2005-10-20 Robert Jordan <robertj@gmx.net>
[mono.git] / mcs / gmcs / iterators.cs
index 6a683d34f32a524c240abb54cd83afdf0a1bdad5..d55efb9c3f1e9374525ac5a0cef12b28b2a5ec68 100644 (file)
@@ -8,7 +8,7 @@
 //
 // TODO:
 //    Flow analysis for Yield.
-//    Emit calls to parent object constructor.
+//    Emit calls to base object constructor.
 //
 // Generics note:
 //    Current should be defined to return T, and IEnumerator.Current returns object
@@ -30,9 +30,9 @@ namespace Mono.CSharp {
        }
        
        public class Yield : Statement {
-               public Expression expr;
-               bool in_exc;
-               
+               Expression expr;
+               ArrayList finally_blocks;
+
                public Yield (Expression expr, Location l)
                {
                        this.expr = expr;
@@ -41,25 +41,32 @@ namespace Mono.CSharp {
 
                public static bool CheckContext (EmitContext ec, Location loc)
                {
-                       if (ec.CurrentBranching.InFinally (true)){
+                       if (ec.InFinally) {
                                Report.Error (1625, loc, "Cannot yield in the body of a " +
                                              "finally clause");
                                return false;
+                       } 
+                       
+                       if (ec.InUnsafe) {
+                               Report.Error (1629, loc, "Unsafe code may not appear in iterators");
+                               return false;
                        }
-                       if (ec.CurrentBranching.InCatch ()){
-                               Report.Error (1631, loc, "Cannot yield in the body of a " +
-                                             "catch clause");
+                       if (ec.InCatch){
+                               Report.Error (1631, loc, "Cannot yield a value in the body of a catch clause");
                                return false;
                        }
-                       if (ec.InAnonymousMethod){
-                               Report.Error (1621, loc, "yield statement can not appear " +
-                                             "inside an anonymoud method");
+
+                       AnonymousContainer am = ec.CurrentAnonymousMethod;
+                       if ((am != null) && !am.IsIterator){
+                               Report.Error (1621, loc, "The yield statement cannot be used inside anonymous method blocks");
                                return false;
                        }
 
-                       //
-                       // FIXME: Missing check for Yield inside try block that contains catch clauses
-                       //
+                       if (ec.CurrentBranching.InTryWithCatch ()) {
+                               Report.Error (1626, loc, "Cannot yield a value in the body of a " +
+                                       "try block with a catch clause");
+                               return false;
+                       }
                        return true;
                }
                
@@ -68,22 +75,26 @@ namespace Mono.CSharp {
                        expr = expr.Resolve (ec);
                        if (expr == null)
                                return false;
+
                        if (!CheckContext (ec, loc))
                                return false;
 
-                       in_exc = ec.CurrentBranching.InTryOrCatch (false);
-                       Type iterator_type = ec.CurrentIterator.IteratorType;
-                       if (expr.Type != iterator_type){
-                               expr = Convert.ImplicitConversionRequired (ec, expr, iterator_type, loc);
+                       Iterator iterator = ec.CurrentIterator;
+
+                       if (expr.Type != iterator.IteratorType){
+                               expr = Convert.ImplicitConversionRequired (
+                                       ec, expr, iterator.IteratorType, loc);
                                if (expr == null)
                                        return false;
                        }
+
+                       ec.CurrentBranching.StealFinallyClauses (ref finally_blocks);
                        return true;
                }
 
                protected override void DoEmit (EmitContext ec)
                {
-                       ec.CurrentIterator.MarkYield (ec, expr, in_exc);
+                       ec.CurrentIterator.MarkYield (ec, expr, finally_blocks);
                }
        }
 
@@ -105,32 +116,41 @@ namespace Mono.CSharp {
 
                protected override void DoEmit (EmitContext ec)
                {
-                       ec.CurrentIterator.EmitYieldBreak (ec.ig, true);
+                       ec.CurrentIterator.EmitYieldBreak (ec.ig);
                }
        }
 
        public class Iterator : Class {
-               Block original_block;
-               Block block;
+               protected ToplevelBlock original_block;
+               protected ToplevelBlock block;
 
-               Type iterator_type;
+               Type original_iterator_type;
                TypeExpr iterator_type_expr;
                bool is_enumerable;
-               bool is_static;
+               public readonly bool IsStatic;
 
                //
                // The state as we generate the iterator
                //
-               ArrayList resume_labels = new ArrayList ();
+               Label move_next_ok, move_next_error;
+               ArrayList resume_points = new ArrayList ();
                int pc;
                
                //
                // Context from the original method
                //
+               GenericMethod generic_method;
                TypeContainer container;
-               Type return_type;
-               Type [] param_types;
+               TypeExpr current_type;
+               Type this_type;
                InternalParameters parameters;
+               InternalParameters original_parameters;
+               IMethodData orig_method;
+
+               MethodInfo dispose_method;
+               MoveNextMethod move_next_method;
+               Constructor ctor;
+               CaptureContext cc;
 
                Expression enumerator_type;
                Expression enumerable_type;
@@ -138,65 +158,147 @@ namespace Mono.CSharp {
                Expression generic_enumerable_type;
                TypeArguments generic_args;
 
+               protected enum State {
+                       Uninitialized   = -2,
+                       After,
+                       Running
+               }
+
                static int proxy_count;
 
-               public void EmitYieldBreak (ILGenerator ig, bool add_return)
+               public void EmitYieldBreak (ILGenerator ig)
                {
                        ig.Emit (OpCodes.Ldarg_0);
-                       IntConstant.EmitInt (ig, -1);
+                       IntConstant.EmitInt (ig, (int) State.After);
                        ig.Emit (OpCodes.Stfld, pc_field.FieldBuilder);
-                       if (add_return){
-                               ig.Emit (OpCodes.Ldc_I4_0);
-                               ig.Emit (OpCodes.Ret);
-                       }
+                       ig.Emit (OpCodes.Br, move_next_error);
                }
 
                public void EmitMoveNext (EmitContext ec)
                {
                        ILGenerator ig = ec.ig;
 
+                       move_next_ok = ig.DefineLabel ();
+                       move_next_error = ig.DefineLabel ();
+
+                       LocalBuilder retval = ec.GetTemporaryLocal (TypeManager.int32_type);
+
+                       ig.BeginExceptionBlock ();
+
                        Label dispatcher = ig.DefineLabel ();
                        ig.Emit (OpCodes.Br, dispatcher);
-                       Label entry_point = ig.DefineLabel ();
-                       ig.MarkLabel (entry_point);
-                       resume_labels.Add (entry_point);
 
-                       ec.EmitTopBlock (original_block, parameters, Location);
+                       ResumePoint entry_point = new ResumePoint (null);
+                       resume_points.Add (entry_point);
+                       entry_point.Define (ig);
+
+                       ec.EmitTopBlock (orig_method, original_block, parameters);
 
-                       EmitYieldBreak (ig, true);
+                       EmitYieldBreak (ig);
 
-                       //
-                       // FIXME: Split the switch in blocks that can be consumed
-                       //        by switch.
-                       //
                        ig.MarkLabel (dispatcher);
 
-                       Label [] labels = new Label [resume_labels.Count];
-                       resume_labels.CopyTo (labels);
+                       Label [] labels = new Label [resume_points.Count];
+                       for (int i = 0; i < labels.Length; i++)
+                               labels [i] = ((ResumePoint) resume_points [i]).Label;
+
                        ig.Emit (OpCodes.Ldarg_0);
                        ig.Emit (OpCodes.Ldfld, pc_field.FieldBuilder);
                        ig.Emit (OpCodes.Switch, labels);
-                       ig.Emit (OpCodes.Ldc_I4_0); 
+
+                       Label end = ig.DefineLabel ();
+
+                       ig.MarkLabel (move_next_error);
+                       ig.Emit (OpCodes.Ldc_I4_0); 
+                       ig.Emit (OpCodes.Stloc, retval);
+                       ig.Emit (OpCodes.Leave, end);
+
+                       ig.MarkLabel (move_next_ok);
+                       ig.Emit (OpCodes.Ldc_I4_1);
+                       ig.Emit (OpCodes.Stloc, retval);
+                       ig.Emit (OpCodes.Leave, end);
+
+                       ig.BeginFaultBlock ();
+
+                       ig.Emit (OpCodes.Ldarg_0);
+                       ig.Emit (OpCodes.Callvirt, dispose_method);
+
+                       ig.EndExceptionBlock ();
+
+                       ig.MarkLabel (end);
+                       ig.Emit (OpCodes.Ldloc, retval);
                        ig.Emit (OpCodes.Ret);
                }
 
-               // 
-               // Invoked when a local variable declaration needs to be mapped to
-               // a field in our proxy class
-               //
-               // Prefixes registered:
-               //   v_   for EmitContext.MapVariable
-               //   s_   for Storage
-               //
-               public FieldBuilder MapVariable (string pfx, string name, Type t)
+               public void EmitDispose (EmitContext ec)
                {
-                       return TypeBuilder.DefineField (pfx + name, t, FieldAttributes.Public);
+                       ILGenerator ig = ec.ig;
+
+                       Label end = ig.DefineLabel ();
+                       Label dispatcher = ig.DefineLabel ();
+                       ig.Emit (OpCodes.Br, dispatcher);
+
+                       Label [] labels = new Label [resume_points.Count];
+                       for (int i = 0; i < labels.Length; i++) {
+                               ResumePoint point = (ResumePoint) resume_points [i];
+
+                               if (point.FinallyBlocks == null) {
+                                       labels [i] = end;
+                                       continue;
+                               }
+
+                               labels [i] = ig.DefineLabel ();
+                               ig.MarkLabel (labels [i]);
+
+                               ig.BeginExceptionBlock ();
+                               ig.BeginFinallyBlock ();
+
+                               foreach (ExceptionStatement stmt in point.FinallyBlocks) {
+                                       if (stmt != null)
+                                               stmt.EmitFinally (ec);
+                               }
+
+                               ig.EndExceptionBlock ();
+                               ig.Emit (OpCodes.Br, end);
+                       }
+
+                       ig.MarkLabel (dispatcher);
+                       ig.Emit (OpCodes.Ldarg_0);
+                       ig.Emit (OpCodes.Ldfld, pc_field.FieldBuilder);
+                       ig.Emit (OpCodes.Switch, labels);
+
+                       ig.Emit (OpCodes.Ldarg_0);
+                       IntConstant.EmitInt (ig, (int) State.After);
+                       ig.Emit (OpCodes.Stfld, pc_field.FieldBuilder);
+
+                       ig.MarkLabel (end);
                }
-               
+
+               protected class ResumePoint
+               {
+                       public Label Label;
+                       public readonly ExceptionStatement[] FinallyBlocks;
+
+                       public ResumePoint (ArrayList list)
+                       {
+                               if (list != null) {
+                                       FinallyBlocks = new ExceptionStatement [list.Count];
+                                       list.CopyTo (FinallyBlocks, 0);
+                               }
+                       }
+
+                       public void Define (ILGenerator ig)
+                       {
+                               Label = ig.DefineLabel ();
+                               ig.MarkLabel (Label);
+                       }
+               }
+
                //
                // Called back from Yield
                //
-               public void MarkYield (EmitContext ec, Expression expr, bool in_exc)
+               public void MarkYield (EmitContext ec, Expression expr,
+                                      ArrayList finally_blocks)
                {
                        ILGenerator ig = ec.ig;
 
@@ -212,84 +314,248 @@ namespace Mono.CSharp {
                        ig.Emit (OpCodes.Stfld, pc_field.FieldBuilder);
 
                        // Return ok
-                       ig.Emit (OpCodes.Ldc_I4_1);
-                       
-                       // Find out how to "leave"
-                       if (in_exc || !ec.IsLastStatement){
-                               Type old = ec.ReturnType;
-                               ec.ReturnType = TypeManager.int32_type;
-                               ig.Emit (OpCodes.Stloc, ec.TemporaryReturn ());
-                               ec.ReturnType = old;
-                       }
-
-                       if (in_exc){
-                               ec.NeedReturnLabel ();
-                               ig.Emit (OpCodes.Leave, ec.ReturnLabel);
-                       } else if (ec.IsLastStatement){
-                               ig.Emit (OpCodes.Ret);
-                       } else {
-                               ec.NeedReturnLabel ();
-                               ig.Emit (OpCodes.Br, ec.ReturnLabel);
-                       }
-                       
-                       Label resume_point = ig.DefineLabel ();
-                       ig.MarkLabel (resume_point);
-                       resume_labels.Add (resume_point);
+                       ig.Emit (OpCodes.Br, move_next_ok);
+
+                       ResumePoint point = new ResumePoint (finally_blocks);
+                       resume_points.Add (point);
+                       point.Define (ig);
+               }
+
+               public void MarkFinally (EmitContext ec, ArrayList finally_blocks)
+               {
+                       ILGenerator ig = ec.ig;
+
+                       // increment pc
+                       pc++;
+                       ig.Emit (OpCodes.Ldarg_0);
+                       IntConstant.EmitInt (ig, pc);
+                       ig.Emit (OpCodes.Stfld, pc_field.FieldBuilder);
+
+                       ResumePoint point = new ResumePoint (finally_blocks);
+                       resume_points.Add (point);
+                       point.Define (ig);
                }
 
-               private static MemberName MakeProxyName (string name)
+               private static MemberName MakeProxyName (string name, GenericMethod generic, Location loc)
                {
                        int pos = name.LastIndexOf ('.');
                        if (pos > 0)
                                name = name.Substring (pos + 1);
 
-                       return new MemberName ("<" + name + ">__" + (proxy_count++));
+                       string proxy_name = "<" + name + ">__" + (proxy_count++);
+
+                       if (generic != null) {
+                               TypeArguments args = new TypeArguments (loc);
+                               foreach (TypeParameter tparam in generic.CurrentTypeParameters)
+                                       args.Add (new SimpleName (tparam.Name, loc));
+                               return new MemberName (proxy_name, args, loc);
+                       } else
+                               return new MemberName (proxy_name, loc);
                }
 
                //
                // Our constructor
                //
-               public Iterator (TypeContainer container, string name, Type return_type,
-                                Type [] param_types, InternalParameters parameters,
-                                int modifiers, Block block, Location loc)
-                       : base (container.NamespaceEntry, container, MakeProxyName (name),
-                               Modifiers.PRIVATE, null, loc)
+               public Iterator (IMethodData m_container, TypeContainer container, GenericMethod generic,
+                                InternalParameters parameters, int modifiers)
+                       : base (container.NamespaceEntry, container,
+                               MakeProxyName (m_container.MethodName.Name, generic, m_container.Location),
+                               (modifiers & Modifiers.UNSAFE) | Modifiers.PRIVATE, null)
                {
+                       this.orig_method = m_container;
+
+                       this.generic_method = generic;
                        this.container = container;
-                       this.return_type = return_type;
-                       this.param_types = param_types;
-                       this.parameters = parameters;
-                       this.original_block = block;
-                       this.block = new Block (null);
+                       this.original_parameters = parameters;
+                       this.original_block = orig_method.Block;
+                       this.block = new ToplevelBlock (orig_method.Block, parameters.Parameters, orig_method.Location);
 
-                       is_static = (modifiers & Modifiers.STATIC) != 0;
+                       if (generic != null) {
+                               ArrayList constraints = new ArrayList ();
+                               foreach (TypeParameter tparam in generic.TypeParameters)
+                                       constraints.Add (tparam.Constraints);
 
-                       container.AddIterator (this);
+                               SetParameterInfo (constraints);
+                       }
+
+                       IsStatic = (modifiers & Modifiers.STATIC) != 0;
+               }
+
+               public AnonymousContainer Host {
+                       get { return move_next_method; }
                }
 
-               public bool Define ()
+               public bool DefineIterator ()
                {
-                       if (!CheckType (return_type)) {
-                               Report.Error (
-                                       1624, Location,
-                                       "The body of `{0}' cannot be an iterator block " +
-                                       "because '{1}' is not an iterator interface type",
-                                       Name, TypeManager.CSharpName (return_type));
+                       ec = new EmitContext (this, Location, null, null, ModFlags);
+                       ec.CurrentAnonymousMethod = move_next_method;
+                       ec.InIterator = true;
+
+                       if (!CheckType ()) {
+                               Report.Error (1624, Location,
+                                       "The body of `{0}' cannot be an iterator block because `{1}' is not an iterator interface type",
+                                       orig_method.GetSignatureForError (), TypeManager.CSharpName (orig_method.ReturnType));
                                return false;
                        }
 
-                       for (int i = 0; i < parameters.Count; i++){
-                               Parameter.Modifier mod = parameters.ParameterModifier (i);
+                       for (int i = 0; i < original_parameters.Count; i++){
+                               Parameter.Modifier mod = original_parameters.ParameterModifier (i);
                                if ((mod & (Parameter.Modifier.REF | Parameter.Modifier.OUT)) != 0){
                                        Report.Error (
                                                1623, Location,
                                                "Iterators cannot have ref or out parameters");
                                        return false;
                                }
+
+                               if ((mod & Parameter.Modifier.ARGLIST) != 0) {
+                                       Report.Error (1636, Location, "__arglist is not allowed in parameter list of iterators");
+                                       return false;
+                               }
+
+                               if (original_parameters.ParameterType (i).IsPointer) {
+                                       Report.Error (1637, Location, "Iterators cannot have unsafe parameters or yield types");
+                                       return false;
+                               }
+                       }
+
+                       if (container.CurrentType != null)
+                               this_type = container.CurrentType;
+                       else
+                               this_type = container.TypeBuilder;
+
+                       container.AddIterator (this);
+
+                       orig_method.Block = block;
+                       return true;
+               }
+
+               MethodInfo FetchMethodDispose ()
+               {
+                       MemberList dispose_list;
+
+                       dispose_list = FindMembers (
+                               current_type.Type,
+                               MemberTypes.Method, BindingFlags.Public | BindingFlags.Instance,
+                               Type.FilterName, "Dispose");
+
+                       if (dispose_list.Count != 1)
+                               throw new InternalErrorException ("Cannot find Dipose() method.");
+
+                       return (MethodInfo) dispose_list [0];
+               }
+
+               protected override bool DoDefineMembers ()
+               {
+                       ec.InIterator = true;
+                       ec.CurrentAnonymousMethod = move_next_method;
+                       ec.capture_context = cc;
+
+                       if (!base.DoDefineMembers ())
+                               return false;
+
+                       dispose_method = FetchMethodDispose ();
+                       if (dispose_method == null)
+                               return false;
+
+                       return true;
+               }
+
+               public override bool Define ()
+               {
+                       if (!base.Define ())
+                               return false;
+
+                       ec.InIterator = true;
+                       ec.CurrentAnonymousMethod = move_next_method;
+                       ec.capture_context = cc;
+
+                       ec.TypeContainer = ec.TypeContainer.Parent;
+
+                       if (ec.TypeContainer.CurrentType != null)
+                               ec.ContainerType = ec.TypeContainer.CurrentType;
+                       else
+                               ec.ContainerType = ec.TypeContainer.TypeBuilder;
+
+                       ec.ig = move_next_method.method.MethodBuilder.GetILGenerator ();
+
+                       if (!ctor.Define ())
+                               return false;
+
+                       bool unreachable;
+
+                       if (!ec.ResolveTopBlock (null, original_block, parameters, orig_method, out unreachable))
+                               return false;
+
+                       if (!ec.ResolveTopBlock (null, block, parameters, orig_method, out unreachable))
+                               return false;
+
+                       original_block.CompleteContexts ();
+
+                       cc.EmitAnonymousHelperClasses (ec);
+
+                       return true;
+               }
+
+               TypeExpr InflateType (Type it)
+               {
+                       if (generic_method == null)
+                               return new TypeExpression (it, Location);
+
+                       if (it.IsGenericParameter && (it.DeclaringMethod != null)) {
+                               int pos = it.GenericParameterPosition;
+                               it = CurrentTypeParameters [pos].Type;
+                       } else if (it.IsGenericInstance) {
+                               Type[] args = it.GetGenericArguments ();
+
+                               TypeArguments inflated = new TypeArguments (Location);
+                               foreach (Type t in args)
+                                       inflated.Add (InflateType (t));
+
+                               return new ConstructedType (it, inflated, Location);
+                       } else if (it.IsArray) {
+                               TypeExpr et_expr = InflateType (it.GetElementType ());
+                               int rank = it.GetArrayRank ();
+
+                               Type et = et_expr.ResolveAsTypeTerminal (ec).Type;
+                               it = et.MakeArrayType (rank);
+                       }
+
+                       return new TypeExpression (it, Location);
+               }
+
+               Parameter InflateParameter (Parameter param)
+               {
+                       TypeExpr te = InflateType (param.ParameterType);
+                       return new Parameter (
+                               te, param.Name, param.ModFlags, param.OptAttributes, param.Location);
+               }
+
+               InternalParameters InflateParameters (Parameters parameters, EmitContext ec)
+               {
+                       Parameter[] fixed_params = null;
+                       if (parameters.FixedParameters != null) {
+                               fixed_params = new Parameter [parameters.FixedParameters.Length];
+                               for (int i = 0; i < fixed_params.Length; i++)
+                                       fixed_params [i] = InflateParameter (parameters.FixedParameters [i]);
                        }
 
+                       Parameters new_params;
+                       if (parameters.ArrayParameter != null) {
+                               Parameter array_param = InflateParameter (parameters.ArrayParameter);
+                               new_params = new Parameters (fixed_params, array_param);
+                       } else
+                               new_params = new Parameters (fixed_params, parameters.HasArglist);
+
+                       Type [] types = new_params.GetParameterInfo (ec);
+                       return new InternalParameters (types, new_params);
+               }
+
+               protected override TypeExpr [] GetClassBases (out TypeExpr base_class)
+               {
+                       iterator_type_expr = InflateType (original_iterator_type);
+
                        generic_args = new TypeArguments (Location);
-                       generic_args.Add (new TypeExpression (iterator_type, Location));
+                       generic_args.Add (iterator_type_expr);
 
                        ArrayList list = new ArrayList ();
                        if (is_enumerable) {
@@ -314,156 +580,151 @@ namespace Mono.CSharp {
                                generic_args, Location);
                        list.Add (generic_enumerator_type);
 
-                       iterator_type_expr = new TypeExpression (iterator_type, Location);
-
                        Bases = list;
-                       return true;
+
+                       return base.GetClassBases (out base_class);
                }
 
                //
                // Returns the new block for the method, or null on failure
                //
-               protected override bool DoDefineType ()
+               protected override bool DefineNestedTypes ()
                {
+                       if (CurrentType != null)
+                               current_type = new TypeExpression (CurrentType, Location);
+                       else
+                               current_type = new TypeExpression (TypeBuilder, Location);
+
+                       parameters = InflateParameters (original_parameters.Parameters, ec);
+
                        Define_Fields ();
-                       Define_Constructor ();
                        Define_Current (false);
                        Define_Current (true);
                        Define_MoveNext ();
                        Define_Reset ();
                        Define_Dispose ();
 
+                       Define_Constructor ();
+
+                       Create_Block ();
+
                        if (is_enumerable) {
                                Define_GetEnumerator (false);
                                Define_GetEnumerator (true);
                        }
 
-                       Create_Block ();
-
-                       return true;
+                       return base.DefineNestedTypes ();
                }
 
-
                Field pc_field;
                Field current_field;
-               public Field this_field;
-               public Field[] parameter_fields;
+               Method dispose;
 
                void Create_Block ()
                {
-                       int first = is_static ? 0 : 1;
+                       original_block.SetHaveAnonymousMethods (Location, move_next_method);
+                       block.SetHaveAnonymousMethods (Location, move_next_method);
+
+                       cc = original_block.CaptureContext;
+
+                       int first = IsStatic ? 0 : 1;
 
                        ArrayList args = new ArrayList ();
-                       if (!is_static) {
-                               Type t = container.TypeBuilder;
+                       if (!IsStatic) {
+                               Type t = this_type;
                                args.Add (new Argument (
-                                       new SimpleParameterReference (t, 0, Location),
-                                       Argument.AType.Expression));
+                                       new ThisParameterReference (t, Location)));
+                               cc.CaptureThis (move_next_method);
                        }
 
+                       args.Add (new Argument (new BoolLiteral (false, Location)));
+
                        for (int i = 0; i < parameters.Count; i++) {
-                               Type t = parameters.ParameterType (i);
+                               Type t = original_parameters.ParameterType (i);
+                               Type inflated = parameters.ParameterType (i);
+                               string name = parameters.ParameterName (i);
+
                                args.Add (new Argument (
-                                       new SimpleParameterReference (t, first + i, Location),
-                                       Argument.AType.Expression));
+                                       new SimpleParameterReference (t, first + i, Location)));
+
+                               cc.AddParameterToContext (move_next_method, name, inflated, first + i);
                        }
 
-                       Expression new_expr = new New (
-                               new TypeExpression (TypeBuilder, Location), args, Location);
+                       TypeExpr proxy_type;
+                       if (generic_method != null) {
+                               TypeArguments new_args = new TypeArguments (Location);
+                               if (Parent.IsGeneric) {
+                                       foreach (TypeParameter tparam in Parent.TypeParameters)
+                                               new_args.Add (new TypeParameterExpr (tparam, Location));
+                               }
+                               foreach (TypeParameter tparam in generic_method.TypeParameters)
+                                       new_args.Add (new TypeParameterExpr (tparam, Location));
+                               ConstructedType ct = new ConstructedType (CurrentType, new_args, Location);
+                               proxy_type = ct.ResolveAsTypeTerminal (ec);
+                       } else
+                               proxy_type = current_type;
 
+                       Expression new_expr = new New (proxy_type, args, Location);
                        block.AddStatement (new NoCheckReturn (new_expr, Location));
                }
 
                void Define_Fields ()
                {
-                       Location loc = Location.Null;
-
                        pc_field = new Field (
-                               TypeManager.system_int32_expr, Modifiers.PRIVATE, "PC",
-                               null, null, loc);
+                               this, TypeManager.system_int32_expr, Modifiers.PRIVATE, "$PC",
+                               null, null, Location);
                        AddField (pc_field);
 
                        current_field = new Field (
-                               iterator_type_expr, Modifiers.PRIVATE, "current",
-                               null, null, loc);
+                               this, iterator_type_expr, Modifiers.PRIVATE, "$current",
+                               null, null, Location);
                        AddField (current_field);
-
-                       if (!is_static) {
-                               this_field = new Field (
-                                       new TypeExpression (container.TypeBuilder, Location),
-                                       Modifiers.PRIVATE, "this", null, null, loc);
-                               AddField (this_field);
-                       }
-
-                       parameter_fields = new Field [parameters.Count];
-                       for (int i = 0; i < parameters.Count; i++) {
-                               string fname = String.Format (
-                                       "field{0}_{1}", i, parameters.ParameterName (i));
-
-                               parameter_fields [i] = new Field (
-                                       new TypeExpression (parameters.ParameterType (i), loc),
-                                       Modifiers.PRIVATE, fname, null, null, loc);
-                               AddField (parameter_fields [i]);
-                       }
                }
 
                void Define_Constructor ()
                {
                        Parameters ctor_params;
 
-                       if (!is_static) {
-                               Parameter this_param = new Parameter (
-                                       new TypeExpression (container.TypeBuilder, Location),
-                                       "this", Parameter.Modifier.NONE, null);
-
-                               Parameter[] old_fixed = parameters.Parameters.FixedParameters;
-                               Parameter[] fixed_params;
-                               if (old_fixed != null) {
-                                       fixed_params = new Parameter [old_fixed.Length + 1];
-                                       old_fixed.CopyTo (fixed_params, 1);
-                               } else {
-                                       fixed_params = new Parameter [1];
-                               }
-                               fixed_params [0] = this_param;
+                       ArrayList list = new ArrayList ();
 
-                               ctor_params = new Parameters (
-                                       fixed_params, parameters.Parameters.ArrayParameter,
-                                       Location);
-                       } else
-                               ctor_params = parameters.Parameters;
+                       if (!IsStatic)
+                               list.Add (new Parameter (
+                                       new TypeExpression (this_type, Location),
+                                       "this", Parameter.Modifier.NONE,
+                                       null, Location));
+                       list.Add (new Parameter (
+                               TypeManager.system_boolean_expr, "initialized",
+                               Parameter.Modifier.NONE, null, Location));
 
-                       Constructor ctor = new Constructor (
-                               this, Name, Modifiers.PUBLIC, ctor_params,
-                               new ConstructorBaseInitializer (
-                                       null, Parameters.EmptyReadOnlyParameters, Location),
-                               Location);
-                       AddConstructor (ctor);
+                       Parameter[] old_fixed = parameters.Parameters.FixedParameters;
+                       if (old_fixed != null)
+                               list.AddRange (old_fixed);
 
-                       Block block = ctor.Block = new Block (null);
+                       Parameter[] fixed_params = new Parameter [list.Count];
+                       list.CopyTo (fixed_params);
 
-                       if (!is_static) {
-                               Type t = container.TypeBuilder;
+                       ctor_params = new Parameters (fixed_params, parameters.Parameters.ArrayParameter);
 
-                               Assign assign = new Assign (
-                                       new FieldExpression (this_field),
-                                       new SimpleParameterReference (t, 1, Location),
-                                       Location);
+                       ctor = new Constructor (
+                               this, MemberName.Name, Modifiers.PUBLIC, ctor_params,
+                               new GeneratedBaseInitializer (Location),
+                               Location);
+                       AddConstructor (ctor);
 
-                               block.AddStatement (new StatementExpression (assign, Location));
-                       }
+                       ctor.Block = new ToplevelBlock (block, parameters.Parameters, Location);
 
-                       int first = is_static ? 1 : 2;
+                       int first = IsStatic ? 2 : 3;
 
-                       for (int i = 0; i < parameters.Count; i++) {
-                               Type t = parameters.ParameterType (i);
+                       State initial = is_enumerable ? State.Uninitialized : State.Running;
+                       ctor.Block.AddStatement (new SetState (this, initial, Location));
 
-                               Assign assign = new Assign (
-                                       new FieldExpression (parameter_fields [i]),
-                                       new SimpleParameterReference (t, first + i, Location),
-                                       Location);
+                       ctor.Block.AddStatement (new If (
+                               new SimpleParameterReference (
+                                       TypeManager.bool_type, first - 1, Location),
+                               new SetState (this, State.Running, Location),
+                               Location));
 
-                               block.AddStatement (new StatementExpression (assign, Location));
-                       }
+                       ctor.Block.AddStatement (new InitScope (this, Location));
                }
 
                Statement Create_ThrowInvalidOperation ()
@@ -489,47 +750,44 @@ namespace Mono.CSharp {
                        if (is_generic) {
                                left = new MemberName (
                                        "System.Collections.Generic.IEnumerator",
-                                       generic_args);
+                                       generic_args, Location);
                                type = iterator_type_expr;
                        } else {
-                               left = new MemberName ("System.Collections.IEnumerator");
+                               left = new MemberName ("System.Collections.IEnumerator", Location);
                                type = TypeManager.system_object_expr;
                        }
 
-                       MemberName name = new MemberName (left, "Current", null);
+                       MemberName name = new MemberName (left, "Current", null, Location);
 
-                       Block get_block = new Block (null);
+                       ToplevelBlock get_block = new ToplevelBlock (
+                               block, parameters.Parameters, Location);
 
                        get_block.AddStatement (new If (
                                new Binary (
                                        Binary.Operator.LessThanOrEqual,
-                                       new FieldExpression (pc_field),
-                                       new IntLiteral (0), Location),
+                                       new FieldExpression (this, pc_field),
+                                       new IntLiteral ((int) State.Running, pc_field.Location)),
                                Create_ThrowInvalidOperation (),
                                new Return (
-                                       new FieldExpression (current_field), Location),
+                                       new FieldExpression (this, current_field), Location),
                                Location));
 
-                       Accessor getter = new Accessor (get_block, null);
+                       Accessor getter = new Accessor (get_block, 0, null, Location);
 
                        Property current = new Property (
-                               this, type, 0, false, name, null, getter, null, Location);
+                               this, type, 0, false, name, null, getter, null);
                        AddProperty (current);
                }
 
                void Define_MoveNext ()
                {
-                       Method move_next = new Method (
-                               this, TypeManager.system_boolean_expr,
-                               Modifiers.PUBLIC, false, new MemberName ("MoveNext"),
-                               Parameters.EmptyReadOnlyParameters, null,
-                               Location.Null);
-                       AddMethod (move_next);
+                       move_next_method = new MoveNextMethod (this, Location);
+
+                       original_block.ReParent (block, move_next_method);
 
-                       Block block = move_next.Block = new Block (null);
+                       move_next_method.CreateMethod (ec);
 
-                       MoveNextMethod inline = new MoveNextMethod (this, Location);
-                       block.AddStatement (inline);
+                       AddMethod (move_next_method.method);
                }
 
                void Define_GetEnumerator (bool is_generic)
@@ -539,25 +797,63 @@ namespace Mono.CSharp {
                        if (is_generic) {
                                left = new MemberName (
                                        "System.Collections.Generic.IEnumerable",
-                                       generic_args);
+                                       generic_args, Location);
                                type = generic_enumerator_type;
                        } else {
-                               left = new MemberName ("System.Collections.IEnumerable");
+                               left = new MemberName ("System.Collections.IEnumerable", Location);
                                type = enumerator_type;
                        }
 
-                       MemberName name = new MemberName (left, "GetEnumerator", null);
+                       MemberName name = new MemberName (left, "GetEnumerator", Location);
 
                        Method get_enumerator = new Method (
-                               this, type, 0, false, name,
-                               Parameters.EmptyReadOnlyParameters, null,
-                               Location.Null);
+                               this, null, type, 0, false, name,
+                               Parameters.EmptyReadOnlyParameters, null);
                        AddMethod (get_enumerator);
 
-                       get_enumerator.Block = new Block (null);
+                       get_enumerator.Block = new ToplevelBlock (
+                               block, parameters.Parameters, Location);
+
+                       get_enumerator.Block.SetHaveAnonymousMethods (Location, move_next_method);
+
+                       Expression ce = new MemberAccess (
+                               new SimpleName ("System.Threading.Interlocked", Location),
+                               "CompareExchange", Location);
+
+                       Expression pc = new FieldExpression (this, pc_field);
+                       Expression before = new IntLiteral ((int) State.Running, Location);
+                       Expression uninitialized = new IntLiteral ((int) State.Uninitialized, Location);
+
+                       ArrayList args = new ArrayList ();
+                       args.Add (new Argument (pc, Argument.AType.Ref));
+                       args.Add (new Argument (before, Argument.AType.Expression));
+                       args.Add (new Argument (uninitialized, Argument.AType.Expression));
+
+                       get_enumerator.Block.AddStatement (new If (
+                               new Binary (
+                                       Binary.Operator.Equality,
+                                       new Invocation (ce, args),
+                                       uninitialized),
+                               new Return (new ThisParameterReference (type.Type, Location),
+                                           Location),
+                               Location));
+
+                       args = new ArrayList ();
+                       if (!IsStatic) {
+                               args.Add (new Argument (new CapturedThisReference (this, Location)));
+                       }
+
+                       args.Add (new Argument (new BoolLiteral (true, Location)));
+
+                       for (int i = 0; i < parameters.Count; i++) {
+                               Expression cp = new CapturedParameterReference (
+                                       this, parameters.ParameterType (i),
+                                       parameters.ParameterName (i), Location);
+                               args.Add (new Argument (cp));
+                       }
 
-                       This the_this = new This (block, Location);
-                       get_enumerator.Block.AddStatement (new Return (the_this, Location));
+                       Expression new_expr = new New (current_type, args, Location);
+                       get_enumerator.Block.AddStatement (new Return (new_expr, Location));
                }
 
                protected class SimpleParameterReference : Expression
@@ -578,24 +874,111 @@ namespace Mono.CSharp {
                        }
 
                        public override void Emit (EmitContext ec)
+                       {
+                               DoEmit (ec);
+                       }
+
+                       protected virtual void DoEmit (EmitContext ec)
                        {
                                ParameterReference.EmitLdArg (ec.ig, idx);
                        }
                }
 
+               protected class ThisParameterReference : SimpleParameterReference, IMemoryLocation
+               {
+                       public ThisParameterReference (Type type, Location loc)
+                               : base (type, 0, loc)
+                       { }
+
+                       protected override void DoEmit (EmitContext ec)
+                       {
+                               base.DoEmit (ec);
+                               if (ec.TypeContainer is Struct)
+                                       ec.ig.Emit (OpCodes.Ldobj, type);
+                       }
+
+                       public void AddressOf (EmitContext ec, AddressOp mode)
+                       {
+                               if (ec.TypeContainer is Struct)
+                                       ec.ig.Emit (OpCodes.Ldarga, 0);
+                               else
+                                       ec.ig.Emit (OpCodes.Ldarg, 0);
+                       }
+               }
+
+               protected class CapturedParameterReference : Expression
+               {
+                       Iterator iterator;
+                       string name;
+
+                       public CapturedParameterReference (Iterator iterator, Type type,
+                                                          string name, Location loc)
+                       {
+                               this.iterator = iterator;
+                               this.loc = loc;
+                               this.type = type;
+                               this.name = name;
+                               eclass = ExprClass.Variable;
+                       }
+
+                       public override Expression DoResolve (EmitContext ec)
+                       {
+                               return this;
+                       }
+
+                       public override void Emit (EmitContext ec)
+                       {
+                               ec.CurrentAnonymousMethod = iterator.move_next_method;
+
+                               iterator.cc.EmitParameter (ec, name);
+                       }
+               }
+
+               protected class CapturedThisReference : Expression
+               {
+                       public CapturedThisReference (Iterator iterator, Location loc)
+                       {
+                               this.loc = loc;
+                               this.type = iterator.this_type;
+                               eclass = ExprClass.Variable;
+                       }
+
+                       public override Expression DoResolve (EmitContext ec)
+                       {
+                               return this;
+                       }
+
+                       public override void Emit (EmitContext ec)
+                       {
+                               ec.EmitThis ();
+                       }
+               }
+
                protected class FieldExpression : Expression
                {
+                       Iterator iterator;
                        Field field;
 
-                       public FieldExpression (Field field)
+                       public FieldExpression (Iterator iterator, Field field)
                        {
+                               this.iterator = iterator;
                                this.field = field;
+                               this.loc = iterator.Location;
+                       }
+
+                       public override Expression DoResolveLValue (EmitContext ec, Expression right_side)
+                       {
+                               FieldExpr fexpr = new FieldExpr (field.FieldBuilder, loc);
+                               fexpr.InstanceExpression = new ThisParameterReference (
+                                       iterator.this_type, loc);
+                               return fexpr.ResolveLValue (ec, right_side, loc);
                        }
 
                        public override Expression DoResolve (EmitContext ec)
                        {
                                FieldExpr fexpr = new FieldExpr (field.FieldBuilder, loc);
-                               fexpr.InstanceExpression = ec.GetThis (loc);
+                               fexpr.InstanceExpression = new ThisParameterReference (
+                                       iterator.this_type, loc);
                                return fexpr.Resolve (ec);
                        }
 
@@ -605,10 +988,60 @@ namespace Mono.CSharp {
                        }
                }
 
-               public class MoveNextMethod : Statement {
+               protected class MoveNextMethod : AnonymousContainer
+               {
                        Iterator iterator;
 
                        public MoveNextMethod (Iterator iterator, Location loc)
+                               : base (iterator.parameters.Parameters, iterator.original_block, loc)
+                       {
+                               this.iterator = iterator;
+                       }
+
+                       protected override bool CreateMethodHost (EmitContext ec)
+                       {
+                               method = new Method (
+                                       iterator, null, TypeManager.system_boolean_expr,
+                                       Modifiers.PUBLIC, false, new MemberName ("MoveNext", loc),
+                                       Parameters.EmptyReadOnlyParameters, null);
+
+                               method.Block = Block;
+
+                               MoveNextStatement inline = new MoveNextStatement (iterator, loc);
+                               Block.AddStatement (inline);
+
+                               return true;
+                       }
+
+                       public bool CreateMethod (EmitContext ec)
+                       {
+                               return CreateMethodHost (ec);
+                       }
+
+                       public override Iterator Iterator {
+                               get { return iterator; }
+                       }
+
+                       public override bool IsIterator {
+                               get { return true; }
+                       }
+
+                       public override void CreateScopeType (EmitContext ec, ScopeInfo scope)
+                       {
+                               scope.ScopeTypeBuilder = iterator.TypeBuilder;
+                               scope.ScopeConstructor = iterator.ctor.ConstructorBuilder;
+                       }
+
+                       public override void Emit (EmitContext ec)
+                       {
+                               throw new InternalErrorException ();
+                       }
+               }
+
+               protected class MoveNextStatement : Statement {
+                       Iterator iterator;
+
+                       public MoveNextStatement (Iterator iterator, Location loc)
                        {
                                this.loc = loc;
                                this.iterator = iterator;
@@ -616,130 +1049,208 @@ namespace Mono.CSharp {
 
                        public override bool Resolve (EmitContext ec)
                        {
-                               ec.CurrentBranching.CurrentUsageVector.Return ();
                                return true;
                        }
 
                        protected override void DoEmit (EmitContext ec)
                        {
-                               int code_flags = Modifiers.METHOD_YIELDS;
-                               if (iterator.is_static)
-                                       code_flags |= Modifiers.STATIC;
+                               ec.CurrentAnonymousMethod = iterator.move_next_method;
+                               ec.InIterator = true;
+
+                               iterator.EmitMoveNext (ec);
+                       }
+               }
+
+               protected class DisposeMethod : Statement {
+                       Iterator iterator;
+
+                       public DisposeMethod (Iterator iterator, Location loc)
+                       {
+                               this.loc = loc;
+                               this.iterator = iterator;
+                       }
+
+                       public override bool Resolve (EmitContext ec)
+                       {
+                               return true;
+                       }
+
+                       protected override void DoEmit (EmitContext ec)
+                       {
+                               iterator.EmitDispose (ec);
+                       }
+               }
+
+               protected class StatementList : Statement {
+                       ArrayList statements;
+
+                       public StatementList (Location loc)
+                       {
+                               this.loc = loc;
+                               statements = new ArrayList ();
+                       }
+
+                       public void Add (Statement statement)
+                       {
+                               statements.Add (statement);
+                       }
+
+                       public override bool Resolve (EmitContext ec)
+                       {
+                               foreach (Statement stmt in statements) {
+                                       if (!stmt.Resolve (ec))
+                                               return false;
+                               }
+
+                               return true;
+                       }
+
+                       protected override void DoEmit (EmitContext ec)
+                       {
+                               foreach (Statement stmt in statements)
+                                       stmt.Emit (ec);
+                       }
+               }
 
-                               EmitContext new_ec = new EmitContext (
-                                       iterator.container, loc, ec.ig,
-                                       iterator.return_type, code_flags);
+               protected class SetState : Statement
+               {
+                       Iterator iterator;
+                       State state;
 
-                               new_ec.CurrentIterator = iterator;
+                       public SetState (Iterator iterator, State state, Location loc)
+                       {
+                               this.iterator = iterator;
+                               this.state = state;
+                               this.loc = loc;
+                       }
 
-                               iterator.EmitMoveNext (new_ec);
+                       public override bool Resolve (EmitContext ec)
+                       {
+                               return true;
+                       }
+
+                       protected override void DoEmit (EmitContext ec)
+                       {
+                               ec.ig.Emit (OpCodes.Ldarg_0);
+                               IntConstant.EmitInt (ec.ig, (int) state);
+                               ec.ig.Emit (OpCodes.Stfld, iterator.pc_field.FieldBuilder);
                        }
                }
 
-               protected class DoYieldBreak : Statement
+               protected class InitScope : Statement
                {
                        Iterator iterator;
-                       bool add_return;
 
-                       public DoYieldBreak (Iterator iterator, bool add_return,
-                                            Location loc)
+                       public InitScope (Iterator iterator, Location loc)
                        {
                                this.iterator = iterator;
-                               this.add_return = add_return;
                                this.loc = loc;
                        }
 
                        public override bool Resolve (EmitContext ec)
                        {
-                               if (add_return)
-                                       ec.CurrentBranching.CurrentUsageVector.Return ();
                                return true;
                        }
 
                        protected override void DoEmit (EmitContext ec)
                        {
-                              iterator.EmitYieldBreak (ec.ig, add_return);
+                               iterator.cc.EmitInitScope (ec);
                        }
                }
 
                void Define_Reset ()
                {
                        Method reset = new Method (
-                               this, TypeManager.system_void_expr, Modifiers.PUBLIC,
-                               false, new MemberName ("Reset"),
-                               Parameters.EmptyReadOnlyParameters, null, Location);
+                               this, null, TypeManager.system_void_expr, Modifiers.PUBLIC,
+                               false, new MemberName ("Reset", Location),
+                               Parameters.EmptyReadOnlyParameters, null);
                        AddMethod (reset);
 
-                       reset.Block = new Block (null);
+                       reset.Block = new ToplevelBlock (Location);
+                       reset.Block = new ToplevelBlock (block, parameters.Parameters, Location);
+                       reset.Block.SetHaveAnonymousMethods (Location, move_next_method);
+
                        reset.Block.AddStatement (Create_ThrowNotSupported ());
                }
 
                void Define_Dispose ()
                {
-                       Method dispose = new Method (
-                               this, TypeManager.system_void_expr, Modifiers.PUBLIC,
-                               false, new MemberName ("Dispose"),
-                               Parameters.EmptyReadOnlyParameters, null, Location);
+                       dispose = new Method (
+                               this, null, TypeManager.system_void_expr, Modifiers.PUBLIC,
+                               false, new MemberName ("Dispose", Location),
+                               Parameters.EmptyReadOnlyParameters, null);
                        AddMethod (dispose);
 
-                       dispose.Block = new Block (null);
-                       dispose.Block.AddStatement (new DoYieldBreak (this, false, Location));
-                       dispose.Block.AddStatement (new Return (null, Location));
-               }
+                       dispose.Block = new ToplevelBlock (block, parameters.Parameters, Location);
+                       dispose.Block.SetHaveAnonymousMethods (Location, move_next_method);
 
-               public Block Block {
-                       get { return block; }
+                       dispose.Block.AddStatement (new DisposeMethod (this, Location));
                }
 
                public Type IteratorType {
-                       get { return iterator_type; }
+                       get { return iterator_type_expr.Type; }
                }
 
                //
                // This return statement tricks return into not flagging an error for being
                // used in a Yields method
                //
-               class NoCheckReturn : Return {
-                       public NoCheckReturn (Expression expr, Location loc) : base (expr, loc)
+               class NoCheckReturn : Statement {
+                       public Expression Expr;
+               
+                       public NoCheckReturn (Expression expr, Location l)
                        {
+                               Expr = expr;
+                               loc = l;
                        }
 
                        public override bool Resolve (EmitContext ec)
                        {
-                               ec.InIterator = false;
-                               bool ret_val = base.Resolve (ec);
-                               ec.InIterator = true;
+                               Expr = Expr.Resolve (ec);
+                               if (Expr == null)
+                                       return false;
+
+                               ec.CurrentBranching.CurrentUsageVector.Return ();
 
-                               return ret_val;
+                               return true;
+                       }
+
+                       protected override void DoEmit (EmitContext ec)
+                       {
+                               Expr.Emit (ec);
+                               ec.ig.Emit (OpCodes.Ret);
                        }
                }
 
-               bool CheckType (Type t)
+               bool CheckType ()
                {
-                       if (t == TypeManager.ienumerable_type) {
-                               iterator_type = TypeManager.object_type;
+                       Type ret = orig_method.ReturnType;
+
+                       if (ret == TypeManager.ienumerable_type) {
+                               original_iterator_type = TypeManager.object_type;
                                is_enumerable = true;
                                return true;
-                       } else if (t == TypeManager.ienumerator_type) {
-                               iterator_type = TypeManager.object_type;
+                       }
+                       if (ret == TypeManager.ienumerator_type) {
+                               original_iterator_type = TypeManager.object_type;
                                is_enumerable = false;
                                return true;
                        }
 
-                       if (!t.IsGenericInstance)
+                       if (!ret.IsGenericInstance)
                                return false;
 
-                       Type[] args = TypeManager.GetTypeArguments (t);
+                       Type[] args = TypeManager.GetTypeArguments (ret);
                        if (args.Length != 1)
                                return false;
 
-                       Type gt = t.GetGenericTypeDefinition ();
+                       Type gt = ret.GetGenericTypeDefinition ();
                        if (gt == TypeManager.generic_ienumerable_type) {
-                               iterator_type = args [0];
+                               original_iterator_type = args [0];
                                is_enumerable = true;
                                return true;
                        } else if (gt == TypeManager.generic_ienumerator_type) {
-                               iterator_type = args [0];
+                               original_iterator_type = args [0];
                                is_enumerable = false;
                                return true;
                        }