* generic.cs (DropGenericTypeArguments): New. Captures the common
[mono.git] / mcs / gmcs / generic.cs
index 90010bb2616c1c8f3a63656377c77a639ba00464..e938019b20b78863e1daec5f84f8718d9579ede7 100644 (file)
@@ -19,7 +19,15 @@ using System.Text.RegularExpressions;
        
 namespace Mono.CSharp {
 
+       /// <summary>
+       ///   Abstract base class for type parameter constraints.
+       ///   The type parameter can come from a generic type definition or from reflection.
+       /// </summary>
        public abstract class GenericConstraints {
+               public abstract string TypeParameter {
+                       get;
+               }
+
                public abstract GenericParameterAttributes Attributes {
                        get;
                }
@@ -122,9 +130,9 @@ namespace Mono.CSharp {
                ValueType
        }
 
-       //
-       // Tracks the constraints for a type parameter
-       //
+       /// <summary>
+       ///   Tracks the constraints for a type parameter from a generic type definition.
+       /// </summary>
        public class Constraints : GenericConstraints {
                string name;
                ArrayList constraints;
@@ -142,7 +150,7 @@ namespace Mono.CSharp {
                        this.loc = loc;
                }
 
-               public string TypeParameter {
+               public override string TypeParameter {
                        get {
                                return name;
                        }
@@ -157,7 +165,12 @@ namespace Mono.CSharp {
                Type[] iface_constraint_types;
                Type effective_base_type;
                bool resolved;
+               bool resolved_types;
 
+               /// <summary>
+               ///   Resolve the constraints - but only resolve things into Expression's, not
+               ///   into actual types.
+               /// </summary>
                public bool Resolve (EmitContext ec)
                {
                        if (resolved)
@@ -210,7 +223,7 @@ namespace Mono.CSharp {
                                        if (errors != Report.Errors)
                                                return false;
 
-                                       Report.Error (246, loc, "Cannot find type '{0}'", obj);
+                                       Report.Error (246, loc, "Cannot find type '{0}'", ((Expression) obj).GetSignatureForError ());
                                        return false;
                                }
 
@@ -224,7 +237,7 @@ namespace Mono.CSharp {
                                } else
                                        expr = fn.ResolveAsTypeTerminal (ec);
 
-                               if (expr == null)
+                               if ((expr == null) || (expr.Type == null))
                                        return false;
 
                                TypeParameterExpr texpr = expr as TypeParameterExpr;
@@ -249,6 +262,71 @@ namespace Mono.CSharp {
                                num_constraints++;
                        }
 
+                       ArrayList list = new ArrayList ();
+                       foreach (TypeExpr iface_constraint in iface_constraints) {
+                               foreach (Type type in list) {
+                                       if (!type.Equals (iface_constraint.Type))
+                                               continue;
+
+                                       Report.Error (405, loc,
+                                                     "Duplicate constraint `{0}' for type " +
+                                                     "parameter `{1}'.", iface_constraint.GetSignatureForError (),
+                                                     name);
+                                       return false;
+                               }
+
+                               list.Add (iface_constraint.Type);
+                       }
+
+                       foreach (TypeParameterExpr expr in type_param_constraints) {
+                               foreach (Type type in list) {
+                                       if (!type.Equals (expr.Type))
+                                               continue;
+
+                                       Report.Error (405, loc,
+                                                     "Duplicate constraint `{0}' for type " +
+                                                     "parameter `{1}'.", expr.GetSignatureForError (), name);
+                                       return false;
+                               }
+
+                               list.Add (expr.Type);
+                       }
+
+                       iface_constraint_types = new Type [list.Count];
+                       list.CopyTo (iface_constraint_types, 0);
+
+                       if (class_constraint != null) {
+                               class_constraint_type = class_constraint.Type;
+                               if (class_constraint_type == null)
+                                       return false;
+
+                               if (class_constraint_type.IsSealed) {
+                                       Report.Error (701, loc,
+                                                     "`{0}' is not a valid bound.  Bounds " +
+                                                     "must be interfaces or non sealed " +
+                                                     "classes", TypeManager.CSharpName (class_constraint_type));
+                                       return false;
+                               }
+
+                               if ((class_constraint_type == TypeManager.array_type) ||
+                                   (class_constraint_type == TypeManager.delegate_type) ||
+                                   (class_constraint_type == TypeManager.enum_type) ||
+                                   (class_constraint_type == TypeManager.value_type) ||
+                                   (class_constraint_type == TypeManager.object_type)) {
+                                       Report.Error (702, loc,
+                                                     "Bound cannot be special class `{0}'",
+                                                     TypeManager.CSharpName (class_constraint_type));
+                                       return false;
+                               }
+                       }
+
+                       if (class_constraint_type != null)
+                               effective_base_type = class_constraint_type;
+                       else if (HasValueTypeConstraint)
+                               effective_base_type = TypeManager.value_type;
+                       else
+                               effective_base_type = TypeManager.object_type;
+
                        resolved = true;
                        return true;
                }
@@ -287,11 +365,16 @@ namespace Mono.CSharp {
                        return true;
                }
 
+               /// <summary>
+               ///   Resolve the constraints into actual types.
+               /// </summary>
                public bool ResolveTypes (EmitContext ec)
                {
-                       if (effective_base_type != null)
+                       if (resolved_types)
                                return true;
 
+                       resolved_types = true;
+
                        foreach (object obj in constraints) {
                                ConstructedType cexpr = obj as ConstructedType;
                                if (cexpr == null)
@@ -307,98 +390,28 @@ namespace Mono.CSharp {
                                        return false;
                        }
 
-                       ArrayList list = new ArrayList ();
-
                        foreach (TypeExpr iface_constraint in iface_constraints) {
-                               foreach (Type type in list) {
-                                       if (!type.Equals (iface_constraint.Type))
-                                               continue;
-
-                                       Report.Error (405, loc,
-                                                     "Duplicate constraint `{0}' for type " +
-                                                     "parameter `{1}'.", iface_constraint.Type,
-                                                     name);
+                               if (iface_constraint.ResolveType (ec) == null)
                                        return false;
-                               }
-
-                               TypeExpr te = iface_constraint.ResolveAsTypeTerminal (ec);
-                               if (te == null)
-                                       return false;
-
-                               list.Add (te.Type);
                        }
 
-                       foreach (TypeParameterExpr expr in type_param_constraints) {
-                               foreach (Type type in list) {
-                                       if (!type.Equals (expr.Type))
-                                               continue;
-
-                                       Report.Error (405, loc,
-                                                     "Duplicate constraint `{0}' for type " +
-                                                     "parameter `{1}'.", expr.Type, name);
-                                       return false;
-                               }
-
-                               list.Add (expr.Type);
-                       }
-
-                       ArrayList new_list = new ArrayList ();
-                       foreach (Type iface in list) {
-                               if (new_list.Contains (iface))
-                                       continue;
-
-                               new_list.Add (iface);
-
-                               Type [] implementing = TypeManager.GetInterfaces (iface);
-                       
-                               foreach (Type imp in implementing) {
-                                       if (!new_list.Contains (imp))
-                                               new_list.Add (imp);
-                               }
-                       }
-
-                       iface_constraint_types = new Type [new_list.Count];
-                       new_list.CopyTo (iface_constraint_types, 0);
-
                        if (class_constraint != null) {
-                               TypeExpr te = class_constraint.ResolveAsTypeTerminal (ec);
-                               if (te == null)
-                                       return false;
-
-                               class_constraint_type = te.Type;
-                               if (class_constraint_type == null)
-                                       return false;
-
-                               if (class_constraint_type.IsSealed) {
-                                       Report.Error (701, loc,
-                                                     "`{0}' is not a valid bound.  Bounds " +
-                                                     "must be interfaces or non sealed " +
-                                                     "classes", class_constraint_type);
-                                       return false;
-                               }
-
-                               if ((class_constraint_type == TypeManager.array_type) ||
-                                   (class_constraint_type == TypeManager.delegate_type) ||
-                                   (class_constraint_type == TypeManager.enum_type) ||
-                                   (class_constraint_type == TypeManager.value_type) ||
-                                   (class_constraint_type == TypeManager.object_type)) {
-                                       Report.Error (702, loc,
-                                                     "Bound cannot be special class `{0}'",
-                                                     class_constraint_type);
+                               if (class_constraint.ResolveType (ec) == null)
                                        return false;
-                               }
                        }
 
-                       if (class_constraint_type != null)
-                               effective_base_type = class_constraint_type;
-                       else if (HasValueTypeConstraint)
-                               effective_base_type = TypeManager.value_type;
-                       else
-                               effective_base_type = TypeManager.object_type;
-
                        return true;
                }
 
+               /// <summary>
+               ///   Check whether there are no conflicts in our type parameter constraints.
+               ///
+               ///   This is an example:
+               ///
+               ///   class Foo<T,U>
+               ///      where T : class
+               ///      where U : T, struct
+               /// </summary>
                public bool CheckDependencies (EmitContext ec)
                {
                        foreach (TypeParameterExpr expr in type_param_constraints) {
@@ -418,7 +431,7 @@ namespace Mono.CSharp {
                        if (HasValueTypeConstraint && constraints.HasClassConstraint) {
                                Report.Error (455, loc, "Type parameter `{0}' inherits " +
                                              "conflicting constraints `{1}' and `{2}'",
-                                             name, constraints.ClassConstraint,
+                                             name, TypeManager.CSharpName (constraints.ClassConstraint),
                                              "System.ValueType");
                                return false;
                        }
@@ -434,7 +447,7 @@ namespace Mono.CSharp {
                                        Report.Error (455, loc,
                                                      "Type parameter `{0}' inherits " +
                                                      "conflicting constraints `{1}' and `{2}'",
-                                                     name, t1, t2);
+                                                     name, TypeManager.CSharpName (t1), TypeManager.CSharpName (t2));
                                        return false;
                                }
                        }
@@ -450,11 +463,6 @@ namespace Mono.CSharp {
                        return true;
                }
 
-               public void Define (GenericTypeParameterBuilder type)
-               {
-                       type.SetGenericParameterAttributes (attrs);
-               }
-
                public override GenericParameterAttributes Attributes {
                        get { return attrs; }
                }
@@ -475,7 +483,7 @@ namespace Mono.CSharp {
                        get { return effective_base_type; }
                }
 
-               internal bool IsSubclassOf (Type t)
+               public bool IsSubclassOf (Type t)
                {
                        if ((class_constraint_type != null) &&
                            class_constraint_type.IsSubclassOf (t))
@@ -492,6 +500,13 @@ namespace Mono.CSharp {
                        return false;
                }
 
+               /// <summary>
+               ///   This is used when we're implementing a generic interface method.
+               ///   Each method type parameter in implementing method must have the same
+               ///   constraints than the corresponding type parameter in the interface
+               ///   method.  To do that, we're called on each of the implementing method's
+               ///   type parameters.
+               /// </summary>
                public bool CheckInterfaceMethod (EmitContext ec, GenericConstraints gc)
                {
                        if (gc.Attributes != attrs)
@@ -527,21 +542,23 @@ namespace Mono.CSharp {
                }
        }
 
-       //
-       // This type represents a generic type parameter
-       //
+       /// <summary>
+       ///   A type parameter from a generic type definition.
+       /// </summary>
        public class TypeParameter : MemberCore, IMemberContainer {
                string name;
+               DeclSpace decl;
                GenericConstraints gc;
                Constraints constraints;
                Location loc;
                GenericTypeParameterBuilder type;
 
-               public TypeParameter (TypeContainer parent, string name,
-                                     Constraints constraints, Location loc)
-                       : base (parent, new MemberName (name, loc), null)
+               public TypeParameter (TypeContainer parent, DeclSpace decl, string name,
+                                     Constraints constraints, Attributes attrs, Location loc)
+                       : base (parent, new MemberName (name, loc), attrs)
                {
                        this.name = name;
+                       this.decl = decl;
                        this.constraints = constraints;
                        this.loc = loc;
                }
@@ -567,24 +584,27 @@ namespace Mono.CSharp {
                        }
                }
 
-               public Type Type {
+               public DeclSpace DeclSpace {
                        get {
-                               return type;
+                               return decl;
                        }
                }
 
-               public bool Resolve (DeclSpace ds)
-               {
-                       if (constraints != null) {
-                               if (!constraints.Resolve (ds.EmitContext)) {
-                                       constraints = null;
-                                       return false;
-                               }
+               public Type Type {
+                       get {
+                               return type;
                        }
-
-                       return true;
                }
 
+               /// <summary>
+               ///   This is the first method which is called during the resolving
+               ///   process; we're called immediately after creating the type parameters
+               ///   with SRE (by calling `DefineGenericParameters()' on the TypeBuilder /
+               ///   MethodBuilder).
+               ///
+               ///   We're either called from TypeContainer.DefineType() or from
+               ///   GenericMethod.Define() (called from Method.Define()).
+               /// </summary>
                public void Define (GenericTypeParameterBuilder type)
                {
                        if (this.type != null)
@@ -594,12 +614,41 @@ namespace Mono.CSharp {
                        TypeManager.AddTypeParameter (type, this);
                }
 
-               public void DefineConstraints ()
+               /// <summary>
+               ///   This is the second method which is called during the resolving
+               ///   process - in case of class type parameters, we're called from
+               ///   TypeContainer.ResolveType() - after it resolved the class'es
+               ///   base class and interfaces. For method type parameters, we're
+               ///   called immediately after Define().
+               ///
+               ///   We're just resolving the constraints into expressions here, we
+               ///   don't resolve them into actual types.
+               ///
+               ///   Note that in the special case of partial generic classes, we may be
+               ///   called _before_ Define() and we may also be called multiple types.
+               /// </summary>
+               public bool Resolve (DeclSpace ds)
                {
-                       if (constraints != null)
-                               constraints.Define (type);
+                       if (constraints != null) {
+                               if (!constraints.Resolve (ds.EmitContext)) {
+                                       constraints = null;
+                                       return false;
+                               }
+                       }
+
+                       return true;
                }
 
+               /// <summary>
+               ///   This is the third method which is called during the resolving
+               ///   process.  We're called immediately after calling DefineConstraints()
+               ///   on all of the current class'es type parameters.
+               ///
+               ///   Our job is to resolve the constraints to actual types.
+               ///
+               ///   Note that we may have circular dependencies on type parameters - this
+               ///   is why Resolve() and ResolveType() are separate.
+               /// </summary>
                public bool ResolveType (EmitContext ec)
                {
                        if (constraints != null) {
@@ -612,11 +661,24 @@ namespace Mono.CSharp {
                        return true;
                }
 
+               /// <summary>
+               ///   This is the fourth and last method which is called during the resolving
+               ///   process.  We're called after everything is fully resolved and actually
+               ///   register the constraints with SRE and the TypeManager.
+               /// </summary>
                public bool DefineType (EmitContext ec)
                {
                        return DefineType (ec, null, null, false);
                }
 
+               /// <summary>
+               ///   This is the fith and last method which is called during the resolving
+               ///   process.  We're called after everything is fully resolved and actually
+               ///   register the constraints with SRE and the TypeManager.
+               ///
+               ///   The `builder', `implementing' and `is_override' arguments are only
+               ///   applicable to method type parameters.
+               /// </summary>
                public bool DefineType (EmitContext ec, MethodBuilder builder,
                                        MethodInfo implementing, bool is_override)
                {
@@ -638,9 +700,8 @@ namespace Mono.CSharp {
                                        mb = mb.GetGenericMethodDefinition ();
 
                                int pos = type.GenericParameterPosition;
-                               ParameterData pd = TypeManager.GetParameterData (mb);
-                               GenericConstraints temp_gc = pd.GenericConstraints (pos);
                                Type mparam = mb.GetGenericArguments () [pos];
+                               GenericConstraints temp_gc = ReflectionConstraints.GetConstraints (mparam);
 
                                if (temp_gc != null)
                                        gc = new InflatedConstraints (temp_gc, implementing.DeclaringType);
@@ -665,12 +726,20 @@ namespace Mono.CSharp {
                                                425, loc, "The constraints for type " +
                                                "parameter `{0}' of method `{1}' must match " +
                                                "the constraints for type parameter `{2}' " +
-                                               "of interface method `{3}'.  Consider using " +
+                                               "of interface method `{3}'. Consider using " +
                                                "an explicit interface implementation instead",
                                                Name, TypeManager.CSharpSignature (builder),
-                                               mparam, TypeManager.CSharpSignature (mb));
+                                               TypeManager.CSharpName (mparam), TypeManager.CSharpSignature (mb));
                                        return false;
                                }
+                       } else if (DeclSpace is Iterator) {
+                               TypeParameter[] tparams = DeclSpace.TypeParameters;
+                               Type[] types = new Type [tparams.Length];
+                               for (int i = 0; i < tparams.Length; i++)
+                                       types [i] = tparams [i].Type;
+
+                               if (constraints != null)
+                                       gc = new InflatedConstraints (constraints, types);
                        } else {
                                gc = (GenericConstraints) constraints;
                        }
@@ -682,11 +751,21 @@ namespace Mono.CSharp {
                                type.SetBaseTypeConstraint (gc.ClassConstraint);
 
                        type.SetInterfaceConstraints (gc.InterfaceConstraints);
+                       type.SetGenericParameterAttributes (gc.Attributes);
                        TypeManager.RegisterBuilder (type, gc.InterfaceConstraints);
 
                        return true;
                }
 
+               /// <summary>
+               ///   Check whether there are no conflicts in our type parameter constraints.
+               ///
+               ///   This is an example:
+               ///
+               ///   class Foo<T,U>
+               ///      where T : class
+               ///      where U : T, struct
+               /// </summary>
                public bool CheckDependencies (EmitContext ec)
                {
                        if (constraints != null)
@@ -695,15 +774,16 @@ namespace Mono.CSharp {
                        return true;
                }
 
+               /// <summary>
+               ///   This is called for each part of a partial generic type definition.
+               ///
+               ///   If `new_constraints' is not null and we don't already have constraints,
+               ///   they become our constraints.  If we already have constraints, we must
+               ///   check that they're the same.
+               ///   con
+               /// </summary>
                public bool UpdateConstraints (EmitContext ec, Constraints new_constraints)
                {
-                       //
-                       // We're used in partial generic type definitions.
-                       // If `check' is false, we just encountered the first ClassPart which has
-                       // constraints - they become our "real" constraints.
-                       // Otherwise we're called after the type parameters have already been defined
-                       // and check whether the constraints are the same in all parts.
-                       //
                        if (type == null)
                                throw new InvalidOperationException ();
 
@@ -721,6 +801,12 @@ namespace Mono.CSharp {
                        return constraints.CheckInterfaceMethod (ec, new_constraints);
                }
 
+               public void EmitAttributes (EmitContext ec)
+               {
+                       if (OptAttributes != null)
+                               OptAttributes.Emit (ec, this);
+               }
+
                public override string DocCommentHeader {
                        get {
                                throw new InvalidOperationException (
@@ -737,22 +823,21 @@ namespace Mono.CSharp {
                        return true;
                }
 
-               protected override void VerifyObsoleteAttribute ()
-               { }
-
                public override void ApplyAttributeBuilder (Attribute a,
                                                            CustomAttributeBuilder cb)
-               { }
+               {
+                       type.SetCustomAttribute (cb);
+               }
 
                public override AttributeTargets AttributeTargets {
                        get {
-                               return (AttributeTargets) 0;
+                               return (AttributeTargets) AttributeTargets.GenericParameter;
                        }
                }
 
                public override string[] ValidAttributeTargets {
                        get {
-                               return new string [0];
+                               return new string [] { "type parameter" };
                        }
                }
 
@@ -798,7 +883,8 @@ namespace Mono.CSharp {
                                members.AddRange (list);
                        }
 
-                       foreach (Type t in gc.InterfaceConstraints) {
+                       Type[] ifaces = TypeManager.ExpandInterfaces (gc.InterfaceConstraints);
+                       foreach (Type t in ifaces) {
                                MemberList list = TypeManager.FindMembers (
                                        t, mt, bf, filter, criteria);
 
@@ -824,6 +910,21 @@ namespace Mono.CSharp {
                        return "TypeParameter[" + name + "]";
                }
 
+               public static string GetSignatureForError (TypeParameter[] tp)
+               {
+                       if (tp == null || tp.Length == 0)
+                               return "";
+
+                       StringBuilder sb = new StringBuilder ("<");
+                       for (int i = 0; i < tp.Length; ++i) {
+                               if (i > 0)
+                                       sb.Append (",");
+                               sb.Append (tp[i].GetSignatureForError ());
+                       }
+                       sb.Append ('>');
+                       return sb.ToString ();
+               }
+
                protected class InflatedConstraints : GenericConstraints
                {
                        GenericConstraints gc;
@@ -833,10 +934,13 @@ namespace Mono.CSharp {
                        Type[] dargs;
 
                        public InflatedConstraints (GenericConstraints gc, Type declaring)
+                               : this (gc, TypeManager.GetTypeArguments (declaring))
+                       { }
+
+                       public InflatedConstraints (GenericConstraints gc, Type[] dargs)
                        {
                                this.gc = gc;
-
-                               dargs = TypeManager.GetTypeArguments (declaring);
+                               this.dargs = dargs;
 
                                ArrayList list = new ArrayList ();
                                if (gc.HasClassConstraint)
@@ -881,6 +985,10 @@ namespace Mono.CSharp {
                                return t;
                        }
 
+                       public override string TypeParameter {
+                               get { return gc.TypeParameter; }
+                       }
+
                        public override GenericParameterAttributes Attributes {
                                get { return gc.Attributes; }
                        }
@@ -899,11 +1007,9 @@ namespace Mono.CSharp {
                }
        }
 
-       //
-       // This type represents a generic type parameter reference.
-       //
-       // These expressions are born in a fully resolved state.
-       //
+       /// <summary>
+       ///   A TypeExpr which already resolved to a type parameter.
+       /// </summary>
        public class TypeParameterExpr : TypeExpr {
                TypeParameter type_parameter;
 
@@ -953,6 +1059,10 @@ namespace Mono.CSharp {
                }
        }
 
+       /// <summary>
+       ///   Tracks the type arguments when instantiating a generic type.  We're used in
+       ///   ConstructedType.
+       /// </summary>
        public class TypeArguments {
                public readonly Location Location;
                ArrayList args;
@@ -989,13 +1099,24 @@ namespace Mono.CSharp {
                        args.AddRange (new_args.args);
                }
 
-               public string[] GetDeclarations ()
+               /// <summary>
+               ///   We're used during the parsing process: the parser can't distinguish
+               ///   between type parameters and type arguments.  Because of that, the
+               ///   parser creates a `MemberName' with `TypeArguments' for both cases and
+               ///   in case of a generic type definition, we call GetDeclarations().
+               /// </summary>
+               public TypeParameterName[] GetDeclarations ()
                {
-                       string[] ret = new string [args.Count];
+                       TypeParameterName[] ret = new TypeParameterName [args.Count];
                        for (int i = 0; i < args.Count; i++) {
+                               TypeParameterName name = args [i] as TypeParameterName;
+                               if (name != null) {
+                                       ret [i] = name;
+                                       continue;
+                               }
                                SimpleName sn = args [i] as SimpleName;
                                if (sn != null) {
-                                       ret [i] = sn.Name;
+                                       ret [i] = new TypeParameterName (sn.Name, null, sn.Location);
                                        continue;
                                }
 
@@ -1006,6 +1127,10 @@ namespace Mono.CSharp {
                        return ret;
                }
 
+               /// <summary>
+               ///   We may only be used after Resolve() is called and return the fully
+               ///   resolved types.
+               /// </summary>
                public Type[] Arguments {
                        get {
                                return atypes;
@@ -1050,6 +1175,9 @@ namespace Mono.CSharp {
                        return s.ToString ();
                }
 
+               /// <summary>
+               ///   Resolve the type arguments.
+               /// </summary>
                public bool Resolve (EmitContext ec)
                {
                        int count = args.Count;
@@ -1070,6 +1198,10 @@ namespace Mono.CSharp {
                                        Report.Error (306, Location, "The type `{0}' may not be used " +
                                                      "as a type argument.", TypeManager.CSharpName (te.Type));
                                        return false;
+                               } else if (te.Type == TypeManager.void_type) {
+                                       Report.Error (1547, Location,
+                                                     "Keyword `void' cannot be used in this context");
+                                       return false;
                                }
 
                                atypes [i] = te.Type;
@@ -1077,14 +1209,37 @@ namespace Mono.CSharp {
                        return ok;
                }
        }
-       
+
+       public class TypeParameterName : SimpleName
+       {
+               Attributes attributes;
+
+               public TypeParameterName (string name, Attributes attrs, Location loc)
+                       : base (name, loc)
+               {
+                       attributes = attrs;
+               }
+
+               public Attributes OptAttributes {
+                       get {
+                               return attributes;
+                       }
+               }
+       }
+
+       /// <summary>
+       ///   An instantiation of a generic type.
+       /// </summary>  
        public class ConstructedType : TypeExpr {
                string full_name;
                FullNamedExpression name;
                TypeArguments args;
                Type[] gen_params, atypes;
                Type gt;
-               
+
+               /// <summary>
+               ///   Instantiate the generic type `fname' with the type arguments `args'.
+               /// </summary>          
                public ConstructedType (FullNamedExpression fname, TypeArguments args, Location l)
                {
                        loc = l;
@@ -1114,68 +1269,204 @@ namespace Mono.CSharp {
                        eclass = ExprClass.Type;
                }
 
-               public ConstructedType (Type t, TypeParameter[] type_params, Location l)
-                       : this (type_params, l)
-               {
-                       gt = t.GetGenericTypeDefinition ();
-
-                       this.name = new TypeExpression (gt, l);
-                       full_name = gt.FullName + "<" + args.ToString () + ">";
+               /// <summary>
+               ///   This is used to construct the `this' type inside a generic type definition.
+               /// </summary>
+               public ConstructedType (Type t, TypeParameter[] type_params, Location l)
+                       : this (type_params, l)
+               {
+                       gt = t.GetGenericTypeDefinition ();
+
+                       this.name = new TypeExpression (gt, l);
+                       full_name = gt.FullName + "<" + args.ToString () + ">";
+               }
+
+               /// <summary>
+               ///   Instantiate the generic type `t' with the type arguments `args'.
+               ///   Use this constructor if you already know the fully resolved
+               ///   generic type.
+               /// </summary>          
+               public ConstructedType (Type t, TypeArguments args, Location l)
+                       : this (args, l)
+               {
+                       gt = t.GetGenericTypeDefinition ();
+
+                       this.name = new TypeExpression (gt, l);
+                       full_name = gt.FullName + "<" + args.ToString () + ">";
+               }
+
+               public TypeArguments TypeArguments {
+                       get { return args; }
+               }
+
+               public override string GetSignatureForError ()
+               {
+                       return TypeManager.CSharpName (gt);
+               }
+
+               protected override TypeExpr DoResolveAsTypeStep (EmitContext ec)
+               {
+                       if (!ResolveConstructedType (ec))
+                               return null;
+
+                       return this;
+               }
+
+               /// <summary>
+               ///   Check the constraints; we're called from ResolveAsTypeTerminal()
+               ///   after fully resolving the constructed type.
+               /// </summary>
+               public bool CheckConstraints (EmitContext ec)
+               {
+                       return ConstraintChecker.CheckConstraints (ec, gt, gen_params, atypes, loc);
+               }
+
+               /// <summary>
+               ///   Resolve the constructed type, but don't check the constraints.
+               /// </summary>
+               public bool ResolveConstructedType (EmitContext ec)
+               {
+                       if (type != null)
+                               return true;
+                       // If we already know the fully resolved generic type.
+                       if (gt != null)
+                               return DoResolveType (ec);
+
+                       int num_args;
+                       Type t = name.Type;
+
+                       if (t == null) {
+                               Report.Error (246, loc, "Cannot find type `{0}'<...>", Name);
+                               return false;
+                       }
+
+                       num_args = TypeManager.GetNumberOfTypeArguments (t);
+                       if (num_args == 0) {
+                               Report.Error (308, loc,
+                                             "The non-generic type `{0}' cannot " +
+                                             "be used with type arguments.",
+                                             TypeManager.CSharpName (t));
+                               return false;
+                       }
+
+                       gt = t.GetGenericTypeDefinition ();
+                       return DoResolveType (ec);
+               }
+
+               bool DoResolveType (EmitContext ec)
+               {
+                       //
+                       // Resolve the arguments.
+                       //
+                       if (args.Resolve (ec) == false)
+                               return false;
+
+                       gen_params = gt.GetGenericArguments ();
+                       atypes = args.Arguments;
+
+                       if (atypes.Length != gen_params.Length) {
+                               Report.Error (305, loc,
+                                             "Using the generic type `{0}' " +
+                                             "requires {1} type arguments",
+                                             TypeManager.CSharpName (gt),
+                                             gen_params.Length.ToString ());
+                               return false;
+                       }
+
+                       //
+                       // Now bind the parameters.
+                       //
+                       type = gt.MakeGenericType (atypes);
+                       return true;
+               }
+
+               public Expression GetSimpleName (EmitContext ec)
+               {
+                       return this;
+               }
+
+               public override bool CheckAccessLevel (DeclSpace ds)
+               {
+                       return ds.CheckAccessLevel (gt);
+               }
+
+               public override bool AsAccessible (DeclSpace ds, int flags)
+               {
+                       return ds.AsAccessible (gt, flags);
+               }
+
+               public override bool IsClass {
+                       get { return gt.IsClass; }
+               }
+
+               public override bool IsValueType {
+                       get { return gt.IsValueType; }
+               }
+
+               public override bool IsInterface {
+                       get { return gt.IsInterface; }
+               }
+
+               public override bool IsSealed {
+                       get { return gt.IsSealed; }
                }
 
-               public ConstructedType (Type t, TypeArguments args, Location l)
-                       : this (args, l)
+               public override bool Equals (object obj)
                {
-                       gt = t.GetGenericTypeDefinition ();
+                       ConstructedType cobj = obj as ConstructedType;
+                       if (cobj == null)
+                               return false;
 
-                       this.name = new TypeExpression (gt, l);
-                       full_name = gt.FullName + "<" + args.ToString () + ">";
+                       if ((type == null) || (cobj.type == null))
+                               return false;
+
+                       return type == cobj.type;
                }
 
-               public TypeArguments TypeArguments {
-                       get { return args; }
+               public override int GetHashCode ()
+               {
+                       return base.GetHashCode ();
                }
 
-               protected string DeclarationName {
+               public override string Name {
                        get {
-                               StringBuilder sb = new StringBuilder ();
-                               sb.Append (gt.FullName);
-                               sb.Append ("<");
-                               for (int i = 0; i < gen_params.Length; i++) {
-                                       if (i > 0)
-                                               sb.Append (",");
-                                       sb.Append (gen_params [i]);
-                               }
-                               sb.Append (">");
-                               return sb.ToString ();
+                               return full_name;
                        }
                }
 
-               protected bool CheckConstraint (EmitContext ec, Type ptype, Expression expr,
-                                               Type ctype)
-               {
-                       if (TypeManager.HasGenericArguments (ctype)) {
-                               Type[] types = TypeManager.GetTypeArguments (ctype);
 
-                               TypeArguments new_args = new TypeArguments (loc);
+               public override string FullName {
+                       get {
+                               return full_name;
+                       }
+               }
+       }
 
-                               for (int i = 0; i < types.Length; i++) {
-                                       Type t = types [i];
+       public abstract class ConstraintChecker
+       {
+               protected readonly Type[] gen_params;
+               protected readonly Type[] atypes;
+               protected readonly Location loc;
 
-                                       if (t.IsGenericParameter) {
-                                               int pos = t.GenericParameterPosition;
-                                               t = args.Arguments [pos];
-                                       }
-                                       new_args.Add (new TypeExpression (t, loc));
-                               }
+               protected ConstraintChecker (Type[] gen_params, Type[] atypes, Location loc)
+               {
+                       this.gen_params = gen_params;
+                       this.atypes = atypes;
+                       this.loc = loc;
+               }
 
-                               TypeExpr ct = new ConstructedType (ctype, new_args, loc);
-                               if (ct.ResolveAsTypeStep (ec) == null)
+               /// <summary>
+               ///   Check the constraints; we're called from ResolveAsTypeTerminal()
+               ///   after fully resolving the constructed type.
+               /// </summary>
+               public bool CheckConstraints (EmitContext ec)
+               {
+                       for (int i = 0; i < gen_params.Length; i++) {
+                               if (!CheckConstraints (ec, i))
                                        return false;
-                               ctype = ct.Type;
                        }
 
-                       return Convert.ImplicitStandardConversionExists (ec, expr, ctype);
+                       return true;
                }
 
                protected bool CheckConstraints (EmitContext ec, int index)
@@ -1214,14 +1505,18 @@ namespace Mono.CSharp {
                                              "a reference type in order to use it " +
                                              "as type parameter `{1}' in the " +
                                              "generic type or method `{2}'.",
-                                             atype, ptype, DeclarationName);
+                                             TypeManager.CSharpName (atype),
+                                             TypeManager.CSharpName (ptype),
+                                             GetSignatureForError ());
                                return false;
                        } else if (gc.HasValueTypeConstraint && !is_struct) {
                                Report.Error (453, loc, "The type `{0}' must be " +
                                              "a value type in order to use it " +
                                              "as type parameter `{1}' in the " +
                                              "generic type or method `{2}'.",
-                                             atype, ptype, DeclarationName);
+                                             TypeManager.CSharpName (atype),
+                                             TypeManager.CSharpName (ptype),
+                                             GetSignatureForError ());
                                return false;
                        }
 
@@ -1230,11 +1525,7 @@ namespace Mono.CSharp {
                        //
                        if (gc.HasClassConstraint) {
                                if (!CheckConstraint (ec, ptype, aexpr, gc.ClassConstraint)) {
-                                       Report.Error (309, loc, "The type `{0}' must be " +
-                                                     "convertible to `{1}' in order to " +
-                                                     "use it as parameter `{2}' in the " +
-                                                     "generic type or method `{3}'",
-                                                     atype, gc.ClassConstraint, ptype, DeclarationName);
+                                       Error_TypeMustBeConvertible (atype, gc.ClassConstraint, ptype);
                                        return false;
                                }
                        }
@@ -1250,11 +1541,7 @@ namespace Mono.CSharp {
                                        itype = it;
 
                                if (!CheckConstraint (ec, ptype, aexpr, itype)) {
-                                       Report.Error (309, loc, "The type `{0}' must be " +
-                                                     "convertible to `{1}' in order to " +
-                                                     "use it as parameter `{2}' in the " +
-                                                     "generic type or method `{3}'",
-                                                     atype, itype, ptype, DeclarationName);
+                                       Error_TypeMustBeConvertible (atype, itype, ptype);
                                        return false;
                                }
                        }
@@ -1269,167 +1556,178 @@ namespace Mono.CSharp {
                        if (TypeManager.IsBuiltinType (atype) || atype.IsValueType)
                                return true;
 
-                       MethodGroupExpr mg = Expression.MemberLookup (
-                               ec, atype, ".ctor", MemberTypes.Constructor,
-                               BindingFlags.Public | BindingFlags.Instance |
-                               BindingFlags.DeclaredOnly, loc)
-                               as MethodGroupExpr;
-
-                       if (!atype.IsAbstract && (mg != null) && mg.IsInstance) {
-                               foreach (MethodBase mb in mg.Methods) {
-                                       ParameterData pd = TypeManager.GetParameterData (mb);
-                                       if (pd.Count == 0)
-                                               return true;
-                               }
-                       }
+                       if (HasDefaultConstructor (ec, atype))
+                               return true;
 
+                       Report_SymbolRelatedToPreviousError ();
+                       Report.SymbolRelatedToPreviousError (atype);
                        Report.Error (310, loc, "The type `{0}' must have a public " +
                                      "parameterless constructor in order to use it " +
                                      "as parameter `{1}' in the generic type or " +
-                                     "method `{2}'", atype, ptype, DeclarationName);
+                                     "method `{2}'",
+                                     TypeManager.CSharpName (atype),
+                                     TypeManager.CSharpName (ptype),
+                                     GetSignatureForError ());
                        return false;
                }
 
-               protected override TypeExpr DoResolveAsTypeStep (EmitContext ec)
+               protected bool CheckConstraint (EmitContext ec, Type ptype, Expression expr,
+                                               Type ctype)
                {
-                       if (!ResolveConstructedType (ec))
-                               return null;
+                       if (TypeManager.HasGenericArguments (ctype)) {
+                               Type[] types = TypeManager.GetTypeArguments (ctype);
 
-                       return this;
-               }
+                               TypeArguments new_args = new TypeArguments (loc);
 
-               public bool CheckConstraints (EmitContext ec)
-               {
-                       for (int i = 0; i < gen_params.Length; i++) {
-                               if (!CheckConstraints (ec, i))
+                               for (int i = 0; i < types.Length; i++) {
+                                       Type t = types [i];
+
+                                       if (t.IsGenericParameter) {
+                                               int pos = t.GenericParameterPosition;
+                                               t = atypes [pos];
+                                       }
+                                       new_args.Add (new TypeExpression (t, loc));
+                               }
+
+                               TypeExpr ct = new ConstructedType (ctype, new_args, loc);
+                               if (ct.ResolveAsTypeStep (ec) == null)
                                        return false;
+                               ctype = ct.Type;
                        }
 
-                       return true;
+                       return Convert.ImplicitStandardConversionExists (ec, expr, ctype);
                }
 
-               public bool ResolveConstructedType (EmitContext ec)
+               bool HasDefaultConstructor (EmitContext ec, Type atype)
                {
-                       if (type != null)
-                               return true;
-                       if (gt != null)
-                               return DoResolveType (ec);
-
-                       int num_args;
-                       Type t = name.Type;
+                       if (atype is TypeBuilder) {
+                               if (atype.IsAbstract)
+                                       return false;
 
-                       if (t == null) {
-                               Report.Error (246, loc, "Cannot find type `{0}'<...>", Name);
-                               return false;
-                       }
+                               TypeContainer tc = TypeManager.LookupTypeContainer (atype);
+                               foreach (Constructor c in tc.InstanceConstructors) {
+                                       if ((c.ModFlags & Modifiers.PUBLIC) == 0)
+                                               continue;
+                                       if ((c.Parameters.FixedParameters != null) &&
+                                           (c.Parameters.FixedParameters.Length != 0))
+                                               continue;
+                                       if (c.Parameters.HasArglist || c.Parameters.HasParams)
+                                               continue;
 
-                       num_args = TypeManager.GetNumberOfTypeArguments (t);
-                       if (num_args == 0) {
-                               Report.Error (308, loc,
-                                             "The non-generic type `{0}' cannot " +
-                                             "be used with type arguments.",
-                                             TypeManager.CSharpName (t));
-                               return false;
+                                       return true;
+                               }
                        }
 
-                       gt = t.GetGenericTypeDefinition ();
-                       return DoResolveType (ec);
-               }
-
-               bool DoResolveType (EmitContext ec)
-               {
-                       //
-                       // Resolve the arguments.
-                       //
-                       if (args.Resolve (ec) == false)
-                               return false;
-
-                       gen_params = gt.GetGenericArguments ();
-                       atypes = args.Arguments;
+                       MethodGroupExpr mg = Expression.MemberLookup (
+                               ec, atype, ".ctor", MemberTypes.Constructor,
+                               BindingFlags.Public | BindingFlags.Instance |
+                               BindingFlags.DeclaredOnly, loc)
+                               as MethodGroupExpr;
 
-                       if (atypes.Length != gen_params.Length) {
-                               Report.Error (305, loc,
-                                             "Using the generic type `{0}' " +
-                                             "requires {1} type arguments",
-                                             TypeManager.GetFullName (gt),
-                                             gen_params.Length);
-                               return false;
+                       if (!atype.IsAbstract && (mg != null) && mg.IsInstance) {
+                               foreach (MethodBase mb in mg.Methods) {
+                                       ParameterData pd = TypeManager.GetParameterData (mb);
+                                       if (pd.Count == 0)
+                                               return true;
+                               }
                        }
 
-                       //
-                       // Now bind the parameters.
-                       //
-                       type = gt.MakeGenericType (atypes);
-                       return true;
+                       return false;
                }
 
-               public Expression GetSimpleName (EmitContext ec)
-               {
-                       return this;
-               }
+               protected abstract string GetSignatureForError ();
+               protected abstract void Report_SymbolRelatedToPreviousError ();
 
-               public override bool CheckAccessLevel (DeclSpace ds)
+               void Error_TypeMustBeConvertible (Type atype, Type gc, Type ptype)
                {
-                       return ds.CheckAccessLevel (gt);
+                       Report_SymbolRelatedToPreviousError ();
+                       Report.SymbolRelatedToPreviousError (atype);
+                       Report.Error (309, loc, 
+                                     "The type `{0}' must be convertible to `{1}' in order to " +
+                                     "use it as parameter `{2}' in the generic type or method `{3}'",
+                                     TypeManager.CSharpName (atype), TypeManager.CSharpName (gc),
+                                     TypeManager.CSharpName (ptype), GetSignatureForError ());
                }
 
-               public override bool AsAccessible (DeclSpace ds, int flags)
+               public static bool CheckConstraints (EmitContext ec, MethodBase definition,
+                                                    MethodBase instantiated, Location loc)
                {
-                       return ds.AsAccessible (gt, flags);
-               }
-
-               public override bool IsClass {
-                       get { return gt.IsClass; }
-               }
+                       MethodConstraintChecker checker = new MethodConstraintChecker (
+                               definition, definition.GetGenericArguments (),
+                               instantiated.GetGenericArguments (), loc);
 
-               public override bool IsValueType {
-                       get { return gt.IsValueType; }
+                       return checker.CheckConstraints (ec);
                }
 
-               public override bool IsInterface {
-                       get { return gt.IsInterface; }
-               }
+               public static bool CheckConstraints (EmitContext ec, Type gt, Type[] gen_params,
+                                                    Type[] atypes, Location loc)
+               {
+                       TypeConstraintChecker checker = new TypeConstraintChecker (
+                               gt, gen_params, atypes, loc);
 
-               public override bool IsSealed {
-                       get { return gt.IsSealed; }
+                       return checker.CheckConstraints (ec);
                }
 
-               public override bool Equals (object obj)
+               protected class MethodConstraintChecker : ConstraintChecker
                {
-                       ConstructedType cobj = obj as ConstructedType;
-                       if (cobj == null)
-                               return false;
+                       MethodBase definition;
 
-                       if ((type == null) || (cobj.type == null))
-                               return false;
+                       public MethodConstraintChecker (MethodBase definition, Type[] gen_params,
+                                                       Type[] atypes, Location loc)
+                               : base (gen_params, atypes, loc)
+                       {
+                               this.definition = definition;
+                       }
 
-                       return type == cobj.type;
+                       protected override string GetSignatureForError ()
+                       {
+                               return TypeManager.CSharpSignature (definition);
+                       }
+
+                       protected override void Report_SymbolRelatedToPreviousError ()
+                       {
+                               Report.SymbolRelatedToPreviousError (definition);
+                       }
                }
 
-               public override int GetHashCode ()
+               protected class TypeConstraintChecker : ConstraintChecker
                {
-                       return base.GetHashCode ();
-               }
+                       Type gt;
 
-               public override string Name {
-                       get {
-                               return full_name;
+                       public TypeConstraintChecker (Type gt, Type[] gen_params, Type[] atypes,
+                                                     Location loc)
+                               : base (gen_params, atypes, loc)
+                       {
+                               this.gt = gt;
                        }
-               }
 
+                       protected override string GetSignatureForError ()
+                       {
+                               return TypeManager.CSharpName (gt);
+                       }
 
-               public override string FullName {
-                       get {
-                               return full_name;
+                       protected override void Report_SymbolRelatedToPreviousError ()
+                       {
+                               Report.SymbolRelatedToPreviousError (gt);
                        }
                }
        }
 
+       /// <summary>
+       ///   A generic method definition.
+       /// </summary>
        public class GenericMethod : DeclSpace
        {
-               public GenericMethod (NamespaceEntry ns, TypeContainer parent, MemberName name)
+               Expression return_type;
+               Parameters parameters;
+
+               public GenericMethod (NamespaceEntry ns, TypeContainer parent, MemberName name,
+                                     Expression return_type, Parameters parameters)
                        : base (ns, parent, name, null)
-               { }
+               {
+                       this.return_type = return_type;
+                       this.parameters = parameters;
+               }
 
                public override TypeBuilder DefineType ()
                {
@@ -1447,11 +1745,18 @@ namespace Mono.CSharp {
                        return true;
                }
 
+               /// <summary>
+               ///   Define and resolve the type parameters.
+               ///   We're called from Method.Define().
+               /// </summary>
                public bool Define (MethodBuilder mb)
                {
                        GenericTypeParameterBuilder[] gen_params;
-                       string[] names = MemberName.TypeArguments.GetDeclarations ();
-                       gen_params = mb.DefineGenericParameters (names);
+                       TypeParameterName[] names = MemberName.TypeArguments.GetDeclarations ();
+                       string[] snames = new string [names.Length];
+                       for (int i = 0; i < names.Length; i++)
+                               snames [i] = names [i].Name;
+                       gen_params = mb.DefineGenericParameters (snames);
                        for (int i = 0; i < TypeParameters.Length; i++)
                                TypeParameters [i].Define (gen_params [i]);
 
@@ -1466,6 +1771,9 @@ namespace Mono.CSharp {
                        return true;
                }
 
+               /// <summary>
+               ///   We're called from MethodData.Define() after creating the MethodBuilder.
+               /// </summary>
                public bool DefineType (EmitContext ec, MethodBuilder mb,
                                        MethodInfo implementing, bool is_override)
                {
@@ -1474,7 +1782,24 @@ namespace Mono.CSharp {
                                            ec, mb, implementing, is_override))
                                        return false;
 
-                       return true;
+                       bool ok = true;
+                       foreach (Parameter p in parameters.FixedParameters){
+                               if (!p.Resolve (ec))
+                                       ok = false;
+                       }
+                       if ((return_type != null) && (return_type.ResolveAsTypeTerminal (ec) == null))
+                               ok = false;
+
+                       return ok;
+               }
+
+               public void EmitAttributes (EmitContext ec)
+               {
+                       for (int i = 0; i < TypeParameters.Length; i++)
+                               TypeParameters [i].EmitAttributes (ec);
+
+                       if (OptAttributes != null)
+                               OptAttributes.Emit (ec, this);
                }
 
                public override bool DefineMembers (TypeContainer parent)
@@ -1496,12 +1821,7 @@ namespace Mono.CSharp {
 
                public override void ApplyAttributeBuilder (Attribute a, CustomAttributeBuilder cb)
                {
-                       // FIXME
-               }
-
-               protected override void VerifyObsoleteAttribute()
-               {
-                       // FIXME
+                       base.ApplyAttributeBuilder (a, cb);
                }
 
                public override AttributeTargets AttributeTargets {
@@ -1589,7 +1909,6 @@ namespace Mono.CSharp {
                //
                // A list of core types that the compiler requires or uses
                //
-               static public Type new_constraint_attr_type;
                static public Type activator_type;
                static public Type generic_ienumerator_type;
                static public Type generic_ienumerable_type;
@@ -1618,8 +1937,6 @@ namespace Mono.CSharp {
                static void InitGenericCoreTypes ()
                {
                        activator_type = CoreLookupType ("System", "Activator");
-                       new_constraint_attr_type = CoreLookupType (
-                               "System.Runtime.CompilerServices", "NewConstraintAttribute");
 
                        generic_ienumerator_type = CoreLookupType (
                                "System.Collections.Generic", "IEnumerator", 1);
@@ -1650,9 +1967,7 @@ namespace Mono.CSharp {
 
                public static TypeContainer LookupGenericTypeContainer (Type t)
                {
-                       while (t.IsGenericInstance)
-                               t = t.GetGenericTypeDefinition ();
-
+                       t = DropGenericTypeArguments (t);
                        return LookupTypeContainer (t);
                }
 
@@ -1670,7 +1985,7 @@ namespace Mono.CSharp {
                        if (tparam != null)
                                return tparam.GenericConstraints;
 
-                       return new ReflectionConstraints (t);
+                       return ReflectionConstraints.GetConstraints (t);
                }
 
                public static bool IsGeneric (Type t)
@@ -1687,6 +2002,8 @@ namespace Mono.CSharp {
 
                public static int GetNumberOfTypeArguments (Type t)
                {
+                       if (t.IsGenericParameter)
+                               return 0;
                        DeclSpace tc = LookupDeclSpace (t);
                        if (tc != null)
                                return tc.IsGeneric ? tc.CountTypeParameters : 0;
@@ -1714,6 +2031,16 @@ namespace Mono.CSharp {
                                return t.GetGenericArguments ();
                }
 
+               public static Type DropGenericTypeArguments (Type t)
+               {
+                       if (!t.IsGenericType)
+                               return t;
+                       // Micro-optimization: a generic typebuilder is always a generic type definition
+                       if (t is TypeBuilder)
+                               return t;
+                       return t.GetGenericTypeDefinition ();
+               }
+
                //
                // Whether `array' is an array of T and `enumerator' is `IEnumerable<T>'.
                // For instance "string[]" -> "IEnumerable<string>".
@@ -1806,7 +2133,12 @@ namespace Mono.CSharp {
                        return false;
                }
 
-               public static bool MayBecomeEqualGenericTypes (Type a, Type b, Type[] class_infered, Type[] method_infered)
+               /// <summary>
+               ///   Check whether `a' and `b' may become equal generic types.
+               ///   The algorithm to do that is a little bit complicated.
+               /// </summary>
+               public static bool MayBecomeEqualGenericTypes (Type a, Type b, Type[] class_infered,
+                                                              Type[] method_infered)
                {
                        if (a.IsGenericParameter) {
                                //
@@ -1900,7 +2232,8 @@ namespace Mono.CSharp {
                // particular instantiation (26.3.1).
                //
                public static bool MayBecomeEqualGenericInstances (Type a, Type b,
-                                                                  Type[] class_infered, Type[] method_infered)
+                                                                  Type[] class_infered,
+                                                                  Type[] method_infered)
                {
                        if (!a.IsGenericInstance || !b.IsGenericInstance)
                                return false;
@@ -1912,7 +2245,8 @@ namespace Mono.CSharp {
                }
 
                public static bool MayBecomeEqualGenericInstances (Type[] aargs, Type[] bargs,
-                                                                  Type[] class_infered, Type[] method_infered)
+                                                                  Type[] class_infered,
+                                                                  Type[] method_infered)
                {
                        if (aargs.Length != bargs.Length)
                                return false;
@@ -1925,23 +2259,28 @@ namespace Mono.CSharp {
                        return true;
                }
 
-               public static bool IsEqualGenericInstance (Type type, Type parent)
+               /// <summary>
+               ///   Check whether `type' and `parent' are both instantiations of the same
+               ///   generic type.  Note that we do not check the type parameters here.
+               /// </summary>
+               public static bool IsInstantiationOfSameGenericType (Type type, Type parent)
                {
                        int tcount = GetNumberOfTypeArguments (type);
                        int pcount = GetNumberOfTypeArguments (parent);
 
-                       if (type.IsGenericInstance)
-                               type = type.GetGenericTypeDefinition ();
-                       if (parent.IsGenericInstance)
-                               parent = parent.GetGenericTypeDefinition ();
-
                        if (tcount != pcount)
                                return false;
 
+                       type = DropGenericTypeArguments (type);
+                       parent = DropGenericTypeArguments (parent);
+
                        return type.Equals (parent);
                }
 
-               static public bool IsGenericMethod (MethodBase mb)
+               /// <summary>
+               ///   Whether `mb' is a generic method definition.
+               /// </summary>
+               public static bool IsGenericMethod (MethodBase mb)
                {
                        if (mb.DeclaringType is TypeBuilder) {
                                IMethodData method = (IMethodData) builder_to_method [mb];
@@ -2062,6 +2401,12 @@ namespace Mono.CSharp {
                        return true;
                }
 
+               /// <summary>
+               ///   Type inference.  Try to infer the type arguments from the params method
+               ///   `method', which is invoked with the arguments `arguments'.  This is used
+               ///   when resolving an Invocation or a DelegateInvocation and the user
+               ///   did not explicitly specify type arguments.
+               /// </summary>
                public static bool InferParamsTypeArguments (EmitContext ec, ArrayList arguments,
                                                             ref MethodBase method)
                {
@@ -2132,7 +2477,8 @@ namespace Mono.CSharp {
                        return true;
                }
 
-               public static bool InferTypeArguments (Type[] param_types, Type[] arg_types, Type[] infered_types)
+               static bool InferTypeArguments (Type[] param_types, Type[] arg_types,
+                                               Type[] infered_types)
                {
                        if (infered_types == null)
                                return false;
@@ -2152,6 +2498,12 @@ namespace Mono.CSharp {
                        return true;
                }
 
+               /// <summary>
+               ///   Type inference.  Try to infer the type arguments from `method',
+               ///   which is invoked with the arguments `arguments'.  This is used
+               ///   when resolving an Invocation or a DelegateInvocation and the user
+               ///   did not explicitly specify type arguments.
+               /// </summary>
                public static bool InferTypeArguments (EmitContext ec, ArrayList arguments,
                                                       ref MethodBase method)
                {
@@ -2203,6 +2555,9 @@ namespace Mono.CSharp {
                        return true;
                }
 
+               /// <summary>
+               ///   Type inference.
+               /// </summary>
                public static bool InferTypeArguments (EmitContext ec, ParameterData apd,
                                                       ref MethodBase method)
                {
@@ -2233,11 +2588,7 @@ namespace Mono.CSharp {
 
                public static bool IsNullableType (Type t)
                {
-                       if (!t.IsGenericInstance)
-                               return false;
-
-                       Type gt = t.GetGenericTypeDefinition ();
-                       return gt == generic_nullable_type;
+                       return generic_nullable_type == DropGenericTypeArguments (t);
                }
        }
 
@@ -2256,8 +2607,8 @@ namespace Mono.CSharp {
                                Type = type;
                                UnderlyingType = TypeManager.GetTypeArguments (type) [0];
 
-                               PropertyInfo has_value_pi = type.GetProperty ("HasValue");
-                               PropertyInfo value_pi = type.GetProperty ("Value");
+                               PropertyInfo has_value_pi = TypeManager.GetProperty (type, "HasValue");
+                               PropertyInfo value_pi = TypeManager.GetProperty (type, "Value");
 
                                HasValue = has_value_pi.GetGetMethod (false);
                                Value = value_pi.GetGetMethod (false);
@@ -2698,13 +3049,19 @@ namespace Mono.CSharp {
                                Label true_label = ig.DefineLabel ();
                                Label end_label = ig.DefineLabel ();
 
+                               bool false_label_used = false;
+                               bool true_label_used = false;
+
                                if (left_unwrap != null) {
                                        left_unwrap.EmitCheck (ec);
                                        if (right is NullLiteral) {
-                                               if (Oper == Binary.Operator.Equality)
+                                               if (Oper == Binary.Operator.Equality) {
+                                                       true_label_used = true;
                                                        ig.Emit (OpCodes.Brfalse, true_label);
-                                               else
+                                               } else {
+                                                       false_label_used = true;
                                                        ig.Emit (OpCodes.Brfalse, false_label);
+                                               }
                                        } else if (right_unwrap != null) {
                                                ig.Emit (OpCodes.Dup);
                                                ig.Emit (OpCodes.Brtrue, left_not_null_label);
@@ -2719,25 +3076,34 @@ namespace Mono.CSharp {
                                                ig.MarkLabel (left_not_null_label);
                                                ig.Emit (OpCodes.Pop);
                                        } else {
-                                               if (Oper == Binary.Operator.Equality)
+                                               if (Oper == Binary.Operator.Equality) {
+                                                       false_label_used = true;
                                                        ig.Emit (OpCodes.Brfalse, false_label);
-                                               else
+                                               } else {
+                                                       true_label_used = true;
                                                        ig.Emit (OpCodes.Brfalse, true_label);
+                                               }
                                        }
                                }
 
                                if (right_unwrap != null) {
                                        right_unwrap.EmitCheck (ec);
                                        if (left is NullLiteral) {
-                                               if (Oper == Binary.Operator.Equality)
+                                               if (Oper == Binary.Operator.Equality) {
+                                                       true_label_used = true;
                                                        ig.Emit (OpCodes.Brfalse, true_label);
-                                               else
+                                               } else {
+                                                       false_label_used = true;
                                                        ig.Emit (OpCodes.Brfalse, false_label);
+                                               }
                                        } else {
-                                               if (Oper == Binary.Operator.Equality)
+                                               if (Oper == Binary.Operator.Equality) {
+                                                       false_label_used = true;
                                                        ig.Emit (OpCodes.Brfalse, false_label);
-                                               else
+                                               } else {
+                                                       true_label_used = true;
                                                        ig.Emit (OpCodes.Brfalse, true_label);
+                                               }
                                        }
                                }
 
@@ -2745,21 +3111,28 @@ namespace Mono.CSharp {
                                bool right_is_null = right is NullLiteral;
                                if (left_is_null || right_is_null) {
                                        if (((Oper == Binary.Operator.Equality) && (left_is_null == right_is_null)) ||
-                                           ((Oper == Binary.Operator.Inequality) && (left_is_null != right_is_null)))
+                                           ((Oper == Binary.Operator.Inequality) && (left_is_null != right_is_null))) {
+                                               true_label_used = true;
                                                ig.Emit (OpCodes.Br, true_label);
-                                       else
+                                       } else {
+                                               false_label_used = true;
                                                ig.Emit (OpCodes.Br, false_label);
+                                       }
                                } else {
                                        underlying.Emit (ec);
                                        ig.Emit (OpCodes.Br, end_label);
                                }
 
                                ig.MarkLabel (false_label);
-                               ig.Emit (OpCodes.Ldc_I4_0);
-                               ig.Emit (OpCodes.Br, end_label);
+                               if (false_label_used) {
+                                       ig.Emit (OpCodes.Ldc_I4_0);
+                                       if (true_label_used)
+                                               ig.Emit (OpCodes.Br, end_label);
+                               }
 
                                ig.MarkLabel (true_label);
-                               ig.Emit (OpCodes.Ldc_I4_1);
+                               if (true_label_used)
+                                       ig.Emit (OpCodes.Ldc_I4_1);
 
                                ig.MarkLabel (end_label);
                        }