merge -r 58060:58217
[mono.git] / mcs / gmcs / expression.cs
index 6a3e5433f6d05cca75ee9534b0e13e8f9fd2bbc3..3985cd5818cf8a0f8661dba3622bf71368784743 100644 (file)
@@ -3,6 +3,7 @@
 //
 // Author:
 //   Miguel de Icaza (miguel@ximian.com)
+//   Marek Safar (marek.safar@seznam.cz)
 //
 // (C) 2001, 2002, 2003 Ximian, Inc.
 // (C) 2003, 2004 Novell, Inc.
@@ -94,7 +95,6 @@ namespace Mono.CSharp {
                public ParenthesizedExpression (Expression expr)
                {
                        this.Expr = expr;
-                       this.loc = expr.Location;
                }
 
                public override Expression DoResolve (EmitContext ec)
@@ -107,6 +107,13 @@ namespace Mono.CSharp {
                {
                        throw new Exception ("Should not happen");
                }
+
+               public override Location Location
+               {
+                       get {
+                               return Expr.Location;
+                       }
+               }
        }
        
        /// <summary>
@@ -188,37 +195,37 @@ namespace Mono.CSharp {
                        Expression e = null;
 
                        if (expr is IntConstant)
-                               e = new IntConstant (-((IntConstant) expr).Value);
+                               e = new IntConstant (-((IntConstant) expr).Value, expr.Location);
                        else if (expr is UIntConstant){
                                uint value = ((UIntConstant) expr).Value;
 
                                if (value < 2147483649)
-                                       return new IntConstant (-(int)value);
+                                       return new IntConstant (-(int)value, expr.Location);
                                else
-                                       e = new LongConstant (-value);
+                                       e = new LongConstant (-value, expr.Location);
                        }
                        else if (expr is LongConstant)
-                               e = new LongConstant (-((LongConstant) expr).Value);
+                               e = new LongConstant (-((LongConstant) expr).Value, expr.Location);
                        else if (expr is ULongConstant){
                                ulong value = ((ULongConstant) expr).Value;
 
                                if (value < 9223372036854775809)
-                                       return new LongConstant(-(long)value);
+                                       return new LongConstant(-(long)value, expr.Location);
                        }
                        else if (expr is FloatConstant)
-                               e = new FloatConstant (-((FloatConstant) expr).Value);
+                               e = new FloatConstant (-((FloatConstant) expr).Value, expr.Location);
                        else if (expr is DoubleConstant)
-                               e = new DoubleConstant (-((DoubleConstant) expr).Value);
+                               e = new DoubleConstant (-((DoubleConstant) expr).Value, expr.Location);
                        else if (expr is DecimalConstant)
-                               e = new DecimalConstant (-((DecimalConstant) expr).Value);
+                               e = new DecimalConstant (-((DecimalConstant) expr).Value, expr.Location);
                        else if (expr is ShortConstant)
-                               e = new IntConstant (-((ShortConstant) expr).Value);
+                               e = new IntConstant (-((ShortConstant) expr).Value, expr.Location);
                        else if (expr is UShortConstant)
-                               e = new IntConstant (-((UShortConstant) expr).Value);
+                               e = new IntConstant (-((UShortConstant) expr).Value, expr.Location);
                        else if (expr is SByteConstant)
-                               e = new IntConstant (-((SByteConstant) expr).Value);
+                               e = new IntConstant (-((SByteConstant) expr).Value, expr.Location);
                        else if (expr is ByteConstant)
-                               e = new IntConstant (-((ByteConstant) expr).Value);
+                               e = new IntConstant (-((ByteConstant) expr).Value, expr.Location);
                        return e;
                }
 
@@ -255,7 +262,7 @@ namespace Mono.CSharp {
                                }
                                
                                BoolConstant b = (BoolConstant) e;
-                               result = new BoolConstant (!(b.Value));
+                               result = new BoolConstant (!(b.Value), b.Location);
                                return true;
                                
                        case Operator.OnesComplement:
@@ -304,13 +311,13 @@ namespace Mono.CSharp {
                                }
 
                                if (expr_type == TypeManager.int32_type){
-                                       result = new IntConstant (~ ((IntConstant) e).Value);
+                                       result = new IntConstant (~ ((IntConstant) e).Value, e.Location);
                                } else if (expr_type == TypeManager.uint32_type){
-                                       result = new UIntConstant (~ ((UIntConstant) e).Value);
+                                       result = new UIntConstant (~ ((UIntConstant) e).Value, e.Location);
                                } else if (expr_type == TypeManager.int64_type){
-                                       result = new LongConstant (~ ((LongConstant) e).Value);
+                                       result = new LongConstant (~ ((LongConstant) e).Value, e.Location);
                                } else if (expr_type == TypeManager.uint64_type){
-                                       result = new ULongConstant (~ ((ULongConstant) e).Value);
+                                       result = new ULongConstant (~ ((ULongConstant) e).Value, e.Location);
                                } else {
                                        result = null;
                                        Error23 (expr_type);
@@ -1027,7 +1034,7 @@ namespace Mono.CSharp {
        public abstract class Probe : Expression {
                public Expression ProbeType;
                protected Expression expr;
-               protected Type probe_type;
+               protected TypeExpr probe_type_expr;
                
                public Probe (Expression expr, Expression probe_type, Location l)
                {
@@ -1044,12 +1051,11 @@ namespace Mono.CSharp {
 
                public override Expression DoResolve (EmitContext ec)
                {
-                       TypeExpr texpr = ProbeType.ResolveAsTypeTerminal (ec);
-                       if (texpr == null)
+                       probe_type_expr = ProbeType.ResolveAsTypeTerminal (ec);
+                       if (probe_type_expr == null)
+                               return null;
+                       if (probe_type_expr.ResolveType (ec) == null)
                                return null;
-                       probe_type = texpr.Type;
-
-                       CheckObsoleteAttribute (probe_type);
 
                        expr = expr.Resolve (ec);
                        if (expr == null)
@@ -1101,7 +1107,7 @@ namespace Mono.CSharp {
                                ig.Emit (OpCodes.Ceq);
                                return;
                        case Action.Probe:
-                               ig.Emit (OpCodes.Isinst, probe_type);
+                               ig.Emit (OpCodes.Isinst, probe_type_expr.Type);
                                ig.Emit (OpCodes.Ldnull);
                                ig.Emit (OpCodes.Cgt_Un);
                                return;
@@ -1131,7 +1137,7 @@ namespace Mono.CSharp {
                                return;
                        case Action.Probe:
                                expr.Emit (ec);
-                               ig.Emit (OpCodes.Isinst, probe_type);
+                               ig.Emit (OpCodes.Isinst, probe_type_expr.Type);
                                ig.Emit (onTrue ? OpCodes.Brtrue : OpCodes.Brfalse, target);
                                return;
                        }
@@ -1156,6 +1162,7 @@ namespace Mono.CSharp {
                        // First case, if at compile time, there is an implicit conversion
                        // then e != null (objects) or true (value types)
                        //
+                       Type probe_type = probe_type_expr.Type;
                        e = Convert.ImplicitConversionStandard (ec, expr, probe_type, loc);
                        if (e != null && !(e is NullCast)){
                                expr = e;
@@ -1202,6 +1209,7 @@ namespace Mono.CSharp {
                }
 
                bool do_isinst = false;
+               Expression resolved_type;
                
                public override void Emit (EmitContext ec)
                {
@@ -1210,7 +1218,7 @@ namespace Mono.CSharp {
                        expr.Emit (ec);
 
                        if (do_isinst)
-                               ig.Emit (OpCodes.Isinst, probe_type);
+                               ig.Emit (OpCodes.Isinst, probe_type_expr.Type);
                }
 
                static void Error_CannotConvertType (Type source, Type target, Location loc)
@@ -1222,30 +1230,56 @@ namespace Mono.CSharp {
                
                public override Expression DoResolve (EmitContext ec)
                {
-                       Expression e = base.DoResolve (ec);
+                       if (resolved_type == null) {
+                               resolved_type = base.DoResolve (ec);
 
-                       if (e == null)
-                               return null;
+                               if (resolved_type == null)
+                                       return null;
+                       }
 
-                       type = probe_type;
+                       type = probe_type_expr.Type;
                        eclass = ExprClass.Value;
                        Type etype = expr.Type;
 
-                       if (probe_type.IsValueType) {
+                       if (type.IsValueType) {
                                Report.Error (77, loc, "The as operator must be used with a reference type (`" +
-                                             TypeManager.CSharpName (probe_type) + "' is a value type)");
+                                             TypeManager.CSharpName (type) + "' is a value type)");
                                return null;
                        
                        }
+
+                       //
+                       // If the type is a type parameter, ensure
+                       // that it is constrained by a class
+                       //
+                       TypeParameterExpr tpe = probe_type_expr as TypeParameterExpr;
+                       if (tpe != null){
+                               Constraints constraints = tpe.TypeParameter.Constraints;
+                               bool error = false;
+                               
+                               if (constraints == null)
+                                       error = true;
+                               else {
+                                       if (!constraints.HasClassConstraint)
+                                               if ((constraints.Attributes & GenericParameterAttributes.ReferenceTypeConstraint) == 0)
+                                                       error = true;
+                               }
+                               if (error){
+                                       Report.Error (413, loc,
+                                                     "The as operator requires that the `{0}' type parameter be constrained by a class",
+                                                     probe_type_expr.GetSignatureForError ());
+                                       return null;
+                               }
+                       }
                        
-                       e = Convert.ImplicitConversion (ec, expr, probe_type, loc);
+                       Expression e = Convert.ImplicitConversion (ec, expr, type, loc);
                        if (e != null){
                                expr = e;
                                do_isinst = false;
                                return this;
                        }
 
-                       if (Convert.ExplicitReferenceConversionExists (etype, probe_type)){
+                       if (Convert.ExplicitReferenceConversionExists (etype, type)){
                                if (etype.IsGenericParameter)
                                        expr = new BoxedCast (expr, etype);
 
@@ -1253,7 +1287,7 @@ namespace Mono.CSharp {
                                return this;
                        }
 
-                       Error_CannotConvertType (etype, probe_type, loc);
+                       Error_CannotConvertType (etype, type, loc);
                        return null;
                }                               
        }
@@ -1294,503 +1328,6 @@ namespace Mono.CSharp {
                                expr = value;
                        }
                }
-
-               bool CheckRange (EmitContext ec, long value, Type type, long min, long max)
-               {
-                       if (!ec.ConstantCheckState)
-                               return true;
-
-                       if ((value < min) || (value > max)) {
-                               Error (221, "Constant value `" + value + "' cannot be converted " +
-                                      "to a `" + TypeManager.CSharpName (type) + "' (use `unchecked' " +
-                                      "syntax to override)");
-                               return false;
-                       }
-
-                       return true;
-               }
-
-               bool CheckRange (EmitContext ec, ulong value, Type type, ulong max)
-               {
-                       if (!ec.ConstantCheckState)
-                               return true;
-
-                       if (value > max) {
-                               Error (221, "Constant value `" + value + "' cannot be converted " +
-                                      "to a `" + TypeManager.CSharpName (type) + "' (use `unchecked' " +
-                                      "syntax to override)");
-                               return false;
-                       }
-
-                       return true;
-               }
-
-               bool CheckUnsigned (EmitContext ec, long value, Type type)
-               {
-                       if (!ec.ConstantCheckState)
-                               return true;
-
-                       if (value < 0) {
-                               Error (221, "Constant value `" + value + "' cannot be converted " +
-                                      "to a `" + TypeManager.CSharpName (type) + "' (use `unchecked' " +
-                                      "syntax to override)");
-                               return false;
-                       }
-
-                       return true;
-               }
-
-               // TODO: move to constant
-               /// <summary>
-               ///   Attempts to do a compile-time folding of a constant cast.
-               /// </summary>
-               Expression TryReduce (EmitContext ec, Type target_type)
-               {
-                       if (expr.Type == target_type)
-                               return expr;
-
-                       if (TypeManager.IsEnumType (target_type) && TypeManager.EnumToUnderlying (target_type) == expr.Type)
-                               return new EnumConstant ((Constant)expr, target_type);
-
-                       Expression real_expr = expr;
-                       if (real_expr is EnumConstant)
-                               real_expr = ((EnumConstant) real_expr).Child;
-                               
-                       if (real_expr is ByteConstant){
-                               byte v = ((ByteConstant) real_expr).Value;
-       
-                               if (target_type == TypeManager.sbyte_type) {
-                                       if (!CheckRange (ec, v, target_type, SByte.MinValue, SByte.MaxValue))
-                                               return null;
-                                       return new SByteConstant ((sbyte) v);
-                               }
-                               if (target_type == TypeManager.short_type)
-                                       return new ShortConstant ((short) v);
-                               if (target_type == TypeManager.ushort_type)
-                                       return new UShortConstant ((ushort) v);
-                               if (target_type == TypeManager.int32_type)
-                                       return new IntConstant ((int) v);
-                               if (target_type == TypeManager.uint32_type)
-                                       return new UIntConstant ((uint) v);
-                               if (target_type == TypeManager.int64_type)
-                                       return new LongConstant ((long) v);
-                               if (target_type == TypeManager.uint64_type)
-                                       return new ULongConstant ((ulong) v);
-                               if (target_type == TypeManager.float_type)
-                                       return new FloatConstant ((float) v);
-                               if (target_type == TypeManager.double_type)
-                                       return new DoubleConstant ((double) v);
-                               if (target_type == TypeManager.char_type)
-                                       return new CharConstant ((char) v);
-                               if (target_type == TypeManager.decimal_type)
-                                       return new DecimalConstant ((decimal) v);
-                       }
-                       if (real_expr is SByteConstant){
-                               sbyte v = ((SByteConstant) real_expr).Value;
-       
-                               if (target_type == TypeManager.byte_type) {
-                                       if (!CheckUnsigned (ec, v, target_type))
-                                               return null;
-                                       return new ByteConstant ((byte) v);
-                               }
-                               if (target_type == TypeManager.short_type)
-                                       return new ShortConstant ((short) v);
-                               if (target_type == TypeManager.ushort_type) {
-                                       if (!CheckUnsigned (ec, v, target_type))
-                                               return null;
-                                       return new UShortConstant ((ushort) v);
-                               } if (target_type == TypeManager.int32_type)
-                                       return new IntConstant ((int) v);
-                               if (target_type == TypeManager.uint32_type) {
-                                       if (!CheckUnsigned (ec, v, target_type))
-                                               return null;
-                                       return new UIntConstant ((uint) v);
-                               } if (target_type == TypeManager.int64_type)
-                                       return new LongConstant ((long) v);
-                               if (target_type == TypeManager.uint64_type) {
-                                       if (!CheckUnsigned (ec, v, target_type))
-                                               return null;
-                                       return new ULongConstant ((ulong) v);
-                               }
-                               if (target_type == TypeManager.float_type)
-                                       return new FloatConstant ((float) v);
-                               if (target_type == TypeManager.double_type)
-                                       return new DoubleConstant ((double) v);
-                               if (target_type == TypeManager.char_type) {
-                                       if (!CheckUnsigned (ec, v, target_type))
-                                               return null;
-                                       return new CharConstant ((char) v);
-                               }
-                               if (target_type == TypeManager.decimal_type)
-                                       return new DecimalConstant ((decimal) v);
-                       }
-                       if (real_expr is ShortConstant){
-                               short v = ((ShortConstant) real_expr).Value;
-       
-                               if (target_type == TypeManager.byte_type) {
-                                       if (!CheckRange (ec, v, target_type, Byte.MinValue, Byte.MaxValue))
-                                               return null;
-                                       return new ByteConstant ((byte) v);
-                               }
-                               if (target_type == TypeManager.sbyte_type) {
-                                       if (!CheckRange (ec, v, target_type, SByte.MinValue, SByte.MaxValue))
-                                               return null;
-                                       return new SByteConstant ((sbyte) v);
-                               }
-                               if (target_type == TypeManager.ushort_type) {
-                                       if (!CheckUnsigned (ec, v, target_type))
-                                               return null;
-                                       return new UShortConstant ((ushort) v);
-                               }
-                               if (target_type == TypeManager.int32_type)
-                                       return new IntConstant ((int) v);
-                               if (target_type == TypeManager.uint32_type) {
-                                       if (!CheckUnsigned (ec, v, target_type))
-                                               return null;
-                                       return new UIntConstant ((uint) v);
-                               }
-                               if (target_type == TypeManager.int64_type)
-                                       return new LongConstant ((long) v);
-                               if (target_type == TypeManager.uint64_type) {
-                                       if (!CheckUnsigned (ec, v, target_type))
-                                               return null;
-                                       return new ULongConstant ((ulong) v);
-                               }
-                               if (target_type == TypeManager.float_type)
-                                       return new FloatConstant ((float) v);
-                               if (target_type == TypeManager.double_type)
-                                       return new DoubleConstant ((double) v);
-                               if (target_type == TypeManager.char_type) {
-                                       if (!CheckRange (ec, v, target_type, Char.MinValue, Char.MaxValue))
-                                               return null;
-                                       return new CharConstant ((char) v);
-                               }
-                               if (target_type == TypeManager.decimal_type)
-                                       return new DecimalConstant ((decimal) v);
-                       }
-                       if (real_expr is UShortConstant){
-                               ushort v = ((UShortConstant) real_expr).Value;
-       
-                               if (target_type == TypeManager.byte_type) {
-                                       if (!CheckRange (ec, v, target_type, Byte.MinValue, Byte.MaxValue))
-                                               return null;
-                                       return new ByteConstant ((byte) v);
-                               }
-                               if (target_type == TypeManager.sbyte_type) {
-                                       if (!CheckRange (ec, v, target_type, SByte.MinValue, SByte.MaxValue))
-                                               return null;
-                                       return new SByteConstant ((sbyte) v);
-                               }
-                               if (target_type == TypeManager.short_type) {
-                                       if (!CheckRange (ec, v, target_type, Int16.MinValue, Int16.MaxValue))
-                                               return null;
-                                       return new ShortConstant ((short) v);
-                               }
-                               if (target_type == TypeManager.int32_type)
-                                       return new IntConstant ((int) v);
-                               if (target_type == TypeManager.uint32_type)
-                                       return new UIntConstant ((uint) v);
-                               if (target_type == TypeManager.int64_type)
-                                       return new LongConstant ((long) v);
-                               if (target_type == TypeManager.uint64_type)
-                                       return new ULongConstant ((ulong) v);
-                               if (target_type == TypeManager.float_type)
-                                       return new FloatConstant ((float) v);
-                               if (target_type == TypeManager.double_type)
-                                       return new DoubleConstant ((double) v);
-                               if (target_type == TypeManager.char_type) {
-                                       if (!CheckRange (ec, v, target_type, Char.MinValue, Char.MaxValue))
-                                               return null;
-                                       return new CharConstant ((char) v);
-                               }
-                               if (target_type == TypeManager.decimal_type)
-                                       return new DecimalConstant ((decimal) v);
-                       }
-                       if (real_expr is IntConstant){
-                               int v = ((IntConstant) real_expr).Value;
-       
-                               if (target_type == TypeManager.byte_type) {
-                                       if (!CheckRange (ec, v, target_type, Byte.MinValue, Byte.MaxValue))
-                                               return null;
-                                       return new ByteConstant ((byte) v);
-                               }
-                               if (target_type == TypeManager.sbyte_type) {
-                                       if (!CheckRange (ec, v, target_type, SByte.MinValue, SByte.MaxValue))
-                                               return null;
-                                       return new SByteConstant ((sbyte) v);
-                               }
-                               if (target_type == TypeManager.short_type) {
-                                       if (!CheckRange (ec, v, target_type, Int16.MinValue, Int16.MaxValue))
-                                               return null;
-                                       return new ShortConstant ((short) v);
-                               }
-                               if (target_type == TypeManager.ushort_type) {
-                                       if (!CheckRange (ec, v, target_type, UInt16.MinValue, UInt16.MaxValue))
-                                               return null;
-                                       return new UShortConstant ((ushort) v);
-                               }
-                               if (target_type == TypeManager.uint32_type) {
-                                       if (!CheckRange (ec, v, target_type, Int32.MinValue, Int32.MaxValue))
-                                               return null;
-                                       return new UIntConstant ((uint) v);
-                               }
-                               if (target_type == TypeManager.int64_type)
-                                       return new LongConstant ((long) v);
-                               if (target_type == TypeManager.uint64_type) {
-                                       if (!CheckUnsigned (ec, v, target_type))
-                                               return null;
-                                       return new ULongConstant ((ulong) v);
-                               }
-                               if (target_type == TypeManager.float_type)
-                                       return new FloatConstant ((float) v);
-                               if (target_type == TypeManager.double_type)
-                                       return new DoubleConstant ((double) v);
-                               if (target_type == TypeManager.char_type) {
-                                       if (!CheckRange (ec, v, target_type, Char.MinValue, Char.MaxValue))
-                                               return null;
-                                       return new CharConstant ((char) v);
-                               }
-                               if (target_type == TypeManager.decimal_type)
-                                       return new DecimalConstant ((decimal) v);
-                       }
-                       if (real_expr is UIntConstant){
-                               uint v = ((UIntConstant) real_expr).Value;
-       
-                               if (target_type == TypeManager.byte_type) {
-                                       if (!CheckRange (ec, v, target_type, Char.MinValue, Char.MaxValue))
-                                               return null;
-                                       return new ByteConstant ((byte) v);
-                               }
-                               if (target_type == TypeManager.sbyte_type) {
-                                       if (!CheckRange (ec, v, target_type, SByte.MinValue, SByte.MaxValue))
-                                               return null;
-                                       return new SByteConstant ((sbyte) v);
-                               }
-                               if (target_type == TypeManager.short_type) {
-                                       if (!CheckRange (ec, v, target_type, Int16.MinValue, Int16.MaxValue))
-                                               return null;
-                                       return new ShortConstant ((short) v);
-                               }
-                               if (target_type == TypeManager.ushort_type) {
-                                       if (!CheckRange (ec, v, target_type, UInt16.MinValue, UInt16.MaxValue))
-                                               return null;
-                                       return new UShortConstant ((ushort) v);
-                               }
-                               if (target_type == TypeManager.int32_type) {
-                                       if (!CheckRange (ec, v, target_type, Int32.MinValue, Int32.MaxValue))
-                                               return null;
-                                       return new IntConstant ((int) v);
-                               }
-                               if (target_type == TypeManager.int64_type)
-                                       return new LongConstant ((long) v);
-                               if (target_type == TypeManager.uint64_type)
-                                       return new ULongConstant ((ulong) v);
-                               if (target_type == TypeManager.float_type)
-                                       return new FloatConstant ((float) v);
-                               if (target_type == TypeManager.double_type)
-                                       return new DoubleConstant ((double) v);
-                               if (target_type == TypeManager.char_type) {
-                                       if (!CheckRange (ec, v, target_type, Char.MinValue, Char.MaxValue))
-                                               return null;
-                                       return new CharConstant ((char) v);
-                               }
-                               if (target_type == TypeManager.decimal_type)
-                                       return new DecimalConstant ((decimal) v);
-                       }
-                       if (real_expr is LongConstant){
-                               long v = ((LongConstant) real_expr).Value;
-       
-                               if (target_type == TypeManager.byte_type) {
-                                       if (!CheckRange (ec, v, target_type, Byte.MinValue, Byte.MaxValue))
-                                               return null;
-                                       return new ByteConstant ((byte) v);
-                               }
-                               if (target_type == TypeManager.sbyte_type) {
-                                       if (!CheckRange (ec, v, target_type, SByte.MinValue, SByte.MaxValue))
-                                               return null;
-                                       return new SByteConstant ((sbyte) v);
-                               }
-                               if (target_type == TypeManager.short_type) {
-                                       if (!CheckRange (ec, v, target_type, Int16.MinValue, Int16.MaxValue))
-                                               return null;
-                                       return new ShortConstant ((short) v);
-                               }
-                               if (target_type == TypeManager.ushort_type) {
-                                       if (!CheckRange (ec, v, target_type, UInt16.MinValue, UInt16.MaxValue))
-                                               return null;
-                                       return new UShortConstant ((ushort) v);
-                               }
-                               if (target_type == TypeManager.int32_type) {
-                                       if (!CheckRange (ec, v, target_type, Int32.MinValue, Int32.MaxValue))
-                                               return null;
-                                       return new IntConstant ((int) v);
-                               }
-                               if (target_type == TypeManager.uint32_type) {
-                                       if (!CheckRange (ec, v, target_type, UInt32.MinValue, UInt32.MaxValue))
-                                               return null;
-                                       return new UIntConstant ((uint) v);
-                               }
-                               if (target_type == TypeManager.uint64_type) {
-                                       if (!CheckUnsigned (ec, v, target_type))
-                                               return null;
-                                       return new ULongConstant ((ulong) v);
-                               }
-                               if (target_type == TypeManager.float_type)
-                                       return new FloatConstant ((float) v);
-                               if (target_type == TypeManager.double_type)
-                                       return new DoubleConstant ((double) v);
-                               if (target_type == TypeManager.char_type) {
-                                       if (!CheckRange (ec, v, target_type, Char.MinValue, Char.MaxValue))
-                                               return null;
-                                       return new CharConstant ((char) v);
-                               }
-                               if (target_type == TypeManager.decimal_type)
-                                       return new DecimalConstant ((decimal) v);
-                       }
-                       if (real_expr is ULongConstant){
-                               ulong v = ((ULongConstant) real_expr).Value;
-       
-                               if (target_type == TypeManager.byte_type) {
-                                       if (!CheckRange (ec, v, target_type, Byte.MaxValue))
-                                               return null;
-                                       return new ByteConstant ((byte) v);
-                               }
-                               if (target_type == TypeManager.sbyte_type) {
-                                       if (!CheckRange (ec, v, target_type, (ulong) SByte.MaxValue))
-                                               return null;
-                                       return new SByteConstant ((sbyte) v);
-                               }
-                               if (target_type == TypeManager.short_type) {
-                                       if (!CheckRange (ec, v, target_type, (ulong) Int16.MaxValue))
-                                               return null;
-                                       return new ShortConstant ((short) v);
-                               }
-                               if (target_type == TypeManager.ushort_type) {
-                                       if (!CheckRange (ec, v, target_type, UInt16.MaxValue))
-                                               return null;
-                                       return new UShortConstant ((ushort) v);
-                               }
-                               if (target_type == TypeManager.int32_type) {
-                                       if (!CheckRange (ec, v, target_type, Int32.MaxValue))
-                                               return null;
-                                       return new IntConstant ((int) v);
-                               }
-                               if (target_type == TypeManager.uint32_type) {
-                                       if (!CheckRange (ec, v, target_type, UInt32.MaxValue))
-                                               return null;
-                                       return new UIntConstant ((uint) v);
-                               }
-                               if (target_type == TypeManager.int64_type) {
-                                       if (!CheckRange (ec, v, target_type, (ulong) Int64.MaxValue))
-                                               return null;
-                                       return new LongConstant ((long) v);
-                               }
-                               if (target_type == TypeManager.float_type)
-                                       return new FloatConstant ((float) v);
-                               if (target_type == TypeManager.double_type)
-                                       return new DoubleConstant ((double) v);
-                               if (target_type == TypeManager.char_type) {
-                                       if (!CheckRange (ec, v, target_type, Char.MaxValue))
-                                               return null;
-                                       return new CharConstant ((char) v);
-                               }
-                               if (target_type == TypeManager.decimal_type)
-                                       return new DecimalConstant ((decimal) v);
-                       }
-                       if (real_expr is FloatConstant){
-                               float v = ((FloatConstant) real_expr).Value;
-       
-                               if (target_type == TypeManager.byte_type)
-                                       return new ByteConstant ((byte) v);
-                               if (target_type == TypeManager.sbyte_type)
-                                       return new SByteConstant ((sbyte) v);
-                               if (target_type == TypeManager.short_type)
-                                       return new ShortConstant ((short) v);
-                               if (target_type == TypeManager.ushort_type)
-                                       return new UShortConstant ((ushort) v);
-                               if (target_type == TypeManager.int32_type)
-                                       return new IntConstant ((int) v);
-                               if (target_type == TypeManager.uint32_type)
-                                       return new UIntConstant ((uint) v);
-                               if (target_type == TypeManager.int64_type)
-                                       return new LongConstant ((long) v);
-                               if (target_type == TypeManager.uint64_type)
-                                       return new ULongConstant ((ulong) v);
-                               if (target_type == TypeManager.double_type)
-                                       return new DoubleConstant ((double) v);
-                               if (target_type == TypeManager.char_type)
-                                       return new CharConstant ((char) v);
-                               if (target_type == TypeManager.decimal_type)
-                                       return new DecimalConstant ((decimal) v);
-                       }
-                       if (real_expr is DoubleConstant){
-                               double v = ((DoubleConstant) real_expr).Value;
-       
-                               if (target_type == TypeManager.byte_type){
-                                       return new ByteConstant ((byte) v);
-                               } if (target_type == TypeManager.sbyte_type)
-                                       return new SByteConstant ((sbyte) v);
-                               if (target_type == TypeManager.short_type)
-                                       return new ShortConstant ((short) v);
-                               if (target_type == TypeManager.ushort_type)
-                                       return new UShortConstant ((ushort) v);
-                               if (target_type == TypeManager.int32_type)
-                                       return new IntConstant ((int) v);
-                               if (target_type == TypeManager.uint32_type)
-                                       return new UIntConstant ((uint) v);
-                               if (target_type == TypeManager.int64_type)
-                                       return new LongConstant ((long) v);
-                               if (target_type == TypeManager.uint64_type)
-                                       return new ULongConstant ((ulong) v);
-                               if (target_type == TypeManager.float_type)
-                                       return new FloatConstant ((float) v);
-                               if (target_type == TypeManager.char_type)
-                                       return new CharConstant ((char) v);
-                               if (target_type == TypeManager.decimal_type)
-                                       return new DecimalConstant ((decimal) v);
-                       }
-
-                       if (real_expr is CharConstant){
-                               char v = ((CharConstant) real_expr).Value;
-                               
-                               if (target_type == TypeManager.byte_type) {
-                                       if (!CheckRange (ec, v, target_type, Byte.MinValue, Byte.MaxValue))
-                                               return null;
-                                       return new ByteConstant ((byte) v);
-                               }
-                               if (target_type == TypeManager.sbyte_type) {
-                                       if (!CheckRange (ec, v, target_type, SByte.MinValue, SByte.MaxValue))
-                                               return null;
-                                       return new SByteConstant ((sbyte) v);
-                               }
-                               if (target_type == TypeManager.short_type) {
-                                       if (!CheckRange (ec, v, target_type, Int16.MinValue, Int16.MaxValue))
-                                               return null;
-                                       return new ShortConstant ((short) v);
-                               }
-                               if (target_type == TypeManager.int32_type)
-                                       return new IntConstant ((int) v);
-                               if (target_type == TypeManager.uint32_type)
-                                       return new UIntConstant ((uint) v);
-                               if (target_type == TypeManager.int64_type)
-                                       return new LongConstant ((long) v);
-                               if (target_type == TypeManager.uint64_type)
-                                       return new ULongConstant ((ulong) v);
-                               if (target_type == TypeManager.float_type)
-                                       return new FloatConstant ((float) v);
-                               if (target_type == TypeManager.double_type)
-                                       return new DoubleConstant ((double) v);
-                               if (target_type == TypeManager.char_type) {
-                                       if (!CheckRange (ec, v, target_type, Char.MinValue, Char.MaxValue))
-                                               return null;
-                                       return new CharConstant ((char) v);
-                               }
-                               if (target_type == TypeManager.decimal_type)
-                                       return new DecimalConstant ((decimal) v);
-                       }
-
-                       return null;
-               }
                
                public override Expression DoResolveLValue (EmitContext ec, Expression right_side)
                {
@@ -1816,9 +1353,7 @@ namespace Mono.CSharp {
                        if (target == null)
                                return null;
                        
-                       type = target.Type;
-
-                       CheckObsoleteAttribute (type);
+                       type = target.ResolveType (ec);
 
                        if (type.IsAbstract && type.IsSealed) {
                                Report.Error (716, loc, "Cannot convert to static type `{0}'", TypeManager.CSharpName (type));
@@ -1827,11 +1362,11 @@ namespace Mono.CSharp {
 
                        eclass = ExprClass.Value;
 
-                       if (expr is Constant){
-                               Expression e = TryReduce (ec, type);
-
-                               if (e != null)
-                                       return e;
+                       Constant c = expr as Constant;
+                       if (c != null) {
+                               c = c.TryReduce (ec, type, loc);
+                               if (c != null)
+                                       return c;
                        }
 
                        if (type.IsPointer && !ec.InUnsafe) {
@@ -1938,7 +1473,7 @@ namespace Mono.CSharp {
                /// <summary>
                ///   Returns a stringified representation of the Operator
                /// </summary>
-               static string OperName (Operator oper)
+               public static string OperName (Operator oper)
                {
                        switch (oper){
                        case Operator.Multiply:
@@ -2074,9 +1609,9 @@ namespace Mono.CSharp {
                                                        long ll = ((LongConstant) right).Value;
 
                                                        if (ll >= 0)
-                                                               right = new ULongConstant ((ulong) ll);
+                                                               right = new ULongConstant ((ulong) ll, right.Location);
                                                } else {
-                                                       e = Convert.ImplicitNumericConversion (ec, right, l, loc);
+                                                       e = Convert.ImplicitNumericConversion (ec, right, l);
                                                        if (e != null)
                                                                right = e;
                                                }
@@ -2091,9 +1626,9 @@ namespace Mono.CSharp {
                                                long ll = ((LongConstant) left).Value;
                                                
                                                if (ll > 0)
-                                                       left = new ULongConstant ((ulong) ll);
+                                                       left = new ULongConstant ((ulong) ll, right.Location);
                                        } else {
-                                               e = Convert.ImplicitNumericConversion (ec, left, r, loc);
+                                               e = Convert.ImplicitNumericConversion (ec, left, r);
                                                if (e != null)
                                                        left = e;
                                        }
@@ -2135,7 +1670,7 @@ namespace Mono.CSharp {
                                                int val = ic.Value;
                                                
                                                if (val >= 0){
-                                                       right = new UIntConstant ((uint) val);
+                                                       right = new UIntConstant ((uint) val, ic.Location);
                                                        type = l;
                                                        
                                                        return true;
@@ -2148,7 +1683,7 @@ namespace Mono.CSharp {
                                                int val = ic.Value;
                                                
                                                if (val >= 0){
-                                                       left = new UIntConstant ((uint) val);
+                                                       left = new UIntConstant ((uint) val, ic.Location);
                                                        type = r;
                                                        return true;
                                                }
@@ -2196,14 +1731,19 @@ namespace Mono.CSharp {
                }
 
                static public void Error_OperatorCannotBeApplied (Location loc, string name, Type l, Type r)
+               {
+                       Error_OperatorCannotBeApplied (loc, name, TypeManager.CSharpName (l), TypeManager.CSharpName (r));
+               }
+
+               public static void Error_OperatorCannotBeApplied (Location loc, string name, string left, string right)
                {
                        Report.Error (19, loc, "Operator `{0}' cannot be applied to operands of type `{1}' and `{2}'",
-                              name, TypeManager.CSharpName (l), TypeManager.CSharpName (r));
+                               name, left, right);
                }
                
                void Error_OperatorCannotBeApplied ()
                {
-                       Error_OperatorCannotBeApplied (loc, OperName (oper), left.Type, right.Type);
+                       Error_OperatorCannotBeApplied (Location, OperName (oper), left.GetSignatureForError (), right.GetSignatureForError ());
                }
 
                static bool is_unsigned (Type t)
@@ -2262,10 +1802,10 @@ namespace Mono.CSharp {
                                type = e.Type;
 
                                if (type == TypeManager.int32_type || type == TypeManager.uint32_type){
-                                       right = new Binary (Binary.Operator.BitwiseAnd, right, new IntLiteral (31));
+                                       right = new Binary (Binary.Operator.BitwiseAnd, right, new IntConstant (31, loc));
                                        right = right.DoResolve (ec);
                                } else {
-                                       right = new Binary (Binary.Operator.BitwiseAnd, right, new IntLiteral (63));
+                                       right = new Binary (Binary.Operator.BitwiseAnd, right, new IntConstant (63, loc));
                                        right = right.DoResolve (ec);
                                }
 
@@ -2384,7 +1924,7 @@ namespace Mono.CSharp {
                                
                                // Simple constant folding
                                if (left is StringConstant && right is StringConstant)
-                                       return new StringConstant (((StringConstant) left).Value + ((StringConstant) right).Value);
+                                       return new StringConstant (((StringConstant) left).Value + ((StringConstant) right).Value, left.Location);
 
                                if (l == TypeManager.string_type || r == TypeManager.string_type) {
 
@@ -2804,6 +2344,43 @@ namespace Mono.CSharp {
                        return this;
                }
 
+               Constant EnumLiftUp (EmitContext ec, Constant left, Constant right)
+               {
+                       switch (oper) {
+                               case Operator.BitwiseOr:
+                               case Operator.BitwiseAnd:
+                               case Operator.ExclusiveOr:
+                               case Operator.Equality:
+                               case Operator.Inequality:
+                               case Operator.LessThan:
+                               case Operator.LessThanOrEqual:
+                               case Operator.GreaterThan:
+                               case Operator.GreaterThanOrEqual:
+                                       if (left is EnumConstant)
+                                               return left;
+
+                                       if (left.IsZeroInteger)
+                                               return new EnumConstant (left, right.Type);
+
+                                       break;
+
+                               case Operator.Addition:
+                               case Operator.Subtraction:
+                                       return left;
+
+                               case Operator.Multiply:
+                               case Operator.Division:
+                               case Operator.Modulus:
+                               case Operator.LeftShift:
+                               case Operator.RightShift:
+                                       if (right is EnumConstant || left is EnumConstant)
+                                               break;
+                                       return left;
+                       }
+                       Error_OperatorCannotBeApplied (loc, Binary.OperName (oper), left.Type, right.Type);
+                       return null;
+               }
+
                public override Expression DoResolve (EmitContext ec)
                {
                        if ((oper == Operator.Subtraction) && (left is ParenthesizedExpression)) {
@@ -2813,7 +2390,7 @@ namespace Mono.CSharp {
                                        return null;
 
                                if (left.eclass == ExprClass.Type) {
-                                       Error (75, "To cast a negative value, you must enclose the value in parentheses");
+                                       Report.Error (75, loc, "To cast a negative value, you must enclose the value in parentheses");
                                        return null;
                                }
                        } else
@@ -2837,9 +2414,19 @@ namespace Mono.CSharp {
                                return null;
 
                        eclass = ExprClass.Value;
-
                        Constant rc = right as Constant;
 
+                       // The conversion rules are ignored in enum context but why
+                       if (!ec.InEnumContext && lc != null && rc != null && (TypeManager.IsEnumType (left.Type) || TypeManager.IsEnumType (right.Type))) {
+                               left = lc = EnumLiftUp (ec, lc, rc);
+                               if (lc == null)
+                                       return null;
+
+                               right = rc = EnumLiftUp (ec, rc, lc);
+                               if (rc == null)
+                                       return null;
+                       }
+
                        if (oper == Operator.BitwiseAnd) {
                                if (rc != null && rc.IsZeroInteger) {
                                        return lc is EnumConstant ?
@@ -2853,6 +2440,19 @@ namespace Mono.CSharp {
                                                lc;
                                }
                        }
+                       else if (oper == Operator.BitwiseOr) {
+                               if (lc is EnumConstant &&
+                                   rc != null && rc.IsZeroInteger)
+                                       return lc;
+                               if (rc is EnumConstant &&
+                                   lc != null && lc.IsZeroInteger)
+                                       return rc;
+                       } else if (oper == Operator.LogicalAnd) {
+                               if (rc != null && rc.IsDefaultValue && rc.Type == TypeManager.bool_type)
+                                       return rc;
+                               if (lc != null && lc.IsDefaultValue && lc.Type == TypeManager.bool_type)
+                                       return lc;
+                       }
 
                        if (rc != null && lc != null){
                                int prev_e = Report.Errors;
@@ -2865,15 +2465,15 @@ namespace Mono.CSharp {
                        if (TypeManager.IsNullableType (left.Type) || TypeManager.IsNullableType (right.Type))
                                return new Nullable.LiftedBinaryOperator (oper, left, right, loc).Resolve (ec);
 
-                       // Check CS0652 warning here (before resolving operator).
-                       if (oper == Operator.Equality ||
-                           oper == Operator.Inequality ||
-                           oper == Operator.LessThanOrEqual ||
-                           oper == Operator.LessThan ||
-                           oper == Operator.GreaterThanOrEqual ||
-                           oper == Operator.GreaterThan){
-                               CheckUselessComparison (left as Constant, right.Type);
-                               CheckUselessComparison (right as Constant, left.Type);
+                       // Comparison warnings
+                       if (oper == Operator.Equality || oper == Operator.Inequality ||
+                           oper == Operator.LessThanOrEqual || oper == Operator.LessThan ||
+                           oper == Operator.GreaterThanOrEqual || oper == Operator.GreaterThan){
+                               if (left.Equals (right)) {
+                                       Report.Warning (1718, 3, loc, "Comparison made to same variable; did you mean to compare something else?");
+                               }
+                               CheckUselessComparison (lc, right.Type);
+                               CheckUselessComparison (rc, left.Type);
                        }
 
                        return ResolveOperator (ec);
@@ -3381,7 +2981,7 @@ namespace Mono.CSharp {
                        if (operand is StringConstant && operands.Count != 0) {
                                StringConstant last_operand = operands [operands.Count - 1] as StringConstant;
                                if (last_operand != null) {
-                                       operands [operands.Count - 1] = new StringConstant (last_operand.Value + ((StringConstant) operand).Value);
+                                       operands [operands.Count - 1] = new StringConstant (last_operand.Value + ((StringConstant) operand).Value, last_operand.Location);
                                        return;
                                }
                        }
@@ -3538,7 +3138,7 @@ namespace Mono.CSharp {
 
                protected void Error19 ()
                {
-                       Binary.Error_OperatorCannotBeApplied (loc, is_and ? "&&" : "||", type, type);
+                       Binary.Error_OperatorCannotBeApplied (loc, is_and ? "&&" : "||", left.GetSignatureForError (), right.GetSignatureForError ());
                }
 
                protected void Error218 ()
@@ -3676,7 +3276,7 @@ namespace Mono.CSharp {
 
                                Constant right_const = right as Constant;
                                if (right_const != null && size != 0) {
-                                       Expression ex = ConstantFold.BinaryFold (ec, Binary.Operator.Multiply, new IntConstant (size), right_const, loc);
+                                       Expression ex = ConstantFold.BinaryFold (ec, Binary.Operator.Multiply, new IntConstant (size, right.Location), right_const, loc);
                                        if (ex == null)
                                                return;
                                        ex.Emit (ec);
@@ -3949,11 +3549,7 @@ namespace Mono.CSharp {
 
                override public Expression DoResolveLValue (EmitContext ec, Expression right_side)
                {
-                       Expression ret = DoResolveBase (ec, right_side);
-                       if (ret != null)
-                               CheckObsoleteAttribute (ret.Type);
-
-                       return ret;
+                       return DoResolveBase (ec, right_side);
                }
 
                public bool VerifyFixed ()
@@ -4272,7 +3868,7 @@ namespace Mono.CSharp {
                        if (ec.HaveCaptureInfo && ec.IsParameterCaptured (name)){
                                if (leave_copy)
                                        throw new InternalErrorException ();
-
+                               
                                ec.EmitParameter (name);
                                return;
                        }
@@ -4369,6 +3965,10 @@ namespace Mono.CSharp {
                        }
                }
 
+               public override string ToString ()
+               {
+                       return "ParameterReference[" + name + "]";
+               }
        }
        
        /// <summary>
@@ -4775,7 +4375,7 @@ namespace Mono.CSharp {
                         return !candidate_params && best_params;
                }
 
-               static bool IsOverride (MethodBase cand_method, MethodBase base_method)
+               internal static bool IsOverride (MethodBase cand_method, MethodBase base_method)
                {
                        if (!IsAncestralType (base_method.DeclaringType, cand_method.DeclaringType))
                                return false;
@@ -5343,7 +4943,7 @@ namespace Mono.CSharp {
                public static void Error_WrongNumArguments (Location loc, String name, int arg_count)
                {
                        Report.Error (1501, loc, "No overload for method `{0}' takes `{1}' arguments",
-                               name, arg_count);
+                               name, arg_count.ToString ());
                }
 
                 static void Error_InvokeOnDelegate (Location loc)
@@ -5362,21 +4962,20 @@ namespace Mono.CSharp {
                                Report.Error (1594, loc, "Delegate `{0}' has some invalid arguments",
                                        TypeManager.CSharpName (delegate_type));
 
-                       string par_desc = expected_par.ParameterDesc (idx);
+                       Parameter.Modifier mod = expected_par.ParameterModifier (idx);
 
-                       if (a.Modifier != expected_par.ParameterModifier (idx)) {
-                               if ((expected_par.ParameterModifier (idx) & (Parameter.Modifier.REF | Parameter.Modifier.OUT)) == 0)
+                       string index = (idx + 1).ToString ();
+                       if (mod != Parameter.Modifier.ARGLIST && mod != a.Modifier) {
+                               if ((mod & (Parameter.Modifier.REF | Parameter.Modifier.OUT)) == 0)
                                        Report.Error (1615, loc, "Argument `{0}' should not be passed with the `{1}' keyword",
-                                               idx + 1, Parameter.GetModifierSignature (a.Modifier));
+                                               index, Parameter.GetModifierSignature (a.Modifier));
                                else
                                        Report.Error (1620, loc, "Argument `{0}' must be passed with the `{1}' keyword",
-                                               idx + 1, Parameter.GetModifierSignature (expected_par.ParameterModifier (idx)));
-                               return;
+                                               index, Parameter.GetModifierSignature (mod));
+                       } else {
+                               Report.Error (1503, loc, "Argument {0}: Cannot convert from `{1}' to `{2}'",
+                                       index, Argument.FullDesc (a), expected_par.ParameterDesc (idx));
                        }
-
-                       Report.Error (1503, loc,
-                                     String.Format ("Argument {0}: Cannot convert from `{1}' to `{2}'",
-                                                    idx + 1, Argument.FullDesc (a), par_desc));
                }
                
                public static bool VerifyArgumentsCompat (EmitContext ec, ArrayList Arguments,
@@ -5397,15 +4996,18 @@ namespace Mono.CSharp {
                                if (pm == Parameter.Modifier.PARAMS){
                                        if ((pm & ~Parameter.Modifier.PARAMS) != a.Modifier) {
                                                if (!may_fail)
-                                                       Error_InvalidArguments (
-                                                               loc, j, method, delegate_type,
-                                                               a, pd);
+                                                       Error_InvalidArguments (loc, j, method, delegate_type, a, pd);
                                                return false;
                                        }
 
                                        if (chose_params_expanded)
                                                parameter_type = TypeManager.GetElementType (parameter_type);
-                               } else if (pm == Parameter.Modifier.ARGLIST){
+                               } else if (pm == Parameter.Modifier.ARGLIST) {
+                                       if (!(a.Expr is Arglist)) {
+                                               if (!may_fail)
+                                                       Error_InvalidArguments (loc, j, method, delegate_type, a, pd);
+                                               return false;
+                                       }
                                        continue;
                                } else {
                                        //
@@ -5413,9 +5015,7 @@ namespace Mono.CSharp {
                                        //
                                        if (pd.ParameterModifier (j) != a.Modifier){
                                                if (!may_fail)
-                                                       Error_InvalidArguments (
-                                                               loc, j, method, delegate_type,
-                                                               a, pd);
+                                                       Error_InvalidArguments (loc, j, method, delegate_type, a, pd);
                                                return false;
                                        }
                                }
@@ -5643,33 +5243,12 @@ namespace Mono.CSharp {
                /// </summary>
                public static void EmitArguments (EmitContext ec, MethodBase mb, ArrayList arguments, bool dup_args, LocalTemporary this_arg)
                {
-                       ParameterData pd;
-                       if (mb != null)
-                               pd = TypeManager.GetParameterData (mb);
-                       else
-                               pd = null;
-                       
+                       ParameterData pd = mb == null ? null : TypeManager.GetParameterData (mb);
+                       int top = arguments == null ? 0 : arguments.Count;
                        LocalTemporary [] temps = null;
                        
-                       if (dup_args)
-                               temps = new LocalTemporary [arguments.Count];
-
-                       //
-                       // If we are calling a params method with no arguments, special case it
-                       //
-                       if (arguments == null){
-                               if (pd != null && pd.Count > 0 &&
-                                   pd.ParameterModifier (0) == Parameter.Modifier.PARAMS){
-                                       ILGenerator ig = ec.ig;
-
-                                       IntConstant.EmitInt (ig, 0);
-                                       ig.Emit (OpCodes.Newarr, TypeManager.GetElementType (pd.ParameterType (0)));
-                               }
-
-                               return;
-                       }
-
-                       int top = arguments.Count;
+                       if (dup_args && top != 0)
+                               temps = new LocalTemporary [top];
 
                        for (int i = 0; i < top; i++){
                                Argument a = (Argument) arguments [i];
@@ -5880,9 +5459,11 @@ namespace Mono.CSharp {
                                        }
 
                                        if (dup_args) {
-                                               this_arg = new LocalTemporary (ec, t);
                                                ig.Emit (OpCodes.Dup);
-                                               this_arg.Store (ec);
+                                               if (Arguments != null && Arguments.Count != 0) {
+                                                       this_arg = new LocalTemporary (ec, t);
+                                                       this_arg.Store (ec);
+                                               }
                                        }
                                }
                        }
@@ -6130,35 +5711,58 @@ namespace Mono.CSharp {
                public static Constant Constantify (Type t)
                {
                        if (t == TypeManager.int32_type)
-                               return new IntConstant (0);
+                               return new IntConstant (0, Location.Null);
                        if (t == TypeManager.uint32_type)
-                               return new UIntConstant (0);
+                               return new UIntConstant (0, Location.Null);
                        if (t == TypeManager.int64_type)
-                               return new LongConstant (0);
+                               return new LongConstant (0, Location.Null);
                        if (t == TypeManager.uint64_type)
-                               return new ULongConstant (0);
+                               return new ULongConstant (0, Location.Null);
                        if (t == TypeManager.float_type)
-                               return new FloatConstant (0);
+                               return new FloatConstant (0, Location.Null);
                        if (t == TypeManager.double_type)
-                               return new DoubleConstant (0);
+                               return new DoubleConstant (0, Location.Null);
                        if (t == TypeManager.short_type)
-                               return new ShortConstant (0);
+                               return new ShortConstant (0, Location.Null);
                        if (t == TypeManager.ushort_type)
-                               return new UShortConstant (0);
+                               return new UShortConstant (0, Location.Null);
                        if (t == TypeManager.sbyte_type)
-                               return new SByteConstant (0);
+                               return new SByteConstant (0, Location.Null);
                        if (t == TypeManager.byte_type)
-                               return new ByteConstant (0);
+                               return new ByteConstant (0, Location.Null);
                        if (t == TypeManager.char_type)
-                               return new CharConstant ('\0');
+                               return new CharConstant ('\0', Location.Null);
                        if (t == TypeManager.bool_type)
-                               return new BoolConstant (false);
+                               return new BoolConstant (false, Location.Null);
                        if (t == TypeManager.decimal_type)
-                               return new DecimalConstant (0);
+                               return new DecimalConstant (0, Location.Null);
 
                        return null;
                }
 
+               //
+               // Checks whether the type is an interface that has the
+               // [ComImport, CoClass] attributes and must be treated
+               // specially
+               //
+               public Expression CheckComImport (EmitContext ec)
+               {
+                       if (!type.IsInterface)
+                               return null;
+
+                       //
+                       // Turn the call into:
+                       // (the-interface-stated) (new class-referenced-in-coclassattribute ())
+                       //
+                       Type real_class = AttributeTester.GetCoClassAttribute (type);
+                       if (real_class == null)
+                               return null;
+
+                       New proxy = new New (new TypeExpression (real_class, loc), Arguments, loc);
+                       Cast cast = new Cast (new TypeExpression (type, loc), proxy, loc);
+                       return cast.Resolve (ec);
+               }
+               
                public override Expression DoResolve (EmitContext ec)
                {
                        //
@@ -6179,19 +5783,15 @@ namespace Mono.CSharp {
                        if (texpr == null)
                                return null;
 
+                       type = texpr.ResolveType (ec);
+
                        if (Arguments == null) {
                                Expression c = Constantify (type);
                                if (c != null)
                                        return c;
                        }
 
-                       type = texpr.Type;
-                       if (type == null)
-                               return null;
-                       
-                       CheckObsoleteAttribute (type);
-
-                       if (TypeManager.IsDelegateType (type)) {
+                       if (TypeManager.IsDelegateType (type)) {
                                RequestedType = (new NewDelegate (type, Arguments, loc)).Resolve (ec);
                                if (RequestedType != null)
                                        if (!(RequestedType is DelegateCreation))
@@ -6231,6 +5831,10 @@ namespace Mono.CSharp {
                        }
 
                        if (type.IsInterface || type.IsAbstract){
+                               RequestedType = CheckComImport (ec);
+                               if (RequestedType != null)
+                                       return RequestedType;
+                               
                                Report.SymbolRelatedToPreviousError (type);
                                Report.Error (144, loc, "Cannot create an instance of the abstract class or interface `{0}'", TypeManager.CSharpName (type));
                                return null;
@@ -6496,16 +6100,21 @@ namespace Mono.CSharp {
                {
                        if (specified_dims) { 
                                Argument a = (Argument) arguments [idx];
-                               
+
                                if (!a.Resolve (ec, loc))
                                        return false;
-                               
-                               if (!(a.Expr is Constant)) {
-                                       Error (150, "A constant value is expected");
+
+                               Constant c = a.Expr as Constant;
+                               if (c != null) {
+                                       c = c.ToType (TypeManager.int32_type, a.Expr.Location);
+                               }
+
+                               if (c == null) {
+                                       Report.Error (150, a.Expr.Location, "A constant value is expected");
                                        return false;
                                }
-                               
-                               int value = (int) ((Constant) a.Expr).GetValue ();
+
+                               int value = (int) c.GetValue ();
                                
                                if (value != probe.Count) {
                                        Error_IncorrectArrayInitializer ();
@@ -6581,7 +6190,7 @@ namespace Mono.CSharp {
                        int i = 0;
                        for (ArrayList probe = initializers; probe != null;) {
                                if (probe.Count > 0 && probe [0] is ArrayList) {
-                                       Expression e = new IntConstant (probe.Count);
+                                       Expression e = new IntConstant (probe.Count, Location.Null);
                                        arguments.Add (new Argument (e, Argument.AType.Expression));
 
                                        bounds [i++] =  probe.Count;
@@ -6589,7 +6198,7 @@ namespace Mono.CSharp {
                                        probe = (ArrayList) probe [0];
                                        
                                } else {
-                                       Expression e = new IntConstant (probe.Count);
+                                       Expression e = new IntConstant (probe.Count, Location.Null);
                                        arguments.Add (new Argument (e, Argument.AType.Expression));
 
                                        bounds [i++] = probe.Count;
@@ -6669,7 +6278,7 @@ namespace Mono.CSharp {
                        if (array_type_expr == null)
                                return false;
 
-                       type = array_type_expr.Type;
+                       type = array_type_expr.ResolveType (ec);
 
                        if (!type.IsArray) {
                                Error (622, "Can only use array initializer expressions to assign to array types. Try using a new expression instead.");
@@ -7158,8 +6767,7 @@ namespace Mono.CSharp {
 
                public bool VerifyFixed ()
                {
-                       // Treat 'this' as a value parameter for the purpose of fixed variable determination.
-                       return true;
+                       return !TypeManager.IsValueType (Type);
                }
 
                public bool ResolveBase (EmitContext ec)
@@ -7401,7 +7009,7 @@ namespace Mono.CSharp {
                        if (texpr == null)
                                return null;
 
-                       typearg = texpr.Type;
+                       typearg = texpr.ResolveType (ec);
 
                        if (typearg == TypeManager.void_type) {
                                Error (673, "System.Void cannot be used from C#. Use typeof (void) to get the void type object");
@@ -7412,7 +7020,6 @@ namespace Mono.CSharp {
                                UnsafeError (loc);
                                return null;
                        }
-                       CheckObsoleteAttribute (typearg);
 
                        type = TypeManager.type_type;
                        // Even though what is returned is a type object, it's treated as a value by the compiler.
@@ -7475,11 +7082,11 @@ namespace Mono.CSharp {
                                return null;
                        }
 
-                       type_queried = texpr.Type;
+                       type_queried = texpr.ResolveType (ec);
 
                        int size_of = GetTypeSize (type_queried);
                        if (size_of > 0) {
-                               return new IntConstant (size_of);
+                               return new IntConstant (size_of, loc);
                        }
 
                        if (!ec.InUnsafe) {
@@ -7488,8 +7095,6 @@ namespace Mono.CSharp {
                                return null;
                        }
 
-                       CheckObsoleteAttribute (type_queried);
-
                        if (!TypeManager.VerifyUnManaged (type_queried, loc)){
                                return null;
                        }
@@ -7527,7 +7132,7 @@ namespace Mono.CSharp {
                public override FullNamedExpression ResolveAsTypeStep (EmitContext ec, bool silent)
                {
                        if (alias == "global")
-                               return new MemberAccess (Namespace.Root, identifier, loc).ResolveAsTypeStep (ec, silent);
+                               return new MemberAccess (RootNamespace.Global, identifier, loc).ResolveAsTypeStep (ec, silent);
 
                        int errors = Report.Errors;
                        FullNamedExpression fne = ec.DeclSpace.NamespaceEntry.LookupAlias (alias);
@@ -7548,7 +7153,7 @@ namespace Mono.CSharp {
                {
                        FullNamedExpression fne;
                        if (alias == "global") {
-                               fne = Namespace.Root;
+                               fne = RootNamespace.Global;
                        } else {
                                int errors = Report.Errors;
                                fne = ec.DeclSpace.NamespaceEntry.LookupAlias (alias);
@@ -7597,15 +7202,16 @@ namespace Mono.CSharp {
        ///   Implements the member access expression
        /// </summary>
        public class MemberAccess : Expression {
-               public readonly string Identifier;  // TODO: LocatedToken
+               public readonly string Identifier;
                Expression expr;
                TypeArguments args;
                
+               // TODO: Location can be removed
                public MemberAccess (Expression expr, string id, Location l)
                {
                        this.expr = expr;
                        Identifier = id;
-                       loc = l;
+                       loc = expr.Location;
                }
 
                public MemberAccess (Expression expr, string id, TypeArguments args,
@@ -7750,10 +7356,8 @@ namespace Mono.CSharp {
                {
                        FullNamedExpression new_expr = expr.ResolveAsTypeStep (ec, silent);
 
-                       if (new_expr == null) {
-                               Report.Error (234, "No such name or typespace {0}", expr);
+                       if (new_expr == null)
                                return null;
-                       }
 
                        string lookup_id = MemberName.MakeName (Identifier, args);
 
@@ -7772,7 +7376,7 @@ namespace Mono.CSharp {
                        if (tnew_expr == null)
                                return null;
 
-                       Type expr_type = tnew_expr.Type;
+                       Type expr_type = tnew_expr.ResolveType (ec);
 
                        if (expr_type.IsPointer){
                                Error (23, "The `.' operator can not be applied to pointer operands (" +
@@ -8054,11 +7658,10 @@ namespace Mono.CSharp {
                                                Report.Error (1708, loc, "Fixed size buffers can only be accessed through locals or fields");
                                                return null;
                                        }
-// TODO: not sure whether it is correct
-//                                     if (!ec.InFixedInitializer) {
-//                                             Error (1666, "You cannot use fixed sized buffers contained in unfixed expressions. Try using the fixed statement");
-//                                             return null;
-//                                     }
+                                       if (!ec.InFixedInitializer && ec.ContainerType.IsValueType) {
+                                               Error (1666, "You cannot use fixed size buffers contained in unfixed expressions. Try using the fixed statement");
+                                               return null;
+                                       }
                                        return MakePointerAccess (ec, ff.ElementType);
                                }
                        }
@@ -8111,7 +7714,7 @@ namespace Mono.CSharp {
                        Type t = ea.Expr.Type;
                        if (t.GetArrayRank () != ea.Arguments.Count){
                                Report.Error (22, ea.Location, "Wrong number of indexes `{0}' inside [], expected `{1}'",
-                                         ea.Arguments.Count, t.GetArrayRank ());
+                                         ea.Arguments.Count.ToString (), t.GetArrayRank ().ToString ());
                                return null;
                        }
 
@@ -8512,6 +8115,21 @@ namespace Mono.CSharp {
                {
                        Indexers ix = empty;
 
+                       if (lookup_type.IsGenericParameter) {
+                               GenericConstraints gc = TypeManager.GetTypeParameterConstraints (lookup_type);
+                               if (gc == null)
+                                       return empty;
+
+                               if (gc.HasClassConstraint)
+                                       Append (ref ix, caller_type, GetIndexersForTypeOrInterface (caller_type, gc.ClassConstraint));
+
+                               Type[] ifaces = gc.InterfaceConstraints;
+                               foreach (Type itype in ifaces)
+                                       Append (ref ix, caller_type, GetIndexersForTypeOrInterface (caller_type, itype));
+
+                               return ix;
+                       }
+
                        Type copy = lookup_type;
                        while (copy != TypeManager.object_type && copy != null){
                                Append (ref ix, caller_type, GetIndexersForTypeOrInterface (caller_type, copy));
@@ -9024,7 +8642,10 @@ namespace Mono.CSharp {
                        if (lexpr == null)
                                return null;
 
-                       Type ltype = lexpr.Type;
+                       bool old = ec.TestObsoleteMethodUsage;
+                       ec.TestObsoleteMethodUsage = true;
+                       Type ltype = lexpr.ResolveType (ec);
+                       ec.TestObsoleteMethodUsage = old;
 
                        if ((ltype == TypeManager.void_type) && (dim != "*")) {
                                Report.Error (1547, Location,
@@ -9080,7 +8701,7 @@ namespace Mono.CSharp {
                }
        }
 
-       public class FixedBufferPtr: Expression {
+       public class FixedBufferPtr : Expression {
                Expression array;
 
                public FixedBufferPtr (Expression array, Type array_type, Location l)
@@ -9206,7 +8827,7 @@ namespace Mono.CSharp {
                        if (texpr == null)
                                return null;
 
-                       otype = texpr.Type;
+                       otype = texpr.ResolveType (ec);
 
                        if (!TypeManager.VerifyUnManaged (otype, loc))
                                return null;