**** Merged from MCS ****
[mono.git] / mcs / gmcs / ecore.cs
index 26b6c6f376eb0fe56329e910566f344af4de69d2..8dd46c5aee3555a64dd43742f0b77feea978e4b5 100755 (executable)
@@ -92,6 +92,25 @@ namespace Mono.CSharp {
                void AddressOf (EmitContext ec, AddressOp mode);
        }
 
+       /// <summary>
+       ///   We are either a namespace or a type.
+       ///   If we're a type, `IsType' is true and we may use `Type' to get
+       ///   a TypeExpr representing that type.
+       /// </summary>
+       public interface IAlias {
+               bool IsType {
+                       get;
+               }
+
+               string Name {
+                       get;
+               }
+
+               TypeExpr Type {
+                       get;
+               }
+       }
+
        /// <summary>
        ///   This interface is implemented by variables
        /// </summary>
@@ -389,7 +408,7 @@ namespace Mono.CSharp {
                                        return null;
                                }
 
-                               if (e.type == null)
+                               if ((e.type == null) && !(e is ConstructedType))
                                        throw new Exception ("Expression " + e +
                                                             " did not set its type after Resolve");
                        }
@@ -466,7 +485,11 @@ namespace Mono.CSharp {
                        else if (t == TypeManager.bool_type)
                                return new BoolConstant ((bool) v);
                        else if (TypeManager.IsEnumType (t)){
-                               Constant e = Constantify (v, TypeManager.TypeToCoreType (v.GetType ()));
+                               Type real_type = TypeManager.TypeToCoreType (v.GetType ());
+                               if (real_type == t)
+                                       real_type = real_type.UnderlyingSystemType;
+
+                               Constant e = Constantify (v, real_type);
 
                                return new EnumConstant (e, t);
                        } else
@@ -536,8 +559,8 @@ namespace Mono.CSharp {
                                                       string name, MemberTypes mt,
                                                       BindingFlags bf, Location loc)
                {
-                       MemberInfo [] mi = TypeManager.MemberLookup (container_type, qualifier_type,
-                                                                    queried_type, mt, bf, name);
+                       MemberInfo [] mi = TypeManager.MemberLookup (
+                               container_type, qualifier_type,queried_type, mt, bf, name);
 
                        if (mi == null)
                                return null;
@@ -594,7 +617,8 @@ namespace Mono.CSharp {
                ///   find it.
                /// </summary>
                public static Expression MemberLookupFinal (EmitContext ec, Type qualifier_type,
-                                                           Type queried_type, string name, Location loc)
+                                                           Type queried_type, string name,
+                                                           Location loc)
                {
                        return MemberLookupFinal (ec, qualifier_type, queried_type, name,
                                                  AllMemberTypes, AllBindingFlags, loc);
@@ -619,7 +643,8 @@ namespace Mono.CSharp {
                        if (errors < Report.Errors)
                                return null;
 
-                       MemberLookupFailed (ec, qualifier_type, queried_type, name, null, loc);
+                       MemberLookupFailed (ec, qualifier_type, queried_type, name,
+                                           null, loc);
                        return null;
                }
 
@@ -627,11 +652,11 @@ namespace Mono.CSharp {
                                                       Type queried_type, string name,
                                                       string class_name, Location loc)
                {
-                       object lookup = TypeManager.MemberLookup (queried_type, null, queried_type,
-                                                                 AllMemberTypes, AllBindingFlags |
-                                                                 BindingFlags.NonPublic, name);
+                       MemberInfo[] mi = TypeManager.MemberLookup (queried_type, null, queried_type,
+                                                                   AllMemberTypes, AllBindingFlags |
+                                                                   BindingFlags.NonPublic, name);
 
-                       if (lookup == null) {
+                       if (mi == null) {
                                if (class_name != null)
                                        Report.Error (103, loc, "The name `" + name + "' could not be " +
                                                      "found in `" + class_name + "'");
@@ -642,6 +667,21 @@ namespace Mono.CSharp {
                                return;
                        }
 
+                       if (TypeManager.MemberLookup (queried_type, null, queried_type,
+                                                     AllMemberTypes, AllBindingFlags |
+                                                     BindingFlags.NonPublic, name) == null) {
+                               if ((mi.Length == 1) && (mi [0] is Type)) {
+                                       Type t = (Type) mi [0];
+
+                                       Report.Error (305, loc,
+                                                     "Using the generic type `{0}' " +
+                                                     "requires {1} type arguments",
+                                                     TypeManager.GetFullName (t),
+                                                     TypeManager.GetNumberOfTypeArguments (t));
+                                       return;
+                               }
+                       }
+
                        if ((qualifier_type != null) && (qualifier_type != ec.ContainerType) &&
                            ec.ContainerType.IsSubclassOf (qualifier_type)) {
                                // Although a derived class can access protected members of
@@ -650,11 +690,11 @@ namespace Mono.CSharp {
                                // ec.ContainerType and the lookup succeeds with the latter one,
                                // then we are in this situation.
 
-                               lookup = TypeManager.MemberLookup (
+                               mi = TypeManager.MemberLookup (
                                        ec.ContainerType, ec.ContainerType, ec.ContainerType,
                                        AllMemberTypes, AllBindingFlags, name);
 
-                               if (lookup != null) {
+                               if (mi != null) {
                                        Report.Error (
                                                1540, loc, "Cannot access protected member `" +
                                                TypeManager.CSharpName (qualifier_type) + "." +
@@ -717,7 +757,8 @@ namespace Mono.CSharp {
 
                        ArrayList arguments = new ArrayList ();
                        arguments.Add (new Argument (e, Argument.AType.Expression));
-                       method = Invocation.OverloadResolve (ec, (MethodGroupExpr) operator_group, arguments, loc);
+                       method = Invocation.OverloadResolve (
+                               ec, (MethodGroupExpr) operator_group, arguments, false, loc);
 
                        if (method == null)
                                return null;
@@ -1515,6 +1556,10 @@ namespace Mono.CSharp {
                {
                        return Child.ConvertToInt ();
                }
+               
+               public override bool IsZeroInteger {
+                       get { return Child.IsZeroInteger; }
+               }
        }
 
        /// <summary>
@@ -1528,11 +1573,13 @@ namespace Mono.CSharp {
                public BoxedCast (Expression expr)
                        : base (expr, TypeManager.object_type) 
                {
+                       eclass = ExprClass.Value;
                }
 
                public BoxedCast (Expression expr, Type target_type)
                        : base (expr, target_type)
                {
+                       eclass = ExprClass.Value;
                }
                
                public override Expression DoResolve (EmitContext ec)
@@ -1571,9 +1618,13 @@ namespace Mono.CSharp {
                        ILGenerator ig = ec.ig;
                        
                        base.Emit (ec);
-                       ig.Emit (OpCodes.Unbox, t);
+                       if (t.IsGenericParameter)
+                               ig.Emit (OpCodes.Unbox_Any, t);
+                       else {
+                               ig.Emit (OpCodes.Unbox, t);
 
-                       LoadFromPtr (ig, t);
+                               LoadFromPtr (ig, t);
+                       }
                }
        }
        
@@ -1856,9 +1907,14 @@ namespace Mono.CSharp {
                {
                        base.Emit (ec);
 
-                       ec.ig.Emit (OpCodes.Castclass, type);
-               }                       
-               
+                       if (child.Type.IsGenericParameter)
+                               ec.ig.Emit (OpCodes.Box, child.Type);
+
+                       if (type.IsGenericParameter)
+                               ec.ig.Emit (OpCodes.Unbox_Any, type);
+                       else
+                               ec.ig.Emit (OpCodes.Castclass, type);
+               }
        }
        
        /// <summary>
@@ -1963,8 +2019,8 @@ namespace Mono.CSharp {
                {
                        DeclSpace ds = ec.DeclSpace;
                        NamespaceEntry ns = ds.NamespaceEntry;
-                       Type t;
-                       string alias_value;
+                       TypeExpr t;
+                       IAlias alias_value;
 
                        //
                        // Since we are cheating: we only do the Alias lookup for
@@ -1975,6 +2031,10 @@ namespace Mono.CSharp {
                        else
                                alias_value = null;
 
+                       TypeParameterExpr generic_type = ds.LookupGeneric (Name, loc);
+                       if (generic_type != null)
+                               return generic_type.ResolveAsTypeTerminal (ec);
+
                        if (ec.ResolvingTypeTree){
                                int errors = Report.Errors;
                                Type dt = ds.FindType (loc, Name);
@@ -1986,8 +2046,10 @@ namespace Mono.CSharp {
                                        return new TypeExpression (dt, loc);
 
                                if (alias_value != null){
-                                       if ((t = RootContext.LookupType (ds, alias_value, true, loc)) != null)
-                                               return new TypeExpression (t, loc);
+                                       if (alias_value.IsType)
+                                               return alias_value.Type;
+                                       if ((t = RootContext.LookupType (ds, alias_value.Name, true, loc)) != null)
+                                               return t;
                                }
                        }
 
@@ -1995,24 +2057,22 @@ namespace Mono.CSharp {
                        // First, the using aliases
                        //
                        if (alias_value != null){
-                               if ((t = RootContext.LookupType (ds, alias_value, true, loc)) != null)
-                                       return new TypeExpression (t, loc);
+                               if (alias_value.IsType)
+                                       return alias_value.Type;
+                               if ((t = RootContext.LookupType (ds, alias_value.Name, true, loc)) != null)
+                                       return t;
                                
                                // we have alias value, but it isn't Type, so try if it's namespace
-                               return new SimpleName (alias_value, loc);
+                               return new SimpleName (alias_value.Name, loc);
                        }
 
-                       TypeParameterExpr generic_type = ds.LookupGeneric (Name, loc);
-                       if (generic_type != null)
-                               return generic_type.ResolveAsTypeTerminal (ec);
-
                        //
                        // Stage 2: Lookup up if we are an alias to a type
                        // or a namespace.
                        //
 
                        if ((t = RootContext.LookupType (ds, Name, true, loc)) != null)
-                               return new TypeExpression (t, loc);
+                               return t;
                                
                        // No match, maybe our parent can compose us
                        // into something meaningful.
@@ -2045,6 +2105,11 @@ namespace Mono.CSharp {
                        //
                        Block current_block = ec.CurrentBlock;
                        if (current_block != null){
+                               if (is_base && current_block.IsVariableNameUsedInChildBlock(Name)) {
+                                       Report.Error (135, Location, "'" + Name + "' has a different meaning in a child block");
+                                       return null;
+                               }
+
                                LocalInfo vi = current_block.GetLocalInfo (Name);
                                if (vi != null){
                                        Expression var;
@@ -2103,9 +2168,12 @@ namespace Mono.CSharp {
                                //
                                NamespaceEntry ns = ec.DeclSpace.NamespaceEntry;
                                if (is_base && ns != null){
-                                       string alias_value = ns.LookupAlias (Name);
+                                       IAlias alias_value = ns.LookupAlias (Name);
                                        if (alias_value != null){
-                                               Name = alias_value;
+                                               if (alias_value.IsType)
+                                                       return alias_value.Type;
+
+                                               Name = alias_value.Name;
                                                Type t;
 
                                                if ((t = TypeManager.LookupType (Name)) != null)
@@ -2184,7 +2252,7 @@ namespace Mono.CSharp {
        /// <summary>
        ///   Fully resolved expression that evaluates to a type
        /// </summary>
-       public abstract class TypeExpr : Expression {
+       public abstract class TypeExpr : Expression, IAlias {
                override public Expression ResolveAsTypeStep (EmitContext ec)
                {
                        TypeExpr t = DoResolveAsTypeStep (ec);
@@ -2235,6 +2303,7 @@ namespace Mono.CSharp {
                {
                        if (Type == TypeManager.enum_type ||
                            (Type == TypeManager.value_type && RootContext.StdLib) ||
+                           Type == TypeManager.multicast_delegate_type ||
                            Type == TypeManager.delegate_type ||
                            Type == TypeManager.array_type)
                                return false;
@@ -2278,13 +2347,28 @@ namespace Mono.CSharp {
                        return Type == tobj.Type;
                }
 
+               public override int GetHashCode ()
+               {
+                       return Type.GetHashCode ();
+               }
+               
                public override string ToString ()
                {
                        return Name;
                }
+
+               bool IAlias.IsType {
+                       get { return true; }
+               }
+
+               TypeExpr IAlias.Type {
+                       get {
+                               return this;
+                       }
+               }
        }
 
-       public class TypeExpression : TypeExpr {
+       public class TypeExpression : TypeExpr, IAlias {
                public TypeExpression (Type t, Location l)
                {
                        Type = t;
@@ -2302,6 +2386,12 @@ namespace Mono.CSharp {
                                return Type.ToString ();
                        }
                }
+
+               string IAlias.Name {
+                       get {
+                               return Type.FullName != null ? Type.FullName : Type.Name;
+                       }
+               }
        }
 
        /// <summary>
@@ -2319,8 +2409,17 @@ namespace Mono.CSharp {
 
                public override TypeExpr DoResolveAsTypeStep (EmitContext ec)
                {
-                       if (type == null)
-                               type = RootContext.LookupType (ec.DeclSpace, name, false, Location.Null);
+                       if (type == null) {
+                               TypeExpr texpr = RootContext.LookupType (
+                                       ec.DeclSpace, name, false, Location.Null);
+                               if (texpr == null)
+                                       return null;
+
+                               type = texpr.ResolveType (ec);
+                               if (type == null)
+                                       return null;
+                       }
+
                        return this;
                }
 
@@ -2331,6 +2430,99 @@ namespace Mono.CSharp {
                }
        }
 
+       public class TypeAliasExpression : TypeExpr, IAlias {
+               TypeExpr texpr;
+               TypeArguments args;
+               string name;
+
+               public TypeAliasExpression (TypeExpr texpr, TypeArguments args, Location l)
+               {
+                       this.texpr = texpr;
+                       this.args = args;
+                       loc = texpr.Location;
+
+                       eclass = ExprClass.Type;
+                       if (args != null)
+                               name = texpr.Name + "<" + args.ToString () + ">";
+                       else
+                               name = texpr.Name;
+               }
+
+               public override string Name {
+                       get { return name; }
+               }
+
+               public override TypeExpr DoResolveAsTypeStep (EmitContext ec)
+               {
+                       Type type = texpr.ResolveType (ec);
+                       if (type == null)
+                               return null;
+
+                       int num_args = TypeManager.GetNumberOfTypeArguments (type);
+
+                       if (args != null) {
+                               if (num_args == 0) {
+                                       Report.Error (308, loc,
+                                                     "The non-generic type `{0}' cannot " +
+                                                     "be used with type arguments.",
+                                                     TypeManager.CSharpName (type));
+                                       return null;
+                               }
+
+                               ConstructedType ctype = new ConstructedType (type, args, loc);
+                               return ctype.ResolveAsTypeTerminal (ec);
+                       } else if (num_args > 0) {
+                               Report.Error (305, loc,
+                                             "Using the generic type `{0}' " +
+                                             "requires {1} type arguments",
+                                             TypeManager.GetFullName (type), num_args);
+                               return null;
+                       }
+
+                       return new TypeExpression (type, loc);
+               }
+
+               public override Type ResolveType (EmitContext ec)
+               {
+                       TypeExpr t = ResolveAsTypeTerminal (ec);
+                       if (t == null)
+                               return null;
+
+                       type = t.ResolveType (ec);
+                       return type;
+               }
+
+               public override bool CheckAccessLevel (DeclSpace ds)
+               {
+                       return texpr.CheckAccessLevel (ds);
+               }
+
+               public override bool AsAccessible (DeclSpace ds, int flags)
+               {
+                       return texpr.AsAccessible (ds, flags);
+               }
+
+               public override bool IsClass {
+                       get { return texpr.IsClass; }
+               }
+
+               public override bool IsValueType {
+                       get { return texpr.IsValueType; }
+               }
+
+               public override bool IsInterface {
+                       get { return texpr.IsInterface; }
+               }
+
+               public override bool IsSealed {
+                       get { return texpr.IsSealed; }
+               }
+
+               public override bool IsAttribute {
+                       get { return texpr.IsAttribute; }
+               }
+       }
+
        /// <summary>
        ///   MethodGroup Expression.
        ///  
@@ -2340,6 +2532,7 @@ namespace Mono.CSharp {
                public MethodBase [] Methods;
                Expression instance_expression = null;
                bool is_explicit_impl = false;
+               bool has_type_arguments = false;
                
                public MethodGroupExpr (MemberInfo [] mi, Location l)
                {
@@ -2404,10 +2597,20 @@ namespace Mono.CSharp {
                        }
                }
 
+               public bool HasTypeArguments {
+                       get {
+                               return has_type_arguments;
+                       }
+
+                       set {
+                               has_type_arguments = value;
+                       }
+               }
+
                public string Name {
                        get {
-                               //return Methods [0].Name;
-                                return Methods [Methods.Length - 1].Name;
+                                return TypeManager.CSharpSignature (
+                                       Methods [Methods.Length - 1]);
                        }
                }
 
@@ -2505,7 +2708,7 @@ namespace Mono.CSharp {
                {
                        FieldInfo = fi;
                        eclass = ExprClass.Variable;
-                       type = fi.FieldType;
+                       type = TypeManager.TypeToCoreType (fi.FieldType);
                        loc = l;
                }
 
@@ -2629,7 +2832,13 @@ namespace Mono.CSharp {
                                if (IsStatic && !ec.IsStatic)
                                        Report_AssignToReadonly (false);
 
-                               if (ec.ContainerType == FieldInfo.DeclaringType)
+                               Type ctype;
+                               if (ec.TypeContainer.CurrentType != null)
+                                       ctype = ec.TypeContainer.CurrentType.ResolveType (ec);
+                               else
+                                       ctype = ec.ContainerType;
+
+                               if (TypeManager.IsEqual (ctype, FieldInfo.DeclaringType))
                                        return this;
                        }
 
@@ -2677,9 +2886,6 @@ namespace Mono.CSharp {
                                if (!(instance_expr is IMemoryLocation)){
                                        tempo = new LocalTemporary (ec, instance_expr.Type);
                                        
-                                       if (ec.RemapToProxy)
-                                               ec.EmitThis ();
-                       
                                        InstanceExpression.Emit (ec);
                                        tempo.Store (ec);
                                        ml = tempo;
@@ -2688,10 +2894,7 @@ namespace Mono.CSharp {
                                
                                ml.AddressOf (ec, AddressOp.Load);
                        } else {
-                               if (ec.RemapToProxy)
-                                       ec.EmitThis ();
-                               else
-                                       instance_expr.Emit (ec);
+                               instance_expr.Emit (ec);
                        }
                        if (is_volatile)
                                ig.Emit (OpCodes.Volatile);
@@ -2719,10 +2922,7 @@ namespace Mono.CSharp {
 
                                        ml.AddressOf (ec, AddressOp.Store);
                                } else {
-                                       if (ec.RemapToProxy)
-                                               ec.EmitThis ();
-                                       else
-                                               instance.Emit (ec);
+                                       instance.Emit (ec);
                                }
                        }
 
@@ -2804,8 +3004,20 @@ namespace Mono.CSharp {
                                        IMemoryLocation ml = (IMemoryLocation) instance_expr;
 
                                        ml.AddressOf (ec, AddressOp.LoadStore);
-                               } else
+                               } else {
                                        instance_expr.Emit (ec);
+
+                                       if (instance_expr.Type.IsValueType) {
+                                               LocalBuilder local = ig.DeclareLocal (instance_expr.Type);
+                                               ig.Emit(OpCodes.Stloc, local);
+                                               ig.Emit(OpCodes.Ldloca, local);
+                                               ig.Emit(OpCodes.Ldfld, FieldInfo);
+                                               LocalBuilder local2 = ig.DeclareLocal(type);
+                                               ig.Emit(OpCodes.Stloc, local2);
+                                               ig.Emit(OpCodes.Ldloca, local2);
+                                               return;
+                                       }
+                               }
                                ig.Emit (OpCodes.Ldflda, FieldInfo);
                        }
                }
@@ -2906,75 +3118,104 @@ namespace Mono.CSharp {
                        return true;
                }
 
-               MethodInfo GetAccessor (Type invocation_type, string accessor_name)
+               MethodInfo FindAccessor (Type invocation_type, bool is_set)
                {
                        BindingFlags flags = BindingFlags.Public | BindingFlags.NonPublic |
-                               BindingFlags.Static | BindingFlags.Instance;
-                       MemberInfo[] group;
+                               BindingFlags.Static | BindingFlags.Instance |
+                               BindingFlags.DeclaredOnly;
 
-                       group = TypeManager.MemberLookup (
-                               invocation_type, invocation_type, PropertyInfo.DeclaringType,
-                               MemberTypes.Method, flags, accessor_name + "_" + PropertyInfo.Name);
+                       Type current = PropertyInfo.DeclaringType;
+                       for (; current != null; current = current.BaseType) {
+                               MemberInfo[] group = TypeManager.MemberLookup (
+                                       invocation_type, invocation_type, current,
+                                       MemberTypes.Property, flags, PropertyInfo.Name);
 
-                       //
-                       // The first method is the closest to us
-                       //
-                       if (group == null)
+                               if (group == null)
+                                       continue;
+
+                               if (group.Length != 1)
+                                       // Oooops, can this ever happen ?
+                                       return null;
+
+                               PropertyInfo pi = (PropertyInfo) group [0];
+
+                               MethodInfo get = pi.GetGetMethod (true);
+                               MethodInfo set = pi.GetSetMethod (true);
+
+                               if (is_set) {
+                                       if (set != null)
+                                               return set;
+                               } else {
+                                       if (get != null)
+                                               return get;
+                               }
+
+                               MethodInfo accessor = get != null ? get : set;
+                               if (accessor == null)
+                                       continue;
+                               if ((accessor.Attributes & MethodAttributes.NewSlot) != 0)
+                                       break;
+                       }
+
+                       return null;
+               }
+
+               MethodInfo GetAccessor (Type invocation_type, bool is_set)
+               {
+                       MethodInfo mi = FindAccessor (invocation_type, is_set);
+                       if (mi == null)
                                return null;
 
-                       foreach (MethodInfo mi in group) {
-                               MethodAttributes ma = mi.Attributes & MethodAttributes.MemberAccessMask;
+                       MethodAttributes ma = mi.Attributes & MethodAttributes.MemberAccessMask;
 
-                               //
-                               // If only accessible to the current class or children
-                               //
-                               if (ma == MethodAttributes.Private) {
-                                       Type declaring_type = mi.DeclaringType;
+                       //
+                       // If only accessible to the current class or children
+                       //
+                       if (ma == MethodAttributes.Private) {
+                               Type declaring_type = mi.DeclaringType;
                                        
-                                       if (invocation_type != declaring_type){
-                                               if (TypeManager.IsSubclassOrNestedChildOf (invocation_type, mi.DeclaringType))
-                                                       return mi;
-                                               else
-                                                       continue;
-                                       } else
+                               if (invocation_type != declaring_type){
+                                       if (TypeManager.IsSubclassOrNestedChildOf (invocation_type, mi.DeclaringType))
                                                return mi;
-                               }
-                               //
-                               // FamAndAssem requires that we not only derivate, but we are on the
-                               // same assembly.  
-                               //
-                               if (ma == MethodAttributes.FamANDAssem){
-                                       if (mi.DeclaringType.Assembly != invocation_type.Assembly)
-                                               continue;
                                        else
-                                               return mi;
-                               }
+                                               return null;
+                               } else
+                                       return mi;
+                       }
+                       //
+                       // FamAndAssem requires that we not only derivate, but we are on the
+                       // same assembly.  
+                       //
+                       if (ma == MethodAttributes.FamANDAssem){
+                               if (mi.DeclaringType.Assembly != invocation_type.Assembly)
+                                       return null;
+                               else
+                                       return mi;
+                       }
 
-                               // Assembly and FamORAssem succeed if we're in the same assembly.
-                               if ((ma == MethodAttributes.Assembly) || (ma == MethodAttributes.FamORAssem)){
-                                       if (mi.DeclaringType.Assembly == invocation_type.Assembly)
-                                               return mi;
-                               }
+                       // Assembly and FamORAssem succeed if we're in the same assembly.
+                       if ((ma == MethodAttributes.Assembly) || (ma == MethodAttributes.FamORAssem)){
+                               if (mi.DeclaringType.Assembly == invocation_type.Assembly)
+                                       return mi;
+                       }
 
-                               // We already know that we aren't in the same assembly.
-                               if (ma == MethodAttributes.Assembly)
-                                       continue;
+                       // We already know that we aren't in the same assembly.
+                       if (ma == MethodAttributes.Assembly)
+                               return null;
 
-                               // Family and FamANDAssem require that we derive.
-                               if ((ma == MethodAttributes.Family) || (ma == MethodAttributes.FamANDAssem) || (ma == MethodAttributes.FamORAssem)){
-                                       if (!TypeManager.IsSubclassOrNestedChildOf (invocation_type, mi.DeclaringType))
-                                               continue;
-                                       else {
+                       // Family and FamANDAssem require that we derive.
+                       if ((ma == MethodAttributes.Family) || (ma == MethodAttributes.FamANDAssem) || (ma == MethodAttributes.FamORAssem)){
+                               if (!TypeManager.IsSubclassOrNestedChildOf (invocation_type, mi.DeclaringType))
+                                       return null;
+                               else {
+                                       if (!TypeManager.IsNestedChildOf (invocation_type, mi.DeclaringType))
                                                must_do_cs1540_check = true;
 
-                                               return mi;
-                                       }
+                                       return mi;
                                }
-
-                               return mi;
                        }
 
-                       return null;
+                       return mi;
                }
 
                //
@@ -2983,11 +3224,11 @@ namespace Mono.CSharp {
                //
                void ResolveAccessors (EmitContext ec)
                {
-                       getter = GetAccessor (ec.ContainerType, "get");
+                       getter = GetAccessor (ec.ContainerType, false);
                        if ((getter != null) && getter.IsStatic)
                                is_static = true;
 
-                       setter = GetAccessor (ec.ContainerType, "set");
+                       setter = GetAccessor (ec.ContainerType, true);
                        if ((setter != null) && setter.IsStatic)
                                is_static = true;
 
@@ -3030,6 +3271,16 @@ namespace Mono.CSharp {
                
                override public Expression DoResolve (EmitContext ec)
                {
+                       if (getter != null){
+                               if (TypeManager.GetArgumentTypes (getter).Length != 0){
+                                       Report.Error (
+                                               117, loc, "`{0}' does not contain a " +
+                                               "definition for `{1}'.", getter.DeclaringType,
+                                               Name);
+                                       return null;
+                               }
+                       }
+
                        if (getter == null){
                                //
                                // The following condition happens if the PropertyExpr was
@@ -3081,6 +3332,14 @@ namespace Mono.CSharp {
                                return null;
                        }
 
+                       if (TypeManager.GetArgumentTypes (setter).Length != 1){
+                               Report.Error (
+                                       117, loc, "`{0}' does not contain a " +
+                                       "definition for `{1}'.", getter.DeclaringType,
+                                       Name);
+                               return null;
+                       }
+
                        if (!InstanceResolve (ec))
                                return null;