2005-01-31 Zoltan Varga <vargaz@freemail.hu>
[mono.git] / mcs / gmcs / decl.cs
old mode 100755 (executable)
new mode 100644 (file)
index cf34162..fccf04b
@@ -7,6 +7,7 @@
 // Licensed under the terms of the GNU GPL
 //
 // (C) 2001 Ximian, Inc (http://www.ximian.com)
+// (C) 2004 Novell, Inc
 //
 // TODO: Move the method verification stuff from the class.cs and interface.cs here
 //
@@ -17,11 +18,12 @@ using System.Collections;
 using System.Globalization;
 using System.Reflection.Emit;
 using System.Reflection;
+using System.Xml;
 
 namespace Mono.CSharp {
 
-       public class MemberName : ICloneable {
-               public readonly string Name;
+       public class MemberName {
+               public string Name;
                public readonly TypeArguments TypeArguments;
 
                public readonly MemberName Left;
@@ -58,6 +60,17 @@ namespace Mono.CSharp {
                                return Name;
                }
 
+               public bool IsGeneric {
+                       get {
+                               if (TypeArguments != null)
+                                       return true;
+                               else if (Left != null)
+                                       return Left.IsGeneric;
+                               else
+                                       return false;
+                       }
+               }
+
                public string GetName (bool is_generic)
                {
                        string name = is_generic ? Basename : Name;
@@ -76,32 +89,68 @@ namespace Mono.CSharp {
                        }
                }
 
-               public string GetFullName ()
+               public string GetMethodName ()
                {
-                       string full_name;
-                       if (TypeArguments != null)
-                               full_name = Name + "<" + TypeArguments + ">";
-                       else
-                               full_name = Name;
                        if (Left != null)
-                               return Left.GetFullName () + "." + full_name;
+                               return Left.GetTypeName () + "." + Name;
                        else
-                               return full_name;
+                               return Name;
+               }
+
+               public static string MakeName (string name, TypeArguments args)
+               {
+                       if (args == null)
+                               return name;
+                       else
+                               return name + "`" + args.Count;
+               }
+
+               public static string MakeName (string name, int count)
+               {
+                       return name + "`" + count;
                }
 
-               public string GetTypeName (bool full)
+               public string GetTypeName ()
                {
-                       string suffix = "";
-                       if (full && (TypeArguments != null))
-                               suffix = "!" + TypeArguments.Count;
                        if (Left != null)
-                               return Left.GetTypeName (full) + "." + Name + suffix;
+                               return Left.GetTypeName () + "." +
+                                       MakeName (Name, TypeArguments);
                        else
-                               return Name + suffix;
+                               return MakeName (Name, TypeArguments);
+               }
+
+               protected bool IsUnbound {
+                       get {
+                               if ((Left != null) && Left.IsUnbound)
+                                       return true;
+                               else if (TypeArguments == null)
+                                       return false;
+                               else
+                                       return TypeArguments.IsUnbound;
+                       }
+               }
+
+               protected bool CheckUnbound (Location loc)
+               {
+                       if ((Left != null) && !Left.CheckUnbound (loc))
+                               return false;
+                       if ((TypeArguments != null) && !TypeArguments.IsUnbound) {
+                               Report.Error (1031, loc, "Type expected");
+                               return false;
+                       }
+
+                       return true;
                }
 
                public Expression GetTypeExpression (Location loc)
                {
+                       if (IsUnbound) {
+                               if (!CheckUnbound (loc))
+                                       return null;
+
+                               return new UnboundTypeExpression (GetTypeName ());
+                       }
+
                        if (Left != null) {
                                Expression lexpr = Left.GetTypeExpression (loc);
 
@@ -114,26 +163,21 @@ namespace Mono.CSharp {
                        }
                }
 
-               public string Basename {
-                       get {
-                               if (TypeArguments != null)
-                                       return Name + "!" + TypeArguments.Count;
-                               else
-                                       return Name;
-                       }
-               }
-
                public MemberName Clone ()
                {
                        if (Left != null)
-                               return new MemberName (Left.Clone (), this);
+                               return new MemberName (Left.Clone (), Name, TypeArguments);
                        else
                                return new MemberName (Name, TypeArguments);
                }
 
-               object ICloneable.Clone ()
-               {
-                       return Clone ();
+               public string Basename {
+                       get {
+                               if (TypeArguments != null)
+                                       return MakeName (Name, TypeArguments);
+                               else
+                                       return Name;
+                       }
                }
 
                public override string ToString ()
@@ -159,20 +203,38 @@ namespace Mono.CSharp {
                /// <summary>
                ///   Public name
                /// </summary>
-               public string Name;
+               public string Name {
+                       get {
+                               return MemberName.GetName (!(this is GenericMethod) && !(this is Method));
+                       }
+               }
 
-               public readonly MemberName MemberName;
+                // Is not readonly because of IndexerName attribute
+               public MemberName MemberName;
 
                /// <summary>
                ///   Modifier flags that the user specified in the source code
                /// </summary>
                public int ModFlags;
 
+               public /*readonly*/ TypeContainer Parent;
+
                /// <summary>
                ///   Location where this declaration happens
                /// </summary>
                public readonly Location Location;
 
+               /// <summary>
+               ///   XML documentation comment
+               /// </summary>
+               public string DocComment;
+
+               /// <summary>
+               ///   Represents header string for documentation comment 
+               ///   for each member types.
+               /// </summary>
+               public abstract string DocCommentHeader { get; }
+
                [Flags]
                public enum Flags {
                        Obsolete_Undetected = 1,                // Obsolete attribute has not been detected yet
@@ -184,19 +246,20 @@ namespace Mono.CSharp {
                        HasClsCompliantAttribute = 1 << 6,                      // Type has CLSCompliantAttribute
                        ClsCompliantAttributeTrue = 1 << 7,                     // Type has CLSCompliant (true)
                        Excluded_Undetected = 1 << 8,           // Conditional attribute has not been detected yet
-                       Excluded = 1 << 9                                       // Method is conditional
-
+                       Excluded = 1 << 9,                                      // Method is conditional
+                       TestMethodDuplication = 1 << 10         // Test for duplication must be performed
                }
   
                /// <summary>
                ///   MemberCore flags at first detected then cached
                /// </summary>
-               protected Flags caching_flags;
+               internal Flags caching_flags;
 
-               public MemberCore (MemberName name, Attributes attrs, Location loc)
+               public MemberCore (TypeContainer parent, MemberName name, Attributes attrs,
+                                  Location loc)
                        : base (attrs)
                {
-                       Name = name.GetName (!(this is GenericMethod) && !(this is Method));
+                       Parent = parent;
                        MemberName = name;
                        Location = loc;
                        caching_flags = Flags.Obsolete_Undetected | Flags.ClsCompliance_Undetected | Flags.HasCompliantAttribute_Undetected | Flags.Excluded_Undetected;
@@ -217,7 +280,7 @@ namespace Mono.CSharp {
                        AttributeTester.Report_ObsoleteMessage (obsolete_attr, type.FullName, Location);
                }
 
-               public abstract bool Define (TypeContainer parent);
+               public abstract bool Define ();
 
                // 
                // Returns full member name for error message
@@ -227,17 +290,33 @@ namespace Mono.CSharp {
                        return Name;
                }
 
+               /// <summary>
+               /// Use this method when MethodBuilder is null
+               /// </summary>
+               public virtual string GetSignatureForError (TypeContainer tc)
+               {
+                       return Name;
+               }
+
                /// <summary>
                /// Base Emit method. This is also entry point for CLS-Compliant verification.
                /// </summary>
-               public virtual void Emit (TypeContainer container)
+               public virtual void Emit ()
                {
-                       VerifyObsoleteAttribute ();
+                       // Hack with Parent == null is for EnumMember
+                       if (Parent == null || (GetObsoleteAttribute (Parent) == null && Parent.GetObsoleteAttribute (Parent) == null))
+                               VerifyObsoleteAttribute ();
 
                        if (!RootContext.VerifyClsCompliance)
                                return;
 
-                       VerifyClsCompliance (container);
+                       VerifyClsCompliance (Parent);
+               }
+
+               public bool InUnsafe {
+                       get {
+                               return ((ModFlags & Modifiers.UNSAFE) != 0) || Parent.UnsafeContext;
+                       }
                }
 
                // 
@@ -273,15 +352,12 @@ namespace Mono.CSharp {
                        if (OptAttributes == null)
                                return null;
 
-                       // TODO: remove this allocation
-                       EmitContext ec = new EmitContext (ds.Parent, ds, ds.Location,
-                               null, null, ds.ModFlags, false);
-
-                       Attribute obsolete_attr = OptAttributes.Search (TypeManager.obsolete_attribute_type, ec);
+                       Attribute obsolete_attr = OptAttributes.Search (
+                               TypeManager.obsolete_attribute_type, ds.EmitContext);
                        if (obsolete_attr == null)
                                return null;
 
-                       ObsoleteAttribute obsolete = obsolete_attr.GetObsoleteAttribute (ds);
+                       ObsoleteAttribute obsolete = obsolete_attr.GetObsoleteAttribute (ds.EmitContext);
                        if (obsolete == null)
                                return null;
 
@@ -310,7 +386,7 @@ namespace Mono.CSharp {
                /// <summary>
                /// Returns true when MemberCore is exposed from assembly.
                /// </summary>
-               protected bool IsExposedFromAssembly (DeclSpace ds)
+               public bool IsExposedFromAssembly (DeclSpace ds)
                {
                        if ((ModFlags & (Modifiers.PUBLIC | Modifiers.PROTECTED)) == 0)
                                return false;
@@ -330,12 +406,11 @@ namespace Mono.CSharp {
                bool GetClsCompliantAttributeValue (DeclSpace ds)
                {
                        if (OptAttributes != null) {
-                               EmitContext ec = new EmitContext (ds.Parent, ds, ds.Location,
-                                                                 null, null, ds.ModFlags, false);
-                               Attribute cls_attribute = OptAttributes.GetClsCompliantAttribute (ec);
+                               Attribute cls_attribute = OptAttributes.Search (
+                                       TypeManager.cls_compliant_attribute_type, ds.EmitContext);
                                if (cls_attribute != null) {
                                        caching_flags |= Flags.HasClsCompliantAttribute;
-                                       return cls_attribute.GetClsCompliantAttributeValue (ds);
+                                       return cls_attribute.GetClsCompliantAttributeValue (ds.EmitContext);
                                }
                        }
                        return ds.GetClsCompliantAttributeValue ();
@@ -351,70 +426,11 @@ namespace Mono.CSharp {
                }
 
                /// <summary>
-               /// This method is used to testing error 3005 (Method or parameter name collision).
-               /// </summary>
-               protected abstract bool IsIdentifierClsCompliant (DeclSpace ds);
-
-               /// <summary>
-               /// Common helper method for identifier and parameters CLS-Compliant testing.
-               /// When return false error 3005 is reported. True means no violation.
-               /// And error 3006 tests are peformed here because of speed.
+               /// It helps to handle error 102 & 111 detection
                /// </summary>
-               protected bool IsIdentifierAndParamClsCompliant (DeclSpace ds, string name, MemberInfo methodBuilder, Type[] paramTypes)
+               public virtual bool MarkForDuplicationCheck ()
                {
-                       MemberList ml = ds.FindMembers (MemberTypes.Event | MemberTypes.Field | MemberTypes.Method | MemberTypes.Property, 
-                               BindingFlags.Public | BindingFlags.Static | BindingFlags.Instance, System.Type.FilterNameIgnoreCase, name);
-               
-                       if (ml.Count < 2)
-                               return true;
-
-                       bool error3006 = false;
-                       for (int i = 0; i < ml.Count; ++i) {
-                               MemberInfo mi = ml [i];
-                               if (name == mi.Name) {
-                                       MethodBase method = mi as MethodBase;
-                                       if (method == null || method == methodBuilder || paramTypes == null || paramTypes.Length == 0)
-                                               continue;
-
-                                       if (AttributeTester.AreOverloadedMethodParamsClsCompliant (paramTypes, TypeManager.GetArgumentTypes (method))) {
-                                               error3006 = false;
-                                               continue;
-                                       }
-
-                                       error3006 = true;
-                               }
-
-                               // We need to test if member is not marked as CLSCompliant (false) and if type is not only internal
-                               // because BindingFlags.Public returns internal types too
-                               DeclSpace temp_ds = TypeManager.LookupDeclSpace (mi.DeclaringType);
-
-                               // Type is external, we can get attribute directly
-                               if (temp_ds == null) {
-                                       object[] cls_attribute = mi.GetCustomAttributes (TypeManager.cls_compliant_attribute_type, false);
-                                       if (cls_attribute.Length == 1 && (!((CLSCompliantAttribute)cls_attribute[0]).IsCompliant))
-                                               continue;
-                               } else {
-                                       string tmp_name = String.Concat (temp_ds.Name, '.', mi.Name);
-
-                                       MemberCore mc = temp_ds.GetDefinition (tmp_name) as MemberCore;
-                                       if (!mc.IsClsCompliaceRequired (ds))
-                                               continue;
-                               }
-
-                               for (int ii = 0; ii < ml.Count; ++ii) {
-                                       mi = ml [ii];
-                                       if (name == mi.Name)
-                                               continue;
-                                       Report.SymbolRelatedToPreviousError (mi);
-                               }
-
-                               if (error3006)
-                                       Report.Error_T (3006, Location, GetSignatureForError ());
-
-                               return error3006;
-
-                       }
-                       return true;
+                       return false;
                }
 
                /// <summary>
@@ -426,32 +442,59 @@ namespace Mono.CSharp {
                protected virtual bool VerifyClsCompliance (DeclSpace ds)
                {
                        if (!IsClsCompliaceRequired (ds)) {
-                               if (HasClsCompliantAttribute && !IsExposedFromAssembly (ds)) {
-                                       Report.Warning_T (3019, Location, GetSignatureForError ());
+                               if (HasClsCompliantAttribute && RootContext.WarningLevel >= 2) {
+                                       if (!IsExposedFromAssembly (ds))
+                                               Report.Warning (3019, Location, "CLS compliance checking will not be performed on '{0}' because it is private or internal", GetSignatureForError ());
+                                       if (!CodeGen.Assembly.IsClsCompliant)
+                                               Report.Warning (3021, Location, "'{0}' does not need a CLSCompliant attribute because the assembly does not have a CLSCompliant attribute", GetSignatureForError ());
                                }
                                return false;
                        }
 
                        if (!CodeGen.Assembly.IsClsCompliant) {
                                if (HasClsCompliantAttribute) {
-                                       Report.Error_T (3014, Location, GetSignatureForError ());
+                                       Report.Error (3014, Location, "'{0}' cannot be marked as CLS-compliant because the assembly does not have a CLSCompliant attribute", GetSignatureForError ());
                                }
+                               return false;
                        }
 
                        int index = Name.LastIndexOf ('.');
                        if (Name [index > 0 ? index + 1 : 0] == '_') {
-                               Report.Error_T (3008, Location, GetSignatureForError () );
-                       }
-
-                       if (!IsIdentifierClsCompliant (ds)) {
-                               Report.Error_T (3005, Location, GetSignatureForError ());
+                               Report.Error (3008, Location, "Identifier '{0}' is not CLS-compliant", GetSignatureForError () );
                        }
-
                        return true;
                }
 
                protected abstract void VerifyObsoleteAttribute ();
 
+               //
+               // Raised (and passed an XmlElement that contains the comment)
+               // when GenerateDocComment is writing documentation expectedly.
+               //
+               internal virtual void OnGenerateDocComment (DeclSpace ds, XmlElement intermediateNode)
+               {
+               }
+
+               //
+               // Returns a string that represents the signature for this 
+               // member which should be used in XML documentation.
+               //
+               public virtual string GetDocCommentName (DeclSpace ds)
+               {
+                       if (ds == null || this is DeclSpace)
+                               return DocCommentHeader + Name;
+                       else
+                               return String.Concat (DocCommentHeader, ds.Name, ".", Name);
+               }
+
+               //
+               // Generates xml doc comments (if any), and if required,
+               // handle warning report.
+               //
+               internal virtual void GenerateDocComment (DeclSpace ds)
+               {
+                       DocUtil.GenerateDocComment (this, ds);
+               }
        }
 
        /// <summary>
@@ -474,7 +517,7 @@ namespace Mono.CSharp {
                ///   currently defining.  We need to lookup members on this
                ///   instead of the TypeBuilder.
                /// </summary>
-               public TypeExpr CurrentType;
+               public Type CurrentType;
 
                //
                // This is the namespace in which this typecontainer
@@ -482,18 +525,22 @@ namespace Mono.CSharp {
                //
                public NamespaceEntry NamespaceEntry;
 
-               public Hashtable Cache = new Hashtable ();
+               private Hashtable Cache = new Hashtable ();
                
                public string Basename;
                
-               /// <summary>
-               ///   defined_names is used for toplevel objects
-               /// </summary>
                protected Hashtable defined_names;
 
                readonly bool is_generic;
                readonly int count_type_params;
 
+               // The emit context for toplevel objects.
+               protected EmitContext ec;
+               
+               public EmitContext EmitContext {
+                       get { return ec; }
+               }
+
                //
                // Whether we are Generic
                //
@@ -501,20 +548,18 @@ namespace Mono.CSharp {
                        get {
                                if (is_generic)
                                        return true;
-                               else if (parent != null)
-                                       return parent.IsGeneric;
+                               else if (Parent != null)
+                                       return Parent.IsGeneric;
                                else
                                        return false;
                        }
                }
 
-               TypeContainer parent;
-
                static string[] attribute_targets = new string [] { "type" };
 
                public DeclSpace (NamespaceEntry ns, TypeContainer parent, MemberName name,
                                  Attributes attrs, Location l)
-                       : base (name, attrs, l)
+                       : base (parent, name, attrs, l)
                {
                        NamespaceEntry = ns;
                        Basename = name.Name;
@@ -525,104 +570,62 @@ namespace Mono.CSharp {
                        }
                        if (parent != null)
                                count_type_params += parent.count_type_params;
-                       this.parent = parent;
-               }
-
-               public void RecordDecl ()
-               {
-                       if ((NamespaceEntry != null) && (parent == RootContext.Tree.Types))
-                               NamespaceEntry.DefineName (MemberName.Basename, this);
                }
 
                /// <summary>
-               ///   The result value from adding an declaration into
-               ///   a struct or a class
+               /// Adds the member to defined_names table. It tests for duplications and enclosing name conflicts
                /// </summary>
-               public enum AdditionResult {
-                       /// <summary>
-                       /// The declaration has been successfully
-                       /// added to the declation space.
-                       /// </summary>
-                       Success,
-
-                       /// <summary>
-                       ///   The symbol has already been defined.
-                       /// </summary>
-                       NameExists,
-
-                       /// <summary>
-                       ///   Returned if the declation being added to the
-                       ///   name space clashes with its container name.
-                       ///
-                       ///   The only exceptions for this are constructors
-                       ///   and static constructors
-                       /// </summary>
-                       EnclosingClash,
-
-                       /// <summary>
-                       ///   Returned if a constructor was created (because syntactically
-                       ///   it looked like a constructor) but was not (because the name
-                       ///   of the method is not the same as the container class
-                       /// </summary>
-                       NotAConstructor,
-
-                       /// <summary>
-                       ///   This is only used by static constructors to emit the
-                       ///   error 111, but this error for other things really
-                       ///   happens at another level for other functions.
-                       /// </summary>
-                       MethodExists,
-
-                       /// <summary>
-                       ///   Some other error.
-                       /// </summary>
-                       Error
-               }
+               protected bool AddToContainer (MemberCore symbol, string fullname, string basename)
+               {
+                       if (basename == Basename && !(this is Interface)) {
+                               if (symbol is TypeParameter)
+                                       Report.Error (694, "Type parameter `{0}' has same name as " +
+                                                     "containing type or method", basename);
+                               else {
+                                       Report.SymbolRelatedToPreviousError (this);
+                                       Report.Error (542, "'{0}': member names cannot be the same as their " +
+                                                     "enclosing type", symbol.Location, symbol.GetSignatureForError ());
+                               }
+                               return false;
+                       }
 
-               /// <summary>
-               ///   Returns a status code based purely on the name
-               ///   of the member being added
-               /// </summary>
-               protected AdditionResult IsValid (string basename, string name)
-               {
-                       if (basename == Basename)
-                               return AdditionResult.EnclosingClash;
+                       MemberCore mc = (MemberCore)defined_names [fullname];
+
+                       if (mc == null) {
+                               defined_names.Add (fullname, symbol);
+                               return true;
+                       }
 
-                       if (defined_names.Contains (name))
-                               return AdditionResult.NameExists;
+                       if (symbol.MarkForDuplicationCheck () && mc.MarkForDuplicationCheck ())
+                               return true;
 
-                       return AdditionResult.Success;
+                       if (symbol is TypeParameter)
+                               Report.Error (692, symbol.Location, "Duplicate type parameter `{0}'", basename);
+                       else {
+                               Report.SymbolRelatedToPreviousError (mc);
+                               Report.Error (102, symbol.Location,
+                                             "The type '{0}' already contains a definition for '{1}'",
+                                             GetSignatureForError (), basename);
+                       }
+                       return false;
                }
 
-               public static int length;
-               public static int small;
-               
-               /// <summary>
-               ///   Introduce @name into this declaration space and
-               ///   associates it with the object @o.  Note that for
-               ///   methods this will just point to the first method. o
-               /// </summary>
-               public void DefineName (string name, object o)
+               public void RecordDecl ()
                {
-                       defined_names.Add (name, o);
-
-#if DEBUGME
-                       int p = name.LastIndexOf ('.');
-                       int l = name.Length;
-                       length += l;
-                       small += l -p;
-#endif
+                       if ((NamespaceEntry != null) && (Parent == RootContext.Tree.Types))
+                               NamespaceEntry.DefineName (MemberName.Basename, this);
                }
 
                /// <summary>
-               ///   Returns the object associated with a given name in the declaration
-               ///   space.  This is the inverse operation of `DefineName'
+               ///   Returns the MemberCore associated with a given name in the declaration
+               ///   space. It doesn't return method based symbols !!
                /// </summary>
-               public object GetDefinition (string name)
+               /// 
+               public MemberCore GetDefinition (string name)
                {
-                       return defined_names [name];
+                       return (MemberCore)defined_names [name];
                }
-               
+
                bool in_transit = false;
                
                /// <summary>
@@ -638,23 +641,6 @@ namespace Mono.CSharp {
                                in_transit = value;
                        }
                }
-
-               public TypeContainer Parent {
-                       get {
-                               return parent;
-                       }
-               }
-
-               /// <summary>
-               ///   Looks up the alias for the name
-               /// </summary>
-               public IAlias LookupAlias (string name)
-               {
-                       if (NamespaceEntry != null)
-                               return NamespaceEntry.LookupAlias (name);
-                       else
-                               return null;
-               }
                
                // 
                // root_types contains all the types.  All TopLevel types
@@ -663,8 +649,8 @@ namespace Mono.CSharp {
                //
                public bool IsTopLevel {
                        get {
-                               if (parent != null){
-                                       if (parent.parent == null)
+                               if (Parent != null){
+                                       if (Parent.Parent == null)
                                                return true;
                                }
                                return false;
@@ -710,8 +696,8 @@ namespace Mono.CSharp {
                        get {
                                if ((ModFlags & Modifiers.UNSAFE) != 0)
                                        return true;
-                               if (parent != null)
-                                       return parent.UnsafeContext;
+                               if (Parent != null)
+                                       return Parent.UnsafeContext;
                                return false;
                        }
                }
@@ -724,52 +710,28 @@ namespace Mono.CSharp {
                }
 
                EmitContext type_resolve_ec;
-               EmitContext GetTypeResolveEmitContext (TypeContainer parent, Location loc)
-               {
-                       type_resolve_ec = new EmitContext (parent, this, loc, null, null, ModFlags, false);
-                       type_resolve_ec.ResolvingTypeTree = true;
-
-                       return type_resolve_ec;
-               }
 
-               // <summary>
-               //    Looks up the type, as parsed into the expression `e' 
-               // </summary>
-               public Type ResolveType (Expression e, bool silent, Location loc)
+               public FullNamedExpression ResolveNestedType (FullNamedExpression t, Location loc)
                {
-                       TypeExpr d = ResolveTypeExpr (e, silent, loc);
-                       if (d == null)
-                               return null;
-
-                       return ResolveType (d, loc);
-               }
-
-               public Type ResolveType (TypeExpr d, Location loc)
-               {
-                       if (!d.CheckAccessLevel (this)) {
-                               Report.Error_T (122, loc, d.Name);
-                               return null;
-                       }
-
-                       Type t = d.ResolveType (type_resolve_ec);
-                       if (t == null)
-                               return null;
-
-                       TypeContainer tc = TypeManager.LookupTypeContainer (t);
+                       TypeContainer tc = TypeManager.LookupTypeContainer (t.Type);
                        if ((tc != null) && tc.IsGeneric) {
                                if (!IsGeneric) {
-                                       int tnum = TypeManager.GetNumberOfTypeArguments (t);
+                                       int tnum = TypeManager.GetNumberOfTypeArguments (t.Type);
                                        Report.Error (305, loc,
                                                      "Using the generic type `{0}' " +
                                                      "requires {1} type arguments",
-                                                     TypeManager.GetFullName (t), tnum);
+                                                     TypeManager.GetFullName (t.Type), tnum);
                                        return null;
                                }
 
-                               ConstructedType ctype = new ConstructedType (
-                                       t, TypeParameters, loc);
+                               TypeParameter[] args;
+                               if (this is GenericMethod)
+                                       args = Parent.TypeParameters;
+                               else
+                                       args = TypeParameters;
 
-                               t = ctype.ResolveType (type_resolve_ec);
+                               TypeExpr ctype = new ConstructedType (t.Type, args, loc);
+                               return ctype.ResolveAsTypeTerminal (ec);
                        }
 
                        return t;
@@ -777,62 +739,34 @@ namespace Mono.CSharp {
 
                // <summary>
                //    Resolves the expression `e' for a type, and will recursively define
-               //    types. 
+               //    types.  This should only be used for resolving base types.
                // </summary>
-               public TypeExpr ResolveTypeExpr (Expression e, bool silent, Location loc)
+               public TypeExpr ResolveBaseTypeExpr (Expression e, bool silent, Location loc)
                {
-                       if (type_resolve_ec == null)
-                               type_resolve_ec = GetTypeResolveEmitContext (parent, loc);
+                       if (type_resolve_ec == null) {
+                               // FIXME: I think this should really be one of:
+                               //
+                               // a. type_resolve_ec = Parent.EmitContext;
+                               // b. type_resolve_ec = new EmitContext (Parent, Parent, loc, null, null, ModFlags, false);
+                               //
+                               // However, if Parent == RootContext.Tree.Types, its NamespaceEntry will be null.
+                               //
+                               type_resolve_ec = new EmitContext (Parent, this, loc, null, null, ModFlags, false);
+                               type_resolve_ec.ResolvingTypeTree = true;
+                       }
                        type_resolve_ec.loc = loc;
                        if (this is GenericMethod)
                                type_resolve_ec.ContainerType = Parent.TypeBuilder;
                        else
                                type_resolve_ec.ContainerType = TypeBuilder;
 
-                       int errors = Report.Errors;
-
-                       TypeExpr d = e.ResolveAsTypeTerminal (type_resolve_ec);
-
-                       if ((d != null) && (d.eclass == ExprClass.Type))
-                               return d;
-
-                       if (silent || (Report.Errors != errors))
-                               return null;
-
-                       if (e is SimpleName){
-                               SimpleName s = new SimpleName (((SimpleName) e).Name, loc);
-                               d = s.ResolveAsTypeTerminal (type_resolve_ec);
-
-                               if ((d == null) || (d.Type == null)) {
-                                       Report.Error (246, loc, "Cannot find type `{0}'", e);
-                                       return null;
-                               }
-
-                               int num_args = TypeManager.GetNumberOfTypeArguments (d.Type);
-
-                               if (num_args == 0) {
-                                       Report.Error (308, loc,
-                                                     "The non-generic type `{0}' cannot " +
-                                                     "be used with type arguments.",
-                                                     TypeManager.CSharpName (d.Type));
-                                       return null;
-                               }
-
-                               Report.Error (305, loc,
-                                             "Using the generic type `{0}' " +
-                                             "requires {1} type arguments",
-                                             TypeManager.GetFullName (d.Type), num_args);
-                               return null;
-                       }
-
-                       Report.Error (246, loc, "Cannot find type `{0}'", e);
-                       return null;
+                       return e.ResolveAsTypeTerminal (type_resolve_ec);
                }
                
                public bool CheckAccessLevel (Type check_type) 
                {
                        TypeBuilder tb;
-                       if (this is GenericMethod)
+                       if ((this is GenericMethod) || (this is Iterator))
                                tb = Parent.TypeBuilder;
                        else
                                tb = TypeBuilder;
@@ -843,6 +777,12 @@ namespace Mono.CSharp {
                        if (check_type == tb)
                                return true;
 
+                       if (TypeBuilder == null)
+                               // FIXME: TypeBuilder will be null when invoked by Class.GetNormalBases().
+                               //        However, this is invoked again later -- so safe to return true.
+                               //        May also be null when resolving top-level attributes.
+                               return true;
+
                        if (check_type.IsGenericParameter)
                                return true; // FIXME
                        
@@ -862,10 +802,11 @@ namespace Mono.CSharp {
 
                        case TypeAttributes.NotPublic:
 
-                               // In same cases is null.
                                if (TypeBuilder == null)
+                                       // FIXME: TypeBuilder will be null when invoked by Class.GetNormalBases().
+                                       //        However, this is invoked again later -- so safe to return true.
+                                       //        May also be null when resolving top-level attributes.
                                        return true;
-
                                //
                                // This test should probably use the declaringtype.
                                //
@@ -875,25 +816,7 @@ namespace Mono.CSharp {
                                return true;
 
                        case TypeAttributes.NestedPrivate:
-                               string check_type_name = check_type.FullName;
-                               string type_name = CurrentType != null ?
-                                       CurrentType.Name : tb.FullName;
-
-                               int cio = check_type_name.LastIndexOf ('+');
-                               string container = check_type_name.Substring (0, cio);
-
-                               //
-                               // Check if the check_type is a nested class of the current type
-                               //
-                               if (check_type_name.StartsWith (type_name + "+")){
-                                       return true;
-                               }
-                               
-                               if (type_name.StartsWith (container)){
-                                       return true;
-                               }
-
-                               return false;
+                               return NestedAccessible (tb, check_type);
 
                        case TypeAttributes.NestedFamily:
                                //
@@ -918,24 +841,31 @@ namespace Mono.CSharp {
 
                }
 
-               protected bool FamilyAccessible (TypeBuilder tb, Type check_type)
+               protected bool NestedAccessible (Type tb, Type check_type)
                {
-                       Type declaring = check_type.DeclaringType;
-                       if (tb.IsSubclassOf (declaring))
-                               return true;
-
                        string check_type_name = check_type.FullName;
                        
+                       // At this point, we already know check_type is a nested class.
                        int cio = check_type_name.LastIndexOf ('+');
-                       string container = check_type_name.Substring (0, cio);
                        
-                       //
-                       // Check if the check_type is a nested class of the current type
-                       //
-                       if (check_type_name.StartsWith (container + "+"))
+                       // Ensure that the string 'container' has a '+' in it to avoid false matches
+                       string container = check_type_name.Substring (0, cio + 1);
+
+                       // Ensure that type_name ends with a '+' so that it can match 'container', if necessary
+                       string type_name = tb.FullName + "+";
+
+                       // If the current class is nested inside the container of check_type,
+                       // we can access check_type even if it is private or protected.
+                       return type_name.StartsWith (container);
+               }
+
+               protected bool FamilyAccessible (Type tb, Type check_type)
+               {
+                       Type declaring = check_type.DeclaringType;
+                       if (tb == declaring || TypeManager.IsFamilyAccessible (tb, declaring))
                                return true;
 
-                       return false;
+                       return NestedAccessible (tb, check_type);
                }
 
                // Access level of a type.
@@ -1051,16 +981,17 @@ namespace Mono.CSharp {
                        return tc.DefineType ();
                }
                
-               Type LookupInterfaceOrClass (string ns, string name, out bool error)
+               FullNamedExpression LookupInterfaceOrClass (string ns, string name, out bool error)
                {
                        DeclSpace parent;
+                       FullNamedExpression result;
                        Type t;
                        object r;
                        
                        error = false;
 
                        if (dh.Lookup (ns, name, out r))
-                               return (Type) r;
+                               return (FullNamedExpression) r;
                        else {
                                if (ns != ""){
                                        if (Namespace.IsNamespace (ns)){
@@ -1073,8 +1004,23 @@ namespace Mono.CSharp {
                        }
                        
                        if (t != null) {
-                               dh.Insert (ns, name, t);
-                               return t;
+                               result = new TypeExpression (t, Location.Null);
+                               dh.Insert (ns, name, result);
+                               return result;
+                       }
+
+                       if (ns != "" && Namespace.IsNamespace (ns)) {
+                               result = Namespace.LookupNamespace (ns, false).Lookup (this, name, Location.Null);
+                               if (result != null) {
+                                       dh.Insert (ns, name, result);
+                                       return result;
+                               }
+                       }
+
+                       if (ns == "" && Namespace.IsNamespace (name)) {
+                               result = Namespace.LookupNamespace (name, false);
+                               dh.Insert (ns, name, result);
+                               return result;
                        }
 
                        //
@@ -1085,7 +1031,10 @@ namespace Mono.CSharp {
                                ns = MakeFQN (ns, name.Substring (0, p));
                                name = name.Substring (p+1);
                        }
-                       
+
+                       if (ns.IndexOf ('+') != -1)
+                               ns = ns.Replace ('+', '.');
+
                        parent = RootContext.Tree.LookupByNamespace (ns, name);
                        if (parent == null) {
                                dh.Insert (ns, name, null);
@@ -1098,8 +1047,9 @@ namespace Mono.CSharp {
                                return null;
                        }
                        
-                       dh.Insert (ns, name, t);
-                       return t;
+                       result = new TypeExpression (t, Location.Null);
+                       dh.Insert (ns, name, result);
+                       return result;
                }
 
                public static void Error_AmbiguousTypeReference (Location loc, string name, string t1, string t2)
@@ -1112,7 +1062,7 @@ namespace Mono.CSharp {
                public Type FindNestedType (Location loc, string name,
                                            out DeclSpace containing_ds)
                {
-                       Type t;
+                       FullNamedExpression t;
                        bool error;
 
                        containing_ds = this;
@@ -1127,8 +1077,8 @@ namespace Mono.CSharp {
                                        if (error)
                                                return null;
 
-                                       if ((t != null) && containing_ds.CheckAccessLevel (t))
-                                               return t;
+                                       if ((t != null) && containing_ds.CheckAccessLevel (t.Type))
+                                               return t.Type;
 
                                        current_type = current_type.BaseType;
                                }
@@ -1150,15 +1100,16 @@ namespace Mono.CSharp {
                ///   during the tree resolution process and potentially define
                ///   recursively the type
                /// </remarks>
-               public Type FindType (Location loc, string name)
+               public FullNamedExpression FindType (Location loc, string name)
                {
-                       Type t;
+                       FullNamedExpression t;
                        bool error;
 
                        //
                        // For the case the type we are looking for is nested within this one
                        // or is in any base class
                        //
+
                        DeclSpace containing_ds = this;
 
                        while (containing_ds != null){
@@ -1172,8 +1123,8 @@ namespace Mono.CSharp {
                                        if (error)
                                                return null;
 
-                                       if ((t != null) && containing_ds.CheckAccessLevel (t))
-                                               return t;
+                                       if ((t != null) && containing_ds.CheckAccessLevel (t.Type))
+                                               return ResolveNestedType (t, loc);
 
                                        current_type = current_type.BaseType;
                                }
@@ -1219,34 +1170,27 @@ namespace Mono.CSharp {
                                if (name.IndexOf ('.') > 0)
                                        continue;
 
-                               IAlias alias_value = ns.LookupAlias (name);
-                               if (alias_value != null) {
-                                       t = LookupInterfaceOrClass ("", alias_value.Name, out error);
-                                       if (error)
-                                               return null;
-
-                                       if (t != null)
-                                               return t;
-                               }
+                               t = ns.LookupAlias (name);
+                               if (t != null)
+                                       return t;
 
                                //
                                // Now check the using clause list
                                //
-                               Type match = null;
+                               FullNamedExpression match = null;
                                foreach (Namespace using_ns in ns.GetUsingTable ()) {
                                        match = LookupInterfaceOrClass (using_ns.Name, name, out error);
                                        if (error)
                                                return null;
 
-                                       if (match != null) {
-                                               if (t != null){
-                                                       if (CheckAccessLevel (match)) {
-                                                               Error_AmbiguousTypeReference (loc, name, t.FullName, match.FullName);
-                                                               return null;
-                                                       }
+                                       if ((match != null) && (match is TypeExpr)) {
+                                               Type matched = ((TypeExpr) match).Type;
+                                               if (!CheckAccessLevel (matched))
                                                        continue;
+                                               if (t != null){
+                                                       Error_AmbiguousTypeReference (loc, name, t.FullName, match.FullName);
+                                                       return null;
                                                }
-                                               
                                                t = match;
                                        }
                                }
@@ -1258,6 +1202,76 @@ namespace Mono.CSharp {
                        return null;
                }
 
+               //
+               // Public function used to locate types, this can only
+               // be used after the ResolveTree function has been invoked.
+               //
+               // Returns: Type or null if they type can not be found.
+               //
+               // Come to think of it, this should be a DeclSpace
+               //
+               public FullNamedExpression LookupType (string name, bool silent, Location loc)
+               {
+                       FullNamedExpression e;
+
+                       if (Cache.Contains (name)) {
+                               e = (FullNamedExpression) Cache [name];
+                       } else {
+                               //
+                               // For the case the type we are looking for is nested within this one
+                               // or is in any base class
+                               //
+                               DeclSpace containing_ds = this;
+                               while (containing_ds != null){
+                                       
+                                       // if the member cache has been created, lets use it.
+                                       // the member cache is MUCH faster.
+                                       if (containing_ds.MemberCache != null) {
+                                               Type t = containing_ds.MemberCache.FindNestedType (name);
+                                               if (t == null) {
+                                                       containing_ds = containing_ds.Parent;
+                                                       continue;
+                                               }
+
+                                               e = new TypeExpression (t, Location.Null);
+                                               e = ResolveNestedType (e, Location.Null);
+                                               Cache [name] = e;
+                                               return e;
+                                       }
+                                       
+                                       // no member cache. Do it the hard way -- reflection
+                                       Type current_type = containing_ds.TypeBuilder;
+                                       
+                                       while (current_type != null &&
+                                              current_type != TypeManager.object_type) {
+                                               //
+                                               // nested class
+                                               //
+                                               Type t = TypeManager.LookupType (current_type.FullName + "." + name);
+                                               if (t != null){
+                                                       e = new TypeExpression (t, Location.Null);
+                                                       e = ResolveNestedType (e, Location.Null);
+                                                       Cache [name] = e;
+                                                       return e;
+                                               }
+                                               
+                                               current_type = current_type.BaseType;
+                                       }
+                                       
+                                       containing_ds = containing_ds.Parent;
+                               }
+                               
+                               e = NamespaceEntry.LookupNamespaceOrType (this, name, loc);
+                               if (!silent || e != null)
+                                       Cache [name] = e;
+                       }
+
+                       if (e == null && !silent)
+                               Report.Error (246, loc, "Cannot find type `"+name+"'");
+                       
+                       return e;
+               }
+
                /// <remarks>
                ///   This function is broken and not what you're looking for.  It should only
                ///   be used while the type is still being created since it doesn't use the cache
@@ -1301,12 +1315,10 @@ namespace Mono.CSharp {
                        caching_flags &= ~Flags.HasCompliantAttribute_Undetected;
 
                        if (OptAttributes != null) {
-                               EmitContext ec = new EmitContext (parent, this, Location,
-                                                                 null, null, ModFlags, false);
-                               Attribute cls_attribute = OptAttributes.GetClsCompliantAttribute (ec);
+                               Attribute cls_attribute = OptAttributes.Search (TypeManager.cls_compliant_attribute_type, ec);
                                if (cls_attribute != null) {
                                        caching_flags |= Flags.HasClsCompliantAttribute;
-                                       if (cls_attribute.GetClsCompliantAttributeValue (this)) {
+                                       if (cls_attribute.GetClsCompliantAttributeValue (ec)) {
                                                caching_flags |= Flags.ClsCompliantAttributeTrue;
                                                return true;
                                        }
@@ -1314,7 +1326,7 @@ namespace Mono.CSharp {
                                }
                        }
 
-                       if (parent == null) {
+                       if (Parent == null) {
                                if (CodeGen.Assembly.IsClsCompliant) {
                                        caching_flags |= Flags.ClsCompliantAttributeTrue;
                                        return true;
@@ -1322,56 +1334,13 @@ namespace Mono.CSharp {
                                return false;
                        }
 
-                       if (parent.GetClsCompliantAttributeValue ()) {
+                       if (Parent.GetClsCompliantAttributeValue ()) {
                                caching_flags |= Flags.ClsCompliantAttributeTrue;
                                return true;
                        }
                        return false;
                }
 
-
-               // Tests container name for CLS-Compliant name (differing only in case)
-               // Possible optimalization: search in same namespace only
-               protected override bool IsIdentifierClsCompliant (DeclSpace ds)
-               {
-                       int l = Name.Length;
-
-                       if (Namespace.LookupNamespace (NamespaceEntry.FullName, false) != null) {
-                               // Seek through all imported types
-                               foreach (string type_name in TypeManager.all_imported_types.Keys) 
-                               {
-                                       if (l != type_name.Length)
-                                               continue;
-
-                                       if (String.Compare (Name, type_name, true, CultureInfo.InvariantCulture) == 0 && 
-                                               AttributeTester.IsClsCompliant (TypeManager.all_imported_types [type_name] as Type)) {
-                                               Report.SymbolRelatedToPreviousError ((Type)TypeManager.all_imported_types [type_name]);
-                                               return false;
-                               }
-                       }
-                       }
-
-                       // Seek through generated types
-                       foreach (string name in RootContext.Tree.Decls.Keys) {
-                               if (l != name.Length)
-                                       continue;
-
-                               if (String.Compare (Name, name, true, CultureInfo.InvariantCulture) == 0) { 
-
-                                       if (Name == name)
-                                               continue;
-                                       
-                                       DeclSpace found_ds = RootContext.Tree.Decls[name] as DeclSpace;
-                                       if (found_ds.IsClsCompliaceRequired (found_ds.Parent)) {
-                                               Report.SymbolRelatedToPreviousError (found_ds.Location, found_ds.GetSignatureForError ());
-                                               return false;
-                               }
-                       }
-                       }
-
-                       return true;
-               }
-
                //
                // Extensions for generics
                //
@@ -1404,7 +1373,7 @@ namespace Mono.CSharp {
                                                693, Location,
                                                "Type parameter `{0}' has same name " +
                                                "as type parameter from outer type `{1}'",
-                                               name, parent.GetInstantiationName ());
+                                               name, Parent.GetInstantiationName ());
 
                                return false;
                        }
@@ -1417,7 +1386,7 @@ namespace Mono.CSharp {
                        if (type_param_list != null)
                                return type_param_list;
 
-                       DeclSpace the_parent = parent;
+                       DeclSpace the_parent = Parent;
                        if (this is GenericMethod)
                                the_parent = null;
 
@@ -1444,17 +1413,16 @@ namespace Mono.CSharp {
                        return type_param_list;
                }
 
-               public AdditionResult SetParameterInfo (ArrayList constraints_list)
+               public void SetParameterInfo (ArrayList constraints_list)
                {
                        if (!is_generic) {
                                if (constraints_list != null) {
                                        Report.Error (
                                                80, Location, "Contraints are not allowed " +
                                                "on non-generic declarations");
-                                       return AdditionResult.Error;
                                }
 
-                               return AdditionResult.Success;
+                               return;
                        }
 
                        string[] names = MemberName.TypeArguments.GetDeclarations ();
@@ -1466,11 +1434,6 @@ namespace Mono.CSharp {
                        for (int i = 0; i < type_params.Length; i++) {
                                string name = names [i];
 
-                               AdditionResult res = IsValid (name, name);
-
-                               if (res != AdditionResult.Success)
-                                       return res;
-
                                Constraints constraints = null;
                                if (constraints_list != null) {
                                        foreach (Constraints constraint in constraints_list) {
@@ -1481,12 +1444,11 @@ namespace Mono.CSharp {
                                        }
                                }
 
-                               type_params [i] = new TypeParameter (name, constraints, Location);
+                               type_params [i] = new TypeParameter (Parent, name, constraints, Location);
 
-                               DefineName (name, type_params [i]);
+                               string full_name = Name + "." + name;
+                               AddToContainer (type_params [i], full_name, name);
                        }
-
-                       return AdditionResult.Success;
                }
 
                public TypeParameter[] TypeParameters {
@@ -1529,8 +1491,8 @@ namespace Mono.CSharp {
                                return new TypeParameterExpr (type_param, loc);
                        }
 
-                       if (parent != null)
-                               return parent.LookupGeneric (name, loc);
+                       if (Parent != null)
+                               return Parent.LookupGeneric (name, loc);
 
                        return null;
                }
@@ -1543,20 +1505,18 @@ namespace Mono.CSharp {
                        get { return Name; }
                }
 
-               TypeExpr IAlias.Type
+               TypeExpr IAlias.ResolveAsType (EmitContext ec)
                {
-                       get {
-                               if (TypeBuilder == null)
-                                       throw new InvalidOperationException ();
-
-                               if (CurrentType != null)
-                                       return CurrentType;
+                       if (TypeBuilder == null)
+                               throw new InvalidOperationException ();
 
+                       if (CurrentType != null)
+                               return new TypeExpression (CurrentType, Location);
+                       else
                                return new TypeExpression (TypeBuilder, Location);
-                       }
                }
 
-               protected override string[] ValidAttributeTargets {
+               public override string[] ValidAttributeTargets {
                        get {
                                return attribute_targets;
                        }
@@ -1733,12 +1693,12 @@ namespace Mono.CSharp {
                }
 
                /// <summary>
-               ///   Returns the IMemberContainer of the parent class or null if this
+               ///   Returns the IMemberContainer of the base class or null if this
                ///   is an interface or TypeManger.object_type.
                ///   This is used when creating the member cache for a class to get all
-               ///   members from the parent class.
+               ///   members from the base class.
                /// </summary>
-               IMemberContainer Parent {
+               MemberCache BaseCache {
                        get;
                }
 
@@ -1789,7 +1749,7 @@ namespace Mono.CSharp {
                public readonly IMemberContainer Container;
                protected Hashtable member_hash;
                protected Hashtable method_hash;
-               
+
                /// <summary>
                ///   Create a new MemberCache for the given IMemberContainer `container'.
                /// </summary>
@@ -1800,20 +1760,10 @@ namespace Mono.CSharp {
                        Timer.IncrementCounter (CounterType.MemberCache);
                        Timer.StartTimer (TimerType.CacheInit);
 
-                       
-
-                       // If we have a parent class (we have a parent class unless we're
+                       // If we have a base class (we have a base class unless we're
                        // TypeManager.object_type), we deep-copy its MemberCache here.
-                       if (Container.IsInterface) {
-                               MemberCache parent;
-                               
-                               if (Container.Parent != null)
-                                       parent = Container.Parent.MemberCache;
-                               else
-                                       parent = TypeHandle.ObjectType.MemberCache;
-                               member_hash = SetupCacheForInterface (parent);
-                       } else if (Container.Parent != null)
-                               member_hash = SetupCache (Container.Parent.MemberCache);
+                       if (Container.BaseCache != null)
+                               member_hash = SetupCache (Container.BaseCache);
                        else
                                member_hash = new Hashtable ();
 
@@ -1831,35 +1781,55 @@ namespace Mono.CSharp {
                        Timer.StopTimer (TimerType.CacheInit);
                }
 
+               public MemberCache (Type[] ifaces)
+               {
+                       //
+                       // The members of this cache all belong to other caches.  
+                       // So, 'Container' will not be used.
+                       //
+                       this.Container = null;
+
+                       member_hash = new Hashtable ();
+                       if (ifaces == null)
+                               return;
+
+                       foreach (Type itype in ifaces)
+                               AddCacheContents (TypeManager.LookupMemberCache (itype));
+               }
+
                /// <summary>
-               ///   Bootstrap this member cache by doing a deep-copy of our parent.
+               ///   Bootstrap this member cache by doing a deep-copy of our base.
                /// </summary>
-               Hashtable SetupCache (MemberCache parent)
+               Hashtable SetupCache (MemberCache base_class)
                {
                        Hashtable hash = new Hashtable ();
 
-                       IDictionaryEnumerator it = parent.member_hash.GetEnumerator ();
+                       if (base_class == null)
+                               return hash;
+
+                       IDictionaryEnumerator it = base_class.member_hash.GetEnumerator ();
                        while (it.MoveNext ()) {
                                hash [it.Key] = ((ArrayList) it.Value).Clone ();
-                        }
+                        }
                                 
                        return hash;
                }
 
-
                /// <summary>
-               ///   Add the contents of `new_hash' to `hash'.
+               ///   Add the contents of `cache' to the member_hash.
                /// </summary>
-               void AddHashtable (Hashtable hash, MemberCache cache)
+               void AddCacheContents (MemberCache cache)
                {
-                       Hashtable new_hash = cache.member_hash;
-                       IDictionaryEnumerator it = new_hash.GetEnumerator ();
+                       IDictionaryEnumerator it = cache.member_hash.GetEnumerator ();
                        while (it.MoveNext ()) {
-                               ArrayList list = (ArrayList) hash [it.Key];
+                               ArrayList list = (ArrayList) member_hash [it.Key];
                                if (list == null)
-                                       hash [it.Key] = list = new ArrayList ();
+                                       member_hash [it.Key] = list = new ArrayList ();
+
+                               ArrayList entries = (ArrayList) it.Value;
+                               for (int i = entries.Count-1; i >= 0; i--) {
+                                       CacheEntry entry = (CacheEntry) entries [i];
 
-                               foreach (CacheEntry entry in (ArrayList) it.Value) {
                                        if (entry.Container != cache.Container)
                                                break;
                                        list.Add (entry);
@@ -1867,30 +1837,6 @@ namespace Mono.CSharp {
                        }
                }
 
-               /// <summary>
-               ///   Bootstrap the member cache for an interface type.
-               ///   Type.GetMembers() won't return any inherited members for interface types,
-               ///   so we need to do this manually.  Interfaces also inherit from System.Object.
-               /// </summary>
-               Hashtable SetupCacheForInterface (MemberCache parent)
-               {
-                       Hashtable hash = SetupCache (parent);
-                       TypeExpr [] ifaces = TypeManager.GetInterfaces (Container.Type);
-
-                       foreach (TypeExpr iface in ifaces) {
-                               Type itype = iface.Type;
-
-                               IMemberContainer iface_container =
-                                       TypeManager.LookupMemberContainer (itype);
-
-                               MemberCache iface_cache = iface_container.MemberCache;
-
-                               AddHashtable (hash, iface_cache);
-                       }
-
-                       return hash;
-               }
-
                /// <summary>
                ///   Add all members from class `container' to the cache.
                /// </summary>
@@ -1898,8 +1844,10 @@ namespace Mono.CSharp {
                {
                        // We need to call AddMembers() with a single member type at a time
                        // to get the member type part of CacheEntry.EntryType right.
+                       if (!container.IsInterface) {
                        AddMembers (MemberTypes.Constructor, container);
                        AddMembers (MemberTypes.Field, container);
+                       }
                        AddMembers (MemberTypes.Method, container);
                        AddMembers (MemberTypes.Property, container);
                        AddMembers (MemberTypes.Event, container);
@@ -1942,7 +1890,7 @@ namespace Mono.CSharp {
                                }
 
                                // When this method is called for the current class, the list will
-                               // already contain all inherited members from our parent classes.
+                               // already contain all inherited members from our base classes.
                                // We cannot add new members in front of the list since this'd be an
                                // expensive operation, that's why the list is sorted in reverse order
                                // (ie. members from the current class are coming last).
@@ -2086,6 +2034,12 @@ namespace Mono.CSharp {
                                this.Member = member;
                                this.EntryType = GetEntryType (mt, bf);
                        }
+
+                       public override string ToString ()
+                       {
+                               return String.Format ("CacheEntry ({0}:{1}:{2})", Container.Name,
+                                                     EntryType, Member);
+                       }
                }
 
                /// <summary>
@@ -2179,9 +2133,9 @@ namespace Mono.CSharp {
 
 
                        // `applicable' is a list of all members with the given member name `name'
-                       // in the current class and all its parent classes.  The list is sorted in
+                       // in the current class and all its base classes.  The list is sorted in
                        // reverse order due to the way how the cache is initialy created (to speed
-                       // things up, we're doing a deep-copy of our parent).
+                       // things up, we're doing a deep-copy of our base).
 
                        for (int i = applicable.Count-1; i >= 0; i--) {
                                CacheEntry entry = (CacheEntry) applicable [i];
@@ -2232,6 +2186,22 @@ namespace Mono.CSharp {
                        return copy;
                }
                
+               // find the nested type @name in @this.
+               public Type FindNestedType (string name)
+               {
+                       ArrayList applicable = (ArrayList) member_hash [name];
+                       if (applicable == null)
+                               return null;
+                       
+                       for (int i = applicable.Count-1; i >= 0; i--) {
+                               CacheEntry entry = (CacheEntry) applicable [i];
+                               if ((entry.EntryType & EntryType.NestedType & EntryType.MaskType) != 0)
+                                       return (Type) entry.Member;
+                       }
+                       
+                       return null;
+               }
+               
                //
                // This finds the method or property for us to override. invocationType is the type where
                // the override is going to be declared, name is the name of the method/property, and
@@ -2313,7 +2283,7 @@ namespace Mono.CSharp {
                                        continue;
 
                                for (int j = cmpAttrs.Length - 1; j >= 0; j --) {
-                                       if (!paramTypes [j].Equals (cmpAttrs [j]))
+                                       if (!TypeManager.IsEqual (paramTypes [j], cmpAttrs [j]))
                                                goto next;
                                }
                                
@@ -2335,7 +2305,7 @@ namespace Mono.CSharp {
                                        // A private method is Ok if we are a nested subtype.
                                        // The spec actually is not very clear about this, see bug 52458.
                                        //
-                                       if (invocationType == entry.Container.Type ||
+                                       if (invocationType.Equals (entry.Container.Type) ||
                                            TypeManager.IsNestedChildOf (invocationType, entry.Container.Type))
                                                return entry.Member;
                                        
@@ -2362,5 +2332,146 @@ namespace Mono.CSharp {
                        
                        return null;
                }
+
+               /// <summary>
+               /// The method is looking for conflict with inherited symbols (errors CS0108, CS0109).
+               /// We handle two cases. The first is for types without parameters (events, field, properties).
+               /// The second are methods, indexers and this is why ignore_complex_types is here.
+               /// The latest param is temporary hack. See DoDefineMembers method for more info.
+               /// </summary>
+               public MemberInfo FindMemberWithSameName (string name, bool ignore_complex_types, MemberInfo ignore_member)
+               {
+                       ArrayList applicable = null;
+                       if (method_hash != null)
+                               applicable = (ArrayList) method_hash [name];
+                       if (applicable != null) {
+                               for (int i = applicable.Count - 1; i >= 0; i--) {
+                                       CacheEntry entry = (CacheEntry) applicable [i];
+                                       if ((entry.EntryType & EntryType.Public) != 0)
+                                               return entry.Member;
+                               }
+                       }
+                       if (member_hash == null)
+                               return null;
+                       applicable = (ArrayList) member_hash [name];
+                       
+                       if (applicable != null) {
+                               for (int i = applicable.Count - 1; i >= 0; i--) {
+                                       CacheEntry entry = (CacheEntry) applicable [i];
+                                       if ((entry.EntryType & EntryType.Public) != 0 & entry.Member != ignore_member) {
+                                               if (ignore_complex_types) {
+                                                       if ((entry.EntryType & EntryType.Method) != 0)
+                                                               continue;
+                                                       // Does exist easier way how to detect indexer ?
+                                                       if ((entry.EntryType & EntryType.Property) != 0) {
+                                                               Type[] arg_types = TypeManager.GetArgumentTypes ((PropertyInfo)entry.Member);
+                                                               if (arg_types.Length > 0)
+                                                                       continue;
+                                                       }
+                                               }
+                                               return entry.Member;
+                                       }
+                               }
+                       }
+                       return null;
+               }
+
+               Hashtable locase_table;
+               /// <summary>
+               /// Builds low-case table for CLS Compliance test
+               /// </summary>
+               public Hashtable GetPublicMembers ()
+               {
+                       if (locase_table != null)
+                               return locase_table;
+                       locase_table = new Hashtable ();
+                       foreach (DictionaryEntry entry in member_hash) {
+                               ArrayList members = (ArrayList)entry.Value;
+                               for (int ii = 0; ii < members.Count; ++ii) {
+                                       CacheEntry member_entry = (CacheEntry) members [ii];
+                                       if ((member_entry.EntryType & EntryType.Public) == 0)
+                                               continue;
+                                       // TODO: Does anyone know easier way how to detect that member is internal ?
+                                       switch (member_entry.EntryType & EntryType.MaskType) {
+                                               case EntryType.Constructor:
+                                                       continue;
+                                               case EntryType.Field:
+                                                       if ((((FieldInfo)member_entry.Member).Attributes & (FieldAttributes.Assembly | FieldAttributes.Public)) == FieldAttributes.Assembly)
+                                                               continue;
+                                                       break;
+                                               case EntryType.Method:
+                                                       if ((((MethodInfo)member_entry.Member).Attributes & (MethodAttributes.Assembly | MethodAttributes.Public)) == MethodAttributes.Assembly)
+                                                               continue;
+                                                       break;
+                                               case EntryType.Property:
+                                                       PropertyInfo pi = (PropertyInfo)member_entry.Member;
+                                                       if (pi.GetSetMethod () == null && pi.GetGetMethod () == null)
+                                                               continue;
+                                                       break;
+                                               case EntryType.Event:
+                                                       EventInfo ei = (EventInfo)member_entry.Member;
+                                                       MethodInfo mi = ei.GetAddMethod ();
+                                                       if ((mi.Attributes & (MethodAttributes.Assembly | MethodAttributes.Public)) == MethodAttributes.Assembly)
+                                                               continue;
+                                                       break;
+                                       }
+                                       string lcase = ((string)entry.Key).ToLower (System.Globalization.CultureInfo.InvariantCulture);
+                                       locase_table [lcase] = member_entry.Member;
+                                       break;
+                               }
+                       }
+                       return locase_table;
+               }
+               public Hashtable Members {
+                       get {
+                               return member_hash;
+                       }
+               }
+               /// <summary>
+               /// Cls compliance check whether methods or constructors parameters differing only in ref or out, or in array rank
+               /// </summary>
+               public void VerifyClsParameterConflict (ArrayList al, MethodCore method, MemberInfo this_builder)
+               {
+                       EntryType tested_type = (method is Constructor ? EntryType.Constructor : EntryType.Method) | EntryType.Public;
+                       for (int i = 0; i < al.Count; ++i) {
+                               MemberCache.CacheEntry entry = (MemberCache.CacheEntry) al [i];
+               
+                               // skip itself
+                               if (entry.Member == this_builder)
+                                       continue;
+               
+                               if ((entry.EntryType & tested_type) != tested_type)
+                                       continue;
+               
+                               MethodBase method_to_compare = (MethodBase)entry.Member;
+                               if (AttributeTester.AreOverloadedMethodParamsClsCompliant (method.ParameterTypes, TypeManager.GetArgumentTypes (method_to_compare)))
+                                       continue;
+
+                               IMethodData md = TypeManager.GetMethod (method_to_compare);
+
+                               // TODO: now we are ignoring CLSCompliance(false) on method from other assembly which is buggy.
+                               // However it is exactly what csc does.
+                               if (md != null && !md.IsClsCompliaceRequired (method.Parent))
+                                       continue;
+               
+                               Report.SymbolRelatedToPreviousError (entry.Member);
+                               Report.Error (3006, method.Location, "Overloaded method '{0}' differing only in ref or out, or in array rank, is not CLS-compliant", method.GetSignatureForError ());
+                       }
+               }
        }
 }