2004-04-14 Sebastien Pouliot <sebastien@ximian.com>
[mono.git] / mcs / class / corlib / System.Runtime.Remoting / RemotingServices.cs
index cd0b373b5ded10bd9b253a052f0735b424c93f8c..09f649274a0636be6c138edf3a968b792c24fd31 100644 (file)
@@ -10,6 +10,7 @@
 //
 
 using System;
+using System.Text;
 using System.Reflection;
 using System.Threading;
 using System.Collections;
@@ -21,6 +22,7 @@ using System.Runtime.Remoting.Activation;
 using System.Runtime.Remoting.Lifetime;
 using System.Runtime.CompilerServices;
 using System.Runtime.Serialization;
+using System.IO;
 
 namespace System.Runtime.Remoting
 {
@@ -34,8 +36,8 @@ namespace System.Runtime.Remoting
                
                static RemotingServices ()
                {
-                       app_id = "/" + Guid.NewGuid().ToString().Replace('-', '_') + "/";
-
+                       RegisterInternalChannels ();
+                       app_id = Guid.NewGuid().ToString().Replace('-', '_') + "/";
                        CreateWellKnownServerIdentity (typeof(RemoteActivator), "RemoteActivationService.rem", WellKnownObjectMode.Singleton);
                }
        
@@ -53,18 +55,37 @@ namespace System.Runtime.Remoting
                {
                        ReturnMessage result;
                        
-                       MonoMethod method = (MonoMethod)reqMsg.MethodBase;
-
-                       try {
+                       MonoMethod method = (MonoMethod) target.GetType().GetMethod(reqMsg.MethodName, BindingFlags.Public|BindingFlags.NonPublic|BindingFlags.Instance, null, (Type[]) reqMsg.MethodSignature, null);
+                       object oldContext = CallContext.SetCurrentCallContext (reqMsg.LogicalCallContext);
+                       
+                       try 
+                       {
                                object [] out_args;
                                object rval = InternalExecute (method, target, reqMsg.Args, out out_args);
-                               result = new ReturnMessage (rval, out_args, out_args.Length,
-                                                           reqMsg.LogicalCallContext, reqMsg);
                        
-                       } catch (Exception e) {
+                               // Collect parameters with Out flag from the request message
+
+                               ParameterInfo[] parameters = method.GetParameters();
+                               object[] returnArgs = new object [parameters.Length];
+                               
+                               int n = 0;
+                               int noa = 0;
+                               foreach (ParameterInfo par in parameters)
+                               {
+                                       if (par.IsOut && !par.ParameterType.IsByRef) 
+                                               returnArgs [n++] = reqMsg.GetArg (par.Position);
+                                       else if (par.ParameterType.IsByRef)
+                                               returnArgs [n++] = out_args [noa++]; 
+                               }
+                               
+                               result = new ReturnMessage (rval, returnArgs, n, CallContext.CreateLogicalCallContext(), reqMsg);
+                       } 
+                       catch (Exception e) 
+                       {
                                result = new ReturnMessage (e, reqMsg);
                        }
-
+                       
+                       CallContext.RestoreCallContext (oldContext);
                        return result;
                }
 
@@ -84,18 +105,48 @@ namespace System.Runtime.Remoting
                public static object Connect (Type classToProxy, string url)
                {
                        ObjRef objRef = new ObjRef (classToProxy, url, null);
-                       return GetRemoteObject(objRef);
+                       return GetRemoteObject (objRef, classToProxy);
                }
 
                public static object Connect (Type classToProxy, string url, object data)
                {
                        ObjRef objRef = new ObjRef (classToProxy, url, data);
-                       return GetRemoteObject(objRef);
+                       return GetRemoteObject (objRef, classToProxy);
+               }
+
+               public static bool Disconnect (MarshalByRefObject obj)
+               {
+                       if (obj == null) throw new ArgumentNullException ("obj");
+
+                       ServerIdentity identity;
+
+                       if (IsTransparentProxy (obj))
+                       {
+                               // CBOs are always accessed through a proxy, even in the server, so
+                               // for server CBOs it is ok to disconnect a proxy
+
+                               RealProxy proxy = GetRealProxy(obj);
+                               if (proxy.GetProxiedType().IsContextful && (proxy.ObjectIdentity is ServerIdentity))
+                                       identity = proxy.ObjectIdentity as ServerIdentity;
+                               else
+                                       throw new ArgumentException ("The obj parameter is a proxy.");
+                       }
+                       else
+                               identity = obj.ObjectIdentity;
+
+                       if (identity == null || !identity.IsConnected)
+                               return false;
+                       else
+                       {
+                               LifetimeServices.StopTrackingLifetime (identity);
+                               DisposeIdentity (identity);
+                               return true;
+                       }
                }
 
                public static Type GetServerTypeForUri (string uri)
                {
-                       Identity ident = GetIdentityForUri (uri);
+                       ServerIdentity ident = GetIdentityForUri (uri) as ServerIdentity;
                        if (ident == null) return null;
                        return ident.ObjectType;
                }
@@ -103,26 +154,33 @@ namespace System.Runtime.Remoting
                public static string GetObjectUri (MarshalByRefObject obj)
                {
                        Identity ident = GetObjectIdentity(obj);
-                       if (ident != null) return ident.ObjectUri;
+                       if (ident is ClientIdentity) return ((ClientIdentity)ident).TargetUri;
+                       else if (ident != null) return ident.ObjectUri;
                        else return null;
                }
 
                public static object Unmarshal (ObjRef objref)
                {
-                       return Unmarshal(objref, false);
+                       return Unmarshal(objref, true);
                }
 
                public static object Unmarshal (ObjRef objref, bool fRefine)
                {
-                       // FIXME: use type name when fRefine==true
+                       Type classToProxy = fRefine ? objref.ServerType : typeof (MarshalByRefObject);
+                       if (classToProxy == null) classToProxy = typeof (MarshalByRefObject);
 
                        if (objref.IsReferenceToWellKnow)
-                               return GetRemoteObject(objref);
+                               return GetRemoteObject(objref, classToProxy);
                        else
                        {
-                               ClientActivatedIdentity identity = uri_hash [objref.URI] as ClientActivatedIdentity;
-                               if (identity != null) return identity.GetServerObject ();
-                               else return GetRemoteObject (objref);
+                               if (classToProxy.IsContextful)
+                               {
+                                       // Look for a ProxyAttribute
+                                       ProxyAttribute att = (ProxyAttribute) Attribute.GetCustomAttribute (classToProxy, typeof(ProxyAttribute),true);
+                                       if (att != null)
+                                               return att.CreateProxy (objref, classToProxy, null, null).GetTransparentProxy();
+                               }
+                               return GetProxyForRemoteObject (objref, classToProxy);
                        }
                }
 
@@ -141,10 +199,22 @@ namespace System.Runtime.Remoting
                        if (IsTransparentProxy (obj))
                        {
                                RealProxy proxy = RemotingServices.GetRealProxy(obj);
-                               if (proxy != null && proxy.ObjectIdentity != null)
+                               Identity identity = proxy.ObjectIdentity;
+
+                               if (identity != null)
                                {
-                                       if (uri != null)
-                                               throw new RemotingException ("It is not possible marshal a proxy of a remote object");
+                                       if (proxy.GetProxiedType().IsContextful && !identity.IsConnected)
+                                       {
+                                               // Unregistered local contextbound object. Register now.
+                                               ClientActivatedIdentity cboundIdentity = (ClientActivatedIdentity)identity;
+                                               if (uri == null) uri = NewUri();
+                                               cboundIdentity.ObjectUri = uri;
+                                               RegisterServerIdentity (cboundIdentity);
+                                               cboundIdentity.StartTrackingLifetime ((ILease)obj.InitializeLifetimeService());
+                                               return cboundIdentity.CreateObjRef(requested_type);
+                                       }
+                                       else if (uri != null)
+                                               throw new RemotingException ("It is not possible marshal a proxy of a remote object.");
 
                                        return proxy.ObjectIdentity.CreateObjRef(requested_type);
                                }
@@ -154,22 +224,34 @@ namespace System.Runtime.Remoting
 
                        if (uri == null) 
                        {
-                               uri = app_id + Environment.TickCount + "_" + next_id++;
-                               CreateClientActivatedServerIdentity (obj, requested_type, uri);
+                               if (obj.ObjectIdentity == null)
+                               {
+                                       uri = NewUri();
+                                       CreateClientActivatedServerIdentity (obj, requested_type, uri);
+                               }
                        }
                        else
                        {
-                               ClientActivatedIdentity identity = uri_hash [uri] as ClientActivatedIdentity;
+                               ClientActivatedIdentity identity = GetIdentityForUri ("/" + uri) as ClientActivatedIdentity;
                                if (identity == null || obj != identity.GetServerObject()) 
                                        CreateClientActivatedServerIdentity (obj, requested_type, uri);
                        }
 
-                       return obj.CreateObjRef(requested_type);
+                       if (IsTransparentProxy (obj))
+                               return RemotingServices.GetRealProxy(obj).ObjectIdentity.CreateObjRef (requested_type);
+                       else
+                               return obj.CreateObjRef(requested_type);
+               }
+
+               static string NewUri ()
+               {
+                       int n = Interlocked.Increment (ref next_id);
+                       return app_id + Environment.TickCount + "_" + n + ".rem";
                }
 
                public static RealProxy GetRealProxy (object proxy)
                {
-                       if (!IsTransparentProxy(proxy)) throw new RemotingException("Cannot get the real proxy from an object that is not a transparent proxy");
+                       if (!IsTransparentProxy(proxy)) throw new RemotingException("Cannot get the real proxy from an object that is not a transparent proxy.");
                        return (RealProxy)((TransparentProxy)proxy)._rp;
                }
 
@@ -177,7 +259,7 @@ namespace System.Runtime.Remoting
                {
                        Type type = Type.GetType (msg.TypeName);
                        if (type == null)
-                               throw new RemotingException ("Type '" + msg.TypeName + "' not found!");
+                               throw new RemotingException ("Type '" + msg.TypeName + "' not found.");
 
                        BindingFlags bflags = BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic;
                        if (msg.MethodSignature == null)
@@ -201,14 +283,34 @@ namespace System.Runtime.Remoting
                        else return ident.CreateObjRef(null);
                }
 
-               [MonoTODO]
+               public static object GetLifetimeService (MarshalByRefObject obj)
+               {
+                       if (obj == null) return null;
+                       return obj.GetLifetimeService ();
+               }
+
+               public static IMessageSink GetEnvoyChainForProxy (MarshalByRefObject obj)
+               {
+                       if (IsTransparentProxy(obj))
+                               return ((ClientIdentity)GetRealProxy (obj).ObjectIdentity).EnvoySink;
+                       else
+                               throw new ArgumentException ("obj must be a proxy.","obj");                     
+               }
+
+               public static void LogRemotingStage (int stage)
+               {
+                       throw new NotImplementedException ();
+               }
+
                public static string GetSessionIdForMethodMessage(IMethodMessage msg)
                {
-                       throw new NotImplementedException (); 
+                       // It seems that this it what MS returns.
+                       return msg.Uri;
                }
 
                public static bool IsMethodOverloaded(IMethodMessage msg)
                {
+                       // TODO: use internal call for better performance
                        Type type = msg.MethodBase.DeclaringType;
                        MemberInfo[] members = type.GetMember (msg.MethodName, MemberTypes.Method, BindingFlags.NonPublic | BindingFlags.Public | BindingFlags.Instance);
                        return members.Length > 1;
@@ -216,6 +318,7 @@ namespace System.Runtime.Remoting
 
                public static bool IsObjectOutOfAppDomain(object tp)
                {
+                       // TODO: use internal call for better performance
                        Identity ident = GetObjectIdentity((MarshalByRefObject)tp);
                        if (ident != null) return !ident.IsFromThisAppDomain;
                        else return false;
@@ -223,6 +326,7 @@ namespace System.Runtime.Remoting
 
                public static bool IsObjectOutOfContext(object tp)
                {
+                       // TODO: use internal call for better performance
                        ServerIdentity ident = GetObjectIdentity((MarshalByRefObject)tp) as ServerIdentity;
                        if (ident != null) return ident.Context != System.Threading.Thread.CurrentContext;
                        else return false;
@@ -230,10 +334,19 @@ namespace System.Runtime.Remoting
 
                public static bool IsOneWay(MethodBase method)
                {
+                       // TODO: use internal call for better performance
                        object[] atts = method.GetCustomAttributes (typeof (OneWayAttribute), false);
                        return atts.Length > 0;
                }
 
+               internal static bool IsAsyncMessage(IMessage msg)
+               {
+                       if (! (msg is MonoMethodMessage)) return false;
+                       else if (((MonoMethodMessage)msg).IsAsync) return true;
+                       else if (IsOneWay (((MonoMethodMessage)msg).MethodBase)) return true;
+                       else return false;
+               }
+
                public static void SetObjectUriForMarshal(MarshalByRefObject obj, string uri)
                {
                        if (IsTransparentProxy (obj)) throw new RemotingException ("SetObjectUriForMarshal method should only be called for MarshalByRefObjects that exist in the current AppDomain.");
@@ -242,11 +355,53 @@ namespace System.Runtime.Remoting
 
                #region Internal Methods
                
+               internal static object CreateClientProxy (ActivatedClientTypeEntry entry, object[] activationAttributes)
+               {
+                       if (entry.ContextAttributes != null || activationAttributes != null)
+                       {
+                               ArrayList props = new ArrayList ();
+                               if (entry.ContextAttributes != null) props.AddRange (entry.ContextAttributes);
+                               if (activationAttributes != null) props.AddRange (activationAttributes);
+                               return CreateClientProxy (entry.ObjectType, entry.ApplicationUrl, props.ToArray ());
+                       }
+                       else
+                               return CreateClientProxy (entry.ObjectType, entry.ApplicationUrl, null);
+               }
+       
+               internal static object CreateClientProxy (Type objectType, string url, object[] activationAttributes)
+               {
+                       string activationUrl = url + "/RemoteActivationService.rem";
+
+                       string objectUri;
+                       IMessageSink sink = GetClientChannelSinkChain (activationUrl, null, out objectUri);
+
+                       RemotingProxy proxy = new RemotingProxy (objectType, activationUrl, activationAttributes);
+                       return proxy.GetTransparentProxy();
+               }
+       
+               internal static object CreateClientProxy (WellKnownClientTypeEntry entry)
+               {
+                       return Connect (entry.ObjectType, entry.ObjectUrl, null);
+               }
+       
+               internal static object CreateClientProxyForContextBound (Type type, object[] activationAttributes)
+               {
+                       if (type.IsContextful)
+                       {
+                               // Look for a ProxyAttribute
+                               ProxyAttribute att = (ProxyAttribute) Attribute.GetCustomAttribute (type, typeof(ProxyAttribute), true);
+                               if (att != null)
+                                       return att.CreateInstance (type);
+                       }
+                       RemotingProxy proxy = new RemotingProxy (type, ChannelServices.CrossContextUrl, activationAttributes);
+                       return proxy.GetTransparentProxy();
+               }
+       
                internal static Identity GetIdentityForUri (string uri)
                {
                        lock (uri_hash)
                        {
-                               return (Identity)uri_hash [uri];
+                               return (Identity)uri_hash [GetNormalizedUri(uri)];
                        }
                }
 
@@ -258,7 +413,7 @@ namespace System.Runtime.Remoting
                                return obj.ObjectIdentity;
                }
 
-               private static ClientIdentity GetOrCreateClientIdentity(ObjRef objRef)
+               internal static ClientIdentity GetOrCreateClientIdentity(ObjRef objRef, Type proxyType, out object clientProxy)
                {
                        // This method looks for an identity for the given url. 
                        // If an identity is not found, it creates the identity and 
@@ -271,46 +426,78 @@ namespace System.Runtime.Remoting
                        string url = (channelData == null) ? objRef.URI : null;
 
                        string objectUri;
-                       IMessageSink sink = ChannelServices.CreateClientChannelSinkChain (url, channelData, out objectUri);
-                       if (sink == null) 
-                       {
-                               if (url != null) {
-                                       string msg = String.Format ("Cannot create channel sink to connect to URL {0}. An appropriate channel has probably not been registered.", url); 
-                                       throw new RemotingException (msg);
-                               }
-                               else {
-                                       string msg = String.Format ("Cannot create channel sink to connect to the remote object. An appropriate channel has probably not been registered.", url); 
-                                       throw new RemotingException (msg);
-                               }
-                       }
+                       IMessageSink sink = GetClientChannelSinkChain (url, channelData, out objectUri);
 
                        if (objectUri == null) objectUri = objRef.URI;
 
                        lock (uri_hash)
                        {
-                               ClientIdentity identity = uri_hash [objRef.URI] as ClientIdentity;
-                               if (identity != null) 
-                                       return identity;        // Object already registered
+                               clientProxy = null;
+                               string uri = GetNormalizedUri (objRef.URI);
+                               
+                               ClientIdentity identity = uri_hash [uri] as ClientIdentity;
+                               if (identity != null)
+                               {
+                                       // Object already registered
+                                       clientProxy = identity.ClientProxy;
+                                       if (clientProxy != null) return identity;
+                                       
+                                       // The proxy has just been GCed, so its identity cannot
+                                       // be reused. Just dispose it.
+                                       DisposeIdentity (identity);
+                               }
 
                                // Creates an identity and a proxy for the remote object
 
                                identity = new ClientIdentity (objectUri, objRef);
-                               identity.ClientSink = sink;
-
-                               RemotingProxy proxy = new RemotingProxy (Type.GetType (objRef.TypeInfo.TypeName), identity);
-                               identity.ClientProxy = (MarshalByRefObject) proxy.GetTransparentProxy();
+                               identity.ChannelSink = sink;
 
                                // Registers the identity
-                               uri_hash [objRef.URI] = identity;
+                               uri_hash [uri] = identity;
+                               
+                               if (proxyType != null)
+                               {
+                                       RemotingProxy proxy = new RemotingProxy (proxyType, identity);
+                                       clientProxy = proxy.GetTransparentProxy();
+                                       identity.ClientProxy = (MarshalByRefObject) clientProxy;
+                               }
+
                                return identity;
                        }
                }
 
+               static IMessageSink GetClientChannelSinkChain(string url, object channelData, out string objectUri)
+               {
+                       IMessageSink sink = ChannelServices.CreateClientChannelSinkChain (url, channelData, out objectUri);
+                       if (sink == null) 
+                       {
+                               if (url != null) 
+                               {
+                                       string msg = String.Format ("Cannot create channel sink to connect to URL {0}. An appropriate channel has probably not been registered.", url); 
+                                       throw new RemotingException (msg);
+                               }
+                               else 
+                               {
+                                       string msg = String.Format ("Cannot create channel sink to connect to the remote object. An appropriate channel has probably not been registered.", url); 
+                                       throw new RemotingException (msg);
+                               }
+                       }
+                       return sink;
+               }
+
+               internal static ClientActivatedIdentity CreateContextBoundObjectIdentity(Type objectType)
+               {
+                       ClientActivatedIdentity identity = new ClientActivatedIdentity (null, objectType);
+                       identity.ChannelSink = ChannelServices.CrossContextChannel;
+                       return identity;
+               }
+
                internal static ClientActivatedIdentity CreateClientActivatedServerIdentity(MarshalByRefObject realObject, Type objectType, string objectUri)
                {
-                       ClientActivatedIdentity identity = new ClientActivatedIdentity (objectUri, Context.DefaultContext, objectType);
-                       identity.AttachServerObject (realObject);
+                       ClientActivatedIdentity identity = new ClientActivatedIdentity (objectUri, objectType);
+                       identity.AttachServerObject (realObject, Context.DefaultContext);
                        RegisterServerIdentity (identity);
+                       identity.StartTrackingLifetime ((ILease)realObject.InitializeLifetimeService ());
                        return identity;
                }
 
@@ -327,45 +514,49 @@ namespace System.Runtime.Remoting
                        return identity;
                }
 
-               private static void RegisterServerIdentity(Identity identity)
+               private static void RegisterServerIdentity(ServerIdentity identity)
                {
                        lock (uri_hash)
                        {
                                if (uri_hash.ContainsKey (identity.ObjectUri)) 
-                                       throw new RemotingException ("Uri already in use: " + identity.ObjectUri);
+                                       throw new RemotingException ("Uri already in use: " + identity.ObjectUri + ".");
 
                                uri_hash[identity.ObjectUri] = identity;
                        }
                }
 
-               internal static object GetRemoteObject(ObjRef objRef)
+               internal static object GetProxyForRemoteObject (ObjRef objref, Type classToProxy)
                {
-                       ClientIdentity id = GetOrCreateClientIdentity (objRef);
-                       return id.ClientProxy;
+                       ClientActivatedIdentity identity = GetIdentityForUri (objref.URI) as ClientActivatedIdentity;
+                       if (identity != null) return identity.GetServerObject ();
+                       else return GetRemoteObject (objref, classToProxy);
+               }
+
+               internal static object GetRemoteObject(ObjRef objRef, Type proxyType)
+               {
+                       object proxy;
+                       GetOrCreateClientIdentity (objRef, proxyType, out proxy);
+                       return proxy;
                }
 
                internal static object GetDomainProxy(AppDomain domain) 
                {
-                       ObjRef appRef = null;
+                       byte[] data = null;
 
-                       // Make sure that the channels is active in this domain
-                       RegisterInternalChannels();
+                       Context currentContext = Thread.CurrentContext;
 
-                       // this should use contexts in the future
-                       AppDomain currentDomain = AppDomain.InternalSetDomain (domain);
-                       try 
+                       try
                        {
-                               // Make sure that our new domain also has the internal channels
-                               RegisterInternalChannels();
-
-                               appRef = RemotingServices.Marshal(domain, null, null);
+                               data = (byte[])AppDomain.InvokeInDomain (domain, typeof (AppDomain).GetMethod ("GetMarshalledDomainObjRef", BindingFlags.Instance|BindingFlags.NonPublic), domain, null);
                        }
-                       finally 
+                       finally
                        {
-                               AppDomain.InternalSetDomain (currentDomain);
-                       }
+                               AppDomain.InternalSetContext (currentContext);
+                       }                               
 
-                       return (AppDomain) RemotingServices.Unmarshal(appRef);
+                       MemoryStream stream = new MemoryStream (data);
+                       ObjRef appref = (ObjRef) CADSerializer.DeserializeObject (stream);
+                       return (AppDomain) RemotingServices.Unmarshal(appref);
                }
 
                private static void RegisterInternalChannels() 
@@ -375,20 +566,71 @@ namespace System.Runtime.Remoting
                
                internal static void DisposeIdentity (Identity ident)
                {
-                       uri_hash.Remove (ident.ObjectUri);
+                       lock (uri_hash)
+                       {
+                               if (!ident.Disposed) {
+                                       ClientIdentity clientId = ident as ClientIdentity;
+                                       if (clientId != null)
+                                               uri_hash.Remove (GetNormalizedUri (clientId.TargetUri));
+                                       else
+                                               uri_hash.Remove (ident.ObjectUri);
+                                               
+                                       ident.Disposed = true;
+                               }
+                       }
                }
 
-               internal static ServerIdentity GetMessageTargetIdentity (IMessage msg)
+               internal static Identity GetMessageTargetIdentity (IMessage msg)
                {
                        // Returns the identity where the message is sent
-                       // TODO: check for identity embedded in MethodCall
+
+                       if (msg is IInternalMessage) 
+                               return ((IInternalMessage)msg).TargetIdentity;
 
                        lock (uri_hash)
                        {
-                               return uri_hash [((IMethodMessage)msg).Uri] as ServerIdentity;
+                               string uri = GetNormalizedUri (((IMethodMessage)msg).Uri);
+                               return uri_hash [uri] as ServerIdentity;
                        }
                }
 
+               internal static void SetMessageTargetIdentity (IMessage msg, Identity ident)
+               {
+                       if (msg is IInternalMessage) 
+                               ((IInternalMessage)msg).TargetIdentity = ident;
+               }
+               
+               internal static bool UpdateOutArgObject (ParameterInfo pi, object local, object remote)
+               {
+                       if (local is StringBuilder) 
+                       {
+                               StringBuilder sb = local as StringBuilder;
+                               sb.Remove (0, sb.Length);
+                               sb.Append (remote.ToString());
+                               return true;
+                       }
+                       else if (pi.ParameterType.IsArray && ((Array)local).Rank == 1)
+                       {
+                               Array alocal = (Array) local;
+                               if (alocal.Rank == 1)
+                               {
+                                       Array.Copy ((Array) remote, alocal, alocal.Length);
+                                       return true;
+                               }
+                               else
+                               {
+                                       // TODO
+                               }
+                       }
+                       return false;
+               }
+               
+               static string GetNormalizedUri (string uri)
+               {
+                       if (uri.StartsWith ("/")) return uri.Substring (1);
+                       else return uri;
+               }
+
                #endregion
        }
 }