2010-07-12 Astushi Enomoto <atsushi@ximian.com>
[mono.git] / mcs / class / System.XML / System.Xml.Serialization / SerializationCodeGenerator.cs
index 93fc7d57f7cfde72984d9bd306670c690f642319..4e43a4f2a87f1ad0eeefbc2dc07c7af05621897c 100644 (file)
@@ -37,6 +37,8 @@ using System.Collections;
 using System.Globalization;
 using System.Text;
 
+using HookDir = System.Xml.Serialization.XmlMappingAccess;
+
 namespace System.Xml.Serialization
 {
        internal class SerializationCodeGenerator
@@ -151,6 +153,7 @@ namespace System.Xml.Serialization
                        _writer = writer;
                        _results = new GenerationResult [_xmlMaps.Length];
                        
+                       WriteLine ("// It is automatically generated");
                        WriteLine ("using System;");
                        WriteLine ("using System.Xml;");
                        WriteLine ("using System.Xml.Schema;");
@@ -345,6 +348,7 @@ namespace System.Xml.Serialization
                                WriteLine ("");
                        }
 
+                       WriteLine ("#if !TARGET_JVM"); // does it make sense? ;-)
                        WriteLine (access_mod + " class " + main.ImplementationClassName + " : System.Xml.Serialization.XmlSerializerImplementation");
                        WriteLineInd ("{");
                        
@@ -434,6 +438,7 @@ namespace System.Xml.Serialization
                        
                        WriteLineUni ("}");
                        WriteLine ("");
+                       WriteLine ("#endif");
                }
 #endif
 
@@ -454,6 +459,12 @@ namespace System.Xml.Serialization
                                WriteLine ("internal class " + writerClassName + " : XmlSerializationWriter");
                        WriteLineInd ("{");
                        WriteLine ("const string xmlNamespace = \"http://www.w3.org/2000/xmlns/\";");
+                       // ToBinHexString() is not public, so use reflection here.
+                       WriteLine ("static readonly System.Reflection.MethodInfo toBinHexStringMethod = typeof (XmlConvert).GetMethod (\"ToBinHexString\", System.Reflection.BindingFlags.Static | System.Reflection.BindingFlags.NonPublic, null, new Type [] {typeof (byte [])}, null);");
+                       WriteLine ("static string ToBinHexString (byte [] input)");
+                       WriteLineInd ("{");
+                       WriteLine ("return input == null ? null : (string) toBinHexStringMethod.Invoke (null, new object [] {input});");
+                       WriteLineUni ("}");
                        
                        for (int n=0; n<maps.Count; n++)
                        {
@@ -575,7 +586,7 @@ namespace System.Xml.Serialization
 
                        WriteLineInd ("switch (val) {");
                        for (int i = 0; i < emap.EnumNames.Length; i++)
-                               WriteLine ("case " + map.TypeData.CSharpFullName + "." + emap.EnumNames[i] + ": return " + GetLiteral (emap.XmlNames[i]) + ";");
+                               WriteLine ("case " + map.TypeData.CSharpFullName + ".@" + emap.EnumNames[i] + ": return " + GetLiteral (emap.XmlNames[i]) + ";");
 
                        if (emap.IsFlags) {
                                WriteLineInd ("default:");
@@ -613,8 +624,6 @@ namespace System.Xml.Serialization
                        SetHookVar ("$TYPE", typeMap.TypeData.CSharpName);
                        SetHookVar ("$FULLTYPE", typeMap.TypeData.CSharpFullName);
                        SetHookVar ("$OBJECT", "ob");
-                       SetHookVar ("$ELEMENT", "element");
-                       SetHookVar ("$NAMESPACE", "namesp");
                        SetHookVar ("$NULLABLE", "isNullable");
 
                        if (GenerateWriteHook (HookType.type, typeMap.TypeData.Type))
@@ -684,7 +693,14 @@ namespace System.Xml.Serialization
                        
                        if (typeMap.TypeData.Type == typeof (object)) {
                                WriteLineInd ("else {");
-                               WriteLine ("WriteTypedPrimitive (element, namesp, ob, true);");
+                               WriteLineInd ("if (ob.GetType().IsArray && typeof(XmlNode).IsAssignableFrom(ob.GetType().GetElementType())) {");
+                               WriteLine ("Writer.WriteStartElement (" + GetLiteral (typeMap.ElementName) + ", " + GetLiteral (typeMap.Namespace) + ");");
+                               WriteLineInd ("foreach (XmlNode node in (System.Collections.IEnumerable) ob)");
+                               WriteLineUni ("node.WriteTo (Writer);");
+                               WriteLineUni ("Writer.WriteEndElement ();");
+                               WriteLine ("}");
+                               WriteLineInd ("else");
+                               WriteLineUni ("WriteTypedPrimitive (element, namesp, ob, true);");
                                WriteLine ("return;");
                                WriteLineUni ("}");
                        }
@@ -772,7 +788,7 @@ namespace System.Xml.Serialization
                                                
                                                if (cond != null) WriteLineInd ("if (" + cond + ") {");
                                                
-                                               string strVal = GenerateGetStringValue (attr.MappedType, attr.TypeData, val);
+                                               string strVal = GenerateGetStringValue (attr.MappedType, attr.TypeData, val, false);
                                                WriteLine ("WriteAttribute (" + GetLiteral(attr.AttributeName) + ", " + GetLiteral(attr.Namespace) + ", " + strVal + ");");
        
                                                if (cond != null) WriteLineUni ("}");
@@ -925,7 +941,7 @@ namespace System.Xml.Serialization
                                        break;
 
                                case SchemaTypes.XmlSerializable:
-                                       WriteMetCall ("WriteSerializable", memberValue, GetLiteral(elem.ElementName), GetLiteral(elem.Namespace), GetLiteral(elem.IsNullable));
+                                       WriteMetCall ("WriteSerializable",  "(" + ToCSharpFullName (elem.MappedType.TypeData.Type) + ") " + memberValue, GetLiteral(elem.ElementName), GetLiteral(elem.Namespace), GetLiteral(elem.IsNullable));
                                        break;
 
                                default:
@@ -955,15 +971,19 @@ namespace System.Xml.Serialization
                void GenerateWriteAnyElementContent (XmlTypeMapMemberAnyElement member, string memberValue)
                {
                        bool singleElement = (member.TypeData.Type == typeof (XmlElement));
-                       string var;
+                       string var, var2;
                        
+                       var2 = GetObTempVar ();
                        if (singleElement)
                                var = memberValue;
                        else {
                                var = GetObTempVar ();
-                               WriteLineInd ("foreach (XmlNode " + var + " in " + memberValue + ") {");
+                               WriteLineInd ("foreach (object " + var2 + " in " + memberValue + ") {");
                        }
-                       
+                       WriteLine ("XmlNode " + var + " = " + var2 + " as XmlNode;");
+                       WriteLine ("if (" + var + " == null && " + var2 + "!= null) throw new InvalidOperationException (\"A member with XmlAnyElementAttribute can only serialize and deserialize certain XmlNode types.");
+                       WriteLineUni ("}");
+
                        string elem = GetObTempVar ();
                        WriteLine ("XmlNode " + elem + " = " + var + ";");
                        WriteLine ("if (" + elem + " is XmlElement) {");
@@ -971,7 +991,7 @@ namespace System.Xml.Serialization
                        if (!member.IsDefaultAny) {
                                for (int n=0; n<member.ElementInfo.Count; n++) {
                                        XmlTypeMapElementInfo info = (XmlTypeMapElementInfo)member.ElementInfo[n];
-                                       string txt = "(" + elem + ".Name == " + GetLiteral(info.ElementName) + " && " + elem + ".NamespaceURI == " + GetLiteral(info.Namespace) + ")";
+                                       string txt = "(" + elem + ".LocalName == " + GetLiteral(info.ElementName) + " && " + elem + ".NamespaceURI == " + GetLiteral(info.Namespace) + ")";
                                        if (n == member.ElementInfo.Count-1) txt += ") {";
                                        if (n == 0) WriteLineInd ("if (" + txt);
                                        else WriteLine ("|| " + txt);
@@ -998,7 +1018,7 @@ namespace System.Xml.Serialization
 
                void GenerateWritePrimitiveElement (XmlTypeMapping typeMap, string ob)
                {
-                       string strVal = GenerateGetStringValue (typeMap, typeMap.TypeData, ob);
+                       string strVal = GenerateGetStringValue (typeMap, typeMap.TypeData, ob, false);
                        WriteLine ("Writer.WriteString (" + strVal + ");");
                }
 
@@ -1008,7 +1028,7 @@ namespace System.Xml.Serialization
                        WriteLine ("Writer.WriteString (" + strVal + ");");
                }
 
-               string GenerateGetStringValue (XmlTypeMapping typeMap, TypeData type, string value)
+               string GenerateGetStringValue (XmlTypeMapping typeMap, TypeData type, string value, bool isNullable)
                {
                        if (type.SchemaType == SchemaTypes.Array) {
                                string str = GetStrTempVar ();
@@ -1020,7 +1040,10 @@ namespace System.Xml.Serialization
                                return str;
                        }
                        else if (type.SchemaType == SchemaTypes.Enum) {
-                               return GenerateGetEnumXmlValue (typeMap, value);
+                               if (isNullable)
+                                       return "(" + value + ").HasValue ? " + GenerateGetEnumXmlValue (typeMap, "(" + value + ").Value") + " : null";
+                               else
+                                       return GenerateGetEnumXmlValue (typeMap, value);
                        }
                        else if (type.Type == typeof (XmlQualifiedName))
                                return "FromXmlQualifiedName (" + value + ")";
@@ -1136,7 +1159,7 @@ namespace System.Xml.Serialization
                                        GenerateWriteMemberElement (info, GetCast (info.TypeData, itemTypeData, item));
                                else
                                {
-                                       string strVal = GenerateGetStringValue (info.MappedType, info.TypeData, GetCast (info.TypeData, itemTypeData, item));
+                                       string strVal = GenerateGetStringValue (info.MappedType, info.TypeData, GetCast (info.TypeData, itemTypeData, item), false);
                                        WriteLine (targetString + ".Append (" + strVal + ").Append (\" \");");
                                }
 
@@ -1151,14 +1174,14 @@ namespace System.Xml.Serialization
                void GenerateWritePrimitiveValueLiteral (string memberValue, string name, string ns, XmlTypeMapping mappedType, TypeData typeData, bool wrapped, bool isNullable)
                {
                        if (!wrapped) {
-                               string strVal = GenerateGetStringValue (mappedType, typeData, memberValue);
+                               string strVal = GenerateGetStringValue (mappedType, typeData, memberValue, false);
                                WriteMetCall ("WriteValue", strVal);
                        }
                        else if (isNullable) {
                                if (typeData.Type == typeof(XmlQualifiedName)) 
                                        WriteMetCall ("WriteNullableQualifiedNameLiteral", GetLiteral(name), GetLiteral(ns), memberValue);
                                else  {
-                                       string strVal = GenerateGetStringValue (mappedType, typeData, memberValue);
+                                       string strVal = GenerateGetStringValue (mappedType, typeData, memberValue, true);
                                        WriteMetCall ("WriteNullableStringLiteral", GetLiteral(name), GetLiteral(ns), strVal);
                                }
                        }
@@ -1166,7 +1189,7 @@ namespace System.Xml.Serialization
                                if (typeData.Type == typeof(XmlQualifiedName))
                                        WriteMetCall ("WriteElementQualifiedName", GetLiteral(name), GetLiteral(ns), memberValue);
                                else {
-                                       string strVal = GenerateGetStringValue (mappedType, typeData, memberValue);
+                                       string strVal = GenerateGetStringValue (mappedType, typeData, memberValue, false);
                                        WriteMetCall ("WriteElementString", GetLiteral(name),GetLiteral(ns), strVal);
                                }
                        }
@@ -1175,14 +1198,14 @@ namespace System.Xml.Serialization
                void GenerateWritePrimitiveValueEncoded (string memberValue, string name, string ns, XmlQualifiedName xsiType, XmlTypeMapping mappedType, TypeData typeData, bool wrapped, bool isNullable)
                {
                        if (!wrapped) {
-                               string strVal = GenerateGetStringValue (mappedType, typeData, memberValue);
+                               string strVal = GenerateGetStringValue (mappedType, typeData, memberValue, false);
                                WriteMetCall ("WriteValue", strVal);
                        }
                        else if (isNullable) {
                                if (typeData.Type == typeof(XmlQualifiedName)) 
                                        WriteMetCall ("WriteNullableQualifiedNameEncoded", GetLiteral(name), GetLiteral(ns), memberValue, GetLiteral(xsiType));
                                else  {
-                                       string strVal = GenerateGetStringValue (mappedType, typeData, memberValue);
+                                       string strVal = GenerateGetStringValue (mappedType, typeData, memberValue, true);
                                        WriteMetCall ("WriteNullableStringEncoded", GetLiteral(name), GetLiteral(ns), strVal, GetLiteral(xsiType));
                                }
                        }
@@ -1190,7 +1213,7 @@ namespace System.Xml.Serialization
                                if (typeData.Type == typeof(XmlQualifiedName))
                                        WriteMetCall ("WriteElementQualifiedName", GetLiteral(name), GetLiteral(ns), memberValue, GetLiteral(xsiType));
                                else {
-                                       string strVal = GenerateGetStringValue (mappedType, typeData, memberValue);
+                                       string strVal = GenerateGetStringValue (mappedType, typeData, memberValue, false);
                                        WriteMetCall ("WriteElementString", GetLiteral(name),GetLiteral(ns), strVal, GetLiteral(xsiType));
                                }
                        }
@@ -1284,6 +1307,12 @@ namespace System.Xml.Serialization
                        else
                                WriteLine ("internal class " + readerClassName + " : XmlSerializationReader");
                        WriteLineInd ("{");
+                       // FromBinHexString() is not public, so use reflection here.
+                       WriteLine ("static readonly System.Reflection.MethodInfo fromBinHexStringMethod = typeof (XmlConvert).GetMethod (\"FromBinHexString\", System.Reflection.BindingFlags.Static | System.Reflection.BindingFlags.NonPublic, null, new Type [] {typeof (string)}, null);");
+                       WriteLine ("static byte [] FromBinHexString (string input)");
+                       WriteLineInd ("{");
+                       WriteLine ("return input == null ? null : (byte []) fromBinHexStringMethod.Invoke (null, new object [] {input});");
+                       WriteLineUni ("}");
 
                        _mapsToGenerate = new ArrayList ();
                        _fixupCallbacks = new ArrayList ();
@@ -1306,7 +1335,7 @@ namespace System.Xml.Serialization
                                
                                GenerateReadObject (map);
                                if (map.TypeData.SchemaType == SchemaTypes.Enum)
-                                       GenerateGetEnumValue (map);
+                                       GenerateGetEnumValueMethod (map);
                        }
                        
                        GenerateReadInitCallbacks ();
@@ -1397,6 +1426,7 @@ namespace System.Xml.Serialization
                                        WriteLineInd ("{");
                                        WriteLineInd ("if (Reader.IsEmptyElement) {");
                                        WriteLine ("Reader.Skip();");
+                                       WriteLine ("Reader.MoveToContent();");
                                        WriteLineUni ("}");
                                        WriteLineInd ("else {");
                                        WriteLine ("Reader.ReadStartElement();");
@@ -1409,11 +1439,27 @@ namespace System.Xml.Serialization
                                }
                                else
                                {
-                                       WriteLine ("while (Reader.NodeType != System.Xml.XmlNodeType.EndElement)");
+                                       // bug #79988: out parameters need to be initialized if 
+                                       // they are value types
+                                       ClassMap classMap = (ClassMap) typeMap.ObjectMap;
+                                       ArrayList members = classMap.AllMembers;
+                                       for (int n = 0; n < members.Count; n++) {
+                                               XmlTypeMapMember mem = (XmlTypeMapMember) members [n];
+                                               if (!mem.IsReturnValue && mem.TypeData.IsValueType)
+                                                       GenerateSetMemberValueFromAttr (mem, "parameters",
+                                                               String.Format ("({0}) Activator.CreateInstance(typeof({0}), true)", mem.TypeData.FullTypeName), true);
+                                       }
+
+                                       WriteLine ("while (Reader.NodeType != System.Xml.XmlNodeType.EndElement && Reader.ReadState == ReadState.Interactive)");
                                        WriteLineInd ("{");
                                        WriteLine ("if (Reader.IsStartElement(" + GetLiteral(typeMap.ElementName) + ", " + GetLiteral(typeMap.Namespace) + "))");
                                        WriteLineInd ("{");
-                                       WriteLine ("if (Reader.IsEmptyElement) { Reader.Skip(); Reader.MoveToContent(); continue; }");
+                                       bool dummy = false;
+                                       GenerateReadAttributeMembers (typeMap, (ClassMap)typeMap.ObjectMap, "parameters", true, ref dummy);
+                                       WriteLine ("if (Reader.IsEmptyElement)");
+                                       WriteLineInd ("{");
+                                       WriteLine ("Reader.Skip(); Reader.MoveToContent(); continue;");
+                                       WriteLineUni ("}");
                                        WriteLine ("Reader.ReadStartElement();");
                                        GenerateReadMembers (typeMap, (ClassMap)typeMap.ObjectMap, "parameters", true, false);
                                        WriteLine ("ReadEndElement();");
@@ -1501,7 +1547,7 @@ namespace System.Xml.Serialization
                        }
                        else
                        {
-                               WriteLine (typeMap.TypeData.CSharpFullName + " ob = new " + typeMap.TypeData.CSharpFullName + " ();");
+                               WriteLine (typeMap.TypeData.CSharpFullName + String.Format (" ob = ({0}) Activator.CreateInstance(typeof({0}), true);", typeMap.TypeData.CSharpFullName));
                        
                                if (GenerateReadHook (HookType.type, typeMap.TypeData.Type)) {
                                        WriteLine ("return ob;");
@@ -1541,7 +1587,7 @@ namespace System.Xml.Serialization
                                }
        
                                WriteLine ("");
-                               WriteLine ("ob = new " + typeMap.TypeData.CSharpFullName + " ();");
+                               WriteLine (String.Format ("ob = ({0}) Activator.CreateInstance(typeof({0}), true);", typeMap.TypeData.CSharpFullName));
                        }
                        
                        WriteLine ("");
@@ -1562,100 +1608,9 @@ namespace System.Xml.Serialization
                        XmlTypeMapping typeMap = xmlMap as XmlTypeMapping;
                        Type xmlMapType = (typeMap != null) ? typeMap.TypeData.Type : typeof(object[]);
                        
-                       // Load the default value of members
-                       if (map.MembersWithDefault != null)
-                       {
-                               ArrayList members = map.MembersWithDefault;
-                               for (int n=0; n<members.Count; n++) {
-                                       XmlTypeMapMember mem = (XmlTypeMapMember) members[n];
-                                       GenerateSetMemberValueFromAttr (mem, ob, GetLiteral (mem.DefaultValue), isValueList);
-                               }
-                       }
-                       
-                       // A value list cannot have attributes
-
-                       bool first;
-                       if (!isValueList && !GenerateReadHook (HookType.attributes, xmlMapType))
-                       {
-                               // Reads attributes
-                               
-                               XmlTypeMapMember anyAttrMember = map.DefaultAnyAttributeMember;
-                               
-                               if (anyAttrMember != null)
-                               {
-                                       WriteLine ("int anyAttributeIndex = 0;");
-                                       WriteLine (anyAttrMember.TypeData.CSharpFullName + " anyAttributeArray = null;");
-                               }
-                               
-                               WriteLine ("while (Reader.MoveToNextAttribute())");
-                               WriteLineInd ("{");
-                               first = true;
-                               if (map.AttributeMembers != null) {
-                                       foreach (XmlTypeMapMemberAttribute at in map.AttributeMembers)
-                                       {
-                                               WriteLineInd ((first?"":"else ") + "if (Reader.LocalName == " + GetLiteral (at.AttributeName) + " && Reader.NamespaceURI == " + GetLiteral (at.Namespace) + ") {");
-                                               if (!GenerateReadMemberHook (xmlMapType, at)) {
-                                                       GenerateSetMemberValue (at, ob, GenerateGetValueFromXmlString ("Reader.Value", at.TypeData, at.MappedType), isValueList);
-                                                       GenerateEndHook ();
-                                               }
-                                               WriteLineUni ("}");
-                                               first = false;
-                                       }
-                               }
-                               WriteLineInd ((first?"":"else ") + "if (IsXmlnsAttribute (Reader.Name)) {");
-
-                               // If the map has NamespaceDeclarations,
-                               // then store this xmlns to the given member.
-                               // If the instance doesn't exist, then create.
-                               
-                               if (map.NamespaceDeclarations != null) {
-                                       if (!GenerateReadMemberHook (xmlMapType, map.NamespaceDeclarations)) {
-                                               string nss = ob + ".@" + map.NamespaceDeclarations.Name;
-                                               WriteLine ("if (" + nss + " == null) " + nss + " = new XmlSerializerNamespaces ();");
-                                               WriteLineInd ("if (Reader.Prefix == \"xmlns\")");
-                                               WriteLine (nss + ".Add (Reader.LocalName, Reader.Value);");
-                                               Unindent ();
-                                               WriteLineInd ("else");
-                                               WriteLine (nss + ".Add (\"\", Reader.Value);");
-                                               Unindent ();
-                                               GenerateEndHook ();
-                                       }
-                               }
-                               
-                               WriteLineUni ("}");
-                               WriteLineInd ("else {");
-
-                               if (anyAttrMember != null) 
-                               {
-                                       if (!GenerateReadArrayMemberHook (xmlMapType, anyAttrMember, "anyAttributeIndex")) {
-                                               WriteLine ("System.Xml.XmlAttribute attr = (System.Xml.XmlAttribute) Document.ReadNode(Reader);");
-                                               if (typeof(System.Xml.Schema.XmlSchemaAnnotated).IsAssignableFrom (xmlMapType)) 
-                                                       WriteLine ("ParseWsdlArrayType (attr);");
-                                               GenerateAddListValue (anyAttrMember.TypeData, "anyAttributeArray", "anyAttributeIndex", GetCast (anyAttrMember.TypeData.ListItemTypeData, "attr"), true);
-                                               GenerateEndHook ();
-                                       }
-                                       WriteLine ("anyAttributeIndex++;");
-                               }
-                               else {
-                                       if (!GenerateReadHook (HookType.unknownAttribute, xmlMapType)) {
-                                               WriteLine ("UnknownNode (" + ob + ");");
-                                               GenerateEndHook ();
-                                       }
-                               }
-
-                               WriteLineUni ("}");
-                               WriteLineUni ("}");
-
-                               if (anyAttrMember != null && !MemberHasReadReplaceHook (xmlMapType, anyAttrMember))
-                               {
-                                       WriteLine ("");
-                                       WriteLine("anyAttributeArray = (" + anyAttrMember.TypeData.CSharpFullName + ") ShrinkArray (anyAttributeArray, anyAttributeIndex, " + GetTypeOf(anyAttrMember.TypeData.Type.GetElementType()) + ", true);");
-                                       GenerateSetMemberValue (anyAttrMember, ob, "anyAttributeArray", isValueList);
-                               }
-                               WriteLine ("");
-       
-                               GenerateEndHook ();
-                       }
+                       bool first = false;
+                       // Read attributes
+                       GenerateReadAttributeMembers (xmlMap, map, ob, isValueList, ref first);
 
                        if (!isValueList)
                        {
@@ -1680,14 +1635,22 @@ namespace System.Xml.Serialization
                                string[] readFlag = null;
                                if (map.ElementMembers != null && !readByOrder)
                                {
-                                       string readFlagsVars = "bool ";
+                                       string readFlagsVars = string.Empty;
                                        readFlag = new string[map.ElementMembers.Count];
-                                       for (int n=0; n<map.ElementMembers.Count; n++) {
-                                               readFlag[n] = GetBoolTempVar ();
-                                               if (n > 0) readFlagsVars += ", ";
-                                               readFlagsVars += readFlag[n] + "=false";
+                                       int n=0;
+                                       foreach (XmlTypeMapMember mem in map.ElementMembers) {
+                                               // The text collector doesn't need a flag
+                                               if (!((mem is XmlTypeMapMemberElement) && ((XmlTypeMapMemberElement)mem).IsXmlTextCollector)) {
+                                                       readFlag[n] = GetBoolTempVar ();
+                                                       if (readFlagsVars.Length > 0) readFlagsVars += ", ";
+                                                       readFlagsVars += readFlag[n] + "=false";
+                                               }
+                                               n++;
+                                       }
+                                       if (readFlagsVars.Length > 0) {
+                                               readFlagsVars = "bool " + readFlagsVars;
+                                               WriteLine (readFlagsVars + ";");
                                        }
-                                       if (map.ElementMembers.Count > 0) WriteLine (readFlagsVars + ";");
                                        WriteLine ("");
                                }
                                
@@ -1967,8 +1930,13 @@ namespace System.Xml.Serialization
                                                        XmlTypeMapElementInfo info = (XmlTypeMapElementInfo) mem.ElementInfo [0];
                                                        if (info.TypeData.Type == typeof (string))
                                                                GenerateSetMemberValue (mem, ob, "ReadString (" + GenerateGetMemberValue (mem, ob, isValueList) + ")", isValueList);
-                                                       else
-                                                               GenerateSetMemberValue (mem, ob, GenerateGetValueFromXmlString ("Reader.ReadString()", info.TypeData, info.MappedType), isValueList);
+                                                       else {
+                                                               WriteLineInd ("{");
+                                                               string str = GetStrTempVar ();
+                                                               WriteLine ("string " + str + " = Reader.ReadString();");
+                                                               GenerateSetMemberValue (mem, ob, GenerateGetValueFromXmlString (str, info.TypeData, info.MappedType, info.IsNullable), isValueList);
+                                                               WriteLineUni ("}");
+                                                       }
                                                        GenerateEndHook ();
                                                }
                                                WriteLineUni ("}");
@@ -2023,6 +1991,93 @@ namespace System.Xml.Serialization
                                WriteLine ("ReadEndElement();");
                        }
                }
+
+               void GenerateReadAttributeMembers (XmlMapping xmlMap, ClassMap map, string ob, bool isValueList, ref bool first)
+               {
+                       XmlTypeMapping typeMap = xmlMap as XmlTypeMapping;
+                       Type xmlMapType = (typeMap != null) ? typeMap.TypeData.Type : typeof(object[]);
+
+                       if (GenerateReadHook (HookType.attributes, xmlMapType))
+                               return;
+
+                       XmlTypeMapMember anyAttrMember = map.DefaultAnyAttributeMember;
+                       
+                       if (anyAttrMember != null)
+                       {
+                               WriteLine ("int anyAttributeIndex = 0;");
+                               WriteLine (anyAttrMember.TypeData.CSharpFullName + " anyAttributeArray = null;");
+                       }
+                       
+                       WriteLine ("while (Reader.MoveToNextAttribute())");
+                       WriteLineInd ("{");
+                       first = true;
+                       if (map.AttributeMembers != null) {
+                               foreach (XmlTypeMapMemberAttribute at in map.AttributeMembers)
+                               {
+                                       WriteLineInd ((first?"":"else ") + "if (Reader.LocalName == " + GetLiteral (at.AttributeName) + " && Reader.NamespaceURI == " + GetLiteral (at.Namespace) + ") {");
+                                       if (!GenerateReadMemberHook (xmlMapType, at)) {
+                                               GenerateSetMemberValue (at, ob, GenerateGetValueFromXmlString ("Reader.Value", at.TypeData, at.MappedType, false), isValueList);
+                                               GenerateEndHook ();
+                                       }
+                                       WriteLineUni ("}");
+                                       first = false;
+                               }
+                       }
+                       WriteLineInd ((first?"":"else ") + "if (IsXmlnsAttribute (Reader.Name)) {");
+
+                       // If the map has NamespaceDeclarations,
+                       // then store this xmlns to the given member.
+                       // If the instance doesn't exist, then create.
+                       
+                       if (map.NamespaceDeclarations != null) {
+                               if (!GenerateReadMemberHook (xmlMapType, map.NamespaceDeclarations)) {
+                                       string nss = ob + ".@" + map.NamespaceDeclarations.Name;
+                                       WriteLine ("if (" + nss + " == null) " + nss + " = new XmlSerializerNamespaces ();");
+                                       WriteLineInd ("if (Reader.Prefix == \"xmlns\")");
+                                       WriteLine (nss + ".Add (Reader.LocalName, Reader.Value);");
+                                       Unindent ();
+                                       WriteLineInd ("else");
+                                       WriteLine (nss + ".Add (\"\", Reader.Value);");
+                                       Unindent ();
+                                       GenerateEndHook ();
+                               }
+                       }
+                       
+                       WriteLineUni ("}");
+                       WriteLineInd ("else {");
+
+                       if (anyAttrMember != null) 
+                       {
+                               if (!GenerateReadArrayMemberHook (xmlMapType, anyAttrMember, "anyAttributeIndex")) {
+                                       WriteLine ("System.Xml.XmlAttribute attr = (System.Xml.XmlAttribute) Document.ReadNode(Reader);");
+                                       if (typeof(System.Xml.Schema.XmlSchemaAnnotated).IsAssignableFrom (xmlMapType)) 
+                                               WriteLine ("ParseWsdlArrayType (attr);");
+                                       GenerateAddListValue (anyAttrMember.TypeData, "anyAttributeArray", "anyAttributeIndex", GetCast (anyAttrMember.TypeData.ListItemTypeData, "attr"), true);
+                                       GenerateEndHook ();
+                               }
+                               WriteLine ("anyAttributeIndex++;");
+                       }
+                       else {
+                               if (!GenerateReadHook (HookType.unknownAttribute, xmlMapType)) {
+                                       WriteLine ("UnknownNode (" + ob + ");");
+                                       GenerateEndHook ();
+                               }
+                       }
+
+                       WriteLineUni ("}");
+                       WriteLineUni ("}");
+
+                       if (anyAttrMember != null && !MemberHasReadReplaceHook (xmlMapType, anyAttrMember))
+                       {
+                               WriteLine ("");
+                               WriteLine("anyAttributeArray = (" + anyAttrMember.TypeData.CSharpFullName + ") ShrinkArray (anyAttributeArray, anyAttributeIndex, " + GetTypeOf(anyAttrMember.TypeData.Type.GetElementType()) + ", true);");
+                               GenerateSetMemberValue (anyAttrMember, ob, "anyAttributeArray", isValueList);
+                       }
+                       WriteLine ("");
+                       WriteLine ("Reader.MoveToElement ();");
+
+                       GenerateEndHook ();
+               }
                
                void GenerateSetListMembersDefaults (XmlTypeMapping typeMap, ClassMap map, string ob, bool isValueList)
                {
@@ -2085,7 +2140,7 @@ namespace System.Xml.Serialization
                                        return GetReadObjectCall (elem.MappedType, GetLiteral(elem.IsNullable), "true");
 
                                case SchemaTypes.XmlSerializable:
-                                       return GetCast (elem.TypeData, "ReadSerializable (new " + elem.TypeData.CSharpFullName + " ())");
+                                       return GetCast (elem.TypeData, String.Format ("({0}) ReadSerializable (({0}) Activator.CreateInstance(typeof({0}), true))", elem.TypeData.CSharpFullName));
 
                                default:
                                        throw new NotSupportedException ("Invalid value type");
@@ -2098,18 +2153,24 @@ namespace System.Xml.Serialization
                                if (elem.IsNullable) return "ReadNullableQualifiedName ()";
                                else return "ReadElementQualifiedName ()";
                        }
-                       else if (elem.IsNullable)
-                               return GenerateGetValueFromXmlString ("ReadNullableString ()", elem.TypeData, elem.MappedType);
-                       else
-                               return GenerateGetValueFromXmlString ("Reader.ReadElementString ()", elem.TypeData, elem.MappedType);
+                       else if (elem.IsNullable) {
+                               string str = GetStrTempVar ();
+                               WriteLine ("string " + str + " = ReadNullableString ();");
+                               return GenerateGetValueFromXmlString (str, elem.TypeData, elem.MappedType, true);
+                       }
+                       else {
+                               string str = GetStrTempVar ();
+                               WriteLine ("string " + str + " = Reader.ReadElementString ();");
+                               return GenerateGetValueFromXmlString (str, elem.TypeData, elem.MappedType, false);
+                       }
                }
                
-               string GenerateGetValueFromXmlString (string value, TypeData typeData, XmlTypeMapping typeMap)
+               string GenerateGetValueFromXmlString (string value, TypeData typeData, XmlTypeMapping typeMap, bool isNullable)
                {
                        if (typeData.SchemaType == SchemaTypes.Array)
                                return GenerateReadListString (typeMap, value);
                        else if (typeData.SchemaType == SchemaTypes.Enum)
-                               return GenerateGetEnumValue (typeMap, value);
+                               return GenerateGetEnumValue (typeMap, value, isNullable);
                        else if (typeData.Type == typeof (XmlQualifiedName))
                                return "ToXmlQualifiedName (" + value + ")";
                        else 
@@ -2220,7 +2281,7 @@ namespace System.Xml.Serialization
 
                        string index = GetNumTempVar ();
                        WriteLineInd ("for (int " + index + " = 0; " + index + " < " + valueArray + ".Length; " + index + "++)");
-                       WriteLine (list + "[" + index + "] = " + GenerateGetValueFromXmlString (valueArray + "[" + index + "]", info.TypeData, info.MappedType) + ";");
+                       WriteLine (list + "[" + index + "] = " + GenerateGetValueFromXmlString (valueArray + "[" + index + "]", info.TypeData, info.MappedType, info.IsNullable) + ";");
                        Unindent ();
                        WriteLineUni ("}");
                        WriteLine ("else");
@@ -2254,7 +2315,7 @@ namespace System.Xml.Serialization
                        {
                                WriteLine ("if (((object)" + list + ") == null)");
                                if (canCreateInstance) 
-                                       WriteLine ("\t" + list + " = new " + listType.CSharpFullName + "();");
+                                       WriteLine ("\t" + list + String.Format (" = ({0}) Activator.CreateInstance(typeof({0}), true);", listType.CSharpFullName));
                                else 
                                        WriteLine ("\tthrow CreateReadOnlyCollectionException (" + GetLiteral (listType.CSharpFullName) + ");");
                                
@@ -2311,18 +2372,21 @@ namespace System.Xml.Serialization
                void GenerateReadEnumElement (XmlTypeMapping typeMap, string isNullable)
                {
                        WriteLine ("Reader.ReadStartElement ();");
-                       WriteLine (typeMap.TypeData.CSharpFullName + " res = " + GenerateGetEnumValue (typeMap, "Reader.ReadString()") + ";");
+                       WriteLine (typeMap.TypeData.CSharpFullName + " res = " + GenerateGetEnumValue (typeMap, "Reader.ReadString()", false) + ";");
                        WriteLineInd ("if (Reader.NodeType != XmlNodeType.None)");
                        WriteLineUni ("Reader.ReadEndElement ();");
                        WriteLine ("return res;");
                }
 
-               string GenerateGetEnumValue (XmlTypeMapping typeMap, string val)
+               string GenerateGetEnumValue (XmlTypeMapping typeMap, string val, bool isNullable)
                {
-                       return GetGetEnumValueName (typeMap) + " (" + val + ")";
+                       if (isNullable)
+                               return "(" + val + ") != null ? " + GetGetEnumValueName (typeMap) + " (" + val + ") : (" + typeMap.TypeData.CSharpFullName + "?) null";
+                       else
+                               return GetGetEnumValueName (typeMap) + " (" + val + ")";
                }
                
-               void GenerateGetEnumValue (XmlTypeMapping typeMap)
+               void GenerateGetEnumValueMethod (XmlTypeMapping typeMap)
                {
                        string metName = GetGetEnumValueName (typeMap);
                        EnumMap map = (EnumMap) typeMap.ObjectMap;
@@ -2361,7 +2425,7 @@ namespace System.Xml.Serialization
                        WriteLineInd ("{");
                        foreach (EnumMap.EnumMapMember mem in map.Members)
                        {
-                               WriteLine ("case " + GetLiteral (mem.XmlName) + ": return " + typeMap.TypeData.CSharpFullName + "." + mem.EnumName + ";");
+                               WriteLine ("case " + GetLiteral (mem.XmlName) + ": return " + typeMap.TypeData.CSharpFullName + ".@" + mem.EnumName + ";");
                        }
                        WriteLineInd ("default:");
                        WriteLine ("throw CreateUnknownConstantException (" + val + ", typeof(" + typeMap.TypeData.CSharpFullName + "));");
@@ -2375,13 +2439,13 @@ namespace System.Xml.Serialization
                        WriteLine ("if (Reader.NodeType == XmlNodeType.Element)");
                        WriteLineInd ("{");
                        WriteLine ("if (Reader.LocalName == " + GetLiteral (typeMap.ElementName) + " && Reader.NamespaceURI == " + GetLiteral (typeMap.Namespace) + ")");
-                       WriteLine ("\treturn ReadSerializable (new " + typeMap.TypeData.CSharpFullName + "());");
+                       WriteLine (String.Format ("\treturn ({0}) ReadSerializable (({0}) Activator.CreateInstance(typeof({0}), true));", typeMap.TypeData.CSharpFullName));
                        WriteLine ("else");
                        WriteLine ("\tthrow CreateUnknownNodeException ();");
                        WriteLineUni ("}");
                        WriteLine ("else UnknownNode (null);");
                        WriteLine ("");
-                       WriteLine ("return null;");
+                       WriteLine ("return default (" + typeMap.TypeData.CSharpFullName + ");");
                }
 
                void GenerateReadInitCallbacks ()
@@ -2593,7 +2657,7 @@ namespace System.Xml.Serialization
                
                string GetUniqueName (string uniqueGroup, object ob, string name)
                {
-                       name = name.Replace ("[]","_array");
+                       name = CodeIdentifier.MakeValid (name.Replace ("[]","_array"));
                        Hashtable names = (Hashtable) _uniqueNames [uniqueGroup];
                        if (names == null) {
                                names = new Hashtable ();
@@ -2652,7 +2716,7 @@ namespace System.Xml.Serialization
                
                string GetUniqueClassName (string s)
                {
-                       return classNames.AddUnique (s, null);
+                       return classNames.AddUnique (CodeIdentifier.MakeValid (s), null);
                }
                
                string GetReadObjectCall (XmlTypeMapping typeMap, string isNullable, string checkType)
@@ -2699,6 +2763,11 @@ namespace System.Xml.Serialization
                {
                        if (ob == null) return "null";
                        if (ob is string) return "\"" + ob.ToString().Replace("\"","\"\"") + "\"";
+                       if (ob is DateTime) return "new DateTime (" + ((DateTime) ob).Ticks + ")";
+#if NET_2_0
+                       if (ob is DateTimeOffset) return "new DateTimeOffset (" + ((DateTimeOffset) ob).Ticks + ")";
+#endif
+                       if (ob is TimeSpan) return "new TimeSpan (" + ((TimeSpan) ob).Ticks + ")";
                        if (ob is bool) return ((bool)ob) ? "true" : "false";
                        if (ob is XmlQualifiedName) {
                                XmlQualifiedName qn = (XmlQualifiedName)ob;
@@ -2806,7 +2875,9 @@ namespace System.Xml.Serialization
                public string WriterClassName;
                public string WriteMethodName;
                public string Namespace;
+#if NET_2_0            
                public string SerializerClassName;
+#endif         
                public string BaseSerializerClassName;
                public string ImplementationClassName;
        }