Fixed bug #4668 - C# compiler doesn't like decimal in custom attribute values, so...

[mono.git] / mcs / class / System.XML / System.Xml.Serialization / MapCodeGenerator.cs

diff --git a/mcs/class/System.XML/System.Xml.Serialization/MapCodeGenerator.cs b/mcs/class/System.XML/System.Xml.Serialization/MapCodeGenerator.cs
index d80710cfb06f15624b1963a156d7bc6a90e12ae4..9f754c727b7fe4f7a8d924c563def3982b95d861 100644 (file)
--- a/mcs/class/System.XML/System.Xml.Serialization/MapCodeGenerator.cs
+++ b/mcs/class/System.XML/System.Xml.Serialization/MapCodeGenerator.cs
@@ -44,29 +44,38 @@ namespace System.Xml.Serialization {
        internal class MapCodeGenerator {
 
                CodeNamespace codeNamespace;
-               CodeCompileUnit codeCompileUnit;
+//             CodeCompileUnit codeCompileUnit;
                CodeAttributeDeclarationCollection includeMetadata;
-               XmlTypeMapping exportedAnyType = null;
+               XmlTypeMapping exportedAnyType;
                protected bool includeArrayTypes;
+#if NET_2_0            
                CodeDomProvider codeProvider;
+#endif         
                CodeGenerationOptions options;
+               CodeIdentifiers identifiers;
 
                Hashtable exportedMaps = new Hashtable ();
                Hashtable includeMaps = new Hashtable ();
 
                public MapCodeGenerator (CodeNamespace codeNamespace, CodeCompileUnit codeCompileUnit, CodeGenerationOptions options)
                {
-                       this.codeCompileUnit = codeCompileUnit;
+//                     this.codeCompileUnit = codeCompileUnit;
                        this.codeNamespace = codeNamespace;
                        this.options = options;
+                       this.identifiers = new CodeIdentifiers ();
                }
 
                public MapCodeGenerator (CodeNamespace codeNamespace, CodeCompileUnit codeCompileUnit, CodeDomProvider codeProvider, CodeGenerationOptions options, Hashtable mappings)
                {
-                       this.codeCompileUnit = codeCompileUnit;
+//                     this.codeCompileUnit = codeCompileUnit;
                        this.codeNamespace = codeNamespace;
-                       this.codeProvider = codeProvider;
                        this.options = options;
+#if NET_2_0
+                       this.codeProvider = codeProvider;
+                       this.identifiers = new CodeIdentifiers ((codeProvider.LanguageOptions & LanguageOptions.CaseInsensitive) == 0);
+#else
+                       this.identifiers = new CodeIdentifiers ();
+#endif
 //                     this.mappings = mappings;
                }
 
@@ -169,7 +178,7 @@ namespace System.Xml.Serialization {
 
                        if (map.BaseMap != null && map.BaseMap.TypeData.SchemaType != SchemaTypes.XmlNode)
                        {
-                               CodeTypeReference ctr = GetDomType (map.BaseMap.TypeData);
+                               CodeTypeReference ctr = GetDomType (map.BaseMap.TypeData, false);
                                codeClass.BaseTypes.Add (ctr);
                                if (map.BaseMap.IncludeInSchema) {
                                        ExportMapCode (map.BaseMap, false);
@@ -202,9 +211,19 @@ namespace System.Xml.Serialization {
 
                void ExportMembersMapCode (CodeTypeDeclaration codeClass, ClassMap map, string defaultNamespace, XmlTypeMapping baseMap)
                {
+                       ICollection attributes = map.AttributeMembers;
+                       ICollection members = map.ElementMembers;
+
+                       // collect names
+                       if (attributes != null)
+                               foreach (XmlTypeMapMemberAttribute attr in attributes)
+                                       identifiers.AddUnique (attr.Name, attr);
+                       if (members != null)
+                               foreach (XmlTypeMapMemberElement member in members)
+                                       identifiers.AddUnique (member.Name, member);
+
                        // Write attributes
 
-                       ICollection attributes = map.AttributeMembers;
                        if (attributes != null) {
                                foreach (XmlTypeMapMemberAttribute attr in attributes) {
                                        if (baseMap != null && DefinedInBaseMap (baseMap, attr)) continue;
@@ -212,7 +231,7 @@ namespace System.Xml.Serialization {
                                }
                        }
 
-                       ICollection members = map.ElementMembers;
+                       members = map.ElementMembers;
                                
                        if (members != null)
                        {
@@ -261,12 +280,12 @@ namespace System.Xml.Serialization {
 
                CodeTypeMember CreateFieldMember (CodeTypeDeclaration codeClass, TypeData type, string name)
                {
-                       return CreateFieldMember (codeClass, GetDomType (type), name, System.DBNull.Value, null, null);
+                       return CreateFieldMember (codeClass, GetDomType (type, false), name, System.DBNull.Value, null, null);
                }
 
                CodeTypeMember CreateFieldMember (CodeTypeDeclaration codeClass, XmlTypeMapMember member)
                {
-                       return CreateFieldMember (codeClass, GetDomType (member.TypeData), member.Name, member.DefaultValue, member.TypeData, member.Documentation);
+                       return CreateFieldMember (codeClass, GetDomType (member.TypeData, member.RequiresNullable), member.Name, member.DefaultValue, member.TypeData, member.Documentation);
                }
                
                CodeTypeMember CreateFieldMember (CodeTypeDeclaration codeClass, CodeTypeReference type, string name, object defaultValue, TypeData defaultType, string documentation)
@@ -275,7 +294,7 @@ namespace System.Xml.Serialization {
                        CodeTypeMember codeProp = null;
 
                        if ((options & CodeGenerationOptions.GenerateProperties) > 0) {
-                               string field = CodeIdentifier.MakeCamel (name + "Field");
+                               string field = identifiers.AddUnique (CodeIdentifier.MakeCamel (name + "Field"), name);
                                codeField = new CodeMemberField (type, field);
                                codeField.Attributes = MemberAttributes.Private;
                                codeClass.Members.Add (codeField);
@@ -322,7 +341,7 @@ namespace System.Xml.Serialization {
 
                        if (attinfo.TypeData.IsValueType && attinfo.IsOptionalValueType)
                        {
-                               codeField = CreateFieldMember (codeClass, typeof(bool), attinfo.Name + "Specified");
+                               codeField = CreateFieldMember (codeClass, typeof(bool), identifiers.MakeUnique (attinfo.Name + "Specified"));
                                codeField.Attributes = MemberAttributes.Public;
                                GenerateSpecifierMember (codeField);
                        }
@@ -345,7 +364,7 @@ namespace System.Xml.Serialization {
                        
                        if (member.TypeData.IsValueType && member.IsOptionalValueType)
                        {
-                               codeField = CreateFieldMember (codeClass, typeof(bool), member.Name + "Specified");
+                               codeField = CreateFieldMember (codeClass, typeof(bool), identifiers.MakeUnique (member.Name + "Specified"));
                                codeField.Attributes = MemberAttributes.Public;
                                GenerateSpecifierMember (codeField);
                        }
@@ -364,14 +383,15 @@ namespace System.Xml.Serialization {
                        
                        foreach (XmlTypeMapElementInfo einfo in member.ElementInfo)
                        {
-                               if (ExportExtraElementAttributes (attributes, einfo, defaultNamespace, defaultType))
-                                       continue;
-
-                               GenerateElementInfoMember (attributes, member, einfo, defaultType, defaultNamespace, addAlwaysAttr, forceUseMemberName);
                                if (einfo.MappedType != null) {
                                        ExportMapCode (einfo.MappedType, false);
                                        RemoveInclude (einfo.MappedType);
                                }
+
+                               if (ExportExtraElementAttributes (attributes, einfo, defaultNamespace, defaultType))
+                                       continue;
+
+                               GenerateElementInfoMember (attributes, member, einfo, defaultType, defaultNamespace, addAlwaysAttr, forceUseMemberName | addAlwaysAttr);
                        }
 
                        GenerateElementMember (attributes, member);
@@ -612,14 +632,14 @@ namespace System.Xml.Serialization {
                }
 #endif
                
-               CodeTypeReference GetDomType (TypeData data)
+               CodeTypeReference GetDomType (TypeData data, bool requiresNullable)
                {
 #if NET_2_0
-                       if (data.IsValueType && data.IsNullable)
+                       if (data.IsValueType && (data.IsNullable || requiresNullable))
                                return new CodeTypeReference ("System.Nullable", new CodeTypeReference (data.FullTypeName));
 #endif
                        if (data.SchemaType == SchemaTypes.Array)
-                               return new CodeTypeReference (GetDomType (data.ListItemTypeData),1);
+                               return new CodeTypeReference (GetDomType (data.ListItemTypeData, false),1);
                        else
                                return new CodeTypeReference (data.FullTypeName);
                }
@@ -664,15 +684,16 @@ namespace System.Xml.Serialization {
                                        throw new InvalidOperationException ("Type " + typeData.TypeName + " not supported");
 
                                IFormattable defaultValueFormattable = defaultValue as IFormattable;
-                               CodeFieldReferenceExpression fref = new CodeFieldReferenceExpression (new CodeTypeReferenceExpression (GetDomType (typeData)), defaultValueFormattable != null ? defaultValueFormattable.ToString(null, CultureInfo.InvariantCulture) : defaultValue.ToString ());
+                               CodeFieldReferenceExpression fref = new CodeFieldReferenceExpression (new CodeTypeReferenceExpression (GetDomType (typeData, false)), defaultValueFormattable != null ? defaultValueFormattable.ToString(null, CultureInfo.InvariantCulture) : defaultValue.ToString ());
                                CodeAttributeArgument arg = new CodeAttributeArgument (fref);
                                AddCustomAttribute (externalField, "System.ComponentModel.DefaultValue", arg);
-                               internalField.InitExpression = fref;
+                               //internalField.InitExpression = fref;
                        }
                        else
                        {
+                               defaultValue = defaultValue is decimal ? (object) ('"' + ((decimal) defaultValue).ToString (CultureInfo.InvariantCulture) + '"') : defaultValue;
                                AddCustomAttribute (externalField, "System.ComponentModel.DefaultValue", GetArg (defaultValue));
-                               internalField.InitExpression = new CodePrimitiveExpression (defaultValue);
+                               //internalField.InitExpression = new CodePrimitiveExpression (defaultValue);
                        }
                }