Merge pull request #495 from nicolas-raoul/fix-for-issue2907-with-no-formatting-changes
[mono.git] / mcs / class / System / System.Net / WebConnectionStream.cs
index b8f93b305c86b560d0868c4cbc43ac626901c8b2..ff370e9e8ba78d1e6f6275a49b9f6cb34570def0 100644 (file)
@@ -44,9 +44,10 @@ namespace System.Net
                byte [] readBuffer;
                int readBufferOffset;
                int readBufferSize;
+               int stream_length; // -1 when CL not present
                int contentLength;
                int totalRead;
-               long totalWritten;
+               internal long totalWritten;
                bool nextReadCalled;
                int pendingReads;
                int pendingWrites;
@@ -64,17 +65,26 @@ namespace System.Net
                bool complete_request_written;
                int read_timeout;
                int write_timeout;
+               AsyncCallback cb_wrapper; // Calls to ReadCallbackWrapper or WriteCallbacWrapper
+               internal bool IgnoreIOErrors;
 
                public WebConnectionStream (WebConnection cnc)
                {
+                       if (cnc.Data == null)
+                               throw new InvalidOperationException ("cnc.Data was not initialized");
+                       if (cnc.Data.Headers == null)
+                               throw new InvalidOperationException ("cnc.Data.Headers was not initialized");
+                       if (cnc.Data.request == null)
+                               throw new InvalidOperationException ("cnc.Data.request was not initialized");
                        isRead = true;
+                       cb_wrapper = new AsyncCallback (ReadCallbackWrapper);
                        pending = new ManualResetEvent (true);
                        this.request = cnc.Data.request;
                        read_timeout = request.ReadWriteTimeout;
                        write_timeout = read_timeout;
                        this.cnc = cnc;
                        string contentType = cnc.Data.Headers ["Transfer-Encoding"];
-                       bool chunkedRead = (contentType != null && contentType.ToLower ().IndexOf ("chunked") != -1);
+                       bool chunkedRead = (contentType != null && contentType.IndexOf ("chunked", StringComparison.OrdinalIgnoreCase) != -1);
                        string clength = cnc.Data.Headers ["Content-Length"];
                        if (!chunkedRead && clength != null && clength != "") {
                                try {
@@ -88,6 +98,10 @@ namespace System.Net
                        } else {
                                contentLength = Int32.MaxValue;
                        }
+
+                       // Negative numbers?
+                       if (!Int32.TryParse (clength, out stream_length))
+                               stream_length = -1;
                }
 
                public WebConnectionStream (WebConnection cnc, HttpWebRequest request)
@@ -95,6 +109,7 @@ namespace System.Net
                        read_timeout = request.ReadWriteTimeout;
                        write_timeout = read_timeout;
                        isRead = false;
+                       cb_wrapper = new AsyncCallback (WriteCallbackWrapper);
                        this.cnc = cnc;
                        this.request = request;
                        allowBuffering = request.InternalAllowBuffering;
@@ -110,7 +125,7 @@ namespace System.Net
                        bool isProxy = (request.Proxy != null && !request.Proxy.IsBypassed (request.Address));
                        string header_name = (isProxy) ? "Proxy-Authenticate" : "WWW-Authenticate";
                        string authHeader = cnc.Data.Headers [header_name];
-                       return (authHeader != null && authHeader.IndexOf ("NTLM") != -1);
+                       return (authHeader != null && authHeader.IndexOf ("NTLM", StringComparison.Ordinal) != -1);
                }
 
                internal void CheckResponseInBuffer ()
@@ -128,16 +143,11 @@ namespace System.Net
                internal WebConnection Connection {
                        get { return cnc; }
                }
-#if NET_2_0
                public override bool CanTimeout {
                        get { return true; }
                }
-#endif
 
-#if NET_2_0
-               public override
-#endif
-               int ReadTimeout {
+               public override int ReadTimeout {
                        get {
                                return read_timeout;
                        }
@@ -149,10 +159,7 @@ namespace System.Net
                        }
                }
 
-#if NET_2_0
-               public override
-#endif
-               int WriteTimeout {
+               public override int WriteTimeout {
                        get {
                                return write_timeout;
                        }
@@ -289,7 +296,10 @@ namespace System.Net
                                result.InnerAsyncResult = r;
                                result.DoCallback ();
                        } else {
-                               EndWrite (r);
+                               try {
+                                       EndWrite (r);
+                               } catch {
+                               }
                        }
                }
 
@@ -301,19 +311,16 @@ namespace System.Net
                                result.InnerAsyncResult = r;
                                result.DoCallback ();
                        } else {
-                               EndRead (r);
+                               try {
+                                       EndRead (r);
+                               } catch {
+                               }
                        }
                }
 
                public override int Read (byte [] buffer, int offset, int size)
                {
-                       if (!isRead)
-                               throw new NotSupportedException ("this stream does not allow reading");
-
-                       if (totalRead >= contentLength)
-                               return 0;
-
-                       AsyncCallback cb = new AsyncCallback (ReadCallbackWrapper);
+                       AsyncCallback cb = cb_wrapper;
                        WebAsyncResult res = (WebAsyncResult) BeginRead (buffer, offset, size, cb, null);
                        if (!res.IsCompleted && !res.WaitUntilComplete (ReadTimeout, false)) {
                                nextReadCalled = true;
@@ -334,8 +341,10 @@ namespace System.Net
                                throw new ArgumentNullException ("buffer");
 
                        int length = buffer.Length;
-                       if (size < 0 || offset < 0 || length < offset || length - offset < size)
-                               throw new ArgumentOutOfRangeException ();
+                       if (offset < 0 || length < offset)
+                               throw new ArgumentOutOfRangeException ("offset");
+                       if (size < 0 || (length - offset) < size)
+                               throw new ArgumentOutOfRangeException ("size");
 
                        lock (locker) {
                                pendingReads++;
@@ -366,7 +375,7 @@ namespace System.Net
                        }
 
                        if (cb != null)
-                               cb = new AsyncCallback (ReadCallbackWrapper);
+                               cb = cb_wrapper;
 
                        if (contentLength != Int32.MaxValue && contentLength - totalRead < size)
                                size = contentLength - totalRead;
@@ -404,6 +413,7 @@ namespace System.Net
                                        nextReadCalled = true;
                                        cnc.Close (true);
                                        result.SetCompleted (false, exc);
+                                       result.DoCallback ();
                                        throw;
                                }
 
@@ -467,8 +477,10 @@ namespace System.Net
                                throw new ArgumentNullException ("buffer");
 
                        int length = buffer.Length;
-                       if (size < 0 || offset < 0 || length < offset || length - offset < size)
-                               throw new ArgumentOutOfRangeException ();
+                       if (offset < 0 || length < offset)
+                               throw new ArgumentOutOfRangeException ("offset");
+                       if (size < 0 || (length - offset) < size)
+                               throw new ArgumentOutOfRangeException ("size");
 
                        if (sendChunked) {
                                lock (locker) {
@@ -507,7 +519,7 @@ namespace System.Net
 
                        AsyncCallback callback = null;
                        if (cb != null)
-                               callback = new AsyncCallback (WriteCallbackWrapper);
+                               callback = cb_wrapper;
 
                        if (sendChunked) {
                                WriteRequest ();
@@ -525,7 +537,14 @@ namespace System.Net
                                size = chunkSize;
                        }
 
-                       result.InnerAsyncResult = cnc.BeginWrite (request, buffer, offset, size, callback, result);
+                       try {
+                               result.InnerAsyncResult = cnc.BeginWrite (request, buffer, offset, size, callback, result);
+                       } catch (Exception) {
+                               if (!IgnoreIOErrors)
+                                       throw;
+                               result.SetCompleted (true, 0);
+                               result.DoCallback ();
+                       }
                        totalWritten += size;
                        return result;
                }
@@ -573,11 +592,17 @@ namespace System.Net
                                throw result.Exception;
 
                        try {
-                               cnc.EndWrite (request, result.InnerAsyncResult);
+                               cnc.EndWrite2 (request, result.InnerAsyncResult);
                                result.SetCompleted (false, 0);
+                               result.DoCallback ();
                        } catch (Exception e) {
-                               result.SetCompleted (false, e);
-                               throw;
+                               if (IgnoreIOErrors)
+                                       result.SetCompleted (false, 0);
+                               else
+                                       result.SetCompleted (false, e);
+                               result.DoCallback ();
+                               if (!IgnoreIOErrors)
+                                       throw;
                        } finally {
                                if (sendChunked) {
                                        lock (locker) {
@@ -591,10 +616,7 @@ namespace System.Net
                
                public override void Write (byte [] buffer, int offset, int size)
                {
-                       if (isRead)
-                               throw new NotSupportedException ("This stream does not allow writing");
-
-                       AsyncCallback cb = new AsyncCallback (WriteCallbackWrapper);
+                       AsyncCallback cb = cb_wrapper;
                        WebAsyncResult res = (WebAsyncResult) BeginWrite (buffer, offset, size, cb, null);
                        if (!res.IsCompleted && !res.WaitUntilComplete (WriteTimeout, false)) {
                                KillBuffer ();
@@ -610,25 +632,27 @@ namespace System.Net
                {
                }
 
-               internal void SetHeaders (byte [] buffer, int offset, int size)
+               internal void SetHeaders (byte [] buffer)
                {
                        if (headersSent)
                                return;
 
-                       headers = new byte [size];
-                       Buffer.BlockCopy (buffer, offset, headers, 0, size);
+                       headers = buffer;
                        long cl = request.ContentLength;
                        string method = request.Method;
                        bool no_writestream = (method == "GET" || method == "CONNECT" || method == "HEAD" ||
-                                               method == "TRACE" || method == "DELETE");
-                       if (sendChunked || cl > -1 || no_writestream) {
+                                               method == "TRACE");
+                       bool webdav = (method == "PROPFIND" || method == "PROPPATCH" || method == "MKCOL" ||
+                                      method == "COPY" || method == "MOVE" || method == "LOCK" ||
+                                      method == "UNLOCK");
+                       if (sendChunked || cl > -1 || no_writestream || webdav) {
                                WriteHeaders ();
                                if (!initRead) {
                                        initRead = true;
                                        WebConnection.InitRead (cnc);
                                }
                                if (!sendChunked && cl == 0)
-                                       Close ();
+                                       requestWritten = true;
                        }
                }
 
@@ -641,7 +665,6 @@ namespace System.Net
                        requestWritten = true;
                        byte [] bytes = writeBuffer.GetBuffer ();
                        int length = (int) writeBuffer.Length;
-                       writeBuffer = null;
                        // Headers already written to the stream
                        return (length > 0) ? cnc.BeginWrite (request, bytes, 0, length, cb, state) : null;
                }
@@ -652,8 +675,9 @@ namespace System.Net
                                return;
 
                        headersSent = true;
-                       if (!cnc.Write (request, headers, 0, headers.Length))
-                               throw new WebException ("Error writing request.", null, WebExceptionStatus.SendFailure, null);
+                       string err_msg = null;
+                       if (!cnc.Write (request, headers, 0, headers.Length, ref err_msg))
+                               throw new WebException ("Error writing request: " + err_msg, null, WebExceptionStatus.SendFailure, null);
                }
 
                internal void WriteRequest ()
@@ -661,17 +685,15 @@ namespace System.Net
                        if (requestWritten)
                                return;
 
-                       if (sendChunked) {
-                               requestWritten = true;
+                       requestWritten = true;
+                       if (sendChunked)
                                return;
-                       }
 
                        if (!allowBuffering || writeBuffer == null)
                                return;
 
                        byte [] bytes = writeBuffer.GetBuffer ();
                        int length = (int) writeBuffer.Length;
-                       writeBuffer = null;
                        if (request.ContentLength != -1 && request.ContentLength < length) {
                                nextReadCalled = true;
                                cnc.Close (true);
@@ -679,6 +701,14 @@ namespace System.Net
                                                        WebExceptionStatus.ServerProtocolViolation, null);
                        }
 
+                       if (!headersSent) {
+                               string method = request.Method;
+                               bool no_writestream = (method == "GET" || method == "CONNECT" || method == "HEAD" ||
+                                                       method == "TRACE");
+                               if (!no_writestream)
+                                       request.InternalContentLength = length;
+                               request.SendRequestHeaders (true);
+                       }
                        WriteHeaders ();
                        if (cnc.Data.StatusCode != 0 && cnc.Data.StatusCode != 100)
                                return;
@@ -711,7 +741,8 @@ namespace System.Net
                                disposed = true;
                                pending.WaitOne ();
                                byte [] chunk = Encoding.ASCII.GetBytes ("0\r\n\r\n");
-                               cnc.Write (request, chunk, 0, chunk.Length);
+                               string err_msg = null;
+                               cnc.Write (request, chunk, 0, chunk.Length, ref err_msg);
                                return;
                        }
 
@@ -746,7 +777,8 @@ namespace System.Net
                                throw new WebException ("Request was cancelled.", io, WebExceptionStatus.RequestCanceled);
                        }
 
-                       WriteRequest ();
+                       // Commented out the next line to fix xamarin bug #1512
+                       //WriteRequest ();
                        disposed = true;
                }
 
@@ -770,15 +802,19 @@ namespace System.Net
                }
 
                public override bool CanRead {
-                       get { return isRead; }
+                       get { return !disposed && isRead; }
                }
 
                public override bool CanWrite {
-                       get { return !isRead; }
+                       get { return !disposed && !isRead; }
                }
 
                public override long Length {
-                       get { throw new NotSupportedException (); }
+                       get {
+                               if (!isRead)
+                                       throw new NotSupportedException ();
+                               return stream_length;
+                       }
                }
 
                public override long Position {