using System.Collections.Generic;
using System.Xml;
using Microsoft.Build.Framework;
+using Microsoft.Build.Utilities;
namespace Microsoft.Build.BuildEngine {
public class Target : IEnumerable {
- BatchingImpl batchingImpl;
+ TargetBatchingImpl batchingImpl;
BuildState buildState;
Engine engine;
ImportedProject importedProject;
this.onErrorElements = new List <XmlElement> ();
this.buildState = BuildState.NotStarted;
this.buildTasks = new List <BuildTask> ();
- this.batchingImpl = new BatchingImpl (project, this.targetElement);
+ this.batchingImpl = new TargetBatchingImpl (project, this.targetElement);
+ bool onErrorFound = false;
foreach (XmlNode xn in targetElement.ChildNodes) {
if (xn is XmlElement) {
XmlElement xe = (XmlElement) xn;
if (xe.Name == "OnError") {
onErrorElements.Add (xe);
- continue;
- }
- buildTasks.Add (new BuildTask (xe, this));
+ onErrorFound = true;
+ } else if (onErrorFound)
+ throw new InvalidProjectFileException (
+ "The element <OnError> must be last under element <Target>. Found element <Error> instead.");
+ else
+ buildTasks.Add (new BuildTask (xe, this));
}
}
}
// FIXME: log errors instead of throwing exceptions
internal bool Build ()
{
- bool result = true;
-
+ bool deps;
+ bool result;
+
+ // log that target is being skipped
+ if (!ConditionParser.ParseAndEvaluate (Condition, Project))
+ return true;
+
try {
buildState = BuildState.Started;
+ deps = BuildDependencies (GetDependencies ());
+
+ result = deps ? DoBuild () : false;
- if (DependsOnTargets != String.Empty) {
- Expression dependencies = new Expression ();
- dependencies.Parse (DependsOnTargets);
-
- string[] targetsToBuildFirst = (string[]) dependencies.ConvertTo (Project, typeof (string[]));
- foreach (string target in targetsToBuildFirst) {
- string trimmed = target.Trim ();
- Target t = (Target) project.Targets [trimmed];
- if (t == null)
- throw new InvalidProjectFileException (String.Format ("Target {0} not found.", trimmed));
- if (t.BuildState == BuildState.NotStarted) {
- if (!t.Build ()) {
- result = false;
- break;
- }
-
- }
- if (t.BuildState == BuildState.Started)
- throw new InvalidProjectFileException ("Cycle in target dependencies detected.");
- }
- }
-
- if (result)
- result = DoBuild ();
- } catch (Exception) {
- return false;
- } finally {
buildState = BuildState.Finished;
+ // FIXME: log it
+ } catch (Exception e) {
+ LogError ("Error building target {0}: {1}", Name, e.ToString ());
+ return false;
}
-
+
return result;
}
+
+ List <Target> GetDependencies ()
+ {
+ List <Target> list = new List <Target> ();
+ Target t;
+ string [] targetNames;
+ Expression deps;
+
+ if (DependsOnTargets != String.Empty) {
+ deps = new Expression ();
+ deps.Parse (DependsOnTargets, true);
+ targetNames = (string []) deps.ConvertTo (Project, typeof (string []));
+ foreach (string name in targetNames) {
+ t = project.Targets [name.Trim ()];
+ if (t == null)
+ throw new InvalidProjectFileException (String.Format ("Target '{0}' not found.", name.Trim ()));
+ list.Add (t);
+ }
+ }
+ return list;
+ }
+
+ bool BuildDependencies (List <Target> deps)
+ {
+ foreach (Target t in deps) {
+ if (t.BuildState == BuildState.NotStarted)
+ if (!t.Build ())
+ return false;
+ if (t.BuildState == BuildState.Started)
+ throw new InvalidProjectFileException ("Cycle in target dependencies detected");
+ }
+
+ return true;
+ }
bool DoBuild ()
{
- bool executeOnErrors = false;
+ bool executeOnErrors;
bool result = true;
+
+ if (BuildTasks.Count == 0)
+ // nothing to do
+ return true;
- LogTargetStarted ();
-
- if (batchingImpl.BuildNeeded ()) {
- foreach (BuildTask bt in buildTasks) {
- result = batchingImpl.BatchBuildTask (bt);
-
- if (!result && !bt.ContinueOnError) {
- executeOnErrors = true;
- break;
- }
- }
- } else {
- LogTargetSkipped ();
+ try {
+ result = batchingImpl.Build (this, out executeOnErrors);
+ } catch (Exception e) {
+ LogError ("Error building target {0}: {1}", Name, e.ToString ());
+ throw;
}
- LogTargetFinished (result);
-
if (executeOnErrors == true)
ExecuteOnErrors ();
}
}
- void LogTargetSkipped ()
- {
- BuildMessageEventArgs bmea;
- bmea = new BuildMessageEventArgs (String.Format ("Skipping target \"{0}\" because its outputs are up-to-date.",
- name), null, "MSBuild", MessageImportance.Normal);
- engine.EventSource.FireMessageRaised (this, bmea);
- }
-
- void LogTargetStarted ()
- {
- TargetStartedEventArgs tsea;
- string projectFile = project.FullFileName;
- tsea = new TargetStartedEventArgs ("Target " + name + " started.", null, name, projectFile, null);
- engine.EventSource.FireTargetStarted (this, tsea);
- }
-
- void LogTargetFinished (bool succeeded)
+ void LogError (string message, params object [] messageArgs)
{
- TargetFinishedEventArgs tfea;
- string projectFile = project.FullFileName;
- tfea = new TargetFinishedEventArgs ("Target " + name + " finished.", null, name, projectFile, null, succeeded);
- engine.EventSource.FireTargetFinished (this, tfea);
+ if (message == null)
+ throw new ArgumentException ("message");
+
+ BuildErrorEventArgs beea = new BuildErrorEventArgs (
+ null, null, null, 0, 0, 0, 0, String.Format (message, messageArgs),
+ null, null);
+ engine.EventSource.FireErrorRaised (this, beea);
}
public string Condition {
internal Project Project {
get { return project; }
}
+
+ internal List<BuildTask> BuildTasks {
+ get { return buildTasks; }
+ }
+
+ internal Engine Engine {
+ get { return engine; }
+ }
internal BuildState BuildState {
get { return buildState; }
}
+
+ internal ITaskItem [] Outputs {
+ get {
+ string outputs = targetElement.GetAttribute ("Outputs");
+ if (outputs == String.Empty)
+ return new ITaskItem [0];
+
+ Expression e = new Expression ();
+ e.Parse (outputs, true);
+
+ return (ITaskItem []) e.ConvertTo (project, typeof (ITaskItem []));
+ }
+ }
}
internal enum BuildState {
projects / mono.git / blobdiff