Merge pull request #819 from brendanzagaeski/patch-1
[mono.git] / mcs / mcs / membercache.cs
1 //
2 // membercache.cs: A container for all member lookups
3 //
4 // Author: Miguel de Icaza (miguel@gnu.org)
5 //         Marek Safar (marek.safar@gmail.com)
6 //
7 // Dual licensed under the terms of the MIT X11 or GNU GPL
8 //
9 // Copyright 2001 Ximian, Inc (http://www.ximian.com)
10 // Copyright 2004-2010 Novell, Inc
11 // Copyright 2011 Xamarin Inc
12 //
13 //
14
15 using System;
16 using System.Collections.Generic;
17
18 namespace Mono.CSharp {
19
20         [Flags]
21         public enum MemberKind
22         {
23                 Constructor = 1,
24                 Event = 1 << 1,
25                 Field = 1 << 2,
26                 Method = 1 << 3,
27                 Property = 1 << 4,
28                 Indexer = 1 << 5,
29                 Operator = 1 << 6,
30                 Destructor      = 1 << 7,
31
32                 Class           = 1 << 11,
33                 Struct          = 1 << 12,
34                 Delegate        = 1 << 13,
35                 Enum            = 1 << 14,
36                 Interface       = 1 << 15,
37                 TypeParameter = 1 << 16,
38
39                 ArrayType = 1 << 19,
40                 PointerType = 1 << 20,
41                 InternalCompilerType = 1 << 21,
42                 MissingType = 1 << 22,
43                 Void = 1 << 23,
44                 Namespace = 1 << 24,
45
46                 NestedMask = Class | Struct | Delegate | Enum | Interface,
47                 GenericMask = Method | Class | Struct | Delegate | Interface,
48                 MaskType = Constructor | Event | Field | Method | Property | Indexer | Operator | Destructor | NestedMask
49         }
50
51         [Flags]
52         public enum BindingRestriction
53         {
54                 None = 0,
55
56                 // Inspect only queried type members
57                 DeclaredOnly = 1 << 1,
58
59                 // Exclude static
60                 InstanceOnly = 1 << 2,
61
62                 NoAccessors = 1 << 3,
63
64                 // Member has to be override
65                 OverrideOnly = 1 << 4
66         }
67
68         public struct MemberFilter : IEquatable<MemberSpec>
69         {
70                 public readonly string Name;
71                 public readonly MemberKind Kind;
72                 public readonly AParametersCollection Parameters;
73                 public readonly TypeSpec MemberType;
74                 public readonly int Arity; // -1 to ignore the check
75
76                 public MemberFilter (MethodSpec m)
77                 {
78                         Name = m.Name;
79                         Kind = MemberKind.Method;
80                         Parameters = m.Parameters;
81                         MemberType = m.ReturnType;
82                         Arity = m.Arity;
83                 }
84
85                 public MemberFilter (string name, int arity, MemberKind kind, AParametersCollection param, TypeSpec type)
86                 {
87                         Name = name;
88                         Kind = kind;
89                         Parameters = param;
90                         MemberType = type;
91                         this.Arity = arity;
92                 }
93
94                 public static MemberFilter Constructor (AParametersCollection param)
95                 {
96                         return new MemberFilter (Mono.CSharp.Constructor.ConstructorName, 0, MemberKind.Constructor, param, null);
97                 }
98
99                 public static MemberFilter Property (string name, TypeSpec type)
100                 {
101                         return new MemberFilter (name, 0, MemberKind.Property, null, type);
102                 }
103
104                 public static MemberFilter Field (string name, TypeSpec type)
105                 {
106                         return new MemberFilter (name, 0, MemberKind.Field, null, type);
107                 }
108
109                 public static MemberFilter Method (string name, int arity, AParametersCollection param, TypeSpec type)
110                 {
111                         return new MemberFilter (name, arity, MemberKind.Method, param, type);
112                 }
113
114                 #region IEquatable<MemberSpec> Members
115
116                 public bool Equals (MemberSpec other)
117                 {
118                         // Is the member of the correct type ?
119                         // TODO: Isn't this redundant ?
120                         if ((other.Kind & Kind & MemberKind.MaskType) == 0)
121                                 return false;
122
123                         // Check arity when not disabled
124                         if (Arity >= 0 && Arity != other.Arity)
125                                 return false;
126
127                         if (Parameters != null) {
128                                 if (other is IParametersMember) {
129                                         var other_param = ((IParametersMember) other).Parameters;
130                                         if (!TypeSpecComparer.Override.IsEqual (Parameters, other_param))
131                                                 return false;
132                                 } else {
133                                         return false;
134                                 }
135                         }
136
137                         if (MemberType != null) {
138                                 if (other is IInterfaceMemberSpec) {
139                                         var other_type = ((IInterfaceMemberSpec) other).MemberType;
140                                         if (!TypeSpecComparer.Override.IsEqual (other_type, MemberType))
141                                                 return false;
142                                 } else {
143                                         return false;
144                                 }
145                         }
146
147                         return true;
148                 }
149
150                 #endregion
151         }
152
153         //
154         // The MemberCache is the main members container used by compiler. It contains
155         // all members imported or defined during compilation using on demand filling
156         // process. Inflated containers are also using MemberCache to make inflated
157         // members look like normal definition.
158         //
159         // All of the methods are performance and memory sensitive as the MemberCache
160         // is the underlying engine of all member based operations.
161         //
162         public class MemberCache
163         {
164                 [Flags]
165                 enum StateFlags
166                 {
167                         HasConversionOperator = 1 << 1,
168                         HasUserOperator = 1 << 2
169                 }
170
171                 readonly Dictionary<string, IList<MemberSpec>> member_hash;
172                 Dictionary<string, MemberSpec[]> locase_members;
173                 IList<MethodSpec> missing_abstract;
174                 StateFlags state;       // TODO: Move to TypeSpec or ITypeDefinition
175
176                 public static readonly string IndexerNameAlias = "<this>";
177
178                 public static readonly MemberCache Empty = new MemberCache (0);
179
180                 public MemberCache ()
181                         : this (16)
182                 {
183                 }
184
185                 public MemberCache (int capacity)
186                 {
187                         member_hash = new Dictionary<string, IList<MemberSpec>> (capacity);
188                 }
189
190                 public MemberCache (MemberCache cache)
191                         : this (cache.member_hash.Count)
192                 {
193                         this.state = cache.state;
194                 }
195
196                 //
197                 // Creates a new MemberCache for the given `container'.
198                 //
199                 public MemberCache (TypeContainer container)
200                         : this ()                               // TODO: Optimize the size
201                 {
202                 }
203
204                 //
205                 // For cases where we need to union cache members
206                 //
207                 public void AddBaseType (TypeSpec baseType)
208                 {
209                         var cache = baseType.MemberCache;
210
211                         IList<MemberSpec> list;
212                         foreach (var entry in cache.member_hash) {
213                                 if (!member_hash.TryGetValue (entry.Key, out list)) {
214                                         if (entry.Value.Count == 1) {
215                                                 list = entry.Value;
216                                         } else {
217                                                 list = new List<MemberSpec> (entry.Value);
218                                         }
219
220                                         member_hash.Add (entry.Key, list);
221                                         continue;
222                                 }
223
224                                 foreach (var ce in entry.Value) {
225                                         if (list.Contains (ce))
226                                                 continue;
227
228                                         if (list is MemberSpec[]) {
229                                                 list = new List<MemberSpec> { list [0] };
230                                                 member_hash[entry.Key] = list;
231                                         }
232
233                                         list.Add (ce);
234                                 }
235                         }
236                 }
237
238                 //
239                 // Member-cache does not contain base members but it does
240                 // contain all base interface members, so the Lookup code
241                 // can use simple inheritance rules.
242                 //
243                 // Does not work recursively because of generic interfaces
244                 //
245                 public void AddInterface (TypeSpec iface)
246                 {
247                         var cache = iface.MemberCache;
248
249                         IList<MemberSpec> list;
250                         foreach (var entry in cache.member_hash) {
251                                 if (!member_hash.TryGetValue (entry.Key, out list)) {
252                                         if (entry.Value.Count == 1) {
253                                                 list = entry.Value;
254                                         } else {
255                                                 list = new List<MemberSpec> (entry.Value);
256                                         }
257
258                                         member_hash.Add (entry.Key, list);
259                                         continue;
260                                 }
261
262                                 foreach (var ce in entry.Value) {
263                                         //
264                                         // When two or more different base interfaces implemenent common
265                                         // interface
266                                         //
267                                         // I : IA, IFoo
268                                         // IA : IFoo
269                                         //
270                                         if (list.Contains (ce))
271                                                 continue;
272
273                                         if (AddInterfaceMember (ce, ref list))
274                                                 member_hash[entry.Key] = list;
275                                 }
276                         }
277                 }
278
279                 public void AddMember (InterfaceMemberBase imb, string exlicitName, MemberSpec ms)
280                 {
281                         // Explicit names cannot be looked-up but can be used for
282                         // collision checking (no name mangling needed)
283                         if (imb.IsExplicitImpl)
284                                 AddMember (exlicitName, ms, false);
285                         else
286                                 AddMember (ms);
287                 }
288
289                 //
290                 // Add non-explicit member to member cache
291                 //
292                 public void AddMember (MemberSpec ms)
293                 {
294                         AddMember (GetLookupName (ms), ms, false);
295                 }
296
297                 void AddMember (string name, MemberSpec member, bool removeHiddenMembers)
298                 {
299                         if (member.Kind == MemberKind.Operator) {
300                                 var dt = member.DeclaringType;
301
302
303                                 //
304                                 // Some core types have user operators but they cannot be used like normal
305                                 // user operators as they are predefined and therefore having different
306                                 // rules (e.g. binary operators) by not setting the flag we hide them for
307                                 // user conversions
308                                 //
309                                 if (!BuiltinTypeSpec.IsPrimitiveType (dt) || dt.BuiltinType == BuiltinTypeSpec.Type.Char) {
310                                         switch (dt.BuiltinType) {
311                                         case BuiltinTypeSpec.Type.String:
312                                         case BuiltinTypeSpec.Type.Delegate:
313                                         case BuiltinTypeSpec.Type.MulticastDelegate:
314                                                 break;
315                                         default:
316                                                 if (name == Operator.GetMetadataName (Operator.OpType.Implicit) || name == Operator.GetMetadataName (Operator.OpType.Explicit)) {
317                                                         state |= StateFlags.HasConversionOperator;
318                                                 } else {
319                                                         state |= StateFlags.HasUserOperator;
320                                                 }
321
322                                                 break;
323                                         }
324                                 }
325                         }
326
327                         IList<MemberSpec> list;
328                         if (!member_hash.TryGetValue (name, out list)) {
329                                 member_hash.Add (name, new MemberSpec[] { member });
330                                 return;
331                         }
332
333                         if (removeHiddenMembers && member.DeclaringType.IsInterface) {
334                                 if (AddInterfaceMember (member, ref list))
335                                         member_hash[name] = list;
336                         } else {
337                                 if (list.Count == 1) {
338                                         list = new List<MemberSpec> { list[0] };
339                                         member_hash[name] = list;
340                                 }
341
342                                 list.Add (member);
343                         }
344                 }
345
346                 public void AddMemberImported (MemberSpec ms)
347                 {
348                         AddMember (GetLookupName (ms), ms, true);
349                 }
350
351                 //
352                 // Ignores any base interface member which can be hidden
353                 // by this interface
354                 //
355                 static bool AddInterfaceMember (MemberSpec member, ref IList<MemberSpec> existing)
356                 {
357                         var member_param = member is IParametersMember ? ((IParametersMember) member).Parameters : ParametersCompiled.EmptyReadOnlyParameters;
358
359                         //
360                         // interface IA : IB { int Prop { set; } }
361                         // interface IB { bool Prop { get; } }
362                         //
363                         // IB.Prop is never accessible from IA interface
364                         //
365                         for (int i = 0; i < existing.Count; ++i) {
366                                 var entry = existing[i];
367
368                                 if (entry.Arity != member.Arity)
369                                         continue;
370
371                                 if (entry is IParametersMember) {
372                                         var entry_param = ((IParametersMember) entry).Parameters;
373                                         if (!TypeSpecComparer.Override.IsEqual (entry_param, member_param))
374                                                 continue;
375                                 }
376
377                                 if (member.DeclaringType.ImplementsInterface (entry.DeclaringType, false)) {
378                                         if (existing.Count == 1) {
379                                                 existing = new MemberSpec[] { member };
380                                                 return true;
381                                         }
382
383                                         existing.RemoveAt (i--);
384                                         continue;
385                                 }
386
387                                 if ((entry.DeclaringType == member.DeclaringType && entry.IsAccessor == member.IsAccessor) ||
388                                         entry.DeclaringType.ImplementsInterface (member.DeclaringType, false))
389                                         return false;
390                         }
391
392                         if (existing.Count == 1) {
393                                 existing = new List<MemberSpec> { existing[0], member };
394                                 return true;
395                         }
396
397                         existing.Add (member);
398                         return false;
399                 }
400
401                 public static MemberSpec FindMember (TypeSpec container, MemberFilter filter, BindingRestriction restrictions)
402                 {
403                         do {
404                                 IList<MemberSpec> applicable;
405                                 if (container.MemberCache.member_hash.TryGetValue (filter.Name, out applicable)) {
406                                         // Start from the end because interface members are in reverse order
407                                         for (int i = applicable.Count - 1; i >= 0; i--) {
408                                                 var entry = applicable [i];
409
410                                                 if ((restrictions & BindingRestriction.InstanceOnly) != 0 && entry.IsStatic)
411                                                         continue;
412
413                                                 if ((restrictions & BindingRestriction.NoAccessors) != 0 && entry.IsAccessor)
414                                                         continue;
415
416                                                 if ((restrictions & BindingRestriction.OverrideOnly) != 0 && (entry.Modifiers & Modifiers.OVERRIDE) == 0)
417                                                         continue;
418
419                                                 if (!filter.Equals (entry))
420                                                         continue;
421
422                                                 if ((restrictions & BindingRestriction.DeclaredOnly) != 0 && container.IsInterface && entry.DeclaringType != container)
423                                                         continue;
424
425                                                 return entry;
426                                         }
427                                 }
428
429                                 if ((restrictions & BindingRestriction.DeclaredOnly) != 0)
430                                         break;
431
432                                 container = container.BaseType;
433                         } while (container != null);
434
435                         return null;
436                 }
437
438                 //
439                 // A special method to work with member lookup only. It returns a list of all members named @name
440                 // starting from @container. It's very performance sensitive
441                 //
442                 // declaredOnlyClass cannot be used interfaces. Manual filtering is required because names are
443                 // compacted
444                 //
445                 public static IList<MemberSpec> FindMembers (TypeSpec container, string name, bool declaredOnlyClass)
446                 {
447                         IList<MemberSpec> applicable;
448
449                         do {
450                                 if (container.MemberCache.member_hash.TryGetValue (name, out applicable) || declaredOnlyClass)
451                                         return applicable;
452
453                                 container = container.BaseType;
454                         } while (container != null);
455
456                         return null;
457                 }
458
459                 //
460                 // Finds the nested type in container
461                 //
462                 public static TypeSpec FindNestedType (TypeSpec container, string name, int arity)
463                 {
464                         IList<MemberSpec> applicable;
465                         TypeSpec best_match = null;
466                         do {
467 #if !FULL_AOT_RUNTIME
468                                 // TODO: Don't know how to handle this yet
469                                 // When resolving base type of nested type, parent type must have
470                                 // base type resolved to scan full hierarchy correctly
471                                 // Similarly MemberCacheTypes will inflate BaseType and Interfaces
472                                 // based on type definition
473                                 var tc = container.MemberDefinition as TypeContainer;
474                                 if (tc != null)
475                                         tc.DefineContainer ();
476 #endif
477
478                                 if (container.MemberCacheTypes.member_hash.TryGetValue (name, out applicable)) {
479                                         for (int i = applicable.Count - 1; i >= 0; i--) {
480                                                 var entry = applicable[i];
481                                                 if ((entry.Kind & MemberKind.NestedMask) == 0)
482                                                         continue;
483
484                                                 var ts = (TypeSpec) entry;
485                                                 if (arity == ts.Arity)
486                                                         return ts;
487
488                                                 if (arity < 0) {
489                                                         if (best_match == null) {
490                                                                 best_match = ts;
491                                                         } else if (System.Math.Abs (ts.Arity + arity) < System.Math.Abs (ts.Arity + arity)) {
492                                                                 best_match = ts;
493                                                         }
494                                                 }
495                                         }
496                                 }
497
498                                 container = container.BaseType;
499                         } while (container != null);
500
501                         return best_match;
502                 }
503
504                 //
505                 // Looks for extension methods with defined name and extension type
506                 //
507                 public List<MethodSpec> FindExtensionMethods (IMemberContext invocationContext, string name, int arity)
508                 {
509                         IList<MemberSpec> entries;
510                         if (!member_hash.TryGetValue (name, out entries))
511                                 return null;
512
513                         List<MethodSpec> candidates = null;
514                         foreach (var entry in entries) {
515                                 if (entry.Kind != MemberKind.Method || (arity > 0 && entry.Arity != arity))
516                                         continue;
517
518                                 var ms = (MethodSpec) entry;
519                                 if (!ms.IsExtensionMethod)
520                                         continue;
521
522                                 if (!ms.IsAccessible (invocationContext))
523                                         continue;
524
525                                 //
526                                 // Extension methods cannot be nested hence checking parent is enough
527                                 //
528                                 if ((ms.DeclaringType.Modifiers & Modifiers.INTERNAL) != 0 && !ms.DeclaringType.MemberDefinition.IsInternalAsPublic (invocationContext.Module.DeclaringAssembly))
529                                         continue;
530
531                                 if (candidates == null)
532                                         candidates = new List<MethodSpec> ();
533                                 candidates.Add (ms);
534                         }
535
536                         return candidates;
537                 }
538
539                 //
540                 // Returns base members of @member member if no exact match is found @bestCandidate returns
541                 // the best match
542                 //
543                 public static MemberSpec FindBaseMember (MemberCore member, out MemberSpec bestCandidate, ref bool overrides)
544                 {
545                         bestCandidate = null;
546                         var container = member.Parent.PartialContainer.Definition;
547                         if (!container.IsInterface) {
548                                 container = container.BaseType;
549
550                                 // It can happen for a user definition of System.Object
551                                 if (container == null)
552                                         return null;
553                         }
554
555                         string name = GetLookupName (member);
556                         var member_param = member is IParametersMember ? ((IParametersMember) member).Parameters : null;
557
558                         var mkind = GetMemberCoreKind (member);
559                         bool member_with_accessors = mkind == MemberKind.Indexer || mkind == MemberKind.Property;
560
561                         IList<MemberSpec> applicable;
562                         MemberSpec ambig_candidate = null;
563
564                         do {
565                                 if (container.MemberCache.member_hash.TryGetValue (name, out applicable)) {
566                                         for (int i = 0; i < applicable.Count; ++i) {
567                                                 var entry = applicable [i];
568
569                                                 if ((entry.Modifiers & Modifiers.PRIVATE) != 0)
570                                                         continue;
571
572                                                 if ((entry.Modifiers & Modifiers.AccessibilityMask) == Modifiers.INTERNAL &&
573                                                         !entry.DeclaringType.MemberDefinition.IsInternalAsPublic (member.Module.DeclaringAssembly))
574                                                         continue;
575
576                                                 //
577                                                 // Isn't the member of same kind ?
578                                                 //
579                                                 if ((entry.Kind & ~MemberKind.Destructor & mkind & MemberKind.MaskType) == 0) {
580                                                         // Destructors are ignored as they cannot be overridden by user
581                                                         if ((entry.Kind & MemberKind.Destructor) != 0)
582                                                                 continue;
583
584                                                         // A method with different arity does not hide base member
585                                                         if (mkind != MemberKind.Method && member.MemberName.Arity != entry.Arity)
586                                                                 continue;
587
588                                                         bestCandidate = entry;
589                                                         return null;
590                                                 }
591
592                                                 //
593                                                 // Same kind of different arity is valid
594                                                 //
595                                                 if (member.MemberName.Arity != entry.Arity) {
596                                                         continue;
597                                                 }
598
599                                                 if ((entry.Kind & mkind & (MemberKind.Method | MemberKind.Indexer)) != 0) {
600                                                         if (entry.IsAccessor != member is AbstractPropertyEventMethod)
601                                                                 continue;
602
603                                                         var pm = entry as IParametersMember;
604                                                         if (!TypeSpecComparer.Override.IsEqual (pm.Parameters, member_param))
605                                                                 continue;
606                                                 }
607
608                                                 //
609                                                 // Skip override for member with accessors. It may not fully implement the base member
610                                                 // but keep flag we found an implementation in case the base member is abstract
611                                                 //
612                                                 if (member_with_accessors && ((entry.Modifiers & (Modifiers.OVERRIDE | Modifiers.SEALED)) == Modifiers.OVERRIDE)) {
613                                                         //
614                                                         // Set candidate to override implementation to flag we found an implementation
615                                                         //
616                                                         overrides = true;
617                                                         continue;
618                                                 }
619
620                                                 //
621                                                 // For members with parameters we can encounter an ambiguous candidates (they match exactly)
622                                                 // because generic type parameters could be inflated into same types
623                                                 //
624                                                 if (ambig_candidate == null && (entry.Kind & mkind & (MemberKind.Method | MemberKind.Indexer)) != 0) {
625                                                         bestCandidate = null;
626                                                         ambig_candidate = entry;
627                                                         continue;
628                                                 }
629
630                                                 bestCandidate = ambig_candidate;
631                                                 return entry;
632                                         }
633                                 }
634
635                                 if (container.IsInterface || ambig_candidate != null)
636                                         break;
637
638                                 container = container.BaseType;
639                         } while (container != null);
640
641                         return ambig_candidate;
642                 }
643
644                 //
645                 // Returns inflated version of MemberSpec, it works similarly to
646                 // SRE TypeBuilder.GetMethod
647                 //
648                 public static T GetMember<T> (TypeSpec container, T spec) where T : MemberSpec
649                 {
650                         IList<MemberSpec> applicable;
651                         if (container.MemberCache.member_hash.TryGetValue (GetLookupName (spec), out applicable)) {
652                                 for (int i = applicable.Count - 1; i >= 0; i--) {
653                                         var entry = applicable[i];
654                                         if (entry.MemberDefinition == spec.MemberDefinition)
655                                                 return (T) entry;
656                                 }
657                         }
658
659                         throw new InternalErrorException ("Missing member `{0}' on inflated type `{1}'",
660                                 spec.GetSignatureForError (), container.GetSignatureForError ());
661                 }
662
663                 static MemberKind GetMemberCoreKind (MemberCore member)
664                 {
665                         if (member is FieldBase)
666                                 return MemberKind.Field;
667                         if (member is Indexer)
668                                 return MemberKind.Indexer;
669                         if (member is Class)
670                                 return MemberKind.Class;
671                         if (member is Struct)
672                                 return MemberKind.Struct;
673                         if (member is Destructor)
674                                 return MemberKind.Destructor;
675                         if (member is Method)
676                                 return MemberKind.Method;
677                         if (member is Property)
678                                 return MemberKind.Property;
679                         if (member is EventField)
680                                 return MemberKind.Event;
681                         if (member is Interface)
682                                 return MemberKind.Interface;
683                         if (member is EventProperty)
684                                 return MemberKind.Event;
685                         if (member is Delegate)
686                                 return MemberKind.Delegate;
687                         if (member is Enum)
688                                 return MemberKind.Enum;
689
690                         throw new NotImplementedException (member.GetType ().ToString ());
691                 }
692
693                 public static List<FieldSpec> GetAllFieldsForDefiniteAssignment (TypeSpec container)
694                 {
695                         List<FieldSpec> fields = null;
696                         foreach (var entry in container.MemberCache.member_hash) {
697                                 foreach (var name_entry in entry.Value) {
698                                         if (name_entry.Kind != MemberKind.Field)
699                                                 continue;
700
701                                         if ((name_entry.Modifiers & Modifiers.STATIC) != 0)
702                                                 continue;
703
704                                         //
705                                         // Fixed size buffers are not subject to definite assignment checking
706                                         //
707                                         if (name_entry is FixedFieldSpec || name_entry is ConstSpec)
708                                                 continue;
709
710                                         var fs = (FieldSpec) name_entry;
711
712                                         //
713                                         // LAMESPEC: Very bizzare hack, definitive assignment is not done
714                                         // for imported non-public reference fields except array. No idea what the
715                                         // actual csc rule is
716                                         //
717                                         if (!fs.IsPublic && container.MemberDefinition.IsImported && (!fs.MemberType.IsArray && TypeSpec.IsReferenceType (fs.MemberType)))
718                                                 continue;
719
720                                         if (fields == null)
721                                                 fields = new List<FieldSpec> ();
722
723                                         fields.Add (fs);
724                                         break;
725                                 }
726                         }
727
728                         return fields ?? new List<FieldSpec> (0);
729                 }
730
731                 public static IList<MemberSpec> GetCompletitionMembers (IMemberContext ctx, TypeSpec container, string name)
732                 {
733                         var matches = new List<MemberSpec> ();
734                         foreach (var entry in container.MemberCache.member_hash) {
735                                 foreach (var name_entry in entry.Value) {
736                                         if (name_entry.IsAccessor)
737                                                 continue;
738
739                                         if ((name_entry.Kind & (MemberKind.Constructor | MemberKind.Destructor | MemberKind.Operator)) != 0)
740                                                 continue;
741
742                                         if (!name_entry.IsAccessible (ctx))
743                                                 continue;
744
745                                         if (name == null || name_entry.Name.StartsWith (name)) {
746                                                 matches.Add (name_entry);
747                                         }
748                                 }
749                         }
750
751                         return matches;
752                 }
753
754                 //
755                 // Returns members of @iface only, base members are ignored
756                 //
757                 public static List<MethodSpec> GetInterfaceMethods (TypeSpec iface)
758                 {
759                         //
760                         // MemberCache flatten interfaces, therefore in cases like this one
761                         // 
762                         // interface IA : IB {}
763                         // interface IB { void Foo () }
764                         //
765                         // we would return Foo inside IA which is not expected in this case
766                         //
767                         var methods = new List<MethodSpec> ();
768                         foreach (var entry in iface.MemberCache.member_hash.Values) {
769                                 foreach (var name_entry in entry) {
770                                         if (iface == name_entry.DeclaringType) {
771                                                 if (name_entry.Kind == MemberKind.Method) {
772                                                         methods.Add ((MethodSpec) name_entry);
773                                                 }
774                                         }
775                                 }
776                         }
777
778                         return methods;
779                 }
780
781                 //
782                 // Returns all not implememted abstract members inside abstract type
783                 // NOTE: Returned list is shared and must not be modified
784                 //
785                 public static IList<MethodSpec> GetNotImplementedAbstractMethods (TypeSpec type)
786                 {
787                         if (type.MemberCache.missing_abstract != null)
788                                 return type.MemberCache.missing_abstract;
789                                 
790                         var abstract_methods = new List<MethodSpec> ();
791                         List<TypeSpec> hierarchy = null;
792
793                         //
794                         // Stage 1: top-to-bottom scan for abstract members
795                         //
796                         var abstract_type = type;
797                         while (true) {
798                                 foreach (var entry in abstract_type.MemberCache.member_hash) {
799                                         foreach (var name_entry in entry.Value) {
800                                                 if ((name_entry.Modifiers & Modifiers.ABSTRACT) == 0)
801                                                         continue;
802
803                                                 var ms = name_entry as MethodSpec;
804                                                 if (ms == null)
805                                                         continue;
806
807                                                 abstract_methods.Add (ms);
808                                         }
809                                 }
810
811                                 var base_type = abstract_type.BaseType;
812                                 if (!base_type.IsAbstract)
813                                         break;
814
815                                 if (hierarchy == null)
816                                         hierarchy = new List<TypeSpec> ();
817
818                                 hierarchy.Add (abstract_type);
819                                 abstract_type = base_type;
820                         }
821
822                         int not_implemented_count = abstract_methods.Count;
823                         if (not_implemented_count == 0 || hierarchy == null) {
824                                 type.MemberCache.missing_abstract = abstract_methods;
825                                 return type.MemberCache.missing_abstract;
826                         }
827
828                         //
829                         // Stage 2: Remove already implemented methods
830                         //
831                         foreach (var type_up in hierarchy) {
832                                 var members = type_up.MemberCache.member_hash;
833                                 if (members.Count == 0)
834                                         continue;
835
836                                 for (int i = 0; i < abstract_methods.Count; ++i) {
837                                         var candidate = abstract_methods [i];
838                                         if (candidate == null)
839                                                 continue;
840
841                                         IList<MemberSpec> applicable;
842                                         if (!members.TryGetValue (candidate.Name, out applicable))
843                                                 continue;
844
845                                         var filter = new MemberFilter (candidate);
846                                         foreach (var item in applicable) {
847                                                 if ((item.Modifiers & (Modifiers.OVERRIDE | Modifiers.VIRTUAL)) == 0)
848                                                         continue;
849
850                                                 //
851                                                 // Abstract override does not override anything
852                                                 //
853                                                 if ((item.Modifiers & Modifiers.ABSTRACT) != 0)
854                                                         continue;
855
856                                                 if (filter.Equals (item)) {
857                                                         --not_implemented_count;
858                                                         abstract_methods [i] = null;
859                                                         break;
860                                                 }
861                                         }
862                                 }
863                         }
864
865                         if (not_implemented_count == abstract_methods.Count) {
866                                 type.MemberCache.missing_abstract = abstract_methods;
867                                 return type.MemberCache.missing_abstract;
868                         }
869
870                         var not_implemented = new MethodSpec[not_implemented_count];
871                         int counter = 0;
872                         foreach (var m in abstract_methods) {
873                                 if (m == null)
874                                         continue;
875
876                                 not_implemented[counter++] = m;
877                         }
878
879                         type.MemberCache.missing_abstract = not_implemented;
880                         return type.MemberCache.missing_abstract;
881                 }
882
883                 static string GetLookupName (MemberSpec ms)
884                 {
885                         if (ms.Kind == MemberKind.Indexer)
886                                 return IndexerNameAlias;
887
888                         if (ms.Kind == MemberKind.Constructor) {
889                                 if (ms.IsStatic)
890                                         return Constructor.TypeConstructorName;
891
892                                 return Constructor.ConstructorName;
893                         }
894
895                         return ms.Name;
896                 }
897
898                 static string GetLookupName (MemberCore mc)
899                 {
900                         if (mc is Indexer)
901                                 return IndexerNameAlias;
902
903                         if (mc is Constructor)
904                                 return mc.IsStatic ? Constructor.TypeConstructorName : Constructor.ConstructorName;
905
906                         return mc.MemberName.Name;
907                 }
908
909                 //
910                 // Returns all operators declared on container and its base types (until declaredOnly is used)
911                 //
912                 public static IList<MemberSpec> GetUserOperator (TypeSpec container, Operator.OpType op, bool declaredOnly)
913                 {
914                         IList<MemberSpec> found = null;
915                         bool shared_list = true;
916                         IList<MemberSpec> applicable;
917                         do {
918                                 var mc = container.MemberCache;
919
920                                 if (((op == Operator.OpType.Implicit || op == Operator.OpType.Explicit) && (mc.state & StateFlags.HasConversionOperator) != 0) ||
921                                          (mc.state & StateFlags.HasUserOperator) != 0) {
922
923                                         if (mc.member_hash.TryGetValue (Operator.GetMetadataName (op), out applicable)) {
924                                                 int i;
925                                                 for (i = 0; i < applicable.Count; ++i) {
926                                                         if (applicable[i].Kind != MemberKind.Operator) {
927                                                                 break;
928                                                         }
929                                                 }
930
931                                                 //
932                                                 // Handles very rare case where a method with same name as operator (op_xxxx) exists
933                                                 // and we have to resize the applicable list
934                                                 //
935                                                 if (i != applicable.Count) {
936                                                         for (i = 0; i < applicable.Count; ++i) {
937                                                                 if (applicable[i].Kind != MemberKind.Operator) {
938                                                                         continue;
939                                                                 }
940
941                                                                 if (found == null) {
942                                                                         found = new List<MemberSpec> ();
943                                                                         found.Add (applicable[i]);
944                                                                 } else {
945                                                                         List<MemberSpec> prev;
946                                                                         if (shared_list) {
947                                                                                 shared_list = false;
948                                                                                 prev = new List<MemberSpec> (found.Count + 1);
949                                                                                 prev.AddRange (found);
950                                                                         } else {
951                                                                                 prev = (List<MemberSpec>) found;
952                                                                         }
953
954                                                                         prev.Add (applicable[i]);
955                                                                 }
956                                                         }
957                                                 } else {
958                                                         if (found == null) {
959                                                                 found = applicable;
960                                                                 shared_list = true;
961                                                         } else {
962                                                                 List<MemberSpec> merged;
963                                                                 if (shared_list) {
964                                                                         shared_list = false;
965                                                                         merged = new List<MemberSpec> (found.Count + applicable.Count);
966                                                                         merged.AddRange (found);
967                                                                         found = merged;
968                                                                 } else {
969                                                                         merged = (List<MemberSpec>) found;
970                                                                 }
971
972                                                                 merged.AddRange (applicable);
973                                                         }
974                                                 }
975                                         }
976                                 }
977
978                                 // BaseType call can be expensive
979                                 if (declaredOnly)
980                                         break;
981
982                                 container = container.BaseType;
983                         } while (container != null);
984
985                         return found;
986                 }
987
988                 //
989                 // Inflates all member cache nested types
990                 //
991                 public void InflateTypes (MemberCache inflated_cache, TypeParameterInflator inflator)
992                 {
993                         foreach (var item in member_hash) {
994                                 IList<MemberSpec> inflated_members = null;
995                                 for (int i = 0; i < item.Value.Count; ++i ) {
996                                         var member = item.Value[i];
997
998                                         // FIXME: When inflating members refering nested types before they are inflated
999                                         if (member == null)
1000                                                 continue;
1001
1002                                         if ((member.Kind & MemberKind.NestedMask) != 0 &&
1003                                                 (member.Modifiers & Modifiers.COMPILER_GENERATED) == 0) {
1004                                                 if (inflated_members == null) {
1005                                                         inflated_members = new MemberSpec[item.Value.Count];
1006                                                         inflated_cache.member_hash.Add (item.Key, inflated_members);
1007                                                 }
1008
1009                                                 inflated_members [i] = member.InflateMember (inflator);
1010                                         }
1011                                 }
1012                         }
1013                 }
1014
1015                 //
1016                 // Inflates all open type members, requires InflateTypes to be called before
1017                 //
1018                 public void InflateMembers (MemberCache cacheToInflate, TypeSpec inflatedType, TypeParameterInflator inflator)
1019                 {
1020                         var inflated_member_hash = cacheToInflate.member_hash;
1021                         Dictionary<MemberSpec, MethodSpec> accessor_relation = null;
1022                         List<MemberSpec> accessor_members = null;
1023
1024                         // Copy member specific flags when all members were added
1025                         cacheToInflate.state = state;
1026
1027                         foreach (var item in member_hash) {
1028                                 var members = item.Value;
1029                                 IList<MemberSpec> inflated_members = null;
1030                                 for (int i = 0; i < members.Count; ++i ) {
1031                                         var member = members[i];
1032
1033                                         //
1034                                         // All nested types have been inflated earlier except for
1035                                         // compiler types which are created later and could miss InflateTypes
1036                                         //
1037                                         if ((member.Kind & MemberKind.NestedMask) != 0 &&
1038                                                 (member.Modifiers & Modifiers.COMPILER_GENERATED) == 0) {
1039                                                 if (inflated_members == null)
1040                                                         inflated_members = inflated_member_hash[item.Key];
1041
1042                                                 continue;
1043                                         }
1044
1045                                         //
1046                                         // Clone the container first
1047                                         //
1048                                         if (inflated_members == null) {
1049                                                 inflated_members = new MemberSpec [item.Value.Count];
1050                                                 inflated_member_hash.Add (item.Key, inflated_members);
1051                                         }
1052
1053                                         var local_inflator = inflator;
1054
1055                                         if (member.DeclaringType != inflatedType) {
1056                                                 //
1057                                                 // Don't inflate top-level non-generic interface members
1058                                                 // merged into generic interface
1059                                                 //
1060                                                 if (!member.DeclaringType.IsGeneric && !member.DeclaringType.IsNested) {
1061                                                         inflated_members [i] = member;
1062                                                         continue;
1063                                                 }
1064
1065                                                 //
1066                                                 // Needed when inflating flatten interfaces. It inflates
1067                                                 // container type only, type parameters are already done
1068                                                 //
1069                                                 // Handles cases like:
1070                                                 //
1071                                                 // interface I<T> {}
1072                                                 // interface I<U, V> : I<U> {}
1073                                                 // 
1074                                                 // class C: I<int, bool> {}
1075                                                 //
1076                                                 var inflated_parent = inflator.Inflate (member.DeclaringType);
1077                                                 if (inflated_parent != inflator.TypeInstance)
1078                                                         local_inflator = new TypeParameterInflator (inflator, inflated_parent);
1079                                         }
1080
1081                                         //
1082                                         // Inflate every member, its parent is now different
1083                                         //
1084                                         var inflated = member.InflateMember (local_inflator);
1085                                         inflated_members [i] = inflated;
1086
1087                                         if (member is PropertySpec || member is EventSpec) {
1088                                                 if (accessor_members == null)
1089                                                         accessor_members = new List<MemberSpec> ();
1090
1091                                                 accessor_members.Add (inflated);
1092                                                 continue;
1093                                         }
1094
1095                                         if (member.IsAccessor) {
1096                                                 if (accessor_relation == null)
1097                                                         accessor_relation = new Dictionary<MemberSpec, MethodSpec> ();
1098                                                 accessor_relation.Add (member, (MethodSpec) inflated);
1099                                         }
1100                                 }
1101                         }
1102
1103                         if (accessor_members != null) {
1104                                 foreach (var member in accessor_members) {
1105                                         var prop = member as PropertySpec;
1106                                         if (prop != null) {
1107                                                 if (prop.Get != null)
1108                                                         prop.Get = accessor_relation[prop.Get];
1109                                                 if (prop.Set != null)
1110                                                         prop.Set = accessor_relation[prop.Set];
1111
1112                                                 continue;
1113                                         }
1114
1115                                         var ev = (EventSpec) member;
1116                                         ev.AccessorAdd = accessor_relation[ev.AccessorAdd];
1117                                         ev.AccessorRemove = accessor_relation[ev.AccessorRemove];
1118                                 }
1119                         }
1120                 }
1121
1122                 //
1123                 // Removes hidden base members of an interface. For compiled interfaces we cannot
1124                 // do name filtering during Add (as we do for import) because we need all base
1125                 // names to be valid during type definition.
1126                 // Add replaces hidden base member with current one which means any name collision
1127                 // (CS0108) of non-first name would be unnoticed because the name was replaced
1128                 // with the one from compiled type
1129                 //
1130                 public void RemoveHiddenMembers (TypeSpec container)
1131                 {
1132                         foreach (var entry in member_hash) {
1133                                 var values = entry.Value;
1134
1135                                 int container_members_start_at = 0;
1136                                 while (values[container_members_start_at].DeclaringType != container && ++container_members_start_at < entry.Value.Count);
1137
1138                                 if (container_members_start_at == 0 || container_members_start_at == values.Count)
1139                                         continue;
1140
1141                                 for (int i = 0; i < container_members_start_at; ++i) {
1142                                         var member = values[i];
1143
1144                                         if (!container.ImplementsInterface (member.DeclaringType, false))
1145                                                 continue;
1146
1147                                         var member_param = member is IParametersMember ? ((IParametersMember) member).Parameters : ParametersCompiled.EmptyReadOnlyParameters;
1148
1149                                         for (int ii = container_members_start_at; ii < values.Count; ++ii) {
1150                                                 var container_entry = values[ii];
1151
1152                                                 if (container_entry.Arity != member.Arity)
1153                                                         continue;
1154
1155                                                 if (container_entry is IParametersMember) {
1156                                                         if (!TypeSpecComparer.Override.IsEqual (((IParametersMember) container_entry).Parameters, member_param))
1157                                                                 continue;
1158                                                 }
1159
1160                                                 values.RemoveAt (i);
1161                                                 --container_members_start_at;
1162                                                 --ii;
1163                                                 --i;
1164                                         }
1165                                 }
1166                         }
1167                 }
1168
1169                 //
1170                 // Checks all appropriate container members for CLS compliance
1171                 //
1172                 public void VerifyClsCompliance (TypeSpec container, Report report)
1173                 {
1174                         if (locase_members != null)
1175                                 return;
1176
1177                         if (container.BaseType == null) {
1178                                 locase_members = new Dictionary<string, MemberSpec[]> (member_hash.Count); // StringComparer.OrdinalIgnoreCase);
1179                         } else {
1180                                 var btype = container.BaseType.GetDefinition ();
1181                                 btype.MemberCache.VerifyClsCompliance (btype, report);
1182                                 locase_members = new Dictionary<string, MemberSpec[]> (btype.MemberCache.locase_members); //, StringComparer.OrdinalIgnoreCase);
1183                         }
1184
1185                         var is_imported_type = container.MemberDefinition.IsImported;
1186                         foreach (var entry in container.MemberCache.member_hash) {
1187                                 for (int i = 0; i < entry.Value.Count; ++i ) {
1188                                         var name_entry = entry.Value[i];
1189                                         if ((name_entry.Modifiers & (Modifiers.PUBLIC | Modifiers.PROTECTED)) == 0)
1190                                                 continue;
1191
1192                                         if ((name_entry.Modifiers & (Modifiers.OVERRIDE | Modifiers.COMPILER_GENERATED)) != 0)
1193                                                 continue;
1194
1195                                         if ((name_entry.Kind & MemberKind.MaskType) == 0)
1196                                                 continue;
1197
1198                                         if (name_entry.MemberDefinition.CLSAttributeValue == false)
1199                                             continue;
1200
1201                                         IParametersMember p_a = null;
1202                                         if (!is_imported_type) {
1203                                                 p_a = name_entry as IParametersMember;
1204                                                 if (p_a != null && !name_entry.IsAccessor) {
1205                                                         var p_a_pd = p_a.Parameters;
1206                                                         //
1207                                                         // Check differing overloads in @container
1208                                                         //
1209                                                         for (int ii = i + 1; ii < entry.Value.Count; ++ii) {
1210                                                                 var checked_entry = entry.Value[ii];
1211                                                                 IParametersMember p_b = checked_entry as IParametersMember;
1212                                                                 if (p_b == null)
1213                                                                         continue;
1214
1215                                                                 if (p_a_pd.Count != p_b.Parameters.Count)
1216                                                                         continue;
1217
1218                                                                 if (checked_entry.IsAccessor)
1219                                                                         continue;
1220
1221                                                                 var res = ParametersCompiled.IsSameClsSignature (p_a.Parameters, p_b.Parameters);
1222                                                                 if (res != 0) {
1223                                                                         ReportOverloadedMethodClsDifference (name_entry, checked_entry, res, report);
1224                                                                 }
1225                                                         }
1226                                                 }
1227                                         }
1228
1229                                         if (i > 0 || name_entry.Kind == MemberKind.Constructor || name_entry.Kind == MemberKind.Indexer)
1230                                                 continue;
1231
1232                                         var name_entry_locase = name_entry.Name.ToLowerInvariant ();
1233
1234                                         MemberSpec[] found;
1235                                         if (!locase_members.TryGetValue (name_entry_locase, out found)) {
1236                                                 found = new MemberSpec[] { name_entry };
1237                                                 locase_members.Add (name_entry_locase, found);
1238                                         } else {
1239                                                 bool same_names_only = true;
1240                                                 foreach (var f in found) {
1241                                                         if (f.Name == name_entry.Name) {
1242                                                                 if (p_a != null) {
1243                                                                         IParametersMember p_b = f as IParametersMember;
1244                                                                         if (p_b == null)
1245                                                                                 continue;
1246
1247                                                                         if (p_a.Parameters.Count != p_b.Parameters.Count)
1248                                                                                 continue;
1249
1250                                                                         if (f.IsAccessor)
1251                                                                                 continue;
1252
1253                                                                         var res = ParametersCompiled.IsSameClsSignature (p_a.Parameters, p_b.Parameters);
1254                                                                         if (res != 0) {
1255                                                                                 ReportOverloadedMethodClsDifference (f, name_entry, res, report);
1256                                                                         }
1257                                                                 }
1258
1259                                                                 continue;
1260                                                         }
1261
1262                                                         same_names_only = false;
1263                                                         if (!is_imported_type) {
1264                                                                 var last = GetLaterDefinedMember (f, name_entry);
1265                                                                 if (last == f.MemberDefinition) {
1266                                                                         report.SymbolRelatedToPreviousError (name_entry);
1267                                                                 } else {
1268                                                                         report.SymbolRelatedToPreviousError (f);
1269                                                                 }
1270
1271                                                                 report.Warning (3005, 1, last.Location,
1272                                                                         "Identifier `{0}' differing only in case is not CLS-compliant", last.GetSignatureForError ());
1273                                                         }
1274                                                 }
1275
1276                                                 if (!same_names_only) {
1277                                                         Array.Resize (ref found, found.Length + 1);
1278                                                         found[found.Length - 1] = name_entry;
1279                                                         locase_members[name_entry_locase] = found;
1280                                                 }
1281                                         }
1282                                 }
1283                         }
1284                 }
1285
1286                 //
1287                 // Local report helper to issue correctly ordered members stored in hashtable
1288                 //
1289                 static MemberCore GetLaterDefinedMember (MemberSpec a, MemberSpec b)
1290                 {
1291                         var mc_a = a.MemberDefinition as MemberCore;
1292                         var mc_b = b.MemberDefinition as MemberCore;
1293                         if (mc_a == null)
1294                                 return mc_b;
1295
1296                         if (mc_b == null)
1297                                 return mc_a;
1298
1299                         if (a.DeclaringType.MemberDefinition != b.DeclaringType.MemberDefinition)
1300                                 return mc_b;
1301
1302                         if (mc_a.Location.File != mc_a.Location.File)
1303                                 return mc_b;
1304
1305                         return mc_b.Location.Row > mc_a.Location.Row ? mc_b : mc_a;
1306                 }
1307
1308                 static void ReportOverloadedMethodClsDifference (MemberSpec a, MemberSpec b, int res, Report report)
1309                 {
1310                         var last = GetLaterDefinedMember (a, b);
1311                         if (last == a.MemberDefinition) {
1312                                 report.SymbolRelatedToPreviousError (b);
1313                         } else {
1314                                 report.SymbolRelatedToPreviousError (a);
1315                         }
1316
1317                         if ((res & 1) != 0) {
1318                                 report.Warning (3006, 1, last.Location,
1319                                                 "Overloaded method `{0}' differing only in ref or out, or in array rank, is not CLS-compliant",
1320                                                 last.GetSignatureForError ());
1321                         }
1322
1323                         if ((res & 2) != 0) {
1324                                 report.Warning (3007, 1, last.Location,
1325                                         "Overloaded method `{0}' differing only by unnamed array types is not CLS-compliant",
1326                                         last.GetSignatureForError ());
1327                         }
1328                 }
1329
1330                 public bool CheckExistingMembersOverloads (MemberCore member, AParametersCollection parameters)
1331                 {
1332                         var name = GetLookupName (member);
1333                         var imb = member as InterfaceMemberBase;
1334                         if (imb != null && imb.IsExplicitImpl) {
1335                                 name = imb.GetFullName (name);
1336                         }
1337
1338                         return CheckExistingMembersOverloads (member, name, parameters);
1339                 }
1340
1341                 public bool CheckExistingMembersOverloads (MemberCore member, string name, AParametersCollection parameters)
1342                 {
1343                         IList<MemberSpec> entries;
1344                         if (!member_hash.TryGetValue (name, out entries))
1345                                 return false;
1346
1347                         var Report = member.Compiler.Report;
1348
1349                         int method_param_count = parameters.Count;
1350                         for (int i = entries.Count - 1; i >= 0; --i) {
1351                                 var ce = entries[i];
1352                                 var pm = ce as IParametersMember;
1353                                 var pd = pm == null ? ParametersCompiled.EmptyReadOnlyParameters : pm.Parameters;
1354                                 if (pd.Count != method_param_count)
1355                                         continue;
1356
1357                                 if (ce.Arity != member.MemberName.Arity)
1358                                         continue;
1359
1360                                 // Ignore merged interface members
1361                                 if (member.Parent.PartialContainer != ce.DeclaringType.MemberDefinition)
1362                                         continue;
1363
1364                                 var p_types = pd.Types;
1365                                 if (method_param_count > 0) {
1366                                         int ii = method_param_count - 1;
1367                                         TypeSpec type_a, type_b;
1368                                         do {
1369                                                 type_a = parameters.Types [ii];
1370                                                 type_b = p_types [ii];
1371
1372                                                 var a_byref = (pd.FixedParameters[ii].ModFlags & Parameter.Modifier.RefOutMask) != 0;
1373                                                 var b_byref = (parameters.FixedParameters[ii].ModFlags & Parameter.Modifier.RefOutMask) != 0;
1374
1375                                                 if (a_byref != b_byref)
1376                                                         break;
1377
1378                                         } while (TypeSpecComparer.Override.IsEqual (type_a, type_b) && ii-- != 0);
1379
1380                                         if (ii >= 0)
1381                                                 continue;
1382
1383                                         //
1384                                         // Operators can differ in return type only
1385                                         //
1386                                         if (member is Operator && ce.Kind == MemberKind.Operator && ((MethodSpec) ce).ReturnType != ((Operator) member).ReturnType)
1387                                                 continue;
1388
1389                                         //
1390                                         // Report difference in parameter modifiers only
1391                                         //
1392                                         if (pd != null && member is MethodCore) {
1393                                                 ii = method_param_count;
1394                                                 while (ii-- != 0 &&
1395                                                         (parameters.FixedParameters[ii].ModFlags & Parameter.Modifier.ModifierMask) ==
1396                                                         (pd.FixedParameters[ii].ModFlags & Parameter.Modifier.ModifierMask) &&
1397                                                         parameters.ExtensionMethodType == pd.ExtensionMethodType) ;
1398
1399                                                 if (ii >= 0) {
1400                                                         var mc = ce as MethodSpec;
1401                                                         member.Compiler.Report.SymbolRelatedToPreviousError (ce);
1402                                                         if ((member.ModFlags & Modifiers.PARTIAL) != 0 && (mc.Modifiers & Modifiers.PARTIAL) != 0) {
1403                                                                 if (parameters.HasParams || pd.HasParams) {
1404                                                                         Report.Error (758, member.Location,
1405                                                                                 "A partial method declaration and partial method implementation cannot differ on use of `params' modifier");
1406                                                                 } else {
1407                                                                         Report.Error (755, member.Location,
1408                                                                                 "A partial method declaration and partial method implementation must be both an extension method or neither");
1409                                                                 }
1410                                                         } else if (member is Constructor) {
1411                                                                 Report.Error (851, member.Location,
1412                                                                         "Overloaded contructor `{0}' cannot differ on use of parameter modifiers only",
1413                                                                         member.GetSignatureForError ());
1414                                                         } else {
1415                                                                 Report.Error (663, member.Location,
1416                                                                         "Overloaded method `{0}' cannot differ on use of parameter modifiers only",
1417                                                                         member.GetSignatureForError ());
1418                                                         }
1419                                                         return false;
1420                                                 }
1421                                         }
1422                                 }
1423
1424                                 if ((ce.Kind & MemberKind.Method) != 0) {
1425                                         Method method_a = member as Method;
1426                                         Method method_b = ce.MemberDefinition as Method;
1427                                         if (method_a != null && method_b != null && (method_a.ModFlags & method_b.ModFlags & Modifiers.PARTIAL) != 0) {
1428                                                 const Modifiers partial_modifiers = Modifiers.STATIC | Modifiers.UNSAFE;
1429                                                 if (method_a.IsPartialDefinition == method_b.IsPartialImplementation) {
1430                                                         if ((method_a.ModFlags & partial_modifiers) == (method_b.ModFlags & partial_modifiers) ||
1431                                                                 method_a.Parent.IsUnsafe && method_b.Parent.IsUnsafe) {
1432                                                                 if (method_a.IsPartialImplementation) {
1433                                                                         method_a.SetPartialDefinition (method_b);
1434                                                                         if (entries.Count == 1)
1435                                                                                 member_hash.Remove (name);
1436                                                                         else
1437                                                                                 entries.RemoveAt (i);
1438                                                                 } else {
1439                                                                         method_b.SetPartialDefinition (method_a);
1440                                                                         method_a.caching_flags |= MemberCore.Flags.PartialDefinitionExists;
1441                                                                 }
1442                                                                 continue;
1443                                                         }
1444
1445                                                         if (method_a.IsStatic != method_b.IsStatic) {
1446                                                                 Report.SymbolRelatedToPreviousError (ce);
1447                                                                 Report.Error (763, member.Location,
1448                                                                         "A partial method declaration and partial method implementation must be both `static' or neither");
1449                                                         }
1450
1451                                                         if ((method_a.ModFlags & Modifiers.UNSAFE) != (method_b.ModFlags & Modifiers.UNSAFE)) {
1452                                                                 Report.SymbolRelatedToPreviousError (ce);
1453                                                                 Report.Error (764, member.Location,
1454                                                                         "A partial method declaration and partial method implementation must be both `unsafe' or neither");
1455                                                         }
1456
1457                                                         return false;
1458                                                 }
1459
1460                                                 Report.SymbolRelatedToPreviousError (ce);
1461                                                 if (method_a.IsPartialDefinition) {
1462                                                         Report.Error (756, member.Location, "A partial method `{0}' declaration is already defined",
1463                                                                 member.GetSignatureForError ());
1464                                                 }
1465
1466                                                 Report.Error (757, member.Location, "A partial method `{0}' implementation is already defined",
1467                                                         member.GetSignatureForError ());
1468                                                 return false;
1469                                         }
1470
1471                                         Report.SymbolRelatedToPreviousError (ce);
1472
1473                                         bool is_reserved_a = member is AbstractPropertyEventMethod || member is Operator;
1474                                         bool is_reserved_b = ((MethodSpec) ce).IsReservedMethod;
1475
1476                                         if (is_reserved_a || is_reserved_b) {
1477                                                 Report.Error (82, member.Location, "A member `{0}' is already reserved",
1478                                                         is_reserved_a ?
1479                                                         ce.GetSignatureForError () :
1480                                                         member.GetSignatureForError ());
1481                                                 return false;
1482                                         }
1483                                 } else {
1484                                         Report.SymbolRelatedToPreviousError (ce);
1485                                 }
1486
1487                                 if (member is Operator && ce.Kind == MemberKind.Operator) {
1488                                         Report.Error (557, member.Location, "Duplicate user-defined conversion in type `{0}'",
1489                                                 member.Parent.GetSignatureForError ());
1490                                         return false;
1491                                 }
1492
1493                                 Report.Error (111, member.Location,
1494                                         "A member `{0}' is already defined. Rename this member or use different parameter types",
1495                                         member.GetSignatureForError ());
1496                                 return false;
1497                         }
1498
1499                         return true;
1500                 }
1501         }
1502 }