1 2010-06-09 Marek Safar <marek.safar@gmail.com>
3 * typemanager.cs, parameter.cs, dynamic.cs, typespec.cs,
4 expression.cs, ecore.cs, cs-parser.jay: Fully parse composed type
5 specifiers and stop using string in AST.
7 2010-06-07 Marek Safar <marek.safar@gmail.com>
9 * typemanager.cs, eval.cs, iterators.cs, anonymous.cs, expression.cs
10 method.cs, class.cs, delegate.cs, cs-parser.jay, driver.cs, visit.cs
11 enum.cs: Hold location of predefined types.
13 2010-06-07 Marek Safar <marek.safar@gmail.com>
16 * pending.cs: Clone cached list before modifying.
18 2010-06-04 Marek Safar <marek.safar@gmail.com>
20 * convert.cs, typespec.cs, expression.cs: Start using array member
21 kind for better conversion checks.
23 * import.cs, report.cs: Report better error message for runtime
26 2010-06-04 Marek Safar <marek.safar@gmail.com>
28 * membercache.cs, convert.cs, nullable.cs, expression.cs: Optimize
29 user defined conversion probing and simplify user conversion for
30 nullabe types. Fixes #610940.
32 2010-06-03 Marek Safar <marek.safar@gmail.com>
35 * parameter.cs, property.cs, cs-parser.jay: Use independent implicit
36 parameters for explicit event accessors. Anonymous method capturing
37 won't otherwise work for event implicit parameter.
39 2010-06-02 Marek Safar <marek.safar@gmail.com>
42 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs:
43 Ignore overrides for base overload resolution as for non-base
44 expressions and convert the best candidate to closest override
47 2010-06-01 Marek Safar <marek.safar@gmail.com>
50 * generic.cs, convert.cs: Recursively check effective base interface
52 2010-06-01 Marek Safar <marek.safar@gmail.com>
54 * statement.cs: Handle nullable types and type parameters in using
55 statement, avoid boxing value types. Also fixes #571010
57 2010-06-01 Marek Safar <marek.safar@gmail.com>
59 * convert.cs, expression.cs: Emit unbox for underlying nullable
62 2010-05-29 Marek Safar <marek.safar@gmail.com>
65 * expression.cs: Don't use branch optimization for types bigger than
68 2010-05-28 Marek Safar <marek.safar@gmail.com>
71 * import.cs: Check private modifier correctly.
73 2010-05-28 Marek Safar <marek.safar@gmail.com>
76 * ecore.cs: Don't ignore override methods when looking for base
79 2010-05-27 Marek Safar <marek.safar@gmail.com>
81 A fix for bugs #608007, #572540, #566130, #476358
83 * generic.cs, linq.cs, expression.cs, statement.cs, cs-parser.jay:
84 More tricky refactoring of implicit linq blocks.
86 2010-05-25 Marek Safar <marek.safar@gmail.com>
88 * linq.cs, cs-parser.jay: Keep location for all linq clauses.
90 2010-05-25 Marek Safar <marek.safar@gmail.com>
92 * context.cs, expression.cs, cs-parser.jay: Don't store current
93 block in This expression (it's too early for linq blocks).
95 2010-05-21 Marek Safar <marek.safar@gmail.com>
97 * expression.cs: Use constrained prefix more broadly to avoid boxing.
99 2010-05-20 Marek Safar <marek.safar@gmail.com>
101 A fix for bug #591149
102 * nullable.cs: Don't double wrap same expression.
104 2010-05-20 Marek Safar <marek.safar@gmail.com>
106 A fix for bug #569827
107 * anonymous.cs: Any issued error in probing mode means no match.
109 2010-05-20 Marek Safar <marek.safar@gmail.com>
111 * expression.cs: Search for base indexer using the closest match
114 2010-05-20 Marek Safar <marek.safar@gmail.com>
116 A fix for bug #572071
117 * method.cs: Set override constraints using unexpanded interface
120 2010-05-20 Marek Safar <marek.safar@gmail.com>
122 A fix for bug #572071
123 * ecore.cs: Include secondary extension method lookup in probing
126 2010-05-19 Marek Safar <marek.safar@gmail.com>
128 A fix for bug #515801
129 * typespec.cs (MayBecomeEqualGenericTypes): Recursively check
132 2010-05-19 Marek Safar <marek.safar@gmail.com>
134 A fix for bug #515801
135 * pending.cs: Advance counter correctly.
137 2010-05-19 Marek Safar <marek.safar@gmail.com>
139 A fix for bug #480139
140 * method.cs, pending.cs: Indexer override uses base name.
142 2010-05-19 Marek Safar <marek.safar@gmail.com>
144 A fix for bug #424064
145 * generic.cs: Replace original with inflated type parameter on
148 2010-05-19 Marek Safar <marek.safar@gmail.com>
150 A fix for bug #359733
151 * parameter.cs: Extension attribute can be defined in each assembly.
153 2010-05-18 Marek Safar <marek.safar@gmail.com>
155 A fix for bug #446507
156 * method.cs: Only one method can implement an interface.
158 2010-05-18 Marek Safar <marek.safar@gmail.com>
160 A fix for bug #594905
161 * convert.cs, constant.cs, expression.cs, literal.cs, ecore.cs:
162 Typed null can be used as a source for expression methods.
164 2010-05-18 Marek Safar <marek.safar@gmail.com>
166 A fix for bug #606551
167 * namespace.cs: Using directive imports only types and not nested
170 2010-05-17 Marek Safar <marek.safar@gmail.com>
172 * typespec.cs, expression.cs, statement.cs, ecore.cs, complete.cs,
173 delegate.cs: Member instance is resolved after member overload
174 definitely resolves static/instance property of member expression.
175 Fixes #545047, #358848, #456605, #460016, #603299
177 2010-05-12 Marek Safar <marek.safar@gmail.com>
179 A fix for bug #604981
180 * generic.cs, decl.cs, anonymous.cs: Reset more type arguments
181 details for nested anonymous methods stories.
183 2010-05-11 Marek Safar <marek.safar@gmail.com>
185 A fix for bug #604735
186 * namespace.cs: Don't report namespace collision.
188 2010-05-11 Marek Safar <marek.safar@gmail.com>
190 A fix for bug #604748
191 * class.cs, typespec.cs: Search full imported attribute hierarchy
194 2010-05-11 Marek Safar <marek.safar@gmail.com>
196 * namespace.cs: Ignore missing dependencies failure at
199 2010-05-11 Marek Safar <marek.safar@gmail.com>
201 A fix for bug #604640
202 * namespace.cs: Don't resolve using constraints too early.
204 2010-05-11 Marek Safar <marek.safar@gmail.com>
206 A fix for bug #604239
207 * generic.cs: Copy partial type constraints to partial container.
209 2010-05-10 Marek Safar <marek.safar@gmail.com>
211 A fix for bug #557210
212 * import.cs: Relax underlying enum field rules.
214 2010-05-10 Marek Safar <marek.safar@gmail.com>
216 A fix for bug #603476
217 * property.cs: Implement IParametersMember for indexer accessors.
219 2010-05-07 Marek Safar <marek.safar@gmail.com>
221 A fix for bug #601141
222 * class.cs: Update all partial modifiers.
224 2010-05-06 Marek Safar <marek.safar@gmail.com>
226 A fix for bug #601708
227 * method.cs, membercache.cs: Destructors cannot be hidden.
229 2010-05-06 Marek Safar <marek.safar@gmail.com>
231 A fix for bug #602551
232 * class.cs: Resursive reference of type definition is allowed.
234 2010-05-06 Marek Safar <marek.safar@gmail.com>
236 * anonymous.cs: Mutate cached storey instance types too.
238 2010-05-06 Marek Safar <marek.safar@gmail.com>
240 A fix for bug #602443
241 * convert.cs: Explicit enum conversion cannot involve user operators
243 2010-05-05 Miguel de Icaza <miguel@novell.com>
245 * class.cs (TypeContainer.DefineBaseTypes)
246 (TypeContainer.CheckRecursiveDefinition): check for the iface not
247 being null, as we could have failed resolution and crashed;
250 * cs-parser.jay: Productions to catch common mistakes when other
251 punctuation operators are used instead of comma. Fixes 571702
253 2010-05-05 Marek Safar <marek.safar@gmail.com>
255 * anonymous.cs: Mutate correct set of constraints.
257 2010-05-05 Marek Safar <marek.safar@gmail.com>
259 A fix for bug #602842
260 * expression.cs: Resolve all array bound arguments.
262 2010-05-05 Marek Safar <marek.safar@gmail.com>
264 * import.cs: Don't import private fields.
266 2010-04-30 Marek Safar <marek.safar@gmail.com>
268 Partially based on patch by <sami.lamti@gmail.com>
270 * eval.cs, ecore.cs: Fixed eval show methods.
272 2010-04-30 Marek Safar <marek.safar@gmail.com>
274 * generic.cs, delegate.cs: Implement output type inference of
275 methodgroup now when the specification was cleared at least little
278 2010-04-29 Marek Safar <marek.safar@gmail.com>
280 A fix for bug #575611
281 * class.cs: Fix recursive unmanaged recursice sruct check.
283 2010-04-29 Marek Safar <marek.safar@gmail.com>
285 A fix for bug #479776
286 * expression.cs: Implement typeof unbounded nested generic types.
288 2010-04-29 Marek Safar <marek.safar@gmail.com>
290 A fix for bug #474953
291 * class.cs: Fix valid recursive base type definition.
293 2010-04-29 Marek Safar <marek.safar@gmail.com>
295 A fix for bug #421737
296 * convert.cs, expression.cs: A boxing conversion exists from a
297 nullable-type to a reference type, if a boxing conversion exists
298 from the underlying non-nullable-value-type to the reference type.
300 2010-04-29 Marek Safar <marek.safar@gmail.com>
302 A fix for bug #376875
303 * import.cs: Import volatile modifier.
305 2010-04-29 Marek Safar <marek.safar@gmail.com>
307 A fix for bug #372412
308 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
311 2010-04-29 Marek Safar <marek.safar@gmail.com>
313 A fix for bug #568955
314 * statements.cs: Handle recursive scope initializers.
316 2010-04-28 Marek Safar <marek.safar@gmail.com>
318 A fix for bug #566511
319 * anonymous.cs: Always get inflated version of hoisted variable
320 on generic type definition.
322 2010-04-28 Marek Safar <marek.safar@gmail.com>
324 * import.cs, membercache.cs: Relax rules for valid properties.
326 2010-04-28 Marek Safar <marek.safar@gmail.com>
328 * import.cs: Intern arrays used in generic arguments.
330 2010-04-28 Marek Safar <marek.safar@gmail.com>
332 A fix for bug #600398
333 * convert.cs: Actually use effective base type for the comparison.
335 2010-04-28 Marek Safar <marek.safar@gmail.com>
337 A fix for bug #600326
338 * ecore.cs: Pass arity to base member lookup.
340 2010-04-28 Marek Safar <marek.safar@gmail.com>
342 A fix for bug #573385
343 * expression.cs: MemberAccess is of generic type based on right
346 2010-05-28 Marek Safar <marek.safar@gmail.com>
348 * cs-tokenizer.cs: Made tab size configurable.
350 2010-05-27 Marek Safar <marek.safar@gmail.com>
352 * attribute.cs: Ensure Obsolete members are defined before doing
355 2010-05-27 Marek Safar <marek.safar@gmail.com>
357 * visit.cs: Add DOM visitor skeleton.
361 2010-05-27 Marek Safar <marek.safar@gmail.com>
363 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
365 2010-05-27 Marek Safar <marek.safar@gmail.com>
367 * *.cs: Major rewrite of compiler internals to better work with
368 unmodified System.Reflection.Emit. Some of the key changes are
369 - TypeSpec replaces reflection specific System.Type.
370 - All Type(TypeSpec) operations are now done in compiler therefore
371 no dependency on SRE to inflate generic members and types or to
372 query unclosed types.
373 - MemberCache is now the only and full hierarchical topology.
374 - Generic constraints are implemented properly.
375 - And as a bonus compilation is on average 30% faster.
377 2010-04-15 Jb Evain <jbevain@novell.com>
379 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
381 2010-04-12 Marek Safar <marek.safar@gmail.com>
383 * expression.cs, attribute.cs, parameter.cs: More attribute type
386 2010-04-12 Marek Safar <marek.safar@gmail.com>
388 A fix for bug #593342
390 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
391 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
392 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
393 codegen.cs: Add custom attribute encoder to deal with unfinished
394 types and easier corlib bootstrap from its own types.
396 2010-03-26 Marek Safar <marek.safar@gmail.com>
398 * cs-parser.jay: Report invalid constraint types.
400 2010-03-16 Jb Evain <jbevain@novell.com>
402 * Makefile: rename the net_2_1 profile to moonlight.
404 2010-03-11 Marek Safar <marek.safar@gmail.com>
406 * statement.cs, cs-parser.jay: Use correct location for empty
409 2010-03-11 Marek Safar <marek.safar@gmail.com>
411 * cs-parser.jay: Disable Location from expression.
413 * generic.cs: Check constraints for overrides in the parser.
415 2010-03-09 Marek Safar <marek.safar@gmail.com>
417 * cs-parser.jay (GetLocation): Use an expression when available.
419 2010-03-04 Marek Safar <marek.safar@gmail.com>
421 A fix for bug #582579
422 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
424 2010-03-04 Marek Safar <marek.safar@gmail.com>
426 A patch by kornelpal@gmail.com
428 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
429 compiler generated classes sealed by default. Emit and close top
430 level compiler generated classes as well.
432 * support.cs: Use RuntimeHelpers.GetHashCode.
434 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
436 * Makefile: We need to use the internal bootstrapping gmcs for
437 net_2_1_bootstrap too now.
439 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
441 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
443 2010-03-02 Marek Safar <marek.safar@gmail.com>
445 * cs-tokenizer.cs: Missed few locations in previous fix.
447 2010-03-02 Marek Safar <marek.safar@gmail.com>
449 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
450 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
451 Report correct location for operator errors.
453 2010-03-02 Marek Safar <marek.safar@gmail.com>
455 * typemanager.cs (IsDynamicType): Don't check external types when
456 the attribute is not external.
458 2010-02-24 Marek Safar <marek.safar@gmail.com>
460 A fix for bug #582579
461 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
464 2010-02-24 Marek Safar <marek.safar@gmail.com>
466 A fix for bug #581804
467 * ecore.cs: Fixed type comparison.
469 2010-02-08 Miguel de Icaza <miguel@novell.com>
471 * namespace.cs (CompletionGetTypesStartingWith): Do not include
472 private types in the completion results.
474 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
477 2010-02-17 Marek Safar <marek.safar@gmail.com>
479 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
482 2010-02-14 Miguel de Icaza <miguel@novell.com>
484 * eval.cs: Do not do the report printer dance unless the user has
485 set the DescribeTypes feature.
487 2010-02-10 Marek Safar <marek.safar@gmail.com>
489 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
491 2010-02-08 Marek Safar <marek.safar@gmail.com>
493 A fix for bug #577029
494 * anonymous.cs: Fixed TypeBuilder* check.
496 2010-02-06 Miguel de Icaza <miguel@novell.com>
498 * eval.cs (CompileBlock): Also undo if there are problems during
499 semantic analysis, fixes various cases where invalid C# code would
500 be reported, but the internal changes would not be undone.
502 2010-02-03 Miguel de Icaza <miguel@novell.com>
504 * driver.cs: Change the --fatal flag to allow a number to be
505 passed, this ignores the first N fatal errors. Useful to debug
506 errors that do not happen on the first hit.
508 * cs-parser.jay (invocation_expression): accept both the
509 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
510 inside an invocation.
512 * driver.cs: Expose FatalErrors.
514 * eval.cs: Initialize the printer's Fatal property from the
515 Driver's FatalError flag, this allows csharp --fatal to work
518 Add support for calling Describe (typeof (TYPE)) if the expression
521 2010-02-02 Marek Safar <marek.safar@gmail.com>
523 A fix for bug #574991
524 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
527 2010-02-02 Marek Safar <marek.safar@gmail.com>
529 A fix for bug #575986
530 * expression.cs: Don't mutate typeof type definitions.
532 2010-01-28 Marek Safar <marek.safar@gmail.com>
534 * decl.cs: Use only one set of modifiers.
536 2010-01-26 Marek Safar <marek.safar@gmail.com>
538 A fix for bug #573329
539 * eval.cs: Don't disable error reporting completely on silent mode.
541 2010-01-25 Marek Safar <marek.safar@gmail.com>
543 A fix for bug #573312
544 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
545 pointer index of unknown size types greater than 2.
547 2010-01-15 Marek Safar <marek.safar@gmail.com>
549 * *.cs: Use only 1 member kind enum.
551 2010-01-15 Marek Safar <marek.safar@gmail.com>
553 * *.cs: Add event specification.
555 2010-01-14 Marek Safar <marek.safar@gmail.com>
557 * membercache.cs: Extracted from decl.cs.
559 * *.cs: Put more infrastructure in place.
561 2010-01-13 Marek Safar <marek.safar@gmail.com>
563 * *.cs: Add property specification, unused yet.
565 2010-01-13 Marek Safar <marek.safar@gmail.com>
567 * property.cs: Move all property based declarations into a new file.
569 2010-01-13 Marek Safar <marek.safar at gmail.com>
571 * expression.cs (Conditional): Resolve reduced expression.
573 2010-01-13 Marek Safar <marek.safar at gmail.com>
575 * *.cs: Introduced non-generic method specification.
577 2010-01-07 Marek Safar <marek.safar@gmail.com>
579 * method.cs: Move all method based declarations into a new file.
581 2010-01-07 Marek Safar <marek.safar@gmail.com>
583 * *.cs: Extract field specification.
585 2009-12-17 Marek Safar <marek.safar@gmail.com>
587 * field.cs: Extracted from class.cs
589 2009-12-15 Marek Safar <marek.safar@gmail.com>
591 * attribute.cs (GetFixedBuffer): Work on field definition only.
593 2009-12-15 Marek Safar <marek.safar@gmail.com>
595 * *.cs: Clean up NET_4_0 conditional where possible.
597 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
599 support.cs (DynamicType): Assembly property returns the assembly builder.
600 This is required due to how compiler context works in corlib.
602 2009-12-14 Marek Safar <marek.safar@gmail.com>
604 A fix for bug #564376
605 * assign.cs (LocalTemporary): Removed no longer needed special
608 2009-12-11 Marek Safar <marek.safar@gmail.com>
610 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
611 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
612 enum for easier debugging.
614 2009-12-10 Marek Safar <marek.safar@gmail.com>
616 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
619 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
622 2009-12-10 Marek Safar <marek.safar@gmail.com>
624 * cs-parser.jay, statement.cs: Handle parser error in code
627 2009-12-10 Marek Safar <marek.safar@gmail.com>
629 * ecore.cs: Ignore base imported methods when they are already
632 * eval.cs: Handle non-existent keys.
634 * report.cs, driver.cs: Make fatal work with console printer only.
636 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
638 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
640 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
642 * typemanager.cs: Add MakeGenericMethod that checks if the method
643 is really the generic method definition.
645 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
646 to inflate generic methods.
648 2009-12-08 Marek Safar <marek.safar@gmail.com>
650 A fix for bug #561149
651 * anonymous.cs: Use actual type parameters when checking for generic
654 2009-12-08 Marek Safar <marek.safar@gmail.com>
656 A fix for bug #561369
657 * expression.cs (DoNumericPromotion): Fixed typo.
659 2009-12-08 Marek Safar <marek.safar@gmail.com>
661 *.cs: Moving to generics world.
663 cs-parser.jay: Removed current_array_type.
665 2009-12-07 Marek Safar <marek.safar@gmail.com>
667 *.cs: Moving to generics world.
669 2009-12-04 Marek Safar <marek.safar@gmail.com>
671 *.cs: Moving to generics world (day 2).
673 2009-12-03 Marek Safar <marek.safar@gmail.com>
675 *.cs: Moving to generics world.
677 2009-12-02 Marek Safar <marek.safar@gmail.com>
679 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
680 Encode dynamic type attribute for elements where attributes cannot
683 2009-12-01 Marek Safar <marek.safar@gmail.com>
685 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
688 2009-12-01 Marek Safar <marek.safar@gmail.com>
690 A fix for bug #360455
691 * class.cs: Never report a unused warning for generic events to
692 workaround wrong expression type.
694 2009-11-30 Marek Safar <marek.safar@gmail.com>
696 A fix for bug #558305
697 * decl.cs, class.cs: Check partial method definitions using correct
700 2009-11-30 Marek Safar <marek.safar@gmail.com>
702 * argument.cs: Don't cache rarely used dynamic flag.
704 2009-11-27 Marek Safar <marek.safar@gmail.com>
706 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
708 2009-11-27 Marek Safar <marek.safar@gmail.com>
710 * ecore.cs (SimpleName): Removed no longer needed in_transit as
711 Resolve is now non-reentrant (saves ~0.6MB for corlib).
713 2009-11-26 Marek Safar <marek.safar@gmail.com>
715 A fix for bug #545081
716 * decl.cs: Check private nested types of nested types recursively.
718 2009-11-26 Marek Safar <marek.safar@gmail.com>
720 A fix for bug #558305
721 * location.cs: Ignore self referencing #line directive
723 2009-11-26 Marek Safar <marek.safar@gmail.com>
725 A fix for bug #558292
726 * class.cs: Allow single unsafe fixed buffer fields.
728 2009-11-26 Marek Safar <marek.safar@gmail.com>
730 * expression: Optimize few more zero-based operations.
732 2009-11-26 Marek Safar <marek.safar@gmail.com>
734 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
735 avoids boxing of literal values.
737 2009-11-26 Marek Safar <marek.safar@gmail.com>
739 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
740 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
741 codegen.cs: LocatedToken redesing to avoid excessive allocation and
742 boxing (saves ~7MB for corlib). Also fixes presise token location.
744 2009-11-25 Marek Safar <marek.safar@gmail.com>
746 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
749 2009-11-24 Marek Safar <marek.safar@gmail.com>
751 * expression.cs: Lower static array initializer barrier.
753 * support.cs, driver.cs: Share reader buffer.
755 2009-11-23 Marek Safar <marek.safar@gmail.com>
757 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
759 2009-11-23 Marek Safar <marek.safar@gmail.com>
761 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
762 cleanup some obsolete code.
764 2009-11-20 Marek Safar <marek.safar@gmail.com>
766 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
769 2009-11-20 Marek Safar <marek.safar@gmail.com>
771 * *.cs: Resolved expressions are never resolved again, this helps to
772 uncover some not easy to find bugs and improve the performance.
774 2009-11-19 Marek Safar <marek.safar@gmail.com>
776 * *.cs: Made constant expressions fully compatible with any other
779 2009-11-19 Marek Safar <marek.safar@gmail.com>
781 * *.cs: DoResolve is a worker method and has to be protected.
783 2009-11-18 Marek Safar <marek.safar@gmail.com>
785 * *.cs: More context specific handling.
787 2009-11-17 Marek Safar <marek.safar@gmail.com>
789 * *.cs: More context specific handling.
791 2009-11-16 Marek Safar <marek.safar@gmail.com>
793 * dynamic.cs, class.cs: Removed few fixed user types conversions.
795 * symbolwriter.cs: Uses public ILOffset.
797 2009-11-13 Marek Safar <marek.safar@gmail.com>
799 A fix for bug #553650
800 * generic.cs: Another missing TypeToCoreType, still too many to fix.
802 2009-11-13 Marek Safar <marek.safar@gmail.com>
804 A fix for bug #555170
806 * class.cs, delegate.cs, enum.cs: Constants have to be available
807 for parameters resolve.
809 2009-11-12 Marek Safar <marek.safar@gmail.com>
811 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
814 2009-11-12 Marek Safar <marek.safar@gmail.com>
816 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
817 with a statically known candidate set.
819 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
821 * generic.cs: Made type inflation for generic constraint checks
822 recursive. This fixes BGO #553655.
824 2009-11-11 Marek Safar <marek.safar@gmail.com>
826 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
829 2009-11-10 Marek Safar <marek.safar@gmail.com>
831 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
832 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
833 attribute.cs: Add some dynamic error checking.
835 2009-11-07 Marek Safar <marek.safar@gmail.com>
837 A fix for bug #553465
839 * expression.cs: Fixed mixed version of expression tree anonymous
842 2009-11-06 Marek Safar <marek.safar@gmail.com>
844 A fix for bug #553031
846 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
847 expression tree version of anonymous type with members declaration.
849 2009-11-05 Marek Safar <marek.safar@gmail.com>
851 * parameter.cs: Handle nullable parameter default expression.
853 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
854 class.cs, attribute.cs: Check for wrong dynamic arguments.
856 2009-11-05 Marek Safar <marek.safar@gmail.com>
858 * statement.cs: Dynamic statements.
860 2009-11-04 Marek Safar <marek.safar@gmail.com>
862 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
863 Compound assignments over dynamic type.
865 2009-11-03 Marek Safar <marek.safar@gmail.com>
867 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
868 constructor arguments.
870 2009-10-30 Marek Safar <marek.safar@gmail.com>
872 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
873 codegen.cs: Unary mutator on dynamic member access expression.
875 2009-10-29 Marek Safar <marek.safar@gmail.com>
877 A fix for bug #550580
878 * convert.cs: Don't eliminate explicit precission casts.
880 2009-10-28 Marek Safar <marek.safar@gmail.com>
882 A fix for bug #550404
884 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
885 expression.cs, statement.cs, ecore.cs: Quote any nested expression
888 2009-10-27 Marek Safar <marek.safar@gmail.com>
890 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
893 * class.cs: Allow nullable binary user operators.
895 2009-10-26 Marek Safar <marek.safar@gmail.com>
897 * expression.cs: Move binary expression optimization at the end of
900 2009-10-23 Marek Safar <marek.safar@gmail.com>
902 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
903 Separate NullConstant from NullLiteral.
905 2009-10-23 Marek Safar <marek.safar@gmail.com>
907 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
908 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
909 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
910 ModuleContainer. Add common unclosed member check routine.
912 2009-10-22 Marek Safar <marek.safar@gmail.com>
914 * argument.cs: Use literal flag for real literals only.
916 * dynamic.cs: Use correct return type for custom delegates.
918 2009-10-22 Marek Safar <marek.safar@gmail.com>
920 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
923 2009-10-22 Marek Safar <marek.safar@gmail.com>
925 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
927 2009-10-21 Marek Safar <marek.safar@gmail.com>
929 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
932 2009-10-21 Marek Safar <marek.safar@gmail.com>
934 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
937 2009-10-20 Marek Safar <marek.safar@gmail.com>
939 * argument.cs, dynamic.cs, expression.cs: Latest API update.
941 2009-10-19 Marek Safar <marek.safar@gmail.com>
943 * typemanager.cs, expression.cs: Dynamic array initializer.
945 2009-10-16 Marek Safar <marek.safar@gmail.com>
947 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
950 2009-10-16 Marek Safar <marek.safar@gmail.com>
952 A fix for bug #493523, #507067
953 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
954 standard nullable conversion using underlying standard conversion
955 and not full conversion.
957 2009-10-15 Marek Safar <marek.safar@gmail.com>
959 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
960 type in VerifyArgumentsCompat.
962 2009-10-15 Marek Safar <marek.safar@gmail.com>
964 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
965 Reject variable used with type arguments.
967 2009-10-14 Marek Safar <marek.safar@gmail.com>
969 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
970 Implement dynamic expressions assignment.
972 2009-10-14 Marek Safar <marek.safar@gmail.com>
974 * expression.cs: Build underlying expression when resolving unary
977 2009-10-14 Marek Safar <marek.safar@gmail.com>
979 * expression.cs: Emit enum array initializer using binary blob.
981 2009-10-08 Marek Safar <marek.safar@gmail.com>
983 * typemanager.cs, constant.cs: Optimize decimal constants which fit
986 2009-10-07 Marek Safar <marek.safar@gmail.com>
988 * typemanager.cs: Reset object_type.
990 * assign: Made SimpleAssign public.
992 2009-10-06 Marek Safar <marek.safar@gmail.com>
994 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
995 invocation assembly to IsThisOrFriendAssembly.
997 2009-10-05 Marek Safar <marek.safar@gmail.com>
999 * expression.cs: Equality comparison of generic parameter with
1002 2009-10-05 Marek Safar <marek.safar@gmail.com>
1004 A fix for bug #543570
1005 * generic.cs: Import predefined constraints correctly.
1007 2009-10-02 Marek Safar <marek.safar@gmail.com>
1009 * ecore.cs: Don't crash on overloads with optional paremeters where
1010 arguments count overflows.
1012 * parameter.cs: Import optional parameter constants using optional
1015 2009-10-01 Marek Safar <marek.safar@gmail.com>
1017 * Makefile: Default is gmcs compiler.
1019 2009-10-01 Marek Safar <marek.safar@gmail.com>
1021 * cs-parser.jay: Fixed few NRE.
1023 2009-10-01 Marek Safar <marek.safar@gmail.com>
1025 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
1027 2009-09-30 Marek Safar <marek.safar@gmail.com>
1029 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
1030 ShimExpression, ImplicitCast.
1032 2009-09-30 Marek Safar <marek.safar@gmail.com>
1034 A fix for bug #542959
1035 * delegate.cs: Emit correct delegate instance variable when there
1036 are static and non-static overloads.
1038 2009-09-29 Marek Safar <marek.safar@gmail.com>
1040 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
1041 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
1043 2009-09-28 Marek Safar <marek.safar@gmail.com>
1045 A fix for bug #542487
1046 * ecore.cs: Resolve extension methods hidden by properties.
1048 2009-09-25 Marek Safar <marek.safar@gmail.com>
1050 * expression.cs, ecore.cs: More dynamic binary expressions.
1052 2009-09-22 Marek Safar <marek.safar@gmail.com>
1054 * nullable.cs, expression.cs: Fixed null lifted conversion for
1055 bitwise enum operations.
1057 2009-09-22 Marek Safar <marek.safar@gmail.com>
1059 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
1060 values in checked context.
1062 2009-09-22 Marek Safar <marek.safar@gmail.com>
1064 * expression.cs, ecore.cs: Fixed array index constant conversion.
1066 2009-09-20 Miguel de Icaza <miguel@novell.com>
1068 * expression.cs: Do not crash when MemberLookup returns something
1069 that is not a MemberExpr here. Report error 582 instead.
1073 2009-09-18 Marek Safar <marek.safar@gmail.com>
1075 * decl.cs, class.cs: Check protected property accessors.
1077 2009-09-18 Marek Safar <marek.safar@gmail.com>
1079 * dynamic.cs, assign.cs: Dynamic compound assignment.
1081 2009-09-17 Marek Safar <marek.safar@gmail.com>
1083 * expression.cs: Fixed compound assignment explicit conversion.
1085 2009-09-17 Marek Safar <marek.safar@gmail.com>
1087 * expression.cs, ecore.cs: Cannot infer variables from method group.
1089 2009-09-16 Marek Safar <marek.safar@gmail.com>
1091 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
1092 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
1093 codegen.cs: Dynamic binary operations scaffolding.
1095 2009-09-15 Marek Safar <marek.safar@gmail.com>
1097 * expression.cs: Fixes nullable promotion for enum type variables.
1099 2009-09-11 Marek Safar <marek.safar@gmail.com>
1101 * driver.cs, dynamic.cs: Reset more static variables.
1103 2009-09-11 Marek Safar <marek.safar@gmail.com>
1105 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
1106 driver.cs: Introduced Expression::MakeExpression.
1108 2009-09-11 Marek Safar <marek.safar@gmail.com>
1110 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
1112 2009-09-09 Marek Safar <marek.safar@gmail.com>
1114 * eval.cs, report.cs: Use Console.Out for all eval error or warning
1117 2009-09-09 Marek Safar <marek.safar@gmail.com>
1119 A fix for bug #518707
1120 * expression.cs (Is): Optimize only generic parameter type
1121 expression probing value type generic parameter.
1123 2009-09-09 Marek Safar <marek.safar@gmail.com>
1125 A fix for bug #532571
1126 * ecore.cs: Check for simple name type arguments used with
1129 2009-09-08 Marek Safar <marek.safar@gmail.com>
1131 A fix for bug #497421
1132 * generic.cs (CheckConstraint): Don't use buildin types to check for
1133 parameterless constructor.
1135 2009-09-08 Marek Safar <marek.safar@gmail.com>
1137 A fix for bug #537402
1138 * generic.cs (CheckConstraint): Correctly inflate generic type
1139 arguments when checking generic method.
1141 2009-09-08 Marek Safar <marek.safar@gmail.com>
1143 A fix for bug #536463
1144 * decl.cs (AddToContainer): Don't report collision between explicit
1145 and parameterless non-explicit members.
1147 2009-09-08 Marek Safar <marek.safar@gmail.com>
1149 * eval.cs: Reset more static stuff.
1151 2009-09-07 Marek Safar <marek.safar@gmail.com>
1153 A fix for bug #324625
1154 * expression.cs, ecore.cs: Create nested generic type expression
1155 using declaring and not current type.
1157 2009-09-07 Marek Safar <marek.safar@gmail.com>
1159 * *.cs: Changed Report class to accept various output printers and
1160 be an instance class. An expression resolver can now use different
1161 message reporter for each call and Report.Error can safely throw
1162 an exception. Part of ongoing work to turn mcs into proper library.
1164 2009-09-04 Marek Safar <marek.safar@gmail.com>
1166 * statement.cs, ecore.cs: Removed error reporting from emit code.
1168 2009-09-04 Marek Safar <marek.safar@gmail.com>
1170 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
1172 2009-09-03 Marek Safar <marek.safar@gmail.com>
1174 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
1175 parser checks out of constructors.
1177 2009-09-02 Marek Safar <marek.safar@gmail.com>
1179 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
1181 2009-09-02 Marek Safar <marek.safar@gmail.com>
1183 A fix for bug #535448
1184 * anonymous.cs, class.cs: Copy return label between all contexts.
1186 2009-09-02 Marek Safar <marek.safar@gmail.com>
1188 A fix for bug #535395
1189 * namespace.cs: Resolve context can be null.
1191 2009-08-25 Marek Safar <marek.safar@gmail.com>
1193 A fix for bug #533912
1194 * generic.cs: Use correct context for constraints resolving.
1196 2009-08-25 Marek Safar <marek.safar@gmail.com>
1198 A fix for bug #532630
1199 * driver.cs: Trim conditional symbols.
1201 2009-08-25 Marek Safar <marek.safar@gmail.com>
1203 * context.cs: New file.
1205 * *.exe.sources, *.csproj: Updated.
1207 2009-08-25 Marek Safar <marek.safar@gmail.com>
1209 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1210 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1211 IMembercontext, some small cleanups.
1213 2009-08-24 Marek Safar <marek.safar@gmail.com>
1215 * *.cs: Split ResolveContext and EmitContext.
1217 2009-08-24 Marek Safar <marek.safar@gmail.com>
1219 * *.cs: Only ResolveContext implements IMemberContext.
1221 2009-08-21 Marek Safar <marek.safar@gmail.com>
1223 * *.cs: Renamed IResolveContext to IMemberContext.
1225 2009-08-21 Marek Safar <marek.safar@gmail.com>
1227 * *.cs: Detached ResolveContext from EmitContext.
1229 2009-08-21 Marek Safar <marek.safar@gmail.com>
1231 * codegen.cs: Moved flow-analysis to BlockContext.
1233 2009-08-21 Marek Safar <marek.safar@gmail.com>
1235 * *.cs: Detached BlockContext from EmitContext.
1237 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1239 * statement.cs: avoid nullref when the return value of GetEnumerator()
1240 does not contain any MoveNext() method.
1242 2009-08-19 Marek Safar <marek.safar@gmail.com>
1244 * *.cs: Removed IResolveContext::GenericDeclContainer.
1246 2009-08-19 Marek Safar <marek.safar@gmail.com>
1248 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1250 2009-08-19 Marek Safar <marek.safar@gmail.com>
1252 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1253 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1255 2009-08-18 Marek Safar <marek.safar@gmail.com>
1257 * *.cs: Removed boolean fields from EmitContext.
1259 2009-08-18 Marek Safar <marek.safar@gmail.com>
1261 * *.cs: Add IResolveContext::IsStatic.
1263 2009-08-18 Marek Safar <marek.safar@gmail.com>
1265 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1267 2009-08-17 Marek Safar <marek.safar@gmail.com>
1269 * *.cs: Removed DeclContainer from EmitContext.
1271 2009-08-17 Marek Safar <marek.safar@gmail.com>
1273 * *.cs: Add IResolveContext::CurrentTypeParameters.
1275 2009-08-14 Marek Safar <marek.safar@gmail.com>
1277 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1279 2009-08-14 Marek Safar <marek.safar@gmail.com>
1281 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1282 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1284 2009-08-13 Marek Safar <marek.safar@gmail.com>
1286 * decl.cs: Look in PartialContainer for parent type parameters.
1288 2009-08-13 Marek Safar <marek.safar@gmail.com>
1290 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1291 codegen.cs: Add IResolveContext::LookupTypeParameter.
1293 2009-08-13 Marek Safar <marek.safar@gmail.com>
1295 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1296 Moved resolved logic from Emit to Resolve.
1298 2009-08-13 Marek Safar <marek.safar@gmail.com>
1300 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1301 codegen.cs: Reworked atttributes handling of ResolveContext.
1303 2009-08-12 Marek Safar <marek.safar@gmail.com>
1305 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1306 LookupNamespaceOrType to ResolveContext.
1308 2009-08-12 Marek Safar <marek.safar@gmail.com>
1310 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1311 class.cs: Removed unused parameters and methods.
1313 2009-08-11 Marek Safar <marek.safar@gmail.com>
1315 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1316 codegen.cs: Finding the best common type of a set of expressions for
1319 2009-08-07 Marek Safar <marek.safar@gmail.com>
1321 * dynamic.cs, expression.cs: More dynamic conversions.
1323 2009-08-06 Miguel de Icaza <miguel@novell.com>
1325 * generic.cs: This loop was incorrect, it was increment ii, but
1326 checking for `i'. This was a change introduced to fix #327497,
1329 * class.cs: Catch another case for cs0533 error, fixes #324782.
1331 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1333 * typemanager.cs (GetGenericArguments): SRE returns null for
1334 generic methods on type builder instances if they are not generic
1335 themselves. For example, for Foo<int>::Bar() it returns null, but
1336 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1338 2009-08-05 Marek Safar <marek.safar@gmail.com>
1340 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1341 delegate.cs: Work on dynamic binding.
1343 2009-08-04 Marek Safar <marek.safar@gmail.com>
1345 A second fix for bug #525342
1346 * class.cs: Attach partial method attributes to method
1349 2009-08-03 Marek Safar <marek.safar@gmail.com>
1351 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1354 * rootcontext.cs: Default to langversion v4.
1356 2009-08-03 Marek Safar <marek.safar@gmail.com>
1358 * pending.cs: Check return type before member info is set.
1360 2009-08-03 Marek Safar <marek.safar@gmail.com>
1362 * anonymous.cs: Fully initialize generic hoisted field expression.
1364 2009-08-02 Miguel de Icaza <miguel@novell.com>
1366 * cs-parser.jay: Flag variables declared on the interactive shell
1367 as used to prevent the 168 warning about local variable not being
1370 2009-07-31 Marek Safar <marek.safar@gmail.com>
1372 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1373 attribute.cs: Emit dynamic export attribute.
1375 2009-07-30 Marek Safar <marek.safar@gmail.com>
1377 * expression.cs: More verifier work.
1379 2009-07-29 Marek Safar <marek.safar@gmail.com>
1381 * nullable.cs: Fixed SRE crash during corlib compilation.
1383 2009-07-29 Marek Safar <marek.safar@gmail.com>
1385 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1386 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1387 More TypeManager.TypeToCoreType needed.
1389 2009-07-29 Marek Safar <marek.safar@gmail.com>
1391 * anonymous.cs: Update after recent SRE fixes.
1393 2009-07-28 Marek Safar <marek.safar@gmail.com>
1395 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1396 version of GetFieldHandle for fields of generic types.
1398 2009-07-27 Marek Safar <marek.safar@gmail.com>
1400 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1401 ecore.cs: Add TypeManager.IsDynamicType,
1402 PredefinedAttributes.Dynamic.
1404 2009-07-27 Marek Safar <marek.safar@gmail.com>
1406 A fix for bug #415375
1407 * expression.cs: Fixed object and reference type parameter
1410 2009-07-27 Marek Safar <marek.safar@gmail.com>
1412 A fix for bug #525342
1413 * class.cs: Attach partial method attributes to method
1416 2009-07-24 Marek Safar <marek.safar@gmail.com>
1418 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1421 2009-07-24 Marek Safar <marek.safar@gmail.com>
1423 * anonymous.cs (MutateField): Add imported types handling.
1425 2009-07-23 Marek Safar <marek.safar@gmail.com>
1427 * expression.cs, delegate.cs: Moved arguments resolve into their
1428 counterparts expressions. Removed argument resolve from
1429 CollectionElementInitializer.
1431 2009-07-23 Marek Safar <marek.safar@gmail.com>
1433 A fix for bug #523683
1434 * convert.cs, delegate.cs: Use common overload mechanism for method
1435 group conversion check.
1437 2009-07-22 Marek Safar <marek.safar@gmail.com>
1439 A fix for bug #523899
1440 * generics.cs: Exact type inference with other bound types.
1442 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1444 Don't complain when the same type is implemented by the output
1445 assembly as well as multiple referenced assemblies
1446 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1447 'must_be_unique' flag.
1448 (GlobalRootNamespace): Update to changes.
1449 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1450 already have a type in hand.
1452 2009-07-22 Marek Safar <marek.safar@gmail.com>
1454 * expression.cs: More verifier instrumentation.
1456 * statement.cs: Do proper throw expression conversion.
1458 2009-07-22 Marek Safar <marek.safar@gmail.com>
1460 A fix for bug #522789
1461 * expression.cs: Mutate invocation return type.
1463 2009-07-16 Marek Safar <marek.safar@gmail.com>
1465 * anonymous.cs: Split assignable and readonly generated variable
1468 2009-07-16 Marek Safar <marek.safar@gmail.com>
1470 A fix for bug #521671
1471 * statement.cs: Fixed crash when checking missing type.
1473 2009-07-16 Marek Safar <marek.safar@gmail.com>
1475 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1476 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1477 class.cs, driver.cs: Work on dynamic binding.
1479 * dynamic.cs: New file.
1481 * *.sources, *.proj: Updated.
1483 2009-07-15 Marek Safar <marek.safar@gmail.com>
1485 * expression.cs (Conditional): Avoid double Resolve.
1487 2009-07-13 Marcus Griep <marcus@griep.us>
1489 * ecore.cs: Fix obscure bug with resolving members of interfaces
1490 that hide parent interface members. Fixes bug #444388 and corrects
1493 2009-07-13 Marek Safar <marek.safar@gmail.com>
1495 * expression.cs (LocalVariableReference): Bounce resolve.
1497 2009-07-10 Marek Safar <marek.safar@gmail.com>
1499 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1500 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1503 * support.cs: New dynamic type wrapper.
1505 2009-07-08 Marek Safar <marek.safar@gmail.com>
1507 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1508 typed local variable.
1510 2009-07-06 Marek Safar <marek.safar@gmail.com>
1512 A fix for bug #519005
1513 * anonymous.cs: Use null_type as no return type placeholder.
1515 2009-07-02 Marek Safar <marek.safar@gmail.com>
1517 * generic.cs: Handle type inference of identical type parameters
1518 with different bounds.
1520 2009-07-01 Marek Safar <marek.safar@gmail.com>
1522 * expression.cs, class.cs: Events variance.
1524 * cs-parser.jay: Interface events error messages.
1526 2009-07-01 Marek Safar <marek.safar@gmail.com>
1528 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1530 2009-06-29 Marek Safar <marek.safar@gmail.com>
1532 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1533 parameter expression can be value-type New.
1535 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1537 2009-06-26 Marek Safar <marek.safar@gmail.com>
1539 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1540 Implemented C# 4.0 named arguments.
1542 2009-06-24 Marek Safar <marek.safar@gmail.com>
1544 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1545 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1546 parameter modifier. Also fixes bug #515497.
1548 2009-06-24 Marek Safar <marek.safar@gmail.com>
1550 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1551 arguments expression to be implemented.
1553 *.sources: Add argument.cs
1555 2009-06-23 Marek Safar <marek.safar@gmail.com>
1557 * parameter.cs: Moved GetParameterIndexByName to base class.
1559 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1560 unused AType. Use argument's version of GetExpressionTree.
1562 2009-06-22 Marek Safar <marek.safar@gmail.com>
1564 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1567 2009-06-17 Marek Safar <marek.safar@gmail.com>
1569 A fix for bug #514096
1570 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1572 2009-06-17 Marek Safar <marek.safar@gmail.com>
1574 * expression.cs: The first multi-dimensional array nested array
1575 initializers was not checked.
1577 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1579 2009-06-17 Marek Safar <marek.safar@gmail.com>
1581 A fix for bug #513400
1582 * nullable.cs (EmitEquality): Operands emit could be simplified for
1583 built-in types when we now emit user operators differently.
1585 2009-06-16 Marek Safar <marek.safar@gmail.com>
1587 * ecore.cs: Report inaccessible delegate methods correctly.
1589 2009-06-16 Marek Safar <marek.safar@gmail.com>
1591 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1592 cs-parser.jay: Implemented C# 4.0 optional parameters.
1594 2009-06-16 Marek Safar <marek.safar@gmail.com>
1596 * driver.cs: Removed broken DefineManifestResource.
1598 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1600 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1601 Use $(BOOTSTRAP_PROFILE) instead.
1603 2009-06-12 Jb Evain <jbevain@novell.com>
1605 * rootcontext.cs: add a Platform field.
1606 * driver.cs: handle /platform.
1607 * codegen.cs: pass the proper flags according to
1608 the platform when saving the assembly.
1610 2009-06-11 Marek Safar <marek.safar@gmail.com>
1612 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1613 Add optional parameters grammar.
1615 2009-06-10 Marek Safar <marek.safar@gmail.com>
1617 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1618 driver.cs: Split lang version and metadata version.
1620 2009-06-10 Marek Safar <marek.safar@gmail.com>
1622 * decl.cs: Better overload ctor collision error message.
1624 2009-06-05 Jb Evain <jbevain@novell.com>
1626 * driver.cs (EmbededResource): avoid using an internal method
1627 in gmcs to embed manifest resources.
1629 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1631 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1632 the compiler from older mono versions (like moon's bots)
1634 2009-06-04 Marek Safar <marek.safar@gmail.com>
1636 * namespace.cs (LookupTypeReflection): Ignore collisions between
1639 2009-06-04 Marek Safar <marek.safar@gmail.com>
1641 * codegen.cs: Enabled generic type forwarders.
1643 2009-06-04 Marek Safar <marek.safar@gmail.com>
1645 * dmcs.*: Add another version of SRE compiler.
1647 2009-06-03 Marek Safar <marek.safar@gmail.com>
1649 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1650 generic-mcs.cs: Fixed variant type conversions.
1652 2009-06-02 Marek Safar <marek.safar@gmail.com>
1654 A fix for bug #507863
1655 * codegen.cs: Fixes a crash on invalid string value attribute.
1657 2009-06-01 Marek Safar <marek.safar@gmail.com>
1659 A fix for bug #508334
1660 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1661 cs-parser.jay: Fully import __arglist modifier.
1663 2009-05-29 Marek Safar <marek.safar@gmail.com>
1665 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1666 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1667 actually work with closed generic types.
1669 2009-05-27 Alan McGovern <amcgovern@novell.com>
1671 * class.cs, decl.cs, delegate.cs, parameter.cs:
1672 Fix the build by replacing the use of 'var' with the actual type.
1674 2009-05-27 Marek Safar <marek.safar@gmail.com>
1676 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1677 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1680 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1683 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1684 Marek Safar <marek.safar@gmail.com>
1686 A fix for bug #377509
1687 * parameter.cs: Use predefined and not empty name for implicit
1690 2009-05-21 Marek Safar <marek.safar@gmail.com>
1692 * class.cs: Don't report wrong warnings for event fields.
1694 2009-05-21 Marek Safar <marek.safar@gmail.com>
1696 A fix for bug #504667
1697 * class.cs: Check for static class using parent container instead of
1700 2009-05-08 Marek Safar <marek.safar@gmail.com>
1702 A fix for bug #496922
1703 * expression.cs: Always use temporary variable when using object
1706 2009-04-28 Marek Safar <marek.safar@gmail.com>
1708 A fix for bug #495112
1709 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1712 2009-04-27 Miguel de Icaza <miguel@novell.com>
1714 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1716 2009-04-24 Miguel de Icaza <miguel@novell.com>
1718 * complete.cs: No idea how gonzalo got a null in the list, but
1721 2009-04-24 Miguel de Icaza <miguel@novell.com>
1723 * complete.cs (CompletionElementInitializer): New completion class
1724 to support completing inside a C# 3 element initializer, so this
1725 allows completion for Silverlight situations where it is very
1728 new TextBlock () { Fo<TAB>
1730 (CompletionSimpleName): Expose the prefix that was
1731 passed to the simple name.
1733 * cs-parser.jay (object_or_collection_initializer): Add support
1734 for element_initializers.
1736 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1737 special case completion expressions as this method aggressively
1738 collects data before it operates, and errors were being thrown
1739 earlier than we were able to complete.
1741 2009-04-23 Miguel de Icaza <miguel@novell.com>
1743 * eval.cs: Make getcompletions silent and enable debugging output
1744 if the -v option is passed.
1746 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1747 Consider looking up the namespace that matches the prefix being
1750 This is part of the support for allowing completions like:
1751 `System.Co<TAB>' to complete to System.Console.
1753 * complete.cs (CompletionSimpleName.AppendResults): Make this
1756 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1758 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1759 COMPLETE_COMPLETION as internal.
1761 2009-04-17 Miguel de Icaza <miguel@novell.com>
1763 * complete.cs: Include namespace resolution in simple names as
1764 well as global types and types in the using scope in the
1767 * namespace.cs: Supporting infrastrcture to provide completions
1768 based on the current using scope.
1770 * eval.cs: Introduce an entry point that allows for initialization
1771 to return a list of the files passed on the command line.
1773 2009-04-14 Marek Safar <marek.safar@gmail.com>
1775 A fix for bug #494243
1776 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1778 2009-04-13 Marek Safar <marek.safar@gmail.com>
1780 A fix for bug #493887
1781 * statement.cs: Don't skip string multi-section with default or
1782 null label when populating string hashtable.
1784 2009-04-06 Marek Safar <marek.safar@gmail.com>
1786 A fix for bug #492329
1787 * expression.cs (New): Load variable when assigning type parameter
1790 2009-04-06 Marek Safar <marek.safar@gmail.com>
1792 A fix for bug #488960
1793 * decl.cs: Compare MVAR types using non-null values.
1795 2009-03-27 Marek Safar <marek.safar@gmail.com>
1797 * typemanager.cs, expression.cs: Removed unused nullable checks.
1799 2009-03-27 Marek Safar <marek.safar@gmail.com>
1801 * *.cs: Removed some gmcs conditionals.
1803 2009-03-26 Marek Safar <marek.safar@gmail.com>
1805 * generic.cs, support.cs: Moved generics stuff out of support.cs
1807 2009-03-24 Marek Safar <marek.safar@gmail.com>
1809 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1812 2009-03-23 Marek Safar <marek.safar@gmail.com>
1814 * attribute.cs: Consider all members for error reporting when
1815 checking named arguments.
1817 2009-03-23 Marek Safar <marek.safar@gmail.com>
1819 A fix for bug #487625
1820 * namespace.cs: Use a warning for all predefined type conflicts.
1822 2009-03-23 Marek Safar <marek.safar@gmail.com>
1824 A fix for bug #485706
1825 * statement.cs: Explicitly type catch type argument to pass verifier
1828 2009-03-22 Miguel de Icaza <miguel@novell.com>
1830 Initial support to provide code completion facilities to consumers
1831 of the evaluator API.
1833 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1834 support the completion engine. When we reach the end of the
1835 input stream instead of returning EOF, when this flag is true the
1836 tokenizer instead produces:
1838 One GENERATE_COMPLETION token: this token then must be
1839 handled in the grammar at every point where the user
1840 would likely request a completion.
1842 As many COMPLETE_COMPLETION tokens as necessary. These
1843 tokens are generated to assist the parser in unwinding and
1844 producing a valid parse tree.
1846 The parser rules do not have to be perfect, the parser needs to be
1847 augmented with judicious use of GENERATE_COMPLETION tokens to
1848 improve the areas where we can provide completion and the parser
1849 needs to add support for COMPLETE_COMPLETION tokens in productions
1852 It is common to not have enough support for COMPLETE_COMPLETION
1853 under certain rules and that even if we generated the
1854 GENERATE_COMPLETION token that the resulting tree will be invalid
1855 due to the missing rules that support COMPLETE_COMPLETION.
1857 The final EOF token is produced by having the parser notify the
1858 tokenizer when it reaches the root production that the next token
1861 * support.cs (CompletionResult): New Exception. This exception
1862 is thrown to return the completion results when one of the special
1863 completion expressions is reached.
1865 This exception is thrown by the completing ExpressionStatements
1866 classes that live in complete.cs
1868 * complete.cs (CompletingExpression): a new base class for
1869 completing expressions. This derives from the
1870 ExpressionStatement class and not from Expression as it allows
1871 completion to happen not only where expressions are expected in
1872 the grammar, but also where statements are expected.
1874 (CompletionSimpleName): A new class used to provide completions
1875 for SimpleNames. This currently only resolves to local
1876 variables from the evaluator context (GetVars call).
1878 (CompletionMemberAccess): Implements support for completing member
1881 * cs-parser.jay: Add support for completion in a few places.
1883 * eval.cs (GetCompletions): New public API for the evaluator that
1884 returns a list of possible completions given the input. The
1885 return value is an array of completions
1887 * anonymous.cs (Compatible): If the exception thrown from the
1888 resolved expression is a CompletionResult exception let that one
1889 through instead of printing a diagnostic error in the try/catch.
1891 2009-03-22 Miguel de Icaza <miguel@novell.com>
1895 * driver.cs (Main): Use Environment.Exit to quit quickly and
1896 prevent the compiler from doing the usual wait for helper thread
1899 This is to prevent a slowdown that was reported by Gonzalo on
1902 2009-03-19 Marek Safar <marek.safar@gmail.com>
1904 * ecore.cs: Load build-in types directly instead of accessing
1907 2009-03-18 Marek Safar <marek.safar@gmail.com>
1909 * ecore.cs: Always use unbox.any when available.
1911 2009-03-18 Marek Safar <marek.safar@gmail.com>
1913 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1915 2009-03-17 Marek Safar <marek.safar@gmail.com>
1917 * generic.cs: Removed obsolete version of type inference.
1919 2009-03-16 Marek Safar <marek.safar@gmail.com>
1921 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1922 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1923 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1924 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1926 2009-03-11 Marek Safar <marek.safar@gmail.com>
1928 A fix for bug #482996
1929 * anonymous.cs: Make sure we are not infering return type when
1930 checking type compatibility.
1932 2009-03-11 Marek Safar <marek.safar@gmail.com>
1934 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1935 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1936 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1937 attributes in their own structure. Needed when accessing their
1938 properties before they are resolved.
1940 2009-03-09 Marek Safar <marek.safar@gmail.com>
1942 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1943 hashtable (~10x faster).
1945 * driver.cs: Removed wrong Reset.
1947 2009-03-08 Marek Safar <marek.safar@gmail.com>
1949 * class.cs: Use correct common base type for unmanaged delayed
1952 * rootcontext.cs: Wrap unhandled exception.
1954 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1956 Make SeekableStreamReader self-tuning and arbitrarily seekable
1957 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1959 (SeekableStreamReader.Position.set): Use it. Simplify logic
1960 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1961 buffer size when the stream needs to be re-read from the beginning.
1963 2009-03-05 Marek Safar <marek.safar@gmail.com>
1965 A fix for bug #480100
1966 * parameter.cs: A parameter is not hoisted when used directly as ET.
1968 2009-03-04 Marek Safar <marek.safar@gmail.com>
1970 * statement.cs: Fixed an issue when using variable is of interface
1973 2009-03-03 Marek Safar <marek.safar@gmail.com>
1975 A fix for bug #480319
1976 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1978 2009-03-03 Marek Safar <marek.safar@gmail.com>
1980 A fix for bug #480867
1981 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1982 expression to have no valid type.
1984 2009-03-03 Marek Safar <marek.safar@gmail.com>
1986 A fix for bug #481258
1987 * class.cs: Set extension method flag in partial container.
1989 2009-03-03 Marek Safar <marek.safar@gmail.com>
1991 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1993 * attribute.cs: Add sanity check.
1995 2009-02-27 Marek Safar <marek.safar@gmail.com>
1997 * class.cs: Add external constructor error.
1999 2009-02-26 Marek Safar <marek.safar@gmail.com>
2001 A fix for bug #475354
2002 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
2003 correctly user defined nullable equality operators.
2005 2009-02-25 Marek Safar <marek.safar@gmail.com>
2007 A fix for bug #479532
2008 * expression.cs: Implement NewInitialize::AddressOf.
2010 2009-02-25 Marek Safar <marek.safar@gmail.com>
2012 A fix for bug #413633
2013 * expression.cs: Iterate all base class-constraint types.
2015 2009-02-24 Marek Safar <marek.safar@gmail.com>
2017 A fix for bug #479209
2018 * literal.cs: Mutate null underlying type.
2020 2009-02-24 Marek Safar <marek.safar@gmail.com>
2022 A fix for bug #476295
2023 * convert.cs: Avoid wrapping implicitly convertible reference type.
2025 2009-02-23 Marek Safar <marek.safar@gmail.com>
2027 * iterators.cs: Create MemberName correctly.
2029 2009-02-23 Marek Safar <marek.safar@gmail.com>
2031 A fix for bug #478655
2032 * literal.cs: Check also underlying null type conversion.
2034 2009-02-21 Marek Safar <marek.safar@gmail.com>
2036 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
2038 2009-02-20 Marek Safar <marek.safar@gmail.com>
2040 A fix for bug #477447
2041 * statement.cs: Add reference to correct parent storey when this
2042 is accessible from deep children storey (more than 1 level).
2044 2009-02-19 Marek Safar <marek.safar@gmail.com>
2046 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
2047 * class.cs: Define base type members before setting up member cache.
2049 2009-02-18 Marek Safar <marek.safar@gmail.com>
2051 A fix for bug #477378
2052 * nullable.cs, expression.cs, statement.cs: More precise null type
2055 2009-02-18 Marek Safar <marek.safar@gmail.com>
2057 A fix for bug #472805
2058 * typemanager.cs, namespace.cs: Import only visible extension method
2061 2009-02-18 Marek Safar <marek.safar@gmail.com>
2063 A fix for bug #476895
2064 * attribute.cs: Use correct resolve context for attribute type.
2066 2009-02-18 Marek Safar <marek.safar@gmail.com>
2068 A fix for bug #476266
2069 * anonymous.cs: Mutate multi-dimensional arrays.
2071 2009-02-18 Marek Safar <marek.safar@gmail.com>
2073 A fix for bug #476400
2074 * statement.cs, expression.cs: Removed wrong Dispose optimization.
2076 2009-02-18 Marek Safar <marek.safar@gmail.com>
2078 A fix for bug #476811
2079 * generics.cs: Fixed null-literal check.
2081 2009-02-17 Marek Safar <marek.safar@gmail.com>
2083 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
2084 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
2085 messing with static variables.
2087 2009-02-16 Marek Safar <marek.safar@gmail.com>
2089 A fix for bug #475965
2090 * generics.cs: Check generic parameter type after extracting from
2093 2009-02-16 Marek Safar <marek.safar@gmail.com>
2095 A fix for bug #475823
2096 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
2099 2009-02-14 Marek Safar <marek.safar@gmail.com>
2101 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
2102 Simplified event field definition using backing field and not
2103 field builder directly.
2105 * expression.cs (EmitLdArg): Optimize fast paths.
2107 2009-02-13 Marek Safar <marek.safar@gmail.com>
2109 A fix for bug #475327
2110 * expression.cs (ArrayCreation): Don't mutate values optimized away.
2112 2009-02-13 Marek Safar <marek.safar@gmail.com>
2114 A fix for bug #475342
2115 * cs-parser.jay: Using 'super' instead of 'base' to call base
2116 constructor crashes compiler.
2118 2009-02-13 Marek Safar <marek.safar@gmail.com>
2120 A fix for bug #475354
2121 * expression.cs (Constantify): Add nullable types.
2123 * const.cs (EmitDecimalConstant): Avoid explicit cast.
2125 2009-02-12 Marek Safar <marek.safar@gmail.com>
2127 A fix for bug #475246
2128 * expression.cs: More broken flowanalysis hacking needed.
2130 2009-02-12 Marek Safar <marek.safar@gmail.com>
2132 * attribute.cs: Compare only ref/out array modifiers.
2134 2009-02-11 Marek Safar <marek.safar@gmail.com>
2136 * statement.cs: Use member cache when looking for foreach members.
2138 2009-02-11 Marek Safar <marek.safar@gmail.com>
2140 * expression.cs: Don't expose internal initializer types.
2142 * statement.cs: Check also explicit conversions for goto case.
2144 2009-02-11 Marek Safar <marek.safar@gmail.com>
2146 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
2148 2009-02-10 Marek Safar <marek.safar@gmail.com>
2150 * *.cs: Replace null-type with NullLiteral where appropriate.
2152 2009-02-09 Marek Safar <marek.safar@gmail.com>
2154 * expression.cs: Initializer of reference argument use temporary
2155 variable to be verifiable.
2157 * parameter.cs: Share EmitLdArg.
2159 2009-02-09 Marek Safar <marek.safar@gmail.com>
2161 A fix for bug #473559
2162 * class.cs: Fixed: Not reporting error about nested class with the
2165 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
2167 Contributed under the MIT/X11 license.
2169 * generic.cs: Added VerifyVariantTypeParameters which performs new
2170 variance verification logic. The old logic, based on the spec, was
2171 wrong because the spec is full of LIES!
2173 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
2175 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
2178 * ecore.cs: Added calls to the new variance verification logic.
2181 * delegate.cs: Removed calls to the old variance verification logic.
2183 2009-02-06 Marek Safar <marek.safar@gmail.com>
2185 * delegate.cs: Use cached Invoke method directly.
2187 2009-02-06 Marek Safar <marek.safar@gmail.com>
2189 * expression.cs: Emit expression tree for hoisted variable access.
2191 2009-02-04 Marek Safar <marek.safar@gmail.com>
2193 * namespace.cs: Add better extension class check.
2195 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2197 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2199 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2201 This patch adds initial generic variance support to the compiler.
2202 It is contributed under the MIT/X11 license.
2204 * typemanager.cs: Modified ImplementsInterface to check variance.
2205 Added VerifyVariantTypeParameters which checks the specified type to see
2206 if it uses a variant type parameter as a type argument (which is not
2207 allowed). Added IsVariantOf which determins if the first type is a
2208 variant of the second. NOTE: This only supports reference types at
2209 the moment to conform with the current level of VM support. When the
2210 VM supports value types, this will follow step.
2212 * generic.cs: Added the Variance enum. Added a Variance property to
2213 TypeParameter and added variance support to definition phase. Added a
2214 Variance property to TypeParameterName. Also check to make sure that
2215 no variant types appear in generic method parameters.
2217 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2218 keywords if the langversion supports it.
2220 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2221 that variant types are only used in legal positions. Also added
2222 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2225 * decl.cs: Construct TypeParameter with the variance information.
2227 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2228 and ImplicitConversionStandard.
2230 * rootcontext.cs: Added new "Future" language version.
2232 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2233 type parameters are not used as type arguments in interface inheritance.
2234 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2235 parameters are not used as method return types. In MemberBase.
2236 ResolveMemberType, ensure that variant type parameters are not used
2237 as type arguments. Also call VerifyNoVariantTypeParameters on every
2238 set of parameters which are resolved.
2240 * delegate.cs: Modified Delegate.Define to ensure that variant
2241 parameters are not used as type arguments and that a contravariant
2242 parameter is not used as the return type. Also call
2243 VerifyNoVariantTypeParameters on the delegate parameters.
2245 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2246 to specify generic variance.
2248 * driver.cs: Added support for LanguageVersion.Future in the form of
2249 "-langversion:future".
2251 * generic-mcs.cs: Stubbed out new members in generic.cs.
2253 2009-02-03 Marek Safar <marek.safar@gmail.com>
2255 * class.cs, generic.cs: Emit type parameter constraints for nested
2258 2009-02-02 Marek Safar <marek.safar@gmail.com>
2260 A fix for bug #471213
2261 * class.cs: Avoid emitting backing field for abstract event fields.
2263 2009-02-01 Marek Safar <marek.safar@gmail.com>
2265 A fix for bug #359731
2266 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2269 2009-01-30 Marek Safar <marek.safar@gmail.com>
2271 A fix for bug #470767
2272 * statement.cs: Introduced BlockScopeExpression, needed when
2273 expression tree conversion has to emit scope variables.
2275 2009-01-29 Marek Safar <marek.safar@gmail.com>
2277 * class.cs: Remove duplicate CallingConvention.
2279 2009-01-29 Marek Safar <marek.safar@gmail.com>
2281 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2282 when I finally found the right naming convention.
2284 2009-01-29 Marek Safar <marek.safar@gmail.com>
2286 * cs-tokenizer.cs: Put back different open parens optimization.
2288 2009-01-28 Marek Safar <marek.safar@gmail.com>
2290 A fix for bug #470227
2291 * cs-tokenizer.cs: Remove too agressive parser optimization.
2293 2009-01-28 Marek Safar <marek.safar@gmail.com>
2295 A fix for bug #324319
2296 * class.cs: Remove too early base type resolve.
2298 2009-01-27 Marek Safar <marek.safar@gmail.com>
2300 A fix for bug #324319
2301 * ecore.cs: Explicitly type null when assigning to type argument to
2302 make pass verifier check.
2304 2009-01-27 Marek Safar <marek.safar@gmail.com>
2306 * anonymous.cs: Fixed recent regression when initializing captured
2309 2009-01-26 Marek Safar <marek.safar@gmail.com>
2311 A fix for bug #469019
2312 * anonymous.cs: Use all parent type parameters when instantiating
2313 nested generic storey.
2315 2009-01-26 Marek Safar <marek.safar@gmail.com>
2317 * expression.cs: Check for null instance methodgroup expression.
2319 2009-01-26 Marek Safar <marek.safar@gmail.com>
2321 A fix for bug #469244
2322 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2323 instance inside a conditional expression.
2325 2009-01-23 Marek Safar <marek.safar@gmail.com>
2327 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2328 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2329 GetElementType and HasElementType. IsValueType clean up.
2331 2009-01-23 Marek Safar <marek.safar@gmail.com>
2333 * nullable.cs: Use common EmitCall.
2335 * expression.cs: Emit constraint. for virtual calls only.
2337 2009-01-23 Marek Safar <marek.safar@gmail.com>
2339 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2340 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2341 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2344 2009-01-22 Jb Evain <jbevain@novell.com>
2346 * anonymous.cs: make anonymous types' ToString implementation
2347 match what csc outputs.
2349 2009-01-21 Marek Safar <marek.safar@gmail.com>
2351 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2354 2009-01-17 Marek Safar <marek.safar@gmail.com>
2356 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2359 2009-01-16 Marek Safar <marek.safar@gmail.com>
2361 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2364 2009-01-15 Marek Safar <marek.safar@gmail.com>
2366 A fix for bug #466634
2367 * statement.cs: Add reference for nested storey when only this
2370 2009-01-15 Marek Safar <marek.safar@gmail.com>
2372 A fix for bug #466474
2373 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2376 2009-01-15 Marek Safar <marek.safar@gmail.com>
2378 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2379 Fixed nested stories parent referencing process. Also fixes #463985.
2381 2009-01-06 Marek Safar <marek.safar@gmail.com>
2383 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2384 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2385 implementation. Also fixes #463108.
2387 2009-01-05 Marek Safar <marek.safar@gmail.com>
2389 A fix for bug #416109
2390 * decl.cs: Issue correct CLSAttribute warning location.
2392 2009-01-05 Marek Safar <marek.safar@gmail.com>
2394 A fix for bug #456775
2395 * attribute.cs: Use attribute owner scope when resolving attribute
2398 2009-01-05 Marek Safar <marek.safar@gmail.com>
2400 A fix for bug #457257
2401 * decl.cs: Fixed incorrect member declaring type comparison.
2403 2009-01-05 Marek Safar <marek.safar@gmail.com>
2405 A fix for bug #460896
2406 * driver.cs: Handle /RES resources as embeddable.
2408 2009-01-05 Marek Safar <marek.safar@gmail.com>
2410 A fix for bug #462515
2411 * ecore.cs: Report inacessible members upwards.
2413 2009-01-05 Marek Safar <marek.safar@gmail.com>
2415 A fix for bug #463190, #463192
2416 * decl.cs, namespace.cs: Also import internal extension classes.
2418 2009-01-04 Marek Safar <marek.safar@gmail.com>
2420 A fix for bug #463415
2421 * generic.cs: Use right index for RemoveDependentTypes.
2423 2009-01-02 Marek Safar <marek.safar@gmail.com>
2425 A fix for bug #463196
2426 * expression.cs: Fixed enum to null comparison.
2428 2009-01-02 Marek Safar <marek.safar@gmail.com>
2430 A fix for bug #463121
2431 * nullable.cs: Fixed nullable user equality operator comparison.
2433 2009-01-02 Marek Safar <marek.safar@gmail.com>
2435 A fix for bug #462950
2436 * class.cs, decl.cs: Use full explicit name when defining automatic
2437 property backing field.
2439 2009-01-02 Marek Safar <marek.safar@gmail.com>
2441 A fix for bug #462592
2442 * pending.cs: Emit type arguments for generic proxy method.
2444 2008-12-30 Marek Safar <marek.safar@gmail.com>
2446 * expression.cs (As): Mutate all type arguments.
2448 2008-12-29 Marek Safar <marek.safar@gmail.com>
2450 A fix for bug #462622
2451 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2454 2008-12-29 Marek Safar <marek.safar@gmail.com>
2456 A fix for bug #450782
2457 * ecore.cs: Consider more variables of form V.I to be fixed.
2459 2008-12-29 Marek Safar <marek.safar@gmail.com>
2461 A fix for bug #460712
2462 * typemanager.cs: Core types could be imported.
2464 2008-12-28 Marek Safar <marek.safar@gmail.com>
2466 A fix for bugs #460847, #460772, #458049, #457339, #447807
2467 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2468 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2469 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2470 user lambdas used inside query clauses.
2472 2008-12-18 Marek Safar <marek.safar@gmail.com>
2474 A fix for bug #460229
2475 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2477 2008-12-18 Marek Safar <marek.safar@gmail.com>
2479 A fix for bug #459952
2480 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2482 2008-12-18 Marek Safar <marek.safar@gmail.com>
2484 A fix for bug #459630
2485 * convert.cs: Enum to valuetype conversion is not allowed.
2487 2008-12-18 Marek Safar <marek.safar@gmail.com>
2489 A fix for bug #457087
2490 * generic.cs: Don't crash when constraint comes from type
2493 2008-12-16 Marek Safar <marek.safar@gmail.com>
2495 A fix for bug #459221
2496 * anonymous.cs, statement.cs: Delay only captured this
2499 2008-12-12 Marek Safar <marek.safar@gmail.com>
2501 A fix for bug #457489
2502 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2503 and initialization to capture scope initializers correctly.
2505 2008-12-11 Marek Safar <marek.safar@gmail.com>
2507 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2508 ParameterReference refactoring.
2510 2008-12-03 Marek Safar <marek.safar@gmail.com>
2512 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2513 to be imported from any assembly.
2515 2008-12-03 Marek Safar <marek.safar@gmail.com>
2517 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2518 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2519 from anonymous method and lambda expression.
2521 2008-12-01 Marek Safar <marek.safar@gmail.com>
2523 A fix for bug #448560
2524 * expression.cs (As): Box any generic type arguments to be
2527 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2529 Add tripwire for implicit conversion bugs
2530 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2532 (MethodGroupExpr.OverloadResolve): Add sanity check between
2533 IsApplicable and VerifyArgumentsCompat.
2534 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2536 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2538 Fix build break in System.Data_test
2539 * convert.cs (ImplicitConversionExists): Move NullLiteral
2541 (ImplicitStandardConversionExists): ... here.
2543 2008-11-28 Marek Safar <marek.safar@gmail.com>
2545 * literal.cs: Emit correctly explicit null to nullable cast.
2547 2008-11-28 Marek Safar <marek.safar@gmail.com>
2549 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2552 2008-11-28 Marek Safar <marek.safar@gmail.com>
2554 A fix for bug #449005
2555 * convert.cs, nullable.cs: Use only one implicit nullable
2558 2008-11-27 Marek Safar <marek.safar@gmail.com>
2560 * convert.cs, literal.cs: More Convert cleanup is needed.
2562 2008-11-27 Marek Safar <marek.safar@gmail.com>
2564 * decl.cs, class.cs: Fixed misleading error message.
2566 2008-11-26 Marek Safar <marek.safar@gmail.com>
2568 A fix for bug #449005
2569 * nullable.cs (EmitEquality): Disable optimization for user operator
2572 2008-11-25 Marek Safar <marek.safar@gmail.com>
2574 A fix for bug #447027
2575 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2576 with context variables stored as expression instances.
2578 2008-11-25 Marek Safar <marek.safar@gmail.com>
2580 A fix for bug #447027
2581 * delegate.cs: Fixed delegate VerifyMethod logic.
2583 2008-11-24 Marek Safar <marek.safar@gmail.com>
2585 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2588 2008-11-21 Marek Safar <marek.safar@gmail.com>
2590 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2591 member type resolve to follow normal flow, instead of random
2594 2008-11-21 Marek Safar <marek.safar@gmail.com>
2596 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2599 2008-11-21 Marek Safar <marek.safar@gmail.com>
2601 * const.cs: Emit decimal array constant as literal.
2603 2008-11-20 Marek Safar <marek.safar@gmail.com>
2605 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2607 2008-11-19 Marek Safar <marek.safar@gmail.com>
2609 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2610 into real property (saves 8 MB for corlib compilation).
2612 2008-11-19 Marek Safar <marek.safar@gmail.com>
2614 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2615 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2616 generic-mcs.cs: Small cleanup of TypeArguments.
2618 2008-11-18 Marek Safar <marek.safar@gmail.com>
2620 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2621 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2622 of ConstructedType expression, renamed to GenericTypeExpr.
2624 2008-11-17 Marek Safar <marek.safar@gmail.com>
2626 A fix for bug #445303
2627 * location.cs (IsConditionalDefined): Handle undefined global
2630 2008-11-17 Marek Safar <marek.safar@gmail.com>
2632 A fix for bug #444678
2633 * expression.cs (TryReduceConstant): Always create new constant
2636 2008-11-17 Marek Safar <marek.safar@gmail.com>
2638 A fix for bug #444673
2639 * ecore.cs: Ignore open generic types when used as generic type
2642 2008-11-17 Marek Safar <marek.safar@gmail.com>
2644 A fix for bug #445458
2645 * expression.cs, cs-parser.jay: Don't crash when an expression
2648 2008-11-17 Marek Safar <marek.safar@gmail.com>
2650 A fix for bug #445464
2651 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2652 inside unbound type.
2654 2008-11-14 Jb Evain <jbevain@novell.com>
2656 * driver.cs: ignore empty -nowarn argument such as
2657 the one in -nowarn:12,13,,.
2659 2008-11-13 Marek Safar <marek.safar@gmail.com>
2661 A fix for bug #444271
2662 * anonymous.cs: Rescan parent storeys when best candidate was
2665 2008-11-13 Marek Safar <marek.safar@gmail.com>
2667 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2668 useless UnboundTypeExpression.
2670 * attribute.cs: Do check obsolete attribute on generic types.
2672 2008-11-12 Marek Safar <marek.safar@gmail.com>
2674 A fix for bugs #425680, #400139
2675 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2678 2008-11-11 Marek Safar <marek.safar@gmail.com>
2680 A fix for bug #435747
2681 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2682 compound value types assignment. Few micro optimizations added.
2684 2008-11-10 Marek Safar <marek.safar@gmail.com>
2686 A fix for bug #442610
2687 * anonymous.cs (MutateConstructor): More SRE hacking.
2689 2008-11-10 Marek Safar <marek.safar@gmail.com>
2691 A fix for bug #442579
2692 * ecore.cs: Also initialize expanded form of a method with 1 params
2695 2008-11-06 Marek Safar <marek.safar@gmail.com>
2697 * expression.cs (UnaryMutator): Do early l-side check.
2699 2008-11-05 Miguel de Icaza <miguel@novell.com>
2701 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2702 Init, otherwise we would crash later on when checking for friend
2705 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2706 Otherwise we never get any meaningful information as to what
2709 2008-11-05 Marek Safar <marek.safar@gmail.com>
2711 A fix for bug #436318
2712 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2714 2008-11-05 Miguel de Icaza <miguel@novell.com>
2716 * namespace.cs: Turns out that it was a really bad idea to hide
2717 the errors for namespaces not found here in eval mode.
2719 * eval.cs: When we process using clauses, only enter those into
2720 the list of valid using clauses after they have been validated.
2722 The above change gives the proper semantics: it does not
2723 senselessly report the same errors with broken using statements by
2724 never storing them in the first place when they are invalid.
2726 2008-11-05 Marek Safar <marek.safar@gmail.com>
2728 A fix for bug #421839
2729 * cs-parser.jay: Remove expression from coalesce rule to force lower
2730 priority than the assignment operator.
2732 2008-11-05 Marek Safar <marek.safar@gmail.com>
2734 A fix for bug #437875
2735 * nullable.cs: Compile correctly method group operand used with null
2736 coalescing operator.
2738 2008-11-04 Marek Safar <marek.safar@gmail.com>
2740 A fix for bug #434589
2741 * expression.cs (Binary): Ignore lifted conversions when at least
2742 one operand is of reference type.
2744 2008-11-04 Marek Safar <marek.safar@gmail.com>
2746 * cs-parser.jay: Better syntax error report.
2748 2008-11-03 Marek Safar <marek.safar@gmail.com>
2750 A fix for bug #436792
2751 * cs-parser.jay: Use GetLocation to access location.
2753 2008-11-03 Marek Safar <marek.safar@gmail.com>
2755 A fix for bug #440774
2756 * cs-parser.jay: Also set current_array_type when parsing local
2759 2008-11-03 Marek Safar <marek.safar@gmail.com>
2761 A fix for bug #440785
2762 * expression.cs (As): Don't resolve self modifing expression
2765 2008-11-03 Marek Safar <marek.safar@gmail.com>
2767 A fix for bug #439447
2768 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2770 2008-11-03 Marek Safar <marek.safar@gmail.com>
2772 A fix for bug #437571
2773 * cs-parser.jay: Fixes internal error for invalid expression
2776 2008-10-17 Marek Safar <marek.safar@gmail.com>
2778 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2780 2008-10-17 Marek Safar <marek.safar@gmail.com>
2782 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2784 2008-10-17 Marek Safar <marek.safar@gmail.com>
2786 * cs-tokenizer.cs: More precise cast parsing.
2788 2008-10-16 Martin Baulig <martin@ximian.com>
2790 * anonymous.cs (AnonymousMethodStorey): Put back the
2791 `hoisted_locals' hashtable and use it in EmitType().
2793 2008-10-15 Marek Safar <marek.safar@gmail.com>
2795 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2796 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2799 2008-10-14 Marek Safar <marek.safar@gmail.com>
2801 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2803 2008-10-14 Marek Safar <marek.safar@gmail.com>
2805 * statement.cs: Mutate scope initializers.
2807 2008-10-14 Marek Safar <marek.safar@gmail.com>
2809 * expression.cs: Use typeless value for This constant.
2811 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2813 2008-10-14 Marek Safar <marek.safar@gmail.com>
2815 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2818 2008-10-13 Marek Safar <marek.safar@gmail.com>
2820 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2823 2008-10-13 Marek Safar <marek.safar@gmail.com>
2825 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2826 parser and tokenizer. Fixes many ambiguities including #433258.
2828 2008-10-10 Marek Safar <marek.safar@gmail.com>
2830 * cs-parser.jay: Fixed missing accessor recovery.
2832 2008-10-10 Marek Safar <marek.safar@gmail.com>
2834 A fix for bug #433701
2835 * expression.cs: Better error message.
2837 2008-10-10 Marek Safar <marek.safar@gmail.com>
2839 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2841 * Makefile: Disabled unused debug symbols.
2843 Also fixes: #320556, #321097, #321656, #321876, #351316
2845 2008-10-09 Miguel de Icaza <miguel@novell.com>
2847 * eval.cs: rename "<interactive>" to "{interactive}", to work
2848 around a requirement in the compiler that this be a valid
2849 filename, and in Windows it is not (433886).
2851 2008-10-09 Marek Safar <marek.safar@gmail.com>
2853 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2855 2008-10-08 Marek Safar <marek.safar@gmail.com>
2857 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2858 cs-parser.jay: Generic type declaration and type arguments cleanup.
2860 2008-10-05 Marek Safar <marek.safar@gmail.com>
2862 * cs-parser.jay: Allow parsing weird array creation construct.
2864 2008-10-05 Marek Safar <marek.safar@gmail.com>
2866 * cs-parser.jay: Conflicts reduction.
2868 2008-10-04 Marek Safar <marek.safar@gmail.com>
2870 * cs-parser.jay: Conflicts reduction.
2872 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2875 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2876 property. Add a 'count' hint about the use of the shared vector.
2877 Ensure that we don't leak out dirty bits.
2878 (UsageVector.MergeChild): Throw away information about variables
2880 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2882 2008-10-03 Marek Safar <marek.safar@gmail.com>
2884 A fix for bug #431746
2885 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2886 parameters when iterator is created.
2888 2008-10-03 Marek Safar <marek.safar@gmail.com>
2890 A fix for bug #431827
2891 * expression.cs: Fixed right based pointer arithmetic operations
2894 2008-10-03 Marek Safar <marek.safar@gmail.com>
2896 A fix for bug #353779
2897 * assign.cs, expression.cs: Fixed compound assignment conversions.
2899 2008-10-02 Marek Safar <marek.safar@gmail.com>
2901 A fix for bug #375262
2902 * statement.cs: Refactor ArrayForeach to be usable with string
2903 indexer. Optimized single dimentional arrays foreach.
2905 2008-10-02 Marek Safar <marek.safar@gmail.com>
2907 A fix for bug #431255
2908 * anonymous.cs, expression.cs: Removed broken optimization.
2910 2008-10-01 Marek Safar <marek.safar@gmail.com>
2912 * anonymous.cs: Use full type parameters of parent generic
2913 containers. Removed unnecessary AddParentStoreyReference call.
2915 2008-10-01 Marek Safar <marek.safar@gmail.com>
2917 A fix for bug #324702
2918 * class.cs: Use better shorter names for explicit interface member
2921 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2923 2008-10-01 Marek Safar <marek.safar@gmail.com>
2925 * expression.cs: Use new interface to check fixed expression.
2927 2008-10-01 Marek Safar <marek.safar@gmail.com>
2929 A fix for bug #421101
2930 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2931 interface to check for fixed fixed-buffers.
2933 2008-10-01 Marek Safar <marek.safar@gmail.com>
2935 A fix for bug #429264
2936 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2938 * delegate.cs: Removed unnecessary casts.
2940 2008-09-30 Marek Safar <marek.safar@gmail.com>
2942 A fix for bug #352151
2943 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2944 class.cs: Fixed already defined explicit interface members check.
2946 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2948 cs-tokenizer.cs: Fix typo.
2950 2008-09-28 Miguel de Icaza <miguel@novell.com>
2952 * eval.cs (InteractiveBase): The quit command now just sets a
2953 flag, instead of calling Environment.Exit(), it is milder on
2956 CompiledMethod is now in Mono.CSharp, not nested inside
2957 the Evaluator, it was inconvenient to use.
2959 2008-09-27 Miguel de Icaza <miguel@novell.com>
2961 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2962 code to be invoked without having to reparse.
2964 2008-09-27 Miguel de Icaza <miguel@novell.com>
2966 * ecore.cs: The recent changes to FieldExpr broke this as well.
2967 Fixes LINQ queries in the interactive shell.
2969 * Multiple files: indentation fixing for the Mono coding
2970 guidelines for the switch statement.
2972 * eval.cs: Make the Evaluator API thread safe.
2974 2008-09-26 Marek Safar <marek.safar@gmail.com>
2976 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2977 constructor parsing.
2979 2008-09-26 Marek Safar <marek.safar@gmail.com>
2981 A fix for bug #325326
2982 * statement.cs: Check possible mistaken empty statement using
2983 explicit blocks only.
2985 2008-09-25 Miguel de Icaza <miguel@novell.com>
2987 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2988 RootNamespace.ComputeNamespaces to update the internal list of
2989 namespaces, this is no longer done for us.
2991 (InteractiveBase): Use the Evaluator APIs instead of calling into
2994 2008-09-25 Marek Safar <marek.safar@gmail.com>
2996 A fix for bug #429264
2997 * expression.cs: Missing mutator for access to multidimensional
3000 2008-09-25 Marek Safar <marek.safar@gmail.com>
3002 * class.cs, statement: Emit DebuggerHidden attribute for iterator
3005 * driver.cs: Missing input argument check.
3007 2008-09-25 Marek Safar <marek.safar@gmail.com>
3009 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
3010 expression.cs, statement.cs, rootcontext.cs, class.cs,
3011 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
3014 2008-09-24 Miguel de Icaza <miguel@novell.com>
3016 * ecore.cs (FieldExpr): Only initialize eclass when we return a
3017 fully constructed FieldExpr, fixes the regression introduced in
3020 * ecore.cs, expression.cs: Plug back the eclass initialization as
3021 otherwise it regresses `csharp'.
3023 2008-09-24 Marek Safar <marek.safar@gmail.com>
3025 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
3026 ecore.cs, attribute.cs: Moved obsolete method checks from emit
3027 phase to resolve phase. It resolves problems with expression trees
3028 and fixes bugs #323796, #325156.
3030 2008-09-23 Marek Safar <marek.safar@gmail.com>
3032 * codegen.cs: Report better error when symbol writer is missing.
3034 2008-09-23 Marek Safar <marek.safar@gmail.com>
3036 * codegen.cs: Set .NET symbol writer.
3038 * decl.cs: Guard against null generic arguments.
3040 * report.cs: Don't report exactly same additional details.
3042 2008-09-22 Marek Safar <marek.safar@gmail.com>
3044 A fix for bug #324917
3045 * cs-parser.jay: Add missing multidimensional non-expression type
3048 2008-09-22 Marek Safar <marek.safar@gmail.com>
3050 A fix for bug #428191
3051 * anonymous.cs: Create an outer generic fields also for non-storey
3054 2008-09-22 Marek Safar <marek.safar@gmail.com>
3056 A fix for bug #378294
3057 * class.cs: Make fixed size buffers gmcs feature only.
3059 2008-09-22 Marek Safar <marek.safar@gmail.com>
3061 A fix for bug #355622, #324993
3062 * assign.cs, const.cs, class.cs: Create new EmitContext for each
3065 2008-09-19 Marek Safar <marek.safar@gmail.com>
3067 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
3070 2008-09-19 Marek Safar <marek.safar@gmail.com>
3072 A fix for bug #416110
3073 * generic.cs: Struct constraint results in default ctor and
3074 ValueType base type constraint to be set.
3076 2008-09-19 Marek Safar <marek.safar@gmail.com>
3078 A fix for bug #423791
3079 * generic.cs: Fixed params output type type-inference.
3081 2008-09-19 Marek Safar <marek.safar@gmail.com>
3083 * cs-parser.jay, expression.cs: Fixed few expression crashes.
3085 2008-09-19 Marek Safar <marek.safar@gmail.com>
3087 * cs-tokenizer.cs: Don't break on extra partial modifier.
3089 2008-09-19 Marek Safar <marek.safar@gmail.com>
3091 A fix for bug #427592
3092 * generic.cs: Use common parameter resolve method.
3094 2008-09-18 Marek Safar <marek.safar@gmail.com>
3096 A fix for bug #414758
3097 * expression.cs, ecore.cs: Fixed crash when accessing non-static
3100 2008-09-18 Marek Safar <marek.safar@gmail.com>
3102 * driver.cs, namespace.cs: Read types and namespaces after all
3103 requested assemblies are loaded, fixes issues with System.Core
3104 auto-reference, and #419888.
3106 2008-09-18 Marek Safar <marek.safar@gmail.com>
3108 A fix for bug #417705
3109 * cs-parser.jay: Fixed as/is operator expression split.
3111 2008-09-18 Marek Safar <marek.safar@gmail.com>
3113 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
3114 Fixed expression tree representation of empty new expression and
3115 new initializer expression.
3117 2008-09-18 Miguel de Icaza <miguel@novell.com>
3119 * eval.cs: Remove warning, keep reference to driver around.
3121 * Hide fields that do not need to be public.
3123 2008-09-17 Marek Safar <marek.safar@gmail.com>
3125 A fix for bug #426385
3126 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
3127 conversion for array elements.
3129 2008-09-17 Marek Safar <marek.safar@gmail.com>
3131 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
3132 void parsing conflicts.
3134 2008-09-15 Marek Safar <marek.safar@gmail.com>
3136 A fix for bug #425601
3137 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
3138 System.Core only when there is no custom ExtensionAttribute
3141 2008-09-15 Miguel de Icaza <miguel@novell.com>
3143 * namespace.cs: Do not report CS0246 (name
3145 2008-09-12 Marek Safar <marek.safar@gmail.com>
3147 A fix for bug #425669
3148 * generic.cs: Don't cache generic static anonymous method
3151 2008-09-12 Marek Safar <marek.safar@gmail.com>
3153 * generic.cs, class.cs, delegate.cs: Check recursive inherited
3154 conflicting constraints.
3156 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
3158 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
3161 2008-09-12 Marek Safar <marek.safar@gmail.com>
3163 * literal.cs, convert.cs, expression.cs, statement.cs: More null
3164 to null pointer conversion fixes.
3166 2008-09-11 Marek Safar <marek.safar@gmail.com>
3168 * cs-parser.jay, expression.cs: An implicitly typed local variable
3169 declarator cannot use an array initializer.
3171 2008-09-11 Marek Safar <marek.safar@gmail.com>
3173 * cs-parser.jay: Reduced number of printed tokens, add sorting.
3175 2008-09-11 Marek Safar <marek.safar@gmail.com>
3177 * generic.cs (InflatedConstraints): Don't crash when constraints
3180 * cs-parser.jay: const_declarator is a block.
3182 * constant.cs: Check for not allowed NaN conversions.
3184 2008-09-10 Miguel de Icaza <miguel@novell.com>
3186 * driver.cs: Drop --shell argument, the compiler is no longer a
3189 * eval.cs: Move most of the code that deals with evaluation into
3190 this file and document the public API from repl.cs
3192 * repl.cs: Remove from here.
3194 2008-09-10 Marek Safar <marek.safar@gmail.com>
3196 A fix for bug #424684
3197 * generic.cs: Generic class constraints must come first.
3199 2008-09-09 Miguel de Icaza <miguel@novell.com>
3201 * cs-parser.jay: Improve error reporting for syntax errors in
3202 statements and expressions, we now report the expected tokens
3203 instead of reporting the useless "; expected".
3205 Drop the strings from the token declaration, it turns out that
3206 they did not do what I thought they did. Instead they were adding
3207 two sets of tokens to the tables.
3209 2008-09-09 Marek Safar <marek.safar@gmail.com>
3211 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3212 delegate.cs: Share special type check.
3214 2008-09-09 Marek Safar <marek.safar@gmail.com>
3216 A fix for bug #423981
3217 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3219 2008-09-09 Marek Safar <marek.safar@gmail.com>
3221 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3224 2008-09-09 Marek Safar <marek.safar@gmail.com>
3226 A fix for bugs: #324750, #335946
3227 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3228 lookup rule to determine ?-based tokens.
3230 2008-09-08 Miguel de Icaza <miguel@novell.com>
3232 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3233 expressions (like event adding or removing) end up here, so we
3234 need to treat those as statements.
3236 Add LoadAssembly method.
3238 2008-09-04 Miguel de Icaza <miguel@novell.com>
3240 * repl.cs: Add Time method.
3242 2008-09-05 Marek Safar <marek.safar@gmail.com>
3244 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3246 2008-09-05 Miguel de Icaza <miguel@novell.com>
3248 * repl.cs: Add workaround for old compilers.
3250 2008-09-04 Jb Evain <jbevain@novell.com>
3252 * repl.cs (PrettyPrint): pretty print everything that
3253 implements IDictionary, as well as IEnumerables. Also,
3254 add a quit helper property.
3256 2008-09-04 Marek Safar <marek.safar@gmail.com>
3258 * constant.cs: Better error reporting for decimal literals.
3260 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3263 2008-09-04 Marek Safar <marek.safar@gmail.com>
3264 Miguel de Icaza <miguel@novell.com>
3266 A fix for bug #422951
3267 * assign.cs (Assign.DoResolve): Perform the type conversions
3268 checks before we attempt to initialize `New' initializers.
3270 2008-09-04 Marek Safar <marek.safar@gmail.com>
3272 A fix for bug #422853
3273 * delegate.cs (DelegateCreation): Add special handling for
3274 EmptyExpression.Null instance expression which is just another
3275 hack for undecided member instance exression.
3277 2008-09-04 Marek Safar <marek.safar@gmail.com>
3279 * expression.cs, ecore.cs: Emit full expression tree for reduced
3282 2008-09-04 Marek Safar <marek.safar@gmail.com>
3284 * expression.cs (This): Guard against multi-resolving.
3286 * ecore.cs, statement.cs (Throw): Simplified.
3288 * flowanalysis.cs: Also verify event fields.
3290 2008-09-04 Miguel de Icaza <miguel@novell.com>
3292 * assign.cs (Assign.DoResolve): Perform the type conversions
3293 checks before we attempt to initialize `New' initializers.
3295 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3297 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3300 * repl.cs: Update help.
3302 2008-09-03 Miguel de Icaza <miguel@novell.com>
3304 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3305 handling of the default config handling, including the special
3306 treatment of System.Core assembly.
3308 Fixes the REPL processing for LINQ.
3310 2008-09-03 Marek Safar <marek.safar@gmail.com>
3312 A fix for bug #422507
3313 * expression.cs (UnboxCast): Add missing child expression mutator.
3315 2008-09-03 Marek Safar <marek.safar@gmail.com>
3317 * driver.cs: Don't self reference System.Core assembly.
3319 2008-09-03 Marek Safar <marek.safar@gmail.com>
3321 A fix for bug #422507
3322 * expression.cs (StringConcat): Add missing type mutator.
3324 2008-09-03 Marek Safar <marek.safar@gmail.com>
3326 * generic.cs (TypeInferenceContext): Follow equality rule for
3327 constructed type lower bound type inference.
3329 2008-09-02 Miguel de Icaza <miguel@novell.com>
3331 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3332 <dblank@cs.brynmawr.edu> which updates the cursor position on
3335 2008-09-02 Marek Safar <marek.safar@gmail.com>
3337 A fix for bug #367145
3338 * driver.cs: Fixed import of extension methods when using -noconfig
3341 2008-09-02 Marek Safar <marek.safar@gmail.com>
3343 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3344 version from non-generic implementation instead.
3346 2008-09-01 Marek Safar <marek.safar@gmail.com>
3348 A fix for bug #418908
3349 * class.cs: Use AddScopeStatement for field initializers.
3351 2008-09-01 Marek Safar <marek.safar@gmail.com>
3353 A fix for bug #415385
3354 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3356 2008-09-01 Marek Safar <marek.safar@gmail.com>
3358 A fix for bug #421736
3359 * iterators.cs: Don't crash on unreachable iterators.
3361 2008-09-01 Marek Safar <marek.safar@gmail.com>
3363 A fix for bug #421628
3364 * parameter.cs, attribute.cs: Clone also parameter attributes.
3366 2008-08-30 Miguel de Icaza <miguel@novell.com>
3368 * namespace.cs (LookupType): In EvalMode, try to replace
3369 the TypeBuilder from our cache with a Type as Reflection.Emit does
3370 not like to mix code from older assemblies emitted and new
3373 This sounds like a serious Mono bug that prevents multiple
3374 assemblies to be generated and consumed at the same time.
3376 * cs-parser.jay (push_current_class): Do not make interactive
3377 classes internal or private, make them public as we currently
3378 generate each new class in a new assembly.
3380 2008-08-29 Miguel de Icaza <miguel@novell.com>
3382 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3383 remove types that are entered into the global namespace during
3384 parsing so that we can remove them on failure.
3386 * cs-parser.jay: Parsing: we now keep track of types that are
3387 entered into global variables and queue those in case the parsing
3390 This happens in a few situations: during partial-input, we invoke
3391 the parser repeatedly for example with the string "class X", this
3392 would cause X to be registed, and we need to remove this
3393 registration so that another parse attempt later with say "class X {"
3394 would actually work.
3396 Additionally, if there is an error in the resolution phase, for
3397 example: "class X : NonExistant {}" th
3399 * cs-parser.jay: Be more precise with the errors being raised,
3400 instead of flagging all exceptions during parsing to be attributed
3401 to the parsing process, distinguish those from errors happening in
3402 the actions and hint that using -v would produce the actual
3405 * repl.cs: Do not load all compiler references on each reset,
3406 doing the partial reset takes care of this.
3408 2008-08-28 Miguel de Icaza <miguel@novell.com>
3410 * repl.cs: Add support for loading all the files from
3411 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3414 Introduce a micro-parser that is able to deambiguate on its input
3415 whether we are dealing with a compilation unit (namespace, class,
3416 interface, struct, delegate) declaration or a statement. This
3417 allows both declarations and statements to be entered.
3419 Set history size by default to 300 lines.
3421 Instead of distinguishing based on the parser.InteractiveResult,
3422 have only two cases: statements were parsed, or a compilation unit
3423 was. Always pull the Using statement additions from the
3424 compilation unit parse.
3426 * cs-tokenizer.cs: Rename tokens to better describe their intent
3427 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3429 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3430 EvalMode is used to trigger the lookup of global variables while
3431 StatementMode is used turn variable declarations into static
3434 * getline.cs: Allow history size to be set.
3436 2008-08-29 Marek Safar <marek.safar@gmail.com>
3438 A fix for bug #360755
3439 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3441 2008-08-29 Marek Safar <marek.safar@gmail.com>
3443 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3445 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3446 member name, it is too confusing
3448 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3450 * rootcontext.cs: Finally default to warning level 4.
3452 2008-08-28 Marek Safar <marek.safar@gmail.com>
3454 * class.cs (CheckBase): Ignore overloaded operators.
3456 2008-08-28 Marek Safar <marek.safar@gmail.com>
3458 A fix for bug #420830
3459 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3461 2008-08-28 Marek Safar <marek.safar@gmail.com>
3463 A fix for bug #420832
3464 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3466 2008-08-28 Marek Safar <marek.safar@gmail.com>
3468 A fix for bug #420386
3469 * nullables.cs: Fixed logic of nullable user comparison operators involving
3472 2008-08-28 Marek Safar <marek.safar@gmail.com>
3474 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3476 2008-08-27 Miguel de Icaza <miguel@novell.com>
3478 * repl.cs: Add support for aborting the running code with C-c.
3480 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3482 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3484 2008-08-27 Miguel de Icaza <miguel@novell.com>
3486 * cs-parser.jay (interactive_statement_list): A new set of rules
3487 for hosting statements that uses the "interactive_" prefix.
3489 * repl.cs: Add support for parsing `using' as a statement or as a
3490 directive. Deambiguating before passing this to the parser.
3492 We need to distinguish statement_expressions that occur at the
3493 toplevel vs those that occur embedded into expressions.
3495 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3496 that fixes the cursor key handling, and a history bug.
3498 2008-08-26 Miguel de Icaza <miguel@novell.com>
3500 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3501 limitations in Console, instead the 2.0 bootstrap libraries now
3502 include the Console bits.
3504 Also, remove the use of Nullables from getline.cs
3508 Interactive support for the C# compiler. Use gmcs --shell to
3509 enter a read-eval-print loop shell.
3511 Docs: http://www.mono-project.com/CsharpRepl
3513 * sources: include repl.cs here and getline.cs for gmcs.exe,
3514 everything else is getline.cs impaired.
3516 * Makefile: when bootstrapping pass a special flag
3517 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3518 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3519 This distinguishes those two cases.
3521 * repl.cs: Support for a read-eval-print loop. Will be soon
3522 refactored into eval support and then REPL on top of it.
3524 * ecore.cs: If a simplename lookup fails, before erroring out,
3525 if we are in EvalMode to resolve the name to a declaration in the
3528 This means that variable declarations that happened in previous
3529 classes (as repl puts every statement in a separate class) are
3530 made visible in this way.
3532 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3533 triggered an error due to the end of file being reached. This is
3534 used to do multi-line input, and notify the caller that the user
3535 needs to provide more text before a successful parse.
3537 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3538 to drive the evaluation with a custom wrapper.
3540 * driver.cs: Add support for --shell, and refactor some code to be
3543 * namespace.cs: Add support for serializing the contents of the
3544 namespaces and reloading them.
3546 * getline.cs: A managed implementation of ReadLine under
3547 X11/Apache2 license terms. Easy to embed in other applications as
3550 * namespace.cs: Add some functions to save and restore the
3553 * rootcontext.cs: New public field.
3555 * cs-tokenizer.cs: Add support for one of the possible characters
3556 we introduce into the token stream.
3558 This patch does not affect the regular tokenization process, the
3559 only performance hit would happen if there is an invalid character
3560 on the input string.
3562 * support.cs: Move isatty helper routine here.
3564 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3565 code generator for in-memory assemblies.
3567 2008-08-26 Marek Safar <marek.safar@gmail.com>
3569 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3570 parameter cannot be always used as a type.
3572 2008-08-21 Marek Safar <marek.safar@gmail.com>
3574 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3576 2008-08-21 Marek Safar <marek.safar@gmail.com>
3578 * convert.cs: Implement explicit array to IList<T> conversion.
3580 2008-08-20 Marek Safar <marek.safar@gmail.com>
3582 A fix for bug #362740
3583 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3585 2008-08-20 Marek Safar <marek.safar@gmail.com>
3587 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3588 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3589 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3590 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3591 handling to use just one type of infrastructure and deal with generics
3594 2008-07-23 Martin Baulig <martin@ximian.com>
3596 *** Merged this from trunk revision 108527 ***
3599 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3600 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3603 2008-08-15 Marek Safar <marek.safar@gmail.com>
3605 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3608 2008-08-15 Marek Safar <marek.safar@gmail.com>
3610 * delegate.cs: Fixed compiler crash when creating delegate using partial
3613 * typemanager.cs: MulticastDelegate is not a delegate.
3615 2008-08-14 Marek Safar <marek.safar@gmail.com>
3617 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3620 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3622 * cs-parser.jay (type): Allow 'var' in mcs too.
3623 (local_variable_type): Likewise.
3625 2008-08-14 Marek Safar <marek.safar@gmail.com>
3627 * driver.cs: Removed broken -noconfig variants.
3629 2008-08-14 Marek Safar <marek.safar@gmail.com>
3631 A fix for bug #417078
3632 * expression.cs: Emit correctly left side pointer operators.
3634 2008-08-13 Marek Safar <marek.safar@gmail.com>
3636 * generic.cs, lambda.cs: Inflate method generic arguments only.
3638 2008-08-12 Marek Safar <marek.safar@gmail.com>
3640 * class.cs: Fixed struct layout check regression.
3642 2008-08-12 Marek Safar <marek.safar@gmail.com>
3644 * cs-parser.jay, enum.cs: Simplified enum parsing.
3646 * decl.cs: Check all type parameters conflicts.
3648 * expression.cs, statement.cs, attribute.cs: More expression checks.
3650 2008-08-11 Marek Safar <marek.safar@gmail.com>
3652 * generic.cs: Add type inference types restriction.
3654 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3655 anonymous.cs, expression.cs: Allocate less accessor parameters.
3657 2008-08-08 Marek Safar <marek.safar@gmail.com>
3659 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3662 2008-08-08 Marek Safar <marek.safar@gmail.com>
3664 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3666 2008-08-07 Marek Safar <marek.safar@gmail.com>
3668 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3669 Also fixes #362146 and #381592.
3671 2008-08-07 Marek Safar <marek.safar@gmail.com>
3673 * ecore.cs: Reduced constant cannot be used as an attribute value.
3675 * cs-parser.jay: Base expression has to be a type.
3677 * expression.cs (Conditional): Uses ReducedExpression.
3679 2008-08-06 Marek Safar <marek.safar@gmail.com>
3681 A fix for bug #376826
3682 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3683 address of hoisted local variable or parameter cannot be taken.
3685 2008-08-05 Marek Safar <marek.safar@gmail.com>
3687 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3688 anonymous method inside checked/unchecked expression.
3690 2008-08-05 Marek Safar <marek.safar@gmail.com>
3692 * typemanager.cs (IsEqual): Guard against null.
3694 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3695 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3696 routine. Fixed few misleading conversion errors.
3698 2008-08-04 Marek Safar <marek.safar@gmail.com>
3700 * class.cs: Consider generics when checking cycles in struct layout.
3702 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3704 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3706 2008-08-04 Marek Safar <marek.safar@gmail.com>
3708 A fix for bug #414165
3709 * anonymous.cs: Use same anonymous implementation method for all anonymous
3712 2008-08-04 Marek Safar <marek.safar@gmail.com>
3714 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3717 2008-08-04 Marek Safar <marek.safar@gmail.com>
3719 * cs-parser.jay: Typeof argument has to be a type expression.
3721 * namespace.cs: Check alias and namespace definitions collisions.
3723 * class.cs, pending.cs: Moved explicit interface accessor implementation
3726 * delegate.cs, expression.cs: Verify special name invocations.
3728 2008-08-01 Marek Safar <marek.safar@gmail.com>
3730 * cs-parser.jay: Don't choke on empty generic type arguments.
3732 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3734 * expression.cs, ecore.cs: Minor expressions bugs.
3736 2008-08-01 Marek Safar <marek.safar@gmail.com>
3738 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3739 and added more error handling.
3741 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3743 * modifiers.cs, enum.cs: Fixed.
3745 2008-07-31 Jb Evain <jbevain@novell.com>
3747 * driver.cs: remove -pkg ability of smcs.
3749 2008-07-30 Marek Safar <marek.safar@gmail.com>
3751 * statement.cs (Switch): Correctly set empty default target for single
3754 2008-07-30 Marek Safar <marek.safar@gmail.com>
3756 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3757 string switch statement implementation to use string dictionary which
3758 significantly (2-8x) improves performance of generated code.
3760 2008-07-29 Marek Safar <marek.safar@gmail.com>
3762 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3763 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3765 2008-07-29 Marek Safar <marek.safar@gmail.com>
3767 A fix for bug #412595
3768 * typemanager.cs, convert.cs, expression.cs: Some types are never
3769 convertible to each other.
3771 2008-07-29 Marek Safar <marek.safar@gmail.com>
3773 * nullable.cs (CreateNullConstant): An error messages update.
3775 2008-07-29 Marek Safar <marek.safar@gmail.com>
3777 A fix for bug #412595
3778 * cfold.cs: Don't cast undefined bool constant.
3780 2008-07-29 Martin Baulig <martin@ximian.com>
3783 (SymbolWriter.Reset): New public static method.
3786 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3788 2008-07-28 Marek Safar <marek.safar@gmail.com>
3790 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3792 * expression.cs (ElementAccess): Exact size allocation.
3794 2008-07-26 Marek Safar <marek.safar@gmail.com>
3796 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3798 2008-07-25 Marek Safar <marek.safar@gmail.com>
3800 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3802 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3805 2008-07-25 Marek Safar <marek.safar@gmail.com>
3807 A fix for bug #412217
3808 * assign.cs: Mutate also assignment type.
3810 2008-07-25 Marek Safar <marek.safar@gmail.com>
3812 A fix for bug #323644
3813 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3816 2008-07-25 Marek Safar <marek.safar@gmail.com>
3818 A fix for bug #412134
3819 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3820 non-enumerable operands when overloading equality or bitwise operators.
3822 2008-07-25 Marek Safar <marek.safar@gmail.com>
3824 * anonymous.cs: Cache closed generic anonymous method delegates.
3826 2008-07-24 Marek Safar <marek.safar@gmail.com>
3828 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3829 anonymous.cs, statement.cs: Always emit anonymous method as static method
3830 when is instance free. Use nesting for nested anynomous methods blocks.
3832 2008-07-23 Marek Safar <marek.safar@gmail.com>
3834 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3837 2008-07-23 Marek Safar <marek.safar@gmail.com>
3839 * expression.cs: Removed MakeSimpleCall.
3841 2008-07-23 Marek Safar <marek.safar@gmail.com>
3843 A fix for bug #323012
3844 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3845 Base method implementing interface has to be public.
3847 2008-07-23 Marek Safar <marek.safar@gmail.com>
3849 * cs-parser.jay: Don't break on missing argument.
3851 2008-07-22 Marek Safar <marek.safar@gmail.com>
3853 A fix for bug #320993
3854 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3855 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3857 2008-07-22 Marek Safar <marek.safar@gmail.com>
3859 A fix for bug #320748
3860 * convert.cs: Implicit user operators cannot convert to interfaces
3862 2008-07-22 Marek Safar <marek.safar@gmail.com>
3864 A fix for bug #312686
3865 * driver.cs: Ignore empty assembly references.
3867 2008-07-22 Marek Safar <marek.safar@gmail.com>
3869 A fix for bug #387040
3870 * ecore.cs: Skip constrains check for an explicit implementation.
3872 2008-07-21 Marek Safar <marek.safar@gmail.com>
3874 A fix for bug #409045
3875 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3876 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3877 identifiers are file specific unless passed as input arguments.
3879 2008-07-21 Marek Safar <marek.safar@gmail.com>
3881 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3882 to emit UnmanagedMarshal data under 2.0 profile.
3884 2008-07-21 Marek Safar <marek.safar@gmail.com>
3886 A fix for bug #410369
3887 * parameter.cs: Clone correctly ParamsParameter.
3889 2008-07-21 Marek Safar <marek.safar@gmail.com>
3891 * expression.cs (Argument): Always report type for type based expressions
3894 2008-07-18 Marek Safar <marek.safar@gmail.com>
3896 A fix for bug #410666
3897 * anonymous.cs: Correctly initialize generic storey reference.
3899 2008-07-18 Marek Safar <marek.safar@gmail.com>
3901 * convert.cs: Don't box same type arguments.
3903 2008-07-18 Marek Safar <marek.safar@gmail.com>
3905 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3906 Finished missing generic type mutators.
3908 2008-07-18 Marek Safar <marek.safar@gmail.com>
3910 * iterators.cs, statement.cs: Finished statements CloneTo.
3912 2008-07-18 Marek Safar <marek.safar@gmail.com>
3914 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3916 * expression.cs: Emit optimized default value expressions in expression tree
3919 2008-07-18 Marek Safar <marek.safar@gmail.com>
3921 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3923 2008-07-17 Marek Safar <marek.safar@gmail.com>
3925 A fix for bug #367536
3926 * cs-parser.jay: Check static constructor of generic types for an access
3929 2008-07-17 Marek Safar <marek.safar@gmail.com>
3931 A fix for bug #353800
3932 * lambda.cs: Emit ret for contextual statements.
3934 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3935 up emitting redundant ret for all anonymous methods with return.
3937 2008-07-17 Marek Safar <marek.safar@gmail.com>
3939 A fix for bug #365188
3940 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3941 create anonymous method storey in unreachable block.
3943 2008-07-17 Marek Safar <marek.safar@gmail.com>
3945 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3946 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3947 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3948 statement.cs: Fixed relevant defects found by Gendarme.
3950 2008-07-17 Marek Safar <marek.safar@gmail.com>
3952 A fix for bug #325291
3953 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3954 statement.cs: Replaced IAnonymousHost with top level block flag.
3956 2008-07-17 Marek Safar <marek.safar@gmail.com>
3958 * cs-parser.jay: Clean up unused open_parens.
3960 2008-07-17 Marek Safar <marek.safar@gmail.com>
3962 * ecore.cs: Custom error message for a range variable assignment.
3964 2008-07-16 Marek Safar <marek.safar@gmail.com>
3966 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3969 2008-07-16 Marek Safar <marek.safar@gmail.com>
3971 * literal.cs: Null literal is of object type.
3973 2008-07-16 Marek Safar <marek.safar@gmail.com>
3975 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3976 expression of nullable equality comparison.
3978 2008-07-15 Marek Safar <marek.safar@gmail.com>
3980 * expression.cs(PointerArithmetic): Removed redundant assignment.
3982 2008-07-15 Marek Safar <marek.safar@gmail.com>
3984 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3986 2008-07-14 Marek Safar <marek.safar@gmail.com>
3988 A fix for bug #408361
3989 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3990 they are replaced by GetMethod.
3992 2008-07-14 Marek Safar <marek.safar@gmail.com>
3994 A fix for bug #408721 by jeremie.laval@gmail.com
3995 * expression.cs (Indirection): Implemented CloneTo.
3997 2008-07-14 Marek Safar <marek.safar@gmail.com>
3999 * statement.cs (AssignableSlots): Temporary disabled variable initialization
4002 2008-07-14 Marek Safar <marek.safar@gmail.com>
4004 * report.cs (EnableReporting): Don't reinitialize 0-based values.
4006 2008-07-11 Marek Safar <marek.safar@gmail.com>
4008 * linq.cs: Reset tranparent parameter counter in probing mode.
4010 2008-07-11 Marek Safar <marek.safar@gmail.com>
4012 * anonymous.cs: Mutate anonymous method type.
4014 2008-07-11 Marek Safar <marek.safar@gmail.com>
4016 * ecore.cs, anonymous.cs: Mutate field expressions.
4018 2008-07-10 Marek Safar <marek.safar@gmail.com>
4020 A fix for bug #369670
4021 * linq.cs, statement.cs: Use explicit block for query expressions variables.
4023 2008-07-10 Marek Safar <marek.safar@gmail.com>
4025 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
4027 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
4030 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
4031 only one '>', and finds a '>>', abort the generic lookahead.
4033 2008-07-10 Marek Safar <marek.safar@gmail.com>
4035 A fix for bug #319902
4036 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
4038 2008-07-10 Marek Safar <marek.safar@gmail.com>
4040 A fix for bug #406371
4041 * statement.cs: Moved EmitSymbolInfo to Block.
4043 2008-07-09 Marek Safar <marek.safar@gmail.com>
4045 * ecore.cs: Report better error for extension method overload failures.
4047 2008-07-09 Marek Safar <marek.safar@gmail.com>
4049 * expression.cs (Is): No need to box reference values.
4051 2008-07-09 Marek Safar <marek.safar@gmail.com>
4053 * class.cs: Use event resolve context when initializing CreateEmitContext.
4055 2008-07-09 Marek Safar <marek.safar@gmail.com>
4057 A fix for bug #394436
4058 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
4059 method used inside expression trees. Added more LINQ to expression tree
4062 2008-07-08 Marek Safar <marek.safar@gmail.com>
4064 A fix for bug #378189, #370577
4065 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
4068 2008-07-08 Marek Safar <marek.safar@gmail.com>
4070 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
4073 2008-07-08 Marek Safar <marek.safar@gmail.com>
4075 A fix for bug #406702
4076 * anonymous.cs: Always park anonymous method in the nearest parent storey.
4078 2008-07-07 Marek Safar <marek.safar@gmail.com>
4080 A fix for bug #406648
4081 * cs-parser.jay: Report nullable use in mcs for some cases.
4083 2008-07-07 Marek Safar <marek.safar@gmail.com>
4085 * ecore.cs: Improved argument mismatch error messages.
4087 2008-07-07 Marek Safar <marek.safar@gmail.com>
4089 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
4091 2008-07-07 Marek Safar <marek.safar@gmail.com>
4093 * expression.cs (TypeOf): Mutate type argument.
4095 2008-07-04 Marek Safar <marek.safar@gmail.com>
4097 * class.cs: Report missing partial modifier for correct type.
4099 2008-07-04 Marek Safar <marek.safar@gmail.com>
4101 * ecore.cs, expression.cs (VariableReference): Variable property is
4104 2008-07-04 Marek Safar <marek.safar@gmail.com>
4106 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
4108 2008-07-04 Marek Safar <marek.safar@gmail.com>
4110 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
4113 2008-07-04 Marek Safar <marek.safar@gmail.com>
4115 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
4116 anonymous method storey to an instance method when only "this" is hoisted.
4118 2008-07-03 Marek Safar <marek.safar@gmail.com>
4120 A fix for bug #321615
4121 * expression.cs: Pointer comparisons use unsigned operator.
4123 2008-07-03 Marek Safar <marek.safar@gmail.com>
4125 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
4127 2008-07-02 Marek Safar <marek.safar@gmail.com>
4129 A fix for bug #404905
4130 * class.cs: Always initialize local unsafe variables.
4132 2008-06-30 Marek Safar <marek.safar@gmail.com>
4134 A fix for bug #396987
4135 * expression.cs (NewInitialize): Clear local temporary variable for next run
4137 2008-06-27 Marek Safar <marek.safar@gmail.com>
4139 A fix for bug #401020
4140 * ecore.cs: Both types and modifiers have to match for ref and out arguments
4142 2008-06-27 Marek Safar <marek.safar@gmail.com>
4144 A fix for bug #398319
4145 * cs-parser.jay: Implemented undocumented base access expression inside
4148 2008-06-26 Marek Safar <marek.safar@gmail.com>
4150 A fix for bug #404227
4151 * cs-parser.jay: Parse namespace declaration using qualified identifier.
4153 2008-06-26 Marek Safar <marek.safar@gmail.com>
4155 A fix for bug #404227
4156 * convert.cs: Fixed explicit array to interface cast.
4158 2008-06-26 Marek Safar <marek.safar@gmail.com>
4160 A fix for bug #403894
4161 * delegate.cs: Mutate DelegateInvocation type.
4163 2008-06-26 Marek Safar <marek.safar@gmail.com>
4165 A fix for bug #379348
4166 * delegate.cs: Box a load of generic parameters.
4168 2008-06-26 Marek Safar <marek.safar@gmail.com>
4170 * expression.cs: Add an array creation arguments mutate.
4172 2008-06-26 Marek Safar <marek.safar@gmail.com>
4174 A fix for bug #386068
4175 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
4178 2008-06-25 Marek Safar <marek.safar@gmail.com>
4180 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4183 2008-06-25 Marek Safar <marek.safar@gmail.com>
4185 A fix for bug #403518
4186 * delegate.cs: Type correctly anonymous method new invocation.
4188 2008-06-24 Marek Safar <marek.safar@gmail.com>
4190 A fix for bug #394826
4191 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4194 2008-06-24 Marek Safar <marek.safar@gmail.com>
4196 A fix for bug #394826
4197 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4200 2008-06-24 Marek Safar <marek.safar@gmail.com>
4202 * class.cs: Clone indexer parameters for localized capturing.
4204 2008-06-24 Marek Safar <marek.safar@gmail.com>
4206 A fix for bug #402379
4207 * expression.cs: Don't crash when an object initializer resolve fails.
4209 2008-06-24 Marek Safar <marek.safar@gmail.com>
4211 A fix for bug #402888
4212 * expression.cs: Mutate conditional expression.
4214 2008-06-24 Marek Safar <marek.safar@gmail.com>
4216 A fix for bug #401012
4217 * class.cs: Keep StructLayout in shared container.
4219 2008-06-24 Marek Safar <marek.safar@gmail.com>
4221 A fix for bug #400438
4222 * decl.cs, class.cs: Only properties can be automatically implemented.
4224 2008-06-24 Marek Safar <marek.safar@gmail.com>
4226 * statement.cs (ChangeToIterator): Copy also labels.
4228 2008-06-23 Marek Safar <marek.safar@gmail.com>
4230 * ecore.cs: Pass type argument details to parent extension method.
4232 2008-06-23 Marek Safar <marek.safar@gmail.com>
4234 A fix for bug #375966
4235 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4237 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4239 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4241 2008-06-22 Marek Safar <marek.safar@gmail.com>
4243 A fix for bug #394347
4244 * anonymous.cs: Cache compatible delegates as compatibility check produces
4245 a new method every time.
4247 2008-06-20 Marek Safar <marek.safar@gmail.com>
4249 * anonymous.cs: Propagate storey reference for single references.
4251 2008-06-20 Marek Safar <marek.safar@gmail.com>
4253 A fix for bug #387615
4254 * assign.cs, expression.cs: Correctly clone compound assignment.
4256 2008-06-19 Marek Safar <marek.safar@gmail.com>
4258 A fix for bug #359611, #359604
4259 * anonymous.cs: Mutate all types of hoisted parameters.
4261 2008-06-19 Marek Safar <marek.safar@gmail.com>
4263 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4264 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4265 expression.cs, codegen.cs, statement.cs
4267 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4268 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4270 ** Anonymous methods, lambda expressions rewrite **
4272 Anonymous expressions are now resolved when an explicit block is resolved
4273 and they don't require any registration procedure anymore. Further,
4274 anonymous methods are defined when explicit block is emitted which allows
4275 better control of whole process and opens possibilities for more
4276 optimizations as well as alternative to reverse whole process.
4278 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4279 process consistent and to correctly emit hoisted generic methods when they
4280 have at least 1 hoisted variable.
4282 2008-06-17 Martin Baulig <martin@ximian.com>
4284 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4286 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4287 virtual property; check it in Emit().
4288 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4290 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4292 (Indexer.Define): Likewise.
4294 2008-06-17 Marek Safar <marek.safar@gmail.com>
4296 * convert.cs: Don't use IsInterface on type arguments.
4298 * delegate.cs: DelegateInvocation uses MethodInfo.
4300 * parameter.cs: Removed IsTypeParameter.
4302 * generic-mcs.cs: More missing stuff.
4304 2008-06-16 Martin Baulig <martin@ximian.com>
4307 (Modifiers.DEBUGGER_HIDDEN): New public const.
4310 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4313 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4314 (AbstractPropertyEventMethod): Likewise.
4315 (Constructor.Emit): Likewise.
4316 (SourceMethod.SetCompilerGenerated): Removed.
4318 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4322 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4323 if we're an `IteratorHost'.
4324 (AnonymousMethodMethod..ctor): Don't set
4325 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4328 2008-06-16 Marek Safar <marek.safar@gmail.com>
4330 * statement.cs: Clean-up foreach statements.
4332 2008-06-12 Marek Safar <marek.safar@gmail.com>
4334 * class.cs: Stop using public method which should not exist
4335 (MethodBuilder.SetGenericMethodSignature).
4337 2008-06-11 Martin Baulig <martin@ximian.com>
4340 (Location.LookupFile): Add `CompilationUnit' argument; when given
4341 a relative file name, make it relative to the directory the .cs
4342 file is located in instead of using the current directory.
4344 2008-06-11 Martin Baulig <martin@ximian.com>
4347 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4348 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4349 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4350 (SourceMethod.SetCompilerGenerated): Likewise.
4352 2008-06-11 Marek Safar <marek.safar@gmail.com>
4354 * codegen.cs, driver: Only write symbol file when it's asked for.
4356 2008-06-11 Marek Safar <marek.safar@gmail.com>
4358 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4360 2008-06-10 Martin Baulig <martin@ximian.com>
4362 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4364 2008-06-09 Marek Safar <marek.safar@gmail.com>
4366 A fix for bug #316290
4367 * expression.cs: Include decimal operators in predefined table.
4369 * parameters.cs: More readonlyness.
4371 2008-06-09 Marek Safar <marek.safar@gmail.com>
4373 A fix for bug #397213
4374 * cs-parser.jay: One more missing current_local_parameters reset.
4376 2008-06-09 Marek Safar <marek.safar@gmail.com>
4378 A fix for bug #396633
4379 * class.cs: Host backing field in partial container.
4381 2008-06-09 Marek Safar <marek.safar@gmail.com>
4383 A fix for bug #397068
4384 * expression.cs: Check both operand types when predefined operator is used.
4386 2008-06-05 Martin Baulig <martin@ximian.com>
4388 Merged the `debugger-kahalo' branch.
4391 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4392 we're an iterator method.
4393 (SourceMethod): Reflect latest symbol writer changes;
4394 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4395 now `start_row' and `end_row'.
4396 (Constructor.Emit): Fix the logic whether to emit symbol information.
4398 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4402 (CompilationUnit): New public class; derives from `SourceFile'.
4403 (SourceFileEntry.DefineSymbolInfo): New public method.
4404 (SourceFileEntry.SetChecksum): New public method.
4405 (Location): Encode hidden line numbers by using `column == 255';
4406 the .ctor now accepts `column == -1' to mark a hidden line number.
4407 (Location.Hidden): New public property.
4408 (Location.CheckPoint): Add `CompilationUnit'.
4409 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4410 (Location.Push): Add `CompilationUnit compile_unit' argument.
4411 (Location.CompilationUnit): New public property.
4414 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4416 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4418 * driver.cs: `SourceFile' -> `CompilationUnit'.
4420 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4422 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4424 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4428 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4429 new symbol writer API to also pass the file.
4431 2008-06-05 Marek Safar <marek.safar@gmail.com>
4433 * statement.cs: Emit catch variable assignment using variable expression.
4435 2008-06-05 Marek Safar <marek.safar@gmail.com>
4437 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4438 with other variable types.
4440 2008-06-04 Marek Safar <marek.safar@gmail.com>
4442 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4443 GetLength method emit, it breaks resolve rules.
4445 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4446 Marek Safar <marek.safar@gmail.com>
4448 A fix for bug #395542
4449 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4452 2008-06-02 Marek Safar <marek.safar@gmail.com>
4454 A fix for bug #395287
4455 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4457 2008-05-31 Marek Safar <marek.safar@gmail.com>
4459 A fix for bug #395845
4460 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4461 non-nullable parameter type.
4463 2008-05-31 Marek Safar <marek.safar@gmail.com>
4465 * class.cs: Handle contructor initializer as a statement in top-level block.
4467 2008-05-30 Marek Safar <marek.safar@gmail.com>
4469 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4470 security attributes.
4472 2008-05-24 Marek Safar <marek.safar@gmail.com>
4474 * ecore.cs, expression.cs: Small IVariable refactoring.
4476 2008-05-22 Marek Safar <marek.safar@gmail.com>
4478 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4480 2008-05-21 Marek Safar <marek.safar@gmail.com>
4482 * cs-parser.jay: Removed redundant catch type check.
4484 2008-05-21 Marek Safar <marek.safar@gmail.com>
4486 A fix for bug #390372
4487 * nullable.cs: Set correct return type.
4489 2008-05-21 Marek Safar <marek.safar@gmail.com>
4491 A fix for bug #391062
4492 * typemanager.cs: Fixed crash when comparing null types.
4494 2008-05-21 Marek Safar <marek.safar@gmail.com>
4496 A fix for bug #391871
4497 * cs-parser.jay: Better error handling for invalid catch type.
4499 2008-05-20 Marek Safar <marek.safar@gmail.com>
4501 A fix for bug #392155
4502 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4504 2008-05-15 Marek Safar <marek.safar@gmail.com>
4506 A fix for bug #390666
4507 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4510 2008-05-15 Marek Safar <marek.safar@gmail.com>
4512 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4515 2008-05-13 Marek Safar <marek.safar@gmail.com>
4517 A fix for bug #389625
4518 * delegate.cs, generic.cs: Some progress on method group return type
4521 2008-05-13 Marek Safar <marek.safar@gmail.com>
4523 A fix for bug #378419
4524 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4526 2008-05-12 Marek Safar <marek.safar@gmail.com>
4528 * class.cs (Constructor): Added IsCompilerGenerated.
4530 2008-05-12 Marek Safar <marek.safar@gmail.com>
4532 * expression.cs: Enum binary operators can accept non-enum operand only when
4533 is implicitly convertible to underlying type.
4535 2008-05-12 Marek Safar <marek.safar@gmail.com>
4537 A fix for bug #389272
4538 * support.cs: Workaround System.InvalidOperationException for enums.
4540 2008-05-12 Marek Safar <marek.safar@gmail.com>
4542 A fix for bug #389073
4543 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4545 2008-05-10 Marek Safar <marek.safar@gmail.com>
4547 * driver.cs: Split Parse.
4549 * location.cs (LookupFile): Uses string.Empty.
4551 2008-05-07 Marek Safar <marek.safar@gmail.com>
4553 * expression.cs, parameter.cs: Small ParameterReference clean up.
4555 2008-05-07 Marek Safar <marek.safar@gmail.com>
4557 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4558 hack. Fixes #387502.
4560 2008-05-06 Martin Baulig <martin@ximian.com>
4562 * class.cs (Constructor.Emit): Fix the logic whether to emit
4565 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4568 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4569 InvalidOperationException when the iterator is before the start or
4572 2008-05-06 Marek Safar <marek.safar@gmail.com>
4574 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4575 when left is nullable type.
4577 2008-05-06 Marek Safar <marek.safar@gmail.com>
4579 A fix for bug #386628
4580 * expression.cs (LocalVariableReference): Continue in resolving when
4581 variable is not assigned.
4583 2008-05-05 Marek Safar <marek.safar@gmail.com>
4585 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4586 nullable operations.
4588 2008-05-04 Marek Safar <marek.safar@gmail.com>
4590 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4591 it saves many redundant temporary variables for nullable operations.
4593 2008-05-03 Marek Safar <marek.safar@gmail.com>
4595 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4597 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4600 * nullable.cs: Constant coalescing operator optimizations.
4602 2008-05-03 Marek Safar <marek.safar@gmail.com>
4604 * constant.cs: Use unsigned conversion for values which are unsigned only.
4606 2008-05-03 Marek Safar <marek.safar@gmail.com>
4608 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4609 coalescing operator as it should be.
4611 2008-05-02 Marek Safar <marek.safar@gmail.com>
4613 A fix for bug #371016
4614 * expression.cs: All predefined delegate operators require implicit method
4617 2008-05-02 Marek Safar <marek.safar@gmail.com>
4619 * constant.cs: Emit long constant as uint when fits the range.
4621 * convert.cs, expression.cs: Fixed few unsafe conversions.
4623 2008-05-02 Marek Safar <marek.safar@gmail.com>
4625 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4627 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4630 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4632 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4634 2008-05-01 Marek Safar <marek.safar@gmail.com>
4636 * constant.cs, literal.cs: IsLiteral property for error reporting.
4638 * ecore.cs, expression.cs: Implemented Property expression.
4640 2008-05-01 Marek Safar <marek.safar@gmail.com>
4642 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4644 * nullable.cs: Implemented nullable coalescing null operator.
4646 * ecore.cs, expression.cs: Expression trees work.
4648 2008-05-01 Marek Safar <marek.safar@gmail.com>
4650 * ecore.cs: CreateExpressionTree is finally abstract.
4652 * expression.cs, linq.cs: Updated.
4654 2008-05-01 Marek Safar <marek.safar@gmail.com>
4656 * expression.cs, ecore.cs: Block base access expression inside expression
4659 2008-05-01 Marek Safar <marek.safar@gmail.com>
4661 A fix for bug #385058
4662 * expression.cs: User-defined operator implementations always take
4663 precedence over predefined operator implementations.
4665 2008-04-30 Marek Safar <marek.safar@gmail.com>
4667 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4668 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4669 expression tree conversions.
4671 2008-04-30 Marek Safar <marek.safar@gmail.com>
4673 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4674 operators method details to Operator class.
4676 2008-04-30 Marek Safar <marek.safar@gmail.com>
4678 * anonymous.cs: Pass unsafe flags to anonymous container.
4680 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4681 inside expression tree.
4683 2008-04-29 Martin Baulig <martin@ximian.com>
4685 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4686 (Tokenizer.PopPosition): Also restore the `line'.
4688 2008-04-29 Marek Safar <marek.safar@gmail.com>
4690 * delegate.cs: Implemented Invoke expression.
4692 2008-04-29 Marek Safar <marek.safar@gmail.com>
4694 * expression.cs: Fixed equality reference comparison regression.
4696 2008-04-29 Marek Safar <marek.safar@gmail.com>
4698 * ecore.cs: Clean up EmptyCast hack.
4700 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4701 using correct conversion rules. Also fixes #383993.
4703 2008-04-28 Martin Baulig <martin@ximian.com>
4705 * class.cs (Constructor.Emit): Don't emit debugging information
4706 for generated default .ctor's.
4708 2008-04-28 Marek Safar <marek.safar@gmail.com>
4710 * convert.cs: Empty-cast ushort to int conversion.
4712 2008-04-28 Marek Safar <marek.safar@gmail.com>
4714 A fix for bug #384191
4715 * ecore.cs, expression.cs: Fixed expression cloning.
4717 2008-04-28 Marek Safar <marek.safar@gmail.com>
4719 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4721 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4723 Fix #381559, test-638.cs, test-639.cs
4724 * assign.cs (CompoundAssign.Helper): New wrapper.
4725 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4727 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4728 Pass unconverted expressions to the params array creation expression.
4729 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4730 (PropertyExpr.EmitAssign): Likewise.
4731 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4732 element if it is of kind CompoundAssign.Helper.
4733 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4734 first before anything else.
4735 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4736 (ArrayAccess.LoadArrayAndArguments): Simplify.
4738 2008-04-27 Marek Safar <marek.safar@gmail.com>
4740 * expression.cs: Fixed cloning of typeof(void).
4742 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4744 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4745 (Assign.Emit): Likewise. Move it to ...
4746 (CompoundAssign.DoResolve): ... here and ...
4747 (CompoundAssign.Emit): ... here.
4748 (EventAddOrRemove): New helper to handle += and -= on events, and
4749 avoid the use of BinaryDelegates.
4750 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4751 (EventExpr.EmitAddOrRemove): Improve.
4752 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4754 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4755 create VarExprs for 'foo.bar.var'.
4756 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4757 is a highly inappropriate name for its functionality.
4759 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4761 Simplify handling of multiple assignments
4762 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4764 (SimpleAssign): New. Class to be used for normal assignments.
4765 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4766 * expression.cs, parameter.cs, statement.cs: Likewise.
4768 2008-04-25 Marek Safar <marek.safar@gmail.com>
4770 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4771 for incompatible underlying types, more to come, uff.
4773 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4776 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4777 Handle 'leave_copy'.
4779 2008-04-25 Marek Safar <marek.safar@gmail.com>
4781 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4783 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4785 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4786 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4787 * statement.cs (While, Do, For): Allow test to have side effects.
4788 (For.DoEmit): Always emit InitStatement.
4791 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4792 Always create SideEffectConstant.
4793 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4794 of type EnumConstant.
4796 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4797 Handle 'right' being SideEffectConstant of type 'bool'.
4799 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4800 Use left.EmitBranchable instead of open coding it, so as to
4801 improve optimization opportunities.
4803 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4805 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4807 (Expression.EmitSideEffect): Document.
4809 2008-04-23 Marek Safar <marek.safar@gmail.com>
4811 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4813 2008-04-23 Marek Safar <marek.safar@gmail.com>
4815 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4817 2008-04-23 Marek Safar <marek.safar@gmail.com>
4819 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4820 conversion to expression tree.
4822 2008-04-23 Marek Safar <marek.safar@gmail.com>
4824 * ecore.cs: Removed unused expression.
4826 2008-04-22 Marek Safar <marek.safar@gmail.com>
4828 * expression.cs: Implemented NegateChecked and New expressions.
4830 2008-04-22 Marek Safar <marek.safar@gmail.com>
4832 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4834 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4837 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4838 needing final 'ret' instruction.
4840 2008-04-22 Marek Safar <marek.safar@gmail.com>
4842 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4844 2008-04-21 Marek Safar <marek.safar@gmail.com>
4846 * expression.cs: Emit ldnull and not null expression as an instance argument
4847 of static method expression calls.
4849 2008-04-21 Marek Safar <marek.safar@gmail.com>
4851 A fix for bug #378200
4852 * expression.cs: Fixed crash when creating parameterless expression tree
4855 2008-04-21 Marek Safar <marek.safar@gmail.com>
4857 A fix for bug #375297
4858 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4861 2008-04-21 Marek Safar <marek.safar@gmail.com>
4863 A fix for bug #377596
4864 * decl.cs, class.cs: Emit delegate type argument attributes.
4866 2008-04-21 Marek Safar <marek.safar@gmail.com>
4868 A fix for bug #365314
4869 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4871 2008-04-21 Marek Safar <marek.safar@gmail.com>
4873 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4876 2008-04-21 Marek Safar <marek.safar@gmail.com>
4878 * generic.cs (TypeParameter): Removed redundant location.
4880 2008-04-19 Marek Safar <marek.safar@gmail.com>
4882 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4883 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4884 FullNamedExpression in all declaration type expression, statements will come
4887 2008-04-18 Marek Safar <marek.safar@gmail.com>
4889 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4890 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4892 2008-04-18 Marek Safar <marek.safar@gmail.com>
4894 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4897 2008-04-17 Marek Safar <marek.safar@gmail.com>
4899 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4902 2008-04-17 Marek Safar <marek.safar@gmail.com>
4904 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4908 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4910 Hook up 'EmitSideEffect'
4911 * constant.cs (Constant.EmitSideEffect): New.
4912 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4913 (SideEffectConstant.EmitSideEffect): New.
4914 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4915 unconditional branch in EmitBranchable.
4916 (FieldExpr.EmitBranchable): New.
4917 * expression.cs (Unary.EmitSideEffect): New.
4918 (Binary.EmitSideEffect): New.
4919 (VariableReference.EmitSideEffect): New. Do nothing.
4921 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4923 Introduce 'EmitSideEffect'
4924 * ecore.cs (Expression.EmitSideEffect): New.
4925 (TypeCast): Rename from EmptyCast.
4927 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4928 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4929 * convert.cs, nullable.cs: Update to changes.
4931 2008-04-16 Marek Safar <marek.safar@gmail.com>
4933 * class.cs, cs-parser.jay: Early check for base types expression.
4935 2008-04-16 Marek Safar <marek.safar@gmail.com>
4937 * decl.cs (MemberName): Declare PrettyName as obsolete.
4939 2008-04-16 Marek Safar <marek.safar@gmail.com>
4941 * namespace.cs: Use MemberName comparison.
4943 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4946 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4948 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4949 (MemberName.FullyQualifiedName): New. Provides the functionality
4950 that users assume FullName would have.
4951 * ecore.cs, namespace.cs: Update to changes.
4953 * statement.cs (Using.assign): Make into ExpressionStatement.
4954 (Using.EmitPreTryBody): Simplify.
4956 2008-04-16 Marek Safar <marek.safar@gmail.com>
4958 * report.cs: ColorFormat is protected.
4960 * rootcontext.cs: Unused fields clean-up.
4962 * namespace.cs: Made UsingEntry name private.
4964 2008-04-16 Marek Safar <marek.safar@gmail.com>
4966 * cs-tokenizer.cs, location.cs: Removed unused field.
4968 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4969 Raja R Harinath <harinath@hurrynot.org>
4972 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4973 (SideEffectConstant.side_effect): Rename from 'right'.
4974 (SideEffectConstant..ctor): Normalize 'side_effect'.
4975 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4976 value of this constant.
4977 * cfold.cs: Update to changes.
4979 2008-04-15 Marek Safar <marek.safar@gmail.com>
4981 * cs-paser.jay: Removed unused variable.
4983 * driver.cs: Made Compile instance method.
4985 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4987 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4989 2008-04-15 Marek Safar <marek.safar@gmail.com>
4991 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4993 2008-04-13 Jb Evain <jbevain@novell.com>
4995 * namespace.cs: update the System.Core fullname for 2.1
4996 * driver.cs: update the list of required assemblies for 2.1.
4997 Merged from the Moonlight 2 branch.
4999 2008-04-11 Marek Safar <marek.safar@gmail.com>
5001 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
5002 types and user defined operators. User operators arguments has to be checked
5003 for null value before invocation, which also means no operator is called
5004 when any argument is not convertible to unwrapped nullable type.
5006 2008-04-09 Marek Safar <marek.safar@gmail.com>
5008 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
5009 of Unary expressions to follow operator overloading rules precisely.
5010 Also fixes #321794, #323794
5012 2008-04-08 Marek Safar <marek.safar@gmail.com>
5014 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
5017 2008-04-08 Marek Safar <marek.safar@gmail.com>
5019 * expression.cs, ecore.cs: Implemented MemberInit expression.
5021 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
5023 Fix mono/tests/exception4.cs
5024 * statement.cs (ExceptionStatement, TryCatch): Revert to using
5025 ec.NeedReturnLabel () rather emitting a 'nop'.
5027 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
5029 (TryCatch.SomeCodeFollows): Likewise.
5030 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
5031 for 'break', 'continue' and 'return' statements inside a try.
5032 We're fairly sure that the generated IL stream will have more
5033 instructions textually following the try.
5034 (FlowBranchingTryCatch): Likewise.
5036 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
5037 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
5040 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
5041 wrapper -- forward everything to CollectionForeach.
5042 (CollectionForeach.NonDisposableWrapper): New.
5043 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
5044 instead of a pop + branch to end.
5046 2008-04-07 Marek Safar <marek.safar@gmail.com>
5048 A fix for bug #377485
5049 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
5050 Propagate location for extension method groups. Report conversion failure at
5053 2008-04-07 Marek Safar <marek.safar@gmail.com>
5055 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
5056 ListInit and Field expressions.
5058 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
5060 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
5061 Since $PC is always -1 inside the body of MoveNext, the fault
5063 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
5064 * statement.cs (ExceptionStatement.emit_finally): Likewise.
5065 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
5067 The denouement! Fix #324708
5068 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
5069 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
5070 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
5071 'finally' inside the finally clause.
5073 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
5074 inside an iterator. Don't emit the body of the 'finally' inside
5075 the finally clause yet.
5077 Use the ResumableStatement infrastructure for MoveNext ()
5078 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
5079 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
5080 'old_resume_points'. Move dispatcher upfront.
5081 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
5082 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
5083 in an enumerator. This encodes the main fix in this patch series
5084 -- we can only jump into the first instruction of a try from the
5085 outside, but we want to emit try/finally regions in iterators and
5086 resume in the middle of them.
5088 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
5090 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
5091 of NeedReturnLabel here.
5093 Introduce a common point for emitting try/finally to IL
5094 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
5095 features of the various subclasses, which are now driven by ...
5096 (ExceptionStatement.EmitPreTryBody): ... this and ...
5097 (ExceptionStatement.EmitTryBody): ... this and the original
5099 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
5100 Remove DoEmit and update to follow above protocol.
5102 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
5103 of the dispatcher are the same, skip emitting the 'switch'.
5104 * iterator.cs (Iterator.EmitDispose): Update to changes.
5106 Clean up handling of 'using' statement
5107 * statement.cs (UsingTemporary): New. Carved out of ...
5108 (Using): ... this. Simplify drastically. Handle exactly
5110 * cs-parser.jay (using_statement): Split. Create UsingTemporary
5111 or Using as appropriate. If there are multiple variable declared,
5112 create nested Using statements.
5113 (resource_acquisition): Kill.
5115 * statement.cs (ExceptionStatement.EmitForDispose): Use
5116 EmitFinallyBody, not EmitFinally.
5118 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
5119 * iterator.cs: Update to changes.
5121 Start using the ResumableStatement infrastructure
5122 * statement.cs (ResumeableStatement.PrepareForDispose): New.
5123 (ResumableStatement.EmitForDispose): New.
5124 (ExceptionStatement): Override them.
5125 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
5126 EmitForDispose to create the body of the Dispose method. Don't
5129 * iterator.cs (Iterator.AddResumePoint): Move here from ...
5130 * statement.cs (Toplevel.AddResumePoint): ... here.
5131 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
5132 * flowanalysis.cs (FlowBranchingIterator): New.
5133 * codegen.cs (EmitContext): Update to changes.
5135 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
5136 (Iterator.old_resume_points): Rename from 'resume_points'.
5137 (Iterator.MoveNextStatement): Remove unused class.
5139 New infrastructure for try/finally in iterators (still unused)
5140 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
5141 (FlowBranchingToplevel.AddResumePoint): Hook into
5142 ToplevelBlock.AddResumePoint.
5143 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
5144 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
5145 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
5146 resume points and assign program-counter values.
5147 (ExceptionBlock.AddResumePoint): Collect resume points for
5148 de-muxer at the top of try block.
5149 * iterators.cs (Yield.CheckContext): Simplify.
5150 (Yield.Resolve): Use FlowBranching.AddResumePoint.
5152 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
5154 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
5155 argument to an ExitStatement.
5156 (FlowBranchingException): Refactor saved origins code.
5157 * statement.cs (ExitStatement): Update to cahges.
5158 * iterator.cs (YieldBreak): Likewise.
5160 * statement.cs (ResumableStatement): New. Common base class for
5161 YieldReturn and ExceptionStatement.
5162 (ExitStatement): New. Common base class for Return and YieldBreak.
5163 (Return): Update to changes.
5164 * iterator.cs (YieldBreak): Likewise.
5165 * lambda.cs (ContextualReturn): Likewise.
5168 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
5169 emit a meaningful error message.
5171 Fix #324765, #319508
5172 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
5173 (VariableInfo.SetAssigned): Set it.
5174 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
5175 determine if CS0219 or CS0168 is appropriate. Don't use
5176 flow-analysis information.
5177 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
5178 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
5179 (EmitContext.EndFlowBranching): ... this.
5181 2008-04-03 Marek Safar <marek.safar@gmail.com>
5183 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5185 2008-04-03 Marek Safar <marek.safar@gmail.com>
5187 A fix for bug #376508
5188 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5189 ImplicitConversionExists.
5191 2008-04-03 Marek Safar <marek.safar@gmail.com>
5193 * expression.cs (Binary): Added remaining binary operators to expression
5196 * nullable.cs: Optimize shift with null argument.
5198 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5200 Fix minor IL regression
5201 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5202 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5203 * cs-parser.jay (try_statement): Update to changes.
5205 * statement.cs (TryFinally.need_exc_block): Delete.
5206 (TryFinally): Update to changes.
5208 Now all ExceptionStatements are unconditional
5209 * statement.cs (CollectionForeach.DisposableWrapper): New.
5210 Extract out the try/finally code into a new wrapper.
5211 (CollectionForeach.Resolve): Use it to simplify the code.
5213 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5215 Start at simplifying ExceptionStatement semantics a bit
5216 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5217 * cs-parser.jay (try_statement): Update to changes.
5218 (opt_catch_clauses): Remove.
5219 * flowanalysis.cs: Update to changes.
5220 (FlowBranching.BranchingType.TryCatch): New.
5221 (FlowBranchingTryCatch): New.
5223 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5224 (FlowBranching.CreateBranching): Update to changes.
5225 (FlowBranchingBlock.AddSibling): Add sanity check.
5226 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5229 * iterators.cs (Iterator.MarkFinally): Remove.
5230 * statement.cs (ExceptionStatement): Update to changes.
5232 Add support for skipping over finally blocks at runtime. First
5233 in a series to fix #324708
5234 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5235 (Iterator.EmitMoveNext): Initialize it.
5236 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5237 branch over the body of the 'finally' clause.
5239 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5241 Avoid lopsided use of Foo/DoFoo names
5242 * statement.cs (ExpressionStatement.EmitFinallyBody):
5243 Rename from EmitFinally.
5244 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5245 * iterator.cs: Update to changes.
5247 2008-04-02 Marek Safar <marek.safar@gmail.com>
5249 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5250 based on UserOperatorCall. More binary nullable operators clean up.
5252 2008-04-02 Martin Baulig <martin@ximian.com>
5254 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5256 2008-04-02 Marek Safar <marek.safar@gmail.com>
5258 * nullable.cs: Merge user and empty conversions when lifting expression
5261 * expression.cs (StringConcat): Implemented expression tree representation.
5263 2008-04-01 Marek Safar <marek.safar@gmail.com>
5265 * nullable.cs: When lifting null literal and a user operator exists, no call
5268 2008-04-01 Marek Safar <marek.safar@gmail.com>
5270 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5273 2008-04-01 Marek Safar <marek.safar@gmail.com>
5275 * nullable.cs, expression.cs: Use namespace instead heavily nested
5276 monster abstract class.
5278 2008-04-01 Marek Safar <marek.safar@gmail.com>
5280 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5281 lifting of null literal and user operators. Clean up of some temporary
5284 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5286 Fix #368224, test-629.cs
5287 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5288 if it crossed an unwind-protect boundary.
5289 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5290 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5291 inside an unwind-protected region.
5292 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5293 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5294 'leave' instead of a 'br' if unwind-protected.
5295 (Iterator.EmitYieldBreak): Likewise.
5297 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5299 * driver.cs: Only define versioninfo resources if no win32 resource
5302 2008-03-28 Marek Safar <marek.safar@gmail.com>
5304 A fix for bug #372375
5305 * convert.cs: Fixed boxing of nullable types.
5307 2008-03-28 Marek Safar <marek.safar@gmail.com>
5309 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5312 2008-03-28 Marek Safar <marek.safar@gmail.com>
5314 A fix for bug #374619
5315 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5317 2008-03-27 Marek Safar <marek.safar@gmail.com>
5319 * lambda.cs: Check return type only for invocation.
5321 2008-03-27 Marek Safar <marek.safar@gmail.com>
5323 A fix for bug #374214
5324 * ecore.cs: Correctly report argument type mismatch.
5326 2008-03-27 Marek Safar <marek.safar@gmail.com>
5328 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5329 and not rely on broken IsEnum.
5331 2008-03-27 Marek Safar <marek.safar@gmail.com>
5333 * nullable.cs: New file, extracted from generic.cs.
5335 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5337 2008-03-27 Marek Safar <marek.safar@gmail.com>
5339 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5340 predefined comparison operators and null literals.
5342 * report.cs: New warning ID.
5344 2008-03-25 Marek Safar <marek.safar@gmail.com>
5346 A fix for bug #370577
5347 * lambda.cs: Check return type too.
5349 2008-03-25 Marek Safar <marek.safar@gmail.com>
5351 A fix for bug #372846
5352 * class.cs: Automatic properties can be declared as unsafe.
5354 2008-03-20 Marek Safar <marek.safar@gmail.com>
5356 * location.cs: Use string based concatenation.
5358 * expression.cs: LiftedBinaryOperator is gmcs only.
5360 2008-03-20 Marek Safar <marek.safar@gmail.com>
5362 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5363 conversions rules and expression trees.
5365 2008-03-19 Marek Safar <marek.safar@gmail.com>
5367 * delegate.cs: Use extension method source as delegate target.
5369 2008-03-19 Marek Safar <marek.safar@gmail.com>
5371 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5372 binary operations to be purely based on binary operations and optimized
5373 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5374 and other ET refactoring.
5376 * typemanager.cs: Fixed warning.
5378 2008-03-17 Marek Safar <marek.safar@gmail.com>
5380 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5382 * symbolwriter.cs: Fixed.
5384 2008-03-17 Marek Safar <marek.safar@gmail.com>
5386 * anonymous.cs, driver.cs: Reset anonymous types counters.
5388 2008-03-17 Marek Safar <marek.safar@gmail.com>
5390 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5392 * class.cs: Use fullname for all type member definitions.
5394 2008-02-19 Martin Baulig <martin@ximian.com>
5397 (IMethodData.EmitExtraSymbolInfo): New interface method.
5398 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5399 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5400 interface method here as an empty public virtual method.
5403 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5404 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5405 CodeGen.SymbolWriter.SetRealMethodName().
5407 2008-02-18 Martin Baulig <martin@ximian.com>
5410 (ScopeInfo.EmitType): Override this and emit debugging
5411 information for captured variables.
5412 (RootScopeInfo.EmitType): Override this and emit symbol
5413 information for a captured `this'.
5415 2008-02-15 Martin Baulig <martin@ximian.com>
5417 * iterators.cs: Emit debugging info.
5420 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5421 (EmitContext.OmitDebuggingInfo): New public property.
5424 (While): Override Emit() and don't emit symbol info there; do it
5425 inside DoEmit() instead.
5426 (Block.Emit): Omit symbol information while emitting the scope
5427 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5429 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5430 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5431 .ctor to make `IsIterator' work.
5433 2008-03-14 Martin Baulig <martin@ximian.com>
5435 * symbolwriter.cs: Added the new symbol writer function from the
5436 debugger's `terrania' branch; temporarily enclose them inside
5437 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5440 2008-03-14 Martin Baulig <martin@ximian.com>
5443 (SymbolWriter): Make this a public static class.
5446 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5447 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5449 2008-03-14 Marek Safar <marek.safar@gmail.com>
5451 A fix for bug #370577
5452 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5455 2008-03-14 Marek Safar <marek.safar@gmail.com>
5457 * typemanager.cs (CSharpName): Made 250 times faster.
5459 2008-03-13 Marek Safar <marek.safar@gmail.com>
5461 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5463 2008-03-12 Marek Safar <marek.safar@gmail.com>
5465 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5466 crash when predefined field does not exist.
5468 2008-03-12 Marek Safar <marek.safar@gmail.com>
5470 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5472 2008-03-12 Marek Safar <marek.safar@gmail.com>
5474 * class.cs (FixedField): Don't crash when contructors are missing.
5476 2008-03-11 Marek Safar <marek.safar@gmail.com>
5478 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5479 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5480 check internal types accessibility for internal and external types.
5481 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5483 2008-03-11 Marek Safar <marek.safar@gmail.com>
5485 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5486 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5487 attribute.cs, statement: Use corect instance of predefined types (work
5488 related to #364674).
5490 2008-03-07 Marek Safar <marek.safar@gmail.com>
5492 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5494 2008-03-07 Marek Safar <marek.safar@gmail.com>
5496 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5497 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5498 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5499 predefined types clean up, delayed predefined types members initialization
5500 (work related to #364674).
5502 2008-03-05 Marek Safar <marek.safar@gmail.com>
5504 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5506 2008-03-05 Marek Safar <marek.safar@gmail.com>
5508 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5509 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5510 predefined types clean up (work related to #364674).
5512 2008-03-04 Marek Safar <marek.safar@gmail.com>
5514 * ecore.cs: Print an error message instead of throwing exception.
5516 2008-03-04 Marek Safar <marek.safar@gmail.com>
5518 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5519 expression.cs, statement.cs: Unififed null literal representation.
5521 2008-03-03 Marek Safar <marek.safar@gmail.com>
5523 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5524 expression.cs: Refactored binary operators resolve phase and improved speed.
5525 The nullable code is still missing and won't work correctly, more fixes
5528 It also fixes #323726, #324312, #324248, and many other unreported issues.
5530 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5532 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5535 2008-02-27 Marek Safar <marek.safar@gmail.com>
5537 * ecore.cs: Clean-up and split BetterConversion.
5539 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5542 * enum.cs (EnumMember.Value): Only access 'value' if
5543 ResolveValue says it's ok.
5544 (EnumMember.DoResolveValue): Don't set prev_member.value.
5545 (Enum.GetDefinition): Reverse arguments of Equals --
5546 EnumMember.Value can return 'null'.
5548 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5550 2008-02-22 Marek Safar <marek.safar@gmail.com>
5552 * generic.cs, expression.cs: More ongoing work on expression trees.
5554 2008-02-21 Marek Safar <marek.safar@gmail.com>
5556 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5557 handle missing matches when mutiple operators exist.
5559 2008-02-20 Marek Safar <marek.safar@gmail.com>
5561 A fix for bug #363218
5562 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5565 2008-02-20 Marek Safar <marek.safar@gmail.com>
5567 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5568 update. This time to deal correctly with SideEffectConstant expression used
5569 as an argument for another constant folding.
5571 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5573 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5576 2008-02-19 Marek Safar <marek.safar@gmail.com>
5578 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5580 2008-02-19 Marek Safar <marek.safar@gmail.com>
5582 A fix for bug #328136
5583 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5584 side is a false constant, because we still need to evaluate the right-hand
5587 * statement.cs (If): Emit two types of boolean constants (simple constant,
5588 side-effect constant).
5590 2008-02-19 Marek Safar <marek.safar@gmail.com>
5592 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5594 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5597 2008-02-18 Marek Safar <marek.safar@gmail.com>
5599 A fix for bug #361457
5600 * ecore.cs (IsApplicable): Params methods have lower priority.
5602 * support.cs: Return correct parameter modifier for params types.
5604 2008-02-18 Marek Safar <marek.safar@gmail.com>
5606 * generic.cs (TypeParameter): Cache attribute target name.
5608 * support.cs: Removed unused variable.
5610 * typemanager.cs: Removed debugging leftover.
5612 * ecore.cs: Use local type instead of a property;
5614 * class.cs (VerifyMembers): Consider also parent to test whether type member
5617 * expression.cs (FullMethodDesc): Removed.
5619 * attribute.cs (IsValidArgumentType): Made static.
5621 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5623 Cleanup to be more readable.
5624 * Makefile (GMCS_PROFILE): Remove.
5625 (COMPILER_NAME): New helper.
5627 2008-02-15 Miguel de Icaza <miguel@novell.com>
5629 * cs-tokenizer.cs: if a conditional expression happens inside a
5630 (...) this also means that we do not need to de-ambiguate between
5631 an parenthesized expression and a cast.
5635 * constant.cs (SideEffectConstant): a constant value that happens
5636 to have a side effect.
5638 Fixes the build regressions introduced by the fix for #359789
5640 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5642 * expression.cs (Conditional.Emit): when emitting the ternary
5643 operator, use local variables to generate code verifiable code.
5645 The verifier cannot infer that the type on stack before the
5646 stloc.0 is executed is of type ParentB. This happens because the
5647 stack merge algorithm uses only parent types when deciding which
5648 is the common type. This is described in Part III 1.8.1.3 of ECMA
5651 This code compiled with mcs is not verifiable under MS. The MS
5652 verifier picks the first common interface of Foo and Bar, which is
5653 wrong, but doesn't use a full join type of the 2 interfaces.
5655 CSC uses a clever hack to compile such code in a verifiable
5656 way. It stores the intermediate values in a local variable with
5661 2008-02-14 Miguel de Icaza <miguel@novell.com>
5663 * expression.cs: Do not fold BitwiseAnd operators when the left
5664 side is a false constant, because we still need to evaluate the
5669 * support.cs: Instead of throwing an InternalErrorException when
5670 the position of the stream is outside the boundary of our buffer,
5671 reset the state of the reader, and restart the reading from the
5672 beginning of the file.
5674 2008-02-14 Marek Safar <marek.safar@gmail.com>
5676 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5678 2008-02-14 Marek Safar <marek.safar@gmail.com>
5680 A fix for bug #361686
5681 * decl.cs: A protected types used inside a private class which parents
5682 derives from the protected class are accessible.
5684 2008-02-13 Marek Safar <marek.safar@gmail.com>
5686 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5687 the parameterless constructor.
5689 2008-02-13 Marek Safar <marek.safar@gmail.com>
5691 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5692 lookup methods to use standard member cache when doing member lookup.
5694 2008-02-12 Marek Safar <marek.safar@gmail.com>
5696 * driver.cs: Don't report full path for referenced module as assembly error.
5698 2008-02-12 Marek Safar <marek.safar@gmail.com>
5700 * Makefile: Fixed `qh' target to work on all machines.
5702 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5703 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5704 and HasElementType with TypeManager implementation.
5706 2008-02-08 Marek Safar <marek.safar@gmail.com>
5708 A fix for bugs #325134, #359749
5709 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5710 first binds point to non-method member expression.
5712 2008-02-08 Marek Safar <marek.safar@gmail.com>
5714 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5716 2008-02-08 Marek Safar <marek.safar@gmail.com>
5718 A fix for bugs #321394, #323028
5719 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5720 Reworked naive IsAccessibleAs implementation to handle nested types.
5722 2008-02-05 Jb Evain <jbevain@novell.com>
5724 * class.cs: use generic type comparison for parameters
5727 2008-02-05 Marek Safar <marek.safar@gmail.com>
5729 A fix for bug #325372
5730 * class.cs: Use generic type comparison when testing method signatures.
5732 2008-02-05 Marek Safar <marek.safar@gmail.com>
5734 A fix for bug #357047
5735 * ecore.cs: Applied C# 3.0 changes to better conversion.
5737 2008-02-05 Marek Safar <marek.safar@gmail.com>
5739 A fix for bug #358374
5740 * cs-parser.jay: Correctly set modifiers for all constructor types.
5742 2008-02-04 Marek Safar <marek.safar@gmail.com>
5744 A fix for bug #355251
5745 * generic.cs: Added base class constraint based type inference.
5747 2008-02-01 Marek Safar <marek.safar@gmail.com>
5749 A fix for bug #357255
5750 * decl.cs: One more missing visibility check.
5752 2008-02-01 Marek Safar <marek.safar@gmail.com>
5754 * support.cs: Fixed broken return.
5756 2008-01-25 Marek Safar <marek.safar@gmail.com>
5758 * report.cs: Correctly reset warnings count after probing.
5760 2008-01-25 Martin Baulig <martin@ximian.com>
5763 (NamespaceEntry.SymbolFileID): Make this work again after
5764 MemberName.ToString() is gone.
5766 2008-01-25 Marek Safar <marek.safar@gmail.com>
5768 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5771 2008-01-25 Marek Safar <marek.safar@gmail.com>
5773 * generic.cs: Use full implicit conversion for type inference fixing.
5775 2008-01-24 Marek Safar <marek.safar@gmail.com>
5777 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5778 Fixed user operator conversions.
5780 2008-01-24 Marek Safar <marek.safar@gmail.com>
5782 * generic.cs: Do nullable type to null comparison optimization during
5785 2008-01-24 Marek Safar <marek.safar@gmail.com>
5787 A fix for bug #355163
5788 * generic.cs: Enabled l-value resolve on nullable expressions.
5790 2008-01-24 Marek Safar <marek.safar@gmail.com>
5792 A fix for bug #353986
5793 * class.cs: Ingore static ctors with parameters for any further checks.
5795 2008-01-24 Marek Safar <marek.safar@gmail.com>
5797 A fix for bug #354310
5798 * namespace.cs: Removed redundant check.
5800 2008-01-24 Marek Safar <marek.safar@gmail.com>
5802 A fix for bug #354928
5803 * expression.cs: ElementInitializers can be resolved only once.
5805 2008-01-24 Marek Safar <marek.safar@gmail.com>
5807 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5808 Condition expressions.
5810 2008-01-23 Marek Safar <marek.safar@gmail.com>
5812 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5814 2008-01-22 Marek Safar <marek.safar@gmail.com>
5816 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5819 * generic.cs: Implemented coalesce expression.
5821 2008-01-22 Marek Safar <marek.safar@gmail.com>
5823 A fix for bug #355145
5824 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5825 expression tree type inference.
5827 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5830 * expression.cs (Binary.IsUnsignedType): Fix typo.
5832 2008-01-22 Marek Safar <marek.safar@gmail.com>
5834 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5836 2008-01-22 Marek Safar <marek.safar@gmail.com>
5838 A fix for bug #355161
5839 * ecore.cs, expression.cs: Wider range of extension method supported
5842 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5844 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5845 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5848 2008-01-22 Marek Safar <marek.safar@gmail.com>
5850 A fix for bug #355148
5851 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5853 2008-01-22 Miguel de Icaza <miguel@novell.com>
5855 * expression.cs (CreateExpressionTree): Add support for or and
5856 logical or, and indent following the coding conventions.
5858 * typemanager.cs (LinqExpression): renamed from
5859 ExpressionTreeManager, for a shorter name.
5861 Use TypeManager.CoreLookupType to lookup types from our core
5862 assemblies and turn those into "Type" variables.
5864 Consumers that previously used "Namespace" and "Type" from this
5865 class should instead use the TypeExpression which is a type that
5866 is fully resolved (without involving the regular C# resolution
5869 This typically looks like this:
5871 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5872 new MemberAccess (texpr, name, type_arguments, loc)
5874 This avoids the problem in: #355178
5876 2008-01-21 Marek Safar <marek.safar@gmail.com>
5878 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5879 feature in parser only as we do in other cases.
5881 2008-01-21 Marek Safar <marek.safar@gmail.com>
5883 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5884 typemanager.cs: A refactoring of params arguments to reuse existing
5885 expressions (params -> array initializer) to emit params argument instead
5886 of specialized handling.
5887 It was required by expression tree implementation and it has other benefits
5888 as well, we now apply same optimization for params arguments as we do for
5891 2008-01-18 Marek Safar <marek.safar@gmail.com>
5893 A fix for bug #353526
5894 * generic.cs: A type inference of params arguments may not required any
5895 temporary array creation.
5897 2008-01-18 Marek Safar <marek.safar@gmail.com>
5899 A fix for bug #353534
5900 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5901 supported for delegates only.
5903 2008-01-18 Marek Safar <marek.safar@gmail.com>
5905 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5906 type for more than 1 candidates.
5908 2008-01-18 Marek Safar <marek.safar@gmail.com>
5910 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5913 2008-01-16 Marek Safar <marek.safar@gmail.com>
5915 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5916 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5917 operator) expressions.
5919 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5921 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5922 not accessed from the generated IL.
5924 2008-01-14 Marek Safar <marek.safar@gmail.com>
5926 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5927 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5928 statement.cs: The first expression tree implementation drop, mostly
5929 infrastructure work.
5931 2008-01-14 Marek Safar <marek.safar@gmail.com>
5933 * ecore.cs (IsNestedChild): Refactored.
5935 2008-01-11 Marek Safar <marek.safar@gmail.com>
5937 * lambda.cs: Don't use a cast on unknown expression statement.
5939 2008-01-10 Geoff Norton <gnorton@novell.com>
5941 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5944 2008-01-09 Marek Safar <marek.safar@gmail.com>
5946 * doc.cs: Report better /doc crash details.
5948 2008-01-09 Marek Safar <marek.safar@gmail.com>
5950 A fix for bug #352536
5951 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5953 2008-01-08 Marek Safar <marek.safar@gmail.com>
5955 A fix for bug #352287
5956 * ecore.cs, expression.cs: Do `this' access checking in all member access
5959 2008-01-08 Marek Safar <marek.safar@gmail.com>
5961 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5963 * report.cs: Reset message stacks.
5965 2008-01-08 Marek Safar <marek.safar@gmail.com>
5967 * generic.cs (InferInPhases): Correctly calculate params position.
5969 2008-01-08 Marek Safar <marek.safar@gmail.com>
5971 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5974 2008-01-07 Marek Safar <marek.safar@gmail.com>
5976 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5978 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5980 * driver.cs: Updated --help option.
5982 2008-01-07 Marek Safar <marek.safar@gmail.com>
5984 * generic.cs (InferParamsTypeArguments): Removed.
5985 (InferInPhases): Add params type inference.
5986 (LowerBoundInference): Fixed scoring mechanism.
5988 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5990 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5992 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5993 byte array for unsigned "baked" assemblies.
5995 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5997 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5998 array for assemblies that are not strongnamed.
6000 2008-01-04 Marek Safar <marek.safar@gmail.com>
6002 A fix for bug #351481
6003 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
6004 declaring type for nested generic types.
6006 2008-01-04 Marek Safar <marek.safar@gmail.com>
6008 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
6009 instead of ToString.
6011 2008-01-03 Marek Safar <marek.safar@gmail.com>
6013 A fix for bug #351047
6014 * expression.cs (Binary.ResolveOperator): Allow equality operators between
6015 null and structs only when equality and inequality operators are defined
6016 either as an user-operators or predefined operators.
6018 2008-01-03 Marek Safar <marek.safar@gmail.com>
6020 A fix for bug #351047
6021 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
6023 2008-01-03 Marek Safar <marek.safar@gmail.com>
6025 A fix for bug #351257
6026 * cs-tokenizer.cs: Advance line number for '\r' correctly.
6028 2008-01-03 Marek Safar <marek.safar@gmail.com>
6030 A fix for bug #351157
6031 * class.cs (Using): Fixed yet another broken cloning.
6033 (Block): Put back more sensible default value for statements.
6035 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
6037 * codegen.cs: Allow AssemblyVersion with only major version component.
6040 2007-12-29 Marek Safar <marek.safar@gmail.com>
6042 A fix for bug #324654
6043 * class.cs: Use FullName property as member name.
6045 2007-12-28 Marek Safar <marek.safar@gmail.com>
6047 A fix for bug #342117
6048 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
6049 constructor constraint.
6051 2007-12-28 Marek Safar <marek.safar@gmail.com>
6053 A fix for bug #338273
6054 * class.cs (ProbertyBase): Access modifier checks are required for overrides
6057 2007-12-28 Marek Safar <marek.safar@gmail.com>
6059 A fix for bug #350839
6060 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
6062 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6064 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6067 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6069 * statement.cs: Changed some Hashtables to use HybridDictionaries
6070 instead. It was observed that some HashTables only contained a few
6071 items in the vast majority of cases. Since HybridDictionary is
6072 more efficient on small sets (<10 elements), "known_variables"
6073 from class ExplicitBlock as well as "labels" and "constants " from
6074 class Block were changed to HybridDictionaries.
6076 Atsai results: (56216kb->54987kb)
6078 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
6081 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6083 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6086 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6088 * expression.cs: foreach loop to for loop, saved on allocation of
6089 enumerator (59333kb->59141kb)
6091 * statement.cs. Changed foreach loops to for loops, saved on
6092 allocation of enumerator (59141kb->59006kb)
6094 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
6095 when constructed with no specified capacity. This was causing a
6096 few ArrayLists to allocate more memory than they would potentially
6097 need in the Block class and MemberCache class. Setting the
6098 ArrayLists to construct with a capacity of 1 saves some
6099 memory. (56216kb->55585kb)
6101 2007-12-27 Marek Safar <marek.safar@gmail.com>
6103 A fix for bug #347189 (2nd issue)
6104 * expression.cs (MemberAccess): Nested type can be found in base non-generic
6107 2007-12-27 Miguel de Icaza <miguel@novell.com>
6109 * report.cs: Do not use colors if stdout and stderr are not a
6112 2007-12-27 Marek Safar <marek.safar@gmail.com>
6114 A fix for bug #346998
6115 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
6118 2007-12-27 Marek Safar <marek.safar@gmail.com>
6120 A fix for bug #343465
6121 * class.cs: Explicit method name for nested types uses dots only.
6123 2007-12-27 Marek Safar <marek.safar@gmail.com>
6125 A fix for bug #343707
6126 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
6128 2007-12-27 Marek Safar <marek.safar@gmail.com>
6130 * ecore.cs: Report type inference errors only when arguments count matches
6133 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
6135 * expression.cs, report.cs: New warning.
6137 * typemanager.cs: Catch anonymous method type too.
6139 2007-12-23 Marek Safar <marek.safar@gmail.com>
6141 A fix for bug #346379
6142 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
6144 2007-12-23 Marek Safar <marek.safar@gmail.com>
6146 A fix for bug #347359
6147 * expression.cs (Invocation): Don't resolve already resolved expression.
6149 2007-12-23 Marek Safar <marek.safar@gmail.com>
6151 A fix for bug #347189
6152 * class.cs (FixedField): Use non-dependent code only in the define phase.
6154 2007-12-23 Marek Safar <marek.safar@gmail.com>
6156 A fix for bug #348076
6157 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
6159 2007-12-22 Marek Safar <marek.safar@gmail.com>
6161 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
6162 discovered extension methods.
6164 2007-12-22 Marek Safar <marek.safar@gmail.com>
6166 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
6169 2007-12-21 Miguel de Icaza <miguel@novell.com>
6171 * report.cs (ErrorMessage): Add support for using colors on
6172 terminals that support it.
6174 2007-12-21 Marek Safar <marek.safar@gmail.com>
6176 * ecore.cs: Use information about expanded params for error reporting.
6178 2007-12-21 Marek Safar <marek.safar@gmail.com>
6180 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
6181 and logic for params overloads.
6183 2007-12-15 Miguel de Icaza <miguel@novell.com>
6185 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6186 as this is also created from the parser. Fixes #349034
6188 2007-12-12 Miguel de Icaza <miguel@novell.com>
6190 * statement.cs (Throw.CloneTo): it is valid to have empty
6191 expressions for throw.
6193 2007-12-03 Marek Safar <marek.safar@gmail.com>
6195 * cs-parser.jay: Set delegate constraint parsing region correctly.
6197 2007-12-03 Marek Safar <marek.safar@gmail.com>
6199 A fix for bug #345467
6200 * typemanager.cs (IsEqual): Compare generic parameters position only.
6202 2007-11-28 Marek Safar <marek.safar@gmail.com>
6204 * expression.cs (BaseAccess): Type arguments can be null.
6206 2007-11-27 Raja R Harinath <harinath@gmail.com>
6208 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6209 consistent even when an error has occured.
6210 (Switch.Resolve): Likewise.
6212 2007-11-22 Marek Safar <marek.safar@gmail.com>
6214 A fix for bug #334505
6215 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6218 2007-11-22 Marek Safar <marek.safar@gmail.com>
6220 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6221 refactorings required to resolve extension methods correctly when mixing
6222 generics and non-generics members.
6224 2007-11-20 Marek Safar <marek.safar@gmail.com>
6226 A fix for bug #342584
6227 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6230 2007-11-19 Marek Safar <marek.safar@gmail.com>
6232 A fix for bug #342512
6233 * delegate.cs: Use delegate argument expression when is available. Don't
6234 emit virtual call when class is sealed.
6236 2007-11-16 Marek Safar <marek.safar@gmail.com>
6238 A fix for bug #325423
6239 * assign.cs (FieldInitializer): Use resolved expression for emit.
6241 * class.cs: Print less confusing error message.
6243 2007-11-16 Marek Safar <marek.safar@gmail.com>
6245 * cs-tokenizer.cs: Removed GMCS ifdefs.
6247 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6250 * cs-parser.jay: Disabled nullable check.
6252 * generic-mcs: Copied more generic stuff.
6254 2007-11-16 Marek Safar <marek.safar@gmail.com>
6256 * gcs-parser.jay: Merged to cs-parser.jay.
6258 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6259 * *.csproj, *.sources: Updated to use only jay parser file.
6261 2007-11-16 Marek Safar <marek.safar@gmail.com>
6263 * gcs-parser.jay: Added nullable and default expression feature checks.
6265 2007-11-16 Marek Safar <marek.safar@gmail.com>
6267 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6268 it fixes many TODOs and hidden bugs.
6270 * expression: Removed duplicate error check.
6272 2007-11-15 Marek Safar <marek.safar@gmail.com>
6274 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6275 implicitly type local variable only when it is used in a declaration.
6277 2007-11-15 Marek Safar <marek.safar@gmail.com>
6279 * attribute.cs: Use CS0612 for empty strings.
6281 2007-11-14 Marek Safar <marek.safar@gmail.com>
6283 * lambda.cs, statement.cs: Contextual return may act as a statement.
6285 2007-11-14 Marek Safar <marek.safar@gmail.com>
6287 A fix for a regression cause by #324222
6288 * class.cs: Don't report unused even when it implements an interface.
6290 2007-11-13 Marek Safar <marek.safar@gmail.com>
6292 A fix for bug #341205
6293 * ecore.cs, expression.cs: Method group expression cannot do static
6294 method access with an instance reference check before overloading takes
6297 2007-11-13 Marek Safar <marek.safar@gmail.com>
6299 A fix for bug #325359
6300 * class.cs: Use predictable name for automatically generated property.
6302 2007-11-12 Marek Safar <marek.safar@gmail.com>
6304 A fix for bug #324996
6305 * expression.cs (Is): Handle case where D is nullable and T is not
6308 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6310 2007-11-12 Marek Safar <marek.safar@gmail.com>
6312 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6313 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6314 Flush small error reporting changes.
6316 2007-11-09 Marek Safar <marek.safar@gmail.com>
6318 A fix for bug #324996
6319 * expression.cs: Rewrote Is expression implementation to work with
6320 generics, nullable types, anonymous method. A const result expression
6321 uses existing infrastructure instead of custom not fully-featured one.
6323 2007-11-08 Marek Safar <marek.safar@gmail.com>
6325 A fix for bug #340202
6326 * class.cs: Consider generics for volatile field.
6328 2007-11-08 Marek Safar <marek.safar@gmail.com>
6330 A fix for bug #335594
6331 * expression.cs: Use conversion rules when handling string addition.
6333 2007-11-07 Marek Safar <marek.safar@gmail.com>
6335 A fix for bug #336651
6336 * expression.cs: Fixed a crash when probing is on.
6338 2007-11-07 Marek Safar <marek.safar@gmail.com>
6340 A fix for bug #324242
6341 * covert.cs: Added a conversion from any nullable-type with an
6342 underlying enum-type to the type System.Enum.
6344 2007-11-07 Marek Safar <marek.safar@gmail.com>
6346 A fix for bug #324222
6347 * class.cs: Report all non-used event fields.
6349 2007-11-07 Marek Safar <marek.safar@gmail.com>
6351 A fix for bug #325161
6352 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6353 qualifier for generic types.
6355 2007-11-07 Marek Safar <marek.safar@gmail.com>
6357 A fix for bug #322971
6358 * expression.cs, ecore.cs: Added intermediate result value check for
6361 2007-11-07 Marek Safar <marek.safar@gmail.com>
6363 A fix for bug #324754
6364 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6365 when it was requested.
6367 2007-11-07 Marek Safar <marek.safar@gmail.com>
6369 A fix for bug #325101
6370 * expression.cs: Do type not value comparison for `is' expression.
6372 2007-11-07 Marek Safar <marek.safar@gmail.com>
6374 A fix for bug #320236
6375 * convert.cs: Don't apply user conversion on underlying target type.
6377 2007-11-06 Marek Safar <marek.safar@gmail.com>
6379 * expression.cs: Don't use unresolved expression for error reporting.
6381 2007-11-06 Marek Safar <marek.safar@gmail.com>
6383 A fix for bugs #337712, #324490
6384 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6385 overloading resolution too.
6387 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6388 the process consistent and more robust.
6390 * expression.cs, linq.cs, report.cs: Update.
6392 2007-11-02 Marek Safar <marek.safar@gmail.com>
6394 A fix for bug #332909
6395 * attribute.cs: Resolve attributes in correct context using error
6398 * rootcontext.cs: Define Obsolete attribute members as core members.
6400 2007-11-02 Marek Safar <marek.safar@gmail.com>
6402 * statement.cs: Removed unused methods.
6404 2007-10-31 Wade Berrier <wberrier@novell.com>
6406 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6407 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6410 2007-10-31 Marek Safar <marek.safar@gmail.com>
6412 A fix for bug #338102
6413 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6414 methods registered as non-generics.
6416 2007-10-31 Marek Safar <marek.safar@gmail.com>
6418 A fix for bugs #337712, #324490
6419 * delegate.cs: Delegate covariance and contravariance is not allowed for
6422 2007-10-31 Marek Safar <marek.safar@gmail.com>
6424 A fix for bug #337719
6425 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6428 2007-10-30 Marek Safar <marek.safar@gmail.com>
6430 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6432 2007-10-29 Marek Safar <marek.safar@gmail.com>
6434 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6437 2007-10-29 Raja R Harinath <rharinath@novell.com>
6439 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6441 2007-10-29 Marek Safar <marek.safar@gmail.com>
6443 A fix for bug #334652
6444 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6445 extension methods when we have not found the best candidate in normal
6448 2007-10-27 Marek Safar <marek.safar@gmail.com>
6450 * AssemblyInfo.cs: Keep up-to-date.
6452 2007-10-27 Marek Safar <marek.safar@gmail.com>
6454 * Makefile: Fixed generics compiler name.
6456 2007-10-27 Marek Safar <marek.safar@gmail.com>
6458 * lambda.test: removed, lambda parsing is done differently.
6460 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6462 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6464 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6466 2007-10-27 Marek Safar <marek.safar@gmail.com>
6468 * Makefile, *.sources : All C# compilers are in mcs folder.
6470 * *.cs: Use existing 2_1 define for smcs.
6472 2007-10-26 Marek Safar <marek.safar@gmail.com>
6474 A fix for bug #335847
6475 * assign.cs, expression.cs: Couple of changes to avoid creating a
6476 temporary variable for each object initializer assignment statement. It
6477 simplifies struct initialization too, otherwise two temporary variables
6479 Implemented optimization of redundant default element initializers.
6481 2007-10-25 Marek Safar <marek.safar@gmail.com>
6483 A fix for bug #336766
6484 * expression.cs (Class.CheckBase): Use generic name when method is
6487 2007-10-25 Marek Safar <marek.safar@gmail.com>
6489 A fix for bug #334737
6490 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6491 variable and not variable argument for prepared copies.
6493 2007-10-24 Marek Safar <marek.safar@gmail.com>
6495 A fix for bug #325110
6496 * class.cs, expression.cs, attribute.cs: Use open generic method when
6497 checking conditional attribute.
6499 2007-10-24 Marek Safar <marek.safar@gmail.com>
6501 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6502 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6503 FeatureIsNotAvailable.
6505 2007-10-24 Marek Safar <marek.safar@gmail.com>
6507 ** C# 3.0 Partial methods
6509 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6510 methods support. Because of member cache issue with generics only
6511 non-generics partial methods are fully supported.
6513 2007-10-23 Marek Safar <marek.safar@gmail.com>
6515 * class.cs, decl.cs: Rewrote member overloads check to cope with
6516 generics and to use member cache for member checking. It also improves
6517 performance and fixes remaining overloads issues.
6519 2007-10-20 Marek Safar <marek.safar@gmail.com>
6521 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6522 roottypes.cs, typemanager.cs:
6524 A member cache creation logic changed to add members immediately and
6525 not rely on fallback. The member cache is now only prefered way
6526 how to access and find type declaration members. It saves 5 MB of memory
6527 during MWF compilation and makes code ready for more optimizations and
6528 clean-ups, it's also a pre-requirement for partial methods.
6530 2007-10-18 Raja R Harinath <harinath@gmail.com>
6532 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6533 handling for generic parameters.
6535 2007-10-15 Marek Safar <marek.safar@gmail.com>
6537 * class.cs (FixedField): Removed redundant volatile check.
6539 2007-10-15 Marek Safar <marek.safar@gmail.com>
6541 * class.cs, decl.cs: Fixed overload members verification to do only one
6542 check per possible collision.
6544 2007-10-13 Marek Safar <marek.safar@gmail.com>
6546 A fix for bug #325478
6547 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6548 and create only one disposable flags container.
6550 2007-10-12 Marek Safar <marek.safar@gmail.com>
6552 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6553 * statement.cs (Fixed): Fixed variables cloning.
6555 2007-10-12 Marek Safar <marek.safar@gmail.com>
6557 A fix for bug #333342
6558 * class.cs (EventField): Don't mark value type event as synchronized.
6560 2007-10-12 Marek Safar <marek.safar@gmail.com>
6562 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6563 inference to identify best candidate method correctly.
6564 (ProperyExpr): A range variable is read only and cannot be modified.
6566 2007-10-11 Marek Safar <marek.safar@gmail.com>
6568 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6569 logic to identify best candidate method correctly.
6571 2007-10-11 Marek Safar <marek.safar@gmail.com>
6573 * location.cs (Equals, GetHashCode): Removed.
6575 2007-10-11 Marek Safar <marek.safar@gmail.com>
6577 * report.cs: Implemented message recorder. It is used mainly for lambda
6578 expressions to capture otherwise swallowed error messages.
6580 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6582 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6584 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6586 * expression.cs (MemberAccess): Always report lookup failure.
6588 * location.cs: Implemented Equals, GetHashCode.
6590 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6592 2007-10-10 Jb Evain <jbevain@novell.com>
6594 * codegen.cs: re-enable assembly version check.
6596 2007-10-09 Marek Safar <marek.safar@gmail.com>
6598 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6601 * namespace.cs (UsingAlias): Do correct version check.
6603 2007-10-08 Marek Safar <marek.safar@gmail.com>
6605 * expresison.cs, ecore.cs: Issue extension method error message when
6608 * rootcontext.cs: Added ISO_2 compiler mode option.
6610 2007-10-08 Marek Safar <marek.safar@gmail.com>
6612 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6615 2007-10-08 Marek Safar <marek.safar@gmail.com>
6617 * attribute.cs (GetString, GetBoolean): Work with both literal and
6620 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6621 Moved method overload specific methods to MethodGroupExpr.
6623 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6624 it should be less memory consuming.
6626 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6628 * codegen.cs: remove the assembly version check until the buildbot is
6631 2007-10-07 Jb Evain <jbevain@novell.com>
6633 * attribute.cs (Attribute.GetString): if the value
6634 expression is a StringConstant, return its string value.
6636 2007-10-07 Jb Evain <jbevain@novell.com>
6638 * typemanager.cs: add `assembly_version_attribute_type`.
6639 * codegen.cs: on attribute emission, check that the
6640 AssemblyVersionAttribute doesn't overflow.
6642 2007-10-05 Marek Safar <marek.safar@gmail.com>
6644 A fix for bug #324677
6645 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6646 parent container of a scope container with currently resolved one.
6648 2007-10-05 Marek Safar <marek.safar@gmail.com>
6650 A fix for bug #325534
6651 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6654 2007-10-05 Marek Safar <marek.safar@gmail.com>
6656 A fix for bug #327504
6657 * class.cs (Operator.Define): Refactored implicit and explicit user
6658 operator conversion rules.
6660 2007-10-05 Marek Safar <marek.safar@gmail.com>
6662 A fix for bug #327520
6663 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6665 2007-10-04 Marek Safar <marek.safar@gmail.com>
6667 A fix for bug #328022
6668 * class.cs (MethodData.Define): Use correct method to check whether
6669 a method implementents an accessor.
6671 2007-10-04 Marek Safar <marek.safar@gmail.com>
6673 A fix for bug #330069
6674 * statement.cs (Fixed.Resolve): Read the first array element only when
6675 an array is instantiated.
6677 2007-10-04 Marek Safar <marek.safar@gmail.com>
6679 * expression.cs, assign.cs, generics.cs: Print correct operator when
6680 compound assignment is used.
6682 2007-10-04 Marek Safar <marek.safar@gmail.com>
6684 A fix for bug #325841
6685 * expression.cs (ArrayAccess): Use full argument cloning only for
6686 string compound concatenation.
6688 2007-10-03 Marek Safar <marek.safar@gmail.com>
6690 A fix for bug #328774
6691 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6693 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6696 2007-10-03 Raja R Harinath <rharinath@novell.com>
6699 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6700 Event accessibility checks here. Remove some bogus code that
6701 accidently made GenericMethods work.
6702 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6704 2007-09-25 Marek Safar <marek.safar@gmail.com>
6706 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6708 * statement.cs (Block): Refactored AddVariable to allow error handling
6711 * generic.cs: New stub.
6713 2007-09-23 Marek Safar <marek.safar@gmail.com>
6715 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6718 2007-09-17 Marek Safar <marek.safar@gmail.com>
6720 * class.cs: Use partial container to record whether any partial part
6721 contains static field initializer and therefore default contructor has
6724 2007-09-14 Marek Safar <marek.safar@gmail.com>
6726 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6727 mono-list when only one of two partial parts has defined accessibility
6730 2007-09-14 Marek Safar <marek.safar@gmail.com>
6732 A fix for bug #82845
6734 * class.cs (TypeContainer): Set correct resolve context for all field
6737 2007-09-13 Marek Safar <marek.safar@gmail.com>
6739 * assign.cs: Fixed a crash when field is resolved twice with an error.
6741 * codegen.cs: Changed InFieldInitializer to be flag.
6743 * anonymous.cs, ecore.cs, expression.cs: Update after
6744 IsInFieldInitializer rename.
6746 * const.cs: Removed unused parameter.
6748 * class.cs: Changed the way how we resolve and emit field initializers.
6749 The field initilizers have to have access to contructor block to emit
6750 compiler generated code.
6752 2007-09-13 Marek Safar <marek.safar@gmail.com>
6754 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6755 generics use TypeContainer instead.
6757 2007-09-12 Marek Safar <marek.safar@gmail.com>
6759 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6761 * lambda.cs (ResolveParameters): Use more powerful
6762 InflateGenericArgument.
6764 * parameters.cs: Better exception message.
6766 2007-09-10 Marek Safar <marek.safar@gmail.com>
6768 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6769 correct expression block type.
6771 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6773 * expression.cs (Invocation): Extracted method group resolve to
6776 2007-09-07 Marek Safar <marek.safar@gmail.com>
6778 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6779 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6781 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6782 generic extension methods.
6784 2007-09-06 Marek Safar <marek.safar@gmail.com>
6786 A fix for bug #82676 (Do I get it right now?)
6787 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6788 object before a standard conversion is applied.
6790 2007-09-06 Marek Safar <marek.safar@gmail.com>
6792 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6795 2007-09-05 Marek Safar <marek.safar@gmail.com>
6797 A fix for bug #82676
6798 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6799 non-generic interface types.
6801 2007-09-05 Marek Safar <marek.safar@gmail.com>
6803 A fix for bug #82690
6804 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6806 2007-09-05 Marek Safar <marek.safar@gmail.com>
6808 A fix for bug #82571
6809 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6810 modifier for container based methods.
6812 2007-09-05 Marek Safar <marek.safar@gmail.com>
6814 A fix for bug #82676
6815 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6816 any interface-type T means to any of interface type T.
6818 2007-09-04 Marek Safar <marek.safar@gmail.com>
6820 * namespace.cs: We have 2 versions of System.Core assembly.
6822 2007-09-04 Marek Safar <marek.safar@gmail.com>
6824 A fix for bug #82652
6825 * class.cs (Class.GetClassBases): Compare types and not expressions.
6827 2007-09-04 Marek Safar <marek.safar@gmail.com>
6829 A fix for bug #82620
6830 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6831 actually never worked before.
6832 (IndexerAccess): Emit prepared arguments before they are modified.
6834 2007-09-04 Marek Safar <marek.safar@gmail.com>
6836 A fix for bug #82563
6837 * assign.cs: Revert wrong fix.
6839 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6841 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6842 Instead of ldelema/stdind we have to use temporary variables to handle
6843 cases like String.Concat (params string[]).
6845 2007-08-31 Marek Safar <marek.safar@gmail.com>
6847 * class.cs: EmitAttributes to Emit rename.
6849 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6851 (MemberCore.HasClsCompliantAttribute): Don't depend on
6852 GetClsCompliantAttributeValue execution.
6854 2007-08-31 Marek Safar <marek.safar@gmail.com>
6856 * anonymous.cs: Use shorter type prefix.
6858 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6861 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6862 variables when probing is on.
6864 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6865 unresolved variables.
6866 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6867 handle transparent identifiers.
6869 2007-08-26 Marek Safar <marek.safar@gmail.com>
6871 * attribute.cs (IsClsCompliant): Add nullable types test.
6873 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6875 * doc.cs : catch other types of exception than XmlException to
6876 report CS1570. Fixed bug #82565.
6878 2007-08-23 Marek Safar <marek.safar@gmail.com>
6880 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6881 The number of delegate parameters has to match.
6882 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6885 2007-08-21 Marek Safar <marek.safar@gmail.com>
6887 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6888 to fix problem with private arguments.
6890 2007-08-20 Marek Safar <marek.safar@gmail.com>
6892 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6894 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6896 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6897 empty. Add cloning suport.
6899 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6901 2007-08-20 Marek Safar <marek.safar@gmail.com>
6903 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6904 to create EmptyCast. It handles EmptyConstantCast specialization for
6907 2007-08-18 Marek Safar <marek.safar@gmail.com>
6909 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6910 (EmitArrayArgument): One routine for array arguments.
6911 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6913 2007-08-17 Marek Safar <marek.safar@gmail.com>
6915 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6917 2007-08-17 Marek Safar <marek.safar@gmail.com>
6919 * anonymous.cs: MemberLookupFinal update.
6921 * class.cs (ConstructorInitializer): Is expression based.
6923 * delegate.cs: MethodGroupExpr update.
6925 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6927 (Error_MemberLookupFailed): Customizable error override.
6928 (MethodGroupExpr): Keep queried type for later usage.
6929 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6932 * expression.cs: Error_MemberLookupFailed refactoring.
6933 (New.DoResolve): Resolve as much as possible.
6934 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6935 customization for invalid member types.
6937 * statement.cs: MethodGroupExpr update.
6939 2007-08-16 Marek Safar <marek.safar@gmail.com>
6941 * modifier.cs (Check): Check all modifiers and not only accessibility
6944 2007-08-16 Marek Safar <marek.safar@gmail.com>
6946 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6947 type and not an expression.
6949 2007-08-16 Marek Safar <marek.safar@gmail.com>
6951 * statement.cs (Catch.Clone): Type and variable can be null.
6953 2007-08-16 Marek Safar <marek.safar@gmail.com>
6955 A fix for bug #81979
6956 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6957 I am really not sure whether this is the best fix.
6959 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6962 2007-08-14 Marek Safar <marek.safar@gmail.com>
6964 ** C# 3.0 Object and collection initializers (major re-write)
6966 * assign.cs (DoResolve): Initializers are not assign related.
6968 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6969 used during collection or object initialization.
6971 * expression.cs (Error_InvalidArguments): Add initializers specific
6972 messages. More will come later because it requires some general
6974 (New.DoResolve): Better error handling for unsafe types.
6975 (EmptyExpressionStatement): New class.
6976 (ElementInitializer): An object initializer expression.
6977 (CollectionElementInitializer): A collection initializer expression.
6978 (CollectionOrObjectInitializers): A block of object or collection
6980 (NewInitialize): New expression with element/object initializers.
6982 * statement.cs: Reverted object/collection initializer hacks.
6984 * typemanager.cs (CSharpName): Filter __arglist type.
6986 2007-08-09 Marek Safar <marek.safar@gmail.com>
6988 ** C# 3.0 Anonymous Types (update to the latest standard)
6990 * expression.cs (Binary.ResolveOperator): Threat all null based types
6992 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6993 (AnonymousTypeParameter): Updated.
6995 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6996 (AnonymousTypeClass): New anonymous type container.
6998 * class.cs (AddField): Return operation result.
7000 * generic.cs: Another empty TypeArguments overload.
7002 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
7003 are stored at top of normal hierarchy.
7005 * typemanager.cs (CSharpName): Filter anonymous types.
7007 2007-08-09 Marek Safar <marek.safar@gmail.com>
7009 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
7010 as single Concat call. How could we miss that :-(
7012 2007-08-08 Marek Safar <marek.safar@gmail.com>
7014 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
7016 2007-08-07 Miguel de Icaza <miguel@novell.com>
7018 * expression.cs: Fix the previous commit, the creation of the
7019 arguments array list needs also to be conditional on the arguments
7022 * class.cs: Add a little bit of help to help narrow down problems.
7024 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
7025 not try to copy in that case.
7027 * driver.cs: When building SMCS, include a new different set of
7028 default assemblies here. Do this here so we can control whether
7029 to include the default assemblies with /noconfig.
7031 2007-08-03 Marek Safar <marek.safar@gmail.com>
7033 A fix for bug #81979
7034 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
7037 2007-08-03 Marek Safar <marek.safar@gmail.com>
7039 A fix for bug #82300
7041 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
7042 we are in probing scope.
7044 2007-08-03 Marek Safar <marek.safar@gmail.com>
7046 A fix for bug #82301
7048 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
7049 (Statement.CloneTo): Clone and not map children blocks.
7051 2007-08-03 Marek Safar <marek.safar@gmail.com>
7053 A fix for bug #82299
7055 * expression.cs (LocalVariableReference.CloneTo): Remap local info
7058 * statement.cs (Statement.CloneTo): Clone variables before statements
7059 to allow remaping of local variables.
7061 2007-08-03 Marek Safar <marek.safar@gmail.com>
7063 A fix for bug #82296
7066 * report.cs: Log crash details for future clone problems.
7068 * statement.cs (Return.Clone): Don't clone non-existent expression.
7070 2007-08-03 Raja R Harinath <harinath@gmail.com>
7072 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
7073 (Class.AddBasesForPart): Move CS0537 check here from ...
7074 * cs-parser.jay (class_declaration): ... here. Move calling of
7075 'AddBasesForPart' to ...
7076 (class_bases): ... here.
7077 (struct_declaration, interface_declaration): Update to changes.
7079 2007-08-02 Marek Safar <marek.safar@gmail.com>
7081 A fix for bug #81923
7083 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
7084 conversion is allowed.
7086 2007-08-02 Marek Safar <marek.safar@gmail.com>
7088 A fix for bug #81564
7090 * ecore.cs (EventExpr): Add IsBase handling.
7092 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
7095 2007-08-02 Raja R Harinath <harinath@gmail.com>
7097 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
7098 * cs-parser.jay: Some whitespace cleanups.
7099 (current_delegate): New.
7101 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
7102 a dummy code block, and use 'type_name' instead of 'member_name'.
7103 (interface_declaration, class_declaration): Likewise.
7104 (delegate_declaration): Likewise. Rearrange slightly and use
7106 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
7107 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
7109 2007-08-02 Marek Safar <marek.safar@gmail.com>
7111 A fix for bug #82039
7113 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
7116 * typemanager.cs (CSharpName): Split to string overload.
7118 2007-08-02 Marek Safar <marek.safar@gmail.com>
7121 * report.cs: Updated warning CS0472.
7123 2007-08-01 Marek Safar <marek.safar@gmail.com>
7125 A fix for bug #82181
7127 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
7129 2007-08-01 Marek Safar <marek.safar@gmail.com>
7131 A fix for bug #82277
7132 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
7134 2007-08-01 Marek Safar <marek.safar@gmail.com>
7136 ** C# 3.0 Type Inference (major bits are working)
7138 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
7139 (.ImplicitStandardConversionExists): Uses compatible.
7140 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
7141 (.InferReturnType): New method.
7142 (.Compatible): Refactored.
7143 (.ResolveParameters): Uses factory to create resolved parameters.
7144 (.CompatibleMethod): Add probing mode support.
7145 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
7146 clearly distinguish between 2 different operations.
7147 (LambdaMethod): Moved to lambda.cs.
7148 (AnonymousMethod): Removed unused fields and methods.
7149 (AnonymousDelegate): Simplified.
7151 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
7153 * convert. cs (ImplicitConversionStandard): Compatible works differently.
7155 * delegate.cs (Delegate): New mehods to reduce code duplication.
7156 (.GetConstructor): New method.
7157 (.GetInvokeMethod): New method.
7158 (DelegateCreation): Updated.
7160 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
7162 (OverloadResolve): Made probing little bit faster.
7164 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
7167 * generic.cs (TypeInferenceContext): Dummy implementation.
7169 * iterators.cs: Updated after Resolve/Define rename.
7171 * lambda.cs (LambdaExpression)
7172 (.ResolveParameters): Handles both type of arguments and type inference too.
7174 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
7175 (InflateTypes): Updated.
7177 * support.cs (InflateTypes): Changed signature and updated.
7179 * typemanager.cs (LookupMemberCache): Better dynamic type check.
7180 (MemberLookup_FindMembers): More MS tricks.
7181 (GetParameterData): Ditto.
7182 (GetDelegateParameters): Uses quick path for dynamic types.
7184 2007-08-01 Marek Safar <marek.safar@gmail.com>
7186 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7189 2007-07-31 Marek Safar <marek.safar@gmail.com>
7191 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7194 2007-07-26 Jb Evain <jbevain@novell.com>
7196 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7197 which takes a boolean 'report_errors', similar to the GetMethod.
7198 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7199 in .net 2.1, do not report errors here.
7201 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7202 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7203 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7206 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7207 of the type InternalsVisibleToAttribute before the first call
7208 to CoreLookupType which is allowed to fail (third boolean parameter
7209 to true). Because, during the resolution for a type that is not
7210 immediately found, we try to check if the type is not defined in
7211 a friend assembly, and to do so, we need the
7212 InternalVisibleToAttribute.
7214 2007-07-23 Miguel de Icaza <miguel@novell.com>
7216 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7217 feature that allows structs to be compared against null and inline
7218 the result as true or false.
7220 Notice that the same code is not permitted inside a generic block
7221 of code that would do:
7223 class Foo<T> where T : struct {
7230 It is only allowed if the type of T is not bound (no where
7231 clause). In my opinion, this CSC 2 behavior is broken but people
7232 seem to be using it (IronRuby does, a few bug reports on bugzilla
7233 have it and some people have complained about it).
7235 All of the users that depend on this behavior have code that is
7238 * report.cs (Warning, Error): make these take object arguments,
7239 not strings, as that allows us to take advantage of Format.
7241 2007-07-20 William Holmes <billholmes54@gmail.com>
7243 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7244 Left member variable for the Count.
7245 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7246 MemberName.CountTypeArguments to avoid a NRE.
7248 This code is contributed under the MIT X11 license
7250 2007-07-18 Marek Safar <marek.safar@gmail.com>
7252 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7254 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7256 * doc.cs : generic method arguments are written as ``x while generic
7257 type arguments are `x. Combined with the previous change, fixed bug
7260 2007-07-18 Raja R Harinath <rharinath@novell.com>
7263 * expression.cs (Binary.ResolveOperator): When converting
7264 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7266 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7268 * doc.cs : when T: or whatever x: is specified, it does not really
7269 check the doc comment's syntax correctness. Fixed bug #82006.
7271 2007-07-18 Marek Safar <marek.safar@gmail.com>
7273 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7274 LambdaExpression better.
7276 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7278 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7280 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7281 as it can be generated.
7283 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7286 * lambda.cs (LambdaExpression): Refactored to share same code with
7287 AnonymousMethodExpression.
7289 2007-07-17 Marek Safar <marek.safar@gmail.com>
7291 * anonymous.cs (MakeName): Include host name for easier debugging.
7292 (LambdaMethod): New class for lambda spcecific stuff.
7294 * attribute.cs: Set EmitContext return type.
7296 * class.cs: Set EmitContext return type.
7298 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7299 with null/void meaning.
7301 * iterators.cs (ContainerType): Implemented.
7303 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7305 * statement.cs (Return): Updated to lambda expressions.
7306 (Block.CloneTo): Parent can be null.
7308 2007-07-13 Marek Safar <marek.safar@gmail.com>
7310 A fix for bug #81917
7311 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7313 * class.cs (FixedField): Check whether field is in unsafe scope.
7315 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7316 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7318 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7321 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7323 2007-07-13 Marek Safar <marek.safar@gmail.com>
7325 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7326 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7329 2007-07-13 Marek Safar <marek.safar@gmail.com>
7331 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7333 2007-07-13 Marek Safar <marek.safar@gmail.com>
7335 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7336 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7338 * codegen.cs(EmitContext): Add ProbingMode flag.
7340 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7342 * driver.cs: For now set both warning values.
7344 * ecore.cs (SimpleName): Name is readonly.
7345 (MethodGroup.OverloadResolve): One quick path for probing.
7347 * expression.cs (Unary): Set Oper r/o.
7348 (Binary): Set Oper r/o.
7349 (ParameterReference): Set few instance variables as r/o.
7350 (ParameterReference.DoResolveBase): Don't capture aruments when
7352 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7353 (Arglist): arguments are private.
7354 (SizeOf): type is private and r/o.
7355 (MemberAccess): arguments are private.
7357 * report.cs: Enhanced reporting on/off capabilities.
7359 * lambda.cs: Uses ec.IsInProbingMode.
7360 (ContextualReturn): Derives from return.
7362 * rootcontext.cs: For now set both warning values.
7364 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7366 (Return.Resolve): Don't die immediately.
7367 (Block.Resolve): Speed-up probing.
7368 (Block.CloneTo): Clone only child blocks.
7370 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7372 * iterators.cs: reverted Miguel's latest change (r81925) as it
7373 breaks the build in System.
7375 2007-07-13 Miguel de Icaza <miguel@novell.com>
7377 * iterators.cs (Yield.CheckContext): Check for the iterator type
7378 also here as we can call into Yield even in codepaths that are not
7380 (MethodOrOperator is the only path that was checked).
7382 In addition to the standard check, use a more specific check for
7383 constructors to report a more verbose error.
7385 2007-07-12 Miguel de Icaza <miguel@novell.com>
7387 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7388 report the warning and continue
7390 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7391 values on the stack on the call to Emit. Use EmitStatement if
7392 possible, or using Emit + Pop if not possible. Fixes #82064
7394 2007-07-12 Raja R Harinath <rharinath@novell.com>
7396 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7397 avoid try...finally in some cases.
7399 2007-07-10 Marek Safar <marek.safar@gmail.com>
7401 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7403 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7404 instead of method. Re-use standard error handling.
7405 (ConstructorInitializer.Emit): Simplified.
7407 * delegate.cs: Updated after Invocation.EmitCall change.
7409 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7410 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7411 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7412 method and don't permanently changing input arguments.
7413 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7414 is resolved it has one of the candidates is the best one which is later
7415 used to emit. Removed a few unused method.
7416 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7418 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7419 (Binary.ResolveOperator): Ditto.
7420 (ConditionalLogicalOperator.DoResolve): Ditto.
7421 (Invocation): Uses method group.
7422 (Invocation.DoResolve): Simplified.
7423 (Invocation.EmitCall): Removed useless is_static.
7424 (Invocation.Emit): Delegate to method group.
7425 (Invocation.EmitStatement): Simplified.
7426 (New): Uses method group.
7427 (MemberAccess.DoResolve): Don't destroy original expression.
7429 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7431 2007-07-04 Marek Safar <marek.safar@gmail.com>
7433 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7436 * lambda.cs: Add custom error message type.
7438 2007-07-03 Marek Safar <marek.safar@gmail.com>
7440 * lambda.cs: Simplified little bit.
7442 * parameter.cs: Introduced ImplicitLambdaParameter.
7443 (Parameters.CreateFullyResolved): New factory instead of ctor.
7447 * delegate.cs: Updated parameter creation.
7449 2007-07-03 Marek Safar <marek.safar@gmail.com>
7451 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7454 * generic.cs: Synchronized with gmcs.
7456 2007-07-03 Marek Safar <marek.safar@gmail.com>
7458 * class.cs (Indexer): Check return type as soon as possible.
7460 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7463 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7465 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7467 * parameter.cs (Parameter): Use expression type when it is available.
7469 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7470 method modifier for the first parameter only.
7472 2007-06-24 Marek Safar <marek.safar@gmail.com>
7474 A fix for bug #81938
7475 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7477 * constant.cs: Tide up an exception message.
7479 2007-06-22 Marek Safar <marek.safar@gmail.com>
7481 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7482 an uninitialized variable is used.
7484 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7486 2007-06-22 Marek Safar <marek.safar@gmail.com>
7488 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7489 not found error handling.
7491 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7493 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7494 (ArrayCreation.DoResolve): Simplified.
7495 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7496 its own resolve process.
7497 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7499 2007-06-20 Marek Safar <marek.safar@gmail.com>
7501 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7504 2007-06-20 Marek Safar <marek.safar@gmail.com>
7506 * cs-tokenizer.cs: Removed var related stuff.
7508 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7509 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7510 a type and a keyword at same time.
7512 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7515 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7516 implicitly typed arrays, more changes will follow.
7518 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7520 2007-06-19 Marek Safar <marek.safar@gmail.com>
7522 * ecore.cs (VarExpr): Removed Handled field.
7524 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7525 build-in assign functionality.
7526 (ForEach.Resolve): Removed all implicitly typed local variable code and
7528 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7529 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7531 2007-06-18 Marek Safar <marek.safar@gmail.com>
7533 * assign.cs: Removed implicitly typed local variable check.
7535 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7536 referencing implicitly typed local variable.
7537 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7540 * statement.cs (Fixed): Removed unsupported implicitly typed local
7543 2007-06-15 Marek Safar <marek.safar@gmail.com>
7545 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7547 2007-06-14 Marek Safar <marek.safar@gmail.com>
7549 A fix for bugs #81855 and #76274
7550 * attribute.cs (AttachTo): Always set owner for global attributes to
7553 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7556 * cs-parser.jay: Assembly and module attributes must precede all other
7557 elements except using clauses and extern alias declarations.
7559 2007-06-13 Marek Safar <marek.safar@gmail.com>
7561 A fix for bug #81748
7563 * expression.cs: More checks for non ISO-1 features.
7565 2007-06-12 Marek Safar <marek.safar@gmail.com>
7567 A fix for bug #81807
7568 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7569 present inside switch statement and it is required by nullable check.
7571 2007-06-12 Marek Safar <marek.safar@gmail.com>
7573 A fix for bug #81840
7574 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7575 when type matching fails.
7577 * namespace.cs: Tiny error message change.
7579 2007-06-12 Marek Safar <marek.safar@gmail.com>
7581 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7582 reporting. Added automatic property check.
7584 * class.cs: Updated after CheckAbstractAndExtern relocation.
7585 (AEventPropertyAccessor.GetSignatureForError): Customized.
7587 2007-06-11 Marek Safar <marek.safar@gmail.com>
7589 * class.cs (DefineBaseTypes): Base type can be undefined.
7591 * ecore.cs (TypeLookup): Minor refactoring.
7592 (DoResolveAsTypeStep): Removed redundant check.
7594 * namespace.cs (Lookup): Removed redundant check.
7596 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7597 ResolveAsTypeTerminal step.
7598 (BootstrapCorlib_*): Simplified.
7599 (PopulateCoreType): Core types can be now external.
7601 2007-06-07 Marek Safar <marek.safar@gmail.com>
7603 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7605 (InferTypeArguments): Infers anonymous expression type arguments.
7606 (Compatible): Split to Compatible and InferTypeArguments.
7608 * lambda.cs: Updated.
7610 2007-06-08 Marek Safar <marek.safar@gmail.com>
7612 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7614 2007-06-07 Raja R Harinath <harinath@gmail.com>
7616 Fix #80477, cs0135-2.cs, cs0135-3.cs
7617 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7618 names to the "known" variables list.
7619 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7620 parameter names are also "known".
7621 (Block.CheckError136): Remove.
7622 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7625 2007-06-07 Marek Safar <marek.safar@gmail.com>
7627 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7629 2007-06-06 Marek Safar <marek.safar@gmail.com>
7631 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7632 internal error not an user error.
7634 * expression.cs (IsApplicable): Refactored to make debugging easier.
7636 * support.cs: More tricks for non-mono runtimes.
7638 * typemanager.cs (CoreLookupType): Made public.
7639 (InitSystemCore): All linq specific stuff moved to linq.cs
7641 2007-06-05 Marek Safar <marek.safar@gmail.com>
7643 * typemanager.cs (CSharpSignature): One more missing build-in types
7645 More tricks for non-mono runtime.
7647 2007-06-05 Raja R Harinath <harinath@gmail.com>
7649 * statement.cs (Block.CheckError136_InParents): Remove.
7650 (Block.AddVariable): Use GetParameterInfo instead.
7651 (ToplevelBlock.ProcessArguments): Likewise.
7653 2007-06-04 Raja R Harinath <rharinath@novell.com>
7655 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7657 (ToplevelBlock.GetParameterInfo): Split out of ...
7658 (ToplevelBlock.GetParameterRefernce): ... this.
7659 (ToplevelBlock.ParameterMap): Remove.
7660 * expression.cs (ParameterReference): Update to use
7661 ToplevelParameterInfo.
7663 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7666 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7667 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7669 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7670 (ToplevelBlock.ProcessParameters) ... here.
7671 (ToplevelBlock..ctor): Invoke it.
7673 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7676 * statement.cs (IKnownVariable): New interface.
7677 (LocalInfo): Implement it.
7678 (ToplevelParameterInfo): New class.
7679 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7680 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7681 GetKnownVariableInfo.
7683 2007-06-03 Raja R Harinath <harinath@gmail.com>
7685 Partly speed up CS0136 error checks.
7686 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7687 'recurse' parameter.
7688 (Block.DoCheckError136): Only check errors in parameters. Move
7689 local variable checks ...
7690 (Block.AddVariable): ... here, and ...
7691 (ToplevelBlock.ResolveMeta): ... here.
7693 2007-06-02 Raja R Harinath <harinath@gmail.com>
7695 * statement.cs (Block.IsChildOf): Remove.
7697 * statement.cs (Statement.Clone): Move special case code ...
7698 (Block.CloneTo): ... here.
7700 2007-05-29 Raja R Harinath <rharinath@novell.com>
7702 * statement.cs (ToplevelBlock.container): Remove field. It's
7703 redundant with 'Parent'.
7704 (ToplevelBlock.ContainerBlock): Remove accessor.
7705 (ToplevelBlock..ctor): Update to changes. Register anonymous
7706 child with parent here, ...
7707 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7709 (start_anonymous): Don't save current_block.
7710 (top_current_block): Remove.
7712 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7713 (Block.Resolve): Update to changes.
7714 (Block..ctor): Move setting of "correct" 'Toplevel'
7715 and 'Explicit' fields to ...
7716 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7718 2007-05-27 Raja R Harinath <harinath@gmail.com>
7721 * statement.cs (Block.Implicit): Remove.
7722 (Block): Update to changes.
7723 * flowanalysis.cs: Likewise.
7725 Mildly speed up CheckInvariantMeaningInBlock
7726 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7727 Recursively call AddKnownVariable to all enclosing blocks.
7728 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7729 Remove recursive calls.
7730 (Block): Update to changes.
7732 New ExplicitBlock invariants
7733 * statement.cs (Block.Explicit): New field. It points to the
7734 immediately enclosing non-implicit block.
7735 (Block..ctor): Maintain the invariant.
7736 * cs-parser.jay: Take advantage of invariant.
7738 Introduce ExplicitBlock
7739 * statement.cs (ExplicitBlock): New.
7740 (ToplevelBlock): Derive from it.
7741 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7743 (Block.Implicit): Update to changes.
7744 * cs-parser.jay: Update to changes.
7747 * codegen.cs (EmitContext.IsLastStatement): Remove.
7748 * statement.cs (Block.DoEmit): Update to changes.
7750 2007-05-25 Raja R Harinath <rharinath@novell.com>
7752 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7753 modifying current_block directly.
7755 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7757 * class.cs: Implemented automatic properties (C# 3.0)
7758 Thanks to Marek for the help.
7760 2007-05-23 Raja R Harinath <rharinath@novell.com>
7762 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7763 variable as assigned, note also that all its components are
7765 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7767 2007-05-19 Marek Safar <marek.safar@gmail.com>
7769 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7770 member is marked as compiler generated.
7772 * decl.cs (MemberCore): Refactored ModFlags into property.
7774 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7775 (Check): Check only accessibility modifiers.
7777 2007-05-18 Raja R Harinath <rharinath@novell.com>
7779 Track all assignable slots in one bit array
7780 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7781 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7782 logic from VariableMap constructor here. Use the same 'offset'
7783 variable that's later used for computing offsets of local
7785 * flowanalysis.cs (UsageVector.parameters): Remove.
7786 (UsageVector): Update to changes.
7787 (VariableMap): Remove.
7789 Avoid creating ParameterMap in every block
7790 * statement.cs (Block.ParameterMap): Move ...
7791 (ToplevelBlock.ParameterMap): ... here.
7792 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7794 * flowanalysis.cs (FlowBranching.param_map): Remove.
7795 (FlowBranching.UsageVector): Update to changes.
7796 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7798 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7800 * expression.cs (ParameterReference): Distinguish between block
7801 where parameter was referenced and declared.
7803 2007-05-18 Marek Safar <marek.safar@gmail.com>
7805 * flowanalysis.cs, statement.cs: Put back improved error handling.
7807 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7811 Imporved object and collection initialization (C# 3.0).
7813 2007-05-15 Marek Safar <marek.safar@gmail.com>
7815 A fix for bug #81380
7816 * expression.cs (Is.DoResolve): Only value types have constant `is'
7819 2007-05-15 Raja R Harinath <rharinath@novell.com>
7821 * statement.cs (ToplevelBlock.child): Remove.
7823 2007-05-15 Raja R Harinath <harinath@gmail.com>
7825 Rationalize ResolveMeta: refactoring
7826 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7827 out constant handling code into ...
7828 (Block.DoResolveConstants): ... this.
7830 Rationalize ResolveMeta: kill local_map
7831 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7832 (Block.AssignableSlots): New.
7833 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7834 for locals -- move code from VariableMap here. Avoid unnecessary
7836 * flowanalysis.cs (FlowBranching.local_map): Remove.
7837 (FlowBranching..ctor): Use Block.AssignableSlots.
7838 (VariableMap): Remove unused constructors.
7840 2007-05-11 Raja R Harinath <rharinath@novell.com>
7842 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7844 2007-05-11 Marek Safar <marek.safar@gmail.com>
7846 * typemanager.cs (IsFriendAssembly): Should not be called for building
7849 2007-05-09 Marek Safar <marek.safar@gmail.com>
7851 * literal.cs (NullConstant): Print null in all cases.
7853 * expression.cs (Binary.ResolveOperator): Implemented delegate
7854 comparison based on C# 2.0 changes.
7856 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7858 This code is contributed under the MIT X11 license
7860 The following enables support for several C# 3.0 language features:
7862 * cs-tokenizer.cs: Added support for the "var" keyword.
7864 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7865 Added VarExpr class to facilitate type inferencing.
7867 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7868 to support anonymous types.
7870 * assign.cs: Added support for type inferencing and initialization.
7872 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7874 * expression.cs: Added implicit array support to ArrayCreation.
7875 Added 5 types and 1 interface:
7877 IInitializable Implementing classes can inject initializing
7878 statements after object instantiation.
7880 Initializer Stores data for object initialization.
7882 AnonymousType An expression for anonymous types.
7884 AnonymousTypeParameter Stores data about an anonymous type's field.
7886 NewInitialize An expression for object initialization.
7888 CollectionInitialize An expression for collection initialization.
7890 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7893 2007-05-06 Marek Safar <marek.safar@gmail.com>
7895 A fix for bug #81500
7896 * cs-tokenizer.cs: Add special handling for coalescing operator.
7898 2007-05-06 Marek Safar <marek.safar@gmail.com>
7900 A fix for bug #81529
7901 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7902 its value from base class until it is redefined.
7904 2007-05-02 Raja R Harinath <rharinath@novell.com>
7906 Fix regression in cs0631-3.cs
7907 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7908 fallback. Make error fallback catch more cases.
7910 2007-05-01 Miguel de Icaza <miguel@novell.com>
7912 * cs-parser.jay: Allow parameters in operator declarations to have
7915 2007-04-27 Miguel de Icaza <miguel@novell.com>
7917 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7920 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7921 inside the ContextualReturn, it does not have to be an
7922 ExpressionStatement.
7924 2007-04-24 Miguel de Icaza <miguel@novell.com>
7926 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7929 2007-04-23 Miguel de Icaza <miguel@novell.com>
7931 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7932 method in two methods: ResolveNoDefine and Resolve.
7934 ResolveNoDefine will stop just after ResolveTopBlock has been
7937 Resolve will then continue by creating a method and issuing the
7938 call to method.Define ().
7940 (AnonymousMethod): Split and implement the new Resolve and
7941 ResolveNoDefine as well.
7943 * lambda.cs (LambdaExpression): Split the anonymous method
7944 resolution code into a separate routine (CoreCompatibilityTest)
7945 from DoCompatibleTest.
7947 (LambdaExpression.TryBuild): New method, this method tries to
7948 build the LambdaExpression with the given set of types to be used
7949 as the types for the various parameters of the lambda expression.
7951 If the compilation succeed with the given types, the infered type
7952 of the Anonymous method is returned, otherwise null is returned.
7954 2007-04-23 Marek Safar <marek.safar@gmail.com>
7956 A fix for bug #81414
7957 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7959 2007-04-22 Miguel de Icaza <miguel@novell.com>
7961 * cs-tokenizer.cs: Change various identifiers here from the
7962 camelCasing to the recommended Linux-like style for instance
7963 variables from the Coding Guidelines.
7965 2007-04-19 Martin Baulig <martin@ximian.com>
7968 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7969 System.Enum to System.ValueType.
7971 2007-04-13 Martin Baulig <martin@ximian.com>
7973 Rewrote implicit reference conversions. We need to distinguish
7974 between implicit reference conversions (13.1.4) and implicit
7975 boxing conversions (13.1.5).
7977 According to the spec, there's an an implicit conversion
7978 "From a one-dimensional array-type S[] to IList<T> and base
7979 interfaces of this interface, provided there is an implicit
7980 reference conversion from S to T." Note that this does not
7981 include boxing conversions.
7984 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7985 (Convert.ImplicitReferenceConversion): Split into
7986 ImplicitReferenceConversionCore() and
7987 ImplicitBoxingConversionExist().
7988 (Convert.ImplicitReferenceConversionExists): Use the new
7989 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7991 2007-04-12 Martin Baulig <martin@ximian.com>
7993 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7994 `TypeManager.null_type' checks up to the top of the method.
7996 2007-04-11 Marek Safar <marek.safar@gmail.com>
7998 A fix for bug #81350
7999 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
8002 2007-04-11 Martin Baulig <martin@ximian.com>
8004 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
8005 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
8006 to make this work for generic classes; fixes #79561.
8008 2007-04-11 Martin Baulig <martin@ximian.com>
8010 * expression.cs (As): Add support for nullable types; fixes #79371.
8012 2007-04-11 Martin Baulig <martin@ximian.com>
8014 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
8015 `type.FullName' is null; fixes #80243.
8017 2007-04-11 Martin Baulig <martin@ximian.com>
8019 * expression.cs (Invocation.IsApplicable): Don't modify the method
8020 if type inference succeeded, but the method was not applicable.
8023 2007-04-10 Marek Safar <marek.safar@gmail.com>
8025 A fix for bug #81324
8026 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
8027 internal and external namespaces containers.
8029 2007-04-10 Martin Baulig <martin@ximian.com>
8031 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
8032 TypeManager.DropGenericMethodArguments() so we also call
8033 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
8035 2007-04-10 Martin Baulig <martin@ximian.com>
8037 * iterators.cs (Iterator.CreateIterator): Don't crash if
8038 `method.ReturnType' is null. This happens if something went wrong
8039 while resolving that typ (we already reported an error in this case).
8041 2007-04-10 Martin Baulig <martin@ximian.com>
8043 * expression.cs (New.DoResolve): Don't call CheckComImport() on
8044 generic interfaces; report the CS0144 directly.
8046 2007-04-10 Martin Baulig <martin@ximian.com>
8048 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
8049 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
8051 2007-04-10 Martin Baulig <martin@ximian.com>
8053 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
8055 2007-04-09 Raja R Harinath <rharinath@novell.com>
8058 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
8059 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
8062 * statement.cs (For.Resolve): If resolution fails, use
8065 2007-04-08 Marek Safar <marek.safar@gmail.com>
8067 * anonymous.cs (MakeName): Make faster and zero-based.
8068 (VerifyExplicitParameterCompatibility): Back to mode where generic
8069 parameter is ignored.
8070 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
8072 * class.cs (EmitType): Method can emit another new method.
8074 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
8076 * driver.cs: Updated.
8078 * lambda.cs: Reuse predefined empty parameters.
8080 * parameter.cs: Updated
8082 * support.cs: Implemented InflateTypes.
8084 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
8085 (InitSystemCore): Introduced to isolate 3.0 dependencies.
8087 2007-04-03 Martin Baulig <martin@ximian.com>
8091 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
8092 version of TypeManager.IsOverride() which also works with generic
8095 2007-04-03 Martin Baulig <martin@ximian.com>
8100 (Convert.ExplicitReferenceConversion): We need to cast when
8101 converting from IList<T> to S[].
8103 2007-04-01 Marek Safar <marek.safar@gmail.com>
8105 * decl.cs (FindExtensionMethods): Consider all candidates with same name
8108 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
8110 2007-03-31 Marek Safar <marek.safar@gmail.com>
8112 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
8113 argument and return type inferring.
8115 * codegen.cs (InferReturnType): Flag whether return can be inferred.
8116 (ReturnType): Turned to property.
8118 * statement.cs (Return): Implemented return type inferring.
8120 * support.cs (ReflectionParameters): Use local types if possible.
8122 2007-03-30 Raja R Harinath <rharinath@novell.com>
8124 * flowanalysis.cs (FlowBranching.Reachability): Remove.
8125 (FlowBranching.UsageVector): Update to changes.
8127 Prepare to kill 'Reachability'
8128 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
8129 argument of constructor.
8131 2007-03-29 Raja R Harinath <rharinath@novell.com>
8133 Prepare to kill 'Reachability'
8134 * flowanalysis.cs (UsageVector.is_unreachable): New.
8135 (UsageVector): Update to maintain 'is_unreachable' in parallel to
8136 'reachability', and verify they're consistent.
8139 * expression.cs (New.EmitStatement): Handle type parameters here too.
8141 2007-03-29 Martin Baulig <martin@ximian.com>
8146 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
8147 CompilerGeneratedClass.
8148 (ScopeInfo.EmitScopeInstance): Make this protected.
8149 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
8150 `ec.CurrentAnonymousMethod.Scope == Scope'.
8152 * statement.cs (Block.ScopeInfo): Make this a property.
8154 2007-03-27 Raja R Harinath <harinath@gmail.com>
8156 Prepare to kill 'Reachability'
8157 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
8158 (FlowBranching.UsageVector.Reachability): Remove property.
8159 (FlowBranching.UsageVector.IsUnreachable): New property.
8160 (FlowBranching.UsageVector.ResetBarrier): New.
8161 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
8162 * codegen.cs, statement.cs: Update to changes.
8164 2007-03-27 Martin Baulig <martin@ximian.com>
8169 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
8172 2007-03-26 Raja R Harinath <rharinath@novell.com>
8174 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
8175 instead of TriState. Remove all mention of TriState.
8177 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
8178 replaced by a boolean. Add boolean 'is_unreachable' field, check
8179 and maintain invariants.
8181 2007-03-25 Marek Safar <marek.safar@gmail.com>
8183 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8185 2007-03-25 Marek Safar <marek.safar@gmail.com>
8187 * expression.cs: Stop using obsolete 2.0 opcodes.
8189 2007-03-25 Marek Safar <marek.safar@gmail.com>
8191 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8192 one of the latests Martin's fixes.
8194 2007-03-23 Miguel de Icaza <miguel@novell.com>
8196 * expression.cs: On BigEndian systems, swap the bytes, temporary
8197 solution until we get a new bitconverter class.
8199 2007-03-23 Martin Baulig <martin@ximian.com>
8203 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8204 "Method" and "Method`1". Normally, a cache lookup is done on the
8205 "Method" form (ie. without the generic arity), but this one makes
8206 lookups on the full form work as well.
8208 2007-03-22 Raja R Harinath <rharinath@novell.com>
8210 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8213 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8215 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8216 ordered_member_list, to TypeBuilder to store members to be defined
8217 in the order they were parsed in.
8218 - ordered_explicit_member_list contains all properties indexers
8219 and methods that are defined as explicit implementation of an
8220 interface or base class.
8221 - ordered_member_list contains all properties indexers and methods
8222 that are not defined as explicit implementation of an interface
8225 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8226 functionality in these removed classes has been replaced with
8227 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8228 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8230 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8231 to CheckForDuplications inside GetMethod and SetMethod Define Method
8232 to handle method property and indexer name conflicts.
8236 All code is contributed under the MIT/X11 license.
8238 2007-03-20 Martin Baulig <martin@ximian.com>
8240 * class.cs (TypeContainer.Interfaces): Removed; they're now
8241 included in `TypeContainer.Types'.
8243 2007-03-20 Martin Baulig <martin@ximian.com>
8245 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8247 * class.cs (TypeContainer.CreateType): New public method. This is
8248 now called before DefineType() to create the TypeBuilders.
8249 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8250 has already been created by CreateType().
8251 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8252 don't resolve our base classes here; this has been moved into
8253 DefineBaseTypes(). We're now called from CreateType().
8254 (TypeContainer.DefineBaseTypes): New private method; resolve our
8255 base classes here. We're now called from DefineType().
8258 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8259 our types first to create all the TypeBuilders. After that, call
8260 TypeContainer.DefineType() on all the types which'll resolve their
8261 base classes and setup the resolve order.
8263 2007-03-20 Martin Baulig <martin@ximian.com>
8265 * class.cs (TypeContainer.Enums): Removed; they're now included in
8266 `TypeContainer.Types'.
8268 2007-03-20 Martin Baulig <martin@ximian.com>
8271 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8272 (TypeContainer.DoResolveMembers): Call DefineType() on our
8273 `compiler_generated' classes; moved here from DefineNestedTypes().
8276 (RootContext.ResolveTree): Call ResolveMembers() on all
8277 TypeContainer's in the `type_container_resolve_order'.
8279 2007-03-19 Marek Safar <marek.safar@gmail.com>
8281 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8283 2007-03-17 Marek Safar <marek.safar@gmail.com>
8285 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8286 implementation flags.
8288 2007-03-17 Marek Safar <marek.safar@gmail.com>
8290 * class.cs: More optimizations for type parameters.
8292 2007-03-15 Marek Safar <marek.safar@gmail.com>
8294 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8296 * ecore.cs, parameter.cs: More common code for both corlibs.
8298 * typemanager.cs (IsGenericMethod): Simplified.
8300 2007-03-15 Raja R Harinath <rharinath@novell.com>
8302 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8304 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8306 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8307 unconditionally. Simplify explanation.
8308 (Try.Resolve, Using.Resolve): Likewise.
8310 2007-03-15 Martin Baulig <martin@ximian.com>
8314 * decl.cs (DeclSpace): If we're a partial class, use our
8315 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8317 2007-03-15 Raja R Harinath <rharinath@novell.com>
8319 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8321 (FlowBranching.UsageVector): Update to changes.
8322 (FlowBranching.MergeSiblings): Likewise.
8323 * statement.cs: Likewise.
8325 2007-03-15 Martin Baulig <martin@ximian.com>
8330 (MemberCache): Added a special .ctor for type parameters.
8333 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8336 2007-03-09 Martin Baulig <martin@ximian.com>
8338 * enum.cs (Enum): Make this a TypeContainer.
8339 (EnumMember): Derive from `Const'.
8342 (Const.DoResolveValue): New protected virtual method; move most of
8343 the functionality of ResolveValue() here so we can override it in
8345 (Const.CreateConstantReference): Make this virtual.
8347 * class.cs (Kind): Add `Kind.Enum'.
8348 (TypeContainer.Emit): Don't emit the enums here; they're already
8349 in the `RootContext.typecontainer_resolve_order'.
8351 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8352 here; they're already in the `typecontainer_resolve_order'.
8354 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8355 TypeManager.DropGenericTypeArguments().
8358 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8359 (TypeManager.IsEnumType): Likewise.
8360 (TypeManager.EnumToUnderlying): Likewise.
8361 (TypeManager.IsEqual): Add support for enums.
8363 2007-03-12 Raja R Harinath <rharinath@novell.com>
8365 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8366 DefaultParameterValueAttribute to be undefined, say if System.dll
8369 2007-03-11 Marek Safar <marek.safar@gmail.com>
8371 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8374 2007-03-10 Marek Safar <marek.safar@gmail.com>
8376 * class.cs, parameter.cs: Unified parameters verification.
8378 2007-03-08 Martin Baulig <martin@ximian.com>
8380 * cs-parser.jay (constructor_header): Pass the location to the
8381 newly created TopLevelBlock.
8383 2007-03-07 Martin Baulig <martin@ximian.com>
8385 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8387 2007-03-06 Miguel de Icaza <miguel@novell.com>
8389 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8390 with the changes from David, fixes the build.
8392 2007-03-05 David Mitchell <dmitchell@logos.com>
8394 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8395 and its base interfaces to a one-dimensional array type S[],
8396 provided there is an implicit or explicit reference conversion
8399 2007-03-03 Marek Safar <marek.safar@gmail.com>
8401 * cs-tokenizer.cs: Implemented basic linq grammar.
8403 * driver.cs: Set linq lang version on demand.
8405 2007-02-26 Marek Safar <marek.safar@gmail.com>
8407 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8409 2007-02-25 Marek Safar <marek.safar@gmail.com>
8411 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8414 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8416 Check property and event extern attributes.
8418 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8421 2007-02-24 Marek Safar <marek.safar@gmail.com>
8423 A fix for bug #80407
8424 * ecore.cs: Don't report ambiguity error when methods have same parent.
8426 2007-02-23 Marek Safar <marek.safar@gmail.com>
8428 A fix for bug #80878
8429 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8431 2007-02-22 Marek Safar <marek.safar@gmail.com>
8433 * attribute.cs: Enable ExtensionAttribute presence test.
8435 2007-02-22 Marek Safar <marek.safar@gmail.com>
8437 * class.cs: Warn about missing GetHashCode only when Equals is override.
8439 * decl.cs: Check accessibility of type arguments.
8441 * typemanager.cs: Correctly report nullable array.
8443 2007-02-20 Marek Safar <marek.safar@gmail.com>
8445 * class.cs, report.cs: Capture more details when things go wrong.
8447 2007-02-20 Marek Safar <marek.safar@gmail.com>
8449 A fix for bug #80650
8450 * cs-parser.jay: Anonymous container starts at constructor declaration
8451 and not at block beginning because it has to be usable in constructor
8454 * statement.cs: Use context location and not block one for error reporting.
8456 2007-02-18 Marek Safar <marek.safar@gmail.com>
8458 A fix for bug #78712
8459 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8462 2007-02-18 Marek Safar <marek.safar@gmail.com>
8464 A fix for bug #80493 by Atsushi Enomoto
8465 * cs-parser.jay: Ignore invalid attribute target.
8467 2007-02-18 Marek Safar <marek.safar@gmail.com>
8469 * cs-tokenizer.cs: Ignore '\0' as white space character.
8471 2007-02-17 Miguel de Icaza <miguel@novell.com>
8473 * cs-parser.jay: Add support for lambda expressions to the mcs
8476 * lambda.cs: Only clone when we are probing, not on the final call
8477 (Compatible is the final call).
8479 * statement.cs (CloneContext): Introduce class to provide block
8480 remapping during clone.
8482 All statements Clone themselves now.
8484 (Clone): special handling for blocks, when we clone a block, we
8485 register the block inside this routine, as children of the block
8486 might trigger a lookup.
8488 * expression.cs: Add support for CloneContext in all expressions.
8490 2007-02-17 Marek Safar <marek.safar@gmail.com>
8492 A fix for bug #80493
8493 * statement.cs: Report ambiguous warning when interfaces are not related.
8495 2007-02-15 Marek Safar <marek.safar@gmail.com>
8497 C# 3.0 extension methods.
8499 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8500 cannot be used directly.
8502 * class.cs (Class.Emit): Emit extension attribute if any class method
8503 is extension method.
8504 (Method.Define): Add basic extension method validation conditions.
8505 (Method.Emit): Emit extension attribute for method.
8507 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8508 extension method exists. Currently we follow same approach as Microsoft
8509 does, emit even if a method or a class are private but this can change
8512 * cs-parser.jay: Add handling of `this' keyword in method parameters
8515 * decl.cs (DeclSpace.IsStaticClass): New property.
8516 (MemberCache.FindExtensionMethods): Looks for extension methods with
8517 defined name and extension type.
8519 * doc.cs: Updated after OverloadResolve changes.
8521 * driver.cs: Add new soft reference to System.Core.dll.
8523 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8524 (ExtensionMethodGroupExpr): Represents group of extension methods.
8526 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8527 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8528 to MethodGroupExpr and made non-static for easier customization.
8529 (Invocation.DoResolve): Add extension method lookup when no standard
8531 (MemberAccess.DoResolve): Try extension methods if no member exists.
8533 * modifiers.cs: Add METHOD_EXTENSION modifier.
8535 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8536 as well as candidate extension type.
8537 (ComputeNamespaces): When assembly constains extension methods registers
8539 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8540 extension method lookup.
8541 (Namespace.LookupExtensionMethod): Looks for extension method in this
8543 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8544 find a method which matches name and extensionType.
8546 * parameter.cs (Parameter): Add This modifer.
8547 (HasExtensionMethodModifier): New property.
8548 (Resolve): Add extension parameter check.
8549 (ModFlags): turned to property to exclude this modifier as it is not real
8551 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8553 * support.cs (ParameterData): Add ExtensionMethodType.
8554 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8556 * typemanager.cs: Add type and ctor extension attribute type.
8558 2007-02-15 Miguel de Icaza <miguel@novell.com>
8560 * report.cs (DisableErrors, EnableErrors): used to prevent error
8561 output when we are "trying" to compile various methods with
8564 * ecore.cs (Expression): Add Clone method that calls the virtual
8565 CloneTo method. The current CloneTo method in Expression throws
8566 an exception so we can track down all the places where this must
8567 be implemented (not using abstract, because that would be a lot of
8568 up-front-work before we can start testing the implementation
8571 Important: we only need Clone capabilities for expressions created
8572 by the parser, as the expressions we will be cloning are
8573 expressions in the pre-resolved state. This vastly simplifies
8576 (SimpleName): Add CloneTo that does nothing.
8577 (EmptyCast): Add CloneTo.
8579 * expression.cs (Binary): Implement CloneTo.
8580 (Invocation.IsApplicable): Store the current ec in
8581 EmitContext.TempEc and restore it on return. This is used so we
8582 do not have to sprinkle hundres of methods with an extra
8583 EmitContext, we know that the only user is the lambda expression
8584 ImplicitConversionExists code.
8586 (Argument): Add Cloning capabilities.
8587 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8588 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8589 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8590 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8591 IndexerAccess): Add Clone capability.
8593 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8595 (Argument): Add cloning capability.
8597 * assign.cs (Assign): Implement CloneTo.
8599 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8601 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8602 version by calling Convert with the EmitContext (that we are
8603 currently storing in ec, this is not great, but will do for now,
8604 to avoid passing EmitContext parameters to hundreds of functions
8605 that do not need them now).
8607 (SetExpression): Remove, it is not needed.
8609 (ContextualReturn): Implement CloneTo.
8611 * statement.cs (Statement): Implement cloning infrastructure,
8612 similar to expressions.
8614 (Block): Partial implementation of Clone for statements.
8616 (Return): Implement clone.
8618 * constant.cs (Constant.CloneTo): New method, does nothing.
8620 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8621 solution, until we decide how to exactly do this.
8623 2007-02-14 Marek Safar <marek.safar@gmail.com>
8625 A fix for bug #80493
8626 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8627 a property is override we need to use second accessor.
8629 2007-02-13 Marek Safar <marek.safar@gmail.com>
8631 A fix for bug #80418
8632 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8635 2007-02-13 Marek Safar <marek.safar@gmail.com>
8637 Another fix for bug #80749
8638 * pending.cs: Abstract class has priority over interfaces.
8640 2007-02-13 Marek Safar <marek.safar@gmail.com>
8642 Another fix for bug #80749
8643 * pending.cs: Abstract class has priority over interfaces.
8645 2007-02-13 Marek Safar <marek.safar@gmail.com>
8647 Another fix for bug #80749
8648 * pending.cs: Abstract class has priority over interfaces.
8650 2007-02-13 Marek Safar <marek.safar@gmail.com>
8652 Another fix for bug #80749
8653 * pending.cs: Abstract class has priority over interfaces.
8655 2007-02-13 Marek Safar <marek.safar@gmail.com>
8657 * class.cs Better error message.
8659 * driver.cs: Add shorter versions of -optimize option.
8661 2007-02-13 Martin Baulig <martin@ximian.com>
8663 * class.cs (Constructor.Emit): Check the return value of
8664 ec.ResolveTopBlock() and return on error.
8666 2007-02-13 Raja R Harinath <rharinath@novell.com>
8668 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8669 message to fix error message regression.
8671 2007-02-12 Marek Safar <marek.safar@gmail.com>
8673 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8675 2007-02-12 Marek Safar <marek.safar@gmail.com>
8677 A fix for bug #80749
8678 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8679 its parent container.
8681 * class.cs (DefineFieldInitializers): Each initializer can has different
8684 * const.cs: Updated.
8686 2007-02-11 Miguel de Icaza <miguel@novell.com>
8688 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8689 now all the heavy lifting to check that embedded statements or
8690 expressions have the right form is done in the ContextualReturn.
8692 (ContextualReturn): New class.
8694 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8695 method that can be invoked to report 201, so we do not replicate
8698 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8700 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8701 treating tabs as spaces.
8703 2007-02-09 Marek Safar <marek.safar@gmail.com>
8705 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8706 * assign.cs: Use full implicit conversion for right side check.
8708 2007-02-09 Marek Safar <marek.safar@gmail.com>
8710 * statement.cs (Switch): Switch over boolean type is not standardized.
8712 2007-02-08 Marek Safar <marek.safar@gmail.com>
8714 A fix for bug #80755
8715 * decl.cs (FindBaseEvent): Don't use method cache for events.
8717 2007-02-07 Marek Safar <marek.safar@gmail.com>
8719 * cs-parser.jay: Better syntax error handling.
8721 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8722 instead of underlying type value.
8724 2007-02-06 Marek Safar <marek.safar@gmail.com>
8726 * driver.cs: Check define identifier before is registered.
8728 * namespace.cs: Use existing error message.
8730 * report.cs: New warning.
8732 2007-02-06 Marek Safar <marek.safar@gmail.com>
8734 A fix for bug #80742
8735 * expression.cs: Delegate Invoke method can be called directly.
8737 2007-02-06 Marek Safar <marek.safar@gmail.com>
8739 A fix for bug #80676
8740 * class.cs (IsEntryPoint): The Main method can have params modifier.
8742 2007-02-04 Miguel de Icaza <miguel@novell.com>
8744 * parameter.cs (Parameter, Parameters): Add Clone method.
8746 * anonymous.cs (Compatible): Turn method into virtual method, so
8747 LambdaExpression can implement a different behavior.
8749 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8750 out the basic checking here, so it can be used by
8753 * lambda.cs: Introduce "Compatible" function that will do the
8756 2007-02-02 Marek Safar <marek.safar@gmail.com>
8758 * attribute.cs: Unified one error message.
8760 * class.cs (Class): Use type attributes and not properties to test static
8762 (IsEntryPoint): Don's pass local variable.
8764 * convert.cs: Removed duplicate check.
8766 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8768 * driver.cs: Don't crash when soft reference does not exist.
8770 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8771 (UsingEntry): Removed redundant allocation.
8773 * parameter.cs: Add fast path for type parameters.
8775 * support.cs: Don't allocate attribute when it's not used.
8777 2007-01-30 Miguel de Icaza <miguel@novell.com>
8780 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8781 this into a virtual method, so we can override it in LambdaExpression.
8783 * driver.cs: Improve diagnostics in case of failure.
8785 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8786 write a function that is slightly more complex and that parses:
8788 type identifier [, type identifier]* )
8790 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8793 (canEmpty ? i >= 0 : i > 0)
8795 2007-01-30 Raja R Harinath <rharinath@novell.com>
8797 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8798 exception on possibly valid code.
8800 2007-01-29 Raja R Harinath <rharinath@novell.com>
8802 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8804 (parse_opt_type_arguments): Remove. It's almost the same as
8806 (parse_namespace_or_typename): Use parse_less_than.
8808 2007-01-28 Miguel de Icaza <miguel@novell.com>
8810 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8811 this bug took a few hours to find, because the state saved and
8812 restored by PushPosition and PopPosition was ignoring the state of
8813 parse_generic_less_than.
8815 I can also now remove the handling of OP_LT and OP_GT, this solves
8818 * cs-tokenizer.cs: store the location for the ARROW token, we use
8821 (PushPosition, PopPosition): save/restore also `current_token',
8822 restore `parse_generic_less_than' (was missing).
8824 (parse_opt_type_arguments): use parse_type, not
8825 parse_namespace_or_typename to parse types.
8827 * lambda.cs: Empty new file, will eventually have the lambda
8828 expression implementation.
8830 * lambda.test: used to test the internal tokenizer.
8832 * report.cs (FeatureIsNotISO1): Rename from
8833 FeatureIsNotStandardized, because it was about the language level
8834 (1 vs 2) it was not about standarization.
8836 (FeatureRequiresLINQ): New.
8838 * support.cs (SeekableStreamReader): Only require that the reader
8839 is a TextReader, not a StreamReader, so we can plug StringReader.
8841 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8842 given position in the input stream the following tokens can be
8843 parsed as a type followed by an identifier.
8845 (is_punct): after a '(' if parse_type_and_parameter returns true,
8846 then return a special token OPEN_PARENS_LAMBDA which is used to
8847 avoid reduce/reduce errors in the grammar for the
8848 lambda_expression rules.
8850 (parse_type): implement a type parser inside the
8851 tokenizer, the parser only returns true or false depending on
8852 whether the input at a given position can be parsed as a type.
8854 (peek_token): new method used during type parsing.
8856 2007-01-28 Raja R Harinath <rharinath@novell.com>
8859 * anonymous.cs (ScopeInfo.InflateParameters): New.
8860 (AnonymousContainer.Resolve): Use it to redirect types of
8861 delegate parameters.
8863 2007-01-27 Raja R Harinath <rharinath@novell.com>
8866 * expression.cs (Error_InvalidArguments): Don't use two different
8867 messages for CS1503. Use ExtraInformation and
8868 SymbolRelatedToPreviousError instead.
8871 * decl.cs (DeclSpace.initialize_type_params): Don't access
8872 'type_params' of a partial class directly.
8874 2007-01-26 Miguel de Icaza <miguel@novell.com>
8876 * constant.cs: Removed a handful of out-of-range checks that were
8879 2007-01-25 Marek Safar <marek.safar@gmail.com>
8881 * expression.cs (CheckUselessComparison): Add additional check for char
8884 * namespace.cs: Fixed typo.
8886 2007-01-23 Miguel de Icaza <miguel@novell.com>
8888 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8889 gone, instead we inline the test, preventing the needless casts to
8890 longs, ulongs and doubles for the parameters, avoiding calls to
8891 methods that overchecked stuff, and instead inlined things
8894 2007-01-20 Marek Safar <marek.safar@gmail.com>
8896 * cs-parser.jay: Better parameter error handling.
8898 2007-01-17 Marek Safar <marek.safar@gmail.com>
8900 A fix for bug #80368, #80522
8901 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8902 whether array initializer contains constants only.
8903 (ArrayCreation.Emit): Use better formula to decide when
8904 are array initializers for static initialization.
8905 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8906 have to emit even constants otherwise they are pre-initialized.
8908 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8909 Raja R Harinath <rharinath@novell.com>
8911 Fix emit order of 'get' vs. 'set'.
8912 * support.cs (Accessors): New.
8913 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8914 Note the order in which accessors are declared in the source.
8915 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8916 Refactored from Property.Define and Indexer.Define.
8917 (PropertyBase.DefineAccessors): New helper that calls the above in
8918 appropriate order as noted by the parser.
8919 (Property.Define, Indexer.Define): Update to changes.
8920 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8922 2007-01-17 Raja R Harinath <rharinath@novell.com>
8924 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8925 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8926 there's an implicit conversion from the current type to the target
8927 type before converting the underlying constant.
8929 2007-01-16 Marek Safar <marek.safar@gmail.com>
8931 * const.cs (ResolveValue): Updated after constant conversion was made more
8934 * constant.cs (GetAttributableValue): constant to object conversion is
8935 used for attributes only.
8936 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8937 constant conversions.
8938 (LongConstant.ConvertImplicitly): Ditto.
8940 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8941 (ImplicitConversionStandard): Handle constant conversion as extra step.
8942 It solves the issue when constant conversion was called indirectly like
8943 inside array initializer and constant folding was skipped.
8945 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8948 * statement.cs(ImplicitConversionStandard): Updated after constant
8949 conversion was made more generic.
8951 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8953 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8954 Constraints, solves the problem where the compiler incorrectly
8955 reported that a type parameter was not constrained to a class (Bug
8958 2007-01-14 Marek Habersack <grendello@gmail.com>
8960 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8962 2007-01-14 Marek Safar <marek.safar@gmail.com>
8964 A fix for bug #80368
8965 * assign.cs (FieldInitializer): New class implements field
8966 initializer statement.
8968 * attribute.cs: Update after FieldMember rename.
8970 * class.cs (PropertyBasedMember): New common class for property based
8972 (InterfaceMemberBase): New base class for all members which can be used as
8973 an interface members.
8974 (MethodCore): Moved really common code to InterfaceMemberBase.
8975 (Method.Define): Equal and GetHasCode detection is relevant for methods
8977 (MethodData.Define): Don't assume that public event implements an
8978 interface automatically.
8979 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8981 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8982 (FieldMember): Merged with FieldBase.
8983 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8984 event extern modifier can be used.
8985 (EventField.EventFieldAccessor): Moved event field specific code here.
8986 (Event.AllowedModifiers): Even event can be extern.
8987 (Event.FindOutBaseMethod): New override specific to events.
8988 (Indexer.parameters): Reintroduce parameters because base class holds
8989 only properties common data.
8990 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8991 need do extra parameters check.
8993 * const.cs: Update after FieldMember rename.
8995 * decl.cs (MemberCache.FindBaseEvent): New method.
8997 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8998 to reflect that indexer is now derived from PropertyBased.
9000 * ecore.cs (GetMemberType): Made public.
9001 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
9004 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
9006 * typemanager.cs (CSharpSignature): Correctly print event accessors.
9007 (RegisterEvent): Removed.
9008 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
9009 (GetPrivateFieldOfEvent): Renamed to GetEventField.
9011 2007-01-11 Raja R Harinath <rharinath@novell.com>
9014 * statement.cs (CollectionForeach.TryType): Prefer generic
9015 GetEnumerator over non-generic variant. Fix code to follow comments.
9017 2007-01-09 Raja R Harinath <rharinath@novell.com>
9020 * support.cs (ReflectionParameter): Don't use an invalid index on
9021 the generic parameter data.
9023 2007-01-08 Miguel de Icaza <miguel@novell.com>
9025 * driver.cs: Just add a tiny bit of infrastructure.
9027 2007-01-02 Marek Safar <marek.safar@gmail.com>
9029 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
9030 where field type is struct from current assembly.
9032 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
9035 2007-01-02 Marek Safar <marek.safar@gmail.com>
9037 A fix for bug #80381
9038 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
9041 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
9043 (Namespace.LookupType): Always use core types from corlib when speficied.
9045 * report.cs: A new warning.
9047 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
9048 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
9049 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
9051 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
9052 (InitCoreTypes): Set expression type of object_type and value_type
9053 immediately after lookup.
9055 2007-01-01 Miguel de Icaza <miguel@novell.com>
9057 * cs-tokenizer.cs: Accept Pc class characters (Connector
9058 Punctuation) as valid identifiers. Fixes #78259
9060 * expression.cs (Invocation.DoResolve): Moved the check for the
9061 use of `this' for doing method calls to the Invocation resolution
9062 step, after overload resolution has taken place instead of doing
9063 the check at the low-level `This.DoResolve' level.
9065 The `This.DoResolve'(appens before overload resolution, so it has
9066 no way of knowing if the method that will be called will be
9067 instace or static, triggering an erroneous report for cs0188 (Bug
9070 We now do the check for instance method invocations after we know
9071 what method will be called.
9073 (This.CheckThisUsage): Move the actual use of this structure
9074 checking into its own method and expose it.
9076 * Everywhere that called Error_ValueCannotBeConverted: pass a new
9079 Exceptions: Null.ConvertImplicitly,
9080 Constant.ImplicitConversionRequired as there are too many call
9081 sites for passing the ec.
9083 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
9084 EmitContext, if the value is null, then we do not try to provide
9085 the extra information from the error (If a userdefined conversion
9086 exists, as UserDefinedConversion requires a non null-EmitContext).
9090 2006-12-30 Raja R Harinath <rharinath@novell.com>
9092 * flowanalysis.cs (MyBitVector): Document some invariants.
9093 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
9094 introduced below, and add a couple of others,
9096 2006-12-30 Marek Safar <marek.safar@gmail.com>
9098 * attribute.cs (GetMethodObsoleteAttribute): Uses new
9099 GetPropertyFromAccessor and GetEventFromAccessor.
9101 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
9102 overrides non-obsolete one.
9103 (Indexer.Define): Error message has been moved to the parser.
9105 * cs-parser.jay: Better syntax errors handling.
9107 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
9108 when an invocation has no arguments.
9110 * ecore.cs: Removed not used caching.
9112 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
9115 * report.cs: Add a new warning.
9117 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
9119 * typemanager.cs (enumeration_type): Removed.
9120 (CSharpSignature): Reuses IsSpecialMethod.
9121 (IsEqual): Hack for MS BCL.
9122 (GetPropertyFromAccessor): New method.
9123 (GetEventFromAccessor): New method.
9124 (IsSpecialMethod): Fixed to handle more cases.
9126 2006-12-30 Marek Safar <marek.safar@gmail.com>
9128 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
9129 Made white spaces array static.
9131 * ecore.cs (RemoveGenericArity): Optimized.
9133 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
9135 (MyBitVector.initialize_vector): Simplified.
9137 2006-12-22 Miguel de Icaza <miguel@novell.com>
9139 * ecore.cs: Am not entirely happy with this hack, but it seems to
9140 address the issue in 80257 (a small test case for
9143 I set the MethodGroupExpr.Type to an internal compiler type
9144 (itself in this case) to force the resolution to take place. Why
9145 it does not take place with a null is beyond me.
9147 2006-12-20 Marek Safar <marek.safar@gmail.com>
9149 A fix for bug #80288
9150 * expression.cs (ResolveOperator): Consider user defined conversion for
9151 logical and operator too.
9152 (EmitBranchable): Optimization for logical and when full constant folding
9153 could not be applied but one operand is constant.
9155 2006-12-19 Marek Safar <marek.safar@gmail.com>
9157 * class.cs (GetClassBases): Write 5 times every day, will never use
9158 FullName for error reporting.
9160 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
9162 2006-12-19 Martin Baulig <martin@ximian.com>
9164 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
9165 the symbol file info here.
9167 2006-12-18 Marek Safar <marek.safar@gmail.com>
9169 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
9170 of `elseif' is taking then following sections are not taking.
9171 Fixes an issue reported on mono mailing list.
9173 2006-12-18 Marek Safar <marek.safar@gmail.com>
9175 A fix for bug #80300
9176 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
9177 a caller is not taking.
9179 2006-12-18 Raja R Harinath <rharinath@novell.com>
9181 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9182 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9183 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9184 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9185 * class.cs: Update to changes.
9187 2006-12-17 Marek Safar <marek.safar@gmail.com>
9189 A fix for bug #79934
9190 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9193 * class.cs (ResolveMembers): Register an iterator in current container and
9196 2006-12-16 Raja R Harinath <rharinath@novell.com>
9199 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9200 satisfy a params annotated parameter.
9202 2006-12-16 Marek Safar <marek.safar@gmail.com>
9204 A fix for bug #77014
9205 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9206 paramters correctly and not rely on hacks in Parameters class.
9207 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9209 (Invocation.VerifyArgumentsCompat): Ditto.
9210 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9213 * parameter.cs (HasParams): Don't assume that params is the last one.
9215 * support.cs (ReflectionParameters.ctor): Look for params attribute
9217 (ReflectionParameters.ParameterType): Removed hack when we returned last
9218 parameter for out of range parameters.
9219 (ParameterName, ParameterModifier): Ditto.
9221 2006-12-14 Marek Safar <marek.safar@gmail.com>
9223 A fix for bug #79987
9224 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9225 when assembly is not CLS compliant but type is. I have no idea why is this
9228 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9230 2006-12-13 Miguel de Icaza <miguel@novell.com>
9232 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9233 in struct constructors, they are basically no-ops.
9235 2006-12-12 Marek Safar <marek.safar@gmail.com>
9237 * cs-tokenizer.cs (Position): Save preprocessor status too.
9239 2006-12-12 Marek Safar <marek.safar@gmail.com>
9241 A fix for bug #77794
9242 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9244 2006-12-12 Marek Safar <marek.safar@gmail.com>
9246 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9248 (pp_expr): Report error for an invalid expression.
9249 (handle_preprocessing_directive): Simplified; add more error checking.
9251 2006-12-11 Marek Safar <marek.safar@gmail.com>
9253 A fix for bug #74939
9254 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9255 directives handling.
9257 2006-12-10 Marek Safar <marek.safar@gmail.com>
9259 A fix for bugs #80093, and #75984
9260 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9261 logic, it seems to me as it worked before "by coincidence".
9262 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9263 (cleanup): Enabled endif check.
9265 2006-12-09 Marek Safar <marek.safar@gmail.com>
9267 A fix for bug #80162
9268 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9269 enumerators are never ambiguous.
9271 2006-12-08 Raja R Harinath <rharinath@novell.com>
9274 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9276 2006-12-06 Marek Safar <marek.safar@gmail.com>
9278 A fix for bug #80144
9279 * class.cs (EventProperty.Define): Explicit implementation means
9280 that an even is used.
9282 2006-12-06 Marek Safar <marek.safar@gmail.com>
9284 Fixes the operators implementation (part II)
9286 * cfold.cs (DoConstantNumericPromotions): Renamed to
9287 DoBinaryNumericPromotions and simplified.
9288 (BinaryFold): Couple of conversion fixes; simplified.
9290 * constant.cs, ecore.cs, literal.cs
9291 (ToType): Renamed to ConvertImplicitly.
9292 (Reduce): Renamed to ConvertExplicitly.
9294 * class.cs, convert.cs: Updated.
9296 * expression.cs: TryReduce doesn't throw an exception.
9298 2006-12-01 Marek Safar <marek.safar@gmail.com>
9300 A fix for bug #80108
9301 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9304 2006-11-30 Marek Safar <marek.safar@gmail.com>
9306 Fixes unary operators implementation (part I)
9309 * cfold.cs (Error_CompileTimeOverflow): Made internal
9311 * const.cs (IConstant): Changed to use reference to constant and
9312 not constant itself.
9313 Updated IConstant implementations.
9315 * constant.cs (CreateConstant): New factory method.
9316 Updated IConstant implementation.
9318 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9320 * ecore.cs: Updated to use CreateConstantReference.
9322 * enum.cs: Reflects IConstant changes.
9324 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9326 * literal.cs (NullConstant): Change to be independently usable.
9328 2006-11-29 Martin Baulig <martin@ximian.com>
9330 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9331 we need to emit the scope initializer before calling the base .ctor.
9333 * anonymous.cs: Merged back from the new anonymous methods branch.
9334 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9336 * expression.cs (ParameterReference.DoResolveBase): Create a
9337 "normal" ScopeInfo when capturing parameters rather than using the
9338 root scope; this makes things work with anonymous methods having
9342 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9344 2006-11-22 Marek Safar <marek.safar@gmail.com>
9346 A fix for bug #79987
9347 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9348 check to a base class.
9349 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9350 only when assembly has missing attribute.
9351 * report.cs: Update.
9353 2006-11-21 Marek Safar <marek.safar@gmail.com>
9355 * cs-tokenizer.cs: Merged with gmcs version.
9357 2006-11-20 Marek Safar <marek.safar@gmail.com>
9360 * cs-parser.jay: Better error message when partial keyword is misplaced.
9362 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9364 A fix for bug #79810
9365 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9366 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9367 a RuntimeWrappedException by default.
9369 2006-11-18 Marek Safar <marek.safar@gmail.com>
9371 A fix for bug #79843
9372 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9374 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9376 2006-11-18 Marek Safar <marek.safar@gmail.com>
9378 * driver.cs, namespace.cs: Uses faster IndexOf version.
9380 2006-11-17 Marek Safar <marek.safar@gmail.com>
9382 A fix for bug #79941
9383 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9385 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9386 even if internal name is different.
9387 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9388 (UserDefinedConversion): Simplified as the operators cannot be internal.
9389 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9391 (MethodLookup): Replaced EmitContext with parentType.
9392 * expression.cs: Updated.
9394 2006-11-09 Raja R Harinath <rharinath@novell.com>
9396 * driver.cs (BadAssembly): Handle all the ugliness of
9397 DefineDynamicAssembly.
9399 2006-11-08 Raja R Harinath <rharinath@novell.com>
9401 Address parts of #58244 -- most of what's left is in the runtime
9402 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9403 CS1509 error checks, and handle them for all assembly loads, not
9404 just the first invocation.
9405 (LoadModule): Likewise. Move handling of 'adder_method' ...
9406 * codegen.cs (AssemblyClass.AddModule): ... here.
9408 2006-11-02 Marek Safar <marek.safar@gmail.com>
9410 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9411 IEnumerable<T> is ambiguous.
9413 2006-10-31 Marek Safar <marek.safar@gmail.com>
9415 A fix for bug #67689
9416 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9417 GetEnumerator is ambiguous.
9419 * report.cs: Add new warning.
9421 2006-10-29 Marek Safar <marek.safar@gmail.com>
9423 A fix for bug #78602
9424 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9425 to protected member can be nested type.
9427 2006-10-28 Marek Safar <marek.safar@gmail.com>
9429 A fix for bug #78965
9430 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9431 to protected member must derive from current type.
9433 2006-10-27 Marek Safar <marek.safar@gmail.com>
9435 assign.cs: Reuses error method.
9437 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9438 instead of type for constants.
9439 (Expression.Error_ValueAssignment): Common error method.
9441 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9444 2006-10-27 Marek Safar <marek.safar@gmail.com>
9446 A fix for bug #79081
9447 * expression.cs (MemberAccess.DoResolve): Check nested type
9450 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9452 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9454 2006-10-26 Marek Safar <marek.safar@gmail.com>
9456 A fix for bug #76591
9457 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9459 2006-10-26 Marek Safar <marek.safar@gmail.com>
9461 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9462 type forwarder of the same type multiple times.
9464 2006-10-26 Raja R Harinath <rharinath@novell.com>
9467 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9468 instance as an rvalue, even when we later resolve as an lvalue.
9470 2006-10-25 Martin Baulig <martin@ximian.com>
9472 * anonymous.cs: Fix #79673.
9474 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9476 A fix for bug #79666
9477 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9478 ignored when is optimized (= default value) as its value is already set.
9480 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9482 A fix for bug #79724
9483 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9484 TypeContainer for type lookup.
9486 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9488 A fix for bug #79231
9489 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9490 * expression.cs (OverloadResolve): Always convert type name for
9492 (ResolveNamespaceOrType): Don't confuse a nested type with any
9495 2006-10-18 Martin Baulig <martin@ximian.com>
9497 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9499 2006-10-17 Miguel de Icaza <miguel@novell.com>
9501 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9502 an int32, but requesting an int64 from the conversion
9504 2006-10-12 Martin Baulig <martin@ximian.com>
9507 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9509 2006-10-12 Martin Baulig <martin@ximian.com>
9512 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9514 2006-10-11 Miguel de Icaza <miguel@novell.com>
9516 * convert.cs: Remove broken code: I was doing the "Existance"
9517 tests for Implicit conversions.
9519 2006-10-10 Miguel de Icaza <miguel@novell.com>
9521 * convert.cs: Added one missing case in
9522 ImplicitStandardConversionExists uint64 to intptr.
9526 * typemanager.cs (uintptr_type): another core known type.
9528 * ecore.cs (OperatorCast): routine used to do cast operations that
9529 depend on op_Explicit. We could change some of the Decimal
9530 conversions to use this.
9532 This one has a probe mechanism that checks both types for an op_
9533 which it coudl be used to eliminate two classes: CastToDecimal
9534 and CastFromDecimal.
9536 * convert.cs: Implement the conversions documented in #59800
9538 2006-10-10 Martin Baulig <martin@ximian.com>
9540 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9541 before RootScope.ResolveMembers().
9543 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9544 `CurrentType' if appropriate.
9546 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9548 A fix for bug #78568
9549 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9550 when contains binary operators.
9551 * cs-parser.jay: Updated.
9553 2006-10-09 Martin Baulig <martin@ximian.com>
9556 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9557 moved that into Define() and also do the other type parameter
9558 checks there. Fixes #79094. Added gtest-292.cs.
9561 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9562 since that doesn't include type parameters; don't use `Ldelema'
9563 for type parameters. Fixes #78980. Added gtest-293.cs.
9565 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9568 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9569 conversion is allowed.
9571 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9573 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9574 error reporting when no error occurs.
9576 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9578 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9581 2006-10-06 Raja R Harinath <rharinath@novell.com>
9584 * class.cs (DefineTypeBuilder): Check circular dependencies before
9585 setting the parent of the TypeBuilder.
9586 (CheckRecursiveDefinition): Don't use 'BaseType', since
9587 it may not be valid until after DefineTypeBuilder. Use
9588 'base_type' instead.
9590 2006-10-04 Martin Baulig <martin@ximian.com>
9592 Merged the Anonymous Methods patch.
9594 * anonymous.cs, iterators.cs: The new anonymous methods code.
9596 * statement.cs (Variable): New public abstract class.
9597 (LocalInfo.Variable): New public property.
9598 (LocalInfo.ResolveVariable): New public method.
9599 (Block.Flags): Add `IsIterator'.
9600 (Block.AddVariable): Improved the CS0136 check.
9601 (Block.AnonymousChildren): New public property.
9602 (Block.AddAnonymousChild): New public method.
9603 (ToplevelBlock): Update to use the new anonymous method framework.
9604 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9605 `ToplevelBlock'; this is required to correctly implement the
9607 (Fixed, Using): Use `TemporaryVariable' instead of directly
9608 creating the `LocalBuilder'.
9610 * parameter.cs (Parameter.ResolveVariable): New public method.
9611 (Parameters.ResolveVariable): Likewise.
9613 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9615 * class.cs (TypeContainer): Replaced the `iterators' list and
9616 corresponding methods with a list of `CompilerGeneratedClass'es.
9617 (TypeContainer.ResolveMembers): New public method.
9618 (Method): `IIteratorContainer' has been replaced by
9621 * expression.cs (VariableReference): New public abstract base
9622 class for `LocalVariableReference', `ParameterReference' and
9625 * codegen.cs (EmitContext): Removed `capture_context',
9626 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9627 (EmitContext.EmitThis): Removed.
9629 * cs-parser.jay: Replace `iterator_container' with
9632 2006-10-04 Martin Baulig <martin@ximian.com>
9634 * generic.cs (GenericMethod): Don't make this abstract.
9635 (Constraints.Clone): Added dummy implementation.
9637 2006-10-04 Raja R Harinath <harinath@gmail.com>
9640 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9641 'declspaces'. Avoid allocating arrays willy-nilly.
9644 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9645 cases out of the switch.
9647 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9649 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9650 message when non-generic type is used with the type arguments.
9651 * expression.cs: Updated.
9653 2006-09-28 Raja R Harinath <rharinath@novell.com>
9656 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9657 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9658 Change semantics slightly. Don't insist on having only one
9659 temporary EmptyExpression -- just throttle the creation of new ones.
9662 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9663 non-interfaces too. If no methods are found, don't try to create
9666 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9668 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9671 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9672 us produce better error message.
9674 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9676 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9677 of the `|' operator.
9679 * report.cs: A new warning added.
9681 2006-09-27 Martin Baulig <martin@ximian.com>
9683 * generic.cs (GenericMethod): Don't make this abstract.
9685 2006-09-27 Martin Baulig <martin@ximian.com>
9688 (InternalErrorException): Added overloaded ctor taking a params array.
9690 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9692 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9693 Fixed the cases when same error was reported twice.
9695 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9696 now report symbol information.
9698 2006-09-25 Martin Baulig <martin@ximian.com>
9700 * class.cs: Completely unified with the gmcs version.
9702 2006-09-25 Martin Baulig <martin@ximian.com>
9704 * typemanager.cs (TypeManager.IsNullableType): New public function.
9705 (TypeManager.IsNullableTypeOf): Likewise.
9706 (TypeManager.IsNullableValueType): Likewise.
9708 * class.cs (MethodCore): Added the `GenericMethod' argument from
9709 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9711 2006-09-24 Raja R Harinath <harinath@gmail.com>
9713 * convert.cs: Unify with gmcs version.
9715 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9717 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9718 verify them as well.
9720 * report.cs: New warning.
9722 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9724 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9725 for anonymous block with out argument.
9727 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9729 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9730 not used private events only.
9732 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9734 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9736 * const.cs (Const.Define): Check for constant type.
9737 (Const.IsConstantTypeValid): Looks for valid constant types.
9739 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9741 * ecore.cs (EmptyConstantCast): New common class for all constant based
9744 * expression.cs (Is.DoResolve): Handle null constant especially.
9745 (New.DoResolve): Check for new void().
9746 (MemberAccess.DoResolve): Cope with all kind of nulls.
9748 * literal.cs (NullConstant): Uses EmptyConstantCast.
9749 (NullDefault): Based on EmptyConstantCast.
9750 (NullLiteral): Uses EmptyConstantCast.
9752 * statement.cs (Block.ResolveMeta): Check for constant type.
9754 2006-09-22 Martin Baulig <martin@ximian.com>
9756 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9758 2006-09-22 Raja R Harinath <rharinath@novell.com>
9760 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9764 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9765 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9768 2006-09-22 Martin Baulig <martin@ximian.com>
9770 * ecore.cs: Merged with the gmcs version.
9772 * generic.cs (ConstructedType): New dummy class.
9773 (TypeArguments): Don't make this abstract.
9776 (TypeManager.IsGenericTypeDefinition): New method.
9777 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9779 2006-09-22 Raja R Harinath <rharinath@novell.com>
9781 * expression.cs (ComposedCast): Check for arrays of TypedReference
9782 before creating the type, not after.
9784 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9786 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9787 after ToType change.
9789 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9790 when constant must be implicitly convertible.
9792 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9794 * ecore.cs (NullCast): Derives from NullConstant.
9796 * expression.cs (Is.DoResolve): Removed useless variables.
9797 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9798 (New.Constantify): Add enum support.
9799 (MemberAccess.DoResolve): Add warning when accessing null constant or
9802 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9805 * literal.cs (NullConstant): New abstract class with common
9806 functionality for all null specializations.
9807 (NullDefault): Represents default(X) when result can be
9809 (NullLiteral): Updated.
9811 * report.cs: Add new warning.
9813 2006-09-21 Martin Baulig <martin@ximian.com>
9815 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9817 2006-09-21 Martin Baulig <martin@ximian.com>
9819 * generic.cs (GenericConstraints): New dummy class.
9820 (Constraints): Likewise.
9821 (TypeParameter): Likewise.
9822 (TypeParameterName): Likewise.
9823 (GenericMethod): Likewise.
9825 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9827 * decl.cs: Merged with the gmcs version.
9829 2006-09-21 Raja R Harinath <rharinath@novell.com>
9831 * generic.cs (TypeParameter): Implement IMemberContainer.
9832 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9834 * rootcontext.cs: Unify with gmcs version.
9836 * report.cs: Unify with gmcs version.
9837 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9838 from gmcs/generics.cs.
9839 * generics.cs (TypeParameter): New dummy class.
9841 * support.cs: Unify with gmcs version.
9843 2006-09-20 Raja R Harinath <rharinath@novell.com>
9845 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9846 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9848 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9849 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9850 * mcs.exe.sources: Add generic.cs.
9852 * codegen.cs: Unify with gmcs version.
9854 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9855 (EmitContext): Add GenericDeclContainer implementation.
9856 * decl.cs (MemberCore, DeclSpace): Likewise.
9857 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9859 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9860 MCS TypeManager has a corresponding dummy method.
9862 2006-09-19 Martin Baulig <martin@ximian.com>
9864 * expression.cs: Completely merged with the gmcs version.
9866 2006-09-19 Martin Baulig <martin@ximian.com>
9868 * expression.cs (Invocation): Merged with the gmcs version.
9869 (ArrayAccess.GetStoreOpcode): Likewise.
9871 2006-09-19 Martin Baulig <martin@ximian.com>
9874 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9875 (TypeManager.IsGenericMethodDefinition): Likewise.
9877 2006-09-19 Martin Baulig <martin@ximian.com>
9880 (TypeManager.IsEqual): Moved the gmcs implementation here.
9881 (TypeManager.DropGenericTypeArguments): Likewise.
9882 (TypeManager.DropGenericMethodArguments): Likewise.
9883 (TypeManager.GetTypeArguments): Moved here from gmcs.
9884 (TypeManager.HasGenericArguments): Likewise.
9886 2006-09-19 Martin Baulig <martin@ximian.com>
9888 * expression.cs (Binary): Merged with the gmcs version.
9890 2006-09-19 Martin Baulig <martin@ximian.com>
9892 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9894 2006-09-19 Martin Baulig <martin@ximian.com>
9896 * typemanager.cs: Merged with the gmcs version.
9898 2006-09-16 Raja R Harinath <rharinath@novell.com>
9900 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9901 * driver.cs: Likewise.
9903 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9906 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9907 only if parent type is class.
9908 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9911 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9914 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9916 * typemanager.cs(CSharpName): Converts NullType to null.
9918 2006-09-15 Martin Baulig <martin@ximian.com>
9921 (TypeManager.GetMethodName): Added mcs implementation.
9922 (TypeManager.IsEqual): Likewise.
9925 (SimpleName.RemoveGenericArity): Added dummy implementation.
9927 * pending.cs: Merged with the gmcs version.
9929 2006-09-15 Martin Baulig <martin@ximian.com>
9931 * statement.cs: Merge with the gmcs version.
9933 2006-09-15 Martin Baulig <martin@ximian.com>
9935 * statement.cs (Switch): Merge with the gmcs implementation
9936 (without nullables), which is newer.
9938 2006-09-15 Martin Baulig <martin@ximian.com>
9940 * statement.cs (Block.Variables): Make this public.
9941 (ToplevelBlock.Parameters): Make this a property.
9942 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9944 2006-09-15 Martin Baulig <martin@ximian.com>
9946 * namespace.cs: Merge with the gmcs version.
9948 2006-09-15 Martin Baulig <martin@ximian.com>
9950 * decl.cs (MemberName): Minor code cleanups.
9952 2006-09-15 Martin Baulig <martin@ximian.com>
9954 * parameter.cs: Merge with the gmcs version.
9956 2006-09-15 Martin Baulig <martin@ximian.com>
9958 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9959 and an error in mcs.
9961 2006-09-15 Martin Baulig <martin@ximian.com>
9963 * flowanalysis.cs: Merged from GMCS; added the generics code into
9964 a `GMCS_SOURCE' conditional so we can share this file.
9966 2006-09-08 Martin Baulig <martin@ximian.com>
9968 * typemanager.cs (TypeManager.interlocked_type): New public field.
9969 (TypeManager.int_interlocked_compare-exchange): New public field.
9970 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9971 enumerator types here and call InitGenericCoreTypes().
9972 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9973 after calling InitEnumUnderlyingTypes().
9976 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9977 `classes_second_stage'.
9979 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9981 * assign.cs, ecore.cs, expression.cs: Share error message text.
9982 * class.cs (FieldMember.Define): Check for varible of static type.
9983 * driver.cs (LoadAssembly): Uses error output for errors.
9984 * statement.cs: Updated.
9986 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9988 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9991 2006-09-07 Martin Baulig <martin@ximian.com>
9994 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9996 2006-08-29 Miguel de Icaza <miguel@novell.com>
9998 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
10000 2006-08-17 Miguel de Icaza <miguel@novell.com>
10002 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
10003 #52019 and #79064, the use of the \uXXXX sequence in source code
10004 to represent unicode characters.
10006 2006-08-15 Marek Safar <marek.safar@seznam.cz>
10008 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
10010 * class.cs, ecore.cs, statement.cs: Merged to one error message.
10012 2006-08-13 Miguel de Icaza <miguel@novell.com>
10014 * assign.cs: Catch attempts to assign to a method groups in += and
10017 2006-08-13 Marek Safar <marek.safar@seznam.cz>
10020 * cs-parser.jay: Don't destroy current array type by typeof of array's.
10022 2006-08-12 Marek Safar <marek.safar@seznam.cz>
10024 * class.cs (Method.Define): Issue a warning when generic method looks like
10026 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
10029 2006-08-09 Marek Safar <marek.safar@seznam.cz>
10031 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
10033 * decl.cs (MemberCache.FindMembers): When container is interface we need to
10034 search all base interfaces as a member can be ambiguous.
10035 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
10036 Constructor member type filter.
10037 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
10038 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
10039 reporting for returned memberinfos.
10040 * report.cs: Updated.
10041 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
10042 version to work on all runtimes.
10043 (TypeManager.RealMemberLookup): Removed members filtering.
10045 2006-08-08 Raja R Harinath <rharinath@novell.com>
10047 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
10048 (PropertyExpr.EmitAssign): Likewise.
10049 * expression.cs (Indirection.EmitAssign): Likewise.
10050 (LocalVariableReference.EmitAssign): Likewise.
10051 (ParameterReference.EmitAssign): Likewise.
10052 (Invocation.EmitArguments): Likewise.
10053 (ArrayAccess.EmitAssign): Likewise.
10054 (IndexerAccess.EmitAssign): Likewise.
10055 (This.EmitAssign): Likewise.
10056 (ConditionalLogicalOperator.Emit): Likewise.
10059 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
10060 instead of ArrayList. If the hashtable has a LocalBuilder, don't
10061 leave it in after returning it.
10062 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
10064 2006-08-06 Marek Safar <marek.safar@seznam.cz>
10066 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
10069 2006-08-03 Raja R Harinath <rharinath@novell.com>
10071 Fix cs0146-3.cs and cs0146-4.cs.
10072 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
10073 enclosing types don't depend on the current type.
10075 2006-08-02 Raja R Harinath <rharinath@novell.com>
10078 * class.cs (TypeContainer.DoDefineMembers): Use
10079 FindBaseMemberWithSameName on Parent, since we're interested in
10080 whether we hide inherited members or not.
10081 (FindBaseMemberWithSameName): Make slightly more robust.
10083 Fix the non-generic testcase from #77396
10084 * decl.cs (DeclSpace.DeclContainer): Remove override.
10086 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
10087 declspaces for doppelgangers too.
10088 (UsingEntry): Implement IResolveContext.
10089 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
10090 'this' as the resolve context.
10091 (LocalAliasEntry): Likewise.
10093 Implement parts of #77403
10094 * roottypes.cs (RootDeclSpace): New. Used to represent the
10095 toplevel declaration space. Each namespace declaration introduces
10096 a "partial" root declaretion space.
10097 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
10098 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
10099 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
10100 from 'current_namespace.SlaveDeclSpace'.
10101 (namespace_declaration): Likewise.
10102 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
10103 check. It can't happen now.
10104 * decl.cs (DeclSpace.LookupType): Likewise.
10105 * driver.cs (MainDriver): Sanity check.
10107 2006-08-01 Raja R Harinath <rharinath@novell.com>
10109 * decl.cs (DeclSpace.FindNestedType): Remove.
10110 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
10111 LookupTypeContainer to get the container of the nested type.
10112 * class.cs (TypeContainer.FindNestedType): Make non-override.
10114 2006-07-31 Raja R Harinath <rharinath@novell.com>
10116 * decl.cs (DeclSpace.PartialContainer): Move field from ...
10117 * class.cs (TypeContainer.PartialContainer): ... here.
10118 (TypeContainer.AddBasesForPart): New helper.
10119 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
10121 * cs-parser.jay (current_class): Convert to DeclSpace.
10122 (struct_declaration, interface_declaration, class_declaration):
10123 Use AddBasesForPart instead of .Bases directly.
10124 * const.cs, iterators.cs: Update to changes.
10126 2006-07-28 Raja R Harinath <rharinath@novell.com>
10128 * class.cs (TypeContainer.AddMemberType): Rename from
10129 AddToTypeContainer.
10130 (TypeContainer.AddMember): Rename from AddToMemberContainer.
10131 (AddTypeContainer): New. Combine AddClassOrStruct and
10133 (AddPartial): Update. Add 'is_partial' argument.
10134 * roottypes.cs: Update to changes.
10135 * cs-parser.jay (push_current_class): New helper for handling
10136 current_container and current_class.
10137 (struct_declaration, interface_declaration, class_declaration):
10140 2006-07-26 Raja R Harinath <rharinath@novell.com>
10142 * roottypes.cs: Rename from tree.cs.
10144 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
10145 * tree.cs (Tree, ITreeDump): Remove types.
10146 * rootcontext.cs (tree, Tree): Remove fields.
10147 (root, ToplevelTypes): New.
10148 * *.cs: Update to rename.
10150 * tree.cs (Tree.RecordDecl): Remove.
10151 (RootTypes.AddToTypeContainer): Record the toplevel type in its
10153 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
10155 2006-07-23 Raja R Harinath <harinath@gmail.com>
10157 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
10158 DoFlowAnalysis and OmitStructFlowAnalysis here.
10159 (ec.With): Rename from WithUnsafe and generalize.
10160 (ec.WithCheckState): Remove. All users can be handled by 'With'.
10161 (ec.WithFlowAnalyis): New.
10162 * ecore.cs, expression.cs, statement.cs: Update.
10164 2006-07-22 Raja R Harinath <harinath@gmail.com>
10166 * statement.cs (Block.ResolveMeta): Simplify slightly.
10168 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
10169 multiple boolean fields. Convert InUnsafe, constant_check_state,
10170 check_state to flags.
10171 (CheckState, ConstantCheckState): Update.
10172 (InUnsafe): New read-only property.
10173 (FlagsHandle): Rename from CheckStateHandle and convert to handle
10175 (WithUnsafe): New helper similar to WithCheckState.
10176 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
10177 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
10179 2006-07-21 Raja R Harinath <rharinath@novell.com>
10181 Make comparisons use the same IL irrespective of whether they're
10182 in a 'checked' or 'unchecked' context: one of the issues in #78899
10183 * codegen.cs (EmitContext.CheckState): Make read-only property.
10184 (EmitContext.ConstantCheckState): Likewise.
10185 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10186 helper that implement a save/restore stack for CheckState
10187 values. This is the only way to change check-state.
10188 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10189 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10190 (CheckedExpr.EmitBranchable): New forwarding method.
10191 (UnCheckedExpr): Likewise.
10192 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10193 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10194 (Checked.Resolve, checked.DoEmit): Likewise.
10196 2006-07-20 Miguel de Icaza <miguel@novell.com>
10198 * anonymous.cs: Cache the resolved anonymous delegate, and return
10199 this so that the ResolveTopBlock is only triggered once, not
10202 Currently we trigger ResolvetopBlock twice due to a first pass of
10203 argument check compatibility, and a second pass that does the
10206 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10208 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10210 * rootcontext.cs (Reset): Add helper_classes.
10212 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10215 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10218 2006-07-13 Miguel de Icaza <miguel@novell.com>
10220 * statement.cs (Lock): Handle expressions of type
10221 TypeManager.null_type specially. Fixes #78770
10223 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10225 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10228 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10230 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10231 for accessors as well.
10232 * ecore.cs (EventExpr): Add AccessorTable.
10234 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10237 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10238 for CS0122 where appropriate.
10239 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10241 (Filter): Assembly can be null in the case of top level attributes.
10243 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10247 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10248 is done at global level.
10250 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10252 A fix for #77002, Implemented TypeForwarder support.
10254 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10255 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10256 * typemanager.cs (): Add type_forwarder_attr_type.
10258 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10260 * report.cs: Add CS0469 warning.
10262 2006-06-21 Martin Baulig <martin@ximian.com>
10264 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10265 the `try'-block, so we also report CS0016 etc. there.
10267 2006-06-21 Martin Baulig <martin@ximian.com>
10270 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10272 2006-06-21 Martin Baulig <martin@ximian.com>
10274 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10275 also report CS1686 for parameters.
10277 2006-06-21 Martin Baulig <martin@ximian.com>
10279 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10280 instead of an error if the value is not implicitly convertible to
10281 the switch types; fixes #77964.
10283 2006-06-21 Raja R Harinath <rharinath@novell.com>
10286 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10287 FieldBuilder is null.
10290 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10291 'left' and 'right' before error-checking.
10293 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10295 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10297 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10298 (FieldExpr.DoResolve): likewise.
10299 (PropertyExpr.InstanceResolve): likewise.
10300 (EventExpr.InstanceResolve): likewise.
10302 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10304 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10305 attribute applicable tests for attribute argument.
10307 2006-06-02 Raja R Harinath <rharinath@novell.com>
10310 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10311 (Binary.OverloadResolve_PredefinedIntegral): New.
10312 (Binary.OverloadResolve_PredefinedFloating): New.
10313 (Binary.OverloadResolve_PredefinedString): New.
10314 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10315 Follow the standard more closely, and treat numeric promotions in
10316 terms of overload resolution.
10317 (Binary.CheckShiftArguments): Simplify.
10319 2006-06-01 Raja R Harinath <rharinath@novell.com>
10321 * flowanalysis.cs (MyBitVector): Simplify representation.
10322 (MyBitVector.Clone): Avoid allocating BitArray.
10323 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10324 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10325 (*): Update. Change all references to MyBitVector.And and
10326 MyBitVector.Or to &= and |=.
10328 2006-05-29 Raja R Harinath <rharinath@novell.com>
10330 Fix cs0231-[34].cs.
10331 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10332 to param arguments too.
10334 2006-05-26 Miguel de Icaza <miguel@novell.com>
10336 * cs-parser.jay: Catch another parsing form for arglist being
10337 followed by other arguments. Fixes #78313.
10339 2006-05-24 Raja R Harinath <rharinath@novell.com>
10341 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10342 checking of out parameters to ...
10343 (FlowBranchingToplevel.Merge): ... here.
10344 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10345 set, propagate the origin upward, and only complain if there was
10347 (FlowBranchingException.AddContinueOrigin): Likewise.
10348 (FlowBranchingException.AddReturnOrigin): Likewise.
10349 (FlowBranchingException.AddGotoOrigin): Likewise.
10351 2006-05-23 Raja R Harinath <rharinath@novell.com>
10353 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10354 unreachable, skip it.
10355 (FlowBranchingException.Merge): Always propagate jumps, even if
10356 the finally block renders subsequent code unreachable.
10358 2006-05-18 Raja R Harinath <rharinath@novell.com>
10361 * statement.cs (Goto.Resolve): Move responsibility for resolving
10362 'goto' to FlowBranching.AddGotoOrigin.
10363 (Goto.SetResolvedTarget): New. Callback to set the
10364 LabeledStatement that's the target of the goto.
10365 (Goto.DoEmit): Use Leave instead of Br when crossing an
10366 unwind-protect boundary.
10367 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10368 LookupLabel and adjust to new semantics.
10369 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10370 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10371 Goto.SetResolvedTarget to update target.
10372 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10373 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10374 AddBreakOrigin & co. Delay propagation until ...
10375 (FlowBranchingException.Merge): ... this.
10377 * statement.cs (Block.Resolve): Always depend on flow-branching to
10378 determine unreachability. Kill workaround that originally emitted
10379 only one statement after an "unreachable" label (see infloop in
10382 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10383 This is still "wrong", but anything better would probably need a
10384 multi-pass algorithm.
10385 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10386 usage vector. Force current usage vector to be reachable, to
10387 optimistically signify backward jumps.
10388 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10390 (FlowBranchingLabeled.Merge): New. If no backward jump was
10391 detected, return the original salted-away usage vector instead,
10392 updated with appropriate changes. Print unreachable warning if
10394 * statement.cs (Block.Resolve): Don't print unreachable warning on
10395 a labeled statement.
10397 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10399 * driver.cs: Pass filename without path to AssemblyBuilder's
10400 AddResourceFile. Fixes bug #78407.
10402 2006-05-17 Raja R Harinath <rharinath@novell.com>
10404 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10405 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10406 (FlowBranching.MergeChild): Overwrite
10407 reachability information from Labeled branchings too.
10409 2006-05-16 Raja R Harinath <rharinath@novell.com>
10411 * statement.cs (Goto.Resolve): Merge jump origins here ...
10412 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10414 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10415 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10416 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10417 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10419 * statement.cs (Goto.Resolve): ... not here.
10420 (Goto.Emit): Remove CS1632 check.
10422 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10424 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10427 2006-05-11 Raja R Harinath <rharinath@novell.com>
10429 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10430 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10431 (FlowBranchingException.Label): Likewise.
10433 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10435 (MyBitVector.Or): Use it to avoid losing information (Count).
10436 (FlowBranching.MergeOrigins): Likewise.
10438 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10439 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10440 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10441 (UsageVector.ToString): Simplify.
10442 (UsageVector.MergeSiblings): Move here from ...
10443 (FlowBranching.Merge): ... here.
10444 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10447 2006-05-10 Raja R Harinath <rharinath@novell.com>
10449 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10450 null bitvector is treated as all-true.
10452 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10453 (MyBitVector): Rationalize invariants. 'vector != null' implies
10454 that we have our own copy of the bitvector. Otherwise,
10455 'InheritsFrom == null' implies all inherited bits are true.
10457 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10459 * statement.cs (LocalInfo): Add IsConstant.
10460 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10461 local variable for constants.
10463 2006-05-09 Raja R Harinath <rharinath@novell.com>
10465 * flowanalysis.cs (MyBitVector.Empty): New.
10466 (MyBitVector): Don't allow InheritedFrom to be null.
10467 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10468 (UsageVector, FlowBranching): Update to changes.
10470 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10471 recursion. The 'Parent == null' condition isn't sufficient for
10473 (FlowBranching.AddBreakOrigin): Likewise.
10474 (FlowBranching.AddContinueOrigin): Likewise.
10475 (FlowBranching.AddReturnOrigin): Likewise.
10476 (FlowBranching.StealFinallyClauses): Likewise.
10477 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10478 (FlowBranching.CheckOutParameters): Likewise.
10479 (FlowBranchingToplevel): Terminate all the above recursions here.
10480 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10481 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10483 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10485 (FlowBranchingToplevel): New. Empty for now.
10486 (FlowBranching.MergeTopBlock): Update.
10487 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10488 branching for the anonymous delegate.
10489 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10491 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10492 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10493 information at the start of the merge. Reorganize.
10495 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10497 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10499 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10501 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10502 to newly introduced ctor.
10504 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10505 message to one place.
10506 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10509 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10511 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10513 * ecore.cs (Expression.ResolveAsConstant): Updated.
10515 * statement.cs (ResolveMeta): Updated.
10517 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10519 * cs-parser.jay: __arglist cannot be used in initializer.
10521 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10524 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10527 2006-05-05 Raja R Harinath <rharinath@novell.com>
10529 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10530 (LabeledStatement): Add 'name' parameter.
10531 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10532 (Block.AddLabel): Update to changes.
10533 * cs-parser.jay (labeled_statement): Likewise.
10535 * flowanalysis.cs (BranchingType.Labeled): New.
10536 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10537 (FlowBranchingLabeled): New. Does nothing for now, but will
10538 eventually handle 'goto' flows.
10539 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10540 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10541 that's terminated ...
10542 (Block.Resolve): ... here.
10544 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10545 (UsageVector.MergeFinallyOrigins): Likewise.
10546 (FlowBranching.InTryOrCatch): Likewise.
10547 (FlowBranching.AddFinallyVector): Likewise.
10548 (FlowBranchingException): Update to changes.
10551 * statement.cs (Return.Resolve): Move error checking to ...
10552 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10553 (FlowBranchingException): Handle return origins like break and
10555 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10557 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10560 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10563 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10566 * class.cs (MethodData.Define): Do public accessor check only when method
10567 implements an interface.
10569 2006-05-04 Raja R Harinath <rharinath@novell.com>
10571 Remove special handling of 'break'
10572 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10573 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10574 (UsageVector.Break): Remove.
10575 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10577 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10579 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10580 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10582 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10585 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10586 be the interface member.
10588 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10591 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10592 for emitting small (int) values.
10594 2006-05-03 Raja R Harinath <rharinath@novell.com>
10597 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10598 control-flow passes through the 'finally' after merging-in all the
10599 control-flows from 'try' and the 'catch' clauses.
10601 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10602 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10603 always true at the only non-recursive entry point.
10604 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10605 FlowBranchingBreakable.
10606 (FlowBranchingLoop): Remove.
10607 * statement.cs (Return.DoResolve): Update to changes.
10610 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10611 (FlowBranching.CreateBranching): Handle it: create a
10612 FlowBranchingContinuable.
10613 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10614 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10615 except that it handles the 'continue' command.
10616 (FlowBranching.UsageVector.MergeOrigins): Rename from
10618 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10619 except that it overrides AddContinueOrigin.
10620 (FlowBranchingException): Override AddContinueOrigin, similar to
10622 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10623 Create a new branching around the embedded statement.
10624 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10625 control flow after the embedded statement.
10626 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10628 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10629 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10630 FlowBranchingBreakable.
10631 (FlowBranchingSwitch): Remove.
10634 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10635 error reporting to ...
10636 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10637 Rename from 'AddBreakVector'. Add new location argument. Return
10638 a bool indicating whether the 'break' crosses an unwind-protect.
10639 (FlowBranchingException.AddBreakOrigin): Add.
10640 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10641 flowbranching after updating with the effects of the 'finally'
10643 (FlowBranchingBreakable): New common base class for
10644 FlowBranchingLoop and FlowBranchingSwitch.
10646 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10647 embedded statement.
10648 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10650 2006-05-02 Raja R Harinath <rharinath@novell.com>
10652 * statement.cs (Do.Resolve): If the loop is infinite, set the
10654 (While.Resolve, For.Resolve): Set a barrier after the embedded
10655 statement. There's no direct control flow that goes from the end
10656 of the embedded statement to the end of the loop.
10657 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10658 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10659 above ensure that the reachability is correctly computed.
10661 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10662 (UsageVector.MergeBreakOrigins): If the current path is
10663 unreachable, treat it as if all parameters/locals are initialized.
10664 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10665 infinite loops before merging-in break origins.
10667 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10668 (Reachability.Reachable): Split part into ...
10669 (Reachability.Unreachable): ... this. Simplify.
10670 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10672 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10673 (Reachability.SetThrowsSometimes): Likewise.
10674 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10675 TriState.Always, use corresponding property.
10676 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10677 (Block.Resolve): Likewise. Remove some redundant checks.
10679 2006-05-02 Raja R Harinath <harinath@gmail.com>
10681 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10682 (Reachability.Meet): Don't bother checking AlwaysThrows --
10683 barrier is always set.
10684 (FlowBranchingBlock.Merge): Likewise.
10686 2006-05-01 Raja R Harinath <harinath@gmail.com>
10688 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10689 checks for unreachable.
10691 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10694 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10696 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10697 whether field is really assigned.
10699 2006-04-30 Raja R Harinath <harinath@gmail.com>
10701 * flowanalysis.cs (Reachability): Make 4-argument constructor
10703 (Reachability.Meet): Rename from 'And'. Remove static variant.
10704 (Reachability.Always): Rename from the highly misleading
10705 'Reachability.Never'.
10706 (FlowBranching.Merge): Update to changes. Mark an impossible
10707 situation with a 'throw'.
10708 (*): Update to changes.
10710 2006-04-29 Raja R Harinath <harinath@gmail.com>
10712 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10713 Remove 'Undefined'.
10714 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10715 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10716 (*): Update to changes.
10717 * statement.cs: Update to changes.
10719 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10722 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10724 2006-04-28 Raja R Harinath <harinath@gmail.com>
10726 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10729 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10730 argument to two arguments: an usage-vector and a bool. Move call
10731 to FlowBranching.Merge () ...
10732 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10734 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10735 handling of loop and switch reachability to ...
10736 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10738 2006-04-27 Raja R Harinath <harinath@gmail.com>
10740 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10741 handling to FlowBranchingLoop.InLoop.
10742 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10744 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10747 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10748 anonymous method is allowed from AnonymousContainer here.
10750 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10752 2006-04-24 Raja R Harinath <rharinath@novell.com>
10755 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10757 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10760 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10761 (DoubleConstant.Reduce): Ditto.
10763 2006-04-23 Raja R Harinath <rharinath@novell.com>
10765 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10766 Remove 'lvalue_right_side' argument. Move parts to ...
10767 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10768 (LocalVariable.DoResolveLValue): ... these.
10770 2006-04-21 Raja R Harinath <rharinath@novell.com>
10773 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10774 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10775 (LocalVariableReference.DoResolveBase): Use it to implement new
10777 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10778 (Argument.Resolve): Simplify. Move CS1510 check ...
10779 * ecore.cs (Expression.ResolveLValue): ... here.
10780 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10781 (PropertyExpr.DoResolveLValue): Likewise.
10782 (FieldExpr.Report_AssignToReadonly): Likewise.
10783 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10784 LValueMemberAccess or LValueMemberOutAccess on instance depending
10786 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10787 DoResolve as appropriate.
10789 2006-04-20 Raja R Harinath <rharinath@novell.com>
10792 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10793 implicit conversions on 'out' and 'ref' arguments.
10795 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10796 improve clarity. Remove dead code.
10799 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10800 (Catch.Resolve): Resolve VarBlock if it exists.
10802 2006-04-19 Miguel de Icaza <miguel@novell.com>
10804 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10805 twice, this was some residual code, the enumerator was emitted
10806 properly in the two branche of if later.
10808 2006-04-19 Raja R Harinath <rharinath@novell.com>
10810 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10811 cast is never an lvalue.
10812 (Cast.DoResolve, Cast.ResolveRest): Combine.
10813 (Argument.Emit): Simplify slightly. Move 'Expr is
10814 IMemoryLocation' check ...
10815 (Argument.Resolve): ... here.
10816 (Argument.Error_LValueRequired): Remove. Inline into only user.
10818 Simplifications. Fix cs0191-2.cs
10819 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10820 CS1649 and CS1651 to ...
10821 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10822 the actual selection of the error code and message to a lookup
10823 table. Add a dummy return value to simplify callsites.
10824 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10825 readonly fields of other instances of the same type. Move CS0197
10827 * expression.cs (Argument.Resolve): ... here. Simplify code.
10828 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10829 resolution of an out or ref argument. The code simplification
10830 above uses this invariant.
10832 2006-04-18 Raja R Harinath <rharinath@novell.com>
10834 Possibly fix #77752. Fix cs1690-[4-7].cs.
10835 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10836 CheckMarshallByRefAccess. Drop parameter.
10837 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10839 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10840 InstanceExpression.
10841 * report.cs (AllWarnings): Add CS1690.
10842 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10843 for ref access too.
10844 (LocalVariableReference.DoResolveBase): Update.
10846 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10848 * class.cs (MethodOrOperator): Moved common parts from method class.
10849 detect obsolete attributes.
10850 (Method.Define): Simplified as it reuses code from base.
10851 (Constructor.ValidAttributeTargets): Fixed issue found during
10853 (Destructor.ValidAttributeTargets): Fixed issue found during
10855 (Operator): Finished refactoring set off by #78020. Operator class is now
10856 ordinary method class.
10858 * anonymous.cs: Updated.
10860 * decl.cs (DeclSpace): Add IsGeneric
10862 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10864 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10866 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10868 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10869 detect obsolete attributes.
10870 (Method.CreateEmitContext): Moved to MethodOrOperator.
10872 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10875 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10876 customized exception to make crash detection easier.
10877 (MethodOrOperator): Started to work on new base class for methods and
10879 (Method): Derives from MethodOrOperator.
10880 (Constructor.Emit): Emits its own attributes.
10881 (AbstractPropertyEventMethod.Emit): Ditto.
10882 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10884 (Operator.Emit): It's temporary more tricky than should be.
10886 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10888 * report.cs (InternalErrorException): Add ctor with inner exception.
10890 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10893 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10896 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10899 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10902 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10904 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10905 attribute is present and Guid not.
10906 (Interface.ApplyAttributeBuilder): Ditto.
10908 * attribute.cs: Add error message.
10910 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10914 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10915 sources (it's composite) so hold them in extra array as they are used in
10916 Emit phase only. It worked in the previous versions by mistake.
10917 (Attribute.Emit): Emit attribute for more owners when exist.
10919 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10920 it has now different behaviour.
10922 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10924 * constant.cs (Constant.IsDefaultInitializer): New method.
10926 * class.cs: Updated.
10928 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10929 re-initialize default values. It saves KBs almost for every assembly.
10930 Thanks Zoltan for the idea.
10931 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10932 (ArrayCreation.DoResolve): Resolve only once.
10933 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10934 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10936 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10938 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10941 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10943 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10944 in an embedded statement too.
10946 2006-04-01 Raja R Harinath <rharinath@novell.com>
10949 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10951 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10955 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10958 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10960 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10962 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10965 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10966 LocalTemporary change.
10968 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10970 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10971 initializers optimization.
10972 (ClassOrStruct.TypeAttr): Moved from modifiers.
10973 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10974 (FieldBase.ResolveInitializer): Resolves initializer.
10975 (FieldBase.HasDefaultInitializer): New property.
10977 * cs-parser.jay: Removed message.
10979 * expression.cs (CompilerGeneratedThis): New specialization.
10981 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10983 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10985 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10987 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10989 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10990 be now EnumConstants only.
10992 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10994 * attribute.cs, driver.cs: Reset more caches.
10996 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10998 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
11000 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11002 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
11003 for easier reuse. Updated all overrides.
11004 (IntegralConstant): New base class for all integral constants.
11005 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
11006 of the constant range, report custom error.
11007 (UIntConstant.Reduce): Fixed uint conversion.
11009 * ecore.cs, literal.cs: Reduce updates.
11011 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11015 * class.cs (Constructor.Define): Removed extra if for default ctors.
11016 A patch from Atsushi Enomoto.
11018 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11020 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
11021 GetAttributableValue.
11023 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
11026 * convert.cs (ImplicitConversionRequired): Error message moved to
11029 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
11030 automatic implicit conversion of an output value.
11031 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
11033 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
11035 (TypeOf.GetAttributableValue): Add extra handling for object type.
11037 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
11038 special error message.
11040 2006-03-25 Marek Safar <marek.safar@seznam.cz>
11042 * class.cs (Constructor.Emit): Don't crash when struct ctor is
11044 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
11045 compatible with MS runtime.
11047 2006-03-23 Marek Safar <marek.safar@seznam.cz>
11049 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
11050 attribute arguments here.
11052 * class.cs (Indexer.Define): The check was moved to attribute class.
11054 2006-03-22 Marek Safar <marek.safar@seznam.cz>
11056 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
11057 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
11060 2006-03-22 Raja R Harinath <rharinath@novell.com>
11062 Support ParameterDefaultValueAttribute in gmcs. Also applied to
11063 mcs to keep code differences small.
11064 * attribute.cs (Attribute.GetParameterDefaultValue): New.
11065 * typemanager.cs (parameter_default_value_attribute_type): New.
11066 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
11069 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11071 * expression.cs (StringConcat.Append): Reverted back to no warning state.
11073 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11075 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
11077 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
11080 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
11082 * doc-bootstrap.cs : fix build.
11084 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11086 * expression.cs (StringConcat.Append): Issue a warning when empty string
11087 is going to append.
11089 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11091 * assign.cs (CompoundAssign.ResolveSource): Removed.
11093 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
11096 * class.cs (TypeContainer.FindMethods): Removed.
11097 (TypeContainer.CheckMemberUsage): Made static.
11099 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
11101 * constant.cs (CheckRange): Removed unused type argument.
11102 (CheckUnsigned): Removed unused type argument.
11104 * cs-parser.jay: Updated after MemberAccess clean up.
11105 Uses Length for empty string test.
11107 * cs-tokenizer.cs: Uses Length for empty string test.
11108 (IsCastToken): Made static.
11109 (is_hex): Made static.
11110 (real_type_suffix): Made static.
11112 * decl.cs (SetupCache): Made static.
11113 (OnGenerateDocComment): Removed unused ds argument.
11115 * delegate.cs (VerifyDelegate): Removed unused argument.
11117 * doc.cs: Uses Length for empty string test.
11119 * driver.cs: Uses Length for empty string test.
11121 * enum.cs (IsValidEnumType): Made static
11123 * expression.cs (EnumLiftUp): Removed unused argument.
11124 (ResolveMethodGroup): Ditto.
11125 (BetterConversion): Ditto.
11126 (GetVarargsTypes): Ditto.
11127 (UpdateIndices): Ditto.
11128 (ValidateInitializers): Ditto.
11129 (MemberAccess.ctor): Ditto.
11130 (GetIndexersForType): Ditto.
11132 * flowanalysis.cs: (MergeFinally): Removed unused argument.
11134 * iterators.cs: Updated after MemberAccess clean up.
11136 * location.cs: Uses Length for empty string test.
11138 * namespace.cs: Uses Length for empty string test.
11140 * report.cs (CheckWarningCode): Made static.
11142 * statement.cs (LabeledStatement): Removed unused argument.
11144 * typemanager.cs (FilterNone): Removed.
11146 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11148 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
11151 * class.cs: Updated.
11153 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11155 * cs-parser.jay.cs: __arglist is not allowed for delegates.
11157 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11161 * expression.cs (VerifyArgumentsCompat): Reverted to double error
11162 reporting, it's more tricky than I thought.
11164 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11168 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
11170 (AnonymousMethod.ImplicitStandardConversionExists): New method.
11171 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
11172 Add more error reporting; Fixed issue with params.
11174 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
11176 * cs-parser.jay: AnonymousMethod requires host container.
11178 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
11180 2006-03-18 Raja R Harinath <harinath@gmail.com>
11182 * class.cs: Change 'TypeContainer ds' constructor argument to
11183 'DeclSpace parent'. Some classes were missed below due to
11184 different naming convention.
11186 * class.cs (MemberCore.Parent): Delete. This makes the
11187 ParentContainer changes below enforceable by the compiler.
11189 Treat pointers to enclosing declaration space as 'DeclSpace', not
11191 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11192 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11194 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11196 (Block.AddThisVariable): Likewise.
11197 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11198 (AbstractPropertyEventMethod.Emit): Likewise.
11199 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11200 (GetMethod.Define, SetMethod.Define): Likewise.
11201 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11202 (DelegateMethod.EmitMethod): Likewise.
11204 Fix regression test-partial-13.cs.
11205 Rationalize use of PartialContainer. Ensure that the partial
11206 class semantics can be tied to type-correctness, i.e., any
11207 violation will cause a compile error.
11208 * class.cs, const.cs: Access all fields that belong to class
11209 TypeContainer via ParentContainer. Arguments of EmitContexts and
11210 Resolve()-like functions still use 'Parent'.
11212 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11213 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11214 (PropertyMethod.CheckModifiers): Remove unused argument.
11215 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11218 2006-03-17 Raja R Harinath <harinath@gmail.com>
11220 Make semantics of PartialContainer simpler.
11221 * decl.cs (DeclSpace.IsPartial): Remove.
11222 * class.cs (TypeContainer.IsPartial): Likewise.
11223 (TypeContainer..ctor): Set PartialContainer to point to self.
11224 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11225 (TypeContainer.FindNestedType): Likewise.
11226 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11228 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11230 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11232 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11234 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11237 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11239 * class.cs (Operator.Define): An error for base conversion was not
11240 reported correctly.
11242 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11244 * iterator.cs : yield break is allowed in try statement which has
11245 catch clauses. Fixed bug #77767.
11247 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11249 A fix for #77593, #77574.
11251 * class.cs (MethodCore.CheckBase): Another if for operator.
11253 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11255 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11258 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11259 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11262 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11265 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11266 Updated after another emitcontext usage was clean up. It should help us to
11267 synchronize with gmcs easier.
11269 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11273 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11274 (Event.Define): ditto
11275 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11277 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11278 Removed redundant code and set NewSlot for Invoke method too.
11280 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11281 (Parameters.MergeGenerated): New method. Use this method when you merge
11282 compiler generated argument with user arguments.
11284 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11286 * attribute.cs (ResolveAsTypeTerminal): Removed.
11288 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11289 specialization for predefined types; 30% speed up.
11290 Finally placed obsolete check to right place.
11291 (Expression.ResolveType): Removed.
11293 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11294 Updated after ResolveType was removed.
11296 * expression.cs (Cast.ctor): Check void cast.
11297 (Binary.ResolveAsTypeTerminal): Is never type.
11298 (Conditional.ResolveAsTypeTerminal): Is never type.
11300 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11302 2006-03-01 Raja R Harinath <rharinath@novell.com>
11305 * expression.cs (ParameterReference.DoResolveBase): Change return
11307 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11311 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11314 * typemanager.cs (GetFullNameSignature): Don't nullref on
11315 protected accessors.
11317 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11319 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11320 these two separated members to simplify the code.
11321 (Attribute.Resolve): Refactored to use new fields and methods.
11322 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11323 implemented obsolete attribute checking.
11324 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11325 implemented obsolete checking again. It look line never ending quest ;-)
11326 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11328 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11330 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11332 *class.cs (Property.Define): Add RegisterProperty call.
11334 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11335 argument groups (only 2).
11337 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11338 encoding expression to arguments.
11339 (Expression.ExprClassToResolveFlags): Just turned to property.
11341 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11342 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11343 optimized as well as implemented support for zero-length attributes.
11345 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11346 Add caching of PropertyInfo's.
11348 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11350 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11351 error multiple times.
11353 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11355 New partial class implementation.
11356 A fix for #77027, #77029, #77403
11358 * attribute.cs (Attributable): Made attributes protected.
11360 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11361 the replacements of ClassPart and PartialContainer.
11362 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11363 (TypeContainer.AddInterface): Ditto.
11364 (TypeContainer.AddPartial): The main method for partial classes. It checks
11365 for errors and merges ModFlags and attributes. At the end class is added to
11366 partial_parts list.
11367 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11369 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11370 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11371 from the rest of partial classes.
11372 (TypeContainer.GetClassBases): Simplified.
11373 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11375 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11376 (TypeContainer.HasExplicitLayout): Uses Flags now.
11377 (PartialContainer): Removed.
11378 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11379 (StaticClass): Was merged with Class.
11380 (Class.GetClassBases): class and static class bases are verified here.
11381 (Class.TypeAttr): Added static attributes when class is static.
11382 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11383 (MemberBase): In some cases we need to call parent container for partial
11384 class. It should be eliminated but it's not easy now.
11386 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11388 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11389 partial classed to accumulate class comments.
11390 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11392 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11394 * driver.cs (MainDriver): Tree.GetDecl was removed.
11396 * modifiers.cs (Modifiers): Add partial modifier.
11398 * tree.cs (Tree.decl): Removed.
11399 (RootTypes): Started to use this class more often for root types
11402 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11406 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11407 external interface does not have an attribute.
11409 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11411 Another prerequisites for new partial classs implementation.
11413 * attribute.cs (Attribute.Equal): Implemented.
11414 (Attribute.Emit): Changed as attributes can be applied more than twice.
11415 (Attributes.Emit): Check for duplicate attributes here.
11417 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11418 as a parameter, clean-up.
11420 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11424 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11425 contains obsolete attribute check which can in some cases look for base
11426 type of current class which is not initialized yet.
11427 (TypeContainer.BaseType): Replacement of ptype.
11429 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11431 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11433 First of prerequisites for new partial classs implemention.
11435 * attribute.cs (Attributable): Extended by ResolveContext;
11436 Attributes finally have correct context for resolving in all cases.
11437 (AttachTo): Attribute owner is assigned here.
11439 * codegen.cs (IResolveContext): Introduce new interface to hold
11440 all information needed in resolving phase.
11441 (EmitContext): Implements IResolveContext; more clean-up needed here.
11443 * decl.cs (MemberCore): Implemented IResolveContext.
11445 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11446 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11447 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11448 Refactored to use new IResolveContext instead of EmitContext; cleanup
11450 2006-02-06 Miguel de Icaza <miguel@novell.com>
11452 * codegen.cs (EmitScopeInitFromBlock): check here the
11453 capture_context, there is no need to make two calls to the
11456 * anonymous.cs: Add some debugging messages that might help me
11457 track other instances of this problem in the future (the
11458 regression of test 467).
11460 * cs-parser.jay: track the variable block, as we need to initalize
11461 any captured variables declared in this block for the "catch"
11462 portion of the "Try" statement.
11464 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11465 scope initialization for captured variables.
11467 Also, move the emit for the variables after the block location has
11470 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11472 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11474 2006-02-02 Miguel de Icaza <miguel@novell.com>
11476 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11477 commit yesterday, the initialization for the roots is necessary.
11478 What is not necessary is the scope activation.
11480 2006-02-02 Raja R Harinath <rharinath@novell.com>
11482 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11483 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11485 (Argument.Resolve): Remove CS0206 checks.
11487 2006-02-01 Miguel de Icaza <miguel@novell.com>
11489 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11490 scopes for all the roots, the scopes will now be emitted when the
11491 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11493 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11494 code. This reduces a lot of existing cruft.
11496 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11497 that the ScopeInfo is generated as we enter the scope, not at the
11498 time of use, which is what we used to do before.
11500 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11501 every time a Block is about to be emitted if we have a
11504 2006-02-01 Raja R Harinath <rharinath@novell.com>
11506 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11508 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11510 * typemanager.cs (cons_param_array_attribute): Make private.
11511 (Reset): Set it to null.
11512 (InitCoreHelpers): Don't initialize it.
11513 (ConsParamArrayAttribute): New. Initialize it as needed.
11514 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11516 2006-01-31 Miguel de Icaza <miguel@novell.com>
11518 * expression.cs: There might be errors reported during the
11519 selection of applicable methods. If there are errors, do not
11520 continue execution as it will lead the compiler to crash.
11522 2006-01-30 Miguel de Icaza <miguel@novell.com>
11524 * expression.cs: Member access is not allowed on anonymous
11525 methods. Fixes #77402.
11527 2006-01-30 Raja R Harinath <rharinath@novell.com>
11530 * cs-parser.jay (VariableDeclaration): Don't set
11531 current_array_type to null.
11532 (field_declaration, event_declaration, declaration_statement):
11533 Set it to null here.
11535 2006-01-28 Raja R Harinath <harinath@gmail.com>
11537 * typemanager.cs (GenericParameterPosition): New.
11540 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11542 * doc.cs : To process "include" elements, first we should create
11543 another list than XmlNodeList, because it could result in node
11544 removal, which could result in that the XmlNodeList gives up
11545 yielding next node.
11547 (Also made code identical to gmcs again.)
11549 2006-01-25 Miguel de Icaza <miguel@novell.com>
11551 * ecore.cs: Introduce an error report that we were not catching
11552 before, if not silent, we must report the error. Gonzalo ran into
11555 2006-01-23 Miguel de Icaza <miguel@novell.com>
11557 A fix for bug: #76957
11559 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11560 ComputeMethodHost before creating the method, this is a new
11563 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11564 that this method references (RegisterScope). The actual scope
11565 where the method is hosted is computed with the ComputeMethodHost
11566 before we create the method.
11568 Moved the Deepest routine here.
11570 (AnonymousContainer.ComputeMethodHost): New routine used to
11571 compute the proper ScopeInfo that will host the anonymous method.
11573 (ScopeInfo): Deal with multiple roots. The problem was that we
11574 did not have a unique root where all ScopeInfos could be hanged
11575 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11578 Remove AdjustMethodScope which is now computed at the end. Remove
11579 LinkScope which did a partial link, instead link all ScopeInfos
11580 before code generation from the new "LinkScopes" routine.
11582 Simplify all the Add* routines as they no longer need to maintain
11583 the tree, they just need to record that they are using variables
11586 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11587 routines to produce the forest of ScopeInfo trees.
11589 * class.cs (TypeContainer.AppendMethod): This is just like
11590 AddMethod, but ensures that an interface implementation method
11591 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11592 methods, but at the end.
11594 We use this functionality to ensure that the generated MoveNext
11595 method in the iterator class is resolved/emitted before the
11596 enumerator methods created.
11598 This is required because the MoveNext method computes the right
11599 ScopeInfo for the method. And the other methods will eventually
11600 need to resolve and fetch information computed from the anonymous
11603 2006-01-21 Raja R Harinath <harinath@gmail.com>
11604 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11606 Fix rest of #76995.
11607 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11608 the 'aliases' hash.
11609 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11610 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11612 2006-01-18 Raja R Harinath <rharinath@novell.com>
11614 Fix #76656, cs0231-2.cs.
11615 * cs-parser.jay (formal_parameter_list): Make error case catch
11617 (parenthesized_expression_0): Add CS1026 check.
11618 (invocation_expression): Remove unused { $$ = lexer.Location }.
11620 2006-01-17 Raja R Harinath <rharinath@novell.com>
11623 * cs-parser.jay (statement_expression): Don't list out the
11624 individual statement-expressions. Convert syntax error into
11627 2006-01-16 Raja R Harinath <rharinath@novell.com>
11630 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11631 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11632 CheckIntermediateModification.
11633 (FieldExpr.DoResolve): Add new two-argument version that
11634 allows us to resolve the InstanceExpression as an lvalue.
11635 The one-argument variant is now just a wrapper.
11636 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11637 Resolve the lhs as an lvalue if the it has a value type.
11638 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11639 from Assign.DoResolve.
11640 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11641 resolved as an lvalue.
11642 (PropertyExpr.DoResolve): Update.
11643 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11644 has a value type. Move CS1612 check here from
11645 CheckIntermediateModification.
11646 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11647 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11648 'right_side' of a ResolveLValue on an 'out' argument.
11649 (EmptyExpression.LValueMemberAccess): New. Used as the
11650 'right_side' of a propagated ResolveLValue on a value type.
11651 (LocalVariableReference.DoResolveBase): Recognize
11652 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11654 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11655 EmptyExpression.Null.
11657 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11659 * typemanager.cs : added IsGenericParameter(). In mcs it always
11661 * doc.cs : for generic parameters, use GenericParameterPosition,
11664 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11666 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11668 2006-01-12 Miguel de Icaza <miguel@novell.com>
11670 This fixes the problem where we used ldfld instead of ldflda to
11671 load the "THIS" pointer on captured parameters, when THIS is a
11672 value type. See bug #77205.
11674 * iterators.cs (CapturedThisReference.Emit): Pass false to
11675 EmitThis (we do not need the address).
11677 * codegen.cs (EmitThis): it needs to know whether we need the
11678 address of `this' or not. This is used by value types.
11680 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11681 every other call passes false.
11683 2006-01-12 Raja R Harinath <rharinath@novell.com>
11686 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11688 * expression.cs (Invocation.OverloadResolve): Update.
11689 (Invocation.DoResolve): Avoid double resolution of invocation.
11691 2006-01-11 Raja R Harinath <rharinath@novell.com>
11694 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11695 unary negation of floating point types as 0-expr; negation cannot
11696 overflow in floating point types.
11699 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11700 on operands of 'void' type.
11703 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11704 and ExclusiveOr for boolean constants too.
11706 2006-01-09 Raja R Harinath <rharinath@novell.com>
11709 * expression.cs (Invocation.OverloadResolve): Replace reflected
11710 override methods with their base virtual methods, rather than
11711 skipping over them.
11712 * typemanager.cs (TypeManager.GetOverride): New.
11714 2006-01-05 Jb Evain <jbevain@gmail.com>
11716 * class.cs (Property.Define, Indexer.Define): do not tag the
11717 properties as SpecialName | RTSpecialName.
11719 2006-01-04 Miguel de Icaza <miguel@novell.com>
11721 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11722 doing a low-level comparission of parameter types. It was lacking
11723 a check for __argslist.
11725 2005-12-30 Miguel de Icaza <miguel@novell.com>
11727 * expression.cs (ParameterReference.DoResolveBase): Allow
11728 reference parameters if they are local to this block.
11730 This allows the ref and out parameters of a delegate to be used in
11731 an anonymous method, for example:
11733 delegate void set (out int x);
11735 set s = delegate (out int x){
11739 This is used by functionality introduced late in the C# language.
11741 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11742 method that take ref and out parameters.
11744 Fixes #77119 which was a late change in the spec.
11746 2005-12-23 Miguel de Icaza <miguel@novell.com>
11748 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11749 parent if its the same scope. Fixes #77060.
11751 2005-12-21 Miguel de Icaza <miguel@novell.com>
11753 * driver.cs: Report the case of no source files and no -out:
11756 2005-12-20 Raja R Harinath <rharinath@novell.com>
11759 * expression.cs (ComposedCast.GetSignatureForError): Define.
11761 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11765 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11766 ListDictionary, to contain the ExternAliasEntry entries (in
11767 addition to the NamespaceEntry.aliases hashtable). This field is
11768 shared between the original entry and its doppelganger (bodyless
11770 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11771 extern_aliases field.
11772 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11773 lookup in extern_aliases.
11775 2005-12-16 Raja R Harinath <rharinath@novell.com>
11778 * class.cs (TypeContainer.Mark_HasEquals): New.
11779 (TypeContainer.Mark_HasGetHashCode): New.
11780 (ClassPart): Override them.
11781 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11784 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11785 'parent' argument to the base constructor.
11787 Remove all mention of TypeContainer from decl.cs.
11788 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11789 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11790 (DeclSpace.DeclSpace): Likewise.
11791 (DeclSpace.DefineMembers): Remove unused argument.
11792 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11793 debugging check -- we don't care if the debug code throws an
11794 InvalidCastException instead of an InternalErrorException.
11795 * class.cs (TypeContainer.DefineMembers): Update to changes.
11796 (TypeContainer.DoDefineMembers): Likewise.
11797 (TypeContainer.GetMethods): Likewise.
11798 (PropertyMember.Define): Likewise.
11799 (MemberBase.Parent): New property that forwards to
11800 MemberCore.Parent, but ensures that we get a TypeContainer.
11801 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11802 (RootContext.PopulateTypes): Likewise. Remove special case code
11803 for !RootContext.StdLib: DefineMembers is idempotent.
11805 2005-12-14 Miguel de Icaza <miguel@novell.com>
11807 * convert.cs (ExplicitConversionCore): Check the return value from
11808 ExplicitConversionCore which can return null on failure. Fixes #76914
11810 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11812 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11814 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11816 * doc.cs : The search for referenced namespace was insufficient to
11817 get global one as it used to do. Fixed bug #76965.
11819 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11821 * doc.cs : check name in cref in the last phase that whether it is
11824 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11826 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11829 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11831 * doc.cs : so it turned out that we cannot skip override check for
11832 interface members. Fixed bug #76954.
11834 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11836 * cs-tokenizer.cs : fixed bug #75984:
11837 - #warning and #error should not be handled when the source line
11839 - #line is not checked strictly when the source line is disabled.
11840 - #define and #undef is on the other hand checked strictly at any
11843 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11845 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11848 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11850 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11852 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11853 event initializers.
11854 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11855 (FieldBase.Initializer): Initializer is now optional.
11856 (EventField.Define): Only event field can have initializer.
11858 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11860 * const.cs (Const): Reuse initializer.
11862 * cs-parser.jay: Updated after FieldBase changes.
11863 Added current_array_type to simplify array initializers.
11865 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11867 * expression.cs, iterators.cs: Updated.
11869 * namespace.cs (NamespaceEntry): Made UsingFound private.
11871 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11873 * parameterCollection.cs: Obsolete, removed.
11874 * parser.cs: Obsolete, removed.
11876 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11879 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11881 * enum.cs (Enum.Define): Set obsolete context here.
11883 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11886 - FindDocumentedMember() now expects 1) paramList as null
11887 when "we don't have to check the number of parameters" and
11888 2) Type.EmptyTypes when "there is no arguments".
11889 - Introduced FoundMember struct to hold the exact type which was
11890 used to find the documented member (the above change broke
11891 test-xml-044; it might be better just to use DeclaringType than
11892 what MS does, like this change does, but it depends on usage.)
11894 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11896 * doc.cs : documented member might be from DeclaringType for nested
11897 types. Fixed bug #76782.
11899 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11901 * anonymous.cs: Have the param code handle leaving copies on the
11902 stack etc. Allows anonymous params to take part in the assignment
11903 code (++, +=, etc). Fixes bug #76550
11905 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11906 it down to the anon code.
11908 * iterators.cs: Use dummy var here
11910 * codegen.cs: Handle new vars
11912 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11915 * class.cs (MethodData.Define): Set proper Obsolete context.
11917 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11919 (FieldExpr.DoResolve): Ditto.
11921 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11924 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11925 parent is not obsolete.
11927 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11929 * doc.cs : (FindDocumentedMember) find parameterless members first
11930 and get CS0419 in the early stage. Fixed first case of bug #76727.
11932 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11935 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11936 no error was reported.
11938 *expression.cs (Binary.DoResolve): left can be null.
11940 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11943 * class.cs (MethodData.Emit): Parameters should be labeled first.
11945 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11948 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11950 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11952 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11954 * class.cs (MethodCore): Parameter clean up.
11955 (IMethodData): Added ParameterInfo.
11956 (MethodData): Parameter clean up.
11957 (Indexer.Define): Parameter clean up.
11969 * typemanager.cs: Parameter clean up.
11971 * delegate.cs (Define): Get rid of duplicated code.
11973 * expression.cs (ParameterReference): Removed useless parameters
11975 (Invocation): Ditto.
11977 * parameter.cs (ParamsParameter): New class, params specialization.
11978 (ArglistParameter): Attemp to separate arglist.
11979 (Parameter): Refactored to be reusable and faster.
11980 (Parameter.Modifier): Made understandable.
11981 (Parameters): Changed to be used as a class for `this' assembly
11982 parameters. Refactored to use new specialized classes.
11984 * support.cs (ParameterData): Added Types property.
11985 (InternalParameters): Deleted.
11987 2005-08-20 Martin Baulig <martin@ximian.com>
11989 Merging this patch from GMCS to fix #75867.
11991 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11992 scope if we don't already have it.
11994 2005-11-17 Martin Baulig <martin@ximian.com>
11997 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11998 inherit the scope from our parent. Fixes #76653.
12000 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12002 * doc.cs : the previous patch does not actually fix the bug.
12003 PropertyInfo override check is now implemented and really fixed it.
12004 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
12006 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12008 * doc.cs : apply "override filter" also to properties.
12011 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12013 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
12014 no need to check overrides. For classes, omit those results from
12015 interfaces since they must exist in the class. Fixed bug #76726.
12017 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12019 * typemanager.cs : (GetFullNameSignature) differentiate indexers
12020 with different parameters. Fixed the second problem in #76685.
12022 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12024 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
12025 get expected 'protected' access in CheckValidFamilyAccess()).
12028 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12030 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
12031 Fixed bug #76705. CS1569 was incorrectly commented out.
12033 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12035 * doc.cs : use Invocation.IsOverride() to do real override check.
12036 * expression.cs : made Invocation.IsOverride() internal.
12038 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12040 * doc.cs : use TypeManager.FindMembers() instead of (possible)
12041 TypeBuilder.FindMembers() and filter overriden base members out.
12044 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12046 * doc.cs : ref/out parameters are represented as '@' (instead of
12047 '&' in type FullName). Fixed bug #76630 (additionally crefs).
12049 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12051 * doc.cs : when there was no '.' in cref to methods in doc comment,
12052 then parameters were missing in the output. Fixed bug #76691.
12054 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12056 * driver.cs : don't output docs when there is an error.
12059 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12062 Now it should detect indexers. Fixed primary concern in bug #76685.
12063 Fixed CS0419 message to not show the identical member signature in
12066 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12068 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
12069 instead of Type.FindMembers() since it does not handle events.
12072 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
12074 * codegen.cs: Fixed typo (speficied -> specified).
12076 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12079 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
12081 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12083 * attribute.cs: Changed error message.
12085 * cs-tokenizer.cs: One more check.
12087 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12089 * statement.cs (Block.Resolve): Ignore empty statement.
12091 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12093 * report.cs: Made error/warning methods more strict to avoid
12096 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
12097 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
12098 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
12099 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
12101 2005-11-08 Marek Safar <marek.safar@seznam.cz>
12103 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
12104 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
12106 * class.cs (TypeContainer.IsComImport): New property.
12107 (Constructor.Define): Create proper ctor for ComImport types.
12109 * expression.cs (New.CheckComImport): Fixed.
12111 2005-11-07 Miguel de Icaza <miguel@novell.com>
12113 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
12114 that a parameter has been captured does not mean that we do not
12115 have to do the rest of the processing. This fixes the second part
12116 of #76592. If there was another anonymous method capturing
12117 values in the past, the Scope would never be set for the second
12118 method that captured the same parameter.
12120 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
12121 properly manipulate the stack. Second part of fix for #76592.
12123 * expression.cs (New): Add support for invoking "new" on
12124 interfaces that have been flagged with the ComImport attribute and
12125 the CoClass. Fixes #76637
12127 * statement.cs (Try.DoEmit): When a variable is captured, do not
12128 try to emit the vi.LocalBuilder variable as it has been captured.
12129 Create a temporary variable and store the results on the
12130 FieldBuilder. Fixes #76642
12132 2005-11-07 Marek Safar <marek.safar@seznam.cz>
12134 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
12136 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
12138 * expression.cs (Binary.DoResolve): Added && optimalization.
12140 * typemanager.cs (AddUserType): Removed useless argument.
12142 2005-11-04 Marek Safar <marek.safar@seznam.cz>
12144 * statement.cs (Block.variables): Uses ListDictionary.
12146 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12149 * class.cs (PartialContainer.EmitType): Customized to emit
12150 security attributes.
12151 (ClassPart.ApplyAttributeBuilder): Transform security attribute
12152 for partial classes.
12154 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12157 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
12158 access has to be fixed.
12160 * typemanager.cs (IsUnmanagedType): Wrong common field type.
12162 2005-11-01 Marek Safar <marek.safar@seznam.cz>
12165 * ecore.cs (NullCast.Reduce): Implemented.
12167 * expression.cs (ArrayCreation.CheckIndices): Correcly check
12170 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
12172 (Foreach.Resolve): Catch null properly.
12174 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12176 * cs-tokenizer.cs: Warning text fix.
12178 * driver.cs: AllWarningNumbers exposed on public interface.
12180 * report.cs (): Reviewed warning numbers.
12181 (IsValidWarning): Use binary search.
12183 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12185 * driver.cs: Implemeted resource visibility.
12186 (Resources): New class for code sharing between /res: and
12189 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12192 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12195 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12198 * ecore.cs (NullCast): Child is contant only.
12200 * literal.cs (NullLiteral.Reduce): null can be converted to any
12203 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12205 * driver.cs: Use Encoding.Default as default code page instead
12208 2005-10-27 Raja R Harinath <rharinath@novell.com>
12211 * expression.cs (Invocation.Error_InvalidArguments): Handle
12212 __arglist parameters.
12213 (Invocation.VerifyArgumentsCompat): Likewise.
12214 * support.cs (ReflectionParameters.GetSignatureForError): Print
12215 __arglist parameters.
12216 (InternalParamters.GetSignatureForError): Likewise.
12217 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12219 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12221 * attribute.cs (GetPropertyValue): Made public.
12223 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12225 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12227 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12230 * driver.cs: Reflect method name change.
12232 * statement.cs (Try.Resolve): Warn when try has both general
12233 exception handlers.
12235 * typemanager.cs: runtime_compatibility_attr_type new predefined
12238 2005-10-26 Raja R Harinath <harinath@gmail.com>
12241 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12242 treat it as an empty parameter list.
12244 2005-10-26 Raja R Harinath <rharinath@novell.com>
12247 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12248 ResolveAsTypeStep silent.
12249 * statement.cs (Block.AddConstant): Mark block as used.
12250 (Block.ResolveMeta): Avoid piling on error messages
12251 if a constant initializer resolution fails.
12253 2005-10-25 Raja R Harinath <rharinath@novell.com>
12255 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12257 (NamespaceEntry.VerifyAllUsing): New.
12258 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12259 behaviour. Delegates actual resolution of alias to ...
12260 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12261 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12263 * driver.cs (Driver.MainDriver): Update.
12265 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12266 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12268 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12270 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12271 RootNamespace.DefineNamespacesForAll.
12273 2005-10-24 Raja R Harinath <harinath@gmail.com>
12275 * typemanager.cs (assemblies, external_aliases, modules)
12276 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12277 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12278 overhead. Move resposibility ...
12279 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12280 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12282 2005-10-23 Raja R Harinath <harinath@gmail.com>
12284 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12285 cached_namespaces. Improve usage.
12286 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12287 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12288 Move from GlobalRootNamespace and simplify.
12289 (RootNamespace.Global): Make instance variable.
12290 (RootNamespace.RootNamespace): Add "alias name" parameter.
12291 (GlobalRootNamespace): Simplify drastically.
12292 (Namespace.Lookup): Don't use GetNamespace.
12293 * typemanager.cs (GetRootNamespace): Rename from
12294 ComputeNamespaceForAlias.
12295 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12297 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12299 * anonymous.cs (AnonymousContainer): Don't crash when container
12302 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12304 * expression.cs (Binary.DoResolve): Warn when comparing same
12307 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12310 * expression.cs (Binary.DoResolve): It looks like there are no
12311 convetsion rules in enum context.
12313 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12315 Add support for extern alias qualifiers.
12316 * typemanager.cs: Move some LookupTypeReflection code
12317 to namespace.cs, to have cleaner code. Added some methods
12318 to help us keep track of the extern aliased references.
12319 * driver.cs: Add suport for extern alias assemblies on command
12320 line and check for their warnings/errors. Also keep track of the
12321 extern aliased assemblies.
12322 * namespace.cs: Move the global functionality of Namespace
12323 to GlobalRootNamespace/RootNamespace. Now the global namespace
12324 is GlobalRootNamespace.Globa. Also the code moved from
12325 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12326 Finally added LocalAliasEntry (AliasEntry before) and
12327 ExternAliasEntry, to handle alias statements.
12328 * cs-parser.jay: Add support in the grammar for extern alias
12330 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12331 Update callings to Namespace (now in GlobalRootNamespace).
12333 2005-10-18 Raja R Harinath <rharinath@novell.com>
12336 * class.cs (TypeContainer.DefineType): Move updating of
12337 topological sort earlier in the code.
12338 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12340 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12343 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12345 * constant.cs (Constant.TryReduce): Moved from Cast class.
12346 (Reduce): Made little bit more OO and fixed missing conversions.
12348 * ecore.cs (Reduce): Implemented.
12349 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12351 * literal.cs (Reduce): Implemented.
12353 * class.cs: Reverted Miguel's wrong commit.
12355 2005-10-14 Miguel de Icaza <miguel@novell.com>
12357 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12359 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12361 * cs-parser.jay, expression.cs : CS0214 was missing error location
12362 for constants. Fixed bug #76404.
12364 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12367 * convert.cs (ExplicitConversionCore): Fixed object->enum
12370 2005-10-10 Raja R Harinath <rharinath@novell.com>
12372 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12373 InstanceExpression.
12374 (PropertyExpr.EmitCall): Likewise.
12375 * expression.cs (Invocation.EmitArguments): Handle case where
12377 (Invocation.EmitCall): Avoid allocating temporary variable if
12378 there are no arguments.
12380 2005-10-07 Raja R Harinath <rharinath@novell.com>
12383 * convert.cs (ImplicitConversionStandard): Move conversion of
12384 void* to arbitrary pointer types ...
12385 (ExplicitConversionStandard): .. here.
12386 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12387 error to always print typenames.
12389 2005-10-07 Raja R Harinath <rharinath@novell.com>
12391 * convert.cs (GetConversionOperator): Rename from
12392 GetConversionOperators. Move operator selection code from ...
12393 (UserDefinedConversion): ... here.
12395 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12397 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12400 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12402 * assign.cs (Assign.DoResolve): Error method changed.
12404 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12406 * const.cs (ResolveValue): Reset in_transit immediately.
12408 * constant.cs: Error method changed.
12410 * convert.cs: Removed useless location parameter.
12411 (ExplicitNumericConversion): Don't do double enum check.
12412 (ExplicitConversionCore): Renamed from ExplicitConversion.
12413 (ExplicitUnsafe): Extracted from ExplicitConversion.
12414 (ExplicitConversion): Uses for error reporting.
12416 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12418 (ResolveBoolean): Uses common error method.
12419 (CastToDecimal): Get rid of ec.
12420 (CastFromDecimal): Optimized.
12421 (ConvCast): Get rid of ec.
12423 * enum.cs (ResolveValue): Reset in_transit immediately.
12424 (Emit): Return after first error.
12426 * expression.cs: Convert changes.
12428 * literal.cs: Error method changed.
12430 * statement.cs: Error method changed.
12432 2005-10-03 Raja R Harinath <rharinath@novell.com>
12434 * support.cs (SeekableStreamReader.Position): Don't error out when
12435 the requested position is just beyond the end of the current
12438 2005-09-28 Raja R Harinath <rharinath@novell.com>
12440 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12441 try to keep in sync with the byte count of the underlying Stream.
12442 However, this limits us to a window size of 2048 characters: i.e.,
12443 the maximum lookahead of our lexer/parser can be 2048 characters.
12445 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12448 * driver.cs: Fix compilation files with full root path.
12450 2005-09-25 Miguel de Icaza <miguel@novell.com>
12452 * report.cs (SymbolRelatedToPreviousError): Format the output so
12453 it does not use an open parenthesis that is never closed.
12455 * driver.cs: Follow coding guidelines
12457 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12460 * const.cs (Const.ResolveValue): Check for assigning non-null
12461 value to reference type.
12463 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12465 * anonymous.cs: Implemented ExprClassName.
12467 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12470 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12473 * class.cs (StaticClass.DefineContainerMembers): Report protected
12476 * codegen.cs: if(ed) PRODUCTION.
12478 * convert.cs (Error_CannotImplicitConversion): Better error
12481 * cs-parser.jay: More error checks.
12483 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12485 * driver.cs (CSCParseOption): Enabled wrong option check.
12487 * ecore.cs (Expression.ExprClassName): Turned to property.
12488 (MemberExpr.CheckIntermediateModification): For checking boxed
12489 value types modification.
12491 * statement.cs (Fixed.Resolve): Expression type must be
12492 convertible to fixed type.
12493 (CollectionForeach.GetEnumeratorFilter,TryType):
12494 Small refactoring for easier error checking.
12496 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12498 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12501 * class.cs (GeneratedBaseInitializer): New class for customization
12502 compiler generated initializers.
12503 (MemberBase.DoDefine): Check Obsolete attribute here.
12504 (FieldMember.DoDefine): Ditto.
12506 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12509 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12510 (MemberCore.GetObsoleteAttribute): Removed argument.
12511 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12512 (MemberCore.CheckObsoleteType): New helper.
12516 * statement.cs: Updates after MemberCore changes.
12518 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12519 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12521 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12522 obsolete attribute for compiler construct.
12523 (As.DoResolve): Cache result.
12525 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12527 2005-09-26 Raja R Harinath <rharinath@novell.com>
12530 * expression.cs (This.VerifyFixed): In a value type T, the type of
12531 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12532 value type R, 'this' is treated as a value parameter.
12534 2005-09-22 Miguel de Icaza <miguel@novell.com>
12536 * statement.cs (Lock): Use the TemporaryVariable class instead of
12537 manually using local variables as those do not work when variables
12540 * ecore.cs: Moved the TemporaryVariable class from being a nested
12541 class inside Foreach to be a public class that can be employed in
12544 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12546 * cs-parser.jay: interface_accessors replaced by
12547 accessor_declarations.
12549 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12552 * statement.cs (GotoCase.Resolve): Convert null constant to
12554 (SwitchLabel.ResolveAndReduce): Ditto.
12555 (SwitchLabel.NullStringCase): Custom null stamp.
12556 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12558 typemanager.cs (CSharpSignature): Don't skip first argument
12561 2005-09-18 Miguel de Icaza <miguel@novell.com>
12563 * driver.cs: Set InEmacs based on the environment variable EMACS.
12565 * location.cs (InEmacs): in this mode, do not report column
12566 location as it confuses Emacs.
12568 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12570 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12571 expression.cs, iterators.cs, literal.cs: Store constants and
12574 * class.cs (MemberBase.ShortName): Pass location.
12576 * cs-parser.jay: Some location fixes.
12578 * ecore.cs (Expression.Location): Made virtual.
12580 2005-09-05 Miguel de Icaza <miguel@novell.com>
12582 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12583 if the underlying types are the same, otherwise we need to produce
12584 code that will do the proper cast.
12586 This was exposed by Marek's constant rewrite which produced
12587 invalid code for the call site:
12589 enum X : long { a }
12590 void Method (X v) {}
12594 This fixes test-49.cs
12596 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12598 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12599 Type/Object should be allowed as well. Fixed bug #75968.
12601 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12603 * expression.cs : (Binary.DoResolve): when one is enum constant and
12604 another is constant 0, then return enum one *as enum type*.
12607 2005-09-02 Raja R Harinath <rharinath@novell.com>
12609 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12613 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12614 flow-branching for LocalVariableReferences in case we were invoked
12615 from a MemberAccess.
12616 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12618 (LocalVariableReference.DoResolveBase): ... this.
12619 (MemberAccess.Resolve): Do the check that was disabled during
12622 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12625 (PartialContainer.Create): check abstract/sealed/static strictly
12626 but abstract/sealed can exist only at one side. Fixed bug #75883.
12628 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12631 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12632 specified, don't default to UnmanagedType.I4.
12634 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12636 * expression.cs : conditional operator should check possibly
12637 incorrect assign expression. Fixed bug #75946.
12639 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12641 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12642 Reverting the change. gmcs is much complex than mcs on this matter.
12644 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12646 * cs-tokenizer.cs : To read another token ahead of the actual
12647 consumption, use new SavedToken and cache token instead of moving
12648 back the stream with SeekableStreamReader (it seemed problematic).
12650 driver.cs : Thus use StreamReader directly.
12651 * support.cs : Thus removed SeekableStreamReader.
12653 2005-08-30 Raja R Harinath <rharinath@novell.com>
12656 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12657 (ScopeInfo.EmitScopeType): Use it to construct field names from
12658 names of captured locals.
12661 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12662 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12663 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12664 (ExplicitConversion): Remove enum cases already handled by
12665 implicit conversion. Move implicit conversion check to the beginning.
12666 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12667 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12668 Don't treat System.Enum as a struct.
12670 2005-08-30 Jb Evain <jbevain@gmail.com>
12672 * attribute.cs: handles as expression in parameters.
12674 2005-08-30 Raja R Harinath <rharinath@novell.com>
12677 * class.cs (TypeContainer.VerifyClsName): Don't use a
12678 PartialContainer when verifying CLS compliance.
12679 (AbstractPropertyEventMethod): Set Parent here, ...
12680 (PropertyMethod): ... not here.
12682 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12684 * attribute.cs : escaped attribute name should not be allowed to be
12685 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12687 2005-08-29 Raja R Harinath <rharinath@novell.com>
12690 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12691 when converting a long constant to unsigned long.
12692 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12693 detect where IsApplicable and VerifyArgumentsCompat disagree.
12695 2005-08-29 Raja R Harinath <rharinath@novell.com>
12696 and Carlos Alberto Cortez <carlos@unixmexico.org>
12699 * class.cs (TypeContainer.CanElideInitializer): New helper.
12700 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12701 can safely emitting the initializer of a field.
12703 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12705 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12706 allowed inside a switch (without loop). Fixed bug #75433.
12708 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12710 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12711 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12713 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12715 * driver.cs : kinda reverting the default encoding changes (not exact
12716 revert since I noticed that "codepage:reset" might not work fine).
12718 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12720 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12721 Location. Now getter and setter store location correctly.
12722 (errors/cs0111-12.cs now reports the expected location.)
12724 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12726 * driver.cs : Use default encoding on the environment.
12727 Removed (now that) extra parameter for SeekableStreamReader.
12728 * support.cs : (SeekableStreamReader) third .ctor() argument for
12729 StreamReader is not required (always true). preamble size could
12730 be acquired in simpler and safe way.
12732 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12734 * cs-parser.jay: report CS0642 at warning level 3
12735 and report CS0642 for an if else statement also
12736 fixes bug #74745. Patch by John Luke (and a bit
12738 Removed extra CS0642 warning check for "while",
12740 * statement.cs: In Block.Resolve(), CS0642 check
12741 is reimplemented to check a sequence of an empty
12742 statement and a block.
12744 Both fix bug #66777.
12746 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12748 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12749 detection until I fix it.
12751 * cs-tokenizer.cs: Changed error message.
12753 * cs-parser.jay: Fixed 2 error locations.
12755 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12756 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12759 * enum.cs (GetSignatureForError): Fixed.
12761 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12765 * typemanager.cs (RegisterProperty): Removed.
12767 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12769 2005-08-24 Raja R Harinath <rharinath@novell.com>
12772 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12773 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12775 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12777 * expression.cs : tiny fix is required for not warning positive ulong.
12780 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12782 * expression.cs : add CS0652 check for constant and integral
12783 expression. Fixed bug #53974.
12785 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12787 * expression.cs : in DoNumericPromotions(), check if there is implicit
12788 conversion overload for string (to check CS0034). Fixed bug #52492.
12790 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12792 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12794 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12796 * ecore.cs : report location when it is *not* Null.
12798 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12804 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12805 correctly. Fixed bug #75721.
12807 2005-08-23 Raja R Harinath <rharinath@novell.com>
12809 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12810 loop that performs 'min (pos, char_count)'.
12813 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12814 converted value in Operator.OnesComplement.
12816 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12818 * anonymous.cs: If the anon method is pulled into a helper class,
12819 it needs to be `internal' not `private'. Fixes runtime behavior on
12822 2005-08-20 Martin Baulig <martin@ximian.com>
12824 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12825 scope if we don't already have it.
12827 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12828 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12831 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12834 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12835 is a partial class.
12837 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12839 The big constants rewrite
12840 Fix #75746, #75685 and more
12841 As a side effect saved 1MB for MWF ;-)
12843 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12844 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12845 enum based for corlib compilation.
12847 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12850 * class.cs (FixedField.Define): Use ResolveAsConstant.
12852 * const.cs (IConstant): Interface constants and enums.
12853 (Const.ResolveValue): New method for constant resolvning.
12854 (ExternalConstant): Constants from imported assemblies.
12856 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12857 conversion; like enums.
12858 (Constant.ToType): Converts this constant to different type.
12859 (Constant.Increment): Adds 1.
12861 * convert.cs (ImplicitConversionRequired): Simplified.
12863 * cs-parser.jay: Create EnumMember directly.
12865 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12867 * doc.cs (GenerateEnumDocComment): Removed.
12869 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12870 (ConvertIntLiteral): Removed.
12871 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12873 * enum.cs (EnumMember): Implement IConstant.
12874 (Enum.IsValidEnumConstant): Removed.
12875 (Enum.GetNextDefaultValue): Removed.
12876 (Enum.FindMembers): Updated.
12877 (Enum.GenerateDocComment): Iterate enum members.
12879 * expression.cs (Cast.TryReduce): Handle enums correctly.
12880 (New.Constantify): Made public.
12881 (MemberAccess.DoResolve): Removed contant specific if(s).
12883 * literal.cs (NullLiteral): Implement new abstract methods.
12885 * statement.cs (GotoCase.Resolve): Use new constant methods.
12886 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12888 * typemanager.cs (LookupEnum): Removed.
12889 (IsEnumType): Fixed to work with corlib.
12890 (RegisterConstant): Removed.
12891 (LookupConstant): Removed.
12892 (GetConstant): Changed to work with IConstant.
12894 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12896 * location.cs : Fixed overflown (>255) column number.
12898 2005-08-03 Raja R Harinath <rharinath@novell.com>
12900 First cut of the qualified-alias-member feature.
12901 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12903 * cs-parser.jay (DOUBLE_COLON): New token.
12904 (namespace_or_type_name): Add rule for recognizing
12905 qualified-alias-members.
12906 (primary_expression): Likewise.
12907 (element_access): Allow QualifiedAliasMember as a possible
12908 type-bearing expression.
12909 (local_variable_type, local_variable_pointer_type): Likewise.
12910 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12911 aliases in the current and enclosing namespace declarations.
12912 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12913 * decl.cs (MemberName.is_double_colon): New.
12914 (MemberName.MemberName): Add new constructor for alias-member.
12915 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12916 * expression.cs (QualifiedAliasMember): New expression type.
12918 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12920 * location.cs : it borked when no argument was specified.
12922 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12924 * location.cs : tiny ToString() format fix.
12926 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12928 * statement.cs : oops, it was missing.
12930 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12932 A set of fixes for precise line/column location.
12935 "token" field now holds a file/line "delta", a line number offset
12936 from the segment, and a column number. See also:
12937 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12938 December/009508.html
12939 Removed static IsNull. Use instance IsNull property instead.
12940 * cs-tokenizer.cs :
12941 For some tokens it stores Location. For Identifier it stores
12942 LocatedToken which is a pair of string name and location.
12943 Column numbers are adjusted only at getChar().
12945 Use Location.ToString() for reporting (it now contains column).
12947 Largely modified to use LocatedToken instead of
12948 string (IDENTIFIER), and to acquire Location from some tokens.
12949 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12950 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12952 Now MemberName holds Location. DeclSpace.ctor() receives Location
12953 as a parameter. Removed extra parameters to all derived classes.
12954 Replaced Location.IsNull() with instance property.
12955 * assign.cs, expression.cs :
12956 Added .ctor() overload that omits Location.
12958 Added "nameEscaped" flag that indicates the identifier was escaped
12959 in the source file. This fixes bug #57047.
12961 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12963 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12964 New method, looking for lo-case imported cls type.
12966 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12969 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12971 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12973 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12974 all_imported_types.
12975 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12977 Optimized to save 3.5 MB for SWF compilation.
12979 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12981 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12982 (PartialContainer.Create): Moved logic AddToContainer.
12983 (PartialContainer.MarkForDuplicationCheck): Shares name.
12985 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12988 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12990 (Namespace.GetSignatureForError): New method.
12992 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12993 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12995 2005-08-01 Raja R Harinath <rharinath@novell.com>
12998 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12999 member lookup rather than qualifier_type, since qualifier_type can
13002 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13004 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
13007 2005-07-31 Miguel de Icaza <miguel@novell.com>
13009 * statement.cs: Copy the local exception into the exception
13010 captured local. Fixes 75674
13012 2005-07-31 Raja R Harinath <harinath@gmail.com>
13015 * expression.cs (Invocation.OverloadResolve): Don't report error
13016 CS1501 if error CS1502 has been reported.
13017 (New.DoResolve): Delegate CS1501 reporting to
13018 Invocation.OverloadResolve.
13021 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
13022 invariant-meaning-in-block property in an enclosing block if
13025 2005-07-29 Marek Safar <marek.safar@seznam.cz>
13027 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
13028 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
13029 (Switch.CheckSwitch): Just save 50kb for SWF.
13031 2005-07-27 Martin Baulig <martin@ximian.com>
13033 * anonymous.cs (CaptureContext.AddField): Added
13034 `AnonymousContainer am' argument; compute its toplevel scope if
13035 it's not already computed. Fixes #75649.
13037 2005-07-26 Raja R Harinath <rharinath@novell.com>
13040 * class.cs (Constructor.Emit): Reset block to null if the block
13043 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13045 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
13047 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13049 * class.cs (MethodData.Define): Check whether accessor implementing
13050 interface is public.
13052 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
13054 2005-07-22 Marek Safar <marek.safar@seznam.cz>
13057 * namespace.cs (LookupType): Moved same type check to...
13059 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
13060 with the same name.
13062 2005-07-21 Raja R Harinath <rharinath@novell.com>
13064 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
13065 already found a typebuilder.
13066 * class.cs (MethodCore.IsDuplicateImplementation): Compare
13067 MemberNames, not strings.
13069 * const.cs (Error_ExpressionMustBeConst):
13070 Rename from Error_EpressionMustBeConst.
13071 * const.cs, class.cs, statement.cd: Update.
13073 2005-07-21 Marek Safar <marek.safar@seznam.cz>
13077 * const.cs (Const.LookupConstantValue): Report missing contant expression
13079 (Error_EpressionMustBeConstant): Only one error method.
13081 * class.cs, statement.c: Updated.
13083 2005-07-20 Raja R Harinath <rharinath@novell.com>
13085 * statement.cs (Block.Flags): Add back HasVarargs.
13086 (Block.flags): Make protected.
13087 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
13089 * typemanager.cs (types, typecontainers, user_types): Remove.
13090 (UserTypes, TypeContainers): Likewise.
13091 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
13092 (CleanUp, Reset): Update.
13093 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
13094 (GetNestedType): Use Type.GetNestedType.
13095 (CoreLookupType): Take two arguments, the namespace and the
13096 basename of the type. Update to use the Namespace.Lookup
13098 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
13099 (RealMemberLookup): Use IsNestedChildOf instead of playing with
13100 string concatenation and substring matches.
13101 * class.cs, enum.cs, delegate.cs: Update to changes.
13103 2005-07-20 Marek Safar <marek.safar@seznam.cz>
13105 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
13106 Expression and made virtual.
13108 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
13109 (ImplicitStandardConversionExists): Fixed `byte' typo ?
13111 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
13113 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
13116 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
13119 2005-07-18 Marek Safar <marek.safar@seznam.cz>
13122 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
13123 AssemblyCultureAttribute is not used on executable.
13126 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
13128 2005-07-16 Raja R Harinath <rharinath@novell.com>
13131 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
13132 New. Reports CS0252/CS0253.
13133 Mostly taken from preliminary patch by Duncak Mak.
13134 (Binary.DoResolveOperator): Store results of operator lookup.
13135 Use them to detect if we need to warn about unintended reference
13138 2005-07-15 Raja R Harinath <rharinath@novell.com>
13141 * namespace.cs (Namespace.Lookup): Add back location parameter.
13142 (Namespace.LookupType): Add CS0436 report. Add location parameter.
13143 * delegate.cs, ecore.cs, expression.cs: Update to changes.
13145 * codegen.cs (EmitContext.DeclSpace): Make readonly.
13146 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
13147 (Namespace.LookupType): ... this.
13148 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
13150 * typemanager.cs (LookupTypeReflection): Remove buggy code that
13151 purported to handle pointers.
13152 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
13155 2005-07-15 Marek Safar <marek.safar@seznam.cz>
13157 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
13160 2005-07-15 Raja R Harinath <rharinath@novell.com>
13162 * namespace.cs (Namespace.Lookup): Drop location parameter.
13163 (NamespaceEntry.LookupAlias): Remove. Merge into ...
13164 (NamespaceEntry.Lookup): ... this.
13165 (NamespaceEntry.Error_AmbiguousTypeReference):
13166 Move here from DeclSpace.
13167 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
13169 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
13170 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
13171 Move to NamespaceEntry.
13172 * delegate.cs, expression.cs: Update to changes.
13174 2005-07-14 Marek Safar <marek.safar@seznam.cz>
13176 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
13177 CheckAttributeType and refactored.
13178 (Attribute.ResolvePossibleAttributeType): Changed to reuse
13179 ResolveAsTypeTerminal error handling.
13180 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13182 (GetSignatureForError): Print errors in same way.
13185 * codegen.cs: Reflect attribute GetSignatureForError change.
13188 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13190 * namespace.cs (UsingEntry): Refactored to make fields private.
13193 statement.cs: Error_UnexpectedKind has extra parameter.
13195 2005-07-14 Raja R Harinath <rharinath@novell.com>
13197 * ecore.cs (IAlias): Remove.
13198 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13199 that implement the interface.
13200 * namespace.cs (Namespace): Likewise.
13201 (Namespace.declspaces): Renamed from 'defined_names'.
13202 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13203 DeclSpace instead of an IAlias.
13204 * tree.cs (Tree.AddDecl): Update.
13206 2005-07-12 Raja R Harinath <rharinath@novell.com>
13208 * statement.cs (Block.Flags); Remove HasVarargs.
13209 (Block.HasVarargs): Move to ToplevelBlock.
13210 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13211 (Block.Variables): Make protected. Initialize variable hashtable
13213 (Block.AddVariable): Update.
13214 (Block.Resolve): Update to changes.
13215 (ToplevelBlock.HasVarargs): New boolean.
13216 (ToplevelBlock.ThisVariable): Move here from Block.
13217 (ToplevelBlock.AddThisVariable): Likewise.
13218 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13219 * expression.cs (This.ResolveBase): Update to changes.
13220 (ArglistAccess.DoResolve): Likewise.
13222 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13225 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13227 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13228 not used and not used & assigned.
13229 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13231 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13234 * expression.cs (Is.DoResolve): null is never provided type.
13236 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13239 * cs-parser.jay: Less strict event error rule to catch more errors.
13241 2005-07-08 Martin Baulig <martin@ximian.com>
13243 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13244 gettter (allowed) or setter (not allowed).
13246 * class.cs (Accessor): Implement IIteratorContainer.
13247 (Accessor.Yields): New public field.
13248 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13249 per-accessor basis.
13252 (get_accessor_declaration, set_accessor_declaration): Set the
13253 `yields' flag on the accessor, not the property.
13254 (property_declaration): Do the iterators check on a per-accessor
13255 basis and not for the whole property.
13257 2005-07-08 Martin Baulig <martin@ximian.com>
13259 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13260 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13262 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13265 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13266 (ExtractSecurityPermissionSet): Cope with self referencing security
13267 attributes properly.
13269 * driver.cs (SetOutputFile): Made public property OutputFile.
13271 2005-07-07 Raja R Harinath <rharinath@novell.com>
13274 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13275 has_nonstatic_fields. Make into a FieldBase pointer.
13276 (TypeContainer.AddField): Add CS0282 check.
13277 (TypeContainer.EmitType): Update.
13279 2005-07-06 Miguel de Icaza <miguel@novell.com>
13281 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13282 compare if they start with __.
13284 2005-07-06 Raja R Harinath <rharinath@novell.com>
13286 * statement.cs (Switch.SwitchGoverningType): Only look at
13287 UserCasts that don't need implicit standard conversions to one of
13288 the allowed switch types (Fixes test-322.cs).
13289 (LocalInfo.Resolve): Re-enable sanity-test.
13291 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13293 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13295 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13297 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13299 2005-07-06 Raja R Harinath <rharinath@novell.com>
13302 * ecore.cs (SimpleName.GetSignatureForError): Add.
13303 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13304 (MemberAccess.GetSignatureForError): Add.
13306 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13308 The big error and warning messages review.
13338 * typemanager.cs: Updated.
13340 * class.cs: (MethodCore.SetYields): Moved here to share.
13341 (PropertyMethod.Define): Moved iterator setup here.
13343 * iterators.cs: Add orig_method to have full access to parent
13346 2005-07-05 Raja R Harinath <rharinath@novell.com>
13348 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13349 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13350 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13351 variable of struct type.
13352 * expression.cs (Unary.ResolveOperator): Update to change.
13353 (Indirection.VerifyFixed): Likewise.
13354 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13355 (ParameterReference.VerifyFixed): Value parameters are fixed.
13356 (This.VerifyFixed): Treat 'this' as a value parameter.
13357 * statement.cs (LocalInfo.IsFixed): Remove.
13359 2005-07-01 Martin Baulig <martin@ximian.com>
13361 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13362 `ec.EmitThis ()' to get the correct scope.
13364 2005-07-01 Martin Baulig <martin@ximian.com>
13366 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13367 instance is a ParameterReference; fixes #75299.
13369 2005-07-01 Martin Baulig <martin@ximian.com>
13371 Reverted Marek's latest patch (r46725):
13372 - it contains structural changes which are neither mentioned in
13373 the ChangeLog nor explained anywhere; for example the additional
13374 argument of EmitContext's and Iterator's .ctor's and the
13375 TypeContainer.DefineMembers() change.
13376 - structural changes like this should go in in seperate patches
13377 and not be hidden in a huge patch which just seems to affect
13378 warnings and errors.
13379 a big and hard to understand patch.
13380 - it breaks iterators and causes regressions, for instance in
13383 2005-06-30 Raja R Harinath <rharinath@novell.com>
13386 * expression.cs (Indexers.map): Remove.
13387 (Indexers.Append): Filter out inaccessible setters and getters.
13388 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13391 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13392 Refactored from ...
13393 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13394 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13395 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13396 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13398 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13401 * class.cs (FieldBase.GetInitializerExpression): One more field
13404 2005-06-28 Miguel de Icaza <miguel@novell.com>
13406 * pending.cs: Do not define a proxy if the base method is virtual,
13407 it will be picked up by the runtime (bug 75270).
13409 2005-06-08 Martin Baulig <martin@ximian.com>
13411 The big Iterators rewrite :-)
13413 * iterators.cs: Rewrite this to use the anonymous methods framework.
13415 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13416 before the TypeContainers; see 2test-21.cs.
13419 (TypeContainer.DefineType): Don't create a new EmitContext if we
13420 already have one (this only happens if we're an Iterator).
13421 (TypeContainer.Define): Also call Define() on all our iterators.
13422 (Method.CreateEmitContext): Added support for iterators.
13425 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13426 (AnonymousContainer.CreateMethodHost): Moved here from
13427 AnonymousMethod and made abstract.
13428 (AnonymousContainer.CreateScopeType): New abstract method.
13429 (AnonymousContainer.IsIterator): New public property.
13430 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13431 get the ScopeTypeBuilder rather than manually defining it here.
13432 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13435 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13436 before RootContext.DefineTypes().
13438 * codegen.cs (EmitContext.RemapToProxy): Removed.
13439 (EmitContext.CurrentAnonymousMethod): Changed type from
13440 AnonymousMethod -> AnonymousContainer.
13441 (EmitContext.ResolveTopBlock): Protect from being called twice.
13442 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13443 (EmitContext.EmitThis): Removed the iterators hacks; use the
13444 anonymous methods framework for that.
13447 (ToplevelBlock.Container): Make this a property, not a field.
13448 (ToplevelBlock.ReParent): New public method; move the
13449 ToplevelBlock into a new container.
13450 (Foreach.TemporaryVariable): Simplify.
13452 2005-06-05 Martin Baulig <martin@ximian.com>
13454 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13455 (Block.AddTemporaryVariable): New public method; creates a new
13456 `LocalInfo' for a temporary variable.
13457 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13459 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13460 non-iterator variables.
13462 2005-06-05 Martin Baulig <martin@ximian.com>
13464 * statement.cs (Foreach.TemporaryVariable): Create the
13465 LocalBuilder in the Emit phase and not in Resolve since in some
13466 situations, we don't have an ILGenerator during Resolve; see
13467 2test-19.cs for an example.
13469 2005-06-04 Martin Baulig <martin@ximian.com>
13471 **** Merged r45395 from GCS ****
13473 The big Foreach rewrite - Part II.
13475 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13476 with `PropertyInfo ienumerator_getcurrent'.
13478 * codegen.cs (VariableStorage): Removed.
13481 (Foreach): Derive from Statement, not ExceptionStatement.
13482 (Foreach.CollectionForeach): New nested class. Moved all the code
13483 dealing with collection foreach here.
13484 (Foreach.ForeachHelperMethods): Removed.
13485 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13487 2005-05-23 Martin Baulig <martin@ximian.com>
13489 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13490 don't need to. Fix #75014.
13492 2005-05-20 Martin Baulig <martin@ximian.com>
13494 Merged r44808 from GMCS.
13496 * class.cs (TypeContainer.CircularDepException): Removed.
13497 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13498 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13499 (CS0146) and interface (CS0529) dependencies here.
13501 2005-06-21 Raja R Harinath <rharinath@novell.com>
13503 * expression.cs (Invocation.EmitCall): Fix initialization
13504 'this_call' to reflect current behaviour. Fix indentation.
13506 * convert.cs (FindMostEncompassedType): Add two trivial special
13507 cases (number_of_types == 0 || number_of_types == 1).
13508 (FindMostEncompasingType): Likewise.
13510 2005-06-17 Raja R Harinath <rharinath@novell.com>
13512 Some cleanups preparing for the fix of #75283.
13513 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13515 (EventExpr.InstanceResolve): Likewise.
13516 (EventExpr.DoResolve): Remove redundant checks.
13518 2005-06-10 Duncan Mak <duncan@novell.com>
13520 * cs-tokenizer.cs (process_directives): New flag for controlling
13521 the processing of preprocessor directives.
13522 (x_token): After seeing a '#', return Token.NONE instead of going
13523 to handle_preprocessing_directive() when not processing
13524 directives. This avoids unnecessary processing during the token peek in
13529 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13530 the existing error reporting methods instead of Report.Error.
13532 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13533 after Raja's rewrite.
13535 2005-06-08 Miguel de Icaza <miguel@novell.com>
13537 * class.cs: Small fix.
13539 2005-06-08 Raja R Harinath <rharinath@novell.com>
13542 * class.cs (GetPartialBases): Fix return value check of
13543 part.GetClassBases.
13545 2005-06-07 Raja R Harinath <rharinath@novell.com>
13547 Ensure that partial classes are registered in their enclosing
13548 namespace. Initial part of fix of #75160.
13549 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13550 Register declspace with namespace here, not in
13551 DeclSpace.RecordDecl.
13552 * cs-parser.jay: Pass namespace to RecordDecl.
13553 * class.cs (PartialContainer.Create): Likewise.
13554 (ClassPart.DefineType): New sanity-check. Throws an exception if
13556 * decl.cs (Declspace.RecordDecl): Remove.
13557 * namespace.cs (NamespaceEntry.DefineName): Remove.
13559 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13561 * rootcontext.cs: Reset TargetExt as well.
13563 2005-06-03 Raja R Harinath <rharinath@novell.com>
13565 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13566 -langversion:ISO-1.
13568 2005-06-02 Raja R Harinath <rharinath@novell.com>
13570 Fix #75080, cs0119.cs.
13571 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13573 (Expression.Resolve): ... this. Use it. Remove bogus code
13574 allowing ExprClass.Type and ExprClass.Namespace for
13575 ResolveFlags.VariableOrValue.
13576 (Expression.Resolve) [1-argument variant]: Change default resolve
13577 flags based on language version.
13578 (Expression.Error_UnexpectedKind): Use a simple string array
13579 rather than an ArrayList.
13580 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13581 not ExprClass.Type.
13582 (TypeOfVoid.DoResolve): Likewise.
13583 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13584 flags argument -- it always has the same value.
13586 2005-05-31 Raja R Harinath <rharinath@novell.com>
13589 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13590 Use it in the error message.
13591 * assign.cs, expression.cs, statement.cs: Update.
13593 2005-05-30 Raja R Harinath <rharinath@novell.com>
13596 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13597 the "almostMatchedMember" case too.
13598 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13599 that failed the accessibility checks to 'almost_match'.
13601 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13603 * attribute.cs: Use internal MethodBuilder methods to set
13604 ExactSpelling and SetLastError on PInvoke methods, instead
13605 of passing them via charset. Fixes #75060.
13607 2005-05-27 Raja R Harinath <rharinath@novell.com>
13609 * parameter.cs (Parameter): Remove TODO comment.
13610 (Parameter.DefineParameter): Remove Location parameter.
13611 (Parameters.LabelParameters): Likewise.
13612 * class.cs (Constructor.Emit): Update to change.
13613 (MethodData.Emit): Likewise.
13614 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13615 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13617 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13620 Removed Parameters.Location and added Parameter.Location instead.
13621 Removed Location parameter from Emit() and GetSignature().
13628 Modified all related calls.
13630 2005-05-26 Raja R Harinath <rharinath@novell.com>
13632 Improve user-defined conversion handling.
13633 * convert.cs (GetConversionOperators): Rewrite. Return only the
13634 applicable operators.
13635 (AddConversionOperators): New. Helper for GetConversionOperators.
13636 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13637 there is only one most encompassed/encompassing type.
13638 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13639 "applicable operator" handling.
13640 (UserConversion): Move cache here from GetConversionOperators.
13641 Directly cache the chosen operator, rather than the whole
13643 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13644 case. Allow conversion of decimal to sbyte and byte too.
13645 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13646 New static methods. Used to avoid allocating EmptyExpressions in
13649 2005-05-24 Duncan Mak <duncan@novell.com>
13651 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13652 another class, used in Convert.ExplicitNumericConversion.
13653 (CastToDecimal): New class, similar to above, but casts to
13654 System.Decimal, used in Convert.ImplicitNumericConversion and also
13655 in explicit convesion from double/float to decimal.
13657 * convert.cs (ImplicitNumericConversion): Handle implicit
13658 conversions to System.Decimal.
13659 (ExplicitNumericConversion): handle explicit conversions to
13664 2005-05-20 Miguel de Icaza <miguel@novell.com>
13666 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13667 know the type at this stage, just break through. Fixes #75008
13669 2005-05-19 Martin Baulig <martin@ximian.com>
13672 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13673 to disable error reporting.
13675 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13676 here since we don't want to report an error; see the new test-336.cs.
13678 2005-05-19 Raja R Harinath <rharinath@novell.com>
13680 * statement.cs (ToplevelBlock.GetParameterReference)
13681 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13682 Move here from class Block.
13683 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13684 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13686 2005-05-18 Martin Baulig <martin@ximian.com>
13691 (FlowBranching.Reachability): Add non-static public And() and Or()
13693 (FlowBranchingSwitch): New class; do the `break_origins' thing
13694 like in FlowBranchingLoop.
13695 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13696 reachability, not just locals and parameters.
13697 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13698 switch; MergeBreakOrigins() now takes care of that.
13700 2005-05-18 Martin Baulig <martin@ximian.com>
13702 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13703 a loop and may leave it, reset the barrier; fixes #74974.
13705 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13707 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13710 * cs-parser.jay: Catch more lexical errors.
13712 * report.cs: Add one more Error method.
13715 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13717 2005-05-17 Martin Baulig <martin@ximian.com>
13719 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13722 2005-05-16 Raja R Harinath <rharinath@novell.com>
13724 Fix test-382.cs. Emit values of decimal constants.
13725 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13727 (TypeContainer.AddField): ... this.
13728 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13729 with initializers to include 'Const's.
13730 (ClassPart.RegisterFieldForInitialization): Forward to
13732 * const.cs (Const.Const): Pass initializer to base class.
13733 (Const.Define): In case of decimal constants, register them for
13734 initialization in a static constructor.
13736 2005-05-14 Martin Baulig <martin@ximian.com>
13738 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13739 do not call ResolveUnreachable() on unreachable statements in
13740 here, see the comment in the source code.
13742 2005-05-13 Raja R Harinath <rharinath@novell.com>
13745 * expression.cs (BinaryResolveOperator): If one of the operands of
13746 an equality comparison is 'null' and the other is a pointer type,
13747 convert the null to a NullPointer.
13748 * convert.cs (ImplicitReferenceConversion): If the expression is a
13749 NullLiteral and the target type is a pointer type, return a
13750 NullPointer instead.
13751 (ImplicitConversionStandard): Likewise.
13753 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13755 * cs-parser.jay: Set readonly context based on special constructs.
13757 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13758 readonly variable error handling.
13760 * rootcontext.cs (EmitCode): Don't verify members when error
13763 * statement.cs (LocalInfo): Add reaodnly context information.
13764 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13766 2005-05-13 Raja R Harinath <rharinath@novell.com>
13768 * statement.cs (Block.Resolve): Revert change below. Modify fix
13769 for #74041 to initialize 'resolved' to false only for explicit
13770 blocks. Fixes #74873.
13772 2005-05-12 Raja R Harinath <harinath@gmail.com>
13775 * typemanager.cs (unmanaged_enclosing_types): New.
13776 (IsUnmanagedType): Avoid infloops by using
13777 'unmanaged_enclosing_types' to talk with recursive invocations.
13779 2005-05-13 Martin Baulig <martin@ximian.com>
13781 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13782 instance variable, not a local. Fix #74873.
13783 (Block.ResolveUnreachable): Set it to true here.
13785 2005-05-11 Duncan Mak <duncan@novell.com>
13787 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13788 continuing to process for 'arg'.
13789 (handle_preprocessing_directive): Check the argument of the #endif
13790 directive and report error CS1025 if there are any trailing
13793 According to the C# spec, having even whitespace after the #endif
13794 directive is illegal; however, because we call arg.TrimEnd ()
13795 beforehand, we have the same behavior as csc, allowing whitespace
13796 after the directive.
13800 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13804 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13805 (Constructor.GetObsoleteAttribute): Implemented correctly.
13807 2005-05-10 Martin Baulig <martin@ximian.com>
13809 * support.cs (ReflectionParameters.ParameterModifier): Use
13810 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13811 and `ParameterAttributes.In'. Fixes #74884.
13813 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13815 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13817 * expression.cs (Argument.GetParameterModifier): Turned to property.
13818 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13820 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13823 2005-05-09 Raja R Harinath <rharinath@novell.com>
13826 * decl.cs (MemberCache.AddMethods): Register override methods,
13827 rather than non-override methods.
13828 * typemanager.cs (RegisterOverride): New.
13829 (IsOverride): Update.
13831 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13835 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13836 recursive declaration.
13838 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13840 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13842 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13844 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13846 2005-05-05 Raja R Harinath <rharinath@novell.com>
13849 * decl.cs (DeclSpace.FamilyAccessible):
13850 Use TypeManager.IsNestedFamilyAccessible.
13852 Fix reopened #64812.
13853 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13856 2005-05-04 Raja R Harinath <rharinath@novell.com>
13857 Abin Thomas <projectmonokochi@rediffmail.com>
13858 Anoob V E <projectmonokochi@rediffmail.com>
13859 Harilal P R <projectmonokochi@rediffmail.com>
13862 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13863 allow access to all static members.
13865 2005-05-04 Martin Baulig <martin@ximian.com>
13867 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13869 2005-05-04 Martin Baulig <martin@ximian.com>
13873 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13874 section at the end; make things work if `default' is not the last
13877 2005-05-04 Martin Baulig <martin@ximian.com>
13881 * statement.cs (Switch): Replaced the `got_default' field with a
13882 `default_section' one.
13883 (Switch.CheckSwitch): Set `default_section' here.
13884 (Switch.Resolve): If we're a constant switch and the constant is
13885 not found, use the default section.
13887 2005-05-03 Martin Baulig <martin@ximian.com>
13889 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13891 * statement.cs (Foreach.ArrayForeach): New nested class.
13892 (Foreach.TemporaryVariable): New nested class.
13893 (Foreach.EmitArrayForeach): Removed; this is now in the new
13894 ArrayForeach class.
13896 2005-05-03 Raja R Harinath <rharinath@novell.com>
13898 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13900 (VerifyPendingMethods): Revert change below.
13902 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13903 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13904 that used to trigger warning -28. Remove warning -28.
13905 * expression.cs (Invocation.OverloadResolve): Use
13906 TypeManager.IsOverride to distinguish override methods.
13909 * pending.cs (VerifyPendingMethods): If a base type implements the
13910 requested interface, don't bother checking individual methods of
13911 the base type. As a side-effect, this prevents the creation of
13912 unnecessary proxies.
13914 2005-05-02 Martin Baulig <martin@ximian.com>
13918 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13919 Also `And' the locals if the old vector is null.
13920 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13921 null; in this case we basically reset all the variables.
13923 2005-05-02 Martin Baulig <martin@ximian.com>
13927 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13928 Added `FlowBranching branching' argument; always `and' the
13929 variables instead of `or'ing them unless we're an infinite loop.
13931 * statement.cs (While.Resolve): Create a new sibling unless we're
13934 2005-05-02 Martin Baulig <martin@ximian.com>
13938 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13939 arguments; use it instead of creating a new TopLevelBlock.
13940 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13941 our ConstructorInitializer.
13944 (TopLevelBlock.TopLevelBranching): New public property.
13945 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13946 and create our `TopLevelBranching'.
13948 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13949 anonymous method host, use `block.TopLevelBranching' rather than
13950 creating a new branching.
13952 2005-04-20 Miguel de Icaza <miguel@novell.com>
13954 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13955 a ScopeInfo, if any of the current children is a child of the new
13956 entry, move those children there.
13958 2005-04-30 Martin Baulig <martin@ximian.com>
13960 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13961 at the beginning of a SwitchSection. Fix #73335.
13963 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13966 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13968 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13969 (FieldExpr.DoResolve): Obsolete members are ignored for field
13972 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13974 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13975 of arrays detection.
13977 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13979 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13981 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13984 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13986 * cs-parser.jay: Use the prefered version of -unsafe in error
13989 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13991 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13994 2005-04-20 John Luke <john.luke@gmail.com>
13996 * driver.cs: fix typo in error message, --outout to --output
13998 2005-04-20 Marek Safar <marek.safar@seznam.cz>
14000 * codegen.cs (InRefOutArgumentResolving): New field.
14002 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
14003 fields outside contructor.
14005 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
14007 2005-04-19 Miguel de Icaza <miguel@novell.com>
14009 * anonymous.cs (CaptureContext.EmitParameterInstance): The
14010 parameter code was not completed ever, so it was not as up-to-date
14011 as local variables. Must finish it.
14013 The bug fix was to compare the Toplevel of the block, not the
14014 current block. Thanks for Ben for pointing this out.
14016 2005-04-19 Raja R Harinath <rharinath@novell.com>
14018 * decl.cs (AddMethods): Use the declaring type of the problem
14019 method to determine if we want to squash a warning.
14021 2005-04-19 Marek Safar <marek.safar@seznam.cz>
14023 * attribute.cs: Removed debug output.
14025 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
14027 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
14030 2005-04-18 Raja R Harinath <rharinath@novell.com>
14033 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
14034 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
14035 all null comparisons against reference types.
14037 2005-04-18 Marek Safar <marek.safar@seznam.cz>
14040 * class.cs (TypeContainer.CircularDepException) New nested
14042 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
14043 (TypeContainer.DefineType): Removed error, reset InTransit before
14045 (Class.DefineType): Throw exception when is in Transit.
14046 Catch exception and report error.
14047 (Struct.DefineType): Throw exception when is in Transit.
14048 Catch exception and report error.
14049 (Interface.DefineType): Throw exception when is in Transit.
14050 Catch exception and report error.
14052 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
14053 handle nested exception handlers.
14055 * flowanalysis.cs (InTryWithCatch): New method, search for try with
14058 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
14059 InFinally and InCatch storage.
14061 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
14062 (Catch.Resolve): Set and Restore ec.InCatch.
14063 (Try.Resolve): Set and Restore ec.InFinally.
14064 (Try.HasCatch): True when try has catch.
14066 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
14068 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
14069 for the same event member, so exclude such cases from warning 419.
14072 2005-04-16 Miguel de Icaza <miguel@novell.com>
14074 * expression.cs (Binary.ResolveOperator): Apply patch from John
14075 Luke to fix bug 59864: operators &, | and ^ on enumerations
14076 require that the same enum type on both sides.
14078 * driver.cs: Add warnings to old flag usage, this is to assist
14079 people who produce Makefiles and hope that the Makefiles will be
14082 * class.cs (TypeContainer.EmitType): Moved the definition of the
14083 special $PRIVATE$ field from the resolve phase to the Emit phase.
14084 During resolve we do not know if we are a struct with
14085 HasExplicitLayout, we know this only after the attributes for the
14088 Set the FieldOffset to zero on the dummy field that we create for
14089 the class. Fixes 74590.
14091 2005-04-16 Raja R Harinath <rharinath@novell.com>
14094 * ecore.cs (PropertyExpr.resolved): New.
14095 (DoResolve): Use it to handle a case of double resolution here.
14096 Handle a case of identical-name-and-type-name.
14097 * expression.cs (ArrayCreation.CheckIndices): Avoid double
14098 resolution by storing the results of expression resolution back
14099 into the "probes" array.
14101 2005-04-15 Raja R Harinath <rharinath@novell.com>
14103 Fix cs0208-7.cs and cs0208-8.cs.
14104 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
14105 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
14106 error reporting to point out the reason a struct is not unmanaged.
14108 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14110 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
14111 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
14113 2005-04-13 Raja R Harinath <rharinath@novell.com>
14116 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
14117 IdenticalNameAndTypeName here.
14118 (EventExpr.InstanceResolve): Likewise.
14120 2005-04-13 Marek Safar <marek.safar@seznam.cz>
14122 C# 2.0 DefaultCharSetAttribute implementation
14124 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
14125 which allows us to set GlobalNamespace for every resolve.
14126 (Attribute.ResolveArguments): Cut from Resolve.
14127 (Attribute.GetCharSetValue): Returns CharSet named argument.
14128 (Attribute.DefinePInvokeMethod): Gets default charset from
14130 (GlobalAttribute.ResolveAsTypeStep): Override.
14131 (GlobalAttribute.ResolveArguments): Override.
14133 * class.cs (TypeAttr): Is protected.
14135 * codegen.cs (ModuleClass.DefaultCharSet): New member.
14136 (ModuleClass.DefaultCharSetType): New memeber.
14137 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
14139 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
14140 charset from module.
14142 * delegate.cs (TypeAttr): Override.
14143 (Delegate.DefineType): Use this TypeAttr.
14145 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
14146 at very early stage (before types are defined) to resolve model
14147 module attributes. It will probably not work with corlib but it
14150 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
14151 charset from module.
14153 * typemanager.cs (default_charset_type): New type.
14155 2005-04-13 Raja R Harinath <rharinath@novell.com>
14157 * decl.cs (MemberCache.AddMethods): Don't warn if
14158 System.Object.Finalize has buggy MethodAttributes.
14160 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
14163 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14165 * doc.cs : detect ambiguous reference to overloaded members.
14166 Fixed bug #71603. MS 1.1 csc does not detect it.
14168 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14170 * doc.cs : delegates must not be referenced with parameters.
14173 2005-04-12 Miguel de Icaza <miguel@novell.com>
14175 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
14177 2005-04-10 Miguel de Icaza <miguel@novell.com>
14179 * driver.cs (MainDriver): Stop processing if the CLS stage found
14182 (CompilerCallableEntryPoint.InvokeCompiler): Always
14183 reset after execution; Take a TextWriter argument for the
14186 * report.cs: Use the error stream instead of hardcoding stderr.
14188 2005-04-09 Miguel de Icaza <miguel@novell.com>
14190 * class.cs: Reduce code paths to test, too small of an
14191 optimization to make it worth the extra testing. Always perform
14194 2005-04-08 Raja R Harinath <rharinath@novell.com>
14197 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14198 operators that had errors reported on them.
14200 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14202 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14204 (Attribute.Resolve): Add named argument type checking.
14206 * class.cs (FixedField.Define): Use IsPrimitiveType
14208 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14210 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14211 unsafe parameter types.
14213 * statement.cs (Using.ResolveExpression): Add better error description.
14215 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14217 2005-04-08 Raja R Harinath <rharinath@novell.com>
14220 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14221 AttributeUsageAttribute in the emitcontext of the attribute class,
14222 not in the emitcontext of the attributable entity it was attached to.
14223 * cs-parser.jay: Use 'current_class', not 'current_container',
14224 when creating a GlobalAttribute.
14226 2005-04-08 Alp Toker <alp@atoker.com>
14228 * pending.cs: The fix to #58413 failed to compile methods implementing
14229 interfaces with/without params modifiers and vice versa, even though
14230 params modifiers aren't part of the signature. Make the modifier check
14231 less strict as in csc.
14233 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14234 Anoob V E <projectmonokochi@rediffmail.com>
14235 Harilal P R <projectmonokochi@rediffmail.com>
14238 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14239 modifiers of pending methods.
14240 (PendingImplementation.PendingImplementation): Initialize it.
14241 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14242 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14243 with ParameterData. Add check for modifiers.
14244 * class.cs (MethodData.Define): Update to changes.
14246 2005-04-07 Raja R Harinath <rharinath@novell.com>
14248 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14250 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14252 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14255 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14258 * typemanager.cs: Registered RequiredAttributeAttribute.
14260 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14262 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14263 Warning CS0169 is back at level 3.
14264 (IMethodData.SetMemberIsUsed): New method.
14266 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14267 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14269 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14271 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14273 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14276 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14279 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14280 to avoid the problems with nested types.
14282 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14283 Anoob V.E <projectmonokochi@rediffmail.com>
14284 Harilal P.R <projectmonokochi@rediffmail.com>
14285 Raja R Harinath <rharinath@novell.com>
14288 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14290 * typemanager (GetConstructor): Make public.
14292 2005-04-05 John Luke <john.luke@gmail.com>
14293 Raja R Harinath <rharinath@novell.com>
14296 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14297 struct too. Return false quicker in a few cases.
14298 (VerifyUnManaged): Use it.
14300 2005-04-05 Raja R Harinath <rharinath@novell.com>
14303 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14304 not 'unreachable_seen'.
14306 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14308 * attribute.cs (Attribute.GetValue): Removed unused.
14310 * codegen.cs (CodeGen.TrimExt): Removed unused.
14312 * cs-parser.jay (output): Removed unused.
14314 * cs-tokenizer.cs (hex_digits): Removed unused.
14316 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14318 * expression.cs (Indirection.LoadExprValue): Removed unused.
14319 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14321 * iterators.cs (Iterator.param_types): Removed unused.
14323 * statement.cs (Goto.block): Removed unused.
14324 (ToplevelBlock.did): Removed unused.
14325 (Switch.ResolveConstantSwitch): Removed unused.
14327 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14329 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14332 2005-04-01 Raja R Harinath <rharinath@novell.com>
14334 Fix #74232 and cs0208-3.cs.
14335 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14336 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14337 unmanaged type. Don't use FieldBuilders when 't' is a
14338 TypeBuilder. Use ModFlags and MemberType fields.
14339 * class.cs (MemberBase.member_type): Rename from MemberType.
14340 (MemberBase.MemberType): New property. Determines member_type on
14342 (MemberBase.DoDefine): Don't initialize MemberType here.
14343 (FieldMember.Define): Likewise.
14345 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14348 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14349 Attributes are emitted there.
14351 2005-04-01 Raja R Harinath <rharinath@novell.com>
14353 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14354 keyword in 'partial enum' too.
14355 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14357 Report from Kamil Skalski <nazgul@omega.pl>.
14360 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14361 have partial containers too.
14363 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14364 in block' checks to Block.CheckInvariantMeaningInBlock.
14365 * statement.cs (Block.GetKnownVariableInfo): Make private.
14366 (Block.IsVariableUsedInChildBlock): Remove.
14367 (Block.IsVariableUsedInBlock): Likewise.
14368 (Block.CheckInvariantMeaningInBlock): New. Show location of
14369 conflicting declaration.
14370 (Block.AddVariable): Make error messages less long-winded and more
14371 specific. Show location of conflicting declaration.
14372 * parameter.cs (Parameters.Location): New readonly property.
14374 2005-03-31 Raja R Harinath <rharinath@novell.com>
14376 Clean up semantics of invoking ResolveMemberAccess.
14377 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14378 can have an instance, ensure that we pass in a non-TypeExpression
14379 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14380 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14381 argument. Update to changes and simplify.
14382 (FieldExpr.Emitinstance): Remove CS0120 check.
14383 (PropertyExpr.EmitInstance): Likewise.
14384 * expression.cs (Argument.Resolve): Likewise.
14385 (Invocation.DoResolve): Update to changes in semantics of
14386 InstanceExpression.
14388 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14391 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14394 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14396 2005-03-31 Raja R Harinath <rharinath@novell.com>
14398 Fix difference in behaviour with commandline invocation.
14399 * driver.cs (Driver.Reset): New.
14400 (CompilerCallableEntryPoint): Call it.
14402 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14403 variable" warnings if the boolean expression failed to resolve.
14405 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14407 * attribute.cs: Fix the union of several permissions when some of them
14408 are unrestricted (so the result isn't an unrestricted permission set).
14411 2005-03-30 Raja R Harinath <rharinath@novell.com>
14413 * ecore.cs (MemberExpr): New class. Convert from interface
14415 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14416 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14418 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14419 (MethodGroupExpr.IsExplicitImpl): Remove.
14420 (Expression.GetFieldFromEvent): Remove.
14421 (SimpleName.MemberStaticCheck): Remove.
14422 (SimpleName.DoSimpleNameResolve): Update to changes.
14423 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14424 (MemberAccess.IdenticalNameAndTypeName): Remove.
14425 (MemberAccess.error176): Move to MemberExpr.
14426 (MemberAccess.DoResolve): Update to changes.
14427 (BaseAccess.DoResolve): Likewise.
14429 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14431 C# 2.0 Conditional attribute class implementation
14433 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14434 Analyzes class whether it has attribute which has ConditionalAttribute
14435 and its condition is not defined.
14437 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14438 (Class.IsExcluded): New method. Search for at least one defined
14439 condition in ConditionalAttribute of attribute class.
14441 2005-03-30 Raja R Harinath <rharinath@novell.com>
14443 * ecore.cs (PropertyExpr): Derive from Expression, not
14444 ExpressionStatement.
14445 (PropertyExpr.EmitStatement): Remove.
14447 2005-03-29 Raja R Harinath <rharinath@novell.com>
14450 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14451 internal field "value__" of an enum be private. The examples for
14452 "value__" that I found on MSDN all used FieldAttributes.Private.
14454 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14455 Don't mention IL method attribute names.
14457 Fix #47991. Remove a TODO.
14458 * statement.cs (Block.Toplevel): Make into a field.
14459 (Block.Parameters): Move into ToplevelBlock.
14460 (Block.known_variables): Rename from child_variable_names.
14461 (Block.Block): Remove variants that take Parameters. Initialize
14462 'Toplevel' with the immediately surrounding toplevel block.
14463 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14464 LocalInfo parameter.
14465 (Block.GetKnownVariableInfo): New.
14466 (Block.IsVariableNameUsedInChildBlock): Update.
14467 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14468 the block, even though it may not be in scope.
14469 (Block.AddVariable): Remove Parameters parameter. Use
14470 Toplevel.Parameters instead.
14471 (Block.AddConstant): Remove Parameters parameter.
14472 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14473 (Block.IsParamaterReference): Likewise.
14474 (Block.IsLocalParameter): Likewise. Simplify a lot.
14475 (ToplevelBlock.Parameters): New. Moved from Block.
14476 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14477 initialize Parameters to a non-null value.
14478 * cs-parser.jay: Update to changes.
14479 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14480 simple names that mean different things in the same block. Use
14481 Block.IsVariableNameUsedInBlock.
14483 2005-03-28 Raja R Harinath <rharinath@novell.com>
14485 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14486 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14487 GetTypeHandle. It is possible for a reflected type to derive from
14488 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14489 System.Array during mscorlib compilation).
14490 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14491 contain a method_hash, don't create one either. Don't create a
14492 deep copy of the base cache's method_hash.
14493 (MemberCache.SetupCache): Rename back from DeepCopy.
14494 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14495 already initialized. If we see an override function, add its
14496 underlying base virtual function to the member_hash too.
14498 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14500 2005-03-26 Raja R Harinath <harinath@acm.org>
14503 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14504 fails to resolve, ensure that the LHS is still resolved as an
14507 2005-03-25 Raja R Harinath <harinath@acm.org>
14509 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14511 (Enum.current_ec): Remove.
14512 (Enum.LookupEnumValue): Remove EmitContext argument.
14513 Just uses the one created during DefineType.
14514 (Enum.FindMembers): Update.
14515 * expression.cs (MemberAccess.DoResolve): Update.
14517 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14519 * assign.cs (Assign.DoResolve): Check for CS1717 when
14520 source and target are same (uses Equals).
14522 * expression.cs (LocalVariableReference, ParameterReference,
14523 This): Implemented Equals, GetHashCode.
14525 * statement.cs (Block.GetParameterReference): Removed useless
14528 2005-03-22 Raja R Harinath <rharinath@novell.com>
14531 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14532 blocks before deciding whether the error is cs0136 or cs0128.
14534 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14535 (using_alias_directive, using_namespace_directive): Pass
14536 MemberName, not an expression to Namespace.UsingAlias and
14538 (MakeName): Use the MemberName of the namespace.
14539 * namespace.cs (Namespace.MemberName): New.
14540 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14541 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14543 * decl.cs (MemberName.Name): Make readonly.
14544 (MemberName.FromDotted): New "constructor".
14545 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14546 (MemberCore.Name): Compute from MemberName on demand.
14547 (MemberCore.SetMemberName): Provide a way to change the
14549 (MemberCore.AddToContainer): Don't take a fullname parameter.
14550 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14551 fully qualified name of the container to the member name.
14552 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14553 only if the type is a member of the root container.
14554 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14555 MemberName.Left rather than searching for an embedded ".".
14556 (PartialContainer.CreatePart): Update to changes in RootContext.
14557 (MemberBase.ShortName): Turn into a property. Use
14558 MemberCore.SetMemberName.
14559 (MemberBase.ExplicitInterfaceName): Remove.
14560 (MemberBase.UpdateMemberName): Remove.
14561 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14562 (PropertyBase.SetMemberName): New override.
14563 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14564 (Tree.GetDecl): New.
14565 (Tree.AllDecls): Rename from Decls.
14566 * attribute.cs, enum.cs, report.cs: Update to changes.
14567 * driver.cs (MainDriver): Use MemberName.FromDotted on
14568 RootContext.MainClass.
14570 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14572 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14575 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14577 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14579 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14580 property accessor modifiers.
14582 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14583 fixed buffer attribute (CS1716).
14584 (PropertyMethod.HasCustomAccessModifier): When property accessor
14585 has custom modifier.
14587 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14589 (PropertyExpr.DoResolveLValue): Add CS0272.
14591 2005-03-17 Miguel de Icaza <miguel@novell.com>
14593 * convert.cs: When converting to a pointer, use the proper Conv.U
14594 or Conv.I depending on the source data type.
14596 * cs-tokenizer.cs: Make the size for large decimal constants,
14599 2005-03-17 Martin Baulig <martin@ximian.com>
14601 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14602 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14604 2005-03-17 Martin Baulig <martin@ximian.com>
14606 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14607 to bool so we can return an error condition.
14608 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14611 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14613 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14616 2005-03-16 Raja R Harinath <rharinath@novell.com>
14618 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14619 Refactor to avoid traversing the list of assemblies, and to avoid
14620 string concatenation.
14621 * typemanager.cs (guid_attr_type): Remove.
14622 (negative_hits, pointers, references): Remove hashes.
14624 (GetConstructedType): New. Uses type_hash to handle constructed
14625 types (arrays, references, pointers).
14626 (GetReferenceType, GetPointerType): Use it.
14627 (GetNestedType): New. Uses type_hash to handle nested types of
14629 (LookupType, LookupTypeDirect): Remove.
14630 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14631 'types' hash and LookupTypeReflection directly.
14632 (params_string, params_object): Use GetConstructedType.
14633 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14635 (Namespace.Lookup): Use cached_types.
14636 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14637 provided by old TypeManager.LookupType.
14638 * rootcontext.cs (MakeFQN): Remove.
14639 * decl.cs (DeclSpace.MakeFQN): Likewise.
14640 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14641 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14642 TypeManager.GetConstructedType.
14643 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14645 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14647 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14650 * cs-parser.jay: Reports CS1527 for any namespace element.
14652 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14655 * expression.cs (ParameterReference.IsAssigned): Changed error to
14657 (Error_WrongNumArguments): Moved CS0245 detection here.
14659 * statement.cs (Return.Resolve): Add CS1622 report.
14661 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14663 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14665 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14667 * attribute.cs expression.cs: Get rid of some allocations.
14669 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14671 * doc.cs : just eliminate the latest change.
14673 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14675 * doc.cs : commented out the latest change. It breaks xml-030.cs
14677 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14679 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14680 fail. So invoke CreateType() in FindDocumentedType().
14682 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14684 * cs-tokenizer.cs : added IsKeyword().
14685 * doc.cs : Detect keyword incorrectly used as identifier.
14686 Allow identifiers prefixed by @.
14688 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14690 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14691 It caused exception in namespace resolving (again!).
14693 * class.cs (Class.ctor): Removed exit.
14694 (PropertyMethod.ctor): ditto.
14696 * codegen.cs (Codegen.Reset): Reset static data.
14697 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14699 * cs-tokenizer.cs (Cleanup): Removed.
14701 * driver.cs (GetSystemDir): Rewrote to one line command.
14702 It caused problem with unloaded dynamic modules.
14703 (UnixParseOption): Removed Exit.
14704 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14705 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14706 Now can be mcs used as library.
14708 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14711 * location.cs (Reset): Reset static data.
14713 * namespace.cs (Reset): Reset static data.
14715 * report.cs (Report.Reset): Reset static data.
14717 * rootcontext.cs (RootContext.Reset): Reset static data.
14719 * tree.cs (RootTypes.ctor): Use Location.Null
14721 * typemanager.cs (TypeManager.Reset): Reset static data.
14722 (CoreLookupType): Removed Exit.
14723 (TypeHandle.Reset): Reset static data.
14725 2005-03-10 Raja R Harinath <rharinath@novell.com>
14728 * typemanager.cs (ComputeNamespaces): Import namespaces from
14729 referenced modules too.
14731 2005-03-09 Raja R Harinath <rharinath@novell.com>
14733 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14736 2005-03-09 Raja R Harinath <rharinath@novell.com>
14738 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14739 enclosing DeclSpace. This ensures that a name-lookup populates
14740 more caches and there are fewer 'TypeExpression's. Carve out
14741 nested type lookup into ...
14742 (LookupNestedTypeInHierarchy): ... this.
14744 2005-03-09 Raja R Harinath <rharinath@novell.com>
14746 Clean up a few partial-class semantics.
14747 Fixes test-357.cs and cs1618-2.cs.
14748 * cs-parser.jay (struct_declaration): Use 'current_class' as
14749 parent of newly-created struct. Remove call to Register ().
14750 Use 'pop_current_class' to complete handing the current struct.
14751 (interface_declaration): Likewise.
14752 (class_declaration): Likewise.
14753 (enum_declaration): Use 'current_class' as parent of newly created
14755 (delegate_declaration): Likewise.
14756 (pop_current_class): New function. This is used to handle closing
14757 up the 'current_class' and 'current_container', and pointing them
14758 to the enclosing class/container.
14759 (CSharpParser): Initialize 'current_class' too.
14760 * decl.cs (MemberCore): Add check for invariant: a partial
14761 container is not a parsed entity, and thus does not enclose any
14763 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14764 (DeclSpace.BaseTypeExpr): Use it.
14765 (DeclSpace.LookupType): Add check for invariant.
14766 * class.cs (TypeContainer): Add check for invariant: a nested
14767 class should have the same NamespaceEntry as its enclosing class.
14768 (TypeContainer.EmitFieldInitializers): Make virtual.
14769 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14771 (TypeContainer.Register): Remove.
14772 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14773 null. Use TypeResolveEmitContext for resolving base types and
14774 interfaces. Move initialization of Parts.TypeBuilder here from
14776 (TypeContainer.DefineNestedTypes): ... here.
14777 (PartialContainer): Take a Namespace not a NamespaceEntry.
14778 (PartialContainer.Create): Don't use Register. Call the
14779 appropriate Add... function directly.
14780 (ClassPart): Take both the PartialContainer and the enclosing
14781 class as constructor arguments.
14782 (ClassPart.EmitFieldInitializers): Override.
14783 (ClassPart.PartFindNestedTypes): Remove.
14784 (FieldBase.GetInitializerExpression): Resolve the initializer
14785 expression in the emit context of the enclosing class.
14786 * tree.cs (RootTypes): Remove Register ().
14788 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14790 * cs-parser.jay: Removed CS0134.
14792 * driver.cs: Removed CS1901.
14794 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14795 for predefined types.
14797 2005-03-07 Duncan Mak <duncan@novell.com>
14799 * codegen.cs (Save): Catch UnauthorizedAccessException as
14800 well. Fixes bug #73454.
14802 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14804 * cs-tokenizer.cs (xtoken): Add CS1035.
14806 * class.cs (MethodData.Define): Add CS0683.
14807 (FieldMember.ctor): Add CS0681.
14809 2005-03-07 Raja R Harinath <rharinath@novell.com>
14811 * ecore.cs (SimpleName.DoResolve): Rename from
14812 SimpleName.DoResolveAllowStatic.
14813 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14814 Pass 'intermediate' flag to MemberStaticCheck.
14815 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14816 of "intermediate" lookups via MemberAccess.
14817 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14818 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14820 2005-03-07 Raja R Harinath <rharinath@novell.com>
14823 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14824 slipped in because of variable names that are identical to a
14825 builtin type's BCL equivalent ('string String;', 'int Int32;').
14826 (PropertyExpr.EmitInstance): Likewise.
14828 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14830 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14832 * report.cs (warning_ignore_table): Made public.
14834 2005-03-04 Raja R Harinath <rharinath@novell.com>
14837 * class.cs (MethodData.Emit): Pass 'container' to
14838 container.GetObsoleteAttribute instead of 'container.Parent'.
14840 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14842 * cs-parser.jay: Add 1534 error test.
14844 * iterators.cs (Yield.CheckContext): Add error 1629.
14845 (Iterator.ctor): Save unsafe modifier.
14846 (MoveNextMethod.DoEmit): Restore unsafe context.
14848 * namespace.cs (UsingAlias): Better error message.
14850 2005-03-03 Dan Winship <danw@novell.com>
14852 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14853 the warning message [#73219]
14855 2005-03-03 Raja R Harinath <rharinath@novell.com>
14857 Fix compile with MCS 1.0.0.0.
14858 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14859 w_restore to not depend on string constant folding.
14861 2005-03-03 Raja R Harinath <rharinath@novell.com>
14863 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14864 CS0246 check to users who passed 'silent = false'.
14865 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14867 (SimpleName.SimpleNameResolve): Update.
14868 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14869 (MemberAccess.IdenticalNameAndTypeName): Update.
14870 * doc.cs (FindDocumentedTypeNonArray): Update.
14872 2005-03-03 Raja R Harinath <rharinath@novell.com>
14874 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14875 * parameters.cs (ComputeAndDefineParameters): Remove.
14876 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14877 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14878 Use GetParameterInfo.
14880 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14882 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14884 2005-03-02 Raja R Harinath <rharinath@novell.com>
14886 Unify DeclSpace.LookupType and DeclSpace.FindType.
14887 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14888 is in charge of defining nested types on demand.
14889 (DeclSpace.LookupType): Use it when the current_type is a
14890 TypeBuilder. Use LookupTypeDirect for reflected types.
14891 (DeclSpace.FindType): Remove.
14892 (DeclSpace.LookupInterfaceOrClass): Likewise.
14893 (DeclSpace.DefineTypeAndParents): Likewise.
14894 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14895 DeclSpace.LookupType.
14896 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14897 * typemanager.cs (LookupType): Simplify.
14898 (AddUserType): Remove type from negative_hits.
14899 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14900 * class.cs (TypeContainer.FindMembers): Move handling of nested
14902 (TypeContainer.FindMembers_NestedTypes): ... here.
14903 (TypeContainer.FindNestedType): Implement override.
14904 (ClassPart.FindNestedType): Delegate to PartialContainer.
14905 (ClassPart.PartFindNestedType): Looks up the nested types of the
14908 2005-03-02 Martin Baulig <martin@ximian.com>
14910 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14911 static constructor in static classes.
14913 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14915 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14916 sizeParamIndex is not specified.
14918 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14921 * report.cs (WarningMessage.IsEnabled): Missing null check.
14923 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14925 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14926 in the fields and not in the properties.
14928 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14930 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14933 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14935 * attribute.cs: Small refactoring (improved robustness).
14936 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14937 (ValidateGuid): Removed.
14938 (Resolve): Removed referenced to above mentioned.
14939 (GetAttributeUsage): Made private and changed to work without
14941 (GetIndexerAttributeValue): Don't crash.
14942 (GetConditionalAttributeValue): Ditto.
14943 (GetClsCompliantAttributeValue): Ditto.
14944 (ExtractSecurityPermissionSet): All attributes exceptions are
14946 (GetPropertyValue): New helper.
14947 (GetMethodImplOptions): New method.
14948 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14949 some missing properties.
14951 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14952 (Method.ApplyAttributeBuilder): Updated.
14954 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14957 2005-02-28 Raja R Harinath <rharinath@novell.com>
14960 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14961 non-simple types (array, pointer, reference).
14963 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14965 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14967 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14969 (Method.CheckBase): Catch wrong destructor here.
14970 (MethodData.Define): Add errors 550, 668.
14972 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14974 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14976 * pending.cs (VerifyPendingMethods): Add error 551.
14978 * typemanager.cs (CSharpName): Next error report helper.
14980 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14982 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14983 attributes. Removed useless attribute double check.
14984 It saves almost 2MBs for corlib.
14986 2005-02-25 Raja R Harinath <rharinath@novell.com>
14989 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14990 called twice in case of error.
14992 2005-02-23 Chris Toshok <toshok@ximian.com>
14994 Fix compiler portions of #72827.
14995 * statement.cs (Block.Emit): call Begin/EndScope on the
14996 EmitContext instead of the ILGenerator.
14998 * codegen.cs (EmitContext.BeginScope): new method, call
14999 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
15001 (EmitContext.BeginScope): same, but EndScope and CloseScope
15003 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
15004 offset and call the superclass's OpenScope(int) with it.
15005 (SymbolWriter.CloseScope): get the current il
15006 offset and call superclass's CloseScope(int) with it.
15008 2005-02-23 Marek Safar <marek.safar@seznam.cz>
15010 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
15011 CS1677 for out and ref as well.
15013 * class.cs (Method.Define): Add error CS1599 detection.
15015 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
15017 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
15019 * delegate.cs (Delegate.Define): Add error CS1599 detection.
15021 * support.cs.cs (ModifierDesc): New helper method.
15023 2005-02-23 Raja R Harinath <rharinath@novell.com>
15024 Abin Thomas <projectmonokochi@rediffmail.com>
15025 Anoob V E <projectmonokochi@rediffmail.com>
15026 Harilal P R <projectmonokochi@rediffmail.com>
15028 Fix #57851, #72718.
15029 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
15030 MemberLookup (used for error reporting) actually returns a result.
15031 Fix error report number (122, not 112).
15033 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
15034 Anoob V E <projectmonokochi@rediffmail.com>
15035 Harilal P R <projectmonokochi@rediffmail.com>
15038 * pending.cs (PendingImplementation.GetAbstractMethods):
15039 Find NonPublic members too.
15041 2005-02-22 Marek Safar <marek.safar@seznam.cz>
15043 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
15046 * class.cs (MethodCore.CheckMethodAgainstBase):
15047 Add error 239 report.
15049 2005-02-21 Raja R Harinath <rharinath@novell.com>
15052 * expression.cs (Invocation.IsApplicable): Make public.
15053 (Invocation.IsParamsMethodApplicable): Likewise.
15054 * delegate.cs (Delegate.VerifyApplicability): Don't use
15055 Invocation.VerifyArgumentCompat for parameter applicability
15056 testing. Use Invocation.IsApplicable and
15057 Invocation.IsParamsMethodApplicable.
15059 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15061 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
15063 * class.cs (Operator.Define): Add error 217 report.
15065 2005-02-21 Raja R Harinath <rharinath@novell.com>
15067 * namespace.cs (UsingEntry.Resolve): Undo change below.
15069 2005-02-21 Raja R Harinath <rharinath@novell.com>
15072 * ecore.cs (Expression.MemberLookupFailed): Add argument to
15073 disable the error message when the extended MemberLookup also
15075 (Expression.MemberLookupFinal): Update.
15076 (SimpleName.DoSimpleNameResolve): Update.
15077 * expression.cs (MemberAccess.ResolveNamespaceOrType):
15078 Don't use MemberLookupFinal.
15079 (New.DoResolve): Update.
15080 (BaseAccess.CommonResolve): Update.
15082 2005-02-21 Raja R Harinath <rharinath@novell.com>
15085 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
15086 occured previously, don't resolve again.
15088 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15091 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
15092 argument. Call ResolveAttributeUsage for unresolved.
15093 when types doesn't match ctor arguments.
15095 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
15096 for nested attribute classes.
15097 (Class.attribute_usage): Removed.
15098 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
15099 for attribute class.
15101 * ecore.cs (IsAttribute): Removed.
15103 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
15105 * rootcontext.cs (RegisterAttribute): Removed, attributes are
15107 (attribute_types): Removed.
15108 (EmitCode): Global attributes are emited as the latest.
15110 2005-02-18 Marek Safar <marek.safar@seznam.cz>
15112 * class.cs (EmitFieldInitializers): Don't emit field initializer
15113 for default values when optimilization is on.
15115 * constant.cs (Constant.IsDefaultValue): New property.
15117 * driver.cs: Add /optimize handling.
15121 * literal.cs: Implement new IsDefaultValue property.
15123 * rootcontext.cs (Optimize): New field, holds /optimize option.
15125 2005-02-18 Raja R Harinath <rharinath@novell.com>
15127 Fix crasher in re-opened #72347.
15128 * namespace.cs (Namespace.Lookup): Return null if
15129 DeclSpace.DefineType returns null.
15132 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
15134 2005-02-18 Raja R Harinath <rharinath@novell.com>
15136 Fix remainder of #63202. Change semantics of DoResolveLValue: it
15137 now returns null if it cannot resolve to an lvalue.
15138 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
15139 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
15140 returned null. Remove check for SimpleName.
15141 (EventExpr.DoResolveLValue): New.
15142 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
15143 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
15145 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
15146 avoid CS0131 error.
15147 (Unary.ResolveOperator): Move CS0211 check ...
15148 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
15150 (Unary.DoResolveLValue): Simplify.
15151 (AddressOf.DoResolveLValue): New.
15152 (ArrayAccess.DoResolveLValue): New.
15154 2005-02-16 Marek Safar <marek.safar@seznam.cz>
15156 * attribute.cs (Attribute.Resolve): Add arguments casting for
15157 when types doesn't match ctor arguments.
15159 2005-02-16 Raja R Harinath <rharinath@novell.com>
15161 Fix parts of #63202.
15162 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
15163 lookup of operator in base type. Ensure that all checks happen
15164 when the operator resolves to an "op_..." method.
15166 2005-02-15 Raja R Harinath <rharinath@novell.com>
15169 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
15170 'ignore_cs0104' parameter. Pass it to ...
15171 (NamespaceEntry.Lookup): ... this.
15172 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
15173 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
15174 (TypeLookupExpression.DoResolveAsTypeStep): Update.
15175 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
15176 Update. Request that cs0104 errors be ignored.
15177 (ComposedCast.ResolveAsTypeStep): Update.
15179 2005-02-14 Raja R Harinath <rharinath@novell.com>
15182 * expression.cs (Invocation.BetterFunction): Remove support for
15183 comparing virtual functions and their overrides.
15184 (Invocation.IsOverride): New.
15185 (Invocation.OverloadResolve): Don't consider 'override' functions
15186 during candidate selection. Store them in a lookaside list.
15187 If the selected method is a 'virtual' function, use the list to
15188 find any overrides that are closer to the LHS type.
15190 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15192 * expression.cs (New.DoResolve): Add complex core type reduction.
15193 (New.Constantify): Converts complex core type syntax like 'new int ()'
15194 to simple constant.
15196 2005-02-14 Raja R Harinath <rharinath@novell.com>
15198 * decl.cs (EntryType.EntryType): New constructor to create an
15199 updated copy of a cache entry.
15200 (MemberCache.AddMethods): Use it.
15201 (MemberCache.ClearDeclaredOnly): Remove.
15202 (MemberCache.MemberCache): Update.
15204 2005-02-11 Miguel de Icaza <miguel@novell.com>
15206 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15207 variable. This one is represents the actual low-level declaration
15208 of the method, as opposed to the semantic level `IsStatic'.
15210 An anonymous method which is hosted into a static method might be
15211 actually an instance method. IsStatic would reflect the
15212 container, while MethodIsStatic represents the actual code
15215 * expression.cs (ParameterReference): Use the new MethodIsStatic
15216 instead of IsStatic.
15218 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15219 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15220 set on the current EmitContext.
15222 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15223 resolve our casted expression as an LValue. This triggers the
15224 proper LValue processing that is later required by Assign.
15228 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15230 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15232 C# 2.0 Fixed buffer implementation
15234 * anonymous.cs: Update after RegisterHelperClass renaming.
15236 * attribute.cs (AttributeTester.fixed_buffer_cache):
15237 Cache of external fixed buffers.
15238 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15239 implementation if field is fixed buffer else null.
15242 (TypeContainer.AddField): Accept FieldMember instead of Field.
15243 (FieldBase.IsFieldClsCompliant): Extracted code from
15244 VerifyClsCompliance descendant customization.
15245 (FixedField): New class handles fixed buffer fields.
15246 (FixedFieldExternal): Keeps information about imported fixed
15248 (IFixedField): Make access to internal or external fixed buffer
15251 * cs-parser.jay: Add fixed buffer parsing.
15253 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15256 * expression.cs (Indirection): Extended implementation to accept
15257 fixed buffer field.
15258 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15259 (ElementAccess.MakePointerAccess): Get type as parameter.
15260 (DoResolve): Add fixed buffer field expression conversion.
15261 (DoResolveLValue): Ditto.
15262 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15263 (ArrayPtr): Derives from FixedBufferPtr.
15264 (ArrayPtr.Emit): Add extra emit for array elements.
15266 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15268 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15269 for compiler generated types.
15270 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15272 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15273 and consume less memory.
15274 (Fixed.Resolve): Add fixed buffer case.
15276 * typemanager.cs (compiler_generated_attr_ctor,
15277 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15278 (HasElementType): Add our own implementation to work on every
15281 2005-02-11 Miguel de Icaza <miguel@novell.com>
15283 * anonymous.cs (CaptureContext): Track whether `this' has been
15286 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15287 only captured `this' if it was implicitly done (instance
15288 methods/variables were used).
15290 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15291 `this' must be captured.
15293 2005-01-30 Miguel de Icaza <miguel@novell.com>
15295 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15296 is null it means that there has been no need to capture anything,
15297 so we just create a sibling.
15299 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15301 Just a partial fix. The other half is fairly elusive.
15303 2005-02-10 Raja R Harinath <rharinath@novell.com>
15305 Fix #52586, cs0121-4.cs.
15306 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15307 and return a hashtable.
15308 (MemberCache.ClearDeclaredOnly): New.
15309 (MemberCache.MemberCache): Update to change. Make a deep copy of
15310 the method_hash of a base type too.
15311 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15312 type methods. Overwrite entries with the same MethodHandle so
15313 that the ReflectedType is correct. The process leaves in base
15314 virtual functions and their overrides as distinct entries.
15315 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15316 matters since it was boxed in a ArrayList before.
15317 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15319 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15320 case of a virtual function and its override (choose the overload
15322 (Invocation.OverloadResolve): Avoid 'override' members during
15323 'applicable_type' calculation.
15325 2005-02-09 Raja R Harinath <rharinath@novell.com>
15327 Combine two near-redundant caches.
15328 * typemanager.cs (method_params): Rename from method_internal_params.
15329 (TypeManager.GetParameterData): New. Replace
15330 Invocation.GetParameterData.
15331 (TypeManager.LookupParametersByBuilder): Remove.
15332 * expression.cs (Invocation.method_parameter_cache): Remove.
15333 (Invocation.GetParameterData): Remove.
15335 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15338 2005-02-08 Raja R Harinath <rharinath@novell.com>
15341 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15342 TypeManager.multicast_delegate_type is null, resolve it by looking
15343 up "System.MulticastDelegate".
15344 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15346 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15347 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15348 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15351 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15352 (LabeledStatement.AddReference): New. Set 'referenced'.
15353 (Goto.Resolve): Use it.
15355 2005-02-05 John Luke <john.luke@gmail.com>
15357 * driver.cs: remove duplicate -doc line in Usage ()
15359 2005-02-04 Raja R Harinath <rharinath@novell.com>
15361 * location.cs (Location.AddFile): Fix CS2002 error report.
15363 2005-02-02 Martin Baulig <martin@ximian.com>
15365 * delegate.cs (Delegate.DefineType): Report an internal error if
15366 TypeManager.multicast_delegate_type is null. See bug #72015 for
15369 2005-02-02 Raja R Harinath <rharinath@novell.com>
15371 Fix a crasher in a variant of #31984.
15372 * const.cs (Constant.CheckBase): New override that defers the
15373 new-or-override check in case the base type hasn't been populated
15375 (Constant.Define): Ensure the new-or-override check is performed.
15377 2005-02-01 Duncan Mak <duncan@ximian.com>
15379 * const.cs (LookupConstantValue): Check that `ce' is not null
15380 before calling GetValue ().
15382 2005-02-01 Raja R Harinath <rharinath@novell.com>
15384 Fix test-334.cs (#69519).
15385 * cs-parser.jay (using_alias_directive): Pass in an expression to
15386 NamespaceEntry.UsingAlias.
15387 (using_namespace_directive): Pass in an expression to
15388 NamespaceEntry.Using.
15389 (namespace_name): Don't flatten to a string.
15390 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15391 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15393 (NamespaceEntry.UsingEntry): Likewise.
15394 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15396 (NamespaceEntry.LookupForUsing): Remove.
15397 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15399 (NamespaceEntry.Lookup): Remove support for dotted names.
15401 2005-02-01 Raja R Harinath <rharinath@novell.com>
15403 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15405 (NamespaceEntry.ImplicitParent): Compute on demand.
15406 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15407 parallels the current.
15408 (NamespaceEntry.LookupForUsing): Use it.
15409 (NamespaceEntry.Lookup): If the current namespace-entry is
15410 implicit, don't search aliases and using tables.
15412 2005-02-01 Raja R Harinath <rharinath@novell.com>
15415 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15417 (TypeContainer.BaseCache): Compute on demand.
15418 (TypeContainer.FindMembers): Define constants and types if they're
15419 not already created.
15420 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15422 * const.cs (Constant.Define): Make idempotent.
15424 2005-01-29 Miguel de Icaza <miguel@novell.com>
15426 * pending.cs: Produce better code (no nops produced by using Ldarg
15429 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15430 i - 1' it should be arg + 1.
15434 2005-01-28 Raja R Harinath <rharinath@novell.com>
15436 * attribute.cs (Attribute.CheckAttributeType): Make private
15438 (Attribute.ResolveType): Make virtual.
15439 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15440 handling of RootContext.Tree.Types.
15442 2005-01-27 Raja R Harinath <rharinath@novell.com>
15444 Update attribute-handling to use the SimpleName/MemberAccess
15446 * cs-parser.jay (attribute): Pass in an expression to the
15447 constructors of Attribute and GlobalAttribute.
15448 * attribute.cs (Attribute): Take an expression for the name.
15449 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15450 passed in attribute name expression.
15451 (Attribute.CheckAttributeType): Use it.
15452 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15453 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15454 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15455 argument to prevent error messages if the lookup fails.
15457 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15459 * expression.cs (Indirection): Implemented IVariable interface
15460 to support indirection in AddressOf operator.
15461 (PointerArithmetic.Emit): Add optimalization for case where
15462 result can be precomputed.
15464 2005-01-26 Martin Baulig <martin@ximian.com>
15466 * class.cs (TypeContainer.AttributeTargets): Return the correct
15467 AttributeTargets depending on our `Kind' instead of throwing an
15468 exception; fixes #71632.
15470 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15473 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15476 2005-01-25 Raja R Harinath <rharinath@novell.com>
15479 * expression.cs (MemberAccess.DoResolve): Don't complain with
15480 cs0572 when the LHS of a member access has identical name and type
15483 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15486 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15488 Create custom PermissionSet only for PermissionSetAttribute.
15490 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15493 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15494 delegates in static class.
15496 2005-01-24 Martin Baulig <martin@ximian.com>
15498 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15499 merging an implicit block, just use its reachability.
15501 * statement.cs (Block.Resolve): Make the unreachable code check
15502 work wrt. implicit blocks; see test-337 from #63842.
15504 2005-01-21 Alp Toker <alp@atoker.com>
15506 * cs-parser.jay: destructor_declaration's container is PartialContainer
15507 not Class when partial types are used, so use Kind prop instead of
15510 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15512 * cs-parser.jay: Improve error reporting when an interface
15513 declares new types.
15515 2005-01-20 Dick Porter <dick@ximian.com>
15517 * support.cs: SeekableStreamReader fix from Sandor Dobos
15518 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15519 chars are read. Fixes bug 70369.
15521 2005-01-20 Raja R Harinath <rharinath@novell.com>
15523 * cs-parser.jay (catch_clause): Simplify current_block handling
15526 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15528 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15529 code with ImplicitStandardConversion to handle the implicit
15530 conversion of method groups into valid delegate invocations.
15532 The problem is that in parameter handling we were using this code
15533 path. Fixes bug #64698
15535 2005-01-19 Raja R Harinath <rharinath@novell.com>
15537 * cs-parser.jay: Fix several infelicities.
15538 - Avoid assigning to the parser value stack. Code like
15539 '$3 = null' is unclean. Synthesize a value for the code block
15541 - Avoid using oob_stack for storing location information. Use ...
15542 (_mark_): ... this. New (empty) rule. Saves the current location
15544 (foreach_statement): Avoid using oob_stack for current_block
15545 handling. Use technique used in for_statement and
15546 using_statement. Synthesize a value for the code block to store
15547 additional intermediate information.
15549 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15551 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15552 of a different type is only allowed to private fields of a
15553 containing type, not on fields of a base class.
15555 See test-174.cs and error cs0122-9.cs
15557 2005-01-13 Raja R Harinath <rharinath@novell.com>
15559 Fix test-335.cs (bug #58126).
15560 * cs-parser.jay (argument): Split out non-expression parts of the
15561 rule into 'non_simple_argument'.
15562 (invocation_expression): Support parenthesized invocations with
15563 multiple arguments, and with single non-simple arguments.
15565 2005-01-13 Raja R Harinath <rharinath@novell.com>
15567 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15570 2005-01-12 Raja R Harinath <rharinath@novell.com>
15572 Fix cs0038-1.cs, cs1640-6.cs.
15573 * ecore.cs (Expression.Resolve): Remove special-case for
15574 SimpleName in error-handling.
15575 (Expression.almostMatchedMembers): Relax access permission to
15577 (Expression.MemberLookupFailed): Handle duplicates in
15578 almostMatchedMembers list.
15579 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15580 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15581 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15582 overload if the passed in MemberInfo is a MethodBase.
15584 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15587 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15588 for non-CAS & merge permission sets properly.
15590 2005-01-11 Raja R Harinath <rharinath@novell.com>
15592 Improve standard-compliance of simple name and member access
15593 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15594 * ecore.cs (FullNamedExpression): New abstract base class
15595 for Namespaces and TypeExpressions.
15596 (ResolveFlags.SimpleName): Remove.
15597 (SimpleName): Remove support for dotted names.
15598 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15599 DeclSpace.FindType and DeclSpace.LookupType.
15600 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15601 (Expression.ExprClassName): Make member function.
15602 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15603 a namespace. Remove creation of dotted "SimpleName"s.
15604 (MemberAccess.DoResolve): Likewise.
15605 * decl.cs (DeclSpace.Cache): Make private.
15606 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15607 (DeclSpace.FindType): Update.
15608 (DeclSpace.LookupType): Move here from RootContext. Return a
15609 FullNamedExpression.
15610 * namespace.cs (Namespace): Derive from FullNamedExpression
15611 so that it can be part of expression resolution.
15612 (Namespace.Lookup): Return an FullNamedExpression.
15613 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15615 * rootcontext.cs (NamespaceLookup): Remove.
15616 (LookupType): Move to DeclSpace.
15617 * attribute.cs (CheckAttributeType): Update.
15618 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15619 (FindDocumentedTypeNonArray): Likewise.
15621 2005-01-11 Raja R Harinath <rharinath@novell.com>
15623 Fix cs0509.cs, cs1632.cs.
15624 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15625 is the same as IsInterface.
15626 (TypeContainer.GetClassBases): Likewise.
15627 * statement.cs (LabeledStatement.ig): New field.
15628 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15630 (LabeledStatement.DoEmit): Check that the label was created with
15631 the same ILGenerator.
15633 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15636 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15637 accessors to its properties.
15639 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15640 from accessors to property.
15642 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15645 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15646 only for overrides.
15648 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15650 * attribute.cs: Check for null and empty strings.
15652 I have lost another battle to Paolo.
15654 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15657 * class.cs (PropertyMethod): Set Parent field in ctors.
15658 (SetMethod.InternalParameters): Add unsafe switch hack.
15659 Override MarkForDuplicationCheck where it is appropriate.
15661 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15662 It says whether container allows members with the same name.
15663 Base default is no.
15664 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15665 Removed is_method parameter.
15667 2005-01-06 Duncan Mak <duncan@ximian.com>
15669 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15670 because the previous change led to incorrect reporting of CS1032
15671 ("Cannot define/undefine preprocessor symbols after first token in
15672 file"). Instead of using `tokens_seen' as the only flag that
15673 triggers CS1040, introduce `comments_seen'. This new flag is used
15674 to signify having seen comments on the current line, so it is
15675 unset after a newline.
15677 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15679 * doc.cs : When searching for a type, find nested type too.
15680 This fixes bug #71040.
15682 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15685 - Warn missing member comment on those classes which also does not
15686 have doc comments. Fixed bug #71041.
15687 - Don't warn missing doc comment on default constructor.
15690 2005-01-06 Duncan Mak <duncan@ximian.com>
15692 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15693 comments, set `tokens_seen' to true. This allows us to detect
15694 misplaced preprocessor directives (i.e. not at the beginning of
15695 the a line, nor after whitespaces). In that case, report error
15696 CS1040. This fixes bug #56460.
15698 * cs-parser.jay (interface_member_declaration): Add checks for
15699 IsExplicitImpl, and report CS0541 error if an interface member is
15700 defined as an explicit interface declaration.
15702 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15705 * class.cs (PropertyMethod): Set Parent field in ctors.
15706 (SetMethod.InternalParameters): Add unsafe switch hack.
15708 * decl.cs (MemberCore.Parent): Cannot be readonly.
15710 2005-01-06 Raja R Harinath <rharinath@novell.com>
15712 * decl.cs (DeclSpace.ResolveType): Remove.
15713 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15714 Merge in code from ...
15715 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15716 * class.cs, enum.cs: Update to changes.
15718 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15720 * anonymous.cs: Ensure that we init the scope of our parent if it
15721 has not been initialized yet.
15723 2004-12-30 Duncan Mak <duncan@ximian.com>
15725 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15726 if field.FieldBuilder is null. Fixes #70758.
15728 * convert.cs: Fixed some typos and updated some of the comments.
15729 (ImplicitStandardConversionExists):
15730 (TryImplicitIntConversion): If `target_type' is an interface and
15731 the type of `ic' implements this interface, return true or a new
15732 BoxedCast instead of null. This fixes #70468.
15734 2004-12-29 Duncan Mak <duncan@ximian.com>
15736 * expression.cs (Argument.Emit): Check that Expr is
15737 IMemoryLocation before casting to it, and report CS1510 otherwise.
15741 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15743 * statement.cs (Block.ThisVariable): remove the recursion here, to
15744 make the --profile more sane.
15746 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15748 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15749 assembly, by JB Evain.
15751 2004-12-17 Raja R Harinath <rharinath@novell.com>
15753 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15754 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15755 "parent" refers to enclosing type/class. "base" refers to superclass.
15757 2004-12-17 Raja R Harinath <rharinath@novell.com>
15759 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15760 Ensure that we only have GlobalAttributes.
15761 * attribute.cs (Attribute.Emit): Make non-virtual.
15762 (GlobalAttribute.Emit): Remove.
15763 (Attribute.Resolve): Make virtual.
15764 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15765 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15766 the argument. Don't create one.
15767 (Attribute.GetObsoleteAttribute): Likewise.
15768 (Attribute.GetClsCompliantAttributeValue): Likewise.
15769 * class.cs, decl.cs: Update to changes.
15771 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15773 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15775 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15777 * statement.cs (Foreach.Resolve): Add error 186 report.
15779 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15781 * expression.cs (Conditional.DoResolve): Add warning 429.
15783 * statement.cs (If.Resolve): Add warning 665.
15785 2004-12-16 Raja R Harinath <rharinath@novell.com>
15787 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15788 except when in the parser, and in GlobalAttribute.
15789 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15790 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15791 RootContext.Tree.Types.NamespaceEntry once work is done.
15792 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15793 and resets RootContext.Tree.Types.NamespaceEntry.
15795 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15797 * cs-parser.jay: Don't create a block for every variable.
15799 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15801 * location.cs: Provide extra information.
15803 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15804 variables from the captured environment, it is the ldarg_0.
15806 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15808 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15811 * class.cs: Changed warning level for 169 to avoid developer
15812 displeasure from warning flooding. It will be changed back when they
15813 fix most of current BCL warnings.
15815 * RootContext.cs: Pushed default WarningLevel to 3.
15817 * statement.cs: Removed unused variable.
15819 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15821 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15822 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15823 Add error 502 report.
15824 (StaticClass.DefineType): Add error 441 report.
15825 (Class.AllowedModifiersProp): New virtual property as temporary
15826 extension to AllowedModifiers.
15827 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15828 to share implementation with StaticClass and don't call virtual
15831 * driver.cs (MainDriver): Add error 1558 test.
15833 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15834 report. Moved error 36 test here.
15836 * statement.cs (Throw.Resolve): Add error 724 report.
15838 * typemanager.cs: Add out_attribute_type core type.
15840 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15842 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15844 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15846 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15849 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15851 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15852 Add error 3023 report.
15853 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15855 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15858 2004-12-12 John Luke <john.luke@gmail.com>
15860 * driver.cs (AddArgs): take -- into account when
15861 adding arguments, fixes bug 65710
15863 2004-12-12 Martin Baulig <martin@ximian.com>
15865 * expression.cs (Unary.TryReduceNegative): Added support for
15866 SByteConstant and ByteConstant.
15867 (Unary.Reduce): Check error values from TryReduceNegative().
15869 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15871 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15872 and report exception as error 182.
15874 2004-12-10 Raja R Harinath <rharinath@novell.com>
15876 * driver.cs (Main): Fix message when there are warnings.
15878 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15880 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15882 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15884 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15885 Reduced number of warnings.
15887 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15889 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15891 * driver.cs: Removed message.
15893 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15895 2004-12-08 <vargaz@freemail.hu>
15897 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15899 2004-12-08 Martin Baulig <martin@ximian.com>
15901 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15902 instead of a CS3002 for properties and indexer.
15904 2004-12-08 Martin Baulig <martin@ximian.com>
15906 * decl.cs (MemberName.ToString): Make this work again.
15908 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15910 * attribute.cs (Resolve): Add error 591 detection.
15912 * class.cs (FieldMember.Define): Add error 1547 detection.
15913 (Indexer.Define): Add error 620 detection.
15914 (Operator.Define): Add error 590 detection.
15916 * ecore.cs: Missing argument for error 79.
15918 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15921 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15924 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15927 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15929 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15930 Some operator comments were suppressed.
15931 * doc.cs : Implicit/explicit operator name in doc comments are like
15932 "op_Explicit(type)~returnType", so added suffix handling.
15934 2004-12-07 Martin Baulig <martin@ximian.com>
15937 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15938 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15939 (DeclSpace.ec): New protected field; store the EmitContext here.
15940 (DeclSpace.EmitContext): New public property; moved here from
15942 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15945 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15946 (Enum.Emit): Don't create a new EmitContext.
15948 * delegate.cs (Delegate.DefineType): Always create the
15951 * iterators.cs (Iterators.DefineIterator): Create a new
15952 EmitContext and store it in `ec'.
15954 2004-08-24 Martin Baulig <martin@ximian.com>
15957 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15958 this for accessibility checks.
15959 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15960 IsNestedFamilyAccessible.
15961 (TypeManager.IsSubclassOf): New method, do what the name actually
15964 2004-12-06 Raja R Harinath <rharinath@novell.com>
15966 Fix crash on cs0657-17.cs.
15967 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15968 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15969 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15970 the case where the NamespaceEntry gets overwritten.
15972 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15974 Fixed #69195, #56821
15975 * ecore.cs (ResolveBoolean): Tiny refactoring.
15977 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15978 of right expression resolving when left is false constant and
15979 operator is LogicalAnd OR true constant and operator is LogicalOr.
15981 * statement.cs (ResolveUnreachable): Always reports warning.
15983 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15985 * class.cs: Distinguish between 1721 and 1722 (just a little help
15986 for the programmer).
15988 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15990 * delegate.cs: Only allow this on new versions of the language.
15992 2004-12-02 Duncan Mak <duncan@ximian.com>
15994 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15996 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15997 here as a static method. Take an additional bool out parameter
15998 `must_do_cs1540_check' for signaling to InstanceResolve.
15999 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
16000 member field from PropertyExpr class and made it an argument of
16001 the method instead.
16002 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
16003 check for MarshalByRefObject, and report CS0122 instead of CS1540.
16004 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
16005 and `remove_accessor' as well as InstanceResolve: report CS0122
16010 2004-12-03 Raja R Harinath <rharinath@novell.com>
16012 Fix test-327.cs, test-328.cs, and put in early infrastructure
16013 for eventually fixing #52697.
16014 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
16015 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
16016 from other methods.
16017 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
16018 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
16019 (VerifyUsing, error246): Update.
16020 * rootcontext.cs (RootContext.NamespaceLookup): Just use
16021 'NamespaceEntry.LookupNamespaceOrType'.
16023 2004-12-03 Martin Baulig <martin@ximian.com>
16025 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16026 method as our child, call AnonymousMethod.Compatible() on it.
16028 2004-12-03 Raja R Harinath <rharinath@novell.com>
16030 Disable XML documentation support in 'basic' profile.
16031 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
16032 Redirect XmlElement to System.Object.
16033 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
16034 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
16035 * mcs.exe.sources: Add doc-bootstrap.cs.
16036 * doc-bootstrap.cs: New file. Contains empty stub implementation
16039 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
16041 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
16042 comments are allowed.
16044 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16046 * delegate.cs: Add checks for subtypes in paramaters and return values
16047 in VerifyMethod () to add support for Covariance/Contravariance
16050 2004-12-02 Miguel de Icaza <miguel@ximian.com>
16052 * report.cs: Remove extra closing parenthesis.
16054 * convert.cs (Error_CannotImplicitConversion): If the name of the
16055 types are the same, provide some extra information.
16057 * class.cs (FieldBase): Use an unused bit field from the field to
16058 encode the `has_offset' property from the FieldMember. This saves
16059 a couple of Ks on bootstrap compilation.
16061 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16062 method as our child, return the AnonymousMethod resolved
16065 * expression.cs (New.DoResolve): Allow return values from
16066 NewDelegate to also include AnonymousMethods.
16070 2004-12-02 Marek Safar <marek.safar@seznam.cz>
16073 * attribute.cs (Resolve): Improved implementation of params
16074 attribute arguments.
16076 * support.cs (ParameterData): Add HasParams to be faster.
16078 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
16080 all things are for /doc support:
16082 * doc.cs: new file that supports XML documentation generation.
16083 * mcs.exe.sources: added doc.cs.
16085 Handle /doc command line option.
16086 Report error 2006 instead of 5 for missing file name for /doc.
16087 Generate XML documentation when required, after type resolution.
16089 Added support for picking up documentation (/// and /** ... */),
16090 including a new XmlCommentState enumeration.
16092 Added lines to fill Documentation element for field, constant,
16093 property, indexer, method, constructor, destructor, operator, event
16094 and class, struct, interface, delegate, enum.
16095 Added lines to warn incorrect comment.
16097 Added Documentation field (passed only when /doc was specified).
16099 Added DocComment, DocCommentHeader, GenerateDocComment() and
16100 OnGenerateDocComment() and some supporting private members for
16101 /doc feature to MemberCore.
16103 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
16105 Added overriden DocCommentHeader.
16107 Added overriden DocCommentHeader and GenerateDocComment().
16109 2004-12-01 Miguel de Icaza <miguel@ximian.com>
16111 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
16112 unwrapping the enumeration values, chain to
16113 DoConstantNumericPromotions again, so we can promote things to the
16114 fundamental types (takes care of enums that are bytes, sbytes).
16118 2004-12-01 Raja R Harinath <rharinath@novell.com>
16120 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
16121 Fix long-standing bug in type-lookup. Use FindType instead of
16122 LookupType when ec.ResolvingTypeTree.
16123 (Attribute.ResolveType, Attribute.Resolve)
16124 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
16126 (Attributes.Search): Remove internal version. Update.
16127 (Attributes.SearchMulti): Update.
16128 (Attributes.GetClsCompliantAttribute): Remove.
16129 (Attributes.GetIndexerNameAttribute): Remove.
16130 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
16131 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
16132 * class.cs (Indexer.Define): Likewise.
16134 2004-12-01 Marek Safar <marek.safar@seznam.cz>
16137 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
16138 MarshallByReference members access.
16140 * expression.cs: Use CheckMarshallByRefAccess;
16141 Better error CS0197 message.
16143 * report.cs: Print whole related error message.
16145 2004-11-30 Raja R Harinath <rharinath@novell.com>
16147 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
16148 the current directory to help debugging.
16150 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16152 * class (GetClassBases): Better error 60 report.
16153 (EventProperty): Disabled warning 67 detection.
16155 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16158 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
16160 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
16163 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16166 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
16168 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
16170 2004-11-26 Miguel de Icaza <miguel@ximian.com>
16172 * attribute.cs (Attribute.Resolve): Refine error reporting and
16173 report a cs0117 if the identifier does not exist, to distinguish
16174 from 0617 which is a miss-use of the actual identifier.
16176 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
16177 between cs0070 and cs0079.
16179 * class.cs (MemberBase.DoDefine): When reporting a wrong
16180 accessibility level, we use MethodCore to compare instead of
16181 Method (this was a regression in some refactoring effort).
16183 So now we correctly report cs0056 again.
16185 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16186 testing the target_type (which was known to be object_type) and
16187 not the source type (which is anonymous_method).
16189 Fixed reporting of error cs1660.
16191 * expression.cs (UserCast.Source): Expose the underlying cast.
16193 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16194 allowed types to find a match to int32 first (most common).
16196 In addition, it ignores any ImplicitUserConversions that did an
16197 internal implicit conversion (as the switch statement allows only
16198 one integral conversion to exist).
16200 * class.cs (PartialContainer.Create): rename `name' to
16201 `member_name' for clarity. Then replace the string calls with a
16202 call to MemberName.GetPartialName, as now using
16203 MemberName.ToString is an error (this is due to the side effects
16204 it had, that were fixed in the past).
16206 This will restore the error reporting on a number of partial class
16207 errors that were missusing this (and getting an exception as a
16208 results, which is now just a plain textual warning, because
16209 yyparse debug output would crash otherwise).
16211 2004-11-26 Raja R Harinath <rharinath@novell.com>
16213 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16215 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16217 * rootcontext.cs (LookupType): Make sure to cache lookups that
16218 don't give us a negative result. This saves about 5% of corlib
16221 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16223 * report.cs (AbstractMessage.Print): messages are sent to stderr
16225 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16226 non-interface in the list of interfaces (at this point, either
16227 parent was properly set, or a base class is being listed in the
16228 interfaces section).
16230 This flags error 1722, and resolves the crash from bug 69259.
16232 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16234 * statement.cs (Using.EmitExpressionFinally): make this work right
16235 for valuetypes. Fixes 69926.
16237 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16239 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16240 converted to an enum" here, before we try to change the underlying
16241 type. This code exists, but it is a different code path than the
16242 one used while encoding constants.
16244 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16245 old bug: when converting from the null literal to a pointer,
16246 return an EmptyCast, not the NullLiteral.
16248 This fixes #69921, the recent null_type changes probably made this
16249 bug more prominent.
16251 (ImplicitReferenceConversionExists): In addition, resynchronized
16252 the code here, so it matches the same code in
16253 ImplicitReferenceConversionExists for the `from any class-type S
16254 to any interface-type T'.
16257 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16259 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16261 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16263 * cs-parser.jay: Use verbosity accordingly.
16265 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16267 * expression.cs (Unary.ResolveOperator): Do not report warning;
16268 AddressOf reads from variable.
16270 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16272 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16276 * attribute.cs (Attributable): Removed CheckTargets.
16277 (Attributes.Emit): Explicit attribute targets are tested here.
16279 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16280 not enabled for interfaces.
16282 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16283 (GetAssemblyName): Ouch next bug there.
16285 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16287 * expression.cs: Error 275 added.
16289 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16291 Fix bug #69177 (Implemented decimal constant support)
16293 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16294 (BinaryFold): Add DecimalConstant.
16296 * const.cs (Define): Decimal constant
16298 (ChangeType): Add decimal type handling.
16299 (LookupConstantValue): Don't set value for decimal type but
16300 emit DecimalConstantAttribute. Needed for constant optimization.
16302 * constant.cs (ToDecimal): New method.
16303 (ConvertToDecimal): New method.
16304 (IntConstant): Implemented ConvertToDecimal.
16305 (DecimalConstant.Emit): Emit optimized version for decimals in
16308 * expression.cs (ResolveOperator): Changed order of constant
16309 reduction to work correctly with native types which have
16310 overloaded operators.
16311 (ResolveMemberAccess): Extract constant value from attribute
16314 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16316 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16317 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16318 (ChangeType): Decimal is special.
16319 (TypeToCoreType): Add decimal type.
16321 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16323 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16326 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16328 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16331 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16333 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16335 * pending.cs (PendingImplementation): Grab only interfaces.
16337 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16339 * statement.cs (ForeachHelperMethods): Add location member and
16340 error 202 detection.
16342 2004-11-19 Raja R Harinath <rharinath@novell.com>
16344 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16345 automatically handled by executable.make.
16346 (PROGRAM): Make profile-specific.
16348 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16350 * expression.cs (DoResolveBase): Fixed wrong warning for out
16353 2004-11-18 Martin Baulig <martin@ximian.com>
16355 Merged latest changes into gmcs. Please keep this comment in
16356 here, it makes it easier for me to see what changed in MCS since
16357 the last time I merged.
16359 2004-11-17 Raja R Harinath <rharinath@novell.com>
16361 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16362 (TypeHandle.GetMemberCache): New.
16363 (TypeHandle.TypeHandle): Update.
16364 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16365 (TypeManager.LookupParentInterfacesCache):
16366 Rename from LookupInterfaceCache. Optimize slightly.
16367 (TypeManager.MemberLookup_FindMembers): Update.
16368 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16369 multi-type variant.
16370 (AddCacheContents): Rename from AddHashtable.
16371 * class.cs (TypeContainer.parent_container): Remove.
16372 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16373 (TypeContainer.DoDefineMembers): Don't initialize it.
16374 Update to name changes.
16376 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16378 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16379 that factors the code to check access modifiers on override.
16381 (PropertyBase): Use the code here.
16383 Patch from Lluis S'anchez, fixes bug #69361.
16385 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16387 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16388 routine that is used to report the use of a captured variable
16389 whose address has been taken.
16391 There are two checks: one when variables are being captured and
16392 the other check is when the address of a variable is taken.
16394 (because an anonymous methods might be resolved before *or* after
16395 the address has been taken) and
16397 * expression.cs (Conditional.DoResolve): Remove the special
16398 casing that Martin added to trueExpr and falseExpr being both
16399 NullLiteral. We get the right behavior now just by introducing
16400 the null_type into the compiler.
16402 * convert.cs (ExplicitConversion): Change the code to use
16403 null_type instead of testing `expr is NullLiteral'.
16404 (ImplicitConversionStandard): use null_type too.
16405 (ImplicitReferenceConversionExists): use null_type too.
16406 (ImplicitReferenceConversion): use null_type too.
16408 * literal.cs: The type of `NullLiteral' is now null_type instead
16410 (Resolve): Set the type here.
16412 * typemanager.cs: Introduce null_type.
16414 2004-11-17 Martin Baulig <martin@ximian.com>
16416 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16417 direction, like FindMembers() does. Fixes #69546, testcase is in
16420 2004-11-16 Martin Baulig <martin@ximian.com>
16422 This is based on a patch from Marek Safar, see bug #69082.
16423 Fixes bugs #63705 and #67130.
16425 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16426 method; create a MemberCache for an interface type and cache the
16429 * decl.cs (IMemberContainer.ParentContainer): Removed.
16430 (IMemberContainer.ParentCache): New property.
16431 (MemberCache.SetupCacheForInterface): Removed.
16432 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16433 to create a cache for an interface's "parent".
16435 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16438 2004-11-16 Martin Baulig <martin@ximian.com>
16440 Merged back from gmcs; these changes already went into gmcs a
16441 couple of weeks ago.
16444 (TypeManager.AddUserType): Removed the `ifaces' argument.
16445 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16447 (TypeManager.AddUserInterface): Removed.
16448 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16450 (TypeManager.GetInterfaces): Likewise.
16451 (TypeManager.GetExplicitInterfaces): Likewise.
16453 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16455 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16456 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16458 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16460 * statement.cs: Avoid adding bools to a hashtable.
16462 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16464 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16465 calling an unsafe method from a safe location.
16467 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16470 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16472 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16474 * namespace.cs (VerifyUsing): use GetPartialName instead of
16477 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16479 * statement.cs (Return.Resolve): Fix regression in typo: if
16480 `in_exc', we have to request a NeedReturnLabel, this was a typo
16481 introduced in the anonymous method check-in. Fixes #69131.
16483 * Indexers were using the ShortName when defining themselves,
16484 causing a regression in the compiler bootstrap when applying the
16485 patch from 2004-11-02 (first part), now they use their full name
16486 and the bug is gone.
16488 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16490 * driver.cs: Strip the path from the names of embedded resources. Fixes
16493 2004-11-04 Raja R Harinath <rharinath@novell.com>
16495 Fix error message regression: cs0104-2.cs.
16496 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16497 (AliasEntry.Resolve): Update.
16498 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16500 (RootContext.LookupType): Update.
16502 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16504 * cs-parser.jay: Add support for handling accessor modifiers
16505 * class: Add support port accessor modifiers and error checking,
16506 define PropertyMethod.Define as virtual (not abstract anymore)
16507 * ecore.cs: Add checking for proeprties access with access modifiers
16508 * iterators.cs: Modify Accessor constructor call based in the modified
16510 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16512 * expression.cs (StringConcat): Handle being called twice,
16513 as when we have a concat in a field init with more than two
16516 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16518 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16519 special case explicit implementations, we should always produce
16520 the .property or .event declaration.
16522 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16523 since it will not return correct data if people use this
16524 unresolved in the presence of using statements (see test-313).
16526 * class.cs (MethodData.Define): If we are an explicit interface
16527 implementation, set the method name to the full name of the
16528 interface plus the name of the method.
16530 Notice that using the method.MethodName.GetFullName() does not
16531 work, as it will only contain the name as declared on the source
16532 file (it can be a shorthand in the presence of using statements)
16533 and not the fully qualifed type name, for example:
16537 class D : ICloneable {
16538 object ICloneable.Clone () {
16542 Would produce a method called `ICloneable.Clone' instead of
16543 `System.ICloneable.Clone'.
16545 * namespace.cs (Alias.Resolve): Use GetPartialName.
16547 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16549 * cs-parser.jay: Add error 1055 report.
16551 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16553 * assign.cs (Assign.DoResolve): Only do the transform of
16554 assignment into a New if the types are compatible, if not, fall
16555 through and let the implicit code deal with the errors and with
16556 the necessary conversions.
16558 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16560 * cs-parser.jay: Add error 1031 report.
16562 * cs-tokenizer.cs: Add location for error 1038.
16564 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16566 * cs-parser.jay: Add error 1016 report.
16568 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16570 * cs-parser.jay: Add errors 1575,1611 report.
16572 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16574 * cs-parser.jay: Add error 1001 report.
16576 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16579 * attribute.cs (GetMarshal): Add method argument for
16580 caller identification.
16582 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16583 agument for GetMarshal and RuntimeMissingSupport.
16585 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16587 * attribute.cs (ExtractSecurityPermissionSet): Removed
16588 TypeManager.code_access_permission_type.
16590 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16592 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16594 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16595 for obsolete use of a variable here. Fixes regression on errors
16596 cs0619-25 and cs0619-26.
16598 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16600 Fix #62358, implemented security attribute encoding.
16602 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16603 Tests permitted SecurityAction for assembly or other types.
16604 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16605 data from SecurityPermissionAttribute to PermisionSet class.
16607 * class.cs (ApplyAttributeBuilder): Added special handling
16608 for System.Security.Permissions.SecurityAttribute based types.
16610 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16611 special handling for System.Security.Permissions.SecurityAttribute
16614 * enum.cs (ApplyAttributeBuilder): Added special handling
16615 for System.Security.Permissions.SecurityAttribute based types.
16617 * parameter.cs (ApplyAttributeBuilder): Added special handling
16618 for System.Security.Permissions.SecurityAttribute based types.
16620 * rootcontext.cs: Next 2 core types.
16622 * typemanager.cs (TypeManager.security_permission_attr_type):
16623 Built in type for the SecurityPermission Attribute.
16624 (code_access_permission_type): Build in type.
16626 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16628 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16629 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16630 all of this information into
16631 EmitContext.EmitCapturedVariableInstance.
16633 * codegen.cs (EmitCapturedVariableInstance): move here the
16634 funcionality of emitting an ldarg.0 in the presence of a
16635 remapping. This centralizes the instance emit code.
16637 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16638 then emit a load of this: it means that we have reached the
16639 topmost ScopeInfo: the one that contains the pointer to the
16640 instance of the class hosting the anonymous method.
16642 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16643 captures to the topmost CaptureContext.
16645 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16647 * expression.cs (LocalVariableReference): Move the knowledge about
16648 the iterators into codegen's EmitCapturedVariableInstance.
16650 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16652 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16653 all code paths return a value from an anonymous method (it is the
16654 same as the 161 error, but for anonymous methods).
16656 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16658 The introduction of anonymous methods in the compiler changed
16659 various ways of doing things in the compiler. The most
16660 significant one is the hard split between the resolution phase
16661 and the emission phases of the compiler.
16663 For instance, routines that referenced local variables no
16664 longer can safely create temporary variables during the
16665 resolution phase: they must do so from the emission phase,
16666 since the variable might have been "captured", hence access to
16667 it can not be done with the local-variable operations from the runtime.
16671 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16672 is a toplevel block.
16674 (ToplevelBlock): A new kind of Block, these are the blocks that
16675 are created by the parser for all toplevel method bodies. These
16676 include methods, accessors and anonymous methods.
16678 These contain some extra information not found in regular blocks:
16679 A pointer to an optional CaptureContext (for tracking captured
16680 local variables and parameters). A pointer to the parent
16683 (Return.Resolve): Catch missmatches when returning a value from an
16684 anonymous method (error 1662).
16685 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16688 (Break.Resolve): ditto.
16690 (SwitchLabel): instead of defining the labels during the
16691 resolution phase, we now turned the public ILLabel and ILLabelCode
16692 labels into methods called GetILLabelCode() and GetILLabel() that
16693 only define the label during the Emit phase.
16695 (GotoCase): Track the SwitchLabel instead of the computed label
16696 (its contained therein). Emit the code by using
16697 SwitchLabel.GetILLabelCode ().
16699 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16700 whether the Local has been captured or not.
16702 (LocalInfo.IsCaptured): New property, used to tell whether the
16703 local has been captured.
16705 * anonymous.cs: Vastly updated to contain the anonymous method
16708 The main classes here are: CaptureContext which tracks any
16709 captured information for a toplevel block and ScopeInfo used to
16710 track the activation frames for various local variables.
16712 Each toplevel block has an optional capture context associated
16713 with it. When a method contains an anonymous method both the
16714 toplevel method and the anonymous method will create a capture
16715 context. When variables or parameters are captured, they are
16716 recorded on the CaptureContext that owns them, for example:
16720 MyDelegate d = delegate {
16725 Here `a' will be recorded as captured on the toplevel
16726 CapturedContext, the inner captured context will not have anything
16727 (it will only have data if local variables or parameters from it
16728 are captured in a nested anonymous method.
16730 The ScopeInfo is used to track the activation frames for local
16731 variables, for example:
16733 for (int i = 0; i < 10; i++)
16734 for (int j = 0; j < 10; j++){
16735 MyDelegate d = delegate {
16740 At runtime this captures a single captured variable `i', but it
16741 captures 10 different versions of the variable `j'. The variable
16742 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16743 recorded on a child.
16745 The toplevel ScopeInfo will also track information like the `this'
16746 pointer if instance variables were referenced (this is necessary
16747 as the anonymous method lives inside a nested class in the host
16748 type of the method).
16750 (AnonymousMethod): Expanded to track the Toplevel, implement
16751 `AnonymousMethod.Compatible' to tell whether an anonymous method
16752 can be converted to a target delegate type.
16754 The routine now also produces the anonymous method content
16756 (AnonymousDelegate): A helper class that derives from
16757 DelegateCreation, this is used to generate the code necessary to
16758 produce the delegate for the anonymous method that was created.
16760 * assign.cs: API adjustments for new changes in
16761 Convert.ImplicitStandardConversionExists.
16763 * class.cs: Adjustments to cope with the fact that now toplevel
16764 blocks are of type `ToplevelBlock'.
16766 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16767 insteda of standard blocks.
16769 Flag errors if params arguments are passed to anonymous methods.
16771 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16772 `CurrentAnonymousMethod' which points to the current Anonymous
16773 Method. The variable points to the AnonymousMethod class that
16774 holds the code being compiled. It is set in the new EmitContext
16775 created for the anonymous method.
16777 (EmitContext.Phase): Introduce a variable and an enumeration to
16778 assist in enforcing some rules about when and where we are allowed
16779 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16780 only one that enfonces this right now).
16782 (EmitContext.HaveCaptureInfo): new helper method that returns
16783 whether we have a CapturedContext initialized.
16785 (EmitContext.CaptureVariable): New method used to register that a
16786 LocalInfo must be flagged for capturing.
16788 (EmitContext.CapturedParameter): New method used to register that a
16789 parameters must be flagged for capturing.
16791 (EmitContext.CapturedField): New method used to register that a
16792 field must be flagged for capturing.
16794 (EmitContext.HaveCapturedVariables,
16795 EmitContext.HaveCapturedFields): Return whether there are captured
16796 variables or fields.
16798 (EmitContext.EmitMethodHostInstance): This is used to emit the
16799 instance for the anonymous method. The instance might be null
16800 (static methods), this (for anonymous methods that capture nothing
16801 and happen to live side-by-side with the current method body) or a
16802 more complicated expression if the method has a CaptureContext.
16804 (EmitContext.EmitTopBlock): Routine that drives the emission of
16805 code: it will first resolve the top block, then emit any metadata
16806 and then emit the code. The split is done so that we can extract
16807 any anonymous methods and flag any captured variables/parameters.
16809 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16810 during this phase, the ILGenerator should not be used as labels
16811 and local variables declared here might not be accessible to any
16812 code that is part of an anonymous method.
16814 Exceptions to this include the temporary variables that are
16815 created by some statements internally for holding temporary
16818 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16821 (EmitContext.TemporaryReturn): This method is typically called
16822 from the Emit phase, and its the only place where we allow the
16823 ReturnLabel to be defined other than the EmitMeta. The reason is
16824 that otherwise we would have to duplicate a lot of logic in the
16825 Resolve phases of various methods that today is on the Emit
16828 (EmitContext.NeedReturnLabel): This no longer creates the label,
16829 as the ILGenerator is not valid during the resolve phase.
16831 (EmitContext.EmitThis): Extended the knowledge in this class to
16832 work in anonymous methods in addition to iterators.
16834 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16835 code is necessary on the stack to access the instance to a local
16836 variable (the variable will be accessed as a field).
16838 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16839 EmitContext.EmitAddressOfParameter): Routines to support
16840 parameters (not completed at this point).
16842 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16843 will also remove the parameters.
16845 * convert.cs (Convert): Define a `ConstantEC' which points to a
16846 null. This is just to prefity some code that uses
16847 ImplicitStandardConversion code and do not have an EmitContext
16850 The idea is to flag explicitly that at that point in time, it is
16851 known that the conversion will not trigger the delegate checking
16852 code in implicit conversions (which requires a valid
16855 Everywhere: pass new EmitContext parameter since
16856 ImplicitStandardConversionExists now requires it to check for
16857 anonymous method conversions.
16859 (Convert.ImplicitStandardConversionExists): If the type of an
16860 expression is the anonymous_method_type, and the type is a
16861 delegate, we invoke the AnonymousMethod.Compatible method to check
16862 whether an implicit conversion is possible.
16864 (Convert.ImplicitConversionStandard): Only do implicit method
16865 group conversions if the language level is not ISO_1.
16867 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16868 MethodInfo for the Invoke method. used by Delegate and
16871 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16872 method conversions if the target type is a delegate.
16874 Removed extra debugging nops.
16876 (LocalVariableReference): Turn the `local_info' into a public
16879 Add `prepared' field, the same hack used for FieldExprs to cope
16880 with composed assignments, as Local variables do not necessarily
16881 operate purely on the stack as they used to: they can be captured
16884 Add `temp' for a temporary result, like fields.
16886 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16888 It now copes with Local variables that are captured and emits the
16889 proper instance variable to load it from a field in the captured
16892 (ParameterReference.DoResolveBase): During the resolve phase,
16893 capture parameters if we are in an anonymous method.
16895 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16896 anonymous method, use the EmitContext helper routines to emit the
16897 parameter reference.
16899 * iterators.cs: Set RemapToProxy to true/false during the
16902 * parameters.cs (GetParameterByName): New helper method.
16904 * typemanager.cs (anonymous_method_type) a new type that
16905 represents an anonyous method. This is always an internal type,
16906 used as a fencepost to test against the anonymous-methodness of an
16909 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16911 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16913 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16915 2004-10-18 Martin Baulig <martin@ximian.com>
16917 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16918 `Type' directly, but call ResolveType() on it.
16919 (Catch.Resolve): Likewise.
16920 (Foreach.Resolve): Likewise.
16922 2004-10-18 Martin Baulig <martin@ximian.com>
16924 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16925 `Type' directly, but call ResolveType() on it.
16926 (Probe.DoResolve): Likewise.
16927 (ArrayCreation.LookupType): Likewise.
16928 (TypeOf.DoResolve): Likewise.
16929 (SizeOf.DoResolve): Likewise.
16931 2004-10-18 Martin Baulig <martin@ximian.com>
16933 * expression.cs (Invocation.BetterFunction): Put back
16934 TypeManager.TypeToCoreType().
16936 2004-10-18 Raja R Harinath <rharinath@novell.com>
16938 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16941 2004-10-18 Martin Baulig <martin@ximian.com>
16943 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16944 `Type' directly, but call ResolveType() on it.
16946 2004-10-18 Martin Baulig <martin@ximian.com>
16948 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16949 `Type' directly, but call ResolveType() on it.
16950 (MemberBase.DoDefine): Likewise.
16952 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16953 `Type' directly, but call ResolveType() on it.
16954 (ComposedCast.DoResolveAsTypeStep): Likewise.
16956 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16957 `Type' directly, but call ResolveType() on it.
16959 2004-10-17 John Luke <john.luke@gmail.com>
16961 * class.cs (Operator.GetSignatureForError): use CSharpName
16963 * parameter.cs (Parameter.GetSignatureForError): Returns
16964 correct name even if was not defined.
16966 2004-10-13 Raja R Harinath <rharinath@novell.com>
16969 * class.cs (TypeContainer.EmitContext): New property.
16970 (DefineNestedTypes): Create an emitcontext for each part.
16971 (MethodCore.DoDefineParameters): Use container's emitcontext.
16972 Pass type array to InternalParameters.
16973 (MemberBase.DoDefine): Use container's emitcontext.
16974 (FieldMember.Define): Likewise.
16975 (Event.Define): Likewise.
16976 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16977 Pass type array to InternalParameters.
16978 (SetIndexerMethod.GetParameterInfo): Likewise.
16979 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16980 * delegate.cs (Define): Pass emitcontext to
16981 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16982 array to InternalParameters.
16983 * expression.cs (ParameterReference.DoResolveBase): Pass
16984 emitcontext to GetParameterInfo.
16985 (ComposedCast.DoResolveAsTypeStep): Remove check on
16986 ec.ResolvingTypeTree.
16987 * parameter.cs (Parameter.Resolve): Change argument to
16988 EmitContext. Use ResolveAsTypeTerminal.
16989 (Parameter.GetSignature): Change argument to EmitContext.
16990 (Parameters.ComputeSignature): Likewise.
16991 (Parameters.ComputeParameterTypes): Likewise.
16992 (Parameters.GetParameterInfo): Likewise.
16993 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16994 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16995 * support.cs (InternalParameters..ctor): Remove variant that takes
16997 * typemanager.cs (system_intptr_expr): New.
16998 (InitExpressionTypes): Initialize it.
17000 2004-10-12 Chris Toshok <toshok@ximian.com>
17002 * cs-parser.jay: fix location for try_statement and catch_clause.
17004 2004-10-11 Martin Baulig <martin@ximian.com>
17006 * report.cs: Don't make --fatal abort on warnings, we have
17007 -warnaserror for that.
17009 2004-10-07 Raja R Harinath <rharinath@novell.com>
17011 More DeclSpace.ResolveType avoidance.
17012 * decl.cs (MemberCore.InUnsafe): New property.
17013 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
17014 with newly created EmitContext.
17015 (FieldMember.Define): Likewise.
17016 * delegate.cs (Delegate.Define): Likewise.
17017 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
17018 only if normal name-lookup fails.
17019 (TypeExpr.DoResolve): Enable error-checking.
17020 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
17021 (SizeOf.DoResolve): Likewise.
17022 (ComposedCast.DoResolveAsTypeStep): Likewise.
17023 (StackAlloc.DoResolve): Likewise.
17024 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
17025 (Block.Unsafe): New property.
17026 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
17027 (Unsafe): Set 'unsafe' flag of contained block.
17028 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
17029 (Fixed.Resolve): Likewise.
17030 (Catch.Resolve): Likewise.
17031 (Using.ResolveLocalVariableDecls): Likewise.
17032 (Foreach.Resolve): Likewise.
17034 2004-10-05 John Luke <john.luke@gmail.com>
17036 * cs-parser.jay: add location to error CS0175
17038 2004-10-04 Miguel de Icaza <miguel@ximian.com>
17040 * ecore.cs (Expression.Constantity): Add support for turning null
17043 * const.cs (Const.Define): Allow constants to be reference types
17044 as long as the value is Null.
17046 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
17048 * namespace.cs (NamespaceEntry.Using): No matter which warning
17049 level is set, check if this namespace name has already been added.
17051 2004-10-03 Ben Maurer <bmaurer@ximian.com>
17053 * expression.cs: reftype [!=]= null should always use br[true,false].
17056 2004-10-03 Marek Safar <marek.safar@seznam.cz>
17059 * attribute.cs: Enum conversion moved to
17060 GetAttributeArgumentExpression to be applied to the all
17063 2004-10-01 Raja R Harinath <rharinath@novell.com>
17065 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
17066 * class.c (TypeContainer.DefineType): Flag error if
17067 base types aren't accessible due to access permissions.
17068 * decl.cs (DeclSpace.ResolveType): Move logic to
17069 Expression.ResolveAsTypeTerminal.
17070 (DeclSpace.ResolveTypeExpr): Thin layer over
17071 Expression.ResolveAsTypeTerminal.
17072 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
17073 Refactor code into NestedAccess. Use it.
17074 (DeclSpace.NestedAccess): New.
17075 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
17076 argument to silence errors. Check access permissions.
17077 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
17078 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
17079 (Cast.DoResolve): Likewise.
17080 (New.DoResolve): Likewise.
17081 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
17082 (TypeOf.DoResolve): Likewise.
17084 * expression.cs (Invocation.BetterConversion): Return the Type of
17085 the better conversion. Implement section 14.4.2.3 more faithfully.
17086 (Invocation.BetterFunction): Make boolean. Make correspondence to
17087 section 14.4.2.2 explicit.
17088 (Invocation.OverloadResolve): Update.
17089 (Invocation): Remove is_base field.
17090 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
17091 (Invocation.Emit): Likewise.
17093 2004-09-27 Raja R Harinath <rharinath@novell.com>
17095 * README: Update to changes.
17097 2004-09-24 Marek Safar <marek.safar@seznam.cz>
17099 * cs-parser.jay: Reverted 642 warning fix.
17101 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17104 * decl.cs (FindMemberWithSameName): Indexer can have more than
17107 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17109 * expression.cs (LocalVariableReference.DoResolveLValue):
17110 Do not report warning 219 for out values.
17111 (EmptyExpression.Null): New member to avoid extra allocations.
17113 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17115 * cs-parser.jay: Fix wrong warning 642 report.
17117 * cs-tokenizer.cs (CheckNextToken): New helper;
17118 Inspect next character if is same as expected.
17120 2004-09-23 Martin Baulig <martin@ximian.com>
17122 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
17123 (Convert.ImplicitReferenceConversionExists): Likewise.
17125 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17127 * class.cs (Operator.Define): Add error 448 and 559 report.
17129 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17131 * class.cs (MemberBase.IsTypePermitted): New protected
17132 method for checking error CS0610.
17134 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17136 * class.cs (TypeContainer.HasExplicitLayout): New property
17137 Returns whether container has StructLayout attribute set Explicit.
17138 (FieldMember): New abstract class for consts and fields.
17139 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
17140 (Field): Reuse FieldMember.
17142 * const.cs (Const): Reuse FieldMember.
17144 * rootcontext.cs: EmitConstants call moved to class.
17146 2004-09-22 Martin Baulig <martin@ximian.com>
17148 Thanks to Peter Sestoft for this bug report.
17150 * expression.cs (Conditional): If both the `trueExpr' and the
17151 `falseExpr' is a NullLiteral, return a NullLiteral.
17153 2004-09-22 Martin Baulig <martin@ximian.com>
17155 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
17156 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
17157 for the "get_Current" call.
17159 2004-09-22 Martin Baulig <martin@ximian.com>
17161 Marek and me just fixed one of our oldest bugs: #28562 :-)
17163 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
17165 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
17166 we're an EnumConstant, just return that.
17167 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
17168 an EnumConstant. In this case, we need to use GetValueAsEnumType()
17169 to get the value which'll actually be written into the attribute.
17170 However, we have to use GetValue() to access the attribute's value
17173 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17175 * constant.cs (Constant.IsNegative): New abstract property
17178 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
17179 (StackAlloc.DoResolve): Reused IsNegative.
17181 2004-09-21 Martin Baulig <martin@ximian.com>
17183 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17184 if we're used in an iterator, we may be called from different
17187 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17188 we actually have an exception block.
17190 2004-09-20 John Luke <jluke@cfl.rr.com>
17192 * class.cs, cs-parser.jay: Improve the error report for 1520:
17193 report the actual line where the error happens, not where the
17194 class was declared.
17196 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17197 Pass location information that was available elsewhere.
17199 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17201 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17202 runtime to delay sign assemblies.
17204 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17206 * cs-parser.jay: Do not report the stack trace, this is barely
17209 2004-08-22 John Luke <john.luke@gmail.com>
17211 * driver.cs : check that a resource id is not already used
17212 before adding it, report CS1508 if it is, bug #63637
17214 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17216 * ecore.cs: Removed dead code.
17218 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17220 * class.cs: Do not report warning CS0067 on the interfaces.
17222 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17224 * cs-parser.jay: Add error 504 report.
17226 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17228 * rootcontext.cs: WarningLevel is 4 by default now.
17230 * statement.cs (Fixed.Resolve): Do not null
17233 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17236 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17237 deep search when property is not virtual.
17238 (PropertyExpr.ResolveAccessors): Make one call for both
17241 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17244 * statement.cs: Error 152 report constains also location.
17246 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17249 * const.cs: Explicitly set constant as static.
17251 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17254 * cs-parser.jay: Add error 1017 report.
17256 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17258 Fixed bug #59980, #64224
17259 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17261 * typemanager.cs (IsSpecialMethod): Simplified
17263 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17265 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17266 condition with better params.
17268 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17271 * attribute.cs (Resolve): Property has to have both
17274 2004-09-14 Martin Baulig <martin@ximian.com>
17276 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17278 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17281 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17282 called and is obsolete then this member suppress message
17283 when call is inside next [Obsolete] method or type.
17285 * expression.cs: Use TestObsoleteMethodUsage member.
17287 2004-09-14 Martin Baulig <martin@ximian.com>
17289 * cs-parser.jay: Sync a bit with the GMCS version.
17291 2004-09-14 Martin Baulig <martin@ximian.com>
17293 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17294 (CSharpParser.yacc_verbose_flag): New public field.
17296 * genericparser.cs: Removed.
17298 2004-09-14 Raja R Harinath <rharinath@novell.com>
17300 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17302 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17304 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17306 2004-09-10 Martin Baulig <martin@ximian.com>
17308 Backported my MemberName changes from GMCS into MCS.
17310 - we are now using a special `MemberName' class instead of using
17311 strings; in GMCS, the `MemberName' also contains the type
17314 - changed the grammar rules a bit:
17315 * the old `member_name' is now a `namespace_or_type_name':
17316 The rule is that we use `namespace_or_type_name' everywhere
17317 where we expect either a "member name" (GetEnumerator) or a
17318 "member name" with an explicit interface name
17319 (IEnumerable.GetEnumerator).
17320 In GMCS, the explicit interface name may include type arguments
17321 (IEnumerable<T>.GetEnumerator).
17322 * we use `member_name' instead of just `IDENTIFIER' for
17324 The rule is that we use `member_name' wherever a member may
17325 have type parameters in GMCS.
17327 * decl.cs (MemberName): New public class.
17328 (MemberCore.MemberName): New public readonly field.
17329 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17330 (DeclSpace): Likewise.
17332 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17333 * enum.cs (Enum.ctor): Likewise.
17335 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17337 (AliasEntry.ctor): Take a MemberName, not an Expression.
17338 (AliasEntry.UsingAlias): Likewise.
17340 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17341 (IMethodData.MemberName): Changed type from string to MemberName.
17342 (MemberBase.ExplicitInterfaceName): Likewise.
17343 (AbstractPropertyEventMethod.SetupName): Make this private.
17344 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17345 argument; compute the member name here.
17346 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17347 on the `member.MemberName' and the `prefix'.
17349 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17351 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17352 thus, we get a `MemberName' instead of a `string'. These
17353 declarations may have type parameters in GMCS.
17354 (interface_method_declaration, delegate_declaration): Likewise.
17355 (class_declaration, interface_declaration): Likewise.
17356 (method_header): Use `namespace_or_type_name' instead of
17357 `member_name'. We may be an explicit interface implementation.
17358 (property_declaration, event_declaration): Likewise.
17359 (member_name): This is now just an `IDENTIFIER', not a
17360 `namespace_or_type_name'.
17361 (type_name, interface_type): Removed.
17362 (namespace_or_type_name): Return a MemberName, not an Expression.
17363 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17364 call GetTypeExpression() on the MemberName to get an expression.
17365 (IndexerDeclaration.interface_type): Changed type from string to
17367 (MakeName): Operate on MemberName's instead of string's.
17369 2004-09-13 Raja R Harinath <rharinath@novell.com>
17372 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17373 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17374 lookup to avoid symbols introduced by 'using'.
17375 * rootcontext.cs (NamespaceLookup): Update.
17377 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17379 * class.cs (TypeContainer.DoDefineMembers): Do not call
17380 DefineDefaultConstructor for static classes.
17382 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17384 * attribute.cs (Attribute.Resolve): Add error 653 report.
17386 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17388 (Method.ApplyAttributeBuilder): Add error 685 report.
17389 (Operator.Define): Add error 564 report.
17391 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17393 * expression.cs (Invocation.DoResolve): Add error
17394 245 and 250 report.
17396 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17399 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17401 * class.cs (ConstructorInitializer.Resolve):
17402 Wrong error number (515->516).
17404 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17406 * class.cs (Indexer.Define): Add error 631 report.
17408 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17410 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17412 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17414 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17416 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17418 * cs-parser.jay: Added error CS0241 report.
17420 2004-09-10 Raja R Harinath <rharinath@novell.com>
17422 * cs-parser.jay (fixed_statement): Introduce a scope for the
17423 declaration in the 'fixed' statement.
17425 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17427 * cs-parser.jay: Added CS0230 error report.
17429 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17431 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17433 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17435 * expression.cs (Argument.Resolve): Added error CS0192 and
17438 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17440 C# 2.0 #pragma warning feature
17442 * cs-tokenizer.cs (PreProcessPragma): New method;
17443 Handles #pragma directive.
17445 * report.cs (WarningRegions): New class; Support
17446 class for #pragma warning directive. It tests whether
17447 warning is enabled for a given line.
17449 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17451 * const.cs: Add more descriptive error report, tahnks to
17454 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17456 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17458 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17460 * expression.cs: Apply patch from Ben: Remove dead code from
17461 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17462 as that code just threw an exception anwyays.
17464 * const.cs: Remove the call to the turnintoconstant, for details
17467 * literal.cs: The type of the null-literal is the null type; So
17468 we use a placeholder type (literal.cs:System.Null, defined here)
17471 * expression.cs (Conditional.DoResolve): Remove some old code that
17472 is no longer needed, conversions have been fixed.
17474 (ArrayCreationExpression.DoResolve): Return false if we fail to
17475 resolve the inner expression.
17477 2004-09-07 Raja R Harinath <rharinath@novell.com>
17480 * cs-parser.jay (delegate_declaration): Record a delegate
17481 declaration as a type declaration.
17482 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17484 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17486 * parameter.cs: Do not crash if the type can not be resolved.
17488 * expression.cs: Report errors with unsafe pointers, fixes #64896
17490 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17492 * expression.cs: Pointer arith always needs to do a conv.i
17493 if the operand is a long. fix 65320
17495 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17497 Fixed cs0619-37.cs, cs0619-38.cs
17499 * enum.cs (GetObsoleteAttribute): Removed.
17501 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17502 on Enum member is double staged. The first is tested member
17505 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17507 Fixed #56986, #63631, #65231
17509 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17510 adds member to name container.
17511 (TypeContainer.AddToTypeContainer): New method, adds type to
17513 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17514 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17515 AddOperator): Simplified by reusing AddToMemberContainer.
17516 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17518 (Method.CheckForDuplications): Fixed implementation to test all
17520 (MemberBase): Detection whether member is explicit interface
17521 implementation is now in constructor.
17522 (MemberBase.UpdateMemberName): Handles IndexerName.
17523 (Accessor): Changed to keep also location information.
17524 (AbstractPropertyEventMethod): Is derived from MemberCore.
17525 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17526 will be emited or not.
17527 (PropertyBase.AreAccessorsDuplicateImplementation):
17528 Tests whether accessors are not in collision with some method.
17529 (Operator): Is derived from MethodCore to simplify common
17532 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17534 (DeclSpace.AddToContainer): Adds the member to defined_names
17535 table. It tests for duplications and enclosing name conflicts.
17537 * enum.cs (EnumMember): Clean up to reuse the base structures
17539 2004-09-03 Martin Baulig <martin@ximian.com>
17541 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17542 into TypeContainer, to make partial classes work again.
17544 2004-09-03 Martin Baulig <martin@ximian.com>
17546 * rootcontext.cs (RootContext.V2): Removed.
17548 2004-03-23 Martin Baulig <martin@ximian.com>
17550 * expression.cs (Invocation.OverloadResolve): Added `bool
17551 may_fail' argument and use it instead of the Location.IsNull() hack.
17553 2004-09-03 Martin Baulig <martin@ximian.com>
17555 Merged latest changes into gmcs. Please keep this comment in
17556 here, it makes it easier for me to see what changed in MCS since
17557 the last time I merged.
17559 2004-09-03 Raja R Harinath <rharinath@novell.com>
17562 * expression.cs (BetterConversion): Don't allow either conversion
17563 to be null. Remove redundant implicit conversion test when 'q ==
17564 null' -- when this function is invoked, we already know that the
17565 implicit conversion exists.
17566 (BetterFunction): Assume that 'best' is non-null. Remove
17567 redundant reimplementation of IsApplicable when 'best' is null.
17568 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17569 number of arguments.
17570 (IsAncestralType): Extract from OverloadResolve.
17571 (OverloadResolve): Make robust to the MethodGroupExpr being
17572 unsorted. Implement all the logic of Section 14.5.5.1, and
17573 support overloading of methods from multiple applicable types.
17574 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17576 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17577 (RealError, Warning): Append type of report to related symbol.
17579 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17581 * enum.cs: Fixed CLS-Compliance checks for enum members.
17582 Error tests cs3008-8.cs, cs3014-8.cs
17584 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17586 Fixed bug #62342, #63102
17587 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17588 like ImplementMethod.
17590 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17592 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17595 2004-09-02 Martin Baulig <martin@ximian.com>
17597 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17598 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17601 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17603 C# 2.0 Static classes implemented
17605 * class.cs (TypeContainer): instance_constructors,
17606 initialized_fields, initialized_static_fields,
17607 default_constructor, base_inteface_types are protected to be
17608 accessible from StaticClass.
17609 (TypeContainer.DefineDefaultConstructor): New virtual method
17610 for custom default constructor generating
17611 (StaticClass): New class to handle "Static classes" feature.
17613 * cs-parser.jay: Handle static keyword on class like instance
17616 * driver.cs: Added "/langversion" command line switch with two
17617 options (iso-1, default).
17619 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17621 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17623 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17625 * delegate.cs: Style.
17627 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17629 * delegate.cs: Add seperate instance expr field for miguel.
17631 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17633 * PointerArithmetic (Resolve): make sure we are not doing
17634 pointer arith on void*. Also, make sure we are resolved
17635 by not setting eclass until resolve.
17637 All callers: Make sure that PointerArithmetic gets resolved.
17639 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17641 * ArrayCreation (LookupType): If the type does not resolve
17642 to an array, give an error.
17644 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17646 * statement.cs (Try.Resolve): Fixed bug #64222
17648 2004-08-27 Martin Baulig <martin@ximian.com>
17651 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17654 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17656 * ecore.cs (Constantify): Get underlying type via
17657 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17658 Windows in special cases.
17660 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17662 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17663 for obtaining also private methods.
17664 (GetRemoveMethod): Used GetRemoveMethod (true)
17665 for obtaining also private methods.
17667 2004-08-24 Martin Baulig <martin@ximian.com>
17669 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17670 MethodAttributes.HideBySig for operators.
17672 2004-08-23 Martin Baulig <martin@ximian.com>
17674 Back to the old error reporting system :-)
17676 * report.cs (Message): Removed.
17677 (Report.MessageData, ErrorData, WarningData): Removed.
17678 (Report.Error, Warning): Back to the old system.
17680 2004-08-23 Martin Baulig <martin@ximian.com>
17682 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17684 * class.cs (TypeContainer.ParentContainer): New public virtual
17685 method; replaces the explicit interface implementation.
17686 (ClassPart.ParentContainer): Override.
17688 2004-08-23 Martin Baulig <martin@ximian.com>
17690 * statement.cs (Switch): Added support for constant switches; see
17691 #59428 or test-285.cs.
17693 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17696 * statement.cs (GetEnumeratorFilter): Removed useless
17697 logic because C# specs is strict. GetEnumerator must be
17700 2004-08-22 Martin Baulig <martin@ximian.com>
17702 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17703 a switch and may break, reset the barrier. Fixes #59867.
17705 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17707 CLS-Compliance speed up (~5% for corlib)
17709 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17710 New method. Tests container for CLS-Compliant names
17712 * class.cs (TypeContainer.VerifyClsName): New method.
17713 Checks whether container name is CLS Compliant.
17714 (Constructor): Implements IMethodData.
17716 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17717 low-case table for CLS Compliance test.
17718 (MemberCache.VerifyClsParameterConflict): New method.
17719 Checks method parameters for CS3006 error.
17721 * enum.cs (EnumMember): Is derived from MemberCore.
17722 (Enum.VerifyClsName): Optimized for better performance.
17724 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17726 * report.cs: Renamed Error_T to Error and changed all
17729 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17731 * class.cs (TypeContainer.IndexerArrayList): New inner class
17732 container for indexers.
17733 (TypeContainer.DefaultIndexerName): New constant for default
17734 indexer name. Replaced all "Item" with this constant.
17735 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17737 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17738 DefaultMemberAttribute constructor.
17740 2004-08-05 Martin Baulig <martin@ximian.com>
17742 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17745 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17747 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17748 multi platforms problem.
17750 * compiler.csproj: Included shared files.
17752 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17754 Fix bug 60333, 55971 in the more general way
17755 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17756 Added arg_type argument for constant conversion.
17757 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17759 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17762 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17763 OperatorArrayList, MethodCoreArrayList for typecontainer
17764 containers. Changed class member types to these new types.
17765 (MethodArrayList.DefineMembers): Added test for CS0659.
17767 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17769 * cfold.cs: Synchronize the folding with the code in expression.cs
17770 Binary.DoNumericPromotions for uint operands.
17772 * attribute.cs: Revert patch from Raja, it introduced a regression
17773 while building Blam-1.2.1 (hard to isolate a test case).
17775 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17779 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17781 (MethodCore.parent_method): New member. The method we're overriding
17782 if this is an override method.
17783 (MethodCore.CheckBase): Moved from Method class and made common.
17784 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17786 (MethodCore.CheckForDuplications): New abstract method. For custom
17787 member duplication search in a container
17788 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17789 method and its return type.
17790 (Event.conflict_symbol): New member. Symbol with same name in the
17794 (MemberCache.FindMemberWithSameName): New method. The method
17795 is looking for conflict with inherited symbols.
17797 2004-08-04 Martin Baulig <martin@ximian.com>
17799 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17801 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17803 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17805 * report.cs (Message): New enum for better error, warning reference in
17807 (MessageData): New inner abstract class. It generally handles printing of
17808 error and warning messages.
17809 Removed unused Error, Warning, Message methods.
17811 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17813 Fix for cs0592-8.cs test
17815 (Attributable.ValidAttributeTargets): Made public.
17816 (Attribute.ExplicitTarget): New member for explicit target value.
17817 (Attribute.CheckTargets): Now we translate explicit attribute
17818 target to Target here.
17820 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17822 * ecore.cs (MethodGroupExpr): new IsBase property.
17824 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17826 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17827 rather than an instance expr.
17829 (DelegateCreation.Emit): Use the method group rather than
17830 the instance expression. Also, if you have base.Foo as the
17831 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17833 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17835 (NewDelegate.DoResolve): Only check for the existance of Invoke
17836 if the method is going to be needed. Use MethodGroupExpr.
17838 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17840 * expression.cs: For pointer arith., make sure to use
17841 the size of the type, not the size of the pointer to
17844 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17847 * class.cs (Class): Added error CS0502 test.
17849 2004-08-03 John Luke <jluke@cfl.rr.com>
17850 Raja R Harinath <rharinath@novell.com>
17853 * attribute.cs (Attribute.complained_before): New flag.
17854 (Attribute.ResolveType, Attribute.Resolve),
17855 (Attribute.DefinePInvokeMethod): Set it.
17856 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17858 2004-08-03 Martin Baulig <martin@ximian.com>
17860 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17861 use a user-defined operator; we still need to do numeric
17862 promotions in case one argument is a builtin type and the other
17863 one has an implicit conversion to that type. Fixes #62322.
17865 2004-08-02 Martin Baulig <martin@ximian.com>
17867 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17868 (LocalInfo.IsThis): New public property.
17869 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17871 2004-08-01 Martin Baulig <martin@ximian.com>
17873 * class.cs (TypeContainer.GetClassBases): Don't set the default
17874 here since we may get called from GetPartialBases().
17875 (TypeContainer.DefineType): If GetClassBases() didn't return a
17876 parent, use the default one.
17878 2004-07-30 Duncan Mak <duncan@ximian.com>
17880 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17882 2004-07-30 Martin Baulig <martin@ximian.com>
17884 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17886 * class.cs (SourceMethod): New public class, derive from the
17887 symbol writer's ISourceMethod.
17888 (Method): Use the new symbol writer API.
17890 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17891 as argument and use the new symbol writer.
17894 (SourceFile): Implement the symbol writer's ISourceFile.
17895 (Location.SymbolDocument): Removed.
17896 (Location.SourceFile): New public property.
17898 * symbolwriter.cs: Use the new symbol writer API.
17900 2004-07-30 Raja R Harinath <rharinath@novell.com>
17902 * Makefile (install-local): Remove. Functionality moved to
17905 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17907 * Makefile: Install mcs.exe.config file together with mcs.exe.
17908 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17909 correct runtime version.
17911 2004-07-25 Martin Baulig <martin@ximian.com>
17914 (TypeContainer.RegisterOrder): Removed, this was unused.
17915 (TypeContainer, interface_order): Removed.
17916 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17917 TypeContainer as argument since we can also be called with a
17918 `PartialContainer' for a partial class/struct/interface.
17919 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17920 of checking whether we're an `Interface' - we could be a
17921 `PartialContainer'.
17922 (PartialContainer.Register): Override; call
17923 AddClass()/AddStruct()/AddInterface() on our parent.
17925 * cs-parser.jay (interface_member_declaration): Add things to the
17926 `current_container', not the `current_class'.
17928 * rootcontext.cs (RegisterOrder): The overloaded version which
17929 takes an `Interface' was unused, removed.
17931 * typemanager.cs (TypeManager.LookupInterface): Return a
17932 `TypeContainer', not an `Interface'.
17933 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17934 contain a `PartialContainer' for an interface, so check it's
17935 `Kind' to figure out what it is.
17937 2004-07-25 Martin Baulig <martin@ximian.com>
17939 * class.cs (Class.DefaultTypeAttributes): New public constant.
17940 (Struct.DefaultTypeAttributes): Likewise.
17941 (Interface.DefaultTypeAttributes): Likewise.
17942 (PartialContainer.TypeAttr): Override this and add the
17943 DefaultTypeAttributes.
17945 2004-07-25 Martin Baulig <martin@ximian.com>
17947 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17948 we can just use the `Parent' field instead.
17950 2004-07-25 Martin Baulig <martin@ximian.com>
17952 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17954 2004-07-25 Martin Baulig <martin@ximian.com>
17956 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17957 our parts before defining any methods.
17958 (TypeContainer.VerifyImplements): Make this virtual.
17959 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17960 on our PartialContainer.
17962 2004-07-25 Martin Baulig <martin@ximian.com>
17964 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17966 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17967 argument, we can just use the `Parent' field instead.
17970 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17971 (MemberBase.DoDefine): Likewise.
17973 2004-07-24 Martin Baulig <martin@ximian.com>
17975 * decl.cs (MemberCore.Parent): New public field.
17976 (DeclSpace.Parent): Moved to MemberCore.
17978 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17979 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17981 (FieldBase, Field, Operator): Likewise.
17982 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17983 (EventField, Event): Likewise.
17985 2004-07-23 Martin Baulig <martin@ximian.com>
17987 * class.cs (PartialContainer): New public class.
17988 (ClassPart): New public class.
17989 (TypeContainer): Added support for partial classes.
17990 (TypeContainer.GetClassBases): Splitted some of the functionality
17991 out into GetNormalBases() and GetPartialBases().
17993 * cs-tokenizer.cs (Token.PARTIAL): New token.
17994 (Tokenizer.consume_identifier): Added some hacks to recognize
17995 `partial', but only if it's immediately followed by `class',
17996 `struct' or `interface'.
17998 * cs-parser.jay: Added support for partial clases.
18000 2004-07-23 Martin Baulig <martin@ximian.com>
18002 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
18003 a `DeclSpace' and also made it readonly.
18004 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
18005 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
18006 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
18008 * cs-parser.jay: Pass the `current_class', not the
18009 `current_container' (at the moment, this is still the same thing)
18010 to a new Method, Property, Event, Indexer or Constructor.
18012 2004-07-23 Martin Baulig <martin@ximian.com>
18014 * cs-parser.jay (CSharpParser): Added a new `current_class' field
18015 and removed the `current_interface' one.
18016 (struct_declaration, class_declaration, interface_declaration):
18017 Set `current_class' to the newly created class/struct/interface;
18018 set their `Bases' and call Register() before parsing their body.
18020 2004-07-23 Martin Baulig <martin@ximian.com>
18022 * class.cs (Kind): New public enum.
18023 (TypeContainer): Made this class abstract.
18024 (TypeContainer.Kind): New public readonly field.
18025 (TypeContainer.CheckDef): New public method; moved here from
18027 (TypeContainer.Register): New public abstract method.
18028 (TypeContainer.GetPendingImplementations): New public abstract
18030 (TypeContainer.GetClassBases): Removed the `is_class' and
18031 `is_iface' parameters.
18032 (TypeContainer.DefineNestedTypes): Formerly known as
18034 (ClassOrStruct): Made this class abstract.
18036 * tree.cs (RootTypes): New public type.
18038 2004-07-20 Martin Baulig <martin@ximian.com>
18040 * tree.cs (Tree.RecordNamespace): Removed.
18041 (Tree.Namespaces): Removed.
18043 * rootcontext.cs (RootContext.IsNamespace): Removed.
18045 * cs-parser.jay (namespace_declaration): Just create a new
18046 NamespaceEntry here.
18048 2004-07-20 Martin Baulig <martin@ximian.com>
18050 * statement.cs (ExceptionStatement): New abstract class. This is
18051 now used as a base class for everyone who's using `finally'.
18052 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
18053 our local variables before using them.
18055 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
18056 virtual method. This is used by Yield.Resolve() to "steal" an
18057 outer block's `finally' clauses.
18058 (FlowBranchingException): The .ctor now takes an ExceptionStatement
18061 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
18062 version which takes an ExceptionStatement. This version must be
18063 used to create exception branchings.
18066 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
18067 (Iterator.EmitMoveNext): Added exception support; protect the
18068 block with a `fault' clause, properly handle 'finally' clauses.
18069 (Iterator.EmitDispose): Run all the `finally' clauses here.
18071 2004-07-20 Martin Baulig <martin@ximian.com>
18073 * iterator.cs: This is the first of a set of changes in the
18074 iterator code. Match the spec more closely: if we're an
18075 IEnumerable, then GetEnumerator() must be called. The first time
18076 GetEnumerator() is called, it returns the current instance; all
18077 subsequent invocations (if any) must create a copy.
18079 2004-07-19 Miguel de Icaza <miguel@ximian.com>
18081 * expression.cs: Resolve the constant expression before returning
18084 2004-07-19 Martin Baulig <martin@ximian.com>
18086 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
18087 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
18088 the return type of the new EmitContext.
18090 2004-07-18 Martin Baulig <martin@ximian.com>
18092 * class.cs (Property.Define): Fix iterators.
18094 * iterators.cs (Iterator.Define): Moved the
18095 `container.AddInterator (this)' call here from the .ctor; only do
18096 it if we resolved successfully.
18098 2004-07-17 Miguel de Icaza <miguel@ximian.com>
18100 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
18101 `true' for preprocessing directives that we parse. The return
18102 value indicates whether we should return to regular tokenizing or
18103 not, not whether it was parsed successfully.
18105 In the past if we were in: #if false ... #line #endif, we would
18106 resume parsing after `#line'. See bug 61604.
18108 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
18109 building: IsEnumType should return true only for enums, not for
18110 enums or System.Enum itself. This fixes #61593.
18112 Likely what happened is that corlib was wrong: mcs depended on
18113 this bug in some places. The bug got fixed, we had to add the
18114 hack, which caused bug 61593.
18116 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
18117 that was a workaround for the older conditions.
18119 2004-07-16 Ben Maurer <bmaurer@ximian.com>
18121 * assign.cs: IAssignMethod has a new interface, as documented
18122 inline. All assignment code now uses this new api.
18124 * ecore.cs, expression.cs: All classes which implement
18125 IAssignMethod now use the new interface.
18127 * expression.cs (Invocation): add a hack to EmitCall so that
18128 IndexerAccess can be the target of a compound assignment without
18129 evaluating its arguments twice.
18131 * statement.cs: Handle changes in Invocation api.
18133 2004-07-16 Martin Baulig <martin@ximian.com>
18135 * iterators.cs: Rewrote this. We're now using one single Proxy
18136 class for both the IEnumerable and the IEnumerator interface and
18137 `Iterator' derives from Class so we can use the high-level API.
18139 * class.cs (TypeContainer.AddIterator): New method.
18140 (TypeContainer.DoDefineType): New protected virtual method, which
18141 is called from DefineType().
18142 (TypeContainer.DoDefineMembers): Call DefineType() and
18143 DefineMembers() on all our iterators.
18144 (TypeContainer.Emit): Call Emit() on all our iterators.
18145 (TypeContainer.CloseType): Call CloseType() on all our iterators.
18147 * codegen.cs (EmitContext.CurrentIterator): New public field.
18149 2004-07-15 Martin Baulig <martin@ximian.com>
18152 (TypeManager.not_supported_exception_type): New type.
18154 2004-07-14 Martin Baulig <martin@ximian.com>
18156 * iterators.cs: Use real error numbers.
18158 2004-07-14 Martin Baulig <martin@ximian.com>
18160 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
18161 requires this to be a System.Collection.IEnumerable and not a
18162 class implementing that interface.
18163 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
18165 2004-07-13 Marek Safar <marek.safar@seznam.cz>
18167 * class.cs: Fixed previous fix, it broke some error tests.
18169 2004-07-12 Martin Baulig <martin@ximian.com>
18171 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
18174 2004-07-09 Miguel de Icaza <miguel@ximian.com>
18176 * assign.cs (LocalTemporary): Add new argument: is_address,If
18177 `is_address' is true, then the value that we store is the address
18178 to the real value, and not the value itself.
18180 * ecore.cs (PropertyExpr): use the new local temporary
18181 stuff to allow us to handle X.Y += z (where X is a struct)
18183 2004-07-08 Martin Baulig <martin@ximian.com>
18185 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18186 not always return, just like we're doing in Using.Resolve().
18188 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18190 * cs-parser.jay (fixed_statement): flag this as Pinned.
18192 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18194 * typemanager.cs (TypeManager): Removed MakePinned method, this
18195 mechanism is replaced with the .NET 2.x compatible mechanism of
18196 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18198 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18199 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18200 `IsFixed' property which has a different meaning.
18202 2004-07-02 Raja R Harinath <rharinath@novell.com>
18204 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18205 visible from inside a nested class, not just the names of the
18206 immediately enclosing class.
18207 Fix for bug #60730.
18209 2004-06-24 Raja R Harinath <rharinath@novell.com>
18211 * expression.cs (BetterConversion): Remove buggy special-case
18212 handling of "implicit constant expression conversions". At this
18213 point, we already know that the conversion is possible -- we're
18214 only checking to see which is better.
18216 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18218 * cs-parser.jay: Added error CS0210 test.
18220 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18222 * cs-parser.jay: Added error CS0134 test.
18224 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18227 * cs-parser.jay: Added error CS0145 test.
18229 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18231 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18233 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18235 * expression.cs (StackAlloc.Resolve): The argument may not
18236 be a constant; deal with this case.
18238 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18240 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18241 GetIndexerAttributeValue.
18242 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18244 * class.cs (Indexer.Define): Added error tests for CS0415,
18247 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18249 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18252 2004-06-23 Martin Baulig <martin@ximian.com>
18254 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18255 neither return nor throw, reset the barrier as well. Fixes #60457.
18257 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18259 * class.cs : EventAttributes is now set to None by default.
18260 This fixes bug #60459.
18262 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18265 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18266 Don't throw exception but return null (it's sufficient now).
18268 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18270 * typemanager.cs (GetArgumentTypes): Faster implementation.
18272 2004-06-18 Martin Baulig <martin@ximian.com>
18274 * attribute.cs (Attribute.Resolve): Check whether we're an
18275 EmptyCast which a Constant child. Fixes #60333.
18277 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18279 * statement.cs (EmitCollectionForeach): Account for the fact that
18280 not all valuetypes are in areas which we can take the address of.
18281 For these variables, we store to a temporary variable. Also, make
18282 sure that we dont emit a `callvirt' on a valuetype method.
18284 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18286 * expression.cs (StackAlloc.DoReSolve): Added test for
18287 negative parameter (CS0247).
18289 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18292 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18294 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18297 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18300 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18302 Fix bug #58254 & cs1555.cs, cs1556.cs
18303 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18305 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18307 * cs-parser.jay: Added error CS1669 test for indexers.
18309 2004-06-11 Martin Baulig <martin@ximian.com>
18311 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18312 call this twice: for params and varargs methods.
18314 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18317 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18319 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18321 * attribute.cs (Attribute.GetValidTargets): Made public.
18324 (AbstractPropertyEventMethod): New class for better code sharing.
18325 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18327 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18329 2004-06-11 Raja R Harinath <rharinath@novell.com>
18332 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18333 that the call to Resolve is part of a MemberAccess.
18334 (Expression.Resolve): Use it for SimpleName resolution.
18335 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18336 Add 'intermediate' boolean argument.
18337 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18338 error message when the SimpleName can be resolved ambiguously
18339 between an expression and a type.
18340 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18342 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18343 call on the left-side.
18345 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18348 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18350 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18352 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18354 2004-06-11 Martin Baulig <martin@ximian.com>
18356 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18357 varargs methods if applicable.
18359 2004-06-11 Martin Baulig <martin@ximian.com>
18361 * expression.cs (Invocation.EmitCall): Don't use
18362 `method.CallingConvention == CallingConventions.VarArgs' since the
18363 method could also have `CallingConventions.HasThis'.
18365 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18367 * class.cs (Event.GetSignatureForError): Implemented.
18368 Fixed crash in error test cs3010.cs
18370 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18372 * cs-tokenizer.cs: Change the way we track __arglist to be
18373 consistent with the other keywords.
18375 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18377 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18380 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18382 * codegen.cs: Check that all referenced assemblies have a strongname
18383 before strongnaming the compiled assembly. If not report error CS1577.
18384 Fix bug #56563. Patch by Jackson Harper.
18385 * typemanager.cs: Added a method to return all referenced assemblies.
18386 Fix bug #56563. Patch by Jackson Harper.
18388 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18391 (Method.ApplyAttributeBuilder): Moved and added conditional
18392 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18395 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18397 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18400 * class.cs: (EventField.attribute_targets): Changed default target.
18402 2004-06-08 Martin Baulig <martin@ximian.com>
18404 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18406 2004-06-08 Martin Baulig <martin@ximian.com>
18408 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18410 2004-06-07 Martin Baulig <martin@ximian.com>
18412 Added support for varargs methods.
18414 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18417 * cs-parser.jay: Added support for `__arglist'.
18419 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18421 * expression.cs (Argument.AType): Added `ArgList'.
18422 (Invocation): Added support for varargs methods.
18423 (ArglistAccess): New public class.
18424 (Arglist): New public class.
18426 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18428 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18429 a method's top-level block if the method has varargs.
18431 * support.cs (ReflectionParameters, InternalParameters): Added
18432 support for varargs methods.
18434 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18436 * class.cs: Provide location in indexer error report.
18438 * driver.cs: Use standard names.
18440 * namespace.cs: Catch the use of using after a namespace has been
18441 declared also on using aliases.
18443 2004-06-03 Raja R Harinath <rharinath@novell.com>
18446 * typemanager.cs (closure_private_ok, closure_invocation_type)
18447 (closure_qualifier_type, closure_invocation_assembly)
18448 (FilterWithClosure): Move to ...
18449 (Closure): New internal nested class.
18450 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18451 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18452 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18453 (MemberLookup, MemberLookupFailed): Use it.
18454 * expression.cs (New.DoResolve): Treat the lookup for the
18455 constructor as being qualified by the 'new'ed type.
18456 (Indexers.GetIndexersForTypeOrInterface): Update.
18458 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18461 (GetConditionalAttributeValue): New method. Returns
18462 condition of ConditionalAttribute.
18463 (SearchMulti): New method. Returns all attributes of type 't'.
18464 Use it when attribute is AllowMultiple = true.
18465 (IsConditionalMethodExcluded): New method.
18468 (Method.IsExcluded): Implemented. Returns true if method has conditional
18469 attribute and the conditions is not defined (method is excluded).
18470 (IMethodData): Extended interface for ConditionalAttribute support.
18471 (PropertyMethod.IsExcluded): Implemented.
18474 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18477 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18480 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18482 * expression.cs (ArrayCreationExpression): Make this just an
18483 `expression'. It can't be a statement, so the code here was
18486 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18489 * typemanager.cs (GetFullNameSignature): New method for
18492 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18495 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18496 Use this method when MethodBuilder is null.
18497 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18498 Added test for error CS0626 (MONO reports error for this situation).
18499 (IMethodData.GetSignatureForError): Extended interface.
18501 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18504 (AttributeTester.GetObsoleteAttribute): Returns instance of
18505 ObsoleteAttribute when type is obsolete.
18508 (TypeContainer.VerifyObsoleteAttribute): Override.
18509 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18510 (MethodCode.VerifyObsoleteAttribute): Override.
18511 (MemberBase.VerifyObsoleteAttribute): Override.
18514 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18515 and report proper error.
18518 Delegate.VerifyObsoleteAttribute): Override.
18521 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18522 and report proper error.
18523 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18526 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18530 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18531 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18532 Added test for ObsoleteAttribute.
18535 (Catch): Derived from Statement.
18537 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18539 Fixed bug #59071 & cs0160.cs
18541 * statement.cs (Try.Resolve): Check here whether order of catch
18542 clauses matches their dependencies.
18544 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18546 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18547 caused a regression: #59343. Referencing nested classes from an
18548 assembly stopped working.
18550 2004-05-31 Martin Baulig <martin@ximian.com>
18552 MCS is now frozen for beta 2.
18554 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18556 * convert.cs: add a trivial cache for overload operator resolution.
18558 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18560 * decl.cs: If possible, use lookuptypedirect here. We can only do
18561 this if there is no `.' after the namespace. Avoids using
18562 LookupType, which does lots of slow processing.
18563 (FindNestedType) New method, does what it says :-).
18564 * namespace.cs: use LookupTypeDirect.
18565 * rootcontext.cs: use membercache, if possible.
18566 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18568 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18571 According to the spec,
18573 In a member access of the form E.I, if E is a single identifier,
18574 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18575 field, property, localvariable, or parameter with the same type as
18576 the meaning of E as a type-name (§3.8), then both possible
18577 meanings of E are permitted.
18579 We did not check that E as a simple-name had the same type as E as
18582 This trivial check gives us 5-7% on bootstrap time.
18584 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18586 * expression.cs (Invocation.OverloadResolve): Avoid the
18587 use of hashtables and boxing here by allocating on demand.
18589 2004-05-30 Martin Baulig <martin@ximian.com>
18591 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18592 we're doing a silent lookup. Don't try to lookup nested types in
18593 TypeManager.object_type (thanks to Ben Maurer).
18595 2004-05-30 Martin Baulig <martin@ximian.com>
18597 Committing a patch from Ben Maurer.
18599 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18601 2004-05-29 Martin Baulig <martin@ximian.com>
18603 * class.cs (IMethodData.ShouldIgnore): New method.
18605 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18606 `Location' argument, we don't need it anywhere. Use
18607 `IMethodData.ShouldIgnore ()' instead of
18608 `MethodData.GetMethodFlags ()'.
18609 (TypeManager.AddMethod): Removed.
18610 (TypeManager.AddMethod2): Renamed to AddMethod.
18612 2004-05-29 Martin Baulig <martin@ximian.com>
18614 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18616 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18617 converting from a class type S to an interface type and we already
18618 have an object on the stack, don't box it again. Fixes #52578.
18620 2004-05-29 Martin Baulig <martin@ximian.com>
18622 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18623 Added support for `params' parameters. Fixes #59267.
18625 2004-05-29 Martin Baulig <martin@ximian.com>
18627 * literal.cs (NullPointer): Provide a private .ctor which sets
18628 `type' to TypeManager.object_type. Fixes #59048.
18630 2004-05-29 Martin Baulig <martin@ximian.com>
18632 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18633 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18635 * ecore.cs (EventExpr.instance_expr): Make the field private.
18637 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18639 Fixed bug #50080 & cs0214-2.cs
18640 * expression.cs (Cast.DoResolve): Check unsafe context here.
18642 * statement.cs (Resolve.DoResolve): Likewise.
18644 2004-05-26 Martin Baulig <martin@ximian.com>
18646 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18648 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18649 (RootContext.LookupType): Pass down the `silent' flag.
18651 2004-05-25 Martin Baulig <martin@ximian.com>
18654 (MethodGroupExpr.IdenticalTypeName): New public property.
18655 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18656 expression actually refers to a type.
18658 2004-05-25 Martin Baulig <martin@ximian.com>
18660 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18661 for #56176 and made it actually work.
18663 2004-05-25 Martin Baulig <martin@ximian.com>
18665 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18666 (FieldExpr, PropertyExpr): Override and implement
18667 CacheTemporaries. Fixes #52279.
18669 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18671 * location.cs: In the new compiler listing a file twice is a
18672 warning, not an error.
18674 2004-05-24 Martin Baulig <martin@ximian.com>
18676 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18677 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18679 2004-05-24 Martin Baulig <martin@ximian.com>
18681 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18682 walking the `using' list. Fixes #53921.
18684 2004-05-24 Martin Baulig <martin@ximian.com>
18686 * const.cs (Const.LookupConstantValue): Added support for
18687 EmptyCast's; fixes #55251.
18689 2004-05-24 Martin Baulig <martin@ximian.com>
18691 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18692 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18693 which does the CS0135 check. The reason is that we first need to
18694 check whether the variable actually exists.
18696 2004-05-24 Martin Baulig <martin@ximian.com>
18698 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18699 than RootContext.LookupType() to find the explicit interface
18700 type. Fixes #58584.
18702 2004-05-24 Raja R Harinath <rharinath@novell.com>
18704 * Makefile: Simplify. Use executable.make.
18705 * mcs.exe.sources: New file. List of sources of mcs.exe.
18707 2004-05-24 Anders Carlsson <andersca@gnome.org>
18711 Use the invariant culture when doing String.Compare for CLS case
18714 2004-05-23 Martin Baulig <martin@ximian.com>
18716 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18717 don't have any dots. Fixes #52622, added cs0246-8.cs.
18719 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18721 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18723 * class.cs (MemberBase.Define): Reuse MemberType member for
18724 resolved type. Other methods can use it too.
18726 2004-05-23 Martin Baulig <martin@ximian.com>
18728 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18729 the variable also exists in the current block (otherwise, we need
18730 to report a CS0103). Fixes #58670.
18732 2004-05-23 Martin Baulig <martin@ximian.com>
18734 * flowanalysis.cs (Reachability.Reachable): Compute this
18735 on-the-fly rather than storing it as a field.
18737 2004-05-23 Martin Baulig <martin@ximian.com>
18739 * flowanalysis.cs (Reachability.And): Manually compute the
18740 resulting `barrier' from the reachability.
18742 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18745 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18746 instance of ObsoleteAttribute when symbol is obsolete.
18749 (IMethodData): Extended interface for ObsoleteAttribute support.
18751 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18753 * attribute.cs: Fix bug #55970
18755 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18759 (GetObsoleteAttribute): New method. Creates the instance of
18761 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18762 ObsoleteAttribute when member is obsolete.
18763 (AttributeTester.Report_ObsoleteMessage): Common method for
18764 Obsolete error/warning reporting.
18767 (TypeContainer.base_classs_type): New member for storing parent type.
18770 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18771 for this MemberCore.
18773 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18775 * attribute.cs, const.cs: Fix bug #58590
18777 2004-05-21 Martin Baulig <martin@ximian.com>
18779 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18780 out parameters if the end of the method is unreachable. Fixes
18783 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18785 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18786 Hari was right, why extra method.
18788 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18790 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18792 2004-05-20 Martin Baulig <martin@ximian.com>
18794 Merged this back from gmcs to keep the differences to a minumum.
18796 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18797 instead of a Declspace.
18798 (Attribute.ResolveType): Likewise.
18799 (Attributes.Search): Likewise.
18800 (Attributes.Contains): Likewise.
18801 (Attributes.GetClsCompliantAttribute): Likewise.
18803 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18805 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18808 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18810 Fix bug #58688 (MCS does not report error when the same attribute
18813 * attribute.cs (Attribute.Emit): Distinction between null and default.
18815 2004-05-19 Raja R Harinath <rharinath@novell.com>
18817 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18818 of a top-level attribute without an attribute target.
18819 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18821 (Attribute.Conditional_GetConditionName),
18822 (Attribute.Obsolete_GetObsoleteMessage): Update.
18823 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18824 part of ScanForIndexerName.
18825 (Attribute.CanIgnoreInvalidAttribute): New function.
18826 (Attribute.ScanForIndexerName): Move to ...
18827 (Attributes.ScanForIndexerName): ... here.
18828 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18829 (Attributes.Search): New internal variant that can choose not to
18830 complain if types aren't resolved. The original signature now
18832 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18833 complaints suppressed.
18834 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18835 only if it not useful.
18836 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18837 top-level for attributes that are shared between the assembly
18838 and a top-level class.
18839 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18840 * class.cs: Update to reflect changes.
18841 (DefineIndexers): Fuse loops.
18842 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18843 a couple more variants of attribute names.
18845 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18847 Fix bug #52585 (Implemented explicit attribute declaration)
18850 (Attributable.ValidAttributeTargets): New abstract method. It gets
18851 list of valid attribute targets for explicit target declaration.
18852 (Attribute.Target): It holds target itself.
18853 (AttributeSection): Removed.
18854 (Attribute.CheckTargets): New method. It checks whether attribute
18855 target is valid for the current element.
18858 (EventProperty): New class. For events that are declared like
18859 property (with add and remove accessors).
18860 (EventField): New class. For events that are declared like field.
18863 * cs-parser.jay: Implemented explicit attribute target declaration.
18865 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18866 Override ValidAttributeTargets.
18869 (ReturnParameter): Class for applying custom attributes on
18871 (ParameterAtribute): New class. Class for applying custom
18872 attributes on the parameter type.
18874 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18876 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18879 (Method): Allow UNSAFE here.
18881 * modifiers.cs: Support unsafe reporting.
18883 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18885 * decl.cs: Fix bug #58478.
18887 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18889 * statement.cs: When checking for unreachable code on an EmptyStatement,
18890 set the location. Fixes bug #58488.
18892 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18894 * driver.cs: Add -pkg handling.
18896 From Gonzalo: UseShelLExecute=false
18898 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18901 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18903 (Attribute.IsClsCompliaceRequired): Moved to base for better
18905 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18906 when attribute is AttributeUsageAttribute.
18907 (Attribute.GetValidTargets): Simplified.
18908 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18909 attribute for this type.
18910 (Attribute.ApplyAttributes): Method renamed to Emit and make
18912 (GlobalAttributeSection): New class for special handling of global
18913 attributes (assembly, module).
18914 (AttributeSection.Emit): New method.
18916 * class.cs: Implemented Attributable abstract methods.
18917 (MethodCore.LabelParameters): Moved to Parameter class.
18918 (Accessor): Is back simple class.
18919 (PropertyMethod): Implemented Attributable abstract class.
18920 (DelegateMethod): Implemented Attributable abstract class.
18921 (Event): New constructor for disctintion between normal Event
18922 and Event with accessors.
18924 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18926 * codegen.cs, const.cs, decl.cs, delegate.cs:
18927 (CommonAssemblyModulClass): Implemented Attributable abstract class
18930 * enum.cs: Implement IAttributeSupport interface.
18931 (EnumMember): New class for emum members. Implemented Attributable
18935 (ParameterBase): Is abstract.
18936 (ReturnParameter): New class for easier [return:] attribute handling.
18938 * typemanager.cs: Removed builder_to_attr.
18940 2004-05-11 Raja R Harinath <rharinath@novell.com>
18943 * attribute.cs (Attribute.GetPositionalValue): New function.
18944 * class.cs (TypeContainer.VerifyMembers): New function.
18945 (TypeContainer.Emit): Use it.
18946 (ClassOrStruct): New base class for Class and Struct.
18947 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18948 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18950 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18951 then each non-static field should have a FieldOffset attribute.
18952 Otherwise, none of the fields should have a FieldOffset attribute.
18953 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18954 and FieldOffset attributes.
18955 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18956 (TypeManager.field_offset_attribute_type): New core types.
18957 (TypeManager.InitCoreTypes): Initialize them.
18959 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18961 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18962 Return correct type.
18965 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18967 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18968 be implicitly converted to ulong.
18970 * expression.cs: The logic for allowing operator &, | and ^ worked
18971 was wrong, it worked before because we did not report an error in
18972 an else branch. Fixes 57895.
18974 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18975 allow volatile fields to be reference types.
18977 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18979 * driver.cs: Add support for /debug-
18981 2004-05-07 Raja R Harinath <rharinath@novell.com>
18983 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18984 Add a 'complain' parameter to silence errors.
18985 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18986 silently overlooked type-resolutions.
18987 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18988 to reflect changes.
18989 (Attributes.Search): New function.
18990 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18991 (Attributes.GetAttributeFullName): Remove hack.
18992 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18993 Update to reflect changes.
18994 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18995 Use Attributes.Search instead of nested loops.
18997 2004-05-07 Marek Safar <marek.safar@seznam.cz>
19000 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
19001 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
19002 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
19004 * report.cs: (Report.Warning): Renamed to Warning_T because of
19005 parameter collision.
19007 2004-05-05 Raja R Harinath <rharinath@novell.com>
19009 * expression.cs (MemberAccess.ResolveMemberAccess):
19010 Exit with non-zero status after Report.Error.
19011 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
19013 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
19015 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19017 * support.cs: Don't hang when the file is empty.
19019 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19021 * support.cs: In SeekableStreamReader, compute the preamble size of the
19022 underlying stream. Position changes should take into account that initial
19025 2004-05-03 Todd Berman <tberman@sevenl.net>
19027 * driver.cs: remove unused GetSysVersion function.
19029 2004-05-03 Todd Berman <tberman@sevenl.net>
19031 * driver.cs: Remove the hack from saturday, as well as the hack
19032 from jackson (LoadAssemblyFromGac), also adds the CWD to the
19033 link_paths to get that bit proper.
19035 2004-05-01 Todd Berman <tberman@sevenl.net>
19037 * driver.cs: Try a LoadFrom before a Load, this checks the current
19038 path. This is currently a bug in mono that is be fixed, however, this
19039 provides a workaround for now. This will be removed when the bug
19042 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
19044 * CryptoConvert.cs: Updated to latest version. Fix issue with
19045 incomplete key pairs (#57941).
19047 2004-05-01 Todd Berman <tberman@sevenl.net>
19049 * driver.cs: Remove '.' from path_chars, now System.* loads properly
19052 2004-04-30 Jackson Harper <jackson@ximian.com>
19054 * codegen.cs: Open keys readonly.
19056 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19058 * typemanager.cs: don't report cyclic struct layout when a struct
19059 contains 2 or more fields of the same type. Failed for Pango.AttrShape
19060 which has 2 Pango.Rectangle fields.
19062 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
19064 * expression.cs: Handle IntPtr comparisons with IL code
19065 rather than a method call.
19067 2004-04-29 Martin Baulig <martin@ximian.com>
19069 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
19070 the list of PropertyInfo's in class hierarchy and find the
19071 accessor. Fixes #56013.
19073 2004-04-29 Martin Baulig <martin@ximian.com>
19075 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
19077 2004-04-29 Martin Baulig <martin@ximian.com>
19079 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19081 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
19083 2004-04-29 Martin Baulig <martin@ximian.com>
19085 * class.cs (ConstructorInitializer.Resolve): Check whether the
19086 parent .ctor is accessible. Fixes #52146.
19088 2004-04-29 Martin Baulig <martin@ximian.com>
19090 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19092 * statement.cs (Using.EmitLocalVariableDecls): Use
19093 TypeManager.idisposable_type, not typeof (IDisposable).
19094 (Foreach.EmitCollectionForeach): Added support for valuetypes.
19096 2004-04-29 Martin Baulig <martin@ximian.com>
19098 * class.cs (Event.Define): Don't emit the field and don't set
19099 RTSpecialName and SpecialName for events on interfaces. Fixes
19102 2004-04-29 Raja R Harinath <rharinath@novell.com>
19104 Refactor Attribute.ApplyAttributes.
19105 * attribute.cs (Attributable): New base class for objects that can
19106 have Attributes applied on them.
19107 (Attribute): Make AttributeUsage fields public.
19108 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
19109 (Attribute.IsInternalCall): New property.
19110 (Attribute.UsageAttr): Convert to a public read-only property.
19111 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
19112 (Attribute.ResolveType, Attribute.Resolve)
19113 (Attribute.ScanForIndexerName): Update to reflect changes.
19114 (Attribute.CheckAttributeTarget): Re-format.
19115 (Attribute.ApplyAttributes): Refactor, to various
19116 Attributable.ApplyAttributeBuilder methods.
19117 * decl.cs (MemberCore): Make Attributable.
19118 * class.cs (Accessor): Make Attributable.
19119 (MethodData.ApplyAttributes): Use proper attribute types, not
19121 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
19122 (TypeContainer.ApplyAttributeBuilder)
19123 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
19124 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
19125 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
19126 (Operator.ApplyAttributeBuilder): New factored-out methods.
19127 * const.cs (Const.ApplyAttributeBuilder): Likewise.
19128 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
19129 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
19130 * parameter.cs (ParameterBase): New Attributable base class
19131 that can also represent Return types.
19132 (Parameter): Update to the changes.
19134 2004-04-29 Jackson Harper <jackson@ximian.com>
19136 * driver.cs: Prefer the corlib system version when looking for
19137 assemblies in the GAC. This is still a hack, but its a better hack
19140 2004-04-29 Marek Safar <marek.safar@seznam.cz>
19142 * decl.cs, enum.cs: Improved error 3005 reporting.
19144 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
19145 (related_symbols): New private member for list of symbols
19146 related to reported error/warning.
19148 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
19150 2004-04-29 Martin Baulig <martin@ximian.com>
19152 * ecore.cs (Expression.Constantify): If we're an enum and
19153 TypeManager.TypeToCoreType() doesn't give us another type, use
19154 t.UnderlyingSystemType. Fixes #56178.
19156 2004-04-29 Martin Baulig <martin@ximian.com>
19158 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
19159 interfaces and for each interface, only add members directly
19160 declared in that interface. Fixes #53255.
19162 2004-04-28 Martin Baulig <martin@ximian.com>
19164 * expression.cs (ConditionalLogicalOperator): Use a temporary
19165 variable for `left' to avoid that we evaluate it more than once;
19168 2004-04-28 Martin Baulig <martin@ximian.com>
19170 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
19173 2004-04-28 Martin Baulig <martin@ximian.com>
19175 * statement.cs (LocalInfo.Resolve): Check whether the type is not
19178 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
19179 whether the type is not void (CS1547).
19181 2004-04-28 Martin Baulig <martin@ximian.com>
19183 * expression.cs (Unary.DoResolveLValue): Override this and report
19184 CS0131 for anything but Operator.Indirection.
19186 2004-04-28 Martin Baulig <martin@ximian.com>
19188 Committing a patch from Ben Maurer; see bug #50820.
19190 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19193 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19196 2004-04-28 Martin Baulig <martin@ximian.com>
19198 Committing a patch from Ben Maurer; see bug #50820.
19200 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19203 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19206 2004-04-28 Martin Baulig <martin@ximian.com>
19208 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19209 (Block.AddLabel): Call DoLookupLabel() to only search in the
19212 2004-04-28 Martin Baulig <martin@ximian.com>
19214 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19215 comparing StringConstants and NullLiterals in Equality and Inequality.
19217 2004-04-28 Jackson Harper <jackson@ximian.com>
19219 * driver.cs: Attempt to load referenced assemblies from the
19220 GAC. This is the quick and dirty version of this method that
19221 doesnt take into account versions and just takes the first
19222 canidate found. Will be good enough for now as we will not have more
19223 then one version installed into the GAC until I update this method.
19225 2004-04-28 Martin Baulig <martin@ximian.com>
19227 * typemanager.cs (TypeManager.CheckStructCycles): New public
19228 static method to check for cycles in the struct layout.
19230 * rootcontext.cs (RootContext.PopulateTypes): Call
19231 TypeManager.CheckStructCycles() for each TypeContainer.
19232 [Note: We only need to visit each type once.]
19234 2004-04-28 Martin Baulig <martin@ximian.com>
19236 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19238 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19239 success and added `out object value'. Use a `bool resolved' field
19240 to check whether we've already been called rather than
19241 `ConstantValue != null' since this breaks for NullLiterals.
19243 2004-04-28 Raja R Harinath <rharinath@novell.com>
19245 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19246 setting of this flag, since the 'set' method may be non-public.
19248 2004-04-28 Raja R Harinath <rharinath@novell.com>
19250 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19251 check on current_vector.Block.
19253 2004-04-27 Martin Baulig <martin@ximian.com>
19255 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19256 a field initializer. Fixes #56459.
19258 2004-04-27 Martin Baulig <martin@ximian.com>
19260 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19261 we're not attempting to use an indexer. Fixes #52154.
19263 2004-04-27 Martin Baulig <martin@ximian.com>
19265 * statement.cs (Return): Don't create a return label if we don't
19266 need it; reverts my change from January 20th. Thanks to Ben
19269 2004-04-27 Martin Baulig <martin@ximian.com>
19271 According to the spec, `goto' can only leave a nested scope, but
19274 * statement.cs (Block.LookupLabel): Only lookup in the current
19275 block, don't recurse into parent or child blocks.
19276 (Block.AddLabel): Check in parent and child blocks, report
19277 CS0140/CS0158 if we find a duplicate.
19278 (Block): Removed this indexer for label lookups.
19279 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19280 this already does the error reporting for us.
19283 (FlowBranching.UsageVector.Block): New public variable; may be null.
19284 (FlowBranching.CreateSibling): Added `Block' argument.
19285 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19286 label for the target of a `goto' and check whether we're not
19287 leaving a `finally'.
19289 2004-04-27 Martin Baulig <martin@ximian.com>
19291 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19292 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19295 2004-04-27 Martin Baulig <martin@ximian.com>
19297 * statement.cs (Block.AddLabel): Also check for implicit blocks
19298 and added a CS0158 check.
19300 2004-04-27 Martin Baulig <martin@ximian.com>
19302 * flowanalysis.cs (FlowBranchingLoop): New class.
19303 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19304 UsageVector's instead of an ArrayList.
19305 (FlowBranching.Label): Likewise.
19306 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19307 (FlowBranching.AddBreakVector): New method.
19309 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19311 * attribute.cs: Small regression fix: only convert the type if we
19312 the type is different, fixes System.Drawing build.
19314 2004-04-27 Martin Baulig <martin@ximian.com>
19316 * attribute.cs (Attribute.Resolve): If we have a constant value
19317 for a named field or property, implicity convert it to the correct
19320 2004-04-27 Raja R Harinath <rharinath@novell.com>
19322 * statement.cs (Block.Block): Implicit blocks share
19323 'child_variable_names' fields with parent blocks.
19324 (Block.AddChildVariableNames): Remove.
19325 (Block.AddVariable): Mark variable as "used by a child block" in
19326 every surrounding block.
19327 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19328 been used in a child block, complain about violation of "Invariant
19329 meaning in blocks" rule.
19330 * cs-parser.jay (declare_local_variables): Don't use
19331 AddChildVariableNames.
19332 (foreach_statement): Don't create an implicit block: 'foreach'
19333 introduces a scope.
19335 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19337 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19338 converting from 0L to ulong. Fixes 57522.
19340 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19342 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19343 derived class hides via 'new' keyword field from base class (test-242.cs).
19344 TODO: Handle this in the more general way.
19346 * class.cs (CheckBase): Ditto.
19348 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19350 * decl.cs (caching_flags): New member for storing cached values
19352 (MemberCore.Flags): New enum where bit flags for caching_flags
19354 (MemberCore.cls_compliance): Moved to caching_flags.
19355 (DeclSpace.Created): Moved to caching_flags.
19357 * class.cs: Use caching_flags instead of DeclSpace.Created
19359 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19361 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19362 if we are only a derived class, not a nested class.
19364 * typemanager.cs: Same as above, but do this at the MemberLookup
19365 level (used by field and methods, properties are handled in
19366 PropertyExpr). Allow for the qualified access if we are a nested
19369 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19371 * class.cs: Refactoring.
19372 (IMethodData): New inteface; Holds links to parent members
19373 to avoid member duplication (reduced memory allocation).
19374 (Method): Implemented IMethodData interface.
19375 (PropertyBase): New inner classes for get/set methods.
19376 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19377 (Event): New inner classes for add/remove methods.
19378 (Event.DelegateMethod): Implemented IMethodData interface.
19380 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19381 EmitContext (related to class.cs refactoring).
19383 2004-04-21 Raja R Harinath <rharinath@novell.com>
19385 * delegate.cs (Delegate.VerifyApplicability): If the number of
19386 arguments are the same as the number of parameters, first try to
19387 verify applicability ignoring any 'params' modifier on the last
19391 2004-04-16 Raja R Harinath <rharinath@novell.com>
19393 * class.cs (TypeContainer.AddIndexer): Use
19394 'ExplicitInterfaceName' to determine if interface name was
19395 explicitly specified. 'InterfaceType' is not initialized at this time.
19396 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19397 Indexers array is already in the required order. Initialize
19398 'IndexerName' only if there are normal indexers.
19399 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19400 (TypeContainer.Emit): Emit DefaultMember attribute only if
19401 IndexerName is initialized.
19404 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19406 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19409 2004-04-15 Raja R Harinath <rharinath@novell.com>
19411 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19415 * attribute.cs (Attribute.Resolve): Check for duplicate named
19419 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19421 * iterators.cs (MarkYield): track whether we are in an exception,
19422 and generate code accordingly. Use a temporary value to store the
19423 result for our state.
19425 I had ignored a bit the interaction of try/catch with iterators
19426 since their behavior was not entirely obvious, but now it is
19427 possible to verify that our behavior is the same as MS .NET 2.0
19431 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19433 * iterators.cs: Avoid creating temporaries if there is no work to
19436 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19437 Enumerations, use TypeManager.EnumToUnderlying and call
19440 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19443 (This.Emit): Use EmitContext.EmitThis to emit our
19446 (This.EmitAssign): Ditto.
19448 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19449 codepaths, we will move all the functionality into
19452 (FieldExpr.EmitAssign): Ditto.
19454 This fixes several hidden bugs that I uncovered while doing a code
19455 review of this today.
19457 * codegen.cs (EmitThis): reworked so the semantics are more clear
19458 and also support value types "this" instances.
19460 * iterators.cs: Changed so that for iterators in value types, we
19461 do not pass the value type as a parameter.
19463 Initialization of the enumerator helpers is now done in the caller
19464 instead of passing the parameters to the constructors and having
19465 the constructor set the fields.
19467 The fields have now `assembly' visibility instead of private.
19469 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19471 * expression.cs (Argument.Resolve): Check if fields passed as ref
19472 or out are contained in a MarshalByRefObject.
19474 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19475 another compiler type.
19477 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19479 * class.cs (Indexer.Define): use the new name checking method.
19480 Also, return false on an error.
19481 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19482 (is_identifier_[start/part]_character): make static.
19484 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19486 * expression.cs (Binary.ResolveOperator): Do no append strings
19487 twice: since we can be invoked more than once (array evaluation)
19488 on the same concatenation, take care of this here. Based on a fix
19489 from Ben (bug #56454)
19491 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19493 * codegen.cs: Fix another case where CS1548 must be reported (when
19494 delay-sign isn't specified and no private is available #56564). Fix
19495 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19496 error when MCS is used on the MS runtime and we need to delay-sign
19497 (which seems unsupported by AssemblyBuilder - see #56621).
19499 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19501 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19502 (TypeManager.ComputeNamespaces): Faster implementation for
19505 * compiler.csproj: Updated AssemblyName to mcs.
19507 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19509 * rootcontext.cs: Add new types to the boot resolution.
19511 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19512 MulticastDelegate is not allowed.
19514 * typemanager.cs: Add new types to lookup: System.TypedReference
19517 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19518 check for TypedReference or ArgIterator, they are not allowed.
19520 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19521 makes us properly catch 1510 in some conditions (see bug 56016 for
19524 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19526 * CryptoConvert.cs: update from corlib version
19529 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19531 * class.cs (Indexer.Define): Check indexername declaration
19533 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19535 * attribute.cs (IsClsCompliant): Fixed problem with handling
19536 all three states (compliant, not-compliant, undetected).
19538 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19540 * attribute.cs (Attribute): Location is now public.
19541 (Resolve): Store resolved arguments (pos_values) in attribute class.
19542 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19543 (GetClsCompliantAttributeValue): New method that gets
19544 CLSCompliantAttribute value.
19545 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19546 if exists else null.
19547 (AttributeTester): New class for CLS-Compliant verification routines.
19549 * class.cs (Emit): Add CLS-Compliant verification.
19550 (Method.GetSignatureForError): Implemented.
19551 (Constructor.GetSignatureForError): Implemented
19552 (Constructor.HasCompliantArgs): Returns if constructor has
19553 CLS-Compliant arguments.
19554 (Constructor.Emit): Override.
19555 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19556 is needed to test only parameters.
19557 (FieldBase.GetSignatureForError): Implemented.
19558 (TypeContainer): New member for storing base interfaces.
19559 (TypeContainer.FindMembers): Search in base interfaces too.
19561 * codegen.cs (GetClsComplianceAttribute): New method that gets
19562 assembly or module CLSCompliantAttribute value.
19563 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19565 (ModuleClass.Emit): Add error 3012 test.
19567 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19569 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19570 state for all decl types.
19571 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19572 if CLS-Compliant tests are required.
19573 (IsClsCompliaceRequired): New method. Analyze whether code
19574 must be CLS-Compliant.
19575 (IsExposedFromAssembly): New method. Returns true when MemberCore
19576 is exposed from assembly.
19577 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19578 value or gets cached value.
19579 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19580 is explicitly marked with CLSCompliantAttribute.
19581 (IsIdentifierClsCompliant): New abstract method. This method is
19582 used to testing error 3005.
19583 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19584 for identifier and parameters CLS-Compliant testing.
19585 (VerifyClsCompliance): New method. The main virtual method for
19586 CLS-Compliant verifications.
19587 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19588 null. I don't know why is null (too many public members !).
19589 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19590 and get value of first CLSCompliantAttribute that found.
19592 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19593 (VerifyClsCompliance): Override and add extra tests.
19595 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19596 clscheck- disable CLS-Compliant verification event if assembly is has
19597 CLSCompliantAttribute(true).
19599 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19600 ApllyAttribute is now called in emit section as in the other cases.
19601 Possible future Emit integration.
19602 (IsIdentifierClsCompliant): New override.
19603 (VerifyClsCompliance): New override.
19604 (GetEnumeratorName): Returns full enum name.
19606 * parameter.cs (GetSignatureForError): Implemented.
19608 * report.cs (WarningData): New struct for Warning message information.
19609 (LocationOfPreviousError): New method.
19610 (Warning): New method. Reports warning based on the warning table.
19611 (Error_T): New method. Reports error based on the error table.
19613 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19614 verifications are done here.
19616 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19618 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19619 CLSCompliantAttribute.
19620 (all_imported_types): New member holds all imported types from other
19622 (LoadAllImportedTypes): New method fills static table with exported types
19623 from all referenced assemblies.
19624 (Modules): New property returns all assembly modules.
19626 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19628 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19629 throwing a parser error.
19631 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19632 which removes the hardcoded get_/set_ prefixes for properties, as
19633 IL allows for the properties to be named something else.
19637 * expression.cs: Do not override operand before we know if it is
19638 non-null. Fix 56207
19640 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19642 * typemanager.cs: support for pinned variables.
19644 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19646 * decl.cs, typemanager.cs: Avoid using an arraylist
19647 as a buffer if there is only one result set.
19649 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19651 * expression.cs: Make sure you cant call a static method
19652 with an instance expression, bug #56174.
19654 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19656 * class.cs (IsDuplicateImplementation): Improve error reporting to
19657 flag 663 (method only differs in parameter modifier).
19659 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19660 in preprocessor directives.
19662 * location.cs (LookupFile): Allow for the empty path.
19664 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19665 better approach for some of that patch, but its failing with the
19666 CharSet enumeration. For now try/catch will do.
19668 * typemanager.cs: Do not crash if a struct does not have fields.
19671 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19673 * expression.cs: cs0213, cant fix a fixed expression.
19676 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19678 * cs-parser.jay: detect invalid embeded statements gracefully.
19681 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19683 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19686 the invocation type may not be a subclass of the tye of the item/
19687 The type of the item must be a subclass of the invocation item.
19692 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19694 * attribute.cs: Added methods to get a string and a bool from an
19695 attribute. Required to information from AssemblyKeyFileAttribute,
19696 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19697 * codegen.cs: Modified AssemblyName creation to include support for
19698 strongnames. Catch additional exceptions to report them as CS1548.
19699 * compiler.csproj: Updated include CryptoConvert.cs.
19700 * compiler.csproj.user: Removed file - user specific configuration.
19701 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19702 Mono.Security assembly. The original class is maintained and tested in
19703 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19704 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19705 like CSC 8.0 (C# v2) supports.
19706 * Makefile: Added CryptoConvert.cs to mcs sources.
19707 * rootcontext.cs: Added new options for strongnames.
19709 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19711 * driver.cs: For --expect-error, report error code `2'
19712 if the program compiled with no errors, error code `1' if
19713 it compiled with an error other than the one expected.
19715 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19717 * compiler.csproj: Updated for Visual Studio .NET 2003.
19718 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19719 * compiler.sln: Updated for Visual Studio .NET 2003.
19721 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19723 * expression.cs: Fix bug #47234. We basically need to apply the
19724 rule that we prefer the conversion of null to a reference type
19725 when faced with a conversion to 'object' (csc behaviour).
19727 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19729 * statement.cs: Shorter form for foreach, eliminates
19730 a local variable. r=Martin.
19732 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19734 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19735 checks if we can use brtrue/brfalse to test for 0.
19736 * expression.cs: use the above in the test for using brtrue/brfalse.
19737 cleanup code a bit.
19739 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19741 * expression.cs: Rewrite string concat stuff. Benefits:
19743 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19744 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19745 rather than a concat chain.
19747 * typemanager.cs: Add lookups for more concat overloads.
19749 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19751 * expression.cs: Emit shorter il code for array init.
19768 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19770 * statement.cs: Before, two switch blocks would be merged if the
19771 total size of the blocks (end_item - begin_item + 1) was less than
19772 two times the combined sizes of the blocks.
19774 Now, it will only merge if after the merge at least half of the
19779 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19781 * class.cs : csc build fix for GetMethods(). See bug #52503.
19783 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19785 * expression.cs: Make sure fp comparisons work with NaN.
19786 This fixes bug #54303. Mig approved this patch a long
19787 time ago, but we were not able to test b/c the runtime
19790 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19792 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19794 2004-03-19 Martin Baulig <martin@ximian.com>
19796 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19797 error here and not in our caller.
19799 2004-03-19 Martin Baulig <martin@ximian.com>
19801 * interface.cs: Completely killed this file.
19802 (Interface): We're now a TypeContainer and live in class.cs.
19804 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19805 argument; we're now also called for interfaces.
19806 (TypeContainer.DefineMembers): Allow this method being called
19808 (TypeContainer.GetMethods): New public method; formerly known as
19809 Interface.GetMethod(). This is used by PendingImplementation.
19810 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19811 it's now private and non-static.
19812 (Interface): Moved this here; it's now implemented similar to
19814 (Method, Property, Event, Indexer): Added `bool is_interface'
19815 argument to their .ctor's.
19816 (MemberBase.IsInterface): New public field.
19818 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19819 instances instead of InterfaceMethod, InterfaceProperty, etc.
19820 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19821 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19823 2004-03-19 Martin Baulig <martin@ximian.com>
19825 * class.cs (MethodCore.IsDuplicateImplementation): New private
19826 method which does the CS0111 checking.
19827 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19828 Use IsDuplicateImplementation().
19830 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19832 * decl.cs (FindMemberToOverride): New method to find the correct
19833 method or property to override in the base class.
19835 - Make Method/Property use the above method to find the
19836 version in the base class.
19837 - Remove the InheritableMemberSignatureCompare as it is now
19840 This patch makes large code bases much faster to compile, as it is
19841 O(n) rather than O(n^2) to do this validation.
19843 Also, it fixes bug 52458 which is that nested classes are not
19844 taken into account when finding the base class member.
19846 Reviewed/Approved by Martin.
19848 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19850 * interface.cs: In all interface classes removed redundant
19851 member initialization.
19853 2004-03-16 Martin Baulig <martin@ximian.com>
19855 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19857 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19859 * decl.cs (DefineTypeAndParents): New helper method to define a
19860 type's containers before the type itself is defined; This is a
19861 bug exposed by the recent changes to Windows.Forms when an
19862 implemented interface was defined inside a class that had not been
19865 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19867 (Check): Loop correctly to report errors modifiers
19868 (UNSAFE was not in the loop, since it was the same as TOP).
19870 * interface.cs: Every interface member now takes a ModFlags,
19871 instead of a "is_new" bool, which we set on the base MemberCore.
19873 Every place where we called "UnsafeOk" in the interface, now we
19874 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19875 the unsafe settings from the member declaration instead of the
19876 container interface.
19878 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19880 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19881 `set_indexer_name' to the pending bits (one per type).
19883 We fixed a bug today that was picking the wrong method to
19884 override, since for properties the existing InterfaceMethod code
19885 basically ignored the method name. Now we make sure that the
19886 method name is one of the valid indexer names.
19888 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19890 * support.cs (SeekableStreamReader): Keep track of stream byte
19891 positions and don't mix them with character offsets to the buffer.
19893 Patch from Gustavo Giráldez
19895 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19897 * interface.cs (InterfaceSetGetBase): Removed double member
19898 initialization, base class does it as well.
19900 2004-03-13 Martin Baulig <martin@ximian.com>
19902 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19903 when compiling corlib.
19905 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19907 * convert.cs (ExplicitConversion): We were reporting an error on
19908 certain conversions (object_type source to a value type, when the
19909 expression was `null') before we had a chance to pass it through
19910 the user defined conversions.
19912 * driver.cs: Replace / and \ in resource specifications to dots.
19915 * class.cs: Add check for duplicate operators. Fixes 52477
19917 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19919 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19920 that are in the middle of the statements, not only at the end.
19923 * class.cs (TypeContainer.AddField): No longer set the
19924 `HaveStaticConstructor' flag, now we call it
19925 `UserDefineStaticConstructor' to diferentiate the slightly
19926 semantic difference.
19928 The situation is that we were not adding BeforeFieldInit (from
19929 Modifiers.TypeAttr) to classes that could have it.
19930 BeforeFieldInit should be set to classes that have no static
19935 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19937 And most importantly Zoltan's comment:
19939 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19941 "I think beforefieldinit means 'it's ok to initialize the type sometime
19942 before its static fields are used', i.e. initialization does not need
19943 to be triggered by the first access to the type. Setting this flag
19944 helps the JIT to compile better code, since it can run the static
19945 constructor at JIT time, and does not need to generate code to call it
19946 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19947 this flag for lots of classes like String.
19949 csc sets this flag if the type does not have an explicit static
19950 constructor. The reasoning seems to be that if there are only static
19951 initalizers for a type, and no static constructor, then the programmer
19952 does not care when this initialization happens, so beforefieldinit
19955 This bug prevents the AOT compiler from being usable, since it
19956 generates so many calls to mono_runtime_class_init that the AOT code
19957 is much slower than the JITted code. The JITted code is faster,
19958 because it does not generate these calls if the vtable is type is
19959 already initialized, which is true in the majority of cases. But the
19960 AOT compiler can't do this."
19962 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19964 * class.cs (MethodData.Emit): Refactor the code so symbolic
19965 information is generated for destructors; For some reasons we
19966 were taking a code path that did not generate symbolic information
19969 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19971 * class.cs: Create a Constructor.CheckBase method that
19972 takes care of all validation type code. The method
19973 contains some code that was moved from Define.
19975 It also includes new code that checks for duplicate ctors.
19976 This fixes bug #55148.
19978 2004-03-09 Joshua Tauberer <tauberer@for.net>
19980 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19981 a { ... }-style array creation invokes EmitStaticInitializers
19982 which is not good for reference-type arrays. String, decimal
19983 and now null constants (NullCast) are not counted toward
19984 static initializers.
19986 2004-03-05 Martin Baulig <martin@ximian.com>
19988 * location.cs (SourceFile.HasLineDirective): New public field;
19989 specifies whether the file contains or is referenced by a "#line"
19991 (Location.DefineSymbolDocuments): Ignore source files which
19992 either contain or are referenced by a "#line" directive.
19994 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19996 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19997 direct access to our parent, so check the method inline there.
19999 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
20001 * expression.cs (Invocation.EmitCall): Miguel's last commit
20002 caused a regression. If you had:
20007 In Foo the implict this would be null.
20009 2004-02-27 Miguel de Icaza <miguel@ximian.com>
20011 * expression.cs (Invocation.EmitCall): If the method is not
20012 virtual, do not emit a CallVirt to it, use Call.
20014 * typemanager.cs (GetFullNameSignature): Improve the method to
20015 cope with ".ctor" and replace it with the type name.
20017 * class.cs (ConstructorInitializer.Resolve): Now the method takes
20018 as an argument the ConstructorBuilder where it is being defined,
20019 to catch the recursive constructor invocations.
20021 2004-02-26 Miguel de Icaza <miguel@ximian.com>
20023 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
20024 routines to check if a type is an enumerable/enumerator allow
20025 classes that implement the IEnumerable or IEnumerator interfaces.
20027 * class.cs (Property, Operator): Implement IIteratorContainer, and
20028 implement SetYields.
20030 (Property.Define): Do the block swapping for get_methods in the
20031 context of iterators. We need to check if Properties also
20032 include indexers or not.
20034 (Operator): Assign the Block before invoking the
20035 OperatorMethod.Define, so we can trigger the Iterator code
20038 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
20039 Property and Operator classes are not created when we parse the
20040 declarator but until we have the block completed, so we use a
20041 singleton SimpleIteratorContainer.Simple to flag whether the
20042 SetYields has been invoked.
20044 We propagate this setting then to the Property or the Operator to
20045 allow the `yield' to function.
20047 2004-02-25 Marek Safar <marek.safar@seznam.cz>
20049 * codegen.cs: Implemented attribute support for modules.
20050 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
20051 Assembly/Module functionality.
20053 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
20054 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
20055 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
20057 2004-02-16 Marek Safar <marek.safar@seznam.cz>
20059 * interface.cs (FindMembers): The operation is performed on all base
20060 interfaces and not only on the first. It is required for future CLS Compliance patch.
20062 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
20064 * statement.cs, codegen.cs:
20065 This patch deals with patterns such as:
20067 public class List : IEnumerable {
20069 public MyEnumerator GetEnumerator () {
20070 return new MyEnumerator(this);
20073 IEnumerator IEnumerable.GetEnumerator () {
20077 public struct MyEnumerator : IEnumerator {
20082 Before, there were a few things we did wrong:
20083 1) we would emit callvirt on a struct, which is illegal
20084 2) we emited ldarg when we needed to emit ldarga
20085 3) we would mistakenly call the interface methods on an enumerator
20086 type that derived from IEnumerator and was in another assembly. For example:
20088 public class MyEnumerator : IEnumerator
20090 Would have the interface methods called, even if there were public impls of the
20091 method. In a struct, this lead to invalid IL code.
20093 2004-02-11 Marek Safar <marek.safar@seznam.cz>
20095 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
20098 * delegate.cs (Define): Fixed crash when delegate type is undefined.
20100 2004-02-11 Miguel de Icaza <miguel@ximian.com>
20102 * cs-parser.jay: Fix small regression: we were not testing V2
20103 compiler features correctly.
20105 * interface.cs: If the emit context is null, then create one
20107 2004-02-09 Marek Safar <marek.safar@seznam.cz>
20109 * decl.cs (GetSignatureForError): New virtual method to get full name
20110 for error messages.
20112 * attribute.cs (IAttributeSupport): New interface for attribute setting.
20113 Now it is possible to rewrite ApplyAttributes method to be less if/else.
20115 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
20116 Duplicated members and code in these classes has been removed.
20117 Better encapsulation in these classes.
20119 2004-02-07 Miguel de Icaza <miguel@ximian.com>
20121 * assign.cs (Assign.DoResolve): When dealing with compound
20122 assignments, there is a new rule in ECMA C# 2.4 (might have been
20123 there before, but it is documented here) that states that in:
20127 If b is of type int, and the `op' is a shift-operator, then the
20128 above is evaluated as:
20132 * expression.cs (Binary.ResolveOperator): Instead of testing for
20133 int/uint/long/ulong, try to implicitly convert to any of those
20134 types and use that in pointer arithmetic.
20136 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
20137 method to print information for from the type, not from the
20138 null-method we were given.
20140 2004-02-01 Duncan Mak <duncan@ximian.com>
20142 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
20143 parsing for cmd, fixes bug #53694.
20145 2004-02-04 Marek Safar <marek.safar@seznam.cz>
20147 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
20148 in the member name duplication tests. Property and operator name duplication
20149 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
20151 2004-02-03 Marek Safar <marek.safar@seznam.cz>
20153 * interface.cs (PopulateMethod): Fixed crash when interface method
20154 returns not existing type (error test cs0246-3.cs).
20156 2004-02-02 Ravi Pratap M <ravi@ximian.com>
20158 * cs-parser.jay (interface_accessors): Re-write actions to also
20159 store attributes attached to get and set methods. Fix spelling
20162 (inteface_property_declaration): Modify accordingly.
20164 (InterfaceAccessorInfo): New helper class to store information to pass
20165 around between rules that use interface_accessors.
20167 * interface.cs (Emit): Apply attributes on the get and set
20168 accessors of properties and indexers too.
20170 * attribute.cs (ApplyAttributes): Modify accordingly to use the
20171 right MethodBuilder when applying attributes to the get and set accessors.
20173 2004-01-31 Miguel de Icaza <miguel@ximian.com>
20175 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
20177 2004-01-26 Miguel de Icaza <miguel@ximian.com>
20179 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
20181 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20183 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20184 changes that treat `yield' specially when present before `break'
20185 or `return' tokens.
20187 * cs-tokenizer.cs: yield is no longer a keyword.
20189 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20191 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20192 setting for default constructors.
20193 For default constructors are almost every time set wrong Modifier. The
20194 generated IL code has been alright. But inside mcs this values was
20195 wrong and this was reason why several of my CLS Compliance tests
20198 2004-01-22 Martin Baulig <martin@ximian.com>
20200 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20201 not a QualifiedIdentifier. This is what `type_name_expression'
20202 was previously doing.
20203 (type_name_expression): Removed; the code is now in
20204 `namespace_or_type_name'.
20205 (qualified_identifier): Removed, use `namespace_or_type_name'
20207 (QualifiedIdentifier): Removed this class.
20209 2004-01-22 Martin Baulig <martin@ximian.com>
20211 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20212 not a string as alias name.
20214 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20216 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20217 #52730 bug, and instead compute correctly the need to use a
20218 temporary variable when requesting an address based on the
20219 static/instace modified of the field and the constructor.
20221 2004-01-21 Martin Baulig <martin@ximian.com>
20223 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20224 class and namespace before looking up aliases. Fixes #52517.
20226 2004-01-21 Martin Baulig <martin@ximian.com>
20228 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20229 assinged in a 'try'; fixes exception4.cs.
20231 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20232 * class.cs : Implemented parameter-less constructor for TypeContainer
20234 * decl.cs: Attributes are now stored here. New property OptAttributes
20236 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20238 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20240 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20242 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20243 (CSharpSignature): New method for indexer and property signature.
20245 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20247 * pending.cs (IsVirtualFilter): Faster implementation.
20249 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20251 * typemanager.cs: Avoid inclusion of same assembly more than once.
20253 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20255 * cs-parser.jay: Fixed problem where the last assembly attribute
20256 has been applied also to following declaration (class, struct, etc.)
20258 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20260 * class.cs: Added error CS0538, CS0539 reporting.
20261 Fixed crash on Microsoft runtime when field type is void.
20263 * cs-parser.jay: Added error CS0537 reporting.
20265 * pending.cs: Added error CS0535 reporting.
20266 Improved error report for errors CS0536, CS0534.
20268 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20270 Merge a few bits from the Anonymous Method MCS tree.
20272 * statement.cs (ToplevelBlock): New class for toplevel methods,
20273 will hold anonymous methods, lifted variables.
20275 * cs-parser.jay: Create toplevel blocks for delegates and for
20276 regular blocks of code.
20278 2004-01-20 Martin Baulig <martin@ximian.com>
20280 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20281 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20282 and `NeedExplicitReturn'; added `IsLastStatement'.
20283 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20284 have a `ReturnLabel' or we're not unreachable.
20286 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20287 child's reachability; don't just override ours with it. Fixes
20288 #58058 (lluis's example).
20289 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20290 InFinally(), InLoop(), InSwitch() and
20291 BreakCrossesTryCatchBoundary() methods.
20293 * statement.cs (Return): Do all error checking in Resolve().
20294 Unless we are the last statement in a top-level block, always
20295 create a return label and jump to it.
20296 (Break, Continue): Do all error checking in Resolve(); also make
20297 sure we aren't leaving a `finally'.
20298 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20299 statement in a top-level block.
20300 (Block.Flags): Added `IsDestructor'.
20301 (Block.IsDestructor): New public property.
20303 2004-01-20 Martin Baulig <martin@ximian.com>
20305 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20307 2004-01-20 Martin Baulig <martin@ximian.com>
20309 * statement.cs (Statement.ResolveUnreachable): New public method.
20310 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20311 (Block.Resolve): Resolve unreachable statements.
20313 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20315 * expression.cs: We need to fix the case where we do
20316 not have a temp variable here.
20318 * assign.cs: Only expression compound assignments need
20319 temporary variables.
20321 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20323 * flowanalysis.cs: Reduce memory allocation in a few ways:
20324 - A block with no variables should not allocate a bit
20326 - A method with no out parameters does not need any tracking
20327 for assignment of the parameters, so we need not allocate
20330 public readonly Type[] VariableTypes;
20331 public readonly string[] VariableNames;
20332 Are redundant. The data is already stored in the variable
20333 map, so we need not allocate another array for it.
20334 - We need to add alot of checks for if (params | locals) == null
20335 due to the first two changes.
20337 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20339 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20340 implement IMemoryLocation, we store a copy on a local variable and
20341 take the address of it. Patch from Benjamin Jemlich
20343 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20344 to use a special "type_name_expression" rule which reduces the
20345 number of "QualifiedIdentifier" classes created, and instead
20346 directly creates MemberAccess expressions.
20348 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20350 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20351 that fixes #52853. Null literal assignment to ValueType
20353 * class.cs (MethodData.Emit): Instead of checking the name of the
20354 method to determine if its a destructor, create a new derived
20355 class from Method called Destructor, and test for that.
20357 * cs-parser.jay: Create a Destructor object instead of a Method.
20359 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20363 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20365 * expression.cs (Binary.ResolveOperator): Perform an implicit
20366 conversion from MethodGroups to their delegate types on the
20367 Addition operation.
20369 * delegate.cs: Introduce a new class DelegateCreation that is the
20370 base class for `NewDelegate' and `ImplicitDelegateCreation',
20371 factor some code in here.
20373 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20374 conversion from MethodGroups to compatible delegate types.
20376 * ecore.cs (Expression.Resolve): Do not flag error 654
20377 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20378 we allow conversions from MethodGroups to delegate types now.
20380 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20381 assignments in v2 either.
20383 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20385 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20386 static read-only fields in ctors.
20388 Applied patch from Benjamin Jemlich
20390 * expression.cs (UnaryMutator): Avoid leaking local variables.
20392 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20394 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20395 here to return true, as they can be used like this:
20397 (XXX) int.MEMBER ()
20399 Fixed 49836 and all the other dups
20401 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20403 * driver.cs: Implement /win32res and /win32icon.
20405 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20407 * cs-parser.jay: Add a rule to improve error handling for the
20408 common mistake of placing modifiers after the type.
20410 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20412 * cs-parser.jay (interface_event_declaration): Catch
20413 initialization of events on interfaces, and report cs0068
20415 * cs-parser.jay (interface_event_declaration): Catch
20416 initialization of events.
20418 * ecore.cs: Better report missing constructors.
20420 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20421 the error reporting done in the wrong place. Fix.
20423 * expression.cs (Binary.ResolveOperator): Catch the
20424 operator + (E x, E y) error earlier, and later allow for implicit
20425 conversions in operator +/- (E e, U x) from U to the underlying
20428 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20429 52596, if the container class is abstract, the default constructor
20430 is protected otherwise its public (before, we were always public).
20432 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20435 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20436 Jemlich that fixes bug #52597, MCS was generating invalid code for
20437 idisposable structs. Thanks to Ben for following up with this
20440 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20442 * driver.cs: Allow assemblies without code to be generated, fixes
20445 2004-01-07 Nick Drochak <ndrochak@gol.com>
20447 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20449 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20451 * cs-parser.jay: Add rules to improve error reporting if fields or
20452 methods are declared at the namespace level (error 116)
20454 * Add rules to catch event add/remove
20456 2004-01-04 David Sheldon <dave-mono@earth.li>
20458 * expression.cs: Added matching ")" to error message for
20461 2004-01-03 Todd Berman <tberman@gentoo.org>
20463 * ecore.cs, attribute.cs:
20464 Applying fix from #52429.
20466 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20468 * ecore.cs, expression.cs, statement.cs:
20469 Total rewrite of how we handle branching. We
20470 now handle complex boolean expressions with fewer
20471 jumps. As well if (x == 0) no longer emits a ceq.
20473 if (x is Foo) is much faster now, because we generate
20476 Overall, we get a pretty big improvement on our benchmark
20477 tests. The code we generate is smaller and more readable.
20479 I did a full two-stage bootstrap. The patch was reviewed
20480 by Martin and Miguel.
20482 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20484 * cs-parser.jay: Make primary_expression not take a QI.
20485 we dont need this because the member_access rule covers
20486 us here. So we replace the rule with just IDENTIFIER.
20488 This has two good effects. First, we remove a s/r conflict.
20489 Second, we allocate many fewer QualifiedIdentifier objects.
20491 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20493 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20494 set the correct information via SRE. This prevents
20495 hanging on the MS runtime. Fixes #29374.
20497 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20499 * convert.cs: correctly handle conversions to value types
20500 from Enum and ValueType as unboxing conversions.
20502 Fixes bug #52569. Patch by Benjamin Jemlich.
20504 2004-01-02 Ravi Pratap <ravi@ximian.com>
20506 * expression.cs (BetterConversion): Prefer int -> uint
20507 over int -> ulong (csc's behaviour). This fixed bug #52046.
20509 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20511 * decl.cs (MemberCache.FindMembers): now returns a
20514 * typemanager.cs: In general, go with with ^^.
20515 (CopyNewMethods): take an IList.
20516 (RealMemberLookup): Only allocate an arraylist
20517 if we copy from two sets of methods.
20519 This change basically does two things:
20520 1) Fewer array lists allocated due to CopyNewMethods.
20521 2) the explicit cast in MemberList costed ALOT.
20523 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20525 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20526 a hashtable to avoid needless string allocations when an identifier is
20527 used more than once (the common case).
20529 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20531 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20532 is broken, it will not return anything. So, we
20533 have to use the information we have in mcs to
20536 * typemanager.cs: Add a cache for GetInterfaces,
20537 since this will now be used more often (due to ^^)
20539 (GetExplicitInterfaces) New method that gets the
20540 declared, not effective, interfaces on a type
20541 builder (eg, if you have interface IFoo, interface
20542 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20545 This patch makes MCS able to bootstrap itself on
20548 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20550 * expression.cs: Remove the Nop's that Miguel put
20553 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20555 * report.cs, codegen.cs: Give the real stack trace to
20556 the error when an exception is thrown.
20558 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20560 * decl.cs: only allocate hashtables for ifaces if
20563 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20565 * expression.cs: fix the error from cs0121-2.cs
20566 (a parent interface has two child interfaces that
20567 have a function with the same name and 0 params
20568 and the function is called through the parent).
20570 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20572 * class.cs, rootcontext.cs, typmanager.cs: do not
20575 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20577 * codegen.cs: remove stack for the ec flow branching.
20578 It is already a linked list, so no need.
20580 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20582 * Makefile: Allow custom profiler here.
20584 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20586 * typemanager.cs (LookupType):
20587 - Use a static char [], because split takes
20588 a param array for args, so it was allocating
20590 - Do not store true in a hashtable, it boxes.
20592 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20594 * flowanalysis.cs: bytify common enums.
20596 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20598 * modifiers.cs: Add a new set of flags for the
20599 flags allowed on explicit interface impls.
20600 * cs-parser.jay: catch the use of modifiers in
20601 interfaces correctly.
20602 * class.cs: catch private void IFoo.Blah ().
20604 All related to bug #50572.
20606 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20608 * decl.cs: Rewrite the consistant accessability checking.
20609 Accessability is not linear, it must be implemented in
20610 a tableish way. Fixes #49704.
20612 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20614 * expression.cs: Handle negation in a checked context.
20615 We must use subtraction from zero. Fixes #38674.
20617 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20619 * class.cs: Ignore static void main in DLLs.
20620 * rootcontext.cs: Handle the target type here,
20621 since we are have to access it from class.cs
20622 * driver.cs: account for the above.
20624 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20626 * report.cs: Give line numbers and files if available.
20628 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20630 * driver.cs: Implement /addmodule.
20632 * typemanager.cs: Change 'modules' field so it now contains Modules not
20635 2003-12-20 Martin Baulig <martin@ximian.com>
20637 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20638 (FieldBase.IsAssigned): Removed this field.
20639 (FieldBase.SetAssigned): New public method.
20640 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20642 2003-12-20 Martin Baulig <martin@ximian.com>
20644 * expression.cs (LocalVariableReference.DoResolve): Don't set
20645 `vi.Used' if we're called from DoResolveLValue().
20647 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20648 returns the usage vector it just merged into the current one -
20649 pass this one to UsageWarning().
20650 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20651 of the `EmitContext', don't call this recursively on our children.
20653 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20655 * driver.cs: Implement /target:module.
20657 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20659 * support.cs (CharArrayHashtable): New helper class.
20661 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20662 char arrays, not strings, so we can avoid creating a string in
20663 consume_identifier if the identifier is a keyword.
20665 2003-12-16 Martin Baulig <martin@ximian.com>
20667 * statement.cs (LocalInfo.Assigned): Removed this property.
20668 (LocalInfo.Flags): Removed `Assigned'.
20669 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20670 and uses flow analysis.
20671 (Block.UsageWarning): Made this method private.
20672 (Block.Resolve): Call UsageWarning() if appropriate.
20674 * expression.cs (LocalVariableReference.DoResolve): Always set
20675 LocalInfo.Used here.
20677 2003-12-13 Martin Baulig <martin@ximian.com>
20679 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20680 any value here; we're now using flow analysis to figure out
20681 whether a statement/block returns a value.
20683 2003-12-13 Martin Baulig <martin@ximian.com>
20685 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20687 (FlowBranching.MergeFinally): Don't call
20688 `branching.CheckOutParameters()' here, this is called in
20690 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20691 when adding the `finally' vector.
20693 2003-12-13 Martin Baulig <martin@ximian.com>
20696 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20697 actually work and also fix #48962.
20699 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20701 * decl.cs: Do not check System.Object for nested types,
20702 since we know it does not have any. Big bang for buck:
20705 Run 1: 8.35 seconds
20706 Run 2: 8.32 seconds
20707 corlib: 17.99 seconds
20709 Run 1: 8.17 seconds
20710 Run 2: 8.17 seconds
20711 corlib: 17.39 seconds
20713 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20715 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20716 time we are returning 0 members, so we save alot here.
20718 2003-12-11 Martin Baulig <martin@ximian.com>
20720 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20721 `MergeChild()', also just take the `FlowBranching' as argument;
20722 call Merge() on it and return the result.
20723 (FlowBranching.Merge): We don't need to do anything if we just
20726 2003-12-11 Martin Baulig <martin@ximian.com>
20728 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20729 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20730 Maurer for this idea.
20732 2003-12-11 Martin Baulig <martin@ximian.com>
20734 * flowanalysis.cs (MergeResult): This class is now gone; we now
20735 use the `UsageVector' for this. The reason for this is that if a
20736 branching just has one sibling, we don't need to "merge" them at
20737 all - that's the next step to do.
20738 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20741 2003-12-11 Martin Baulig <martin@ximian.com>
20743 Reworked flow analyis and made it more precise and bug-free. The
20744 most important change is that we're now using a special `Reachability'
20745 class instead of having "magic" meanings of `FlowReturns'. I'll
20746 do some more cleanups and optimizations and also add some more
20747 documentation this week.
20749 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20750 largely reworked this class.
20751 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20752 the new `Reachability' class instead of having "magic" values here.
20753 (FlowBranching): We're now using an instance of `Reachability'
20754 instead of having separate `Returns', `Breaks' etc. fields.
20756 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20757 based on flow analysis; ignore the return value of block.Emit ().
20759 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20761 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20762 if they are private.
20764 2003-12-09 Martin Baulig <martin@ximian.com>
20766 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20767 call them directly on the UsageVector.
20769 2003-12-09 Martin Baulig <martin@ximian.com>
20771 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20772 Changed return type from `FlowReturns' to `Reachability'.
20774 2003-12-09 Martin Baulig <martin@ximian.com>
20776 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20777 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20778 `Reachable' fields with a single `Reachability' one.
20780 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20782 * class.cs (FindMembers): Remove foreach's.
20787 Run 1: 8.74 seconds
20788 Run 2: 8.71 seconds
20791 Run 1: 8.64 seconds
20792 Run 2: 8.58 seconds
20795 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20800 This patch does a few things:
20801 1. EmptyStatement is now a singleton, so it is never reallocated.
20802 2. All blah is EmptyStatement constructs have been changed to
20803 blah == EmptyStatement.Value, which is much faster and valid
20804 now that EmptyStatement is a singleton.
20805 3. When resolving a block, rather than allocating a new array for
20806 the non-empty statements, empty statements are replaced with
20807 EmptyStatement.Value
20808 4. Some recursive functions have been made non-recursive.
20809 Mainly the performance impact is from (3), however (1) and (2) are needed for
20810 this to work. (4) does not make a big difference in normal situations, however
20811 it makes the profile look saner.
20816 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20817 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20818 Total memory allocated: 56397 KB
20821 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20822 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20823 Total memory allocated: 55666 KB
20825 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20827 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20828 than the hashtable in a hashtable version
20830 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20831 we always end up concating a string. This results in a huge perf
20832 loss, because many strings have to be tracked by the GC. In this
20833 patch, we first use a hashtable that works with two keys, so that
20834 the strings do not need to be concat'ed.
20838 Run 1: 8.74 seconds
20839 Run 2: 8.71 seconds
20842 Run 1: 8.65 seconds
20843 Run 2: 8.56 seconds
20845 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20847 * Makefile: Add a new target `do-time' that does a quick and simple
20848 profile, leaving easy to parse output.
20850 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20852 * codegen.cs (Init): Create the dynamic assembly with
20853 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20855 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20857 * support.cs: Make the PtrHashtable use only one
20858 instance of its comparer.
20860 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20862 * typemanager.cs: Fix lookup of GetNamespaces.
20864 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20866 * expression.cs: Removed redundant line.
20868 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20869 ArrayLists, use for loops with bounds.
20871 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20874 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20875 arraylists, use for loop with bounds.
20877 The above three changes give us a 0.071 second performance
20878 improvement out of 3.294 seconds down to 3.223. On my machine
20879 the above changes reduced the memory usage by 1,387 KB during
20880 compiler bootstrap.
20882 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20883 QualifiedIdentifiers. Before we created a new string through
20884 concatenation, and mostly later on, the result would be
20885 manipulated by DecomposeQI through string manipulation.
20887 This reduced the compiler memory usage for bootstrapping from
20888 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20889 compile times in 0.05 seconds.
20891 2003-11-28 Dick Porter <dick@ximian.com>
20893 * support.cs: Do string compares with the Invariant culture.
20901 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20902 the comparison is done with the Invariant culture.
20904 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20906 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20907 GetEnumerator method.
20909 (ProbeCollectionType): Iterate starting at the most specific type
20910 upwards looking for a GetEnumerator
20912 * expression.cs: Shift count can be up to 31 for int/uint and 63
20915 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20917 * statement.cs (Block.LookupLabel): Also look for the label on the
20918 children blocks. Use a hash table to keep track of visited
20921 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20922 we actually did transform the other operand, otherwise fall back
20923 to the common codepath that casts to long.
20925 * cs-tokenizer.cs: Use the same code pattern as the int case.
20926 Maybe I should do the parsing myself, and avoid depending on the
20927 Parse routines to get this done.
20929 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20931 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20932 which fixes bug 51347. This time test it.
20934 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20935 attributes for example can not tell the difference between these.
20936 The difference was only a syntax feature of the language.
20938 * attribute.cs: Apply attributes to delegates.
20940 * delegate.cs: Call the apply attributes method.
20942 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20944 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20945 comparing 0 vs Byte.MinValue, not the value
20947 (ImplicitConversionRequired): When reporting a conversion error,
20948 use error 31 to print out the constant error instead of the
20951 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20952 which fixes bug 51347.
20954 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20956 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20957 which fixes the -warnaserror command line option.
20959 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20961 * cfold.cs (DoNumericPromotions): During constant folding of
20962 additions on UIntConstant, special case intconstants with
20963 IntConstants like we do on the expression binary operator.
20965 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20967 * convert.cs (ImplicitReferenceConversion): We were missing a case
20968 (System.Enum are not value types or class types, so we need to
20969 classify them separatedly).
20971 * driver.cs: We do not support error 2007.
20973 2003-11-12 Jackson Harper <jackson@ximian.com>
20975 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20976 system directory. Also use the full file name so users can
20977 libraries names mscorlib-o-tron.dll in a non system dir.
20979 2003-11-10 Martin Baulig <martin@ximian.com>
20981 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20982 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20983 calling `ResolveType()' on them, directly assign their `Type'.
20985 2003-11-08 Martin Baulig <martin@ximian.com>
20987 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20988 return value and the `out parent' parameter.
20989 (TypeContainer.DefineType): Moved the CS0644 check into
20990 GetClassBases(). Don't pass the interface types to the
20991 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20992 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20994 * ecore.cs (TypeExpr.IsAttribute): New property.
20995 (TypeExpr.GetInterfaces): New method.
20997 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20998 TypeExpr instead of a Type.
20999 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
21000 (Interface.DefineType): Don't pass the interface types to the
21001 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
21002 them later and then call `TypeBulider.AddInterfaceImplementation()'.
21004 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
21005 instead of a `Type[]'.
21006 (TypeManager.RegisterBuilder): Likewise.
21007 (TypeManager.AddUserInterface): Likewise.
21008 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
21009 `Type[]' and also return a `TypeExpr[]'.
21010 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
21012 2003-11-08 Martin Baulig <martin@ximian.com>
21014 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
21017 2003-11-08 Martin Baulig <martin@ximian.com>
21019 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
21020 TypeManager.ResolveExpressionTypes().
21022 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
21023 instead of an Expression.
21024 (TypeExpr): This is now an abstract base class for `TypeExpression'.
21025 (TypeExpression): New public class; formerly known as `TypeExpr'.
21027 * expression.cs (ComposedCast): Derive from TypeExpr.
21029 * typemanager.cs (TypeManager.system_*_expr): These are now
21030 TypExpr's instead of Expression's.
21031 (TypeManager.ResolveExpressionTypes): New public static function;
21032 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
21035 2003-11-06 Miguel de Icaza <miguel@ximian.com>
21037 * expression.cs (New.DoResolve): Do not dereference value that
21038 might be a null return.
21040 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
21041 sure that the constant value has the right type. Fixes an
21042 unreported bug, similar to 50425.
21044 * const.cs (Const.LookupConstantValue): Call
21045 ImplicitStandardConversionExists before doing a conversion to
21046 avoid havng the TypeManager.ChangeType do conversions.
21048 Reduced the number of casts used
21050 (Const.ChangeType): New routine to enable reuse of the constant
21051 type changing code from statement.
21053 * typemanager.cs (ChangeType): Move common initialization to
21054 static global variables.
21058 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
21059 every value type to go through, even if it was void. Fix that.
21061 * cs-tokenizer.cs: Use is_identifier_start_character on the start
21062 character of the define, and the is_identifier_part_character for
21063 the rest of the string.
21065 2003-11-05 Miguel de Icaza <miguel@ximian.com>
21067 * expression.cs (UnaryMutator.EmitCode): When I updated
21068 LocalVariableReference.DoResolve, I overdid it, and dropped an
21069 optimization done on local variable references.
21071 2003-11-04 Miguel de Icaza <miguel@ximian.com>
21073 * ecore.cs: Convert the return from Ldlen into an int.
21075 2003-10-20 Miguel de Icaza <miguel@ximian.com>
21077 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
21078 the accessibility, this is a special case for toplevel non-public
21079 classes (internal for instance).
21081 2003-10-20 Nick Drochak <ndrochak@gol.com>
21083 * ecore.cs: Fix typo and build. Needed another right paren.
21085 2003-10-19 Miguel de Icaza <miguel@ximian.com>
21087 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
21088 `internal' case regular and protected, but not allowing protected
21089 to be evaluated later. Bug 49840
21091 2003-10-15 Miguel de Icaza <miguel@ximian.com>
21093 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
21094 to kb.Nlast, and not the kb.nFirst to isolate the switch
21097 Extract the underlying type, so enumerations of long/ulong are
21098 treated like long/ulong.
21100 2003-10-14 Miguel de Icaza <miguel@ximian.com>
21102 * expression.cs (New): Overload the meaning of RequestedType to
21103 track the possible creation of the NewDelegate type, since
21104 DoResolve is invoked more than once for new constructors on field
21107 See bugs: #48800 and #37014
21109 * cs-parser.jay (declare_local_constants): Take an arraylist
21110 instead of a single constant.
21112 (local_constant_declaration): It should take a
21113 constant_declarators, not a constant_declarator. Fixes 49487
21115 * convert.cs: Fix error report.
21117 2003-10-13 Jackson Harper <jackson@ximian.com>
21119 * typemanager.cs (TypeToCoreType): Add float and double this fixes
21122 2003-10-09 Martin Baulig <martin@ximian.com>
21124 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
21126 (MethodCore.DoDefineParameters): Removed the TypeContainer
21127 argument; use the DeclSpace which was passed to the .ctor instead.
21128 (MethodCore.CheckParameter): Take a DeclSpace instead of a
21129 TypeContainer; we only need a DeclSpace here.
21131 2003-10-09 Martin Baulig <martin@ximian.com>
21133 * class.cs (MethodData): Added additional `DeclSpace ds' argument
21135 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
21136 EmitContext's .ctor.
21138 2003-10-09 Martin Baulig <martin@ximian.com>
21140 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
21141 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
21142 AsAccessible(), moved them as well.
21144 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
21146 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
21148 * cs-parser.jay : Renamed yyName to yyNames related to jay.
21150 2003-10-07 Miguel de Icaza <miguel@ximian.com>
21152 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
21153 generation for >=, as spotted by Paolo, bug 48679.
21154 Patch from David Waite.
21156 * cs-tokenizer.cs: Add handling for #pragma.
21158 * cs-parser.jay: Allow for both yield and yield return in the
21159 syntax. The anti-cobolization of C# fight will go on!
21161 * class.cs (TypeBuilder.DefineType): Catch error condition here
21162 (Parent.DefineType erroring out and returning null).
21164 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21165 coping with enumerations variables, we were mistakenly processing
21166 them as a regular value type instead of built-in types. Fixes the
21169 * typemanager.cs (IsBuiltinOrEnum): New method.
21171 2003-09-30 Miguel de Icaza <miguel@ximian.com>
21173 * cs-parser.jay: Upgrade: yield now needs the return clause.
21175 2003-09-19 Martin Baulig <martin@ximian.com>
21177 * decl.cs (MemberCache.SetupCacheForInterface): Take a
21178 `MemberCache parent' argument. Normally, an interface doesn't
21179 have a parent type except System.Object, but we use this in gmcs
21180 for generic type parameters.
21182 2003-09-18 Martin Baulig <martin@ximian.com>
21184 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21185 on `type.IsInterface'; don't check whether the type has a parent
21186 to determine whether it's an interface.
21188 2003-09-15 Martin Baulig <martin@ximian.com>
21190 * class.cs (TypeContainer.DefineType): Added an error flag to
21191 avoid reporting duplicate CS0146's ("class definition is
21194 * driver.cs (Driver.MainDriver): Abort if
21195 RootContext.ResolveTree() reported any errors.
21197 2003-09-07 Martin Baulig <martin@ximian.com>
21199 * report.cs (Error, Warning): Added overloaded versions which take
21200 a `params object[] args' and call String.Format().
21202 2003-09-07 Martin Baulig <martin@ximian.com>
21204 * decl.cs (DeclSpace..ctor): Don't call
21205 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21206 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21207 (DeclSpace.RecordDecl): New method.
21209 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21211 2003-09-02 Ravi Pratap <ravi@ximian.com>
21213 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21214 value attributes to be applied to ParameterBuilders.
21216 * class.cs (MethodCore.LabelParameters): Make static and more
21217 generic so that it can be used from other places - like interface
21218 methods, for instance.
21220 * interface.cs (Interface.Emit): Call LabelParameters before
21221 emitting attributes on the InterfaceMethod.
21223 2003-08-26 Martin Baulig <martin@ximian.com>
21225 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21226 resolving aliases; fixes #47927.
21228 2003-08-26 Martin Baulig <martin@ximian.com>
21230 * statement.cs (Using.DoResolve): This is internally emitting a
21231 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21232 do not always return. Fixes #47681.
21234 2003-08-26 Martin Baulig <martin@ximian.com>
21236 * decl.cs (MemberCore): Moved WarningNotHiding(),
21237 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21239 (AdditionResult): Make this nested in DeclSpace.
21240 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21241 argument; call NamespaceEntry.Define() unless we're nested in a
21244 * namespace.cs (Namespace.DefineName): New public function. This
21245 is called from DeclSpace's .ctor to add
21246 (Namespace.Lookup): Include DeclSpaces in the lookup.
21248 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21250 * const.cs (Const): Derive from MemberBase, not MemberCore.
21252 2003-08-25 Martin Baulig <martin@ximian.com>
21254 * convert.cs (Convert.ExplicitReferenceConversion): When
21255 converting from an interface type to a class, unbox if the target
21256 type is a struct type. Fixes #47822.
21258 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21260 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21263 2003-08-22 Martin Baulig <martin@ximian.com>
21265 * class.cs (TypeManager.DefineType): When defining a nested type,
21266 call DefineType() on our parent; fixes #47801.
21268 2003-08-22 Martin Baulig <martin@ximian.com>
21270 * class.cs (MethodData.Define): While checking if a method is an
21271 interface implementation, improve the test a bit more to fix #47654.
21273 2003-08-22 Martin Baulig <martin@ximian.com>
21275 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21276 correctly; fixes #47722.
21278 2003-08-22 Martin Baulig <martin@ximian.com>
21280 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21281 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21283 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21285 2003-08-22 Martin Baulig <martin@ximian.com>
21287 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21288 can only be assigned in static constructors. Fixes #47161.
21290 2003-08-22 Martin Baulig <martin@ximian.com>
21292 Rewrote and improved the flow analysis code.
21294 * flowbranching.cs (FlowBranching): Make this class abstract.
21295 (FlowBranching.CreateBranching): New static function to create a
21296 new flow branching.
21297 (FlowBranchingBlock, FlowBranchingException): New classes.
21298 (FlowBranching.UsageVector.Type): New public readonly field.
21299 (FlowBranching.UsageVector.Breaks): Removed the setter.
21300 (FlowBranching.UsageVector.Returns): Removed the setter.
21301 (FlowBranching.UsageVector): Added Break(), Return(),
21302 NeverReachable() and Throw() methods to modify the reachability.
21303 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21304 done by FlowBranching.Merge().
21305 (FlowBranching.UsageVector.MergeChild): New method; merges the
21306 merge result into the current vector.
21307 (FlowBranching.Merge): New abstract method to merge a branching.
21309 2003-08-12 Martin Baulig <martin@ximian.com>
21311 * expression.cs (Indirection.CacheTemporaries): Create the
21312 LocalTemporary with the pointer type, not its element type.
21314 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21316 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21317 token was a keyword or not.
21319 Add `error' options where an IDENTIFIER was expected; Provide
21320 CheckToken and CheckIdentifierToken convenience error reporting
21323 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21325 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21326 NameSpaceEntry NameSpaceEntry.
21328 (LookupInterfaceOrClass): Avoid creating a full qualified name
21329 from namespace and name: avoid doing lookups when we know the
21330 namespace is non-existant. Use new Tree.LookupByNamespace which
21331 looks up DeclSpaces based on their namespace, name pair.
21333 * driver.cs: Provide a new `parser verbose' to display the
21334 exception thrown during parsing. This is turned off by default
21335 now, so the output of a failure from mcs is more graceful.
21337 * namespace.cs: Track all the namespaces defined in a hashtable
21340 (IsNamespace): New method
21342 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21344 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21345 we know that we need to concatenate (full typename can never be
21350 * statement.cs: Use a bitfield; Do not initialize to null things
21351 which are done by the constructor by default.
21353 * cs-parser.jay: bug fix, parameter was 4, not 3.
21355 * expression.cs: Just use the property;
21357 * statement.cs: No need for GetVariableInfo method.
21359 2003-08-08 Martin Baulig <martin@ximian.com>
21361 * flowanalysis.cs (FlowReturns): This is now nested in the
21362 `FlowBranching' class.
21363 (MyBitVector): Moved this here from statement.cs.
21364 (FlowBranching.SiblingType): New enum type.
21365 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21367 2003-08-07 Martin Baulig <martin@ximian.com>
21369 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21370 `FlowBranching' class and called `BranchingType'.
21372 2003-08-07 Martin Baulig <martin@ximian.com>
21374 * flowanalysis.cs: Moved all the control flow analysis code into
21377 2003-08-07 Martin Baulig <martin@ximian.com>
21379 * assign.cs (Assign.DoResolve): `target' must either be an
21380 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21383 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21385 * expression.cs (BinaryMethod): This kind of expression is created by the
21386 Binary class if it determines that the operator has to be handled
21389 (BinaryDelegate): This kind of expression is created if we are
21390 dealing with a + or - operator on delegates.
21392 (Binary): remove method, argumetns, and DelegateOperator: when
21393 dealing with methods,
21395 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21397 * statement.cs (Block): use bitfields for the three extra booleans
21398 we had in use. Remove unused topblock parameter.
21400 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21402 * assign.cs: Drop extra unneeded tests.
21404 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21406 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21408 * statement.cs (Foreach): Use VariableStorage instead of
21411 * codegen.cs (VariableStorage): New class used by clients that
21412 require a variable stored: locals or fields for variables that
21413 need to live across yield.
21415 Maybe provide a convenience api for EmitThis+EmitLoad?
21417 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21420 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21422 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21423 RemapParameterLValue): New methods that are used to turn a
21424 precomputed FieldInfo into an expression like this:
21428 The idea is to use this instead of making LocalVariableReference
21429 have more than one meaning.
21431 * cs-parser.jay: Add error production to BASE.
21433 * ecore.cs: Deal with TypeManager.GetField returning null, which
21434 is now a valid return value.
21436 (FieldExprNoAddress): New expression for Fields whose address can
21439 * expression.cs (LocalVariableReference): During the resolve
21440 phases, create new expressions if we are in a remapping context.
21441 Remove code that dealt with remapping here.
21443 (ParameterReference): same.
21445 (ProxyInstance): New expression, like the `This' expression, but
21446 it is born fully resolved. We know what we are doing, so remove
21447 the errors that are targeted to user-provided uses of `this'.
21449 * statement.cs (Foreach): our variable is now stored as an
21450 Expression; During resolution, follow the protocol, dont just
21451 assume it will return this.
21453 2003-08-06 Martin Baulig <martin@ximian.com>
21455 * support.cs (SeekableStreamReader.cs): New public class.
21457 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21458 SeekableStreamReader instead of the normal StreamReader.
21460 2003-08-04 Martin Baulig <martin@ximian.com>
21462 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21463 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21464 deambiguate casts and delegate invocations.
21465 (parenthesized_expression): Use the new tokens to ensure this is
21466 not a cast of method invocation.
21468 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21469 when reading a `)' and Deambiguate_CloseParens () was previously
21472 * expression.cs (ParenthesizedExpression): New class. This is
21473 just used for the CS0075 test.
21474 (Binary.DoResolve): Check for CS0075.
21476 2003-07-29 Ravi Pratap <ravi@ximian.com>
21478 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21479 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21480 reference comparison.
21482 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21483 examine the ReturnType for equality - this is necessary in the
21484 cases of implicit and explicit operators whose signature also
21485 includes the return type.
21487 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21489 * namespace.cs: Cache the result of the namespace computation,
21490 instead of computing it every time.
21492 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21494 * decl.cs: Use a global arraylist that we reuse over invocations
21495 to avoid excesive memory consumption. Reduces memory usage on an
21496 mcs compile by one meg (45 average).
21498 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21499 private, work around that.
21501 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21503 * literal.cs (IntLiteral): Define Zero and One static literals.
21505 * cs-parser.jay (integer_literal): use static literals to reduce
21506 memory usage for the most used literals (0, 1 and -1). 211kb
21507 reduced in memory usage.
21509 Replace all calls to `new ArrayList' with `new
21510 ArrayList(4)' which is a good average number for most allocations,
21511 and also requires only 16 bytes of memory for its buffer by
21514 This reduced MCS memory usage in seven megabytes for the RSS after
21517 2003-07-28 Ravi Pratap <ravi@ximian.com>
21519 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21520 handle params methods the correct way by forming only one
21521 applicable set with params and normal methods in them. Earlier we
21522 were looking at params methods only if we found no normal methods
21523 which was not the correct thing to do.
21525 (Invocation.BetterFunction): Take separate arguments indicating
21526 when candidate and the best method are params methods in their
21529 This fixes bugs #43367 and #46199.
21531 * attribute.cs: Documentation updates.
21533 (CheckAttribute): Rename to CheckAttributeTarget.
21534 (GetValidPlaces): Rename to GetValidTargets.
21536 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21537 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21541 2003-07-28 Martin Baulig <martin@ximian.com>
21543 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21544 name when looking up the base class of a nested class. Fixes #46977.
21546 2003-07-26 Martin Baulig <martin@ximian.com>
21548 * expression.cs (Indexers.Indexer): New nested struct; contains
21549 getter, setter and the indexer's type.
21550 (Indexers.Properties): This is now an ArrayList of
21551 Indexers.Indexer's.
21552 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21553 indexer doesn't have any getters.
21555 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21556 for embedded property and indexer assignments.
21558 2003-07-26 Martin Baulig <martin@ximian.com>
21560 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21561 preprocessor directive is not the first non-whitespace character
21564 2003-07-26 Martin Baulig <martin@ximian.com>
21566 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21567 namespace parsing, follow the spec more closely.
21569 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21570 NamespaceEntry.Lookup().
21572 2003-07-25 Martin Baulig <martin@ximian.com>
21574 * MethodCore.cs (OverridesSomething): New public field; it's set
21575 from TypeContainer.DefineMembers if this method overrides
21576 something (which doesn't need to be a method). Fix #39462.
21578 2003-07-25 Ravi Pratap <ravi@ximian.com>
21580 * typemanager.cs (GetMembers): Ensure that the list of members is
21581 reversed. This keeps things in sync.
21583 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21584 find an AttributeUsage attribute.
21586 * expression.cs (Invocation.OverloadResolve): Perform the check
21587 which disallows Invoke to be directly called on a Delegate.
21589 (Error_InvokeOnDelegate): Report error cs1533.
21591 2003-07-25 Martin Baulig <martin@ximian.com>
21593 * expression.cs (Indexers.GetIndexersForType): Only look in the
21594 interface hierarchy if the requested type is already an
21595 interface. Fixes #46788 while keeping #46502 fixed.
21597 2003-07-25 Martin Baulig <martin@ximian.com>
21599 * class.cs (TypeContainer.DefineMembers): Check whether all
21600 readonly fields have been assigned and report warning CS0649 if
21603 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21606 2003-07-24 Ravi Pratap <ravi@ximian.com>
21608 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21609 returned from GetMethods to make things consistent with the
21610 assumptions MCS makes about ordering of methods.
21612 This should comprehensively fix bug #45127 and it does :-)
21614 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21615 ordering is actually reverse.
21617 * Clean up some debug messages I left lying around.
21619 * interface.cs (Populate*): Get rid of code which emits attributes
21620 since the stage in which we emit attributes is the 'Emit' stage,
21621 not the define stage.
21623 (Emit): Move attribute emission for interface members here.
21625 2003-07-22 Ravi Pratap <ravi@ximian.com>
21627 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21628 closely: we eliminate methods in base types when we have an
21629 applicable method in a top-level type.
21631 Please see section 14.5.5.1 for an exact description of what goes
21634 This fixes bug #45127 and a host of other related to corlib compilation.
21636 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21637 array is the method corresponding to the top-level type (this is
21638 because of the changes made to icall.c) so we change this
21641 (MethodGroupExpr.Name): This too.
21643 * typemanager.cs (GetElementType): New method which does the right
21644 thing when compiling corlib.
21646 * everywhere: Make use of the above in the relevant places.
21648 2003-07-22 Martin Baulig <martin@ximian.com>
21650 * cs-parser.jay (invocation_expression): Moved
21651 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21652 `cast_expression', but create a InvocationOrCast which later
21653 resolves to either an Invocation or a Cast.
21655 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21656 method; call this before EmitStatement() to make sure that this
21657 expression can be used as a statement.
21659 * expression.cs (InvocationOrCast): New class; resolves to either
21660 an Invocation or a Cast.
21662 * statement.cs (StatementExpression): Call ResolveStatement() on
21663 the ExpressionStatement before emitting it.
21665 2003-07-21 Martin Baulig <martin@ximian.com>
21667 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21668 `ref' and `out' attributes match; fixes #46220.
21669 (MemberAccess.ResolveMemberAccess): You can't reference a type
21670 through an expression; fixes #33180.
21671 (Indexers.GetIndexersForType): Don't return the indexers from
21672 interfaces the class implements; fixes #46502.
21674 2003-07-21 Martin Baulig <martin@ximian.com>
21676 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21677 CS0661 checks; fixes bug #30442.
21679 2003-07-21 Martin Baulig <martin@ximian.com>
21681 * decl.cs (AdditionResult): Added `Error'.
21683 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21685 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21686 makes cs0031.cs actually work.
21688 2003-07-20 Martin Baulig <martin@ximian.com>
21690 * namespace.cs: Fixed that bug which caused a crash when compiling
21691 the debugger's GUI.
21693 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21695 * typemanager.cs (LookupTypeReflection): Never expose types which
21696 are NotPublic, NestedPrivate, NestedAssembly, or
21697 NestedFamANDAssem. We used to return these, and later do a check
21698 that would report a meaningful error, but the problem is that we
21699 would not get the real match, if there was a name override.
21701 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21703 * namespace.cs (Namespace, Name): Do not compute the namespace
21704 name dynamically, compute it in the constructor. This reduced
21705 memory usage by 1697 KB.
21707 * driver.cs: Use --pause to pause at the end.
21709 2003-07-17 Peter Williams <peter@newton.cx>
21711 * Makefile: Change the name of the test target so that it doesn't
21712 conflict with the recursive test target.
21714 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21716 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21717 AddressOf): Do not use EmitThis, that was wrong, use the actual
21720 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21722 * class.cs (MethodData.Define): While checking if a method is an
21723 interface implementation, improve the test: If we are not public
21724 (use new test here: use the computed MethodAttributes directly,
21725 instead of the parsed modifier flags) check if the `implementing'
21726 method comes from an interface or not.
21728 * pending.cs (VerifyPendingMethods): Slightly better error
21731 * makefile: add test target that does the mcs bootstrap.
21733 2003-07-16 Ravi Pratap <ravi@ximian.com>
21735 * interface.cs (Define): Do nothing here since there are no
21736 members to populate etc. Move the attribute emission out of here
21737 since this was just totally the wrong place to put it. Attribute
21738 application happens during the 'Emit' phase, not in the 'Define'
21741 (Emit): Add this method and move the attribute emission here
21743 * rootcontext.cs (EmitCode): Call the Emit method on interface
21746 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21748 * expression.cs (OverloadResolve): Report error only if Location
21749 is not 'Null' which means that there was a probe going on.
21751 2003-07-14 Martin Baulig <martin@ximian.com>
21753 * expression.cs (ConditionalLogicalOperator): New public class to
21754 implement user defined conditional logical operators.
21755 This is section 14.11.2 in the spec and bug #40505.
21757 2003-07-14 Martin Baulig <martin@ximian.com>
21759 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21761 2003-07-14 Martin Baulig <martin@ximian.com>
21763 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21765 * ecore.cs (IVariable.VerifyFixed): New interface method.
21767 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21768 operator, check whether the variable is actually fixed. Fixes bug
21769 #36055. Set a variable definitely assigned when taking its
21770 address as required by the spec.
21772 * statement.cs (LocalInfo.IsFixed): New field.
21773 (LocalInfo.MakePinned): Set `IsFixed' to true.
21775 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21777 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21778 for .ctors, ensure that we only ask for members declared in the
21779 attribute type (BindingFlags.DeclaredOnly).
21783 * expression.cs (Error_WrongNumArguments): Report error 1501
21784 correctly the way CSC does.
21786 2003-07-13 Martin Baulig <martin@ximian.com>
21788 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21789 lookup on the fully qualified name, to make things like "X.X" work
21790 where "X.X" is a fully qualified type name, but we also have a
21791 namespace "X" in the using list. Fixes #41975.
21793 2003-07-13 Martin Baulig <martin@ximian.com>
21795 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21796 function. If we're a CompoundAssign, we need to create an embedded
21797 CompoundAssign, not an embedded Assign.
21798 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21801 2003-07-13 Martin Baulig <martin@ximian.com>
21803 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21804 work to fix bug #46088.
21806 2003-07-13 Ravi Pratap <ravi@ximian.com>
21808 * class.cs (Operator.Emit): Do not emit attributes here - it is
21809 taken care of by the Method class that we delegate too. This takes
21810 care of bug #45876.
21812 2003-07-10 Martin Baulig <martin@ximian.com>
21814 * expression.cs (TypeOfVoid): New class.
21815 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21817 2003-07-10 Martin Baulig <martin@ximian.com>
21819 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21822 2003-07-10 Martin Baulig <martin@ximian.com>
21824 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21825 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21827 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21829 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21831 2003-07-10 Martin Baulig <martin@ximian.com>
21833 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21834 of decimal. Fixes #42850.
21836 NOTE: I also fixed the created byte blob, but this doesn't work on
21837 the MS runtime and csc never produces any byte blobs for decimal
21840 2003-07-10 Martin Baulig <martin@ximian.com>
21842 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21843 structs; fixes #32068.
21844 (Block.AddChildVariableNames): Fixed #44302.
21846 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21848 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21850 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21852 * attribute.cs: And this test is onger needed.
21854 2003-07-08 Martin Baulig <martin@ximian.com>
21856 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21857 inaccessible types. Fixes #36313.
21859 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21861 * namespace.cs (NamespaceEntry): Create implicit entries for all
21862 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21863 implicit entries for N1.N2 and N1.
21865 2003-07-08 Martin Baulig <martin@ximian.com>
21867 Rewrote the handling of namespaces to fix a lot of the issues
21868 wrt. `using' aliases etc.
21870 * namespace.cs (Namespace): Splitted this class into a
21871 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21873 * typemanager.cs (TypeManager.IsNamespace): Removed.
21874 (TypeManager.ComputeNamespaces): Only compute namespaces from
21875 loaded assemblies here, not the namespaces from the assembly we're
21876 currently compiling.
21878 2003-07-08 Martin Baulig <martin@ximian.com>
21880 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21882 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21884 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21887 I thought about the memory savings here, but LookupTypeReflection
21888 is used under already very constrained scenarios. Compiling
21889 corlib or mcs only exposes one hit, so it would not really reduce
21890 any memory consumption.
21892 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21894 * typemanager.cs: fixes bug #45889 by only adding public types from
21895 other assemblies to the list of known types.
21897 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21899 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21900 on the type we resolved.
21902 2003-07-05 Martin Baulig <martin@ximian.com>
21904 * pending.cs (PendingImplementation.ParentImplements): Don't
21905 create the proxy if the parent is abstract.
21907 * class.cs (TypeContainer.DefineIndexers): Process explicit
21908 interface implementations first. Fixes #37714.
21910 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21912 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21913 defined recursively; but since we modify the input parameters
21914 (left is set to `this' temporarily), we reset this value if the
21915 left_is_explicit is false, which gives the original semantics to
21918 * literal.cs (NullPointer): new class used to represent a null
21919 literal in a pointer context.
21921 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21922 type is a pointer, use a NullPointer object instead of a
21923 NullLiteral. Closes 43687
21925 (ExplicitConversion): Convert pointer values using
21926 the conv opcode to the proper type.
21928 * ecore.cs (New): change ValueTypeVariable property into a method,
21929 that returns whether the valuetype is suitable for being used.
21931 * expression.cs (Binary.DoNumericPromotions): Only return if we
21932 the int constant was a valid uint, and we can return both left and
21933 right as uints. If not, we continue processing, to trigger the
21934 type conversion. This fixes 39018.
21936 * statement.cs (Block.EmitMeta): During constant resolution, set
21937 the CurrentBlock property on the emitcontext, so that we resolve
21938 constants propertly.
21940 2003-07-02 Martin Baulig <martin@ximian.com>
21942 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21943 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21945 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21946 than emitting it here.
21948 * statement.cs: Fixed some more flow analysis bugs.
21950 2003-07-02 Martin Baulig <martin@ximian.com>
21952 * class.cs (MethodData.Define): When implementing interface
21953 methods, set Final unless we're Virtual.
21955 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21956 check work for interface methods.
21958 2003-07-01 Martin Baulig <martin@ximian.com>
21960 * ecore.cs (EmitContext.This): Replaced this property with a
21961 GetThis() method which takes a Location argument. This ensures
21962 that we get the correct error location for a CS0188.
21964 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21966 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21967 ImplicitStandardConversion.
21969 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21971 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21973 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21976 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21978 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21981 (MethodData.Define): Turn off initlocals for unsafe methods.
21983 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21985 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21986 complete; Fixes #37521.
21988 * delegate.cs: Use Modifiers.TypeAttr to compute the
21989 TypeAttributes, instead of rolling our own. This makes the flags
21990 correct for the delegates.
21992 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21994 * class.cs (Constructor.Define): Set the private flag for static
21995 constructors as well.
21997 * cs-parser.jay (statement_expression): Set the return value to
21998 null, to avoid a crash when we catch an error.
22000 2003-06-24 Miguel de Icaza <miguel@ximian.com>
22002 * cs-parser.jay: Applied patch from Jackson that adds support for
22003 extern and unsafe modifiers to destructor declarations.
22005 * expression.cs: Report error 21 if the user is trying to index a
22008 * driver.cs: Add an error message, suggested by the bug report.
22010 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
22011 if we do not have a ": this ()" constructor initializer. Fixes 45149
22013 2003-06-14 Miguel de Icaza <miguel@ximian.com>
22015 * namespace.cs: Add some information to reduce FAQs.
22017 2003-06-13 Miguel de Icaza <miguel@ximian.com>
22019 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
22020 underlying enumeration types. Fixes #43915.
22022 * expression.cs: Treat ushort/short as legal values to be used in
22023 bitwise operations.
22025 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
22027 * delegate.cs: transfer custom attributes for paramenters from
22028 the delegate declaration to Invoke and BeginInvoke.
22030 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
22032 * attribute.cs: handle custom marshalers and emit marshal info
22035 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
22037 * makefile.gnu: Added anonymous.cs to the compiler sources.
22039 2003-05-28 Miguel de Icaza <miguel@ximian.com>
22041 * iterators.cs: Change the name of the proxy class to include two
22044 * cs-parser.jay: Update grammar to include anonymous methods.
22046 * anonymous.cs: new file.
22048 2003-05-27 Miguel de Icaza <miguel@ximian.com>
22050 * class.cs (Field.Define): Add missing test for pointers and
22053 2003-05-27 Ravi Pratap <ravi@ximian.com>
22055 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
22056 we use the stobj opcode.
22058 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
22059 since it wasn't the correct fix.
22061 It still is puzzling that we are required to use stobj for IntPtr
22062 which seems to be a ValueType.
22064 2003-05-26 Miguel de Icaza <miguel@ximian.com>
22066 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
22067 during regular simple name resolution. Now, the trick is that
22068 instead of returning for processing the simplename, we do a
22069 TypeManager.LookupType (ie, a rooted lookup as opposed to a
22070 contextual lookup type). If a match is found, return that, if
22071 not, return for further composition.
22073 This fixes long-standing 30485.
22075 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
22076 using the address to initialize an object, do an Stobj instead of
22077 using the regular Stelem.
22079 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
22080 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
22081 Because if we are a BaseIndexerAccess that value will be true.
22084 * statement.cs (GotoCase.Resolve): Return after reporting an
22085 error, do not attempt to continue.
22087 * expression.cs (PointerArithmetic.Emit): If our operand is a
22088 long, convert our constants to match the operand before
22089 multiplying. Convert to I type before adding. Fixes 43670.
22091 2003-05-14 Ravi Pratap <ravi@ximian.com>
22093 * enum.cs (ImplicitConversionExists) : Rename to
22094 ImplicitEnumConversionExists to remove ambiguity.
22096 * ecore.cs (NullCast): New type of cast expression class which
22097 basically is very similar to EmptyCast with the difference being
22098 it still is a constant since it is used only to cast a null to
22100 (eg. (string) null)
22102 * convert.cs (ImplicitReferenceConversion): When casting a null
22103 literal, we return a NullCast.
22105 * literal.cs (NullLiteralTyped): Remove - I don't see why this
22106 should be around anymore.
22108 The renaming (reported was slightly wrong). Corrections:
22110 ConvertImplicitStandard -> ImplicitConversionStandard
22111 ConvertExplicitStandard -> ExplicitConversionStandard
22113 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
22114 before passing them in !
22116 * convert.cs (ImplicitConversionStandard): When comparing for
22117 equal expr and target types, ensure that expr is not a
22120 In general, we must not be checking (expr_type ==
22121 target_type) in the top level conversion methods
22122 (ImplicitConversion, ExplicitConversion etc). This checking is
22123 done in the methods that they delegate to.
22125 2003-05-20 Miguel de Icaza <miguel@ximian.com>
22127 * convert.cs: Move Error_CannotConvertType,
22128 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
22129 ImplicitNumericConversion, ImplicitConversionExists,
22130 ImplicitUserConversionExists, StandardConversionExists,
22131 FindMostEncompassedType, FindMostSpecificSource,
22132 FindMostSpecificTarget, ImplicitUserConversion,
22133 ExplicitUserConversion, GetConversionOperators,
22134 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
22135 TryImplicitIntConversion, Error_CannotConvertImplicit,
22136 ConvertImplicitRequired, ConvertNumericExplicit,
22137 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
22138 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
22141 Perform the following renames:
22143 StandardConversionExists -> ImplicitStandardConversionExists
22144 ConvertImplicit -> ImplicitConversion
22145 ConvertImplicitStandard -> ImplicitStandardConversion
22146 TryImplicitIntConversion -> ImplicitIntConversion
22147 ConvertImplicitRequired -> ImplicitConversionRequired
22148 ConvertNumericExplicit -> ExplicitNumericConversion
22149 ConvertReferenceExplicit -> ExplicitReferenceConversion
22150 ConvertExplicit -> ExplicitConversion
22151 ConvertExplicitStandard -> ExplicitStandardConversion
22153 2003-05-19 Martin Baulig <martin@ximian.com>
22155 * statement.cs (TypeInfo.StructInfo): Made this type protected.
22156 (TypeInfo): Added support for structs having structs as fields.
22158 * ecore.cs (FieldExpr): Implement IVariable.
22159 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
22160 VariableInfo for the field.
22162 2003-05-18 Martin Baulig <martin@ximian.com>
22164 * expression.cs (This.DoResolve): Report a CS0027 if we're
22165 emitting a field initializer.
22167 2003-05-18 Martin Baulig <martin@ximian.com>
22169 * expression.cs (This.ResolveBase): New public function.
22170 (This.DoResolve): Check for CS0188.
22172 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
22175 * ecore.cs (MethodGroupExpr.DoResolve): Set the
22176 `instance_expression' to null if we don't have any non-static
22179 2003-05-18 Martin Baulig <martin@ximian.com>
22181 Reworked the way how local variables and parameters are handled by
22182 the flow analysis code.
22184 * statement.cs (TypeInfo, VariableMap): New public classes.
22185 (VariableInfo): New public class. This is now responsible for
22186 checking whether a variable has been assigned. It is used for
22187 parameters and local variables.
22188 (Block.EmitMeta): Take the InternalParameters as argument; compute
22189 the layout of the flow vectors here.
22190 (Block.LocalMap, Block.ParameterMap): New public properties.
22191 (FlowBranching): The .ctor doesn't get the InternalParameters
22192 anymore since Block.EmitMeta() now computes the layout of the flow
22194 (MyStructInfo): This class is now known as `StructInfo' and nested
22195 in `TypeInfo'; we don't access this directly anymore.
22197 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22198 property and removed IsAssigned(), IsFieldAssigned(),
22199 SetAssigned() and SetFieldAssigned(); we now call them on the
22200 VariableInfo so we don't need to duplicate this code everywhere.
22202 * expression.cs (ParameterReference): Added `Block block' argument
22204 (LocalVariableReference, ParameterReference, This): The new
22205 VariableInfo class is now responsible for all the definite
22208 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22209 IsParameterAssigned, SetParameterAssigned): Removed.
22211 2003-05-18 Martin Baulig <martin@ximian.com>
22213 * typemanager.cs (InitCoreTypes): Try calling
22214 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22215 the 3-args-version. Corlib now also needs our `void_type'.
22216 (GetMethod): Added overloaded version which takes an optional
22217 `bool report_errors' to allow lookups of optional methods.
22219 2003-05-12 Martin Baulig <martin@ximian.com>
22221 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22222 only used for locals and not for parameters.
22224 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22226 * support.cs (InternalParameters.ParameterType): Return the
22227 ExternalType of the parameter.
22229 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22232 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22234 * class.cs (MethodData.Define): Do not set the `newslot' on
22235 interface members, if they are also flagged as "override".
22237 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22238 better code for ++i and i++. This only works for static fields
22239 and local variables.
22241 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22242 want to pull the DeclSpace out of the builder_to_declspace instead
22243 of the TypeBuilder (like in TypeContainer.FindMembers).
22245 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22246 instead of LookupTypeContainer. Fixes the crash on .NET for
22247 looking up interface members.
22249 * const.cs: Create our own emit context during the Definition
22250 stage, so that constants are evaluated in the proper context, when
22251 a recursive definition happens.
22253 2003-05-11 Martin Baulig <martin@ximian.com>
22255 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22256 new block for a switch section.
22257 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22258 the adding/lookup in the switch block. Fixes #39828.
22260 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22262 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22263 functionality: I needed to convert the data after I had performed
22264 the add/sub operation into the operands type size.
22266 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22267 pass the type for the box operation, otherwise the resulting
22268 object would have been of type object.
22270 (BoxedCast): Add constructor to specify the type to box as.
22272 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22274 * iterators.cs: I was reusing the `count' variable inadvertently,
22275 take steps to not allow this to happen.
22277 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22279 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22280 by creating an array at the point where the params starts and
22281 putting all those arguments there, then adjusting the size of the
22284 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22286 * expression.cs (New.AddressOf): Implement interface
22287 IMemoryLocation. This is used when the `new' operator is used in
22288 the context of an invocation to a method on a value type.
22290 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22293 * namespace.cs: Also check the using aliases here.
22295 * driver.cs: Move the test for using validity after the types have
22296 been entered, so we do a single pass that also includes the using
22299 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22300 in the regular case. CreateSiblingForFinally is doing extra
22303 * attribute.cs (GetAttributeArgumentExpression): Store the result
22304 on an out value, and use the return value to indicate failure
22305 instead of using null (which is a valid return for Constant.GetValue).
22307 * statement.cs: Perform the analysis flow for the increment
22308 portion after the statement, because this will be the real flow of
22309 execution. Fixes #42385
22311 * codegen.cs (EmitContext.EmitArgument,
22312 EmitContext.EmitStoreArgument): New helper functions when the
22313 RemapToProxy flag is set.
22315 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22318 Add support for remapping parameters.
22320 * iterators.cs: Propagate parameter values; Store parameter
22321 values in the proxy classes.
22323 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22325 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22326 need a proxy reference; I do not know what I was thinking
22328 * cs-parser.jay (constructor_initializer): catch another error,
22329 and display nice message.
22331 (field_declaration): catch void field declaration
22332 to flag a better error.
22334 * class.cs (MemberBase.CheckBase): Report an error instead of a
22335 warning if a new protected member is declared in a struct.
22336 (Field.Define): catch the error of readonly/volatile.
22338 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22340 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22341 volatile variable is taken
22343 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22345 * statement.cs (Fixed.Resolve): Report an error if we are not in
22348 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22350 * typemanager.cs: reuse the code that handles type clashes for
22351 delegates and enumerations.
22353 * class.cs (Report28): Always report.
22355 * expression.cs (EncodeAsAttribute): Allow nulls here.
22357 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22359 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22360 the functionality for testing whether an expression is valid for
22361 an attribute here. Also handle the case of arrays of elements
22364 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22365 encoding a linear array into an array of objects that are suitable
22366 to be passed to an CustomAttributeBuilder.
22368 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22370 * ecore.cs: (FieldExpr): Handle field remapping here.
22372 * iteratators.cs: Pass the instance variable (if the method is an
22373 instance method) to the constructors, so we can access the field
22374 variables on the class.
22376 TODO: Test this with structs. I think the THIS variable on
22377 structs might have to be a pointer, and not a refenrece
22379 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22381 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22382 local variables to fields in a proxy class.
22384 * iterators.cs (PopulateProxy): Rename our internal fields to
22386 Create a <THIS> field if we are an instance method, so we can
22387 reference our parent container variables.
22388 (MapVariable): Called back from the EmitContext code to enter a
22389 new variable to field mapping into the proxy class (we just create
22393 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22394 for using the remapped locals to fields.
22396 I placed the code here, because that gives the same semantics to
22397 local variables, and only changes the Emit code.
22399 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22400 statements inside iterators.
22401 (VariableInfo): Add a FieldBuilder for the cases when we are
22402 remapping local variables to fields in a proxy class
22404 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22405 current_block != null.
22407 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22408 not cope with strings, as it has been moved to the
22409 TableSwitchEmit. Fixed bug in switch generation.
22411 * expression.cs (New.DoResolve): Provide more context for the user
22412 when reporting an error.
22414 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22417 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22418 check the permissions for it. Note than in a type-resolution
22419 context the check was already present in DeclSpace.ResolveType,
22420 but was missing from the MemberAccess.
22422 (ArrayCreation.CheckIndices): warn if the user has
22423 more nested levels of expressions, but there are no more
22424 dimensions specified. Avoids crash on bug 41906.
22426 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22428 * statement.cs (Block): replace Implicit bool, for a generic
22430 New flag: `Unchecked'. This is used during the EmitMeta phase
22431 (which is out-of-line with the regular Resolve/Emit process for a
22432 statement, as this is done ahead of time, but still gets a chance
22433 to call constant resolve).
22435 (Block.Flags): new enum for adding a new flag.
22437 (Block.EmitMeta): track the state of unchecked.
22439 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22440 to enable constant resolution to work there as well.
22442 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22444 * typemanager.cs (ienumerable_type): Also look up
22445 System.Collections.IEnumerable.
22447 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22449 TODO: Test more than one conditional per method.
22451 * class.cs (Indexer.Define): Report the location where the user is
22452 referencing the unsupported feature.
22454 (MethodData): Overload the use of `conditionals' to
22455 minimize the creation of needless ArrayLists. This saves roughly
22456 212kb on my machine.
22458 (Method): Implement the new IIteratorContainer interface.
22459 (Method.SetYields): Implement the method by setting the ModFlags
22460 to contain METHOD_YIELDS.
22462 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22463 which just got set to null.
22465 * iterators.cs: New file.
22467 (Yield, YieldBreak): New statements.
22469 * statement.cs (Return.Resolve): Flag an error if we are used in
22470 an iterator method.
22472 * codegen.cs (InIterator): New flag set if the code is being
22473 compiled in an iterator method.
22475 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22476 internal modifier, and we just use it to avoid adding extra
22477 fields, as this is seldom used.
22479 * cs-parser.jay: Add yield_statement (yield and yield break).
22481 * driver.cs: New flag -v2 to turn on version 2 features.
22483 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22484 hashtable when v2 is enabled.
22486 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22488 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22489 there is already a namespace defined with this name.
22491 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22492 people upgraded their corlibs.
22494 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22495 always use fully qualified types, no need to use the compiler
22498 (TypeManager.IsNamespace): Use binarysearch.
22500 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22501 AddDelegate): I did not quite use the new IsValid API properly: I
22502 have to pass the short-name and the fullname. I was passing only
22503 the basename instead of the fullname sometimes.
22505 (TypeContainer.DefineType): call NamespaceClash.
22507 * interface.cs (Interface.DefineType): use NamespaceClash before
22510 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22513 * enum.cs: (Enum.DefineType): use NamespaceClash before
22516 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22517 speed increase. First, use the negative_hits cache when we get a
22518 negative. Second, add the type with its full original name
22519 instead of the new . and + encoded name (reflection uses + to
22520 separate type from a nested type). Use LookupTypeReflection
22521 directly which bypasses the type->name hashtable (that we already
22522 know does not contain the type.
22524 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22525 location/container type.
22527 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22529 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22531 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22533 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22534 method is being referenced in the method group from a static
22535 context, and report error 120 if so.
22537 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22540 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22541 is created, we create the A namespace).
22543 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22546 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22548 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22549 invocation to ModuleBuilder.GetType with the same values will
22550 return a new type instance, so we need to cache its return
22553 * expression.cs (Binary.ResolveOperator): Only allow the compare
22554 operators on enums if they are of the same type.
22556 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22557 types of ValueType on their own case. Before we were giving them
22558 the same treatment as objects.
22560 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22561 fullname. Short name is used to compare against container name.
22562 Fullname is used to check against defined namespace names.
22564 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22565 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22567 (Method.CheckBase): Call parent.
22568 (MemberBase.CheckBase): Check for protected members on sealed
22570 (PropertyBase.CheckBase): Call parent.
22571 (Field.Define): Call parent.
22573 * report.cs: Negative error codes are now mapped to 8000 - code,
22574 so that the display is render more nicely.
22576 * typemanager.cs: Do not use try/catch, instead report a regular
22579 (GetPointerType, GetReferenceType): These methods provide
22580 mechanisms to obtain the T* and T& from a T. We had the code
22581 previously scattered around the code base, and it also used
22582 TypeManager.LookupType that would go through plenty of caches.
22583 This one goes directly to the type source.
22585 In some places we did the Type.GetType followed by
22586 ModuleBuilder.GetType, but not in others, so this unifies the
22587 processing as well.
22589 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22590 statements now that we have namespace information.
22592 * typemanager.cs (IsNamespace): New method, returns whether the
22593 string presented is a namespace or not.
22595 (ComputeNamespaces): New public entry point, computes the list of
22596 available namespaces, using the GetNamespaces API call in Mono, or
22597 the slower version in MS.NET.
22599 Now before we start the semantic analysis phase, we have a
22600 complete list of namespaces including everything that the user has
22603 Deleted old code to cache namespaces in .nsc files.
22605 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22607 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22608 class/struct location definition Location for the implicit
22609 constructor location.
22611 (Operator.Define): Use the location of the operator for the
22612 implicit Method definition.
22614 (Constructor.Emit): use the constructor location for the implicit
22615 base initializer constructor.
22617 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22618 and the Expression class now contains two new methods:
22620 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22621 isolate type lookup from the rest of the resolution process.
22623 Since we use Expressions to hold type definitions due to the way
22624 we parse the input we have historically overloaded Resolve to
22625 perform the Type lookups if a special flag is passed. Now this is
22626 eliminated and two methods take their place.
22628 The differences in the two methods between xStep and xTerminal is
22629 that xStep is involved in our current lookup system that uses
22630 SimpleNames to compose a name, while xTerminal is used just to
22631 catch the case where the simplename lookup failed.
22633 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22635 * expression.cs (ResolveMemberAccess): Remove redundant code.
22636 TypeExpr expressions are always born fully resolved.
22638 * interface.cs (PopulateMethod): Do not lookup the types twice.
22639 We were doing it once during SemanticAnalysis and once during
22642 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22643 in local variable type definitions, were being returned as a
22644 SimpleName (we decomposed everything into a string), that is
22645 because primary_expression was being used instead of a type in the
22646 grammar (reduce/reduce conflicts).
22648 The part that was wrong is that we converted the expression into a
22649 string (an oversimplification in one hand, compounded with primary
22650 expressions doing string concatenation).
22656 Would return "A.B.C[]" as a SimpleName. This stopped things like
22657 using clauses from working on this particular context. And a type
22658 was being matched directly against "A.B.C[]".
22660 We now use the correct approach, and allow for ComposedCast to be
22661 part of the unary expression. So the "A.B.C []" become a composed
22662 cast of "A.B.C" (as a nested group of MemberAccess with a
22663 SimpleName at the end) plus the rank composition "[]".
22667 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22669 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22670 for the access level checking.
22672 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22673 `TypeContainer container', because I kept getting confused when I
22674 was debugging this code.
22676 * expression.cs (Indexers): Instead of tracking getters/setters,
22677 we now track them in parallel. We create one arraylist less, but
22678 most importantly it is possible now for the LValue code to find a
22679 matching get for a set.
22681 (IndexerAccess.DoResolveLValue): Update the code.
22682 GetIndexersForType has been modified already to extract all the
22683 indexers from a type. The code assumed it did not.
22685 Also make the code set the correct return type for the indexer.
22686 This was fixed a long time ago for properties, but was missing for
22687 indexers. It used to be void_type.
22689 (Binary.Emit): Test first for doubles instead of
22690 floats, as they are more common.
22692 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22693 when dealing with floats and the <=, >= operators. This fixes bug
22696 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22697 to load the array value by emitting a load on the foreach variable
22698 type. This was incorrect.
22700 We now emit the code to load an element using the the array
22701 variable type, and then we emit the conversion operator.
22705 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22707 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22709 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22711 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22712 test for protection before we test for signatures.
22714 (MethodSignature.ToString): implement.
22716 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22717 to the case where we reduced into a LongConstant.
22719 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22720 depend on whether the information is acurrate, because the
22721 Microsoft runtime will always claim that the array type is public,
22722 regardless of the real state.
22724 If the type is a pointer, another problem happens: the type is
22725 reported as non-public in Microsoft.
22727 In both cases we have to call CheckAccessLevel recursively with
22728 the underlying type as the argument to be tested.
22730 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22732 * assign.cs (Assign.Emit): If we are dealing with a compound
22733 assignment expression, we should use the code path that stores the
22734 intermediate result in a temporary value. This fixes #40903.
22736 *expression.cs (Indirection.ToString): Provide ToString method for
22739 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22741 * class.cs: Null out fields holding references to Block objects so
22742 they can be garbage collected.
22744 * expression.cs (OverloadResolve): Remove unused local.
22746 2003-04-07 Martin Baulig <martin@ximian.com>
22748 * codegen.cs (EmitContext.CurrentFile): New public field.
22749 (EmitContext.Mark): Use the CurrentFile to check whether the
22750 location is in the correct file.
22751 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22753 2003-04-07 Martin Baulig <martin@ximian.com>
22755 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22757 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22758 location. [FIXME: The location argument which gets passed to this
22759 method is sometimes wrong!]
22761 2003-04-07 Nick Drochak <ndrochak@gol.com>
22763 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22765 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22767 * expression.cs (Indirection.EmitAssign): We were using the
22768 temporary, but returning immediately instead of continuing the
22771 2003-04-06 Martin Baulig <martin@ximian.com>
22773 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22774 if it's a nested child, but also deriving from the outer class.
22777 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22778 nested child, but also deriving from the outer class. See
22780 (FilterWithClosure): We may access private members of the outer
22781 class if we're a nested child and deriving from the outer class.
22782 (RealMemberLookup): Only set `closure_private_ok' if the
22783 `original_bf' contained BindingFlags.NonPublic.
22785 2003-04-05 Martin Baulig <martin@ximian.com>
22787 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22789 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22791 * class.cs (Event.Define): Do not allow abstract events to have
22794 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22796 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22797 block in event declarations.
22799 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22800 value type, get its address.
22802 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22803 leaving a class on the stack instead of a boolean value (int
22804 0/1). Change the code so we compare against null, and then the
22805 result against zero.
22807 * class.cs (TypeContainer.GetClassBases): We were checking for the
22808 parent class being sealed too late.
22810 * expression.cs (Binary.Emit): For <= and >= when dealing with
22811 floating point values, use cgt.un and clt.un instead of cgt and
22814 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22816 * statement.cs: Apply the same optimization as MS: skip the
22817 GetEnumerator returning an IEnumerator, and use the one returning a
22818 CharEnumerator instead. This allows us to avoid the try-finally block
22821 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22823 * cs-parser.jay: Attributes cannot be applied to
22824 namespaces. Fixes #40473
22826 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22829 (Add*): check if the name is valid using the full name for constants,
22830 fields, properties and events.
22832 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22834 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22835 char constants to be part of the enumeration.
22837 * expression.cs (Conditional.DoResolve): Add support for operator
22838 true. Implements the missing functionality from 14.12
22840 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22841 operator true/false as required by the spec.
22843 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22844 implicit conversion to boolean.
22846 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22847 also one where the type implements `operator true'.
22849 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22850 get an expression that will invoke operator true based on an
22853 (GetConversionOperators): Removed the hack that called op_True
22856 (Expression.ResolveBoolean): Move this from Statement.
22858 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22860 * ecore.cs (FieldExpr): do not allow initialization of initonly
22861 fields on derived classes
22863 2003-03-13 Martin Baulig <martin@ximian.com>
22865 * statement.cs (Block.Emit): Call ig.BeginScope() and
22866 ig.EndScope() when compiling with debugging info; call
22867 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22869 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22871 * expression.cs (Indexers): Do not construct immediately, allow
22872 for new members to be appended as we go. Fixes 38143
22874 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22876 * expression.cs: save/restore context when resolving an unchecked
22879 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22881 * cfold.cs: Catch division by zero in modulus operator during
22884 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22886 * interface.cs (Interface.DefineMembers): Avoid defining members
22889 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22891 * driver.cs: handle the +/- options for -noconfig
22893 * statement.cs (Unckeched.Resolve): Also track the state of
22894 unchecked in the Resolve phase.
22896 2003-02-27 Martin Baulig <martin@ximian.com>
22898 * ecore.cs (Expression.MemberLookup): Don't create a
22899 MethodGroupExpr for something which is not a method. Fixes #38291.
22901 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22903 * class.cs (MemberBase.CheckParameters): Also check that the type
22904 is unmanaged if it is a pointer.
22906 * expression.cs (SizeOf.Resolve): Add location information.
22908 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22909 a managed type is declared.
22911 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22912 parameter modifiers as well. Fixes bug 38606
22914 * class.cs: Very sad. Am backing out the speed up changes
22915 introduced by the ArrayList -> Array in the TypeContainer, as they
22916 were not actually that much faster, and introduced a bug (no error
22917 reports on duplicated methods).
22919 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22920 source first, this will guarantee that we have a valid expression
22921 before calling in lower levels functions that will require a
22922 resolved object. Then use this original_source in the
22923 target.ResolveLValue instead of the original source that was
22926 Another change. Use target.Resolve instead of LValueResolve.
22927 Although we are resolving for LValues, we will let the Assign code
22928 take care of that (it will be called again from Resolve). This
22929 basically allows code like this:
22931 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22932 class Y { void A (X x) { x [0] += o; }
22934 The problem was that the indexer was trying to resolve for
22935 set_Item (idx, object o) and never finding one. The real set_Item
22936 was set_Item (idx, X). By delaying the process we get the right
22941 2003-02-23 Martin Baulig <martin@ximian.com>
22943 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22944 while calling DoEmit ().
22946 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22947 source files; if you use the #line directive inside a method, the
22948 compiler stops emitting line numbers for the debugger until it
22949 reaches the end of the method or another #line directive which
22950 restores the original file.
22952 2003-02-23 Martin Baulig <martin@ximian.com>
22954 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22956 2003-02-23 Martin Baulig <martin@ximian.com>
22958 * statement.cs (Block.AddChildVariableNames): We need to call this
22959 recursively, not just for our immediate children.
22961 2003-02-23 Martin Baulig <martin@ximian.com>
22963 * class.cs (Event.Define): Always make the field private, like csc does.
22965 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22966 actually work, fixes bug #37521.
22968 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22970 * delegate.cs: When creating the various temporary "Parameters"
22971 classes, make sure that we call the ComputeAndDefineParameterTypes
22972 on those new parameters (just like we do with the formal ones), to
22973 allow them to be resolved in the context of the DeclSpace.
22975 This fixes the bug that Dick observed in Bugzilla #38530.
22977 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22979 * expression.cs (ResolveMemberAccess): When resolving a constant,
22980 do not attempt to pull a constant if the value was not able to
22981 generate a valid constant.
22983 * const.cs (LookupConstantValue): Do not report more errors than required.
22985 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22987 * expression.cs: fixes bug #38328.
22989 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22991 * class.cs: Changed all the various members that can be part of a
22992 class from being an ArrayList to be an Array of the right type.
22993 During the DefineType type_list, interface_list, delegate_list and
22994 enum_list are turned into types, interfaces, delegates and enums
22997 And during the member population, indexer_list, event_list,
22998 constant_list, field_list, instance_constructor_list, method_list,
22999 operator_list and property_list are turned into their real arrays.
23001 Although we could probably perform this operation earlier, for
23002 good error reporting we need to keep the lists and remove the
23003 lists for longer than required.
23005 This optimization was triggered by Paolo profiling the compiler
23006 speed on the output of `gen-sample-program.pl' perl script.
23008 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
23009 not crash in methods like MemberLookupFailed that use this field.
23011 This problem arises when the compiler fails to resolve a type
23012 during interface type definition for example.
23014 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23016 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
23017 inherit from System.Object, so we have to stop at null, not only
23018 when reaching System.Object.
23020 2003-02-17 Miguel de Icaza <miguel@ximian.com>
23022 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
23023 DeclaredOnly because the parent indexer might have had a different
23024 name, but did not loop until the top of the hierarchy was reached.
23026 The problem this one fixes is 35492: when a class implemented an
23027 indexer from an interface, we were getting the interface method
23028 (which was abstract) and we were flagging an error (can not invoke
23031 This also keeps bug 33089 functioning, and test-148 functioning.
23033 * typemanager.cs (IsSpecialMethod): The correct way of figuring
23034 out if a method is special is to see if it is declared in a
23035 property or event, or whether it is one of the predefined operator
23036 names. This should fix correctly #36804.
23038 2003-02-15 Miguel de Icaza <miguel@ximian.com>
23040 The goal here is to remove the dependency on EmptyCast.Peel ().
23041 Killing it completely.
23043 The problem is that currently in a number of places where
23044 constants are expected, we have to "probe" for an EmptyCast, and
23045 Peel, which is not the correct thing to do, as this will be
23046 repetitive and will likely lead to errors.
23048 The idea is to remove any EmptyCasts that are used in casts that
23049 can be reduced to constants, so we only have to cope with
23052 This bug hunt was triggered by Bug 37363 and the desire to remove
23053 the duplicate pattern where we were "peeling" emptycasts to check
23054 whether they were constants. Now constants will always be
23057 * ecore.cs: Use an enumconstant here instead of wrapping with
23060 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
23061 throwing me off. By handling this we can get rid of a few hacks.
23063 * statement.cs (Switch): Removed Peel() code.
23065 2003-02-14 Miguel de Icaza <miguel@ximian.com>
23067 * class.cs: Location information for error 508
23069 * expression.cs (New.DoResolve): Add a guard against double
23070 resolution of an expression.
23072 The New DoResolve might be called twice when initializing field
23073 expressions (see EmitFieldInitializers, the call to
23074 GetInitializerExpression will perform a resolve on the expression,
23075 and later the assign will trigger another resolution
23077 This leads to bugs (#37014)
23079 * delegate.cs: The signature for EndInvoke should contain any ref
23080 or out parameters as well. We were not doing this in the past.
23082 * class.cs (Field.Define): Do not overwrite the type definition
23083 inside the `volatile' group. Turns out that volatile enumerations
23084 were changing the type here to perform a validity test, which
23087 2003-02-12 Miguel de Icaza <miguel@ximian.com>
23089 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
23090 and structs, we do not want to load the instance variable
23092 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
23093 enum_type has to be handled like an object reference (implicit
23094 conversions exists from this to object), but the regular IsClass
23095 and IsValueType tests will never return true for this one.
23097 Also we use TypeManager.IsValueType instead of type.IsValueType,
23098 just for consistency with the rest of the code (this is only
23099 needed if we ever use the construct exposed by test-180.cs inside
23100 corlib, which we dont today).
23102 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
23104 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
23107 2003-02-09 Martin Baulig <martin@ximian.com>
23109 * namespace.cs (Namespace..ctor): Added SourceFile argument.
23110 (Namespace.DefineNamespaces): New static public method; this is
23111 called when we're compiling with debugging to add all namespaces
23112 to the symbol file.
23114 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
23115 pass it to the Namespace's .ctor.
23117 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
23118 and MethodBase arguments; pass the namespace ID to the symwriter;
23119 pass the MethodBase instead of the token to the symwriter.
23120 (SymbolWriter.DefineNamespace): New method to add a namespace to
23123 2003-02-09 Martin Baulig <martin@ximian.com>
23125 * symbolwriter.cs: New file. This is a wrapper around
23126 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
23127 methods here in near future.
23129 2003-02-09 Martin Baulig <martin@ximian.com>
23131 * codegen.cs (EmitContext.Mark): Just pass the arguments to
23132 ILGenerator.MarkSequencePoint() which are actually used by the
23135 2003-02-09 Martin Baulig <martin@ximian.com>
23137 * location.cs (SourceFile): New public sealed class. This
23138 contains the name and an index which is used in the location's token.
23139 (Location): Reserve an appropriate number of bits in the token for
23140 the source file instead of walking over that list, this gives us a
23141 really huge performance improvement when compiling with debugging.
23143 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
23144 `SourceFile' argument instead of a string.
23145 (Driver.ProcessFile): Add all the files via Location.AddFile(),
23146 but don't parse/tokenize here, we need to generate the list of all
23147 source files before we do that.
23148 (Driver.ProcessFiles): New static function. Parses/tokenizes all
23151 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
23152 instead of a string.
23154 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
23157 2003-02-09 Martin Baulig <martin@ximian.com>
23159 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
23160 filename on `#line default'.
23162 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
23164 * statement.cs: don't clear the pinned var when the fixed statement
23165 returns from the method (fixes bug#37752).
23167 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
23169 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
23172 2003-02-07 Martin Baulig <martin@ximian.com>
23174 * driver.cs: Removed the `--debug-args' command line argument.
23176 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
23177 automatically by the AsssemblyBuilder.
23178 (CodeGen.InitializeSymbolWriter): We don't need to call any
23179 initialization function on the symbol writer anymore. This method
23180 doesn't take any arguments.
23182 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23184 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23185 from referenced assemblies as well.
23187 2003-02-02 Martin Baulig <martin@ximian.com>
23189 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23191 2003-02-02 Martin Baulig <martin@ximian.com>
23193 * class.cs (Constructor.Emit): Open the symbol writer before
23194 emitting the constructor initializer.
23195 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23196 single-stepping through constructor initializers.
23198 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23200 * class.cs: Handle error 549: do not allow virtual methods in
23203 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23205 * decl.cs: Check access levels when resolving types
23207 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23209 * statement.cs: Add parameters and locals set in catch blocks that might
23210 return to set vector
23212 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23214 * class.cs (Operator): Set the SpecialName flags for operators.
23216 * expression.cs (Invocation.DoResolve): Only block calls to
23217 accessors and operators on SpecialName methods.
23219 (Cast.TryReduce): Handle conversions from char constants.
23222 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23224 * statement.cs: small memory and time optimization in FlowBranching.
23226 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23228 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23229 problem that the last fix but in the other sid (Set).
23231 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23232 access when there is no indexer in the hierarchy.
23234 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23236 * class.cs: Combine some if statements.
23238 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23240 * driver.cs: fixed bug #37187.
23242 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23244 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23245 any indexer, it's needed to build a list with all the indexers in the
23246 hierarchy (AllGetters), else we have problems. Fixes #35653.
23248 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23250 * class.cs (MethodData.Define): It is wrong for an interface
23251 implementation to be static in both cases: explicit and implicit.
23252 We were only handling this in one case.
23254 Improve the if situation there to not have negations.
23256 * class.cs (Field.Define): Turns out that we do not need to check
23257 the unsafe bit on field definition, only on usage. Remove the test.
23259 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23261 * driver.cs: use assembly.Location instead of Codebase (the latest
23262 patch made mcs fail when using MS assemblies).
23264 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23266 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23267 get the path to *corlib.dll.
23269 2003-01-21 Nick Drochak <ndrochak@gol.com>
23273 * typemanager.cs: Remove compiler warnings
23275 2003-01-20 Duncan Mak <duncan@ximian.com>
23277 * AssemblyInfo.cs: Bump the version number to 0.19.
23279 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23281 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23283 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23285 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23287 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23289 * cs-parser.jay: Small fix: we were not comparing the constructor
23290 name correctly. Thanks to Zoltan for the initial pointer.
23292 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23294 * cs-tokenizer.cs: Set file name when specified with #line
23296 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23298 * cs-parser.jay: Only perform the constructor checks here if we
23299 are named like the class; This will help provider a better
23300 error. The constructor path is taken when a type definition is
23301 not found, but most likely the user forgot to add the type, so
23302 report that rather than the constructor error.
23304 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23306 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23309 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23311 * cs-parser.jay: Add cleanup call.
23313 2003-01-13 Duncan Mak <duncan@ximian.com>
23315 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23316 consistent with other methods.
23318 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23320 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23322 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23324 * attribute.cs: only set GuidAttr to true when we have a
23327 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23331 * typemanager.cs: fixes to allow mcs compile corlib with the new
23332 Type.IsSubclassOf fix.
23334 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23336 * expression.cs (LocalVariableReference.DoResolve): Classify a
23337 constant as a value, not as a variable. Also, set the type for
23340 * cs-parser.jay (fixed_statement): take a type instead of a
23341 pointer_type, so we can produce a better error message later.
23343 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23346 (For.DoEmit): Make inifinite loops have a
23347 non-conditional branch back.
23349 (Fixed.DoEmit): First populate the pinned variables, then emit the
23350 statement, then clear the variables. Before I was emitting the
23351 code once for each fixed piece.
23354 2003-01-08 Martin Baulig <martin@ximian.com>
23356 * statement.cs (FlowBranching.MergeChild): A break in a
23357 SWITCH_SECTION does not leave a loop. Fixes #36155.
23359 2003-01-08 Martin Baulig <martin@ximian.com>
23361 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23362 lives in the same number space than `param_map'. Fixes #36154.
23364 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23366 * cs-parser.jay (constructor_declaration): Set the
23367 Constructor.ModFlags before probing for it. This makes the
23368 compiler report 514, 515 and 132 (the code was there, but got
23371 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23372 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23373 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23375 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23377 * enum.cs: create the enum static fields using the enum type.
23379 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23381 * class.cs: don't try to create the ParamBuilder for the return
23382 type if it's not needed (and handle it breaking for the ms runtime
23385 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23387 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23389 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23391 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23392 the command. This showed up while compiling the JANET source
23393 code, which used \r as its only newline separator.
23395 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23397 * class.cs (Method.Define): If we are an operator (because it
23398 reuses our code), then set the SpecialName and HideBySig. #36128
23400 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23402 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23403 exception, report error 120 `object reference required'.
23405 * driver.cs: Add --pause option, used during to measure the size
23406 of the process as it goes with --timestamp.
23408 * expression.cs (Invocation.DoResolve): Do not allow methods with
23409 SpecialName to be invoked.
23411 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23413 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23414 number before adding it.
23416 2002-12-21 Ravi Pratap <ravi@ximian.com>
23418 * ecore.cs (StandardImplicitConversion): When in an unsafe
23419 context, we allow conversion between void * to any other pointer
23420 type. This fixes bug #35973.
23422 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23424 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23425 is not thrown when extensionless outputs are used
23427 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23429 * rootcontext.cs: fixed compilation of corlib.
23431 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23433 * attribute.cs (Attributes.Contains): Add new method.
23435 * class.cs (MethodCore.LabelParameters): if the parameter is an
23436 `out' parameter, check that no attribute `[In]' has been passed.
23438 * enum.cs: Handle the `value__' name in an enumeration.
23440 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23442 * decl.cs: Added special case to allow overrides on "protected
23445 2002-12-18 Ravi Pratap <ravi@ximian.com>
23447 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23448 since it makes much more sense.
23450 (Attributes.ctor): Don't require a Location parameter.
23452 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23454 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23455 since we already have that information per attribute.
23457 * everywhere : make appropriate changes.
23459 * class.cs (LabelParameters): Write the code which actually
23460 applies attributes to the return type. We can't do this on the MS
23461 .NET runtime so we flag a warning in the case an exception is
23464 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23466 * const.cs: Handle implicit null conversions here too.
23468 2002-12-17 Ravi Pratap <ravi@ximian.com>
23470 * class.cs (MethodCore.LabelParameters): Remove the extra
23471 Type [] parameter since it is completely unnecessary. Instead
23472 pass in the method's attributes so that we can extract
23473 the "return" attribute.
23475 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23477 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23478 of ignoring it and letting the compile continue.
23480 * typemanager.cs (ChangeType): use an extra argument to return an
23481 error condition instead of throwing an exception.
23483 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23485 * expression.cs (Unary.TryReduce): mimic the code for the regular
23486 code path. Perform an implicit cast in the cases where we can
23487 implicitly convert to one of the integral types, and then reduce
23488 based on that constant. This fixes bug #35483.
23490 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23492 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23494 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23496 * namespace.cs: fixed bug #35489.
23498 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23500 * class.cs: Remove some dead code.
23502 * cs-parser.jay: Estimate the number of methods needed
23503 (RootContext.MethodCount);
23505 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23506 numbers instead of StringBuilders.
23508 * support.cs (PtrHashtable): Add constructor with initial size;
23509 We can now reduce reallocations of the method table.
23511 2002-12-10 Ravi Pratap <ravi@ximian.com>
23513 * attribute.cs (ApplyAttributes): Keep track of the emitted
23514 attributes on a per-target basis. This fixes bug #35413.
23516 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23518 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23519 default to the Windows 1252 encoding.
23521 (UnixParseOption): Support version, thanks to Alp for the missing
23524 * AssemblyInfo.cs: Add nice assembly information.
23526 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23529 * cs-parser.jay: Allow a trailing comma before the close bracked
23530 in the attribute_section production.
23532 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23533 address of the instance was being taken, I will take this out,
23534 because we take the address of the object immediately here.
23536 2002-12-09 Ravi Pratap <ravi@ximian.com>
23538 * typemanager.cs (AreMultipleAllowed): Take care of the most
23539 obvious case where attribute type is not in the current assembly -
23542 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23544 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23545 definitions, instead of doing that afterwards.
23547 Also we use a nice little hack, depending on the constructor, we
23548 know if we are a "composed" name or a simple name. Hence, we
23549 avoid the IndexOf test, and we avoid
23551 * codegen.cs: Add code to assist in a bug reporter to track down
23552 the source of a compiler crash.
23554 2002-12-07 Ravi Pratap <ravi@ximian.com>
23556 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23557 types have been emitted for a given element and flag an error
23558 if something which does not have AllowMultiple set is used more
23561 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23562 attribute types and their corresponding AllowMultiple properties
23564 (AreMultipleAllowed): Check the property for a given type.
23566 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23567 property in the case we have a TypeContainer.
23569 (Attributes.AddAttribute): Detect duplicates and just skip on
23570 adding them. This trivial fix catches a pretty gross error in our
23571 attribute emission - global attributes were being emitted twice!
23573 Bugzilla bug #33187 is now fixed.
23575 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23577 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23578 instead of pp_and).
23580 * expression.cs (Binary.ResolveOperator): I can only use the
23581 Concat (string, string, string) and Concat (string, string,
23582 string, string) if the child is actually a concatenation of
23585 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23587 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23588 context where we need a 2-character lookahead.
23590 * pending.cs (PendingImplementation): Rework so we can keep track
23591 of interface types all the time, and flag those which were
23592 implemented by parents as optional.
23594 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23596 * expression.cs (Binary.ResolveOperator): Use
23597 String.Concat(string,string,string) or
23598 String.Concat(string,string,string,string) when possible.
23600 * typemanager: More helper methods.
23603 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23605 * pending.cs: remove the bogus return from GetMissingInterfaces()
23606 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23608 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23610 * namespace.cs: avoid duplicated 'using xxx' being added to
23611 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23612 when we get more than one 'using' statement for the same namespace.
23613 Report a CS0105 warning for it.
23615 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23617 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23618 of calling getChar/putback, uses internal knowledge of it.
23620 (xtoken): Reorder tokenizer so most common patterns are checked
23621 first. This reduces the compilation time in another 5% (from 8.11s
23622 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23624 The parsing time is 22% of the compilation in mcs, and from that
23625 64% is spent on the tokenization process.
23627 I tried using a binary search for keywords, but this is slower
23628 than the hashtable. Another option would be to do a couple of
23631 * Not use a StringBuilder, instead use an array of chars,
23632 with a set value. Notice that this way we could catch
23633 the 645 error without having to do it *afterwards*.
23635 * We could write a hand-parser to avoid the hashtable
23636 compares altogether.
23638 The identifier consumption process takes 37% of the tokenization
23639 time. Another 15% is spent on is_number. 56% of the time spent
23640 on is_number is spent on Int64.Parse:
23642 * We could probably choose based on the string length to
23643 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23646 Another 3% is spend on wrapping `xtoken' in the `token' function.
23648 Handle 0xa0 as whitespace (#34752)
23650 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23652 * typemanager.cs (IsCLRType): New routine to tell whether a type
23653 is one of the builtin types.
23655 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23656 typecode in more places instead of doing pointer comparissions.
23657 We could leverage some knowledge about the way the typecodes are
23660 New code to cache namespaces in assemblies, it is currently not
23661 invoked, to be used soon.
23663 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23665 * expression.cs (Binary.ResolveOperator): specially handle
23666 strings, and do not perform user-defined operator overloading for
23669 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23671 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23672 internalcall as it is a pretty simple operation; Avoid whenever
23673 possible to call Char.IsLetter.
23675 (consume_identifier): Cut by half the number of
23676 hashtable calls by merging the is_keyword and GetKeyword behavior.
23678 Do not short-circuit, because if we do, we
23679 report errors (ie, #if false && true would produce an invalid
23683 2002-11-24 Martin Baulig <martin@ximian.com>
23685 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23686 check constant ranges and report a CS0221. Fixes #33186.
23688 2002-11-24 Martin Baulig <martin@ximian.com>
23690 * cs-parser.jay: Make this work for uninitialized variable
23691 declarations in the `for' initializer. Fixes #32416.
23693 2002-11-24 Martin Baulig <martin@ximian.com>
23695 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23696 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23698 2002-11-24 Martin Baulig <martin@ximian.com>
23700 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23701 argument; if true, we also check for user-defined conversions.
23702 This is only needed if both arguments are of a user-defined type.
23703 Fixes #30443, added test-175.cs.
23704 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23706 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23708 2002-11-24 Martin Baulig <martin@ximian.com>
23710 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23711 function to get the store opcode.
23712 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23713 only emit the Ldelema if the store opcode is Stobj. You must run
23714 both test-34 and test-167 to test this. Fixes #34529.
23716 2002-11-23 Martin Baulig <martin@ximian.com>
23718 * ecore.cs (Expression.MemberLookup): Added additional
23719 `qualifier_type' argument which is used when we're being called
23720 from MemberAccess.DoResolve() and null if we're called from a
23722 (Expression.MemberLookupFailed): New method to report errors; this
23723 does the CS1540 check and reports the correct error message.
23725 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23726 argument for the CS1540 check and redone the way how we're dealing
23727 with private members. See the comment in the source code for details.
23728 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23729 `closure_start_type' to `closure_qualifier_type' and check whether
23730 it's not null. It was not this filter being broken, it was just
23731 being called with the wrong arguments.
23733 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23734 and pass it the correct `qualifier_type'; this also does the error
23737 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23739 * expression.cs (Invocation.EmitParams): If the we are dealing
23740 with a non-built-in value type, load its address as well.
23742 (ArrayCreation): Use a a pretty constant instead
23743 of the hardcoded value 2. Use 6 instead of 2 for the number of
23744 static initializers.
23746 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23747 because they are not really value types, just glorified integers.
23749 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23751 * ecore.cs: Remove redundant code for enumerations, make them use
23752 the same code path as everything else, fixes the casting issue
23753 with enumerations in Windows.Forms.
23755 * attribute.cs: Do only cast to string if it is a string, the
23756 validation happens later.
23758 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23759 people upgrade their corlibs.
23761 * ecore.cs: Oops, enumerations were not following the entire code path
23763 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23765 * typemanager.cs (FilterWithClosure): Commented out the test for
23766 1540 in typemanager.cs, as it has problems when accessing
23767 protected methods from a parent class (see test-174.cs).
23769 * attribute.cs (Attribute.ValidateGuid): new method.
23770 (Attribute.Resolve): Use above.
23772 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23774 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23776 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23777 handling for enumerations, as we only needed the TypeContainer
23778 functionality to begin with (this is required for the fix below to
23779 work for enums that reference constants in a container class for
23782 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23784 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23785 a valid TypeBuilder to perform lookups on.o
23787 * class.cs (InheritableMemberSignatureCompare): Use true in the
23788 call to GetGetMethod and GetSetMethod, because we are comparing
23789 the signature, and we need to get the methods *even* if they are
23792 (PropertyBase.CheckBase): ditto.
23794 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23795 GotoCase.Resolve): Use Peel on EmpytCasts.
23797 * ecore.cs (EmptyCast): drop child, add Peel method.
23799 2002-11-17 Martin Baulig <martin@ximian.com>
23801 * ecore.cs (EmptyCast.Child): New public property.
23803 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23804 label resolved to an EmptyCast. Fixes #34162.
23805 (GotoCase.Resolve): Likewise.
23806 (Block.EmitMeta): Likewise.
23808 2002-11-17 Martin Baulig <martin@ximian.com>
23810 * expression.cs (Invocation.BetterConversion): Prefer int over
23811 uint; short over ushort; long over ulong for integer literals.
23812 Use ImplicitConversionExists instead of StandardConversionExists
23813 since we also need to check for user-defined implicit conversions.
23814 Fixes #34165. Added test-173.cs.
23816 2002-11-16 Martin Baulig <martin@ximian.com>
23818 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23819 with the `true' and `false' literals. Fixes #33151.
23821 2002-11-16 Martin Baulig <martin@ximian.com>
23823 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23824 October 22nd; don't do the cs1540 check for static members.
23826 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23827 now using our own filter here and doing the cs1540 check again.
23829 2002-11-16 Martin Baulig <martin@ximian.com>
23831 * support.cs (InternalParameters): Don't crash if we don't have
23832 any fixed parameters. Fixes #33532.
23834 2002-11-16 Martin Baulig <martin@ximian.com>
23836 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23837 when looking up static methods to make this work on Windows.
23840 2002-11-16 Martin Baulig <martin@ximian.com>
23842 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23843 a setter rather than using PropertyInfo.CanWrite.
23845 2002-11-15 Nick Drochak <ndrochak@gol.com>
23847 * class.cs: Allow acces to block member by subclasses. Fixes build
23850 2002-11-14 Martin Baulig <martin@ximian.com>
23852 * class.cs (Constructor.Emit): Added the extern/block check.
23855 2002-11-14 Martin Baulig <martin@ximian.com>
23857 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23858 iteration while looking for indexers, this is needed because the
23859 indexer may have a different name in our base classes. Fixed the
23860 error reporting (no indexers at all, not get accessor, no
23861 overloaded match). Fixes bug #33089.
23862 (IndexerAccess.DoResolveLValue): Likewise.
23864 2002-11-14 Martin Baulig <martin@ximian.com>
23866 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23867 indexers. Fixes the first part of bug #33089.
23868 (MethodSignature.InheritableMemberSignatureCompare): Added support
23871 2002-11-13 Ravi Pratap <ravi@ximian.com>
23873 * attribute.cs (Attribute.Resolve): Catch the
23874 NullReferenceException and report it since it isn't supposed to
23877 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23879 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23880 LogicalOr and LogicalAnd that can benefit from recursively
23881 handling EmitBranchable. The code now should be nice for Paolo.
23883 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23885 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23886 the Type lookups, as we perform quite a number of lookups on
23887 non-Types. This can be removed once we can deterministically tell
23888 whether we have a type or a namespace in advance.
23890 But this might require special hacks from our corlib.
23894 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23895 and double which avoids a conversion from an integer to a double.
23897 * expression.cs: tiny optimization, avoid calling IsConstant,
23898 because it effectively performs the lookup twice.
23900 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23902 But a bogus return here to keep the semantics of the old code
23903 until the Mono runtime is fixed.
23905 * pending.cs (GetMissingInterfaces): New method used to remove all
23906 the interfaces that are already implemented by our parent
23907 classes from the list of pending methods.
23909 * interface.cs: Add checks for calls after ResolveTypeExpr.
23911 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23913 * class.cs (Class.Emit): Report warning 67: event not used if the
23914 warning level is beyond 3.
23916 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23917 being a NullLiteral.
23919 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23922 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23923 path that might fail if a type can not be resolved.
23925 * expression.cs (Binary.Emit): Emit unsigned versions of the
23928 * driver.cs: use error 5.
23930 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23932 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23934 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23936 * cs-parser.jay (switch_section): A beautiful patch from Martin
23937 Baulig that fixed 33094.
23939 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23941 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23942 Check whether the base is abstract and report an error if so.
23944 * expression.cs (IndexerAccess.DoResolveLValue,
23945 IndexerAccess.DoResolve): ditto.
23947 (Invocation.DoResolve): ditto.
23949 (Invocation.FullMethodDesc): Improve the report string.
23951 * statement.cs (Block): Eliminate IsVariableDefined as it is
23952 basically just a wrapper for GetVariableInfo.
23954 * ecore.cs (SimpleName): Use new
23956 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23957 type, as we return the actual parameter ref/unref state on a
23960 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23962 * support.cs: Return proper flags REF/OUT fixing the previous
23965 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23966 not used to mean `ref' but `ref or out' in ParameterReference
23968 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23969 full type signature instead of calling TypeManger.CSharpName
23972 * support.cs (InternalParameters.ParameterDesc): Do not compare
23973 directly to the modflags, because REF/OUT will actually be bitsets
23976 * delegate.cs (VerifyMethod): Check also the modifiers.
23978 * cs-tokenizer.cs: Fix bug where floating point values with an
23979 exponent where a sign was missing was ignored.
23981 * driver.cs: Allow multiple assemblies to be specified in a single
23984 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23986 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23987 because identifiers after a parenthesis would end up in this kind
23988 of production, and we needed to desamiguate it for having casts
23991 (UserDefinedType *) xxx
23993 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23995 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23996 we should set on the Bindingflags.NonPublic, but not turn on
23997 private_ok. private_ok controls whether a Private member is
23998 returned (this is chekced on the filter routine), while the
23999 BindingFlags.NonPublic just controls whether private/protected
24000 will be allowed. This fixes the problem part of the problem of
24001 private properties being allowed to be used in derived classes.
24003 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
24004 so we can call the children DoResolveLValue method (this will
24005 properly signal errors on lvalue assignments to base properties)
24007 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
24008 getter are null, and we have a property info, we know that this
24009 happened because the lookup failed, so we report an error 122 for
24010 protection level violation.
24012 We also silently return if setter and getter are null in the
24013 resolve functions, this condition only happens if we have flagged
24014 the error before. This is the other half of the problem.
24016 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
24017 not have accessibility information, that is why we were returning
24018 true in the filter function in typemanager.cs.
24020 To properly report 122 (property is inaccessible because of its
24021 protection level) correctly, we report this error in ResolveAccess
24022 by failing if both the setter and the getter are lacking (ie, the
24025 DoResolve and DoLResolve have been modified to check for both
24026 setter/getter being null and returning silently, the reason being
24027 that I did not want to put the knowledge about this error in upper
24030 int old = Report.Errors;
24031 x = new PropertyExpr (...);
24032 if (old != Report.Errors)
24037 So the property expr is returned, but it is invalid, so the error
24038 will be flagged during the resolve process.
24040 * class.cs: Remove InheritablePropertySignatureCompare from the
24041 class, as we no longer depend on the property signature to compute
24042 whether it is possible to implement a method or not.
24044 The reason is that calling PropertyInfo.GetGetMethod will return
24045 null (in .NET, in Mono it works, and we should change this), in
24046 cases where the Get Method does not exist in that particular
24051 class X { public virtual int A { get { return 1; } } }
24053 class Z : Y { public override int A { get { return 2; } } }
24055 Would fail in Z because the parent (Y) would not have the property
24056 defined. So we avoid this completely now (because the alternative
24057 fix was ugly and slow), and we now depend exclusively on the
24060 (PropertyBase.CheckBase): Use a method-base mechanism to find our
24061 reference method, instead of using the property.
24063 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
24064 routines are gone now.
24066 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
24067 names, they were incorrectly named.
24069 * cs-tokenizer.cs: Return are more gentle token on failure.
24071 * pending.cs (PendingImplementation.InterfaceMethod): This routine
24072 had an out-of-sync index variable, which caused it to remove from
24073 the list of pending methods the wrong method sometimes.
24075 2002-10-22 Miguel de Icaza <miguel@ximian.com>
24077 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
24078 CanWrite, because those refer to this particular instance of the
24079 property, and do not take into account the fact that we can
24080 override single members of a property.
24082 Constructor requires an EmitContext. The resolution process does
24083 not happen here, but we need to compute the accessors before,
24084 because the resolution does not always happen for properties.
24086 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
24087 subclass, before we did not update this flag, but we did update
24090 (GetAccessors): Drop this routine, as it did not work in the
24091 presence of partially overwritten set/get methods.
24093 Notice that this broke the cs1540 detection, but that will require
24096 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24100 * driver.cs: issue a warning instead of an error if we don't support
24101 debugging for the platform. Also ignore a couple of errors that may
24102 arise when trying to write the symbols. Undo my previous patch.
24104 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24106 * driver.cs: ignore /debug switch except for Unix platforms.
24108 2002-10-23 Nick Drochak <ndrochak@gol.com>
24110 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
24112 2002-10-21 Miguel de Icaza <miguel@ximian.com>
24114 * driver.cs: Do not make mcs-debug conditional, so we do not break
24115 builds that use it.
24117 * statement.cs (UsageVector.MergeChildren): I would like Martin to
24118 review this patch. But basically after all the children variables
24119 have been merged, the value of "Breaks" was not being set to
24120 new_breaks for Switch blocks. I think that it should be set after
24121 it has executed. Currently I set this to the value of new_breaks,
24122 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
24123 conservative, but I do not understand this code very well.
24125 I did not break anything in the build, so that is good ;-)
24127 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
24129 2002-10-20 Mark Crichton <crichton@gimp.org>
24131 * cfold.cs: Fixed compile blocker. Really fixed it this time.
24133 2002-10-20 Nick Drochak <ndrochak@gol.com>
24135 * cfold.cs: Fixed compile blocker.
24137 2002-10-20 Miguel de Icaza <miguel@ximian.com>
24139 * driver.cs: I was chekcing the key, not the file.
24141 2002-10-19 Ravi Pratap <ravi@ximian.com>
24143 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
24144 message that we were generating - we just need to silently return
24147 2002-10-19 Miguel de Icaza <miguel@ximian.com>
24149 * class.cs (Event.Define): Change my previous commit, as this
24150 breaks the debugger. This is a temporary hack, as it seems like
24151 the compiler is generating events incorrectly to begin with.
24153 * expression.cs (Binary.ResolveOperator): Added support for
24154 "U operator - (E x, E y)"
24156 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
24159 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
24160 init-only variables, but this path did not take into account that
24161 there might be also instance readonly variables. Correct this
24164 This fixes bug 32253
24166 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
24169 * driver.cs: Change the extension for modules to `netmodule'
24171 * cs-parser.jay: Improved slightly the location tracking for
24172 the debugger symbols.
24174 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
24175 modifiers that were specified instead of the hardcoded value
24176 (FamAndAssem). This was basically ignoring the static modifier,
24177 and others. Fixes 32429.
24179 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
24180 fixed a bug in the process (32476)
24182 * expression.cs (ArrayAccess.EmitAssign): Patch from
24183 hwang_rob@yahoo.ca that fixes bug 31834.3
24185 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24187 * driver.cs: Make the module extension .netmodule.
24189 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24191 * driver.cs: Report an error if the resource file is not found
24192 instead of crashing.
24194 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24195 false, like Emit does.
24197 2002-10-16 Nick Drochak <ndrochak@gol.com>
24199 * typemanager.cs: Remove unused private member. Also reported mcs
24200 bug to report this as a warning like csc.
24202 2002-10-15 Martin Baulig <martin@gnome.org>
24204 * statement.cs (Statement.Emit): Made this a virtual method; emits
24205 the line number info and calls DoEmit().
24206 (Statement.DoEmit): New protected abstract method, formerly knows
24207 as Statement.Emit().
24209 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24211 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24213 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24214 have fixed a remaining problem: not every AddXXXX was adding a
24215 fully qualified name.
24217 Now everyone registers a fully qualified name in the DeclSpace as
24218 being defined instead of the partial name.
24220 Downsides: we are slower than we need to be due to the excess
24221 copies and the names being registered this way.
24223 The reason for this is that we currently depend (on the corlib
24224 bootstrap for instance) that types are fully qualified, because
24225 we dump all the types in the namespace, and we should really have
24226 types inserted into the proper namespace, so we can only store the
24227 basenames in the defined_names array.
24229 2002-10-10 Martin Baulig <martin@gnome.org>
24231 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24232 from bug #31834, see the bug report for a testcase which is
24235 2002-10-10 Martin Baulig <martin@gnome.org>
24237 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24238 flow analysis code for this.
24240 * statement.cs (Do, While, For): Tell the flow analysis code about
24242 (FlowBranching.UsageVector): Added support for infinite loops.
24243 (Block.Resolve): Moved the dead code elimination here and use flow
24246 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24248 * class.cs (Field.Define): Catch cycles on struct type
24251 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24252 fields if the fields are static. We only need to check instance
24255 * expression.cs (As.DoResolve): Test for reference type.
24257 * statement.cs (Using.ResolveExpression): Use
24258 ConvertImplicitRequired, not ConvertImplicit which reports an
24260 (Using.ResolveLocalVariableDecls): ditto.
24262 * expression.cs (Binary.ResolveOperator): Report errors in a few
24263 places where we had to.
24265 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24267 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24269 * expression.cs: Use StoreFromPtr instead of extracting the type
24270 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24272 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24273 an enumeration value to a System.Enum, but System.Enum is not a
24274 value type, but an class type, so we need to box.
24276 (Expression.ConvertExplicit): One codepath could return
24277 errors but not flag them. Fix this. Fixes #31853
24279 * parameter.cs (Resolve): Do not allow void as a parameter type.
24281 2002-10-06 Martin Baulig <martin@gnome.org>
24283 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24284 if it's a class type and not a struct. Fixes #31815.
24286 2002-10-06 Martin Baulig <martin@gnome.org>
24288 * statement.cs: Reworked the flow analysis code a bit to make it
24289 usable for dead code elimination.
24291 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24293 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24295 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24297 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24298 to fix the test 165, will investigate deeper.
24300 2002-10-04 Martin Baulig <martin@gnome.org>
24302 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24303 finally blocks actually work.
24304 (Try.Resolve): We don't need to create a sibling for `finally' if
24305 there is no finally block.
24307 2002-10-04 Martin Baulig <martin@gnome.org>
24309 * class.cs (Constructor.Define): The default accessibility for a
24310 non-default constructor is private, not public.
24312 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24314 * class.cs (Constructor): Make AllowedModifiers public, add
24317 * cs-parser.jay: Perform the modifiers test here, as the
24318 constructor for the Constructor class usually receives a zero
24319 because of the way we create it (first we create, later we
24320 customize, and we were never checking the modifiers).
24322 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24323 is a version of LookupTypeReflection that includes the type-name
24324 cache. This can be used as a fast path for functions that know
24325 the fully qualified name and are only calling into *.GetType() to
24326 obtain a composed type.
24328 This is also used by TypeManager.LookupType during its type
24331 (LookupType): We now also track the real type name, as sometimes
24332 we can get a quey for the real type name from things like
24333 ComposedCast. This fixes bug 31422.
24335 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24336 complete type fullname, it does not have to go through the type
24337 resolution system to obtain the composed version of the type (for
24338 obtaining arrays or pointers).
24340 (Conditional.Emit): Use the EmitBoolExpression to
24341 generate nicer code, as requested by Paolo.
24343 (ArrayCreation.CheckIndices): Use the patch from
24344 hwang_rob@yahoo.ca to validate the array initializers.
24346 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24348 * class.cs (ConstructorInitializer.Emit): simplify code by using
24349 Invocation.EmitCall, and at the same time, fix the bugs in calling
24350 parent constructors that took variable arguments.
24352 * ecore.cs (Expression.ConvertNumericExplicit,
24353 Expression.ImplicitNumericConversion): Remove the code that
24354 manually wrapped decimal (InternalTypeConstructor call is now gone
24357 * expression.cs (Cast.TryReduce): Also handle decimal types when
24358 trying to perform a constant fold on the type.
24360 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24362 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24363 that only turned off an error report, and did nothing else.
24365 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24367 * driver.cs: Handle and ignore /fullpaths
24369 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24371 * expression.cs (Binary.ResolveOperator): Catch the case where
24372 DoNumericPromotions returns true,
24374 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24376 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24378 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24381 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24383 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24384 conversion exists, but it is also required that the conversion be
24385 performed. This manifested in "(Type64Enum) 2".
24387 * class.cs (TypeManager.AddMethod): The fix is not to change
24388 AddEnum, because that one was using a fully qualified name (every
24389 DeclSpace derivative does), but to change the AddMethod routine
24390 that was using an un-namespaced name. This now correctly reports
24391 the duplicated name.
24393 Revert patch until I can properly fix it. The issue
24394 is that we have a shared Type space across all namespaces
24395 currently, which is wrong.
24397 Options include making the Namespace a DeclSpace, and merge
24398 current_namespace/current_container in the parser.
24400 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24402 * cs-parser.jay: Improve error reporting when we get a different
24403 kind of expression in local_variable_type and
24404 local_variable_pointer_type.
24406 Propagate this to avoid missleading errors being reported.
24408 * ecore.cs (ImplicitReferenceConversion): treat
24409 TypeManager.value_type as a target just like object_type. As
24414 Is valid, and needs to result in the int 1 being boxed before it
24415 is assigned to the value type v.
24417 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24418 to validate the enumeration name.
24420 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24421 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24422 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24424 * ecore.cs (TryImplicitIntConversion): When doing an
24425 implicit-enumeration-conversion, check if the type is 64-bits and
24426 perform a conversion before passing to EnumConstant.
24428 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24430 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24431 report ambiguous type references. Unlike the MS version, we
24432 report what the ambiguity is. Innovation at work ;-)
24434 (DeclSpace.FindType): Require a location argument to
24435 display when we display an ambiguous error.
24437 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24439 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24441 * expression.cs (EmitDynamicInitializers): Apply patch from
24442 hwang_rob@yahoo.ca that fixes the order in which we emit our
24445 2002-09-21 Martin Baulig <martin@gnome.org>
24447 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24448 delegate takes no arguments.
24450 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24452 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24455 * expression.cs: Extract the underlying type.
24457 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24459 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24461 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24463 * class.cs (TypeContainer.DefineType): We can not use the nice
24464 PackingSize with the size set to 1 DefineType method, because it
24465 will not allow us to define the interfaces that the struct
24468 This completes the fixing of bug 27287
24470 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24471 means also structs. This fixes part of the problem.
24472 (Expresion.ImplicitReferenceConversionExists): ditto.
24474 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24475 error if there were no errors reported during the type lookup
24476 process, to avoid duplicates or redundant errors. Without this
24477 you would get an ambiguous errors plus a type not found. We have
24478 beaten the user enough with the first error.
24480 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24483 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24484 during the resolution process, stop the lookup, this avoids
24485 repeated error reports (same error twice).
24487 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24489 * typemanager.cs (LookupType): Redo the type lookup code to match
24490 the needs of System.Reflection.
24492 The issue is that System.Reflection requires references to nested
24493 types to begin with a "+" sign instead of a dot. So toplevel
24494 types look like: "NameSpace.TopLevelClass", and nested ones look
24495 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24498 2002-09-19 Martin Baulig <martin@gnome.org>
24500 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24501 says that a method always returns or always throws an exception,
24502 don't report the CS0161.
24504 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24505 set `Returns = new_returns'.
24507 2002-09-19 Martin Baulig <martin@gnome.org>
24509 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24510 to an enum constant, check for a CS0176.
24512 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24514 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24515 for operators that must be in pairs and report errors.
24517 * ecore.cs (SimpleName.DoResolveType): During the initial type
24518 resolution process, when we define types recursively, we must
24519 check first for types in our current scope before we perform
24520 lookups in the enclosing scopes.
24522 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24524 (Invocation.VerifyArgumentsCompat): Call
24525 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24526 I thought we were supposed to always call this, but there are a
24527 few places in the code where we dont do it.
24529 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24531 * driver.cs: Add support in -linkres and -resource to specify the
24532 name of the identifier.
24534 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24536 * ecore.cs (StandardConversionExists): Sync with the conversion
24537 code: allow anything-* to void* conversions.
24539 (FindMostSpecificSource): Use an Expression argument
24540 instead of a Type, because we might be handed over a Literal which
24541 gets a few more implicit conversions that plain types do not. So
24542 this information was being lost.
24544 Also, we drop the temporary type-holder expression when not
24547 2002-09-17 Martin Baulig <martin@gnome.org>
24549 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24550 this is an explicit interface implementation.
24552 2002-09-17 Martin Baulig <martin@gnome.org>
24554 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24555 different `IndexerName' attributes.
24557 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24558 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24559 virtual CommonResolve().
24561 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24563 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24564 and convert that to the UnderlyingType.
24566 * statement.cs (Foreach.Resolve): Indexers are just like variables
24567 or PropertyAccesses.
24569 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24570 inside quoted strings, we were not doing this before.
24572 2002-09-16 Martin Baulig <martin@gnome.org>
24574 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24575 resolve it. This is needed for the definite assignment check of the
24576 instance expression, fixes bug #29846.
24577 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24579 2002-09-16 Nick Drochak <ndrochak@gol.com>
24581 * parameter.cs: Fix compile error. Cannot reference static member
24582 from an instance object. Is this an mcs bug?
24584 2002-09-14 Martin Baulig <martin@gnome.org>
24586 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24587 multiple times. Fixes bug #30295, added test-166.cs.
24589 2002-09-14 Martin Baulig <martin@gnome.org>
24591 * statement.cs (Block.Emit): Don't emit unreachable code.
24592 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24593 `break' statements.
24594 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24596 2002-09-14 Martin Baulig <martin@gnome.org>
24598 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24601 2002-09-14 Martin Baulig <martin@gnome.org>
24603 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24604 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24605 be false on the ms runtime.
24607 2002-09-13 Martin Baulig <martin@gnome.org>
24609 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24610 the CS0038 error message.
24612 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24614 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24615 constant inside, return it.
24617 2002-09-12 Martin Baulig <martin@gnome.org>
24619 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24620 implicit conversion can be done between enum types.
24622 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24623 check whether an implicit conversion to the current enum's UnderlyingType
24624 exists and report an error if not.
24626 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24627 without debugging support.
24629 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24630 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24632 2002-09-12 Martin Baulig <martin@gnome.org>
24634 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24636 * ecore.cs (IMemberExpr.DeclaringType): New property.
24637 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24638 nonstatic member of an outer type (CS0038).
24640 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24642 * driver.cs: Activate the using-error detector at warning level
24643 4 (at least for MS-compatible APIs).
24645 * namespace.cs (VerifyUsing): Small buglett fix.
24647 * pending.cs (PendingImplementation): pass the container pointer.
24649 * interface.cs (GetMethods): Allow for recursive definition. Long
24650 term, I would like to move every type to support recursive
24651 definitions, not the current ordering mechanism that we have right
24654 The situation is this: Attributes are handled before interfaces,
24655 so we can apply attributes to interfaces. But some attributes
24656 implement interfaces, we will now handle the simple cases
24657 (recursive definitions will just get an error).
24659 * parameter.cs: Only invalidate types at the end if we fail to
24662 2002-09-09 Martin Baulig <martin@gnome.org>
24664 * ecore.cs (PropertyExpr.Emit): Also check for
24665 TypeManager.system_int_array_get_length so this'll also work when
24666 compiling corlib. Fixes #30003.
24668 2002-09-09 Martin Baulig <martin@gnome.org>
24670 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24671 and throw an exception if we can't get the type's size. Fixed #30040,
24674 2002-09-09 Martin Baulig <martin@gnome.org>
24676 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24678 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24679 context. Fixes bug #30027.
24681 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24682 virtual functions. Fixes bug #30043, added test-164.cs.
24684 2002-09-08 Ravi Pratap <ravi@ximian.com>
24686 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24688 2002-09-08 Nick Drochak <ndrochak@gol.com>
24690 * driver.cs: Use an object to get the windows codepage since it's not a
24693 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24695 * statement.cs (For.Emit): for infinite loops (test == null)
24696 return whether there is a break inside, not always "true".
24698 * namespace.cs (UsingEntry): New struct to hold the name of the
24699 using definition, the location where it is defined, and whether it
24700 has been used in a successful type lookup.
24702 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24707 2002-09-06 Ravi Pratap <ravi@ximian.com>
24709 * attribute.cs : Fix incorrect code which relied on catching
24710 a NullReferenceException to detect a null being passed in
24711 where an object was expected.
24713 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24715 * statement.cs (Try): flag the catch variable as assigned
24717 * expression.cs (Cast): Simplified by using ResolveType instead of
24718 manually resolving.
24720 * statement.cs (Catch): Fix bug by using ResolveType.
24722 2002-09-06 Ravi Pratap <ravi@ximian.com>
24724 * expression.cs (BetterConversion): Special case for when we have
24725 a NullLiteral as the argument and we have to choose between string
24726 and object types - we choose string the way csc does.
24728 * attribute.cs (Attribute.Resolve): Catch the
24729 NullReferenceException and report error #182 since the Mono
24730 runtime no more has the bug and having this exception raised means
24731 we tried to select a constructor which takes an object and is
24734 2002-09-05 Ravi Pratap <ravi@ximian.com>
24736 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24737 message (1502, 1503) when we can't locate a method after overload
24738 resolution. This is much more informative and closes the bug
24741 * interface.cs (PopulateMethod): Return if there are no argument
24742 types. Fixes a NullReferenceException bug.
24744 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24745 expressions too. Previously we were checking only in one place for
24746 positional arguments leaving out named arguments.
24748 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24749 type to the enum type is not allowed. Remove code corresponding to
24752 (ConvertNumericExplicit): Allow explicit conversions from
24753 the underlying type to enum type. This precisely follows the spec
24754 and closes a bug filed by Gonzalo.
24756 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24759 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24761 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24763 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24764 it was important that we stored the right value after the
24765 reduction in `converted'.
24767 2002-09-04 Martin Baulig <martin@gnome.org>
24769 * location.cs (Location.SymbolDocument): Use full pathnames for the
24772 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24774 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24775 of the expression resolve mechanism, because that will catch the
24776 SimpleName error failures.
24778 (Conditional): If we can not resolve the
24779 expression, return, do not crash.
24781 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24784 (location): display token name instead of its number.
24786 2002-08-28 Martin Baulig <martin@gnome.org>
24788 * expression.cs (Binary.ResolveOperator): Don't silently return
24789 but return an error if an operator cannot be applied between two
24792 2002-08-28 Martin Baulig <martin@gnome.org>
24794 * class.cs (Constructor.Define): Set the permission attributes
24795 correctly instead of making all constructors public.
24797 2002-08-28 Martin Baulig <martin@gnome.org>
24799 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24800 for private members before reporting a CS0103; if we find anything,
24803 2002-08-28 Martin Baulig <martin@gnome.org>
24805 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24806 to check whether `closure_start_type == closure_invocation_type',
24807 we also need to check whether `m.DeclaringType == closure_invocation_type'
24808 before bypassing the permission checks. We might be accessing
24809 protected/private members from the base class.
24810 (TypeManager.RealMemberLookup): Only set private_ok if private
24811 members were requested via BindingFlags.NonPublic.
24813 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24815 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24816 MethodGroupExpr.IsExplicitImpl if appropriate.
24817 (Invocation.DoResolve): Don't report the CS0120 for explicit
24818 interface implementations.
24820 2002-08-27 Martin Baulig <martin@gnome.org>
24822 * expression.cs (Invocation.DoResolve): If this is a static
24823 method and we don't have an InstanceExpression, we must report
24826 2002-08-25 Martin Baulig <martin@gnome.org>
24828 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24829 `==' between a valuetype and an object.
24831 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24833 * ecore.cs (TypeExpr): Provide a ToString method.
24835 2002-08-24 Martin Baulig <martin@gnome.org>
24837 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24838 now called proggie.dbg and it's a binary file.
24840 2002-08-23 Martin Baulig <martin@gnome.org>
24842 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24844 2002-08-23 Martin Baulig <martin@gnome.org>
24846 * struct.cs (MyStructInfo.ctor): Make this work with empty
24847 structs; it's not allowed to use foreach() on null.
24849 2002-08-23 Martin Baulig <martin@gnome.org>
24851 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24852 writer the full pathname of the generated assembly.
24854 2002-08-23 Martin Baulig <martin@gnome.org>
24856 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24857 A `finally' block never returns or breaks; improved handling of
24860 2002-08-23 Martin Baulig <martin@gnome.org>
24862 * statement.cs (Throw.Resolve): Allow `throw null'.
24864 2002-08-23 Martin Baulig <martin@gnome.org>
24866 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24867 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24868 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24869 MemberLookup would return a wrong event if this is an explicit
24870 interface implementation and the class has an event with the same
24873 2002-08-23 Martin Baulig <martin@gnome.org>
24875 * statement.cs (Block.AddChildVariableNames): New public method.
24876 (Block.AddChildVariableName): Likewise.
24877 (Block.IsVariableNameUsedInChildBlock): Likewise.
24878 (Block.AddVariable): Check whether a variable name has already
24879 been used in a child block.
24881 * cs-parser.jay (declare_local_variables): Mark all variable names
24882 from the current block as being used in a child block in the
24885 2002-08-23 Martin Baulig <martin@gnome.org>
24887 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24888 find the symbol writer.
24890 * driver.cs: csc also allows the arguments to /define being
24891 separated by commas, not only by semicolons.
24893 2002-08-23 Martin Baulig <martin@gnome.org>
24895 * interface.cs (Interface.GetMembers): Added static check for events.
24897 2002-08-15 Martin Baulig <martin@gnome.org>
24899 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24900 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24902 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24903 why the MethodData.EmitDestructor() change was necessary.
24905 2002-08-20 Martin Baulig <martin@gnome.org>
24907 * class.cs (TypeContainer.FindMembers): Added static check for events.
24909 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24911 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24912 use Type.GetEvents(), not Type.FindMembers().
24914 2002-08-20 Martin Baulig <martin@gnome.org>
24916 * decl.cs (MemberCache): Added a special method cache which will
24917 be used for method-only searched. This ensures that a method
24918 search will return a MethodInfo with the correct ReflectedType for
24921 2002-08-20 Martin Baulig <martin@gnome.org>
24923 * decl.cs (DeclSpace.FindMembers): Made this public.
24925 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24927 * delegate.cs: fixed build on windows.
24928 [FIXME: Filed as bug #29150: MCS must report these errors.]
24930 2002-08-19 Ravi Pratap <ravi@ximian.com>
24932 * ecore.cs (StandardConversionExists): Return a false
24933 if we are trying to convert the void type to anything else
24934 since that is not allowed.
24936 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24937 we flag error 70 in the event an event is trying to be accessed
24938 directly from outside the declaring type.
24940 2002-08-20 Martin Baulig <martin@gnome.org>
24942 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24943 MemberCache from typemanager.cs to decl.cs.
24945 2002-08-19 Martin Baulig <martin@gnome.org>
24947 * class.cs (TypeContainer): Implement IMemberContainer.
24948 (TypeContainer.DefineMembers): Create the MemberCache.
24949 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24950 return public members if BindingFlags.Public was given, check
24951 whether members are static.
24953 2002-08-16 Martin Baulig <martin@gnome.org>
24955 * decl.cs (DeclSpace.Define): Splitted this in Define and
24956 DefineMembers. DefineMembers is called first and initializes the
24959 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24960 DefineMembers() on all our DeclSpaces.
24962 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24963 but call DefineMembers() on all nested interfaces. We call their
24964 Define() in our new Define() function.
24966 * interface.cs (Interface): Implement IMemberContainer.
24967 (Interface.Define): Moved all code except the attribute stuf to
24969 (Interface.DefineMembers): Initialize the member cache.
24971 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24972 need this anymore since we can use MemberCache.FindMembers directly.
24974 2002-08-19 Martin Baulig <martin@gnome.org>
24976 * typemanager.cs (MemberCache): When creating the cache for an
24977 interface type, add all inherited members.
24978 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24979 to `out bool used_cache' and documented it.
24980 (TypeManager.MemberLookup): If we already used the cache in the first
24981 iteration, we don't need to do the interfaces check.
24983 2002-08-19 Martin Baulig <martin@gnome.org>
24985 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24986 here from IMemberFinder and don't implement this interface anymore.
24987 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24989 * typemanager.cs (IMemberFinder): This interface is now only used by
24990 classes which actually support the member cache.
24991 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24992 since we only put DeclSpaces into this Hashtable.
24993 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24994 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24996 2002-08-16 Martin Baulig <martin@gnome.org>
24998 * typemanager.cs (ICachingMemberFinder): Removed.
24999 (IMemberFinder.MemberCache): New property.
25000 (TypeManager.FindMembers): Merged this with RealFindMembers().
25001 This function will never be called from TypeManager.MemberLookup()
25002 so we can't use the cache here, just the IMemberFinder.
25003 (TypeManager.MemberLookup_FindMembers): Check whether the
25004 IMemberFinder has a MemberCache and call the cache's FindMembers
25006 (MemberCache): Rewrote larger parts of this yet another time and
25007 cleaned it up a bit.
25009 2002-08-15 Miguel de Icaza <miguel@ximian.com>
25011 * driver.cs (LoadArgs): Support quoting.
25013 (Usage): Show the CSC-like command line arguments.
25015 Improved a few error messages.
25017 2002-08-15 Martin Baulig <martin@gnome.org>
25019 * typemanager.cs (IMemberContainer.Type): New property.
25020 (IMemberContainer.IsInterface): New property.
25022 The following changes are conditional to BROKEN_RUNTIME, which is
25023 defined at the top of the file.
25025 * typemanager.cs (MemberCache.MemberCache): Don't add the base
25026 class'es members, but add all members from TypeHandle.ObjectType
25027 if we're an interface.
25028 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
25029 is the current type.
25030 (MemberCache.CacheEntry.Container): Removed this field.
25031 (TypeHandle.GetMembers): Include inherited members.
25033 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25035 * typemanager.cs: fixed compilation and added a comment on a field that
25038 2002-08-15 Martin Baulig <martin@gnome.org>
25040 * class.cs (ConstructorInitializer.Resolve): In the
25041 Expression.MemberLookup call, use the queried_type as
25044 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
25045 declared' attribute, it's always true.
25046 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
25047 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
25048 temporary wrapper for FindMembers which tells MemberLookup whether
25049 members from the base classes are included in the return value.
25050 This will go away soon.
25051 (TypeManager.MemberLookup): Use this temporary hack here; once the
25052 new MemberCache is completed, we don't need to do the DeclaredOnly
25053 looping here anymore since the MemberCache will take care of this.
25054 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
25055 (MemberCache): When creating the MemberCache for a class, get
25056 members from the current class and all its base classes.
25057 (MemberCache.CacheEntry.Container): New field. This is a
25058 temporary hack until the Mono runtime is fixed to distinguish
25059 between ReflectedType and DeclaringType. It allows us to use MCS
25060 with both the MS runtime and the unfixed Mono runtime without
25061 problems and without accecting performance.
25062 (MemberCache.SearchMembers): The DeclaredOnly looping from
25063 TypeManager.MemberLookup is now done here.
25065 2002-08-14 Martin Baulig <martin@gnome.org>
25067 * statement.cs (MyStructInfo.MyStructInfo): Don't call
25068 Type.GetFields on dynamic types but get the fields from the
25069 corresponding TypeContainer.
25070 (MyStructInfo.GetStructInfo): Added check for enum types.
25072 * typemanager.cs (MemberList.IsSynchronized): Implemented.
25073 (MemberList.SyncRoot): Implemented.
25074 (TypeManager.FilterWithClosure): No need to check permissions if
25075 closure_start_type == closure_invocation_type, don't crash if
25076 closure_invocation_type is null.
25078 2002-08-13 Martin Baulig <martin@gnome.org>
25080 Rewrote TypeContainer.FindMembers to use a member cache. This
25081 gives us a speed increase of about 35% for the self-hosting MCS
25082 build and of about 15-20% for the class libs (both on GNU/Linux).
25084 * report.cs (Timer): New class to get enhanced profiling. This
25085 whole class is "TIMER" conditional since it remarkably slows down
25088 * class.cs (MemberList): New class. This is an IList wrapper
25089 which we're now using instead of passing MemberInfo[]'s around to
25090 avoid copying this array unnecessarily.
25091 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
25092 (ICachingMemberFinder, IMemberContainer): New interface.
25093 (TypeManager.FilterWithClosure): If `criteria' is null, the name
25094 has already been checked, otherwise use it for the name comparision.
25095 (TypeManager.FindMembers): Renamed to RealMemberFinder and
25096 provided wrapper which tries to use ICachingMemberFinder.FindMembers
25097 if possible. Returns a MemberList, not a MemberInfo [].
25098 (TypeHandle): New class, implements IMemberContainer. We create
25099 one instance of this class per type, it contains a MemberCache
25100 which is used to do the member lookups.
25101 (MemberCache): New class. Each instance of this class contains
25102 all members of a type and a name-based hash table.
25103 (MemberCache.FindMembers): This is our new member lookup
25104 function. First, it looks up all members of the requested name in
25105 the hash table. Then, it walks this list and sorts out all
25106 applicable members and returns them.
25108 2002-08-13 Martin Baulig <martin@gnome.org>
25110 In addition to a nice code cleanup, this gives us a performance
25111 increase of about 1.4% on GNU/Linux - not much, but it's already
25112 half a second for the self-hosting MCS compilation.
25114 * typemanager.cs (IMemberFinder): New interface. It is used by
25115 TypeManager.FindMembers to call FindMembers on a TypeContainer,
25116 Enum, Delegate or Interface.
25117 (TypeManager.finder_to_member_finder): New PtrHashtable.
25118 (TypeManager.finder_to_container): Removed.
25119 (TypeManager.finder_to_delegate): Removed.
25120 (TypeManager.finder_to_interface): Removed.
25121 (TypeManager.finder_to_enum): Removed.
25123 * interface.cs (Interface): Implement IMemberFinder.
25125 * delegate.cs (Delegate): Implement IMemberFinder.
25127 * enum.cs (Enum): Implement IMemberFinder.
25129 * class.cs (TypeContainer): Implement IMemberFinder.
25131 2002-08-12 Martin Baulig <martin@gnome.org>
25133 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
25135 2002-08-12 Martin Baulig <martin@gnome.org>
25137 * ecore.cs (ITypeExpression): New interface for expressions which
25139 (TypeExpression): Renamed to TypeLookupExpression.
25140 (Expression.DoResolve): If we're doing a types-only lookup, the
25141 expression must implement the ITypeExpression interface and we
25142 call DoResolveType() on it.
25143 (SimpleName): Implement the new ITypeExpression interface.
25144 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
25145 hack, the situation that we're only looking up types can't happen
25146 anymore when this method is called. Moved the type lookup code to
25147 DoResolveType() and call it.
25148 (SimpleName.DoResolveType): This ITypeExpression interface method
25149 is now doing the types-only lookup.
25150 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
25151 (ResolveFlags): Added MaskExprClass.
25153 * expression.cs (MemberAccess): Implement the ITypeExpression
25155 (MemberAccess.DoResolve): Added support for a types-only lookup
25156 when we're called via ITypeExpression.DoResolveType().
25157 (ComposedCast): Implement the ITypeExpression interface.
25159 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
25160 Expression.Resolve() with ResolveFlags.Type instead.
25162 2002-08-12 Martin Baulig <martin@gnome.org>
25164 * interface.cs (Interface.Define): Apply attributes.
25166 * attribute.cs (Attribute.ApplyAttributes): Added support for
25167 interface attributes.
25169 2002-08-11 Martin Baulig <martin@gnome.org>
25171 * statement.cs (Block.Emit): Only check the "this" variable if we
25172 do not always throw an exception.
25174 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
25175 whether the property has a set accessor.
25177 2002-08-11 Martin Baulig <martin@gnome.org>
25179 Added control flow analysis support for structs.
25181 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25182 with control flow analysis turned off.
25183 (IVariable): New interface.
25184 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25185 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25186 (FieldExpr.DoResolve): Resolve the instance expression with flow
25187 analysis turned off and do the definite assignment check after the
25188 resolving when we know what the expression will resolve to.
25190 * expression.cs (LocalVariableReference, ParameterReference):
25191 Implement the new IVariable interface, only call the flow analysis
25192 code if ec.DoFlowAnalysis is true.
25193 (This): Added constructor which takes a Block argument. Implement
25194 the new IVariable interface.
25195 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25196 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25197 This does the definite assignment checks for struct members.
25199 * class.cs (Constructor.Emit): If this is a non-static `struct'
25200 constructor which doesn't have any initializer, call
25201 Block.AddThisVariable() to tell the flow analysis code that all
25202 struct elements must be initialized before control returns from
25205 * statement.cs (MyStructInfo): New public class.
25206 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25207 argument to this indexer. If non-zero, check an individual struct
25208 member, not the whole struct.
25209 (FlowBranching.CheckOutParameters): Check struct members.
25210 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25211 overloaded versions of these methods which take an additional
25212 `int field_idx' argument to check struct members.
25213 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25214 overloaded versions of these methods which take an additional
25215 `string field_name' argument to check struct member.s
25216 (VariableInfo): Implement the IVariable interface.
25217 (VariableInfo.StructInfo): New public property. Returns the
25218 MyStructInfo instance of the variable if it's a struct or null.
25219 (Block.AddThisVariable): New public method. This is called from
25220 Constructor.Emit() for non-static `struct' constructor which do
25221 not have any initializer. It creates a special variable for the
25222 "this" instance variable which will be checked by the flow
25223 analysis code to ensure that all of the struct's fields are
25224 initialized before control returns from the constructor.
25225 (UsageVector): Added support for struct members. If a
25226 variable/parameter is a struct with N members, we reserve a slot
25227 in the usage vector for each member. A struct is considered fully
25228 initialized if either the struct itself (slot 0) or all its
25229 members are initialized.
25231 2002-08-08 Martin Baulig <martin@gnome.org>
25233 * driver.cs (Driver.MainDriver): Only report an error CS5001
25234 if there were no compilation errors.
25236 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25237 `UnsafeContext' property to determine whether the parent is in
25238 unsafe context rather than checking the parent's ModFlags:
25239 classes nested in an unsafe class are unsafe as well.
25241 2002-08-08 Martin Baulig <martin@gnome.org>
25243 * statement.cs (UsageVector.MergeChildren): Distinguish between
25244 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25245 we return. Added test17() and test18() to test-154.cs.
25247 2002-08-08 Martin Baulig <martin@gnome.org>
25249 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25250 Family access, make sure the invoking type isn't a subclass of the
25251 queried type (that'd be a CS1540).
25253 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25254 this method which takes an additional `Type invocation_type'.
25256 * expression.cs (BaseAccess.DoResolve): Use the base type as
25257 invocation and query type.
25258 (MemberAccess.DoResolve): If the lookup failed and we're about to
25259 report a CS0122, try a lookup with the ec.ContainerType - if this
25260 succeeds, we must report a CS1540.
25262 2002-08-08 Martin Baulig <martin@gnome.org>
25264 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25265 (MethodGroupExpr): Implement the IMemberExpr interface.
25267 * expression (MemberAccess.ResolveMemberAccess): No need to have
25268 any special code for MethodGroupExprs anymore, they're now
25271 2002-08-08 Martin Baulig <martin@gnome.org>
25273 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25274 Family, FamANDAssem and FamORAssem permissions.
25275 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25277 2002-08-08 Martin Baulig <martin@gnome.org>
25279 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25280 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25283 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25285 * driver.cs: implemented /resource option to embed managed resources.
25287 2002-08-07 Martin Baulig <martin@gnome.org>
25289 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25290 (FieldBase.HasFieldInitializer): New public property.
25291 (FieldBase.GetInitializerExpression): New public method. Resolves and
25292 returns the field initializer and makes sure it is only resolved once.
25293 (TypeContainer.EmitFieldInitializers): Call
25294 FieldBase.GetInitializerExpression to get the initializer, this ensures
25295 that it isn't resolved multiple times.
25297 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25298 the resolving process (SimpleName/MemberLookup) that we're currently
25299 emitting a field initializer (which must not access any instance members,
25300 this is an error CS0236).
25302 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25303 argument, if the `IsFieldInitializer' flag is set, we must report and
25304 error CS0236 and not an error CS0120.
25306 2002-08-07 Martin Baulig <martin@gnome.org>
25308 * ecore.cs (IMemberExpr): New public interface.
25309 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25310 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25311 if the expression is an IMemberExpr.
25313 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25314 to be null, implicitly default to `this' if we're non-static in
25315 this case. Simplified the code a lot by using the new IMemberExpr
25316 interface. Also fixed bug #28176 here.
25318 2002-08-06 Martin Baulig <martin@gnome.org>
25320 * cs-parser.jay (SimpleLookup): Removed. We need to create
25321 ParameterReferences during semantic analysis so that we can do a
25322 type-only search when resolving Cast, TypeOf and SizeOf.
25323 (block): Pass the `current_local_parameters' to the Block's
25326 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25327 argument to the constructor.
25328 (ConstructorInitializer.Resolve): Create a temporary implicit
25329 block with the parameters.
25331 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25332 references here if we aren't doing a type-only search.
25334 * statement.cs (Block): Added constructor which takes a
25335 `Parameters parameters' argument.
25336 (Block.Parameters): New public property.
25338 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25339 to `Parameters' and made it public readonly.
25341 2002-08-06 Martin Baulig <martin@gnome.org>
25343 * ecore.cs (Expression.Warning): Made this public as well.
25345 * report.cs (Report.Debug): Print the contents of collections.
25347 2002-08-06 Martin Baulig <martin@gnome.org>
25349 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25350 used to tell Resolve() which kinds of expressions it may return.
25351 (Expression.Resolve): Added overloaded version of this method which
25352 takes a `ResolveFlags flags' argument. This can be used to tell
25353 Resolve() which kinds of expressions it may return. Reports a
25355 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25356 ResolveFlags.SimpleName.
25357 (Expression.Error118): Added overloaded version of this method which
25358 takes a `ResolveFlags flags' argument. It uses the flags to determine
25359 which kinds of expressions are allowed.
25361 * expression.cs (Argument.ResolveMethodGroup): New public method.
25362 Resolves an argument, but allows a MethodGroup to be returned.
25363 This is used when invoking a delegate.
25365 * TODO: Updated a bit.
25367 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25369 Fixed compilation with csc.
25371 * ecore.cs: Expression.Error made public. Is this correct? Should
25372 Warning be made public too?
25374 * expression.cs: use ea.Location instead of ea.loc.
25375 [FIXME: Filed as bug #28607: MCS must report these errors.]
25377 2002-08-06 Martin Baulig <martin@gnome.org>
25379 * ecore.cs (Expression.loc): Moved the location here instead of
25380 duplicating it in all derived classes.
25381 (Expression.Location): New public property.
25382 (Expression.Error, Expression.Warning): Made them non-static and
25383 removed the location argument.
25384 (Expression.Warning): Added overloaded version which takes an
25385 `int level' argument.
25386 (Expression.Error118): Make this non-static and removed the
25387 expression and location arguments.
25388 (TypeExpr): Added location argument to the constructor.
25390 * expression.cs (StaticCallExpr): Added location argument to
25392 (Indirection, PointerArithmetic): Likewise.
25393 (CheckedExpr, UnCheckedExpr): Likewise.
25394 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25395 (StringPtr): Likewise.
25398 2002-08-05 Martin Baulig <martin@gnome.org>
25400 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25402 * assign.cs (Assign.DoResolve): Check whether the source
25403 expression is a value or variable.
25405 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25406 while resolving the corresponding blocks.
25408 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25409 an error, don't silently return null.
25411 * statement.cs (Block.AddVariable): Do the error reporting here
25412 and distinguish between CS0128 and CS0136.
25413 (Block.DoResolve): Report all unused labels (warning CS0164).
25414 (LabeledStatement): Pass the location to the constructor.
25415 (LabeledStatement.HasBeenReferenced): New property.
25416 (LabeledStatement.Resolve): Set it to true here.
25418 * statement.cs (Return.Emit): Return success even after reporting
25419 a type mismatch error (CS0126 or CS0127), this is what csc does and
25420 it avoids confusing the users with any consecutive errors.
25422 2002-08-05 Martin Baulig <martin@gnome.org>
25424 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25426 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25428 * expression.cs (MemberAccess.DoResolve): Silently return if an
25429 error has already been reported.
25431 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25432 error has already been reported.
25434 2002-08-05 Martin Baulig <martin@gnome.org>
25436 * statement.cs (UsageVector): Only initialize the `parameters'
25437 vector if we actually have any "out" parameters.
25439 2002-08-05 Martin Baulig <martin@gnome.org>
25441 * expression.cs (Binary.ResolveOperator): When combining delegates,
25442 they must have the same type.
25444 2002-08-05 Martin Baulig <martin@gnome.org>
25446 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25447 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25448 work with the ms runtime and we also don't need it: if we're a
25449 PropertyBuilder and not in the `indexer_arguments' hash, then we
25450 are a property and not an indexer.
25452 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25453 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25454 since the latter one doesn't work with the ms runtime.
25456 2002-08-03 Martin Baulig <martin@gnome.org>
25458 Fixed bugs #27998 and #22735.
25460 * class.cs (Method.IsOperator): New public field.
25461 (Method.CheckBase): Report CS0111 if there's already a method
25462 with the same parameters in the current class. Report CS0508 when
25463 attempting to change the return type of an inherited method.
25464 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25465 and it's not marked abstract or extern.
25466 (PropertyBase): New abstract base class for Property and Indexer.
25467 (PropertyBase.CheckBase): Moved here from Property and made it work
25469 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25470 the same so we can reuse it there.
25471 (Property, Indexer): Derive from PropertyBase.
25472 (MethodSignature.inheritable_property_signature_filter): New delegate
25473 to find properties and indexers.
25475 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25476 argument and improved error reporting.
25478 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25479 EmptyReadOnlyParameters and made it a property.
25481 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25482 version of this method which takes a `PropertyInfo indexer'.
25483 (TypeManager.RegisterIndexer): New method.
25485 * class.cs: Added myself as author of this file :-)
25487 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25489 * class.cs: fixed compilation on windoze.
25491 2002-08-03 Martin Baulig <martin@gnome.org>
25493 * interface.cs (Interface.GetInterfaceBases): Check whether all
25494 base interfaces are at least as accessible than the current one.
25496 * class.cs (TypeContainer.GetClassBases): Check whether base types
25497 are at least as accessible than the current type.
25498 (TypeContainer.AsAccessible): Implemented and made non-static.
25499 (MemberBase.CheckParameters): Report errors if the accessibility
25502 * delegate.cs (Delegate.Delegate): The default visibility is
25503 internal for top-level types and private for nested types.
25504 (Delegate.Define): Report errors if the accessibility checks fail.
25506 * enum.cs (Enum.Enum): The default visibility is internal for
25507 top-level types and private for nested types.
25508 (Enum.DefineType): Compute the correct visibility.
25510 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25511 function which takes a `bool is_toplevel' instead of a TypeContainer.
25513 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25516 2002-08-02 Martin Baulig <martin@gnome.org>
25518 * expression.cs (LocalVariableReferenc): Added constructor which
25519 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25520 (LocalVariableReference.IsReadOnly): New property.
25521 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25522 variable is readonly, use our own readonly flag to do this; you can
25523 use the new constructor to get a writable reference to a read-only
25526 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25527 reference to the local variable.
25529 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25531 * rootcontext.cs (ResolveCore): Also include System.Exception
25533 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25534 we reach an EmptyStatement.
25536 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25539 * expression.cs (Binary.ResolveOperator): Check error result in
25542 use brtrue/brfalse directly and avoid compares to null.
25544 2002-08-02 Martin Baulig <martin@gnome.org>
25546 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25547 Fixes bug #28407, added test-155.cs.
25549 2002-08-01 Martin Baulig <martin@gnome.org>
25551 * class.cs (Event.EmitDefaultMethod): Make this work with static
25552 events. Fixes #28311, added verify-3.cs.
25554 2002-08-01 Martin Baulig <martin@gnome.org>
25556 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25557 `is_disposable' fields.
25558 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25559 `hm.is_disposable' if we're using the collection pattern.
25560 (Foreach.EmitCollectionForeach): Use the correct type for the
25561 enumerator's local variable, only emit the try/finally block if
25562 necessary (fixes #27713).
25564 2002-08-01 Martin Baulig <martin@gnome.org>
25566 * ecore.cs (Expression.report118): Renamed to Error118 and made
25569 * statement.cs (Throw.Resolve): Check whether the expression is of
25570 the correct type (CS0118) and whether the type derives from
25571 System.Exception (CS0155).
25572 (Catch.Resolve): New method. Do the type lookup here and check
25573 whether it derives from System.Exception (CS0155).
25574 (Catch.CatchType, Catch.IsGeneral): New public properties.
25576 * typemanager.cs (TypeManager.exception_type): Added.
25578 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25580 * driver.cs: Updated About function.
25582 2002-07-31 Martin Baulig <martin@gnome.org>
25584 Implemented Control Flow Analysis.
25586 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25587 (EmitContext.CurrentBranching): Added.
25588 (EmitContext.StartFlowBranching): Added.
25589 (EmitContext.EndFlowBranching): Added.
25590 (EmitContext.KillFlowBranching): Added.
25591 (EmitContext.IsVariableAssigned): Added.
25592 (EmitContext.SetVariableAssigned): Added.
25593 (EmitContext.IsParameterAssigned): Added.
25594 (EmitContext.SetParameterAssigned): Added.
25595 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25596 Added control flow analysis stuff here.
25598 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25599 resolve the expression as lvalue.
25600 (LocalVariableReference.DoResolve): Check whether the variable has
25601 already been assigned.
25602 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25603 the parameter as assigned here.
25604 (ParameterReference.DoResolve): Check whether the parameter has already
25606 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25607 expression as lvalue.
25609 * statement.cs (FlowBranching): New class for the flow analysis code.
25610 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25611 (LabeledStatement.IsDefined): New public property.
25612 (LabeledStatement.AddUsageVector): New public method to tell flow
25613 analyis that the label may be reached via a forward jump.
25614 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25616 (VariableInfo.Number): New public field. This is used by flow analysis
25617 to number all locals of a block.
25618 (Block.CountVariables): New public property. This is the number of
25619 local variables in this block (including the locals from all parent
25621 (Block.EmitMeta): Number all the variables.
25623 * statement.cs: Added flow analysis support to all classes.
25625 2002-07-31 Martin Baulig <martin@gnome.org>
25627 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25628 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25629 then use this argument.
25631 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25633 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25634 use this to specify /define options.
25636 2002-07-29 Martin Baulig <martin@gnome.org>
25638 * statement.cs (Fixed): Moved all code that does variable lookups
25639 and resolvings from Emit to Resolve.
25641 * statement.cs (For): Moved all code that does variable lookups
25642 and resolvings from Emit to Resolve.
25644 * statement.cs (Using): Moved all code that does variable lookups
25645 and resolvings from Emit to Resolve.
25647 2002-07-29 Martin Baulig <martin@gnome.org>
25649 * attribute.cs (Attribute.Resolve): Explicitly catch a
25650 System.NullReferenceException when creating the
25651 CustromAttributeBuilder and report a different warning message.
25653 2002-07-29 Martin Baulig <martin@gnome.org>
25655 * support.cs (ParameterData.ParameterName): Added method to
25656 get the name of a parameter.
25658 * typemanager.cs (TypeManager.IsValueType): New public method.
25660 2002-07-29 Martin Baulig <martin@gnome.org>
25662 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25663 is a flag which specifies that it's either ref or out.
25664 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25665 the out parameter to `out Parameter.Modifier mod', also set the
25666 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25668 * support.cs (InternalParameters.ParameterModifier): Distinguish
25669 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25670 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25672 * expression.cs (Argument.GetParameterModifier): Distinguish
25673 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25674 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25676 2002-07-29 Martin Baulig <martin@gnome.org>
25678 * expression.cs (ParameterReference.ParameterReference): Added
25679 `Location loc' argument to the constructor.
25681 * cs-parser.jay: Pass location to ParameterReference.
25683 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25685 * statement.cs (Try): Initialize the location.
25687 * cs-parser.jay: pass location to Try.
25689 * expression.cs (Unary.Reduce): Change the prototype to return
25690 whether a constant fold could be performed or not. The result is
25691 returned in an out parameters. In the case of Indirection and
25692 AddressOf, we want to perform the full tests.
25694 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25696 * statement.cs (Statement.Emit): Flag dead code.
25698 2002-07-27 Andrew Birkett <andy@nobugs.org>
25700 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25702 2002-07-27 Martin Baulig <martin@gnome.org>
25704 * class.cs (MethodData.Define): Put back call to
25705 TypeManager.AddMethod(), accidentally commented this out.
25707 * report.cs (Debug): New public method to print debugging information,
25708 this is `[Conditional ("DEBUG")]'.
25710 2002-07-26 Martin Baulig <martin@gnome.org>
25712 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25713 (switch_statement): Push the current_block to the switch_stack and
25714 pop it again when we're done with the switch.
25715 (switch_section): The new block is a child of the current_block.
25716 Fixes bug #24007, added test-152.cs.
25718 2002-07-27 Martin Baulig <martin@gnome.org>
25720 * expression.cs (Invocation.EmitArguments): When calling a varargs
25721 function with only its fixed arguments, we need to pass an empty
25724 2002-07-27 Martin Baulig <martin@gnome.org>
25726 Mono 0.13 has been released.
25728 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25730 * driver.cs: Rename --resource to --linkres, because that is what
25731 we do currently, we dont support --resource yet.
25733 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25735 2002-07-25 Martin Baulig <martin@gnome.org>
25737 * class.cs (MethodData): New public class. This is a `method builder'
25738 class for a method or one accessor of a Property/Indexer/Event.
25739 (MethodData.GetMethodFlags): Moved here from MemberBase.
25740 (MethodData.ApplyAttributes): Likewise.
25741 (MethodData.ApplyObsoleteAttribute): Likewise.
25742 (MethodData.ApplyConditionalAttribute): Likewise.
25743 (MethodData.ApplyDllImportAttribute): Likewise.
25744 (MethodData.CheckAbstractAndExternal): Likewise.
25745 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25746 (MethodData.Emit): Formerly known as Method.Emit().
25747 (MemberBase): Moved everything which was specific to a single
25748 accessor/method to MethodData.
25749 (Method): Create a new MethodData and call Define() and Emit() on it.
25750 (Property, Indexer, Event): Create a new MethodData objects for each
25751 accessor and call Define() and Emit() on them.
25753 2002-07-25 Martin Baulig <martin@gnome.org>
25755 Made MethodCore derive from MemberBase to reuse the code from there.
25756 MemberBase now also checks for attributes.
25758 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25759 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25761 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25762 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25763 (MemberBase.ApplyAttributes): New virtual method; applies the
25764 attributes to a method or accessor.
25765 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25766 (MemberBase.ApplyConditionalAttribute): Likewise.
25767 (MemberBase.ApplyDllImportAttribute): Likewise.
25768 (MemberBase.CheckAbstractAndExternal): Likewise.
25769 (MethodCore.ParameterTypes): This is now a property instead of a
25770 method, it's initialized from DoDefineParameters().
25771 (MethodCore.ParameterInfo): Removed the set accessor.
25772 (MethodCore.DoDefineParameters): New protected virtual method to
25773 initialize ParameterTypes and ParameterInfo.
25774 (Method.GetReturnType): We can now simply return the MemberType.
25775 (Method.GetMethodFlags): Override the MemberBase version and add
25776 the conditional flags.
25777 (Method.CheckBase): Moved some code from Define() here, call
25778 DoDefineParameters() here.
25779 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25780 here to avoid some larger code duplication.
25781 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25782 ensure that abstract and external accessors don't declare a body.
25784 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25785 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25786 lookup in the attribute's parent classes, so we need to abort as soon
25787 as we found the first match.
25788 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25789 the attribute has no arguments.
25791 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25794 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25796 * cs-parser.jay: reverted previous patch.
25798 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25800 * cs-parser.jay: fixed bug #22119.
25802 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25804 * attribute.cs: fixed compilation. The error was:
25805 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25806 be assigned to before control leaves the current method."
25807 [FIXME: Filed as bug #28186: MCS must report this error.]
25809 2002-07-25 Martin Baulig <martin@gnome.org>
25811 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25812 method to pull the condition name ouf of a Conditional attribute.
25813 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25814 the obsolete message and error flag out of an Obsolete attribute.
25816 * class.cs (Method.GetMethodFlags): New public method to get the
25817 TypeManager.MethodFlags for this method.
25818 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25820 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25821 if we're overriding a virtual function, set the new private variable
25822 `parent_method'; call the new TypeManager.AddMethod().
25824 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25825 the MethodBuilder and the Method in a PtrHashtable.
25826 (TypeManager.builder_to_method): Added for this purpose.
25827 (TypeManager.MethodFlags): Added IsObsoleteError.
25828 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25829 Obsolete and Conditional arguments in MethodBuilders. If we discover
25830 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25831 the message from the attribute.
25833 2002-07-24 Martin Baulig <martin@gnome.org>
25835 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25836 preprocessor directives, ensure that the argument to #define/#undef is
25837 exactly one identifier and that it's actually an identifier.
25839 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25842 2002-07-24 Martin Baulig <martin@gnome.org>
25844 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25845 initialize it to TypeManager.object_type in the constructor.
25846 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25847 of the `hm.get_current' method if we're using the collection pattern.
25848 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25849 for the explicit conversion to make it work when we're using the collection
25850 pattern and the `Current' property has a different return type than `object'.
25853 2002-07-24 Martin Baulig <martin@gnome.org>
25855 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25856 does not match, but don't report any errors. This method is called in
25857 order for all methods in a MethodGroupExpr until a matching method is
25858 found, so we don't want to bail out if the first method doesn't match.
25859 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25860 matches, report the 123. Fixes #28070.
25862 2002-07-24 Martin Baulig <martin@gnome.org>
25864 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25865 TypeManager.TypeToCoreType() to the top of the method so the
25866 following equality checks will work. Fixes #28107.
25868 2002-07-24 Martin Baulig <martin@gnome.org>
25870 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25871 operand is of type uint, and the other operand is of type sbyte,
25872 short or int, the operands are converted to type long." -
25873 Actually do what this comment already told us. Fixes bug #28106,
25876 2002-07-24 Martin Baulig <martin@gnome.org>
25878 * class.cs (MethodBase): New abstract class. This is now a base
25879 class for Property, Indexer and Event to avoid some code duplication
25880 in their Define() and DefineMethods() methods.
25881 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25882 generic methods for Define() and DefineMethods().
25883 (FieldBase): Derive from MemberBase, not MemberCore.
25884 (Property): Derive from MemberBase, not MemberCore.
25885 (Property.DefineMethod): Moved all the code from this method to the
25886 new MethodBase.DefineAccessor(), just call it with appropriate
25888 (Property.Define): Call the new Property.DoDefine(), this does some
25889 sanity checks and we don't need to duplicate the code everywhere.
25890 (Event): Derive from MemberBase, not MemberCore.
25891 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25892 accessors, this will also make them work with interface events.
25893 (Indexer): Derive from MemberBase, not MemberCore.
25894 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25895 (Indexer.Define): Use the new MethodBase functions.
25897 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25898 argument to the constructor.
25899 (Interface.FindMembers): Added support for interface events.
25900 (Interface.PopluateEvent): Implemented.
25902 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25904 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25906 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25907 but this is required to check for a method name being the same as
25908 the containing class.
25912 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25914 * interface.cs: initialize variable.
25916 2002-07-23 Martin Baulig <martin@gnome.org>
25918 Implemented the IndexerName attribute in interfaces.
25920 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25921 name if this is an explicit interface implementation.
25922 (Indexer.InterfaceIndexerName): New public variable. If we're
25923 implementing an interface indexer, this is the IndexerName in that
25924 interface. Otherwise, it's the IndexerName.
25925 (Indexer.DefineMethod): If we're implementing interface indexer,
25926 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25927 and Pending.ImplementIndexer methods.
25928 (Indexer.Define): Also define the PropertyBuilder if we're
25929 implementing an interface indexer and this is neither an explicit
25930 interface implementation nor do the IndexerName match the one in
25933 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25934 If a method is defined here, then we always need to create a proxy
25935 for it. This is used when implementing interface indexers.
25936 (Pending.IsInterfaceIndexer): New public method.
25937 (Pending.ImplementIndexer): New public method.
25938 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25939 This is used when implementing interface indexers to define a proxy
25941 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25942 define a proxy if necessary.
25944 * interface.cs (Interface.IndexerName): New public variable.
25945 (Interface.PopulateIndexer): Set the IndexerName.
25946 (Interface.DefineIndexers): New private method. Populate all the
25947 indexers and make sure their IndexerNames match.
25949 * typemanager.cs (IndexerPropertyName): Added support for interface
25952 2002-07-22 Martin Baulig <martin@gnome.org>
25954 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25955 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25956 ret if HasReturnLabel.
25957 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25960 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25961 and set the ec.LoopBeginTryCatchLevel.
25962 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25963 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25964 the current ec.TryCatchLevel, the branch goes out of an exception
25965 block. In this case, we need to use Leave and not Br.
25967 2002-07-22 Martin Baulig <martin@gnome.org>
25969 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25970 block unless the block does not always return or it is contained in
25971 another try { ... } catch { ... } block. Fixes bug #26506.
25972 Added verify-1.cs to the test suite.
25974 2002-07-22 Martin Baulig <martin@gnome.org>
25976 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25977 then we do not always return. Fixes bug #24985.
25979 2002-07-22 Martin Baulig <martin@gnome.org>
25981 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25982 lookup on a per-class level; ie. walk up the class hierarchy until we
25983 found at least one applicable method, then choose the best among them.
25984 Fixes bug #24463 and test-29.cs.
25986 2002-07-22 Martin Baulig <martin@gnome.org>
25988 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25989 return types of the methods. The return type is not part of the
25990 signature and we must not check it to make the `new' modifier work.
25991 Fixes bug #27999, also added test-147.cs.
25992 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25994 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25995 on the method's return type.
25997 2002-07-21 Martin Baulig <martin@gnome.org>
25999 * assign.cs: Make this work if the rightmost source is a constant and
26000 we need to do an implicit type conversion. Also adding a few more tests
26001 to test-38.cs which should have caught this.
26003 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
26004 target in the makefile for this. The makefile.gnu is primarily intended
26005 for end-users who don't want to debug the compiler.
26007 2002-07-21 Martin Baulig <martin@gnome.org>
26009 * assign.cs: Improved the Assign class so it can now handle embedded
26010 assignments (X = Y = Z = something). As a side-effect this'll now also
26011 consume less local variables. test-38.cs now passes with MCS, added
26012 a few new test cases to that test.
26014 2002-07-20 Martin Baulig <martin@gnome.org>
26016 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
26017 instructions. Fixes bug #27977, also added test-146.cs.
26019 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26021 * cs-tokenizer.cs: fixed getHex ().
26023 2002-07-19 Martin Baulig <martin@gnome.org>
26025 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
26026 not Type.GetType() to lookup the array type. This is needed when
26027 we're constructing an array of a user-defined type.
26028 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
26029 single-dimensional arrays, but also for single-dimensial arrays of
26032 2002-07-19 Martin Baulig <martin@gnome.org>
26034 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
26035 this function is called, it's not allowed to share LocalBuilders
26036 among ILGenerators.
26038 2002-07-19 Martin Baulig <martin@gnome.org>
26040 * expression.cs (Argument.Resolve): Report an error 118 when trying
26041 to pass a type as argument.
26043 2002-07-18 Martin Baulig <martin@gnome.org>
26045 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
26046 Conv_R_Un for the signed `long' type.
26048 2002-07-15 Miguel de Icaza <miguel@ximian.com>
26050 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
26051 `expr' for the temporary result, as that will fail if we do
26052 multiple resolves on the same expression.
26054 2002-07-05 Miguel de Icaza <miguel@ximian.com>
26056 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
26057 ec.TypeContainer for looking up aliases.
26059 * class.cs (TypeContainer): Remove LookupAlias from here.
26061 * decl.cs (DeclSpace); Move here.
26063 2002-07-01 Miguel de Icaza <miguel@ximian.com>
26065 * class.cs (FindMembers): Only call filter if the constructor
26066 bulider is not null.
26068 Also handle delegates in `NestedTypes' now. Now we will perform
26069 type lookups using the standard resolution process. This also
26072 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
26073 This uses Expressions (the limited kind that can be parsed by the
26074 tree) instead of strings.
26076 * expression.cs (ComposedCast.ToString): Implement, used to flag
26077 errors since now we have to render expressions.
26079 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
26082 * ecore.cs (SimpleName.ToString): ditto.
26084 * cs-parser.jay: Instead of using strings to assemble types, use
26085 Expressions to assemble the type (using SimpleName, ComposedCast,
26086 MemberAccess). This should fix the type lookups in declarations,
26087 because we were using a different code path for this.
26089 * statement.cs (Block.Resolve): Continue processing statements
26090 even when there is an error.
26092 2002-07-17 Miguel de Icaza <miguel@ximian.com>
26094 * class.cs (Event.Define): Also remove the `remove' method from
26095 the list of pending items.
26097 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
26098 generate more compact code.
26100 2002-07-17 Martin Baulig <martin@gnome.org>
26102 * const.cs (Const.LookupConstantValue): Add support for constant
26103 `unchecked' and `checked' expressions.
26104 Also adding test case test-140.cs for this.
26106 2002-07-17 Martin Baulig <martin@gnome.org>
26108 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
26109 check whether mi.ReturnType implements the IEnumerator interface; the
26110 `==' and the IsAssignableFrom() will fail in this situation.
26112 2002-07-16 Ravi Pratap <ravi@ximian.com>
26114 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
26117 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26119 * expression.cs: fixed bug #27811.
26121 2002-07-14 Miguel de Icaza <miguel@ximian.com>
26123 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
26124 Molaro: when we are a ref, the value already contains a pointer
26125 value, do not take the address of it.
26127 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26128 * removed mb-parser.jay and mb-tokenizer.cs
26130 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26132 * expression.cs: check against the building corlib void type.
26134 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
26136 * ecore.cs: fix for valuetype static readonly fields: when
26137 initializing them, we need their address, not the address of a copy.
26139 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
26141 * typemanager.cs: register also enum_type in corlib.
26143 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26145 * class.cs: allow calling this (but not base) initializers in structs.
26147 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
26149 * ecore.cs: make sure we compare against the building base types
26152 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
26154 * typemanager.cs: fix TypeToCoreType() to handle void and object
26155 (corlib gets no more typerefs after this change).
26157 2002-07-12 Miguel de Icaza <miguel@ximian.com>
26159 * expression.cs (ArrayCreation.EmitArrayArguments): use
26160 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
26162 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
26163 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
26164 array indexes, the runtime actually forbids them.
26166 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
26167 for array arguments here.
26169 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
26170 instead of the default for ValueTypes.
26172 (New.DoEmit): Use IsValueType instead of
26173 IsSubclassOf (value_type)
26174 (New.DoResolve): ditto.
26175 (Invocation.EmitCall): ditto.
26177 * assign.cs (Assign): ditto.
26179 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
26180 Statements *are* currently doing part of their resolution during
26183 Expressions do always resolve during resolve, but statements are
26184 only required to propagate resolution to their children.
26186 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26188 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26190 (LoadAssembly): Do not add the dll if it is already specified
26192 (MainDriver): Add the System directory to the link path at the end,
26193 after all the other -L arguments.
26195 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26196 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26197 ldelem.u1) and using the opposite for sbytes.
26199 This fixes Digger, and we can finally run it.
26201 * driver.cs (UnixParseOption): Move the option parsing here.
26202 (CSCParseOption): Implement CSC-like parsing of options.
26204 We now support both modes of operation, the old Unix way, and the
26205 new CSC-like way. This should help those who wanted to make cross
26206 platform makefiles.
26208 The only thing broken is that /r:, /reference: and /lib: are not
26209 implemented, because I want to make those have the same semantics
26210 as the CSC compiler has, and kill once and for all the confussion
26211 around this. Will be doing this tomorrow.
26213 * statement.cs (Unsafe.Resolve): The state is checked during
26214 resolve, not emit, so we have to set the flags for IsUnsfe here.
26216 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26218 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26219 not catch the Error_ObjectRefRequired in SimpleName (as it is
26220 possible to have a class/instance variable name that later gets
26221 deambiguated), we have to check this here.
26223 2002-07-10 Ravi Pratap <ravi@ximian.com>
26225 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26226 make static and put into Expression.
26228 (Event.Define): Register the private field of the event with the
26229 TypeManager so that GetFieldFromEvent can get at it.
26231 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26232 keep track of the private field associated with an event which
26235 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26238 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26240 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26242 * expression.cs (Binary.EmitBranchable): this routine emits the
26243 Binary expression in a branchable context. This basically means:
26244 we need to branch somewhere, not just get the value on the stack.
26246 This works together with Statement.EmitBoolExpression.
26248 * statement.cs (Statement.EmitBoolExpression): Use
26251 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26253 * statement.cs (For): Reduce the number of jumps in loops.
26255 (For): Implement loop inversion for the For statement.
26257 (Break): We can be breaking out of a Try/Catch controlled section
26258 (foreach might have an implicit try/catch clause), so we need to
26259 use Leave instead of Br.
26261 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26262 now). If the instace expression supports IMemoryLocation, we use
26263 the AddressOf method from the IMemoryLocation to extract the
26264 address instead of emitting the instance.
26266 This showed up with `This', as we were emitting the instance
26267 always (Emit) instead of the Address of This. Particularly
26268 interesting when This is a value type, as we dont want the Emit
26269 effect (which was to load the object).
26271 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26273 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26275 * statement.cs (Checked): Set the CheckedState during the resolve
26276 process too, as the ConvCast operations track the checked state on
26277 the resolve process, and not emit.
26279 * cs-parser.jay (namespace_member_declaration): Flag that we have
26280 found a declaration when we do. This is used to flag error 1529
26282 * driver.cs: Report ok when we display the help only.
26284 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26286 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26288 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26290 * cs-tokenizer.cs (define): We also have to track locally the
26291 defines. AllDefines is just used for the Conditional Attribute,
26292 but we also need the local defines for the current source code.
26294 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26296 * statement.cs (While, For, Do): These loops can exit through a
26297 Break statement, use this information to tell whether the
26298 statement is the last piece of code.
26300 (Break): Flag that we break.
26302 * codegen.cs (EmitContexts): New `Breaks' state variable.
26304 2002-07-03 Martin Baulig <martin@gnome.org>
26306 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26307 modifiers in method declarations in structs. Otherwise, you won't
26308 be able to override things like Object.Equals().
26310 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26312 * class.cs (Method, Property, Indexer): Do not allow the public
26313 modifier to be used in explicit interface implementations.
26315 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26316 override modifiers in method declarations in structs
26318 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26320 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26321 integer or real overflow, report an error
26323 2002-07-02 Martin Baulig <martin@gnome.org>
26325 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26326 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26327 to tell the runtime about our newly created System.Object and
26328 System.ValueType types.
26330 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26332 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26333 struct instead of Ldarg/Starg.
26335 2002-07-02 Martin Baulig <martin@gnome.org>
26337 * expression.cs (Indirection.Indirection): Call
26338 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26340 2002-07-02 Martin Baulig <martin@gnome.org>
26342 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26343 ValueType, call TypeManager.TypeToCoreType() on it.
26344 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26345 the OpCodes.Newarr argument.
26347 2002-07-02 Martin Baulig <martin@gnome.org>
26349 * expression.cs (Invocation.EmitCall): When compiling corlib,
26350 replace all calls to the system's System.Array type to calls to
26351 the newly created one.
26353 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26354 System.Array methods.
26355 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26356 from the system's System.Array type which must be replaced.
26358 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26360 * typemanager.cs: load unverifiable_code_ctor so we can build
26361 corlib using the correct type. Avoid using GetTypeCode() with
26363 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26364 TypeManager.object_type to allow building corlib.
26366 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26368 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26370 2002-07-01 Martin Baulig <martin@gnome.org>
26372 * class.cs: Make the last change actually work, we need to check
26373 whether `ifaces != null' to avoid a crash.
26375 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26377 * class.cs: when we build structs without fields that implement
26378 interfaces, we need to add the interfaces separately, since there is
26379 no API to both set the size and add the interfaces at type creation
26382 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26384 * expression.cs: the dimension arguments to the array constructors
26385 need to be converted if they are a long.
26387 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26389 * class.cs: don't emit ldarg.0 if there is no parent constructor
26390 (fixes showstopper for corlib).
26392 2002-06-29 Martin Baulig <martin@gnome.org>
26394 MCS now compiles corlib on GNU/Linux :-)
26396 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26397 ie. check for MethodImplOptions.InternalCall.
26399 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26400 and TypeManager.attribute_type are null, so we must explicitly check
26401 whether parent is not null to find out whether it's an attribute type.
26402 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26403 and SetBuilder, not only if the property is neither abstract nor external.
26404 This is necessary to set the MethodImplOptions on the accessor methods.
26405 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26406 SetBuilder, see Property.Emit().
26408 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26409 populate "System.Object", "System.ValueType" and "System.Attribute" since
26410 they've already been populated from BootCorlib_PopulateCoreTypes().
26412 2002-06-29 Martin Baulig <martin@gnome.org>
26414 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26415 is the NullLiteral, we also need to make sure that target_type is not
26418 2002-06-29 Martin Baulig <martin@gnome.org>
26420 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26421 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26422 before calling BootstrapCorlib_ResolveDelegate ().
26424 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26426 * statement.cs: fixed build-breaker. All tests passed ok.
26428 2002-06-27 Martin Baulig <martin@gnome.org>
26430 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26431 for System.Decimal when compiling corlib.
26433 2002-06-27 Martin Baulig <martin@gnome.org>
26435 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26436 switch blocks which contain nothing but a default clause.
26438 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26440 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26442 2002-06-27 Martin Baulig <martin@gnome.org>
26444 * ecore.cs (PropertyExpr.PropertyExpr): Call
26445 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26447 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26448 is already a TypeBuilder.
26450 2002-06-27 Martin Baulig <martin@gnome.org>
26452 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26453 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26454 the "from an array-type to System.Array" case. This makes it work
26455 when compiling corlib.
26457 2002-06-27 Martin Baulig <martin@gnome.org>
26459 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26460 non-static PropertyExpr, set its InstanceExpression. This makes
26461 the `ICollection.Count' property work in System/Array.cs.
26463 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26465 * driver.cs: Made error handling more consistent. Errors now
26466 tracked by Report class, so many methods which used to return int
26467 now return void. Main() now prints success/failure and
26468 errors/warnings message.
26470 Renamed '--probe' compiler argument to '--expect-error'. Removed
26471 the magic number return values (123 and 124). Now, if the
26472 expected error occurs, the compiler exits with success (exit value
26473 0). If the compilation completes without seeing that particular
26474 error, the compiler exits with failure (exit value 1). The
26475 makefile in mcs/errors has been changed to handle the new behaviour.
26477 * report.cs: Made 'expected error' number a property and renamed
26478 it from 'Probe' to 'ExpectedError'.
26480 * genericparser.cs: Removed error handling support, since it is
26481 now all done by Report class.
26483 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26484 class, so parse() no longer returns an int.
26486 * namespace.cs: Use Report.Error instead of GenericParser.error
26488 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26490 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26491 TypeContainer.AddOperator): At the front of the list put the
26492 explicit implementations, so they get resolved/defined first.
26494 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26496 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26497 interface type is implemented by this TypeContainer. Used during
26498 explicit interface implementation.
26500 (Property.Define, Indexer.Define, Method.Define): Validate that
26501 the given interface in the explicit implementation is one of the
26502 base classes for the containing type.
26504 Also if we are explicitly implementing an interface, but there is
26505 no match in the pending implementation table, report an error.
26507 (Property.Define): Only define the property if we are
26508 not explicitly implementing a property from an interface. Use the
26509 correct name also for those properties (the same CSC uses,
26510 although that is really not needed).
26512 (Property.Emit): Do not emit attributes for explicitly implemented
26513 properties, as there is no TypeBuilder.
26515 (Indexer.Emit): ditto.
26517 Hiding then means that we do not really *implement* a pending
26518 implementation, which makes code fail.
26520 2002-06-22 Martin Baulig <martin@gnome.org>
26522 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26523 the return value of Object.GetType(). [FIXME: we need to do this whenever
26524 we get a type back from the reflection library].
26526 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26528 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26530 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26532 * attribute.cs: Return null if we can not look up the type.
26534 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26535 the interface types found.
26537 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26538 interface types found.
26540 * typemanager.cs (GetInterfaces): Make this routine returns alll
26541 the interfaces and work around the lame differences between
26542 System.Type and System.Reflection.Emit.TypeBuilder in the results
26543 result for GetInterfaces.
26545 (ExpandInterfaces): Given an array of interface types, expand and
26546 eliminate repeated ocurrences of an interface. This expands in
26547 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26550 2002-06-21 Martin Baulig <martin@gnome.org>
26552 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26555 2002-06-21 Martin Baulig <martin@gnome.org>
26557 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26558 and called with one of the core types, return the corresponding typebuilder for
26561 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26564 2002-06-21 Martin Baulig <martin@gnome.org>
26566 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26567 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26568 (Expression.ConvertReferenceExplicit): Likewise.
26570 * expression.cs (ElementAccess.DoResolve): Likewise.
26571 (ElementAccess.DoResolveLValue): Likewise.
26573 2002-06-10 Martin Baulig <martin@gnome.org>
26575 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26576 add the "value" parameter to the parameter list.
26578 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26581 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26583 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26584 the argument to an int, uint, long or ulong, per the spec. Also
26585 catch negative constants in array creation.
26587 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26589 * class.cs: do not allow the same interface to appear twice in
26590 the definition list.
26592 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26594 * ecore.cs: don't use ldlen with System.Array.
26596 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26598 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26600 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26602 * modifiers.cs: produce correct field attributes for protected
26603 internal. Easy fix so miguel can work on ther harder stuff:-)
26605 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26607 * pending.cs: New file. Move the code from class.cs here.
26608 Support clearning the pending flag for all methods (when not doing
26609 explicit interface implementation).
26611 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26613 * rootcontext.cs: added a couple more types needed to bootstrap.
26615 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26617 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26618 constructor in the type, instead of any constructor in the type
26619 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26620 a bug in the Mono runtime when applying the params attribute).
26622 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26623 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26625 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26627 * expression.cs (Unary.ResolveOperator): Use TypeManager
26628 to resolve the type.
26630 2002-06-13 Ravi Pratap <ravi@ximian.com>
26632 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26635 * enum.cs (AddEnumMember): Add support to store the attributes associated
26636 with each member too.
26638 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26639 field builders too - this takes care of the enum member case.
26641 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26643 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26644 address-of operator on both value types and pointers.
26646 2002-06-10 Martin Baulig <martin@gnome.org>
26648 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26649 PropertyBuilder to the `property_builders' list.
26651 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26652 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26653 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26654 find any indexers which are inherited from an interface.
26656 2002-06-09 Martin Baulig <martin@gnome.org>
26658 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26659 the same type as the constant if necessary. There's also a test-130.cs
26662 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26664 * typemanager.cs (TypeManager.ChangeType): Previously known as
26665 Enum.ChangeEnumType().
26667 2002-06-09 Martin Baulig <martin@gnome.org>
26669 * expression.cs (Cast.TryReduce): Added support for consts.
26671 2002-06-08 Ravi Pratap <ravi@ximian.com>
26673 * class.cs (Accessor): Hold attributes information so we can pass
26676 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26677 Modify to pass in attributes attached to the methods.
26679 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26681 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26682 to handle the Accessor kind :-)
26684 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26686 2002-06-08 Martin Baulig <martin@gnome.org>
26688 * expression.cs (Unary.TryReduceNegative): Added support for
26691 2002-06-08 Martin Baulig <martin@gnome.org>
26693 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26694 name can't be found in the `defined_names' - the caller will do a
26695 MemberLookup in this case and thus find methods in System.Enum
26696 such as Enum.IsDefined().
26698 2002-06-08 Martin Baulig <martin@gnome.org>
26700 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26701 Convert.ChangeType() which works with TypeBuilder created types.
26702 (Enum.LookupEnumValue, Enum.Define): Use it here.
26704 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26705 `TypeBuilder.BaseType != null' check.
26706 (TypeContainer.FindMembers): Only lookup parent members if we
26707 actually have a parent.
26708 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26709 (ConstructorInitializer.Resolve): Likewise.
26711 * interface.cs (Interface.FindMembers): Added
26712 `TypeBuilder.BaseType != null' check.
26714 * rootcontext.cs (RootContext.ResolveCore): Added
26715 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26716 classes_second_stage.
26718 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26719 debug_type and trace_type when compiling with --nostdlib.
26721 2002-06-07 Martin Baulig <martin@gnome.org>
26723 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26724 (AddField): Set it to true when adding a non-static field.
26725 (DefineType): Use `have_nonstatic_fields' to find out whether we
26726 have non-static fields, not `Fields != null'.
26728 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26730 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26731 dereferencing a null on the static-field code path)
26733 2002-05-30 Martin Baulig <martin@gnome.org>
26735 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26736 to take command line arguments. Use reflection to call the new
26737 custom `Initialize' function on the symbol writer and pass it the
26738 command line arguments.
26740 * driver.cs (--debug-args): New command line argument to pass command
26741 line arguments to the symbol writer.
26743 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26745 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26746 the target type for indexers and properties. Thanks to Joe for
26749 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26751 * typemanager.cs (MethodFlags): returns the method flags
26752 (Obsolete/ShouldIgnore) that control warning emission and whether
26753 the invocation should be made, or ignored.
26755 * expression.cs (Invocation.Emit): Remove previous hack, we should
26756 not do this on matching a base type, we should do this based on an attribute
26758 Only emit calls to System.Diagnostics.Debug and
26759 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26760 on the command line.
26762 * rootcontext.cs: Global settings for tracing and debugging.
26764 * cs-tokenizer.cs (define): New utility function to track
26765 defines. Set the global settings for TRACE and DEBUG if found.
26767 2002-05-25 Ravi Pratap <ravi@ximian.com>
26769 * interface.cs (Populate*): Pass in the TypeContainer as well as
26770 the DeclSpace as parameters so that we can create EmitContexts and
26771 then use that to apply attributes etc.
26773 (PopulateMethod, PopulateEvent, PopulateProperty)
26774 (PopulateIndexer): Apply attributes everywhere.
26776 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26779 (ApplyAttributes): Update accordingly.
26781 We now apply interface attributes for all members too.
26783 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26785 * class.cs (Indexer.Define); Correctly check if we are explicit
26786 implementation (instead of checking the Name for a ".", we
26787 directly look up if the InterfaceType was specified).
26789 Delay the creation of the PropertyBuilder.
26791 Only create the PropertyBuilder if we are not an explicit
26792 interface implementation. This means that explicit interface
26793 implementation members do not participate in regular function
26794 lookups, and hence fixes another major ambiguity problem in
26795 overload resolution (that was the visible effect).
26797 (DefineMethod): Return whether we are doing an interface
26800 * typemanager.cs: Temporary hack until we get attributes in
26801 interfaces (Ravi is working on that) and we get IndexerName
26802 support in interfaces.
26804 * interface.cs: Register the indexers as properties.
26806 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26807 warning, I have verified that this is a bug in the .NET runtime
26808 (JavaScript suffers of the same problem).
26810 * typemanager.cs (MemberLookup): When looking up members for
26811 interfaces, the parent of an interface is the implicit
26812 System.Object (so we succeed in searches of Object methods in an
26813 interface method invocation. Example: IEnumerable x; x.ToString
26816 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26818 * class.cs (Event): Events should also register if they do
26819 implement the methods that an interface requires.
26821 * typemanager.cs (MemberLookup); use the new GetInterfaces
26824 (GetInterfaces): The code used to lookup interfaces for a type is
26825 used in more than one place, factor it here.
26827 * driver.cs: Track the errors at the bottom of the file, we kept
26830 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26831 instance if the method we are calling is static!
26833 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26835 * attribute.cs (ApplyAttributes): Make this function filter out
26836 the IndexerName attribute (as that attribute in reality is never
26837 applied) and return the string constant for the IndexerName
26840 * class.cs (TypeContainer.Emit): Validate that all the indexers
26841 have the same IndexerName attribute, and if so, set the
26842 DefaultName attribute on the class.
26844 * typemanager.cs: The return value might contain other stuff (not
26845 only methods). For instance, consider a method with an "Item"
26846 property and an Item method.
26848 * class.cs: If there is a problem with the parameter types,
26851 2002-05-24 Ravi Pratap <ravi@ximian.com>
26853 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26854 looks at user defined conversion after making a call to
26855 StandardConversionExists - we need this for overload resolution.
26857 * expression.cs : Update accordingly the various method calls.
26859 This fixes 2 bugs filed against implicit user defined conversions
26861 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26863 * statement.cs: Track the result of the assignment.
26865 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26867 * expression.cs (MemberAccess): Improved error reporting for
26868 inaccessible members.
26870 2002-05-22 Martin Baulig <martin@gnome.org>
26872 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26873 itself with debugging support.
26875 2002-05-22 Martin Baulig <martin@gnome.org>
26877 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26878 Removed, this isn't needed anymore.
26880 2002-05-20 Martin Baulig <martin@gnome.org>
26882 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26883 be underlying type for an enum.
26885 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26887 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26888 that splits out the loading of just the core types.
26890 * rootcontext.cs (ResolveCore): Split the struct resolution in
26891 two, so we can load the enumeration underlying types before any
26894 * expression.cs (Is): Bandaid until we fix properly Switch (see
26895 bug #24985 for details).
26897 * typemanager.cs (ImplementsInterface): The hashtable will contain
26898 a null if there are no interfaces implemented.
26900 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26902 * cs-parser.jay (indexer_declarator): It is fine to have array
26905 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26907 * typemanager.cs: (RegisterBuilder): New function used to register
26908 TypeBuilders that implement interfaces. Since
26909 TypeBuilder.GetInterfaces (as usual) does not work with lame
26911 (AddUserType): register interfaces.
26913 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26914 dealing with TypeBuilder. Also, arrays are showing up as
26915 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26916 methods can not be invoked on them!
26918 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26919 (ImplicitReferenceConversionExists): Split out from
26920 StandardConversionExists.
26922 * expression.cs (As): We were only implementing one of the three
26923 cases for the as operator. We now implement them all.
26924 (Is): Implement the various other cases for Is as well.
26926 * typemanager.cs (CACHE): New define used to control if we want or
26927 not the FindMembers cache. Seems to have a negative impact on
26928 performance currently
26930 (MemberLookup): Nested types have full acess to
26931 enclosing type members
26933 Remove code that coped with instance/static returns for events, we
26934 now catch this in RealFindMembers.
26936 (RealFindMembers): only perform static lookup if the instance
26937 lookup did not return a type or an event.
26939 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26941 * assign.cs (CompoundAssign): We pass more semantic information
26942 now to Compound Assignments than we did before: now we have all
26943 the information at hand, and now we resolve the target *before* we
26944 do the expression expansion, which allows the "CacheValue" method
26945 to have the effect we intended (before, a [x] += 1 would generate
26946 two differen ArrayAccess expressions from the ElementAccess,
26947 during the resolution process).
26949 (CompoundAssign.DoResolve): Resolve target and original_source here.
26951 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26953 * expression.cs (ArrayAccess): dropped debugging information.
26955 * typemanager.cs: Small bug fix: I was always returning i_members,
26956 instead of one of i_members or s_members (depending on which had
26959 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26960 method is invoked before any code generation takes place, and it
26961 is a mechanism to inform that the expression will be invoked more
26962 than once, and that the method should use temporary values to
26963 avoid having side effects
26965 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26967 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26970 * expression.cs (Indirection, ArrayAccess): Add support for
26971 CacheTemporaries in these two bad boys.
26973 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26974 ldobj or ldind_ref.
26975 (StoreFromPtr): Handle stobj as well.
26977 * expression.cs (UnaryMutator): Share more code.
26979 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26980 down: I was not tracking the Filter function as well, which
26981 was affecting the results of the cache.
26983 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26985 * attribute.cs: Remove the hack to handle the CharSet property on
26988 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26990 * attribute.cs (DoResolve): More uglyness, we now only try to
26991 resolve the attribute partially, to extract the CharSet
26992 information (only if we are a StructLayout attribute). Otherwise
26994 (GetExtraTypeInfo): Add some code to conditionally kill in the
26995 future this. I am more and more convinced that the .NET
26996 framework has special code to handle the attribute setting on
26999 * expression.cs (IsParamsMethodApplicable): Revert my previous
27000 foreach change here, it was wrong.
27002 2002-05-13 Miguel de Icaza <miguel@ximian.com>
27004 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
27005 (pp_expr): do not abort on unknown input, just return.
27006 (eval): abort if there are pending chars.
27008 * attribute.cs (Attribute.Resolve): Positional parameters are
27009 optional. Deal with that case.
27011 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
27012 the Ansi/Unicode/Auto information for the type.
27014 (TypeContainer.DefineType): instantiate the EmitContext here, as
27015 we will be using it during the type definition (to resolve
27016 attributes) and during the emit phase.
27018 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
27019 to pull type information out of the attributes
27021 (Attribute.Resolve): track the constructor builder, and allow for
27022 multiple invocations (structs and classes will use this).
27024 * ecore.cs (MemberLookupFinal): new version with all the
27025 parameters customizable.
27027 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
27028 constructors. Return if the result value is null (as the error
27029 would have been flagged already by MemberLookupFinal)
27031 Do not allow instances of abstract classes or interfaces to be
27034 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
27035 We have to compare the assembly property here when dealing with
27036 FamANDAssem and Assembly access modifiers, because we might be
27037 creating an assembly from *modules* (that means that we are not
27038 getting TypeBuilders for types defined in other modules that are
27039 part of this assembly).
27041 (Method.Emit): If the method is marked abstract and has a body,
27044 (TypeContainer.DefineMembers): If both the defined member and the
27045 parent name match are methods, then do not emit any warnings: let
27046 the Method.Define routine take care of flagging warnings. But if
27047 there is a mismatch (method overrides something else, or method is
27048 overriwritten by something, then emit warning).
27050 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
27051 set to null, this means `do not check for the return type on the
27054 (Method.Define): set the return type for the method signature to
27055 null, so that we get methods with the same name and parameters and
27056 different return types. This is used to flag warning 114 (you are
27057 hiding a method, and you probably want to use the new/override
27060 * typemanager.cs (MemberLookup): Implemented proper access
27061 control, closing a long standing set of bug reports. The problem
27062 was that the Framework only has two bits: Public and NonPublic,
27063 and NonPublic includes private and protected methods, but we need
27064 to enforce the FamANDAssem, FamOrAssem and Family.
27066 2002-05-11 Miguel de Icaza <miguel@ximian.com>
27068 * statement.cs (GotoCase): Return true: Ammounts to giving up
27069 knowledge on whether we return or not, and letting the other case
27070 be responsible for it.
27072 2002-05-10 Miguel de Icaza <miguel@ximian.com>
27074 * driver.cs: Do not load directories for each file processed, only
27075 do it if there is a pattern.
27077 * ecore.cs: Report readonly assigns here as well, as we might have
27078 been resolved only by MemberAccess.
27080 (SimpleName.SimpleNameResolve): Also be useful for LValue
27081 resolution. We need this to propagate assign to local readonly variables
27083 * typemanager.cs: Use a ptrhashtable for the criteria, because we
27084 do not want to reuse potential criteria memory.
27086 * class.cs (MyEventBuilder): Set reflected_type;
27088 * ecore.cs (Constantify): Added support for constifying bools.
27090 (RootContext.LookupType): Added a cache for values looked up in
27091 the declaration space.
27093 * typemanager.cs (FindMembers): Now is a front-end to
27094 RealFindMembers, and provides a two-level hashtable-based cache to
27097 15% performance improvement: from 22.5 to 19.2 seconds.
27099 * expression.cs (IsParamsMethodApplicable): use foreach.
27100 (Invocation.DoResolve): ditto.
27101 (New.DoResolve): ditto.
27102 (ArrayCreation.DoResolve): ditto.
27104 * ecore.cs (FindMostEncompassingType): use foreach.
27106 * delegate.cs (NewDelegate.DoResolve): Use foreach
27108 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
27109 (RemoveMethods): use foreach.
27111 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
27112 nested foreach statements instead of for, and also break out of
27113 the inner loop once a match is found.
27115 (Invocation.OverloadResolve): Use foreach, simplify the code.
27117 2002-05-08 Miguel de Icaza <miguel@ximian.com>
27119 * cfold.cs (BinaryFold): During an enumeration evaluation context,
27120 we actually unwrap the expression to allow for extra information
27123 * expression.cs: Use Shr_Un on unsigned operations.
27125 2002-05-08 Ravi Pratap <ravi@ximian.com>
27127 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
27128 applicable operators was not being considered correctly. This closes
27129 the bug Miguel reported.
27131 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
27133 * attribute.cs: check that the type derives from System.Attribute
27134 and report the correct error in that case (moved the duplicate code to
27135 its own method, too).
27137 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
27139 * attribute.cs: lookup attribute type name as the spec says: first the
27140 bare attribute name and then name + "Attribute" (nant compiles with
27141 mcs after this fix).
27143 2002-05-07 Miguel de Icaza <miguel@ximian.com>
27145 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
27146 Because of the way we parse things, we should try to see if a
27147 UIntConstant can fit in an integer.
27149 2002-05-07 Ravi Pratap <ravi@ximian.com>
27151 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
27152 when we are in an explicit context.
27154 (ConvertReferenceExplicit): When converting from Iface type S to Class
27155 T make sure the rules are implemented as an OR.
27157 * parameter.cs (ParameterType): Make it a property for now although the
27158 purpose really isn't anything immediate.
27160 * expression.cs (Is*Applicable): Do better checking on the parameter type
27161 of a ref/out parameter. The ones from the system assemblies are already
27162 marked with the correct type so we don't need to do any correction.
27164 * ecore.cs (StandardConversionExists): Conversion from Interface types to
27165 the object type is standard too so include that.
27167 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27169 * ecore.cs (StandardConversionExists): Augment with missing code:
27170 deal with IntConstant, LongConstants and Enumerations.
27172 * assign.cs: Report the error, instead of failing silently
27174 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
27175 typecontainer that they are declared, because the
27176 typecontainer/namespace will have the list of using clauses that
27177 need to be applied.
27179 Assembly Attributes were escaping the normal registration
27182 (EmitCode): Apply attributes within an EmitContext that represents
27183 the container they were declared on.
27185 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27187 2002-05-06 Ravi Pratap <ravi@ximian.com>
27189 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27190 Revamp completely - make much cleaner as we now operate only
27193 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27194 to implement the logic detailed in the spec more correctly.
27196 (UserDefinedConversion): Update accordingly.
27198 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27200 * statement.cs: Return flow analysis information up.
27202 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27205 (token): Do not consume an extra character before calling
27208 2002-05-06 Piers Haken <piersh@friskit.com>
27210 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27212 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27214 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27215 EmitContext during the instance constructor initializer
27216 resolution, to stop access to instance variables.
27218 This is mandated by the spec, last paragraph of the `constructor
27219 initializers' section.
27221 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27223 * cs-parser.jay, class.cs (Accessor): new class used to represent
27224 an accessor (get or set). In the past we used `null' to represent
27225 a missing accessor. But this is ambiguous because there was no
27226 way to tell in abstract indexers/properties if one of them was
27229 Now there is a way of addressing that.
27231 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27232 instead of FindMembers.
27234 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27235 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27237 * attribute.cs: Treat indexers and properties as the same in terms
27238 of applying attributes
27240 * ecore.cs (FindMostEncompassedType): Use statically initialized
27241 EmptyExpressions()s like we do elsewhere to avoid creating useless
27242 objects (and we take this out of the tight loop).
27244 (GetConversionOperators): Move the code to extract the actual
27245 operators to a separate routine to clean things up.
27247 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27249 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27250 events are always registered FieldBuilders.
27252 * class.cs (FieldBase): New class shared by Fields
27254 * delegate.cs: If we are a toplevel delegate, use our full name.
27255 If we are a nested delegate, then only use our tail name.
27257 2002-05-02 Ravi Pratap <ravi@ximian.com>
27259 * expression.cs (IsApplicable): Ensure that we add the "&" to
27260 ref/out types before comparing it with the type of the argument.
27262 (IsParamsMethodApplicable): Ditto.
27264 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27267 * delegate.cs : Handle the case when we have more than one applicable
27268 method. Flag an error only when we finish checking all.
27270 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27272 * expression.cs: Add support for boolean static initializers.
27274 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27276 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27278 * parameter.cs (ComputeParameterTypes,
27279 ComputeAndDefineParameterTypes): Better error handling: now we
27280 clear the `types' cache if we fail during any of the type lookups.
27281 We also return the status code correctly to our caller
27283 * delegate.cs: If we fail to define a delegate, abort the extra
27286 * expression.cs (Binary.ResolveOperator): for
27287 operator==(object,object) and operator !=(object, object) we also
27288 have to verify that there is an implicit conversion from one to
27291 (ArrayAccess.DoResolve): Array Access can operate on
27294 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27296 * assign.cs (CompoundAssign): A new class used as a "flag" that
27297 the assignment actually is happening as part of a compound
27298 assignment operator.
27300 During compound assignment, a few new rules exist to enable things
27307 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27308 to the type of x) if y is implicitly convertible to the type of x,
27309 and the operator is a builtin operator and the return type of the
27310 operator is explicitly convertible to the type of x.
27312 * rootcontext.cs: Reset warning level to 2. 4 catches various
27313 "interesting" features in mcs, we must clean this up at some
27314 point, but currently am trying to kill other bugs ;-)
27316 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27317 in container classes as well.
27319 * expression.cs (Binary.ResolveOperator): Handle string case
27320 before anything else (as operator overloading does emit an error
27321 before doing anything else).
27323 This code could go away when we move to a table driven model, but
27324 i could not come up with a good plan last night.
27326 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27328 * typemanager.cs (CSharpName): reimplementation using regex.
27329 * class.cs: added null check for fields in Emit
27330 * rootcontext.cs: set warninglevel to 4
27332 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27334 * typemanager.cs (CSharpName): reimplemented with Lupus
27337 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27339 * statement.cs (If): correclty implement Resolve, because we were
27340 not catching sem errors in there. The same process is needed
27342 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27345 (Statement.Warning_DeadCodeFound): Factorize code.
27346 (While): Report dead code here too.
27348 (Statement): Added Resolve virtual method to allow
27349 for resolution split from the emit code.
27351 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27353 * statement.cs (EmitBoolExpression): No longer try to resolve the
27355 (MakeBoolean): New utility function that resolve, implicitly
27356 converts to boolean and tags the expression.
27359 (If, Do): Implement dead code elimination.
27360 (While): Implement loop inversion
27362 (Do, While, For, If): Resolve the expression prior to calling our
27365 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27368 - added method Report28 (warning: program has more than one entry point)
27369 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27370 - modified method Method.Define, the part at the end of the method
27372 * rootcontext.cs: added static public Location EntryPointLocation;
27374 * ../errors/cs0028.cs : Add test case for the above warning.
27377 - modified method CSharpName to allow arrays of primitive type to
27378 be printed nicely (e.g. instead of System.Int32[][] it now prints
27380 - added method CSharpSignature: returns the signature of a method
27381 in string format to be used in reporting errors, warnings, etc.
27383 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27386 2002-04-26 Ravi Pratap <ravi@ximian.com>
27388 * delegate.cs (Define): Fix extremely silly bug where I was
27389 setting the type of the 'object' parameter of the BeginInvoke
27390 method to System.IAsyncResult instead of System.Object ;-)
27392 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27394 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27397 (Constructor.Emit): return if we fail to initialize the
27398 constructor. Another door closed!
27400 * expression.cs (New.DoResolve): Improve error message (from -6 to
27401 1501). Use DeclaredOnly lookup to find the exact constructor.
27403 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27404 loop. This is useful.
27406 * cs-parser.jay: Adjust the default parameters so that destructors
27407 have the proper signature.
27409 2002-04-26 Martin Baulig <martin@gnome.org>
27411 * driver.cs (LoadAssembly): If `assembly' contains any characters
27412 which are only valid in path names and not in assembly names
27413 (currently slash, backslash and point), use Assembly.LoadFrom ()
27414 instead of Assembly.Load () on the `assembly' (before iteration
27415 over the link_paths).
27417 2002-04-26 Martin Baulig <martin@gnome.org>
27419 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27421 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27423 * class.cs (Property): use the new typemanager.MemberLookup
27425 (TypeContainer.MemberLookup): Implement using the
27426 TypeManager.MemberLookup now.
27428 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27429 and return MemberInfos, so that these can be used without an
27430 EmitContext (what we had before).
27432 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27434 * expression.cs: Fix the case where the argument to params if the
27435 type of the params. I omitted handling this before. Fixed
27437 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27439 * driver.cs: Call BootCorlib_PopulateCoreType
27441 * class.cs (Property.CheckBase): Check for properties only, not
27444 * interface.cs: Temporary hack: try/catch around the
27445 CustomAttributeBuilder, because I am getting an exception that I
27448 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27449 types whose definitions are required to be there (attributes are
27450 defined before standard types).
27452 Compute definitions as we boot the various types, as they are used
27453 immediately (value_type class will need object_type, but if we do
27454 not initialize object_type, we will pass a null, which will let
27455 the runtime pick the System.Object from the existing corlib, which
27456 is not what we want).
27458 2002-04-22 Patrik Torstensson <totte@labs2.com>
27460 * cs-tokenizer.cs: fixed a number of trim() issues.
27462 2002-04-22 Ravi Pratap <ravi@ximian.com>
27464 * expression.cs (Argument.Type): Ensure that we return the correct
27465 type when we have out or ref parameters [in which case we
27468 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27470 * class.cs (Property, Indexer): Allow extern modifier in there.
27472 * typemanager.cs (InitBaseTypes): Initializes object_type and
27473 value_type, since those will be used early on during the bootstrap
27474 process to compile corlib.
27476 (InitCoreTypes): Move code from here to InitBaseTypes.
27478 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27480 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27481 single-dimension arrays as using the ldlen opcode.
27483 Daniel Lewis discovered this optimization.
27485 * typemanager.cs: Add signature for System.Array::get_Length
27487 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27489 * statement.cs: report the error when the foreach does not apply to an
27490 array nor a collection.
27492 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27494 * expression.cs: Add implicit conversions to the operator ~.
27496 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27498 * typemanager.cs: Locate the decimal constructor.
27500 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27502 * attribute.cs: use the new property of TypeOf.
27503 * expression.cs: added 'get' property around typearg.
27505 These changes fix a build breaker reported by NickD. Is this the
27506 correct way to fix? If not, please, revert my changes and make it
27509 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27511 * attribute.cs: Add support for typeof in attribute invocations.
27512 I am not sure that this is right though.
27514 2002-04-14 Duncan Mak <duncan@ximian.com>
27516 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27517 Binary.Operator.Division case.
27519 2002-04-13 Ravi Pratap <ravi@ximian.com>
27521 * class.cs (DefineType): Ensure that we do a proper check on
27522 attribute types and also register it with the TypeManager.
27524 (TypeContainer.Targets): The default for attribute types is
27525 AttributeTargets.All.
27527 * attribute.cs (ApplyAttributes): Registering the attribute type
27528 is done elsewhere, not when we discover we have a Usage attribute.
27530 2002-04-12 Ravi Pratap <ravi@ximian.com>
27532 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27533 and get rid of is_delegate parameter.
27535 * everywhere : update.
27537 2002-04-12 Ravi Pratap <ravi@ximian.com>
27539 * cs-parser.jay (compilation_unit): Revamp completely to use
27540 some new ideas that I got from Rhys' grammar to solve the problems
27541 with assembly level attributes.
27543 (outer_declaration): New grammar production.
27545 (attribute_sections): Add.
27547 (opt_attributes): Base on attribute_sections
27549 (namespace_declaration): Allow opt_attributes to tackle the case
27550 when we have assembly level attributes - we are clever in this
27553 * attribute.cs (ApplyAttributes): Do not worry about assembly
27554 attributes in the non-global context.
27556 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27557 instead of SetGlobalAttributes.
27559 * class.cs, rootcontext.cs : Ensure we define and generate
27560 attribute types before anything else.
27562 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27563 and flag the new error -20 for the case when the attribute type
27564 does not have valid targets specified. csc does not catch this.
27566 * ../errors/errors.txt : update for error # -20
27568 2002-04-11 Ravi Pratap <ravi@ximian.com>
27570 * support.cs (InternalParameters.ParameterModifier): Do some null
27571 checking and return sane values.
27573 * class.cs (Method.Define): If we are a PInvoke method, ensure
27574 that we are static and extern. Report error # 601
27576 * ../errors/cs0601.cs : Add test case for the above error.
27578 2002-04-07 Ravi Pratap <ravi@ximian.com>
27580 * rootcontext.cs (attribute_types): We need to keep type of
27581 all attribute types separately and emit code for them first.
27583 (RegisterAttribute) : Implement.
27585 * class.cs (DefineType): Check if the current Type is a custom
27586 attribute type and register it accordingly.
27588 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27589 adding the first attribute twice and rename to
27591 (SetGlobalAttributes): this.
27593 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27596 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27597 if we are processing global arguments. Hmm, I am unsure of this.
27599 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27601 * expression.cs: added static array of strings to avoid calling
27602 Enum.ToString () for Operator in Binary. Significant recover of
27605 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27607 * class.cs (FindMembers): Allow the Builders of the various
27608 members to be null. If they are skip them. This only happens
27609 during the PInvoke declaration.
27611 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27613 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27614 failure, so we do not keep going afterwards.
27616 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27617 wanted to pass `false' as the `is_delegate' argument. If this is
27618 the case, why not use delegate_type == null to mean `is_delegate =
27619 false' and anything else as is_delegate = true.
27621 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27623 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27624 code for the section, not the beginning of the tests.
27626 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27628 * cfold.cs: Handle operator + (Enum x, Underlying x)
27630 * expression.cs (Binary): same. Warn about errors where we have
27631 Enum/Enum in operator + as well.
27633 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27636 - added support for switch(bool)
27637 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27638 - add TableSwitchEmit() to handle table-based switch statements
27640 2002-04-05 Ravi Pratap <ravi@ximian.com>
27642 * expression.cs (Invocation.OverloadResolve): Factor out code which
27643 does parameter compatibility checking with arguments so that we can
27644 re-use the code even from Delegate.VerifyApplicability
27646 (VerifyArgumentsCompat): Move above code here.
27648 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27649 and instead make a call to the above method.
27651 2002-03-31 Ravi Pratap <ravi@ximian.com>
27653 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27654 We use it to keep track of classes which are attribute types.
27656 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27658 * delegate.cs (Delegate.Define): Correctly define the types in the
27659 presence of fixed and array parameters.
27661 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27664 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27665 include NonPublic after the first iteration.
27667 * class.cs (Indexer.CheckBase): Only check if both parents are
27670 * cs-parser.jay (accessor_body): If empty, set to null.
27672 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27673 same code path here to resolve constants names that we did have in
27674 MemberAccess.DoResolve. There is too much code duplicated here.
27676 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27678 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27680 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27683 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27684 tokens, numbers and strings.
27686 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27689 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27690 asyncronous parameters and the regular parameters.
27692 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27693 specify the target directory.
27695 * expression.cs: (This.DoResolve): Simplify
27696 (As.Emit): Optimize, do not generate IsInst if the expression is
27697 always of the given type.
27699 (Is.DoResolve): Bug fix, we were reporting both always/never for
27702 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27703 creating too many unnecessary arrays.
27705 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27707 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27708 fields instead of rolling our own initializer. Takes care of all
27709 implicit conversions, and drops unnecessary static checks/argument.
27711 2002-03-31 Dick Porter <dick@ximian.com>
27713 * driver.cs: use the GetDirectories() return values properly, and
27714 use "/" as path separator.
27716 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27718 * expression.cs (Unary): Optimize - - expr into expr.
27719 (Binary): Optimize a + (-b) into a -b.
27721 * codegen.cs (CodeGen): Made all methods static.
27723 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27727 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27728 TypeBuilder property.
27730 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27733 * tree.cs: Removed the various RecordXXXX, and replaced with a
27734 single RecordDecl. Removed all the accessor methods, and just
27735 left a single access point Type
27737 * enum.cs: Rename DefineEnum to DefineType.
27739 * decl.cs: New abstract method `DefineType' used to unify the
27740 Defines for Enumerations, Interfaces, TypeContainers and
27743 (FindType): Moved LookupInterfaceOrClass here. Moved the
27744 LookupBaseClasses method that used to live in class.cs and
27745 interface.cs here, and renamed to FindType.
27747 * delegate.cs: Implement DefineType. Take advantage of the
27748 refactored pattern for locating the parent builder without taking
27749 the parent_builder argument (which we know does not work if we are
27750 nested, and triggering a toplevel definition).
27752 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27754 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27755 accessibility of a member has changed during override and report
27758 * class.cs (Method.Define, Property.Define): Only complain on
27759 overrides if the method is private, any other accessibility is
27760 fine (and since we just checked the permission is the same, we are
27763 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27764 and elif are processed always. The other pre-processing
27765 directives are only processed if we are "taking" the path
27767 2002-03-29 Martin Baulig <martin@gnome.org>
27769 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27770 current location is not Null.
27772 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27773 a separate method so we can profile it.
27775 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27776 `span.Seconds' are just seconds, but no minutes or hours.
27777 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27779 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27781 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27782 Remove the gratuitous set of Final:
27784 // If an interface implementation, then we can set Final.
27785 if (((flags & MethodAttributes.Abstract) == 0) &&
27786 implementing.DeclaringType.IsInterface)
27787 flags |= MethodAttributes.Final;
27789 I do not know what I was smoking when I used that.
27792 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27793 step into fixing the name resolution issues for delegates and
27794 unifying the toplevel name resolution.
27796 2002-03-28 Martin Baulig <martin@gnome.org>
27798 * class.cs (Method.Emit): If we have a symbol writer, call its
27799 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27800 tell it about the current method.
27802 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27803 writer that we're going to emit the first byte of IL code for a new
27804 statement (a new source line).
27805 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27806 EmitContext.Mark() before emitting any code.
27808 * location.cs (SymbolDocument): Return null when we're Null.
27810 * statement.cs (Statement): Moved the `Location loc' variable here.
27811 (Statement.EmitBoolExpression): If we have a symbol writer, call
27812 ec.Mark() before emitting any code to tell it that we're at the
27813 beginning of a new statement.
27814 (StatementExpression): Added `Location' argument to the constructor.
27815 (Block): Added public readonly variable `StartLocation' and public
27816 variable `EndLocation'. The latter is to be set using SetEndLocation().
27817 (Block): Added constructor which takes a start and end location.
27818 (Block.SetEndLocation): New method. This sets the end location.
27819 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27820 local variables we create.
27821 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27822 each statement and do also mark the begin and end of the block.
27824 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27825 tell it the current lexer.Location, use Location.Null for the end of the
27827 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27828 current block, set its end location using SetEndLocation().
27829 (statement_expression): StatementExpression constructor now takes the
27830 lexer.Location as additional argument.
27831 (for_statement, declare_local_variables): Likewise.
27832 (declare_local_variables): When creating a new implicit block, use the
27833 new Block constructor and pass it the lexer.Location.
27835 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27837 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27838 members also on the parent interfaces recursively.
27840 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27842 * report.cs: Use new formats, since Gonzalo finished the missing
27845 * expression.cs (Binary.ResolveOperator): added missing operator|
27846 operator& and operator^ for bool/bool.
27848 * cs-parser.jay: CheckDef now takes a Location argument that is
27849 used to report errors more precisly (instead of reporting the end
27850 of a definition, we try to track something which is a lot closer
27851 to the source of the problem).
27853 * cs-tokenizer.cs: Track global token use, so we can properly flag
27854 the use of #define/#undef after the first token has been seen.
27856 Also, rename the reportXXXX to Error_DescriptiveName
27858 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27859 TypeContainer, so that Enum and Interface can use this too.
27861 * class.cs (TypeContainer.LookupInterfaceOrClass,
27862 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27863 `builder' argument. Typically this was used to pass the parent
27864 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27867 The problem is that a nested class could trigger the definition of
27868 a toplevel class, and the builder would be obviously wrong in that
27871 So we drop this argument, and we compute dynamically the
27872 TypeBuilder/ModuleBuilder (the correct information was available
27873 to us anyways from DeclSpace.Parent)
27875 * interface.cs (Interface.DefineInterface): Drop builder
27876 parameter cleanup like class.cs
27878 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27881 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27884 (Try.Emit): Propagate the returns value from the statement.
27886 (Return.Emit): Even if we are leavning
27888 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27890 * modifiers.cs: Fix the computation of MethodAttributes flags.
27892 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27894 * driver.cs: allow compilation of files that start with '/'.
27895 Add a default case when checking the argument of --target.
27897 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27899 * interface.cs: Implement the same search algorithm for types in
27900 the interface code.
27902 * delegate.cs: Do not allow multiple definition.
27904 * Recovered ChangeLog that got accidentally amputated
27906 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27908 * rootcontext.cs: Load manually enum to allow core classes to
27909 contain enumerations.
27911 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27912 Update to new static methods in TypeManager.
27914 * typemanager.cs (GetMethod, GetConstructor): Use our
27915 implementation of FindMembers to find the members, since during
27916 corlib compilation, the types are TypeBuilders and GetMethod and
27917 GetConstructor do not work.
27919 Make all methods in TypeManager static.
27921 (InitCodeHelpers): Split the functionality from
27922 the InitCodeTypes function.
27924 * driver.cs: Call InitCodeHelpers after we have populated the
27927 * cs-parser.jay (delegate_declaration): we did not used to compute
27928 the delegate name correctly for void delegates.
27930 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27932 * rootcontext.cs (RootContext): Init the interface_resolve_order
27933 and type_container_resolve_order always.
27935 (ResolveCore, BootstrapCorlib_ResolveClass,
27936 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27937 compiler when compiling with --nostdlib
27939 * class.cs (TypeContainer.DefineType): Check that our parent is
27940 not null. This test is most important when we are bootstraping
27943 * codegen.cs: Split out the symbol writing code.
27945 2002-03-25 Martin Baulig <martin@gnome.org>
27947 * driver.cs (-g): Made -g an alias for --debug.
27949 2002-03-24 Martin Baulig <martin@gnome.org>
27951 * codegen.cs (SymbolWriter): New public variable. Returns the
27952 current symbol writer.
27953 (CodeGen): Added `bool want_debugging_support' argument to the
27954 constructor. If true, tell the ModuleBuild that we want debugging
27955 support and ask it for the ISymbolWriter.
27956 (Save): If we have a symbol writer, call it's Close() method after
27957 saving the assembly.
27959 * driver.c (--debug): New command line argument to create a
27960 debugger information file.
27962 * location.cs (SymbolDocument): New public property. Returns an
27963 ISymbolDocumentWriter object for the current source file or null
27964 if we don't have a symbol writer.
27966 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27968 * driver.cs (LoadAssembly): Correctly return when all the paths
27969 have been tried and not before.
27971 * statement.cs (Switch.Emit): return the actual coverage for this
27972 statement (returns/not-returns)
27974 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27975 switch of the statement if we are the last switch section. That
27976 kills two problems: try/catch problems (we used to emit an empty
27977 nop at the end) and switch statements where all branches would
27980 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27982 * driver.cs: Add default assemblies (the equivalent to the
27983 Microsoft CSC.RSP file)
27985 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27986 also update tokens_seen and set it to false.
27988 * driver.cs: Implement --recurse for Mike.
27990 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27991 correctly splitting out the paths.
27993 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27995 * interface.cs (Interface.PopulateProperty): Instead of using
27996 `parent' as the declaration space for the set parameters, use
27999 * support.cs (InternalParameters): InternalParameters constructor
28000 takes a DeclSpace instead of a TypeContainer.
28002 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
28003 types are being initialized, load the address of it before calling
28006 (New): Provide a mechanism to disable the generation of local
28007 value type temporaries when the caller will be providing us with
28008 an address to store it.
28010 (ArrayCreation.EmitDynamicInitializers): Use it.
28012 2002-03-17 Miguel de Icaza <miguel@ximian.com>
28014 * expression.cs (Invocation.EmitArguments): Only probe for array
28015 property if there is more than one argument. Sorry about that.
28017 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
28018 empty param arrays.
28020 * class.cs (Method.LabelParameters): Fix incorrect code path that
28021 prevented the `ParamArrayAttribute' from being applied to the
28024 2002-03-16 Miguel de Icaza <miguel@ximian.com>
28026 * support.cs (ReflectionParameters): Correctly compute whether the
28027 last argument is a params array. Fixes the problem with
28030 * typemanager.cs: Make the assemblies array always be non-null
28031 (empty, but non-null)
28033 * tree.cs (RecordDecl): New function that abstracts the recording
28034 of names. This reports error 101, and provides a pointer to the
28035 previous declaration. Fixes a crash in the compiler.
28037 * cs-parser.jay (constructor_declaration): Update to new grammar,
28038 and provide a constructor_body that can be empty.
28040 2002-03-15 Miguel de Icaza <miguel@ximian.com>
28042 * driver.cs: Add support for --resources.
28044 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
28045 Make all types for the various array helper methods be integer.
28047 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
28048 CheckState to ConvCast.
28050 (ConvCast): Now it takes a `checked' state argument, to avoid
28051 depending on the emit context for the conversion, and just using
28052 the resolve time setting.
28054 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
28055 instead of Invocation.EmitArguments. We do not emit the original
28056 arguments, instead we emit those which have been converted to
28057 unsigned int expressions.
28059 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
28061 * codegen.cs: ditto.
28063 * expression.cs (LocalVariableReference): Drop the use of the
28064 Store function that depended on the variable index.
28066 * statement.cs (VariableInfo): Drop the `Idx' property from this
28067 class, as this is not taking into account the indexes for
28068 temporaries tat we generate during the execution, getting the
28071 * class.cs: First emit class initializers, then call the parent
28074 * expression.cs (Binary): Fix opcode emision.
28075 (UnaryMutator.EmitCode): Support checked code generation
28077 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
28078 matches for events for both the Static and Instance scans,
28079 pointing to the same element. Fix that.
28081 2002-03-14 Miguel de Icaza <miguel@ximian.com>
28083 * rootcontext.cs (ResolveTree): Always set the
28084 interface_resolve_order, because nested interfaces will be calling
28087 * class.cs (GetInterfaceOrClass): Track the same resolution
28088 process used by TypeManager.LookupType. This fixes the nested
28089 type lookups in class declarations (separate path from
28092 (TypeContainer.DefineType): Also define nested interfaces.
28093 (TypeContainer.RegisterOrder): New public function used to
28094 register the order in which child interfaces need to be closed.
28096 Nested interfaces need to be closed after their parents have been
28099 * interface.cs (InterfaceAttr): Put all the logic for computing
28100 the interface attribute here.
28102 (DefineInterface): Register our interface order with the
28103 RootContext or with the TypeContainer depending on the case.
28105 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28107 * cs-parser.jay: rework foreach statement to work with the new
28108 changes to the policy on SimpleNames.
28110 * report.cs: support Stacktrace on warnings as well.
28112 * makefile: drop --unsafe and /unsafe from the compile.
28114 2002-03-13 Ravi Pratap <ravi@ximian.com>
28116 * ecore.cs (StandardConversionExists): Modify to take an Expression
28117 as the first parameter. Ensure we do null -> reference type conversion
28120 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
28121 temporary Expression objects.
28123 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
28125 * interface.cs: workaround bug in method overloading resolution
28126 (there is already a bugzilla bug for it).
28128 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28130 We could also solve this problem by having a separate path for
28131 performing type lookups, instead of DoResolve, we could have a
28132 ResolveType entry point, and only participating pieces of the
28133 production (simplename, deref, array) would implement this.
28135 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
28136 signal SimpleName to only resolve type names and not attempt to
28137 resolve anything else.
28139 * expression.cs (Cast): Set the flag.
28141 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
28143 * class.cs: Only report 108 if there is no `new' modifier.
28145 * cs-parser.jay: rework foreach statement to work with the new
28146 changes to the policy on SimpleNames.
28148 * report.cs: support Stacktrace on warnings as well.
28150 * makefile: drop --unsafe and /unsafe from the compile.
28152 2002-03-11 Miguel de Icaza <miguel@ximian.com>
28154 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28155 lookups here, instead of doing that at parse time. This means
28156 that our grammar will not introduce `LocalVariableReferences' as
28157 expressions at this point. That solves the problem of code like
28161 static void Main ()
28165 This is only half the fix. The full fix requires parameters to
28166 also be handled in this way.
28168 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
28169 makes the use more obvious of the DeclSpace. The
28170 ec.TypeContainer.TypeBuilder is now only used to pull the
28171 TypeBuilder for it.
28173 My theory is that I can get rid of the TypeBuilder completely from
28174 the EmitContext, and have typecasts where it is used (from
28175 DeclSpace to where it matters).
28177 The only pending problem is that the code that implements Aliases
28178 is on TypeContainer, and probably should go in DeclSpace.
28180 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28181 lookups here, instead of doing that at parse time. This means
28182 that our grammar will not introduce `LocalVariableReferences' as
28183 expressions at this point. That solves the problem of code like
28187 static void Main ()
28191 This is only half the fix. The full fix requires parameters to
28192 also be handled in this way.
28194 * class.cs (Property.DefineMethod): When implementing an interface
28195 method, set newslot, when implementing an abstract method, do not
28196 set the flag (before we tried never setting it, or always setting
28197 it, which is the difference).
28198 (Indexer.DefineMethod): same.
28199 (Method.DefineMethod): same.
28201 * ecore.cs: Only set the status used flag if we get back a Field.
28203 * attribute.cs: Temporary hack, so Paolo can keep working.
28205 2002-03-08 Ravi Pratap <ravi@ximian.com>
28207 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28208 the unmanaged type in the case we have a MarshalAs attribute.
28210 (Resolve): Handle the case when we are parsing the special MarshalAs
28211 attribute [we need to store the unmanaged type to use later]
28213 * typemanager.cs (marshal_as_attr_type): Built in type for the
28214 MarshalAs Attribute.
28216 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28217 on parameters and accordingly set the marshalling info.
28219 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28221 * class.cs: Optimizing slightly by removing redundant code after
28222 we switched to the `NoTypes' return value.
28223 (Property.DefineMethod): use NoTypes here too.
28225 This fixes the bug I introduced in my last batch of changes.
28227 2002-03-05 Ravi Pratap <ravi@ximian.com>
28229 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28231 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28232 Enums since those are types too.
28234 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28236 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28237 thanks to a call during the lookup process.
28239 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28241 * statement.cs (Foreach): Lots of work to accomodate a particular
28242 kind of foreach statement that I had not kept in mind. It is
28243 possible to have foreachs on classes that provide a GetEnumerator
28244 method that return objects that implement the "pattern" for using
28245 a foreach, there is no need to support GetEnumerator
28248 This is needed to compile nant.
28250 * decl.cs: Only report 114 if the member is not `Finalize' and if
28251 the warning level is at least 2.
28253 * class.cs: Moved the compare function from Method to
28256 (MethodSignature.InheritableMemberSignatureCompare): Add new
28257 filter function that is used to extract inheritable methods from a
28260 (Method.Define): Use the new `inheritable_method_signature_filter'
28263 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28266 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28268 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28270 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28272 * expression.cs: Pass location information to
28273 ConvertImplicitStandard.
28275 * class.cs: Added debugging code to track return values from
28278 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28280 * expression.cs (Is.DoResolve): If either side of the `is' is an
28281 interface, do not flag the warning.
28283 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28286 * report.cs: Allow for --fatal to be used with --probe.
28288 * typemanager.cs (NoTypes): Move the definition for the empty Type
28291 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28293 (TypeContainer.DefineProxy): New function used to proxy to parent
28294 implementations when implementing interfaces.
28295 (TypeContainer.ParentImplements): used to lookup if our parent
28296 implements a public function that is required by an interface.
28297 (TypeContainer.VerifyPendingMethods): Hook this up.
28299 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28300 `modules' and `assemblies' arraylists into arrays. We only grow
28301 these are the very early start up of the program, so this improves
28302 the speedof LookupType (nicely measured).
28304 * expression.cs (MakeByteBlob): Replaced unsafe code with
28305 BitConverter, as suggested by Paolo.
28307 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28308 folding of string concatenation, but if either side is a string,
28309 and the other is not, then return null, and let the runtime use
28310 the concatenation on the string plus the object (using
28311 `Object.ToString').
28313 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28315 Constant Folding has been implemented now.
28317 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28318 the error instead on types that are not supported in one's
28321 * constant.cs (Constant and all children): New set of functions to
28322 perform implict and explicit conversions.
28324 * ecore.cs (EnumConstant): Implement the new functions to perform
28325 conversion by proxying to the child expression.
28327 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28328 own separate setting that can not be turned off from the command
28329 line using --unchecked or --checked and is only controlled using
28330 the checked/unchecked statements and expressions. This setting is
28331 used by the constant folder to flag errors.
28333 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28334 ConstantCheckState as well.
28336 During Resolve, they also have to flag the state, because the
28337 constant folder runs completely in the Resolve phase.
28339 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28342 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28344 * cfold.cs: New file, this file contains the constant folder.
28346 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28347 argument to track whether we are using the resulting address to
28348 load or store a value and provide better error messages.
28350 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28351 new AddressOf arguments.
28353 * statement.cs (Foreach.EmitCollectionForeach): Update
28355 * expression.cs (Argument.Emit): Call AddressOf with proper
28356 arguments to track usage.
28358 (New.DoEmit): Call AddressOf with new arguments.
28360 (Unary.Emit): Adjust AddressOf call.
28362 2002-03-01 Ravi Pratap <ravi@ximian.com>
28364 * cs-parser.jay (member_access): Change the case for pre-defined types
28365 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28368 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28371 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28372 essentially like methods and apply attributes like MethodImplOptions to them too.
28374 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28377 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28378 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28381 * Update code everywhere accordingly.
28383 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28385 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28387 2002-02-28 Ravi Pratap <ravi@ximian.com>
28389 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28390 try performing lookups against those instead of jumping straight into using
28391 the 'using' clauses.
28393 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28395 (LookupType): Perform lookups in implicit parents too.
28397 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28398 sequence as RootContext.LookupType.
28400 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28401 the various cases of namespace lookups into this method.
28403 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28405 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28406 in positional arguments)
28408 * class.cs (Operator): Update the AllowedModifiers to contain
28411 * cs-parser.jay: Update operator declaration to allow for the
28412 operator body to be empty.
28414 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28417 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28419 * class.cs (Method.Emit): Label parameters.
28421 * driver.cs: Return 1 or 0 as the program exit code.
28423 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28425 * expression.cs: Special case the `null' object when trying to
28426 auto-compute the type, as anything can be explicitly converted to
28429 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28430 spotting this Paolo.
28432 (Expression.ImplicitNumericConversion): Perform comparissions of
28433 the type using the underlying type in the case of an enumeration
28434 rather than using the enumeration type for the compare.
28436 Cope with the underlying == type case, which is not possible to
28439 (Expression.ConvertNumericExplicit): Perform comparissions of
28440 the type using the underlying type in the case of an enumeration
28441 rather than using the enumeration type for the compare.
28443 * driver.cs: If the user does not supply an extension, assume .exe
28445 * cs-parser.jay (if_statement): Rewrote so that we can track the
28446 location for the if statement.
28448 * expression.cs (Binary.ConstantFold): Only concat strings when
28449 the operation is "+", not everything ;-)
28451 * statement.cs (Statement.EmitBoolExpression): Take a location
28453 (If, While, Do): Track location.
28455 * expression.cs (Binary.ResolveOperator): In the object + string
28456 case, I was missing a call to ConvertImplicit
28458 2002-02-25 Ravi Pratap <ravi@ximian.com>
28460 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28461 Location arguments. Ensure we use RootContext.LookupType to do our work
28462 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28464 * interface.cs (PopulateMethod): Handle the type of the parameter being
28467 * expression.cs (Invocation.BetterFunction): Handle the case when we
28468 have a params method with no fixed arguments and a call is made with no
28471 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28473 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28474 the verbatim-string-literal
28476 * support.cs (InternalParameters.ParameterModifier): handle null
28478 (InternalParameters.ParameterType): ditto.
28480 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28481 duplicating the name of the variable parameter.
28482 (GetParameterByName): Fix bug where we were not looking up array
28483 paramters if they were the only present (thanks Paolo!).
28484 (GetParameterInfo): We only have an empty set of types if both
28485 fixed and array are set to null.
28486 (GetParameterInfo-idx): Handle FixedParameter == null
28488 * cs-parser.jay: Handle the case where there is no catch
28489 statements (missing null test).
28491 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28493 * driver.cs (MainDriver): Be conservative on our command line
28496 Catch DirectoryNotFoundException when calling GetFiles.
28498 (SplitPathAndPattern): Used to split the input specification into
28499 a path and a pattern that we can feed to Directory.GetFiles.
28501 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28503 * statement.cs (Fixed): Implement the last case of the Fixed
28504 statement (string handling).
28506 * expression.cs (StringPtr): New class used to return a char * to
28507 a string; Used by the Fixed statement.
28509 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28511 * expression.cs (Binary.ResolveOperator): Remove redundant
28512 MemberLookup pn parent type.
28513 Optimize union call, we do not need a union if the types are the same.
28514 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28517 Specialize the use of MemberLookup everywhere, instead of using
28518 the default settings.
28520 (StackAlloc): Implement stackalloc keyword.
28522 * cs-parser.jay: Add rule to parse stackalloc.
28524 * driver.cs: Handle /h, /help, /?
28526 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28527 before we supported unsafe code.
28529 * makefile: add --unsafe to the self compilation of mcs.
28531 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28533 * expression.cs (PointerArithmetic): New class that is used to
28534 perform pointer arithmetic.
28535 (Binary.Resolve): Handle pointer arithmetic
28536 Handle pointer comparission.
28537 (ArrayPtr): Utility expression class that is used to take the
28538 address of an array.
28540 (ElementAccess): Implement array access for pointers
28542 * statement.cs (Fixed): Implement fixed statement for arrays, we
28543 are missing one more case before we are done.
28545 * expression.cs (Indirection): Implement EmitAssign and set the
28546 ExprClass to Variable. This allows pointer dereferences to be
28547 treated as variables, and to have values assigned to them.
28549 * ecore.cs (Expression.StoreFromPtr): New utility function to
28550 store values dereferencing.
28552 2002-02-20 Ravi Pratap <ravi@ximian.com>
28554 * expression.cs (Binary.ResolveOperator): Ensure that we are
28555 not trying to operate on a void type - this fixes the reported
28558 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28559 the parent implementation is sealed.
28561 * ../errors/cs0239.cs : Add.
28563 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28565 * typemanager.cs (unverifiable_code_type): Corresponds to
28566 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28567 which have unsafe code in them.
28569 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28572 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28574 * cs-tokenizer.cs: Add support for @"litreal strings"
28576 Make tokenizer accept pre-processor directives
28577 on any column (remove the old C-like limitation).
28579 * rootcontext.cs (EmitCode): Emit any global attributes.
28580 (AddGlobalAttributes): Used to keep track of assembly attributes.
28582 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28584 * cs-parser.jay: Add support for global attributes.
28586 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28588 * expression.cs (Indirection): New helper class. Unary will
28589 create Indirection classes to be able to implement the
28590 IMemoryLocation interface on it.
28592 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28594 * cs-parser.jay (fixed_statement): reference the right statement.
28596 * statement.cs (Fixed.Emit): Finish implementing the fixed
28597 statement for the &x case.
28599 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28601 * class.cs (Property.Define, Method.Define): Remove newslot when
28604 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28605 wrong. NewSlot should only be used if the `new' keyword is present.
28607 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28608 locating our system dir. Sorry about this.
28610 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28612 * driver.cs (GetSystemDir): Compute correctly the location of our
28613 system assemblies. I was using the compiler directory instead of
28614 the library directory.
28616 2002-02-13 Ravi Pratap <ravi@ximian.com>
28618 * expression.cs (BetterFunction): Put back in what Miguel commented out
28619 since it is the correct fix. The problem is elsewhere ;-)
28621 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28622 parameters of the parms method are themselves compatible or not !
28624 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28625 to check that a class implements an interface before saying that an implicit
28626 conversion was allowed. Use ImplementsInterface to do the checking.
28628 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28630 * class.cs (Method.Define): Track whether we are an explicit
28631 implementation or not. And only call DefineMethodOverride if we
28632 are an explicit implementation.
28634 (Property.DefineMethod): Ditto.
28636 2002-02-11 Ravi Pratap <ravi@ximian.com>
28638 * expression.cs (BetterFunction): Catch hideous bug which was
28639 preventing us from detecting ambiguous calls due to implicit casts i.e
28642 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28644 * support.cs (Pair): Remove un-needed method. I figured why I was
28645 getting the error in cs-parser.jay, the variable in a foreach loop
28646 is readonly, and the compiler does not really treat this as a variable.
28648 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28649 instead of EQUALS in grammar.
28651 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28653 * expression.cs (Unary.DoResolve): Check whether the argument is
28656 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28658 * support.cs: Api for Pair to set a value. Despite the fact that
28659 the variables are public the MS C# compiler refuses to compile
28660 code that accesses the field if the variable is part of a foreach
28663 * statement.cs (Fixed): Begin implementation of the fixed
28666 (Block.AddVariable): Return the VariableInfo on success and null
28667 on failure instead of true/false.
28669 * cs-parser.jay (foreach): Catch errors on variables already
28670 defined (we were ignoring this value before) and properly unwind
28671 the block hierarchy
28673 (fixed_statement): grammar for the fixed statement.
28675 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28677 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28678 pointer types to be incretemented.
28680 (SizeOf): Implement.
28682 * cs-parser.jay (pointer_member_access): Implement
28683 expr->IDENTIFIER production.
28685 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28686 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28689 (Unary): Implement indirection.
28691 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28692 use in non-unsafe context).
28694 (SimpleName.DoResolve): Check for pointers in field access on safe
28697 (Expression.LoadFromPtr): Factor the load-indirect code in this
28698 function. This was duplicated in UnboxCast and ParameterReference
28700 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28702 * expression.cs (ComposedCast): report an error if a pointer cast
28703 is used in a safe region.
28705 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28706 pointer type casts in unsafe context.
28708 * codegen.cs (EmitContext): Set up IsUnsafe.
28710 * cs-parser.jay (non_expression_type): Add productions for pointer
28713 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28714 code. We should not use force into static mode if the method is
28715 not virtual. Fixes bug in MIS
28717 * statement.cs (Do.Emit, While.Emit, For.Emit,
28718 Statement.EmitBoolExpression): Add support to Do and While to
28719 propagate infinite loop as `I do return' semantics.
28721 Improve the For case to also test for boolean constants.
28723 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28724 to the list of attributes we can add.
28726 Remove `EmitContext' argument.
28728 * class.cs (Method.Define): Apply parameter attributes.
28729 (Constructor.Define): Apply parameter attributes.
28730 (MethodCore.LabelParameters): Move here the core of labeling
28733 * support.cs (ReflectionParameters.ParameterModifier,
28734 InternalParameters.ParameterModifier): Use IsByRef on the type and
28735 only return the OUT bit for these parameters instead of in/out/ref
28738 This is because I miss-understood things. The ParameterInfo.IsIn
28739 and IsOut represent whether the parameter has the [In] and [Out]
28742 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28744 * ecore.cs (FieldExpr.Emit): Release temporaries.
28746 * assign.cs (LocalTemporary.Release): new function.
28748 * codegen.cs (EmitContext.GetTemporaryStorage,
28749 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28750 temporary storage. Now we can "put back" localbuilders when we
28753 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28755 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28756 need to make a copy of the variable to generate verifiable code.
28758 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28760 * driver.cs: Compute dynamically the system directory.
28762 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28763 Slower, but more generally useful. Used by the abstract
28764 registering implementation.
28766 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28767 the rules for the special rule on Type/instances. First check if
28768 we have the same name, and if so, try that special static path
28769 rather than the instance path.
28771 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28773 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28776 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28777 Enum, ValueType, Delegate or Array for non-corlib compiles.
28779 * cs-tokenizer.cs: Catch long identifiers (645)
28781 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28784 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28785 fix, we were returning too early, so we were not registering
28786 pending methods from abstract classes.
28788 Do not register pending methods if the class is abstract.
28790 * expression.cs (Conditional.DoResolve): Report circular implicit
28791 conversions when we neecd to compute it for conditional
28794 (Is.DoResolve): If the expression is always of the provided type,
28795 flag warning 183. If the expression can not ever be of the
28796 provided type flag warning 184.
28798 * class.cs: Catch 169 as well.
28800 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28803 2002-01-18 Nick Drochak <ndrochak@gol.com>
28805 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28807 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28809 * interface.cs: (PopulateMethod): Check for pointers being defined
28810 only if the unsafe context is active.
28811 (PopulateProperty): ditto.
28812 (PopulateIndexer): ditto.
28814 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28815 specified. If pointers are present, make sure that they are
28816 present in an unsafe context.
28817 (Constructor, Constructor.Define): ditto.
28818 (Field, Field.Define): ditto.
28819 (Property, Property.Define): ditto.
28820 (Event, Event.Define): ditto.
28822 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28823 hashtable if there are classes or structs defined.
28825 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28826 code, as the constant resolution moved.
28828 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28829 the metadata, so we can flag error 133.
28831 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28832 pointer is being declared in an unsafe context.
28834 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28836 * modifiers.cs (Modifiers.Check): Require a Location argument.
28837 Report error 227 for Unsafe use.
28839 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28841 * statement.cs (For.Emit): If the test is null, then report that
28842 we do `return', as we wont reach anything afterwards.
28844 (Switch.SwitchGoverningType): Track the expression that matched
28847 * driver.cs: Allow negative numbers as an error code to flag.
28849 * cs-parser.jay: Handle 1551.
28851 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28853 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28855 * cs-parser.jay: Report 1518 (type declaration can only contain
28856 class, struct, interface, enum or delegate)
28858 (switch_label): Report 1523 (keywords `case' or `default' must
28861 (opt_switch_sections): Report 1522 (empty switch)
28863 * driver.cs: Report 1515 (response file specified multiple times)
28864 Report 1516 (Source file specified multiple times).
28866 * expression.cs (Argument.Resolve): Signal 1510
28868 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28869 access not allowed in static code)
28871 2002-01-11 Ravi Pratap <ravi@ximian.com>
28873 * typemanager.cs (IsPointerType): Utility method which we are going
28876 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28877 the object type, so we take care of that.
28879 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28881 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28882 added to non-params parameters :-)
28884 * typemanager.cs (CSharpName): Include 'void' type too.
28886 (void_ptr_type): Include in the set of core types.
28888 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28891 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28894 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28895 completely forgotten about it.
28897 2002-01-10 Ravi Pratap <ravi@ximian.com>
28899 * cs-parser.jay (pointer_type): Add. This begins our implementation
28900 of parsing rules for unsafe code.
28902 (unsafe_statement): Implement.
28904 (embedded_statement): Modify to include the above.
28906 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28908 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28909 if the current context is an unsafe one.
28911 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28912 are handled differently, we need separate rules for them.
28914 (local_variable_declaration): Update to use local_variable_pointer_type
28915 to allow variable declarations of unmanaged pointer types.
28917 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28918 in unsafe contexts.
28920 * ../errors/cs0214.cs : Add.
28922 2002-01-16 Nick Drochak <ndrochak@gol.com>
28924 * makefile: remove 'response' file when cleaning.
28926 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28928 * cs-parser.jay: Report 1524.
28930 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28932 * typemanager.cs (RegisterMethod): drop checking if we have
28933 registered this from here
28935 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28937 * class.cs (Method.EmitDestructor): Implement calling our base
28940 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28941 value of InFinally.
28943 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28944 this routine and will wrap the call in a try/catch block. Deal
28947 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28949 * ecore.cs (Expression.MemberLookup): instead of taking a
28950 parameter `same_type' that was used to tell whether we could
28951 access private members we compute our containing type from the
28954 (FieldExpr): Added partial support for volatile fields. This does
28955 not work for volatile fields exposed from assemblies, as I can not
28956 figure out how to extract the modreq from it.
28958 Updated all the source files to use this.
28960 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28961 because it is referenced by MemberLookup very often.
28963 2002-01-09 Ravi Pratap <ravi@ximian.com>
28965 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28966 TypeBuilder.GetCustomAttributes to retrieve what we need.
28968 Get rid of redundant default_member_attr_type as this is the same as
28969 default_member_type which already exists.
28971 * interface.cs, attribute.cs : Update accordingly.
28973 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28975 * typemanager.cs: Enable IndexerPropertyName again. It does not
28976 work for TYpeBuilders though. Ravi, can you please fix this?
28978 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28980 * expression.cs (Argument.Emit): Handle the case of ref objects
28981 being passed to ref functions;
28983 (ParameterReference.EmitLoad): Loads the content of the pointer
28984 without dereferencing.
28986 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28988 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28990 2002-01-08 Ravi Pratap <ravi@ximian.com>
28992 * class.cs (Indexer.DefineMethod): Incorporate the interface
28993 type in the name of the method if we are doing explicit interface
28996 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28998 (BetterConversion): Fix extremely trivial bug where we were referring to
28999 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
29002 * ../errors/bug16.cs : Add although we have fixed it.
29004 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29006 * expression.cs (BaseIndexer): Begin implementation.
29008 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
29010 * cs-parser.jay (indexer_declarator): Use qualified_identifier
29011 production directly to remove a shift/reduce, and implement
29012 explicit interface implementation.
29014 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
29015 after a floating point suffix.
29017 * expression.cs (DoNumericPromotions): Improved the conversion for
29018 uint/uint. If we have a constant, we avoid doing a typecast to a
29021 * class.cs (Indexer): Implement explicit interface implementation
29024 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
29026 * class.cs: make the default instance constructor public and hidebysig.
29028 2001-01-03 Ravi Pratap <ravi@ximian.com>
29030 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
29031 so we can call it from elsewhere.
29033 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
29034 we emit it internally if the class has a defined indexer; otherwise the user
29035 emits it by decorating the class definition with the DefaultMemberAttribute.
29037 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
29038 attribute is not used on a type which defines an indexer.
29040 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
29041 character when we skip whitespace.
29043 * ../errors/cs0646.cs : Add.
29045 2002-01-03 Miguel de Icaza <miguel@ximian.com>
29047 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
29050 * makefile: Add practical target `mcs3.exe' which builds the third
29051 generation compiler.
29053 * expression.cs (New): Fix structures constructor calling.
29055 * class.cs (Property, Method, Indexer): Emit Final flag on the
29056 method if we are an interface implementation and we are not
29059 * ecore.cs (PropertyExpr): New public field `IsBase', tells
29060 whether this property is referencing a `base' method.
29062 * expression.cs (Invocation.EmitCall): take an extra argument:
29063 is_base, this is used to determine whether the `call' or
29064 `callvirt' opcode should be used.
29067 * delegate.cs: update EmitCall.
29069 * class.cs (Method.Define): Set NewSlot for the cases where we are
29070 not implementing an interface method.
29072 (Property.Define): ditto.
29074 2002-01-02 Miguel de Icaza <miguel@ximian.com>
29076 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
29077 'r'. Allows mcs to parse itself fully.
29079 2002-01-02 Ravi Pratap <ravi@ximian.com>
29081 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
29082 of the number of initializers that require the InitializeArray method.
29084 (CheckIndices): Store the Expression in all cases - not the plain value. Also
29085 update the above field where necessary.
29087 (MakeByteBlob): Update accordingly.
29089 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
29092 (EmitDynamicInitializers): Update in accordance with the new optimization.
29094 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
29095 same OpCode applies.
29097 * cs-parser.jay : Fix some glaring errors I introduced.
29099 2002-01-01 Ravi Pratap <ravi@ximian.com>
29101 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
29102 so that we can check for name clashes there too.
29104 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
29105 for interface indexers.
29107 * interfaces.cs (Define): Emit the default member attribute.
29109 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
29110 variable was being referred to while setting the value ;-)
29112 2002-01-01 Miguel de Icaza <miguel@ximian.com>
29114 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
29115 byte-by-byte information when we know the data is zero.
29117 Make the block always a multiple of 4, because
29118 DefineInitializedData has a bug.
29120 * assign.cs: Fix, we should assign from the temporary, not from
29123 * expression.cs (MakeByteBlob): Fix my incorrect code.
29125 2001-12-31 Miguel de Icaza <miguel@ximian.com>
29127 * typemanager.cs (EnumToUnderlying): This function is used to get
29128 the underlying type from an enumeration, because it does not
29131 * constant.cs: Use the I4_S form for values between -128 and 127.
29133 * statement.cs (Block.LookupLabel): Looks up a label.
29134 (Block): Drop support for labeled blocks.
29136 (LabeledStatement): New kind of statement that represents a label
29139 (Goto): Finally implement this bad boy.
29141 * cs-parser.jay: Update to reflect new mechanism to implement
29144 2001-12-30 Miguel de Icaza <miguel@ximian.com>
29146 * codegen.cs (EmitContext.This): a codegen property that keeps the
29147 a single instance of this instead of creating many different this
29150 * delegate.cs (Delegate.DoResolve): Update to use the property;
29152 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
29154 * expression.cs (BaseAccess.DoResolve): Ditto.
29156 2001-12-29 Ravi Pratap <ravi@ximian.com>
29158 * typemanager.cs (methodimpl_attr_type): Add to hold the type
29159 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
29161 (InitCoreTypes): Update accordingly.
29163 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
29164 so we can quickly store the state.
29166 (ApplyAttributes): Set the correct implementation flags
29167 for InternalCall methods.
29169 2001-12-29 Miguel de Icaza <miguel@ximian.com>
29171 * expression.cs (EmitCall): if a method is not virtual, then do
29172 not use callvirt on it.
29174 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
29175 user defined stuff) requires the use of stobj, which takes an
29176 address on the stack instead of an array and an index. So emit
29177 the Ldelema operation for it.
29179 (EmitStoreOpcode): Use stobj for valuetypes.
29181 (UnaryMutator.EmitCode): Use the right 1 value depending on
29182 whether we are dealing with int64/uint64, float or doubles.
29184 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29185 constructors that I implemented last night.
29187 (Constructor.IsDefault): Fix to work properly for static
29190 * cs-parser.jay (CheckDef): report method signature errors.
29191 Update error number 103 to be 132.
29193 * decl.cs: New AdditionResult enumeration value: MethodExists.
29194 Although we do this check for methods later on in the semantic
29195 analysis, catching repeated default constructors is so easy that
29196 we catch these here.
29198 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29201 (ParameterReference.EmitAssign, Emit): handle
29204 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29205 (ArrayAccess.EmitStoreOpcode): ditto.
29207 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29209 * expression.cs (MakeByteBlob): Complete all the missing types
29210 (uint, short, ushort, byte, sbyte)
29212 * class.cs: Only init instance field initializers on instance
29215 Rename `constructors' to instance_constructors.
29217 (TypeContainer.AddConstructor): Only add constructors to the list
29218 if it is not static.
29220 Make sure that we handle default_static_constructor independently
29221 everywhere where we handle instance_constructors
29223 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29225 * class.cs: Do not lookup or create a base initializer for a
29226 static constructor.
29228 (ConstructorInitializer.Resolve): use the proper type to lookup
29231 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29233 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29236 * decl.cs: CloseType is now an virtual method, the default
29237 implementation just closes this type.
29239 2001-12-28 Ravi Pratap <ravi@ximian.com>
29241 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29242 to PreserveSig by default. Also emit HideBySig on such methods.
29244 Basically, set the defaults to standard values.
29246 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29247 argument, if candidate is better, it can't be worse than the best !
29249 (Invocation): Re-write bits to differentiate between methods being
29250 applicable in their expanded form and their normal form - for params
29253 Get rid of use_standard everywhere as only standard conversions are allowed
29254 in overload resolution.
29256 More spec conformance.
29258 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29260 * driver.cs: Add --timestamp, to see where the compiler spends
29263 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29264 `this' in static code.
29266 (SimpleName.DoResolve): Implement in terms of a helper function
29267 that allows static-references to be passed upstream to
29270 (Expression.ResolveWithSimpleName): Resolve specially simple
29271 names when called by MemberAccess to implement the special
29274 (Expression.ImplicitReferenceConversion): Handle conversions from
29275 Null to reference types before others, as Null's type is
29278 * expression.cs (Invocation.EmitCall): Handle the special case of
29279 calling methods declared on a reference type from a ValueType
29280 (Base classes System.Object and System.Enum)
29282 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29283 the left hand side is a TypeExpr, not on every enumeration.
29285 (Binary.Resolve): If types are reference types, then do a cast to
29286 object on operators != and == of both arguments.
29288 * typemanager.cs (FindMembers): Extract instance and static
29289 members if requested.
29291 * interface.cs (PopulateProperty): Use void_type instead of null
29292 as the return type for the setter method.
29294 (PopulateIndexer): ditto.
29296 2001-12-27 Ravi Pratap <ravi@ximian.com>
29298 * support.cs (ReflectionParameters): Fix minor bug where we
29299 were examining the wrong parameter for the ParamArray attribute.
29301 Cope with requests for the type of the parameter at position
29302 greater than the params parameter's. We now return the element
29303 type of the params array as that makes more sense.
29305 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29306 accordingly as we no longer have to extract the element type
29309 (Invocation.OverloadResolve): Update.
29311 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29313 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29314 against IEnumerator, test whether the return value is a descendant
29315 of the IEnumerator interface.
29317 * class.cs (Indexer.Define): Use an auxiliary method to implement
29318 the other bits of the method definition. Begin support for
29319 explicit interface implementation.
29321 (Property.DefineMethod): Use TypeManager.void_type instead of null
29322 for an empty return value.
29324 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29326 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29327 dealing with a FieldExpr which is composed of a FieldBuilder, in
29328 the code path we did extract the constant, but we should have
29329 obtained the underlying value to be able to cast it (otherwise we
29330 end up in an infinite loop, this is what Ravi was running into).
29332 (ArrayCreation.UpdateIndices): Arrays might be empty.
29334 (MemberAccess.ResolveMemberAccess): Add support for section
29335 14.5.4.1 that deals with the special case of E.I when E is a type
29336 and something else, that I can be a reference to a static member.
29338 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29339 handle a particular array type to create byte blobs, it is just
29340 something we dont generate byteblobs for.
29342 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29345 * location.cs (Push): remove the key from the hashtable that we
29346 are about to add. This happens for empty files.
29348 * driver.cs: Dispose files after we have parsed them.
29350 (tokenize): new function that only runs the tokenizer on its
29351 input, for speed testing.
29353 2001-12-26 Ravi Pratap <ravi@ximian.com>
29355 * class.cs (Event.Define): Define the private field only if there
29356 are no accessors defined.
29358 * expression.cs (ResolveMemberAccess): If there is no associated
29359 field with the event, that means we have an event defined with its
29360 own accessors and we should flag error cs0070 since transforming
29361 ourselves into a field is not valid in that case.
29363 * ecore.cs (SimpleName.DoResolve): Same as above.
29365 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29366 and charset to sane values.
29368 2001-12-25 Ravi Pratap <ravi@ximian.com>
29370 * assign.cs (DoResolve): Perform check on events only if they
29371 are being accessed outside the declaring type.
29373 * cs-parser.jay (event_declarations): Update rules to correctly
29374 set the type of the implicit parameter etc.
29376 (add_accessor, remove_accessor): Set current local parameters.
29378 * expression.cs (Binary): For delegate addition and subtraction,
29379 cast the return value from the method into the appropriate delegate
29382 2001-12-24 Ravi Pratap <ravi@ximian.com>
29384 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29385 of these as the workaround is unnecessary.
29387 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29388 delegate data - none of that is needed at all.
29390 Re-write bits to extract the instance expression and the delegate method
29393 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29396 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29397 of attaching attributes instead of duplicating code everywhere.
29399 * everywhere : Update code to do attribute emission using the above method.
29401 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29403 * expression.cs (IsParamsMethodApplicable): if there are not
29404 parameters, return immediately.
29406 * ecore.cs: The 0 literal can be implicity converted to an enum
29409 (SimpleName.DoResolve): First lookup the type, then lookup the
29412 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29413 want to get its address. If the InstanceExpression is not
29414 addressable, store the result in a temporary variable, then get
29417 * codegen.cs: Only display 219 errors on warning level or above.
29419 * expression.cs (ArrayAccess): Make it implement the
29420 IMemoryLocation interface.
29422 (Binary.DoResolve): handle the operator == (object a, object b)
29423 and operator != (object a, object b) without incurring into a
29424 BoxedCast (because 5 != o should never be performed).
29426 Handle binary enumerator operators.
29428 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29429 value type, otherwise use Ldelem_ref.
29431 Use precomputed names;
29433 (AddressOf): Implement address of
29435 * cs-parser.jay (labeled_statement): Fix recursive block
29436 addition by reworking the production.
29438 * expression.cs (New.DoEmit): New has a special case:
29440 If we are dealing with a ValueType, we have a few
29441 situations to deal with:
29443 * The target of New is a ValueType variable, that is
29444 easy, we just pass this as the variable reference
29446 * The target of New is being passed as an argument,
29447 to a boxing operation or a function that takes a
29450 In this case, we need to create a temporary variable
29451 that is the argument of New.
29454 2001-12-23 Ravi Pratap <ravi@ximian.com>
29456 * rootcontext.cs (LookupType): Check that current_type is not null before
29457 going about looking at nested types.
29459 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29460 not implement the IAssignMethod interface any more.
29462 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29463 where we tranform them into FieldExprs if they are being resolved from within
29464 the declaring type.
29466 * ecore.cs (SimpleName.DoResolve): Do the same here.
29468 * assign.cs (DoResolve, Emit): Clean up code considerably.
29470 * ../errors/bug10.cs : Add.
29472 * ../errors/cs0070.cs : Add.
29474 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29476 * assign.cs : Get rid of EventIsLocal everywhere.
29478 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29480 * ecore.cs (ConvertIntLiteral): finished the implementation.
29482 * statement.cs (SwitchLabel): Convert the value we are using as a
29483 key before looking up the table.
29485 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29487 * codegen.cs (EmitTopBlock): Require a Location argument now.
29489 * cs-parser.jay (constructor_declarator): We need to setup
29490 current_local_parameters before we parse the
29491 opt_constructor_initializer, to allow the variables to be bound
29492 to the constructor arguments.
29494 * rootcontext.cs (LookupType): First lookup nested classes in our
29495 class and our parents before we go looking outside our class.
29497 * expression.cs (ConstantFold): Extract/debox the values at the
29500 * rootcontext.cs (EmitCode): Resolve the constants first before we
29501 resolve the types. This is not really needed, but it helps debugging.
29503 * statement.cs: report location.
29505 * cs-parser.jay: pass location to throw statement.
29507 * driver.cs: Small bug fix.
29509 * report.cs: Updated format to be 4-zero filled digits.
29511 2001-12-22 Ravi Pratap <ravi@ximian.com>
29513 * expression.cs (CheckIndices): Fix minor bug where the wrong
29514 variable was being referred to ;-)
29516 (DoEmit): Do not call EmitStaticInitializers when the
29517 underlying type is System.Object.
29519 2001-12-21 Ravi Pratap <ravi@ximian.com>
29521 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29522 and do the usual workaround for SRE.
29524 * class.cs (MyEventBuilder.EventType): New member to get at the type
29525 of the event, quickly.
29527 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29529 * assign.cs (Assign.DoResolve): Handle the case when the target
29530 is an EventExpr and perform the necessary checks.
29532 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29535 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29537 (EventExpr): Set the type in the constructor itself since we
29538 are meant to be born fully resolved.
29540 (EventExpr.Define): Revert code I wrote earlier.
29542 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29543 instance expression is null. The instance expression is a This in that case
29544 or a null, depending on whether it is a static method or not.
29546 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29547 refers to more than one method.
29549 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29550 and accordingly flag errors.
29552 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29554 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29556 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29558 * location.cs (ToString): Provide useful rutine.
29560 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29562 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29563 objects, return the actual integral boxed.
29565 * statement.cs (SwitchLabel): define an ILLabel for each
29568 (Switch.CheckSwitch): If the value is a Literal, extract
29569 the underlying literal.
29571 Also in the unused hashtable we had, add the SwitchLabel so we can
29572 quickly look this value up.
29574 * constant.cs: Implement a bunch of new constants. Rewrite
29575 Literal based on this. Made changes everywhere to adapt to this.
29577 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29578 dereferencing array only once, and also copes with enumrations.
29580 bytes are two bytes wide, not one.
29582 (Cast): Perform constant conversions.
29584 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29585 wrappers to the literals here.
29587 * expression.cs (DoNumericPromotions): long literals can converted
29588 to ulong implicity (this is taken care of elsewhere, but I was
29589 missing this spot).
29591 * ecore.cs (Expression.Literalize): Make the return type Literal,
29592 to improve type checking.
29594 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29596 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29598 * literal.cs: Revert code from ravi that checked the bounds. The
29599 bounds are sane by the definition of the type itself.
29601 * typemanager.cs: Fix implementation of ImplementsInterface. We
29602 need to actually look up in our parent hierarchy for interfaces
29605 * const.cs: Use the underlying type for enumerations
29607 * delegate.cs: Compute the basename for the delegate creation,
29608 that should fix the delegate test case, and restore the correct
29609 Type Lookup semantics in rootcontext
29611 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29612 referencing a nested type with the Reflection API is using the "+"
29615 * cs-parser.jay: Do not require EOF token at the end.
29617 2001-12-20 Ravi Pratap <ravi@ximian.com>
29619 * rootcontext.cs (LookupType): Concatenate type names with
29620 a '.' instead of a '+' The test suite passes again.
29622 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29623 field of the enumeration.
29625 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29626 the case when the member is an EventExpr.
29628 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29629 static has an associated instance expression.
29631 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29633 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29635 * class.cs (Event.Define): Register event and perform appropriate checks
29638 We define the Add and Remove methods even if the use provides none because
29639 in that case, we provide default implementations ourselves.
29641 Define a private field of the type of the event. This is done by the CSC compiler
29642 and we should be doing it too ;-)
29644 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29645 More methods we use in code we generate.
29647 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29650 (InitCoreTypes): Update accordingly for the above.
29652 * class.cs (Event.Emit): Generate code for default accessors that we provide
29654 (EmitDefaultMethod): Do the job in the above.
29656 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29659 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29661 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29662 builders even if we were missing one.
29664 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29665 pass the Basename as our class name instead of the Name. The
29666 basename will be correctly composed for us.
29668 * parameter.cs (Paramters): Now takes a Location argument.
29670 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29671 make all the code call directly LookupType in RootContext and take
29672 this chance to pass the Location information everywhere.
29674 * Everywhere: pass Location information.
29676 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29678 * class.cs (Constructor.Define): Updated way of detecting the
29679 length of the parameters.
29681 (TypeContainer.DefineType): Use basename as the type name for
29684 (TypeContainer.Define): Do not recursively define types here, as
29685 definition is taken care in order by the RootContext.
29687 * tree.cs: Keep track of namespaces in a per-file basis.
29689 * parameter.cs (Parameter.ComputeSignature): Update to use
29692 (Parameters.GetSignature): ditto.
29694 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29695 instead of a TypeContainer.
29697 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29698 resolve names. Because we need to be resolve in our context, not
29701 * driver.cs: Implement response files.
29703 * class.cs (TypeContainer.DefineType): If we are defined, do not
29704 redefine ourselves.
29706 (Event.Emit): Emit the code for add/remove handlers.
29707 (Event.Define): Save the MethodBuilders for add/remove.
29709 * typemanager.cs: Use pair here too.
29711 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29712 DictionaryEntry requires the first argument to be non-null.
29714 (enum_declaration): Compute full name for registering the
29717 (delegate_declaration): Instead of using
29718 formal_parameter_list, use opt_formal_parameter_list as the list
29721 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29722 (EventParsing): New property that controls whether `add' and
29723 `remove' are returned as tokens or identifiers (for events);
29725 2001-12-19 Ravi Pratap <ravi@ximian.com>
29727 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29728 use MyEventBuilder only and let it wrap the real builder for us.
29730 (MyEventBuilder): Revamp constructor etc.
29732 Implement all operations that we perform on EventBuilder in precisely the same
29735 (FindMembers): Update to use the EventBuilder member.
29737 (Event.Emit): Update accordingly.
29739 2001-12-18 Ravi Pratap <ravi@ximian.com>
29741 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29742 by calling the appropriate methods.
29744 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29747 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29749 2001-12-17 Ravi Pratap <ravi@ximian.com>
29751 * delegate.cs (Delegate.Populate): Check that the return type
29752 and various parameters types are indeed accessible.
29754 * class.cs (Constructor.Define): Same here.
29756 (Field.Define): Ditto.
29758 (Event.Define): Ditto.
29760 (Operator.Define): Check that the underlying Method defined itself
29761 correctly - so it's MethodBuilder should not be null.
29763 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29764 expression happens to be null.
29766 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29767 members but as of now we don't seem to be able to do anything really useful with it.
29769 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29770 not the EventBuilder.
29772 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29774 * cs-tokenizer.cs: Add support for defines.
29775 Add support for #if, #elif, #else, #endif
29777 (eval_var): evaluates a variable.
29778 (eval): stubbed for evaluating functions.
29780 * cs-parser.jay: Pass the defines information
29782 * driver.cs: Add --define command line option.
29784 * decl.cs: Move MemberCore here.
29786 Make it the base class for DeclSpace. This allows us to catch and
29787 report 108 and 109 for everything now.
29789 * class.cs (TypeContainer.Define): Extract all the members
29790 before populating and emit the warning 108 (new keyword required
29791 to override) instead of having each member implement this.
29793 (MemberCore.Define): New abstract method, we will be using this in
29794 the warning reporting engine in Populate.
29796 (Operator.Define): Adjust to new MemberCore protocol.
29798 * const.cs (Const): This does not derive from Expression, it is a
29799 temporary object we use to create fields, it is a MemberCore.
29801 * class.cs (Method.Define): Allow the entry point to be in a
29804 * driver.cs: Rewrite the argument handler to clean it up a bit.
29806 * rootcontext.cs: Made it just an auxiliary namespace feature by
29807 making everything static.
29809 * driver.cs: Adapt code to use RootContext type name instead of
29812 * delegate.cs: Remove RootContext argument.
29814 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29817 * class.cs (Event.Define): The lookup can fail.
29819 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29821 * expression.cs: Resolve the this instance before invoking the code.
29823 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29825 * cs-parser.jay: Add a production in element_access that allows
29826 the thing to become a "type" reference. This way we can parse
29827 things like "(string [])" as a type.
29829 Note that this still does not handle the more complex rules of
29833 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29835 * ecore.cs: (CopyNewMethods): new utility function used to
29836 assemble the list of methods from running FindMembers.
29838 (MemberLookup): Rework FindMembers so that
29840 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29842 * class.cs (TypeContainer): Remove Delegates who fail to be
29845 * delegate.cs (Populate): Verify that we dont get null return
29846 values. TODO: Check for AsAccessible.
29848 * cs-parser.jay: Use basename to emit error 574 (destructor should
29849 have the same name as container class), not the full name.
29851 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29852 possible representation.
29854 Also implements integer type suffixes U and L.
29856 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29858 * expression.cs (ArrayCreation.DoResolve): We need to do the
29859 argument resolution *always*.
29861 * decl.cs: Make this hold the namespace. Hold the root context as
29863 (LookupType): Move here.
29865 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29867 * location.cs (Row, Name): Fixed the code, it was always returning
29868 references to the first file.
29870 * interface.cs: Register properties defined through interfaces.
29872 * driver.cs: Add support for globbing on the command line
29874 * class.cs (Field): Make it derive from MemberCore as well.
29877 2001-12-15 Ravi Pratap <ravi@ximian.com>
29879 * class.cs (Event::Define): Check that the type of the event is a delegate
29880 type else flag error #66.
29882 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29885 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29886 values of EntryPoint, CharSet etc etc.
29888 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29890 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29891 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29892 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29893 which needs this to do its work.
29895 * ../errors/cs0066.cs : Add.
29897 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29899 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29902 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29903 clears out the parameters field.
29904 (MemberSignatureCompare): Cleanup
29906 (MemberCore): New base class used to share code between MethodCore
29909 (RegisterRequiredImplementations) BindingFlags.Public requires
29910 either BindingFlags.Instace or Static. Use instance here.
29912 (Property): Refactored code to cope better with the full spec.
29914 * parameter.cs (GetParameterInfo): Return an empty array instead
29917 * class.cs (Property): Abstract or extern properties have no bodies.
29919 * parameter.cs (GetParameterInfo): return a zero-sized array.
29921 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29922 method modifier validation to the typecontainer so we can reuse
29923 this on properties.
29925 (MethodCore.ParameterTypes): return an empty sized array of types.
29927 (Property.Define): Test property modifier validity.
29929 Add tests for sealed/override too.
29931 (Method.Emit): abstract or extern methods have no bodies.
29933 2001-12-14 Ravi Pratap <ravi@ximian.com>
29935 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29938 (Method::Define, ::Emit): Modify accordingly.
29940 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29942 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29944 * makefile: Pass in /unsafe.
29946 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29948 * class.cs (MakeKey): Kill routine.
29950 * class.cs (TypeContainer.Define): Correctly define explicit
29951 method implementations (they require the full interface name plus
29954 * typemanager.cs: Deply the PtrHashtable here and stop using the
29955 lame keys. Things work so much better.
29957 This of course broke everyone who depended on `RegisterMethod' to
29958 do the `test for existance' test. This has to be done elsewhere.
29960 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29961 the object stupid Equals method (because, that like fails all over
29962 the place). We still do not use it.
29964 * class.cs (TypeContainer.SetRequiredInterface,
29965 TypeContainer.RequireMethods): Killed these two routines and moved
29966 all the functionality to RegisterRequiredImplementations.
29968 (TypeContainer.RegisterRequiredImplementations): This routine now
29969 registers all the implementations required in an array for the
29970 interfaces and abstract methods. We use an array of structures
29971 which can be computed ahead of time to reduce memory usage and we
29972 also assume that lookups are cheap as most classes will not
29973 implement too many interfaces.
29975 We also avoid creating too many MethodSignatures.
29977 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29978 clear the "pending" bit if we find that there are problems with
29981 (TypeContainer.VerifyPendingMethods): Update to report errors of
29982 methods that look like implementations but are not.
29984 (TypeContainer.Define): Add support for explicit interface method
29987 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29989 * typemanager.cs: Keep track of the parameters here instead of
29990 being a feature of the TypeContainer.
29992 * class.cs: Drop the registration of parameters here, as
29993 InterfaceMethods are also interface declarations.
29995 * delegate.cs: Register methods with the TypeManager not only with
29996 the TypeContainer. This code was buggy.
29998 * interface.cs: Full registation here.
30000 2001-12-11 Miguel de Icaza <miguel@ximian.com>
30002 * expression.cs: Remove reducer for binary expressions, it can not
30005 * const.cs: Put here the code that used to go into constant.cs
30007 * constant.cs: Put here the code for constants, this is a new base
30008 class for Literals.
30010 * literal.cs: Make Literal derive from Constant.
30012 2001-12-09 Miguel de Icaza <miguel@ximian.com>
30014 * statement.cs (Return.Emit): Report error 157 if the user
30015 attempts to return from a finally block.
30017 (Return.Emit): Instead of emitting a return, jump to the end of
30020 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
30021 LocalBuilder to store the result of the function. ReturnLabel is
30022 the target where we jump.
30025 2001-12-09 Radek Doulik <rodo@ximian.com>
30027 * cs-parser.jay: remember alias in current namespace
30029 * ecore.cs (SimpleName::DoResolve): use aliases for types or
30032 * class.cs (LookupAlias): lookup alias in my_namespace
30034 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
30036 (LookupAlias): lookup alias in this and if needed in parent
30039 2001-12-08 Miguel de Icaza <miguel@ximian.com>
30043 * rootcontext.cs: (ModuleBuilder) Made static, first step into
30044 making things static. I need this to avoid passing the
30045 TypeContainer when calling ParameterType.
30047 * support.cs (InternalParameters.ParameterType): Remove ugly hack
30048 that did string manipulation to compute the type and then call
30049 GetType. Use Parameter.ParameterType instead.
30051 * cs-tokenizer.cs: Consume the suffix for floating values.
30053 * expression.cs (ParameterReference): figure out whether this is a
30054 reference parameter or not. Kill an extra variable by computing
30055 the arg_idx during emission.
30057 * parameter.cs (Parameters.GetParameterInfo): New overloaded
30058 function that returns whether a parameter is an out/ref value or not.
30060 (Parameter.ParameterType): The type of the parameter (base,
30061 without ref/out applied).
30063 (Parameter.Resolve): Perform resolution here.
30064 (Parameter.ExternalType): The full type (with ref/out applied).
30066 * statement.cs (Using.Emit, Using.EmitExpression): Implement
30067 support for expressions on the using statement.
30069 2001-12-07 Miguel de Icaza <miguel@ximian.com>
30071 * statement.cs (Using.EmitLocalVariableDecls): Split the
30072 localvariable handling of the using statement.
30074 (Block.EmitMeta): Keep track of variable count across blocks. We
30075 were reusing slots on separate branches of blocks.
30077 (Try.Emit): Emit the general code block, we were not emitting it.
30079 Check the type of the declaration to be an IDisposable or
30080 something that can be implicity converted to it.
30082 Emit conversions if required.
30084 * ecore.cs (EmptyExpression): New utility class.
30085 (Expression.ImplicitConversionExists): New utility function.
30087 2001-12-06 Miguel de Icaza <miguel@ximian.com>
30089 * statement.cs (Using): Implement.
30091 * expression.cs (LocalVariableReference): Support read only variables.
30093 * statement.cs: Remove the explicit emit for the Leave opcode.
30094 (VariableInfo): Add a readonly field.
30096 2001-12-05 Miguel de Icaza <miguel@ximian.com>
30098 * ecore.cs (ConvCast): new class used to encapsulate the various
30099 explicit integer conversions that works in both checked and
30100 unchecked contexts.
30102 (Expression.ConvertNumericExplicit): Use new ConvCast class to
30103 properly generate the overflow opcodes.
30105 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30107 * statement.cs: The correct type for the EmptyExpression is the
30108 element_type, not the variable type. Ravi pointed this out.
30110 2001-12-04 Ravi Pratap <ravi@ximian.com>
30112 * class.cs (Method::Define): Handle PInvoke methods specially
30113 by using DefinePInvokeMethod instead of the usual one.
30115 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
30116 above to do the task of extracting information and defining the method.
30118 2001-12-04 Ravi Pratap <ravi@ximian.com>
30120 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
30121 of the condition for string type.
30123 (Emit): Move that here.
30125 (ArrayCreation::CheckIndices): Keep string literals in their expression
30128 (EmitDynamicInitializers): Handle strings appropriately.
30130 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30132 * codegen.cs (EmitContext): Replace multiple variables with a
30133 single pointer to the current Switch statement.
30135 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
30138 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30142 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
30145 (Foreach.Emit): Foreach on arrays was not setting
30146 up the loop variables (for break/continue).
30148 (GotoCase): Semi-implented.
30150 2001-12-03 Ravi Pratap <ravi@ximian.com>
30152 * attribute.cs (CheckAttribute): Handle system attributes by using
30153 Attribute.GetAttributes to examine information we need.
30155 (GetValidPlaces): Same here.
30157 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
30159 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
30161 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
30163 (Method::Define): Set appropriate flags if we have a DllImport attribute.
30165 (Method::Emit): Handle the case when we are a PInvoke method.
30167 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30169 * expression.cs: Use ResolveWithSimpleName on compound names.
30171 2001-12-02 Ravi Pratap <ravi@ximian.com>
30173 * constant.cs (EmitConstant): Make sure we resolve the associated expression
30174 before trying to reduce it.
30176 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
30178 * constant.cs (LookupConstantValue): Implement.
30180 (EmitConstant): Use the above in emitting the constant.
30182 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30183 that are user-defined by doing a LookupConstantValue on them.
30185 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30188 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30190 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30192 (BaseAccess.DoResolve): Implement.
30194 (MemberAccess.DoResolve): Split this routine into a
30195 ResolveMemberAccess routine that can be used independently
30197 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30199 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30200 As that share bits of the implementation. Is returns a boolean,
30201 while As returns the Type that is being probed.
30203 2001-12-01 Ravi Pratap <ravi@ximian.com>
30205 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30206 instead of a Literal - much easier.
30208 (EnumInTransit): Remove - utterly useless :-)
30210 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30212 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30214 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30215 chain when we have no associated expression.
30217 2001-11-30 Ravi Pratap <ravi@ximian.com>
30219 * constant.cs (Define): Use Location while reporting the errror.
30221 Also emit a warning when 'new' is used and there is no inherited
30224 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30227 (LookupEnumValue): Implement to lookup an enum member's value and define it
30230 (Populate): Re-write accordingly to use the above routine.
30232 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30234 * expression.cs (This): Fix prototype for DoResolveLValue to
30235 override the base class DoResolveLValue.
30237 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30240 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30241 (we need to load the address of the field here). This fixes
30244 (FieldExpr.DoResolveLValue): Call the DoResolve
30245 function to initialize the Instance expression.
30247 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30248 correctly the GetEnumerator operation on a value type.
30250 * cs-parser.jay: Add more simple parsing error catches.
30252 * statement.cs (Switch): Add support for string switches.
30253 Handle null specially.
30255 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30257 2001-11-28 Ravi Pratap <ravi@ximian.com>
30259 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30261 (declare_local_constant): New helper function.
30263 * statement.cs (AddConstant): Keep a separate record of constants
30265 (IsConstant): Implement to determine if a variable is a constant.
30267 (GetConstantExpression): Implement.
30269 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30271 * statement.cs (IsVariableDefined): Re-write.
30273 2001-11-27 Ravi Pratap <ravi@ximian.com>
30275 * class.cs (TypeContainer::FindMembers): Look for constants
30276 in the case when we are looking for MemberTypes.Field
30278 * expression.cs (MemberAccess::DoResolve): Check that in the
30279 case we are a FieldExpr and a Literal, we are not being accessed
30280 by an instance reference.
30282 * cs-parser.jay (local_constant_declaration): Implement.
30284 (declaration_statement): Implement for constant declarations.
30286 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30288 * statement.cs (Switch): Catch double defaults.
30290 (Switch): More work on the switch() statement
30291 implementation. It works for integral values now, need to finish
30295 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30297 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30298 integer literals into other integer literals. To be used by
30301 2001-11-24 Ravi Pratap <ravi@ximian.com>
30303 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30306 (EmitDynamicInitializers): Cope with the above since we extract data
30307 directly from ArrayData now.
30309 (ExpectInitializers): Keep track of whether initializers are mandatory
30312 (Bounds): Make it a hashtable to prevent the same dimension being
30313 recorded for every element in that dimension.
30315 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30318 Also fix bug which was causing the indices to be emitted in the reverse
30321 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30323 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30324 unfinished. They do not work, because the underlying code is
30327 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30329 * cs-parser.jay: Remove bogus fixme.
30331 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30332 on Switch statement.
30334 2001-11-23 Ravi Pratap <ravi@ximian.com>
30336 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30339 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30340 parameter. Apparently, any expression is allowed.
30342 (ValidateInitializers): Update accordingly.
30344 (CheckIndices): Fix some tricky bugs thanks to recursion.
30346 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30347 I was being completely brain-dead.
30349 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30350 and re-write acordingly.
30352 (DelegateInvocation): Re-write accordingly.
30354 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30356 (MakeByteBlob): Handle types more correctly.
30358 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30359 initialization from expressions but it is incomplete because I am a complete
30362 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30364 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30365 on If. Basically, we have to return `true' (ie, we do return to
30366 our caller) only if both branches of the if return.
30368 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30369 short-circuit operators, handle them as short circuit operators.
30371 (Cast.DoResolve): Resolve type.
30372 (Cast.Cast): Take an expression as the target type.
30374 * cs-parser.jay (cast_expression): Remove old hack that only
30375 allowed a limited set of types to be handled. Now we take a
30376 unary_expression and we resolve to a type during semantic
30379 Use the grammar productions from Rhys to handle casts (this is
30380 not complete like Rhys syntax yet, we fail to handle that corner
30381 case that C# has regarding (-x), but we will get there.
30383 2001-11-22 Ravi Pratap <ravi@ximian.com>
30385 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30386 field which is an array type.
30388 * cs-parser.jay (declare_local_variables): Support array initialization too.
30390 * typemanager.cs (MakeKey): Implement.
30392 (everywhere): Use the above appropriately.
30394 * cs-parser.jay (for_statement): Update for array initialization while
30395 declaring variables.
30397 * ecore.cs : The error message was correct, it's the variable's names that
30398 were misleading ;-) Make the code more readable.
30400 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30401 the correct type etc.
30403 (ConvertExplicit): Handle Enum types by examining the underlying type.
30405 2001-11-21 Ravi Pratap <ravi@ximian.com>
30407 * parameter.cs (GetCallingConvention): Always return
30408 CallingConventions.Standard for now.
30410 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30412 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30413 and `r' after calling DoNumericPromotions.
30415 * ecore.cs: Fix error message (the types were in the wrong order).
30417 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30418 BindingFlags.Instance as well
30420 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30421 implicit int literal conversion in an empty cast so that we
30422 propagate the right type upstream.
30424 (UnboxCast): new class used to unbox value types.
30425 (Expression.ConvertExplicit): Add explicit type conversions done
30428 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30429 the target type before applying the implicit LongLiterals to ULong
30432 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30434 * cs-parser.jay (for_statement): Reworked the way For works: now
30435 we declare manually any variables that are introduced in
30436 for_initializer to solve the problem of having out-of-band code
30437 emition (that is what got for broken).
30439 (declaration_statement): Perform the actual variable declaration
30440 that used to be done in local_variable_declaration here.
30442 (local_variable_declaration): Do not declare anything, just pass
30443 the information on a DictionaryEntry
30445 2001-11-20 Ravi Pratap <ravi@ximian.com>
30447 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30448 re-write of the logic to now make it recursive.
30450 (UpdateIndices): Re-write accordingly.
30452 Store element data in a separate ArrayData list in the above methods.
30454 (MakeByteBlob): Implement to dump the array data into a byte array.
30456 2001-11-19 Ravi Pratap <ravi@ximian.com>
30458 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30461 * constant.cs (Define): Implement.
30463 (EmitConstant): Re-write fully.
30465 Pass in location info.
30467 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30470 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30471 DictionaryEntry since we need location info too.
30473 (constant_declaration): Update accordingly.
30475 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30476 code into another method : UpdateIndices.
30478 2001-11-18 Ravi Pratap <ravi@ximian.com>
30480 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30481 some type checking etc.
30483 2001-11-17 Ravi Pratap <ravi@ximian.com>
30485 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30486 bits to provide dimension info if the user skips doing that.
30488 Update second constructor to store the rank correctly.
30490 2001-11-16 Ravi Pratap <ravi@ximian.com>
30492 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30493 and try to implement.
30495 * ../errors/cs0150.cs : Add.
30497 * ../errors/cs0178.cs : Add.
30499 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30501 * statement.cs: Implement foreach on multi-dimensional arrays.
30503 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30504 name of the params argument.
30506 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30507 initializing the array.
30509 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30510 we can use this elsewhere.
30512 * statement.cs: Finish implementation of foreach for single
30515 * cs-parser.jay: Use an out-of-band stack to pass information
30516 around, I wonder why I need this.
30518 foreach_block: Make the new foreach_block the current_block.
30520 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30521 function used to return a static Parameters structure. Used for
30522 empty parameters, as those are created very frequently.
30524 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30526 2001-11-15 Ravi Pratap <ravi@ximian.com>
30528 * interface.cs : Default modifier is private, not public. The
30529 make verify test passes again.
30531 2001-11-15 Ravi Pratap <ravi@ximian.com>
30533 * support.cs (ReflectionParameters): Fix logic to determine
30534 whether the last parameter is a params one. Test 9 passes again.
30536 * delegate.cs (Populate): Register the builders we define with
30537 RegisterParameterForBuilder. Test 19 passes again.
30539 * cs-parser.jay (property_declaration): Reference $6 instead
30540 of $$ to get at the location.
30542 (indexer_declaration): Similar stuff.
30544 (attribute): Ditto.
30546 * class.cs (Property): Register parameters for the Get and Set methods
30547 if they exist. Test 23 passes again.
30549 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30550 call to EmitArguments as we are sure there aren't any params arguments.
30551 Test 32 passes again.
30553 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30554 IndexOutOfRangeException.
30556 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30557 Test 33 now passes again.
30559 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30561 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30562 broke a bunch of things. Will have to come up with a better way
30563 of tracking locations.
30565 * statement.cs: Implemented foreach for single dimension arrays.
30567 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30569 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30570 an error. This removes the lookup from the critical path.
30572 * cs-parser.jay: Removed use of temporary_loc, which is completely
30575 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30577 * support.cs (ReflectionParameters.ParameterModifier): Report
30578 whether the argument is a PARAMS argument or not.
30580 * class.cs: Set the attribute `ParamArrayAttribute' on the
30581 parameter argument.
30583 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30584 and cons_param_array_attribute (ConstructorInfo for
30585 ParamArrayAttribute).,
30587 * codegen.cs: Emit the return using the `Return' statement, that
30588 way we can report the error correctly for missing return values.
30590 * class.cs (Method.Emit): Clean up.
30592 * expression.cs (Argument.Resolve): Take another argument: the
30593 location where this argument is used. Notice that this is not
30594 part of the "Argument" class as to reduce the size of the
30595 structure (we know the approximate location anyways).
30597 Test if the argument is a variable-reference, if not, then
30598 complain with a 206.
30600 (Argument.Emit): Emit addresses of variables.
30602 (Argument.FullDesc): Simplify.
30604 (Invocation.DoResolve): Update for Argument.Resolve.
30606 (ElementAccess.DoResolve): ditto.
30608 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30609 method should be virtual, as this method is always virtual.
30611 (NewDelegate.DoResolve): Update for Argument.Resolve.
30613 * class.cs (ConstructorInitializer.DoResolve): ditto.
30615 * attribute.cs (Attribute.Resolve): ditto.
30617 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30619 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30621 * expression.cs (ParameterReference): Drop IStackStorage and implement
30622 IAssignMethod instead.
30624 (LocalVariableReference): ditto.
30626 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30627 IAssignMethod instead.
30629 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30631 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30632 enumerations that are used in heavily used structures derive from
30633 byte in a laughable and pathetic attempt to reduce memory usage.
30634 This is the kind of pre-optimzations that you should not do at
30635 home without adult supervision.
30637 * expression.cs (UnaryMutator): New class, used to handle ++ and
30638 -- separatedly from the other unary operators. Cleans up the
30639 code, and kills the ExpressionStatement dependency in Unary.
30641 (Unary): Removed `method' and `Arguments' from this class, making
30642 it smaller, and moving it all to SimpleCall, so I can reuse this
30643 code in other locations and avoid creating a lot of transient data
30644 strucutres when not required.
30646 * cs-parser.jay: Adjust for new changes.
30648 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30650 * enum.cs (Enum.Populate): If there is a failure during
30653 * cs-parser.jay (opt_enum_base): we used to catch type errors
30654 here, but this is really incorrect. The type error should be
30655 catched during semantic analysis.
30657 2001-12-11 Ravi Pratap <ravi@ximian.com>
30659 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30660 current_local_parameters as expected since I, in my stupidity, had forgotten
30663 * attribute.cs (GetValidPlaces): Fix stupid bug.
30665 * class.cs (Method::Emit): Perform check on applicability of attributes.
30667 (Constructor::Emit): Ditto.
30669 (Field::Emit): Ditto.
30671 (Field.Location): Store location information.
30673 (Property, Event, Indexer, Operator): Ditto.
30675 * cs-parser.jay (field_declaration): Pass in location for each field.
30677 * ../errors/cs0592.cs : Add.
30679 2001-11-12 Ravi Pratap <ravi@ximian.com>
30681 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30683 (InitCoreTypes): Update accordingly.
30685 (RegisterAttrType, LookupAttr): Implement.
30687 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30688 info about the same.
30690 (Resolve): Update to populate the above as necessary.
30692 (Error592): Helper.
30694 (GetValidPlaces): Helper to the above.
30696 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30698 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30700 2001-11-12 Ravi Pratap <ravi@ximian.com>
30702 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30704 * ../errors/cs0617.cs : Add.
30706 2001-11-11 Ravi Pratap <ravi@ximian.com>
30708 * enum.cs (Emit): Rename to Populate to be more consistent with what
30709 we expect it to do and when exactly it is called.
30711 * class.cs, rootcontext.cs : Update accordingly.
30713 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30714 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30716 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30718 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30719 of a fieldinfo using the above, when dealing with a FieldBuilder.
30721 2001-11-10 Ravi Pratap <ravi@ximian.com>
30723 * ../errors/cs0031.cs : Add.
30725 * ../errors/cs1008.cs : Add.
30727 * ../errrors/cs0543.cs : Add.
30729 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30732 (FindMembers): Implement.
30734 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30735 enums and delegates too.
30737 (enum_types): Rename to builder_to_enum.
30739 (delegate_types): Rename to builder_to_delegate.
30741 * delegate.cs (FindMembers): Implement.
30743 2001-11-09 Ravi Pratap <ravi@ximian.com>
30745 * typemanager.cs (IsEnumType): Implement.
30747 * enum.cs (Emit): Re-write parts to account for the underlying type
30748 better and perform checking etc.
30750 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30751 of the underlying type.
30753 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30756 * enum.cs (error31): Helper to report error #31.
30758 * cs-parser.jay (enum_declaration): Store location of each member too.
30760 * enum.cs (member_to_location): New hashtable.
30762 (AddEnumMember): Update location hashtable.
30764 (Emit): Use the location of each member while reporting errors.
30766 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30768 * cs-parser.jay: A for_initializer if is a
30769 local_variable_declaration really ammount to have an implicit
30770 block with the variable declaration and no initializer for for.
30772 * statement.cs (For.Emit): Cope with null initializers.
30774 This fixes the infinite loop on for initializers.
30776 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30778 * enum.cs: More cleanup.
30780 * ecore.cs: Remove dead code.
30782 * class.cs (Property.Emit): More simplification.
30783 (Event.Emit): ditto.
30785 Reworked to have less levels of indentation.
30787 2001-11-08 Ravi Pratap <ravi@ximian.com>
30789 * class.cs (Property): Emit attributes.
30799 * enum.cs (Emit): Ditto.
30801 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30804 * class.cs (Field, Event, etc.): Move attribute generation into the
30805 Emit method everywhere.
30807 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30808 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30809 as we had no way of defining nested enums !
30811 * rootcontext.cs : Adjust code accordingly.
30813 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30815 2001-11-07 Ravi Pratap <ravi@ximian.com>
30817 * expression.cs (EvalConstantExpression): Move into ecore.cs
30819 * enum.cs (Enum): Rename some members and make them public and readonly
30820 according to our convention.
30822 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30825 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30827 (Enum::Emit): Write a simple version for now which doesn't try to compute
30828 expressions. I shall modify this to be more robust in just a while.
30830 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30832 (TypeContainer::CloseType): Create the Enum types too.
30834 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30836 * expression.cs (EvalConstantExpression): Get rid of completely.
30838 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30839 user-defined values and other cases.
30841 (IsValidEnumLiteral): Helper function.
30843 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30844 out there in the case we had a literal FieldExpr.
30846 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30848 (Literalize): Revamp a bit to take two arguments.
30850 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30852 2001-11-06 Ravi Pratap <ravi@ximian.com>
30854 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30856 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30858 (Resolve): Use the above to ensure we have proper initializers.
30860 2001-11-05 Ravi Pratap <ravi@ximian.com>
30862 * expression.cs (Expression::EvalConstantExpression): New method to
30863 evaluate constant expressions.
30865 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30867 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30869 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30872 (Binary.ResolveOperator): Handle operator != (object a, object b)
30873 and operator == (object a, object b);
30875 (Binary.DoNumericPromotions): Indicate whether the numeric
30876 promotion was possible.
30878 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30881 Made the ArrayAccess implement interface IAssignMethod instead of
30882 IStackStore as the order in which arguments are passed reflects
30885 * assign.cs: Instead of using expr.ExprClass to select the way of
30886 assinging, probe for the IStackStore/IAssignMethod interfaces.
30888 * typemanager.cs: Load InitializeArray definition.
30890 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30891 static data that can be used to initialize arrays.
30893 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30895 * expression.cs: Handle operator== and operator!= for booleans.
30897 (Conditioal.Reduce): Implement reducer for the ?: operator.
30899 (Conditional.Resolve): Implement dead code elimination.
30901 (Binary.Resolve): Catch string literals and return a new
30902 concatenated string.
30904 (Unary.Reduce): Implement reduction of unary expressions.
30906 * ecore.cs: Split out the expression core handling here.
30908 (Expression.Reduce): New method used to perform constant folding
30909 and CSE. This is needed to support constant-expressions.
30911 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30912 targets, and optimize for !x.
30914 2001-11-04 Ravi Pratap <ravi@ximian.com>
30916 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30917 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30918 set custom atttributes.
30920 * literal.cs (Literal::GetValue): New abstract method to return the actual
30921 value of the literal, cast as an object.
30923 (*Literal): Implement GetValue method.
30925 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30926 expressions to the arraylist but objects of type Argument.
30928 * class.cs (TypeContainer::Emit): Emit our attributes too.
30930 (Method::Emit, Constructor::Emit): Ditto.
30932 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30933 to be ignoring earlier.
30935 2001-11-03 Ravi Pratap <ravi@ximian.com>
30937 * attribute.cs (AttributeSection::Define): Implement to do the business
30938 of constructing a CustomAttributeBuilder.
30940 (Attribute): New trivial class. Increases readability of code.
30942 * cs-parser.jay : Update accordingly.
30944 (positional_argument_list, named_argument_list, named_argument): New rules
30946 (attribute_arguments): Use the above so that we are more correct.
30948 2001-11-02 Ravi Pratap <ravi@ximian.com>
30950 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30951 to perform all checks for a method with a params parameter.
30953 (Invocation::OverloadResolve): Update to use the above method and therefore
30954 cope correctly with params method invocations.
30956 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30959 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30960 constructors in our parent too because we can't afford to miss out on
30963 * attribute.cs (AttributeSection): New name for the class Attribute
30965 Other trivial changes to improve readability.
30967 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30968 use the new class names.
30970 2001-11-01 Ravi Pratap <ravi@ximian.com>
30972 * class.cs (Method::Define): Complete definition for params types too
30974 (Indexer::Define): Ditto.
30976 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30977 Cope everywhere with a request for info about the array parameter.
30979 2001-11-01 Ravi Pratap <ravi@ximian.com>
30981 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30983 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30984 local_variable_type to extract the string corresponding to the type.
30986 (local_variable_type): Fixup the action to use the new helper method.
30988 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30991 * expression.cs : Clean out code which uses the above.
30993 2001-10-31 Ravi Pratap <ravi@ximian.com>
30995 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30996 and bale out if necessary by returning a false.
30998 (RegisterProperty): Ditto.
31000 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
31001 and print out appropriate error messages.
31003 * interface.cs (everywhere): Ditto.
31005 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
31006 location to constructor.
31008 * class.cs (Property, Event, Indexer): Update accordingly.
31010 * ../errors/cs111.cs : Added.
31012 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
31013 of a method, as laid down by the spec.
31015 (Invocation::OverloadResolve): Use the above method.
31017 2001-10-31 Ravi Pratap <ravi@ximian.com>
31019 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
31020 now take a TypeContainer and a Parameters object.
31022 (ParameterData): Modify return type of ParameterModifier method to be
31023 Parameter.Modifier and not a string.
31025 (ReflectionParameters, InternalParameters): Update accordingly.
31027 * expression.cs (Argument::GetParameterModifier): Same here.
31029 * support.cs (InternalParameters::ParameterType): Find a better way of determining
31030 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
31031 symbol in it at all so maybe this is only for now.
31033 2001-10-30 Ravi Pratap <ravi@ximian.com>
31035 * support.cs (InternalParameters): Constructor now takes an extra argument
31036 which is the actual Parameters class.
31038 (ParameterDesc): Update to provide info on ref/out modifiers.
31040 * class.cs (everywhere): Update call to InternalParameters to pass in
31041 the second argument too.
31043 * support.cs (ParameterData): Add ParameterModifier, which is a method
31044 to return the modifier info [ref/out etc]
31046 (InternalParameters, ReflectionParameters): Implement the above.
31048 * expression.cs (Argument::ParameterModifier): Similar function to return
31049 info about the argument's modifiers.
31051 (Invocation::OverloadResolve): Update to take into account matching modifiers
31054 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
31055 a new SetFormalParameters object which we pass to InternalParameters.
31057 2001-10-30 Ravi Pratap <ravi@ximian.com>
31059 * expression.cs (NewArray): Merge into the ArrayCreation class.
31061 2001-10-29 Ravi Pratap <ravi@ximian.com>
31063 * expression.cs (NewArray): Merge classes NewBuiltinArray and
31064 NewUserdefinedArray into one as there wasn't much of a use in having
31067 * expression.cs (Argument): Change field's name to ArgType from Type.
31069 (Type): New readonly property which returns the proper type, taking into
31070 account ref/out modifiers.
31072 (everywhere): Adjust code accordingly for the above.
31074 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
31075 whether we are emitting for a ref or out parameter.
31077 * expression.cs (Argument::Emit): Use the above field to set the state.
31079 (LocalVariableReference::Emit): Update to honour the flag and emit the
31082 * parameter.cs (Attributes): Set the correct flags for ref parameters.
31084 * expression.cs (Argument::FullDesc): New function to provide a full desc.
31086 * support.cs (ParameterData): Add method ParameterDesc to the interface.
31088 (ReflectionParameters, InternalParameters): Implement the above method.
31090 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
31093 (Invocation::FullMethodDesc): Ditto.
31095 2001-10-29 Miguel de Icaza <miguel@ximian.com>
31097 * cs-parser.jay: Add extra production for the second form of array
31100 * expression.cs (ArrayCreation): Update to reflect the above
31103 * Small changes to prepare for Array initialization.
31105 2001-10-28 Miguel de Icaza <miguel@ximian.com>
31107 * typemanager.cs (ImplementsInterface): interface might be null;
31108 Deal with this problem;
31110 Also, we do store negative hits on the cache (null values), so use
31111 this instead of calling t.GetInterfaces on the type everytime.
31113 2001-10-28 Ravi Pratap <ravi@ximian.com>
31115 * typemanager.cs (IsBuiltinType): New method to help determine the same.
31117 * expression.cs (New::DoResolve): Get rid of array creation code and instead
31118 split functionality out into different classes.
31120 (New::FormArrayType): Move into NewBuiltinArray.
31122 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
31125 (NewBuiltinArray): New class to handle creation of built-in arrays.
31127 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
31128 account creation of one-dimensional arrays.
31130 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
31132 (NewUserdefinedArray::DoResolve): Implement.
31134 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
31136 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
31137 we maintain inside the TypeManager. This is necessary to perform lookups on the
31140 (LookupType): Update to perform GetType on the module builders too.
31142 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
31144 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
31146 2001-10-23 Ravi Pratap <ravi@ximian.com>
31148 * expression.cs (New::DoResolve): Implement guts of array creation.
31150 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
31152 2001-10-27 Miguel de Icaza <miguel@ximian.com>
31154 * expression.cs: Fix bug I introduced lsat night that broke
31157 (Expression.Resolve): Report a 246 error (can not resolve name)
31158 if we find a SimpleName in the stream.
31160 (Expression.ResolveLValue): Ditto.
31162 (Expression.ResolveWithSimpleName): This function is a variant of
31163 ResolveName, this one allows SimpleNames to be returned without a
31164 warning. The only consumer of SimpleNames is MemberAccess
31166 2001-10-26 Miguel de Icaza <miguel@ximian.com>
31168 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
31169 might arrive here. I have my doubts that this is correct.
31171 * statement.cs (Lock): Implement lock statement.
31173 * cs-parser.jay: Small fixes to support `lock' and `using'
31175 * cs-tokenizer.cs: Remove extra space
31177 * driver.cs: New flag --checked, allows to turn on integer math
31180 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
31181 Threading.Monitor.Exit
31183 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31185 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31186 Expression Class to be IndexerAccess.
31188 Notice that Indexer::DoResolve sets the eclass to Value.
31190 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31192 * class.cs (TypeContainer::Emit): Emit code for indexers.
31194 * assign.cs (IAssignMethod): New interface implemented by Indexers
31195 and Properties for handling assignment.
31197 (Assign::Emit): Simplify and reuse code.
31199 * expression.cs (IndexerAccess, PropertyExpr): Implement
31200 IAssignMethod, clean up old code.
31202 2001-10-22 Ravi Pratap <ravi@ximian.com>
31204 * typemanager.cs (ImplementsInterface): New method to determine if a type
31205 implements a given interface. Provides a nice cache too.
31207 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31210 (ConvertReferenceExplicit): Ditto.
31212 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31213 various methods, with correct names etc.
31215 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31216 Operator.UnaryNegation.
31218 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31219 we have a unary plus or minus operator.
31221 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31224 * everywhere : update accordingly.
31226 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31229 * class.cs (Method::Define): For the case where we are implementing a method
31230 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31231 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31233 2001-10-21 Ravi Pratap <ravi@ximian.com>
31235 * interface.cs (FindMembers): Implement to work around S.R.E
31238 * typemanager.cs (IsInterfaceType): Implement.
31240 (FindMembers): Update to handle interface types too.
31242 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31243 use IsAssignableFrom as that is not correct - it doesn't work.
31245 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31246 and accordingly override EmitStatement.
31248 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31249 using the correct logic :-)
31251 2001-10-19 Ravi Pratap <ravi@ximian.com>
31253 * ../errors/cs-11.cs : Add to demonstrate error -11
31255 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31257 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31258 then pass this as a hint to ResolveLValue.
31260 * expression.cs (FieldExpr): Add Location information
31262 (FieldExpr::LValueResolve): Report assignment to readonly
31265 (Expression::ExprClassFromMemberInfo): Pass location information.
31267 (Expression::ResolveLValue): Add new method that resolves an
31270 (Expression::DoResolveLValue): Default invocation calls
31273 (Indexers): New class used to keep track of indexers in a given
31276 (IStackStore): Renamed from LValue, as it did not really describe
31277 what this did. Also ResolveLValue is gone from this interface and
31278 now is part of Expression.
31280 (ElementAccess): Depending on the element access type
31282 * typemanager.cs: Add `indexer_name_type' as a Core type
31283 (System.Runtime.CompilerServices.IndexerNameAttribute)
31285 * statement.cs (Goto): Take a location.
31287 2001-10-18 Ravi Pratap <ravi@ximian.com>
31289 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31290 if two delegates are compatible.
31292 (NewDelegate::DoResolve): Update to take care of the case when
31293 we instantiate a delegate from another delegate.
31295 * typemanager.cs (FindMembers): Don't even try to look up members
31296 of Delegate types for now.
31298 2001-10-18 Ravi Pratap <ravi@ximian.com>
31300 * delegate.cs (NewDelegate): New class to take care of delegate
31303 * expression.cs (New): Split the delegate related code out into
31304 the NewDelegate class.
31306 * delegate.cs (DelegateInvocation): New class to handle delegate
31309 * expression.cs (Invocation): Split out delegate related code into
31310 the DelegateInvocation class.
31312 2001-10-17 Ravi Pratap <ravi@ximian.com>
31314 * expression.cs (New::DoResolve): Implement delegate creation fully
31315 and according to the spec.
31317 (New::DoEmit): Update to handle delegates differently.
31319 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31320 because of which we were printing out arguments in reverse order !
31322 * delegate.cs (VerifyMethod): Implement to check if the given method
31323 matches the delegate.
31325 (FullDelegateDesc): Implement.
31327 (VerifyApplicability): Implement.
31329 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31330 delegate invocations too.
31332 (Invocation::Emit): Ditto.
31334 * ../errors/cs1593.cs : Added.
31336 * ../errors/cs1594.cs : Added.
31338 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31340 2001-10-16 Ravi Pratap <ravi@ximian.com>
31342 * typemanager.cs (intptr_type): Core type for System.IntPtr
31344 (InitCoreTypes): Update for the same.
31346 (iasyncresult_type, asynccallback_type): Ditto.
31348 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31351 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31354 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31355 the builders for the 4 members of a delegate type :-)
31357 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31360 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31362 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31364 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31366 * statement.cs (Break::Emit): Implement.
31367 (Continue::Emit): Implement.
31369 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31370 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31371 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31372 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31375 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31376 properties that track the label for the current loop (begin of the
31377 loop and end of the loop).
31379 2001-10-15 Ravi Pratap <ravi@ximian.com>
31381 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31382 use of emitting anything at all.
31384 * class.cs, rootcontext.cs : Get rid of calls to the same.
31386 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31388 (Populate): Define the constructor correctly and set the implementation
31391 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31394 (AddDelegateType): Implement.
31396 (IsDelegateType): Implement helper method.
31398 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31400 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31401 and accordingly handle it.
31403 * delegate.cs (Populate): Take TypeContainer argument.
31404 Implement bits to define the Invoke method. However, I still haven't figured out
31405 how to take care of the native int bit :-(
31407 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31408 Qualify the name of the delegate, not its return type !
31410 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31413 (StandardConversionExists): Checking for array types turns out to be recursive.
31415 (ConvertReferenceExplicit): Implement array conversion.
31417 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31419 2001-10-12 Ravi Pratap <ravi@ximian.com>
31421 * cs-parser.jay (delegate_declaration): Store the fully qualified
31422 name as it is a type declaration.
31424 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31427 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31428 as TypeContainer::DefineType.
31430 (Populate): Method in which all the definition of the various methods (Invoke)
31433 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31436 (CloseDelegate): Finally creates the delegate.
31438 * class.cs (TypeContainer::DefineType): Update to define delegates.
31439 (Populate, Emit and CloseType): Do the same thing here too.
31441 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31442 delegates in all these operations.
31444 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31446 * expression.cs: LocalTemporary: a new expression used to
31447 reference a temporary that has been created.
31449 * assign.cs: Handle PropertyAccess back here, so that we can
31450 provide the proper semantic access to properties.
31452 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31453 a few more explicit conversions.
31455 * modifiers.cs: `NEW' modifier maps to HideBySig.
31457 * expression.cs (PropertyExpr): Make this into an
31458 ExpressionStatement, and support the EmitStatement code path.
31460 Perform get/set error checking, clean up the interface.
31462 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31463 them into toplevel access objects.
31465 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31467 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31470 * typemanager.cs: Keep track here of our PropertyBuilders again to
31471 work around lameness in SRE.
31473 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31475 * expression.cs (LValue::LValueResolve): New method in the
31476 interface, used to perform a second resolution pass for LValues.
31478 (This::DoResolve): Catch the use of this in static methods.
31480 (This::LValueResolve): Implement.
31482 (This::Store): Remove warning, assigning to `this' in structures
31485 (Invocation::Emit): Deal with invocation of
31486 methods on value types. We need to pass the address to structure
31487 methods rather than the object itself. (The equivalent code to
31488 emit "this" for structures leaves the entire structure on the
31489 stack instead of a pointer to it).
31491 (ParameterReference::DoResolve): Compute the real index for the
31492 argument based on whether the method takes or not a `this' pointer
31493 (ie, the method is static).
31495 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31496 value types returned from functions when we need to invoke a
31497 method on the sturcture.
31500 2001-10-11 Ravi Pratap <ravi@ximian.com>
31502 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31503 defining the type in the Modulebuilder or Typebuilder. This is to take
31504 care of nested types which need to be defined on the TypeBuilder using
31505 DefineNestedMethod.
31507 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31508 methods in RootContext, only ported to be part of TypeContainer.
31510 (TypeContainer::GetInterfaceOrClass): Ditto.
31512 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31514 * interface.cs (Interface::DefineInterface): New method. Does exactly
31515 what RootContext.CreateInterface did earlier, only it takes care of nested types
31518 (Interface::GetInterfaces): Move from RootContext here and port.
31520 (Interface::GetInterfaceByName): Same here.
31522 * rootcontext.cs (ResolveTree): Re-write.
31524 (PopulateTypes): Re-write.
31526 * class.cs (TypeContainer::Populate): Populate nested types too.
31527 (TypeContainer::Emit): Emit nested members too.
31529 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31530 instead just use the name argument passed in as it is already fully
31533 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31534 to TypeContainer mapping to see if a type is user-defined.
31536 * class.cs (TypeContainer::CloseType): Implement.
31538 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31539 the default constructor.
31541 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31544 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31546 * interface.cs (CloseType): Create the type here.
31548 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31551 Remove all the methods which are now in TypeContainer.
31553 2001-10-10 Ravi Pratap <ravi@ximian.com>
31555 * delegate.cs (Define): Re-write bits to define the delegate
31558 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31560 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31562 * expression.cs (ImplicitReferenceConversion): handle null as well
31563 as a source to convert to any reference type.
31565 * statement.cs (Return): Perform any implicit conversions to
31566 expected return type.
31568 Validate use of return statement.
31570 * codegen.cs (EmitContext): Pass the expected return type here.
31572 * class.cs (Method, Constructor, Property): Pass expected return
31573 type to EmitContext.
31575 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31577 * expression.cs: Make DoResolve take an EmitContext instead of a
31580 Replaced `l' and `location' for `loc', for consistency.
31582 (Error, Warning): Remove unneeded Tc argument.
31584 * assign.cs, literal.cs, constant.cs: Update to new calling
31587 * codegen.cs: EmitContext now contains a flag indicating whether
31588 code is being generated in a static method or not.
31590 * cs-parser.jay: DecomposeQI, new function that replaces the old
31591 QualifiedIdentifier. Now we always decompose the assembled
31592 strings from qualified_identifier productions into a group of
31595 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31597 * rootcontext.cs: Deal with field-less struct types correctly now
31598 by passing the size option to Define Type.
31600 * class.cs: Removed hack that created one static field.
31602 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31604 * statement.cs: Moved most of the code generation here.
31606 2001-10-09 Ravi Pratap <ravi@ximian.com>
31608 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31611 (ElementAccess): Remove useless bits for now - keep checks as the spec
31614 2001-10-08 Ravi Pratap <ravi@ximian.com>
31616 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31617 and start performing checks according to the spec.
31619 2001-10-07 Ravi Pratap <ravi@ximian.com>
31621 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31622 rank_specifiers instead.
31624 (rank_specifiers): Change the order in which the rank specifiers are stored
31626 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31628 * expression.cs (ElementAccess): Implement the LValue interface too.
31630 2001-10-06 Ravi Pratap <ravi@ximian.com>
31632 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31633 except that user defined conversions are not included.
31635 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31636 perform the conversion of the return type, if necessary.
31638 (New::DoResolve): Check whether we are creating an array or an object
31639 and accordingly do the needful.
31641 (New::Emit): Same here.
31643 (New::DoResolve): Implement guts of array creation.
31645 (New::FormLookupType): Helper function.
31647 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31649 * codegen.cs: Removed most of the code generation here, and move the
31650 corresponding code generation bits to the statement classes.
31652 Added support for try/catch/finalize and throw.
31654 * cs-parser.jay: Added support for try/catch/finalize.
31656 * class.cs: Catch static methods having the flags override,
31657 virtual or abstract.
31659 * expression.cs (UserCast): This user cast was not really doing
31660 what it was supposed to do. Which is to be born in fully resolved
31661 state. Parts of the resolution were being performed at Emit time!
31665 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31667 * expression.cs: Implicity convert the result from UserCast.
31669 2001-10-05 Ravi Pratap <ravi@ximian.com>
31671 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31672 prevented it from working correctly.
31674 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31675 merely ConvertImplicit.
31677 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31679 * typemanager.cs: Make the LookupTypeContainer function static,
31680 and not per-instance.
31682 * class.cs: Make static FindMembers (the one that takes a Type
31685 * codegen.cs: Add EmitForeach here.
31687 * cs-parser.jay: Make foreach a toplevel object instead of the
31688 inline expansion, as we need to perform semantic analysis on it.
31690 2001-10-05 Ravi Pratap <ravi@ximian.com>
31692 * expression.cs (Expression::ImplicitUserConversion): Rename to
31693 UserDefinedConversion.
31695 (Expression::UserDefinedConversion): Take an extra argument specifying
31696 whether we look for explicit user conversions too.
31698 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31700 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31702 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31703 with the appropriate arguments.
31705 * cs-parser.jay (cast_expression): Record location too.
31707 * expression.cs (Cast): Record location info.
31709 (Expression::ConvertExplicit): Take location argument.
31711 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31712 to determine if we are doing explicit conversions.
31714 (UserCast::Emit): Update accordingly.
31716 (Expression::ConvertExplicit): Report an error if everything fails.
31718 * ../errors/cs0030.cs : Add.
31720 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31722 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31723 virtual and newslot bits.
31725 * class.cs (TypeContainer::RegisterRequiredImplementations):
31726 Record methods we need.
31728 (TypeContainer::MakeKey): Helper function to make keys for
31729 MethodBases, since the Methodbase key is useless.
31731 (TypeContainer::Populate): Call RegisterRequiredImplementations
31732 before defining the methods.
31734 Create a mapping for method_builders_to_methods ahead of time
31735 instead of inside a tight loop.
31737 (::RequireMethods): Accept an object as the data to set into the
31738 hashtable so we can report interface vs abstract method mismatch.
31740 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31742 * report.cs: Make all of it static.
31744 * rootcontext.cs: Drop object_type and value_type computations, as
31745 we have those in the TypeManager anyways.
31747 Drop report instance variable too, now it is a global.
31749 * driver.cs: Use try/catch on command line handling.
31751 Add --probe option to debug the error reporting system with a test
31754 * report.cs: Add support for exiting program when a probe
31755 condition is reached.
31757 2001-10-03 Ravi Pratap <ravi@ximian.com>
31759 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31760 we do a forcible conversion regardless of type, to check if
31761 ForceConversion returns a null.
31763 (Binary::error19): Use location to report error.
31765 (Unary::error23): Use location here too.
31767 * ../errors/cs0019.cs : Check in.
31769 * ../errors/cs0023.cs : Check in.
31771 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31772 case of a non-null MethodInfo object with a length of 0 !
31774 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31775 an applicable member - according to the spec :-)
31776 Also fix logic to find members in base types.
31778 (Unary::ResolveOperator): Same here.
31780 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31781 as I was getting thoroughly confused between this and error19 :-)
31783 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31784 (::FindMostEncompassedType): Implement.
31785 (::FindMostEncompassingType): Implement.
31786 (::StandardConversionExists): Implement.
31788 (UserImplicitCast): Re-vamp. We now need info about most specific
31789 source and target types so that we can do the necessary conversions.
31791 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31792 mathematical union with no duplicates.
31794 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31796 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31797 in order from base classes to child classes, so that we can in
31798 child classes look up in our parent for method names and
31799 attributes (required for handling abstract, virtual, new, override
31800 constructs: we need to instrospect our base class, and if we dont
31801 populate the classes in order, the introspection might be
31802 incorrect. For example, a method could query its parent before
31803 the parent has any methods and would determine that the parent has
31804 no abstract methods (while it could have had them)).
31806 (RootContext::CreateType): Record the order in which we define the
31809 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31811 * class.cs (TypeContainer::Populate): Also method definitions can
31812 fail now, keep track of this.
31814 (TypeContainer::FindMembers): Implement support for
31815 DeclaredOnly/noDeclaredOnly flag.
31817 (Constructor::Emit) Return the ConstructorBuilder.
31819 (Method::Emit) Return the MethodBuilder.
31820 Check for abstract or virtual methods to be public.
31822 * rootcontext.cs (RootContext::CreateType): Register all the
31823 abstract methods required for the class to be complete and the
31824 interface methods that must be implemented.
31826 * cs-parser.jay: Report error 501 (method requires body if it is
31827 not marked abstract or extern).
31829 * expression.cs (TypeOf::Emit): Implement.
31831 * typemanager.cs: runtime_handle_type, new global type.
31833 * class.cs (Property::Emit): Generate code for properties.
31835 2001-10-02 Ravi Pratap <ravi@ximian.com>
31837 * expression.cs (Unary::ResolveOperator): Find operators on base type
31838 too - we now conform exactly to the spec.
31840 (Binary::ResolveOperator): Same here.
31842 * class.cs (Operator::Define): Fix minor quirk in the tests.
31844 * ../errors/cs0215.cs : Added.
31846 * ../errors/cs0556.cs : Added.
31848 * ../errors/cs0555.cs : Added.
31850 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31852 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31853 single integer which is really efficient
31855 2001-10-01 Ravi Pratap <ravi@ximian.com>
31857 * expression.cs (Expression::ImplicitUserConversion): Use location
31858 even in the case when we are examining True operators.
31860 * class.cs (Operator::Define): Perform extensive checks to conform
31861 with the rules for operator overloading in the spec.
31863 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31864 some of the other conversions mentioned in the spec.
31866 * typemanager.cs (array_type): New static member for the System.Array built-in
31869 (cloneable_interface): For System.ICloneable interface.
31871 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31872 we start resolving the tree and populating types.
31874 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31876 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31878 * expression.cs (Expression::ExprClassFromMemberInfo,
31879 Expression::Literalize): Create literal expressions from
31880 FieldInfos which are literals.
31882 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31883 type casts, because they were wrong. The test suite in tests
31886 (ImplicitNumericConversion): ushort to ulong requires a widening
31889 Int32 constant to long requires widening cast as well.
31891 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31892 for integers because the type on the stack is not i4.
31894 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31896 * expression.cs (report118): require location argument.
31898 * parameter.cs: Do not dereference potential null value.
31900 * class.cs: Catch methods that lack the `new' keyword when
31901 overriding a name. Report warnings when `new' is used without
31902 anything being there to override.
31904 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31906 * class.cs: Only add constructor to hashtable if it is non-null
31907 (as now constructors can fail on define).
31909 (TypeManager, Class, Struct): Take location arguments.
31911 Catch field instance initialization in structs as errors.
31913 accepting_filter: a new filter for FindMembers that is static so
31914 that we dont create an instance per invocation.
31916 (Constructor::Define): Catch errors where a struct constructor is
31919 * cs-parser.jay: Pass location information for various new
31922 * delegate.cs (Delegate): take a location argument.
31924 * driver.cs: Do not call EmitCode if there were problesm in the
31925 Definition of the types, as many Builders wont be there.
31927 * decl.cs (Decl::Decl): Require a location argument.
31929 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31930 into integers, and find the most appropiate integer for it.
31932 * literal.cs: Implement ULongLiteral.
31934 * rootcontext.cs: Provide better information about the location of
31935 failure when CreateType fails.
31937 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31939 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31942 * expression.cs (Binary::CheckShiftArguments): Add missing type
31944 (Binary::ResolveOperator): Add type to the logical and and logical
31945 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31948 (Binary::DoNumericPromotions): In the case where either argument
31949 is ulong (and most signed types combined with ulong cause an
31950 error) perform implicit integer constant conversions as well.
31952 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31954 * expression.cs (UserImplicitCast): Method should always be
31956 (Invocation::BetterConversion): Simplified test for IntLiteral.
31958 (Expression::ImplicitNumericConversion): Split this routine out.
31959 Put the code that performs implicit constant integer conversions
31962 (Expression::Resolve): Become a wrapper around DoResolve so we can
31963 check eclass and type being set after resolve.
31965 (Invocation::Badness): Remove this dead function
31967 (Binary::ResolveOperator): Do not compute the expensive argumnets
31968 unless we have a union for it.
31970 (Probe::Emit): Is needs to do an isinst and then
31971 compare against null.
31973 (::CanConvert): Added Location argument. If the Location argument
31974 is null (Location.Null), then we do not report errors. This is
31975 used by the `probe' mechanism of the Explicit conversion. We do
31976 not want to generate an error for something that the user
31977 explicitly requested to be casted. But the pipeline for an
31978 explicit cast first tests for potential implicit casts.
31980 So for now, if the Location is null, it means `Probe only' to
31981 avoid adding another argument. Might have to revise this
31984 (ClassCast): New class used to type cast objects into arbitrary
31985 classes (used in Explicit Reference Conversions).
31987 Implement `as' as well.
31989 Reverted all the patches from Ravi below: they were broken:
31991 * The use of `level' as a mechanism to stop recursive
31992 invocations is wrong. That was there just to catch the
31993 bug with a strack trace but not as a way of addressing
31996 To fix the problem we have to *understand* what is going
31997 on and the interactions and come up with a plan, not
31998 just get things going.
32000 * The use of the type conversion cache that I proposed
32001 last night had an open topic: How does this work across
32002 protection domains. A user defined conversion might not
32003 be public in the location where we are applying the
32004 conversion, a different conversion might be selected
32005 (ie, private A->B (better) but public B->A (worse),
32006 inside A, A->B applies, but outside it, B->A will
32009 * On top of that (ie, even if the above is solved),
32010 conversions in a cache need to be abstract. Ie, `To
32011 convert from an Int to a Short use an OpcodeCast', not
32012 `To convert from an Int to a Short use the OpcodeCast on
32013 the variable 5' (which is what this patch was doing).
32015 2001-09-28 Ravi Pratap <ravi@ximian.com>
32017 * expression.cs (Invocation::ConversionExists): Re-write to use
32018 the conversion cache
32020 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
32021 cache all conversions done, not just user-defined ones.
32023 (Invocation::BetterConversion): The real culprit. Use ConversionExists
32024 to determine if a conversion exists instead of acutually trying to
32025 perform the conversion. It's faster too.
32027 (Expression::ConvertExplicit): Modify to use ConversionExists to check
32028 and only then attempt the implicit conversion.
32030 2001-09-28 Ravi Pratap <ravi@ximian.com>
32032 * expression.cs (ConvertImplicit): Use a cache for conversions
32033 already found. Check level of recursion and bail out if necessary.
32035 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32037 * typemanager.cs (string_concat_string_string, string_concat_object_object):
32038 Export standard methods that we expect for string operations.
32040 * statement.cs (Block::UsageWarning): Track usage of variables and
32041 report the errors for not used variables.
32043 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
32046 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32048 * codegen.cs: remove unnneded code
32050 * expression.cs: Removed BuiltinTypeAccess class
32052 Fix the order in which implicit conversions are
32055 The previous fixed dropped support for boxed conversions (adding a
32056 test to the test suite now)
32058 (UserImplicitCast::CanConvert): Remove test for source being null,
32059 that code is broken. We should not feed a null to begin with, if
32060 we do, then we should track the bug where the problem originates
32061 and not try to cover it up here.
32063 Return a resolved expression of type UserImplicitCast on success
32064 rather than true/false. Ravi: this is what I was talking about,
32065 the pattern is to use a static method as a "constructor" for
32068 Also, do not create arguments until the very last minute,
32069 otherwise we always create the arguments even for lookups that
32070 will never be performed.
32072 (UserImplicitCast::Resolve): Eliminate, objects of type
32073 UserImplicitCast are born in a fully resolved state.
32075 * typemanager.cs (InitCoreTypes): Init also value_type
32076 (System.ValueType).
32078 * expression.cs (Cast::Resolve): First resolve the child expression.
32080 (LValue): Add new method AddressOf to be used by
32083 Change the argument of Store to take an EmitContext instead of an
32084 ILGenerator, because things like FieldExpr need to be able to call
32085 their children expression to generate the instance code.
32087 (Expression::Error, Expression::Warning): Sugar functions for
32090 (Expression::MemberLookup): Accept a TypeContainer instead of a
32091 Report as the first argument.
32093 (Expression::ResolvePrimary): Killed. I still want to improve
32094 this as currently the code is just not right.
32096 (Expression::ResolveMemberAccess): Simplify, but it is still
32099 (Unary::Resolve): Catch errors in AddressOf operators.
32101 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
32102 index to a byte for the short-version, or the compiler will choose
32103 the wrong Emit call, which generates the wrong data.
32105 (ParameterReference::Emit, ::Store): same.
32107 (FieldExpr::AddressOf): Implement.
32109 * typemanager.cs: TypeManager: made public variable instead of
32112 * driver.cs: document --fatal.
32114 * report.cs (ErrorMessage, WarningMessage): new names for the old
32115 Error and Warning classes.
32117 * cs-parser.jay (member_access): Turn built-in access to types
32118 into a normal simplename
32120 2001-09-27 Ravi Pratap <ravi@ximian.com>
32122 * expression.cs (Invocation::BetterConversion): Fix to cope
32123 with q being null, since this was introducing a bug.
32125 * expression.cs (ConvertImplicit): Do built-in conversions first.
32127 2001-09-27 Ravi Pratap <ravi@ximian.com>
32129 * expression.cs (UserImplicitCast::Resolve): Fix bug.
32131 2001-09-27 Ravi Pratap <ravi@ximian.com>
32133 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
32134 I had introduced long ago (what's new ?).
32136 * expression.cs (UserImplicitCast::CanConvert): Static method to do
32137 the work of all the checking.
32138 (ConvertImplicit): Call CanConvert and only then create object if necessary.
32139 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
32141 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
32142 that is the right way.
32144 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
32145 overloading resolution. Use everywhere instead of cutting and pasting code.
32147 (Binary::ResolveOperator): Use MakeUnionSet.
32149 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
32150 we have to convert to bool types. Not complete yet.
32152 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32154 * typemanager.cs (TypeManager::CSharpName): support ushort.
32156 * expression.cs (Expression::TryImplicitIntConversion): Attempts
32157 to provide an expression that performsn an implicit constant int
32158 conversion (section 6.1.6).
32159 (Expression::ConvertImplicitRequired): Reworked to include
32160 implicit constant expression conversions.
32162 (Expression::ConvertNumericExplicit): Finished.
32164 (Invocation::Emit): If InstanceExpression is null, then it means
32165 that we perform a call on this.
32167 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32169 * expression.cs (Unary::Emit): Remove some dead code.
32170 (Probe): Implement Resolve and Emit for `is'.
32171 (Expression::ConvertImplicitRequired): Attempt to do constant
32172 expression conversions here. Maybe should be moved to
32173 ConvertImplicit, but I am not sure.
32174 (Expression::ImplicitLongConstantConversionPossible,
32175 Expression::ImplicitIntConstantConversionPossible): New functions
32176 that tell whether is it possible to apply an implicit constant
32177 expression conversion.
32179 (ConvertNumericExplicit): Started work on explicit numeric
32182 * cs-parser.jay: Update operator constants.
32184 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32185 (Parameters::GetSignature): Hook up VerifyArgs here.
32186 (Parameters::VerifyArgs): Verifies that no two arguments have the
32189 * class.cs (Operator): Update the operator names to reflect the
32190 ones that the spec expects (as we are just stringizing the
32193 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32194 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32195 previous usage did only work for our methods.
32196 (Expression::ConvertImplicit): Handle decimal implicit numeric
32197 conversions as well.
32198 (Expression::InternalTypeConstructor): Used to invoke constructors
32199 on internal types for default promotions.
32201 (Unary::Emit): Implement special handling for the pre/post
32202 increment/decrement for overloaded operators, as they need to have
32203 the same semantics as the other operators.
32205 (Binary::ResolveOperator): ditto.
32206 (Invocation::ConversionExists): ditto.
32207 (UserImplicitCast::Resolve): ditto.
32209 2001-09-26 Ravi Pratap <ravi@ximian.com>
32211 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32212 operator, return after emitting body. Regression tests pass again !
32214 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32215 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32216 (Invocation::OverloadResolve): Ditto.
32217 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32219 * everywhere : update calls to the above methods accordingly.
32221 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32223 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32225 * expression.cs (ExpressionStatement): New base class used for
32226 expressions that can appear in statements, so that we can provide
32227 an alternate path to generate expression that do not leave a value
32230 (Expression::Emit, and all the derivatives): We no longer return
32231 whether a value is left on the stack or not. Every expression
32232 after being emitted leaves a single value on the stack.
32234 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32235 facilties of ExpressionStatement if possible.
32237 * cs-parser.jay: Update statement_expression.
32239 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32241 * driver.cs: Change the wording of message
32243 2001-09-25 Ravi Pratap <ravi@ximian.com>
32245 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32246 the type of the expression to the return type of the method if
32247 we have an overloaded operator match ! The regression tests pass again !
32248 (Unary::ResolveOperator): Ditto.
32250 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32251 to find "op_Implicit", not "implicit" ;-)
32252 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32253 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32255 * everywhere : Correct calls to the above accordingly.
32257 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32258 (ConvertImplicit): Do user-defined conversion if it exists.
32260 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32262 * assign.cs: track location.
32263 (Resolve): Use implicit conversions on assignment.
32265 * literal.cs: Oops. Not good, Emit of short access values should
32266 pass (Bytes) or the wrong argument will be selected.
32268 * expression.cs (Unary::Emit): Emit code for -expr.
32270 (Unary::ResolveOperator): Handle `Substract' for non-constants
32271 (substract from zero from the non-constants).
32272 Deal with Doubles as well.
32274 (Expression::ConvertImplicitRequired): New routine that reports an
32275 error if no implicit conversion exists.
32277 (Invocation::OverloadResolve): Store the converted implicit
32278 expressions if we make them
32280 2001-09-24 Ravi Pratap <ravi@ximian.com>
32282 * class.cs (ConstructorInitializer): Take a Location argument.
32283 (ConstructorBaseInitializer): Same here.
32284 (ConstructorThisInitializer): Same here.
32286 * cs-parser.jay : Update all calls accordingly.
32288 * expression.cs (Unary, Binary, New): Take location argument.
32289 Update accordingly everywhere.
32291 * cs-parser.jay : Update all calls to the above to take a location
32294 * class.cs : Ditto.
32296 2001-09-24 Ravi Pratap <ravi@ximian.com>
32298 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32299 (Invocation::BetterConversion): Same here
32300 (Invocation::ConversionExists): Ditto.
32302 (Invocation::ConversionExists): Implement.
32304 2001-09-22 Ravi Pratap <ravi@ximian.com>
32306 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32307 Also take an additional TypeContainer argument.
32309 * All over : Pass in TypeContainer as argument to OverloadResolve.
32311 * typemanager.cs (CSharpName): Update to check for the string type and return
32314 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32317 2001-09-21 Ravi Pratap <ravi@ximian.com>
32319 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32320 (Invocation::BetterFunction): Implement.
32321 (Invocation::BetterConversion): Implement.
32322 (Invocation::ConversionExists): Skeleton, no implementation yet.
32324 Okay, things work fine !
32326 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32328 * typemanager.cs: declare and load enum_type, delegate_type and
32331 * expression.cs (Expression::Emit): Now emit returns a value that
32332 tells whether a value is left on the stack or not. This strategy
32333 might be reveted tomorrow with a mechanism that would address
32334 multiple assignments.
32335 (Expression::report118): Utility routine to report mismatches on
32338 (Unary::Report23): Report impossible type/operator combination
32341 (Unary::IsIncrementableNumber): Whether the type can be
32342 incremented or decremented with add.
32343 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32345 (Unary::ResolveOperator): Implement ++, !, ~,
32347 (Invocation::Emit): Deal with new Emit convetion.
32349 * All Expression derivatives: Updated their Emit method to return
32350 whether they leave values on the stack or not.
32352 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32353 stack for expressions that are statements.
32355 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32357 * expression.cs (LValue): New interface. Must be implemented by
32359 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32362 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32363 interface for generating code, simplifies the code.
32365 2001-09-20 Ravi Pratap <ravi@ximian.com>
32367 * expression.cs (everywhere): Comment out return statements in ::Resolve
32368 methods to avoid the warnings.
32370 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32372 * driver.cs (parse): Report error 2001 if we can not open the
32375 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32378 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32381 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32382 otherwise nested blocks end up with the same index.
32384 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32386 * expression.cs: Instead of having FIXMEs in the Resolve
32387 functions, throw exceptions so it is obvious that we are facing a
32390 * cs-parser.jay (invocation_expression): Pass Location information.
32392 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32393 Use a basename for those routines because .NET does not like paths
32396 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32399 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32401 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32402 are loading the correct data types (throws an exception if not).
32403 (TypeManager::InitCoreTypes): Use CoreLookupType
32405 * expression.cs (Unary::ResolveOperator): return the child
32406 expression for expressions which are just +expr.
32407 (Unary::ResolveOperator): Return negative literals for -LITERAL
32408 expressions (otherwise they are Unary {Literal}).
32409 (Invocation::Badness): Take into account `Implicit constant
32410 expression conversions'.
32412 * literal.cs (LongLiteral): Implement long literal class.
32413 (IntLiteral): export the `Value' of the intliteral.
32415 2001-09-19 Ravi Pratap <ravi@ximian.com>
32417 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32419 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32420 instead of 'Operator'
32422 * expression.cs (Binary::ResolveOperator): Update accordingly.
32423 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32426 * cs-parser.jay (unary_expression): Update to use the new names.
32428 * gen-treedump.cs (GetUnary): Same here.
32430 * expression.cs (Unary::Resolve): Implement.
32431 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32432 operators are found instead of making noise ;-)
32433 (Unary::ResolveOperator): New method to do precisely the same thing which
32434 Binary::ResolveOperator does for Binary expressions.
32435 (Unary.method, .Arguments): Add.
32436 (Unary::OperName): Implement.
32437 (Unary::ForceConversion): Copy and Paste !
32439 * class.cs (Operator::Define): Fix a small bug for the case when we have
32442 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32443 for the inbuilt operators. Only overloading works for now ;-)
32445 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32447 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32448 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32450 * expression.cs (This::Emit): Implement.
32451 (This::Resolve): Implement.
32452 (TypeOf:Resolve): Implement.
32453 (Expression::ResolveSimpleName): Add an implicit this to instance
32455 (MemberAccess::Resolve): Deal with Parameters and Fields.
32456 Bind instance variable to Field expressions.
32457 (FieldExpr::Instance): New field used to track the expression that
32458 represents the object instance.
32459 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32461 (FieldExpr::Emit): Implement.
32463 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32464 the last instruction contains a return opcode to avoid generating
32465 the last `ret' instruction (this generates correct code, and it is
32466 nice to pass the peverify output).
32468 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32469 initializer for static and instance variables.
32470 (Constructor::Emit): Allow initializer to be null in the case of
32471 static constructors. Only emit initializer for instance
32474 (TypeContainer::FindMembers): Return a null array if there are no
32477 Also fix the code for the MemberTypes.Method branch, as it was not
32478 scanning that for operators (or tried to access null variables before).
32480 * assign.cs (Assign::Emit): Handle instance and static fields.
32484 * driver.cs: Stop compilation if there are parse errors.
32486 * cs-parser.jay (constructor_declaration): Provide default base
32487 initializer for non-static constructors.
32488 (constructor_declarator): Do not provide a default base
32489 initializers if none was specified.
32490 Catch the fact that constructors should not have parameters.
32492 * class.cs: Do not emit parent class initializers for static
32493 constructors, that should be flagged as an error.
32495 2001-09-18 Ravi Pratap <ravi@ximian.com>
32497 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32498 Move back code into TypeContainer::Populate.
32500 2001-09-18 Ravi Pratap <ravi@ximian.com>
32502 * class.cs (TypeContainer::AddConstructor): Fix the check to
32503 compare against Name, not Basename.
32504 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32506 * cs-parser.jay : Update accordingly.
32508 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32509 for methods, don't forget to look into the operators too.
32510 (RegisterMethodBuilder): Helper method to take care of this for
32511 methods, constructors and operators.
32512 (Operator::Define): Completely revamp.
32513 (Operator.OperatorMethod, MethodName): New fields.
32514 (TypeContainer::Populate): Move the registering of builders into
32515 RegisterMethodBuilder.
32516 (Operator::Emit): Re-write.
32518 * expression.cs (Binary::Emit): Comment out code path to emit method
32519 invocation stuff for the case when we have a user defined operator. I am
32520 just not able to get it right !
32522 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32524 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32527 (Expression::MemberLookup): Provide a version that allows to
32528 specify the MemberTypes and BindingFlags.
32530 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32531 so it was not fetching variable information from outer blocks.
32533 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32534 Beforefieldinit as it was buggy.
32536 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32537 that Ravi put here.
32539 * class.cs (Constructor::Emit): Only emit if block is not null.
32540 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32541 deal with this by semantically definining it as if the user had
32544 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32545 constructors as we now "emit" them at a higher level.
32547 (TypeContainer::DefineDefaultConstructor): Used to define the
32548 default constructors if none was provided.
32550 (ConstructorInitializer): Add methods Resolve and Emit.
32552 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32554 2001-09-17 Ravi Pratap <ravi@ximian.com>
32556 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32557 the default constructor builder with our hashtable for methodbuilders
32560 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32561 and argument_count is 0 in which case we have a match.
32562 (Binary::ResolveOperator): More null checking and miscellaneous coding
32565 2001-09-17 Ravi Pratap <ravi@ximian.com>
32567 * rootcontext.cs (IsNameSpace): Compare against null.
32569 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32571 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32572 and Unary::Operator.
32574 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32577 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32578 we have overloaded operators.
32579 (Binary::ResolveOperator): Implement the part which does the operator overload
32582 * class.cs (Operator::Emit): Implement.
32583 (TypeContainer::Emit): Emit the operators we have too.
32585 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32586 the case when we have a user-defined operator.
32588 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32590 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32592 2001-09-16 Ravi Pratap <ravi@ximian.com>
32594 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32595 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32596 (Constructor::Emit): Implement.
32597 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32598 if we have no work to do.
32599 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32602 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32603 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32605 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32608 2001-09-15 Ravi Pratap <ravi@ximian.com>
32610 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32612 (Tree::RecordNamespace): Method to do what the name says ;-)
32613 (Tree::Namespaces): Property to get at the namespaces hashtable.
32615 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32618 * rootcontext.cs (IsNamespace): Fixed it :-)
32620 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32622 * class.cs (TypeContainer::FindMembers): Add support for
32624 (MethodCore): New class that encapsulates both the shared aspects
32625 of a Constructor and a Method.
32626 (Method, Constructor): Factored pieces into MethodCore.
32628 * driver.cs: Added --fatal which makes errors throw exceptions.
32629 Load System assembly as well as part of the standard library.
32631 * report.cs: Allow throwing exceptions on errors for debugging.
32633 * modifiers.cs: Do not use `parent', instead use the real type
32634 container to evaluate permission settings.
32636 * class.cs: Put Ravi's patch back in. He is right, and we will
32637 have to cope with the
32639 2001-09-14 Ravi Pratap <ravi@ximian.com>
32641 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32642 FamORAssem, not FamANDAssem.
32644 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32646 * driver.cs: Added --parse option that only parses its input files
32649 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32650 incorrect. IsTopLevel is not used to tell whether an object is
32651 root_types or not (that can be achieved by testing this ==
32652 root_types). But to see if this is a top-level *class* (not
32653 necessarly our "toplevel" container).
32655 2001-09-14 Ravi Pratap <ravi@ximian.com>
32657 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32658 parent instead of a direct call to GetType.
32660 2001-09-14 Ravi Pratap <ravi@ximian.com>
32662 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32663 Modifiers.TypeAttr. This should just be a call to that method.
32665 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32666 object so that we can determine if we are top-level or not.
32668 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32671 * enum.cs (Enum::Define): Ditto.
32673 * modifiers.cs (FieldAttr): Re-write.
32675 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32676 (TypeContainer::HaveStaticConstructor): New property to provide access
32677 to precisely that info.
32679 * modifiers.cs (MethodAttr): Re-write.
32680 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32682 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32683 of top-level types as claimed.
32685 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32687 * expression.cs (MemberLookup): Fruitless attempt to lookup
32688 constructors. Maybe I need to emit default constructors? That
32689 might be it (currently .NET emits this for me automatically).
32690 (Invocation::OverloadResolve): Cope with Arguments == null.
32691 (Invocation::EmitArguments): new function, shared by the new
32692 constructor and us.
32693 (Invocation::Emit): Handle static and instance methods. Emit
32694 proper call instruction for virtual or non-virtual invocations.
32695 (New::Emit): Implement.
32696 (New::Resolve): Implement.
32697 (MemberAccess:Resolve): Implement.
32698 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32699 to track instances.
32700 (FieldExpr::Resolve): Set type.
32702 * support.cs: Handle empty arguments.
32704 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32705 SimpleLookup): Auxiliary routines to help parse a qualifier
32708 Update qualifier_identifier rule.
32710 * codegen.cs: Removed debugging messages.
32712 * class.cs: Make this a global thing, this acts just as a "key" to
32713 objects that we might have around.
32715 (Populate): Only initialize method_builders_to_methods once.
32717 * expression.cs (PropertyExpr): Initialize type from the
32720 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32721 Resolve pattern. Attempt to implicitly convert value to boolean.
32724 * expression.cs: Set the type for the int32/int32 argument case.
32725 (Binary::ResolveOperator): Set the return type to boolean for
32726 comparission operators
32728 * typemanager.cs: Remove debugging print code.
32730 (Invocation::Resolve): resolve type.
32732 * class.cs: Allocate a MemberInfo of the correct size, as the code
32733 elsewhere depends on the test to reflect the correct contents.
32735 (Method::) Keep track of parameters, due to System.Reflection holes
32737 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32740 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32741 of the exact size and return that.
32743 (Class::LookupMethodByBuilder): New function that maps
32744 MethodBuilders to its methods. Required to locate the information
32745 on methods because System.Reflection bit us again.
32747 * support.cs: New file, contains an interface ParameterData and
32748 two implementations: ReflectionParameters and InternalParameters
32749 used to access Parameter information. We will need to grow this
32752 * expression.cs (Invocation::GetParameterData): implement a cache
32753 and a wrapper around the ParameterData creation for methods.
32754 (Invocation::OverloadResolve): Use new code.
32756 2001-09-13 Ravi Pratap <ravi@ximian.com>
32758 * class.cs (TypeContainer::EmitField): Remove and move into
32759 (Field::Define): here and modify accordingly.
32760 (Field.FieldBuilder): New member.
32761 (TypeContainer::Populate): Update accordingly.
32762 (TypeContainer::FindMembers): Implement.
32764 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32766 * statement.cs: (VariableInfo::VariableType): New field to be
32767 initialized with the full type once it is resolved.
32769 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32771 * parameter.cs (GetParameterInfo): Use a type cache to compute
32772 things only once, and to reuse this information
32774 * expression.cs (LocalVariableReference::Emit): Implement.
32775 (OpcodeCast::Emit): fix.
32777 (ParameterReference::Resolve): Implement.
32778 (ParameterReference::Emit): Implement.
32780 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32781 that are expressions need to stay as Expressions.
32783 * typemanager.cs (CSharpName): Returns the C# name of a type if
32786 * expression.cs (Expression::ConvertImplicit): New function that
32787 implements implicit type conversions.
32789 (Expression::ImplicitReferenceConversion): Implements implicit
32790 reference conversions.
32792 (EmptyCast): New type for transparent casts.
32794 (OpcodeCast): New type for casts of types that are performed with
32795 a sequence of bytecodes.
32797 (BoxedCast): New type used for casting value types into reference
32798 types. Emits a box opcode.
32800 (Binary::DoNumericPromotions): Implements numeric promotions of
32801 and computation of the Binary::Type.
32803 (Binary::EmitBranchable): Optimization.
32805 (Binary::Emit): Implement code emission for expressions.
32807 * typemanager.cs (TypeManager): Added two new core types: sbyte
32810 2001-09-12 Ravi Pratap <ravi@ximian.com>
32812 * class.cs (TypeContainer::FindMembers): Method which does exactly
32813 what Type.FindMembers does, only we don't have to use reflection. No
32814 implementation yet.
32816 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32817 typecontainer objects as we need to get at them.
32818 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32820 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32821 typecontainer object.
32823 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32824 of just a Report object.
32826 2001-09-11 Ravi Pratap <ravi@ximian.com>
32828 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32830 (TypeContainer::Populate): Now define the delegates of the type too.
32831 (TypeContainer.Delegates): Property to access the list of delegates defined
32834 * delegates.cs (Delegate::Define): Implement partially.
32836 * modifiers.cs (TypeAttr): Handle more flags.
32838 2001-09-11 Ravi Pratap <ravi@ximian.com>
32840 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32842 (Operator::Define): Re-write logic to get types by using the LookupType method
32843 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32844 (Indexer::Define): Ditto.
32845 (Event::Define): Ditto.
32846 (Property::Define): Ditto.
32848 2001-09-10 Ravi Pratap <ravi@ximian.com>
32850 * class.cs (TypeContainer::Populate): Now define operators too.
32851 (TypeContainer.Operators): New property to access the list of operators
32853 (Operator.OperatorMethodBuilder): New member to hold the method builder
32854 for the operator we are defining.
32855 (Operator::Define): Implement.
32857 2001-09-10 Ravi Pratap <ravi@ximian.com>
32859 * class.cs (Event::Define): Make the prefixes of the accessor methods
32860 addOn_ and removeOn_
32862 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32863 of the location being passed in too. Ideally, this should go later since all
32864 error reporting should be done through the Report object.
32866 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32867 (Populate): Iterate thru the indexers we have and define them too.
32868 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32869 for the get and set accessors.
32870 (Indexer::Define): Implement.
32872 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32874 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32875 my previous implementation, did not work.
32877 * typemanager.cs: Add a couple of missing types (the longs).
32879 * literal.cs: Use TypeManager.bool_type instead of getting it.
32881 * expression.cs (EventExpr): New kind of expressions.
32882 (Expressio::ExprClassFromMemberInfo): finish
32884 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32886 * assign.cs: Emit stores to static fields differently.
32888 2001-09-08 Ravi Pratap <ravi@ximian.com>
32890 * Merge in changes and adjust code to tackle conflicts. Backed out my
32891 code in Assign::Resolve ;-)
32893 2001-09-08 Ravi Pratap <ravi@ximian.com>
32895 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32896 instead Report.Error and also pass in the location.
32897 (CSharpParser::Lexer): New readonly property to return the reference
32898 to the Tokenizer object.
32899 (declare_local_variables): Use Report.Error with location instead of plain
32903 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32904 (Operator.CheckBinaryOperator): Ditto.
32906 * cs-parser.jay (operator_declarator): Update accordingly.
32908 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32909 (CheckBinaryOperator): Same here.
32911 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32912 on the name without any prefixes of namespace names etc. This is because we
32913 already might have something already fully qualified like
32914 'System.Console.WriteLine'
32916 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32918 2001-09-07 Ravi Pratap <ravi@ximian.com>
32920 * cs-tokenizer.cs (location): Return a string which also contains
32923 * expression.cs (ElementAccess): New class for expressions of the
32924 type 'element access.'
32925 (BaseAccess): New class for expressions of the type 'base access.'
32926 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32929 * cs-parser.jay (element_access): Implement action.
32930 (base_access): Implement actions.
32931 (checked_expression, unchecked_expression): Implement.
32933 * cs-parser.jay (local_variable_type): Correct and implement.
32934 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32936 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32938 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32939 name and the specifiers.
32941 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32943 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32944 making them all public ;-)
32946 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32949 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32951 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32953 (FieldExpr, PropertyExprs): New resolved expressions.
32954 (SimpleName::MemberStaticCheck): Perform static checks for access
32955 to non-static fields on static methods. Maybe this should be
32956 generalized for MemberAccesses.
32957 (SimpleName::ResolveSimpleName): More work on simple name
32960 * cs-parser.jay (primary_expression/qualified_identifier): track
32961 the parameter index.
32963 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32964 (EmitContext::EmitBoolExpression): Chain to expression generation
32965 instead of temporary hack.
32966 (::EmitStatementExpression): Put generic expression code generation.
32968 * assign.cs (Assign::Emit): Implement variable assignments to
32969 local variables, parameters and fields.
32971 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32973 * statement.cs (Block::GetVariableInfo): New method, returns the
32974 VariableInfo for a variable name in a block.
32975 (Block::GetVariableType): Implement in terms of GetVariableInfo
32977 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32978 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32980 2001-09-06 Ravi Pratap <ravi@ximian.com>
32982 * cs-parser.jay (operator_declaration): Continue on my quest : update
32983 to take attributes argument.
32984 (event_declaration): Ditto.
32985 (enum_declaration): Ditto.
32986 (indexer_declaration): Ditto.
32988 * class.cs (Operator::Operator): Update constructor accordingly.
32989 (Event::Event): Ditto.
32991 * delegate.cs (Delegate::Delegate): Same here.
32993 * enum.cs (Enum::Enum): Same here.
32995 2001-09-05 Ravi Pratap <ravi@ximian.com>
32997 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32999 * ../tests/cs0658.cs : New file to demonstrate error 0658.
33001 * attribute.cs (Attributes): New class to encapsulate all attributes which were
33002 being passed around as an arraylist.
33003 (Attributes::AddAttribute): Method to add attribute sections.
33005 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
33006 (struct_declaration): Update accordingly.
33007 (constant_declaration): Update.
33008 (field_declaration): Update.
33009 (method_header): Update.
33010 (fixed_parameter): Update.
33011 (parameter_array): Ditto.
33012 (property_declaration): Ditto.
33013 (destructor_declaration): Ditto.
33015 * class.cs (Struct::Struct): Update constructors accordingly.
33016 (Class::Class): Ditto.
33017 (Field::Field): Ditto.
33018 (Method::Method): Ditto.
33019 (Property::Property): Ditto.
33020 (TypeContainer::OptAttribute): update property's return type.
33022 * interface.cs (Interface.opt_attributes): New member.
33023 (Interface::Interface): Update to take the extra Attributes argument.
33025 * parameter.cs (Parameter::Parameter): Ditto.
33027 * constant.cs (Constant::Constant): Ditto.
33029 * interface.cs (InterfaceMemberBase): New OptAttributes field.
33030 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
33031 the attributes as a parameter.
33032 (InterfaceProperty): Update constructor call.
33033 (InterfaceEvent): Ditto.
33034 (InterfaceMethod): Ditto.
33035 (InterfaceIndexer): Ditto.
33037 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
33038 pass the attributes too.
33039 (interface_event_declaration): Ditto.
33040 (interface_property_declaration): Ditto.
33041 (interface_method_declaration): Ditto.
33042 (interface_declaration): Ditto.
33044 2001-09-05 Miguel de Icaza <miguel@ximian.com>
33046 * class.cs (Method::Define): Track the "static Main" definition to
33047 create an entry point.
33049 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
33050 EntryPoint if we find it.
33052 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
33053 (EmitContext::ig): Make this variable public.
33055 * driver.cs: Make the default output file be the first file name
33056 with the .exe extension.
33058 Detect empty compilations
33060 Handle various kinds of output targets. Handle --target and
33061 rename -t to --dumper.
33063 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
33064 methods inherited from Expression return now an Expression. This
33065 will is used during the tree rewriting as we resolve them during
33068 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
33069 the spec. Missing entirely is the information about
33070 accessability of elements of it.
33072 (Expression::ExprClassFromMemberInfo): New constructor for
33073 Expressions that creates a fully initialized Expression based on
33074 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
33077 (Invocation::Resolve): Begin implementing resolution of invocations.
33079 * literal.cs (StringLiteral): Implement Emit.
33081 2001-09-05 Ravi Pratap <ravi@ximian.com>
33083 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
33086 2001-09-04 Ravi Pratap <ravi@ximian.com>
33088 * cs-parser.jay (attribute_arguments): Implement actions.
33089 (attribute): Fix bug in production. Implement action.
33090 (attribute_list): Implement.
33091 (attribute_target): Implement.
33092 (attribute_target_specifier, opt_target_specifier): Implement
33093 (CheckAttributeTarget): New method to check if the attribute target
33095 (attribute_section): Implement.
33096 (opt_attributes): Implement.
33098 * attribute.cs : New file to handle attributes.
33099 (Attribute): Class to hold attribute info.
33101 * cs-parser.jay (opt_attribute_target_specifier): Remove production
33102 (attribute_section): Modify production to use 2 different rules to
33103 achieve the same thing. 1 s/r conflict down !
33104 Clean out commented, useless, non-reducing dimension_separator rules.
33106 * class.cs (TypeContainer.attributes): New member to hold list
33107 of attributes for a type.
33108 (Struct::Struct): Modify to take one more argument, the attribute list.
33109 (Class::Class): Ditto.
33110 (Field::Field): Ditto.
33111 (Method::Method): Ditto.
33112 (Property::Property): Ditto.
33114 * cs-parser.jay (struct_declaration): Update constructor call to
33115 pass in the attributes too.
33116 (class_declaration): Ditto.
33117 (constant_declaration): Ditto.
33118 (field_declaration): Ditto.
33119 (method_header): Ditto.
33120 (fixed_parameter): Ditto.
33121 (parameter_array): Ditto.
33122 (property_declaration): Ditto.
33124 * constant.cs (Constant::Constant): Update constructor similarly.
33125 Use System.Collections.
33127 * parameter.cs (Parameter::Parameter): Update as above.
33129 2001-09-02 Ravi Pratap <ravi@ximian.com>
33131 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
33132 (TypeContainer.delegates): New member to hold list of delegates.
33134 * cs-parser.jay (delegate_declaration): Implement the action correctly
33135 this time as I seem to be on crack ;-)
33137 2001-09-02 Miguel de Icaza <miguel@ximian.com>
33139 * rootcontext.cs (RootContext::IsNamespace): new function, used to
33140 tell whether an identifier represents a namespace.
33142 * expression.cs (NamespaceExpr): A namespace expression, used only
33143 temporarly during expression resolution.
33144 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
33145 utility functions to resolve names on expressions.
33147 2001-09-01 Miguel de Icaza <miguel@ximian.com>
33149 * codegen.cs: Add hook for StatementExpressions.
33151 * class.cs: Fix inverted test for static flag in methods.
33153 2001-09-02 Ravi Pratap <ravi@ximian.com>
33155 * class.cs (Operator::CheckUnaryOperator): Correct error number used
33156 to make it coincide with MS' number.
33157 (Operator::CheckBinaryOperator): Ditto.
33159 * ../errors/errors.txt : Remove error numbers added earlier.
33161 * ../errors/cs1019.cs : Test case for error # 1019
33163 * ../errros/cs1020.cs : Test case for error # 1020
33165 * cs-parser.jay : Clean out commented cruft.
33166 (dimension_separators, dimension_separator): Comment out. Ostensibly not
33167 used anywhere - non-reducing rule.
33168 (namespace_declarations): Non-reducing rule - comment out.
33170 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
33171 with TypeContainer::AddEnum.
33173 * delegate.cs : New file for delegate handling classes.
33174 (Delegate): Class for declaring delegates.
33176 * makefile : Update.
33178 * cs-parser.jay (delegate_declaration): Implement.
33180 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33182 * class.cs (Event::Define): Implement.
33183 (Event.EventBuilder): New member.
33185 * class.cs (TypeContainer::Populate): Update to define all enums and events
33187 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33188 readonly fields for all these cases ?
33190 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33192 * class.cs (Property): Revamp to use the convention of making fields readonly.
33193 Accordingly modify code elsewhere.
33195 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33196 the Define method of the Property class.
33198 * class.cs : Clean up applied patch and update references to variables etc. Fix
33200 (TypeContainer::Populate): Update to define all the properties we have. Also
33201 define all enumerations.
33203 * enum.cs (Define): Implement.
33205 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33207 * cs-parser.jay (overloadable_operator): The semantic value is an
33208 enum of the Operator class.
33209 (operator_declarator): Implement actions.
33210 (operator_declaration): Implement.
33212 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33213 validity of definitions.
33214 (Operator::CheckBinaryOperator): Static method to check for binary operators
33215 (TypeContainer::AddOperator): New method to add an operator to a type.
33217 * cs-parser.jay (indexer_declaration): Added line to actually call the
33218 AddIndexer method so it gets added ;-)
33220 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33221 already taken care of by the MS compiler ?
33223 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33225 * class.cs (Operator): New class for operator declarations.
33226 (Operator::OpType): Enum for the various operators.
33228 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33230 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33231 ostensibly handle this in semantic analysis.
33233 * cs-parser.jay (general_catch_clause): Comment out
33234 (specific_catch_clauses, specific_catch_clause): Ditto.
33235 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33236 (catch_args, opt_catch_args): New productions.
33237 (catch_clause): Rewrite to use the new productions above
33238 (catch_clauses): Modify accordingly.
33239 (opt_catch_clauses): New production to use in try_statement
33240 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33241 and re-write the code in the actions to extract the specific and
33242 general catch clauses by being a little smart ;-)
33244 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33245 Hooray, try and catch statements parse fine !
33247 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33249 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33250 string from the hashtable of variables.
33252 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33253 I end up making that mistake ;-)
33254 (catch_clauses): Fixed gross error which made Key and Value of the
33255 DictionaryEntry the same : $1 !!
33257 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33259 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33261 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33262 when the add and remove accessors are specified.
33264 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33266 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33267 information about indexer_declarator.
33268 (indexer_declarator): Implement actions.
33269 (parsing_indexer): New local boolean used to keep track of whether
33270 we are parsing indexers or properties. This is necessary because
33271 implicit_parameters come into picture even for the get accessor in the
33272 case of an indexer.
33273 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33275 * class.cs (Indexer): New class for indexer declarations.
33276 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33277 (TypeContainer::indexers): New member to hold list of indexers for the
33280 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33282 * cs-parser.jay (add_accessor_declaration): Implement action.
33283 (remove_accessor_declaration): Implement action.
33284 (event_accessors_declaration): Implement
33285 (variable_declarators): swap statements for first rule - trivial.
33287 * class.cs (Event): New class to hold information about event
33289 (TypeContainer::AddEvent): New method to add an event to a type
33290 (TypeContainer::events): New member to hold list of events.
33292 * cs-parser.jay (event_declaration): Implement actions.
33294 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33296 * cs-parser.jay (dim_separators): Implement. Make it a string
33297 concatenating all the commas together, just as they appear.
33298 (opt_dim_separators): Modify accordingly
33299 (rank_specifiers): Update accordingly. Basically do the same
33300 thing - instead, collect the brackets here.
33301 (opt_rank_sepcifiers): Modify accordingly.
33302 (array_type): Modify to actually return the complete type string
33303 instead of ignoring the rank_specifiers.
33304 (expression_list): Implement to collect the expressions
33305 (variable_initializer): Implement. We make it a list of expressions
33306 essentially so that we can handle the array_initializer case neatly too.
33307 (variable_initializer_list): Implement.
33308 (array_initializer): Make it a list of variable_initializers
33309 (opt_array_initializer): Modify accordingly.
33311 * expression.cs (New::NType): Add enumeration to help us
33312 keep track of whether we have an object/delegate creation
33313 or an array creation.
33314 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33315 members to hold data about array creation.
33316 (New:New): Modify to update NewType
33317 (New:New): New Overloaded contructor for the array creation
33320 * cs-parser.jay (array_creation_expression): Implement to call
33321 the overloaded New constructor.
33323 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33325 * class.cs (TypeContainer::Constructors): Return member
33326 constructors instead of returning null.
33328 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33330 * typemanager.cs (InitCoreTypes): Initialize the various core
33331 types after we have populated the type manager with the user
33332 defined types (this distinction will be important later while
33333 compiling corlib.dll)
33335 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33336 on Expression Classification. Now all expressions have a method
33337 `Resolve' and a method `Emit'.
33339 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33340 generation from working. Also add some temporary debugging
33343 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33345 * codegen.cs: Lots of code generation pieces. This is only the
33346 beginning, will continue tomorrow with more touches of polish. We
33347 handle the fundamentals of if, while, do, for, return. Others are
33348 trickier and I need to start working on invocations soon.
33350 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33353 * codegen.cs (EmitContext): New struct, used during code
33354 emission to keep a context. Most of the code generation will be
33357 * cs-parser.jay: Add embedded blocks to the list of statements of
33358 this block. So code generation proceeds in a top down fashion.
33360 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33362 * statement.cs: Add support for multiple child blocks.
33364 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33366 * codegen.cs (EmitCode): New function, will emit the code for a
33367 Block of code given a TypeContainer and its ILGenerator.
33369 * statement.cs (Block): Standard public readonly optimization.
33370 (Block::Block constructors): Link children.
33371 (Block::Child): Child Linker.
33372 (Block::EmitVariables): Emits IL variable declarations.
33374 * class.cs: Drop support for MethodGroups here, delay until
33376 (Method::): Applied the same simplification that I did before, and
33377 move from Properties to public readonly fields.
33378 (Method::ParameterTypes): Returns the parameter types for the
33379 function, and implements a cache that will be useful later when I
33380 do error checking and the semantic analysis on the methods is
33382 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33383 and made a method, optional argument tells whether this is a class
33384 or a structure to apply the `has-this' bit.
33385 (Method::GetCallingConvention): Implement, returns the calling
33387 (Method::Define): Defines the type, a second pass is performed
33388 later to populate the methods.
33390 (Constructor::ParameterTypes): implement a cache similar to the
33391 one on Method::ParameterTypes, useful later when we do semantic
33394 (TypeContainer::EmitMethod): New method. Emits methods.
33396 * expression.cs: Removed MethodGroup class from here.
33398 * parameter.cs (Parameters::GetCallingConvention): new method.
33400 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33402 * class.cs (TypeContainer::Populate): Drop RootContext from the
33405 (Constructor::CallingConvention): Returns the calling convention.
33406 (Constructor::ParameterTypes): Returns the constructor parameter
33409 (TypeContainer::AddConstructor): Keep track of default constructor
33410 and the default static constructor.
33412 (Constructor::) Another class that starts using `public readonly'
33413 instead of properties.
33415 (Constructor::IsDefault): Whether this is a default constructor.
33417 (Field::) use readonly public fields instead of properties also.
33419 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33420 track of static constructors; If none is used, turn on
33421 BeforeFieldInit in the TypeAttributes.
33423 * cs-parser.jay (opt_argument_list): now the return can be null
33424 for the cases where there are no arguments.
33426 (constructor_declarator): If there is no implicit `base' or
33427 `this', then invoke the default parent constructor.
33429 * modifiers.cs (MethodAttr): New static function maps a set of
33430 modifiers flags into a MethodAttributes enum
33431 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33432 MethodAttr, TypeAttr to represent the various mappings where the
33433 modifiers are used.
33434 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33436 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33438 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33441 * interface.cs (PopulateIndexer): Implemented the code generator
33442 for interface indexers.
33444 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33446 * interface.cs (InterfaceMemberBase): Now we track the new status
33449 (PopulateProperty): Implement property population. Woohoo! Got
33450 Methods and Properties going today.
33452 Removed all the properties for interfaces, and replaced them with
33453 `public readonly' fields.
33455 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33457 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33458 initialize their hashtables/arraylists only when they are needed
33459 instead of doing this always.
33461 * parameter.cs: Handle refs and out parameters.
33463 * cs-parser.jay: Use an ArrayList to construct the arguments
33464 instead of the ParameterCollection, and then cast that to a
33467 * parameter.cs: Drop the use of ParameterCollection and use
33468 instead arrays of Parameters.
33470 (GetParameterInfo): Use the Type, not the Name when resolving
33473 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33475 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33476 and instead use public readonly fields.
33478 * class.cs: Put back walking code for type containers.
33480 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33482 * class.cs (MakeConstant): Code to define constants.
33484 * rootcontext.cs (LookupType): New function. Used to locate types
33487 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33489 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33490 this System.Reflection code is. Kudos to Microsoft
33492 * typemanager.cs: Implement a type cache and avoid loading all
33493 types at boot time. Wrap in LookupType the internals. This made
33494 the compiler so much faster. Wow. I rule!
33496 * driver.cs: Make sure we always load mscorlib first (for
33497 debugging purposes, nothing really important).
33499 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33500 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33502 * rootcontext.cs: Lookup types on their namespace; Lookup types
33503 on namespaces that have been imported using the `using' keyword.
33505 * class.cs (TypeContainer::TypeAttr): Virtualize.
33506 (Class::TypeAttr): Return attributes suitable for this bad boy.
33507 (Struct::TypeAttr): ditto.
33508 Handle nested classes.
33509 (TypeContainer::) Remove all the type visiting code, it is now
33510 replaced with the rootcontext.cs code
33512 * rootcontext.cs (GetClassBases): Added support for structs.
33514 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33516 * interface.cs, statement.cs, class.cs, parameter.cs,
33517 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33518 Drop use of TypeRefs, and use strings instead.
33520 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33524 * class.cs (Struct::Struct): set the SEALED flags after
33525 checking the modifiers.
33526 (TypeContainer::TypeAttr): new property, returns the
33527 TypeAttributes for a class.
33529 * cs-parser.jay (type_list): Oops, list production was creating a
33530 new list of base types.
33532 * rootcontext.cs (StdLib): New property.
33533 (GetInterfaceTypeByName): returns an interface by type name, and
33534 encapsulates error handling here.
33535 (GetInterfaces): simplified.
33536 (ResolveTree): Encapsulated all the tree resolution here.
33537 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33540 * driver.cs: Add support for --nostdlib, to avoid loading the
33541 default assemblies.
33542 (Main): Do not put tree resolution here.
33544 * rootcontext.cs: Beginning of the class resolution.
33546 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33548 * rootcontext.cs: Provide better error reporting.
33550 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33552 * rootcontext.cs (CreateInterface): Handle the case where there
33553 are no parent interfaces.
33555 (CloseTypes): Routine to flush types at the end.
33556 (CreateInterface): Track types.
33557 (GetInterfaces): Returns an array of Types from the list of
33558 defined interfaces.
33560 * typemanager.c (AddUserType): Mechanism to track user types (puts
33561 the type on the global type hash, and allows us to close it at the
33564 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33566 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33567 RecordInterface instead.
33569 * cs-parser.jay: Updated to reflect changes above.
33571 * decl.cs (Definition): Keep track of the TypeBuilder type that
33572 represents this type here. Not sure we will use it in the long
33573 run, but wont hurt for now.
33575 * driver.cs: Smaller changes to accomodate the new code.
33577 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33580 * rootcontext.cs (CreateInterface): New method, used to create
33581 the System.TypeBuilder type for interfaces.
33582 (ResolveInterfaces): new entry point to resolve the interface
33584 (CodeGen): Property, used to keep track of the code generator.
33586 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33588 * cs-parser.jay: Add a second production for delegate_declaration
33591 (enum_body): Put an opt_comma here instead of putting it on
33592 enum_body or enum_member_declarations so we can handle trailing
33593 commas on enumeration members. Gets rid of a shift/reduce.
33595 (type_list): Need a COMMA in the middle.
33597 (indexer_declaration): Tell tokenizer to recognize get/set
33599 * Remove old targets.
33601 * Re-add the parser target.
33603 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33605 * cs-parser.jay: Add precendence rules for a number of operators
33606 ot reduce the number of shift/reduce conflicts in the grammar.
33608 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33610 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33613 Get rid of old crufty code.
33615 * rootcontext.cs: Use this to keep track of the parsed
33616 representation and the defined types available to the program.
33618 * gen-treedump.cs: adjust for new convention.
33620 * type.cs: Split out the type manager, and the assembly builder
33623 * typemanager.cs: the type manager will live here now.
33625 * cil-codegen.cs: And the code generator here.
33627 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33629 * makefile: Fixed up for easy making.
33631 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33633 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33636 (unary_expression): Expand pre_increment_expression and
33637 post_decrement_expression to reduce a shift/reduce.
33639 2001-07-11 Simon Cozens
33641 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33643 Improve allow_keyword_as_indent name.
33645 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33647 * Adjustments for Beta2.
33649 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33651 * decl.cs: Added `Define' abstract method.
33652 (InTransit): new property, used to catch recursive definitions.
33654 * interface.cs: Implement `Define'.
33656 * modifiers.cs: Map Modifiers.constants to
33657 System.Reflection.TypeAttribute flags.
33659 * class.cs: Keep track of types and user-defined types.
33660 (BuilderInit): New method for creating an assembly
33661 (ResolveType): New function to launch the resolution process, only
33662 used by interfaces for now.
33664 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33665 that are inserted into the name space.
33667 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33669 * ARGH. I have screwed up my tree so many times due to the use of
33670 rsync rather than using CVS. Going to fix this at once.
33672 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33675 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33677 * Experiment successful: Use System.Type rather that our own
33680 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33682 * cs-parser.jay: Removed nsAliases from here.
33684 Use new namespaces, handle `using XXX;'
33686 * namespace.cs: Reimplemented namespace handling, use a recursive
33687 definition of the class. Now we can keep track of using clauses
33688 and catch invalid using clauses.
33690 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33692 * gen-treedump.cs: Adapted for all the renaming.
33694 * expression.cs (Expression): this class now has a Type property
33695 which returns an expression Type.
33697 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33698 `Type', as this has a different meaning now in the base
33700 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33702 * interface.cs, class.cs: Removed from all the sources the
33703 references to signature computation, as we can not do method
33704 signature computation during the parsing time, as we are not
33705 trying to solve at that point distinguishing:
33709 void a (NS.Blah x) {}
33712 Which depending on the context might be valid or not, as we do not
33713 know if Blah is the same thing as NS.Blah at that point.
33715 * Redid everything so the code uses TypeRefs now instead of
33716 Types. TypeRefs are just temporary type placeholders, that need
33717 to be resolved. They initially have a pointer to a string and the
33718 current scope in which they are used. This is used later by the
33719 compiler to resolve the reference to an actual Type.
33721 * DeclSpace is no longer a CIR.Type, and neither are
33722 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33723 are all DeclSpaces, but no Types.
33725 * type.cs (TypeRefManager): This implements the TypeRef manager,
33726 which keeps track of all the types that need to be resolved after
33727 the parsing has finished.
33729 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33731 * ARGH. We are going to have to store `foreach' as a class rather
33732 than resolving it, as we need to verify error 1579 after name
33733 resolution. *OR* we could keep a flag that says `This request to
33734 IEnumerator comes from a foreach statement' which we can then use
33735 to generate the error.
33737 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33739 * class.cs (TypeContainer.AddMethod): we now add methods to the
33740 MethodGroup instead of the method hashtable.
33742 * expression.cs: Add MethodGroup abstraction, which gets us one
33743 step closer to the specification in the way we handle method
33746 * cs-parser.jay (primary_expression): qualified_identifier now
33747 tried to match up an identifier to a local variable reference or
33748 to a parameter reference.
33750 current_local_parameters is now a parser global variable that
33751 points to the current parameters for the block, used during name
33754 (property_declaration): Now creates an implicit `value' argument to
33757 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33759 * parameter.cs: Do not use `param' arguments as part of the
33760 signature, per the spec.
33762 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33764 * decl.cs: Base class for classes, structs and interfaces. This
33765 is the "Declaration Space"
33767 * cs-parser.jay: Use CheckDef for checking declaration errors
33768 instead of having one on each function.
33770 * class.cs: Factor out some code for handling error handling in
33771 accordance to the "Declarations" section in the "Basic Concepts"
33772 chapter in the ECMA C# spec.
33774 * interface.cs: Make all interface member classes derive from
33775 InterfaceMemberBase.
33777 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33779 * Many things: all interfaces are parsed and generated in
33780 gen-treedump. Support for member variables, constructors,
33781 destructors, properties, constants is there.
33783 Beginning of the IL backend, but very little done, just there for
33786 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33788 * cs-parser.jay: Fix labeled statement.
33790 * cs-tokenizer.cs (escape): Escape " and ' always.
33791 ref_line, ref_name: keep track of the line/filename as instructed
33792 by #line by the compiler.
33795 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33797 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33798 to match the values in System.CodeDOM.
33800 Divid renamed to Divide.
33802 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33804 (Statements.set): remove.
33806 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33809 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33810 falseStatements always have valid values.
33812 * cs-parser.jay: Use System.CodeDOM now.