1 2004-06-24 Raja R Harinath <rharinath@novell.com>
3 * expression.cs (BetterConversion): Remove buggy special-case
4 handling of "implicit constant expression conversions". At this
5 point, we already know that the conversion is possible -- we're
6 only checking to see which is better.
8 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10 * cs-parser.jay: Added error CS0210 test.
12 2004-06-24 Marek Safar <marek.safar@seznam.cz>
14 * cs-parser.jay: Added error CS0134 test.
16 2004-06-24 Marek Safar <marek.safar@seznam.cz>
19 * cs-parser.jay: Added error CS0145 test.
21 2004-06-24 Marek Safar <marek.safar@seznam.cz>
23 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
25 2004-06-23 Ben Maurer <bmaurer@ximian.com>
27 * expression.cs (StackAlloc.Resolve): The argument may not
28 be a constant; deal with this case.
30 2004-06-23 Marek Safar <marek.safar@seznam.cz>
32 * attribute.cs (IndexerName_GetIndexerName): Renamed to
33 GetIndexerAttributeValue.
34 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
36 * class.cs (Indexer.Define): Added error tests for CS0415,
39 2004-06-23 Miguel de Icaza <miguel@ximian.com>
41 * attribute.cs (Attribute.Resolve): Keep field code in sync with
44 2004-06-23 Martin Baulig <martin@ximian.com>
46 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
47 neither return nor throw, reset the barrier as well. Fixes #60457.
49 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
51 * class.cs : EventAttributes is now set to None by default.
52 This fixes bug #60459.
54 2004-06-18 Marek Safar <marek.safar@seznam.cz>
57 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
58 Don't throw exception but return null (it's sufficient now).
60 2004-06-18 Marek Safar <marek.safar@seznam.cz>
62 * typemanager.cs (GetArgumentTypes): Faster implementation.
64 2004-06-18 Martin Baulig <martin@ximian.com>
66 * attribute.cs (Attribute.Resolve): Check whether we're an
67 EmptyCast which a Constant child. Fixes #60333.
69 2004-06-17 Ben Maurer <bmaurer@ximian.com>
71 * statement.cs (EmitCollectionForeach): Account for the fact that
72 not all valuetypes are in areas which we can take the address of.
73 For these variables, we store to a temporary variable. Also, make
74 sure that we dont emit a `callvirt' on a valuetype method.
76 2004-06-15 Marek Safar <marek.safar@seznam.cz>
78 * expression.cs (StackAlloc.DoReSolve): Added test for
79 negative parameter (CS0247).
81 2004-06-15 Marek Safar <marek.safar@seznam.cz>
84 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
86 2004-06-15 Marek Safar <marek.safar@seznam.cz>
89 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
92 2004-06-14 Marek Safar <marek.safar@seznam.cz>
94 Fix bug #58254 & cs1555.cs, cs1556.cs
95 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
97 2004-06-14 Marek Safar <marek.safar@seznam.cz>
99 * cs-parser.jay: Added error CS1669 test for indexers.
101 2004-06-13 Martin Baulig <martin@ximian.com>
103 Merged latest changes into gmcs. Please keep this comment in
104 here, it makes it easier for me to see what changed in MCS since
105 the last time I merged.
107 2004-06-11 Martin Baulig <martin@ximian.com>
109 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
110 call this twice: for params and varargs methods.
112 2004-06-11 Marek Safar <marek.safar@seznam.cz>
115 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
117 2004-06-11 Marek Safar <marek.safar@seznam.cz>
119 * attribute.cs (Attribute.GetValidTargets): Made public.
122 (AbstractPropertyEventMethod): New class for better code sharing.
123 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
125 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
127 2004-06-11 Raja R Harinath <rharinath@novell.com>
130 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
131 that the call to Resolve is part of a MemberAccess.
132 (Expression.Resolve): Use it for SimpleName resolution.
133 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
134 Add 'intermediate' boolean argument.
135 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
136 error message when the SimpleName can be resolved ambiguously
137 between an expression and a type.
138 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
140 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
141 call on the left-side.
143 2004-06-11 Marek Safar <marek.safar@seznam.cz>
146 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
148 2004-06-11 Marek Safar <marek.safar@seznam.cz>
150 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
152 2004-06-11 Martin Baulig <martin@ximian.com>
154 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
155 varargs methods if applicable.
157 2004-06-11 Martin Baulig <martin@ximian.com>
159 * expression.cs (Invocation.EmitCall): Don't use
160 `method.CallingConvention == CallingConventions.VarArgs' since the
161 method could also have `CallingConventions.HasThis'.
163 2004-06-11 Marek Safar <marek.safar@seznam.cz>
165 * class.cs (Event.GetSignatureForError): Implemented.
166 Fixed crash in error test cs3010.cs
168 2004-06-10 Miguel de Icaza <miguel@ximian.com>
170 * cs-tokenizer.cs: Change the way we track __arglist to be
171 consistent with the other keywords.
173 2004-06-09 Miguel de Icaza <miguel@ximian.com>
175 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
178 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
180 * codegen.cs: Check that all referenced assemblies have a strongname
181 before strongnaming the compiled assembly. If not report error CS1577.
182 Fix bug #56563. Patch by Jackson Harper.
183 * typemanager.cs: Added a method to return all referenced assemblies.
184 Fix bug #56563. Patch by Jackson Harper.
186 2004-06-08 Marek Safar <marek.safar@seznam.cz>
189 (Method.ApplyAttributeBuilder): Moved and added conditional
190 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
193 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
195 2004-06-08 Marek Safar <marek.safar@seznam.cz>
198 * class.cs: (EventField.attribute_targets): Changed default target.
200 2004-06-08 Martin Baulig <martin@ximian.com>
202 * expression.cs (Invocation.EmitCall): Enable varargs methods.
204 2004-06-08 Martin Baulig <martin@ximian.com>
206 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
208 2004-06-07 Martin Baulig <martin@ximian.com>
210 Added support for varargs methods.
212 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
215 * cs-parser.jay: Added support for `__arglist'.
217 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
219 * expression.cs (Argument.AType): Added `ArgList'.
220 (Invocation): Added support for varargs methods.
221 (ArglistAccess): New public class.
222 (Arglist): New public class.
224 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
226 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
227 a method's top-level block if the method has varargs.
229 * support.cs (ReflectionParameters, InternalParameters): Added
230 support for varargs methods.
232 2004-06-07 Miguel de Icaza <miguel@ximian.com>
234 * class.cs: Provide location in indexer error report.
236 * driver.cs: Use standard names.
238 * namespace.cs: Catch the use of using after a namespace has been
239 declared also on using aliases.
241 2004-06-03 Raja R Harinath <rharinath@novell.com>
244 * typemanager.cs (closure_private_ok, closure_invocation_type)
245 (closure_qualifier_type, closure_invocation_assembly)
246 (FilterWithClosure): Move to ...
247 (Closure): New internal nested class.
248 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
249 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
250 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
251 (MemberLookup, MemberLookupFailed): Use it.
252 * expression.cs (New.DoResolve): Treat the lookup for the
253 constructor as being qualified by the 'new'ed type.
254 (Indexers.GetIndexersForTypeOrInterface): Update.
256 2004-06-03 Marek Safar <marek.safar@seznam.cz>
259 (GetConditionalAttributeValue): New method. Returns
260 condition of ConditionalAttribute.
261 (SearchMulti): New method. Returns all attributes of type 't'.
262 Use it when attribute is AllowMultiple = true.
263 (IsConditionalMethodExcluded): New method.
266 (Method.IsExcluded): Implemented. Returns true if method has conditional
267 attribute and the conditions is not defined (method is excluded).
268 (IMethodData): Extended interface for ConditionalAttribute support.
269 (PropertyMethod.IsExcluded): Implemented.
272 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
275 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
278 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
280 * expression.cs (ArrayCreationExpression): Make this just an
281 `expression'. It can't be a statement, so the code here was
284 2004-06-02 Marek Safar <marek.safar@seznam.cz>
287 * typemanager.cs (GetFullNameSignature): New method for
290 2004-06-02 Marek Safar <marek.safar@seznam.cz>
293 * class.cs (MemberBase.GetSignatureForError): New virtual method.
294 Use this method when MethodBuilder is null.
295 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
296 Added test for error CS0626 (MONO reports error for this situation).
297 (IMethodData.GetSignatureForError): Extended interface.
299 2004-06-01 Marek Safar <marek.safar@seznam.cz>
302 (AttributeTester.GetObsoleteAttribute): Returns instance of
303 ObsoleteAttribute when type is obsolete.
306 (TypeContainer.VerifyObsoleteAttribute): Override.
307 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
308 (MethodCode.VerifyObsoleteAttribute): Override.
309 (MemberBase.VerifyObsoleteAttribute): Override.
312 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
313 and report proper error.
316 Delegate.VerifyObsoleteAttribute): Override.
319 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
320 and report proper error.
321 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
324 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
328 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
329 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
330 Added test for ObsoleteAttribute.
333 (Catch): Derived from Statement.
335 2004-06-01 Marek Safar <marek.safar@seznam.cz>
337 Fixed bug #59071 & cs0160.cs
339 * statement.cs (Try.Resolve): Check here whether order of catch
340 clauses matches their dependencies.
342 2004-05-31 Miguel de Icaza <miguel@ximian.com>
344 * Reverted patch to namespace.cs (Use lookuptypedirect). This
345 caused a regression: #59343. Referencing nested classes from an
346 assembly stopped working.
348 2004-05-31 Martin Baulig <martin@ximian.com>
350 MCS is now frozen for beta 2.
352 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
354 * convert.cs: add a trivial cache for overload operator resolution.
356 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
358 * decl.cs: If possible, use lookuptypedirect here. We can only do
359 this if there is no `.' after the namespace. Avoids using
360 LookupType, which does lots of slow processing.
361 (FindNestedType) New method, does what it says :-).
362 * namespace.cs: use LookupTypeDirect.
363 * rootcontext.cs: use membercache, if possible.
364 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
366 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
369 According to the spec,
371 In a member access of the form E.I, if E is a single identifier,
372 and if the meaning of E as a simple-name (§7.5.2) is a constant,
373 field, property, localvariable, or parameter with the same type as
374 the meaning of E as a type-name (§3.8), then both possible
375 meanings of E are permitted.
377 We did not check that E as a simple-name had the same type as E as
380 This trivial check gives us 5-7% on bootstrap time.
382 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
384 * expression.cs (Invocation.OverloadResolve): Avoid the
385 use of hashtables and boxing here by allocating on demand.
387 2004-05-30 Martin Baulig <martin@ximian.com>
389 * rootcontext.cs (RootContext.LookupType): Don't cache things if
390 we're doing a silent lookup. Don't try to lookup nested types in
391 TypeManager.object_type (thanks to Ben Maurer).
393 2004-05-30 Martin Baulig <martin@ximian.com>
395 Committing a patch from Ben Maurer.
397 * rootcontext.cs (RootContext.LookupType): Cache negative results.
399 2004-05-29 Martin Baulig <martin@ximian.com>
401 * class.cs (IMethodData.ShouldIgnore): New method.
403 * typemanager.cs (TypeManager.MethodFlags): Don't take a
404 `Location' argument, we don't need it anywhere. Use
405 `IMethodData.ShouldIgnore ()' instead of
406 `MethodData.GetMethodFlags ()'.
407 (TypeManager.AddMethod): Removed.
408 (TypeManager.AddMethod2): Renamed to AddMethod.
410 2004-05-29 Martin Baulig <martin@ximian.com>
412 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
414 * convert.cs (Convert.ImplicitReferenceConversion): If we're
415 converting from a class type S to an interface type and we already
416 have an object on the stack, don't box it again. Fixes #52578.
418 2004-05-29 Martin Baulig <martin@ximian.com>
420 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
421 Added support for `params' parameters. Fixes #59267.
423 2004-05-29 Martin Baulig <martin@ximian.com>
425 * literal.cs (NullPointer): Provide a private .ctor which sets
426 `type' to TypeManager.object_type. Fixes #59048.
428 2004-05-29 Martin Baulig <martin@ximian.com>
430 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
431 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
433 * ecore.cs (EventExpr.instance_expr): Make the field private.
435 2004-05-26 Marek Safar <marek.safar@seznam.cz>
437 Fixed bug #50080 & cs0214-2.cs
438 * expression.cs (Cast.DoResolve): Check unsafe context here.
440 * statement.cs (Resolve.DoResolve): Likewise.
442 2004-05-26 Martin Baulig <martin@ximian.com>
444 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
446 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
447 (RootContext.LookupType): Pass down the `silent' flag.
449 2004-05-25 Martin Baulig <martin@ximian.com>
452 (MethodGroupExpr.IdenticalTypeName): New public property.
453 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
454 expression actually refers to a type.
456 2004-05-25 Martin Baulig <martin@ximian.com>
458 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
459 for #56176 and made it actually work.
461 2004-05-25 Martin Baulig <martin@ximian.com>
463 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
464 (FieldExpr, PropertyExpr): Override and implement
465 CacheTemporaries. Fixes #52279.
467 2004-05-25 Miguel de Icaza <miguel@ximian.com>
469 * location.cs: In the new compiler listing a file twice is a
470 warning, not an error.
472 2004-05-24 Martin Baulig <martin@ximian.com>
474 * enum.cs (Enum.DefineType): For the `BaseType' to be a
475 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
477 2004-05-24 Martin Baulig <martin@ximian.com>
479 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
480 walking the `using' list. Fixes #53921.
482 2004-05-24 Martin Baulig <martin@ximian.com>
484 * const.cs (Const.LookupConstantValue): Added support for
485 EmptyCast's; fixes #55251.
487 2004-05-24 Martin Baulig <martin@ximian.com>
489 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
490 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
491 which does the CS0135 check. The reason is that we first need to
492 check whether the variable actually exists.
494 2004-05-24 Martin Baulig <martin@ximian.com>
496 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
497 than RootContext.LookupType() to find the explicit interface
500 2004-05-24 Raja R Harinath <rharinath@novell.com>
502 * Makefile: Simplify. Use executable.make.
503 * mcs.exe.sources: New file. List of sources of mcs.exe.
505 2004-05-24 Anders Carlsson <andersca@gnome.org>
509 Use the invariant culture when doing String.Compare for CLS case
512 2004-05-23 Martin Baulig <martin@ximian.com>
514 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
515 don't have any dots. Fixes #52622, added cs0246-8.cs.
517 * namespace.cs (NamespaceEntry.Lookup): Likewise.
519 2004-05-23 Marek Safar <marek.safar@seznam.cz>
521 * class.cs (MemberBase.Define): Reuse MemberType member for
522 resolved type. Other methods can use it too.
524 2004-05-23 Martin Baulig <martin@ximian.com>
526 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
527 the variable also exists in the current block (otherwise, we need
528 to report a CS0103). Fixes #58670.
530 2004-05-23 Martin Baulig <martin@ximian.com>
532 * flowanalysis.cs (Reachability.Reachable): Compute this
533 on-the-fly rather than storing it as a field.
535 2004-05-23 Martin Baulig <martin@ximian.com>
537 * flowanalysis.cs (Reachability.And): Manually compute the
538 resulting `barrier' from the reachability.
540 2004-05-23 Marek Safar <marek.safar@seznam.cz>
543 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
544 instance of ObsoleteAttribute when symbol is obsolete.
547 (IMethodData): Extended interface for ObsoleteAttribute support.
549 2004-05-22 Marek Safar <marek.safar@seznam.cz>
551 * attribute.cs: Fix bug #55970
553 2004-05-22 Marek Safar <marek.safar@seznam.cz>
557 (GetObsoleteAttribute): New method. Creates the instance of
559 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
560 ObsoleteAttribute when member is obsolete.
561 (AttributeTester.Report_ObsoleteMessage): Common method for
562 Obsolete error/warning reporting.
565 (TypeContainer.base_classs_type): New member for storing parent type.
568 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
571 2004-05-21 Marek Safar <marek.safar@seznam.cz>
573 * attribute.cs, const.cs: Fix bug #58590
575 2004-05-21 Martin Baulig <martin@ximian.com>
577 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
578 out parameters if the end of the method is unreachable. Fixes
581 2004-05-21 Marek Safar <marek.safar@seznam.cz>
583 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
584 Hari was right, why extra method.
586 2004-05-21 Marek Safar <marek.safar@seznam.cz>
588 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
590 2004-05-20 Martin Baulig <martin@ximian.com>
592 Merged this back from gmcs to keep the differences to a minumum.
594 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
595 instead of a Declspace.
596 (Attribute.ResolveType): Likewise.
597 (Attributes.Search): Likewise.
598 (Attributes.Contains): Likewise.
599 (Attributes.GetClsCompliantAttribute): Likewise.
601 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
603 (MethodData.ApplyAttributes): Take an EmitContext instead of a
606 2004-05-19 Marek Safar <marek.safar@seznam.cz>
608 Fix bug #58688 (MCS does not report error when the same attribute
611 * attribute.cs (Attribute.Emit): Distinction between null and default.
613 2004-05-19 Raja R Harinath <rharinath@novell.com>
615 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
616 of a top-level attribute without an attribute target.
617 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
619 (Attribute.Conditional_GetConditionName),
620 (Attribute.Obsolete_GetObsoleteMessage): Update.
621 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
622 part of ScanForIndexerName.
623 (Attribute.CanIgnoreInvalidAttribute): New function.
624 (Attribute.ScanForIndexerName): Move to ...
625 (Attributes.ScanForIndexerName): ... here.
626 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
627 (Attributes.Search): New internal variant that can choose not to
628 complain if types aren't resolved. The original signature now
630 (Attributes.GetClsCompliantAttribute): Use internal variant, with
631 complaints suppressed.
632 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
633 only if it not useful.
634 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
635 top-level for attributes that are shared between the assembly
636 and a top-level class.
637 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
638 * class.cs: Update to reflect changes.
639 (DefineIndexers): Fuse loops.
640 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
641 a couple more variants of attribute names.
643 2004-05-18 Marek Safar <marek.safar@seznam.cz>
645 Fix bug #52585 (Implemented explicit attribute declaration)
648 (Attributable.ValidAttributeTargets): New abstract method. It gets
649 list of valid attribute targets for explicit target declaration.
650 (Attribute.Target): It holds target itself.
651 (AttributeSection): Removed.
652 (Attribute.CheckTargets): New method. It checks whether attribute
653 target is valid for the current element.
656 (EventProperty): New class. For events that are declared like
657 property (with add and remove accessors).
658 (EventField): New class. For events that are declared like field.
661 * cs-parser.jay: Implemented explicit attribute target declaration.
663 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
664 Override ValidAttributeTargets.
667 (ReturnParameter): Class for applying custom attributes on
669 (ParameterAtribute): New class. Class for applying custom
670 attributes on the parameter type.
672 2004-05-17 Miguel de Icaza <miguel@ximian.com>
674 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
677 (Method): Allow UNSAFE here.
679 * modifiers.cs: Support unsafe reporting.
681 2004-05-17 Marek Safar <marek.safar@seznam.cz>
683 * decl.cs: Fix bug #58478.
685 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
687 * statement.cs: When checking for unreachable code on an EmptyStatement,
688 set the location. Fixes bug #58488.
690 2004-05-13 Miguel de Icaza <miguel@ximian.com>
692 * driver.cs: Add -pkg handling.
694 From Gonzalo: UseShelLExecute=false
696 2004-05-12 Marek Safar <marek.safar@seznam.cz>
699 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
701 (Attribute.IsClsCompliaceRequired): Moved to base for better
703 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
704 when attribute is AttributeUsageAttribute.
705 (Attribute.GetValidTargets): Simplified.
706 (Attribute.GetAttributeUsage): New method returns AttributeUsage
707 attribute for this type.
708 (Attribute.ApplyAttributes): Method renamed to Emit and make
710 (GlobalAttributeSection): New class for special handling of global
711 attributes (assembly, module).
712 (AttributeSection.Emit): New method.
714 * class.cs: Implemented Attributable abstract methods.
715 (MethodCore.LabelParameters): Moved to Parameter class.
716 (Accessor): Is back simple class.
717 (PropertyMethod): Implemented Attributable abstract class.
718 (DelegateMethod): Implemented Attributable abstract class.
719 (Event): New constructor for disctintion between normal Event
720 and Event with accessors.
722 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
724 * codegen.cs, const.cs, decl.cs, delegate.cs:
725 (CommonAssemblyModulClass): Implemented Attributable abstract class
728 * enum.cs: Implement IAttributeSupport interface.
729 (EnumMember): New class for emum members. Implemented Attributable
733 (ParameterBase): Is abstract.
734 (ReturnParameter): New class for easier [return:] attribute handling.
736 * typemanager.cs: Removed builder_to_attr.
738 2004-05-11 Raja R Harinath <rharinath@novell.com>
741 * attribute.cs (Attribute.GetPositionalValue): New function.
742 * class.cs (TypeContainer.VerifyMembers): New function.
743 (TypeContainer.Emit): Use it.
744 (ClassOrStruct): New base class for Class and Struct.
745 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
746 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
748 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
749 then each non-static field should have a FieldOffset attribute.
750 Otherwise, none of the fields should have a FieldOffset attribute.
751 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
752 and FieldOffset attributes.
753 * typemanager.cs (TypeManager.struct_layout_attribute_type)
754 (TypeManager.field_offset_attribute_type): New core types.
755 (TypeManager.InitCoreTypes): Initialize them.
757 2004-05-11 Michal Moskal <malekith@pld-linux.org>
759 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
763 2004-05-09 Miguel de Icaza <miguel@ximian.com>
765 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
766 be implicitly converted to ulong.
768 * expression.cs: The logic for allowing operator &, | and ^ worked
769 was wrong, it worked before because we did not report an error in
770 an else branch. Fixes 57895.
772 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
773 allow volatile fields to be reference types.
775 2004-05-07 Miguel de Icaza <miguel@ximian.com>
777 * driver.cs: Add support for /debug-
779 2004-05-07 Raja R Harinath <rharinath@novell.com>
781 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
782 Add a 'complain' parameter to silence errors.
783 (Attribute.Resolve): Update to changes. Put in sanity check to catch
784 silently overlooked type-resolutions.
785 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
787 (Attributes.Search): New function.
788 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
789 (Attributes.GetAttributeFullName): Remove hack.
790 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
791 Update to reflect changes.
792 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
793 Use Attributes.Search instead of nested loops.
795 2004-05-07 Marek Safar <marek.safar@seznam.cz>
798 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
799 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
800 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
802 * report.cs: (Report.Warning): Renamed to Warning_T because of
805 2004-05-05 Raja R Harinath <rharinath@novell.com>
807 * expression.cs (MemberAccess.ResolveMemberAccess):
808 Exit with non-zero status after Report.Error.
809 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
811 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
813 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
815 * support.cs: Don't hang when the file is empty.
817 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
819 * support.cs: In SeekableStreamReader, compute the preamble size of the
820 underlying stream. Position changes should take into account that initial
823 2004-05-03 Todd Berman <tberman@sevenl.net>
825 * driver.cs: remove unused GetSysVersion function.
827 2004-05-03 Todd Berman <tberman@sevenl.net>
829 * driver.cs: Remove the hack from saturday, as well as the hack
830 from jackson (LoadAssemblyFromGac), also adds the CWD to the
831 link_paths to get that bit proper.
833 2004-05-01 Todd Berman <tberman@sevenl.net>
835 * driver.cs: Try a LoadFrom before a Load, this checks the current
836 path. This is currently a bug in mono that is be fixed, however, this
837 provides a workaround for now. This will be removed when the bug
840 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
842 * CryptoConvert.cs: Updated to latest version. Fix issue with
843 incomplete key pairs (#57941).
845 2004-05-01 Todd Berman <tberman@sevenl.net>
847 * driver.cs: Remove '.' from path_chars, now System.* loads properly
850 2004-04-30 Jackson Harper <jackson@ximian.com>
852 * codegen.cs: Open keys readonly.
854 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
856 * typemanager.cs: don't report cyclic struct layout when a struct
857 contains 2 or more fields of the same type. Failed for Pango.AttrShape
858 which has 2 Pango.Rectangle fields.
860 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
862 * expression.cs: Handle IntPtr comparisons with IL code
863 rather than a method call.
865 2004-04-29 Martin Baulig <martin@ximian.com>
867 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
868 the list of PropertyInfo's in class hierarchy and find the
869 accessor. Fixes #56013.
871 2004-04-29 Martin Baulig <martin@ximian.com>
873 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
875 2004-04-29 Martin Baulig <martin@ximian.com>
877 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
879 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
881 2004-04-29 Martin Baulig <martin@ximian.com>
883 * class.cs (ConstructorInitializer.Resolve): Check whether the
884 parent .ctor is accessible. Fixes #52146.
886 2004-04-29 Martin Baulig <martin@ximian.com>
888 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
890 * statement.cs (Using.EmitLocalVariableDecls): Use
891 TypeManager.idisposable_type, not typeof (IDisposable).
892 (Foreach.EmitCollectionForeach): Added support for valuetypes.
894 2004-04-29 Martin Baulig <martin@ximian.com>
896 * class.cs (Event.Define): Don't emit the field and don't set
897 RTSpecialName and SpecialName for events on interfaces. Fixes
900 2004-04-29 Raja R Harinath <rharinath@novell.com>
902 Refactor Attribute.ApplyAttributes.
903 * attribute.cs (Attributable): New base class for objects that can
904 have Attributes applied on them.
905 (Attribute): Make AttributeUsage fields public.
906 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
907 (Attribute.IsInternalCall): New property.
908 (Attribute.UsageAttr): Convert to a public read-only property.
909 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
910 (Attribute.ResolveType, Attribute.Resolve)
911 (Attribute.ScanForIndexerName): Update to reflect changes.
912 (Attribute.CheckAttributeTarget): Re-format.
913 (Attribute.ApplyAttributes): Refactor, to various
914 Attributable.ApplyAttributeBuilder methods.
915 * decl.cs (MemberCore): Make Attributable.
916 * class.cs (Accessor): Make Attributable.
917 (MethodData.ApplyAttributes): Use proper attribute types, not
919 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
920 (TypeContainer.ApplyAttributeBuilder)
921 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
922 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
923 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
924 (Operator.ApplyAttributeBuilder): New factored-out methods.
925 * const.cs (Const.ApplyAttributeBuilder): Likewise.
926 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
927 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
928 * parameter.cs (ParameterBase): New Attributable base class
929 that can also represent Return types.
930 (Parameter): Update to the changes.
932 2004-04-29 Jackson Harper <jackson@ximian.com>
934 * driver.cs: Prefer the corlib system version when looking for
935 assemblies in the GAC. This is still a hack, but its a better hack
938 2004-04-29 Marek Safar <marek.safar@seznam.cz>
940 * decl.cs, enum.cs: Improved error 3005 reporting.
942 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
943 (related_symbols): New private member for list of symbols
944 related to reported error/warning.
946 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
948 2004-04-29 Martin Baulig <martin@ximian.com>
950 * ecore.cs (Expression.Constantify): If we're an enum and
951 TypeManager.TypeToCoreType() doesn't give us another type, use
952 t.UnderlyingSystemType. Fixes #56178.
954 2004-04-29 Martin Baulig <martin@ximian.com>
956 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
957 interfaces and for each interface, only add members directly
958 declared in that interface. Fixes #53255.
960 2004-04-28 Martin Baulig <martin@ximian.com>
962 * expression.cs (ConditionalLogicalOperator): Use a temporary
963 variable for `left' to avoid that we evaluate it more than once;
966 2004-04-28 Martin Baulig <martin@ximian.com>
968 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
971 2004-04-28 Martin Baulig <martin@ximian.com>
973 * statement.cs (LocalInfo.Resolve): Check whether the type is not
976 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
977 whether the type is not void (CS1547).
979 2004-04-28 Martin Baulig <martin@ximian.com>
981 * expression.cs (Unary.DoResolveLValue): Override this and report
982 CS0131 for anything but Operator.Indirection.
984 2004-04-28 Martin Baulig <martin@ximian.com>
986 Committing a patch from Ben Maurer; see bug #50820.
988 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
991 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
994 2004-04-28 Martin Baulig <martin@ximian.com>
996 Committing a patch from Ben Maurer; see bug #50820.
998 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
1001 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
1004 2004-04-28 Martin Baulig <martin@ximian.com>
1006 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
1007 (Block.AddLabel): Call DoLookupLabel() to only search in the
1010 2004-04-28 Martin Baulig <martin@ximian.com>
1012 * cfold.cs (ConstantFold.BinaryFold): Added special support for
1013 comparing StringConstants and NullLiterals in Equality and Inequality.
1015 2004-04-28 Jackson Harper <jackson@ximian.com>
1017 * driver.cs: Attempt to load referenced assemblies from the
1018 GAC. This is the quick and dirty version of this method that
1019 doesnt take into account versions and just takes the first
1020 canidate found. Will be good enough for now as we will not have more
1021 then one version installed into the GAC until I update this method.
1023 2004-04-28 Martin Baulig <martin@ximian.com>
1025 * typemanager.cs (TypeManager.CheckStructCycles): New public
1026 static method to check for cycles in the struct layout.
1028 * rootcontext.cs (RootContext.PopulateTypes): Call
1029 TypeManager.CheckStructCycles() for each TypeContainer.
1030 [Note: We only need to visit each type once.]
1032 2004-04-28 Martin Baulig <martin@ximian.com>
1034 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
1036 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
1037 success and added `out object value'. Use a `bool resolved' field
1038 to check whether we've already been called rather than
1039 `ConstantValue != null' since this breaks for NullLiterals.
1041 2004-04-28 Raja R Harinath <rharinath@novell.com>
1043 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
1044 setting of this flag, since the 'set' method may be non-public.
1046 2004-04-28 Raja R Harinath <rharinath@novell.com>
1048 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
1049 check on current_vector.Block.
1051 2004-04-27 Martin Baulig <martin@ximian.com>
1053 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
1054 a field initializer. Fixes #56459.
1056 2004-04-27 Martin Baulig <martin@ximian.com>
1058 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
1059 we're not attempting to use an indexer. Fixes #52154.
1061 2004-04-27 Martin Baulig <martin@ximian.com>
1063 * statement.cs (Return): Don't create a return label if we don't
1064 need it; reverts my change from January 20th. Thanks to Ben
1067 2004-04-27 Martin Baulig <martin@ximian.com>
1069 According to the spec, `goto' can only leave a nested scope, but
1072 * statement.cs (Block.LookupLabel): Only lookup in the current
1073 block, don't recurse into parent or child blocks.
1074 (Block.AddLabel): Check in parent and child blocks, report
1075 CS0140/CS0158 if we find a duplicate.
1076 (Block): Removed this indexer for label lookups.
1077 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
1078 this already does the error reporting for us.
1081 (FlowBranching.UsageVector.Block): New public variable; may be null.
1082 (FlowBranching.CreateSibling): Added `Block' argument.
1083 (FlowBranching.LookupLabel): New public virtual method. Lookup a
1084 label for the target of a `goto' and check whether we're not
1085 leaving a `finally'.
1087 2004-04-27 Martin Baulig <martin@ximian.com>
1089 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
1090 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
1093 2004-04-27 Martin Baulig <martin@ximian.com>
1095 * statement.cs (Block.AddLabel): Also check for implicit blocks
1096 and added a CS0158 check.
1098 2004-04-27 Martin Baulig <martin@ximian.com>
1100 * flowanalysis.cs (FlowBranchingLoop): New class.
1101 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
1102 UsageVector's instead of an ArrayList.
1103 (FlowBranching.Label): Likewise.
1104 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
1105 (FlowBranching.AddBreakVector): New method.
1107 2004-04-27 Miguel de Icaza <miguel@ximian.com>
1109 * attribute.cs: Small regression fix: only convert the type if we
1110 the type is different, fixes System.Drawing build.
1112 2004-04-27 Martin Baulig <martin@ximian.com>
1114 * attribute.cs (Attribute.Resolve): If we have a constant value
1115 for a named field or property, implicity convert it to the correct
1118 2004-04-27 Raja R Harinath <rharinath@novell.com>
1120 * statement.cs (Block.Block): Implicit blocks share
1121 'child_variable_names' fields with parent blocks.
1122 (Block.AddChildVariableNames): Remove.
1123 (Block.AddVariable): Mark variable as "used by a child block" in
1124 every surrounding block.
1125 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
1126 been used in a child block, complain about violation of "Invariant
1127 meaning in blocks" rule.
1128 * cs-parser.jay (declare_local_variables): Don't use
1129 AddChildVariableNames.
1130 (foreach_statement): Don't create an implicit block: 'foreach'
1133 2004-04-23 Miguel de Icaza <miguel@ximian.com>
1135 * convert.cs (ImplicitNumericConversion): 0 is also positive when
1136 converting from 0L to ulong. Fixes 57522.
1138 2004-04-22 Marek Safar <marek.safar@seznam.cz>
1140 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
1141 derived class hides via 'new' keyword field from base class (test-242.cs).
1142 TODO: Handle this in the more general way.
1144 * class.cs (CheckBase): Ditto.
1146 2004-04-22 Marek Safar <marek.safar@seznam.cz>
1148 * decl.cs (caching_flags): New member for storing cached values
1150 (MemberCore.Flags): New enum where bit flags for caching_flags
1152 (MemberCore.cls_compliance): Moved to caching_flags.
1153 (DeclSpace.Created): Moved to caching_flags.
1155 * class.cs: Use caching_flags instead of DeclSpace.Created
1157 2004-04-21 Miguel de Icaza <miguel@ximian.com>
1159 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
1160 if we are only a derived class, not a nested class.
1162 * typemanager.cs: Same as above, but do this at the MemberLookup
1163 level (used by field and methods, properties are handled in
1164 PropertyExpr). Allow for the qualified access if we are a nested
1167 2004-04-21 Marek Safar <marek.safar@seznam.cz>
1169 * class.cs: Refactoring.
1170 (IMethodData): New inteface; Holds links to parent members
1171 to avoid member duplication (reduced memory allocation).
1172 (Method): Implemented IMethodData interface.
1173 (PropertyBase): New inner classes for get/set methods.
1174 (PropertyBase.PropertyMethod): Implemented IMethodData interface
1175 (Event): New inner classes for add/remove methods.
1176 (Event.DelegateMethod): Implemented IMethodData interface.
1178 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
1179 EmitContext (related to class.cs refactoring).
1181 2004-04-21 Raja R Harinath <rharinath@novell.com>
1183 * delegate.cs (Delegate.VerifyApplicability): If the number of
1184 arguments are the same as the number of parameters, first try to
1185 verify applicability ignoring any 'params' modifier on the last
1189 2004-04-16 Raja R Harinath <rharinath@novell.com>
1191 * class.cs (TypeContainer.AddIndexer): Use
1192 'ExplicitInterfaceName' to determine if interface name was
1193 explicitly specified. 'InterfaceType' is not initialized at this time.
1194 (TypeContainer.DefineIndexers): Remove use of temporary list. The
1195 Indexers array is already in the required order. Initialize
1196 'IndexerName' only if there are normal indexers.
1197 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
1198 (TypeContainer.Emit): Emit DefaultMember attribute only if
1199 IndexerName is initialized.
1202 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
1204 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
1207 2004-04-15 Raja R Harinath <rharinath@novell.com>
1209 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
1213 * attribute.cs (Attribute.Resolve): Check for duplicate named
1217 2004-04-15 Miguel de Icaza <miguel@ximian.com>
1219 * iterators.cs (MarkYield): track whether we are in an exception,
1220 and generate code accordingly. Use a temporary value to store the
1221 result for our state.
1223 I had ignored a bit the interaction of try/catch with iterators
1224 since their behavior was not entirely obvious, but now it is
1225 possible to verify that our behavior is the same as MS .NET 2.0
1229 2004-04-14 Miguel de Icaza <miguel@ximian.com>
1231 * iterators.cs: Avoid creating temporaries if there is no work to
1234 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
1235 Enumerations, use TypeManager.EnumToUnderlying and call
1238 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
1241 (This.Emit): Use EmitContext.EmitThis to emit our
1244 (This.EmitAssign): Ditto.
1246 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
1247 codepaths, we will move all the functionality into
1250 (FieldExpr.EmitAssign): Ditto.
1252 This fixes several hidden bugs that I uncovered while doing a code
1253 review of this today.
1255 * codegen.cs (EmitThis): reworked so the semantics are more clear
1256 and also support value types "this" instances.
1258 * iterators.cs: Changed so that for iterators in value types, we
1259 do not pass the value type as a parameter.
1261 Initialization of the enumerator helpers is now done in the caller
1262 instead of passing the parameters to the constructors and having
1263 the constructor set the fields.
1265 The fields have now `assembly' visibility instead of private.
1267 2004-04-11 Miguel de Icaza <miguel@ximian.com>
1269 * expression.cs (Argument.Resolve): Check if fields passed as ref
1270 or out are contained in a MarshalByRefObject.
1272 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
1273 another compiler type.
1275 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
1277 * class.cs (Indexer.Define): use the new name checking method.
1278 Also, return false on an error.
1279 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
1280 (is_identifier_[start/part]_character): make static.
1282 2004-04-10 Miguel de Icaza <miguel@ximian.com>
1284 * expression.cs (Binary.ResolveOperator): Do no append strings
1285 twice: since we can be invoked more than once (array evaluation)
1286 on the same concatenation, take care of this here. Based on a fix
1287 from Ben (bug #56454)
1289 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
1291 * codegen.cs: Fix another case where CS1548 must be reported (when
1292 delay-sign isn't specified and no private is available #56564). Fix
1293 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
1294 error when MCS is used on the MS runtime and we need to delay-sign
1295 (which seems unsupported by AssemblyBuilder - see #56621).
1297 2004-04-08 Marek Safar <marek.safar@seznam.cz>
1299 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
1300 (TypeManager.ComputeNamespaces): Faster implementation for
1303 * compiler.csproj: Updated AssemblyName to mcs.
1305 2004-04-07 Miguel de Icaza <miguel@ximian.com>
1307 * rootcontext.cs: Add new types to the boot resolution.
1309 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
1310 MulticastDelegate is not allowed.
1312 * typemanager.cs: Add new types to lookup: System.TypedReference
1315 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
1316 check for TypedReference or ArgIterator, they are not allowed.
1318 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
1319 makes us properly catch 1510 in some conditions (see bug 56016 for
1322 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
1324 * CryptoConvert.cs: update from corlib version
1327 2004-04-05 Miguel de Icaza <miguel@ximian.com>
1329 * class.cs (Indexer.Define): Check indexername declaration
1331 2004-04-05 Marek Safar <marek.safar@seznam.cz>
1333 * attribute.cs (IsClsCompliant): Fixed problem with handling
1334 all three states (compliant, not-compliant, undetected).
1336 2004-03-30 Marek Safar <marek.safar@seznam.cz>
1338 * attribute.cs (Attribute): Location is now public.
1339 (Resolve): Store resolved arguments (pos_values) in attribute class.
1340 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
1341 (GetClsCompliantAttributeValue): New method that gets
1342 CLSCompliantAttribute value.
1343 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
1344 if exists else null.
1345 (AttributeTester): New class for CLS-Compliant verification routines.
1347 * class.cs (Emit): Add CLS-Compliant verification.
1348 (Method.GetSignatureForError): Implemented.
1349 (Constructor.GetSignatureForError): Implemented
1350 (Constructor.HasCompliantArgs): Returns if constructor has
1351 CLS-Compliant arguments.
1352 (Constructor.Emit): Override.
1353 (Construcor.IsIdentifierClsCompliant): New method; For constructors
1354 is needed to test only parameters.
1355 (FieldBase.GetSignatureForError): Implemented.
1356 (TypeContainer): New member for storing base interfaces.
1357 (TypeContainer.FindMembers): Search in base interfaces too.
1359 * codegen.cs (GetClsComplianceAttribute): New method that gets
1360 assembly or module CLSCompliantAttribute value.
1361 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
1363 (ModuleClass.Emit): Add error 3012 test.
1365 * const.cs (Emit): Override and call base for CLS-Compliant tests.
1367 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
1368 state for all decl types.
1369 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
1370 if CLS-Compliant tests are required.
1371 (IsClsCompliaceRequired): New method. Analyze whether code
1372 must be CLS-Compliant.
1373 (IsExposedFromAssembly): New method. Returns true when MemberCore
1374 is exposed from assembly.
1375 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
1376 value or gets cached value.
1377 (HasClsCompliantAttribute): New method. Returns true if MemberCore
1378 is explicitly marked with CLSCompliantAttribute.
1379 (IsIdentifierClsCompliant): New abstract method. This method is
1380 used to testing error 3005.
1381 (IsIdentifierAndParamClsCompliant): New method. Common helper method
1382 for identifier and parameters CLS-Compliant testing.
1383 (VerifyClsCompliance): New method. The main virtual method for
1384 CLS-Compliant verifications.
1385 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
1386 null. I don't know why is null (too many public members !).
1387 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
1388 and get value of first CLSCompliantAttribute that found.
1390 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
1391 (VerifyClsCompliance): Override and add extra tests.
1393 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
1394 clscheck- disable CLS-Compliant verification event if assembly is has
1395 CLSCompliantAttribute(true).
1397 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
1398 ApllyAttribute is now called in emit section as in the other cases.
1399 Possible future Emit integration.
1400 (IsIdentifierClsCompliant): New override.
1401 (VerifyClsCompliance): New override.
1402 (GetEnumeratorName): Returns full enum name.
1404 * parameter.cs (GetSignatureForError): Implemented.
1406 * report.cs (WarningData): New struct for Warning message information.
1407 (LocationOfPreviousError): New method.
1408 (Warning): New method. Reports warning based on the warning table.
1409 (Error_T): New method. Reports error based on the error table.
1411 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
1412 verifications are done here.
1414 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
1416 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
1417 CLSCompliantAttribute.
1418 (all_imported_types): New member holds all imported types from other
1420 (LoadAllImportedTypes): New method fills static table with exported types
1421 from all referenced assemblies.
1422 (Modules): New property returns all assembly modules.
1424 2004-03-30 Miguel de Icaza <miguel@ximian.com>
1426 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
1427 throwing a parser error.
1429 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
1430 which removes the hardcoded get_/set_ prefixes for properties, as
1431 IL allows for the properties to be named something else.
1435 * expression.cs: Do not override operand before we know if it is
1438 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
1440 * typemanager.cs: support for pinned variables.
1442 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
1444 * decl.cs, typemanager.cs: Avoid using an arraylist
1445 as a buffer if there is only one result set.
1447 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
1449 * expression.cs: Make sure you cant call a static method
1450 with an instance expression, bug #56174.
1452 2004-03-29 Miguel de Icaza <miguel@ximian.com>
1454 * class.cs (IsDuplicateImplementation): Improve error reporting to
1455 flag 663 (method only differs in parameter modifier).
1457 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
1458 in preprocessor directives.
1460 * location.cs (LookupFile): Allow for the empty path.
1462 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
1463 better approach for some of that patch, but its failing with the
1464 CharSet enumeration. For now try/catch will do.
1466 * typemanager.cs: Do not crash if a struct does not have fields.
1469 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
1471 * expression.cs: cs0213, cant fix a fixed expression.
1474 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
1476 * cs-parser.jay: detect invalid embeded statements gracefully.
1479 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
1481 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
1484 the invocation type may not be a subclass of the tye of the item/
1485 The type of the item must be a subclass of the invocation item.
1490 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
1492 * attribute.cs: Added methods to get a string and a bool from an
1493 attribute. Required to information from AssemblyKeyFileAttribute,
1494 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
1495 * codegen.cs: Modified AssemblyName creation to include support for
1496 strongnames. Catch additional exceptions to report them as CS1548.
1497 * compiler.csproj: Updated include CryptoConvert.cs.
1498 * compiler.csproj.user: Removed file - user specific configuration.
1499 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
1500 Mono.Security assembly. The original class is maintained and tested in
1501 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
1502 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
1503 like CSC 8.0 (C# v2) supports.
1504 * Makefile: Added CryptoConvert.cs to mcs sources.
1505 * rootcontext.cs: Added new options for strongnames.
1507 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
1509 * driver.cs: For --expect-error, report error code `2'
1510 if the program compiled with no errors, error code `1' if
1511 it compiled with an error other than the one expected.
1513 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
1515 * compiler.csproj: Updated for Visual Studio .NET 2003.
1516 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
1517 * compiler.sln: Updated for Visual Studio .NET 2003.
1519 2004-03-24 Ravi Pratap M <ravi@ximian.com>
1521 * expression.cs: Fix bug #47234. We basically need to apply the
1522 rule that we prefer the conversion of null to a reference type
1523 when faced with a conversion to 'object' (csc behaviour).
1525 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
1527 * statement.cs: Shorter form for foreach, eliminates
1528 a local variable. r=Martin.
1530 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
1532 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
1533 checks if we can use brtrue/brfalse to test for 0.
1534 * expression.cs: use the above in the test for using brtrue/brfalse.
1537 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
1539 * expression.cs: Rewrite string concat stuff. Benefits:
1541 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
1542 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
1543 rather than a concat chain.
1545 * typemanager.cs: Add lookups for more concat overloads.
1547 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
1549 * expression.cs: Emit shorter il code for array init.
1566 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
1568 * statement.cs: Before, two switch blocks would be merged if the
1569 total size of the blocks (end_item - begin_item + 1) was less than
1570 two times the combined sizes of the blocks.
1572 Now, it will only merge if after the merge at least half of the
1577 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
1579 * class.cs : csc build fix for GetMethods(). See bug #52503.
1581 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
1583 * expression.cs: Make sure fp comparisons work with NaN.
1584 This fixes bug #54303. Mig approved this patch a long
1585 time ago, but we were not able to test b/c the runtime
1588 2004-03-19 Miguel de Icaza <miguel@ximian.com>
1590 * ecore.cs (TypExpr.GetHashCode): implement this overload.
1592 2004-03-19 Martin Baulig <martin@ximian.com>
1594 * class.cs (MemberCore.IsDuplicateImplementation): Report the
1595 error here and not in our caller.
1597 2004-03-19 Martin Baulig <martin@ximian.com>
1599 * interface.cs: Completely killed this file.
1600 (Interface): We're now a TypeContainer and live in class.cs.
1602 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
1603 argument; we're now also called for interfaces.
1604 (TypeContainer.DefineMembers): Allow this method being called
1606 (TypeContainer.GetMethods): New public method; formerly known as
1607 Interface.GetMethod(). This is used by PendingImplementation.
1608 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
1609 it's now private and non-static.
1610 (Interface): Moved this here; it's now implemented similar to
1612 (Method, Property, Event, Indexer): Added `bool is_interface'
1613 argument to their .ctor's.
1614 (MemberBase.IsInterface): New public field.
1616 * cs-parser.jay: Create normal Method, Property, Event, Indexer
1617 instances instead of InterfaceMethod, InterfaceProperty, etc.
1618 (opt_interface_base): Removed; we now use `opt_class_base' instead.
1619 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
1621 2004-03-19 Martin Baulig <martin@ximian.com>
1623 * class.cs (MethodCore.IsDuplicateImplementation): New private
1624 method which does the CS0111 checking.
1625 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
1626 Use IsDuplicateImplementation().
1628 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
1630 * decl.cs (FindMemberToOverride): New method to find the correct
1631 method or property to override in the base class.
1633 - Make Method/Property use the above method to find the
1634 version in the base class.
1635 - Remove the InheritableMemberSignatureCompare as it is now
1638 This patch makes large code bases much faster to compile, as it is
1639 O(n) rather than O(n^2) to do this validation.
1641 Also, it fixes bug 52458 which is that nested classes are not
1642 taken into account when finding the base class member.
1644 Reviewed/Approved by Martin.
1646 2004-03-17 Marek Safar <marek.safar@seznam.cz>
1648 * interface.cs: In all interface classes removed redundant
1649 member initialization.
1651 2004-03-16 Martin Baulig <martin@ximian.com>
1653 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
1655 2004-03-15 Miguel de Icaza <miguel@ximian.com>
1657 * decl.cs (DefineTypeAndParents): New helper method to define a
1658 type's containers before the type itself is defined; This is a
1659 bug exposed by the recent changes to Windows.Forms when an
1660 implemented interface was defined inside a class that had not been
1663 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
1665 (Check): Loop correctly to report errors modifiers
1666 (UNSAFE was not in the loop, since it was the same as TOP).
1668 * interface.cs: Every interface member now takes a ModFlags,
1669 instead of a "is_new" bool, which we set on the base MemberCore.
1671 Every place where we called "UnsafeOk" in the interface, now we
1672 call the proper member (InterfaceMethod.UnsafeOK) instead to get
1673 the unsafe settings from the member declaration instead of the
1674 container interface.
1676 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
1678 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
1679 `set_indexer_name' to the pending bits (one per type).
1681 We fixed a bug today that was picking the wrong method to
1682 override, since for properties the existing InterfaceMethod code
1683 basically ignored the method name. Now we make sure that the
1684 method name is one of the valid indexer names.
1686 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
1688 * support.cs (SeekableStreamReader): Keep track of stream byte
1689 positions and don't mix them with character offsets to the buffer.
1691 Patch from Gustavo Giráldez
1693 2004-03-15 Marek Safar <marek.safar@seznam.cz>
1695 * interface.cs (InterfaceSetGetBase): Removed double member
1696 initialization, base class does it as well.
1698 2004-03-13 Martin Baulig <martin@ximian.com>
1700 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
1701 when compiling corlib.
1703 2004-03-13 Miguel de Icaza <miguel@ximian.com>
1705 * convert.cs (ExplicitConversion): We were reporting an error on
1706 certain conversions (object_type source to a value type, when the
1707 expression was `null') before we had a chance to pass it through
1708 the user defined conversions.
1710 * driver.cs: Replace / and \ in resource specifications to dots.
1713 * class.cs: Add check for duplicate operators. Fixes 52477
1715 2004-03-11 Miguel de Icaza <miguel@ximian.com>
1717 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
1718 that are in the middle of the statements, not only at the end.
1721 * class.cs (TypeContainer.AddField): No longer set the
1722 `HaveStaticConstructor' flag, now we call it
1723 `UserDefineStaticConstructor' to diferentiate the slightly
1724 semantic difference.
1726 The situation is that we were not adding BeforeFieldInit (from
1727 Modifiers.TypeAttr) to classes that could have it.
1728 BeforeFieldInit should be set to classes that have no static
1733 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
1735 And most importantly Zoltan's comment:
1737 http://bugzilla.ximian.com/show_bug.cgi?id=44229
1739 "I think beforefieldinit means 'it's ok to initialize the type sometime
1740 before its static fields are used', i.e. initialization does not need
1741 to be triggered by the first access to the type. Setting this flag
1742 helps the JIT to compile better code, since it can run the static
1743 constructor at JIT time, and does not need to generate code to call it
1744 (possibly lots of times) at runtime. Unfortunately, mcs does not set
1745 this flag for lots of classes like String.
1747 csc sets this flag if the type does not have an explicit static
1748 constructor. The reasoning seems to be that if there are only static
1749 initalizers for a type, and no static constructor, then the programmer
1750 does not care when this initialization happens, so beforefieldinit
1753 This bug prevents the AOT compiler from being usable, since it
1754 generates so many calls to mono_runtime_class_init that the AOT code
1755 is much slower than the JITted code. The JITted code is faster,
1756 because it does not generate these calls if the vtable is type is
1757 already initialized, which is true in the majority of cases. But the
1758 AOT compiler can't do this."
1760 2004-03-10 Miguel de Icaza <miguel@ximian.com>
1762 * class.cs (MethodData.Emit): Refactor the code so symbolic
1763 information is generated for destructors; For some reasons we
1764 were taking a code path that did not generate symbolic information
1767 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
1769 * class.cs: Create a Constructor.CheckBase method that
1770 takes care of all validation type code. The method
1771 contains some code that was moved from Define.
1773 It also includes new code that checks for duplicate ctors.
1774 This fixes bug #55148.
1776 2004-03-09 Joshua Tauberer <tauberer@for.net>
1778 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
1779 a { ... }-style array creation invokes EmitStaticInitializers
1780 which is not good for reference-type arrays. String, decimal
1781 and now null constants (NullCast) are not counted toward
1782 static initializers.
1784 2004-03-05 Martin Baulig <martin@ximian.com>
1786 * location.cs (SourceFile.HasLineDirective): New public field;
1787 specifies whether the file contains or is referenced by a "#line"
1789 (Location.DefineSymbolDocuments): Ignore source files which
1790 either contain or are referenced by a "#line" directive.
1792 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
1794 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
1795 direct access to our parent, so check the method inline there.
1797 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
1799 * expression.cs (Invocation.EmitCall): Miguel's last commit
1800 caused a regression. If you had:
1805 In Foo the implict this would be null.
1807 2004-02-27 Miguel de Icaza <miguel@ximian.com>
1809 * expression.cs (Invocation.EmitCall): If the method is not
1810 virtual, do not emit a CallVirt to it, use Call.
1812 * typemanager.cs (GetFullNameSignature): Improve the method to
1813 cope with ".ctor" and replace it with the type name.
1815 * class.cs (ConstructorInitializer.Resolve): Now the method takes
1816 as an argument the ConstructorBuilder where it is being defined,
1817 to catch the recursive constructor invocations.
1819 2004-02-26 Miguel de Icaza <miguel@ximian.com>
1821 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
1822 routines to check if a type is an enumerable/enumerator allow
1823 classes that implement the IEnumerable or IEnumerator interfaces.
1825 * class.cs (Property, Operator): Implement IIteratorContainer, and
1826 implement SetYields.
1828 (Property.Define): Do the block swapping for get_methods in the
1829 context of iterators. We need to check if Properties also
1830 include indexers or not.
1832 (Operator): Assign the Block before invoking the
1833 OperatorMethod.Define, so we can trigger the Iterator code
1836 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
1837 Property and Operator classes are not created when we parse the
1838 declarator but until we have the block completed, so we use a
1839 singleton SimpleIteratorContainer.Simple to flag whether the
1840 SetYields has been invoked.
1842 We propagate this setting then to the Property or the Operator to
1843 allow the `yield' to function.
1845 2004-02-25 Marek Safar <marek.safar@seznam.cz>
1847 * codegen.cs: Implemented attribute support for modules.
1848 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
1849 Assembly/Module functionality.
1851 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
1852 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
1853 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
1855 2004-02-16 Marek Safar <marek.safar@seznam.cz>
1857 * interface.cs (FindMembers): The operation is performed on all base
1858 interfaces and not only on the first. It is required for future CLS Compliance patch.
1860 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
1862 * statement.cs, codegen.cs:
1863 This patch deals with patterns such as:
1865 public class List : IEnumerable {
1867 public MyEnumerator GetEnumerator () {
1868 return new MyEnumerator(this);
1871 IEnumerator IEnumerable.GetEnumerator () {
1875 public struct MyEnumerator : IEnumerator {
1880 Before, there were a few things we did wrong:
1881 1) we would emit callvirt on a struct, which is illegal
1882 2) we emited ldarg when we needed to emit ldarga
1883 3) we would mistakenly call the interface methods on an enumerator
1884 type that derived from IEnumerator and was in another assembly. For example:
1886 public class MyEnumerator : IEnumerator
1888 Would have the interface methods called, even if there were public impls of the
1889 method. In a struct, this lead to invalid IL code.
1891 2004-02-11 Marek Safar <marek.safar@seznam.cz>
1893 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
1896 * delegate.cs (Define): Fixed crash when delegate type is undefined.
1898 2004-02-11 Miguel de Icaza <miguel@ximian.com>
1900 * cs-parser.jay: Fix small regression: we were not testing V2
1901 compiler features correctly.
1903 * interface.cs: If the emit context is null, then create one
1905 2004-02-09 Marek Safar <marek.safar@seznam.cz>
1907 * decl.cs (GetSignatureForError): New virtual method to get full name
1910 * attribute.cs (IAttributeSupport): New interface for attribute setting.
1911 Now it is possible to rewrite ApplyAttributes method to be less if/else.
1913 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
1914 Duplicated members and code in these classes has been removed.
1915 Better encapsulation in these classes.
1917 2004-02-07 Miguel de Icaza <miguel@ximian.com>
1919 * assign.cs (Assign.DoResolve): When dealing with compound
1920 assignments, there is a new rule in ECMA C# 2.4 (might have been
1921 there before, but it is documented here) that states that in:
1925 If b is of type int, and the `op' is a shift-operator, then the
1926 above is evaluated as:
1930 * expression.cs (Binary.ResolveOperator): Instead of testing for
1931 int/uint/long/ulong, try to implicitly convert to any of those
1932 types and use that in pointer arithmetic.
1934 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
1935 method to print information for from the type, not from the
1936 null-method we were given.
1938 2004-02-01 Duncan Mak <duncan@ximian.com>
1940 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
1941 parsing for cmd, fixes bug #53694.
1943 2004-02-04 Marek Safar <marek.safar@seznam.cz>
1945 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
1946 in the member name duplication tests. Property and operator name duplication
1947 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
1949 2004-02-03 Marek Safar <marek.safar@seznam.cz>
1951 * interface.cs (PopulateMethod): Fixed crash when interface method
1952 returns not existing type (error test cs0246-3.cs).
1954 2004-02-02 Ravi Pratap M <ravi@ximian.com>
1956 * cs-parser.jay (interface_accessors): Re-write actions to also
1957 store attributes attached to get and set methods. Fix spelling
1960 (inteface_property_declaration): Modify accordingly.
1962 (InterfaceAccessorInfo): New helper class to store information to pass
1963 around between rules that use interface_accessors.
1965 * interface.cs (Emit): Apply attributes on the get and set
1966 accessors of properties and indexers too.
1968 * attribute.cs (ApplyAttributes): Modify accordingly to use the
1969 right MethodBuilder when applying attributes to the get and set accessors.
1971 2004-01-31 Miguel de Icaza <miguel@ximian.com>
1973 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
1975 2004-01-26 Miguel de Icaza <miguel@ximian.com>
1977 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
1979 2004-01-25 Miguel de Icaza <miguel@ximian.com>
1981 * cs-parser.jay: Remove YIELD token, instead use the new grammar
1982 changes that treat `yield' specially when present before `break'
1985 * cs-tokenizer.cs: yield is no longer a keyword.
1987 2004-01-23 Marek Safar <marek.safar@seznam.cz>
1989 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
1990 setting for default constructors.
1991 For default constructors are almost every time set wrong Modifier. The
1992 generated IL code has been alright. But inside mcs this values was
1993 wrong and this was reason why several of my CLS Compliance tests
1996 2004-01-22 Martin Baulig <martin@ximian.com>
1998 * cs-parser.jay (namespace_or_type_name): Return an Expression,
1999 not a QualifiedIdentifier. This is what `type_name_expression'
2000 was previously doing.
2001 (type_name_expression): Removed; the code is now in
2002 `namespace_or_type_name'.
2003 (qualified_identifier): Removed, use `namespace_or_type_name'
2005 (QualifiedIdentifier): Removed this class.
2007 2004-01-22 Martin Baulig <martin@ximian.com>
2009 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
2010 not a string as alias name.
2012 2004-01-21 Miguel de Icaza <miguel@ximian.com>
2014 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
2015 #52730 bug, and instead compute correctly the need to use a
2016 temporary variable when requesting an address based on the
2017 static/instace modified of the field and the constructor.
2019 2004-01-21 Martin Baulig <martin@ximian.com>
2021 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
2022 class and namespace before looking up aliases. Fixes #52517.
2024 2004-01-21 Martin Baulig <martin@ximian.com>
2026 * flowanalysis.cs (UsageVector.Merge): Allow variables being
2027 assinged in a 'try'; fixes exception4.cs.
2029 2004-01-21 Marek Safar <marek.safar@seznam.cz>
2030 * class.cs : Implemented parameter-less constructor for TypeContainer
2032 * decl.cs: Attributes are now stored here. New property OptAttributes
2034 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
2036 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
2038 2004-01-21 Marek Safar <marek.safar@seznam.cz>
2040 * typemanager.cs (CSharpSignature): Now reports also inner class name.
2041 (CSharpSignature): New method for indexer and property signature.
2043 2004-01-21 Marek Safar <marek.safar@seznam.cz>
2045 * pending.cs (IsVirtualFilter): Faster implementation.
2047 2004-01-21 Marek Safar <marek.safar@seznam.cz>
2049 * typemanager.cs: Avoid inclusion of same assembly more than once.
2051 2004-01-21 Marek Safar <marek.safar@seznam.cz>
2053 * cs-parser.jay: Fixed problem where the last assembly attribute
2054 has been applied also to following declaration (class, struct, etc.)
2056 2004-01-21 Marek Safar <marek.safar@seznam.cz>
2058 * class.cs: Added error CS0538, CS0539 reporting.
2059 Fixed crash on Microsoft runtime when field type is void.
2061 * cs-parser.jay: Added error CS0537 reporting.
2063 * pending.cs: Added error CS0535 reporting.
2064 Improved error report for errors CS0536, CS0534.
2066 2004-01-20 Miguel de Icaza <miguel@ximian.com>
2068 Merge a few bits from the Anonymous Method MCS tree.
2070 * statement.cs (ToplevelBlock): New class for toplevel methods,
2071 will hold anonymous methods, lifted variables.
2073 * cs-parser.jay: Create toplevel blocks for delegates and for
2074 regular blocks of code.
2076 2004-01-20 Martin Baulig <martin@ximian.com>
2078 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
2079 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
2080 and `NeedExplicitReturn'; added `IsLastStatement'.
2081 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
2082 have a `ReturnLabel' or we're not unreachable.
2084 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
2085 child's reachability; don't just override ours with it. Fixes
2086 #58058 (lluis's example).
2087 (FlowBranching): Added public InTryOrCatch(), InCatch(),
2088 InFinally(), InLoop(), InSwitch() and
2089 BreakCrossesTryCatchBoundary() methods.
2091 * statement.cs (Return): Do all error checking in Resolve().
2092 Unless we are the last statement in a top-level block, always
2093 create a return label and jump to it.
2094 (Break, Continue): Do all error checking in Resolve(); also make
2095 sure we aren't leaving a `finally'.
2096 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
2097 statement in a top-level block.
2098 (Block.Flags): Added `IsDestructor'.
2099 (Block.IsDestructor): New public property.
2101 2004-01-20 Martin Baulig <martin@ximian.com>
2103 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
2105 2004-01-20 Martin Baulig <martin@ximian.com>
2107 * statement.cs (Statement.ResolveUnreachable): New public method.
2108 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
2109 (Block.Resolve): Resolve unreachable statements.
2111 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
2113 * expression.cs: We need to fix the case where we do
2114 not have a temp variable here.
2116 * assign.cs: Only expression compound assignments need
2117 temporary variables.
2119 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
2121 * flowanalysis.cs: Reduce memory allocation in a few ways:
2122 - A block with no variables should not allocate a bit
2124 - A method with no out parameters does not need any tracking
2125 for assignment of the parameters, so we need not allocate
2128 public readonly Type[] VariableTypes;
2129 public readonly string[] VariableNames;
2130 Are redundant. The data is already stored in the variable
2131 map, so we need not allocate another array for it.
2132 - We need to add alot of checks for if (params | locals) == null
2133 due to the first two changes.
2135 2004-01-18 Miguel de Icaza <miguel@ximian.com>
2137 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
2138 implement IMemoryLocation, we store a copy on a local variable and
2139 take the address of it. Patch from Benjamin Jemlich
2141 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
2142 to use a special "type_name_expression" rule which reduces the
2143 number of "QualifiedIdentifier" classes created, and instead
2144 directly creates MemberAccess expressions.
2146 2004-01-17 Miguel de Icaza <miguel@ximian.com>
2148 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
2149 that fixes #52853. Null literal assignment to ValueType
2151 * class.cs (MethodData.Emit): Instead of checking the name of the
2152 method to determine if its a destructor, create a new derived
2153 class from Method called Destructor, and test for that.
2155 * cs-parser.jay: Create a Destructor object instead of a Method.
2157 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
2161 2004-01-16 Miguel de Icaza <miguel@ximian.com>
2163 * expression.cs (Binary.ResolveOperator): Perform an implicit
2164 conversion from MethodGroups to their delegate types on the
2167 * delegate.cs: Introduce a new class DelegateCreation that is the
2168 base class for `NewDelegate' and `ImplicitDelegateCreation',
2169 factor some code in here.
2171 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
2172 conversion from MethodGroups to compatible delegate types.
2174 * ecore.cs (Expression.Resolve): Do not flag error 654
2175 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
2176 we allow conversions from MethodGroups to delegate types now.
2178 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
2179 assignments in v2 either.
2181 2004-01-10 Miguel de Icaza <miguel@ximian.com>
2183 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
2184 static read-only fields in ctors.
2186 Applied patch from Benjamin Jemlich
2188 * expression.cs (UnaryMutator): Avoid leaking local variables.
2190 2004-01-09 Miguel de Icaza <miguel@ximian.com>
2192 * cs-tokenizer.cs (IsCastToken): Allow the various native types
2193 here to return true, as they can be used like this:
2197 Fixed 49836 and all the other dups
2199 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
2201 * driver.cs: Implement /win32res and /win32icon.
2203 2004-01-08 Miguel de Icaza <miguel@ximian.com>
2205 * cs-parser.jay: Add a rule to improve error handling for the
2206 common mistake of placing modifiers after the type.
2208 2004-01-07 Miguel de Icaza <miguel@ximian.com>
2210 * cs-parser.jay (interface_event_declaration): Catch
2211 initialization of events on interfaces, and report cs0068
2213 * cs-parser.jay (interface_event_declaration): Catch
2214 initialization of events.
2216 * ecore.cs: Better report missing constructors.
2218 * expression.cs (Binary.ResolveOperator): My previous bug fix had
2219 the error reporting done in the wrong place. Fix.
2221 * expression.cs (Binary.ResolveOperator): Catch the
2222 operator + (E x, E y) error earlier, and later allow for implicit
2223 conversions in operator +/- (E e, U x) from U to the underlying
2226 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
2227 52596, if the container class is abstract, the default constructor
2228 is protected otherwise its public (before, we were always public).
2230 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
2233 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
2234 Jemlich that fixes bug #52597, MCS was generating invalid code for
2235 idisposable structs. Thanks to Ben for following up with this
2238 2004-01-06 Miguel de Icaza <miguel@ximian.com>
2240 * driver.cs: Allow assemblies without code to be generated, fixes
2243 2004-01-07 Nick Drochak <ndrochak@gol.com>
2245 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
2247 2004-01-05 Miguel de Icaza <miguel@ximian.com>
2249 * cs-parser.jay: Add rules to improve error reporting if fields or
2250 methods are declared at the namespace level (error 116)
2252 * Add rules to catch event add/remove
2254 2004-01-04 David Sheldon <dave-mono@earth.li>
2256 * expression.cs: Added matching ")" to error message for
2259 2004-01-03 Todd Berman <tberman@gentoo.org>
2261 * ecore.cs, attribute.cs:
2262 Applying fix from #52429.
2264 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
2266 * ecore.cs, expression.cs, statement.cs:
2267 Total rewrite of how we handle branching. We
2268 now handle complex boolean expressions with fewer
2269 jumps. As well if (x == 0) no longer emits a ceq.
2271 if (x is Foo) is much faster now, because we generate
2274 Overall, we get a pretty big improvement on our benchmark
2275 tests. The code we generate is smaller and more readable.
2277 I did a full two-stage bootstrap. The patch was reviewed
2278 by Martin and Miguel.
2280 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
2282 * cs-parser.jay: Make primary_expression not take a QI.
2283 we dont need this because the member_access rule covers
2284 us here. So we replace the rule with just IDENTIFIER.
2286 This has two good effects. First, we remove a s/r conflict.
2287 Second, we allocate many fewer QualifiedIdentifier objects.
2289 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
2291 * attribute.cs: Handle MarshalAs attributes as pseudo, and
2292 set the correct information via SRE. This prevents
2293 hanging on the MS runtime. Fixes #29374.
2295 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
2297 * convert.cs: correctly handle conversions to value types
2298 from Enum and ValueType as unboxing conversions.
2300 Fixes bug #52569. Patch by Benjamin Jemlich.
2302 2004-01-02 Ravi Pratap <ravi@ximian.com>
2304 * expression.cs (BetterConversion): Prefer int -> uint
2305 over int -> ulong (csc's behaviour). This fixed bug #52046.
2307 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
2309 * decl.cs (MemberCache.FindMembers): now returns a
2312 * typemanager.cs: In general, go with with ^^.
2313 (CopyNewMethods): take an IList.
2314 (RealMemberLookup): Only allocate an arraylist
2315 if we copy from two sets of methods.
2317 This change basically does two things:
2318 1) Fewer array lists allocated due to CopyNewMethods.
2319 2) the explicit cast in MemberList costed ALOT.
2321 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
2323 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
2324 a hashtable to avoid needless string allocations when an identifier is
2325 used more than once (the common case).
2327 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
2329 * pending.cs: MS's TypeBuilder.GetInterfaces ()
2330 is broken, it will not return anything. So, we
2331 have to use the information we have in mcs to
2334 * typemanager.cs: Add a cache for GetInterfaces,
2335 since this will now be used more often (due to ^^)
2337 (GetExplicitInterfaces) New method that gets the
2338 declared, not effective, interfaces on a type
2339 builder (eg, if you have interface IFoo, interface
2340 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
2343 This patch makes MCS able to bootstrap itself on
2346 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
2348 * expression.cs: Remove the Nop's that Miguel put
2351 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
2353 * report.cs, codegen.cs: Give the real stack trace to
2354 the error when an exception is thrown.
2356 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
2358 * decl.cs: only allocate hashtables for ifaces if
2361 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
2363 * expression.cs: fix the error from cs0121-2.cs
2364 (a parent interface has two child interfaces that
2365 have a function with the same name and 0 params
2366 and the function is called through the parent).
2368 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
2370 * class.cs, rootcontext.cs, typmanager.cs: do not
2373 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
2375 * codegen.cs: remove stack for the ec flow branching.
2376 It is already a linked list, so no need.
2378 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
2380 * Makefile: Allow custom profiler here.
2382 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
2384 * typemanager.cs (LookupType):
2385 - Use a static char [], because split takes
2386 a param array for args, so it was allocating
2388 - Do not store true in a hashtable, it boxes.
2390 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
2392 * flowanalysis.cs: bytify common enums.
2394 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
2396 * modifiers.cs: Add a new set of flags for the
2397 flags allowed on explicit interface impls.
2398 * cs-parser.jay: catch the use of modifiers in
2399 interfaces correctly.
2400 * class.cs: catch private void IFoo.Blah ().
2402 All related to bug #50572.
2404 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
2406 * decl.cs: Rewrite the consistant accessability checking.
2407 Accessability is not linear, it must be implemented in
2408 a tableish way. Fixes #49704.
2410 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
2412 * expression.cs: Handle negation in a checked context.
2413 We must use subtraction from zero. Fixes #38674.
2415 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
2417 * class.cs: Ignore static void main in DLLs.
2418 * rootcontext.cs: Handle the target type here,
2419 since we are have to access it from class.cs
2420 * driver.cs: account for the above.
2422 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
2424 * report.cs: Give line numbers and files if available.
2426 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
2428 * driver.cs: Implement /addmodule.
2430 * typemanager.cs: Change 'modules' field so it now contains Modules not
2433 2003-12-20 Martin Baulig <martin@ximian.com>
2435 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
2436 (FieldBase.IsAssigned): Removed this field.
2437 (FieldBase.SetAssigned): New public method.
2438 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
2440 2003-12-20 Martin Baulig <martin@ximian.com>
2442 * expression.cs (LocalVariableReference.DoResolve): Don't set
2443 `vi.Used' if we're called from DoResolveLValue().
2445 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
2446 returns the usage vector it just merged into the current one -
2447 pass this one to UsageWarning().
2448 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
2449 of the `EmitContext', don't call this recursively on our children.
2451 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
2453 * driver.cs: Implement /target:module.
2455 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
2457 * support.cs (CharArrayHashtable): New helper class.
2459 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
2460 char arrays, not strings, so we can avoid creating a string in
2461 consume_identifier if the identifier is a keyword.
2463 2003-12-16 Martin Baulig <martin@ximian.com>
2465 * statement.cs (LocalInfo.Assigned): Removed this property.
2466 (LocalInfo.Flags): Removed `Assigned'.
2467 (LocalInfo.IsAssigned): New public method; takes the EmitContext
2468 and uses flow analysis.
2469 (Block.UsageWarning): Made this method private.
2470 (Block.Resolve): Call UsageWarning() if appropriate.
2472 * expression.cs (LocalVariableReference.DoResolve): Always set
2473 LocalInfo.Used here.
2475 2003-12-13 Martin Baulig <martin@ximian.com>
2477 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
2478 any value here; we're now using flow analysis to figure out
2479 whether a statement/block returns a value.
2481 2003-12-13 Martin Baulig <martin@ximian.com>
2483 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
2485 (FlowBranching.MergeFinally): Don't call
2486 `branching.CheckOutParameters()' here, this is called in
2488 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
2489 when adding the `finally' vector.
2491 2003-12-13 Martin Baulig <martin@ximian.com>
2494 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
2495 actually work and also fix #48962.
2497 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
2499 * decl.cs: Do not check System.Object for nested types,
2500 since we know it does not have any. Big bang for buck:
2505 corlib: 17.99 seconds
2509 corlib: 17.39 seconds
2511 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
2513 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
2514 time we are returning 0 members, so we save alot here.
2516 2003-12-11 Martin Baulig <martin@ximian.com>
2518 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
2519 `MergeChild()', also just take the `FlowBranching' as argument;
2520 call Merge() on it and return the result.
2521 (FlowBranching.Merge): We don't need to do anything if we just
2524 2003-12-11 Martin Baulig <martin@ximian.com>
2526 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
2527 them in an `ArrayList' to reduce memory usage. Thanks to Ben
2528 Maurer for this idea.
2530 2003-12-11 Martin Baulig <martin@ximian.com>
2532 * flowanalysis.cs (MergeResult): This class is now gone; we now
2533 use the `UsageVector' for this. The reason for this is that if a
2534 branching just has one sibling, we don't need to "merge" them at
2535 all - that's the next step to do.
2536 (FlowBranching.Merge): We now return a `UsageVector' instead of a
2539 2003-12-11 Martin Baulig <martin@ximian.com>
2541 Reworked flow analyis and made it more precise and bug-free. The
2542 most important change is that we're now using a special `Reachability'
2543 class instead of having "magic" meanings of `FlowReturns'. I'll
2544 do some more cleanups and optimizations and also add some more
2545 documentation this week.
2547 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
2548 largely reworked this class.
2549 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
2550 the new `Reachability' class instead of having "magic" values here.
2551 (FlowBranching): We're now using an instance of `Reachability'
2552 instead of having separate `Returns', `Breaks' etc. fields.
2554 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
2555 based on flow analysis; ignore the return value of block.Emit ().
2557 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
2559 * driver.cs typemanager.cs: Find the mono extensions to corlib even
2560 if they are private.
2562 2003-12-09 Martin Baulig <martin@ximian.com>
2564 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
2565 call them directly on the UsageVector.
2567 2003-12-09 Martin Baulig <martin@ximian.com>
2569 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
2570 Changed return type from `FlowReturns' to `Reachability'.
2572 2003-12-09 Martin Baulig <martin@ximian.com>
2574 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
2575 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
2576 `Reachable' fields with a single `Reachability' one.
2578 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
2580 * class.cs (FindMembers): Remove foreach's.
2593 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
2598 This patch does a few things:
2599 1. EmptyStatement is now a singleton, so it is never reallocated.
2600 2. All blah is EmptyStatement constructs have been changed to
2601 blah == EmptyStatement.Value, which is much faster and valid
2602 now that EmptyStatement is a singleton.
2603 3. When resolving a block, rather than allocating a new array for
2604 the non-empty statements, empty statements are replaced with
2605 EmptyStatement.Value
2606 4. Some recursive functions have been made non-recursive.
2607 Mainly the performance impact is from (3), however (1) and (2) are needed for
2608 this to work. (4) does not make a big difference in normal situations, however
2609 it makes the profile look saner.
2614 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
2615 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
2616 Total memory allocated: 56397 KB
2619 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
2620 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
2621 Total memory allocated: 55666 KB
2623 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
2625 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
2626 than the hashtable in a hashtable version
2628 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
2629 we always end up concating a string. This results in a huge perf
2630 loss, because many strings have to be tracked by the GC. In this
2631 patch, we first use a hashtable that works with two keys, so that
2632 the strings do not need to be concat'ed.
2643 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
2645 * Makefile: Add a new target `do-time' that does a quick and simple
2646 profile, leaving easy to parse output.
2648 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
2650 * codegen.cs (Init): Create the dynamic assembly with
2651 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
2653 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
2655 * support.cs: Make the PtrHashtable use only one
2656 instance of its comparer.
2658 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
2660 * typemanager.cs: Fix lookup of GetNamespaces.
2662 2003-11-29 Miguel de Icaza <miguel@ximian.com>
2664 * expression.cs: Removed redundant line.
2666 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
2667 ArrayLists, use for loops with bounds.
2669 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
2672 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
2673 arraylists, use for loop with bounds.
2675 The above three changes give us a 0.071 second performance
2676 improvement out of 3.294 seconds down to 3.223. On my machine
2677 the above changes reduced the memory usage by 1,387 KB during
2680 * cs-parser.jay (QualifiedIdentifier): New class used to represent
2681 QualifiedIdentifiers. Before we created a new string through
2682 concatenation, and mostly later on, the result would be
2683 manipulated by DecomposeQI through string manipulation.
2685 This reduced the compiler memory usage for bootstrapping from
2686 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
2687 compile times in 0.05 seconds.
2689 2003-11-28 Dick Porter <dick@ximian.com>
2691 * support.cs: Do string compares with the Invariant culture.
2699 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
2700 the comparison is done with the Invariant culture.
2702 2003-11-27 Miguel de Icaza <miguel@ximian.com>
2704 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
2705 GetEnumerator method.
2707 (ProbeCollectionType): Iterate starting at the most specific type
2708 upwards looking for a GetEnumerator
2710 * expression.cs: Shift count can be up to 31 for int/uint and 63
2713 2003-11-26 Miguel de Icaza <miguel@ximian.com>
2715 * statement.cs (Block.LookupLabel): Also look for the label on the
2716 children blocks. Use a hash table to keep track of visited
2719 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
2720 we actually did transform the other operand, otherwise fall back
2721 to the common codepath that casts to long.
2723 * cs-tokenizer.cs: Use the same code pattern as the int case.
2724 Maybe I should do the parsing myself, and avoid depending on the
2725 Parse routines to get this done.
2727 2003-11-25 Miguel de Icaza <miguel@ximian.com>
2729 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
2730 which fixes bug 51347. This time test it.
2732 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
2733 attributes for example can not tell the difference between these.
2734 The difference was only a syntax feature of the language.
2736 * attribute.cs: Apply attributes to delegates.
2738 * delegate.cs: Call the apply attributes method.
2740 2003-11-24 Miguel de Icaza <miguel@ximian.com>
2742 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
2743 comparing 0 vs Byte.MinValue, not the value
2745 (ImplicitConversionRequired): When reporting a conversion error,
2746 use error 31 to print out the constant error instead of the
2749 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
2750 which fixes bug 51347.
2752 2003-11-22 Miguel de Icaza <miguel@ximian.com>
2754 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
2755 which fixes the -warnaserror command line option.
2757 2003-11-21 Miguel de Icaza <miguel@ximian.com>
2759 * cfold.cs (DoNumericPromotions): During constant folding of
2760 additions on UIntConstant, special case intconstants with
2761 IntConstants like we do on the expression binary operator.
2763 2003-11-12 Miguel de Icaza <miguel@ximian.com>
2765 * convert.cs (ImplicitReferenceConversion): We were missing a case
2766 (System.Enum are not value types or class types, so we need to
2767 classify them separatedly).
2769 * driver.cs: We do not support error 2007.
2771 2003-11-12 Jackson Harper <jackson@ximian.com>
2773 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
2774 system directory. Also use the full file name so users can
2775 libraries names mscorlib-o-tron.dll in a non system dir.
2777 2003-11-10 Martin Baulig <martin@ximian.com>
2779 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
2780 (TypeManager.InitCoreTypes): Initialize them here, but instead of
2781 calling `ResolveType()' on them, directly assign their `Type'.
2783 2003-11-08 Martin Baulig <martin@ximian.com>
2785 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
2786 return value and the `out parent' parameter.
2787 (TypeContainer.DefineType): Moved the CS0644 check into
2788 GetClassBases(). Don't pass the interface types to the
2789 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
2790 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
2792 * ecore.cs (TypeExpr.IsAttribute): New property.
2793 (TypeExpr.GetInterfaces): New method.
2795 * interface.cs (Interface.GetInterfaceTypeByName): Return a
2796 TypeExpr instead of a Type.
2797 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
2798 (Interface.DefineType): Don't pass the interface types to the
2799 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
2800 them later and then call `TypeBulider.AddInterfaceImplementation()'.
2802 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
2803 instead of a `Type[]'.
2804 (TypeManager.RegisterBuilder): Likewise.
2805 (TypeManager.AddUserInterface): Likewise.
2806 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
2807 `Type[]' and also return a `TypeExpr[]'.
2808 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
2810 2003-11-08 Martin Baulig <martin@ximian.com>
2812 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
2815 2003-11-08 Martin Baulig <martin@ximian.com>
2817 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
2818 TypeManager.ResolveExpressionTypes().
2820 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
2821 instead of an Expression.
2822 (TypeExpr): This is now an abstract base class for `TypeExpression'.
2823 (TypeExpression): New public class; formerly known as `TypeExpr'.
2825 * expression.cs (ComposedCast): Derive from TypeExpr.
2827 * typemanager.cs (TypeManager.system_*_expr): These are now
2828 TypExpr's instead of Expression's.
2829 (TypeManager.ResolveExpressionTypes): New public static function;
2830 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
2833 2003-11-06 Miguel de Icaza <miguel@ximian.com>
2835 * expression.cs (New.DoResolve): Do not dereference value that
2836 might be a null return.
2838 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
2839 sure that the constant value has the right type. Fixes an
2840 unreported bug, similar to 50425.
2842 * const.cs (Const.LookupConstantValue): Call
2843 ImplicitStandardConversionExists before doing a conversion to
2844 avoid havng the TypeManager.ChangeType do conversions.
2846 Reduced the number of casts used
2848 (Const.ChangeType): New routine to enable reuse of the constant
2849 type changing code from statement.
2851 * typemanager.cs (ChangeType): Move common initialization to
2852 static global variables.
2856 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
2857 every value type to go through, even if it was void. Fix that.
2859 * cs-tokenizer.cs: Use is_identifier_start_character on the start
2860 character of the define, and the is_identifier_part_character for
2861 the rest of the string.
2863 2003-11-05 Miguel de Icaza <miguel@ximian.com>
2865 * expression.cs (UnaryMutator.EmitCode): When I updated
2866 LocalVariableReference.DoResolve, I overdid it, and dropped an
2867 optimization done on local variable references.
2869 2003-11-04 Miguel de Icaza <miguel@ximian.com>
2871 * ecore.cs: Convert the return from Ldlen into an int.
2873 2003-10-20 Miguel de Icaza <miguel@ximian.com>
2875 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
2876 the accessibility, this is a special case for toplevel non-public
2877 classes (internal for instance).
2879 2003-10-20 Nick Drochak <ndrochak@gol.com>
2881 * ecore.cs: Fix typo and build. Needed another right paren.
2883 2003-10-19 Miguel de Icaza <miguel@ximian.com>
2885 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
2886 `internal' case regular and protected, but not allowing protected
2887 to be evaluated later. Bug 49840
2889 2003-10-15 Miguel de Icaza <miguel@ximian.com>
2891 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
2892 to kb.Nlast, and not the kb.nFirst to isolate the switch
2895 Extract the underlying type, so enumerations of long/ulong are
2896 treated like long/ulong.
2898 2003-10-14 Miguel de Icaza <miguel@ximian.com>
2900 * expression.cs (New): Overload the meaning of RequestedType to
2901 track the possible creation of the NewDelegate type, since
2902 DoResolve is invoked more than once for new constructors on field
2905 See bugs: #48800 and #37014
2907 * cs-parser.jay (declare_local_constants): Take an arraylist
2908 instead of a single constant.
2910 (local_constant_declaration): It should take a
2911 constant_declarators, not a constant_declarator. Fixes 49487
2913 * convert.cs: Fix error report.
2915 2003-10-13 Jackson Harper <jackson@ximian.com>
2917 * typemanager.cs (TypeToCoreType): Add float and double this fixes
2920 2003-10-09 Martin Baulig <martin@ximian.com>
2922 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
2924 (MethodCore.DoDefineParameters): Removed the TypeContainer
2925 argument; use the DeclSpace which was passed to the .ctor instead.
2926 (MethodCore.CheckParameter): Take a DeclSpace instead of a
2927 TypeContainer; we only need a DeclSpace here.
2929 2003-10-09 Martin Baulig <martin@ximian.com>
2931 * class.cs (MethodData): Added additional `DeclSpace ds' argument
2933 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
2934 EmitContext's .ctor.
2936 2003-10-09 Martin Baulig <martin@ximian.com>
2938 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
2939 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
2940 AsAccessible(), moved them as well.
2942 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
2944 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
2946 * cs-parser.jay : Renamed yyName to yyNames related to jay.
2948 2003-10-07 Miguel de Icaza <miguel@ximian.com>
2950 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
2951 generation for >=, as spotted by Paolo, bug 48679.
2952 Patch from David Waite.
2954 * cs-tokenizer.cs: Add handling for #pragma.
2956 * cs-parser.jay: Allow for both yield and yield return in the
2957 syntax. The anti-cobolization of C# fight will go on!
2959 * class.cs (TypeBuilder.DefineType): Catch error condition here
2960 (Parent.DefineType erroring out and returning null).
2962 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
2963 coping with enumerations variables, we were mistakenly processing
2964 them as a regular value type instead of built-in types. Fixes the
2967 * typemanager.cs (IsBuiltinOrEnum): New method.
2969 2003-09-30 Miguel de Icaza <miguel@ximian.com>
2971 * cs-parser.jay: Upgrade: yield now needs the return clause.
2973 2003-09-19 Martin Baulig <martin@ximian.com>
2975 * decl.cs (MemberCache.SetupCacheForInterface): Take a
2976 `MemberCache parent' argument. Normally, an interface doesn't
2977 have a parent type except System.Object, but we use this in gmcs
2978 for generic type parameters.
2980 2003-09-18 Martin Baulig <martin@ximian.com>
2982 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
2983 on `type.IsInterface'; don't check whether the type has a parent
2984 to determine whether it's an interface.
2986 2003-09-15 Martin Baulig <martin@ximian.com>
2988 * class.cs (TypeContainer.DefineType): Added an error flag to
2989 avoid reporting duplicate CS0146's ("class definition is
2992 * driver.cs (Driver.MainDriver): Abort if
2993 RootContext.ResolveTree() reported any errors.
2995 2003-09-07 Martin Baulig <martin@ximian.com>
2997 * report.cs (Error, Warning): Added overloaded versions which take
2998 a `params object[] args' and call String.Format().
3000 2003-09-07 Martin Baulig <martin@ximian.com>
3002 * decl.cs (DeclSpace..ctor): Don't call
3003 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
3004 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
3005 (DeclSpace.RecordDecl): New method.
3007 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
3009 2003-09-02 Ravi Pratap <ravi@ximian.com>
3011 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
3012 value attributes to be applied to ParameterBuilders.
3014 * class.cs (MethodCore.LabelParameters): Make static and more
3015 generic so that it can be used from other places - like interface
3016 methods, for instance.
3018 * interface.cs (Interface.Emit): Call LabelParameters before
3019 emitting attributes on the InterfaceMethod.
3021 2003-08-26 Martin Baulig <martin@ximian.com>
3023 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
3024 resolving aliases; fixes #47927.
3026 2003-08-26 Martin Baulig <martin@ximian.com>
3028 * statement.cs (Using.DoResolve): This is internally emitting a
3029 try/finally clause, so we need to set ec.NeedExplicitReturn if we
3030 do not always return. Fixes #47681.
3032 2003-08-26 Martin Baulig <martin@ximian.com>
3034 * decl.cs (MemberCore): Moved WarningNotHiding(),
3035 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
3037 (AdditionResult): Make this nested in DeclSpace.
3038 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
3039 argument; call NamespaceEntry.Define() unless we're nested in a
3042 * namespace.cs (Namespace.DefineName): New public function. This
3043 is called from DeclSpace's .ctor to add
3044 (Namespace.Lookup): Include DeclSpaces in the lookup.
3046 * class.cs (Operator): Derive from MemberBase, not MemberCore.
3048 * const.cs (Const): Derive from MemberBase, not MemberCore.
3050 2003-08-25 Martin Baulig <martin@ximian.com>
3052 * convert.cs (Convert.ExplicitReferenceConversion): When
3053 converting from an interface type to a class, unbox if the target
3054 type is a struct type. Fixes #47822.
3056 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3058 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
3061 2003-08-22 Martin Baulig <martin@ximian.com>
3063 * class.cs (TypeManager.DefineType): When defining a nested type,
3064 call DefineType() on our parent; fixes #47801.
3066 2003-08-22 Martin Baulig <martin@ximian.com>
3068 * class.cs (MethodData.Define): While checking if a method is an
3069 interface implementation, improve the test a bit more to fix #47654.
3071 2003-08-22 Martin Baulig <martin@ximian.com>
3073 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
3074 correctly; fixes #47722.
3076 2003-08-22 Martin Baulig <martin@ximian.com>
3078 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
3079 LocalVariableReference, ensure it's not read-only. Fixes #47536.
3081 * statement.cs (Fixed.DoResolve): Make all variables read-only.
3083 2003-08-22 Martin Baulig <martin@ximian.com>
3085 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
3086 can only be assigned in static constructors. Fixes #47161.
3088 2003-08-22 Martin Baulig <martin@ximian.com>
3090 Rewrote and improved the flow analysis code.
3092 * flowbranching.cs (FlowBranching): Make this class abstract.
3093 (FlowBranching.CreateBranching): New static function to create a
3095 (FlowBranchingBlock, FlowBranchingException): New classes.
3096 (FlowBranching.UsageVector.Type): New public readonly field.
3097 (FlowBranching.UsageVector.Breaks): Removed the setter.
3098 (FlowBranching.UsageVector.Returns): Removed the setter.
3099 (FlowBranching.UsageVector): Added Break(), Return(),
3100 NeverReachable() and Throw() methods to modify the reachability.
3101 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
3102 done by FlowBranching.Merge().
3103 (FlowBranching.UsageVector.MergeChild): New method; merges the
3104 merge result into the current vector.
3105 (FlowBranching.Merge): New abstract method to merge a branching.
3107 2003-08-12 Martin Baulig <martin@ximian.com>
3109 * expression.cs (Indirection.CacheTemporaries): Create the
3110 LocalTemporary with the pointer type, not its element type.
3112 2003-08-10 Miguel de Icaza <miguel@ximian.com>
3114 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
3115 token was a keyword or not.
3117 Add `error' options where an IDENTIFIER was expected; Provide
3118 CheckToken and CheckIdentifierToken convenience error reporting
3121 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
3123 * decl.cs: Rename `NamespaceEntry Namespace' public field into
3124 NameSpaceEntry NameSpaceEntry.
3126 (LookupInterfaceOrClass): Avoid creating a full qualified name
3127 from namespace and name: avoid doing lookups when we know the
3128 namespace is non-existant. Use new Tree.LookupByNamespace which
3129 looks up DeclSpaces based on their namespace, name pair.
3131 * driver.cs: Provide a new `parser verbose' to display the
3132 exception thrown during parsing. This is turned off by default
3133 now, so the output of a failure from mcs is more graceful.
3135 * namespace.cs: Track all the namespaces defined in a hashtable
3138 (IsNamespace): New method
3140 2003-08-09 Miguel de Icaza <miguel@ximian.com>
3142 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
3143 we know that we need to concatenate (full typename can never be
3148 * statement.cs: Use a bitfield; Do not initialize to null things
3149 which are done by the constructor by default.
3151 * cs-parser.jay: bug fix, parameter was 4, not 3.
3153 * expression.cs: Just use the property;
3155 * statement.cs: No need for GetVariableInfo method.
3157 2003-08-08 Martin Baulig <martin@ximian.com>
3159 * flowanalysis.cs (FlowReturns): This is now nested in the
3160 `FlowBranching' class.
3161 (MyBitVector): Moved this here from statement.cs.
3162 (FlowBranching.SiblingType): New enum type.
3163 (FlowBranching.CreateSibling): Added `SiblingType' argument.
3165 2003-08-07 Martin Baulig <martin@ximian.com>
3167 * flowanalysis.cs (FlowBranchingType): This is now nested in the
3168 `FlowBranching' class and called `BranchingType'.
3170 2003-08-07 Martin Baulig <martin@ximian.com>
3172 * flowanalysis.cs: Moved all the control flow analysis code into
3175 2003-08-07 Martin Baulig <martin@ximian.com>
3177 * assign.cs (Assign.DoResolve): `target' must either be an
3178 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
3181 2003-08-07 Miguel de Icaza <miguel@ximian.com>
3183 * expression.cs (BinaryMethod): This kind of expression is created by the
3184 Binary class if it determines that the operator has to be handled
3187 (BinaryDelegate): This kind of expression is created if we are
3188 dealing with a + or - operator on delegates.
3190 (Binary): remove method, argumetns, and DelegateOperator: when
3191 dealing with methods,
3193 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
3195 * statement.cs (Block): use bitfields for the three extra booleans
3196 we had in use. Remove unused topblock parameter.
3198 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
3200 * assign.cs: Drop extra unneeded tests.
3202 2003-08-06 Miguel de Icaza <miguel@ximian.com>
3204 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
3206 * statement.cs (Foreach): Use VariableStorage instead of
3209 * codegen.cs (VariableStorage): New class used by clients that
3210 require a variable stored: locals or fields for variables that
3211 need to live across yield.
3213 Maybe provide a convenience api for EmitThis+EmitLoad?
3215 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
3218 2003-08-05 Miguel de Icaza <miguel@ximian.com>
3220 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
3221 RemapParameterLValue): New methods that are used to turn a
3222 precomputed FieldInfo into an expression like this:
3226 The idea is to use this instead of making LocalVariableReference
3227 have more than one meaning.
3229 * cs-parser.jay: Add error production to BASE.
3231 * ecore.cs: Deal with TypeManager.GetField returning null, which
3232 is now a valid return value.
3234 (FieldExprNoAddress): New expression for Fields whose address can
3237 * expression.cs (LocalVariableReference): During the resolve
3238 phases, create new expressions if we are in a remapping context.
3239 Remove code that dealt with remapping here.
3241 (ParameterReference): same.
3243 (ProxyInstance): New expression, like the `This' expression, but
3244 it is born fully resolved. We know what we are doing, so remove
3245 the errors that are targeted to user-provided uses of `this'.
3247 * statement.cs (Foreach): our variable is now stored as an
3248 Expression; During resolution, follow the protocol, dont just
3249 assume it will return this.
3251 2003-08-06 Martin Baulig <martin@ximian.com>
3253 * support.cs (SeekableStreamReader.cs): New public class.
3255 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
3256 SeekableStreamReader instead of the normal StreamReader.
3258 2003-08-04 Martin Baulig <martin@ximian.com>
3260 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
3261 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
3262 deambiguate casts and delegate invocations.
3263 (parenthesized_expression): Use the new tokens to ensure this is
3264 not a cast of method invocation.
3266 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
3267 when reading a `)' and Deambiguate_CloseParens () was previously
3270 * expression.cs (ParenthesizedExpression): New class. This is
3271 just used for the CS0075 test.
3272 (Binary.DoResolve): Check for CS0075.
3274 2003-07-29 Ravi Pratap <ravi@ximian.com>
3276 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
3277 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
3278 reference comparison.
3280 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
3281 examine the ReturnType for equality - this is necessary in the
3282 cases of implicit and explicit operators whose signature also
3283 includes the return type.
3285 2003-07-26 Miguel de Icaza <miguel@ximian.com>
3287 * namespace.cs: Cache the result of the namespace computation,
3288 instead of computing it every time.
3290 2003-07-24 Miguel de Icaza <miguel@ximian.com>
3292 * decl.cs: Use a global arraylist that we reuse over invocations
3293 to avoid excesive memory consumption. Reduces memory usage on an
3294 mcs compile by one meg (45 average).
3296 * typemanager.cs (LookupTypeReflection): In .NET pointers are
3297 private, work around that.
3299 2003-07-23 Miguel de Icaza <miguel@ximian.com>
3301 * literal.cs (IntLiteral): Define Zero and One static literals.
3303 * cs-parser.jay (integer_literal): use static literals to reduce
3304 memory usage for the most used literals (0, 1 and -1). 211kb
3305 reduced in memory usage.
3307 Replace all calls to `new ArrayList' with `new
3308 ArrayList(4)' which is a good average number for most allocations,
3309 and also requires only 16 bytes of memory for its buffer by
3312 This reduced MCS memory usage in seven megabytes for the RSS after
3315 2003-07-28 Ravi Pratap <ravi@ximian.com>
3317 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
3318 handle params methods the correct way by forming only one
3319 applicable set with params and normal methods in them. Earlier we
3320 were looking at params methods only if we found no normal methods
3321 which was not the correct thing to do.
3323 (Invocation.BetterFunction): Take separate arguments indicating
3324 when candidate and the best method are params methods in their
3327 This fixes bugs #43367 and #46199.
3329 * attribute.cs: Documentation updates.
3331 (CheckAttribute): Rename to CheckAttributeTarget.
3332 (GetValidPlaces): Rename to GetValidTargets.
3334 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
3335 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
3339 2003-07-28 Martin Baulig <martin@ximian.com>
3341 * class.cs (TypeContainer.DefineMembers): Use the base type's full
3342 name when looking up the base class of a nested class. Fixes #46977.
3344 2003-07-26 Martin Baulig <martin@ximian.com>
3346 * expression.cs (Indexers.Indexer): New nested struct; contains
3347 getter, setter and the indexer's type.
3348 (Indexers.Properties): This is now an ArrayList of
3350 (IndexerAccess.DoResolveLValue): Correctly set the type if the
3351 indexer doesn't have any getters.
3353 * assign.cs (Assign.DoResolve): Also do the implicit conversions
3354 for embedded property and indexer assignments.
3356 2003-07-26 Martin Baulig <martin@ximian.com>
3358 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
3359 preprocessor directive is not the first non-whitespace character
3362 2003-07-26 Martin Baulig <martin@ximian.com>
3364 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
3365 namespace parsing, follow the spec more closely.
3367 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
3368 NamespaceEntry.Lookup().
3370 2003-07-25 Martin Baulig <martin@ximian.com>
3372 * MethodCore.cs (OverridesSomething): New public field; it's set
3373 from TypeContainer.DefineMembers if this method overrides
3374 something (which doesn't need to be a method). Fix #39462.
3376 2003-07-25 Ravi Pratap <ravi@ximian.com>
3378 * typemanager.cs (GetMembers): Ensure that the list of members is
3379 reversed. This keeps things in sync.
3381 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
3382 find an AttributeUsage attribute.
3384 * expression.cs (Invocation.OverloadResolve): Perform the check
3385 which disallows Invoke to be directly called on a Delegate.
3387 (Error_InvokeOnDelegate): Report error cs1533.
3389 2003-07-25 Martin Baulig <martin@ximian.com>
3391 * expression.cs (Indexers.GetIndexersForType): Only look in the
3392 interface hierarchy if the requested type is already an
3393 interface. Fixes #46788 while keeping #46502 fixed.
3395 2003-07-25 Martin Baulig <martin@ximian.com>
3397 * class.cs (TypeContainer.DefineMembers): Check whether all
3398 readonly fields have been assigned and report warning CS0649 if
3401 * statement.cs (LocalInfo.IsFixed): Always return true if this is
3404 2003-07-24 Ravi Pratap <ravi@ximian.com>
3406 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
3407 returned from GetMethods to make things consistent with the
3408 assumptions MCS makes about ordering of methods.
3410 This should comprehensively fix bug #45127 and it does :-)
3412 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
3413 ordering is actually reverse.
3415 * Clean up some debug messages I left lying around.
3417 * interface.cs (Populate*): Get rid of code which emits attributes
3418 since the stage in which we emit attributes is the 'Emit' stage,
3419 not the define stage.
3421 (Emit): Move attribute emission for interface members here.
3423 2003-07-22 Ravi Pratap <ravi@ximian.com>
3425 * expression.cs (Invocation.OverloadResolve): Follow the spec more
3426 closely: we eliminate methods in base types when we have an
3427 applicable method in a top-level type.
3429 Please see section 14.5.5.1 for an exact description of what goes
3432 This fixes bug #45127 and a host of other related to corlib compilation.
3434 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
3435 array is the method corresponding to the top-level type (this is
3436 because of the changes made to icall.c) so we change this
3439 (MethodGroupExpr.Name): This too.
3441 * typemanager.cs (GetElementType): New method which does the right
3442 thing when compiling corlib.
3444 * everywhere: Make use of the above in the relevant places.
3446 2003-07-22 Martin Baulig <martin@ximian.com>
3448 * cs-parser.jay (invocation_expression): Moved
3449 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
3450 `cast_expression', but create a InvocationOrCast which later
3451 resolves to either an Invocation or a Cast.
3453 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
3454 method; call this before EmitStatement() to make sure that this
3455 expression can be used as a statement.
3457 * expression.cs (InvocationOrCast): New class; resolves to either
3458 an Invocation or a Cast.
3460 * statement.cs (StatementExpression): Call ResolveStatement() on
3461 the ExpressionStatement before emitting it.
3463 2003-07-21 Martin Baulig <martin@ximian.com>
3465 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
3466 `ref' and `out' attributes match; fixes #46220.
3467 (MemberAccess.ResolveMemberAccess): You can't reference a type
3468 through an expression; fixes #33180.
3469 (Indexers.GetIndexersForType): Don't return the indexers from
3470 interfaces the class implements; fixes #46502.
3472 2003-07-21 Martin Baulig <martin@ximian.com>
3474 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
3475 CS0661 checks; fixes bug #30442.
3477 2003-07-21 Martin Baulig <martin@ximian.com>
3479 * decl.cs (AdditionResult): Added `Error'.
3481 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
3483 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
3484 makes cs0031.cs actually work.
3486 2003-07-20 Martin Baulig <martin@ximian.com>
3488 * namespace.cs: Fixed that bug which caused a crash when compiling
3491 2003-07-20 Miguel de Icaza <miguel@ximian.com>
3493 * typemanager.cs (LookupTypeReflection): Never expose types which
3494 are NotPublic, NestedPrivate, NestedAssembly, or
3495 NestedFamANDAssem. We used to return these, and later do a check
3496 that would report a meaningful error, but the problem is that we
3497 would not get the real match, if there was a name override.
3499 2003-07-18 Miguel de Icaza <miguel@ximian.com>
3501 * namespace.cs (Namespace, Name): Do not compute the namespace
3502 name dynamically, compute it in the constructor. This reduced
3503 memory usage by 1697 KB.
3505 * driver.cs: Use --pause to pause at the end.
3507 2003-07-17 Peter Williams <peter@newton.cx>
3509 * Makefile: Change the name of the test target so that it doesn't
3510 conflict with the recursive test target.
3512 2003-07-17 Miguel de Icaza <miguel@ximian.com>
3514 * expression.cs (LocalVariableReference.Emit, EmitAssign,
3515 AddressOf): Do not use EmitThis, that was wrong, use the actual
3518 2003-07-15 Miguel de Icaza <miguel@ximian.com>
3520 * class.cs (MethodData.Define): While checking if a method is an
3521 interface implementation, improve the test: If we are not public
3522 (use new test here: use the computed MethodAttributes directly,
3523 instead of the parsed modifier flags) check if the `implementing'
3524 method comes from an interface or not.
3526 * pending.cs (VerifyPendingMethods): Slightly better error
3529 * makefile: add test target that does the mcs bootstrap.
3531 2003-07-16 Ravi Pratap <ravi@ximian.com>
3533 * interface.cs (Define): Do nothing here since there are no
3534 members to populate etc. Move the attribute emission out of here
3535 since this was just totally the wrong place to put it. Attribute
3536 application happens during the 'Emit' phase, not in the 'Define'
3539 (Emit): Add this method and move the attribute emission here
3541 * rootcontext.cs (EmitCode): Call the Emit method on interface
3544 2003-07-14 Ravi Pratap M <ravi@ximian.com>
3546 * expression.cs (OverloadResolve): Report error only if Location
3547 is not 'Null' which means that there was a probe going on.
3549 2003-07-14 Martin Baulig <martin@ximian.com>
3551 * expression.cs (ConditionalLogicalOperator): New public class to
3552 implement user defined conditional logical operators.
3553 This is section 14.11.2 in the spec and bug #40505.
3555 2003-07-14 Martin Baulig <martin@ximian.com>
3557 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
3559 2003-07-14 Martin Baulig <martin@ximian.com>
3561 * codegen.cs (EmitContext.InFixedInitializer): New public field.
3563 * ecore.cs (IVariable.VerifyFixed): New interface method.
3565 * expression.cs (Unary.ResolveOperator): When resolving the `&'
3566 operator, check whether the variable is actually fixed. Fixes bug
3567 #36055. Set a variable definitely assigned when taking its
3568 address as required by the spec.
3570 * statement.cs (LocalInfo.IsFixed): New field.
3571 (LocalInfo.MakePinned): Set `IsFixed' to true.
3573 2003-07-14 Ravi Pratap M <ravi@ximian.com>
3575 * attribute.cs (Attribute.Resolve): While doing a Member lookup
3576 for .ctors, ensure that we only ask for members declared in the
3577 attribute type (BindingFlags.DeclaredOnly).
3581 * expression.cs (Error_WrongNumArguments): Report error 1501
3582 correctly the way CSC does.
3584 2003-07-13 Martin Baulig <martin@ximian.com>
3586 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
3587 lookup on the fully qualified name, to make things like "X.X" work
3588 where "X.X" is a fully qualified type name, but we also have a
3589 namespace "X" in the using list. Fixes #41975.
3591 2003-07-13 Martin Baulig <martin@ximian.com>
3593 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
3594 function. If we're a CompoundAssign, we need to create an embedded
3595 CompoundAssign, not an embedded Assign.
3596 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
3599 2003-07-13 Martin Baulig <martin@ximian.com>
3601 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
3602 work to fix bug #46088.
3604 2003-07-13 Ravi Pratap <ravi@ximian.com>
3606 * class.cs (Operator.Emit): Do not emit attributes here - it is
3607 taken care of by the Method class that we delegate too. This takes
3610 2003-07-10 Martin Baulig <martin@ximian.com>
3612 * expression.cs (TypeOfVoid): New class.
3613 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
3615 2003-07-10 Martin Baulig <martin@ximian.com>
3617 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
3620 2003-07-10 Martin Baulig <martin@ximian.com>
3622 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
3623 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
3625 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
3627 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
3629 2003-07-10 Martin Baulig <martin@ximian.com>
3631 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
3632 of decimal. Fixes #42850.
3634 NOTE: I also fixed the created byte blob, but this doesn't work on
3635 the MS runtime and csc never produces any byte blobs for decimal
3638 2003-07-10 Martin Baulig <martin@ximian.com>
3640 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
3641 structs; fixes #32068.
3642 (Block.AddChildVariableNames): Fixed #44302.
3644 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3646 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
3648 2003-07-07 Miguel de Icaza <miguel@ximian.com>
3650 * attribute.cs: And this test is onger needed.
3652 2003-07-08 Martin Baulig <martin@ximian.com>
3654 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
3655 inaccessible types. Fixes #36313.
3657 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
3659 * namespace.cs (NamespaceEntry): Create implicit entries for all
3660 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
3661 implicit entries for N1.N2 and N1.
3663 2003-07-08 Martin Baulig <martin@ximian.com>
3665 Rewrote the handling of namespaces to fix a lot of the issues
3666 wrt. `using' aliases etc.
3668 * namespace.cs (Namespace): Splitted this class into a
3669 per-assembly `Namespace' and a per-file `NamespaceEntry'.
3671 * typemanager.cs (TypeManager.IsNamespace): Removed.
3672 (TypeManager.ComputeNamespaces): Only compute namespaces from
3673 loaded assemblies here, not the namespaces from the assembly we're
3674 currently compiling.
3676 2003-07-08 Martin Baulig <martin@ximian.com>
3678 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
3680 2003-07-07 Miguel de Icaza <miguel@ximian.com>
3682 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
3685 I thought about the memory savings here, but LookupTypeReflection
3686 is used under already very constrained scenarios. Compiling
3687 corlib or mcs only exposes one hit, so it would not really reduce
3688 any memory consumption.
3690 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3692 * typemanager.cs: fixes bug #45889 by only adding public types from
3693 other assemblies to the list of known types.
3695 2003-07-07 Miguel de Icaza <miguel@ximian.com>
3697 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
3698 on the type we resolved.
3700 2003-07-05 Martin Baulig <martin@ximian.com>
3702 * pending.cs (PendingImplementation.ParentImplements): Don't
3703 create the proxy if the parent is abstract.
3705 * class.cs (TypeContainer.DefineIndexers): Process explicit
3706 interface implementations first. Fixes #37714.
3708 2003-07-04 Miguel de Icaza <miguel@ximian.com>
3710 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
3711 defined recursively; but since we modify the input parameters
3712 (left is set to `this' temporarily), we reset this value if the
3713 left_is_explicit is false, which gives the original semantics to
3716 * literal.cs (NullPointer): new class used to represent a null
3717 literal in a pointer context.
3719 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
3720 type is a pointer, use a NullPointer object instead of a
3721 NullLiteral. Closes 43687
3723 (ExplicitConversion): Convert pointer values using
3724 the conv opcode to the proper type.
3726 * ecore.cs (New): change ValueTypeVariable property into a method,
3727 that returns whether the valuetype is suitable for being used.
3729 * expression.cs (Binary.DoNumericPromotions): Only return if we
3730 the int constant was a valid uint, and we can return both left and
3731 right as uints. If not, we continue processing, to trigger the
3732 type conversion. This fixes 39018.
3734 * statement.cs (Block.EmitMeta): During constant resolution, set
3735 the CurrentBlock property on the emitcontext, so that we resolve
3736 constants propertly.
3738 2003-07-02 Martin Baulig <martin@ximian.com>
3740 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
3741 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
3743 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
3744 than emitting it here.
3746 * statement.cs: Fixed some more flow analysis bugs.
3748 2003-07-02 Martin Baulig <martin@ximian.com>
3750 * class.cs (MethodData.Define): When implementing interface
3751 methods, set Final unless we're Virtual.
3753 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
3754 check work for interface methods.
3756 2003-07-01 Martin Baulig <martin@ximian.com>
3758 * ecore.cs (EmitContext.This): Replaced this property with a
3759 GetThis() method which takes a Location argument. This ensures
3760 that we get the correct error location for a CS0188.
3762 2003-07-01 Miguel de Icaza <miguel@ximian.com>
3764 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
3765 ImplicitStandardConversion.
3767 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
3769 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
3771 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
3774 2003-06-30 Miguel de Icaza <miguel@ximian.com>
3776 * class.cs (Constructor.Define): Turn off initlocals for unsafe
3779 (MethodData.Define): Turn off initlocals for unsafe methods.
3781 2003-06-29 Miguel de Icaza <miguel@ximian.com>
3783 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
3784 complete; Fixes #37521.
3786 * delegate.cs: Use Modifiers.TypeAttr to compute the
3787 TypeAttributes, instead of rolling our own. This makes the flags
3788 correct for the delegates.
3790 2003-06-28 Miguel de Icaza <miguel@ximian.com>
3792 * class.cs (Constructor.Define): Set the private flag for static
3793 constructors as well.
3795 * cs-parser.jay (statement_expression): Set the return value to
3796 null, to avoid a crash when we catch an error.
3798 2003-06-24 Miguel de Icaza <miguel@ximian.com>
3800 * cs-parser.jay: Applied patch from Jackson that adds support for
3801 extern and unsafe modifiers to destructor declarations.
3803 * expression.cs: Report error 21 if the user is trying to index a
3806 * driver.cs: Add an error message, suggested by the bug report.
3808 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
3809 if we do not have a ": this ()" constructor initializer. Fixes 45149
3811 2003-06-14 Miguel de Icaza <miguel@ximian.com>
3813 * namespace.cs: Add some information to reduce FAQs.
3815 2003-06-13 Miguel de Icaza <miguel@ximian.com>
3817 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
3818 underlying enumeration types. Fixes #43915.
3820 * expression.cs: Treat ushort/short as legal values to be used in
3823 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
3825 * delegate.cs: transfer custom attributes for paramenters from
3826 the delegate declaration to Invoke and BeginInvoke.
3828 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
3830 * attribute.cs: handle custom marshalers and emit marshal info
3833 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
3835 * makefile.gnu: Added anonymous.cs to the compiler sources.
3837 2003-05-28 Miguel de Icaza <miguel@ximian.com>
3839 * iterators.cs: Change the name of the proxy class to include two
3842 * cs-parser.jay: Update grammar to include anonymous methods.
3844 * anonymous.cs: new file.
3846 2003-05-27 Miguel de Icaza <miguel@ximian.com>
3848 * class.cs (Field.Define): Add missing test for pointers and
3851 2003-05-27 Ravi Pratap <ravi@ximian.com>
3853 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
3854 we use the stobj opcode.
3856 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
3857 since it wasn't the correct fix.
3859 It still is puzzling that we are required to use stobj for IntPtr
3860 which seems to be a ValueType.
3862 2003-05-26 Miguel de Icaza <miguel@ximian.com>
3864 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
3865 during regular simple name resolution. Now, the trick is that
3866 instead of returning for processing the simplename, we do a
3867 TypeManager.LookupType (ie, a rooted lookup as opposed to a
3868 contextual lookup type). If a match is found, return that, if
3869 not, return for further composition.
3871 This fixes long-standing 30485.
3873 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
3874 using the address to initialize an object, do an Stobj instead of
3875 using the regular Stelem.
3877 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
3878 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
3879 Because if we are a BaseIndexerAccess that value will be true.
3882 * statement.cs (GotoCase.Resolve): Return after reporting an
3883 error, do not attempt to continue.
3885 * expression.cs (PointerArithmetic.Emit): If our operand is a
3886 long, convert our constants to match the operand before
3887 multiplying. Convert to I type before adding. Fixes 43670.
3889 2003-05-14 Ravi Pratap <ravi@ximian.com>
3891 * enum.cs (ImplicitConversionExists) : Rename to
3892 ImplicitEnumConversionExists to remove ambiguity.
3894 * ecore.cs (NullCast): New type of cast expression class which
3895 basically is very similar to EmptyCast with the difference being
3896 it still is a constant since it is used only to cast a null to
3900 * convert.cs (ImplicitReferenceConversion): When casting a null
3901 literal, we return a NullCast.
3903 * literal.cs (NullLiteralTyped): Remove - I don't see why this
3904 should be around anymore.
3906 The renaming (reported was slightly wrong). Corrections:
3908 ConvertImplicitStandard -> ImplicitConversionStandard
3909 ConvertExplicitStandard -> ExplicitConversionStandard
3911 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
3912 before passing them in !
3914 * convert.cs (ImplicitConversionStandard): When comparing for
3915 equal expr and target types, ensure that expr is not a
3918 In general, we must not be checking (expr_type ==
3919 target_type) in the top level conversion methods
3920 (ImplicitConversion, ExplicitConversion etc). This checking is
3921 done in the methods that they delegate to.
3923 2003-05-20 Miguel de Icaza <miguel@ximian.com>
3925 * convert.cs: Move Error_CannotConvertType,
3926 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
3927 ImplicitNumericConversion, ImplicitConversionExists,
3928 ImplicitUserConversionExists, StandardConversionExists,
3929 FindMostEncompassedType, FindMostSpecificSource,
3930 FindMostSpecificTarget, ImplicitUserConversion,
3931 ExplicitUserConversion, GetConversionOperators,
3932 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
3933 TryImplicitIntConversion, Error_CannotConvertImplicit,
3934 ConvertImplicitRequired, ConvertNumericExplicit,
3935 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
3936 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
3939 Perform the following renames:
3941 StandardConversionExists -> ImplicitStandardConversionExists
3942 ConvertImplicit -> ImplicitConversion
3943 ConvertImplicitStandard -> ImplicitStandardConversion
3944 TryImplicitIntConversion -> ImplicitIntConversion
3945 ConvertImplicitRequired -> ImplicitConversionRequired
3946 ConvertNumericExplicit -> ExplicitNumericConversion
3947 ConvertReferenceExplicit -> ExplicitReferenceConversion
3948 ConvertExplicit -> ExplicitConversion
3949 ConvertExplicitStandard -> ExplicitStandardConversion
3951 2003-05-19 Martin Baulig <martin@ximian.com>
3953 * statement.cs (TypeInfo.StructInfo): Made this type protected.
3954 (TypeInfo): Added support for structs having structs as fields.
3956 * ecore.cs (FieldExpr): Implement IVariable.
3957 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
3958 VariableInfo for the field.
3960 2003-05-18 Martin Baulig <martin@ximian.com>
3962 * expression.cs (This.DoResolve): Report a CS0027 if we're
3963 emitting a field initializer.
3965 2003-05-18 Martin Baulig <martin@ximian.com>
3967 * expression.cs (This.ResolveBase): New public function.
3968 (This.DoResolve): Check for CS0188.
3970 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
3973 * ecore.cs (MethodGroupExpr.DoResolve): Set the
3974 `instance_expression' to null if we don't have any non-static
3977 2003-05-18 Martin Baulig <martin@ximian.com>
3979 Reworked the way how local variables and parameters are handled by
3980 the flow analysis code.
3982 * statement.cs (TypeInfo, VariableMap): New public classes.
3983 (VariableInfo): New public class. This is now responsible for
3984 checking whether a variable has been assigned. It is used for
3985 parameters and local variables.
3986 (Block.EmitMeta): Take the InternalParameters as argument; compute
3987 the layout of the flow vectors here.
3988 (Block.LocalMap, Block.ParameterMap): New public properties.
3989 (FlowBranching): The .ctor doesn't get the InternalParameters
3990 anymore since Block.EmitMeta() now computes the layout of the flow
3992 (MyStructInfo): This class is now known as `StructInfo' and nested
3993 in `TypeInfo'; we don't access this directly anymore.
3995 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
3996 property and removed IsAssigned(), IsFieldAssigned(),
3997 SetAssigned() and SetFieldAssigned(); we now call them on the
3998 VariableInfo so we don't need to duplicate this code everywhere.
4000 * expression.cs (ParameterReference): Added `Block block' argument
4002 (LocalVariableReference, ParameterReference, This): The new
4003 VariableInfo class is now responsible for all the definite
4006 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
4007 IsParameterAssigned, SetParameterAssigned): Removed.
4009 2003-05-18 Martin Baulig <martin@ximian.com>
4011 * typemanager.cs (InitCoreTypes): Try calling
4012 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
4013 the 3-args-version. Corlib now also needs our `void_type'.
4014 (GetMethod): Added overloaded version which takes an optional
4015 `bool report_errors' to allow lookups of optional methods.
4017 2003-05-12 Martin Baulig <martin@ximian.com>
4019 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
4020 only used for locals and not for parameters.
4022 2003-05-12 Miguel de Icaza <miguel@ximian.com>
4024 * support.cs (InternalParameters.ParameterType): Return the
4025 ExternalType of the parameter.
4027 * parameter.cs (Parameter.ExternalType): drop the two arguments,
4030 2003-05-11 Miguel de Icaza <miguel@ximian.com>
4032 * class.cs (MethodData.Define): Do not set the `newslot' on
4033 interface members, if they are also flagged as "override".
4035 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
4036 better code for ++i and i++. This only works for static fields
4037 and local variables.
4039 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
4040 want to pull the DeclSpace out of the builder_to_declspace instead
4041 of the TypeBuilder (like in TypeContainer.FindMembers).
4043 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
4044 instead of LookupTypeContainer. Fixes the crash on .NET for
4045 looking up interface members.
4047 * const.cs: Create our own emit context during the Definition
4048 stage, so that constants are evaluated in the proper context, when
4049 a recursive definition happens.
4051 2003-05-11 Martin Baulig <martin@ximian.com>
4053 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
4054 new block for a switch section.
4055 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
4056 the adding/lookup in the switch block. Fixes #39828.
4058 2003-05-09 Miguel de Icaza <miguel@ximian.com>
4060 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
4061 functionality: I needed to convert the data after I had performed
4062 the add/sub operation into the operands type size.
4064 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
4065 pass the type for the box operation, otherwise the resulting
4066 object would have been of type object.
4068 (BoxedCast): Add constructor to specify the type to box as.
4070 2003-05-07 Miguel de Icaza <miguel@ximian.com>
4072 * iterators.cs: I was reusing the `count' variable inadvertently,
4073 take steps to not allow this to happen.
4075 2003-05-06 Miguel de Icaza <miguel@ximian.com>
4077 * attribute.cs (Attribute.Resolve): Params attributes are encoded
4078 by creating an array at the point where the params starts and
4079 putting all those arguments there, then adjusting the size of the
4082 2003-05-05 Miguel de Icaza <miguel@ximian.com>
4084 * expression.cs (New.AddressOf): Implement interface
4085 IMemoryLocation. This is used when the `new' operator is used in
4086 the context of an invocation to a method on a value type.
4088 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
4091 * namespace.cs: Also check the using aliases here.
4093 * driver.cs: Move the test for using validity after the types have
4094 been entered, so we do a single pass that also includes the using
4097 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
4098 in the regular case. CreateSiblingForFinally is doing extra
4101 * attribute.cs (GetAttributeArgumentExpression): Store the result
4102 on an out value, and use the return value to indicate failure
4103 instead of using null (which is a valid return for Constant.GetValue).
4105 * statement.cs: Perform the analysis flow for the increment
4106 portion after the statement, because this will be the real flow of
4107 execution. Fixes #42385
4109 * codegen.cs (EmitContext.EmitArgument,
4110 EmitContext.EmitStoreArgument): New helper functions when the
4111 RemapToProxy flag is set.
4113 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
4116 Add support for remapping parameters.
4118 * iterators.cs: Propagate parameter values; Store parameter
4119 values in the proxy classes.
4121 2003-05-04 Miguel de Icaza <miguel@ximian.com>
4123 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
4124 need a proxy reference; I do not know what I was thinking
4126 * cs-parser.jay (constructor_initializer): catch another error,
4127 and display nice message.
4129 (field_declaration): catch void field declaration
4130 to flag a better error.
4132 * class.cs (MemberBase.CheckBase): Report an error instead of a
4133 warning if a new protected member is declared in a struct.
4134 (Field.Define): catch the error of readonly/volatile.
4136 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
4138 (FieldExpr.AddressOf): ditto. Catch error where the address of a
4139 volatile variable is taken
4141 2003-05-02 Miguel de Icaza <miguel@ximian.com>
4143 * statement.cs (Fixed.Resolve): Report an error if we are not in
4146 2003-05-01 Miguel de Icaza <miguel@ximian.com>
4148 * typemanager.cs: reuse the code that handles type clashes for
4149 delegates and enumerations.
4151 * class.cs (Report28): Always report.
4153 * expression.cs (EncodeAsAttribute): Allow nulls here.
4155 2003-04-28 Miguel de Icaza <miguel@ximian.com>
4157 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
4158 the functionality for testing whether an expression is valid for
4159 an attribute here. Also handle the case of arrays of elements
4162 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
4163 encoding a linear array into an array of objects that are suitable
4164 to be passed to an CustomAttributeBuilder.
4166 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
4168 * ecore.cs: (FieldExpr): Handle field remapping here.
4170 * iteratators.cs: Pass the instance variable (if the method is an
4171 instance method) to the constructors, so we can access the field
4172 variables on the class.
4174 TODO: Test this with structs. I think the THIS variable on
4175 structs might have to be a pointer, and not a refenrece
4177 2003-04-27 Miguel de Icaza <miguel@ximian.com>
4179 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
4180 local variables to fields in a proxy class.
4182 * iterators.cs (PopulateProxy): Rename our internal fields to
4184 Create a <THIS> field if we are an instance method, so we can
4185 reference our parent container variables.
4186 (MapVariable): Called back from the EmitContext code to enter a
4187 new variable to field mapping into the proxy class (we just create
4191 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
4192 for using the remapped locals to fields.
4194 I placed the code here, because that gives the same semantics to
4195 local variables, and only changes the Emit code.
4197 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
4198 statements inside iterators.
4199 (VariableInfo): Add a FieldBuilder for the cases when we are
4200 remapping local variables to fields in a proxy class
4202 * ecore.cs (SimpleNameResolve): Avoid testing two times for
4203 current_block != null.
4205 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
4206 not cope with strings, as it has been moved to the
4207 TableSwitchEmit. Fixed bug in switch generation.
4209 * expression.cs (New.DoResolve): Provide more context for the user
4210 when reporting an error.
4212 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
4215 * expression.cs (MemberAccess.DoResolve): When we get a type back,
4216 check the permissions for it. Note than in a type-resolution
4217 context the check was already present in DeclSpace.ResolveType,
4218 but was missing from the MemberAccess.
4220 (ArrayCreation.CheckIndices): warn if the user has
4221 more nested levels of expressions, but there are no more
4222 dimensions specified. Avoids crash on bug 41906.
4224 2003-04-26 Miguel de Icaza <miguel@ximian.com>
4226 * statement.cs (Block): replace Implicit bool, for a generic
4228 New flag: `Unchecked'. This is used during the EmitMeta phase
4229 (which is out-of-line with the regular Resolve/Emit process for a
4230 statement, as this is done ahead of time, but still gets a chance
4231 to call constant resolve).
4233 (Block.Flags): new enum for adding a new flag.
4235 (Block.EmitMeta): track the state of unchecked.
4237 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
4238 to enable constant resolution to work there as well.
4240 2003-04-22 Miguel de Icaza <miguel@ximian.com>
4242 * typemanager.cs (ienumerable_type): Also look up
4243 System.Collections.IEnumerable.
4245 2003-04-21 Miguel de Icaza <miguel@ximian.com>
4247 TODO: Test more than one conditional per method.
4249 * class.cs (Indexer.Define): Report the location where the user is
4250 referencing the unsupported feature.
4252 (MethodData): Overload the use of `conditionals' to
4253 minimize the creation of needless ArrayLists. This saves roughly
4254 212kb on my machine.
4256 (Method): Implement the new IIteratorContainer interface.
4257 (Method.SetYields): Implement the method by setting the ModFlags
4258 to contain METHOD_YIELDS.
4260 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
4261 which just got set to null.
4263 * iterators.cs: New file.
4265 (Yield, YieldBreak): New statements.
4267 * statement.cs (Return.Resolve): Flag an error if we are used in
4270 * codegen.cs (InIterator): New flag set if the code is being
4271 compiled in an iterator method.
4273 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
4274 internal modifier, and we just use it to avoid adding extra
4275 fields, as this is seldom used.
4277 * cs-parser.jay: Add yield_statement (yield and yield break).
4279 * driver.cs: New flag -v2 to turn on version 2 features.
4281 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
4282 hashtable when v2 is enabled.
4284 2003-04-20 Miguel de Icaza <miguel@ximian.com>
4286 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
4287 there is already a namespace defined with this name.
4289 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
4290 people upgraded their corlibs.
4292 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
4293 always use fully qualified types, no need to use the compiler
4296 (TypeManager.IsNamespace): Use binarysearch.
4298 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
4299 AddDelegate): I did not quite use the new IsValid API properly: I
4300 have to pass the short-name and the fullname. I was passing only
4301 the basename instead of the fullname sometimes.
4303 (TypeContainer.DefineType): call NamespaceClash.
4305 * interface.cs (Interface.DefineType): use NamespaceClash before
4308 * delegate.cs (Delegate.DefineType): use NamespaceClash before
4311 * enum.cs: (Enum.DefineType): use NamespaceClash before
4314 * typemanager.cs (: 3-line patch that gives us some tasty 11%
4315 speed increase. First, use the negative_hits cache when we get a
4316 negative. Second, add the type with its full original name
4317 instead of the new . and + encoded name (reflection uses + to
4318 separate type from a nested type). Use LookupTypeReflection
4319 directly which bypasses the type->name hashtable (that we already
4320 know does not contain the type.
4322 * decl.cs (DeclSpace.ResolveTypeExpr): track the
4323 location/container type.
4325 * driver.cs: When passing utf8, use directly the UTF8Encoding.
4327 2003-04-19 Miguel de Icaza <miguel@ximian.com>
4329 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
4331 * delegate.cs (NewDelegate.Resolve): Test whether an instance
4332 method is being referenced in the method group from a static
4333 context, and report error 120 if so.
4335 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
4338 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
4339 is created, we create the A namespace).
4341 * cs-parser.jay: A namespace also introduces a DeclarationFound.
4344 2003-04-18 Miguel de Icaza <miguel@ximian.com>
4346 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
4347 invocation to ModuleBuilder.GetType with the same values will
4348 return a new type instance, so we need to cache its return
4351 * expression.cs (Binary.ResolveOperator): Only allow the compare
4352 operators on enums if they are of the same type.
4354 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
4355 types of ValueType on their own case. Before we were giving them
4356 the same treatment as objects.
4358 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
4359 fullname. Short name is used to compare against container name.
4360 Fullname is used to check against defined namespace names.
4362 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
4363 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
4365 (Method.CheckBase): Call parent.
4366 (MemberBase.CheckBase): Check for protected members on sealed
4368 (PropertyBase.CheckBase): Call parent.
4369 (Field.Define): Call parent.
4371 * report.cs: Negative error codes are now mapped to 8000 - code,
4372 so that the display is render more nicely.
4374 * typemanager.cs: Do not use try/catch, instead report a regular
4377 (GetPointerType, GetReferenceType): These methods provide
4378 mechanisms to obtain the T* and T& from a T. We had the code
4379 previously scattered around the code base, and it also used
4380 TypeManager.LookupType that would go through plenty of caches.
4381 This one goes directly to the type source.
4383 In some places we did the Type.GetType followed by
4384 ModuleBuilder.GetType, but not in others, so this unifies the
4387 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
4388 statements now that we have namespace information.
4390 * typemanager.cs (IsNamespace): New method, returns whether the
4391 string presented is a namespace or not.
4393 (ComputeNamespaces): New public entry point, computes the list of
4394 available namespaces, using the GetNamespaces API call in Mono, or
4395 the slower version in MS.NET.
4397 Now before we start the semantic analysis phase, we have a
4398 complete list of namespaces including everything that the user has
4401 Deleted old code to cache namespaces in .nsc files.
4403 2003-04-17 Miguel de Icaza <miguel@ximian.com>
4405 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
4406 class/struct location definition Location for the implicit
4407 constructor location.
4409 (Operator.Define): Use the location of the operator for the
4410 implicit Method definition.
4412 (Constructor.Emit): use the constructor location for the implicit
4413 base initializer constructor.
4415 * ecore.cs: Remove ITypeExpression. This interface is now gone,
4416 and the Expression class now contains two new methods:
4418 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
4419 isolate type lookup from the rest of the resolution process.
4421 Since we use Expressions to hold type definitions due to the way
4422 we parse the input we have historically overloaded Resolve to
4423 perform the Type lookups if a special flag is passed. Now this is
4424 eliminated and two methods take their place.
4426 The differences in the two methods between xStep and xTerminal is
4427 that xStep is involved in our current lookup system that uses
4428 SimpleNames to compose a name, while xTerminal is used just to
4429 catch the case where the simplename lookup failed.
4431 2003-04-16 Miguel de Icaza <miguel@ximian.com>
4433 * expression.cs (ResolveMemberAccess): Remove redundant code.
4434 TypeExpr expressions are always born fully resolved.
4436 * interface.cs (PopulateMethod): Do not lookup the types twice.
4437 We were doing it once during SemanticAnalysis and once during
4440 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
4441 in local variable type definitions, were being returned as a
4442 SimpleName (we decomposed everything into a string), that is
4443 because primary_expression was being used instead of a type in the
4444 grammar (reduce/reduce conflicts).
4446 The part that was wrong is that we converted the expression into a
4447 string (an oversimplification in one hand, compounded with primary
4448 expressions doing string concatenation).
4454 Would return "A.B.C[]" as a SimpleName. This stopped things like
4455 using clauses from working on this particular context. And a type
4456 was being matched directly against "A.B.C[]".
4458 We now use the correct approach, and allow for ComposedCast to be
4459 part of the unary expression. So the "A.B.C []" become a composed
4460 cast of "A.B.C" (as a nested group of MemberAccess with a
4461 SimpleName at the end) plus the rank composition "[]".
4465 2003-04-10 Miguel de Icaza <miguel@ximian.com>
4467 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
4468 for the access level checking.
4470 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
4471 `TypeContainer container', because I kept getting confused when I
4472 was debugging this code.
4474 * expression.cs (Indexers): Instead of tracking getters/setters,
4475 we now track them in parallel. We create one arraylist less, but
4476 most importantly it is possible now for the LValue code to find a
4477 matching get for a set.
4479 (IndexerAccess.DoResolveLValue): Update the code.
4480 GetIndexersForType has been modified already to extract all the
4481 indexers from a type. The code assumed it did not.
4483 Also make the code set the correct return type for the indexer.
4484 This was fixed a long time ago for properties, but was missing for
4485 indexers. It used to be void_type.
4487 (Binary.Emit): Test first for doubles instead of
4488 floats, as they are more common.
4490 (Binary.EmitBranchable): Use the .un version of the branch opcodes
4491 when dealing with floats and the <=, >= operators. This fixes bug
4494 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
4495 to load the array value by emitting a load on the foreach variable
4496 type. This was incorrect.
4498 We now emit the code to load an element using the the array
4499 variable type, and then we emit the conversion operator.
4503 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
4505 * attribute.cs: Avoid allocation of ArrayLists in the common case.
4507 2003-04-09 Miguel de Icaza <miguel@ximian.com>
4509 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
4510 test for protection before we test for signatures.
4512 (MethodSignature.ToString): implement.
4514 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
4515 to the case where we reduced into a LongConstant.
4517 * decl.cs (CheckAccessLevel): If the type is an array, we can not
4518 depend on whether the information is acurrate, because the
4519 Microsoft runtime will always claim that the array type is public,
4520 regardless of the real state.
4522 If the type is a pointer, another problem happens: the type is
4523 reported as non-public in Microsoft.
4525 In both cases we have to call CheckAccessLevel recursively with
4526 the underlying type as the argument to be tested.
4528 2003-04-08 Miguel de Icaza <miguel@ximian.com>
4530 * assign.cs (Assign.Emit): If we are dealing with a compound
4531 assignment expression, we should use the code path that stores the
4532 intermediate result in a temporary value. This fixes #40903.
4534 *expression.cs (Indirection.ToString): Provide ToString method for
4537 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
4539 * class.cs: Null out fields holding references to Block objects so
4540 they can be garbage collected.
4542 * expression.cs (OverloadResolve): Remove unused local.
4544 2003-04-07 Martin Baulig <martin@ximian.com>
4546 * codegen.cs (EmitContext.CurrentFile): New public field.
4547 (EmitContext.Mark): Use the CurrentFile to check whether the
4548 location is in the correct file.
4549 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
4551 2003-04-07 Martin Baulig <martin@ximian.com>
4553 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
4555 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
4556 location. [FIXME: The location argument which gets passed to this
4557 method is sometimes wrong!]
4559 2003-04-07 Nick Drochak <ndrochak@gol.com>
4561 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
4563 2003-04-07 Miguel de Icaza <miguel@ximian.com>
4565 * expression.cs (Indirection.EmitAssign): We were using the
4566 temporary, but returning immediately instead of continuing the
4569 2003-04-06 Martin Baulig <martin@ximian.com>
4571 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
4572 if it's a nested child, but also deriving from the outer class.
4575 * typemanager.cs (IsNestedChildOf): Make this work if it's a
4576 nested child, but also deriving from the outer class. See
4578 (FilterWithClosure): We may access private members of the outer
4579 class if we're a nested child and deriving from the outer class.
4580 (RealMemberLookup): Only set `closure_private_ok' if the
4581 `original_bf' contained BindingFlags.NonPublic.
4583 2003-04-05 Martin Baulig <martin@ximian.com>
4585 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
4587 2003-04-02 Miguel de Icaza <miguel@ximian.com>
4589 * class.cs (Event.Define): Do not allow abstract events to have
4592 2003-04-01 Miguel de Icaza <miguel@ximian.com>
4594 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
4595 block in event declarations.
4597 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
4598 value type, get its address.
4600 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
4601 leaving a class on the stack instead of a boolean value (int
4602 0/1). Change the code so we compare against null, and then the
4603 result against zero.
4605 * class.cs (TypeContainer.GetClassBases): We were checking for the
4606 parent class being sealed too late.
4608 * expression.cs (Binary.Emit): For <= and >= when dealing with
4609 floating point values, use cgt.un and clt.un instead of cgt and
4612 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
4614 * statement.cs: Apply the same optimization as MS: skip the
4615 GetEnumerator returning an IEnumerator, and use the one returning a
4616 CharEnumerator instead. This allows us to avoid the try-finally block
4619 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
4621 * cs-parser.jay: Attributes cannot be applied to
4622 namespaces. Fixes #40473
4624 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4627 (Add*): check if the name is valid using the full name for constants,
4628 fields, properties and events.
4630 2003-03-28 Miguel de Icaza <miguel@ximian.com>
4632 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
4633 char constants to be part of the enumeration.
4635 * expression.cs (Conditional.DoResolve): Add support for operator
4636 true. Implements the missing functionality from 14.12
4638 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
4639 operator true/false as required by the spec.
4641 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
4642 implicit conversion to boolean.
4644 * statement.cs (Statement.ResolveBoolean): A boolean expression is
4645 also one where the type implements `operator true'.
4647 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
4648 get an expression that will invoke operator true based on an
4651 (GetConversionOperators): Removed the hack that called op_True
4654 (Expression.ResolveBoolean): Move this from Statement.
4656 2003-03-17 Miguel de Icaza <miguel@ximian.com>
4658 * ecore.cs (FieldExpr): do not allow initialization of initonly
4659 fields on derived classes
4661 2003-03-13 Martin Baulig <martin@ximian.com>
4663 * statement.cs (Block.Emit): Call ig.BeginScope() and
4664 ig.EndScope() when compiling with debugging info; call
4665 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
4667 2003-03-08 Miguel de Icaza <miguel@ximian.com>
4669 * expression.cs (Indexers): Do not construct immediately, allow
4670 for new members to be appended as we go. Fixes 38143
4672 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4674 * expression.cs: save/restore context when resolving an unchecked
4677 2003-03-05 Miguel de Icaza <miguel@ximian.com>
4679 * cfold.cs: Catch division by zero in modulus operator during
4682 2003-03-03 Miguel de Icaza <miguel@ximian.com>
4684 * interface.cs (Interface.DefineMembers): Avoid defining members
4687 2003-02-27 Miguel de Icaza <miguel@ximian.com>
4689 * driver.cs: handle the +/- options for -noconfig
4691 * statement.cs (Unckeched.Resolve): Also track the state of
4692 unchecked in the Resolve phase.
4694 2003-02-27 Martin Baulig <martin@ximian.com>
4696 * ecore.cs (Expression.MemberLookup): Don't create a
4697 MethodGroupExpr for something which is not a method. Fixes #38291.
4699 2003-02-25 Miguel de Icaza <miguel@ximian.com>
4701 * class.cs (MemberBase.CheckParameters): Also check that the type
4702 is unmanaged if it is a pointer.
4704 * expression.cs (SizeOf.Resolve): Add location information.
4706 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
4707 a managed type is declared.
4709 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
4710 parameter modifiers as well. Fixes bug 38606
4712 * class.cs: Very sad. Am backing out the speed up changes
4713 introduced by the ArrayList -> Array in the TypeContainer, as they
4714 were not actually that much faster, and introduced a bug (no error
4715 reports on duplicated methods).
4717 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
4718 source first, this will guarantee that we have a valid expression
4719 before calling in lower levels functions that will require a
4720 resolved object. Then use this original_source in the
4721 target.ResolveLValue instead of the original source that was
4724 Another change. Use target.Resolve instead of LValueResolve.
4725 Although we are resolving for LValues, we will let the Assign code
4726 take care of that (it will be called again from Resolve). This
4727 basically allows code like this:
4729 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
4730 class Y { void A (X x) { x [0] += o; }
4732 The problem was that the indexer was trying to resolve for
4733 set_Item (idx, object o) and never finding one. The real set_Item
4734 was set_Item (idx, X). By delaying the process we get the right
4739 2003-02-23 Martin Baulig <martin@ximian.com>
4741 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
4742 while calling DoEmit ().
4744 * codegen.cs (EmitContext.Mark): Don't mark locations in other
4745 source files; if you use the #line directive inside a method, the
4746 compiler stops emitting line numbers for the debugger until it
4747 reaches the end of the method or another #line directive which
4748 restores the original file.
4750 2003-02-23 Martin Baulig <martin@ximian.com>
4752 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
4754 2003-02-23 Martin Baulig <martin@ximian.com>
4756 * statement.cs (Block.AddChildVariableNames): We need to call this
4757 recursively, not just for our immediate children.
4759 2003-02-23 Martin Baulig <martin@ximian.com>
4761 * class.cs (Event.Define): Always make the field private, like csc does.
4763 * typemanager.cs (TypeManager.RealMemberLookup): Make events
4764 actually work, fixes bug #37521.
4766 2003-02-23 Miguel de Icaza <miguel@ximian.com>
4768 * delegate.cs: When creating the various temporary "Parameters"
4769 classes, make sure that we call the ComputeAndDefineParameterTypes
4770 on those new parameters (just like we do with the formal ones), to
4771 allow them to be resolved in the context of the DeclSpace.
4773 This fixes the bug that Dick observed in Bugzilla #38530.
4775 2003-02-22 Miguel de Icaza <miguel@ximian.com>
4777 * expression.cs (ResolveMemberAccess): When resolving a constant,
4778 do not attempt to pull a constant if the value was not able to
4779 generate a valid constant.
4781 * const.cs (LookupConstantValue): Do not report more errors than required.
4783 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4785 * expression.cs: fixes bug #38328.
4787 2003-02-18 Miguel de Icaza <miguel@ximian.com>
4789 * class.cs: Changed all the various members that can be part of a
4790 class from being an ArrayList to be an Array of the right type.
4791 During the DefineType type_list, interface_list, delegate_list and
4792 enum_list are turned into types, interfaces, delegates and enums
4795 And during the member population, indexer_list, event_list,
4796 constant_list, field_list, instance_constructor_list, method_list,
4797 operator_list and property_list are turned into their real arrays.
4799 Although we could probably perform this operation earlier, for
4800 good error reporting we need to keep the lists and remove the
4801 lists for longer than required.
4803 This optimization was triggered by Paolo profiling the compiler
4804 speed on the output of `gen-sample-program.pl' perl script.
4806 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
4807 not crash in methods like MemberLookupFailed that use this field.
4809 This problem arises when the compiler fails to resolve a type
4810 during interface type definition for example.
4812 2003-02-18 Miguel de Icaza <miguel@ximian.com>
4814 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
4815 inherit from System.Object, so we have to stop at null, not only
4816 when reaching System.Object.
4818 2003-02-17 Miguel de Icaza <miguel@ximian.com>
4820 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
4821 DeclaredOnly because the parent indexer might have had a different
4822 name, but did not loop until the top of the hierarchy was reached.
4824 The problem this one fixes is 35492: when a class implemented an
4825 indexer from an interface, we were getting the interface method
4826 (which was abstract) and we were flagging an error (can not invoke
4829 This also keeps bug 33089 functioning, and test-148 functioning.
4831 * typemanager.cs (IsSpecialMethod): The correct way of figuring
4832 out if a method is special is to see if it is declared in a
4833 property or event, or whether it is one of the predefined operator
4834 names. This should fix correctly #36804.
4836 2003-02-15 Miguel de Icaza <miguel@ximian.com>
4838 The goal here is to remove the dependency on EmptyCast.Peel ().
4839 Killing it completely.
4841 The problem is that currently in a number of places where
4842 constants are expected, we have to "probe" for an EmptyCast, and
4843 Peel, which is not the correct thing to do, as this will be
4844 repetitive and will likely lead to errors.
4846 The idea is to remove any EmptyCasts that are used in casts that
4847 can be reduced to constants, so we only have to cope with
4850 This bug hunt was triggered by Bug 37363 and the desire to remove
4851 the duplicate pattern where we were "peeling" emptycasts to check
4852 whether they were constants. Now constants will always be
4855 * ecore.cs: Use an enumconstant here instead of wrapping with
4858 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
4859 throwing me off. By handling this we can get rid of a few hacks.
4861 * statement.cs (Switch): Removed Peel() code.
4863 2003-02-14 Miguel de Icaza <miguel@ximian.com>
4865 * class.cs: Location information for error 508
4867 * expression.cs (New.DoResolve): Add a guard against double
4868 resolution of an expression.
4870 The New DoResolve might be called twice when initializing field
4871 expressions (see EmitFieldInitializers, the call to
4872 GetInitializerExpression will perform a resolve on the expression,
4873 and later the assign will trigger another resolution
4875 This leads to bugs (#37014)
4877 * delegate.cs: The signature for EndInvoke should contain any ref
4878 or out parameters as well. We were not doing this in the past.
4880 * class.cs (Field.Define): Do not overwrite the type definition
4881 inside the `volatile' group. Turns out that volatile enumerations
4882 were changing the type here to perform a validity test, which
4885 2003-02-12 Miguel de Icaza <miguel@ximian.com>
4887 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
4888 and structs, we do not want to load the instance variable
4890 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
4891 enum_type has to be handled like an object reference (implicit
4892 conversions exists from this to object), but the regular IsClass
4893 and IsValueType tests will never return true for this one.
4895 Also we use TypeManager.IsValueType instead of type.IsValueType,
4896 just for consistency with the rest of the code (this is only
4897 needed if we ever use the construct exposed by test-180.cs inside
4898 corlib, which we dont today).
4900 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
4902 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
4905 2003-02-09 Martin Baulig <martin@ximian.com>
4907 * namespace.cs (Namespace..ctor): Added SourceFile argument.
4908 (Namespace.DefineNamespaces): New static public method; this is
4909 called when we're compiling with debugging to add all namespaces
4912 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
4913 pass it to the Namespace's .ctor.
4915 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
4916 and MethodBase arguments; pass the namespace ID to the symwriter;
4917 pass the MethodBase instead of the token to the symwriter.
4918 (SymbolWriter.DefineNamespace): New method to add a namespace to
4921 2003-02-09 Martin Baulig <martin@ximian.com>
4923 * symbolwriter.cs: New file. This is a wrapper around
4924 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
4925 methods here in near future.
4927 2003-02-09 Martin Baulig <martin@ximian.com>
4929 * codegen.cs (EmitContext.Mark): Just pass the arguments to
4930 ILGenerator.MarkSequencePoint() which are actually used by the
4933 2003-02-09 Martin Baulig <martin@ximian.com>
4935 * location.cs (SourceFile): New public sealed class. This
4936 contains the name and an index which is used in the location's token.
4937 (Location): Reserve an appropriate number of bits in the token for
4938 the source file instead of walking over that list, this gives us a
4939 really huge performance improvement when compiling with debugging.
4941 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
4942 `SourceFile' argument instead of a string.
4943 (Driver.ProcessFile): Add all the files via Location.AddFile(),
4944 but don't parse/tokenize here, we need to generate the list of all
4945 source files before we do that.
4946 (Driver.ProcessFiles): New static function. Parses/tokenizes all
4949 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
4950 instead of a string.
4952 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
4955 2003-02-09 Martin Baulig <martin@ximian.com>
4957 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
4958 filename on `#line default'.
4960 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
4962 * statement.cs: don't clear the pinned var when the fixed statement
4963 returns from the method (fixes bug#37752).
4965 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
4967 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
4970 2003-02-07 Martin Baulig <martin@ximian.com>
4972 * driver.cs: Removed the `--debug-args' command line argument.
4974 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
4975 automatically by the AsssemblyBuilder.
4976 (CodeGen.InitializeSymbolWriter): We don't need to call any
4977 initialization function on the symbol writer anymore. This method
4978 doesn't take any arguments.
4980 2003-02-03 Miguel de Icaza <miguel@ximian.com>
4982 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
4983 from referenced assemblies as well.
4985 2003-02-02 Martin Baulig <martin@ximian.com>
4987 * class.cs (MethodData.Emit): Generate debugging info for external methods.
4989 2003-02-02 Martin Baulig <martin@ximian.com>
4991 * class.cs (Constructor.Emit): Open the symbol writer before
4992 emitting the constructor initializer.
4993 (ConstructorInitializer.Emit): Call ec.Mark() to allow
4994 single-stepping through constructor initializers.
4996 2003-01-30 Miguel de Icaza <miguel@ximian.com>
4998 * class.cs: Handle error 549: do not allow virtual methods in
5001 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
5003 * decl.cs: Check access levels when resolving types
5005 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
5007 * statement.cs: Add parameters and locals set in catch blocks that might
5008 return to set vector
5010 2003-01-29 Miguel de Icaza <miguel@ximian.com>
5012 * class.cs (Operator): Set the SpecialName flags for operators.
5014 * expression.cs (Invocation.DoResolve): Only block calls to
5015 accessors and operators on SpecialName methods.
5017 (Cast.TryReduce): Handle conversions from char constants.
5020 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
5022 * statement.cs: small memory and time optimization in FlowBranching.
5024 2003-01-28 Pedro Mart <yoros@wanadoo.es>
5026 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
5027 problem that the last fix but in the other sid (Set).
5029 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
5030 access when there is no indexer in the hierarchy.
5032 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
5034 * class.cs: Combine some if statements.
5036 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5038 * driver.cs: fixed bug #37187.
5040 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
5042 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
5043 any indexer, it's needed to build a list with all the indexers in the
5044 hierarchy (AllGetters), else we have problems. Fixes #35653.
5046 2003-01-23 Miguel de Icaza <miguel@ximian.com>
5048 * class.cs (MethodData.Define): It is wrong for an interface
5049 implementation to be static in both cases: explicit and implicit.
5050 We were only handling this in one case.
5052 Improve the if situation there to not have negations.
5054 * class.cs (Field.Define): Turns out that we do not need to check
5055 the unsafe bit on field definition, only on usage. Remove the test.
5057 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5059 * driver.cs: use assembly.Location instead of Codebase (the latest
5060 patch made mcs fail when using MS assemblies).
5062 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
5064 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
5065 get the path to *corlib.dll.
5067 2003-01-21 Nick Drochak <ndrochak@gol.com>
5071 * typemanager.cs: Remove compiler warnings
5073 2003-01-20 Duncan Mak <duncan@ximian.com>
5075 * AssemblyInfo.cs: Bump the version number to 0.19.
5077 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5079 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
5081 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
5083 * class.cs (Constructor::Emit): Emit debugging info for constructors.
5085 2003-01-17 Miguel de Icaza <miguel@ximian.com>
5087 * cs-parser.jay: Small fix: we were not comparing the constructor
5088 name correctly. Thanks to Zoltan for the initial pointer.
5090 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
5092 * cs-tokenizer.cs: Set file name when specified with #line
5094 2003-01-15 Miguel de Icaza <miguel@ximian.com>
5096 * cs-parser.jay: Only perform the constructor checks here if we
5097 are named like the class; This will help provider a better
5098 error. The constructor path is taken when a type definition is
5099 not found, but most likely the user forgot to add the type, so
5100 report that rather than the constructor error.
5102 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
5104 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
5107 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
5109 * cs-parser.jay: Add cleanup call.
5111 2003-01-13 Duncan Mak <duncan@ximian.com>
5113 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
5114 consistent with other methods.
5116 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
5118 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
5120 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
5122 * attribute.cs: only set GuidAttr to true when we have a
5125 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5129 * typemanager.cs: fixes to allow mcs compile corlib with the new
5130 Type.IsSubclassOf fix.
5132 2003-01-08 Miguel de Icaza <miguel@ximian.com>
5134 * expression.cs (LocalVariableReference.DoResolve): Classify a
5135 constant as a value, not as a variable. Also, set the type for
5138 * cs-parser.jay (fixed_statement): take a type instead of a
5139 pointer_type, so we can produce a better error message later.
5141 * statement.cs (Fixed.Resolve): Flag types that are not pointers
5144 (For.DoEmit): Make inifinite loops have a
5145 non-conditional branch back.
5147 (Fixed.DoEmit): First populate the pinned variables, then emit the
5148 statement, then clear the variables. Before I was emitting the
5149 code once for each fixed piece.
5152 2003-01-08 Martin Baulig <martin@ximian.com>
5154 * statement.cs (FlowBranching.MergeChild): A break in a
5155 SWITCH_SECTION does not leave a loop. Fixes #36155.
5157 2003-01-08 Martin Baulig <martin@ximian.com>
5159 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
5160 lives in the same number space than `param_map'. Fixes #36154.
5162 2003-01-07 Miguel de Icaza <miguel@ximian.com>
5164 * cs-parser.jay (constructor_declaration): Set the
5165 Constructor.ModFlags before probing for it. This makes the
5166 compiler report 514, 515 and 132 (the code was there, but got
5169 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
5170 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
5171 (GotoCase.Resolve): Set `Returns' to ALWAYS.
5173 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
5175 * enum.cs: create the enum static fields using the enum type.
5177 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
5179 * class.cs: don't try to create the ParamBuilder for the return
5180 type if it's not needed (and handle it breaking for the ms runtime
5183 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
5185 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
5187 2002-12-29 Miguel de Icaza <miguel@ximian.com>
5189 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
5190 the command. This showed up while compiling the JANET source
5191 code, which used \r as its only newline separator.
5193 2002-12-28 Miguel de Icaza <miguel@ximian.com>
5195 * class.cs (Method.Define): If we are an operator (because it
5196 reuses our code), then set the SpecialName and HideBySig. #36128
5198 2002-12-22 Miguel de Icaza <miguel@ximian.com>
5200 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
5201 exception, report error 120 `object reference required'.
5203 * driver.cs: Add --pause option, used during to measure the size
5204 of the process as it goes with --timestamp.
5206 * expression.cs (Invocation.DoResolve): Do not allow methods with
5207 SpecialName to be invoked.
5209 2002-12-21 Miguel de Icaza <miguel@ximian.com>
5211 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
5212 number before adding it.
5214 2002-12-21 Ravi Pratap <ravi@ximian.com>
5216 * ecore.cs (StandardImplicitConversion): When in an unsafe
5217 context, we allow conversion between void * to any other pointer
5218 type. This fixes bug #35973.
5220 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
5222 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
5223 is not thrown when extensionless outputs are used
5225 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5227 * rootcontext.cs: fixed compilation of corlib.
5229 2002-12-19 Miguel de Icaza <miguel@ximian.com>
5231 * attribute.cs (Attributes.Contains): Add new method.
5233 * class.cs (MethodCore.LabelParameters): if the parameter is an
5234 `out' parameter, check that no attribute `[In]' has been passed.
5236 * enum.cs: Handle the `value__' name in an enumeration.
5238 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
5240 * decl.cs: Added special case to allow overrides on "protected
5243 2002-12-18 Ravi Pratap <ravi@ximian.com>
5245 * attribute.cs (Attributes.AddAttributeSection): Rename to this
5246 since it makes much more sense.
5248 (Attributes.ctor): Don't require a Location parameter.
5250 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
5252 * attribute.cs (ApplyAttributes): Remove extra Location parameters
5253 since we already have that information per attribute.
5255 * everywhere : make appropriate changes.
5257 * class.cs (LabelParameters): Write the code which actually
5258 applies attributes to the return type. We can't do this on the MS
5259 .NET runtime so we flag a warning in the case an exception is
5262 2002-12-18 Miguel de Icaza <miguel@ximian.com>
5264 * const.cs: Handle implicit null conversions here too.
5266 2002-12-17 Ravi Pratap <ravi@ximian.com>
5268 * class.cs (MethodCore.LabelParameters): Remove the extra
5269 Type [] parameter since it is completely unnecessary. Instead
5270 pass in the method's attributes so that we can extract
5271 the "return" attribute.
5273 2002-12-17 Miguel de Icaza <miguel@ximian.com>
5275 * cs-parser.jay (parse): Use Report.Error to flag errors instead
5276 of ignoring it and letting the compile continue.
5278 * typemanager.cs (ChangeType): use an extra argument to return an
5279 error condition instead of throwing an exception.
5281 2002-12-15 Miguel de Icaza <miguel@ximian.com>
5283 * expression.cs (Unary.TryReduce): mimic the code for the regular
5284 code path. Perform an implicit cast in the cases where we can
5285 implicitly convert to one of the integral types, and then reduce
5286 based on that constant. This fixes bug #35483.
5288 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5290 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
5292 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5294 * namespace.cs: fixed bug #35489.
5296 2002-12-12 Miguel de Icaza <miguel@ximian.com>
5298 * class.cs: Remove some dead code.
5300 * cs-parser.jay: Estimate the number of methods needed
5301 (RootContext.MethodCount);
5303 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
5304 numbers instead of StringBuilders.
5306 * support.cs (PtrHashtable): Add constructor with initial size;
5307 We can now reduce reallocations of the method table.
5309 2002-12-10 Ravi Pratap <ravi@ximian.com>
5311 * attribute.cs (ApplyAttributes): Keep track of the emitted
5312 attributes on a per-target basis. This fixes bug #35413.
5314 2002-12-10 Miguel de Icaza <miguel@ximian.com>
5316 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
5317 default to the Windows 1252 encoding.
5319 (UnixParseOption): Support version, thanks to Alp for the missing
5322 * AssemblyInfo.cs: Add nice assembly information.
5324 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
5327 * cs-parser.jay: Allow a trailing comma before the close bracked
5328 in the attribute_section production.
5330 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
5331 address of the instance was being taken, I will take this out,
5332 because we take the address of the object immediately here.
5334 2002-12-09 Ravi Pratap <ravi@ximian.com>
5336 * typemanager.cs (AreMultipleAllowed): Take care of the most
5337 obvious case where attribute type is not in the current assembly -
5340 2002-12-08 Miguel de Icaza <miguel@ximian.com>
5342 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
5343 definitions, instead of doing that afterwards.
5345 Also we use a nice little hack, depending on the constructor, we
5346 know if we are a "composed" name or a simple name. Hence, we
5347 avoid the IndexOf test, and we avoid
5349 * codegen.cs: Add code to assist in a bug reporter to track down
5350 the source of a compiler crash.
5352 2002-12-07 Ravi Pratap <ravi@ximian.com>
5354 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
5355 types have been emitted for a given element and flag an error
5356 if something which does not have AllowMultiple set is used more
5359 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
5360 attribute types and their corresponding AllowMultiple properties
5362 (AreMultipleAllowed): Check the property for a given type.
5364 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
5365 property in the case we have a TypeContainer.
5367 (Attributes.AddAttribute): Detect duplicates and just skip on
5368 adding them. This trivial fix catches a pretty gross error in our
5369 attribute emission - global attributes were being emitted twice!
5371 Bugzilla bug #33187 is now fixed.
5373 2002-12-06 Miguel de Icaza <miguel@ximian.com>
5375 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
5378 * expression.cs (Binary.ResolveOperator): I can only use the
5379 Concat (string, string, string) and Concat (string, string,
5380 string, string) if the child is actually a concatenation of
5383 2002-12-04 Miguel de Icaza <miguel@ximian.com>
5385 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
5386 context where we need a 2-character lookahead.
5388 * pending.cs (PendingImplementation): Rework so we can keep track
5389 of interface types all the time, and flag those which were
5390 implemented by parents as optional.
5392 2002-12-03 Miguel de Icaza <miguel@ximian.com>
5394 * expression.cs (Binary.ResolveOperator): Use
5395 String.Concat(string,string,string) or
5396 String.Concat(string,string,string,string) when possible.
5398 * typemanager: More helper methods.
5401 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
5403 * pending.cs: remove the bogus return from GetMissingInterfaces()
5404 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
5406 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5408 * namespace.cs: avoid duplicated 'using xxx' being added to
5409 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
5410 when we get more than one 'using' statement for the same namespace.
5411 Report a CS0105 warning for it.
5413 2002-11-30 Miguel de Icaza <miguel@ximian.com>
5415 * cs-tokenizer.cs (consume_identifier): use read directly, instead
5416 of calling getChar/putback, uses internal knowledge of it.
5418 (xtoken): Reorder tokenizer so most common patterns are checked
5419 first. This reduces the compilation time in another 5% (from 8.11s
5420 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
5422 The parsing time is 22% of the compilation in mcs, and from that
5423 64% is spent on the tokenization process.
5425 I tried using a binary search for keywords, but this is slower
5426 than the hashtable. Another option would be to do a couple of
5429 * Not use a StringBuilder, instead use an array of chars,
5430 with a set value. Notice that this way we could catch
5431 the 645 error without having to do it *afterwards*.
5433 * We could write a hand-parser to avoid the hashtable
5434 compares altogether.
5436 The identifier consumption process takes 37% of the tokenization
5437 time. Another 15% is spent on is_number. 56% of the time spent
5438 on is_number is spent on Int64.Parse:
5440 * We could probably choose based on the string length to
5441 use Int32.Parse or Int64.Parse and avoid all the 64-bit
5444 Another 3% is spend on wrapping `xtoken' in the `token' function.
5446 Handle 0xa0 as whitespace (#34752)
5448 2002-11-26 Miguel de Icaza <miguel@ximian.com>
5450 * typemanager.cs (IsCLRType): New routine to tell whether a type
5451 is one of the builtin types.
5453 Maybe it needs to use TypeCodes to be faster. Maybe we could use
5454 typecode in more places instead of doing pointer comparissions.
5455 We could leverage some knowledge about the way the typecodes are
5458 New code to cache namespaces in assemblies, it is currently not
5459 invoked, to be used soon.
5461 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
5463 * expression.cs (Binary.ResolveOperator): specially handle
5464 strings, and do not perform user-defined operator overloading for
5467 2002-11-24 Miguel de Icaza <miguel@ximian.com>
5469 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
5470 internalcall as it is a pretty simple operation; Avoid whenever
5471 possible to call Char.IsLetter.
5473 (consume_identifier): Cut by half the number of
5474 hashtable calls by merging the is_keyword and GetKeyword behavior.
5476 Do not short-circuit, because if we do, we
5477 report errors (ie, #if false && true would produce an invalid
5481 2002-11-24 Martin Baulig <martin@ximian.com>
5483 * expression.cs (Cast.TryReduce): If we're in checked syntax,
5484 check constant ranges and report a CS0221. Fixes #33186.
5486 2002-11-24 Martin Baulig <martin@ximian.com>
5488 * cs-parser.jay: Make this work for uninitialized variable
5489 declarations in the `for' initializer. Fixes #32416.
5491 2002-11-24 Martin Baulig <martin@ximian.com>
5493 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
5494 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
5496 2002-11-24 Martin Baulig <martin@ximian.com>
5498 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
5499 argument; if true, we also check for user-defined conversions.
5500 This is only needed if both arguments are of a user-defined type.
5501 Fixes #30443, added test-175.cs.
5502 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
5504 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
5506 2002-11-24 Martin Baulig <martin@ximian.com>
5508 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
5509 function to get the store opcode.
5510 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
5511 only emit the Ldelema if the store opcode is Stobj. You must run
5512 both test-34 and test-167 to test this. Fixes #34529.
5514 2002-11-23 Martin Baulig <martin@ximian.com>
5516 * ecore.cs (Expression.MemberLookup): Added additional
5517 `qualifier_type' argument which is used when we're being called
5518 from MemberAccess.DoResolve() and null if we're called from a
5520 (Expression.MemberLookupFailed): New method to report errors; this
5521 does the CS1540 check and reports the correct error message.
5523 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
5524 argument for the CS1540 check and redone the way how we're dealing
5525 with private members. See the comment in the source code for details.
5526 (FilterWithClosure): Reverted this back to revision 1.197; renamed
5527 `closure_start_type' to `closure_qualifier_type' and check whether
5528 it's not null. It was not this filter being broken, it was just
5529 being called with the wrong arguments.
5531 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
5532 and pass it the correct `qualifier_type'; this also does the error
5535 2002-11-22 Miguel de Icaza <miguel@ximian.com>
5537 * expression.cs (Invocation.EmitParams): If the we are dealing
5538 with a non-built-in value type, load its address as well.
5540 (ArrayCreation): Use a a pretty constant instead
5541 of the hardcoded value 2. Use 6 instead of 2 for the number of
5542 static initializers.
5544 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
5545 because they are not really value types, just glorified integers.
5547 * driver.cs: Do not append .exe, the CSC compiler does not do it.
5549 * ecore.cs: Remove redundant code for enumerations, make them use
5550 the same code path as everything else, fixes the casting issue
5551 with enumerations in Windows.Forms.
5553 * attribute.cs: Do only cast to string if it is a string, the
5554 validation happens later.
5556 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
5557 people upgrade their corlibs.
5559 * ecore.cs: Oops, enumerations were not following the entire code path
5561 2002-11-21 Miguel de Icaza <miguel@ximian.com>
5563 * typemanager.cs (FilterWithClosure): Commented out the test for
5564 1540 in typemanager.cs, as it has problems when accessing
5565 protected methods from a parent class (see test-174.cs).
5567 * attribute.cs (Attribute.ValidateGuid): new method.
5568 (Attribute.Resolve): Use above.
5570 2002-11-19 Miguel de Icaza <miguel@ximian.com>
5572 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
5574 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
5575 handling for enumerations, as we only needed the TypeContainer
5576 functionality to begin with (this is required for the fix below to
5577 work for enums that reference constants in a container class for
5580 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
5582 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
5583 a valid TypeBuilder to perform lookups on.o
5585 * class.cs (InheritableMemberSignatureCompare): Use true in the
5586 call to GetGetMethod and GetSetMethod, because we are comparing
5587 the signature, and we need to get the methods *even* if they are
5590 (PropertyBase.CheckBase): ditto.
5592 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
5593 GotoCase.Resolve): Use Peel on EmpytCasts.
5595 * ecore.cs (EmptyCast): drop child, add Peel method.
5597 2002-11-17 Martin Baulig <martin@ximian.com>
5599 * ecore.cs (EmptyCast.Child): New public property.
5601 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
5602 label resolved to an EmptyCast. Fixes #34162.
5603 (GotoCase.Resolve): Likewise.
5604 (Block.EmitMeta): Likewise.
5606 2002-11-17 Martin Baulig <martin@ximian.com>
5608 * expression.cs (Invocation.BetterConversion): Prefer int over
5609 uint; short over ushort; long over ulong for integer literals.
5610 Use ImplicitConversionExists instead of StandardConversionExists
5611 since we also need to check for user-defined implicit conversions.
5612 Fixes #34165. Added test-173.cs.
5614 2002-11-16 Martin Baulig <martin@ximian.com>
5616 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
5617 with the `true' and `false' literals. Fixes #33151.
5619 2002-11-16 Martin Baulig <martin@ximian.com>
5621 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
5622 October 22nd; don't do the cs1540 check for static members.
5624 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
5625 now using our own filter here and doing the cs1540 check again.
5627 2002-11-16 Martin Baulig <martin@ximian.com>
5629 * support.cs (InternalParameters): Don't crash if we don't have
5630 any fixed parameters. Fixes #33532.
5632 2002-11-16 Martin Baulig <martin@ximian.com>
5634 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
5635 when looking up static methods to make this work on Windows.
5638 2002-11-16 Martin Baulig <martin@ximian.com>
5640 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
5641 a setter rather than using PropertyInfo.CanWrite.
5643 2002-11-15 Nick Drochak <ndrochak@gol.com>
5645 * class.cs: Allow acces to block member by subclasses. Fixes build
5648 2002-11-14 Martin Baulig <martin@ximian.com>
5650 * class.cs (Constructor.Emit): Added the extern/block check.
5653 2002-11-14 Martin Baulig <martin@ximian.com>
5655 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
5656 iteration while looking for indexers, this is needed because the
5657 indexer may have a different name in our base classes. Fixed the
5658 error reporting (no indexers at all, not get accessor, no
5659 overloaded match). Fixes bug #33089.
5660 (IndexerAccess.DoResolveLValue): Likewise.
5662 2002-11-14 Martin Baulig <martin@ximian.com>
5664 * class.cs (PropertyBase.CheckBase): Make this work for multiple
5665 indexers. Fixes the first part of bug #33089.
5666 (MethodSignature.InheritableMemberSignatureCompare): Added support
5669 2002-11-13 Ravi Pratap <ravi@ximian.com>
5671 * attribute.cs (Attribute.Resolve): Catch the
5672 NullReferenceException and report it since it isn't supposed to
5675 2002-11-12 Miguel de Icaza <miguel@ximian.com>
5677 * expression.cs (Binary.EmitBranchable): Also handle the cases for
5678 LogicalOr and LogicalAnd that can benefit from recursively
5679 handling EmitBranchable. The code now should be nice for Paolo.
5681 2002-11-08 Miguel de Icaza <miguel@ximian.com>
5683 * typemanager.cs (LookupType): Added a negative-hit hashtable for
5684 the Type lookups, as we perform quite a number of lookups on
5685 non-Types. This can be removed once we can deterministically tell
5686 whether we have a type or a namespace in advance.
5688 But this might require special hacks from our corlib.
5692 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
5693 and double which avoids a conversion from an integer to a double.
5695 * expression.cs: tiny optimization, avoid calling IsConstant,
5696 because it effectively performs the lookup twice.
5698 2002-11-06 Miguel de Icaza <miguel@ximian.com>
5700 But a bogus return here to keep the semantics of the old code
5701 until the Mono runtime is fixed.
5703 * pending.cs (GetMissingInterfaces): New method used to remove all
5704 the interfaces that are already implemented by our parent
5705 classes from the list of pending methods.
5707 * interface.cs: Add checks for calls after ResolveTypeExpr.
5709 2002-11-05 Miguel de Icaza <miguel@ximian.com>
5711 * class.cs (Class.Emit): Report warning 67: event not used if the
5712 warning level is beyond 3.
5714 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
5715 being a NullLiteral.
5717 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
5720 * class.cs (TypeContainer.GetClassBases): Cover a missing code
5721 path that might fail if a type can not be resolved.
5723 * expression.cs (Binary.Emit): Emit unsigned versions of the
5726 * driver.cs: use error 5.
5728 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
5730 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
5732 2002-11-01 Miguel de Icaza <miguel@ximian.com>
5734 * cs-parser.jay (switch_section): A beautiful patch from Martin
5735 Baulig that fixed 33094.
5737 2002-10-31 Miguel de Icaza <miguel@ximian.com>
5739 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
5740 Check whether the base is abstract and report an error if so.
5742 * expression.cs (IndexerAccess.DoResolveLValue,
5743 IndexerAccess.DoResolve): ditto.
5745 (Invocation.DoResolve): ditto.
5747 (Invocation.FullMethodDesc): Improve the report string.
5749 * statement.cs (Block): Eliminate IsVariableDefined as it is
5750 basically just a wrapper for GetVariableInfo.
5752 * ecore.cs (SimpleName): Use new
5754 * support.cs (ReflectionParamter.ParameterType): We unwrap the
5755 type, as we return the actual parameter ref/unref state on a
5758 2002-10-30 Miguel de Icaza <miguel@ximian.com>
5760 * support.cs: Return proper flags REF/OUT fixing the previous
5763 * expression.cs: Reverted last patch, that was wrong. Is_ref is
5764 not used to mean `ref' but `ref or out' in ParameterReference
5766 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
5767 full type signature instead of calling TypeManger.CSharpName
5770 * support.cs (InternalParameters.ParameterDesc): Do not compare
5771 directly to the modflags, because REF/OUT will actually be bitsets
5774 * delegate.cs (VerifyMethod): Check also the modifiers.
5776 * cs-tokenizer.cs: Fix bug where floating point values with an
5777 exponent where a sign was missing was ignored.
5779 * driver.cs: Allow multiple assemblies to be specified in a single
5782 2002-10-28 Miguel de Icaza <miguel@ximian.com>
5784 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
5785 because identifiers after a parenthesis would end up in this kind
5786 of production, and we needed to desamiguate it for having casts
5789 (UserDefinedType *) xxx
5791 2002-10-24 Miguel de Icaza <miguel@ximian.com>
5793 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
5794 we should set on the Bindingflags.NonPublic, but not turn on
5795 private_ok. private_ok controls whether a Private member is
5796 returned (this is chekced on the filter routine), while the
5797 BindingFlags.NonPublic just controls whether private/protected
5798 will be allowed. This fixes the problem part of the problem of
5799 private properties being allowed to be used in derived classes.
5801 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
5802 so we can call the children DoResolveLValue method (this will
5803 properly signal errors on lvalue assignments to base properties)
5805 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
5806 getter are null, and we have a property info, we know that this
5807 happened because the lookup failed, so we report an error 122 for
5808 protection level violation.
5810 We also silently return if setter and getter are null in the
5811 resolve functions, this condition only happens if we have flagged
5812 the error before. This is the other half of the problem.
5814 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
5815 not have accessibility information, that is why we were returning
5816 true in the filter function in typemanager.cs.
5818 To properly report 122 (property is inaccessible because of its
5819 protection level) correctly, we report this error in ResolveAccess
5820 by failing if both the setter and the getter are lacking (ie, the
5823 DoResolve and DoLResolve have been modified to check for both
5824 setter/getter being null and returning silently, the reason being
5825 that I did not want to put the knowledge about this error in upper
5828 int old = Report.Errors;
5829 x = new PropertyExpr (...);
5830 if (old != Report.Errors)
5835 So the property expr is returned, but it is invalid, so the error
5836 will be flagged during the resolve process.
5838 * class.cs: Remove InheritablePropertySignatureCompare from the
5839 class, as we no longer depend on the property signature to compute
5840 whether it is possible to implement a method or not.
5842 The reason is that calling PropertyInfo.GetGetMethod will return
5843 null (in .NET, in Mono it works, and we should change this), in
5844 cases where the Get Method does not exist in that particular
5849 class X { public virtual int A { get { return 1; } } }
5851 class Z : Y { public override int A { get { return 2; } } }
5853 Would fail in Z because the parent (Y) would not have the property
5854 defined. So we avoid this completely now (because the alternative
5855 fix was ugly and slow), and we now depend exclusively on the
5858 (PropertyBase.CheckBase): Use a method-base mechanism to find our
5859 reference method, instead of using the property.
5861 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
5862 routines are gone now.
5864 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
5865 names, they were incorrectly named.
5867 * cs-tokenizer.cs: Return are more gentle token on failure.
5869 * pending.cs (PendingImplementation.InterfaceMethod): This routine
5870 had an out-of-sync index variable, which caused it to remove from
5871 the list of pending methods the wrong method sometimes.
5873 2002-10-22 Miguel de Icaza <miguel@ximian.com>
5875 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
5876 CanWrite, because those refer to this particular instance of the
5877 property, and do not take into account the fact that we can
5878 override single members of a property.
5880 Constructor requires an EmitContext. The resolution process does
5881 not happen here, but we need to compute the accessors before,
5882 because the resolution does not always happen for properties.
5884 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
5885 subclass, before we did not update this flag, but we did update
5888 (GetAccessors): Drop this routine, as it did not work in the
5889 presence of partially overwritten set/get methods.
5891 Notice that this broke the cs1540 detection, but that will require
5894 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5898 * driver.cs: issue a warning instead of an error if we don't support
5899 debugging for the platform. Also ignore a couple of errors that may
5900 arise when trying to write the symbols. Undo my previous patch.
5902 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5904 * driver.cs: ignore /debug switch except for Unix platforms.
5906 2002-10-23 Nick Drochak <ndrochak@gol.com>
5908 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
5910 2002-10-21 Miguel de Icaza <miguel@ximian.com>
5912 * driver.cs: Do not make mcs-debug conditional, so we do not break
5915 * statement.cs (UsageVector.MergeChildren): I would like Martin to
5916 review this patch. But basically after all the children variables
5917 have been merged, the value of "Breaks" was not being set to
5918 new_breaks for Switch blocks. I think that it should be set after
5919 it has executed. Currently I set this to the value of new_breaks,
5920 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
5921 conservative, but I do not understand this code very well.
5923 I did not break anything in the build, so that is good ;-)
5925 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
5927 2002-10-20 Mark Crichton <crichton@gimp.org>
5929 * cfold.cs: Fixed compile blocker. Really fixed it this time.
5931 2002-10-20 Nick Drochak <ndrochak@gol.com>
5933 * cfold.cs: Fixed compile blocker.
5935 2002-10-20 Miguel de Icaza <miguel@ximian.com>
5937 * driver.cs: I was chekcing the key, not the file.
5939 2002-10-19 Ravi Pratap <ravi@ximian.com>
5941 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
5942 message that we were generating - we just need to silently return
5945 2002-10-19 Miguel de Icaza <miguel@ximian.com>
5947 * class.cs (Event.Define): Change my previous commit, as this
5948 breaks the debugger. This is a temporary hack, as it seems like
5949 the compiler is generating events incorrectly to begin with.
5951 * expression.cs (Binary.ResolveOperator): Added support for
5952 "U operator - (E x, E y)"
5954 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
5957 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
5958 init-only variables, but this path did not take into account that
5959 there might be also instance readonly variables. Correct this
5962 This fixes bug 32253
5964 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
5967 * driver.cs: Change the extension for modules to `netmodule'
5969 * cs-parser.jay: Improved slightly the location tracking for
5970 the debugger symbols.
5972 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
5973 modifiers that were specified instead of the hardcoded value
5974 (FamAndAssem). This was basically ignoring the static modifier,
5975 and others. Fixes 32429.
5977 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
5978 fixed a bug in the process (32476)
5980 * expression.cs (ArrayAccess.EmitAssign): Patch from
5981 hwang_rob@yahoo.ca that fixes bug 31834.3
5983 2002-10-18 Miguel de Icaza <miguel@ximian.com>
5985 * driver.cs: Make the module extension .netmodule.
5987 2002-10-16 Miguel de Icaza <miguel@ximian.com>
5989 * driver.cs: Report an error if the resource file is not found
5990 instead of crashing.
5992 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
5993 false, like Emit does.
5995 2002-10-16 Nick Drochak <ndrochak@gol.com>
5997 * typemanager.cs: Remove unused private member. Also reported mcs
5998 bug to report this as a warning like csc.
6000 2002-10-15 Martin Baulig <martin@gnome.org>
6002 * statement.cs (Statement.Emit): Made this a virtual method; emits
6003 the line number info and calls DoEmit().
6004 (Statement.DoEmit): New protected abstract method, formerly knows
6005 as Statement.Emit().
6007 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
6009 2002-10-11 Miguel de Icaza <miguel@ximian.com>
6011 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
6012 have fixed a remaining problem: not every AddXXXX was adding a
6013 fully qualified name.
6015 Now everyone registers a fully qualified name in the DeclSpace as
6016 being defined instead of the partial name.
6018 Downsides: we are slower than we need to be due to the excess
6019 copies and the names being registered this way.
6021 The reason for this is that we currently depend (on the corlib
6022 bootstrap for instance) that types are fully qualified, because
6023 we dump all the types in the namespace, and we should really have
6024 types inserted into the proper namespace, so we can only store the
6025 basenames in the defined_names array.
6027 2002-10-10 Martin Baulig <martin@gnome.org>
6029 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
6030 from bug #31834, see the bug report for a testcase which is
6033 2002-10-10 Martin Baulig <martin@gnome.org>
6035 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
6036 flow analysis code for this.
6038 * statement.cs (Do, While, For): Tell the flow analysis code about
6040 (FlowBranching.UsageVector): Added support for infinite loops.
6041 (Block.Resolve): Moved the dead code elimination here and use flow
6044 2002-10-09 Miguel de Icaza <miguel@ximian.com>
6046 * class.cs (Field.Define): Catch cycles on struct type
6049 * typemanager.cs (IsUnmanagedtype): Do not recursively check
6050 fields if the fields are static. We only need to check instance
6053 * expression.cs (As.DoResolve): Test for reference type.
6055 * statement.cs (Using.ResolveExpression): Use
6056 ConvertImplicitRequired, not ConvertImplicit which reports an
6058 (Using.ResolveLocalVariableDecls): ditto.
6060 * expression.cs (Binary.ResolveOperator): Report errors in a few
6061 places where we had to.
6063 * typemanager.cs (IsUnmanagedtype): Finish implementation.
6065 2002-10-08 Miguel de Icaza <miguel@ximian.com>
6067 * expression.cs: Use StoreFromPtr instead of extracting the type
6068 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
6070 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
6071 an enumeration value to a System.Enum, but System.Enum is not a
6072 value type, but an class type, so we need to box.
6074 (Expression.ConvertExplicit): One codepath could return
6075 errors but not flag them. Fix this. Fixes #31853
6077 * parameter.cs (Resolve): Do not allow void as a parameter type.
6079 2002-10-06 Martin Baulig <martin@gnome.org>
6081 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
6082 if it's a class type and not a struct. Fixes #31815.
6084 2002-10-06 Martin Baulig <martin@gnome.org>
6086 * statement.cs: Reworked the flow analysis code a bit to make it
6087 usable for dead code elimination.
6089 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6091 * cs-parser.jay: allow empty source files. Fixes bug #31781.
6093 2002-10-04 Miguel de Icaza <miguel@ximian.com>
6095 * expression.cs (ComposedCast.DoResolveType): A quick workaround
6096 to fix the test 165, will investigate deeper.
6098 2002-10-04 Martin Baulig <martin@gnome.org>
6100 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
6101 finally blocks actually work.
6102 (Try.Resolve): We don't need to create a sibling for `finally' if
6103 there is no finally block.
6105 2002-10-04 Martin Baulig <martin@gnome.org>
6107 * class.cs (Constructor.Define): The default accessibility for a
6108 non-default constructor is private, not public.
6110 2002-10-04 Miguel de Icaza <miguel@ximian.com>
6112 * class.cs (Constructor): Make AllowedModifiers public, add
6115 * cs-parser.jay: Perform the modifiers test here, as the
6116 constructor for the Constructor class usually receives a zero
6117 because of the way we create it (first we create, later we
6118 customize, and we were never checking the modifiers).
6120 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
6121 is a version of LookupTypeReflection that includes the type-name
6122 cache. This can be used as a fast path for functions that know
6123 the fully qualified name and are only calling into *.GetType() to
6124 obtain a composed type.
6126 This is also used by TypeManager.LookupType during its type
6129 (LookupType): We now also track the real type name, as sometimes
6130 we can get a quey for the real type name from things like
6131 ComposedCast. This fixes bug 31422.
6133 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
6134 complete type fullname, it does not have to go through the type
6135 resolution system to obtain the composed version of the type (for
6136 obtaining arrays or pointers).
6138 (Conditional.Emit): Use the EmitBoolExpression to
6139 generate nicer code, as requested by Paolo.
6141 (ArrayCreation.CheckIndices): Use the patch from
6142 hwang_rob@yahoo.ca to validate the array initializers.
6144 2002-10-03 Miguel de Icaza <miguel@ximian.com>
6146 * class.cs (ConstructorInitializer.Emit): simplify code by using
6147 Invocation.EmitCall, and at the same time, fix the bugs in calling
6148 parent constructors that took variable arguments.
6150 * ecore.cs (Expression.ConvertNumericExplicit,
6151 Expression.ImplicitNumericConversion): Remove the code that
6152 manually wrapped decimal (InternalTypeConstructor call is now gone
6155 * expression.cs (Cast.TryReduce): Also handle decimal types when
6156 trying to perform a constant fold on the type.
6158 * typemanager.cs (IsUnmanagedtype): Partially implemented.
6160 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
6161 that only turned off an error report, and did nothing else.
6163 2002-10-02 Miguel de Icaza <miguel@ximian.com>
6165 * driver.cs: Handle and ignore /fullpaths
6167 2002-10-01 Miguel de Icaza <miguel@ximian.com>
6169 * expression.cs (Binary.ResolveOperator): Catch the case where
6170 DoNumericPromotions returns true,
6172 (Binary.DoNumericPromotions): Simplify the code, and the tests.
6174 2002-09-27 Miguel de Icaza <miguel@ximian.com>
6176 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
6179 2002-09-26 Miguel de Icaza <miguel@ximian.com>
6181 * ecore.cs (ConvertNumericExplicit): It is not enough that the
6182 conversion exists, but it is also required that the conversion be
6183 performed. This manifested in "(Type64Enum) 2".
6185 * class.cs (TypeManager.AddMethod): The fix is not to change
6186 AddEnum, because that one was using a fully qualified name (every
6187 DeclSpace derivative does), but to change the AddMethod routine
6188 that was using an un-namespaced name. This now correctly reports
6189 the duplicated name.
6191 Revert patch until I can properly fix it. The issue
6192 is that we have a shared Type space across all namespaces
6193 currently, which is wrong.
6195 Options include making the Namespace a DeclSpace, and merge
6196 current_namespace/current_container in the parser.
6198 2002-09-25 Miguel de Icaza <miguel@ximian.com>
6200 * cs-parser.jay: Improve error reporting when we get a different
6201 kind of expression in local_variable_type and
6202 local_variable_pointer_type.
6204 Propagate this to avoid missleading errors being reported.
6206 * ecore.cs (ImplicitReferenceConversion): treat
6207 TypeManager.value_type as a target just like object_type. As
6212 Is valid, and needs to result in the int 1 being boxed before it
6213 is assigned to the value type v.
6215 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
6216 to validate the enumeration name.
6218 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
6219 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
6220 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
6222 * ecore.cs (TryImplicitIntConversion): When doing an
6223 implicit-enumeration-conversion, check if the type is 64-bits and
6224 perform a conversion before passing to EnumConstant.
6226 2002-09-23 Miguel de Icaza <miguel@ximian.com>
6228 * decl.cs (Error_AmbiguousTypeReference); New routine used to
6229 report ambiguous type references. Unlike the MS version, we
6230 report what the ambiguity is. Innovation at work ;-)
6232 (DeclSpace.FindType): Require a location argument to
6233 display when we display an ambiguous error.
6235 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
6237 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
6239 * expression.cs (EmitDynamicInitializers): Apply patch from
6240 hwang_rob@yahoo.ca that fixes the order in which we emit our
6243 2002-09-21 Martin Baulig <martin@gnome.org>
6245 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
6246 delegate takes no arguments.
6248 2002-09-20 Miguel de Icaza <miguel@ximian.com>
6250 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
6253 * expression.cs: Extract the underlying type.
6255 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
6257 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
6259 2002-09-19 Miguel de Icaza <miguel@ximian.com>
6261 * class.cs (TypeContainer.DefineType): We can not use the nice
6262 PackingSize with the size set to 1 DefineType method, because it
6263 will not allow us to define the interfaces that the struct
6266 This completes the fixing of bug 27287
6268 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
6269 means also structs. This fixes part of the problem.
6270 (Expresion.ImplicitReferenceConversionExists): ditto.
6272 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
6273 error if there were no errors reported during the type lookup
6274 process, to avoid duplicates or redundant errors. Without this
6275 you would get an ambiguous errors plus a type not found. We have
6276 beaten the user enough with the first error.
6278 (DeclSparce.FindType): Emit a warning if we have an ambiguous
6281 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
6282 during the resolution process, stop the lookup, this avoids
6283 repeated error reports (same error twice).
6285 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
6287 * typemanager.cs (LookupType): Redo the type lookup code to match
6288 the needs of System.Reflection.
6290 The issue is that System.Reflection requires references to nested
6291 types to begin with a "+" sign instead of a dot. So toplevel
6292 types look like: "NameSpace.TopLevelClass", and nested ones look
6293 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
6296 2002-09-19 Martin Baulig <martin@gnome.org>
6298 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
6299 says that a method always returns or always throws an exception,
6300 don't report the CS0161.
6302 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
6303 set `Returns = new_returns'.
6305 2002-09-19 Martin Baulig <martin@gnome.org>
6307 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
6308 to an enum constant, check for a CS0176.
6310 2002-09-18 Miguel de Icaza <miguel@ximian.com>
6312 * class.cs (TypeContainer.CheckPairedOperators): Now we check
6313 for operators that must be in pairs and report errors.
6315 * ecore.cs (SimpleName.DoResolveType): During the initial type
6316 resolution process, when we define types recursively, we must
6317 check first for types in our current scope before we perform
6318 lookups in the enclosing scopes.
6320 * expression.cs (MakeByteBlob): Handle Decimal blobs.
6322 (Invocation.VerifyArgumentsCompat): Call
6323 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
6324 I thought we were supposed to always call this, but there are a
6325 few places in the code where we dont do it.
6327 2002-09-17 Miguel de Icaza <miguel@ximian.com>
6329 * driver.cs: Add support in -linkres and -resource to specify the
6330 name of the identifier.
6332 2002-09-16 Miguel de Icaza <miguel@ximian.com>
6334 * ecore.cs (StandardConversionExists): Sync with the conversion
6335 code: allow anything-* to void* conversions.
6337 (FindMostSpecificSource): Use an Expression argument
6338 instead of a Type, because we might be handed over a Literal which
6339 gets a few more implicit conversions that plain types do not. So
6340 this information was being lost.
6342 Also, we drop the temporary type-holder expression when not
6345 2002-09-17 Martin Baulig <martin@gnome.org>
6347 * class.cs (PropertyBase.CheckBase): Don't check the base class if
6348 this is an explicit interface implementation.
6350 2002-09-17 Martin Baulig <martin@gnome.org>
6352 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
6353 different `IndexerName' attributes.
6355 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
6356 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
6357 virtual CommonResolve().
6359 2002-09-16 Miguel de Icaza <miguel@ximian.com>
6361 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
6362 and convert that to the UnderlyingType.
6364 * statement.cs (Foreach.Resolve): Indexers are just like variables
6365 or PropertyAccesses.
6367 * cs-tokenizer.cs (consume_string): Track line numbers and columns
6368 inside quoted strings, we were not doing this before.
6370 2002-09-16 Martin Baulig <martin@gnome.org>
6372 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
6373 resolve it. This is needed for the definite assignment check of the
6374 instance expression, fixes bug #29846.
6375 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
6377 2002-09-16 Nick Drochak <ndrochak@gol.com>
6379 * parameter.cs: Fix compile error. Cannot reference static member
6380 from an instance object. Is this an mcs bug?
6382 2002-09-14 Martin Baulig <martin@gnome.org>
6384 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
6385 multiple times. Fixes bug #30295, added test-166.cs.
6387 2002-09-14 Martin Baulig <martin@gnome.org>
6389 * statement.cs (Block.Emit): Don't emit unreachable code.
6390 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
6392 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
6394 2002-09-14 Martin Baulig <martin@gnome.org>
6396 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
6399 2002-09-14 Martin Baulig <martin@gnome.org>
6401 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
6402 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
6403 be false on the ms runtime.
6405 2002-09-13 Martin Baulig <martin@gnome.org>
6407 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
6408 the CS0038 error message.
6410 2002-09-12 Miguel de Icaza <miguel@ximian.com>
6412 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
6413 constant inside, return it.
6415 2002-09-12 Martin Baulig <martin@gnome.org>
6417 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
6418 implicit conversion can be done between enum types.
6420 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
6421 check whether an implicit conversion to the current enum's UnderlyingType
6422 exists and report an error if not.
6424 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
6425 without debugging support.
6427 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
6428 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
6430 2002-09-12 Martin Baulig <martin@gnome.org>
6432 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
6434 * ecore.cs (IMemberExpr.DeclaringType): New property.
6435 (SimpleName.SimpleNameResolve): Check whether we're accessing a
6436 nonstatic member of an outer type (CS0038).
6438 2002-09-11 Miguel de Icaza <miguel@ximian.com>
6440 * driver.cs: Activate the using-error detector at warning level
6441 4 (at least for MS-compatible APIs).
6443 * namespace.cs (VerifyUsing): Small buglett fix.
6445 * pending.cs (PendingImplementation): pass the container pointer.
6447 * interface.cs (GetMethods): Allow for recursive definition. Long
6448 term, I would like to move every type to support recursive
6449 definitions, not the current ordering mechanism that we have right
6452 The situation is this: Attributes are handled before interfaces,
6453 so we can apply attributes to interfaces. But some attributes
6454 implement interfaces, we will now handle the simple cases
6455 (recursive definitions will just get an error).
6457 * parameter.cs: Only invalidate types at the end if we fail to
6460 2002-09-09 Martin Baulig <martin@gnome.org>
6462 * ecore.cs (PropertyExpr.Emit): Also check for
6463 TypeManager.system_int_array_get_length so this'll also work when
6464 compiling corlib. Fixes #30003.
6466 2002-09-09 Martin Baulig <martin@gnome.org>
6468 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
6469 and throw an exception if we can't get the type's size. Fixed #30040,
6472 2002-09-09 Martin Baulig <martin@gnome.org>
6474 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
6476 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
6477 context. Fixes bug #30027.
6479 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
6480 virtual functions. Fixes bug #30043, added test-164.cs.
6482 2002-09-08 Ravi Pratap <ravi@ximian.com>
6484 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
6486 2002-09-08 Nick Drochak <ndrochak@gol.com>
6488 * driver.cs: Use an object to get the windows codepage since it's not a
6491 2002-09-08 Miguel de Icaza <miguel@ximian.com>
6493 * statement.cs (For.Emit): for infinite loops (test == null)
6494 return whether there is a break inside, not always "true".
6496 * namespace.cs (UsingEntry): New struct to hold the name of the
6497 using definition, the location where it is defined, and whether it
6498 has been used in a successful type lookup.
6500 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
6505 2002-09-06 Ravi Pratap <ravi@ximian.com>
6507 * attribute.cs : Fix incorrect code which relied on catching
6508 a NullReferenceException to detect a null being passed in
6509 where an object was expected.
6511 2002-09-06 Miguel de Icaza <miguel@ximian.com>
6513 * statement.cs (Try): flag the catch variable as assigned
6515 * expression.cs (Cast): Simplified by using ResolveType instead of
6518 * statement.cs (Catch): Fix bug by using ResolveType.
6520 2002-09-06 Ravi Pratap <ravi@ximian.com>
6522 * expression.cs (BetterConversion): Special case for when we have
6523 a NullLiteral as the argument and we have to choose between string
6524 and object types - we choose string the way csc does.
6526 * attribute.cs (Attribute.Resolve): Catch the
6527 NullReferenceException and report error #182 since the Mono
6528 runtime no more has the bug and having this exception raised means
6529 we tried to select a constructor which takes an object and is
6532 2002-09-05 Ravi Pratap <ravi@ximian.com>
6534 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
6535 message (1502, 1503) when we can't locate a method after overload
6536 resolution. This is much more informative and closes the bug
6539 * interface.cs (PopulateMethod): Return if there are no argument
6540 types. Fixes a NullReferenceException bug.
6542 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
6543 expressions too. Previously we were checking only in one place for
6544 positional arguments leaving out named arguments.
6546 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
6547 type to the enum type is not allowed. Remove code corresponding to
6550 (ConvertNumericExplicit): Allow explicit conversions from
6551 the underlying type to enum type. This precisely follows the spec
6552 and closes a bug filed by Gonzalo.
6554 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6557 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
6559 2002-09-03 Miguel de Icaza <miguel@ximian.com>
6561 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
6562 it was important that we stored the right value after the
6563 reduction in `converted'.
6565 2002-09-04 Martin Baulig <martin@gnome.org>
6567 * location.cs (Location.SymbolDocument): Use full pathnames for the
6570 2002-08-30 Miguel de Icaza <miguel@ximian.com>
6572 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
6573 of the expression resolve mechanism, because that will catch the
6574 SimpleName error failures.
6576 (Conditional): If we can not resolve the
6577 expression, return, do not crash.
6579 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6582 (location): display token name instead of its number.
6584 2002-08-28 Martin Baulig <martin@gnome.org>
6586 * expression.cs (Binary.ResolveOperator): Don't silently return
6587 but return an error if an operator cannot be applied between two
6590 2002-08-28 Martin Baulig <martin@gnome.org>
6592 * class.cs (Constructor.Define): Set the permission attributes
6593 correctly instead of making all constructors public.
6595 2002-08-28 Martin Baulig <martin@gnome.org>
6597 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
6598 for private members before reporting a CS0103; if we find anything,
6601 2002-08-28 Martin Baulig <martin@gnome.org>
6603 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
6604 to check whether `closure_start_type == closure_invocation_type',
6605 we also need to check whether `m.DeclaringType == closure_invocation_type'
6606 before bypassing the permission checks. We might be accessing
6607 protected/private members from the base class.
6608 (TypeManager.RealMemberLookup): Only set private_ok if private
6609 members were requested via BindingFlags.NonPublic.
6611 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
6613 * expression.cs (MemberAccess.ResolveMemberAccess): Set
6614 MethodGroupExpr.IsExplicitImpl if appropriate.
6615 (Invocation.DoResolve): Don't report the CS0120 for explicit
6616 interface implementations.
6618 2002-08-27 Martin Baulig <martin@gnome.org>
6620 * expression.cs (Invocation.DoResolve): If this is a static
6621 method and we don't have an InstanceExpression, we must report
6624 2002-08-25 Martin Baulig <martin@gnome.org>
6626 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
6627 `==' between a valuetype and an object.
6629 2002-08-25 Miguel de Icaza <miguel@ximian.com>
6631 * ecore.cs (TypeExpr): Provide a ToString method.
6633 2002-08-24 Martin Baulig <martin@gnome.org>
6635 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
6636 now called proggie.dbg and it's a binary file.
6638 2002-08-23 Martin Baulig <martin@gnome.org>
6640 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
6642 2002-08-23 Martin Baulig <martin@gnome.org>
6644 * struct.cs (MyStructInfo.ctor): Make this work with empty
6645 structs; it's not allowed to use foreach() on null.
6647 2002-08-23 Martin Baulig <martin@gnome.org>
6649 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
6650 writer the full pathname of the generated assembly.
6652 2002-08-23 Martin Baulig <martin@gnome.org>
6654 * statements.cs (FlowBranching.UsageVector.MergeChildren):
6655 A `finally' block never returns or breaks; improved handling of
6658 2002-08-23 Martin Baulig <martin@gnome.org>
6660 * statement.cs (Throw.Resolve): Allow `throw null'.
6662 2002-08-23 Martin Baulig <martin@gnome.org>
6664 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
6665 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
6666 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
6667 MemberLookup would return a wrong event if this is an explicit
6668 interface implementation and the class has an event with the same
6671 2002-08-23 Martin Baulig <martin@gnome.org>
6673 * statement.cs (Block.AddChildVariableNames): New public method.
6674 (Block.AddChildVariableName): Likewise.
6675 (Block.IsVariableNameUsedInChildBlock): Likewise.
6676 (Block.AddVariable): Check whether a variable name has already
6677 been used in a child block.
6679 * cs-parser.jay (declare_local_variables): Mark all variable names
6680 from the current block as being used in a child block in the
6683 2002-08-23 Martin Baulig <martin@gnome.org>
6685 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
6686 find the symbol writer.
6688 * driver.cs: csc also allows the arguments to /define being
6689 separated by commas, not only by semicolons.
6691 2002-08-23 Martin Baulig <martin@gnome.org>
6693 * interface.cs (Interface.GetMembers): Added static check for events.
6695 2002-08-15 Martin Baulig <martin@gnome.org>
6697 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
6698 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
6700 * ecore.cs (Expression.MemberLookup): Added documentation and explained
6701 why the MethodData.EmitDestructor() change was necessary.
6703 2002-08-20 Martin Baulig <martin@gnome.org>
6705 * class.cs (TypeContainer.FindMembers): Added static check for events.
6707 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
6709 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
6710 use Type.GetEvents(), not Type.FindMembers().
6712 2002-08-20 Martin Baulig <martin@gnome.org>
6714 * decl.cs (MemberCache): Added a special method cache which will
6715 be used for method-only searched. This ensures that a method
6716 search will return a MethodInfo with the correct ReflectedType for
6719 2002-08-20 Martin Baulig <martin@gnome.org>
6721 * decl.cs (DeclSpace.FindMembers): Made this public.
6723 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6725 * delegate.cs: fixed build on windows.
6726 [FIXME: Filed as bug #29150: MCS must report these errors.]
6728 2002-08-19 Ravi Pratap <ravi@ximian.com>
6730 * ecore.cs (StandardConversionExists): Return a false
6731 if we are trying to convert the void type to anything else
6732 since that is not allowed.
6734 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
6735 we flag error 70 in the event an event is trying to be accessed
6736 directly from outside the declaring type.
6738 2002-08-20 Martin Baulig <martin@gnome.org>
6740 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
6741 MemberCache from typemanager.cs to decl.cs.
6743 2002-08-19 Martin Baulig <martin@gnome.org>
6745 * class.cs (TypeContainer): Implement IMemberContainer.
6746 (TypeContainer.DefineMembers): Create the MemberCache.
6747 (TypeContainer.FindMembers): Do better BindingFlags checking; only
6748 return public members if BindingFlags.Public was given, check
6749 whether members are static.
6751 2002-08-16 Martin Baulig <martin@gnome.org>
6753 * decl.cs (DeclSpace.Define): Splitted this in Define and
6754 DefineMembers. DefineMembers is called first and initializes the
6757 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
6758 DefineMembers() on all our DeclSpaces.
6760 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
6761 but call DefineMembers() on all nested interfaces. We call their
6762 Define() in our new Define() function.
6764 * interface.cs (Interface): Implement IMemberContainer.
6765 (Interface.Define): Moved all code except the attribute stuf to
6767 (Interface.DefineMembers): Initialize the member cache.
6769 * typemanager.cs (IMemberFinder): Removed this interface, we don't
6770 need this anymore since we can use MemberCache.FindMembers directly.
6772 2002-08-19 Martin Baulig <martin@gnome.org>
6774 * typemanager.cs (MemberCache): When creating the cache for an
6775 interface type, add all inherited members.
6776 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
6777 to `out bool used_cache' and documented it.
6778 (TypeManager.MemberLookup): If we already used the cache in the first
6779 iteration, we don't need to do the interfaces check.
6781 2002-08-19 Martin Baulig <martin@gnome.org>
6783 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
6784 here from IMemberFinder and don't implement this interface anymore.
6785 (DeclSpace.MemberCache): Moved here from IMemberFinder.
6787 * typemanager.cs (IMemberFinder): This interface is now only used by
6788 classes which actually support the member cache.
6789 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
6790 since we only put DeclSpaces into this Hashtable.
6791 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
6792 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
6794 2002-08-16 Martin Baulig <martin@gnome.org>
6796 * typemanager.cs (ICachingMemberFinder): Removed.
6797 (IMemberFinder.MemberCache): New property.
6798 (TypeManager.FindMembers): Merged this with RealFindMembers().
6799 This function will never be called from TypeManager.MemberLookup()
6800 so we can't use the cache here, just the IMemberFinder.
6801 (TypeManager.MemberLookup_FindMembers): Check whether the
6802 IMemberFinder has a MemberCache and call the cache's FindMembers
6804 (MemberCache): Rewrote larger parts of this yet another time and
6805 cleaned it up a bit.
6807 2002-08-15 Miguel de Icaza <miguel@ximian.com>
6809 * driver.cs (LoadArgs): Support quoting.
6811 (Usage): Show the CSC-like command line arguments.
6813 Improved a few error messages.
6815 2002-08-15 Martin Baulig <martin@gnome.org>
6817 * typemanager.cs (IMemberContainer.Type): New property.
6818 (IMemberContainer.IsInterface): New property.
6820 The following changes are conditional to BROKEN_RUNTIME, which is
6821 defined at the top of the file.
6823 * typemanager.cs (MemberCache.MemberCache): Don't add the base
6824 class'es members, but add all members from TypeHandle.ObjectType
6825 if we're an interface.
6826 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
6827 is the current type.
6828 (MemberCache.CacheEntry.Container): Removed this field.
6829 (TypeHandle.GetMembers): Include inherited members.
6831 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6833 * typemanager.cs: fixed compilation and added a comment on a field that
6836 2002-08-15 Martin Baulig <martin@gnome.org>
6838 * class.cs (ConstructorInitializer.Resolve): In the
6839 Expression.MemberLookup call, use the queried_type as
6842 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
6843 declared' attribute, it's always true.
6844 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
6845 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
6846 temporary wrapper for FindMembers which tells MemberLookup whether
6847 members from the base classes are included in the return value.
6848 This will go away soon.
6849 (TypeManager.MemberLookup): Use this temporary hack here; once the
6850 new MemberCache is completed, we don't need to do the DeclaredOnly
6851 looping here anymore since the MemberCache will take care of this.
6852 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
6853 (MemberCache): When creating the MemberCache for a class, get
6854 members from the current class and all its base classes.
6855 (MemberCache.CacheEntry.Container): New field. This is a
6856 temporary hack until the Mono runtime is fixed to distinguish
6857 between ReflectedType and DeclaringType. It allows us to use MCS
6858 with both the MS runtime and the unfixed Mono runtime without
6859 problems and without accecting performance.
6860 (MemberCache.SearchMembers): The DeclaredOnly looping from
6861 TypeManager.MemberLookup is now done here.
6863 2002-08-14 Martin Baulig <martin@gnome.org>
6865 * statement.cs (MyStructInfo.MyStructInfo): Don't call
6866 Type.GetFields on dynamic types but get the fields from the
6867 corresponding TypeContainer.
6868 (MyStructInfo.GetStructInfo): Added check for enum types.
6870 * typemanager.cs (MemberList.IsSynchronized): Implemented.
6871 (MemberList.SyncRoot): Implemented.
6872 (TypeManager.FilterWithClosure): No need to check permissions if
6873 closure_start_type == closure_invocation_type, don't crash if
6874 closure_invocation_type is null.
6876 2002-08-13 Martin Baulig <martin@gnome.org>
6878 Rewrote TypeContainer.FindMembers to use a member cache. This
6879 gives us a speed increase of about 35% for the self-hosting MCS
6880 build and of about 15-20% for the class libs (both on GNU/Linux).
6882 * report.cs (Timer): New class to get enhanced profiling. This
6883 whole class is "TIMER" conditional since it remarkably slows down
6886 * class.cs (MemberList): New class. This is an IList wrapper
6887 which we're now using instead of passing MemberInfo[]'s around to
6888 avoid copying this array unnecessarily.
6889 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
6890 (ICachingMemberFinder, IMemberContainer): New interface.
6891 (TypeManager.FilterWithClosure): If `criteria' is null, the name
6892 has already been checked, otherwise use it for the name comparision.
6893 (TypeManager.FindMembers): Renamed to RealMemberFinder and
6894 provided wrapper which tries to use ICachingMemberFinder.FindMembers
6895 if possible. Returns a MemberList, not a MemberInfo [].
6896 (TypeHandle): New class, implements IMemberContainer. We create
6897 one instance of this class per type, it contains a MemberCache
6898 which is used to do the member lookups.
6899 (MemberCache): New class. Each instance of this class contains
6900 all members of a type and a name-based hash table.
6901 (MemberCache.FindMembers): This is our new member lookup
6902 function. First, it looks up all members of the requested name in
6903 the hash table. Then, it walks this list and sorts out all
6904 applicable members and returns them.
6906 2002-08-13 Martin Baulig <martin@gnome.org>
6908 In addition to a nice code cleanup, this gives us a performance
6909 increase of about 1.4% on GNU/Linux - not much, but it's already
6910 half a second for the self-hosting MCS compilation.
6912 * typemanager.cs (IMemberFinder): New interface. It is used by
6913 TypeManager.FindMembers to call FindMembers on a TypeContainer,
6914 Enum, Delegate or Interface.
6915 (TypeManager.finder_to_member_finder): New PtrHashtable.
6916 (TypeManager.finder_to_container): Removed.
6917 (TypeManager.finder_to_delegate): Removed.
6918 (TypeManager.finder_to_interface): Removed.
6919 (TypeManager.finder_to_enum): Removed.
6921 * interface.cs (Interface): Implement IMemberFinder.
6923 * delegate.cs (Delegate): Implement IMemberFinder.
6925 * enum.cs (Enum): Implement IMemberFinder.
6927 * class.cs (TypeContainer): Implement IMemberFinder.
6929 2002-08-12 Martin Baulig <martin@gnome.org>
6931 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
6933 2002-08-12 Martin Baulig <martin@gnome.org>
6935 * ecore.cs (ITypeExpression): New interface for expressions which
6937 (TypeExpression): Renamed to TypeLookupExpression.
6938 (Expression.DoResolve): If we're doing a types-only lookup, the
6939 expression must implement the ITypeExpression interface and we
6940 call DoResolveType() on it.
6941 (SimpleName): Implement the new ITypeExpression interface.
6942 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
6943 hack, the situation that we're only looking up types can't happen
6944 anymore when this method is called. Moved the type lookup code to
6945 DoResolveType() and call it.
6946 (SimpleName.DoResolveType): This ITypeExpression interface method
6947 is now doing the types-only lookup.
6948 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
6949 (ResolveFlags): Added MaskExprClass.
6951 * expression.cs (MemberAccess): Implement the ITypeExpression
6953 (MemberAccess.DoResolve): Added support for a types-only lookup
6954 when we're called via ITypeExpression.DoResolveType().
6955 (ComposedCast): Implement the ITypeExpression interface.
6957 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
6958 Expression.Resolve() with ResolveFlags.Type instead.
6960 2002-08-12 Martin Baulig <martin@gnome.org>
6962 * interface.cs (Interface.Define): Apply attributes.
6964 * attribute.cs (Attribute.ApplyAttributes): Added support for
6965 interface attributes.
6967 2002-08-11 Martin Baulig <martin@gnome.org>
6969 * statement.cs (Block.Emit): Only check the "this" variable if we
6970 do not always throw an exception.
6972 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
6973 whether the property has a set accessor.
6975 2002-08-11 Martin Baulig <martin@gnome.org>
6977 Added control flow analysis support for structs.
6979 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
6980 with control flow analysis turned off.
6981 (IVariable): New interface.
6982 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
6983 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
6984 (FieldExpr.DoResolve): Resolve the instance expression with flow
6985 analysis turned off and do the definite assignment check after the
6986 resolving when we know what the expression will resolve to.
6988 * expression.cs (LocalVariableReference, ParameterReference):
6989 Implement the new IVariable interface, only call the flow analysis
6990 code if ec.DoFlowAnalysis is true.
6991 (This): Added constructor which takes a Block argument. Implement
6992 the new IVariable interface.
6993 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
6994 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
6995 This does the definite assignment checks for struct members.
6997 * class.cs (Constructor.Emit): If this is a non-static `struct'
6998 constructor which doesn't have any initializer, call
6999 Block.AddThisVariable() to tell the flow analysis code that all
7000 struct elements must be initialized before control returns from
7003 * statement.cs (MyStructInfo): New public class.
7004 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
7005 argument to this indexer. If non-zero, check an individual struct
7006 member, not the whole struct.
7007 (FlowBranching.CheckOutParameters): Check struct members.
7008 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
7009 overloaded versions of these methods which take an additional
7010 `int field_idx' argument to check struct members.
7011 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
7012 overloaded versions of these methods which take an additional
7013 `string field_name' argument to check struct member.s
7014 (VariableInfo): Implement the IVariable interface.
7015 (VariableInfo.StructInfo): New public property. Returns the
7016 MyStructInfo instance of the variable if it's a struct or null.
7017 (Block.AddThisVariable): New public method. This is called from
7018 Constructor.Emit() for non-static `struct' constructor which do
7019 not have any initializer. It creates a special variable for the
7020 "this" instance variable which will be checked by the flow
7021 analysis code to ensure that all of the struct's fields are
7022 initialized before control returns from the constructor.
7023 (UsageVector): Added support for struct members. If a
7024 variable/parameter is a struct with N members, we reserve a slot
7025 in the usage vector for each member. A struct is considered fully
7026 initialized if either the struct itself (slot 0) or all its
7027 members are initialized.
7029 2002-08-08 Martin Baulig <martin@gnome.org>
7031 * driver.cs (Driver.MainDriver): Only report an error CS5001
7032 if there were no compilation errors.
7034 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
7035 `UnsafeContext' property to determine whether the parent is in
7036 unsafe context rather than checking the parent's ModFlags:
7037 classes nested in an unsafe class are unsafe as well.
7039 2002-08-08 Martin Baulig <martin@gnome.org>
7041 * statement.cs (UsageVector.MergeChildren): Distinguish between
7042 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
7043 we return. Added test17() and test18() to test-154.cs.
7045 2002-08-08 Martin Baulig <martin@gnome.org>
7047 * typemanager.cs (TypeManager.FilterWithClosure): If we have
7048 Family access, make sure the invoking type isn't a subclass of the
7049 queried type (that'd be a CS1540).
7051 * ecore.cs (Expression.MemberLookup): Added overloaded version of
7052 this method which takes an additional `Type invocation_type'.
7054 * expression.cs (BaseAccess.DoResolve): Use the base type as
7055 invocation and query type.
7056 (MemberAccess.DoResolve): If the lookup failed and we're about to
7057 report a CS0122, try a lookup with the ec.ContainerType - if this
7058 succeeds, we must report a CS1540.
7060 2002-08-08 Martin Baulig <martin@gnome.org>
7062 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
7063 (MethodGroupExpr): Implement the IMemberExpr interface.
7065 * expression (MemberAccess.ResolveMemberAccess): No need to have
7066 any special code for MethodGroupExprs anymore, they're now
7069 2002-08-08 Martin Baulig <martin@gnome.org>
7071 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
7072 Family, FamANDAssem and FamORAssem permissions.
7073 (TypeManager.IsSubclassOrNestedChildOf): New public method.
7075 2002-08-08 Martin Baulig <martin@gnome.org>
7077 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
7078 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
7081 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
7083 * driver.cs: implemented /resource option to embed managed resources.
7085 2002-08-07 Martin Baulig <martin@gnome.org>
7087 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
7088 (FieldBase.HasFieldInitializer): New public property.
7089 (FieldBase.GetInitializerExpression): New public method. Resolves and
7090 returns the field initializer and makes sure it is only resolved once.
7091 (TypeContainer.EmitFieldInitializers): Call
7092 FieldBase.GetInitializerExpression to get the initializer, this ensures
7093 that it isn't resolved multiple times.
7095 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
7096 the resolving process (SimpleName/MemberLookup) that we're currently
7097 emitting a field initializer (which must not access any instance members,
7098 this is an error CS0236).
7100 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
7101 argument, if the `IsFieldInitializer' flag is set, we must report and
7102 error CS0236 and not an error CS0120.
7104 2002-08-07 Martin Baulig <martin@gnome.org>
7106 * ecore.cs (IMemberExpr): New public interface.
7107 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
7108 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
7109 if the expression is an IMemberExpr.
7111 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
7112 to be null, implicitly default to `this' if we're non-static in
7113 this case. Simplified the code a lot by using the new IMemberExpr
7114 interface. Also fixed bug #28176 here.
7116 2002-08-06 Martin Baulig <martin@gnome.org>
7118 * cs-parser.jay (SimpleLookup): Removed. We need to create
7119 ParameterReferences during semantic analysis so that we can do a
7120 type-only search when resolving Cast, TypeOf and SizeOf.
7121 (block): Pass the `current_local_parameters' to the Block's
7124 * class.cs (ConstructorInitializer): Added `Parameters parameters'
7125 argument to the constructor.
7126 (ConstructorInitializer.Resolve): Create a temporary implicit
7127 block with the parameters.
7129 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
7130 references here if we aren't doing a type-only search.
7132 * statement.cs (Block): Added constructor which takes a
7133 `Parameters parameters' argument.
7134 (Block.Parameters): New public property.
7136 * support.cs (InternalParameters.Parameters): Renamed `parameters'
7137 to `Parameters' and made it public readonly.
7139 2002-08-06 Martin Baulig <martin@gnome.org>
7141 * ecore.cs (Expression.Warning): Made this public as well.
7143 * report.cs (Report.Debug): Print the contents of collections.
7145 2002-08-06 Martin Baulig <martin@gnome.org>
7147 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
7148 used to tell Resolve() which kinds of expressions it may return.
7149 (Expression.Resolve): Added overloaded version of this method which
7150 takes a `ResolveFlags flags' argument. This can be used to tell
7151 Resolve() which kinds of expressions it may return. Reports a
7153 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
7154 ResolveFlags.SimpleName.
7155 (Expression.Error118): Added overloaded version of this method which
7156 takes a `ResolveFlags flags' argument. It uses the flags to determine
7157 which kinds of expressions are allowed.
7159 * expression.cs (Argument.ResolveMethodGroup): New public method.
7160 Resolves an argument, but allows a MethodGroup to be returned.
7161 This is used when invoking a delegate.
7163 * TODO: Updated a bit.
7165 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7167 Fixed compilation with csc.
7169 * ecore.cs: Expression.Error made public. Is this correct? Should
7170 Warning be made public too?
7172 * expression.cs: use ea.Location instead of ea.loc.
7173 [FIXME: Filed as bug #28607: MCS must report these errors.]
7175 2002-08-06 Martin Baulig <martin@gnome.org>
7177 * ecore.cs (Expression.loc): Moved the location here instead of
7178 duplicating it in all derived classes.
7179 (Expression.Location): New public property.
7180 (Expression.Error, Expression.Warning): Made them non-static and
7181 removed the location argument.
7182 (Expression.Warning): Added overloaded version which takes an
7183 `int level' argument.
7184 (Expression.Error118): Make this non-static and removed the
7185 expression and location arguments.
7186 (TypeExpr): Added location argument to the constructor.
7188 * expression.cs (StaticCallExpr): Added location argument to
7190 (Indirection, PointerArithmetic): Likewise.
7191 (CheckedExpr, UnCheckedExpr): Likewise.
7192 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
7193 (StringPtr): Likewise.
7196 2002-08-05 Martin Baulig <martin@gnome.org>
7198 * expression.cs (BaseAccess.DoResolve): Actually report errors.
7200 * assign.cs (Assign.DoResolve): Check whether the source
7201 expression is a value or variable.
7203 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
7204 while resolving the corresponding blocks.
7206 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
7207 an error, don't silently return null.
7209 * statement.cs (Block.AddVariable): Do the error reporting here
7210 and distinguish between CS0128 and CS0136.
7211 (Block.DoResolve): Report all unused labels (warning CS0164).
7212 (LabeledStatement): Pass the location to the constructor.
7213 (LabeledStatement.HasBeenReferenced): New property.
7214 (LabeledStatement.Resolve): Set it to true here.
7216 * statement.cs (Return.Emit): Return success even after reporting
7217 a type mismatch error (CS0126 or CS0127), this is what csc does and
7218 it avoids confusing the users with any consecutive errors.
7220 2002-08-05 Martin Baulig <martin@gnome.org>
7222 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
7224 * const.cs (Const.LookupConstantValue): Catch circular definitions.
7226 * expression.cs (MemberAccess.DoResolve): Silently return if an
7227 error has already been reported.
7229 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
7230 error has already been reported.
7232 2002-08-05 Martin Baulig <martin@gnome.org>
7234 * statement.cs (UsageVector): Only initialize the `parameters'
7235 vector if we actually have any "out" parameters.
7237 2002-08-05 Martin Baulig <martin@gnome.org>
7239 * expression.cs (Binary.ResolveOperator): When combining delegates,
7240 they must have the same type.
7242 2002-08-05 Martin Baulig <martin@gnome.org>
7244 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
7245 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
7246 work with the ms runtime and we also don't need it: if we're a
7247 PropertyBuilder and not in the `indexer_arguments' hash, then we
7248 are a property and not an indexer.
7250 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
7251 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
7252 since the latter one doesn't work with the ms runtime.
7254 2002-08-03 Martin Baulig <martin@gnome.org>
7256 Fixed bugs #27998 and #22735.
7258 * class.cs (Method.IsOperator): New public field.
7259 (Method.CheckBase): Report CS0111 if there's already a method
7260 with the same parameters in the current class. Report CS0508 when
7261 attempting to change the return type of an inherited method.
7262 (MethodData.Emit): Report CS0179 if a method doesn't have a body
7263 and it's not marked abstract or extern.
7264 (PropertyBase): New abstract base class for Property and Indexer.
7265 (PropertyBase.CheckBase): Moved here from Property and made it work
7267 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
7268 the same so we can reuse it there.
7269 (Property, Indexer): Derive from PropertyBase.
7270 (MethodSignature.inheritable_property_signature_filter): New delegate
7271 to find properties and indexers.
7273 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
7274 argument and improved error reporting.
7276 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
7277 EmptyReadOnlyParameters and made it a property.
7279 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
7280 version of this method which takes a `PropertyInfo indexer'.
7281 (TypeManager.RegisterIndexer): New method.
7283 * class.cs: Added myself as author of this file :-)
7285 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7287 * class.cs: fixed compilation on windoze.
7289 2002-08-03 Martin Baulig <martin@gnome.org>
7291 * interface.cs (Interface.GetInterfaceBases): Check whether all
7292 base interfaces are at least as accessible than the current one.
7294 * class.cs (TypeContainer.GetClassBases): Check whether base types
7295 are at least as accessible than the current type.
7296 (TypeContainer.AsAccessible): Implemented and made non-static.
7297 (MemberBase.CheckParameters): Report errors if the accessibility
7300 * delegate.cs (Delegate.Delegate): The default visibility is
7301 internal for top-level types and private for nested types.
7302 (Delegate.Define): Report errors if the accessibility checks fail.
7304 * enum.cs (Enum.Enum): The default visibility is internal for
7305 top-level types and private for nested types.
7306 (Enum.DefineType): Compute the correct visibility.
7308 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
7309 function which takes a `bool is_toplevel' instead of a TypeContainer.
7311 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
7314 2002-08-02 Martin Baulig <martin@gnome.org>
7316 * expression.cs (LocalVariableReferenc): Added constructor which
7317 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
7318 (LocalVariableReference.IsReadOnly): New property.
7319 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
7320 variable is readonly, use our own readonly flag to do this; you can
7321 use the new constructor to get a writable reference to a read-only
7324 * cs-parser.jay (foreach_statement, using_statement): Get a writable
7325 reference to the local variable.
7327 2002-08-01 Miguel de Icaza <miguel@ximian.com>
7329 * rootcontext.cs (ResolveCore): Also include System.Exception
7331 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
7332 we reach an EmptyStatement.
7334 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
7337 * expression.cs (Binary.ResolveOperator): Check error result in
7340 use brtrue/brfalse directly and avoid compares to null.
7342 2002-08-02 Martin Baulig <martin@gnome.org>
7344 * class.cs (TypeContainer.Define): Define all nested interfaces here.
7345 Fixes bug #28407, added test-155.cs.
7347 2002-08-01 Martin Baulig <martin@gnome.org>
7349 * class.cs (Event.EmitDefaultMethod): Make this work with static
7350 events. Fixes #28311, added verify-3.cs.
7352 2002-08-01 Martin Baulig <martin@gnome.org>
7354 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
7355 `is_disposable' fields.
7356 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
7357 `hm.is_disposable' if we're using the collection pattern.
7358 (Foreach.EmitCollectionForeach): Use the correct type for the
7359 enumerator's local variable, only emit the try/finally block if
7360 necessary (fixes #27713).
7362 2002-08-01 Martin Baulig <martin@gnome.org>
7364 * ecore.cs (Expression.report118): Renamed to Error118 and made
7367 * statement.cs (Throw.Resolve): Check whether the expression is of
7368 the correct type (CS0118) and whether the type derives from
7369 System.Exception (CS0155).
7370 (Catch.Resolve): New method. Do the type lookup here and check
7371 whether it derives from System.Exception (CS0155).
7372 (Catch.CatchType, Catch.IsGeneral): New public properties.
7374 * typemanager.cs (TypeManager.exception_type): Added.
7376 2002-07-31 Miguel de Icaza <miguel@ximian.com>
7378 * driver.cs: Updated About function.
7380 2002-07-31 Martin Baulig <martin@gnome.org>
7382 Implemented Control Flow Analysis.
7384 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
7385 (EmitContext.CurrentBranching): Added.
7386 (EmitContext.StartFlowBranching): Added.
7387 (EmitContext.EndFlowBranching): Added.
7388 (EmitContext.KillFlowBranching): Added.
7389 (EmitContext.IsVariableAssigned): Added.
7390 (EmitContext.SetVariableAssigned): Added.
7391 (EmitContext.IsParameterAssigned): Added.
7392 (EmitContext.SetParameterAssigned): Added.
7393 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
7394 Added control flow analysis stuff here.
7396 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
7397 resolve the expression as lvalue.
7398 (LocalVariableReference.DoResolve): Check whether the variable has
7399 already been assigned.
7400 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
7401 the parameter as assigned here.
7402 (ParameterReference.DoResolve): Check whether the parameter has already
7404 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
7405 expression as lvalue.
7407 * statement.cs (FlowBranching): New class for the flow analysis code.
7408 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
7409 (LabeledStatement.IsDefined): New public property.
7410 (LabeledStatement.AddUsageVector): New public method to tell flow
7411 analyis that the label may be reached via a forward jump.
7412 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
7414 (VariableInfo.Number): New public field. This is used by flow analysis
7415 to number all locals of a block.
7416 (Block.CountVariables): New public property. This is the number of
7417 local variables in this block (including the locals from all parent
7419 (Block.EmitMeta): Number all the variables.
7421 * statement.cs: Added flow analysis support to all classes.
7423 2002-07-31 Martin Baulig <martin@gnome.org>
7425 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
7426 To get debugging messages, compile mcs with /define:MCS_DEBUG and
7427 then use this argument.
7429 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
7431 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
7432 use this to specify /define options.
7434 2002-07-29 Martin Baulig <martin@gnome.org>
7436 * statement.cs (Fixed): Moved all code that does variable lookups
7437 and resolvings from Emit to Resolve.
7439 * statement.cs (For): Moved all code that does variable lookups
7440 and resolvings from Emit to Resolve.
7442 * statement.cs (Using): Moved all code that does variable lookups
7443 and resolvings from Emit to Resolve.
7445 2002-07-29 Martin Baulig <martin@gnome.org>
7447 * attribute.cs (Attribute.Resolve): Explicitly catch a
7448 System.NullReferenceException when creating the
7449 CustromAttributeBuilder and report a different warning message.
7451 2002-07-29 Martin Baulig <martin@gnome.org>
7453 * support.cs (ParameterData.ParameterName): Added method to
7454 get the name of a parameter.
7456 * typemanager.cs (TypeManager.IsValueType): New public method.
7458 2002-07-29 Martin Baulig <martin@gnome.org>
7460 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
7461 is a flag which specifies that it's either ref or out.
7462 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
7463 the out parameter to `out Parameter.Modifier mod', also set the
7464 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
7466 * support.cs (InternalParameters.ParameterModifier): Distinguish
7467 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
7468 Parameter.Modifier.ISBYREF flag if it's either ref or out.
7470 * expression.cs (Argument.GetParameterModifier): Distinguish
7471 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
7472 Parameter.Modifier.ISBYREF flag if it's either ref or out.
7474 2002-07-29 Martin Baulig <martin@gnome.org>
7476 * expression.cs (ParameterReference.ParameterReference): Added
7477 `Location loc' argument to the constructor.
7479 * cs-parser.jay: Pass location to ParameterReference.
7481 2002-07-28 Miguel de Icaza <miguel@ximian.com>
7483 * statement.cs (Try): Initialize the location.
7485 * cs-parser.jay: pass location to Try.
7487 * expression.cs (Unary.Reduce): Change the prototype to return
7488 whether a constant fold could be performed or not. The result is
7489 returned in an out parameters. In the case of Indirection and
7490 AddressOf, we want to perform the full tests.
7492 2002-07-26 Miguel de Icaza <miguel@ximian.com>
7494 * statement.cs (Statement.Emit): Flag dead code.
7496 2002-07-27 Andrew Birkett <andy@nobugs.org>
7498 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
7500 2002-07-27 Martin Baulig <martin@gnome.org>
7502 * class.cs (MethodData.Define): Put back call to
7503 TypeManager.AddMethod(), accidentally commented this out.
7505 * report.cs (Debug): New public method to print debugging information,
7506 this is `[Conditional ("DEBUG")]'.
7508 2002-07-26 Martin Baulig <martin@gnome.org>
7510 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
7511 (switch_statement): Push the current_block to the switch_stack and
7512 pop it again when we're done with the switch.
7513 (switch_section): The new block is a child of the current_block.
7514 Fixes bug #24007, added test-152.cs.
7516 2002-07-27 Martin Baulig <martin@gnome.org>
7518 * expression.cs (Invocation.EmitArguments): When calling a varargs
7519 function with only its fixed arguments, we need to pass an empty
7522 2002-07-27 Martin Baulig <martin@gnome.org>
7524 Mono 0.13 has been released.
7526 2002-07-25 Miguel de Icaza <miguel@ximian.com>
7528 * driver.cs: Rename --resource to --linkres, because that is what
7529 we do currently, we dont support --resource yet.
7531 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
7533 2002-07-25 Martin Baulig <martin@gnome.org>
7535 * class.cs (MethodData): New public class. This is a `method builder'
7536 class for a method or one accessor of a Property/Indexer/Event.
7537 (MethodData.GetMethodFlags): Moved here from MemberBase.
7538 (MethodData.ApplyAttributes): Likewise.
7539 (MethodData.ApplyObsoleteAttribute): Likewise.
7540 (MethodData.ApplyConditionalAttribute): Likewise.
7541 (MethodData.ApplyDllImportAttribute): Likewise.
7542 (MethodData.CheckAbstractAndExternal): Likewise.
7543 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
7544 (MethodData.Emit): Formerly known as Method.Emit().
7545 (MemberBase): Moved everything which was specific to a single
7546 accessor/method to MethodData.
7547 (Method): Create a new MethodData and call Define() and Emit() on it.
7548 (Property, Indexer, Event): Create a new MethodData objects for each
7549 accessor and call Define() and Emit() on them.
7551 2002-07-25 Martin Baulig <martin@gnome.org>
7553 Made MethodCore derive from MemberBase to reuse the code from there.
7554 MemberBase now also checks for attributes.
7556 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
7557 (MemberBase.GetMethodFlags): Moved here from class Method and marked
7559 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
7560 `CallingConventions cc' and `Attributes opt_attrs' arguments.
7561 (MemberBase.ApplyAttributes): New virtual method; applies the
7562 attributes to a method or accessor.
7563 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
7564 (MemberBase.ApplyConditionalAttribute): Likewise.
7565 (MemberBase.ApplyDllImportAttribute): Likewise.
7566 (MemberBase.CheckAbstractAndExternal): Likewise.
7567 (MethodCore.ParameterTypes): This is now a property instead of a
7568 method, it's initialized from DoDefineParameters().
7569 (MethodCore.ParameterInfo): Removed the set accessor.
7570 (MethodCore.DoDefineParameters): New protected virtual method to
7571 initialize ParameterTypes and ParameterInfo.
7572 (Method.GetReturnType): We can now simply return the MemberType.
7573 (Method.GetMethodFlags): Override the MemberBase version and add
7574 the conditional flags.
7575 (Method.CheckBase): Moved some code from Define() here, call
7576 DoDefineParameters() here.
7577 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
7578 here to avoid some larger code duplication.
7579 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
7580 ensure that abstract and external accessors don't declare a body.
7582 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
7583 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
7584 lookup in the attribute's parent classes, so we need to abort as soon
7585 as we found the first match.
7586 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
7587 the attribute has no arguments.
7589 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
7592 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7594 * cs-parser.jay: reverted previous patch.
7596 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7598 * cs-parser.jay: fixed bug #22119.
7600 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7602 * attribute.cs: fixed compilation. The error was:
7603 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
7604 be assigned to before control leaves the current method."
7605 [FIXME: Filed as bug #28186: MCS must report this error.]
7607 2002-07-25 Martin Baulig <martin@gnome.org>
7609 * attribute.cs (Attribute.Conditional_GetConditionName): New static
7610 method to pull the condition name ouf of a Conditional attribute.
7611 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
7612 the obsolete message and error flag out of an Obsolete attribute.
7614 * class.cs (Method.GetMethodFlags): New public method to get the
7615 TypeManager.MethodFlags for this method.
7616 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
7618 (Method.Define): Get and apply the Obsolete and Conditional attributes;
7619 if we're overriding a virtual function, set the new private variable
7620 `parent_method'; call the new TypeManager.AddMethod().
7622 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
7623 the MethodBuilder and the Method in a PtrHashtable.
7624 (TypeManager.builder_to_method): Added for this purpose.
7625 (TypeManager.MethodFlags): Added IsObsoleteError.
7626 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
7627 Obsolete and Conditional arguments in MethodBuilders. If we discover
7628 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
7629 the message from the attribute.
7631 2002-07-24 Martin Baulig <martin@gnome.org>
7633 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
7634 preprocessor directives, ensure that the argument to #define/#undef is
7635 exactly one identifier and that it's actually an identifier.
7637 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
7640 2002-07-24 Martin Baulig <martin@gnome.org>
7642 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
7643 initialize it to TypeManager.object_type in the constructor.
7644 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
7645 of the `hm.get_current' method if we're using the collection pattern.
7646 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
7647 for the explicit conversion to make it work when we're using the collection
7648 pattern and the `Current' property has a different return type than `object'.
7651 2002-07-24 Martin Baulig <martin@gnome.org>
7653 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
7654 does not match, but don't report any errors. This method is called in
7655 order for all methods in a MethodGroupExpr until a matching method is
7656 found, so we don't want to bail out if the first method doesn't match.
7657 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
7658 matches, report the 123. Fixes #28070.
7660 2002-07-24 Martin Baulig <martin@gnome.org>
7662 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
7663 TypeManager.TypeToCoreType() to the top of the method so the
7664 following equality checks will work. Fixes #28107.
7666 2002-07-24 Martin Baulig <martin@gnome.org>
7668 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
7669 operand is of type uint, and the other operand is of type sbyte,
7670 short or int, the operands are converted to type long." -
7671 Actually do what this comment already told us. Fixes bug #28106,
7674 2002-07-24 Martin Baulig <martin@gnome.org>
7676 * class.cs (MethodBase): New abstract class. This is now a base
7677 class for Property, Indexer and Event to avoid some code duplication
7678 in their Define() and DefineMethods() methods.
7679 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
7680 generic methods for Define() and DefineMethods().
7681 (FieldBase): Derive from MemberBase, not MemberCore.
7682 (Property): Derive from MemberBase, not MemberCore.
7683 (Property.DefineMethod): Moved all the code from this method to the
7684 new MethodBase.DefineAccessor(), just call it with appropriate
7686 (Property.Define): Call the new Property.DoDefine(), this does some
7687 sanity checks and we don't need to duplicate the code everywhere.
7688 (Event): Derive from MemberBase, not MemberCore.
7689 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
7690 accessors, this will also make them work with interface events.
7691 (Indexer): Derive from MemberBase, not MemberCore.
7692 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
7693 (Indexer.Define): Use the new MethodBase functions.
7695 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
7696 argument to the constructor.
7697 (Interface.FindMembers): Added support for interface events.
7698 (Interface.PopluateEvent): Implemented.
7700 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
7702 2002-07-22 Miguel de Icaza <miguel@ximian.com>
7704 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
7705 but this is required to check for a method name being the same as
7706 the containing class.
7710 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7712 * interface.cs: initialize variable.
7714 2002-07-23 Martin Baulig <martin@gnome.org>
7716 Implemented the IndexerName attribute in interfaces.
7718 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
7719 name if this is an explicit interface implementation.
7720 (Indexer.InterfaceIndexerName): New public variable. If we're
7721 implementing an interface indexer, this is the IndexerName in that
7722 interface. Otherwise, it's the IndexerName.
7723 (Indexer.DefineMethod): If we're implementing interface indexer,
7724 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
7725 and Pending.ImplementIndexer methods.
7726 (Indexer.Define): Also define the PropertyBuilder if we're
7727 implementing an interface indexer and this is neither an explicit
7728 interface implementation nor do the IndexerName match the one in
7731 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
7732 If a method is defined here, then we always need to create a proxy
7733 for it. This is used when implementing interface indexers.
7734 (Pending.IsInterfaceIndexer): New public method.
7735 (Pending.ImplementIndexer): New public method.
7736 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
7737 This is used when implementing interface indexers to define a proxy
7739 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
7740 define a proxy if necessary.
7742 * interface.cs (Interface.IndexerName): New public variable.
7743 (Interface.PopulateIndexer): Set the IndexerName.
7744 (Interface.DefineIndexers): New private method. Populate all the
7745 indexers and make sure their IndexerNames match.
7747 * typemanager.cs (IndexerPropertyName): Added support for interface
7750 2002-07-22 Martin Baulig <martin@gnome.org>
7752 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
7753 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
7754 ret if HasReturnLabel.
7755 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
7758 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
7759 and set the ec.LoopBeginTryCatchLevel.
7760 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
7761 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
7762 the current ec.TryCatchLevel, the branch goes out of an exception
7763 block. In this case, we need to use Leave and not Br.
7765 2002-07-22 Martin Baulig <martin@gnome.org>
7767 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
7768 block unless the block does not always return or it is contained in
7769 another try { ... } catch { ... } block. Fixes bug #26506.
7770 Added verify-1.cs to the test suite.
7772 2002-07-22 Martin Baulig <martin@gnome.org>
7774 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
7775 then we do not always return. Fixes bug #24985.
7777 2002-07-22 Martin Baulig <martin@gnome.org>
7779 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
7780 lookup on a per-class level; ie. walk up the class hierarchy until we
7781 found at least one applicable method, then choose the best among them.
7782 Fixes bug #24463 and test-29.cs.
7784 2002-07-22 Martin Baulig <martin@gnome.org>
7786 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
7787 return types of the methods. The return type is not part of the
7788 signature and we must not check it to make the `new' modifier work.
7789 Fixes bug #27999, also added test-147.cs.
7790 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
7792 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
7793 on the method's return type.
7795 2002-07-21 Martin Baulig <martin@gnome.org>
7797 * assign.cs: Make this work if the rightmost source is a constant and
7798 we need to do an implicit type conversion. Also adding a few more tests
7799 to test-38.cs which should have caught this.
7801 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
7802 target in the makefile for this. The makefile.gnu is primarily intended
7803 for end-users who don't want to debug the compiler.
7805 2002-07-21 Martin Baulig <martin@gnome.org>
7807 * assign.cs: Improved the Assign class so it can now handle embedded
7808 assignments (X = Y = Z = something). As a side-effect this'll now also
7809 consume less local variables. test-38.cs now passes with MCS, added
7810 a few new test cases to that test.
7812 2002-07-20 Martin Baulig <martin@gnome.org>
7814 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
7815 instructions. Fixes bug #27977, also added test-146.cs.
7817 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7819 * cs-tokenizer.cs: fixed getHex ().
7821 2002-07-19 Martin Baulig <martin@gnome.org>
7823 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
7824 not Type.GetType() to lookup the array type. This is needed when
7825 we're constructing an array of a user-defined type.
7826 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
7827 single-dimensional arrays, but also for single-dimensial arrays of
7830 2002-07-19 Martin Baulig <martin@gnome.org>
7832 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
7833 this function is called, it's not allowed to share LocalBuilders
7836 2002-07-19 Martin Baulig <martin@gnome.org>
7838 * expression.cs (Argument.Resolve): Report an error 118 when trying
7839 to pass a type as argument.
7841 2002-07-18 Martin Baulig <martin@gnome.org>
7843 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
7844 Conv_R_Un for the signed `long' type.
7846 2002-07-15 Miguel de Icaza <miguel@ximian.com>
7848 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
7849 `expr' for the temporary result, as that will fail if we do
7850 multiple resolves on the same expression.
7852 2002-07-05 Miguel de Icaza <miguel@ximian.com>
7854 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
7855 ec.TypeContainer for looking up aliases.
7857 * class.cs (TypeContainer): Remove LookupAlias from here.
7859 * decl.cs (DeclSpace); Move here.
7861 2002-07-01 Miguel de Icaza <miguel@ximian.com>
7863 * class.cs (FindMembers): Only call filter if the constructor
7864 bulider is not null.
7866 Also handle delegates in `NestedTypes' now. Now we will perform
7867 type lookups using the standard resolution process. This also
7870 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
7871 This uses Expressions (the limited kind that can be parsed by the
7872 tree) instead of strings.
7874 * expression.cs (ComposedCast.ToString): Implement, used to flag
7875 errors since now we have to render expressions.
7877 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
7880 * ecore.cs (SimpleName.ToString): ditto.
7882 * cs-parser.jay: Instead of using strings to assemble types, use
7883 Expressions to assemble the type (using SimpleName, ComposedCast,
7884 MemberAccess). This should fix the type lookups in declarations,
7885 because we were using a different code path for this.
7887 * statement.cs (Block.Resolve): Continue processing statements
7888 even when there is an error.
7890 2002-07-17 Miguel de Icaza <miguel@ximian.com>
7892 * class.cs (Event.Define): Also remove the `remove' method from
7893 the list of pending items.
7895 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
7896 generate more compact code.
7898 2002-07-17 Martin Baulig <martin@gnome.org>
7900 * const.cs (Const.LookupConstantValue): Add support for constant
7901 `unchecked' and `checked' expressions.
7902 Also adding test case test-140.cs for this.
7904 2002-07-17 Martin Baulig <martin@gnome.org>
7906 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
7907 check whether mi.ReturnType implements the IEnumerator interface; the
7908 `==' and the IsAssignableFrom() will fail in this situation.
7910 2002-07-16 Ravi Pratap <ravi@ximian.com>
7912 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
7915 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7917 * expression.cs: fixed bug #27811.
7919 2002-07-14 Miguel de Icaza <miguel@ximian.com>
7921 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
7922 Molaro: when we are a ref, the value already contains a pointer
7923 value, do not take the address of it.
7925 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
7926 * removed mb-parser.jay and mb-tokenizer.cs
7928 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
7930 * expression.cs: check against the building corlib void type.
7932 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
7934 * ecore.cs: fix for valuetype static readonly fields: when
7935 initializing them, we need their address, not the address of a copy.
7937 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
7939 * typemanager.cs: register also enum_type in corlib.
7941 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
7943 * class.cs: allow calling this (but not base) initializers in structs.
7945 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
7947 * ecore.cs: make sure we compare against the building base types
7950 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
7952 * typemanager.cs: fix TypeToCoreType() to handle void and object
7953 (corlib gets no more typerefs after this change).
7955 2002-07-12 Miguel de Icaza <miguel@ximian.com>
7957 * expression.cs (ArrayCreation.EmitArrayArguments): use
7958 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
7960 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
7961 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
7962 array indexes, the runtime actually forbids them.
7964 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
7965 for array arguments here.
7967 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
7968 instead of the default for ValueTypes.
7970 (New.DoEmit): Use IsValueType instead of
7971 IsSubclassOf (value_type)
7972 (New.DoResolve): ditto.
7973 (Invocation.EmitCall): ditto.
7975 * assign.cs (Assign): ditto.
7977 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
7978 Statements *are* currently doing part of their resolution during
7981 Expressions do always resolve during resolve, but statements are
7982 only required to propagate resolution to their children.
7984 2002-07-11 Miguel de Icaza <miguel@ximian.com>
7986 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
7988 (LoadAssembly): Do not add the dll if it is already specified
7990 (MainDriver): Add the System directory to the link path at the end,
7991 after all the other -L arguments.
7993 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
7994 wrong opcode for loading bytes and bools (ldelem.i1 instead of
7995 ldelem.u1) and using the opposite for sbytes.
7997 This fixes Digger, and we can finally run it.
7999 * driver.cs (UnixParseOption): Move the option parsing here.
8000 (CSCParseOption): Implement CSC-like parsing of options.
8002 We now support both modes of operation, the old Unix way, and the
8003 new CSC-like way. This should help those who wanted to make cross
8006 The only thing broken is that /r:, /reference: and /lib: are not
8007 implemented, because I want to make those have the same semantics
8008 as the CSC compiler has, and kill once and for all the confussion
8009 around this. Will be doing this tomorrow.
8011 * statement.cs (Unsafe.Resolve): The state is checked during
8012 resolve, not emit, so we have to set the flags for IsUnsfe here.
8014 2002-07-10 Miguel de Icaza <miguel@ximian.com>
8016 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
8017 not catch the Error_ObjectRefRequired in SimpleName (as it is
8018 possible to have a class/instance variable name that later gets
8019 deambiguated), we have to check this here.
8021 2002-07-10 Ravi Pratap <ravi@ximian.com>
8023 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
8024 make static and put into Expression.
8026 (Event.Define): Register the private field of the event with the
8027 TypeManager so that GetFieldFromEvent can get at it.
8029 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
8030 keep track of the private field associated with an event which
8033 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
8036 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
8038 2002-07-10 Miguel de Icaza <miguel@ximian.com>
8040 * expression.cs (Binary.EmitBranchable): this routine emits the
8041 Binary expression in a branchable context. This basically means:
8042 we need to branch somewhere, not just get the value on the stack.
8044 This works together with Statement.EmitBoolExpression.
8046 * statement.cs (Statement.EmitBoolExpression): Use
8049 2002-07-09 Miguel de Icaza <miguel@ximian.com>
8051 * statement.cs (For): Reduce the number of jumps in loops.
8053 (For): Implement loop inversion for the For statement.
8055 (Break): We can be breaking out of a Try/Catch controlled section
8056 (foreach might have an implicit try/catch clause), so we need to
8057 use Leave instead of Br.
8059 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
8060 now). If the instace expression supports IMemoryLocation, we use
8061 the AddressOf method from the IMemoryLocation to extract the
8062 address instead of emitting the instance.
8064 This showed up with `This', as we were emitting the instance
8065 always (Emit) instead of the Address of This. Particularly
8066 interesting when This is a value type, as we dont want the Emit
8067 effect (which was to load the object).
8069 2002-07-08 Miguel de Icaza <miguel@ximian.com>
8071 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
8073 * statement.cs (Checked): Set the CheckedState during the resolve
8074 process too, as the ConvCast operations track the checked state on
8075 the resolve process, and not emit.
8077 * cs-parser.jay (namespace_member_declaration): Flag that we have
8078 found a declaration when we do. This is used to flag error 1529
8080 * driver.cs: Report ok when we display the help only.
8082 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
8084 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
8086 2002-07-04 Miguel de Icaza <miguel@ximian.com>
8088 * cs-tokenizer.cs (define): We also have to track locally the
8089 defines. AllDefines is just used for the Conditional Attribute,
8090 but we also need the local defines for the current source code.
8092 2002-07-03 Miguel de Icaza <miguel@ximian.com>
8094 * statement.cs (While, For, Do): These loops can exit through a
8095 Break statement, use this information to tell whether the
8096 statement is the last piece of code.
8098 (Break): Flag that we break.
8100 * codegen.cs (EmitContexts): New `Breaks' state variable.
8102 2002-07-03 Martin Baulig <martin@gnome.org>
8104 * class.cs (TypeContainer.MethodModifiersValid): Allow override
8105 modifiers in method declarations in structs. Otherwise, you won't
8106 be able to override things like Object.Equals().
8108 2002-07-02 Miguel de Icaza <miguel@ximian.com>
8110 * class.cs (Method, Property, Indexer): Do not allow the public
8111 modifier to be used in explicit interface implementations.
8113 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
8114 override modifiers in method declarations in structs
8116 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
8118 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
8119 integer or real overflow, report an error
8121 2002-07-02 Martin Baulig <martin@gnome.org>
8123 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
8124 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
8125 to tell the runtime about our newly created System.Object and
8126 System.ValueType types.
8128 2002-07-02 Miguel de Icaza <miguel@ximian.com>
8130 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
8131 struct instead of Ldarg/Starg.
8133 2002-07-02 Martin Baulig <martin@gnome.org>
8135 * expression.cs (Indirection.Indirection): Call
8136 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
8138 2002-07-02 Martin Baulig <martin@gnome.org>
8140 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
8141 ValueType, call TypeManager.TypeToCoreType() on it.
8142 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
8143 the OpCodes.Newarr argument.
8145 2002-07-02 Martin Baulig <martin@gnome.org>
8147 * expression.cs (Invocation.EmitCall): When compiling corlib,
8148 replace all calls to the system's System.Array type to calls to
8149 the newly created one.
8151 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
8152 System.Array methods.
8153 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
8154 from the system's System.Array type which must be replaced.
8156 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
8158 * typemanager.cs: load unverifiable_code_ctor so we can build
8159 corlib using the correct type. Avoid using GetTypeCode() with
8161 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
8162 TypeManager.object_type to allow building corlib.
8164 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
8166 * ecore.cs: handle System.Enum separately in LoadFromPtr().
8168 2002-07-01 Martin Baulig <martin@gnome.org>
8170 * class.cs: Make the last change actually work, we need to check
8171 whether `ifaces != null' to avoid a crash.
8173 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
8175 * class.cs: when we build structs without fields that implement
8176 interfaces, we need to add the interfaces separately, since there is
8177 no API to both set the size and add the interfaces at type creation
8180 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
8182 * expression.cs: the dimension arguments to the array constructors
8183 need to be converted if they are a long.
8185 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
8187 * class.cs: don't emit ldarg.0 if there is no parent constructor
8188 (fixes showstopper for corlib).
8190 2002-06-29 Martin Baulig <martin@gnome.org>
8192 MCS now compiles corlib on GNU/Linux :-)
8194 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
8195 ie. check for MethodImplOptions.InternalCall.
8197 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
8198 and TypeManager.attribute_type are null, so we must explicitly check
8199 whether parent is not null to find out whether it's an attribute type.
8200 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
8201 and SetBuilder, not only if the property is neither abstract nor external.
8202 This is necessary to set the MethodImplOptions on the accessor methods.
8203 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
8204 SetBuilder, see Property.Emit().
8206 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
8207 populate "System.Object", "System.ValueType" and "System.Attribute" since
8208 they've already been populated from BootCorlib_PopulateCoreTypes().
8210 2002-06-29 Martin Baulig <martin@gnome.org>
8212 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
8213 is the NullLiteral, we also need to make sure that target_type is not
8216 2002-06-29 Martin Baulig <martin@gnome.org>
8218 * rootcontext.cs (RootContext.ResolveCore): We must initialize
8219 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
8220 before calling BootstrapCorlib_ResolveDelegate ().
8222 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8224 * statement.cs: fixed build-breaker. All tests passed ok.
8226 2002-06-27 Martin Baulig <martin@gnome.org>
8228 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
8229 for System.Decimal when compiling corlib.
8231 2002-06-27 Martin Baulig <martin@gnome.org>
8233 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
8234 switch blocks which contain nothing but a default clause.
8236 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
8238 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
8240 2002-06-27 Martin Baulig <martin@gnome.org>
8242 * ecore.cs (PropertyExpr.PropertyExpr): Call
8243 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
8245 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
8246 is already a TypeBuilder.
8248 2002-06-27 Martin Baulig <martin@gnome.org>
8250 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
8251 `target_type == TypeManager.array_type', not IsAssignableFrom() in
8252 the "from an array-type to System.Array" case. This makes it work
8253 when compiling corlib.
8255 2002-06-27 Martin Baulig <martin@gnome.org>
8257 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
8258 non-static PropertyExpr, set its InstanceExpression. This makes
8259 the `ICollection.Count' property work in System/Array.cs.
8261 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
8263 * driver.cs: Made error handling more consistent. Errors now
8264 tracked by Report class, so many methods which used to return int
8265 now return void. Main() now prints success/failure and
8266 errors/warnings message.
8268 Renamed '--probe' compiler argument to '--expect-error'. Removed
8269 the magic number return values (123 and 124). Now, if the
8270 expected error occurs, the compiler exits with success (exit value
8271 0). If the compilation completes without seeing that particular
8272 error, the compiler exits with failure (exit value 1). The
8273 makefile in mcs/errors has been changed to handle the new behaviour.
8275 * report.cs: Made 'expected error' number a property and renamed
8276 it from 'Probe' to 'ExpectedError'.
8278 * genericparser.cs: Removed error handling support, since it is
8279 now all done by Report class.
8281 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
8282 class, so parse() no longer returns an int.
8284 * namespace.cs: Use Report.Error instead of GenericParser.error
8286 2002-06-22 Miguel de Icaza <miguel@ximian.com>
8288 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
8289 TypeContainer.AddOperator): At the front of the list put the
8290 explicit implementations, so they get resolved/defined first.
8292 2002-06-21 Miguel de Icaza <miguel@ximian.com>
8294 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
8295 interface type is implemented by this TypeContainer. Used during
8296 explicit interface implementation.
8298 (Property.Define, Indexer.Define, Method.Define): Validate that
8299 the given interface in the explicit implementation is one of the
8300 base classes for the containing type.
8302 Also if we are explicitly implementing an interface, but there is
8303 no match in the pending implementation table, report an error.
8305 (Property.Define): Only define the property if we are
8306 not explicitly implementing a property from an interface. Use the
8307 correct name also for those properties (the same CSC uses,
8308 although that is really not needed).
8310 (Property.Emit): Do not emit attributes for explicitly implemented
8311 properties, as there is no TypeBuilder.
8313 (Indexer.Emit): ditto.
8315 Hiding then means that we do not really *implement* a pending
8316 implementation, which makes code fail.
8318 2002-06-22 Martin Baulig <martin@gnome.org>
8320 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
8321 the return value of Object.GetType(). [FIXME: we need to do this whenever
8322 we get a type back from the reflection library].
8324 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
8326 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
8328 2002-06-20 Miguel de Icaza <miguel@ximian.com>
8330 * attribute.cs: Return null if we can not look up the type.
8332 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
8333 the interface types found.
8335 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
8336 interface types found.
8338 * typemanager.cs (GetInterfaces): Make this routine returns alll
8339 the interfaces and work around the lame differences between
8340 System.Type and System.Reflection.Emit.TypeBuilder in the results
8341 result for GetInterfaces.
8343 (ExpandInterfaces): Given an array of interface types, expand and
8344 eliminate repeated ocurrences of an interface. This expands in
8345 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
8348 2002-06-21 Martin Baulig <martin@gnome.org>
8350 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
8353 2002-06-21 Martin Baulig <martin@gnome.org>
8355 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
8356 and called with one of the core types, return the corresponding typebuilder for
8359 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
8362 2002-06-21 Martin Baulig <martin@gnome.org>
8364 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
8365 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
8366 (Expression.ConvertReferenceExplicit): Likewise.
8368 * expression.cs (ElementAccess.DoResolve): Likewise.
8369 (ElementAccess.DoResolveLValue): Likewise.
8371 2002-06-10 Martin Baulig <martin@gnome.org>
8373 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
8374 add the "value" parameter to the parameter list.
8376 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
8379 2002-06-19 Miguel de Icaza <miguel@ximian.com>
8381 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
8382 the argument to an int, uint, long or ulong, per the spec. Also
8383 catch negative constants in array creation.
8385 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
8387 * class.cs: do not allow the same interface to appear twice in
8388 the definition list.
8390 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
8392 * ecore.cs: don't use ldlen with System.Array.
8394 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
8396 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
8398 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
8400 * modifiers.cs: produce correct field attributes for protected
8401 internal. Easy fix so miguel can work on ther harder stuff:-)
8403 2002-06-18 Miguel de Icaza <miguel@ximian.com>
8405 * pending.cs: New file. Move the code from class.cs here.
8406 Support clearning the pending flag for all methods (when not doing
8407 explicit interface implementation).
8409 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
8411 * rootcontext.cs: added a couple more types needed to bootstrap.
8413 2002-06-17 Miguel de Icaza <miguel@ximian.com>
8415 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
8416 constructor in the type, instead of any constructor in the type
8417 hierarchy. Thanks to Paolo for finding this bug (it showed up as
8418 a bug in the Mono runtime when applying the params attribute).
8420 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
8421 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
8423 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
8425 * expression.cs (Unary.ResolveOperator): Use TypeManager
8426 to resolve the type.
8428 2002-06-13 Ravi Pratap <ravi@ximian.com>
8430 * cs-parser.jay (enum_member_declaration): Pass in the attributes
8433 * enum.cs (AddEnumMember): Add support to store the attributes associated
8434 with each member too.
8436 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
8437 field builders too - this takes care of the enum member case.
8439 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
8441 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
8442 address-of operator on both value types and pointers.
8444 2002-06-10 Martin Baulig <martin@gnome.org>
8446 * interface.cs (Interface.PopulateIndexer): Add the indexer's
8447 PropertyBuilder to the `property_builders' list.
8449 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
8450 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
8451 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
8452 find any indexers which are inherited from an interface.
8454 2002-06-09 Martin Baulig <martin@gnome.org>
8456 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
8457 the same type as the constant if necessary. There's also a test-130.cs
8460 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
8462 * typemanager.cs (TypeManager.ChangeType): Previously known as
8463 Enum.ChangeEnumType().
8465 2002-06-09 Martin Baulig <martin@gnome.org>
8467 * expression.cs (Cast.TryReduce): Added support for consts.
8469 2002-06-08 Ravi Pratap <ravi@ximian.com>
8471 * class.cs (Accessor): Hold attributes information so we can pass
8474 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
8475 Modify to pass in attributes attached to the methods.
8477 (add_accessor_declaration, remove_accessor_declaration): Ditto.
8479 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
8480 to handle the Accessor kind :-)
8482 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
8484 2002-06-08 Martin Baulig <martin@gnome.org>
8486 * expression.cs (Unary.TryReduceNegative): Added support for
8489 2002-06-08 Martin Baulig <martin@gnome.org>
8491 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
8492 name can't be found in the `defined_names' - the caller will do a
8493 MemberLookup in this case and thus find methods in System.Enum
8494 such as Enum.IsDefined().
8496 2002-06-08 Martin Baulig <martin@gnome.org>
8498 * enum.cs (Enum.ChangeEnumType): This is a custom version of
8499 Convert.ChangeType() which works with TypeBuilder created types.
8500 (Enum.LookupEnumValue, Enum.Define): Use it here.
8502 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
8503 `TypeBuilder.BaseType != null' check.
8504 (TypeContainer.FindMembers): Only lookup parent members if we
8505 actually have a parent.
8506 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
8507 (ConstructorInitializer.Resolve): Likewise.
8509 * interface.cs (Interface.FindMembers): Added
8510 `TypeBuilder.BaseType != null' check.
8512 * rootcontext.cs (RootContext.ResolveCore): Added
8513 "System.Runtime.CompilerServices.IndexerNameAttribute" to
8514 classes_second_stage.
8516 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
8517 debug_type and trace_type when compiling with --nostdlib.
8519 2002-06-07 Martin Baulig <martin@gnome.org>
8521 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
8522 (AddField): Set it to true when adding a non-static field.
8523 (DefineType): Use `have_nonstatic_fields' to find out whether we
8524 have non-static fields, not `Fields != null'.
8526 2002-06-02 Miguel de Icaza <miguel@ximian.com>
8528 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
8529 dereferencing a null on the static-field code path)
8531 2002-05-30 Martin Baulig <martin@gnome.org>
8533 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
8534 to take command line arguments. Use reflection to call the new
8535 custom `Initialize' function on the symbol writer and pass it the
8536 command line arguments.
8538 * driver.cs (--debug-args): New command line argument to pass command
8539 line arguments to the symbol writer.
8541 2002-05-28 Miguel de Icaza <miguel@ximian.com>
8543 * assign.cs (DoResolve): Forgot to do the implicit conversion to
8544 the target type for indexers and properties. Thanks to Joe for
8547 2002-05-27 Miguel de Icaza <miguel@ximian.com>
8549 * typemanager.cs (MethodFlags): returns the method flags
8550 (Obsolete/ShouldIgnore) that control warning emission and whether
8551 the invocation should be made, or ignored.
8553 * expression.cs (Invocation.Emit): Remove previous hack, we should
8554 not do this on matching a base type, we should do this based on an attribute
8556 Only emit calls to System.Diagnostics.Debug and
8557 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
8558 on the command line.
8560 * rootcontext.cs: Global settings for tracing and debugging.
8562 * cs-tokenizer.cs (define): New utility function to track
8563 defines. Set the global settings for TRACE and DEBUG if found.
8565 2002-05-25 Ravi Pratap <ravi@ximian.com>
8567 * interface.cs (Populate*): Pass in the TypeContainer as well as
8568 the DeclSpace as parameters so that we can create EmitContexts and
8569 then use that to apply attributes etc.
8571 (PopulateMethod, PopulateEvent, PopulateProperty)
8572 (PopulateIndexer): Apply attributes everywhere.
8574 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
8577 (ApplyAttributes): Update accordingly.
8579 We now apply interface attributes for all members too.
8581 2002-05-26 Miguel de Icaza <miguel@ximian.com>
8583 * class.cs (Indexer.Define); Correctly check if we are explicit
8584 implementation (instead of checking the Name for a ".", we
8585 directly look up if the InterfaceType was specified).
8587 Delay the creation of the PropertyBuilder.
8589 Only create the PropertyBuilder if we are not an explicit
8590 interface implementation. This means that explicit interface
8591 implementation members do not participate in regular function
8592 lookups, and hence fixes another major ambiguity problem in
8593 overload resolution (that was the visible effect).
8595 (DefineMethod): Return whether we are doing an interface
8598 * typemanager.cs: Temporary hack until we get attributes in
8599 interfaces (Ravi is working on that) and we get IndexerName
8600 support in interfaces.
8602 * interface.cs: Register the indexers as properties.
8604 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
8605 warning, I have verified that this is a bug in the .NET runtime
8606 (JavaScript suffers of the same problem).
8608 * typemanager.cs (MemberLookup): When looking up members for
8609 interfaces, the parent of an interface is the implicit
8610 System.Object (so we succeed in searches of Object methods in an
8611 interface method invocation. Example: IEnumerable x; x.ToString
8614 2002-05-25 Miguel de Icaza <miguel@ximian.com>
8616 * class.cs (Event): Events should also register if they do
8617 implement the methods that an interface requires.
8619 * typemanager.cs (MemberLookup); use the new GetInterfaces
8622 (GetInterfaces): The code used to lookup interfaces for a type is
8623 used in more than one place, factor it here.
8625 * driver.cs: Track the errors at the bottom of the file, we kept
8628 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
8629 instance if the method we are calling is static!
8631 2002-05-24 Miguel de Icaza <miguel@ximian.com>
8633 * attribute.cs (ApplyAttributes): Make this function filter out
8634 the IndexerName attribute (as that attribute in reality is never
8635 applied) and return the string constant for the IndexerName
8638 * class.cs (TypeContainer.Emit): Validate that all the indexers
8639 have the same IndexerName attribute, and if so, set the
8640 DefaultName attribute on the class.
8642 * typemanager.cs: The return value might contain other stuff (not
8643 only methods). For instance, consider a method with an "Item"
8644 property and an Item method.
8646 * class.cs: If there is a problem with the parameter types,
8649 2002-05-24 Ravi Pratap <ravi@ximian.com>
8651 * ecore.cs (ImplicitConversionExists): Wrapper function which also
8652 looks at user defined conversion after making a call to
8653 StandardConversionExists - we need this for overload resolution.
8655 * expression.cs : Update accordingly the various method calls.
8657 This fixes 2 bugs filed against implicit user defined conversions
8659 2002-05-22 Miguel de Icaza <miguel@ximian.com>
8661 * statement.cs: Track the result of the assignment.
8663 2002-05-21 Miguel de Icaza <miguel@ximian.com>
8665 * expression.cs (MemberAccess): Improved error reporting for
8666 inaccessible members.
8668 2002-05-22 Martin Baulig <martin@gnome.org>
8670 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
8671 itself with debugging support.
8673 2002-05-22 Martin Baulig <martin@gnome.org>
8675 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
8676 Removed, this isn't needed anymore.
8678 2002-05-20 Martin Baulig <martin@gnome.org>
8680 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
8681 be underlying type for an enum.
8683 2002-05-20 Miguel de Icaza <miguel@ximian.com>
8685 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
8686 that splits out the loading of just the core types.
8688 * rootcontext.cs (ResolveCore): Split the struct resolution in
8689 two, so we can load the enumeration underlying types before any
8692 * expression.cs (Is): Bandaid until we fix properly Switch (see
8693 bug #24985 for details).
8695 * typemanager.cs (ImplementsInterface): The hashtable will contain
8696 a null if there are no interfaces implemented.
8698 2002-05-18 Miguel de Icaza <miguel@ximian.com>
8700 * cs-parser.jay (indexer_declarator): It is fine to have array
8703 2002-05-17 Miguel de Icaza <miguel@ximian.com>
8705 * typemanager.cs: (RegisterBuilder): New function used to register
8706 TypeBuilders that implement interfaces. Since
8707 TypeBuilder.GetInterfaces (as usual) does not work with lame
8709 (AddUserType): register interfaces.
8711 (ImplementsInterface): Use the builder_to_ifaces hash if we are
8712 dealing with TypeBuilder. Also, arrays are showing up as
8713 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
8714 methods can not be invoked on them!
8716 * ecore.cs (ExplicitReferenceConversionExists): Made public.
8717 (ImplicitReferenceConversionExists): Split out from
8718 StandardConversionExists.
8720 * expression.cs (As): We were only implementing one of the three
8721 cases for the as operator. We now implement them all.
8722 (Is): Implement the various other cases for Is as well.
8724 * typemanager.cs (CACHE): New define used to control if we want or
8725 not the FindMembers cache. Seems to have a negative impact on
8726 performance currently
8728 (MemberLookup): Nested types have full acess to
8729 enclosing type members
8731 Remove code that coped with instance/static returns for events, we
8732 now catch this in RealFindMembers.
8734 (RealFindMembers): only perform static lookup if the instance
8735 lookup did not return a type or an event.
8737 2002-05-17 Miguel de Icaza <miguel@ximian.com>
8739 * assign.cs (CompoundAssign): We pass more semantic information
8740 now to Compound Assignments than we did before: now we have all
8741 the information at hand, and now we resolve the target *before* we
8742 do the expression expansion, which allows the "CacheValue" method
8743 to have the effect we intended (before, a [x] += 1 would generate
8744 two differen ArrayAccess expressions from the ElementAccess,
8745 during the resolution process).
8747 (CompoundAssign.DoResolve): Resolve target and original_source here.
8749 2002-05-16 Miguel de Icaza <miguel@ximian.com>
8751 * expression.cs (ArrayAccess): dropped debugging information.
8753 * typemanager.cs: Small bug fix: I was always returning i_members,
8754 instead of one of i_members or s_members (depending on which had
8757 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
8758 method is invoked before any code generation takes place, and it
8759 is a mechanism to inform that the expression will be invoked more
8760 than once, and that the method should use temporary values to
8761 avoid having side effects
8763 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
8765 * ecore.cs (Expression.CacheTemporaries): Provide empty default
8768 * expression.cs (Indirection, ArrayAccess): Add support for
8769 CacheTemporaries in these two bad boys.
8771 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
8773 (StoreFromPtr): Handle stobj as well.
8775 * expression.cs (UnaryMutator): Share more code.
8777 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
8778 down: I was not tracking the Filter function as well, which
8779 was affecting the results of the cache.
8781 2002-05-15 Miguel de Icaza <miguel@ximian.com>
8783 * attribute.cs: Remove the hack to handle the CharSet property on
8786 2002-05-14 Miguel de Icaza <miguel@ximian.com>
8788 * attribute.cs (DoResolve): More uglyness, we now only try to
8789 resolve the attribute partially, to extract the CharSet
8790 information (only if we are a StructLayout attribute). Otherwise
8792 (GetExtraTypeInfo): Add some code to conditionally kill in the
8793 future this. I am more and more convinced that the .NET
8794 framework has special code to handle the attribute setting on
8797 * expression.cs (IsParamsMethodApplicable): Revert my previous
8798 foreach change here, it was wrong.
8800 2002-05-13 Miguel de Icaza <miguel@ximian.com>
8802 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
8803 (pp_expr): do not abort on unknown input, just return.
8804 (eval): abort if there are pending chars.
8806 * attribute.cs (Attribute.Resolve): Positional parameters are
8807 optional. Deal with that case.
8809 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
8810 the Ansi/Unicode/Auto information for the type.
8812 (TypeContainer.DefineType): instantiate the EmitContext here, as
8813 we will be using it during the type definition (to resolve
8814 attributes) and during the emit phase.
8816 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
8817 to pull type information out of the attributes
8819 (Attribute.Resolve): track the constructor builder, and allow for
8820 multiple invocations (structs and classes will use this).
8822 * ecore.cs (MemberLookupFinal): new version with all the
8823 parameters customizable.
8825 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
8826 constructors. Return if the result value is null (as the error
8827 would have been flagged already by MemberLookupFinal)
8829 Do not allow instances of abstract classes or interfaces to be
8832 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
8833 We have to compare the assembly property here when dealing with
8834 FamANDAssem and Assembly access modifiers, because we might be
8835 creating an assembly from *modules* (that means that we are not
8836 getting TypeBuilders for types defined in other modules that are
8837 part of this assembly).
8839 (Method.Emit): If the method is marked abstract and has a body,
8842 (TypeContainer.DefineMembers): If both the defined member and the
8843 parent name match are methods, then do not emit any warnings: let
8844 the Method.Define routine take care of flagging warnings. But if
8845 there is a mismatch (method overrides something else, or method is
8846 overriwritten by something, then emit warning).
8848 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
8849 set to null, this means `do not check for the return type on the
8852 (Method.Define): set the return type for the method signature to
8853 null, so that we get methods with the same name and parameters and
8854 different return types. This is used to flag warning 114 (you are
8855 hiding a method, and you probably want to use the new/override
8858 * typemanager.cs (MemberLookup): Implemented proper access
8859 control, closing a long standing set of bug reports. The problem
8860 was that the Framework only has two bits: Public and NonPublic,
8861 and NonPublic includes private and protected methods, but we need
8862 to enforce the FamANDAssem, FamOrAssem and Family.
8864 2002-05-11 Miguel de Icaza <miguel@ximian.com>
8866 * statement.cs (GotoCase): Return true: Ammounts to giving up
8867 knowledge on whether we return or not, and letting the other case
8868 be responsible for it.
8870 2002-05-10 Miguel de Icaza <miguel@ximian.com>
8872 * driver.cs: Do not load directories for each file processed, only
8873 do it if there is a pattern.
8875 * ecore.cs: Report readonly assigns here as well, as we might have
8876 been resolved only by MemberAccess.
8878 (SimpleName.SimpleNameResolve): Also be useful for LValue
8879 resolution. We need this to propagate assign to local readonly variables
8881 * typemanager.cs: Use a ptrhashtable for the criteria, because we
8882 do not want to reuse potential criteria memory.
8884 * class.cs (MyEventBuilder): Set reflected_type;
8886 * ecore.cs (Constantify): Added support for constifying bools.
8888 (RootContext.LookupType): Added a cache for values looked up in
8889 the declaration space.
8891 * typemanager.cs (FindMembers): Now is a front-end to
8892 RealFindMembers, and provides a two-level hashtable-based cache to
8895 15% performance improvement: from 22.5 to 19.2 seconds.
8897 * expression.cs (IsParamsMethodApplicable): use foreach.
8898 (Invocation.DoResolve): ditto.
8899 (New.DoResolve): ditto.
8900 (ArrayCreation.DoResolve): ditto.
8902 * ecore.cs (FindMostEncompassingType): use foreach.
8904 * delegate.cs (NewDelegate.DoResolve): Use foreach
8906 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
8907 (RemoveMethods): use foreach.
8909 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
8910 nested foreach statements instead of for, and also break out of
8911 the inner loop once a match is found.
8913 (Invocation.OverloadResolve): Use foreach, simplify the code.
8915 2002-05-08 Miguel de Icaza <miguel@ximian.com>
8917 * cfold.cs (BinaryFold): During an enumeration evaluation context,
8918 we actually unwrap the expression to allow for extra information
8921 * expression.cs: Use Shr_Un on unsigned operations.
8923 2002-05-08 Ravi Pratap <ravi@ximian.com>
8925 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
8926 applicable operators was not being considered correctly. This closes
8927 the bug Miguel reported.
8929 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
8931 * attribute.cs: check that the type derives from System.Attribute
8932 and report the correct error in that case (moved the duplicate code to
8933 its own method, too).
8935 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
8937 * attribute.cs: lookup attribute type name as the spec says: first the
8938 bare attribute name and then name + "Attribute" (nant compiles with
8939 mcs after this fix).
8941 2002-05-07 Miguel de Icaza <miguel@ximian.com>
8943 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
8944 Because of the way we parse things, we should try to see if a
8945 UIntConstant can fit in an integer.
8947 2002-05-07 Ravi Pratap <ravi@ximian.com>
8949 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
8950 when we are in an explicit context.
8952 (ConvertReferenceExplicit): When converting from Iface type S to Class
8953 T make sure the rules are implemented as an OR.
8955 * parameter.cs (ParameterType): Make it a property for now although the
8956 purpose really isn't anything immediate.
8958 * expression.cs (Is*Applicable): Do better checking on the parameter type
8959 of a ref/out parameter. The ones from the system assemblies are already
8960 marked with the correct type so we don't need to do any correction.
8962 * ecore.cs (StandardConversionExists): Conversion from Interface types to
8963 the object type is standard too so include that.
8965 2002-05-06 Miguel de Icaza <miguel@ximian.com>
8967 * ecore.cs (StandardConversionExists): Augment with missing code:
8968 deal with IntConstant, LongConstants and Enumerations.
8970 * assign.cs: Report the error, instead of failing silently
8972 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
8973 typecontainer that they are declared, because the
8974 typecontainer/namespace will have the list of using clauses that
8977 Assembly Attributes were escaping the normal registration
8980 (EmitCode): Apply attributes within an EmitContext that represents
8981 the container they were declared on.
8983 * cs-parser.jay: Track bases for structs. How did I get this wrong?
8985 2002-05-06 Ravi Pratap <ravi@ximian.com>
8987 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
8988 Revamp completely - make much cleaner as we now operate only
8991 (FindMostSpecificSource, FindMostSpecificTarget): New methods
8992 to implement the logic detailed in the spec more correctly.
8994 (UserDefinedConversion): Update accordingly.
8996 2002-05-06 Miguel de Icaza <miguel@ximian.com>
8998 * statement.cs: Return flow analysis information up.
9000 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
9003 (token): Do not consume an extra character before calling
9006 2002-05-06 Piers Haken <piersh@friskit.com>
9008 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
9010 2002-05-06 Miguel de Icaza <miguel@ximian.com>
9012 * class.cs (Constructor.Emit): Set the IsStatic flag in the
9013 EmitContext during the instance constructor initializer
9014 resolution, to stop access to instance variables.
9016 This is mandated by the spec, last paragraph of the `constructor
9017 initializers' section.
9019 2002-05-05 Miguel de Icaza <miguel@ximian.com>
9021 * cs-parser.jay, class.cs (Accessor): new class used to represent
9022 an accessor (get or set). In the past we used `null' to represent
9023 a missing accessor. But this is ambiguous because there was no
9024 way to tell in abstract indexers/properties if one of them was
9027 Now there is a way of addressing that.
9029 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
9030 instead of FindMembers.
9032 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
9033 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
9035 * attribute.cs: Treat indexers and properties as the same in terms
9036 of applying attributes
9038 * ecore.cs (FindMostEncompassedType): Use statically initialized
9039 EmptyExpressions()s like we do elsewhere to avoid creating useless
9040 objects (and we take this out of the tight loop).
9042 (GetConversionOperators): Move the code to extract the actual
9043 operators to a separate routine to clean things up.
9045 2002-05-04 Miguel de Icaza <miguel@ximian.com>
9047 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
9048 events are always registered FieldBuilders.
9050 * class.cs (FieldBase): New class shared by Fields
9052 * delegate.cs: If we are a toplevel delegate, use our full name.
9053 If we are a nested delegate, then only use our tail name.
9055 2002-05-02 Ravi Pratap <ravi@ximian.com>
9057 * expression.cs (IsApplicable): Ensure that we add the "&" to
9058 ref/out types before comparing it with the type of the argument.
9060 (IsParamsMethodApplicable): Ditto.
9062 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
9065 * delegate.cs : Handle the case when we have more than one applicable
9066 method. Flag an error only when we finish checking all.
9068 2002-05-02 Miguel de Icaza <miguel@ximian.com>
9070 * expression.cs: Add support for boolean static initializers.
9072 2002-05-01 Miguel de Icaza <miguel@ximian.com>
9074 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
9076 * parameter.cs (ComputeParameterTypes,
9077 ComputeAndDefineParameterTypes): Better error handling: now we
9078 clear the `types' cache if we fail during any of the type lookups.
9079 We also return the status code correctly to our caller
9081 * delegate.cs: If we fail to define a delegate, abort the extra
9084 * expression.cs (Binary.ResolveOperator): for
9085 operator==(object,object) and operator !=(object, object) we also
9086 have to verify that there is an implicit conversion from one to
9089 (ArrayAccess.DoResolve): Array Access can operate on
9092 2002-04-30 Miguel de Icaza <miguel@ximian.com>
9094 * assign.cs (CompoundAssign): A new class used as a "flag" that
9095 the assignment actually is happening as part of a compound
9096 assignment operator.
9098 During compound assignment, a few new rules exist to enable things
9105 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
9106 to the type of x) if y is implicitly convertible to the type of x,
9107 and the operator is a builtin operator and the return type of the
9108 operator is explicitly convertible to the type of x.
9110 * rootcontext.cs: Reset warning level to 2. 4 catches various
9111 "interesting" features in mcs, we must clean this up at some
9112 point, but currently am trying to kill other bugs ;-)
9114 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
9115 in container classes as well.
9117 * expression.cs (Binary.ResolveOperator): Handle string case
9118 before anything else (as operator overloading does emit an error
9119 before doing anything else).
9121 This code could go away when we move to a table driven model, but
9122 i could not come up with a good plan last night.
9124 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
9126 * typemanager.cs (CSharpName): reimplementation using regex.
9127 * class.cs: added null check for fields in Emit
9128 * rootcontext.cs: set warninglevel to 4
9130 2002-04-29 Miguel de Icaza <miguel@ximian.com>
9132 * typemanager.cs (CSharpName): reimplemented with Lupus
9135 2002-04-28 Miguel de Icaza <miguel@ximian.com>
9137 * statement.cs (If): correclty implement Resolve, because we were
9138 not catching sem errors in there. The same process is needed
9140 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
9143 (Statement.Warning_DeadCodeFound): Factorize code.
9144 (While): Report dead code here too.
9146 (Statement): Added Resolve virtual method to allow
9147 for resolution split from the emit code.
9149 2002-04-26 Miguel de Icaza <miguel@ximian.com>
9151 * statement.cs (EmitBoolExpression): No longer try to resolve the
9153 (MakeBoolean): New utility function that resolve, implicitly
9154 converts to boolean and tags the expression.
9157 (If, Do): Implement dead code elimination.
9158 (While): Implement loop inversion
9160 (Do, While, For, If): Resolve the expression prior to calling our
9163 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
9166 - added method Report28 (warning: program has more than one entry point)
9167 - added method IsEntryPoint, implements paragraph 10.1 of the spec
9168 - modified method Method.Define, the part at the end of the method
9170 * rootcontext.cs: added static public Location EntryPointLocation;
9172 * ../errors/cs0028.cs : Add test case for the above warning.
9175 - modified method CSharpName to allow arrays of primitive type to
9176 be printed nicely (e.g. instead of System.Int32[][] it now prints
9178 - added method CSharpSignature: returns the signature of a method
9179 in string format to be used in reporting errors, warnings, etc.
9181 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
9184 2002-04-26 Ravi Pratap <ravi@ximian.com>
9186 * delegate.cs (Define): Fix extremely silly bug where I was
9187 setting the type of the 'object' parameter of the BeginInvoke
9188 method to System.IAsyncResult instead of System.Object ;-)
9190 2002-04-26 Miguel de Icaza <miguel@ximian.com>
9192 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
9195 (Constructor.Emit): return if we fail to initialize the
9196 constructor. Another door closed!
9198 * expression.cs (New.DoResolve): Improve error message (from -6 to
9199 1501). Use DeclaredOnly lookup to find the exact constructor.
9201 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
9202 loop. This is useful.
9204 * cs-parser.jay: Adjust the default parameters so that destructors
9205 have the proper signature.
9207 2002-04-26 Martin Baulig <martin@gnome.org>
9209 * driver.cs (LoadAssembly): If `assembly' contains any characters
9210 which are only valid in path names and not in assembly names
9211 (currently slash, backslash and point), use Assembly.LoadFrom ()
9212 instead of Assembly.Load () on the `assembly' (before iteration
9213 over the link_paths).
9215 2002-04-26 Martin Baulig <martin@gnome.org>
9217 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
9219 2002-04-25 Miguel de Icaza <miguel@ximian.com>
9221 * class.cs (Property): use the new typemanager.MemberLookup
9223 (TypeContainer.MemberLookup): Implement using the
9224 TypeManager.MemberLookup now.
9226 * typemanager.cs: Make MemberLookup a function of the TypeManager,
9227 and return MemberInfos, so that these can be used without an
9228 EmitContext (what we had before).
9230 2002-04-24 Miguel de Icaza <miguel@ximian.com>
9232 * expression.cs: Fix the case where the argument to params if the
9233 type of the params. I omitted handling this before. Fixed
9235 2002-04-22 Miguel de Icaza <miguel@ximian.com>
9237 * driver.cs: Call BootCorlib_PopulateCoreType
9239 * class.cs (Property.CheckBase): Check for properties only, not
9242 * interface.cs: Temporary hack: try/catch around the
9243 CustomAttributeBuilder, because I am getting an exception that I
9246 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
9247 types whose definitions are required to be there (attributes are
9248 defined before standard types).
9250 Compute definitions as we boot the various types, as they are used
9251 immediately (value_type class will need object_type, but if we do
9252 not initialize object_type, we will pass a null, which will let
9253 the runtime pick the System.Object from the existing corlib, which
9254 is not what we want).
9256 2002-04-22 Patrik Torstensson <totte@labs2.com>
9258 * cs-tokenizer.cs: fixed a number of trim() issues.
9260 2002-04-22 Ravi Pratap <ravi@ximian.com>
9262 * expression.cs (Argument.Type): Ensure that we return the correct
9263 type when we have out or ref parameters [in which case we
9266 2002-04-22 Miguel de Icaza <miguel@ximian.com>
9268 * class.cs (Property, Indexer): Allow extern modifier in there.
9270 * typemanager.cs (InitBaseTypes): Initializes object_type and
9271 value_type, since those will be used early on during the bootstrap
9272 process to compile corlib.
9274 (InitCoreTypes): Move code from here to InitBaseTypes.
9276 2002-04-21 Miguel de Icaza <miguel@ximian.com>
9278 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
9279 single-dimension arrays as using the ldlen opcode.
9281 Daniel Lewis discovered this optimization.
9283 * typemanager.cs: Add signature for System.Array::get_Length
9285 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9287 * statement.cs: report the error when the foreach does not apply to an
9288 array nor a collection.
9290 2002-04-19 Miguel de Icaza <miguel@ximian.com>
9292 * expression.cs: Add implicit conversions to the operator ~.
9294 * constant.cs (DecimalConstant.Emit): Emit decimal value.
9296 * typemanager.cs: Locate the decimal constructor.
9298 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9300 * attribute.cs: use the new property of TypeOf.
9301 * expression.cs: added 'get' property around typearg.
9303 These changes fix a build breaker reported by NickD. Is this the
9304 correct way to fix? If not, please, revert my changes and make it
9307 2002-04-17 Miguel de Icaza <miguel@ximian.com>
9309 * attribute.cs: Add support for typeof in attribute invocations.
9310 I am not sure that this is right though.
9312 2002-04-14 Duncan Mak <duncan@ximian.com>
9314 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
9315 Binary.Operator.Division case.
9317 2002-04-13 Ravi Pratap <ravi@ximian.com>
9319 * class.cs (DefineType): Ensure that we do a proper check on
9320 attribute types and also register it with the TypeManager.
9322 (TypeContainer.Targets): The default for attribute types is
9323 AttributeTargets.All.
9325 * attribute.cs (ApplyAttributes): Registering the attribute type
9326 is done elsewhere, not when we discover we have a Usage attribute.
9328 2002-04-12 Ravi Pratap <ravi@ximian.com>
9330 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
9331 and get rid of is_delegate parameter.
9333 * everywhere : update.
9335 2002-04-12 Ravi Pratap <ravi@ximian.com>
9337 * cs-parser.jay (compilation_unit): Revamp completely to use
9338 some new ideas that I got from Rhys' grammar to solve the problems
9339 with assembly level attributes.
9341 (outer_declaration): New grammar production.
9343 (attribute_sections): Add.
9345 (opt_attributes): Base on attribute_sections
9347 (namespace_declaration): Allow opt_attributes to tackle the case
9348 when we have assembly level attributes - we are clever in this
9351 * attribute.cs (ApplyAttributes): Do not worry about assembly
9352 attributes in the non-global context.
9354 * rootcontext.cs (AddGlobalAttributes): Go back to using this
9355 instead of SetGlobalAttributes.
9357 * class.cs, rootcontext.cs : Ensure we define and generate
9358 attribute types before anything else.
9360 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
9361 and flag the new error -20 for the case when the attribute type
9362 does not have valid targets specified. csc does not catch this.
9364 * ../errors/errors.txt : update for error # -20
9366 2002-04-11 Ravi Pratap <ravi@ximian.com>
9368 * support.cs (InternalParameters.ParameterModifier): Do some null
9369 checking and return sane values.
9371 * class.cs (Method.Define): If we are a PInvoke method, ensure
9372 that we are static and extern. Report error # 601
9374 * ../errors/cs0601.cs : Add test case for the above error.
9376 2002-04-07 Ravi Pratap <ravi@ximian.com>
9378 * rootcontext.cs (attribute_types): We need to keep type of
9379 all attribute types separately and emit code for them first.
9381 (RegisterAttribute) : Implement.
9383 * class.cs (DefineType): Check if the current Type is a custom
9384 attribute type and register it accordingly.
9386 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
9387 adding the first attribute twice and rename to
9389 (SetGlobalAttributes): this.
9391 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
9394 * attribute.cs (ApplyAttributes): Take an additional argument telling us
9395 if we are processing global arguments. Hmm, I am unsure of this.
9397 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9399 * expression.cs: added static array of strings to avoid calling
9400 Enum.ToString () for Operator in Binary. Significant recover of
9403 2002-04-10 Miguel de Icaza <miguel@ximian.com>
9405 * class.cs (FindMembers): Allow the Builders of the various
9406 members to be null. If they are skip them. This only happens
9407 during the PInvoke declaration.
9409 2002-04-09 Miguel de Icaza <miguel@ximian.com>
9411 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
9412 failure, so we do not keep going afterwards.
9414 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
9415 wanted to pass `false' as the `is_delegate' argument. If this is
9416 the case, why not use delegate_type == null to mean `is_delegate =
9417 false' and anything else as is_delegate = true.
9419 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
9421 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
9422 code for the section, not the beginning of the tests.
9424 2002-04-08 Miguel de Icaza <miguel@ximian.com>
9426 * cfold.cs: Handle operator + (Enum x, Underlying x)
9428 * expression.cs (Binary): same. Warn about errors where we have
9429 Enum/Enum in operator + as well.
9431 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
9434 - added support for switch(bool)
9435 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
9436 - add TableSwitchEmit() to handle table-based switch statements
9438 2002-04-05 Ravi Pratap <ravi@ximian.com>
9440 * expression.cs (Invocation.OverloadResolve): Factor out code which
9441 does parameter compatibility checking with arguments so that we can
9442 re-use the code even from Delegate.VerifyApplicability
9444 (VerifyArgumentsCompat): Move above code here.
9446 * delegate.cs (VerifyApplicability): Get rid of duplicate code
9447 and instead make a call to the above method.
9449 2002-03-31 Ravi Pratap <ravi@ximian.com>
9451 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
9452 We use it to keep track of classes which are attribute types.
9454 2002-04-02 Miguel de Icaza <miguel@ximian.com>
9456 * delegate.cs (Delegate.Define): Correctly define the types in the
9457 presence of fixed and array parameters.
9459 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
9462 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
9463 include NonPublic after the first iteration.
9465 * class.cs (Indexer.CheckBase): Only check if both parents are
9468 * cs-parser.jay (accessor_body): If empty, set to null.
9470 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
9471 same code path here to resolve constants names that we did have in
9472 MemberAccess.DoResolve. There is too much code duplicated here.
9474 2002-04-01 Miguel de Icaza <miguel@ximian.com>
9476 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
9478 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
9481 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
9482 tokens, numbers and strings.
9484 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
9487 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
9488 asyncronous parameters and the regular parameters.
9490 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
9491 specify the target directory.
9493 * expression.cs: (This.DoResolve): Simplify
9494 (As.Emit): Optimize, do not generate IsInst if the expression is
9495 always of the given type.
9497 (Is.DoResolve): Bug fix, we were reporting both always/never for
9500 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
9501 creating too many unnecessary arrays.
9503 2002-03-31 Miguel de Icaza <miguel@ximian.com>
9505 * class.cs (EmitFieldInitializer): Use Assign expression to assign
9506 fields instead of rolling our own initializer. Takes care of all
9507 implicit conversions, and drops unnecessary static checks/argument.
9509 2002-03-31 Dick Porter <dick@ximian.com>
9511 * driver.cs: use the GetDirectories() return values properly, and
9512 use "/" as path separator.
9514 2002-03-30 Miguel de Icaza <miguel@ximian.com>
9516 * expression.cs (Unary): Optimize - - expr into expr.
9517 (Binary): Optimize a + (-b) into a -b.
9519 * codegen.cs (CodeGen): Made all methods static.
9521 2002-03-29 Miguel de Icaza <miguel@ximian.com>
9525 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
9526 TypeBuilder property.
9528 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
9531 * tree.cs: Removed the various RecordXXXX, and replaced with a
9532 single RecordDecl. Removed all the accessor methods, and just
9533 left a single access point Type
9535 * enum.cs: Rename DefineEnum to DefineType.
9537 * decl.cs: New abstract method `DefineType' used to unify the
9538 Defines for Enumerations, Interfaces, TypeContainers and
9541 (FindType): Moved LookupInterfaceOrClass here. Moved the
9542 LookupBaseClasses method that used to live in class.cs and
9543 interface.cs here, and renamed to FindType.
9545 * delegate.cs: Implement DefineType. Take advantage of the
9546 refactored pattern for locating the parent builder without taking
9547 the parent_builder argument (which we know does not work if we are
9548 nested, and triggering a toplevel definition).
9550 2002-03-28 Miguel de Icaza <miguel@ximian.com>
9552 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
9553 accessibility of a member has changed during override and report
9556 * class.cs (Method.Define, Property.Define): Only complain on
9557 overrides if the method is private, any other accessibility is
9558 fine (and since we just checked the permission is the same, we are
9561 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
9562 and elif are processed always. The other pre-processing
9563 directives are only processed if we are "taking" the path
9565 2002-03-29 Martin Baulig <martin@gnome.org>
9567 * class.cs (Method.Emit): Only emit symbolic debugging info if the
9568 current location is not Null.
9570 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
9571 a separate method so we can profile it.
9573 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
9574 `span.Seconds' are just seconds, but no minutes or hours.
9575 (MainDriver): Profile the CodeGen.SaveSymbols calls.
9577 2002-03-28 Miguel de Icaza <miguel@ximian.com>
9579 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
9580 Remove the gratuitous set of Final:
9582 // If an interface implementation, then we can set Final.
9583 if (((flags & MethodAttributes.Abstract) == 0) &&
9584 implementing.DeclaringType.IsInterface)
9585 flags |= MethodAttributes.Final;
9587 I do not know what I was smoking when I used that.
9590 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
9591 step into fixing the name resolution issues for delegates and
9592 unifying the toplevel name resolution.
9594 2002-03-28 Martin Baulig <martin@gnome.org>
9596 * class.cs (Method.Emit): If we have a symbol writer, call its
9597 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
9598 tell it about the current method.
9600 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
9601 writer that we're going to emit the first byte of IL code for a new
9602 statement (a new source line).
9603 (EmitContext.EmitTopBlock): If we have a symbol writer, call
9604 EmitContext.Mark() before emitting any code.
9606 * location.cs (SymbolDocument): Return null when we're Null.
9608 * statement.cs (Statement): Moved the `Location loc' variable here.
9609 (Statement.EmitBoolExpression): If we have a symbol writer, call
9610 ec.Mark() before emitting any code to tell it that we're at the
9611 beginning of a new statement.
9612 (StatementExpression): Added `Location' argument to the constructor.
9613 (Block): Added public readonly variable `StartLocation' and public
9614 variable `EndLocation'. The latter is to be set using SetEndLocation().
9615 (Block): Added constructor which takes a start and end location.
9616 (Block.SetEndLocation): New method. This sets the end location.
9617 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
9618 local variables we create.
9619 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
9620 each statement and do also mark the begin and end of the block.
9622 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
9623 tell it the current lexer.Location, use Location.Null for the end of the
9625 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
9626 current block, set its end location using SetEndLocation().
9627 (statement_expression): StatementExpression constructor now takes the
9628 lexer.Location as additional argument.
9629 (for_statement, declare_local_variables): Likewise.
9630 (declare_local_variables): When creating a new implicit block, use the
9631 new Block constructor and pass it the lexer.Location.
9633 2002-03-28 Miguel de Icaza <miguel@ximian.com>
9635 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
9636 members also on the parent interfaces recursively.
9638 2002-03-27 Miguel de Icaza <miguel@ximian.com>
9640 * report.cs: Use new formats, since Gonzalo finished the missing
9643 * expression.cs (Binary.ResolveOperator): added missing operator|
9644 operator& and operator^ for bool/bool.
9646 * cs-parser.jay: CheckDef now takes a Location argument that is
9647 used to report errors more precisly (instead of reporting the end
9648 of a definition, we try to track something which is a lot closer
9649 to the source of the problem).
9651 * cs-tokenizer.cs: Track global token use, so we can properly flag
9652 the use of #define/#undef after the first token has been seen.
9654 Also, rename the reportXXXX to Error_DescriptiveName
9656 * decl.cs (DeclSpace.IsTopLevel): Move property here from
9657 TypeContainer, so that Enum and Interface can use this too.
9659 * class.cs (TypeContainer.LookupInterfaceOrClass,
9660 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
9661 `builder' argument. Typically this was used to pass the parent
9662 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
9665 The problem is that a nested class could trigger the definition of
9666 a toplevel class, and the builder would be obviously wrong in that
9669 So we drop this argument, and we compute dynamically the
9670 TypeBuilder/ModuleBuilder (the correct information was available
9671 to us anyways from DeclSpace.Parent)
9673 * interface.cs (Interface.DefineInterface): Drop builder
9674 parameter cleanup like class.cs
9676 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
9679 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
9682 (Try.Emit): Propagate the returns value from the statement.
9684 (Return.Emit): Even if we are leavning
9686 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
9688 * modifiers.cs: Fix the computation of MethodAttributes flags.
9690 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
9692 * driver.cs: allow compilation of files that start with '/'.
9693 Add a default case when checking the argument of --target.
9695 2002-03-25 Miguel de Icaza <miguel@ximian.com>
9697 * interface.cs: Implement the same search algorithm for types in
9700 * delegate.cs: Do not allow multiple definition.
9702 * Recovered ChangeLog that got accidentally amputated
9704 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
9706 * rootcontext.cs: Load manually enum to allow core classes to
9707 contain enumerations.
9709 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
9710 Update to new static methods in TypeManager.
9712 * typemanager.cs (GetMethod, GetConstructor): Use our
9713 implementation of FindMembers to find the members, since during
9714 corlib compilation, the types are TypeBuilders and GetMethod and
9715 GetConstructor do not work.
9717 Make all methods in TypeManager static.
9719 (InitCodeHelpers): Split the functionality from
9720 the InitCodeTypes function.
9722 * driver.cs: Call InitCodeHelpers after we have populated the
9725 * cs-parser.jay (delegate_declaration): we did not used to compute
9726 the delegate name correctly for void delegates.
9728 2002-03-24 Miguel de Icaza <miguel@ximian.com>
9730 * rootcontext.cs (RootContext): Init the interface_resolve_order
9731 and type_container_resolve_order always.
9733 (ResolveCore, BootstrapCorlib_ResolveClass,
9734 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
9735 compiler when compiling with --nostdlib
9737 * class.cs (TypeContainer.DefineType): Check that our parent is
9738 not null. This test is most important when we are bootstraping
9741 * codegen.cs: Split out the symbol writing code.
9743 2002-03-25 Martin Baulig <martin@gnome.org>
9745 * driver.cs (-g): Made -g an alias for --debug.
9747 2002-03-24 Martin Baulig <martin@gnome.org>
9749 * codegen.cs (SymbolWriter): New public variable. Returns the
9750 current symbol writer.
9751 (CodeGen): Added `bool want_debugging_support' argument to the
9752 constructor. If true, tell the ModuleBuild that we want debugging
9753 support and ask it for the ISymbolWriter.
9754 (Save): If we have a symbol writer, call it's Close() method after
9755 saving the assembly.
9757 * driver.c (--debug): New command line argument to create a
9758 debugger information file.
9760 * location.cs (SymbolDocument): New public property. Returns an
9761 ISymbolDocumentWriter object for the current source file or null
9762 if we don't have a symbol writer.
9764 2002-03-21 Miguel de Icaza <miguel@ximian.com>
9766 * driver.cs (LoadAssembly): Correctly return when all the paths
9767 have been tried and not before.
9769 * statement.cs (Switch.Emit): return the actual coverage for this
9770 statement (returns/not-returns)
9772 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
9773 switch of the statement if we are the last switch section. That
9774 kills two problems: try/catch problems (we used to emit an empty
9775 nop at the end) and switch statements where all branches would
9778 2002-03-19 Miguel de Icaza <miguel@ximian.com>
9780 * driver.cs: Add default assemblies (the equivalent to the
9781 Microsoft CSC.RSP file)
9783 * cs-tokenizer.cs: When updating `cols and setting it to zero,
9784 also update tokens_seen and set it to false.
9786 * driver.cs: Implement --recurse for Mike.
9788 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
9789 correctly splitting out the paths.
9791 2002-03-18 Miguel de Icaza <miguel@ximian.com>
9793 * interface.cs (Interface.PopulateProperty): Instead of using
9794 `parent' as the declaration space for the set parameters, use
9797 * support.cs (InternalParameters): InternalParameters constructor
9798 takes a DeclSpace instead of a TypeContainer.
9800 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
9801 types are being initialized, load the address of it before calling
9804 (New): Provide a mechanism to disable the generation of local
9805 value type temporaries when the caller will be providing us with
9806 an address to store it.
9808 (ArrayCreation.EmitDynamicInitializers): Use it.
9810 2002-03-17 Miguel de Icaza <miguel@ximian.com>
9812 * expression.cs (Invocation.EmitArguments): Only probe for array
9813 property if there is more than one argument. Sorry about that.
9815 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
9818 * class.cs (Method.LabelParameters): Fix incorrect code path that
9819 prevented the `ParamArrayAttribute' from being applied to the
9822 2002-03-16 Miguel de Icaza <miguel@ximian.com>
9824 * support.cs (ReflectionParameters): Correctly compute whether the
9825 last argument is a params array. Fixes the problem with
9828 * typemanager.cs: Make the assemblies array always be non-null
9829 (empty, but non-null)
9831 * tree.cs (RecordDecl): New function that abstracts the recording
9832 of names. This reports error 101, and provides a pointer to the
9833 previous declaration. Fixes a crash in the compiler.
9835 * cs-parser.jay (constructor_declaration): Update to new grammar,
9836 and provide a constructor_body that can be empty.
9838 2002-03-15 Miguel de Icaza <miguel@ximian.com>
9840 * driver.cs: Add support for --resources.
9842 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
9843 Make all types for the various array helper methods be integer.
9845 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
9846 CheckState to ConvCast.
9848 (ConvCast): Now it takes a `checked' state argument, to avoid
9849 depending on the emit context for the conversion, and just using
9850 the resolve time setting.
9852 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
9853 instead of Invocation.EmitArguments. We do not emit the original
9854 arguments, instead we emit those which have been converted to
9855 unsigned int expressions.
9857 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
9859 * codegen.cs: ditto.
9861 * expression.cs (LocalVariableReference): Drop the use of the
9862 Store function that depended on the variable index.
9864 * statement.cs (VariableInfo): Drop the `Idx' property from this
9865 class, as this is not taking into account the indexes for
9866 temporaries tat we generate during the execution, getting the
9869 * class.cs: First emit class initializers, then call the parent
9872 * expression.cs (Binary): Fix opcode emision.
9873 (UnaryMutator.EmitCode): Support checked code generation
9875 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
9876 matches for events for both the Static and Instance scans,
9877 pointing to the same element. Fix that.
9879 2002-03-14 Miguel de Icaza <miguel@ximian.com>
9881 * rootcontext.cs (ResolveTree): Always set the
9882 interface_resolve_order, because nested interfaces will be calling
9885 * class.cs (GetInterfaceOrClass): Track the same resolution
9886 process used by TypeManager.LookupType. This fixes the nested
9887 type lookups in class declarations (separate path from
9890 (TypeContainer.DefineType): Also define nested interfaces.
9891 (TypeContainer.RegisterOrder): New public function used to
9892 register the order in which child interfaces need to be closed.
9894 Nested interfaces need to be closed after their parents have been
9897 * interface.cs (InterfaceAttr): Put all the logic for computing
9898 the interface attribute here.
9900 (DefineInterface): Register our interface order with the
9901 RootContext or with the TypeContainer depending on the case.
9903 2002-03-12 Miguel de Icaza <miguel@ximian.com>
9905 * cs-parser.jay: rework foreach statement to work with the new
9906 changes to the policy on SimpleNames.
9908 * report.cs: support Stacktrace on warnings as well.
9910 * makefile: drop --unsafe and /unsafe from the compile.
9912 2002-03-13 Ravi Pratap <ravi@ximian.com>
9914 * ecore.cs (StandardConversionExists): Modify to take an Expression
9915 as the first parameter. Ensure we do null -> reference type conversion
9918 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
9919 temporary Expression objects.
9921 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
9923 * interface.cs: workaround bug in method overloading resolution
9924 (there is already a bugzilla bug for it).
9926 2002-03-12 Miguel de Icaza <miguel@ximian.com>
9928 We could also solve this problem by having a separate path for
9929 performing type lookups, instead of DoResolve, we could have a
9930 ResolveType entry point, and only participating pieces of the
9931 production (simplename, deref, array) would implement this.
9933 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
9934 signal SimpleName to only resolve type names and not attempt to
9935 resolve anything else.
9937 * expression.cs (Cast): Set the flag.
9939 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
9941 * class.cs: Only report 108 if there is no `new' modifier.
9943 * cs-parser.jay: rework foreach statement to work with the new
9944 changes to the policy on SimpleNames.
9946 * report.cs: support Stacktrace on warnings as well.
9948 * makefile: drop --unsafe and /unsafe from the compile.
9950 2002-03-11 Miguel de Icaza <miguel@ximian.com>
9952 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
9953 lookups here, instead of doing that at parse time. This means
9954 that our grammar will not introduce `LocalVariableReferences' as
9955 expressions at this point. That solves the problem of code like
9963 This is only half the fix. The full fix requires parameters to
9964 also be handled in this way.
9966 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
9967 makes the use more obvious of the DeclSpace. The
9968 ec.TypeContainer.TypeBuilder is now only used to pull the
9971 My theory is that I can get rid of the TypeBuilder completely from
9972 the EmitContext, and have typecasts where it is used (from
9973 DeclSpace to where it matters).
9975 The only pending problem is that the code that implements Aliases
9976 is on TypeContainer, and probably should go in DeclSpace.
9978 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
9979 lookups here, instead of doing that at parse time. This means
9980 that our grammar will not introduce `LocalVariableReferences' as
9981 expressions at this point. That solves the problem of code like
9989 This is only half the fix. The full fix requires parameters to
9990 also be handled in this way.
9992 * class.cs (Property.DefineMethod): When implementing an interface
9993 method, set newslot, when implementing an abstract method, do not
9994 set the flag (before we tried never setting it, or always setting
9995 it, which is the difference).
9996 (Indexer.DefineMethod): same.
9997 (Method.DefineMethod): same.
9999 * ecore.cs: Only set the status used flag if we get back a Field.
10001 * attribute.cs: Temporary hack, so Paolo can keep working.
10003 2002-03-08 Ravi Pratap <ravi@ximian.com>
10005 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
10006 the unmanaged type in the case we have a MarshalAs attribute.
10008 (Resolve): Handle the case when we are parsing the special MarshalAs
10009 attribute [we need to store the unmanaged type to use later]
10011 * typemanager.cs (marshal_as_attr_type): Built in type for the
10012 MarshalAs Attribute.
10014 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
10015 on parameters and accordingly set the marshalling info.
10017 2002-03-09 Miguel de Icaza <miguel@ximian.com>
10019 * class.cs: Optimizing slightly by removing redundant code after
10020 we switched to the `NoTypes' return value.
10021 (Property.DefineMethod): use NoTypes here too.
10023 This fixes the bug I introduced in my last batch of changes.
10025 2002-03-05 Ravi Pratap <ravi@ximian.com>
10027 * tree.cs (RecordEnum): Add. We now keep track of enums too.
10029 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
10030 Enums since those are types too.
10032 * cs-parser.jay (enum_declaration): Record enums as we parse them.
10034 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
10035 thanks to a call during the lookup process.
10037 2002-03-07 Miguel de Icaza <miguel@ximian.com>
10039 * statement.cs (Foreach): Lots of work to accomodate a particular
10040 kind of foreach statement that I had not kept in mind. It is
10041 possible to have foreachs on classes that provide a GetEnumerator
10042 method that return objects that implement the "pattern" for using
10043 a foreach, there is no need to support GetEnumerator
10046 This is needed to compile nant.
10048 * decl.cs: Only report 114 if the member is not `Finalize' and if
10049 the warning level is at least 2.
10051 * class.cs: Moved the compare function from Method to
10054 (MethodSignature.InheritableMemberSignatureCompare): Add new
10055 filter function that is used to extract inheritable methods from a
10058 (Method.Define): Use the new `inheritable_method_signature_filter'
10061 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
10064 2002-03-06 Miguel de Icaza <miguel@ximian.com>
10066 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
10068 * cs-parser.jay: Add opt_semicolon to the interface declaration.
10070 * expression.cs: Pass location information to
10071 ConvertImplicitStandard.
10073 * class.cs: Added debugging code to track return values from
10076 2002-03-05 Miguel de Icaza <miguel@ximian.com>
10078 * expression.cs (Is.DoResolve): If either side of the `is' is an
10079 interface, do not flag the warning.
10081 * ecore.cs (ImplicitReferenceConversion): We need a separate test
10084 * report.cs: Allow for --fatal to be used with --probe.
10086 * typemanager.cs (NoTypes): Move the definition for the empty Type
10089 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
10091 (TypeContainer.DefineProxy): New function used to proxy to parent
10092 implementations when implementing interfaces.
10093 (TypeContainer.ParentImplements): used to lookup if our parent
10094 implements a public function that is required by an interface.
10095 (TypeContainer.VerifyPendingMethods): Hook this up.
10097 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
10098 `modules' and `assemblies' arraylists into arrays. We only grow
10099 these are the very early start up of the program, so this improves
10100 the speedof LookupType (nicely measured).
10102 * expression.cs (MakeByteBlob): Replaced unsafe code with
10103 BitConverter, as suggested by Paolo.
10105 * cfold.cs (ConstantFold.Binary): Special case: perform constant
10106 folding of string concatenation, but if either side is a string,
10107 and the other is not, then return null, and let the runtime use
10108 the concatenation on the string plus the object (using
10109 `Object.ToString').
10111 2002-03-04 Miguel de Icaza <miguel@ximian.com>
10113 Constant Folding has been implemented now.
10115 * expression.cs (Unary.Reduce): Do not throw an exception, catch
10116 the error instead on types that are not supported in one's
10119 * constant.cs (Constant and all children): New set of functions to
10120 perform implict and explicit conversions.
10122 * ecore.cs (EnumConstant): Implement the new functions to perform
10123 conversion by proxying to the child expression.
10125 * codegen.cs: (ConstantCheckState): Constant evaluation has its
10126 own separate setting that can not be turned off from the command
10127 line using --unchecked or --checked and is only controlled using
10128 the checked/unchecked statements and expressions. This setting is
10129 used by the constant folder to flag errors.
10131 * expression.cs (CheckedExpr, UncheckedExpr): Set the
10132 ConstantCheckState as well.
10134 During Resolve, they also have to flag the state, because the
10135 constant folder runs completely in the Resolve phase.
10137 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
10140 2002-03-01 Miguel de Icaza <miguel@ximian.com>
10142 * cfold.cs: New file, this file contains the constant folder.
10144 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
10145 argument to track whether we are using the resulting address to
10146 load or store a value and provide better error messages.
10148 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
10149 new AddressOf arguments.
10151 * statement.cs (Foreach.EmitCollectionForeach): Update
10153 * expression.cs (Argument.Emit): Call AddressOf with proper
10154 arguments to track usage.
10156 (New.DoEmit): Call AddressOf with new arguments.
10158 (Unary.Emit): Adjust AddressOf call.
10160 2002-03-01 Ravi Pratap <ravi@ximian.com>
10162 * cs-parser.jay (member_access): Change the case for pre-defined types
10163 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
10166 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
10169 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
10170 essentially like methods and apply attributes like MethodImplOptions to them too.
10172 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
10175 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
10176 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
10179 * Update code everywhere accordingly.
10181 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
10183 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
10185 2002-02-28 Ravi Pratap <ravi@ximian.com>
10187 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
10188 try performing lookups against those instead of jumping straight into using
10189 the 'using' clauses.
10191 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
10193 (LookupType): Perform lookups in implicit parents too.
10195 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
10196 sequence as RootContext.LookupType.
10198 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
10199 the various cases of namespace lookups into this method.
10201 2002-03-01 Miguel de Icaza <miguel@ximian.com>
10203 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
10204 in positional arguments)
10206 * class.cs (Operator): Update the AllowedModifiers to contain
10209 * cs-parser.jay: Update operator declaration to allow for the
10210 operator body to be empty.
10212 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
10215 2002-02-27 Miguel de Icaza <miguel@ximian.com>
10217 * class.cs (Method.Emit): Label parameters.
10219 * driver.cs: Return 1 or 0 as the program exit code.
10221 2002-02-26 Miguel de Icaza <miguel@ximian.com>
10223 * expression.cs: Special case the `null' object when trying to
10224 auto-compute the type, as anything can be explicitly converted to
10227 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
10228 spotting this Paolo.
10230 (Expression.ImplicitNumericConversion): Perform comparissions of
10231 the type using the underlying type in the case of an enumeration
10232 rather than using the enumeration type for the compare.
10234 Cope with the underlying == type case, which is not possible to
10237 (Expression.ConvertNumericExplicit): Perform comparissions of
10238 the type using the underlying type in the case of an enumeration
10239 rather than using the enumeration type for the compare.
10241 * driver.cs: If the user does not supply an extension, assume .exe
10243 * cs-parser.jay (if_statement): Rewrote so that we can track the
10244 location for the if statement.
10246 * expression.cs (Binary.ConstantFold): Only concat strings when
10247 the operation is "+", not everything ;-)
10249 * statement.cs (Statement.EmitBoolExpression): Take a location
10251 (If, While, Do): Track location.
10253 * expression.cs (Binary.ResolveOperator): In the object + string
10254 case, I was missing a call to ConvertImplicit
10256 2002-02-25 Ravi Pratap <ravi@ximian.com>
10258 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
10259 Location arguments. Ensure we use RootContext.LookupType to do our work
10260 and not try to do a direct Type.GetType and ModuleBuilder.GetType
10262 * interface.cs (PopulateMethod): Handle the type of the parameter being
10265 * expression.cs (Invocation.BetterFunction): Handle the case when we
10266 have a params method with no fixed arguments and a call is made with no
10269 2002-02-25 Miguel de Icaza <miguel@ximian.com>
10271 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
10272 the verbatim-string-literal
10274 * support.cs (InternalParameters.ParameterModifier): handle null
10276 (InternalParameters.ParameterType): ditto.
10278 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
10279 duplicating the name of the variable parameter.
10280 (GetParameterByName): Fix bug where we were not looking up array
10281 paramters if they were the only present (thanks Paolo!).
10282 (GetParameterInfo): We only have an empty set of types if both
10283 fixed and array are set to null.
10284 (GetParameterInfo-idx): Handle FixedParameter == null
10286 * cs-parser.jay: Handle the case where there is no catch
10287 statements (missing null test).
10289 2002-02-22 Miguel de Icaza <miguel@ximian.com>
10291 * driver.cs (MainDriver): Be conservative on our command line
10294 Catch DirectoryNotFoundException when calling GetFiles.
10296 (SplitPathAndPattern): Used to split the input specification into
10297 a path and a pattern that we can feed to Directory.GetFiles.
10299 2002-02-21 Miguel de Icaza <miguel@ximian.com>
10301 * statement.cs (Fixed): Implement the last case of the Fixed
10302 statement (string handling).
10304 * expression.cs (StringPtr): New class used to return a char * to
10305 a string; Used by the Fixed statement.
10307 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
10309 * expression.cs (Binary.ResolveOperator): Remove redundant
10310 MemberLookup pn parent type.
10311 Optimize union call, we do not need a union if the types are the same.
10312 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
10315 Specialize the use of MemberLookup everywhere, instead of using
10316 the default settings.
10318 (StackAlloc): Implement stackalloc keyword.
10320 * cs-parser.jay: Add rule to parse stackalloc.
10322 * driver.cs: Handle /h, /help, /?
10324 * expression.cs (MakeByteBlob): Removed the hacks we had in place
10325 before we supported unsafe code.
10327 * makefile: add --unsafe to the self compilation of mcs.
10329 2002-02-20 Miguel de Icaza <miguel@ximian.com>
10331 * expression.cs (PointerArithmetic): New class that is used to
10332 perform pointer arithmetic.
10333 (Binary.Resolve): Handle pointer arithmetic
10334 Handle pointer comparission.
10335 (ArrayPtr): Utility expression class that is used to take the
10336 address of an array.
10338 (ElementAccess): Implement array access for pointers
10340 * statement.cs (Fixed): Implement fixed statement for arrays, we
10341 are missing one more case before we are done.
10343 * expression.cs (Indirection): Implement EmitAssign and set the
10344 ExprClass to Variable. This allows pointer dereferences to be
10345 treated as variables, and to have values assigned to them.
10347 * ecore.cs (Expression.StoreFromPtr): New utility function to
10348 store values dereferencing.
10350 2002-02-20 Ravi Pratap <ravi@ximian.com>
10352 * expression.cs (Binary.ResolveOperator): Ensure that we are
10353 not trying to operate on a void type - this fixes the reported
10356 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
10357 the parent implementation is sealed.
10359 * ../errors/cs0239.cs : Add.
10361 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
10363 * typemanager.cs (unverifiable_code_type): Corresponds to
10364 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
10365 which have unsafe code in them.
10367 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
10370 2002-02-19 Miguel de Icaza <miguel@ximian.com>
10372 * cs-tokenizer.cs: Add support for @"litreal strings"
10374 Make tokenizer accept pre-processor directives
10375 on any column (remove the old C-like limitation).
10377 * rootcontext.cs (EmitCode): Emit any global attributes.
10378 (AddGlobalAttributes): Used to keep track of assembly attributes.
10380 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
10382 * cs-parser.jay: Add support for global attributes.
10384 2002-02-17 Miguel de Icaza <miguel@ximian.com>
10386 * expression.cs (Indirection): New helper class. Unary will
10387 create Indirection classes to be able to implement the
10388 IMemoryLocation interface on it.
10390 2002-02-16 Miguel de Icaza <miguel@ximian.com>
10392 * cs-parser.jay (fixed_statement): reference the right statement.
10394 * statement.cs (Fixed.Emit): Finish implementing the fixed
10395 statement for the &x case.
10397 2002-02-14 Miguel de Icaza <miguel@ximian.com>
10399 * class.cs (Property.Define, Method.Define): Remove newslot when
10402 * modifiers.cs: My use of NewSlot when `Abstract' was set was
10403 wrong. NewSlot should only be used if the `new' keyword is present.
10405 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
10406 locating our system dir. Sorry about this.
10408 2002-02-13 Miguel de Icaza <miguel@ximian.com>
10410 * driver.cs (GetSystemDir): Compute correctly the location of our
10411 system assemblies. I was using the compiler directory instead of
10412 the library directory.
10414 2002-02-13 Ravi Pratap <ravi@ximian.com>
10416 * expression.cs (BetterFunction): Put back in what Miguel commented out
10417 since it is the correct fix. The problem is elsewhere ;-)
10419 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
10420 parameters of the parms method are themselves compatible or not !
10422 (StandardConversionExists): Fix very dangerous bug where we were forgetting
10423 to check that a class implements an interface before saying that an implicit
10424 conversion was allowed. Use ImplementsInterface to do the checking.
10426 2002-02-13 Miguel de Icaza <miguel@ximian.com>
10428 * class.cs (Method.Define): Track whether we are an explicit
10429 implementation or not. And only call DefineMethodOverride if we
10430 are an explicit implementation.
10432 (Property.DefineMethod): Ditto.
10434 2002-02-11 Ravi Pratap <ravi@ximian.com>
10436 * expression.cs (BetterFunction): Catch hideous bug which was
10437 preventing us from detecting ambiguous calls due to implicit casts i.e
10440 2002-01-29 Miguel de Icaza <miguel@ximian.com>
10442 * support.cs (Pair): Remove un-needed method. I figured why I was
10443 getting the error in cs-parser.jay, the variable in a foreach loop
10444 is readonly, and the compiler does not really treat this as a variable.
10446 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
10447 instead of EQUALS in grammar.
10449 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
10451 * expression.cs (Unary.DoResolve): Check whether the argument is
10454 2002-01-28 Miguel de Icaza <miguel@ximian.com>
10456 * support.cs: Api for Pair to set a value. Despite the fact that
10457 the variables are public the MS C# compiler refuses to compile
10458 code that accesses the field if the variable is part of a foreach
10461 * statement.cs (Fixed): Begin implementation of the fixed
10464 (Block.AddVariable): Return the VariableInfo on success and null
10465 on failure instead of true/false.
10467 * cs-parser.jay (foreach): Catch errors on variables already
10468 defined (we were ignoring this value before) and properly unwind
10469 the block hierarchy
10471 (fixed_statement): grammar for the fixed statement.
10473 2002-01-25 Miguel de Icaza <miguel@ximian.com>
10475 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
10476 pointer types to be incretemented.
10478 (SizeOf): Implement.
10480 * cs-parser.jay (pointer_member_access): Implement
10481 expr->IDENTIFIER production.
10483 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
10484 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
10487 (Unary): Implement indirection.
10489 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
10490 use in non-unsafe context).
10492 (SimpleName.DoResolve): Check for pointers in field access on safe
10495 (Expression.LoadFromPtr): Factor the load-indirect code in this
10496 function. This was duplicated in UnboxCast and ParameterReference
10498 2002-01-24 Miguel de Icaza <miguel@ximian.com>
10500 * expression.cs (ComposedCast): report an error if a pointer cast
10501 is used in a safe region.
10503 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
10504 pointer type casts in unsafe context.
10506 * codegen.cs (EmitContext): Set up IsUnsafe.
10508 * cs-parser.jay (non_expression_type): Add productions for pointer
10511 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
10512 code. We should not use force into static mode if the method is
10513 not virtual. Fixes bug in MIS
10515 * statement.cs (Do.Emit, While.Emit, For.Emit,
10516 Statement.EmitBoolExpression): Add support to Do and While to
10517 propagate infinite loop as `I do return' semantics.
10519 Improve the For case to also test for boolean constants.
10521 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
10522 to the list of attributes we can add.
10524 Remove `EmitContext' argument.
10526 * class.cs (Method.Define): Apply parameter attributes.
10527 (Constructor.Define): Apply parameter attributes.
10528 (MethodCore.LabelParameters): Move here the core of labeling
10531 * support.cs (ReflectionParameters.ParameterModifier,
10532 InternalParameters.ParameterModifier): Use IsByRef on the type and
10533 only return the OUT bit for these parameters instead of in/out/ref
10536 This is because I miss-understood things. The ParameterInfo.IsIn
10537 and IsOut represent whether the parameter has the [In] and [Out]
10540 2002-01-22 Miguel de Icaza <miguel@ximian.com>
10542 * ecore.cs (FieldExpr.Emit): Release temporaries.
10544 * assign.cs (LocalTemporary.Release): new function.
10546 * codegen.cs (EmitContext.GetTemporaryStorage,
10547 EmitContext.FreeTemporaryStorage): Rework the way we deal with
10548 temporary storage. Now we can "put back" localbuilders when we
10551 2002-01-21 Miguel de Icaza <miguel@ximian.com>
10553 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
10554 need to make a copy of the variable to generate verifiable code.
10556 2002-01-19 Miguel de Icaza <miguel@ximian.com>
10558 * driver.cs: Compute dynamically the system directory.
10560 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
10561 Slower, but more generally useful. Used by the abstract
10562 registering implementation.
10564 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
10565 the rules for the special rule on Type/instances. First check if
10566 we have the same name, and if so, try that special static path
10567 rather than the instance path.
10569 2002-01-18 Miguel de Icaza <miguel@ximian.com>
10571 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
10574 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
10575 Enum, ValueType, Delegate or Array for non-corlib compiles.
10577 * cs-tokenizer.cs: Catch long identifiers (645)
10579 * typemanager.cs (IndexerPropetyName): Ravi never tested this
10582 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
10583 fix, we were returning too early, so we were not registering
10584 pending methods from abstract classes.
10586 Do not register pending methods if the class is abstract.
10588 * expression.cs (Conditional.DoResolve): Report circular implicit
10589 conversions when we neecd to compute it for conditional
10592 (Is.DoResolve): If the expression is always of the provided type,
10593 flag warning 183. If the expression can not ever be of the
10594 provided type flag warning 184.
10596 * class.cs: Catch 169 as well.
10598 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
10601 2002-01-18 Nick Drochak <ndrochak@gol.com>
10603 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
10605 2002-01-17 Miguel de Icaza <miguel@ximian.com>
10607 * interface.cs: (PopulateMethod): Check for pointers being defined
10608 only if the unsafe context is active.
10609 (PopulateProperty): ditto.
10610 (PopulateIndexer): ditto.
10612 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
10613 specified. If pointers are present, make sure that they are
10614 present in an unsafe context.
10615 (Constructor, Constructor.Define): ditto.
10616 (Field, Field.Define): ditto.
10617 (Property, Property.Define): ditto.
10618 (Event, Event.Define): ditto.
10620 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
10621 hashtable if there are classes or structs defined.
10623 * expression.cs (LocalVariableReference.DoResolve): Simplify this
10624 code, as the constant resolution moved.
10626 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
10627 the metadata, so we can flag error 133.
10629 * decl.cs (MemberCore.UnsafeOK): New function to test that a
10630 pointer is being declared in an unsafe context.
10632 2002-01-16 Miguel de Icaza <miguel@ximian.com>
10634 * modifiers.cs (Modifiers.Check): Require a Location argument.
10635 Report error 227 for Unsafe use.
10637 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
10639 * statement.cs (For.Emit): If the test is null, then report that
10640 we do `return', as we wont reach anything afterwards.
10642 (Switch.SwitchGoverningType): Track the expression that matched
10645 * driver.cs: Allow negative numbers as an error code to flag.
10647 * cs-parser.jay: Handle 1551.
10649 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
10651 2002-01-15 Miguel de Icaza <miguel@ximian.com>
10653 * cs-parser.jay: Report 1518 (type declaration can only contain
10654 class, struct, interface, enum or delegate)
10656 (switch_label): Report 1523 (keywords `case' or `default' must
10659 (opt_switch_sections): Report 1522 (empty switch)
10661 * driver.cs: Report 1515 (response file specified multiple times)
10662 Report 1516 (Source file specified multiple times).
10664 * expression.cs (Argument.Resolve): Signal 1510
10666 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
10667 access not allowed in static code)
10669 2002-01-11 Ravi Pratap <ravi@ximian.com>
10671 * typemanager.cs (IsPointerType): Utility method which we are going
10674 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
10675 the object type, so we take care of that.
10677 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
10679 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
10680 added to non-params parameters :-)
10682 * typemanager.cs (CSharpName): Include 'void' type too.
10684 (void_ptr_type): Include in the set of core types.
10686 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
10689 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
10692 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
10693 completely forgotten about it.
10695 2002-01-10 Ravi Pratap <ravi@ximian.com>
10697 * cs-parser.jay (pointer_type): Add. This begins our implementation
10698 of parsing rules for unsafe code.
10700 (unsafe_statement): Implement.
10702 (embedded_statement): Modify to include the above.
10704 * statement.cs (Unsafe): Implement new class for unsafe blocks.
10706 * codegen.cs (EmitContext.InUnsafe): Add. This determines
10707 if the current context is an unsafe one.
10709 * cs-parser.jay (local_variable_pointer_type): Since local variable types
10710 are handled differently, we need separate rules for them.
10712 (local_variable_declaration): Update to use local_variable_pointer_type
10713 to allow variable declarations of unmanaged pointer types.
10715 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
10716 in unsafe contexts.
10718 * ../errors/cs0214.cs : Add.
10720 2002-01-16 Nick Drochak <ndrochak@gol.com>
10722 * makefile: remove 'response' file when cleaning.
10724 2002-01-15 Miguel de Icaza <miguel@ximian.com>
10726 * cs-parser.jay: Report 1524.
10728 2002-01-14 Miguel de Icaza <miguel@ximian.com>
10730 * typemanager.cs (RegisterMethod): drop checking if we have
10731 registered this from here
10733 2002-01-12 Miguel de Icaza <miguel@ximian.com>
10735 * class.cs (Method.EmitDestructor): Implement calling our base
10738 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
10739 value of InFinally.
10741 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
10742 this routine and will wrap the call in a try/catch block. Deal
10745 2002-01-11 Miguel de Icaza <miguel@ximian.com>
10747 * ecore.cs (Expression.MemberLookup): instead of taking a
10748 parameter `same_type' that was used to tell whether we could
10749 access private members we compute our containing type from the
10752 (FieldExpr): Added partial support for volatile fields. This does
10753 not work for volatile fields exposed from assemblies, as I can not
10754 figure out how to extract the modreq from it.
10756 Updated all the source files to use this.
10758 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
10759 because it is referenced by MemberLookup very often.
10761 2002-01-09 Ravi Pratap <ravi@ximian.com>
10763 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
10764 TypeBuilder.GetCustomAttributes to retrieve what we need.
10766 Get rid of redundant default_member_attr_type as this is the same as
10767 default_member_type which already exists.
10769 * interface.cs, attribute.cs : Update accordingly.
10771 2002-01-08 Miguel de Icaza <miguel@ximian.com>
10773 * typemanager.cs: Enable IndexerPropertyName again. It does not
10774 work for TYpeBuilders though. Ravi, can you please fix this?
10776 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
10778 * expression.cs (Argument.Emit): Handle the case of ref objects
10779 being passed to ref functions;
10781 (ParameterReference.EmitLoad): Loads the content of the pointer
10782 without dereferencing.
10784 2002-01-07 Miguel de Icaza <miguel@ximian.com>
10786 * cs-tokenizer.cs: Implemented the pre-processing expressions.
10788 2002-01-08 Ravi Pratap <ravi@ximian.com>
10790 * class.cs (Indexer.DefineMethod): Incorporate the interface
10791 type in the name of the method if we are doing explicit interface
10794 * expression.cs (ConversionExists): Remove as it is completely obsolete.
10796 (BetterConversion): Fix extremely trivial bug where we were referring to
10797 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
10800 * ../errors/bug16.cs : Add although we have fixed it.
10802 2002-01-07 Miguel de Icaza <miguel@ximian.com>
10804 * expression.cs (BaseIndexer): Begin implementation.
10806 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
10808 * cs-parser.jay (indexer_declarator): Use qualified_identifier
10809 production directly to remove a shift/reduce, and implement
10810 explicit interface implementation.
10812 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
10813 after a floating point suffix.
10815 * expression.cs (DoNumericPromotions): Improved the conversion for
10816 uint/uint. If we have a constant, we avoid doing a typecast to a
10819 * class.cs (Indexer): Implement explicit interface implementation
10822 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
10824 * class.cs: make the default instance constructor public and hidebysig.
10826 2001-01-03 Ravi Pratap <ravi@ximian.com>
10828 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
10829 so we can call it from elsewhere.
10831 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
10832 we emit it internally if the class has a defined indexer; otherwise the user
10833 emits it by decorating the class definition with the DefaultMemberAttribute.
10835 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
10836 attribute is not used on a type which defines an indexer.
10838 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
10839 character when we skip whitespace.
10841 * ../errors/cs0646.cs : Add.
10843 2002-01-03 Miguel de Icaza <miguel@ximian.com>
10845 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
10848 * makefile: Add practical target `mcs3.exe' which builds the third
10849 generation compiler.
10851 * expression.cs (New): Fix structures constructor calling.
10853 * class.cs (Property, Method, Indexer): Emit Final flag on the
10854 method if we are an interface implementation and we are not
10857 * ecore.cs (PropertyExpr): New public field `IsBase', tells
10858 whether this property is referencing a `base' method.
10860 * expression.cs (Invocation.EmitCall): take an extra argument:
10861 is_base, this is used to determine whether the `call' or
10862 `callvirt' opcode should be used.
10865 * delegate.cs: update EmitCall.
10867 * class.cs (Method.Define): Set NewSlot for the cases where we are
10868 not implementing an interface method.
10870 (Property.Define): ditto.
10872 2002-01-02 Miguel de Icaza <miguel@ximian.com>
10874 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
10875 'r'. Allows mcs to parse itself fully.
10877 2002-01-02 Ravi Pratap <ravi@ximian.com>
10879 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
10880 of the number of initializers that require the InitializeArray method.
10882 (CheckIndices): Store the Expression in all cases - not the plain value. Also
10883 update the above field where necessary.
10885 (MakeByteBlob): Update accordingly.
10887 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
10890 (EmitDynamicInitializers): Update in accordance with the new optimization.
10892 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
10893 same OpCode applies.
10895 * cs-parser.jay : Fix some glaring errors I introduced.
10897 2002-01-01 Ravi Pratap <ravi@ximian.com>
10899 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
10900 so that we can check for name clashes there too.
10902 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
10903 for interface indexers.
10905 * interfaces.cs (Define): Emit the default member attribute.
10907 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
10908 variable was being referred to while setting the value ;-)
10910 2002-01-01 Miguel de Icaza <miguel@ximian.com>
10912 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
10913 byte-by-byte information when we know the data is zero.
10915 Make the block always a multiple of 4, because
10916 DefineInitializedData has a bug.
10918 * assign.cs: Fix, we should assign from the temporary, not from
10921 * expression.cs (MakeByteBlob): Fix my incorrect code.
10923 2001-12-31 Miguel de Icaza <miguel@ximian.com>
10925 * typemanager.cs (EnumToUnderlying): This function is used to get
10926 the underlying type from an enumeration, because it does not
10929 * constant.cs: Use the I4_S form for values between -128 and 127.
10931 * statement.cs (Block.LookupLabel): Looks up a label.
10932 (Block): Drop support for labeled blocks.
10934 (LabeledStatement): New kind of statement that represents a label
10937 (Goto): Finally implement this bad boy.
10939 * cs-parser.jay: Update to reflect new mechanism to implement
10942 2001-12-30 Miguel de Icaza <miguel@ximian.com>
10944 * codegen.cs (EmitContext.This): a codegen property that keeps the
10945 a single instance of this instead of creating many different this
10948 * delegate.cs (Delegate.DoResolve): Update to use the property;
10950 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
10952 * expression.cs (BaseAccess.DoResolve): Ditto.
10954 2001-12-29 Ravi Pratap <ravi@ximian.com>
10956 * typemanager.cs (methodimpl_attr_type): Add to hold the type
10957 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
10959 (InitCoreTypes): Update accordingly.
10961 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
10962 so we can quickly store the state.
10964 (ApplyAttributes): Set the correct implementation flags
10965 for InternalCall methods.
10967 2001-12-29 Miguel de Icaza <miguel@ximian.com>
10969 * expression.cs (EmitCall): if a method is not virtual, then do
10970 not use callvirt on it.
10972 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
10973 user defined stuff) requires the use of stobj, which takes an
10974 address on the stack instead of an array and an index. So emit
10975 the Ldelema operation for it.
10977 (EmitStoreOpcode): Use stobj for valuetypes.
10979 (UnaryMutator.EmitCode): Use the right 1 value depending on
10980 whether we are dealing with int64/uint64, float or doubles.
10982 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
10983 constructors that I implemented last night.
10985 (Constructor.IsDefault): Fix to work properly for static
10988 * cs-parser.jay (CheckDef): report method signature errors.
10989 Update error number 103 to be 132.
10991 * decl.cs: New AdditionResult enumeration value: MethodExists.
10992 Although we do this check for methods later on in the semantic
10993 analysis, catching repeated default constructors is so easy that
10994 we catch these here.
10996 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
10999 (ParameterReference.EmitAssign, Emit): handle
11002 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
11003 (ArrayAccess.EmitStoreOpcode): ditto.
11005 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
11007 * expression.cs (MakeByteBlob): Complete all the missing types
11008 (uint, short, ushort, byte, sbyte)
11010 * class.cs: Only init instance field initializers on instance
11013 Rename `constructors' to instance_constructors.
11015 (TypeContainer.AddConstructor): Only add constructors to the list
11016 if it is not static.
11018 Make sure that we handle default_static_constructor independently
11019 everywhere where we handle instance_constructors
11021 2001-12-28 Miguel de Icaza <miguel@ximian.com>
11023 * class.cs: Do not lookup or create a base initializer for a
11024 static constructor.
11026 (ConstructorInitializer.Resolve): use the proper type to lookup
11029 * cs-parser.jay: Report error 1585 (modifiers between type and name).
11031 * enum.cs, interface.cs: Remove CloseType, this is taken care by
11034 * decl.cs: CloseType is now an virtual method, the default
11035 implementation just closes this type.
11037 2001-12-28 Ravi Pratap <ravi@ximian.com>
11039 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
11040 to PreserveSig by default. Also emit HideBySig on such methods.
11042 Basically, set the defaults to standard values.
11044 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
11045 argument, if candidate is better, it can't be worse than the best !
11047 (Invocation): Re-write bits to differentiate between methods being
11048 applicable in their expanded form and their normal form - for params
11051 Get rid of use_standard everywhere as only standard conversions are allowed
11052 in overload resolution.
11054 More spec conformance.
11056 2001-12-27 Miguel de Icaza <miguel@ximian.com>
11058 * driver.cs: Add --timestamp, to see where the compiler spends
11061 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
11062 `this' in static code.
11064 (SimpleName.DoResolve): Implement in terms of a helper function
11065 that allows static-references to be passed upstream to
11068 (Expression.ResolveWithSimpleName): Resolve specially simple
11069 names when called by MemberAccess to implement the special
11072 (Expression.ImplicitReferenceConversion): Handle conversions from
11073 Null to reference types before others, as Null's type is
11076 * expression.cs (Invocation.EmitCall): Handle the special case of
11077 calling methods declared on a reference type from a ValueType
11078 (Base classes System.Object and System.Enum)
11080 (MemberAccess.Resolve): Only perform lookups on Enumerations if
11081 the left hand side is a TypeExpr, not on every enumeration.
11083 (Binary.Resolve): If types are reference types, then do a cast to
11084 object on operators != and == of both arguments.
11086 * typemanager.cs (FindMembers): Extract instance and static
11087 members if requested.
11089 * interface.cs (PopulateProperty): Use void_type instead of null
11090 as the return type for the setter method.
11092 (PopulateIndexer): ditto.
11094 2001-12-27 Ravi Pratap <ravi@ximian.com>
11096 * support.cs (ReflectionParameters): Fix minor bug where we
11097 were examining the wrong parameter for the ParamArray attribute.
11099 Cope with requests for the type of the parameter at position
11100 greater than the params parameter's. We now return the element
11101 type of the params array as that makes more sense.
11103 * expression.cs (Invocation.IsParamsMethodApplicable): Update
11104 accordingly as we no longer have to extract the element type
11107 (Invocation.OverloadResolve): Update.
11109 2001-12-27 Miguel de Icaza <miguel@ximian.com>
11111 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
11112 against IEnumerator, test whether the return value is a descendant
11113 of the IEnumerator interface.
11115 * class.cs (Indexer.Define): Use an auxiliary method to implement
11116 the other bits of the method definition. Begin support for
11117 explicit interface implementation.
11119 (Property.DefineMethod): Use TypeManager.void_type instead of null
11120 for an empty return value.
11122 2001-12-26 Miguel de Icaza <miguel@ximian.com>
11124 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
11125 dealing with a FieldExpr which is composed of a FieldBuilder, in
11126 the code path we did extract the constant, but we should have
11127 obtained the underlying value to be able to cast it (otherwise we
11128 end up in an infinite loop, this is what Ravi was running into).
11130 (ArrayCreation.UpdateIndices): Arrays might be empty.
11132 (MemberAccess.ResolveMemberAccess): Add support for section
11133 14.5.4.1 that deals with the special case of E.I when E is a type
11134 and something else, that I can be a reference to a static member.
11136 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
11137 handle a particular array type to create byte blobs, it is just
11138 something we dont generate byteblobs for.
11140 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
11143 * location.cs (Push): remove the key from the hashtable that we
11144 are about to add. This happens for empty files.
11146 * driver.cs: Dispose files after we have parsed them.
11148 (tokenize): new function that only runs the tokenizer on its
11149 input, for speed testing.
11151 2001-12-26 Ravi Pratap <ravi@ximian.com>
11153 * class.cs (Event.Define): Define the private field only if there
11154 are no accessors defined.
11156 * expression.cs (ResolveMemberAccess): If there is no associated
11157 field with the event, that means we have an event defined with its
11158 own accessors and we should flag error cs0070 since transforming
11159 ourselves into a field is not valid in that case.
11161 * ecore.cs (SimpleName.DoResolve): Same as above.
11163 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
11164 and charset to sane values.
11166 2001-12-25 Ravi Pratap <ravi@ximian.com>
11168 * assign.cs (DoResolve): Perform check on events only if they
11169 are being accessed outside the declaring type.
11171 * cs-parser.jay (event_declarations): Update rules to correctly
11172 set the type of the implicit parameter etc.
11174 (add_accessor, remove_accessor): Set current local parameters.
11176 * expression.cs (Binary): For delegate addition and subtraction,
11177 cast the return value from the method into the appropriate delegate
11180 2001-12-24 Ravi Pratap <ravi@ximian.com>
11182 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
11183 of these as the workaround is unnecessary.
11185 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
11186 delegate data - none of that is needed at all.
11188 Re-write bits to extract the instance expression and the delegate method
11191 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
11194 * attribute.cs (ApplyAttributes): New method to take care of common tasks
11195 of attaching attributes instead of duplicating code everywhere.
11197 * everywhere : Update code to do attribute emission using the above method.
11199 2001-12-23 Miguel de Icaza <miguel@ximian.com>
11201 * expression.cs (IsParamsMethodApplicable): if there are not
11202 parameters, return immediately.
11204 * ecore.cs: The 0 literal can be implicity converted to an enum
11207 (SimpleName.DoResolve): First lookup the type, then lookup the
11210 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
11211 want to get its address. If the InstanceExpression is not
11212 addressable, store the result in a temporary variable, then get
11215 * codegen.cs: Only display 219 errors on warning level or above.
11217 * expression.cs (ArrayAccess): Make it implement the
11218 IMemoryLocation interface.
11220 (Binary.DoResolve): handle the operator == (object a, object b)
11221 and operator != (object a, object b) without incurring into a
11222 BoxedCast (because 5 != o should never be performed).
11224 Handle binary enumerator operators.
11226 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
11227 value type, otherwise use Ldelem_ref.
11229 Use precomputed names;
11231 (AddressOf): Implement address of
11233 * cs-parser.jay (labeled_statement): Fix recursive block
11234 addition by reworking the production.
11236 * expression.cs (New.DoEmit): New has a special case:
11238 If we are dealing with a ValueType, we have a few
11239 situations to deal with:
11241 * The target of New is a ValueType variable, that is
11242 easy, we just pass this as the variable reference
11244 * The target of New is being passed as an argument,
11245 to a boxing operation or a function that takes a
11248 In this case, we need to create a temporary variable
11249 that is the argument of New.
11252 2001-12-23 Ravi Pratap <ravi@ximian.com>
11254 * rootcontext.cs (LookupType): Check that current_type is not null before
11255 going about looking at nested types.
11257 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
11258 not implement the IAssignMethod interface any more.
11260 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
11261 where we tranform them into FieldExprs if they are being resolved from within
11262 the declaring type.
11264 * ecore.cs (SimpleName.DoResolve): Do the same here.
11266 * assign.cs (DoResolve, Emit): Clean up code considerably.
11268 * ../errors/bug10.cs : Add.
11270 * ../errors/cs0070.cs : Add.
11272 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
11274 * assign.cs : Get rid of EventIsLocal everywhere.
11276 2001-12-23 Miguel de Icaza <miguel@ximian.com>
11278 * ecore.cs (ConvertIntLiteral): finished the implementation.
11280 * statement.cs (SwitchLabel): Convert the value we are using as a
11281 key before looking up the table.
11283 2001-12-22 Miguel de Icaza <miguel@ximian.com>
11285 * codegen.cs (EmitTopBlock): Require a Location argument now.
11287 * cs-parser.jay (constructor_declarator): We need to setup
11288 current_local_parameters before we parse the
11289 opt_constructor_initializer, to allow the variables to be bound
11290 to the constructor arguments.
11292 * rootcontext.cs (LookupType): First lookup nested classes in our
11293 class and our parents before we go looking outside our class.
11295 * expression.cs (ConstantFold): Extract/debox the values at the
11298 * rootcontext.cs (EmitCode): Resolve the constants first before we
11299 resolve the types. This is not really needed, but it helps debugging.
11301 * statement.cs: report location.
11303 * cs-parser.jay: pass location to throw statement.
11305 * driver.cs: Small bug fix.
11307 * report.cs: Updated format to be 4-zero filled digits.
11309 2001-12-22 Ravi Pratap <ravi@ximian.com>
11311 * expression.cs (CheckIndices): Fix minor bug where the wrong
11312 variable was being referred to ;-)
11314 (DoEmit): Do not call EmitStaticInitializers when the
11315 underlying type is System.Object.
11317 2001-12-21 Ravi Pratap <ravi@ximian.com>
11319 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
11320 and do the usual workaround for SRE.
11322 * class.cs (MyEventBuilder.EventType): New member to get at the type
11323 of the event, quickly.
11325 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
11327 * assign.cs (Assign.DoResolve): Handle the case when the target
11328 is an EventExpr and perform the necessary checks.
11330 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
11333 (SimpleName.MemberStaticCheck): Include check for EventExpr.
11335 (EventExpr): Set the type in the constructor itself since we
11336 are meant to be born fully resolved.
11338 (EventExpr.Define): Revert code I wrote earlier.
11340 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
11341 instance expression is null. The instance expression is a This in that case
11342 or a null, depending on whether it is a static method or not.
11344 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
11345 refers to more than one method.
11347 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
11348 and accordingly flag errors.
11350 2001-12-21 Miguel de Icaza <miguel@ximian.com>
11352 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
11354 2001-12-22 Miguel de Icaza <miguel@ximian.com>
11356 * location.cs (ToString): Provide useful rutine.
11358 2001-12-21 Miguel de Icaza <miguel@ximian.com>
11360 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
11361 objects, return the actual integral boxed.
11363 * statement.cs (SwitchLabel): define an ILLabel for each
11366 (Switch.CheckSwitch): If the value is a Literal, extract
11367 the underlying literal.
11369 Also in the unused hashtable we had, add the SwitchLabel so we can
11370 quickly look this value up.
11372 * constant.cs: Implement a bunch of new constants. Rewrite
11373 Literal based on this. Made changes everywhere to adapt to this.
11375 * expression.cs (Expression.MakeByteBlob): Optimize routine by
11376 dereferencing array only once, and also copes with enumrations.
11378 bytes are two bytes wide, not one.
11380 (Cast): Perform constant conversions.
11382 * ecore.cs (TryImplicitIntConversion): Return literals instead of
11383 wrappers to the literals here.
11385 * expression.cs (DoNumericPromotions): long literals can converted
11386 to ulong implicity (this is taken care of elsewhere, but I was
11387 missing this spot).
11389 * ecore.cs (Expression.Literalize): Make the return type Literal,
11390 to improve type checking.
11392 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
11394 2001-12-20 Miguel de Icaza <miguel@ximian.com>
11396 * literal.cs: Revert code from ravi that checked the bounds. The
11397 bounds are sane by the definition of the type itself.
11399 * typemanager.cs: Fix implementation of ImplementsInterface. We
11400 need to actually look up in our parent hierarchy for interfaces
11403 * const.cs: Use the underlying type for enumerations
11405 * delegate.cs: Compute the basename for the delegate creation,
11406 that should fix the delegate test case, and restore the correct
11407 Type Lookup semantics in rootcontext
11409 * rootcontext.cs: Revert Ravi's last patch. The correct way of
11410 referencing a nested type with the Reflection API is using the "+"
11413 * cs-parser.jay: Do not require EOF token at the end.
11415 2001-12-20 Ravi Pratap <ravi@ximian.com>
11417 * rootcontext.cs (LookupType): Concatenate type names with
11418 a '.' instead of a '+' The test suite passes again.
11420 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
11421 field of the enumeration.
11423 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
11424 the case when the member is an EventExpr.
11426 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
11427 static has an associated instance expression.
11429 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
11431 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
11433 * class.cs (Event.Define): Register event and perform appropriate checks
11436 We define the Add and Remove methods even if the use provides none because
11437 in that case, we provide default implementations ourselves.
11439 Define a private field of the type of the event. This is done by the CSC compiler
11440 and we should be doing it too ;-)
11442 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
11443 More methods we use in code we generate.
11445 (multicast_delegate_type, delegate_type): Two separate types since the distinction
11448 (InitCoreTypes): Update accordingly for the above.
11450 * class.cs (Event.Emit): Generate code for default accessors that we provide
11452 (EmitDefaultMethod): Do the job in the above.
11454 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
11457 2001-12-20 Miguel de Icaza <miguel@ximian.com>
11459 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
11460 builders even if we were missing one.
11462 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
11463 pass the Basename as our class name instead of the Name. The
11464 basename will be correctly composed for us.
11466 * parameter.cs (Paramters): Now takes a Location argument.
11468 * decl.cs (DeclSpace.LookupType): Removed convenience function and
11469 make all the code call directly LookupType in RootContext and take
11470 this chance to pass the Location information everywhere.
11472 * Everywhere: pass Location information.
11474 2001-12-19 Miguel de Icaza <miguel@ximian.com>
11476 * class.cs (Constructor.Define): Updated way of detecting the
11477 length of the parameters.
11479 (TypeContainer.DefineType): Use basename as the type name for
11482 (TypeContainer.Define): Do not recursively define types here, as
11483 definition is taken care in order by the RootContext.
11485 * tree.cs: Keep track of namespaces in a per-file basis.
11487 * parameter.cs (Parameter.ComputeSignature): Update to use
11490 (Parameters.GetSignature): ditto.
11492 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
11493 instead of a TypeContainer.
11495 (Interface.SemanticAnalysis): Use `this' instead of our parent to
11496 resolve names. Because we need to be resolve in our context, not
11499 * driver.cs: Implement response files.
11501 * class.cs (TypeContainer.DefineType): If we are defined, do not
11502 redefine ourselves.
11504 (Event.Emit): Emit the code for add/remove handlers.
11505 (Event.Define): Save the MethodBuilders for add/remove.
11507 * typemanager.cs: Use pair here too.
11509 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
11510 DictionaryEntry requires the first argument to be non-null.
11512 (enum_declaration): Compute full name for registering the
11515 (delegate_declaration): Instead of using
11516 formal_parameter_list, use opt_formal_parameter_list as the list
11519 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
11520 (EventParsing): New property that controls whether `add' and
11521 `remove' are returned as tokens or identifiers (for events);
11523 2001-12-19 Ravi Pratap <ravi@ximian.com>
11525 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
11526 use MyEventBuilder only and let it wrap the real builder for us.
11528 (MyEventBuilder): Revamp constructor etc.
11530 Implement all operations that we perform on EventBuilder in precisely the same
11533 (FindMembers): Update to use the EventBuilder member.
11535 (Event.Emit): Update accordingly.
11537 2001-12-18 Ravi Pratap <ravi@ximian.com>
11539 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
11540 by calling the appropriate methods.
11542 (GetCustomAttributes): Make stubs as they cannot possibly do anything
11545 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
11547 2001-12-17 Ravi Pratap <ravi@ximian.com>
11549 * delegate.cs (Delegate.Populate): Check that the return type
11550 and various parameters types are indeed accessible.
11552 * class.cs (Constructor.Define): Same here.
11554 (Field.Define): Ditto.
11556 (Event.Define): Ditto.
11558 (Operator.Define): Check that the underlying Method defined itself
11559 correctly - so it's MethodBuilder should not be null.
11561 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
11562 expression happens to be null.
11564 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
11565 members but as of now we don't seem to be able to do anything really useful with it.
11567 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
11568 not the EventBuilder.
11570 2001-12-18 Miguel de Icaza <miguel@ximian.com>
11572 * cs-tokenizer.cs: Add support for defines.
11573 Add support for #if, #elif, #else, #endif
11575 (eval_var): evaluates a variable.
11576 (eval): stubbed for evaluating functions.
11578 * cs-parser.jay: Pass the defines information
11580 * driver.cs: Add --define command line option.
11582 * decl.cs: Move MemberCore here.
11584 Make it the base class for DeclSpace. This allows us to catch and
11585 report 108 and 109 for everything now.
11587 * class.cs (TypeContainer.Define): Extract all the members
11588 before populating and emit the warning 108 (new keyword required
11589 to override) instead of having each member implement this.
11591 (MemberCore.Define): New abstract method, we will be using this in
11592 the warning reporting engine in Populate.
11594 (Operator.Define): Adjust to new MemberCore protocol.
11596 * const.cs (Const): This does not derive from Expression, it is a
11597 temporary object we use to create fields, it is a MemberCore.
11599 * class.cs (Method.Define): Allow the entry point to be in a
11602 * driver.cs: Rewrite the argument handler to clean it up a bit.
11604 * rootcontext.cs: Made it just an auxiliary namespace feature by
11605 making everything static.
11607 * driver.cs: Adapt code to use RootContext type name instead of
11610 * delegate.cs: Remove RootContext argument.
11612 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
11615 * class.cs (Event.Define): The lookup can fail.
11617 * cs-tokenizer.cs: Begin implementation of pre-procesor.
11619 * expression.cs: Resolve the this instance before invoking the code.
11621 2001-12-17 Miguel de Icaza <miguel@ximian.com>
11623 * cs-parser.jay: Add a production in element_access that allows
11624 the thing to become a "type" reference. This way we can parse
11625 things like "(string [])" as a type.
11627 Note that this still does not handle the more complex rules of
11631 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
11633 * ecore.cs: (CopyNewMethods): new utility function used to
11634 assemble the list of methods from running FindMembers.
11636 (MemberLookup): Rework FindMembers so that
11638 2001-12-16 Miguel de Icaza <miguel@ximian.com>
11640 * class.cs (TypeContainer): Remove Delegates who fail to be
11643 * delegate.cs (Populate): Verify that we dont get null return
11644 values. TODO: Check for AsAccessible.
11646 * cs-parser.jay: Use basename to emit error 574 (destructor should
11647 have the same name as container class), not the full name.
11649 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
11650 possible representation.
11652 Also implements integer type suffixes U and L.
11654 2001-12-15 Miguel de Icaza <miguel@ximian.com>
11656 * expression.cs (ArrayCreation.DoResolve): We need to do the
11657 argument resolution *always*.
11659 * decl.cs: Make this hold the namespace. Hold the root context as
11661 (LookupType): Move here.
11663 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
11665 * location.cs (Row, Name): Fixed the code, it was always returning
11666 references to the first file.
11668 * interface.cs: Register properties defined through interfaces.
11670 * driver.cs: Add support for globbing on the command line
11672 * class.cs (Field): Make it derive from MemberCore as well.
11675 2001-12-15 Ravi Pratap <ravi@ximian.com>
11677 * class.cs (Event::Define): Check that the type of the event is a delegate
11678 type else flag error #66.
11680 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
11683 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
11684 values of EntryPoint, CharSet etc etc.
11686 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
11688 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
11689 be null and we should ignore this. I am not sure if this is really clean. Apparently,
11690 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
11691 which needs this to do its work.
11693 * ../errors/cs0066.cs : Add.
11695 2001-12-14 Miguel de Icaza <miguel@ximian.com>
11697 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
11700 * class.cs: (MethodSignature.MethodSignature): Removed hack that
11701 clears out the parameters field.
11702 (MemberSignatureCompare): Cleanup
11704 (MemberCore): New base class used to share code between MethodCore
11707 (RegisterRequiredImplementations) BindingFlags.Public requires
11708 either BindingFlags.Instace or Static. Use instance here.
11710 (Property): Refactored code to cope better with the full spec.
11712 * parameter.cs (GetParameterInfo): Return an empty array instead
11715 * class.cs (Property): Abstract or extern properties have no bodies.
11717 * parameter.cs (GetParameterInfo): return a zero-sized array.
11719 * class.cs (TypeContainer.MethodModifiersValid): Move all the
11720 method modifier validation to the typecontainer so we can reuse
11721 this on properties.
11723 (MethodCore.ParameterTypes): return an empty sized array of types.
11725 (Property.Define): Test property modifier validity.
11727 Add tests for sealed/override too.
11729 (Method.Emit): abstract or extern methods have no bodies.
11731 2001-12-14 Ravi Pratap <ravi@ximian.com>
11733 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
11736 (Method::Define, ::Emit): Modify accordingly.
11738 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
11740 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
11742 * makefile: Pass in /unsafe.
11744 2001-12-13 Miguel de Icaza <miguel@ximian.com>
11746 * class.cs (MakeKey): Kill routine.
11748 * class.cs (TypeContainer.Define): Correctly define explicit
11749 method implementations (they require the full interface name plus
11752 * typemanager.cs: Deply the PtrHashtable here and stop using the
11753 lame keys. Things work so much better.
11755 This of course broke everyone who depended on `RegisterMethod' to
11756 do the `test for existance' test. This has to be done elsewhere.
11758 * support.cs (PtrHashtable): A hashtable that avoid comparing with
11759 the object stupid Equals method (because, that like fails all over
11760 the place). We still do not use it.
11762 * class.cs (TypeContainer.SetRequiredInterface,
11763 TypeContainer.RequireMethods): Killed these two routines and moved
11764 all the functionality to RegisterRequiredImplementations.
11766 (TypeContainer.RegisterRequiredImplementations): This routine now
11767 registers all the implementations required in an array for the
11768 interfaces and abstract methods. We use an array of structures
11769 which can be computed ahead of time to reduce memory usage and we
11770 also assume that lookups are cheap as most classes will not
11771 implement too many interfaces.
11773 We also avoid creating too many MethodSignatures.
11775 (TypeContainer.IsInterfaceMethod): Update and optionally does not
11776 clear the "pending" bit if we find that there are problems with
11779 (TypeContainer.VerifyPendingMethods): Update to report errors of
11780 methods that look like implementations but are not.
11782 (TypeContainer.Define): Add support for explicit interface method
11785 2001-12-12 Miguel de Icaza <miguel@ximian.com>
11787 * typemanager.cs: Keep track of the parameters here instead of
11788 being a feature of the TypeContainer.
11790 * class.cs: Drop the registration of parameters here, as
11791 InterfaceMethods are also interface declarations.
11793 * delegate.cs: Register methods with the TypeManager not only with
11794 the TypeContainer. This code was buggy.
11796 * interface.cs: Full registation here.
11798 2001-12-11 Miguel de Icaza <miguel@ximian.com>
11800 * expression.cs: Remove reducer for binary expressions, it can not
11803 * const.cs: Put here the code that used to go into constant.cs
11805 * constant.cs: Put here the code for constants, this is a new base
11806 class for Literals.
11808 * literal.cs: Make Literal derive from Constant.
11810 2001-12-09 Miguel de Icaza <miguel@ximian.com>
11812 * statement.cs (Return.Emit): Report error 157 if the user
11813 attempts to return from a finally block.
11815 (Return.Emit): Instead of emitting a return, jump to the end of
11818 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
11819 LocalBuilder to store the result of the function. ReturnLabel is
11820 the target where we jump.
11823 2001-12-09 Radek Doulik <rodo@ximian.com>
11825 * cs-parser.jay: remember alias in current namespace
11827 * ecore.cs (SimpleName::DoResolve): use aliases for types or
11830 * class.cs (LookupAlias): lookup alias in my_namespace
11832 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
11834 (LookupAlias): lookup alias in this and if needed in parent
11837 2001-12-08 Miguel de Icaza <miguel@ximian.com>
11841 * rootcontext.cs: (ModuleBuilder) Made static, first step into
11842 making things static. I need this to avoid passing the
11843 TypeContainer when calling ParameterType.
11845 * support.cs (InternalParameters.ParameterType): Remove ugly hack
11846 that did string manipulation to compute the type and then call
11847 GetType. Use Parameter.ParameterType instead.
11849 * cs-tokenizer.cs: Consume the suffix for floating values.
11851 * expression.cs (ParameterReference): figure out whether this is a
11852 reference parameter or not. Kill an extra variable by computing
11853 the arg_idx during emission.
11855 * parameter.cs (Parameters.GetParameterInfo): New overloaded
11856 function that returns whether a parameter is an out/ref value or not.
11858 (Parameter.ParameterType): The type of the parameter (base,
11859 without ref/out applied).
11861 (Parameter.Resolve): Perform resolution here.
11862 (Parameter.ExternalType): The full type (with ref/out applied).
11864 * statement.cs (Using.Emit, Using.EmitExpression): Implement
11865 support for expressions on the using statement.
11867 2001-12-07 Miguel de Icaza <miguel@ximian.com>
11869 * statement.cs (Using.EmitLocalVariableDecls): Split the
11870 localvariable handling of the using statement.
11872 (Block.EmitMeta): Keep track of variable count across blocks. We
11873 were reusing slots on separate branches of blocks.
11875 (Try.Emit): Emit the general code block, we were not emitting it.
11877 Check the type of the declaration to be an IDisposable or
11878 something that can be implicity converted to it.
11880 Emit conversions if required.
11882 * ecore.cs (EmptyExpression): New utility class.
11883 (Expression.ImplicitConversionExists): New utility function.
11885 2001-12-06 Miguel de Icaza <miguel@ximian.com>
11887 * statement.cs (Using): Implement.
11889 * expression.cs (LocalVariableReference): Support read only variables.
11891 * statement.cs: Remove the explicit emit for the Leave opcode.
11892 (VariableInfo): Add a readonly field.
11894 2001-12-05 Miguel de Icaza <miguel@ximian.com>
11896 * ecore.cs (ConvCast): new class used to encapsulate the various
11897 explicit integer conversions that works in both checked and
11898 unchecked contexts.
11900 (Expression.ConvertNumericExplicit): Use new ConvCast class to
11901 properly generate the overflow opcodes.
11903 2001-12-04 Miguel de Icaza <miguel@ximian.com>
11905 * statement.cs: The correct type for the EmptyExpression is the
11906 element_type, not the variable type. Ravi pointed this out.
11908 2001-12-04 Ravi Pratap <ravi@ximian.com>
11910 * class.cs (Method::Define): Handle PInvoke methods specially
11911 by using DefinePInvokeMethod instead of the usual one.
11913 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
11914 above to do the task of extracting information and defining the method.
11916 2001-12-04 Ravi Pratap <ravi@ximian.com>
11918 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
11919 of the condition for string type.
11921 (Emit): Move that here.
11923 (ArrayCreation::CheckIndices): Keep string literals in their expression
11926 (EmitDynamicInitializers): Handle strings appropriately.
11928 2001-12-04 Miguel de Icaza <miguel@ximian.com>
11930 * codegen.cs (EmitContext): Replace multiple variables with a
11931 single pointer to the current Switch statement.
11933 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
11936 2001-12-03 Miguel de Icaza <miguel@ximian.com>
11940 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
11943 (Foreach.Emit): Foreach on arrays was not setting
11944 up the loop variables (for break/continue).
11946 (GotoCase): Semi-implented.
11948 2001-12-03 Ravi Pratap <ravi@ximian.com>
11950 * attribute.cs (CheckAttribute): Handle system attributes by using
11951 Attribute.GetAttributes to examine information we need.
11953 (GetValidPlaces): Same here.
11955 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
11957 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
11959 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
11961 (Method::Define): Set appropriate flags if we have a DllImport attribute.
11963 (Method::Emit): Handle the case when we are a PInvoke method.
11965 2001-12-03 Miguel de Icaza <miguel@ximian.com>
11967 * expression.cs: Use ResolveWithSimpleName on compound names.
11969 2001-12-02 Ravi Pratap <ravi@ximian.com>
11971 * constant.cs (EmitConstant): Make sure we resolve the associated expression
11972 before trying to reduce it.
11974 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
11976 * constant.cs (LookupConstantValue): Implement.
11978 (EmitConstant): Use the above in emitting the constant.
11980 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
11981 that are user-defined by doing a LookupConstantValue on them.
11983 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
11986 2001-11-29 Miguel de Icaza <miguel@ximian.com>
11988 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
11990 (BaseAccess.DoResolve): Implement.
11992 (MemberAccess.DoResolve): Split this routine into a
11993 ResolveMemberAccess routine that can be used independently
11995 2001-11-28 Miguel de Icaza <miguel@ximian.com>
11997 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
11998 As that share bits of the implementation. Is returns a boolean,
11999 while As returns the Type that is being probed.
12001 2001-12-01 Ravi Pratap <ravi@ximian.com>
12003 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
12004 instead of a Literal - much easier.
12006 (EnumInTransit): Remove - utterly useless :-)
12008 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
12010 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
12012 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
12013 chain when we have no associated expression.
12015 2001-11-30 Ravi Pratap <ravi@ximian.com>
12017 * constant.cs (Define): Use Location while reporting the errror.
12019 Also emit a warning when 'new' is used and there is no inherited
12022 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
12025 (LookupEnumValue): Implement to lookup an enum member's value and define it
12028 (Populate): Re-write accordingly to use the above routine.
12030 2001-11-27 Miguel de Icaza <miguel@ximian.com>
12032 * expression.cs (This): Fix prototype for DoResolveLValue to
12033 override the base class DoResolveLValue.
12035 * cs-parser.cs: Report errors cs574 and cs575 (destructor
12038 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
12039 (we need to load the address of the field here). This fixes
12042 (FieldExpr.DoResolveLValue): Call the DoResolve
12043 function to initialize the Instance expression.
12045 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
12046 correctly the GetEnumerator operation on a value type.
12048 * cs-parser.jay: Add more simple parsing error catches.
12050 * statement.cs (Switch): Add support for string switches.
12051 Handle null specially.
12053 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
12055 2001-11-28 Ravi Pratap <ravi@ximian.com>
12057 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
12059 (declare_local_constant): New helper function.
12061 * statement.cs (AddConstant): Keep a separate record of constants
12063 (IsConstant): Implement to determine if a variable is a constant.
12065 (GetConstantExpression): Implement.
12067 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
12069 * statement.cs (IsVariableDefined): Re-write.
12071 2001-11-27 Ravi Pratap <ravi@ximian.com>
12073 * class.cs (TypeContainer::FindMembers): Look for constants
12074 in the case when we are looking for MemberTypes.Field
12076 * expression.cs (MemberAccess::DoResolve): Check that in the
12077 case we are a FieldExpr and a Literal, we are not being accessed
12078 by an instance reference.
12080 * cs-parser.jay (local_constant_declaration): Implement.
12082 (declaration_statement): Implement for constant declarations.
12084 2001-11-26 Miguel de Icaza <miguel@ximian.com>
12086 * statement.cs (Switch): Catch double defaults.
12088 (Switch): More work on the switch() statement
12089 implementation. It works for integral values now, need to finish
12093 2001-11-24 Miguel de Icaza <miguel@ximian.com>
12095 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
12096 integer literals into other integer literals. To be used by
12099 2001-11-24 Ravi Pratap <ravi@ximian.com>
12101 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
12104 (EmitDynamicInitializers): Cope with the above since we extract data
12105 directly from ArrayData now.
12107 (ExpectInitializers): Keep track of whether initializers are mandatory
12110 (Bounds): Make it a hashtable to prevent the same dimension being
12111 recorded for every element in that dimension.
12113 (EmitDynamicInitializers): Fix bug which prevented the Set array method
12116 Also fix bug which was causing the indices to be emitted in the reverse
12119 2001-11-24 Miguel de Icaza <miguel@ximian.com>
12121 * expression.cs (ArrayCreation): Implement the bits that Ravi left
12122 unfinished. They do not work, because the underlying code is
12125 2001-11-22 Miguel de Icaza <miguel@ximian.com>
12127 * cs-parser.jay: Remove bogus fixme.
12129 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
12130 on Switch statement.
12132 2001-11-23 Ravi Pratap <ravi@ximian.com>
12134 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
12137 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
12138 parameter. Apparently, any expression is allowed.
12140 (ValidateInitializers): Update accordingly.
12142 (CheckIndices): Fix some tricky bugs thanks to recursion.
12144 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
12145 I was being completely brain-dead.
12147 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
12148 and re-write acordingly.
12150 (DelegateInvocation): Re-write accordingly.
12152 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
12154 (MakeByteBlob): Handle types more correctly.
12156 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
12157 initialization from expressions but it is incomplete because I am a complete
12160 2001-11-22 Miguel de Icaza <miguel@ximian.com>
12162 * statement.cs (If.Emit): Fix a bug that generated incorrect code
12163 on If. Basically, we have to return `true' (ie, we do return to
12164 our caller) only if both branches of the if return.
12166 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
12167 short-circuit operators, handle them as short circuit operators.
12169 (Cast.DoResolve): Resolve type.
12170 (Cast.Cast): Take an expression as the target type.
12172 * cs-parser.jay (cast_expression): Remove old hack that only
12173 allowed a limited set of types to be handled. Now we take a
12174 unary_expression and we resolve to a type during semantic
12177 Use the grammar productions from Rhys to handle casts (this is
12178 not complete like Rhys syntax yet, we fail to handle that corner
12179 case that C# has regarding (-x), but we will get there.
12181 2001-11-22 Ravi Pratap <ravi@ximian.com>
12183 * class.cs (EmitFieldInitializer): Take care of the case when we have a
12184 field which is an array type.
12186 * cs-parser.jay (declare_local_variables): Support array initialization too.
12188 * typemanager.cs (MakeKey): Implement.
12190 (everywhere): Use the above appropriately.
12192 * cs-parser.jay (for_statement): Update for array initialization while
12193 declaring variables.
12195 * ecore.cs : The error message was correct, it's the variable's names that
12196 were misleading ;-) Make the code more readable.
12198 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
12199 the correct type etc.
12201 (ConvertExplicit): Handle Enum types by examining the underlying type.
12203 2001-11-21 Ravi Pratap <ravi@ximian.com>
12205 * parameter.cs (GetCallingConvention): Always return
12206 CallingConventions.Standard for now.
12208 2001-11-22 Miguel de Icaza <miguel@ximian.com>
12210 * expression.cs (Binary.ResolveOperator): Update the values of `l'
12211 and `r' after calling DoNumericPromotions.
12213 * ecore.cs: Fix error message (the types were in the wrong order).
12215 * statement.cs (Foreach.ProbeCollectionType): Need to pass
12216 BindingFlags.Instance as well
12218 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
12219 implicit int literal conversion in an empty cast so that we
12220 propagate the right type upstream.
12222 (UnboxCast): new class used to unbox value types.
12223 (Expression.ConvertExplicit): Add explicit type conversions done
12226 (Expression.ImplicitNumericConversion): Oops, forgot to test for
12227 the target type before applying the implicit LongLiterals to ULong
12230 2001-11-21 Miguel de Icaza <miguel@ximian.com>
12232 * cs-parser.jay (for_statement): Reworked the way For works: now
12233 we declare manually any variables that are introduced in
12234 for_initializer to solve the problem of having out-of-band code
12235 emition (that is what got for broken).
12237 (declaration_statement): Perform the actual variable declaration
12238 that used to be done in local_variable_declaration here.
12240 (local_variable_declaration): Do not declare anything, just pass
12241 the information on a DictionaryEntry
12243 2001-11-20 Ravi Pratap <ravi@ximian.com>
12245 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
12246 re-write of the logic to now make it recursive.
12248 (UpdateIndices): Re-write accordingly.
12250 Store element data in a separate ArrayData list in the above methods.
12252 (MakeByteBlob): Implement to dump the array data into a byte array.
12254 2001-11-19 Ravi Pratap <ravi@ximian.com>
12256 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
12259 * constant.cs (Define): Implement.
12261 (EmitConstant): Re-write fully.
12263 Pass in location info.
12265 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
12268 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
12269 DictionaryEntry since we need location info too.
12271 (constant_declaration): Update accordingly.
12273 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
12274 code into another method : UpdateIndices.
12276 2001-11-18 Ravi Pratap <ravi@ximian.com>
12278 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
12279 some type checking etc.
12281 2001-11-17 Ravi Pratap <ravi@ximian.com>
12283 * expression.cs (ArrayCreation::ValidateInitializers): Implement
12284 bits to provide dimension info if the user skips doing that.
12286 Update second constructor to store the rank correctly.
12288 2001-11-16 Ravi Pratap <ravi@ximian.com>
12290 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
12291 and try to implement.
12293 * ../errors/cs0150.cs : Add.
12295 * ../errors/cs0178.cs : Add.
12297 2001-11-16 Miguel de Icaza <miguel@ximian.com>
12299 * statement.cs: Implement foreach on multi-dimensional arrays.
12301 * parameter.cs (Parameters.GetParameterByName): Also lookup the
12302 name of the params argument.
12304 * expression.cs: Use EmitStoreOpcode to get the right opcode while
12305 initializing the array.
12307 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
12308 we can use this elsewhere.
12310 * statement.cs: Finish implementation of foreach for single
12313 * cs-parser.jay: Use an out-of-band stack to pass information
12314 around, I wonder why I need this.
12316 foreach_block: Make the new foreach_block the current_block.
12318 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
12319 function used to return a static Parameters structure. Used for
12320 empty parameters, as those are created very frequently.
12322 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
12324 2001-11-15 Ravi Pratap <ravi@ximian.com>
12326 * interface.cs : Default modifier is private, not public. The
12327 make verify test passes again.
12329 2001-11-15 Ravi Pratap <ravi@ximian.com>
12331 * support.cs (ReflectionParameters): Fix logic to determine
12332 whether the last parameter is a params one. Test 9 passes again.
12334 * delegate.cs (Populate): Register the builders we define with
12335 RegisterParameterForBuilder. Test 19 passes again.
12337 * cs-parser.jay (property_declaration): Reference $6 instead
12338 of $$ to get at the location.
12340 (indexer_declaration): Similar stuff.
12342 (attribute): Ditto.
12344 * class.cs (Property): Register parameters for the Get and Set methods
12345 if they exist. Test 23 passes again.
12347 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
12348 call to EmitArguments as we are sure there aren't any params arguments.
12349 Test 32 passes again.
12351 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
12352 IndexOutOfRangeException.
12354 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
12355 Test 33 now passes again.
12357 2001-11-15 Miguel de Icaza <miguel@ximian.com>
12359 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
12360 broke a bunch of things. Will have to come up with a better way
12361 of tracking locations.
12363 * statement.cs: Implemented foreach for single dimension arrays.
12365 2001-11-09 Miguel de Icaza <miguel@ximian.com>
12367 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
12368 an error. This removes the lookup from the critical path.
12370 * cs-parser.jay: Removed use of temporary_loc, which is completely
12373 2001-11-14 Miguel de Icaza <miguel@ximian.com>
12375 * support.cs (ReflectionParameters.ParameterModifier): Report
12376 whether the argument is a PARAMS argument or not.
12378 * class.cs: Set the attribute `ParamArrayAttribute' on the
12379 parameter argument.
12381 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
12382 and cons_param_array_attribute (ConstructorInfo for
12383 ParamArrayAttribute).,
12385 * codegen.cs: Emit the return using the `Return' statement, that
12386 way we can report the error correctly for missing return values.
12388 * class.cs (Method.Emit): Clean up.
12390 * expression.cs (Argument.Resolve): Take another argument: the
12391 location where this argument is used. Notice that this is not
12392 part of the "Argument" class as to reduce the size of the
12393 structure (we know the approximate location anyways).
12395 Test if the argument is a variable-reference, if not, then
12396 complain with a 206.
12398 (Argument.Emit): Emit addresses of variables.
12400 (Argument.FullDesc): Simplify.
12402 (Invocation.DoResolve): Update for Argument.Resolve.
12404 (ElementAccess.DoResolve): ditto.
12406 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
12407 method should be virtual, as this method is always virtual.
12409 (NewDelegate.DoResolve): Update for Argument.Resolve.
12411 * class.cs (ConstructorInitializer.DoResolve): ditto.
12413 * attribute.cs (Attribute.Resolve): ditto.
12415 2001-11-13 Miguel de Icaza <miguel@ximian.com>
12417 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
12419 * expression.cs (ParameterReference): Drop IStackStorage and implement
12420 IAssignMethod instead.
12422 (LocalVariableReference): ditto.
12424 * ecore.cs (FieldExpr): Drop IStackStorage and implement
12425 IAssignMethod instead.
12427 2001-11-13 Miguel de Icaza <miguel@ximian.com>
12429 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
12430 enumerations that are used in heavily used structures derive from
12431 byte in a laughable and pathetic attempt to reduce memory usage.
12432 This is the kind of pre-optimzations that you should not do at
12433 home without adult supervision.
12435 * expression.cs (UnaryMutator): New class, used to handle ++ and
12436 -- separatedly from the other unary operators. Cleans up the
12437 code, and kills the ExpressionStatement dependency in Unary.
12439 (Unary): Removed `method' and `Arguments' from this class, making
12440 it smaller, and moving it all to SimpleCall, so I can reuse this
12441 code in other locations and avoid creating a lot of transient data
12442 strucutres when not required.
12444 * cs-parser.jay: Adjust for new changes.
12446 2001-11-11 Miguel de Icaza <miguel@ximian.com>
12448 * enum.cs (Enum.Populate): If there is a failure during
12451 * cs-parser.jay (opt_enum_base): we used to catch type errors
12452 here, but this is really incorrect. The type error should be
12453 catched during semantic analysis.
12455 2001-12-11 Ravi Pratap <ravi@ximian.com>
12457 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
12458 current_local_parameters as expected since I, in my stupidity, had forgotten
12461 * attribute.cs (GetValidPlaces): Fix stupid bug.
12463 * class.cs (Method::Emit): Perform check on applicability of attributes.
12465 (Constructor::Emit): Ditto.
12467 (Field::Emit): Ditto.
12469 (Field.Location): Store location information.
12471 (Property, Event, Indexer, Operator): Ditto.
12473 * cs-parser.jay (field_declaration): Pass in location for each field.
12475 * ../errors/cs0592.cs : Add.
12477 2001-11-12 Ravi Pratap <ravi@ximian.com>
12479 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
12481 (InitCoreTypes): Update accordingly.
12483 (RegisterAttrType, LookupAttr): Implement.
12485 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
12486 info about the same.
12488 (Resolve): Update to populate the above as necessary.
12490 (Error592): Helper.
12492 (GetValidPlaces): Helper to the above.
12494 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
12496 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
12498 2001-11-12 Ravi Pratap <ravi@ximian.com>
12500 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
12502 * ../errors/cs0617.cs : Add.
12504 2001-11-11 Ravi Pratap <ravi@ximian.com>
12506 * enum.cs (Emit): Rename to Populate to be more consistent with what
12507 we expect it to do and when exactly it is called.
12509 * class.cs, rootcontext.cs : Update accordingly.
12511 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
12512 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
12514 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
12516 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
12517 of a fieldinfo using the above, when dealing with a FieldBuilder.
12519 2001-11-10 Ravi Pratap <ravi@ximian.com>
12521 * ../errors/cs0031.cs : Add.
12523 * ../errors/cs1008.cs : Add.
12525 * ../errrors/cs0543.cs : Add.
12527 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
12530 (FindMembers): Implement.
12532 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
12533 enums and delegates too.
12535 (enum_types): Rename to builder_to_enum.
12537 (delegate_types): Rename to builder_to_delegate.
12539 * delegate.cs (FindMembers): Implement.
12541 2001-11-09 Ravi Pratap <ravi@ximian.com>
12543 * typemanager.cs (IsEnumType): Implement.
12545 * enum.cs (Emit): Re-write parts to account for the underlying type
12546 better and perform checking etc.
12548 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
12549 of the underlying type.
12551 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
12554 * enum.cs (error31): Helper to report error #31.
12556 * cs-parser.jay (enum_declaration): Store location of each member too.
12558 * enum.cs (member_to_location): New hashtable.
12560 (AddEnumMember): Update location hashtable.
12562 (Emit): Use the location of each member while reporting errors.
12564 2001-11-09 Miguel de Icaza <miguel@ximian.com>
12566 * cs-parser.jay: A for_initializer if is a
12567 local_variable_declaration really ammount to have an implicit
12568 block with the variable declaration and no initializer for for.
12570 * statement.cs (For.Emit): Cope with null initializers.
12572 This fixes the infinite loop on for initializers.
12574 2001-11-08 Miguel de Icaza <miguel@ximian.com>
12576 * enum.cs: More cleanup.
12578 * ecore.cs: Remove dead code.
12580 * class.cs (Property.Emit): More simplification.
12581 (Event.Emit): ditto.
12583 Reworked to have less levels of indentation.
12585 2001-11-08 Ravi Pratap <ravi@ximian.com>
12587 * class.cs (Property): Emit attributes.
12597 * enum.cs (Emit): Ditto.
12599 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
12602 * class.cs (Field, Event, etc.): Move attribute generation into the
12603 Emit method everywhere.
12605 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
12606 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
12607 as we had no way of defining nested enums !
12609 * rootcontext.cs : Adjust code accordingly.
12611 * typemanager.cs (AddEnumType): To keep track of enum types separately.
12613 2001-11-07 Ravi Pratap <ravi@ximian.com>
12615 * expression.cs (EvalConstantExpression): Move into ecore.cs
12617 * enum.cs (Enum): Rename some members and make them public and readonly
12618 according to our convention.
12620 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
12623 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
12625 (Enum::Emit): Write a simple version for now which doesn't try to compute
12626 expressions. I shall modify this to be more robust in just a while.
12628 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
12630 (TypeContainer::CloseType): Create the Enum types too.
12632 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
12634 * expression.cs (EvalConstantExpression): Get rid of completely.
12636 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
12637 user-defined values and other cases.
12639 (IsValidEnumLiteral): Helper function.
12641 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
12642 out there in the case we had a literal FieldExpr.
12644 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
12646 (Literalize): Revamp a bit to take two arguments.
12648 (EnumLiteral): New class which derives from Literal to wrap enum literals.
12650 2001-11-06 Ravi Pratap <ravi@ximian.com>
12652 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
12654 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
12656 (Resolve): Use the above to ensure we have proper initializers.
12658 2001-11-05 Ravi Pratap <ravi@ximian.com>
12660 * expression.cs (Expression::EvalConstantExpression): New method to
12661 evaluate constant expressions.
12663 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
12665 2001-11-07 Miguel de Icaza <miguel@ximian.com>
12667 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
12670 (Binary.ResolveOperator): Handle operator != (object a, object b)
12671 and operator == (object a, object b);
12673 (Binary.DoNumericPromotions): Indicate whether the numeric
12674 promotion was possible.
12676 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
12679 Made the ArrayAccess implement interface IAssignMethod instead of
12680 IStackStore as the order in which arguments are passed reflects
12683 * assign.cs: Instead of using expr.ExprClass to select the way of
12684 assinging, probe for the IStackStore/IAssignMethod interfaces.
12686 * typemanager.cs: Load InitializeArray definition.
12688 * rootcontext.cs (RootContext.MakeStaticData): Used to define
12689 static data that can be used to initialize arrays.
12691 2001-11-05 Miguel de Icaza <miguel@ximian.com>
12693 * expression.cs: Handle operator== and operator!= for booleans.
12695 (Conditioal.Reduce): Implement reducer for the ?: operator.
12697 (Conditional.Resolve): Implement dead code elimination.
12699 (Binary.Resolve): Catch string literals and return a new
12700 concatenated string.
12702 (Unary.Reduce): Implement reduction of unary expressions.
12704 * ecore.cs: Split out the expression core handling here.
12706 (Expression.Reduce): New method used to perform constant folding
12707 and CSE. This is needed to support constant-expressions.
12709 * statement.cs (Statement.EmitBoolExpression): Pass true and false
12710 targets, and optimize for !x.
12712 2001-11-04 Ravi Pratap <ravi@ximian.com>
12714 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
12715 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
12716 set custom atttributes.
12718 * literal.cs (Literal::GetValue): New abstract method to return the actual
12719 value of the literal, cast as an object.
12721 (*Literal): Implement GetValue method.
12723 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
12724 expressions to the arraylist but objects of type Argument.
12726 * class.cs (TypeContainer::Emit): Emit our attributes too.
12728 (Method::Emit, Constructor::Emit): Ditto.
12730 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
12731 to be ignoring earlier.
12733 2001-11-03 Ravi Pratap <ravi@ximian.com>
12735 * attribute.cs (AttributeSection::Define): Implement to do the business
12736 of constructing a CustomAttributeBuilder.
12738 (Attribute): New trivial class. Increases readability of code.
12740 * cs-parser.jay : Update accordingly.
12742 (positional_argument_list, named_argument_list, named_argument): New rules
12744 (attribute_arguments): Use the above so that we are more correct.
12746 2001-11-02 Ravi Pratap <ravi@ximian.com>
12748 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
12749 to perform all checks for a method with a params parameter.
12751 (Invocation::OverloadResolve): Update to use the above method and therefore
12752 cope correctly with params method invocations.
12754 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
12757 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
12758 constructors in our parent too because we can't afford to miss out on
12761 * attribute.cs (AttributeSection): New name for the class Attribute
12763 Other trivial changes to improve readability.
12765 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
12766 use the new class names.
12768 2001-11-01 Ravi Pratap <ravi@ximian.com>
12770 * class.cs (Method::Define): Complete definition for params types too
12772 (Indexer::Define): Ditto.
12774 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
12775 Cope everywhere with a request for info about the array parameter.
12777 2001-11-01 Ravi Pratap <ravi@ximian.com>
12779 * tree.cs (RecordNamespace): Fix up to check for the correct key.
12781 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
12782 local_variable_type to extract the string corresponding to the type.
12784 (local_variable_type): Fixup the action to use the new helper method.
12786 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
12789 * expression.cs : Clean out code which uses the above.
12791 2001-10-31 Ravi Pratap <ravi@ximian.com>
12793 * typemanager.cs (RegisterMethod): Check if we already have an existing key
12794 and bale out if necessary by returning a false.
12796 (RegisterProperty): Ditto.
12798 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
12799 and print out appropriate error messages.
12801 * interface.cs (everywhere): Ditto.
12803 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
12804 location to constructor.
12806 * class.cs (Property, Event, Indexer): Update accordingly.
12808 * ../errors/cs111.cs : Added.
12810 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
12811 of a method, as laid down by the spec.
12813 (Invocation::OverloadResolve): Use the above method.
12815 2001-10-31 Ravi Pratap <ravi@ximian.com>
12817 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
12818 now take a TypeContainer and a Parameters object.
12820 (ParameterData): Modify return type of ParameterModifier method to be
12821 Parameter.Modifier and not a string.
12823 (ReflectionParameters, InternalParameters): Update accordingly.
12825 * expression.cs (Argument::GetParameterModifier): Same here.
12827 * support.cs (InternalParameters::ParameterType): Find a better way of determining
12828 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
12829 symbol in it at all so maybe this is only for now.
12831 2001-10-30 Ravi Pratap <ravi@ximian.com>
12833 * support.cs (InternalParameters): Constructor now takes an extra argument
12834 which is the actual Parameters class.
12836 (ParameterDesc): Update to provide info on ref/out modifiers.
12838 * class.cs (everywhere): Update call to InternalParameters to pass in
12839 the second argument too.
12841 * support.cs (ParameterData): Add ParameterModifier, which is a method
12842 to return the modifier info [ref/out etc]
12844 (InternalParameters, ReflectionParameters): Implement the above.
12846 * expression.cs (Argument::ParameterModifier): Similar function to return
12847 info about the argument's modifiers.
12849 (Invocation::OverloadResolve): Update to take into account matching modifiers
12852 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
12853 a new SetFormalParameters object which we pass to InternalParameters.
12855 2001-10-30 Ravi Pratap <ravi@ximian.com>
12857 * expression.cs (NewArray): Merge into the ArrayCreation class.
12859 2001-10-29 Ravi Pratap <ravi@ximian.com>
12861 * expression.cs (NewArray): Merge classes NewBuiltinArray and
12862 NewUserdefinedArray into one as there wasn't much of a use in having
12865 * expression.cs (Argument): Change field's name to ArgType from Type.
12867 (Type): New readonly property which returns the proper type, taking into
12868 account ref/out modifiers.
12870 (everywhere): Adjust code accordingly for the above.
12872 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
12873 whether we are emitting for a ref or out parameter.
12875 * expression.cs (Argument::Emit): Use the above field to set the state.
12877 (LocalVariableReference::Emit): Update to honour the flag and emit the
12880 * parameter.cs (Attributes): Set the correct flags for ref parameters.
12882 * expression.cs (Argument::FullDesc): New function to provide a full desc.
12884 * support.cs (ParameterData): Add method ParameterDesc to the interface.
12886 (ReflectionParameters, InternalParameters): Implement the above method.
12888 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
12891 (Invocation::FullMethodDesc): Ditto.
12893 2001-10-29 Miguel de Icaza <miguel@ximian.com>
12895 * cs-parser.jay: Add extra production for the second form of array
12898 * expression.cs (ArrayCreation): Update to reflect the above
12901 * Small changes to prepare for Array initialization.
12903 2001-10-28 Miguel de Icaza <miguel@ximian.com>
12905 * typemanager.cs (ImplementsInterface): interface might be null;
12906 Deal with this problem;
12908 Also, we do store negative hits on the cache (null values), so use
12909 this instead of calling t.GetInterfaces on the type everytime.
12911 2001-10-28 Ravi Pratap <ravi@ximian.com>
12913 * typemanager.cs (IsBuiltinType): New method to help determine the same.
12915 * expression.cs (New::DoResolve): Get rid of array creation code and instead
12916 split functionality out into different classes.
12918 (New::FormArrayType): Move into NewBuiltinArray.
12920 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
12923 (NewBuiltinArray): New class to handle creation of built-in arrays.
12925 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
12926 account creation of one-dimensional arrays.
12928 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
12930 (NewUserdefinedArray::DoResolve): Implement.
12932 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
12934 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
12935 we maintain inside the TypeManager. This is necessary to perform lookups on the
12938 (LookupType): Update to perform GetType on the module builders too.
12940 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
12942 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
12944 2001-10-23 Ravi Pratap <ravi@ximian.com>
12946 * expression.cs (New::DoResolve): Implement guts of array creation.
12948 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
12950 2001-10-27 Miguel de Icaza <miguel@ximian.com>
12952 * expression.cs: Fix bug I introduced lsat night that broke
12955 (Expression.Resolve): Report a 246 error (can not resolve name)
12956 if we find a SimpleName in the stream.
12958 (Expression.ResolveLValue): Ditto.
12960 (Expression.ResolveWithSimpleName): This function is a variant of
12961 ResolveName, this one allows SimpleNames to be returned without a
12962 warning. The only consumer of SimpleNames is MemberAccess
12964 2001-10-26 Miguel de Icaza <miguel@ximian.com>
12966 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
12967 might arrive here. I have my doubts that this is correct.
12969 * statement.cs (Lock): Implement lock statement.
12971 * cs-parser.jay: Small fixes to support `lock' and `using'
12973 * cs-tokenizer.cs: Remove extra space
12975 * driver.cs: New flag --checked, allows to turn on integer math
12978 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
12979 Threading.Monitor.Exit
12981 2001-10-23 Miguel de Icaza <miguel@ximian.com>
12983 * expression.cs (IndexerAccess::DoResolveLValue): Set the
12984 Expression Class to be IndexerAccess.
12986 Notice that Indexer::DoResolve sets the eclass to Value.
12988 2001-10-22 Miguel de Icaza <miguel@ximian.com>
12990 * class.cs (TypeContainer::Emit): Emit code for indexers.
12992 * assign.cs (IAssignMethod): New interface implemented by Indexers
12993 and Properties for handling assignment.
12995 (Assign::Emit): Simplify and reuse code.
12997 * expression.cs (IndexerAccess, PropertyExpr): Implement
12998 IAssignMethod, clean up old code.
13000 2001-10-22 Ravi Pratap <ravi@ximian.com>
13002 * typemanager.cs (ImplementsInterface): New method to determine if a type
13003 implements a given interface. Provides a nice cache too.
13005 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
13008 (ConvertReferenceExplicit): Ditto.
13010 * delegate.cs (Delegate::Populate): Update to define the parameters on the
13011 various methods, with correct names etc.
13013 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
13014 Operator.UnaryNegation.
13016 * cs-parser.jay (operator_declarator): Be a little clever in the case where
13017 we have a unary plus or minus operator.
13019 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
13022 * everywhere : update accordingly.
13024 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
13027 * class.cs (Method::Define): For the case where we are implementing a method
13028 inherited from an interface, we need to set the MethodAttributes.Final flag too.
13029 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
13031 2001-10-21 Ravi Pratap <ravi@ximian.com>
13033 * interface.cs (FindMembers): Implement to work around S.R.E
13036 * typemanager.cs (IsInterfaceType): Implement.
13038 (FindMembers): Update to handle interface types too.
13040 * expression.cs (ImplicitReferenceConversion): Re-write bits which
13041 use IsAssignableFrom as that is not correct - it doesn't work.
13043 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
13044 and accordingly override EmitStatement.
13046 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
13047 using the correct logic :-)
13049 2001-10-19 Ravi Pratap <ravi@ximian.com>
13051 * ../errors/cs-11.cs : Add to demonstrate error -11
13053 2001-10-17 Miguel de Icaza <miguel@ximian.com>
13055 * assign.cs (Assign::Resolve): Resolve right hand side first, and
13056 then pass this as a hint to ResolveLValue.
13058 * expression.cs (FieldExpr): Add Location information
13060 (FieldExpr::LValueResolve): Report assignment to readonly
13063 (Expression::ExprClassFromMemberInfo): Pass location information.
13065 (Expression::ResolveLValue): Add new method that resolves an
13068 (Expression::DoResolveLValue): Default invocation calls
13071 (Indexers): New class used to keep track of indexers in a given
13074 (IStackStore): Renamed from LValue, as it did not really describe
13075 what this did. Also ResolveLValue is gone from this interface and
13076 now is part of Expression.
13078 (ElementAccess): Depending on the element access type
13080 * typemanager.cs: Add `indexer_name_type' as a Core type
13081 (System.Runtime.CompilerServices.IndexerNameAttribute)
13083 * statement.cs (Goto): Take a location.
13085 2001-10-18 Ravi Pratap <ravi@ximian.com>
13087 * delegate.cs (Delegate::VerifyDelegate): New method to verify
13088 if two delegates are compatible.
13090 (NewDelegate::DoResolve): Update to take care of the case when
13091 we instantiate a delegate from another delegate.
13093 * typemanager.cs (FindMembers): Don't even try to look up members
13094 of Delegate types for now.
13096 2001-10-18 Ravi Pratap <ravi@ximian.com>
13098 * delegate.cs (NewDelegate): New class to take care of delegate
13101 * expression.cs (New): Split the delegate related code out into
13102 the NewDelegate class.
13104 * delegate.cs (DelegateInvocation): New class to handle delegate
13107 * expression.cs (Invocation): Split out delegate related code into
13108 the DelegateInvocation class.
13110 2001-10-17 Ravi Pratap <ravi@ximian.com>
13112 * expression.cs (New::DoResolve): Implement delegate creation fully
13113 and according to the spec.
13115 (New::DoEmit): Update to handle delegates differently.
13117 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
13118 because of which we were printing out arguments in reverse order !
13120 * delegate.cs (VerifyMethod): Implement to check if the given method
13121 matches the delegate.
13123 (FullDelegateDesc): Implement.
13125 (VerifyApplicability): Implement.
13127 * expression.cs (Invocation::DoResolve): Update to accordingly handle
13128 delegate invocations too.
13130 (Invocation::Emit): Ditto.
13132 * ../errors/cs1593.cs : Added.
13134 * ../errors/cs1594.cs : Added.
13136 * delegate.cs (InstanceExpression, TargetMethod): New properties.
13138 2001-10-16 Ravi Pratap <ravi@ximian.com>
13140 * typemanager.cs (intptr_type): Core type for System.IntPtr
13142 (InitCoreTypes): Update for the same.
13144 (iasyncresult_type, asynccallback_type): Ditto.
13146 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
13149 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
13152 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
13153 the builders for the 4 members of a delegate type :-)
13155 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
13158 * expression.cs (New::DoResolve): Implement guts for delegate creation.
13160 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
13162 2001-10-15 Miguel de Icaza <miguel@ximian.com>
13164 * statement.cs (Break::Emit): Implement.
13165 (Continue::Emit): Implement.
13167 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
13168 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
13169 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
13170 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
13173 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
13174 properties that track the label for the current loop (begin of the
13175 loop and end of the loop).
13177 2001-10-15 Ravi Pratap <ravi@ximian.com>
13179 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
13180 use of emitting anything at all.
13182 * class.cs, rootcontext.cs : Get rid of calls to the same.
13184 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
13186 (Populate): Define the constructor correctly and set the implementation
13189 * typemanager.cs (delegate_types): New hashtable to hold delegates that
13192 (AddDelegateType): Implement.
13194 (IsDelegateType): Implement helper method.
13196 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
13198 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
13199 and accordingly handle it.
13201 * delegate.cs (Populate): Take TypeContainer argument.
13202 Implement bits to define the Invoke method. However, I still haven't figured out
13203 how to take care of the native int bit :-(
13205 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
13206 Qualify the name of the delegate, not its return type !
13208 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
13211 (StandardConversionExists): Checking for array types turns out to be recursive.
13213 (ConvertReferenceExplicit): Implement array conversion.
13215 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
13217 2001-10-12 Ravi Pratap <ravi@ximian.com>
13219 * cs-parser.jay (delegate_declaration): Store the fully qualified
13220 name as it is a type declaration.
13222 * delegate.cs (ReturnType, Name): Rename members to these. Make them
13225 (DefineDelegate): Renamed from Define. Does the same thing essentially,
13226 as TypeContainer::DefineType.
13228 (Populate): Method in which all the definition of the various methods (Invoke)
13231 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
13234 (CloseDelegate): Finally creates the delegate.
13236 * class.cs (TypeContainer::DefineType): Update to define delegates.
13237 (Populate, Emit and CloseType): Do the same thing here too.
13239 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
13240 delegates in all these operations.
13242 2001-10-14 Miguel de Icaza <miguel@ximian.com>
13244 * expression.cs: LocalTemporary: a new expression used to
13245 reference a temporary that has been created.
13247 * assign.cs: Handle PropertyAccess back here, so that we can
13248 provide the proper semantic access to properties.
13250 * expression.cs (Expression::ConvertReferenceExplicit): Implement
13251 a few more explicit conversions.
13253 * modifiers.cs: `NEW' modifier maps to HideBySig.
13255 * expression.cs (PropertyExpr): Make this into an
13256 ExpressionStatement, and support the EmitStatement code path.
13258 Perform get/set error checking, clean up the interface.
13260 * assign.cs: recognize PropertyExprs as targets, and if so, turn
13261 them into toplevel access objects.
13263 2001-10-12 Miguel de Icaza <miguel@ximian.com>
13265 * expression.cs: PropertyExpr::PropertyExpr: use work around the
13268 * typemanager.cs: Keep track here of our PropertyBuilders again to
13269 work around lameness in SRE.
13271 2001-10-11 Miguel de Icaza <miguel@ximian.com>
13273 * expression.cs (LValue::LValueResolve): New method in the
13274 interface, used to perform a second resolution pass for LValues.
13276 (This::DoResolve): Catch the use of this in static methods.
13278 (This::LValueResolve): Implement.
13280 (This::Store): Remove warning, assigning to `this' in structures
13283 (Invocation::Emit): Deal with invocation of
13284 methods on value types. We need to pass the address to structure
13285 methods rather than the object itself. (The equivalent code to
13286 emit "this" for structures leaves the entire structure on the
13287 stack instead of a pointer to it).
13289 (ParameterReference::DoResolve): Compute the real index for the
13290 argument based on whether the method takes or not a `this' pointer
13291 (ie, the method is static).
13293 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
13294 value types returned from functions when we need to invoke a
13295 method on the sturcture.
13298 2001-10-11 Ravi Pratap <ravi@ximian.com>
13300 * class.cs (TypeContainer::DefineType): Method to actually do the business of
13301 defining the type in the Modulebuilder or Typebuilder. This is to take
13302 care of nested types which need to be defined on the TypeBuilder using
13303 DefineNestedMethod.
13305 (TypeContainer::GetClassBases): Implement. Essentially the code from the
13306 methods in RootContext, only ported to be part of TypeContainer.
13308 (TypeContainer::GetInterfaceOrClass): Ditto.
13310 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
13312 * interface.cs (Interface::DefineInterface): New method. Does exactly
13313 what RootContext.CreateInterface did earlier, only it takes care of nested types
13316 (Interface::GetInterfaces): Move from RootContext here and port.
13318 (Interface::GetInterfaceByName): Same here.
13320 * rootcontext.cs (ResolveTree): Re-write.
13322 (PopulateTypes): Re-write.
13324 * class.cs (TypeContainer::Populate): Populate nested types too.
13325 (TypeContainer::Emit): Emit nested members too.
13327 * typemanager.cs (AddUserType): Do not make use of the FullName property,
13328 instead just use the name argument passed in as it is already fully
13331 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
13332 to TypeContainer mapping to see if a type is user-defined.
13334 * class.cs (TypeContainer::CloseType): Implement.
13336 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
13337 the default constructor.
13339 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
13342 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
13344 * interface.cs (CloseType): Create the type here.
13346 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
13349 Remove all the methods which are now in TypeContainer.
13351 2001-10-10 Ravi Pratap <ravi@ximian.com>
13353 * delegate.cs (Define): Re-write bits to define the delegate
13356 2001-10-10 Miguel de Icaza <miguel@ximian.com>
13358 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
13360 * expression.cs (ImplicitReferenceConversion): handle null as well
13361 as a source to convert to any reference type.
13363 * statement.cs (Return): Perform any implicit conversions to
13364 expected return type.
13366 Validate use of return statement.
13368 * codegen.cs (EmitContext): Pass the expected return type here.
13370 * class.cs (Method, Constructor, Property): Pass expected return
13371 type to EmitContext.
13373 2001-10-09 Miguel de Icaza <miguel@ximian.com>
13375 * expression.cs: Make DoResolve take an EmitContext instead of a
13378 Replaced `l' and `location' for `loc', for consistency.
13380 (Error, Warning): Remove unneeded Tc argument.
13382 * assign.cs, literal.cs, constant.cs: Update to new calling
13385 * codegen.cs: EmitContext now contains a flag indicating whether
13386 code is being generated in a static method or not.
13388 * cs-parser.jay: DecomposeQI, new function that replaces the old
13389 QualifiedIdentifier. Now we always decompose the assembled
13390 strings from qualified_identifier productions into a group of
13393 2001-10-08 Miguel de Icaza <miguel@ximian.com>
13395 * rootcontext.cs: Deal with field-less struct types correctly now
13396 by passing the size option to Define Type.
13398 * class.cs: Removed hack that created one static field.
13400 2001-10-07 Miguel de Icaza <miguel@ximian.com>
13402 * statement.cs: Moved most of the code generation here.
13404 2001-10-09 Ravi Pratap <ravi@ximian.com>
13406 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
13409 (ElementAccess): Remove useless bits for now - keep checks as the spec
13412 2001-10-08 Ravi Pratap <ravi@ximian.com>
13414 * expression.cs (ElementAccess::DoResolve): Remove my crap code
13415 and start performing checks according to the spec.
13417 2001-10-07 Ravi Pratap <ravi@ximian.com>
13419 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
13420 rank_specifiers instead.
13422 (rank_specifiers): Change the order in which the rank specifiers are stored
13424 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
13426 * expression.cs (ElementAccess): Implement the LValue interface too.
13428 2001-10-06 Ravi Pratap <ravi@ximian.com>
13430 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
13431 except that user defined conversions are not included.
13433 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
13434 perform the conversion of the return type, if necessary.
13436 (New::DoResolve): Check whether we are creating an array or an object
13437 and accordingly do the needful.
13439 (New::Emit): Same here.
13441 (New::DoResolve): Implement guts of array creation.
13443 (New::FormLookupType): Helper function.
13445 2001-10-07 Miguel de Icaza <miguel@ximian.com>
13447 * codegen.cs: Removed most of the code generation here, and move the
13448 corresponding code generation bits to the statement classes.
13450 Added support for try/catch/finalize and throw.
13452 * cs-parser.jay: Added support for try/catch/finalize.
13454 * class.cs: Catch static methods having the flags override,
13455 virtual or abstract.
13457 * expression.cs (UserCast): This user cast was not really doing
13458 what it was supposed to do. Which is to be born in fully resolved
13459 state. Parts of the resolution were being performed at Emit time!
13463 2001-10-05 Miguel de Icaza <miguel@ximian.com>
13465 * expression.cs: Implicity convert the result from UserCast.
13467 2001-10-05 Ravi Pratap <ravi@ximian.com>
13469 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
13470 prevented it from working correctly.
13472 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
13473 merely ConvertImplicit.
13475 2001-10-05 Miguel de Icaza <miguel@ximian.com>
13477 * typemanager.cs: Make the LookupTypeContainer function static,
13478 and not per-instance.
13480 * class.cs: Make static FindMembers (the one that takes a Type
13483 * codegen.cs: Add EmitForeach here.
13485 * cs-parser.jay: Make foreach a toplevel object instead of the
13486 inline expansion, as we need to perform semantic analysis on it.
13488 2001-10-05 Ravi Pratap <ravi@ximian.com>
13490 * expression.cs (Expression::ImplicitUserConversion): Rename to
13491 UserDefinedConversion.
13493 (Expression::UserDefinedConversion): Take an extra argument specifying
13494 whether we look for explicit user conversions too.
13496 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
13498 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
13500 (ExplicitUserConversion): Make it a call to UserDefinedConversion
13501 with the appropriate arguments.
13503 * cs-parser.jay (cast_expression): Record location too.
13505 * expression.cs (Cast): Record location info.
13507 (Expression::ConvertExplicit): Take location argument.
13509 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
13510 to determine if we are doing explicit conversions.
13512 (UserCast::Emit): Update accordingly.
13514 (Expression::ConvertExplicit): Report an error if everything fails.
13516 * ../errors/cs0030.cs : Add.
13518 2001-10-04 Miguel de Icaza <miguel@ximian.com>
13520 * modifiers.cs: If the ABSTRACT keyword is present, also set the
13521 virtual and newslot bits.
13523 * class.cs (TypeContainer::RegisterRequiredImplementations):
13524 Record methods we need.
13526 (TypeContainer::MakeKey): Helper function to make keys for
13527 MethodBases, since the Methodbase key is useless.
13529 (TypeContainer::Populate): Call RegisterRequiredImplementations
13530 before defining the methods.
13532 Create a mapping for method_builders_to_methods ahead of time
13533 instead of inside a tight loop.
13535 (::RequireMethods): Accept an object as the data to set into the
13536 hashtable so we can report interface vs abstract method mismatch.
13538 2001-10-03 Miguel de Icaza <miguel@ximian.com>
13540 * report.cs: Make all of it static.
13542 * rootcontext.cs: Drop object_type and value_type computations, as
13543 we have those in the TypeManager anyways.
13545 Drop report instance variable too, now it is a global.
13547 * driver.cs: Use try/catch on command line handling.
13549 Add --probe option to debug the error reporting system with a test
13552 * report.cs: Add support for exiting program when a probe
13553 condition is reached.
13555 2001-10-03 Ravi Pratap <ravi@ximian.com>
13557 * expression.cs (Binary::DoNumericPromotions): Fix the case when
13558 we do a forcible conversion regardless of type, to check if
13559 ForceConversion returns a null.
13561 (Binary::error19): Use location to report error.
13563 (Unary::error23): Use location here too.
13565 * ../errors/cs0019.cs : Check in.
13567 * ../errors/cs0023.cs : Check in.
13569 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
13570 case of a non-null MethodInfo object with a length of 0 !
13572 (Binary::ResolveOperator): Flag error if overload resolution fails to find
13573 an applicable member - according to the spec :-)
13574 Also fix logic to find members in base types.
13576 (Unary::ResolveOperator): Same here.
13578 (Unary::report23): Change name to error23 and make first argument a TypeContainer
13579 as I was getting thoroughly confused between this and error19 :-)
13581 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
13582 (::FindMostEncompassedType): Implement.
13583 (::FindMostEncompassingType): Implement.
13584 (::StandardConversionExists): Implement.
13586 (UserImplicitCast): Re-vamp. We now need info about most specific
13587 source and target types so that we can do the necessary conversions.
13589 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
13590 mathematical union with no duplicates.
13592 2001-10-03 Miguel de Icaza <miguel@ximian.com>
13594 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
13595 in order from base classes to child classes, so that we can in
13596 child classes look up in our parent for method names and
13597 attributes (required for handling abstract, virtual, new, override
13598 constructs: we need to instrospect our base class, and if we dont
13599 populate the classes in order, the introspection might be
13600 incorrect. For example, a method could query its parent before
13601 the parent has any methods and would determine that the parent has
13602 no abstract methods (while it could have had them)).
13604 (RootContext::CreateType): Record the order in which we define the
13607 2001-10-02 Miguel de Icaza <miguel@ximian.com>
13609 * class.cs (TypeContainer::Populate): Also method definitions can
13610 fail now, keep track of this.
13612 (TypeContainer::FindMembers): Implement support for
13613 DeclaredOnly/noDeclaredOnly flag.
13615 (Constructor::Emit) Return the ConstructorBuilder.
13617 (Method::Emit) Return the MethodBuilder.
13618 Check for abstract or virtual methods to be public.
13620 * rootcontext.cs (RootContext::CreateType): Register all the
13621 abstract methods required for the class to be complete and the
13622 interface methods that must be implemented.
13624 * cs-parser.jay: Report error 501 (method requires body if it is
13625 not marked abstract or extern).
13627 * expression.cs (TypeOf::Emit): Implement.
13629 * typemanager.cs: runtime_handle_type, new global type.
13631 * class.cs (Property::Emit): Generate code for properties.
13633 2001-10-02 Ravi Pratap <ravi@ximian.com>
13635 * expression.cs (Unary::ResolveOperator): Find operators on base type
13636 too - we now conform exactly to the spec.
13638 (Binary::ResolveOperator): Same here.
13640 * class.cs (Operator::Define): Fix minor quirk in the tests.
13642 * ../errors/cs0215.cs : Added.
13644 * ../errors/cs0556.cs : Added.
13646 * ../errors/cs0555.cs : Added.
13648 2001-10-01 Miguel de Icaza <miguel@ximian.com>
13650 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
13651 single integer which is really efficient
13653 2001-10-01 Ravi Pratap <ravi@ximian.com>
13655 * expression.cs (Expression::ImplicitUserConversion): Use location
13656 even in the case when we are examining True operators.
13658 * class.cs (Operator::Define): Perform extensive checks to conform
13659 with the rules for operator overloading in the spec.
13661 * expression.cs (Expression::ImplicitReferenceConversion): Implement
13662 some of the other conversions mentioned in the spec.
13664 * typemanager.cs (array_type): New static member for the System.Array built-in
13667 (cloneable_interface): For System.ICloneable interface.
13669 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
13670 we start resolving the tree and populating types.
13672 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
13674 2001-10-01 Miguel de Icaza <miguel@ximian.com>
13676 * expression.cs (Expression::ExprClassFromMemberInfo,
13677 Expression::Literalize): Create literal expressions from
13678 FieldInfos which are literals.
13680 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
13681 type casts, because they were wrong. The test suite in tests
13684 (ImplicitNumericConversion): ushort to ulong requires a widening
13687 Int32 constant to long requires widening cast as well.
13689 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
13690 for integers because the type on the stack is not i4.
13692 2001-09-30 Miguel de Icaza <miguel@ximian.com>
13694 * expression.cs (report118): require location argument.
13696 * parameter.cs: Do not dereference potential null value.
13698 * class.cs: Catch methods that lack the `new' keyword when
13699 overriding a name. Report warnings when `new' is used without
13700 anything being there to override.
13702 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
13704 * class.cs: Only add constructor to hashtable if it is non-null
13705 (as now constructors can fail on define).
13707 (TypeManager, Class, Struct): Take location arguments.
13709 Catch field instance initialization in structs as errors.
13711 accepting_filter: a new filter for FindMembers that is static so
13712 that we dont create an instance per invocation.
13714 (Constructor::Define): Catch errors where a struct constructor is
13717 * cs-parser.jay: Pass location information for various new
13720 * delegate.cs (Delegate): take a location argument.
13722 * driver.cs: Do not call EmitCode if there were problesm in the
13723 Definition of the types, as many Builders wont be there.
13725 * decl.cs (Decl::Decl): Require a location argument.
13727 * cs-tokenizer.cs: Handle properly hex constants that can not fit
13728 into integers, and find the most appropiate integer for it.
13730 * literal.cs: Implement ULongLiteral.
13732 * rootcontext.cs: Provide better information about the location of
13733 failure when CreateType fails.
13735 2001-09-29 Miguel de Icaza <miguel@ximian.com>
13737 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
13740 * expression.cs (Binary::CheckShiftArguments): Add missing type
13742 (Binary::ResolveOperator): Add type to the logical and and logical
13743 or, Bitwise And/Or and Exclusive Or code paths, it was missing
13746 (Binary::DoNumericPromotions): In the case where either argument
13747 is ulong (and most signed types combined with ulong cause an
13748 error) perform implicit integer constant conversions as well.
13750 2001-09-28 Miguel de Icaza <miguel@ximian.com>
13752 * expression.cs (UserImplicitCast): Method should always be
13754 (Invocation::BetterConversion): Simplified test for IntLiteral.
13756 (Expression::ImplicitNumericConversion): Split this routine out.
13757 Put the code that performs implicit constant integer conversions
13760 (Expression::Resolve): Become a wrapper around DoResolve so we can
13761 check eclass and type being set after resolve.
13763 (Invocation::Badness): Remove this dead function
13765 (Binary::ResolveOperator): Do not compute the expensive argumnets
13766 unless we have a union for it.
13768 (Probe::Emit): Is needs to do an isinst and then
13769 compare against null.
13771 (::CanConvert): Added Location argument. If the Location argument
13772 is null (Location.Null), then we do not report errors. This is
13773 used by the `probe' mechanism of the Explicit conversion. We do
13774 not want to generate an error for something that the user
13775 explicitly requested to be casted. But the pipeline for an
13776 explicit cast first tests for potential implicit casts.
13778 So for now, if the Location is null, it means `Probe only' to
13779 avoid adding another argument. Might have to revise this
13782 (ClassCast): New class used to type cast objects into arbitrary
13783 classes (used in Explicit Reference Conversions).
13785 Implement `as' as well.
13787 Reverted all the patches from Ravi below: they were broken:
13789 * The use of `level' as a mechanism to stop recursive
13790 invocations is wrong. That was there just to catch the
13791 bug with a strack trace but not as a way of addressing
13794 To fix the problem we have to *understand* what is going
13795 on and the interactions and come up with a plan, not
13796 just get things going.
13798 * The use of the type conversion cache that I proposed
13799 last night had an open topic: How does this work across
13800 protection domains. A user defined conversion might not
13801 be public in the location where we are applying the
13802 conversion, a different conversion might be selected
13803 (ie, private A->B (better) but public B->A (worse),
13804 inside A, A->B applies, but outside it, B->A will
13807 * On top of that (ie, even if the above is solved),
13808 conversions in a cache need to be abstract. Ie, `To
13809 convert from an Int to a Short use an OpcodeCast', not
13810 `To convert from an Int to a Short use the OpcodeCast on
13811 the variable 5' (which is what this patch was doing).
13813 2001-09-28 Ravi Pratap <ravi@ximian.com>
13815 * expression.cs (Invocation::ConversionExists): Re-write to use
13816 the conversion cache
13818 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
13819 cache all conversions done, not just user-defined ones.
13821 (Invocation::BetterConversion): The real culprit. Use ConversionExists
13822 to determine if a conversion exists instead of acutually trying to
13823 perform the conversion. It's faster too.
13825 (Expression::ConvertExplicit): Modify to use ConversionExists to check
13826 and only then attempt the implicit conversion.
13828 2001-09-28 Ravi Pratap <ravi@ximian.com>
13830 * expression.cs (ConvertImplicit): Use a cache for conversions
13831 already found. Check level of recursion and bail out if necessary.
13833 2001-09-28 Miguel de Icaza <miguel@ximian.com>
13835 * typemanager.cs (string_concat_string_string, string_concat_object_object):
13836 Export standard methods that we expect for string operations.
13838 * statement.cs (Block::UsageWarning): Track usage of variables and
13839 report the errors for not used variables.
13841 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
13844 2001-09-27 Miguel de Icaza <miguel@ximian.com>
13846 * codegen.cs: remove unnneded code
13848 * expression.cs: Removed BuiltinTypeAccess class
13850 Fix the order in which implicit conversions are
13853 The previous fixed dropped support for boxed conversions (adding a
13854 test to the test suite now)
13856 (UserImplicitCast::CanConvert): Remove test for source being null,
13857 that code is broken. We should not feed a null to begin with, if
13858 we do, then we should track the bug where the problem originates
13859 and not try to cover it up here.
13861 Return a resolved expression of type UserImplicitCast on success
13862 rather than true/false. Ravi: this is what I was talking about,
13863 the pattern is to use a static method as a "constructor" for
13866 Also, do not create arguments until the very last minute,
13867 otherwise we always create the arguments even for lookups that
13868 will never be performed.
13870 (UserImplicitCast::Resolve): Eliminate, objects of type
13871 UserImplicitCast are born in a fully resolved state.
13873 * typemanager.cs (InitCoreTypes): Init also value_type
13874 (System.ValueType).
13876 * expression.cs (Cast::Resolve): First resolve the child expression.
13878 (LValue): Add new method AddressOf to be used by
13881 Change the argument of Store to take an EmitContext instead of an
13882 ILGenerator, because things like FieldExpr need to be able to call
13883 their children expression to generate the instance code.
13885 (Expression::Error, Expression::Warning): Sugar functions for
13888 (Expression::MemberLookup): Accept a TypeContainer instead of a
13889 Report as the first argument.
13891 (Expression::ResolvePrimary): Killed. I still want to improve
13892 this as currently the code is just not right.
13894 (Expression::ResolveMemberAccess): Simplify, but it is still
13897 (Unary::Resolve): Catch errors in AddressOf operators.
13899 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
13900 index to a byte for the short-version, or the compiler will choose
13901 the wrong Emit call, which generates the wrong data.
13903 (ParameterReference::Emit, ::Store): same.
13905 (FieldExpr::AddressOf): Implement.
13907 * typemanager.cs: TypeManager: made public variable instead of
13910 * driver.cs: document --fatal.
13912 * report.cs (ErrorMessage, WarningMessage): new names for the old
13913 Error and Warning classes.
13915 * cs-parser.jay (member_access): Turn built-in access to types
13916 into a normal simplename
13918 2001-09-27 Ravi Pratap <ravi@ximian.com>
13920 * expression.cs (Invocation::BetterConversion): Fix to cope
13921 with q being null, since this was introducing a bug.
13923 * expression.cs (ConvertImplicit): Do built-in conversions first.
13925 2001-09-27 Ravi Pratap <ravi@ximian.com>
13927 * expression.cs (UserImplicitCast::Resolve): Fix bug.
13929 2001-09-27 Ravi Pratap <ravi@ximian.com>
13931 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
13932 I had introduced long ago (what's new ?).
13934 * expression.cs (UserImplicitCast::CanConvert): Static method to do
13935 the work of all the checking.
13936 (ConvertImplicit): Call CanConvert and only then create object if necessary.
13937 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
13939 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
13940 that is the right way.
13942 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
13943 overloading resolution. Use everywhere instead of cutting and pasting code.
13945 (Binary::ResolveOperator): Use MakeUnionSet.
13947 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
13948 we have to convert to bool types. Not complete yet.
13950 2001-09-27 Miguel de Icaza <miguel@ximian.com>
13952 * typemanager.cs (TypeManager::CSharpName): support ushort.
13954 * expression.cs (Expression::TryImplicitIntConversion): Attempts
13955 to provide an expression that performsn an implicit constant int
13956 conversion (section 6.1.6).
13957 (Expression::ConvertImplicitRequired): Reworked to include
13958 implicit constant expression conversions.
13960 (Expression::ConvertNumericExplicit): Finished.
13962 (Invocation::Emit): If InstanceExpression is null, then it means
13963 that we perform a call on this.
13965 2001-09-26 Miguel de Icaza <miguel@ximian.com>
13967 * expression.cs (Unary::Emit): Remove some dead code.
13968 (Probe): Implement Resolve and Emit for `is'.
13969 (Expression::ConvertImplicitRequired): Attempt to do constant
13970 expression conversions here. Maybe should be moved to
13971 ConvertImplicit, but I am not sure.
13972 (Expression::ImplicitLongConstantConversionPossible,
13973 Expression::ImplicitIntConstantConversionPossible): New functions
13974 that tell whether is it possible to apply an implicit constant
13975 expression conversion.
13977 (ConvertNumericExplicit): Started work on explicit numeric
13980 * cs-parser.jay: Update operator constants.
13982 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
13983 (Parameters::GetSignature): Hook up VerifyArgs here.
13984 (Parameters::VerifyArgs): Verifies that no two arguments have the
13987 * class.cs (Operator): Update the operator names to reflect the
13988 ones that the spec expects (as we are just stringizing the
13991 * expression.cs (Unary::ResolveOperator): Fix bug: Use
13992 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
13993 previous usage did only work for our methods.
13994 (Expression::ConvertImplicit): Handle decimal implicit numeric
13995 conversions as well.
13996 (Expression::InternalTypeConstructor): Used to invoke constructors
13997 on internal types for default promotions.
13999 (Unary::Emit): Implement special handling for the pre/post
14000 increment/decrement for overloaded operators, as they need to have
14001 the same semantics as the other operators.
14003 (Binary::ResolveOperator): ditto.
14004 (Invocation::ConversionExists): ditto.
14005 (UserImplicitCast::Resolve): ditto.
14007 2001-09-26 Ravi Pratap <ravi@ximian.com>
14009 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
14010 operator, return after emitting body. Regression tests pass again !
14012 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
14013 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
14014 (Invocation::OverloadResolve): Ditto.
14015 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
14017 * everywhere : update calls to the above methods accordingly.
14019 2001-09-26 Miguel de Icaza <miguel@ximian.com>
14021 * assign.cs (Assign): Make it inherit from ExpressionStatement.
14023 * expression.cs (ExpressionStatement): New base class used for
14024 expressions that can appear in statements, so that we can provide
14025 an alternate path to generate expression that do not leave a value
14028 (Expression::Emit, and all the derivatives): We no longer return
14029 whether a value is left on the stack or not. Every expression
14030 after being emitted leaves a single value on the stack.
14032 * codegen.cs (EmitContext::EmitStatementExpression): Use the
14033 facilties of ExpressionStatement if possible.
14035 * cs-parser.jay: Update statement_expression.
14037 2001-09-25 Miguel de Icaza <miguel@ximian.com>
14039 * driver.cs: Change the wording of message
14041 2001-09-25 Ravi Pratap <ravi@ximian.com>
14043 * expression.cs (Binary::ResolveOperator): Had forgottten to set
14044 the type of the expression to the return type of the method if
14045 we have an overloaded operator match ! The regression tests pass again !
14046 (Unary::ResolveOperator): Ditto.
14048 * expression.cs (Invocation::ConversionExists): Correct the member lookup
14049 to find "op_Implicit", not "implicit" ;-)
14050 (UserImplicitCast): New class to take care of user-defined implicit conversions.
14051 (ConvertImplicit, ForceConversion): Take TypeContainer argument
14053 * everywhere : Correct calls to the above accordingly.
14055 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
14056 (ConvertImplicit): Do user-defined conversion if it exists.
14058 2001-09-24 Miguel de Icaza <miguel@ximian.com>
14060 * assign.cs: track location.
14061 (Resolve): Use implicit conversions on assignment.
14063 * literal.cs: Oops. Not good, Emit of short access values should
14064 pass (Bytes) or the wrong argument will be selected.
14066 * expression.cs (Unary::Emit): Emit code for -expr.
14068 (Unary::ResolveOperator): Handle `Substract' for non-constants
14069 (substract from zero from the non-constants).
14070 Deal with Doubles as well.
14072 (Expression::ConvertImplicitRequired): New routine that reports an
14073 error if no implicit conversion exists.
14075 (Invocation::OverloadResolve): Store the converted implicit
14076 expressions if we make them
14078 2001-09-24 Ravi Pratap <ravi@ximian.com>
14080 * class.cs (ConstructorInitializer): Take a Location argument.
14081 (ConstructorBaseInitializer): Same here.
14082 (ConstructorThisInitializer): Same here.
14084 * cs-parser.jay : Update all calls accordingly.
14086 * expression.cs (Unary, Binary, New): Take location argument.
14087 Update accordingly everywhere.
14089 * cs-parser.jay : Update all calls to the above to take a location
14092 * class.cs : Ditto.
14094 2001-09-24 Ravi Pratap <ravi@ximian.com>
14096 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
14097 (Invocation::BetterConversion): Same here
14098 (Invocation::ConversionExists): Ditto.
14100 (Invocation::ConversionExists): Implement.
14102 2001-09-22 Ravi Pratap <ravi@ximian.com>
14104 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
14105 Also take an additional TypeContainer argument.
14107 * All over : Pass in TypeContainer as argument to OverloadResolve.
14109 * typemanager.cs (CSharpName): Update to check for the string type and return
14112 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
14115 2001-09-21 Ravi Pratap <ravi@ximian.com>
14117 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
14118 (Invocation::BetterFunction): Implement.
14119 (Invocation::BetterConversion): Implement.
14120 (Invocation::ConversionExists): Skeleton, no implementation yet.
14122 Okay, things work fine !
14124 2001-09-21 Miguel de Icaza <miguel@ximian.com>
14126 * typemanager.cs: declare and load enum_type, delegate_type and
14129 * expression.cs (Expression::Emit): Now emit returns a value that
14130 tells whether a value is left on the stack or not. This strategy
14131 might be reveted tomorrow with a mechanism that would address
14132 multiple assignments.
14133 (Expression::report118): Utility routine to report mismatches on
14136 (Unary::Report23): Report impossible type/operator combination
14139 (Unary::IsIncrementableNumber): Whether the type can be
14140 incremented or decremented with add.
14141 (Unary::ResolveOperator): Also allow enumerations to be bitwise
14143 (Unary::ResolveOperator): Implement ++, !, ~,
14145 (Invocation::Emit): Deal with new Emit convetion.
14147 * All Expression derivatives: Updated their Emit method to return
14148 whether they leave values on the stack or not.
14150 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
14151 stack for expressions that are statements.
14153 2001-09-20 Miguel de Icaza <miguel@ximian.com>
14155 * expression.cs (LValue): New interface. Must be implemented by
14157 (LocalVariableReference, ParameterReference, FieldExpr): Implement
14160 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
14161 interface for generating code, simplifies the code.
14163 2001-09-20 Ravi Pratap <ravi@ximian.com>
14165 * expression.cs (everywhere): Comment out return statements in ::Resolve
14166 methods to avoid the warnings.
14168 2001-09-20 Miguel de Icaza <miguel@ximian.com>
14170 * driver.cs (parse): Report error 2001 if we can not open the
14173 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
14176 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
14179 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
14180 otherwise nested blocks end up with the same index.
14182 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
14184 * expression.cs: Instead of having FIXMEs in the Resolve
14185 functions, throw exceptions so it is obvious that we are facing a
14188 * cs-parser.jay (invocation_expression): Pass Location information.
14190 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
14191 Use a basename for those routines because .NET does not like paths
14194 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
14197 2001-09-19 Miguel de Icaza <miguel@ximian.com>
14199 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
14200 are loading the correct data types (throws an exception if not).
14201 (TypeManager::InitCoreTypes): Use CoreLookupType
14203 * expression.cs (Unary::ResolveOperator): return the child
14204 expression for expressions which are just +expr.
14205 (Unary::ResolveOperator): Return negative literals for -LITERAL
14206 expressions (otherwise they are Unary {Literal}).
14207 (Invocation::Badness): Take into account `Implicit constant
14208 expression conversions'.
14210 * literal.cs (LongLiteral): Implement long literal class.
14211 (IntLiteral): export the `Value' of the intliteral.
14213 2001-09-19 Ravi Pratap <ravi@ximian.com>
14215 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
14217 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
14218 instead of 'Operator'
14220 * expression.cs (Binary::ResolveOperator): Update accordingly.
14221 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
14224 * cs-parser.jay (unary_expression): Update to use the new names.
14226 * gen-treedump.cs (GetUnary): Same here.
14228 * expression.cs (Unary::Resolve): Implement.
14229 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
14230 operators are found instead of making noise ;-)
14231 (Unary::ResolveOperator): New method to do precisely the same thing which
14232 Binary::ResolveOperator does for Binary expressions.
14233 (Unary.method, .Arguments): Add.
14234 (Unary::OperName): Implement.
14235 (Unary::ForceConversion): Copy and Paste !
14237 * class.cs (Operator::Define): Fix a small bug for the case when we have
14240 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
14241 for the inbuilt operators. Only overloading works for now ;-)
14243 2001-09-18 Miguel de Icaza <miguel@ximian.com>
14245 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
14246 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
14248 * expression.cs (This::Emit): Implement.
14249 (This::Resolve): Implement.
14250 (TypeOf:Resolve): Implement.
14251 (Expression::ResolveSimpleName): Add an implicit this to instance
14253 (MemberAccess::Resolve): Deal with Parameters and Fields.
14254 Bind instance variable to Field expressions.
14255 (FieldExpr::Instance): New field used to track the expression that
14256 represents the object instance.
14257 (FieldExpr::Resolve): Track potential errors from MemberLookup not
14259 (FieldExpr::Emit): Implement.
14261 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
14262 the last instruction contains a return opcode to avoid generating
14263 the last `ret' instruction (this generates correct code, and it is
14264 nice to pass the peverify output).
14266 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
14267 initializer for static and instance variables.
14268 (Constructor::Emit): Allow initializer to be null in the case of
14269 static constructors. Only emit initializer for instance
14272 (TypeContainer::FindMembers): Return a null array if there are no
14275 Also fix the code for the MemberTypes.Method branch, as it was not
14276 scanning that for operators (or tried to access null variables before).
14278 * assign.cs (Assign::Emit): Handle instance and static fields.
14282 * driver.cs: Stop compilation if there are parse errors.
14284 * cs-parser.jay (constructor_declaration): Provide default base
14285 initializer for non-static constructors.
14286 (constructor_declarator): Do not provide a default base
14287 initializers if none was specified.
14288 Catch the fact that constructors should not have parameters.
14290 * class.cs: Do not emit parent class initializers for static
14291 constructors, that should be flagged as an error.
14293 2001-09-18 Ravi Pratap <ravi@ximian.com>
14295 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
14296 Move back code into TypeContainer::Populate.
14298 2001-09-18 Ravi Pratap <ravi@ximian.com>
14300 * class.cs (TypeContainer::AddConstructor): Fix the check to
14301 compare against Name, not Basename.
14302 (Operator::OpType): Change Plus and Minus to Add and Subtract.
14304 * cs-parser.jay : Update accordingly.
14306 * class.cs (TypeContainer::FindMembers): For the case where we are searching
14307 for methods, don't forget to look into the operators too.
14308 (RegisterMethodBuilder): Helper method to take care of this for
14309 methods, constructors and operators.
14310 (Operator::Define): Completely revamp.
14311 (Operator.OperatorMethod, MethodName): New fields.
14312 (TypeContainer::Populate): Move the registering of builders into
14313 RegisterMethodBuilder.
14314 (Operator::Emit): Re-write.
14316 * expression.cs (Binary::Emit): Comment out code path to emit method
14317 invocation stuff for the case when we have a user defined operator. I am
14318 just not able to get it right !
14320 2001-09-17 Miguel de Icaza <miguel@ximian.com>
14322 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
14325 (Expression::MemberLookup): Provide a version that allows to
14326 specify the MemberTypes and BindingFlags.
14328 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
14329 so it was not fetching variable information from outer blocks.
14331 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
14332 Beforefieldinit as it was buggy.
14334 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
14335 that Ravi put here.
14337 * class.cs (Constructor::Emit): Only emit if block is not null.
14338 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
14339 deal with this by semantically definining it as if the user had
14342 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
14343 constructors as we now "emit" them at a higher level.
14345 (TypeContainer::DefineDefaultConstructor): Used to define the
14346 default constructors if none was provided.
14348 (ConstructorInitializer): Add methods Resolve and Emit.
14350 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
14352 2001-09-17 Ravi Pratap <ravi@ximian.com>
14354 * class.cs (TypeContainer::EmitDefaultConstructor): Register
14355 the default constructor builder with our hashtable for methodbuilders
14358 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
14359 and argument_count is 0 in which case we have a match.
14360 (Binary::ResolveOperator): More null checking and miscellaneous coding
14363 2001-09-17 Ravi Pratap <ravi@ximian.com>
14365 * rootcontext.cs (IsNameSpace): Compare against null.
14367 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
14369 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
14370 and Unary::Operator.
14372 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
14375 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
14376 we have overloaded operators.
14377 (Binary::ResolveOperator): Implement the part which does the operator overload
14380 * class.cs (Operator::Emit): Implement.
14381 (TypeContainer::Emit): Emit the operators we have too.
14383 * expression.cs (Binary::Emit): Update to emit the appropriate code for
14384 the case when we have a user-defined operator.
14386 2001-09-17 Miguel de Icaza <miguel@ximian.com>
14388 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
14390 2001-09-16 Ravi Pratap <ravi@ximian.com>
14392 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
14393 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
14394 (Constructor::Emit): Implement.
14395 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
14396 if we have no work to do.
14397 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
14400 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
14401 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
14403 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
14406 2001-09-15 Ravi Pratap <ravi@ximian.com>
14408 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
14410 (Tree::RecordNamespace): Method to do what the name says ;-)
14411 (Tree::Namespaces): Property to get at the namespaces hashtable.
14413 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
14416 * rootcontext.cs (IsNamespace): Fixed it :-)
14418 2001-09-14 Miguel de Icaza <miguel@ximian.com>
14420 * class.cs (TypeContainer::FindMembers): Add support for
14422 (MethodCore): New class that encapsulates both the shared aspects
14423 of a Constructor and a Method.
14424 (Method, Constructor): Factored pieces into MethodCore.
14426 * driver.cs: Added --fatal which makes errors throw exceptions.
14427 Load System assembly as well as part of the standard library.
14429 * report.cs: Allow throwing exceptions on errors for debugging.
14431 * modifiers.cs: Do not use `parent', instead use the real type
14432 container to evaluate permission settings.
14434 * class.cs: Put Ravi's patch back in. He is right, and we will
14435 have to cope with the
14437 2001-09-14 Ravi Pratap <ravi@ximian.com>
14439 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
14440 FamORAssem, not FamANDAssem.
14442 2001-09-14 Miguel de Icaza <miguel@ximian.com>
14444 * driver.cs: Added --parse option that only parses its input files
14447 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
14448 incorrect. IsTopLevel is not used to tell whether an object is
14449 root_types or not (that can be achieved by testing this ==
14450 root_types). But to see if this is a top-level *class* (not
14451 necessarly our "toplevel" container).
14453 2001-09-14 Ravi Pratap <ravi@ximian.com>
14455 * enum.cs (Enum::Define): Modify to call the Lookup method on the
14456 parent instead of a direct call to GetType.
14458 2001-09-14 Ravi Pratap <ravi@ximian.com>
14460 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
14461 Modifiers.TypeAttr. This should just be a call to that method.
14463 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
14464 object so that we can determine if we are top-level or not.
14466 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
14469 * enum.cs (Enum::Define): Ditto.
14471 * modifiers.cs (FieldAttr): Re-write.
14473 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
14474 (TypeContainer::HaveStaticConstructor): New property to provide access
14475 to precisely that info.
14477 * modifiers.cs (MethodAttr): Re-write.
14478 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
14480 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
14481 of top-level types as claimed.
14483 2001-09-13 Miguel de Icaza <miguel@ximian.com>
14485 * expression.cs (MemberLookup): Fruitless attempt to lookup
14486 constructors. Maybe I need to emit default constructors? That
14487 might be it (currently .NET emits this for me automatically).
14488 (Invocation::OverloadResolve): Cope with Arguments == null.
14489 (Invocation::EmitArguments): new function, shared by the new
14490 constructor and us.
14491 (Invocation::Emit): Handle static and instance methods. Emit
14492 proper call instruction for virtual or non-virtual invocations.
14493 (New::Emit): Implement.
14494 (New::Resolve): Implement.
14495 (MemberAccess:Resolve): Implement.
14496 (MethodGroupExpr::InstanceExpression): used conforming to the spec
14497 to track instances.
14498 (FieldExpr::Resolve): Set type.
14500 * support.cs: Handle empty arguments.
14502 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
14503 SimpleLookup): Auxiliary routines to help parse a qualifier
14506 Update qualifier_identifier rule.
14508 * codegen.cs: Removed debugging messages.
14510 * class.cs: Make this a global thing, this acts just as a "key" to
14511 objects that we might have around.
14513 (Populate): Only initialize method_builders_to_methods once.
14515 * expression.cs (PropertyExpr): Initialize type from the
14518 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
14519 Resolve pattern. Attempt to implicitly convert value to boolean.
14522 * expression.cs: Set the type for the int32/int32 argument case.
14523 (Binary::ResolveOperator): Set the return type to boolean for
14524 comparission operators
14526 * typemanager.cs: Remove debugging print code.
14528 (Invocation::Resolve): resolve type.
14530 * class.cs: Allocate a MemberInfo of the correct size, as the code
14531 elsewhere depends on the test to reflect the correct contents.
14533 (Method::) Keep track of parameters, due to System.Reflection holes
14535 (TypeContainer::Populate): Keep track of MethodBuilders to Method
14538 (TypeContainer::FindMembers): Use ArrayList and then copy an array
14539 of the exact size and return that.
14541 (Class::LookupMethodByBuilder): New function that maps
14542 MethodBuilders to its methods. Required to locate the information
14543 on methods because System.Reflection bit us again.
14545 * support.cs: New file, contains an interface ParameterData and
14546 two implementations: ReflectionParameters and InternalParameters
14547 used to access Parameter information. We will need to grow this
14550 * expression.cs (Invocation::GetParameterData): implement a cache
14551 and a wrapper around the ParameterData creation for methods.
14552 (Invocation::OverloadResolve): Use new code.
14554 2001-09-13 Ravi Pratap <ravi@ximian.com>
14556 * class.cs (TypeContainer::EmitField): Remove and move into
14557 (Field::Define): here and modify accordingly.
14558 (Field.FieldBuilder): New member.
14559 (TypeContainer::Populate): Update accordingly.
14560 (TypeContainer::FindMembers): Implement.
14562 2001-09-13 Miguel de Icaza <miguel@ximian.com>
14564 * statement.cs: (VariableInfo::VariableType): New field to be
14565 initialized with the full type once it is resolved.
14567 2001-09-12 Miguel de Icaza <miguel@ximian.com>
14569 * parameter.cs (GetParameterInfo): Use a type cache to compute
14570 things only once, and to reuse this information
14572 * expression.cs (LocalVariableReference::Emit): Implement.
14573 (OpcodeCast::Emit): fix.
14575 (ParameterReference::Resolve): Implement.
14576 (ParameterReference::Emit): Implement.
14578 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
14579 that are expressions need to stay as Expressions.
14581 * typemanager.cs (CSharpName): Returns the C# name of a type if
14584 * expression.cs (Expression::ConvertImplicit): New function that
14585 implements implicit type conversions.
14587 (Expression::ImplicitReferenceConversion): Implements implicit
14588 reference conversions.
14590 (EmptyCast): New type for transparent casts.
14592 (OpcodeCast): New type for casts of types that are performed with
14593 a sequence of bytecodes.
14595 (BoxedCast): New type used for casting value types into reference
14596 types. Emits a box opcode.
14598 (Binary::DoNumericPromotions): Implements numeric promotions of
14599 and computation of the Binary::Type.
14601 (Binary::EmitBranchable): Optimization.
14603 (Binary::Emit): Implement code emission for expressions.
14605 * typemanager.cs (TypeManager): Added two new core types: sbyte
14608 2001-09-12 Ravi Pratap <ravi@ximian.com>
14610 * class.cs (TypeContainer::FindMembers): Method which does exactly
14611 what Type.FindMembers does, only we don't have to use reflection. No
14612 implementation yet.
14614 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
14615 typecontainer objects as we need to get at them.
14616 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
14618 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
14619 typecontainer object.
14621 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
14622 of just a Report object.
14624 2001-09-11 Ravi Pratap <ravi@ximian.com>
14626 * class.cs (Event::Define): Go back to using the prefixes "add_" and
14628 (TypeContainer::Populate): Now define the delegates of the type too.
14629 (TypeContainer.Delegates): Property to access the list of delegates defined
14632 * delegates.cs (Delegate::Define): Implement partially.
14634 * modifiers.cs (TypeAttr): Handle more flags.
14636 2001-09-11 Ravi Pratap <ravi@ximian.com>
14638 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
14640 (Operator::Define): Re-write logic to get types by using the LookupType method
14641 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
14642 (Indexer::Define): Ditto.
14643 (Event::Define): Ditto.
14644 (Property::Define): Ditto.
14646 2001-09-10 Ravi Pratap <ravi@ximian.com>
14648 * class.cs (TypeContainer::Populate): Now define operators too.
14649 (TypeContainer.Operators): New property to access the list of operators
14651 (Operator.OperatorMethodBuilder): New member to hold the method builder
14652 for the operator we are defining.
14653 (Operator::Define): Implement.
14655 2001-09-10 Ravi Pratap <ravi@ximian.com>
14657 * class.cs (Event::Define): Make the prefixes of the accessor methods
14658 addOn_ and removeOn_
14660 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
14661 of the location being passed in too. Ideally, this should go later since all
14662 error reporting should be done through the Report object.
14664 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
14665 (Populate): Iterate thru the indexers we have and define them too.
14666 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
14667 for the get and set accessors.
14668 (Indexer::Define): Implement.
14670 2001-09-09 Miguel de Icaza <miguel@ximian.com>
14672 * expression.cs (Binary::Resolve): Beginning of it. I scratched
14673 my previous implementation, did not work.
14675 * typemanager.cs: Add a couple of missing types (the longs).
14677 * literal.cs: Use TypeManager.bool_type instead of getting it.
14679 * expression.cs (EventExpr): New kind of expressions.
14680 (Expressio::ExprClassFromMemberInfo): finish
14682 2001-09-08 Miguel de Icaza <miguel@ximian.com>
14684 * assign.cs: Emit stores to static fields differently.
14686 2001-09-08 Ravi Pratap <ravi@ximian.com>
14688 * Merge in changes and adjust code to tackle conflicts. Backed out my
14689 code in Assign::Resolve ;-)
14691 2001-09-08 Ravi Pratap <ravi@ximian.com>
14693 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
14694 instead Report.Error and also pass in the location.
14695 (CSharpParser::Lexer): New readonly property to return the reference
14696 to the Tokenizer object.
14697 (declare_local_variables): Use Report.Error with location instead of plain
14701 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
14702 (Operator.CheckBinaryOperator): Ditto.
14704 * cs-parser.jay (operator_declarator): Update accordingly.
14706 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
14707 (CheckBinaryOperator): Same here.
14709 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
14710 on the name without any prefixes of namespace names etc. This is because we
14711 already might have something already fully qualified like
14712 'System.Console.WriteLine'
14714 * assign.cs (Resolve): Begin implementation. Stuck ;-)
14716 2001-09-07 Ravi Pratap <ravi@ximian.com>
14718 * cs-tokenizer.cs (location): Return a string which also contains
14721 * expression.cs (ElementAccess): New class for expressions of the
14722 type 'element access.'
14723 (BaseAccess): New class for expressions of the type 'base access.'
14724 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
14727 * cs-parser.jay (element_access): Implement action.
14728 (base_access): Implement actions.
14729 (checked_expression, unchecked_expression): Implement.
14731 * cs-parser.jay (local_variable_type): Correct and implement.
14732 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
14734 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
14736 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
14737 name and the specifiers.
14739 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
14741 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
14742 making them all public ;-)
14744 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
14747 2001-09-07 Miguel de Icaza <miguel@ximian.com>
14749 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
14751 (FieldExpr, PropertyExprs): New resolved expressions.
14752 (SimpleName::MemberStaticCheck): Perform static checks for access
14753 to non-static fields on static methods. Maybe this should be
14754 generalized for MemberAccesses.
14755 (SimpleName::ResolveSimpleName): More work on simple name
14758 * cs-parser.jay (primary_expression/qualified_identifier): track
14759 the parameter index.
14761 * codegen.cs (CodeGen::Save): Catch save exception, report error.
14762 (EmitContext::EmitBoolExpression): Chain to expression generation
14763 instead of temporary hack.
14764 (::EmitStatementExpression): Put generic expression code generation.
14766 * assign.cs (Assign::Emit): Implement variable assignments to
14767 local variables, parameters and fields.
14769 2001-09-06 Miguel de Icaza <miguel@ximian.com>
14771 * statement.cs (Block::GetVariableInfo): New method, returns the
14772 VariableInfo for a variable name in a block.
14773 (Block::GetVariableType): Implement in terms of GetVariableInfo
14775 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
14776 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
14778 2001-09-06 Ravi Pratap <ravi@ximian.com>
14780 * cs-parser.jay (operator_declaration): Continue on my quest : update
14781 to take attributes argument.
14782 (event_declaration): Ditto.
14783 (enum_declaration): Ditto.
14784 (indexer_declaration): Ditto.
14786 * class.cs (Operator::Operator): Update constructor accordingly.
14787 (Event::Event): Ditto.
14789 * delegate.cs (Delegate::Delegate): Same here.
14791 * enum.cs (Enum::Enum): Same here.
14793 2001-09-05 Ravi Pratap <ravi@ximian.com>
14795 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
14797 * ../tests/cs0658.cs : New file to demonstrate error 0658.
14799 * attribute.cs (Attributes): New class to encapsulate all attributes which were
14800 being passed around as an arraylist.
14801 (Attributes::AddAttribute): Method to add attribute sections.
14803 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
14804 (struct_declaration): Update accordingly.
14805 (constant_declaration): Update.
14806 (field_declaration): Update.
14807 (method_header): Update.
14808 (fixed_parameter): Update.
14809 (parameter_array): Ditto.
14810 (property_declaration): Ditto.
14811 (destructor_declaration): Ditto.
14813 * class.cs (Struct::Struct): Update constructors accordingly.
14814 (Class::Class): Ditto.
14815 (Field::Field): Ditto.
14816 (Method::Method): Ditto.
14817 (Property::Property): Ditto.
14818 (TypeContainer::OptAttribute): update property's return type.
14820 * interface.cs (Interface.opt_attributes): New member.
14821 (Interface::Interface): Update to take the extra Attributes argument.
14823 * parameter.cs (Parameter::Parameter): Ditto.
14825 * constant.cs (Constant::Constant): Ditto.
14827 * interface.cs (InterfaceMemberBase): New OptAttributes field.
14828 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
14829 the attributes as a parameter.
14830 (InterfaceProperty): Update constructor call.
14831 (InterfaceEvent): Ditto.
14832 (InterfaceMethod): Ditto.
14833 (InterfaceIndexer): Ditto.
14835 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
14836 pass the attributes too.
14837 (interface_event_declaration): Ditto.
14838 (interface_property_declaration): Ditto.
14839 (interface_method_declaration): Ditto.
14840 (interface_declaration): Ditto.
14842 2001-09-05 Miguel de Icaza <miguel@ximian.com>
14844 * class.cs (Method::Define): Track the "static Main" definition to
14845 create an entry point.
14847 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
14848 EntryPoint if we find it.
14850 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
14851 (EmitContext::ig): Make this variable public.
14853 * driver.cs: Make the default output file be the first file name
14854 with the .exe extension.
14856 Detect empty compilations
14858 Handle various kinds of output targets. Handle --target and
14859 rename -t to --dumper.
14861 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
14862 methods inherited from Expression return now an Expression. This
14863 will is used during the tree rewriting as we resolve them during
14866 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
14867 the spec. Missing entirely is the information about
14868 accessability of elements of it.
14870 (Expression::ExprClassFromMemberInfo): New constructor for
14871 Expressions that creates a fully initialized Expression based on
14872 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
14875 (Invocation::Resolve): Begin implementing resolution of invocations.
14877 * literal.cs (StringLiteral): Implement Emit.
14879 2001-09-05 Ravi Pratap <ravi@ximian.com>
14881 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
14884 2001-09-04 Ravi Pratap <ravi@ximian.com>
14886 * cs-parser.jay (attribute_arguments): Implement actions.
14887 (attribute): Fix bug in production. Implement action.
14888 (attribute_list): Implement.
14889 (attribute_target): Implement.
14890 (attribute_target_specifier, opt_target_specifier): Implement
14891 (CheckAttributeTarget): New method to check if the attribute target
14893 (attribute_section): Implement.
14894 (opt_attributes): Implement.
14896 * attribute.cs : New file to handle attributes.
14897 (Attribute): Class to hold attribute info.
14899 * cs-parser.jay (opt_attribute_target_specifier): Remove production
14900 (attribute_section): Modify production to use 2 different rules to
14901 achieve the same thing. 1 s/r conflict down !
14902 Clean out commented, useless, non-reducing dimension_separator rules.
14904 * class.cs (TypeContainer.attributes): New member to hold list
14905 of attributes for a type.
14906 (Struct::Struct): Modify to take one more argument, the attribute list.
14907 (Class::Class): Ditto.
14908 (Field::Field): Ditto.
14909 (Method::Method): Ditto.
14910 (Property::Property): Ditto.
14912 * cs-parser.jay (struct_declaration): Update constructor call to
14913 pass in the attributes too.
14914 (class_declaration): Ditto.
14915 (constant_declaration): Ditto.
14916 (field_declaration): Ditto.
14917 (method_header): Ditto.
14918 (fixed_parameter): Ditto.
14919 (parameter_array): Ditto.
14920 (property_declaration): Ditto.
14922 * constant.cs (Constant::Constant): Update constructor similarly.
14923 Use System.Collections.
14925 * parameter.cs (Parameter::Parameter): Update as above.
14927 2001-09-02 Ravi Pratap <ravi@ximian.com>
14929 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
14930 (TypeContainer.delegates): New member to hold list of delegates.
14932 * cs-parser.jay (delegate_declaration): Implement the action correctly
14933 this time as I seem to be on crack ;-)
14935 2001-09-02 Miguel de Icaza <miguel@ximian.com>
14937 * rootcontext.cs (RootContext::IsNamespace): new function, used to
14938 tell whether an identifier represents a namespace.
14940 * expression.cs (NamespaceExpr): A namespace expression, used only
14941 temporarly during expression resolution.
14942 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
14943 utility functions to resolve names on expressions.
14945 2001-09-01 Miguel de Icaza <miguel@ximian.com>
14947 * codegen.cs: Add hook for StatementExpressions.
14949 * class.cs: Fix inverted test for static flag in methods.
14951 2001-09-02 Ravi Pratap <ravi@ximian.com>
14953 * class.cs (Operator::CheckUnaryOperator): Correct error number used
14954 to make it coincide with MS' number.
14955 (Operator::CheckBinaryOperator): Ditto.
14957 * ../errors/errors.txt : Remove error numbers added earlier.
14959 * ../errors/cs1019.cs : Test case for error # 1019
14961 * ../errros/cs1020.cs : Test case for error # 1020
14963 * cs-parser.jay : Clean out commented cruft.
14964 (dimension_separators, dimension_separator): Comment out. Ostensibly not
14965 used anywhere - non-reducing rule.
14966 (namespace_declarations): Non-reducing rule - comment out.
14968 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
14969 with TypeContainer::AddEnum.
14971 * delegate.cs : New file for delegate handling classes.
14972 (Delegate): Class for declaring delegates.
14974 * makefile : Update.
14976 * cs-parser.jay (delegate_declaration): Implement.
14978 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
14980 * class.cs (Event::Define): Implement.
14981 (Event.EventBuilder): New member.
14983 * class.cs (TypeContainer::Populate): Update to define all enums and events
14985 (Events): New property for the events arraylist we hold. Shouldn't we move to using
14986 readonly fields for all these cases ?
14988 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
14990 * class.cs (Property): Revamp to use the convention of making fields readonly.
14991 Accordingly modify code elsewhere.
14993 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
14994 the Define method of the Property class.
14996 * class.cs : Clean up applied patch and update references to variables etc. Fix
14998 (TypeContainer::Populate): Update to define all the properties we have. Also
14999 define all enumerations.
15001 * enum.cs (Define): Implement.
15003 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
15005 * cs-parser.jay (overloadable_operator): The semantic value is an
15006 enum of the Operator class.
15007 (operator_declarator): Implement actions.
15008 (operator_declaration): Implement.
15010 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
15011 validity of definitions.
15012 (Operator::CheckBinaryOperator): Static method to check for binary operators
15013 (TypeContainer::AddOperator): New method to add an operator to a type.
15015 * cs-parser.jay (indexer_declaration): Added line to actually call the
15016 AddIndexer method so it gets added ;-)
15018 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
15019 already taken care of by the MS compiler ?
15021 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
15023 * class.cs (Operator): New class for operator declarations.
15024 (Operator::OpType): Enum for the various operators.
15026 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
15028 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
15029 ostensibly handle this in semantic analysis.
15031 * cs-parser.jay (general_catch_clause): Comment out
15032 (specific_catch_clauses, specific_catch_clause): Ditto.
15033 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
15034 (catch_args, opt_catch_args): New productions.
15035 (catch_clause): Rewrite to use the new productions above
15036 (catch_clauses): Modify accordingly.
15037 (opt_catch_clauses): New production to use in try_statement
15038 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
15039 and re-write the code in the actions to extract the specific and
15040 general catch clauses by being a little smart ;-)
15042 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
15043 Hooray, try and catch statements parse fine !
15045 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
15047 * statement.cs (Block::GetVariableType): Fix logic to extract the type
15048 string from the hashtable of variables.
15050 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
15051 I end up making that mistake ;-)
15052 (catch_clauses): Fixed gross error which made Key and Value of the
15053 DictionaryEntry the same : $1 !!
15055 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
15057 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
15059 * cs-parser.jay (event_declaration): Correct to remove the semicolon
15060 when the add and remove accessors are specified.
15062 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
15064 * cs-parser.jay (IndexerDeclaration): New helper class to hold
15065 information about indexer_declarator.
15066 (indexer_declarator): Implement actions.
15067 (parsing_indexer): New local boolean used to keep track of whether
15068 we are parsing indexers or properties. This is necessary because
15069 implicit_parameters come into picture even for the get accessor in the
15070 case of an indexer.
15071 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
15073 * class.cs (Indexer): New class for indexer declarations.
15074 (TypeContainer::AddIndexer): New method to add an indexer to a type.
15075 (TypeContainer::indexers): New member to hold list of indexers for the
15078 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
15080 * cs-parser.jay (add_accessor_declaration): Implement action.
15081 (remove_accessor_declaration): Implement action.
15082 (event_accessors_declaration): Implement
15083 (variable_declarators): swap statements for first rule - trivial.
15085 * class.cs (Event): New class to hold information about event
15087 (TypeContainer::AddEvent): New method to add an event to a type
15088 (TypeContainer::events): New member to hold list of events.
15090 * cs-parser.jay (event_declaration): Implement actions.
15092 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
15094 * cs-parser.jay (dim_separators): Implement. Make it a string
15095 concatenating all the commas together, just as they appear.
15096 (opt_dim_separators): Modify accordingly
15097 (rank_specifiers): Update accordingly. Basically do the same
15098 thing - instead, collect the brackets here.
15099 (opt_rank_sepcifiers): Modify accordingly.
15100 (array_type): Modify to actually return the complete type string
15101 instead of ignoring the rank_specifiers.
15102 (expression_list): Implement to collect the expressions
15103 (variable_initializer): Implement. We make it a list of expressions
15104 essentially so that we can handle the array_initializer case neatly too.
15105 (variable_initializer_list): Implement.
15106 (array_initializer): Make it a list of variable_initializers
15107 (opt_array_initializer): Modify accordingly.
15109 * expression.cs (New::NType): Add enumeration to help us
15110 keep track of whether we have an object/delegate creation
15111 or an array creation.
15112 (New:NewType, New::Rank, New::Indices, New::Initializers): New
15113 members to hold data about array creation.
15114 (New:New): Modify to update NewType
15115 (New:New): New Overloaded contructor for the array creation
15118 * cs-parser.jay (array_creation_expression): Implement to call
15119 the overloaded New constructor.
15121 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
15123 * class.cs (TypeContainer::Constructors): Return member
15124 constructors instead of returning null.
15126 2001-08-26 Miguel de Icaza <miguel@ximian.com>
15128 * typemanager.cs (InitCoreTypes): Initialize the various core
15129 types after we have populated the type manager with the user
15130 defined types (this distinction will be important later while
15131 compiling corlib.dll)
15133 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
15134 on Expression Classification. Now all expressions have a method
15135 `Resolve' and a method `Emit'.
15137 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
15138 generation from working. Also add some temporary debugging
15141 2001-08-24 Miguel de Icaza <miguel@ximian.com>
15143 * codegen.cs: Lots of code generation pieces. This is only the
15144 beginning, will continue tomorrow with more touches of polish. We
15145 handle the fundamentals of if, while, do, for, return. Others are
15146 trickier and I need to start working on invocations soon.
15148 * gen-treedump.cs: Bug fix, use s.Increment here instead of
15151 * codegen.cs (EmitContext): New struct, used during code
15152 emission to keep a context. Most of the code generation will be
15155 * cs-parser.jay: Add embedded blocks to the list of statements of
15156 this block. So code generation proceeds in a top down fashion.
15158 2001-08-23 Miguel de Icaza <miguel@ximian.com>
15160 * statement.cs: Add support for multiple child blocks.
15162 2001-08-22 Miguel de Icaza <miguel@ximian.com>
15164 * codegen.cs (EmitCode): New function, will emit the code for a
15165 Block of code given a TypeContainer and its ILGenerator.
15167 * statement.cs (Block): Standard public readonly optimization.
15168 (Block::Block constructors): Link children.
15169 (Block::Child): Child Linker.
15170 (Block::EmitVariables): Emits IL variable declarations.
15172 * class.cs: Drop support for MethodGroups here, delay until
15174 (Method::): Applied the same simplification that I did before, and
15175 move from Properties to public readonly fields.
15176 (Method::ParameterTypes): Returns the parameter types for the
15177 function, and implements a cache that will be useful later when I
15178 do error checking and the semantic analysis on the methods is
15180 (Constructor::GetCallingConvention): Renamed from CallingConvetion
15181 and made a method, optional argument tells whether this is a class
15182 or a structure to apply the `has-this' bit.
15183 (Method::GetCallingConvention): Implement, returns the calling
15185 (Method::Define): Defines the type, a second pass is performed
15186 later to populate the methods.
15188 (Constructor::ParameterTypes): implement a cache similar to the
15189 one on Method::ParameterTypes, useful later when we do semantic
15192 (TypeContainer::EmitMethod): New method. Emits methods.
15194 * expression.cs: Removed MethodGroup class from here.
15196 * parameter.cs (Parameters::GetCallingConvention): new method.
15198 2001-08-21 Miguel de Icaza <miguel@ximian.com>
15200 * class.cs (TypeContainer::Populate): Drop RootContext from the
15203 (Constructor::CallingConvention): Returns the calling convention.
15204 (Constructor::ParameterTypes): Returns the constructor parameter
15207 (TypeContainer::AddConstructor): Keep track of default constructor
15208 and the default static constructor.
15210 (Constructor::) Another class that starts using `public readonly'
15211 instead of properties.
15213 (Constructor::IsDefault): Whether this is a default constructor.
15215 (Field::) use readonly public fields instead of properties also.
15217 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
15218 track of static constructors; If none is used, turn on
15219 BeforeFieldInit in the TypeAttributes.
15221 * cs-parser.jay (opt_argument_list): now the return can be null
15222 for the cases where there are no arguments.
15224 (constructor_declarator): If there is no implicit `base' or
15225 `this', then invoke the default parent constructor.
15227 * modifiers.cs (MethodAttr): New static function maps a set of
15228 modifiers flags into a MethodAttributes enum
15229 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
15230 MethodAttr, TypeAttr to represent the various mappings where the
15231 modifiers are used.
15232 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
15234 2001-08-19 Miguel de Icaza <miguel@ximian.com>
15236 * parameter.cs (GetParameterInfo): Fix bug where there would be no
15239 * interface.cs (PopulateIndexer): Implemented the code generator
15240 for interface indexers.
15242 2001-08-17 Miguel de Icaza <miguel@ximian.com>
15244 * interface.cs (InterfaceMemberBase): Now we track the new status
15247 (PopulateProperty): Implement property population. Woohoo! Got
15248 Methods and Properties going today.
15250 Removed all the properties for interfaces, and replaced them with
15251 `public readonly' fields.
15253 2001-08-16 Miguel de Icaza <miguel@ximian.com>
15255 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
15256 initialize their hashtables/arraylists only when they are needed
15257 instead of doing this always.
15259 * parameter.cs: Handle refs and out parameters.
15261 * cs-parser.jay: Use an ArrayList to construct the arguments
15262 instead of the ParameterCollection, and then cast that to a
15265 * parameter.cs: Drop the use of ParameterCollection and use
15266 instead arrays of Parameters.
15268 (GetParameterInfo): Use the Type, not the Name when resolving
15271 2001-08-13 Miguel de Icaza <miguel@ximian.com>
15273 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
15274 and instead use public readonly fields.
15276 * class.cs: Put back walking code for type containers.
15278 2001-08-11 Miguel de Icaza <miguel@ximian.com>
15280 * class.cs (MakeConstant): Code to define constants.
15282 * rootcontext.cs (LookupType): New function. Used to locate types
15285 2001-08-08 Miguel de Icaza <miguel@ximian.com>
15287 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
15288 this System.Reflection code is. Kudos to Microsoft
15290 * typemanager.cs: Implement a type cache and avoid loading all
15291 types at boot time. Wrap in LookupType the internals. This made
15292 the compiler so much faster. Wow. I rule!
15294 * driver.cs: Make sure we always load mscorlib first (for
15295 debugging purposes, nothing really important).
15297 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
15298 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
15300 * rootcontext.cs: Lookup types on their namespace; Lookup types
15301 on namespaces that have been imported using the `using' keyword.
15303 * class.cs (TypeContainer::TypeAttr): Virtualize.
15304 (Class::TypeAttr): Return attributes suitable for this bad boy.
15305 (Struct::TypeAttr): ditto.
15306 Handle nested classes.
15307 (TypeContainer::) Remove all the type visiting code, it is now
15308 replaced with the rootcontext.cs code
15310 * rootcontext.cs (GetClassBases): Added support for structs.
15312 2001-08-06 Miguel de Icaza <miguel@ximian.com>
15314 * interface.cs, statement.cs, class.cs, parameter.cs,
15315 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
15316 Drop use of TypeRefs, and use strings instead.
15318 2001-08-04 Miguel de Icaza <miguel@ximian.com>
15322 * class.cs (Struct::Struct): set the SEALED flags after
15323 checking the modifiers.
15324 (TypeContainer::TypeAttr): new property, returns the
15325 TypeAttributes for a class.
15327 * cs-parser.jay (type_list): Oops, list production was creating a
15328 new list of base types.
15330 * rootcontext.cs (StdLib): New property.
15331 (GetInterfaceTypeByName): returns an interface by type name, and
15332 encapsulates error handling here.
15333 (GetInterfaces): simplified.
15334 (ResolveTree): Encapsulated all the tree resolution here.
15335 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
15338 * driver.cs: Add support for --nostdlib, to avoid loading the
15339 default assemblies.
15340 (Main): Do not put tree resolution here.
15342 * rootcontext.cs: Beginning of the class resolution.
15344 2001-08-03 Miguel de Icaza <miguel@ximian.com>
15346 * rootcontext.cs: Provide better error reporting.
15348 * cs-parser.jay (interface_base): set our $$ to be interfaces.
15350 * rootcontext.cs (CreateInterface): Handle the case where there
15351 are no parent interfaces.
15353 (CloseTypes): Routine to flush types at the end.
15354 (CreateInterface): Track types.
15355 (GetInterfaces): Returns an array of Types from the list of
15356 defined interfaces.
15358 * typemanager.c (AddUserType): Mechanism to track user types (puts
15359 the type on the global type hash, and allows us to close it at the
15362 2001-08-02 Miguel de Icaza <miguel@ximian.com>
15364 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
15365 RecordInterface instead.
15367 * cs-parser.jay: Updated to reflect changes above.
15369 * decl.cs (Definition): Keep track of the TypeBuilder type that
15370 represents this type here. Not sure we will use it in the long
15371 run, but wont hurt for now.
15373 * driver.cs: Smaller changes to accomodate the new code.
15375 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
15378 * rootcontext.cs (CreateInterface): New method, used to create
15379 the System.TypeBuilder type for interfaces.
15380 (ResolveInterfaces): new entry point to resolve the interface
15382 (CodeGen): Property, used to keep track of the code generator.
15384 2001-07-26 Miguel de Icaza <miguel@ximian.com>
15386 * cs-parser.jay: Add a second production for delegate_declaration
15389 (enum_body): Put an opt_comma here instead of putting it on
15390 enum_body or enum_member_declarations so we can handle trailing
15391 commas on enumeration members. Gets rid of a shift/reduce.
15393 (type_list): Need a COMMA in the middle.
15395 (indexer_declaration): Tell tokenizer to recognize get/set
15397 * Remove old targets.
15399 * Re-add the parser target.
15401 2001-07-13 Simon Cozens <simon@simon-cozens.org>
15403 * cs-parser.jay: Add precendence rules for a number of operators
15404 ot reduce the number of shift/reduce conflicts in the grammar.
15406 2001-07-17 Miguel de Icaza <miguel@ximian.com>
15408 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
15411 Get rid of old crufty code.
15413 * rootcontext.cs: Use this to keep track of the parsed
15414 representation and the defined types available to the program.
15416 * gen-treedump.cs: adjust for new convention.
15418 * type.cs: Split out the type manager, and the assembly builder
15421 * typemanager.cs: the type manager will live here now.
15423 * cil-codegen.cs: And the code generator here.
15425 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
15427 * makefile: Fixed up for easy making.
15429 2001-07-13 Simon Cozens <simon@simon-cozens.org>
15431 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
15434 (unary_expression): Expand pre_increment_expression and
15435 post_decrement_expression to reduce a shift/reduce.
15437 2001-07-11 Simon Cozens
15439 * cs-tokenizer.cs: Hex numbers should begin with a 0.
15441 Improve allow_keyword_as_indent name.
15443 2001-06-19 Miguel de Icaza <miguel@ximian.com>
15445 * Adjustments for Beta2.
15447 2001-06-13 Miguel de Icaza <miguel@ximian.com>
15449 * decl.cs: Added `Define' abstract method.
15450 (InTransit): new property, used to catch recursive definitions.
15452 * interface.cs: Implement `Define'.
15454 * modifiers.cs: Map Modifiers.constants to
15455 System.Reflection.TypeAttribute flags.
15457 * class.cs: Keep track of types and user-defined types.
15458 (BuilderInit): New method for creating an assembly
15459 (ResolveType): New function to launch the resolution process, only
15460 used by interfaces for now.
15462 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
15463 that are inserted into the name space.
15465 2001-06-08 Miguel de Icaza <miguel@ximian.com>
15467 * ARGH. I have screwed up my tree so many times due to the use of
15468 rsync rather than using CVS. Going to fix this at once.
15470 * driver.cs: Objetify driver. Load assemblies, use assemblies to
15473 2001-06-07 Miguel de Icaza <miguel@ximian.com>
15475 * Experiment successful: Use System.Type rather that our own
15478 2001-05-25 Miguel de Icaza <miguel@ximian.com>
15480 * cs-parser.jay: Removed nsAliases from here.
15482 Use new namespaces, handle `using XXX;'
15484 * namespace.cs: Reimplemented namespace handling, use a recursive
15485 definition of the class. Now we can keep track of using clauses
15486 and catch invalid using clauses.
15488 2001-05-24 Miguel de Icaza <miguel@ximian.com>
15490 * gen-treedump.cs: Adapted for all the renaming.
15492 * expression.cs (Expression): this class now has a Type property
15493 which returns an expression Type.
15495 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
15496 `Type', as this has a different meaning now in the base
15498 2001-05-22 Miguel de Icaza <miguel@ximian.com>
15500 * interface.cs, class.cs: Removed from all the sources the
15501 references to signature computation, as we can not do method
15502 signature computation during the parsing time, as we are not
15503 trying to solve at that point distinguishing:
15507 void a (NS.Blah x) {}
15510 Which depending on the context might be valid or not, as we do not
15511 know if Blah is the same thing as NS.Blah at that point.
15513 * Redid everything so the code uses TypeRefs now instead of
15514 Types. TypeRefs are just temporary type placeholders, that need
15515 to be resolved. They initially have a pointer to a string and the
15516 current scope in which they are used. This is used later by the
15517 compiler to resolve the reference to an actual Type.
15519 * DeclSpace is no longer a CIR.Type, and neither are
15520 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
15521 are all DeclSpaces, but no Types.
15523 * type.cs (TypeRefManager): This implements the TypeRef manager,
15524 which keeps track of all the types that need to be resolved after
15525 the parsing has finished.
15527 2001-05-13 Miguel de Icaza <miguel@ximian.com>
15529 * ARGH. We are going to have to store `foreach' as a class rather
15530 than resolving it, as we need to verify error 1579 after name
15531 resolution. *OR* we could keep a flag that says `This request to
15532 IEnumerator comes from a foreach statement' which we can then use
15533 to generate the error.
15535 2001-05-10 Miguel de Icaza <miguel@ximian.com>
15537 * class.cs (TypeContainer.AddMethod): we now add methods to the
15538 MethodGroup instead of the method hashtable.
15540 * expression.cs: Add MethodGroup abstraction, which gets us one
15541 step closer to the specification in the way we handle method
15544 * cs-parser.jay (primary_expression): qualified_identifier now
15545 tried to match up an identifier to a local variable reference or
15546 to a parameter reference.
15548 current_local_parameters is now a parser global variable that
15549 points to the current parameters for the block, used during name
15552 (property_declaration): Now creates an implicit `value' argument to
15555 2001-05-09 Miguel de Icaza <miguel@ximian.com>
15557 * parameter.cs: Do not use `param' arguments as part of the
15558 signature, per the spec.
15560 2001-05-08 Miguel de Icaza <miguel@ximian.com>
15562 * decl.cs: Base class for classes, structs and interfaces. This
15563 is the "Declaration Space"
15565 * cs-parser.jay: Use CheckDef for checking declaration errors
15566 instead of having one on each function.
15568 * class.cs: Factor out some code for handling error handling in
15569 accordance to the "Declarations" section in the "Basic Concepts"
15570 chapter in the ECMA C# spec.
15572 * interface.cs: Make all interface member classes derive from
15573 InterfaceMemberBase.
15575 2001-05-07 Miguel de Icaza <miguel@ximian.com>
15577 * Many things: all interfaces are parsed and generated in
15578 gen-treedump. Support for member variables, constructors,
15579 destructors, properties, constants is there.
15581 Beginning of the IL backend, but very little done, just there for
15584 2001-04-29 Miguel de Icaza <miguel@ximian.com>
15586 * cs-parser.jay: Fix labeled statement.
15588 * cs-tokenizer.cs (escape): Escape " and ' always.
15589 ref_line, ref_name: keep track of the line/filename as instructed
15590 by #line by the compiler.
15593 2001-04-27 Miguel de Icaza <miguel@ximian.com>
15595 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
15596 to match the values in System.CodeDOM.
15598 Divid renamed to Divide.
15600 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
15602 (Statements.set): remove.
15604 * System.CodeDOM/CodeCatchClause.cs: always have a valid
15607 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
15608 falseStatements always have valid values.
15610 * cs-parser.jay: Use System.CodeDOM now.