1 2008-02-15 Miguel de Icaza <miguel@novell.com>
3 * cs-tokenizer.cs: if a conditional expression happens inside a
4 (...) this also means that we do not need to de-ambiguate between
5 an parenthesized expression and a cast.
9 * constant.cs (SideEffectConstant): a constant value that happens
10 to have a side effect.
12 Fixes the build regressions introduced by the fix for #359789
14 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
16 * expression.cs (Conditional.Emit): when emitting the ternary
17 operator, use local variables to generate code verifiable code.
19 The verifier cannot infer that the type on stack before the
20 stloc.0 is executed is of type ParentB. This happens because the
21 stack merge algorithm uses only parent types when deciding which
22 is the common type. This is described in Part III 1.8.1.3 of ECMA
25 This code compiled with mcs is not verifiable under MS. The MS
26 verifier picks the first common interface of Foo and Bar, which is
27 wrong, but doesn't use a full join type of the 2 interfaces.
29 CSC uses a clever hack to compile such code in a verifiable
30 way. It stores the intermediate values in a local variable with
35 2008-02-14 Miguel de Icaza <miguel@novell.com>
37 * expression.cs: Do not fold BitwiseAnd operators when the left
38 side is a false constant, because we still need to evaluate the
43 * support.cs: Instead of throwing an InternalErrorException when
44 the position of the stream is outside the boundary of our buffer,
45 reset the state of the reader, and restart the reading from the
46 beginning of the file.
48 2008-02-14 Marek Safar <marek.safar@gmail.com>
50 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
52 2008-02-14 Marek Safar <marek.safar@gmail.com>
55 * decl.cs: A protected types used inside a private class which parents
56 derives from the protected class are accessible.
58 2008-02-13 Marek Safar <marek.safar@gmail.com>
60 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
61 the parameterless constructor.
63 2008-02-13 Marek Safar <marek.safar@gmail.com>
65 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
66 lookup methods to use standard member cache when doing member lookup.
68 2008-02-12 Marek Safar <marek.safar@gmail.com>
70 * driver.cs: Don't report full path for referenced module as assembly error.
72 2008-02-12 Marek Safar <marek.safar@gmail.com>
74 * Makefile: Fixed `qh' target to work on all machines.
76 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
77 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
78 and HasElementType with TypeManager implementation.
80 2008-02-08 Marek Safar <marek.safar@gmail.com>
82 A fix for bugs #325134, #359749
83 * expression.cs, ecore.cs: Try to resolve an extension method even if the
84 first binds point to non-method member expression.
86 2008-02-08 Marek Safar <marek.safar@gmail.com>
88 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
90 2008-02-08 Marek Safar <marek.safar@gmail.com>
92 A fix for bugs #321394, #323028
93 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
94 Reworked naive IsAccessibleAs implementation to handle nested types.
96 2008-02-05 Jb Evain <jbevain@novell.com>
98 * class.cs: use generic type comparison for parameters
101 2008-02-05 Marek Safar <marek.safar@gmail.com>
103 A fix for bug #325372
104 * class.cs: Use generic type comparison when testing method signatures.
106 2008-02-05 Marek Safar <marek.safar@gmail.com>
108 A fix for bug #357047
109 * ecore.cs: Applied C# 3.0 changes to better conversion.
111 2008-02-05 Marek Safar <marek.safar@gmail.com>
113 A fix for bug #358374
114 * cs-parser.jay: Correctly set modifiers for all constructor types.
116 2008-02-04 Marek Safar <marek.safar@gmail.com>
118 A fix for bug #355251
119 * generic.cs: Added base class constraint based type inference.
121 2008-02-01 Marek Safar <marek.safar@gmail.com>
123 A fix for bug #357255
124 * decl.cs: One more missing visibility check.
126 2008-02-01 Marek Safar <marek.safar@gmail.com>
128 * support.cs: Fixed broken return.
130 2008-01-25 Marek Safar <marek.safar@gmail.com>
132 * report.cs: Correctly reset warnings count after probing.
134 2008-01-25 Martin Baulig <martin@ximian.com>
137 (NamespaceEntry.SymbolFileID): Make this work again after
138 MemberName.ToString() is gone.
140 2008-01-25 Marek Safar <marek.safar@gmail.com>
142 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
145 2008-01-25 Marek Safar <marek.safar@gmail.com>
147 * generic.cs: Use full implicit conversion for type inference fixing.
149 2008-01-24 Marek Safar <marek.safar@gmail.com>
151 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
152 Fixed user operator conversions.
154 2008-01-24 Marek Safar <marek.safar@gmail.com>
156 * generic.cs: Do nullable type to null comparison optimization during
159 2008-01-24 Marek Safar <marek.safar@gmail.com>
161 A fix for bug #355163
162 * generic.cs: Enabled l-value resolve on nullable expressions.
164 2008-01-24 Marek Safar <marek.safar@gmail.com>
166 A fix for bug #353986
167 * class.cs: Ingore static ctors with parameters for any further checks.
169 2008-01-24 Marek Safar <marek.safar@gmail.com>
171 A fix for bug #354310
172 * namespace.cs: Removed redundant check.
174 2008-01-24 Marek Safar <marek.safar@gmail.com>
176 A fix for bug #354928
177 * expression.cs: ElementInitializers can be resolved only once.
179 2008-01-24 Marek Safar <marek.safar@gmail.com>
181 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
182 Condition expressions.
184 2008-01-23 Marek Safar <marek.safar@gmail.com>
186 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
188 2008-01-22 Marek Safar <marek.safar@gmail.com>
190 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
193 * generic.cs: Implemented coalesce expression.
195 2008-01-22 Marek Safar <marek.safar@gmail.com>
197 A fix for bug #355145
198 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
199 expression tree type inference.
201 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
204 * expression.cs (Binary.IsUnsignedType): Fix typo.
206 2008-01-22 Marek Safar <marek.safar@gmail.com>
208 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
210 2008-01-22 Marek Safar <marek.safar@gmail.com>
212 A fix for bug #355161
213 * ecore.cs, expression.cs: Wider range of extension method supported
216 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
218 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
219 AssemblyBuilder to operate in compiler context. Fixes mcs part of
222 2008-01-22 Marek Safar <marek.safar@gmail.com>
224 A fix for bug #355148
225 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
227 2008-01-22 Miguel de Icaza <miguel@novell.com>
229 * expression.cs (CreateExpressionTree): Add support for or and
230 logical or, and indent following the coding conventions.
232 * typemanager.cs (LinqExpression): renamed from
233 ExpressionTreeManager, for a shorter name.
235 Use TypeManager.CoreLookupType to lookup types from our core
236 assemblies and turn those into "Type" variables.
238 Consumers that previously used "Namespace" and "Type" from this
239 class should instead use the TypeExpression which is a type that
240 is fully resolved (without involving the regular C# resolution
243 This typically looks like this:
245 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
246 new MemberAccess (texpr, name, type_arguments, loc)
248 This avoids the problem in: #355178
250 2008-01-21 Marek Safar <marek.safar@gmail.com>
252 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
253 feature in parser only as we do in other cases.
255 2008-01-21 Marek Safar <marek.safar@gmail.com>
257 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
258 typemanager.cs: A refactoring of params arguments to reuse existing
259 expressions (params -> array initializer) to emit params argument instead
260 of specialized handling.
261 It was required by expression tree implementation and it has other benefits
262 as well, we now apply same optimization for params arguments as we do for
265 2008-01-18 Marek Safar <marek.safar@gmail.com>
267 A fix for bug #353526
268 * generic.cs: A type inference of params arguments may not required any
269 temporary array creation.
271 2008-01-18 Marek Safar <marek.safar@gmail.com>
273 A fix for bug #353534
274 * generic.cs, ecore.cs, expression.cs: A method group type inference is
275 supported for delegates only.
277 2008-01-18 Marek Safar <marek.safar@gmail.com>
279 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
280 type for more than 1 candidates.
282 2008-01-18 Marek Safar <marek.safar@gmail.com>
284 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
287 2008-01-16 Marek Safar <marek.safar@gmail.com>
289 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
290 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
291 operator) expressions.
293 2008-01-16 Zoltan Varga <vargaz@gmail.com>
295 * statement.cs: Avoid declaring an IL variable for this_variable since it is
296 not accessed from the generated IL.
298 2008-01-14 Marek Safar <marek.safar@gmail.com>
300 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
301 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
302 statement.cs: The first expression tree implementation drop, mostly
305 2008-01-14 Marek Safar <marek.safar@gmail.com>
307 * ecore.cs (IsNestedChild): Refactored.
309 2008-01-11 Marek Safar <marek.safar@gmail.com>
311 * lambda.cs: Don't use a cast on unknown expression statement.
313 2008-01-10 Geoff Norton <gnorton@novell.com>
315 * cs-tokenizer.cs: One more token to distinguish between method and lambda
318 2008-01-09 Marek Safar <marek.safar@gmail.com>
320 * doc.cs: Report better /doc crash details.
322 2008-01-09 Marek Safar <marek.safar@gmail.com>
324 A fix for bug #352536
325 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
327 2008-01-08 Marek Safar <marek.safar@gmail.com>
329 A fix for bug #352287
330 * ecore.cs, expression.cs: Do `this' access checking in all member access
333 2008-01-08 Marek Safar <marek.safar@gmail.com>
335 * rootcontext.cs, driver.cs: Switch to linq mode by default.
337 * report.cs: Reset message stacks.
339 2008-01-08 Marek Safar <marek.safar@gmail.com>
341 * generic.cs (InferInPhases): Correctly calculate params position.
343 2008-01-08 Marek Safar <marek.safar@gmail.com>
345 * cs-tokenizer.cs: No need to parse full string when parsing lambda
348 2008-01-07 Marek Safar <marek.safar@gmail.com>
350 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
352 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
354 * driver.cs: Updated --help option.
356 2008-01-07 Marek Safar <marek.safar@gmail.com>
358 * generic.cs (InferParamsTypeArguments): Removed.
359 (InferInPhases): Add params type inference.
360 (LowerBoundInference): Fixed scoring mechanism.
362 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
364 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
366 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
367 byte array for unsigned "baked" assemblies.
369 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
371 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
372 array for assemblies that are not strongnamed.
374 2008-01-04 Marek Safar <marek.safar@gmail.com>
376 A fix for bug #351481
377 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
378 declaring type for nested generic types.
380 2008-01-04 Marek Safar <marek.safar@gmail.com>
382 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
385 2008-01-03 Marek Safar <marek.safar@gmail.com>
387 A fix for bug #351047
388 * expression.cs (Binary.ResolveOperator): Allow equality operators between
389 null and structs only when equality and inequality operators are defined
390 either as an user-operators or predefined operators.
392 2008-01-03 Marek Safar <marek.safar@gmail.com>
394 A fix for bug #351047
395 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
397 2008-01-03 Marek Safar <marek.safar@gmail.com>
399 A fix for bug #351257
400 * cs-tokenizer.cs: Advance line number for '\r' correctly.
402 2008-01-03 Marek Safar <marek.safar@gmail.com>
404 A fix for bug #351157
405 * class.cs (Using): Fixed yet another broken cloning.
407 (Block): Put back more sensible default value for statements.
409 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
411 * codegen.cs: Allow AssemblyVersion with only major version component.
414 2007-12-29 Marek Safar <marek.safar@gmail.com>
416 A fix for bug #324654
417 * class.cs: Use FullName property as member name.
419 2007-12-28 Marek Safar <marek.safar@gmail.com>
421 A fix for bug #342117
422 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
423 constructor constraint.
425 2007-12-28 Marek Safar <marek.safar@gmail.com>
427 A fix for bug #338273
428 * class.cs (ProbertyBase): Access modifier checks are required for overrides
431 2007-12-28 Marek Safar <marek.safar@gmail.com>
433 A fix for bug #350839
434 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
436 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
438 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
441 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
443 * statement.cs: Changed some Hashtables to use HybridDictionaries
444 instead. It was observed that some HashTables only contained a few
445 items in the vast majority of cases. Since HybridDictionary is
446 more efficient on small sets (<10 elements), "known_variables"
447 from class ExplicitBlock as well as "labels" and "constants " from
448 class Block were changed to HybridDictionaries.
450 Atsai results: (56216kb->54987kb)
452 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
455 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
457 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
460 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
462 * expression.cs: foreach loop to for loop, saved on allocation of
463 enumerator (59333kb->59141kb)
465 * statement.cs. Changed foreach loops to for loops, saved on
466 allocation of enumerator (59141kb->59006kb)
468 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
469 when constructed with no specified capacity. This was causing a
470 few ArrayLists to allocate more memory than they would potentially
471 need in the Block class and MemberCache class. Setting the
472 ArrayLists to construct with a capacity of 1 saves some
473 memory. (56216kb->55585kb)
475 2007-12-27 Marek Safar <marek.safar@gmail.com>
477 A fix for bug #347189 (2nd issue)
478 * expression.cs (MemberAccess): Nested type can be found in base non-generic
481 2007-12-27 Miguel de Icaza <miguel@novell.com>
483 * report.cs: Do not use colors if stdout and stderr are not a
486 2007-12-27 Marek Safar <marek.safar@gmail.com>
488 A fix for bug #346998
489 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
492 2007-12-27 Marek Safar <marek.safar@gmail.com>
494 A fix for bug #343465
495 * class.cs: Explicit method name for nested types uses dots only.
497 2007-12-27 Marek Safar <marek.safar@gmail.com>
499 A fix for bug #343707
500 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
502 2007-12-27 Marek Safar <marek.safar@gmail.com>
504 * ecore.cs: Report type inference errors only when arguments count matches
507 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
509 * expression.cs, report.cs: New warning.
511 * typemanager.cs: Catch anonymous method type too.
513 2007-12-23 Marek Safar <marek.safar@gmail.com>
515 A fix for bug #346379
516 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
518 2007-12-23 Marek Safar <marek.safar@gmail.com>
520 A fix for bug #347359
521 * expression.cs (Invocation): Don't resolve already resolved expression.
523 2007-12-23 Marek Safar <marek.safar@gmail.com>
525 A fix for bug #347189
526 * class.cs (FixedField): Use non-dependent code only in the define phase.
528 2007-12-23 Marek Safar <marek.safar@gmail.com>
530 A fix for bug #348076
531 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
533 2007-12-22 Marek Safar <marek.safar@gmail.com>
535 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
536 discovered extension methods.
538 2007-12-22 Marek Safar <marek.safar@gmail.com>
540 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
543 2007-12-21 Miguel de Icaza <miguel@novell.com>
545 * report.cs (ErrorMessage): Add support for using colors on
546 terminals that support it.
548 2007-12-21 Marek Safar <marek.safar@gmail.com>
550 * ecore.cs: Use information about expanded params for error reporting.
552 2007-12-21 Marek Safar <marek.safar@gmail.com>
554 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
555 and logic for params overloads.
557 2007-12-15 Miguel de Icaza <miguel@novell.com>
559 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
560 as this is also created from the parser. Fixes #349034
562 2007-12-12 Miguel de Icaza <miguel@novell.com>
564 * statement.cs (Throw.CloneTo): it is valid to have empty
565 expressions for throw.
567 2007-12-03 Marek Safar <marek.safar@gmail.com>
569 * cs-parser.jay: Set delegate constraint parsing region correctly.
571 2007-12-03 Marek Safar <marek.safar@gmail.com>
573 A fix for bug #345467
574 * typemanager.cs (IsEqual): Compare generic parameters position only.
576 2007-11-28 Marek Safar <marek.safar@gmail.com>
578 * expression.cs (BaseAccess): Type arguments can be null.
580 2007-11-27 Raja R Harinath <harinath@gmail.com>
582 * statement.cs (Block.Resolve): Ensure flow-branching tree is
583 consistent even when an error has occured.
584 (Switch.Resolve): Likewise.
586 2007-11-22 Marek Safar <marek.safar@gmail.com>
588 A fix for bug #334505
589 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
592 2007-11-22 Marek Safar <marek.safar@gmail.com>
594 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
595 refactorings required to resolve extension methods correctly when mixing
596 generics and non-generics members.
598 2007-11-20 Marek Safar <marek.safar@gmail.com>
600 A fix for bug #342584
601 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
604 2007-11-19 Marek Safar <marek.safar@gmail.com>
606 A fix for bug #342512
607 * delegate.cs: Use delegate argument expression when is available. Don't
608 emit virtual call when class is sealed.
610 2007-11-16 Marek Safar <marek.safar@gmail.com>
612 A fix for bug #325423
613 * assign.cs (FieldInitializer): Use resolved expression for emit.
615 * class.cs: Print less confusing error message.
617 2007-11-16 Marek Safar <marek.safar@gmail.com>
619 * cs-tokenizer.cs: Removed GMCS ifdefs.
621 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
624 * cs-parser.jay: Disabled nullable check.
626 * generic-mcs: Copied more generic stuff.
628 2007-11-16 Marek Safar <marek.safar@gmail.com>
630 * gcs-parser.jay: Merged to cs-parser.jay.
632 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
633 * *.csproj, *.sources: Updated to use only jay parser file.
635 2007-11-16 Marek Safar <marek.safar@gmail.com>
637 * gcs-parser.jay: Added nullable and default expression feature checks.
639 2007-11-16 Marek Safar <marek.safar@gmail.com>
641 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
642 it fixes many TODOs and hidden bugs.
644 * expression: Removed duplicate error check.
646 2007-11-15 Marek Safar <marek.safar@gmail.com>
648 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
649 implicitly type local variable only when it is used in a declaration.
651 2007-11-15 Marek Safar <marek.safar@gmail.com>
653 * attribute.cs: Use CS0612 for empty strings.
655 2007-11-14 Marek Safar <marek.safar@gmail.com>
657 * lambda.cs, statement.cs: Contextual return may act as a statement.
659 2007-11-14 Marek Safar <marek.safar@gmail.com>
661 A fix for a regression cause by #324222
662 * class.cs: Don't report unused even when it implements an interface.
664 2007-11-13 Marek Safar <marek.safar@gmail.com>
666 A fix for bug #341205
667 * ecore.cs, expression.cs: Method group expression cannot do static
668 method access with an instance reference check before overloading takes
671 2007-11-13 Marek Safar <marek.safar@gmail.com>
673 A fix for bug #325359
674 * class.cs: Use predictable name for automatically generated property.
676 2007-11-12 Marek Safar <marek.safar@gmail.com>
678 A fix for bug #324996
679 * expression.cs (Is): Handle case where D is nullable and T is not
682 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
684 2007-11-12 Marek Safar <marek.safar@gmail.com>
686 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
687 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
688 Flush small error reporting changes.
690 2007-11-09 Marek Safar <marek.safar@gmail.com>
692 A fix for bug #324996
693 * expression.cs: Rewrote Is expression implementation to work with
694 generics, nullable types, anonymous method. A const result expression
695 uses existing infrastructure instead of custom not fully-featured one.
697 2007-11-08 Marek Safar <marek.safar@gmail.com>
699 A fix for bug #340202
700 * class.cs: Consider generics for volatile field.
702 2007-11-08 Marek Safar <marek.safar@gmail.com>
704 A fix for bug #335594
705 * expression.cs: Use conversion rules when handling string addition.
707 2007-11-07 Marek Safar <marek.safar@gmail.com>
709 A fix for bug #336651
710 * expression.cs: Fixed a crash when probing is on.
712 2007-11-07 Marek Safar <marek.safar@gmail.com>
714 A fix for bug #324242
715 * covert.cs: Added a conversion from any nullable-type with an
716 underlying enum-type to the type System.Enum.
718 2007-11-07 Marek Safar <marek.safar@gmail.com>
720 A fix for bug #324222
721 * class.cs: Report all non-used event fields.
723 2007-11-07 Marek Safar <marek.safar@gmail.com>
725 A fix for bug #325161
726 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
727 qualifier for generic types.
729 2007-11-07 Marek Safar <marek.safar@gmail.com>
731 A fix for bug #322971
732 * expression.cs, ecore.cs: Added intermediate result value check for
735 2007-11-07 Marek Safar <marek.safar@gmail.com>
737 A fix for bug #324754
738 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
739 when it was requested.
741 2007-11-07 Marek Safar <marek.safar@gmail.com>
743 A fix for bug #325101
744 * expression.cs: Do type not value comparison for `is' expression.
746 2007-11-07 Marek Safar <marek.safar@gmail.com>
748 A fix for bug #320236
749 * convert.cs: Don't apply user conversion on underlying target type.
751 2007-11-06 Marek Safar <marek.safar@gmail.com>
753 * expression.cs: Don't use unresolved expression for error reporting.
755 2007-11-06 Marek Safar <marek.safar@gmail.com>
757 A fix for bugs #337712, #324490
758 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
759 overloading resolution too.
761 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
762 the process consistent and more robust.
764 * expression.cs, linq.cs, report.cs: Update.
766 2007-11-02 Marek Safar <marek.safar@gmail.com>
768 A fix for bug #332909
769 * attribute.cs: Resolve attributes in correct context using error
772 * rootcontext.cs: Define Obsolete attribute members as core members.
774 2007-11-02 Marek Safar <marek.safar@gmail.com>
776 * statement.cs: Removed unused methods.
778 2007-10-31 Wade Berrier <wberrier@novell.com>
780 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
781 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
784 2007-10-31 Marek Safar <marek.safar@gmail.com>
786 A fix for bug #338102
787 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
788 methods registered as non-generics.
790 2007-10-31 Marek Safar <marek.safar@gmail.com>
792 A fix for bugs #337712, #324490
793 * delegate.cs: Delegate covariance and contravariance is not allowed for
796 2007-10-31 Marek Safar <marek.safar@gmail.com>
798 A fix for bug #337719
799 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
802 2007-10-30 Marek Safar <marek.safar@gmail.com>
804 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
806 2007-10-29 Marek Safar <marek.safar@gmail.com>
808 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
811 2007-10-29 Raja R Harinath <rharinath@novell.com>
813 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
815 2007-10-29 Marek Safar <marek.safar@gmail.com>
817 A fix for bug #334652
818 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
819 extension methods when we have not found the best candidate in normal
822 2007-10-27 Marek Safar <marek.safar@gmail.com>
824 * AssemblyInfo.cs: Keep up-to-date.
826 2007-10-27 Marek Safar <marek.safar@gmail.com>
828 * Makefile: Fixed generics compiler name.
830 2007-10-27 Marek Safar <marek.safar@gmail.com>
832 * lambda.test: removed, lambda parsing is done differently.
834 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
836 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
838 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
840 2007-10-27 Marek Safar <marek.safar@gmail.com>
842 * Makefile, *.sources : All C# compilers are in mcs folder.
844 * *.cs: Use existing 2_1 define for smcs.
846 2007-10-26 Marek Safar <marek.safar@gmail.com>
848 A fix for bug #335847
849 * assign.cs, expression.cs: Couple of changes to avoid creating a
850 temporary variable for each object initializer assignment statement. It
851 simplifies struct initialization too, otherwise two temporary variables
853 Implemented optimization of redundant default element initializers.
855 2007-10-25 Marek Safar <marek.safar@gmail.com>
857 A fix for bug #336766
858 * expression.cs (Class.CheckBase): Use generic name when method is
861 2007-10-25 Marek Safar <marek.safar@gmail.com>
863 A fix for bug #334737
864 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
865 variable and not variable argument for prepared copies.
867 2007-10-24 Marek Safar <marek.safar@gmail.com>
869 A fix for bug #325110
870 * class.cs, expression.cs, attribute.cs: Use open generic method when
871 checking conditional attribute.
873 2007-10-24 Marek Safar <marek.safar@gmail.com>
875 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
876 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
877 FeatureIsNotAvailable.
879 2007-10-24 Marek Safar <marek.safar@gmail.com>
881 ** C# 3.0 Partial methods
883 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
884 methods support. Because of member cache issue with generics only
885 non-generics partial methods are fully supported.
887 2007-10-23 Marek Safar <marek.safar@gmail.com>
889 * class.cs, decl.cs: Rewrote member overloads check to cope with
890 generics and to use member cache for member checking. It also improves
891 performance and fixes remaining overloads issues.
893 2007-10-20 Marek Safar <marek.safar@gmail.com>
895 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
896 roottypes.cs, typemanager.cs:
898 A member cache creation logic changed to add members immediately and
899 not rely on fallback. The member cache is now only prefered way
900 how to access and find type declaration members. It saves 5 MB of memory
901 during MWF compilation and makes code ready for more optimizations and
902 clean-ups, it's also a pre-requirement for partial methods.
904 2007-10-18 Raja R Harinath <harinath@gmail.com>
906 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
907 handling for generic parameters.
909 2007-10-15 Marek Safar <marek.safar@gmail.com>
911 * class.cs (FixedField): Removed redundant volatile check.
913 2007-10-15 Marek Safar <marek.safar@gmail.com>
915 * class.cs, decl.cs: Fixed overload members verification to do only one
916 check per possible collision.
918 2007-10-13 Marek Safar <marek.safar@gmail.com>
920 A fix for bug #325478
921 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
922 and create only one disposable flags container.
924 2007-10-12 Marek Safar <marek.safar@gmail.com>
926 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
927 * statement.cs (Fixed): Fixed variables cloning.
929 2007-10-12 Marek Safar <marek.safar@gmail.com>
931 A fix for bug #333342
932 * class.cs (EventField): Don't mark value type event as synchronized.
934 2007-10-12 Marek Safar <marek.safar@gmail.com>
936 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
937 inference to identify best candidate method correctly.
938 (ProperyExpr): A range variable is read only and cannot be modified.
940 2007-10-11 Marek Safar <marek.safar@gmail.com>
942 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
943 logic to identify best candidate method correctly.
945 2007-10-11 Marek Safar <marek.safar@gmail.com>
947 * location.cs (Equals, GetHashCode): Removed.
949 2007-10-11 Marek Safar <marek.safar@gmail.com>
951 * report.cs: Implemented message recorder. It is used mainly for lambda
952 expressions to capture otherwise swallowed error messages.
954 * anonymous.cs, lambda.cs.cs: Do full parameters check.
956 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
958 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
960 * expression.cs (MemberAccess): Always report lookup failure.
962 * location.cs: Implemented Equals, GetHashCode.
964 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
966 2007-10-10 Jb Evain <jbevain@novell.com>
968 * codegen.cs: re-enable assembly version check.
970 2007-10-09 Marek Safar <marek.safar@gmail.com>
972 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
975 * namespace.cs (UsingAlias): Do correct version check.
977 2007-10-08 Marek Safar <marek.safar@gmail.com>
979 * expresison.cs, ecore.cs: Issue extension method error message when
982 * rootcontext.cs: Added ISO_2 compiler mode option.
984 2007-10-08 Marek Safar <marek.safar@gmail.com>
986 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
989 2007-10-08 Marek Safar <marek.safar@gmail.com>
991 * attribute.cs (GetString, GetBoolean): Work with both literal and
994 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
995 Moved method overload specific methods to MethodGroupExpr.
997 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
998 it should be less memory consuming.
1000 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
1002 * codegen.cs: remove the assembly version check until the buildbot is
1005 2007-10-07 Jb Evain <jbevain@novell.com>
1007 * attribute.cs (Attribute.GetString): if the value
1008 expression is a StringConstant, return its string value.
1010 2007-10-07 Jb Evain <jbevain@novell.com>
1012 * typemanager.cs: add `assembly_version_attribute_type`.
1013 * codegen.cs: on attribute emission, check that the
1014 AssemblyVersionAttribute doesn't overflow.
1016 2007-10-05 Marek Safar <marek.safar@gmail.com>
1018 A fix for bug #324677
1019 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
1020 parent container of a scope container with currently resolved one.
1022 2007-10-05 Marek Safar <marek.safar@gmail.com>
1024 A fix for bug #325534
1025 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
1028 2007-10-05 Marek Safar <marek.safar@gmail.com>
1030 A fix for bug #327504
1031 * class.cs (Operator.Define): Refactored implicit and explicit user
1032 operator conversion rules.
1034 2007-10-05 Marek Safar <marek.safar@gmail.com>
1036 A fix for bug #327520
1037 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
1039 2007-10-04 Marek Safar <marek.safar@gmail.com>
1041 A fix for bug #328022
1042 * class.cs (MethodData.Define): Use correct method to check whether
1043 a method implementents an accessor.
1045 2007-10-04 Marek Safar <marek.safar@gmail.com>
1047 A fix for bug #330069
1048 * statement.cs (Fixed.Resolve): Read the first array element only when
1049 an array is instantiated.
1051 2007-10-04 Marek Safar <marek.safar@gmail.com>
1053 * expression.cs, assign.cs, generics.cs: Print correct operator when
1054 compound assignment is used.
1056 2007-10-04 Marek Safar <marek.safar@gmail.com>
1058 A fix for bug #325841
1059 * expression.cs (ArrayAccess): Use full argument cloning only for
1060 string compound concatenation.
1062 2007-10-03 Marek Safar <marek.safar@gmail.com>
1064 A fix for bug #328774
1065 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
1067 (PropertyExpr.EmitAssign): Fixed string concatenation compound
1070 2007-10-03 Raja R Harinath <rharinath@novell.com>
1073 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
1074 Event accessibility checks here. Remove some bogus code that
1075 accidently made GenericMethods work.
1076 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
1078 2007-09-25 Marek Safar <marek.safar@gmail.com>
1080 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
1082 * statement.cs (Block): Refactored AddVariable to allow error handling
1085 * generic.cs: New stub.
1087 2007-09-23 Marek Safar <marek.safar@gmail.com>
1089 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
1092 2007-09-17 Marek Safar <marek.safar@gmail.com>
1094 * class.cs: Use partial container to record whether any partial part
1095 contains static field initializer and therefore default contructor has
1098 2007-09-14 Marek Safar <marek.safar@gmail.com>
1100 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
1101 mono-list when only one of two partial parts has defined accessibility
1104 2007-09-14 Marek Safar <marek.safar@gmail.com>
1106 A fix for bug #82845
1108 * class.cs (TypeContainer): Set correct resolve context for all field
1111 2007-09-13 Marek Safar <marek.safar@gmail.com>
1113 * assign.cs: Fixed a crash when field is resolved twice with an error.
1115 * codegen.cs: Changed InFieldInitializer to be flag.
1117 * anonymous.cs, ecore.cs, expression.cs: Update after
1118 IsInFieldInitializer rename.
1120 * const.cs: Removed unused parameter.
1122 * class.cs: Changed the way how we resolve and emit field initializers.
1123 The field initilizers have to have access to contructor block to emit
1124 compiler generated code.
1126 2007-09-13 Marek Safar <marek.safar@gmail.com>
1128 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
1129 generics use TypeContainer instead.
1131 2007-09-12 Marek Safar <marek.safar@gmail.com>
1133 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
1135 * lambda.cs (ResolveParameters): Use more powerful
1136 InflateGenericArgument.
1138 * parameters.cs: Better exception message.
1140 2007-09-10 Marek Safar <marek.safar@gmail.com>
1142 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
1143 correct expression block type.
1145 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
1147 * expression.cs (Invocation): Extracted method group resolve to
1150 2007-09-07 Marek Safar <marek.safar@gmail.com>
1152 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
1153 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
1155 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
1156 generic extension methods.
1158 2007-09-06 Marek Safar <marek.safar@gmail.com>
1160 A fix for bug #82676 (Do I get it right now?)
1161 * convert.cs (Binary.ResolveOperator): An interface is converted to the
1162 object before a standard conversion is applied.
1164 2007-09-06 Marek Safar <marek.safar@gmail.com>
1166 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
1169 2007-09-05 Marek Safar <marek.safar@gmail.com>
1171 A fix for bug #82676
1172 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
1173 non-generic interface types.
1175 2007-09-05 Marek Safar <marek.safar@gmail.com>
1177 A fix for bug #82690
1178 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
1180 2007-09-05 Marek Safar <marek.safar@gmail.com>
1182 A fix for bug #82571
1183 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
1184 modifier for container based methods.
1186 2007-09-05 Marek Safar <marek.safar@gmail.com>
1188 A fix for bug #82676
1189 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
1190 any interface-type T means to any of interface type T.
1192 2007-09-04 Marek Safar <marek.safar@gmail.com>
1194 * namespace.cs: We have 2 versions of System.Core assembly.
1196 2007-09-04 Marek Safar <marek.safar@gmail.com>
1198 A fix for bug #82652
1199 * class.cs (Class.GetClassBases): Compare types and not expressions.
1201 2007-09-04 Marek Safar <marek.safar@gmail.com>
1203 A fix for bug #82620
1204 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
1205 actually never worked before.
1206 (IndexerAccess): Emit prepared arguments before they are modified.
1208 2007-09-04 Marek Safar <marek.safar@gmail.com>
1210 A fix for bug #82563
1211 * assign.cs: Revert wrong fix.
1213 * expression.cs (VariableReference.EmitAssign): Handle ref reference
1215 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
1216 Instead of ldelema/stdind we have to use temporary variables to handle
1217 cases like String.Concat (params string[]).
1219 2007-08-31 Marek Safar <marek.safar@gmail.com>
1221 * class.cs: EmitAttributes to Emit rename.
1223 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
1225 (MemberCore.HasClsCompliantAttribute): Don't depend on
1226 GetClsCompliantAttributeValue execution.
1228 2007-08-31 Marek Safar <marek.safar@gmail.com>
1230 * anonymous.cs: Use shorter type prefix.
1232 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
1235 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
1236 variables when probing is on.
1238 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
1239 unresolved variables.
1240 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
1241 handle transparent identifiers.
1243 2007-08-26 Marek Safar <marek.safar@gmail.com>
1245 * attribute.cs (IsClsCompliant): Add nullable types test.
1247 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
1249 * doc.cs : catch other types of exception than XmlException to
1250 report CS1570. Fixed bug #82565.
1252 2007-08-23 Marek Safar <marek.safar@gmail.com>
1254 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
1255 The number of delegate parameters has to match.
1256 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
1259 2007-08-21 Marek Safar <marek.safar@gmail.com>
1261 * anonymous.cs (AnonymousMethod): Generate private anonymous method
1262 to fix problem with private arguments.
1264 2007-08-20 Marek Safar <marek.safar@gmail.com>
1266 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
1268 * decl.cs (MemberName): Ignore generic type with no generic arguments.
1270 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
1271 empty. Add cloning suport.
1273 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
1275 2007-08-20 Marek Safar <marek.safar@gmail.com>
1277 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
1278 to create EmptyCast. It handles EmptyConstantCast specialization for
1281 2007-08-18 Marek Safar <marek.safar@gmail.com>
1283 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
1284 (EmitArrayArgument): One routine for array arguments.
1285 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
1287 2007-08-17 Marek Safar <marek.safar@gmail.com>
1289 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
1291 2007-08-17 Marek Safar <marek.safar@gmail.com>
1293 * anonymous.cs: MemberLookupFinal update.
1295 * class.cs (ConstructorInitializer): Is expression based.
1297 * delegate.cs: MethodGroupExpr update.
1299 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
1301 (Error_MemberLookupFailed): Customizable error override.
1302 (MethodGroupExpr): Keep queried type for later usage.
1303 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
1306 * expression.cs: Error_MemberLookupFailed refactoring.
1307 (New.DoResolve): Resolve as much as possible.
1308 (ElementInitializer.Error_MemberLookupFailed): Object initializer
1309 customization for invalid member types.
1311 * statement.cs: MethodGroupExpr update.
1313 2007-08-16 Marek Safar <marek.safar@gmail.com>
1315 * modifier.cs (Check): Check all modifiers and not only accessibility
1318 2007-08-16 Marek Safar <marek.safar@gmail.com>
1320 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
1321 type and not an expression.
1323 2007-08-16 Marek Safar <marek.safar@gmail.com>
1325 * statement.cs (Catch.Clone): Type and variable can be null.
1327 2007-08-16 Marek Safar <marek.safar@gmail.com>
1329 A fix for bug #81979
1330 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
1331 I am really not sure whether this is the best fix.
1333 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
1336 2007-08-14 Marek Safar <marek.safar@gmail.com>
1338 ** C# 3.0 Object and collection initializers (major re-write)
1340 * assign.cs (DoResolve): Initializers are not assign related.
1342 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
1343 used during collection or object initialization.
1345 * expression.cs (Error_InvalidArguments): Add initializers specific
1346 messages. More will come later because it requires some general
1348 (New.DoResolve): Better error handling for unsafe types.
1349 (EmptyExpressionStatement): New class.
1350 (ElementInitializer): An object initializer expression.
1351 (CollectionElementInitializer): A collection initializer expression.
1352 (CollectionOrObjectInitializers): A block of object or collection
1354 (NewInitialize): New expression with element/object initializers.
1356 * statement.cs: Reverted object/collection initializer hacks.
1358 * typemanager.cs (CSharpName): Filter __arglist type.
1360 2007-08-09 Marek Safar <marek.safar@gmail.com>
1362 ** C# 3.0 Anonymous Types (update to the latest standard)
1364 * expression.cs (Binary.ResolveOperator): Threat all null based types
1366 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
1367 (AnonymousTypeParameter): Updated.
1369 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
1370 (AnonymousTypeClass): New anonymous type container.
1372 * class.cs (AddField): Return operation result.
1374 * generic.cs: Another empty TypeArguments overload.
1376 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
1377 are stored at top of normal hierarchy.
1379 * typemanager.cs (CSharpName): Filter anonymous types.
1381 2007-08-09 Marek Safar <marek.safar@gmail.com>
1383 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
1384 as single Concat call. How could we miss that :-(
1386 2007-08-08 Marek Safar <marek.safar@gmail.com>
1388 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
1390 2007-08-07 Miguel de Icaza <miguel@novell.com>
1392 * expression.cs: Fix the previous commit, the creation of the
1393 arguments array list needs also to be conditional on the arguments
1396 * class.cs: Add a little bit of help to help narrow down problems.
1398 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
1399 not try to copy in that case.
1401 * driver.cs: When building SMCS, include a new different set of
1402 default assemblies here. Do this here so we can control whether
1403 to include the default assemblies with /noconfig.
1405 2007-08-03 Marek Safar <marek.safar@gmail.com>
1407 A fix for bug #81979
1408 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
1411 2007-08-03 Marek Safar <marek.safar@gmail.com>
1413 A fix for bug #82300
1415 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
1416 we are in probing scope.
1418 2007-08-03 Marek Safar <marek.safar@gmail.com>
1420 A fix for bug #82301
1422 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
1423 (Statement.CloneTo): Clone and not map children blocks.
1425 2007-08-03 Marek Safar <marek.safar@gmail.com>
1427 A fix for bug #82299
1429 * expression.cs (LocalVariableReference.CloneTo): Remap local info
1432 * statement.cs (Statement.CloneTo): Clone variables before statements
1433 to allow remaping of local variables.
1435 2007-08-03 Marek Safar <marek.safar@gmail.com>
1437 A fix for bug #82296
1440 * report.cs: Log crash details for future clone problems.
1442 * statement.cs (Return.Clone): Don't clone non-existent expression.
1444 2007-08-03 Raja R Harinath <harinath@gmail.com>
1446 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
1447 (Class.AddBasesForPart): Move CS0537 check here from ...
1448 * cs-parser.jay (class_declaration): ... here. Move calling of
1449 'AddBasesForPart' to ...
1450 (class_bases): ... here.
1451 (struct_declaration, interface_declaration): Update to changes.
1453 2007-08-02 Marek Safar <marek.safar@gmail.com>
1455 A fix for bug #81923
1457 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
1458 conversion is allowed.
1460 2007-08-02 Marek Safar <marek.safar@gmail.com>
1462 A fix for bug #81564
1464 * ecore.cs (EventExpr): Add IsBase handling.
1466 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
1469 2007-08-02 Raja R Harinath <harinath@gmail.com>
1471 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
1472 * cs-parser.jay: Some whitespace cleanups.
1473 (current_delegate): New.
1475 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
1476 a dummy code block, and use 'type_name' instead of 'member_name'.
1477 (interface_declaration, class_declaration): Likewise.
1478 (delegate_declaration): Likewise. Rearrange slightly and use
1480 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
1481 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
1483 2007-08-02 Marek Safar <marek.safar@gmail.com>
1485 A fix for bug #82039
1487 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
1490 * typemanager.cs (CSharpName): Split to string overload.
1492 2007-08-02 Marek Safar <marek.safar@gmail.com>
1495 * report.cs: Updated warning CS0472.
1497 2007-08-01 Marek Safar <marek.safar@gmail.com>
1499 A fix for bug #82181
1501 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
1503 2007-08-01 Marek Safar <marek.safar@gmail.com>
1505 A fix for bug #82277
1506 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
1508 2007-08-01 Marek Safar <marek.safar@gmail.com>
1510 ** C# 3.0 Type Inference (major bits are working)
1512 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
1513 (.ImplicitStandardConversionExists): Uses compatible.
1514 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
1515 (.InferReturnType): New method.
1516 (.Compatible): Refactored.
1517 (.ResolveParameters): Uses factory to create resolved parameters.
1518 (.CompatibleMethod): Add probing mode support.
1519 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
1520 clearly distinguish between 2 different operations.
1521 (LambdaMethod): Moved to lambda.cs.
1522 (AnonymousMethod): Removed unused fields and methods.
1523 (AnonymousDelegate): Simplified.
1525 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
1527 * convert. cs (ImplicitConversionStandard): Compatible works differently.
1529 * delegate.cs (Delegate): New mehods to reduce code duplication.
1530 (.GetConstructor): New method.
1531 (.GetInvokeMethod): New method.
1532 (DelegateCreation): Updated.
1534 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
1536 (OverloadResolve): Made probing little bit faster.
1538 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
1541 * generic.cs (TypeInferenceContext): Dummy implementation.
1543 * iterators.cs: Updated after Resolve/Define rename.
1545 * lambda.cs (LambdaExpression)
1546 (.ResolveParameters): Handles both type of arguments and type inference too.
1548 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
1549 (InflateTypes): Updated.
1551 * support.cs (InflateTypes): Changed signature and updated.
1553 * typemanager.cs (LookupMemberCache): Better dynamic type check.
1554 (MemberLookup_FindMembers): More MS tricks.
1555 (GetParameterData): Ditto.
1556 (GetDelegateParameters): Uses quick path for dynamic types.
1558 2007-08-01 Marek Safar <marek.safar@gmail.com>
1560 * class.cs (MethodData.Define): EmitContext is required for generic stuff
1563 2007-07-31 Marek Safar <marek.safar@gmail.com>
1565 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
1568 2007-07-26 Jb Evain <jbevain@novell.com>
1570 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
1571 which takes a boolean 'report_errors', similar to the GetMethod.
1572 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
1573 in .net 2.1, do not report errors here.
1575 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
1576 System.Runtime.CompilerServices.RequiredAttributeAttribute and
1577 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
1580 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
1581 of the type InternalsVisibleToAttribute before the first call
1582 to CoreLookupType which is allowed to fail (third boolean parameter
1583 to true). Because, during the resolution for a type that is not
1584 immediately found, we try to check if the type is not defined in
1585 a friend assembly, and to do so, we need the
1586 InternalVisibleToAttribute.
1588 2007-07-23 Miguel de Icaza <miguel@novell.com>
1590 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
1591 feature that allows structs to be compared against null and inline
1592 the result as true or false.
1594 Notice that the same code is not permitted inside a generic block
1595 of code that would do:
1597 class Foo<T> where T : struct {
1604 It is only allowed if the type of T is not bound (no where
1605 clause). In my opinion, this CSC 2 behavior is broken but people
1606 seem to be using it (IronRuby does, a few bug reports on bugzilla
1607 have it and some people have complained about it).
1609 All of the users that depend on this behavior have code that is
1612 * report.cs (Warning, Error): make these take object arguments,
1613 not strings, as that allows us to take advantage of Format.
1615 2007-07-20 William Holmes <billholmes54@gmail.com>
1617 * decl.cs: Changed MemberName.CountTypeArguments to also check the
1618 Left member variable for the Count.
1619 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
1620 MemberName.CountTypeArguments to avoid a NRE.
1622 This code is contributed under the MIT X11 license
1624 2007-07-18 Marek Safar <marek.safar@gmail.com>
1626 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
1628 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1630 * doc.cs : generic method arguments are written as ``x while generic
1631 type arguments are `x. Combined with the previous change, fixed bug
1634 2007-07-18 Raja R Harinath <rharinath@novell.com>
1637 * expression.cs (Binary.ResolveOperator): When converting
1638 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
1640 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1642 * doc.cs : when T: or whatever x: is specified, it does not really
1643 check the doc comment's syntax correctness. Fixed bug #82006.
1645 2007-07-18 Marek Safar <marek.safar@gmail.com>
1647 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
1648 LambdaExpression better.
1650 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
1652 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
1654 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
1655 as it can be generated.
1657 * expression.cs (Invocation.Error_InvalidArguments): Show correct
1660 * lambda.cs (LambdaExpression): Refactored to share same code with
1661 AnonymousMethodExpression.
1663 2007-07-17 Marek Safar <marek.safar@gmail.com>
1665 * anonymous.cs (MakeName): Include host name for easier debugging.
1666 (LambdaMethod): New class for lambda spcecific stuff.
1668 * attribute.cs: Set EmitContext return type.
1670 * class.cs: Set EmitContext return type.
1672 * codegen.cs (EmitContext): Return type cannot be null to stop messing
1673 with null/void meaning.
1675 * iterators.cs (ContainerType): Implemented.
1677 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
1679 * statement.cs (Return): Updated to lambda expressions.
1680 (Block.CloneTo): Parent can be null.
1682 2007-07-13 Marek Safar <marek.safar@gmail.com>
1684 A fix for bug #81917
1685 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
1687 * class.cs (FixedField): Check whether field is in unsafe scope.
1689 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
1690 (FieldExpr.Emit): Fixed buffers cannot be volatile.
1692 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
1695 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
1697 2007-07-13 Marek Safar <marek.safar@gmail.com>
1699 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
1700 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
1703 2007-07-13 Marek Safar <marek.safar@gmail.com>
1705 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
1707 2007-07-13 Marek Safar <marek.safar@gmail.com>
1709 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
1710 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
1712 * codegen.cs(EmitContext): Add ProbingMode flag.
1714 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
1716 * driver.cs: For now set both warning values.
1718 * ecore.cs (SimpleName): Name is readonly.
1719 (MethodGroup.OverloadResolve): One quick path for probing.
1721 * expression.cs (Unary): Set Oper r/o.
1722 (Binary): Set Oper r/o.
1723 (ParameterReference): Set few instance variables as r/o.
1724 (ParameterReference.DoResolveBase): Don't capture aruments when
1726 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
1727 (Arglist): arguments are private.
1728 (SizeOf): type is private and r/o.
1729 (MemberAccess): arguments are private.
1731 * report.cs: Enhanced reporting on/off capabilities.
1733 * lambda.cs: Uses ec.IsInProbingMode.
1734 (ContextualReturn): Derives from return.
1736 * rootcontext.cs: For now set both warning values.
1738 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
1740 (Return.Resolve): Don't die immediately.
1741 (Block.Resolve): Speed-up probing.
1742 (Block.CloneTo): Clone only child blocks.
1744 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
1746 * iterators.cs: reverted Miguel's latest change (r81925) as it
1747 breaks the build in System.
1749 2007-07-13 Miguel de Icaza <miguel@novell.com>
1751 * iterators.cs (Yield.CheckContext): Check for the iterator type
1752 also here as we can call into Yield even in codepaths that are not
1754 (MethodOrOperator is the only path that was checked).
1756 In addition to the standard check, use a more specific check for
1757 constructors to report a more verbose error.
1759 2007-07-12 Miguel de Icaza <miguel@novell.com>
1761 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
1762 report the warning and continue
1764 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
1765 values on the stack on the call to Emit. Use EmitStatement if
1766 possible, or using Emit + Pop if not possible. Fixes #82064
1768 2007-07-12 Raja R Harinath <rharinath@novell.com>
1770 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
1771 avoid try...finally in some cases.
1773 2007-07-10 Marek Safar <marek.safar@gmail.com>
1775 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
1777 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
1778 instead of method. Re-use standard error handling.
1779 (ConstructorInitializer.Emit): Simplified.
1781 * delegate.cs: Updated after Invocation.EmitCall change.
1783 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
1784 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
1785 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
1786 method and don't permanently changing input arguments.
1787 (MethodGroupExpr): Introduced resolved best_candidate, when method group
1788 is resolved it has one of the candidates is the best one which is later
1789 used to emit. Removed a few unused method.
1790 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
1792 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
1793 (Binary.ResolveOperator): Ditto.
1794 (ConditionalLogicalOperator.DoResolve): Ditto.
1795 (Invocation): Uses method group.
1796 (Invocation.DoResolve): Simplified.
1797 (Invocation.EmitCall): Removed useless is_static.
1798 (Invocation.Emit): Delegate to method group.
1799 (Invocation.EmitStatement): Simplified.
1800 (New): Uses method group.
1801 (MemberAccess.DoResolve): Don't destroy original expression.
1803 * statement.cs (ForEach.Resolve): Use null for no method arguments.
1805 2007-07-04 Marek Safar <marek.safar@gmail.com>
1807 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
1810 * lambda.cs: Add custom error message type.
1812 2007-07-03 Marek Safar <marek.safar@gmail.com>
1814 * lambda.cs: Simplified little bit.
1816 * parameter.cs: Introduced ImplicitLambdaParameter.
1817 (Parameters.CreateFullyResolved): New factory instead of ctor.
1821 * delegate.cs: Updated parameter creation.
1823 2007-07-03 Marek Safar <marek.safar@gmail.com>
1825 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
1828 * generic.cs: Synchronized with gmcs.
1830 2007-07-03 Marek Safar <marek.safar@gmail.com>
1832 * class.cs (Indexer): Check return type as soon as possible.
1834 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
1837 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
1839 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
1841 * parameter.cs (Parameter): Use expression type when it is available.
1843 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
1844 method modifier for the first parameter only.
1846 2007-06-24 Marek Safar <marek.safar@gmail.com>
1848 A fix for bug #81938
1849 * typemanager.cs (ChangeType): Fixed couple of char conversions.
1851 * constant.cs: Tide up an exception message.
1853 2007-06-22 Marek Safar <marek.safar@gmail.com>
1855 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
1856 an uninitialized variable is used.
1858 * expression.cs (LocalVariableReference.DoResolve): Ditto.
1860 2007-06-22 Marek Safar <marek.safar@gmail.com>
1862 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
1863 not found error handling.
1865 * expression.cs (ArrayCreation): Removed redundant fields and little bit
1867 (ArrayCreation.ResolveArrayElement): To be ready to customization.
1868 (ArrayCreation.DoResolve): Simplified.
1869 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
1870 its own resolve process.
1871 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
1873 2007-06-20 Marek Safar <marek.safar@gmail.com>
1875 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
1878 2007-06-20 Marek Safar <marek.safar@gmail.com>
1880 * cs-tokenizer.cs: Removed var related stuff.
1882 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
1883 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
1884 a type and a keyword at same time.
1886 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
1889 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
1890 implicitly typed arrays, more changes will follow.
1892 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
1894 2007-06-19 Marek Safar <marek.safar@gmail.com>
1896 * ecore.cs (VarExpr): Removed Handled field.
1898 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
1899 build-in assign functionality.
1900 (ForEach.Resolve): Removed all implicitly typed local variable code and
1902 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
1903 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
1905 2007-06-18 Marek Safar <marek.safar@gmail.com>
1907 * assign.cs: Removed implicitly typed local variable check.
1909 * expression.cs (LocalVariableReference.DoResolve): Add check for self
1910 referencing implicitly typed local variable.
1911 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
1914 * statement.cs (Fixed): Removed unsupported implicitly typed local
1917 2007-06-15 Marek Safar <marek.safar@gmail.com>
1919 * decl.cs (MemberName): Moved all Unbound stuff to parser.
1921 2007-06-14 Marek Safar <marek.safar@gmail.com>
1923 A fix for bugs #81855 and #76274
1924 * attribute.cs (AttachTo): Always set owner for global attributes to
1927 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
1930 * cs-parser.jay: Assembly and module attributes must precede all other
1931 elements except using clauses and extern alias declarations.
1933 2007-06-13 Marek Safar <marek.safar@gmail.com>
1935 A fix for bug #81748
1937 * expression.cs: More checks for non ISO-1 features.
1939 2007-06-12 Marek Safar <marek.safar@gmail.com>
1941 A fix for bug #81807
1942 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
1943 present inside switch statement and it is required by nullable check.
1945 2007-06-12 Marek Safar <marek.safar@gmail.com>
1947 A fix for bug #81840
1948 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
1949 when type matching fails.
1951 * namespace.cs: Tiny error message change.
1953 2007-06-12 Marek Safar <marek.safar@gmail.com>
1955 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
1956 reporting. Added automatic property check.
1958 * class.cs: Updated after CheckAbstractAndExtern relocation.
1959 (AEventPropertyAccessor.GetSignatureForError): Customized.
1961 2007-06-11 Marek Safar <marek.safar@gmail.com>
1963 * class.cs (DefineBaseTypes): Base type can be undefined.
1965 * ecore.cs (TypeLookup): Minor refactoring.
1966 (DoResolveAsTypeStep): Removed redundant check.
1968 * namespace.cs (Lookup): Removed redundant check.
1970 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
1971 ResolveAsTypeTerminal step.
1972 (BootstrapCorlib_*): Simplified.
1973 (PopulateCoreType): Core types can be now external.
1975 2007-06-07 Marek Safar <marek.safar@gmail.com>
1977 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
1979 (InferTypeArguments): Infers anonymous expression type arguments.
1980 (Compatible): Split to Compatible and InferTypeArguments.
1982 * lambda.cs: Updated.
1984 2007-06-08 Marek Safar <marek.safar@gmail.com>
1986 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
1988 2007-06-07 Raja R Harinath <harinath@gmail.com>
1990 Fix #80477, cs0135-2.cs, cs0135-3.cs
1991 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
1992 names to the "known" variables list.
1993 (Block.CheckInvariantMeaningInBlock): Handle the fact the
1994 parameter names are also "known".
1995 (Block.CheckError136): Remove.
1996 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
1999 2007-06-07 Marek Safar <marek.safar@gmail.com>
2001 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
2003 2007-06-06 Marek Safar <marek.safar@gmail.com>
2005 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
2006 internal error not an user error.
2008 * expression.cs (IsApplicable): Refactored to make debugging easier.
2010 * support.cs: More tricks for non-mono runtimes.
2012 * typemanager.cs (CoreLookupType): Made public.
2013 (InitSystemCore): All linq specific stuff moved to linq.cs
2015 2007-06-05 Marek Safar <marek.safar@gmail.com>
2017 * typemanager.cs (CSharpSignature): One more missing build-in types
2019 More tricks for non-mono runtime.
2021 2007-06-05 Raja R Harinath <harinath@gmail.com>
2023 * statement.cs (Block.CheckError136_InParents): Remove.
2024 (Block.AddVariable): Use GetParameterInfo instead.
2025 (ToplevelBlock.ProcessArguments): Likewise.
2027 2007-06-04 Raja R Harinath <rharinath@novell.com>
2029 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
2031 (ToplevelBlock.GetParameterInfo): Split out of ...
2032 (ToplevelBlock.GetParameterRefernce): ... this.
2033 (ToplevelBlock.ParameterMap): Remove.
2034 * expression.cs (ParameterReference): Update to use
2035 ToplevelParameterInfo.
2037 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
2040 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
2041 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
2043 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
2044 (ToplevelBlock.ProcessParameters) ... here.
2045 (ToplevelBlock..ctor): Invoke it.
2047 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
2050 * statement.cs (IKnownVariable): New interface.
2051 (LocalInfo): Implement it.
2052 (ToplevelParameterInfo): New class.
2053 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
2054 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
2055 GetKnownVariableInfo.
2057 2007-06-03 Raja R Harinath <harinath@gmail.com>
2059 Partly speed up CS0136 error checks.
2060 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
2061 'recurse' parameter.
2062 (Block.DoCheckError136): Only check errors in parameters. Move
2063 local variable checks ...
2064 (Block.AddVariable): ... here, and ...
2065 (ToplevelBlock.ResolveMeta): ... here.
2067 2007-06-02 Raja R Harinath <harinath@gmail.com>
2069 * statement.cs (Block.IsChildOf): Remove.
2071 * statement.cs (Statement.Clone): Move special case code ...
2072 (Block.CloneTo): ... here.
2074 2007-05-29 Raja R Harinath <rharinath@novell.com>
2076 * statement.cs (ToplevelBlock.container): Remove field. It's
2077 redundant with 'Parent'.
2078 (ToplevelBlock.ContainerBlock): Remove accessor.
2079 (ToplevelBlock..ctor): Update to changes. Register anonymous
2080 child with parent here, ...
2081 * cs-parser.jay (end_anonymous): ... not here. Don't modify
2083 (start_anonymous): Don't save current_block.
2084 (top_current_block): Remove.
2086 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
2087 (Block.Resolve): Update to changes.
2088 (Block..ctor): Move setting of "correct" 'Toplevel'
2089 and 'Explicit' fields to ...
2090 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
2092 2007-05-27 Raja R Harinath <harinath@gmail.com>
2095 * statement.cs (Block.Implicit): Remove.
2096 (Block): Update to changes.
2097 * flowanalysis.cs: Likewise.
2099 Mildly speed up CheckInvariantMeaningInBlock
2100 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
2101 Recursively call AddKnownVariable to all enclosing blocks.
2102 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
2103 Remove recursive calls.
2104 (Block): Update to changes.
2106 New ExplicitBlock invariants
2107 * statement.cs (Block.Explicit): New field. It points to the
2108 immediately enclosing non-implicit block.
2109 (Block..ctor): Maintain the invariant.
2110 * cs-parser.jay: Take advantage of invariant.
2112 Introduce ExplicitBlock
2113 * statement.cs (ExplicitBlock): New.
2114 (ToplevelBlock): Derive from it.
2115 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
2117 (Block.Implicit): Update to changes.
2118 * cs-parser.jay: Update to changes.
2121 * codegen.cs (EmitContext.IsLastStatement): Remove.
2122 * statement.cs (Block.DoEmit): Update to changes.
2124 2007-05-25 Raja R Harinath <rharinath@novell.com>
2126 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
2127 modifying current_block directly.
2129 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
2131 * class.cs: Implemented automatic properties (C# 3.0)
2132 Thanks to Marek for the help.
2134 2007-05-23 Raja R Harinath <rharinath@novell.com>
2136 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
2137 variable as assigned, note also that all its components are
2139 (MyBitVector.SetRange): New. Function to set multiple bits to true.
2141 2007-05-19 Marek Safar <marek.safar@gmail.com>
2143 * anonymous.cs, class.cs: Emit Compiler generated attribute when
2144 member is marked as compiler generated.
2146 * decl.cs (MemberCore): Refactored ModFlags into property.
2148 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
2149 (Check): Check only accessibility modifiers.
2151 2007-05-18 Raja R Harinath <rharinath@novell.com>
2153 Track all assignable slots in one bit array
2154 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
2155 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
2156 logic from VariableMap constructor here. Use the same 'offset'
2157 variable that's later used for computing offsets of local
2159 * flowanalysis.cs (UsageVector.parameters): Remove.
2160 (UsageVector): Update to changes.
2161 (VariableMap): Remove.
2163 Avoid creating ParameterMap in every block
2164 * statement.cs (Block.ParameterMap): Move ...
2165 (ToplevelBlock.ParameterMap): ... here.
2166 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
2168 * flowanalysis.cs (FlowBranching.param_map): Remove.
2169 (FlowBranching.UsageVector): Update to changes.
2170 (FlowBranchingToplevel.CheckOutParameters): Likewise.
2172 * statement.cs (Block.CloneTo): Clone Toplevel field too.
2174 * expression.cs (ParameterReference): Distinguish between block
2175 where parameter was referenced and declared.
2177 2007-05-18 Marek Safar <marek.safar@gmail.com>
2179 * flowanalysis.cs, statement.cs: Put back improved error handling.
2181 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
2185 Imporved object and collection initialization (C# 3.0).
2187 2007-05-15 Marek Safar <marek.safar@gmail.com>
2189 A fix for bug #81380
2190 * expression.cs (Is.DoResolve): Only value types have constant `is'
2193 2007-05-15 Raja R Harinath <rharinath@novell.com>
2195 * statement.cs (ToplevelBlock.child): Remove.
2197 2007-05-15 Raja R Harinath <harinath@gmail.com>
2199 Rationalize ResolveMeta: refactoring
2200 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
2201 out constant handling code into ...
2202 (Block.DoResolveConstants): ... this.
2204 Rationalize ResolveMeta: kill local_map
2205 * statement.cs (Block.local_map, Block.LocalMap): Remove.
2206 (Block.AssignableSlots): New.
2207 (Block.ResolveMeta): Make protected. Don't create a VariableMap
2208 for locals -- move code from VariableMap here. Avoid unnecessary
2210 * flowanalysis.cs (FlowBranching.local_map): Remove.
2211 (FlowBranching..ctor): Use Block.AssignableSlots.
2212 (VariableMap): Remove unused constructors.
2214 2007-05-11 Raja R Harinath <rharinath@novell.com>
2216 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
2218 2007-05-11 Marek Safar <marek.safar@gmail.com>
2220 * typemanager.cs (IsFriendAssembly): Should not be called for building
2223 2007-05-09 Marek Safar <marek.safar@gmail.com>
2225 * literal.cs (NullConstant): Print null in all cases.
2227 * expression.cs (Binary.ResolveOperator): Implemented delegate
2228 comparison based on C# 2.0 changes.
2230 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
2232 This code is contributed under the MIT X11 license
2234 The following enables support for several C# 3.0 language features:
2236 * cs-tokenizer.cs: Added support for the "var" keyword.
2238 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
2239 Added VarExpr class to facilitate type inferencing.
2241 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
2242 to support anonymous types.
2244 * assign.cs: Added support for type inferencing and initialization.
2246 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
2248 * expression.cs: Added implicit array support to ArrayCreation.
2249 Added 5 types and 1 interface:
2251 IInitializable Implementing classes can inject initializing
2252 statements after object instantiation.
2254 Initializer Stores data for object initialization.
2256 AnonymousType An expression for anonymous types.
2258 AnonymousTypeParameter Stores data about an anonymous type's field.
2260 NewInitialize An expression for object initialization.
2262 CollectionInitialize An expression for collection initialization.
2264 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
2267 2007-05-06 Marek Safar <marek.safar@gmail.com>
2269 A fix for bug #81500
2270 * cs-tokenizer.cs: Add special handling for coalescing operator.
2272 2007-05-06 Marek Safar <marek.safar@gmail.com>
2274 A fix for bug #81529
2275 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
2276 its value from base class until it is redefined.
2278 2007-05-02 Raja R Harinath <rharinath@novell.com>
2280 Fix regression in cs0631-3.cs
2281 * cs-parser.jay (operator_declarator): Add opt_attributes to error
2282 fallback. Make error fallback catch more cases.
2284 2007-05-01 Miguel de Icaza <miguel@novell.com>
2286 * cs-parser.jay: Allow parameters in operator declarations to have
2289 2007-04-27 Miguel de Icaza <miguel@novell.com>
2291 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
2294 * lambda.cs (ContextualReturn.Resolve): An expression is valid
2295 inside the ContextualReturn, it does not have to be an
2296 ExpressionStatement.
2298 2007-04-24 Miguel de Icaza <miguel@novell.com>
2300 * lambda.cs (ContextualReturn.Resolve): if the return type is not
2303 2007-04-23 Miguel de Icaza <miguel@novell.com>
2305 * anonymous.cs (AnonymousContainer): split the virtual Resolve
2306 method in two methods: ResolveNoDefine and Resolve.
2308 ResolveNoDefine will stop just after ResolveTopBlock has been
2311 Resolve will then continue by creating a method and issuing the
2312 call to method.Define ().
2314 (AnonymousMethod): Split and implement the new Resolve and
2315 ResolveNoDefine as well.
2317 * lambda.cs (LambdaExpression): Split the anonymous method
2318 resolution code into a separate routine (CoreCompatibilityTest)
2319 from DoCompatibleTest.
2321 (LambdaExpression.TryBuild): New method, this method tries to
2322 build the LambdaExpression with the given set of types to be used
2323 as the types for the various parameters of the lambda expression.
2325 If the compilation succeed with the given types, the infered type
2326 of the Anonymous method is returned, otherwise null is returned.
2328 2007-04-23 Marek Safar <marek.safar@gmail.com>
2330 A fix for bug #81414
2331 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
2333 2007-04-22 Miguel de Icaza <miguel@novell.com>
2335 * cs-tokenizer.cs: Change various identifiers here from the
2336 camelCasing to the recommended Linux-like style for instance
2337 variables from the Coding Guidelines.
2339 2007-04-19 Martin Baulig <martin@ximian.com>
2342 (Convert.ImplicitReferenceConversionCore): Allow conversions from
2343 System.Enum to System.ValueType.
2345 2007-04-13 Martin Baulig <martin@ximian.com>
2347 Rewrote implicit reference conversions. We need to distinguish
2348 between implicit reference conversions (13.1.4) and implicit
2349 boxing conversions (13.1.5).
2351 According to the spec, there's an an implicit conversion
2352 "From a one-dimensional array-type S[] to IList<T> and base
2353 interfaces of this interface, provided there is an implicit
2354 reference conversion from S to T." Note that this does not
2355 include boxing conversions.
2358 (Convert.ImplicitTypeParameterBoxingConversion): New method.
2359 (Convert.ImplicitReferenceConversion): Split into
2360 ImplicitReferenceConversionCore() and
2361 ImplicitBoxingConversionExist().
2362 (Convert.ImplicitReferenceConversionExists): Use the new
2363 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
2365 2007-04-12 Martin Baulig <martin@ximian.com>
2367 * convert.cs (Convert.ImplicitReferenceConversion): Move the
2368 `TypeManager.null_type' checks up to the top of the method.
2370 2007-04-11 Marek Safar <marek.safar@gmail.com>
2372 A fix for bug #81350
2373 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
2376 2007-04-11 Martin Baulig <martin@ximian.com>
2378 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
2379 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
2380 to make this work for generic classes; fixes #79561.
2382 2007-04-11 Martin Baulig <martin@ximian.com>
2384 * expression.cs (As): Add support for nullable types; fixes #79371.
2386 2007-04-11 Martin Baulig <martin@ximian.com>
2388 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
2389 `type.FullName' is null; fixes #80243.
2391 2007-04-11 Martin Baulig <martin@ximian.com>
2393 * expression.cs (Invocation.IsApplicable): Don't modify the method
2394 if type inference succeeded, but the method was not applicable.
2397 2007-04-10 Marek Safar <marek.safar@gmail.com>
2399 A fix for bug #81324
2400 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
2401 internal and external namespaces containers.
2403 2007-04-10 Martin Baulig <martin@ximian.com>
2405 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
2406 TypeManager.DropGenericMethodArguments() so we also call
2407 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
2409 2007-04-10 Martin Baulig <martin@ximian.com>
2411 * iterators.cs (Iterator.CreateIterator): Don't crash if
2412 `method.ReturnType' is null. This happens if something went wrong
2413 while resolving that typ (we already reported an error in this case).
2415 2007-04-10 Martin Baulig <martin@ximian.com>
2417 * expression.cs (New.DoResolve): Don't call CheckComImport() on
2418 generic interfaces; report the CS0144 directly.
2420 2007-04-10 Martin Baulig <martin@ximian.com>
2422 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
2423 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
2425 2007-04-10 Martin Baulig <martin@ximian.com>
2427 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
2429 2007-04-09 Raja R Harinath <rharinath@novell.com>
2432 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
2433 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
2436 * statement.cs (For.Resolve): If resolution fails, use
2439 2007-04-08 Marek Safar <marek.safar@gmail.com>
2441 * anonymous.cs (MakeName): Make faster and zero-based.
2442 (VerifyExplicitParameterCompatibility): Back to mode where generic
2443 parameter is ignored.
2444 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
2446 * class.cs (EmitType): Method can emit another new method.
2448 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
2450 * driver.cs: Updated.
2452 * lambda.cs: Reuse predefined empty parameters.
2454 * parameter.cs: Updated
2456 * support.cs: Implemented InflateTypes.
2458 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
2459 (InitSystemCore): Introduced to isolate 3.0 dependencies.
2461 2007-04-03 Martin Baulig <martin@ximian.com>
2465 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
2466 version of TypeManager.IsOverride() which also works with generic
2469 2007-04-03 Martin Baulig <martin@ximian.com>
2474 (Convert.ExplicitReferenceConversion): We need to cast when
2475 converting from IList<T> to S[].
2477 2007-04-01 Marek Safar <marek.safar@gmail.com>
2479 * decl.cs (FindExtensionMethods): Consider all candidates with same name
2482 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
2484 2007-03-31 Marek Safar <marek.safar@gmail.com>
2486 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
2487 argument and return type inferring.
2489 * codegen.cs (InferReturnType): Flag whether return can be inferred.
2490 (ReturnType): Turned to property.
2492 * statement.cs (Return): Implemented return type inferring.
2494 * support.cs (ReflectionParameters): Use local types if possible.
2496 2007-03-30 Raja R Harinath <rharinath@novell.com>
2498 * flowanalysis.cs (FlowBranching.Reachability): Remove.
2499 (FlowBranching.UsageVector): Update to changes.
2501 Prepare to kill 'Reachability'
2502 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
2503 argument of constructor.
2505 2007-03-29 Raja R Harinath <rharinath@novell.com>
2507 Prepare to kill 'Reachability'
2508 * flowanalysis.cs (UsageVector.is_unreachable): New.
2509 (UsageVector): Update to maintain 'is_unreachable' in parallel to
2510 'reachability', and verify they're consistent.
2513 * expression.cs (New.EmitStatement): Handle type parameters here too.
2515 2007-03-29 Martin Baulig <martin@ximian.com>
2520 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
2521 CompilerGeneratedClass.
2522 (ScopeInfo.EmitScopeInstance): Make this protected.
2523 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
2524 `ec.CurrentAnonymousMethod.Scope == Scope'.
2526 * statement.cs (Block.ScopeInfo): Make this a property.
2528 2007-03-27 Raja R Harinath <harinath@gmail.com>
2530 Prepare to kill 'Reachability'
2531 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
2532 (FlowBranching.UsageVector.Reachability): Remove property.
2533 (FlowBranching.UsageVector.IsUnreachable): New property.
2534 (FlowBranching.UsageVector.ResetBarrier): New.
2535 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
2536 * codegen.cs, statement.cs: Update to changes.
2538 2007-03-27 Martin Baulig <martin@ximian.com>
2543 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
2546 2007-03-26 Raja R Harinath <rharinath@novell.com>
2548 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
2549 instead of TriState. Remove all mention of TriState.
2551 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
2552 replaced by a boolean. Add boolean 'is_unreachable' field, check
2553 and maintain invariants.
2555 2007-03-25 Marek Safar <marek.safar@gmail.com>
2557 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
2559 2007-03-25 Marek Safar <marek.safar@gmail.com>
2561 * expression.cs: Stop using obsolete 2.0 opcodes.
2563 2007-03-25 Marek Safar <marek.safar@gmail.com>
2565 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
2566 one of the latests Martin's fixes.
2568 2007-03-23 Miguel de Icaza <miguel@novell.com>
2570 * expression.cs: On BigEndian systems, swap the bytes, temporary
2571 solution until we get a new bitconverter class.
2573 2007-03-23 Martin Baulig <martin@ximian.com>
2577 * decl.cs (MemberCache.AddMembers): Add generic methods both as
2578 "Method" and "Method`1". Normally, a cache lookup is done on the
2579 "Method" form (ie. without the generic arity), but this one makes
2580 lookups on the full form work as well.
2582 2007-03-22 Raja R Harinath <rharinath@novell.com>
2584 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
2587 2007-03-20 Bill Holmes <billholmes54@gmail.com>
2589 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
2590 ordered_member_list, to TypeBuilder to store members to be defined
2591 in the order they were parsed in.
2592 - ordered_explicit_member_list contains all properties indexers
2593 and methods that are defined as explicit implementation of an
2594 interface or base class.
2595 - ordered_member_list contains all properties indexers and methods
2596 that are not defined as explicit implementation of an interface
2599 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
2600 functionality in these removed classes has been replaced with
2601 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
2602 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
2604 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
2605 to CheckForDuplications inside GetMethod and SetMethod Define Method
2606 to handle method property and indexer name conflicts.
2610 All code is contributed under the MIT/X11 license.
2612 2007-03-20 Martin Baulig <martin@ximian.com>
2614 * class.cs (TypeContainer.Interfaces): Removed; they're now
2615 included in `TypeContainer.Types'.
2617 2007-03-20 Martin Baulig <martin@ximian.com>
2619 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
2621 * class.cs (TypeContainer.CreateType): New public method. This is
2622 now called before DefineType() to create the TypeBuilders.
2623 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
2624 has already been created by CreateType().
2625 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
2626 don't resolve our base classes here; this has been moved into
2627 DefineBaseTypes(). We're now called from CreateType().
2628 (TypeContainer.DefineBaseTypes): New private method; resolve our
2629 base classes here. We're now called from DefineType().
2632 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
2633 our types first to create all the TypeBuilders. After that, call
2634 TypeContainer.DefineType() on all the types which'll resolve their
2635 base classes and setup the resolve order.
2637 2007-03-20 Martin Baulig <martin@ximian.com>
2639 * class.cs (TypeContainer.Enums): Removed; they're now included in
2640 `TypeContainer.Types'.
2642 2007-03-20 Martin Baulig <martin@ximian.com>
2645 (TypeContainer.DefineType): Don't call ResolveMembers() here.
2646 (TypeContainer.DoResolveMembers): Call DefineType() on our
2647 `compiler_generated' classes; moved here from DefineNestedTypes().
2650 (RootContext.ResolveTree): Call ResolveMembers() on all
2651 TypeContainer's in the `type_container_resolve_order'.
2653 2007-03-19 Marek Safar <marek.safar@gmail.com>
2655 * class.cs: Use corlib to handle InternalMethodImplAttribute.
2657 2007-03-17 Marek Safar <marek.safar@gmail.com>
2659 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
2660 implementation flags.
2662 2007-03-17 Marek Safar <marek.safar@gmail.com>
2664 * class.cs: More optimizations for type parameters.
2666 2007-03-15 Marek Safar <marek.safar@gmail.com>
2668 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
2670 * ecore.cs, parameter.cs: More common code for both corlibs.
2672 * typemanager.cs (IsGenericMethod): Simplified.
2674 2007-03-15 Raja R Harinath <rharinath@novell.com>
2676 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2678 * statement.cs, iterators.cs, lambda.cs: Update to changes.
2680 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
2681 unconditionally. Simplify explanation.
2682 (Try.Resolve, Using.Resolve): Likewise.
2684 2007-03-15 Martin Baulig <martin@ximian.com>
2688 * decl.cs (DeclSpace): If we're a partial class, use our
2689 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
2691 2007-03-15 Raja R Harinath <rharinath@novell.com>
2693 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2695 (FlowBranching.UsageVector): Update to changes.
2696 (FlowBranching.MergeSiblings): Likewise.
2697 * statement.cs: Likewise.
2699 2007-03-15 Martin Baulig <martin@ximian.com>
2704 (MemberCache): Added a special .ctor for type parameters.
2707 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
2710 2007-03-09 Martin Baulig <martin@ximian.com>
2712 * enum.cs (Enum): Make this a TypeContainer.
2713 (EnumMember): Derive from `Const'.
2716 (Const.DoResolveValue): New protected virtual method; move most of
2717 the functionality of ResolveValue() here so we can override it in
2719 (Const.CreateConstantReference): Make this virtual.
2721 * class.cs (Kind): Add `Kind.Enum'.
2722 (TypeContainer.Emit): Don't emit the enums here; they're already
2723 in the `RootContext.typecontainer_resolve_order'.
2725 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
2726 here; they're already in the `typecontainer_resolve_order'.
2728 * ecore.cs (EnumConstant.ConvertImplicitly): Add
2729 TypeManager.DropGenericTypeArguments().
2732 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
2733 (TypeManager.IsEnumType): Likewise.
2734 (TypeManager.EnumToUnderlying): Likewise.
2735 (TypeManager.IsEqual): Add support for enums.
2737 2007-03-12 Raja R Harinath <rharinath@novell.com>
2739 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
2740 DefaultParameterValueAttribute to be undefined, say if System.dll
2743 2007-03-11 Marek Safar <marek.safar@gmail.com>
2745 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
2748 2007-03-10 Marek Safar <marek.safar@gmail.com>
2750 * class.cs, parameter.cs: Unified parameters verification.
2752 2007-03-08 Martin Baulig <martin@ximian.com>
2754 * cs-parser.jay (constructor_header): Pass the location to the
2755 newly created TopLevelBlock.
2757 2007-03-07 Martin Baulig <martin@ximian.com>
2759 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
2761 2007-03-06 Miguel de Icaza <miguel@novell.com>
2763 * convert.cs (ExplicitReferenceConversionExists): Sync this method
2764 with the changes from David, fixes the build.
2766 2007-03-05 David Mitchell <dmitchell@logos.com>
2768 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
2769 and its base interfaces to a one-dimensional array type S[],
2770 provided there is an implicit or explicit reference conversion
2773 2007-03-03 Marek Safar <marek.safar@gmail.com>
2775 * cs-tokenizer.cs: Implemented basic linq grammar.
2777 * driver.cs: Set linq lang version on demand.
2779 2007-02-26 Marek Safar <marek.safar@gmail.com>
2781 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
2783 2007-02-25 Marek Safar <marek.safar@gmail.com>
2785 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
2788 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
2790 Check property and event extern attributes.
2792 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
2795 2007-02-24 Marek Safar <marek.safar@gmail.com>
2797 A fix for bug #80407
2798 * ecore.cs: Don't report ambiguity error when methods have same parent.
2800 2007-02-23 Marek Safar <marek.safar@gmail.com>
2802 A fix for bug #80878
2803 * class.cs, cs-parser.jay: Event property can host anonymous methods.
2805 2007-02-22 Marek Safar <marek.safar@gmail.com>
2807 * attribute.cs: Enable ExtensionAttribute presence test.
2809 2007-02-22 Marek Safar <marek.safar@gmail.com>
2811 * class.cs: Warn about missing GetHashCode only when Equals is override.
2813 * decl.cs: Check accessibility of type arguments.
2815 * typemanager.cs: Correctly report nullable array.
2817 2007-02-20 Marek Safar <marek.safar@gmail.com>
2819 * class.cs, report.cs: Capture more details when things go wrong.
2821 2007-02-20 Marek Safar <marek.safar@gmail.com>
2823 A fix for bug #80650
2824 * cs-parser.jay: Anonymous container starts at constructor declaration
2825 and not at block beginning because it has to be usable in constructor
2828 * statement.cs: Use context location and not block one for error reporting.
2830 2007-02-18 Marek Safar <marek.safar@gmail.com>
2832 A fix for bug #78712
2833 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
2836 2007-02-18 Marek Safar <marek.safar@gmail.com>
2838 A fix for bug #80493 by Atsushi Enomoto
2839 * cs-parser.jay: Ignore invalid attribute target.
2841 2007-02-18 Marek Safar <marek.safar@gmail.com>
2843 * cs-tokenizer.cs: Ignore '\0' as white space character.
2845 2007-02-17 Miguel de Icaza <miguel@novell.com>
2847 * cs-parser.jay: Add support for lambda expressions to the mcs
2850 * lambda.cs: Only clone when we are probing, not on the final call
2851 (Compatible is the final call).
2853 * statement.cs (CloneContext): Introduce class to provide block
2854 remapping during clone.
2856 All statements Clone themselves now.
2858 (Clone): special handling for blocks, when we clone a block, we
2859 register the block inside this routine, as children of the block
2860 might trigger a lookup.
2862 * expression.cs: Add support for CloneContext in all expressions.
2864 2007-02-17 Marek Safar <marek.safar@gmail.com>
2866 A fix for bug #80493
2867 * statement.cs: Report ambiguous warning when interfaces are not related.
2869 2007-02-15 Marek Safar <marek.safar@gmail.com>
2871 C# 3.0 extension methods.
2873 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
2874 cannot be used directly.
2876 * class.cs (Class.Emit): Emit extension attribute if any class method
2877 is extension method.
2878 (Method.Define): Add basic extension method validation conditions.
2879 (Method.Emit): Emit extension attribute for method.
2881 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
2882 extension method exists. Currently we follow same approach as Microsoft
2883 does, emit even if a method or a class are private but this can change
2886 * cs-parser.jay: Add handling of `this' keyword in method parameters
2889 * decl.cs (DeclSpace.IsStaticClass): New property.
2890 (MemberCache.FindExtensionMethods): Looks for extension methods with
2891 defined name and extension type.
2893 * doc.cs: Updated after OverloadResolve changes.
2895 * driver.cs: Add new soft reference to System.Core.dll.
2897 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
2898 (ExtensionMethodGroupExpr): Represents group of extension methods.
2900 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
2901 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
2902 to MethodGroupExpr and made non-static for easier customization.
2903 (Invocation.DoResolve): Add extension method lookup when no standard
2905 (MemberAccess.DoResolve): Try extension methods if no member exists.
2907 * modifiers.cs: Add METHOD_EXTENSION modifier.
2909 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
2910 as well as candidate extension type.
2911 (ComputeNamespaces): When assembly constains extension methods registers
2913 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
2914 extension method lookup.
2915 (Namespace.LookupExtensionMethod): Looks for extension method in this
2917 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
2918 find a method which matches name and extensionType.
2920 * parameter.cs (Parameter): Add This modifer.
2921 (HasExtensionMethodModifier): New property.
2922 (Resolve): Add extension parameter check.
2923 (ModFlags): turned to property to exclude this modifier as it is not real
2925 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
2927 * support.cs (ParameterData): Add ExtensionMethodType.
2928 (ReflectionParameters): Implemented ExtensionMethodType interface property.
2930 * typemanager.cs: Add type and ctor extension attribute type.
2932 2007-02-15 Miguel de Icaza <miguel@novell.com>
2934 * report.cs (DisableErrors, EnableErrors): used to prevent error
2935 output when we are "trying" to compile various methods with
2938 * ecore.cs (Expression): Add Clone method that calls the virtual
2939 CloneTo method. The current CloneTo method in Expression throws
2940 an exception so we can track down all the places where this must
2941 be implemented (not using abstract, because that would be a lot of
2942 up-front-work before we can start testing the implementation
2945 Important: we only need Clone capabilities for expressions created
2946 by the parser, as the expressions we will be cloning are
2947 expressions in the pre-resolved state. This vastly simplifies
2950 (SimpleName): Add CloneTo that does nothing.
2951 (EmptyCast): Add CloneTo.
2953 * expression.cs (Binary): Implement CloneTo.
2954 (Invocation.IsApplicable): Store the current ec in
2955 EmitContext.TempEc and restore it on return. This is used so we
2956 do not have to sprinkle hundres of methods with an extra
2957 EmitContext, we know that the only user is the lambda expression
2958 ImplicitConversionExists code.
2960 (Argument): Add Cloning capabilities.
2961 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
2962 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
2963 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
2964 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
2965 IndexerAccess): Add Clone capability.
2967 (LocalVariableReference, This): TODO: needs cloned Block mapping.
2969 (Argument): Add cloning capability.
2971 * assign.cs (Assign): Implement CloneTo.
2973 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
2975 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
2976 version by calling Convert with the EmitContext (that we are
2977 currently storing in ec, this is not great, but will do for now,
2978 to avoid passing EmitContext parameters to hundreds of functions
2979 that do not need them now).
2981 (SetExpression): Remove, it is not needed.
2983 (ContextualReturn): Implement CloneTo.
2985 * statement.cs (Statement): Implement cloning infrastructure,
2986 similar to expressions.
2988 (Block): Partial implementation of Clone for statements.
2990 (Return): Implement clone.
2992 * constant.cs (Constant.CloneTo): New method, does nothing.
2994 * codegen.cs (TempEc): Add a static EmitContext as a temporary
2995 solution, until we decide how to exactly do this.
2997 2007-02-14 Marek Safar <marek.safar@gmail.com>
2999 A fix for bug #80493
3000 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
3001 a property is override we need to use second accessor.
3003 2007-02-13 Marek Safar <marek.safar@gmail.com>
3005 A fix for bug #80418
3006 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
3009 2007-02-13 Marek Safar <marek.safar@gmail.com>
3011 Another fix for bug #80749
3012 * pending.cs: Abstract class has priority over interfaces.
3014 2007-02-13 Marek Safar <marek.safar@gmail.com>
3016 Another fix for bug #80749
3017 * pending.cs: Abstract class has priority over interfaces.
3019 2007-02-13 Marek Safar <marek.safar@gmail.com>
3021 Another fix for bug #80749
3022 * pending.cs: Abstract class has priority over interfaces.
3024 2007-02-13 Marek Safar <marek.safar@gmail.com>
3026 Another fix for bug #80749
3027 * pending.cs: Abstract class has priority over interfaces.
3029 2007-02-13 Marek Safar <marek.safar@gmail.com>
3031 * class.cs Better error message.
3033 * driver.cs: Add shorter versions of -optimize option.
3035 2007-02-13 Martin Baulig <martin@ximian.com>
3037 * class.cs (Constructor.Emit): Check the return value of
3038 ec.ResolveTopBlock() and return on error.
3040 2007-02-13 Raja R Harinath <rharinath@novell.com>
3042 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
3043 message to fix error message regression.
3045 2007-02-12 Marek Safar <marek.safar@gmail.com>
3047 * delegate.cs: Delegate creation expression cannot be of Nullable type.
3049 2007-02-12 Marek Safar <marek.safar@gmail.com>
3051 A fix for bug #80749
3052 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
3053 its parent container.
3055 * class.cs (DefineFieldInitializers): Each initializer can has different
3058 * const.cs: Updated.
3060 2007-02-11 Miguel de Icaza <miguel@novell.com>
3062 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
3063 now all the heavy lifting to check that embedded statements or
3064 expressions have the right form is done in the ContextualReturn.
3066 (ContextualReturn): New class.
3068 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
3069 method that can be invoked to report 201, so we do not replicate
3072 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
3074 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
3075 treating tabs as spaces.
3077 2007-02-09 Marek Safar <marek.safar@gmail.com>
3079 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
3080 * assign.cs: Use full implicit conversion for right side check.
3082 2007-02-09 Marek Safar <marek.safar@gmail.com>
3084 * statement.cs (Switch): Switch over boolean type is not standardized.
3086 2007-02-08 Marek Safar <marek.safar@gmail.com>
3088 A fix for bug #80755
3089 * decl.cs (FindBaseEvent): Don't use method cache for events.
3091 2007-02-07 Marek Safar <marek.safar@gmail.com>
3093 * cs-parser.jay: Better syntax error handling.
3095 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
3096 instead of underlying type value.
3098 2007-02-06 Marek Safar <marek.safar@gmail.com>
3100 * driver.cs: Check define identifier before is registered.
3102 * namespace.cs: Use existing error message.
3104 * report.cs: New warning.
3106 2007-02-06 Marek Safar <marek.safar@gmail.com>
3108 A fix for bug #80742
3109 * expression.cs: Delegate Invoke method can be called directly.
3111 2007-02-06 Marek Safar <marek.safar@gmail.com>
3113 A fix for bug #80676
3114 * class.cs (IsEntryPoint): The Main method can have params modifier.
3116 2007-02-04 Miguel de Icaza <miguel@novell.com>
3118 * parameter.cs (Parameter, Parameters): Add Clone method.
3120 * anonymous.cs (Compatible): Turn method into virtual method, so
3121 LambdaExpression can implement a different behavior.
3123 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
3124 out the basic checking here, so it can be used by
3127 * lambda.cs: Introduce "Compatible" function that will do the
3130 2007-02-02 Marek Safar <marek.safar@gmail.com>
3132 * attribute.cs: Unified one error message.
3134 * class.cs (Class): Use type attributes and not properties to test static
3136 (IsEntryPoint): Don's pass local variable.
3138 * convert.cs: Removed duplicate check.
3140 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
3142 * driver.cs: Don't crash when soft reference does not exist.
3144 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
3145 (UsingEntry): Removed redundant allocation.
3147 * parameter.cs: Add fast path for type parameters.
3149 * support.cs: Don't allocate attribute when it's not used.
3151 2007-01-30 Miguel de Icaza <miguel@novell.com>
3154 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
3155 this into a virtual method, so we can override it in LambdaExpression.
3157 * driver.cs: Improve diagnostics in case of failure.
3159 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
3160 write a function that is slightly more complex and that parses:
3162 type identifier [, type identifier]* )
3164 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
3167 (canEmpty ? i >= 0 : i > 0)
3169 2007-01-30 Raja R Harinath <rharinath@novell.com>
3171 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
3172 exception on possibly valid code.
3174 2007-01-29 Raja R Harinath <rharinath@novell.com>
3176 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
3178 (parse_opt_type_arguments): Remove. It's almost the same as
3180 (parse_namespace_or_typename): Use parse_less_than.
3182 2007-01-28 Miguel de Icaza <miguel@novell.com>
3184 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
3185 this bug took a few hours to find, because the state saved and
3186 restored by PushPosition and PopPosition was ignoring the state of
3187 parse_generic_less_than.
3189 I can also now remove the handling of OP_LT and OP_GT, this solves
3192 * cs-tokenizer.cs: store the location for the ARROW token, we use
3195 (PushPosition, PopPosition): save/restore also `current_token',
3196 restore `parse_generic_less_than' (was missing).
3198 (parse_opt_type_arguments): use parse_type, not
3199 parse_namespace_or_typename to parse types.
3201 * lambda.cs: Empty new file, will eventually have the lambda
3202 expression implementation.
3204 * lambda.test: used to test the internal tokenizer.
3206 * report.cs (FeatureIsNotISO1): Rename from
3207 FeatureIsNotStandardized, because it was about the language level
3208 (1 vs 2) it was not about standarization.
3210 (FeatureRequiresLINQ): New.
3212 * support.cs (SeekableStreamReader): Only require that the reader
3213 is a TextReader, not a StreamReader, so we can plug StringReader.
3215 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
3216 given position in the input stream the following tokens can be
3217 parsed as a type followed by an identifier.
3219 (is_punct): after a '(' if parse_type_and_parameter returns true,
3220 then return a special token OPEN_PARENS_LAMBDA which is used to
3221 avoid reduce/reduce errors in the grammar for the
3222 lambda_expression rules.
3224 (parse_type): implement a type parser inside the
3225 tokenizer, the parser only returns true or false depending on
3226 whether the input at a given position can be parsed as a type.
3228 (peek_token): new method used during type parsing.
3230 2007-01-28 Raja R Harinath <rharinath@novell.com>
3233 * anonymous.cs (ScopeInfo.InflateParameters): New.
3234 (AnonymousContainer.Resolve): Use it to redirect types of
3235 delegate parameters.
3237 2007-01-27 Raja R Harinath <rharinath@novell.com>
3240 * expression.cs (Error_InvalidArguments): Don't use two different
3241 messages for CS1503. Use ExtraInformation and
3242 SymbolRelatedToPreviousError instead.
3245 * decl.cs (DeclSpace.initialize_type_params): Don't access
3246 'type_params' of a partial class directly.
3248 2007-01-26 Miguel de Icaza <miguel@novell.com>
3250 * constant.cs: Removed a handful of out-of-range checks that were
3253 2007-01-25 Marek Safar <marek.safar@gmail.com>
3255 * expression.cs (CheckUselessComparison): Add additional check for char
3258 * namespace.cs: Fixed typo.
3260 2007-01-23 Miguel de Icaza <miguel@novell.com>
3262 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
3263 gone, instead we inline the test, preventing the needless casts to
3264 longs, ulongs and doubles for the parameters, avoiding calls to
3265 methods that overchecked stuff, and instead inlined things
3268 2007-01-20 Marek Safar <marek.safar@gmail.com>
3270 * cs-parser.jay: Better parameter error handling.
3272 2007-01-17 Marek Safar <marek.safar@gmail.com>
3274 A fix for bug #80368, #80522
3275 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
3276 whether array initializer contains constants only.
3277 (ArrayCreation.Emit): Use better formula to decide when
3278 are array initializers for static initialization.
3279 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
3280 have to emit even constants otherwise they are pre-initialized.
3282 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
3283 Raja R Harinath <rharinath@novell.com>
3285 Fix emit order of 'get' vs. 'set'.
3286 * support.cs (Accessors): New.
3287 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
3288 Note the order in which accessors are declared in the source.
3289 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
3290 Refactored from Property.Define and Indexer.Define.
3291 (PropertyBase.DefineAccessors): New helper that calls the above in
3292 appropriate order as noted by the parser.
3293 (Property.Define, Indexer.Define): Update to changes.
3294 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
3296 2007-01-17 Raja R Harinath <rharinath@novell.com>
3298 Fix cs0029-6.cs and gcs0029-2.cs (regression)
3299 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
3300 there's an implicit conversion from the current type to the target
3301 type before converting the underlying constant.
3303 2007-01-16 Marek Safar <marek.safar@gmail.com>
3305 * const.cs (ResolveValue): Updated after constant conversion was made more
3308 * constant.cs (GetAttributableValue): constant to object conversion is
3309 used for attributes only.
3310 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
3311 constant conversions.
3312 (LongConstant.ConvertImplicitly): Ditto.
3314 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
3315 (ImplicitConversionStandard): Handle constant conversion as extra step.
3316 It solves the issue when constant conversion was called indirectly like
3317 inside array initializer and constant folding was skipped.
3319 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
3322 * statement.cs(ImplicitConversionStandard): Updated after constant
3323 conversion was made more generic.
3325 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
3327 * expression.cs (As.DoResolve): Use GenericConstraints instead of
3328 Constraints, solves the problem where the compiler incorrectly
3329 reported that a type parameter was not constrained to a class (Bug
3332 2007-01-14 Marek Habersack <grendello@gmail.com>
3334 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
3336 2007-01-14 Marek Safar <marek.safar@gmail.com>
3338 A fix for bug #80368
3339 * assign.cs (FieldInitializer): New class implements field
3340 initializer statement.
3342 * attribute.cs: Update after FieldMember rename.
3344 * class.cs (PropertyBasedMember): New common class for property based
3346 (InterfaceMemberBase): New base class for all members which can be used as
3347 an interface members.
3348 (MethodCore): Moved really common code to InterfaceMemberBase.
3349 (Method.Define): Equal and GetHasCode detection is relevant for methods
3351 (MethodData.Define): Don't assume that public event implements an
3352 interface automatically.
3353 (MethodData.DefineMethodBuilder): Issue an error even if only extern
3355 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
3356 (FieldMember): Merged with FieldBase.
3357 (EventProperty.AEventPropertyAccessor): New specialization to check whether
3358 event extern modifier can be used.
3359 (EventField.EventFieldAccessor): Moved event field specific code here.
3360 (Event.AllowedModifiers): Even event can be extern.
3361 (Event.FindOutBaseMethod): New override specific to events.
3362 (Indexer.parameters): Reintroduce parameters because base class holds
3363 only properties common data.
3364 (Indexer.CheckForDuplications): Indexers are threated as methods so we
3365 need do extra parameters check.
3367 * const.cs: Update after FieldMember rename.
3369 * decl.cs (MemberCache.FindBaseEvent): New method.
3371 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
3372 to reflect that indexer is now derived from PropertyBased.
3374 * ecore.cs (GetMemberType): Made public.
3375 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
3378 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
3380 * typemanager.cs (CSharpSignature): Correctly print event accessors.
3381 (RegisterEvent): Removed.
3382 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
3383 (GetPrivateFieldOfEvent): Renamed to GetEventField.
3385 2007-01-11 Raja R Harinath <rharinath@novell.com>
3388 * statement.cs (CollectionForeach.TryType): Prefer generic
3389 GetEnumerator over non-generic variant. Fix code to follow comments.
3391 2007-01-09 Raja R Harinath <rharinath@novell.com>
3394 * support.cs (ReflectionParameter): Don't use an invalid index on
3395 the generic parameter data.
3397 2007-01-08 Miguel de Icaza <miguel@novell.com>
3399 * driver.cs: Just add a tiny bit of infrastructure.
3401 2007-01-02 Marek Safar <marek.safar@gmail.com>
3403 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
3404 where field type is struct from current assembly.
3406 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
3409 2007-01-02 Marek Safar <marek.safar@gmail.com>
3411 A fix for bug #80381
3412 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
3415 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
3417 (Namespace.LookupType): Always use core types from corlib when speficied.
3419 * report.cs: A new warning.
3421 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
3422 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
3423 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
3425 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
3426 (InitCoreTypes): Set expression type of object_type and value_type
3427 immediately after lookup.
3429 2007-01-01 Miguel de Icaza <miguel@novell.com>
3431 * cs-tokenizer.cs: Accept Pc class characters (Connector
3432 Punctuation) as valid identifiers. Fixes #78259
3434 * expression.cs (Invocation.DoResolve): Moved the check for the
3435 use of `this' for doing method calls to the Invocation resolution
3436 step, after overload resolution has taken place instead of doing
3437 the check at the low-level `This.DoResolve' level.
3439 The `This.DoResolve'(appens before overload resolution, so it has
3440 no way of knowing if the method that will be called will be
3441 instace or static, triggering an erroneous report for cs0188 (Bug
3444 We now do the check for instance method invocations after we know
3445 what method will be called.
3447 (This.CheckThisUsage): Move the actual use of this structure
3448 checking into its own method and expose it.
3450 * Everywhere that called Error_ValueCannotBeConverted: pass a new
3453 Exceptions: Null.ConvertImplicitly,
3454 Constant.ImplicitConversionRequired as there are too many call
3455 sites for passing the ec.
3457 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
3458 EmitContext, if the value is null, then we do not try to provide
3459 the extra information from the error (If a userdefined conversion
3460 exists, as UserDefinedConversion requires a non null-EmitContext).
3464 2006-12-30 Raja R Harinath <rharinath@novell.com>
3466 * flowanalysis.cs (MyBitVector): Document some invariants.
3467 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
3468 introduced below, and add a couple of others,
3470 2006-12-30 Marek Safar <marek.safar@gmail.com>
3472 * attribute.cs (GetMethodObsoleteAttribute): Uses new
3473 GetPropertyFromAccessor and GetEventFromAccessor.
3475 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
3476 overrides non-obsolete one.
3477 (Indexer.Define): Error message has been moved to the parser.
3479 * cs-parser.jay: Better syntax errors handling.
3481 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
3482 when an invocation has no arguments.
3484 * ecore.cs: Removed not used caching.
3486 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
3489 * report.cs: Add a new warning.
3491 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
3493 * typemanager.cs (enumeration_type): Removed.
3494 (CSharpSignature): Reuses IsSpecialMethod.
3495 (IsEqual): Hack for MS BCL.
3496 (GetPropertyFromAccessor): New method.
3497 (GetEventFromAccessor): New method.
3498 (IsSpecialMethod): Fixed to handle more cases.
3500 2006-12-30 Marek Safar <marek.safar@gmail.com>
3502 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
3503 Made white spaces array static.
3505 * ecore.cs (RemoveGenericArity): Optimized.
3507 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
3509 (MyBitVector.initialize_vector): Simplified.
3511 2006-12-22 Miguel de Icaza <miguel@novell.com>
3513 * ecore.cs: Am not entirely happy with this hack, but it seems to
3514 address the issue in 80257 (a small test case for
3517 I set the MethodGroupExpr.Type to an internal compiler type
3518 (itself in this case) to force the resolution to take place. Why
3519 it does not take place with a null is beyond me.
3521 2006-12-20 Marek Safar <marek.safar@gmail.com>
3523 A fix for bug #80288
3524 * expression.cs (ResolveOperator): Consider user defined conversion for
3525 logical and operator too.
3526 (EmitBranchable): Optimization for logical and when full constant folding
3527 could not be applied but one operand is constant.
3529 2006-12-19 Marek Safar <marek.safar@gmail.com>
3531 * class.cs (GetClassBases): Write 5 times every day, will never use
3532 FullName for error reporting.
3534 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
3536 2006-12-19 Martin Baulig <martin@ximian.com>
3538 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
3539 the symbol file info here.
3541 2006-12-18 Marek Safar <marek.safar@gmail.com>
3543 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
3544 of `elseif' is taking then following sections are not taking.
3545 Fixes an issue reported on mono mailing list.
3547 2006-12-18 Marek Safar <marek.safar@gmail.com>
3549 A fix for bug #80300
3550 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
3551 a caller is not taking.
3553 2006-12-18 Raja R Harinath <rharinath@novell.com>
3555 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
3556 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
3557 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
3558 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
3559 * class.cs: Update to changes.
3561 2006-12-17 Marek Safar <marek.safar@gmail.com>
3563 A fix for bug #79934
3564 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
3567 * class.cs (ResolveMembers): Register an iterator in current container and
3570 2006-12-16 Raja R Harinath <rharinath@novell.com>
3573 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
3574 satisfy a params annotated parameter.
3576 2006-12-16 Marek Safar <marek.safar@gmail.com>
3578 A fix for bug #77014
3579 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
3580 paramters correctly and not rely on hacks in Parameters class.
3581 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
3583 (Invocation.VerifyArgumentsCompat): Ditto.
3584 (Invocation.EmitArguments): Changed to correctly emit params arguments at
3587 * parameter.cs (HasParams): Don't assume that params is the last one.
3589 * support.cs (ReflectionParameters.ctor): Look for params attribute
3591 (ReflectionParameters.ParameterType): Removed hack when we returned last
3592 parameter for out of range parameters.
3593 (ParameterName, ParameterModifier): Ditto.
3595 2006-12-14 Marek Safar <marek.safar@gmail.com>
3597 A fix for bug #79987
3598 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
3599 when assembly is not CLS compliant but type is. I have no idea why is this
3602 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
3604 2006-12-13 Miguel de Icaza <miguel@novell.com>
3606 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
3607 in struct constructors, they are basically no-ops.
3609 2006-12-12 Marek Safar <marek.safar@gmail.com>
3611 * cs-tokenizer.cs (Position): Save preprocessor status too.
3613 2006-12-12 Marek Safar <marek.safar@gmail.com>
3615 A fix for bug #77794
3616 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
3618 2006-12-12 Marek Safar <marek.safar@gmail.com>
3620 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
3622 (pp_expr): Report error for an invalid expression.
3623 (handle_preprocessing_directive): Simplified; add more error checking.
3625 2006-12-11 Marek Safar <marek.safar@gmail.com>
3627 A fix for bug #74939
3628 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
3629 directives handling.
3631 2006-12-10 Marek Safar <marek.safar@gmail.com>
3633 A fix for bugs #80093, and #75984
3634 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
3635 logic, it seems to me as it worked before "by coincidence".
3636 (xtoken): Simplified to use reworked handle_preprocessing_directive.
3637 (cleanup): Enabled endif check.
3639 2006-12-09 Marek Safar <marek.safar@gmail.com>
3641 A fix for bug #80162
3642 * statement.cs (CollectionForeach.TryType): Generics and non-generics
3643 enumerators are never ambiguous.
3645 2006-12-08 Raja R Harinath <rharinath@novell.com>
3648 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
3650 2006-12-06 Marek Safar <marek.safar@gmail.com>
3652 A fix for bug #80144
3653 * class.cs (EventProperty.Define): Explicit implementation means
3654 that an even is used.
3656 2006-12-06 Marek Safar <marek.safar@gmail.com>
3658 Fixes the operators implementation (part II)
3660 * cfold.cs (DoConstantNumericPromotions): Renamed to
3661 DoBinaryNumericPromotions and simplified.
3662 (BinaryFold): Couple of conversion fixes; simplified.
3664 * constant.cs, ecore.cs, literal.cs
3665 (ToType): Renamed to ConvertImplicitly.
3666 (Reduce): Renamed to ConvertExplicitly.
3668 * class.cs, convert.cs: Updated.
3670 * expression.cs: TryReduce doesn't throw an exception.
3672 2006-12-01 Marek Safar <marek.safar@gmail.com>
3674 A fix for bug #80108
3675 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
3678 2006-11-30 Marek Safar <marek.safar@gmail.com>
3680 Fixes unary operators implementation (part I)
3683 * cfold.cs (Error_CompileTimeOverflow): Made internal
3685 * const.cs (IConstant): Changed to use reference to constant and
3686 not constant itself.
3687 Updated IConstant implementations.
3689 * constant.cs (CreateConstant): New factory method.
3690 Updated IConstant implementation.
3692 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
3694 * ecore.cs: Updated to use CreateConstantReference.
3696 * enum.cs: Reflects IConstant changes.
3698 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
3700 * literal.cs (NullConstant): Change to be independently usable.
3702 2006-11-29 Martin Baulig <martin@ximian.com>
3704 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
3705 we need to emit the scope initializer before calling the base .ctor.
3707 * anonymous.cs: Merged back from the new anonymous methods branch.
3708 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
3710 * expression.cs (ParameterReference.DoResolveBase): Create a
3711 "normal" ScopeInfo when capturing parameters rather than using the
3712 root scope; this makes things work with anonymous methods having
3716 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
3718 2006-11-22 Marek Safar <marek.safar@gmail.com>
3720 A fix for bug #79987
3721 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
3722 check to a base class.
3723 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
3724 only when assembly has missing attribute.
3725 * report.cs: Update.
3727 2006-11-21 Marek Safar <marek.safar@gmail.com>
3729 * cs-tokenizer.cs: Merged with gmcs version.
3731 2006-11-20 Marek Safar <marek.safar@gmail.com>
3734 * cs-parser.jay: Better error message when partial keyword is misplaced.
3736 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
3738 A fix for bug #79810
3739 report.cs: CS1058 only applies to 2.0 profile (gmcs).
3740 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
3741 a RuntimeWrappedException by default.
3743 2006-11-18 Marek Safar <marek.safar@gmail.com>
3745 A fix for bug #79843
3746 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
3748 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
3750 2006-11-18 Marek Safar <marek.safar@gmail.com>
3752 * driver.cs, namespace.cs: Uses faster IndexOf version.
3754 2006-11-17 Marek Safar <marek.safar@gmail.com>
3756 A fix for bug #79941
3757 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
3759 (Operator.Define): Implicit/Explicit operator of same type is duplicate
3760 even if internal name is different.
3761 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
3762 (UserDefinedConversion): Simplified as the operators cannot be internal.
3763 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
3765 (MethodLookup): Replaced EmitContext with parentType.
3766 * expression.cs: Updated.
3768 2006-11-09 Raja R Harinath <rharinath@novell.com>
3770 * driver.cs (BadAssembly): Handle all the ugliness of
3771 DefineDynamicAssembly.
3773 2006-11-08 Raja R Harinath <rharinath@novell.com>
3775 Address parts of #58244 -- most of what's left is in the runtime
3776 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
3777 CS1509 error checks, and handle them for all assembly loads, not
3778 just the first invocation.
3779 (LoadModule): Likewise. Move handling of 'adder_method' ...
3780 * codegen.cs (AssemblyClass.AddModule): ... here.
3782 2006-11-02 Marek Safar <marek.safar@gmail.com>
3784 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
3785 IEnumerable<T> is ambiguous.
3787 2006-10-31 Marek Safar <marek.safar@gmail.com>
3789 A fix for bug #67689
3790 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
3791 GetEnumerator is ambiguous.
3793 * report.cs: Add new warning.
3795 2006-10-29 Marek Safar <marek.safar@gmail.com>
3797 A fix for bug #78602
3798 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
3799 to protected member can be nested type.
3801 2006-10-28 Marek Safar <marek.safar@gmail.com>
3803 A fix for bug #78965
3804 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
3805 to protected member must derive from current type.
3807 2006-10-27 Marek Safar <marek.safar@gmail.com>
3809 assign.cs: Reuses error method.
3811 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
3812 instead of type for constants.
3813 (Expression.Error_ValueAssignment): Common error method.
3815 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
3818 2006-10-27 Marek Safar <marek.safar@gmail.com>
3820 A fix for bug #79081
3821 * expression.cs (MemberAccess.DoResolve): Check nested type
3824 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
3826 * doc.cs : nested delegates were not handled. Fixed bug #79754.
3828 2006-10-26 Marek Safar <marek.safar@gmail.com>
3830 A fix for bug #76591
3831 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
3833 2006-10-26 Marek Safar <marek.safar@gmail.com>
3835 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
3836 type forwarder of the same type multiple times.
3838 2006-10-26 Raja R Harinath <rharinath@novell.com>
3841 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
3842 instance as an rvalue, even when we later resolve as an lvalue.
3844 2006-10-25 Martin Baulig <martin@ximian.com>
3846 * anonymous.cs: Fix #79673.
3848 2006-10-24 Marek Safar <marek.safar@seznam.cz>
3850 A fix for bug #79666
3851 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
3852 ignored when is optimized (= default value) as its value is already set.
3854 2006-10-23 Marek Safar <marek.safar@seznam.cz>
3856 A fix for bug #79724
3857 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
3858 TypeContainer for type lookup.
3860 2006-10-23 Marek Safar <marek.safar@seznam.cz>
3862 A fix for bug #79231
3863 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
3864 * expression.cs (OverloadResolve): Always convert type name for
3866 (ResolveNamespaceOrType): Don't confuse a nested type with any
3869 2006-10-18 Martin Baulig <martin@ximian.com>
3871 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
3873 2006-10-17 Miguel de Icaza <miguel@novell.com>
3875 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
3876 an int32, but requesting an int64 from the conversion
3878 2006-10-12 Martin Baulig <martin@ximian.com>
3881 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
3883 2006-10-12 Martin Baulig <martin@ximian.com>
3886 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
3888 2006-10-11 Miguel de Icaza <miguel@novell.com>
3890 * convert.cs: Remove broken code: I was doing the "Existance"
3891 tests for Implicit conversions.
3893 2006-10-10 Miguel de Icaza <miguel@novell.com>
3895 * convert.cs: Added one missing case in
3896 ImplicitStandardConversionExists uint64 to intptr.
3900 * typemanager.cs (uintptr_type): another core known type.
3902 * ecore.cs (OperatorCast): routine used to do cast operations that
3903 depend on op_Explicit. We could change some of the Decimal
3904 conversions to use this.
3906 This one has a probe mechanism that checks both types for an op_
3907 which it coudl be used to eliminate two classes: CastToDecimal
3908 and CastFromDecimal.
3910 * convert.cs: Implement the conversions documented in #59800
3912 2006-10-10 Martin Baulig <martin@ximian.com>
3914 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
3915 before RootScope.ResolveMembers().
3917 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
3918 `CurrentType' if appropriate.
3920 2006-10-09 Marek Safar <marek.safar@seznam.cz>
3922 A fix for bug #78568
3923 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
3924 when contains binary operators.
3925 * cs-parser.jay: Updated.
3927 2006-10-09 Martin Baulig <martin@ximian.com>
3930 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
3931 moved that into Define() and also do the other type parameter
3932 checks there. Fixes #79094. Added gtest-292.cs.
3935 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
3936 since that doesn't include type parameters; don't use `Ldelema'
3937 for type parameters. Fixes #78980. Added gtest-293.cs.
3939 2006-10-08 Marek Safar <marek.safar@seznam.cz>
3942 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
3943 conversion is allowed.
3945 2006-10-06 Marek Safar <marek.safar@seznam.cz>
3947 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
3948 error reporting when no error occurs.
3950 2006-10-06 Marek Safar <marek.safar@seznam.cz>
3952 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
3955 2006-10-06 Raja R Harinath <rharinath@novell.com>
3958 * class.cs (DefineTypeBuilder): Check circular dependencies before
3959 setting the parent of the TypeBuilder.
3960 (CheckRecursiveDefinition): Don't use 'BaseType', since
3961 it may not be valid until after DefineTypeBuilder. Use
3962 'base_type' instead.
3964 2006-10-04 Martin Baulig <martin@ximian.com>
3966 Merged the Anonymous Methods patch.
3968 * anonymous.cs, iterators.cs: The new anonymous methods code.
3970 * statement.cs (Variable): New public abstract class.
3971 (LocalInfo.Variable): New public property.
3972 (LocalInfo.ResolveVariable): New public method.
3973 (Block.Flags): Add `IsIterator'.
3974 (Block.AddVariable): Improved the CS0136 check.
3975 (Block.AnonymousChildren): New public property.
3976 (Block.AddAnonymousChild): New public method.
3977 (ToplevelBlock): Update to use the new anonymous method framework.
3978 (ToplevelBlock.ctor): `container' is now a `Block' and not a
3979 `ToplevelBlock'; this is required to correctly implement the
3981 (Fixed, Using): Use `TemporaryVariable' instead of directly
3982 creating the `LocalBuilder'.
3984 * parameter.cs (Parameter.ResolveVariable): New public method.
3985 (Parameters.ResolveVariable): Likewise.
3987 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
3989 * class.cs (TypeContainer): Replaced the `iterators' list and
3990 corresponding methods with a list of `CompilerGeneratedClass'es.
3991 (TypeContainer.ResolveMembers): New public method.
3992 (Method): `IIteratorContainer' has been replaced by
3995 * expression.cs (VariableReference): New public abstract base
3996 class for `LocalVariableReference', `ParameterReference' and
3999 * codegen.cs (EmitContext): Removed `capture_context',
4000 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
4001 (EmitContext.EmitThis): Removed.
4003 * cs-parser.jay: Replace `iterator_container' with
4006 2006-10-04 Martin Baulig <martin@ximian.com>
4008 * generic.cs (GenericMethod): Don't make this abstract.
4009 (Constraints.Clone): Added dummy implementation.
4011 2006-10-04 Raja R Harinath <harinath@gmail.com>
4014 * namespace.cs (LookForAnyGenericType): Avoid nullref on
4015 'declspaces'. Avoid allocating arrays willy-nilly.
4018 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
4019 cases out of the switch.
4021 2006-09-28 Marek Safar <marek.safar@seznam.cz>
4023 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
4024 message when non-generic type is used with the type arguments.
4025 * expression.cs: Updated.
4027 2006-09-28 Raja R Harinath <rharinath@novell.com>
4030 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
4031 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
4032 Change semantics slightly. Don't insist on having only one
4033 temporary EmptyExpression -- just throttle the creation of new ones.
4036 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
4037 non-interfaces too. If no methods are found, don't try to create
4040 2006-09-28 Marek Safar <marek.safar@seznam.cz>
4042 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
4045 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
4046 us produce better error message.
4048 2006-09-27 Marek Safar <marek.safar@seznam.cz>
4050 * expression.cs (Binary.ResolveOperator): Warn about a side effect
4051 of the `|' operator.
4053 * report.cs: A new warning added.
4055 2006-09-27 Martin Baulig <martin@ximian.com>
4057 * generic.cs (GenericMethod): Don't make this abstract.
4059 2006-09-27 Martin Baulig <martin@ximian.com>
4062 (InternalErrorException): Added overloaded ctor taking a params array.
4064 2006-09-26 Marek Safar <marek.safar@seznam.cz>
4066 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
4067 Fixed the cases when same error was reported twice.
4069 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
4070 now report symbol information.
4072 2006-09-25 Martin Baulig <martin@ximian.com>
4074 * class.cs: Completely unified with the gmcs version.
4076 2006-09-25 Martin Baulig <martin@ximian.com>
4078 * typemanager.cs (TypeManager.IsNullableType): New public function.
4079 (TypeManager.IsNullableTypeOf): Likewise.
4080 (TypeManager.IsNullableValueType): Likewise.
4082 * class.cs (MethodCore): Added the `GenericMethod' argument from
4083 gmcs and also unified all classes derived from `MethodCore' with gmcs.
4085 2006-09-24 Raja R Harinath <harinath@gmail.com>
4087 * convert.cs: Unify with gmcs version.
4089 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4091 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
4092 verify them as well.
4094 * report.cs: New warning.
4096 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4098 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
4099 for anonymous block with out argument.
4101 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4103 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
4104 not used private events only.
4106 2006-09-23 Marek Safar <marek.safar@seznam.cz>
4108 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
4110 * const.cs (Const.Define): Check for constant type.
4111 (Const.IsConstantTypeValid): Looks for valid constant types.
4113 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
4115 * ecore.cs (EmptyConstantCast): New common class for all constant based
4118 * expression.cs (Is.DoResolve): Handle null constant especially.
4119 (New.DoResolve): Check for new void().
4120 (MemberAccess.DoResolve): Cope with all kind of nulls.
4122 * literal.cs (NullConstant): Uses EmptyConstantCast.
4123 (NullDefault): Based on EmptyConstantCast.
4124 (NullLiteral): Uses EmptyConstantCast.
4126 * statement.cs (Block.ResolveMeta): Check for constant type.
4128 2006-09-22 Martin Baulig <martin@ximian.com>
4130 * delegate.cs, attribute.cs: Merged with the gmcs versions.
4132 2006-09-22 Raja R Harinath <rharinath@novell.com>
4134 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
4138 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
4139 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
4142 2006-09-22 Martin Baulig <martin@ximian.com>
4144 * ecore.cs: Merged with the gmcs version.
4146 * generic.cs (ConstructedType): New dummy class.
4147 (TypeArguments): Don't make this abstract.
4150 (TypeManager.IsGenericTypeDefinition): New method.
4151 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
4153 2006-09-22 Raja R Harinath <rharinath@novell.com>
4155 * expression.cs (ComposedCast): Check for arrays of TypedReference
4156 before creating the type, not after.
4158 2006-09-21 Marek Safar <marek.safar@seznam.cz>
4160 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
4161 after ToType change.
4163 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
4164 when constant must be implicitly convertible.
4166 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
4168 * ecore.cs (NullCast): Derives from NullConstant.
4170 * expression.cs (Is.DoResolve): Removed useless variables.
4171 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
4172 (New.Constantify): Add enum support.
4173 (MemberAccess.DoResolve): Add warning when accessing null constant or
4176 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
4179 * literal.cs (NullConstant): New abstract class with common
4180 functionality for all null specializations.
4181 (NullDefault): Represents default(X) when result can be
4183 (NullLiteral): Updated.
4185 * report.cs: Add new warning.
4187 2006-09-21 Martin Baulig <martin@ximian.com>
4189 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
4191 2006-09-21 Martin Baulig <martin@ximian.com>
4193 * generic.cs (GenericConstraints): New dummy class.
4194 (Constraints): Likewise.
4195 (TypeParameter): Likewise.
4196 (TypeParameterName): Likewise.
4197 (GenericMethod): Likewise.
4199 * typemanager.cs (TypeManager.GetGenericArguments): New method.
4201 * decl.cs: Merged with the gmcs version.
4203 2006-09-21 Raja R Harinath <rharinath@novell.com>
4205 * generic.cs (TypeParameter): Implement IMemberContainer.
4206 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
4208 * rootcontext.cs: Unify with gmcs version.
4210 * report.cs: Unify with gmcs version.
4211 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
4212 from gmcs/generics.cs.
4213 * generics.cs (TypeParameter): New dummy class.
4215 * support.cs: Unify with gmcs version.
4217 2006-09-20 Raja R Harinath <rharinath@novell.com>
4219 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
4220 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
4222 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
4223 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
4224 * mcs.exe.sources: Add generic.cs.
4226 * codegen.cs: Unify with gmcs version.
4228 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
4229 (EmitContext): Add GenericDeclContainer implementation.
4230 * decl.cs (MemberCore, DeclSpace): Likewise.
4231 * namespace.cs: Remove #ifdef GMCS_SOURCE.
4233 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
4234 MCS TypeManager has a corresponding dummy method.
4236 2006-09-19 Martin Baulig <martin@ximian.com>
4238 * expression.cs: Completely merged with the gmcs version.
4240 2006-09-19 Martin Baulig <martin@ximian.com>
4242 * expression.cs (Invocation): Merged with the gmcs version.
4243 (ArrayAccess.GetStoreOpcode): Likewise.
4245 2006-09-19 Martin Baulig <martin@ximian.com>
4248 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
4249 (TypeManager.IsGenericMethodDefinition): Likewise.
4251 2006-09-19 Martin Baulig <martin@ximian.com>
4254 (TypeManager.IsEqual): Moved the gmcs implementation here.
4255 (TypeManager.DropGenericTypeArguments): Likewise.
4256 (TypeManager.DropGenericMethodArguments): Likewise.
4257 (TypeManager.GetTypeArguments): Moved here from gmcs.
4258 (TypeManager.HasGenericArguments): Likewise.
4260 2006-09-19 Martin Baulig <martin@ximian.com>
4262 * expression.cs (Binary): Merged with the gmcs version.
4264 2006-09-19 Martin Baulig <martin@ximian.com>
4266 * expression.cs (Probe, As, Is): Merged with the gmcs version.
4268 2006-09-19 Martin Baulig <martin@ximian.com>
4270 * typemanager.cs: Merged with the gmcs version.
4272 2006-09-16 Raja R Harinath <rharinath@novell.com>
4274 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
4275 * driver.cs: Likewise.
4277 2006-09-16 Marek Safar <marek.safar@seznam.cz>
4280 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
4281 only if parent type is class.
4282 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
4285 2006-09-15 Marek Safar <marek.safar@seznam.cz>
4288 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
4290 * typemanager.cs(CSharpName): Converts NullType to null.
4292 2006-09-15 Martin Baulig <martin@ximian.com>
4295 (TypeManager.GetMethodName): Added mcs implementation.
4296 (TypeManager.IsEqual): Likewise.
4299 (SimpleName.RemoveGenericArity): Added dummy implementation.
4301 * pending.cs: Merged with the gmcs version.
4303 2006-09-15 Martin Baulig <martin@ximian.com>
4305 * statement.cs: Merge with the gmcs version.
4307 2006-09-15 Martin Baulig <martin@ximian.com>
4309 * statement.cs (Switch): Merge with the gmcs implementation
4310 (without nullables), which is newer.
4312 2006-09-15 Martin Baulig <martin@ximian.com>
4314 * statement.cs (Block.Variables): Make this public.
4315 (ToplevelBlock.Parameters): Make this a property.
4316 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
4318 2006-09-15 Martin Baulig <martin@ximian.com>
4320 * namespace.cs: Merge with the gmcs version.
4322 2006-09-15 Martin Baulig <martin@ximian.com>
4324 * decl.cs (MemberName): Minor code cleanups.
4326 2006-09-15 Martin Baulig <martin@ximian.com>
4328 * parameter.cs: Merge with the gmcs version.
4330 2006-09-15 Martin Baulig <martin@ximian.com>
4332 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
4333 and an error in mcs.
4335 2006-09-15 Martin Baulig <martin@ximian.com>
4337 * flowanalysis.cs: Merged from GMCS; added the generics code into
4338 a `GMCS_SOURCE' conditional so we can share this file.
4340 2006-09-08 Martin Baulig <martin@ximian.com>
4342 * typemanager.cs (TypeManager.interlocked_type): New public field.
4343 (TypeManager.int_interlocked_compare-exchange): New public field.
4344 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
4345 enumerator types here and call InitGenericCoreTypes().
4346 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
4347 after calling InitEnumUnderlyingTypes().
4350 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
4351 `classes_second_stage'.
4353 2006-09-14 Marek Safar <marek.safar@seznam.cz>
4355 * assign.cs, ecore.cs, expression.cs: Share error message text.
4356 * class.cs (FieldMember.Define): Check for varible of static type.
4357 * driver.cs (LoadAssembly): Uses error output for errors.
4358 * statement.cs: Updated.
4360 2006-09-08 Marek Safar <marek.safar@seznam.cz>
4362 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
4365 2006-09-07 Martin Baulig <martin@ximian.com>
4368 (MainDriver): Revert r62663 from Marek; see #70506 for details.
4370 2006-08-29 Miguel de Icaza <miguel@novell.com>
4372 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
4374 2006-08-17 Miguel de Icaza <miguel@novell.com>
4376 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
4377 #52019 and #79064, the use of the \uXXXX sequence in source code
4378 to represent unicode characters.
4380 2006-08-15 Marek Safar <marek.safar@seznam.cz>
4382 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
4384 * class.cs, ecore.cs, statement.cs: Merged to one error message.
4386 2006-08-13 Miguel de Icaza <miguel@novell.com>
4388 * assign.cs: Catch attempts to assign to a method groups in += and
4391 2006-08-13 Marek Safar <marek.safar@seznam.cz>
4394 * cs-parser.jay: Don't destroy current array type by typeof of array's.
4396 2006-08-12 Marek Safar <marek.safar@seznam.cz>
4398 * class.cs (Method.Define): Issue a warning when generic method looks like
4400 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
4403 2006-08-09 Marek Safar <marek.safar@seznam.cz>
4405 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
4407 * decl.cs (MemberCache.FindMembers): When container is interface we need to
4408 search all base interfaces as a member can be ambiguous.
4409 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
4410 Constructor member type filter.
4411 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
4412 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
4413 reporting for returned memberinfos.
4414 * report.cs: Updated.
4415 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
4416 version to work on all runtimes.
4417 (TypeManager.RealMemberLookup): Removed members filtering.
4419 2006-08-08 Raja R Harinath <rharinath@novell.com>
4421 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
4422 (PropertyExpr.EmitAssign): Likewise.
4423 * expression.cs (Indirection.EmitAssign): Likewise.
4424 (LocalVariableReference.EmitAssign): Likewise.
4425 (ParameterReference.EmitAssign): Likewise.
4426 (Invocation.EmitArguments): Likewise.
4427 (ArrayAccess.EmitAssign): Likewise.
4428 (IndexerAccess.EmitAssign): Likewise.
4429 (This.EmitAssign): Likewise.
4430 (ConditionalLogicalOperator.Emit): Likewise.
4433 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
4434 instead of ArrayList. If the hashtable has a LocalBuilder, don't
4435 leave it in after returning it.
4436 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
4438 2006-08-06 Marek Safar <marek.safar@seznam.cz>
4440 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
4443 2006-08-03 Raja R Harinath <rharinath@novell.com>
4445 Fix cs0146-3.cs and cs0146-4.cs.
4446 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
4447 enclosing types don't depend on the current type.
4449 2006-08-02 Raja R Harinath <rharinath@novell.com>
4452 * class.cs (TypeContainer.DoDefineMembers): Use
4453 FindBaseMemberWithSameName on Parent, since we're interested in
4454 whether we hide inherited members or not.
4455 (FindBaseMemberWithSameName): Make slightly more robust.
4457 Fix the non-generic testcase from #77396
4458 * decl.cs (DeclSpace.DeclContainer): Remove override.
4460 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
4461 declspaces for doppelgangers too.
4462 (UsingEntry): Implement IResolveContext.
4463 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
4464 'this' as the resolve context.
4465 (LocalAliasEntry): Likewise.
4467 Implement parts of #77403
4468 * roottypes.cs (RootDeclSpace): New. Used to represent the
4469 toplevel declaration space. Each namespace declaration introduces
4470 a "partial" root declaretion space.
4471 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
4472 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
4473 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
4474 from 'current_namespace.SlaveDeclSpace'.
4475 (namespace_declaration): Likewise.
4476 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
4477 check. It can't happen now.
4478 * decl.cs (DeclSpace.LookupType): Likewise.
4479 * driver.cs (MainDriver): Sanity check.
4481 2006-08-01 Raja R Harinath <rharinath@novell.com>
4483 * decl.cs (DeclSpace.FindNestedType): Remove.
4484 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
4485 LookupTypeContainer to get the container of the nested type.
4486 * class.cs (TypeContainer.FindNestedType): Make non-override.
4488 2006-07-31 Raja R Harinath <rharinath@novell.com>
4490 * decl.cs (DeclSpace.PartialContainer): Move field from ...
4491 * class.cs (TypeContainer.PartialContainer): ... here.
4492 (TypeContainer.AddBasesForPart): New helper.
4493 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
4495 * cs-parser.jay (current_class): Convert to DeclSpace.
4496 (struct_declaration, interface_declaration, class_declaration):
4497 Use AddBasesForPart instead of .Bases directly.
4498 * const.cs, iterators.cs: Update to changes.
4500 2006-07-28 Raja R Harinath <rharinath@novell.com>
4502 * class.cs (TypeContainer.AddMemberType): Rename from
4504 (TypeContainer.AddMember): Rename from AddToMemberContainer.
4505 (AddTypeContainer): New. Combine AddClassOrStruct and
4507 (AddPartial): Update. Add 'is_partial' argument.
4508 * roottypes.cs: Update to changes.
4509 * cs-parser.jay (push_current_class): New helper for handling
4510 current_container and current_class.
4511 (struct_declaration, interface_declaration, class_declaration):
4514 2006-07-26 Raja R Harinath <rharinath@novell.com>
4516 * roottypes.cs: Rename from tree.cs.
4518 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
4519 * tree.cs (Tree, ITreeDump): Remove types.
4520 * rootcontext.cs (tree, Tree): Remove fields.
4521 (root, ToplevelTypes): New.
4522 * *.cs: Update to rename.
4524 * tree.cs (Tree.RecordDecl): Remove.
4525 (RootTypes.AddToTypeContainer): Record the toplevel type in its
4527 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
4529 2006-07-23 Raja R Harinath <harinath@gmail.com>
4531 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
4532 DoFlowAnalysis and OmitStructFlowAnalysis here.
4533 (ec.With): Rename from WithUnsafe and generalize.
4534 (ec.WithCheckState): Remove. All users can be handled by 'With'.
4535 (ec.WithFlowAnalyis): New.
4536 * ecore.cs, expression.cs, statement.cs: Update.
4538 2006-07-22 Raja R Harinath <harinath@gmail.com>
4540 * statement.cs (Block.ResolveMeta): Simplify slightly.
4542 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
4543 multiple boolean fields. Convert InUnsafe, constant_check_state,
4544 check_state to flags.
4545 (CheckState, ConstantCheckState): Update.
4546 (InUnsafe): New read-only property.
4547 (FlagsHandle): Rename from CheckStateHandle and convert to handle
4549 (WithUnsafe): New helper similar to WithCheckState.
4550 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
4551 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
4553 2006-07-21 Raja R Harinath <rharinath@novell.com>
4555 Make comparisons use the same IL irrespective of whether they're
4556 in a 'checked' or 'unchecked' context: one of the issues in #78899
4557 * codegen.cs (EmitContext.CheckState): Make read-only property.
4558 (EmitContext.ConstantCheckState): Likewise.
4559 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
4560 helper that implement a save/restore stack for CheckState
4561 values. This is the only way to change check-state.
4562 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
4563 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
4564 (CheckedExpr.EmitBranchable): New forwarding method.
4565 (UnCheckedExpr): Likewise.
4566 * statement.cs (Block.ResolveMeta): Use WithCheckState.
4567 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
4568 (Checked.Resolve, checked.DoEmit): Likewise.
4570 2006-07-20 Miguel de Icaza <miguel@novell.com>
4572 * anonymous.cs: Cache the resolved anonymous delegate, and return
4573 this so that the ResolveTopBlock is only triggered once, not
4576 Currently we trigger ResolvetopBlock twice due to a first pass of
4577 argument check compatibility, and a second pass that does the
4580 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4582 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
4584 * rootcontext.cs (Reset): Add helper_classes.
4586 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4589 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
4592 2006-07-13 Miguel de Icaza <miguel@novell.com>
4594 * statement.cs (Lock): Handle expressions of type
4595 TypeManager.null_type specially. Fixes #78770
4597 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4599 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
4602 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4604 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
4605 for accessors as well.
4606 * ecore.cs (EventExpr): Add AccessorTable.
4608 2006-07-01 Marek Safar <marek.safar@seznam.cz>
4611 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
4612 for CS0122 where appropriate.
4613 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
4615 (Filter): Assembly can be null in the case of top level attributes.
4617 2006-06-25 Marek Safar <marek.safar@seznam.cz>
4621 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
4622 is done at global level.
4624 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4626 A fix for #77002, Implemented TypeForwarder support.
4628 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
4629 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
4630 * typemanager.cs (): Add type_forwarder_attr_type.
4632 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4634 * report.cs: Add CS0469 warning.
4636 2006-06-21 Martin Baulig <martin@ximian.com>
4638 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
4639 the `try'-block, so we also report CS0016 etc. there.
4641 2006-06-21 Martin Baulig <martin@ximian.com>
4644 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
4646 2006-06-21 Martin Baulig <martin@ximian.com>
4648 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
4649 also report CS1686 for parameters.
4651 2006-06-21 Martin Baulig <martin@ximian.com>
4653 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
4654 instead of an error if the value is not implicitly convertible to
4655 the switch types; fixes #77964.
4657 2006-06-21 Raja R Harinath <rharinath@novell.com>
4660 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
4661 FieldBuilder is null.
4664 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
4665 'left' and 'right' before error-checking.
4667 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
4669 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
4671 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
4672 (FieldExpr.DoResolve): likewise.
4673 (PropertyExpr.InstanceResolve): likewise.
4674 (EventExpr.InstanceResolve): likewise.
4676 2006-06-04 Marek Safar <marek.safar@seznam.cz>
4678 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
4679 attribute applicable tests for attribute argument.
4681 2006-06-02 Raja R Harinath <rharinath@novell.com>
4684 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
4685 (Binary.OverloadResolve_PredefinedIntegral): New.
4686 (Binary.OverloadResolve_PredefinedFloating): New.
4687 (Binary.OverloadResolve_PredefinedString): New.
4688 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
4689 Follow the standard more closely, and treat numeric promotions in
4690 terms of overload resolution.
4691 (Binary.CheckShiftArguments): Simplify.
4693 2006-06-01 Raja R Harinath <rharinath@novell.com>
4695 * flowanalysis.cs (MyBitVector): Simplify representation.
4696 (MyBitVector.Clone): Avoid allocating BitArray.
4697 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
4698 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
4699 (*): Update. Change all references to MyBitVector.And and
4700 MyBitVector.Or to &= and |=.
4702 2006-05-29 Raja R Harinath <rharinath@novell.com>
4705 * cs-parser.jay (formal_parameter_list): Extend the pattern below
4706 to param arguments too.
4708 2006-05-26 Miguel de Icaza <miguel@novell.com>
4710 * cs-parser.jay: Catch another parsing form for arglist being
4711 followed by other arguments. Fixes #78313.
4713 2006-05-24 Raja R Harinath <rharinath@novell.com>
4715 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
4716 checking of out parameters to ...
4717 (FlowBranchingToplevel.Merge): ... here.
4718 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
4719 set, propagate the origin upward, and only complain if there was
4721 (FlowBranchingException.AddContinueOrigin): Likewise.
4722 (FlowBranchingException.AddReturnOrigin): Likewise.
4723 (FlowBranchingException.AddGotoOrigin): Likewise.
4725 2006-05-23 Raja R Harinath <rharinath@novell.com>
4727 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
4728 unreachable, skip it.
4729 (FlowBranchingException.Merge): Always propagate jumps, even if
4730 the finally block renders subsequent code unreachable.
4732 2006-05-18 Raja R Harinath <rharinath@novell.com>
4735 * statement.cs (Goto.Resolve): Move responsibility for resolving
4736 'goto' to FlowBranching.AddGotoOrigin.
4737 (Goto.SetResolvedTarget): New. Callback to set the
4738 LabeledStatement that's the target of the goto.
4739 (Goto.DoEmit): Use Leave instead of Br when crossing an
4740 unwind-protect boundary.
4741 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
4742 LookupLabel and adjust to new semantics.
4743 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
4744 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
4745 Goto.SetResolvedTarget to update target.
4746 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
4747 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
4748 AddBreakOrigin & co. Delay propagation until ...
4749 (FlowBranchingException.Merge): ... this.
4751 * statement.cs (Block.Resolve): Always depend on flow-branching to
4752 determine unreachability. Kill workaround that originally emitted
4753 only one statement after an "unreachable" label (see infloop in
4756 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
4757 This is still "wrong", but anything better would probably need a
4758 multi-pass algorithm.
4759 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
4760 usage vector. Force current usage vector to be reachable, to
4761 optimistically signify backward jumps.
4762 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
4764 (FlowBranchingLabeled.Merge): New. If no backward jump was
4765 detected, return the original salted-away usage vector instead,
4766 updated with appropriate changes. Print unreachable warning if
4768 * statement.cs (Block.Resolve): Don't print unreachable warning on
4769 a labeled statement.
4771 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
4773 * driver.cs: Pass filename without path to AssemblyBuilder's
4774 AddResourceFile. Fixes bug #78407.
4776 2006-05-17 Raja R Harinath <rharinath@novell.com>
4778 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
4779 * flowanalysis.cs (FlowBranchingLabeled): ... here.
4780 (FlowBranching.MergeChild): Overwrite
4781 reachability information from Labeled branchings too.
4783 2006-05-16 Raja R Harinath <rharinath@novell.com>
4785 * statement.cs (Goto.Resolve): Merge jump origins here ...
4786 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
4788 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
4789 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
4790 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
4791 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
4793 * statement.cs (Goto.Resolve): ... not here.
4794 (Goto.Emit): Remove CS1632 check.
4796 2006-05-14 Marek Safar <marek.safar@seznam.cz>
4798 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
4801 2006-05-11 Raja R Harinath <rharinath@novell.com>
4803 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
4804 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
4805 (FlowBranchingException.Label): Likewise.
4807 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
4809 (MyBitVector.Or): Use it to avoid losing information (Count).
4810 (FlowBranching.MergeOrigins): Likewise.
4812 * flowanalysis.cs (UsageVector.IsDirty): Remove.
4813 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
4814 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
4815 (UsageVector.ToString): Simplify.
4816 (UsageVector.MergeSiblings): Move here from ...
4817 (FlowBranching.Merge): ... here.
4818 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
4821 2006-05-10 Raja R Harinath <rharinath@novell.com>
4823 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
4824 null bitvector is treated as all-true.
4826 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
4827 (MyBitVector): Rationalize invariants. 'vector != null' implies
4828 that we have our own copy of the bitvector. Otherwise,
4829 'InheritsFrom == null' implies all inherited bits are true.
4831 2006-05-09 Marek Safar <marek.safar@seznam.cz>
4833 * statement.cs (LocalInfo): Add IsConstant.
4834 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
4835 local variable for constants.
4837 2006-05-09 Raja R Harinath <rharinath@novell.com>
4839 * flowanalysis.cs (MyBitVector.Empty): New.
4840 (MyBitVector): Don't allow InheritedFrom to be null.
4841 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
4842 (UsageVector, FlowBranching): Update to changes.
4844 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
4845 recursion. The 'Parent == null' condition isn't sufficient for
4847 (FlowBranching.AddBreakOrigin): Likewise.
4848 (FlowBranching.AddContinueOrigin): Likewise.
4849 (FlowBranching.AddReturnOrigin): Likewise.
4850 (FlowBranching.StealFinallyClauses): Likewise.
4851 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
4852 (FlowBranching.CheckOutParameters): Likewise.
4853 (FlowBranchingToplevel): Terminate all the above recursions here.
4854 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
4855 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
4857 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
4859 (FlowBranchingToplevel): New. Empty for now.
4860 (FlowBranching.MergeTopBlock): Update.
4861 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
4862 branching for the anonymous delegate.
4863 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
4865 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
4866 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
4867 information at the start of the merge. Reorganize.
4869 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4871 * class.cs (MethodData.Define): Method cannot implement interface accessor.
4873 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4875 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
4876 to newly introduced ctor.
4878 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
4879 message to one place.
4880 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
4883 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4885 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
4887 * ecore.cs (Expression.ResolveAsConstant): Updated.
4889 * statement.cs (ResolveMeta): Updated.
4891 2006-05-06 Marek Safar <marek.safar@seznam.cz>
4893 * cs-parser.jay: __arglist cannot be used in initializer.
4895 2006-05-06 Marek Safar <marek.safar@seznam.cz>
4898 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
4901 2006-05-05 Raja R Harinath <rharinath@novell.com>
4903 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
4904 (LabeledStatement): Add 'name' parameter.
4905 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
4906 (Block.AddLabel): Update to changes.
4907 * cs-parser.jay (labeled_statement): Likewise.
4909 * flowanalysis.cs (BranchingType.Labeled): New.
4910 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
4911 (FlowBranchingLabeled): New. Does nothing for now, but will
4912 eventually handle 'goto' flows.
4913 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
4914 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
4915 that's terminated ...
4916 (Block.Resolve): ... here.
4918 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
4919 (UsageVector.MergeFinallyOrigins): Likewise.
4920 (FlowBranching.InTryOrCatch): Likewise.
4921 (FlowBranching.AddFinallyVector): Likewise.
4922 (FlowBranchingException): Update to changes.
4925 * statement.cs (Return.Resolve): Move error checking to ...
4926 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
4927 (FlowBranchingException): Handle return origins like break and
4929 (FlowBranching.UsageVector.CheckOutParameters): Remove.
4931 2006-05-04 Marek Safar <marek.safar@seznam.cz>
4934 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
4937 2006-05-04 Marek Safar <marek.safar@seznam.cz>
4940 * class.cs (MethodData.Define): Do public accessor check only when method
4941 implements an interface.
4943 2006-05-04 Raja R Harinath <rharinath@novell.com>
4945 Remove special handling of 'break'
4946 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
4947 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
4948 (UsageVector.Break): Remove.
4949 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
4951 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
4953 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
4954 UsageVector.Breaks (). Don't set NeedsReturnLabel.
4956 2006-05-03 Marek Safar <marek.safar@seznam.cz>
4959 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
4960 be the interface member.
4962 2006-05-03 Marek Safar <marek.safar@seznam.cz>
4965 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
4966 for emitting small (int) values.
4968 2006-05-03 Raja R Harinath <rharinath@novell.com>
4971 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
4972 control-flow passes through the 'finally' after merging-in all the
4973 control-flows from 'try' and the 'catch' clauses.
4975 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
4976 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
4977 always true at the only non-recursive entry point.
4978 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
4979 FlowBranchingBreakable.
4980 (FlowBranchingLoop): Remove.
4981 * statement.cs (Return.DoResolve): Update to changes.
4984 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
4985 (FlowBranching.CreateBranching): Handle it: create a
4986 FlowBranchingContinuable.
4987 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
4988 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
4989 except that it handles the 'continue' command.
4990 (FlowBranching.UsageVector.MergeOrigins): Rename from
4992 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
4993 except that it overrides AddContinueOrigin.
4994 (FlowBranchingException): Override AddContinueOrigin, similar to
4996 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
4997 Create a new branching around the embedded statement.
4998 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
4999 control flow after the embedded statement.
5000 (Continue.Resolve): Move all error checking to AddContinueOrigin.
5002 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
5003 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
5004 FlowBranchingBreakable.
5005 (FlowBranchingSwitch): Remove.
5008 * statement.cs (Break.Resolve): Simplify. Move responsibility for
5009 error reporting to ...
5010 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
5011 Rename from 'AddBreakVector'. Add new location argument. Return
5012 a bool indicating whether the 'break' crosses an unwind-protect.
5013 (FlowBranchingException.AddBreakOrigin): Add.
5014 (FlowBranchingException.Merge): Propagate 'break's to surrounding
5015 flowbranching after updating with the effects of the 'finally'
5017 (FlowBranchingBreakable): New common base class for
5018 FlowBranchingLoop and FlowBranchingSwitch.
5020 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
5022 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
5024 2006-05-02 Raja R Harinath <rharinath@novell.com>
5026 * statement.cs (Do.Resolve): If the loop is infinite, set the
5028 (While.Resolve, For.Resolve): Set a barrier after the embedded
5029 statement. There's no direct control flow that goes from the end
5030 of the embedded statement to the end of the loop.
5031 * flowanalysis.cs (FlowBranching.Infinite): Remove.
5032 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
5033 above ensure that the reachability is correctly computed.
5035 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
5036 (UsageVector.MergeBreakOrigins): If the current path is
5037 unreachable, treat it as if all parameters/locals are initialized.
5038 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
5039 infinite loops before merging-in break origins.
5041 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
5042 (Reachability.Reachable): Split part into ...
5043 (Reachability.Unreachable): ... this. Simplify.
5044 (Reachability.IsUnreachable): Use 'Unreachable' instead.
5046 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
5047 (Reachability.SetThrowsSometimes): Likewise.
5048 (FlowBranchingBlock.MergeTopBlock): Don't compare against
5049 TriState.Always, use corresponding property.
5050 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
5051 (Block.Resolve): Likewise. Remove some redundant checks.
5053 2006-05-02 Raja R Harinath <harinath@gmail.com>
5055 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
5056 (Reachability.Meet): Don't bother checking AlwaysThrows --
5057 barrier is always set.
5058 (FlowBranchingBlock.Merge): Likewise.
5060 2006-05-01 Raja R Harinath <harinath@gmail.com>
5062 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
5063 checks for unreachable.
5065 2006-05-01 Marek Safar <marek.safar@seznam.cz>
5068 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
5070 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
5071 whether field is really assigned.
5073 2006-04-30 Raja R Harinath <harinath@gmail.com>
5075 * flowanalysis.cs (Reachability): Make 4-argument constructor
5077 (Reachability.Meet): Rename from 'And'. Remove static variant.
5078 (Reachability.Always): Rename from the highly misleading
5079 'Reachability.Never'.
5080 (FlowBranching.Merge): Update to changes. Mark an impossible
5081 situation with a 'throw'.
5082 (*): Update to changes.
5084 2006-04-29 Raja R Harinath <harinath@gmail.com>
5086 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
5088 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
5089 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
5090 (*): Update to changes.
5091 * statement.cs: Update to changes.
5093 2006-04-28 Marek Safar <marek.safar@seznam.cz>
5096 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
5098 2006-04-28 Raja R Harinath <harinath@gmail.com>
5100 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
5103 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
5104 argument to two arguments: an usage-vector and a bool. Move call
5105 to FlowBranching.Merge () ...
5106 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
5108 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
5109 handling of loop and switch reachability to ...
5110 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
5112 2006-04-27 Raja R Harinath <harinath@gmail.com>
5114 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
5115 handling to FlowBranchingLoop.InLoop.
5116 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
5118 2006-04-26 Marek Safar <marek.safar@seznam.cz>
5121 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
5122 anonymous method is allowed from AnonymousContainer here.
5124 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
5126 2006-04-24 Raja R Harinath <rharinath@novell.com>
5129 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
5131 2006-04-23 Marek Safar <marek.safar@seznam.cz>
5134 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
5135 (DoubleConstant.Reduce): Ditto.
5137 2006-04-23 Raja R Harinath <rharinath@novell.com>
5139 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
5140 Remove 'lvalue_right_side' argument. Move parts to ...
5141 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
5142 (LocalVariable.DoResolveLValue): ... these.
5144 2006-04-21 Raja R Harinath <rharinath@novell.com>
5147 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
5148 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
5149 (LocalVariableReference.DoResolveBase): Use it to implement new
5151 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
5152 (Argument.Resolve): Simplify. Move CS1510 check ...
5153 * ecore.cs (Expression.ResolveLValue): ... here.
5154 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
5155 (PropertyExpr.DoResolveLValue): Likewise.
5156 (FieldExpr.Report_AssignToReadonly): Likewise.
5157 (FieldExpr.DoResolve): Add 'out_access' argument. Use
5158 LValueMemberAccess or LValueMemberOutAccess on instance depending
5160 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
5161 DoResolve as appropriate.
5163 2006-04-20 Raja R Harinath <rharinath@novell.com>
5166 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
5167 implicit conversions on 'out' and 'ref' arguments.
5169 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
5170 improve clarity. Remove dead code.
5173 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
5174 (Catch.Resolve): Resolve VarBlock if it exists.
5176 2006-04-19 Miguel de Icaza <miguel@novell.com>
5178 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
5179 twice, this was some residual code, the enumerator was emitted
5180 properly in the two branche of if later.
5182 2006-04-19 Raja R Harinath <rharinath@novell.com>
5184 * expression.cs (Cast.ResolveLValue): Remove. The result of a
5185 cast is never an lvalue.
5186 (Cast.DoResolve, Cast.ResolveRest): Combine.
5187 (Argument.Emit): Simplify slightly. Move 'Expr is
5188 IMemoryLocation' check ...
5189 (Argument.Resolve): ... here.
5190 (Argument.Error_LValueRequired): Remove. Inline into only user.
5192 Simplifications. Fix cs0191-2.cs
5193 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
5194 CS1649 and CS1651 to ...
5195 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
5196 the actual selection of the error code and message to a lookup
5197 table. Add a dummy return value to simplify callsites.
5198 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
5199 readonly fields of other instances of the same type. Move CS0197
5201 * expression.cs (Argument.Resolve): ... here. Simplify code.
5202 Ensure that ec.InRefOutArgumentResolving is only set during LValue
5203 resolution of an out or ref argument. The code simplification
5204 above uses this invariant.
5206 2006-04-18 Raja R Harinath <rharinath@novell.com>
5208 Possibly fix #77752. Fix cs1690-[4-7].cs.
5209 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
5210 CheckMarshallByRefAccess. Drop parameter.
5211 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
5213 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
5215 * report.cs (AllWarnings): Add CS1690.
5216 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
5218 (LocalVariableReference.DoResolveBase): Update.
5220 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5222 * class.cs (MethodOrOperator): Moved common parts from method class.
5223 detect obsolete attributes.
5224 (Method.Define): Simplified as it reuses code from base.
5225 (Constructor.ValidAttributeTargets): Fixed issue found during
5227 (Destructor.ValidAttributeTargets): Fixed issue found during
5229 (Operator): Finished refactoring set off by #78020. Operator class is now
5230 ordinary method class.
5232 * anonymous.cs: Updated.
5234 * decl.cs (DeclSpace): Add IsGeneric
5236 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5238 * class.cs (Constructor.Emit): Don't emit the attributes twice.
5240 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5242 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
5243 detect obsolete attributes.
5244 (Method.CreateEmitContext): Moved to MethodOrOperator.
5246 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5249 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
5250 customized exception to make crash detection easier.
5251 (MethodOrOperator): Started to work on new base class for methods and
5253 (Method): Derives from MethodOrOperator.
5254 (Constructor.Emit): Emits its own attributes.
5255 (AbstractPropertyEventMethod.Emit): Ditto.
5256 (Operator): Derives from MethodOrOperator, will refactor fully in extra
5258 (Operator.Emit): It's temporary more tricky than should be.
5260 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
5262 * report.cs (InternalErrorException): Add ctor with inner exception.
5264 2006-04-08 Marek Safar <marek.safar@seznam.cz>
5267 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
5270 2006-04-07 Marek Safar <marek.safar@seznam.cz>
5273 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
5276 2006-04-06 Marek Safar <marek.safar@seznam.cz>
5278 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
5279 attribute is present and Guid not.
5280 (Interface.ApplyAttributeBuilder): Ditto.
5282 * attribute.cs: Add error message.
5284 2006-04-06 Marek Safar <marek.safar@seznam.cz>
5288 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
5289 sources (it's composite) so hold them in extra array as they are used in
5290 Emit phase only. It worked in the previous versions by mistake.
5291 (Attribute.Emit): Emit attribute for more owners when exist.
5293 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
5294 it has now different behaviour.
5296 2006-04-04 Marek Safar <marek.safar@seznam.cz>
5298 * constant.cs (Constant.IsDefaultInitializer): New method.
5300 * class.cs: Updated.
5302 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
5303 re-initialize default values. It saves KBs almost for every assembly.
5304 Thanks Zoltan for the idea.
5305 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
5306 (ArrayCreation.DoResolve): Resolve only once.
5307 (ArrayCreation.Emit): Emit static initializer only when it is faster.
5308 (ArrayCreation.GetAttributableValue): Cope with optimized values.
5310 2006-04-03 Zoltan Varga <vargaz@gmail.com>
5312 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
5315 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5317 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
5318 in an embedded statement too.
5320 2006-04-01 Raja R Harinath <rharinath@novell.com>
5323 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
5325 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5329 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
5332 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
5334 2006-03-31 Marek Safar <marek.safar@seznam.cz>
5336 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
5339 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
5340 LocalTemporary change.
5342 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
5344 (ClassOrStruct.DefineFieldInitializers): Implemented static field
5345 initializers optimization.
5346 (ClassOrStruct.TypeAttr): Moved from modifiers.
5347 (Constructor.CheckBase): Don't crash when static ctor has parameters.
5348 (FieldBase.ResolveInitializer): Resolves initializer.
5349 (FieldBase.HasDefaultInitializer): New property.
5351 * cs-parser.jay: Removed message.
5353 * expression.cs (CompilerGeneratedThis): New specialization.
5355 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
5357 2006-03-28 Marek Safar <marek.safar@seznam.cz>
5359 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
5361 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5363 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
5364 be now EnumConstants only.
5366 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5368 * attribute.cs, driver.cs: Reset more caches.
5370 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5372 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
5374 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5376 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
5377 for easier reuse. Updated all overrides.
5378 (IntegralConstant): New base class for all integral constants.
5379 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
5380 of the constant range, report custom error.
5381 (UIntConstant.Reduce): Fixed uint conversion.
5383 * ecore.cs, literal.cs: Reduce updates.
5385 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5389 * class.cs (Constructor.Define): Removed extra if for default ctors.
5390 A patch from Atsushi Enomoto.
5392 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5394 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
5395 GetAttributableValue.
5397 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
5400 * convert.cs (ImplicitConversionRequired): Error message moved to
5403 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
5404 automatic implicit conversion of an output value.
5405 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
5407 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
5409 (TypeOf.GetAttributableValue): Add extra handling for object type.
5411 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
5412 special error message.
5414 2006-03-25 Marek Safar <marek.safar@seznam.cz>
5416 * class.cs (Constructor.Emit): Don't crash when struct ctor is
5418 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
5419 compatible with MS runtime.
5421 2006-03-23 Marek Safar <marek.safar@seznam.cz>
5423 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
5424 attribute arguments here.
5426 * class.cs (Indexer.Define): The check was moved to attribute class.
5428 2006-03-22 Marek Safar <marek.safar@seznam.cz>
5430 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
5431 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
5434 2006-03-22 Raja R Harinath <rharinath@novell.com>
5436 Support ParameterDefaultValueAttribute in gmcs. Also applied to
5437 mcs to keep code differences small.
5438 * attribute.cs (Attribute.GetParameterDefaultValue): New.
5439 * typemanager.cs (parameter_default_value_attribute_type): New.
5440 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
5443 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5445 * expression.cs (StringConcat.Append): Reverted back to no warning state.
5447 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5449 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
5451 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
5454 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
5456 * doc-bootstrap.cs : fix build.
5458 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5460 * expression.cs (StringConcat.Append): Issue a warning when empty string
5463 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5465 * assign.cs (CompoundAssign.ResolveSource): Removed.
5467 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
5470 * class.cs (TypeContainer.FindMethods): Removed.
5471 (TypeContainer.CheckMemberUsage): Made static.
5473 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
5475 * constant.cs (CheckRange): Removed unused type argument.
5476 (CheckUnsigned): Removed unused type argument.
5478 * cs-parser.jay: Updated after MemberAccess clean up.
5479 Uses Length for empty string test.
5481 * cs-tokenizer.cs: Uses Length for empty string test.
5482 (IsCastToken): Made static.
5483 (is_hex): Made static.
5484 (real_type_suffix): Made static.
5486 * decl.cs (SetupCache): Made static.
5487 (OnGenerateDocComment): Removed unused ds argument.
5489 * delegate.cs (VerifyDelegate): Removed unused argument.
5491 * doc.cs: Uses Length for empty string test.
5493 * driver.cs: Uses Length for empty string test.
5495 * enum.cs (IsValidEnumType): Made static
5497 * expression.cs (EnumLiftUp): Removed unused argument.
5498 (ResolveMethodGroup): Ditto.
5499 (BetterConversion): Ditto.
5500 (GetVarargsTypes): Ditto.
5501 (UpdateIndices): Ditto.
5502 (ValidateInitializers): Ditto.
5503 (MemberAccess.ctor): Ditto.
5504 (GetIndexersForType): Ditto.
5506 * flowanalysis.cs: (MergeFinally): Removed unused argument.
5508 * iterators.cs: Updated after MemberAccess clean up.
5510 * location.cs: Uses Length for empty string test.
5512 * namespace.cs: Uses Length for empty string test.
5514 * report.cs (CheckWarningCode): Made static.
5516 * statement.cs (LabeledStatement): Removed unused argument.
5518 * typemanager.cs (FilterNone): Removed.
5520 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5522 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
5525 * class.cs: Updated.
5527 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5529 * cs-parser.jay.cs: __arglist is not allowed for delegates.
5531 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5535 * expression.cs (VerifyArgumentsCompat): Reverted to double error
5536 reporting, it's more tricky than I thought.
5538 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5542 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
5544 (AnonymousMethod.ImplicitStandardConversionExists): New method.
5545 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
5546 Add more error reporting; Fixed issue with params.
5548 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
5550 * cs-parser.jay: AnonymousMethod requires host container.
5552 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
5554 2006-03-18 Raja R Harinath <harinath@gmail.com>
5556 * class.cs: Change 'TypeContainer ds' constructor argument to
5557 'DeclSpace parent'. Some classes were missed below due to
5558 different naming convention.
5560 * class.cs (MemberCore.Parent): Delete. This makes the
5561 ParentContainer changes below enforceable by the compiler.
5563 Treat pointers to enclosing declaration space as 'DeclSpace', not
5565 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
5566 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
5568 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
5570 (Block.AddThisVariable): Likewise.
5571 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
5572 (AbstractPropertyEventMethod.Emit): Likewise.
5573 (AbstractPropertyEventMethod.EmitMethod): Likewise.
5574 (GetMethod.Define, SetMethod.Define): Likewise.
5575 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
5576 (DelegateMethod.EmitMethod): Likewise.
5578 Fix regression test-partial-13.cs.
5579 Rationalize use of PartialContainer. Ensure that the partial
5580 class semantics can be tied to type-correctness, i.e., any
5581 violation will cause a compile error.
5582 * class.cs, const.cs: Access all fields that belong to class
5583 TypeContainer via ParentContainer. Arguments of EmitContexts and
5584 Resolve()-like functions still use 'Parent'.
5586 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
5587 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
5588 (PropertyMethod.CheckModifiers): Remove unused argument.
5589 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
5592 2006-03-17 Raja R Harinath <harinath@gmail.com>
5594 Make semantics of PartialContainer simpler.
5595 * decl.cs (DeclSpace.IsPartial): Remove.
5596 * class.cs (TypeContainer.IsPartial): Likewise.
5597 (TypeContainer..ctor): Set PartialContainer to point to self.
5598 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
5599 (TypeContainer.FindNestedType): Likewise.
5600 (MemberCore.ParentContainer): Simplify. Remove deprecation.
5602 2006-03-17 Marek Safar <marek.safar@seznam.cz>
5604 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
5606 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5608 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
5611 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5613 * class.cs (Operator.Define): An error for base conversion was not
5616 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
5618 * iterator.cs : yield break is allowed in try statement which has
5619 catch clauses. Fixed bug #77767.
5621 2006-03-13 Marek Safar <marek.safar@seznam.cz>
5623 A fix for #77593, #77574.
5625 * class.cs (MethodCore.CheckBase): Another if for operator.
5627 2006-03-09 Marek Safar <marek.safar@seznam.cz>
5629 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
5632 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
5633 (DelegateCreation.ImplicitStandardConversionExists): New method for just
5636 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
5639 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
5640 Updated after another emitcontext usage was clean up. It should help us to
5641 synchronize with gmcs easier.
5643 2006-03-04 Marek Safar <marek.safar@seznam.cz>
5647 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
5648 (Event.Define): ditto
5649 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
5651 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
5652 Removed redundant code and set NewSlot for Invoke method too.
5654 * parameter.cs (Parameters.ctor): Add custom, type ctor.
5655 (Parameters.MergeGenerated): New method. Use this method when you merge
5656 compiler generated argument with user arguments.
5658 2006-03-03 Marek Safar <marek.safar@seznam.cz>
5660 * attribute.cs (ResolveAsTypeTerminal): Removed.
5662 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
5663 specialization for predefined types; 30% speed up.
5664 Finally placed obsolete check to right place.
5665 (Expression.ResolveType): Removed.
5667 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
5668 Updated after ResolveType was removed.
5670 * expression.cs (Cast.ctor): Check void cast.
5671 (Binary.ResolveAsTypeTerminal): Is never type.
5672 (Conditional.ResolveAsTypeTerminal): Is never type.
5674 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
5676 2006-03-01 Raja R Harinath <rharinath@novell.com>
5679 * expression.cs (ParameterReference.DoResolveBase): Change return
5681 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
5685 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
5688 * typemanager.cs (GetFullNameSignature): Don't nullref on
5689 protected accessors.
5691 2006-02-27 Marek Safar <marek.safar@seznam.cz>
5693 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
5694 these two separated members to simplify the code.
5695 (Attribute.Resolve): Refactored to use new fields and methods.
5696 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
5697 implemented obsolete attribute checking.
5698 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
5699 implemented obsolete checking again. It look line never ending quest ;-)
5700 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
5702 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
5704 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
5706 *class.cs (Property.Define): Add RegisterProperty call.
5708 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
5709 argument groups (only 2).
5711 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
5712 encoding expression to arguments.
5713 (Expression.ExprClassToResolveFlags): Just turned to property.
5715 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
5716 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
5717 optimized as well as implemented support for zero-length attributes.
5719 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
5720 Add caching of PropertyInfo's.
5722 2006-02-25 Marek Safar <marek.safar@seznam.cz>
5724 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
5725 error multiple times.
5727 2006-02-25 Marek Safar <marek.safar@seznam.cz>
5729 New partial class implementation.
5730 A fix for #77027, #77029, #77403
5732 * attribute.cs (Attributable): Made attributes protected.
5734 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
5735 the replacements of ClassPart and PartialContainer.
5736 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
5737 (TypeContainer.AddInterface): Ditto.
5738 (TypeContainer.AddPartial): The main method for partial classes. It checks
5739 for errors and merges ModFlags and attributes. At the end class is added to
5741 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
5743 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
5744 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
5745 from the rest of partial classes.
5746 (TypeContainer.GetClassBases): Simplified.
5747 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
5749 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
5750 (TypeContainer.HasExplicitLayout): Uses Flags now.
5751 (PartialContainer): Removed.
5752 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
5753 (StaticClass): Was merged with Class.
5754 (Class.GetClassBases): class and static class bases are verified here.
5755 (Class.TypeAttr): Added static attributes when class is static.
5756 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
5757 (MemberBase): In some cases we need to call parent container for partial
5758 class. It should be eliminated but it's not easy now.
5760 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
5762 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
5763 partial classed to accumulate class comments.
5764 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
5766 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
5768 * driver.cs (MainDriver): Tree.GetDecl was removed.
5770 * modifiers.cs (Modifiers): Add partial modifier.
5772 * tree.cs (Tree.decl): Removed.
5773 (RootTypes): Started to use this class more often for root types
5776 2006-02-22 Marek Safar <marek.safar@seznam.cz>
5780 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
5781 external interface does not have an attribute.
5783 2006-02-22 Marek Safar <marek.safar@seznam.cz>
5785 Another prerequisites for new partial classs implementation.
5787 * attribute.cs (Attribute.Equal): Implemented.
5788 (Attribute.Emit): Changed as attributes can be applied more than twice.
5789 (Attributes.Emit): Check for duplicate attributes here.
5791 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
5792 as a parameter, clean-up.
5794 2006-02-11 Marek Safar <marek.safar@seznam.cz>
5798 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
5799 contains obsolete attribute check which can in some cases look for base
5800 type of current class which is not initialized yet.
5801 (TypeContainer.BaseType): Replacement of ptype.
5803 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
5805 2006-02-11 Marek Safar <marek.safar@seznam.cz>
5807 First of prerequisites for new partial classs implemention.
5809 * attribute.cs (Attributable): Extended by ResolveContext;
5810 Attributes finally have correct context for resolving in all cases.
5811 (AttachTo): Attribute owner is assigned here.
5813 * codegen.cs (IResolveContext): Introduce new interface to hold
5814 all information needed in resolving phase.
5815 (EmitContext): Implements IResolveContext; more clean-up needed here.
5817 * decl.cs (MemberCore): Implemented IResolveContext.
5819 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
5820 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
5821 parameter.cs, statement.cs, tree.cs, typemanager.cs:
5822 Refactored to use new IResolveContext instead of EmitContext; cleanup
5824 2006-02-06 Miguel de Icaza <miguel@novell.com>
5826 * codegen.cs (EmitScopeInitFromBlock): check here the
5827 capture_context, there is no need to make two calls to the
5830 * anonymous.cs: Add some debugging messages that might help me
5831 track other instances of this problem in the future (the
5832 regression of test 467).
5834 * cs-parser.jay: track the variable block, as we need to initalize
5835 any captured variables declared in this block for the "catch"
5836 portion of the "Try" statement.
5838 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
5839 scope initialization for captured variables.
5841 Also, move the emit for the variables after the block location has
5844 2006-02-06 Marek Safar <marek.safar@seznam.cz>
5846 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
5848 2006-02-02 Miguel de Icaza <miguel@novell.com>
5850 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
5851 commit yesterday, the initialization for the roots is necessary.
5852 What is not necessary is the scope activation.
5854 2006-02-02 Raja R Harinath <rharinath@novell.com>
5856 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
5857 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
5859 (Argument.Resolve): Remove CS0206 checks.
5861 2006-02-01 Miguel de Icaza <miguel@novell.com>
5863 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
5864 scopes for all the roots, the scopes will now be emitted when the
5865 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
5867 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
5868 code. This reduces a lot of existing cruft.
5870 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
5871 that the ScopeInfo is generated as we enter the scope, not at the
5872 time of use, which is what we used to do before.
5874 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
5875 every time a Block is about to be emitted if we have a
5878 2006-02-01 Raja R Harinath <rharinath@novell.com>
5880 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
5882 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
5884 * typemanager.cs (cons_param_array_attribute): Make private.
5885 (Reset): Set it to null.
5886 (InitCoreHelpers): Don't initialize it.
5887 (ConsParamArrayAttribute): New. Initialize it as needed.
5888 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
5890 2006-01-31 Miguel de Icaza <miguel@novell.com>
5892 * expression.cs: There might be errors reported during the
5893 selection of applicable methods. If there are errors, do not
5894 continue execution as it will lead the compiler to crash.
5896 2006-01-30 Miguel de Icaza <miguel@novell.com>
5898 * expression.cs: Member access is not allowed on anonymous
5899 methods. Fixes #77402.
5901 2006-01-30 Raja R Harinath <rharinath@novell.com>
5904 * cs-parser.jay (VariableDeclaration): Don't set
5905 current_array_type to null.
5906 (field_declaration, event_declaration, declaration_statement):
5907 Set it to null here.
5909 2006-01-28 Raja R Harinath <harinath@gmail.com>
5911 * typemanager.cs (GenericParameterPosition): New.
5914 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
5916 * doc.cs : To process "include" elements, first we should create
5917 another list than XmlNodeList, because it could result in node
5918 removal, which could result in that the XmlNodeList gives up
5921 (Also made code identical to gmcs again.)
5923 2006-01-25 Miguel de Icaza <miguel@novell.com>
5925 * ecore.cs: Introduce an error report that we were not catching
5926 before, if not silent, we must report the error. Gonzalo ran into
5929 2006-01-23 Miguel de Icaza <miguel@novell.com>
5931 A fix for bug: #76957
5933 * iterators.cs (MoveNextMethod.CreateMethodHost): call
5934 ComputeMethodHost before creating the method, this is a new
5937 * anonymous.cs (AnonymousContainer): Now we track all the scopes
5938 that this method references (RegisterScope). The actual scope
5939 where the method is hosted is computed with the ComputeMethodHost
5940 before we create the method.
5942 Moved the Deepest routine here.
5944 (AnonymousContainer.ComputeMethodHost): New routine used to
5945 compute the proper ScopeInfo that will host the anonymous method.
5947 (ScopeInfo): Deal with multiple roots. The problem was that we
5948 did not have a unique root where all ScopeInfos could be hanged
5949 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
5952 Remove AdjustMethodScope which is now computed at the end. Remove
5953 LinkScope which did a partial link, instead link all ScopeInfos
5954 before code generation from the new "LinkScopes" routine.
5956 Simplify all the Add* routines as they no longer need to maintain
5957 the tree, they just need to record that they are using variables
5960 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
5961 routines to produce the forest of ScopeInfo trees.
5963 * class.cs (TypeContainer.AppendMethod): This is just like
5964 AddMethod, but ensures that an interface implementation method
5965 (IEnumerable.XXX) is not inserted at the beginning of the queue of
5966 methods, but at the end.
5968 We use this functionality to ensure that the generated MoveNext
5969 method in the iterator class is resolved/emitted before the
5970 enumerator methods created.
5972 This is required because the MoveNext method computes the right
5973 ScopeInfo for the method. And the other methods will eventually
5974 need to resolve and fetch information computed from the anonymous
5977 2006-01-21 Raja R Harinath <harinath@gmail.com>
5978 Carlos Alberto Cortez <calberto.cortez@gmail.com>
5981 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
5983 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
5984 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
5986 2006-01-18 Raja R Harinath <rharinath@novell.com>
5988 Fix #76656, cs0231-2.cs.
5989 * cs-parser.jay (formal_parameter_list): Make error case catch
5991 (parenthesized_expression_0): Add CS1026 check.
5992 (invocation_expression): Remove unused { $$ = lexer.Location }.
5994 2006-01-17 Raja R Harinath <rharinath@novell.com>
5997 * cs-parser.jay (statement_expression): Don't list out the
5998 individual statement-expressions. Convert syntax error into
6001 2006-01-16 Raja R Harinath <rharinath@novell.com>
6004 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
6005 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
6006 CheckIntermediateModification.
6007 (FieldExpr.DoResolve): Add new two-argument version that
6008 allows us to resolve the InstanceExpression as an lvalue.
6009 The one-argument variant is now just a wrapper.
6010 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
6011 Resolve the lhs as an lvalue if the it has a value type.
6012 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
6013 from Assign.DoResolve.
6014 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
6015 resolved as an lvalue.
6016 (PropertyExpr.DoResolve): Update.
6017 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
6018 has a value type. Move CS1612 check here from
6019 CheckIntermediateModification.
6020 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
6021 * expression.cs (EmptyExpression.OutAccess): New. Used as the
6022 'right_side' of a ResolveLValue on an 'out' argument.
6023 (EmptyExpression.LValueMemberAccess): New. Used as the
6024 'right_side' of a propagated ResolveLValue on a value type.
6025 (LocalVariableReference.DoResolveBase): Recognize
6026 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
6028 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
6029 EmptyExpression.Null.
6031 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
6033 * typemanager.cs : added IsGenericParameter(). In mcs it always
6035 * doc.cs : for generic parameters, use GenericParameterPosition,
6038 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
6040 * expression.cs: Fix Console.WriteLine ((this = x).foo);
6042 2006-01-12 Miguel de Icaza <miguel@novell.com>
6044 This fixes the problem where we used ldfld instead of ldflda to
6045 load the "THIS" pointer on captured parameters, when THIS is a
6046 value type. See bug #77205.
6048 * iterators.cs (CapturedThisReference.Emit): Pass false to
6049 EmitThis (we do not need the address).
6051 * codegen.cs (EmitThis): it needs to know whether we need the
6052 address of `this' or not. This is used by value types.
6054 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
6055 every other call passes false.
6057 2006-01-12 Raja R Harinath <rharinath@novell.com>
6060 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
6062 * expression.cs (Invocation.OverloadResolve): Update.
6063 (Invocation.DoResolve): Avoid double resolution of invocation.
6065 2006-01-11 Raja R Harinath <rharinath@novell.com>
6068 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
6069 unary negation of floating point types as 0-expr; negation cannot
6070 overflow in floating point types.
6073 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
6074 on operands of 'void' type.
6077 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
6078 and ExclusiveOr for boolean constants too.
6080 2006-01-09 Raja R Harinath <rharinath@novell.com>
6083 * expression.cs (Invocation.OverloadResolve): Replace reflected
6084 override methods with their base virtual methods, rather than
6086 * typemanager.cs (TypeManager.GetOverride): New.
6088 2006-01-05 Jb Evain <jbevain@gmail.com>
6090 * class.cs (Property.Define, Indexer.Define): do not tag the
6091 properties as SpecialName | RTSpecialName.
6093 2006-01-04 Miguel de Icaza <miguel@novell.com>
6095 * class.cs (MethodCore.IsDuplicateImplementation): This method was
6096 doing a low-level comparission of parameter types. It was lacking
6097 a check for __argslist.
6099 2005-12-30 Miguel de Icaza <miguel@novell.com>
6101 * expression.cs (ParameterReference.DoResolveBase): Allow
6102 reference parameters if they are local to this block.
6104 This allows the ref and out parameters of a delegate to be used in
6105 an anonymous method, for example:
6107 delegate void set (out int x);
6109 set s = delegate (out int x){
6113 This is used by functionality introduced late in the C# language.
6115 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
6116 method that take ref and out parameters.
6118 Fixes #77119 which was a late change in the spec.
6120 2005-12-23 Miguel de Icaza <miguel@novell.com>
6122 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
6123 parent if its the same scope. Fixes #77060.
6125 2005-12-21 Miguel de Icaza <miguel@novell.com>
6127 * driver.cs: Report the case of no source files and no -out:
6130 2005-12-20 Raja R Harinath <rharinath@novell.com>
6133 * expression.cs (ComposedCast.GetSignatureForError): Define.
6135 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6139 * namespace.cs (NamespaceEntry): Add extern_aliases as a
6140 ListDictionary, to contain the ExternAliasEntry entries (in
6141 addition to the NamespaceEntry.aliases hashtable). This field is
6142 shared between the original entry and its doppelganger (bodyless
6144 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
6145 extern_aliases field.
6146 (NamespaceEntry.Lookup): Move the IsImplicit check after the
6147 lookup in extern_aliases.
6149 2005-12-16 Raja R Harinath <rharinath@novell.com>
6152 * class.cs (TypeContainer.Mark_HasEquals): New.
6153 (TypeContainer.Mark_HasGetHashCode): New.
6154 (ClassPart): Override them.
6155 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
6158 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
6159 'parent' argument to the base constructor.
6161 Remove all mention of TypeContainer from decl.cs.
6162 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
6163 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
6164 (DeclSpace.DeclSpace): Likewise.
6165 (DeclSpace.DefineMembers): Remove unused argument.
6166 * cs-parser.jay (pop_current_class): Update to changes. Simplify
6167 debugging check -- we don't care if the debug code throws an
6168 InvalidCastException instead of an InternalErrorException.
6169 * class.cs (TypeContainer.DefineMembers): Update to changes.
6170 (TypeContainer.DoDefineMembers): Likewise.
6171 (TypeContainer.GetMethods): Likewise.
6172 (PropertyMember.Define): Likewise.
6173 (MemberBase.Parent): New property that forwards to
6174 MemberCore.Parent, but ensures that we get a TypeContainer.
6175 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
6176 (RootContext.PopulateTypes): Likewise. Remove special case code
6177 for !RootContext.StdLib: DefineMembers is idempotent.
6179 2005-12-14 Miguel de Icaza <miguel@novell.com>
6181 * convert.cs (ExplicitConversionCore): Check the return value from
6182 ExplicitConversionCore which can return null on failure. Fixes #76914
6184 2005-12-13 Marek Safar <marek.safar@seznam.cz>
6186 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
6188 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
6190 * doc.cs : The search for referenced namespace was insufficient to
6191 get global one as it used to do. Fixed bug #76965.
6193 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
6195 * doc.cs : check name in cref in the last phase that whether it is
6198 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6200 * cs-tokenizer.cs : reverted the latest change: it somehow broke
6203 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6205 * doc.cs : so it turned out that we cannot skip override check for
6206 interface members. Fixed bug #76954.
6208 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6210 * cs-tokenizer.cs : fixed bug #75984:
6211 - #warning and #error should not be handled when the source line
6213 - #line is not checked strictly when the source line is disabled.
6214 - #define and #undef is on the other hand checked strictly at any
6217 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
6219 * cs-tokenizer.cs : missing Location (actually, filename) in one of
6222 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6224 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
6226 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
6228 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
6229 (FieldBase.Initializer): Initializer is now optional.
6230 (EventField.Define): Only event field can have initializer.
6232 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
6234 * const.cs (Const): Reuse initializer.
6236 * cs-parser.jay: Updated after FieldBase changes.
6237 Added current_array_type to simplify array initializers.
6239 * ecore.cs (NullCast.IsDefaultValue): Implemented.
6241 * expression.cs, iterators.cs: Updated.
6243 * namespace.cs (NamespaceEntry): Made UsingFound private.
6245 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6247 * parameterCollection.cs: Obsolete, removed.
6248 * parser.cs: Obsolete, removed.
6250 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6253 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
6255 * enum.cs (Enum.Define): Set obsolete context here.
6257 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6260 - FindDocumentedMember() now expects 1) paramList as null
6261 when "we don't have to check the number of parameters" and
6262 2) Type.EmptyTypes when "there is no arguments".
6263 - Introduced FoundMember struct to hold the exact type which was
6264 used to find the documented member (the above change broke
6265 test-xml-044; it might be better just to use DeclaringType than
6266 what MS does, like this change does, but it depends on usage.)
6268 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6270 * doc.cs : documented member might be from DeclaringType for nested
6271 types. Fixed bug #76782.
6273 2005-12-03 Ben Maurer <bmaurer@ximian.com>
6275 * anonymous.cs: Have the param code handle leaving copies on the
6276 stack etc. Allows anonymous params to take part in the assignment
6277 code (++, +=, etc). Fixes bug #76550
6279 * expression.cs: Handle the prepare_for_load/leave_copy by passing
6280 it down to the anon code.
6282 * iterators.cs: Use dummy var here
6284 * codegen.cs: Handle new vars
6286 2005-12-01 Marek Safar <marek.safar@seznam.cz>
6289 * class.cs (MethodData.Define): Set proper Obsolete context.
6291 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
6293 (FieldExpr.DoResolve): Ditto.
6295 2005-12-01 Marek Safar <marek.safar@seznam.cz>
6298 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
6299 parent is not obsolete.
6301 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
6303 * doc.cs : (FindDocumentedMember) find parameterless members first
6304 and get CS0419 in the early stage. Fixed first case of bug #76727.
6306 2005-11-30 Marek Safar <marek.safar@seznam.cz>
6309 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
6310 no error was reported.
6312 *expression.cs (Binary.DoResolve): left can be null.
6314 2005-11-22 Marek Safar <marek.safar@seznam.cz>
6317 * class.cs (MethodData.Emit): Parameters should be labeled first.
6319 2005-11-21 Marek Safar <marek.safar@seznam.cz>
6322 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
6324 2005-11-18 Marek Safar <marek.safar@seznam.cz>
6326 * attribute.cs (AreParametersCompliant): Moved to Parameter.
6328 * class.cs (MethodCore): Parameter clean up.
6329 (IMethodData): Added ParameterInfo.
6330 (MethodData): Parameter clean up.
6331 (Indexer.Define): Parameter clean up.
6343 * typemanager.cs: Parameter clean up.
6345 * delegate.cs (Define): Get rid of duplicated code.
6347 * expression.cs (ParameterReference): Removed useless parameters
6349 (Invocation): Ditto.
6351 * parameter.cs (ParamsParameter): New class, params specialization.
6352 (ArglistParameter): Attemp to separate arglist.
6353 (Parameter): Refactored to be reusable and faster.
6354 (Parameter.Modifier): Made understandable.
6355 (Parameters): Changed to be used as a class for `this' assembly
6356 parameters. Refactored to use new specialized classes.
6358 * support.cs (ParameterData): Added Types property.
6359 (InternalParameters): Deleted.
6361 2005-08-20 Martin Baulig <martin@ximian.com>
6363 Merging this patch from GMCS to fix #75867.
6365 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
6366 scope if we don't already have it.
6368 2005-11-17 Martin Baulig <martin@ximian.com>
6371 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
6372 inherit the scope from our parent. Fixes #76653.
6374 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6376 * doc.cs : the previous patch does not actually fix the bug.
6377 PropertyInfo override check is now implemented and really fixed it.
6378 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
6380 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6382 * doc.cs : apply "override filter" also to properties.
6385 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6387 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
6388 no need to check overrides. For classes, omit those results from
6389 interfaces since they must exist in the class. Fixed bug #76726.
6391 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6393 * typemanager.cs : (GetFullNameSignature) differentiate indexers
6394 with different parameters. Fixed the second problem in #76685.
6396 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6398 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
6399 get expected 'protected' access in CheckValidFamilyAccess()).
6402 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6404 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
6405 Fixed bug #76705. CS1569 was incorrectly commented out.
6407 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6409 * doc.cs : use Invocation.IsOverride() to do real override check.
6410 * expression.cs : made Invocation.IsOverride() internal.
6412 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6414 * doc.cs : use TypeManager.FindMembers() instead of (possible)
6415 TypeBuilder.FindMembers() and filter overriden base members out.
6418 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6420 * doc.cs : ref/out parameters are represented as '@' (instead of
6421 '&' in type FullName). Fixed bug #76630 (additionally crefs).
6423 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6425 * doc.cs : when there was no '.' in cref to methods in doc comment,
6426 then parameters were missing in the output. Fixed bug #76691.
6428 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6430 * driver.cs : don't output docs when there is an error.
6433 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6436 Now it should detect indexers. Fixed primary concern in bug #76685.
6437 Fixed CS0419 message to not show the identical member signature in
6440 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6442 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
6443 instead of Type.FindMembers() since it does not handle events.
6446 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
6448 * codegen.cs: Fixed typo (speficied -> specified).
6450 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6453 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
6455 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6457 * attribute.cs: Changed error message.
6459 * cs-tokenizer.cs: One more check.
6461 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6463 * statement.cs (Block.Resolve): Ignore empty statement.
6465 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6467 * report.cs: Made error/warning methods more strict to avoid
6470 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
6471 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
6472 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
6473 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
6475 2005-11-08 Marek Safar <marek.safar@seznam.cz>
6477 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
6478 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
6480 * class.cs (TypeContainer.IsComImport): New property.
6481 (Constructor.Define): Create proper ctor for ComImport types.
6483 * expression.cs (New.CheckComImport): Fixed.
6485 2005-11-07 Miguel de Icaza <miguel@novell.com>
6487 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
6488 that a parameter has been captured does not mean that we do not
6489 have to do the rest of the processing. This fixes the second part
6490 of #76592. If there was another anonymous method capturing
6491 values in the past, the Scope would never be set for the second
6492 method that captured the same parameter.
6494 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
6495 properly manipulate the stack. Second part of fix for #76592.
6497 * expression.cs (New): Add support for invoking "new" on
6498 interfaces that have been flagged with the ComImport attribute and
6499 the CoClass. Fixes #76637
6501 * statement.cs (Try.DoEmit): When a variable is captured, do not
6502 try to emit the vi.LocalBuilder variable as it has been captured.
6503 Create a temporary variable and store the results on the
6504 FieldBuilder. Fixes #76642
6506 2005-11-07 Marek Safar <marek.safar@seznam.cz>
6508 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
6510 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
6512 * expression.cs (Binary.DoResolve): Added && optimalization.
6514 * typemanager.cs (AddUserType): Removed useless argument.
6516 2005-11-04 Marek Safar <marek.safar@seznam.cz>
6518 * statement.cs (Block.variables): Uses ListDictionary.
6520 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6523 * class.cs (PartialContainer.EmitType): Customized to emit
6524 security attributes.
6525 (ClassPart.ApplyAttributeBuilder): Transform security attribute
6526 for partial classes.
6528 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6531 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
6532 access has to be fixed.
6534 * typemanager.cs (IsUnmanagedType): Wrong common field type.
6536 2005-11-01 Marek Safar <marek.safar@seznam.cz>
6539 * ecore.cs (NullCast.Reduce): Implemented.
6541 * expression.cs (ArrayCreation.CheckIndices): Correcly check
6544 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
6546 (Foreach.Resolve): Catch null properly.
6548 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6550 * cs-tokenizer.cs: Warning text fix.
6552 * driver.cs: AllWarningNumbers exposed on public interface.
6554 * report.cs (): Reviewed warning numbers.
6555 (IsValidWarning): Use binary search.
6557 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6559 * driver.cs: Implemeted resource visibility.
6560 (Resources): New class for code sharing between /res: and
6563 2005-10-28 Marek Safar <marek.safar@seznam.cz>
6566 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
6569 * convert (Convert.ImplicitReferenceConversion): NullCast holds
6572 * ecore.cs (NullCast): Child is contant only.
6574 * literal.cs (NullLiteral.Reduce): null can be converted to any
6577 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
6579 * driver.cs: Use Encoding.Default as default code page instead
6582 2005-10-27 Raja R Harinath <rharinath@novell.com>
6585 * expression.cs (Invocation.Error_InvalidArguments): Handle
6586 __arglist parameters.
6587 (Invocation.VerifyArgumentsCompat): Likewise.
6588 * support.cs (ReflectionParameters.GetSignatureForError): Print
6589 __arglist parameters.
6590 (InternalParamters.GetSignatureForError): Likewise.
6591 * parameter.cs (Parameters.GetSignatureForError): Likewise.
6593 2005-10-26 Marek Safar <marek.safar@seznam.cz>
6595 * attribute.cs (GetPropertyValue): Made public.
6597 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
6599 Add new property WrapNonExceptionThrows to handle 2.0 assembly
6601 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
6604 * driver.cs: Reflect method name change.
6606 * statement.cs (Try.Resolve): Warn when try has both general
6609 * typemanager.cs: runtime_compatibility_attr_type new predefined
6612 2005-10-26 Raja R Harinath <harinath@gmail.com>
6615 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
6616 treat it as an empty parameter list.
6618 2005-10-26 Raja R Harinath <rharinath@novell.com>
6621 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
6622 ResolveAsTypeStep silent.
6623 * statement.cs (Block.AddConstant): Mark block as used.
6624 (Block.ResolveMeta): Avoid piling on error messages
6625 if a constant initializer resolution fails.
6627 2005-10-25 Raja R Harinath <rharinath@novell.com>
6629 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
6631 (NamespaceEntry.VerifyAllUsing): New.
6632 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
6633 behaviour. Delegates actual resolution of alias to ...
6634 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
6635 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
6637 * driver.cs (Driver.MainDriver): Update.
6639 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
6640 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
6642 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
6644 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
6645 RootNamespace.DefineNamespacesForAll.
6647 2005-10-24 Raja R Harinath <harinath@gmail.com>
6649 * typemanager.cs (assemblies, external_aliases, modules)
6650 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
6651 (ComputeNamespaces, GetRootNamespace): Remove extra staging
6652 overhead. Move resposibility ...
6653 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
6654 * driver.cs, attribute.cs, codegen.cs: Update to changes.
6656 2005-10-23 Raja R Harinath <harinath@gmail.com>
6658 * namespace.cs (RootNamespace.all_namespaces): Renamed from
6659 cached_namespaces. Improve usage.
6660 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
6661 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
6662 Move from GlobalRootNamespace and simplify.
6663 (RootNamespace.Global): Make instance variable.
6664 (RootNamespace.RootNamespace): Add "alias name" parameter.
6665 (GlobalRootNamespace): Simplify drastically.
6666 (Namespace.Lookup): Don't use GetNamespace.
6667 * typemanager.cs (GetRootNamespace): Rename from
6668 ComputeNamespaceForAlias.
6669 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
6671 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6673 * anonymous.cs (AnonymousContainer): Don't crash when container
6676 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6678 * expression.cs (Binary.DoResolve): Warn when comparing same
6681 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6684 * expression.cs (Binary.DoResolve): It looks like there are no
6685 convetsion rules in enum context.
6687 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6689 Add support for extern alias qualifiers.
6690 * typemanager.cs: Move some LookupTypeReflection code
6691 to namespace.cs, to have cleaner code. Added some methods
6692 to help us keep track of the extern aliased references.
6693 * driver.cs: Add suport for extern alias assemblies on command
6694 line and check for their warnings/errors. Also keep track of the
6695 extern aliased assemblies.
6696 * namespace.cs: Move the global functionality of Namespace
6697 to GlobalRootNamespace/RootNamespace. Now the global namespace
6698 is GlobalRootNamespace.Globa. Also the code moved from
6699 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
6700 Finally added LocalAliasEntry (AliasEntry before) and
6701 ExternAliasEntry, to handle alias statements.
6702 * cs-parser.jay: Add support in the grammar for extern alias
6704 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
6705 Update callings to Namespace (now in GlobalRootNamespace).
6707 2005-10-18 Raja R Harinath <rharinath@novell.com>
6710 * class.cs (TypeContainer.DefineType): Move updating of
6711 topological sort earlier in the code.
6712 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
6714 2005-10-18 Marek Safar <marek.safar@seznam.cz>
6717 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
6719 * constant.cs (Constant.TryReduce): Moved from Cast class.
6720 (Reduce): Made little bit more OO and fixed missing conversions.
6722 * ecore.cs (Reduce): Implemented.
6723 (Binary.EnumLiftUp): New method to upgrade values to enum values.
6725 * literal.cs (Reduce): Implemented.
6727 * class.cs: Reverted Miguel's wrong commit.
6729 2005-10-14 Miguel de Icaza <miguel@novell.com>
6731 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
6733 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
6735 * cs-parser.jay, expression.cs : CS0214 was missing error location
6736 for constants. Fixed bug #76404.
6738 2005-10-11 Marek Safar <marek.safar@seznam.cz>
6741 * convert.cs (ExplicitConversionCore): Fixed object->enum
6744 2005-10-10 Raja R Harinath <rharinath@novell.com>
6746 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
6748 (PropertyExpr.EmitCall): Likewise.
6749 * expression.cs (Invocation.EmitArguments): Handle case where
6751 (Invocation.EmitCall): Avoid allocating temporary variable if
6752 there are no arguments.
6754 2005-10-07 Raja R Harinath <rharinath@novell.com>
6757 * convert.cs (ImplicitConversionStandard): Move conversion of
6758 void* to arbitrary pointer types ...
6759 (ExplicitConversionStandard): .. here.
6760 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
6761 error to always print typenames.
6763 2005-10-07 Raja R Harinath <rharinath@novell.com>
6765 * convert.cs (GetConversionOperator): Rename from
6766 GetConversionOperators. Move operator selection code from ...
6767 (UserDefinedConversion): ... here.
6769 2005-10-06 Marek Safar <marek.safar@seznam.cz>
6771 * convert.cs (ExplicitConversionCore): Removed duplicate enum
6774 2005-10-05 Marek Safar <marek.safar@seznam.cz>
6776 * assign.cs (Assign.DoResolve): Error method changed.
6778 * cfold.cs (DoConstantNumericPromotions): Error method changed.
6780 * const.cs (ResolveValue): Reset in_transit immediately.
6782 * constant.cs: Error method changed.
6784 * convert.cs: Removed useless location parameter.
6785 (ExplicitNumericConversion): Don't do double enum check.
6786 (ExplicitConversionCore): Renamed from ExplicitConversion.
6787 (ExplicitUnsafe): Extracted from ExplicitConversion.
6788 (ExplicitConversion): Uses for error reporting.
6790 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
6792 (ResolveBoolean): Uses common error method.
6793 (CastToDecimal): Get rid of ec.
6794 (CastFromDecimal): Optimized.
6795 (ConvCast): Get rid of ec.
6797 * enum.cs (ResolveValue): Reset in_transit immediately.
6798 (Emit): Return after first error.
6800 * expression.cs: Convert changes.
6802 * literal.cs: Error method changed.
6804 * statement.cs: Error method changed.
6806 2005-10-03 Raja R Harinath <rharinath@novell.com>
6808 * support.cs (SeekableStreamReader.Position): Don't error out when
6809 the requested position is just beyond the end of the current
6812 2005-09-28 Raja R Harinath <rharinath@novell.com>
6814 * support.cs (SeekableStreamReader): Simplify drastically. Don't
6815 try to keep in sync with the byte count of the underlying Stream.
6816 However, this limits us to a window size of 2048 characters: i.e.,
6817 the maximum lookahead of our lexer/parser can be 2048 characters.
6819 2005-09-28 Marek Safar <marek.safar@seznam.cz>
6822 * driver.cs: Fix compilation files with full root path.
6824 2005-09-25 Miguel de Icaza <miguel@novell.com>
6826 * report.cs (SymbolRelatedToPreviousError): Format the output so
6827 it does not use an open parenthesis that is never closed.
6829 * driver.cs: Follow coding guidelines
6831 2005-09-27 Marek Safar <marek.safar@seznam.cz>
6834 * const.cs (Const.ResolveValue): Check for assigning non-null
6835 value to reference type.
6837 2005-09-27 Marek Safar <marek.safar@seznam.cz>
6839 * anonymous.cs: Implemented ExprClassName.
6841 * assign.cs (Assign.DoResolve): Don't chrash when type is not
6844 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
6847 * class.cs (StaticClass.DefineContainerMembers): Report protected
6850 * codegen.cs: if(ed) PRODUCTION.
6852 * convert.cs (Error_CannotImplicitConversion): Better error
6855 * cs-parser.jay: More error checks.
6857 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
6859 * driver.cs (CSCParseOption): Enabled wrong option check.
6861 * ecore.cs (Expression.ExprClassName): Turned to property.
6862 (MemberExpr.CheckIntermediateModification): For checking boxed
6863 value types modification.
6865 * statement.cs (Fixed.Resolve): Expression type must be
6866 convertible to fixed type.
6867 (CollectionForeach.GetEnumeratorFilter,TryType):
6868 Small refactoring for easier error checking.
6870 2005-09-26 Marek Safar <marek.safar@seznam.cz>
6872 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
6875 * class.cs (GeneratedBaseInitializer): New class for customization
6876 compiler generated initializers.
6877 (MemberBase.DoDefine): Check Obsolete attribute here.
6878 (FieldMember.DoDefine): Ditto.
6880 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
6883 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
6884 (MemberCore.GetObsoleteAttribute): Removed argument.
6885 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
6886 (MemberCore.CheckObsoleteType): New helper.
6890 * statement.cs: Updates after MemberCore changes.
6892 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
6893 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
6895 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
6896 obsolete attribute for compiler construct.
6897 (As.DoResolve): Cache result.
6899 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
6901 2005-09-26 Raja R Harinath <rharinath@novell.com>
6904 * expression.cs (This.VerifyFixed): In a value type T, the type of
6905 'this' is T&, iow, 'this' is either an out or ref parameter. In a
6906 value type R, 'this' is treated as a value parameter.
6908 2005-09-22 Miguel de Icaza <miguel@novell.com>
6910 * statement.cs (Lock): Use the TemporaryVariable class instead of
6911 manually using local variables as those do not work when variables
6914 * ecore.cs: Moved the TemporaryVariable class from being a nested
6915 class inside Foreach to be a public class that can be employed in
6918 2005-09-19 Marek Safar <marek.safar@seznam.cz>
6920 * cs-parser.jay: interface_accessors replaced by
6921 accessor_declarations.
6923 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
6926 * statement.cs (GotoCase.Resolve): Convert null constant to
6928 (SwitchLabel.ResolveAndReduce): Ditto.
6929 (SwitchLabel.NullStringCase): Custom null stamp.
6930 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
6932 typemanager.cs (CSharpSignature): Don't skip first argument
6935 2005-09-18 Miguel de Icaza <miguel@novell.com>
6937 * driver.cs: Set InEmacs based on the environment variable EMACS.
6939 * location.cs (InEmacs): in this mode, do not report column
6940 location as it confuses Emacs.
6942 2005-09-16 Marek Safar <marek.safar@seznam.cz>
6944 * cfold.cs, constant.cs, convert.cs, ecore.cs,
6945 expression.cs, iterators.cs, literal.cs: Store constants and
6948 * class.cs (MemberBase.ShortName): Pass location.
6950 * cs-parser.jay: Some location fixes.
6952 * ecore.cs (Expression.Location): Made virtual.
6954 2005-09-05 Miguel de Icaza <miguel@novell.com>
6956 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
6957 if the underlying types are the same, otherwise we need to produce
6958 code that will do the proper cast.
6960 This was exposed by Marek's constant rewrite which produced
6961 invalid code for the call site:
6964 void Method (X v) {}
6968 This fixes test-49.cs
6970 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
6972 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
6973 Type/Object should be allowed as well. Fixed bug #75968.
6975 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
6977 * expression.cs : (Binary.DoResolve): when one is enum constant and
6978 another is constant 0, then return enum one *as enum type*.
6981 2005-09-02 Raja R Harinath <rharinath@novell.com>
6983 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
6987 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
6988 flow-branching for LocalVariableReferences in case we were invoked
6989 from a MemberAccess.
6990 * expression.cs (LocalVariableReference.VerifyAssigned): New.
6992 (LocalVariableReference.DoResolveBase): ... this.
6993 (MemberAccess.Resolve): Do the check that was disabled during
6996 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
6999 (PartialContainer.Create): check abstract/sealed/static strictly
7000 but abstract/sealed can exist only at one side. Fixed bug #75883.
7002 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
7005 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
7006 specified, don't default to UnmanagedType.I4.
7008 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
7010 * expression.cs : conditional operator should check possibly
7011 incorrect assign expression. Fixed bug #75946.
7013 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
7015 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
7016 Reverting the change. gmcs is much complex than mcs on this matter.
7018 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
7020 * cs-tokenizer.cs : To read another token ahead of the actual
7021 consumption, use new SavedToken and cache token instead of moving
7022 back the stream with SeekableStreamReader (it seemed problematic).
7024 driver.cs : Thus use StreamReader directly.
7025 * support.cs : Thus removed SeekableStreamReader.
7027 2005-08-30 Raja R Harinath <rharinath@novell.com>
7030 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
7031 (ScopeInfo.EmitScopeType): Use it to construct field names from
7032 names of captured locals.
7035 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
7036 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
7037 Pass 'target_type' to BoxedCast. Don't default to 'object'.
7038 (ExplicitConversion): Remove enum cases already handled by
7039 implicit conversion. Move implicit conversion check to the beginning.
7040 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
7041 * expression.cs (ArrayCreation.EmitDynamicInitializers):
7042 Don't treat System.Enum as a struct.
7044 2005-08-30 Jb Evain <jbevain@gmail.com>
7046 * attribute.cs: handles as expression in parameters.
7048 2005-08-30 Raja R Harinath <rharinath@novell.com>
7051 * class.cs (TypeContainer.VerifyClsName): Don't use a
7052 PartialContainer when verifying CLS compliance.
7053 (AbstractPropertyEventMethod): Set Parent here, ...
7054 (PropertyMethod): ... not here.
7056 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
7058 * attribute.cs : escaped attribute name should not be allowed to be
7059 resolved (e.g. @class as classAttribute). Fixed bug #75930.
7061 2005-08-29 Raja R Harinath <rharinath@novell.com>
7064 * convert.cs (ImplicitStandardConversionExists): Allow zero also
7065 when converting a long constant to unsigned long.
7066 * expression.cs (Invocation.OverloadResolve): Add sanity check to
7067 detect where IsApplicable and VerifyArgumentsCompat disagree.
7069 2005-08-29 Raja R Harinath <rharinath@novell.com>
7070 and Carlos Alberto Cortez <carlos@unixmexico.org>
7073 * class.cs (TypeContainer.CanElideInitializer): New helper.
7074 (TypeContainer.EmitFieldInitializers): Use it to determine if we
7075 can safely emitting the initializer of a field.
7077 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7079 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
7080 allowed inside a switch (without loop). Fixed bug #75433.
7082 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
7084 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
7085 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
7087 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7089 * driver.cs : kinda reverting the default encoding changes (not exact
7090 revert since I noticed that "codepage:reset" might not work fine).
7092 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7094 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
7095 Location. Now getter and setter store location correctly.
7096 (errors/cs0111-12.cs now reports the expected location.)
7098 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7100 * driver.cs : Use default encoding on the environment.
7101 Removed (now that) extra parameter for SeekableStreamReader.
7102 * support.cs : (SeekableStreamReader) third .ctor() argument for
7103 StreamReader is not required (always true). preamble size could
7104 be acquired in simpler and safe way.
7106 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
7108 * cs-parser.jay: report CS0642 at warning level 3
7109 and report CS0642 for an if else statement also
7110 fixes bug #74745. Patch by John Luke (and a bit
7112 Removed extra CS0642 warning check for "while",
7114 * statement.cs: In Block.Resolve(), CS0642 check
7115 is reimplemented to check a sequence of an empty
7116 statement and a block.
7118 Both fix bug #66777.
7120 2005-08-24 Marek Safar <marek.safar@seznam.cz>
7122 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
7123 detection until I fix it.
7125 * cs-tokenizer.cs: Changed error message.
7127 * cs-parser.jay: Fixed 2 error locations.
7129 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
7130 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
7133 * enum.cs (GetSignatureForError): Fixed.
7135 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
7139 * typemanager.cs (RegisterProperty): Removed.
7141 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
7143 2005-08-24 Raja R Harinath <rharinath@novell.com>
7146 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
7147 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
7149 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7151 * expression.cs : tiny fix is required for not warning positive ulong.
7154 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7156 * expression.cs : add CS0652 check for constant and integral
7157 expression. Fixed bug #53974.
7159 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7161 * expression.cs : in DoNumericPromotions(), check if there is implicit
7162 conversion overload for string (to check CS0034). Fixed bug #52492.
7164 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7166 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
7168 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7170 * ecore.cs : report location when it is *not* Null.
7172 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7178 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
7179 correctly. Fixed bug #75721.
7181 2005-08-23 Raja R Harinath <rharinath@novell.com>
7183 * support.cs (SeekableStreamReader.Position): Avoid an expensive
7184 loop that performs 'min (pos, char_count)'.
7187 * expression.cs (Unary.ResolveOperator): Don't discard implicit
7188 converted value in Operator.OnesComplement.
7190 2005-08-22 Ben Maurer <bmaurer@ximian.com>
7192 * anonymous.cs: If the anon method is pulled into a helper class,
7193 it needs to be `internal' not `private'. Fixes runtime behavior on
7196 2005-08-20 Martin Baulig <martin@ximian.com>
7198 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7199 scope if we don't already have it.
7201 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
7202 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
7205 2005-08-17 Marek Safar <marek.safar@seznam.cz>
7208 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
7211 2005-08-16 Marek Safar <marek.safar@seznam.cz>
7213 The big constants rewrite
7214 Fix #75746, #75685 and more
7215 As a side effect saved 1MB for MWF ;-)
7217 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
7218 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
7219 enum based for corlib compilation.
7221 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
7224 * class.cs (FixedField.Define): Use ResolveAsConstant.
7226 * const.cs (IConstant): Interface constants and enums.
7227 (Const.ResolveValue): New method for constant resolvning.
7228 (ExternalConstant): Constants from imported assemblies.
7230 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
7231 conversion; like enums.
7232 (Constant.ToType): Converts this constant to different type.
7233 (Constant.Increment): Adds 1.
7235 * convert.cs (ImplicitConversionRequired): Simplified.
7237 * cs-parser.jay: Create EnumMember directly.
7239 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
7241 * doc.cs (GenerateEnumDocComment): Removed.
7243 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
7244 (ConvertIntLiteral): Removed.
7245 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
7247 * enum.cs (EnumMember): Implement IConstant.
7248 (Enum.IsValidEnumConstant): Removed.
7249 (Enum.GetNextDefaultValue): Removed.
7250 (Enum.FindMembers): Updated.
7251 (Enum.GenerateDocComment): Iterate enum members.
7253 * expression.cs (Cast.TryReduce): Handle enums correctly.
7254 (New.Constantify): Made public.
7255 (MemberAccess.DoResolve): Removed contant specific if(s).
7257 * literal.cs (NullLiteral): Implement new abstract methods.
7259 * statement.cs (GotoCase.Resolve): Use new constant methods.
7260 (SwitchLabel.ResolveAndReduce): Use new constant methods.
7262 * typemanager.cs (LookupEnum): Removed.
7263 (IsEnumType): Fixed to work with corlib.
7264 (RegisterConstant): Removed.
7265 (LookupConstant): Removed.
7266 (GetConstant): Changed to work with IConstant.
7268 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
7270 * location.cs : Fixed overflown (>255) column number.
7272 2005-08-03 Raja R Harinath <rharinath@novell.com>
7274 First cut of the qualified-alias-member feature.
7275 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
7277 * cs-parser.jay (DOUBLE_COLON): New token.
7278 (namespace_or_type_name): Add rule for recognizing
7279 qualified-alias-members.
7280 (primary_expression): Likewise.
7281 (element_access): Allow QualifiedAliasMember as a possible
7282 type-bearing expression.
7283 (local_variable_type, local_variable_pointer_type): Likewise.
7284 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
7285 aliases in the current and enclosing namespace declarations.
7286 (NamespaceEntry.UsingAlias): Add CS0440 warning.
7287 * decl.cs (MemberName.is_double_colon): New.
7288 (MemberName.MemberName): Add new constructor for alias-member.
7289 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
7290 * expression.cs (QualifiedAliasMember): New expression type.
7292 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7294 * location.cs : it borked when no argument was specified.
7296 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7298 * location.cs : tiny ToString() format fix.
7300 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7302 * statement.cs : oops, it was missing.
7304 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7306 A set of fixes for precise line/column location.
7309 "token" field now holds a file/line "delta", a line number offset
7310 from the segment, and a column number. See also:
7311 http://lists.ximian.com/pipermail/mono-devel-list/2004-
7312 December/009508.html
7313 Removed static IsNull. Use instance IsNull property instead.
7315 For some tokens it stores Location. For Identifier it stores
7316 LocatedToken which is a pair of string name and location.
7317 Column numbers are adjusted only at getChar().
7319 Use Location.ToString() for reporting (it now contains column).
7321 Largely modified to use LocatedToken instead of
7322 string (IDENTIFIER), and to acquire Location from some tokens.
7323 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
7324 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
7326 Now MemberName holds Location. DeclSpace.ctor() receives Location
7327 as a parameter. Removed extra parameters to all derived classes.
7328 Replaced Location.IsNull() with instance property.
7329 * assign.cs, expression.cs :
7330 Added .ctor() overload that omits Location.
7332 Added "nameEscaped" flag that indicates the identifier was escaped
7333 in the source file. This fixes bug #57047.
7335 2005-08-02 Marek Safar <marek.safar@seznam.cz>
7337 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
7338 New method, looking for lo-case imported cls type.
7340 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
7343 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
7345 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
7347 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
7349 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
7351 Optimized to save 3.5 MB for SWF compilation.
7353 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7355 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
7356 (PartialContainer.Create): Moved logic AddToContainer.
7357 (PartialContainer.MarkForDuplicationCheck): Shares name.
7359 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
7362 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
7364 (Namespace.GetSignatureForError): New method.
7366 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
7367 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
7369 2005-08-01 Raja R Harinath <rharinath@novell.com>
7372 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
7373 member lookup rather than qualifier_type, since qualifier_type can
7376 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7378 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
7381 2005-07-31 Miguel de Icaza <miguel@novell.com>
7383 * statement.cs: Copy the local exception into the exception
7384 captured local. Fixes 75674
7386 2005-07-31 Raja R Harinath <harinath@gmail.com>
7389 * expression.cs (Invocation.OverloadResolve): Don't report error
7390 CS1501 if error CS1502 has been reported.
7391 (New.DoResolve): Delegate CS1501 reporting to
7392 Invocation.OverloadResolve.
7395 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
7396 invariant-meaning-in-block property in an enclosing block if
7399 2005-07-29 Marek Safar <marek.safar@seznam.cz>
7401 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
7402 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
7403 (Switch.CheckSwitch): Just save 50kb for SWF.
7405 2005-07-27 Martin Baulig <martin@ximian.com>
7407 * anonymous.cs (CaptureContext.AddField): Added
7408 `AnonymousContainer am' argument; compute its toplevel scope if
7409 it's not already computed. Fixes #75649.
7411 2005-07-26 Raja R Harinath <rharinath@novell.com>
7414 * class.cs (Constructor.Emit): Reset block to null if the block
7417 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7419 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
7421 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7423 * class.cs (MethodData.Define): Check whether accessor implementing
7424 interface is public.
7426 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
7428 2005-07-22 Marek Safar <marek.safar@seznam.cz>
7431 * namespace.cs (LookupType): Moved same type check to...
7433 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
7436 2005-07-21 Raja R Harinath <rharinath@novell.com>
7438 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
7439 already found a typebuilder.
7440 * class.cs (MethodCore.IsDuplicateImplementation): Compare
7441 MemberNames, not strings.
7443 * const.cs (Error_ExpressionMustBeConst):
7444 Rename from Error_EpressionMustBeConst.
7445 * const.cs, class.cs, statement.cd: Update.
7447 2005-07-21 Marek Safar <marek.safar@seznam.cz>
7451 * const.cs (Const.LookupConstantValue): Report missing contant expression
7453 (Error_EpressionMustBeConstant): Only one error method.
7455 * class.cs, statement.c: Updated.
7457 2005-07-20 Raja R Harinath <rharinath@novell.com>
7459 * statement.cs (Block.Flags): Add back HasVarargs.
7460 (Block.flags): Make protected.
7461 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
7463 * typemanager.cs (types, typecontainers, user_types): Remove.
7464 (UserTypes, TypeContainers): Likewise.
7465 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
7466 (CleanUp, Reset): Update.
7467 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
7468 (GetNestedType): Use Type.GetNestedType.
7469 (CoreLookupType): Take two arguments, the namespace and the
7470 basename of the type. Update to use the Namespace.Lookup
7472 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
7473 (RealMemberLookup): Use IsNestedChildOf instead of playing with
7474 string concatenation and substring matches.
7475 * class.cs, enum.cs, delegate.cs: Update to changes.
7477 2005-07-20 Marek Safar <marek.safar@seznam.cz>
7479 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
7480 Expression and made virtual.
7482 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
7483 (ImplicitStandardConversionExists): Fixed `byte' typo ?
7485 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
7487 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
7490 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
7493 2005-07-18 Marek Safar <marek.safar@seznam.cz>
7496 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
7497 AssemblyCultureAttribute is not used on executable.
7500 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
7502 2005-07-16 Raja R Harinath <rharinath@novell.com>
7505 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
7506 New. Reports CS0252/CS0253.
7507 Mostly taken from preliminary patch by Duncak Mak.
7508 (Binary.DoResolveOperator): Store results of operator lookup.
7509 Use them to detect if we need to warn about unintended reference
7512 2005-07-15 Raja R Harinath <rharinath@novell.com>
7515 * namespace.cs (Namespace.Lookup): Add back location parameter.
7516 (Namespace.LookupType): Add CS0436 report. Add location parameter.
7517 * delegate.cs, ecore.cs, expression.cs: Update to changes.
7519 * codegen.cs (EmitContext.DeclSpace): Make readonly.
7520 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
7521 (Namespace.LookupType): ... this.
7522 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
7524 * typemanager.cs (LookupTypeReflection): Remove buggy code that
7525 purported to handle pointers.
7526 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
7529 2005-07-15 Marek Safar <marek.safar@seznam.cz>
7531 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
7534 2005-07-15 Raja R Harinath <rharinath@novell.com>
7536 * namespace.cs (Namespace.Lookup): Drop location parameter.
7537 (NamespaceEntry.LookupAlias): Remove. Merge into ...
7538 (NamespaceEntry.Lookup): ... this.
7539 (NamespaceEntry.Error_AmbiguousTypeReference):
7540 Move here from DeclSpace.
7541 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
7543 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
7544 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
7545 Move to NamespaceEntry.
7546 * delegate.cs, expression.cs: Update to changes.
7548 2005-07-14 Marek Safar <marek.safar@seznam.cz>
7550 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
7551 CheckAttributeType and refactored.
7552 (Attribute.ResolvePossibleAttributeType): Changed to reuse
7553 ResolveAsTypeTerminal error handling.
7554 (ResolveAsTypeTerminal): Introduced because of global attributes extra
7556 (GetSignatureForError): Print errors in same way.
7559 * codegen.cs: Reflect attribute GetSignatureForError change.
7562 * expression.cs: Add silent parameter to ResolveAsTypeStep.
7564 * namespace.cs (UsingEntry): Refactored to make fields private.
7567 statement.cs: Error_UnexpectedKind has extra parameter.
7569 2005-07-14 Raja R Harinath <rharinath@novell.com>
7571 * ecore.cs (IAlias): Remove.
7572 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
7573 that implement the interface.
7574 * namespace.cs (Namespace): Likewise.
7575 (Namespace.declspaces): Renamed from 'defined_names'.
7576 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
7577 DeclSpace instead of an IAlias.
7578 * tree.cs (Tree.AddDecl): Update.
7580 2005-07-12 Raja R Harinath <rharinath@novell.com>
7582 * statement.cs (Block.Flags); Remove HasVarargs.
7583 (Block.HasVarargs): Move to ToplevelBlock.
7584 (Block.ThisVariable, Block.AddThisVariable): Likewise.
7585 (Block.Variables): Make protected. Initialize variable hashtable
7587 (Block.AddVariable): Update.
7588 (Block.Resolve): Update to changes.
7589 (ToplevelBlock.HasVarargs): New boolean.
7590 (ToplevelBlock.ThisVariable): Move here from Block.
7591 (ToplevelBlock.AddThisVariable): Likewise.
7592 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
7593 * expression.cs (This.ResolveBase): Update to changes.
7594 (ArglistAccess.DoResolve): Likewise.
7596 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7599 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
7601 * class.cs (TypeContainer.VerifyMembers): Distinguish between
7602 not used and not used & assigned.
7603 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
7605 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7608 * expression.cs (Is.DoResolve): null is never provided type.
7610 2005-07-08 Marek Safar <marek.safar@seznam.cz>
7613 * cs-parser.jay: Less strict event error rule to catch more errors.
7615 2005-07-08 Martin Baulig <martin@ximian.com>
7617 Fix test-iter-10.cs - distinguish whether we `yield' in a property
7618 gettter (allowed) or setter (not allowed).
7620 * class.cs (Accessor): Implement IIteratorContainer.
7621 (Accessor.Yields): New public field.
7622 (PropertyBase.PropertyMethod.Define): Handle iterators on a
7626 (get_accessor_declaration, set_accessor_declaration): Set the
7627 `yields' flag on the accessor, not the property.
7628 (property_declaration): Do the iterators check on a per-accessor
7629 basis and not for the whole property.
7631 2005-07-08 Martin Baulig <martin@ximian.com>
7633 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
7634 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
7636 2005-07-07 Marek Safar <marek.safar@seznam.cz>
7639 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
7640 (ExtractSecurityPermissionSet): Cope with self referencing security
7641 attributes properly.
7643 * driver.cs (SetOutputFile): Made public property OutputFile.
7645 2005-07-07 Raja R Harinath <rharinath@novell.com>
7648 * class.cs (TypeContainer.first_nonstatic_field): Rename from
7649 has_nonstatic_fields. Make into a FieldBase pointer.
7650 (TypeContainer.AddField): Add CS0282 check.
7651 (TypeContainer.EmitType): Update.
7653 2005-07-06 Miguel de Icaza <miguel@novell.com>
7655 * cs-tokenizer.cs (consume_identifier): Do not create strings to
7656 compare if they start with __.
7658 2005-07-06 Raja R Harinath <rharinath@novell.com>
7660 * statement.cs (Switch.SwitchGoverningType): Only look at
7661 UserCasts that don't need implicit standard conversions to one of
7662 the allowed switch types (Fixes test-322.cs).
7663 (LocalInfo.Resolve): Re-enable sanity-test.
7665 2005-07-06 Marek Safar <marek.safar@seznam.cz>
7667 * cs-tokenizer.cs (consume_identifier): Detect double undescores
7669 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
7671 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
7673 2005-07-06 Raja R Harinath <rharinath@novell.com>
7676 * ecore.cs (SimpleName.GetSignatureForError): Add.
7677 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
7678 (MemberAccess.GetSignatureForError): Add.
7680 2005-07-05 Marek Safar <marek.safar@seznam.cz>
7682 The big error and warning messages review.
7712 * typemanager.cs: Updated.
7714 * class.cs: (MethodCore.SetYields): Moved here to share.
7715 (PropertyMethod.Define): Moved iterator setup here.
7717 * iterators.cs: Add orig_method to have full access to parent
7720 2005-07-05 Raja R Harinath <rharinath@novell.com>
7722 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
7723 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
7724 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
7725 variable of struct type.
7726 * expression.cs (Unary.ResolveOperator): Update to change.
7727 (Indirection.VerifyFixed): Likewise.
7728 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
7729 (ParameterReference.VerifyFixed): Value parameters are fixed.
7730 (This.VerifyFixed): Treat 'this' as a value parameter.
7731 * statement.cs (LocalInfo.IsFixed): Remove.
7733 2005-07-01 Martin Baulig <martin@ximian.com>
7735 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
7736 `ec.EmitThis ()' to get the correct scope.
7738 2005-07-01 Martin Baulig <martin@ximian.com>
7740 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
7741 instance is a ParameterReference; fixes #75299.
7743 2005-07-01 Martin Baulig <martin@ximian.com>
7745 Reverted Marek's latest patch (r46725):
7746 - it contains structural changes which are neither mentioned in
7747 the ChangeLog nor explained anywhere; for example the additional
7748 argument of EmitContext's and Iterator's .ctor's and the
7749 TypeContainer.DefineMembers() change.
7750 - structural changes like this should go in in seperate patches
7751 and not be hidden in a huge patch which just seems to affect
7752 warnings and errors.
7753 a big and hard to understand patch.
7754 - it breaks iterators and causes regressions, for instance in
7757 2005-06-30 Raja R Harinath <rharinath@novell.com>
7760 * expression.cs (Indexers.map): Remove.
7761 (Indexers.Append): Filter out inaccessible setters and getters.
7762 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
7765 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
7767 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
7768 (FieldExpr.Emit, PropertyExpr.Emit): Update.
7769 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
7770 * expression.cs (Invocation.EmitCall): Add CS0120 check.
7772 2005-06-30 Marek Safar <marek.safar@seznam.cz>
7775 * class.cs (FieldBase.GetInitializerExpression): One more field
7778 2005-06-28 Miguel de Icaza <miguel@novell.com>
7780 * pending.cs: Do not define a proxy if the base method is virtual,
7781 it will be picked up by the runtime (bug 75270).
7783 2005-06-08 Martin Baulig <martin@ximian.com>
7785 The big Iterators rewrite :-)
7787 * iterators.cs: Rewrite this to use the anonymous methods framework.
7789 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
7790 before the TypeContainers; see 2test-21.cs.
7793 (TypeContainer.DefineType): Don't create a new EmitContext if we
7794 already have one (this only happens if we're an Iterator).
7795 (TypeContainer.Define): Also call Define() on all our iterators.
7796 (Method.CreateEmitContext): Added support for iterators.
7799 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
7800 (AnonymousContainer.CreateMethodHost): Moved here from
7801 AnonymousMethod and made abstract.
7802 (AnonymousContainer.CreateScopeType): New abstract method.
7803 (AnonymousContainer.IsIterator): New public property.
7804 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
7805 get the ScopeTypeBuilder rather than manually defining it here.
7806 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
7809 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
7810 before RootContext.DefineTypes().
7812 * codegen.cs (EmitContext.RemapToProxy): Removed.
7813 (EmitContext.CurrentAnonymousMethod): Changed type from
7814 AnonymousMethod -> AnonymousContainer.
7815 (EmitContext.ResolveTopBlock): Protect from being called twice.
7816 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
7817 (EmitContext.EmitThis): Removed the iterators hacks; use the
7818 anonymous methods framework for that.
7821 (ToplevelBlock.Container): Make this a property, not a field.
7822 (ToplevelBlock.ReParent): New public method; move the
7823 ToplevelBlock into a new container.
7824 (Foreach.TemporaryVariable): Simplify.
7826 2005-06-05 Martin Baulig <martin@ximian.com>
7828 * statement.cs (LocalInfo.CompilerGenerated): New flag.
7829 (Block.AddTemporaryVariable): New public method; creates a new
7830 `LocalInfo' for a temporary variable.
7831 (Block.EmitMeta): Create the LocalBuilders for all the temporary
7833 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
7834 non-iterator variables.
7836 2005-06-05 Martin Baulig <martin@ximian.com>
7838 * statement.cs (Foreach.TemporaryVariable): Create the
7839 LocalBuilder in the Emit phase and not in Resolve since in some
7840 situations, we don't have an ILGenerator during Resolve; see
7841 2test-19.cs for an example.
7843 2005-06-04 Martin Baulig <martin@ximian.com>
7845 **** Merged r45395 from GCS ****
7847 The big Foreach rewrite - Part II.
7849 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
7850 with `PropertyInfo ienumerator_getcurrent'.
7852 * codegen.cs (VariableStorage): Removed.
7855 (Foreach): Derive from Statement, not ExceptionStatement.
7856 (Foreach.CollectionForeach): New nested class. Moved all the code
7857 dealing with collection foreach here.
7858 (Foreach.ForeachHelperMethods): Removed.
7859 (Foreach.TemporaryVariable): Implement IMemoryLocation.
7861 2005-05-23 Martin Baulig <martin@ximian.com>
7863 * statement.cs (Try.DoResolve): Don't create a `finally' if we
7864 don't need to. Fix #75014.
7866 2005-05-20 Martin Baulig <martin@ximian.com>
7868 Merged r44808 from GMCS.
7870 * class.cs (TypeContainer.CircularDepException): Removed.
7871 (TypeContainer.DefineType): Removed the `InTransit' stuff.
7872 (TypeContainer.CheckRecursiveDefinition): Check for circular class
7873 (CS0146) and interface (CS0529) dependencies here.
7875 2005-06-21 Raja R Harinath <rharinath@novell.com>
7877 * expression.cs (Invocation.EmitCall): Fix initialization
7878 'this_call' to reflect current behaviour. Fix indentation.
7880 * convert.cs (FindMostEncompassedType): Add two trivial special
7881 cases (number_of_types == 0 || number_of_types == 1).
7882 (FindMostEncompasingType): Likewise.
7884 2005-06-17 Raja R Harinath <rharinath@novell.com>
7886 Some cleanups preparing for the fix of #75283.
7887 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
7889 (EventExpr.InstanceResolve): Likewise.
7890 (EventExpr.DoResolve): Remove redundant checks.
7892 2005-06-10 Duncan Mak <duncan@novell.com>
7894 * cs-tokenizer.cs (process_directives): New flag for controlling
7895 the processing of preprocessor directives.
7896 (x_token): After seeing a '#', return Token.NONE instead of going
7897 to handle_preprocessing_directive() when not processing
7898 directives. This avoids unnecessary processing during the token peek in
7903 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
7904 the existing error reporting methods instead of Report.Error.
7906 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
7907 after Raja's rewrite.
7909 2005-06-08 Miguel de Icaza <miguel@novell.com>
7911 * class.cs: Small fix.
7913 2005-06-08 Raja R Harinath <rharinath@novell.com>
7916 * class.cs (GetPartialBases): Fix return value check of
7919 2005-06-07 Raja R Harinath <rharinath@novell.com>
7921 Ensure that partial classes are registered in their enclosing
7922 namespace. Initial part of fix of #75160.
7923 * tree.cs (Tree.RecordDecl): Add new namespace argument.
7924 Register declspace with namespace here, not in
7925 DeclSpace.RecordDecl.
7926 * cs-parser.jay: Pass namespace to RecordDecl.
7927 * class.cs (PartialContainer.Create): Likewise.
7928 (ClassPart.DefineType): New sanity-check. Throws an exception if
7930 * decl.cs (Declspace.RecordDecl): Remove.
7931 * namespace.cs (NamespaceEntry.DefineName): Remove.
7933 2005-06-06 Marek Safar <marek.safar@seznam.cz>
7935 * rootcontext.cs: Reset TargetExt as well.
7937 2005-06-03 Raja R Harinath <rharinath@novell.com>
7939 * ecore.cs (Expression.Resolve): Emit CS0654 error when
7942 2005-06-02 Raja R Harinath <rharinath@novell.com>
7944 Fix #75080, cs0119.cs.
7945 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
7947 (Expression.Resolve): ... this. Use it. Remove bogus code
7948 allowing ExprClass.Type and ExprClass.Namespace for
7949 ResolveFlags.VariableOrValue.
7950 (Expression.Resolve) [1-argument variant]: Change default resolve
7951 flags based on language version.
7952 (Expression.Error_UnexpectedKind): Use a simple string array
7953 rather than an ArrayList.
7954 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
7956 (TypeOfVoid.DoResolve): Likewise.
7957 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
7958 flags argument -- it always has the same value.
7960 2005-05-31 Raja R Harinath <rharinath@novell.com>
7963 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
7964 Use it in the error message.
7965 * assign.cs, expression.cs, statement.cs: Update.
7967 2005-05-30 Raja R Harinath <rharinath@novell.com>
7970 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
7971 the "almostMatchedMember" case too.
7972 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
7973 that failed the accessibility checks to 'almost_match'.
7975 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
7977 * attribute.cs: Use internal MethodBuilder methods to set
7978 ExactSpelling and SetLastError on PInvoke methods, instead
7979 of passing them via charset. Fixes #75060.
7981 2005-05-27 Raja R Harinath <rharinath@novell.com>
7983 * parameter.cs (Parameter): Remove TODO comment.
7984 (Parameter.DefineParameter): Remove Location parameter.
7985 (Parameters.LabelParameters): Likewise.
7986 * class.cs (Constructor.Emit): Update to change.
7987 (MethodData.Emit): Likewise.
7988 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
7989 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
7991 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
7994 Removed Parameters.Location and added Parameter.Location instead.
7995 Removed Location parameter from Emit() and GetSignature().
8002 Modified all related calls.
8004 2005-05-26 Raja R Harinath <rharinath@novell.com>
8006 Improve user-defined conversion handling.
8007 * convert.cs (GetConversionOperators): Rewrite. Return only the
8008 applicable operators.
8009 (AddConversionOperators): New. Helper for GetConversionOperators.
8010 (FindMostEncompassedType, FindMostEncompassingType): Verify that
8011 there is only one most encompassed/encompassing type.
8012 (FindMostSpecificSource, FindMostSpecificTarget): Remove
8013 "applicable operator" handling.
8014 (UserConversion): Move cache here from GetConversionOperators.
8015 Directly cache the chosen operator, rather than the whole
8017 (ExplicitNumericConversion): Fix buggy implementation of Decimal
8018 case. Allow conversion of decimal to sbyte and byte too.
8019 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
8020 New static methods. Used to avoid allocating EmptyExpressions in
8023 2005-05-24 Duncan Mak <duncan@novell.com>
8025 * ecore.cs (CastFromDecimal): New class for casting a decimal to
8026 another class, used in Convert.ExplicitNumericConversion.
8027 (CastToDecimal): New class, similar to above, but casts to
8028 System.Decimal, used in Convert.ImplicitNumericConversion and also
8029 in explicit convesion from double/float to decimal.
8031 * convert.cs (ImplicitNumericConversion): Handle implicit
8032 conversions to System.Decimal.
8033 (ExplicitNumericConversion): handle explicit conversions to
8038 2005-05-20 Miguel de Icaza <miguel@novell.com>
8040 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
8041 know the type at this stage, just break through. Fixes #75008
8043 2005-05-19 Martin Baulig <martin@ximian.com>
8046 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
8047 to disable error reporting.
8049 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
8050 here since we don't want to report an error; see the new test-336.cs.
8052 2005-05-19 Raja R Harinath <rharinath@novell.com>
8054 * statement.cs (ToplevelBlock.GetParameterReference)
8055 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
8056 Move here from class Block.
8057 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
8058 * expression.cs (ParameterReference.DoResolveBase): Likewise.
8060 2005-05-18 Martin Baulig <martin@ximian.com>
8065 (FlowBranching.Reachability): Add non-static public And() and Or()
8067 (FlowBranchingSwitch): New class; do the `break_origins' thing
8068 like in FlowBranchingLoop.
8069 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
8070 reachability, not just locals and parameters.
8071 (FlowBranching.MergeChild): Remove some of the hacks for loop and
8072 switch; MergeBreakOrigins() now takes care of that.
8074 2005-05-18 Martin Baulig <martin@ximian.com>
8076 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
8077 a loop and may leave it, reset the barrier; fixes #74974.
8079 2005-05-17 Marek Safar <marek.safar@seznam.cz>
8081 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
8084 * cs-parser.jay: Catch more lexical errors.
8086 * report.cs: Add one more Error method.
8089 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
8091 2005-05-17 Martin Baulig <martin@ximian.com>
8093 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
8096 2005-05-16 Raja R Harinath <rharinath@novell.com>
8098 Fix test-382.cs. Emit values of decimal constants.
8099 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
8101 (TypeContainer.AddField): ... this.
8102 (TypeContainer.EmitFieldInitializers): Allow the list of fields
8103 with initializers to include 'Const's.
8104 (ClassPart.RegisterFieldForInitialization): Forward to
8106 * const.cs (Const.Const): Pass initializer to base class.
8107 (Const.Define): In case of decimal constants, register them for
8108 initialization in a static constructor.
8110 2005-05-14 Martin Baulig <martin@ximian.com>
8112 * statement.cs (Block.Resolve): Correctly handle unreachable code;
8113 do not call ResolveUnreachable() on unreachable statements in
8114 here, see the comment in the source code.
8116 2005-05-13 Raja R Harinath <rharinath@novell.com>
8119 * expression.cs (BinaryResolveOperator): If one of the operands of
8120 an equality comparison is 'null' and the other is a pointer type,
8121 convert the null to a NullPointer.
8122 * convert.cs (ImplicitReferenceConversion): If the expression is a
8123 NullLiteral and the target type is a pointer type, return a
8124 NullPointer instead.
8125 (ImplicitConversionStandard): Likewise.
8127 2005-05-13 Marek Safar <marek.safar@seznam.cz>
8129 * cs-parser.jay: Set readonly context based on special constructs.
8131 * expression.cs (LocalVariableReference.DoResolveBase): Improved
8132 readonly variable error handling.
8134 * rootcontext.cs (EmitCode): Don't verify members when error
8137 * statement.cs (LocalInfo): Add reaodnly context information.
8138 (SetReadOnlyContext, GetReadOnlyContext): New methods.
8140 2005-05-13 Raja R Harinath <rharinath@novell.com>
8142 * statement.cs (Block.Resolve): Revert change below. Modify fix
8143 for #74041 to initialize 'resolved' to false only for explicit
8144 blocks. Fixes #74873.
8146 2005-05-12 Raja R Harinath <harinath@gmail.com>
8149 * typemanager.cs (unmanaged_enclosing_types): New.
8150 (IsUnmanagedType): Avoid infloops by using
8151 'unmanaged_enclosing_types' to talk with recursive invocations.
8153 2005-05-13 Martin Baulig <martin@ximian.com>
8155 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
8156 instance variable, not a local. Fix #74873.
8157 (Block.ResolveUnreachable): Set it to true here.
8159 2005-05-11 Duncan Mak <duncan@novell.com>
8161 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
8162 continuing to process for 'arg'.
8163 (handle_preprocessing_directive): Check the argument of the #endif
8164 directive and report error CS1025 if there are any trailing
8167 According to the C# spec, having even whitespace after the #endif
8168 directive is illegal; however, because we call arg.TrimEnd ()
8169 beforehand, we have the same behavior as csc, allowing whitespace
8170 after the directive.
8174 2005-05-11 Marek Safar <marek.safar@seznam.cz>
8178 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
8179 (Constructor.GetObsoleteAttribute): Implemented correctly.
8181 2005-05-10 Martin Baulig <martin@ximian.com>
8183 * support.cs (ReflectionParameters.ParameterModifier): Use
8184 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
8185 and `ParameterAttributes.In'. Fixes #74884.
8187 2005-05-10 Marek Safar <marek.safar@seznam.cz>
8189 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
8191 * expression.cs (Argument.GetParameterModifier): Turned to property.
8192 (Invocation.Error_InvalidArguments): Add more descriptive errors.
8194 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
8197 2005-05-09 Raja R Harinath <rharinath@novell.com>
8200 * decl.cs (MemberCache.AddMethods): Register override methods,
8201 rather than non-override methods.
8202 * typemanager.cs (RegisterOverride): New.
8203 (IsOverride): Update.
8205 2005-05-09 Marek Safar <marek.safar@seznam.cz>
8209 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
8210 recursive declaration.
8212 * statement.cs (Block.ResolveMeta): Report any error in resolving.
8214 2005-05-06 Marek Safar <marek.safar@seznam.cz>
8216 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
8218 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
8220 2005-05-05 Raja R Harinath <rharinath@novell.com>
8223 * decl.cs (DeclSpace.FamilyAccessible):
8224 Use TypeManager.IsNestedFamilyAccessible.
8226 Fix reopened #64812.
8227 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
8230 2005-05-04 Raja R Harinath <rharinath@novell.com>
8231 Abin Thomas <projectmonokochi@rediffmail.com>
8232 Anoob V E <projectmonokochi@rediffmail.com>
8233 Harilal P R <projectmonokochi@rediffmail.com>
8236 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
8237 allow access to all static members.
8239 2005-05-04 Martin Baulig <martin@ximian.com>
8241 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
8243 2005-05-04 Martin Baulig <martin@ximian.com>
8247 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
8248 section at the end; make things work if `default' is not the last
8251 2005-05-04 Martin Baulig <martin@ximian.com>
8255 * statement.cs (Switch): Replaced the `got_default' field with a
8256 `default_section' one.
8257 (Switch.CheckSwitch): Set `default_section' here.
8258 (Switch.Resolve): If we're a constant switch and the constant is
8259 not found, use the default section.
8261 2005-05-03 Martin Baulig <martin@ximian.com>
8263 * expression.cs (ArrayAccess.EmitGetLength): New public method.
8265 * statement.cs (Foreach.ArrayForeach): New nested class.
8266 (Foreach.TemporaryVariable): New nested class.
8267 (Foreach.EmitArrayForeach): Removed; this is now in the new
8270 2005-05-03 Raja R Harinath <rharinath@novell.com>
8272 * pending.cs (BaseImplements): Move the #74773 fix here. This is
8274 (VerifyPendingMethods): Revert change below.
8276 * typemanager.cs (IsOverride, RegisterNonOverride): New.
8277 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
8278 that used to trigger warning -28. Remove warning -28.
8279 * expression.cs (Invocation.OverloadResolve): Use
8280 TypeManager.IsOverride to distinguish override methods.
8283 * pending.cs (VerifyPendingMethods): If a base type implements the
8284 requested interface, don't bother checking individual methods of
8285 the base type. As a side-effect, this prevents the creation of
8286 unnecessary proxies.
8288 2005-05-02 Martin Baulig <martin@ximian.com>
8292 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
8293 Also `And' the locals if the old vector is null.
8294 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
8295 null; in this case we basically reset all the variables.
8297 2005-05-02 Martin Baulig <martin@ximian.com>
8301 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
8302 Added `FlowBranching branching' argument; always `and' the
8303 variables instead of `or'ing them unless we're an infinite loop.
8305 * statement.cs (While.Resolve): Create a new sibling unless we're
8308 2005-05-02 Martin Baulig <martin@ximian.com>
8312 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
8313 arguments; use it instead of creating a new TopLevelBlock.
8314 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
8315 our ConstructorInitializer.
8318 (TopLevelBlock.TopLevelBranching): New public property.
8319 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
8320 and create our `TopLevelBranching'.
8322 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
8323 anonymous method host, use `block.TopLevelBranching' rather than
8324 creating a new branching.
8326 2005-04-20 Miguel de Icaza <miguel@novell.com>
8328 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
8329 a ScopeInfo, if any of the current children is a child of the new
8330 entry, move those children there.
8332 2005-04-30 Martin Baulig <martin@ximian.com>
8334 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
8335 at the beginning of a SwitchSection. Fix #73335.
8337 2005-04-27 Marek Safar <marek.safar@seznam.cz>
8340 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
8342 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
8343 (FieldExpr.DoResolve): Obsolete members are ignored for field
8346 2005-04-26 Marek Safar <marek.safar@seznam.cz>
8348 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
8349 of arrays detection.
8351 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
8353 (Field.VerifyClsCompliance): Volatile fields are not compliant.
8355 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
8358 2005-04-25 Ben Maurer <bmaurer@ximian.com>
8360 * cs-parser.jay: Use the prefered version of -unsafe in error
8363 2005-04-22 Marek Safar <marek.safar@seznam.cz>
8365 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
8368 2005-04-20 John Luke <john.luke@gmail.com>
8370 * driver.cs: fix typo in error message, --outout to --output
8372 2005-04-20 Marek Safar <marek.safar@seznam.cz>
8374 * codegen.cs (InRefOutArgumentResolving): New field.
8376 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
8377 fields outside contructor.
8379 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
8381 2005-04-19 Miguel de Icaza <miguel@novell.com>
8383 * anonymous.cs (CaptureContext.EmitParameterInstance): The
8384 parameter code was not completed ever, so it was not as up-to-date
8385 as local variables. Must finish it.
8387 The bug fix was to compare the Toplevel of the block, not the
8388 current block. Thanks for Ben for pointing this out.
8390 2005-04-19 Raja R Harinath <rharinath@novell.com>
8392 * decl.cs (AddMethods): Use the declaring type of the problem
8393 method to determine if we want to squash a warning.
8395 2005-04-19 Marek Safar <marek.safar@seznam.cz>
8397 * attribute.cs: Removed debug output.
8399 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
8401 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
8404 2005-04-18 Raja R Harinath <rharinath@novell.com>
8407 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
8408 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
8409 all null comparisons against reference types.
8411 2005-04-18 Marek Safar <marek.safar@seznam.cz>
8414 * class.cs (TypeContainer.CircularDepException) New nested
8416 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
8417 (TypeContainer.DefineType): Removed error, reset InTransit before
8419 (Class.DefineType): Throw exception when is in Transit.
8420 Catch exception and report error.
8421 (Struct.DefineType): Throw exception when is in Transit.
8422 Catch exception and report error.
8423 (Interface.DefineType): Throw exception when is in Transit.
8424 Catch exception and report error.
8426 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
8427 handle nested exception handlers.
8429 * flowanalysis.cs (InTryWithCatch): New method, search for try with
8432 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
8433 InFinally and InCatch storage.
8435 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
8436 (Catch.Resolve): Set and Restore ec.InCatch.
8437 (Try.Resolve): Set and Restore ec.InFinally.
8438 (Try.HasCatch): True when try has catch.
8440 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
8442 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
8443 for the same event member, so exclude such cases from warning 419.
8446 2005-04-16 Miguel de Icaza <miguel@novell.com>
8448 * expression.cs (Binary.ResolveOperator): Apply patch from John
8449 Luke to fix bug 59864: operators &, | and ^ on enumerations
8450 require that the same enum type on both sides.
8452 * driver.cs: Add warnings to old flag usage, this is to assist
8453 people who produce Makefiles and hope that the Makefiles will be
8456 * class.cs (TypeContainer.EmitType): Moved the definition of the
8457 special $PRIVATE$ field from the resolve phase to the Emit phase.
8458 During resolve we do not know if we are a struct with
8459 HasExplicitLayout, we know this only after the attributes for the
8462 Set the FieldOffset to zero on the dummy field that we create for
8463 the class. Fixes 74590.
8465 2005-04-16 Raja R Harinath <rharinath@novell.com>
8468 * ecore.cs (PropertyExpr.resolved): New.
8469 (DoResolve): Use it to handle a case of double resolution here.
8470 Handle a case of identical-name-and-type-name.
8471 * expression.cs (ArrayCreation.CheckIndices): Avoid double
8472 resolution by storing the results of expression resolution back
8473 into the "probes" array.
8475 2005-04-15 Raja R Harinath <rharinath@novell.com>
8477 Fix cs0208-7.cs and cs0208-8.cs.
8478 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
8479 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
8480 error reporting to point out the reason a struct is not unmanaged.
8482 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8484 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
8485 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
8487 2005-04-13 Raja R Harinath <rharinath@novell.com>
8490 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
8491 IdenticalNameAndTypeName here.
8492 (EventExpr.InstanceResolve): Likewise.
8494 2005-04-13 Marek Safar <marek.safar@seznam.cz>
8496 C# 2.0 DefaultCharSetAttribute implementation
8498 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
8499 which allows us to set GlobalNamespace for every resolve.
8500 (Attribute.ResolveArguments): Cut from Resolve.
8501 (Attribute.GetCharSetValue): Returns CharSet named argument.
8502 (Attribute.DefinePInvokeMethod): Gets default charset from
8504 (GlobalAttribute.ResolveAsTypeStep): Override.
8505 (GlobalAttribute.ResolveArguments): Override.
8507 * class.cs (TypeAttr): Is protected.
8509 * codegen.cs (ModuleClass.DefaultCharSet): New member.
8510 (ModuleClass.DefaultCharSetType): New memeber.
8511 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
8513 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
8514 charset from module.
8516 * delegate.cs (TypeAttr): Override.
8517 (Delegate.DefineType): Use this TypeAttr.
8519 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
8520 at very early stage (before types are defined) to resolve model
8521 module attributes. It will probably not work with corlib but it
8524 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
8525 charset from module.
8527 * typemanager.cs (default_charset_type): New type.
8529 2005-04-13 Raja R Harinath <rharinath@novell.com>
8531 * decl.cs (MemberCache.AddMethods): Don't warn if
8532 System.Object.Finalize has buggy MethodAttributes.
8534 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
8537 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8539 * doc.cs : detect ambiguous reference to overloaded members.
8540 Fixed bug #71603. MS 1.1 csc does not detect it.
8542 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8544 * doc.cs : delegates must not be referenced with parameters.
8547 2005-04-12 Miguel de Icaza <miguel@novell.com>
8549 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
8551 2005-04-10 Miguel de Icaza <miguel@novell.com>
8553 * driver.cs (MainDriver): Stop processing if the CLS stage found
8556 (CompilerCallableEntryPoint.InvokeCompiler): Always
8557 reset after execution; Take a TextWriter argument for the
8560 * report.cs: Use the error stream instead of hardcoding stderr.
8562 2005-04-09 Miguel de Icaza <miguel@novell.com>
8564 * class.cs: Reduce code paths to test, too small of an
8565 optimization to make it worth the extra testing. Always perform
8568 2005-04-08 Raja R Harinath <rharinath@novell.com>
8571 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
8572 operators that had errors reported on them.
8574 2005-04-08 Marek Safar <marek.safar@seznam.cz>
8576 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
8578 (Attribute.Resolve): Add named argument type checking.
8580 * class.cs (FixedField.Define): Use IsPrimitiveType
8582 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
8584 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
8585 unsafe parameter types.
8587 * statement.cs (Using.ResolveExpression): Add better error description.
8589 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
8591 2005-04-08 Raja R Harinath <rharinath@novell.com>
8594 * attribute.cs (Attribute.GetAttributeUsage): Resolve
8595 AttributeUsageAttribute in the emitcontext of the attribute class,
8596 not in the emitcontext of the attributable entity it was attached to.
8597 * cs-parser.jay: Use 'current_class', not 'current_container',
8598 when creating a GlobalAttribute.
8600 2005-04-08 Alp Toker <alp@atoker.com>
8602 * pending.cs: The fix to #58413 failed to compile methods implementing
8603 interfaces with/without params modifiers and vice versa, even though
8604 params modifiers aren't part of the signature. Make the modifier check
8605 less strict as in csc.
8607 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
8608 Anoob V E <projectmonokochi@rediffmail.com>
8609 Harilal P R <projectmonokochi@rediffmail.com>
8612 * pending.cs (TypeAndMethods.mods): New. Store the parameter
8613 modifiers of pending methods.
8614 (PendingImplementation.PendingImplementation): Initialize it.
8615 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
8616 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
8617 with ParameterData. Add check for modifiers.
8618 * class.cs (MethodData.Define): Update to changes.
8620 2005-04-07 Raja R Harinath <rharinath@novell.com>
8622 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
8624 2005-04-07 Marek Safar <marek.safar@seznam.cz>
8626 * class.cs (PropertyMethod.Define): Check private accessor in abstract
8629 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
8632 * typemanager.cs: Registered RequiredAttributeAttribute.
8634 2005-04-06 Marek Safar <marek.safar@seznam.cz>
8636 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
8637 Warning CS0169 is back at level 3.
8638 (IMethodData.SetMemberIsUsed): New method.
8640 * decl.cs (IsUsed): New value; moved from FieldBase.Status
8641 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
8643 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
8645 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
8647 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
8650 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
8653 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
8654 to avoid the problems with nested types.
8656 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
8657 Anoob V.E <projectmonokochi@rediffmail.com>
8658 Harilal P.R <projectmonokochi@rediffmail.com>
8659 Raja R Harinath <rharinath@novell.com>
8662 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
8664 * typemanager (GetConstructor): Make public.
8666 2005-04-05 John Luke <john.luke@gmail.com>
8667 Raja R Harinath <rharinath@novell.com>
8670 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
8671 struct too. Return false quicker in a few cases.
8672 (VerifyUnManaged): Use it.
8674 2005-04-05 Raja R Harinath <rharinath@novell.com>
8677 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
8678 not 'unreachable_seen'.
8680 2005-04-04 Marek Safar <marek.safar@seznam.cz>
8682 * attribute.cs (Attribute.GetValue): Removed unused.
8684 * codegen.cs (CodeGen.TrimExt): Removed unused.
8686 * cs-parser.jay (output): Removed unused.
8688 * cs-tokenizer.cs (hex_digits): Removed unused.
8690 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
8692 * expression.cs (Indirection.LoadExprValue): Removed unused.
8693 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
8695 * iterators.cs (Iterator.param_types): Removed unused.
8697 * statement.cs (Goto.block): Removed unused.
8698 (ToplevelBlock.did): Removed unused.
8699 (Switch.ResolveConstantSwitch): Removed unused.
8701 2005-04-01 Ben Maurer <bmaurer@ximian.com>
8703 * rootcontext.cs: Allow mcs to bootstrap with the compilation
8706 2005-04-01 Raja R Harinath <rharinath@novell.com>
8708 Fix #74232 and cs0208-3.cs.
8709 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
8710 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
8711 unmanaged type. Don't use FieldBuilders when 't' is a
8712 TypeBuilder. Use ModFlags and MemberType fields.
8713 * class.cs (MemberBase.member_type): Rename from MemberType.
8714 (MemberBase.MemberType): New property. Determines member_type on
8716 (MemberBase.DoDefine): Don't initialize MemberType here.
8717 (FieldMember.Define): Likewise.
8719 2005-04-01 Marek Safar <marek.safar@seznam.cz>
8722 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
8723 Attributes are emitted there.
8725 2005-04-01 Raja R Harinath <rharinath@novell.com>
8727 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
8728 keyword in 'partial enum' too.
8729 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
8731 Report from Kamil Skalski <nazgul@omega.pl>.
8734 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
8735 have partial containers too.
8737 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
8738 in block' checks to Block.CheckInvariantMeaningInBlock.
8739 * statement.cs (Block.GetKnownVariableInfo): Make private.
8740 (Block.IsVariableUsedInChildBlock): Remove.
8741 (Block.IsVariableUsedInBlock): Likewise.
8742 (Block.CheckInvariantMeaningInBlock): New. Show location of
8743 conflicting declaration.
8744 (Block.AddVariable): Make error messages less long-winded and more
8745 specific. Show location of conflicting declaration.
8746 * parameter.cs (Parameters.Location): New readonly property.
8748 2005-03-31 Raja R Harinath <rharinath@novell.com>
8750 Clean up semantics of invoking ResolveMemberAccess.
8751 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
8752 can have an instance, ensure that we pass in a non-TypeExpression
8753 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
8754 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
8755 argument. Update to changes and simplify.
8756 (FieldExpr.Emitinstance): Remove CS0120 check.
8757 (PropertyExpr.EmitInstance): Likewise.
8758 * expression.cs (Argument.Resolve): Likewise.
8759 (Invocation.DoResolve): Update to changes in semantics of
8762 2005-03-31 Marek Safar <marek.safar@seznam.cz>
8765 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
8768 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
8770 2005-03-31 Raja R Harinath <rharinath@novell.com>
8772 Fix difference in behaviour with commandline invocation.
8773 * driver.cs (Driver.Reset): New.
8774 (CompilerCallableEntryPoint): Call it.
8776 * statement.cs (If.Resolve): Avoid spurious "uninitialized
8777 variable" warnings if the boolean expression failed to resolve.
8779 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
8781 * attribute.cs: Fix the union of several permissions when some of them
8782 are unrestricted (so the result isn't an unrestricted permission set).
8785 2005-03-30 Raja R Harinath <rharinath@novell.com>
8787 * ecore.cs (MemberExpr): New class. Convert from interface
8789 (MemberExpr.ResolveMemberAccess): Refactor and move here from
8790 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
8792 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
8793 (MethodGroupExpr.IsExplicitImpl): Remove.
8794 (Expression.GetFieldFromEvent): Remove.
8795 (SimpleName.MemberStaticCheck): Remove.
8796 (SimpleName.DoSimpleNameResolve): Update to changes.
8797 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
8798 (MemberAccess.IdenticalNameAndTypeName): Remove.
8799 (MemberAccess.error176): Move to MemberExpr.
8800 (MemberAccess.DoResolve): Update to changes.
8801 (BaseAccess.DoResolve): Likewise.
8803 2005-03-30 Marek Safar <marek.safar@seznam.cz>
8805 C# 2.0 Conditional attribute class implementation
8807 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
8808 Analyzes class whether it has attribute which has ConditionalAttribute
8809 and its condition is not defined.
8811 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
8812 (Class.IsExcluded): New method. Search for at least one defined
8813 condition in ConditionalAttribute of attribute class.
8815 2005-03-30 Raja R Harinath <rharinath@novell.com>
8817 * ecore.cs (PropertyExpr): Derive from Expression, not
8818 ExpressionStatement.
8819 (PropertyExpr.EmitStatement): Remove.
8821 2005-03-29 Raja R Harinath <rharinath@novell.com>
8824 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
8825 internal field "value__" of an enum be private. The examples for
8826 "value__" that I found on MSDN all used FieldAttributes.Private.
8828 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
8829 Don't mention IL method attribute names.
8831 Fix #47991. Remove a TODO.
8832 * statement.cs (Block.Toplevel): Make into a field.
8833 (Block.Parameters): Move into ToplevelBlock.
8834 (Block.known_variables): Rename from child_variable_names.
8835 (Block.Block): Remove variants that take Parameters. Initialize
8836 'Toplevel' with the immediately surrounding toplevel block.
8837 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
8838 LocalInfo parameter.
8839 (Block.GetKnownVariableInfo): New.
8840 (Block.IsVariableNameUsedInChildBlock): Update.
8841 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
8842 the block, even though it may not be in scope.
8843 (Block.AddVariable): Remove Parameters parameter. Use
8844 Toplevel.Parameters instead.
8845 (Block.AddConstant): Remove Parameters parameter.
8846 (Block.GetParameterReference): Update to use Toplevel.Parameters.
8847 (Block.IsParamaterReference): Likewise.
8848 (Block.IsLocalParameter): Likewise. Simplify a lot.
8849 (ToplevelBlock.Parameters): New. Moved from Block.
8850 (ToplevelBlock.ToplevelBlock): Update to changes. Always
8851 initialize Parameters to a non-null value.
8852 * cs-parser.jay: Update to changes.
8853 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
8854 simple names that mean different things in the same block. Use
8855 Block.IsVariableNameUsedInBlock.
8857 2005-03-28 Raja R Harinath <rharinath@novell.com>
8859 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
8860 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
8861 GetTypeHandle. It is possible for a reflected type to derive from
8862 a TypeBuilder (e.g., int[] derives from the TypeBuilder
8863 System.Array during mscorlib compilation).
8864 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
8865 contain a method_hash, don't create one either. Don't create a
8866 deep copy of the base cache's method_hash.
8867 (MemberCache.SetupCache): Rename back from DeepCopy.
8868 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
8869 already initialized. If we see an override function, add its
8870 underlying base virtual function to the member_hash too.
8872 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
8874 2005-03-26 Raja R Harinath <harinath@acm.org>
8877 * assign.cs (Assign.DoResolve): When the RHS of an assignment
8878 fails to resolve, ensure that the LHS is still resolved as an
8881 2005-03-25 Raja R Harinath <harinath@acm.org>
8883 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
8885 (Enum.current_ec): Remove.
8886 (Enum.LookupEnumValue): Remove EmitContext argument.
8887 Just uses the one created during DefineType.
8888 (Enum.FindMembers): Update.
8889 * expression.cs (MemberAccess.DoResolve): Update.
8891 2005-03-22 Marek Safar <marek.safar@seznam.cz>
8893 * assign.cs (Assign.DoResolve): Check for CS1717 when
8894 source and target are same (uses Equals).
8896 * expression.cs (LocalVariableReference, ParameterReference,
8897 This): Implemented Equals, GetHashCode.
8899 * statement.cs (Block.GetParameterReference): Removed useless
8902 2005-03-22 Raja R Harinath <rharinath@novell.com>
8905 * statement.cs (Block.AddVariable): Ensure that we skip implicit
8906 blocks before deciding whether the error is cs0136 or cs0128.
8908 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
8909 (using_alias_directive, using_namespace_directive): Pass
8910 MemberName, not an expression to Namespace.UsingAlias and
8912 (MakeName): Use the MemberName of the namespace.
8913 * namespace.cs (Namespace.MemberName): New.
8914 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
8915 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
8917 * decl.cs (MemberName.Name): Make readonly.
8918 (MemberName.FromDotted): New "constructor".
8919 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
8920 (MemberCore.Name): Compute from MemberName on demand.
8921 (MemberCore.SetMemberName): Provide a way to change the
8923 (MemberCore.AddToContainer): Don't take a fullname parameter.
8924 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
8925 fully qualified name of the container to the member name.
8926 (TypeContainer.AddToTypeContainer): Use a fully qualified name
8927 only if the type is a member of the root container.
8928 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
8929 MemberName.Left rather than searching for an embedded ".".
8930 (PartialContainer.CreatePart): Update to changes in RootContext.
8931 (MemberBase.ShortName): Turn into a property. Use
8932 MemberCore.SetMemberName.
8933 (MemberBase.ExplicitInterfaceName): Remove.
8934 (MemberBase.UpdateMemberName): Remove.
8935 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
8936 (PropertyBase.SetMemberName): New override.
8937 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
8938 (Tree.GetDecl): New.
8939 (Tree.AllDecls): Rename from Decls.
8940 * attribute.cs, enum.cs, report.cs: Update to changes.
8941 * driver.cs (MainDriver): Use MemberName.FromDotted on
8942 RootContext.MainClass.
8944 2005-03-21 Marek Safar <marek.safar@seznam.cz>
8946 * class.cs (FixedField.Define): Check for CS1664 and more sanity
8949 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
8951 2005-03-18 Marek Safar <marek.safar@seznam.cz>
8953 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
8954 property accessor modifiers.
8956 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
8957 fixed buffer attribute (CS1716).
8958 (PropertyMethod.HasCustomAccessModifier): When property accessor
8959 has custom modifier.
8961 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
8963 (PropertyExpr.DoResolveLValue): Add CS0272.
8965 2005-03-17 Miguel de Icaza <miguel@novell.com>
8967 * convert.cs: When converting to a pointer, use the proper Conv.U
8968 or Conv.I depending on the source data type.
8970 * cs-tokenizer.cs: Make the size for large decimal constants,
8973 2005-03-17 Martin Baulig <martin@ximian.com>
8975 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
8976 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
8978 2005-03-17 Martin Baulig <martin@ximian.com>
8980 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
8981 to bool so we can return an error condition.
8982 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
8985 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
8987 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
8990 2005-03-16 Raja R Harinath <rharinath@novell.com>
8992 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
8993 Refactor to avoid traversing the list of assemblies, and to avoid
8994 string concatenation.
8995 * typemanager.cs (guid_attr_type): Remove.
8996 (negative_hits, pointers, references): Remove hashes.
8998 (GetConstructedType): New. Uses type_hash to handle constructed
8999 types (arrays, references, pointers).
9000 (GetReferenceType, GetPointerType): Use it.
9001 (GetNestedType): New. Uses type_hash to handle nested types of
9003 (LookupType, LookupTypeDirect): Remove.
9004 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
9005 'types' hash and LookupTypeReflection directly.
9006 (params_string, params_object): Use GetConstructedType.
9007 * namespace.cs (Namespace.cached_types): New. Cache of reflected
9009 (Namespace.Lookup): Use cached_types.
9010 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
9011 provided by old TypeManager.LookupType.
9012 * rootcontext.cs (MakeFQN): Remove.
9013 * decl.cs (DeclSpace.MakeFQN): Likewise.
9014 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
9015 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
9016 TypeManager.GetConstructedType.
9017 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
9019 2005-03-15 Marek Safar <marek.safar@seznam.cz>
9021 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
9024 * cs-parser.jay: Reports CS1527 for any namespace element.
9026 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
9029 * expression.cs (ParameterReference.IsAssigned): Changed error to
9031 (Error_WrongNumArguments): Moved CS0245 detection here.
9033 * statement.cs (Return.Resolve): Add CS1622 report.
9035 2005-03-11 Marek Safar <marek.safar@seznam.cz>
9037 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
9039 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
9041 * attribute.cs expression.cs: Get rid of some allocations.
9043 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
9045 * doc.cs : just eliminate the latest change.
9047 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
9049 * doc.cs : commented out the latest change. It breaks xml-030.cs
9051 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
9053 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
9054 fail. So invoke CreateType() in FindDocumentedType().
9056 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
9058 * cs-tokenizer.cs : added IsKeyword().
9059 * doc.cs : Detect keyword incorrectly used as identifier.
9060 Allow identifiers prefixed by @.
9062 2005-03-10 Marek Safar <marek.safar@seznam.cz>
9064 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
9065 It caused exception in namespace resolving (again!).
9067 * class.cs (Class.ctor): Removed exit.
9068 (PropertyMethod.ctor): ditto.
9070 * codegen.cs (Codegen.Reset): Reset static data.
9071 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
9073 * cs-tokenizer.cs (Cleanup): Removed.
9075 * driver.cs (GetSystemDir): Rewrote to one line command.
9076 It caused problem with unloaded dynamic modules.
9077 (UnixParseOption): Removed Exit.
9078 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
9079 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
9080 Now can be mcs used as library.
9082 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
9085 * location.cs (Reset): Reset static data.
9087 * namespace.cs (Reset): Reset static data.
9089 * report.cs (Report.Reset): Reset static data.
9091 * rootcontext.cs (RootContext.Reset): Reset static data.
9093 * tree.cs (RootTypes.ctor): Use Location.Null
9095 * typemanager.cs (TypeManager.Reset): Reset static data.
9096 (CoreLookupType): Removed Exit.
9097 (TypeHandle.Reset): Reset static data.
9099 2005-03-10 Raja R Harinath <rharinath@novell.com>
9102 * typemanager.cs (ComputeNamespaces): Import namespaces from
9103 referenced modules too.
9105 2005-03-09 Raja R Harinath <rharinath@novell.com>
9107 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
9110 2005-03-09 Raja R Harinath <rharinath@novell.com>
9112 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
9113 enclosing DeclSpace. This ensures that a name-lookup populates
9114 more caches and there are fewer 'TypeExpression's. Carve out
9115 nested type lookup into ...
9116 (LookupNestedTypeInHierarchy): ... this.
9118 2005-03-09 Raja R Harinath <rharinath@novell.com>
9120 Clean up a few partial-class semantics.
9121 Fixes test-357.cs and cs1618-2.cs.
9122 * cs-parser.jay (struct_declaration): Use 'current_class' as
9123 parent of newly-created struct. Remove call to Register ().
9124 Use 'pop_current_class' to complete handing the current struct.
9125 (interface_declaration): Likewise.
9126 (class_declaration): Likewise.
9127 (enum_declaration): Use 'current_class' as parent of newly created
9129 (delegate_declaration): Likewise.
9130 (pop_current_class): New function. This is used to handle closing
9131 up the 'current_class' and 'current_container', and pointing them
9132 to the enclosing class/container.
9133 (CSharpParser): Initialize 'current_class' too.
9134 * decl.cs (MemberCore): Add check for invariant: a partial
9135 container is not a parsed entity, and thus does not enclose any
9137 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
9138 (DeclSpace.BaseTypeExpr): Use it.
9139 (DeclSpace.LookupType): Add check for invariant.
9140 * class.cs (TypeContainer): Add check for invariant: a nested
9141 class should have the same NamespaceEntry as its enclosing class.
9142 (TypeContainer.EmitFieldInitializers): Make virtual.
9143 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
9145 (TypeContainer.Register): Remove.
9146 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
9147 null. Use TypeResolveEmitContext for resolving base types and
9148 interfaces. Move initialization of Parts.TypeBuilder here from
9150 (TypeContainer.DefineNestedTypes): ... here.
9151 (PartialContainer): Take a Namespace not a NamespaceEntry.
9152 (PartialContainer.Create): Don't use Register. Call the
9153 appropriate Add... function directly.
9154 (ClassPart): Take both the PartialContainer and the enclosing
9155 class as constructor arguments.
9156 (ClassPart.EmitFieldInitializers): Override.
9157 (ClassPart.PartFindNestedTypes): Remove.
9158 (FieldBase.GetInitializerExpression): Resolve the initializer
9159 expression in the emit context of the enclosing class.
9160 * tree.cs (RootTypes): Remove Register ().
9162 2005-03-08 Marek Safar <marek.safar@seznam.cz>
9164 * cs-parser.jay: Removed CS0134.
9166 * driver.cs: Removed CS1901.
9168 * expression.cs (SizeOf.DoResolve): Don't report CS0233
9169 for predefined types.
9171 2005-03-07 Duncan Mak <duncan@novell.com>
9173 * codegen.cs (Save): Catch UnauthorizedAccessException as
9174 well. Fixes bug #73454.
9176 2005-03-07 Marek Safar <marek.safar@seznam.cz>
9178 * cs-tokenizer.cs (xtoken): Add CS1035.
9180 * class.cs (MethodData.Define): Add CS0683.
9181 (FieldMember.ctor): Add CS0681.
9183 2005-03-07 Raja R Harinath <rharinath@novell.com>
9185 * ecore.cs (SimpleName.DoResolve): Rename from
9186 SimpleName.DoResolveAllowStatic.
9187 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
9188 Pass 'intermediate' flag to MemberStaticCheck.
9189 (SimpleName.MemberStaticCheck): Skip "static check" only in case
9190 of "intermediate" lookups via MemberAccess.
9191 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
9192 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
9194 2005-03-07 Raja R Harinath <rharinath@novell.com>
9197 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
9198 slipped in because of variable names that are identical to a
9199 builtin type's BCL equivalent ('string String;', 'int Int32;').
9200 (PropertyExpr.EmitInstance): Likewise.
9202 2005-03-04 Marek Safar <marek.safar@seznam.cz>
9204 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
9206 * report.cs (warning_ignore_table): Made public.
9208 2005-03-04 Raja R Harinath <rharinath@novell.com>
9211 * class.cs (MethodData.Emit): Pass 'container' to
9212 container.GetObsoleteAttribute instead of 'container.Parent'.
9214 2005-03-03 Marek Safar <marek.safar@seznam.cz>
9216 * cs-parser.jay: Add 1534 error test.
9218 * iterators.cs (Yield.CheckContext): Add error 1629.
9219 (Iterator.ctor): Save unsafe modifier.
9220 (MoveNextMethod.DoEmit): Restore unsafe context.
9222 * namespace.cs (UsingAlias): Better error message.
9224 2005-03-03 Dan Winship <danw@novell.com>
9226 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
9227 the warning message [#73219]
9229 2005-03-03 Raja R Harinath <rharinath@novell.com>
9231 Fix compile with MCS 1.0.0.0.
9232 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
9233 w_restore to not depend on string constant folding.
9235 2005-03-03 Raja R Harinath <rharinath@novell.com>
9237 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
9238 CS0246 check to users who passed 'silent = false'.
9239 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
9241 (SimpleName.SimpleNameResolve): Update.
9242 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
9243 (MemberAccess.IdenticalNameAndTypeName): Update.
9244 * doc.cs (FindDocumentedTypeNonArray): Update.
9246 2005-03-03 Raja R Harinath <rharinath@novell.com>
9248 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
9249 * parameters.cs (ComputeAndDefineParameters): Remove.
9250 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
9251 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
9252 Use GetParameterInfo.
9254 2005-03-02 Marek Safar <marek.safar@seznam.cz>
9256 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
9258 2005-03-02 Raja R Harinath <rharinath@novell.com>
9260 Unify DeclSpace.LookupType and DeclSpace.FindType.
9261 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
9262 is in charge of defining nested types on demand.
9263 (DeclSpace.LookupType): Use it when the current_type is a
9264 TypeBuilder. Use LookupTypeDirect for reflected types.
9265 (DeclSpace.FindType): Remove.
9266 (DeclSpace.LookupInterfaceOrClass): Likewise.
9267 (DeclSpace.DefineTypeAndParents): Likewise.
9268 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
9269 DeclSpace.LookupType.
9270 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
9271 * typemanager.cs (LookupType): Simplify.
9272 (AddUserType): Remove type from negative_hits.
9273 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
9274 * class.cs (TypeContainer.FindMembers): Move handling of nested
9276 (TypeContainer.FindMembers_NestedTypes): ... here.
9277 (TypeContainer.FindNestedType): Implement override.
9278 (ClassPart.FindNestedType): Delegate to PartialContainer.
9279 (ClassPart.PartFindNestedType): Looks up the nested types of the
9282 2005-03-02 Martin Baulig <martin@ximian.com>
9284 * class.cs (TypeContainer.DoDefineMembers): We also need a default
9285 static constructor in static classes.
9287 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
9289 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
9290 sizeParamIndex is not specified.
9292 2005-03-01 Marek Safar <marek.safar@seznam.cz>
9295 * report.cs (WarningMessage.IsEnabled): Missing null check.
9297 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9299 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
9300 in the fields and not in the properties.
9302 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
9304 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
9307 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9309 * attribute.cs: Small refactoring (improved robustness).
9310 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
9311 (ValidateGuid): Removed.
9312 (Resolve): Removed referenced to above mentioned.
9313 (GetAttributeUsage): Made private and changed to work without
9315 (GetIndexerAttributeValue): Don't crash.
9316 (GetConditionalAttributeValue): Ditto.
9317 (GetClsCompliantAttributeValue): Ditto.
9318 (ExtractSecurityPermissionSet): All attributes exceptions are
9320 (GetPropertyValue): New helper.
9321 (GetMethodImplOptions): New method.
9322 (DefinePInvokeMethod): Reuse common code. Implemented handling of
9323 some missing properties.
9325 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
9326 (Method.ApplyAttributeBuilder): Updated.
9328 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
9331 2005-02-28 Raja R Harinath <rharinath@novell.com>
9334 * report.cs (Report.SymbolRelatedToPreviousError): Handle
9335 non-simple types (array, pointer, reference).
9337 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9339 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
9341 * class.cs (MethodCore.IsDuplicateImplementation): Special error
9343 (Method.CheckBase): Catch wrong destructor here.
9344 (MethodData.Define): Add errors 550, 668.
9346 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
9348 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
9350 * pending.cs (VerifyPendingMethods): Add error 551.
9352 * typemanager.cs (CSharpName): Next error report helper.
9354 2005-02-25 Marek Safar <marek.safar@seznam.cz>
9356 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
9357 attributes. Removed useless attribute double check.
9358 It saves almost 2MBs for corlib.
9360 2005-02-25 Raja R Harinath <rharinath@novell.com>
9363 * statement.cs (ExpressionStatement.Resolve): Make robust to being
9364 called twice in case of error.
9366 2005-02-23 Chris Toshok <toshok@ximian.com>
9368 Fix compiler portions of #72827.
9369 * statement.cs (Block.Emit): call Begin/EndScope on the
9370 EmitContext instead of the ILGenerator.
9372 * codegen.cs (EmitContext.BeginScope): new method, call
9373 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
9375 (EmitContext.BeginScope): same, but EndScope and CloseScope
9377 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
9378 offset and call the superclass's OpenScope(int) with it.
9379 (SymbolWriter.CloseScope): get the current il
9380 offset and call superclass's CloseScope(int) with it.
9382 2005-02-23 Marek Safar <marek.safar@seznam.cz>
9384 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
9385 CS1677 for out and ref as well.
9387 * class.cs (Method.Define): Add error CS1599 detection.
9389 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
9391 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
9393 * delegate.cs (Delegate.Define): Add error CS1599 detection.
9395 * support.cs.cs (ModifierDesc): New helper method.
9397 2005-02-23 Raja R Harinath <rharinath@novell.com>
9398 Abin Thomas <projectmonokochi@rediffmail.com>
9399 Anoob V E <projectmonokochi@rediffmail.com>
9400 Harilal P R <projectmonokochi@rediffmail.com>
9403 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
9404 MemberLookup (used for error reporting) actually returns a result.
9405 Fix error report number (122, not 112).
9407 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
9408 Anoob V E <projectmonokochi@rediffmail.com>
9409 Harilal P R <projectmonokochi@rediffmail.com>
9412 * pending.cs (PendingImplementation.GetAbstractMethods):
9413 Find NonPublic members too.
9415 2005-02-22 Marek Safar <marek.safar@seznam.cz>
9417 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
9420 * class.cs (MethodCore.CheckMethodAgainstBase):
9421 Add error 239 report.
9423 2005-02-21 Raja R Harinath <rharinath@novell.com>
9426 * expression.cs (Invocation.IsApplicable): Make public.
9427 (Invocation.IsParamsMethodApplicable): Likewise.
9428 * delegate.cs (Delegate.VerifyApplicability): Don't use
9429 Invocation.VerifyArgumentCompat for parameter applicability
9430 testing. Use Invocation.IsApplicable and
9431 Invocation.IsParamsMethodApplicable.
9433 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9435 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
9437 * class.cs (Operator.Define): Add error 217 report.
9439 2005-02-21 Raja R Harinath <rharinath@novell.com>
9441 * namespace.cs (UsingEntry.Resolve): Undo change below.
9443 2005-02-21 Raja R Harinath <rharinath@novell.com>
9446 * ecore.cs (Expression.MemberLookupFailed): Add argument to
9447 disable the error message when the extended MemberLookup also
9449 (Expression.MemberLookupFinal): Update.
9450 (SimpleName.DoSimpleNameResolve): Update.
9451 * expression.cs (MemberAccess.ResolveNamespaceOrType):
9452 Don't use MemberLookupFinal.
9453 (New.DoResolve): Update.
9454 (BaseAccess.CommonResolve): Update.
9456 2005-02-21 Raja R Harinath <rharinath@novell.com>
9459 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
9460 occured previously, don't resolve again.
9462 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9465 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
9466 argument. Call ResolveAttributeUsage for unresolved.
9467 when types doesn't match ctor arguments.
9469 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
9470 for nested attribute classes.
9471 (Class.attribute_usage): Removed.
9472 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
9473 for attribute class.
9475 * ecore.cs (IsAttribute): Removed.
9477 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
9479 * rootcontext.cs (RegisterAttribute): Removed, attributes are
9481 (attribute_types): Removed.
9482 (EmitCode): Global attributes are emited as the latest.
9484 2005-02-18 Marek Safar <marek.safar@seznam.cz>
9486 * class.cs (EmitFieldInitializers): Don't emit field initializer
9487 for default values when optimilization is on.
9489 * constant.cs (Constant.IsDefaultValue): New property.
9491 * driver.cs: Add /optimize handling.
9495 * literal.cs: Implement new IsDefaultValue property.
9497 * rootcontext.cs (Optimize): New field, holds /optimize option.
9499 2005-02-18 Raja R Harinath <rharinath@novell.com>
9501 Fix crasher in re-opened #72347.
9502 * namespace.cs (Namespace.Lookup): Return null if
9503 DeclSpace.DefineType returns null.
9506 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
9508 2005-02-18 Raja R Harinath <rharinath@novell.com>
9510 Fix remainder of #63202. Change semantics of DoResolveLValue: it
9511 now returns null if it cannot resolve to an lvalue.
9512 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
9513 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
9514 returned null. Remove check for SimpleName.
9515 (EventExpr.DoResolveLValue): New.
9516 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
9517 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
9519 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
9521 (Unary.ResolveOperator): Move CS0211 check ...
9522 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
9524 (Unary.DoResolveLValue): Simplify.
9525 (AddressOf.DoResolveLValue): New.
9526 (ArrayAccess.DoResolveLValue): New.
9528 2005-02-16 Marek Safar <marek.safar@seznam.cz>
9530 * attribute.cs (Attribute.Resolve): Add arguments casting for
9531 when types doesn't match ctor arguments.
9533 2005-02-16 Raja R Harinath <rharinath@novell.com>
9535 Fix parts of #63202.
9536 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
9537 lookup of operator in base type. Ensure that all checks happen
9538 when the operator resolves to an "op_..." method.
9540 2005-02-15 Raja R Harinath <rharinath@novell.com>
9543 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
9544 'ignore_cs0104' parameter. Pass it to ...
9545 (NamespaceEntry.Lookup): ... this.
9546 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
9547 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
9548 (TypeLookupExpression.DoResolveAsTypeStep): Update.
9549 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
9550 Update. Request that cs0104 errors be ignored.
9551 (ComposedCast.ResolveAsTypeStep): Update.
9553 2005-02-14 Raja R Harinath <rharinath@novell.com>
9556 * expression.cs (Invocation.BetterFunction): Remove support for
9557 comparing virtual functions and their overrides.
9558 (Invocation.IsOverride): New.
9559 (Invocation.OverloadResolve): Don't consider 'override' functions
9560 during candidate selection. Store them in a lookaside list.
9561 If the selected method is a 'virtual' function, use the list to
9562 find any overrides that are closer to the LHS type.
9564 2005-02-14 Marek Safar <marek.safar@seznam.cz>
9566 * expression.cs (New.DoResolve): Add complex core type reduction.
9567 (New.Constantify): Converts complex core type syntax like 'new int ()'
9570 2005-02-14 Raja R Harinath <rharinath@novell.com>
9572 * decl.cs (EntryType.EntryType): New constructor to create an
9573 updated copy of a cache entry.
9574 (MemberCache.AddMethods): Use it.
9575 (MemberCache.ClearDeclaredOnly): Remove.
9576 (MemberCache.MemberCache): Update.
9578 2005-02-11 Miguel de Icaza <miguel@novell.com>
9580 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
9581 variable. This one is represents the actual low-level declaration
9582 of the method, as opposed to the semantic level `IsStatic'.
9584 An anonymous method which is hosted into a static method might be
9585 actually an instance method. IsStatic would reflect the
9586 container, while MethodIsStatic represents the actual code
9589 * expression.cs (ParameterReference): Use the new MethodIsStatic
9590 instead of IsStatic.
9592 * anonymous.cs (AnonymousMethod.Compatible): Pass the
9593 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
9594 set on the current EmitContext.
9596 * expression.cs (Cast): Overload DoResolveLValue so we can pass
9597 resolve our casted expression as an LValue. This triggers the
9598 proper LValue processing that is later required by Assign.
9602 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
9604 2005-02-11 Marek Safar <marek.safar@seznam.cz>
9606 C# 2.0 Fixed buffer implementation
9608 * anonymous.cs: Update after RegisterHelperClass renaming.
9610 * attribute.cs (AttributeTester.fixed_buffer_cache):
9611 Cache of external fixed buffers.
9612 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
9613 implementation if field is fixed buffer else null.
9616 (TypeContainer.AddField): Accept FieldMember instead of Field.
9617 (FieldBase.IsFieldClsCompliant): Extracted code from
9618 VerifyClsCompliance descendant customization.
9619 (FixedField): New class handles fixed buffer fields.
9620 (FixedFieldExternal): Keeps information about imported fixed
9622 (IFixedField): Make access to internal or external fixed buffer
9625 * cs-parser.jay: Add fixed buffer parsing.
9627 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
9630 * expression.cs (Indirection): Extended implementation to accept
9632 (PointerArithmetic.Emit): Get element from fixed buffer as well.
9633 (ElementAccess.MakePointerAccess): Get type as parameter.
9634 (DoResolve): Add fixed buffer field expression conversion.
9635 (DoResolveLValue): Ditto.
9636 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
9637 (ArrayPtr): Derives from FixedBufferPtr.
9638 (ArrayPtr.Emit): Add extra emit for array elements.
9640 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
9642 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
9643 for compiler generated types.
9644 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
9646 * statement.cs (Fixed): Refactored to be easier add fixed buffer
9647 and consume less memory.
9648 (Fixed.Resolve): Add fixed buffer case.
9650 * typemanager.cs (compiler_generated_attr_ctor,
9651 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
9652 (HasElementType): Add our own implementation to work on every
9655 2005-02-11 Miguel de Icaza <miguel@novell.com>
9657 * anonymous.cs (CaptureContext): Track whether `this' has been
9660 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
9661 only captured `this' if it was implicitly done (instance
9662 methods/variables were used).
9664 * codegen.cs (EmitContext.CaptureThis): New method to flag that
9665 `this' must be captured.
9667 2005-01-30 Miguel de Icaza <miguel@novell.com>
9669 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
9670 is null it means that there has been no need to capture anything,
9671 so we just create a sibling.
9673 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
9675 Just a partial fix. The other half is fairly elusive.
9677 2005-02-10 Raja R Harinath <rharinath@novell.com>
9679 Fix #52586, cs0121-4.cs.
9680 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
9681 and return a hashtable.
9682 (MemberCache.ClearDeclaredOnly): New.
9683 (MemberCache.MemberCache): Update to change. Make a deep copy of
9684 the method_hash of a base type too.
9685 (MemberCache.AddMethods): Adapt to having a deep copy of the base
9686 type methods. Overwrite entries with the same MethodHandle so
9687 that the ReflectedType is correct. The process leaves in base
9688 virtual functions and their overrides as distinct entries.
9689 (CacheEntry): Now a class instead of a struct. It shouldn't alter
9690 matters since it was boxed in a ArrayList before.
9691 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
9693 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
9694 case of a virtual function and its override (choose the overload
9696 (Invocation.OverloadResolve): Avoid 'override' members during
9697 'applicable_type' calculation.
9699 2005-02-09 Raja R Harinath <rharinath@novell.com>
9701 Combine two near-redundant caches.
9702 * typemanager.cs (method_params): Rename from method_internal_params.
9703 (TypeManager.GetParameterData): New. Replace
9704 Invocation.GetParameterData.
9705 (TypeManager.LookupParametersByBuilder): Remove.
9706 * expression.cs (Invocation.method_parameter_cache): Remove.
9707 (Invocation.GetParameterData): Remove.
9709 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
9712 2005-02-08 Raja R Harinath <rharinath@novell.com>
9715 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
9716 TypeManager.multicast_delegate_type is null, resolve it by looking
9717 up "System.MulticastDelegate".
9718 * rootcontext.cs (RootContext.ResolveCore): Simplify.
9720 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
9721 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
9722 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
9725 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
9726 (LabeledStatement.AddReference): New. Set 'referenced'.
9727 (Goto.Resolve): Use it.
9729 2005-02-05 John Luke <john.luke@gmail.com>
9731 * driver.cs: remove duplicate -doc line in Usage ()
9733 2005-02-04 Raja R Harinath <rharinath@novell.com>
9735 * location.cs (Location.AddFile): Fix CS2002 error report.
9737 2005-02-02 Martin Baulig <martin@ximian.com>
9739 * delegate.cs (Delegate.DefineType): Report an internal error if
9740 TypeManager.multicast_delegate_type is null. See bug #72015 for
9743 2005-02-02 Raja R Harinath <rharinath@novell.com>
9745 Fix a crasher in a variant of #31984.
9746 * const.cs (Constant.CheckBase): New override that defers the
9747 new-or-override check in case the base type hasn't been populated
9749 (Constant.Define): Ensure the new-or-override check is performed.
9751 2005-02-01 Duncan Mak <duncan@ximian.com>
9753 * const.cs (LookupConstantValue): Check that `ce' is not null
9754 before calling GetValue ().
9756 2005-02-01 Raja R Harinath <rharinath@novell.com>
9758 Fix test-334.cs (#69519).
9759 * cs-parser.jay (using_alias_directive): Pass in an expression to
9760 NamespaceEntry.UsingAlias.
9761 (using_namespace_directive): Pass in an expression to
9762 NamespaceEntry.Using.
9763 (namespace_name): Don't flatten to a string.
9764 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
9765 (NamespaceEntry.AliasEntry.Resolve): Lookup using
9767 (NamespaceEntry.UsingEntry): Likewise.
9768 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
9770 (NamespaceEntry.LookupForUsing): Remove.
9771 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
9773 (NamespaceEntry.Lookup): Remove support for dotted names.
9775 2005-02-01 Raja R Harinath <rharinath@novell.com>
9777 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
9779 (NamespaceEntry.ImplicitParent): Compute on demand.
9780 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
9781 parallels the current.
9782 (NamespaceEntry.LookupForUsing): Use it.
9783 (NamespaceEntry.Lookup): If the current namespace-entry is
9784 implicit, don't search aliases and using tables.
9786 2005-02-01 Raja R Harinath <rharinath@novell.com>
9789 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
9791 (TypeContainer.BaseCache): Compute on demand.
9792 (TypeContainer.FindMembers): Define constants and types if they're
9793 not already created.
9794 (FieldMember.Define): Move resetting of ec.InUnsafe before error
9796 * const.cs (Constant.Define): Make idempotent.
9798 2005-01-29 Miguel de Icaza <miguel@novell.com>
9800 * pending.cs: Produce better code (no nops produced by using Ldarg
9803 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
9804 i - 1' it should be arg + 1.
9808 2005-01-28 Raja R Harinath <rharinath@novell.com>
9810 * attribute.cs (Attribute.CheckAttributeType): Make private
9812 (Attribute.ResolveType): Make virtual.
9813 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
9814 handling of RootContext.Tree.Types.
9816 2005-01-27 Raja R Harinath <rharinath@novell.com>
9818 Update attribute-handling to use the SimpleName/MemberAccess
9820 * cs-parser.jay (attribute): Pass in an expression to the
9821 constructors of Attribute and GlobalAttribute.
9822 * attribute.cs (Attribute): Take an expression for the name.
9823 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
9824 passed in attribute name expression.
9825 (Attribute.CheckAttributeType): Use it.
9826 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
9827 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
9828 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
9829 argument to prevent error messages if the lookup fails.
9831 2005-01-27 Marek Safar <marek.safar@seznam.cz>
9833 * expression.cs (Indirection): Implemented IVariable interface
9834 to support indirection in AddressOf operator.
9835 (PointerArithmetic.Emit): Add optimalization for case where
9836 result can be precomputed.
9838 2005-01-26 Martin Baulig <martin@ximian.com>
9840 * class.cs (TypeContainer.AttributeTargets): Return the correct
9841 AttributeTargets depending on our `Kind' instead of throwing an
9842 exception; fixes #71632.
9844 2005-01-26 Marek Safar <marek.safar@seznam.cz>
9847 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
9850 2005-01-25 Raja R Harinath <rharinath@novell.com>
9853 * expression.cs (MemberAccess.DoResolve): Don't complain with
9854 cs0572 when the LHS of a member access has identical name and type
9857 2005-01-25 Marek Safar <marek.safar@seznam.cz>
9860 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
9862 Create custom PermissionSet only for PermissionSetAttribute.
9864 2005-01-24 Marek Safar <marek.safar@seznam.cz>
9867 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
9868 delegates in static class.
9870 2005-01-24 Martin Baulig <martin@ximian.com>
9872 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9873 merging an implicit block, just use its reachability.
9875 * statement.cs (Block.Resolve): Make the unreachable code check
9876 work wrt. implicit blocks; see test-337 from #63842.
9878 2005-01-21 Alp Toker <alp@atoker.com>
9880 * cs-parser.jay: destructor_declaration's container is PartialContainer
9881 not Class when partial types are used, so use Kind prop instead of
9884 2005-01-22 Miguel de Icaza <miguel@ximian.com>
9886 * cs-parser.jay: Improve error reporting when an interface
9889 2005-01-20 Dick Porter <dick@ximian.com>
9891 * support.cs: SeekableStreamReader fix from Sandor Dobos
9892 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
9893 chars are read. Fixes bug 70369.
9895 2005-01-20 Raja R Harinath <rharinath@novell.com>
9897 * cs-parser.jay (catch_clause): Simplify current_block handling
9900 2005-01-17 Miguel de Icaza <miguel@ximian.com>
9902 * convert.cs (ImplicitStandardConversionExists): Synchronize the
9903 code with ImplicitStandardConversion to handle the implicit
9904 conversion of method groups into valid delegate invocations.
9906 The problem is that in parameter handling we were using this code
9907 path. Fixes bug #64698
9909 2005-01-19 Raja R Harinath <rharinath@novell.com>
9911 * cs-parser.jay: Fix several infelicities.
9912 - Avoid assigning to the parser value stack. Code like
9913 '$3 = null' is unclean. Synthesize a value for the code block
9915 - Avoid using oob_stack for storing location information. Use ...
9916 (_mark_): ... this. New (empty) rule. Saves the current location
9918 (foreach_statement): Avoid using oob_stack for current_block
9919 handling. Use technique used in for_statement and
9920 using_statement. Synthesize a value for the code block to store
9921 additional intermediate information.
9923 2005-01-13 Miguel de Icaza <miguel@ximian.com>
9925 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
9926 of a different type is only allowed to private fields of a
9927 containing type, not on fields of a base class.
9929 See test-174.cs and error cs0122-9.cs
9931 2005-01-13 Raja R Harinath <rharinath@novell.com>
9933 Fix test-335.cs (bug #58126).
9934 * cs-parser.jay (argument): Split out non-expression parts of the
9935 rule into 'non_simple_argument'.
9936 (invocation_expression): Support parenthesized invocations with
9937 multiple arguments, and with single non-simple arguments.
9939 2005-01-13 Raja R Harinath <rharinath@novell.com>
9941 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
9944 2005-01-12 Raja R Harinath <rharinath@novell.com>
9946 Fix cs0038-1.cs, cs1640-6.cs.
9947 * ecore.cs (Expression.Resolve): Remove special-case for
9948 SimpleName in error-handling.
9949 (Expression.almostMatchedMembers): Relax access permission to
9951 (Expression.MemberLookupFailed): Handle duplicates in
9952 almostMatchedMembers list.
9953 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
9954 * expression.cs (New.DoResolve): Report CS1540 for more cases.
9955 * typemanager.cs (GetFullNameSignature): Use the MethodBase
9956 overload if the passed in MemberInfo is a MethodBase.
9958 2005-01-12 Marek Safar <marek.safar@seznam.cz>
9961 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
9962 for non-CAS & merge permission sets properly.
9964 2005-01-11 Raja R Harinath <rharinath@novell.com>
9966 Improve standard-compliance of simple name and member access
9967 resolution. Fixes bugs #52697, #57200, #67520, #69519.
9968 * ecore.cs (FullNamedExpression): New abstract base class
9969 for Namespaces and TypeExpressions.
9970 (ResolveFlags.SimpleName): Remove.
9971 (SimpleName): Remove support for dotted names.
9972 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
9973 DeclSpace.FindType and DeclSpace.LookupType.
9974 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
9975 (Expression.ExprClassName): Make member function.
9976 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
9977 a namespace. Remove creation of dotted "SimpleName"s.
9978 (MemberAccess.DoResolve): Likewise.
9979 * decl.cs (DeclSpace.Cache): Make private.
9980 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
9981 (DeclSpace.FindType): Update.
9982 (DeclSpace.LookupType): Move here from RootContext. Return a
9983 FullNamedExpression.
9984 * namespace.cs (Namespace): Derive from FullNamedExpression
9985 so that it can be part of expression resolution.
9986 (Namespace.Lookup): Return an FullNamedExpression.
9987 (NamespaceEntry.LookupAlias): Lookup aliases only in current
9989 * rootcontext.cs (NamespaceLookup): Remove.
9990 (LookupType): Move to DeclSpace.
9991 * attribute.cs (CheckAttributeType): Update.
9992 * doc.cs (FindDocumentedType): Remove allowAlias argument.
9993 (FindDocumentedTypeNonArray): Likewise.
9995 2005-01-11 Raja R Harinath <rharinath@novell.com>
9997 Fix cs0509.cs, cs1632.cs.
9998 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
9999 is the same as IsInterface.
10000 (TypeContainer.GetClassBases): Likewise.
10001 * statement.cs (LabeledStatement.ig): New field.
10002 (LabeledStatement.LabelTarget): Save ILGenerator which created the
10004 (LabeledStatement.DoEmit): Check that the label was created with
10005 the same ILGenerator.
10007 2005-01-10 Marek Safar <marek.safar@seznam.cz>
10010 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
10011 accessors to its properties.
10013 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
10014 from accessors to property.
10016 2005-01-10 Marek Safar <marek.safar@seznam.cz>
10019 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
10020 only for overrides.
10022 2005-01-08 Miguel de Icaza <miguel@ximian.com>
10024 * attribute.cs: Check for null and empty strings.
10026 I have lost another battle to Paolo.
10028 2005-01-07 Marek Safar <marek.safar@seznam.cz>
10031 * class.cs (PropertyMethod): Set Parent field in ctors.
10032 (SetMethod.InternalParameters): Add unsafe switch hack.
10033 Override MarkForDuplicationCheck where it is appropriate.
10035 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
10036 It says whether container allows members with the same name.
10037 Base default is no.
10038 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
10039 Removed is_method parameter.
10041 2005-01-06 Duncan Mak <duncan@ximian.com>
10043 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
10044 because the previous change led to incorrect reporting of CS1032
10045 ("Cannot define/undefine preprocessor symbols after first token in
10046 file"). Instead of using `tokens_seen' as the only flag that
10047 triggers CS1040, introduce `comments_seen'. This new flag is used
10048 to signify having seen comments on the current line, so it is
10049 unset after a newline.
10051 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
10053 * doc.cs : When searching for a type, find nested type too.
10054 This fixes bug #71040.
10056 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
10059 - Warn missing member comment on those classes which also does not
10060 have doc comments. Fixed bug #71041.
10061 - Don't warn missing doc comment on default constructor.
10064 2005-01-06 Duncan Mak <duncan@ximian.com>
10066 * cs-tokenizer.cs (xtoken): After handling traditional C-style
10067 comments, set `tokens_seen' to true. This allows us to detect
10068 misplaced preprocessor directives (i.e. not at the beginning of
10069 the a line, nor after whitespaces). In that case, report error
10070 CS1040. This fixes bug #56460.
10072 * cs-parser.jay (interface_member_declaration): Add checks for
10073 IsExplicitImpl, and report CS0541 error if an interface member is
10074 defined as an explicit interface declaration.
10076 2005-01-06 Marek Safar <marek.safar@seznam.cz>
10079 * class.cs (PropertyMethod): Set Parent field in ctors.
10080 (SetMethod.InternalParameters): Add unsafe switch hack.
10082 * decl.cs (MemberCore.Parent): Cannot be readonly.
10084 2005-01-06 Raja R Harinath <rharinath@novell.com>
10086 * decl.cs (DeclSpace.ResolveType): Remove.
10087 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
10088 Merge in code from ...
10089 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
10090 * class.cs, enum.cs: Update to changes.
10092 2005-01-06 Miguel de Icaza <miguel@ximian.com>
10094 * anonymous.cs: Ensure that we init the scope of our parent if it
10095 has not been initialized yet.
10097 2004-12-30 Duncan Mak <duncan@ximian.com>
10099 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
10100 if field.FieldBuilder is null. Fixes #70758.
10102 * convert.cs: Fixed some typos and updated some of the comments.
10103 (ImplicitStandardConversionExists):
10104 (TryImplicitIntConversion): If `target_type' is an interface and
10105 the type of `ic' implements this interface, return true or a new
10106 BoxedCast instead of null. This fixes #70468.
10108 2004-12-29 Duncan Mak <duncan@ximian.com>
10110 * expression.cs (Argument.Emit): Check that Expr is
10111 IMemoryLocation before casting to it, and report CS1510 otherwise.
10115 2004-12-21 Ben Maurer <bmaurer@ximian.com>
10117 * statement.cs (Block.ThisVariable): remove the recursion here, to
10118 make the --profile more sane.
10120 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
10122 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
10123 assembly, by JB Evain.
10125 2004-12-17 Raja R Harinath <rharinath@novell.com>
10127 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
10128 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
10129 "parent" refers to enclosing type/class. "base" refers to superclass.
10131 2004-12-17 Raja R Harinath <rharinath@novell.com>
10133 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10134 Ensure that we only have GlobalAttributes.
10135 * attribute.cs (Attribute.Emit): Make non-virtual.
10136 (GlobalAttribute.Emit): Remove.
10137 (Attribute.Resolve): Make virtual.
10138 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
10139 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
10140 the argument. Don't create one.
10141 (Attribute.GetObsoleteAttribute): Likewise.
10142 (Attribute.GetClsCompliantAttributeValue): Likewise.
10143 * class.cs, decl.cs: Update to changes.
10145 2004-12-17 Marek Safar <marek.safar@seznam.cz>
10147 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
10149 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
10151 * statement.cs (Foreach.Resolve): Add error 186 report.
10153 2004-12-16 Marek Safar <marek.safar@seznam.cz>
10155 * expression.cs (Conditional.DoResolve): Add warning 429.
10157 * statement.cs (If.Resolve): Add warning 665.
10159 2004-12-16 Raja R Harinath <rharinath@novell.com>
10161 New invariant: RootContext.Tree.Types.NamespaceEntry == null
10162 except when in the parser, and in GlobalAttribute.
10163 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
10164 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
10165 RootContext.Tree.Types.NamespaceEntry once work is done.
10166 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
10167 and resets RootContext.Tree.Types.NamespaceEntry.
10169 2004-12-15 Marek Safar <marek.safar@seznam.cz>
10171 * cs-parser.jay: Don't create a block for every variable.
10173 2004-12-14 Miguel de Icaza <miguel@ximian.com>
10175 * location.cs: Provide extra information.
10177 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
10178 variables from the captured environment, it is the ldarg_0.
10180 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10182 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
10185 * class.cs: Changed warning level for 169 to avoid developer
10186 displeasure from warning flooding. It will be changed back when they
10187 fix most of current BCL warnings.
10189 * RootContext.cs: Pushed default WarningLevel to 3.
10191 * statement.cs: Removed unused variable.
10193 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10195 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
10196 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
10197 Add error 502 report.
10198 (StaticClass.DefineType): Add error 441 report.
10199 (Class.AllowedModifiersProp): New virtual property as temporary
10200 extension to AllowedModifiers.
10201 (Class.DefineType): Add error 418 report. Moved ModFlags check here
10202 to share implementation with StaticClass and don't call virtual
10205 * driver.cs (MainDriver): Add error 1558 test.
10207 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
10208 report. Moved error 36 test here.
10210 * statement.cs (Throw.Resolve): Add error 724 report.
10212 * typemanager.cs: Add out_attribute_type core type.
10214 2004-12-13 Marek Safar <marek.safar@seznam.cz>
10216 * class.cs (TypeContainer.VerifyClsCompliance): Add error
10218 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
10220 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
10223 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
10225 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
10226 Add error 3023 report.
10227 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
10229 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
10232 2004-12-12 John Luke <john.luke@gmail.com>
10234 * driver.cs (AddArgs): take -- into account when
10235 adding arguments, fixes bug 65710
10237 2004-12-12 Martin Baulig <martin@ximian.com>
10239 * expression.cs (Unary.TryReduceNegative): Added support for
10240 SByteConstant and ByteConstant.
10241 (Unary.Reduce): Check error values from TryReduceNegative().
10243 2004-12-10 Marek Safar <marek.safar@seznam.cz>
10245 * attributes.cs (Attribute.Resolve): Avoid multiple error report
10246 and report exception as error 182.
10248 2004-12-10 Raja R Harinath <rharinath@novell.com>
10250 * driver.cs (Main): Fix message when there are warnings.
10252 2004-12-09 Miguel de Icaza <miguel@ximian.com>
10254 * delegate.cs: Fixed my fix from yesterday, sorry about that.
10256 2004-12-09 Marek Safar <marek.safar@seznam.cz>
10258 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
10259 Reduced number of warnings.
10261 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
10263 2004-12-08 Miguel de Icaza <miguel@ximian.com>
10265 * driver.cs: Removed message.
10267 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
10269 2004-12-08 <vargaz@freemail.hu>
10271 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
10273 2004-12-08 Martin Baulig <martin@ximian.com>
10275 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
10276 instead of a CS3002 for properties and indexer.
10278 2004-12-08 Martin Baulig <martin@ximian.com>
10280 * decl.cs (MemberName.ToString): Make this work again.
10282 2004-12-08 Marek Safar <marek.safar@seznam.cz>
10284 * attribute.cs (Resolve): Add error 591 detection.
10286 * class.cs (FieldMember.Define): Add error 1547 detection.
10287 (Indexer.Define): Add error 620 detection.
10288 (Operator.Define): Add error 590 detection.
10290 * ecore.cs: Missing argument for error 79.
10292 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
10295 2004-12-07 Marek Safar <marek.safar@seznam.cz>
10298 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
10301 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
10303 * cs-parser.jay : handle doc comments on implicit/explicit operators.
10304 Some operator comments were suppressed.
10305 * doc.cs : Implicit/explicit operator name in doc comments are like
10306 "op_Explicit(type)~returnType", so added suffix handling.
10308 2004-12-07 Martin Baulig <martin@ximian.com>
10311 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
10312 (MemberCore.GetClsCompliantAttributeValue): Likewise.
10313 (DeclSpace.ec): New protected field; store the EmitContext here.
10314 (DeclSpace.EmitContext): New public property; moved here from
10316 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
10319 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
10320 (Enum.Emit): Don't create a new EmitContext.
10322 * delegate.cs (Delegate.DefineType): Always create the
10325 * iterators.cs (Iterators.DefineIterator): Create a new
10326 EmitContext and store it in `ec'.
10328 2004-08-24 Martin Baulig <martin@ximian.com>
10331 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
10332 this for accessibility checks.
10333 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
10334 IsNestedFamilyAccessible.
10335 (TypeManager.IsSubclassOf): New method, do what the name actually
10338 2004-12-06 Raja R Harinath <rharinath@novell.com>
10340 Fix crash on cs0657-17.cs.
10341 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10342 Use RootContext.Tree.Types, not 'new RootTypes ()'.
10343 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
10344 the case where the NamespaceEntry gets overwritten.
10346 2004-12-06 Marek Safar <marek.safar@seznam.cz>
10348 Fixed #69195, #56821
10349 * ecore.cs (ResolveBoolean): Tiny refactoring.
10351 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
10352 of right expression resolving when left is false constant and
10353 operator is LogicalAnd OR true constant and operator is LogicalOr.
10355 * statement.cs (ResolveUnreachable): Always reports warning.
10357 2004-12-05 Miguel de Icaza <miguel@ximian.com>
10359 * class.cs: Distinguish between 1721 and 1722 (just a little help
10360 for the programmer).
10362 2004-12-03 Miguel de Icaza <miguel@ximian.com>
10364 * delegate.cs: Only allow this on new versions of the language.
10366 2004-12-02 Duncan Mak <duncan@ximian.com>
10368 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
10370 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
10371 here as a static method. Take an additional bool out parameter
10372 `must_do_cs1540_check' for signaling to InstanceResolve.
10373 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
10374 member field from PropertyExpr class and made it an argument of
10375 the method instead.
10376 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
10377 check for MarshalByRefObject, and report CS0122 instead of CS1540.
10378 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
10379 and `remove_accessor' as well as InstanceResolve: report CS0122
10384 2004-12-03 Raja R Harinath <rharinath@novell.com>
10386 Fix test-327.cs, test-328.cs, and put in early infrastructure
10387 for eventually fixing #52697.
10388 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
10389 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
10390 from other methods.
10391 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
10392 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
10393 (VerifyUsing, error246): Update.
10394 * rootcontext.cs (RootContext.NamespaceLookup): Just use
10395 'NamespaceEntry.LookupNamespaceOrType'.
10397 2004-12-03 Martin Baulig <martin@ximian.com>
10399 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10400 method as our child, call AnonymousMethod.Compatible() on it.
10402 2004-12-03 Raja R Harinath <rharinath@novell.com>
10404 Disable XML documentation support in 'basic' profile.
10405 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
10406 Redirect XmlElement to System.Object.
10407 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
10408 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
10409 * mcs.exe.sources: Add doc-bootstrap.cs.
10410 * doc-bootstrap.cs: New file. Contains empty stub implementation
10413 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
10415 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
10416 comments are allowed.
10418 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10420 * delegate.cs: Add checks for subtypes in paramaters and return values
10421 in VerifyMethod () to add support for Covariance/Contravariance
10424 2004-12-02 Miguel de Icaza <miguel@ximian.com>
10426 * report.cs: Remove extra closing parenthesis.
10428 * convert.cs (Error_CannotImplicitConversion): If the name of the
10429 types are the same, provide some extra information.
10431 * class.cs (FieldBase): Use an unused bit field from the field to
10432 encode the `has_offset' property from the FieldMember. This saves
10433 a couple of Ks on bootstrap compilation.
10435 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10436 method as our child, return the AnonymousMethod resolved
10439 * expression.cs (New.DoResolve): Allow return values from
10440 NewDelegate to also include AnonymousMethods.
10444 2004-12-02 Marek Safar <marek.safar@seznam.cz>
10447 * attribute.cs (Resolve): Improved implementation of params
10448 attribute arguments.
10450 * support.cs (ParameterData): Add HasParams to be faster.
10452 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
10454 all things are for /doc support:
10456 * doc.cs: new file that supports XML documentation generation.
10457 * mcs.exe.sources: added doc.cs.
10459 Handle /doc command line option.
10460 Report error 2006 instead of 5 for missing file name for /doc.
10461 Generate XML documentation when required, after type resolution.
10463 Added support for picking up documentation (/// and /** ... */),
10464 including a new XmlCommentState enumeration.
10466 Added lines to fill Documentation element for field, constant,
10467 property, indexer, method, constructor, destructor, operator, event
10468 and class, struct, interface, delegate, enum.
10469 Added lines to warn incorrect comment.
10471 Added Documentation field (passed only when /doc was specified).
10473 Added DocComment, DocCommentHeader, GenerateDocComment() and
10474 OnGenerateDocComment() and some supporting private members for
10475 /doc feature to MemberCore.
10477 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
10479 Added overriden DocCommentHeader.
10481 Added overriden DocCommentHeader and GenerateDocComment().
10483 2004-12-01 Miguel de Icaza <miguel@ximian.com>
10485 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
10486 unwrapping the enumeration values, chain to
10487 DoConstantNumericPromotions again, so we can promote things to the
10488 fundamental types (takes care of enums that are bytes, sbytes).
10492 2004-12-01 Raja R Harinath <rharinath@novell.com>
10494 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
10495 Fix long-standing bug in type-lookup. Use FindType instead of
10496 LookupType when ec.ResolvingTypeTree.
10497 (Attribute.ResolveType, Attribute.Resolve)
10498 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
10500 (Attributes.Search): Remove internal version. Update.
10501 (Attributes.SearchMulti): Update.
10502 (Attributes.GetClsCompliantAttribute): Remove.
10503 (Attributes.GetIndexerNameAttribute): Remove.
10504 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
10505 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
10506 * class.cs (Indexer.Define): Likewise.
10508 2004-12-01 Marek Safar <marek.safar@seznam.cz>
10511 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
10512 MarshallByReference members access.
10514 * expression.cs: Use CheckMarshallByRefAccess;
10515 Better error CS0197 message.
10517 * report.cs: Print whole related error message.
10519 2004-11-30 Raja R Harinath <rharinath@novell.com>
10521 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
10522 the current directory to help debugging.
10524 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10526 * class (GetClassBases): Better error 60 report.
10527 (EventProperty): Disabled warning 67 detection.
10529 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10532 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
10534 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
10537 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10540 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
10542 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
10544 2004-11-26 Miguel de Icaza <miguel@ximian.com>
10546 * attribute.cs (Attribute.Resolve): Refine error reporting and
10547 report a cs0117 if the identifier does not exist, to distinguish
10548 from 0617 which is a miss-use of the actual identifier.
10550 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
10551 between cs0070 and cs0079.
10553 * class.cs (MemberBase.DoDefine): When reporting a wrong
10554 accessibility level, we use MethodCore to compare instead of
10555 Method (this was a regression in some refactoring effort).
10557 So now we correctly report cs0056 again.
10559 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
10560 testing the target_type (which was known to be object_type) and
10561 not the source type (which is anonymous_method).
10563 Fixed reporting of error cs1660.
10565 * expression.cs (UserCast.Source): Expose the underlying cast.
10567 * statement.cs (Switch.SwitchGoverningType): Sort the list of
10568 allowed types to find a match to int32 first (most common).
10570 In addition, it ignores any ImplicitUserConversions that did an
10571 internal implicit conversion (as the switch statement allows only
10572 one integral conversion to exist).
10574 * class.cs (PartialContainer.Create): rename `name' to
10575 `member_name' for clarity. Then replace the string calls with a
10576 call to MemberName.GetPartialName, as now using
10577 MemberName.ToString is an error (this is due to the side effects
10578 it had, that were fixed in the past).
10580 This will restore the error reporting on a number of partial class
10581 errors that were missusing this (and getting an exception as a
10582 results, which is now just a plain textual warning, because
10583 yyparse debug output would crash otherwise).
10585 2004-11-26 Raja R Harinath <rharinath@novell.com>
10587 * Makefile (PROGRAM_INSTALL_DIR): Remove.
10589 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10591 * rootcontext.cs (LookupType): Make sure to cache lookups that
10592 don't give us a negative result. This saves about 5% of corlib
10595 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10597 * report.cs (AbstractMessage.Print): messages are sent to stderr
10599 * class.cs (TypeContainer.GetClassBases): It is an error to have a
10600 non-interface in the list of interfaces (at this point, either
10601 parent was properly set, or a base class is being listed in the
10602 interfaces section).
10604 This flags error 1722, and resolves the crash from bug 69259.
10606 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10608 * statement.cs (Using.EmitExpressionFinally): make this work right
10609 for valuetypes. Fixes 69926.
10611 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10613 * const.cs (Const.ChangeType): Cope with the "0 literal can be
10614 converted to an enum" here, before we try to change the underlying
10615 type. This code exists, but it is a different code path than the
10616 one used while encoding constants.
10618 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
10619 old bug: when converting from the null literal to a pointer,
10620 return an EmptyCast, not the NullLiteral.
10622 This fixes #69921, the recent null_type changes probably made this
10623 bug more prominent.
10625 (ImplicitReferenceConversionExists): In addition, resynchronized
10626 the code here, so it matches the same code in
10627 ImplicitReferenceConversionExists for the `from any class-type S
10628 to any interface-type T'.
10631 2004-11-25 Marek Safar <marek.safar@seznam.cz>
10633 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
10635 2004-11-24 Miguel de Icaza <miguel@ximian.com>
10637 * cs-parser.jay: Use verbosity accordingly.
10639 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10641 * expression.cs (Unary.ResolveOperator): Do not report warning;
10642 AddressOf reads from variable.
10644 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
10646 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10650 * attribute.cs (Attributable): Removed CheckTargets.
10651 (Attributes.Emit): Explicit attribute targets are tested here.
10653 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
10654 not enabled for interfaces.
10656 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
10657 (GetAssemblyName): Ouch next bug there.
10659 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10661 * expression.cs: Error 275 added.
10663 2004-11-23 Marek Safar <marek.safar@seznam.cz>
10665 Fix bug #69177 (Implemented decimal constant support)
10667 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
10668 (BinaryFold): Add DecimalConstant.
10670 * const.cs (Define): Decimal constant
10672 (ChangeType): Add decimal type handling.
10673 (LookupConstantValue): Don't set value for decimal type but
10674 emit DecimalConstantAttribute. Needed for constant optimization.
10676 * constant.cs (ToDecimal): New method.
10677 (ConvertToDecimal): New method.
10678 (IntConstant): Implemented ConvertToDecimal.
10679 (DecimalConstant.Emit): Emit optimized version for decimals in
10682 * expression.cs (ResolveOperator): Changed order of constant
10683 reduction to work correctly with native types which have
10684 overloaded operators.
10685 (ResolveMemberAccess): Extract constant value from attribute
10688 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
10690 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
10691 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
10692 (ChangeType): Decimal is special.
10693 (TypeToCoreType): Add decimal type.
10695 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10697 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
10700 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10702 * class.cs (EventField.ApplyAttributeBuilder): Fix error
10705 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10707 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
10709 * pending.cs (PendingImplementation): Grab only interfaces.
10711 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10713 * statement.cs (ForeachHelperMethods): Add location member and
10714 error 202 detection.
10716 2004-11-19 Raja R Harinath <rharinath@novell.com>
10718 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
10719 automatically handled by executable.make.
10720 (PROGRAM): Make profile-specific.
10722 2004-11-18 Marek Safar <marek.safar@seznam.cz>
10724 * expression.cs (DoResolveBase): Fixed wrong warning for out
10727 2004-11-18 Martin Baulig <martin@ximian.com>
10729 Merged latest changes into gmcs. Please keep this comment in
10730 here, it makes it easier for me to see what changed in MCS since
10731 the last time I merged.
10733 2004-11-17 Raja R Harinath <rharinath@novell.com>
10735 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
10736 (TypeHandle.GetMemberCache): New.
10737 (TypeHandle.TypeHandle): Update.
10738 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
10739 (TypeManager.LookupParentInterfacesCache):
10740 Rename from LookupInterfaceCache. Optimize slightly.
10741 (TypeManager.MemberLookup_FindMembers): Update.
10742 * decl.cs (MemberCache.MemberCache): Set Container to null in the
10743 multi-type variant.
10744 (AddCacheContents): Rename from AddHashtable.
10745 * class.cs (TypeContainer.parent_container): Remove.
10746 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
10747 (TypeContainer.DoDefineMembers): Don't initialize it.
10748 Update to name changes.
10750 2004-11-17 Miguel de Icaza <miguel@ximian.com>
10752 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
10753 that factors the code to check access modifiers on override.
10755 (PropertyBase): Use the code here.
10757 Patch from Lluis S'anchez, fixes bug #69361.
10759 2004-11-15 Miguel de Icaza <miguel@ximian.com>
10761 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
10762 routine that is used to report the use of a captured variable
10763 whose address has been taken.
10765 There are two checks: one when variables are being captured and
10766 the other check is when the address of a variable is taken.
10768 (because an anonymous methods might be resolved before *or* after
10769 the address has been taken) and
10771 * expression.cs (Conditional.DoResolve): Remove the special
10772 casing that Martin added to trueExpr and falseExpr being both
10773 NullLiteral. We get the right behavior now just by introducing
10774 the null_type into the compiler.
10776 * convert.cs (ExplicitConversion): Change the code to use
10777 null_type instead of testing `expr is NullLiteral'.
10778 (ImplicitConversionStandard): use null_type too.
10779 (ImplicitReferenceConversionExists): use null_type too.
10780 (ImplicitReferenceConversion): use null_type too.
10782 * literal.cs: The type of `NullLiteral' is now null_type instead
10784 (Resolve): Set the type here.
10786 * typemanager.cs: Introduce null_type.
10788 2004-11-17 Martin Baulig <martin@ximian.com>
10790 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
10791 direction, like FindMembers() does. Fixes #69546, testcase is in
10794 2004-11-16 Martin Baulig <martin@ximian.com>
10796 This is based on a patch from Marek Safar, see bug #69082.
10797 Fixes bugs #63705 and #67130.
10799 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
10800 method; create a MemberCache for an interface type and cache the
10803 * decl.cs (IMemberContainer.ParentContainer): Removed.
10804 (IMemberContainer.ParentCache): New property.
10805 (MemberCache.SetupCacheForInterface): Removed.
10806 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
10807 to create a cache for an interface's "parent".
10809 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
10812 2004-11-16 Martin Baulig <martin@ximian.com>
10814 Merged back from gmcs; these changes already went into gmcs a
10815 couple of weeks ago.
10818 (TypeManager.AddUserType): Removed the `ifaces' argument.
10819 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
10821 (TypeManager.AddUserInterface): Removed.
10822 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
10824 (TypeManager.GetInterfaces): Likewise.
10825 (TypeManager.GetExplicitInterfaces): Likewise.
10827 * ecore.cs (TypeExpr.GetInterfaces): Removed.
10829 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
10830 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
10832 2004-11-14 Ben Maurer <bmaurer@ximian.com>
10834 * statement.cs: Avoid adding bools to a hashtable.
10836 2004-11-07 Miguel de Icaza <miguel@ximian.com>
10838 * expression.cs (Invocation.OverloadResolve): Flag error if we are
10839 calling an unsafe method from a safe location.
10841 2004-11-06 Marek Safar <marek.safar@seznam.cz>
10844 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
10846 2004-11-06 Miguel de Icaza <miguel@ximian.com>
10848 * namespace.cs (VerifyUsing): use GetPartialName instead of
10851 2004-11-05 Miguel de Icaza <miguel@ximian.com>
10853 * statement.cs (Return.Resolve): Fix regression in typo: if
10854 `in_exc', we have to request a NeedReturnLabel, this was a typo
10855 introduced in the anonymous method check-in. Fixes #69131.
10857 * Indexers were using the ShortName when defining themselves,
10858 causing a regression in the compiler bootstrap when applying the
10859 patch from 2004-11-02 (first part), now they use their full name
10860 and the bug is gone.
10862 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
10864 * driver.cs: Strip the path from the names of embedded resources. Fixes
10867 2004-11-04 Raja R Harinath <rharinath@novell.com>
10869 Fix error message regression: cs0104-2.cs.
10870 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
10871 (AliasEntry.Resolve): Update.
10872 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
10874 (RootContext.LookupType): Update.
10876 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
10878 * cs-parser.jay: Add support for handling accessor modifiers
10879 * class: Add support port accessor modifiers and error checking,
10880 define PropertyMethod.Define as virtual (not abstract anymore)
10881 * ecore.cs: Add checking for proeprties access with access modifiers
10882 * iterators.cs: Modify Accessor constructor call based in the modified
10884 2004-11-02 Ben Maurer <bmaurer@ximian.com>
10886 * expression.cs (StringConcat): Handle being called twice,
10887 as when we have a concat in a field init with more than two
10890 2004-11-02 Miguel de Icaza <miguel@ximian.com>
10892 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
10893 special case explicit implementations, we should always produce
10894 the .property or .event declaration.
10896 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
10897 since it will not return correct data if people use this
10898 unresolved in the presence of using statements (see test-313).
10900 * class.cs (MethodData.Define): If we are an explicit interface
10901 implementation, set the method name to the full name of the
10902 interface plus the name of the method.
10904 Notice that using the method.MethodName.GetFullName() does not
10905 work, as it will only contain the name as declared on the source
10906 file (it can be a shorthand in the presence of using statements)
10907 and not the fully qualifed type name, for example:
10911 class D : ICloneable {
10912 object ICloneable.Clone () {
10916 Would produce a method called `ICloneable.Clone' instead of
10917 `System.ICloneable.Clone'.
10919 * namespace.cs (Alias.Resolve): Use GetPartialName.
10921 2004-11-01 Marek Safar <marek.safar@seznam.cz>
10923 * cs-parser.jay: Add error 1055 report.
10925 2004-11-01 Miguel de Icaza <miguel@ximian.com>
10927 * assign.cs (Assign.DoResolve): Only do the transform of
10928 assignment into a New if the types are compatible, if not, fall
10929 through and let the implicit code deal with the errors and with
10930 the necessary conversions.
10932 2004-11-01 Marek Safar <marek.safar@seznam.cz>
10934 * cs-parser.jay: Add error 1031 report.
10936 * cs-tokenizer.cs: Add location for error 1038.
10938 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10940 * cs-parser.jay: Add error 1016 report.
10942 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10944 * cs-parser.jay: Add errors 1575,1611 report.
10946 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10948 * cs-parser.jay: Add error 1001 report.
10950 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10953 * attribute.cs (GetMarshal): Add method argument for
10954 caller identification.
10956 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
10957 agument for GetMarshal and RuntimeMissingSupport.
10959 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10961 * attribute.cs (ExtractSecurityPermissionSet): Removed
10962 TypeManager.code_access_permission_type.
10964 * typemanager.cs: Removed TypeManager.code_access_permission_type.
10966 2004-10-27 Miguel de Icaza <miguel@ximian.com>
10968 * expression.cs (LocalVariableReference.DoResolveLValue): Check
10969 for obsolete use of a variable here. Fixes regression on errors
10970 cs0619-25 and cs0619-26.
10972 2004-10-27 Marek Safar <marek.safar@seznam.cz>
10974 Fix #62358, implemented security attribute encoding.
10976 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
10977 Tests permitted SecurityAction for assembly or other types.
10978 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
10979 data from SecurityPermissionAttribute to PermisionSet class.
10981 * class.cs (ApplyAttributeBuilder): Added special handling
10982 for System.Security.Permissions.SecurityAttribute based types.
10984 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
10985 special handling for System.Security.Permissions.SecurityAttribute
10988 * enum.cs (ApplyAttributeBuilder): Added special handling
10989 for System.Security.Permissions.SecurityAttribute based types.
10991 * parameter.cs (ApplyAttributeBuilder): Added special handling
10992 for System.Security.Permissions.SecurityAttribute based types.
10994 * rootcontext.cs: Next 2 core types.
10996 * typemanager.cs (TypeManager.security_permission_attr_type):
10997 Built in type for the SecurityPermission Attribute.
10998 (code_access_permission_type): Build in type.
11000 2004-10-17 Miguel de Icaza <miguel@ximian.com>
11002 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
11003 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
11004 all of this information into
11005 EmitContext.EmitCapturedVariableInstance.
11007 * codegen.cs (EmitCapturedVariableInstance): move here the
11008 funcionality of emitting an ldarg.0 in the presence of a
11009 remapping. This centralizes the instance emit code.
11011 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
11012 then emit a load of this: it means that we have reached the
11013 topmost ScopeInfo: the one that contains the pointer to the
11014 instance of the class hosting the anonymous method.
11016 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
11017 captures to the topmost CaptureContext.
11019 2004-10-12 Miguel de Icaza <miguel@ximian.com>
11021 * expression.cs (LocalVariableReference): Move the knowledge about
11022 the iterators into codegen's EmitCapturedVariableInstance.
11024 2004-10-11 Miguel de Icaza <miguel@ximian.com>
11026 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
11027 all code paths return a value from an anonymous method (it is the
11028 same as the 161 error, but for anonymous methods).
11030 2004-10-08 Miguel de Icaza <miguel@ximian.com>
11032 The introduction of anonymous methods in the compiler changed
11033 various ways of doing things in the compiler. The most
11034 significant one is the hard split between the resolution phase
11035 and the emission phases of the compiler.
11037 For instance, routines that referenced local variables no
11038 longer can safely create temporary variables during the
11039 resolution phase: they must do so from the emission phase,
11040 since the variable might have been "captured", hence access to
11041 it can not be done with the local-variable operations from the runtime.
11045 (Block.Flags): New flag `IsTopLevel' to indicate that this block
11046 is a toplevel block.
11048 (ToplevelBlock): A new kind of Block, these are the blocks that
11049 are created by the parser for all toplevel method bodies. These
11050 include methods, accessors and anonymous methods.
11052 These contain some extra information not found in regular blocks:
11053 A pointer to an optional CaptureContext (for tracking captured
11054 local variables and parameters). A pointer to the parent
11057 (Return.Resolve): Catch missmatches when returning a value from an
11058 anonymous method (error 1662).
11059 Invoke NeedReturnLabel from the Resolve phase instead of the emit
11062 (Break.Resolve): ditto.
11064 (SwitchLabel): instead of defining the labels during the
11065 resolution phase, we now turned the public ILLabel and ILLabelCode
11066 labels into methods called GetILLabelCode() and GetILLabel() that
11067 only define the label during the Emit phase.
11069 (GotoCase): Track the SwitchLabel instead of the computed label
11070 (its contained therein). Emit the code by using
11071 SwitchLabel.GetILLabelCode ().
11073 (LocalInfo.Flags.Captured): A new flag has been introduce to track
11074 whether the Local has been captured or not.
11076 (LocalInfo.IsCaptured): New property, used to tell whether the
11077 local has been captured.
11079 * anonymous.cs: Vastly updated to contain the anonymous method
11082 The main classes here are: CaptureContext which tracks any
11083 captured information for a toplevel block and ScopeInfo used to
11084 track the activation frames for various local variables.
11086 Each toplevel block has an optional capture context associated
11087 with it. When a method contains an anonymous method both the
11088 toplevel method and the anonymous method will create a capture
11089 context. When variables or parameters are captured, they are
11090 recorded on the CaptureContext that owns them, for example:
11094 MyDelegate d = delegate {
11099 Here `a' will be recorded as captured on the toplevel
11100 CapturedContext, the inner captured context will not have anything
11101 (it will only have data if local variables or parameters from it
11102 are captured in a nested anonymous method.
11104 The ScopeInfo is used to track the activation frames for local
11105 variables, for example:
11107 for (int i = 0; i < 10; i++)
11108 for (int j = 0; j < 10; j++){
11109 MyDelegate d = delegate {
11114 At runtime this captures a single captured variable `i', but it
11115 captures 10 different versions of the variable `j'. The variable
11116 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
11117 recorded on a child.
11119 The toplevel ScopeInfo will also track information like the `this'
11120 pointer if instance variables were referenced (this is necessary
11121 as the anonymous method lives inside a nested class in the host
11122 type of the method).
11124 (AnonymousMethod): Expanded to track the Toplevel, implement
11125 `AnonymousMethod.Compatible' to tell whether an anonymous method
11126 can be converted to a target delegate type.
11128 The routine now also produces the anonymous method content
11130 (AnonymousDelegate): A helper class that derives from
11131 DelegateCreation, this is used to generate the code necessary to
11132 produce the delegate for the anonymous method that was created.
11134 * assign.cs: API adjustments for new changes in
11135 Convert.ImplicitStandardConversionExists.
11137 * class.cs: Adjustments to cope with the fact that now toplevel
11138 blocks are of type `ToplevelBlock'.
11140 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
11141 insteda of standard blocks.
11143 Flag errors if params arguments are passed to anonymous methods.
11145 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
11146 `CurrentAnonymousMethod' which points to the current Anonymous
11147 Method. The variable points to the AnonymousMethod class that
11148 holds the code being compiled. It is set in the new EmitContext
11149 created for the anonymous method.
11151 (EmitContext.Phase): Introduce a variable and an enumeration to
11152 assist in enforcing some rules about when and where we are allowed
11153 to invoke certain methods (EmitContext.NeedsReturnLabel is the
11154 only one that enfonces this right now).
11156 (EmitContext.HaveCaptureInfo): new helper method that returns
11157 whether we have a CapturedContext initialized.
11159 (EmitContext.CaptureVariable): New method used to register that a
11160 LocalInfo must be flagged for capturing.
11162 (EmitContext.CapturedParameter): New method used to register that a
11163 parameters must be flagged for capturing.
11165 (EmitContext.CapturedField): New method used to register that a
11166 field must be flagged for capturing.
11168 (EmitContext.HaveCapturedVariables,
11169 EmitContext.HaveCapturedFields): Return whether there are captured
11170 variables or fields.
11172 (EmitContext.EmitMethodHostInstance): This is used to emit the
11173 instance for the anonymous method. The instance might be null
11174 (static methods), this (for anonymous methods that capture nothing
11175 and happen to live side-by-side with the current method body) or a
11176 more complicated expression if the method has a CaptureContext.
11178 (EmitContext.EmitTopBlock): Routine that drives the emission of
11179 code: it will first resolve the top block, then emit any metadata
11180 and then emit the code. The split is done so that we can extract
11181 any anonymous methods and flag any captured variables/parameters.
11183 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
11184 during this phase, the ILGenerator should not be used as labels
11185 and local variables declared here might not be accessible to any
11186 code that is part of an anonymous method.
11188 Exceptions to this include the temporary variables that are
11189 created by some statements internally for holding temporary
11192 (EmitContext.EmitMeta): New routine, in charge of emitting all the
11195 (EmitContext.TemporaryReturn): This method is typically called
11196 from the Emit phase, and its the only place where we allow the
11197 ReturnLabel to be defined other than the EmitMeta. The reason is
11198 that otherwise we would have to duplicate a lot of logic in the
11199 Resolve phases of various methods that today is on the Emit
11202 (EmitContext.NeedReturnLabel): This no longer creates the label,
11203 as the ILGenerator is not valid during the resolve phase.
11205 (EmitContext.EmitThis): Extended the knowledge in this class to
11206 work in anonymous methods in addition to iterators.
11208 (EmitContext.EmitCapturedVariableInstance): This emits whatever
11209 code is necessary on the stack to access the instance to a local
11210 variable (the variable will be accessed as a field).
11212 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
11213 EmitContext.EmitAddressOfParameter): Routines to support
11214 parameters (not completed at this point).
11216 Removals: Removed RemapLocal and RemapLocalLValue. We probably
11217 will also remove the parameters.
11219 * convert.cs (Convert): Define a `ConstantEC' which points to a
11220 null. This is just to prefity some code that uses
11221 ImplicitStandardConversion code and do not have an EmitContext
11224 The idea is to flag explicitly that at that point in time, it is
11225 known that the conversion will not trigger the delegate checking
11226 code in implicit conversions (which requires a valid
11229 Everywhere: pass new EmitContext parameter since
11230 ImplicitStandardConversionExists now requires it to check for
11231 anonymous method conversions.
11233 (Convert.ImplicitStandardConversionExists): If the type of an
11234 expression is the anonymous_method_type, and the type is a
11235 delegate, we invoke the AnonymousMethod.Compatible method to check
11236 whether an implicit conversion is possible.
11238 (Convert.ImplicitConversionStandard): Only do implicit method
11239 group conversions if the language level is not ISO_1.
11241 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
11242 MethodInfo for the Invoke method. used by Delegate and
11245 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
11246 method conversions if the target type is a delegate.
11248 Removed extra debugging nops.
11250 (LocalVariableReference): Turn the `local_info' into a public
11253 Add `prepared' field, the same hack used for FieldExprs to cope
11254 with composed assignments, as Local variables do not necessarily
11255 operate purely on the stack as they used to: they can be captured
11258 Add `temp' for a temporary result, like fields.
11260 Refactor DoResolve and DoResolveLValue into DoResolveBase.
11262 It now copes with Local variables that are captured and emits the
11263 proper instance variable to load it from a field in the captured
11266 (ParameterReference.DoResolveBase): During the resolve phase,
11267 capture parameters if we are in an anonymous method.
11269 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
11270 anonymous method, use the EmitContext helper routines to emit the
11271 parameter reference.
11273 * iterators.cs: Set RemapToProxy to true/false during the
11276 * parameters.cs (GetParameterByName): New helper method.
11278 * typemanager.cs (anonymous_method_type) a new type that
11279 represents an anonyous method. This is always an internal type,
11280 used as a fencepost to test against the anonymous-methodness of an
11283 2004-10-20 Marek Safar <marek.safar@seznam.cz>
11285 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
11287 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
11289 2004-10-18 Martin Baulig <martin@ximian.com>
11291 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
11292 `Type' directly, but call ResolveType() on it.
11293 (Catch.Resolve): Likewise.
11294 (Foreach.Resolve): Likewise.
11296 2004-10-18 Martin Baulig <martin@ximian.com>
11298 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
11299 `Type' directly, but call ResolveType() on it.
11300 (Probe.DoResolve): Likewise.
11301 (ArrayCreation.LookupType): Likewise.
11302 (TypeOf.DoResolve): Likewise.
11303 (SizeOf.DoResolve): Likewise.
11305 2004-10-18 Martin Baulig <martin@ximian.com>
11307 * expression.cs (Invocation.BetterFunction): Put back
11308 TypeManager.TypeToCoreType().
11310 2004-10-18 Raja R Harinath <rharinath@novell.com>
11312 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
11315 2004-10-18 Martin Baulig <martin@ximian.com>
11317 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
11318 `Type' directly, but call ResolveType() on it.
11320 2004-10-18 Martin Baulig <martin@ximian.com>
11322 * class.cs (FieldMember.Define): Don't access the TypeExpr's
11323 `Type' directly, but call ResolveType() on it.
11324 (MemberBase.DoDefine): Likewise.
11326 * expression.cs (New.DoResolve): Don't access the TypeExpr's
11327 `Type' directly, but call ResolveType() on it.
11328 (ComposedCast.DoResolveAsTypeStep): Likewise.
11330 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
11331 `Type' directly, but call ResolveType() on it.
11333 2004-10-17 John Luke <john.luke@gmail.com>
11335 * class.cs (Operator.GetSignatureForError): use CSharpName
11337 * parameter.cs (Parameter.GetSignatureForError): Returns
11338 correct name even if was not defined.
11340 2004-10-13 Raja R Harinath <rharinath@novell.com>
11343 * class.cs (TypeContainer.EmitContext): New property.
11344 (DefineNestedTypes): Create an emitcontext for each part.
11345 (MethodCore.DoDefineParameters): Use container's emitcontext.
11346 Pass type array to InternalParameters.
11347 (MemberBase.DoDefine): Use container's emitcontext.
11348 (FieldMember.Define): Likewise.
11349 (Event.Define): Likewise.
11350 (SetMethod.GetParameterInfo): Change argument to EmitContext.
11351 Pass type array to InternalParameters.
11352 (SetIndexerMethod.GetParameterInfo): Likewise.
11353 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
11354 * delegate.cs (Define): Pass emitcontext to
11355 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
11356 array to InternalParameters.
11357 * expression.cs (ParameterReference.DoResolveBase): Pass
11358 emitcontext to GetParameterInfo.
11359 (ComposedCast.DoResolveAsTypeStep): Remove check on
11360 ec.ResolvingTypeTree.
11361 * parameter.cs (Parameter.Resolve): Change argument to
11362 EmitContext. Use ResolveAsTypeTerminal.
11363 (Parameter.GetSignature): Change argument to EmitContext.
11364 (Parameters.ComputeSignature): Likewise.
11365 (Parameters.ComputeParameterTypes): Likewise.
11366 (Parameters.GetParameterInfo): Likewise.
11367 (Parameters.ComputeAndDefineParameterTypes): Likewise.
11368 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
11369 * support.cs (InternalParameters..ctor): Remove variant that takes
11371 * typemanager.cs (system_intptr_expr): New.
11372 (InitExpressionTypes): Initialize it.
11374 2004-10-12 Chris Toshok <toshok@ximian.com>
11376 * cs-parser.jay: fix location for try_statement and catch_clause.
11378 2004-10-11 Martin Baulig <martin@ximian.com>
11380 * report.cs: Don't make --fatal abort on warnings, we have
11381 -warnaserror for that.
11383 2004-10-07 Raja R Harinath <rharinath@novell.com>
11385 More DeclSpace.ResolveType avoidance.
11386 * decl.cs (MemberCore.InUnsafe): New property.
11387 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
11388 with newly created EmitContext.
11389 (FieldMember.Define): Likewise.
11390 * delegate.cs (Delegate.Define): Likewise.
11391 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
11392 only if normal name-lookup fails.
11393 (TypeExpr.DoResolve): Enable error-checking.
11394 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
11395 (SizeOf.DoResolve): Likewise.
11396 (ComposedCast.DoResolveAsTypeStep): Likewise.
11397 (StackAlloc.DoResolve): Likewise.
11398 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
11399 (Block.Unsafe): New property.
11400 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
11401 (Unsafe): Set 'unsafe' flag of contained block.
11402 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
11403 (Fixed.Resolve): Likewise.
11404 (Catch.Resolve): Likewise.
11405 (Using.ResolveLocalVariableDecls): Likewise.
11406 (Foreach.Resolve): Likewise.
11408 2004-10-05 John Luke <john.luke@gmail.com>
11410 * cs-parser.jay: add location to error CS0175
11412 2004-10-04 Miguel de Icaza <miguel@ximian.com>
11414 * ecore.cs (Expression.Constantity): Add support for turning null
11417 * const.cs (Const.Define): Allow constants to be reference types
11418 as long as the value is Null.
11420 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
11422 * namespace.cs (NamespaceEntry.Using): No matter which warning
11423 level is set, check if this namespace name has already been added.
11425 2004-10-03 Ben Maurer <bmaurer@ximian.com>
11427 * expression.cs: reftype [!=]= null should always use br[true,false].
11430 2004-10-03 Marek Safar <marek.safar@seznam.cz>
11433 * attribute.cs: Enum conversion moved to
11434 GetAttributeArgumentExpression to be applied to the all
11437 2004-10-01 Raja R Harinath <rharinath@novell.com>
11439 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
11440 * class.c (TypeContainer.DefineType): Flag error if
11441 base types aren't accessible due to access permissions.
11442 * decl.cs (DeclSpace.ResolveType): Move logic to
11443 Expression.ResolveAsTypeTerminal.
11444 (DeclSpace.ResolveTypeExpr): Thin layer over
11445 Expression.ResolveAsTypeTerminal.
11446 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
11447 Refactor code into NestedAccess. Use it.
11448 (DeclSpace.NestedAccess): New.
11449 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
11450 argument to silence errors. Check access permissions.
11451 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
11452 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
11453 (Cast.DoResolve): Likewise.
11454 (New.DoResolve): Likewise.
11455 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
11456 (TypeOf.DoResolve): Likewise.
11458 * expression.cs (Invocation.BetterConversion): Return the Type of
11459 the better conversion. Implement section 14.4.2.3 more faithfully.
11460 (Invocation.BetterFunction): Make boolean. Make correspondence to
11461 section 14.4.2.2 explicit.
11462 (Invocation.OverloadResolve): Update.
11463 (Invocation): Remove is_base field.
11464 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
11465 (Invocation.Emit): Likewise.
11467 2004-09-27 Raja R Harinath <rharinath@novell.com>
11469 * README: Update to changes.
11471 2004-09-24 Marek Safar <marek.safar@seznam.cz>
11473 * cs-parser.jay: Reverted 642 warning fix.
11475 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11478 * decl.cs (FindMemberWithSameName): Indexer can have more than
11481 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11483 * expression.cs (LocalVariableReference.DoResolveLValue):
11484 Do not report warning 219 for out values.
11485 (EmptyExpression.Null): New member to avoid extra allocations.
11487 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11489 * cs-parser.jay: Fix wrong warning 642 report.
11491 * cs-tokenizer.cs (CheckNextToken): New helper;
11492 Inspect next character if is same as expected.
11494 2004-09-23 Martin Baulig <martin@ximian.com>
11496 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
11497 (Convert.ImplicitReferenceConversionExists): Likewise.
11499 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11501 * class.cs (Operator.Define): Add error 448 and 559 report.
11503 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11505 * class.cs (MemberBase.IsTypePermitted): New protected
11506 method for checking error CS0610.
11508 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11510 * class.cs (TypeContainer.HasExplicitLayout): New property
11511 Returns whether container has StructLayout attribute set Explicit.
11512 (FieldMember): New abstract class for consts and fields.
11513 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
11514 (Field): Reuse FieldMember.
11516 * const.cs (Const): Reuse FieldMember.
11518 * rootcontext.cs: EmitConstants call moved to class.
11520 2004-09-22 Martin Baulig <martin@ximian.com>
11522 Thanks to Peter Sestoft for this bug report.
11524 * expression.cs (Conditional): If both the `trueExpr' and the
11525 `falseExpr' is a NullLiteral, return a NullLiteral.
11527 2004-09-22 Martin Baulig <martin@ximian.com>
11529 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
11530 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
11531 for the "get_Current" call.
11533 2004-09-22 Martin Baulig <martin@ximian.com>
11535 Marek and me just fixed one of our oldest bugs: #28562 :-)
11537 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
11539 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
11540 we're an EnumConstant, just return that.
11541 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
11542 an EnumConstant. In this case, we need to use GetValueAsEnumType()
11543 to get the value which'll actually be written into the attribute.
11544 However, we have to use GetValue() to access the attribute's value
11547 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11549 * constant.cs (Constant.IsNegative): New abstract property
11552 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
11553 (StackAlloc.DoResolve): Reused IsNegative.
11555 2004-09-21 Martin Baulig <martin@ximian.com>
11557 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
11558 if we're used in an iterator, we may be called from different
11561 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
11562 we actually have an exception block.
11564 2004-09-20 John Luke <jluke@cfl.rr.com>
11566 * class.cs, cs-parser.jay: Improve the error report for 1520:
11567 report the actual line where the error happens, not where the
11568 class was declared.
11570 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
11571 Pass location information that was available elsewhere.
11573 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
11575 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
11576 runtime to delay sign assemblies.
11578 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11580 * cs-parser.jay: Do not report the stack trace, this is barely
11583 2004-08-22 John Luke <john.luke@gmail.com>
11585 * driver.cs : check that a resource id is not already used
11586 before adding it, report CS1508 if it is, bug #63637
11588 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11590 * ecore.cs: Removed dead code.
11592 2004-09-18 Marek Safar <marek.safar@seznam.cz>
11594 * class.cs: Do not report warning CS0067 on the interfaces.
11596 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11598 * cs-parser.jay: Add error 504 report.
11600 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11602 * rootcontext.cs: WarningLevel is 4 by default now.
11604 * statement.cs (Fixed.Resolve): Do not null
11607 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11610 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
11611 deep search when property is not virtual.
11612 (PropertyExpr.ResolveAccessors): Make one call for both
11615 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11618 * statement.cs: Error 152 report constains also location.
11620 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11623 * const.cs: Explicitly set constant as static.
11625 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11628 * cs-parser.jay: Add error 1017 report.
11630 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11632 Fixed bug #59980, #64224
11633 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
11635 * typemanager.cs (IsSpecialMethod): Simplified
11637 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11639 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
11640 condition with better params.
11642 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11645 * attribute.cs (Resolve): Property has to have both
11648 2004-09-14 Martin Baulig <martin@ximian.com>
11650 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
11652 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11655 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
11656 called and is obsolete then this member suppress message
11657 when call is inside next [Obsolete] method or type.
11659 * expression.cs: Use TestObsoleteMethodUsage member.
11661 2004-09-14 Martin Baulig <martin@ximian.com>
11663 * cs-parser.jay: Sync a bit with the GMCS version.
11665 2004-09-14 Martin Baulig <martin@ximian.com>
11667 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
11668 (CSharpParser.yacc_verbose_flag): New public field.
11670 * genericparser.cs: Removed.
11672 2004-09-14 Raja R Harinath <rharinath@novell.com>
11674 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
11676 2004-09-13 Marek Safar <marek.safar@seznam.cz>
11678 * class.cs (MethodCore.CheckBase): Fix bug #65757.
11680 2004-09-10 Martin Baulig <martin@ximian.com>
11682 Backported my MemberName changes from GMCS into MCS.
11684 - we are now using a special `MemberName' class instead of using
11685 strings; in GMCS, the `MemberName' also contains the type
11688 - changed the grammar rules a bit:
11689 * the old `member_name' is now a `namespace_or_type_name':
11690 The rule is that we use `namespace_or_type_name' everywhere
11691 where we expect either a "member name" (GetEnumerator) or a
11692 "member name" with an explicit interface name
11693 (IEnumerable.GetEnumerator).
11694 In GMCS, the explicit interface name may include type arguments
11695 (IEnumerable<T>.GetEnumerator).
11696 * we use `member_name' instead of just `IDENTIFIER' for
11698 The rule is that we use `member_name' wherever a member may
11699 have type parameters in GMCS.
11701 * decl.cs (MemberName): New public class.
11702 (MemberCore.MemberName): New public readonly field.
11703 (MemberCore.ctor): Take a `MemberName' argument, not a string.
11704 (DeclSpace): Likewise.
11706 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
11707 * enum.cs (Enum.ctor): Likewise.
11709 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
11711 (AliasEntry.ctor): Take a MemberName, not an Expression.
11712 (AliasEntry.UsingAlias): Likewise.
11714 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
11715 (IMethodData.MemberName): Changed type from string to MemberName.
11716 (MemberBase.ExplicitInterfaceName): Likewise.
11717 (AbstractPropertyEventMethod.SetupName): Make this private.
11718 (AbstractPropertyEventMethod.ctor): Added `string prefix'
11719 argument; compute the member name here.
11720 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
11721 on the `member.MemberName' and the `prefix'.
11723 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
11725 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
11726 thus, we get a `MemberName' instead of a `string'. These
11727 declarations may have type parameters in GMCS.
11728 (interface_method_declaration, delegate_declaration): Likewise.
11729 (class_declaration, interface_declaration): Likewise.
11730 (method_header): Use `namespace_or_type_name' instead of
11731 `member_name'. We may be an explicit interface implementation.
11732 (property_declaration, event_declaration): Likewise.
11733 (member_name): This is now just an `IDENTIFIER', not a
11734 `namespace_or_type_name'.
11735 (type_name, interface_type): Removed.
11736 (namespace_or_type_name): Return a MemberName, not an Expression.
11737 (primary_expression): Use `member_name' instead of `IDENTIFIER';
11738 call GetTypeExpression() on the MemberName to get an expression.
11739 (IndexerDeclaration.interface_type): Changed type from string to
11741 (MakeName): Operate on MemberName's instead of string's.
11743 2004-09-13 Raja R Harinath <rharinath@novell.com>
11746 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
11747 (NamespaceEntry.Lookup): Add new argument to flag if we want the
11748 lookup to avoid symbols introduced by 'using'.
11749 * rootcontext.cs (NamespaceLookup): Update.
11751 2004-09-12 Marek Safar <marek.safar@seznam.cz>
11753 * class.cs (TypeContainer.DoDefineMembers): Do not call
11754 DefineDefaultConstructor for static classes.
11756 2004-09-12 Marek Safar <marek.safar@seznam.cz>
11758 * attribute.cs (Attribute.Resolve): Add error 653 report.
11760 * class.cs (Class.ApplyAttributeBuilder): Add error 641
11762 (Method.ApplyAttributeBuilder): Add error 685 report.
11763 (Operator.Define): Add error 564 report.
11765 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
11767 * expression.cs (Invocation.DoResolve): Add error
11768 245 and 250 report.
11770 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
11773 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11775 * class.cs (ConstructorInitializer.Resolve):
11776 Wrong error number (515->516).
11778 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11780 * class.cs (Indexer.Define): Add error 631 report.
11782 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11784 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
11786 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11788 * expression.cs (Probe.DoResolve): Add error CS0241 report.
11790 2004-09-10 Marek Safar <marek.safar@seznam.cz>
11792 * cs-parser.jay: Added error CS0241 report.
11794 2004-09-10 Raja R Harinath <rharinath@novell.com>
11796 * cs-parser.jay (fixed_statement): Introduce a scope for the
11797 declaration in the 'fixed' statement.
11799 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11801 * cs-parser.jay: Added CS0230 error report.
11803 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11805 * cs-parser.jay: Added errors CS0231 and CS0257 report.
11807 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11809 * expression.cs (Argument.Resolve): Added error CS0192 and
11812 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11814 C# 2.0 #pragma warning feature
11816 * cs-tokenizer.cs (PreProcessPragma): New method;
11817 Handles #pragma directive.
11819 * report.cs (WarningRegions): New class; Support
11820 class for #pragma warning directive. It tests whether
11821 warning is enabled for a given line.
11823 2004-09-08 Miguel de Icaza <miguel@ximian.com>
11825 * const.cs: Add more descriptive error report, tahnks to
11828 2004-09-08 Marek Safar <marek.safar@seznam.cz>
11830 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
11832 2004-09-07 Miguel de Icaza <miguel@ximian.com>
11834 * expression.cs: Apply patch from Ben: Remove dead code from
11835 ArrayCreation, and remove the TurnintoConstant call in const.cs,
11836 as that code just threw an exception anwyays.
11838 * const.cs: Remove the call to the turnintoconstant, for details
11841 * literal.cs: The type of the null-literal is the null type; So
11842 we use a placeholder type (literal.cs:System.Null, defined here)
11845 * expression.cs (Conditional.DoResolve): Remove some old code that
11846 is no longer needed, conversions have been fixed.
11848 (ArrayCreationExpression.DoResolve): Return false if we fail to
11849 resolve the inner expression.
11851 2004-09-07 Raja R Harinath <rharinath@novell.com>
11854 * cs-parser.jay (delegate_declaration): Record a delegate
11855 declaration as a type declaration.
11856 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
11858 2004-09-06 Miguel de Icaza <miguel@ximian.com>
11860 * parameter.cs: Do not crash if the type can not be resolved.
11862 * expression.cs: Report errors with unsafe pointers, fixes #64896
11864 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
11866 * expression.cs: Pointer arith always needs to do a conv.i
11867 if the operand is a long. fix 65320
11869 2004-09-04 Marek Safar <marek.safar@seznam.cz>
11871 Fixed cs0619-37.cs, cs0619-38.cs
11873 * enum.cs (GetObsoleteAttribute): Removed.
11875 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
11876 on Enum member is double staged. The first is tested member
11879 2004-09-04 Marek Safar <marek.safar@seznam.cz>
11881 Fixed #56986, #63631, #65231
11883 * class.cs: (TypeContainer.AddToMemberContainer): New method,
11884 adds member to name container.
11885 (TypeContainer.AddToTypeContainer): New method, adds type to
11887 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
11888 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
11889 AddOperator): Simplified by reusing AddToMemberContainer.
11890 (TypeContainer.UserDefinedStaticConstructor): Changed to property
11892 (Method.CheckForDuplications): Fixed implementation to test all
11894 (MemberBase): Detection whether member is explicit interface
11895 implementation is now in constructor.
11896 (MemberBase.UpdateMemberName): Handles IndexerName.
11897 (Accessor): Changed to keep also location information.
11898 (AbstractPropertyEventMethod): Is derived from MemberCore.
11899 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
11900 will be emited or not.
11901 (PropertyBase.AreAccessorsDuplicateImplementation):
11902 Tests whether accessors are not in collision with some method.
11903 (Operator): Is derived from MethodCore to simplify common
11906 * decl.cs (Flags.TestMethodDuplication): Test for duplication
11908 (DeclSpace.AddToContainer): Adds the member to defined_names
11909 table. It tests for duplications and enclosing name conflicts.
11911 * enum.cs (EnumMember): Clean up to reuse the base structures
11913 2004-09-03 Martin Baulig <martin@ximian.com>
11915 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
11916 into TypeContainer, to make partial classes work again.
11918 2004-09-03 Martin Baulig <martin@ximian.com>
11920 * rootcontext.cs (RootContext.V2): Removed.
11922 2004-03-23 Martin Baulig <martin@ximian.com>
11924 * expression.cs (Invocation.OverloadResolve): Added `bool
11925 may_fail' argument and use it instead of the Location.IsNull() hack.
11927 2004-09-03 Martin Baulig <martin@ximian.com>
11929 Merged latest changes into gmcs. Please keep this comment in
11930 here, it makes it easier for me to see what changed in MCS since
11931 the last time I merged.
11933 2004-09-03 Raja R Harinath <rharinath@novell.com>
11936 * expression.cs (BetterConversion): Don't allow either conversion
11937 to be null. Remove redundant implicit conversion test when 'q ==
11938 null' -- when this function is invoked, we already know that the
11939 implicit conversion exists.
11940 (BetterFunction): Assume that 'best' is non-null. Remove
11941 redundant reimplementation of IsApplicable when 'best' is null.
11942 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
11943 number of arguments.
11944 (IsAncestralType): Extract from OverloadResolve.
11945 (OverloadResolve): Make robust to the MethodGroupExpr being
11946 unsorted. Implement all the logic of Section 14.5.5.1, and
11947 support overloading of methods from multiple applicable types.
11948 Clean up logic somewhat. Don't pass null methods to BetterFunction.
11950 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
11951 (RealError, Warning): Append type of report to related symbol.
11953 2004-09-03 Marek Safar <marek.safar@seznam.cz>
11955 * enum.cs: Fixed CLS-Compliance checks for enum members.
11956 Error tests cs3008-8.cs, cs3014-8.cs
11958 2004-09-02 Marek Safar <marek.safar@seznam.cz>
11960 Fixed bug #62342, #63102
11961 * class.cs: ImplementIndexer uses member.IsExplicitImpl
11962 like ImplementMethod.
11964 2004-09-02 Marek Safar <marek.safar@seznam.cz>
11966 * attribute.cs (Attribute.GetAttributeArgumentExpression):
11969 2004-09-02 Martin Baulig <martin@ximian.com>
11971 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
11972 TypeManager.GetArgumentTypes() rather than calling GetParameters()
11975 2004-09-01 Marek Safar <marek.safar@seznam.cz>
11977 C# 2.0 Static classes implemented
11979 * class.cs (TypeContainer): instance_constructors,
11980 initialized_fields, initialized_static_fields,
11981 default_constructor, base_inteface_types are protected to be
11982 accessible from StaticClass.
11983 (TypeContainer.DefineDefaultConstructor): New virtual method
11984 for custom default constructor generating
11985 (StaticClass): New class to handle "Static classes" feature.
11987 * cs-parser.jay: Handle static keyword on class like instance
11990 * driver.cs: Added "/langversion" command line switch with two
11991 options (iso-1, default).
11993 2004-08-31 Marek Safar <marek.safar@seznam.cz>
11995 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
11997 2004-08-31 Miguel de Icaza <miguel@ximian.com>
11999 * delegate.cs: Style.
12001 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
12003 * delegate.cs: Add seperate instance expr field for miguel.
12005 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
12007 * PointerArithmetic (Resolve): make sure we are not doing
12008 pointer arith on void*. Also, make sure we are resolved
12009 by not setting eclass until resolve.
12011 All callers: Make sure that PointerArithmetic gets resolved.
12013 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
12015 * ArrayCreation (LookupType): If the type does not resolve
12016 to an array, give an error.
12018 2004-08-27 Marek Safar <marek.safar@seznam.cz>
12020 * statement.cs (Try.Resolve): Fixed bug #64222
12022 2004-08-27 Martin Baulig <martin@ximian.com>
12025 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
12028 2004-08-26 Marek Safar <marek.safar@seznam.cz>
12030 * ecore.cs (Constantify): Get underlying type via
12031 System.Enum.GetUnderlyingType to avoid StackOverflow on the
12032 Windows in special cases.
12034 2004-08-26 Marek Safar <marek.safar@seznam.cz>
12036 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
12037 for obtaining also private methods.
12038 (GetRemoveMethod): Used GetRemoveMethod (true)
12039 for obtaining also private methods.
12041 2004-08-24 Martin Baulig <martin@ximian.com>
12043 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
12044 MethodAttributes.HideBySig for operators.
12046 2004-08-23 Martin Baulig <martin@ximian.com>
12048 Back to the old error reporting system :-)
12050 * report.cs (Message): Removed.
12051 (Report.MessageData, ErrorData, WarningData): Removed.
12052 (Report.Error, Warning): Back to the old system.
12054 2004-08-23 Martin Baulig <martin@ximian.com>
12056 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
12058 * class.cs (TypeContainer.ParentContainer): New public virtual
12059 method; replaces the explicit interface implementation.
12060 (ClassPart.ParentContainer): Override.
12062 2004-08-23 Martin Baulig <martin@ximian.com>
12064 * statement.cs (Switch): Added support for constant switches; see
12065 #59428 or test-285.cs.
12067 2004-08-22 Marek Safar <marek.safar@seznam.cz>
12070 * statement.cs (GetEnumeratorFilter): Removed useless
12071 logic because C# specs is strict. GetEnumerator must be
12074 2004-08-22 Martin Baulig <martin@ximian.com>
12076 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
12077 a switch and may break, reset the barrier. Fixes #59867.
12079 2004-08-22 Marek Safar <marek.safar@seznam.cz>
12081 CLS-Compliance speed up (~5% for corlib)
12083 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
12084 New method. Tests container for CLS-Compliant names
12086 * class.cs (TypeContainer.VerifyClsName): New method.
12087 Checks whether container name is CLS Compliant.
12088 (Constructor): Implements IMethodData.
12090 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
12091 low-case table for CLS Compliance test.
12092 (MemberCache.VerifyClsParameterConflict): New method.
12093 Checks method parameters for CS3006 error.
12095 * enum.cs (EnumMember): Is derived from MemberCore.
12096 (Enum.VerifyClsName): Optimized for better performance.
12098 2004-08-06 Marek Safar <marek.safar@seznam.cz>
12100 * report.cs: Renamed Error_T to Error and changed all
12103 2004-08-06 Marek Safar <marek.safar@seznam.cz>
12105 * class.cs (TypeContainer.IndexerArrayList): New inner class
12106 container for indexers.
12107 (TypeContainer.DefaultIndexerName): New constant for default
12108 indexer name. Replaced all "Item" with this constant.
12109 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
12111 * typemanager.cs (TypeManager.default_member_ctor): Cache here
12112 DefaultMemberAttribute constructor.
12114 2004-08-05 Martin Baulig <martin@ximian.com>
12116 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
12119 2004-08-05 Marek Safar <marek.safar@seznam.cz>
12121 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
12122 multi platforms problem.
12124 * compiler.csproj: Included shared files.
12126 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12128 Fix bug 60333, 55971 in the more general way
12129 * attribute.cs (Attribute.GetAttributeArgumentExpression):
12130 Added arg_type argument for constant conversion.
12131 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
12133 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12136 * class.cs (TypeContainer ): New inner classes MethodArrayList,
12137 OperatorArrayList, MethodCoreArrayList for typecontainer
12138 containers. Changed class member types to these new types.
12139 (MethodArrayList.DefineMembers): Added test for CS0659.
12141 2004-08-04 Miguel de Icaza <miguel@ximian.com>
12143 * cfold.cs: Synchronize the folding with the code in expression.cs
12144 Binary.DoNumericPromotions for uint operands.
12146 * attribute.cs: Revert patch from Raja, it introduced a regression
12147 while building Blam-1.2.1 (hard to isolate a test case).
12149 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12153 (TypeContainer.Define): Renamed to DefineContainerMembers because of
12155 (MethodCore.parent_method): New member. The method we're overriding
12156 if this is an override method.
12157 (MethodCore.CheckBase): Moved from Method class and made common.
12158 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
12160 (MethodCore.CheckForDuplications): New abstract method. For custom
12161 member duplication search in a container
12162 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
12163 method and its return type.
12164 (Event.conflict_symbol): New member. Symbol with same name in the
12168 (MemberCache.FindMemberWithSameName): New method. The method
12169 is looking for conflict with inherited symbols.
12171 2004-08-04 Martin Baulig <martin@ximian.com>
12173 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
12175 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
12177 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12179 * report.cs (Message): New enum for better error, warning reference in
12181 (MessageData): New inner abstract class. It generally handles printing of
12182 error and warning messages.
12183 Removed unused Error, Warning, Message methods.
12185 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12187 Fix for cs0592-8.cs test
12189 (Attributable.ValidAttributeTargets): Made public.
12190 (Attribute.ExplicitTarget): New member for explicit target value.
12191 (Attribute.CheckTargets): Now we translate explicit attribute
12192 target to Target here.
12194 2004-08-03 Ben Maurer <bmaurer@ximian.com>
12196 * ecore.cs (MethodGroupExpr): new IsBase property.
12198 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
12200 * delegate.cs (DelegateCreation): store a MethodGroupExpr
12201 rather than an instance expr.
12203 (DelegateCreation.Emit): Use the method group rather than
12204 the instance expression. Also, if you have base.Foo as the
12205 method for a delegate, make sure to emit ldftn, not ldftnvirt.
12207 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
12209 (NewDelegate.DoResolve): Only check for the existance of Invoke
12210 if the method is going to be needed. Use MethodGroupExpr.
12212 (NewDelegate.Emit): Remove, DelegateCreation implements this.
12214 * expression.cs: For pointer arith., make sure to use
12215 the size of the type, not the size of the pointer to
12218 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12221 * class.cs (Class): Added error CS0502 test.
12223 2004-08-03 John Luke <jluke@cfl.rr.com>
12224 Raja R Harinath <rharinath@novell.com>
12227 * attribute.cs (Attribute.complained_before): New flag.
12228 (Attribute.ResolveType, Attribute.Resolve),
12229 (Attribute.DefinePInvokeMethod): Set it.
12230 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
12232 2004-08-03 Martin Baulig <martin@ximian.com>
12234 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
12235 use a user-defined operator; we still need to do numeric
12236 promotions in case one argument is a builtin type and the other
12237 one has an implicit conversion to that type. Fixes #62322.
12239 2004-08-02 Martin Baulig <martin@ximian.com>
12241 * statement.cs (LocalInfo.Flags): Added `IsThis'.
12242 (LocalInfo.IsThis): New public property.
12243 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
12245 2004-08-01 Martin Baulig <martin@ximian.com>
12247 * class.cs (TypeContainer.GetClassBases): Don't set the default
12248 here since we may get called from GetPartialBases().
12249 (TypeContainer.DefineType): If GetClassBases() didn't return a
12250 parent, use the default one.
12252 2004-07-30 Duncan Mak <duncan@ximian.com>
12254 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
12256 2004-07-30 Martin Baulig <martin@ximian.com>
12258 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
12260 * class.cs (SourceMethod): New public class, derive from the
12261 symbol writer's ISourceMethod.
12262 (Method): Use the new symbol writer API.
12264 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
12265 as argument and use the new symbol writer.
12268 (SourceFile): Implement the symbol writer's ISourceFile.
12269 (Location.SymbolDocument): Removed.
12270 (Location.SourceFile): New public property.
12272 * symbolwriter.cs: Use the new symbol writer API.
12274 2004-07-30 Raja R Harinath <rharinath@novell.com>
12276 * Makefile (install-local): Remove. Functionality moved to
12279 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
12281 * Makefile: Install mcs.exe.config file together with mcs.exe.
12282 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
12283 correct runtime version.
12285 2004-07-25 Martin Baulig <martin@ximian.com>
12288 (TypeContainer.RegisterOrder): Removed, this was unused.
12289 (TypeContainer, interface_order): Removed.
12290 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
12291 TypeContainer as argument since we can also be called with a
12292 `PartialContainer' for a partial class/struct/interface.
12293 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
12294 of checking whether we're an `Interface' - we could be a
12295 `PartialContainer'.
12296 (PartialContainer.Register): Override; call
12297 AddClass()/AddStruct()/AddInterface() on our parent.
12299 * cs-parser.jay (interface_member_declaration): Add things to the
12300 `current_container', not the `current_class'.
12302 * rootcontext.cs (RegisterOrder): The overloaded version which
12303 takes an `Interface' was unused, removed.
12305 * typemanager.cs (TypeManager.LookupInterface): Return a
12306 `TypeContainer', not an `Interface'.
12307 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
12308 contain a `PartialContainer' for an interface, so check it's
12309 `Kind' to figure out what it is.
12311 2004-07-25 Martin Baulig <martin@ximian.com>
12313 * class.cs (Class.DefaultTypeAttributes): New public constant.
12314 (Struct.DefaultTypeAttributes): Likewise.
12315 (Interface.DefaultTypeAttributes): Likewise.
12316 (PartialContainer.TypeAttr): Override this and add the
12317 DefaultTypeAttributes.
12319 2004-07-25 Martin Baulig <martin@ximian.com>
12321 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
12322 we can just use the `Parent' field instead.
12324 2004-07-25 Martin Baulig <martin@ximian.com>
12326 * class.cs (TypeContainer.Emit): Renamed to EmitType().
12328 2004-07-25 Martin Baulig <martin@ximian.com>
12330 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
12331 our parts before defining any methods.
12332 (TypeContainer.VerifyImplements): Make this virtual.
12333 (ClassPart.VerifyImplements): Override and call VerifyImplements()
12334 on our PartialContainer.
12336 2004-07-25 Martin Baulig <martin@ximian.com>
12338 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
12340 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
12341 argument, we can just use the `Parent' field instead.
12344 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
12345 (MemberBase.DoDefine): Likewise.
12347 2004-07-24 Martin Baulig <martin@ximian.com>
12349 * decl.cs (MemberCore.Parent): New public field.
12350 (DeclSpace.Parent): Moved to MemberCore.
12352 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
12353 (MemberBase.ctor): Added TypeContainer argument, pass it to our
12355 (FieldBase, Field, Operator): Likewise.
12356 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
12357 (EventField, Event): Likewise.
12359 2004-07-23 Martin Baulig <martin@ximian.com>
12361 * class.cs (PartialContainer): New public class.
12362 (ClassPart): New public class.
12363 (TypeContainer): Added support for partial classes.
12364 (TypeContainer.GetClassBases): Splitted some of the functionality
12365 out into GetNormalBases() and GetPartialBases().
12367 * cs-tokenizer.cs (Token.PARTIAL): New token.
12368 (Tokenizer.consume_identifier): Added some hacks to recognize
12369 `partial', but only if it's immediately followed by `class',
12370 `struct' or `interface'.
12372 * cs-parser.jay: Added support for partial clases.
12374 2004-07-23 Martin Baulig <martin@ximian.com>
12376 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
12377 a `DeclSpace' and also made it readonly.
12378 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
12379 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
12380 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
12382 * cs-parser.jay: Pass the `current_class', not the
12383 `current_container' (at the moment, this is still the same thing)
12384 to a new Method, Property, Event, Indexer or Constructor.
12386 2004-07-23 Martin Baulig <martin@ximian.com>
12388 * cs-parser.jay (CSharpParser): Added a new `current_class' field
12389 and removed the `current_interface' one.
12390 (struct_declaration, class_declaration, interface_declaration):
12391 Set `current_class' to the newly created class/struct/interface;
12392 set their `Bases' and call Register() before parsing their body.
12394 2004-07-23 Martin Baulig <martin@ximian.com>
12396 * class.cs (Kind): New public enum.
12397 (TypeContainer): Made this class abstract.
12398 (TypeContainer.Kind): New public readonly field.
12399 (TypeContainer.CheckDef): New public method; moved here from
12401 (TypeContainer.Register): New public abstract method.
12402 (TypeContainer.GetPendingImplementations): New public abstract
12404 (TypeContainer.GetClassBases): Removed the `is_class' and
12405 `is_iface' parameters.
12406 (TypeContainer.DefineNestedTypes): Formerly known as
12408 (ClassOrStruct): Made this class abstract.
12410 * tree.cs (RootTypes): New public type.
12412 2004-07-20 Martin Baulig <martin@ximian.com>
12414 * tree.cs (Tree.RecordNamespace): Removed.
12415 (Tree.Namespaces): Removed.
12417 * rootcontext.cs (RootContext.IsNamespace): Removed.
12419 * cs-parser.jay (namespace_declaration): Just create a new
12420 NamespaceEntry here.
12422 2004-07-20 Martin Baulig <martin@ximian.com>
12424 * statement.cs (ExceptionStatement): New abstract class. This is
12425 now used as a base class for everyone who's using `finally'.
12426 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
12427 our local variables before using them.
12429 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
12430 virtual method. This is used by Yield.Resolve() to "steal" an
12431 outer block's `finally' clauses.
12432 (FlowBranchingException): The .ctor now takes an ExceptionStatement
12435 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
12436 version which takes an ExceptionStatement. This version must be
12437 used to create exception branchings.
12440 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
12441 (Iterator.EmitMoveNext): Added exception support; protect the
12442 block with a `fault' clause, properly handle 'finally' clauses.
12443 (Iterator.EmitDispose): Run all the `finally' clauses here.
12445 2004-07-20 Martin Baulig <martin@ximian.com>
12447 * iterator.cs: This is the first of a set of changes in the
12448 iterator code. Match the spec more closely: if we're an
12449 IEnumerable, then GetEnumerator() must be called. The first time
12450 GetEnumerator() is called, it returns the current instance; all
12451 subsequent invocations (if any) must create a copy.
12453 2004-07-19 Miguel de Icaza <miguel@ximian.com>
12455 * expression.cs: Resolve the constant expression before returning
12458 2004-07-19 Martin Baulig <martin@ximian.com>
12460 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
12461 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
12462 the return type of the new EmitContext.
12464 2004-07-18 Martin Baulig <martin@ximian.com>
12466 * class.cs (Property.Define): Fix iterators.
12468 * iterators.cs (Iterator.Define): Moved the
12469 `container.AddInterator (this)' call here from the .ctor; only do
12470 it if we resolved successfully.
12472 2004-07-17 Miguel de Icaza <miguel@ximian.com>
12474 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
12475 `true' for preprocessing directives that we parse. The return
12476 value indicates whether we should return to regular tokenizing or
12477 not, not whether it was parsed successfully.
12479 In the past if we were in: #if false ... #line #endif, we would
12480 resume parsing after `#line'. See bug 61604.
12482 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
12483 building: IsEnumType should return true only for enums, not for
12484 enums or System.Enum itself. This fixes #61593.
12486 Likely what happened is that corlib was wrong: mcs depended on
12487 this bug in some places. The bug got fixed, we had to add the
12488 hack, which caused bug 61593.
12490 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
12491 that was a workaround for the older conditions.
12493 2004-07-16 Ben Maurer <bmaurer@ximian.com>
12495 * assign.cs: IAssignMethod has a new interface, as documented
12496 inline. All assignment code now uses this new api.
12498 * ecore.cs, expression.cs: All classes which implement
12499 IAssignMethod now use the new interface.
12501 * expression.cs (Invocation): add a hack to EmitCall so that
12502 IndexerAccess can be the target of a compound assignment without
12503 evaluating its arguments twice.
12505 * statement.cs: Handle changes in Invocation api.
12507 2004-07-16 Martin Baulig <martin@ximian.com>
12509 * iterators.cs: Rewrote this. We're now using one single Proxy
12510 class for both the IEnumerable and the IEnumerator interface and
12511 `Iterator' derives from Class so we can use the high-level API.
12513 * class.cs (TypeContainer.AddIterator): New method.
12514 (TypeContainer.DoDefineType): New protected virtual method, which
12515 is called from DefineType().
12516 (TypeContainer.DoDefineMembers): Call DefineType() and
12517 DefineMembers() on all our iterators.
12518 (TypeContainer.Emit): Call Emit() on all our iterators.
12519 (TypeContainer.CloseType): Call CloseType() on all our iterators.
12521 * codegen.cs (EmitContext.CurrentIterator): New public field.
12523 2004-07-15 Martin Baulig <martin@ximian.com>
12526 (TypeManager.not_supported_exception_type): New type.
12528 2004-07-14 Martin Baulig <martin@ximian.com>
12530 * iterators.cs: Use real error numbers.
12532 2004-07-14 Martin Baulig <martin@ximian.com>
12534 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
12535 requires this to be a System.Collection.IEnumerable and not a
12536 class implementing that interface.
12537 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
12539 2004-07-13 Marek Safar <marek.safar@seznam.cz>
12541 * class.cs: Fixed previous fix, it broke some error tests.
12543 2004-07-12 Martin Baulig <martin@ximian.com>
12545 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
12548 2004-07-09 Miguel de Icaza <miguel@ximian.com>
12550 * assign.cs (LocalTemporary): Add new argument: is_address,If
12551 `is_address' is true, then the value that we store is the address
12552 to the real value, and not the value itself.
12554 * ecore.cs (PropertyExpr): use the new local temporary
12555 stuff to allow us to handle X.Y += z (where X is a struct)
12557 2004-07-08 Martin Baulig <martin@ximian.com>
12559 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
12560 not always return, just like we're doing in Using.Resolve().
12562 2004-07-07 Miguel de Icaza <miguel@ximian.com>
12564 * cs-parser.jay (fixed_statement): flag this as Pinned.
12566 2004-07-06 Miguel de Icaza <miguel@ximian.com>
12568 * typemanager.cs (TypeManager): Removed MakePinned method, this
12569 mechanism is replaced with the .NET 2.x compatible mechanism of
12570 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
12572 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
12573 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
12574 `IsFixed' property which has a different meaning.
12576 2004-07-02 Raja R Harinath <rharinath@novell.com>
12578 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
12579 visible from inside a nested class, not just the names of the
12580 immediately enclosing class.
12581 Fix for bug #60730.
12583 2004-06-24 Raja R Harinath <rharinath@novell.com>
12585 * expression.cs (BetterConversion): Remove buggy special-case
12586 handling of "implicit constant expression conversions". At this
12587 point, we already know that the conversion is possible -- we're
12588 only checking to see which is better.
12590 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12592 * cs-parser.jay: Added error CS0210 test.
12594 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12596 * cs-parser.jay: Added error CS0134 test.
12598 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12601 * cs-parser.jay: Added error CS0145 test.
12603 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12605 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
12607 2004-06-23 Ben Maurer <bmaurer@ximian.com>
12609 * expression.cs (StackAlloc.Resolve): The argument may not
12610 be a constant; deal with this case.
12612 2004-06-23 Marek Safar <marek.safar@seznam.cz>
12614 * attribute.cs (IndexerName_GetIndexerName): Renamed to
12615 GetIndexerAttributeValue.
12616 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
12618 * class.cs (Indexer.Define): Added error tests for CS0415,
12621 2004-06-23 Miguel de Icaza <miguel@ximian.com>
12623 * attribute.cs (Attribute.Resolve): Keep field code in sync with
12626 2004-06-23 Martin Baulig <martin@ximian.com>
12628 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
12629 neither return nor throw, reset the barrier as well. Fixes #60457.
12631 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
12633 * class.cs : EventAttributes is now set to None by default.
12634 This fixes bug #60459.
12636 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12639 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
12640 Don't throw exception but return null (it's sufficient now).
12642 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12644 * typemanager.cs (GetArgumentTypes): Faster implementation.
12646 2004-06-18 Martin Baulig <martin@ximian.com>
12648 * attribute.cs (Attribute.Resolve): Check whether we're an
12649 EmptyCast which a Constant child. Fixes #60333.
12651 2004-06-17 Ben Maurer <bmaurer@ximian.com>
12653 * statement.cs (EmitCollectionForeach): Account for the fact that
12654 not all valuetypes are in areas which we can take the address of.
12655 For these variables, we store to a temporary variable. Also, make
12656 sure that we dont emit a `callvirt' on a valuetype method.
12658 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12660 * expression.cs (StackAlloc.DoReSolve): Added test for
12661 negative parameter (CS0247).
12663 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12666 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
12668 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12671 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
12674 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12676 Fix bug #58254 & cs1555.cs, cs1556.cs
12677 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
12679 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12681 * cs-parser.jay: Added error CS1669 test for indexers.
12683 2004-06-11 Martin Baulig <martin@ximian.com>
12685 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
12686 call this twice: for params and varargs methods.
12688 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12691 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
12693 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12695 * attribute.cs (Attribute.GetValidTargets): Made public.
12698 (AbstractPropertyEventMethod): New class for better code sharing.
12699 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
12701 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
12703 2004-06-11 Raja R Harinath <rharinath@novell.com>
12706 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
12707 that the call to Resolve is part of a MemberAccess.
12708 (Expression.Resolve): Use it for SimpleName resolution.
12709 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
12710 Add 'intermediate' boolean argument.
12711 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
12712 error message when the SimpleName can be resolved ambiguously
12713 between an expression and a type.
12714 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
12716 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
12717 call on the left-side.
12719 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12722 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
12724 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12726 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
12728 2004-06-11 Martin Baulig <martin@ximian.com>
12730 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
12731 varargs methods if applicable.
12733 2004-06-11 Martin Baulig <martin@ximian.com>
12735 * expression.cs (Invocation.EmitCall): Don't use
12736 `method.CallingConvention == CallingConventions.VarArgs' since the
12737 method could also have `CallingConventions.HasThis'.
12739 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12741 * class.cs (Event.GetSignatureForError): Implemented.
12742 Fixed crash in error test cs3010.cs
12744 2004-06-10 Miguel de Icaza <miguel@ximian.com>
12746 * cs-tokenizer.cs: Change the way we track __arglist to be
12747 consistent with the other keywords.
12749 2004-06-09 Miguel de Icaza <miguel@ximian.com>
12751 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
12754 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
12756 * codegen.cs: Check that all referenced assemblies have a strongname
12757 before strongnaming the compiled assembly. If not report error CS1577.
12758 Fix bug #56563. Patch by Jackson Harper.
12759 * typemanager.cs: Added a method to return all referenced assemblies.
12760 Fix bug #56563. Patch by Jackson Harper.
12762 2004-06-08 Marek Safar <marek.safar@seznam.cz>
12765 (Method.ApplyAttributeBuilder): Moved and added conditional
12766 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
12769 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
12771 2004-06-08 Marek Safar <marek.safar@seznam.cz>
12774 * class.cs: (EventField.attribute_targets): Changed default target.
12776 2004-06-08 Martin Baulig <martin@ximian.com>
12778 * expression.cs (Invocation.EmitCall): Enable varargs methods.
12780 2004-06-08 Martin Baulig <martin@ximian.com>
12782 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
12784 2004-06-07 Martin Baulig <martin@ximian.com>
12786 Added support for varargs methods.
12788 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
12791 * cs-parser.jay: Added support for `__arglist'.
12793 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
12795 * expression.cs (Argument.AType): Added `ArgList'.
12796 (Invocation): Added support for varargs methods.
12797 (ArglistAccess): New public class.
12798 (Arglist): New public class.
12800 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
12802 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
12803 a method's top-level block if the method has varargs.
12805 * support.cs (ReflectionParameters, InternalParameters): Added
12806 support for varargs methods.
12808 2004-06-07 Miguel de Icaza <miguel@ximian.com>
12810 * class.cs: Provide location in indexer error report.
12812 * driver.cs: Use standard names.
12814 * namespace.cs: Catch the use of using after a namespace has been
12815 declared also on using aliases.
12817 2004-06-03 Raja R Harinath <rharinath@novell.com>
12820 * typemanager.cs (closure_private_ok, closure_invocation_type)
12821 (closure_qualifier_type, closure_invocation_assembly)
12822 (FilterWithClosure): Move to ...
12823 (Closure): New internal nested class.
12824 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
12825 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
12826 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
12827 (MemberLookup, MemberLookupFailed): Use it.
12828 * expression.cs (New.DoResolve): Treat the lookup for the
12829 constructor as being qualified by the 'new'ed type.
12830 (Indexers.GetIndexersForTypeOrInterface): Update.
12832 2004-06-03 Marek Safar <marek.safar@seznam.cz>
12835 (GetConditionalAttributeValue): New method. Returns
12836 condition of ConditionalAttribute.
12837 (SearchMulti): New method. Returns all attributes of type 't'.
12838 Use it when attribute is AllowMultiple = true.
12839 (IsConditionalMethodExcluded): New method.
12842 (Method.IsExcluded): Implemented. Returns true if method has conditional
12843 attribute and the conditions is not defined (method is excluded).
12844 (IMethodData): Extended interface for ConditionalAttribute support.
12845 (PropertyMethod.IsExcluded): Implemented.
12848 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
12851 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
12854 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
12856 * expression.cs (ArrayCreationExpression): Make this just an
12857 `expression'. It can't be a statement, so the code here was
12860 2004-06-02 Marek Safar <marek.safar@seznam.cz>
12863 * typemanager.cs (GetFullNameSignature): New method for
12866 2004-06-02 Marek Safar <marek.safar@seznam.cz>
12869 * class.cs (MemberBase.GetSignatureForError): New virtual method.
12870 Use this method when MethodBuilder is null.
12871 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
12872 Added test for error CS0626 (MONO reports error for this situation).
12873 (IMethodData.GetSignatureForError): Extended interface.
12875 2004-06-01 Marek Safar <marek.safar@seznam.cz>
12878 (AttributeTester.GetObsoleteAttribute): Returns instance of
12879 ObsoleteAttribute when type is obsolete.
12882 (TypeContainer.VerifyObsoleteAttribute): Override.
12883 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
12884 (MethodCode.VerifyObsoleteAttribute): Override.
12885 (MemberBase.VerifyObsoleteAttribute): Override.
12888 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
12889 and report proper error.
12892 Delegate.VerifyObsoleteAttribute): Override.
12895 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
12896 and report proper error.
12897 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
12900 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
12904 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
12905 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
12906 Added test for ObsoleteAttribute.
12909 (Catch): Derived from Statement.
12911 2004-06-01 Marek Safar <marek.safar@seznam.cz>
12913 Fixed bug #59071 & cs0160.cs
12915 * statement.cs (Try.Resolve): Check here whether order of catch
12916 clauses matches their dependencies.
12918 2004-05-31 Miguel de Icaza <miguel@ximian.com>
12920 * Reverted patch to namespace.cs (Use lookuptypedirect). This
12921 caused a regression: #59343. Referencing nested classes from an
12922 assembly stopped working.
12924 2004-05-31 Martin Baulig <martin@ximian.com>
12926 MCS is now frozen for beta 2.
12928 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12930 * convert.cs: add a trivial cache for overload operator resolution.
12932 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12934 * decl.cs: If possible, use lookuptypedirect here. We can only do
12935 this if there is no `.' after the namespace. Avoids using
12936 LookupType, which does lots of slow processing.
12937 (FindNestedType) New method, does what it says :-).
12938 * namespace.cs: use LookupTypeDirect.
12939 * rootcontext.cs: use membercache, if possible.
12940 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
12942 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12945 According to the spec,
12947 In a member access of the form E.I, if E is a single identifier,
12948 and if the meaning of E as a simple-name (§7.5.2) is a constant,
12949 field, property, localvariable, or parameter with the same type as
12950 the meaning of E as a type-name (§3.8), then both possible
12951 meanings of E are permitted.
12953 We did not check that E as a simple-name had the same type as E as
12956 This trivial check gives us 5-7% on bootstrap time.
12958 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12960 * expression.cs (Invocation.OverloadResolve): Avoid the
12961 use of hashtables and boxing here by allocating on demand.
12963 2004-05-30 Martin Baulig <martin@ximian.com>
12965 * rootcontext.cs (RootContext.LookupType): Don't cache things if
12966 we're doing a silent lookup. Don't try to lookup nested types in
12967 TypeManager.object_type (thanks to Ben Maurer).
12969 2004-05-30 Martin Baulig <martin@ximian.com>
12971 Committing a patch from Ben Maurer.
12973 * rootcontext.cs (RootContext.LookupType): Cache negative results.
12975 2004-05-29 Martin Baulig <martin@ximian.com>
12977 * class.cs (IMethodData.ShouldIgnore): New method.
12979 * typemanager.cs (TypeManager.MethodFlags): Don't take a
12980 `Location' argument, we don't need it anywhere. Use
12981 `IMethodData.ShouldIgnore ()' instead of
12982 `MethodData.GetMethodFlags ()'.
12983 (TypeManager.AddMethod): Removed.
12984 (TypeManager.AddMethod2): Renamed to AddMethod.
12986 2004-05-29 Martin Baulig <martin@ximian.com>
12988 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
12990 * convert.cs (Convert.ImplicitReferenceConversion): If we're
12991 converting from a class type S to an interface type and we already
12992 have an object on the stack, don't box it again. Fixes #52578.
12994 2004-05-29 Martin Baulig <martin@ximian.com>
12996 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
12997 Added support for `params' parameters. Fixes #59267.
12999 2004-05-29 Martin Baulig <martin@ximian.com>
13001 * literal.cs (NullPointer): Provide a private .ctor which sets
13002 `type' to TypeManager.object_type. Fixes #59048.
13004 2004-05-29 Martin Baulig <martin@ximian.com>
13006 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
13007 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
13009 * ecore.cs (EventExpr.instance_expr): Make the field private.
13011 2004-05-26 Marek Safar <marek.safar@seznam.cz>
13013 Fixed bug #50080 & cs0214-2.cs
13014 * expression.cs (Cast.DoResolve): Check unsafe context here.
13016 * statement.cs (Resolve.DoResolve): Likewise.
13018 2004-05-26 Martin Baulig <martin@ximian.com>
13020 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
13022 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
13023 (RootContext.LookupType): Pass down the `silent' flag.
13025 2004-05-25 Martin Baulig <martin@ximian.com>
13028 (MethodGroupExpr.IdenticalTypeName): New public property.
13029 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
13030 expression actually refers to a type.
13032 2004-05-25 Martin Baulig <martin@ximian.com>
13034 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
13035 for #56176 and made it actually work.
13037 2004-05-25 Martin Baulig <martin@ximian.com>
13039 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
13040 (FieldExpr, PropertyExpr): Override and implement
13041 CacheTemporaries. Fixes #52279.
13043 2004-05-25 Miguel de Icaza <miguel@ximian.com>
13045 * location.cs: In the new compiler listing a file twice is a
13046 warning, not an error.
13048 2004-05-24 Martin Baulig <martin@ximian.com>
13050 * enum.cs (Enum.DefineType): For the `BaseType' to be a
13051 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
13053 2004-05-24 Martin Baulig <martin@ximian.com>
13055 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
13056 walking the `using' list. Fixes #53921.
13058 2004-05-24 Martin Baulig <martin@ximian.com>
13060 * const.cs (Const.LookupConstantValue): Added support for
13061 EmptyCast's; fixes #55251.
13063 2004-05-24 Martin Baulig <martin@ximian.com>
13065 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
13066 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
13067 which does the CS0135 check. The reason is that we first need to
13068 check whether the variable actually exists.
13070 2004-05-24 Martin Baulig <martin@ximian.com>
13072 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
13073 than RootContext.LookupType() to find the explicit interface
13074 type. Fixes #58584.
13076 2004-05-24 Raja R Harinath <rharinath@novell.com>
13078 * Makefile: Simplify. Use executable.make.
13079 * mcs.exe.sources: New file. List of sources of mcs.exe.
13081 2004-05-24 Anders Carlsson <andersca@gnome.org>
13085 Use the invariant culture when doing String.Compare for CLS case
13088 2004-05-23 Martin Baulig <martin@ximian.com>
13090 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
13091 don't have any dots. Fixes #52622, added cs0246-8.cs.
13093 * namespace.cs (NamespaceEntry.Lookup): Likewise.
13095 2004-05-23 Marek Safar <marek.safar@seznam.cz>
13097 * class.cs (MemberBase.Define): Reuse MemberType member for
13098 resolved type. Other methods can use it too.
13100 2004-05-23 Martin Baulig <martin@ximian.com>
13102 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
13103 the variable also exists in the current block (otherwise, we need
13104 to report a CS0103). Fixes #58670.
13106 2004-05-23 Martin Baulig <martin@ximian.com>
13108 * flowanalysis.cs (Reachability.Reachable): Compute this
13109 on-the-fly rather than storing it as a field.
13111 2004-05-23 Martin Baulig <martin@ximian.com>
13113 * flowanalysis.cs (Reachability.And): Manually compute the
13114 resulting `barrier' from the reachability.
13116 2004-05-23 Marek Safar <marek.safar@seznam.cz>
13119 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
13120 instance of ObsoleteAttribute when symbol is obsolete.
13123 (IMethodData): Extended interface for ObsoleteAttribute support.
13125 2004-05-22 Marek Safar <marek.safar@seznam.cz>
13127 * attribute.cs: Fix bug #55970
13129 2004-05-22 Marek Safar <marek.safar@seznam.cz>
13133 (GetObsoleteAttribute): New method. Creates the instance of
13135 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
13136 ObsoleteAttribute when member is obsolete.
13137 (AttributeTester.Report_ObsoleteMessage): Common method for
13138 Obsolete error/warning reporting.
13141 (TypeContainer.base_classs_type): New member for storing parent type.
13144 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
13145 for this MemberCore.
13147 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13149 * attribute.cs, const.cs: Fix bug #58590
13151 2004-05-21 Martin Baulig <martin@ximian.com>
13153 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
13154 out parameters if the end of the method is unreachable. Fixes
13157 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13159 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
13160 Hari was right, why extra method.
13162 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13164 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
13166 2004-05-20 Martin Baulig <martin@ximian.com>
13168 Merged this back from gmcs to keep the differences to a minumum.
13170 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
13171 instead of a Declspace.
13172 (Attribute.ResolveType): Likewise.
13173 (Attributes.Search): Likewise.
13174 (Attributes.Contains): Likewise.
13175 (Attributes.GetClsCompliantAttribute): Likewise.
13177 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
13179 (MethodData.ApplyAttributes): Take an EmitContext instead of a
13182 2004-05-19 Marek Safar <marek.safar@seznam.cz>
13184 Fix bug #58688 (MCS does not report error when the same attribute
13187 * attribute.cs (Attribute.Emit): Distinction between null and default.
13189 2004-05-19 Raja R Harinath <rharinath@novell.com>
13191 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
13192 of a top-level attribute without an attribute target.
13193 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
13195 (Attribute.Conditional_GetConditionName),
13196 (Attribute.Obsolete_GetObsoleteMessage): Update.
13197 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
13198 part of ScanForIndexerName.
13199 (Attribute.CanIgnoreInvalidAttribute): New function.
13200 (Attribute.ScanForIndexerName): Move to ...
13201 (Attributes.ScanForIndexerName): ... here.
13202 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
13203 (Attributes.Search): New internal variant that can choose not to
13204 complain if types aren't resolved. The original signature now
13206 (Attributes.GetClsCompliantAttribute): Use internal variant, with
13207 complaints suppressed.
13208 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
13209 only if it not useful.
13210 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
13211 top-level for attributes that are shared between the assembly
13212 and a top-level class.
13213 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
13214 * class.cs: Update to reflect changes.
13215 (DefineIndexers): Fuse loops.
13216 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
13217 a couple more variants of attribute names.
13219 2004-05-18 Marek Safar <marek.safar@seznam.cz>
13221 Fix bug #52585 (Implemented explicit attribute declaration)
13224 (Attributable.ValidAttributeTargets): New abstract method. It gets
13225 list of valid attribute targets for explicit target declaration.
13226 (Attribute.Target): It holds target itself.
13227 (AttributeSection): Removed.
13228 (Attribute.CheckTargets): New method. It checks whether attribute
13229 target is valid for the current element.
13232 (EventProperty): New class. For events that are declared like
13233 property (with add and remove accessors).
13234 (EventField): New class. For events that are declared like field.
13237 * cs-parser.jay: Implemented explicit attribute target declaration.
13239 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
13240 Override ValidAttributeTargets.
13243 (ReturnParameter): Class for applying custom attributes on
13245 (ParameterAtribute): New class. Class for applying custom
13246 attributes on the parameter type.
13248 2004-05-17 Miguel de Icaza <miguel@ximian.com>
13250 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
13253 (Method): Allow UNSAFE here.
13255 * modifiers.cs: Support unsafe reporting.
13257 2004-05-17 Marek Safar <marek.safar@seznam.cz>
13259 * decl.cs: Fix bug #58478.
13261 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13263 * statement.cs: When checking for unreachable code on an EmptyStatement,
13264 set the location. Fixes bug #58488.
13266 2004-05-13 Miguel de Icaza <miguel@ximian.com>
13268 * driver.cs: Add -pkg handling.
13270 From Gonzalo: UseShelLExecute=false
13272 2004-05-12 Marek Safar <marek.safar@seznam.cz>
13275 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
13277 (Attribute.IsClsCompliaceRequired): Moved to base for better
13279 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
13280 when attribute is AttributeUsageAttribute.
13281 (Attribute.GetValidTargets): Simplified.
13282 (Attribute.GetAttributeUsage): New method returns AttributeUsage
13283 attribute for this type.
13284 (Attribute.ApplyAttributes): Method renamed to Emit and make
13286 (GlobalAttributeSection): New class for special handling of global
13287 attributes (assembly, module).
13288 (AttributeSection.Emit): New method.
13290 * class.cs: Implemented Attributable abstract methods.
13291 (MethodCore.LabelParameters): Moved to Parameter class.
13292 (Accessor): Is back simple class.
13293 (PropertyMethod): Implemented Attributable abstract class.
13294 (DelegateMethod): Implemented Attributable abstract class.
13295 (Event): New constructor for disctintion between normal Event
13296 and Event with accessors.
13298 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
13300 * codegen.cs, const.cs, decl.cs, delegate.cs:
13301 (CommonAssemblyModulClass): Implemented Attributable abstract class
13304 * enum.cs: Implement IAttributeSupport interface.
13305 (EnumMember): New class for emum members. Implemented Attributable
13309 (ParameterBase): Is abstract.
13310 (ReturnParameter): New class for easier [return:] attribute handling.
13312 * typemanager.cs: Removed builder_to_attr.
13314 2004-05-11 Raja R Harinath <rharinath@novell.com>
13317 * attribute.cs (Attribute.GetPositionalValue): New function.
13318 * class.cs (TypeContainer.VerifyMembers): New function.
13319 (TypeContainer.Emit): Use it.
13320 (ClassOrStruct): New base class for Class and Struct.
13321 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
13322 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
13324 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
13325 then each non-static field should have a FieldOffset attribute.
13326 Otherwise, none of the fields should have a FieldOffset attribute.
13327 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
13328 and FieldOffset attributes.
13329 * typemanager.cs (TypeManager.struct_layout_attribute_type)
13330 (TypeManager.field_offset_attribute_type): New core types.
13331 (TypeManager.InitCoreTypes): Initialize them.
13333 2004-05-11 Michal Moskal <malekith@pld-linux.org>
13335 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
13336 Return correct type.
13339 2004-05-09 Miguel de Icaza <miguel@ximian.com>
13341 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
13342 be implicitly converted to ulong.
13344 * expression.cs: The logic for allowing operator &, | and ^ worked
13345 was wrong, it worked before because we did not report an error in
13346 an else branch. Fixes 57895.
13348 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
13349 allow volatile fields to be reference types.
13351 2004-05-07 Miguel de Icaza <miguel@ximian.com>
13353 * driver.cs: Add support for /debug-
13355 2004-05-07 Raja R Harinath <rharinath@novell.com>
13357 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
13358 Add a 'complain' parameter to silence errors.
13359 (Attribute.Resolve): Update to changes. Put in sanity check to catch
13360 silently overlooked type-resolutions.
13361 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
13362 to reflect changes.
13363 (Attributes.Search): New function.
13364 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
13365 (Attributes.GetAttributeFullName): Remove hack.
13366 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
13367 Update to reflect changes.
13368 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
13369 Use Attributes.Search instead of nested loops.
13371 2004-05-07 Marek Safar <marek.safar@seznam.cz>
13374 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
13375 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
13376 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
13378 * report.cs: (Report.Warning): Renamed to Warning_T because of
13379 parameter collision.
13381 2004-05-05 Raja R Harinath <rharinath@novell.com>
13383 * expression.cs (MemberAccess.ResolveMemberAccess):
13384 Exit with non-zero status after Report.Error.
13385 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
13387 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
13389 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13391 * support.cs: Don't hang when the file is empty.
13393 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13395 * support.cs: In SeekableStreamReader, compute the preamble size of the
13396 underlying stream. Position changes should take into account that initial
13399 2004-05-03 Todd Berman <tberman@sevenl.net>
13401 * driver.cs: remove unused GetSysVersion function.
13403 2004-05-03 Todd Berman <tberman@sevenl.net>
13405 * driver.cs: Remove the hack from saturday, as well as the hack
13406 from jackson (LoadAssemblyFromGac), also adds the CWD to the
13407 link_paths to get that bit proper.
13409 2004-05-01 Todd Berman <tberman@sevenl.net>
13411 * driver.cs: Try a LoadFrom before a Load, this checks the current
13412 path. This is currently a bug in mono that is be fixed, however, this
13413 provides a workaround for now. This will be removed when the bug
13416 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
13418 * CryptoConvert.cs: Updated to latest version. Fix issue with
13419 incomplete key pairs (#57941).
13421 2004-05-01 Todd Berman <tberman@sevenl.net>
13423 * driver.cs: Remove '.' from path_chars, now System.* loads properly
13426 2004-04-30 Jackson Harper <jackson@ximian.com>
13428 * codegen.cs: Open keys readonly.
13430 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13432 * typemanager.cs: don't report cyclic struct layout when a struct
13433 contains 2 or more fields of the same type. Failed for Pango.AttrShape
13434 which has 2 Pango.Rectangle fields.
13436 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
13438 * expression.cs: Handle IntPtr comparisons with IL code
13439 rather than a method call.
13441 2004-04-29 Martin Baulig <martin@ximian.com>
13443 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
13444 the list of PropertyInfo's in class hierarchy and find the
13445 accessor. Fixes #56013.
13447 2004-04-29 Martin Baulig <martin@ximian.com>
13449 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
13451 2004-04-29 Martin Baulig <martin@ximian.com>
13453 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13455 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
13457 2004-04-29 Martin Baulig <martin@ximian.com>
13459 * class.cs (ConstructorInitializer.Resolve): Check whether the
13460 parent .ctor is accessible. Fixes #52146.
13462 2004-04-29 Martin Baulig <martin@ximian.com>
13464 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13466 * statement.cs (Using.EmitLocalVariableDecls): Use
13467 TypeManager.idisposable_type, not typeof (IDisposable).
13468 (Foreach.EmitCollectionForeach): Added support for valuetypes.
13470 2004-04-29 Martin Baulig <martin@ximian.com>
13472 * class.cs (Event.Define): Don't emit the field and don't set
13473 RTSpecialName and SpecialName for events on interfaces. Fixes
13476 2004-04-29 Raja R Harinath <rharinath@novell.com>
13478 Refactor Attribute.ApplyAttributes.
13479 * attribute.cs (Attributable): New base class for objects that can
13480 have Attributes applied on them.
13481 (Attribute): Make AttributeUsage fields public.
13482 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
13483 (Attribute.IsInternalCall): New property.
13484 (Attribute.UsageAttr): Convert to a public read-only property.
13485 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
13486 (Attribute.ResolveType, Attribute.Resolve)
13487 (Attribute.ScanForIndexerName): Update to reflect changes.
13488 (Attribute.CheckAttributeTarget): Re-format.
13489 (Attribute.ApplyAttributes): Refactor, to various
13490 Attributable.ApplyAttributeBuilder methods.
13491 * decl.cs (MemberCore): Make Attributable.
13492 * class.cs (Accessor): Make Attributable.
13493 (MethodData.ApplyAttributes): Use proper attribute types, not
13495 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
13496 (TypeContainer.ApplyAttributeBuilder)
13497 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
13498 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
13499 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
13500 (Operator.ApplyAttributeBuilder): New factored-out methods.
13501 * const.cs (Const.ApplyAttributeBuilder): Likewise.
13502 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
13503 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
13504 * parameter.cs (ParameterBase): New Attributable base class
13505 that can also represent Return types.
13506 (Parameter): Update to the changes.
13508 2004-04-29 Jackson Harper <jackson@ximian.com>
13510 * driver.cs: Prefer the corlib system version when looking for
13511 assemblies in the GAC. This is still a hack, but its a better hack
13514 2004-04-29 Marek Safar <marek.safar@seznam.cz>
13516 * decl.cs, enum.cs: Improved error 3005 reporting.
13518 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
13519 (related_symbols): New private member for list of symbols
13520 related to reported error/warning.
13522 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
13524 2004-04-29 Martin Baulig <martin@ximian.com>
13526 * ecore.cs (Expression.Constantify): If we're an enum and
13527 TypeManager.TypeToCoreType() doesn't give us another type, use
13528 t.UnderlyingSystemType. Fixes #56178.
13530 2004-04-29 Martin Baulig <martin@ximian.com>
13532 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
13533 interfaces and for each interface, only add members directly
13534 declared in that interface. Fixes #53255.
13536 2004-04-28 Martin Baulig <martin@ximian.com>
13538 * expression.cs (ConditionalLogicalOperator): Use a temporary
13539 variable for `left' to avoid that we evaluate it more than once;
13542 2004-04-28 Martin Baulig <martin@ximian.com>
13544 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
13547 2004-04-28 Martin Baulig <martin@ximian.com>
13549 * statement.cs (LocalInfo.Resolve): Check whether the type is not
13552 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
13553 whether the type is not void (CS1547).
13555 2004-04-28 Martin Baulig <martin@ximian.com>
13557 * expression.cs (Unary.DoResolveLValue): Override this and report
13558 CS0131 for anything but Operator.Indirection.
13560 2004-04-28 Martin Baulig <martin@ximian.com>
13562 Committing a patch from Ben Maurer; see bug #50820.
13564 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13567 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13570 2004-04-28 Martin Baulig <martin@ximian.com>
13572 Committing a patch from Ben Maurer; see bug #50820.
13574 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13577 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13580 2004-04-28 Martin Baulig <martin@ximian.com>
13582 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
13583 (Block.AddLabel): Call DoLookupLabel() to only search in the
13586 2004-04-28 Martin Baulig <martin@ximian.com>
13588 * cfold.cs (ConstantFold.BinaryFold): Added special support for
13589 comparing StringConstants and NullLiterals in Equality and Inequality.
13591 2004-04-28 Jackson Harper <jackson@ximian.com>
13593 * driver.cs: Attempt to load referenced assemblies from the
13594 GAC. This is the quick and dirty version of this method that
13595 doesnt take into account versions and just takes the first
13596 canidate found. Will be good enough for now as we will not have more
13597 then one version installed into the GAC until I update this method.
13599 2004-04-28 Martin Baulig <martin@ximian.com>
13601 * typemanager.cs (TypeManager.CheckStructCycles): New public
13602 static method to check for cycles in the struct layout.
13604 * rootcontext.cs (RootContext.PopulateTypes): Call
13605 TypeManager.CheckStructCycles() for each TypeContainer.
13606 [Note: We only need to visit each type once.]
13608 2004-04-28 Martin Baulig <martin@ximian.com>
13610 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
13612 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
13613 success and added `out object value'. Use a `bool resolved' field
13614 to check whether we've already been called rather than
13615 `ConstantValue != null' since this breaks for NullLiterals.
13617 2004-04-28 Raja R Harinath <rharinath@novell.com>
13619 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
13620 setting of this flag, since the 'set' method may be non-public.
13622 2004-04-28 Raja R Harinath <rharinath@novell.com>
13624 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
13625 check on current_vector.Block.
13627 2004-04-27 Martin Baulig <martin@ximian.com>
13629 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
13630 a field initializer. Fixes #56459.
13632 2004-04-27 Martin Baulig <martin@ximian.com>
13634 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
13635 we're not attempting to use an indexer. Fixes #52154.
13637 2004-04-27 Martin Baulig <martin@ximian.com>
13639 * statement.cs (Return): Don't create a return label if we don't
13640 need it; reverts my change from January 20th. Thanks to Ben
13643 2004-04-27 Martin Baulig <martin@ximian.com>
13645 According to the spec, `goto' can only leave a nested scope, but
13648 * statement.cs (Block.LookupLabel): Only lookup in the current
13649 block, don't recurse into parent or child blocks.
13650 (Block.AddLabel): Check in parent and child blocks, report
13651 CS0140/CS0158 if we find a duplicate.
13652 (Block): Removed this indexer for label lookups.
13653 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
13654 this already does the error reporting for us.
13657 (FlowBranching.UsageVector.Block): New public variable; may be null.
13658 (FlowBranching.CreateSibling): Added `Block' argument.
13659 (FlowBranching.LookupLabel): New public virtual method. Lookup a
13660 label for the target of a `goto' and check whether we're not
13661 leaving a `finally'.
13663 2004-04-27 Martin Baulig <martin@ximian.com>
13665 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13666 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
13669 2004-04-27 Martin Baulig <martin@ximian.com>
13671 * statement.cs (Block.AddLabel): Also check for implicit blocks
13672 and added a CS0158 check.
13674 2004-04-27 Martin Baulig <martin@ximian.com>
13676 * flowanalysis.cs (FlowBranchingLoop): New class.
13677 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
13678 UsageVector's instead of an ArrayList.
13679 (FlowBranching.Label): Likewise.
13680 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
13681 (FlowBranching.AddBreakVector): New method.
13683 2004-04-27 Miguel de Icaza <miguel@ximian.com>
13685 * attribute.cs: Small regression fix: only convert the type if we
13686 the type is different, fixes System.Drawing build.
13688 2004-04-27 Martin Baulig <martin@ximian.com>
13690 * attribute.cs (Attribute.Resolve): If we have a constant value
13691 for a named field or property, implicity convert it to the correct
13694 2004-04-27 Raja R Harinath <rharinath@novell.com>
13696 * statement.cs (Block.Block): Implicit blocks share
13697 'child_variable_names' fields with parent blocks.
13698 (Block.AddChildVariableNames): Remove.
13699 (Block.AddVariable): Mark variable as "used by a child block" in
13700 every surrounding block.
13701 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
13702 been used in a child block, complain about violation of "Invariant
13703 meaning in blocks" rule.
13704 * cs-parser.jay (declare_local_variables): Don't use
13705 AddChildVariableNames.
13706 (foreach_statement): Don't create an implicit block: 'foreach'
13707 introduces a scope.
13709 2004-04-23 Miguel de Icaza <miguel@ximian.com>
13711 * convert.cs (ImplicitNumericConversion): 0 is also positive when
13712 converting from 0L to ulong. Fixes 57522.
13714 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13716 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
13717 derived class hides via 'new' keyword field from base class (test-242.cs).
13718 TODO: Handle this in the more general way.
13720 * class.cs (CheckBase): Ditto.
13722 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13724 * decl.cs (caching_flags): New member for storing cached values
13726 (MemberCore.Flags): New enum where bit flags for caching_flags
13728 (MemberCore.cls_compliance): Moved to caching_flags.
13729 (DeclSpace.Created): Moved to caching_flags.
13731 * class.cs: Use caching_flags instead of DeclSpace.Created
13733 2004-04-21 Miguel de Icaza <miguel@ximian.com>
13735 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
13736 if we are only a derived class, not a nested class.
13738 * typemanager.cs: Same as above, but do this at the MemberLookup
13739 level (used by field and methods, properties are handled in
13740 PropertyExpr). Allow for the qualified access if we are a nested
13743 2004-04-21 Marek Safar <marek.safar@seznam.cz>
13745 * class.cs: Refactoring.
13746 (IMethodData): New inteface; Holds links to parent members
13747 to avoid member duplication (reduced memory allocation).
13748 (Method): Implemented IMethodData interface.
13749 (PropertyBase): New inner classes for get/set methods.
13750 (PropertyBase.PropertyMethod): Implemented IMethodData interface
13751 (Event): New inner classes for add/remove methods.
13752 (Event.DelegateMethod): Implemented IMethodData interface.
13754 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
13755 EmitContext (related to class.cs refactoring).
13757 2004-04-21 Raja R Harinath <rharinath@novell.com>
13759 * delegate.cs (Delegate.VerifyApplicability): If the number of
13760 arguments are the same as the number of parameters, first try to
13761 verify applicability ignoring any 'params' modifier on the last
13765 2004-04-16 Raja R Harinath <rharinath@novell.com>
13767 * class.cs (TypeContainer.AddIndexer): Use
13768 'ExplicitInterfaceName' to determine if interface name was
13769 explicitly specified. 'InterfaceType' is not initialized at this time.
13770 (TypeContainer.DefineIndexers): Remove use of temporary list. The
13771 Indexers array is already in the required order. Initialize
13772 'IndexerName' only if there are normal indexers.
13773 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
13774 (TypeContainer.Emit): Emit DefaultMember attribute only if
13775 IndexerName is initialized.
13778 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
13780 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
13783 2004-04-15 Raja R Harinath <rharinath@novell.com>
13785 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
13789 * attribute.cs (Attribute.Resolve): Check for duplicate named
13793 2004-04-15 Miguel de Icaza <miguel@ximian.com>
13795 * iterators.cs (MarkYield): track whether we are in an exception,
13796 and generate code accordingly. Use a temporary value to store the
13797 result for our state.
13799 I had ignored a bit the interaction of try/catch with iterators
13800 since their behavior was not entirely obvious, but now it is
13801 possible to verify that our behavior is the same as MS .NET 2.0
13805 2004-04-14 Miguel de Icaza <miguel@ximian.com>
13807 * iterators.cs: Avoid creating temporaries if there is no work to
13810 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
13811 Enumerations, use TypeManager.EnumToUnderlying and call
13814 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
13817 (This.Emit): Use EmitContext.EmitThis to emit our
13820 (This.EmitAssign): Ditto.
13822 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
13823 codepaths, we will move all the functionality into
13826 (FieldExpr.EmitAssign): Ditto.
13828 This fixes several hidden bugs that I uncovered while doing a code
13829 review of this today.
13831 * codegen.cs (EmitThis): reworked so the semantics are more clear
13832 and also support value types "this" instances.
13834 * iterators.cs: Changed so that for iterators in value types, we
13835 do not pass the value type as a parameter.
13837 Initialization of the enumerator helpers is now done in the caller
13838 instead of passing the parameters to the constructors and having
13839 the constructor set the fields.
13841 The fields have now `assembly' visibility instead of private.
13843 2004-04-11 Miguel de Icaza <miguel@ximian.com>
13845 * expression.cs (Argument.Resolve): Check if fields passed as ref
13846 or out are contained in a MarshalByRefObject.
13848 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
13849 another compiler type.
13851 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
13853 * class.cs (Indexer.Define): use the new name checking method.
13854 Also, return false on an error.
13855 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
13856 (is_identifier_[start/part]_character): make static.
13858 2004-04-10 Miguel de Icaza <miguel@ximian.com>
13860 * expression.cs (Binary.ResolveOperator): Do no append strings
13861 twice: since we can be invoked more than once (array evaluation)
13862 on the same concatenation, take care of this here. Based on a fix
13863 from Ben (bug #56454)
13865 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
13867 * codegen.cs: Fix another case where CS1548 must be reported (when
13868 delay-sign isn't specified and no private is available #56564). Fix
13869 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
13870 error when MCS is used on the MS runtime and we need to delay-sign
13871 (which seems unsupported by AssemblyBuilder - see #56621).
13873 2004-04-08 Marek Safar <marek.safar@seznam.cz>
13875 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
13876 (TypeManager.ComputeNamespaces): Faster implementation for
13879 * compiler.csproj: Updated AssemblyName to mcs.
13881 2004-04-07 Miguel de Icaza <miguel@ximian.com>
13883 * rootcontext.cs: Add new types to the boot resolution.
13885 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
13886 MulticastDelegate is not allowed.
13888 * typemanager.cs: Add new types to lookup: System.TypedReference
13891 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
13892 check for TypedReference or ArgIterator, they are not allowed.
13894 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
13895 makes us properly catch 1510 in some conditions (see bug 56016 for
13898 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
13900 * CryptoConvert.cs: update from corlib version
13903 2004-04-05 Miguel de Icaza <miguel@ximian.com>
13905 * class.cs (Indexer.Define): Check indexername declaration
13907 2004-04-05 Marek Safar <marek.safar@seznam.cz>
13909 * attribute.cs (IsClsCompliant): Fixed problem with handling
13910 all three states (compliant, not-compliant, undetected).
13912 2004-03-30 Marek Safar <marek.safar@seznam.cz>
13914 * attribute.cs (Attribute): Location is now public.
13915 (Resolve): Store resolved arguments (pos_values) in attribute class.
13916 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
13917 (GetClsCompliantAttributeValue): New method that gets
13918 CLSCompliantAttribute value.
13919 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
13920 if exists else null.
13921 (AttributeTester): New class for CLS-Compliant verification routines.
13923 * class.cs (Emit): Add CLS-Compliant verification.
13924 (Method.GetSignatureForError): Implemented.
13925 (Constructor.GetSignatureForError): Implemented
13926 (Constructor.HasCompliantArgs): Returns if constructor has
13927 CLS-Compliant arguments.
13928 (Constructor.Emit): Override.
13929 (Construcor.IsIdentifierClsCompliant): New method; For constructors
13930 is needed to test only parameters.
13931 (FieldBase.GetSignatureForError): Implemented.
13932 (TypeContainer): New member for storing base interfaces.
13933 (TypeContainer.FindMembers): Search in base interfaces too.
13935 * codegen.cs (GetClsComplianceAttribute): New method that gets
13936 assembly or module CLSCompliantAttribute value.
13937 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
13939 (ModuleClass.Emit): Add error 3012 test.
13941 * const.cs (Emit): Override and call base for CLS-Compliant tests.
13943 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
13944 state for all decl types.
13945 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
13946 if CLS-Compliant tests are required.
13947 (IsClsCompliaceRequired): New method. Analyze whether code
13948 must be CLS-Compliant.
13949 (IsExposedFromAssembly): New method. Returns true when MemberCore
13950 is exposed from assembly.
13951 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
13952 value or gets cached value.
13953 (HasClsCompliantAttribute): New method. Returns true if MemberCore
13954 is explicitly marked with CLSCompliantAttribute.
13955 (IsIdentifierClsCompliant): New abstract method. This method is
13956 used to testing error 3005.
13957 (IsIdentifierAndParamClsCompliant): New method. Common helper method
13958 for identifier and parameters CLS-Compliant testing.
13959 (VerifyClsCompliance): New method. The main virtual method for
13960 CLS-Compliant verifications.
13961 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
13962 null. I don't know why is null (too many public members !).
13963 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
13964 and get value of first CLSCompliantAttribute that found.
13966 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
13967 (VerifyClsCompliance): Override and add extra tests.
13969 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
13970 clscheck- disable CLS-Compliant verification event if assembly is has
13971 CLSCompliantAttribute(true).
13973 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
13974 ApllyAttribute is now called in emit section as in the other cases.
13975 Possible future Emit integration.
13976 (IsIdentifierClsCompliant): New override.
13977 (VerifyClsCompliance): New override.
13978 (GetEnumeratorName): Returns full enum name.
13980 * parameter.cs (GetSignatureForError): Implemented.
13982 * report.cs (WarningData): New struct for Warning message information.
13983 (LocationOfPreviousError): New method.
13984 (Warning): New method. Reports warning based on the warning table.
13985 (Error_T): New method. Reports error based on the error table.
13987 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
13988 verifications are done here.
13990 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
13992 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
13993 CLSCompliantAttribute.
13994 (all_imported_types): New member holds all imported types from other
13996 (LoadAllImportedTypes): New method fills static table with exported types
13997 from all referenced assemblies.
13998 (Modules): New property returns all assembly modules.
14000 2004-03-30 Miguel de Icaza <miguel@ximian.com>
14002 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
14003 throwing a parser error.
14005 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
14006 which removes the hardcoded get_/set_ prefixes for properties, as
14007 IL allows for the properties to be named something else.
14011 * expression.cs: Do not override operand before we know if it is
14012 non-null. Fix 56207
14014 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
14016 * typemanager.cs: support for pinned variables.
14018 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
14020 * decl.cs, typemanager.cs: Avoid using an arraylist
14021 as a buffer if there is only one result set.
14023 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
14025 * expression.cs: Make sure you cant call a static method
14026 with an instance expression, bug #56174.
14028 2004-03-29 Miguel de Icaza <miguel@ximian.com>
14030 * class.cs (IsDuplicateImplementation): Improve error reporting to
14031 flag 663 (method only differs in parameter modifier).
14033 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
14034 in preprocessor directives.
14036 * location.cs (LookupFile): Allow for the empty path.
14038 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
14039 better approach for some of that patch, but its failing with the
14040 CharSet enumeration. For now try/catch will do.
14042 * typemanager.cs: Do not crash if a struct does not have fields.
14045 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
14047 * expression.cs: cs0213, cant fix a fixed expression.
14050 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
14052 * cs-parser.jay: detect invalid embeded statements gracefully.
14055 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
14057 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
14060 the invocation type may not be a subclass of the tye of the item/
14061 The type of the item must be a subclass of the invocation item.
14066 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
14068 * attribute.cs: Added methods to get a string and a bool from an
14069 attribute. Required to information from AssemblyKeyFileAttribute,
14070 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
14071 * codegen.cs: Modified AssemblyName creation to include support for
14072 strongnames. Catch additional exceptions to report them as CS1548.
14073 * compiler.csproj: Updated include CryptoConvert.cs.
14074 * compiler.csproj.user: Removed file - user specific configuration.
14075 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
14076 Mono.Security assembly. The original class is maintained and tested in
14077 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
14078 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
14079 like CSC 8.0 (C# v2) supports.
14080 * Makefile: Added CryptoConvert.cs to mcs sources.
14081 * rootcontext.cs: Added new options for strongnames.
14083 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
14085 * driver.cs: For --expect-error, report error code `2'
14086 if the program compiled with no errors, error code `1' if
14087 it compiled with an error other than the one expected.
14089 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
14091 * compiler.csproj: Updated for Visual Studio .NET 2003.
14092 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
14093 * compiler.sln: Updated for Visual Studio .NET 2003.
14095 2004-03-24 Ravi Pratap M <ravi@ximian.com>
14097 * expression.cs: Fix bug #47234. We basically need to apply the
14098 rule that we prefer the conversion of null to a reference type
14099 when faced with a conversion to 'object' (csc behaviour).
14101 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14103 * statement.cs: Shorter form for foreach, eliminates
14104 a local variable. r=Martin.
14106 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14108 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
14109 checks if we can use brtrue/brfalse to test for 0.
14110 * expression.cs: use the above in the test for using brtrue/brfalse.
14111 cleanup code a bit.
14113 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14115 * expression.cs: Rewrite string concat stuff. Benefits:
14117 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
14118 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
14119 rather than a concat chain.
14121 * typemanager.cs: Add lookups for more concat overloads.
14123 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14125 * expression.cs: Emit shorter il code for array init.
14142 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
14144 * statement.cs: Before, two switch blocks would be merged if the
14145 total size of the blocks (end_item - begin_item + 1) was less than
14146 two times the combined sizes of the blocks.
14148 Now, it will only merge if after the merge at least half of the
14153 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
14155 * class.cs : csc build fix for GetMethods(). See bug #52503.
14157 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
14159 * expression.cs: Make sure fp comparisons work with NaN.
14160 This fixes bug #54303. Mig approved this patch a long
14161 time ago, but we were not able to test b/c the runtime
14164 2004-03-19 Miguel de Icaza <miguel@ximian.com>
14166 * ecore.cs (TypExpr.GetHashCode): implement this overload.
14168 2004-03-19 Martin Baulig <martin@ximian.com>
14170 * class.cs (MemberCore.IsDuplicateImplementation): Report the
14171 error here and not in our caller.
14173 2004-03-19 Martin Baulig <martin@ximian.com>
14175 * interface.cs: Completely killed this file.
14176 (Interface): We're now a TypeContainer and live in class.cs.
14178 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
14179 argument; we're now also called for interfaces.
14180 (TypeContainer.DefineMembers): Allow this method being called
14182 (TypeContainer.GetMethods): New public method; formerly known as
14183 Interface.GetMethod(). This is used by PendingImplementation.
14184 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
14185 it's now private and non-static.
14186 (Interface): Moved this here; it's now implemented similar to
14188 (Method, Property, Event, Indexer): Added `bool is_interface'
14189 argument to their .ctor's.
14190 (MemberBase.IsInterface): New public field.
14192 * cs-parser.jay: Create normal Method, Property, Event, Indexer
14193 instances instead of InterfaceMethod, InterfaceProperty, etc.
14194 (opt_interface_base): Removed; we now use `opt_class_base' instead.
14195 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
14197 2004-03-19 Martin Baulig <martin@ximian.com>
14199 * class.cs (MethodCore.IsDuplicateImplementation): New private
14200 method which does the CS0111 checking.
14201 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
14202 Use IsDuplicateImplementation().
14204 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
14206 * decl.cs (FindMemberToOverride): New method to find the correct
14207 method or property to override in the base class.
14209 - Make Method/Property use the above method to find the
14210 version in the base class.
14211 - Remove the InheritableMemberSignatureCompare as it is now
14214 This patch makes large code bases much faster to compile, as it is
14215 O(n) rather than O(n^2) to do this validation.
14217 Also, it fixes bug 52458 which is that nested classes are not
14218 taken into account when finding the base class member.
14220 Reviewed/Approved by Martin.
14222 2004-03-17 Marek Safar <marek.safar@seznam.cz>
14224 * interface.cs: In all interface classes removed redundant
14225 member initialization.
14227 2004-03-16 Martin Baulig <martin@ximian.com>
14229 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
14231 2004-03-15 Miguel de Icaza <miguel@ximian.com>
14233 * decl.cs (DefineTypeAndParents): New helper method to define a
14234 type's containers before the type itself is defined; This is a
14235 bug exposed by the recent changes to Windows.Forms when an
14236 implemented interface was defined inside a class that had not been
14239 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
14241 (Check): Loop correctly to report errors modifiers
14242 (UNSAFE was not in the loop, since it was the same as TOP).
14244 * interface.cs: Every interface member now takes a ModFlags,
14245 instead of a "is_new" bool, which we set on the base MemberCore.
14247 Every place where we called "UnsafeOk" in the interface, now we
14248 call the proper member (InterfaceMethod.UnsafeOK) instead to get
14249 the unsafe settings from the member declaration instead of the
14250 container interface.
14252 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
14254 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
14255 `set_indexer_name' to the pending bits (one per type).
14257 We fixed a bug today that was picking the wrong method to
14258 override, since for properties the existing InterfaceMethod code
14259 basically ignored the method name. Now we make sure that the
14260 method name is one of the valid indexer names.
14262 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
14264 * support.cs (SeekableStreamReader): Keep track of stream byte
14265 positions and don't mix them with character offsets to the buffer.
14267 Patch from Gustavo Giráldez
14269 2004-03-15 Marek Safar <marek.safar@seznam.cz>
14271 * interface.cs (InterfaceSetGetBase): Removed double member
14272 initialization, base class does it as well.
14274 2004-03-13 Martin Baulig <martin@ximian.com>
14276 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
14277 when compiling corlib.
14279 2004-03-13 Miguel de Icaza <miguel@ximian.com>
14281 * convert.cs (ExplicitConversion): We were reporting an error on
14282 certain conversions (object_type source to a value type, when the
14283 expression was `null') before we had a chance to pass it through
14284 the user defined conversions.
14286 * driver.cs: Replace / and \ in resource specifications to dots.
14289 * class.cs: Add check for duplicate operators. Fixes 52477
14291 2004-03-11 Miguel de Icaza <miguel@ximian.com>
14293 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
14294 that are in the middle of the statements, not only at the end.
14297 * class.cs (TypeContainer.AddField): No longer set the
14298 `HaveStaticConstructor' flag, now we call it
14299 `UserDefineStaticConstructor' to diferentiate the slightly
14300 semantic difference.
14302 The situation is that we were not adding BeforeFieldInit (from
14303 Modifiers.TypeAttr) to classes that could have it.
14304 BeforeFieldInit should be set to classes that have no static
14309 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
14311 And most importantly Zoltan's comment:
14313 http://bugzilla.ximian.com/show_bug.cgi?id=44229
14315 "I think beforefieldinit means 'it's ok to initialize the type sometime
14316 before its static fields are used', i.e. initialization does not need
14317 to be triggered by the first access to the type. Setting this flag
14318 helps the JIT to compile better code, since it can run the static
14319 constructor at JIT time, and does not need to generate code to call it
14320 (possibly lots of times) at runtime. Unfortunately, mcs does not set
14321 this flag for lots of classes like String.
14323 csc sets this flag if the type does not have an explicit static
14324 constructor. The reasoning seems to be that if there are only static
14325 initalizers for a type, and no static constructor, then the programmer
14326 does not care when this initialization happens, so beforefieldinit
14329 This bug prevents the AOT compiler from being usable, since it
14330 generates so many calls to mono_runtime_class_init that the AOT code
14331 is much slower than the JITted code. The JITted code is faster,
14332 because it does not generate these calls if the vtable is type is
14333 already initialized, which is true in the majority of cases. But the
14334 AOT compiler can't do this."
14336 2004-03-10 Miguel de Icaza <miguel@ximian.com>
14338 * class.cs (MethodData.Emit): Refactor the code so symbolic
14339 information is generated for destructors; For some reasons we
14340 were taking a code path that did not generate symbolic information
14343 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
14345 * class.cs: Create a Constructor.CheckBase method that
14346 takes care of all validation type code. The method
14347 contains some code that was moved from Define.
14349 It also includes new code that checks for duplicate ctors.
14350 This fixes bug #55148.
14352 2004-03-09 Joshua Tauberer <tauberer@for.net>
14354 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
14355 a { ... }-style array creation invokes EmitStaticInitializers
14356 which is not good for reference-type arrays. String, decimal
14357 and now null constants (NullCast) are not counted toward
14358 static initializers.
14360 2004-03-05 Martin Baulig <martin@ximian.com>
14362 * location.cs (SourceFile.HasLineDirective): New public field;
14363 specifies whether the file contains or is referenced by a "#line"
14365 (Location.DefineSymbolDocuments): Ignore source files which
14366 either contain or are referenced by a "#line" directive.
14368 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
14370 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
14371 direct access to our parent, so check the method inline there.
14373 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
14375 * expression.cs (Invocation.EmitCall): Miguel's last commit
14376 caused a regression. If you had:
14381 In Foo the implict this would be null.
14383 2004-02-27 Miguel de Icaza <miguel@ximian.com>
14385 * expression.cs (Invocation.EmitCall): If the method is not
14386 virtual, do not emit a CallVirt to it, use Call.
14388 * typemanager.cs (GetFullNameSignature): Improve the method to
14389 cope with ".ctor" and replace it with the type name.
14391 * class.cs (ConstructorInitializer.Resolve): Now the method takes
14392 as an argument the ConstructorBuilder where it is being defined,
14393 to catch the recursive constructor invocations.
14395 2004-02-26 Miguel de Icaza <miguel@ximian.com>
14397 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
14398 routines to check if a type is an enumerable/enumerator allow
14399 classes that implement the IEnumerable or IEnumerator interfaces.
14401 * class.cs (Property, Operator): Implement IIteratorContainer, and
14402 implement SetYields.
14404 (Property.Define): Do the block swapping for get_methods in the
14405 context of iterators. We need to check if Properties also
14406 include indexers or not.
14408 (Operator): Assign the Block before invoking the
14409 OperatorMethod.Define, so we can trigger the Iterator code
14412 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
14413 Property and Operator classes are not created when we parse the
14414 declarator but until we have the block completed, so we use a
14415 singleton SimpleIteratorContainer.Simple to flag whether the
14416 SetYields has been invoked.
14418 We propagate this setting then to the Property or the Operator to
14419 allow the `yield' to function.
14421 2004-02-25 Marek Safar <marek.safar@seznam.cz>
14423 * codegen.cs: Implemented attribute support for modules.
14424 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
14425 Assembly/Module functionality.
14427 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
14428 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
14429 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
14431 2004-02-16 Marek Safar <marek.safar@seznam.cz>
14433 * interface.cs (FindMembers): The operation is performed on all base
14434 interfaces and not only on the first. It is required for future CLS Compliance patch.
14436 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
14438 * statement.cs, codegen.cs:
14439 This patch deals with patterns such as:
14441 public class List : IEnumerable {
14443 public MyEnumerator GetEnumerator () {
14444 return new MyEnumerator(this);
14447 IEnumerator IEnumerable.GetEnumerator () {
14451 public struct MyEnumerator : IEnumerator {
14456 Before, there were a few things we did wrong:
14457 1) we would emit callvirt on a struct, which is illegal
14458 2) we emited ldarg when we needed to emit ldarga
14459 3) we would mistakenly call the interface methods on an enumerator
14460 type that derived from IEnumerator and was in another assembly. For example:
14462 public class MyEnumerator : IEnumerator
14464 Would have the interface methods called, even if there were public impls of the
14465 method. In a struct, this lead to invalid IL code.
14467 2004-02-11 Marek Safar <marek.safar@seznam.cz>
14469 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
14472 * delegate.cs (Define): Fixed crash when delegate type is undefined.
14474 2004-02-11 Miguel de Icaza <miguel@ximian.com>
14476 * cs-parser.jay: Fix small regression: we were not testing V2
14477 compiler features correctly.
14479 * interface.cs: If the emit context is null, then create one
14481 2004-02-09 Marek Safar <marek.safar@seznam.cz>
14483 * decl.cs (GetSignatureForError): New virtual method to get full name
14484 for error messages.
14486 * attribute.cs (IAttributeSupport): New interface for attribute setting.
14487 Now it is possible to rewrite ApplyAttributes method to be less if/else.
14489 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
14490 Duplicated members and code in these classes has been removed.
14491 Better encapsulation in these classes.
14493 2004-02-07 Miguel de Icaza <miguel@ximian.com>
14495 * assign.cs (Assign.DoResolve): When dealing with compound
14496 assignments, there is a new rule in ECMA C# 2.4 (might have been
14497 there before, but it is documented here) that states that in:
14501 If b is of type int, and the `op' is a shift-operator, then the
14502 above is evaluated as:
14506 * expression.cs (Binary.ResolveOperator): Instead of testing for
14507 int/uint/long/ulong, try to implicitly convert to any of those
14508 types and use that in pointer arithmetic.
14510 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
14511 method to print information for from the type, not from the
14512 null-method we were given.
14514 2004-02-01 Duncan Mak <duncan@ximian.com>
14516 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
14517 parsing for cmd, fixes bug #53694.
14519 2004-02-04 Marek Safar <marek.safar@seznam.cz>
14521 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
14522 in the member name duplication tests. Property and operator name duplication
14523 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
14525 2004-02-03 Marek Safar <marek.safar@seznam.cz>
14527 * interface.cs (PopulateMethod): Fixed crash when interface method
14528 returns not existing type (error test cs0246-3.cs).
14530 2004-02-02 Ravi Pratap M <ravi@ximian.com>
14532 * cs-parser.jay (interface_accessors): Re-write actions to also
14533 store attributes attached to get and set methods. Fix spelling
14536 (inteface_property_declaration): Modify accordingly.
14538 (InterfaceAccessorInfo): New helper class to store information to pass
14539 around between rules that use interface_accessors.
14541 * interface.cs (Emit): Apply attributes on the get and set
14542 accessors of properties and indexers too.
14544 * attribute.cs (ApplyAttributes): Modify accordingly to use the
14545 right MethodBuilder when applying attributes to the get and set accessors.
14547 2004-01-31 Miguel de Icaza <miguel@ximian.com>
14549 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
14551 2004-01-26 Miguel de Icaza <miguel@ximian.com>
14553 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
14555 2004-01-25 Miguel de Icaza <miguel@ximian.com>
14557 * cs-parser.jay: Remove YIELD token, instead use the new grammar
14558 changes that treat `yield' specially when present before `break'
14559 or `return' tokens.
14561 * cs-tokenizer.cs: yield is no longer a keyword.
14563 2004-01-23 Marek Safar <marek.safar@seznam.cz>
14565 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
14566 setting for default constructors.
14567 For default constructors are almost every time set wrong Modifier. The
14568 generated IL code has been alright. But inside mcs this values was
14569 wrong and this was reason why several of my CLS Compliance tests
14572 2004-01-22 Martin Baulig <martin@ximian.com>
14574 * cs-parser.jay (namespace_or_type_name): Return an Expression,
14575 not a QualifiedIdentifier. This is what `type_name_expression'
14576 was previously doing.
14577 (type_name_expression): Removed; the code is now in
14578 `namespace_or_type_name'.
14579 (qualified_identifier): Removed, use `namespace_or_type_name'
14581 (QualifiedIdentifier): Removed this class.
14583 2004-01-22 Martin Baulig <martin@ximian.com>
14585 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
14586 not a string as alias name.
14588 2004-01-21 Miguel de Icaza <miguel@ximian.com>
14590 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
14591 #52730 bug, and instead compute correctly the need to use a
14592 temporary variable when requesting an address based on the
14593 static/instace modified of the field and the constructor.
14595 2004-01-21 Martin Baulig <martin@ximian.com>
14597 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
14598 class and namespace before looking up aliases. Fixes #52517.
14600 2004-01-21 Martin Baulig <martin@ximian.com>
14602 * flowanalysis.cs (UsageVector.Merge): Allow variables being
14603 assinged in a 'try'; fixes exception4.cs.
14605 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14606 * class.cs : Implemented parameter-less constructor for TypeContainer
14608 * decl.cs: Attributes are now stored here. New property OptAttributes
14610 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
14612 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
14614 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14616 * typemanager.cs (CSharpSignature): Now reports also inner class name.
14617 (CSharpSignature): New method for indexer and property signature.
14619 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14621 * pending.cs (IsVirtualFilter): Faster implementation.
14623 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14625 * typemanager.cs: Avoid inclusion of same assembly more than once.
14627 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14629 * cs-parser.jay: Fixed problem where the last assembly attribute
14630 has been applied also to following declaration (class, struct, etc.)
14632 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14634 * class.cs: Added error CS0538, CS0539 reporting.
14635 Fixed crash on Microsoft runtime when field type is void.
14637 * cs-parser.jay: Added error CS0537 reporting.
14639 * pending.cs: Added error CS0535 reporting.
14640 Improved error report for errors CS0536, CS0534.
14642 2004-01-20 Miguel de Icaza <miguel@ximian.com>
14644 Merge a few bits from the Anonymous Method MCS tree.
14646 * statement.cs (ToplevelBlock): New class for toplevel methods,
14647 will hold anonymous methods, lifted variables.
14649 * cs-parser.jay: Create toplevel blocks for delegates and for
14650 regular blocks of code.
14652 2004-01-20 Martin Baulig <martin@ximian.com>
14654 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
14655 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
14656 and `NeedExplicitReturn'; added `IsLastStatement'.
14657 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
14658 have a `ReturnLabel' or we're not unreachable.
14660 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
14661 child's reachability; don't just override ours with it. Fixes
14662 #58058 (lluis's example).
14663 (FlowBranching): Added public InTryOrCatch(), InCatch(),
14664 InFinally(), InLoop(), InSwitch() and
14665 BreakCrossesTryCatchBoundary() methods.
14667 * statement.cs (Return): Do all error checking in Resolve().
14668 Unless we are the last statement in a top-level block, always
14669 create a return label and jump to it.
14670 (Break, Continue): Do all error checking in Resolve(); also make
14671 sure we aren't leaving a `finally'.
14672 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
14673 statement in a top-level block.
14674 (Block.Flags): Added `IsDestructor'.
14675 (Block.IsDestructor): New public property.
14677 2004-01-20 Martin Baulig <martin@ximian.com>
14679 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
14681 2004-01-20 Martin Baulig <martin@ximian.com>
14683 * statement.cs (Statement.ResolveUnreachable): New public method.
14684 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
14685 (Block.Resolve): Resolve unreachable statements.
14687 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14689 * expression.cs: We need to fix the case where we do
14690 not have a temp variable here.
14692 * assign.cs: Only expression compound assignments need
14693 temporary variables.
14695 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14697 * flowanalysis.cs: Reduce memory allocation in a few ways:
14698 - A block with no variables should not allocate a bit
14700 - A method with no out parameters does not need any tracking
14701 for assignment of the parameters, so we need not allocate
14704 public readonly Type[] VariableTypes;
14705 public readonly string[] VariableNames;
14706 Are redundant. The data is already stored in the variable
14707 map, so we need not allocate another array for it.
14708 - We need to add alot of checks for if (params | locals) == null
14709 due to the first two changes.
14711 2004-01-18 Miguel de Icaza <miguel@ximian.com>
14713 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
14714 implement IMemoryLocation, we store a copy on a local variable and
14715 take the address of it. Patch from Benjamin Jemlich
14717 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
14718 to use a special "type_name_expression" rule which reduces the
14719 number of "QualifiedIdentifier" classes created, and instead
14720 directly creates MemberAccess expressions.
14722 2004-01-17 Miguel de Icaza <miguel@ximian.com>
14724 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
14725 that fixes #52853. Null literal assignment to ValueType
14727 * class.cs (MethodData.Emit): Instead of checking the name of the
14728 method to determine if its a destructor, create a new derived
14729 class from Method called Destructor, and test for that.
14731 * cs-parser.jay: Create a Destructor object instead of a Method.
14733 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
14737 2004-01-16 Miguel de Icaza <miguel@ximian.com>
14739 * expression.cs (Binary.ResolveOperator): Perform an implicit
14740 conversion from MethodGroups to their delegate types on the
14741 Addition operation.
14743 * delegate.cs: Introduce a new class DelegateCreation that is the
14744 base class for `NewDelegate' and `ImplicitDelegateCreation',
14745 factor some code in here.
14747 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
14748 conversion from MethodGroups to compatible delegate types.
14750 * ecore.cs (Expression.Resolve): Do not flag error 654
14751 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
14752 we allow conversions from MethodGroups to delegate types now.
14754 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
14755 assignments in v2 either.
14757 2004-01-10 Miguel de Icaza <miguel@ximian.com>
14759 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
14760 static read-only fields in ctors.
14762 Applied patch from Benjamin Jemlich
14764 * expression.cs (UnaryMutator): Avoid leaking local variables.
14766 2004-01-09 Miguel de Icaza <miguel@ximian.com>
14768 * cs-tokenizer.cs (IsCastToken): Allow the various native types
14769 here to return true, as they can be used like this:
14771 (XXX) int.MEMBER ()
14773 Fixed 49836 and all the other dups
14775 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
14777 * driver.cs: Implement /win32res and /win32icon.
14779 2004-01-08 Miguel de Icaza <miguel@ximian.com>
14781 * cs-parser.jay: Add a rule to improve error handling for the
14782 common mistake of placing modifiers after the type.
14784 2004-01-07 Miguel de Icaza <miguel@ximian.com>
14786 * cs-parser.jay (interface_event_declaration): Catch
14787 initialization of events on interfaces, and report cs0068
14789 * cs-parser.jay (interface_event_declaration): Catch
14790 initialization of events.
14792 * ecore.cs: Better report missing constructors.
14794 * expression.cs (Binary.ResolveOperator): My previous bug fix had
14795 the error reporting done in the wrong place. Fix.
14797 * expression.cs (Binary.ResolveOperator): Catch the
14798 operator + (E x, E y) error earlier, and later allow for implicit
14799 conversions in operator +/- (E e, U x) from U to the underlying
14802 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
14803 52596, if the container class is abstract, the default constructor
14804 is protected otherwise its public (before, we were always public).
14806 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
14809 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
14810 Jemlich that fixes bug #52597, MCS was generating invalid code for
14811 idisposable structs. Thanks to Ben for following up with this
14814 2004-01-06 Miguel de Icaza <miguel@ximian.com>
14816 * driver.cs: Allow assemblies without code to be generated, fixes
14819 2004-01-07 Nick Drochak <ndrochak@gol.com>
14821 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
14823 2004-01-05 Miguel de Icaza <miguel@ximian.com>
14825 * cs-parser.jay: Add rules to improve error reporting if fields or
14826 methods are declared at the namespace level (error 116)
14828 * Add rules to catch event add/remove
14830 2004-01-04 David Sheldon <dave-mono@earth.li>
14832 * expression.cs: Added matching ")" to error message for
14835 2004-01-03 Todd Berman <tberman@gentoo.org>
14837 * ecore.cs, attribute.cs:
14838 Applying fix from #52429.
14840 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14842 * ecore.cs, expression.cs, statement.cs:
14843 Total rewrite of how we handle branching. We
14844 now handle complex boolean expressions with fewer
14845 jumps. As well if (x == 0) no longer emits a ceq.
14847 if (x is Foo) is much faster now, because we generate
14850 Overall, we get a pretty big improvement on our benchmark
14851 tests. The code we generate is smaller and more readable.
14853 I did a full two-stage bootstrap. The patch was reviewed
14854 by Martin and Miguel.
14856 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14858 * cs-parser.jay: Make primary_expression not take a QI.
14859 we dont need this because the member_access rule covers
14860 us here. So we replace the rule with just IDENTIFIER.
14862 This has two good effects. First, we remove a s/r conflict.
14863 Second, we allocate many fewer QualifiedIdentifier objects.
14865 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14867 * attribute.cs: Handle MarshalAs attributes as pseudo, and
14868 set the correct information via SRE. This prevents
14869 hanging on the MS runtime. Fixes #29374.
14871 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14873 * convert.cs: correctly handle conversions to value types
14874 from Enum and ValueType as unboxing conversions.
14876 Fixes bug #52569. Patch by Benjamin Jemlich.
14878 2004-01-02 Ravi Pratap <ravi@ximian.com>
14880 * expression.cs (BetterConversion): Prefer int -> uint
14881 over int -> ulong (csc's behaviour). This fixed bug #52046.
14883 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
14885 * decl.cs (MemberCache.FindMembers): now returns a
14888 * typemanager.cs: In general, go with with ^^.
14889 (CopyNewMethods): take an IList.
14890 (RealMemberLookup): Only allocate an arraylist
14891 if we copy from two sets of methods.
14893 This change basically does two things:
14894 1) Fewer array lists allocated due to CopyNewMethods.
14895 2) the explicit cast in MemberList costed ALOT.
14897 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
14899 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
14900 a hashtable to avoid needless string allocations when an identifier is
14901 used more than once (the common case).
14903 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
14905 * pending.cs: MS's TypeBuilder.GetInterfaces ()
14906 is broken, it will not return anything. So, we
14907 have to use the information we have in mcs to
14910 * typemanager.cs: Add a cache for GetInterfaces,
14911 since this will now be used more often (due to ^^)
14913 (GetExplicitInterfaces) New method that gets the
14914 declared, not effective, interfaces on a type
14915 builder (eg, if you have interface IFoo, interface
14916 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
14919 This patch makes MCS able to bootstrap itself on
14922 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
14924 * expression.cs: Remove the Nop's that Miguel put
14927 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14929 * report.cs, codegen.cs: Give the real stack trace to
14930 the error when an exception is thrown.
14932 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14934 * decl.cs: only allocate hashtables for ifaces if
14937 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14939 * expression.cs: fix the error from cs0121-2.cs
14940 (a parent interface has two child interfaces that
14941 have a function with the same name and 0 params
14942 and the function is called through the parent).
14944 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
14946 * class.cs, rootcontext.cs, typmanager.cs: do not
14949 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
14951 * codegen.cs: remove stack for the ec flow branching.
14952 It is already a linked list, so no need.
14954 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
14956 * Makefile: Allow custom profiler here.
14958 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
14960 * typemanager.cs (LookupType):
14961 - Use a static char [], because split takes
14962 a param array for args, so it was allocating
14964 - Do not store true in a hashtable, it boxes.
14966 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
14968 * flowanalysis.cs: bytify common enums.
14970 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14972 * modifiers.cs: Add a new set of flags for the
14973 flags allowed on explicit interface impls.
14974 * cs-parser.jay: catch the use of modifiers in
14975 interfaces correctly.
14976 * class.cs: catch private void IFoo.Blah ().
14978 All related to bug #50572.
14980 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14982 * decl.cs: Rewrite the consistant accessability checking.
14983 Accessability is not linear, it must be implemented in
14984 a tableish way. Fixes #49704.
14986 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14988 * expression.cs: Handle negation in a checked context.
14989 We must use subtraction from zero. Fixes #38674.
14991 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
14993 * class.cs: Ignore static void main in DLLs.
14994 * rootcontext.cs: Handle the target type here,
14995 since we are have to access it from class.cs
14996 * driver.cs: account for the above.
14998 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
15000 * report.cs: Give line numbers and files if available.
15002 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
15004 * driver.cs: Implement /addmodule.
15006 * typemanager.cs: Change 'modules' field so it now contains Modules not
15009 2003-12-20 Martin Baulig <martin@ximian.com>
15011 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
15012 (FieldBase.IsAssigned): Removed this field.
15013 (FieldBase.SetAssigned): New public method.
15014 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
15016 2003-12-20 Martin Baulig <martin@ximian.com>
15018 * expression.cs (LocalVariableReference.DoResolve): Don't set
15019 `vi.Used' if we're called from DoResolveLValue().
15021 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
15022 returns the usage vector it just merged into the current one -
15023 pass this one to UsageWarning().
15024 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
15025 of the `EmitContext', don't call this recursively on our children.
15027 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
15029 * driver.cs: Implement /target:module.
15031 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
15033 * support.cs (CharArrayHashtable): New helper class.
15035 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
15036 char arrays, not strings, so we can avoid creating a string in
15037 consume_identifier if the identifier is a keyword.
15039 2003-12-16 Martin Baulig <martin@ximian.com>
15041 * statement.cs (LocalInfo.Assigned): Removed this property.
15042 (LocalInfo.Flags): Removed `Assigned'.
15043 (LocalInfo.IsAssigned): New public method; takes the EmitContext
15044 and uses flow analysis.
15045 (Block.UsageWarning): Made this method private.
15046 (Block.Resolve): Call UsageWarning() if appropriate.
15048 * expression.cs (LocalVariableReference.DoResolve): Always set
15049 LocalInfo.Used here.
15051 2003-12-13 Martin Baulig <martin@ximian.com>
15053 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
15054 any value here; we're now using flow analysis to figure out
15055 whether a statement/block returns a value.
15057 2003-12-13 Martin Baulig <martin@ximian.com>
15059 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
15061 (FlowBranching.MergeFinally): Don't call
15062 `branching.CheckOutParameters()' here, this is called in
15064 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
15065 when adding the `finally' vector.
15067 2003-12-13 Martin Baulig <martin@ximian.com>
15070 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
15071 actually work and also fix #48962.
15073 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
15075 * decl.cs: Do not check System.Object for nested types,
15076 since we know it does not have any. Big bang for buck:
15079 Run 1: 8.35 seconds
15080 Run 2: 8.32 seconds
15081 corlib: 17.99 seconds
15083 Run 1: 8.17 seconds
15084 Run 2: 8.17 seconds
15085 corlib: 17.39 seconds
15087 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
15089 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
15090 time we are returning 0 members, so we save alot here.
15092 2003-12-11 Martin Baulig <martin@ximian.com>
15094 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
15095 `MergeChild()', also just take the `FlowBranching' as argument;
15096 call Merge() on it and return the result.
15097 (FlowBranching.Merge): We don't need to do anything if we just
15100 2003-12-11 Martin Baulig <martin@ximian.com>
15102 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
15103 them in an `ArrayList' to reduce memory usage. Thanks to Ben
15104 Maurer for this idea.
15106 2003-12-11 Martin Baulig <martin@ximian.com>
15108 * flowanalysis.cs (MergeResult): This class is now gone; we now
15109 use the `UsageVector' for this. The reason for this is that if a
15110 branching just has one sibling, we don't need to "merge" them at
15111 all - that's the next step to do.
15112 (FlowBranching.Merge): We now return a `UsageVector' instead of a
15115 2003-12-11 Martin Baulig <martin@ximian.com>
15117 Reworked flow analyis and made it more precise and bug-free. The
15118 most important change is that we're now using a special `Reachability'
15119 class instead of having "magic" meanings of `FlowReturns'. I'll
15120 do some more cleanups and optimizations and also add some more
15121 documentation this week.
15123 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
15124 largely reworked this class.
15125 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
15126 the new `Reachability' class instead of having "magic" values here.
15127 (FlowBranching): We're now using an instance of `Reachability'
15128 instead of having separate `Returns', `Breaks' etc. fields.
15130 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
15131 based on flow analysis; ignore the return value of block.Emit ().
15133 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
15135 * driver.cs typemanager.cs: Find the mono extensions to corlib even
15136 if they are private.
15138 2003-12-09 Martin Baulig <martin@ximian.com>
15140 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
15141 call them directly on the UsageVector.
15143 2003-12-09 Martin Baulig <martin@ximian.com>
15145 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
15146 Changed return type from `FlowReturns' to `Reachability'.
15148 2003-12-09 Martin Baulig <martin@ximian.com>
15150 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
15151 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
15152 `Reachable' fields with a single `Reachability' one.
15154 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15156 * class.cs (FindMembers): Remove foreach's.
15161 Run 1: 8.74 seconds
15162 Run 2: 8.71 seconds
15165 Run 1: 8.64 seconds
15166 Run 2: 8.58 seconds
15169 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15174 This patch does a few things:
15175 1. EmptyStatement is now a singleton, so it is never reallocated.
15176 2. All blah is EmptyStatement constructs have been changed to
15177 blah == EmptyStatement.Value, which is much faster and valid
15178 now that EmptyStatement is a singleton.
15179 3. When resolving a block, rather than allocating a new array for
15180 the non-empty statements, empty statements are replaced with
15181 EmptyStatement.Value
15182 4. Some recursive functions have been made non-recursive.
15183 Mainly the performance impact is from (3), however (1) and (2) are needed for
15184 this to work. (4) does not make a big difference in normal situations, however
15185 it makes the profile look saner.
15190 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15191 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15192 Total memory allocated: 56397 KB
15195 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
15196 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
15197 Total memory allocated: 55666 KB
15199 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15201 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
15202 than the hashtable in a hashtable version
15204 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
15205 we always end up concating a string. This results in a huge perf
15206 loss, because many strings have to be tracked by the GC. In this
15207 patch, we first use a hashtable that works with two keys, so that
15208 the strings do not need to be concat'ed.
15212 Run 1: 8.74 seconds
15213 Run 2: 8.71 seconds
15216 Run 1: 8.65 seconds
15217 Run 2: 8.56 seconds
15219 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15221 * Makefile: Add a new target `do-time' that does a quick and simple
15222 profile, leaving easy to parse output.
15224 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
15226 * codegen.cs (Init): Create the dynamic assembly with
15227 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
15229 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
15231 * support.cs: Make the PtrHashtable use only one
15232 instance of its comparer.
15234 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
15236 * typemanager.cs: Fix lookup of GetNamespaces.
15238 2003-11-29 Miguel de Icaza <miguel@ximian.com>
15240 * expression.cs: Removed redundant line.
15242 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
15243 ArrayLists, use for loops with bounds.
15245 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
15248 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
15249 arraylists, use for loop with bounds.
15251 The above three changes give us a 0.071 second performance
15252 improvement out of 3.294 seconds down to 3.223. On my machine
15253 the above changes reduced the memory usage by 1,387 KB during
15254 compiler bootstrap.
15256 * cs-parser.jay (QualifiedIdentifier): New class used to represent
15257 QualifiedIdentifiers. Before we created a new string through
15258 concatenation, and mostly later on, the result would be
15259 manipulated by DecomposeQI through string manipulation.
15261 This reduced the compiler memory usage for bootstrapping from
15262 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
15263 compile times in 0.05 seconds.
15265 2003-11-28 Dick Porter <dick@ximian.com>
15267 * support.cs: Do string compares with the Invariant culture.
15275 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
15276 the comparison is done with the Invariant culture.
15278 2003-11-27 Miguel de Icaza <miguel@ximian.com>
15280 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
15281 GetEnumerator method.
15283 (ProbeCollectionType): Iterate starting at the most specific type
15284 upwards looking for a GetEnumerator
15286 * expression.cs: Shift count can be up to 31 for int/uint and 63
15289 2003-11-26 Miguel de Icaza <miguel@ximian.com>
15291 * statement.cs (Block.LookupLabel): Also look for the label on the
15292 children blocks. Use a hash table to keep track of visited
15295 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
15296 we actually did transform the other operand, otherwise fall back
15297 to the common codepath that casts to long.
15299 * cs-tokenizer.cs: Use the same code pattern as the int case.
15300 Maybe I should do the parsing myself, and avoid depending on the
15301 Parse routines to get this done.
15303 2003-11-25 Miguel de Icaza <miguel@ximian.com>
15305 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15306 which fixes bug 51347. This time test it.
15308 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
15309 attributes for example can not tell the difference between these.
15310 The difference was only a syntax feature of the language.
15312 * attribute.cs: Apply attributes to delegates.
15314 * delegate.cs: Call the apply attributes method.
15316 2003-11-24 Miguel de Icaza <miguel@ximian.com>
15318 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
15319 comparing 0 vs Byte.MinValue, not the value
15321 (ImplicitConversionRequired): When reporting a conversion error,
15322 use error 31 to print out the constant error instead of the
15325 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15326 which fixes bug 51347.
15328 2003-11-22 Miguel de Icaza <miguel@ximian.com>
15330 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
15331 which fixes the -warnaserror command line option.
15333 2003-11-21 Miguel de Icaza <miguel@ximian.com>
15335 * cfold.cs (DoNumericPromotions): During constant folding of
15336 additions on UIntConstant, special case intconstants with
15337 IntConstants like we do on the expression binary operator.
15339 2003-11-12 Miguel de Icaza <miguel@ximian.com>
15341 * convert.cs (ImplicitReferenceConversion): We were missing a case
15342 (System.Enum are not value types or class types, so we need to
15343 classify them separatedly).
15345 * driver.cs: We do not support error 2007.
15347 2003-11-12 Jackson Harper <jackson@ximian.com>
15349 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
15350 system directory. Also use the full file name so users can
15351 libraries names mscorlib-o-tron.dll in a non system dir.
15353 2003-11-10 Martin Baulig <martin@ximian.com>
15355 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
15356 (TypeManager.InitCoreTypes): Initialize them here, but instead of
15357 calling `ResolveType()' on them, directly assign their `Type'.
15359 2003-11-08 Martin Baulig <martin@ximian.com>
15361 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
15362 return value and the `out parent' parameter.
15363 (TypeContainer.DefineType): Moved the CS0644 check into
15364 GetClassBases(). Don't pass the interface types to the
15365 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
15366 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
15368 * ecore.cs (TypeExpr.IsAttribute): New property.
15369 (TypeExpr.GetInterfaces): New method.
15371 * interface.cs (Interface.GetInterfaceTypeByName): Return a
15372 TypeExpr instead of a Type.
15373 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
15374 (Interface.DefineType): Don't pass the interface types to the
15375 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
15376 them later and then call `TypeBulider.AddInterfaceImplementation()'.
15378 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
15379 instead of a `Type[]'.
15380 (TypeManager.RegisterBuilder): Likewise.
15381 (TypeManager.AddUserInterface): Likewise.
15382 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
15383 `Type[]' and also return a `TypeExpr[]'.
15384 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
15386 2003-11-08 Martin Baulig <martin@ximian.com>
15388 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
15391 2003-11-08 Martin Baulig <martin@ximian.com>
15393 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
15394 TypeManager.ResolveExpressionTypes().
15396 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
15397 instead of an Expression.
15398 (TypeExpr): This is now an abstract base class for `TypeExpression'.
15399 (TypeExpression): New public class; formerly known as `TypeExpr'.
15401 * expression.cs (ComposedCast): Derive from TypeExpr.
15403 * typemanager.cs (TypeManager.system_*_expr): These are now
15404 TypExpr's instead of Expression's.
15405 (TypeManager.ResolveExpressionTypes): New public static function;
15406 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
15409 2003-11-06 Miguel de Icaza <miguel@ximian.com>
15411 * expression.cs (New.DoResolve): Do not dereference value that
15412 might be a null return.
15414 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
15415 sure that the constant value has the right type. Fixes an
15416 unreported bug, similar to 50425.
15418 * const.cs (Const.LookupConstantValue): Call
15419 ImplicitStandardConversionExists before doing a conversion to
15420 avoid havng the TypeManager.ChangeType do conversions.
15422 Reduced the number of casts used
15424 (Const.ChangeType): New routine to enable reuse of the constant
15425 type changing code from statement.
15427 * typemanager.cs (ChangeType): Move common initialization to
15428 static global variables.
15432 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
15433 every value type to go through, even if it was void. Fix that.
15435 * cs-tokenizer.cs: Use is_identifier_start_character on the start
15436 character of the define, and the is_identifier_part_character for
15437 the rest of the string.
15439 2003-11-05 Miguel de Icaza <miguel@ximian.com>
15441 * expression.cs (UnaryMutator.EmitCode): When I updated
15442 LocalVariableReference.DoResolve, I overdid it, and dropped an
15443 optimization done on local variable references.
15445 2003-11-04 Miguel de Icaza <miguel@ximian.com>
15447 * ecore.cs: Convert the return from Ldlen into an int.
15449 2003-10-20 Miguel de Icaza <miguel@ximian.com>
15451 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
15452 the accessibility, this is a special case for toplevel non-public
15453 classes (internal for instance).
15455 2003-10-20 Nick Drochak <ndrochak@gol.com>
15457 * ecore.cs: Fix typo and build. Needed another right paren.
15459 2003-10-19 Miguel de Icaza <miguel@ximian.com>
15461 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
15462 `internal' case regular and protected, but not allowing protected
15463 to be evaluated later. Bug 49840
15465 2003-10-15 Miguel de Icaza <miguel@ximian.com>
15467 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
15468 to kb.Nlast, and not the kb.nFirst to isolate the switch
15471 Extract the underlying type, so enumerations of long/ulong are
15472 treated like long/ulong.
15474 2003-10-14 Miguel de Icaza <miguel@ximian.com>
15476 * expression.cs (New): Overload the meaning of RequestedType to
15477 track the possible creation of the NewDelegate type, since
15478 DoResolve is invoked more than once for new constructors on field
15481 See bugs: #48800 and #37014
15483 * cs-parser.jay (declare_local_constants): Take an arraylist
15484 instead of a single constant.
15486 (local_constant_declaration): It should take a
15487 constant_declarators, not a constant_declarator. Fixes 49487
15489 * convert.cs: Fix error report.
15491 2003-10-13 Jackson Harper <jackson@ximian.com>
15493 * typemanager.cs (TypeToCoreType): Add float and double this fixes
15496 2003-10-09 Martin Baulig <martin@ximian.com>
15498 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
15500 (MethodCore.DoDefineParameters): Removed the TypeContainer
15501 argument; use the DeclSpace which was passed to the .ctor instead.
15502 (MethodCore.CheckParameter): Take a DeclSpace instead of a
15503 TypeContainer; we only need a DeclSpace here.
15505 2003-10-09 Martin Baulig <martin@ximian.com>
15507 * class.cs (MethodData): Added additional `DeclSpace ds' argument
15509 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
15510 EmitContext's .ctor.
15512 2003-10-09 Martin Baulig <martin@ximian.com>
15514 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
15515 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
15516 AsAccessible(), moved them as well.
15518 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
15520 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
15522 * cs-parser.jay : Renamed yyName to yyNames related to jay.
15524 2003-10-07 Miguel de Icaza <miguel@ximian.com>
15526 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
15527 generation for >=, as spotted by Paolo, bug 48679.
15528 Patch from David Waite.
15530 * cs-tokenizer.cs: Add handling for #pragma.
15532 * cs-parser.jay: Allow for both yield and yield return in the
15533 syntax. The anti-cobolization of C# fight will go on!
15535 * class.cs (TypeBuilder.DefineType): Catch error condition here
15536 (Parent.DefineType erroring out and returning null).
15538 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15539 coping with enumerations variables, we were mistakenly processing
15540 them as a regular value type instead of built-in types. Fixes the
15543 * typemanager.cs (IsBuiltinOrEnum): New method.
15545 2003-09-30 Miguel de Icaza <miguel@ximian.com>
15547 * cs-parser.jay: Upgrade: yield now needs the return clause.
15549 2003-09-19 Martin Baulig <martin@ximian.com>
15551 * decl.cs (MemberCache.SetupCacheForInterface): Take a
15552 `MemberCache parent' argument. Normally, an interface doesn't
15553 have a parent type except System.Object, but we use this in gmcs
15554 for generic type parameters.
15556 2003-09-18 Martin Baulig <martin@ximian.com>
15558 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
15559 on `type.IsInterface'; don't check whether the type has a parent
15560 to determine whether it's an interface.
15562 2003-09-15 Martin Baulig <martin@ximian.com>
15564 * class.cs (TypeContainer.DefineType): Added an error flag to
15565 avoid reporting duplicate CS0146's ("class definition is
15568 * driver.cs (Driver.MainDriver): Abort if
15569 RootContext.ResolveTree() reported any errors.
15571 2003-09-07 Martin Baulig <martin@ximian.com>
15573 * report.cs (Error, Warning): Added overloaded versions which take
15574 a `params object[] args' and call String.Format().
15576 2003-09-07 Martin Baulig <martin@ximian.com>
15578 * decl.cs (DeclSpace..ctor): Don't call
15579 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
15580 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
15581 (DeclSpace.RecordDecl): New method.
15583 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
15585 2003-09-02 Ravi Pratap <ravi@ximian.com>
15587 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
15588 value attributes to be applied to ParameterBuilders.
15590 * class.cs (MethodCore.LabelParameters): Make static and more
15591 generic so that it can be used from other places - like interface
15592 methods, for instance.
15594 * interface.cs (Interface.Emit): Call LabelParameters before
15595 emitting attributes on the InterfaceMethod.
15597 2003-08-26 Martin Baulig <martin@ximian.com>
15599 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
15600 resolving aliases; fixes #47927.
15602 2003-08-26 Martin Baulig <martin@ximian.com>
15604 * statement.cs (Using.DoResolve): This is internally emitting a
15605 try/finally clause, so we need to set ec.NeedExplicitReturn if we
15606 do not always return. Fixes #47681.
15608 2003-08-26 Martin Baulig <martin@ximian.com>
15610 * decl.cs (MemberCore): Moved WarningNotHiding(),
15611 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
15613 (AdditionResult): Make this nested in DeclSpace.
15614 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
15615 argument; call NamespaceEntry.Define() unless we're nested in a
15618 * namespace.cs (Namespace.DefineName): New public function. This
15619 is called from DeclSpace's .ctor to add
15620 (Namespace.Lookup): Include DeclSpaces in the lookup.
15622 * class.cs (Operator): Derive from MemberBase, not MemberCore.
15624 * const.cs (Const): Derive from MemberBase, not MemberCore.
15626 2003-08-25 Martin Baulig <martin@ximian.com>
15628 * convert.cs (Convert.ExplicitReferenceConversion): When
15629 converting from an interface type to a class, unbox if the target
15630 type is a struct type. Fixes #47822.
15632 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15634 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
15637 2003-08-22 Martin Baulig <martin@ximian.com>
15639 * class.cs (TypeManager.DefineType): When defining a nested type,
15640 call DefineType() on our parent; fixes #47801.
15642 2003-08-22 Martin Baulig <martin@ximian.com>
15644 * class.cs (MethodData.Define): While checking if a method is an
15645 interface implementation, improve the test a bit more to fix #47654.
15647 2003-08-22 Martin Baulig <martin@ximian.com>
15649 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
15650 correctly; fixes #47722.
15652 2003-08-22 Martin Baulig <martin@ximian.com>
15654 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
15655 LocalVariableReference, ensure it's not read-only. Fixes #47536.
15657 * statement.cs (Fixed.DoResolve): Make all variables read-only.
15659 2003-08-22 Martin Baulig <martin@ximian.com>
15661 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
15662 can only be assigned in static constructors. Fixes #47161.
15664 2003-08-22 Martin Baulig <martin@ximian.com>
15666 Rewrote and improved the flow analysis code.
15668 * flowbranching.cs (FlowBranching): Make this class abstract.
15669 (FlowBranching.CreateBranching): New static function to create a
15670 new flow branching.
15671 (FlowBranchingBlock, FlowBranchingException): New classes.
15672 (FlowBranching.UsageVector.Type): New public readonly field.
15673 (FlowBranching.UsageVector.Breaks): Removed the setter.
15674 (FlowBranching.UsageVector.Returns): Removed the setter.
15675 (FlowBranching.UsageVector): Added Break(), Return(),
15676 NeverReachable() and Throw() methods to modify the reachability.
15677 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
15678 done by FlowBranching.Merge().
15679 (FlowBranching.UsageVector.MergeChild): New method; merges the
15680 merge result into the current vector.
15681 (FlowBranching.Merge): New abstract method to merge a branching.
15683 2003-08-12 Martin Baulig <martin@ximian.com>
15685 * expression.cs (Indirection.CacheTemporaries): Create the
15686 LocalTemporary with the pointer type, not its element type.
15688 2003-08-10 Miguel de Icaza <miguel@ximian.com>
15690 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
15691 token was a keyword or not.
15693 Add `error' options where an IDENTIFIER was expected; Provide
15694 CheckToken and CheckIdentifierToken convenience error reporting
15697 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
15699 * decl.cs: Rename `NamespaceEntry Namespace' public field into
15700 NameSpaceEntry NameSpaceEntry.
15702 (LookupInterfaceOrClass): Avoid creating a full qualified name
15703 from namespace and name: avoid doing lookups when we know the
15704 namespace is non-existant. Use new Tree.LookupByNamespace which
15705 looks up DeclSpaces based on their namespace, name pair.
15707 * driver.cs: Provide a new `parser verbose' to display the
15708 exception thrown during parsing. This is turned off by default
15709 now, so the output of a failure from mcs is more graceful.
15711 * namespace.cs: Track all the namespaces defined in a hashtable
15714 (IsNamespace): New method
15716 2003-08-09 Miguel de Icaza <miguel@ximian.com>
15718 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
15719 we know that we need to concatenate (full typename can never be
15724 * statement.cs: Use a bitfield; Do not initialize to null things
15725 which are done by the constructor by default.
15727 * cs-parser.jay: bug fix, parameter was 4, not 3.
15729 * expression.cs: Just use the property;
15731 * statement.cs: No need for GetVariableInfo method.
15733 2003-08-08 Martin Baulig <martin@ximian.com>
15735 * flowanalysis.cs (FlowReturns): This is now nested in the
15736 `FlowBranching' class.
15737 (MyBitVector): Moved this here from statement.cs.
15738 (FlowBranching.SiblingType): New enum type.
15739 (FlowBranching.CreateSibling): Added `SiblingType' argument.
15741 2003-08-07 Martin Baulig <martin@ximian.com>
15743 * flowanalysis.cs (FlowBranchingType): This is now nested in the
15744 `FlowBranching' class and called `BranchingType'.
15746 2003-08-07 Martin Baulig <martin@ximian.com>
15748 * flowanalysis.cs: Moved all the control flow analysis code into
15751 2003-08-07 Martin Baulig <martin@ximian.com>
15753 * assign.cs (Assign.DoResolve): `target' must either be an
15754 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
15757 2003-08-07 Miguel de Icaza <miguel@ximian.com>
15759 * expression.cs (BinaryMethod): This kind of expression is created by the
15760 Binary class if it determines that the operator has to be handled
15763 (BinaryDelegate): This kind of expression is created if we are
15764 dealing with a + or - operator on delegates.
15766 (Binary): remove method, argumetns, and DelegateOperator: when
15767 dealing with methods,
15769 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
15771 * statement.cs (Block): use bitfields for the three extra booleans
15772 we had in use. Remove unused topblock parameter.
15774 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
15776 * assign.cs: Drop extra unneeded tests.
15778 2003-08-06 Miguel de Icaza <miguel@ximian.com>
15780 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
15782 * statement.cs (Foreach): Use VariableStorage instead of
15785 * codegen.cs (VariableStorage): New class used by clients that
15786 require a variable stored: locals or fields for variables that
15787 need to live across yield.
15789 Maybe provide a convenience api for EmitThis+EmitLoad?
15791 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
15794 2003-08-05 Miguel de Icaza <miguel@ximian.com>
15796 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
15797 RemapParameterLValue): New methods that are used to turn a
15798 precomputed FieldInfo into an expression like this:
15802 The idea is to use this instead of making LocalVariableReference
15803 have more than one meaning.
15805 * cs-parser.jay: Add error production to BASE.
15807 * ecore.cs: Deal with TypeManager.GetField returning null, which
15808 is now a valid return value.
15810 (FieldExprNoAddress): New expression for Fields whose address can
15813 * expression.cs (LocalVariableReference): During the resolve
15814 phases, create new expressions if we are in a remapping context.
15815 Remove code that dealt with remapping here.
15817 (ParameterReference): same.
15819 (ProxyInstance): New expression, like the `This' expression, but
15820 it is born fully resolved. We know what we are doing, so remove
15821 the errors that are targeted to user-provided uses of `this'.
15823 * statement.cs (Foreach): our variable is now stored as an
15824 Expression; During resolution, follow the protocol, dont just
15825 assume it will return this.
15827 2003-08-06 Martin Baulig <martin@ximian.com>
15829 * support.cs (SeekableStreamReader.cs): New public class.
15831 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
15832 SeekableStreamReader instead of the normal StreamReader.
15834 2003-08-04 Martin Baulig <martin@ximian.com>
15836 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
15837 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
15838 deambiguate casts and delegate invocations.
15839 (parenthesized_expression): Use the new tokens to ensure this is
15840 not a cast of method invocation.
15842 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
15843 when reading a `)' and Deambiguate_CloseParens () was previously
15846 * expression.cs (ParenthesizedExpression): New class. This is
15847 just used for the CS0075 test.
15848 (Binary.DoResolve): Check for CS0075.
15850 2003-07-29 Ravi Pratap <ravi@ximian.com>
15852 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
15853 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
15854 reference comparison.
15856 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
15857 examine the ReturnType for equality - this is necessary in the
15858 cases of implicit and explicit operators whose signature also
15859 includes the return type.
15861 2003-07-26 Miguel de Icaza <miguel@ximian.com>
15863 * namespace.cs: Cache the result of the namespace computation,
15864 instead of computing it every time.
15866 2003-07-24 Miguel de Icaza <miguel@ximian.com>
15868 * decl.cs: Use a global arraylist that we reuse over invocations
15869 to avoid excesive memory consumption. Reduces memory usage on an
15870 mcs compile by one meg (45 average).
15872 * typemanager.cs (LookupTypeReflection): In .NET pointers are
15873 private, work around that.
15875 2003-07-23 Miguel de Icaza <miguel@ximian.com>
15877 * literal.cs (IntLiteral): Define Zero and One static literals.
15879 * cs-parser.jay (integer_literal): use static literals to reduce
15880 memory usage for the most used literals (0, 1 and -1). 211kb
15881 reduced in memory usage.
15883 Replace all calls to `new ArrayList' with `new
15884 ArrayList(4)' which is a good average number for most allocations,
15885 and also requires only 16 bytes of memory for its buffer by
15888 This reduced MCS memory usage in seven megabytes for the RSS after
15891 2003-07-28 Ravi Pratap <ravi@ximian.com>
15893 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
15894 handle params methods the correct way by forming only one
15895 applicable set with params and normal methods in them. Earlier we
15896 were looking at params methods only if we found no normal methods
15897 which was not the correct thing to do.
15899 (Invocation.BetterFunction): Take separate arguments indicating
15900 when candidate and the best method are params methods in their
15903 This fixes bugs #43367 and #46199.
15905 * attribute.cs: Documentation updates.
15907 (CheckAttribute): Rename to CheckAttributeTarget.
15908 (GetValidPlaces): Rename to GetValidTargets.
15910 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
15911 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
15915 2003-07-28 Martin Baulig <martin@ximian.com>
15917 * class.cs (TypeContainer.DefineMembers): Use the base type's full
15918 name when looking up the base class of a nested class. Fixes #46977.
15920 2003-07-26 Martin Baulig <martin@ximian.com>
15922 * expression.cs (Indexers.Indexer): New nested struct; contains
15923 getter, setter and the indexer's type.
15924 (Indexers.Properties): This is now an ArrayList of
15925 Indexers.Indexer's.
15926 (IndexerAccess.DoResolveLValue): Correctly set the type if the
15927 indexer doesn't have any getters.
15929 * assign.cs (Assign.DoResolve): Also do the implicit conversions
15930 for embedded property and indexer assignments.
15932 2003-07-26 Martin Baulig <martin@ximian.com>
15934 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
15935 preprocessor directive is not the first non-whitespace character
15938 2003-07-26 Martin Baulig <martin@ximian.com>
15940 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
15941 namespace parsing, follow the spec more closely.
15943 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
15944 NamespaceEntry.Lookup().
15946 2003-07-25 Martin Baulig <martin@ximian.com>
15948 * MethodCore.cs (OverridesSomething): New public field; it's set
15949 from TypeContainer.DefineMembers if this method overrides
15950 something (which doesn't need to be a method). Fix #39462.
15952 2003-07-25 Ravi Pratap <ravi@ximian.com>
15954 * typemanager.cs (GetMembers): Ensure that the list of members is
15955 reversed. This keeps things in sync.
15957 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
15958 find an AttributeUsage attribute.
15960 * expression.cs (Invocation.OverloadResolve): Perform the check
15961 which disallows Invoke to be directly called on a Delegate.
15963 (Error_InvokeOnDelegate): Report error cs1533.
15965 2003-07-25 Martin Baulig <martin@ximian.com>
15967 * expression.cs (Indexers.GetIndexersForType): Only look in the
15968 interface hierarchy if the requested type is already an
15969 interface. Fixes #46788 while keeping #46502 fixed.
15971 2003-07-25 Martin Baulig <martin@ximian.com>
15973 * class.cs (TypeContainer.DefineMembers): Check whether all
15974 readonly fields have been assigned and report warning CS0649 if
15977 * statement.cs (LocalInfo.IsFixed): Always return true if this is
15980 2003-07-24 Ravi Pratap <ravi@ximian.com>
15982 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
15983 returned from GetMethods to make things consistent with the
15984 assumptions MCS makes about ordering of methods.
15986 This should comprehensively fix bug #45127 and it does :-)
15988 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
15989 ordering is actually reverse.
15991 * Clean up some debug messages I left lying around.
15993 * interface.cs (Populate*): Get rid of code which emits attributes
15994 since the stage in which we emit attributes is the 'Emit' stage,
15995 not the define stage.
15997 (Emit): Move attribute emission for interface members here.
15999 2003-07-22 Ravi Pratap <ravi@ximian.com>
16001 * expression.cs (Invocation.OverloadResolve): Follow the spec more
16002 closely: we eliminate methods in base types when we have an
16003 applicable method in a top-level type.
16005 Please see section 14.5.5.1 for an exact description of what goes
16008 This fixes bug #45127 and a host of other related to corlib compilation.
16010 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
16011 array is the method corresponding to the top-level type (this is
16012 because of the changes made to icall.c) so we change this
16015 (MethodGroupExpr.Name): This too.
16017 * typemanager.cs (GetElementType): New method which does the right
16018 thing when compiling corlib.
16020 * everywhere: Make use of the above in the relevant places.
16022 2003-07-22 Martin Baulig <martin@ximian.com>
16024 * cs-parser.jay (invocation_expression): Moved
16025 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
16026 `cast_expression', but create a InvocationOrCast which later
16027 resolves to either an Invocation or a Cast.
16029 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
16030 method; call this before EmitStatement() to make sure that this
16031 expression can be used as a statement.
16033 * expression.cs (InvocationOrCast): New class; resolves to either
16034 an Invocation or a Cast.
16036 * statement.cs (StatementExpression): Call ResolveStatement() on
16037 the ExpressionStatement before emitting it.
16039 2003-07-21 Martin Baulig <martin@ximian.com>
16041 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
16042 `ref' and `out' attributes match; fixes #46220.
16043 (MemberAccess.ResolveMemberAccess): You can't reference a type
16044 through an expression; fixes #33180.
16045 (Indexers.GetIndexersForType): Don't return the indexers from
16046 interfaces the class implements; fixes #46502.
16048 2003-07-21 Martin Baulig <martin@ximian.com>
16050 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
16051 CS0661 checks; fixes bug #30442.
16053 2003-07-21 Martin Baulig <martin@ximian.com>
16055 * decl.cs (AdditionResult): Added `Error'.
16057 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
16059 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
16060 makes cs0031.cs actually work.
16062 2003-07-20 Martin Baulig <martin@ximian.com>
16064 * namespace.cs: Fixed that bug which caused a crash when compiling
16065 the debugger's GUI.
16067 2003-07-20 Miguel de Icaza <miguel@ximian.com>
16069 * typemanager.cs (LookupTypeReflection): Never expose types which
16070 are NotPublic, NestedPrivate, NestedAssembly, or
16071 NestedFamANDAssem. We used to return these, and later do a check
16072 that would report a meaningful error, but the problem is that we
16073 would not get the real match, if there was a name override.
16075 2003-07-18 Miguel de Icaza <miguel@ximian.com>
16077 * namespace.cs (Namespace, Name): Do not compute the namespace
16078 name dynamically, compute it in the constructor. This reduced
16079 memory usage by 1697 KB.
16081 * driver.cs: Use --pause to pause at the end.
16083 2003-07-17 Peter Williams <peter@newton.cx>
16085 * Makefile: Change the name of the test target so that it doesn't
16086 conflict with the recursive test target.
16088 2003-07-17 Miguel de Icaza <miguel@ximian.com>
16090 * expression.cs (LocalVariableReference.Emit, EmitAssign,
16091 AddressOf): Do not use EmitThis, that was wrong, use the actual
16094 2003-07-15 Miguel de Icaza <miguel@ximian.com>
16096 * class.cs (MethodData.Define): While checking if a method is an
16097 interface implementation, improve the test: If we are not public
16098 (use new test here: use the computed MethodAttributes directly,
16099 instead of the parsed modifier flags) check if the `implementing'
16100 method comes from an interface or not.
16102 * pending.cs (VerifyPendingMethods): Slightly better error
16105 * makefile: add test target that does the mcs bootstrap.
16107 2003-07-16 Ravi Pratap <ravi@ximian.com>
16109 * interface.cs (Define): Do nothing here since there are no
16110 members to populate etc. Move the attribute emission out of here
16111 since this was just totally the wrong place to put it. Attribute
16112 application happens during the 'Emit' phase, not in the 'Define'
16115 (Emit): Add this method and move the attribute emission here
16117 * rootcontext.cs (EmitCode): Call the Emit method on interface
16120 2003-07-14 Ravi Pratap M <ravi@ximian.com>
16122 * expression.cs (OverloadResolve): Report error only if Location
16123 is not 'Null' which means that there was a probe going on.
16125 2003-07-14 Martin Baulig <martin@ximian.com>
16127 * expression.cs (ConditionalLogicalOperator): New public class to
16128 implement user defined conditional logical operators.
16129 This is section 14.11.2 in the spec and bug #40505.
16131 2003-07-14 Martin Baulig <martin@ximian.com>
16133 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
16135 2003-07-14 Martin Baulig <martin@ximian.com>
16137 * codegen.cs (EmitContext.InFixedInitializer): New public field.
16139 * ecore.cs (IVariable.VerifyFixed): New interface method.
16141 * expression.cs (Unary.ResolveOperator): When resolving the `&'
16142 operator, check whether the variable is actually fixed. Fixes bug
16143 #36055. Set a variable definitely assigned when taking its
16144 address as required by the spec.
16146 * statement.cs (LocalInfo.IsFixed): New field.
16147 (LocalInfo.MakePinned): Set `IsFixed' to true.
16149 2003-07-14 Ravi Pratap M <ravi@ximian.com>
16151 * attribute.cs (Attribute.Resolve): While doing a Member lookup
16152 for .ctors, ensure that we only ask for members declared in the
16153 attribute type (BindingFlags.DeclaredOnly).
16157 * expression.cs (Error_WrongNumArguments): Report error 1501
16158 correctly the way CSC does.
16160 2003-07-13 Martin Baulig <martin@ximian.com>
16162 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
16163 lookup on the fully qualified name, to make things like "X.X" work
16164 where "X.X" is a fully qualified type name, but we also have a
16165 namespace "X" in the using list. Fixes #41975.
16167 2003-07-13 Martin Baulig <martin@ximian.com>
16169 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
16170 function. If we're a CompoundAssign, we need to create an embedded
16171 CompoundAssign, not an embedded Assign.
16172 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
16175 2003-07-13 Martin Baulig <martin@ximian.com>
16177 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
16178 work to fix bug #46088.
16180 2003-07-13 Ravi Pratap <ravi@ximian.com>
16182 * class.cs (Operator.Emit): Do not emit attributes here - it is
16183 taken care of by the Method class that we delegate too. This takes
16184 care of bug #45876.
16186 2003-07-10 Martin Baulig <martin@ximian.com>
16188 * expression.cs (TypeOfVoid): New class.
16189 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
16191 2003-07-10 Martin Baulig <martin@ximian.com>
16193 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
16196 2003-07-10 Martin Baulig <martin@ximian.com>
16198 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
16199 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
16201 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
16203 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
16205 2003-07-10 Martin Baulig <martin@ximian.com>
16207 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
16208 of decimal. Fixes #42850.
16210 NOTE: I also fixed the created byte blob, but this doesn't work on
16211 the MS runtime and csc never produces any byte blobs for decimal
16214 2003-07-10 Martin Baulig <martin@ximian.com>
16216 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
16217 structs; fixes #32068.
16218 (Block.AddChildVariableNames): Fixed #44302.
16220 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16222 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
16224 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16226 * attribute.cs: And this test is onger needed.
16228 2003-07-08 Martin Baulig <martin@ximian.com>
16230 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
16231 inaccessible types. Fixes #36313.
16233 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
16235 * namespace.cs (NamespaceEntry): Create implicit entries for all
16236 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
16237 implicit entries for N1.N2 and N1.
16239 2003-07-08 Martin Baulig <martin@ximian.com>
16241 Rewrote the handling of namespaces to fix a lot of the issues
16242 wrt. `using' aliases etc.
16244 * namespace.cs (Namespace): Splitted this class into a
16245 per-assembly `Namespace' and a per-file `NamespaceEntry'.
16247 * typemanager.cs (TypeManager.IsNamespace): Removed.
16248 (TypeManager.ComputeNamespaces): Only compute namespaces from
16249 loaded assemblies here, not the namespaces from the assembly we're
16250 currently compiling.
16252 2003-07-08 Martin Baulig <martin@ximian.com>
16254 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
16256 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16258 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
16261 I thought about the memory savings here, but LookupTypeReflection
16262 is used under already very constrained scenarios. Compiling
16263 corlib or mcs only exposes one hit, so it would not really reduce
16264 any memory consumption.
16266 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16268 * typemanager.cs: fixes bug #45889 by only adding public types from
16269 other assemblies to the list of known types.
16271 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16273 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
16274 on the type we resolved.
16276 2003-07-05 Martin Baulig <martin@ximian.com>
16278 * pending.cs (PendingImplementation.ParentImplements): Don't
16279 create the proxy if the parent is abstract.
16281 * class.cs (TypeContainer.DefineIndexers): Process explicit
16282 interface implementations first. Fixes #37714.
16284 2003-07-04 Miguel de Icaza <miguel@ximian.com>
16286 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
16287 defined recursively; but since we modify the input parameters
16288 (left is set to `this' temporarily), we reset this value if the
16289 left_is_explicit is false, which gives the original semantics to
16292 * literal.cs (NullPointer): new class used to represent a null
16293 literal in a pointer context.
16295 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
16296 type is a pointer, use a NullPointer object instead of a
16297 NullLiteral. Closes 43687
16299 (ExplicitConversion): Convert pointer values using
16300 the conv opcode to the proper type.
16302 * ecore.cs (New): change ValueTypeVariable property into a method,
16303 that returns whether the valuetype is suitable for being used.
16305 * expression.cs (Binary.DoNumericPromotions): Only return if we
16306 the int constant was a valid uint, and we can return both left and
16307 right as uints. If not, we continue processing, to trigger the
16308 type conversion. This fixes 39018.
16310 * statement.cs (Block.EmitMeta): During constant resolution, set
16311 the CurrentBlock property on the emitcontext, so that we resolve
16312 constants propertly.
16314 2003-07-02 Martin Baulig <martin@ximian.com>
16316 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
16317 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
16319 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
16320 than emitting it here.
16322 * statement.cs: Fixed some more flow analysis bugs.
16324 2003-07-02 Martin Baulig <martin@ximian.com>
16326 * class.cs (MethodData.Define): When implementing interface
16327 methods, set Final unless we're Virtual.
16329 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
16330 check work for interface methods.
16332 2003-07-01 Martin Baulig <martin@ximian.com>
16334 * ecore.cs (EmitContext.This): Replaced this property with a
16335 GetThis() method which takes a Location argument. This ensures
16336 that we get the correct error location for a CS0188.
16338 2003-07-01 Miguel de Icaza <miguel@ximian.com>
16340 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
16341 ImplicitStandardConversion.
16343 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
16345 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
16347 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
16350 2003-06-30 Miguel de Icaza <miguel@ximian.com>
16352 * class.cs (Constructor.Define): Turn off initlocals for unsafe
16355 (MethodData.Define): Turn off initlocals for unsafe methods.
16357 2003-06-29 Miguel de Icaza <miguel@ximian.com>
16359 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
16360 complete; Fixes #37521.
16362 * delegate.cs: Use Modifiers.TypeAttr to compute the
16363 TypeAttributes, instead of rolling our own. This makes the flags
16364 correct for the delegates.
16366 2003-06-28 Miguel de Icaza <miguel@ximian.com>
16368 * class.cs (Constructor.Define): Set the private flag for static
16369 constructors as well.
16371 * cs-parser.jay (statement_expression): Set the return value to
16372 null, to avoid a crash when we catch an error.
16374 2003-06-24 Miguel de Icaza <miguel@ximian.com>
16376 * cs-parser.jay: Applied patch from Jackson that adds support for
16377 extern and unsafe modifiers to destructor declarations.
16379 * expression.cs: Report error 21 if the user is trying to index a
16382 * driver.cs: Add an error message, suggested by the bug report.
16384 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
16385 if we do not have a ": this ()" constructor initializer. Fixes 45149
16387 2003-06-14 Miguel de Icaza <miguel@ximian.com>
16389 * namespace.cs: Add some information to reduce FAQs.
16391 2003-06-13 Miguel de Icaza <miguel@ximian.com>
16393 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
16394 underlying enumeration types. Fixes #43915.
16396 * expression.cs: Treat ushort/short as legal values to be used in
16397 bitwise operations.
16399 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
16401 * delegate.cs: transfer custom attributes for paramenters from
16402 the delegate declaration to Invoke and BeginInvoke.
16404 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
16406 * attribute.cs: handle custom marshalers and emit marshal info
16409 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
16411 * makefile.gnu: Added anonymous.cs to the compiler sources.
16413 2003-05-28 Miguel de Icaza <miguel@ximian.com>
16415 * iterators.cs: Change the name of the proxy class to include two
16418 * cs-parser.jay: Update grammar to include anonymous methods.
16420 * anonymous.cs: new file.
16422 2003-05-27 Miguel de Icaza <miguel@ximian.com>
16424 * class.cs (Field.Define): Add missing test for pointers and
16427 2003-05-27 Ravi Pratap <ravi@ximian.com>
16429 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
16430 we use the stobj opcode.
16432 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
16433 since it wasn't the correct fix.
16435 It still is puzzling that we are required to use stobj for IntPtr
16436 which seems to be a ValueType.
16438 2003-05-26 Miguel de Icaza <miguel@ximian.com>
16440 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
16441 during regular simple name resolution. Now, the trick is that
16442 instead of returning for processing the simplename, we do a
16443 TypeManager.LookupType (ie, a rooted lookup as opposed to a
16444 contextual lookup type). If a match is found, return that, if
16445 not, return for further composition.
16447 This fixes long-standing 30485.
16449 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16450 using the address to initialize an object, do an Stobj instead of
16451 using the regular Stelem.
16453 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
16454 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
16455 Because if we are a BaseIndexerAccess that value will be true.
16458 * statement.cs (GotoCase.Resolve): Return after reporting an
16459 error, do not attempt to continue.
16461 * expression.cs (PointerArithmetic.Emit): If our operand is a
16462 long, convert our constants to match the operand before
16463 multiplying. Convert to I type before adding. Fixes 43670.
16465 2003-05-14 Ravi Pratap <ravi@ximian.com>
16467 * enum.cs (ImplicitConversionExists) : Rename to
16468 ImplicitEnumConversionExists to remove ambiguity.
16470 * ecore.cs (NullCast): New type of cast expression class which
16471 basically is very similar to EmptyCast with the difference being
16472 it still is a constant since it is used only to cast a null to
16474 (eg. (string) null)
16476 * convert.cs (ImplicitReferenceConversion): When casting a null
16477 literal, we return a NullCast.
16479 * literal.cs (NullLiteralTyped): Remove - I don't see why this
16480 should be around anymore.
16482 The renaming (reported was slightly wrong). Corrections:
16484 ConvertImplicitStandard -> ImplicitConversionStandard
16485 ConvertExplicitStandard -> ExplicitConversionStandard
16487 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
16488 before passing them in !
16490 * convert.cs (ImplicitConversionStandard): When comparing for
16491 equal expr and target types, ensure that expr is not a
16494 In general, we must not be checking (expr_type ==
16495 target_type) in the top level conversion methods
16496 (ImplicitConversion, ExplicitConversion etc). This checking is
16497 done in the methods that they delegate to.
16499 2003-05-20 Miguel de Icaza <miguel@ximian.com>
16501 * convert.cs: Move Error_CannotConvertType,
16502 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
16503 ImplicitNumericConversion, ImplicitConversionExists,
16504 ImplicitUserConversionExists, StandardConversionExists,
16505 FindMostEncompassedType, FindMostSpecificSource,
16506 FindMostSpecificTarget, ImplicitUserConversion,
16507 ExplicitUserConversion, GetConversionOperators,
16508 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
16509 TryImplicitIntConversion, Error_CannotConvertImplicit,
16510 ConvertImplicitRequired, ConvertNumericExplicit,
16511 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
16512 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
16515 Perform the following renames:
16517 StandardConversionExists -> ImplicitStandardConversionExists
16518 ConvertImplicit -> ImplicitConversion
16519 ConvertImplicitStandard -> ImplicitStandardConversion
16520 TryImplicitIntConversion -> ImplicitIntConversion
16521 ConvertImplicitRequired -> ImplicitConversionRequired
16522 ConvertNumericExplicit -> ExplicitNumericConversion
16523 ConvertReferenceExplicit -> ExplicitReferenceConversion
16524 ConvertExplicit -> ExplicitConversion
16525 ConvertExplicitStandard -> ExplicitStandardConversion
16527 2003-05-19 Martin Baulig <martin@ximian.com>
16529 * statement.cs (TypeInfo.StructInfo): Made this type protected.
16530 (TypeInfo): Added support for structs having structs as fields.
16532 * ecore.cs (FieldExpr): Implement IVariable.
16533 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
16534 VariableInfo for the field.
16536 2003-05-18 Martin Baulig <martin@ximian.com>
16538 * expression.cs (This.DoResolve): Report a CS0027 if we're
16539 emitting a field initializer.
16541 2003-05-18 Martin Baulig <martin@ximian.com>
16543 * expression.cs (This.ResolveBase): New public function.
16544 (This.DoResolve): Check for CS0188.
16546 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
16549 * ecore.cs (MethodGroupExpr.DoResolve): Set the
16550 `instance_expression' to null if we don't have any non-static
16553 2003-05-18 Martin Baulig <martin@ximian.com>
16555 Reworked the way how local variables and parameters are handled by
16556 the flow analysis code.
16558 * statement.cs (TypeInfo, VariableMap): New public classes.
16559 (VariableInfo): New public class. This is now responsible for
16560 checking whether a variable has been assigned. It is used for
16561 parameters and local variables.
16562 (Block.EmitMeta): Take the InternalParameters as argument; compute
16563 the layout of the flow vectors here.
16564 (Block.LocalMap, Block.ParameterMap): New public properties.
16565 (FlowBranching): The .ctor doesn't get the InternalParameters
16566 anymore since Block.EmitMeta() now computes the layout of the flow
16568 (MyStructInfo): This class is now known as `StructInfo' and nested
16569 in `TypeInfo'; we don't access this directly anymore.
16571 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
16572 property and removed IsAssigned(), IsFieldAssigned(),
16573 SetAssigned() and SetFieldAssigned(); we now call them on the
16574 VariableInfo so we don't need to duplicate this code everywhere.
16576 * expression.cs (ParameterReference): Added `Block block' argument
16578 (LocalVariableReference, ParameterReference, This): The new
16579 VariableInfo class is now responsible for all the definite
16582 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
16583 IsParameterAssigned, SetParameterAssigned): Removed.
16585 2003-05-18 Martin Baulig <martin@ximian.com>
16587 * typemanager.cs (InitCoreTypes): Try calling
16588 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
16589 the 3-args-version. Corlib now also needs our `void_type'.
16590 (GetMethod): Added overloaded version which takes an optional
16591 `bool report_errors' to allow lookups of optional methods.
16593 2003-05-12 Martin Baulig <martin@ximian.com>
16595 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
16596 only used for locals and not for parameters.
16598 2003-05-12 Miguel de Icaza <miguel@ximian.com>
16600 * support.cs (InternalParameters.ParameterType): Return the
16601 ExternalType of the parameter.
16603 * parameter.cs (Parameter.ExternalType): drop the two arguments,
16606 2003-05-11 Miguel de Icaza <miguel@ximian.com>
16608 * class.cs (MethodData.Define): Do not set the `newslot' on
16609 interface members, if they are also flagged as "override".
16611 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
16612 better code for ++i and i++. This only works for static fields
16613 and local variables.
16615 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
16616 want to pull the DeclSpace out of the builder_to_declspace instead
16617 of the TypeBuilder (like in TypeContainer.FindMembers).
16619 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
16620 instead of LookupTypeContainer. Fixes the crash on .NET for
16621 looking up interface members.
16623 * const.cs: Create our own emit context during the Definition
16624 stage, so that constants are evaluated in the proper context, when
16625 a recursive definition happens.
16627 2003-05-11 Martin Baulig <martin@ximian.com>
16629 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
16630 new block for a switch section.
16631 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
16632 the adding/lookup in the switch block. Fixes #39828.
16634 2003-05-09 Miguel de Icaza <miguel@ximian.com>
16636 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
16637 functionality: I needed to convert the data after I had performed
16638 the add/sub operation into the operands type size.
16640 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
16641 pass the type for the box operation, otherwise the resulting
16642 object would have been of type object.
16644 (BoxedCast): Add constructor to specify the type to box as.
16646 2003-05-07 Miguel de Icaza <miguel@ximian.com>
16648 * iterators.cs: I was reusing the `count' variable inadvertently,
16649 take steps to not allow this to happen.
16651 2003-05-06 Miguel de Icaza <miguel@ximian.com>
16653 * attribute.cs (Attribute.Resolve): Params attributes are encoded
16654 by creating an array at the point where the params starts and
16655 putting all those arguments there, then adjusting the size of the
16658 2003-05-05 Miguel de Icaza <miguel@ximian.com>
16660 * expression.cs (New.AddressOf): Implement interface
16661 IMemoryLocation. This is used when the `new' operator is used in
16662 the context of an invocation to a method on a value type.
16664 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
16667 * namespace.cs: Also check the using aliases here.
16669 * driver.cs: Move the test for using validity after the types have
16670 been entered, so we do a single pass that also includes the using
16673 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
16674 in the regular case. CreateSiblingForFinally is doing extra
16677 * attribute.cs (GetAttributeArgumentExpression): Store the result
16678 on an out value, and use the return value to indicate failure
16679 instead of using null (which is a valid return for Constant.GetValue).
16681 * statement.cs: Perform the analysis flow for the increment
16682 portion after the statement, because this will be the real flow of
16683 execution. Fixes #42385
16685 * codegen.cs (EmitContext.EmitArgument,
16686 EmitContext.EmitStoreArgument): New helper functions when the
16687 RemapToProxy flag is set.
16689 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
16692 Add support for remapping parameters.
16694 * iterators.cs: Propagate parameter values; Store parameter
16695 values in the proxy classes.
16697 2003-05-04 Miguel de Icaza <miguel@ximian.com>
16699 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
16700 need a proxy reference; I do not know what I was thinking
16702 * cs-parser.jay (constructor_initializer): catch another error,
16703 and display nice message.
16705 (field_declaration): catch void field declaration
16706 to flag a better error.
16708 * class.cs (MemberBase.CheckBase): Report an error instead of a
16709 warning if a new protected member is declared in a struct.
16710 (Field.Define): catch the error of readonly/volatile.
16712 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
16714 (FieldExpr.AddressOf): ditto. Catch error where the address of a
16715 volatile variable is taken
16717 2003-05-02 Miguel de Icaza <miguel@ximian.com>
16719 * statement.cs (Fixed.Resolve): Report an error if we are not in
16722 2003-05-01 Miguel de Icaza <miguel@ximian.com>
16724 * typemanager.cs: reuse the code that handles type clashes for
16725 delegates and enumerations.
16727 * class.cs (Report28): Always report.
16729 * expression.cs (EncodeAsAttribute): Allow nulls here.
16731 2003-04-28 Miguel de Icaza <miguel@ximian.com>
16733 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
16734 the functionality for testing whether an expression is valid for
16735 an attribute here. Also handle the case of arrays of elements
16738 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
16739 encoding a linear array into an array of objects that are suitable
16740 to be passed to an CustomAttributeBuilder.
16742 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
16744 * ecore.cs: (FieldExpr): Handle field remapping here.
16746 * iteratators.cs: Pass the instance variable (if the method is an
16747 instance method) to the constructors, so we can access the field
16748 variables on the class.
16750 TODO: Test this with structs. I think the THIS variable on
16751 structs might have to be a pointer, and not a refenrece
16753 2003-04-27 Miguel de Icaza <miguel@ximian.com>
16755 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
16756 local variables to fields in a proxy class.
16758 * iterators.cs (PopulateProxy): Rename our internal fields to
16760 Create a <THIS> field if we are an instance method, so we can
16761 reference our parent container variables.
16762 (MapVariable): Called back from the EmitContext code to enter a
16763 new variable to field mapping into the proxy class (we just create
16767 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
16768 for using the remapped locals to fields.
16770 I placed the code here, because that gives the same semantics to
16771 local variables, and only changes the Emit code.
16773 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
16774 statements inside iterators.
16775 (VariableInfo): Add a FieldBuilder for the cases when we are
16776 remapping local variables to fields in a proxy class
16778 * ecore.cs (SimpleNameResolve): Avoid testing two times for
16779 current_block != null.
16781 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
16782 not cope with strings, as it has been moved to the
16783 TableSwitchEmit. Fixed bug in switch generation.
16785 * expression.cs (New.DoResolve): Provide more context for the user
16786 when reporting an error.
16788 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
16791 * expression.cs (MemberAccess.DoResolve): When we get a type back,
16792 check the permissions for it. Note than in a type-resolution
16793 context the check was already present in DeclSpace.ResolveType,
16794 but was missing from the MemberAccess.
16796 (ArrayCreation.CheckIndices): warn if the user has
16797 more nested levels of expressions, but there are no more
16798 dimensions specified. Avoids crash on bug 41906.
16800 2003-04-26 Miguel de Icaza <miguel@ximian.com>
16802 * statement.cs (Block): replace Implicit bool, for a generic
16804 New flag: `Unchecked'. This is used during the EmitMeta phase
16805 (which is out-of-line with the regular Resolve/Emit process for a
16806 statement, as this is done ahead of time, but still gets a chance
16807 to call constant resolve).
16809 (Block.Flags): new enum for adding a new flag.
16811 (Block.EmitMeta): track the state of unchecked.
16813 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
16814 to enable constant resolution to work there as well.
16816 2003-04-22 Miguel de Icaza <miguel@ximian.com>
16818 * typemanager.cs (ienumerable_type): Also look up
16819 System.Collections.IEnumerable.
16821 2003-04-21 Miguel de Icaza <miguel@ximian.com>
16823 TODO: Test more than one conditional per method.
16825 * class.cs (Indexer.Define): Report the location where the user is
16826 referencing the unsupported feature.
16828 (MethodData): Overload the use of `conditionals' to
16829 minimize the creation of needless ArrayLists. This saves roughly
16830 212kb on my machine.
16832 (Method): Implement the new IIteratorContainer interface.
16833 (Method.SetYields): Implement the method by setting the ModFlags
16834 to contain METHOD_YIELDS.
16836 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
16837 which just got set to null.
16839 * iterators.cs: New file.
16841 (Yield, YieldBreak): New statements.
16843 * statement.cs (Return.Resolve): Flag an error if we are used in
16844 an iterator method.
16846 * codegen.cs (InIterator): New flag set if the code is being
16847 compiled in an iterator method.
16849 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
16850 internal modifier, and we just use it to avoid adding extra
16851 fields, as this is seldom used.
16853 * cs-parser.jay: Add yield_statement (yield and yield break).
16855 * driver.cs: New flag -v2 to turn on version 2 features.
16857 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
16858 hashtable when v2 is enabled.
16860 2003-04-20 Miguel de Icaza <miguel@ximian.com>
16862 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
16863 there is already a namespace defined with this name.
16865 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
16866 people upgraded their corlibs.
16868 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
16869 always use fully qualified types, no need to use the compiler
16872 (TypeManager.IsNamespace): Use binarysearch.
16874 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
16875 AddDelegate): I did not quite use the new IsValid API properly: I
16876 have to pass the short-name and the fullname. I was passing only
16877 the basename instead of the fullname sometimes.
16879 (TypeContainer.DefineType): call NamespaceClash.
16881 * interface.cs (Interface.DefineType): use NamespaceClash before
16884 * delegate.cs (Delegate.DefineType): use NamespaceClash before
16887 * enum.cs: (Enum.DefineType): use NamespaceClash before
16890 * typemanager.cs (: 3-line patch that gives us some tasty 11%
16891 speed increase. First, use the negative_hits cache when we get a
16892 negative. Second, add the type with its full original name
16893 instead of the new . and + encoded name (reflection uses + to
16894 separate type from a nested type). Use LookupTypeReflection
16895 directly which bypasses the type->name hashtable (that we already
16896 know does not contain the type.
16898 * decl.cs (DeclSpace.ResolveTypeExpr): track the
16899 location/container type.
16901 * driver.cs: When passing utf8, use directly the UTF8Encoding.
16903 2003-04-19 Miguel de Icaza <miguel@ximian.com>
16905 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
16907 * delegate.cs (NewDelegate.Resolve): Test whether an instance
16908 method is being referenced in the method group from a static
16909 context, and report error 120 if so.
16911 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
16914 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
16915 is created, we create the A namespace).
16917 * cs-parser.jay: A namespace also introduces a DeclarationFound.
16920 2003-04-18 Miguel de Icaza <miguel@ximian.com>
16922 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
16923 invocation to ModuleBuilder.GetType with the same values will
16924 return a new type instance, so we need to cache its return
16927 * expression.cs (Binary.ResolveOperator): Only allow the compare
16928 operators on enums if they are of the same type.
16930 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
16931 types of ValueType on their own case. Before we were giving them
16932 the same treatment as objects.
16934 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
16935 fullname. Short name is used to compare against container name.
16936 Fullname is used to check against defined namespace names.
16938 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
16939 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
16941 (Method.CheckBase): Call parent.
16942 (MemberBase.CheckBase): Check for protected members on sealed
16944 (PropertyBase.CheckBase): Call parent.
16945 (Field.Define): Call parent.
16947 * report.cs: Negative error codes are now mapped to 8000 - code,
16948 so that the display is render more nicely.
16950 * typemanager.cs: Do not use try/catch, instead report a regular
16953 (GetPointerType, GetReferenceType): These methods provide
16954 mechanisms to obtain the T* and T& from a T. We had the code
16955 previously scattered around the code base, and it also used
16956 TypeManager.LookupType that would go through plenty of caches.
16957 This one goes directly to the type source.
16959 In some places we did the Type.GetType followed by
16960 ModuleBuilder.GetType, but not in others, so this unifies the
16961 processing as well.
16963 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
16964 statements now that we have namespace information.
16966 * typemanager.cs (IsNamespace): New method, returns whether the
16967 string presented is a namespace or not.
16969 (ComputeNamespaces): New public entry point, computes the list of
16970 available namespaces, using the GetNamespaces API call in Mono, or
16971 the slower version in MS.NET.
16973 Now before we start the semantic analysis phase, we have a
16974 complete list of namespaces including everything that the user has
16977 Deleted old code to cache namespaces in .nsc files.
16979 2003-04-17 Miguel de Icaza <miguel@ximian.com>
16981 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
16982 class/struct location definition Location for the implicit
16983 constructor location.
16985 (Operator.Define): Use the location of the operator for the
16986 implicit Method definition.
16988 (Constructor.Emit): use the constructor location for the implicit
16989 base initializer constructor.
16991 * ecore.cs: Remove ITypeExpression. This interface is now gone,
16992 and the Expression class now contains two new methods:
16994 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
16995 isolate type lookup from the rest of the resolution process.
16997 Since we use Expressions to hold type definitions due to the way
16998 we parse the input we have historically overloaded Resolve to
16999 perform the Type lookups if a special flag is passed. Now this is
17000 eliminated and two methods take their place.
17002 The differences in the two methods between xStep and xTerminal is
17003 that xStep is involved in our current lookup system that uses
17004 SimpleNames to compose a name, while xTerminal is used just to
17005 catch the case where the simplename lookup failed.
17007 2003-04-16 Miguel de Icaza <miguel@ximian.com>
17009 * expression.cs (ResolveMemberAccess): Remove redundant code.
17010 TypeExpr expressions are always born fully resolved.
17012 * interface.cs (PopulateMethod): Do not lookup the types twice.
17013 We were doing it once during SemanticAnalysis and once during
17016 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
17017 in local variable type definitions, were being returned as a
17018 SimpleName (we decomposed everything into a string), that is
17019 because primary_expression was being used instead of a type in the
17020 grammar (reduce/reduce conflicts).
17022 The part that was wrong is that we converted the expression into a
17023 string (an oversimplification in one hand, compounded with primary
17024 expressions doing string concatenation).
17030 Would return "A.B.C[]" as a SimpleName. This stopped things like
17031 using clauses from working on this particular context. And a type
17032 was being matched directly against "A.B.C[]".
17034 We now use the correct approach, and allow for ComposedCast to be
17035 part of the unary expression. So the "A.B.C []" become a composed
17036 cast of "A.B.C" (as a nested group of MemberAccess with a
17037 SimpleName at the end) plus the rank composition "[]".
17041 2003-04-10 Miguel de Icaza <miguel@ximian.com>
17043 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
17044 for the access level checking.
17046 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
17047 `TypeContainer container', because I kept getting confused when I
17048 was debugging this code.
17050 * expression.cs (Indexers): Instead of tracking getters/setters,
17051 we now track them in parallel. We create one arraylist less, but
17052 most importantly it is possible now for the LValue code to find a
17053 matching get for a set.
17055 (IndexerAccess.DoResolveLValue): Update the code.
17056 GetIndexersForType has been modified already to extract all the
17057 indexers from a type. The code assumed it did not.
17059 Also make the code set the correct return type for the indexer.
17060 This was fixed a long time ago for properties, but was missing for
17061 indexers. It used to be void_type.
17063 (Binary.Emit): Test first for doubles instead of
17064 floats, as they are more common.
17066 (Binary.EmitBranchable): Use the .un version of the branch opcodes
17067 when dealing with floats and the <=, >= operators. This fixes bug
17070 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
17071 to load the array value by emitting a load on the foreach variable
17072 type. This was incorrect.
17074 We now emit the code to load an element using the the array
17075 variable type, and then we emit the conversion operator.
17079 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
17081 * attribute.cs: Avoid allocation of ArrayLists in the common case.
17083 2003-04-09 Miguel de Icaza <miguel@ximian.com>
17085 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
17086 test for protection before we test for signatures.
17088 (MethodSignature.ToString): implement.
17090 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
17091 to the case where we reduced into a LongConstant.
17093 * decl.cs (CheckAccessLevel): If the type is an array, we can not
17094 depend on whether the information is acurrate, because the
17095 Microsoft runtime will always claim that the array type is public,
17096 regardless of the real state.
17098 If the type is a pointer, another problem happens: the type is
17099 reported as non-public in Microsoft.
17101 In both cases we have to call CheckAccessLevel recursively with
17102 the underlying type as the argument to be tested.
17104 2003-04-08 Miguel de Icaza <miguel@ximian.com>
17106 * assign.cs (Assign.Emit): If we are dealing with a compound
17107 assignment expression, we should use the code path that stores the
17108 intermediate result in a temporary value. This fixes #40903.
17110 *expression.cs (Indirection.ToString): Provide ToString method for
17113 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
17115 * class.cs: Null out fields holding references to Block objects so
17116 they can be garbage collected.
17118 * expression.cs (OverloadResolve): Remove unused local.
17120 2003-04-07 Martin Baulig <martin@ximian.com>
17122 * codegen.cs (EmitContext.CurrentFile): New public field.
17123 (EmitContext.Mark): Use the CurrentFile to check whether the
17124 location is in the correct file.
17125 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
17127 2003-04-07 Martin Baulig <martin@ximian.com>
17129 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
17131 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
17132 location. [FIXME: The location argument which gets passed to this
17133 method is sometimes wrong!]
17135 2003-04-07 Nick Drochak <ndrochak@gol.com>
17137 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
17139 2003-04-07 Miguel de Icaza <miguel@ximian.com>
17141 * expression.cs (Indirection.EmitAssign): We were using the
17142 temporary, but returning immediately instead of continuing the
17145 2003-04-06 Martin Baulig <martin@ximian.com>
17147 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
17148 if it's a nested child, but also deriving from the outer class.
17151 * typemanager.cs (IsNestedChildOf): Make this work if it's a
17152 nested child, but also deriving from the outer class. See
17154 (FilterWithClosure): We may access private members of the outer
17155 class if we're a nested child and deriving from the outer class.
17156 (RealMemberLookup): Only set `closure_private_ok' if the
17157 `original_bf' contained BindingFlags.NonPublic.
17159 2003-04-05 Martin Baulig <martin@ximian.com>
17161 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
17163 2003-04-02 Miguel de Icaza <miguel@ximian.com>
17165 * class.cs (Event.Define): Do not allow abstract events to have
17168 2003-04-01 Miguel de Icaza <miguel@ximian.com>
17170 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
17171 block in event declarations.
17173 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
17174 value type, get its address.
17176 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
17177 leaving a class on the stack instead of a boolean value (int
17178 0/1). Change the code so we compare against null, and then the
17179 result against zero.
17181 * class.cs (TypeContainer.GetClassBases): We were checking for the
17182 parent class being sealed too late.
17184 * expression.cs (Binary.Emit): For <= and >= when dealing with
17185 floating point values, use cgt.un and clt.un instead of cgt and
17188 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
17190 * statement.cs: Apply the same optimization as MS: skip the
17191 GetEnumerator returning an IEnumerator, and use the one returning a
17192 CharEnumerator instead. This allows us to avoid the try-finally block
17195 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
17197 * cs-parser.jay: Attributes cannot be applied to
17198 namespaces. Fixes #40473
17200 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17203 (Add*): check if the name is valid using the full name for constants,
17204 fields, properties and events.
17206 2003-03-28 Miguel de Icaza <miguel@ximian.com>
17208 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
17209 char constants to be part of the enumeration.
17211 * expression.cs (Conditional.DoResolve): Add support for operator
17212 true. Implements the missing functionality from 14.12
17214 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
17215 operator true/false as required by the spec.
17217 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
17218 implicit conversion to boolean.
17220 * statement.cs (Statement.ResolveBoolean): A boolean expression is
17221 also one where the type implements `operator true'.
17223 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
17224 get an expression that will invoke operator true based on an
17227 (GetConversionOperators): Removed the hack that called op_True
17230 (Expression.ResolveBoolean): Move this from Statement.
17232 2003-03-17 Miguel de Icaza <miguel@ximian.com>
17234 * ecore.cs (FieldExpr): do not allow initialization of initonly
17235 fields on derived classes
17237 2003-03-13 Martin Baulig <martin@ximian.com>
17239 * statement.cs (Block.Emit): Call ig.BeginScope() and
17240 ig.EndScope() when compiling with debugging info; call
17241 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
17243 2003-03-08 Miguel de Icaza <miguel@ximian.com>
17245 * expression.cs (Indexers): Do not construct immediately, allow
17246 for new members to be appended as we go. Fixes 38143
17248 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17250 * expression.cs: save/restore context when resolving an unchecked
17253 2003-03-05 Miguel de Icaza <miguel@ximian.com>
17255 * cfold.cs: Catch division by zero in modulus operator during
17258 2003-03-03 Miguel de Icaza <miguel@ximian.com>
17260 * interface.cs (Interface.DefineMembers): Avoid defining members
17263 2003-02-27 Miguel de Icaza <miguel@ximian.com>
17265 * driver.cs: handle the +/- options for -noconfig
17267 * statement.cs (Unckeched.Resolve): Also track the state of
17268 unchecked in the Resolve phase.
17270 2003-02-27 Martin Baulig <martin@ximian.com>
17272 * ecore.cs (Expression.MemberLookup): Don't create a
17273 MethodGroupExpr for something which is not a method. Fixes #38291.
17275 2003-02-25 Miguel de Icaza <miguel@ximian.com>
17277 * class.cs (MemberBase.CheckParameters): Also check that the type
17278 is unmanaged if it is a pointer.
17280 * expression.cs (SizeOf.Resolve): Add location information.
17282 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
17283 a managed type is declared.
17285 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
17286 parameter modifiers as well. Fixes bug 38606
17288 * class.cs: Very sad. Am backing out the speed up changes
17289 introduced by the ArrayList -> Array in the TypeContainer, as they
17290 were not actually that much faster, and introduced a bug (no error
17291 reports on duplicated methods).
17293 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
17294 source first, this will guarantee that we have a valid expression
17295 before calling in lower levels functions that will require a
17296 resolved object. Then use this original_source in the
17297 target.ResolveLValue instead of the original source that was
17300 Another change. Use target.Resolve instead of LValueResolve.
17301 Although we are resolving for LValues, we will let the Assign code
17302 take care of that (it will be called again from Resolve). This
17303 basically allows code like this:
17305 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
17306 class Y { void A (X x) { x [0] += o; }
17308 The problem was that the indexer was trying to resolve for
17309 set_Item (idx, object o) and never finding one. The real set_Item
17310 was set_Item (idx, X). By delaying the process we get the right
17315 2003-02-23 Martin Baulig <martin@ximian.com>
17317 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
17318 while calling DoEmit ().
17320 * codegen.cs (EmitContext.Mark): Don't mark locations in other
17321 source files; if you use the #line directive inside a method, the
17322 compiler stops emitting line numbers for the debugger until it
17323 reaches the end of the method or another #line directive which
17324 restores the original file.
17326 2003-02-23 Martin Baulig <martin@ximian.com>
17328 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
17330 2003-02-23 Martin Baulig <martin@ximian.com>
17332 * statement.cs (Block.AddChildVariableNames): We need to call this
17333 recursively, not just for our immediate children.
17335 2003-02-23 Martin Baulig <martin@ximian.com>
17337 * class.cs (Event.Define): Always make the field private, like csc does.
17339 * typemanager.cs (TypeManager.RealMemberLookup): Make events
17340 actually work, fixes bug #37521.
17342 2003-02-23 Miguel de Icaza <miguel@ximian.com>
17344 * delegate.cs: When creating the various temporary "Parameters"
17345 classes, make sure that we call the ComputeAndDefineParameterTypes
17346 on those new parameters (just like we do with the formal ones), to
17347 allow them to be resolved in the context of the DeclSpace.
17349 This fixes the bug that Dick observed in Bugzilla #38530.
17351 2003-02-22 Miguel de Icaza <miguel@ximian.com>
17353 * expression.cs (ResolveMemberAccess): When resolving a constant,
17354 do not attempt to pull a constant if the value was not able to
17355 generate a valid constant.
17357 * const.cs (LookupConstantValue): Do not report more errors than required.
17359 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17361 * expression.cs: fixes bug #38328.
17363 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17365 * class.cs: Changed all the various members that can be part of a
17366 class from being an ArrayList to be an Array of the right type.
17367 During the DefineType type_list, interface_list, delegate_list and
17368 enum_list are turned into types, interfaces, delegates and enums
17371 And during the member population, indexer_list, event_list,
17372 constant_list, field_list, instance_constructor_list, method_list,
17373 operator_list and property_list are turned into their real arrays.
17375 Although we could probably perform this operation earlier, for
17376 good error reporting we need to keep the lists and remove the
17377 lists for longer than required.
17379 This optimization was triggered by Paolo profiling the compiler
17380 speed on the output of `gen-sample-program.pl' perl script.
17382 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
17383 not crash in methods like MemberLookupFailed that use this field.
17385 This problem arises when the compiler fails to resolve a type
17386 during interface type definition for example.
17388 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17390 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
17391 inherit from System.Object, so we have to stop at null, not only
17392 when reaching System.Object.
17394 2003-02-17 Miguel de Icaza <miguel@ximian.com>
17396 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
17397 DeclaredOnly because the parent indexer might have had a different
17398 name, but did not loop until the top of the hierarchy was reached.
17400 The problem this one fixes is 35492: when a class implemented an
17401 indexer from an interface, we were getting the interface method
17402 (which was abstract) and we were flagging an error (can not invoke
17405 This also keeps bug 33089 functioning, and test-148 functioning.
17407 * typemanager.cs (IsSpecialMethod): The correct way of figuring
17408 out if a method is special is to see if it is declared in a
17409 property or event, or whether it is one of the predefined operator
17410 names. This should fix correctly #36804.
17412 2003-02-15 Miguel de Icaza <miguel@ximian.com>
17414 The goal here is to remove the dependency on EmptyCast.Peel ().
17415 Killing it completely.
17417 The problem is that currently in a number of places where
17418 constants are expected, we have to "probe" for an EmptyCast, and
17419 Peel, which is not the correct thing to do, as this will be
17420 repetitive and will likely lead to errors.
17422 The idea is to remove any EmptyCasts that are used in casts that
17423 can be reduced to constants, so we only have to cope with
17426 This bug hunt was triggered by Bug 37363 and the desire to remove
17427 the duplicate pattern where we were "peeling" emptycasts to check
17428 whether they were constants. Now constants will always be
17431 * ecore.cs: Use an enumconstant here instead of wrapping with
17434 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
17435 throwing me off. By handling this we can get rid of a few hacks.
17437 * statement.cs (Switch): Removed Peel() code.
17439 2003-02-14 Miguel de Icaza <miguel@ximian.com>
17441 * class.cs: Location information for error 508
17443 * expression.cs (New.DoResolve): Add a guard against double
17444 resolution of an expression.
17446 The New DoResolve might be called twice when initializing field
17447 expressions (see EmitFieldInitializers, the call to
17448 GetInitializerExpression will perform a resolve on the expression,
17449 and later the assign will trigger another resolution
17451 This leads to bugs (#37014)
17453 * delegate.cs: The signature for EndInvoke should contain any ref
17454 or out parameters as well. We were not doing this in the past.
17456 * class.cs (Field.Define): Do not overwrite the type definition
17457 inside the `volatile' group. Turns out that volatile enumerations
17458 were changing the type here to perform a validity test, which
17461 2003-02-12 Miguel de Icaza <miguel@ximian.com>
17463 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
17464 and structs, we do not want to load the instance variable
17466 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
17467 enum_type has to be handled like an object reference (implicit
17468 conversions exists from this to object), but the regular IsClass
17469 and IsValueType tests will never return true for this one.
17471 Also we use TypeManager.IsValueType instead of type.IsValueType,
17472 just for consistency with the rest of the code (this is only
17473 needed if we ever use the construct exposed by test-180.cs inside
17474 corlib, which we dont today).
17476 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
17478 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
17481 2003-02-09 Martin Baulig <martin@ximian.com>
17483 * namespace.cs (Namespace..ctor): Added SourceFile argument.
17484 (Namespace.DefineNamespaces): New static public method; this is
17485 called when we're compiling with debugging to add all namespaces
17486 to the symbol file.
17488 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
17489 pass it to the Namespace's .ctor.
17491 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
17492 and MethodBase arguments; pass the namespace ID to the symwriter;
17493 pass the MethodBase instead of the token to the symwriter.
17494 (SymbolWriter.DefineNamespace): New method to add a namespace to
17497 2003-02-09 Martin Baulig <martin@ximian.com>
17499 * symbolwriter.cs: New file. This is a wrapper around
17500 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
17501 methods here in near future.
17503 2003-02-09 Martin Baulig <martin@ximian.com>
17505 * codegen.cs (EmitContext.Mark): Just pass the arguments to
17506 ILGenerator.MarkSequencePoint() which are actually used by the
17509 2003-02-09 Martin Baulig <martin@ximian.com>
17511 * location.cs (SourceFile): New public sealed class. This
17512 contains the name and an index which is used in the location's token.
17513 (Location): Reserve an appropriate number of bits in the token for
17514 the source file instead of walking over that list, this gives us a
17515 really huge performance improvement when compiling with debugging.
17517 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
17518 `SourceFile' argument instead of a string.
17519 (Driver.ProcessFile): Add all the files via Location.AddFile(),
17520 but don't parse/tokenize here, we need to generate the list of all
17521 source files before we do that.
17522 (Driver.ProcessFiles): New static function. Parses/tokenizes all
17525 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
17526 instead of a string.
17528 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
17531 2003-02-09 Martin Baulig <martin@ximian.com>
17533 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
17534 filename on `#line default'.
17536 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
17538 * statement.cs: don't clear the pinned var when the fixed statement
17539 returns from the method (fixes bug#37752).
17541 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
17543 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
17546 2003-02-07 Martin Baulig <martin@ximian.com>
17548 * driver.cs: Removed the `--debug-args' command line argument.
17550 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
17551 automatically by the AsssemblyBuilder.
17552 (CodeGen.InitializeSymbolWriter): We don't need to call any
17553 initialization function on the symbol writer anymore. This method
17554 doesn't take any arguments.
17556 2003-02-03 Miguel de Icaza <miguel@ximian.com>
17558 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
17559 from referenced assemblies as well.
17561 2003-02-02 Martin Baulig <martin@ximian.com>
17563 * class.cs (MethodData.Emit): Generate debugging info for external methods.
17565 2003-02-02 Martin Baulig <martin@ximian.com>
17567 * class.cs (Constructor.Emit): Open the symbol writer before
17568 emitting the constructor initializer.
17569 (ConstructorInitializer.Emit): Call ec.Mark() to allow
17570 single-stepping through constructor initializers.
17572 2003-01-30 Miguel de Icaza <miguel@ximian.com>
17574 * class.cs: Handle error 549: do not allow virtual methods in
17577 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
17579 * decl.cs: Check access levels when resolving types
17581 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
17583 * statement.cs: Add parameters and locals set in catch blocks that might
17584 return to set vector
17586 2003-01-29 Miguel de Icaza <miguel@ximian.com>
17588 * class.cs (Operator): Set the SpecialName flags for operators.
17590 * expression.cs (Invocation.DoResolve): Only block calls to
17591 accessors and operators on SpecialName methods.
17593 (Cast.TryReduce): Handle conversions from char constants.
17596 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
17598 * statement.cs: small memory and time optimization in FlowBranching.
17600 2003-01-28 Pedro Mart <yoros@wanadoo.es>
17602 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
17603 problem that the last fix but in the other sid (Set).
17605 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
17606 access when there is no indexer in the hierarchy.
17608 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
17610 * class.cs: Combine some if statements.
17612 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17614 * driver.cs: fixed bug #37187.
17616 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
17618 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
17619 any indexer, it's needed to build a list with all the indexers in the
17620 hierarchy (AllGetters), else we have problems. Fixes #35653.
17622 2003-01-23 Miguel de Icaza <miguel@ximian.com>
17624 * class.cs (MethodData.Define): It is wrong for an interface
17625 implementation to be static in both cases: explicit and implicit.
17626 We were only handling this in one case.
17628 Improve the if situation there to not have negations.
17630 * class.cs (Field.Define): Turns out that we do not need to check
17631 the unsafe bit on field definition, only on usage. Remove the test.
17633 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17635 * driver.cs: use assembly.Location instead of Codebase (the latest
17636 patch made mcs fail when using MS assemblies).
17638 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
17640 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
17641 get the path to *corlib.dll.
17643 2003-01-21 Nick Drochak <ndrochak@gol.com>
17647 * typemanager.cs: Remove compiler warnings
17649 2003-01-20 Duncan Mak <duncan@ximian.com>
17651 * AssemblyInfo.cs: Bump the version number to 0.19.
17653 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17655 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
17657 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
17659 * class.cs (Constructor::Emit): Emit debugging info for constructors.
17661 2003-01-17 Miguel de Icaza <miguel@ximian.com>
17663 * cs-parser.jay: Small fix: we were not comparing the constructor
17664 name correctly. Thanks to Zoltan for the initial pointer.
17666 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
17668 * cs-tokenizer.cs: Set file name when specified with #line
17670 2003-01-15 Miguel de Icaza <miguel@ximian.com>
17672 * cs-parser.jay: Only perform the constructor checks here if we
17673 are named like the class; This will help provider a better
17674 error. The constructor path is taken when a type definition is
17675 not found, but most likely the user forgot to add the type, so
17676 report that rather than the constructor error.
17678 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
17680 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
17683 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17685 * cs-parser.jay: Add cleanup call.
17687 2003-01-13 Duncan Mak <duncan@ximian.com>
17689 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
17690 consistent with other methods.
17692 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17694 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
17696 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
17698 * attribute.cs: only set GuidAttr to true when we have a
17701 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17705 * typemanager.cs: fixes to allow mcs compile corlib with the new
17706 Type.IsSubclassOf fix.
17708 2003-01-08 Miguel de Icaza <miguel@ximian.com>
17710 * expression.cs (LocalVariableReference.DoResolve): Classify a
17711 constant as a value, not as a variable. Also, set the type for
17714 * cs-parser.jay (fixed_statement): take a type instead of a
17715 pointer_type, so we can produce a better error message later.
17717 * statement.cs (Fixed.Resolve): Flag types that are not pointers
17720 (For.DoEmit): Make inifinite loops have a
17721 non-conditional branch back.
17723 (Fixed.DoEmit): First populate the pinned variables, then emit the
17724 statement, then clear the variables. Before I was emitting the
17725 code once for each fixed piece.
17728 2003-01-08 Martin Baulig <martin@ximian.com>
17730 * statement.cs (FlowBranching.MergeChild): A break in a
17731 SWITCH_SECTION does not leave a loop. Fixes #36155.
17733 2003-01-08 Martin Baulig <martin@ximian.com>
17735 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
17736 lives in the same number space than `param_map'. Fixes #36154.
17738 2003-01-07 Miguel de Icaza <miguel@ximian.com>
17740 * cs-parser.jay (constructor_declaration): Set the
17741 Constructor.ModFlags before probing for it. This makes the
17742 compiler report 514, 515 and 132 (the code was there, but got
17745 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
17746 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
17747 (GotoCase.Resolve): Set `Returns' to ALWAYS.
17749 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
17751 * enum.cs: create the enum static fields using the enum type.
17753 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
17755 * class.cs: don't try to create the ParamBuilder for the return
17756 type if it's not needed (and handle it breaking for the ms runtime
17759 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
17761 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
17763 2002-12-29 Miguel de Icaza <miguel@ximian.com>
17765 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
17766 the command. This showed up while compiling the JANET source
17767 code, which used \r as its only newline separator.
17769 2002-12-28 Miguel de Icaza <miguel@ximian.com>
17771 * class.cs (Method.Define): If we are an operator (because it
17772 reuses our code), then set the SpecialName and HideBySig. #36128
17774 2002-12-22 Miguel de Icaza <miguel@ximian.com>
17776 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
17777 exception, report error 120 `object reference required'.
17779 * driver.cs: Add --pause option, used during to measure the size
17780 of the process as it goes with --timestamp.
17782 * expression.cs (Invocation.DoResolve): Do not allow methods with
17783 SpecialName to be invoked.
17785 2002-12-21 Miguel de Icaza <miguel@ximian.com>
17787 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
17788 number before adding it.
17790 2002-12-21 Ravi Pratap <ravi@ximian.com>
17792 * ecore.cs (StandardImplicitConversion): When in an unsafe
17793 context, we allow conversion between void * to any other pointer
17794 type. This fixes bug #35973.
17796 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
17798 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
17799 is not thrown when extensionless outputs are used
17801 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17803 * rootcontext.cs: fixed compilation of corlib.
17805 2002-12-19 Miguel de Icaza <miguel@ximian.com>
17807 * attribute.cs (Attributes.Contains): Add new method.
17809 * class.cs (MethodCore.LabelParameters): if the parameter is an
17810 `out' parameter, check that no attribute `[In]' has been passed.
17812 * enum.cs: Handle the `value__' name in an enumeration.
17814 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
17816 * decl.cs: Added special case to allow overrides on "protected
17819 2002-12-18 Ravi Pratap <ravi@ximian.com>
17821 * attribute.cs (Attributes.AddAttributeSection): Rename to this
17822 since it makes much more sense.
17824 (Attributes.ctor): Don't require a Location parameter.
17826 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
17828 * attribute.cs (ApplyAttributes): Remove extra Location parameters
17829 since we already have that information per attribute.
17831 * everywhere : make appropriate changes.
17833 * class.cs (LabelParameters): Write the code which actually
17834 applies attributes to the return type. We can't do this on the MS
17835 .NET runtime so we flag a warning in the case an exception is
17838 2002-12-18 Miguel de Icaza <miguel@ximian.com>
17840 * const.cs: Handle implicit null conversions here too.
17842 2002-12-17 Ravi Pratap <ravi@ximian.com>
17844 * class.cs (MethodCore.LabelParameters): Remove the extra
17845 Type [] parameter since it is completely unnecessary. Instead
17846 pass in the method's attributes so that we can extract
17847 the "return" attribute.
17849 2002-12-17 Miguel de Icaza <miguel@ximian.com>
17851 * cs-parser.jay (parse): Use Report.Error to flag errors instead
17852 of ignoring it and letting the compile continue.
17854 * typemanager.cs (ChangeType): use an extra argument to return an
17855 error condition instead of throwing an exception.
17857 2002-12-15 Miguel de Icaza <miguel@ximian.com>
17859 * expression.cs (Unary.TryReduce): mimic the code for the regular
17860 code path. Perform an implicit cast in the cases where we can
17861 implicitly convert to one of the integral types, and then reduce
17862 based on that constant. This fixes bug #35483.
17864 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17866 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
17868 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17870 * namespace.cs: fixed bug #35489.
17872 2002-12-12 Miguel de Icaza <miguel@ximian.com>
17874 * class.cs: Remove some dead code.
17876 * cs-parser.jay: Estimate the number of methods needed
17877 (RootContext.MethodCount);
17879 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
17880 numbers instead of StringBuilders.
17882 * support.cs (PtrHashtable): Add constructor with initial size;
17883 We can now reduce reallocations of the method table.
17885 2002-12-10 Ravi Pratap <ravi@ximian.com>
17887 * attribute.cs (ApplyAttributes): Keep track of the emitted
17888 attributes on a per-target basis. This fixes bug #35413.
17890 2002-12-10 Miguel de Icaza <miguel@ximian.com>
17892 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
17893 default to the Windows 1252 encoding.
17895 (UnixParseOption): Support version, thanks to Alp for the missing
17898 * AssemblyInfo.cs: Add nice assembly information.
17900 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
17903 * cs-parser.jay: Allow a trailing comma before the close bracked
17904 in the attribute_section production.
17906 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
17907 address of the instance was being taken, I will take this out,
17908 because we take the address of the object immediately here.
17910 2002-12-09 Ravi Pratap <ravi@ximian.com>
17912 * typemanager.cs (AreMultipleAllowed): Take care of the most
17913 obvious case where attribute type is not in the current assembly -
17916 2002-12-08 Miguel de Icaza <miguel@ximian.com>
17918 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
17919 definitions, instead of doing that afterwards.
17921 Also we use a nice little hack, depending on the constructor, we
17922 know if we are a "composed" name or a simple name. Hence, we
17923 avoid the IndexOf test, and we avoid
17925 * codegen.cs: Add code to assist in a bug reporter to track down
17926 the source of a compiler crash.
17928 2002-12-07 Ravi Pratap <ravi@ximian.com>
17930 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
17931 types have been emitted for a given element and flag an error
17932 if something which does not have AllowMultiple set is used more
17935 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
17936 attribute types and their corresponding AllowMultiple properties
17938 (AreMultipleAllowed): Check the property for a given type.
17940 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
17941 property in the case we have a TypeContainer.
17943 (Attributes.AddAttribute): Detect duplicates and just skip on
17944 adding them. This trivial fix catches a pretty gross error in our
17945 attribute emission - global attributes were being emitted twice!
17947 Bugzilla bug #33187 is now fixed.
17949 2002-12-06 Miguel de Icaza <miguel@ximian.com>
17951 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
17952 instead of pp_and).
17954 * expression.cs (Binary.ResolveOperator): I can only use the
17955 Concat (string, string, string) and Concat (string, string,
17956 string, string) if the child is actually a concatenation of
17959 2002-12-04 Miguel de Icaza <miguel@ximian.com>
17961 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
17962 context where we need a 2-character lookahead.
17964 * pending.cs (PendingImplementation): Rework so we can keep track
17965 of interface types all the time, and flag those which were
17966 implemented by parents as optional.
17968 2002-12-03 Miguel de Icaza <miguel@ximian.com>
17970 * expression.cs (Binary.ResolveOperator): Use
17971 String.Concat(string,string,string) or
17972 String.Concat(string,string,string,string) when possible.
17974 * typemanager: More helper methods.
17977 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
17979 * pending.cs: remove the bogus return from GetMissingInterfaces()
17980 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
17982 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17984 * namespace.cs: avoid duplicated 'using xxx' being added to
17985 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
17986 when we get more than one 'using' statement for the same namespace.
17987 Report a CS0105 warning for it.
17989 2002-11-30 Miguel de Icaza <miguel@ximian.com>
17991 * cs-tokenizer.cs (consume_identifier): use read directly, instead
17992 of calling getChar/putback, uses internal knowledge of it.
17994 (xtoken): Reorder tokenizer so most common patterns are checked
17995 first. This reduces the compilation time in another 5% (from 8.11s
17996 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
17998 The parsing time is 22% of the compilation in mcs, and from that
17999 64% is spent on the tokenization process.
18001 I tried using a binary search for keywords, but this is slower
18002 than the hashtable. Another option would be to do a couple of
18005 * Not use a StringBuilder, instead use an array of chars,
18006 with a set value. Notice that this way we could catch
18007 the 645 error without having to do it *afterwards*.
18009 * We could write a hand-parser to avoid the hashtable
18010 compares altogether.
18012 The identifier consumption process takes 37% of the tokenization
18013 time. Another 15% is spent on is_number. 56% of the time spent
18014 on is_number is spent on Int64.Parse:
18016 * We could probably choose based on the string length to
18017 use Int32.Parse or Int64.Parse and avoid all the 64-bit
18020 Another 3% is spend on wrapping `xtoken' in the `token' function.
18022 Handle 0xa0 as whitespace (#34752)
18024 2002-11-26 Miguel de Icaza <miguel@ximian.com>
18026 * typemanager.cs (IsCLRType): New routine to tell whether a type
18027 is one of the builtin types.
18029 Maybe it needs to use TypeCodes to be faster. Maybe we could use
18030 typecode in more places instead of doing pointer comparissions.
18031 We could leverage some knowledge about the way the typecodes are
18034 New code to cache namespaces in assemblies, it is currently not
18035 invoked, to be used soon.
18037 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
18039 * expression.cs (Binary.ResolveOperator): specially handle
18040 strings, and do not perform user-defined operator overloading for
18043 2002-11-24 Miguel de Icaza <miguel@ximian.com>
18045 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
18046 internalcall as it is a pretty simple operation; Avoid whenever
18047 possible to call Char.IsLetter.
18049 (consume_identifier): Cut by half the number of
18050 hashtable calls by merging the is_keyword and GetKeyword behavior.
18052 Do not short-circuit, because if we do, we
18053 report errors (ie, #if false && true would produce an invalid
18057 2002-11-24 Martin Baulig <martin@ximian.com>
18059 * expression.cs (Cast.TryReduce): If we're in checked syntax,
18060 check constant ranges and report a CS0221. Fixes #33186.
18062 2002-11-24 Martin Baulig <martin@ximian.com>
18064 * cs-parser.jay: Make this work for uninitialized variable
18065 declarations in the `for' initializer. Fixes #32416.
18067 2002-11-24 Martin Baulig <martin@ximian.com>
18069 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
18070 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
18072 2002-11-24 Martin Baulig <martin@ximian.com>
18074 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
18075 argument; if true, we also check for user-defined conversions.
18076 This is only needed if both arguments are of a user-defined type.
18077 Fixes #30443, added test-175.cs.
18078 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
18080 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
18082 2002-11-24 Martin Baulig <martin@ximian.com>
18084 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
18085 function to get the store opcode.
18086 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
18087 only emit the Ldelema if the store opcode is Stobj. You must run
18088 both test-34 and test-167 to test this. Fixes #34529.
18090 2002-11-23 Martin Baulig <martin@ximian.com>
18092 * ecore.cs (Expression.MemberLookup): Added additional
18093 `qualifier_type' argument which is used when we're being called
18094 from MemberAccess.DoResolve() and null if we're called from a
18096 (Expression.MemberLookupFailed): New method to report errors; this
18097 does the CS1540 check and reports the correct error message.
18099 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
18100 argument for the CS1540 check and redone the way how we're dealing
18101 with private members. See the comment in the source code for details.
18102 (FilterWithClosure): Reverted this back to revision 1.197; renamed
18103 `closure_start_type' to `closure_qualifier_type' and check whether
18104 it's not null. It was not this filter being broken, it was just
18105 being called with the wrong arguments.
18107 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
18108 and pass it the correct `qualifier_type'; this also does the error
18111 2002-11-22 Miguel de Icaza <miguel@ximian.com>
18113 * expression.cs (Invocation.EmitParams): If the we are dealing
18114 with a non-built-in value type, load its address as well.
18116 (ArrayCreation): Use a a pretty constant instead
18117 of the hardcoded value 2. Use 6 instead of 2 for the number of
18118 static initializers.
18120 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
18121 because they are not really value types, just glorified integers.
18123 * driver.cs: Do not append .exe, the CSC compiler does not do it.
18125 * ecore.cs: Remove redundant code for enumerations, make them use
18126 the same code path as everything else, fixes the casting issue
18127 with enumerations in Windows.Forms.
18129 * attribute.cs: Do only cast to string if it is a string, the
18130 validation happens later.
18132 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
18133 people upgrade their corlibs.
18135 * ecore.cs: Oops, enumerations were not following the entire code path
18137 2002-11-21 Miguel de Icaza <miguel@ximian.com>
18139 * typemanager.cs (FilterWithClosure): Commented out the test for
18140 1540 in typemanager.cs, as it has problems when accessing
18141 protected methods from a parent class (see test-174.cs).
18143 * attribute.cs (Attribute.ValidateGuid): new method.
18144 (Attribute.Resolve): Use above.
18146 2002-11-19 Miguel de Icaza <miguel@ximian.com>
18148 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
18150 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
18151 handling for enumerations, as we only needed the TypeContainer
18152 functionality to begin with (this is required for the fix below to
18153 work for enums that reference constants in a container class for
18156 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
18158 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
18159 a valid TypeBuilder to perform lookups on.o
18161 * class.cs (InheritableMemberSignatureCompare): Use true in the
18162 call to GetGetMethod and GetSetMethod, because we are comparing
18163 the signature, and we need to get the methods *even* if they are
18166 (PropertyBase.CheckBase): ditto.
18168 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
18169 GotoCase.Resolve): Use Peel on EmpytCasts.
18171 * ecore.cs (EmptyCast): drop child, add Peel method.
18173 2002-11-17 Martin Baulig <martin@ximian.com>
18175 * ecore.cs (EmptyCast.Child): New public property.
18177 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
18178 label resolved to an EmptyCast. Fixes #34162.
18179 (GotoCase.Resolve): Likewise.
18180 (Block.EmitMeta): Likewise.
18182 2002-11-17 Martin Baulig <martin@ximian.com>
18184 * expression.cs (Invocation.BetterConversion): Prefer int over
18185 uint; short over ushort; long over ulong for integer literals.
18186 Use ImplicitConversionExists instead of StandardConversionExists
18187 since we also need to check for user-defined implicit conversions.
18188 Fixes #34165. Added test-173.cs.
18190 2002-11-16 Martin Baulig <martin@ximian.com>
18192 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
18193 with the `true' and `false' literals. Fixes #33151.
18195 2002-11-16 Martin Baulig <martin@ximian.com>
18197 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
18198 October 22nd; don't do the cs1540 check for static members.
18200 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
18201 now using our own filter here and doing the cs1540 check again.
18203 2002-11-16 Martin Baulig <martin@ximian.com>
18205 * support.cs (InternalParameters): Don't crash if we don't have
18206 any fixed parameters. Fixes #33532.
18208 2002-11-16 Martin Baulig <martin@ximian.com>
18210 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
18211 when looking up static methods to make this work on Windows.
18214 2002-11-16 Martin Baulig <martin@ximian.com>
18216 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
18217 a setter rather than using PropertyInfo.CanWrite.
18219 2002-11-15 Nick Drochak <ndrochak@gol.com>
18221 * class.cs: Allow acces to block member by subclasses. Fixes build
18224 2002-11-14 Martin Baulig <martin@ximian.com>
18226 * class.cs (Constructor.Emit): Added the extern/block check.
18229 2002-11-14 Martin Baulig <martin@ximian.com>
18231 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
18232 iteration while looking for indexers, this is needed because the
18233 indexer may have a different name in our base classes. Fixed the
18234 error reporting (no indexers at all, not get accessor, no
18235 overloaded match). Fixes bug #33089.
18236 (IndexerAccess.DoResolveLValue): Likewise.
18238 2002-11-14 Martin Baulig <martin@ximian.com>
18240 * class.cs (PropertyBase.CheckBase): Make this work for multiple
18241 indexers. Fixes the first part of bug #33089.
18242 (MethodSignature.InheritableMemberSignatureCompare): Added support
18245 2002-11-13 Ravi Pratap <ravi@ximian.com>
18247 * attribute.cs (Attribute.Resolve): Catch the
18248 NullReferenceException and report it since it isn't supposed to
18251 2002-11-12 Miguel de Icaza <miguel@ximian.com>
18253 * expression.cs (Binary.EmitBranchable): Also handle the cases for
18254 LogicalOr and LogicalAnd that can benefit from recursively
18255 handling EmitBranchable. The code now should be nice for Paolo.
18257 2002-11-08 Miguel de Icaza <miguel@ximian.com>
18259 * typemanager.cs (LookupType): Added a negative-hit hashtable for
18260 the Type lookups, as we perform quite a number of lookups on
18261 non-Types. This can be removed once we can deterministically tell
18262 whether we have a type or a namespace in advance.
18264 But this might require special hacks from our corlib.
18268 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
18269 and double which avoids a conversion from an integer to a double.
18271 * expression.cs: tiny optimization, avoid calling IsConstant,
18272 because it effectively performs the lookup twice.
18274 2002-11-06 Miguel de Icaza <miguel@ximian.com>
18276 But a bogus return here to keep the semantics of the old code
18277 until the Mono runtime is fixed.
18279 * pending.cs (GetMissingInterfaces): New method used to remove all
18280 the interfaces that are already implemented by our parent
18281 classes from the list of pending methods.
18283 * interface.cs: Add checks for calls after ResolveTypeExpr.
18285 2002-11-05 Miguel de Icaza <miguel@ximian.com>
18287 * class.cs (Class.Emit): Report warning 67: event not used if the
18288 warning level is beyond 3.
18290 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
18291 being a NullLiteral.
18293 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
18296 * class.cs (TypeContainer.GetClassBases): Cover a missing code
18297 path that might fail if a type can not be resolved.
18299 * expression.cs (Binary.Emit): Emit unsigned versions of the
18302 * driver.cs: use error 5.
18304 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
18306 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
18308 2002-11-01 Miguel de Icaza <miguel@ximian.com>
18310 * cs-parser.jay (switch_section): A beautiful patch from Martin
18311 Baulig that fixed 33094.
18313 2002-10-31 Miguel de Icaza <miguel@ximian.com>
18315 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
18316 Check whether the base is abstract and report an error if so.
18318 * expression.cs (IndexerAccess.DoResolveLValue,
18319 IndexerAccess.DoResolve): ditto.
18321 (Invocation.DoResolve): ditto.
18323 (Invocation.FullMethodDesc): Improve the report string.
18325 * statement.cs (Block): Eliminate IsVariableDefined as it is
18326 basically just a wrapper for GetVariableInfo.
18328 * ecore.cs (SimpleName): Use new
18330 * support.cs (ReflectionParamter.ParameterType): We unwrap the
18331 type, as we return the actual parameter ref/unref state on a
18334 2002-10-30 Miguel de Icaza <miguel@ximian.com>
18336 * support.cs: Return proper flags REF/OUT fixing the previous
18339 * expression.cs: Reverted last patch, that was wrong. Is_ref is
18340 not used to mean `ref' but `ref or out' in ParameterReference
18342 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
18343 full type signature instead of calling TypeManger.CSharpName
18346 * support.cs (InternalParameters.ParameterDesc): Do not compare
18347 directly to the modflags, because REF/OUT will actually be bitsets
18350 * delegate.cs (VerifyMethod): Check also the modifiers.
18352 * cs-tokenizer.cs: Fix bug where floating point values with an
18353 exponent where a sign was missing was ignored.
18355 * driver.cs: Allow multiple assemblies to be specified in a single
18358 2002-10-28 Miguel de Icaza <miguel@ximian.com>
18360 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
18361 because identifiers after a parenthesis would end up in this kind
18362 of production, and we needed to desamiguate it for having casts
18365 (UserDefinedType *) xxx
18367 2002-10-24 Miguel de Icaza <miguel@ximian.com>
18369 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
18370 we should set on the Bindingflags.NonPublic, but not turn on
18371 private_ok. private_ok controls whether a Private member is
18372 returned (this is chekced on the filter routine), while the
18373 BindingFlags.NonPublic just controls whether private/protected
18374 will be allowed. This fixes the problem part of the problem of
18375 private properties being allowed to be used in derived classes.
18377 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
18378 so we can call the children DoResolveLValue method (this will
18379 properly signal errors on lvalue assignments to base properties)
18381 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
18382 getter are null, and we have a property info, we know that this
18383 happened because the lookup failed, so we report an error 122 for
18384 protection level violation.
18386 We also silently return if setter and getter are null in the
18387 resolve functions, this condition only happens if we have flagged
18388 the error before. This is the other half of the problem.
18390 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
18391 not have accessibility information, that is why we were returning
18392 true in the filter function in typemanager.cs.
18394 To properly report 122 (property is inaccessible because of its
18395 protection level) correctly, we report this error in ResolveAccess
18396 by failing if both the setter and the getter are lacking (ie, the
18399 DoResolve and DoLResolve have been modified to check for both
18400 setter/getter being null and returning silently, the reason being
18401 that I did not want to put the knowledge about this error in upper
18404 int old = Report.Errors;
18405 x = new PropertyExpr (...);
18406 if (old != Report.Errors)
18411 So the property expr is returned, but it is invalid, so the error
18412 will be flagged during the resolve process.
18414 * class.cs: Remove InheritablePropertySignatureCompare from the
18415 class, as we no longer depend on the property signature to compute
18416 whether it is possible to implement a method or not.
18418 The reason is that calling PropertyInfo.GetGetMethod will return
18419 null (in .NET, in Mono it works, and we should change this), in
18420 cases where the Get Method does not exist in that particular
18425 class X { public virtual int A { get { return 1; } } }
18427 class Z : Y { public override int A { get { return 2; } } }
18429 Would fail in Z because the parent (Y) would not have the property
18430 defined. So we avoid this completely now (because the alternative
18431 fix was ugly and slow), and we now depend exclusively on the
18434 (PropertyBase.CheckBase): Use a method-base mechanism to find our
18435 reference method, instead of using the property.
18437 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
18438 routines are gone now.
18440 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
18441 names, they were incorrectly named.
18443 * cs-tokenizer.cs: Return are more gentle token on failure.
18445 * pending.cs (PendingImplementation.InterfaceMethod): This routine
18446 had an out-of-sync index variable, which caused it to remove from
18447 the list of pending methods the wrong method sometimes.
18449 2002-10-22 Miguel de Icaza <miguel@ximian.com>
18451 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
18452 CanWrite, because those refer to this particular instance of the
18453 property, and do not take into account the fact that we can
18454 override single members of a property.
18456 Constructor requires an EmitContext. The resolution process does
18457 not happen here, but we need to compute the accessors before,
18458 because the resolution does not always happen for properties.
18460 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
18461 subclass, before we did not update this flag, but we did update
18464 (GetAccessors): Drop this routine, as it did not work in the
18465 presence of partially overwritten set/get methods.
18467 Notice that this broke the cs1540 detection, but that will require
18470 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18474 * driver.cs: issue a warning instead of an error if we don't support
18475 debugging for the platform. Also ignore a couple of errors that may
18476 arise when trying to write the symbols. Undo my previous patch.
18478 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18480 * driver.cs: ignore /debug switch except for Unix platforms.
18482 2002-10-23 Nick Drochak <ndrochak@gol.com>
18484 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
18486 2002-10-21 Miguel de Icaza <miguel@ximian.com>
18488 * driver.cs: Do not make mcs-debug conditional, so we do not break
18489 builds that use it.
18491 * statement.cs (UsageVector.MergeChildren): I would like Martin to
18492 review this patch. But basically after all the children variables
18493 have been merged, the value of "Breaks" was not being set to
18494 new_breaks for Switch blocks. I think that it should be set after
18495 it has executed. Currently I set this to the value of new_breaks,
18496 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
18497 conservative, but I do not understand this code very well.
18499 I did not break anything in the build, so that is good ;-)
18501 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
18503 2002-10-20 Mark Crichton <crichton@gimp.org>
18505 * cfold.cs: Fixed compile blocker. Really fixed it this time.
18507 2002-10-20 Nick Drochak <ndrochak@gol.com>
18509 * cfold.cs: Fixed compile blocker.
18511 2002-10-20 Miguel de Icaza <miguel@ximian.com>
18513 * driver.cs: I was chekcing the key, not the file.
18515 2002-10-19 Ravi Pratap <ravi@ximian.com>
18517 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
18518 message that we were generating - we just need to silently return
18521 2002-10-19 Miguel de Icaza <miguel@ximian.com>
18523 * class.cs (Event.Define): Change my previous commit, as this
18524 breaks the debugger. This is a temporary hack, as it seems like
18525 the compiler is generating events incorrectly to begin with.
18527 * expression.cs (Binary.ResolveOperator): Added support for
18528 "U operator - (E x, E y)"
18530 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
18533 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
18534 init-only variables, but this path did not take into account that
18535 there might be also instance readonly variables. Correct this
18538 This fixes bug 32253
18540 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
18543 * driver.cs: Change the extension for modules to `netmodule'
18545 * cs-parser.jay: Improved slightly the location tracking for
18546 the debugger symbols.
18548 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
18549 modifiers that were specified instead of the hardcoded value
18550 (FamAndAssem). This was basically ignoring the static modifier,
18551 and others. Fixes 32429.
18553 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
18554 fixed a bug in the process (32476)
18556 * expression.cs (ArrayAccess.EmitAssign): Patch from
18557 hwang_rob@yahoo.ca that fixes bug 31834.3
18559 2002-10-18 Miguel de Icaza <miguel@ximian.com>
18561 * driver.cs: Make the module extension .netmodule.
18563 2002-10-16 Miguel de Icaza <miguel@ximian.com>
18565 * driver.cs: Report an error if the resource file is not found
18566 instead of crashing.
18568 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
18569 false, like Emit does.
18571 2002-10-16 Nick Drochak <ndrochak@gol.com>
18573 * typemanager.cs: Remove unused private member. Also reported mcs
18574 bug to report this as a warning like csc.
18576 2002-10-15 Martin Baulig <martin@gnome.org>
18578 * statement.cs (Statement.Emit): Made this a virtual method; emits
18579 the line number info and calls DoEmit().
18580 (Statement.DoEmit): New protected abstract method, formerly knows
18581 as Statement.Emit().
18583 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
18585 2002-10-11 Miguel de Icaza <miguel@ximian.com>
18587 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
18588 have fixed a remaining problem: not every AddXXXX was adding a
18589 fully qualified name.
18591 Now everyone registers a fully qualified name in the DeclSpace as
18592 being defined instead of the partial name.
18594 Downsides: we are slower than we need to be due to the excess
18595 copies and the names being registered this way.
18597 The reason for this is that we currently depend (on the corlib
18598 bootstrap for instance) that types are fully qualified, because
18599 we dump all the types in the namespace, and we should really have
18600 types inserted into the proper namespace, so we can only store the
18601 basenames in the defined_names array.
18603 2002-10-10 Martin Baulig <martin@gnome.org>
18605 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
18606 from bug #31834, see the bug report for a testcase which is
18609 2002-10-10 Martin Baulig <martin@gnome.org>
18611 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
18612 flow analysis code for this.
18614 * statement.cs (Do, While, For): Tell the flow analysis code about
18616 (FlowBranching.UsageVector): Added support for infinite loops.
18617 (Block.Resolve): Moved the dead code elimination here and use flow
18620 2002-10-09 Miguel de Icaza <miguel@ximian.com>
18622 * class.cs (Field.Define): Catch cycles on struct type
18625 * typemanager.cs (IsUnmanagedtype): Do not recursively check
18626 fields if the fields are static. We only need to check instance
18629 * expression.cs (As.DoResolve): Test for reference type.
18631 * statement.cs (Using.ResolveExpression): Use
18632 ConvertImplicitRequired, not ConvertImplicit which reports an
18634 (Using.ResolveLocalVariableDecls): ditto.
18636 * expression.cs (Binary.ResolveOperator): Report errors in a few
18637 places where we had to.
18639 * typemanager.cs (IsUnmanagedtype): Finish implementation.
18641 2002-10-08 Miguel de Icaza <miguel@ximian.com>
18643 * expression.cs: Use StoreFromPtr instead of extracting the type
18644 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
18646 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
18647 an enumeration value to a System.Enum, but System.Enum is not a
18648 value type, but an class type, so we need to box.
18650 (Expression.ConvertExplicit): One codepath could return
18651 errors but not flag them. Fix this. Fixes #31853
18653 * parameter.cs (Resolve): Do not allow void as a parameter type.
18655 2002-10-06 Martin Baulig <martin@gnome.org>
18657 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
18658 if it's a class type and not a struct. Fixes #31815.
18660 2002-10-06 Martin Baulig <martin@gnome.org>
18662 * statement.cs: Reworked the flow analysis code a bit to make it
18663 usable for dead code elimination.
18665 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18667 * cs-parser.jay: allow empty source files. Fixes bug #31781.
18669 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18671 * expression.cs (ComposedCast.DoResolveType): A quick workaround
18672 to fix the test 165, will investigate deeper.
18674 2002-10-04 Martin Baulig <martin@gnome.org>
18676 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
18677 finally blocks actually work.
18678 (Try.Resolve): We don't need to create a sibling for `finally' if
18679 there is no finally block.
18681 2002-10-04 Martin Baulig <martin@gnome.org>
18683 * class.cs (Constructor.Define): The default accessibility for a
18684 non-default constructor is private, not public.
18686 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18688 * class.cs (Constructor): Make AllowedModifiers public, add
18691 * cs-parser.jay: Perform the modifiers test here, as the
18692 constructor for the Constructor class usually receives a zero
18693 because of the way we create it (first we create, later we
18694 customize, and we were never checking the modifiers).
18696 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
18697 is a version of LookupTypeReflection that includes the type-name
18698 cache. This can be used as a fast path for functions that know
18699 the fully qualified name and are only calling into *.GetType() to
18700 obtain a composed type.
18702 This is also used by TypeManager.LookupType during its type
18705 (LookupType): We now also track the real type name, as sometimes
18706 we can get a quey for the real type name from things like
18707 ComposedCast. This fixes bug 31422.
18709 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
18710 complete type fullname, it does not have to go through the type
18711 resolution system to obtain the composed version of the type (for
18712 obtaining arrays or pointers).
18714 (Conditional.Emit): Use the EmitBoolExpression to
18715 generate nicer code, as requested by Paolo.
18717 (ArrayCreation.CheckIndices): Use the patch from
18718 hwang_rob@yahoo.ca to validate the array initializers.
18720 2002-10-03 Miguel de Icaza <miguel@ximian.com>
18722 * class.cs (ConstructorInitializer.Emit): simplify code by using
18723 Invocation.EmitCall, and at the same time, fix the bugs in calling
18724 parent constructors that took variable arguments.
18726 * ecore.cs (Expression.ConvertNumericExplicit,
18727 Expression.ImplicitNumericConversion): Remove the code that
18728 manually wrapped decimal (InternalTypeConstructor call is now gone
18731 * expression.cs (Cast.TryReduce): Also handle decimal types when
18732 trying to perform a constant fold on the type.
18734 * typemanager.cs (IsUnmanagedtype): Partially implemented.
18736 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
18737 that only turned off an error report, and did nothing else.
18739 2002-10-02 Miguel de Icaza <miguel@ximian.com>
18741 * driver.cs: Handle and ignore /fullpaths
18743 2002-10-01 Miguel de Icaza <miguel@ximian.com>
18745 * expression.cs (Binary.ResolveOperator): Catch the case where
18746 DoNumericPromotions returns true,
18748 (Binary.DoNumericPromotions): Simplify the code, and the tests.
18750 2002-09-27 Miguel de Icaza <miguel@ximian.com>
18752 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
18755 2002-09-26 Miguel de Icaza <miguel@ximian.com>
18757 * ecore.cs (ConvertNumericExplicit): It is not enough that the
18758 conversion exists, but it is also required that the conversion be
18759 performed. This manifested in "(Type64Enum) 2".
18761 * class.cs (TypeManager.AddMethod): The fix is not to change
18762 AddEnum, because that one was using a fully qualified name (every
18763 DeclSpace derivative does), but to change the AddMethod routine
18764 that was using an un-namespaced name. This now correctly reports
18765 the duplicated name.
18767 Revert patch until I can properly fix it. The issue
18768 is that we have a shared Type space across all namespaces
18769 currently, which is wrong.
18771 Options include making the Namespace a DeclSpace, and merge
18772 current_namespace/current_container in the parser.
18774 2002-09-25 Miguel de Icaza <miguel@ximian.com>
18776 * cs-parser.jay: Improve error reporting when we get a different
18777 kind of expression in local_variable_type and
18778 local_variable_pointer_type.
18780 Propagate this to avoid missleading errors being reported.
18782 * ecore.cs (ImplicitReferenceConversion): treat
18783 TypeManager.value_type as a target just like object_type. As
18788 Is valid, and needs to result in the int 1 being boxed before it
18789 is assigned to the value type v.
18791 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
18792 to validate the enumeration name.
18794 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
18795 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
18796 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
18798 * ecore.cs (TryImplicitIntConversion): When doing an
18799 implicit-enumeration-conversion, check if the type is 64-bits and
18800 perform a conversion before passing to EnumConstant.
18802 2002-09-23 Miguel de Icaza <miguel@ximian.com>
18804 * decl.cs (Error_AmbiguousTypeReference); New routine used to
18805 report ambiguous type references. Unlike the MS version, we
18806 report what the ambiguity is. Innovation at work ;-)
18808 (DeclSpace.FindType): Require a location argument to
18809 display when we display an ambiguous error.
18811 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
18813 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
18815 * expression.cs (EmitDynamicInitializers): Apply patch from
18816 hwang_rob@yahoo.ca that fixes the order in which we emit our
18819 2002-09-21 Martin Baulig <martin@gnome.org>
18821 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
18822 delegate takes no arguments.
18824 2002-09-20 Miguel de Icaza <miguel@ximian.com>
18826 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
18829 * expression.cs: Extract the underlying type.
18831 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
18833 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
18835 2002-09-19 Miguel de Icaza <miguel@ximian.com>
18837 * class.cs (TypeContainer.DefineType): We can not use the nice
18838 PackingSize with the size set to 1 DefineType method, because it
18839 will not allow us to define the interfaces that the struct
18842 This completes the fixing of bug 27287
18844 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
18845 means also structs. This fixes part of the problem.
18846 (Expresion.ImplicitReferenceConversionExists): ditto.
18848 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
18849 error if there were no errors reported during the type lookup
18850 process, to avoid duplicates or redundant errors. Without this
18851 you would get an ambiguous errors plus a type not found. We have
18852 beaten the user enough with the first error.
18854 (DeclSparce.FindType): Emit a warning if we have an ambiguous
18857 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
18858 during the resolution process, stop the lookup, this avoids
18859 repeated error reports (same error twice).
18861 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
18863 * typemanager.cs (LookupType): Redo the type lookup code to match
18864 the needs of System.Reflection.
18866 The issue is that System.Reflection requires references to nested
18867 types to begin with a "+" sign instead of a dot. So toplevel
18868 types look like: "NameSpace.TopLevelClass", and nested ones look
18869 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
18872 2002-09-19 Martin Baulig <martin@gnome.org>
18874 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
18875 says that a method always returns or always throws an exception,
18876 don't report the CS0161.
18878 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
18879 set `Returns = new_returns'.
18881 2002-09-19 Martin Baulig <martin@gnome.org>
18883 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
18884 to an enum constant, check for a CS0176.
18886 2002-09-18 Miguel de Icaza <miguel@ximian.com>
18888 * class.cs (TypeContainer.CheckPairedOperators): Now we check
18889 for operators that must be in pairs and report errors.
18891 * ecore.cs (SimpleName.DoResolveType): During the initial type
18892 resolution process, when we define types recursively, we must
18893 check first for types in our current scope before we perform
18894 lookups in the enclosing scopes.
18896 * expression.cs (MakeByteBlob): Handle Decimal blobs.
18898 (Invocation.VerifyArgumentsCompat): Call
18899 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
18900 I thought we were supposed to always call this, but there are a
18901 few places in the code where we dont do it.
18903 2002-09-17 Miguel de Icaza <miguel@ximian.com>
18905 * driver.cs: Add support in -linkres and -resource to specify the
18906 name of the identifier.
18908 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18910 * ecore.cs (StandardConversionExists): Sync with the conversion
18911 code: allow anything-* to void* conversions.
18913 (FindMostSpecificSource): Use an Expression argument
18914 instead of a Type, because we might be handed over a Literal which
18915 gets a few more implicit conversions that plain types do not. So
18916 this information was being lost.
18918 Also, we drop the temporary type-holder expression when not
18921 2002-09-17 Martin Baulig <martin@gnome.org>
18923 * class.cs (PropertyBase.CheckBase): Don't check the base class if
18924 this is an explicit interface implementation.
18926 2002-09-17 Martin Baulig <martin@gnome.org>
18928 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
18929 different `IndexerName' attributes.
18931 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
18932 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
18933 virtual CommonResolve().
18935 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18937 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
18938 and convert that to the UnderlyingType.
18940 * statement.cs (Foreach.Resolve): Indexers are just like variables
18941 or PropertyAccesses.
18943 * cs-tokenizer.cs (consume_string): Track line numbers and columns
18944 inside quoted strings, we were not doing this before.
18946 2002-09-16 Martin Baulig <martin@gnome.org>
18948 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
18949 resolve it. This is needed for the definite assignment check of the
18950 instance expression, fixes bug #29846.
18951 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
18953 2002-09-16 Nick Drochak <ndrochak@gol.com>
18955 * parameter.cs: Fix compile error. Cannot reference static member
18956 from an instance object. Is this an mcs bug?
18958 2002-09-14 Martin Baulig <martin@gnome.org>
18960 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
18961 multiple times. Fixes bug #30295, added test-166.cs.
18963 2002-09-14 Martin Baulig <martin@gnome.org>
18965 * statement.cs (Block.Emit): Don't emit unreachable code.
18966 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
18967 `break' statements.
18968 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
18970 2002-09-14 Martin Baulig <martin@gnome.org>
18972 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
18975 2002-09-14 Martin Baulig <martin@gnome.org>
18977 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
18978 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
18979 be false on the ms runtime.
18981 2002-09-13 Martin Baulig <martin@gnome.org>
18983 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
18984 the CS0038 error message.
18986 2002-09-12 Miguel de Icaza <miguel@ximian.com>
18988 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
18989 constant inside, return it.
18991 2002-09-12 Martin Baulig <martin@gnome.org>
18993 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
18994 implicit conversion can be done between enum types.
18996 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
18997 check whether an implicit conversion to the current enum's UnderlyingType
18998 exists and report an error if not.
19000 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
19001 without debugging support.
19003 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
19004 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
19006 2002-09-12 Martin Baulig <martin@gnome.org>
19008 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
19010 * ecore.cs (IMemberExpr.DeclaringType): New property.
19011 (SimpleName.SimpleNameResolve): Check whether we're accessing a
19012 nonstatic member of an outer type (CS0038).
19014 2002-09-11 Miguel de Icaza <miguel@ximian.com>
19016 * driver.cs: Activate the using-error detector at warning level
19017 4 (at least for MS-compatible APIs).
19019 * namespace.cs (VerifyUsing): Small buglett fix.
19021 * pending.cs (PendingImplementation): pass the container pointer.
19023 * interface.cs (GetMethods): Allow for recursive definition. Long
19024 term, I would like to move every type to support recursive
19025 definitions, not the current ordering mechanism that we have right
19028 The situation is this: Attributes are handled before interfaces,
19029 so we can apply attributes to interfaces. But some attributes
19030 implement interfaces, we will now handle the simple cases
19031 (recursive definitions will just get an error).
19033 * parameter.cs: Only invalidate types at the end if we fail to
19036 2002-09-09 Martin Baulig <martin@gnome.org>
19038 * ecore.cs (PropertyExpr.Emit): Also check for
19039 TypeManager.system_int_array_get_length so this'll also work when
19040 compiling corlib. Fixes #30003.
19042 2002-09-09 Martin Baulig <martin@gnome.org>
19044 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
19045 and throw an exception if we can't get the type's size. Fixed #30040,
19048 2002-09-09 Martin Baulig <martin@gnome.org>
19050 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
19052 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
19053 context. Fixes bug #30027.
19055 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
19056 virtual functions. Fixes bug #30043, added test-164.cs.
19058 2002-09-08 Ravi Pratap <ravi@ximian.com>
19060 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
19062 2002-09-08 Nick Drochak <ndrochak@gol.com>
19064 * driver.cs: Use an object to get the windows codepage since it's not a
19067 2002-09-08 Miguel de Icaza <miguel@ximian.com>
19069 * statement.cs (For.Emit): for infinite loops (test == null)
19070 return whether there is a break inside, not always "true".
19072 * namespace.cs (UsingEntry): New struct to hold the name of the
19073 using definition, the location where it is defined, and whether it
19074 has been used in a successful type lookup.
19076 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
19081 2002-09-06 Ravi Pratap <ravi@ximian.com>
19083 * attribute.cs : Fix incorrect code which relied on catching
19084 a NullReferenceException to detect a null being passed in
19085 where an object was expected.
19087 2002-09-06 Miguel de Icaza <miguel@ximian.com>
19089 * statement.cs (Try): flag the catch variable as assigned
19091 * expression.cs (Cast): Simplified by using ResolveType instead of
19092 manually resolving.
19094 * statement.cs (Catch): Fix bug by using ResolveType.
19096 2002-09-06 Ravi Pratap <ravi@ximian.com>
19098 * expression.cs (BetterConversion): Special case for when we have
19099 a NullLiteral as the argument and we have to choose between string
19100 and object types - we choose string the way csc does.
19102 * attribute.cs (Attribute.Resolve): Catch the
19103 NullReferenceException and report error #182 since the Mono
19104 runtime no more has the bug and having this exception raised means
19105 we tried to select a constructor which takes an object and is
19108 2002-09-05 Ravi Pratap <ravi@ximian.com>
19110 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
19111 message (1502, 1503) when we can't locate a method after overload
19112 resolution. This is much more informative and closes the bug
19115 * interface.cs (PopulateMethod): Return if there are no argument
19116 types. Fixes a NullReferenceException bug.
19118 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
19119 expressions too. Previously we were checking only in one place for
19120 positional arguments leaving out named arguments.
19122 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
19123 type to the enum type is not allowed. Remove code corresponding to
19126 (ConvertNumericExplicit): Allow explicit conversions from
19127 the underlying type to enum type. This precisely follows the spec
19128 and closes a bug filed by Gonzalo.
19130 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19133 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
19135 2002-09-03 Miguel de Icaza <miguel@ximian.com>
19137 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
19138 it was important that we stored the right value after the
19139 reduction in `converted'.
19141 2002-09-04 Martin Baulig <martin@gnome.org>
19143 * location.cs (Location.SymbolDocument): Use full pathnames for the
19146 2002-08-30 Miguel de Icaza <miguel@ximian.com>
19148 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
19149 of the expression resolve mechanism, because that will catch the
19150 SimpleName error failures.
19152 (Conditional): If we can not resolve the
19153 expression, return, do not crash.
19155 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19158 (location): display token name instead of its number.
19160 2002-08-28 Martin Baulig <martin@gnome.org>
19162 * expression.cs (Binary.ResolveOperator): Don't silently return
19163 but return an error if an operator cannot be applied between two
19166 2002-08-28 Martin Baulig <martin@gnome.org>
19168 * class.cs (Constructor.Define): Set the permission attributes
19169 correctly instead of making all constructors public.
19171 2002-08-28 Martin Baulig <martin@gnome.org>
19173 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
19174 for private members before reporting a CS0103; if we find anything,
19177 2002-08-28 Martin Baulig <martin@gnome.org>
19179 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
19180 to check whether `closure_start_type == closure_invocation_type',
19181 we also need to check whether `m.DeclaringType == closure_invocation_type'
19182 before bypassing the permission checks. We might be accessing
19183 protected/private members from the base class.
19184 (TypeManager.RealMemberLookup): Only set private_ok if private
19185 members were requested via BindingFlags.NonPublic.
19187 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
19189 * expression.cs (MemberAccess.ResolveMemberAccess): Set
19190 MethodGroupExpr.IsExplicitImpl if appropriate.
19191 (Invocation.DoResolve): Don't report the CS0120 for explicit
19192 interface implementations.
19194 2002-08-27 Martin Baulig <martin@gnome.org>
19196 * expression.cs (Invocation.DoResolve): If this is a static
19197 method and we don't have an InstanceExpression, we must report
19200 2002-08-25 Martin Baulig <martin@gnome.org>
19202 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
19203 `==' between a valuetype and an object.
19205 2002-08-25 Miguel de Icaza <miguel@ximian.com>
19207 * ecore.cs (TypeExpr): Provide a ToString method.
19209 2002-08-24 Martin Baulig <martin@gnome.org>
19211 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
19212 now called proggie.dbg and it's a binary file.
19214 2002-08-23 Martin Baulig <martin@gnome.org>
19216 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
19218 2002-08-23 Martin Baulig <martin@gnome.org>
19220 * struct.cs (MyStructInfo.ctor): Make this work with empty
19221 structs; it's not allowed to use foreach() on null.
19223 2002-08-23 Martin Baulig <martin@gnome.org>
19225 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
19226 writer the full pathname of the generated assembly.
19228 2002-08-23 Martin Baulig <martin@gnome.org>
19230 * statements.cs (FlowBranching.UsageVector.MergeChildren):
19231 A `finally' block never returns or breaks; improved handling of
19234 2002-08-23 Martin Baulig <martin@gnome.org>
19236 * statement.cs (Throw.Resolve): Allow `throw null'.
19238 2002-08-23 Martin Baulig <martin@gnome.org>
19240 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
19241 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
19242 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
19243 MemberLookup would return a wrong event if this is an explicit
19244 interface implementation and the class has an event with the same
19247 2002-08-23 Martin Baulig <martin@gnome.org>
19249 * statement.cs (Block.AddChildVariableNames): New public method.
19250 (Block.AddChildVariableName): Likewise.
19251 (Block.IsVariableNameUsedInChildBlock): Likewise.
19252 (Block.AddVariable): Check whether a variable name has already
19253 been used in a child block.
19255 * cs-parser.jay (declare_local_variables): Mark all variable names
19256 from the current block as being used in a child block in the
19259 2002-08-23 Martin Baulig <martin@gnome.org>
19261 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
19262 find the symbol writer.
19264 * driver.cs: csc also allows the arguments to /define being
19265 separated by commas, not only by semicolons.
19267 2002-08-23 Martin Baulig <martin@gnome.org>
19269 * interface.cs (Interface.GetMembers): Added static check for events.
19271 2002-08-15 Martin Baulig <martin@gnome.org>
19273 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
19274 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
19276 * ecore.cs (Expression.MemberLookup): Added documentation and explained
19277 why the MethodData.EmitDestructor() change was necessary.
19279 2002-08-20 Martin Baulig <martin@gnome.org>
19281 * class.cs (TypeContainer.FindMembers): Added static check for events.
19283 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
19285 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
19286 use Type.GetEvents(), not Type.FindMembers().
19288 2002-08-20 Martin Baulig <martin@gnome.org>
19290 * decl.cs (MemberCache): Added a special method cache which will
19291 be used for method-only searched. This ensures that a method
19292 search will return a MethodInfo with the correct ReflectedType for
19295 2002-08-20 Martin Baulig <martin@gnome.org>
19297 * decl.cs (DeclSpace.FindMembers): Made this public.
19299 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19301 * delegate.cs: fixed build on windows.
19302 [FIXME: Filed as bug #29150: MCS must report these errors.]
19304 2002-08-19 Ravi Pratap <ravi@ximian.com>
19306 * ecore.cs (StandardConversionExists): Return a false
19307 if we are trying to convert the void type to anything else
19308 since that is not allowed.
19310 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
19311 we flag error 70 in the event an event is trying to be accessed
19312 directly from outside the declaring type.
19314 2002-08-20 Martin Baulig <martin@gnome.org>
19316 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
19317 MemberCache from typemanager.cs to decl.cs.
19319 2002-08-19 Martin Baulig <martin@gnome.org>
19321 * class.cs (TypeContainer): Implement IMemberContainer.
19322 (TypeContainer.DefineMembers): Create the MemberCache.
19323 (TypeContainer.FindMembers): Do better BindingFlags checking; only
19324 return public members if BindingFlags.Public was given, check
19325 whether members are static.
19327 2002-08-16 Martin Baulig <martin@gnome.org>
19329 * decl.cs (DeclSpace.Define): Splitted this in Define and
19330 DefineMembers. DefineMembers is called first and initializes the
19333 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
19334 DefineMembers() on all our DeclSpaces.
19336 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
19337 but call DefineMembers() on all nested interfaces. We call their
19338 Define() in our new Define() function.
19340 * interface.cs (Interface): Implement IMemberContainer.
19341 (Interface.Define): Moved all code except the attribute stuf to
19343 (Interface.DefineMembers): Initialize the member cache.
19345 * typemanager.cs (IMemberFinder): Removed this interface, we don't
19346 need this anymore since we can use MemberCache.FindMembers directly.
19348 2002-08-19 Martin Baulig <martin@gnome.org>
19350 * typemanager.cs (MemberCache): When creating the cache for an
19351 interface type, add all inherited members.
19352 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
19353 to `out bool used_cache' and documented it.
19354 (TypeManager.MemberLookup): If we already used the cache in the first
19355 iteration, we don't need to do the interfaces check.
19357 2002-08-19 Martin Baulig <martin@gnome.org>
19359 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
19360 here from IMemberFinder and don't implement this interface anymore.
19361 (DeclSpace.MemberCache): Moved here from IMemberFinder.
19363 * typemanager.cs (IMemberFinder): This interface is now only used by
19364 classes which actually support the member cache.
19365 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
19366 since we only put DeclSpaces into this Hashtable.
19367 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
19368 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
19370 2002-08-16 Martin Baulig <martin@gnome.org>
19372 * typemanager.cs (ICachingMemberFinder): Removed.
19373 (IMemberFinder.MemberCache): New property.
19374 (TypeManager.FindMembers): Merged this with RealFindMembers().
19375 This function will never be called from TypeManager.MemberLookup()
19376 so we can't use the cache here, just the IMemberFinder.
19377 (TypeManager.MemberLookup_FindMembers): Check whether the
19378 IMemberFinder has a MemberCache and call the cache's FindMembers
19380 (MemberCache): Rewrote larger parts of this yet another time and
19381 cleaned it up a bit.
19383 2002-08-15 Miguel de Icaza <miguel@ximian.com>
19385 * driver.cs (LoadArgs): Support quoting.
19387 (Usage): Show the CSC-like command line arguments.
19389 Improved a few error messages.
19391 2002-08-15 Martin Baulig <martin@gnome.org>
19393 * typemanager.cs (IMemberContainer.Type): New property.
19394 (IMemberContainer.IsInterface): New property.
19396 The following changes are conditional to BROKEN_RUNTIME, which is
19397 defined at the top of the file.
19399 * typemanager.cs (MemberCache.MemberCache): Don't add the base
19400 class'es members, but add all members from TypeHandle.ObjectType
19401 if we're an interface.
19402 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
19403 is the current type.
19404 (MemberCache.CacheEntry.Container): Removed this field.
19405 (TypeHandle.GetMembers): Include inherited members.
19407 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19409 * typemanager.cs: fixed compilation and added a comment on a field that
19412 2002-08-15 Martin Baulig <martin@gnome.org>
19414 * class.cs (ConstructorInitializer.Resolve): In the
19415 Expression.MemberLookup call, use the queried_type as
19418 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
19419 declared' attribute, it's always true.
19420 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
19421 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
19422 temporary wrapper for FindMembers which tells MemberLookup whether
19423 members from the base classes are included in the return value.
19424 This will go away soon.
19425 (TypeManager.MemberLookup): Use this temporary hack here; once the
19426 new MemberCache is completed, we don't need to do the DeclaredOnly
19427 looping here anymore since the MemberCache will take care of this.
19428 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
19429 (MemberCache): When creating the MemberCache for a class, get
19430 members from the current class and all its base classes.
19431 (MemberCache.CacheEntry.Container): New field. This is a
19432 temporary hack until the Mono runtime is fixed to distinguish
19433 between ReflectedType and DeclaringType. It allows us to use MCS
19434 with both the MS runtime and the unfixed Mono runtime without
19435 problems and without accecting performance.
19436 (MemberCache.SearchMembers): The DeclaredOnly looping from
19437 TypeManager.MemberLookup is now done here.
19439 2002-08-14 Martin Baulig <martin@gnome.org>
19441 * statement.cs (MyStructInfo.MyStructInfo): Don't call
19442 Type.GetFields on dynamic types but get the fields from the
19443 corresponding TypeContainer.
19444 (MyStructInfo.GetStructInfo): Added check for enum types.
19446 * typemanager.cs (MemberList.IsSynchronized): Implemented.
19447 (MemberList.SyncRoot): Implemented.
19448 (TypeManager.FilterWithClosure): No need to check permissions if
19449 closure_start_type == closure_invocation_type, don't crash if
19450 closure_invocation_type is null.
19452 2002-08-13 Martin Baulig <martin@gnome.org>
19454 Rewrote TypeContainer.FindMembers to use a member cache. This
19455 gives us a speed increase of about 35% for the self-hosting MCS
19456 build and of about 15-20% for the class libs (both on GNU/Linux).
19458 * report.cs (Timer): New class to get enhanced profiling. This
19459 whole class is "TIMER" conditional since it remarkably slows down
19462 * class.cs (MemberList): New class. This is an IList wrapper
19463 which we're now using instead of passing MemberInfo[]'s around to
19464 avoid copying this array unnecessarily.
19465 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
19466 (ICachingMemberFinder, IMemberContainer): New interface.
19467 (TypeManager.FilterWithClosure): If `criteria' is null, the name
19468 has already been checked, otherwise use it for the name comparision.
19469 (TypeManager.FindMembers): Renamed to RealMemberFinder and
19470 provided wrapper which tries to use ICachingMemberFinder.FindMembers
19471 if possible. Returns a MemberList, not a MemberInfo [].
19472 (TypeHandle): New class, implements IMemberContainer. We create
19473 one instance of this class per type, it contains a MemberCache
19474 which is used to do the member lookups.
19475 (MemberCache): New class. Each instance of this class contains
19476 all members of a type and a name-based hash table.
19477 (MemberCache.FindMembers): This is our new member lookup
19478 function. First, it looks up all members of the requested name in
19479 the hash table. Then, it walks this list and sorts out all
19480 applicable members and returns them.
19482 2002-08-13 Martin Baulig <martin@gnome.org>
19484 In addition to a nice code cleanup, this gives us a performance
19485 increase of about 1.4% on GNU/Linux - not much, but it's already
19486 half a second for the self-hosting MCS compilation.
19488 * typemanager.cs (IMemberFinder): New interface. It is used by
19489 TypeManager.FindMembers to call FindMembers on a TypeContainer,
19490 Enum, Delegate or Interface.
19491 (TypeManager.finder_to_member_finder): New PtrHashtable.
19492 (TypeManager.finder_to_container): Removed.
19493 (TypeManager.finder_to_delegate): Removed.
19494 (TypeManager.finder_to_interface): Removed.
19495 (TypeManager.finder_to_enum): Removed.
19497 * interface.cs (Interface): Implement IMemberFinder.
19499 * delegate.cs (Delegate): Implement IMemberFinder.
19501 * enum.cs (Enum): Implement IMemberFinder.
19503 * class.cs (TypeContainer): Implement IMemberFinder.
19505 2002-08-12 Martin Baulig <martin@gnome.org>
19507 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
19509 2002-08-12 Martin Baulig <martin@gnome.org>
19511 * ecore.cs (ITypeExpression): New interface for expressions which
19513 (TypeExpression): Renamed to TypeLookupExpression.
19514 (Expression.DoResolve): If we're doing a types-only lookup, the
19515 expression must implement the ITypeExpression interface and we
19516 call DoResolveType() on it.
19517 (SimpleName): Implement the new ITypeExpression interface.
19518 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
19519 hack, the situation that we're only looking up types can't happen
19520 anymore when this method is called. Moved the type lookup code to
19521 DoResolveType() and call it.
19522 (SimpleName.DoResolveType): This ITypeExpression interface method
19523 is now doing the types-only lookup.
19524 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
19525 (ResolveFlags): Added MaskExprClass.
19527 * expression.cs (MemberAccess): Implement the ITypeExpression
19529 (MemberAccess.DoResolve): Added support for a types-only lookup
19530 when we're called via ITypeExpression.DoResolveType().
19531 (ComposedCast): Implement the ITypeExpression interface.
19533 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
19534 Expression.Resolve() with ResolveFlags.Type instead.
19536 2002-08-12 Martin Baulig <martin@gnome.org>
19538 * interface.cs (Interface.Define): Apply attributes.
19540 * attribute.cs (Attribute.ApplyAttributes): Added support for
19541 interface attributes.
19543 2002-08-11 Martin Baulig <martin@gnome.org>
19545 * statement.cs (Block.Emit): Only check the "this" variable if we
19546 do not always throw an exception.
19548 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
19549 whether the property has a set accessor.
19551 2002-08-11 Martin Baulig <martin@gnome.org>
19553 Added control flow analysis support for structs.
19555 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
19556 with control flow analysis turned off.
19557 (IVariable): New interface.
19558 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
19559 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
19560 (FieldExpr.DoResolve): Resolve the instance expression with flow
19561 analysis turned off and do the definite assignment check after the
19562 resolving when we know what the expression will resolve to.
19564 * expression.cs (LocalVariableReference, ParameterReference):
19565 Implement the new IVariable interface, only call the flow analysis
19566 code if ec.DoFlowAnalysis is true.
19567 (This): Added constructor which takes a Block argument. Implement
19568 the new IVariable interface.
19569 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
19570 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
19571 This does the definite assignment checks for struct members.
19573 * class.cs (Constructor.Emit): If this is a non-static `struct'
19574 constructor which doesn't have any initializer, call
19575 Block.AddThisVariable() to tell the flow analysis code that all
19576 struct elements must be initialized before control returns from
19579 * statement.cs (MyStructInfo): New public class.
19580 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
19581 argument to this indexer. If non-zero, check an individual struct
19582 member, not the whole struct.
19583 (FlowBranching.CheckOutParameters): Check struct members.
19584 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
19585 overloaded versions of these methods which take an additional
19586 `int field_idx' argument to check struct members.
19587 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
19588 overloaded versions of these methods which take an additional
19589 `string field_name' argument to check struct member.s
19590 (VariableInfo): Implement the IVariable interface.
19591 (VariableInfo.StructInfo): New public property. Returns the
19592 MyStructInfo instance of the variable if it's a struct or null.
19593 (Block.AddThisVariable): New public method. This is called from
19594 Constructor.Emit() for non-static `struct' constructor which do
19595 not have any initializer. It creates a special variable for the
19596 "this" instance variable which will be checked by the flow
19597 analysis code to ensure that all of the struct's fields are
19598 initialized before control returns from the constructor.
19599 (UsageVector): Added support for struct members. If a
19600 variable/parameter is a struct with N members, we reserve a slot
19601 in the usage vector for each member. A struct is considered fully
19602 initialized if either the struct itself (slot 0) or all its
19603 members are initialized.
19605 2002-08-08 Martin Baulig <martin@gnome.org>
19607 * driver.cs (Driver.MainDriver): Only report an error CS5001
19608 if there were no compilation errors.
19610 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
19611 `UnsafeContext' property to determine whether the parent is in
19612 unsafe context rather than checking the parent's ModFlags:
19613 classes nested in an unsafe class are unsafe as well.
19615 2002-08-08 Martin Baulig <martin@gnome.org>
19617 * statement.cs (UsageVector.MergeChildren): Distinguish between
19618 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
19619 we return. Added test17() and test18() to test-154.cs.
19621 2002-08-08 Martin Baulig <martin@gnome.org>
19623 * typemanager.cs (TypeManager.FilterWithClosure): If we have
19624 Family access, make sure the invoking type isn't a subclass of the
19625 queried type (that'd be a CS1540).
19627 * ecore.cs (Expression.MemberLookup): Added overloaded version of
19628 this method which takes an additional `Type invocation_type'.
19630 * expression.cs (BaseAccess.DoResolve): Use the base type as
19631 invocation and query type.
19632 (MemberAccess.DoResolve): If the lookup failed and we're about to
19633 report a CS0122, try a lookup with the ec.ContainerType - if this
19634 succeeds, we must report a CS1540.
19636 2002-08-08 Martin Baulig <martin@gnome.org>
19638 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
19639 (MethodGroupExpr): Implement the IMemberExpr interface.
19641 * expression (MemberAccess.ResolveMemberAccess): No need to have
19642 any special code for MethodGroupExprs anymore, they're now
19645 2002-08-08 Martin Baulig <martin@gnome.org>
19647 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
19648 Family, FamANDAssem and FamORAssem permissions.
19649 (TypeManager.IsSubclassOrNestedChildOf): New public method.
19651 2002-08-08 Martin Baulig <martin@gnome.org>
19653 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
19654 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
19657 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
19659 * driver.cs: implemented /resource option to embed managed resources.
19661 2002-08-07 Martin Baulig <martin@gnome.org>
19663 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
19664 (FieldBase.HasFieldInitializer): New public property.
19665 (FieldBase.GetInitializerExpression): New public method. Resolves and
19666 returns the field initializer and makes sure it is only resolved once.
19667 (TypeContainer.EmitFieldInitializers): Call
19668 FieldBase.GetInitializerExpression to get the initializer, this ensures
19669 that it isn't resolved multiple times.
19671 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
19672 the resolving process (SimpleName/MemberLookup) that we're currently
19673 emitting a field initializer (which must not access any instance members,
19674 this is an error CS0236).
19676 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
19677 argument, if the `IsFieldInitializer' flag is set, we must report and
19678 error CS0236 and not an error CS0120.
19680 2002-08-07 Martin Baulig <martin@gnome.org>
19682 * ecore.cs (IMemberExpr): New public interface.
19683 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
19684 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
19685 if the expression is an IMemberExpr.
19687 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
19688 to be null, implicitly default to `this' if we're non-static in
19689 this case. Simplified the code a lot by using the new IMemberExpr
19690 interface. Also fixed bug #28176 here.
19692 2002-08-06 Martin Baulig <martin@gnome.org>
19694 * cs-parser.jay (SimpleLookup): Removed. We need to create
19695 ParameterReferences during semantic analysis so that we can do a
19696 type-only search when resolving Cast, TypeOf and SizeOf.
19697 (block): Pass the `current_local_parameters' to the Block's
19700 * class.cs (ConstructorInitializer): Added `Parameters parameters'
19701 argument to the constructor.
19702 (ConstructorInitializer.Resolve): Create a temporary implicit
19703 block with the parameters.
19705 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
19706 references here if we aren't doing a type-only search.
19708 * statement.cs (Block): Added constructor which takes a
19709 `Parameters parameters' argument.
19710 (Block.Parameters): New public property.
19712 * support.cs (InternalParameters.Parameters): Renamed `parameters'
19713 to `Parameters' and made it public readonly.
19715 2002-08-06 Martin Baulig <martin@gnome.org>
19717 * ecore.cs (Expression.Warning): Made this public as well.
19719 * report.cs (Report.Debug): Print the contents of collections.
19721 2002-08-06 Martin Baulig <martin@gnome.org>
19723 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
19724 used to tell Resolve() which kinds of expressions it may return.
19725 (Expression.Resolve): Added overloaded version of this method which
19726 takes a `ResolveFlags flags' argument. This can be used to tell
19727 Resolve() which kinds of expressions it may return. Reports a
19729 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
19730 ResolveFlags.SimpleName.
19731 (Expression.Error118): Added overloaded version of this method which
19732 takes a `ResolveFlags flags' argument. It uses the flags to determine
19733 which kinds of expressions are allowed.
19735 * expression.cs (Argument.ResolveMethodGroup): New public method.
19736 Resolves an argument, but allows a MethodGroup to be returned.
19737 This is used when invoking a delegate.
19739 * TODO: Updated a bit.
19741 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19743 Fixed compilation with csc.
19745 * ecore.cs: Expression.Error made public. Is this correct? Should
19746 Warning be made public too?
19748 * expression.cs: use ea.Location instead of ea.loc.
19749 [FIXME: Filed as bug #28607: MCS must report these errors.]
19751 2002-08-06 Martin Baulig <martin@gnome.org>
19753 * ecore.cs (Expression.loc): Moved the location here instead of
19754 duplicating it in all derived classes.
19755 (Expression.Location): New public property.
19756 (Expression.Error, Expression.Warning): Made them non-static and
19757 removed the location argument.
19758 (Expression.Warning): Added overloaded version which takes an
19759 `int level' argument.
19760 (Expression.Error118): Make this non-static and removed the
19761 expression and location arguments.
19762 (TypeExpr): Added location argument to the constructor.
19764 * expression.cs (StaticCallExpr): Added location argument to
19766 (Indirection, PointerArithmetic): Likewise.
19767 (CheckedExpr, UnCheckedExpr): Likewise.
19768 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
19769 (StringPtr): Likewise.
19772 2002-08-05 Martin Baulig <martin@gnome.org>
19774 * expression.cs (BaseAccess.DoResolve): Actually report errors.
19776 * assign.cs (Assign.DoResolve): Check whether the source
19777 expression is a value or variable.
19779 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
19780 while resolving the corresponding blocks.
19782 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
19783 an error, don't silently return null.
19785 * statement.cs (Block.AddVariable): Do the error reporting here
19786 and distinguish between CS0128 and CS0136.
19787 (Block.DoResolve): Report all unused labels (warning CS0164).
19788 (LabeledStatement): Pass the location to the constructor.
19789 (LabeledStatement.HasBeenReferenced): New property.
19790 (LabeledStatement.Resolve): Set it to true here.
19792 * statement.cs (Return.Emit): Return success even after reporting
19793 a type mismatch error (CS0126 or CS0127), this is what csc does and
19794 it avoids confusing the users with any consecutive errors.
19796 2002-08-05 Martin Baulig <martin@gnome.org>
19798 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
19800 * const.cs (Const.LookupConstantValue): Catch circular definitions.
19802 * expression.cs (MemberAccess.DoResolve): Silently return if an
19803 error has already been reported.
19805 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
19806 error has already been reported.
19808 2002-08-05 Martin Baulig <martin@gnome.org>
19810 * statement.cs (UsageVector): Only initialize the `parameters'
19811 vector if we actually have any "out" parameters.
19813 2002-08-05 Martin Baulig <martin@gnome.org>
19815 * expression.cs (Binary.ResolveOperator): When combining delegates,
19816 they must have the same type.
19818 2002-08-05 Martin Baulig <martin@gnome.org>
19820 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
19821 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
19822 work with the ms runtime and we also don't need it: if we're a
19823 PropertyBuilder and not in the `indexer_arguments' hash, then we
19824 are a property and not an indexer.
19826 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
19827 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
19828 since the latter one doesn't work with the ms runtime.
19830 2002-08-03 Martin Baulig <martin@gnome.org>
19832 Fixed bugs #27998 and #22735.
19834 * class.cs (Method.IsOperator): New public field.
19835 (Method.CheckBase): Report CS0111 if there's already a method
19836 with the same parameters in the current class. Report CS0508 when
19837 attempting to change the return type of an inherited method.
19838 (MethodData.Emit): Report CS0179 if a method doesn't have a body
19839 and it's not marked abstract or extern.
19840 (PropertyBase): New abstract base class for Property and Indexer.
19841 (PropertyBase.CheckBase): Moved here from Property and made it work
19843 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
19844 the same so we can reuse it there.
19845 (Property, Indexer): Derive from PropertyBase.
19846 (MethodSignature.inheritable_property_signature_filter): New delegate
19847 to find properties and indexers.
19849 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
19850 argument and improved error reporting.
19852 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
19853 EmptyReadOnlyParameters and made it a property.
19855 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
19856 version of this method which takes a `PropertyInfo indexer'.
19857 (TypeManager.RegisterIndexer): New method.
19859 * class.cs: Added myself as author of this file :-)
19861 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19863 * class.cs: fixed compilation on windoze.
19865 2002-08-03 Martin Baulig <martin@gnome.org>
19867 * interface.cs (Interface.GetInterfaceBases): Check whether all
19868 base interfaces are at least as accessible than the current one.
19870 * class.cs (TypeContainer.GetClassBases): Check whether base types
19871 are at least as accessible than the current type.
19872 (TypeContainer.AsAccessible): Implemented and made non-static.
19873 (MemberBase.CheckParameters): Report errors if the accessibility
19876 * delegate.cs (Delegate.Delegate): The default visibility is
19877 internal for top-level types and private for nested types.
19878 (Delegate.Define): Report errors if the accessibility checks fail.
19880 * enum.cs (Enum.Enum): The default visibility is internal for
19881 top-level types and private for nested types.
19882 (Enum.DefineType): Compute the correct visibility.
19884 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
19885 function which takes a `bool is_toplevel' instead of a TypeContainer.
19887 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
19890 2002-08-02 Martin Baulig <martin@gnome.org>
19892 * expression.cs (LocalVariableReferenc): Added constructor which
19893 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
19894 (LocalVariableReference.IsReadOnly): New property.
19895 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
19896 variable is readonly, use our own readonly flag to do this; you can
19897 use the new constructor to get a writable reference to a read-only
19900 * cs-parser.jay (foreach_statement, using_statement): Get a writable
19901 reference to the local variable.
19903 2002-08-01 Miguel de Icaza <miguel@ximian.com>
19905 * rootcontext.cs (ResolveCore): Also include System.Exception
19907 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
19908 we reach an EmptyStatement.
19910 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
19913 * expression.cs (Binary.ResolveOperator): Check error result in
19916 use brtrue/brfalse directly and avoid compares to null.
19918 2002-08-02 Martin Baulig <martin@gnome.org>
19920 * class.cs (TypeContainer.Define): Define all nested interfaces here.
19921 Fixes bug #28407, added test-155.cs.
19923 2002-08-01 Martin Baulig <martin@gnome.org>
19925 * class.cs (Event.EmitDefaultMethod): Make this work with static
19926 events. Fixes #28311, added verify-3.cs.
19928 2002-08-01 Martin Baulig <martin@gnome.org>
19930 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
19931 `is_disposable' fields.
19932 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
19933 `hm.is_disposable' if we're using the collection pattern.
19934 (Foreach.EmitCollectionForeach): Use the correct type for the
19935 enumerator's local variable, only emit the try/finally block if
19936 necessary (fixes #27713).
19938 2002-08-01 Martin Baulig <martin@gnome.org>
19940 * ecore.cs (Expression.report118): Renamed to Error118 and made
19943 * statement.cs (Throw.Resolve): Check whether the expression is of
19944 the correct type (CS0118) and whether the type derives from
19945 System.Exception (CS0155).
19946 (Catch.Resolve): New method. Do the type lookup here and check
19947 whether it derives from System.Exception (CS0155).
19948 (Catch.CatchType, Catch.IsGeneral): New public properties.
19950 * typemanager.cs (TypeManager.exception_type): Added.
19952 2002-07-31 Miguel de Icaza <miguel@ximian.com>
19954 * driver.cs: Updated About function.
19956 2002-07-31 Martin Baulig <martin@gnome.org>
19958 Implemented Control Flow Analysis.
19960 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
19961 (EmitContext.CurrentBranching): Added.
19962 (EmitContext.StartFlowBranching): Added.
19963 (EmitContext.EndFlowBranching): Added.
19964 (EmitContext.KillFlowBranching): Added.
19965 (EmitContext.IsVariableAssigned): Added.
19966 (EmitContext.SetVariableAssigned): Added.
19967 (EmitContext.IsParameterAssigned): Added.
19968 (EmitContext.SetParameterAssigned): Added.
19969 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
19970 Added control flow analysis stuff here.
19972 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
19973 resolve the expression as lvalue.
19974 (LocalVariableReference.DoResolve): Check whether the variable has
19975 already been assigned.
19976 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
19977 the parameter as assigned here.
19978 (ParameterReference.DoResolve): Check whether the parameter has already
19980 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
19981 expression as lvalue.
19983 * statement.cs (FlowBranching): New class for the flow analysis code.
19984 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
19985 (LabeledStatement.IsDefined): New public property.
19986 (LabeledStatement.AddUsageVector): New public method to tell flow
19987 analyis that the label may be reached via a forward jump.
19988 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
19990 (VariableInfo.Number): New public field. This is used by flow analysis
19991 to number all locals of a block.
19992 (Block.CountVariables): New public property. This is the number of
19993 local variables in this block (including the locals from all parent
19995 (Block.EmitMeta): Number all the variables.
19997 * statement.cs: Added flow analysis support to all classes.
19999 2002-07-31 Martin Baulig <martin@gnome.org>
20001 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
20002 To get debugging messages, compile mcs with /define:MCS_DEBUG and
20003 then use this argument.
20005 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
20007 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
20008 use this to specify /define options.
20010 2002-07-29 Martin Baulig <martin@gnome.org>
20012 * statement.cs (Fixed): Moved all code that does variable lookups
20013 and resolvings from Emit to Resolve.
20015 * statement.cs (For): Moved all code that does variable lookups
20016 and resolvings from Emit to Resolve.
20018 * statement.cs (Using): Moved all code that does variable lookups
20019 and resolvings from Emit to Resolve.
20021 2002-07-29 Martin Baulig <martin@gnome.org>
20023 * attribute.cs (Attribute.Resolve): Explicitly catch a
20024 System.NullReferenceException when creating the
20025 CustromAttributeBuilder and report a different warning message.
20027 2002-07-29 Martin Baulig <martin@gnome.org>
20029 * support.cs (ParameterData.ParameterName): Added method to
20030 get the name of a parameter.
20032 * typemanager.cs (TypeManager.IsValueType): New public method.
20034 2002-07-29 Martin Baulig <martin@gnome.org>
20036 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
20037 is a flag which specifies that it's either ref or out.
20038 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
20039 the out parameter to `out Parameter.Modifier mod', also set the
20040 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
20042 * support.cs (InternalParameters.ParameterModifier): Distinguish
20043 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
20044 Parameter.Modifier.ISBYREF flag if it's either ref or out.
20046 * expression.cs (Argument.GetParameterModifier): Distinguish
20047 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
20048 Parameter.Modifier.ISBYREF flag if it's either ref or out.
20050 2002-07-29 Martin Baulig <martin@gnome.org>
20052 * expression.cs (ParameterReference.ParameterReference): Added
20053 `Location loc' argument to the constructor.
20055 * cs-parser.jay: Pass location to ParameterReference.
20057 2002-07-28 Miguel de Icaza <miguel@ximian.com>
20059 * statement.cs (Try): Initialize the location.
20061 * cs-parser.jay: pass location to Try.
20063 * expression.cs (Unary.Reduce): Change the prototype to return
20064 whether a constant fold could be performed or not. The result is
20065 returned in an out parameters. In the case of Indirection and
20066 AddressOf, we want to perform the full tests.
20068 2002-07-26 Miguel de Icaza <miguel@ximian.com>
20070 * statement.cs (Statement.Emit): Flag dead code.
20072 2002-07-27 Andrew Birkett <andy@nobugs.org>
20074 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
20076 2002-07-27 Martin Baulig <martin@gnome.org>
20078 * class.cs (MethodData.Define): Put back call to
20079 TypeManager.AddMethod(), accidentally commented this out.
20081 * report.cs (Debug): New public method to print debugging information,
20082 this is `[Conditional ("DEBUG")]'.
20084 2002-07-26 Martin Baulig <martin@gnome.org>
20086 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
20087 (switch_statement): Push the current_block to the switch_stack and
20088 pop it again when we're done with the switch.
20089 (switch_section): The new block is a child of the current_block.
20090 Fixes bug #24007, added test-152.cs.
20092 2002-07-27 Martin Baulig <martin@gnome.org>
20094 * expression.cs (Invocation.EmitArguments): When calling a varargs
20095 function with only its fixed arguments, we need to pass an empty
20098 2002-07-27 Martin Baulig <martin@gnome.org>
20100 Mono 0.13 has been released.
20102 2002-07-25 Miguel de Icaza <miguel@ximian.com>
20104 * driver.cs: Rename --resource to --linkres, because that is what
20105 we do currently, we dont support --resource yet.
20107 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
20109 2002-07-25 Martin Baulig <martin@gnome.org>
20111 * class.cs (MethodData): New public class. This is a `method builder'
20112 class for a method or one accessor of a Property/Indexer/Event.
20113 (MethodData.GetMethodFlags): Moved here from MemberBase.
20114 (MethodData.ApplyAttributes): Likewise.
20115 (MethodData.ApplyObsoleteAttribute): Likewise.
20116 (MethodData.ApplyConditionalAttribute): Likewise.
20117 (MethodData.ApplyDllImportAttribute): Likewise.
20118 (MethodData.CheckAbstractAndExternal): Likewise.
20119 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
20120 (MethodData.Emit): Formerly known as Method.Emit().
20121 (MemberBase): Moved everything which was specific to a single
20122 accessor/method to MethodData.
20123 (Method): Create a new MethodData and call Define() and Emit() on it.
20124 (Property, Indexer, Event): Create a new MethodData objects for each
20125 accessor and call Define() and Emit() on them.
20127 2002-07-25 Martin Baulig <martin@gnome.org>
20129 Made MethodCore derive from MemberBase to reuse the code from there.
20130 MemberBase now also checks for attributes.
20132 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
20133 (MemberBase.GetMethodFlags): Moved here from class Method and marked
20135 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
20136 `CallingConventions cc' and `Attributes opt_attrs' arguments.
20137 (MemberBase.ApplyAttributes): New virtual method; applies the
20138 attributes to a method or accessor.
20139 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
20140 (MemberBase.ApplyConditionalAttribute): Likewise.
20141 (MemberBase.ApplyDllImportAttribute): Likewise.
20142 (MemberBase.CheckAbstractAndExternal): Likewise.
20143 (MethodCore.ParameterTypes): This is now a property instead of a
20144 method, it's initialized from DoDefineParameters().
20145 (MethodCore.ParameterInfo): Removed the set accessor.
20146 (MethodCore.DoDefineParameters): New protected virtual method to
20147 initialize ParameterTypes and ParameterInfo.
20148 (Method.GetReturnType): We can now simply return the MemberType.
20149 (Method.GetMethodFlags): Override the MemberBase version and add
20150 the conditional flags.
20151 (Method.CheckBase): Moved some code from Define() here, call
20152 DoDefineParameters() here.
20153 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
20154 here to avoid some larger code duplication.
20155 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
20156 ensure that abstract and external accessors don't declare a body.
20158 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
20159 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
20160 lookup in the attribute's parent classes, so we need to abort as soon
20161 as we found the first match.
20162 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
20163 the attribute has no arguments.
20165 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
20168 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20170 * cs-parser.jay: reverted previous patch.
20172 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20174 * cs-parser.jay: fixed bug #22119.
20176 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20178 * attribute.cs: fixed compilation. The error was:
20179 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
20180 be assigned to before control leaves the current method."
20181 [FIXME: Filed as bug #28186: MCS must report this error.]
20183 2002-07-25 Martin Baulig <martin@gnome.org>
20185 * attribute.cs (Attribute.Conditional_GetConditionName): New static
20186 method to pull the condition name ouf of a Conditional attribute.
20187 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
20188 the obsolete message and error flag out of an Obsolete attribute.
20190 * class.cs (Method.GetMethodFlags): New public method to get the
20191 TypeManager.MethodFlags for this method.
20192 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
20194 (Method.Define): Get and apply the Obsolete and Conditional attributes;
20195 if we're overriding a virtual function, set the new private variable
20196 `parent_method'; call the new TypeManager.AddMethod().
20198 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
20199 the MethodBuilder and the Method in a PtrHashtable.
20200 (TypeManager.builder_to_method): Added for this purpose.
20201 (TypeManager.MethodFlags): Added IsObsoleteError.
20202 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
20203 Obsolete and Conditional arguments in MethodBuilders. If we discover
20204 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
20205 the message from the attribute.
20207 2002-07-24 Martin Baulig <martin@gnome.org>
20209 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
20210 preprocessor directives, ensure that the argument to #define/#undef is
20211 exactly one identifier and that it's actually an identifier.
20213 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
20216 2002-07-24 Martin Baulig <martin@gnome.org>
20218 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
20219 initialize it to TypeManager.object_type in the constructor.
20220 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
20221 of the `hm.get_current' method if we're using the collection pattern.
20222 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
20223 for the explicit conversion to make it work when we're using the collection
20224 pattern and the `Current' property has a different return type than `object'.
20227 2002-07-24 Martin Baulig <martin@gnome.org>
20229 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
20230 does not match, but don't report any errors. This method is called in
20231 order for all methods in a MethodGroupExpr until a matching method is
20232 found, so we don't want to bail out if the first method doesn't match.
20233 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
20234 matches, report the 123. Fixes #28070.
20236 2002-07-24 Martin Baulig <martin@gnome.org>
20238 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
20239 TypeManager.TypeToCoreType() to the top of the method so the
20240 following equality checks will work. Fixes #28107.
20242 2002-07-24 Martin Baulig <martin@gnome.org>
20244 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
20245 operand is of type uint, and the other operand is of type sbyte,
20246 short or int, the operands are converted to type long." -
20247 Actually do what this comment already told us. Fixes bug #28106,
20250 2002-07-24 Martin Baulig <martin@gnome.org>
20252 * class.cs (MethodBase): New abstract class. This is now a base
20253 class for Property, Indexer and Event to avoid some code duplication
20254 in their Define() and DefineMethods() methods.
20255 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
20256 generic methods for Define() and DefineMethods().
20257 (FieldBase): Derive from MemberBase, not MemberCore.
20258 (Property): Derive from MemberBase, not MemberCore.
20259 (Property.DefineMethod): Moved all the code from this method to the
20260 new MethodBase.DefineAccessor(), just call it with appropriate
20262 (Property.Define): Call the new Property.DoDefine(), this does some
20263 sanity checks and we don't need to duplicate the code everywhere.
20264 (Event): Derive from MemberBase, not MemberCore.
20265 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
20266 accessors, this will also make them work with interface events.
20267 (Indexer): Derive from MemberBase, not MemberCore.
20268 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
20269 (Indexer.Define): Use the new MethodBase functions.
20271 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
20272 argument to the constructor.
20273 (Interface.FindMembers): Added support for interface events.
20274 (Interface.PopluateEvent): Implemented.
20276 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
20278 2002-07-22 Miguel de Icaza <miguel@ximian.com>
20280 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
20281 but this is required to check for a method name being the same as
20282 the containing class.
20286 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20288 * interface.cs: initialize variable.
20290 2002-07-23 Martin Baulig <martin@gnome.org>
20292 Implemented the IndexerName attribute in interfaces.
20294 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
20295 name if this is an explicit interface implementation.
20296 (Indexer.InterfaceIndexerName): New public variable. If we're
20297 implementing an interface indexer, this is the IndexerName in that
20298 interface. Otherwise, it's the IndexerName.
20299 (Indexer.DefineMethod): If we're implementing interface indexer,
20300 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
20301 and Pending.ImplementIndexer methods.
20302 (Indexer.Define): Also define the PropertyBuilder if we're
20303 implementing an interface indexer and this is neither an explicit
20304 interface implementation nor do the IndexerName match the one in
20307 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
20308 If a method is defined here, then we always need to create a proxy
20309 for it. This is used when implementing interface indexers.
20310 (Pending.IsInterfaceIndexer): New public method.
20311 (Pending.ImplementIndexer): New public method.
20312 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
20313 This is used when implementing interface indexers to define a proxy
20315 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
20316 define a proxy if necessary.
20318 * interface.cs (Interface.IndexerName): New public variable.
20319 (Interface.PopulateIndexer): Set the IndexerName.
20320 (Interface.DefineIndexers): New private method. Populate all the
20321 indexers and make sure their IndexerNames match.
20323 * typemanager.cs (IndexerPropertyName): Added support for interface
20326 2002-07-22 Martin Baulig <martin@gnome.org>
20328 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
20329 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
20330 ret if HasReturnLabel.
20331 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
20334 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
20335 and set the ec.LoopBeginTryCatchLevel.
20336 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
20337 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
20338 the current ec.TryCatchLevel, the branch goes out of an exception
20339 block. In this case, we need to use Leave and not Br.
20341 2002-07-22 Martin Baulig <martin@gnome.org>
20343 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
20344 block unless the block does not always return or it is contained in
20345 another try { ... } catch { ... } block. Fixes bug #26506.
20346 Added verify-1.cs to the test suite.
20348 2002-07-22 Martin Baulig <martin@gnome.org>
20350 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
20351 then we do not always return. Fixes bug #24985.
20353 2002-07-22 Martin Baulig <martin@gnome.org>
20355 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
20356 lookup on a per-class level; ie. walk up the class hierarchy until we
20357 found at least one applicable method, then choose the best among them.
20358 Fixes bug #24463 and test-29.cs.
20360 2002-07-22 Martin Baulig <martin@gnome.org>
20362 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
20363 return types of the methods. The return type is not part of the
20364 signature and we must not check it to make the `new' modifier work.
20365 Fixes bug #27999, also added test-147.cs.
20366 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
20368 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
20369 on the method's return type.
20371 2002-07-21 Martin Baulig <martin@gnome.org>
20373 * assign.cs: Make this work if the rightmost source is a constant and
20374 we need to do an implicit type conversion. Also adding a few more tests
20375 to test-38.cs which should have caught this.
20377 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
20378 target in the makefile for this. The makefile.gnu is primarily intended
20379 for end-users who don't want to debug the compiler.
20381 2002-07-21 Martin Baulig <martin@gnome.org>
20383 * assign.cs: Improved the Assign class so it can now handle embedded
20384 assignments (X = Y = Z = something). As a side-effect this'll now also
20385 consume less local variables. test-38.cs now passes with MCS, added
20386 a few new test cases to that test.
20388 2002-07-20 Martin Baulig <martin@gnome.org>
20390 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
20391 instructions. Fixes bug #27977, also added test-146.cs.
20393 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20395 * cs-tokenizer.cs: fixed getHex ().
20397 2002-07-19 Martin Baulig <martin@gnome.org>
20399 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
20400 not Type.GetType() to lookup the array type. This is needed when
20401 we're constructing an array of a user-defined type.
20402 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
20403 single-dimensional arrays, but also for single-dimensial arrays of
20406 2002-07-19 Martin Baulig <martin@gnome.org>
20408 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
20409 this function is called, it's not allowed to share LocalBuilders
20410 among ILGenerators.
20412 2002-07-19 Martin Baulig <martin@gnome.org>
20414 * expression.cs (Argument.Resolve): Report an error 118 when trying
20415 to pass a type as argument.
20417 2002-07-18 Martin Baulig <martin@gnome.org>
20419 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
20420 Conv_R_Un for the signed `long' type.
20422 2002-07-15 Miguel de Icaza <miguel@ximian.com>
20424 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
20425 `expr' for the temporary result, as that will fail if we do
20426 multiple resolves on the same expression.
20428 2002-07-05 Miguel de Icaza <miguel@ximian.com>
20430 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
20431 ec.TypeContainer for looking up aliases.
20433 * class.cs (TypeContainer): Remove LookupAlias from here.
20435 * decl.cs (DeclSpace); Move here.
20437 2002-07-01 Miguel de Icaza <miguel@ximian.com>
20439 * class.cs (FindMembers): Only call filter if the constructor
20440 bulider is not null.
20442 Also handle delegates in `NestedTypes' now. Now we will perform
20443 type lookups using the standard resolution process. This also
20446 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
20447 This uses Expressions (the limited kind that can be parsed by the
20448 tree) instead of strings.
20450 * expression.cs (ComposedCast.ToString): Implement, used to flag
20451 errors since now we have to render expressions.
20453 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
20456 * ecore.cs (SimpleName.ToString): ditto.
20458 * cs-parser.jay: Instead of using strings to assemble types, use
20459 Expressions to assemble the type (using SimpleName, ComposedCast,
20460 MemberAccess). This should fix the type lookups in declarations,
20461 because we were using a different code path for this.
20463 * statement.cs (Block.Resolve): Continue processing statements
20464 even when there is an error.
20466 2002-07-17 Miguel de Icaza <miguel@ximian.com>
20468 * class.cs (Event.Define): Also remove the `remove' method from
20469 the list of pending items.
20471 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
20472 generate more compact code.
20474 2002-07-17 Martin Baulig <martin@gnome.org>
20476 * const.cs (Const.LookupConstantValue): Add support for constant
20477 `unchecked' and `checked' expressions.
20478 Also adding test case test-140.cs for this.
20480 2002-07-17 Martin Baulig <martin@gnome.org>
20482 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
20483 check whether mi.ReturnType implements the IEnumerator interface; the
20484 `==' and the IsAssignableFrom() will fail in this situation.
20486 2002-07-16 Ravi Pratap <ravi@ximian.com>
20488 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
20491 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20493 * expression.cs: fixed bug #27811.
20495 2002-07-14 Miguel de Icaza <miguel@ximian.com>
20497 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
20498 Molaro: when we are a ref, the value already contains a pointer
20499 value, do not take the address of it.
20501 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20502 * removed mb-parser.jay and mb-tokenizer.cs
20504 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
20506 * expression.cs: check against the building corlib void type.
20508 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
20510 * ecore.cs: fix for valuetype static readonly fields: when
20511 initializing them, we need their address, not the address of a copy.
20513 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
20515 * typemanager.cs: register also enum_type in corlib.
20517 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
20519 * class.cs: allow calling this (but not base) initializers in structs.
20521 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
20523 * ecore.cs: make sure we compare against the building base types
20526 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
20528 * typemanager.cs: fix TypeToCoreType() to handle void and object
20529 (corlib gets no more typerefs after this change).
20531 2002-07-12 Miguel de Icaza <miguel@ximian.com>
20533 * expression.cs (ArrayCreation.EmitArrayArguments): use
20534 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
20536 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
20537 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
20538 array indexes, the runtime actually forbids them.
20540 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
20541 for array arguments here.
20543 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
20544 instead of the default for ValueTypes.
20546 (New.DoEmit): Use IsValueType instead of
20547 IsSubclassOf (value_type)
20548 (New.DoResolve): ditto.
20549 (Invocation.EmitCall): ditto.
20551 * assign.cs (Assign): ditto.
20553 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
20554 Statements *are* currently doing part of their resolution during
20557 Expressions do always resolve during resolve, but statements are
20558 only required to propagate resolution to their children.
20560 2002-07-11 Miguel de Icaza <miguel@ximian.com>
20562 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
20564 (LoadAssembly): Do not add the dll if it is already specified
20566 (MainDriver): Add the System directory to the link path at the end,
20567 after all the other -L arguments.
20569 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
20570 wrong opcode for loading bytes and bools (ldelem.i1 instead of
20571 ldelem.u1) and using the opposite for sbytes.
20573 This fixes Digger, and we can finally run it.
20575 * driver.cs (UnixParseOption): Move the option parsing here.
20576 (CSCParseOption): Implement CSC-like parsing of options.
20578 We now support both modes of operation, the old Unix way, and the
20579 new CSC-like way. This should help those who wanted to make cross
20580 platform makefiles.
20582 The only thing broken is that /r:, /reference: and /lib: are not
20583 implemented, because I want to make those have the same semantics
20584 as the CSC compiler has, and kill once and for all the confussion
20585 around this. Will be doing this tomorrow.
20587 * statement.cs (Unsafe.Resolve): The state is checked during
20588 resolve, not emit, so we have to set the flags for IsUnsfe here.
20590 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20592 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
20593 not catch the Error_ObjectRefRequired in SimpleName (as it is
20594 possible to have a class/instance variable name that later gets
20595 deambiguated), we have to check this here.
20597 2002-07-10 Ravi Pratap <ravi@ximian.com>
20599 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
20600 make static and put into Expression.
20602 (Event.Define): Register the private field of the event with the
20603 TypeManager so that GetFieldFromEvent can get at it.
20605 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
20606 keep track of the private field associated with an event which
20609 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
20612 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
20614 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20616 * expression.cs (Binary.EmitBranchable): this routine emits the
20617 Binary expression in a branchable context. This basically means:
20618 we need to branch somewhere, not just get the value on the stack.
20620 This works together with Statement.EmitBoolExpression.
20622 * statement.cs (Statement.EmitBoolExpression): Use
20625 2002-07-09 Miguel de Icaza <miguel@ximian.com>
20627 * statement.cs (For): Reduce the number of jumps in loops.
20629 (For): Implement loop inversion for the For statement.
20631 (Break): We can be breaking out of a Try/Catch controlled section
20632 (foreach might have an implicit try/catch clause), so we need to
20633 use Leave instead of Br.
20635 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
20636 now). If the instace expression supports IMemoryLocation, we use
20637 the AddressOf method from the IMemoryLocation to extract the
20638 address instead of emitting the instance.
20640 This showed up with `This', as we were emitting the instance
20641 always (Emit) instead of the Address of This. Particularly
20642 interesting when This is a value type, as we dont want the Emit
20643 effect (which was to load the object).
20645 2002-07-08 Miguel de Icaza <miguel@ximian.com>
20647 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
20649 * statement.cs (Checked): Set the CheckedState during the resolve
20650 process too, as the ConvCast operations track the checked state on
20651 the resolve process, and not emit.
20653 * cs-parser.jay (namespace_member_declaration): Flag that we have
20654 found a declaration when we do. This is used to flag error 1529
20656 * driver.cs: Report ok when we display the help only.
20658 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
20660 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
20662 2002-07-04 Miguel de Icaza <miguel@ximian.com>
20664 * cs-tokenizer.cs (define): We also have to track locally the
20665 defines. AllDefines is just used for the Conditional Attribute,
20666 but we also need the local defines for the current source code.
20668 2002-07-03 Miguel de Icaza <miguel@ximian.com>
20670 * statement.cs (While, For, Do): These loops can exit through a
20671 Break statement, use this information to tell whether the
20672 statement is the last piece of code.
20674 (Break): Flag that we break.
20676 * codegen.cs (EmitContexts): New `Breaks' state variable.
20678 2002-07-03 Martin Baulig <martin@gnome.org>
20680 * class.cs (TypeContainer.MethodModifiersValid): Allow override
20681 modifiers in method declarations in structs. Otherwise, you won't
20682 be able to override things like Object.Equals().
20684 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20686 * class.cs (Method, Property, Indexer): Do not allow the public
20687 modifier to be used in explicit interface implementations.
20689 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
20690 override modifiers in method declarations in structs
20692 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
20694 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
20695 integer or real overflow, report an error
20697 2002-07-02 Martin Baulig <martin@gnome.org>
20699 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
20700 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
20701 to tell the runtime about our newly created System.Object and
20702 System.ValueType types.
20704 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20706 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
20707 struct instead of Ldarg/Starg.
20709 2002-07-02 Martin Baulig <martin@gnome.org>
20711 * expression.cs (Indirection.Indirection): Call
20712 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
20714 2002-07-02 Martin Baulig <martin@gnome.org>
20716 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
20717 ValueType, call TypeManager.TypeToCoreType() on it.
20718 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
20719 the OpCodes.Newarr argument.
20721 2002-07-02 Martin Baulig <martin@gnome.org>
20723 * expression.cs (Invocation.EmitCall): When compiling corlib,
20724 replace all calls to the system's System.Array type to calls to
20725 the newly created one.
20727 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
20728 System.Array methods.
20729 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
20730 from the system's System.Array type which must be replaced.
20732 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
20734 * typemanager.cs: load unverifiable_code_ctor so we can build
20735 corlib using the correct type. Avoid using GetTypeCode() with
20737 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
20738 TypeManager.object_type to allow building corlib.
20740 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
20742 * ecore.cs: handle System.Enum separately in LoadFromPtr().
20744 2002-07-01 Martin Baulig <martin@gnome.org>
20746 * class.cs: Make the last change actually work, we need to check
20747 whether `ifaces != null' to avoid a crash.
20749 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
20751 * class.cs: when we build structs without fields that implement
20752 interfaces, we need to add the interfaces separately, since there is
20753 no API to both set the size and add the interfaces at type creation
20756 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
20758 * expression.cs: the dimension arguments to the array constructors
20759 need to be converted if they are a long.
20761 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
20763 * class.cs: don't emit ldarg.0 if there is no parent constructor
20764 (fixes showstopper for corlib).
20766 2002-06-29 Martin Baulig <martin@gnome.org>
20768 MCS now compiles corlib on GNU/Linux :-)
20770 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
20771 ie. check for MethodImplOptions.InternalCall.
20773 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
20774 and TypeManager.attribute_type are null, so we must explicitly check
20775 whether parent is not null to find out whether it's an attribute type.
20776 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
20777 and SetBuilder, not only if the property is neither abstract nor external.
20778 This is necessary to set the MethodImplOptions on the accessor methods.
20779 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
20780 SetBuilder, see Property.Emit().
20782 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
20783 populate "System.Object", "System.ValueType" and "System.Attribute" since
20784 they've already been populated from BootCorlib_PopulateCoreTypes().
20786 2002-06-29 Martin Baulig <martin@gnome.org>
20788 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
20789 is the NullLiteral, we also need to make sure that target_type is not
20792 2002-06-29 Martin Baulig <martin@gnome.org>
20794 * rootcontext.cs (RootContext.ResolveCore): We must initialize
20795 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
20796 before calling BootstrapCorlib_ResolveDelegate ().
20798 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20800 * statement.cs: fixed build-breaker. All tests passed ok.
20802 2002-06-27 Martin Baulig <martin@gnome.org>
20804 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
20805 for System.Decimal when compiling corlib.
20807 2002-06-27 Martin Baulig <martin@gnome.org>
20809 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
20810 switch blocks which contain nothing but a default clause.
20812 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
20814 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
20816 2002-06-27 Martin Baulig <martin@gnome.org>
20818 * ecore.cs (PropertyExpr.PropertyExpr): Call
20819 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
20821 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
20822 is already a TypeBuilder.
20824 2002-06-27 Martin Baulig <martin@gnome.org>
20826 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
20827 `target_type == TypeManager.array_type', not IsAssignableFrom() in
20828 the "from an array-type to System.Array" case. This makes it work
20829 when compiling corlib.
20831 2002-06-27 Martin Baulig <martin@gnome.org>
20833 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
20834 non-static PropertyExpr, set its InstanceExpression. This makes
20835 the `ICollection.Count' property work in System/Array.cs.
20837 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
20839 * driver.cs: Made error handling more consistent. Errors now
20840 tracked by Report class, so many methods which used to return int
20841 now return void. Main() now prints success/failure and
20842 errors/warnings message.
20844 Renamed '--probe' compiler argument to '--expect-error'. Removed
20845 the magic number return values (123 and 124). Now, if the
20846 expected error occurs, the compiler exits with success (exit value
20847 0). If the compilation completes without seeing that particular
20848 error, the compiler exits with failure (exit value 1). The
20849 makefile in mcs/errors has been changed to handle the new behaviour.
20851 * report.cs: Made 'expected error' number a property and renamed
20852 it from 'Probe' to 'ExpectedError'.
20854 * genericparser.cs: Removed error handling support, since it is
20855 now all done by Report class.
20857 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
20858 class, so parse() no longer returns an int.
20860 * namespace.cs: Use Report.Error instead of GenericParser.error
20862 2002-06-22 Miguel de Icaza <miguel@ximian.com>
20864 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
20865 TypeContainer.AddOperator): At the front of the list put the
20866 explicit implementations, so they get resolved/defined first.
20868 2002-06-21 Miguel de Icaza <miguel@ximian.com>
20870 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
20871 interface type is implemented by this TypeContainer. Used during
20872 explicit interface implementation.
20874 (Property.Define, Indexer.Define, Method.Define): Validate that
20875 the given interface in the explicit implementation is one of the
20876 base classes for the containing type.
20878 Also if we are explicitly implementing an interface, but there is
20879 no match in the pending implementation table, report an error.
20881 (Property.Define): Only define the property if we are
20882 not explicitly implementing a property from an interface. Use the
20883 correct name also for those properties (the same CSC uses,
20884 although that is really not needed).
20886 (Property.Emit): Do not emit attributes for explicitly implemented
20887 properties, as there is no TypeBuilder.
20889 (Indexer.Emit): ditto.
20891 Hiding then means that we do not really *implement* a pending
20892 implementation, which makes code fail.
20894 2002-06-22 Martin Baulig <martin@gnome.org>
20896 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
20897 the return value of Object.GetType(). [FIXME: we need to do this whenever
20898 we get a type back from the reflection library].
20900 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
20902 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
20904 2002-06-20 Miguel de Icaza <miguel@ximian.com>
20906 * attribute.cs: Return null if we can not look up the type.
20908 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
20909 the interface types found.
20911 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
20912 interface types found.
20914 * typemanager.cs (GetInterfaces): Make this routine returns alll
20915 the interfaces and work around the lame differences between
20916 System.Type and System.Reflection.Emit.TypeBuilder in the results
20917 result for GetInterfaces.
20919 (ExpandInterfaces): Given an array of interface types, expand and
20920 eliminate repeated ocurrences of an interface. This expands in
20921 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
20924 2002-06-21 Martin Baulig <martin@gnome.org>
20926 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
20929 2002-06-21 Martin Baulig <martin@gnome.org>
20931 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
20932 and called with one of the core types, return the corresponding typebuilder for
20935 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
20938 2002-06-21 Martin Baulig <martin@gnome.org>
20940 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
20941 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
20942 (Expression.ConvertReferenceExplicit): Likewise.
20944 * expression.cs (ElementAccess.DoResolve): Likewise.
20945 (ElementAccess.DoResolveLValue): Likewise.
20947 2002-06-10 Martin Baulig <martin@gnome.org>
20949 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
20950 add the "value" parameter to the parameter list.
20952 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
20955 2002-06-19 Miguel de Icaza <miguel@ximian.com>
20957 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
20958 the argument to an int, uint, long or ulong, per the spec. Also
20959 catch negative constants in array creation.
20961 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
20963 * class.cs: do not allow the same interface to appear twice in
20964 the definition list.
20966 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
20968 * ecore.cs: don't use ldlen with System.Array.
20970 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
20972 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
20974 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
20976 * modifiers.cs: produce correct field attributes for protected
20977 internal. Easy fix so miguel can work on ther harder stuff:-)
20979 2002-06-18 Miguel de Icaza <miguel@ximian.com>
20981 * pending.cs: New file. Move the code from class.cs here.
20982 Support clearning the pending flag for all methods (when not doing
20983 explicit interface implementation).
20985 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
20987 * rootcontext.cs: added a couple more types needed to bootstrap.
20989 2002-06-17 Miguel de Icaza <miguel@ximian.com>
20991 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
20992 constructor in the type, instead of any constructor in the type
20993 hierarchy. Thanks to Paolo for finding this bug (it showed up as
20994 a bug in the Mono runtime when applying the params attribute).
20996 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20997 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
20999 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
21001 * expression.cs (Unary.ResolveOperator): Use TypeManager
21002 to resolve the type.
21004 2002-06-13 Ravi Pratap <ravi@ximian.com>
21006 * cs-parser.jay (enum_member_declaration): Pass in the attributes
21009 * enum.cs (AddEnumMember): Add support to store the attributes associated
21010 with each member too.
21012 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
21013 field builders too - this takes care of the enum member case.
21015 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
21017 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
21018 address-of operator on both value types and pointers.
21020 2002-06-10 Martin Baulig <martin@gnome.org>
21022 * interface.cs (Interface.PopulateIndexer): Add the indexer's
21023 PropertyBuilder to the `property_builders' list.
21025 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
21026 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
21027 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
21028 find any indexers which are inherited from an interface.
21030 2002-06-09 Martin Baulig <martin@gnome.org>
21032 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
21033 the same type as the constant if necessary. There's also a test-130.cs
21036 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
21038 * typemanager.cs (TypeManager.ChangeType): Previously known as
21039 Enum.ChangeEnumType().
21041 2002-06-09 Martin Baulig <martin@gnome.org>
21043 * expression.cs (Cast.TryReduce): Added support for consts.
21045 2002-06-08 Ravi Pratap <ravi@ximian.com>
21047 * class.cs (Accessor): Hold attributes information so we can pass
21050 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
21051 Modify to pass in attributes attached to the methods.
21053 (add_accessor_declaration, remove_accessor_declaration): Ditto.
21055 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
21056 to handle the Accessor kind :-)
21058 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
21060 2002-06-08 Martin Baulig <martin@gnome.org>
21062 * expression.cs (Unary.TryReduceNegative): Added support for
21065 2002-06-08 Martin Baulig <martin@gnome.org>
21067 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
21068 name can't be found in the `defined_names' - the caller will do a
21069 MemberLookup in this case and thus find methods in System.Enum
21070 such as Enum.IsDefined().
21072 2002-06-08 Martin Baulig <martin@gnome.org>
21074 * enum.cs (Enum.ChangeEnumType): This is a custom version of
21075 Convert.ChangeType() which works with TypeBuilder created types.
21076 (Enum.LookupEnumValue, Enum.Define): Use it here.
21078 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
21079 `TypeBuilder.BaseType != null' check.
21080 (TypeContainer.FindMembers): Only lookup parent members if we
21081 actually have a parent.
21082 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
21083 (ConstructorInitializer.Resolve): Likewise.
21085 * interface.cs (Interface.FindMembers): Added
21086 `TypeBuilder.BaseType != null' check.
21088 * rootcontext.cs (RootContext.ResolveCore): Added
21089 "System.Runtime.CompilerServices.IndexerNameAttribute" to
21090 classes_second_stage.
21092 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
21093 debug_type and trace_type when compiling with --nostdlib.
21095 2002-06-07 Martin Baulig <martin@gnome.org>
21097 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
21098 (AddField): Set it to true when adding a non-static field.
21099 (DefineType): Use `have_nonstatic_fields' to find out whether we
21100 have non-static fields, not `Fields != null'.
21102 2002-06-02 Miguel de Icaza <miguel@ximian.com>
21104 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
21105 dereferencing a null on the static-field code path)
21107 2002-05-30 Martin Baulig <martin@gnome.org>
21109 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
21110 to take command line arguments. Use reflection to call the new
21111 custom `Initialize' function on the symbol writer and pass it the
21112 command line arguments.
21114 * driver.cs (--debug-args): New command line argument to pass command
21115 line arguments to the symbol writer.
21117 2002-05-28 Miguel de Icaza <miguel@ximian.com>
21119 * assign.cs (DoResolve): Forgot to do the implicit conversion to
21120 the target type for indexers and properties. Thanks to Joe for
21123 2002-05-27 Miguel de Icaza <miguel@ximian.com>
21125 * typemanager.cs (MethodFlags): returns the method flags
21126 (Obsolete/ShouldIgnore) that control warning emission and whether
21127 the invocation should be made, or ignored.
21129 * expression.cs (Invocation.Emit): Remove previous hack, we should
21130 not do this on matching a base type, we should do this based on an attribute
21132 Only emit calls to System.Diagnostics.Debug and
21133 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
21134 on the command line.
21136 * rootcontext.cs: Global settings for tracing and debugging.
21138 * cs-tokenizer.cs (define): New utility function to track
21139 defines. Set the global settings for TRACE and DEBUG if found.
21141 2002-05-25 Ravi Pratap <ravi@ximian.com>
21143 * interface.cs (Populate*): Pass in the TypeContainer as well as
21144 the DeclSpace as parameters so that we can create EmitContexts and
21145 then use that to apply attributes etc.
21147 (PopulateMethod, PopulateEvent, PopulateProperty)
21148 (PopulateIndexer): Apply attributes everywhere.
21150 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
21153 (ApplyAttributes): Update accordingly.
21155 We now apply interface attributes for all members too.
21157 2002-05-26 Miguel de Icaza <miguel@ximian.com>
21159 * class.cs (Indexer.Define); Correctly check if we are explicit
21160 implementation (instead of checking the Name for a ".", we
21161 directly look up if the InterfaceType was specified).
21163 Delay the creation of the PropertyBuilder.
21165 Only create the PropertyBuilder if we are not an explicit
21166 interface implementation. This means that explicit interface
21167 implementation members do not participate in regular function
21168 lookups, and hence fixes another major ambiguity problem in
21169 overload resolution (that was the visible effect).
21171 (DefineMethod): Return whether we are doing an interface
21174 * typemanager.cs: Temporary hack until we get attributes in
21175 interfaces (Ravi is working on that) and we get IndexerName
21176 support in interfaces.
21178 * interface.cs: Register the indexers as properties.
21180 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
21181 warning, I have verified that this is a bug in the .NET runtime
21182 (JavaScript suffers of the same problem).
21184 * typemanager.cs (MemberLookup): When looking up members for
21185 interfaces, the parent of an interface is the implicit
21186 System.Object (so we succeed in searches of Object methods in an
21187 interface method invocation. Example: IEnumerable x; x.ToString
21190 2002-05-25 Miguel de Icaza <miguel@ximian.com>
21192 * class.cs (Event): Events should also register if they do
21193 implement the methods that an interface requires.
21195 * typemanager.cs (MemberLookup); use the new GetInterfaces
21198 (GetInterfaces): The code used to lookup interfaces for a type is
21199 used in more than one place, factor it here.
21201 * driver.cs: Track the errors at the bottom of the file, we kept
21204 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
21205 instance if the method we are calling is static!
21207 2002-05-24 Miguel de Icaza <miguel@ximian.com>
21209 * attribute.cs (ApplyAttributes): Make this function filter out
21210 the IndexerName attribute (as that attribute in reality is never
21211 applied) and return the string constant for the IndexerName
21214 * class.cs (TypeContainer.Emit): Validate that all the indexers
21215 have the same IndexerName attribute, and if so, set the
21216 DefaultName attribute on the class.
21218 * typemanager.cs: The return value might contain other stuff (not
21219 only methods). For instance, consider a method with an "Item"
21220 property and an Item method.
21222 * class.cs: If there is a problem with the parameter types,
21225 2002-05-24 Ravi Pratap <ravi@ximian.com>
21227 * ecore.cs (ImplicitConversionExists): Wrapper function which also
21228 looks at user defined conversion after making a call to
21229 StandardConversionExists - we need this for overload resolution.
21231 * expression.cs : Update accordingly the various method calls.
21233 This fixes 2 bugs filed against implicit user defined conversions
21235 2002-05-22 Miguel de Icaza <miguel@ximian.com>
21237 * statement.cs: Track the result of the assignment.
21239 2002-05-21 Miguel de Icaza <miguel@ximian.com>
21241 * expression.cs (MemberAccess): Improved error reporting for
21242 inaccessible members.
21244 2002-05-22 Martin Baulig <martin@gnome.org>
21246 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
21247 itself with debugging support.
21249 2002-05-22 Martin Baulig <martin@gnome.org>
21251 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
21252 Removed, this isn't needed anymore.
21254 2002-05-20 Martin Baulig <martin@gnome.org>
21256 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
21257 be underlying type for an enum.
21259 2002-05-20 Miguel de Icaza <miguel@ximian.com>
21261 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
21262 that splits out the loading of just the core types.
21264 * rootcontext.cs (ResolveCore): Split the struct resolution in
21265 two, so we can load the enumeration underlying types before any
21268 * expression.cs (Is): Bandaid until we fix properly Switch (see
21269 bug #24985 for details).
21271 * typemanager.cs (ImplementsInterface): The hashtable will contain
21272 a null if there are no interfaces implemented.
21274 2002-05-18 Miguel de Icaza <miguel@ximian.com>
21276 * cs-parser.jay (indexer_declarator): It is fine to have array
21279 2002-05-17 Miguel de Icaza <miguel@ximian.com>
21281 * typemanager.cs: (RegisterBuilder): New function used to register
21282 TypeBuilders that implement interfaces. Since
21283 TypeBuilder.GetInterfaces (as usual) does not work with lame
21285 (AddUserType): register interfaces.
21287 (ImplementsInterface): Use the builder_to_ifaces hash if we are
21288 dealing with TypeBuilder. Also, arrays are showing up as
21289 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
21290 methods can not be invoked on them!
21292 * ecore.cs (ExplicitReferenceConversionExists): Made public.
21293 (ImplicitReferenceConversionExists): Split out from
21294 StandardConversionExists.
21296 * expression.cs (As): We were only implementing one of the three
21297 cases for the as operator. We now implement them all.
21298 (Is): Implement the various other cases for Is as well.
21300 * typemanager.cs (CACHE): New define used to control if we want or
21301 not the FindMembers cache. Seems to have a negative impact on
21302 performance currently
21304 (MemberLookup): Nested types have full acess to
21305 enclosing type members
21307 Remove code that coped with instance/static returns for events, we
21308 now catch this in RealFindMembers.
21310 (RealFindMembers): only perform static lookup if the instance
21311 lookup did not return a type or an event.
21313 2002-05-17 Miguel de Icaza <miguel@ximian.com>
21315 * assign.cs (CompoundAssign): We pass more semantic information
21316 now to Compound Assignments than we did before: now we have all
21317 the information at hand, and now we resolve the target *before* we
21318 do the expression expansion, which allows the "CacheValue" method
21319 to have the effect we intended (before, a [x] += 1 would generate
21320 two differen ArrayAccess expressions from the ElementAccess,
21321 during the resolution process).
21323 (CompoundAssign.DoResolve): Resolve target and original_source here.
21325 2002-05-16 Miguel de Icaza <miguel@ximian.com>
21327 * expression.cs (ArrayAccess): dropped debugging information.
21329 * typemanager.cs: Small bug fix: I was always returning i_members,
21330 instead of one of i_members or s_members (depending on which had
21333 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
21334 method is invoked before any code generation takes place, and it
21335 is a mechanism to inform that the expression will be invoked more
21336 than once, and that the method should use temporary values to
21337 avoid having side effects
21339 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
21341 * ecore.cs (Expression.CacheTemporaries): Provide empty default
21344 * expression.cs (Indirection, ArrayAccess): Add support for
21345 CacheTemporaries in these two bad boys.
21347 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
21348 ldobj or ldind_ref.
21349 (StoreFromPtr): Handle stobj as well.
21351 * expression.cs (UnaryMutator): Share more code.
21353 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
21354 down: I was not tracking the Filter function as well, which
21355 was affecting the results of the cache.
21357 2002-05-15 Miguel de Icaza <miguel@ximian.com>
21359 * attribute.cs: Remove the hack to handle the CharSet property on
21362 2002-05-14 Miguel de Icaza <miguel@ximian.com>
21364 * attribute.cs (DoResolve): More uglyness, we now only try to
21365 resolve the attribute partially, to extract the CharSet
21366 information (only if we are a StructLayout attribute). Otherwise
21368 (GetExtraTypeInfo): Add some code to conditionally kill in the
21369 future this. I am more and more convinced that the .NET
21370 framework has special code to handle the attribute setting on
21373 * expression.cs (IsParamsMethodApplicable): Revert my previous
21374 foreach change here, it was wrong.
21376 2002-05-13 Miguel de Icaza <miguel@ximian.com>
21378 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
21379 (pp_expr): do not abort on unknown input, just return.
21380 (eval): abort if there are pending chars.
21382 * attribute.cs (Attribute.Resolve): Positional parameters are
21383 optional. Deal with that case.
21385 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
21386 the Ansi/Unicode/Auto information for the type.
21388 (TypeContainer.DefineType): instantiate the EmitContext here, as
21389 we will be using it during the type definition (to resolve
21390 attributes) and during the emit phase.
21392 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
21393 to pull type information out of the attributes
21395 (Attribute.Resolve): track the constructor builder, and allow for
21396 multiple invocations (structs and classes will use this).
21398 * ecore.cs (MemberLookupFinal): new version with all the
21399 parameters customizable.
21401 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
21402 constructors. Return if the result value is null (as the error
21403 would have been flagged already by MemberLookupFinal)
21405 Do not allow instances of abstract classes or interfaces to be
21408 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
21409 We have to compare the assembly property here when dealing with
21410 FamANDAssem and Assembly access modifiers, because we might be
21411 creating an assembly from *modules* (that means that we are not
21412 getting TypeBuilders for types defined in other modules that are
21413 part of this assembly).
21415 (Method.Emit): If the method is marked abstract and has a body,
21418 (TypeContainer.DefineMembers): If both the defined member and the
21419 parent name match are methods, then do not emit any warnings: let
21420 the Method.Define routine take care of flagging warnings. But if
21421 there is a mismatch (method overrides something else, or method is
21422 overriwritten by something, then emit warning).
21424 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
21425 set to null, this means `do not check for the return type on the
21428 (Method.Define): set the return type for the method signature to
21429 null, so that we get methods with the same name and parameters and
21430 different return types. This is used to flag warning 114 (you are
21431 hiding a method, and you probably want to use the new/override
21434 * typemanager.cs (MemberLookup): Implemented proper access
21435 control, closing a long standing set of bug reports. The problem
21436 was that the Framework only has two bits: Public and NonPublic,
21437 and NonPublic includes private and protected methods, but we need
21438 to enforce the FamANDAssem, FamOrAssem and Family.
21440 2002-05-11 Miguel de Icaza <miguel@ximian.com>
21442 * statement.cs (GotoCase): Return true: Ammounts to giving up
21443 knowledge on whether we return or not, and letting the other case
21444 be responsible for it.
21446 2002-05-10 Miguel de Icaza <miguel@ximian.com>
21448 * driver.cs: Do not load directories for each file processed, only
21449 do it if there is a pattern.
21451 * ecore.cs: Report readonly assigns here as well, as we might have
21452 been resolved only by MemberAccess.
21454 (SimpleName.SimpleNameResolve): Also be useful for LValue
21455 resolution. We need this to propagate assign to local readonly variables
21457 * typemanager.cs: Use a ptrhashtable for the criteria, because we
21458 do not want to reuse potential criteria memory.
21460 * class.cs (MyEventBuilder): Set reflected_type;
21462 * ecore.cs (Constantify): Added support for constifying bools.
21464 (RootContext.LookupType): Added a cache for values looked up in
21465 the declaration space.
21467 * typemanager.cs (FindMembers): Now is a front-end to
21468 RealFindMembers, and provides a two-level hashtable-based cache to
21471 15% performance improvement: from 22.5 to 19.2 seconds.
21473 * expression.cs (IsParamsMethodApplicable): use foreach.
21474 (Invocation.DoResolve): ditto.
21475 (New.DoResolve): ditto.
21476 (ArrayCreation.DoResolve): ditto.
21478 * ecore.cs (FindMostEncompassingType): use foreach.
21480 * delegate.cs (NewDelegate.DoResolve): Use foreach
21482 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
21483 (RemoveMethods): use foreach.
21485 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
21486 nested foreach statements instead of for, and also break out of
21487 the inner loop once a match is found.
21489 (Invocation.OverloadResolve): Use foreach, simplify the code.
21491 2002-05-08 Miguel de Icaza <miguel@ximian.com>
21493 * cfold.cs (BinaryFold): During an enumeration evaluation context,
21494 we actually unwrap the expression to allow for extra information
21497 * expression.cs: Use Shr_Un on unsigned operations.
21499 2002-05-08 Ravi Pratap <ravi@ximian.com>
21501 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
21502 applicable operators was not being considered correctly. This closes
21503 the bug Miguel reported.
21505 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
21507 * attribute.cs: check that the type derives from System.Attribute
21508 and report the correct error in that case (moved the duplicate code to
21509 its own method, too).
21511 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
21513 * attribute.cs: lookup attribute type name as the spec says: first the
21514 bare attribute name and then name + "Attribute" (nant compiles with
21515 mcs after this fix).
21517 2002-05-07 Miguel de Icaza <miguel@ximian.com>
21519 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
21520 Because of the way we parse things, we should try to see if a
21521 UIntConstant can fit in an integer.
21523 2002-05-07 Ravi Pratap <ravi@ximian.com>
21525 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
21526 when we are in an explicit context.
21528 (ConvertReferenceExplicit): When converting from Iface type S to Class
21529 T make sure the rules are implemented as an OR.
21531 * parameter.cs (ParameterType): Make it a property for now although the
21532 purpose really isn't anything immediate.
21534 * expression.cs (Is*Applicable): Do better checking on the parameter type
21535 of a ref/out parameter. The ones from the system assemblies are already
21536 marked with the correct type so we don't need to do any correction.
21538 * ecore.cs (StandardConversionExists): Conversion from Interface types to
21539 the object type is standard too so include that.
21541 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21543 * ecore.cs (StandardConversionExists): Augment with missing code:
21544 deal with IntConstant, LongConstants and Enumerations.
21546 * assign.cs: Report the error, instead of failing silently
21548 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
21549 typecontainer that they are declared, because the
21550 typecontainer/namespace will have the list of using clauses that
21551 need to be applied.
21553 Assembly Attributes were escaping the normal registration
21556 (EmitCode): Apply attributes within an EmitContext that represents
21557 the container they were declared on.
21559 * cs-parser.jay: Track bases for structs. How did I get this wrong?
21561 2002-05-06 Ravi Pratap <ravi@ximian.com>
21563 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
21564 Revamp completely - make much cleaner as we now operate only
21567 (FindMostSpecificSource, FindMostSpecificTarget): New methods
21568 to implement the logic detailed in the spec more correctly.
21570 (UserDefinedConversion): Update accordingly.
21572 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21574 * statement.cs: Return flow analysis information up.
21576 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
21579 (token): Do not consume an extra character before calling
21582 2002-05-06 Piers Haken <piersh@friskit.com>
21584 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
21586 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21588 * class.cs (Constructor.Emit): Set the IsStatic flag in the
21589 EmitContext during the instance constructor initializer
21590 resolution, to stop access to instance variables.
21592 This is mandated by the spec, last paragraph of the `constructor
21593 initializers' section.
21595 2002-05-05 Miguel de Icaza <miguel@ximian.com>
21597 * cs-parser.jay, class.cs (Accessor): new class used to represent
21598 an accessor (get or set). In the past we used `null' to represent
21599 a missing accessor. But this is ambiguous because there was no
21600 way to tell in abstract indexers/properties if one of them was
21603 Now there is a way of addressing that.
21605 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
21606 instead of FindMembers.
21608 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
21609 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
21611 * attribute.cs: Treat indexers and properties as the same in terms
21612 of applying attributes
21614 * ecore.cs (FindMostEncompassedType): Use statically initialized
21615 EmptyExpressions()s like we do elsewhere to avoid creating useless
21616 objects (and we take this out of the tight loop).
21618 (GetConversionOperators): Move the code to extract the actual
21619 operators to a separate routine to clean things up.
21621 2002-05-04 Miguel de Icaza <miguel@ximian.com>
21623 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
21624 events are always registered FieldBuilders.
21626 * class.cs (FieldBase): New class shared by Fields
21628 * delegate.cs: If we are a toplevel delegate, use our full name.
21629 If we are a nested delegate, then only use our tail name.
21631 2002-05-02 Ravi Pratap <ravi@ximian.com>
21633 * expression.cs (IsApplicable): Ensure that we add the "&" to
21634 ref/out types before comparing it with the type of the argument.
21636 (IsParamsMethodApplicable): Ditto.
21638 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
21641 * delegate.cs : Handle the case when we have more than one applicable
21642 method. Flag an error only when we finish checking all.
21644 2002-05-02 Miguel de Icaza <miguel@ximian.com>
21646 * expression.cs: Add support for boolean static initializers.
21648 2002-05-01 Miguel de Icaza <miguel@ximian.com>
21650 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
21652 * parameter.cs (ComputeParameterTypes,
21653 ComputeAndDefineParameterTypes): Better error handling: now we
21654 clear the `types' cache if we fail during any of the type lookups.
21655 We also return the status code correctly to our caller
21657 * delegate.cs: If we fail to define a delegate, abort the extra
21660 * expression.cs (Binary.ResolveOperator): for
21661 operator==(object,object) and operator !=(object, object) we also
21662 have to verify that there is an implicit conversion from one to
21665 (ArrayAccess.DoResolve): Array Access can operate on
21668 2002-04-30 Miguel de Icaza <miguel@ximian.com>
21670 * assign.cs (CompoundAssign): A new class used as a "flag" that
21671 the assignment actually is happening as part of a compound
21672 assignment operator.
21674 During compound assignment, a few new rules exist to enable things
21681 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
21682 to the type of x) if y is implicitly convertible to the type of x,
21683 and the operator is a builtin operator and the return type of the
21684 operator is explicitly convertible to the type of x.
21686 * rootcontext.cs: Reset warning level to 2. 4 catches various
21687 "interesting" features in mcs, we must clean this up at some
21688 point, but currently am trying to kill other bugs ;-)
21690 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
21691 in container classes as well.
21693 * expression.cs (Binary.ResolveOperator): Handle string case
21694 before anything else (as operator overloading does emit an error
21695 before doing anything else).
21697 This code could go away when we move to a table driven model, but
21698 i could not come up with a good plan last night.
21700 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
21702 * typemanager.cs (CSharpName): reimplementation using regex.
21703 * class.cs: added null check for fields in Emit
21704 * rootcontext.cs: set warninglevel to 4
21706 2002-04-29 Miguel de Icaza <miguel@ximian.com>
21708 * typemanager.cs (CSharpName): reimplemented with Lupus
21711 2002-04-28 Miguel de Icaza <miguel@ximian.com>
21713 * statement.cs (If): correclty implement Resolve, because we were
21714 not catching sem errors in there. The same process is needed
21716 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
21719 (Statement.Warning_DeadCodeFound): Factorize code.
21720 (While): Report dead code here too.
21722 (Statement): Added Resolve virtual method to allow
21723 for resolution split from the emit code.
21725 2002-04-26 Miguel de Icaza <miguel@ximian.com>
21727 * statement.cs (EmitBoolExpression): No longer try to resolve the
21729 (MakeBoolean): New utility function that resolve, implicitly
21730 converts to boolean and tags the expression.
21733 (If, Do): Implement dead code elimination.
21734 (While): Implement loop inversion
21736 (Do, While, For, If): Resolve the expression prior to calling our
21739 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
21742 - added method Report28 (warning: program has more than one entry point)
21743 - added method IsEntryPoint, implements paragraph 10.1 of the spec
21744 - modified method Method.Define, the part at the end of the method
21746 * rootcontext.cs: added static public Location EntryPointLocation;
21748 * ../errors/cs0028.cs : Add test case for the above warning.
21751 - modified method CSharpName to allow arrays of primitive type to
21752 be printed nicely (e.g. instead of System.Int32[][] it now prints
21754 - added method CSharpSignature: returns the signature of a method
21755 in string format to be used in reporting errors, warnings, etc.
21757 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
21760 2002-04-26 Ravi Pratap <ravi@ximian.com>
21762 * delegate.cs (Define): Fix extremely silly bug where I was
21763 setting the type of the 'object' parameter of the BeginInvoke
21764 method to System.IAsyncResult instead of System.Object ;-)
21766 2002-04-26 Miguel de Icaza <miguel@ximian.com>
21768 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
21771 (Constructor.Emit): return if we fail to initialize the
21772 constructor. Another door closed!
21774 * expression.cs (New.DoResolve): Improve error message (from -6 to
21775 1501). Use DeclaredOnly lookup to find the exact constructor.
21777 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
21778 loop. This is useful.
21780 * cs-parser.jay: Adjust the default parameters so that destructors
21781 have the proper signature.
21783 2002-04-26 Martin Baulig <martin@gnome.org>
21785 * driver.cs (LoadAssembly): If `assembly' contains any characters
21786 which are only valid in path names and not in assembly names
21787 (currently slash, backslash and point), use Assembly.LoadFrom ()
21788 instead of Assembly.Load () on the `assembly' (before iteration
21789 over the link_paths).
21791 2002-04-26 Martin Baulig <martin@gnome.org>
21793 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
21795 2002-04-25 Miguel de Icaza <miguel@ximian.com>
21797 * class.cs (Property): use the new typemanager.MemberLookup
21799 (TypeContainer.MemberLookup): Implement using the
21800 TypeManager.MemberLookup now.
21802 * typemanager.cs: Make MemberLookup a function of the TypeManager,
21803 and return MemberInfos, so that these can be used without an
21804 EmitContext (what we had before).
21806 2002-04-24 Miguel de Icaza <miguel@ximian.com>
21808 * expression.cs: Fix the case where the argument to params if the
21809 type of the params. I omitted handling this before. Fixed
21811 2002-04-22 Miguel de Icaza <miguel@ximian.com>
21813 * driver.cs: Call BootCorlib_PopulateCoreType
21815 * class.cs (Property.CheckBase): Check for properties only, not
21818 * interface.cs: Temporary hack: try/catch around the
21819 CustomAttributeBuilder, because I am getting an exception that I
21822 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
21823 types whose definitions are required to be there (attributes are
21824 defined before standard types).
21826 Compute definitions as we boot the various types, as they are used
21827 immediately (value_type class will need object_type, but if we do
21828 not initialize object_type, we will pass a null, which will let
21829 the runtime pick the System.Object from the existing corlib, which
21830 is not what we want).
21832 2002-04-22 Patrik Torstensson <totte@labs2.com>
21834 * cs-tokenizer.cs: fixed a number of trim() issues.
21836 2002-04-22 Ravi Pratap <ravi@ximian.com>
21838 * expression.cs (Argument.Type): Ensure that we return the correct
21839 type when we have out or ref parameters [in which case we
21842 2002-04-22 Miguel de Icaza <miguel@ximian.com>
21844 * class.cs (Property, Indexer): Allow extern modifier in there.
21846 * typemanager.cs (InitBaseTypes): Initializes object_type and
21847 value_type, since those will be used early on during the bootstrap
21848 process to compile corlib.
21850 (InitCoreTypes): Move code from here to InitBaseTypes.
21852 2002-04-21 Miguel de Icaza <miguel@ximian.com>
21854 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
21855 single-dimension arrays as using the ldlen opcode.
21857 Daniel Lewis discovered this optimization.
21859 * typemanager.cs: Add signature for System.Array::get_Length
21861 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21863 * statement.cs: report the error when the foreach does not apply to an
21864 array nor a collection.
21866 2002-04-19 Miguel de Icaza <miguel@ximian.com>
21868 * expression.cs: Add implicit conversions to the operator ~.
21870 * constant.cs (DecimalConstant.Emit): Emit decimal value.
21872 * typemanager.cs: Locate the decimal constructor.
21874 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21876 * attribute.cs: use the new property of TypeOf.
21877 * expression.cs: added 'get' property around typearg.
21879 These changes fix a build breaker reported by NickD. Is this the
21880 correct way to fix? If not, please, revert my changes and make it
21883 2002-04-17 Miguel de Icaza <miguel@ximian.com>
21885 * attribute.cs: Add support for typeof in attribute invocations.
21886 I am not sure that this is right though.
21888 2002-04-14 Duncan Mak <duncan@ximian.com>
21890 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
21891 Binary.Operator.Division case.
21893 2002-04-13 Ravi Pratap <ravi@ximian.com>
21895 * class.cs (DefineType): Ensure that we do a proper check on
21896 attribute types and also register it with the TypeManager.
21898 (TypeContainer.Targets): The default for attribute types is
21899 AttributeTargets.All.
21901 * attribute.cs (ApplyAttributes): Registering the attribute type
21902 is done elsewhere, not when we discover we have a Usage attribute.
21904 2002-04-12 Ravi Pratap <ravi@ximian.com>
21906 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
21907 and get rid of is_delegate parameter.
21909 * everywhere : update.
21911 2002-04-12 Ravi Pratap <ravi@ximian.com>
21913 * cs-parser.jay (compilation_unit): Revamp completely to use
21914 some new ideas that I got from Rhys' grammar to solve the problems
21915 with assembly level attributes.
21917 (outer_declaration): New grammar production.
21919 (attribute_sections): Add.
21921 (opt_attributes): Base on attribute_sections
21923 (namespace_declaration): Allow opt_attributes to tackle the case
21924 when we have assembly level attributes - we are clever in this
21927 * attribute.cs (ApplyAttributes): Do not worry about assembly
21928 attributes in the non-global context.
21930 * rootcontext.cs (AddGlobalAttributes): Go back to using this
21931 instead of SetGlobalAttributes.
21933 * class.cs, rootcontext.cs : Ensure we define and generate
21934 attribute types before anything else.
21936 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
21937 and flag the new error -20 for the case when the attribute type
21938 does not have valid targets specified. csc does not catch this.
21940 * ../errors/errors.txt : update for error # -20
21942 2002-04-11 Ravi Pratap <ravi@ximian.com>
21944 * support.cs (InternalParameters.ParameterModifier): Do some null
21945 checking and return sane values.
21947 * class.cs (Method.Define): If we are a PInvoke method, ensure
21948 that we are static and extern. Report error # 601
21950 * ../errors/cs0601.cs : Add test case for the above error.
21952 2002-04-07 Ravi Pratap <ravi@ximian.com>
21954 * rootcontext.cs (attribute_types): We need to keep type of
21955 all attribute types separately and emit code for them first.
21957 (RegisterAttribute) : Implement.
21959 * class.cs (DefineType): Check if the current Type is a custom
21960 attribute type and register it accordingly.
21962 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
21963 adding the first attribute twice and rename to
21965 (SetGlobalAttributes): this.
21967 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
21970 * attribute.cs (ApplyAttributes): Take an additional argument telling us
21971 if we are processing global arguments. Hmm, I am unsure of this.
21973 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21975 * expression.cs: added static array of strings to avoid calling
21976 Enum.ToString () for Operator in Binary. Significant recover of
21979 2002-04-10 Miguel de Icaza <miguel@ximian.com>
21981 * class.cs (FindMembers): Allow the Builders of the various
21982 members to be null. If they are skip them. This only happens
21983 during the PInvoke declaration.
21985 2002-04-09 Miguel de Icaza <miguel@ximian.com>
21987 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
21988 failure, so we do not keep going afterwards.
21990 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
21991 wanted to pass `false' as the `is_delegate' argument. If this is
21992 the case, why not use delegate_type == null to mean `is_delegate =
21993 false' and anything else as is_delegate = true.
21995 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
21997 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
21998 code for the section, not the beginning of the tests.
22000 2002-04-08 Miguel de Icaza <miguel@ximian.com>
22002 * cfold.cs: Handle operator + (Enum x, Underlying x)
22004 * expression.cs (Binary): same. Warn about errors where we have
22005 Enum/Enum in operator + as well.
22007 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
22010 - added support for switch(bool)
22011 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
22012 - add TableSwitchEmit() to handle table-based switch statements
22014 2002-04-05 Ravi Pratap <ravi@ximian.com>
22016 * expression.cs (Invocation.OverloadResolve): Factor out code which
22017 does parameter compatibility checking with arguments so that we can
22018 re-use the code even from Delegate.VerifyApplicability
22020 (VerifyArgumentsCompat): Move above code here.
22022 * delegate.cs (VerifyApplicability): Get rid of duplicate code
22023 and instead make a call to the above method.
22025 2002-03-31 Ravi Pratap <ravi@ximian.com>
22027 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
22028 We use it to keep track of classes which are attribute types.
22030 2002-04-02 Miguel de Icaza <miguel@ximian.com>
22032 * delegate.cs (Delegate.Define): Correctly define the types in the
22033 presence of fixed and array parameters.
22035 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
22038 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
22039 include NonPublic after the first iteration.
22041 * class.cs (Indexer.CheckBase): Only check if both parents are
22044 * cs-parser.jay (accessor_body): If empty, set to null.
22046 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
22047 same code path here to resolve constants names that we did have in
22048 MemberAccess.DoResolve. There is too much code duplicated here.
22050 2002-04-01 Miguel de Icaza <miguel@ximian.com>
22052 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
22054 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
22057 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
22058 tokens, numbers and strings.
22060 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
22063 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
22064 asyncronous parameters and the regular parameters.
22066 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
22067 specify the target directory.
22069 * expression.cs: (This.DoResolve): Simplify
22070 (As.Emit): Optimize, do not generate IsInst if the expression is
22071 always of the given type.
22073 (Is.DoResolve): Bug fix, we were reporting both always/never for
22076 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
22077 creating too many unnecessary arrays.
22079 2002-03-31 Miguel de Icaza <miguel@ximian.com>
22081 * class.cs (EmitFieldInitializer): Use Assign expression to assign
22082 fields instead of rolling our own initializer. Takes care of all
22083 implicit conversions, and drops unnecessary static checks/argument.
22085 2002-03-31 Dick Porter <dick@ximian.com>
22087 * driver.cs: use the GetDirectories() return values properly, and
22088 use "/" as path separator.
22090 2002-03-30 Miguel de Icaza <miguel@ximian.com>
22092 * expression.cs (Unary): Optimize - - expr into expr.
22093 (Binary): Optimize a + (-b) into a -b.
22095 * codegen.cs (CodeGen): Made all methods static.
22097 2002-03-29 Miguel de Icaza <miguel@ximian.com>
22101 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
22102 TypeBuilder property.
22104 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
22107 * tree.cs: Removed the various RecordXXXX, and replaced with a
22108 single RecordDecl. Removed all the accessor methods, and just
22109 left a single access point Type
22111 * enum.cs: Rename DefineEnum to DefineType.
22113 * decl.cs: New abstract method `DefineType' used to unify the
22114 Defines for Enumerations, Interfaces, TypeContainers and
22117 (FindType): Moved LookupInterfaceOrClass here. Moved the
22118 LookupBaseClasses method that used to live in class.cs and
22119 interface.cs here, and renamed to FindType.
22121 * delegate.cs: Implement DefineType. Take advantage of the
22122 refactored pattern for locating the parent builder without taking
22123 the parent_builder argument (which we know does not work if we are
22124 nested, and triggering a toplevel definition).
22126 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22128 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
22129 accessibility of a member has changed during override and report
22132 * class.cs (Method.Define, Property.Define): Only complain on
22133 overrides if the method is private, any other accessibility is
22134 fine (and since we just checked the permission is the same, we are
22137 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
22138 and elif are processed always. The other pre-processing
22139 directives are only processed if we are "taking" the path
22141 2002-03-29 Martin Baulig <martin@gnome.org>
22143 * class.cs (Method.Emit): Only emit symbolic debugging info if the
22144 current location is not Null.
22146 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
22147 a separate method so we can profile it.
22149 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
22150 `span.Seconds' are just seconds, but no minutes or hours.
22151 (MainDriver): Profile the CodeGen.SaveSymbols calls.
22153 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22155 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
22156 Remove the gratuitous set of Final:
22158 // If an interface implementation, then we can set Final.
22159 if (((flags & MethodAttributes.Abstract) == 0) &&
22160 implementing.DeclaringType.IsInterface)
22161 flags |= MethodAttributes.Final;
22163 I do not know what I was smoking when I used that.
22166 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
22167 step into fixing the name resolution issues for delegates and
22168 unifying the toplevel name resolution.
22170 2002-03-28 Martin Baulig <martin@gnome.org>
22172 * class.cs (Method.Emit): If we have a symbol writer, call its
22173 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
22174 tell it about the current method.
22176 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
22177 writer that we're going to emit the first byte of IL code for a new
22178 statement (a new source line).
22179 (EmitContext.EmitTopBlock): If we have a symbol writer, call
22180 EmitContext.Mark() before emitting any code.
22182 * location.cs (SymbolDocument): Return null when we're Null.
22184 * statement.cs (Statement): Moved the `Location loc' variable here.
22185 (Statement.EmitBoolExpression): If we have a symbol writer, call
22186 ec.Mark() before emitting any code to tell it that we're at the
22187 beginning of a new statement.
22188 (StatementExpression): Added `Location' argument to the constructor.
22189 (Block): Added public readonly variable `StartLocation' and public
22190 variable `EndLocation'. The latter is to be set using SetEndLocation().
22191 (Block): Added constructor which takes a start and end location.
22192 (Block.SetEndLocation): New method. This sets the end location.
22193 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
22194 local variables we create.
22195 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
22196 each statement and do also mark the begin and end of the block.
22198 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
22199 tell it the current lexer.Location, use Location.Null for the end of the
22201 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
22202 current block, set its end location using SetEndLocation().
22203 (statement_expression): StatementExpression constructor now takes the
22204 lexer.Location as additional argument.
22205 (for_statement, declare_local_variables): Likewise.
22206 (declare_local_variables): When creating a new implicit block, use the
22207 new Block constructor and pass it the lexer.Location.
22209 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22211 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
22212 members also on the parent interfaces recursively.
22214 2002-03-27 Miguel de Icaza <miguel@ximian.com>
22216 * report.cs: Use new formats, since Gonzalo finished the missing
22219 * expression.cs (Binary.ResolveOperator): added missing operator|
22220 operator& and operator^ for bool/bool.
22222 * cs-parser.jay: CheckDef now takes a Location argument that is
22223 used to report errors more precisly (instead of reporting the end
22224 of a definition, we try to track something which is a lot closer
22225 to the source of the problem).
22227 * cs-tokenizer.cs: Track global token use, so we can properly flag
22228 the use of #define/#undef after the first token has been seen.
22230 Also, rename the reportXXXX to Error_DescriptiveName
22232 * decl.cs (DeclSpace.IsTopLevel): Move property here from
22233 TypeContainer, so that Enum and Interface can use this too.
22235 * class.cs (TypeContainer.LookupInterfaceOrClass,
22236 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
22237 `builder' argument. Typically this was used to pass the parent
22238 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
22241 The problem is that a nested class could trigger the definition of
22242 a toplevel class, and the builder would be obviously wrong in that
22245 So we drop this argument, and we compute dynamically the
22246 TypeBuilder/ModuleBuilder (the correct information was available
22247 to us anyways from DeclSpace.Parent)
22249 * interface.cs (Interface.DefineInterface): Drop builder
22250 parameter cleanup like class.cs
22252 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
22255 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
22258 (Try.Emit): Propagate the returns value from the statement.
22260 (Return.Emit): Even if we are leavning
22262 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
22264 * modifiers.cs: Fix the computation of MethodAttributes flags.
22266 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
22268 * driver.cs: allow compilation of files that start with '/'.
22269 Add a default case when checking the argument of --target.
22271 2002-03-25 Miguel de Icaza <miguel@ximian.com>
22273 * interface.cs: Implement the same search algorithm for types in
22274 the interface code.
22276 * delegate.cs: Do not allow multiple definition.
22278 * Recovered ChangeLog that got accidentally amputated
22280 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
22282 * rootcontext.cs: Load manually enum to allow core classes to
22283 contain enumerations.
22285 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
22286 Update to new static methods in TypeManager.
22288 * typemanager.cs (GetMethod, GetConstructor): Use our
22289 implementation of FindMembers to find the members, since during
22290 corlib compilation, the types are TypeBuilders and GetMethod and
22291 GetConstructor do not work.
22293 Make all methods in TypeManager static.
22295 (InitCodeHelpers): Split the functionality from
22296 the InitCodeTypes function.
22298 * driver.cs: Call InitCodeHelpers after we have populated the
22301 * cs-parser.jay (delegate_declaration): we did not used to compute
22302 the delegate name correctly for void delegates.
22304 2002-03-24 Miguel de Icaza <miguel@ximian.com>
22306 * rootcontext.cs (RootContext): Init the interface_resolve_order
22307 and type_container_resolve_order always.
22309 (ResolveCore, BootstrapCorlib_ResolveClass,
22310 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
22311 compiler when compiling with --nostdlib
22313 * class.cs (TypeContainer.DefineType): Check that our parent is
22314 not null. This test is most important when we are bootstraping
22317 * codegen.cs: Split out the symbol writing code.
22319 2002-03-25 Martin Baulig <martin@gnome.org>
22321 * driver.cs (-g): Made -g an alias for --debug.
22323 2002-03-24 Martin Baulig <martin@gnome.org>
22325 * codegen.cs (SymbolWriter): New public variable. Returns the
22326 current symbol writer.
22327 (CodeGen): Added `bool want_debugging_support' argument to the
22328 constructor. If true, tell the ModuleBuild that we want debugging
22329 support and ask it for the ISymbolWriter.
22330 (Save): If we have a symbol writer, call it's Close() method after
22331 saving the assembly.
22333 * driver.c (--debug): New command line argument to create a
22334 debugger information file.
22336 * location.cs (SymbolDocument): New public property. Returns an
22337 ISymbolDocumentWriter object for the current source file or null
22338 if we don't have a symbol writer.
22340 2002-03-21 Miguel de Icaza <miguel@ximian.com>
22342 * driver.cs (LoadAssembly): Correctly return when all the paths
22343 have been tried and not before.
22345 * statement.cs (Switch.Emit): return the actual coverage for this
22346 statement (returns/not-returns)
22348 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
22349 switch of the statement if we are the last switch section. That
22350 kills two problems: try/catch problems (we used to emit an empty
22351 nop at the end) and switch statements where all branches would
22354 2002-03-19 Miguel de Icaza <miguel@ximian.com>
22356 * driver.cs: Add default assemblies (the equivalent to the
22357 Microsoft CSC.RSP file)
22359 * cs-tokenizer.cs: When updating `cols and setting it to zero,
22360 also update tokens_seen and set it to false.
22362 * driver.cs: Implement --recurse for Mike.
22364 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
22365 correctly splitting out the paths.
22367 2002-03-18 Miguel de Icaza <miguel@ximian.com>
22369 * interface.cs (Interface.PopulateProperty): Instead of using
22370 `parent' as the declaration space for the set parameters, use
22373 * support.cs (InternalParameters): InternalParameters constructor
22374 takes a DeclSpace instead of a TypeContainer.
22376 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
22377 types are being initialized, load the address of it before calling
22380 (New): Provide a mechanism to disable the generation of local
22381 value type temporaries when the caller will be providing us with
22382 an address to store it.
22384 (ArrayCreation.EmitDynamicInitializers): Use it.
22386 2002-03-17 Miguel de Icaza <miguel@ximian.com>
22388 * expression.cs (Invocation.EmitArguments): Only probe for array
22389 property if there is more than one argument. Sorry about that.
22391 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
22392 empty param arrays.
22394 * class.cs (Method.LabelParameters): Fix incorrect code path that
22395 prevented the `ParamArrayAttribute' from being applied to the
22398 2002-03-16 Miguel de Icaza <miguel@ximian.com>
22400 * support.cs (ReflectionParameters): Correctly compute whether the
22401 last argument is a params array. Fixes the problem with
22404 * typemanager.cs: Make the assemblies array always be non-null
22405 (empty, but non-null)
22407 * tree.cs (RecordDecl): New function that abstracts the recording
22408 of names. This reports error 101, and provides a pointer to the
22409 previous declaration. Fixes a crash in the compiler.
22411 * cs-parser.jay (constructor_declaration): Update to new grammar,
22412 and provide a constructor_body that can be empty.
22414 2002-03-15 Miguel de Icaza <miguel@ximian.com>
22416 * driver.cs: Add support for --resources.
22418 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
22419 Make all types for the various array helper methods be integer.
22421 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
22422 CheckState to ConvCast.
22424 (ConvCast): Now it takes a `checked' state argument, to avoid
22425 depending on the emit context for the conversion, and just using
22426 the resolve time setting.
22428 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
22429 instead of Invocation.EmitArguments. We do not emit the original
22430 arguments, instead we emit those which have been converted to
22431 unsigned int expressions.
22433 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
22435 * codegen.cs: ditto.
22437 * expression.cs (LocalVariableReference): Drop the use of the
22438 Store function that depended on the variable index.
22440 * statement.cs (VariableInfo): Drop the `Idx' property from this
22441 class, as this is not taking into account the indexes for
22442 temporaries tat we generate during the execution, getting the
22445 * class.cs: First emit class initializers, then call the parent
22448 * expression.cs (Binary): Fix opcode emision.
22449 (UnaryMutator.EmitCode): Support checked code generation
22451 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
22452 matches for events for both the Static and Instance scans,
22453 pointing to the same element. Fix that.
22455 2002-03-14 Miguel de Icaza <miguel@ximian.com>
22457 * rootcontext.cs (ResolveTree): Always set the
22458 interface_resolve_order, because nested interfaces will be calling
22461 * class.cs (GetInterfaceOrClass): Track the same resolution
22462 process used by TypeManager.LookupType. This fixes the nested
22463 type lookups in class declarations (separate path from
22466 (TypeContainer.DefineType): Also define nested interfaces.
22467 (TypeContainer.RegisterOrder): New public function used to
22468 register the order in which child interfaces need to be closed.
22470 Nested interfaces need to be closed after their parents have been
22473 * interface.cs (InterfaceAttr): Put all the logic for computing
22474 the interface attribute here.
22476 (DefineInterface): Register our interface order with the
22477 RootContext or with the TypeContainer depending on the case.
22479 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22481 * cs-parser.jay: rework foreach statement to work with the new
22482 changes to the policy on SimpleNames.
22484 * report.cs: support Stacktrace on warnings as well.
22486 * makefile: drop --unsafe and /unsafe from the compile.
22488 2002-03-13 Ravi Pratap <ravi@ximian.com>
22490 * ecore.cs (StandardConversionExists): Modify to take an Expression
22491 as the first parameter. Ensure we do null -> reference type conversion
22494 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
22495 temporary Expression objects.
22497 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
22499 * interface.cs: workaround bug in method overloading resolution
22500 (there is already a bugzilla bug for it).
22502 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22504 We could also solve this problem by having a separate path for
22505 performing type lookups, instead of DoResolve, we could have a
22506 ResolveType entry point, and only participating pieces of the
22507 production (simplename, deref, array) would implement this.
22509 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
22510 signal SimpleName to only resolve type names and not attempt to
22511 resolve anything else.
22513 * expression.cs (Cast): Set the flag.
22515 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
22517 * class.cs: Only report 108 if there is no `new' modifier.
22519 * cs-parser.jay: rework foreach statement to work with the new
22520 changes to the policy on SimpleNames.
22522 * report.cs: support Stacktrace on warnings as well.
22524 * makefile: drop --unsafe and /unsafe from the compile.
22526 2002-03-11 Miguel de Icaza <miguel@ximian.com>
22528 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22529 lookups here, instead of doing that at parse time. This means
22530 that our grammar will not introduce `LocalVariableReferences' as
22531 expressions at this point. That solves the problem of code like
22535 static void Main ()
22539 This is only half the fix. The full fix requires parameters to
22540 also be handled in this way.
22542 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
22543 makes the use more obvious of the DeclSpace. The
22544 ec.TypeContainer.TypeBuilder is now only used to pull the
22545 TypeBuilder for it.
22547 My theory is that I can get rid of the TypeBuilder completely from
22548 the EmitContext, and have typecasts where it is used (from
22549 DeclSpace to where it matters).
22551 The only pending problem is that the code that implements Aliases
22552 is on TypeContainer, and probably should go in DeclSpace.
22554 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22555 lookups here, instead of doing that at parse time. This means
22556 that our grammar will not introduce `LocalVariableReferences' as
22557 expressions at this point. That solves the problem of code like
22561 static void Main ()
22565 This is only half the fix. The full fix requires parameters to
22566 also be handled in this way.
22568 * class.cs (Property.DefineMethod): When implementing an interface
22569 method, set newslot, when implementing an abstract method, do not
22570 set the flag (before we tried never setting it, or always setting
22571 it, which is the difference).
22572 (Indexer.DefineMethod): same.
22573 (Method.DefineMethod): same.
22575 * ecore.cs: Only set the status used flag if we get back a Field.
22577 * attribute.cs: Temporary hack, so Paolo can keep working.
22579 2002-03-08 Ravi Pratap <ravi@ximian.com>
22581 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
22582 the unmanaged type in the case we have a MarshalAs attribute.
22584 (Resolve): Handle the case when we are parsing the special MarshalAs
22585 attribute [we need to store the unmanaged type to use later]
22587 * typemanager.cs (marshal_as_attr_type): Built in type for the
22588 MarshalAs Attribute.
22590 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
22591 on parameters and accordingly set the marshalling info.
22593 2002-03-09 Miguel de Icaza <miguel@ximian.com>
22595 * class.cs: Optimizing slightly by removing redundant code after
22596 we switched to the `NoTypes' return value.
22597 (Property.DefineMethod): use NoTypes here too.
22599 This fixes the bug I introduced in my last batch of changes.
22601 2002-03-05 Ravi Pratap <ravi@ximian.com>
22603 * tree.cs (RecordEnum): Add. We now keep track of enums too.
22605 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
22606 Enums since those are types too.
22608 * cs-parser.jay (enum_declaration): Record enums as we parse them.
22610 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
22611 thanks to a call during the lookup process.
22613 2002-03-07 Miguel de Icaza <miguel@ximian.com>
22615 * statement.cs (Foreach): Lots of work to accomodate a particular
22616 kind of foreach statement that I had not kept in mind. It is
22617 possible to have foreachs on classes that provide a GetEnumerator
22618 method that return objects that implement the "pattern" for using
22619 a foreach, there is no need to support GetEnumerator
22622 This is needed to compile nant.
22624 * decl.cs: Only report 114 if the member is not `Finalize' and if
22625 the warning level is at least 2.
22627 * class.cs: Moved the compare function from Method to
22630 (MethodSignature.InheritableMemberSignatureCompare): Add new
22631 filter function that is used to extract inheritable methods from a
22634 (Method.Define): Use the new `inheritable_method_signature_filter'
22637 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
22640 2002-03-06 Miguel de Icaza <miguel@ximian.com>
22642 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
22644 * cs-parser.jay: Add opt_semicolon to the interface declaration.
22646 * expression.cs: Pass location information to
22647 ConvertImplicitStandard.
22649 * class.cs: Added debugging code to track return values from
22652 2002-03-05 Miguel de Icaza <miguel@ximian.com>
22654 * expression.cs (Is.DoResolve): If either side of the `is' is an
22655 interface, do not flag the warning.
22657 * ecore.cs (ImplicitReferenceConversion): We need a separate test
22660 * report.cs: Allow for --fatal to be used with --probe.
22662 * typemanager.cs (NoTypes): Move the definition for the empty Type
22665 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
22667 (TypeContainer.DefineProxy): New function used to proxy to parent
22668 implementations when implementing interfaces.
22669 (TypeContainer.ParentImplements): used to lookup if our parent
22670 implements a public function that is required by an interface.
22671 (TypeContainer.VerifyPendingMethods): Hook this up.
22673 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
22674 `modules' and `assemblies' arraylists into arrays. We only grow
22675 these are the very early start up of the program, so this improves
22676 the speedof LookupType (nicely measured).
22678 * expression.cs (MakeByteBlob): Replaced unsafe code with
22679 BitConverter, as suggested by Paolo.
22681 * cfold.cs (ConstantFold.Binary): Special case: perform constant
22682 folding of string concatenation, but if either side is a string,
22683 and the other is not, then return null, and let the runtime use
22684 the concatenation on the string plus the object (using
22685 `Object.ToString').
22687 2002-03-04 Miguel de Icaza <miguel@ximian.com>
22689 Constant Folding has been implemented now.
22691 * expression.cs (Unary.Reduce): Do not throw an exception, catch
22692 the error instead on types that are not supported in one's
22695 * constant.cs (Constant and all children): New set of functions to
22696 perform implict and explicit conversions.
22698 * ecore.cs (EnumConstant): Implement the new functions to perform
22699 conversion by proxying to the child expression.
22701 * codegen.cs: (ConstantCheckState): Constant evaluation has its
22702 own separate setting that can not be turned off from the command
22703 line using --unchecked or --checked and is only controlled using
22704 the checked/unchecked statements and expressions. This setting is
22705 used by the constant folder to flag errors.
22707 * expression.cs (CheckedExpr, UncheckedExpr): Set the
22708 ConstantCheckState as well.
22710 During Resolve, they also have to flag the state, because the
22711 constant folder runs completely in the Resolve phase.
22713 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
22716 2002-03-01 Miguel de Icaza <miguel@ximian.com>
22718 * cfold.cs: New file, this file contains the constant folder.
22720 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
22721 argument to track whether we are using the resulting address to
22722 load or store a value and provide better error messages.
22724 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
22725 new AddressOf arguments.
22727 * statement.cs (Foreach.EmitCollectionForeach): Update
22729 * expression.cs (Argument.Emit): Call AddressOf with proper
22730 arguments to track usage.
22732 (New.DoEmit): Call AddressOf with new arguments.
22734 (Unary.Emit): Adjust AddressOf call.
22736 2002-03-01 Ravi Pratap <ravi@ximian.com>
22738 * cs-parser.jay (member_access): Change the case for pre-defined types
22739 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
22742 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
22745 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
22746 essentially like methods and apply attributes like MethodImplOptions to them too.
22748 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
22751 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
22752 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
22755 * Update code everywhere accordingly.
22757 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
22759 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
22761 2002-02-28 Ravi Pratap <ravi@ximian.com>
22763 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
22764 try performing lookups against those instead of jumping straight into using
22765 the 'using' clauses.
22767 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
22769 (LookupType): Perform lookups in implicit parents too.
22771 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
22772 sequence as RootContext.LookupType.
22774 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
22775 the various cases of namespace lookups into this method.
22777 2002-03-01 Miguel de Icaza <miguel@ximian.com>
22779 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
22780 in positional arguments)
22782 * class.cs (Operator): Update the AllowedModifiers to contain
22785 * cs-parser.jay: Update operator declaration to allow for the
22786 operator body to be empty.
22788 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
22791 2002-02-27 Miguel de Icaza <miguel@ximian.com>
22793 * class.cs (Method.Emit): Label parameters.
22795 * driver.cs: Return 1 or 0 as the program exit code.
22797 2002-02-26 Miguel de Icaza <miguel@ximian.com>
22799 * expression.cs: Special case the `null' object when trying to
22800 auto-compute the type, as anything can be explicitly converted to
22803 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
22804 spotting this Paolo.
22806 (Expression.ImplicitNumericConversion): Perform comparissions of
22807 the type using the underlying type in the case of an enumeration
22808 rather than using the enumeration type for the compare.
22810 Cope with the underlying == type case, which is not possible to
22813 (Expression.ConvertNumericExplicit): Perform comparissions of
22814 the type using the underlying type in the case of an enumeration
22815 rather than using the enumeration type for the compare.
22817 * driver.cs: If the user does not supply an extension, assume .exe
22819 * cs-parser.jay (if_statement): Rewrote so that we can track the
22820 location for the if statement.
22822 * expression.cs (Binary.ConstantFold): Only concat strings when
22823 the operation is "+", not everything ;-)
22825 * statement.cs (Statement.EmitBoolExpression): Take a location
22827 (If, While, Do): Track location.
22829 * expression.cs (Binary.ResolveOperator): In the object + string
22830 case, I was missing a call to ConvertImplicit
22832 2002-02-25 Ravi Pratap <ravi@ximian.com>
22834 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
22835 Location arguments. Ensure we use RootContext.LookupType to do our work
22836 and not try to do a direct Type.GetType and ModuleBuilder.GetType
22838 * interface.cs (PopulateMethod): Handle the type of the parameter being
22841 * expression.cs (Invocation.BetterFunction): Handle the case when we
22842 have a params method with no fixed arguments and a call is made with no
22845 2002-02-25 Miguel de Icaza <miguel@ximian.com>
22847 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
22848 the verbatim-string-literal
22850 * support.cs (InternalParameters.ParameterModifier): handle null
22852 (InternalParameters.ParameterType): ditto.
22854 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
22855 duplicating the name of the variable parameter.
22856 (GetParameterByName): Fix bug where we were not looking up array
22857 paramters if they were the only present (thanks Paolo!).
22858 (GetParameterInfo): We only have an empty set of types if both
22859 fixed and array are set to null.
22860 (GetParameterInfo-idx): Handle FixedParameter == null
22862 * cs-parser.jay: Handle the case where there is no catch
22863 statements (missing null test).
22865 2002-02-22 Miguel de Icaza <miguel@ximian.com>
22867 * driver.cs (MainDriver): Be conservative on our command line
22870 Catch DirectoryNotFoundException when calling GetFiles.
22872 (SplitPathAndPattern): Used to split the input specification into
22873 a path and a pattern that we can feed to Directory.GetFiles.
22875 2002-02-21 Miguel de Icaza <miguel@ximian.com>
22877 * statement.cs (Fixed): Implement the last case of the Fixed
22878 statement (string handling).
22880 * expression.cs (StringPtr): New class used to return a char * to
22881 a string; Used by the Fixed statement.
22883 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
22885 * expression.cs (Binary.ResolveOperator): Remove redundant
22886 MemberLookup pn parent type.
22887 Optimize union call, we do not need a union if the types are the same.
22888 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
22891 Specialize the use of MemberLookup everywhere, instead of using
22892 the default settings.
22894 (StackAlloc): Implement stackalloc keyword.
22896 * cs-parser.jay: Add rule to parse stackalloc.
22898 * driver.cs: Handle /h, /help, /?
22900 * expression.cs (MakeByteBlob): Removed the hacks we had in place
22901 before we supported unsafe code.
22903 * makefile: add --unsafe to the self compilation of mcs.
22905 2002-02-20 Miguel de Icaza <miguel@ximian.com>
22907 * expression.cs (PointerArithmetic): New class that is used to
22908 perform pointer arithmetic.
22909 (Binary.Resolve): Handle pointer arithmetic
22910 Handle pointer comparission.
22911 (ArrayPtr): Utility expression class that is used to take the
22912 address of an array.
22914 (ElementAccess): Implement array access for pointers
22916 * statement.cs (Fixed): Implement fixed statement for arrays, we
22917 are missing one more case before we are done.
22919 * expression.cs (Indirection): Implement EmitAssign and set the
22920 ExprClass to Variable. This allows pointer dereferences to be
22921 treated as variables, and to have values assigned to them.
22923 * ecore.cs (Expression.StoreFromPtr): New utility function to
22924 store values dereferencing.
22926 2002-02-20 Ravi Pratap <ravi@ximian.com>
22928 * expression.cs (Binary.ResolveOperator): Ensure that we are
22929 not trying to operate on a void type - this fixes the reported
22932 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
22933 the parent implementation is sealed.
22935 * ../errors/cs0239.cs : Add.
22937 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
22939 * typemanager.cs (unverifiable_code_type): Corresponds to
22940 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
22941 which have unsafe code in them.
22943 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
22946 2002-02-19 Miguel de Icaza <miguel@ximian.com>
22948 * cs-tokenizer.cs: Add support for @"litreal strings"
22950 Make tokenizer accept pre-processor directives
22951 on any column (remove the old C-like limitation).
22953 * rootcontext.cs (EmitCode): Emit any global attributes.
22954 (AddGlobalAttributes): Used to keep track of assembly attributes.
22956 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
22958 * cs-parser.jay: Add support for global attributes.
22960 2002-02-17 Miguel de Icaza <miguel@ximian.com>
22962 * expression.cs (Indirection): New helper class. Unary will
22963 create Indirection classes to be able to implement the
22964 IMemoryLocation interface on it.
22966 2002-02-16 Miguel de Icaza <miguel@ximian.com>
22968 * cs-parser.jay (fixed_statement): reference the right statement.
22970 * statement.cs (Fixed.Emit): Finish implementing the fixed
22971 statement for the &x case.
22973 2002-02-14 Miguel de Icaza <miguel@ximian.com>
22975 * class.cs (Property.Define, Method.Define): Remove newslot when
22978 * modifiers.cs: My use of NewSlot when `Abstract' was set was
22979 wrong. NewSlot should only be used if the `new' keyword is present.
22981 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
22982 locating our system dir. Sorry about this.
22984 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22986 * driver.cs (GetSystemDir): Compute correctly the location of our
22987 system assemblies. I was using the compiler directory instead of
22988 the library directory.
22990 2002-02-13 Ravi Pratap <ravi@ximian.com>
22992 * expression.cs (BetterFunction): Put back in what Miguel commented out
22993 since it is the correct fix. The problem is elsewhere ;-)
22995 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
22996 parameters of the parms method are themselves compatible or not !
22998 (StandardConversionExists): Fix very dangerous bug where we were forgetting
22999 to check that a class implements an interface before saying that an implicit
23000 conversion was allowed. Use ImplementsInterface to do the checking.
23002 2002-02-13 Miguel de Icaza <miguel@ximian.com>
23004 * class.cs (Method.Define): Track whether we are an explicit
23005 implementation or not. And only call DefineMethodOverride if we
23006 are an explicit implementation.
23008 (Property.DefineMethod): Ditto.
23010 2002-02-11 Ravi Pratap <ravi@ximian.com>
23012 * expression.cs (BetterFunction): Catch hideous bug which was
23013 preventing us from detecting ambiguous calls due to implicit casts i.e
23016 2002-01-29 Miguel de Icaza <miguel@ximian.com>
23018 * support.cs (Pair): Remove un-needed method. I figured why I was
23019 getting the error in cs-parser.jay, the variable in a foreach loop
23020 is readonly, and the compiler does not really treat this as a variable.
23022 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
23023 instead of EQUALS in grammar.
23025 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
23027 * expression.cs (Unary.DoResolve): Check whether the argument is
23030 2002-01-28 Miguel de Icaza <miguel@ximian.com>
23032 * support.cs: Api for Pair to set a value. Despite the fact that
23033 the variables are public the MS C# compiler refuses to compile
23034 code that accesses the field if the variable is part of a foreach
23037 * statement.cs (Fixed): Begin implementation of the fixed
23040 (Block.AddVariable): Return the VariableInfo on success and null
23041 on failure instead of true/false.
23043 * cs-parser.jay (foreach): Catch errors on variables already
23044 defined (we were ignoring this value before) and properly unwind
23045 the block hierarchy
23047 (fixed_statement): grammar for the fixed statement.
23049 2002-01-25 Miguel de Icaza <miguel@ximian.com>
23051 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
23052 pointer types to be incretemented.
23054 (SizeOf): Implement.
23056 * cs-parser.jay (pointer_member_access): Implement
23057 expr->IDENTIFIER production.
23059 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
23060 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
23063 (Unary): Implement indirection.
23065 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
23066 use in non-unsafe context).
23068 (SimpleName.DoResolve): Check for pointers in field access on safe
23071 (Expression.LoadFromPtr): Factor the load-indirect code in this
23072 function. This was duplicated in UnboxCast and ParameterReference
23074 2002-01-24 Miguel de Icaza <miguel@ximian.com>
23076 * expression.cs (ComposedCast): report an error if a pointer cast
23077 is used in a safe region.
23079 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
23080 pointer type casts in unsafe context.
23082 * codegen.cs (EmitContext): Set up IsUnsafe.
23084 * cs-parser.jay (non_expression_type): Add productions for pointer
23087 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
23088 code. We should not use force into static mode if the method is
23089 not virtual. Fixes bug in MIS
23091 * statement.cs (Do.Emit, While.Emit, For.Emit,
23092 Statement.EmitBoolExpression): Add support to Do and While to
23093 propagate infinite loop as `I do return' semantics.
23095 Improve the For case to also test for boolean constants.
23097 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
23098 to the list of attributes we can add.
23100 Remove `EmitContext' argument.
23102 * class.cs (Method.Define): Apply parameter attributes.
23103 (Constructor.Define): Apply parameter attributes.
23104 (MethodCore.LabelParameters): Move here the core of labeling
23107 * support.cs (ReflectionParameters.ParameterModifier,
23108 InternalParameters.ParameterModifier): Use IsByRef on the type and
23109 only return the OUT bit for these parameters instead of in/out/ref
23112 This is because I miss-understood things. The ParameterInfo.IsIn
23113 and IsOut represent whether the parameter has the [In] and [Out]
23116 2002-01-22 Miguel de Icaza <miguel@ximian.com>
23118 * ecore.cs (FieldExpr.Emit): Release temporaries.
23120 * assign.cs (LocalTemporary.Release): new function.
23122 * codegen.cs (EmitContext.GetTemporaryStorage,
23123 EmitContext.FreeTemporaryStorage): Rework the way we deal with
23124 temporary storage. Now we can "put back" localbuilders when we
23127 2002-01-21 Miguel de Icaza <miguel@ximian.com>
23129 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
23130 need to make a copy of the variable to generate verifiable code.
23132 2002-01-19 Miguel de Icaza <miguel@ximian.com>
23134 * driver.cs: Compute dynamically the system directory.
23136 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
23137 Slower, but more generally useful. Used by the abstract
23138 registering implementation.
23140 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
23141 the rules for the special rule on Type/instances. First check if
23142 we have the same name, and if so, try that special static path
23143 rather than the instance path.
23145 2002-01-18 Miguel de Icaza <miguel@ximian.com>
23147 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
23150 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
23151 Enum, ValueType, Delegate or Array for non-corlib compiles.
23153 * cs-tokenizer.cs: Catch long identifiers (645)
23155 * typemanager.cs (IndexerPropetyName): Ravi never tested this
23158 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
23159 fix, we were returning too early, so we were not registering
23160 pending methods from abstract classes.
23162 Do not register pending methods if the class is abstract.
23164 * expression.cs (Conditional.DoResolve): Report circular implicit
23165 conversions when we neecd to compute it for conditional
23168 (Is.DoResolve): If the expression is always of the provided type,
23169 flag warning 183. If the expression can not ever be of the
23170 provided type flag warning 184.
23172 * class.cs: Catch 169 as well.
23174 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
23177 2002-01-18 Nick Drochak <ndrochak@gol.com>
23179 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
23181 2002-01-17 Miguel de Icaza <miguel@ximian.com>
23183 * interface.cs: (PopulateMethod): Check for pointers being defined
23184 only if the unsafe context is active.
23185 (PopulateProperty): ditto.
23186 (PopulateIndexer): ditto.
23188 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
23189 specified. If pointers are present, make sure that they are
23190 present in an unsafe context.
23191 (Constructor, Constructor.Define): ditto.
23192 (Field, Field.Define): ditto.
23193 (Property, Property.Define): ditto.
23194 (Event, Event.Define): ditto.
23196 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
23197 hashtable if there are classes or structs defined.
23199 * expression.cs (LocalVariableReference.DoResolve): Simplify this
23200 code, as the constant resolution moved.
23202 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
23203 the metadata, so we can flag error 133.
23205 * decl.cs (MemberCore.UnsafeOK): New function to test that a
23206 pointer is being declared in an unsafe context.
23208 2002-01-16 Miguel de Icaza <miguel@ximian.com>
23210 * modifiers.cs (Modifiers.Check): Require a Location argument.
23211 Report error 227 for Unsafe use.
23213 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
23215 * statement.cs (For.Emit): If the test is null, then report that
23216 we do `return', as we wont reach anything afterwards.
23218 (Switch.SwitchGoverningType): Track the expression that matched
23221 * driver.cs: Allow negative numbers as an error code to flag.
23223 * cs-parser.jay: Handle 1551.
23225 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
23227 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23229 * cs-parser.jay: Report 1518 (type declaration can only contain
23230 class, struct, interface, enum or delegate)
23232 (switch_label): Report 1523 (keywords `case' or `default' must
23235 (opt_switch_sections): Report 1522 (empty switch)
23237 * driver.cs: Report 1515 (response file specified multiple times)
23238 Report 1516 (Source file specified multiple times).
23240 * expression.cs (Argument.Resolve): Signal 1510
23242 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
23243 access not allowed in static code)
23245 2002-01-11 Ravi Pratap <ravi@ximian.com>
23247 * typemanager.cs (IsPointerType): Utility method which we are going
23250 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
23251 the object type, so we take care of that.
23253 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
23255 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
23256 added to non-params parameters :-)
23258 * typemanager.cs (CSharpName): Include 'void' type too.
23260 (void_ptr_type): Include in the set of core types.
23262 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
23265 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
23268 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
23269 completely forgotten about it.
23271 2002-01-10 Ravi Pratap <ravi@ximian.com>
23273 * cs-parser.jay (pointer_type): Add. This begins our implementation
23274 of parsing rules for unsafe code.
23276 (unsafe_statement): Implement.
23278 (embedded_statement): Modify to include the above.
23280 * statement.cs (Unsafe): Implement new class for unsafe blocks.
23282 * codegen.cs (EmitContext.InUnsafe): Add. This determines
23283 if the current context is an unsafe one.
23285 * cs-parser.jay (local_variable_pointer_type): Since local variable types
23286 are handled differently, we need separate rules for them.
23288 (local_variable_declaration): Update to use local_variable_pointer_type
23289 to allow variable declarations of unmanaged pointer types.
23291 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
23292 in unsafe contexts.
23294 * ../errors/cs0214.cs : Add.
23296 2002-01-16 Nick Drochak <ndrochak@gol.com>
23298 * makefile: remove 'response' file when cleaning.
23300 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23302 * cs-parser.jay: Report 1524.
23304 2002-01-14 Miguel de Icaza <miguel@ximian.com>
23306 * typemanager.cs (RegisterMethod): drop checking if we have
23307 registered this from here
23309 2002-01-12 Miguel de Icaza <miguel@ximian.com>
23311 * class.cs (Method.EmitDestructor): Implement calling our base
23314 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
23315 value of InFinally.
23317 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
23318 this routine and will wrap the call in a try/catch block. Deal
23321 2002-01-11 Miguel de Icaza <miguel@ximian.com>
23323 * ecore.cs (Expression.MemberLookup): instead of taking a
23324 parameter `same_type' that was used to tell whether we could
23325 access private members we compute our containing type from the
23328 (FieldExpr): Added partial support for volatile fields. This does
23329 not work for volatile fields exposed from assemblies, as I can not
23330 figure out how to extract the modreq from it.
23332 Updated all the source files to use this.
23334 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
23335 because it is referenced by MemberLookup very often.
23337 2002-01-09 Ravi Pratap <ravi@ximian.com>
23339 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
23340 TypeBuilder.GetCustomAttributes to retrieve what we need.
23342 Get rid of redundant default_member_attr_type as this is the same as
23343 default_member_type which already exists.
23345 * interface.cs, attribute.cs : Update accordingly.
23347 2002-01-08 Miguel de Icaza <miguel@ximian.com>
23349 * typemanager.cs: Enable IndexerPropertyName again. It does not
23350 work for TYpeBuilders though. Ravi, can you please fix this?
23352 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
23354 * expression.cs (Argument.Emit): Handle the case of ref objects
23355 being passed to ref functions;
23357 (ParameterReference.EmitLoad): Loads the content of the pointer
23358 without dereferencing.
23360 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23362 * cs-tokenizer.cs: Implemented the pre-processing expressions.
23364 2002-01-08 Ravi Pratap <ravi@ximian.com>
23366 * class.cs (Indexer.DefineMethod): Incorporate the interface
23367 type in the name of the method if we are doing explicit interface
23370 * expression.cs (ConversionExists): Remove as it is completely obsolete.
23372 (BetterConversion): Fix extremely trivial bug where we were referring to
23373 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
23376 * ../errors/bug16.cs : Add although we have fixed it.
23378 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23380 * expression.cs (BaseIndexer): Begin implementation.
23382 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
23384 * cs-parser.jay (indexer_declarator): Use qualified_identifier
23385 production directly to remove a shift/reduce, and implement
23386 explicit interface implementation.
23388 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
23389 after a floating point suffix.
23391 * expression.cs (DoNumericPromotions): Improved the conversion for
23392 uint/uint. If we have a constant, we avoid doing a typecast to a
23395 * class.cs (Indexer): Implement explicit interface implementation
23398 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
23400 * class.cs: make the default instance constructor public and hidebysig.
23402 2001-01-03 Ravi Pratap <ravi@ximian.com>
23404 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
23405 so we can call it from elsewhere.
23407 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
23408 we emit it internally if the class has a defined indexer; otherwise the user
23409 emits it by decorating the class definition with the DefaultMemberAttribute.
23411 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
23412 attribute is not used on a type which defines an indexer.
23414 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
23415 character when we skip whitespace.
23417 * ../errors/cs0646.cs : Add.
23419 2002-01-03 Miguel de Icaza <miguel@ximian.com>
23421 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
23424 * makefile: Add practical target `mcs3.exe' which builds the third
23425 generation compiler.
23427 * expression.cs (New): Fix structures constructor calling.
23429 * class.cs (Property, Method, Indexer): Emit Final flag on the
23430 method if we are an interface implementation and we are not
23433 * ecore.cs (PropertyExpr): New public field `IsBase', tells
23434 whether this property is referencing a `base' method.
23436 * expression.cs (Invocation.EmitCall): take an extra argument:
23437 is_base, this is used to determine whether the `call' or
23438 `callvirt' opcode should be used.
23441 * delegate.cs: update EmitCall.
23443 * class.cs (Method.Define): Set NewSlot for the cases where we are
23444 not implementing an interface method.
23446 (Property.Define): ditto.
23448 2002-01-02 Miguel de Icaza <miguel@ximian.com>
23450 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
23451 'r'. Allows mcs to parse itself fully.
23453 2002-01-02 Ravi Pratap <ravi@ximian.com>
23455 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
23456 of the number of initializers that require the InitializeArray method.
23458 (CheckIndices): Store the Expression in all cases - not the plain value. Also
23459 update the above field where necessary.
23461 (MakeByteBlob): Update accordingly.
23463 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
23466 (EmitDynamicInitializers): Update in accordance with the new optimization.
23468 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
23469 same OpCode applies.
23471 * cs-parser.jay : Fix some glaring errors I introduced.
23473 2002-01-01 Ravi Pratap <ravi@ximian.com>
23475 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
23476 so that we can check for name clashes there too.
23478 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
23479 for interface indexers.
23481 * interfaces.cs (Define): Emit the default member attribute.
23483 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
23484 variable was being referred to while setting the value ;-)
23486 2002-01-01 Miguel de Icaza <miguel@ximian.com>
23488 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
23489 byte-by-byte information when we know the data is zero.
23491 Make the block always a multiple of 4, because
23492 DefineInitializedData has a bug.
23494 * assign.cs: Fix, we should assign from the temporary, not from
23497 * expression.cs (MakeByteBlob): Fix my incorrect code.
23499 2001-12-31 Miguel de Icaza <miguel@ximian.com>
23501 * typemanager.cs (EnumToUnderlying): This function is used to get
23502 the underlying type from an enumeration, because it does not
23505 * constant.cs: Use the I4_S form for values between -128 and 127.
23507 * statement.cs (Block.LookupLabel): Looks up a label.
23508 (Block): Drop support for labeled blocks.
23510 (LabeledStatement): New kind of statement that represents a label
23513 (Goto): Finally implement this bad boy.
23515 * cs-parser.jay: Update to reflect new mechanism to implement
23518 2001-12-30 Miguel de Icaza <miguel@ximian.com>
23520 * codegen.cs (EmitContext.This): a codegen property that keeps the
23521 a single instance of this instead of creating many different this
23524 * delegate.cs (Delegate.DoResolve): Update to use the property;
23526 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
23528 * expression.cs (BaseAccess.DoResolve): Ditto.
23530 2001-12-29 Ravi Pratap <ravi@ximian.com>
23532 * typemanager.cs (methodimpl_attr_type): Add to hold the type
23533 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
23535 (InitCoreTypes): Update accordingly.
23537 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
23538 so we can quickly store the state.
23540 (ApplyAttributes): Set the correct implementation flags
23541 for InternalCall methods.
23543 2001-12-29 Miguel de Icaza <miguel@ximian.com>
23545 * expression.cs (EmitCall): if a method is not virtual, then do
23546 not use callvirt on it.
23548 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
23549 user defined stuff) requires the use of stobj, which takes an
23550 address on the stack instead of an array and an index. So emit
23551 the Ldelema operation for it.
23553 (EmitStoreOpcode): Use stobj for valuetypes.
23555 (UnaryMutator.EmitCode): Use the right 1 value depending on
23556 whether we are dealing with int64/uint64, float or doubles.
23558 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
23559 constructors that I implemented last night.
23561 (Constructor.IsDefault): Fix to work properly for static
23564 * cs-parser.jay (CheckDef): report method signature errors.
23565 Update error number 103 to be 132.
23567 * decl.cs: New AdditionResult enumeration value: MethodExists.
23568 Although we do this check for methods later on in the semantic
23569 analysis, catching repeated default constructors is so easy that
23570 we catch these here.
23572 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
23575 (ParameterReference.EmitAssign, Emit): handle
23578 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
23579 (ArrayAccess.EmitStoreOpcode): ditto.
23581 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
23583 * expression.cs (MakeByteBlob): Complete all the missing types
23584 (uint, short, ushort, byte, sbyte)
23586 * class.cs: Only init instance field initializers on instance
23589 Rename `constructors' to instance_constructors.
23591 (TypeContainer.AddConstructor): Only add constructors to the list
23592 if it is not static.
23594 Make sure that we handle default_static_constructor independently
23595 everywhere where we handle instance_constructors
23597 2001-12-28 Miguel de Icaza <miguel@ximian.com>
23599 * class.cs: Do not lookup or create a base initializer for a
23600 static constructor.
23602 (ConstructorInitializer.Resolve): use the proper type to lookup
23605 * cs-parser.jay: Report error 1585 (modifiers between type and name).
23607 * enum.cs, interface.cs: Remove CloseType, this is taken care by
23610 * decl.cs: CloseType is now an virtual method, the default
23611 implementation just closes this type.
23613 2001-12-28 Ravi Pratap <ravi@ximian.com>
23615 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
23616 to PreserveSig by default. Also emit HideBySig on such methods.
23618 Basically, set the defaults to standard values.
23620 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
23621 argument, if candidate is better, it can't be worse than the best !
23623 (Invocation): Re-write bits to differentiate between methods being
23624 applicable in their expanded form and their normal form - for params
23627 Get rid of use_standard everywhere as only standard conversions are allowed
23628 in overload resolution.
23630 More spec conformance.
23632 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23634 * driver.cs: Add --timestamp, to see where the compiler spends
23637 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
23638 `this' in static code.
23640 (SimpleName.DoResolve): Implement in terms of a helper function
23641 that allows static-references to be passed upstream to
23644 (Expression.ResolveWithSimpleName): Resolve specially simple
23645 names when called by MemberAccess to implement the special
23648 (Expression.ImplicitReferenceConversion): Handle conversions from
23649 Null to reference types before others, as Null's type is
23652 * expression.cs (Invocation.EmitCall): Handle the special case of
23653 calling methods declared on a reference type from a ValueType
23654 (Base classes System.Object and System.Enum)
23656 (MemberAccess.Resolve): Only perform lookups on Enumerations if
23657 the left hand side is a TypeExpr, not on every enumeration.
23659 (Binary.Resolve): If types are reference types, then do a cast to
23660 object on operators != and == of both arguments.
23662 * typemanager.cs (FindMembers): Extract instance and static
23663 members if requested.
23665 * interface.cs (PopulateProperty): Use void_type instead of null
23666 as the return type for the setter method.
23668 (PopulateIndexer): ditto.
23670 2001-12-27 Ravi Pratap <ravi@ximian.com>
23672 * support.cs (ReflectionParameters): Fix minor bug where we
23673 were examining the wrong parameter for the ParamArray attribute.
23675 Cope with requests for the type of the parameter at position
23676 greater than the params parameter's. We now return the element
23677 type of the params array as that makes more sense.
23679 * expression.cs (Invocation.IsParamsMethodApplicable): Update
23680 accordingly as we no longer have to extract the element type
23683 (Invocation.OverloadResolve): Update.
23685 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23687 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
23688 against IEnumerator, test whether the return value is a descendant
23689 of the IEnumerator interface.
23691 * class.cs (Indexer.Define): Use an auxiliary method to implement
23692 the other bits of the method definition. Begin support for
23693 explicit interface implementation.
23695 (Property.DefineMethod): Use TypeManager.void_type instead of null
23696 for an empty return value.
23698 2001-12-26 Miguel de Icaza <miguel@ximian.com>
23700 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
23701 dealing with a FieldExpr which is composed of a FieldBuilder, in
23702 the code path we did extract the constant, but we should have
23703 obtained the underlying value to be able to cast it (otherwise we
23704 end up in an infinite loop, this is what Ravi was running into).
23706 (ArrayCreation.UpdateIndices): Arrays might be empty.
23708 (MemberAccess.ResolveMemberAccess): Add support for section
23709 14.5.4.1 that deals with the special case of E.I when E is a type
23710 and something else, that I can be a reference to a static member.
23712 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
23713 handle a particular array type to create byte blobs, it is just
23714 something we dont generate byteblobs for.
23716 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
23719 * location.cs (Push): remove the key from the hashtable that we
23720 are about to add. This happens for empty files.
23722 * driver.cs: Dispose files after we have parsed them.
23724 (tokenize): new function that only runs the tokenizer on its
23725 input, for speed testing.
23727 2001-12-26 Ravi Pratap <ravi@ximian.com>
23729 * class.cs (Event.Define): Define the private field only if there
23730 are no accessors defined.
23732 * expression.cs (ResolveMemberAccess): If there is no associated
23733 field with the event, that means we have an event defined with its
23734 own accessors and we should flag error cs0070 since transforming
23735 ourselves into a field is not valid in that case.
23737 * ecore.cs (SimpleName.DoResolve): Same as above.
23739 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
23740 and charset to sane values.
23742 2001-12-25 Ravi Pratap <ravi@ximian.com>
23744 * assign.cs (DoResolve): Perform check on events only if they
23745 are being accessed outside the declaring type.
23747 * cs-parser.jay (event_declarations): Update rules to correctly
23748 set the type of the implicit parameter etc.
23750 (add_accessor, remove_accessor): Set current local parameters.
23752 * expression.cs (Binary): For delegate addition and subtraction,
23753 cast the return value from the method into the appropriate delegate
23756 2001-12-24 Ravi Pratap <ravi@ximian.com>
23758 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
23759 of these as the workaround is unnecessary.
23761 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
23762 delegate data - none of that is needed at all.
23764 Re-write bits to extract the instance expression and the delegate method
23767 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
23770 * attribute.cs (ApplyAttributes): New method to take care of common tasks
23771 of attaching attributes instead of duplicating code everywhere.
23773 * everywhere : Update code to do attribute emission using the above method.
23775 2001-12-23 Miguel de Icaza <miguel@ximian.com>
23777 * expression.cs (IsParamsMethodApplicable): if there are not
23778 parameters, return immediately.
23780 * ecore.cs: The 0 literal can be implicity converted to an enum
23783 (SimpleName.DoResolve): First lookup the type, then lookup the
23786 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
23787 want to get its address. If the InstanceExpression is not
23788 addressable, store the result in a temporary variable, then get
23791 * codegen.cs: Only display 219 errors on warning level or above.
23793 * expression.cs (ArrayAccess): Make it implement the
23794 IMemoryLocation interface.
23796 (Binary.DoResolve): handle the operator == (object a, object b)
23797 and operator != (object a, object b) without incurring into a
23798 BoxedCast (because 5 != o should never be performed).
23800 Handle binary enumerator operators.
23802 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
23803 value type, otherwise use Ldelem_ref.
23805 Use precomputed names;
23807 (AddressOf): Implement address of
23809 * cs-parser.jay (labeled_statement): Fix recursive block
23810 addition by reworking the production.
23812 * expression.cs (New.DoEmit): New has a special case:
23814 If we are dealing with a ValueType, we have a few
23815 situations to deal with:
23817 * The target of New is a ValueType variable, that is
23818 easy, we just pass this as the variable reference
23820 * The target of New is being passed as an argument,
23821 to a boxing operation or a function that takes a
23824 In this case, we need to create a temporary variable
23825 that is the argument of New.
23828 2001-12-23 Ravi Pratap <ravi@ximian.com>
23830 * rootcontext.cs (LookupType): Check that current_type is not null before
23831 going about looking at nested types.
23833 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
23834 not implement the IAssignMethod interface any more.
23836 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
23837 where we tranform them into FieldExprs if they are being resolved from within
23838 the declaring type.
23840 * ecore.cs (SimpleName.DoResolve): Do the same here.
23842 * assign.cs (DoResolve, Emit): Clean up code considerably.
23844 * ../errors/bug10.cs : Add.
23846 * ../errors/cs0070.cs : Add.
23848 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
23850 * assign.cs : Get rid of EventIsLocal everywhere.
23852 2001-12-23 Miguel de Icaza <miguel@ximian.com>
23854 * ecore.cs (ConvertIntLiteral): finished the implementation.
23856 * statement.cs (SwitchLabel): Convert the value we are using as a
23857 key before looking up the table.
23859 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23861 * codegen.cs (EmitTopBlock): Require a Location argument now.
23863 * cs-parser.jay (constructor_declarator): We need to setup
23864 current_local_parameters before we parse the
23865 opt_constructor_initializer, to allow the variables to be bound
23866 to the constructor arguments.
23868 * rootcontext.cs (LookupType): First lookup nested classes in our
23869 class and our parents before we go looking outside our class.
23871 * expression.cs (ConstantFold): Extract/debox the values at the
23874 * rootcontext.cs (EmitCode): Resolve the constants first before we
23875 resolve the types. This is not really needed, but it helps debugging.
23877 * statement.cs: report location.
23879 * cs-parser.jay: pass location to throw statement.
23881 * driver.cs: Small bug fix.
23883 * report.cs: Updated format to be 4-zero filled digits.
23885 2001-12-22 Ravi Pratap <ravi@ximian.com>
23887 * expression.cs (CheckIndices): Fix minor bug where the wrong
23888 variable was being referred to ;-)
23890 (DoEmit): Do not call EmitStaticInitializers when the
23891 underlying type is System.Object.
23893 2001-12-21 Ravi Pratap <ravi@ximian.com>
23895 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
23896 and do the usual workaround for SRE.
23898 * class.cs (MyEventBuilder.EventType): New member to get at the type
23899 of the event, quickly.
23901 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
23903 * assign.cs (Assign.DoResolve): Handle the case when the target
23904 is an EventExpr and perform the necessary checks.
23906 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
23909 (SimpleName.MemberStaticCheck): Include check for EventExpr.
23911 (EventExpr): Set the type in the constructor itself since we
23912 are meant to be born fully resolved.
23914 (EventExpr.Define): Revert code I wrote earlier.
23916 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
23917 instance expression is null. The instance expression is a This in that case
23918 or a null, depending on whether it is a static method or not.
23920 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
23921 refers to more than one method.
23923 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
23924 and accordingly flag errors.
23926 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23928 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
23930 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23932 * location.cs (ToString): Provide useful rutine.
23934 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23936 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
23937 objects, return the actual integral boxed.
23939 * statement.cs (SwitchLabel): define an ILLabel for each
23942 (Switch.CheckSwitch): If the value is a Literal, extract
23943 the underlying literal.
23945 Also in the unused hashtable we had, add the SwitchLabel so we can
23946 quickly look this value up.
23948 * constant.cs: Implement a bunch of new constants. Rewrite
23949 Literal based on this. Made changes everywhere to adapt to this.
23951 * expression.cs (Expression.MakeByteBlob): Optimize routine by
23952 dereferencing array only once, and also copes with enumrations.
23954 bytes are two bytes wide, not one.
23956 (Cast): Perform constant conversions.
23958 * ecore.cs (TryImplicitIntConversion): Return literals instead of
23959 wrappers to the literals here.
23961 * expression.cs (DoNumericPromotions): long literals can converted
23962 to ulong implicity (this is taken care of elsewhere, but I was
23963 missing this spot).
23965 * ecore.cs (Expression.Literalize): Make the return type Literal,
23966 to improve type checking.
23968 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
23970 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23972 * literal.cs: Revert code from ravi that checked the bounds. The
23973 bounds are sane by the definition of the type itself.
23975 * typemanager.cs: Fix implementation of ImplementsInterface. We
23976 need to actually look up in our parent hierarchy for interfaces
23979 * const.cs: Use the underlying type for enumerations
23981 * delegate.cs: Compute the basename for the delegate creation,
23982 that should fix the delegate test case, and restore the correct
23983 Type Lookup semantics in rootcontext
23985 * rootcontext.cs: Revert Ravi's last patch. The correct way of
23986 referencing a nested type with the Reflection API is using the "+"
23989 * cs-parser.jay: Do not require EOF token at the end.
23991 2001-12-20 Ravi Pratap <ravi@ximian.com>
23993 * rootcontext.cs (LookupType): Concatenate type names with
23994 a '.' instead of a '+' The test suite passes again.
23996 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
23997 field of the enumeration.
23999 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
24000 the case when the member is an EventExpr.
24002 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
24003 static has an associated instance expression.
24005 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
24007 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
24009 * class.cs (Event.Define): Register event and perform appropriate checks
24012 We define the Add and Remove methods even if the use provides none because
24013 in that case, we provide default implementations ourselves.
24015 Define a private field of the type of the event. This is done by the CSC compiler
24016 and we should be doing it too ;-)
24018 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
24019 More methods we use in code we generate.
24021 (multicast_delegate_type, delegate_type): Two separate types since the distinction
24024 (InitCoreTypes): Update accordingly for the above.
24026 * class.cs (Event.Emit): Generate code for default accessors that we provide
24028 (EmitDefaultMethod): Do the job in the above.
24030 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
24033 2001-12-20 Miguel de Icaza <miguel@ximian.com>
24035 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
24036 builders even if we were missing one.
24038 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
24039 pass the Basename as our class name instead of the Name. The
24040 basename will be correctly composed for us.
24042 * parameter.cs (Paramters): Now takes a Location argument.
24044 * decl.cs (DeclSpace.LookupType): Removed convenience function and
24045 make all the code call directly LookupType in RootContext and take
24046 this chance to pass the Location information everywhere.
24048 * Everywhere: pass Location information.
24050 2001-12-19 Miguel de Icaza <miguel@ximian.com>
24052 * class.cs (Constructor.Define): Updated way of detecting the
24053 length of the parameters.
24055 (TypeContainer.DefineType): Use basename as the type name for
24058 (TypeContainer.Define): Do not recursively define types here, as
24059 definition is taken care in order by the RootContext.
24061 * tree.cs: Keep track of namespaces in a per-file basis.
24063 * parameter.cs (Parameter.ComputeSignature): Update to use
24066 (Parameters.GetSignature): ditto.
24068 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
24069 instead of a TypeContainer.
24071 (Interface.SemanticAnalysis): Use `this' instead of our parent to
24072 resolve names. Because we need to be resolve in our context, not
24075 * driver.cs: Implement response files.
24077 * class.cs (TypeContainer.DefineType): If we are defined, do not
24078 redefine ourselves.
24080 (Event.Emit): Emit the code for add/remove handlers.
24081 (Event.Define): Save the MethodBuilders for add/remove.
24083 * typemanager.cs: Use pair here too.
24085 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
24086 DictionaryEntry requires the first argument to be non-null.
24088 (enum_declaration): Compute full name for registering the
24091 (delegate_declaration): Instead of using
24092 formal_parameter_list, use opt_formal_parameter_list as the list
24095 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
24096 (EventParsing): New property that controls whether `add' and
24097 `remove' are returned as tokens or identifiers (for events);
24099 2001-12-19 Ravi Pratap <ravi@ximian.com>
24101 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
24102 use MyEventBuilder only and let it wrap the real builder for us.
24104 (MyEventBuilder): Revamp constructor etc.
24106 Implement all operations that we perform on EventBuilder in precisely the same
24109 (FindMembers): Update to use the EventBuilder member.
24111 (Event.Emit): Update accordingly.
24113 2001-12-18 Ravi Pratap <ravi@ximian.com>
24115 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
24116 by calling the appropriate methods.
24118 (GetCustomAttributes): Make stubs as they cannot possibly do anything
24121 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
24123 2001-12-17 Ravi Pratap <ravi@ximian.com>
24125 * delegate.cs (Delegate.Populate): Check that the return type
24126 and various parameters types are indeed accessible.
24128 * class.cs (Constructor.Define): Same here.
24130 (Field.Define): Ditto.
24132 (Event.Define): Ditto.
24134 (Operator.Define): Check that the underlying Method defined itself
24135 correctly - so it's MethodBuilder should not be null.
24137 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
24138 expression happens to be null.
24140 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
24141 members but as of now we don't seem to be able to do anything really useful with it.
24143 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
24144 not the EventBuilder.
24146 2001-12-18 Miguel de Icaza <miguel@ximian.com>
24148 * cs-tokenizer.cs: Add support for defines.
24149 Add support for #if, #elif, #else, #endif
24151 (eval_var): evaluates a variable.
24152 (eval): stubbed for evaluating functions.
24154 * cs-parser.jay: Pass the defines information
24156 * driver.cs: Add --define command line option.
24158 * decl.cs: Move MemberCore here.
24160 Make it the base class for DeclSpace. This allows us to catch and
24161 report 108 and 109 for everything now.
24163 * class.cs (TypeContainer.Define): Extract all the members
24164 before populating and emit the warning 108 (new keyword required
24165 to override) instead of having each member implement this.
24167 (MemberCore.Define): New abstract method, we will be using this in
24168 the warning reporting engine in Populate.
24170 (Operator.Define): Adjust to new MemberCore protocol.
24172 * const.cs (Const): This does not derive from Expression, it is a
24173 temporary object we use to create fields, it is a MemberCore.
24175 * class.cs (Method.Define): Allow the entry point to be in a
24178 * driver.cs: Rewrite the argument handler to clean it up a bit.
24180 * rootcontext.cs: Made it just an auxiliary namespace feature by
24181 making everything static.
24183 * driver.cs: Adapt code to use RootContext type name instead of
24186 * delegate.cs: Remove RootContext argument.
24188 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
24191 * class.cs (Event.Define): The lookup can fail.
24193 * cs-tokenizer.cs: Begin implementation of pre-procesor.
24195 * expression.cs: Resolve the this instance before invoking the code.
24197 2001-12-17 Miguel de Icaza <miguel@ximian.com>
24199 * cs-parser.jay: Add a production in element_access that allows
24200 the thing to become a "type" reference. This way we can parse
24201 things like "(string [])" as a type.
24203 Note that this still does not handle the more complex rules of
24207 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
24209 * ecore.cs: (CopyNewMethods): new utility function used to
24210 assemble the list of methods from running FindMembers.
24212 (MemberLookup): Rework FindMembers so that
24214 2001-12-16 Miguel de Icaza <miguel@ximian.com>
24216 * class.cs (TypeContainer): Remove Delegates who fail to be
24219 * delegate.cs (Populate): Verify that we dont get null return
24220 values. TODO: Check for AsAccessible.
24222 * cs-parser.jay: Use basename to emit error 574 (destructor should
24223 have the same name as container class), not the full name.
24225 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
24226 possible representation.
24228 Also implements integer type suffixes U and L.
24230 2001-12-15 Miguel de Icaza <miguel@ximian.com>
24232 * expression.cs (ArrayCreation.DoResolve): We need to do the
24233 argument resolution *always*.
24235 * decl.cs: Make this hold the namespace. Hold the root context as
24237 (LookupType): Move here.
24239 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
24241 * location.cs (Row, Name): Fixed the code, it was always returning
24242 references to the first file.
24244 * interface.cs: Register properties defined through interfaces.
24246 * driver.cs: Add support for globbing on the command line
24248 * class.cs (Field): Make it derive from MemberCore as well.
24251 2001-12-15 Ravi Pratap <ravi@ximian.com>
24253 * class.cs (Event::Define): Check that the type of the event is a delegate
24254 type else flag error #66.
24256 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
24259 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
24260 values of EntryPoint, CharSet etc etc.
24262 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
24264 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
24265 be null and we should ignore this. I am not sure if this is really clean. Apparently,
24266 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
24267 which needs this to do its work.
24269 * ../errors/cs0066.cs : Add.
24271 2001-12-14 Miguel de Icaza <miguel@ximian.com>
24273 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
24276 * class.cs: (MethodSignature.MethodSignature): Removed hack that
24277 clears out the parameters field.
24278 (MemberSignatureCompare): Cleanup
24280 (MemberCore): New base class used to share code between MethodCore
24283 (RegisterRequiredImplementations) BindingFlags.Public requires
24284 either BindingFlags.Instace or Static. Use instance here.
24286 (Property): Refactored code to cope better with the full spec.
24288 * parameter.cs (GetParameterInfo): Return an empty array instead
24291 * class.cs (Property): Abstract or extern properties have no bodies.
24293 * parameter.cs (GetParameterInfo): return a zero-sized array.
24295 * class.cs (TypeContainer.MethodModifiersValid): Move all the
24296 method modifier validation to the typecontainer so we can reuse
24297 this on properties.
24299 (MethodCore.ParameterTypes): return an empty sized array of types.
24301 (Property.Define): Test property modifier validity.
24303 Add tests for sealed/override too.
24305 (Method.Emit): abstract or extern methods have no bodies.
24307 2001-12-14 Ravi Pratap <ravi@ximian.com>
24309 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
24312 (Method::Define, ::Emit): Modify accordingly.
24314 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
24316 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
24318 * makefile: Pass in /unsafe.
24320 2001-12-13 Miguel de Icaza <miguel@ximian.com>
24322 * class.cs (MakeKey): Kill routine.
24324 * class.cs (TypeContainer.Define): Correctly define explicit
24325 method implementations (they require the full interface name plus
24328 * typemanager.cs: Deply the PtrHashtable here and stop using the
24329 lame keys. Things work so much better.
24331 This of course broke everyone who depended on `RegisterMethod' to
24332 do the `test for existance' test. This has to be done elsewhere.
24334 * support.cs (PtrHashtable): A hashtable that avoid comparing with
24335 the object stupid Equals method (because, that like fails all over
24336 the place). We still do not use it.
24338 * class.cs (TypeContainer.SetRequiredInterface,
24339 TypeContainer.RequireMethods): Killed these two routines and moved
24340 all the functionality to RegisterRequiredImplementations.
24342 (TypeContainer.RegisterRequiredImplementations): This routine now
24343 registers all the implementations required in an array for the
24344 interfaces and abstract methods. We use an array of structures
24345 which can be computed ahead of time to reduce memory usage and we
24346 also assume that lookups are cheap as most classes will not
24347 implement too many interfaces.
24349 We also avoid creating too many MethodSignatures.
24351 (TypeContainer.IsInterfaceMethod): Update and optionally does not
24352 clear the "pending" bit if we find that there are problems with
24355 (TypeContainer.VerifyPendingMethods): Update to report errors of
24356 methods that look like implementations but are not.
24358 (TypeContainer.Define): Add support for explicit interface method
24361 2001-12-12 Miguel de Icaza <miguel@ximian.com>
24363 * typemanager.cs: Keep track of the parameters here instead of
24364 being a feature of the TypeContainer.
24366 * class.cs: Drop the registration of parameters here, as
24367 InterfaceMethods are also interface declarations.
24369 * delegate.cs: Register methods with the TypeManager not only with
24370 the TypeContainer. This code was buggy.
24372 * interface.cs: Full registation here.
24374 2001-12-11 Miguel de Icaza <miguel@ximian.com>
24376 * expression.cs: Remove reducer for binary expressions, it can not
24379 * const.cs: Put here the code that used to go into constant.cs
24381 * constant.cs: Put here the code for constants, this is a new base
24382 class for Literals.
24384 * literal.cs: Make Literal derive from Constant.
24386 2001-12-09 Miguel de Icaza <miguel@ximian.com>
24388 * statement.cs (Return.Emit): Report error 157 if the user
24389 attempts to return from a finally block.
24391 (Return.Emit): Instead of emitting a return, jump to the end of
24394 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
24395 LocalBuilder to store the result of the function. ReturnLabel is
24396 the target where we jump.
24399 2001-12-09 Radek Doulik <rodo@ximian.com>
24401 * cs-parser.jay: remember alias in current namespace
24403 * ecore.cs (SimpleName::DoResolve): use aliases for types or
24406 * class.cs (LookupAlias): lookup alias in my_namespace
24408 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
24410 (LookupAlias): lookup alias in this and if needed in parent
24413 2001-12-08 Miguel de Icaza <miguel@ximian.com>
24417 * rootcontext.cs: (ModuleBuilder) Made static, first step into
24418 making things static. I need this to avoid passing the
24419 TypeContainer when calling ParameterType.
24421 * support.cs (InternalParameters.ParameterType): Remove ugly hack
24422 that did string manipulation to compute the type and then call
24423 GetType. Use Parameter.ParameterType instead.
24425 * cs-tokenizer.cs: Consume the suffix for floating values.
24427 * expression.cs (ParameterReference): figure out whether this is a
24428 reference parameter or not. Kill an extra variable by computing
24429 the arg_idx during emission.
24431 * parameter.cs (Parameters.GetParameterInfo): New overloaded
24432 function that returns whether a parameter is an out/ref value or not.
24434 (Parameter.ParameterType): The type of the parameter (base,
24435 without ref/out applied).
24437 (Parameter.Resolve): Perform resolution here.
24438 (Parameter.ExternalType): The full type (with ref/out applied).
24440 * statement.cs (Using.Emit, Using.EmitExpression): Implement
24441 support for expressions on the using statement.
24443 2001-12-07 Miguel de Icaza <miguel@ximian.com>
24445 * statement.cs (Using.EmitLocalVariableDecls): Split the
24446 localvariable handling of the using statement.
24448 (Block.EmitMeta): Keep track of variable count across blocks. We
24449 were reusing slots on separate branches of blocks.
24451 (Try.Emit): Emit the general code block, we were not emitting it.
24453 Check the type of the declaration to be an IDisposable or
24454 something that can be implicity converted to it.
24456 Emit conversions if required.
24458 * ecore.cs (EmptyExpression): New utility class.
24459 (Expression.ImplicitConversionExists): New utility function.
24461 2001-12-06 Miguel de Icaza <miguel@ximian.com>
24463 * statement.cs (Using): Implement.
24465 * expression.cs (LocalVariableReference): Support read only variables.
24467 * statement.cs: Remove the explicit emit for the Leave opcode.
24468 (VariableInfo): Add a readonly field.
24470 2001-12-05 Miguel de Icaza <miguel@ximian.com>
24472 * ecore.cs (ConvCast): new class used to encapsulate the various
24473 explicit integer conversions that works in both checked and
24474 unchecked contexts.
24476 (Expression.ConvertNumericExplicit): Use new ConvCast class to
24477 properly generate the overflow opcodes.
24479 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24481 * statement.cs: The correct type for the EmptyExpression is the
24482 element_type, not the variable type. Ravi pointed this out.
24484 2001-12-04 Ravi Pratap <ravi@ximian.com>
24486 * class.cs (Method::Define): Handle PInvoke methods specially
24487 by using DefinePInvokeMethod instead of the usual one.
24489 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
24490 above to do the task of extracting information and defining the method.
24492 2001-12-04 Ravi Pratap <ravi@ximian.com>
24494 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
24495 of the condition for string type.
24497 (Emit): Move that here.
24499 (ArrayCreation::CheckIndices): Keep string literals in their expression
24502 (EmitDynamicInitializers): Handle strings appropriately.
24504 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24506 * codegen.cs (EmitContext): Replace multiple variables with a
24507 single pointer to the current Switch statement.
24509 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
24512 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24516 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
24519 (Foreach.Emit): Foreach on arrays was not setting
24520 up the loop variables (for break/continue).
24522 (GotoCase): Semi-implented.
24524 2001-12-03 Ravi Pratap <ravi@ximian.com>
24526 * attribute.cs (CheckAttribute): Handle system attributes by using
24527 Attribute.GetAttributes to examine information we need.
24529 (GetValidPlaces): Same here.
24531 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
24533 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
24535 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
24537 (Method::Define): Set appropriate flags if we have a DllImport attribute.
24539 (Method::Emit): Handle the case when we are a PInvoke method.
24541 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24543 * expression.cs: Use ResolveWithSimpleName on compound names.
24545 2001-12-02 Ravi Pratap <ravi@ximian.com>
24547 * constant.cs (EmitConstant): Make sure we resolve the associated expression
24548 before trying to reduce it.
24550 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
24552 * constant.cs (LookupConstantValue): Implement.
24554 (EmitConstant): Use the above in emitting the constant.
24556 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
24557 that are user-defined by doing a LookupConstantValue on them.
24559 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
24562 2001-11-29 Miguel de Icaza <miguel@ximian.com>
24564 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
24566 (BaseAccess.DoResolve): Implement.
24568 (MemberAccess.DoResolve): Split this routine into a
24569 ResolveMemberAccess routine that can be used independently
24571 2001-11-28 Miguel de Icaza <miguel@ximian.com>
24573 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
24574 As that share bits of the implementation. Is returns a boolean,
24575 while As returns the Type that is being probed.
24577 2001-12-01 Ravi Pratap <ravi@ximian.com>
24579 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
24580 instead of a Literal - much easier.
24582 (EnumInTransit): Remove - utterly useless :-)
24584 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
24586 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
24588 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
24589 chain when we have no associated expression.
24591 2001-11-30 Ravi Pratap <ravi@ximian.com>
24593 * constant.cs (Define): Use Location while reporting the errror.
24595 Also emit a warning when 'new' is used and there is no inherited
24598 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
24601 (LookupEnumValue): Implement to lookup an enum member's value and define it
24604 (Populate): Re-write accordingly to use the above routine.
24606 2001-11-27 Miguel de Icaza <miguel@ximian.com>
24608 * expression.cs (This): Fix prototype for DoResolveLValue to
24609 override the base class DoResolveLValue.
24611 * cs-parser.cs: Report errors cs574 and cs575 (destructor
24614 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
24615 (we need to load the address of the field here). This fixes
24618 (FieldExpr.DoResolveLValue): Call the DoResolve
24619 function to initialize the Instance expression.
24621 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
24622 correctly the GetEnumerator operation on a value type.
24624 * cs-parser.jay: Add more simple parsing error catches.
24626 * statement.cs (Switch): Add support for string switches.
24627 Handle null specially.
24629 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
24631 2001-11-28 Ravi Pratap <ravi@ximian.com>
24633 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
24635 (declare_local_constant): New helper function.
24637 * statement.cs (AddConstant): Keep a separate record of constants
24639 (IsConstant): Implement to determine if a variable is a constant.
24641 (GetConstantExpression): Implement.
24643 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
24645 * statement.cs (IsVariableDefined): Re-write.
24647 2001-11-27 Ravi Pratap <ravi@ximian.com>
24649 * class.cs (TypeContainer::FindMembers): Look for constants
24650 in the case when we are looking for MemberTypes.Field
24652 * expression.cs (MemberAccess::DoResolve): Check that in the
24653 case we are a FieldExpr and a Literal, we are not being accessed
24654 by an instance reference.
24656 * cs-parser.jay (local_constant_declaration): Implement.
24658 (declaration_statement): Implement for constant declarations.
24660 2001-11-26 Miguel de Icaza <miguel@ximian.com>
24662 * statement.cs (Switch): Catch double defaults.
24664 (Switch): More work on the switch() statement
24665 implementation. It works for integral values now, need to finish
24669 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24671 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
24672 integer literals into other integer literals. To be used by
24675 2001-11-24 Ravi Pratap <ravi@ximian.com>
24677 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
24680 (EmitDynamicInitializers): Cope with the above since we extract data
24681 directly from ArrayData now.
24683 (ExpectInitializers): Keep track of whether initializers are mandatory
24686 (Bounds): Make it a hashtable to prevent the same dimension being
24687 recorded for every element in that dimension.
24689 (EmitDynamicInitializers): Fix bug which prevented the Set array method
24692 Also fix bug which was causing the indices to be emitted in the reverse
24695 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24697 * expression.cs (ArrayCreation): Implement the bits that Ravi left
24698 unfinished. They do not work, because the underlying code is
24701 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24703 * cs-parser.jay: Remove bogus fixme.
24705 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
24706 on Switch statement.
24708 2001-11-23 Ravi Pratap <ravi@ximian.com>
24710 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
24713 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
24714 parameter. Apparently, any expression is allowed.
24716 (ValidateInitializers): Update accordingly.
24718 (CheckIndices): Fix some tricky bugs thanks to recursion.
24720 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
24721 I was being completely brain-dead.
24723 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
24724 and re-write acordingly.
24726 (DelegateInvocation): Re-write accordingly.
24728 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
24730 (MakeByteBlob): Handle types more correctly.
24732 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
24733 initialization from expressions but it is incomplete because I am a complete
24736 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24738 * statement.cs (If.Emit): Fix a bug that generated incorrect code
24739 on If. Basically, we have to return `true' (ie, we do return to
24740 our caller) only if both branches of the if return.
24742 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
24743 short-circuit operators, handle them as short circuit operators.
24745 (Cast.DoResolve): Resolve type.
24746 (Cast.Cast): Take an expression as the target type.
24748 * cs-parser.jay (cast_expression): Remove old hack that only
24749 allowed a limited set of types to be handled. Now we take a
24750 unary_expression and we resolve to a type during semantic
24753 Use the grammar productions from Rhys to handle casts (this is
24754 not complete like Rhys syntax yet, we fail to handle that corner
24755 case that C# has regarding (-x), but we will get there.
24757 2001-11-22 Ravi Pratap <ravi@ximian.com>
24759 * class.cs (EmitFieldInitializer): Take care of the case when we have a
24760 field which is an array type.
24762 * cs-parser.jay (declare_local_variables): Support array initialization too.
24764 * typemanager.cs (MakeKey): Implement.
24766 (everywhere): Use the above appropriately.
24768 * cs-parser.jay (for_statement): Update for array initialization while
24769 declaring variables.
24771 * ecore.cs : The error message was correct, it's the variable's names that
24772 were misleading ;-) Make the code more readable.
24774 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
24775 the correct type etc.
24777 (ConvertExplicit): Handle Enum types by examining the underlying type.
24779 2001-11-21 Ravi Pratap <ravi@ximian.com>
24781 * parameter.cs (GetCallingConvention): Always return
24782 CallingConventions.Standard for now.
24784 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24786 * expression.cs (Binary.ResolveOperator): Update the values of `l'
24787 and `r' after calling DoNumericPromotions.
24789 * ecore.cs: Fix error message (the types were in the wrong order).
24791 * statement.cs (Foreach.ProbeCollectionType): Need to pass
24792 BindingFlags.Instance as well
24794 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
24795 implicit int literal conversion in an empty cast so that we
24796 propagate the right type upstream.
24798 (UnboxCast): new class used to unbox value types.
24799 (Expression.ConvertExplicit): Add explicit type conversions done
24802 (Expression.ImplicitNumericConversion): Oops, forgot to test for
24803 the target type before applying the implicit LongLiterals to ULong
24806 2001-11-21 Miguel de Icaza <miguel@ximian.com>
24808 * cs-parser.jay (for_statement): Reworked the way For works: now
24809 we declare manually any variables that are introduced in
24810 for_initializer to solve the problem of having out-of-band code
24811 emition (that is what got for broken).
24813 (declaration_statement): Perform the actual variable declaration
24814 that used to be done in local_variable_declaration here.
24816 (local_variable_declaration): Do not declare anything, just pass
24817 the information on a DictionaryEntry
24819 2001-11-20 Ravi Pratap <ravi@ximian.com>
24821 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
24822 re-write of the logic to now make it recursive.
24824 (UpdateIndices): Re-write accordingly.
24826 Store element data in a separate ArrayData list in the above methods.
24828 (MakeByteBlob): Implement to dump the array data into a byte array.
24830 2001-11-19 Ravi Pratap <ravi@ximian.com>
24832 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
24835 * constant.cs (Define): Implement.
24837 (EmitConstant): Re-write fully.
24839 Pass in location info.
24841 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
24844 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
24845 DictionaryEntry since we need location info too.
24847 (constant_declaration): Update accordingly.
24849 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
24850 code into another method : UpdateIndices.
24852 2001-11-18 Ravi Pratap <ravi@ximian.com>
24854 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
24855 some type checking etc.
24857 2001-11-17 Ravi Pratap <ravi@ximian.com>
24859 * expression.cs (ArrayCreation::ValidateInitializers): Implement
24860 bits to provide dimension info if the user skips doing that.
24862 Update second constructor to store the rank correctly.
24864 2001-11-16 Ravi Pratap <ravi@ximian.com>
24866 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
24867 and try to implement.
24869 * ../errors/cs0150.cs : Add.
24871 * ../errors/cs0178.cs : Add.
24873 2001-11-16 Miguel de Icaza <miguel@ximian.com>
24875 * statement.cs: Implement foreach on multi-dimensional arrays.
24877 * parameter.cs (Parameters.GetParameterByName): Also lookup the
24878 name of the params argument.
24880 * expression.cs: Use EmitStoreOpcode to get the right opcode while
24881 initializing the array.
24883 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
24884 we can use this elsewhere.
24886 * statement.cs: Finish implementation of foreach for single
24889 * cs-parser.jay: Use an out-of-band stack to pass information
24890 around, I wonder why I need this.
24892 foreach_block: Make the new foreach_block the current_block.
24894 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
24895 function used to return a static Parameters structure. Used for
24896 empty parameters, as those are created very frequently.
24898 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
24900 2001-11-15 Ravi Pratap <ravi@ximian.com>
24902 * interface.cs : Default modifier is private, not public. The
24903 make verify test passes again.
24905 2001-11-15 Ravi Pratap <ravi@ximian.com>
24907 * support.cs (ReflectionParameters): Fix logic to determine
24908 whether the last parameter is a params one. Test 9 passes again.
24910 * delegate.cs (Populate): Register the builders we define with
24911 RegisterParameterForBuilder. Test 19 passes again.
24913 * cs-parser.jay (property_declaration): Reference $6 instead
24914 of $$ to get at the location.
24916 (indexer_declaration): Similar stuff.
24918 (attribute): Ditto.
24920 * class.cs (Property): Register parameters for the Get and Set methods
24921 if they exist. Test 23 passes again.
24923 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
24924 call to EmitArguments as we are sure there aren't any params arguments.
24925 Test 32 passes again.
24927 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
24928 IndexOutOfRangeException.
24930 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
24931 Test 33 now passes again.
24933 2001-11-15 Miguel de Icaza <miguel@ximian.com>
24935 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
24936 broke a bunch of things. Will have to come up with a better way
24937 of tracking locations.
24939 * statement.cs: Implemented foreach for single dimension arrays.
24941 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24943 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
24944 an error. This removes the lookup from the critical path.
24946 * cs-parser.jay: Removed use of temporary_loc, which is completely
24949 2001-11-14 Miguel de Icaza <miguel@ximian.com>
24951 * support.cs (ReflectionParameters.ParameterModifier): Report
24952 whether the argument is a PARAMS argument or not.
24954 * class.cs: Set the attribute `ParamArrayAttribute' on the
24955 parameter argument.
24957 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
24958 and cons_param_array_attribute (ConstructorInfo for
24959 ParamArrayAttribute).,
24961 * codegen.cs: Emit the return using the `Return' statement, that
24962 way we can report the error correctly for missing return values.
24964 * class.cs (Method.Emit): Clean up.
24966 * expression.cs (Argument.Resolve): Take another argument: the
24967 location where this argument is used. Notice that this is not
24968 part of the "Argument" class as to reduce the size of the
24969 structure (we know the approximate location anyways).
24971 Test if the argument is a variable-reference, if not, then
24972 complain with a 206.
24974 (Argument.Emit): Emit addresses of variables.
24976 (Argument.FullDesc): Simplify.
24978 (Invocation.DoResolve): Update for Argument.Resolve.
24980 (ElementAccess.DoResolve): ditto.
24982 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
24983 method should be virtual, as this method is always virtual.
24985 (NewDelegate.DoResolve): Update for Argument.Resolve.
24987 * class.cs (ConstructorInitializer.DoResolve): ditto.
24989 * attribute.cs (Attribute.Resolve): ditto.
24991 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24993 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
24995 * expression.cs (ParameterReference): Drop IStackStorage and implement
24996 IAssignMethod instead.
24998 (LocalVariableReference): ditto.
25000 * ecore.cs (FieldExpr): Drop IStackStorage and implement
25001 IAssignMethod instead.
25003 2001-11-13 Miguel de Icaza <miguel@ximian.com>
25005 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
25006 enumerations that are used in heavily used structures derive from
25007 byte in a laughable and pathetic attempt to reduce memory usage.
25008 This is the kind of pre-optimzations that you should not do at
25009 home without adult supervision.
25011 * expression.cs (UnaryMutator): New class, used to handle ++ and
25012 -- separatedly from the other unary operators. Cleans up the
25013 code, and kills the ExpressionStatement dependency in Unary.
25015 (Unary): Removed `method' and `Arguments' from this class, making
25016 it smaller, and moving it all to SimpleCall, so I can reuse this
25017 code in other locations and avoid creating a lot of transient data
25018 strucutres when not required.
25020 * cs-parser.jay: Adjust for new changes.
25022 2001-11-11 Miguel de Icaza <miguel@ximian.com>
25024 * enum.cs (Enum.Populate): If there is a failure during
25027 * cs-parser.jay (opt_enum_base): we used to catch type errors
25028 here, but this is really incorrect. The type error should be
25029 catched during semantic analysis.
25031 2001-12-11 Ravi Pratap <ravi@ximian.com>
25033 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
25034 current_local_parameters as expected since I, in my stupidity, had forgotten
25037 * attribute.cs (GetValidPlaces): Fix stupid bug.
25039 * class.cs (Method::Emit): Perform check on applicability of attributes.
25041 (Constructor::Emit): Ditto.
25043 (Field::Emit): Ditto.
25045 (Field.Location): Store location information.
25047 (Property, Event, Indexer, Operator): Ditto.
25049 * cs-parser.jay (field_declaration): Pass in location for each field.
25051 * ../errors/cs0592.cs : Add.
25053 2001-11-12 Ravi Pratap <ravi@ximian.com>
25055 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
25057 (InitCoreTypes): Update accordingly.
25059 (RegisterAttrType, LookupAttr): Implement.
25061 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
25062 info about the same.
25064 (Resolve): Update to populate the above as necessary.
25066 (Error592): Helper.
25068 (GetValidPlaces): Helper to the above.
25070 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
25072 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
25074 2001-11-12 Ravi Pratap <ravi@ximian.com>
25076 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
25078 * ../errors/cs0617.cs : Add.
25080 2001-11-11 Ravi Pratap <ravi@ximian.com>
25082 * enum.cs (Emit): Rename to Populate to be more consistent with what
25083 we expect it to do and when exactly it is called.
25085 * class.cs, rootcontext.cs : Update accordingly.
25087 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
25088 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
25090 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
25092 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
25093 of a fieldinfo using the above, when dealing with a FieldBuilder.
25095 2001-11-10 Ravi Pratap <ravi@ximian.com>
25097 * ../errors/cs0031.cs : Add.
25099 * ../errors/cs1008.cs : Add.
25101 * ../errrors/cs0543.cs : Add.
25103 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
25106 (FindMembers): Implement.
25108 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
25109 enums and delegates too.
25111 (enum_types): Rename to builder_to_enum.
25113 (delegate_types): Rename to builder_to_delegate.
25115 * delegate.cs (FindMembers): Implement.
25117 2001-11-09 Ravi Pratap <ravi@ximian.com>
25119 * typemanager.cs (IsEnumType): Implement.
25121 * enum.cs (Emit): Re-write parts to account for the underlying type
25122 better and perform checking etc.
25124 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
25125 of the underlying type.
25127 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
25130 * enum.cs (error31): Helper to report error #31.
25132 * cs-parser.jay (enum_declaration): Store location of each member too.
25134 * enum.cs (member_to_location): New hashtable.
25136 (AddEnumMember): Update location hashtable.
25138 (Emit): Use the location of each member while reporting errors.
25140 2001-11-09 Miguel de Icaza <miguel@ximian.com>
25142 * cs-parser.jay: A for_initializer if is a
25143 local_variable_declaration really ammount to have an implicit
25144 block with the variable declaration and no initializer for for.
25146 * statement.cs (For.Emit): Cope with null initializers.
25148 This fixes the infinite loop on for initializers.
25150 2001-11-08 Miguel de Icaza <miguel@ximian.com>
25152 * enum.cs: More cleanup.
25154 * ecore.cs: Remove dead code.
25156 * class.cs (Property.Emit): More simplification.
25157 (Event.Emit): ditto.
25159 Reworked to have less levels of indentation.
25161 2001-11-08 Ravi Pratap <ravi@ximian.com>
25163 * class.cs (Property): Emit attributes.
25173 * enum.cs (Emit): Ditto.
25175 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
25178 * class.cs (Field, Event, etc.): Move attribute generation into the
25179 Emit method everywhere.
25181 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
25182 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
25183 as we had no way of defining nested enums !
25185 * rootcontext.cs : Adjust code accordingly.
25187 * typemanager.cs (AddEnumType): To keep track of enum types separately.
25189 2001-11-07 Ravi Pratap <ravi@ximian.com>
25191 * expression.cs (EvalConstantExpression): Move into ecore.cs
25193 * enum.cs (Enum): Rename some members and make them public and readonly
25194 according to our convention.
25196 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
25199 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
25201 (Enum::Emit): Write a simple version for now which doesn't try to compute
25202 expressions. I shall modify this to be more robust in just a while.
25204 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
25206 (TypeContainer::CloseType): Create the Enum types too.
25208 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
25210 * expression.cs (EvalConstantExpression): Get rid of completely.
25212 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
25213 user-defined values and other cases.
25215 (IsValidEnumLiteral): Helper function.
25217 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
25218 out there in the case we had a literal FieldExpr.
25220 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
25222 (Literalize): Revamp a bit to take two arguments.
25224 (EnumLiteral): New class which derives from Literal to wrap enum literals.
25226 2001-11-06 Ravi Pratap <ravi@ximian.com>
25228 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
25230 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
25232 (Resolve): Use the above to ensure we have proper initializers.
25234 2001-11-05 Ravi Pratap <ravi@ximian.com>
25236 * expression.cs (Expression::EvalConstantExpression): New method to
25237 evaluate constant expressions.
25239 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
25241 2001-11-07 Miguel de Icaza <miguel@ximian.com>
25243 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
25246 (Binary.ResolveOperator): Handle operator != (object a, object b)
25247 and operator == (object a, object b);
25249 (Binary.DoNumericPromotions): Indicate whether the numeric
25250 promotion was possible.
25252 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
25255 Made the ArrayAccess implement interface IAssignMethod instead of
25256 IStackStore as the order in which arguments are passed reflects
25259 * assign.cs: Instead of using expr.ExprClass to select the way of
25260 assinging, probe for the IStackStore/IAssignMethod interfaces.
25262 * typemanager.cs: Load InitializeArray definition.
25264 * rootcontext.cs (RootContext.MakeStaticData): Used to define
25265 static data that can be used to initialize arrays.
25267 2001-11-05 Miguel de Icaza <miguel@ximian.com>
25269 * expression.cs: Handle operator== and operator!= for booleans.
25271 (Conditioal.Reduce): Implement reducer for the ?: operator.
25273 (Conditional.Resolve): Implement dead code elimination.
25275 (Binary.Resolve): Catch string literals and return a new
25276 concatenated string.
25278 (Unary.Reduce): Implement reduction of unary expressions.
25280 * ecore.cs: Split out the expression core handling here.
25282 (Expression.Reduce): New method used to perform constant folding
25283 and CSE. This is needed to support constant-expressions.
25285 * statement.cs (Statement.EmitBoolExpression): Pass true and false
25286 targets, and optimize for !x.
25288 2001-11-04 Ravi Pratap <ravi@ximian.com>
25290 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
25291 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
25292 set custom atttributes.
25294 * literal.cs (Literal::GetValue): New abstract method to return the actual
25295 value of the literal, cast as an object.
25297 (*Literal): Implement GetValue method.
25299 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
25300 expressions to the arraylist but objects of type Argument.
25302 * class.cs (TypeContainer::Emit): Emit our attributes too.
25304 (Method::Emit, Constructor::Emit): Ditto.
25306 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
25307 to be ignoring earlier.
25309 2001-11-03 Ravi Pratap <ravi@ximian.com>
25311 * attribute.cs (AttributeSection::Define): Implement to do the business
25312 of constructing a CustomAttributeBuilder.
25314 (Attribute): New trivial class. Increases readability of code.
25316 * cs-parser.jay : Update accordingly.
25318 (positional_argument_list, named_argument_list, named_argument): New rules
25320 (attribute_arguments): Use the above so that we are more correct.
25322 2001-11-02 Ravi Pratap <ravi@ximian.com>
25324 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
25325 to perform all checks for a method with a params parameter.
25327 (Invocation::OverloadResolve): Update to use the above method and therefore
25328 cope correctly with params method invocations.
25330 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
25333 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
25334 constructors in our parent too because we can't afford to miss out on
25337 * attribute.cs (AttributeSection): New name for the class Attribute
25339 Other trivial changes to improve readability.
25341 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
25342 use the new class names.
25344 2001-11-01 Ravi Pratap <ravi@ximian.com>
25346 * class.cs (Method::Define): Complete definition for params types too
25348 (Indexer::Define): Ditto.
25350 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
25351 Cope everywhere with a request for info about the array parameter.
25353 2001-11-01 Ravi Pratap <ravi@ximian.com>
25355 * tree.cs (RecordNamespace): Fix up to check for the correct key.
25357 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
25358 local_variable_type to extract the string corresponding to the type.
25360 (local_variable_type): Fixup the action to use the new helper method.
25362 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
25365 * expression.cs : Clean out code which uses the above.
25367 2001-10-31 Ravi Pratap <ravi@ximian.com>
25369 * typemanager.cs (RegisterMethod): Check if we already have an existing key
25370 and bale out if necessary by returning a false.
25372 (RegisterProperty): Ditto.
25374 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
25375 and print out appropriate error messages.
25377 * interface.cs (everywhere): Ditto.
25379 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
25380 location to constructor.
25382 * class.cs (Property, Event, Indexer): Update accordingly.
25384 * ../errors/cs111.cs : Added.
25386 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
25387 of a method, as laid down by the spec.
25389 (Invocation::OverloadResolve): Use the above method.
25391 2001-10-31 Ravi Pratap <ravi@ximian.com>
25393 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
25394 now take a TypeContainer and a Parameters object.
25396 (ParameterData): Modify return type of ParameterModifier method to be
25397 Parameter.Modifier and not a string.
25399 (ReflectionParameters, InternalParameters): Update accordingly.
25401 * expression.cs (Argument::GetParameterModifier): Same here.
25403 * support.cs (InternalParameters::ParameterType): Find a better way of determining
25404 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
25405 symbol in it at all so maybe this is only for now.
25407 2001-10-30 Ravi Pratap <ravi@ximian.com>
25409 * support.cs (InternalParameters): Constructor now takes an extra argument
25410 which is the actual Parameters class.
25412 (ParameterDesc): Update to provide info on ref/out modifiers.
25414 * class.cs (everywhere): Update call to InternalParameters to pass in
25415 the second argument too.
25417 * support.cs (ParameterData): Add ParameterModifier, which is a method
25418 to return the modifier info [ref/out etc]
25420 (InternalParameters, ReflectionParameters): Implement the above.
25422 * expression.cs (Argument::ParameterModifier): Similar function to return
25423 info about the argument's modifiers.
25425 (Invocation::OverloadResolve): Update to take into account matching modifiers
25428 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
25429 a new SetFormalParameters object which we pass to InternalParameters.
25431 2001-10-30 Ravi Pratap <ravi@ximian.com>
25433 * expression.cs (NewArray): Merge into the ArrayCreation class.
25435 2001-10-29 Ravi Pratap <ravi@ximian.com>
25437 * expression.cs (NewArray): Merge classes NewBuiltinArray and
25438 NewUserdefinedArray into one as there wasn't much of a use in having
25441 * expression.cs (Argument): Change field's name to ArgType from Type.
25443 (Type): New readonly property which returns the proper type, taking into
25444 account ref/out modifiers.
25446 (everywhere): Adjust code accordingly for the above.
25448 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
25449 whether we are emitting for a ref or out parameter.
25451 * expression.cs (Argument::Emit): Use the above field to set the state.
25453 (LocalVariableReference::Emit): Update to honour the flag and emit the
25456 * parameter.cs (Attributes): Set the correct flags for ref parameters.
25458 * expression.cs (Argument::FullDesc): New function to provide a full desc.
25460 * support.cs (ParameterData): Add method ParameterDesc to the interface.
25462 (ReflectionParameters, InternalParameters): Implement the above method.
25464 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
25467 (Invocation::FullMethodDesc): Ditto.
25469 2001-10-29 Miguel de Icaza <miguel@ximian.com>
25471 * cs-parser.jay: Add extra production for the second form of array
25474 * expression.cs (ArrayCreation): Update to reflect the above
25477 * Small changes to prepare for Array initialization.
25479 2001-10-28 Miguel de Icaza <miguel@ximian.com>
25481 * typemanager.cs (ImplementsInterface): interface might be null;
25482 Deal with this problem;
25484 Also, we do store negative hits on the cache (null values), so use
25485 this instead of calling t.GetInterfaces on the type everytime.
25487 2001-10-28 Ravi Pratap <ravi@ximian.com>
25489 * typemanager.cs (IsBuiltinType): New method to help determine the same.
25491 * expression.cs (New::DoResolve): Get rid of array creation code and instead
25492 split functionality out into different classes.
25494 (New::FormArrayType): Move into NewBuiltinArray.
25496 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
25499 (NewBuiltinArray): New class to handle creation of built-in arrays.
25501 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
25502 account creation of one-dimensional arrays.
25504 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
25506 (NewUserdefinedArray::DoResolve): Implement.
25508 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
25510 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
25511 we maintain inside the TypeManager. This is necessary to perform lookups on the
25514 (LookupType): Update to perform GetType on the module builders too.
25516 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
25518 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
25520 2001-10-23 Ravi Pratap <ravi@ximian.com>
25522 * expression.cs (New::DoResolve): Implement guts of array creation.
25524 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
25526 2001-10-27 Miguel de Icaza <miguel@ximian.com>
25528 * expression.cs: Fix bug I introduced lsat night that broke
25531 (Expression.Resolve): Report a 246 error (can not resolve name)
25532 if we find a SimpleName in the stream.
25534 (Expression.ResolveLValue): Ditto.
25536 (Expression.ResolveWithSimpleName): This function is a variant of
25537 ResolveName, this one allows SimpleNames to be returned without a
25538 warning. The only consumer of SimpleNames is MemberAccess
25540 2001-10-26 Miguel de Icaza <miguel@ximian.com>
25542 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
25543 might arrive here. I have my doubts that this is correct.
25545 * statement.cs (Lock): Implement lock statement.
25547 * cs-parser.jay: Small fixes to support `lock' and `using'
25549 * cs-tokenizer.cs: Remove extra space
25551 * driver.cs: New flag --checked, allows to turn on integer math
25554 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
25555 Threading.Monitor.Exit
25557 2001-10-23 Miguel de Icaza <miguel@ximian.com>
25559 * expression.cs (IndexerAccess::DoResolveLValue): Set the
25560 Expression Class to be IndexerAccess.
25562 Notice that Indexer::DoResolve sets the eclass to Value.
25564 2001-10-22 Miguel de Icaza <miguel@ximian.com>
25566 * class.cs (TypeContainer::Emit): Emit code for indexers.
25568 * assign.cs (IAssignMethod): New interface implemented by Indexers
25569 and Properties for handling assignment.
25571 (Assign::Emit): Simplify and reuse code.
25573 * expression.cs (IndexerAccess, PropertyExpr): Implement
25574 IAssignMethod, clean up old code.
25576 2001-10-22 Ravi Pratap <ravi@ximian.com>
25578 * typemanager.cs (ImplementsInterface): New method to determine if a type
25579 implements a given interface. Provides a nice cache too.
25581 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
25584 (ConvertReferenceExplicit): Ditto.
25586 * delegate.cs (Delegate::Populate): Update to define the parameters on the
25587 various methods, with correct names etc.
25589 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
25590 Operator.UnaryNegation.
25592 * cs-parser.jay (operator_declarator): Be a little clever in the case where
25593 we have a unary plus or minus operator.
25595 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
25598 * everywhere : update accordingly.
25600 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
25603 * class.cs (Method::Define): For the case where we are implementing a method
25604 inherited from an interface, we need to set the MethodAttributes.Final flag too.
25605 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
25607 2001-10-21 Ravi Pratap <ravi@ximian.com>
25609 * interface.cs (FindMembers): Implement to work around S.R.E
25612 * typemanager.cs (IsInterfaceType): Implement.
25614 (FindMembers): Update to handle interface types too.
25616 * expression.cs (ImplicitReferenceConversion): Re-write bits which
25617 use IsAssignableFrom as that is not correct - it doesn't work.
25619 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
25620 and accordingly override EmitStatement.
25622 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
25623 using the correct logic :-)
25625 2001-10-19 Ravi Pratap <ravi@ximian.com>
25627 * ../errors/cs-11.cs : Add to demonstrate error -11
25629 2001-10-17 Miguel de Icaza <miguel@ximian.com>
25631 * assign.cs (Assign::Resolve): Resolve right hand side first, and
25632 then pass this as a hint to ResolveLValue.
25634 * expression.cs (FieldExpr): Add Location information
25636 (FieldExpr::LValueResolve): Report assignment to readonly
25639 (Expression::ExprClassFromMemberInfo): Pass location information.
25641 (Expression::ResolveLValue): Add new method that resolves an
25644 (Expression::DoResolveLValue): Default invocation calls
25647 (Indexers): New class used to keep track of indexers in a given
25650 (IStackStore): Renamed from LValue, as it did not really describe
25651 what this did. Also ResolveLValue is gone from this interface and
25652 now is part of Expression.
25654 (ElementAccess): Depending on the element access type
25656 * typemanager.cs: Add `indexer_name_type' as a Core type
25657 (System.Runtime.CompilerServices.IndexerNameAttribute)
25659 * statement.cs (Goto): Take a location.
25661 2001-10-18 Ravi Pratap <ravi@ximian.com>
25663 * delegate.cs (Delegate::VerifyDelegate): New method to verify
25664 if two delegates are compatible.
25666 (NewDelegate::DoResolve): Update to take care of the case when
25667 we instantiate a delegate from another delegate.
25669 * typemanager.cs (FindMembers): Don't even try to look up members
25670 of Delegate types for now.
25672 2001-10-18 Ravi Pratap <ravi@ximian.com>
25674 * delegate.cs (NewDelegate): New class to take care of delegate
25677 * expression.cs (New): Split the delegate related code out into
25678 the NewDelegate class.
25680 * delegate.cs (DelegateInvocation): New class to handle delegate
25683 * expression.cs (Invocation): Split out delegate related code into
25684 the DelegateInvocation class.
25686 2001-10-17 Ravi Pratap <ravi@ximian.com>
25688 * expression.cs (New::DoResolve): Implement delegate creation fully
25689 and according to the spec.
25691 (New::DoEmit): Update to handle delegates differently.
25693 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
25694 because of which we were printing out arguments in reverse order !
25696 * delegate.cs (VerifyMethod): Implement to check if the given method
25697 matches the delegate.
25699 (FullDelegateDesc): Implement.
25701 (VerifyApplicability): Implement.
25703 * expression.cs (Invocation::DoResolve): Update to accordingly handle
25704 delegate invocations too.
25706 (Invocation::Emit): Ditto.
25708 * ../errors/cs1593.cs : Added.
25710 * ../errors/cs1594.cs : Added.
25712 * delegate.cs (InstanceExpression, TargetMethod): New properties.
25714 2001-10-16 Ravi Pratap <ravi@ximian.com>
25716 * typemanager.cs (intptr_type): Core type for System.IntPtr
25718 (InitCoreTypes): Update for the same.
25720 (iasyncresult_type, asynccallback_type): Ditto.
25722 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
25725 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
25728 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
25729 the builders for the 4 members of a delegate type :-)
25731 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
25734 * expression.cs (New::DoResolve): Implement guts for delegate creation.
25736 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
25738 2001-10-15 Miguel de Icaza <miguel@ximian.com>
25740 * statement.cs (Break::Emit): Implement.
25741 (Continue::Emit): Implement.
25743 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
25744 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
25745 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
25746 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
25749 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
25750 properties that track the label for the current loop (begin of the
25751 loop and end of the loop).
25753 2001-10-15 Ravi Pratap <ravi@ximian.com>
25755 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
25756 use of emitting anything at all.
25758 * class.cs, rootcontext.cs : Get rid of calls to the same.
25760 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
25762 (Populate): Define the constructor correctly and set the implementation
25765 * typemanager.cs (delegate_types): New hashtable to hold delegates that
25768 (AddDelegateType): Implement.
25770 (IsDelegateType): Implement helper method.
25772 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
25774 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
25775 and accordingly handle it.
25777 * delegate.cs (Populate): Take TypeContainer argument.
25778 Implement bits to define the Invoke method. However, I still haven't figured out
25779 how to take care of the native int bit :-(
25781 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
25782 Qualify the name of the delegate, not its return type !
25784 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
25787 (StandardConversionExists): Checking for array types turns out to be recursive.
25789 (ConvertReferenceExplicit): Implement array conversion.
25791 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
25793 2001-10-12 Ravi Pratap <ravi@ximian.com>
25795 * cs-parser.jay (delegate_declaration): Store the fully qualified
25796 name as it is a type declaration.
25798 * delegate.cs (ReturnType, Name): Rename members to these. Make them
25801 (DefineDelegate): Renamed from Define. Does the same thing essentially,
25802 as TypeContainer::DefineType.
25804 (Populate): Method in which all the definition of the various methods (Invoke)
25807 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
25810 (CloseDelegate): Finally creates the delegate.
25812 * class.cs (TypeContainer::DefineType): Update to define delegates.
25813 (Populate, Emit and CloseType): Do the same thing here too.
25815 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
25816 delegates in all these operations.
25818 2001-10-14 Miguel de Icaza <miguel@ximian.com>
25820 * expression.cs: LocalTemporary: a new expression used to
25821 reference a temporary that has been created.
25823 * assign.cs: Handle PropertyAccess back here, so that we can
25824 provide the proper semantic access to properties.
25826 * expression.cs (Expression::ConvertReferenceExplicit): Implement
25827 a few more explicit conversions.
25829 * modifiers.cs: `NEW' modifier maps to HideBySig.
25831 * expression.cs (PropertyExpr): Make this into an
25832 ExpressionStatement, and support the EmitStatement code path.
25834 Perform get/set error checking, clean up the interface.
25836 * assign.cs: recognize PropertyExprs as targets, and if so, turn
25837 them into toplevel access objects.
25839 2001-10-12 Miguel de Icaza <miguel@ximian.com>
25841 * expression.cs: PropertyExpr::PropertyExpr: use work around the
25844 * typemanager.cs: Keep track here of our PropertyBuilders again to
25845 work around lameness in SRE.
25847 2001-10-11 Miguel de Icaza <miguel@ximian.com>
25849 * expression.cs (LValue::LValueResolve): New method in the
25850 interface, used to perform a second resolution pass for LValues.
25852 (This::DoResolve): Catch the use of this in static methods.
25854 (This::LValueResolve): Implement.
25856 (This::Store): Remove warning, assigning to `this' in structures
25859 (Invocation::Emit): Deal with invocation of
25860 methods on value types. We need to pass the address to structure
25861 methods rather than the object itself. (The equivalent code to
25862 emit "this" for structures leaves the entire structure on the
25863 stack instead of a pointer to it).
25865 (ParameterReference::DoResolve): Compute the real index for the
25866 argument based on whether the method takes or not a `this' pointer
25867 (ie, the method is static).
25869 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
25870 value types returned from functions when we need to invoke a
25871 method on the sturcture.
25874 2001-10-11 Ravi Pratap <ravi@ximian.com>
25876 * class.cs (TypeContainer::DefineType): Method to actually do the business of
25877 defining the type in the Modulebuilder or Typebuilder. This is to take
25878 care of nested types which need to be defined on the TypeBuilder using
25879 DefineNestedMethod.
25881 (TypeContainer::GetClassBases): Implement. Essentially the code from the
25882 methods in RootContext, only ported to be part of TypeContainer.
25884 (TypeContainer::GetInterfaceOrClass): Ditto.
25886 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
25888 * interface.cs (Interface::DefineInterface): New method. Does exactly
25889 what RootContext.CreateInterface did earlier, only it takes care of nested types
25892 (Interface::GetInterfaces): Move from RootContext here and port.
25894 (Interface::GetInterfaceByName): Same here.
25896 * rootcontext.cs (ResolveTree): Re-write.
25898 (PopulateTypes): Re-write.
25900 * class.cs (TypeContainer::Populate): Populate nested types too.
25901 (TypeContainer::Emit): Emit nested members too.
25903 * typemanager.cs (AddUserType): Do not make use of the FullName property,
25904 instead just use the name argument passed in as it is already fully
25907 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
25908 to TypeContainer mapping to see if a type is user-defined.
25910 * class.cs (TypeContainer::CloseType): Implement.
25912 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
25913 the default constructor.
25915 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
25918 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
25920 * interface.cs (CloseType): Create the type here.
25922 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
25925 Remove all the methods which are now in TypeContainer.
25927 2001-10-10 Ravi Pratap <ravi@ximian.com>
25929 * delegate.cs (Define): Re-write bits to define the delegate
25932 2001-10-10 Miguel de Icaza <miguel@ximian.com>
25934 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
25936 * expression.cs (ImplicitReferenceConversion): handle null as well
25937 as a source to convert to any reference type.
25939 * statement.cs (Return): Perform any implicit conversions to
25940 expected return type.
25942 Validate use of return statement.
25944 * codegen.cs (EmitContext): Pass the expected return type here.
25946 * class.cs (Method, Constructor, Property): Pass expected return
25947 type to EmitContext.
25949 2001-10-09 Miguel de Icaza <miguel@ximian.com>
25951 * expression.cs: Make DoResolve take an EmitContext instead of a
25954 Replaced `l' and `location' for `loc', for consistency.
25956 (Error, Warning): Remove unneeded Tc argument.
25958 * assign.cs, literal.cs, constant.cs: Update to new calling
25961 * codegen.cs: EmitContext now contains a flag indicating whether
25962 code is being generated in a static method or not.
25964 * cs-parser.jay: DecomposeQI, new function that replaces the old
25965 QualifiedIdentifier. Now we always decompose the assembled
25966 strings from qualified_identifier productions into a group of
25969 2001-10-08 Miguel de Icaza <miguel@ximian.com>
25971 * rootcontext.cs: Deal with field-less struct types correctly now
25972 by passing the size option to Define Type.
25974 * class.cs: Removed hack that created one static field.
25976 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25978 * statement.cs: Moved most of the code generation here.
25980 2001-10-09 Ravi Pratap <ravi@ximian.com>
25982 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
25985 (ElementAccess): Remove useless bits for now - keep checks as the spec
25988 2001-10-08 Ravi Pratap <ravi@ximian.com>
25990 * expression.cs (ElementAccess::DoResolve): Remove my crap code
25991 and start performing checks according to the spec.
25993 2001-10-07 Ravi Pratap <ravi@ximian.com>
25995 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
25996 rank_specifiers instead.
25998 (rank_specifiers): Change the order in which the rank specifiers are stored
26000 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
26002 * expression.cs (ElementAccess): Implement the LValue interface too.
26004 2001-10-06 Ravi Pratap <ravi@ximian.com>
26006 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
26007 except that user defined conversions are not included.
26009 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
26010 perform the conversion of the return type, if necessary.
26012 (New::DoResolve): Check whether we are creating an array or an object
26013 and accordingly do the needful.
26015 (New::Emit): Same here.
26017 (New::DoResolve): Implement guts of array creation.
26019 (New::FormLookupType): Helper function.
26021 2001-10-07 Miguel de Icaza <miguel@ximian.com>
26023 * codegen.cs: Removed most of the code generation here, and move the
26024 corresponding code generation bits to the statement classes.
26026 Added support for try/catch/finalize and throw.
26028 * cs-parser.jay: Added support for try/catch/finalize.
26030 * class.cs: Catch static methods having the flags override,
26031 virtual or abstract.
26033 * expression.cs (UserCast): This user cast was not really doing
26034 what it was supposed to do. Which is to be born in fully resolved
26035 state. Parts of the resolution were being performed at Emit time!
26039 2001-10-05 Miguel de Icaza <miguel@ximian.com>
26041 * expression.cs: Implicity convert the result from UserCast.
26043 2001-10-05 Ravi Pratap <ravi@ximian.com>
26045 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
26046 prevented it from working correctly.
26048 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
26049 merely ConvertImplicit.
26051 2001-10-05 Miguel de Icaza <miguel@ximian.com>
26053 * typemanager.cs: Make the LookupTypeContainer function static,
26054 and not per-instance.
26056 * class.cs: Make static FindMembers (the one that takes a Type
26059 * codegen.cs: Add EmitForeach here.
26061 * cs-parser.jay: Make foreach a toplevel object instead of the
26062 inline expansion, as we need to perform semantic analysis on it.
26064 2001-10-05 Ravi Pratap <ravi@ximian.com>
26066 * expression.cs (Expression::ImplicitUserConversion): Rename to
26067 UserDefinedConversion.
26069 (Expression::UserDefinedConversion): Take an extra argument specifying
26070 whether we look for explicit user conversions too.
26072 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
26074 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
26076 (ExplicitUserConversion): Make it a call to UserDefinedConversion
26077 with the appropriate arguments.
26079 * cs-parser.jay (cast_expression): Record location too.
26081 * expression.cs (Cast): Record location info.
26083 (Expression::ConvertExplicit): Take location argument.
26085 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
26086 to determine if we are doing explicit conversions.
26088 (UserCast::Emit): Update accordingly.
26090 (Expression::ConvertExplicit): Report an error if everything fails.
26092 * ../errors/cs0030.cs : Add.
26094 2001-10-04 Miguel de Icaza <miguel@ximian.com>
26096 * modifiers.cs: If the ABSTRACT keyword is present, also set the
26097 virtual and newslot bits.
26099 * class.cs (TypeContainer::RegisterRequiredImplementations):
26100 Record methods we need.
26102 (TypeContainer::MakeKey): Helper function to make keys for
26103 MethodBases, since the Methodbase key is useless.
26105 (TypeContainer::Populate): Call RegisterRequiredImplementations
26106 before defining the methods.
26108 Create a mapping for method_builders_to_methods ahead of time
26109 instead of inside a tight loop.
26111 (::RequireMethods): Accept an object as the data to set into the
26112 hashtable so we can report interface vs abstract method mismatch.
26114 2001-10-03 Miguel de Icaza <miguel@ximian.com>
26116 * report.cs: Make all of it static.
26118 * rootcontext.cs: Drop object_type and value_type computations, as
26119 we have those in the TypeManager anyways.
26121 Drop report instance variable too, now it is a global.
26123 * driver.cs: Use try/catch on command line handling.
26125 Add --probe option to debug the error reporting system with a test
26128 * report.cs: Add support for exiting program when a probe
26129 condition is reached.
26131 2001-10-03 Ravi Pratap <ravi@ximian.com>
26133 * expression.cs (Binary::DoNumericPromotions): Fix the case when
26134 we do a forcible conversion regardless of type, to check if
26135 ForceConversion returns a null.
26137 (Binary::error19): Use location to report error.
26139 (Unary::error23): Use location here too.
26141 * ../errors/cs0019.cs : Check in.
26143 * ../errors/cs0023.cs : Check in.
26145 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
26146 case of a non-null MethodInfo object with a length of 0 !
26148 (Binary::ResolveOperator): Flag error if overload resolution fails to find
26149 an applicable member - according to the spec :-)
26150 Also fix logic to find members in base types.
26152 (Unary::ResolveOperator): Same here.
26154 (Unary::report23): Change name to error23 and make first argument a TypeContainer
26155 as I was getting thoroughly confused between this and error19 :-)
26157 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
26158 (::FindMostEncompassedType): Implement.
26159 (::FindMostEncompassingType): Implement.
26160 (::StandardConversionExists): Implement.
26162 (UserImplicitCast): Re-vamp. We now need info about most specific
26163 source and target types so that we can do the necessary conversions.
26165 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
26166 mathematical union with no duplicates.
26168 2001-10-03 Miguel de Icaza <miguel@ximian.com>
26170 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
26171 in order from base classes to child classes, so that we can in
26172 child classes look up in our parent for method names and
26173 attributes (required for handling abstract, virtual, new, override
26174 constructs: we need to instrospect our base class, and if we dont
26175 populate the classes in order, the introspection might be
26176 incorrect. For example, a method could query its parent before
26177 the parent has any methods and would determine that the parent has
26178 no abstract methods (while it could have had them)).
26180 (RootContext::CreateType): Record the order in which we define the
26183 2001-10-02 Miguel de Icaza <miguel@ximian.com>
26185 * class.cs (TypeContainer::Populate): Also method definitions can
26186 fail now, keep track of this.
26188 (TypeContainer::FindMembers): Implement support for
26189 DeclaredOnly/noDeclaredOnly flag.
26191 (Constructor::Emit) Return the ConstructorBuilder.
26193 (Method::Emit) Return the MethodBuilder.
26194 Check for abstract or virtual methods to be public.
26196 * rootcontext.cs (RootContext::CreateType): Register all the
26197 abstract methods required for the class to be complete and the
26198 interface methods that must be implemented.
26200 * cs-parser.jay: Report error 501 (method requires body if it is
26201 not marked abstract or extern).
26203 * expression.cs (TypeOf::Emit): Implement.
26205 * typemanager.cs: runtime_handle_type, new global type.
26207 * class.cs (Property::Emit): Generate code for properties.
26209 2001-10-02 Ravi Pratap <ravi@ximian.com>
26211 * expression.cs (Unary::ResolveOperator): Find operators on base type
26212 too - we now conform exactly to the spec.
26214 (Binary::ResolveOperator): Same here.
26216 * class.cs (Operator::Define): Fix minor quirk in the tests.
26218 * ../errors/cs0215.cs : Added.
26220 * ../errors/cs0556.cs : Added.
26222 * ../errors/cs0555.cs : Added.
26224 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26226 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
26227 single integer which is really efficient
26229 2001-10-01 Ravi Pratap <ravi@ximian.com>
26231 * expression.cs (Expression::ImplicitUserConversion): Use location
26232 even in the case when we are examining True operators.
26234 * class.cs (Operator::Define): Perform extensive checks to conform
26235 with the rules for operator overloading in the spec.
26237 * expression.cs (Expression::ImplicitReferenceConversion): Implement
26238 some of the other conversions mentioned in the spec.
26240 * typemanager.cs (array_type): New static member for the System.Array built-in
26243 (cloneable_interface): For System.ICloneable interface.
26245 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
26246 we start resolving the tree and populating types.
26248 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
26250 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26252 * expression.cs (Expression::ExprClassFromMemberInfo,
26253 Expression::Literalize): Create literal expressions from
26254 FieldInfos which are literals.
26256 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
26257 type casts, because they were wrong. The test suite in tests
26260 (ImplicitNumericConversion): ushort to ulong requires a widening
26263 Int32 constant to long requires widening cast as well.
26265 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
26266 for integers because the type on the stack is not i4.
26268 2001-09-30 Miguel de Icaza <miguel@ximian.com>
26270 * expression.cs (report118): require location argument.
26272 * parameter.cs: Do not dereference potential null value.
26274 * class.cs: Catch methods that lack the `new' keyword when
26275 overriding a name. Report warnings when `new' is used without
26276 anything being there to override.
26278 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
26280 * class.cs: Only add constructor to hashtable if it is non-null
26281 (as now constructors can fail on define).
26283 (TypeManager, Class, Struct): Take location arguments.
26285 Catch field instance initialization in structs as errors.
26287 accepting_filter: a new filter for FindMembers that is static so
26288 that we dont create an instance per invocation.
26290 (Constructor::Define): Catch errors where a struct constructor is
26293 * cs-parser.jay: Pass location information for various new
26296 * delegate.cs (Delegate): take a location argument.
26298 * driver.cs: Do not call EmitCode if there were problesm in the
26299 Definition of the types, as many Builders wont be there.
26301 * decl.cs (Decl::Decl): Require a location argument.
26303 * cs-tokenizer.cs: Handle properly hex constants that can not fit
26304 into integers, and find the most appropiate integer for it.
26306 * literal.cs: Implement ULongLiteral.
26308 * rootcontext.cs: Provide better information about the location of
26309 failure when CreateType fails.
26311 2001-09-29 Miguel de Icaza <miguel@ximian.com>
26313 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
26316 * expression.cs (Binary::CheckShiftArguments): Add missing type
26318 (Binary::ResolveOperator): Add type to the logical and and logical
26319 or, Bitwise And/Or and Exclusive Or code paths, it was missing
26322 (Binary::DoNumericPromotions): In the case where either argument
26323 is ulong (and most signed types combined with ulong cause an
26324 error) perform implicit integer constant conversions as well.
26326 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26328 * expression.cs (UserImplicitCast): Method should always be
26330 (Invocation::BetterConversion): Simplified test for IntLiteral.
26332 (Expression::ImplicitNumericConversion): Split this routine out.
26333 Put the code that performs implicit constant integer conversions
26336 (Expression::Resolve): Become a wrapper around DoResolve so we can
26337 check eclass and type being set after resolve.
26339 (Invocation::Badness): Remove this dead function
26341 (Binary::ResolveOperator): Do not compute the expensive argumnets
26342 unless we have a union for it.
26344 (Probe::Emit): Is needs to do an isinst and then
26345 compare against null.
26347 (::CanConvert): Added Location argument. If the Location argument
26348 is null (Location.Null), then we do not report errors. This is
26349 used by the `probe' mechanism of the Explicit conversion. We do
26350 not want to generate an error for something that the user
26351 explicitly requested to be casted. But the pipeline for an
26352 explicit cast first tests for potential implicit casts.
26354 So for now, if the Location is null, it means `Probe only' to
26355 avoid adding another argument. Might have to revise this
26358 (ClassCast): New class used to type cast objects into arbitrary
26359 classes (used in Explicit Reference Conversions).
26361 Implement `as' as well.
26363 Reverted all the patches from Ravi below: they were broken:
26365 * The use of `level' as a mechanism to stop recursive
26366 invocations is wrong. That was there just to catch the
26367 bug with a strack trace but not as a way of addressing
26370 To fix the problem we have to *understand* what is going
26371 on and the interactions and come up with a plan, not
26372 just get things going.
26374 * The use of the type conversion cache that I proposed
26375 last night had an open topic: How does this work across
26376 protection domains. A user defined conversion might not
26377 be public in the location where we are applying the
26378 conversion, a different conversion might be selected
26379 (ie, private A->B (better) but public B->A (worse),
26380 inside A, A->B applies, but outside it, B->A will
26383 * On top of that (ie, even if the above is solved),
26384 conversions in a cache need to be abstract. Ie, `To
26385 convert from an Int to a Short use an OpcodeCast', not
26386 `To convert from an Int to a Short use the OpcodeCast on
26387 the variable 5' (which is what this patch was doing).
26389 2001-09-28 Ravi Pratap <ravi@ximian.com>
26391 * expression.cs (Invocation::ConversionExists): Re-write to use
26392 the conversion cache
26394 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
26395 cache all conversions done, not just user-defined ones.
26397 (Invocation::BetterConversion): The real culprit. Use ConversionExists
26398 to determine if a conversion exists instead of acutually trying to
26399 perform the conversion. It's faster too.
26401 (Expression::ConvertExplicit): Modify to use ConversionExists to check
26402 and only then attempt the implicit conversion.
26404 2001-09-28 Ravi Pratap <ravi@ximian.com>
26406 * expression.cs (ConvertImplicit): Use a cache for conversions
26407 already found. Check level of recursion and bail out if necessary.
26409 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26411 * typemanager.cs (string_concat_string_string, string_concat_object_object):
26412 Export standard methods that we expect for string operations.
26414 * statement.cs (Block::UsageWarning): Track usage of variables and
26415 report the errors for not used variables.
26417 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
26420 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26422 * codegen.cs: remove unnneded code
26424 * expression.cs: Removed BuiltinTypeAccess class
26426 Fix the order in which implicit conversions are
26429 The previous fixed dropped support for boxed conversions (adding a
26430 test to the test suite now)
26432 (UserImplicitCast::CanConvert): Remove test for source being null,
26433 that code is broken. We should not feed a null to begin with, if
26434 we do, then we should track the bug where the problem originates
26435 and not try to cover it up here.
26437 Return a resolved expression of type UserImplicitCast on success
26438 rather than true/false. Ravi: this is what I was talking about,
26439 the pattern is to use a static method as a "constructor" for
26442 Also, do not create arguments until the very last minute,
26443 otherwise we always create the arguments even for lookups that
26444 will never be performed.
26446 (UserImplicitCast::Resolve): Eliminate, objects of type
26447 UserImplicitCast are born in a fully resolved state.
26449 * typemanager.cs (InitCoreTypes): Init also value_type
26450 (System.ValueType).
26452 * expression.cs (Cast::Resolve): First resolve the child expression.
26454 (LValue): Add new method AddressOf to be used by
26457 Change the argument of Store to take an EmitContext instead of an
26458 ILGenerator, because things like FieldExpr need to be able to call
26459 their children expression to generate the instance code.
26461 (Expression::Error, Expression::Warning): Sugar functions for
26464 (Expression::MemberLookup): Accept a TypeContainer instead of a
26465 Report as the first argument.
26467 (Expression::ResolvePrimary): Killed. I still want to improve
26468 this as currently the code is just not right.
26470 (Expression::ResolveMemberAccess): Simplify, but it is still
26473 (Unary::Resolve): Catch errors in AddressOf operators.
26475 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
26476 index to a byte for the short-version, or the compiler will choose
26477 the wrong Emit call, which generates the wrong data.
26479 (ParameterReference::Emit, ::Store): same.
26481 (FieldExpr::AddressOf): Implement.
26483 * typemanager.cs: TypeManager: made public variable instead of
26486 * driver.cs: document --fatal.
26488 * report.cs (ErrorMessage, WarningMessage): new names for the old
26489 Error and Warning classes.
26491 * cs-parser.jay (member_access): Turn built-in access to types
26492 into a normal simplename
26494 2001-09-27 Ravi Pratap <ravi@ximian.com>
26496 * expression.cs (Invocation::BetterConversion): Fix to cope
26497 with q being null, since this was introducing a bug.
26499 * expression.cs (ConvertImplicit): Do built-in conversions first.
26501 2001-09-27 Ravi Pratap <ravi@ximian.com>
26503 * expression.cs (UserImplicitCast::Resolve): Fix bug.
26505 2001-09-27 Ravi Pratap <ravi@ximian.com>
26507 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
26508 I had introduced long ago (what's new ?).
26510 * expression.cs (UserImplicitCast::CanConvert): Static method to do
26511 the work of all the checking.
26512 (ConvertImplicit): Call CanConvert and only then create object if necessary.
26513 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
26515 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
26516 that is the right way.
26518 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
26519 overloading resolution. Use everywhere instead of cutting and pasting code.
26521 (Binary::ResolveOperator): Use MakeUnionSet.
26523 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
26524 we have to convert to bool types. Not complete yet.
26526 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26528 * typemanager.cs (TypeManager::CSharpName): support ushort.
26530 * expression.cs (Expression::TryImplicitIntConversion): Attempts
26531 to provide an expression that performsn an implicit constant int
26532 conversion (section 6.1.6).
26533 (Expression::ConvertImplicitRequired): Reworked to include
26534 implicit constant expression conversions.
26536 (Expression::ConvertNumericExplicit): Finished.
26538 (Invocation::Emit): If InstanceExpression is null, then it means
26539 that we perform a call on this.
26541 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26543 * expression.cs (Unary::Emit): Remove some dead code.
26544 (Probe): Implement Resolve and Emit for `is'.
26545 (Expression::ConvertImplicitRequired): Attempt to do constant
26546 expression conversions here. Maybe should be moved to
26547 ConvertImplicit, but I am not sure.
26548 (Expression::ImplicitLongConstantConversionPossible,
26549 Expression::ImplicitIntConstantConversionPossible): New functions
26550 that tell whether is it possible to apply an implicit constant
26551 expression conversion.
26553 (ConvertNumericExplicit): Started work on explicit numeric
26556 * cs-parser.jay: Update operator constants.
26558 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
26559 (Parameters::GetSignature): Hook up VerifyArgs here.
26560 (Parameters::VerifyArgs): Verifies that no two arguments have the
26563 * class.cs (Operator): Update the operator names to reflect the
26564 ones that the spec expects (as we are just stringizing the
26567 * expression.cs (Unary::ResolveOperator): Fix bug: Use
26568 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
26569 previous usage did only work for our methods.
26570 (Expression::ConvertImplicit): Handle decimal implicit numeric
26571 conversions as well.
26572 (Expression::InternalTypeConstructor): Used to invoke constructors
26573 on internal types for default promotions.
26575 (Unary::Emit): Implement special handling for the pre/post
26576 increment/decrement for overloaded operators, as they need to have
26577 the same semantics as the other operators.
26579 (Binary::ResolveOperator): ditto.
26580 (Invocation::ConversionExists): ditto.
26581 (UserImplicitCast::Resolve): ditto.
26583 2001-09-26 Ravi Pratap <ravi@ximian.com>
26585 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
26586 operator, return after emitting body. Regression tests pass again !
26588 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
26589 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
26590 (Invocation::OverloadResolve): Ditto.
26591 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
26593 * everywhere : update calls to the above methods accordingly.
26595 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26597 * assign.cs (Assign): Make it inherit from ExpressionStatement.
26599 * expression.cs (ExpressionStatement): New base class used for
26600 expressions that can appear in statements, so that we can provide
26601 an alternate path to generate expression that do not leave a value
26604 (Expression::Emit, and all the derivatives): We no longer return
26605 whether a value is left on the stack or not. Every expression
26606 after being emitted leaves a single value on the stack.
26608 * codegen.cs (EmitContext::EmitStatementExpression): Use the
26609 facilties of ExpressionStatement if possible.
26611 * cs-parser.jay: Update statement_expression.
26613 2001-09-25 Miguel de Icaza <miguel@ximian.com>
26615 * driver.cs: Change the wording of message
26617 2001-09-25 Ravi Pratap <ravi@ximian.com>
26619 * expression.cs (Binary::ResolveOperator): Had forgottten to set
26620 the type of the expression to the return type of the method if
26621 we have an overloaded operator match ! The regression tests pass again !
26622 (Unary::ResolveOperator): Ditto.
26624 * expression.cs (Invocation::ConversionExists): Correct the member lookup
26625 to find "op_Implicit", not "implicit" ;-)
26626 (UserImplicitCast): New class to take care of user-defined implicit conversions.
26627 (ConvertImplicit, ForceConversion): Take TypeContainer argument
26629 * everywhere : Correct calls to the above accordingly.
26631 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
26632 (ConvertImplicit): Do user-defined conversion if it exists.
26634 2001-09-24 Miguel de Icaza <miguel@ximian.com>
26636 * assign.cs: track location.
26637 (Resolve): Use implicit conversions on assignment.
26639 * literal.cs: Oops. Not good, Emit of short access values should
26640 pass (Bytes) or the wrong argument will be selected.
26642 * expression.cs (Unary::Emit): Emit code for -expr.
26644 (Unary::ResolveOperator): Handle `Substract' for non-constants
26645 (substract from zero from the non-constants).
26646 Deal with Doubles as well.
26648 (Expression::ConvertImplicitRequired): New routine that reports an
26649 error if no implicit conversion exists.
26651 (Invocation::OverloadResolve): Store the converted implicit
26652 expressions if we make them
26654 2001-09-24 Ravi Pratap <ravi@ximian.com>
26656 * class.cs (ConstructorInitializer): Take a Location argument.
26657 (ConstructorBaseInitializer): Same here.
26658 (ConstructorThisInitializer): Same here.
26660 * cs-parser.jay : Update all calls accordingly.
26662 * expression.cs (Unary, Binary, New): Take location argument.
26663 Update accordingly everywhere.
26665 * cs-parser.jay : Update all calls to the above to take a location
26668 * class.cs : Ditto.
26670 2001-09-24 Ravi Pratap <ravi@ximian.com>
26672 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
26673 (Invocation::BetterConversion): Same here
26674 (Invocation::ConversionExists): Ditto.
26676 (Invocation::ConversionExists): Implement.
26678 2001-09-22 Ravi Pratap <ravi@ximian.com>
26680 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
26681 Also take an additional TypeContainer argument.
26683 * All over : Pass in TypeContainer as argument to OverloadResolve.
26685 * typemanager.cs (CSharpName): Update to check for the string type and return
26688 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
26691 2001-09-21 Ravi Pratap <ravi@ximian.com>
26693 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
26694 (Invocation::BetterFunction): Implement.
26695 (Invocation::BetterConversion): Implement.
26696 (Invocation::ConversionExists): Skeleton, no implementation yet.
26698 Okay, things work fine !
26700 2001-09-21 Miguel de Icaza <miguel@ximian.com>
26702 * typemanager.cs: declare and load enum_type, delegate_type and
26705 * expression.cs (Expression::Emit): Now emit returns a value that
26706 tells whether a value is left on the stack or not. This strategy
26707 might be reveted tomorrow with a mechanism that would address
26708 multiple assignments.
26709 (Expression::report118): Utility routine to report mismatches on
26712 (Unary::Report23): Report impossible type/operator combination
26715 (Unary::IsIncrementableNumber): Whether the type can be
26716 incremented or decremented with add.
26717 (Unary::ResolveOperator): Also allow enumerations to be bitwise
26719 (Unary::ResolveOperator): Implement ++, !, ~,
26721 (Invocation::Emit): Deal with new Emit convetion.
26723 * All Expression derivatives: Updated their Emit method to return
26724 whether they leave values on the stack or not.
26726 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
26727 stack for expressions that are statements.
26729 2001-09-20 Miguel de Icaza <miguel@ximian.com>
26731 * expression.cs (LValue): New interface. Must be implemented by
26733 (LocalVariableReference, ParameterReference, FieldExpr): Implement
26736 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
26737 interface for generating code, simplifies the code.
26739 2001-09-20 Ravi Pratap <ravi@ximian.com>
26741 * expression.cs (everywhere): Comment out return statements in ::Resolve
26742 methods to avoid the warnings.
26744 2001-09-20 Miguel de Icaza <miguel@ximian.com>
26746 * driver.cs (parse): Report error 2001 if we can not open the
26749 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
26752 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
26755 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
26756 otherwise nested blocks end up with the same index.
26758 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
26760 * expression.cs: Instead of having FIXMEs in the Resolve
26761 functions, throw exceptions so it is obvious that we are facing a
26764 * cs-parser.jay (invocation_expression): Pass Location information.
26766 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
26767 Use a basename for those routines because .NET does not like paths
26770 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
26773 2001-09-19 Miguel de Icaza <miguel@ximian.com>
26775 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
26776 are loading the correct data types (throws an exception if not).
26777 (TypeManager::InitCoreTypes): Use CoreLookupType
26779 * expression.cs (Unary::ResolveOperator): return the child
26780 expression for expressions which are just +expr.
26781 (Unary::ResolveOperator): Return negative literals for -LITERAL
26782 expressions (otherwise they are Unary {Literal}).
26783 (Invocation::Badness): Take into account `Implicit constant
26784 expression conversions'.
26786 * literal.cs (LongLiteral): Implement long literal class.
26787 (IntLiteral): export the `Value' of the intliteral.
26789 2001-09-19 Ravi Pratap <ravi@ximian.com>
26791 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
26793 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
26794 instead of 'Operator'
26796 * expression.cs (Binary::ResolveOperator): Update accordingly.
26797 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
26800 * cs-parser.jay (unary_expression): Update to use the new names.
26802 * gen-treedump.cs (GetUnary): Same here.
26804 * expression.cs (Unary::Resolve): Implement.
26805 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
26806 operators are found instead of making noise ;-)
26807 (Unary::ResolveOperator): New method to do precisely the same thing which
26808 Binary::ResolveOperator does for Binary expressions.
26809 (Unary.method, .Arguments): Add.
26810 (Unary::OperName): Implement.
26811 (Unary::ForceConversion): Copy and Paste !
26813 * class.cs (Operator::Define): Fix a small bug for the case when we have
26816 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
26817 for the inbuilt operators. Only overloading works for now ;-)
26819 2001-09-18 Miguel de Icaza <miguel@ximian.com>
26821 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
26822 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
26824 * expression.cs (This::Emit): Implement.
26825 (This::Resolve): Implement.
26826 (TypeOf:Resolve): Implement.
26827 (Expression::ResolveSimpleName): Add an implicit this to instance
26829 (MemberAccess::Resolve): Deal with Parameters and Fields.
26830 Bind instance variable to Field expressions.
26831 (FieldExpr::Instance): New field used to track the expression that
26832 represents the object instance.
26833 (FieldExpr::Resolve): Track potential errors from MemberLookup not
26835 (FieldExpr::Emit): Implement.
26837 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
26838 the last instruction contains a return opcode to avoid generating
26839 the last `ret' instruction (this generates correct code, and it is
26840 nice to pass the peverify output).
26842 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
26843 initializer for static and instance variables.
26844 (Constructor::Emit): Allow initializer to be null in the case of
26845 static constructors. Only emit initializer for instance
26848 (TypeContainer::FindMembers): Return a null array if there are no
26851 Also fix the code for the MemberTypes.Method branch, as it was not
26852 scanning that for operators (or tried to access null variables before).
26854 * assign.cs (Assign::Emit): Handle instance and static fields.
26858 * driver.cs: Stop compilation if there are parse errors.
26860 * cs-parser.jay (constructor_declaration): Provide default base
26861 initializer for non-static constructors.
26862 (constructor_declarator): Do not provide a default base
26863 initializers if none was specified.
26864 Catch the fact that constructors should not have parameters.
26866 * class.cs: Do not emit parent class initializers for static
26867 constructors, that should be flagged as an error.
26869 2001-09-18 Ravi Pratap <ravi@ximian.com>
26871 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
26872 Move back code into TypeContainer::Populate.
26874 2001-09-18 Ravi Pratap <ravi@ximian.com>
26876 * class.cs (TypeContainer::AddConstructor): Fix the check to
26877 compare against Name, not Basename.
26878 (Operator::OpType): Change Plus and Minus to Add and Subtract.
26880 * cs-parser.jay : Update accordingly.
26882 * class.cs (TypeContainer::FindMembers): For the case where we are searching
26883 for methods, don't forget to look into the operators too.
26884 (RegisterMethodBuilder): Helper method to take care of this for
26885 methods, constructors and operators.
26886 (Operator::Define): Completely revamp.
26887 (Operator.OperatorMethod, MethodName): New fields.
26888 (TypeContainer::Populate): Move the registering of builders into
26889 RegisterMethodBuilder.
26890 (Operator::Emit): Re-write.
26892 * expression.cs (Binary::Emit): Comment out code path to emit method
26893 invocation stuff for the case when we have a user defined operator. I am
26894 just not able to get it right !
26896 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26898 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
26901 (Expression::MemberLookup): Provide a version that allows to
26902 specify the MemberTypes and BindingFlags.
26904 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
26905 so it was not fetching variable information from outer blocks.
26907 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
26908 Beforefieldinit as it was buggy.
26910 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
26911 that Ravi put here.
26913 * class.cs (Constructor::Emit): Only emit if block is not null.
26914 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
26915 deal with this by semantically definining it as if the user had
26918 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
26919 constructors as we now "emit" them at a higher level.
26921 (TypeContainer::DefineDefaultConstructor): Used to define the
26922 default constructors if none was provided.
26924 (ConstructorInitializer): Add methods Resolve and Emit.
26926 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
26928 2001-09-17 Ravi Pratap <ravi@ximian.com>
26930 * class.cs (TypeContainer::EmitDefaultConstructor): Register
26931 the default constructor builder with our hashtable for methodbuilders
26934 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
26935 and argument_count is 0 in which case we have a match.
26936 (Binary::ResolveOperator): More null checking and miscellaneous coding
26939 2001-09-17 Ravi Pratap <ravi@ximian.com>
26941 * rootcontext.cs (IsNameSpace): Compare against null.
26943 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
26945 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
26946 and Unary::Operator.
26948 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
26951 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
26952 we have overloaded operators.
26953 (Binary::ResolveOperator): Implement the part which does the operator overload
26956 * class.cs (Operator::Emit): Implement.
26957 (TypeContainer::Emit): Emit the operators we have too.
26959 * expression.cs (Binary::Emit): Update to emit the appropriate code for
26960 the case when we have a user-defined operator.
26962 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26964 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
26966 2001-09-16 Ravi Pratap <ravi@ximian.com>
26968 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
26969 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
26970 (Constructor::Emit): Implement.
26971 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
26972 if we have no work to do.
26973 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
26976 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
26977 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
26979 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
26982 2001-09-15 Ravi Pratap <ravi@ximian.com>
26984 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
26986 (Tree::RecordNamespace): Method to do what the name says ;-)
26987 (Tree::Namespaces): Property to get at the namespaces hashtable.
26989 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
26992 * rootcontext.cs (IsNamespace): Fixed it :-)
26994 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26996 * class.cs (TypeContainer::FindMembers): Add support for
26998 (MethodCore): New class that encapsulates both the shared aspects
26999 of a Constructor and a Method.
27000 (Method, Constructor): Factored pieces into MethodCore.
27002 * driver.cs: Added --fatal which makes errors throw exceptions.
27003 Load System assembly as well as part of the standard library.
27005 * report.cs: Allow throwing exceptions on errors for debugging.
27007 * modifiers.cs: Do not use `parent', instead use the real type
27008 container to evaluate permission settings.
27010 * class.cs: Put Ravi's patch back in. He is right, and we will
27011 have to cope with the
27013 2001-09-14 Ravi Pratap <ravi@ximian.com>
27015 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
27016 FamORAssem, not FamANDAssem.
27018 2001-09-14 Miguel de Icaza <miguel@ximian.com>
27020 * driver.cs: Added --parse option that only parses its input files
27023 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
27024 incorrect. IsTopLevel is not used to tell whether an object is
27025 root_types or not (that can be achieved by testing this ==
27026 root_types). But to see if this is a top-level *class* (not
27027 necessarly our "toplevel" container).
27029 2001-09-14 Ravi Pratap <ravi@ximian.com>
27031 * enum.cs (Enum::Define): Modify to call the Lookup method on the
27032 parent instead of a direct call to GetType.
27034 2001-09-14 Ravi Pratap <ravi@ximian.com>
27036 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
27037 Modifiers.TypeAttr. This should just be a call to that method.
27039 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
27040 object so that we can determine if we are top-level or not.
27042 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
27045 * enum.cs (Enum::Define): Ditto.
27047 * modifiers.cs (FieldAttr): Re-write.
27049 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
27050 (TypeContainer::HaveStaticConstructor): New property to provide access
27051 to precisely that info.
27053 * modifiers.cs (MethodAttr): Re-write.
27054 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
27056 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
27057 of top-level types as claimed.
27059 2001-09-13 Miguel de Icaza <miguel@ximian.com>
27061 * expression.cs (MemberLookup): Fruitless attempt to lookup
27062 constructors. Maybe I need to emit default constructors? That
27063 might be it (currently .NET emits this for me automatically).
27064 (Invocation::OverloadResolve): Cope with Arguments == null.
27065 (Invocation::EmitArguments): new function, shared by the new
27066 constructor and us.
27067 (Invocation::Emit): Handle static and instance methods. Emit
27068 proper call instruction for virtual or non-virtual invocations.
27069 (New::Emit): Implement.
27070 (New::Resolve): Implement.
27071 (MemberAccess:Resolve): Implement.
27072 (MethodGroupExpr::InstanceExpression): used conforming to the spec
27073 to track instances.
27074 (FieldExpr::Resolve): Set type.
27076 * support.cs: Handle empty arguments.
27078 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
27079 SimpleLookup): Auxiliary routines to help parse a qualifier
27082 Update qualifier_identifier rule.
27084 * codegen.cs: Removed debugging messages.
27086 * class.cs: Make this a global thing, this acts just as a "key" to
27087 objects that we might have around.
27089 (Populate): Only initialize method_builders_to_methods once.
27091 * expression.cs (PropertyExpr): Initialize type from the
27094 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
27095 Resolve pattern. Attempt to implicitly convert value to boolean.
27098 * expression.cs: Set the type for the int32/int32 argument case.
27099 (Binary::ResolveOperator): Set the return type to boolean for
27100 comparission operators
27102 * typemanager.cs: Remove debugging print code.
27104 (Invocation::Resolve): resolve type.
27106 * class.cs: Allocate a MemberInfo of the correct size, as the code
27107 elsewhere depends on the test to reflect the correct contents.
27109 (Method::) Keep track of parameters, due to System.Reflection holes
27111 (TypeContainer::Populate): Keep track of MethodBuilders to Method
27114 (TypeContainer::FindMembers): Use ArrayList and then copy an array
27115 of the exact size and return that.
27117 (Class::LookupMethodByBuilder): New function that maps
27118 MethodBuilders to its methods. Required to locate the information
27119 on methods because System.Reflection bit us again.
27121 * support.cs: New file, contains an interface ParameterData and
27122 two implementations: ReflectionParameters and InternalParameters
27123 used to access Parameter information. We will need to grow this
27126 * expression.cs (Invocation::GetParameterData): implement a cache
27127 and a wrapper around the ParameterData creation for methods.
27128 (Invocation::OverloadResolve): Use new code.
27130 2001-09-13 Ravi Pratap <ravi@ximian.com>
27132 * class.cs (TypeContainer::EmitField): Remove and move into
27133 (Field::Define): here and modify accordingly.
27134 (Field.FieldBuilder): New member.
27135 (TypeContainer::Populate): Update accordingly.
27136 (TypeContainer::FindMembers): Implement.
27138 2001-09-13 Miguel de Icaza <miguel@ximian.com>
27140 * statement.cs: (VariableInfo::VariableType): New field to be
27141 initialized with the full type once it is resolved.
27143 2001-09-12 Miguel de Icaza <miguel@ximian.com>
27145 * parameter.cs (GetParameterInfo): Use a type cache to compute
27146 things only once, and to reuse this information
27148 * expression.cs (LocalVariableReference::Emit): Implement.
27149 (OpcodeCast::Emit): fix.
27151 (ParameterReference::Resolve): Implement.
27152 (ParameterReference::Emit): Implement.
27154 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
27155 that are expressions need to stay as Expressions.
27157 * typemanager.cs (CSharpName): Returns the C# name of a type if
27160 * expression.cs (Expression::ConvertImplicit): New function that
27161 implements implicit type conversions.
27163 (Expression::ImplicitReferenceConversion): Implements implicit
27164 reference conversions.
27166 (EmptyCast): New type for transparent casts.
27168 (OpcodeCast): New type for casts of types that are performed with
27169 a sequence of bytecodes.
27171 (BoxedCast): New type used for casting value types into reference
27172 types. Emits a box opcode.
27174 (Binary::DoNumericPromotions): Implements numeric promotions of
27175 and computation of the Binary::Type.
27177 (Binary::EmitBranchable): Optimization.
27179 (Binary::Emit): Implement code emission for expressions.
27181 * typemanager.cs (TypeManager): Added two new core types: sbyte
27184 2001-09-12 Ravi Pratap <ravi@ximian.com>
27186 * class.cs (TypeContainer::FindMembers): Method which does exactly
27187 what Type.FindMembers does, only we don't have to use reflection. No
27188 implementation yet.
27190 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
27191 typecontainer objects as we need to get at them.
27192 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
27194 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
27195 typecontainer object.
27197 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
27198 of just a Report object.
27200 2001-09-11 Ravi Pratap <ravi@ximian.com>
27202 * class.cs (Event::Define): Go back to using the prefixes "add_" and
27204 (TypeContainer::Populate): Now define the delegates of the type too.
27205 (TypeContainer.Delegates): Property to access the list of delegates defined
27208 * delegates.cs (Delegate::Define): Implement partially.
27210 * modifiers.cs (TypeAttr): Handle more flags.
27212 2001-09-11 Ravi Pratap <ravi@ximian.com>
27214 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
27216 (Operator::Define): Re-write logic to get types by using the LookupType method
27217 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
27218 (Indexer::Define): Ditto.
27219 (Event::Define): Ditto.
27220 (Property::Define): Ditto.
27222 2001-09-10 Ravi Pratap <ravi@ximian.com>
27224 * class.cs (TypeContainer::Populate): Now define operators too.
27225 (TypeContainer.Operators): New property to access the list of operators
27227 (Operator.OperatorMethodBuilder): New member to hold the method builder
27228 for the operator we are defining.
27229 (Operator::Define): Implement.
27231 2001-09-10 Ravi Pratap <ravi@ximian.com>
27233 * class.cs (Event::Define): Make the prefixes of the accessor methods
27234 addOn_ and removeOn_
27236 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
27237 of the location being passed in too. Ideally, this should go later since all
27238 error reporting should be done through the Report object.
27240 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
27241 (Populate): Iterate thru the indexers we have and define them too.
27242 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
27243 for the get and set accessors.
27244 (Indexer::Define): Implement.
27246 2001-09-09 Miguel de Icaza <miguel@ximian.com>
27248 * expression.cs (Binary::Resolve): Beginning of it. I scratched
27249 my previous implementation, did not work.
27251 * typemanager.cs: Add a couple of missing types (the longs).
27253 * literal.cs: Use TypeManager.bool_type instead of getting it.
27255 * expression.cs (EventExpr): New kind of expressions.
27256 (Expressio::ExprClassFromMemberInfo): finish
27258 2001-09-08 Miguel de Icaza <miguel@ximian.com>
27260 * assign.cs: Emit stores to static fields differently.
27262 2001-09-08 Ravi Pratap <ravi@ximian.com>
27264 * Merge in changes and adjust code to tackle conflicts. Backed out my
27265 code in Assign::Resolve ;-)
27267 2001-09-08 Ravi Pratap <ravi@ximian.com>
27269 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
27270 instead Report.Error and also pass in the location.
27271 (CSharpParser::Lexer): New readonly property to return the reference
27272 to the Tokenizer object.
27273 (declare_local_variables): Use Report.Error with location instead of plain
27277 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
27278 (Operator.CheckBinaryOperator): Ditto.
27280 * cs-parser.jay (operator_declarator): Update accordingly.
27282 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
27283 (CheckBinaryOperator): Same here.
27285 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
27286 on the name without any prefixes of namespace names etc. This is because we
27287 already might have something already fully qualified like
27288 'System.Console.WriteLine'
27290 * assign.cs (Resolve): Begin implementation. Stuck ;-)
27292 2001-09-07 Ravi Pratap <ravi@ximian.com>
27294 * cs-tokenizer.cs (location): Return a string which also contains
27297 * expression.cs (ElementAccess): New class for expressions of the
27298 type 'element access.'
27299 (BaseAccess): New class for expressions of the type 'base access.'
27300 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
27303 * cs-parser.jay (element_access): Implement action.
27304 (base_access): Implement actions.
27305 (checked_expression, unchecked_expression): Implement.
27307 * cs-parser.jay (local_variable_type): Correct and implement.
27308 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
27310 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
27312 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
27313 name and the specifiers.
27315 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
27317 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
27318 making them all public ;-)
27320 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
27323 2001-09-07 Miguel de Icaza <miguel@ximian.com>
27325 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
27327 (FieldExpr, PropertyExprs): New resolved expressions.
27328 (SimpleName::MemberStaticCheck): Perform static checks for access
27329 to non-static fields on static methods. Maybe this should be
27330 generalized for MemberAccesses.
27331 (SimpleName::ResolveSimpleName): More work on simple name
27334 * cs-parser.jay (primary_expression/qualified_identifier): track
27335 the parameter index.
27337 * codegen.cs (CodeGen::Save): Catch save exception, report error.
27338 (EmitContext::EmitBoolExpression): Chain to expression generation
27339 instead of temporary hack.
27340 (::EmitStatementExpression): Put generic expression code generation.
27342 * assign.cs (Assign::Emit): Implement variable assignments to
27343 local variables, parameters and fields.
27345 2001-09-06 Miguel de Icaza <miguel@ximian.com>
27347 * statement.cs (Block::GetVariableInfo): New method, returns the
27348 VariableInfo for a variable name in a block.
27349 (Block::GetVariableType): Implement in terms of GetVariableInfo
27351 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
27352 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
27354 2001-09-06 Ravi Pratap <ravi@ximian.com>
27356 * cs-parser.jay (operator_declaration): Continue on my quest : update
27357 to take attributes argument.
27358 (event_declaration): Ditto.
27359 (enum_declaration): Ditto.
27360 (indexer_declaration): Ditto.
27362 * class.cs (Operator::Operator): Update constructor accordingly.
27363 (Event::Event): Ditto.
27365 * delegate.cs (Delegate::Delegate): Same here.
27367 * enum.cs (Enum::Enum): Same here.
27369 2001-09-05 Ravi Pratap <ravi@ximian.com>
27371 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
27373 * ../tests/cs0658.cs : New file to demonstrate error 0658.
27375 * attribute.cs (Attributes): New class to encapsulate all attributes which were
27376 being passed around as an arraylist.
27377 (Attributes::AddAttribute): Method to add attribute sections.
27379 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
27380 (struct_declaration): Update accordingly.
27381 (constant_declaration): Update.
27382 (field_declaration): Update.
27383 (method_header): Update.
27384 (fixed_parameter): Update.
27385 (parameter_array): Ditto.
27386 (property_declaration): Ditto.
27387 (destructor_declaration): Ditto.
27389 * class.cs (Struct::Struct): Update constructors accordingly.
27390 (Class::Class): Ditto.
27391 (Field::Field): Ditto.
27392 (Method::Method): Ditto.
27393 (Property::Property): Ditto.
27394 (TypeContainer::OptAttribute): update property's return type.
27396 * interface.cs (Interface.opt_attributes): New member.
27397 (Interface::Interface): Update to take the extra Attributes argument.
27399 * parameter.cs (Parameter::Parameter): Ditto.
27401 * constant.cs (Constant::Constant): Ditto.
27403 * interface.cs (InterfaceMemberBase): New OptAttributes field.
27404 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
27405 the attributes as a parameter.
27406 (InterfaceProperty): Update constructor call.
27407 (InterfaceEvent): Ditto.
27408 (InterfaceMethod): Ditto.
27409 (InterfaceIndexer): Ditto.
27411 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
27412 pass the attributes too.
27413 (interface_event_declaration): Ditto.
27414 (interface_property_declaration): Ditto.
27415 (interface_method_declaration): Ditto.
27416 (interface_declaration): Ditto.
27418 2001-09-05 Miguel de Icaza <miguel@ximian.com>
27420 * class.cs (Method::Define): Track the "static Main" definition to
27421 create an entry point.
27423 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
27424 EntryPoint if we find it.
27426 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
27427 (EmitContext::ig): Make this variable public.
27429 * driver.cs: Make the default output file be the first file name
27430 with the .exe extension.
27432 Detect empty compilations
27434 Handle various kinds of output targets. Handle --target and
27435 rename -t to --dumper.
27437 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
27438 methods inherited from Expression return now an Expression. This
27439 will is used during the tree rewriting as we resolve them during
27442 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
27443 the spec. Missing entirely is the information about
27444 accessability of elements of it.
27446 (Expression::ExprClassFromMemberInfo): New constructor for
27447 Expressions that creates a fully initialized Expression based on
27448 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
27451 (Invocation::Resolve): Begin implementing resolution of invocations.
27453 * literal.cs (StringLiteral): Implement Emit.
27455 2001-09-05 Ravi Pratap <ravi@ximian.com>
27457 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
27460 2001-09-04 Ravi Pratap <ravi@ximian.com>
27462 * cs-parser.jay (attribute_arguments): Implement actions.
27463 (attribute): Fix bug in production. Implement action.
27464 (attribute_list): Implement.
27465 (attribute_target): Implement.
27466 (attribute_target_specifier, opt_target_specifier): Implement
27467 (CheckAttributeTarget): New method to check if the attribute target
27469 (attribute_section): Implement.
27470 (opt_attributes): Implement.
27472 * attribute.cs : New file to handle attributes.
27473 (Attribute): Class to hold attribute info.
27475 * cs-parser.jay (opt_attribute_target_specifier): Remove production
27476 (attribute_section): Modify production to use 2 different rules to
27477 achieve the same thing. 1 s/r conflict down !
27478 Clean out commented, useless, non-reducing dimension_separator rules.
27480 * class.cs (TypeContainer.attributes): New member to hold list
27481 of attributes for a type.
27482 (Struct::Struct): Modify to take one more argument, the attribute list.
27483 (Class::Class): Ditto.
27484 (Field::Field): Ditto.
27485 (Method::Method): Ditto.
27486 (Property::Property): Ditto.
27488 * cs-parser.jay (struct_declaration): Update constructor call to
27489 pass in the attributes too.
27490 (class_declaration): Ditto.
27491 (constant_declaration): Ditto.
27492 (field_declaration): Ditto.
27493 (method_header): Ditto.
27494 (fixed_parameter): Ditto.
27495 (parameter_array): Ditto.
27496 (property_declaration): Ditto.
27498 * constant.cs (Constant::Constant): Update constructor similarly.
27499 Use System.Collections.
27501 * parameter.cs (Parameter::Parameter): Update as above.
27503 2001-09-02 Ravi Pratap <ravi@ximian.com>
27505 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
27506 (TypeContainer.delegates): New member to hold list of delegates.
27508 * cs-parser.jay (delegate_declaration): Implement the action correctly
27509 this time as I seem to be on crack ;-)
27511 2001-09-02 Miguel de Icaza <miguel@ximian.com>
27513 * rootcontext.cs (RootContext::IsNamespace): new function, used to
27514 tell whether an identifier represents a namespace.
27516 * expression.cs (NamespaceExpr): A namespace expression, used only
27517 temporarly during expression resolution.
27518 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
27519 utility functions to resolve names on expressions.
27521 2001-09-01 Miguel de Icaza <miguel@ximian.com>
27523 * codegen.cs: Add hook for StatementExpressions.
27525 * class.cs: Fix inverted test for static flag in methods.
27527 2001-09-02 Ravi Pratap <ravi@ximian.com>
27529 * class.cs (Operator::CheckUnaryOperator): Correct error number used
27530 to make it coincide with MS' number.
27531 (Operator::CheckBinaryOperator): Ditto.
27533 * ../errors/errors.txt : Remove error numbers added earlier.
27535 * ../errors/cs1019.cs : Test case for error # 1019
27537 * ../errros/cs1020.cs : Test case for error # 1020
27539 * cs-parser.jay : Clean out commented cruft.
27540 (dimension_separators, dimension_separator): Comment out. Ostensibly not
27541 used anywhere - non-reducing rule.
27542 (namespace_declarations): Non-reducing rule - comment out.
27544 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
27545 with TypeContainer::AddEnum.
27547 * delegate.cs : New file for delegate handling classes.
27548 (Delegate): Class for declaring delegates.
27550 * makefile : Update.
27552 * cs-parser.jay (delegate_declaration): Implement.
27554 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
27556 * class.cs (Event::Define): Implement.
27557 (Event.EventBuilder): New member.
27559 * class.cs (TypeContainer::Populate): Update to define all enums and events
27561 (Events): New property for the events arraylist we hold. Shouldn't we move to using
27562 readonly fields for all these cases ?
27564 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27566 * class.cs (Property): Revamp to use the convention of making fields readonly.
27567 Accordingly modify code elsewhere.
27569 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
27570 the Define method of the Property class.
27572 * class.cs : Clean up applied patch and update references to variables etc. Fix
27574 (TypeContainer::Populate): Update to define all the properties we have. Also
27575 define all enumerations.
27577 * enum.cs (Define): Implement.
27579 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27581 * cs-parser.jay (overloadable_operator): The semantic value is an
27582 enum of the Operator class.
27583 (operator_declarator): Implement actions.
27584 (operator_declaration): Implement.
27586 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
27587 validity of definitions.
27588 (Operator::CheckBinaryOperator): Static method to check for binary operators
27589 (TypeContainer::AddOperator): New method to add an operator to a type.
27591 * cs-parser.jay (indexer_declaration): Added line to actually call the
27592 AddIndexer method so it gets added ;-)
27594 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
27595 already taken care of by the MS compiler ?
27597 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27599 * class.cs (Operator): New class for operator declarations.
27600 (Operator::OpType): Enum for the various operators.
27602 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27604 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
27605 ostensibly handle this in semantic analysis.
27607 * cs-parser.jay (general_catch_clause): Comment out
27608 (specific_catch_clauses, specific_catch_clause): Ditto.
27609 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
27610 (catch_args, opt_catch_args): New productions.
27611 (catch_clause): Rewrite to use the new productions above
27612 (catch_clauses): Modify accordingly.
27613 (opt_catch_clauses): New production to use in try_statement
27614 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
27615 and re-write the code in the actions to extract the specific and
27616 general catch clauses by being a little smart ;-)
27618 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
27619 Hooray, try and catch statements parse fine !
27621 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27623 * statement.cs (Block::GetVariableType): Fix logic to extract the type
27624 string from the hashtable of variables.
27626 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
27627 I end up making that mistake ;-)
27628 (catch_clauses): Fixed gross error which made Key and Value of the
27629 DictionaryEntry the same : $1 !!
27631 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27633 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
27635 * cs-parser.jay (event_declaration): Correct to remove the semicolon
27636 when the add and remove accessors are specified.
27638 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27640 * cs-parser.jay (IndexerDeclaration): New helper class to hold
27641 information about indexer_declarator.
27642 (indexer_declarator): Implement actions.
27643 (parsing_indexer): New local boolean used to keep track of whether
27644 we are parsing indexers or properties. This is necessary because
27645 implicit_parameters come into picture even for the get accessor in the
27646 case of an indexer.
27647 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
27649 * class.cs (Indexer): New class for indexer declarations.
27650 (TypeContainer::AddIndexer): New method to add an indexer to a type.
27651 (TypeContainer::indexers): New member to hold list of indexers for the
27654 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27656 * cs-parser.jay (add_accessor_declaration): Implement action.
27657 (remove_accessor_declaration): Implement action.
27658 (event_accessors_declaration): Implement
27659 (variable_declarators): swap statements for first rule - trivial.
27661 * class.cs (Event): New class to hold information about event
27663 (TypeContainer::AddEvent): New method to add an event to a type
27664 (TypeContainer::events): New member to hold list of events.
27666 * cs-parser.jay (event_declaration): Implement actions.
27668 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27670 * cs-parser.jay (dim_separators): Implement. Make it a string
27671 concatenating all the commas together, just as they appear.
27672 (opt_dim_separators): Modify accordingly
27673 (rank_specifiers): Update accordingly. Basically do the same
27674 thing - instead, collect the brackets here.
27675 (opt_rank_sepcifiers): Modify accordingly.
27676 (array_type): Modify to actually return the complete type string
27677 instead of ignoring the rank_specifiers.
27678 (expression_list): Implement to collect the expressions
27679 (variable_initializer): Implement. We make it a list of expressions
27680 essentially so that we can handle the array_initializer case neatly too.
27681 (variable_initializer_list): Implement.
27682 (array_initializer): Make it a list of variable_initializers
27683 (opt_array_initializer): Modify accordingly.
27685 * expression.cs (New::NType): Add enumeration to help us
27686 keep track of whether we have an object/delegate creation
27687 or an array creation.
27688 (New:NewType, New::Rank, New::Indices, New::Initializers): New
27689 members to hold data about array creation.
27690 (New:New): Modify to update NewType
27691 (New:New): New Overloaded contructor for the array creation
27694 * cs-parser.jay (array_creation_expression): Implement to call
27695 the overloaded New constructor.
27697 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
27699 * class.cs (TypeContainer::Constructors): Return member
27700 constructors instead of returning null.
27702 2001-08-26 Miguel de Icaza <miguel@ximian.com>
27704 * typemanager.cs (InitCoreTypes): Initialize the various core
27705 types after we have populated the type manager with the user
27706 defined types (this distinction will be important later while
27707 compiling corlib.dll)
27709 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
27710 on Expression Classification. Now all expressions have a method
27711 `Resolve' and a method `Emit'.
27713 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
27714 generation from working. Also add some temporary debugging
27717 2001-08-24 Miguel de Icaza <miguel@ximian.com>
27719 * codegen.cs: Lots of code generation pieces. This is only the
27720 beginning, will continue tomorrow with more touches of polish. We
27721 handle the fundamentals of if, while, do, for, return. Others are
27722 trickier and I need to start working on invocations soon.
27724 * gen-treedump.cs: Bug fix, use s.Increment here instead of
27727 * codegen.cs (EmitContext): New struct, used during code
27728 emission to keep a context. Most of the code generation will be
27731 * cs-parser.jay: Add embedded blocks to the list of statements of
27732 this block. So code generation proceeds in a top down fashion.
27734 2001-08-23 Miguel de Icaza <miguel@ximian.com>
27736 * statement.cs: Add support for multiple child blocks.
27738 2001-08-22 Miguel de Icaza <miguel@ximian.com>
27740 * codegen.cs (EmitCode): New function, will emit the code for a
27741 Block of code given a TypeContainer and its ILGenerator.
27743 * statement.cs (Block): Standard public readonly optimization.
27744 (Block::Block constructors): Link children.
27745 (Block::Child): Child Linker.
27746 (Block::EmitVariables): Emits IL variable declarations.
27748 * class.cs: Drop support for MethodGroups here, delay until
27750 (Method::): Applied the same simplification that I did before, and
27751 move from Properties to public readonly fields.
27752 (Method::ParameterTypes): Returns the parameter types for the
27753 function, and implements a cache that will be useful later when I
27754 do error checking and the semantic analysis on the methods is
27756 (Constructor::GetCallingConvention): Renamed from CallingConvetion
27757 and made a method, optional argument tells whether this is a class
27758 or a structure to apply the `has-this' bit.
27759 (Method::GetCallingConvention): Implement, returns the calling
27761 (Method::Define): Defines the type, a second pass is performed
27762 later to populate the methods.
27764 (Constructor::ParameterTypes): implement a cache similar to the
27765 one on Method::ParameterTypes, useful later when we do semantic
27768 (TypeContainer::EmitMethod): New method. Emits methods.
27770 * expression.cs: Removed MethodGroup class from here.
27772 * parameter.cs (Parameters::GetCallingConvention): new method.
27774 2001-08-21 Miguel de Icaza <miguel@ximian.com>
27776 * class.cs (TypeContainer::Populate): Drop RootContext from the
27779 (Constructor::CallingConvention): Returns the calling convention.
27780 (Constructor::ParameterTypes): Returns the constructor parameter
27783 (TypeContainer::AddConstructor): Keep track of default constructor
27784 and the default static constructor.
27786 (Constructor::) Another class that starts using `public readonly'
27787 instead of properties.
27789 (Constructor::IsDefault): Whether this is a default constructor.
27791 (Field::) use readonly public fields instead of properties also.
27793 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
27794 track of static constructors; If none is used, turn on
27795 BeforeFieldInit in the TypeAttributes.
27797 * cs-parser.jay (opt_argument_list): now the return can be null
27798 for the cases where there are no arguments.
27800 (constructor_declarator): If there is no implicit `base' or
27801 `this', then invoke the default parent constructor.
27803 * modifiers.cs (MethodAttr): New static function maps a set of
27804 modifiers flags into a MethodAttributes enum
27805 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
27806 MethodAttr, TypeAttr to represent the various mappings where the
27807 modifiers are used.
27808 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
27810 2001-08-19 Miguel de Icaza <miguel@ximian.com>
27812 * parameter.cs (GetParameterInfo): Fix bug where there would be no
27815 * interface.cs (PopulateIndexer): Implemented the code generator
27816 for interface indexers.
27818 2001-08-17 Miguel de Icaza <miguel@ximian.com>
27820 * interface.cs (InterfaceMemberBase): Now we track the new status
27823 (PopulateProperty): Implement property population. Woohoo! Got
27824 Methods and Properties going today.
27826 Removed all the properties for interfaces, and replaced them with
27827 `public readonly' fields.
27829 2001-08-16 Miguel de Icaza <miguel@ximian.com>
27831 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
27832 initialize their hashtables/arraylists only when they are needed
27833 instead of doing this always.
27835 * parameter.cs: Handle refs and out parameters.
27837 * cs-parser.jay: Use an ArrayList to construct the arguments
27838 instead of the ParameterCollection, and then cast that to a
27841 * parameter.cs: Drop the use of ParameterCollection and use
27842 instead arrays of Parameters.
27844 (GetParameterInfo): Use the Type, not the Name when resolving
27847 2001-08-13 Miguel de Icaza <miguel@ximian.com>
27849 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
27850 and instead use public readonly fields.
27852 * class.cs: Put back walking code for type containers.
27854 2001-08-11 Miguel de Icaza <miguel@ximian.com>
27856 * class.cs (MakeConstant): Code to define constants.
27858 * rootcontext.cs (LookupType): New function. Used to locate types
27861 2001-08-08 Miguel de Icaza <miguel@ximian.com>
27863 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
27864 this System.Reflection code is. Kudos to Microsoft
27866 * typemanager.cs: Implement a type cache and avoid loading all
27867 types at boot time. Wrap in LookupType the internals. This made
27868 the compiler so much faster. Wow. I rule!
27870 * driver.cs: Make sure we always load mscorlib first (for
27871 debugging purposes, nothing really important).
27873 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
27874 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
27876 * rootcontext.cs: Lookup types on their namespace; Lookup types
27877 on namespaces that have been imported using the `using' keyword.
27879 * class.cs (TypeContainer::TypeAttr): Virtualize.
27880 (Class::TypeAttr): Return attributes suitable for this bad boy.
27881 (Struct::TypeAttr): ditto.
27882 Handle nested classes.
27883 (TypeContainer::) Remove all the type visiting code, it is now
27884 replaced with the rootcontext.cs code
27886 * rootcontext.cs (GetClassBases): Added support for structs.
27888 2001-08-06 Miguel de Icaza <miguel@ximian.com>
27890 * interface.cs, statement.cs, class.cs, parameter.cs,
27891 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
27892 Drop use of TypeRefs, and use strings instead.
27894 2001-08-04 Miguel de Icaza <miguel@ximian.com>
27898 * class.cs (Struct::Struct): set the SEALED flags after
27899 checking the modifiers.
27900 (TypeContainer::TypeAttr): new property, returns the
27901 TypeAttributes for a class.
27903 * cs-parser.jay (type_list): Oops, list production was creating a
27904 new list of base types.
27906 * rootcontext.cs (StdLib): New property.
27907 (GetInterfaceTypeByName): returns an interface by type name, and
27908 encapsulates error handling here.
27909 (GetInterfaces): simplified.
27910 (ResolveTree): Encapsulated all the tree resolution here.
27911 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
27914 * driver.cs: Add support for --nostdlib, to avoid loading the
27915 default assemblies.
27916 (Main): Do not put tree resolution here.
27918 * rootcontext.cs: Beginning of the class resolution.
27920 2001-08-03 Miguel de Icaza <miguel@ximian.com>
27922 * rootcontext.cs: Provide better error reporting.
27924 * cs-parser.jay (interface_base): set our $$ to be interfaces.
27926 * rootcontext.cs (CreateInterface): Handle the case where there
27927 are no parent interfaces.
27929 (CloseTypes): Routine to flush types at the end.
27930 (CreateInterface): Track types.
27931 (GetInterfaces): Returns an array of Types from the list of
27932 defined interfaces.
27934 * typemanager.c (AddUserType): Mechanism to track user types (puts
27935 the type on the global type hash, and allows us to close it at the
27938 2001-08-02 Miguel de Icaza <miguel@ximian.com>
27940 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
27941 RecordInterface instead.
27943 * cs-parser.jay: Updated to reflect changes above.
27945 * decl.cs (Definition): Keep track of the TypeBuilder type that
27946 represents this type here. Not sure we will use it in the long
27947 run, but wont hurt for now.
27949 * driver.cs: Smaller changes to accomodate the new code.
27951 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
27954 * rootcontext.cs (CreateInterface): New method, used to create
27955 the System.TypeBuilder type for interfaces.
27956 (ResolveInterfaces): new entry point to resolve the interface
27958 (CodeGen): Property, used to keep track of the code generator.
27960 2001-07-26 Miguel de Icaza <miguel@ximian.com>
27962 * cs-parser.jay: Add a second production for delegate_declaration
27965 (enum_body): Put an opt_comma here instead of putting it on
27966 enum_body or enum_member_declarations so we can handle trailing
27967 commas on enumeration members. Gets rid of a shift/reduce.
27969 (type_list): Need a COMMA in the middle.
27971 (indexer_declaration): Tell tokenizer to recognize get/set
27973 * Remove old targets.
27975 * Re-add the parser target.
27977 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27979 * cs-parser.jay: Add precendence rules for a number of operators
27980 ot reduce the number of shift/reduce conflicts in the grammar.
27982 2001-07-17 Miguel de Icaza <miguel@ximian.com>
27984 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
27987 Get rid of old crufty code.
27989 * rootcontext.cs: Use this to keep track of the parsed
27990 representation and the defined types available to the program.
27992 * gen-treedump.cs: adjust for new convention.
27994 * type.cs: Split out the type manager, and the assembly builder
27997 * typemanager.cs: the type manager will live here now.
27999 * cil-codegen.cs: And the code generator here.
28001 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
28003 * makefile: Fixed up for easy making.
28005 2001-07-13 Simon Cozens <simon@simon-cozens.org>
28007 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
28010 (unary_expression): Expand pre_increment_expression and
28011 post_decrement_expression to reduce a shift/reduce.
28013 2001-07-11 Simon Cozens
28015 * cs-tokenizer.cs: Hex numbers should begin with a 0.
28017 Improve allow_keyword_as_indent name.
28019 2001-06-19 Miguel de Icaza <miguel@ximian.com>
28021 * Adjustments for Beta2.
28023 2001-06-13 Miguel de Icaza <miguel@ximian.com>
28025 * decl.cs: Added `Define' abstract method.
28026 (InTransit): new property, used to catch recursive definitions.
28028 * interface.cs: Implement `Define'.
28030 * modifiers.cs: Map Modifiers.constants to
28031 System.Reflection.TypeAttribute flags.
28033 * class.cs: Keep track of types and user-defined types.
28034 (BuilderInit): New method for creating an assembly
28035 (ResolveType): New function to launch the resolution process, only
28036 used by interfaces for now.
28038 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
28039 that are inserted into the name space.
28041 2001-06-08 Miguel de Icaza <miguel@ximian.com>
28043 * ARGH. I have screwed up my tree so many times due to the use of
28044 rsync rather than using CVS. Going to fix this at once.
28046 * driver.cs: Objetify driver. Load assemblies, use assemblies to
28049 2001-06-07 Miguel de Icaza <miguel@ximian.com>
28051 * Experiment successful: Use System.Type rather that our own
28054 2001-05-25 Miguel de Icaza <miguel@ximian.com>
28056 * cs-parser.jay: Removed nsAliases from here.
28058 Use new namespaces, handle `using XXX;'
28060 * namespace.cs: Reimplemented namespace handling, use a recursive
28061 definition of the class. Now we can keep track of using clauses
28062 and catch invalid using clauses.
28064 2001-05-24 Miguel de Icaza <miguel@ximian.com>
28066 * gen-treedump.cs: Adapted for all the renaming.
28068 * expression.cs (Expression): this class now has a Type property
28069 which returns an expression Type.
28071 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
28072 `Type', as this has a different meaning now in the base
28074 2001-05-22 Miguel de Icaza <miguel@ximian.com>
28076 * interface.cs, class.cs: Removed from all the sources the
28077 references to signature computation, as we can not do method
28078 signature computation during the parsing time, as we are not
28079 trying to solve at that point distinguishing:
28083 void a (NS.Blah x) {}
28086 Which depending on the context might be valid or not, as we do not
28087 know if Blah is the same thing as NS.Blah at that point.
28089 * Redid everything so the code uses TypeRefs now instead of
28090 Types. TypeRefs are just temporary type placeholders, that need
28091 to be resolved. They initially have a pointer to a string and the
28092 current scope in which they are used. This is used later by the
28093 compiler to resolve the reference to an actual Type.
28095 * DeclSpace is no longer a CIR.Type, and neither are
28096 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
28097 are all DeclSpaces, but no Types.
28099 * type.cs (TypeRefManager): This implements the TypeRef manager,
28100 which keeps track of all the types that need to be resolved after
28101 the parsing has finished.
28103 2001-05-13 Miguel de Icaza <miguel@ximian.com>
28105 * ARGH. We are going to have to store `foreach' as a class rather
28106 than resolving it, as we need to verify error 1579 after name
28107 resolution. *OR* we could keep a flag that says `This request to
28108 IEnumerator comes from a foreach statement' which we can then use
28109 to generate the error.
28111 2001-05-10 Miguel de Icaza <miguel@ximian.com>
28113 * class.cs (TypeContainer.AddMethod): we now add methods to the
28114 MethodGroup instead of the method hashtable.
28116 * expression.cs: Add MethodGroup abstraction, which gets us one
28117 step closer to the specification in the way we handle method
28120 * cs-parser.jay (primary_expression): qualified_identifier now
28121 tried to match up an identifier to a local variable reference or
28122 to a parameter reference.
28124 current_local_parameters is now a parser global variable that
28125 points to the current parameters for the block, used during name
28128 (property_declaration): Now creates an implicit `value' argument to
28131 2001-05-09 Miguel de Icaza <miguel@ximian.com>
28133 * parameter.cs: Do not use `param' arguments as part of the
28134 signature, per the spec.
28136 2001-05-08 Miguel de Icaza <miguel@ximian.com>
28138 * decl.cs: Base class for classes, structs and interfaces. This
28139 is the "Declaration Space"
28141 * cs-parser.jay: Use CheckDef for checking declaration errors
28142 instead of having one on each function.
28144 * class.cs: Factor out some code for handling error handling in
28145 accordance to the "Declarations" section in the "Basic Concepts"
28146 chapter in the ECMA C# spec.
28148 * interface.cs: Make all interface member classes derive from
28149 InterfaceMemberBase.
28151 2001-05-07 Miguel de Icaza <miguel@ximian.com>
28153 * Many things: all interfaces are parsed and generated in
28154 gen-treedump. Support for member variables, constructors,
28155 destructors, properties, constants is there.
28157 Beginning of the IL backend, but very little done, just there for
28160 2001-04-29 Miguel de Icaza <miguel@ximian.com>
28162 * cs-parser.jay: Fix labeled statement.
28164 * cs-tokenizer.cs (escape): Escape " and ' always.
28165 ref_line, ref_name: keep track of the line/filename as instructed
28166 by #line by the compiler.
28169 2001-04-27 Miguel de Icaza <miguel@ximian.com>
28171 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
28172 to match the values in System.CodeDOM.
28174 Divid renamed to Divide.
28176 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
28178 (Statements.set): remove.
28180 * System.CodeDOM/CodeCatchClause.cs: always have a valid
28183 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
28184 falseStatements always have valid values.
28186 * cs-parser.jay: Use System.CodeDOM now.