1 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
4 * expression.cs (Binary.IsUnsignedType): Fix typo.
6 2008-01-22 Marek Safar <marek.safar@gmail.com>
8 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
10 2008-01-22 Marek Safar <marek.safar@gmail.com>
13 * ecore.cs, expression.cs: Wider range of extension method supported
16 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
18 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
19 AssemblyBuilder to operate in compiler context. Fixes mcs part of
22 2008-01-22 Marek Safar <marek.safar@gmail.com>
25 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
27 2008-01-22 Miguel de Icaza <miguel@novell.com>
29 * expression.cs (CreateExpressionTree): Add support for or and
30 logical or, and indent following the coding conventions.
32 * typemanager.cs (LinqExpression): renamed from
33 ExpressionTreeManager, for a shorter name.
35 Use TypeManager.CoreLookupType to lookup types from our core
36 assemblies and turn those into "Type" variables.
38 Consumers that previously used "Namespace" and "Type" from this
39 class should instead use the TypeExpression which is a type that
40 is fully resolved (without involving the regular C# resolution
43 This typically looks like this:
45 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
46 new MemberAccess (texpr, name, type_arguments, loc)
48 This avoids the problem in: #355178
50 2008-01-21 Marek Safar <marek.safar@gmail.com>
52 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
53 feature in parser only as we do in other cases.
55 2008-01-21 Marek Safar <marek.safar@gmail.com>
57 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
58 typemanager.cs: A refactoring of params arguments to reuse existing
59 expressions (params -> array initializer) to emit params argument instead
60 of specialized handling.
61 It was required by expression tree implementation and it has other benefits
62 as well, we now apply same optimization for params arguments as we do for
65 2008-01-18 Marek Safar <marek.safar@gmail.com>
68 * generic.cs: A type inference of params arguments may not required any
69 temporary array creation.
71 2008-01-18 Marek Safar <marek.safar@gmail.com>
74 * generic.cs, ecore.cs, expression.cs: A method group type inference is
75 supported for delegates only.
77 2008-01-18 Marek Safar <marek.safar@gmail.com>
79 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
80 type for more than 1 candidates.
82 2008-01-18 Marek Safar <marek.safar@gmail.com>
84 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
87 2008-01-16 Marek Safar <marek.safar@gmail.com>
89 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
90 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
91 operator) expressions.
93 2008-01-16 Zoltan Varga <vargaz@gmail.com>
95 * statement.cs: Avoid declaring an IL variable for this_variable since it is
96 not accessed from the generated IL.
98 2008-01-14 Marek Safar <marek.safar@gmail.com>
100 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
101 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
102 statement.cs: The first expression tree implementation drop, mostly
105 2008-01-14 Marek Safar <marek.safar@gmail.com>
107 * ecore.cs (IsNestedChild): Refactored.
109 2008-01-11 Marek Safar <marek.safar@gmail.com>
111 * lambda.cs: Don't use a cast on unknown expression statement.
113 2008-01-10 Geoff Norton <gnorton@novell.com>
115 * cs-tokenizer.cs: One more token to distinguish between method and lambda
118 2008-01-09 Marek Safar <marek.safar@gmail.com>
120 * doc.cs: Report better /doc crash details.
122 2008-01-09 Marek Safar <marek.safar@gmail.com>
124 A fix for bug #352536
125 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
127 2008-01-08 Marek Safar <marek.safar@gmail.com>
129 A fix for bug #352287
130 * ecore.cs, expression.cs: Do `this' access checking in all member access
133 2008-01-08 Marek Safar <marek.safar@gmail.com>
135 * rootcontext.cs, driver.cs: Switch to linq mode by default.
137 * report.cs: Reset message stacks.
139 2008-01-08 Marek Safar <marek.safar@gmail.com>
141 * generic.cs (InferInPhases): Correctly calculate params position.
143 2008-01-08 Marek Safar <marek.safar@gmail.com>
145 * cs-tokenizer.cs: No need to parse full string when parsing lambda
148 2008-01-07 Marek Safar <marek.safar@gmail.com>
150 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
152 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
154 * driver.cs: Updated --help option.
156 2008-01-07 Marek Safar <marek.safar@gmail.com>
158 * generic.cs (InferParamsTypeArguments): Removed.
159 (InferInPhases): Add params type inference.
160 (LowerBoundInference): Fixed scoring mechanism.
162 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
164 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
166 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
167 byte array for unsigned "baked" assemblies.
169 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
171 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
172 array for assemblies that are not strongnamed.
174 2008-01-04 Marek Safar <marek.safar@gmail.com>
176 A fix for bug #351481
177 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
178 declaring type for nested generic types.
180 2008-01-04 Marek Safar <marek.safar@gmail.com>
182 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
185 2008-01-03 Marek Safar <marek.safar@gmail.com>
187 A fix for bug #351047
188 * expression.cs (Binary.ResolveOperator): Allow equality operators between
189 null and structs only when equality and inequality operators are defined
190 either as an user-operators or predefined operators.
192 2008-01-03 Marek Safar <marek.safar@gmail.com>
194 A fix for bug #351047
195 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
197 2008-01-03 Marek Safar <marek.safar@gmail.com>
199 A fix for bug #351257
200 * cs-tokenizer.cs: Advance line number for '\r' correctly.
202 2008-01-03 Marek Safar <marek.safar@gmail.com>
204 A fix for bug #351157
205 * class.cs (Using): Fixed yet another broken cloning.
207 (Block): Put back more sensible default value for statements.
209 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
211 * codegen.cs: Allow AssemblyVersion with only major version component.
214 2007-12-29 Marek Safar <marek.safar@gmail.com>
216 A fix for bug #324654
217 * class.cs: Use FullName property as member name.
219 2007-12-28 Marek Safar <marek.safar@gmail.com>
221 A fix for bug #342117
222 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
223 constructor constraint.
225 2007-12-28 Marek Safar <marek.safar@gmail.com>
227 A fix for bug #338273
228 * class.cs (ProbertyBase): Access modifier checks are required for overrides
231 2007-12-28 Marek Safar <marek.safar@gmail.com>
233 A fix for bug #350839
234 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
236 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
238 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
241 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
243 * statement.cs: Changed some Hashtables to use HybridDictionaries
244 instead. It was observed that some HashTables only contained a few
245 items in the vast majority of cases. Since HybridDictionary is
246 more efficient on small sets (<10 elements), "known_variables"
247 from class ExplicitBlock as well as "labels" and "constants " from
248 class Block were changed to HybridDictionaries.
250 Atsai results: (56216kb->54987kb)
252 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
255 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
257 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
260 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
262 * expression.cs: foreach loop to for loop, saved on allocation of
263 enumerator (59333kb->59141kb)
265 * statement.cs. Changed foreach loops to for loops, saved on
266 allocation of enumerator (59141kb->59006kb)
268 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
269 when constructed with no specified capacity. This was causing a
270 few ArrayLists to allocate more memory than they would potentially
271 need in the Block class and MemberCache class. Setting the
272 ArrayLists to construct with a capacity of 1 saves some
273 memory. (56216kb->55585kb)
275 2007-12-27 Marek Safar <marek.safar@gmail.com>
277 A fix for bug #347189 (2nd issue)
278 * expression.cs (MemberAccess): Nested type can be found in base non-generic
281 2007-12-27 Miguel de Icaza <miguel@novell.com>
283 * report.cs: Do not use colors if stdout and stderr are not a
286 2007-12-27 Marek Safar <marek.safar@gmail.com>
288 A fix for bug #346998
289 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
292 2007-12-27 Marek Safar <marek.safar@gmail.com>
294 A fix for bug #343465
295 * class.cs: Explicit method name for nested types uses dots only.
297 2007-12-27 Marek Safar <marek.safar@gmail.com>
299 A fix for bug #343707
300 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
302 2007-12-27 Marek Safar <marek.safar@gmail.com>
304 * ecore.cs: Report type inference errors only when arguments count matches
307 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
309 * expression.cs, report.cs: New warning.
311 * typemanager.cs: Catch anonymous method type too.
313 2007-12-23 Marek Safar <marek.safar@gmail.com>
315 A fix for bug #346379
316 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
318 2007-12-23 Marek Safar <marek.safar@gmail.com>
320 A fix for bug #347359
321 * expression.cs (Invocation): Don't resolve already resolved expression.
323 2007-12-23 Marek Safar <marek.safar@gmail.com>
325 A fix for bug #347189
326 * class.cs (FixedField): Use non-dependent code only in the define phase.
328 2007-12-23 Marek Safar <marek.safar@gmail.com>
330 A fix for bug #348076
331 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
333 2007-12-22 Marek Safar <marek.safar@gmail.com>
335 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
336 discovered extension methods.
338 2007-12-22 Marek Safar <marek.safar@gmail.com>
340 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
343 2007-12-21 Miguel de Icaza <miguel@novell.com>
345 * report.cs (ErrorMessage): Add support for using colors on
346 terminals that support it.
348 2007-12-21 Marek Safar <marek.safar@gmail.com>
350 * ecore.cs: Use information about expanded params for error reporting.
352 2007-12-21 Marek Safar <marek.safar@gmail.com>
354 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
355 and logic for params overloads.
357 2007-12-15 Miguel de Icaza <miguel@novell.com>
359 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
360 as this is also created from the parser. Fixes #349034
362 2007-12-12 Miguel de Icaza <miguel@novell.com>
364 * statement.cs (Throw.CloneTo): it is valid to have empty
365 expressions for throw.
367 2007-12-03 Marek Safar <marek.safar@gmail.com>
369 * cs-parser.jay: Set delegate constraint parsing region correctly.
371 2007-12-03 Marek Safar <marek.safar@gmail.com>
373 A fix for bug #345467
374 * typemanager.cs (IsEqual): Compare generic parameters position only.
376 2007-11-28 Marek Safar <marek.safar@gmail.com>
378 * expression.cs (BaseAccess): Type arguments can be null.
380 2007-11-27 Raja R Harinath <harinath@gmail.com>
382 * statement.cs (Block.Resolve): Ensure flow-branching tree is
383 consistent even when an error has occured.
384 (Switch.Resolve): Likewise.
386 2007-11-22 Marek Safar <marek.safar@gmail.com>
388 A fix for bug #334505
389 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
392 2007-11-22 Marek Safar <marek.safar@gmail.com>
394 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
395 refactorings required to resolve extension methods correctly when mixing
396 generics and non-generics members.
398 2007-11-20 Marek Safar <marek.safar@gmail.com>
400 A fix for bug #342584
401 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
404 2007-11-19 Marek Safar <marek.safar@gmail.com>
406 A fix for bug #342512
407 * delegate.cs: Use delegate argument expression when is available. Don't
408 emit virtual call when class is sealed.
410 2007-11-16 Marek Safar <marek.safar@gmail.com>
412 A fix for bug #325423
413 * assign.cs (FieldInitializer): Use resolved expression for emit.
415 * class.cs: Print less confusing error message.
417 2007-11-16 Marek Safar <marek.safar@gmail.com>
419 * cs-tokenizer.cs: Removed GMCS ifdefs.
421 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
424 * cs-parser.jay: Disabled nullable check.
426 * generic-mcs: Copied more generic stuff.
428 2007-11-16 Marek Safar <marek.safar@gmail.com>
430 * gcs-parser.jay: Merged to cs-parser.jay.
432 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
433 * *.csproj, *.sources: Updated to use only jay parser file.
435 2007-11-16 Marek Safar <marek.safar@gmail.com>
437 * gcs-parser.jay: Added nullable and default expression feature checks.
439 2007-11-16 Marek Safar <marek.safar@gmail.com>
441 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
442 it fixes many TODOs and hidden bugs.
444 * expression: Removed duplicate error check.
446 2007-11-15 Marek Safar <marek.safar@gmail.com>
448 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
449 implicitly type local variable only when it is used in a declaration.
451 2007-11-15 Marek Safar <marek.safar@gmail.com>
453 * attribute.cs: Use CS0612 for empty strings.
455 2007-11-14 Marek Safar <marek.safar@gmail.com>
457 * lambda.cs, statement.cs: Contextual return may act as a statement.
459 2007-11-14 Marek Safar <marek.safar@gmail.com>
461 A fix for a regression cause by #324222
462 * class.cs: Don't report unused even when it implements an interface.
464 2007-11-13 Marek Safar <marek.safar@gmail.com>
466 A fix for bug #341205
467 * ecore.cs, expression.cs: Method group expression cannot do static
468 method access with an instance reference check before overloading takes
471 2007-11-13 Marek Safar <marek.safar@gmail.com>
473 A fix for bug #325359
474 * class.cs: Use predictable name for automatically generated property.
476 2007-11-12 Marek Safar <marek.safar@gmail.com>
478 A fix for bug #324996
479 * expression.cs (Is): Handle case where D is nullable and T is not
482 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
484 2007-11-12 Marek Safar <marek.safar@gmail.com>
486 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
487 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
488 Flush small error reporting changes.
490 2007-11-09 Marek Safar <marek.safar@gmail.com>
492 A fix for bug #324996
493 * expression.cs: Rewrote Is expression implementation to work with
494 generics, nullable types, anonymous method. A const result expression
495 uses existing infrastructure instead of custom not fully-featured one.
497 2007-11-08 Marek Safar <marek.safar@gmail.com>
499 A fix for bug #340202
500 * class.cs: Consider generics for volatile field.
502 2007-11-08 Marek Safar <marek.safar@gmail.com>
504 A fix for bug #335594
505 * expression.cs: Use conversion rules when handling string addition.
507 2007-11-07 Marek Safar <marek.safar@gmail.com>
509 A fix for bug #336651
510 * expression.cs: Fixed a crash when probing is on.
512 2007-11-07 Marek Safar <marek.safar@gmail.com>
514 A fix for bug #324242
515 * covert.cs: Added a conversion from any nullable-type with an
516 underlying enum-type to the type System.Enum.
518 2007-11-07 Marek Safar <marek.safar@gmail.com>
520 A fix for bug #324222
521 * class.cs: Report all non-used event fields.
523 2007-11-07 Marek Safar <marek.safar@gmail.com>
525 A fix for bug #325161
526 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
527 qualifier for generic types.
529 2007-11-07 Marek Safar <marek.safar@gmail.com>
531 A fix for bug #322971
532 * expression.cs, ecore.cs: Added intermediate result value check for
535 2007-11-07 Marek Safar <marek.safar@gmail.com>
537 A fix for bug #324754
538 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
539 when it was requested.
541 2007-11-07 Marek Safar <marek.safar@gmail.com>
543 A fix for bug #325101
544 * expression.cs: Do type not value comparison for `is' expression.
546 2007-11-07 Marek Safar <marek.safar@gmail.com>
548 A fix for bug #320236
549 * convert.cs: Don't apply user conversion on underlying target type.
551 2007-11-06 Marek Safar <marek.safar@gmail.com>
553 * expression.cs: Don't use unresolved expression for error reporting.
555 2007-11-06 Marek Safar <marek.safar@gmail.com>
557 A fix for bugs #337712, #324490
558 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
559 overloading resolution too.
561 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
562 the process consistent and more robust.
564 * expression.cs, linq.cs, report.cs: Update.
566 2007-11-02 Marek Safar <marek.safar@gmail.com>
568 A fix for bug #332909
569 * attribute.cs: Resolve attributes in correct context using error
572 * rootcontext.cs: Define Obsolete attribute members as core members.
574 2007-11-02 Marek Safar <marek.safar@gmail.com>
576 * statement.cs: Removed unused methods.
578 2007-10-31 Wade Berrier <wberrier@novell.com>
580 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
581 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
584 2007-10-31 Marek Safar <marek.safar@gmail.com>
586 A fix for bug #338102
587 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
588 methods registered as non-generics.
590 2007-10-31 Marek Safar <marek.safar@gmail.com>
592 A fix for bugs #337712, #324490
593 * delegate.cs: Delegate covariance and contravariance is not allowed for
596 2007-10-31 Marek Safar <marek.safar@gmail.com>
598 A fix for bug #337719
599 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
602 2007-10-30 Marek Safar <marek.safar@gmail.com>
604 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
606 2007-10-29 Marek Safar <marek.safar@gmail.com>
608 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
611 2007-10-29 Raja R Harinath <rharinath@novell.com>
613 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
615 2007-10-29 Marek Safar <marek.safar@gmail.com>
617 A fix for bug #334652
618 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
619 extension methods when we have not found the best candidate in normal
622 2007-10-27 Marek Safar <marek.safar@gmail.com>
624 * AssemblyInfo.cs: Keep up-to-date.
626 2007-10-27 Marek Safar <marek.safar@gmail.com>
628 * Makefile: Fixed generics compiler name.
630 2007-10-27 Marek Safar <marek.safar@gmail.com>
632 * lambda.test: removed, lambda parsing is done differently.
634 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
636 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
638 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
640 2007-10-27 Marek Safar <marek.safar@gmail.com>
642 * Makefile, *.sources : All C# compilers are in mcs folder.
644 * *.cs: Use existing 2_1 define for smcs.
646 2007-10-26 Marek Safar <marek.safar@gmail.com>
648 A fix for bug #335847
649 * assign.cs, expression.cs: Couple of changes to avoid creating a
650 temporary variable for each object initializer assignment statement. It
651 simplifies struct initialization too, otherwise two temporary variables
653 Implemented optimization of redundant default element initializers.
655 2007-10-25 Marek Safar <marek.safar@gmail.com>
657 A fix for bug #336766
658 * expression.cs (Class.CheckBase): Use generic name when method is
661 2007-10-25 Marek Safar <marek.safar@gmail.com>
663 A fix for bug #334737
664 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
665 variable and not variable argument for prepared copies.
667 2007-10-24 Marek Safar <marek.safar@gmail.com>
669 A fix for bug #325110
670 * class.cs, expression.cs, attribute.cs: Use open generic method when
671 checking conditional attribute.
673 2007-10-24 Marek Safar <marek.safar@gmail.com>
675 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
676 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
677 FeatureIsNotAvailable.
679 2007-10-24 Marek Safar <marek.safar@gmail.com>
681 ** C# 3.0 Partial methods
683 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
684 methods support. Because of member cache issue with generics only
685 non-generics partial methods are fully supported.
687 2007-10-23 Marek Safar <marek.safar@gmail.com>
689 * class.cs, decl.cs: Rewrote member overloads check to cope with
690 generics and to use member cache for member checking. It also improves
691 performance and fixes remaining overloads issues.
693 2007-10-20 Marek Safar <marek.safar@gmail.com>
695 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
696 roottypes.cs, typemanager.cs:
698 A member cache creation logic changed to add members immediately and
699 not rely on fallback. The member cache is now only prefered way
700 how to access and find type declaration members. It saves 5 MB of memory
701 during MWF compilation and makes code ready for more optimizations and
702 clean-ups, it's also a pre-requirement for partial methods.
704 2007-10-18 Raja R Harinath <harinath@gmail.com>
706 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
707 handling for generic parameters.
709 2007-10-15 Marek Safar <marek.safar@gmail.com>
711 * class.cs (FixedField): Removed redundant volatile check.
713 2007-10-15 Marek Safar <marek.safar@gmail.com>
715 * class.cs, decl.cs: Fixed overload members verification to do only one
716 check per possible collision.
718 2007-10-13 Marek Safar <marek.safar@gmail.com>
720 A fix for bug #325478
721 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
722 and create only one disposable flags container.
724 2007-10-12 Marek Safar <marek.safar@gmail.com>
726 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
727 * statement.cs (Fixed): Fixed variables cloning.
729 2007-10-12 Marek Safar <marek.safar@gmail.com>
731 A fix for bug #333342
732 * class.cs (EventField): Don't mark value type event as synchronized.
734 2007-10-12 Marek Safar <marek.safar@gmail.com>
736 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
737 inference to identify best candidate method correctly.
738 (ProperyExpr): A range variable is read only and cannot be modified.
740 2007-10-11 Marek Safar <marek.safar@gmail.com>
742 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
743 logic to identify best candidate method correctly.
745 2007-10-11 Marek Safar <marek.safar@gmail.com>
747 * location.cs (Equals, GetHashCode): Removed.
749 2007-10-11 Marek Safar <marek.safar@gmail.com>
751 * report.cs: Implemented message recorder. It is used mainly for lambda
752 expressions to capture otherwise swallowed error messages.
754 * anonymous.cs, lambda.cs.cs: Do full parameters check.
756 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
758 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
760 * expression.cs (MemberAccess): Always report lookup failure.
762 * location.cs: Implemented Equals, GetHashCode.
764 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
766 2007-10-10 Jb Evain <jbevain@novell.com>
768 * codegen.cs: re-enable assembly version check.
770 2007-10-09 Marek Safar <marek.safar@gmail.com>
772 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
775 * namespace.cs (UsingAlias): Do correct version check.
777 2007-10-08 Marek Safar <marek.safar@gmail.com>
779 * expresison.cs, ecore.cs: Issue extension method error message when
782 * rootcontext.cs: Added ISO_2 compiler mode option.
784 2007-10-08 Marek Safar <marek.safar@gmail.com>
786 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
789 2007-10-08 Marek Safar <marek.safar@gmail.com>
791 * attribute.cs (GetString, GetBoolean): Work with both literal and
794 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
795 Moved method overload specific methods to MethodGroupExpr.
797 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
798 it should be less memory consuming.
800 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
802 * codegen.cs: remove the assembly version check until the buildbot is
805 2007-10-07 Jb Evain <jbevain@novell.com>
807 * attribute.cs (Attribute.GetString): if the value
808 expression is a StringConstant, return its string value.
810 2007-10-07 Jb Evain <jbevain@novell.com>
812 * typemanager.cs: add `assembly_version_attribute_type`.
813 * codegen.cs: on attribute emission, check that the
814 AssemblyVersionAttribute doesn't overflow.
816 2007-10-05 Marek Safar <marek.safar@gmail.com>
818 A fix for bug #324677
819 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
820 parent container of a scope container with currently resolved one.
822 2007-10-05 Marek Safar <marek.safar@gmail.com>
824 A fix for bug #325534
825 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
828 2007-10-05 Marek Safar <marek.safar@gmail.com>
830 A fix for bug #327504
831 * class.cs (Operator.Define): Refactored implicit and explicit user
832 operator conversion rules.
834 2007-10-05 Marek Safar <marek.safar@gmail.com>
836 A fix for bug #327520
837 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
839 2007-10-04 Marek Safar <marek.safar@gmail.com>
841 A fix for bug #328022
842 * class.cs (MethodData.Define): Use correct method to check whether
843 a method implementents an accessor.
845 2007-10-04 Marek Safar <marek.safar@gmail.com>
847 A fix for bug #330069
848 * statement.cs (Fixed.Resolve): Read the first array element only when
849 an array is instantiated.
851 2007-10-04 Marek Safar <marek.safar@gmail.com>
853 * expression.cs, assign.cs, generics.cs: Print correct operator when
854 compound assignment is used.
856 2007-10-04 Marek Safar <marek.safar@gmail.com>
858 A fix for bug #325841
859 * expression.cs (ArrayAccess): Use full argument cloning only for
860 string compound concatenation.
862 2007-10-03 Marek Safar <marek.safar@gmail.com>
864 A fix for bug #328774
865 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
867 (PropertyExpr.EmitAssign): Fixed string concatenation compound
870 2007-10-03 Raja R Harinath <rharinath@novell.com>
873 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
874 Event accessibility checks here. Remove some bogus code that
875 accidently made GenericMethods work.
876 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
878 2007-09-25 Marek Safar <marek.safar@gmail.com>
880 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
882 * statement.cs (Block): Refactored AddVariable to allow error handling
885 * generic.cs: New stub.
887 2007-09-23 Marek Safar <marek.safar@gmail.com>
889 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
892 2007-09-17 Marek Safar <marek.safar@gmail.com>
894 * class.cs: Use partial container to record whether any partial part
895 contains static field initializer and therefore default contructor has
898 2007-09-14 Marek Safar <marek.safar@gmail.com>
900 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
901 mono-list when only one of two partial parts has defined accessibility
904 2007-09-14 Marek Safar <marek.safar@gmail.com>
908 * class.cs (TypeContainer): Set correct resolve context for all field
911 2007-09-13 Marek Safar <marek.safar@gmail.com>
913 * assign.cs: Fixed a crash when field is resolved twice with an error.
915 * codegen.cs: Changed InFieldInitializer to be flag.
917 * anonymous.cs, ecore.cs, expression.cs: Update after
918 IsInFieldInitializer rename.
920 * const.cs: Removed unused parameter.
922 * class.cs: Changed the way how we resolve and emit field initializers.
923 The field initilizers have to have access to contructor block to emit
924 compiler generated code.
926 2007-09-13 Marek Safar <marek.safar@gmail.com>
928 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
929 generics use TypeContainer instead.
931 2007-09-12 Marek Safar <marek.safar@gmail.com>
933 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
935 * lambda.cs (ResolveParameters): Use more powerful
936 InflateGenericArgument.
938 * parameters.cs: Better exception message.
940 2007-09-10 Marek Safar <marek.safar@gmail.com>
942 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
943 correct expression block type.
945 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
947 * expression.cs (Invocation): Extracted method group resolve to
950 2007-09-07 Marek Safar <marek.safar@gmail.com>
952 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
953 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
955 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
956 generic extension methods.
958 2007-09-06 Marek Safar <marek.safar@gmail.com>
960 A fix for bug #82676 (Do I get it right now?)
961 * convert.cs (Binary.ResolveOperator): An interface is converted to the
962 object before a standard conversion is applied.
964 2007-09-06 Marek Safar <marek.safar@gmail.com>
966 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
969 2007-09-05 Marek Safar <marek.safar@gmail.com>
972 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
973 non-generic interface types.
975 2007-09-05 Marek Safar <marek.safar@gmail.com>
978 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
980 2007-09-05 Marek Safar <marek.safar@gmail.com>
983 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
984 modifier for container based methods.
986 2007-09-05 Marek Safar <marek.safar@gmail.com>
989 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
990 any interface-type T means to any of interface type T.
992 2007-09-04 Marek Safar <marek.safar@gmail.com>
994 * namespace.cs: We have 2 versions of System.Core assembly.
996 2007-09-04 Marek Safar <marek.safar@gmail.com>
999 * class.cs (Class.GetClassBases): Compare types and not expressions.
1001 2007-09-04 Marek Safar <marek.safar@gmail.com>
1003 A fix for bug #82620
1004 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
1005 actually never worked before.
1006 (IndexerAccess): Emit prepared arguments before they are modified.
1008 2007-09-04 Marek Safar <marek.safar@gmail.com>
1010 A fix for bug #82563
1011 * assign.cs: Revert wrong fix.
1013 * expression.cs (VariableReference.EmitAssign): Handle ref reference
1015 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
1016 Instead of ldelema/stdind we have to use temporary variables to handle
1017 cases like String.Concat (params string[]).
1019 2007-08-31 Marek Safar <marek.safar@gmail.com>
1021 * class.cs: EmitAttributes to Emit rename.
1023 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
1025 (MemberCore.HasClsCompliantAttribute): Don't depend on
1026 GetClsCompliantAttributeValue execution.
1028 2007-08-31 Marek Safar <marek.safar@gmail.com>
1030 * anonymous.cs: Use shorter type prefix.
1032 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
1035 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
1036 variables when probing is on.
1038 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
1039 unresolved variables.
1040 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
1041 handle transparent identifiers.
1043 2007-08-26 Marek Safar <marek.safar@gmail.com>
1045 * attribute.cs (IsClsCompliant): Add nullable types test.
1047 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
1049 * doc.cs : catch other types of exception than XmlException to
1050 report CS1570. Fixed bug #82565.
1052 2007-08-23 Marek Safar <marek.safar@gmail.com>
1054 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
1055 The number of delegate parameters has to match.
1056 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
1059 2007-08-21 Marek Safar <marek.safar@gmail.com>
1061 * anonymous.cs (AnonymousMethod): Generate private anonymous method
1062 to fix problem with private arguments.
1064 2007-08-20 Marek Safar <marek.safar@gmail.com>
1066 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
1068 * decl.cs (MemberName): Ignore generic type with no generic arguments.
1070 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
1071 empty. Add cloning suport.
1073 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
1075 2007-08-20 Marek Safar <marek.safar@gmail.com>
1077 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
1078 to create EmptyCast. It handles EmptyConstantCast specialization for
1081 2007-08-18 Marek Safar <marek.safar@gmail.com>
1083 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
1084 (EmitArrayArgument): One routine for array arguments.
1085 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
1087 2007-08-17 Marek Safar <marek.safar@gmail.com>
1089 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
1091 2007-08-17 Marek Safar <marek.safar@gmail.com>
1093 * anonymous.cs: MemberLookupFinal update.
1095 * class.cs (ConstructorInitializer): Is expression based.
1097 * delegate.cs: MethodGroupExpr update.
1099 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
1101 (Error_MemberLookupFailed): Customizable error override.
1102 (MethodGroupExpr): Keep queried type for later usage.
1103 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
1106 * expression.cs: Error_MemberLookupFailed refactoring.
1107 (New.DoResolve): Resolve as much as possible.
1108 (ElementInitializer.Error_MemberLookupFailed): Object initializer
1109 customization for invalid member types.
1111 * statement.cs: MethodGroupExpr update.
1113 2007-08-16 Marek Safar <marek.safar@gmail.com>
1115 * modifier.cs (Check): Check all modifiers and not only accessibility
1118 2007-08-16 Marek Safar <marek.safar@gmail.com>
1120 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
1121 type and not an expression.
1123 2007-08-16 Marek Safar <marek.safar@gmail.com>
1125 * statement.cs (Catch.Clone): Type and variable can be null.
1127 2007-08-16 Marek Safar <marek.safar@gmail.com>
1129 A fix for bug #81979
1130 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
1131 I am really not sure whether this is the best fix.
1133 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
1136 2007-08-14 Marek Safar <marek.safar@gmail.com>
1138 ** C# 3.0 Object and collection initializers (major re-write)
1140 * assign.cs (DoResolve): Initializers are not assign related.
1142 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
1143 used during collection or object initialization.
1145 * expression.cs (Error_InvalidArguments): Add initializers specific
1146 messages. More will come later because it requires some general
1148 (New.DoResolve): Better error handling for unsafe types.
1149 (EmptyExpressionStatement): New class.
1150 (ElementInitializer): An object initializer expression.
1151 (CollectionElementInitializer): A collection initializer expression.
1152 (CollectionOrObjectInitializers): A block of object or collection
1154 (NewInitialize): New expression with element/object initializers.
1156 * statement.cs: Reverted object/collection initializer hacks.
1158 * typemanager.cs (CSharpName): Filter __arglist type.
1160 2007-08-09 Marek Safar <marek.safar@gmail.com>
1162 ** C# 3.0 Anonymous Types (update to the latest standard)
1164 * expression.cs (Binary.ResolveOperator): Threat all null based types
1166 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
1167 (AnonymousTypeParameter): Updated.
1169 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
1170 (AnonymousTypeClass): New anonymous type container.
1172 * class.cs (AddField): Return operation result.
1174 * generic.cs: Another empty TypeArguments overload.
1176 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
1177 are stored at top of normal hierarchy.
1179 * typemanager.cs (CSharpName): Filter anonymous types.
1181 2007-08-09 Marek Safar <marek.safar@gmail.com>
1183 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
1184 as single Concat call. How could we miss that :-(
1186 2007-08-08 Marek Safar <marek.safar@gmail.com>
1188 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
1190 2007-08-07 Miguel de Icaza <miguel@novell.com>
1192 * expression.cs: Fix the previous commit, the creation of the
1193 arguments array list needs also to be conditional on the arguments
1196 * class.cs: Add a little bit of help to help narrow down problems.
1198 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
1199 not try to copy in that case.
1201 * driver.cs: When building SMCS, include a new different set of
1202 default assemblies here. Do this here so we can control whether
1203 to include the default assemblies with /noconfig.
1205 2007-08-03 Marek Safar <marek.safar@gmail.com>
1207 A fix for bug #81979
1208 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
1211 2007-08-03 Marek Safar <marek.safar@gmail.com>
1213 A fix for bug #82300
1215 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
1216 we are in probing scope.
1218 2007-08-03 Marek Safar <marek.safar@gmail.com>
1220 A fix for bug #82301
1222 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
1223 (Statement.CloneTo): Clone and not map children blocks.
1225 2007-08-03 Marek Safar <marek.safar@gmail.com>
1227 A fix for bug #82299
1229 * expression.cs (LocalVariableReference.CloneTo): Remap local info
1232 * statement.cs (Statement.CloneTo): Clone variables before statements
1233 to allow remaping of local variables.
1235 2007-08-03 Marek Safar <marek.safar@gmail.com>
1237 A fix for bug #82296
1240 * report.cs: Log crash details for future clone problems.
1242 * statement.cs (Return.Clone): Don't clone non-existent expression.
1244 2007-08-03 Raja R Harinath <harinath@gmail.com>
1246 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
1247 (Class.AddBasesForPart): Move CS0537 check here from ...
1248 * cs-parser.jay (class_declaration): ... here. Move calling of
1249 'AddBasesForPart' to ...
1250 (class_bases): ... here.
1251 (struct_declaration, interface_declaration): Update to changes.
1253 2007-08-02 Marek Safar <marek.safar@gmail.com>
1255 A fix for bug #81923
1257 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
1258 conversion is allowed.
1260 2007-08-02 Marek Safar <marek.safar@gmail.com>
1262 A fix for bug #81564
1264 * ecore.cs (EventExpr): Add IsBase handling.
1266 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
1269 2007-08-02 Raja R Harinath <harinath@gmail.com>
1271 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
1272 * cs-parser.jay: Some whitespace cleanups.
1273 (current_delegate): New.
1275 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
1276 a dummy code block, and use 'type_name' instead of 'member_name'.
1277 (interface_declaration, class_declaration): Likewise.
1278 (delegate_declaration): Likewise. Rearrange slightly and use
1280 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
1281 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
1283 2007-08-02 Marek Safar <marek.safar@gmail.com>
1285 A fix for bug #82039
1287 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
1290 * typemanager.cs (CSharpName): Split to string overload.
1292 2007-08-02 Marek Safar <marek.safar@gmail.com>
1295 * report.cs: Updated warning CS0472.
1297 2007-08-01 Marek Safar <marek.safar@gmail.com>
1299 A fix for bug #82181
1301 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
1303 2007-08-01 Marek Safar <marek.safar@gmail.com>
1305 A fix for bug #82277
1306 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
1308 2007-08-01 Marek Safar <marek.safar@gmail.com>
1310 ** C# 3.0 Type Inference (major bits are working)
1312 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
1313 (.ImplicitStandardConversionExists): Uses compatible.
1314 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
1315 (.InferReturnType): New method.
1316 (.Compatible): Refactored.
1317 (.ResolveParameters): Uses factory to create resolved parameters.
1318 (.CompatibleMethod): Add probing mode support.
1319 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
1320 clearly distinguish between 2 different operations.
1321 (LambdaMethod): Moved to lambda.cs.
1322 (AnonymousMethod): Removed unused fields and methods.
1323 (AnonymousDelegate): Simplified.
1325 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
1327 * convert. cs (ImplicitConversionStandard): Compatible works differently.
1329 * delegate.cs (Delegate): New mehods to reduce code duplication.
1330 (.GetConstructor): New method.
1331 (.GetInvokeMethod): New method.
1332 (DelegateCreation): Updated.
1334 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
1336 (OverloadResolve): Made probing little bit faster.
1338 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
1341 * generic.cs (TypeInferenceContext): Dummy implementation.
1343 * iterators.cs: Updated after Resolve/Define rename.
1345 * lambda.cs (LambdaExpression)
1346 (.ResolveParameters): Handles both type of arguments and type inference too.
1348 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
1349 (InflateTypes): Updated.
1351 * support.cs (InflateTypes): Changed signature and updated.
1353 * typemanager.cs (LookupMemberCache): Better dynamic type check.
1354 (MemberLookup_FindMembers): More MS tricks.
1355 (GetParameterData): Ditto.
1356 (GetDelegateParameters): Uses quick path for dynamic types.
1358 2007-08-01 Marek Safar <marek.safar@gmail.com>
1360 * class.cs (MethodData.Define): EmitContext is required for generic stuff
1363 2007-07-31 Marek Safar <marek.safar@gmail.com>
1365 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
1368 2007-07-26 Jb Evain <jbevain@novell.com>
1370 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
1371 which takes a boolean 'report_errors', similar to the GetMethod.
1372 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
1373 in .net 2.1, do not report errors here.
1375 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
1376 System.Runtime.CompilerServices.RequiredAttributeAttribute and
1377 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
1380 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
1381 of the type InternalsVisibleToAttribute before the first call
1382 to CoreLookupType which is allowed to fail (third boolean parameter
1383 to true). Because, during the resolution for a type that is not
1384 immediately found, we try to check if the type is not defined in
1385 a friend assembly, and to do so, we need the
1386 InternalVisibleToAttribute.
1388 2007-07-23 Miguel de Icaza <miguel@novell.com>
1390 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
1391 feature that allows structs to be compared against null and inline
1392 the result as true or false.
1394 Notice that the same code is not permitted inside a generic block
1395 of code that would do:
1397 class Foo<T> where T : struct {
1404 It is only allowed if the type of T is not bound (no where
1405 clause). In my opinion, this CSC 2 behavior is broken but people
1406 seem to be using it (IronRuby does, a few bug reports on bugzilla
1407 have it and some people have complained about it).
1409 All of the users that depend on this behavior have code that is
1412 * report.cs (Warning, Error): make these take object arguments,
1413 not strings, as that allows us to take advantage of Format.
1415 2007-07-20 William Holmes <billholmes54@gmail.com>
1417 * decl.cs: Changed MemberName.CountTypeArguments to also check the
1418 Left member variable for the Count.
1419 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
1420 MemberName.CountTypeArguments to avoid a NRE.
1422 This code is contributed under the MIT X11 license
1424 2007-07-18 Marek Safar <marek.safar@gmail.com>
1426 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
1428 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1430 * doc.cs : generic method arguments are written as ``x while generic
1431 type arguments are `x. Combined with the previous change, fixed bug
1434 2007-07-18 Raja R Harinath <rharinath@novell.com>
1437 * expression.cs (Binary.ResolveOperator): When converting
1438 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
1440 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
1442 * doc.cs : when T: or whatever x: is specified, it does not really
1443 check the doc comment's syntax correctness. Fixed bug #82006.
1445 2007-07-18 Marek Safar <marek.safar@gmail.com>
1447 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
1448 LambdaExpression better.
1450 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
1452 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
1454 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
1455 as it can be generated.
1457 * expression.cs (Invocation.Error_InvalidArguments): Show correct
1460 * lambda.cs (LambdaExpression): Refactored to share same code with
1461 AnonymousMethodExpression.
1463 2007-07-17 Marek Safar <marek.safar@gmail.com>
1465 * anonymous.cs (MakeName): Include host name for easier debugging.
1466 (LambdaMethod): New class for lambda spcecific stuff.
1468 * attribute.cs: Set EmitContext return type.
1470 * class.cs: Set EmitContext return type.
1472 * codegen.cs (EmitContext): Return type cannot be null to stop messing
1473 with null/void meaning.
1475 * iterators.cs (ContainerType): Implemented.
1477 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
1479 * statement.cs (Return): Updated to lambda expressions.
1480 (Block.CloneTo): Parent can be null.
1482 2007-07-13 Marek Safar <marek.safar@gmail.com>
1484 A fix for bug #81917
1485 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
1487 * class.cs (FixedField): Check whether field is in unsafe scope.
1489 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
1490 (FieldExpr.Emit): Fixed buffers cannot be volatile.
1492 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
1495 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
1497 2007-07-13 Marek Safar <marek.safar@gmail.com>
1499 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
1500 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
1503 2007-07-13 Marek Safar <marek.safar@gmail.com>
1505 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
1507 2007-07-13 Marek Safar <marek.safar@gmail.com>
1509 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
1510 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
1512 * codegen.cs(EmitContext): Add ProbingMode flag.
1514 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
1516 * driver.cs: For now set both warning values.
1518 * ecore.cs (SimpleName): Name is readonly.
1519 (MethodGroup.OverloadResolve): One quick path for probing.
1521 * expression.cs (Unary): Set Oper r/o.
1522 (Binary): Set Oper r/o.
1523 (ParameterReference): Set few instance variables as r/o.
1524 (ParameterReference.DoResolveBase): Don't capture aruments when
1526 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
1527 (Arglist): arguments are private.
1528 (SizeOf): type is private and r/o.
1529 (MemberAccess): arguments are private.
1531 * report.cs: Enhanced reporting on/off capabilities.
1533 * lambda.cs: Uses ec.IsInProbingMode.
1534 (ContextualReturn): Derives from return.
1536 * rootcontext.cs: For now set both warning values.
1538 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
1540 (Return.Resolve): Don't die immediately.
1541 (Block.Resolve): Speed-up probing.
1542 (Block.CloneTo): Clone only child blocks.
1544 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
1546 * iterators.cs: reverted Miguel's latest change (r81925) as it
1547 breaks the build in System.
1549 2007-07-13 Miguel de Icaza <miguel@novell.com>
1551 * iterators.cs (Yield.CheckContext): Check for the iterator type
1552 also here as we can call into Yield even in codepaths that are not
1554 (MethodOrOperator is the only path that was checked).
1556 In addition to the standard check, use a more specific check for
1557 constructors to report a more verbose error.
1559 2007-07-12 Miguel de Icaza <miguel@novell.com>
1561 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
1562 report the warning and continue
1564 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
1565 values on the stack on the call to Emit. Use EmitStatement if
1566 possible, or using Emit + Pop if not possible. Fixes #82064
1568 2007-07-12 Raja R Harinath <rharinath@novell.com>
1570 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
1571 avoid try...finally in some cases.
1573 2007-07-10 Marek Safar <marek.safar@gmail.com>
1575 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
1577 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
1578 instead of method. Re-use standard error handling.
1579 (ConstructorInitializer.Emit): Simplified.
1581 * delegate.cs: Updated after Invocation.EmitCall change.
1583 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
1584 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
1585 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
1586 method and don't permanently changing input arguments.
1587 (MethodGroupExpr): Introduced resolved best_candidate, when method group
1588 is resolved it has one of the candidates is the best one which is later
1589 used to emit. Removed a few unused method.
1590 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
1592 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
1593 (Binary.ResolveOperator): Ditto.
1594 (ConditionalLogicalOperator.DoResolve): Ditto.
1595 (Invocation): Uses method group.
1596 (Invocation.DoResolve): Simplified.
1597 (Invocation.EmitCall): Removed useless is_static.
1598 (Invocation.Emit): Delegate to method group.
1599 (Invocation.EmitStatement): Simplified.
1600 (New): Uses method group.
1601 (MemberAccess.DoResolve): Don't destroy original expression.
1603 * statement.cs (ForEach.Resolve): Use null for no method arguments.
1605 2007-07-04 Marek Safar <marek.safar@gmail.com>
1607 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
1610 * lambda.cs: Add custom error message type.
1612 2007-07-03 Marek Safar <marek.safar@gmail.com>
1614 * lambda.cs: Simplified little bit.
1616 * parameter.cs: Introduced ImplicitLambdaParameter.
1617 (Parameters.CreateFullyResolved): New factory instead of ctor.
1621 * delegate.cs: Updated parameter creation.
1623 2007-07-03 Marek Safar <marek.safar@gmail.com>
1625 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
1628 * generic.cs: Synchronized with gmcs.
1630 2007-07-03 Marek Safar <marek.safar@gmail.com>
1632 * class.cs (Indexer): Check return type as soon as possible.
1634 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
1637 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
1639 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
1641 * parameter.cs (Parameter): Use expression type when it is available.
1643 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
1644 method modifier for the first parameter only.
1646 2007-06-24 Marek Safar <marek.safar@gmail.com>
1648 A fix for bug #81938
1649 * typemanager.cs (ChangeType): Fixed couple of char conversions.
1651 * constant.cs: Tide up an exception message.
1653 2007-06-22 Marek Safar <marek.safar@gmail.com>
1655 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
1656 an uninitialized variable is used.
1658 * expression.cs (LocalVariableReference.DoResolve): Ditto.
1660 2007-06-22 Marek Safar <marek.safar@gmail.com>
1662 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
1663 not found error handling.
1665 * expression.cs (ArrayCreation): Removed redundant fields and little bit
1667 (ArrayCreation.ResolveArrayElement): To be ready to customization.
1668 (ArrayCreation.DoResolve): Simplified.
1669 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
1670 its own resolve process.
1671 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
1673 2007-06-20 Marek Safar <marek.safar@gmail.com>
1675 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
1678 2007-06-20 Marek Safar <marek.safar@gmail.com>
1680 * cs-tokenizer.cs: Removed var related stuff.
1682 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
1683 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
1684 a type and a keyword at same time.
1686 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
1689 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
1690 implicitly typed arrays, more changes will follow.
1692 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
1694 2007-06-19 Marek Safar <marek.safar@gmail.com>
1696 * ecore.cs (VarExpr): Removed Handled field.
1698 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
1699 build-in assign functionality.
1700 (ForEach.Resolve): Removed all implicitly typed local variable code and
1702 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
1703 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
1705 2007-06-18 Marek Safar <marek.safar@gmail.com>
1707 * assign.cs: Removed implicitly typed local variable check.
1709 * expression.cs (LocalVariableReference.DoResolve): Add check for self
1710 referencing implicitly typed local variable.
1711 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
1714 * statement.cs (Fixed): Removed unsupported implicitly typed local
1717 2007-06-15 Marek Safar <marek.safar@gmail.com>
1719 * decl.cs (MemberName): Moved all Unbound stuff to parser.
1721 2007-06-14 Marek Safar <marek.safar@gmail.com>
1723 A fix for bugs #81855 and #76274
1724 * attribute.cs (AttachTo): Always set owner for global attributes to
1727 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
1730 * cs-parser.jay: Assembly and module attributes must precede all other
1731 elements except using clauses and extern alias declarations.
1733 2007-06-13 Marek Safar <marek.safar@gmail.com>
1735 A fix for bug #81748
1737 * expression.cs: More checks for non ISO-1 features.
1739 2007-06-12 Marek Safar <marek.safar@gmail.com>
1741 A fix for bug #81807
1742 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
1743 present inside switch statement and it is required by nullable check.
1745 2007-06-12 Marek Safar <marek.safar@gmail.com>
1747 A fix for bug #81840
1748 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
1749 when type matching fails.
1751 * namespace.cs: Tiny error message change.
1753 2007-06-12 Marek Safar <marek.safar@gmail.com>
1755 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
1756 reporting. Added automatic property check.
1758 * class.cs: Updated after CheckAbstractAndExtern relocation.
1759 (AEventPropertyAccessor.GetSignatureForError): Customized.
1761 2007-06-11 Marek Safar <marek.safar@gmail.com>
1763 * class.cs (DefineBaseTypes): Base type can be undefined.
1765 * ecore.cs (TypeLookup): Minor refactoring.
1766 (DoResolveAsTypeStep): Removed redundant check.
1768 * namespace.cs (Lookup): Removed redundant check.
1770 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
1771 ResolveAsTypeTerminal step.
1772 (BootstrapCorlib_*): Simplified.
1773 (PopulateCoreType): Core types can be now external.
1775 2007-06-07 Marek Safar <marek.safar@gmail.com>
1777 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
1779 (InferTypeArguments): Infers anonymous expression type arguments.
1780 (Compatible): Split to Compatible and InferTypeArguments.
1782 * lambda.cs: Updated.
1784 2007-06-08 Marek Safar <marek.safar@gmail.com>
1786 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
1788 2007-06-07 Raja R Harinath <harinath@gmail.com>
1790 Fix #80477, cs0135-2.cs, cs0135-3.cs
1791 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
1792 names to the "known" variables list.
1793 (Block.CheckInvariantMeaningInBlock): Handle the fact the
1794 parameter names are also "known".
1795 (Block.CheckError136): Remove.
1796 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
1799 2007-06-07 Marek Safar <marek.safar@gmail.com>
1801 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
1803 2007-06-06 Marek Safar <marek.safar@gmail.com>
1805 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
1806 internal error not an user error.
1808 * expression.cs (IsApplicable): Refactored to make debugging easier.
1810 * support.cs: More tricks for non-mono runtimes.
1812 * typemanager.cs (CoreLookupType): Made public.
1813 (InitSystemCore): All linq specific stuff moved to linq.cs
1815 2007-06-05 Marek Safar <marek.safar@gmail.com>
1817 * typemanager.cs (CSharpSignature): One more missing build-in types
1819 More tricks for non-mono runtime.
1821 2007-06-05 Raja R Harinath <harinath@gmail.com>
1823 * statement.cs (Block.CheckError136_InParents): Remove.
1824 (Block.AddVariable): Use GetParameterInfo instead.
1825 (ToplevelBlock.ProcessArguments): Likewise.
1827 2007-06-04 Raja R Harinath <rharinath@novell.com>
1829 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
1831 (ToplevelBlock.GetParameterInfo): Split out of ...
1832 (ToplevelBlock.GetParameterRefernce): ... this.
1833 (ToplevelBlock.ParameterMap): Remove.
1834 * expression.cs (ParameterReference): Update to use
1835 ToplevelParameterInfo.
1837 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
1840 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
1841 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
1843 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
1844 (ToplevelBlock.ProcessParameters) ... here.
1845 (ToplevelBlock..ctor): Invoke it.
1847 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
1850 * statement.cs (IKnownVariable): New interface.
1851 (LocalInfo): Implement it.
1852 (ToplevelParameterInfo): New class.
1853 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
1854 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
1855 GetKnownVariableInfo.
1857 2007-06-03 Raja R Harinath <harinath@gmail.com>
1859 Partly speed up CS0136 error checks.
1860 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
1861 'recurse' parameter.
1862 (Block.DoCheckError136): Only check errors in parameters. Move
1863 local variable checks ...
1864 (Block.AddVariable): ... here, and ...
1865 (ToplevelBlock.ResolveMeta): ... here.
1867 2007-06-02 Raja R Harinath <harinath@gmail.com>
1869 * statement.cs (Block.IsChildOf): Remove.
1871 * statement.cs (Statement.Clone): Move special case code ...
1872 (Block.CloneTo): ... here.
1874 2007-05-29 Raja R Harinath <rharinath@novell.com>
1876 * statement.cs (ToplevelBlock.container): Remove field. It's
1877 redundant with 'Parent'.
1878 (ToplevelBlock.ContainerBlock): Remove accessor.
1879 (ToplevelBlock..ctor): Update to changes. Register anonymous
1880 child with parent here, ...
1881 * cs-parser.jay (end_anonymous): ... not here. Don't modify
1883 (start_anonymous): Don't save current_block.
1884 (top_current_block): Remove.
1886 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
1887 (Block.Resolve): Update to changes.
1888 (Block..ctor): Move setting of "correct" 'Toplevel'
1889 and 'Explicit' fields to ...
1890 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
1892 2007-05-27 Raja R Harinath <harinath@gmail.com>
1895 * statement.cs (Block.Implicit): Remove.
1896 (Block): Update to changes.
1897 * flowanalysis.cs: Likewise.
1899 Mildly speed up CheckInvariantMeaningInBlock
1900 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
1901 Recursively call AddKnownVariable to all enclosing blocks.
1902 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
1903 Remove recursive calls.
1904 (Block): Update to changes.
1906 New ExplicitBlock invariants
1907 * statement.cs (Block.Explicit): New field. It points to the
1908 immediately enclosing non-implicit block.
1909 (Block..ctor): Maintain the invariant.
1910 * cs-parser.jay: Take advantage of invariant.
1912 Introduce ExplicitBlock
1913 * statement.cs (ExplicitBlock): New.
1914 (ToplevelBlock): Derive from it.
1915 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
1917 (Block.Implicit): Update to changes.
1918 * cs-parser.jay: Update to changes.
1921 * codegen.cs (EmitContext.IsLastStatement): Remove.
1922 * statement.cs (Block.DoEmit): Update to changes.
1924 2007-05-25 Raja R Harinath <rharinath@novell.com>
1926 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
1927 modifying current_block directly.
1929 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
1931 * class.cs: Implemented automatic properties (C# 3.0)
1932 Thanks to Marek for the help.
1934 2007-05-23 Raja R Harinath <rharinath@novell.com>
1936 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
1937 variable as assigned, note also that all its components are
1939 (MyBitVector.SetRange): New. Function to set multiple bits to true.
1941 2007-05-19 Marek Safar <marek.safar@gmail.com>
1943 * anonymous.cs, class.cs: Emit Compiler generated attribute when
1944 member is marked as compiler generated.
1946 * decl.cs (MemberCore): Refactored ModFlags into property.
1948 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
1949 (Check): Check only accessibility modifiers.
1951 2007-05-18 Raja R Harinath <rharinath@novell.com>
1953 Track all assignable slots in one bit array
1954 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
1955 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
1956 logic from VariableMap constructor here. Use the same 'offset'
1957 variable that's later used for computing offsets of local
1959 * flowanalysis.cs (UsageVector.parameters): Remove.
1960 (UsageVector): Update to changes.
1961 (VariableMap): Remove.
1963 Avoid creating ParameterMap in every block
1964 * statement.cs (Block.ParameterMap): Move ...
1965 (ToplevelBlock.ParameterMap): ... here.
1966 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
1968 * flowanalysis.cs (FlowBranching.param_map): Remove.
1969 (FlowBranching.UsageVector): Update to changes.
1970 (FlowBranchingToplevel.CheckOutParameters): Likewise.
1972 * statement.cs (Block.CloneTo): Clone Toplevel field too.
1974 * expression.cs (ParameterReference): Distinguish between block
1975 where parameter was referenced and declared.
1977 2007-05-18 Marek Safar <marek.safar@gmail.com>
1979 * flowanalysis.cs, statement.cs: Put back improved error handling.
1981 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
1985 Imporved object and collection initialization (C# 3.0).
1987 2007-05-15 Marek Safar <marek.safar@gmail.com>
1989 A fix for bug #81380
1990 * expression.cs (Is.DoResolve): Only value types have constant `is'
1993 2007-05-15 Raja R Harinath <rharinath@novell.com>
1995 * statement.cs (ToplevelBlock.child): Remove.
1997 2007-05-15 Raja R Harinath <harinath@gmail.com>
1999 Rationalize ResolveMeta: refactoring
2000 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
2001 out constant handling code into ...
2002 (Block.DoResolveConstants): ... this.
2004 Rationalize ResolveMeta: kill local_map
2005 * statement.cs (Block.local_map, Block.LocalMap): Remove.
2006 (Block.AssignableSlots): New.
2007 (Block.ResolveMeta): Make protected. Don't create a VariableMap
2008 for locals -- move code from VariableMap here. Avoid unnecessary
2010 * flowanalysis.cs (FlowBranching.local_map): Remove.
2011 (FlowBranching..ctor): Use Block.AssignableSlots.
2012 (VariableMap): Remove unused constructors.
2014 2007-05-11 Raja R Harinath <rharinath@novell.com>
2016 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
2018 2007-05-11 Marek Safar <marek.safar@gmail.com>
2020 * typemanager.cs (IsFriendAssembly): Should not be called for building
2023 2007-05-09 Marek Safar <marek.safar@gmail.com>
2025 * literal.cs (NullConstant): Print null in all cases.
2027 * expression.cs (Binary.ResolveOperator): Implemented delegate
2028 comparison based on C# 2.0 changes.
2030 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
2032 This code is contributed under the MIT X11 license
2034 The following enables support for several C# 3.0 language features:
2036 * cs-tokenizer.cs: Added support for the "var" keyword.
2038 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
2039 Added VarExpr class to facilitate type inferencing.
2041 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
2042 to support anonymous types.
2044 * assign.cs: Added support for type inferencing and initialization.
2046 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
2048 * expression.cs: Added implicit array support to ArrayCreation.
2049 Added 5 types and 1 interface:
2051 IInitializable Implementing classes can inject initializing
2052 statements after object instantiation.
2054 Initializer Stores data for object initialization.
2056 AnonymousType An expression for anonymous types.
2058 AnonymousTypeParameter Stores data about an anonymous type's field.
2060 NewInitialize An expression for object initialization.
2062 CollectionInitialize An expression for collection initialization.
2064 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
2067 2007-05-06 Marek Safar <marek.safar@gmail.com>
2069 A fix for bug #81500
2070 * cs-tokenizer.cs: Add special handling for coalescing operator.
2072 2007-05-06 Marek Safar <marek.safar@gmail.com>
2074 A fix for bug #81529
2075 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
2076 its value from base class until it is redefined.
2078 2007-05-02 Raja R Harinath <rharinath@novell.com>
2080 Fix regression in cs0631-3.cs
2081 * cs-parser.jay (operator_declarator): Add opt_attributes to error
2082 fallback. Make error fallback catch more cases.
2084 2007-05-01 Miguel de Icaza <miguel@novell.com>
2086 * cs-parser.jay: Allow parameters in operator declarations to have
2089 2007-04-27 Miguel de Icaza <miguel@novell.com>
2091 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
2094 * lambda.cs (ContextualReturn.Resolve): An expression is valid
2095 inside the ContextualReturn, it does not have to be an
2096 ExpressionStatement.
2098 2007-04-24 Miguel de Icaza <miguel@novell.com>
2100 * lambda.cs (ContextualReturn.Resolve): if the return type is not
2103 2007-04-23 Miguel de Icaza <miguel@novell.com>
2105 * anonymous.cs (AnonymousContainer): split the virtual Resolve
2106 method in two methods: ResolveNoDefine and Resolve.
2108 ResolveNoDefine will stop just after ResolveTopBlock has been
2111 Resolve will then continue by creating a method and issuing the
2112 call to method.Define ().
2114 (AnonymousMethod): Split and implement the new Resolve and
2115 ResolveNoDefine as well.
2117 * lambda.cs (LambdaExpression): Split the anonymous method
2118 resolution code into a separate routine (CoreCompatibilityTest)
2119 from DoCompatibleTest.
2121 (LambdaExpression.TryBuild): New method, this method tries to
2122 build the LambdaExpression with the given set of types to be used
2123 as the types for the various parameters of the lambda expression.
2125 If the compilation succeed with the given types, the infered type
2126 of the Anonymous method is returned, otherwise null is returned.
2128 2007-04-23 Marek Safar <marek.safar@gmail.com>
2130 A fix for bug #81414
2131 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
2133 2007-04-22 Miguel de Icaza <miguel@novell.com>
2135 * cs-tokenizer.cs: Change various identifiers here from the
2136 camelCasing to the recommended Linux-like style for instance
2137 variables from the Coding Guidelines.
2139 2007-04-19 Martin Baulig <martin@ximian.com>
2142 (Convert.ImplicitReferenceConversionCore): Allow conversions from
2143 System.Enum to System.ValueType.
2145 2007-04-13 Martin Baulig <martin@ximian.com>
2147 Rewrote implicit reference conversions. We need to distinguish
2148 between implicit reference conversions (13.1.4) and implicit
2149 boxing conversions (13.1.5).
2151 According to the spec, there's an an implicit conversion
2152 "From a one-dimensional array-type S[] to IList<T> and base
2153 interfaces of this interface, provided there is an implicit
2154 reference conversion from S to T." Note that this does not
2155 include boxing conversions.
2158 (Convert.ImplicitTypeParameterBoxingConversion): New method.
2159 (Convert.ImplicitReferenceConversion): Split into
2160 ImplicitReferenceConversionCore() and
2161 ImplicitBoxingConversionExist().
2162 (Convert.ImplicitReferenceConversionExists): Use the new
2163 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
2165 2007-04-12 Martin Baulig <martin@ximian.com>
2167 * convert.cs (Convert.ImplicitReferenceConversion): Move the
2168 `TypeManager.null_type' checks up to the top of the method.
2170 2007-04-11 Marek Safar <marek.safar@gmail.com>
2172 A fix for bug #81350
2173 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
2176 2007-04-11 Martin Baulig <martin@ximian.com>
2178 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
2179 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
2180 to make this work for generic classes; fixes #79561.
2182 2007-04-11 Martin Baulig <martin@ximian.com>
2184 * expression.cs (As): Add support for nullable types; fixes #79371.
2186 2007-04-11 Martin Baulig <martin@ximian.com>
2188 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
2189 `type.FullName' is null; fixes #80243.
2191 2007-04-11 Martin Baulig <martin@ximian.com>
2193 * expression.cs (Invocation.IsApplicable): Don't modify the method
2194 if type inference succeeded, but the method was not applicable.
2197 2007-04-10 Marek Safar <marek.safar@gmail.com>
2199 A fix for bug #81324
2200 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
2201 internal and external namespaces containers.
2203 2007-04-10 Martin Baulig <martin@ximian.com>
2205 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
2206 TypeManager.DropGenericMethodArguments() so we also call
2207 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
2209 2007-04-10 Martin Baulig <martin@ximian.com>
2211 * iterators.cs (Iterator.CreateIterator): Don't crash if
2212 `method.ReturnType' is null. This happens if something went wrong
2213 while resolving that typ (we already reported an error in this case).
2215 2007-04-10 Martin Baulig <martin@ximian.com>
2217 * expression.cs (New.DoResolve): Don't call CheckComImport() on
2218 generic interfaces; report the CS0144 directly.
2220 2007-04-10 Martin Baulig <martin@ximian.com>
2222 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
2223 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
2225 2007-04-10 Martin Baulig <martin@ximian.com>
2227 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
2229 2007-04-09 Raja R Harinath <rharinath@novell.com>
2232 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
2233 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
2236 * statement.cs (For.Resolve): If resolution fails, use
2239 2007-04-08 Marek Safar <marek.safar@gmail.com>
2241 * anonymous.cs (MakeName): Make faster and zero-based.
2242 (VerifyExplicitParameterCompatibility): Back to mode where generic
2243 parameter is ignored.
2244 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
2246 * class.cs (EmitType): Method can emit another new method.
2248 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
2250 * driver.cs: Updated.
2252 * lambda.cs: Reuse predefined empty parameters.
2254 * parameter.cs: Updated
2256 * support.cs: Implemented InflateTypes.
2258 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
2259 (InitSystemCore): Introduced to isolate 3.0 dependencies.
2261 2007-04-03 Martin Baulig <martin@ximian.com>
2265 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
2266 version of TypeManager.IsOverride() which also works with generic
2269 2007-04-03 Martin Baulig <martin@ximian.com>
2274 (Convert.ExplicitReferenceConversion): We need to cast when
2275 converting from IList<T> to S[].
2277 2007-04-01 Marek Safar <marek.safar@gmail.com>
2279 * decl.cs (FindExtensionMethods): Consider all candidates with same name
2282 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
2284 2007-03-31 Marek Safar <marek.safar@gmail.com>
2286 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
2287 argument and return type inferring.
2289 * codegen.cs (InferReturnType): Flag whether return can be inferred.
2290 (ReturnType): Turned to property.
2292 * statement.cs (Return): Implemented return type inferring.
2294 * support.cs (ReflectionParameters): Use local types if possible.
2296 2007-03-30 Raja R Harinath <rharinath@novell.com>
2298 * flowanalysis.cs (FlowBranching.Reachability): Remove.
2299 (FlowBranching.UsageVector): Update to changes.
2301 Prepare to kill 'Reachability'
2302 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
2303 argument of constructor.
2305 2007-03-29 Raja R Harinath <rharinath@novell.com>
2307 Prepare to kill 'Reachability'
2308 * flowanalysis.cs (UsageVector.is_unreachable): New.
2309 (UsageVector): Update to maintain 'is_unreachable' in parallel to
2310 'reachability', and verify they're consistent.
2313 * expression.cs (New.EmitStatement): Handle type parameters here too.
2315 2007-03-29 Martin Baulig <martin@ximian.com>
2320 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
2321 CompilerGeneratedClass.
2322 (ScopeInfo.EmitScopeInstance): Make this protected.
2323 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
2324 `ec.CurrentAnonymousMethod.Scope == Scope'.
2326 * statement.cs (Block.ScopeInfo): Make this a property.
2328 2007-03-27 Raja R Harinath <harinath@gmail.com>
2330 Prepare to kill 'Reachability'
2331 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
2332 (FlowBranching.UsageVector.Reachability): Remove property.
2333 (FlowBranching.UsageVector.IsUnreachable): New property.
2334 (FlowBranching.UsageVector.ResetBarrier): New.
2335 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
2336 * codegen.cs, statement.cs: Update to changes.
2338 2007-03-27 Martin Baulig <martin@ximian.com>
2343 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
2346 2007-03-26 Raja R Harinath <rharinath@novell.com>
2348 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
2349 instead of TriState. Remove all mention of TriState.
2351 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
2352 replaced by a boolean. Add boolean 'is_unreachable' field, check
2353 and maintain invariants.
2355 2007-03-25 Marek Safar <marek.safar@gmail.com>
2357 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
2359 2007-03-25 Marek Safar <marek.safar@gmail.com>
2361 * expression.cs: Stop using obsolete 2.0 opcodes.
2363 2007-03-25 Marek Safar <marek.safar@gmail.com>
2365 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
2366 one of the latests Martin's fixes.
2368 2007-03-23 Miguel de Icaza <miguel@novell.com>
2370 * expression.cs: On BigEndian systems, swap the bytes, temporary
2371 solution until we get a new bitconverter class.
2373 2007-03-23 Martin Baulig <martin@ximian.com>
2377 * decl.cs (MemberCache.AddMembers): Add generic methods both as
2378 "Method" and "Method`1". Normally, a cache lookup is done on the
2379 "Method" form (ie. without the generic arity), but this one makes
2380 lookups on the full form work as well.
2382 2007-03-22 Raja R Harinath <rharinath@novell.com>
2384 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
2387 2007-03-20 Bill Holmes <billholmes54@gmail.com>
2389 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
2390 ordered_member_list, to TypeBuilder to store members to be defined
2391 in the order they were parsed in.
2392 - ordered_explicit_member_list contains all properties indexers
2393 and methods that are defined as explicit implementation of an
2394 interface or base class.
2395 - ordered_member_list contains all properties indexers and methods
2396 that are not defined as explicit implementation of an interface
2399 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
2400 functionality in these removed classes has been replaced with
2401 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
2402 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
2404 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
2405 to CheckForDuplications inside GetMethod and SetMethod Define Method
2406 to handle method property and indexer name conflicts.
2410 All code is contributed under the MIT/X11 license.
2412 2007-03-20 Martin Baulig <martin@ximian.com>
2414 * class.cs (TypeContainer.Interfaces): Removed; they're now
2415 included in `TypeContainer.Types'.
2417 2007-03-20 Martin Baulig <martin@ximian.com>
2419 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
2421 * class.cs (TypeContainer.CreateType): New public method. This is
2422 now called before DefineType() to create the TypeBuilders.
2423 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
2424 has already been created by CreateType().
2425 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
2426 don't resolve our base classes here; this has been moved into
2427 DefineBaseTypes(). We're now called from CreateType().
2428 (TypeContainer.DefineBaseTypes): New private method; resolve our
2429 base classes here. We're now called from DefineType().
2432 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
2433 our types first to create all the TypeBuilders. After that, call
2434 TypeContainer.DefineType() on all the types which'll resolve their
2435 base classes and setup the resolve order.
2437 2007-03-20 Martin Baulig <martin@ximian.com>
2439 * class.cs (TypeContainer.Enums): Removed; they're now included in
2440 `TypeContainer.Types'.
2442 2007-03-20 Martin Baulig <martin@ximian.com>
2445 (TypeContainer.DefineType): Don't call ResolveMembers() here.
2446 (TypeContainer.DoResolveMembers): Call DefineType() on our
2447 `compiler_generated' classes; moved here from DefineNestedTypes().
2450 (RootContext.ResolveTree): Call ResolveMembers() on all
2451 TypeContainer's in the `type_container_resolve_order'.
2453 2007-03-19 Marek Safar <marek.safar@gmail.com>
2455 * class.cs: Use corlib to handle InternalMethodImplAttribute.
2457 2007-03-17 Marek Safar <marek.safar@gmail.com>
2459 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
2460 implementation flags.
2462 2007-03-17 Marek Safar <marek.safar@gmail.com>
2464 * class.cs: More optimizations for type parameters.
2466 2007-03-15 Marek Safar <marek.safar@gmail.com>
2468 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
2470 * ecore.cs, parameter.cs: More common code for both corlibs.
2472 * typemanager.cs (IsGenericMethod): Simplified.
2474 2007-03-15 Raja R Harinath <rharinath@novell.com>
2476 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2478 * statement.cs, iterators.cs, lambda.cs: Update to changes.
2480 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
2481 unconditionally. Simplify explanation.
2482 (Try.Resolve, Using.Resolve): Likewise.
2484 2007-03-15 Martin Baulig <martin@ximian.com>
2488 * decl.cs (DeclSpace): If we're a partial class, use our
2489 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
2491 2007-03-15 Raja R Harinath <rharinath@novell.com>
2493 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
2495 (FlowBranching.UsageVector): Update to changes.
2496 (FlowBranching.MergeSiblings): Likewise.
2497 * statement.cs: Likewise.
2499 2007-03-15 Martin Baulig <martin@ximian.com>
2504 (MemberCache): Added a special .ctor for type parameters.
2507 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
2510 2007-03-09 Martin Baulig <martin@ximian.com>
2512 * enum.cs (Enum): Make this a TypeContainer.
2513 (EnumMember): Derive from `Const'.
2516 (Const.DoResolveValue): New protected virtual method; move most of
2517 the functionality of ResolveValue() here so we can override it in
2519 (Const.CreateConstantReference): Make this virtual.
2521 * class.cs (Kind): Add `Kind.Enum'.
2522 (TypeContainer.Emit): Don't emit the enums here; they're already
2523 in the `RootContext.typecontainer_resolve_order'.
2525 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
2526 here; they're already in the `typecontainer_resolve_order'.
2528 * ecore.cs (EnumConstant.ConvertImplicitly): Add
2529 TypeManager.DropGenericTypeArguments().
2532 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
2533 (TypeManager.IsEnumType): Likewise.
2534 (TypeManager.EnumToUnderlying): Likewise.
2535 (TypeManager.IsEqual): Add support for enums.
2537 2007-03-12 Raja R Harinath <rharinath@novell.com>
2539 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
2540 DefaultParameterValueAttribute to be undefined, say if System.dll
2543 2007-03-11 Marek Safar <marek.safar@gmail.com>
2545 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
2548 2007-03-10 Marek Safar <marek.safar@gmail.com>
2550 * class.cs, parameter.cs: Unified parameters verification.
2552 2007-03-08 Martin Baulig <martin@ximian.com>
2554 * cs-parser.jay (constructor_header): Pass the location to the
2555 newly created TopLevelBlock.
2557 2007-03-07 Martin Baulig <martin@ximian.com>
2559 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
2561 2007-03-06 Miguel de Icaza <miguel@novell.com>
2563 * convert.cs (ExplicitReferenceConversionExists): Sync this method
2564 with the changes from David, fixes the build.
2566 2007-03-05 David Mitchell <dmitchell@logos.com>
2568 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
2569 and its base interfaces to a one-dimensional array type S[],
2570 provided there is an implicit or explicit reference conversion
2573 2007-03-03 Marek Safar <marek.safar@gmail.com>
2575 * cs-tokenizer.cs: Implemented basic linq grammar.
2577 * driver.cs: Set linq lang version on demand.
2579 2007-02-26 Marek Safar <marek.safar@gmail.com>
2581 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
2583 2007-02-25 Marek Safar <marek.safar@gmail.com>
2585 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
2588 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
2590 Check property and event extern attributes.
2592 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
2595 2007-02-24 Marek Safar <marek.safar@gmail.com>
2597 A fix for bug #80407
2598 * ecore.cs: Don't report ambiguity error when methods have same parent.
2600 2007-02-23 Marek Safar <marek.safar@gmail.com>
2602 A fix for bug #80878
2603 * class.cs, cs-parser.jay: Event property can host anonymous methods.
2605 2007-02-22 Marek Safar <marek.safar@gmail.com>
2607 * attribute.cs: Enable ExtensionAttribute presence test.
2609 2007-02-22 Marek Safar <marek.safar@gmail.com>
2611 * class.cs: Warn about missing GetHashCode only when Equals is override.
2613 * decl.cs: Check accessibility of type arguments.
2615 * typemanager.cs: Correctly report nullable array.
2617 2007-02-20 Marek Safar <marek.safar@gmail.com>
2619 * class.cs, report.cs: Capture more details when things go wrong.
2621 2007-02-20 Marek Safar <marek.safar@gmail.com>
2623 A fix for bug #80650
2624 * cs-parser.jay: Anonymous container starts at constructor declaration
2625 and not at block beginning because it has to be usable in constructor
2628 * statement.cs: Use context location and not block one for error reporting.
2630 2007-02-18 Marek Safar <marek.safar@gmail.com>
2632 A fix for bug #78712
2633 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
2636 2007-02-18 Marek Safar <marek.safar@gmail.com>
2638 A fix for bug #80493 by Atsushi Enomoto
2639 * cs-parser.jay: Ignore invalid attribute target.
2641 2007-02-18 Marek Safar <marek.safar@gmail.com>
2643 * cs-tokenizer.cs: Ignore '\0' as white space character.
2645 2007-02-17 Miguel de Icaza <miguel@novell.com>
2647 * cs-parser.jay: Add support for lambda expressions to the mcs
2650 * lambda.cs: Only clone when we are probing, not on the final call
2651 (Compatible is the final call).
2653 * statement.cs (CloneContext): Introduce class to provide block
2654 remapping during clone.
2656 All statements Clone themselves now.
2658 (Clone): special handling for blocks, when we clone a block, we
2659 register the block inside this routine, as children of the block
2660 might trigger a lookup.
2662 * expression.cs: Add support for CloneContext in all expressions.
2664 2007-02-17 Marek Safar <marek.safar@gmail.com>
2666 A fix for bug #80493
2667 * statement.cs: Report ambiguous warning when interfaces are not related.
2669 2007-02-15 Marek Safar <marek.safar@gmail.com>
2671 C# 3.0 extension methods.
2673 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
2674 cannot be used directly.
2676 * class.cs (Class.Emit): Emit extension attribute if any class method
2677 is extension method.
2678 (Method.Define): Add basic extension method validation conditions.
2679 (Method.Emit): Emit extension attribute for method.
2681 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
2682 extension method exists. Currently we follow same approach as Microsoft
2683 does, emit even if a method or a class are private but this can change
2686 * cs-parser.jay: Add handling of `this' keyword in method parameters
2689 * decl.cs (DeclSpace.IsStaticClass): New property.
2690 (MemberCache.FindExtensionMethods): Looks for extension methods with
2691 defined name and extension type.
2693 * doc.cs: Updated after OverloadResolve changes.
2695 * driver.cs: Add new soft reference to System.Core.dll.
2697 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
2698 (ExtensionMethodGroupExpr): Represents group of extension methods.
2700 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
2701 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
2702 to MethodGroupExpr and made non-static for easier customization.
2703 (Invocation.DoResolve): Add extension method lookup when no standard
2705 (MemberAccess.DoResolve): Try extension methods if no member exists.
2707 * modifiers.cs: Add METHOD_EXTENSION modifier.
2709 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
2710 as well as candidate extension type.
2711 (ComputeNamespaces): When assembly constains extension methods registers
2713 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
2714 extension method lookup.
2715 (Namespace.LookupExtensionMethod): Looks for extension method in this
2717 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
2718 find a method which matches name and extensionType.
2720 * parameter.cs (Parameter): Add This modifer.
2721 (HasExtensionMethodModifier): New property.
2722 (Resolve): Add extension parameter check.
2723 (ModFlags): turned to property to exclude this modifier as it is not real
2725 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
2727 * support.cs (ParameterData): Add ExtensionMethodType.
2728 (ReflectionParameters): Implemented ExtensionMethodType interface property.
2730 * typemanager.cs: Add type and ctor extension attribute type.
2732 2007-02-15 Miguel de Icaza <miguel@novell.com>
2734 * report.cs (DisableErrors, EnableErrors): used to prevent error
2735 output when we are "trying" to compile various methods with
2738 * ecore.cs (Expression): Add Clone method that calls the virtual
2739 CloneTo method. The current CloneTo method in Expression throws
2740 an exception so we can track down all the places where this must
2741 be implemented (not using abstract, because that would be a lot of
2742 up-front-work before we can start testing the implementation
2745 Important: we only need Clone capabilities for expressions created
2746 by the parser, as the expressions we will be cloning are
2747 expressions in the pre-resolved state. This vastly simplifies
2750 (SimpleName): Add CloneTo that does nothing.
2751 (EmptyCast): Add CloneTo.
2753 * expression.cs (Binary): Implement CloneTo.
2754 (Invocation.IsApplicable): Store the current ec in
2755 EmitContext.TempEc and restore it on return. This is used so we
2756 do not have to sprinkle hundres of methods with an extra
2757 EmitContext, we know that the only user is the lambda expression
2758 ImplicitConversionExists code.
2760 (Argument): Add Cloning capabilities.
2761 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
2762 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
2763 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
2764 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
2765 IndexerAccess): Add Clone capability.
2767 (LocalVariableReference, This): TODO: needs cloned Block mapping.
2769 (Argument): Add cloning capability.
2771 * assign.cs (Assign): Implement CloneTo.
2773 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
2775 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
2776 version by calling Convert with the EmitContext (that we are
2777 currently storing in ec, this is not great, but will do for now,
2778 to avoid passing EmitContext parameters to hundreds of functions
2779 that do not need them now).
2781 (SetExpression): Remove, it is not needed.
2783 (ContextualReturn): Implement CloneTo.
2785 * statement.cs (Statement): Implement cloning infrastructure,
2786 similar to expressions.
2788 (Block): Partial implementation of Clone for statements.
2790 (Return): Implement clone.
2792 * constant.cs (Constant.CloneTo): New method, does nothing.
2794 * codegen.cs (TempEc): Add a static EmitContext as a temporary
2795 solution, until we decide how to exactly do this.
2797 2007-02-14 Marek Safar <marek.safar@gmail.com>
2799 A fix for bug #80493
2800 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
2801 a property is override we need to use second accessor.
2803 2007-02-13 Marek Safar <marek.safar@gmail.com>
2805 A fix for bug #80418
2806 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
2809 2007-02-13 Marek Safar <marek.safar@gmail.com>
2811 Another fix for bug #80749
2812 * pending.cs: Abstract class has priority over interfaces.
2814 2007-02-13 Marek Safar <marek.safar@gmail.com>
2816 Another fix for bug #80749
2817 * pending.cs: Abstract class has priority over interfaces.
2819 2007-02-13 Marek Safar <marek.safar@gmail.com>
2821 Another fix for bug #80749
2822 * pending.cs: Abstract class has priority over interfaces.
2824 2007-02-13 Marek Safar <marek.safar@gmail.com>
2826 Another fix for bug #80749
2827 * pending.cs: Abstract class has priority over interfaces.
2829 2007-02-13 Marek Safar <marek.safar@gmail.com>
2831 * class.cs Better error message.
2833 * driver.cs: Add shorter versions of -optimize option.
2835 2007-02-13 Martin Baulig <martin@ximian.com>
2837 * class.cs (Constructor.Emit): Check the return value of
2838 ec.ResolveTopBlock() and return on error.
2840 2007-02-13 Raja R Harinath <rharinath@novell.com>
2842 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
2843 message to fix error message regression.
2845 2007-02-12 Marek Safar <marek.safar@gmail.com>
2847 * delegate.cs: Delegate creation expression cannot be of Nullable type.
2849 2007-02-12 Marek Safar <marek.safar@gmail.com>
2851 A fix for bug #80749
2852 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
2853 its parent container.
2855 * class.cs (DefineFieldInitializers): Each initializer can has different
2858 * const.cs: Updated.
2860 2007-02-11 Miguel de Icaza <miguel@novell.com>
2862 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
2863 now all the heavy lifting to check that embedded statements or
2864 expressions have the right form is done in the ContextualReturn.
2866 (ContextualReturn): New class.
2868 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
2869 method that can be invoked to report 201, so we do not replicate
2872 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
2874 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
2875 treating tabs as spaces.
2877 2007-02-09 Marek Safar <marek.safar@gmail.com>
2879 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
2880 * assign.cs: Use full implicit conversion for right side check.
2882 2007-02-09 Marek Safar <marek.safar@gmail.com>
2884 * statement.cs (Switch): Switch over boolean type is not standardized.
2886 2007-02-08 Marek Safar <marek.safar@gmail.com>
2888 A fix for bug #80755
2889 * decl.cs (FindBaseEvent): Don't use method cache for events.
2891 2007-02-07 Marek Safar <marek.safar@gmail.com>
2893 * cs-parser.jay: Better syntax error handling.
2895 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
2896 instead of underlying type value.
2898 2007-02-06 Marek Safar <marek.safar@gmail.com>
2900 * driver.cs: Check define identifier before is registered.
2902 * namespace.cs: Use existing error message.
2904 * report.cs: New warning.
2906 2007-02-06 Marek Safar <marek.safar@gmail.com>
2908 A fix for bug #80742
2909 * expression.cs: Delegate Invoke method can be called directly.
2911 2007-02-06 Marek Safar <marek.safar@gmail.com>
2913 A fix for bug #80676
2914 * class.cs (IsEntryPoint): The Main method can have params modifier.
2916 2007-02-04 Miguel de Icaza <miguel@novell.com>
2918 * parameter.cs (Parameter, Parameters): Add Clone method.
2920 * anonymous.cs (Compatible): Turn method into virtual method, so
2921 LambdaExpression can implement a different behavior.
2923 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
2924 out the basic checking here, so it can be used by
2927 * lambda.cs: Introduce "Compatible" function that will do the
2930 2007-02-02 Marek Safar <marek.safar@gmail.com>
2932 * attribute.cs: Unified one error message.
2934 * class.cs (Class): Use type attributes and not properties to test static
2936 (IsEntryPoint): Don's pass local variable.
2938 * convert.cs: Removed duplicate check.
2940 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
2942 * driver.cs: Don't crash when soft reference does not exist.
2944 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
2945 (UsingEntry): Removed redundant allocation.
2947 * parameter.cs: Add fast path for type parameters.
2949 * support.cs: Don't allocate attribute when it's not used.
2951 2007-01-30 Miguel de Icaza <miguel@novell.com>
2954 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
2955 this into a virtual method, so we can override it in LambdaExpression.
2957 * driver.cs: Improve diagnostics in case of failure.
2959 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
2960 write a function that is slightly more complex and that parses:
2962 type identifier [, type identifier]* )
2964 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
2967 (canEmpty ? i >= 0 : i > 0)
2969 2007-01-30 Raja R Harinath <rharinath@novell.com>
2971 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
2972 exception on possibly valid code.
2974 2007-01-29 Raja R Harinath <rharinath@novell.com>
2976 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
2978 (parse_opt_type_arguments): Remove. It's almost the same as
2980 (parse_namespace_or_typename): Use parse_less_than.
2982 2007-01-28 Miguel de Icaza <miguel@novell.com>
2984 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
2985 this bug took a few hours to find, because the state saved and
2986 restored by PushPosition and PopPosition was ignoring the state of
2987 parse_generic_less_than.
2989 I can also now remove the handling of OP_LT and OP_GT, this solves
2992 * cs-tokenizer.cs: store the location for the ARROW token, we use
2995 (PushPosition, PopPosition): save/restore also `current_token',
2996 restore `parse_generic_less_than' (was missing).
2998 (parse_opt_type_arguments): use parse_type, not
2999 parse_namespace_or_typename to parse types.
3001 * lambda.cs: Empty new file, will eventually have the lambda
3002 expression implementation.
3004 * lambda.test: used to test the internal tokenizer.
3006 * report.cs (FeatureIsNotISO1): Rename from
3007 FeatureIsNotStandardized, because it was about the language level
3008 (1 vs 2) it was not about standarization.
3010 (FeatureRequiresLINQ): New.
3012 * support.cs (SeekableStreamReader): Only require that the reader
3013 is a TextReader, not a StreamReader, so we can plug StringReader.
3015 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
3016 given position in the input stream the following tokens can be
3017 parsed as a type followed by an identifier.
3019 (is_punct): after a '(' if parse_type_and_parameter returns true,
3020 then return a special token OPEN_PARENS_LAMBDA which is used to
3021 avoid reduce/reduce errors in the grammar for the
3022 lambda_expression rules.
3024 (parse_type): implement a type parser inside the
3025 tokenizer, the parser only returns true or false depending on
3026 whether the input at a given position can be parsed as a type.
3028 (peek_token): new method used during type parsing.
3030 2007-01-28 Raja R Harinath <rharinath@novell.com>
3033 * anonymous.cs (ScopeInfo.InflateParameters): New.
3034 (AnonymousContainer.Resolve): Use it to redirect types of
3035 delegate parameters.
3037 2007-01-27 Raja R Harinath <rharinath@novell.com>
3040 * expression.cs (Error_InvalidArguments): Don't use two different
3041 messages for CS1503. Use ExtraInformation and
3042 SymbolRelatedToPreviousError instead.
3045 * decl.cs (DeclSpace.initialize_type_params): Don't access
3046 'type_params' of a partial class directly.
3048 2007-01-26 Miguel de Icaza <miguel@novell.com>
3050 * constant.cs: Removed a handful of out-of-range checks that were
3053 2007-01-25 Marek Safar <marek.safar@gmail.com>
3055 * expression.cs (CheckUselessComparison): Add additional check for char
3058 * namespace.cs: Fixed typo.
3060 2007-01-23 Miguel de Icaza <miguel@novell.com>
3062 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
3063 gone, instead we inline the test, preventing the needless casts to
3064 longs, ulongs and doubles for the parameters, avoiding calls to
3065 methods that overchecked stuff, and instead inlined things
3068 2007-01-20 Marek Safar <marek.safar@gmail.com>
3070 * cs-parser.jay: Better parameter error handling.
3072 2007-01-17 Marek Safar <marek.safar@gmail.com>
3074 A fix for bug #80368, #80522
3075 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
3076 whether array initializer contains constants only.
3077 (ArrayCreation.Emit): Use better formula to decide when
3078 are array initializers for static initialization.
3079 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
3080 have to emit even constants otherwise they are pre-initialized.
3082 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
3083 Raja R Harinath <rharinath@novell.com>
3085 Fix emit order of 'get' vs. 'set'.
3086 * support.cs (Accessors): New.
3087 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
3088 Note the order in which accessors are declared in the source.
3089 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
3090 Refactored from Property.Define and Indexer.Define.
3091 (PropertyBase.DefineAccessors): New helper that calls the above in
3092 appropriate order as noted by the parser.
3093 (Property.Define, Indexer.Define): Update to changes.
3094 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
3096 2007-01-17 Raja R Harinath <rharinath@novell.com>
3098 Fix cs0029-6.cs and gcs0029-2.cs (regression)
3099 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
3100 there's an implicit conversion from the current type to the target
3101 type before converting the underlying constant.
3103 2007-01-16 Marek Safar <marek.safar@gmail.com>
3105 * const.cs (ResolveValue): Updated after constant conversion was made more
3108 * constant.cs (GetAttributableValue): constant to object conversion is
3109 used for attributes only.
3110 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
3111 constant conversions.
3112 (LongConstant.ConvertImplicitly): Ditto.
3114 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
3115 (ImplicitConversionStandard): Handle constant conversion as extra step.
3116 It solves the issue when constant conversion was called indirectly like
3117 inside array initializer and constant folding was skipped.
3119 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
3122 * statement.cs(ImplicitConversionStandard): Updated after constant
3123 conversion was made more generic.
3125 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
3127 * expression.cs (As.DoResolve): Use GenericConstraints instead of
3128 Constraints, solves the problem where the compiler incorrectly
3129 reported that a type parameter was not constrained to a class (Bug
3132 2007-01-14 Marek Habersack <grendello@gmail.com>
3134 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
3136 2007-01-14 Marek Safar <marek.safar@gmail.com>
3138 A fix for bug #80368
3139 * assign.cs (FieldInitializer): New class implements field
3140 initializer statement.
3142 * attribute.cs: Update after FieldMember rename.
3144 * class.cs (PropertyBasedMember): New common class for property based
3146 (InterfaceMemberBase): New base class for all members which can be used as
3147 an interface members.
3148 (MethodCore): Moved really common code to InterfaceMemberBase.
3149 (Method.Define): Equal and GetHasCode detection is relevant for methods
3151 (MethodData.Define): Don't assume that public event implements an
3152 interface automatically.
3153 (MethodData.DefineMethodBuilder): Issue an error even if only extern
3155 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
3156 (FieldMember): Merged with FieldBase.
3157 (EventProperty.AEventPropertyAccessor): New specialization to check whether
3158 event extern modifier can be used.
3159 (EventField.EventFieldAccessor): Moved event field specific code here.
3160 (Event.AllowedModifiers): Even event can be extern.
3161 (Event.FindOutBaseMethod): New override specific to events.
3162 (Indexer.parameters): Reintroduce parameters because base class holds
3163 only properties common data.
3164 (Indexer.CheckForDuplications): Indexers are threated as methods so we
3165 need do extra parameters check.
3167 * const.cs: Update after FieldMember rename.
3169 * decl.cs (MemberCache.FindBaseEvent): New method.
3171 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
3172 to reflect that indexer is now derived from PropertyBased.
3174 * ecore.cs (GetMemberType): Made public.
3175 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
3178 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
3180 * typemanager.cs (CSharpSignature): Correctly print event accessors.
3181 (RegisterEvent): Removed.
3182 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
3183 (GetPrivateFieldOfEvent): Renamed to GetEventField.
3185 2007-01-11 Raja R Harinath <rharinath@novell.com>
3188 * statement.cs (CollectionForeach.TryType): Prefer generic
3189 GetEnumerator over non-generic variant. Fix code to follow comments.
3191 2007-01-09 Raja R Harinath <rharinath@novell.com>
3194 * support.cs (ReflectionParameter): Don't use an invalid index on
3195 the generic parameter data.
3197 2007-01-08 Miguel de Icaza <miguel@novell.com>
3199 * driver.cs: Just add a tiny bit of infrastructure.
3201 2007-01-02 Marek Safar <marek.safar@gmail.com>
3203 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
3204 where field type is struct from current assembly.
3206 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
3209 2007-01-02 Marek Safar <marek.safar@gmail.com>
3211 A fix for bug #80381
3212 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
3215 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
3217 (Namespace.LookupType): Always use core types from corlib when speficied.
3219 * report.cs: A new warning.
3221 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
3222 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
3223 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
3225 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
3226 (InitCoreTypes): Set expression type of object_type and value_type
3227 immediately after lookup.
3229 2007-01-01 Miguel de Icaza <miguel@novell.com>
3231 * cs-tokenizer.cs: Accept Pc class characters (Connector
3232 Punctuation) as valid identifiers. Fixes #78259
3234 * expression.cs (Invocation.DoResolve): Moved the check for the
3235 use of `this' for doing method calls to the Invocation resolution
3236 step, after overload resolution has taken place instead of doing
3237 the check at the low-level `This.DoResolve' level.
3239 The `This.DoResolve'(appens before overload resolution, so it has
3240 no way of knowing if the method that will be called will be
3241 instace or static, triggering an erroneous report for cs0188 (Bug
3244 We now do the check for instance method invocations after we know
3245 what method will be called.
3247 (This.CheckThisUsage): Move the actual use of this structure
3248 checking into its own method and expose it.
3250 * Everywhere that called Error_ValueCannotBeConverted: pass a new
3253 Exceptions: Null.ConvertImplicitly,
3254 Constant.ImplicitConversionRequired as there are too many call
3255 sites for passing the ec.
3257 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
3258 EmitContext, if the value is null, then we do not try to provide
3259 the extra information from the error (If a userdefined conversion
3260 exists, as UserDefinedConversion requires a non null-EmitContext).
3264 2006-12-30 Raja R Harinath <rharinath@novell.com>
3266 * flowanalysis.cs (MyBitVector): Document some invariants.
3267 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
3268 introduced below, and add a couple of others,
3270 2006-12-30 Marek Safar <marek.safar@gmail.com>
3272 * attribute.cs (GetMethodObsoleteAttribute): Uses new
3273 GetPropertyFromAccessor and GetEventFromAccessor.
3275 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
3276 overrides non-obsolete one.
3277 (Indexer.Define): Error message has been moved to the parser.
3279 * cs-parser.jay: Better syntax errors handling.
3281 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
3282 when an invocation has no arguments.
3284 * ecore.cs: Removed not used caching.
3286 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
3289 * report.cs: Add a new warning.
3291 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
3293 * typemanager.cs (enumeration_type): Removed.
3294 (CSharpSignature): Reuses IsSpecialMethod.
3295 (IsEqual): Hack for MS BCL.
3296 (GetPropertyFromAccessor): New method.
3297 (GetEventFromAccessor): New method.
3298 (IsSpecialMethod): Fixed to handle more cases.
3300 2006-12-30 Marek Safar <marek.safar@gmail.com>
3302 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
3303 Made white spaces array static.
3305 * ecore.cs (RemoveGenericArity): Optimized.
3307 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
3309 (MyBitVector.initialize_vector): Simplified.
3311 2006-12-22 Miguel de Icaza <miguel@novell.com>
3313 * ecore.cs: Am not entirely happy with this hack, but it seems to
3314 address the issue in 80257 (a small test case for
3317 I set the MethodGroupExpr.Type to an internal compiler type
3318 (itself in this case) to force the resolution to take place. Why
3319 it does not take place with a null is beyond me.
3321 2006-12-20 Marek Safar <marek.safar@gmail.com>
3323 A fix for bug #80288
3324 * expression.cs (ResolveOperator): Consider user defined conversion for
3325 logical and operator too.
3326 (EmitBranchable): Optimization for logical and when full constant folding
3327 could not be applied but one operand is constant.
3329 2006-12-19 Marek Safar <marek.safar@gmail.com>
3331 * class.cs (GetClassBases): Write 5 times every day, will never use
3332 FullName for error reporting.
3334 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
3336 2006-12-19 Martin Baulig <martin@ximian.com>
3338 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
3339 the symbol file info here.
3341 2006-12-18 Marek Safar <marek.safar@gmail.com>
3343 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
3344 of `elseif' is taking then following sections are not taking.
3345 Fixes an issue reported on mono mailing list.
3347 2006-12-18 Marek Safar <marek.safar@gmail.com>
3349 A fix for bug #80300
3350 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
3351 a caller is not taking.
3353 2006-12-18 Raja R Harinath <rharinath@novell.com>
3355 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
3356 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
3357 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
3358 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
3359 * class.cs: Update to changes.
3361 2006-12-17 Marek Safar <marek.safar@gmail.com>
3363 A fix for bug #79934
3364 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
3367 * class.cs (ResolveMembers): Register an iterator in current container and
3370 2006-12-16 Raja R Harinath <rharinath@novell.com>
3373 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
3374 satisfy a params annotated parameter.
3376 2006-12-16 Marek Safar <marek.safar@gmail.com>
3378 A fix for bug #77014
3379 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
3380 paramters correctly and not rely on hacks in Parameters class.
3381 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
3383 (Invocation.VerifyArgumentsCompat): Ditto.
3384 (Invocation.EmitArguments): Changed to correctly emit params arguments at
3387 * parameter.cs (HasParams): Don't assume that params is the last one.
3389 * support.cs (ReflectionParameters.ctor): Look for params attribute
3391 (ReflectionParameters.ParameterType): Removed hack when we returned last
3392 parameter for out of range parameters.
3393 (ParameterName, ParameterModifier): Ditto.
3395 2006-12-14 Marek Safar <marek.safar@gmail.com>
3397 A fix for bug #79987
3398 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
3399 when assembly is not CLS compliant but type is. I have no idea why is this
3402 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
3404 2006-12-13 Miguel de Icaza <miguel@novell.com>
3406 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
3407 in struct constructors, they are basically no-ops.
3409 2006-12-12 Marek Safar <marek.safar@gmail.com>
3411 * cs-tokenizer.cs (Position): Save preprocessor status too.
3413 2006-12-12 Marek Safar <marek.safar@gmail.com>
3415 A fix for bug #77794
3416 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
3418 2006-12-12 Marek Safar <marek.safar@gmail.com>
3420 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
3422 (pp_expr): Report error for an invalid expression.
3423 (handle_preprocessing_directive): Simplified; add more error checking.
3425 2006-12-11 Marek Safar <marek.safar@gmail.com>
3427 A fix for bug #74939
3428 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
3429 directives handling.
3431 2006-12-10 Marek Safar <marek.safar@gmail.com>
3433 A fix for bugs #80093, and #75984
3434 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
3435 logic, it seems to me as it worked before "by coincidence".
3436 (xtoken): Simplified to use reworked handle_preprocessing_directive.
3437 (cleanup): Enabled endif check.
3439 2006-12-09 Marek Safar <marek.safar@gmail.com>
3441 A fix for bug #80162
3442 * statement.cs (CollectionForeach.TryType): Generics and non-generics
3443 enumerators are never ambiguous.
3445 2006-12-08 Raja R Harinath <rharinath@novell.com>
3448 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
3450 2006-12-06 Marek Safar <marek.safar@gmail.com>
3452 A fix for bug #80144
3453 * class.cs (EventProperty.Define): Explicit implementation means
3454 that an even is used.
3456 2006-12-06 Marek Safar <marek.safar@gmail.com>
3458 Fixes the operators implementation (part II)
3460 * cfold.cs (DoConstantNumericPromotions): Renamed to
3461 DoBinaryNumericPromotions and simplified.
3462 (BinaryFold): Couple of conversion fixes; simplified.
3464 * constant.cs, ecore.cs, literal.cs
3465 (ToType): Renamed to ConvertImplicitly.
3466 (Reduce): Renamed to ConvertExplicitly.
3468 * class.cs, convert.cs: Updated.
3470 * expression.cs: TryReduce doesn't throw an exception.
3472 2006-12-01 Marek Safar <marek.safar@gmail.com>
3474 A fix for bug #80108
3475 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
3478 2006-11-30 Marek Safar <marek.safar@gmail.com>
3480 Fixes unary operators implementation (part I)
3483 * cfold.cs (Error_CompileTimeOverflow): Made internal
3485 * const.cs (IConstant): Changed to use reference to constant and
3486 not constant itself.
3487 Updated IConstant implementations.
3489 * constant.cs (CreateConstant): New factory method.
3490 Updated IConstant implementation.
3492 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
3494 * ecore.cs: Updated to use CreateConstantReference.
3496 * enum.cs: Reflects IConstant changes.
3498 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
3500 * literal.cs (NullConstant): Change to be independently usable.
3502 2006-11-29 Martin Baulig <martin@ximian.com>
3504 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
3505 we need to emit the scope initializer before calling the base .ctor.
3507 * anonymous.cs: Merged back from the new anonymous methods branch.
3508 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
3510 * expression.cs (ParameterReference.DoResolveBase): Create a
3511 "normal" ScopeInfo when capturing parameters rather than using the
3512 root scope; this makes things work with anonymous methods having
3516 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
3518 2006-11-22 Marek Safar <marek.safar@gmail.com>
3520 A fix for bug #79987
3521 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
3522 check to a base class.
3523 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
3524 only when assembly has missing attribute.
3525 * report.cs: Update.
3527 2006-11-21 Marek Safar <marek.safar@gmail.com>
3529 * cs-tokenizer.cs: Merged with gmcs version.
3531 2006-11-20 Marek Safar <marek.safar@gmail.com>
3534 * cs-parser.jay: Better error message when partial keyword is misplaced.
3536 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
3538 A fix for bug #79810
3539 report.cs: CS1058 only applies to 2.0 profile (gmcs).
3540 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
3541 a RuntimeWrappedException by default.
3543 2006-11-18 Marek Safar <marek.safar@gmail.com>
3545 A fix for bug #79843
3546 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
3548 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
3550 2006-11-18 Marek Safar <marek.safar@gmail.com>
3552 * driver.cs, namespace.cs: Uses faster IndexOf version.
3554 2006-11-17 Marek Safar <marek.safar@gmail.com>
3556 A fix for bug #79941
3557 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
3559 (Operator.Define): Implicit/Explicit operator of same type is duplicate
3560 even if internal name is different.
3561 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
3562 (UserDefinedConversion): Simplified as the operators cannot be internal.
3563 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
3565 (MethodLookup): Replaced EmitContext with parentType.
3566 * expression.cs: Updated.
3568 2006-11-09 Raja R Harinath <rharinath@novell.com>
3570 * driver.cs (BadAssembly): Handle all the ugliness of
3571 DefineDynamicAssembly.
3573 2006-11-08 Raja R Harinath <rharinath@novell.com>
3575 Address parts of #58244 -- most of what's left is in the runtime
3576 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
3577 CS1509 error checks, and handle them for all assembly loads, not
3578 just the first invocation.
3579 (LoadModule): Likewise. Move handling of 'adder_method' ...
3580 * codegen.cs (AssemblyClass.AddModule): ... here.
3582 2006-11-02 Marek Safar <marek.safar@gmail.com>
3584 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
3585 IEnumerable<T> is ambiguous.
3587 2006-10-31 Marek Safar <marek.safar@gmail.com>
3589 A fix for bug #67689
3590 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
3591 GetEnumerator is ambiguous.
3593 * report.cs: Add new warning.
3595 2006-10-29 Marek Safar <marek.safar@gmail.com>
3597 A fix for bug #78602
3598 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
3599 to protected member can be nested type.
3601 2006-10-28 Marek Safar <marek.safar@gmail.com>
3603 A fix for bug #78965
3604 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
3605 to protected member must derive from current type.
3607 2006-10-27 Marek Safar <marek.safar@gmail.com>
3609 assign.cs: Reuses error method.
3611 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
3612 instead of type for constants.
3613 (Expression.Error_ValueAssignment): Common error method.
3615 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
3618 2006-10-27 Marek Safar <marek.safar@gmail.com>
3620 A fix for bug #79081
3621 * expression.cs (MemberAccess.DoResolve): Check nested type
3624 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
3626 * doc.cs : nested delegates were not handled. Fixed bug #79754.
3628 2006-10-26 Marek Safar <marek.safar@gmail.com>
3630 A fix for bug #76591
3631 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
3633 2006-10-26 Marek Safar <marek.safar@gmail.com>
3635 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
3636 type forwarder of the same type multiple times.
3638 2006-10-26 Raja R Harinath <rharinath@novell.com>
3641 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
3642 instance as an rvalue, even when we later resolve as an lvalue.
3644 2006-10-25 Martin Baulig <martin@ximian.com>
3646 * anonymous.cs: Fix #79673.
3648 2006-10-24 Marek Safar <marek.safar@seznam.cz>
3650 A fix for bug #79666
3651 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
3652 ignored when is optimized (= default value) as its value is already set.
3654 2006-10-23 Marek Safar <marek.safar@seznam.cz>
3656 A fix for bug #79724
3657 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
3658 TypeContainer for type lookup.
3660 2006-10-23 Marek Safar <marek.safar@seznam.cz>
3662 A fix for bug #79231
3663 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
3664 * expression.cs (OverloadResolve): Always convert type name for
3666 (ResolveNamespaceOrType): Don't confuse a nested type with any
3669 2006-10-18 Martin Baulig <martin@ximian.com>
3671 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
3673 2006-10-17 Miguel de Icaza <miguel@novell.com>
3675 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
3676 an int32, but requesting an int64 from the conversion
3678 2006-10-12 Martin Baulig <martin@ximian.com>
3681 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
3683 2006-10-12 Martin Baulig <martin@ximian.com>
3686 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
3688 2006-10-11 Miguel de Icaza <miguel@novell.com>
3690 * convert.cs: Remove broken code: I was doing the "Existance"
3691 tests for Implicit conversions.
3693 2006-10-10 Miguel de Icaza <miguel@novell.com>
3695 * convert.cs: Added one missing case in
3696 ImplicitStandardConversionExists uint64 to intptr.
3700 * typemanager.cs (uintptr_type): another core known type.
3702 * ecore.cs (OperatorCast): routine used to do cast operations that
3703 depend on op_Explicit. We could change some of the Decimal
3704 conversions to use this.
3706 This one has a probe mechanism that checks both types for an op_
3707 which it coudl be used to eliminate two classes: CastToDecimal
3708 and CastFromDecimal.
3710 * convert.cs: Implement the conversions documented in #59800
3712 2006-10-10 Martin Baulig <martin@ximian.com>
3714 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
3715 before RootScope.ResolveMembers().
3717 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
3718 `CurrentType' if appropriate.
3720 2006-10-09 Marek Safar <marek.safar@seznam.cz>
3722 A fix for bug #78568
3723 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
3724 when contains binary operators.
3725 * cs-parser.jay: Updated.
3727 2006-10-09 Martin Baulig <martin@ximian.com>
3730 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
3731 moved that into Define() and also do the other type parameter
3732 checks there. Fixes #79094. Added gtest-292.cs.
3735 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
3736 since that doesn't include type parameters; don't use `Ldelema'
3737 for type parameters. Fixes #78980. Added gtest-293.cs.
3739 2006-10-08 Marek Safar <marek.safar@seznam.cz>
3742 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
3743 conversion is allowed.
3745 2006-10-06 Marek Safar <marek.safar@seznam.cz>
3747 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
3748 error reporting when no error occurs.
3750 2006-10-06 Marek Safar <marek.safar@seznam.cz>
3752 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
3755 2006-10-06 Raja R Harinath <rharinath@novell.com>
3758 * class.cs (DefineTypeBuilder): Check circular dependencies before
3759 setting the parent of the TypeBuilder.
3760 (CheckRecursiveDefinition): Don't use 'BaseType', since
3761 it may not be valid until after DefineTypeBuilder. Use
3762 'base_type' instead.
3764 2006-10-04 Martin Baulig <martin@ximian.com>
3766 Merged the Anonymous Methods patch.
3768 * anonymous.cs, iterators.cs: The new anonymous methods code.
3770 * statement.cs (Variable): New public abstract class.
3771 (LocalInfo.Variable): New public property.
3772 (LocalInfo.ResolveVariable): New public method.
3773 (Block.Flags): Add `IsIterator'.
3774 (Block.AddVariable): Improved the CS0136 check.
3775 (Block.AnonymousChildren): New public property.
3776 (Block.AddAnonymousChild): New public method.
3777 (ToplevelBlock): Update to use the new anonymous method framework.
3778 (ToplevelBlock.ctor): `container' is now a `Block' and not a
3779 `ToplevelBlock'; this is required to correctly implement the
3781 (Fixed, Using): Use `TemporaryVariable' instead of directly
3782 creating the `LocalBuilder'.
3784 * parameter.cs (Parameter.ResolveVariable): New public method.
3785 (Parameters.ResolveVariable): Likewise.
3787 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
3789 * class.cs (TypeContainer): Replaced the `iterators' list and
3790 corresponding methods with a list of `CompilerGeneratedClass'es.
3791 (TypeContainer.ResolveMembers): New public method.
3792 (Method): `IIteratorContainer' has been replaced by
3795 * expression.cs (VariableReference): New public abstract base
3796 class for `LocalVariableReference', `ParameterReference' and
3799 * codegen.cs (EmitContext): Removed `capture_context',
3800 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
3801 (EmitContext.EmitThis): Removed.
3803 * cs-parser.jay: Replace `iterator_container' with
3806 2006-10-04 Martin Baulig <martin@ximian.com>
3808 * generic.cs (GenericMethod): Don't make this abstract.
3809 (Constraints.Clone): Added dummy implementation.
3811 2006-10-04 Raja R Harinath <harinath@gmail.com>
3814 * namespace.cs (LookForAnyGenericType): Avoid nullref on
3815 'declspaces'. Avoid allocating arrays willy-nilly.
3818 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
3819 cases out of the switch.
3821 2006-09-28 Marek Safar <marek.safar@seznam.cz>
3823 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
3824 message when non-generic type is used with the type arguments.
3825 * expression.cs: Updated.
3827 2006-09-28 Raja R Harinath <rharinath@novell.com>
3830 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
3831 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
3832 Change semantics slightly. Don't insist on having only one
3833 temporary EmptyExpression -- just throttle the creation of new ones.
3836 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
3837 non-interfaces too. If no methods are found, don't try to create
3840 2006-09-28 Marek Safar <marek.safar@seznam.cz>
3842 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
3845 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
3846 us produce better error message.
3848 2006-09-27 Marek Safar <marek.safar@seznam.cz>
3850 * expression.cs (Binary.ResolveOperator): Warn about a side effect
3851 of the `|' operator.
3853 * report.cs: A new warning added.
3855 2006-09-27 Martin Baulig <martin@ximian.com>
3857 * generic.cs (GenericMethod): Don't make this abstract.
3859 2006-09-27 Martin Baulig <martin@ximian.com>
3862 (InternalErrorException): Added overloaded ctor taking a params array.
3864 2006-09-26 Marek Safar <marek.safar@seznam.cz>
3866 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
3867 Fixed the cases when same error was reported twice.
3869 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
3870 now report symbol information.
3872 2006-09-25 Martin Baulig <martin@ximian.com>
3874 * class.cs: Completely unified with the gmcs version.
3876 2006-09-25 Martin Baulig <martin@ximian.com>
3878 * typemanager.cs (TypeManager.IsNullableType): New public function.
3879 (TypeManager.IsNullableTypeOf): Likewise.
3880 (TypeManager.IsNullableValueType): Likewise.
3882 * class.cs (MethodCore): Added the `GenericMethod' argument from
3883 gmcs and also unified all classes derived from `MethodCore' with gmcs.
3885 2006-09-24 Raja R Harinath <harinath@gmail.com>
3887 * convert.cs: Unify with gmcs version.
3889 2006-09-24 Marek Safar <marek.safar@seznam.cz>
3891 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
3892 verify them as well.
3894 * report.cs: New warning.
3896 2006-09-24 Marek Safar <marek.safar@seznam.cz>
3898 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
3899 for anonymous block with out argument.
3901 2006-09-24 Marek Safar <marek.safar@seznam.cz>
3903 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
3904 not used private events only.
3906 2006-09-23 Marek Safar <marek.safar@seznam.cz>
3908 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
3910 * const.cs (Const.Define): Check for constant type.
3911 (Const.IsConstantTypeValid): Looks for valid constant types.
3913 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
3915 * ecore.cs (EmptyConstantCast): New common class for all constant based
3918 * expression.cs (Is.DoResolve): Handle null constant especially.
3919 (New.DoResolve): Check for new void().
3920 (MemberAccess.DoResolve): Cope with all kind of nulls.
3922 * literal.cs (NullConstant): Uses EmptyConstantCast.
3923 (NullDefault): Based on EmptyConstantCast.
3924 (NullLiteral): Uses EmptyConstantCast.
3926 * statement.cs (Block.ResolveMeta): Check for constant type.
3928 2006-09-22 Martin Baulig <martin@ximian.com>
3930 * delegate.cs, attribute.cs: Merged with the gmcs versions.
3932 2006-09-22 Raja R Harinath <rharinath@novell.com>
3934 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
3938 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
3939 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
3942 2006-09-22 Martin Baulig <martin@ximian.com>
3944 * ecore.cs: Merged with the gmcs version.
3946 * generic.cs (ConstructedType): New dummy class.
3947 (TypeArguments): Don't make this abstract.
3950 (TypeManager.IsGenericTypeDefinition): New method.
3951 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
3953 2006-09-22 Raja R Harinath <rharinath@novell.com>
3955 * expression.cs (ComposedCast): Check for arrays of TypedReference
3956 before creating the type, not after.
3958 2006-09-21 Marek Safar <marek.safar@seznam.cz>
3960 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
3961 after ToType change.
3963 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
3964 when constant must be implicitly convertible.
3966 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
3968 * ecore.cs (NullCast): Derives from NullConstant.
3970 * expression.cs (Is.DoResolve): Removed useless variables.
3971 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
3972 (New.Constantify): Add enum support.
3973 (MemberAccess.DoResolve): Add warning when accessing null constant or
3976 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
3979 * literal.cs (NullConstant): New abstract class with common
3980 functionality for all null specializations.
3981 (NullDefault): Represents default(X) when result can be
3983 (NullLiteral): Updated.
3985 * report.cs: Add new warning.
3987 2006-09-21 Martin Baulig <martin@ximian.com>
3989 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
3991 2006-09-21 Martin Baulig <martin@ximian.com>
3993 * generic.cs (GenericConstraints): New dummy class.
3994 (Constraints): Likewise.
3995 (TypeParameter): Likewise.
3996 (TypeParameterName): Likewise.
3997 (GenericMethod): Likewise.
3999 * typemanager.cs (TypeManager.GetGenericArguments): New method.
4001 * decl.cs: Merged with the gmcs version.
4003 2006-09-21 Raja R Harinath <rharinath@novell.com>
4005 * generic.cs (TypeParameter): Implement IMemberContainer.
4006 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
4008 * rootcontext.cs: Unify with gmcs version.
4010 * report.cs: Unify with gmcs version.
4011 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
4012 from gmcs/generics.cs.
4013 * generics.cs (TypeParameter): New dummy class.
4015 * support.cs: Unify with gmcs version.
4017 2006-09-20 Raja R Harinath <rharinath@novell.com>
4019 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
4020 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
4022 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
4023 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
4024 * mcs.exe.sources: Add generic.cs.
4026 * codegen.cs: Unify with gmcs version.
4028 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
4029 (EmitContext): Add GenericDeclContainer implementation.
4030 * decl.cs (MemberCore, DeclSpace): Likewise.
4031 * namespace.cs: Remove #ifdef GMCS_SOURCE.
4033 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
4034 MCS TypeManager has a corresponding dummy method.
4036 2006-09-19 Martin Baulig <martin@ximian.com>
4038 * expression.cs: Completely merged with the gmcs version.
4040 2006-09-19 Martin Baulig <martin@ximian.com>
4042 * expression.cs (Invocation): Merged with the gmcs version.
4043 (ArrayAccess.GetStoreOpcode): Likewise.
4045 2006-09-19 Martin Baulig <martin@ximian.com>
4048 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
4049 (TypeManager.IsGenericMethodDefinition): Likewise.
4051 2006-09-19 Martin Baulig <martin@ximian.com>
4054 (TypeManager.IsEqual): Moved the gmcs implementation here.
4055 (TypeManager.DropGenericTypeArguments): Likewise.
4056 (TypeManager.DropGenericMethodArguments): Likewise.
4057 (TypeManager.GetTypeArguments): Moved here from gmcs.
4058 (TypeManager.HasGenericArguments): Likewise.
4060 2006-09-19 Martin Baulig <martin@ximian.com>
4062 * expression.cs (Binary): Merged with the gmcs version.
4064 2006-09-19 Martin Baulig <martin@ximian.com>
4066 * expression.cs (Probe, As, Is): Merged with the gmcs version.
4068 2006-09-19 Martin Baulig <martin@ximian.com>
4070 * typemanager.cs: Merged with the gmcs version.
4072 2006-09-16 Raja R Harinath <rharinath@novell.com>
4074 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
4075 * driver.cs: Likewise.
4077 2006-09-16 Marek Safar <marek.safar@seznam.cz>
4080 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
4081 only if parent type is class.
4082 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
4085 2006-09-15 Marek Safar <marek.safar@seznam.cz>
4088 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
4090 * typemanager.cs(CSharpName): Converts NullType to null.
4092 2006-09-15 Martin Baulig <martin@ximian.com>
4095 (TypeManager.GetMethodName): Added mcs implementation.
4096 (TypeManager.IsEqual): Likewise.
4099 (SimpleName.RemoveGenericArity): Added dummy implementation.
4101 * pending.cs: Merged with the gmcs version.
4103 2006-09-15 Martin Baulig <martin@ximian.com>
4105 * statement.cs: Merge with the gmcs version.
4107 2006-09-15 Martin Baulig <martin@ximian.com>
4109 * statement.cs (Switch): Merge with the gmcs implementation
4110 (without nullables), which is newer.
4112 2006-09-15 Martin Baulig <martin@ximian.com>
4114 * statement.cs (Block.Variables): Make this public.
4115 (ToplevelBlock.Parameters): Make this a property.
4116 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
4118 2006-09-15 Martin Baulig <martin@ximian.com>
4120 * namespace.cs: Merge with the gmcs version.
4122 2006-09-15 Martin Baulig <martin@ximian.com>
4124 * decl.cs (MemberName): Minor code cleanups.
4126 2006-09-15 Martin Baulig <martin@ximian.com>
4128 * parameter.cs: Merge with the gmcs version.
4130 2006-09-15 Martin Baulig <martin@ximian.com>
4132 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
4133 and an error in mcs.
4135 2006-09-15 Martin Baulig <martin@ximian.com>
4137 * flowanalysis.cs: Merged from GMCS; added the generics code into
4138 a `GMCS_SOURCE' conditional so we can share this file.
4140 2006-09-08 Martin Baulig <martin@ximian.com>
4142 * typemanager.cs (TypeManager.interlocked_type): New public field.
4143 (TypeManager.int_interlocked_compare-exchange): New public field.
4144 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
4145 enumerator types here and call InitGenericCoreTypes().
4146 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
4147 after calling InitEnumUnderlyingTypes().
4150 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
4151 `classes_second_stage'.
4153 2006-09-14 Marek Safar <marek.safar@seznam.cz>
4155 * assign.cs, ecore.cs, expression.cs: Share error message text.
4156 * class.cs (FieldMember.Define): Check for varible of static type.
4157 * driver.cs (LoadAssembly): Uses error output for errors.
4158 * statement.cs: Updated.
4160 2006-09-08 Marek Safar <marek.safar@seznam.cz>
4162 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
4165 2006-09-07 Martin Baulig <martin@ximian.com>
4168 (MainDriver): Revert r62663 from Marek; see #70506 for details.
4170 2006-08-29 Miguel de Icaza <miguel@novell.com>
4172 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
4174 2006-08-17 Miguel de Icaza <miguel@novell.com>
4176 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
4177 #52019 and #79064, the use of the \uXXXX sequence in source code
4178 to represent unicode characters.
4180 2006-08-15 Marek Safar <marek.safar@seznam.cz>
4182 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
4184 * class.cs, ecore.cs, statement.cs: Merged to one error message.
4186 2006-08-13 Miguel de Icaza <miguel@novell.com>
4188 * assign.cs: Catch attempts to assign to a method groups in += and
4191 2006-08-13 Marek Safar <marek.safar@seznam.cz>
4194 * cs-parser.jay: Don't destroy current array type by typeof of array's.
4196 2006-08-12 Marek Safar <marek.safar@seznam.cz>
4198 * class.cs (Method.Define): Issue a warning when generic method looks like
4200 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
4203 2006-08-09 Marek Safar <marek.safar@seznam.cz>
4205 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
4207 * decl.cs (MemberCache.FindMembers): When container is interface we need to
4208 search all base interfaces as a member can be ambiguous.
4209 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
4210 Constructor member type filter.
4211 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
4212 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
4213 reporting for returned memberinfos.
4214 * report.cs: Updated.
4215 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
4216 version to work on all runtimes.
4217 (TypeManager.RealMemberLookup): Removed members filtering.
4219 2006-08-08 Raja R Harinath <rharinath@novell.com>
4221 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
4222 (PropertyExpr.EmitAssign): Likewise.
4223 * expression.cs (Indirection.EmitAssign): Likewise.
4224 (LocalVariableReference.EmitAssign): Likewise.
4225 (ParameterReference.EmitAssign): Likewise.
4226 (Invocation.EmitArguments): Likewise.
4227 (ArrayAccess.EmitAssign): Likewise.
4228 (IndexerAccess.EmitAssign): Likewise.
4229 (This.EmitAssign): Likewise.
4230 (ConditionalLogicalOperator.Emit): Likewise.
4233 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
4234 instead of ArrayList. If the hashtable has a LocalBuilder, don't
4235 leave it in after returning it.
4236 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
4238 2006-08-06 Marek Safar <marek.safar@seznam.cz>
4240 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
4243 2006-08-03 Raja R Harinath <rharinath@novell.com>
4245 Fix cs0146-3.cs and cs0146-4.cs.
4246 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
4247 enclosing types don't depend on the current type.
4249 2006-08-02 Raja R Harinath <rharinath@novell.com>
4252 * class.cs (TypeContainer.DoDefineMembers): Use
4253 FindBaseMemberWithSameName on Parent, since we're interested in
4254 whether we hide inherited members or not.
4255 (FindBaseMemberWithSameName): Make slightly more robust.
4257 Fix the non-generic testcase from #77396
4258 * decl.cs (DeclSpace.DeclContainer): Remove override.
4260 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
4261 declspaces for doppelgangers too.
4262 (UsingEntry): Implement IResolveContext.
4263 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
4264 'this' as the resolve context.
4265 (LocalAliasEntry): Likewise.
4267 Implement parts of #77403
4268 * roottypes.cs (RootDeclSpace): New. Used to represent the
4269 toplevel declaration space. Each namespace declaration introduces
4270 a "partial" root declaretion space.
4271 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
4272 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
4273 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
4274 from 'current_namespace.SlaveDeclSpace'.
4275 (namespace_declaration): Likewise.
4276 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
4277 check. It can't happen now.
4278 * decl.cs (DeclSpace.LookupType): Likewise.
4279 * driver.cs (MainDriver): Sanity check.
4281 2006-08-01 Raja R Harinath <rharinath@novell.com>
4283 * decl.cs (DeclSpace.FindNestedType): Remove.
4284 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
4285 LookupTypeContainer to get the container of the nested type.
4286 * class.cs (TypeContainer.FindNestedType): Make non-override.
4288 2006-07-31 Raja R Harinath <rharinath@novell.com>
4290 * decl.cs (DeclSpace.PartialContainer): Move field from ...
4291 * class.cs (TypeContainer.PartialContainer): ... here.
4292 (TypeContainer.AddBasesForPart): New helper.
4293 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
4295 * cs-parser.jay (current_class): Convert to DeclSpace.
4296 (struct_declaration, interface_declaration, class_declaration):
4297 Use AddBasesForPart instead of .Bases directly.
4298 * const.cs, iterators.cs: Update to changes.
4300 2006-07-28 Raja R Harinath <rharinath@novell.com>
4302 * class.cs (TypeContainer.AddMemberType): Rename from
4304 (TypeContainer.AddMember): Rename from AddToMemberContainer.
4305 (AddTypeContainer): New. Combine AddClassOrStruct and
4307 (AddPartial): Update. Add 'is_partial' argument.
4308 * roottypes.cs: Update to changes.
4309 * cs-parser.jay (push_current_class): New helper for handling
4310 current_container and current_class.
4311 (struct_declaration, interface_declaration, class_declaration):
4314 2006-07-26 Raja R Harinath <rharinath@novell.com>
4316 * roottypes.cs: Rename from tree.cs.
4318 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
4319 * tree.cs (Tree, ITreeDump): Remove types.
4320 * rootcontext.cs (tree, Tree): Remove fields.
4321 (root, ToplevelTypes): New.
4322 * *.cs: Update to rename.
4324 * tree.cs (Tree.RecordDecl): Remove.
4325 (RootTypes.AddToTypeContainer): Record the toplevel type in its
4327 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
4329 2006-07-23 Raja R Harinath <harinath@gmail.com>
4331 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
4332 DoFlowAnalysis and OmitStructFlowAnalysis here.
4333 (ec.With): Rename from WithUnsafe and generalize.
4334 (ec.WithCheckState): Remove. All users can be handled by 'With'.
4335 (ec.WithFlowAnalyis): New.
4336 * ecore.cs, expression.cs, statement.cs: Update.
4338 2006-07-22 Raja R Harinath <harinath@gmail.com>
4340 * statement.cs (Block.ResolveMeta): Simplify slightly.
4342 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
4343 multiple boolean fields. Convert InUnsafe, constant_check_state,
4344 check_state to flags.
4345 (CheckState, ConstantCheckState): Update.
4346 (InUnsafe): New read-only property.
4347 (FlagsHandle): Rename from CheckStateHandle and convert to handle
4349 (WithUnsafe): New helper similar to WithCheckState.
4350 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
4351 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
4353 2006-07-21 Raja R Harinath <rharinath@novell.com>
4355 Make comparisons use the same IL irrespective of whether they're
4356 in a 'checked' or 'unchecked' context: one of the issues in #78899
4357 * codegen.cs (EmitContext.CheckState): Make read-only property.
4358 (EmitContext.ConstantCheckState): Likewise.
4359 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
4360 helper that implement a save/restore stack for CheckState
4361 values. This is the only way to change check-state.
4362 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
4363 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
4364 (CheckedExpr.EmitBranchable): New forwarding method.
4365 (UnCheckedExpr): Likewise.
4366 * statement.cs (Block.ResolveMeta): Use WithCheckState.
4367 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
4368 (Checked.Resolve, checked.DoEmit): Likewise.
4370 2006-07-20 Miguel de Icaza <miguel@novell.com>
4372 * anonymous.cs: Cache the resolved anonymous delegate, and return
4373 this so that the ResolveTopBlock is only triggered once, not
4376 Currently we trigger ResolvetopBlock twice due to a first pass of
4377 argument check compatibility, and a second pass that does the
4380 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4382 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
4384 * rootcontext.cs (Reset): Add helper_classes.
4386 2006-07-15 Marek Safar <marek.safar@seznam.cz>
4389 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
4392 2006-07-13 Miguel de Icaza <miguel@novell.com>
4394 * statement.cs (Lock): Handle expressions of type
4395 TypeManager.null_type specially. Fixes #78770
4397 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4399 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
4402 2006-07-08 Marek Safar <marek.safar@seznam.cz>
4404 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
4405 for accessors as well.
4406 * ecore.cs (EventExpr): Add AccessorTable.
4408 2006-07-01 Marek Safar <marek.safar@seznam.cz>
4411 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
4412 for CS0122 where appropriate.
4413 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
4415 (Filter): Assembly can be null in the case of top level attributes.
4417 2006-06-25 Marek Safar <marek.safar@seznam.cz>
4421 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
4422 is done at global level.
4424 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4426 A fix for #77002, Implemented TypeForwarder support.
4428 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
4429 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
4430 * typemanager.cs (): Add type_forwarder_attr_type.
4432 2006-06-24 Marek Safar <marek.safar@seznam.cz>
4434 * report.cs: Add CS0469 warning.
4436 2006-06-21 Martin Baulig <martin@ximian.com>
4438 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
4439 the `try'-block, so we also report CS0016 etc. there.
4441 2006-06-21 Martin Baulig <martin@ximian.com>
4444 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
4446 2006-06-21 Martin Baulig <martin@ximian.com>
4448 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
4449 also report CS1686 for parameters.
4451 2006-06-21 Martin Baulig <martin@ximian.com>
4453 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
4454 instead of an error if the value is not implicitly convertible to
4455 the switch types; fixes #77964.
4457 2006-06-21 Raja R Harinath <rharinath@novell.com>
4460 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
4461 FieldBuilder is null.
4464 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
4465 'left' and 'right' before error-checking.
4467 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
4469 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
4471 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
4472 (FieldExpr.DoResolve): likewise.
4473 (PropertyExpr.InstanceResolve): likewise.
4474 (EventExpr.InstanceResolve): likewise.
4476 2006-06-04 Marek Safar <marek.safar@seznam.cz>
4478 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
4479 attribute applicable tests for attribute argument.
4481 2006-06-02 Raja R Harinath <rharinath@novell.com>
4484 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
4485 (Binary.OverloadResolve_PredefinedIntegral): New.
4486 (Binary.OverloadResolve_PredefinedFloating): New.
4487 (Binary.OverloadResolve_PredefinedString): New.
4488 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
4489 Follow the standard more closely, and treat numeric promotions in
4490 terms of overload resolution.
4491 (Binary.CheckShiftArguments): Simplify.
4493 2006-06-01 Raja R Harinath <rharinath@novell.com>
4495 * flowanalysis.cs (MyBitVector): Simplify representation.
4496 (MyBitVector.Clone): Avoid allocating BitArray.
4497 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
4498 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
4499 (*): Update. Change all references to MyBitVector.And and
4500 MyBitVector.Or to &= and |=.
4502 2006-05-29 Raja R Harinath <rharinath@novell.com>
4505 * cs-parser.jay (formal_parameter_list): Extend the pattern below
4506 to param arguments too.
4508 2006-05-26 Miguel de Icaza <miguel@novell.com>
4510 * cs-parser.jay: Catch another parsing form for arglist being
4511 followed by other arguments. Fixes #78313.
4513 2006-05-24 Raja R Harinath <rharinath@novell.com>
4515 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
4516 checking of out parameters to ...
4517 (FlowBranchingToplevel.Merge): ... here.
4518 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
4519 set, propagate the origin upward, and only complain if there was
4521 (FlowBranchingException.AddContinueOrigin): Likewise.
4522 (FlowBranchingException.AddReturnOrigin): Likewise.
4523 (FlowBranchingException.AddGotoOrigin): Likewise.
4525 2006-05-23 Raja R Harinath <rharinath@novell.com>
4527 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
4528 unreachable, skip it.
4529 (FlowBranchingException.Merge): Always propagate jumps, even if
4530 the finally block renders subsequent code unreachable.
4532 2006-05-18 Raja R Harinath <rharinath@novell.com>
4535 * statement.cs (Goto.Resolve): Move responsibility for resolving
4536 'goto' to FlowBranching.AddGotoOrigin.
4537 (Goto.SetResolvedTarget): New. Callback to set the
4538 LabeledStatement that's the target of the goto.
4539 (Goto.DoEmit): Use Leave instead of Br when crossing an
4540 unwind-protect boundary.
4541 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
4542 LookupLabel and adjust to new semantics.
4543 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
4544 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
4545 Goto.SetResolvedTarget to update target.
4546 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
4547 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
4548 AddBreakOrigin & co. Delay propagation until ...
4549 (FlowBranchingException.Merge): ... this.
4551 * statement.cs (Block.Resolve): Always depend on flow-branching to
4552 determine unreachability. Kill workaround that originally emitted
4553 only one statement after an "unreachable" label (see infloop in
4556 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
4557 This is still "wrong", but anything better would probably need a
4558 multi-pass algorithm.
4559 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
4560 usage vector. Force current usage vector to be reachable, to
4561 optimistically signify backward jumps.
4562 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
4564 (FlowBranchingLabeled.Merge): New. If no backward jump was
4565 detected, return the original salted-away usage vector instead,
4566 updated with appropriate changes. Print unreachable warning if
4568 * statement.cs (Block.Resolve): Don't print unreachable warning on
4569 a labeled statement.
4571 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
4573 * driver.cs: Pass filename without path to AssemblyBuilder's
4574 AddResourceFile. Fixes bug #78407.
4576 2006-05-17 Raja R Harinath <rharinath@novell.com>
4578 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
4579 * flowanalysis.cs (FlowBranchingLabeled): ... here.
4580 (FlowBranching.MergeChild): Overwrite
4581 reachability information from Labeled branchings too.
4583 2006-05-16 Raja R Harinath <rharinath@novell.com>
4585 * statement.cs (Goto.Resolve): Merge jump origins here ...
4586 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
4588 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
4589 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
4590 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
4591 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
4593 * statement.cs (Goto.Resolve): ... not here.
4594 (Goto.Emit): Remove CS1632 check.
4596 2006-05-14 Marek Safar <marek.safar@seznam.cz>
4598 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
4601 2006-05-11 Raja R Harinath <rharinath@novell.com>
4603 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
4604 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
4605 (FlowBranchingException.Label): Likewise.
4607 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
4609 (MyBitVector.Or): Use it to avoid losing information (Count).
4610 (FlowBranching.MergeOrigins): Likewise.
4612 * flowanalysis.cs (UsageVector.IsDirty): Remove.
4613 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
4614 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
4615 (UsageVector.ToString): Simplify.
4616 (UsageVector.MergeSiblings): Move here from ...
4617 (FlowBranching.Merge): ... here.
4618 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
4621 2006-05-10 Raja R Harinath <rharinath@novell.com>
4623 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
4624 null bitvector is treated as all-true.
4626 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
4627 (MyBitVector): Rationalize invariants. 'vector != null' implies
4628 that we have our own copy of the bitvector. Otherwise,
4629 'InheritsFrom == null' implies all inherited bits are true.
4631 2006-05-09 Marek Safar <marek.safar@seznam.cz>
4633 * statement.cs (LocalInfo): Add IsConstant.
4634 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
4635 local variable for constants.
4637 2006-05-09 Raja R Harinath <rharinath@novell.com>
4639 * flowanalysis.cs (MyBitVector.Empty): New.
4640 (MyBitVector): Don't allow InheritedFrom to be null.
4641 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
4642 (UsageVector, FlowBranching): Update to changes.
4644 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
4645 recursion. The 'Parent == null' condition isn't sufficient for
4647 (FlowBranching.AddBreakOrigin): Likewise.
4648 (FlowBranching.AddContinueOrigin): Likewise.
4649 (FlowBranching.AddReturnOrigin): Likewise.
4650 (FlowBranching.StealFinallyClauses): Likewise.
4651 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
4652 (FlowBranching.CheckOutParameters): Likewise.
4653 (FlowBranchingToplevel): Terminate all the above recursions here.
4654 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
4655 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
4657 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
4659 (FlowBranchingToplevel): New. Empty for now.
4660 (FlowBranching.MergeTopBlock): Update.
4661 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
4662 branching for the anonymous delegate.
4663 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
4665 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
4666 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
4667 information at the start of the merge. Reorganize.
4669 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4671 * class.cs (MethodData.Define): Method cannot implement interface accessor.
4673 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4675 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
4676 to newly introduced ctor.
4678 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
4679 message to one place.
4680 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
4683 2006-05-07 Marek Safar <marek.safar@seznam.cz>
4685 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
4687 * ecore.cs (Expression.ResolveAsConstant): Updated.
4689 * statement.cs (ResolveMeta): Updated.
4691 2006-05-06 Marek Safar <marek.safar@seznam.cz>
4693 * cs-parser.jay: __arglist cannot be used in initializer.
4695 2006-05-06 Marek Safar <marek.safar@seznam.cz>
4698 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
4701 2006-05-05 Raja R Harinath <rharinath@novell.com>
4703 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
4704 (LabeledStatement): Add 'name' parameter.
4705 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
4706 (Block.AddLabel): Update to changes.
4707 * cs-parser.jay (labeled_statement): Likewise.
4709 * flowanalysis.cs (BranchingType.Labeled): New.
4710 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
4711 (FlowBranchingLabeled): New. Does nothing for now, but will
4712 eventually handle 'goto' flows.
4713 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
4714 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
4715 that's terminated ...
4716 (Block.Resolve): ... here.
4718 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
4719 (UsageVector.MergeFinallyOrigins): Likewise.
4720 (FlowBranching.InTryOrCatch): Likewise.
4721 (FlowBranching.AddFinallyVector): Likewise.
4722 (FlowBranchingException): Update to changes.
4725 * statement.cs (Return.Resolve): Move error checking to ...
4726 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
4727 (FlowBranchingException): Handle return origins like break and
4729 (FlowBranching.UsageVector.CheckOutParameters): Remove.
4731 2006-05-04 Marek Safar <marek.safar@seznam.cz>
4734 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
4737 2006-05-04 Marek Safar <marek.safar@seznam.cz>
4740 * class.cs (MethodData.Define): Do public accessor check only when method
4741 implements an interface.
4743 2006-05-04 Raja R Harinath <rharinath@novell.com>
4745 Remove special handling of 'break'
4746 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
4747 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
4748 (UsageVector.Break): Remove.
4749 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
4751 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
4753 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
4754 UsageVector.Breaks (). Don't set NeedsReturnLabel.
4756 2006-05-03 Marek Safar <marek.safar@seznam.cz>
4759 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
4760 be the interface member.
4762 2006-05-03 Marek Safar <marek.safar@seznam.cz>
4765 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
4766 for emitting small (int) values.
4768 2006-05-03 Raja R Harinath <rharinath@novell.com>
4771 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
4772 control-flow passes through the 'finally' after merging-in all the
4773 control-flows from 'try' and the 'catch' clauses.
4775 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
4776 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
4777 always true at the only non-recursive entry point.
4778 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
4779 FlowBranchingBreakable.
4780 (FlowBranchingLoop): Remove.
4781 * statement.cs (Return.DoResolve): Update to changes.
4784 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
4785 (FlowBranching.CreateBranching): Handle it: create a
4786 FlowBranchingContinuable.
4787 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
4788 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
4789 except that it handles the 'continue' command.
4790 (FlowBranching.UsageVector.MergeOrigins): Rename from
4792 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
4793 except that it overrides AddContinueOrigin.
4794 (FlowBranchingException): Override AddContinueOrigin, similar to
4796 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
4797 Create a new branching around the embedded statement.
4798 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
4799 control flow after the embedded statement.
4800 (Continue.Resolve): Move all error checking to AddContinueOrigin.
4802 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
4803 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
4804 FlowBranchingBreakable.
4805 (FlowBranchingSwitch): Remove.
4808 * statement.cs (Break.Resolve): Simplify. Move responsibility for
4809 error reporting to ...
4810 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
4811 Rename from 'AddBreakVector'. Add new location argument. Return
4812 a bool indicating whether the 'break' crosses an unwind-protect.
4813 (FlowBranchingException.AddBreakOrigin): Add.
4814 (FlowBranchingException.Merge): Propagate 'break's to surrounding
4815 flowbranching after updating with the effects of the 'finally'
4817 (FlowBranchingBreakable): New common base class for
4818 FlowBranchingLoop and FlowBranchingSwitch.
4820 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
4822 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
4824 2006-05-02 Raja R Harinath <rharinath@novell.com>
4826 * statement.cs (Do.Resolve): If the loop is infinite, set the
4828 (While.Resolve, For.Resolve): Set a barrier after the embedded
4829 statement. There's no direct control flow that goes from the end
4830 of the embedded statement to the end of the loop.
4831 * flowanalysis.cs (FlowBranching.Infinite): Remove.
4832 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
4833 above ensure that the reachability is correctly computed.
4835 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
4836 (UsageVector.MergeBreakOrigins): If the current path is
4837 unreachable, treat it as if all parameters/locals are initialized.
4838 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
4839 infinite loops before merging-in break origins.
4841 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
4842 (Reachability.Reachable): Split part into ...
4843 (Reachability.Unreachable): ... this. Simplify.
4844 (Reachability.IsUnreachable): Use 'Unreachable' instead.
4846 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
4847 (Reachability.SetThrowsSometimes): Likewise.
4848 (FlowBranchingBlock.MergeTopBlock): Don't compare against
4849 TriState.Always, use corresponding property.
4850 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
4851 (Block.Resolve): Likewise. Remove some redundant checks.
4853 2006-05-02 Raja R Harinath <harinath@gmail.com>
4855 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
4856 (Reachability.Meet): Don't bother checking AlwaysThrows --
4857 barrier is always set.
4858 (FlowBranchingBlock.Merge): Likewise.
4860 2006-05-01 Raja R Harinath <harinath@gmail.com>
4862 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
4863 checks for unreachable.
4865 2006-05-01 Marek Safar <marek.safar@seznam.cz>
4868 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
4870 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
4871 whether field is really assigned.
4873 2006-04-30 Raja R Harinath <harinath@gmail.com>
4875 * flowanalysis.cs (Reachability): Make 4-argument constructor
4877 (Reachability.Meet): Rename from 'And'. Remove static variant.
4878 (Reachability.Always): Rename from the highly misleading
4879 'Reachability.Never'.
4880 (FlowBranching.Merge): Update to changes. Mark an impossible
4881 situation with a 'throw'.
4882 (*): Update to changes.
4884 2006-04-29 Raja R Harinath <harinath@gmail.com>
4886 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
4888 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
4889 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
4890 (*): Update to changes.
4891 * statement.cs: Update to changes.
4893 2006-04-28 Marek Safar <marek.safar@seznam.cz>
4896 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
4898 2006-04-28 Raja R Harinath <harinath@gmail.com>
4900 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
4903 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
4904 argument to two arguments: an usage-vector and a bool. Move call
4905 to FlowBranching.Merge () ...
4906 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
4908 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
4909 handling of loop and switch reachability to ...
4910 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
4912 2006-04-27 Raja R Harinath <harinath@gmail.com>
4914 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
4915 handling to FlowBranchingLoop.InLoop.
4916 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
4918 2006-04-26 Marek Safar <marek.safar@seznam.cz>
4921 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
4922 anonymous method is allowed from AnonymousContainer here.
4924 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
4926 2006-04-24 Raja R Harinath <rharinath@novell.com>
4929 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
4931 2006-04-23 Marek Safar <marek.safar@seznam.cz>
4934 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
4935 (DoubleConstant.Reduce): Ditto.
4937 2006-04-23 Raja R Harinath <rharinath@novell.com>
4939 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
4940 Remove 'lvalue_right_side' argument. Move parts to ...
4941 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
4942 (LocalVariable.DoResolveLValue): ... these.
4944 2006-04-21 Raja R Harinath <rharinath@novell.com>
4947 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
4948 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
4949 (LocalVariableReference.DoResolveBase): Use it to implement new
4951 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
4952 (Argument.Resolve): Simplify. Move CS1510 check ...
4953 * ecore.cs (Expression.ResolveLValue): ... here.
4954 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
4955 (PropertyExpr.DoResolveLValue): Likewise.
4956 (FieldExpr.Report_AssignToReadonly): Likewise.
4957 (FieldExpr.DoResolve): Add 'out_access' argument. Use
4958 LValueMemberAccess or LValueMemberOutAccess on instance depending
4960 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
4961 DoResolve as appropriate.
4963 2006-04-20 Raja R Harinath <rharinath@novell.com>
4966 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
4967 implicit conversions on 'out' and 'ref' arguments.
4969 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
4970 improve clarity. Remove dead code.
4973 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
4974 (Catch.Resolve): Resolve VarBlock if it exists.
4976 2006-04-19 Miguel de Icaza <miguel@novell.com>
4978 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
4979 twice, this was some residual code, the enumerator was emitted
4980 properly in the two branche of if later.
4982 2006-04-19 Raja R Harinath <rharinath@novell.com>
4984 * expression.cs (Cast.ResolveLValue): Remove. The result of a
4985 cast is never an lvalue.
4986 (Cast.DoResolve, Cast.ResolveRest): Combine.
4987 (Argument.Emit): Simplify slightly. Move 'Expr is
4988 IMemoryLocation' check ...
4989 (Argument.Resolve): ... here.
4990 (Argument.Error_LValueRequired): Remove. Inline into only user.
4992 Simplifications. Fix cs0191-2.cs
4993 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
4994 CS1649 and CS1651 to ...
4995 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
4996 the actual selection of the error code and message to a lookup
4997 table. Add a dummy return value to simplify callsites.
4998 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
4999 readonly fields of other instances of the same type. Move CS0197
5001 * expression.cs (Argument.Resolve): ... here. Simplify code.
5002 Ensure that ec.InRefOutArgumentResolving is only set during LValue
5003 resolution of an out or ref argument. The code simplification
5004 above uses this invariant.
5006 2006-04-18 Raja R Harinath <rharinath@novell.com>
5008 Possibly fix #77752. Fix cs1690-[4-7].cs.
5009 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
5010 CheckMarshallByRefAccess. Drop parameter.
5011 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
5013 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
5015 * report.cs (AllWarnings): Add CS1690.
5016 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
5018 (LocalVariableReference.DoResolveBase): Update.
5020 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5022 * class.cs (MethodOrOperator): Moved common parts from method class.
5023 detect obsolete attributes.
5024 (Method.Define): Simplified as it reuses code from base.
5025 (Constructor.ValidAttributeTargets): Fixed issue found during
5027 (Destructor.ValidAttributeTargets): Fixed issue found during
5029 (Operator): Finished refactoring set off by #78020. Operator class is now
5030 ordinary method class.
5032 * anonymous.cs: Updated.
5034 * decl.cs (DeclSpace): Add IsGeneric
5036 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5038 * class.cs (Constructor.Emit): Don't emit the attributes twice.
5040 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5042 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
5043 detect obsolete attributes.
5044 (Method.CreateEmitContext): Moved to MethodOrOperator.
5046 2006-04-09 Marek Safar <marek.safar@seznam.cz>
5049 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
5050 customized exception to make crash detection easier.
5051 (MethodOrOperator): Started to work on new base class for methods and
5053 (Method): Derives from MethodOrOperator.
5054 (Constructor.Emit): Emits its own attributes.
5055 (AbstractPropertyEventMethod.Emit): Ditto.
5056 (Operator): Derives from MethodOrOperator, will refactor fully in extra
5058 (Operator.Emit): It's temporary more tricky than should be.
5060 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
5062 * report.cs (InternalErrorException): Add ctor with inner exception.
5064 2006-04-08 Marek Safar <marek.safar@seznam.cz>
5067 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
5070 2006-04-07 Marek Safar <marek.safar@seznam.cz>
5073 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
5076 2006-04-06 Marek Safar <marek.safar@seznam.cz>
5078 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
5079 attribute is present and Guid not.
5080 (Interface.ApplyAttributeBuilder): Ditto.
5082 * attribute.cs: Add error message.
5084 2006-04-06 Marek Safar <marek.safar@seznam.cz>
5088 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
5089 sources (it's composite) so hold them in extra array as they are used in
5090 Emit phase only. It worked in the previous versions by mistake.
5091 (Attribute.Emit): Emit attribute for more owners when exist.
5093 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
5094 it has now different behaviour.
5096 2006-04-04 Marek Safar <marek.safar@seznam.cz>
5098 * constant.cs (Constant.IsDefaultInitializer): New method.
5100 * class.cs: Updated.
5102 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
5103 re-initialize default values. It saves KBs almost for every assembly.
5104 Thanks Zoltan for the idea.
5105 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
5106 (ArrayCreation.DoResolve): Resolve only once.
5107 (ArrayCreation.Emit): Emit static initializer only when it is faster.
5108 (ArrayCreation.GetAttributableValue): Cope with optimized values.
5110 2006-04-03 Zoltan Varga <vargaz@gmail.com>
5112 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
5115 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5117 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
5118 in an embedded statement too.
5120 2006-04-01 Raja R Harinath <rharinath@novell.com>
5123 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
5125 2006-04-01 Marek Safar <marek.safar@seznam.cz>
5129 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
5132 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
5134 2006-03-31 Marek Safar <marek.safar@seznam.cz>
5136 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
5139 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
5140 LocalTemporary change.
5142 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
5144 (ClassOrStruct.DefineFieldInitializers): Implemented static field
5145 initializers optimization.
5146 (ClassOrStruct.TypeAttr): Moved from modifiers.
5147 (Constructor.CheckBase): Don't crash when static ctor has parameters.
5148 (FieldBase.ResolveInitializer): Resolves initializer.
5149 (FieldBase.HasDefaultInitializer): New property.
5151 * cs-parser.jay: Removed message.
5153 * expression.cs (CompilerGeneratedThis): New specialization.
5155 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
5157 2006-03-28 Marek Safar <marek.safar@seznam.cz>
5159 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
5161 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5163 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
5164 be now EnumConstants only.
5166 2006-03-27 Marek Safar <marek.safar@seznam.cz>
5168 * attribute.cs, driver.cs: Reset more caches.
5170 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5172 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
5174 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5176 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
5177 for easier reuse. Updated all overrides.
5178 (IntegralConstant): New base class for all integral constants.
5179 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
5180 of the constant range, report custom error.
5181 (UIntConstant.Reduce): Fixed uint conversion.
5183 * ecore.cs, literal.cs: Reduce updates.
5185 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5189 * class.cs (Constructor.Define): Removed extra if for default ctors.
5190 A patch from Atsushi Enomoto.
5192 2006-03-26 Marek Safar <marek.safar@seznam.cz>
5194 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
5195 GetAttributableValue.
5197 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
5200 * convert.cs (ImplicitConversionRequired): Error message moved to
5203 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
5204 automatic implicit conversion of an output value.
5205 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
5207 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
5209 (TypeOf.GetAttributableValue): Add extra handling for object type.
5211 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
5212 special error message.
5214 2006-03-25 Marek Safar <marek.safar@seznam.cz>
5216 * class.cs (Constructor.Emit): Don't crash when struct ctor is
5218 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
5219 compatible with MS runtime.
5221 2006-03-23 Marek Safar <marek.safar@seznam.cz>
5223 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
5224 attribute arguments here.
5226 * class.cs (Indexer.Define): The check was moved to attribute class.
5228 2006-03-22 Marek Safar <marek.safar@seznam.cz>
5230 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
5231 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
5234 2006-03-22 Raja R Harinath <rharinath@novell.com>
5236 Support ParameterDefaultValueAttribute in gmcs. Also applied to
5237 mcs to keep code differences small.
5238 * attribute.cs (Attribute.GetParameterDefaultValue): New.
5239 * typemanager.cs (parameter_default_value_attribute_type): New.
5240 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
5243 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5245 * expression.cs (StringConcat.Append): Reverted back to no warning state.
5247 2006-03-21 Marek Safar <marek.safar@seznam.cz>
5249 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
5251 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
5254 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
5256 * doc-bootstrap.cs : fix build.
5258 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5260 * expression.cs (StringConcat.Append): Issue a warning when empty string
5263 2006-03-20 Marek Safar <marek.safar@seznam.cz>
5265 * assign.cs (CompoundAssign.ResolveSource): Removed.
5267 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
5270 * class.cs (TypeContainer.FindMethods): Removed.
5271 (TypeContainer.CheckMemberUsage): Made static.
5273 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
5275 * constant.cs (CheckRange): Removed unused type argument.
5276 (CheckUnsigned): Removed unused type argument.
5278 * cs-parser.jay: Updated after MemberAccess clean up.
5279 Uses Length for empty string test.
5281 * cs-tokenizer.cs: Uses Length for empty string test.
5282 (IsCastToken): Made static.
5283 (is_hex): Made static.
5284 (real_type_suffix): Made static.
5286 * decl.cs (SetupCache): Made static.
5287 (OnGenerateDocComment): Removed unused ds argument.
5289 * delegate.cs (VerifyDelegate): Removed unused argument.
5291 * doc.cs: Uses Length for empty string test.
5293 * driver.cs: Uses Length for empty string test.
5295 * enum.cs (IsValidEnumType): Made static
5297 * expression.cs (EnumLiftUp): Removed unused argument.
5298 (ResolveMethodGroup): Ditto.
5299 (BetterConversion): Ditto.
5300 (GetVarargsTypes): Ditto.
5301 (UpdateIndices): Ditto.
5302 (ValidateInitializers): Ditto.
5303 (MemberAccess.ctor): Ditto.
5304 (GetIndexersForType): Ditto.
5306 * flowanalysis.cs: (MergeFinally): Removed unused argument.
5308 * iterators.cs: Updated after MemberAccess clean up.
5310 * location.cs: Uses Length for empty string test.
5312 * namespace.cs: Uses Length for empty string test.
5314 * report.cs (CheckWarningCode): Made static.
5316 * statement.cs (LabeledStatement): Removed unused argument.
5318 * typemanager.cs (FilterNone): Removed.
5320 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5322 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
5325 * class.cs: Updated.
5327 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5329 * cs-parser.jay.cs: __arglist is not allowed for delegates.
5331 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5335 * expression.cs (VerifyArgumentsCompat): Reverted to double error
5336 reporting, it's more tricky than I thought.
5338 2006-03-18 Marek Safar <marek.safar@seznam.cz>
5342 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
5344 (AnonymousMethod.ImplicitStandardConversionExists): New method.
5345 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
5346 Add more error reporting; Fixed issue with params.
5348 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
5350 * cs-parser.jay: AnonymousMethod requires host container.
5352 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
5354 2006-03-18 Raja R Harinath <harinath@gmail.com>
5356 * class.cs: Change 'TypeContainer ds' constructor argument to
5357 'DeclSpace parent'. Some classes were missed below due to
5358 different naming convention.
5360 * class.cs (MemberCore.Parent): Delete. This makes the
5361 ParentContainer changes below enforceable by the compiler.
5363 Treat pointers to enclosing declaration space as 'DeclSpace', not
5365 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
5366 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
5368 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
5370 (Block.AddThisVariable): Likewise.
5371 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
5372 (AbstractPropertyEventMethod.Emit): Likewise.
5373 (AbstractPropertyEventMethod.EmitMethod): Likewise.
5374 (GetMethod.Define, SetMethod.Define): Likewise.
5375 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
5376 (DelegateMethod.EmitMethod): Likewise.
5378 Fix regression test-partial-13.cs.
5379 Rationalize use of PartialContainer. Ensure that the partial
5380 class semantics can be tied to type-correctness, i.e., any
5381 violation will cause a compile error.
5382 * class.cs, const.cs: Access all fields that belong to class
5383 TypeContainer via ParentContainer. Arguments of EmitContexts and
5384 Resolve()-like functions still use 'Parent'.
5386 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
5387 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
5388 (PropertyMethod.CheckModifiers): Remove unused argument.
5389 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
5392 2006-03-17 Raja R Harinath <harinath@gmail.com>
5394 Make semantics of PartialContainer simpler.
5395 * decl.cs (DeclSpace.IsPartial): Remove.
5396 * class.cs (TypeContainer.IsPartial): Likewise.
5397 (TypeContainer..ctor): Set PartialContainer to point to self.
5398 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
5399 (TypeContainer.FindNestedType): Likewise.
5400 (MemberCore.ParentContainer): Simplify. Remove deprecation.
5402 2006-03-17 Marek Safar <marek.safar@seznam.cz>
5404 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
5406 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5408 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
5411 2006-03-15 Marek Safar <marek.safar@seznam.cz>
5413 * class.cs (Operator.Define): An error for base conversion was not
5416 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
5418 * iterator.cs : yield break is allowed in try statement which has
5419 catch clauses. Fixed bug #77767.
5421 2006-03-13 Marek Safar <marek.safar@seznam.cz>
5423 A fix for #77593, #77574.
5425 * class.cs (MethodCore.CheckBase): Another if for operator.
5427 2006-03-09 Marek Safar <marek.safar@seznam.cz>
5429 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
5432 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
5433 (DelegateCreation.ImplicitStandardConversionExists): New method for just
5436 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
5439 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
5440 Updated after another emitcontext usage was clean up. It should help us to
5441 synchronize with gmcs easier.
5443 2006-03-04 Marek Safar <marek.safar@seznam.cz>
5447 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
5448 (Event.Define): ditto
5449 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
5451 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
5452 Removed redundant code and set NewSlot for Invoke method too.
5454 * parameter.cs (Parameters.ctor): Add custom, type ctor.
5455 (Parameters.MergeGenerated): New method. Use this method when you merge
5456 compiler generated argument with user arguments.
5458 2006-03-03 Marek Safar <marek.safar@seznam.cz>
5460 * attribute.cs (ResolveAsTypeTerminal): Removed.
5462 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
5463 specialization for predefined types; 30% speed up.
5464 Finally placed obsolete check to right place.
5465 (Expression.ResolveType): Removed.
5467 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
5468 Updated after ResolveType was removed.
5470 * expression.cs (Cast.ctor): Check void cast.
5471 (Binary.ResolveAsTypeTerminal): Is never type.
5472 (Conditional.ResolveAsTypeTerminal): Is never type.
5474 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
5476 2006-03-01 Raja R Harinath <rharinath@novell.com>
5479 * expression.cs (ParameterReference.DoResolveBase): Change return
5481 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
5485 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
5488 * typemanager.cs (GetFullNameSignature): Don't nullref on
5489 protected accessors.
5491 2006-02-27 Marek Safar <marek.safar@seznam.cz>
5493 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
5494 these two separated members to simplify the code.
5495 (Attribute.Resolve): Refactored to use new fields and methods.
5496 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
5497 implemented obsolete attribute checking.
5498 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
5499 implemented obsolete checking again. It look line never ending quest ;-)
5500 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
5502 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
5504 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
5506 *class.cs (Property.Define): Add RegisterProperty call.
5508 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
5509 argument groups (only 2).
5511 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
5512 encoding expression to arguments.
5513 (Expression.ExprClassToResolveFlags): Just turned to property.
5515 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
5516 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
5517 optimized as well as implemented support for zero-length attributes.
5519 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
5520 Add caching of PropertyInfo's.
5522 2006-02-25 Marek Safar <marek.safar@seznam.cz>
5524 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
5525 error multiple times.
5527 2006-02-25 Marek Safar <marek.safar@seznam.cz>
5529 New partial class implementation.
5530 A fix for #77027, #77029, #77403
5532 * attribute.cs (Attributable): Made attributes protected.
5534 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
5535 the replacements of ClassPart and PartialContainer.
5536 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
5537 (TypeContainer.AddInterface): Ditto.
5538 (TypeContainer.AddPartial): The main method for partial classes. It checks
5539 for errors and merges ModFlags and attributes. At the end class is added to
5541 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
5543 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
5544 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
5545 from the rest of partial classes.
5546 (TypeContainer.GetClassBases): Simplified.
5547 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
5549 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
5550 (TypeContainer.HasExplicitLayout): Uses Flags now.
5551 (PartialContainer): Removed.
5552 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
5553 (StaticClass): Was merged with Class.
5554 (Class.GetClassBases): class and static class bases are verified here.
5555 (Class.TypeAttr): Added static attributes when class is static.
5556 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
5557 (MemberBase): In some cases we need to call parent container for partial
5558 class. It should be eliminated but it's not easy now.
5560 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
5562 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
5563 partial classed to accumulate class comments.
5564 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
5566 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
5568 * driver.cs (MainDriver): Tree.GetDecl was removed.
5570 * modifiers.cs (Modifiers): Add partial modifier.
5572 * tree.cs (Tree.decl): Removed.
5573 (RootTypes): Started to use this class more often for root types
5576 2006-02-22 Marek Safar <marek.safar@seznam.cz>
5580 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
5581 external interface does not have an attribute.
5583 2006-02-22 Marek Safar <marek.safar@seznam.cz>
5585 Another prerequisites for new partial classs implementation.
5587 * attribute.cs (Attribute.Equal): Implemented.
5588 (Attribute.Emit): Changed as attributes can be applied more than twice.
5589 (Attributes.Emit): Check for duplicate attributes here.
5591 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
5592 as a parameter, clean-up.
5594 2006-02-11 Marek Safar <marek.safar@seznam.cz>
5598 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
5599 contains obsolete attribute check which can in some cases look for base
5600 type of current class which is not initialized yet.
5601 (TypeContainer.BaseType): Replacement of ptype.
5603 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
5605 2006-02-11 Marek Safar <marek.safar@seznam.cz>
5607 First of prerequisites for new partial classs implemention.
5609 * attribute.cs (Attributable): Extended by ResolveContext;
5610 Attributes finally have correct context for resolving in all cases.
5611 (AttachTo): Attribute owner is assigned here.
5613 * codegen.cs (IResolveContext): Introduce new interface to hold
5614 all information needed in resolving phase.
5615 (EmitContext): Implements IResolveContext; more clean-up needed here.
5617 * decl.cs (MemberCore): Implemented IResolveContext.
5619 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
5620 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
5621 parameter.cs, statement.cs, tree.cs, typemanager.cs:
5622 Refactored to use new IResolveContext instead of EmitContext; cleanup
5624 2006-02-06 Miguel de Icaza <miguel@novell.com>
5626 * codegen.cs (EmitScopeInitFromBlock): check here the
5627 capture_context, there is no need to make two calls to the
5630 * anonymous.cs: Add some debugging messages that might help me
5631 track other instances of this problem in the future (the
5632 regression of test 467).
5634 * cs-parser.jay: track the variable block, as we need to initalize
5635 any captured variables declared in this block for the "catch"
5636 portion of the "Try" statement.
5638 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
5639 scope initialization for captured variables.
5641 Also, move the emit for the variables after the block location has
5644 2006-02-06 Marek Safar <marek.safar@seznam.cz>
5646 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
5648 2006-02-02 Miguel de Icaza <miguel@novell.com>
5650 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
5651 commit yesterday, the initialization for the roots is necessary.
5652 What is not necessary is the scope activation.
5654 2006-02-02 Raja R Harinath <rharinath@novell.com>
5656 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
5657 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
5659 (Argument.Resolve): Remove CS0206 checks.
5661 2006-02-01 Miguel de Icaza <miguel@novell.com>
5663 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
5664 scopes for all the roots, the scopes will now be emitted when the
5665 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
5667 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
5668 code. This reduces a lot of existing cruft.
5670 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
5671 that the ScopeInfo is generated as we enter the scope, not at the
5672 time of use, which is what we used to do before.
5674 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
5675 every time a Block is about to be emitted if we have a
5678 2006-02-01 Raja R Harinath <rharinath@novell.com>
5680 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
5682 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
5684 * typemanager.cs (cons_param_array_attribute): Make private.
5685 (Reset): Set it to null.
5686 (InitCoreHelpers): Don't initialize it.
5687 (ConsParamArrayAttribute): New. Initialize it as needed.
5688 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
5690 2006-01-31 Miguel de Icaza <miguel@novell.com>
5692 * expression.cs: There might be errors reported during the
5693 selection of applicable methods. If there are errors, do not
5694 continue execution as it will lead the compiler to crash.
5696 2006-01-30 Miguel de Icaza <miguel@novell.com>
5698 * expression.cs: Member access is not allowed on anonymous
5699 methods. Fixes #77402.
5701 2006-01-30 Raja R Harinath <rharinath@novell.com>
5704 * cs-parser.jay (VariableDeclaration): Don't set
5705 current_array_type to null.
5706 (field_declaration, event_declaration, declaration_statement):
5707 Set it to null here.
5709 2006-01-28 Raja R Harinath <harinath@gmail.com>
5711 * typemanager.cs (GenericParameterPosition): New.
5714 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
5716 * doc.cs : To process "include" elements, first we should create
5717 another list than XmlNodeList, because it could result in node
5718 removal, which could result in that the XmlNodeList gives up
5721 (Also made code identical to gmcs again.)
5723 2006-01-25 Miguel de Icaza <miguel@novell.com>
5725 * ecore.cs: Introduce an error report that we were not catching
5726 before, if not silent, we must report the error. Gonzalo ran into
5729 2006-01-23 Miguel de Icaza <miguel@novell.com>
5731 A fix for bug: #76957
5733 * iterators.cs (MoveNextMethod.CreateMethodHost): call
5734 ComputeMethodHost before creating the method, this is a new
5737 * anonymous.cs (AnonymousContainer): Now we track all the scopes
5738 that this method references (RegisterScope). The actual scope
5739 where the method is hosted is computed with the ComputeMethodHost
5740 before we create the method.
5742 Moved the Deepest routine here.
5744 (AnonymousContainer.ComputeMethodHost): New routine used to
5745 compute the proper ScopeInfo that will host the anonymous method.
5747 (ScopeInfo): Deal with multiple roots. The problem was that we
5748 did not have a unique root where all ScopeInfos could be hanged
5749 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
5752 Remove AdjustMethodScope which is now computed at the end. Remove
5753 LinkScope which did a partial link, instead link all ScopeInfos
5754 before code generation from the new "LinkScopes" routine.
5756 Simplify all the Add* routines as they no longer need to maintain
5757 the tree, they just need to record that they are using variables
5760 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
5761 routines to produce the forest of ScopeInfo trees.
5763 * class.cs (TypeContainer.AppendMethod): This is just like
5764 AddMethod, but ensures that an interface implementation method
5765 (IEnumerable.XXX) is not inserted at the beginning of the queue of
5766 methods, but at the end.
5768 We use this functionality to ensure that the generated MoveNext
5769 method in the iterator class is resolved/emitted before the
5770 enumerator methods created.
5772 This is required because the MoveNext method computes the right
5773 ScopeInfo for the method. And the other methods will eventually
5774 need to resolve and fetch information computed from the anonymous
5777 2006-01-21 Raja R Harinath <harinath@gmail.com>
5778 Carlos Alberto Cortez <calberto.cortez@gmail.com>
5781 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
5783 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
5784 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
5786 2006-01-18 Raja R Harinath <rharinath@novell.com>
5788 Fix #76656, cs0231-2.cs.
5789 * cs-parser.jay (formal_parameter_list): Make error case catch
5791 (parenthesized_expression_0): Add CS1026 check.
5792 (invocation_expression): Remove unused { $$ = lexer.Location }.
5794 2006-01-17 Raja R Harinath <rharinath@novell.com>
5797 * cs-parser.jay (statement_expression): Don't list out the
5798 individual statement-expressions. Convert syntax error into
5801 2006-01-16 Raja R Harinath <rharinath@novell.com>
5804 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
5805 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
5806 CheckIntermediateModification.
5807 (FieldExpr.DoResolve): Add new two-argument version that
5808 allows us to resolve the InstanceExpression as an lvalue.
5809 The one-argument variant is now just a wrapper.
5810 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
5811 Resolve the lhs as an lvalue if the it has a value type.
5812 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
5813 from Assign.DoResolve.
5814 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
5815 resolved as an lvalue.
5816 (PropertyExpr.DoResolve): Update.
5817 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
5818 has a value type. Move CS1612 check here from
5819 CheckIntermediateModification.
5820 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
5821 * expression.cs (EmptyExpression.OutAccess): New. Used as the
5822 'right_side' of a ResolveLValue on an 'out' argument.
5823 (EmptyExpression.LValueMemberAccess): New. Used as the
5824 'right_side' of a propagated ResolveLValue on a value type.
5825 (LocalVariableReference.DoResolveBase): Recognize
5826 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
5828 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
5829 EmptyExpression.Null.
5831 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
5833 * typemanager.cs : added IsGenericParameter(). In mcs it always
5835 * doc.cs : for generic parameters, use GenericParameterPosition,
5838 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
5840 * expression.cs: Fix Console.WriteLine ((this = x).foo);
5842 2006-01-12 Miguel de Icaza <miguel@novell.com>
5844 This fixes the problem where we used ldfld instead of ldflda to
5845 load the "THIS" pointer on captured parameters, when THIS is a
5846 value type. See bug #77205.
5848 * iterators.cs (CapturedThisReference.Emit): Pass false to
5849 EmitThis (we do not need the address).
5851 * codegen.cs (EmitThis): it needs to know whether we need the
5852 address of `this' or not. This is used by value types.
5854 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
5855 every other call passes false.
5857 2006-01-12 Raja R Harinath <rharinath@novell.com>
5860 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
5862 * expression.cs (Invocation.OverloadResolve): Update.
5863 (Invocation.DoResolve): Avoid double resolution of invocation.
5865 2006-01-11 Raja R Harinath <rharinath@novell.com>
5868 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
5869 unary negation of floating point types as 0-expr; negation cannot
5870 overflow in floating point types.
5873 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
5874 on operands of 'void' type.
5877 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
5878 and ExclusiveOr for boolean constants too.
5880 2006-01-09 Raja R Harinath <rharinath@novell.com>
5883 * expression.cs (Invocation.OverloadResolve): Replace reflected
5884 override methods with their base virtual methods, rather than
5886 * typemanager.cs (TypeManager.GetOverride): New.
5888 2006-01-05 Jb Evain <jbevain@gmail.com>
5890 * class.cs (Property.Define, Indexer.Define): do not tag the
5891 properties as SpecialName | RTSpecialName.
5893 2006-01-04 Miguel de Icaza <miguel@novell.com>
5895 * class.cs (MethodCore.IsDuplicateImplementation): This method was
5896 doing a low-level comparission of parameter types. It was lacking
5897 a check for __argslist.
5899 2005-12-30 Miguel de Icaza <miguel@novell.com>
5901 * expression.cs (ParameterReference.DoResolveBase): Allow
5902 reference parameters if they are local to this block.
5904 This allows the ref and out parameters of a delegate to be used in
5905 an anonymous method, for example:
5907 delegate void set (out int x);
5909 set s = delegate (out int x){
5913 This is used by functionality introduced late in the C# language.
5915 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
5916 method that take ref and out parameters.
5918 Fixes #77119 which was a late change in the spec.
5920 2005-12-23 Miguel de Icaza <miguel@novell.com>
5922 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
5923 parent if its the same scope. Fixes #77060.
5925 2005-12-21 Miguel de Icaza <miguel@novell.com>
5927 * driver.cs: Report the case of no source files and no -out:
5930 2005-12-20 Raja R Harinath <rharinath@novell.com>
5933 * expression.cs (ComposedCast.GetSignatureForError): Define.
5935 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
5939 * namespace.cs (NamespaceEntry): Add extern_aliases as a
5940 ListDictionary, to contain the ExternAliasEntry entries (in
5941 addition to the NamespaceEntry.aliases hashtable). This field is
5942 shared between the original entry and its doppelganger (bodyless
5944 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
5945 extern_aliases field.
5946 (NamespaceEntry.Lookup): Move the IsImplicit check after the
5947 lookup in extern_aliases.
5949 2005-12-16 Raja R Harinath <rharinath@novell.com>
5952 * class.cs (TypeContainer.Mark_HasEquals): New.
5953 (TypeContainer.Mark_HasGetHashCode): New.
5954 (ClassPart): Override them.
5955 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
5958 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
5959 'parent' argument to the base constructor.
5961 Remove all mention of TypeContainer from decl.cs.
5962 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
5963 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
5964 (DeclSpace.DeclSpace): Likewise.
5965 (DeclSpace.DefineMembers): Remove unused argument.
5966 * cs-parser.jay (pop_current_class): Update to changes. Simplify
5967 debugging check -- we don't care if the debug code throws an
5968 InvalidCastException instead of an InternalErrorException.
5969 * class.cs (TypeContainer.DefineMembers): Update to changes.
5970 (TypeContainer.DoDefineMembers): Likewise.
5971 (TypeContainer.GetMethods): Likewise.
5972 (PropertyMember.Define): Likewise.
5973 (MemberBase.Parent): New property that forwards to
5974 MemberCore.Parent, but ensures that we get a TypeContainer.
5975 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
5976 (RootContext.PopulateTypes): Likewise. Remove special case code
5977 for !RootContext.StdLib: DefineMembers is idempotent.
5979 2005-12-14 Miguel de Icaza <miguel@novell.com>
5981 * convert.cs (ExplicitConversionCore): Check the return value from
5982 ExplicitConversionCore which can return null on failure. Fixes #76914
5984 2005-12-13 Marek Safar <marek.safar@seznam.cz>
5986 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
5988 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
5990 * doc.cs : The search for referenced namespace was insufficient to
5991 get global one as it used to do. Fixed bug #76965.
5993 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
5995 * doc.cs : check name in cref in the last phase that whether it is
5998 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6000 * cs-tokenizer.cs : reverted the latest change: it somehow broke
6003 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6005 * doc.cs : so it turned out that we cannot skip override check for
6006 interface members. Fixed bug #76954.
6008 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6010 * cs-tokenizer.cs : fixed bug #75984:
6011 - #warning and #error should not be handled when the source line
6013 - #line is not checked strictly when the source line is disabled.
6014 - #define and #undef is on the other hand checked strictly at any
6017 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
6019 * cs-tokenizer.cs : missing Location (actually, filename) in one of
6022 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6024 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
6026 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
6028 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
6029 (FieldBase.Initializer): Initializer is now optional.
6030 (EventField.Define): Only event field can have initializer.
6032 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
6034 * const.cs (Const): Reuse initializer.
6036 * cs-parser.jay: Updated after FieldBase changes.
6037 Added current_array_type to simplify array initializers.
6039 * ecore.cs (NullCast.IsDefaultValue): Implemented.
6041 * expression.cs, iterators.cs: Updated.
6043 * namespace.cs (NamespaceEntry): Made UsingFound private.
6045 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6047 * parameterCollection.cs: Obsolete, removed.
6048 * parser.cs: Obsolete, removed.
6050 2005-12-05 Marek Safar <marek.safar@seznam.cz>
6053 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
6055 * enum.cs (Enum.Define): Set obsolete context here.
6057 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6060 - FindDocumentedMember() now expects 1) paramList as null
6061 when "we don't have to check the number of parameters" and
6062 2) Type.EmptyTypes when "there is no arguments".
6063 - Introduced FoundMember struct to hold the exact type which was
6064 used to find the documented member (the above change broke
6065 test-xml-044; it might be better just to use DeclaringType than
6066 what MS does, like this change does, but it depends on usage.)
6068 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
6070 * doc.cs : documented member might be from DeclaringType for nested
6071 types. Fixed bug #76782.
6073 2005-12-03 Ben Maurer <bmaurer@ximian.com>
6075 * anonymous.cs: Have the param code handle leaving copies on the
6076 stack etc. Allows anonymous params to take part in the assignment
6077 code (++, +=, etc). Fixes bug #76550
6079 * expression.cs: Handle the prepare_for_load/leave_copy by passing
6080 it down to the anon code.
6082 * iterators.cs: Use dummy var here
6084 * codegen.cs: Handle new vars
6086 2005-12-01 Marek Safar <marek.safar@seznam.cz>
6089 * class.cs (MethodData.Define): Set proper Obsolete context.
6091 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
6093 (FieldExpr.DoResolve): Ditto.
6095 2005-12-01 Marek Safar <marek.safar@seznam.cz>
6098 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
6099 parent is not obsolete.
6101 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
6103 * doc.cs : (FindDocumentedMember) find parameterless members first
6104 and get CS0419 in the early stage. Fixed first case of bug #76727.
6106 2005-11-30 Marek Safar <marek.safar@seznam.cz>
6109 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
6110 no error was reported.
6112 *expression.cs (Binary.DoResolve): left can be null.
6114 2005-11-22 Marek Safar <marek.safar@seznam.cz>
6117 * class.cs (MethodData.Emit): Parameters should be labeled first.
6119 2005-11-21 Marek Safar <marek.safar@seznam.cz>
6122 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
6124 2005-11-18 Marek Safar <marek.safar@seznam.cz>
6126 * attribute.cs (AreParametersCompliant): Moved to Parameter.
6128 * class.cs (MethodCore): Parameter clean up.
6129 (IMethodData): Added ParameterInfo.
6130 (MethodData): Parameter clean up.
6131 (Indexer.Define): Parameter clean up.
6143 * typemanager.cs: Parameter clean up.
6145 * delegate.cs (Define): Get rid of duplicated code.
6147 * expression.cs (ParameterReference): Removed useless parameters
6149 (Invocation): Ditto.
6151 * parameter.cs (ParamsParameter): New class, params specialization.
6152 (ArglistParameter): Attemp to separate arglist.
6153 (Parameter): Refactored to be reusable and faster.
6154 (Parameter.Modifier): Made understandable.
6155 (Parameters): Changed to be used as a class for `this' assembly
6156 parameters. Refactored to use new specialized classes.
6158 * support.cs (ParameterData): Added Types property.
6159 (InternalParameters): Deleted.
6161 2005-08-20 Martin Baulig <martin@ximian.com>
6163 Merging this patch from GMCS to fix #75867.
6165 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
6166 scope if we don't already have it.
6168 2005-11-17 Martin Baulig <martin@ximian.com>
6171 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
6172 inherit the scope from our parent. Fixes #76653.
6174 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6176 * doc.cs : the previous patch does not actually fix the bug.
6177 PropertyInfo override check is now implemented and really fixed it.
6178 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
6180 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6182 * doc.cs : apply "override filter" also to properties.
6185 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
6187 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
6188 no need to check overrides. For classes, omit those results from
6189 interfaces since they must exist in the class. Fixed bug #76726.
6191 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6193 * typemanager.cs : (GetFullNameSignature) differentiate indexers
6194 with different parameters. Fixed the second problem in #76685.
6196 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6198 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
6199 get expected 'protected' access in CheckValidFamilyAccess()).
6202 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
6204 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
6205 Fixed bug #76705. CS1569 was incorrectly commented out.
6207 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6209 * doc.cs : use Invocation.IsOverride() to do real override check.
6210 * expression.cs : made Invocation.IsOverride() internal.
6212 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
6214 * doc.cs : use TypeManager.FindMembers() instead of (possible)
6215 TypeBuilder.FindMembers() and filter overriden base members out.
6218 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6220 * doc.cs : ref/out parameters are represented as '@' (instead of
6221 '&' in type FullName). Fixed bug #76630 (additionally crefs).
6223 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6225 * doc.cs : when there was no '.' in cref to methods in doc comment,
6226 then parameters were missing in the output. Fixed bug #76691.
6228 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6230 * driver.cs : don't output docs when there is an error.
6233 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6236 Now it should detect indexers. Fixed primary concern in bug #76685.
6237 Fixed CS0419 message to not show the identical member signature in
6240 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
6242 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
6243 instead of Type.FindMembers() since it does not handle events.
6246 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
6248 * codegen.cs: Fixed typo (speficied -> specified).
6250 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6253 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
6255 2005-11-11 Marek Safar <marek.safar@seznam.cz>
6257 * attribute.cs: Changed error message.
6259 * cs-tokenizer.cs: One more check.
6261 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6263 * statement.cs (Block.Resolve): Ignore empty statement.
6265 2005-11-10 Marek Safar <marek.safar@seznam.cz>
6267 * report.cs: Made error/warning methods more strict to avoid
6270 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
6271 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
6272 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
6273 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
6275 2005-11-08 Marek Safar <marek.safar@seznam.cz>
6277 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
6278 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
6280 * class.cs (TypeContainer.IsComImport): New property.
6281 (Constructor.Define): Create proper ctor for ComImport types.
6283 * expression.cs (New.CheckComImport): Fixed.
6285 2005-11-07 Miguel de Icaza <miguel@novell.com>
6287 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
6288 that a parameter has been captured does not mean that we do not
6289 have to do the rest of the processing. This fixes the second part
6290 of #76592. If there was another anonymous method capturing
6291 values in the past, the Scope would never be set for the second
6292 method that captured the same parameter.
6294 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
6295 properly manipulate the stack. Second part of fix for #76592.
6297 * expression.cs (New): Add support for invoking "new" on
6298 interfaces that have been flagged with the ComImport attribute and
6299 the CoClass. Fixes #76637
6301 * statement.cs (Try.DoEmit): When a variable is captured, do not
6302 try to emit the vi.LocalBuilder variable as it has been captured.
6303 Create a temporary variable and store the results on the
6304 FieldBuilder. Fixes #76642
6306 2005-11-07 Marek Safar <marek.safar@seznam.cz>
6308 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
6310 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
6312 * expression.cs (Binary.DoResolve): Added && optimalization.
6314 * typemanager.cs (AddUserType): Removed useless argument.
6316 2005-11-04 Marek Safar <marek.safar@seznam.cz>
6318 * statement.cs (Block.variables): Uses ListDictionary.
6320 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6323 * class.cs (PartialContainer.EmitType): Customized to emit
6324 security attributes.
6325 (ClassPart.ApplyAttributeBuilder): Transform security attribute
6326 for partial classes.
6328 2005-11-03 Marek Safar <marek.safar@seznam.cz>
6331 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
6332 access has to be fixed.
6334 * typemanager.cs (IsUnmanagedType): Wrong common field type.
6336 2005-11-01 Marek Safar <marek.safar@seznam.cz>
6339 * ecore.cs (NullCast.Reduce): Implemented.
6341 * expression.cs (ArrayCreation.CheckIndices): Correcly check
6344 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
6346 (Foreach.Resolve): Catch null properly.
6348 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6350 * cs-tokenizer.cs: Warning text fix.
6352 * driver.cs: AllWarningNumbers exposed on public interface.
6354 * report.cs (): Reviewed warning numbers.
6355 (IsValidWarning): Use binary search.
6357 2005-10-29 Marek Safar <marek.safar@seznam.cz>
6359 * driver.cs: Implemeted resource visibility.
6360 (Resources): New class for code sharing between /res: and
6363 2005-10-28 Marek Safar <marek.safar@seznam.cz>
6366 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
6369 * convert (Convert.ImplicitReferenceConversion): NullCast holds
6372 * ecore.cs (NullCast): Child is contant only.
6374 * literal.cs (NullLiteral.Reduce): null can be converted to any
6377 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
6379 * driver.cs: Use Encoding.Default as default code page instead
6382 2005-10-27 Raja R Harinath <rharinath@novell.com>
6385 * expression.cs (Invocation.Error_InvalidArguments): Handle
6386 __arglist parameters.
6387 (Invocation.VerifyArgumentsCompat): Likewise.
6388 * support.cs (ReflectionParameters.GetSignatureForError): Print
6389 __arglist parameters.
6390 (InternalParamters.GetSignatureForError): Likewise.
6391 * parameter.cs (Parameters.GetSignatureForError): Likewise.
6393 2005-10-26 Marek Safar <marek.safar@seznam.cz>
6395 * attribute.cs (GetPropertyValue): Made public.
6397 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
6399 Add new property WrapNonExceptionThrows to handle 2.0 assembly
6401 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
6404 * driver.cs: Reflect method name change.
6406 * statement.cs (Try.Resolve): Warn when try has both general
6409 * typemanager.cs: runtime_compatibility_attr_type new predefined
6412 2005-10-26 Raja R Harinath <harinath@gmail.com>
6415 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
6416 treat it as an empty parameter list.
6418 2005-10-26 Raja R Harinath <rharinath@novell.com>
6421 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
6422 ResolveAsTypeStep silent.
6423 * statement.cs (Block.AddConstant): Mark block as used.
6424 (Block.ResolveMeta): Avoid piling on error messages
6425 if a constant initializer resolution fails.
6427 2005-10-25 Raja R Harinath <rharinath@novell.com>
6429 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
6431 (NamespaceEntry.VerifyAllUsing): New.
6432 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
6433 behaviour. Delegates actual resolution of alias to ...
6434 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
6435 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
6437 * driver.cs (Driver.MainDriver): Update.
6439 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
6440 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
6442 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
6444 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
6445 RootNamespace.DefineNamespacesForAll.
6447 2005-10-24 Raja R Harinath <harinath@gmail.com>
6449 * typemanager.cs (assemblies, external_aliases, modules)
6450 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
6451 (ComputeNamespaces, GetRootNamespace): Remove extra staging
6452 overhead. Move resposibility ...
6453 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
6454 * driver.cs, attribute.cs, codegen.cs: Update to changes.
6456 2005-10-23 Raja R Harinath <harinath@gmail.com>
6458 * namespace.cs (RootNamespace.all_namespaces): Renamed from
6459 cached_namespaces. Improve usage.
6460 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
6461 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
6462 Move from GlobalRootNamespace and simplify.
6463 (RootNamespace.Global): Make instance variable.
6464 (RootNamespace.RootNamespace): Add "alias name" parameter.
6465 (GlobalRootNamespace): Simplify drastically.
6466 (Namespace.Lookup): Don't use GetNamespace.
6467 * typemanager.cs (GetRootNamespace): Rename from
6468 ComputeNamespaceForAlias.
6469 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
6471 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6473 * anonymous.cs (AnonymousContainer): Don't crash when container
6476 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6478 * expression.cs (Binary.DoResolve): Warn when comparing same
6481 2005-10-23 Marek Safar <marek.safar@seznam.cz>
6484 * expression.cs (Binary.DoResolve): It looks like there are no
6485 convetsion rules in enum context.
6487 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6489 Add support for extern alias qualifiers.
6490 * typemanager.cs: Move some LookupTypeReflection code
6491 to namespace.cs, to have cleaner code. Added some methods
6492 to help us keep track of the extern aliased references.
6493 * driver.cs: Add suport for extern alias assemblies on command
6494 line and check for their warnings/errors. Also keep track of the
6495 extern aliased assemblies.
6496 * namespace.cs: Move the global functionality of Namespace
6497 to GlobalRootNamespace/RootNamespace. Now the global namespace
6498 is GlobalRootNamespace.Globa. Also the code moved from
6499 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
6500 Finally added LocalAliasEntry (AliasEntry before) and
6501 ExternAliasEntry, to handle alias statements.
6502 * cs-parser.jay: Add support in the grammar for extern alias
6504 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
6505 Update callings to Namespace (now in GlobalRootNamespace).
6507 2005-10-18 Raja R Harinath <rharinath@novell.com>
6510 * class.cs (TypeContainer.DefineType): Move updating of
6511 topological sort earlier in the code.
6512 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
6514 2005-10-18 Marek Safar <marek.safar@seznam.cz>
6517 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
6519 * constant.cs (Constant.TryReduce): Moved from Cast class.
6520 (Reduce): Made little bit more OO and fixed missing conversions.
6522 * ecore.cs (Reduce): Implemented.
6523 (Binary.EnumLiftUp): New method to upgrade values to enum values.
6525 * literal.cs (Reduce): Implemented.
6527 * class.cs: Reverted Miguel's wrong commit.
6529 2005-10-14 Miguel de Icaza <miguel@novell.com>
6531 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
6533 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
6535 * cs-parser.jay, expression.cs : CS0214 was missing error location
6536 for constants. Fixed bug #76404.
6538 2005-10-11 Marek Safar <marek.safar@seznam.cz>
6541 * convert.cs (ExplicitConversionCore): Fixed object->enum
6544 2005-10-10 Raja R Harinath <rharinath@novell.com>
6546 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
6548 (PropertyExpr.EmitCall): Likewise.
6549 * expression.cs (Invocation.EmitArguments): Handle case where
6551 (Invocation.EmitCall): Avoid allocating temporary variable if
6552 there are no arguments.
6554 2005-10-07 Raja R Harinath <rharinath@novell.com>
6557 * convert.cs (ImplicitConversionStandard): Move conversion of
6558 void* to arbitrary pointer types ...
6559 (ExplicitConversionStandard): .. here.
6560 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
6561 error to always print typenames.
6563 2005-10-07 Raja R Harinath <rharinath@novell.com>
6565 * convert.cs (GetConversionOperator): Rename from
6566 GetConversionOperators. Move operator selection code from ...
6567 (UserDefinedConversion): ... here.
6569 2005-10-06 Marek Safar <marek.safar@seznam.cz>
6571 * convert.cs (ExplicitConversionCore): Removed duplicate enum
6574 2005-10-05 Marek Safar <marek.safar@seznam.cz>
6576 * assign.cs (Assign.DoResolve): Error method changed.
6578 * cfold.cs (DoConstantNumericPromotions): Error method changed.
6580 * const.cs (ResolveValue): Reset in_transit immediately.
6582 * constant.cs: Error method changed.
6584 * convert.cs: Removed useless location parameter.
6585 (ExplicitNumericConversion): Don't do double enum check.
6586 (ExplicitConversionCore): Renamed from ExplicitConversion.
6587 (ExplicitUnsafe): Extracted from ExplicitConversion.
6588 (ExplicitConversion): Uses for error reporting.
6590 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
6592 (ResolveBoolean): Uses common error method.
6593 (CastToDecimal): Get rid of ec.
6594 (CastFromDecimal): Optimized.
6595 (ConvCast): Get rid of ec.
6597 * enum.cs (ResolveValue): Reset in_transit immediately.
6598 (Emit): Return after first error.
6600 * expression.cs: Convert changes.
6602 * literal.cs: Error method changed.
6604 * statement.cs: Error method changed.
6606 2005-10-03 Raja R Harinath <rharinath@novell.com>
6608 * support.cs (SeekableStreamReader.Position): Don't error out when
6609 the requested position is just beyond the end of the current
6612 2005-09-28 Raja R Harinath <rharinath@novell.com>
6614 * support.cs (SeekableStreamReader): Simplify drastically. Don't
6615 try to keep in sync with the byte count of the underlying Stream.
6616 However, this limits us to a window size of 2048 characters: i.e.,
6617 the maximum lookahead of our lexer/parser can be 2048 characters.
6619 2005-09-28 Marek Safar <marek.safar@seznam.cz>
6622 * driver.cs: Fix compilation files with full root path.
6624 2005-09-25 Miguel de Icaza <miguel@novell.com>
6626 * report.cs (SymbolRelatedToPreviousError): Format the output so
6627 it does not use an open parenthesis that is never closed.
6629 * driver.cs: Follow coding guidelines
6631 2005-09-27 Marek Safar <marek.safar@seznam.cz>
6634 * const.cs (Const.ResolveValue): Check for assigning non-null
6635 value to reference type.
6637 2005-09-27 Marek Safar <marek.safar@seznam.cz>
6639 * anonymous.cs: Implemented ExprClassName.
6641 * assign.cs (Assign.DoResolve): Don't chrash when type is not
6644 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
6647 * class.cs (StaticClass.DefineContainerMembers): Report protected
6650 * codegen.cs: if(ed) PRODUCTION.
6652 * convert.cs (Error_CannotImplicitConversion): Better error
6655 * cs-parser.jay: More error checks.
6657 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
6659 * driver.cs (CSCParseOption): Enabled wrong option check.
6661 * ecore.cs (Expression.ExprClassName): Turned to property.
6662 (MemberExpr.CheckIntermediateModification): For checking boxed
6663 value types modification.
6665 * statement.cs (Fixed.Resolve): Expression type must be
6666 convertible to fixed type.
6667 (CollectionForeach.GetEnumeratorFilter,TryType):
6668 Small refactoring for easier error checking.
6670 2005-09-26 Marek Safar <marek.safar@seznam.cz>
6672 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
6675 * class.cs (GeneratedBaseInitializer): New class for customization
6676 compiler generated initializers.
6677 (MemberBase.DoDefine): Check Obsolete attribute here.
6678 (FieldMember.DoDefine): Ditto.
6680 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
6683 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
6684 (MemberCore.GetObsoleteAttribute): Removed argument.
6685 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
6686 (MemberCore.CheckObsoleteType): New helper.
6690 * statement.cs: Updates after MemberCore changes.
6692 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
6693 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
6695 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
6696 obsolete attribute for compiler construct.
6697 (As.DoResolve): Cache result.
6699 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
6701 2005-09-26 Raja R Harinath <rharinath@novell.com>
6704 * expression.cs (This.VerifyFixed): In a value type T, the type of
6705 'this' is T&, iow, 'this' is either an out or ref parameter. In a
6706 value type R, 'this' is treated as a value parameter.
6708 2005-09-22 Miguel de Icaza <miguel@novell.com>
6710 * statement.cs (Lock): Use the TemporaryVariable class instead of
6711 manually using local variables as those do not work when variables
6714 * ecore.cs: Moved the TemporaryVariable class from being a nested
6715 class inside Foreach to be a public class that can be employed in
6718 2005-09-19 Marek Safar <marek.safar@seznam.cz>
6720 * cs-parser.jay: interface_accessors replaced by
6721 accessor_declarations.
6723 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
6726 * statement.cs (GotoCase.Resolve): Convert null constant to
6728 (SwitchLabel.ResolveAndReduce): Ditto.
6729 (SwitchLabel.NullStringCase): Custom null stamp.
6730 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
6732 typemanager.cs (CSharpSignature): Don't skip first argument
6735 2005-09-18 Miguel de Icaza <miguel@novell.com>
6737 * driver.cs: Set InEmacs based on the environment variable EMACS.
6739 * location.cs (InEmacs): in this mode, do not report column
6740 location as it confuses Emacs.
6742 2005-09-16 Marek Safar <marek.safar@seznam.cz>
6744 * cfold.cs, constant.cs, convert.cs, ecore.cs,
6745 expression.cs, iterators.cs, literal.cs: Store constants and
6748 * class.cs (MemberBase.ShortName): Pass location.
6750 * cs-parser.jay: Some location fixes.
6752 * ecore.cs (Expression.Location): Made virtual.
6754 2005-09-05 Miguel de Icaza <miguel@novell.com>
6756 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
6757 if the underlying types are the same, otherwise we need to produce
6758 code that will do the proper cast.
6760 This was exposed by Marek's constant rewrite which produced
6761 invalid code for the call site:
6764 void Method (X v) {}
6768 This fixes test-49.cs
6770 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
6772 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
6773 Type/Object should be allowed as well. Fixed bug #75968.
6775 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
6777 * expression.cs : (Binary.DoResolve): when one is enum constant and
6778 another is constant 0, then return enum one *as enum type*.
6781 2005-09-02 Raja R Harinath <rharinath@novell.com>
6783 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
6787 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
6788 flow-branching for LocalVariableReferences in case we were invoked
6789 from a MemberAccess.
6790 * expression.cs (LocalVariableReference.VerifyAssigned): New.
6792 (LocalVariableReference.DoResolveBase): ... this.
6793 (MemberAccess.Resolve): Do the check that was disabled during
6796 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
6799 (PartialContainer.Create): check abstract/sealed/static strictly
6800 but abstract/sealed can exist only at one side. Fixed bug #75883.
6802 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
6805 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
6806 specified, don't default to UnmanagedType.I4.
6808 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
6810 * expression.cs : conditional operator should check possibly
6811 incorrect assign expression. Fixed bug #75946.
6813 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
6815 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
6816 Reverting the change. gmcs is much complex than mcs on this matter.
6818 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
6820 * cs-tokenizer.cs : To read another token ahead of the actual
6821 consumption, use new SavedToken and cache token instead of moving
6822 back the stream with SeekableStreamReader (it seemed problematic).
6824 driver.cs : Thus use StreamReader directly.
6825 * support.cs : Thus removed SeekableStreamReader.
6827 2005-08-30 Raja R Harinath <rharinath@novell.com>
6830 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
6831 (ScopeInfo.EmitScopeType): Use it to construct field names from
6832 names of captured locals.
6835 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
6836 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
6837 Pass 'target_type' to BoxedCast. Don't default to 'object'.
6838 (ExplicitConversion): Remove enum cases already handled by
6839 implicit conversion. Move implicit conversion check to the beginning.
6840 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
6841 * expression.cs (ArrayCreation.EmitDynamicInitializers):
6842 Don't treat System.Enum as a struct.
6844 2005-08-30 Jb Evain <jbevain@gmail.com>
6846 * attribute.cs: handles as expression in parameters.
6848 2005-08-30 Raja R Harinath <rharinath@novell.com>
6851 * class.cs (TypeContainer.VerifyClsName): Don't use a
6852 PartialContainer when verifying CLS compliance.
6853 (AbstractPropertyEventMethod): Set Parent here, ...
6854 (PropertyMethod): ... not here.
6856 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
6858 * attribute.cs : escaped attribute name should not be allowed to be
6859 resolved (e.g. @class as classAttribute). Fixed bug #75930.
6861 2005-08-29 Raja R Harinath <rharinath@novell.com>
6864 * convert.cs (ImplicitStandardConversionExists): Allow zero also
6865 when converting a long constant to unsigned long.
6866 * expression.cs (Invocation.OverloadResolve): Add sanity check to
6867 detect where IsApplicable and VerifyArgumentsCompat disagree.
6869 2005-08-29 Raja R Harinath <rharinath@novell.com>
6870 and Carlos Alberto Cortez <carlos@unixmexico.org>
6873 * class.cs (TypeContainer.CanElideInitializer): New helper.
6874 (TypeContainer.EmitFieldInitializers): Use it to determine if we
6875 can safely emitting the initializer of a field.
6877 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6879 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
6880 allowed inside a switch (without loop). Fixed bug #75433.
6882 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
6884 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
6885 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
6887 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6889 * driver.cs : kinda reverting the default encoding changes (not exact
6890 revert since I noticed that "codepage:reset" might not work fine).
6892 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6894 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
6895 Location. Now getter and setter store location correctly.
6896 (errors/cs0111-12.cs now reports the expected location.)
6898 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
6900 * driver.cs : Use default encoding on the environment.
6901 Removed (now that) extra parameter for SeekableStreamReader.
6902 * support.cs : (SeekableStreamReader) third .ctor() argument for
6903 StreamReader is not required (always true). preamble size could
6904 be acquired in simpler and safe way.
6906 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
6908 * cs-parser.jay: report CS0642 at warning level 3
6909 and report CS0642 for an if else statement also
6910 fixes bug #74745. Patch by John Luke (and a bit
6912 Removed extra CS0642 warning check for "while",
6914 * statement.cs: In Block.Resolve(), CS0642 check
6915 is reimplemented to check a sequence of an empty
6916 statement and a block.
6918 Both fix bug #66777.
6920 2005-08-24 Marek Safar <marek.safar@seznam.cz>
6922 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
6923 detection until I fix it.
6925 * cs-tokenizer.cs: Changed error message.
6927 * cs-parser.jay: Fixed 2 error locations.
6929 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
6930 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
6933 * enum.cs (GetSignatureForError): Fixed.
6935 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
6939 * typemanager.cs (RegisterProperty): Removed.
6941 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
6943 2005-08-24 Raja R Harinath <rharinath@novell.com>
6946 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
6947 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
6949 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
6951 * expression.cs : tiny fix is required for not warning positive ulong.
6954 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
6956 * expression.cs : add CS0652 check for constant and integral
6957 expression. Fixed bug #53974.
6959 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
6961 * expression.cs : in DoNumericPromotions(), check if there is implicit
6962 conversion overload for string (to check CS0034). Fixed bug #52492.
6964 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
6966 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
6968 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
6970 * ecore.cs : report location when it is *not* Null.
6972 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
6978 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
6979 correctly. Fixed bug #75721.
6981 2005-08-23 Raja R Harinath <rharinath@novell.com>
6983 * support.cs (SeekableStreamReader.Position): Avoid an expensive
6984 loop that performs 'min (pos, char_count)'.
6987 * expression.cs (Unary.ResolveOperator): Don't discard implicit
6988 converted value in Operator.OnesComplement.
6990 2005-08-22 Ben Maurer <bmaurer@ximian.com>
6992 * anonymous.cs: If the anon method is pulled into a helper class,
6993 it needs to be `internal' not `private'. Fixes runtime behavior on
6996 2005-08-20 Martin Baulig <martin@ximian.com>
6998 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
6999 scope if we don't already have it.
7001 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
7002 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
7005 2005-08-17 Marek Safar <marek.safar@seznam.cz>
7008 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
7011 2005-08-16 Marek Safar <marek.safar@seznam.cz>
7013 The big constants rewrite
7014 Fix #75746, #75685 and more
7015 As a side effect saved 1MB for MWF ;-)
7017 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
7018 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
7019 enum based for corlib compilation.
7021 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
7024 * class.cs (FixedField.Define): Use ResolveAsConstant.
7026 * const.cs (IConstant): Interface constants and enums.
7027 (Const.ResolveValue): New method for constant resolvning.
7028 (ExternalConstant): Constants from imported assemblies.
7030 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
7031 conversion; like enums.
7032 (Constant.ToType): Converts this constant to different type.
7033 (Constant.Increment): Adds 1.
7035 * convert.cs (ImplicitConversionRequired): Simplified.
7037 * cs-parser.jay: Create EnumMember directly.
7039 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
7041 * doc.cs (GenerateEnumDocComment): Removed.
7043 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
7044 (ConvertIntLiteral): Removed.
7045 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
7047 * enum.cs (EnumMember): Implement IConstant.
7048 (Enum.IsValidEnumConstant): Removed.
7049 (Enum.GetNextDefaultValue): Removed.
7050 (Enum.FindMembers): Updated.
7051 (Enum.GenerateDocComment): Iterate enum members.
7053 * expression.cs (Cast.TryReduce): Handle enums correctly.
7054 (New.Constantify): Made public.
7055 (MemberAccess.DoResolve): Removed contant specific if(s).
7057 * literal.cs (NullLiteral): Implement new abstract methods.
7059 * statement.cs (GotoCase.Resolve): Use new constant methods.
7060 (SwitchLabel.ResolveAndReduce): Use new constant methods.
7062 * typemanager.cs (LookupEnum): Removed.
7063 (IsEnumType): Fixed to work with corlib.
7064 (RegisterConstant): Removed.
7065 (LookupConstant): Removed.
7066 (GetConstant): Changed to work with IConstant.
7068 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
7070 * location.cs : Fixed overflown (>255) column number.
7072 2005-08-03 Raja R Harinath <rharinath@novell.com>
7074 First cut of the qualified-alias-member feature.
7075 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
7077 * cs-parser.jay (DOUBLE_COLON): New token.
7078 (namespace_or_type_name): Add rule for recognizing
7079 qualified-alias-members.
7080 (primary_expression): Likewise.
7081 (element_access): Allow QualifiedAliasMember as a possible
7082 type-bearing expression.
7083 (local_variable_type, local_variable_pointer_type): Likewise.
7084 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
7085 aliases in the current and enclosing namespace declarations.
7086 (NamespaceEntry.UsingAlias): Add CS0440 warning.
7087 * decl.cs (MemberName.is_double_colon): New.
7088 (MemberName.MemberName): Add new constructor for alias-member.
7089 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
7090 * expression.cs (QualifiedAliasMember): New expression type.
7092 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7094 * location.cs : it borked when no argument was specified.
7096 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7098 * location.cs : tiny ToString() format fix.
7100 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7102 * statement.cs : oops, it was missing.
7104 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
7106 A set of fixes for precise line/column location.
7109 "token" field now holds a file/line "delta", a line number offset
7110 from the segment, and a column number. See also:
7111 http://lists.ximian.com/pipermail/mono-devel-list/2004-
7112 December/009508.html
7113 Removed static IsNull. Use instance IsNull property instead.
7115 For some tokens it stores Location. For Identifier it stores
7116 LocatedToken which is a pair of string name and location.
7117 Column numbers are adjusted only at getChar().
7119 Use Location.ToString() for reporting (it now contains column).
7121 Largely modified to use LocatedToken instead of
7122 string (IDENTIFIER), and to acquire Location from some tokens.
7123 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
7124 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
7126 Now MemberName holds Location. DeclSpace.ctor() receives Location
7127 as a parameter. Removed extra parameters to all derived classes.
7128 Replaced Location.IsNull() with instance property.
7129 * assign.cs, expression.cs :
7130 Added .ctor() overload that omits Location.
7132 Added "nameEscaped" flag that indicates the identifier was escaped
7133 in the source file. This fixes bug #57047.
7135 2005-08-02 Marek Safar <marek.safar@seznam.cz>
7137 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
7138 New method, looking for lo-case imported cls type.
7140 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
7143 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
7145 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
7147 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
7149 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
7151 Optimized to save 3.5 MB for SWF compilation.
7153 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7155 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
7156 (PartialContainer.Create): Moved logic AddToContainer.
7157 (PartialContainer.MarkForDuplicationCheck): Shares name.
7159 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
7162 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
7164 (Namespace.GetSignatureForError): New method.
7166 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
7167 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
7169 2005-08-01 Raja R Harinath <rharinath@novell.com>
7172 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
7173 member lookup rather than qualifier_type, since qualifier_type can
7176 2005-08-01 Marek Safar <marek.safar@seznam.cz>
7178 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
7181 2005-07-31 Miguel de Icaza <miguel@novell.com>
7183 * statement.cs: Copy the local exception into the exception
7184 captured local. Fixes 75674
7186 2005-07-31 Raja R Harinath <harinath@gmail.com>
7189 * expression.cs (Invocation.OverloadResolve): Don't report error
7190 CS1501 if error CS1502 has been reported.
7191 (New.DoResolve): Delegate CS1501 reporting to
7192 Invocation.OverloadResolve.
7195 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
7196 invariant-meaning-in-block property in an enclosing block if
7199 2005-07-29 Marek Safar <marek.safar@seznam.cz>
7201 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
7202 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
7203 (Switch.CheckSwitch): Just save 50kb for SWF.
7205 2005-07-27 Martin Baulig <martin@ximian.com>
7207 * anonymous.cs (CaptureContext.AddField): Added
7208 `AnonymousContainer am' argument; compute its toplevel scope if
7209 it's not already computed. Fixes #75649.
7211 2005-07-26 Raja R Harinath <rharinath@novell.com>
7214 * class.cs (Constructor.Emit): Reset block to null if the block
7217 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7219 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
7221 2005-07-25 Marek Safar <marek.safar@seznam.cz>
7223 * class.cs (MethodData.Define): Check whether accessor implementing
7224 interface is public.
7226 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
7228 2005-07-22 Marek Safar <marek.safar@seznam.cz>
7231 * namespace.cs (LookupType): Moved same type check to...
7233 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
7236 2005-07-21 Raja R Harinath <rharinath@novell.com>
7238 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
7239 already found a typebuilder.
7240 * class.cs (MethodCore.IsDuplicateImplementation): Compare
7241 MemberNames, not strings.
7243 * const.cs (Error_ExpressionMustBeConst):
7244 Rename from Error_EpressionMustBeConst.
7245 * const.cs, class.cs, statement.cd: Update.
7247 2005-07-21 Marek Safar <marek.safar@seznam.cz>
7251 * const.cs (Const.LookupConstantValue): Report missing contant expression
7253 (Error_EpressionMustBeConstant): Only one error method.
7255 * class.cs, statement.c: Updated.
7257 2005-07-20 Raja R Harinath <rharinath@novell.com>
7259 * statement.cs (Block.Flags): Add back HasVarargs.
7260 (Block.flags): Make protected.
7261 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
7263 * typemanager.cs (types, typecontainers, user_types): Remove.
7264 (UserTypes, TypeContainers): Likewise.
7265 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
7266 (CleanUp, Reset): Update.
7267 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
7268 (GetNestedType): Use Type.GetNestedType.
7269 (CoreLookupType): Take two arguments, the namespace and the
7270 basename of the type. Update to use the Namespace.Lookup
7272 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
7273 (RealMemberLookup): Use IsNestedChildOf instead of playing with
7274 string concatenation and substring matches.
7275 * class.cs, enum.cs, delegate.cs: Update to changes.
7277 2005-07-20 Marek Safar <marek.safar@seznam.cz>
7279 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
7280 Expression and made virtual.
7282 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
7283 (ImplicitStandardConversionExists): Fixed `byte' typo ?
7285 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
7287 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
7290 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
7293 2005-07-18 Marek Safar <marek.safar@seznam.cz>
7296 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
7297 AssemblyCultureAttribute is not used on executable.
7300 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
7302 2005-07-16 Raja R Harinath <rharinath@novell.com>
7305 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
7306 New. Reports CS0252/CS0253.
7307 Mostly taken from preliminary patch by Duncak Mak.
7308 (Binary.DoResolveOperator): Store results of operator lookup.
7309 Use them to detect if we need to warn about unintended reference
7312 2005-07-15 Raja R Harinath <rharinath@novell.com>
7315 * namespace.cs (Namespace.Lookup): Add back location parameter.
7316 (Namespace.LookupType): Add CS0436 report. Add location parameter.
7317 * delegate.cs, ecore.cs, expression.cs: Update to changes.
7319 * codegen.cs (EmitContext.DeclSpace): Make readonly.
7320 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
7321 (Namespace.LookupType): ... this.
7322 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
7324 * typemanager.cs (LookupTypeReflection): Remove buggy code that
7325 purported to handle pointers.
7326 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
7329 2005-07-15 Marek Safar <marek.safar@seznam.cz>
7331 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
7334 2005-07-15 Raja R Harinath <rharinath@novell.com>
7336 * namespace.cs (Namespace.Lookup): Drop location parameter.
7337 (NamespaceEntry.LookupAlias): Remove. Merge into ...
7338 (NamespaceEntry.Lookup): ... this.
7339 (NamespaceEntry.Error_AmbiguousTypeReference):
7340 Move here from DeclSpace.
7341 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
7343 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
7344 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
7345 Move to NamespaceEntry.
7346 * delegate.cs, expression.cs: Update to changes.
7348 2005-07-14 Marek Safar <marek.safar@seznam.cz>
7350 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
7351 CheckAttributeType and refactored.
7352 (Attribute.ResolvePossibleAttributeType): Changed to reuse
7353 ResolveAsTypeTerminal error handling.
7354 (ResolveAsTypeTerminal): Introduced because of global attributes extra
7356 (GetSignatureForError): Print errors in same way.
7359 * codegen.cs: Reflect attribute GetSignatureForError change.
7362 * expression.cs: Add silent parameter to ResolveAsTypeStep.
7364 * namespace.cs (UsingEntry): Refactored to make fields private.
7367 statement.cs: Error_UnexpectedKind has extra parameter.
7369 2005-07-14 Raja R Harinath <rharinath@novell.com>
7371 * ecore.cs (IAlias): Remove.
7372 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
7373 that implement the interface.
7374 * namespace.cs (Namespace): Likewise.
7375 (Namespace.declspaces): Renamed from 'defined_names'.
7376 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
7377 DeclSpace instead of an IAlias.
7378 * tree.cs (Tree.AddDecl): Update.
7380 2005-07-12 Raja R Harinath <rharinath@novell.com>
7382 * statement.cs (Block.Flags); Remove HasVarargs.
7383 (Block.HasVarargs): Move to ToplevelBlock.
7384 (Block.ThisVariable, Block.AddThisVariable): Likewise.
7385 (Block.Variables): Make protected. Initialize variable hashtable
7387 (Block.AddVariable): Update.
7388 (Block.Resolve): Update to changes.
7389 (ToplevelBlock.HasVarargs): New boolean.
7390 (ToplevelBlock.ThisVariable): Move here from Block.
7391 (ToplevelBlock.AddThisVariable): Likewise.
7392 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
7393 * expression.cs (This.ResolveBase): Update to changes.
7394 (ArglistAccess.DoResolve): Likewise.
7396 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7399 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
7401 * class.cs (TypeContainer.VerifyMembers): Distinguish between
7402 not used and not used & assigned.
7403 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
7405 2005-07-11 Marek Safar <marek.safar@seznam.cz>
7408 * expression.cs (Is.DoResolve): null is never provided type.
7410 2005-07-08 Marek Safar <marek.safar@seznam.cz>
7413 * cs-parser.jay: Less strict event error rule to catch more errors.
7415 2005-07-08 Martin Baulig <martin@ximian.com>
7417 Fix test-iter-10.cs - distinguish whether we `yield' in a property
7418 gettter (allowed) or setter (not allowed).
7420 * class.cs (Accessor): Implement IIteratorContainer.
7421 (Accessor.Yields): New public field.
7422 (PropertyBase.PropertyMethod.Define): Handle iterators on a
7426 (get_accessor_declaration, set_accessor_declaration): Set the
7427 `yields' flag on the accessor, not the property.
7428 (property_declaration): Do the iterators check on a per-accessor
7429 basis and not for the whole property.
7431 2005-07-08 Martin Baulig <martin@ximian.com>
7433 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
7434 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
7436 2005-07-07 Marek Safar <marek.safar@seznam.cz>
7439 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
7440 (ExtractSecurityPermissionSet): Cope with self referencing security
7441 attributes properly.
7443 * driver.cs (SetOutputFile): Made public property OutputFile.
7445 2005-07-07 Raja R Harinath <rharinath@novell.com>
7448 * class.cs (TypeContainer.first_nonstatic_field): Rename from
7449 has_nonstatic_fields. Make into a FieldBase pointer.
7450 (TypeContainer.AddField): Add CS0282 check.
7451 (TypeContainer.EmitType): Update.
7453 2005-07-06 Miguel de Icaza <miguel@novell.com>
7455 * cs-tokenizer.cs (consume_identifier): Do not create strings to
7456 compare if they start with __.
7458 2005-07-06 Raja R Harinath <rharinath@novell.com>
7460 * statement.cs (Switch.SwitchGoverningType): Only look at
7461 UserCasts that don't need implicit standard conversions to one of
7462 the allowed switch types (Fixes test-322.cs).
7463 (LocalInfo.Resolve): Re-enable sanity-test.
7465 2005-07-06 Marek Safar <marek.safar@seznam.cz>
7467 * cs-tokenizer.cs (consume_identifier): Detect double undescores
7469 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
7471 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
7473 2005-07-06 Raja R Harinath <rharinath@novell.com>
7476 * ecore.cs (SimpleName.GetSignatureForError): Add.
7477 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
7478 (MemberAccess.GetSignatureForError): Add.
7480 2005-07-05 Marek Safar <marek.safar@seznam.cz>
7482 The big error and warning messages review.
7512 * typemanager.cs: Updated.
7514 * class.cs: (MethodCore.SetYields): Moved here to share.
7515 (PropertyMethod.Define): Moved iterator setup here.
7517 * iterators.cs: Add orig_method to have full access to parent
7520 2005-07-05 Raja R Harinath <rharinath@novell.com>
7522 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
7523 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
7524 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
7525 variable of struct type.
7526 * expression.cs (Unary.ResolveOperator): Update to change.
7527 (Indirection.VerifyFixed): Likewise.
7528 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
7529 (ParameterReference.VerifyFixed): Value parameters are fixed.
7530 (This.VerifyFixed): Treat 'this' as a value parameter.
7531 * statement.cs (LocalInfo.IsFixed): Remove.
7533 2005-07-01 Martin Baulig <martin@ximian.com>
7535 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
7536 `ec.EmitThis ()' to get the correct scope.
7538 2005-07-01 Martin Baulig <martin@ximian.com>
7540 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
7541 instance is a ParameterReference; fixes #75299.
7543 2005-07-01 Martin Baulig <martin@ximian.com>
7545 Reverted Marek's latest patch (r46725):
7546 - it contains structural changes which are neither mentioned in
7547 the ChangeLog nor explained anywhere; for example the additional
7548 argument of EmitContext's and Iterator's .ctor's and the
7549 TypeContainer.DefineMembers() change.
7550 - structural changes like this should go in in seperate patches
7551 and not be hidden in a huge patch which just seems to affect
7552 warnings and errors.
7553 a big and hard to understand patch.
7554 - it breaks iterators and causes regressions, for instance in
7557 2005-06-30 Raja R Harinath <rharinath@novell.com>
7560 * expression.cs (Indexers.map): Remove.
7561 (Indexers.Append): Filter out inaccessible setters and getters.
7562 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
7565 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
7567 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
7568 (FieldExpr.Emit, PropertyExpr.Emit): Update.
7569 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
7570 * expression.cs (Invocation.EmitCall): Add CS0120 check.
7572 2005-06-30 Marek Safar <marek.safar@seznam.cz>
7575 * class.cs (FieldBase.GetInitializerExpression): One more field
7578 2005-06-28 Miguel de Icaza <miguel@novell.com>
7580 * pending.cs: Do not define a proxy if the base method is virtual,
7581 it will be picked up by the runtime (bug 75270).
7583 2005-06-08 Martin Baulig <martin@ximian.com>
7585 The big Iterators rewrite :-)
7587 * iterators.cs: Rewrite this to use the anonymous methods framework.
7589 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
7590 before the TypeContainers; see 2test-21.cs.
7593 (TypeContainer.DefineType): Don't create a new EmitContext if we
7594 already have one (this only happens if we're an Iterator).
7595 (TypeContainer.Define): Also call Define() on all our iterators.
7596 (Method.CreateEmitContext): Added support for iterators.
7599 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
7600 (AnonymousContainer.CreateMethodHost): Moved here from
7601 AnonymousMethod and made abstract.
7602 (AnonymousContainer.CreateScopeType): New abstract method.
7603 (AnonymousContainer.IsIterator): New public property.
7604 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
7605 get the ScopeTypeBuilder rather than manually defining it here.
7606 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
7609 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
7610 before RootContext.DefineTypes().
7612 * codegen.cs (EmitContext.RemapToProxy): Removed.
7613 (EmitContext.CurrentAnonymousMethod): Changed type from
7614 AnonymousMethod -> AnonymousContainer.
7615 (EmitContext.ResolveTopBlock): Protect from being called twice.
7616 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
7617 (EmitContext.EmitThis): Removed the iterators hacks; use the
7618 anonymous methods framework for that.
7621 (ToplevelBlock.Container): Make this a property, not a field.
7622 (ToplevelBlock.ReParent): New public method; move the
7623 ToplevelBlock into a new container.
7624 (Foreach.TemporaryVariable): Simplify.
7626 2005-06-05 Martin Baulig <martin@ximian.com>
7628 * statement.cs (LocalInfo.CompilerGenerated): New flag.
7629 (Block.AddTemporaryVariable): New public method; creates a new
7630 `LocalInfo' for a temporary variable.
7631 (Block.EmitMeta): Create the LocalBuilders for all the temporary
7633 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
7634 non-iterator variables.
7636 2005-06-05 Martin Baulig <martin@ximian.com>
7638 * statement.cs (Foreach.TemporaryVariable): Create the
7639 LocalBuilder in the Emit phase and not in Resolve since in some
7640 situations, we don't have an ILGenerator during Resolve; see
7641 2test-19.cs for an example.
7643 2005-06-04 Martin Baulig <martin@ximian.com>
7645 **** Merged r45395 from GCS ****
7647 The big Foreach rewrite - Part II.
7649 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
7650 with `PropertyInfo ienumerator_getcurrent'.
7652 * codegen.cs (VariableStorage): Removed.
7655 (Foreach): Derive from Statement, not ExceptionStatement.
7656 (Foreach.CollectionForeach): New nested class. Moved all the code
7657 dealing with collection foreach here.
7658 (Foreach.ForeachHelperMethods): Removed.
7659 (Foreach.TemporaryVariable): Implement IMemoryLocation.
7661 2005-05-23 Martin Baulig <martin@ximian.com>
7663 * statement.cs (Try.DoResolve): Don't create a `finally' if we
7664 don't need to. Fix #75014.
7666 2005-05-20 Martin Baulig <martin@ximian.com>
7668 Merged r44808 from GMCS.
7670 * class.cs (TypeContainer.CircularDepException): Removed.
7671 (TypeContainer.DefineType): Removed the `InTransit' stuff.
7672 (TypeContainer.CheckRecursiveDefinition): Check for circular class
7673 (CS0146) and interface (CS0529) dependencies here.
7675 2005-06-21 Raja R Harinath <rharinath@novell.com>
7677 * expression.cs (Invocation.EmitCall): Fix initialization
7678 'this_call' to reflect current behaviour. Fix indentation.
7680 * convert.cs (FindMostEncompassedType): Add two trivial special
7681 cases (number_of_types == 0 || number_of_types == 1).
7682 (FindMostEncompasingType): Likewise.
7684 2005-06-17 Raja R Harinath <rharinath@novell.com>
7686 Some cleanups preparing for the fix of #75283.
7687 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
7689 (EventExpr.InstanceResolve): Likewise.
7690 (EventExpr.DoResolve): Remove redundant checks.
7692 2005-06-10 Duncan Mak <duncan@novell.com>
7694 * cs-tokenizer.cs (process_directives): New flag for controlling
7695 the processing of preprocessor directives.
7696 (x_token): After seeing a '#', return Token.NONE instead of going
7697 to handle_preprocessing_directive() when not processing
7698 directives. This avoids unnecessary processing during the token peek in
7703 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
7704 the existing error reporting methods instead of Report.Error.
7706 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
7707 after Raja's rewrite.
7709 2005-06-08 Miguel de Icaza <miguel@novell.com>
7711 * class.cs: Small fix.
7713 2005-06-08 Raja R Harinath <rharinath@novell.com>
7716 * class.cs (GetPartialBases): Fix return value check of
7719 2005-06-07 Raja R Harinath <rharinath@novell.com>
7721 Ensure that partial classes are registered in their enclosing
7722 namespace. Initial part of fix of #75160.
7723 * tree.cs (Tree.RecordDecl): Add new namespace argument.
7724 Register declspace with namespace here, not in
7725 DeclSpace.RecordDecl.
7726 * cs-parser.jay: Pass namespace to RecordDecl.
7727 * class.cs (PartialContainer.Create): Likewise.
7728 (ClassPart.DefineType): New sanity-check. Throws an exception if
7730 * decl.cs (Declspace.RecordDecl): Remove.
7731 * namespace.cs (NamespaceEntry.DefineName): Remove.
7733 2005-06-06 Marek Safar <marek.safar@seznam.cz>
7735 * rootcontext.cs: Reset TargetExt as well.
7737 2005-06-03 Raja R Harinath <rharinath@novell.com>
7739 * ecore.cs (Expression.Resolve): Emit CS0654 error when
7742 2005-06-02 Raja R Harinath <rharinath@novell.com>
7744 Fix #75080, cs0119.cs.
7745 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
7747 (Expression.Resolve): ... this. Use it. Remove bogus code
7748 allowing ExprClass.Type and ExprClass.Namespace for
7749 ResolveFlags.VariableOrValue.
7750 (Expression.Resolve) [1-argument variant]: Change default resolve
7751 flags based on language version.
7752 (Expression.Error_UnexpectedKind): Use a simple string array
7753 rather than an ArrayList.
7754 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
7756 (TypeOfVoid.DoResolve): Likewise.
7757 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
7758 flags argument -- it always has the same value.
7760 2005-05-31 Raja R Harinath <rharinath@novell.com>
7763 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
7764 Use it in the error message.
7765 * assign.cs, expression.cs, statement.cs: Update.
7767 2005-05-30 Raja R Harinath <rharinath@novell.com>
7770 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
7771 the "almostMatchedMember" case too.
7772 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
7773 that failed the accessibility checks to 'almost_match'.
7775 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
7777 * attribute.cs: Use internal MethodBuilder methods to set
7778 ExactSpelling and SetLastError on PInvoke methods, instead
7779 of passing them via charset. Fixes #75060.
7781 2005-05-27 Raja R Harinath <rharinath@novell.com>
7783 * parameter.cs (Parameter): Remove TODO comment.
7784 (Parameter.DefineParameter): Remove Location parameter.
7785 (Parameters.LabelParameters): Likewise.
7786 * class.cs (Constructor.Emit): Update to change.
7787 (MethodData.Emit): Likewise.
7788 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
7789 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
7791 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
7794 Removed Parameters.Location and added Parameter.Location instead.
7795 Removed Location parameter from Emit() and GetSignature().
7802 Modified all related calls.
7804 2005-05-26 Raja R Harinath <rharinath@novell.com>
7806 Improve user-defined conversion handling.
7807 * convert.cs (GetConversionOperators): Rewrite. Return only the
7808 applicable operators.
7809 (AddConversionOperators): New. Helper for GetConversionOperators.
7810 (FindMostEncompassedType, FindMostEncompassingType): Verify that
7811 there is only one most encompassed/encompassing type.
7812 (FindMostSpecificSource, FindMostSpecificTarget): Remove
7813 "applicable operator" handling.
7814 (UserConversion): Move cache here from GetConversionOperators.
7815 Directly cache the chosen operator, rather than the whole
7817 (ExplicitNumericConversion): Fix buggy implementation of Decimal
7818 case. Allow conversion of decimal to sbyte and byte too.
7819 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
7820 New static methods. Used to avoid allocating EmptyExpressions in
7823 2005-05-24 Duncan Mak <duncan@novell.com>
7825 * ecore.cs (CastFromDecimal): New class for casting a decimal to
7826 another class, used in Convert.ExplicitNumericConversion.
7827 (CastToDecimal): New class, similar to above, but casts to
7828 System.Decimal, used in Convert.ImplicitNumericConversion and also
7829 in explicit convesion from double/float to decimal.
7831 * convert.cs (ImplicitNumericConversion): Handle implicit
7832 conversions to System.Decimal.
7833 (ExplicitNumericConversion): handle explicit conversions to
7838 2005-05-20 Miguel de Icaza <miguel@novell.com>
7840 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
7841 know the type at this stage, just break through. Fixes #75008
7843 2005-05-19 Martin Baulig <martin@ximian.com>
7846 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
7847 to disable error reporting.
7849 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
7850 here since we don't want to report an error; see the new test-336.cs.
7852 2005-05-19 Raja R Harinath <rharinath@novell.com>
7854 * statement.cs (ToplevelBlock.GetParameterReference)
7855 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
7856 Move here from class Block.
7857 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
7858 * expression.cs (ParameterReference.DoResolveBase): Likewise.
7860 2005-05-18 Martin Baulig <martin@ximian.com>
7865 (FlowBranching.Reachability): Add non-static public And() and Or()
7867 (FlowBranchingSwitch): New class; do the `break_origins' thing
7868 like in FlowBranchingLoop.
7869 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
7870 reachability, not just locals and parameters.
7871 (FlowBranching.MergeChild): Remove some of the hacks for loop and
7872 switch; MergeBreakOrigins() now takes care of that.
7874 2005-05-18 Martin Baulig <martin@ximian.com>
7876 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7877 a loop and may leave it, reset the barrier; fixes #74974.
7879 2005-05-17 Marek Safar <marek.safar@seznam.cz>
7881 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
7884 * cs-parser.jay: Catch more lexical errors.
7886 * report.cs: Add one more Error method.
7889 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
7891 2005-05-17 Martin Baulig <martin@ximian.com>
7893 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
7896 2005-05-16 Raja R Harinath <rharinath@novell.com>
7898 Fix test-382.cs. Emit values of decimal constants.
7899 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
7901 (TypeContainer.AddField): ... this.
7902 (TypeContainer.EmitFieldInitializers): Allow the list of fields
7903 with initializers to include 'Const's.
7904 (ClassPart.RegisterFieldForInitialization): Forward to
7906 * const.cs (Const.Const): Pass initializer to base class.
7907 (Const.Define): In case of decimal constants, register them for
7908 initialization in a static constructor.
7910 2005-05-14 Martin Baulig <martin@ximian.com>
7912 * statement.cs (Block.Resolve): Correctly handle unreachable code;
7913 do not call ResolveUnreachable() on unreachable statements in
7914 here, see the comment in the source code.
7916 2005-05-13 Raja R Harinath <rharinath@novell.com>
7919 * expression.cs (BinaryResolveOperator): If one of the operands of
7920 an equality comparison is 'null' and the other is a pointer type,
7921 convert the null to a NullPointer.
7922 * convert.cs (ImplicitReferenceConversion): If the expression is a
7923 NullLiteral and the target type is a pointer type, return a
7924 NullPointer instead.
7925 (ImplicitConversionStandard): Likewise.
7927 2005-05-13 Marek Safar <marek.safar@seznam.cz>
7929 * cs-parser.jay: Set readonly context based on special constructs.
7931 * expression.cs (LocalVariableReference.DoResolveBase): Improved
7932 readonly variable error handling.
7934 * rootcontext.cs (EmitCode): Don't verify members when error
7937 * statement.cs (LocalInfo): Add reaodnly context information.
7938 (SetReadOnlyContext, GetReadOnlyContext): New methods.
7940 2005-05-13 Raja R Harinath <rharinath@novell.com>
7942 * statement.cs (Block.Resolve): Revert change below. Modify fix
7943 for #74041 to initialize 'resolved' to false only for explicit
7944 blocks. Fixes #74873.
7946 2005-05-12 Raja R Harinath <harinath@gmail.com>
7949 * typemanager.cs (unmanaged_enclosing_types): New.
7950 (IsUnmanagedType): Avoid infloops by using
7951 'unmanaged_enclosing_types' to talk with recursive invocations.
7953 2005-05-13 Martin Baulig <martin@ximian.com>
7955 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
7956 instance variable, not a local. Fix #74873.
7957 (Block.ResolveUnreachable): Set it to true here.
7959 2005-05-11 Duncan Mak <duncan@novell.com>
7961 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
7962 continuing to process for 'arg'.
7963 (handle_preprocessing_directive): Check the argument of the #endif
7964 directive and report error CS1025 if there are any trailing
7967 According to the C# spec, having even whitespace after the #endif
7968 directive is illegal; however, because we call arg.TrimEnd ()
7969 beforehand, we have the same behavior as csc, allowing whitespace
7970 after the directive.
7974 2005-05-11 Marek Safar <marek.safar@seznam.cz>
7978 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
7979 (Constructor.GetObsoleteAttribute): Implemented correctly.
7981 2005-05-10 Martin Baulig <martin@ximian.com>
7983 * support.cs (ReflectionParameters.ParameterModifier): Use
7984 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
7985 and `ParameterAttributes.In'. Fixes #74884.
7987 2005-05-10 Marek Safar <marek.safar@seznam.cz>
7989 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
7991 * expression.cs (Argument.GetParameterModifier): Turned to property.
7992 (Invocation.Error_InvalidArguments): Add more descriptive errors.
7994 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
7997 2005-05-09 Raja R Harinath <rharinath@novell.com>
8000 * decl.cs (MemberCache.AddMethods): Register override methods,
8001 rather than non-override methods.
8002 * typemanager.cs (RegisterOverride): New.
8003 (IsOverride): Update.
8005 2005-05-09 Marek Safar <marek.safar@seznam.cz>
8009 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
8010 recursive declaration.
8012 * statement.cs (Block.ResolveMeta): Report any error in resolving.
8014 2005-05-06 Marek Safar <marek.safar@seznam.cz>
8016 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
8018 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
8020 2005-05-05 Raja R Harinath <rharinath@novell.com>
8023 * decl.cs (DeclSpace.FamilyAccessible):
8024 Use TypeManager.IsNestedFamilyAccessible.
8026 Fix reopened #64812.
8027 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
8030 2005-05-04 Raja R Harinath <rharinath@novell.com>
8031 Abin Thomas <projectmonokochi@rediffmail.com>
8032 Anoob V E <projectmonokochi@rediffmail.com>
8033 Harilal P R <projectmonokochi@rediffmail.com>
8036 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
8037 allow access to all static members.
8039 2005-05-04 Martin Baulig <martin@ximian.com>
8041 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
8043 2005-05-04 Martin Baulig <martin@ximian.com>
8047 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
8048 section at the end; make things work if `default' is not the last
8051 2005-05-04 Martin Baulig <martin@ximian.com>
8055 * statement.cs (Switch): Replaced the `got_default' field with a
8056 `default_section' one.
8057 (Switch.CheckSwitch): Set `default_section' here.
8058 (Switch.Resolve): If we're a constant switch and the constant is
8059 not found, use the default section.
8061 2005-05-03 Martin Baulig <martin@ximian.com>
8063 * expression.cs (ArrayAccess.EmitGetLength): New public method.
8065 * statement.cs (Foreach.ArrayForeach): New nested class.
8066 (Foreach.TemporaryVariable): New nested class.
8067 (Foreach.EmitArrayForeach): Removed; this is now in the new
8070 2005-05-03 Raja R Harinath <rharinath@novell.com>
8072 * pending.cs (BaseImplements): Move the #74773 fix here. This is
8074 (VerifyPendingMethods): Revert change below.
8076 * typemanager.cs (IsOverride, RegisterNonOverride): New.
8077 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
8078 that used to trigger warning -28. Remove warning -28.
8079 * expression.cs (Invocation.OverloadResolve): Use
8080 TypeManager.IsOverride to distinguish override methods.
8083 * pending.cs (VerifyPendingMethods): If a base type implements the
8084 requested interface, don't bother checking individual methods of
8085 the base type. As a side-effect, this prevents the creation of
8086 unnecessary proxies.
8088 2005-05-02 Martin Baulig <martin@ximian.com>
8092 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
8093 Also `And' the locals if the old vector is null.
8094 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
8095 null; in this case we basically reset all the variables.
8097 2005-05-02 Martin Baulig <martin@ximian.com>
8101 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
8102 Added `FlowBranching branching' argument; always `and' the
8103 variables instead of `or'ing them unless we're an infinite loop.
8105 * statement.cs (While.Resolve): Create a new sibling unless we're
8108 2005-05-02 Martin Baulig <martin@ximian.com>
8112 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
8113 arguments; use it instead of creating a new TopLevelBlock.
8114 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
8115 our ConstructorInitializer.
8118 (TopLevelBlock.TopLevelBranching): New public property.
8119 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
8120 and create our `TopLevelBranching'.
8122 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
8123 anonymous method host, use `block.TopLevelBranching' rather than
8124 creating a new branching.
8126 2005-04-20 Miguel de Icaza <miguel@novell.com>
8128 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
8129 a ScopeInfo, if any of the current children is a child of the new
8130 entry, move those children there.
8132 2005-04-30 Martin Baulig <martin@ximian.com>
8134 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
8135 at the beginning of a SwitchSection. Fix #73335.
8137 2005-04-27 Marek Safar <marek.safar@seznam.cz>
8140 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
8142 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
8143 (FieldExpr.DoResolve): Obsolete members are ignored for field
8146 2005-04-26 Marek Safar <marek.safar@seznam.cz>
8148 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
8149 of arrays detection.
8151 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
8153 (Field.VerifyClsCompliance): Volatile fields are not compliant.
8155 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
8158 2005-04-25 Ben Maurer <bmaurer@ximian.com>
8160 * cs-parser.jay: Use the prefered version of -unsafe in error
8163 2005-04-22 Marek Safar <marek.safar@seznam.cz>
8165 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
8168 2005-04-20 John Luke <john.luke@gmail.com>
8170 * driver.cs: fix typo in error message, --outout to --output
8172 2005-04-20 Marek Safar <marek.safar@seznam.cz>
8174 * codegen.cs (InRefOutArgumentResolving): New field.
8176 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
8177 fields outside contructor.
8179 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
8181 2005-04-19 Miguel de Icaza <miguel@novell.com>
8183 * anonymous.cs (CaptureContext.EmitParameterInstance): The
8184 parameter code was not completed ever, so it was not as up-to-date
8185 as local variables. Must finish it.
8187 The bug fix was to compare the Toplevel of the block, not the
8188 current block. Thanks for Ben for pointing this out.
8190 2005-04-19 Raja R Harinath <rharinath@novell.com>
8192 * decl.cs (AddMethods): Use the declaring type of the problem
8193 method to determine if we want to squash a warning.
8195 2005-04-19 Marek Safar <marek.safar@seznam.cz>
8197 * attribute.cs: Removed debug output.
8199 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
8201 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
8204 2005-04-18 Raja R Harinath <rharinath@novell.com>
8207 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
8208 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
8209 all null comparisons against reference types.
8211 2005-04-18 Marek Safar <marek.safar@seznam.cz>
8214 * class.cs (TypeContainer.CircularDepException) New nested
8216 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
8217 (TypeContainer.DefineType): Removed error, reset InTransit before
8219 (Class.DefineType): Throw exception when is in Transit.
8220 Catch exception and report error.
8221 (Struct.DefineType): Throw exception when is in Transit.
8222 Catch exception and report error.
8223 (Interface.DefineType): Throw exception when is in Transit.
8224 Catch exception and report error.
8226 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
8227 handle nested exception handlers.
8229 * flowanalysis.cs (InTryWithCatch): New method, search for try with
8232 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
8233 InFinally and InCatch storage.
8235 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
8236 (Catch.Resolve): Set and Restore ec.InCatch.
8237 (Try.Resolve): Set and Restore ec.InFinally.
8238 (Try.HasCatch): True when try has catch.
8240 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
8242 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
8243 for the same event member, so exclude such cases from warning 419.
8246 2005-04-16 Miguel de Icaza <miguel@novell.com>
8248 * expression.cs (Binary.ResolveOperator): Apply patch from John
8249 Luke to fix bug 59864: operators &, | and ^ on enumerations
8250 require that the same enum type on both sides.
8252 * driver.cs: Add warnings to old flag usage, this is to assist
8253 people who produce Makefiles and hope that the Makefiles will be
8256 * class.cs (TypeContainer.EmitType): Moved the definition of the
8257 special $PRIVATE$ field from the resolve phase to the Emit phase.
8258 During resolve we do not know if we are a struct with
8259 HasExplicitLayout, we know this only after the attributes for the
8262 Set the FieldOffset to zero on the dummy field that we create for
8263 the class. Fixes 74590.
8265 2005-04-16 Raja R Harinath <rharinath@novell.com>
8268 * ecore.cs (PropertyExpr.resolved): New.
8269 (DoResolve): Use it to handle a case of double resolution here.
8270 Handle a case of identical-name-and-type-name.
8271 * expression.cs (ArrayCreation.CheckIndices): Avoid double
8272 resolution by storing the results of expression resolution back
8273 into the "probes" array.
8275 2005-04-15 Raja R Harinath <rharinath@novell.com>
8277 Fix cs0208-7.cs and cs0208-8.cs.
8278 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
8279 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
8280 error reporting to point out the reason a struct is not unmanaged.
8282 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8284 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
8285 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
8287 2005-04-13 Raja R Harinath <rharinath@novell.com>
8290 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
8291 IdenticalNameAndTypeName here.
8292 (EventExpr.InstanceResolve): Likewise.
8294 2005-04-13 Marek Safar <marek.safar@seznam.cz>
8296 C# 2.0 DefaultCharSetAttribute implementation
8298 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
8299 which allows us to set GlobalNamespace for every resolve.
8300 (Attribute.ResolveArguments): Cut from Resolve.
8301 (Attribute.GetCharSetValue): Returns CharSet named argument.
8302 (Attribute.DefinePInvokeMethod): Gets default charset from
8304 (GlobalAttribute.ResolveAsTypeStep): Override.
8305 (GlobalAttribute.ResolveArguments): Override.
8307 * class.cs (TypeAttr): Is protected.
8309 * codegen.cs (ModuleClass.DefaultCharSet): New member.
8310 (ModuleClass.DefaultCharSetType): New memeber.
8311 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
8313 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
8314 charset from module.
8316 * delegate.cs (TypeAttr): Override.
8317 (Delegate.DefineType): Use this TypeAttr.
8319 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
8320 at very early stage (before types are defined) to resolve model
8321 module attributes. It will probably not work with corlib but it
8324 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
8325 charset from module.
8327 * typemanager.cs (default_charset_type): New type.
8329 2005-04-13 Raja R Harinath <rharinath@novell.com>
8331 * decl.cs (MemberCache.AddMethods): Don't warn if
8332 System.Object.Finalize has buggy MethodAttributes.
8334 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
8337 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8339 * doc.cs : detect ambiguous reference to overloaded members.
8340 Fixed bug #71603. MS 1.1 csc does not detect it.
8342 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
8344 * doc.cs : delegates must not be referenced with parameters.
8347 2005-04-12 Miguel de Icaza <miguel@novell.com>
8349 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
8351 2005-04-10 Miguel de Icaza <miguel@novell.com>
8353 * driver.cs (MainDriver): Stop processing if the CLS stage found
8356 (CompilerCallableEntryPoint.InvokeCompiler): Always
8357 reset after execution; Take a TextWriter argument for the
8360 * report.cs: Use the error stream instead of hardcoding stderr.
8362 2005-04-09 Miguel de Icaza <miguel@novell.com>
8364 * class.cs: Reduce code paths to test, too small of an
8365 optimization to make it worth the extra testing. Always perform
8368 2005-04-08 Raja R Harinath <rharinath@novell.com>
8371 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
8372 operators that had errors reported on them.
8374 2005-04-08 Marek Safar <marek.safar@seznam.cz>
8376 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
8378 (Attribute.Resolve): Add named argument type checking.
8380 * class.cs (FixedField.Define): Use IsPrimitiveType
8382 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
8384 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
8385 unsafe parameter types.
8387 * statement.cs (Using.ResolveExpression): Add better error description.
8389 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
8391 2005-04-08 Raja R Harinath <rharinath@novell.com>
8394 * attribute.cs (Attribute.GetAttributeUsage): Resolve
8395 AttributeUsageAttribute in the emitcontext of the attribute class,
8396 not in the emitcontext of the attributable entity it was attached to.
8397 * cs-parser.jay: Use 'current_class', not 'current_container',
8398 when creating a GlobalAttribute.
8400 2005-04-08 Alp Toker <alp@atoker.com>
8402 * pending.cs: The fix to #58413 failed to compile methods implementing
8403 interfaces with/without params modifiers and vice versa, even though
8404 params modifiers aren't part of the signature. Make the modifier check
8405 less strict as in csc.
8407 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
8408 Anoob V E <projectmonokochi@rediffmail.com>
8409 Harilal P R <projectmonokochi@rediffmail.com>
8412 * pending.cs (TypeAndMethods.mods): New. Store the parameter
8413 modifiers of pending methods.
8414 (PendingImplementation.PendingImplementation): Initialize it.
8415 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
8416 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
8417 with ParameterData. Add check for modifiers.
8418 * class.cs (MethodData.Define): Update to changes.
8420 2005-04-07 Raja R Harinath <rharinath@novell.com>
8422 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
8424 2005-04-07 Marek Safar <marek.safar@seznam.cz>
8426 * class.cs (PropertyMethod.Define): Check private accessor in abstract
8429 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
8432 * typemanager.cs: Registered RequiredAttributeAttribute.
8434 2005-04-06 Marek Safar <marek.safar@seznam.cz>
8436 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
8437 Warning CS0169 is back at level 3.
8438 (IMethodData.SetMemberIsUsed): New method.
8440 * decl.cs (IsUsed): New value; moved from FieldBase.Status
8441 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
8443 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
8445 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
8447 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
8450 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
8453 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
8454 to avoid the problems with nested types.
8456 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
8457 Anoob V.E <projectmonokochi@rediffmail.com>
8458 Harilal P.R <projectmonokochi@rediffmail.com>
8459 Raja R Harinath <rharinath@novell.com>
8462 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
8464 * typemanager (GetConstructor): Make public.
8466 2005-04-05 John Luke <john.luke@gmail.com>
8467 Raja R Harinath <rharinath@novell.com>
8470 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
8471 struct too. Return false quicker in a few cases.
8472 (VerifyUnManaged): Use it.
8474 2005-04-05 Raja R Harinath <rharinath@novell.com>
8477 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
8478 not 'unreachable_seen'.
8480 2005-04-04 Marek Safar <marek.safar@seznam.cz>
8482 * attribute.cs (Attribute.GetValue): Removed unused.
8484 * codegen.cs (CodeGen.TrimExt): Removed unused.
8486 * cs-parser.jay (output): Removed unused.
8488 * cs-tokenizer.cs (hex_digits): Removed unused.
8490 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
8492 * expression.cs (Indirection.LoadExprValue): Removed unused.
8493 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
8495 * iterators.cs (Iterator.param_types): Removed unused.
8497 * statement.cs (Goto.block): Removed unused.
8498 (ToplevelBlock.did): Removed unused.
8499 (Switch.ResolveConstantSwitch): Removed unused.
8501 2005-04-01 Ben Maurer <bmaurer@ximian.com>
8503 * rootcontext.cs: Allow mcs to bootstrap with the compilation
8506 2005-04-01 Raja R Harinath <rharinath@novell.com>
8508 Fix #74232 and cs0208-3.cs.
8509 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
8510 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
8511 unmanaged type. Don't use FieldBuilders when 't' is a
8512 TypeBuilder. Use ModFlags and MemberType fields.
8513 * class.cs (MemberBase.member_type): Rename from MemberType.
8514 (MemberBase.MemberType): New property. Determines member_type on
8516 (MemberBase.DoDefine): Don't initialize MemberType here.
8517 (FieldMember.Define): Likewise.
8519 2005-04-01 Marek Safar <marek.safar@seznam.cz>
8522 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
8523 Attributes are emitted there.
8525 2005-04-01 Raja R Harinath <rharinath@novell.com>
8527 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
8528 keyword in 'partial enum' too.
8529 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
8531 Report from Kamil Skalski <nazgul@omega.pl>.
8534 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
8535 have partial containers too.
8537 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
8538 in block' checks to Block.CheckInvariantMeaningInBlock.
8539 * statement.cs (Block.GetKnownVariableInfo): Make private.
8540 (Block.IsVariableUsedInChildBlock): Remove.
8541 (Block.IsVariableUsedInBlock): Likewise.
8542 (Block.CheckInvariantMeaningInBlock): New. Show location of
8543 conflicting declaration.
8544 (Block.AddVariable): Make error messages less long-winded and more
8545 specific. Show location of conflicting declaration.
8546 * parameter.cs (Parameters.Location): New readonly property.
8548 2005-03-31 Raja R Harinath <rharinath@novell.com>
8550 Clean up semantics of invoking ResolveMemberAccess.
8551 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
8552 can have an instance, ensure that we pass in a non-TypeExpression
8553 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
8554 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
8555 argument. Update to changes and simplify.
8556 (FieldExpr.Emitinstance): Remove CS0120 check.
8557 (PropertyExpr.EmitInstance): Likewise.
8558 * expression.cs (Argument.Resolve): Likewise.
8559 (Invocation.DoResolve): Update to changes in semantics of
8562 2005-03-31 Marek Safar <marek.safar@seznam.cz>
8565 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
8568 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
8570 2005-03-31 Raja R Harinath <rharinath@novell.com>
8572 Fix difference in behaviour with commandline invocation.
8573 * driver.cs (Driver.Reset): New.
8574 (CompilerCallableEntryPoint): Call it.
8576 * statement.cs (If.Resolve): Avoid spurious "uninitialized
8577 variable" warnings if the boolean expression failed to resolve.
8579 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
8581 * attribute.cs: Fix the union of several permissions when some of them
8582 are unrestricted (so the result isn't an unrestricted permission set).
8585 2005-03-30 Raja R Harinath <rharinath@novell.com>
8587 * ecore.cs (MemberExpr): New class. Convert from interface
8589 (MemberExpr.ResolveMemberAccess): Refactor and move here from
8590 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
8592 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
8593 (MethodGroupExpr.IsExplicitImpl): Remove.
8594 (Expression.GetFieldFromEvent): Remove.
8595 (SimpleName.MemberStaticCheck): Remove.
8596 (SimpleName.DoSimpleNameResolve): Update to changes.
8597 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
8598 (MemberAccess.IdenticalNameAndTypeName): Remove.
8599 (MemberAccess.error176): Move to MemberExpr.
8600 (MemberAccess.DoResolve): Update to changes.
8601 (BaseAccess.DoResolve): Likewise.
8603 2005-03-30 Marek Safar <marek.safar@seznam.cz>
8605 C# 2.0 Conditional attribute class implementation
8607 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
8608 Analyzes class whether it has attribute which has ConditionalAttribute
8609 and its condition is not defined.
8611 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
8612 (Class.IsExcluded): New method. Search for at least one defined
8613 condition in ConditionalAttribute of attribute class.
8615 2005-03-30 Raja R Harinath <rharinath@novell.com>
8617 * ecore.cs (PropertyExpr): Derive from Expression, not
8618 ExpressionStatement.
8619 (PropertyExpr.EmitStatement): Remove.
8621 2005-03-29 Raja R Harinath <rharinath@novell.com>
8624 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
8625 internal field "value__" of an enum be private. The examples for
8626 "value__" that I found on MSDN all used FieldAttributes.Private.
8628 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
8629 Don't mention IL method attribute names.
8631 Fix #47991. Remove a TODO.
8632 * statement.cs (Block.Toplevel): Make into a field.
8633 (Block.Parameters): Move into ToplevelBlock.
8634 (Block.known_variables): Rename from child_variable_names.
8635 (Block.Block): Remove variants that take Parameters. Initialize
8636 'Toplevel' with the immediately surrounding toplevel block.
8637 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
8638 LocalInfo parameter.
8639 (Block.GetKnownVariableInfo): New.
8640 (Block.IsVariableNameUsedInChildBlock): Update.
8641 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
8642 the block, even though it may not be in scope.
8643 (Block.AddVariable): Remove Parameters parameter. Use
8644 Toplevel.Parameters instead.
8645 (Block.AddConstant): Remove Parameters parameter.
8646 (Block.GetParameterReference): Update to use Toplevel.Parameters.
8647 (Block.IsParamaterReference): Likewise.
8648 (Block.IsLocalParameter): Likewise. Simplify a lot.
8649 (ToplevelBlock.Parameters): New. Moved from Block.
8650 (ToplevelBlock.ToplevelBlock): Update to changes. Always
8651 initialize Parameters to a non-null value.
8652 * cs-parser.jay: Update to changes.
8653 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
8654 simple names that mean different things in the same block. Use
8655 Block.IsVariableNameUsedInBlock.
8657 2005-03-28 Raja R Harinath <rharinath@novell.com>
8659 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
8660 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
8661 GetTypeHandle. It is possible for a reflected type to derive from
8662 a TypeBuilder (e.g., int[] derives from the TypeBuilder
8663 System.Array during mscorlib compilation).
8664 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
8665 contain a method_hash, don't create one either. Don't create a
8666 deep copy of the base cache's method_hash.
8667 (MemberCache.SetupCache): Rename back from DeepCopy.
8668 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
8669 already initialized. If we see an override function, add its
8670 underlying base virtual function to the member_hash too.
8672 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
8674 2005-03-26 Raja R Harinath <harinath@acm.org>
8677 * assign.cs (Assign.DoResolve): When the RHS of an assignment
8678 fails to resolve, ensure that the LHS is still resolved as an
8681 2005-03-25 Raja R Harinath <harinath@acm.org>
8683 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
8685 (Enum.current_ec): Remove.
8686 (Enum.LookupEnumValue): Remove EmitContext argument.
8687 Just uses the one created during DefineType.
8688 (Enum.FindMembers): Update.
8689 * expression.cs (MemberAccess.DoResolve): Update.
8691 2005-03-22 Marek Safar <marek.safar@seznam.cz>
8693 * assign.cs (Assign.DoResolve): Check for CS1717 when
8694 source and target are same (uses Equals).
8696 * expression.cs (LocalVariableReference, ParameterReference,
8697 This): Implemented Equals, GetHashCode.
8699 * statement.cs (Block.GetParameterReference): Removed useless
8702 2005-03-22 Raja R Harinath <rharinath@novell.com>
8705 * statement.cs (Block.AddVariable): Ensure that we skip implicit
8706 blocks before deciding whether the error is cs0136 or cs0128.
8708 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
8709 (using_alias_directive, using_namespace_directive): Pass
8710 MemberName, not an expression to Namespace.UsingAlias and
8712 (MakeName): Use the MemberName of the namespace.
8713 * namespace.cs (Namespace.MemberName): New.
8714 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
8715 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
8717 * decl.cs (MemberName.Name): Make readonly.
8718 (MemberName.FromDotted): New "constructor".
8719 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
8720 (MemberCore.Name): Compute from MemberName on demand.
8721 (MemberCore.SetMemberName): Provide a way to change the
8723 (MemberCore.AddToContainer): Don't take a fullname parameter.
8724 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
8725 fully qualified name of the container to the member name.
8726 (TypeContainer.AddToTypeContainer): Use a fully qualified name
8727 only if the type is a member of the root container.
8728 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
8729 MemberName.Left rather than searching for an embedded ".".
8730 (PartialContainer.CreatePart): Update to changes in RootContext.
8731 (MemberBase.ShortName): Turn into a property. Use
8732 MemberCore.SetMemberName.
8733 (MemberBase.ExplicitInterfaceName): Remove.
8734 (MemberBase.UpdateMemberName): Remove.
8735 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
8736 (PropertyBase.SetMemberName): New override.
8737 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
8738 (Tree.GetDecl): New.
8739 (Tree.AllDecls): Rename from Decls.
8740 * attribute.cs, enum.cs, report.cs: Update to changes.
8741 * driver.cs (MainDriver): Use MemberName.FromDotted on
8742 RootContext.MainClass.
8744 2005-03-21 Marek Safar <marek.safar@seznam.cz>
8746 * class.cs (FixedField.Define): Check for CS1664 and more sanity
8749 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
8751 2005-03-18 Marek Safar <marek.safar@seznam.cz>
8753 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
8754 property accessor modifiers.
8756 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
8757 fixed buffer attribute (CS1716).
8758 (PropertyMethod.HasCustomAccessModifier): When property accessor
8759 has custom modifier.
8761 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
8763 (PropertyExpr.DoResolveLValue): Add CS0272.
8765 2005-03-17 Miguel de Icaza <miguel@novell.com>
8767 * convert.cs: When converting to a pointer, use the proper Conv.U
8768 or Conv.I depending on the source data type.
8770 * cs-tokenizer.cs: Make the size for large decimal constants,
8773 2005-03-17 Martin Baulig <martin@ximian.com>
8775 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
8776 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
8778 2005-03-17 Martin Baulig <martin@ximian.com>
8780 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
8781 to bool so we can return an error condition.
8782 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
8785 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
8787 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
8790 2005-03-16 Raja R Harinath <rharinath@novell.com>
8792 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
8793 Refactor to avoid traversing the list of assemblies, and to avoid
8794 string concatenation.
8795 * typemanager.cs (guid_attr_type): Remove.
8796 (negative_hits, pointers, references): Remove hashes.
8798 (GetConstructedType): New. Uses type_hash to handle constructed
8799 types (arrays, references, pointers).
8800 (GetReferenceType, GetPointerType): Use it.
8801 (GetNestedType): New. Uses type_hash to handle nested types of
8803 (LookupType, LookupTypeDirect): Remove.
8804 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
8805 'types' hash and LookupTypeReflection directly.
8806 (params_string, params_object): Use GetConstructedType.
8807 * namespace.cs (Namespace.cached_types): New. Cache of reflected
8809 (Namespace.Lookup): Use cached_types.
8810 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
8811 provided by old TypeManager.LookupType.
8812 * rootcontext.cs (MakeFQN): Remove.
8813 * decl.cs (DeclSpace.MakeFQN): Likewise.
8814 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
8815 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
8816 TypeManager.GetConstructedType.
8817 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
8819 2005-03-15 Marek Safar <marek.safar@seznam.cz>
8821 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
8824 * cs-parser.jay: Reports CS1527 for any namespace element.
8826 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
8829 * expression.cs (ParameterReference.IsAssigned): Changed error to
8831 (Error_WrongNumArguments): Moved CS0245 detection here.
8833 * statement.cs (Return.Resolve): Add CS1622 report.
8835 2005-03-11 Marek Safar <marek.safar@seznam.cz>
8837 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
8839 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
8841 * attribute.cs expression.cs: Get rid of some allocations.
8843 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
8845 * doc.cs : just eliminate the latest change.
8847 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
8849 * doc.cs : commented out the latest change. It breaks xml-030.cs
8851 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
8853 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
8854 fail. So invoke CreateType() in FindDocumentedType().
8856 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
8858 * cs-tokenizer.cs : added IsKeyword().
8859 * doc.cs : Detect keyword incorrectly used as identifier.
8860 Allow identifiers prefixed by @.
8862 2005-03-10 Marek Safar <marek.safar@seznam.cz>
8864 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
8865 It caused exception in namespace resolving (again!).
8867 * class.cs (Class.ctor): Removed exit.
8868 (PropertyMethod.ctor): ditto.
8870 * codegen.cs (Codegen.Reset): Reset static data.
8871 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
8873 * cs-tokenizer.cs (Cleanup): Removed.
8875 * driver.cs (GetSystemDir): Rewrote to one line command.
8876 It caused problem with unloaded dynamic modules.
8877 (UnixParseOption): Removed Exit.
8878 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
8879 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
8880 Now can be mcs used as library.
8882 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
8885 * location.cs (Reset): Reset static data.
8887 * namespace.cs (Reset): Reset static data.
8889 * report.cs (Report.Reset): Reset static data.
8891 * rootcontext.cs (RootContext.Reset): Reset static data.
8893 * tree.cs (RootTypes.ctor): Use Location.Null
8895 * typemanager.cs (TypeManager.Reset): Reset static data.
8896 (CoreLookupType): Removed Exit.
8897 (TypeHandle.Reset): Reset static data.
8899 2005-03-10 Raja R Harinath <rharinath@novell.com>
8902 * typemanager.cs (ComputeNamespaces): Import namespaces from
8903 referenced modules too.
8905 2005-03-09 Raja R Harinath <rharinath@novell.com>
8907 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
8910 2005-03-09 Raja R Harinath <rharinath@novell.com>
8912 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
8913 enclosing DeclSpace. This ensures that a name-lookup populates
8914 more caches and there are fewer 'TypeExpression's. Carve out
8915 nested type lookup into ...
8916 (LookupNestedTypeInHierarchy): ... this.
8918 2005-03-09 Raja R Harinath <rharinath@novell.com>
8920 Clean up a few partial-class semantics.
8921 Fixes test-357.cs and cs1618-2.cs.
8922 * cs-parser.jay (struct_declaration): Use 'current_class' as
8923 parent of newly-created struct. Remove call to Register ().
8924 Use 'pop_current_class' to complete handing the current struct.
8925 (interface_declaration): Likewise.
8926 (class_declaration): Likewise.
8927 (enum_declaration): Use 'current_class' as parent of newly created
8929 (delegate_declaration): Likewise.
8930 (pop_current_class): New function. This is used to handle closing
8931 up the 'current_class' and 'current_container', and pointing them
8932 to the enclosing class/container.
8933 (CSharpParser): Initialize 'current_class' too.
8934 * decl.cs (MemberCore): Add check for invariant: a partial
8935 container is not a parsed entity, and thus does not enclose any
8937 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
8938 (DeclSpace.BaseTypeExpr): Use it.
8939 (DeclSpace.LookupType): Add check for invariant.
8940 * class.cs (TypeContainer): Add check for invariant: a nested
8941 class should have the same NamespaceEntry as its enclosing class.
8942 (TypeContainer.EmitFieldInitializers): Make virtual.
8943 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
8945 (TypeContainer.Register): Remove.
8946 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
8947 null. Use TypeResolveEmitContext for resolving base types and
8948 interfaces. Move initialization of Parts.TypeBuilder here from
8950 (TypeContainer.DefineNestedTypes): ... here.
8951 (PartialContainer): Take a Namespace not a NamespaceEntry.
8952 (PartialContainer.Create): Don't use Register. Call the
8953 appropriate Add... function directly.
8954 (ClassPart): Take both the PartialContainer and the enclosing
8955 class as constructor arguments.
8956 (ClassPart.EmitFieldInitializers): Override.
8957 (ClassPart.PartFindNestedTypes): Remove.
8958 (FieldBase.GetInitializerExpression): Resolve the initializer
8959 expression in the emit context of the enclosing class.
8960 * tree.cs (RootTypes): Remove Register ().
8962 2005-03-08 Marek Safar <marek.safar@seznam.cz>
8964 * cs-parser.jay: Removed CS0134.
8966 * driver.cs: Removed CS1901.
8968 * expression.cs (SizeOf.DoResolve): Don't report CS0233
8969 for predefined types.
8971 2005-03-07 Duncan Mak <duncan@novell.com>
8973 * codegen.cs (Save): Catch UnauthorizedAccessException as
8974 well. Fixes bug #73454.
8976 2005-03-07 Marek Safar <marek.safar@seznam.cz>
8978 * cs-tokenizer.cs (xtoken): Add CS1035.
8980 * class.cs (MethodData.Define): Add CS0683.
8981 (FieldMember.ctor): Add CS0681.
8983 2005-03-07 Raja R Harinath <rharinath@novell.com>
8985 * ecore.cs (SimpleName.DoResolve): Rename from
8986 SimpleName.DoResolveAllowStatic.
8987 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
8988 Pass 'intermediate' flag to MemberStaticCheck.
8989 (SimpleName.MemberStaticCheck): Skip "static check" only in case
8990 of "intermediate" lookups via MemberAccess.
8991 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
8992 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
8994 2005-03-07 Raja R Harinath <rharinath@novell.com>
8997 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
8998 slipped in because of variable names that are identical to a
8999 builtin type's BCL equivalent ('string String;', 'int Int32;').
9000 (PropertyExpr.EmitInstance): Likewise.
9002 2005-03-04 Marek Safar <marek.safar@seznam.cz>
9004 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
9006 * report.cs (warning_ignore_table): Made public.
9008 2005-03-04 Raja R Harinath <rharinath@novell.com>
9011 * class.cs (MethodData.Emit): Pass 'container' to
9012 container.GetObsoleteAttribute instead of 'container.Parent'.
9014 2005-03-03 Marek Safar <marek.safar@seznam.cz>
9016 * cs-parser.jay: Add 1534 error test.
9018 * iterators.cs (Yield.CheckContext): Add error 1629.
9019 (Iterator.ctor): Save unsafe modifier.
9020 (MoveNextMethod.DoEmit): Restore unsafe context.
9022 * namespace.cs (UsingAlias): Better error message.
9024 2005-03-03 Dan Winship <danw@novell.com>
9026 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
9027 the warning message [#73219]
9029 2005-03-03 Raja R Harinath <rharinath@novell.com>
9031 Fix compile with MCS 1.0.0.0.
9032 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
9033 w_restore to not depend on string constant folding.
9035 2005-03-03 Raja R Harinath <rharinath@novell.com>
9037 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
9038 CS0246 check to users who passed 'silent = false'.
9039 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
9041 (SimpleName.SimpleNameResolve): Update.
9042 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
9043 (MemberAccess.IdenticalNameAndTypeName): Update.
9044 * doc.cs (FindDocumentedTypeNonArray): Update.
9046 2005-03-03 Raja R Harinath <rharinath@novell.com>
9048 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
9049 * parameters.cs (ComputeAndDefineParameters): Remove.
9050 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
9051 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
9052 Use GetParameterInfo.
9054 2005-03-02 Marek Safar <marek.safar@seznam.cz>
9056 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
9058 2005-03-02 Raja R Harinath <rharinath@novell.com>
9060 Unify DeclSpace.LookupType and DeclSpace.FindType.
9061 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
9062 is in charge of defining nested types on demand.
9063 (DeclSpace.LookupType): Use it when the current_type is a
9064 TypeBuilder. Use LookupTypeDirect for reflected types.
9065 (DeclSpace.FindType): Remove.
9066 (DeclSpace.LookupInterfaceOrClass): Likewise.
9067 (DeclSpace.DefineTypeAndParents): Likewise.
9068 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
9069 DeclSpace.LookupType.
9070 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
9071 * typemanager.cs (LookupType): Simplify.
9072 (AddUserType): Remove type from negative_hits.
9073 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
9074 * class.cs (TypeContainer.FindMembers): Move handling of nested
9076 (TypeContainer.FindMembers_NestedTypes): ... here.
9077 (TypeContainer.FindNestedType): Implement override.
9078 (ClassPart.FindNestedType): Delegate to PartialContainer.
9079 (ClassPart.PartFindNestedType): Looks up the nested types of the
9082 2005-03-02 Martin Baulig <martin@ximian.com>
9084 * class.cs (TypeContainer.DoDefineMembers): We also need a default
9085 static constructor in static classes.
9087 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
9089 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
9090 sizeParamIndex is not specified.
9092 2005-03-01 Marek Safar <marek.safar@seznam.cz>
9095 * report.cs (WarningMessage.IsEnabled): Missing null check.
9097 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9099 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
9100 in the fields and not in the properties.
9102 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
9104 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
9107 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9109 * attribute.cs: Small refactoring (improved robustness).
9110 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
9111 (ValidateGuid): Removed.
9112 (Resolve): Removed referenced to above mentioned.
9113 (GetAttributeUsage): Made private and changed to work without
9115 (GetIndexerAttributeValue): Don't crash.
9116 (GetConditionalAttributeValue): Ditto.
9117 (GetClsCompliantAttributeValue): Ditto.
9118 (ExtractSecurityPermissionSet): All attributes exceptions are
9120 (GetPropertyValue): New helper.
9121 (GetMethodImplOptions): New method.
9122 (DefinePInvokeMethod): Reuse common code. Implemented handling of
9123 some missing properties.
9125 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
9126 (Method.ApplyAttributeBuilder): Updated.
9128 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
9131 2005-02-28 Raja R Harinath <rharinath@novell.com>
9134 * report.cs (Report.SymbolRelatedToPreviousError): Handle
9135 non-simple types (array, pointer, reference).
9137 2005-02-28 Marek Safar <marek.safar@seznam.cz>
9139 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
9141 * class.cs (MethodCore.IsDuplicateImplementation): Special error
9143 (Method.CheckBase): Catch wrong destructor here.
9144 (MethodData.Define): Add errors 550, 668.
9146 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
9148 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
9150 * pending.cs (VerifyPendingMethods): Add error 551.
9152 * typemanager.cs (CSharpName): Next error report helper.
9154 2005-02-25 Marek Safar <marek.safar@seznam.cz>
9156 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
9157 attributes. Removed useless attribute double check.
9158 It saves almost 2MBs for corlib.
9160 2005-02-25 Raja R Harinath <rharinath@novell.com>
9163 * statement.cs (ExpressionStatement.Resolve): Make robust to being
9164 called twice in case of error.
9166 2005-02-23 Chris Toshok <toshok@ximian.com>
9168 Fix compiler portions of #72827.
9169 * statement.cs (Block.Emit): call Begin/EndScope on the
9170 EmitContext instead of the ILGenerator.
9172 * codegen.cs (EmitContext.BeginScope): new method, call
9173 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
9175 (EmitContext.BeginScope): same, but EndScope and CloseScope
9177 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
9178 offset and call the superclass's OpenScope(int) with it.
9179 (SymbolWriter.CloseScope): get the current il
9180 offset and call superclass's CloseScope(int) with it.
9182 2005-02-23 Marek Safar <marek.safar@seznam.cz>
9184 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
9185 CS1677 for out and ref as well.
9187 * class.cs (Method.Define): Add error CS1599 detection.
9189 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
9191 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
9193 * delegate.cs (Delegate.Define): Add error CS1599 detection.
9195 * support.cs.cs (ModifierDesc): New helper method.
9197 2005-02-23 Raja R Harinath <rharinath@novell.com>
9198 Abin Thomas <projectmonokochi@rediffmail.com>
9199 Anoob V E <projectmonokochi@rediffmail.com>
9200 Harilal P R <projectmonokochi@rediffmail.com>
9203 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
9204 MemberLookup (used for error reporting) actually returns a result.
9205 Fix error report number (122, not 112).
9207 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
9208 Anoob V E <projectmonokochi@rediffmail.com>
9209 Harilal P R <projectmonokochi@rediffmail.com>
9212 * pending.cs (PendingImplementation.GetAbstractMethods):
9213 Find NonPublic members too.
9215 2005-02-22 Marek Safar <marek.safar@seznam.cz>
9217 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
9220 * class.cs (MethodCore.CheckMethodAgainstBase):
9221 Add error 239 report.
9223 2005-02-21 Raja R Harinath <rharinath@novell.com>
9226 * expression.cs (Invocation.IsApplicable): Make public.
9227 (Invocation.IsParamsMethodApplicable): Likewise.
9228 * delegate.cs (Delegate.VerifyApplicability): Don't use
9229 Invocation.VerifyArgumentCompat for parameter applicability
9230 testing. Use Invocation.IsApplicable and
9231 Invocation.IsParamsMethodApplicable.
9233 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9235 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
9237 * class.cs (Operator.Define): Add error 217 report.
9239 2005-02-21 Raja R Harinath <rharinath@novell.com>
9241 * namespace.cs (UsingEntry.Resolve): Undo change below.
9243 2005-02-21 Raja R Harinath <rharinath@novell.com>
9246 * ecore.cs (Expression.MemberLookupFailed): Add argument to
9247 disable the error message when the extended MemberLookup also
9249 (Expression.MemberLookupFinal): Update.
9250 (SimpleName.DoSimpleNameResolve): Update.
9251 * expression.cs (MemberAccess.ResolveNamespaceOrType):
9252 Don't use MemberLookupFinal.
9253 (New.DoResolve): Update.
9254 (BaseAccess.CommonResolve): Update.
9256 2005-02-21 Raja R Harinath <rharinath@novell.com>
9259 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
9260 occured previously, don't resolve again.
9262 2005-02-21 Marek Safar <marek.safar@seznam.cz>
9265 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
9266 argument. Call ResolveAttributeUsage for unresolved.
9267 when types doesn't match ctor arguments.
9269 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
9270 for nested attribute classes.
9271 (Class.attribute_usage): Removed.
9272 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
9273 for attribute class.
9275 * ecore.cs (IsAttribute): Removed.
9277 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
9279 * rootcontext.cs (RegisterAttribute): Removed, attributes are
9281 (attribute_types): Removed.
9282 (EmitCode): Global attributes are emited as the latest.
9284 2005-02-18 Marek Safar <marek.safar@seznam.cz>
9286 * class.cs (EmitFieldInitializers): Don't emit field initializer
9287 for default values when optimilization is on.
9289 * constant.cs (Constant.IsDefaultValue): New property.
9291 * driver.cs: Add /optimize handling.
9295 * literal.cs: Implement new IsDefaultValue property.
9297 * rootcontext.cs (Optimize): New field, holds /optimize option.
9299 2005-02-18 Raja R Harinath <rharinath@novell.com>
9301 Fix crasher in re-opened #72347.
9302 * namespace.cs (Namespace.Lookup): Return null if
9303 DeclSpace.DefineType returns null.
9306 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
9308 2005-02-18 Raja R Harinath <rharinath@novell.com>
9310 Fix remainder of #63202. Change semantics of DoResolveLValue: it
9311 now returns null if it cannot resolve to an lvalue.
9312 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
9313 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
9314 returned null. Remove check for SimpleName.
9315 (EventExpr.DoResolveLValue): New.
9316 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
9317 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
9319 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
9321 (Unary.ResolveOperator): Move CS0211 check ...
9322 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
9324 (Unary.DoResolveLValue): Simplify.
9325 (AddressOf.DoResolveLValue): New.
9326 (ArrayAccess.DoResolveLValue): New.
9328 2005-02-16 Marek Safar <marek.safar@seznam.cz>
9330 * attribute.cs (Attribute.Resolve): Add arguments casting for
9331 when types doesn't match ctor arguments.
9333 2005-02-16 Raja R Harinath <rharinath@novell.com>
9335 Fix parts of #63202.
9336 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
9337 lookup of operator in base type. Ensure that all checks happen
9338 when the operator resolves to an "op_..." method.
9340 2005-02-15 Raja R Harinath <rharinath@novell.com>
9343 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
9344 'ignore_cs0104' parameter. Pass it to ...
9345 (NamespaceEntry.Lookup): ... this.
9346 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
9347 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
9348 (TypeLookupExpression.DoResolveAsTypeStep): Update.
9349 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
9350 Update. Request that cs0104 errors be ignored.
9351 (ComposedCast.ResolveAsTypeStep): Update.
9353 2005-02-14 Raja R Harinath <rharinath@novell.com>
9356 * expression.cs (Invocation.BetterFunction): Remove support for
9357 comparing virtual functions and their overrides.
9358 (Invocation.IsOverride): New.
9359 (Invocation.OverloadResolve): Don't consider 'override' functions
9360 during candidate selection. Store them in a lookaside list.
9361 If the selected method is a 'virtual' function, use the list to
9362 find any overrides that are closer to the LHS type.
9364 2005-02-14 Marek Safar <marek.safar@seznam.cz>
9366 * expression.cs (New.DoResolve): Add complex core type reduction.
9367 (New.Constantify): Converts complex core type syntax like 'new int ()'
9370 2005-02-14 Raja R Harinath <rharinath@novell.com>
9372 * decl.cs (EntryType.EntryType): New constructor to create an
9373 updated copy of a cache entry.
9374 (MemberCache.AddMethods): Use it.
9375 (MemberCache.ClearDeclaredOnly): Remove.
9376 (MemberCache.MemberCache): Update.
9378 2005-02-11 Miguel de Icaza <miguel@novell.com>
9380 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
9381 variable. This one is represents the actual low-level declaration
9382 of the method, as opposed to the semantic level `IsStatic'.
9384 An anonymous method which is hosted into a static method might be
9385 actually an instance method. IsStatic would reflect the
9386 container, while MethodIsStatic represents the actual code
9389 * expression.cs (ParameterReference): Use the new MethodIsStatic
9390 instead of IsStatic.
9392 * anonymous.cs (AnonymousMethod.Compatible): Pass the
9393 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
9394 set on the current EmitContext.
9396 * expression.cs (Cast): Overload DoResolveLValue so we can pass
9397 resolve our casted expression as an LValue. This triggers the
9398 proper LValue processing that is later required by Assign.
9402 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
9404 2005-02-11 Marek Safar <marek.safar@seznam.cz>
9406 C# 2.0 Fixed buffer implementation
9408 * anonymous.cs: Update after RegisterHelperClass renaming.
9410 * attribute.cs (AttributeTester.fixed_buffer_cache):
9411 Cache of external fixed buffers.
9412 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
9413 implementation if field is fixed buffer else null.
9416 (TypeContainer.AddField): Accept FieldMember instead of Field.
9417 (FieldBase.IsFieldClsCompliant): Extracted code from
9418 VerifyClsCompliance descendant customization.
9419 (FixedField): New class handles fixed buffer fields.
9420 (FixedFieldExternal): Keeps information about imported fixed
9422 (IFixedField): Make access to internal or external fixed buffer
9425 * cs-parser.jay: Add fixed buffer parsing.
9427 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
9430 * expression.cs (Indirection): Extended implementation to accept
9432 (PointerArithmetic.Emit): Get element from fixed buffer as well.
9433 (ElementAccess.MakePointerAccess): Get type as parameter.
9434 (DoResolve): Add fixed buffer field expression conversion.
9435 (DoResolveLValue): Ditto.
9436 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
9437 (ArrayPtr): Derives from FixedBufferPtr.
9438 (ArrayPtr.Emit): Add extra emit for array elements.
9440 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
9442 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
9443 for compiler generated types.
9444 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
9446 * statement.cs (Fixed): Refactored to be easier add fixed buffer
9447 and consume less memory.
9448 (Fixed.Resolve): Add fixed buffer case.
9450 * typemanager.cs (compiler_generated_attr_ctor,
9451 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
9452 (HasElementType): Add our own implementation to work on every
9455 2005-02-11 Miguel de Icaza <miguel@novell.com>
9457 * anonymous.cs (CaptureContext): Track whether `this' has been
9460 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
9461 only captured `this' if it was implicitly done (instance
9462 methods/variables were used).
9464 * codegen.cs (EmitContext.CaptureThis): New method to flag that
9465 `this' must be captured.
9467 2005-01-30 Miguel de Icaza <miguel@novell.com>
9469 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
9470 is null it means that there has been no need to capture anything,
9471 so we just create a sibling.
9473 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
9475 Just a partial fix. The other half is fairly elusive.
9477 2005-02-10 Raja R Harinath <rharinath@novell.com>
9479 Fix #52586, cs0121-4.cs.
9480 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
9481 and return a hashtable.
9482 (MemberCache.ClearDeclaredOnly): New.
9483 (MemberCache.MemberCache): Update to change. Make a deep copy of
9484 the method_hash of a base type too.
9485 (MemberCache.AddMethods): Adapt to having a deep copy of the base
9486 type methods. Overwrite entries with the same MethodHandle so
9487 that the ReflectedType is correct. The process leaves in base
9488 virtual functions and their overrides as distinct entries.
9489 (CacheEntry): Now a class instead of a struct. It shouldn't alter
9490 matters since it was boxed in a ArrayList before.
9491 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
9493 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
9494 case of a virtual function and its override (choose the overload
9496 (Invocation.OverloadResolve): Avoid 'override' members during
9497 'applicable_type' calculation.
9499 2005-02-09 Raja R Harinath <rharinath@novell.com>
9501 Combine two near-redundant caches.
9502 * typemanager.cs (method_params): Rename from method_internal_params.
9503 (TypeManager.GetParameterData): New. Replace
9504 Invocation.GetParameterData.
9505 (TypeManager.LookupParametersByBuilder): Remove.
9506 * expression.cs (Invocation.method_parameter_cache): Remove.
9507 (Invocation.GetParameterData): Remove.
9509 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
9512 2005-02-08 Raja R Harinath <rharinath@novell.com>
9515 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
9516 TypeManager.multicast_delegate_type is null, resolve it by looking
9517 up "System.MulticastDelegate".
9518 * rootcontext.cs (RootContext.ResolveCore): Simplify.
9520 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
9521 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
9522 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
9525 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
9526 (LabeledStatement.AddReference): New. Set 'referenced'.
9527 (Goto.Resolve): Use it.
9529 2005-02-05 John Luke <john.luke@gmail.com>
9531 * driver.cs: remove duplicate -doc line in Usage ()
9533 2005-02-04 Raja R Harinath <rharinath@novell.com>
9535 * location.cs (Location.AddFile): Fix CS2002 error report.
9537 2005-02-02 Martin Baulig <martin@ximian.com>
9539 * delegate.cs (Delegate.DefineType): Report an internal error if
9540 TypeManager.multicast_delegate_type is null. See bug #72015 for
9543 2005-02-02 Raja R Harinath <rharinath@novell.com>
9545 Fix a crasher in a variant of #31984.
9546 * const.cs (Constant.CheckBase): New override that defers the
9547 new-or-override check in case the base type hasn't been populated
9549 (Constant.Define): Ensure the new-or-override check is performed.
9551 2005-02-01 Duncan Mak <duncan@ximian.com>
9553 * const.cs (LookupConstantValue): Check that `ce' is not null
9554 before calling GetValue ().
9556 2005-02-01 Raja R Harinath <rharinath@novell.com>
9558 Fix test-334.cs (#69519).
9559 * cs-parser.jay (using_alias_directive): Pass in an expression to
9560 NamespaceEntry.UsingAlias.
9561 (using_namespace_directive): Pass in an expression to
9562 NamespaceEntry.Using.
9563 (namespace_name): Don't flatten to a string.
9564 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
9565 (NamespaceEntry.AliasEntry.Resolve): Lookup using
9567 (NamespaceEntry.UsingEntry): Likewise.
9568 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
9570 (NamespaceEntry.LookupForUsing): Remove.
9571 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
9573 (NamespaceEntry.Lookup): Remove support for dotted names.
9575 2005-02-01 Raja R Harinath <rharinath@novell.com>
9577 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
9579 (NamespaceEntry.ImplicitParent): Compute on demand.
9580 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
9581 parallels the current.
9582 (NamespaceEntry.LookupForUsing): Use it.
9583 (NamespaceEntry.Lookup): If the current namespace-entry is
9584 implicit, don't search aliases and using tables.
9586 2005-02-01 Raja R Harinath <rharinath@novell.com>
9589 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
9591 (TypeContainer.BaseCache): Compute on demand.
9592 (TypeContainer.FindMembers): Define constants and types if they're
9593 not already created.
9594 (FieldMember.Define): Move resetting of ec.InUnsafe before error
9596 * const.cs (Constant.Define): Make idempotent.
9598 2005-01-29 Miguel de Icaza <miguel@novell.com>
9600 * pending.cs: Produce better code (no nops produced by using Ldarg
9603 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
9604 i - 1' it should be arg + 1.
9608 2005-01-28 Raja R Harinath <rharinath@novell.com>
9610 * attribute.cs (Attribute.CheckAttributeType): Make private
9612 (Attribute.ResolveType): Make virtual.
9613 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
9614 handling of RootContext.Tree.Types.
9616 2005-01-27 Raja R Harinath <rharinath@novell.com>
9618 Update attribute-handling to use the SimpleName/MemberAccess
9620 * cs-parser.jay (attribute): Pass in an expression to the
9621 constructors of Attribute and GlobalAttribute.
9622 * attribute.cs (Attribute): Take an expression for the name.
9623 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
9624 passed in attribute name expression.
9625 (Attribute.CheckAttributeType): Use it.
9626 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
9627 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
9628 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
9629 argument to prevent error messages if the lookup fails.
9631 2005-01-27 Marek Safar <marek.safar@seznam.cz>
9633 * expression.cs (Indirection): Implemented IVariable interface
9634 to support indirection in AddressOf operator.
9635 (PointerArithmetic.Emit): Add optimalization for case where
9636 result can be precomputed.
9638 2005-01-26 Martin Baulig <martin@ximian.com>
9640 * class.cs (TypeContainer.AttributeTargets): Return the correct
9641 AttributeTargets depending on our `Kind' instead of throwing an
9642 exception; fixes #71632.
9644 2005-01-26 Marek Safar <marek.safar@seznam.cz>
9647 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
9650 2005-01-25 Raja R Harinath <rharinath@novell.com>
9653 * expression.cs (MemberAccess.DoResolve): Don't complain with
9654 cs0572 when the LHS of a member access has identical name and type
9657 2005-01-25 Marek Safar <marek.safar@seznam.cz>
9660 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
9662 Create custom PermissionSet only for PermissionSetAttribute.
9664 2005-01-24 Marek Safar <marek.safar@seznam.cz>
9667 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
9668 delegates in static class.
9670 2005-01-24 Martin Baulig <martin@ximian.com>
9672 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9673 merging an implicit block, just use its reachability.
9675 * statement.cs (Block.Resolve): Make the unreachable code check
9676 work wrt. implicit blocks; see test-337 from #63842.
9678 2005-01-21 Alp Toker <alp@atoker.com>
9680 * cs-parser.jay: destructor_declaration's container is PartialContainer
9681 not Class when partial types are used, so use Kind prop instead of
9684 2005-01-22 Miguel de Icaza <miguel@ximian.com>
9686 * cs-parser.jay: Improve error reporting when an interface
9689 2005-01-20 Dick Porter <dick@ximian.com>
9691 * support.cs: SeekableStreamReader fix from Sandor Dobos
9692 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
9693 chars are read. Fixes bug 70369.
9695 2005-01-20 Raja R Harinath <rharinath@novell.com>
9697 * cs-parser.jay (catch_clause): Simplify current_block handling
9700 2005-01-17 Miguel de Icaza <miguel@ximian.com>
9702 * convert.cs (ImplicitStandardConversionExists): Synchronize the
9703 code with ImplicitStandardConversion to handle the implicit
9704 conversion of method groups into valid delegate invocations.
9706 The problem is that in parameter handling we were using this code
9707 path. Fixes bug #64698
9709 2005-01-19 Raja R Harinath <rharinath@novell.com>
9711 * cs-parser.jay: Fix several infelicities.
9712 - Avoid assigning to the parser value stack. Code like
9713 '$3 = null' is unclean. Synthesize a value for the code block
9715 - Avoid using oob_stack for storing location information. Use ...
9716 (_mark_): ... this. New (empty) rule. Saves the current location
9718 (foreach_statement): Avoid using oob_stack for current_block
9719 handling. Use technique used in for_statement and
9720 using_statement. Synthesize a value for the code block to store
9721 additional intermediate information.
9723 2005-01-13 Miguel de Icaza <miguel@ximian.com>
9725 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
9726 of a different type is only allowed to private fields of a
9727 containing type, not on fields of a base class.
9729 See test-174.cs and error cs0122-9.cs
9731 2005-01-13 Raja R Harinath <rharinath@novell.com>
9733 Fix test-335.cs (bug #58126).
9734 * cs-parser.jay (argument): Split out non-expression parts of the
9735 rule into 'non_simple_argument'.
9736 (invocation_expression): Support parenthesized invocations with
9737 multiple arguments, and with single non-simple arguments.
9739 2005-01-13 Raja R Harinath <rharinath@novell.com>
9741 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
9744 2005-01-12 Raja R Harinath <rharinath@novell.com>
9746 Fix cs0038-1.cs, cs1640-6.cs.
9747 * ecore.cs (Expression.Resolve): Remove special-case for
9748 SimpleName in error-handling.
9749 (Expression.almostMatchedMembers): Relax access permission to
9751 (Expression.MemberLookupFailed): Handle duplicates in
9752 almostMatchedMembers list.
9753 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
9754 * expression.cs (New.DoResolve): Report CS1540 for more cases.
9755 * typemanager.cs (GetFullNameSignature): Use the MethodBase
9756 overload if the passed in MemberInfo is a MethodBase.
9758 2005-01-12 Marek Safar <marek.safar@seznam.cz>
9761 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
9762 for non-CAS & merge permission sets properly.
9764 2005-01-11 Raja R Harinath <rharinath@novell.com>
9766 Improve standard-compliance of simple name and member access
9767 resolution. Fixes bugs #52697, #57200, #67520, #69519.
9768 * ecore.cs (FullNamedExpression): New abstract base class
9769 for Namespaces and TypeExpressions.
9770 (ResolveFlags.SimpleName): Remove.
9771 (SimpleName): Remove support for dotted names.
9772 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
9773 DeclSpace.FindType and DeclSpace.LookupType.
9774 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
9775 (Expression.ExprClassName): Make member function.
9776 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
9777 a namespace. Remove creation of dotted "SimpleName"s.
9778 (MemberAccess.DoResolve): Likewise.
9779 * decl.cs (DeclSpace.Cache): Make private.
9780 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
9781 (DeclSpace.FindType): Update.
9782 (DeclSpace.LookupType): Move here from RootContext. Return a
9783 FullNamedExpression.
9784 * namespace.cs (Namespace): Derive from FullNamedExpression
9785 so that it can be part of expression resolution.
9786 (Namespace.Lookup): Return an FullNamedExpression.
9787 (NamespaceEntry.LookupAlias): Lookup aliases only in current
9789 * rootcontext.cs (NamespaceLookup): Remove.
9790 (LookupType): Move to DeclSpace.
9791 * attribute.cs (CheckAttributeType): Update.
9792 * doc.cs (FindDocumentedType): Remove allowAlias argument.
9793 (FindDocumentedTypeNonArray): Likewise.
9795 2005-01-11 Raja R Harinath <rharinath@novell.com>
9797 Fix cs0509.cs, cs1632.cs.
9798 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
9799 is the same as IsInterface.
9800 (TypeContainer.GetClassBases): Likewise.
9801 * statement.cs (LabeledStatement.ig): New field.
9802 (LabeledStatement.LabelTarget): Save ILGenerator which created the
9804 (LabeledStatement.DoEmit): Check that the label was created with
9805 the same ILGenerator.
9807 2005-01-10 Marek Safar <marek.safar@seznam.cz>
9810 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
9811 accessors to its properties.
9813 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
9814 from accessors to property.
9816 2005-01-10 Marek Safar <marek.safar@seznam.cz>
9819 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
9822 2005-01-08 Miguel de Icaza <miguel@ximian.com>
9824 * attribute.cs: Check for null and empty strings.
9826 I have lost another battle to Paolo.
9828 2005-01-07 Marek Safar <marek.safar@seznam.cz>
9831 * class.cs (PropertyMethod): Set Parent field in ctors.
9832 (SetMethod.InternalParameters): Add unsafe switch hack.
9833 Override MarkForDuplicationCheck where it is appropriate.
9835 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
9836 It says whether container allows members with the same name.
9838 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
9839 Removed is_method parameter.
9841 2005-01-06 Duncan Mak <duncan@ximian.com>
9843 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
9844 because the previous change led to incorrect reporting of CS1032
9845 ("Cannot define/undefine preprocessor symbols after first token in
9846 file"). Instead of using `tokens_seen' as the only flag that
9847 triggers CS1040, introduce `comments_seen'. This new flag is used
9848 to signify having seen comments on the current line, so it is
9849 unset after a newline.
9851 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
9853 * doc.cs : When searching for a type, find nested type too.
9854 This fixes bug #71040.
9856 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
9859 - Warn missing member comment on those classes which also does not
9860 have doc comments. Fixed bug #71041.
9861 - Don't warn missing doc comment on default constructor.
9864 2005-01-06 Duncan Mak <duncan@ximian.com>
9866 * cs-tokenizer.cs (xtoken): After handling traditional C-style
9867 comments, set `tokens_seen' to true. This allows us to detect
9868 misplaced preprocessor directives (i.e. not at the beginning of
9869 the a line, nor after whitespaces). In that case, report error
9870 CS1040. This fixes bug #56460.
9872 * cs-parser.jay (interface_member_declaration): Add checks for
9873 IsExplicitImpl, and report CS0541 error if an interface member is
9874 defined as an explicit interface declaration.
9876 2005-01-06 Marek Safar <marek.safar@seznam.cz>
9879 * class.cs (PropertyMethod): Set Parent field in ctors.
9880 (SetMethod.InternalParameters): Add unsafe switch hack.
9882 * decl.cs (MemberCore.Parent): Cannot be readonly.
9884 2005-01-06 Raja R Harinath <rharinath@novell.com>
9886 * decl.cs (DeclSpace.ResolveType): Remove.
9887 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
9888 Merge in code from ...
9889 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
9890 * class.cs, enum.cs: Update to changes.
9892 2005-01-06 Miguel de Icaza <miguel@ximian.com>
9894 * anonymous.cs: Ensure that we init the scope of our parent if it
9895 has not been initialized yet.
9897 2004-12-30 Duncan Mak <duncan@ximian.com>
9899 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
9900 if field.FieldBuilder is null. Fixes #70758.
9902 * convert.cs: Fixed some typos and updated some of the comments.
9903 (ImplicitStandardConversionExists):
9904 (TryImplicitIntConversion): If `target_type' is an interface and
9905 the type of `ic' implements this interface, return true or a new
9906 BoxedCast instead of null. This fixes #70468.
9908 2004-12-29 Duncan Mak <duncan@ximian.com>
9910 * expression.cs (Argument.Emit): Check that Expr is
9911 IMemoryLocation before casting to it, and report CS1510 otherwise.
9915 2004-12-21 Ben Maurer <bmaurer@ximian.com>
9917 * statement.cs (Block.ThisVariable): remove the recursion here, to
9918 make the --profile more sane.
9920 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
9922 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
9923 assembly, by JB Evain.
9925 2004-12-17 Raja R Harinath <rharinath@novell.com>
9927 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
9928 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
9929 "parent" refers to enclosing type/class. "base" refers to superclass.
9931 2004-12-17 Raja R Harinath <rharinath@novell.com>
9933 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
9934 Ensure that we only have GlobalAttributes.
9935 * attribute.cs (Attribute.Emit): Make non-virtual.
9936 (GlobalAttribute.Emit): Remove.
9937 (Attribute.Resolve): Make virtual.
9938 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
9939 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
9940 the argument. Don't create one.
9941 (Attribute.GetObsoleteAttribute): Likewise.
9942 (Attribute.GetClsCompliantAttributeValue): Likewise.
9943 * class.cs, decl.cs: Update to changes.
9945 2004-12-17 Marek Safar <marek.safar@seznam.cz>
9947 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
9949 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
9951 * statement.cs (Foreach.Resolve): Add error 186 report.
9953 2004-12-16 Marek Safar <marek.safar@seznam.cz>
9955 * expression.cs (Conditional.DoResolve): Add warning 429.
9957 * statement.cs (If.Resolve): Add warning 665.
9959 2004-12-16 Raja R Harinath <rharinath@novell.com>
9961 New invariant: RootContext.Tree.Types.NamespaceEntry == null
9962 except when in the parser, and in GlobalAttribute.
9963 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
9964 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
9965 RootContext.Tree.Types.NamespaceEntry once work is done.
9966 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
9967 and resets RootContext.Tree.Types.NamespaceEntry.
9969 2004-12-15 Marek Safar <marek.safar@seznam.cz>
9971 * cs-parser.jay: Don't create a block for every variable.
9973 2004-12-14 Miguel de Icaza <miguel@ximian.com>
9975 * location.cs: Provide extra information.
9977 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
9978 variables from the captured environment, it is the ldarg_0.
9980 2004-12-14 Marek Safar <marek.safar@seznam.cz>
9982 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
9985 * class.cs: Changed warning level for 169 to avoid developer
9986 displeasure from warning flooding. It will be changed back when they
9987 fix most of current BCL warnings.
9989 * RootContext.cs: Pushed default WarningLevel to 3.
9991 * statement.cs: Removed unused variable.
9993 2004-12-14 Marek Safar <marek.safar@seznam.cz>
9995 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
9996 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
9997 Add error 502 report.
9998 (StaticClass.DefineType): Add error 441 report.
9999 (Class.AllowedModifiersProp): New virtual property as temporary
10000 extension to AllowedModifiers.
10001 (Class.DefineType): Add error 418 report. Moved ModFlags check here
10002 to share implementation with StaticClass and don't call virtual
10005 * driver.cs (MainDriver): Add error 1558 test.
10007 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
10008 report. Moved error 36 test here.
10010 * statement.cs (Throw.Resolve): Add error 724 report.
10012 * typemanager.cs: Add out_attribute_type core type.
10014 2004-12-13 Marek Safar <marek.safar@seznam.cz>
10016 * class.cs (TypeContainer.VerifyClsCompliance): Add error
10018 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
10020 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
10023 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
10025 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
10026 Add error 3023 report.
10027 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
10029 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
10032 2004-12-12 John Luke <john.luke@gmail.com>
10034 * driver.cs (AddArgs): take -- into account when
10035 adding arguments, fixes bug 65710
10037 2004-12-12 Martin Baulig <martin@ximian.com>
10039 * expression.cs (Unary.TryReduceNegative): Added support for
10040 SByteConstant and ByteConstant.
10041 (Unary.Reduce): Check error values from TryReduceNegative().
10043 2004-12-10 Marek Safar <marek.safar@seznam.cz>
10045 * attributes.cs (Attribute.Resolve): Avoid multiple error report
10046 and report exception as error 182.
10048 2004-12-10 Raja R Harinath <rharinath@novell.com>
10050 * driver.cs (Main): Fix message when there are warnings.
10052 2004-12-09 Miguel de Icaza <miguel@ximian.com>
10054 * delegate.cs: Fixed my fix from yesterday, sorry about that.
10056 2004-12-09 Marek Safar <marek.safar@seznam.cz>
10058 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
10059 Reduced number of warnings.
10061 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
10063 2004-12-08 Miguel de Icaza <miguel@ximian.com>
10065 * driver.cs: Removed message.
10067 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
10069 2004-12-08 <vargaz@freemail.hu>
10071 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
10073 2004-12-08 Martin Baulig <martin@ximian.com>
10075 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
10076 instead of a CS3002 for properties and indexer.
10078 2004-12-08 Martin Baulig <martin@ximian.com>
10080 * decl.cs (MemberName.ToString): Make this work again.
10082 2004-12-08 Marek Safar <marek.safar@seznam.cz>
10084 * attribute.cs (Resolve): Add error 591 detection.
10086 * class.cs (FieldMember.Define): Add error 1547 detection.
10087 (Indexer.Define): Add error 620 detection.
10088 (Operator.Define): Add error 590 detection.
10090 * ecore.cs: Missing argument for error 79.
10092 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
10095 2004-12-07 Marek Safar <marek.safar@seznam.cz>
10098 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
10101 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
10103 * cs-parser.jay : handle doc comments on implicit/explicit operators.
10104 Some operator comments were suppressed.
10105 * doc.cs : Implicit/explicit operator name in doc comments are like
10106 "op_Explicit(type)~returnType", so added suffix handling.
10108 2004-12-07 Martin Baulig <martin@ximian.com>
10111 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
10112 (MemberCore.GetClsCompliantAttributeValue): Likewise.
10113 (DeclSpace.ec): New protected field; store the EmitContext here.
10114 (DeclSpace.EmitContext): New public property; moved here from
10116 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
10119 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
10120 (Enum.Emit): Don't create a new EmitContext.
10122 * delegate.cs (Delegate.DefineType): Always create the
10125 * iterators.cs (Iterators.DefineIterator): Create a new
10126 EmitContext and store it in `ec'.
10128 2004-08-24 Martin Baulig <martin@ximian.com>
10131 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
10132 this for accessibility checks.
10133 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
10134 IsNestedFamilyAccessible.
10135 (TypeManager.IsSubclassOf): New method, do what the name actually
10138 2004-12-06 Raja R Harinath <rharinath@novell.com>
10140 Fix crash on cs0657-17.cs.
10141 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10142 Use RootContext.Tree.Types, not 'new RootTypes ()'.
10143 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
10144 the case where the NamespaceEntry gets overwritten.
10146 2004-12-06 Marek Safar <marek.safar@seznam.cz>
10148 Fixed #69195, #56821
10149 * ecore.cs (ResolveBoolean): Tiny refactoring.
10151 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
10152 of right expression resolving when left is false constant and
10153 operator is LogicalAnd OR true constant and operator is LogicalOr.
10155 * statement.cs (ResolveUnreachable): Always reports warning.
10157 2004-12-05 Miguel de Icaza <miguel@ximian.com>
10159 * class.cs: Distinguish between 1721 and 1722 (just a little help
10160 for the programmer).
10162 2004-12-03 Miguel de Icaza <miguel@ximian.com>
10164 * delegate.cs: Only allow this on new versions of the language.
10166 2004-12-02 Duncan Mak <duncan@ximian.com>
10168 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
10170 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
10171 here as a static method. Take an additional bool out parameter
10172 `must_do_cs1540_check' for signaling to InstanceResolve.
10173 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
10174 member field from PropertyExpr class and made it an argument of
10175 the method instead.
10176 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
10177 check for MarshalByRefObject, and report CS0122 instead of CS1540.
10178 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
10179 and `remove_accessor' as well as InstanceResolve: report CS0122
10184 2004-12-03 Raja R Harinath <rharinath@novell.com>
10186 Fix test-327.cs, test-328.cs, and put in early infrastructure
10187 for eventually fixing #52697.
10188 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
10189 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
10190 from other methods.
10191 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
10192 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
10193 (VerifyUsing, error246): Update.
10194 * rootcontext.cs (RootContext.NamespaceLookup): Just use
10195 'NamespaceEntry.LookupNamespaceOrType'.
10197 2004-12-03 Martin Baulig <martin@ximian.com>
10199 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10200 method as our child, call AnonymousMethod.Compatible() on it.
10202 2004-12-03 Raja R Harinath <rharinath@novell.com>
10204 Disable XML documentation support in 'basic' profile.
10205 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
10206 Redirect XmlElement to System.Object.
10207 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
10208 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
10209 * mcs.exe.sources: Add doc-bootstrap.cs.
10210 * doc-bootstrap.cs: New file. Contains empty stub implementation
10213 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
10215 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
10216 comments are allowed.
10218 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10220 * delegate.cs: Add checks for subtypes in paramaters and return values
10221 in VerifyMethod () to add support for Covariance/Contravariance
10224 2004-12-02 Miguel de Icaza <miguel@ximian.com>
10226 * report.cs: Remove extra closing parenthesis.
10228 * convert.cs (Error_CannotImplicitConversion): If the name of the
10229 types are the same, provide some extra information.
10231 * class.cs (FieldBase): Use an unused bit field from the field to
10232 encode the `has_offset' property from the FieldMember. This saves
10233 a couple of Ks on bootstrap compilation.
10235 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
10236 method as our child, return the AnonymousMethod resolved
10239 * expression.cs (New.DoResolve): Allow return values from
10240 NewDelegate to also include AnonymousMethods.
10244 2004-12-02 Marek Safar <marek.safar@seznam.cz>
10247 * attribute.cs (Resolve): Improved implementation of params
10248 attribute arguments.
10250 * support.cs (ParameterData): Add HasParams to be faster.
10252 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
10254 all things are for /doc support:
10256 * doc.cs: new file that supports XML documentation generation.
10257 * mcs.exe.sources: added doc.cs.
10259 Handle /doc command line option.
10260 Report error 2006 instead of 5 for missing file name for /doc.
10261 Generate XML documentation when required, after type resolution.
10263 Added support for picking up documentation (/// and /** ... */),
10264 including a new XmlCommentState enumeration.
10266 Added lines to fill Documentation element for field, constant,
10267 property, indexer, method, constructor, destructor, operator, event
10268 and class, struct, interface, delegate, enum.
10269 Added lines to warn incorrect comment.
10271 Added Documentation field (passed only when /doc was specified).
10273 Added DocComment, DocCommentHeader, GenerateDocComment() and
10274 OnGenerateDocComment() and some supporting private members for
10275 /doc feature to MemberCore.
10277 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
10279 Added overriden DocCommentHeader.
10281 Added overriden DocCommentHeader and GenerateDocComment().
10283 2004-12-01 Miguel de Icaza <miguel@ximian.com>
10285 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
10286 unwrapping the enumeration values, chain to
10287 DoConstantNumericPromotions again, so we can promote things to the
10288 fundamental types (takes care of enums that are bytes, sbytes).
10292 2004-12-01 Raja R Harinath <rharinath@novell.com>
10294 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
10295 Fix long-standing bug in type-lookup. Use FindType instead of
10296 LookupType when ec.ResolvingTypeTree.
10297 (Attribute.ResolveType, Attribute.Resolve)
10298 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
10300 (Attributes.Search): Remove internal version. Update.
10301 (Attributes.SearchMulti): Update.
10302 (Attributes.GetClsCompliantAttribute): Remove.
10303 (Attributes.GetIndexerNameAttribute): Remove.
10304 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
10305 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
10306 * class.cs (Indexer.Define): Likewise.
10308 2004-12-01 Marek Safar <marek.safar@seznam.cz>
10311 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
10312 MarshallByReference members access.
10314 * expression.cs: Use CheckMarshallByRefAccess;
10315 Better error CS0197 message.
10317 * report.cs: Print whole related error message.
10319 2004-11-30 Raja R Harinath <rharinath@novell.com>
10321 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
10322 the current directory to help debugging.
10324 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10326 * class (GetClassBases): Better error 60 report.
10327 (EventProperty): Disabled warning 67 detection.
10329 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10332 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
10334 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
10337 2004-11-29 Marek Safar <marek.safar@seznam.cz>
10340 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
10342 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
10344 2004-11-26 Miguel de Icaza <miguel@ximian.com>
10346 * attribute.cs (Attribute.Resolve): Refine error reporting and
10347 report a cs0117 if the identifier does not exist, to distinguish
10348 from 0617 which is a miss-use of the actual identifier.
10350 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
10351 between cs0070 and cs0079.
10353 * class.cs (MemberBase.DoDefine): When reporting a wrong
10354 accessibility level, we use MethodCore to compare instead of
10355 Method (this was a regression in some refactoring effort).
10357 So now we correctly report cs0056 again.
10359 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
10360 testing the target_type (which was known to be object_type) and
10361 not the source type (which is anonymous_method).
10363 Fixed reporting of error cs1660.
10365 * expression.cs (UserCast.Source): Expose the underlying cast.
10367 * statement.cs (Switch.SwitchGoverningType): Sort the list of
10368 allowed types to find a match to int32 first (most common).
10370 In addition, it ignores any ImplicitUserConversions that did an
10371 internal implicit conversion (as the switch statement allows only
10372 one integral conversion to exist).
10374 * class.cs (PartialContainer.Create): rename `name' to
10375 `member_name' for clarity. Then replace the string calls with a
10376 call to MemberName.GetPartialName, as now using
10377 MemberName.ToString is an error (this is due to the side effects
10378 it had, that were fixed in the past).
10380 This will restore the error reporting on a number of partial class
10381 errors that were missusing this (and getting an exception as a
10382 results, which is now just a plain textual warning, because
10383 yyparse debug output would crash otherwise).
10385 2004-11-26 Raja R Harinath <rharinath@novell.com>
10387 * Makefile (PROGRAM_INSTALL_DIR): Remove.
10389 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10391 * rootcontext.cs (LookupType): Make sure to cache lookups that
10392 don't give us a negative result. This saves about 5% of corlib
10395 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10397 * report.cs (AbstractMessage.Print): messages are sent to stderr
10399 * class.cs (TypeContainer.GetClassBases): It is an error to have a
10400 non-interface in the list of interfaces (at this point, either
10401 parent was properly set, or a base class is being listed in the
10402 interfaces section).
10404 This flags error 1722, and resolves the crash from bug 69259.
10406 2004-11-25 Ben Maurer <bmaurer@ximian.com>
10408 * statement.cs (Using.EmitExpressionFinally): make this work right
10409 for valuetypes. Fixes 69926.
10411 2004-11-25 Miguel de Icaza <miguel@ximian.com>
10413 * const.cs (Const.ChangeType): Cope with the "0 literal can be
10414 converted to an enum" here, before we try to change the underlying
10415 type. This code exists, but it is a different code path than the
10416 one used while encoding constants.
10418 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
10419 old bug: when converting from the null literal to a pointer,
10420 return an EmptyCast, not the NullLiteral.
10422 This fixes #69921, the recent null_type changes probably made this
10423 bug more prominent.
10425 (ImplicitReferenceConversionExists): In addition, resynchronized
10426 the code here, so it matches the same code in
10427 ImplicitReferenceConversionExists for the `from any class-type S
10428 to any interface-type T'.
10431 2004-11-25 Marek Safar <marek.safar@seznam.cz>
10433 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
10435 2004-11-24 Miguel de Icaza <miguel@ximian.com>
10437 * cs-parser.jay: Use verbosity accordingly.
10439 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10441 * expression.cs (Unary.ResolveOperator): Do not report warning;
10442 AddressOf reads from variable.
10444 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
10446 2004-11-24 Marek Safar <marek.safar@seznam.cz>
10450 * attribute.cs (Attributable): Removed CheckTargets.
10451 (Attributes.Emit): Explicit attribute targets are tested here.
10453 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
10454 not enabled for interfaces.
10456 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
10457 (GetAssemblyName): Ouch next bug there.
10459 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10461 * expression.cs: Error 275 added.
10463 2004-11-23 Marek Safar <marek.safar@seznam.cz>
10465 Fix bug #69177 (Implemented decimal constant support)
10467 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
10468 (BinaryFold): Add DecimalConstant.
10470 * const.cs (Define): Decimal constant
10472 (ChangeType): Add decimal type handling.
10473 (LookupConstantValue): Don't set value for decimal type but
10474 emit DecimalConstantAttribute. Needed for constant optimization.
10476 * constant.cs (ToDecimal): New method.
10477 (ConvertToDecimal): New method.
10478 (IntConstant): Implemented ConvertToDecimal.
10479 (DecimalConstant.Emit): Emit optimized version for decimals in
10482 * expression.cs (ResolveOperator): Changed order of constant
10483 reduction to work correctly with native types which have
10484 overloaded operators.
10485 (ResolveMemberAccess): Extract constant value from attribute
10488 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
10490 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
10491 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
10492 (ChangeType): Decimal is special.
10493 (TypeToCoreType): Add decimal type.
10495 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10497 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
10500 2004-11-22 Marek Safar <marek.safar@seznam.cz>
10502 * class.cs (EventField.ApplyAttributeBuilder): Fix error
10505 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10507 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
10509 * pending.cs (PendingImplementation): Grab only interfaces.
10511 2004-11-19 Marek Safar <marek.safar@seznam.cz>
10513 * statement.cs (ForeachHelperMethods): Add location member and
10514 error 202 detection.
10516 2004-11-19 Raja R Harinath <rharinath@novell.com>
10518 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
10519 automatically handled by executable.make.
10520 (PROGRAM): Make profile-specific.
10522 2004-11-18 Marek Safar <marek.safar@seznam.cz>
10524 * expression.cs (DoResolveBase): Fixed wrong warning for out
10527 2004-11-18 Martin Baulig <martin@ximian.com>
10529 Merged latest changes into gmcs. Please keep this comment in
10530 here, it makes it easier for me to see what changed in MCS since
10531 the last time I merged.
10533 2004-11-17 Raja R Harinath <rharinath@novell.com>
10535 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
10536 (TypeHandle.GetMemberCache): New.
10537 (TypeHandle.TypeHandle): Update.
10538 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
10539 (TypeManager.LookupParentInterfacesCache):
10540 Rename from LookupInterfaceCache. Optimize slightly.
10541 (TypeManager.MemberLookup_FindMembers): Update.
10542 * decl.cs (MemberCache.MemberCache): Set Container to null in the
10543 multi-type variant.
10544 (AddCacheContents): Rename from AddHashtable.
10545 * class.cs (TypeContainer.parent_container): Remove.
10546 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
10547 (TypeContainer.DoDefineMembers): Don't initialize it.
10548 Update to name changes.
10550 2004-11-17 Miguel de Icaza <miguel@ximian.com>
10552 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
10553 that factors the code to check access modifiers on override.
10555 (PropertyBase): Use the code here.
10557 Patch from Lluis S'anchez, fixes bug #69361.
10559 2004-11-15 Miguel de Icaza <miguel@ximian.com>
10561 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
10562 routine that is used to report the use of a captured variable
10563 whose address has been taken.
10565 There are two checks: one when variables are being captured and
10566 the other check is when the address of a variable is taken.
10568 (because an anonymous methods might be resolved before *or* after
10569 the address has been taken) and
10571 * expression.cs (Conditional.DoResolve): Remove the special
10572 casing that Martin added to trueExpr and falseExpr being both
10573 NullLiteral. We get the right behavior now just by introducing
10574 the null_type into the compiler.
10576 * convert.cs (ExplicitConversion): Change the code to use
10577 null_type instead of testing `expr is NullLiteral'.
10578 (ImplicitConversionStandard): use null_type too.
10579 (ImplicitReferenceConversionExists): use null_type too.
10580 (ImplicitReferenceConversion): use null_type too.
10582 * literal.cs: The type of `NullLiteral' is now null_type instead
10584 (Resolve): Set the type here.
10586 * typemanager.cs: Introduce null_type.
10588 2004-11-17 Martin Baulig <martin@ximian.com>
10590 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
10591 direction, like FindMembers() does. Fixes #69546, testcase is in
10594 2004-11-16 Martin Baulig <martin@ximian.com>
10596 This is based on a patch from Marek Safar, see bug #69082.
10597 Fixes bugs #63705 and #67130.
10599 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
10600 method; create a MemberCache for an interface type and cache the
10603 * decl.cs (IMemberContainer.ParentContainer): Removed.
10604 (IMemberContainer.ParentCache): New property.
10605 (MemberCache.SetupCacheForInterface): Removed.
10606 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
10607 to create a cache for an interface's "parent".
10609 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
10612 2004-11-16 Martin Baulig <martin@ximian.com>
10614 Merged back from gmcs; these changes already went into gmcs a
10615 couple of weeks ago.
10618 (TypeManager.AddUserType): Removed the `ifaces' argument.
10619 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
10621 (TypeManager.AddUserInterface): Removed.
10622 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
10624 (TypeManager.GetInterfaces): Likewise.
10625 (TypeManager.GetExplicitInterfaces): Likewise.
10627 * ecore.cs (TypeExpr.GetInterfaces): Removed.
10629 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
10630 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
10632 2004-11-14 Ben Maurer <bmaurer@ximian.com>
10634 * statement.cs: Avoid adding bools to a hashtable.
10636 2004-11-07 Miguel de Icaza <miguel@ximian.com>
10638 * expression.cs (Invocation.OverloadResolve): Flag error if we are
10639 calling an unsafe method from a safe location.
10641 2004-11-06 Marek Safar <marek.safar@seznam.cz>
10644 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
10646 2004-11-06 Miguel de Icaza <miguel@ximian.com>
10648 * namespace.cs (VerifyUsing): use GetPartialName instead of
10651 2004-11-05 Miguel de Icaza <miguel@ximian.com>
10653 * statement.cs (Return.Resolve): Fix regression in typo: if
10654 `in_exc', we have to request a NeedReturnLabel, this was a typo
10655 introduced in the anonymous method check-in. Fixes #69131.
10657 * Indexers were using the ShortName when defining themselves,
10658 causing a regression in the compiler bootstrap when applying the
10659 patch from 2004-11-02 (first part), now they use their full name
10660 and the bug is gone.
10662 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
10664 * driver.cs: Strip the path from the names of embedded resources. Fixes
10667 2004-11-04 Raja R Harinath <rharinath@novell.com>
10669 Fix error message regression: cs0104-2.cs.
10670 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
10671 (AliasEntry.Resolve): Update.
10672 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
10674 (RootContext.LookupType): Update.
10676 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
10678 * cs-parser.jay: Add support for handling accessor modifiers
10679 * class: Add support port accessor modifiers and error checking,
10680 define PropertyMethod.Define as virtual (not abstract anymore)
10681 * ecore.cs: Add checking for proeprties access with access modifiers
10682 * iterators.cs: Modify Accessor constructor call based in the modified
10684 2004-11-02 Ben Maurer <bmaurer@ximian.com>
10686 * expression.cs (StringConcat): Handle being called twice,
10687 as when we have a concat in a field init with more than two
10690 2004-11-02 Miguel de Icaza <miguel@ximian.com>
10692 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
10693 special case explicit implementations, we should always produce
10694 the .property or .event declaration.
10696 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
10697 since it will not return correct data if people use this
10698 unresolved in the presence of using statements (see test-313).
10700 * class.cs (MethodData.Define): If we are an explicit interface
10701 implementation, set the method name to the full name of the
10702 interface plus the name of the method.
10704 Notice that using the method.MethodName.GetFullName() does not
10705 work, as it will only contain the name as declared on the source
10706 file (it can be a shorthand in the presence of using statements)
10707 and not the fully qualifed type name, for example:
10711 class D : ICloneable {
10712 object ICloneable.Clone () {
10716 Would produce a method called `ICloneable.Clone' instead of
10717 `System.ICloneable.Clone'.
10719 * namespace.cs (Alias.Resolve): Use GetPartialName.
10721 2004-11-01 Marek Safar <marek.safar@seznam.cz>
10723 * cs-parser.jay: Add error 1055 report.
10725 2004-11-01 Miguel de Icaza <miguel@ximian.com>
10727 * assign.cs (Assign.DoResolve): Only do the transform of
10728 assignment into a New if the types are compatible, if not, fall
10729 through and let the implicit code deal with the errors and with
10730 the necessary conversions.
10732 2004-11-01 Marek Safar <marek.safar@seznam.cz>
10734 * cs-parser.jay: Add error 1031 report.
10736 * cs-tokenizer.cs: Add location for error 1038.
10738 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10740 * cs-parser.jay: Add error 1016 report.
10742 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10744 * cs-parser.jay: Add errors 1575,1611 report.
10746 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10748 * cs-parser.jay: Add error 1001 report.
10750 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10753 * attribute.cs (GetMarshal): Add method argument for
10754 caller identification.
10756 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
10757 agument for GetMarshal and RuntimeMissingSupport.
10759 2004-10-31 Marek Safar <marek.safar@seznam.cz>
10761 * attribute.cs (ExtractSecurityPermissionSet): Removed
10762 TypeManager.code_access_permission_type.
10764 * typemanager.cs: Removed TypeManager.code_access_permission_type.
10766 2004-10-27 Miguel de Icaza <miguel@ximian.com>
10768 * expression.cs (LocalVariableReference.DoResolveLValue): Check
10769 for obsolete use of a variable here. Fixes regression on errors
10770 cs0619-25 and cs0619-26.
10772 2004-10-27 Marek Safar <marek.safar@seznam.cz>
10774 Fix #62358, implemented security attribute encoding.
10776 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
10777 Tests permitted SecurityAction for assembly or other types.
10778 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
10779 data from SecurityPermissionAttribute to PermisionSet class.
10781 * class.cs (ApplyAttributeBuilder): Added special handling
10782 for System.Security.Permissions.SecurityAttribute based types.
10784 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
10785 special handling for System.Security.Permissions.SecurityAttribute
10788 * enum.cs (ApplyAttributeBuilder): Added special handling
10789 for System.Security.Permissions.SecurityAttribute based types.
10791 * parameter.cs (ApplyAttributeBuilder): Added special handling
10792 for System.Security.Permissions.SecurityAttribute based types.
10794 * rootcontext.cs: Next 2 core types.
10796 * typemanager.cs (TypeManager.security_permission_attr_type):
10797 Built in type for the SecurityPermission Attribute.
10798 (code_access_permission_type): Build in type.
10800 2004-10-17 Miguel de Icaza <miguel@ximian.com>
10802 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
10803 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
10804 all of this information into
10805 EmitContext.EmitCapturedVariableInstance.
10807 * codegen.cs (EmitCapturedVariableInstance): move here the
10808 funcionality of emitting an ldarg.0 in the presence of a
10809 remapping. This centralizes the instance emit code.
10811 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
10812 then emit a load of this: it means that we have reached the
10813 topmost ScopeInfo: the one that contains the pointer to the
10814 instance of the class hosting the anonymous method.
10816 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
10817 captures to the topmost CaptureContext.
10819 2004-10-12 Miguel de Icaza <miguel@ximian.com>
10821 * expression.cs (LocalVariableReference): Move the knowledge about
10822 the iterators into codegen's EmitCapturedVariableInstance.
10824 2004-10-11 Miguel de Icaza <miguel@ximian.com>
10826 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
10827 all code paths return a value from an anonymous method (it is the
10828 same as the 161 error, but for anonymous methods).
10830 2004-10-08 Miguel de Icaza <miguel@ximian.com>
10832 The introduction of anonymous methods in the compiler changed
10833 various ways of doing things in the compiler. The most
10834 significant one is the hard split between the resolution phase
10835 and the emission phases of the compiler.
10837 For instance, routines that referenced local variables no
10838 longer can safely create temporary variables during the
10839 resolution phase: they must do so from the emission phase,
10840 since the variable might have been "captured", hence access to
10841 it can not be done with the local-variable operations from the runtime.
10845 (Block.Flags): New flag `IsTopLevel' to indicate that this block
10846 is a toplevel block.
10848 (ToplevelBlock): A new kind of Block, these are the blocks that
10849 are created by the parser for all toplevel method bodies. These
10850 include methods, accessors and anonymous methods.
10852 These contain some extra information not found in regular blocks:
10853 A pointer to an optional CaptureContext (for tracking captured
10854 local variables and parameters). A pointer to the parent
10857 (Return.Resolve): Catch missmatches when returning a value from an
10858 anonymous method (error 1662).
10859 Invoke NeedReturnLabel from the Resolve phase instead of the emit
10862 (Break.Resolve): ditto.
10864 (SwitchLabel): instead of defining the labels during the
10865 resolution phase, we now turned the public ILLabel and ILLabelCode
10866 labels into methods called GetILLabelCode() and GetILLabel() that
10867 only define the label during the Emit phase.
10869 (GotoCase): Track the SwitchLabel instead of the computed label
10870 (its contained therein). Emit the code by using
10871 SwitchLabel.GetILLabelCode ().
10873 (LocalInfo.Flags.Captured): A new flag has been introduce to track
10874 whether the Local has been captured or not.
10876 (LocalInfo.IsCaptured): New property, used to tell whether the
10877 local has been captured.
10879 * anonymous.cs: Vastly updated to contain the anonymous method
10882 The main classes here are: CaptureContext which tracks any
10883 captured information for a toplevel block and ScopeInfo used to
10884 track the activation frames for various local variables.
10886 Each toplevel block has an optional capture context associated
10887 with it. When a method contains an anonymous method both the
10888 toplevel method and the anonymous method will create a capture
10889 context. When variables or parameters are captured, they are
10890 recorded on the CaptureContext that owns them, for example:
10894 MyDelegate d = delegate {
10899 Here `a' will be recorded as captured on the toplevel
10900 CapturedContext, the inner captured context will not have anything
10901 (it will only have data if local variables or parameters from it
10902 are captured in a nested anonymous method.
10904 The ScopeInfo is used to track the activation frames for local
10905 variables, for example:
10907 for (int i = 0; i < 10; i++)
10908 for (int j = 0; j < 10; j++){
10909 MyDelegate d = delegate {
10914 At runtime this captures a single captured variable `i', but it
10915 captures 10 different versions of the variable `j'. The variable
10916 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
10917 recorded on a child.
10919 The toplevel ScopeInfo will also track information like the `this'
10920 pointer if instance variables were referenced (this is necessary
10921 as the anonymous method lives inside a nested class in the host
10922 type of the method).
10924 (AnonymousMethod): Expanded to track the Toplevel, implement
10925 `AnonymousMethod.Compatible' to tell whether an anonymous method
10926 can be converted to a target delegate type.
10928 The routine now also produces the anonymous method content
10930 (AnonymousDelegate): A helper class that derives from
10931 DelegateCreation, this is used to generate the code necessary to
10932 produce the delegate for the anonymous method that was created.
10934 * assign.cs: API adjustments for new changes in
10935 Convert.ImplicitStandardConversionExists.
10937 * class.cs: Adjustments to cope with the fact that now toplevel
10938 blocks are of type `ToplevelBlock'.
10940 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
10941 insteda of standard blocks.
10943 Flag errors if params arguments are passed to anonymous methods.
10945 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
10946 `CurrentAnonymousMethod' which points to the current Anonymous
10947 Method. The variable points to the AnonymousMethod class that
10948 holds the code being compiled. It is set in the new EmitContext
10949 created for the anonymous method.
10951 (EmitContext.Phase): Introduce a variable and an enumeration to
10952 assist in enforcing some rules about when and where we are allowed
10953 to invoke certain methods (EmitContext.NeedsReturnLabel is the
10954 only one that enfonces this right now).
10956 (EmitContext.HaveCaptureInfo): new helper method that returns
10957 whether we have a CapturedContext initialized.
10959 (EmitContext.CaptureVariable): New method used to register that a
10960 LocalInfo must be flagged for capturing.
10962 (EmitContext.CapturedParameter): New method used to register that a
10963 parameters must be flagged for capturing.
10965 (EmitContext.CapturedField): New method used to register that a
10966 field must be flagged for capturing.
10968 (EmitContext.HaveCapturedVariables,
10969 EmitContext.HaveCapturedFields): Return whether there are captured
10970 variables or fields.
10972 (EmitContext.EmitMethodHostInstance): This is used to emit the
10973 instance for the anonymous method. The instance might be null
10974 (static methods), this (for anonymous methods that capture nothing
10975 and happen to live side-by-side with the current method body) or a
10976 more complicated expression if the method has a CaptureContext.
10978 (EmitContext.EmitTopBlock): Routine that drives the emission of
10979 code: it will first resolve the top block, then emit any metadata
10980 and then emit the code. The split is done so that we can extract
10981 any anonymous methods and flag any captured variables/parameters.
10983 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
10984 during this phase, the ILGenerator should not be used as labels
10985 and local variables declared here might not be accessible to any
10986 code that is part of an anonymous method.
10988 Exceptions to this include the temporary variables that are
10989 created by some statements internally for holding temporary
10992 (EmitContext.EmitMeta): New routine, in charge of emitting all the
10995 (EmitContext.TemporaryReturn): This method is typically called
10996 from the Emit phase, and its the only place where we allow the
10997 ReturnLabel to be defined other than the EmitMeta. The reason is
10998 that otherwise we would have to duplicate a lot of logic in the
10999 Resolve phases of various methods that today is on the Emit
11002 (EmitContext.NeedReturnLabel): This no longer creates the label,
11003 as the ILGenerator is not valid during the resolve phase.
11005 (EmitContext.EmitThis): Extended the knowledge in this class to
11006 work in anonymous methods in addition to iterators.
11008 (EmitContext.EmitCapturedVariableInstance): This emits whatever
11009 code is necessary on the stack to access the instance to a local
11010 variable (the variable will be accessed as a field).
11012 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
11013 EmitContext.EmitAddressOfParameter): Routines to support
11014 parameters (not completed at this point).
11016 Removals: Removed RemapLocal and RemapLocalLValue. We probably
11017 will also remove the parameters.
11019 * convert.cs (Convert): Define a `ConstantEC' which points to a
11020 null. This is just to prefity some code that uses
11021 ImplicitStandardConversion code and do not have an EmitContext
11024 The idea is to flag explicitly that at that point in time, it is
11025 known that the conversion will not trigger the delegate checking
11026 code in implicit conversions (which requires a valid
11029 Everywhere: pass new EmitContext parameter since
11030 ImplicitStandardConversionExists now requires it to check for
11031 anonymous method conversions.
11033 (Convert.ImplicitStandardConversionExists): If the type of an
11034 expression is the anonymous_method_type, and the type is a
11035 delegate, we invoke the AnonymousMethod.Compatible method to check
11036 whether an implicit conversion is possible.
11038 (Convert.ImplicitConversionStandard): Only do implicit method
11039 group conversions if the language level is not ISO_1.
11041 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
11042 MethodInfo for the Invoke method. used by Delegate and
11045 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
11046 method conversions if the target type is a delegate.
11048 Removed extra debugging nops.
11050 (LocalVariableReference): Turn the `local_info' into a public
11053 Add `prepared' field, the same hack used for FieldExprs to cope
11054 with composed assignments, as Local variables do not necessarily
11055 operate purely on the stack as they used to: they can be captured
11058 Add `temp' for a temporary result, like fields.
11060 Refactor DoResolve and DoResolveLValue into DoResolveBase.
11062 It now copes with Local variables that are captured and emits the
11063 proper instance variable to load it from a field in the captured
11066 (ParameterReference.DoResolveBase): During the resolve phase,
11067 capture parameters if we are in an anonymous method.
11069 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
11070 anonymous method, use the EmitContext helper routines to emit the
11071 parameter reference.
11073 * iterators.cs: Set RemapToProxy to true/false during the
11076 * parameters.cs (GetParameterByName): New helper method.
11078 * typemanager.cs (anonymous_method_type) a new type that
11079 represents an anonyous method. This is always an internal type,
11080 used as a fencepost to test against the anonymous-methodness of an
11083 2004-10-20 Marek Safar <marek.safar@seznam.cz>
11085 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
11087 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
11089 2004-10-18 Martin Baulig <martin@ximian.com>
11091 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
11092 `Type' directly, but call ResolveType() on it.
11093 (Catch.Resolve): Likewise.
11094 (Foreach.Resolve): Likewise.
11096 2004-10-18 Martin Baulig <martin@ximian.com>
11098 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
11099 `Type' directly, but call ResolveType() on it.
11100 (Probe.DoResolve): Likewise.
11101 (ArrayCreation.LookupType): Likewise.
11102 (TypeOf.DoResolve): Likewise.
11103 (SizeOf.DoResolve): Likewise.
11105 2004-10-18 Martin Baulig <martin@ximian.com>
11107 * expression.cs (Invocation.BetterFunction): Put back
11108 TypeManager.TypeToCoreType().
11110 2004-10-18 Raja R Harinath <rharinath@novell.com>
11112 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
11115 2004-10-18 Martin Baulig <martin@ximian.com>
11117 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
11118 `Type' directly, but call ResolveType() on it.
11120 2004-10-18 Martin Baulig <martin@ximian.com>
11122 * class.cs (FieldMember.Define): Don't access the TypeExpr's
11123 `Type' directly, but call ResolveType() on it.
11124 (MemberBase.DoDefine): Likewise.
11126 * expression.cs (New.DoResolve): Don't access the TypeExpr's
11127 `Type' directly, but call ResolveType() on it.
11128 (ComposedCast.DoResolveAsTypeStep): Likewise.
11130 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
11131 `Type' directly, but call ResolveType() on it.
11133 2004-10-17 John Luke <john.luke@gmail.com>
11135 * class.cs (Operator.GetSignatureForError): use CSharpName
11137 * parameter.cs (Parameter.GetSignatureForError): Returns
11138 correct name even if was not defined.
11140 2004-10-13 Raja R Harinath <rharinath@novell.com>
11143 * class.cs (TypeContainer.EmitContext): New property.
11144 (DefineNestedTypes): Create an emitcontext for each part.
11145 (MethodCore.DoDefineParameters): Use container's emitcontext.
11146 Pass type array to InternalParameters.
11147 (MemberBase.DoDefine): Use container's emitcontext.
11148 (FieldMember.Define): Likewise.
11149 (Event.Define): Likewise.
11150 (SetMethod.GetParameterInfo): Change argument to EmitContext.
11151 Pass type array to InternalParameters.
11152 (SetIndexerMethod.GetParameterInfo): Likewise.
11153 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
11154 * delegate.cs (Define): Pass emitcontext to
11155 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
11156 array to InternalParameters.
11157 * expression.cs (ParameterReference.DoResolveBase): Pass
11158 emitcontext to GetParameterInfo.
11159 (ComposedCast.DoResolveAsTypeStep): Remove check on
11160 ec.ResolvingTypeTree.
11161 * parameter.cs (Parameter.Resolve): Change argument to
11162 EmitContext. Use ResolveAsTypeTerminal.
11163 (Parameter.GetSignature): Change argument to EmitContext.
11164 (Parameters.ComputeSignature): Likewise.
11165 (Parameters.ComputeParameterTypes): Likewise.
11166 (Parameters.GetParameterInfo): Likewise.
11167 (Parameters.ComputeAndDefineParameterTypes): Likewise.
11168 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
11169 * support.cs (InternalParameters..ctor): Remove variant that takes
11171 * typemanager.cs (system_intptr_expr): New.
11172 (InitExpressionTypes): Initialize it.
11174 2004-10-12 Chris Toshok <toshok@ximian.com>
11176 * cs-parser.jay: fix location for try_statement and catch_clause.
11178 2004-10-11 Martin Baulig <martin@ximian.com>
11180 * report.cs: Don't make --fatal abort on warnings, we have
11181 -warnaserror for that.
11183 2004-10-07 Raja R Harinath <rharinath@novell.com>
11185 More DeclSpace.ResolveType avoidance.
11186 * decl.cs (MemberCore.InUnsafe): New property.
11187 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
11188 with newly created EmitContext.
11189 (FieldMember.Define): Likewise.
11190 * delegate.cs (Delegate.Define): Likewise.
11191 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
11192 only if normal name-lookup fails.
11193 (TypeExpr.DoResolve): Enable error-checking.
11194 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
11195 (SizeOf.DoResolve): Likewise.
11196 (ComposedCast.DoResolveAsTypeStep): Likewise.
11197 (StackAlloc.DoResolve): Likewise.
11198 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
11199 (Block.Unsafe): New property.
11200 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
11201 (Unsafe): Set 'unsafe' flag of contained block.
11202 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
11203 (Fixed.Resolve): Likewise.
11204 (Catch.Resolve): Likewise.
11205 (Using.ResolveLocalVariableDecls): Likewise.
11206 (Foreach.Resolve): Likewise.
11208 2004-10-05 John Luke <john.luke@gmail.com>
11210 * cs-parser.jay: add location to error CS0175
11212 2004-10-04 Miguel de Icaza <miguel@ximian.com>
11214 * ecore.cs (Expression.Constantity): Add support for turning null
11217 * const.cs (Const.Define): Allow constants to be reference types
11218 as long as the value is Null.
11220 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
11222 * namespace.cs (NamespaceEntry.Using): No matter which warning
11223 level is set, check if this namespace name has already been added.
11225 2004-10-03 Ben Maurer <bmaurer@ximian.com>
11227 * expression.cs: reftype [!=]= null should always use br[true,false].
11230 2004-10-03 Marek Safar <marek.safar@seznam.cz>
11233 * attribute.cs: Enum conversion moved to
11234 GetAttributeArgumentExpression to be applied to the all
11237 2004-10-01 Raja R Harinath <rharinath@novell.com>
11239 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
11240 * class.c (TypeContainer.DefineType): Flag error if
11241 base types aren't accessible due to access permissions.
11242 * decl.cs (DeclSpace.ResolveType): Move logic to
11243 Expression.ResolveAsTypeTerminal.
11244 (DeclSpace.ResolveTypeExpr): Thin layer over
11245 Expression.ResolveAsTypeTerminal.
11246 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
11247 Refactor code into NestedAccess. Use it.
11248 (DeclSpace.NestedAccess): New.
11249 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
11250 argument to silence errors. Check access permissions.
11251 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
11252 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
11253 (Cast.DoResolve): Likewise.
11254 (New.DoResolve): Likewise.
11255 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
11256 (TypeOf.DoResolve): Likewise.
11258 * expression.cs (Invocation.BetterConversion): Return the Type of
11259 the better conversion. Implement section 14.4.2.3 more faithfully.
11260 (Invocation.BetterFunction): Make boolean. Make correspondence to
11261 section 14.4.2.2 explicit.
11262 (Invocation.OverloadResolve): Update.
11263 (Invocation): Remove is_base field.
11264 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
11265 (Invocation.Emit): Likewise.
11267 2004-09-27 Raja R Harinath <rharinath@novell.com>
11269 * README: Update to changes.
11271 2004-09-24 Marek Safar <marek.safar@seznam.cz>
11273 * cs-parser.jay: Reverted 642 warning fix.
11275 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11278 * decl.cs (FindMemberWithSameName): Indexer can have more than
11281 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11283 * expression.cs (LocalVariableReference.DoResolveLValue):
11284 Do not report warning 219 for out values.
11285 (EmptyExpression.Null): New member to avoid extra allocations.
11287 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11289 * cs-parser.jay: Fix wrong warning 642 report.
11291 * cs-tokenizer.cs (CheckNextToken): New helper;
11292 Inspect next character if is same as expected.
11294 2004-09-23 Martin Baulig <martin@ximian.com>
11296 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
11297 (Convert.ImplicitReferenceConversionExists): Likewise.
11299 2004-09-23 Marek Safar <marek.safar@seznam.cz>
11301 * class.cs (Operator.Define): Add error 448 and 559 report.
11303 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11305 * class.cs (MemberBase.IsTypePermitted): New protected
11306 method for checking error CS0610.
11308 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11310 * class.cs (TypeContainer.HasExplicitLayout): New property
11311 Returns whether container has StructLayout attribute set Explicit.
11312 (FieldMember): New abstract class for consts and fields.
11313 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
11314 (Field): Reuse FieldMember.
11316 * const.cs (Const): Reuse FieldMember.
11318 * rootcontext.cs: EmitConstants call moved to class.
11320 2004-09-22 Martin Baulig <martin@ximian.com>
11322 Thanks to Peter Sestoft for this bug report.
11324 * expression.cs (Conditional): If both the `trueExpr' and the
11325 `falseExpr' is a NullLiteral, return a NullLiteral.
11327 2004-09-22 Martin Baulig <martin@ximian.com>
11329 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
11330 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
11331 for the "get_Current" call.
11333 2004-09-22 Martin Baulig <martin@ximian.com>
11335 Marek and me just fixed one of our oldest bugs: #28562 :-)
11337 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
11339 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
11340 we're an EnumConstant, just return that.
11341 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
11342 an EnumConstant. In this case, we need to use GetValueAsEnumType()
11343 to get the value which'll actually be written into the attribute.
11344 However, we have to use GetValue() to access the attribute's value
11347 2004-09-22 Marek Safar <marek.safar@seznam.cz>
11349 * constant.cs (Constant.IsNegative): New abstract property
11352 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
11353 (StackAlloc.DoResolve): Reused IsNegative.
11355 2004-09-21 Martin Baulig <martin@ximian.com>
11357 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
11358 if we're used in an iterator, we may be called from different
11361 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
11362 we actually have an exception block.
11364 2004-09-20 John Luke <jluke@cfl.rr.com>
11366 * class.cs, cs-parser.jay: Improve the error report for 1520:
11367 report the actual line where the error happens, not where the
11368 class was declared.
11370 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
11371 Pass location information that was available elsewhere.
11373 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
11375 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
11376 runtime to delay sign assemblies.
11378 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11380 * cs-parser.jay: Do not report the stack trace, this is barely
11383 2004-08-22 John Luke <john.luke@gmail.com>
11385 * driver.cs : check that a resource id is not already used
11386 before adding it, report CS1508 if it is, bug #63637
11388 2004-09-19 Miguel de Icaza <miguel@ximian.com>
11390 * ecore.cs: Removed dead code.
11392 2004-09-18 Marek Safar <marek.safar@seznam.cz>
11394 * class.cs: Do not report warning CS0067 on the interfaces.
11396 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11398 * cs-parser.jay: Add error 504 report.
11400 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11402 * rootcontext.cs: WarningLevel is 4 by default now.
11404 * statement.cs (Fixed.Resolve): Do not null
11407 2004-09-16 Marek Safar <marek.safar@seznam.cz>
11410 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
11411 deep search when property is not virtual.
11412 (PropertyExpr.ResolveAccessors): Make one call for both
11415 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11418 * statement.cs: Error 152 report constains also location.
11420 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11423 * const.cs: Explicitly set constant as static.
11425 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11428 * cs-parser.jay: Add error 1017 report.
11430 2004-09-15 Marek Safar <marek.safar@seznam.cz>
11432 Fixed bug #59980, #64224
11433 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
11435 * typemanager.cs (IsSpecialMethod): Simplified
11437 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11439 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
11440 condition with better params.
11442 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11445 * attribute.cs (Resolve): Property has to have both
11448 2004-09-14 Martin Baulig <martin@ximian.com>
11450 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
11452 2004-09-14 Marek Safar <marek.safar@seznam.cz>
11455 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
11456 called and is obsolete then this member suppress message
11457 when call is inside next [Obsolete] method or type.
11459 * expression.cs: Use TestObsoleteMethodUsage member.
11461 2004-09-14 Martin Baulig <martin@ximian.com>
11463 * cs-parser.jay: Sync a bit with the GMCS version.
11465 2004-09-14 Martin Baulig <martin@ximian.com>
11467 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
11468 (CSharpParser.yacc_verbose_flag): New public field.
11470 * genericparser.cs: Removed.
11472 2004-09-14 Raja R Harinath <rharinath@novell.com>
11474 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
11476 2004-09-13 Marek Safar <marek.safar@seznam.cz>
11478 * class.cs (MethodCore.CheckBase): Fix bug #65757.
11480 2004-09-10 Martin Baulig <martin@ximian.com>
11482 Backported my MemberName changes from GMCS into MCS.
11484 - we are now using a special `MemberName' class instead of using
11485 strings; in GMCS, the `MemberName' also contains the type
11488 - changed the grammar rules a bit:
11489 * the old `member_name' is now a `namespace_or_type_name':
11490 The rule is that we use `namespace_or_type_name' everywhere
11491 where we expect either a "member name" (GetEnumerator) or a
11492 "member name" with an explicit interface name
11493 (IEnumerable.GetEnumerator).
11494 In GMCS, the explicit interface name may include type arguments
11495 (IEnumerable<T>.GetEnumerator).
11496 * we use `member_name' instead of just `IDENTIFIER' for
11498 The rule is that we use `member_name' wherever a member may
11499 have type parameters in GMCS.
11501 * decl.cs (MemberName): New public class.
11502 (MemberCore.MemberName): New public readonly field.
11503 (MemberCore.ctor): Take a `MemberName' argument, not a string.
11504 (DeclSpace): Likewise.
11506 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
11507 * enum.cs (Enum.ctor): Likewise.
11509 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
11511 (AliasEntry.ctor): Take a MemberName, not an Expression.
11512 (AliasEntry.UsingAlias): Likewise.
11514 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
11515 (IMethodData.MemberName): Changed type from string to MemberName.
11516 (MemberBase.ExplicitInterfaceName): Likewise.
11517 (AbstractPropertyEventMethod.SetupName): Make this private.
11518 (AbstractPropertyEventMethod.ctor): Added `string prefix'
11519 argument; compute the member name here.
11520 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
11521 on the `member.MemberName' and the `prefix'.
11523 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
11525 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
11526 thus, we get a `MemberName' instead of a `string'. These
11527 declarations may have type parameters in GMCS.
11528 (interface_method_declaration, delegate_declaration): Likewise.
11529 (class_declaration, interface_declaration): Likewise.
11530 (method_header): Use `namespace_or_type_name' instead of
11531 `member_name'. We may be an explicit interface implementation.
11532 (property_declaration, event_declaration): Likewise.
11533 (member_name): This is now just an `IDENTIFIER', not a
11534 `namespace_or_type_name'.
11535 (type_name, interface_type): Removed.
11536 (namespace_or_type_name): Return a MemberName, not an Expression.
11537 (primary_expression): Use `member_name' instead of `IDENTIFIER';
11538 call GetTypeExpression() on the MemberName to get an expression.
11539 (IndexerDeclaration.interface_type): Changed type from string to
11541 (MakeName): Operate on MemberName's instead of string's.
11543 2004-09-13 Raja R Harinath <rharinath@novell.com>
11546 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
11547 (NamespaceEntry.Lookup): Add new argument to flag if we want the
11548 lookup to avoid symbols introduced by 'using'.
11549 * rootcontext.cs (NamespaceLookup): Update.
11551 2004-09-12 Marek Safar <marek.safar@seznam.cz>
11553 * class.cs (TypeContainer.DoDefineMembers): Do not call
11554 DefineDefaultConstructor for static classes.
11556 2004-09-12 Marek Safar <marek.safar@seznam.cz>
11558 * attribute.cs (Attribute.Resolve): Add error 653 report.
11560 * class.cs (Class.ApplyAttributeBuilder): Add error 641
11562 (Method.ApplyAttributeBuilder): Add error 685 report.
11563 (Operator.Define): Add error 564 report.
11565 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
11567 * expression.cs (Invocation.DoResolve): Add error
11568 245 and 250 report.
11570 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
11573 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11575 * class.cs (ConstructorInitializer.Resolve):
11576 Wrong error number (515->516).
11578 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11580 * class.cs (Indexer.Define): Add error 631 report.
11582 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11584 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
11586 2004-09-11 Marek Safar <marek.safar@seznam.cz>
11588 * expression.cs (Probe.DoResolve): Add error CS0241 report.
11590 2004-09-10 Marek Safar <marek.safar@seznam.cz>
11592 * cs-parser.jay: Added error CS0241 report.
11594 2004-09-10 Raja R Harinath <rharinath@novell.com>
11596 * cs-parser.jay (fixed_statement): Introduce a scope for the
11597 declaration in the 'fixed' statement.
11599 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11601 * cs-parser.jay: Added CS0230 error report.
11603 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11605 * cs-parser.jay: Added errors CS0231 and CS0257 report.
11607 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11609 * expression.cs (Argument.Resolve): Added error CS0192 and
11612 2004-09-09 Marek Safar <marek.safar@seznam.cz>
11614 C# 2.0 #pragma warning feature
11616 * cs-tokenizer.cs (PreProcessPragma): New method;
11617 Handles #pragma directive.
11619 * report.cs (WarningRegions): New class; Support
11620 class for #pragma warning directive. It tests whether
11621 warning is enabled for a given line.
11623 2004-09-08 Miguel de Icaza <miguel@ximian.com>
11625 * const.cs: Add more descriptive error report, tahnks to
11628 2004-09-08 Marek Safar <marek.safar@seznam.cz>
11630 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
11632 2004-09-07 Miguel de Icaza <miguel@ximian.com>
11634 * expression.cs: Apply patch from Ben: Remove dead code from
11635 ArrayCreation, and remove the TurnintoConstant call in const.cs,
11636 as that code just threw an exception anwyays.
11638 * const.cs: Remove the call to the turnintoconstant, for details
11641 * literal.cs: The type of the null-literal is the null type; So
11642 we use a placeholder type (literal.cs:System.Null, defined here)
11645 * expression.cs (Conditional.DoResolve): Remove some old code that
11646 is no longer needed, conversions have been fixed.
11648 (ArrayCreationExpression.DoResolve): Return false if we fail to
11649 resolve the inner expression.
11651 2004-09-07 Raja R Harinath <rharinath@novell.com>
11654 * cs-parser.jay (delegate_declaration): Record a delegate
11655 declaration as a type declaration.
11656 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
11658 2004-09-06 Miguel de Icaza <miguel@ximian.com>
11660 * parameter.cs: Do not crash if the type can not be resolved.
11662 * expression.cs: Report errors with unsafe pointers, fixes #64896
11664 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
11666 * expression.cs: Pointer arith always needs to do a conv.i
11667 if the operand is a long. fix 65320
11669 2004-09-04 Marek Safar <marek.safar@seznam.cz>
11671 Fixed cs0619-37.cs, cs0619-38.cs
11673 * enum.cs (GetObsoleteAttribute): Removed.
11675 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
11676 on Enum member is double staged. The first is tested member
11679 2004-09-04 Marek Safar <marek.safar@seznam.cz>
11681 Fixed #56986, #63631, #65231
11683 * class.cs: (TypeContainer.AddToMemberContainer): New method,
11684 adds member to name container.
11685 (TypeContainer.AddToTypeContainer): New method, adds type to
11687 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
11688 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
11689 AddOperator): Simplified by reusing AddToMemberContainer.
11690 (TypeContainer.UserDefinedStaticConstructor): Changed to property
11692 (Method.CheckForDuplications): Fixed implementation to test all
11694 (MemberBase): Detection whether member is explicit interface
11695 implementation is now in constructor.
11696 (MemberBase.UpdateMemberName): Handles IndexerName.
11697 (Accessor): Changed to keep also location information.
11698 (AbstractPropertyEventMethod): Is derived from MemberCore.
11699 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
11700 will be emited or not.
11701 (PropertyBase.AreAccessorsDuplicateImplementation):
11702 Tests whether accessors are not in collision with some method.
11703 (Operator): Is derived from MethodCore to simplify common
11706 * decl.cs (Flags.TestMethodDuplication): Test for duplication
11708 (DeclSpace.AddToContainer): Adds the member to defined_names
11709 table. It tests for duplications and enclosing name conflicts.
11711 * enum.cs (EnumMember): Clean up to reuse the base structures
11713 2004-09-03 Martin Baulig <martin@ximian.com>
11715 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
11716 into TypeContainer, to make partial classes work again.
11718 2004-09-03 Martin Baulig <martin@ximian.com>
11720 * rootcontext.cs (RootContext.V2): Removed.
11722 2004-03-23 Martin Baulig <martin@ximian.com>
11724 * expression.cs (Invocation.OverloadResolve): Added `bool
11725 may_fail' argument and use it instead of the Location.IsNull() hack.
11727 2004-09-03 Martin Baulig <martin@ximian.com>
11729 Merged latest changes into gmcs. Please keep this comment in
11730 here, it makes it easier for me to see what changed in MCS since
11731 the last time I merged.
11733 2004-09-03 Raja R Harinath <rharinath@novell.com>
11736 * expression.cs (BetterConversion): Don't allow either conversion
11737 to be null. Remove redundant implicit conversion test when 'q ==
11738 null' -- when this function is invoked, we already know that the
11739 implicit conversion exists.
11740 (BetterFunction): Assume that 'best' is non-null. Remove
11741 redundant reimplementation of IsApplicable when 'best' is null.
11742 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
11743 number of arguments.
11744 (IsAncestralType): Extract from OverloadResolve.
11745 (OverloadResolve): Make robust to the MethodGroupExpr being
11746 unsorted. Implement all the logic of Section 14.5.5.1, and
11747 support overloading of methods from multiple applicable types.
11748 Clean up logic somewhat. Don't pass null methods to BetterFunction.
11750 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
11751 (RealError, Warning): Append type of report to related symbol.
11753 2004-09-03 Marek Safar <marek.safar@seznam.cz>
11755 * enum.cs: Fixed CLS-Compliance checks for enum members.
11756 Error tests cs3008-8.cs, cs3014-8.cs
11758 2004-09-02 Marek Safar <marek.safar@seznam.cz>
11760 Fixed bug #62342, #63102
11761 * class.cs: ImplementIndexer uses member.IsExplicitImpl
11762 like ImplementMethod.
11764 2004-09-02 Marek Safar <marek.safar@seznam.cz>
11766 * attribute.cs (Attribute.GetAttributeArgumentExpression):
11769 2004-09-02 Martin Baulig <martin@ximian.com>
11771 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
11772 TypeManager.GetArgumentTypes() rather than calling GetParameters()
11775 2004-09-01 Marek Safar <marek.safar@seznam.cz>
11777 C# 2.0 Static classes implemented
11779 * class.cs (TypeContainer): instance_constructors,
11780 initialized_fields, initialized_static_fields,
11781 default_constructor, base_inteface_types are protected to be
11782 accessible from StaticClass.
11783 (TypeContainer.DefineDefaultConstructor): New virtual method
11784 for custom default constructor generating
11785 (StaticClass): New class to handle "Static classes" feature.
11787 * cs-parser.jay: Handle static keyword on class like instance
11790 * driver.cs: Added "/langversion" command line switch with two
11791 options (iso-1, default).
11793 2004-08-31 Marek Safar <marek.safar@seznam.cz>
11795 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
11797 2004-08-31 Miguel de Icaza <miguel@ximian.com>
11799 * delegate.cs: Style.
11801 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
11803 * delegate.cs: Add seperate instance expr field for miguel.
11805 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
11807 * PointerArithmetic (Resolve): make sure we are not doing
11808 pointer arith on void*. Also, make sure we are resolved
11809 by not setting eclass until resolve.
11811 All callers: Make sure that PointerArithmetic gets resolved.
11813 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
11815 * ArrayCreation (LookupType): If the type does not resolve
11816 to an array, give an error.
11818 2004-08-27 Marek Safar <marek.safar@seznam.cz>
11820 * statement.cs (Try.Resolve): Fixed bug #64222
11822 2004-08-27 Martin Baulig <martin@ximian.com>
11825 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
11828 2004-08-26 Marek Safar <marek.safar@seznam.cz>
11830 * ecore.cs (Constantify): Get underlying type via
11831 System.Enum.GetUnderlyingType to avoid StackOverflow on the
11832 Windows in special cases.
11834 2004-08-26 Marek Safar <marek.safar@seznam.cz>
11836 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
11837 for obtaining also private methods.
11838 (GetRemoveMethod): Used GetRemoveMethod (true)
11839 for obtaining also private methods.
11841 2004-08-24 Martin Baulig <martin@ximian.com>
11843 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
11844 MethodAttributes.HideBySig for operators.
11846 2004-08-23 Martin Baulig <martin@ximian.com>
11848 Back to the old error reporting system :-)
11850 * report.cs (Message): Removed.
11851 (Report.MessageData, ErrorData, WarningData): Removed.
11852 (Report.Error, Warning): Back to the old system.
11854 2004-08-23 Martin Baulig <martin@ximian.com>
11856 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
11858 * class.cs (TypeContainer.ParentContainer): New public virtual
11859 method; replaces the explicit interface implementation.
11860 (ClassPart.ParentContainer): Override.
11862 2004-08-23 Martin Baulig <martin@ximian.com>
11864 * statement.cs (Switch): Added support for constant switches; see
11865 #59428 or test-285.cs.
11867 2004-08-22 Marek Safar <marek.safar@seznam.cz>
11870 * statement.cs (GetEnumeratorFilter): Removed useless
11871 logic because C# specs is strict. GetEnumerator must be
11874 2004-08-22 Martin Baulig <martin@ximian.com>
11876 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11877 a switch and may break, reset the barrier. Fixes #59867.
11879 2004-08-22 Marek Safar <marek.safar@seznam.cz>
11881 CLS-Compliance speed up (~5% for corlib)
11883 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
11884 New method. Tests container for CLS-Compliant names
11886 * class.cs (TypeContainer.VerifyClsName): New method.
11887 Checks whether container name is CLS Compliant.
11888 (Constructor): Implements IMethodData.
11890 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
11891 low-case table for CLS Compliance test.
11892 (MemberCache.VerifyClsParameterConflict): New method.
11893 Checks method parameters for CS3006 error.
11895 * enum.cs (EnumMember): Is derived from MemberCore.
11896 (Enum.VerifyClsName): Optimized for better performance.
11898 2004-08-06 Marek Safar <marek.safar@seznam.cz>
11900 * report.cs: Renamed Error_T to Error and changed all
11903 2004-08-06 Marek Safar <marek.safar@seznam.cz>
11905 * class.cs (TypeContainer.IndexerArrayList): New inner class
11906 container for indexers.
11907 (TypeContainer.DefaultIndexerName): New constant for default
11908 indexer name. Replaced all "Item" with this constant.
11909 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
11911 * typemanager.cs (TypeManager.default_member_ctor): Cache here
11912 DefaultMemberAttribute constructor.
11914 2004-08-05 Martin Baulig <martin@ximian.com>
11916 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
11919 2004-08-05 Marek Safar <marek.safar@seznam.cz>
11921 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
11922 multi platforms problem.
11924 * compiler.csproj: Included shared files.
11926 2004-08-04 Marek Safar <marek.safar@seznam.cz>
11928 Fix bug 60333, 55971 in the more general way
11929 * attribute.cs (Attribute.GetAttributeArgumentExpression):
11930 Added arg_type argument for constant conversion.
11931 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
11933 2004-08-04 Marek Safar <marek.safar@seznam.cz>
11936 * class.cs (TypeContainer ): New inner classes MethodArrayList,
11937 OperatorArrayList, MethodCoreArrayList for typecontainer
11938 containers. Changed class member types to these new types.
11939 (MethodArrayList.DefineMembers): Added test for CS0659.
11941 2004-08-04 Miguel de Icaza <miguel@ximian.com>
11943 * cfold.cs: Synchronize the folding with the code in expression.cs
11944 Binary.DoNumericPromotions for uint operands.
11946 * attribute.cs: Revert patch from Raja, it introduced a regression
11947 while building Blam-1.2.1 (hard to isolate a test case).
11949 2004-08-04 Marek Safar <marek.safar@seznam.cz>
11953 (TypeContainer.Define): Renamed to DefineContainerMembers because of
11955 (MethodCore.parent_method): New member. The method we're overriding
11956 if this is an override method.
11957 (MethodCore.CheckBase): Moved from Method class and made common.
11958 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
11960 (MethodCore.CheckForDuplications): New abstract method. For custom
11961 member duplication search in a container
11962 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
11963 method and its return type.
11964 (Event.conflict_symbol): New member. Symbol with same name in the
11968 (MemberCache.FindMemberWithSameName): New method. The method
11969 is looking for conflict with inherited symbols.
11971 2004-08-04 Martin Baulig <martin@ximian.com>
11973 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
11975 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
11977 2004-08-03 Marek Safar <marek.safar@seznam.cz>
11979 * report.cs (Message): New enum for better error, warning reference in
11981 (MessageData): New inner abstract class. It generally handles printing of
11982 error and warning messages.
11983 Removed unused Error, Warning, Message methods.
11985 2004-08-03 Marek Safar <marek.safar@seznam.cz>
11987 Fix for cs0592-8.cs test
11989 (Attributable.ValidAttributeTargets): Made public.
11990 (Attribute.ExplicitTarget): New member for explicit target value.
11991 (Attribute.CheckTargets): Now we translate explicit attribute
11992 target to Target here.
11994 2004-08-03 Ben Maurer <bmaurer@ximian.com>
11996 * ecore.cs (MethodGroupExpr): new IsBase property.
11998 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
12000 * delegate.cs (DelegateCreation): store a MethodGroupExpr
12001 rather than an instance expr.
12003 (DelegateCreation.Emit): Use the method group rather than
12004 the instance expression. Also, if you have base.Foo as the
12005 method for a delegate, make sure to emit ldftn, not ldftnvirt.
12007 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
12009 (NewDelegate.DoResolve): Only check for the existance of Invoke
12010 if the method is going to be needed. Use MethodGroupExpr.
12012 (NewDelegate.Emit): Remove, DelegateCreation implements this.
12014 * expression.cs: For pointer arith., make sure to use
12015 the size of the type, not the size of the pointer to
12018 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12021 * class.cs (Class): Added error CS0502 test.
12023 2004-08-03 John Luke <jluke@cfl.rr.com>
12024 Raja R Harinath <rharinath@novell.com>
12027 * attribute.cs (Attribute.complained_before): New flag.
12028 (Attribute.ResolveType, Attribute.Resolve),
12029 (Attribute.DefinePInvokeMethod): Set it.
12030 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
12032 2004-08-03 Martin Baulig <martin@ximian.com>
12034 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
12035 use a user-defined operator; we still need to do numeric
12036 promotions in case one argument is a builtin type and the other
12037 one has an implicit conversion to that type. Fixes #62322.
12039 2004-08-02 Martin Baulig <martin@ximian.com>
12041 * statement.cs (LocalInfo.Flags): Added `IsThis'.
12042 (LocalInfo.IsThis): New public property.
12043 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
12045 2004-08-01 Martin Baulig <martin@ximian.com>
12047 * class.cs (TypeContainer.GetClassBases): Don't set the default
12048 here since we may get called from GetPartialBases().
12049 (TypeContainer.DefineType): If GetClassBases() didn't return a
12050 parent, use the default one.
12052 2004-07-30 Duncan Mak <duncan@ximian.com>
12054 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
12056 2004-07-30 Martin Baulig <martin@ximian.com>
12058 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
12060 * class.cs (SourceMethod): New public class, derive from the
12061 symbol writer's ISourceMethod.
12062 (Method): Use the new symbol writer API.
12064 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
12065 as argument and use the new symbol writer.
12068 (SourceFile): Implement the symbol writer's ISourceFile.
12069 (Location.SymbolDocument): Removed.
12070 (Location.SourceFile): New public property.
12072 * symbolwriter.cs: Use the new symbol writer API.
12074 2004-07-30 Raja R Harinath <rharinath@novell.com>
12076 * Makefile (install-local): Remove. Functionality moved to
12079 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
12081 * Makefile: Install mcs.exe.config file together with mcs.exe.
12082 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
12083 correct runtime version.
12085 2004-07-25 Martin Baulig <martin@ximian.com>
12088 (TypeContainer.RegisterOrder): Removed, this was unused.
12089 (TypeContainer, interface_order): Removed.
12090 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
12091 TypeContainer as argument since we can also be called with a
12092 `PartialContainer' for a partial class/struct/interface.
12093 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
12094 of checking whether we're an `Interface' - we could be a
12095 `PartialContainer'.
12096 (PartialContainer.Register): Override; call
12097 AddClass()/AddStruct()/AddInterface() on our parent.
12099 * cs-parser.jay (interface_member_declaration): Add things to the
12100 `current_container', not the `current_class'.
12102 * rootcontext.cs (RegisterOrder): The overloaded version which
12103 takes an `Interface' was unused, removed.
12105 * typemanager.cs (TypeManager.LookupInterface): Return a
12106 `TypeContainer', not an `Interface'.
12107 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
12108 contain a `PartialContainer' for an interface, so check it's
12109 `Kind' to figure out what it is.
12111 2004-07-25 Martin Baulig <martin@ximian.com>
12113 * class.cs (Class.DefaultTypeAttributes): New public constant.
12114 (Struct.DefaultTypeAttributes): Likewise.
12115 (Interface.DefaultTypeAttributes): Likewise.
12116 (PartialContainer.TypeAttr): Override this and add the
12117 DefaultTypeAttributes.
12119 2004-07-25 Martin Baulig <martin@ximian.com>
12121 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
12122 we can just use the `Parent' field instead.
12124 2004-07-25 Martin Baulig <martin@ximian.com>
12126 * class.cs (TypeContainer.Emit): Renamed to EmitType().
12128 2004-07-25 Martin Baulig <martin@ximian.com>
12130 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
12131 our parts before defining any methods.
12132 (TypeContainer.VerifyImplements): Make this virtual.
12133 (ClassPart.VerifyImplements): Override and call VerifyImplements()
12134 on our PartialContainer.
12136 2004-07-25 Martin Baulig <martin@ximian.com>
12138 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
12140 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
12141 argument, we can just use the `Parent' field instead.
12144 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
12145 (MemberBase.DoDefine): Likewise.
12147 2004-07-24 Martin Baulig <martin@ximian.com>
12149 * decl.cs (MemberCore.Parent): New public field.
12150 (DeclSpace.Parent): Moved to MemberCore.
12152 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
12153 (MemberBase.ctor): Added TypeContainer argument, pass it to our
12155 (FieldBase, Field, Operator): Likewise.
12156 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
12157 (EventField, Event): Likewise.
12159 2004-07-23 Martin Baulig <martin@ximian.com>
12161 * class.cs (PartialContainer): New public class.
12162 (ClassPart): New public class.
12163 (TypeContainer): Added support for partial classes.
12164 (TypeContainer.GetClassBases): Splitted some of the functionality
12165 out into GetNormalBases() and GetPartialBases().
12167 * cs-tokenizer.cs (Token.PARTIAL): New token.
12168 (Tokenizer.consume_identifier): Added some hacks to recognize
12169 `partial', but only if it's immediately followed by `class',
12170 `struct' or `interface'.
12172 * cs-parser.jay: Added support for partial clases.
12174 2004-07-23 Martin Baulig <martin@ximian.com>
12176 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
12177 a `DeclSpace' and also made it readonly.
12178 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
12179 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
12180 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
12182 * cs-parser.jay: Pass the `current_class', not the
12183 `current_container' (at the moment, this is still the same thing)
12184 to a new Method, Property, Event, Indexer or Constructor.
12186 2004-07-23 Martin Baulig <martin@ximian.com>
12188 * cs-parser.jay (CSharpParser): Added a new `current_class' field
12189 and removed the `current_interface' one.
12190 (struct_declaration, class_declaration, interface_declaration):
12191 Set `current_class' to the newly created class/struct/interface;
12192 set their `Bases' and call Register() before parsing their body.
12194 2004-07-23 Martin Baulig <martin@ximian.com>
12196 * class.cs (Kind): New public enum.
12197 (TypeContainer): Made this class abstract.
12198 (TypeContainer.Kind): New public readonly field.
12199 (TypeContainer.CheckDef): New public method; moved here from
12201 (TypeContainer.Register): New public abstract method.
12202 (TypeContainer.GetPendingImplementations): New public abstract
12204 (TypeContainer.GetClassBases): Removed the `is_class' and
12205 `is_iface' parameters.
12206 (TypeContainer.DefineNestedTypes): Formerly known as
12208 (ClassOrStruct): Made this class abstract.
12210 * tree.cs (RootTypes): New public type.
12212 2004-07-20 Martin Baulig <martin@ximian.com>
12214 * tree.cs (Tree.RecordNamespace): Removed.
12215 (Tree.Namespaces): Removed.
12217 * rootcontext.cs (RootContext.IsNamespace): Removed.
12219 * cs-parser.jay (namespace_declaration): Just create a new
12220 NamespaceEntry here.
12222 2004-07-20 Martin Baulig <martin@ximian.com>
12224 * statement.cs (ExceptionStatement): New abstract class. This is
12225 now used as a base class for everyone who's using `finally'.
12226 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
12227 our local variables before using them.
12229 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
12230 virtual method. This is used by Yield.Resolve() to "steal" an
12231 outer block's `finally' clauses.
12232 (FlowBranchingException): The .ctor now takes an ExceptionStatement
12235 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
12236 version which takes an ExceptionStatement. This version must be
12237 used to create exception branchings.
12240 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
12241 (Iterator.EmitMoveNext): Added exception support; protect the
12242 block with a `fault' clause, properly handle 'finally' clauses.
12243 (Iterator.EmitDispose): Run all the `finally' clauses here.
12245 2004-07-20 Martin Baulig <martin@ximian.com>
12247 * iterator.cs: This is the first of a set of changes in the
12248 iterator code. Match the spec more closely: if we're an
12249 IEnumerable, then GetEnumerator() must be called. The first time
12250 GetEnumerator() is called, it returns the current instance; all
12251 subsequent invocations (if any) must create a copy.
12253 2004-07-19 Miguel de Icaza <miguel@ximian.com>
12255 * expression.cs: Resolve the constant expression before returning
12258 2004-07-19 Martin Baulig <martin@ximian.com>
12260 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
12261 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
12262 the return type of the new EmitContext.
12264 2004-07-18 Martin Baulig <martin@ximian.com>
12266 * class.cs (Property.Define): Fix iterators.
12268 * iterators.cs (Iterator.Define): Moved the
12269 `container.AddInterator (this)' call here from the .ctor; only do
12270 it if we resolved successfully.
12272 2004-07-17 Miguel de Icaza <miguel@ximian.com>
12274 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
12275 `true' for preprocessing directives that we parse. The return
12276 value indicates whether we should return to regular tokenizing or
12277 not, not whether it was parsed successfully.
12279 In the past if we were in: #if false ... #line #endif, we would
12280 resume parsing after `#line'. See bug 61604.
12282 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
12283 building: IsEnumType should return true only for enums, not for
12284 enums or System.Enum itself. This fixes #61593.
12286 Likely what happened is that corlib was wrong: mcs depended on
12287 this bug in some places. The bug got fixed, we had to add the
12288 hack, which caused bug 61593.
12290 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
12291 that was a workaround for the older conditions.
12293 2004-07-16 Ben Maurer <bmaurer@ximian.com>
12295 * assign.cs: IAssignMethod has a new interface, as documented
12296 inline. All assignment code now uses this new api.
12298 * ecore.cs, expression.cs: All classes which implement
12299 IAssignMethod now use the new interface.
12301 * expression.cs (Invocation): add a hack to EmitCall so that
12302 IndexerAccess can be the target of a compound assignment without
12303 evaluating its arguments twice.
12305 * statement.cs: Handle changes in Invocation api.
12307 2004-07-16 Martin Baulig <martin@ximian.com>
12309 * iterators.cs: Rewrote this. We're now using one single Proxy
12310 class for both the IEnumerable and the IEnumerator interface and
12311 `Iterator' derives from Class so we can use the high-level API.
12313 * class.cs (TypeContainer.AddIterator): New method.
12314 (TypeContainer.DoDefineType): New protected virtual method, which
12315 is called from DefineType().
12316 (TypeContainer.DoDefineMembers): Call DefineType() and
12317 DefineMembers() on all our iterators.
12318 (TypeContainer.Emit): Call Emit() on all our iterators.
12319 (TypeContainer.CloseType): Call CloseType() on all our iterators.
12321 * codegen.cs (EmitContext.CurrentIterator): New public field.
12323 2004-07-15 Martin Baulig <martin@ximian.com>
12326 (TypeManager.not_supported_exception_type): New type.
12328 2004-07-14 Martin Baulig <martin@ximian.com>
12330 * iterators.cs: Use real error numbers.
12332 2004-07-14 Martin Baulig <martin@ximian.com>
12334 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
12335 requires this to be a System.Collection.IEnumerable and not a
12336 class implementing that interface.
12337 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
12339 2004-07-13 Marek Safar <marek.safar@seznam.cz>
12341 * class.cs: Fixed previous fix, it broke some error tests.
12343 2004-07-12 Martin Baulig <martin@ximian.com>
12345 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
12348 2004-07-09 Miguel de Icaza <miguel@ximian.com>
12350 * assign.cs (LocalTemporary): Add new argument: is_address,If
12351 `is_address' is true, then the value that we store is the address
12352 to the real value, and not the value itself.
12354 * ecore.cs (PropertyExpr): use the new local temporary
12355 stuff to allow us to handle X.Y += z (where X is a struct)
12357 2004-07-08 Martin Baulig <martin@ximian.com>
12359 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
12360 not always return, just like we're doing in Using.Resolve().
12362 2004-07-07 Miguel de Icaza <miguel@ximian.com>
12364 * cs-parser.jay (fixed_statement): flag this as Pinned.
12366 2004-07-06 Miguel de Icaza <miguel@ximian.com>
12368 * typemanager.cs (TypeManager): Removed MakePinned method, this
12369 mechanism is replaced with the .NET 2.x compatible mechanism of
12370 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
12372 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
12373 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
12374 `IsFixed' property which has a different meaning.
12376 2004-07-02 Raja R Harinath <rharinath@novell.com>
12378 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
12379 visible from inside a nested class, not just the names of the
12380 immediately enclosing class.
12381 Fix for bug #60730.
12383 2004-06-24 Raja R Harinath <rharinath@novell.com>
12385 * expression.cs (BetterConversion): Remove buggy special-case
12386 handling of "implicit constant expression conversions". At this
12387 point, we already know that the conversion is possible -- we're
12388 only checking to see which is better.
12390 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12392 * cs-parser.jay: Added error CS0210 test.
12394 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12396 * cs-parser.jay: Added error CS0134 test.
12398 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12401 * cs-parser.jay: Added error CS0145 test.
12403 2004-06-24 Marek Safar <marek.safar@seznam.cz>
12405 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
12407 2004-06-23 Ben Maurer <bmaurer@ximian.com>
12409 * expression.cs (StackAlloc.Resolve): The argument may not
12410 be a constant; deal with this case.
12412 2004-06-23 Marek Safar <marek.safar@seznam.cz>
12414 * attribute.cs (IndexerName_GetIndexerName): Renamed to
12415 GetIndexerAttributeValue.
12416 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
12418 * class.cs (Indexer.Define): Added error tests for CS0415,
12421 2004-06-23 Miguel de Icaza <miguel@ximian.com>
12423 * attribute.cs (Attribute.Resolve): Keep field code in sync with
12426 2004-06-23 Martin Baulig <martin@ximian.com>
12428 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
12429 neither return nor throw, reset the barrier as well. Fixes #60457.
12431 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
12433 * class.cs : EventAttributes is now set to None by default.
12434 This fixes bug #60459.
12436 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12439 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
12440 Don't throw exception but return null (it's sufficient now).
12442 2004-06-18 Marek Safar <marek.safar@seznam.cz>
12444 * typemanager.cs (GetArgumentTypes): Faster implementation.
12446 2004-06-18 Martin Baulig <martin@ximian.com>
12448 * attribute.cs (Attribute.Resolve): Check whether we're an
12449 EmptyCast which a Constant child. Fixes #60333.
12451 2004-06-17 Ben Maurer <bmaurer@ximian.com>
12453 * statement.cs (EmitCollectionForeach): Account for the fact that
12454 not all valuetypes are in areas which we can take the address of.
12455 For these variables, we store to a temporary variable. Also, make
12456 sure that we dont emit a `callvirt' on a valuetype method.
12458 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12460 * expression.cs (StackAlloc.DoReSolve): Added test for
12461 negative parameter (CS0247).
12463 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12466 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
12468 2004-06-15 Marek Safar <marek.safar@seznam.cz>
12471 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
12474 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12476 Fix bug #58254 & cs1555.cs, cs1556.cs
12477 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
12479 2004-06-14 Marek Safar <marek.safar@seznam.cz>
12481 * cs-parser.jay: Added error CS1669 test for indexers.
12483 2004-06-11 Martin Baulig <martin@ximian.com>
12485 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
12486 call this twice: for params and varargs methods.
12488 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12491 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
12493 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12495 * attribute.cs (Attribute.GetValidTargets): Made public.
12498 (AbstractPropertyEventMethod): New class for better code sharing.
12499 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
12501 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
12503 2004-06-11 Raja R Harinath <rharinath@novell.com>
12506 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
12507 that the call to Resolve is part of a MemberAccess.
12508 (Expression.Resolve): Use it for SimpleName resolution.
12509 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
12510 Add 'intermediate' boolean argument.
12511 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
12512 error message when the SimpleName can be resolved ambiguously
12513 between an expression and a type.
12514 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
12516 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
12517 call on the left-side.
12519 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12522 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
12524 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12526 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
12528 2004-06-11 Martin Baulig <martin@ximian.com>
12530 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
12531 varargs methods if applicable.
12533 2004-06-11 Martin Baulig <martin@ximian.com>
12535 * expression.cs (Invocation.EmitCall): Don't use
12536 `method.CallingConvention == CallingConventions.VarArgs' since the
12537 method could also have `CallingConventions.HasThis'.
12539 2004-06-11 Marek Safar <marek.safar@seznam.cz>
12541 * class.cs (Event.GetSignatureForError): Implemented.
12542 Fixed crash in error test cs3010.cs
12544 2004-06-10 Miguel de Icaza <miguel@ximian.com>
12546 * cs-tokenizer.cs: Change the way we track __arglist to be
12547 consistent with the other keywords.
12549 2004-06-09 Miguel de Icaza <miguel@ximian.com>
12551 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
12554 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
12556 * codegen.cs: Check that all referenced assemblies have a strongname
12557 before strongnaming the compiled assembly. If not report error CS1577.
12558 Fix bug #56563. Patch by Jackson Harper.
12559 * typemanager.cs: Added a method to return all referenced assemblies.
12560 Fix bug #56563. Patch by Jackson Harper.
12562 2004-06-08 Marek Safar <marek.safar@seznam.cz>
12565 (Method.ApplyAttributeBuilder): Moved and added conditional
12566 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
12569 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
12571 2004-06-08 Marek Safar <marek.safar@seznam.cz>
12574 * class.cs: (EventField.attribute_targets): Changed default target.
12576 2004-06-08 Martin Baulig <martin@ximian.com>
12578 * expression.cs (Invocation.EmitCall): Enable varargs methods.
12580 2004-06-08 Martin Baulig <martin@ximian.com>
12582 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
12584 2004-06-07 Martin Baulig <martin@ximian.com>
12586 Added support for varargs methods.
12588 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
12591 * cs-parser.jay: Added support for `__arglist'.
12593 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
12595 * expression.cs (Argument.AType): Added `ArgList'.
12596 (Invocation): Added support for varargs methods.
12597 (ArglistAccess): New public class.
12598 (Arglist): New public class.
12600 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
12602 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
12603 a method's top-level block if the method has varargs.
12605 * support.cs (ReflectionParameters, InternalParameters): Added
12606 support for varargs methods.
12608 2004-06-07 Miguel de Icaza <miguel@ximian.com>
12610 * class.cs: Provide location in indexer error report.
12612 * driver.cs: Use standard names.
12614 * namespace.cs: Catch the use of using after a namespace has been
12615 declared also on using aliases.
12617 2004-06-03 Raja R Harinath <rharinath@novell.com>
12620 * typemanager.cs (closure_private_ok, closure_invocation_type)
12621 (closure_qualifier_type, closure_invocation_assembly)
12622 (FilterWithClosure): Move to ...
12623 (Closure): New internal nested class.
12624 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
12625 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
12626 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
12627 (MemberLookup, MemberLookupFailed): Use it.
12628 * expression.cs (New.DoResolve): Treat the lookup for the
12629 constructor as being qualified by the 'new'ed type.
12630 (Indexers.GetIndexersForTypeOrInterface): Update.
12632 2004-06-03 Marek Safar <marek.safar@seznam.cz>
12635 (GetConditionalAttributeValue): New method. Returns
12636 condition of ConditionalAttribute.
12637 (SearchMulti): New method. Returns all attributes of type 't'.
12638 Use it when attribute is AllowMultiple = true.
12639 (IsConditionalMethodExcluded): New method.
12642 (Method.IsExcluded): Implemented. Returns true if method has conditional
12643 attribute and the conditions is not defined (method is excluded).
12644 (IMethodData): Extended interface for ConditionalAttribute support.
12645 (PropertyMethod.IsExcluded): Implemented.
12648 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
12651 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
12654 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
12656 * expression.cs (ArrayCreationExpression): Make this just an
12657 `expression'. It can't be a statement, so the code here was
12660 2004-06-02 Marek Safar <marek.safar@seznam.cz>
12663 * typemanager.cs (GetFullNameSignature): New method for
12666 2004-06-02 Marek Safar <marek.safar@seznam.cz>
12669 * class.cs (MemberBase.GetSignatureForError): New virtual method.
12670 Use this method when MethodBuilder is null.
12671 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
12672 Added test for error CS0626 (MONO reports error for this situation).
12673 (IMethodData.GetSignatureForError): Extended interface.
12675 2004-06-01 Marek Safar <marek.safar@seznam.cz>
12678 (AttributeTester.GetObsoleteAttribute): Returns instance of
12679 ObsoleteAttribute when type is obsolete.
12682 (TypeContainer.VerifyObsoleteAttribute): Override.
12683 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
12684 (MethodCode.VerifyObsoleteAttribute): Override.
12685 (MemberBase.VerifyObsoleteAttribute): Override.
12688 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
12689 and report proper error.
12692 Delegate.VerifyObsoleteAttribute): Override.
12695 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
12696 and report proper error.
12697 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
12700 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
12704 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
12705 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
12706 Added test for ObsoleteAttribute.
12709 (Catch): Derived from Statement.
12711 2004-06-01 Marek Safar <marek.safar@seznam.cz>
12713 Fixed bug #59071 & cs0160.cs
12715 * statement.cs (Try.Resolve): Check here whether order of catch
12716 clauses matches their dependencies.
12718 2004-05-31 Miguel de Icaza <miguel@ximian.com>
12720 * Reverted patch to namespace.cs (Use lookuptypedirect). This
12721 caused a regression: #59343. Referencing nested classes from an
12722 assembly stopped working.
12724 2004-05-31 Martin Baulig <martin@ximian.com>
12726 MCS is now frozen for beta 2.
12728 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12730 * convert.cs: add a trivial cache for overload operator resolution.
12732 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12734 * decl.cs: If possible, use lookuptypedirect here. We can only do
12735 this if there is no `.' after the namespace. Avoids using
12736 LookupType, which does lots of slow processing.
12737 (FindNestedType) New method, does what it says :-).
12738 * namespace.cs: use LookupTypeDirect.
12739 * rootcontext.cs: use membercache, if possible.
12740 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
12742 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12745 According to the spec,
12747 In a member access of the form E.I, if E is a single identifier,
12748 and if the meaning of E as a simple-name (§7.5.2) is a constant,
12749 field, property, localvariable, or parameter with the same type as
12750 the meaning of E as a type-name (§3.8), then both possible
12751 meanings of E are permitted.
12753 We did not check that E as a simple-name had the same type as E as
12756 This trivial check gives us 5-7% on bootstrap time.
12758 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
12760 * expression.cs (Invocation.OverloadResolve): Avoid the
12761 use of hashtables and boxing here by allocating on demand.
12763 2004-05-30 Martin Baulig <martin@ximian.com>
12765 * rootcontext.cs (RootContext.LookupType): Don't cache things if
12766 we're doing a silent lookup. Don't try to lookup nested types in
12767 TypeManager.object_type (thanks to Ben Maurer).
12769 2004-05-30 Martin Baulig <martin@ximian.com>
12771 Committing a patch from Ben Maurer.
12773 * rootcontext.cs (RootContext.LookupType): Cache negative results.
12775 2004-05-29 Martin Baulig <martin@ximian.com>
12777 * class.cs (IMethodData.ShouldIgnore): New method.
12779 * typemanager.cs (TypeManager.MethodFlags): Don't take a
12780 `Location' argument, we don't need it anywhere. Use
12781 `IMethodData.ShouldIgnore ()' instead of
12782 `MethodData.GetMethodFlags ()'.
12783 (TypeManager.AddMethod): Removed.
12784 (TypeManager.AddMethod2): Renamed to AddMethod.
12786 2004-05-29 Martin Baulig <martin@ximian.com>
12788 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
12790 * convert.cs (Convert.ImplicitReferenceConversion): If we're
12791 converting from a class type S to an interface type and we already
12792 have an object on the stack, don't box it again. Fixes #52578.
12794 2004-05-29 Martin Baulig <martin@ximian.com>
12796 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
12797 Added support for `params' parameters. Fixes #59267.
12799 2004-05-29 Martin Baulig <martin@ximian.com>
12801 * literal.cs (NullPointer): Provide a private .ctor which sets
12802 `type' to TypeManager.object_type. Fixes #59048.
12804 2004-05-29 Martin Baulig <martin@ximian.com>
12806 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
12807 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
12809 * ecore.cs (EventExpr.instance_expr): Make the field private.
12811 2004-05-26 Marek Safar <marek.safar@seznam.cz>
12813 Fixed bug #50080 & cs0214-2.cs
12814 * expression.cs (Cast.DoResolve): Check unsafe context here.
12816 * statement.cs (Resolve.DoResolve): Likewise.
12818 2004-05-26 Martin Baulig <martin@ximian.com>
12820 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
12822 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
12823 (RootContext.LookupType): Pass down the `silent' flag.
12825 2004-05-25 Martin Baulig <martin@ximian.com>
12828 (MethodGroupExpr.IdenticalTypeName): New public property.
12829 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
12830 expression actually refers to a type.
12832 2004-05-25 Martin Baulig <martin@ximian.com>
12834 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
12835 for #56176 and made it actually work.
12837 2004-05-25 Martin Baulig <martin@ximian.com>
12839 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
12840 (FieldExpr, PropertyExpr): Override and implement
12841 CacheTemporaries. Fixes #52279.
12843 2004-05-25 Miguel de Icaza <miguel@ximian.com>
12845 * location.cs: In the new compiler listing a file twice is a
12846 warning, not an error.
12848 2004-05-24 Martin Baulig <martin@ximian.com>
12850 * enum.cs (Enum.DefineType): For the `BaseType' to be a
12851 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
12853 2004-05-24 Martin Baulig <martin@ximian.com>
12855 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
12856 walking the `using' list. Fixes #53921.
12858 2004-05-24 Martin Baulig <martin@ximian.com>
12860 * const.cs (Const.LookupConstantValue): Added support for
12861 EmptyCast's; fixes #55251.
12863 2004-05-24 Martin Baulig <martin@ximian.com>
12865 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
12866 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
12867 which does the CS0135 check. The reason is that we first need to
12868 check whether the variable actually exists.
12870 2004-05-24 Martin Baulig <martin@ximian.com>
12872 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
12873 than RootContext.LookupType() to find the explicit interface
12874 type. Fixes #58584.
12876 2004-05-24 Raja R Harinath <rharinath@novell.com>
12878 * Makefile: Simplify. Use executable.make.
12879 * mcs.exe.sources: New file. List of sources of mcs.exe.
12881 2004-05-24 Anders Carlsson <andersca@gnome.org>
12885 Use the invariant culture when doing String.Compare for CLS case
12888 2004-05-23 Martin Baulig <martin@ximian.com>
12890 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
12891 don't have any dots. Fixes #52622, added cs0246-8.cs.
12893 * namespace.cs (NamespaceEntry.Lookup): Likewise.
12895 2004-05-23 Marek Safar <marek.safar@seznam.cz>
12897 * class.cs (MemberBase.Define): Reuse MemberType member for
12898 resolved type. Other methods can use it too.
12900 2004-05-23 Martin Baulig <martin@ximian.com>
12902 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
12903 the variable also exists in the current block (otherwise, we need
12904 to report a CS0103). Fixes #58670.
12906 2004-05-23 Martin Baulig <martin@ximian.com>
12908 * flowanalysis.cs (Reachability.Reachable): Compute this
12909 on-the-fly rather than storing it as a field.
12911 2004-05-23 Martin Baulig <martin@ximian.com>
12913 * flowanalysis.cs (Reachability.And): Manually compute the
12914 resulting `barrier' from the reachability.
12916 2004-05-23 Marek Safar <marek.safar@seznam.cz>
12919 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
12920 instance of ObsoleteAttribute when symbol is obsolete.
12923 (IMethodData): Extended interface for ObsoleteAttribute support.
12925 2004-05-22 Marek Safar <marek.safar@seznam.cz>
12927 * attribute.cs: Fix bug #55970
12929 2004-05-22 Marek Safar <marek.safar@seznam.cz>
12933 (GetObsoleteAttribute): New method. Creates the instance of
12935 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
12936 ObsoleteAttribute when member is obsolete.
12937 (AttributeTester.Report_ObsoleteMessage): Common method for
12938 Obsolete error/warning reporting.
12941 (TypeContainer.base_classs_type): New member for storing parent type.
12944 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
12945 for this MemberCore.
12947 2004-05-21 Marek Safar <marek.safar@seznam.cz>
12949 * attribute.cs, const.cs: Fix bug #58590
12951 2004-05-21 Martin Baulig <martin@ximian.com>
12953 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
12954 out parameters if the end of the method is unreachable. Fixes
12957 2004-05-21 Marek Safar <marek.safar@seznam.cz>
12959 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
12960 Hari was right, why extra method.
12962 2004-05-21 Marek Safar <marek.safar@seznam.cz>
12964 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
12966 2004-05-20 Martin Baulig <martin@ximian.com>
12968 Merged this back from gmcs to keep the differences to a minumum.
12970 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
12971 instead of a Declspace.
12972 (Attribute.ResolveType): Likewise.
12973 (Attributes.Search): Likewise.
12974 (Attributes.Contains): Likewise.
12975 (Attributes.GetClsCompliantAttribute): Likewise.
12977 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
12979 (MethodData.ApplyAttributes): Take an EmitContext instead of a
12982 2004-05-19 Marek Safar <marek.safar@seznam.cz>
12984 Fix bug #58688 (MCS does not report error when the same attribute
12987 * attribute.cs (Attribute.Emit): Distinction between null and default.
12989 2004-05-19 Raja R Harinath <rharinath@novell.com>
12991 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
12992 of a top-level attribute without an attribute target.
12993 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
12995 (Attribute.Conditional_GetConditionName),
12996 (Attribute.Obsolete_GetObsoleteMessage): Update.
12997 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
12998 part of ScanForIndexerName.
12999 (Attribute.CanIgnoreInvalidAttribute): New function.
13000 (Attribute.ScanForIndexerName): Move to ...
13001 (Attributes.ScanForIndexerName): ... here.
13002 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
13003 (Attributes.Search): New internal variant that can choose not to
13004 complain if types aren't resolved. The original signature now
13006 (Attributes.GetClsCompliantAttribute): Use internal variant, with
13007 complaints suppressed.
13008 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
13009 only if it not useful.
13010 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
13011 top-level for attributes that are shared between the assembly
13012 and a top-level class.
13013 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
13014 * class.cs: Update to reflect changes.
13015 (DefineIndexers): Fuse loops.
13016 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
13017 a couple more variants of attribute names.
13019 2004-05-18 Marek Safar <marek.safar@seznam.cz>
13021 Fix bug #52585 (Implemented explicit attribute declaration)
13024 (Attributable.ValidAttributeTargets): New abstract method. It gets
13025 list of valid attribute targets for explicit target declaration.
13026 (Attribute.Target): It holds target itself.
13027 (AttributeSection): Removed.
13028 (Attribute.CheckTargets): New method. It checks whether attribute
13029 target is valid for the current element.
13032 (EventProperty): New class. For events that are declared like
13033 property (with add and remove accessors).
13034 (EventField): New class. For events that are declared like field.
13037 * cs-parser.jay: Implemented explicit attribute target declaration.
13039 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
13040 Override ValidAttributeTargets.
13043 (ReturnParameter): Class for applying custom attributes on
13045 (ParameterAtribute): New class. Class for applying custom
13046 attributes on the parameter type.
13048 2004-05-17 Miguel de Icaza <miguel@ximian.com>
13050 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
13053 (Method): Allow UNSAFE here.
13055 * modifiers.cs: Support unsafe reporting.
13057 2004-05-17 Marek Safar <marek.safar@seznam.cz>
13059 * decl.cs: Fix bug #58478.
13061 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13063 * statement.cs: When checking for unreachable code on an EmptyStatement,
13064 set the location. Fixes bug #58488.
13066 2004-05-13 Miguel de Icaza <miguel@ximian.com>
13068 * driver.cs: Add -pkg handling.
13070 From Gonzalo: UseShelLExecute=false
13072 2004-05-12 Marek Safar <marek.safar@seznam.cz>
13075 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
13077 (Attribute.IsClsCompliaceRequired): Moved to base for better
13079 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
13080 when attribute is AttributeUsageAttribute.
13081 (Attribute.GetValidTargets): Simplified.
13082 (Attribute.GetAttributeUsage): New method returns AttributeUsage
13083 attribute for this type.
13084 (Attribute.ApplyAttributes): Method renamed to Emit and make
13086 (GlobalAttributeSection): New class for special handling of global
13087 attributes (assembly, module).
13088 (AttributeSection.Emit): New method.
13090 * class.cs: Implemented Attributable abstract methods.
13091 (MethodCore.LabelParameters): Moved to Parameter class.
13092 (Accessor): Is back simple class.
13093 (PropertyMethod): Implemented Attributable abstract class.
13094 (DelegateMethod): Implemented Attributable abstract class.
13095 (Event): New constructor for disctintion between normal Event
13096 and Event with accessors.
13098 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
13100 * codegen.cs, const.cs, decl.cs, delegate.cs:
13101 (CommonAssemblyModulClass): Implemented Attributable abstract class
13104 * enum.cs: Implement IAttributeSupport interface.
13105 (EnumMember): New class for emum members. Implemented Attributable
13109 (ParameterBase): Is abstract.
13110 (ReturnParameter): New class for easier [return:] attribute handling.
13112 * typemanager.cs: Removed builder_to_attr.
13114 2004-05-11 Raja R Harinath <rharinath@novell.com>
13117 * attribute.cs (Attribute.GetPositionalValue): New function.
13118 * class.cs (TypeContainer.VerifyMembers): New function.
13119 (TypeContainer.Emit): Use it.
13120 (ClassOrStruct): New base class for Class and Struct.
13121 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
13122 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
13124 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
13125 then each non-static field should have a FieldOffset attribute.
13126 Otherwise, none of the fields should have a FieldOffset attribute.
13127 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
13128 and FieldOffset attributes.
13129 * typemanager.cs (TypeManager.struct_layout_attribute_type)
13130 (TypeManager.field_offset_attribute_type): New core types.
13131 (TypeManager.InitCoreTypes): Initialize them.
13133 2004-05-11 Michal Moskal <malekith@pld-linux.org>
13135 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
13136 Return correct type.
13139 2004-05-09 Miguel de Icaza <miguel@ximian.com>
13141 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
13142 be implicitly converted to ulong.
13144 * expression.cs: The logic for allowing operator &, | and ^ worked
13145 was wrong, it worked before because we did not report an error in
13146 an else branch. Fixes 57895.
13148 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
13149 allow volatile fields to be reference types.
13151 2004-05-07 Miguel de Icaza <miguel@ximian.com>
13153 * driver.cs: Add support for /debug-
13155 2004-05-07 Raja R Harinath <rharinath@novell.com>
13157 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
13158 Add a 'complain' parameter to silence errors.
13159 (Attribute.Resolve): Update to changes. Put in sanity check to catch
13160 silently overlooked type-resolutions.
13161 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
13162 to reflect changes.
13163 (Attributes.Search): New function.
13164 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
13165 (Attributes.GetAttributeFullName): Remove hack.
13166 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
13167 Update to reflect changes.
13168 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
13169 Use Attributes.Search instead of nested loops.
13171 2004-05-07 Marek Safar <marek.safar@seznam.cz>
13174 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
13175 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
13176 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
13178 * report.cs: (Report.Warning): Renamed to Warning_T because of
13179 parameter collision.
13181 2004-05-05 Raja R Harinath <rharinath@novell.com>
13183 * expression.cs (MemberAccess.ResolveMemberAccess):
13184 Exit with non-zero status after Report.Error.
13185 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
13187 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
13189 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13191 * support.cs: Don't hang when the file is empty.
13193 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
13195 * support.cs: In SeekableStreamReader, compute the preamble size of the
13196 underlying stream. Position changes should take into account that initial
13199 2004-05-03 Todd Berman <tberman@sevenl.net>
13201 * driver.cs: remove unused GetSysVersion function.
13203 2004-05-03 Todd Berman <tberman@sevenl.net>
13205 * driver.cs: Remove the hack from saturday, as well as the hack
13206 from jackson (LoadAssemblyFromGac), also adds the CWD to the
13207 link_paths to get that bit proper.
13209 2004-05-01 Todd Berman <tberman@sevenl.net>
13211 * driver.cs: Try a LoadFrom before a Load, this checks the current
13212 path. This is currently a bug in mono that is be fixed, however, this
13213 provides a workaround for now. This will be removed when the bug
13216 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
13218 * CryptoConvert.cs: Updated to latest version. Fix issue with
13219 incomplete key pairs (#57941).
13221 2004-05-01 Todd Berman <tberman@sevenl.net>
13223 * driver.cs: Remove '.' from path_chars, now System.* loads properly
13226 2004-04-30 Jackson Harper <jackson@ximian.com>
13228 * codegen.cs: Open keys readonly.
13230 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13232 * typemanager.cs: don't report cyclic struct layout when a struct
13233 contains 2 or more fields of the same type. Failed for Pango.AttrShape
13234 which has 2 Pango.Rectangle fields.
13236 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
13238 * expression.cs: Handle IntPtr comparisons with IL code
13239 rather than a method call.
13241 2004-04-29 Martin Baulig <martin@ximian.com>
13243 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
13244 the list of PropertyInfo's in class hierarchy and find the
13245 accessor. Fixes #56013.
13247 2004-04-29 Martin Baulig <martin@ximian.com>
13249 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
13251 2004-04-29 Martin Baulig <martin@ximian.com>
13253 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13255 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
13257 2004-04-29 Martin Baulig <martin@ximian.com>
13259 * class.cs (ConstructorInitializer.Resolve): Check whether the
13260 parent .ctor is accessible. Fixes #52146.
13262 2004-04-29 Martin Baulig <martin@ximian.com>
13264 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
13266 * statement.cs (Using.EmitLocalVariableDecls): Use
13267 TypeManager.idisposable_type, not typeof (IDisposable).
13268 (Foreach.EmitCollectionForeach): Added support for valuetypes.
13270 2004-04-29 Martin Baulig <martin@ximian.com>
13272 * class.cs (Event.Define): Don't emit the field and don't set
13273 RTSpecialName and SpecialName for events on interfaces. Fixes
13276 2004-04-29 Raja R Harinath <rharinath@novell.com>
13278 Refactor Attribute.ApplyAttributes.
13279 * attribute.cs (Attributable): New base class for objects that can
13280 have Attributes applied on them.
13281 (Attribute): Make AttributeUsage fields public.
13282 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
13283 (Attribute.IsInternalCall): New property.
13284 (Attribute.UsageAttr): Convert to a public read-only property.
13285 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
13286 (Attribute.ResolveType, Attribute.Resolve)
13287 (Attribute.ScanForIndexerName): Update to reflect changes.
13288 (Attribute.CheckAttributeTarget): Re-format.
13289 (Attribute.ApplyAttributes): Refactor, to various
13290 Attributable.ApplyAttributeBuilder methods.
13291 * decl.cs (MemberCore): Make Attributable.
13292 * class.cs (Accessor): Make Attributable.
13293 (MethodData.ApplyAttributes): Use proper attribute types, not
13295 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
13296 (TypeContainer.ApplyAttributeBuilder)
13297 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
13298 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
13299 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
13300 (Operator.ApplyAttributeBuilder): New factored-out methods.
13301 * const.cs (Const.ApplyAttributeBuilder): Likewise.
13302 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
13303 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
13304 * parameter.cs (ParameterBase): New Attributable base class
13305 that can also represent Return types.
13306 (Parameter): Update to the changes.
13308 2004-04-29 Jackson Harper <jackson@ximian.com>
13310 * driver.cs: Prefer the corlib system version when looking for
13311 assemblies in the GAC. This is still a hack, but its a better hack
13314 2004-04-29 Marek Safar <marek.safar@seznam.cz>
13316 * decl.cs, enum.cs: Improved error 3005 reporting.
13318 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
13319 (related_symbols): New private member for list of symbols
13320 related to reported error/warning.
13322 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
13324 2004-04-29 Martin Baulig <martin@ximian.com>
13326 * ecore.cs (Expression.Constantify): If we're an enum and
13327 TypeManager.TypeToCoreType() doesn't give us another type, use
13328 t.UnderlyingSystemType. Fixes #56178.
13330 2004-04-29 Martin Baulig <martin@ximian.com>
13332 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
13333 interfaces and for each interface, only add members directly
13334 declared in that interface. Fixes #53255.
13336 2004-04-28 Martin Baulig <martin@ximian.com>
13338 * expression.cs (ConditionalLogicalOperator): Use a temporary
13339 variable for `left' to avoid that we evaluate it more than once;
13342 2004-04-28 Martin Baulig <martin@ximian.com>
13344 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
13347 2004-04-28 Martin Baulig <martin@ximian.com>
13349 * statement.cs (LocalInfo.Resolve): Check whether the type is not
13352 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
13353 whether the type is not void (CS1547).
13355 2004-04-28 Martin Baulig <martin@ximian.com>
13357 * expression.cs (Unary.DoResolveLValue): Override this and report
13358 CS0131 for anything but Operator.Indirection.
13360 2004-04-28 Martin Baulig <martin@ximian.com>
13362 Committing a patch from Ben Maurer; see bug #50820.
13364 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13367 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13370 2004-04-28 Martin Baulig <martin@ximian.com>
13372 Committing a patch from Ben Maurer; see bug #50820.
13374 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
13377 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
13380 2004-04-28 Martin Baulig <martin@ximian.com>
13382 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
13383 (Block.AddLabel): Call DoLookupLabel() to only search in the
13386 2004-04-28 Martin Baulig <martin@ximian.com>
13388 * cfold.cs (ConstantFold.BinaryFold): Added special support for
13389 comparing StringConstants and NullLiterals in Equality and Inequality.
13391 2004-04-28 Jackson Harper <jackson@ximian.com>
13393 * driver.cs: Attempt to load referenced assemblies from the
13394 GAC. This is the quick and dirty version of this method that
13395 doesnt take into account versions and just takes the first
13396 canidate found. Will be good enough for now as we will not have more
13397 then one version installed into the GAC until I update this method.
13399 2004-04-28 Martin Baulig <martin@ximian.com>
13401 * typemanager.cs (TypeManager.CheckStructCycles): New public
13402 static method to check for cycles in the struct layout.
13404 * rootcontext.cs (RootContext.PopulateTypes): Call
13405 TypeManager.CheckStructCycles() for each TypeContainer.
13406 [Note: We only need to visit each type once.]
13408 2004-04-28 Martin Baulig <martin@ximian.com>
13410 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
13412 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
13413 success and added `out object value'. Use a `bool resolved' field
13414 to check whether we've already been called rather than
13415 `ConstantValue != null' since this breaks for NullLiterals.
13417 2004-04-28 Raja R Harinath <rharinath@novell.com>
13419 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
13420 setting of this flag, since the 'set' method may be non-public.
13422 2004-04-28 Raja R Harinath <rharinath@novell.com>
13424 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
13425 check on current_vector.Block.
13427 2004-04-27 Martin Baulig <martin@ximian.com>
13429 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
13430 a field initializer. Fixes #56459.
13432 2004-04-27 Martin Baulig <martin@ximian.com>
13434 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
13435 we're not attempting to use an indexer. Fixes #52154.
13437 2004-04-27 Martin Baulig <martin@ximian.com>
13439 * statement.cs (Return): Don't create a return label if we don't
13440 need it; reverts my change from January 20th. Thanks to Ben
13443 2004-04-27 Martin Baulig <martin@ximian.com>
13445 According to the spec, `goto' can only leave a nested scope, but
13448 * statement.cs (Block.LookupLabel): Only lookup in the current
13449 block, don't recurse into parent or child blocks.
13450 (Block.AddLabel): Check in parent and child blocks, report
13451 CS0140/CS0158 if we find a duplicate.
13452 (Block): Removed this indexer for label lookups.
13453 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
13454 this already does the error reporting for us.
13457 (FlowBranching.UsageVector.Block): New public variable; may be null.
13458 (FlowBranching.CreateSibling): Added `Block' argument.
13459 (FlowBranching.LookupLabel): New public virtual method. Lookup a
13460 label for the target of a `goto' and check whether we're not
13461 leaving a `finally'.
13463 2004-04-27 Martin Baulig <martin@ximian.com>
13465 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13466 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
13469 2004-04-27 Martin Baulig <martin@ximian.com>
13471 * statement.cs (Block.AddLabel): Also check for implicit blocks
13472 and added a CS0158 check.
13474 2004-04-27 Martin Baulig <martin@ximian.com>
13476 * flowanalysis.cs (FlowBranchingLoop): New class.
13477 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
13478 UsageVector's instead of an ArrayList.
13479 (FlowBranching.Label): Likewise.
13480 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
13481 (FlowBranching.AddBreakVector): New method.
13483 2004-04-27 Miguel de Icaza <miguel@ximian.com>
13485 * attribute.cs: Small regression fix: only convert the type if we
13486 the type is different, fixes System.Drawing build.
13488 2004-04-27 Martin Baulig <martin@ximian.com>
13490 * attribute.cs (Attribute.Resolve): If we have a constant value
13491 for a named field or property, implicity convert it to the correct
13494 2004-04-27 Raja R Harinath <rharinath@novell.com>
13496 * statement.cs (Block.Block): Implicit blocks share
13497 'child_variable_names' fields with parent blocks.
13498 (Block.AddChildVariableNames): Remove.
13499 (Block.AddVariable): Mark variable as "used by a child block" in
13500 every surrounding block.
13501 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
13502 been used in a child block, complain about violation of "Invariant
13503 meaning in blocks" rule.
13504 * cs-parser.jay (declare_local_variables): Don't use
13505 AddChildVariableNames.
13506 (foreach_statement): Don't create an implicit block: 'foreach'
13507 introduces a scope.
13509 2004-04-23 Miguel de Icaza <miguel@ximian.com>
13511 * convert.cs (ImplicitNumericConversion): 0 is also positive when
13512 converting from 0L to ulong. Fixes 57522.
13514 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13516 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
13517 derived class hides via 'new' keyword field from base class (test-242.cs).
13518 TODO: Handle this in the more general way.
13520 * class.cs (CheckBase): Ditto.
13522 2004-04-22 Marek Safar <marek.safar@seznam.cz>
13524 * decl.cs (caching_flags): New member for storing cached values
13526 (MemberCore.Flags): New enum where bit flags for caching_flags
13528 (MemberCore.cls_compliance): Moved to caching_flags.
13529 (DeclSpace.Created): Moved to caching_flags.
13531 * class.cs: Use caching_flags instead of DeclSpace.Created
13533 2004-04-21 Miguel de Icaza <miguel@ximian.com>
13535 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
13536 if we are only a derived class, not a nested class.
13538 * typemanager.cs: Same as above, but do this at the MemberLookup
13539 level (used by field and methods, properties are handled in
13540 PropertyExpr). Allow for the qualified access if we are a nested
13543 2004-04-21 Marek Safar <marek.safar@seznam.cz>
13545 * class.cs: Refactoring.
13546 (IMethodData): New inteface; Holds links to parent members
13547 to avoid member duplication (reduced memory allocation).
13548 (Method): Implemented IMethodData interface.
13549 (PropertyBase): New inner classes for get/set methods.
13550 (PropertyBase.PropertyMethod): Implemented IMethodData interface
13551 (Event): New inner classes for add/remove methods.
13552 (Event.DelegateMethod): Implemented IMethodData interface.
13554 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
13555 EmitContext (related to class.cs refactoring).
13557 2004-04-21 Raja R Harinath <rharinath@novell.com>
13559 * delegate.cs (Delegate.VerifyApplicability): If the number of
13560 arguments are the same as the number of parameters, first try to
13561 verify applicability ignoring any 'params' modifier on the last
13565 2004-04-16 Raja R Harinath <rharinath@novell.com>
13567 * class.cs (TypeContainer.AddIndexer): Use
13568 'ExplicitInterfaceName' to determine if interface name was
13569 explicitly specified. 'InterfaceType' is not initialized at this time.
13570 (TypeContainer.DefineIndexers): Remove use of temporary list. The
13571 Indexers array is already in the required order. Initialize
13572 'IndexerName' only if there are normal indexers.
13573 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
13574 (TypeContainer.Emit): Emit DefaultMember attribute only if
13575 IndexerName is initialized.
13578 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
13580 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
13583 2004-04-15 Raja R Harinath <rharinath@novell.com>
13585 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
13589 * attribute.cs (Attribute.Resolve): Check for duplicate named
13593 2004-04-15 Miguel de Icaza <miguel@ximian.com>
13595 * iterators.cs (MarkYield): track whether we are in an exception,
13596 and generate code accordingly. Use a temporary value to store the
13597 result for our state.
13599 I had ignored a bit the interaction of try/catch with iterators
13600 since their behavior was not entirely obvious, but now it is
13601 possible to verify that our behavior is the same as MS .NET 2.0
13605 2004-04-14 Miguel de Icaza <miguel@ximian.com>
13607 * iterators.cs: Avoid creating temporaries if there is no work to
13610 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
13611 Enumerations, use TypeManager.EnumToUnderlying and call
13614 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
13617 (This.Emit): Use EmitContext.EmitThis to emit our
13620 (This.EmitAssign): Ditto.
13622 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
13623 codepaths, we will move all the functionality into
13626 (FieldExpr.EmitAssign): Ditto.
13628 This fixes several hidden bugs that I uncovered while doing a code
13629 review of this today.
13631 * codegen.cs (EmitThis): reworked so the semantics are more clear
13632 and also support value types "this" instances.
13634 * iterators.cs: Changed so that for iterators in value types, we
13635 do not pass the value type as a parameter.
13637 Initialization of the enumerator helpers is now done in the caller
13638 instead of passing the parameters to the constructors and having
13639 the constructor set the fields.
13641 The fields have now `assembly' visibility instead of private.
13643 2004-04-11 Miguel de Icaza <miguel@ximian.com>
13645 * expression.cs (Argument.Resolve): Check if fields passed as ref
13646 or out are contained in a MarshalByRefObject.
13648 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
13649 another compiler type.
13651 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
13653 * class.cs (Indexer.Define): use the new name checking method.
13654 Also, return false on an error.
13655 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
13656 (is_identifier_[start/part]_character): make static.
13658 2004-04-10 Miguel de Icaza <miguel@ximian.com>
13660 * expression.cs (Binary.ResolveOperator): Do no append strings
13661 twice: since we can be invoked more than once (array evaluation)
13662 on the same concatenation, take care of this here. Based on a fix
13663 from Ben (bug #56454)
13665 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
13667 * codegen.cs: Fix another case where CS1548 must be reported (when
13668 delay-sign isn't specified and no private is available #56564). Fix
13669 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
13670 error when MCS is used on the MS runtime and we need to delay-sign
13671 (which seems unsupported by AssemblyBuilder - see #56621).
13673 2004-04-08 Marek Safar <marek.safar@seznam.cz>
13675 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
13676 (TypeManager.ComputeNamespaces): Faster implementation for
13679 * compiler.csproj: Updated AssemblyName to mcs.
13681 2004-04-07 Miguel de Icaza <miguel@ximian.com>
13683 * rootcontext.cs: Add new types to the boot resolution.
13685 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
13686 MulticastDelegate is not allowed.
13688 * typemanager.cs: Add new types to lookup: System.TypedReference
13691 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
13692 check for TypedReference or ArgIterator, they are not allowed.
13694 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
13695 makes us properly catch 1510 in some conditions (see bug 56016 for
13698 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
13700 * CryptoConvert.cs: update from corlib version
13703 2004-04-05 Miguel de Icaza <miguel@ximian.com>
13705 * class.cs (Indexer.Define): Check indexername declaration
13707 2004-04-05 Marek Safar <marek.safar@seznam.cz>
13709 * attribute.cs (IsClsCompliant): Fixed problem with handling
13710 all three states (compliant, not-compliant, undetected).
13712 2004-03-30 Marek Safar <marek.safar@seznam.cz>
13714 * attribute.cs (Attribute): Location is now public.
13715 (Resolve): Store resolved arguments (pos_values) in attribute class.
13716 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
13717 (GetClsCompliantAttributeValue): New method that gets
13718 CLSCompliantAttribute value.
13719 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
13720 if exists else null.
13721 (AttributeTester): New class for CLS-Compliant verification routines.
13723 * class.cs (Emit): Add CLS-Compliant verification.
13724 (Method.GetSignatureForError): Implemented.
13725 (Constructor.GetSignatureForError): Implemented
13726 (Constructor.HasCompliantArgs): Returns if constructor has
13727 CLS-Compliant arguments.
13728 (Constructor.Emit): Override.
13729 (Construcor.IsIdentifierClsCompliant): New method; For constructors
13730 is needed to test only parameters.
13731 (FieldBase.GetSignatureForError): Implemented.
13732 (TypeContainer): New member for storing base interfaces.
13733 (TypeContainer.FindMembers): Search in base interfaces too.
13735 * codegen.cs (GetClsComplianceAttribute): New method that gets
13736 assembly or module CLSCompliantAttribute value.
13737 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
13739 (ModuleClass.Emit): Add error 3012 test.
13741 * const.cs (Emit): Override and call base for CLS-Compliant tests.
13743 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
13744 state for all decl types.
13745 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
13746 if CLS-Compliant tests are required.
13747 (IsClsCompliaceRequired): New method. Analyze whether code
13748 must be CLS-Compliant.
13749 (IsExposedFromAssembly): New method. Returns true when MemberCore
13750 is exposed from assembly.
13751 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
13752 value or gets cached value.
13753 (HasClsCompliantAttribute): New method. Returns true if MemberCore
13754 is explicitly marked with CLSCompliantAttribute.
13755 (IsIdentifierClsCompliant): New abstract method. This method is
13756 used to testing error 3005.
13757 (IsIdentifierAndParamClsCompliant): New method. Common helper method
13758 for identifier and parameters CLS-Compliant testing.
13759 (VerifyClsCompliance): New method. The main virtual method for
13760 CLS-Compliant verifications.
13761 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
13762 null. I don't know why is null (too many public members !).
13763 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
13764 and get value of first CLSCompliantAttribute that found.
13766 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
13767 (VerifyClsCompliance): Override and add extra tests.
13769 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
13770 clscheck- disable CLS-Compliant verification event if assembly is has
13771 CLSCompliantAttribute(true).
13773 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
13774 ApllyAttribute is now called in emit section as in the other cases.
13775 Possible future Emit integration.
13776 (IsIdentifierClsCompliant): New override.
13777 (VerifyClsCompliance): New override.
13778 (GetEnumeratorName): Returns full enum name.
13780 * parameter.cs (GetSignatureForError): Implemented.
13782 * report.cs (WarningData): New struct for Warning message information.
13783 (LocationOfPreviousError): New method.
13784 (Warning): New method. Reports warning based on the warning table.
13785 (Error_T): New method. Reports error based on the error table.
13787 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
13788 verifications are done here.
13790 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
13792 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
13793 CLSCompliantAttribute.
13794 (all_imported_types): New member holds all imported types from other
13796 (LoadAllImportedTypes): New method fills static table with exported types
13797 from all referenced assemblies.
13798 (Modules): New property returns all assembly modules.
13800 2004-03-30 Miguel de Icaza <miguel@ximian.com>
13802 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
13803 throwing a parser error.
13805 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
13806 which removes the hardcoded get_/set_ prefixes for properties, as
13807 IL allows for the properties to be named something else.
13811 * expression.cs: Do not override operand before we know if it is
13812 non-null. Fix 56207
13814 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13816 * typemanager.cs: support for pinned variables.
13818 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13820 * decl.cs, typemanager.cs: Avoid using an arraylist
13821 as a buffer if there is only one result set.
13823 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
13825 * expression.cs: Make sure you cant call a static method
13826 with an instance expression, bug #56174.
13828 2004-03-29 Miguel de Icaza <miguel@ximian.com>
13830 * class.cs (IsDuplicateImplementation): Improve error reporting to
13831 flag 663 (method only differs in parameter modifier).
13833 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
13834 in preprocessor directives.
13836 * location.cs (LookupFile): Allow for the empty path.
13838 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
13839 better approach for some of that patch, but its failing with the
13840 CharSet enumeration. For now try/catch will do.
13842 * typemanager.cs: Do not crash if a struct does not have fields.
13845 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
13847 * expression.cs: cs0213, cant fix a fixed expression.
13850 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
13852 * cs-parser.jay: detect invalid embeded statements gracefully.
13855 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
13857 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
13860 the invocation type may not be a subclass of the tye of the item/
13861 The type of the item must be a subclass of the invocation item.
13866 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
13868 * attribute.cs: Added methods to get a string and a bool from an
13869 attribute. Required to information from AssemblyKeyFileAttribute,
13870 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
13871 * codegen.cs: Modified AssemblyName creation to include support for
13872 strongnames. Catch additional exceptions to report them as CS1548.
13873 * compiler.csproj: Updated include CryptoConvert.cs.
13874 * compiler.csproj.user: Removed file - user specific configuration.
13875 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
13876 Mono.Security assembly. The original class is maintained and tested in
13877 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
13878 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
13879 like CSC 8.0 (C# v2) supports.
13880 * Makefile: Added CryptoConvert.cs to mcs sources.
13881 * rootcontext.cs: Added new options for strongnames.
13883 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
13885 * driver.cs: For --expect-error, report error code `2'
13886 if the program compiled with no errors, error code `1' if
13887 it compiled with an error other than the one expected.
13889 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
13891 * compiler.csproj: Updated for Visual Studio .NET 2003.
13892 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
13893 * compiler.sln: Updated for Visual Studio .NET 2003.
13895 2004-03-24 Ravi Pratap M <ravi@ximian.com>
13897 * expression.cs: Fix bug #47234. We basically need to apply the
13898 rule that we prefer the conversion of null to a reference type
13899 when faced with a conversion to 'object' (csc behaviour).
13901 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13903 * statement.cs: Shorter form for foreach, eliminates
13904 a local variable. r=Martin.
13906 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13908 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
13909 checks if we can use brtrue/brfalse to test for 0.
13910 * expression.cs: use the above in the test for using brtrue/brfalse.
13911 cleanup code a bit.
13913 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13915 * expression.cs: Rewrite string concat stuff. Benefits:
13917 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
13918 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
13919 rather than a concat chain.
13921 * typemanager.cs: Add lookups for more concat overloads.
13923 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
13925 * expression.cs: Emit shorter il code for array init.
13942 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
13944 * statement.cs: Before, two switch blocks would be merged if the
13945 total size of the blocks (end_item - begin_item + 1) was less than
13946 two times the combined sizes of the blocks.
13948 Now, it will only merge if after the merge at least half of the
13953 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
13955 * class.cs : csc build fix for GetMethods(). See bug #52503.
13957 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
13959 * expression.cs: Make sure fp comparisons work with NaN.
13960 This fixes bug #54303. Mig approved this patch a long
13961 time ago, but we were not able to test b/c the runtime
13964 2004-03-19 Miguel de Icaza <miguel@ximian.com>
13966 * ecore.cs (TypExpr.GetHashCode): implement this overload.
13968 2004-03-19 Martin Baulig <martin@ximian.com>
13970 * class.cs (MemberCore.IsDuplicateImplementation): Report the
13971 error here and not in our caller.
13973 2004-03-19 Martin Baulig <martin@ximian.com>
13975 * interface.cs: Completely killed this file.
13976 (Interface): We're now a TypeContainer and live in class.cs.
13978 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
13979 argument; we're now also called for interfaces.
13980 (TypeContainer.DefineMembers): Allow this method being called
13982 (TypeContainer.GetMethods): New public method; formerly known as
13983 Interface.GetMethod(). This is used by PendingImplementation.
13984 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
13985 it's now private and non-static.
13986 (Interface): Moved this here; it's now implemented similar to
13988 (Method, Property, Event, Indexer): Added `bool is_interface'
13989 argument to their .ctor's.
13990 (MemberBase.IsInterface): New public field.
13992 * cs-parser.jay: Create normal Method, Property, Event, Indexer
13993 instances instead of InterfaceMethod, InterfaceProperty, etc.
13994 (opt_interface_base): Removed; we now use `opt_class_base' instead.
13995 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
13997 2004-03-19 Martin Baulig <martin@ximian.com>
13999 * class.cs (MethodCore.IsDuplicateImplementation): New private
14000 method which does the CS0111 checking.
14001 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
14002 Use IsDuplicateImplementation().
14004 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
14006 * decl.cs (FindMemberToOverride): New method to find the correct
14007 method or property to override in the base class.
14009 - Make Method/Property use the above method to find the
14010 version in the base class.
14011 - Remove the InheritableMemberSignatureCompare as it is now
14014 This patch makes large code bases much faster to compile, as it is
14015 O(n) rather than O(n^2) to do this validation.
14017 Also, it fixes bug 52458 which is that nested classes are not
14018 taken into account when finding the base class member.
14020 Reviewed/Approved by Martin.
14022 2004-03-17 Marek Safar <marek.safar@seznam.cz>
14024 * interface.cs: In all interface classes removed redundant
14025 member initialization.
14027 2004-03-16 Martin Baulig <martin@ximian.com>
14029 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
14031 2004-03-15 Miguel de Icaza <miguel@ximian.com>
14033 * decl.cs (DefineTypeAndParents): New helper method to define a
14034 type's containers before the type itself is defined; This is a
14035 bug exposed by the recent changes to Windows.Forms when an
14036 implemented interface was defined inside a class that had not been
14039 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
14041 (Check): Loop correctly to report errors modifiers
14042 (UNSAFE was not in the loop, since it was the same as TOP).
14044 * interface.cs: Every interface member now takes a ModFlags,
14045 instead of a "is_new" bool, which we set on the base MemberCore.
14047 Every place where we called "UnsafeOk" in the interface, now we
14048 call the proper member (InterfaceMethod.UnsafeOK) instead to get
14049 the unsafe settings from the member declaration instead of the
14050 container interface.
14052 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
14054 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
14055 `set_indexer_name' to the pending bits (one per type).
14057 We fixed a bug today that was picking the wrong method to
14058 override, since for properties the existing InterfaceMethod code
14059 basically ignored the method name. Now we make sure that the
14060 method name is one of the valid indexer names.
14062 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
14064 * support.cs (SeekableStreamReader): Keep track of stream byte
14065 positions and don't mix them with character offsets to the buffer.
14067 Patch from Gustavo Giráldez
14069 2004-03-15 Marek Safar <marek.safar@seznam.cz>
14071 * interface.cs (InterfaceSetGetBase): Removed double member
14072 initialization, base class does it as well.
14074 2004-03-13 Martin Baulig <martin@ximian.com>
14076 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
14077 when compiling corlib.
14079 2004-03-13 Miguel de Icaza <miguel@ximian.com>
14081 * convert.cs (ExplicitConversion): We were reporting an error on
14082 certain conversions (object_type source to a value type, when the
14083 expression was `null') before we had a chance to pass it through
14084 the user defined conversions.
14086 * driver.cs: Replace / and \ in resource specifications to dots.
14089 * class.cs: Add check for duplicate operators. Fixes 52477
14091 2004-03-11 Miguel de Icaza <miguel@ximian.com>
14093 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
14094 that are in the middle of the statements, not only at the end.
14097 * class.cs (TypeContainer.AddField): No longer set the
14098 `HaveStaticConstructor' flag, now we call it
14099 `UserDefineStaticConstructor' to diferentiate the slightly
14100 semantic difference.
14102 The situation is that we were not adding BeforeFieldInit (from
14103 Modifiers.TypeAttr) to classes that could have it.
14104 BeforeFieldInit should be set to classes that have no static
14109 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
14111 And most importantly Zoltan's comment:
14113 http://bugzilla.ximian.com/show_bug.cgi?id=44229
14115 "I think beforefieldinit means 'it's ok to initialize the type sometime
14116 before its static fields are used', i.e. initialization does not need
14117 to be triggered by the first access to the type. Setting this flag
14118 helps the JIT to compile better code, since it can run the static
14119 constructor at JIT time, and does not need to generate code to call it
14120 (possibly lots of times) at runtime. Unfortunately, mcs does not set
14121 this flag for lots of classes like String.
14123 csc sets this flag if the type does not have an explicit static
14124 constructor. The reasoning seems to be that if there are only static
14125 initalizers for a type, and no static constructor, then the programmer
14126 does not care when this initialization happens, so beforefieldinit
14129 This bug prevents the AOT compiler from being usable, since it
14130 generates so many calls to mono_runtime_class_init that the AOT code
14131 is much slower than the JITted code. The JITted code is faster,
14132 because it does not generate these calls if the vtable is type is
14133 already initialized, which is true in the majority of cases. But the
14134 AOT compiler can't do this."
14136 2004-03-10 Miguel de Icaza <miguel@ximian.com>
14138 * class.cs (MethodData.Emit): Refactor the code so symbolic
14139 information is generated for destructors; For some reasons we
14140 were taking a code path that did not generate symbolic information
14143 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
14145 * class.cs: Create a Constructor.CheckBase method that
14146 takes care of all validation type code. The method
14147 contains some code that was moved from Define.
14149 It also includes new code that checks for duplicate ctors.
14150 This fixes bug #55148.
14152 2004-03-09 Joshua Tauberer <tauberer@for.net>
14154 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
14155 a { ... }-style array creation invokes EmitStaticInitializers
14156 which is not good for reference-type arrays. String, decimal
14157 and now null constants (NullCast) are not counted toward
14158 static initializers.
14160 2004-03-05 Martin Baulig <martin@ximian.com>
14162 * location.cs (SourceFile.HasLineDirective): New public field;
14163 specifies whether the file contains or is referenced by a "#line"
14165 (Location.DefineSymbolDocuments): Ignore source files which
14166 either contain or are referenced by a "#line" directive.
14168 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
14170 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
14171 direct access to our parent, so check the method inline there.
14173 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
14175 * expression.cs (Invocation.EmitCall): Miguel's last commit
14176 caused a regression. If you had:
14181 In Foo the implict this would be null.
14183 2004-02-27 Miguel de Icaza <miguel@ximian.com>
14185 * expression.cs (Invocation.EmitCall): If the method is not
14186 virtual, do not emit a CallVirt to it, use Call.
14188 * typemanager.cs (GetFullNameSignature): Improve the method to
14189 cope with ".ctor" and replace it with the type name.
14191 * class.cs (ConstructorInitializer.Resolve): Now the method takes
14192 as an argument the ConstructorBuilder where it is being defined,
14193 to catch the recursive constructor invocations.
14195 2004-02-26 Miguel de Icaza <miguel@ximian.com>
14197 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
14198 routines to check if a type is an enumerable/enumerator allow
14199 classes that implement the IEnumerable or IEnumerator interfaces.
14201 * class.cs (Property, Operator): Implement IIteratorContainer, and
14202 implement SetYields.
14204 (Property.Define): Do the block swapping for get_methods in the
14205 context of iterators. We need to check if Properties also
14206 include indexers or not.
14208 (Operator): Assign the Block before invoking the
14209 OperatorMethod.Define, so we can trigger the Iterator code
14212 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
14213 Property and Operator classes are not created when we parse the
14214 declarator but until we have the block completed, so we use a
14215 singleton SimpleIteratorContainer.Simple to flag whether the
14216 SetYields has been invoked.
14218 We propagate this setting then to the Property or the Operator to
14219 allow the `yield' to function.
14221 2004-02-25 Marek Safar <marek.safar@seznam.cz>
14223 * codegen.cs: Implemented attribute support for modules.
14224 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
14225 Assembly/Module functionality.
14227 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
14228 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
14229 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
14231 2004-02-16 Marek Safar <marek.safar@seznam.cz>
14233 * interface.cs (FindMembers): The operation is performed on all base
14234 interfaces and not only on the first. It is required for future CLS Compliance patch.
14236 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
14238 * statement.cs, codegen.cs:
14239 This patch deals with patterns such as:
14241 public class List : IEnumerable {
14243 public MyEnumerator GetEnumerator () {
14244 return new MyEnumerator(this);
14247 IEnumerator IEnumerable.GetEnumerator () {
14251 public struct MyEnumerator : IEnumerator {
14256 Before, there were a few things we did wrong:
14257 1) we would emit callvirt on a struct, which is illegal
14258 2) we emited ldarg when we needed to emit ldarga
14259 3) we would mistakenly call the interface methods on an enumerator
14260 type that derived from IEnumerator and was in another assembly. For example:
14262 public class MyEnumerator : IEnumerator
14264 Would have the interface methods called, even if there were public impls of the
14265 method. In a struct, this lead to invalid IL code.
14267 2004-02-11 Marek Safar <marek.safar@seznam.cz>
14269 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
14272 * delegate.cs (Define): Fixed crash when delegate type is undefined.
14274 2004-02-11 Miguel de Icaza <miguel@ximian.com>
14276 * cs-parser.jay: Fix small regression: we were not testing V2
14277 compiler features correctly.
14279 * interface.cs: If the emit context is null, then create one
14281 2004-02-09 Marek Safar <marek.safar@seznam.cz>
14283 * decl.cs (GetSignatureForError): New virtual method to get full name
14284 for error messages.
14286 * attribute.cs (IAttributeSupport): New interface for attribute setting.
14287 Now it is possible to rewrite ApplyAttributes method to be less if/else.
14289 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
14290 Duplicated members and code in these classes has been removed.
14291 Better encapsulation in these classes.
14293 2004-02-07 Miguel de Icaza <miguel@ximian.com>
14295 * assign.cs (Assign.DoResolve): When dealing with compound
14296 assignments, there is a new rule in ECMA C# 2.4 (might have been
14297 there before, but it is documented here) that states that in:
14301 If b is of type int, and the `op' is a shift-operator, then the
14302 above is evaluated as:
14306 * expression.cs (Binary.ResolveOperator): Instead of testing for
14307 int/uint/long/ulong, try to implicitly convert to any of those
14308 types and use that in pointer arithmetic.
14310 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
14311 method to print information for from the type, not from the
14312 null-method we were given.
14314 2004-02-01 Duncan Mak <duncan@ximian.com>
14316 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
14317 parsing for cmd, fixes bug #53694.
14319 2004-02-04 Marek Safar <marek.safar@seznam.cz>
14321 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
14322 in the member name duplication tests. Property and operator name duplication
14323 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
14325 2004-02-03 Marek Safar <marek.safar@seznam.cz>
14327 * interface.cs (PopulateMethod): Fixed crash when interface method
14328 returns not existing type (error test cs0246-3.cs).
14330 2004-02-02 Ravi Pratap M <ravi@ximian.com>
14332 * cs-parser.jay (interface_accessors): Re-write actions to also
14333 store attributes attached to get and set methods. Fix spelling
14336 (inteface_property_declaration): Modify accordingly.
14338 (InterfaceAccessorInfo): New helper class to store information to pass
14339 around between rules that use interface_accessors.
14341 * interface.cs (Emit): Apply attributes on the get and set
14342 accessors of properties and indexers too.
14344 * attribute.cs (ApplyAttributes): Modify accordingly to use the
14345 right MethodBuilder when applying attributes to the get and set accessors.
14347 2004-01-31 Miguel de Icaza <miguel@ximian.com>
14349 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
14351 2004-01-26 Miguel de Icaza <miguel@ximian.com>
14353 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
14355 2004-01-25 Miguel de Icaza <miguel@ximian.com>
14357 * cs-parser.jay: Remove YIELD token, instead use the new grammar
14358 changes that treat `yield' specially when present before `break'
14359 or `return' tokens.
14361 * cs-tokenizer.cs: yield is no longer a keyword.
14363 2004-01-23 Marek Safar <marek.safar@seznam.cz>
14365 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
14366 setting for default constructors.
14367 For default constructors are almost every time set wrong Modifier. The
14368 generated IL code has been alright. But inside mcs this values was
14369 wrong and this was reason why several of my CLS Compliance tests
14372 2004-01-22 Martin Baulig <martin@ximian.com>
14374 * cs-parser.jay (namespace_or_type_name): Return an Expression,
14375 not a QualifiedIdentifier. This is what `type_name_expression'
14376 was previously doing.
14377 (type_name_expression): Removed; the code is now in
14378 `namespace_or_type_name'.
14379 (qualified_identifier): Removed, use `namespace_or_type_name'
14381 (QualifiedIdentifier): Removed this class.
14383 2004-01-22 Martin Baulig <martin@ximian.com>
14385 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
14386 not a string as alias name.
14388 2004-01-21 Miguel de Icaza <miguel@ximian.com>
14390 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
14391 #52730 bug, and instead compute correctly the need to use a
14392 temporary variable when requesting an address based on the
14393 static/instace modified of the field and the constructor.
14395 2004-01-21 Martin Baulig <martin@ximian.com>
14397 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
14398 class and namespace before looking up aliases. Fixes #52517.
14400 2004-01-21 Martin Baulig <martin@ximian.com>
14402 * flowanalysis.cs (UsageVector.Merge): Allow variables being
14403 assinged in a 'try'; fixes exception4.cs.
14405 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14406 * class.cs : Implemented parameter-less constructor for TypeContainer
14408 * decl.cs: Attributes are now stored here. New property OptAttributes
14410 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
14412 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
14414 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14416 * typemanager.cs (CSharpSignature): Now reports also inner class name.
14417 (CSharpSignature): New method for indexer and property signature.
14419 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14421 * pending.cs (IsVirtualFilter): Faster implementation.
14423 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14425 * typemanager.cs: Avoid inclusion of same assembly more than once.
14427 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14429 * cs-parser.jay: Fixed problem where the last assembly attribute
14430 has been applied also to following declaration (class, struct, etc.)
14432 2004-01-21 Marek Safar <marek.safar@seznam.cz>
14434 * class.cs: Added error CS0538, CS0539 reporting.
14435 Fixed crash on Microsoft runtime when field type is void.
14437 * cs-parser.jay: Added error CS0537 reporting.
14439 * pending.cs: Added error CS0535 reporting.
14440 Improved error report for errors CS0536, CS0534.
14442 2004-01-20 Miguel de Icaza <miguel@ximian.com>
14444 Merge a few bits from the Anonymous Method MCS tree.
14446 * statement.cs (ToplevelBlock): New class for toplevel methods,
14447 will hold anonymous methods, lifted variables.
14449 * cs-parser.jay: Create toplevel blocks for delegates and for
14450 regular blocks of code.
14452 2004-01-20 Martin Baulig <martin@ximian.com>
14454 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
14455 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
14456 and `NeedExplicitReturn'; added `IsLastStatement'.
14457 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
14458 have a `ReturnLabel' or we're not unreachable.
14460 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
14461 child's reachability; don't just override ours with it. Fixes
14462 #58058 (lluis's example).
14463 (FlowBranching): Added public InTryOrCatch(), InCatch(),
14464 InFinally(), InLoop(), InSwitch() and
14465 BreakCrossesTryCatchBoundary() methods.
14467 * statement.cs (Return): Do all error checking in Resolve().
14468 Unless we are the last statement in a top-level block, always
14469 create a return label and jump to it.
14470 (Break, Continue): Do all error checking in Resolve(); also make
14471 sure we aren't leaving a `finally'.
14472 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
14473 statement in a top-level block.
14474 (Block.Flags): Added `IsDestructor'.
14475 (Block.IsDestructor): New public property.
14477 2004-01-20 Martin Baulig <martin@ximian.com>
14479 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
14481 2004-01-20 Martin Baulig <martin@ximian.com>
14483 * statement.cs (Statement.ResolveUnreachable): New public method.
14484 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
14485 (Block.Resolve): Resolve unreachable statements.
14487 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14489 * expression.cs: We need to fix the case where we do
14490 not have a temp variable here.
14492 * assign.cs: Only expression compound assignments need
14493 temporary variables.
14495 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
14497 * flowanalysis.cs: Reduce memory allocation in a few ways:
14498 - A block with no variables should not allocate a bit
14500 - A method with no out parameters does not need any tracking
14501 for assignment of the parameters, so we need not allocate
14504 public readonly Type[] VariableTypes;
14505 public readonly string[] VariableNames;
14506 Are redundant. The data is already stored in the variable
14507 map, so we need not allocate another array for it.
14508 - We need to add alot of checks for if (params | locals) == null
14509 due to the first two changes.
14511 2004-01-18 Miguel de Icaza <miguel@ximian.com>
14513 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
14514 implement IMemoryLocation, we store a copy on a local variable and
14515 take the address of it. Patch from Benjamin Jemlich
14517 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
14518 to use a special "type_name_expression" rule which reduces the
14519 number of "QualifiedIdentifier" classes created, and instead
14520 directly creates MemberAccess expressions.
14522 2004-01-17 Miguel de Icaza <miguel@ximian.com>
14524 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
14525 that fixes #52853. Null literal assignment to ValueType
14527 * class.cs (MethodData.Emit): Instead of checking the name of the
14528 method to determine if its a destructor, create a new derived
14529 class from Method called Destructor, and test for that.
14531 * cs-parser.jay: Create a Destructor object instead of a Method.
14533 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
14537 2004-01-16 Miguel de Icaza <miguel@ximian.com>
14539 * expression.cs (Binary.ResolveOperator): Perform an implicit
14540 conversion from MethodGroups to their delegate types on the
14541 Addition operation.
14543 * delegate.cs: Introduce a new class DelegateCreation that is the
14544 base class for `NewDelegate' and `ImplicitDelegateCreation',
14545 factor some code in here.
14547 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
14548 conversion from MethodGroups to compatible delegate types.
14550 * ecore.cs (Expression.Resolve): Do not flag error 654
14551 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
14552 we allow conversions from MethodGroups to delegate types now.
14554 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
14555 assignments in v2 either.
14557 2004-01-10 Miguel de Icaza <miguel@ximian.com>
14559 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
14560 static read-only fields in ctors.
14562 Applied patch from Benjamin Jemlich
14564 * expression.cs (UnaryMutator): Avoid leaking local variables.
14566 2004-01-09 Miguel de Icaza <miguel@ximian.com>
14568 * cs-tokenizer.cs (IsCastToken): Allow the various native types
14569 here to return true, as they can be used like this:
14571 (XXX) int.MEMBER ()
14573 Fixed 49836 and all the other dups
14575 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
14577 * driver.cs: Implement /win32res and /win32icon.
14579 2004-01-08 Miguel de Icaza <miguel@ximian.com>
14581 * cs-parser.jay: Add a rule to improve error handling for the
14582 common mistake of placing modifiers after the type.
14584 2004-01-07 Miguel de Icaza <miguel@ximian.com>
14586 * cs-parser.jay (interface_event_declaration): Catch
14587 initialization of events on interfaces, and report cs0068
14589 * cs-parser.jay (interface_event_declaration): Catch
14590 initialization of events.
14592 * ecore.cs: Better report missing constructors.
14594 * expression.cs (Binary.ResolveOperator): My previous bug fix had
14595 the error reporting done in the wrong place. Fix.
14597 * expression.cs (Binary.ResolveOperator): Catch the
14598 operator + (E x, E y) error earlier, and later allow for implicit
14599 conversions in operator +/- (E e, U x) from U to the underlying
14602 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
14603 52596, if the container class is abstract, the default constructor
14604 is protected otherwise its public (before, we were always public).
14606 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
14609 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
14610 Jemlich that fixes bug #52597, MCS was generating invalid code for
14611 idisposable structs. Thanks to Ben for following up with this
14614 2004-01-06 Miguel de Icaza <miguel@ximian.com>
14616 * driver.cs: Allow assemblies without code to be generated, fixes
14619 2004-01-07 Nick Drochak <ndrochak@gol.com>
14621 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
14623 2004-01-05 Miguel de Icaza <miguel@ximian.com>
14625 * cs-parser.jay: Add rules to improve error reporting if fields or
14626 methods are declared at the namespace level (error 116)
14628 * Add rules to catch event add/remove
14630 2004-01-04 David Sheldon <dave-mono@earth.li>
14632 * expression.cs: Added matching ")" to error message for
14635 2004-01-03 Todd Berman <tberman@gentoo.org>
14637 * ecore.cs, attribute.cs:
14638 Applying fix from #52429.
14640 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14642 * ecore.cs, expression.cs, statement.cs:
14643 Total rewrite of how we handle branching. We
14644 now handle complex boolean expressions with fewer
14645 jumps. As well if (x == 0) no longer emits a ceq.
14647 if (x is Foo) is much faster now, because we generate
14650 Overall, we get a pretty big improvement on our benchmark
14651 tests. The code we generate is smaller and more readable.
14653 I did a full two-stage bootstrap. The patch was reviewed
14654 by Martin and Miguel.
14656 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14658 * cs-parser.jay: Make primary_expression not take a QI.
14659 we dont need this because the member_access rule covers
14660 us here. So we replace the rule with just IDENTIFIER.
14662 This has two good effects. First, we remove a s/r conflict.
14663 Second, we allocate many fewer QualifiedIdentifier objects.
14665 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14667 * attribute.cs: Handle MarshalAs attributes as pseudo, and
14668 set the correct information via SRE. This prevents
14669 hanging on the MS runtime. Fixes #29374.
14671 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
14673 * convert.cs: correctly handle conversions to value types
14674 from Enum and ValueType as unboxing conversions.
14676 Fixes bug #52569. Patch by Benjamin Jemlich.
14678 2004-01-02 Ravi Pratap <ravi@ximian.com>
14680 * expression.cs (BetterConversion): Prefer int -> uint
14681 over int -> ulong (csc's behaviour). This fixed bug #52046.
14683 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
14685 * decl.cs (MemberCache.FindMembers): now returns a
14688 * typemanager.cs: In general, go with with ^^.
14689 (CopyNewMethods): take an IList.
14690 (RealMemberLookup): Only allocate an arraylist
14691 if we copy from two sets of methods.
14693 This change basically does two things:
14694 1) Fewer array lists allocated due to CopyNewMethods.
14695 2) the explicit cast in MemberList costed ALOT.
14697 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
14699 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
14700 a hashtable to avoid needless string allocations when an identifier is
14701 used more than once (the common case).
14703 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
14705 * pending.cs: MS's TypeBuilder.GetInterfaces ()
14706 is broken, it will not return anything. So, we
14707 have to use the information we have in mcs to
14710 * typemanager.cs: Add a cache for GetInterfaces,
14711 since this will now be used more often (due to ^^)
14713 (GetExplicitInterfaces) New method that gets the
14714 declared, not effective, interfaces on a type
14715 builder (eg, if you have interface IFoo, interface
14716 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
14719 This patch makes MCS able to bootstrap itself on
14722 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
14724 * expression.cs: Remove the Nop's that Miguel put
14727 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14729 * report.cs, codegen.cs: Give the real stack trace to
14730 the error when an exception is thrown.
14732 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14734 * decl.cs: only allocate hashtables for ifaces if
14737 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
14739 * expression.cs: fix the error from cs0121-2.cs
14740 (a parent interface has two child interfaces that
14741 have a function with the same name and 0 params
14742 and the function is called through the parent).
14744 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
14746 * class.cs, rootcontext.cs, typmanager.cs: do not
14749 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
14751 * codegen.cs: remove stack for the ec flow branching.
14752 It is already a linked list, so no need.
14754 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
14756 * Makefile: Allow custom profiler here.
14758 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
14760 * typemanager.cs (LookupType):
14761 - Use a static char [], because split takes
14762 a param array for args, so it was allocating
14764 - Do not store true in a hashtable, it boxes.
14766 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
14768 * flowanalysis.cs: bytify common enums.
14770 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14772 * modifiers.cs: Add a new set of flags for the
14773 flags allowed on explicit interface impls.
14774 * cs-parser.jay: catch the use of modifiers in
14775 interfaces correctly.
14776 * class.cs: catch private void IFoo.Blah ().
14778 All related to bug #50572.
14780 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14782 * decl.cs: Rewrite the consistant accessability checking.
14783 Accessability is not linear, it must be implemented in
14784 a tableish way. Fixes #49704.
14786 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
14788 * expression.cs: Handle negation in a checked context.
14789 We must use subtraction from zero. Fixes #38674.
14791 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
14793 * class.cs: Ignore static void main in DLLs.
14794 * rootcontext.cs: Handle the target type here,
14795 since we are have to access it from class.cs
14796 * driver.cs: account for the above.
14798 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
14800 * report.cs: Give line numbers and files if available.
14802 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
14804 * driver.cs: Implement /addmodule.
14806 * typemanager.cs: Change 'modules' field so it now contains Modules not
14809 2003-12-20 Martin Baulig <martin@ximian.com>
14811 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
14812 (FieldBase.IsAssigned): Removed this field.
14813 (FieldBase.SetAssigned): New public method.
14814 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
14816 2003-12-20 Martin Baulig <martin@ximian.com>
14818 * expression.cs (LocalVariableReference.DoResolve): Don't set
14819 `vi.Used' if we're called from DoResolveLValue().
14821 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
14822 returns the usage vector it just merged into the current one -
14823 pass this one to UsageWarning().
14824 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
14825 of the `EmitContext', don't call this recursively on our children.
14827 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
14829 * driver.cs: Implement /target:module.
14831 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
14833 * support.cs (CharArrayHashtable): New helper class.
14835 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
14836 char arrays, not strings, so we can avoid creating a string in
14837 consume_identifier if the identifier is a keyword.
14839 2003-12-16 Martin Baulig <martin@ximian.com>
14841 * statement.cs (LocalInfo.Assigned): Removed this property.
14842 (LocalInfo.Flags): Removed `Assigned'.
14843 (LocalInfo.IsAssigned): New public method; takes the EmitContext
14844 and uses flow analysis.
14845 (Block.UsageWarning): Made this method private.
14846 (Block.Resolve): Call UsageWarning() if appropriate.
14848 * expression.cs (LocalVariableReference.DoResolve): Always set
14849 LocalInfo.Used here.
14851 2003-12-13 Martin Baulig <martin@ximian.com>
14853 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
14854 any value here; we're now using flow analysis to figure out
14855 whether a statement/block returns a value.
14857 2003-12-13 Martin Baulig <martin@ximian.com>
14859 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
14861 (FlowBranching.MergeFinally): Don't call
14862 `branching.CheckOutParameters()' here, this is called in
14864 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
14865 when adding the `finally' vector.
14867 2003-12-13 Martin Baulig <martin@ximian.com>
14870 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
14871 actually work and also fix #48962.
14873 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
14875 * decl.cs: Do not check System.Object for nested types,
14876 since we know it does not have any. Big bang for buck:
14879 Run 1: 8.35 seconds
14880 Run 2: 8.32 seconds
14881 corlib: 17.99 seconds
14883 Run 1: 8.17 seconds
14884 Run 2: 8.17 seconds
14885 corlib: 17.39 seconds
14887 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
14889 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
14890 time we are returning 0 members, so we save alot here.
14892 2003-12-11 Martin Baulig <martin@ximian.com>
14894 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
14895 `MergeChild()', also just take the `FlowBranching' as argument;
14896 call Merge() on it and return the result.
14897 (FlowBranching.Merge): We don't need to do anything if we just
14900 2003-12-11 Martin Baulig <martin@ximian.com>
14902 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
14903 them in an `ArrayList' to reduce memory usage. Thanks to Ben
14904 Maurer for this idea.
14906 2003-12-11 Martin Baulig <martin@ximian.com>
14908 * flowanalysis.cs (MergeResult): This class is now gone; we now
14909 use the `UsageVector' for this. The reason for this is that if a
14910 branching just has one sibling, we don't need to "merge" them at
14911 all - that's the next step to do.
14912 (FlowBranching.Merge): We now return a `UsageVector' instead of a
14915 2003-12-11 Martin Baulig <martin@ximian.com>
14917 Reworked flow analyis and made it more precise and bug-free. The
14918 most important change is that we're now using a special `Reachability'
14919 class instead of having "magic" meanings of `FlowReturns'. I'll
14920 do some more cleanups and optimizations and also add some more
14921 documentation this week.
14923 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
14924 largely reworked this class.
14925 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
14926 the new `Reachability' class instead of having "magic" values here.
14927 (FlowBranching): We're now using an instance of `Reachability'
14928 instead of having separate `Returns', `Breaks' etc. fields.
14930 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
14931 based on flow analysis; ignore the return value of block.Emit ().
14933 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
14935 * driver.cs typemanager.cs: Find the mono extensions to corlib even
14936 if they are private.
14938 2003-12-09 Martin Baulig <martin@ximian.com>
14940 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
14941 call them directly on the UsageVector.
14943 2003-12-09 Martin Baulig <martin@ximian.com>
14945 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
14946 Changed return type from `FlowReturns' to `Reachability'.
14948 2003-12-09 Martin Baulig <martin@ximian.com>
14950 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
14951 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
14952 `Reachable' fields with a single `Reachability' one.
14954 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
14956 * class.cs (FindMembers): Remove foreach's.
14961 Run 1: 8.74 seconds
14962 Run 2: 8.71 seconds
14965 Run 1: 8.64 seconds
14966 Run 2: 8.58 seconds
14969 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
14974 This patch does a few things:
14975 1. EmptyStatement is now a singleton, so it is never reallocated.
14976 2. All blah is EmptyStatement constructs have been changed to
14977 blah == EmptyStatement.Value, which is much faster and valid
14978 now that EmptyStatement is a singleton.
14979 3. When resolving a block, rather than allocating a new array for
14980 the non-empty statements, empty statements are replaced with
14981 EmptyStatement.Value
14982 4. Some recursive functions have been made non-recursive.
14983 Mainly the performance impact is from (3), however (1) and (2) are needed for
14984 this to work. (4) does not make a big difference in normal situations, however
14985 it makes the profile look saner.
14990 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
14991 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
14992 Total memory allocated: 56397 KB
14995 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
14996 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
14997 Total memory allocated: 55666 KB
14999 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15001 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
15002 than the hashtable in a hashtable version
15004 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
15005 we always end up concating a string. This results in a huge perf
15006 loss, because many strings have to be tracked by the GC. In this
15007 patch, we first use a hashtable that works with two keys, so that
15008 the strings do not need to be concat'ed.
15012 Run 1: 8.74 seconds
15013 Run 2: 8.71 seconds
15016 Run 1: 8.65 seconds
15017 Run 2: 8.56 seconds
15019 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15021 * Makefile: Add a new target `do-time' that does a quick and simple
15022 profile, leaving easy to parse output.
15024 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
15026 * codegen.cs (Init): Create the dynamic assembly with
15027 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
15029 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
15031 * support.cs: Make the PtrHashtable use only one
15032 instance of its comparer.
15034 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
15036 * typemanager.cs: Fix lookup of GetNamespaces.
15038 2003-11-29 Miguel de Icaza <miguel@ximian.com>
15040 * expression.cs: Removed redundant line.
15042 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
15043 ArrayLists, use for loops with bounds.
15045 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
15048 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
15049 arraylists, use for loop with bounds.
15051 The above three changes give us a 0.071 second performance
15052 improvement out of 3.294 seconds down to 3.223. On my machine
15053 the above changes reduced the memory usage by 1,387 KB during
15054 compiler bootstrap.
15056 * cs-parser.jay (QualifiedIdentifier): New class used to represent
15057 QualifiedIdentifiers. Before we created a new string through
15058 concatenation, and mostly later on, the result would be
15059 manipulated by DecomposeQI through string manipulation.
15061 This reduced the compiler memory usage for bootstrapping from
15062 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
15063 compile times in 0.05 seconds.
15065 2003-11-28 Dick Porter <dick@ximian.com>
15067 * support.cs: Do string compares with the Invariant culture.
15075 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
15076 the comparison is done with the Invariant culture.
15078 2003-11-27 Miguel de Icaza <miguel@ximian.com>
15080 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
15081 GetEnumerator method.
15083 (ProbeCollectionType): Iterate starting at the most specific type
15084 upwards looking for a GetEnumerator
15086 * expression.cs: Shift count can be up to 31 for int/uint and 63
15089 2003-11-26 Miguel de Icaza <miguel@ximian.com>
15091 * statement.cs (Block.LookupLabel): Also look for the label on the
15092 children blocks. Use a hash table to keep track of visited
15095 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
15096 we actually did transform the other operand, otherwise fall back
15097 to the common codepath that casts to long.
15099 * cs-tokenizer.cs: Use the same code pattern as the int case.
15100 Maybe I should do the parsing myself, and avoid depending on the
15101 Parse routines to get this done.
15103 2003-11-25 Miguel de Icaza <miguel@ximian.com>
15105 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15106 which fixes bug 51347. This time test it.
15108 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
15109 attributes for example can not tell the difference between these.
15110 The difference was only a syntax feature of the language.
15112 * attribute.cs: Apply attributes to delegates.
15114 * delegate.cs: Call the apply attributes method.
15116 2003-11-24 Miguel de Icaza <miguel@ximian.com>
15118 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
15119 comparing 0 vs Byte.MinValue, not the value
15121 (ImplicitConversionRequired): When reporting a conversion error,
15122 use error 31 to print out the constant error instead of the
15125 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
15126 which fixes bug 51347.
15128 2003-11-22 Miguel de Icaza <miguel@ximian.com>
15130 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
15131 which fixes the -warnaserror command line option.
15133 2003-11-21 Miguel de Icaza <miguel@ximian.com>
15135 * cfold.cs (DoNumericPromotions): During constant folding of
15136 additions on UIntConstant, special case intconstants with
15137 IntConstants like we do on the expression binary operator.
15139 2003-11-12 Miguel de Icaza <miguel@ximian.com>
15141 * convert.cs (ImplicitReferenceConversion): We were missing a case
15142 (System.Enum are not value types or class types, so we need to
15143 classify them separatedly).
15145 * driver.cs: We do not support error 2007.
15147 2003-11-12 Jackson Harper <jackson@ximian.com>
15149 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
15150 system directory. Also use the full file name so users can
15151 libraries names mscorlib-o-tron.dll in a non system dir.
15153 2003-11-10 Martin Baulig <martin@ximian.com>
15155 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
15156 (TypeManager.InitCoreTypes): Initialize them here, but instead of
15157 calling `ResolveType()' on them, directly assign their `Type'.
15159 2003-11-08 Martin Baulig <martin@ximian.com>
15161 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
15162 return value and the `out parent' parameter.
15163 (TypeContainer.DefineType): Moved the CS0644 check into
15164 GetClassBases(). Don't pass the interface types to the
15165 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
15166 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
15168 * ecore.cs (TypeExpr.IsAttribute): New property.
15169 (TypeExpr.GetInterfaces): New method.
15171 * interface.cs (Interface.GetInterfaceTypeByName): Return a
15172 TypeExpr instead of a Type.
15173 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
15174 (Interface.DefineType): Don't pass the interface types to the
15175 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
15176 them later and then call `TypeBulider.AddInterfaceImplementation()'.
15178 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
15179 instead of a `Type[]'.
15180 (TypeManager.RegisterBuilder): Likewise.
15181 (TypeManager.AddUserInterface): Likewise.
15182 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
15183 `Type[]' and also return a `TypeExpr[]'.
15184 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
15186 2003-11-08 Martin Baulig <martin@ximian.com>
15188 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
15191 2003-11-08 Martin Baulig <martin@ximian.com>
15193 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
15194 TypeManager.ResolveExpressionTypes().
15196 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
15197 instead of an Expression.
15198 (TypeExpr): This is now an abstract base class for `TypeExpression'.
15199 (TypeExpression): New public class; formerly known as `TypeExpr'.
15201 * expression.cs (ComposedCast): Derive from TypeExpr.
15203 * typemanager.cs (TypeManager.system_*_expr): These are now
15204 TypExpr's instead of Expression's.
15205 (TypeManager.ResolveExpressionTypes): New public static function;
15206 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
15209 2003-11-06 Miguel de Icaza <miguel@ximian.com>
15211 * expression.cs (New.DoResolve): Do not dereference value that
15212 might be a null return.
15214 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
15215 sure that the constant value has the right type. Fixes an
15216 unreported bug, similar to 50425.
15218 * const.cs (Const.LookupConstantValue): Call
15219 ImplicitStandardConversionExists before doing a conversion to
15220 avoid havng the TypeManager.ChangeType do conversions.
15222 Reduced the number of casts used
15224 (Const.ChangeType): New routine to enable reuse of the constant
15225 type changing code from statement.
15227 * typemanager.cs (ChangeType): Move common initialization to
15228 static global variables.
15232 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
15233 every value type to go through, even if it was void. Fix that.
15235 * cs-tokenizer.cs: Use is_identifier_start_character on the start
15236 character of the define, and the is_identifier_part_character for
15237 the rest of the string.
15239 2003-11-05 Miguel de Icaza <miguel@ximian.com>
15241 * expression.cs (UnaryMutator.EmitCode): When I updated
15242 LocalVariableReference.DoResolve, I overdid it, and dropped an
15243 optimization done on local variable references.
15245 2003-11-04 Miguel de Icaza <miguel@ximian.com>
15247 * ecore.cs: Convert the return from Ldlen into an int.
15249 2003-10-20 Miguel de Icaza <miguel@ximian.com>
15251 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
15252 the accessibility, this is a special case for toplevel non-public
15253 classes (internal for instance).
15255 2003-10-20 Nick Drochak <ndrochak@gol.com>
15257 * ecore.cs: Fix typo and build. Needed another right paren.
15259 2003-10-19 Miguel de Icaza <miguel@ximian.com>
15261 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
15262 `internal' case regular and protected, but not allowing protected
15263 to be evaluated later. Bug 49840
15265 2003-10-15 Miguel de Icaza <miguel@ximian.com>
15267 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
15268 to kb.Nlast, and not the kb.nFirst to isolate the switch
15271 Extract the underlying type, so enumerations of long/ulong are
15272 treated like long/ulong.
15274 2003-10-14 Miguel de Icaza <miguel@ximian.com>
15276 * expression.cs (New): Overload the meaning of RequestedType to
15277 track the possible creation of the NewDelegate type, since
15278 DoResolve is invoked more than once for new constructors on field
15281 See bugs: #48800 and #37014
15283 * cs-parser.jay (declare_local_constants): Take an arraylist
15284 instead of a single constant.
15286 (local_constant_declaration): It should take a
15287 constant_declarators, not a constant_declarator. Fixes 49487
15289 * convert.cs: Fix error report.
15291 2003-10-13 Jackson Harper <jackson@ximian.com>
15293 * typemanager.cs (TypeToCoreType): Add float and double this fixes
15296 2003-10-09 Martin Baulig <martin@ximian.com>
15298 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
15300 (MethodCore.DoDefineParameters): Removed the TypeContainer
15301 argument; use the DeclSpace which was passed to the .ctor instead.
15302 (MethodCore.CheckParameter): Take a DeclSpace instead of a
15303 TypeContainer; we only need a DeclSpace here.
15305 2003-10-09 Martin Baulig <martin@ximian.com>
15307 * class.cs (MethodData): Added additional `DeclSpace ds' argument
15309 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
15310 EmitContext's .ctor.
15312 2003-10-09 Martin Baulig <martin@ximian.com>
15314 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
15315 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
15316 AsAccessible(), moved them as well.
15318 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
15320 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
15322 * cs-parser.jay : Renamed yyName to yyNames related to jay.
15324 2003-10-07 Miguel de Icaza <miguel@ximian.com>
15326 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
15327 generation for >=, as spotted by Paolo, bug 48679.
15328 Patch from David Waite.
15330 * cs-tokenizer.cs: Add handling for #pragma.
15332 * cs-parser.jay: Allow for both yield and yield return in the
15333 syntax. The anti-cobolization of C# fight will go on!
15335 * class.cs (TypeBuilder.DefineType): Catch error condition here
15336 (Parent.DefineType erroring out and returning null).
15338 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15339 coping with enumerations variables, we were mistakenly processing
15340 them as a regular value type instead of built-in types. Fixes the
15343 * typemanager.cs (IsBuiltinOrEnum): New method.
15345 2003-09-30 Miguel de Icaza <miguel@ximian.com>
15347 * cs-parser.jay: Upgrade: yield now needs the return clause.
15349 2003-09-19 Martin Baulig <martin@ximian.com>
15351 * decl.cs (MemberCache.SetupCacheForInterface): Take a
15352 `MemberCache parent' argument. Normally, an interface doesn't
15353 have a parent type except System.Object, but we use this in gmcs
15354 for generic type parameters.
15356 2003-09-18 Martin Baulig <martin@ximian.com>
15358 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
15359 on `type.IsInterface'; don't check whether the type has a parent
15360 to determine whether it's an interface.
15362 2003-09-15 Martin Baulig <martin@ximian.com>
15364 * class.cs (TypeContainer.DefineType): Added an error flag to
15365 avoid reporting duplicate CS0146's ("class definition is
15368 * driver.cs (Driver.MainDriver): Abort if
15369 RootContext.ResolveTree() reported any errors.
15371 2003-09-07 Martin Baulig <martin@ximian.com>
15373 * report.cs (Error, Warning): Added overloaded versions which take
15374 a `params object[] args' and call String.Format().
15376 2003-09-07 Martin Baulig <martin@ximian.com>
15378 * decl.cs (DeclSpace..ctor): Don't call
15379 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
15380 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
15381 (DeclSpace.RecordDecl): New method.
15383 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
15385 2003-09-02 Ravi Pratap <ravi@ximian.com>
15387 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
15388 value attributes to be applied to ParameterBuilders.
15390 * class.cs (MethodCore.LabelParameters): Make static and more
15391 generic so that it can be used from other places - like interface
15392 methods, for instance.
15394 * interface.cs (Interface.Emit): Call LabelParameters before
15395 emitting attributes on the InterfaceMethod.
15397 2003-08-26 Martin Baulig <martin@ximian.com>
15399 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
15400 resolving aliases; fixes #47927.
15402 2003-08-26 Martin Baulig <martin@ximian.com>
15404 * statement.cs (Using.DoResolve): This is internally emitting a
15405 try/finally clause, so we need to set ec.NeedExplicitReturn if we
15406 do not always return. Fixes #47681.
15408 2003-08-26 Martin Baulig <martin@ximian.com>
15410 * decl.cs (MemberCore): Moved WarningNotHiding(),
15411 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
15413 (AdditionResult): Make this nested in DeclSpace.
15414 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
15415 argument; call NamespaceEntry.Define() unless we're nested in a
15418 * namespace.cs (Namespace.DefineName): New public function. This
15419 is called from DeclSpace's .ctor to add
15420 (Namespace.Lookup): Include DeclSpaces in the lookup.
15422 * class.cs (Operator): Derive from MemberBase, not MemberCore.
15424 * const.cs (Const): Derive from MemberBase, not MemberCore.
15426 2003-08-25 Martin Baulig <martin@ximian.com>
15428 * convert.cs (Convert.ExplicitReferenceConversion): When
15429 converting from an interface type to a class, unbox if the target
15430 type is a struct type. Fixes #47822.
15432 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15434 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
15437 2003-08-22 Martin Baulig <martin@ximian.com>
15439 * class.cs (TypeManager.DefineType): When defining a nested type,
15440 call DefineType() on our parent; fixes #47801.
15442 2003-08-22 Martin Baulig <martin@ximian.com>
15444 * class.cs (MethodData.Define): While checking if a method is an
15445 interface implementation, improve the test a bit more to fix #47654.
15447 2003-08-22 Martin Baulig <martin@ximian.com>
15449 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
15450 correctly; fixes #47722.
15452 2003-08-22 Martin Baulig <martin@ximian.com>
15454 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
15455 LocalVariableReference, ensure it's not read-only. Fixes #47536.
15457 * statement.cs (Fixed.DoResolve): Make all variables read-only.
15459 2003-08-22 Martin Baulig <martin@ximian.com>
15461 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
15462 can only be assigned in static constructors. Fixes #47161.
15464 2003-08-22 Martin Baulig <martin@ximian.com>
15466 Rewrote and improved the flow analysis code.
15468 * flowbranching.cs (FlowBranching): Make this class abstract.
15469 (FlowBranching.CreateBranching): New static function to create a
15470 new flow branching.
15471 (FlowBranchingBlock, FlowBranchingException): New classes.
15472 (FlowBranching.UsageVector.Type): New public readonly field.
15473 (FlowBranching.UsageVector.Breaks): Removed the setter.
15474 (FlowBranching.UsageVector.Returns): Removed the setter.
15475 (FlowBranching.UsageVector): Added Break(), Return(),
15476 NeverReachable() and Throw() methods to modify the reachability.
15477 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
15478 done by FlowBranching.Merge().
15479 (FlowBranching.UsageVector.MergeChild): New method; merges the
15480 merge result into the current vector.
15481 (FlowBranching.Merge): New abstract method to merge a branching.
15483 2003-08-12 Martin Baulig <martin@ximian.com>
15485 * expression.cs (Indirection.CacheTemporaries): Create the
15486 LocalTemporary with the pointer type, not its element type.
15488 2003-08-10 Miguel de Icaza <miguel@ximian.com>
15490 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
15491 token was a keyword or not.
15493 Add `error' options where an IDENTIFIER was expected; Provide
15494 CheckToken and CheckIdentifierToken convenience error reporting
15497 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
15499 * decl.cs: Rename `NamespaceEntry Namespace' public field into
15500 NameSpaceEntry NameSpaceEntry.
15502 (LookupInterfaceOrClass): Avoid creating a full qualified name
15503 from namespace and name: avoid doing lookups when we know the
15504 namespace is non-existant. Use new Tree.LookupByNamespace which
15505 looks up DeclSpaces based on their namespace, name pair.
15507 * driver.cs: Provide a new `parser verbose' to display the
15508 exception thrown during parsing. This is turned off by default
15509 now, so the output of a failure from mcs is more graceful.
15511 * namespace.cs: Track all the namespaces defined in a hashtable
15514 (IsNamespace): New method
15516 2003-08-09 Miguel de Icaza <miguel@ximian.com>
15518 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
15519 we know that we need to concatenate (full typename can never be
15524 * statement.cs: Use a bitfield; Do not initialize to null things
15525 which are done by the constructor by default.
15527 * cs-parser.jay: bug fix, parameter was 4, not 3.
15529 * expression.cs: Just use the property;
15531 * statement.cs: No need for GetVariableInfo method.
15533 2003-08-08 Martin Baulig <martin@ximian.com>
15535 * flowanalysis.cs (FlowReturns): This is now nested in the
15536 `FlowBranching' class.
15537 (MyBitVector): Moved this here from statement.cs.
15538 (FlowBranching.SiblingType): New enum type.
15539 (FlowBranching.CreateSibling): Added `SiblingType' argument.
15541 2003-08-07 Martin Baulig <martin@ximian.com>
15543 * flowanalysis.cs (FlowBranchingType): This is now nested in the
15544 `FlowBranching' class and called `BranchingType'.
15546 2003-08-07 Martin Baulig <martin@ximian.com>
15548 * flowanalysis.cs: Moved all the control flow analysis code into
15551 2003-08-07 Martin Baulig <martin@ximian.com>
15553 * assign.cs (Assign.DoResolve): `target' must either be an
15554 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
15557 2003-08-07 Miguel de Icaza <miguel@ximian.com>
15559 * expression.cs (BinaryMethod): This kind of expression is created by the
15560 Binary class if it determines that the operator has to be handled
15563 (BinaryDelegate): This kind of expression is created if we are
15564 dealing with a + or - operator on delegates.
15566 (Binary): remove method, argumetns, and DelegateOperator: when
15567 dealing with methods,
15569 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
15571 * statement.cs (Block): use bitfields for the three extra booleans
15572 we had in use. Remove unused topblock parameter.
15574 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
15576 * assign.cs: Drop extra unneeded tests.
15578 2003-08-06 Miguel de Icaza <miguel@ximian.com>
15580 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
15582 * statement.cs (Foreach): Use VariableStorage instead of
15585 * codegen.cs (VariableStorage): New class used by clients that
15586 require a variable stored: locals or fields for variables that
15587 need to live across yield.
15589 Maybe provide a convenience api for EmitThis+EmitLoad?
15591 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
15594 2003-08-05 Miguel de Icaza <miguel@ximian.com>
15596 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
15597 RemapParameterLValue): New methods that are used to turn a
15598 precomputed FieldInfo into an expression like this:
15602 The idea is to use this instead of making LocalVariableReference
15603 have more than one meaning.
15605 * cs-parser.jay: Add error production to BASE.
15607 * ecore.cs: Deal with TypeManager.GetField returning null, which
15608 is now a valid return value.
15610 (FieldExprNoAddress): New expression for Fields whose address can
15613 * expression.cs (LocalVariableReference): During the resolve
15614 phases, create new expressions if we are in a remapping context.
15615 Remove code that dealt with remapping here.
15617 (ParameterReference): same.
15619 (ProxyInstance): New expression, like the `This' expression, but
15620 it is born fully resolved. We know what we are doing, so remove
15621 the errors that are targeted to user-provided uses of `this'.
15623 * statement.cs (Foreach): our variable is now stored as an
15624 Expression; During resolution, follow the protocol, dont just
15625 assume it will return this.
15627 2003-08-06 Martin Baulig <martin@ximian.com>
15629 * support.cs (SeekableStreamReader.cs): New public class.
15631 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
15632 SeekableStreamReader instead of the normal StreamReader.
15634 2003-08-04 Martin Baulig <martin@ximian.com>
15636 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
15637 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
15638 deambiguate casts and delegate invocations.
15639 (parenthesized_expression): Use the new tokens to ensure this is
15640 not a cast of method invocation.
15642 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
15643 when reading a `)' and Deambiguate_CloseParens () was previously
15646 * expression.cs (ParenthesizedExpression): New class. This is
15647 just used for the CS0075 test.
15648 (Binary.DoResolve): Check for CS0075.
15650 2003-07-29 Ravi Pratap <ravi@ximian.com>
15652 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
15653 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
15654 reference comparison.
15656 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
15657 examine the ReturnType for equality - this is necessary in the
15658 cases of implicit and explicit operators whose signature also
15659 includes the return type.
15661 2003-07-26 Miguel de Icaza <miguel@ximian.com>
15663 * namespace.cs: Cache the result of the namespace computation,
15664 instead of computing it every time.
15666 2003-07-24 Miguel de Icaza <miguel@ximian.com>
15668 * decl.cs: Use a global arraylist that we reuse over invocations
15669 to avoid excesive memory consumption. Reduces memory usage on an
15670 mcs compile by one meg (45 average).
15672 * typemanager.cs (LookupTypeReflection): In .NET pointers are
15673 private, work around that.
15675 2003-07-23 Miguel de Icaza <miguel@ximian.com>
15677 * literal.cs (IntLiteral): Define Zero and One static literals.
15679 * cs-parser.jay (integer_literal): use static literals to reduce
15680 memory usage for the most used literals (0, 1 and -1). 211kb
15681 reduced in memory usage.
15683 Replace all calls to `new ArrayList' with `new
15684 ArrayList(4)' which is a good average number for most allocations,
15685 and also requires only 16 bytes of memory for its buffer by
15688 This reduced MCS memory usage in seven megabytes for the RSS after
15691 2003-07-28 Ravi Pratap <ravi@ximian.com>
15693 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
15694 handle params methods the correct way by forming only one
15695 applicable set with params and normal methods in them. Earlier we
15696 were looking at params methods only if we found no normal methods
15697 which was not the correct thing to do.
15699 (Invocation.BetterFunction): Take separate arguments indicating
15700 when candidate and the best method are params methods in their
15703 This fixes bugs #43367 and #46199.
15705 * attribute.cs: Documentation updates.
15707 (CheckAttribute): Rename to CheckAttributeTarget.
15708 (GetValidPlaces): Rename to GetValidTargets.
15710 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
15711 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
15715 2003-07-28 Martin Baulig <martin@ximian.com>
15717 * class.cs (TypeContainer.DefineMembers): Use the base type's full
15718 name when looking up the base class of a nested class. Fixes #46977.
15720 2003-07-26 Martin Baulig <martin@ximian.com>
15722 * expression.cs (Indexers.Indexer): New nested struct; contains
15723 getter, setter and the indexer's type.
15724 (Indexers.Properties): This is now an ArrayList of
15725 Indexers.Indexer's.
15726 (IndexerAccess.DoResolveLValue): Correctly set the type if the
15727 indexer doesn't have any getters.
15729 * assign.cs (Assign.DoResolve): Also do the implicit conversions
15730 for embedded property and indexer assignments.
15732 2003-07-26 Martin Baulig <martin@ximian.com>
15734 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
15735 preprocessor directive is not the first non-whitespace character
15738 2003-07-26 Martin Baulig <martin@ximian.com>
15740 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
15741 namespace parsing, follow the spec more closely.
15743 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
15744 NamespaceEntry.Lookup().
15746 2003-07-25 Martin Baulig <martin@ximian.com>
15748 * MethodCore.cs (OverridesSomething): New public field; it's set
15749 from TypeContainer.DefineMembers if this method overrides
15750 something (which doesn't need to be a method). Fix #39462.
15752 2003-07-25 Ravi Pratap <ravi@ximian.com>
15754 * typemanager.cs (GetMembers): Ensure that the list of members is
15755 reversed. This keeps things in sync.
15757 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
15758 find an AttributeUsage attribute.
15760 * expression.cs (Invocation.OverloadResolve): Perform the check
15761 which disallows Invoke to be directly called on a Delegate.
15763 (Error_InvokeOnDelegate): Report error cs1533.
15765 2003-07-25 Martin Baulig <martin@ximian.com>
15767 * expression.cs (Indexers.GetIndexersForType): Only look in the
15768 interface hierarchy if the requested type is already an
15769 interface. Fixes #46788 while keeping #46502 fixed.
15771 2003-07-25 Martin Baulig <martin@ximian.com>
15773 * class.cs (TypeContainer.DefineMembers): Check whether all
15774 readonly fields have been assigned and report warning CS0649 if
15777 * statement.cs (LocalInfo.IsFixed): Always return true if this is
15780 2003-07-24 Ravi Pratap <ravi@ximian.com>
15782 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
15783 returned from GetMethods to make things consistent with the
15784 assumptions MCS makes about ordering of methods.
15786 This should comprehensively fix bug #45127 and it does :-)
15788 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
15789 ordering is actually reverse.
15791 * Clean up some debug messages I left lying around.
15793 * interface.cs (Populate*): Get rid of code which emits attributes
15794 since the stage in which we emit attributes is the 'Emit' stage,
15795 not the define stage.
15797 (Emit): Move attribute emission for interface members here.
15799 2003-07-22 Ravi Pratap <ravi@ximian.com>
15801 * expression.cs (Invocation.OverloadResolve): Follow the spec more
15802 closely: we eliminate methods in base types when we have an
15803 applicable method in a top-level type.
15805 Please see section 14.5.5.1 for an exact description of what goes
15808 This fixes bug #45127 and a host of other related to corlib compilation.
15810 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
15811 array is the method corresponding to the top-level type (this is
15812 because of the changes made to icall.c) so we change this
15815 (MethodGroupExpr.Name): This too.
15817 * typemanager.cs (GetElementType): New method which does the right
15818 thing when compiling corlib.
15820 * everywhere: Make use of the above in the relevant places.
15822 2003-07-22 Martin Baulig <martin@ximian.com>
15824 * cs-parser.jay (invocation_expression): Moved
15825 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
15826 `cast_expression', but create a InvocationOrCast which later
15827 resolves to either an Invocation or a Cast.
15829 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
15830 method; call this before EmitStatement() to make sure that this
15831 expression can be used as a statement.
15833 * expression.cs (InvocationOrCast): New class; resolves to either
15834 an Invocation or a Cast.
15836 * statement.cs (StatementExpression): Call ResolveStatement() on
15837 the ExpressionStatement before emitting it.
15839 2003-07-21 Martin Baulig <martin@ximian.com>
15841 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
15842 `ref' and `out' attributes match; fixes #46220.
15843 (MemberAccess.ResolveMemberAccess): You can't reference a type
15844 through an expression; fixes #33180.
15845 (Indexers.GetIndexersForType): Don't return the indexers from
15846 interfaces the class implements; fixes #46502.
15848 2003-07-21 Martin Baulig <martin@ximian.com>
15850 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
15851 CS0661 checks; fixes bug #30442.
15853 2003-07-21 Martin Baulig <martin@ximian.com>
15855 * decl.cs (AdditionResult): Added `Error'.
15857 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
15859 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
15860 makes cs0031.cs actually work.
15862 2003-07-20 Martin Baulig <martin@ximian.com>
15864 * namespace.cs: Fixed that bug which caused a crash when compiling
15865 the debugger's GUI.
15867 2003-07-20 Miguel de Icaza <miguel@ximian.com>
15869 * typemanager.cs (LookupTypeReflection): Never expose types which
15870 are NotPublic, NestedPrivate, NestedAssembly, or
15871 NestedFamANDAssem. We used to return these, and later do a check
15872 that would report a meaningful error, but the problem is that we
15873 would not get the real match, if there was a name override.
15875 2003-07-18 Miguel de Icaza <miguel@ximian.com>
15877 * namespace.cs (Namespace, Name): Do not compute the namespace
15878 name dynamically, compute it in the constructor. This reduced
15879 memory usage by 1697 KB.
15881 * driver.cs: Use --pause to pause at the end.
15883 2003-07-17 Peter Williams <peter@newton.cx>
15885 * Makefile: Change the name of the test target so that it doesn't
15886 conflict with the recursive test target.
15888 2003-07-17 Miguel de Icaza <miguel@ximian.com>
15890 * expression.cs (LocalVariableReference.Emit, EmitAssign,
15891 AddressOf): Do not use EmitThis, that was wrong, use the actual
15894 2003-07-15 Miguel de Icaza <miguel@ximian.com>
15896 * class.cs (MethodData.Define): While checking if a method is an
15897 interface implementation, improve the test: If we are not public
15898 (use new test here: use the computed MethodAttributes directly,
15899 instead of the parsed modifier flags) check if the `implementing'
15900 method comes from an interface or not.
15902 * pending.cs (VerifyPendingMethods): Slightly better error
15905 * makefile: add test target that does the mcs bootstrap.
15907 2003-07-16 Ravi Pratap <ravi@ximian.com>
15909 * interface.cs (Define): Do nothing here since there are no
15910 members to populate etc. Move the attribute emission out of here
15911 since this was just totally the wrong place to put it. Attribute
15912 application happens during the 'Emit' phase, not in the 'Define'
15915 (Emit): Add this method and move the attribute emission here
15917 * rootcontext.cs (EmitCode): Call the Emit method on interface
15920 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15922 * expression.cs (OverloadResolve): Report error only if Location
15923 is not 'Null' which means that there was a probe going on.
15925 2003-07-14 Martin Baulig <martin@ximian.com>
15927 * expression.cs (ConditionalLogicalOperator): New public class to
15928 implement user defined conditional logical operators.
15929 This is section 14.11.2 in the spec and bug #40505.
15931 2003-07-14 Martin Baulig <martin@ximian.com>
15933 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
15935 2003-07-14 Martin Baulig <martin@ximian.com>
15937 * codegen.cs (EmitContext.InFixedInitializer): New public field.
15939 * ecore.cs (IVariable.VerifyFixed): New interface method.
15941 * expression.cs (Unary.ResolveOperator): When resolving the `&'
15942 operator, check whether the variable is actually fixed. Fixes bug
15943 #36055. Set a variable definitely assigned when taking its
15944 address as required by the spec.
15946 * statement.cs (LocalInfo.IsFixed): New field.
15947 (LocalInfo.MakePinned): Set `IsFixed' to true.
15949 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15951 * attribute.cs (Attribute.Resolve): While doing a Member lookup
15952 for .ctors, ensure that we only ask for members declared in the
15953 attribute type (BindingFlags.DeclaredOnly).
15957 * expression.cs (Error_WrongNumArguments): Report error 1501
15958 correctly the way CSC does.
15960 2003-07-13 Martin Baulig <martin@ximian.com>
15962 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
15963 lookup on the fully qualified name, to make things like "X.X" work
15964 where "X.X" is a fully qualified type name, but we also have a
15965 namespace "X" in the using list. Fixes #41975.
15967 2003-07-13 Martin Baulig <martin@ximian.com>
15969 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
15970 function. If we're a CompoundAssign, we need to create an embedded
15971 CompoundAssign, not an embedded Assign.
15972 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
15975 2003-07-13 Martin Baulig <martin@ximian.com>
15977 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
15978 work to fix bug #46088.
15980 2003-07-13 Ravi Pratap <ravi@ximian.com>
15982 * class.cs (Operator.Emit): Do not emit attributes here - it is
15983 taken care of by the Method class that we delegate too. This takes
15984 care of bug #45876.
15986 2003-07-10 Martin Baulig <martin@ximian.com>
15988 * expression.cs (TypeOfVoid): New class.
15989 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
15991 2003-07-10 Martin Baulig <martin@ximian.com>
15993 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
15996 2003-07-10 Martin Baulig <martin@ximian.com>
15998 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
15999 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
16001 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
16003 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
16005 2003-07-10 Martin Baulig <martin@ximian.com>
16007 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
16008 of decimal. Fixes #42850.
16010 NOTE: I also fixed the created byte blob, but this doesn't work on
16011 the MS runtime and csc never produces any byte blobs for decimal
16014 2003-07-10 Martin Baulig <martin@ximian.com>
16016 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
16017 structs; fixes #32068.
16018 (Block.AddChildVariableNames): Fixed #44302.
16020 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16022 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
16024 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16026 * attribute.cs: And this test is onger needed.
16028 2003-07-08 Martin Baulig <martin@ximian.com>
16030 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
16031 inaccessible types. Fixes #36313.
16033 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
16035 * namespace.cs (NamespaceEntry): Create implicit entries for all
16036 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
16037 implicit entries for N1.N2 and N1.
16039 2003-07-08 Martin Baulig <martin@ximian.com>
16041 Rewrote the handling of namespaces to fix a lot of the issues
16042 wrt. `using' aliases etc.
16044 * namespace.cs (Namespace): Splitted this class into a
16045 per-assembly `Namespace' and a per-file `NamespaceEntry'.
16047 * typemanager.cs (TypeManager.IsNamespace): Removed.
16048 (TypeManager.ComputeNamespaces): Only compute namespaces from
16049 loaded assemblies here, not the namespaces from the assembly we're
16050 currently compiling.
16052 2003-07-08 Martin Baulig <martin@ximian.com>
16054 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
16056 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16058 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
16061 I thought about the memory savings here, but LookupTypeReflection
16062 is used under already very constrained scenarios. Compiling
16063 corlib or mcs only exposes one hit, so it would not really reduce
16064 any memory consumption.
16066 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16068 * typemanager.cs: fixes bug #45889 by only adding public types from
16069 other assemblies to the list of known types.
16071 2003-07-07 Miguel de Icaza <miguel@ximian.com>
16073 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
16074 on the type we resolved.
16076 2003-07-05 Martin Baulig <martin@ximian.com>
16078 * pending.cs (PendingImplementation.ParentImplements): Don't
16079 create the proxy if the parent is abstract.
16081 * class.cs (TypeContainer.DefineIndexers): Process explicit
16082 interface implementations first. Fixes #37714.
16084 2003-07-04 Miguel de Icaza <miguel@ximian.com>
16086 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
16087 defined recursively; but since we modify the input parameters
16088 (left is set to `this' temporarily), we reset this value if the
16089 left_is_explicit is false, which gives the original semantics to
16092 * literal.cs (NullPointer): new class used to represent a null
16093 literal in a pointer context.
16095 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
16096 type is a pointer, use a NullPointer object instead of a
16097 NullLiteral. Closes 43687
16099 (ExplicitConversion): Convert pointer values using
16100 the conv opcode to the proper type.
16102 * ecore.cs (New): change ValueTypeVariable property into a method,
16103 that returns whether the valuetype is suitable for being used.
16105 * expression.cs (Binary.DoNumericPromotions): Only return if we
16106 the int constant was a valid uint, and we can return both left and
16107 right as uints. If not, we continue processing, to trigger the
16108 type conversion. This fixes 39018.
16110 * statement.cs (Block.EmitMeta): During constant resolution, set
16111 the CurrentBlock property on the emitcontext, so that we resolve
16112 constants propertly.
16114 2003-07-02 Martin Baulig <martin@ximian.com>
16116 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
16117 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
16119 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
16120 than emitting it here.
16122 * statement.cs: Fixed some more flow analysis bugs.
16124 2003-07-02 Martin Baulig <martin@ximian.com>
16126 * class.cs (MethodData.Define): When implementing interface
16127 methods, set Final unless we're Virtual.
16129 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
16130 check work for interface methods.
16132 2003-07-01 Martin Baulig <martin@ximian.com>
16134 * ecore.cs (EmitContext.This): Replaced this property with a
16135 GetThis() method which takes a Location argument. This ensures
16136 that we get the correct error location for a CS0188.
16138 2003-07-01 Miguel de Icaza <miguel@ximian.com>
16140 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
16141 ImplicitStandardConversion.
16143 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
16145 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
16147 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
16150 2003-06-30 Miguel de Icaza <miguel@ximian.com>
16152 * class.cs (Constructor.Define): Turn off initlocals for unsafe
16155 (MethodData.Define): Turn off initlocals for unsafe methods.
16157 2003-06-29 Miguel de Icaza <miguel@ximian.com>
16159 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
16160 complete; Fixes #37521.
16162 * delegate.cs: Use Modifiers.TypeAttr to compute the
16163 TypeAttributes, instead of rolling our own. This makes the flags
16164 correct for the delegates.
16166 2003-06-28 Miguel de Icaza <miguel@ximian.com>
16168 * class.cs (Constructor.Define): Set the private flag for static
16169 constructors as well.
16171 * cs-parser.jay (statement_expression): Set the return value to
16172 null, to avoid a crash when we catch an error.
16174 2003-06-24 Miguel de Icaza <miguel@ximian.com>
16176 * cs-parser.jay: Applied patch from Jackson that adds support for
16177 extern and unsafe modifiers to destructor declarations.
16179 * expression.cs: Report error 21 if the user is trying to index a
16182 * driver.cs: Add an error message, suggested by the bug report.
16184 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
16185 if we do not have a ": this ()" constructor initializer. Fixes 45149
16187 2003-06-14 Miguel de Icaza <miguel@ximian.com>
16189 * namespace.cs: Add some information to reduce FAQs.
16191 2003-06-13 Miguel de Icaza <miguel@ximian.com>
16193 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
16194 underlying enumeration types. Fixes #43915.
16196 * expression.cs: Treat ushort/short as legal values to be used in
16197 bitwise operations.
16199 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
16201 * delegate.cs: transfer custom attributes for paramenters from
16202 the delegate declaration to Invoke and BeginInvoke.
16204 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
16206 * attribute.cs: handle custom marshalers and emit marshal info
16209 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
16211 * makefile.gnu: Added anonymous.cs to the compiler sources.
16213 2003-05-28 Miguel de Icaza <miguel@ximian.com>
16215 * iterators.cs: Change the name of the proxy class to include two
16218 * cs-parser.jay: Update grammar to include anonymous methods.
16220 * anonymous.cs: new file.
16222 2003-05-27 Miguel de Icaza <miguel@ximian.com>
16224 * class.cs (Field.Define): Add missing test for pointers and
16227 2003-05-27 Ravi Pratap <ravi@ximian.com>
16229 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
16230 we use the stobj opcode.
16232 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
16233 since it wasn't the correct fix.
16235 It still is puzzling that we are required to use stobj for IntPtr
16236 which seems to be a ValueType.
16238 2003-05-26 Miguel de Icaza <miguel@ximian.com>
16240 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
16241 during regular simple name resolution. Now, the trick is that
16242 instead of returning for processing the simplename, we do a
16243 TypeManager.LookupType (ie, a rooted lookup as opposed to a
16244 contextual lookup type). If a match is found, return that, if
16245 not, return for further composition.
16247 This fixes long-standing 30485.
16249 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16250 using the address to initialize an object, do an Stobj instead of
16251 using the regular Stelem.
16253 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
16254 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
16255 Because if we are a BaseIndexerAccess that value will be true.
16258 * statement.cs (GotoCase.Resolve): Return after reporting an
16259 error, do not attempt to continue.
16261 * expression.cs (PointerArithmetic.Emit): If our operand is a
16262 long, convert our constants to match the operand before
16263 multiplying. Convert to I type before adding. Fixes 43670.
16265 2003-05-14 Ravi Pratap <ravi@ximian.com>
16267 * enum.cs (ImplicitConversionExists) : Rename to
16268 ImplicitEnumConversionExists to remove ambiguity.
16270 * ecore.cs (NullCast): New type of cast expression class which
16271 basically is very similar to EmptyCast with the difference being
16272 it still is a constant since it is used only to cast a null to
16274 (eg. (string) null)
16276 * convert.cs (ImplicitReferenceConversion): When casting a null
16277 literal, we return a NullCast.
16279 * literal.cs (NullLiteralTyped): Remove - I don't see why this
16280 should be around anymore.
16282 The renaming (reported was slightly wrong). Corrections:
16284 ConvertImplicitStandard -> ImplicitConversionStandard
16285 ConvertExplicitStandard -> ExplicitConversionStandard
16287 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
16288 before passing them in !
16290 * convert.cs (ImplicitConversionStandard): When comparing for
16291 equal expr and target types, ensure that expr is not a
16294 In general, we must not be checking (expr_type ==
16295 target_type) in the top level conversion methods
16296 (ImplicitConversion, ExplicitConversion etc). This checking is
16297 done in the methods that they delegate to.
16299 2003-05-20 Miguel de Icaza <miguel@ximian.com>
16301 * convert.cs: Move Error_CannotConvertType,
16302 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
16303 ImplicitNumericConversion, ImplicitConversionExists,
16304 ImplicitUserConversionExists, StandardConversionExists,
16305 FindMostEncompassedType, FindMostSpecificSource,
16306 FindMostSpecificTarget, ImplicitUserConversion,
16307 ExplicitUserConversion, GetConversionOperators,
16308 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
16309 TryImplicitIntConversion, Error_CannotConvertImplicit,
16310 ConvertImplicitRequired, ConvertNumericExplicit,
16311 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
16312 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
16315 Perform the following renames:
16317 StandardConversionExists -> ImplicitStandardConversionExists
16318 ConvertImplicit -> ImplicitConversion
16319 ConvertImplicitStandard -> ImplicitStandardConversion
16320 TryImplicitIntConversion -> ImplicitIntConversion
16321 ConvertImplicitRequired -> ImplicitConversionRequired
16322 ConvertNumericExplicit -> ExplicitNumericConversion
16323 ConvertReferenceExplicit -> ExplicitReferenceConversion
16324 ConvertExplicit -> ExplicitConversion
16325 ConvertExplicitStandard -> ExplicitStandardConversion
16327 2003-05-19 Martin Baulig <martin@ximian.com>
16329 * statement.cs (TypeInfo.StructInfo): Made this type protected.
16330 (TypeInfo): Added support for structs having structs as fields.
16332 * ecore.cs (FieldExpr): Implement IVariable.
16333 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
16334 VariableInfo for the field.
16336 2003-05-18 Martin Baulig <martin@ximian.com>
16338 * expression.cs (This.DoResolve): Report a CS0027 if we're
16339 emitting a field initializer.
16341 2003-05-18 Martin Baulig <martin@ximian.com>
16343 * expression.cs (This.ResolveBase): New public function.
16344 (This.DoResolve): Check for CS0188.
16346 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
16349 * ecore.cs (MethodGroupExpr.DoResolve): Set the
16350 `instance_expression' to null if we don't have any non-static
16353 2003-05-18 Martin Baulig <martin@ximian.com>
16355 Reworked the way how local variables and parameters are handled by
16356 the flow analysis code.
16358 * statement.cs (TypeInfo, VariableMap): New public classes.
16359 (VariableInfo): New public class. This is now responsible for
16360 checking whether a variable has been assigned. It is used for
16361 parameters and local variables.
16362 (Block.EmitMeta): Take the InternalParameters as argument; compute
16363 the layout of the flow vectors here.
16364 (Block.LocalMap, Block.ParameterMap): New public properties.
16365 (FlowBranching): The .ctor doesn't get the InternalParameters
16366 anymore since Block.EmitMeta() now computes the layout of the flow
16368 (MyStructInfo): This class is now known as `StructInfo' and nested
16369 in `TypeInfo'; we don't access this directly anymore.
16371 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
16372 property and removed IsAssigned(), IsFieldAssigned(),
16373 SetAssigned() and SetFieldAssigned(); we now call them on the
16374 VariableInfo so we don't need to duplicate this code everywhere.
16376 * expression.cs (ParameterReference): Added `Block block' argument
16378 (LocalVariableReference, ParameterReference, This): The new
16379 VariableInfo class is now responsible for all the definite
16382 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
16383 IsParameterAssigned, SetParameterAssigned): Removed.
16385 2003-05-18 Martin Baulig <martin@ximian.com>
16387 * typemanager.cs (InitCoreTypes): Try calling
16388 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
16389 the 3-args-version. Corlib now also needs our `void_type'.
16390 (GetMethod): Added overloaded version which takes an optional
16391 `bool report_errors' to allow lookups of optional methods.
16393 2003-05-12 Martin Baulig <martin@ximian.com>
16395 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
16396 only used for locals and not for parameters.
16398 2003-05-12 Miguel de Icaza <miguel@ximian.com>
16400 * support.cs (InternalParameters.ParameterType): Return the
16401 ExternalType of the parameter.
16403 * parameter.cs (Parameter.ExternalType): drop the two arguments,
16406 2003-05-11 Miguel de Icaza <miguel@ximian.com>
16408 * class.cs (MethodData.Define): Do not set the `newslot' on
16409 interface members, if they are also flagged as "override".
16411 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
16412 better code for ++i and i++. This only works for static fields
16413 and local variables.
16415 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
16416 want to pull the DeclSpace out of the builder_to_declspace instead
16417 of the TypeBuilder (like in TypeContainer.FindMembers).
16419 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
16420 instead of LookupTypeContainer. Fixes the crash on .NET for
16421 looking up interface members.
16423 * const.cs: Create our own emit context during the Definition
16424 stage, so that constants are evaluated in the proper context, when
16425 a recursive definition happens.
16427 2003-05-11 Martin Baulig <martin@ximian.com>
16429 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
16430 new block for a switch section.
16431 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
16432 the adding/lookup in the switch block. Fixes #39828.
16434 2003-05-09 Miguel de Icaza <miguel@ximian.com>
16436 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
16437 functionality: I needed to convert the data after I had performed
16438 the add/sub operation into the operands type size.
16440 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
16441 pass the type for the box operation, otherwise the resulting
16442 object would have been of type object.
16444 (BoxedCast): Add constructor to specify the type to box as.
16446 2003-05-07 Miguel de Icaza <miguel@ximian.com>
16448 * iterators.cs: I was reusing the `count' variable inadvertently,
16449 take steps to not allow this to happen.
16451 2003-05-06 Miguel de Icaza <miguel@ximian.com>
16453 * attribute.cs (Attribute.Resolve): Params attributes are encoded
16454 by creating an array at the point where the params starts and
16455 putting all those arguments there, then adjusting the size of the
16458 2003-05-05 Miguel de Icaza <miguel@ximian.com>
16460 * expression.cs (New.AddressOf): Implement interface
16461 IMemoryLocation. This is used when the `new' operator is used in
16462 the context of an invocation to a method on a value type.
16464 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
16467 * namespace.cs: Also check the using aliases here.
16469 * driver.cs: Move the test for using validity after the types have
16470 been entered, so we do a single pass that also includes the using
16473 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
16474 in the regular case. CreateSiblingForFinally is doing extra
16477 * attribute.cs (GetAttributeArgumentExpression): Store the result
16478 on an out value, and use the return value to indicate failure
16479 instead of using null (which is a valid return for Constant.GetValue).
16481 * statement.cs: Perform the analysis flow for the increment
16482 portion after the statement, because this will be the real flow of
16483 execution. Fixes #42385
16485 * codegen.cs (EmitContext.EmitArgument,
16486 EmitContext.EmitStoreArgument): New helper functions when the
16487 RemapToProxy flag is set.
16489 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
16492 Add support for remapping parameters.
16494 * iterators.cs: Propagate parameter values; Store parameter
16495 values in the proxy classes.
16497 2003-05-04 Miguel de Icaza <miguel@ximian.com>
16499 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
16500 need a proxy reference; I do not know what I was thinking
16502 * cs-parser.jay (constructor_initializer): catch another error,
16503 and display nice message.
16505 (field_declaration): catch void field declaration
16506 to flag a better error.
16508 * class.cs (MemberBase.CheckBase): Report an error instead of a
16509 warning if a new protected member is declared in a struct.
16510 (Field.Define): catch the error of readonly/volatile.
16512 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
16514 (FieldExpr.AddressOf): ditto. Catch error where the address of a
16515 volatile variable is taken
16517 2003-05-02 Miguel de Icaza <miguel@ximian.com>
16519 * statement.cs (Fixed.Resolve): Report an error if we are not in
16522 2003-05-01 Miguel de Icaza <miguel@ximian.com>
16524 * typemanager.cs: reuse the code that handles type clashes for
16525 delegates and enumerations.
16527 * class.cs (Report28): Always report.
16529 * expression.cs (EncodeAsAttribute): Allow nulls here.
16531 2003-04-28 Miguel de Icaza <miguel@ximian.com>
16533 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
16534 the functionality for testing whether an expression is valid for
16535 an attribute here. Also handle the case of arrays of elements
16538 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
16539 encoding a linear array into an array of objects that are suitable
16540 to be passed to an CustomAttributeBuilder.
16542 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
16544 * ecore.cs: (FieldExpr): Handle field remapping here.
16546 * iteratators.cs: Pass the instance variable (if the method is an
16547 instance method) to the constructors, so we can access the field
16548 variables on the class.
16550 TODO: Test this with structs. I think the THIS variable on
16551 structs might have to be a pointer, and not a refenrece
16553 2003-04-27 Miguel de Icaza <miguel@ximian.com>
16555 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
16556 local variables to fields in a proxy class.
16558 * iterators.cs (PopulateProxy): Rename our internal fields to
16560 Create a <THIS> field if we are an instance method, so we can
16561 reference our parent container variables.
16562 (MapVariable): Called back from the EmitContext code to enter a
16563 new variable to field mapping into the proxy class (we just create
16567 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
16568 for using the remapped locals to fields.
16570 I placed the code here, because that gives the same semantics to
16571 local variables, and only changes the Emit code.
16573 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
16574 statements inside iterators.
16575 (VariableInfo): Add a FieldBuilder for the cases when we are
16576 remapping local variables to fields in a proxy class
16578 * ecore.cs (SimpleNameResolve): Avoid testing two times for
16579 current_block != null.
16581 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
16582 not cope with strings, as it has been moved to the
16583 TableSwitchEmit. Fixed bug in switch generation.
16585 * expression.cs (New.DoResolve): Provide more context for the user
16586 when reporting an error.
16588 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
16591 * expression.cs (MemberAccess.DoResolve): When we get a type back,
16592 check the permissions for it. Note than in a type-resolution
16593 context the check was already present in DeclSpace.ResolveType,
16594 but was missing from the MemberAccess.
16596 (ArrayCreation.CheckIndices): warn if the user has
16597 more nested levels of expressions, but there are no more
16598 dimensions specified. Avoids crash on bug 41906.
16600 2003-04-26 Miguel de Icaza <miguel@ximian.com>
16602 * statement.cs (Block): replace Implicit bool, for a generic
16604 New flag: `Unchecked'. This is used during the EmitMeta phase
16605 (which is out-of-line with the regular Resolve/Emit process for a
16606 statement, as this is done ahead of time, but still gets a chance
16607 to call constant resolve).
16609 (Block.Flags): new enum for adding a new flag.
16611 (Block.EmitMeta): track the state of unchecked.
16613 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
16614 to enable constant resolution to work there as well.
16616 2003-04-22 Miguel de Icaza <miguel@ximian.com>
16618 * typemanager.cs (ienumerable_type): Also look up
16619 System.Collections.IEnumerable.
16621 2003-04-21 Miguel de Icaza <miguel@ximian.com>
16623 TODO: Test more than one conditional per method.
16625 * class.cs (Indexer.Define): Report the location where the user is
16626 referencing the unsupported feature.
16628 (MethodData): Overload the use of `conditionals' to
16629 minimize the creation of needless ArrayLists. This saves roughly
16630 212kb on my machine.
16632 (Method): Implement the new IIteratorContainer interface.
16633 (Method.SetYields): Implement the method by setting the ModFlags
16634 to contain METHOD_YIELDS.
16636 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
16637 which just got set to null.
16639 * iterators.cs: New file.
16641 (Yield, YieldBreak): New statements.
16643 * statement.cs (Return.Resolve): Flag an error if we are used in
16644 an iterator method.
16646 * codegen.cs (InIterator): New flag set if the code is being
16647 compiled in an iterator method.
16649 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
16650 internal modifier, and we just use it to avoid adding extra
16651 fields, as this is seldom used.
16653 * cs-parser.jay: Add yield_statement (yield and yield break).
16655 * driver.cs: New flag -v2 to turn on version 2 features.
16657 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
16658 hashtable when v2 is enabled.
16660 2003-04-20 Miguel de Icaza <miguel@ximian.com>
16662 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
16663 there is already a namespace defined with this name.
16665 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
16666 people upgraded their corlibs.
16668 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
16669 always use fully qualified types, no need to use the compiler
16672 (TypeManager.IsNamespace): Use binarysearch.
16674 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
16675 AddDelegate): I did not quite use the new IsValid API properly: I
16676 have to pass the short-name and the fullname. I was passing only
16677 the basename instead of the fullname sometimes.
16679 (TypeContainer.DefineType): call NamespaceClash.
16681 * interface.cs (Interface.DefineType): use NamespaceClash before
16684 * delegate.cs (Delegate.DefineType): use NamespaceClash before
16687 * enum.cs: (Enum.DefineType): use NamespaceClash before
16690 * typemanager.cs (: 3-line patch that gives us some tasty 11%
16691 speed increase. First, use the negative_hits cache when we get a
16692 negative. Second, add the type with its full original name
16693 instead of the new . and + encoded name (reflection uses + to
16694 separate type from a nested type). Use LookupTypeReflection
16695 directly which bypasses the type->name hashtable (that we already
16696 know does not contain the type.
16698 * decl.cs (DeclSpace.ResolveTypeExpr): track the
16699 location/container type.
16701 * driver.cs: When passing utf8, use directly the UTF8Encoding.
16703 2003-04-19 Miguel de Icaza <miguel@ximian.com>
16705 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
16707 * delegate.cs (NewDelegate.Resolve): Test whether an instance
16708 method is being referenced in the method group from a static
16709 context, and report error 120 if so.
16711 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
16714 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
16715 is created, we create the A namespace).
16717 * cs-parser.jay: A namespace also introduces a DeclarationFound.
16720 2003-04-18 Miguel de Icaza <miguel@ximian.com>
16722 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
16723 invocation to ModuleBuilder.GetType with the same values will
16724 return a new type instance, so we need to cache its return
16727 * expression.cs (Binary.ResolveOperator): Only allow the compare
16728 operators on enums if they are of the same type.
16730 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
16731 types of ValueType on their own case. Before we were giving them
16732 the same treatment as objects.
16734 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
16735 fullname. Short name is used to compare against container name.
16736 Fullname is used to check against defined namespace names.
16738 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
16739 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
16741 (Method.CheckBase): Call parent.
16742 (MemberBase.CheckBase): Check for protected members on sealed
16744 (PropertyBase.CheckBase): Call parent.
16745 (Field.Define): Call parent.
16747 * report.cs: Negative error codes are now mapped to 8000 - code,
16748 so that the display is render more nicely.
16750 * typemanager.cs: Do not use try/catch, instead report a regular
16753 (GetPointerType, GetReferenceType): These methods provide
16754 mechanisms to obtain the T* and T& from a T. We had the code
16755 previously scattered around the code base, and it also used
16756 TypeManager.LookupType that would go through plenty of caches.
16757 This one goes directly to the type source.
16759 In some places we did the Type.GetType followed by
16760 ModuleBuilder.GetType, but not in others, so this unifies the
16761 processing as well.
16763 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
16764 statements now that we have namespace information.
16766 * typemanager.cs (IsNamespace): New method, returns whether the
16767 string presented is a namespace or not.
16769 (ComputeNamespaces): New public entry point, computes the list of
16770 available namespaces, using the GetNamespaces API call in Mono, or
16771 the slower version in MS.NET.
16773 Now before we start the semantic analysis phase, we have a
16774 complete list of namespaces including everything that the user has
16777 Deleted old code to cache namespaces in .nsc files.
16779 2003-04-17 Miguel de Icaza <miguel@ximian.com>
16781 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
16782 class/struct location definition Location for the implicit
16783 constructor location.
16785 (Operator.Define): Use the location of the operator for the
16786 implicit Method definition.
16788 (Constructor.Emit): use the constructor location for the implicit
16789 base initializer constructor.
16791 * ecore.cs: Remove ITypeExpression. This interface is now gone,
16792 and the Expression class now contains two new methods:
16794 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
16795 isolate type lookup from the rest of the resolution process.
16797 Since we use Expressions to hold type definitions due to the way
16798 we parse the input we have historically overloaded Resolve to
16799 perform the Type lookups if a special flag is passed. Now this is
16800 eliminated and two methods take their place.
16802 The differences in the two methods between xStep and xTerminal is
16803 that xStep is involved in our current lookup system that uses
16804 SimpleNames to compose a name, while xTerminal is used just to
16805 catch the case where the simplename lookup failed.
16807 2003-04-16 Miguel de Icaza <miguel@ximian.com>
16809 * expression.cs (ResolveMemberAccess): Remove redundant code.
16810 TypeExpr expressions are always born fully resolved.
16812 * interface.cs (PopulateMethod): Do not lookup the types twice.
16813 We were doing it once during SemanticAnalysis and once during
16816 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
16817 in local variable type definitions, were being returned as a
16818 SimpleName (we decomposed everything into a string), that is
16819 because primary_expression was being used instead of a type in the
16820 grammar (reduce/reduce conflicts).
16822 The part that was wrong is that we converted the expression into a
16823 string (an oversimplification in one hand, compounded with primary
16824 expressions doing string concatenation).
16830 Would return "A.B.C[]" as a SimpleName. This stopped things like
16831 using clauses from working on this particular context. And a type
16832 was being matched directly against "A.B.C[]".
16834 We now use the correct approach, and allow for ComposedCast to be
16835 part of the unary expression. So the "A.B.C []" become a composed
16836 cast of "A.B.C" (as a nested group of MemberAccess with a
16837 SimpleName at the end) plus the rank composition "[]".
16841 2003-04-10 Miguel de Icaza <miguel@ximian.com>
16843 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
16844 for the access level checking.
16846 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
16847 `TypeContainer container', because I kept getting confused when I
16848 was debugging this code.
16850 * expression.cs (Indexers): Instead of tracking getters/setters,
16851 we now track them in parallel. We create one arraylist less, but
16852 most importantly it is possible now for the LValue code to find a
16853 matching get for a set.
16855 (IndexerAccess.DoResolveLValue): Update the code.
16856 GetIndexersForType has been modified already to extract all the
16857 indexers from a type. The code assumed it did not.
16859 Also make the code set the correct return type for the indexer.
16860 This was fixed a long time ago for properties, but was missing for
16861 indexers. It used to be void_type.
16863 (Binary.Emit): Test first for doubles instead of
16864 floats, as they are more common.
16866 (Binary.EmitBranchable): Use the .un version of the branch opcodes
16867 when dealing with floats and the <=, >= operators. This fixes bug
16870 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
16871 to load the array value by emitting a load on the foreach variable
16872 type. This was incorrect.
16874 We now emit the code to load an element using the the array
16875 variable type, and then we emit the conversion operator.
16879 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
16881 * attribute.cs: Avoid allocation of ArrayLists in the common case.
16883 2003-04-09 Miguel de Icaza <miguel@ximian.com>
16885 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
16886 test for protection before we test for signatures.
16888 (MethodSignature.ToString): implement.
16890 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
16891 to the case where we reduced into a LongConstant.
16893 * decl.cs (CheckAccessLevel): If the type is an array, we can not
16894 depend on whether the information is acurrate, because the
16895 Microsoft runtime will always claim that the array type is public,
16896 regardless of the real state.
16898 If the type is a pointer, another problem happens: the type is
16899 reported as non-public in Microsoft.
16901 In both cases we have to call CheckAccessLevel recursively with
16902 the underlying type as the argument to be tested.
16904 2003-04-08 Miguel de Icaza <miguel@ximian.com>
16906 * assign.cs (Assign.Emit): If we are dealing with a compound
16907 assignment expression, we should use the code path that stores the
16908 intermediate result in a temporary value. This fixes #40903.
16910 *expression.cs (Indirection.ToString): Provide ToString method for
16913 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
16915 * class.cs: Null out fields holding references to Block objects so
16916 they can be garbage collected.
16918 * expression.cs (OverloadResolve): Remove unused local.
16920 2003-04-07 Martin Baulig <martin@ximian.com>
16922 * codegen.cs (EmitContext.CurrentFile): New public field.
16923 (EmitContext.Mark): Use the CurrentFile to check whether the
16924 location is in the correct file.
16925 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
16927 2003-04-07 Martin Baulig <martin@ximian.com>
16929 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
16931 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
16932 location. [FIXME: The location argument which gets passed to this
16933 method is sometimes wrong!]
16935 2003-04-07 Nick Drochak <ndrochak@gol.com>
16937 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
16939 2003-04-07 Miguel de Icaza <miguel@ximian.com>
16941 * expression.cs (Indirection.EmitAssign): We were using the
16942 temporary, but returning immediately instead of continuing the
16945 2003-04-06 Martin Baulig <martin@ximian.com>
16947 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
16948 if it's a nested child, but also deriving from the outer class.
16951 * typemanager.cs (IsNestedChildOf): Make this work if it's a
16952 nested child, but also deriving from the outer class. See
16954 (FilterWithClosure): We may access private members of the outer
16955 class if we're a nested child and deriving from the outer class.
16956 (RealMemberLookup): Only set `closure_private_ok' if the
16957 `original_bf' contained BindingFlags.NonPublic.
16959 2003-04-05 Martin Baulig <martin@ximian.com>
16961 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
16963 2003-04-02 Miguel de Icaza <miguel@ximian.com>
16965 * class.cs (Event.Define): Do not allow abstract events to have
16968 2003-04-01 Miguel de Icaza <miguel@ximian.com>
16970 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
16971 block in event declarations.
16973 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
16974 value type, get its address.
16976 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
16977 leaving a class on the stack instead of a boolean value (int
16978 0/1). Change the code so we compare against null, and then the
16979 result against zero.
16981 * class.cs (TypeContainer.GetClassBases): We were checking for the
16982 parent class being sealed too late.
16984 * expression.cs (Binary.Emit): For <= and >= when dealing with
16985 floating point values, use cgt.un and clt.un instead of cgt and
16988 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
16990 * statement.cs: Apply the same optimization as MS: skip the
16991 GetEnumerator returning an IEnumerator, and use the one returning a
16992 CharEnumerator instead. This allows us to avoid the try-finally block
16995 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
16997 * cs-parser.jay: Attributes cannot be applied to
16998 namespaces. Fixes #40473
17000 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17003 (Add*): check if the name is valid using the full name for constants,
17004 fields, properties and events.
17006 2003-03-28 Miguel de Icaza <miguel@ximian.com>
17008 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
17009 char constants to be part of the enumeration.
17011 * expression.cs (Conditional.DoResolve): Add support for operator
17012 true. Implements the missing functionality from 14.12
17014 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
17015 operator true/false as required by the spec.
17017 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
17018 implicit conversion to boolean.
17020 * statement.cs (Statement.ResolveBoolean): A boolean expression is
17021 also one where the type implements `operator true'.
17023 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
17024 get an expression that will invoke operator true based on an
17027 (GetConversionOperators): Removed the hack that called op_True
17030 (Expression.ResolveBoolean): Move this from Statement.
17032 2003-03-17 Miguel de Icaza <miguel@ximian.com>
17034 * ecore.cs (FieldExpr): do not allow initialization of initonly
17035 fields on derived classes
17037 2003-03-13 Martin Baulig <martin@ximian.com>
17039 * statement.cs (Block.Emit): Call ig.BeginScope() and
17040 ig.EndScope() when compiling with debugging info; call
17041 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
17043 2003-03-08 Miguel de Icaza <miguel@ximian.com>
17045 * expression.cs (Indexers): Do not construct immediately, allow
17046 for new members to be appended as we go. Fixes 38143
17048 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17050 * expression.cs: save/restore context when resolving an unchecked
17053 2003-03-05 Miguel de Icaza <miguel@ximian.com>
17055 * cfold.cs: Catch division by zero in modulus operator during
17058 2003-03-03 Miguel de Icaza <miguel@ximian.com>
17060 * interface.cs (Interface.DefineMembers): Avoid defining members
17063 2003-02-27 Miguel de Icaza <miguel@ximian.com>
17065 * driver.cs: handle the +/- options for -noconfig
17067 * statement.cs (Unckeched.Resolve): Also track the state of
17068 unchecked in the Resolve phase.
17070 2003-02-27 Martin Baulig <martin@ximian.com>
17072 * ecore.cs (Expression.MemberLookup): Don't create a
17073 MethodGroupExpr for something which is not a method. Fixes #38291.
17075 2003-02-25 Miguel de Icaza <miguel@ximian.com>
17077 * class.cs (MemberBase.CheckParameters): Also check that the type
17078 is unmanaged if it is a pointer.
17080 * expression.cs (SizeOf.Resolve): Add location information.
17082 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
17083 a managed type is declared.
17085 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
17086 parameter modifiers as well. Fixes bug 38606
17088 * class.cs: Very sad. Am backing out the speed up changes
17089 introduced by the ArrayList -> Array in the TypeContainer, as they
17090 were not actually that much faster, and introduced a bug (no error
17091 reports on duplicated methods).
17093 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
17094 source first, this will guarantee that we have a valid expression
17095 before calling in lower levels functions that will require a
17096 resolved object. Then use this original_source in the
17097 target.ResolveLValue instead of the original source that was
17100 Another change. Use target.Resolve instead of LValueResolve.
17101 Although we are resolving for LValues, we will let the Assign code
17102 take care of that (it will be called again from Resolve). This
17103 basically allows code like this:
17105 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
17106 class Y { void A (X x) { x [0] += o; }
17108 The problem was that the indexer was trying to resolve for
17109 set_Item (idx, object o) and never finding one. The real set_Item
17110 was set_Item (idx, X). By delaying the process we get the right
17115 2003-02-23 Martin Baulig <martin@ximian.com>
17117 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
17118 while calling DoEmit ().
17120 * codegen.cs (EmitContext.Mark): Don't mark locations in other
17121 source files; if you use the #line directive inside a method, the
17122 compiler stops emitting line numbers for the debugger until it
17123 reaches the end of the method or another #line directive which
17124 restores the original file.
17126 2003-02-23 Martin Baulig <martin@ximian.com>
17128 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
17130 2003-02-23 Martin Baulig <martin@ximian.com>
17132 * statement.cs (Block.AddChildVariableNames): We need to call this
17133 recursively, not just for our immediate children.
17135 2003-02-23 Martin Baulig <martin@ximian.com>
17137 * class.cs (Event.Define): Always make the field private, like csc does.
17139 * typemanager.cs (TypeManager.RealMemberLookup): Make events
17140 actually work, fixes bug #37521.
17142 2003-02-23 Miguel de Icaza <miguel@ximian.com>
17144 * delegate.cs: When creating the various temporary "Parameters"
17145 classes, make sure that we call the ComputeAndDefineParameterTypes
17146 on those new parameters (just like we do with the formal ones), to
17147 allow them to be resolved in the context of the DeclSpace.
17149 This fixes the bug that Dick observed in Bugzilla #38530.
17151 2003-02-22 Miguel de Icaza <miguel@ximian.com>
17153 * expression.cs (ResolveMemberAccess): When resolving a constant,
17154 do not attempt to pull a constant if the value was not able to
17155 generate a valid constant.
17157 * const.cs (LookupConstantValue): Do not report more errors than required.
17159 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17161 * expression.cs: fixes bug #38328.
17163 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17165 * class.cs: Changed all the various members that can be part of a
17166 class from being an ArrayList to be an Array of the right type.
17167 During the DefineType type_list, interface_list, delegate_list and
17168 enum_list are turned into types, interfaces, delegates and enums
17171 And during the member population, indexer_list, event_list,
17172 constant_list, field_list, instance_constructor_list, method_list,
17173 operator_list and property_list are turned into their real arrays.
17175 Although we could probably perform this operation earlier, for
17176 good error reporting we need to keep the lists and remove the
17177 lists for longer than required.
17179 This optimization was triggered by Paolo profiling the compiler
17180 speed on the output of `gen-sample-program.pl' perl script.
17182 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
17183 not crash in methods like MemberLookupFailed that use this field.
17185 This problem arises when the compiler fails to resolve a type
17186 during interface type definition for example.
17188 2003-02-18 Miguel de Icaza <miguel@ximian.com>
17190 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
17191 inherit from System.Object, so we have to stop at null, not only
17192 when reaching System.Object.
17194 2003-02-17 Miguel de Icaza <miguel@ximian.com>
17196 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
17197 DeclaredOnly because the parent indexer might have had a different
17198 name, but did not loop until the top of the hierarchy was reached.
17200 The problem this one fixes is 35492: when a class implemented an
17201 indexer from an interface, we were getting the interface method
17202 (which was abstract) and we were flagging an error (can not invoke
17205 This also keeps bug 33089 functioning, and test-148 functioning.
17207 * typemanager.cs (IsSpecialMethod): The correct way of figuring
17208 out if a method is special is to see if it is declared in a
17209 property or event, or whether it is one of the predefined operator
17210 names. This should fix correctly #36804.
17212 2003-02-15 Miguel de Icaza <miguel@ximian.com>
17214 The goal here is to remove the dependency on EmptyCast.Peel ().
17215 Killing it completely.
17217 The problem is that currently in a number of places where
17218 constants are expected, we have to "probe" for an EmptyCast, and
17219 Peel, which is not the correct thing to do, as this will be
17220 repetitive and will likely lead to errors.
17222 The idea is to remove any EmptyCasts that are used in casts that
17223 can be reduced to constants, so we only have to cope with
17226 This bug hunt was triggered by Bug 37363 and the desire to remove
17227 the duplicate pattern where we were "peeling" emptycasts to check
17228 whether they were constants. Now constants will always be
17231 * ecore.cs: Use an enumconstant here instead of wrapping with
17234 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
17235 throwing me off. By handling this we can get rid of a few hacks.
17237 * statement.cs (Switch): Removed Peel() code.
17239 2003-02-14 Miguel de Icaza <miguel@ximian.com>
17241 * class.cs: Location information for error 508
17243 * expression.cs (New.DoResolve): Add a guard against double
17244 resolution of an expression.
17246 The New DoResolve might be called twice when initializing field
17247 expressions (see EmitFieldInitializers, the call to
17248 GetInitializerExpression will perform a resolve on the expression,
17249 and later the assign will trigger another resolution
17251 This leads to bugs (#37014)
17253 * delegate.cs: The signature for EndInvoke should contain any ref
17254 or out parameters as well. We were not doing this in the past.
17256 * class.cs (Field.Define): Do not overwrite the type definition
17257 inside the `volatile' group. Turns out that volatile enumerations
17258 were changing the type here to perform a validity test, which
17261 2003-02-12 Miguel de Icaza <miguel@ximian.com>
17263 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
17264 and structs, we do not want to load the instance variable
17266 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
17267 enum_type has to be handled like an object reference (implicit
17268 conversions exists from this to object), but the regular IsClass
17269 and IsValueType tests will never return true for this one.
17271 Also we use TypeManager.IsValueType instead of type.IsValueType,
17272 just for consistency with the rest of the code (this is only
17273 needed if we ever use the construct exposed by test-180.cs inside
17274 corlib, which we dont today).
17276 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
17278 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
17281 2003-02-09 Martin Baulig <martin@ximian.com>
17283 * namespace.cs (Namespace..ctor): Added SourceFile argument.
17284 (Namespace.DefineNamespaces): New static public method; this is
17285 called when we're compiling with debugging to add all namespaces
17286 to the symbol file.
17288 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
17289 pass it to the Namespace's .ctor.
17291 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
17292 and MethodBase arguments; pass the namespace ID to the symwriter;
17293 pass the MethodBase instead of the token to the symwriter.
17294 (SymbolWriter.DefineNamespace): New method to add a namespace to
17297 2003-02-09 Martin Baulig <martin@ximian.com>
17299 * symbolwriter.cs: New file. This is a wrapper around
17300 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
17301 methods here in near future.
17303 2003-02-09 Martin Baulig <martin@ximian.com>
17305 * codegen.cs (EmitContext.Mark): Just pass the arguments to
17306 ILGenerator.MarkSequencePoint() which are actually used by the
17309 2003-02-09 Martin Baulig <martin@ximian.com>
17311 * location.cs (SourceFile): New public sealed class. This
17312 contains the name and an index which is used in the location's token.
17313 (Location): Reserve an appropriate number of bits in the token for
17314 the source file instead of walking over that list, this gives us a
17315 really huge performance improvement when compiling with debugging.
17317 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
17318 `SourceFile' argument instead of a string.
17319 (Driver.ProcessFile): Add all the files via Location.AddFile(),
17320 but don't parse/tokenize here, we need to generate the list of all
17321 source files before we do that.
17322 (Driver.ProcessFiles): New static function. Parses/tokenizes all
17325 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
17326 instead of a string.
17328 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
17331 2003-02-09 Martin Baulig <martin@ximian.com>
17333 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
17334 filename on `#line default'.
17336 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
17338 * statement.cs: don't clear the pinned var when the fixed statement
17339 returns from the method (fixes bug#37752).
17341 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
17343 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
17346 2003-02-07 Martin Baulig <martin@ximian.com>
17348 * driver.cs: Removed the `--debug-args' command line argument.
17350 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
17351 automatically by the AsssemblyBuilder.
17352 (CodeGen.InitializeSymbolWriter): We don't need to call any
17353 initialization function on the symbol writer anymore. This method
17354 doesn't take any arguments.
17356 2003-02-03 Miguel de Icaza <miguel@ximian.com>
17358 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
17359 from referenced assemblies as well.
17361 2003-02-02 Martin Baulig <martin@ximian.com>
17363 * class.cs (MethodData.Emit): Generate debugging info for external methods.
17365 2003-02-02 Martin Baulig <martin@ximian.com>
17367 * class.cs (Constructor.Emit): Open the symbol writer before
17368 emitting the constructor initializer.
17369 (ConstructorInitializer.Emit): Call ec.Mark() to allow
17370 single-stepping through constructor initializers.
17372 2003-01-30 Miguel de Icaza <miguel@ximian.com>
17374 * class.cs: Handle error 549: do not allow virtual methods in
17377 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
17379 * decl.cs: Check access levels when resolving types
17381 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
17383 * statement.cs: Add parameters and locals set in catch blocks that might
17384 return to set vector
17386 2003-01-29 Miguel de Icaza <miguel@ximian.com>
17388 * class.cs (Operator): Set the SpecialName flags for operators.
17390 * expression.cs (Invocation.DoResolve): Only block calls to
17391 accessors and operators on SpecialName methods.
17393 (Cast.TryReduce): Handle conversions from char constants.
17396 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
17398 * statement.cs: small memory and time optimization in FlowBranching.
17400 2003-01-28 Pedro Mart <yoros@wanadoo.es>
17402 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
17403 problem that the last fix but in the other sid (Set).
17405 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
17406 access when there is no indexer in the hierarchy.
17408 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
17410 * class.cs: Combine some if statements.
17412 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17414 * driver.cs: fixed bug #37187.
17416 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
17418 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
17419 any indexer, it's needed to build a list with all the indexers in the
17420 hierarchy (AllGetters), else we have problems. Fixes #35653.
17422 2003-01-23 Miguel de Icaza <miguel@ximian.com>
17424 * class.cs (MethodData.Define): It is wrong for an interface
17425 implementation to be static in both cases: explicit and implicit.
17426 We were only handling this in one case.
17428 Improve the if situation there to not have negations.
17430 * class.cs (Field.Define): Turns out that we do not need to check
17431 the unsafe bit on field definition, only on usage. Remove the test.
17433 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17435 * driver.cs: use assembly.Location instead of Codebase (the latest
17436 patch made mcs fail when using MS assemblies).
17438 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
17440 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
17441 get the path to *corlib.dll.
17443 2003-01-21 Nick Drochak <ndrochak@gol.com>
17447 * typemanager.cs: Remove compiler warnings
17449 2003-01-20 Duncan Mak <duncan@ximian.com>
17451 * AssemblyInfo.cs: Bump the version number to 0.19.
17453 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17455 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
17457 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
17459 * class.cs (Constructor::Emit): Emit debugging info for constructors.
17461 2003-01-17 Miguel de Icaza <miguel@ximian.com>
17463 * cs-parser.jay: Small fix: we were not comparing the constructor
17464 name correctly. Thanks to Zoltan for the initial pointer.
17466 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
17468 * cs-tokenizer.cs: Set file name when specified with #line
17470 2003-01-15 Miguel de Icaza <miguel@ximian.com>
17472 * cs-parser.jay: Only perform the constructor checks here if we
17473 are named like the class; This will help provider a better
17474 error. The constructor path is taken when a type definition is
17475 not found, but most likely the user forgot to add the type, so
17476 report that rather than the constructor error.
17478 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
17480 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
17483 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17485 * cs-parser.jay: Add cleanup call.
17487 2003-01-13 Duncan Mak <duncan@ximian.com>
17489 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
17490 consistent with other methods.
17492 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
17494 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
17496 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
17498 * attribute.cs: only set GuidAttr to true when we have a
17501 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17505 * typemanager.cs: fixes to allow mcs compile corlib with the new
17506 Type.IsSubclassOf fix.
17508 2003-01-08 Miguel de Icaza <miguel@ximian.com>
17510 * expression.cs (LocalVariableReference.DoResolve): Classify a
17511 constant as a value, not as a variable. Also, set the type for
17514 * cs-parser.jay (fixed_statement): take a type instead of a
17515 pointer_type, so we can produce a better error message later.
17517 * statement.cs (Fixed.Resolve): Flag types that are not pointers
17520 (For.DoEmit): Make inifinite loops have a
17521 non-conditional branch back.
17523 (Fixed.DoEmit): First populate the pinned variables, then emit the
17524 statement, then clear the variables. Before I was emitting the
17525 code once for each fixed piece.
17528 2003-01-08 Martin Baulig <martin@ximian.com>
17530 * statement.cs (FlowBranching.MergeChild): A break in a
17531 SWITCH_SECTION does not leave a loop. Fixes #36155.
17533 2003-01-08 Martin Baulig <martin@ximian.com>
17535 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
17536 lives in the same number space than `param_map'. Fixes #36154.
17538 2003-01-07 Miguel de Icaza <miguel@ximian.com>
17540 * cs-parser.jay (constructor_declaration): Set the
17541 Constructor.ModFlags before probing for it. This makes the
17542 compiler report 514, 515 and 132 (the code was there, but got
17545 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
17546 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
17547 (GotoCase.Resolve): Set `Returns' to ALWAYS.
17549 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
17551 * enum.cs: create the enum static fields using the enum type.
17553 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
17555 * class.cs: don't try to create the ParamBuilder for the return
17556 type if it's not needed (and handle it breaking for the ms runtime
17559 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
17561 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
17563 2002-12-29 Miguel de Icaza <miguel@ximian.com>
17565 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
17566 the command. This showed up while compiling the JANET source
17567 code, which used \r as its only newline separator.
17569 2002-12-28 Miguel de Icaza <miguel@ximian.com>
17571 * class.cs (Method.Define): If we are an operator (because it
17572 reuses our code), then set the SpecialName and HideBySig. #36128
17574 2002-12-22 Miguel de Icaza <miguel@ximian.com>
17576 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
17577 exception, report error 120 `object reference required'.
17579 * driver.cs: Add --pause option, used during to measure the size
17580 of the process as it goes with --timestamp.
17582 * expression.cs (Invocation.DoResolve): Do not allow methods with
17583 SpecialName to be invoked.
17585 2002-12-21 Miguel de Icaza <miguel@ximian.com>
17587 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
17588 number before adding it.
17590 2002-12-21 Ravi Pratap <ravi@ximian.com>
17592 * ecore.cs (StandardImplicitConversion): When in an unsafe
17593 context, we allow conversion between void * to any other pointer
17594 type. This fixes bug #35973.
17596 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
17598 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
17599 is not thrown when extensionless outputs are used
17601 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17603 * rootcontext.cs: fixed compilation of corlib.
17605 2002-12-19 Miguel de Icaza <miguel@ximian.com>
17607 * attribute.cs (Attributes.Contains): Add new method.
17609 * class.cs (MethodCore.LabelParameters): if the parameter is an
17610 `out' parameter, check that no attribute `[In]' has been passed.
17612 * enum.cs: Handle the `value__' name in an enumeration.
17614 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
17616 * decl.cs: Added special case to allow overrides on "protected
17619 2002-12-18 Ravi Pratap <ravi@ximian.com>
17621 * attribute.cs (Attributes.AddAttributeSection): Rename to this
17622 since it makes much more sense.
17624 (Attributes.ctor): Don't require a Location parameter.
17626 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
17628 * attribute.cs (ApplyAttributes): Remove extra Location parameters
17629 since we already have that information per attribute.
17631 * everywhere : make appropriate changes.
17633 * class.cs (LabelParameters): Write the code which actually
17634 applies attributes to the return type. We can't do this on the MS
17635 .NET runtime so we flag a warning in the case an exception is
17638 2002-12-18 Miguel de Icaza <miguel@ximian.com>
17640 * const.cs: Handle implicit null conversions here too.
17642 2002-12-17 Ravi Pratap <ravi@ximian.com>
17644 * class.cs (MethodCore.LabelParameters): Remove the extra
17645 Type [] parameter since it is completely unnecessary. Instead
17646 pass in the method's attributes so that we can extract
17647 the "return" attribute.
17649 2002-12-17 Miguel de Icaza <miguel@ximian.com>
17651 * cs-parser.jay (parse): Use Report.Error to flag errors instead
17652 of ignoring it and letting the compile continue.
17654 * typemanager.cs (ChangeType): use an extra argument to return an
17655 error condition instead of throwing an exception.
17657 2002-12-15 Miguel de Icaza <miguel@ximian.com>
17659 * expression.cs (Unary.TryReduce): mimic the code for the regular
17660 code path. Perform an implicit cast in the cases where we can
17661 implicitly convert to one of the integral types, and then reduce
17662 based on that constant. This fixes bug #35483.
17664 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17666 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
17668 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17670 * namespace.cs: fixed bug #35489.
17672 2002-12-12 Miguel de Icaza <miguel@ximian.com>
17674 * class.cs: Remove some dead code.
17676 * cs-parser.jay: Estimate the number of methods needed
17677 (RootContext.MethodCount);
17679 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
17680 numbers instead of StringBuilders.
17682 * support.cs (PtrHashtable): Add constructor with initial size;
17683 We can now reduce reallocations of the method table.
17685 2002-12-10 Ravi Pratap <ravi@ximian.com>
17687 * attribute.cs (ApplyAttributes): Keep track of the emitted
17688 attributes on a per-target basis. This fixes bug #35413.
17690 2002-12-10 Miguel de Icaza <miguel@ximian.com>
17692 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
17693 default to the Windows 1252 encoding.
17695 (UnixParseOption): Support version, thanks to Alp for the missing
17698 * AssemblyInfo.cs: Add nice assembly information.
17700 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
17703 * cs-parser.jay: Allow a trailing comma before the close bracked
17704 in the attribute_section production.
17706 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
17707 address of the instance was being taken, I will take this out,
17708 because we take the address of the object immediately here.
17710 2002-12-09 Ravi Pratap <ravi@ximian.com>
17712 * typemanager.cs (AreMultipleAllowed): Take care of the most
17713 obvious case where attribute type is not in the current assembly -
17716 2002-12-08 Miguel de Icaza <miguel@ximian.com>
17718 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
17719 definitions, instead of doing that afterwards.
17721 Also we use a nice little hack, depending on the constructor, we
17722 know if we are a "composed" name or a simple name. Hence, we
17723 avoid the IndexOf test, and we avoid
17725 * codegen.cs: Add code to assist in a bug reporter to track down
17726 the source of a compiler crash.
17728 2002-12-07 Ravi Pratap <ravi@ximian.com>
17730 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
17731 types have been emitted for a given element and flag an error
17732 if something which does not have AllowMultiple set is used more
17735 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
17736 attribute types and their corresponding AllowMultiple properties
17738 (AreMultipleAllowed): Check the property for a given type.
17740 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
17741 property in the case we have a TypeContainer.
17743 (Attributes.AddAttribute): Detect duplicates and just skip on
17744 adding them. This trivial fix catches a pretty gross error in our
17745 attribute emission - global attributes were being emitted twice!
17747 Bugzilla bug #33187 is now fixed.
17749 2002-12-06 Miguel de Icaza <miguel@ximian.com>
17751 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
17752 instead of pp_and).
17754 * expression.cs (Binary.ResolveOperator): I can only use the
17755 Concat (string, string, string) and Concat (string, string,
17756 string, string) if the child is actually a concatenation of
17759 2002-12-04 Miguel de Icaza <miguel@ximian.com>
17761 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
17762 context where we need a 2-character lookahead.
17764 * pending.cs (PendingImplementation): Rework so we can keep track
17765 of interface types all the time, and flag those which were
17766 implemented by parents as optional.
17768 2002-12-03 Miguel de Icaza <miguel@ximian.com>
17770 * expression.cs (Binary.ResolveOperator): Use
17771 String.Concat(string,string,string) or
17772 String.Concat(string,string,string,string) when possible.
17774 * typemanager: More helper methods.
17777 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
17779 * pending.cs: remove the bogus return from GetMissingInterfaces()
17780 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
17782 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17784 * namespace.cs: avoid duplicated 'using xxx' being added to
17785 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
17786 when we get more than one 'using' statement for the same namespace.
17787 Report a CS0105 warning for it.
17789 2002-11-30 Miguel de Icaza <miguel@ximian.com>
17791 * cs-tokenizer.cs (consume_identifier): use read directly, instead
17792 of calling getChar/putback, uses internal knowledge of it.
17794 (xtoken): Reorder tokenizer so most common patterns are checked
17795 first. This reduces the compilation time in another 5% (from 8.11s
17796 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
17798 The parsing time is 22% of the compilation in mcs, and from that
17799 64% is spent on the tokenization process.
17801 I tried using a binary search for keywords, but this is slower
17802 than the hashtable. Another option would be to do a couple of
17805 * Not use a StringBuilder, instead use an array of chars,
17806 with a set value. Notice that this way we could catch
17807 the 645 error without having to do it *afterwards*.
17809 * We could write a hand-parser to avoid the hashtable
17810 compares altogether.
17812 The identifier consumption process takes 37% of the tokenization
17813 time. Another 15% is spent on is_number. 56% of the time spent
17814 on is_number is spent on Int64.Parse:
17816 * We could probably choose based on the string length to
17817 use Int32.Parse or Int64.Parse and avoid all the 64-bit
17820 Another 3% is spend on wrapping `xtoken' in the `token' function.
17822 Handle 0xa0 as whitespace (#34752)
17824 2002-11-26 Miguel de Icaza <miguel@ximian.com>
17826 * typemanager.cs (IsCLRType): New routine to tell whether a type
17827 is one of the builtin types.
17829 Maybe it needs to use TypeCodes to be faster. Maybe we could use
17830 typecode in more places instead of doing pointer comparissions.
17831 We could leverage some knowledge about the way the typecodes are
17834 New code to cache namespaces in assemblies, it is currently not
17835 invoked, to be used soon.
17837 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
17839 * expression.cs (Binary.ResolveOperator): specially handle
17840 strings, and do not perform user-defined operator overloading for
17843 2002-11-24 Miguel de Icaza <miguel@ximian.com>
17845 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
17846 internalcall as it is a pretty simple operation; Avoid whenever
17847 possible to call Char.IsLetter.
17849 (consume_identifier): Cut by half the number of
17850 hashtable calls by merging the is_keyword and GetKeyword behavior.
17852 Do not short-circuit, because if we do, we
17853 report errors (ie, #if false && true would produce an invalid
17857 2002-11-24 Martin Baulig <martin@ximian.com>
17859 * expression.cs (Cast.TryReduce): If we're in checked syntax,
17860 check constant ranges and report a CS0221. Fixes #33186.
17862 2002-11-24 Martin Baulig <martin@ximian.com>
17864 * cs-parser.jay: Make this work for uninitialized variable
17865 declarations in the `for' initializer. Fixes #32416.
17867 2002-11-24 Martin Baulig <martin@ximian.com>
17869 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
17870 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
17872 2002-11-24 Martin Baulig <martin@ximian.com>
17874 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
17875 argument; if true, we also check for user-defined conversions.
17876 This is only needed if both arguments are of a user-defined type.
17877 Fixes #30443, added test-175.cs.
17878 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
17880 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
17882 2002-11-24 Martin Baulig <martin@ximian.com>
17884 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
17885 function to get the store opcode.
17886 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
17887 only emit the Ldelema if the store opcode is Stobj. You must run
17888 both test-34 and test-167 to test this. Fixes #34529.
17890 2002-11-23 Martin Baulig <martin@ximian.com>
17892 * ecore.cs (Expression.MemberLookup): Added additional
17893 `qualifier_type' argument which is used when we're being called
17894 from MemberAccess.DoResolve() and null if we're called from a
17896 (Expression.MemberLookupFailed): New method to report errors; this
17897 does the CS1540 check and reports the correct error message.
17899 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
17900 argument for the CS1540 check and redone the way how we're dealing
17901 with private members. See the comment in the source code for details.
17902 (FilterWithClosure): Reverted this back to revision 1.197; renamed
17903 `closure_start_type' to `closure_qualifier_type' and check whether
17904 it's not null. It was not this filter being broken, it was just
17905 being called with the wrong arguments.
17907 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
17908 and pass it the correct `qualifier_type'; this also does the error
17911 2002-11-22 Miguel de Icaza <miguel@ximian.com>
17913 * expression.cs (Invocation.EmitParams): If the we are dealing
17914 with a non-built-in value type, load its address as well.
17916 (ArrayCreation): Use a a pretty constant instead
17917 of the hardcoded value 2. Use 6 instead of 2 for the number of
17918 static initializers.
17920 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
17921 because they are not really value types, just glorified integers.
17923 * driver.cs: Do not append .exe, the CSC compiler does not do it.
17925 * ecore.cs: Remove redundant code for enumerations, make them use
17926 the same code path as everything else, fixes the casting issue
17927 with enumerations in Windows.Forms.
17929 * attribute.cs: Do only cast to string if it is a string, the
17930 validation happens later.
17932 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
17933 people upgrade their corlibs.
17935 * ecore.cs: Oops, enumerations were not following the entire code path
17937 2002-11-21 Miguel de Icaza <miguel@ximian.com>
17939 * typemanager.cs (FilterWithClosure): Commented out the test for
17940 1540 in typemanager.cs, as it has problems when accessing
17941 protected methods from a parent class (see test-174.cs).
17943 * attribute.cs (Attribute.ValidateGuid): new method.
17944 (Attribute.Resolve): Use above.
17946 2002-11-19 Miguel de Icaza <miguel@ximian.com>
17948 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
17950 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
17951 handling for enumerations, as we only needed the TypeContainer
17952 functionality to begin with (this is required for the fix below to
17953 work for enums that reference constants in a container class for
17956 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
17958 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
17959 a valid TypeBuilder to perform lookups on.o
17961 * class.cs (InheritableMemberSignatureCompare): Use true in the
17962 call to GetGetMethod and GetSetMethod, because we are comparing
17963 the signature, and we need to get the methods *even* if they are
17966 (PropertyBase.CheckBase): ditto.
17968 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
17969 GotoCase.Resolve): Use Peel on EmpytCasts.
17971 * ecore.cs (EmptyCast): drop child, add Peel method.
17973 2002-11-17 Martin Baulig <martin@ximian.com>
17975 * ecore.cs (EmptyCast.Child): New public property.
17977 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
17978 label resolved to an EmptyCast. Fixes #34162.
17979 (GotoCase.Resolve): Likewise.
17980 (Block.EmitMeta): Likewise.
17982 2002-11-17 Martin Baulig <martin@ximian.com>
17984 * expression.cs (Invocation.BetterConversion): Prefer int over
17985 uint; short over ushort; long over ulong for integer literals.
17986 Use ImplicitConversionExists instead of StandardConversionExists
17987 since we also need to check for user-defined implicit conversions.
17988 Fixes #34165. Added test-173.cs.
17990 2002-11-16 Martin Baulig <martin@ximian.com>
17992 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
17993 with the `true' and `false' literals. Fixes #33151.
17995 2002-11-16 Martin Baulig <martin@ximian.com>
17997 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
17998 October 22nd; don't do the cs1540 check for static members.
18000 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
18001 now using our own filter here and doing the cs1540 check again.
18003 2002-11-16 Martin Baulig <martin@ximian.com>
18005 * support.cs (InternalParameters): Don't crash if we don't have
18006 any fixed parameters. Fixes #33532.
18008 2002-11-16 Martin Baulig <martin@ximian.com>
18010 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
18011 when looking up static methods to make this work on Windows.
18014 2002-11-16 Martin Baulig <martin@ximian.com>
18016 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
18017 a setter rather than using PropertyInfo.CanWrite.
18019 2002-11-15 Nick Drochak <ndrochak@gol.com>
18021 * class.cs: Allow acces to block member by subclasses. Fixes build
18024 2002-11-14 Martin Baulig <martin@ximian.com>
18026 * class.cs (Constructor.Emit): Added the extern/block check.
18029 2002-11-14 Martin Baulig <martin@ximian.com>
18031 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
18032 iteration while looking for indexers, this is needed because the
18033 indexer may have a different name in our base classes. Fixed the
18034 error reporting (no indexers at all, not get accessor, no
18035 overloaded match). Fixes bug #33089.
18036 (IndexerAccess.DoResolveLValue): Likewise.
18038 2002-11-14 Martin Baulig <martin@ximian.com>
18040 * class.cs (PropertyBase.CheckBase): Make this work for multiple
18041 indexers. Fixes the first part of bug #33089.
18042 (MethodSignature.InheritableMemberSignatureCompare): Added support
18045 2002-11-13 Ravi Pratap <ravi@ximian.com>
18047 * attribute.cs (Attribute.Resolve): Catch the
18048 NullReferenceException and report it since it isn't supposed to
18051 2002-11-12 Miguel de Icaza <miguel@ximian.com>
18053 * expression.cs (Binary.EmitBranchable): Also handle the cases for
18054 LogicalOr and LogicalAnd that can benefit from recursively
18055 handling EmitBranchable. The code now should be nice for Paolo.
18057 2002-11-08 Miguel de Icaza <miguel@ximian.com>
18059 * typemanager.cs (LookupType): Added a negative-hit hashtable for
18060 the Type lookups, as we perform quite a number of lookups on
18061 non-Types. This can be removed once we can deterministically tell
18062 whether we have a type or a namespace in advance.
18064 But this might require special hacks from our corlib.
18068 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
18069 and double which avoids a conversion from an integer to a double.
18071 * expression.cs: tiny optimization, avoid calling IsConstant,
18072 because it effectively performs the lookup twice.
18074 2002-11-06 Miguel de Icaza <miguel@ximian.com>
18076 But a bogus return here to keep the semantics of the old code
18077 until the Mono runtime is fixed.
18079 * pending.cs (GetMissingInterfaces): New method used to remove all
18080 the interfaces that are already implemented by our parent
18081 classes from the list of pending methods.
18083 * interface.cs: Add checks for calls after ResolveTypeExpr.
18085 2002-11-05 Miguel de Icaza <miguel@ximian.com>
18087 * class.cs (Class.Emit): Report warning 67: event not used if the
18088 warning level is beyond 3.
18090 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
18091 being a NullLiteral.
18093 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
18096 * class.cs (TypeContainer.GetClassBases): Cover a missing code
18097 path that might fail if a type can not be resolved.
18099 * expression.cs (Binary.Emit): Emit unsigned versions of the
18102 * driver.cs: use error 5.
18104 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
18106 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
18108 2002-11-01 Miguel de Icaza <miguel@ximian.com>
18110 * cs-parser.jay (switch_section): A beautiful patch from Martin
18111 Baulig that fixed 33094.
18113 2002-10-31 Miguel de Icaza <miguel@ximian.com>
18115 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
18116 Check whether the base is abstract and report an error if so.
18118 * expression.cs (IndexerAccess.DoResolveLValue,
18119 IndexerAccess.DoResolve): ditto.
18121 (Invocation.DoResolve): ditto.
18123 (Invocation.FullMethodDesc): Improve the report string.
18125 * statement.cs (Block): Eliminate IsVariableDefined as it is
18126 basically just a wrapper for GetVariableInfo.
18128 * ecore.cs (SimpleName): Use new
18130 * support.cs (ReflectionParamter.ParameterType): We unwrap the
18131 type, as we return the actual parameter ref/unref state on a
18134 2002-10-30 Miguel de Icaza <miguel@ximian.com>
18136 * support.cs: Return proper flags REF/OUT fixing the previous
18139 * expression.cs: Reverted last patch, that was wrong. Is_ref is
18140 not used to mean `ref' but `ref or out' in ParameterReference
18142 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
18143 full type signature instead of calling TypeManger.CSharpName
18146 * support.cs (InternalParameters.ParameterDesc): Do not compare
18147 directly to the modflags, because REF/OUT will actually be bitsets
18150 * delegate.cs (VerifyMethod): Check also the modifiers.
18152 * cs-tokenizer.cs: Fix bug where floating point values with an
18153 exponent where a sign was missing was ignored.
18155 * driver.cs: Allow multiple assemblies to be specified in a single
18158 2002-10-28 Miguel de Icaza <miguel@ximian.com>
18160 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
18161 because identifiers after a parenthesis would end up in this kind
18162 of production, and we needed to desamiguate it for having casts
18165 (UserDefinedType *) xxx
18167 2002-10-24 Miguel de Icaza <miguel@ximian.com>
18169 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
18170 we should set on the Bindingflags.NonPublic, but not turn on
18171 private_ok. private_ok controls whether a Private member is
18172 returned (this is chekced on the filter routine), while the
18173 BindingFlags.NonPublic just controls whether private/protected
18174 will be allowed. This fixes the problem part of the problem of
18175 private properties being allowed to be used in derived classes.
18177 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
18178 so we can call the children DoResolveLValue method (this will
18179 properly signal errors on lvalue assignments to base properties)
18181 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
18182 getter are null, and we have a property info, we know that this
18183 happened because the lookup failed, so we report an error 122 for
18184 protection level violation.
18186 We also silently return if setter and getter are null in the
18187 resolve functions, this condition only happens if we have flagged
18188 the error before. This is the other half of the problem.
18190 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
18191 not have accessibility information, that is why we were returning
18192 true in the filter function in typemanager.cs.
18194 To properly report 122 (property is inaccessible because of its
18195 protection level) correctly, we report this error in ResolveAccess
18196 by failing if both the setter and the getter are lacking (ie, the
18199 DoResolve and DoLResolve have been modified to check for both
18200 setter/getter being null and returning silently, the reason being
18201 that I did not want to put the knowledge about this error in upper
18204 int old = Report.Errors;
18205 x = new PropertyExpr (...);
18206 if (old != Report.Errors)
18211 So the property expr is returned, but it is invalid, so the error
18212 will be flagged during the resolve process.
18214 * class.cs: Remove InheritablePropertySignatureCompare from the
18215 class, as we no longer depend on the property signature to compute
18216 whether it is possible to implement a method or not.
18218 The reason is that calling PropertyInfo.GetGetMethod will return
18219 null (in .NET, in Mono it works, and we should change this), in
18220 cases where the Get Method does not exist in that particular
18225 class X { public virtual int A { get { return 1; } } }
18227 class Z : Y { public override int A { get { return 2; } } }
18229 Would fail in Z because the parent (Y) would not have the property
18230 defined. So we avoid this completely now (because the alternative
18231 fix was ugly and slow), and we now depend exclusively on the
18234 (PropertyBase.CheckBase): Use a method-base mechanism to find our
18235 reference method, instead of using the property.
18237 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
18238 routines are gone now.
18240 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
18241 names, they were incorrectly named.
18243 * cs-tokenizer.cs: Return are more gentle token on failure.
18245 * pending.cs (PendingImplementation.InterfaceMethod): This routine
18246 had an out-of-sync index variable, which caused it to remove from
18247 the list of pending methods the wrong method sometimes.
18249 2002-10-22 Miguel de Icaza <miguel@ximian.com>
18251 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
18252 CanWrite, because those refer to this particular instance of the
18253 property, and do not take into account the fact that we can
18254 override single members of a property.
18256 Constructor requires an EmitContext. The resolution process does
18257 not happen here, but we need to compute the accessors before,
18258 because the resolution does not always happen for properties.
18260 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
18261 subclass, before we did not update this flag, but we did update
18264 (GetAccessors): Drop this routine, as it did not work in the
18265 presence of partially overwritten set/get methods.
18267 Notice that this broke the cs1540 detection, but that will require
18270 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18274 * driver.cs: issue a warning instead of an error if we don't support
18275 debugging for the platform. Also ignore a couple of errors that may
18276 arise when trying to write the symbols. Undo my previous patch.
18278 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18280 * driver.cs: ignore /debug switch except for Unix platforms.
18282 2002-10-23 Nick Drochak <ndrochak@gol.com>
18284 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
18286 2002-10-21 Miguel de Icaza <miguel@ximian.com>
18288 * driver.cs: Do not make mcs-debug conditional, so we do not break
18289 builds that use it.
18291 * statement.cs (UsageVector.MergeChildren): I would like Martin to
18292 review this patch. But basically after all the children variables
18293 have been merged, the value of "Breaks" was not being set to
18294 new_breaks for Switch blocks. I think that it should be set after
18295 it has executed. Currently I set this to the value of new_breaks,
18296 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
18297 conservative, but I do not understand this code very well.
18299 I did not break anything in the build, so that is good ;-)
18301 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
18303 2002-10-20 Mark Crichton <crichton@gimp.org>
18305 * cfold.cs: Fixed compile blocker. Really fixed it this time.
18307 2002-10-20 Nick Drochak <ndrochak@gol.com>
18309 * cfold.cs: Fixed compile blocker.
18311 2002-10-20 Miguel de Icaza <miguel@ximian.com>
18313 * driver.cs: I was chekcing the key, not the file.
18315 2002-10-19 Ravi Pratap <ravi@ximian.com>
18317 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
18318 message that we were generating - we just need to silently return
18321 2002-10-19 Miguel de Icaza <miguel@ximian.com>
18323 * class.cs (Event.Define): Change my previous commit, as this
18324 breaks the debugger. This is a temporary hack, as it seems like
18325 the compiler is generating events incorrectly to begin with.
18327 * expression.cs (Binary.ResolveOperator): Added support for
18328 "U operator - (E x, E y)"
18330 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
18333 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
18334 init-only variables, but this path did not take into account that
18335 there might be also instance readonly variables. Correct this
18338 This fixes bug 32253
18340 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
18343 * driver.cs: Change the extension for modules to `netmodule'
18345 * cs-parser.jay: Improved slightly the location tracking for
18346 the debugger symbols.
18348 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
18349 modifiers that were specified instead of the hardcoded value
18350 (FamAndAssem). This was basically ignoring the static modifier,
18351 and others. Fixes 32429.
18353 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
18354 fixed a bug in the process (32476)
18356 * expression.cs (ArrayAccess.EmitAssign): Patch from
18357 hwang_rob@yahoo.ca that fixes bug 31834.3
18359 2002-10-18 Miguel de Icaza <miguel@ximian.com>
18361 * driver.cs: Make the module extension .netmodule.
18363 2002-10-16 Miguel de Icaza <miguel@ximian.com>
18365 * driver.cs: Report an error if the resource file is not found
18366 instead of crashing.
18368 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
18369 false, like Emit does.
18371 2002-10-16 Nick Drochak <ndrochak@gol.com>
18373 * typemanager.cs: Remove unused private member. Also reported mcs
18374 bug to report this as a warning like csc.
18376 2002-10-15 Martin Baulig <martin@gnome.org>
18378 * statement.cs (Statement.Emit): Made this a virtual method; emits
18379 the line number info and calls DoEmit().
18380 (Statement.DoEmit): New protected abstract method, formerly knows
18381 as Statement.Emit().
18383 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
18385 2002-10-11 Miguel de Icaza <miguel@ximian.com>
18387 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
18388 have fixed a remaining problem: not every AddXXXX was adding a
18389 fully qualified name.
18391 Now everyone registers a fully qualified name in the DeclSpace as
18392 being defined instead of the partial name.
18394 Downsides: we are slower than we need to be due to the excess
18395 copies and the names being registered this way.
18397 The reason for this is that we currently depend (on the corlib
18398 bootstrap for instance) that types are fully qualified, because
18399 we dump all the types in the namespace, and we should really have
18400 types inserted into the proper namespace, so we can only store the
18401 basenames in the defined_names array.
18403 2002-10-10 Martin Baulig <martin@gnome.org>
18405 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
18406 from bug #31834, see the bug report for a testcase which is
18409 2002-10-10 Martin Baulig <martin@gnome.org>
18411 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
18412 flow analysis code for this.
18414 * statement.cs (Do, While, For): Tell the flow analysis code about
18416 (FlowBranching.UsageVector): Added support for infinite loops.
18417 (Block.Resolve): Moved the dead code elimination here and use flow
18420 2002-10-09 Miguel de Icaza <miguel@ximian.com>
18422 * class.cs (Field.Define): Catch cycles on struct type
18425 * typemanager.cs (IsUnmanagedtype): Do not recursively check
18426 fields if the fields are static. We only need to check instance
18429 * expression.cs (As.DoResolve): Test for reference type.
18431 * statement.cs (Using.ResolveExpression): Use
18432 ConvertImplicitRequired, not ConvertImplicit which reports an
18434 (Using.ResolveLocalVariableDecls): ditto.
18436 * expression.cs (Binary.ResolveOperator): Report errors in a few
18437 places where we had to.
18439 * typemanager.cs (IsUnmanagedtype): Finish implementation.
18441 2002-10-08 Miguel de Icaza <miguel@ximian.com>
18443 * expression.cs: Use StoreFromPtr instead of extracting the type
18444 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
18446 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
18447 an enumeration value to a System.Enum, but System.Enum is not a
18448 value type, but an class type, so we need to box.
18450 (Expression.ConvertExplicit): One codepath could return
18451 errors but not flag them. Fix this. Fixes #31853
18453 * parameter.cs (Resolve): Do not allow void as a parameter type.
18455 2002-10-06 Martin Baulig <martin@gnome.org>
18457 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
18458 if it's a class type and not a struct. Fixes #31815.
18460 2002-10-06 Martin Baulig <martin@gnome.org>
18462 * statement.cs: Reworked the flow analysis code a bit to make it
18463 usable for dead code elimination.
18465 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18467 * cs-parser.jay: allow empty source files. Fixes bug #31781.
18469 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18471 * expression.cs (ComposedCast.DoResolveType): A quick workaround
18472 to fix the test 165, will investigate deeper.
18474 2002-10-04 Martin Baulig <martin@gnome.org>
18476 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
18477 finally blocks actually work.
18478 (Try.Resolve): We don't need to create a sibling for `finally' if
18479 there is no finally block.
18481 2002-10-04 Martin Baulig <martin@gnome.org>
18483 * class.cs (Constructor.Define): The default accessibility for a
18484 non-default constructor is private, not public.
18486 2002-10-04 Miguel de Icaza <miguel@ximian.com>
18488 * class.cs (Constructor): Make AllowedModifiers public, add
18491 * cs-parser.jay: Perform the modifiers test here, as the
18492 constructor for the Constructor class usually receives a zero
18493 because of the way we create it (first we create, later we
18494 customize, and we were never checking the modifiers).
18496 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
18497 is a version of LookupTypeReflection that includes the type-name
18498 cache. This can be used as a fast path for functions that know
18499 the fully qualified name and are only calling into *.GetType() to
18500 obtain a composed type.
18502 This is also used by TypeManager.LookupType during its type
18505 (LookupType): We now also track the real type name, as sometimes
18506 we can get a quey for the real type name from things like
18507 ComposedCast. This fixes bug 31422.
18509 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
18510 complete type fullname, it does not have to go through the type
18511 resolution system to obtain the composed version of the type (for
18512 obtaining arrays or pointers).
18514 (Conditional.Emit): Use the EmitBoolExpression to
18515 generate nicer code, as requested by Paolo.
18517 (ArrayCreation.CheckIndices): Use the patch from
18518 hwang_rob@yahoo.ca to validate the array initializers.
18520 2002-10-03 Miguel de Icaza <miguel@ximian.com>
18522 * class.cs (ConstructorInitializer.Emit): simplify code by using
18523 Invocation.EmitCall, and at the same time, fix the bugs in calling
18524 parent constructors that took variable arguments.
18526 * ecore.cs (Expression.ConvertNumericExplicit,
18527 Expression.ImplicitNumericConversion): Remove the code that
18528 manually wrapped decimal (InternalTypeConstructor call is now gone
18531 * expression.cs (Cast.TryReduce): Also handle decimal types when
18532 trying to perform a constant fold on the type.
18534 * typemanager.cs (IsUnmanagedtype): Partially implemented.
18536 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
18537 that only turned off an error report, and did nothing else.
18539 2002-10-02 Miguel de Icaza <miguel@ximian.com>
18541 * driver.cs: Handle and ignore /fullpaths
18543 2002-10-01 Miguel de Icaza <miguel@ximian.com>
18545 * expression.cs (Binary.ResolveOperator): Catch the case where
18546 DoNumericPromotions returns true,
18548 (Binary.DoNumericPromotions): Simplify the code, and the tests.
18550 2002-09-27 Miguel de Icaza <miguel@ximian.com>
18552 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
18555 2002-09-26 Miguel de Icaza <miguel@ximian.com>
18557 * ecore.cs (ConvertNumericExplicit): It is not enough that the
18558 conversion exists, but it is also required that the conversion be
18559 performed. This manifested in "(Type64Enum) 2".
18561 * class.cs (TypeManager.AddMethod): The fix is not to change
18562 AddEnum, because that one was using a fully qualified name (every
18563 DeclSpace derivative does), but to change the AddMethod routine
18564 that was using an un-namespaced name. This now correctly reports
18565 the duplicated name.
18567 Revert patch until I can properly fix it. The issue
18568 is that we have a shared Type space across all namespaces
18569 currently, which is wrong.
18571 Options include making the Namespace a DeclSpace, and merge
18572 current_namespace/current_container in the parser.
18574 2002-09-25 Miguel de Icaza <miguel@ximian.com>
18576 * cs-parser.jay: Improve error reporting when we get a different
18577 kind of expression in local_variable_type and
18578 local_variable_pointer_type.
18580 Propagate this to avoid missleading errors being reported.
18582 * ecore.cs (ImplicitReferenceConversion): treat
18583 TypeManager.value_type as a target just like object_type. As
18588 Is valid, and needs to result in the int 1 being boxed before it
18589 is assigned to the value type v.
18591 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
18592 to validate the enumeration name.
18594 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
18595 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
18596 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
18598 * ecore.cs (TryImplicitIntConversion): When doing an
18599 implicit-enumeration-conversion, check if the type is 64-bits and
18600 perform a conversion before passing to EnumConstant.
18602 2002-09-23 Miguel de Icaza <miguel@ximian.com>
18604 * decl.cs (Error_AmbiguousTypeReference); New routine used to
18605 report ambiguous type references. Unlike the MS version, we
18606 report what the ambiguity is. Innovation at work ;-)
18608 (DeclSpace.FindType): Require a location argument to
18609 display when we display an ambiguous error.
18611 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
18613 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
18615 * expression.cs (EmitDynamicInitializers): Apply patch from
18616 hwang_rob@yahoo.ca that fixes the order in which we emit our
18619 2002-09-21 Martin Baulig <martin@gnome.org>
18621 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
18622 delegate takes no arguments.
18624 2002-09-20 Miguel de Icaza <miguel@ximian.com>
18626 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
18629 * expression.cs: Extract the underlying type.
18631 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
18633 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
18635 2002-09-19 Miguel de Icaza <miguel@ximian.com>
18637 * class.cs (TypeContainer.DefineType): We can not use the nice
18638 PackingSize with the size set to 1 DefineType method, because it
18639 will not allow us to define the interfaces that the struct
18642 This completes the fixing of bug 27287
18644 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
18645 means also structs. This fixes part of the problem.
18646 (Expresion.ImplicitReferenceConversionExists): ditto.
18648 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
18649 error if there were no errors reported during the type lookup
18650 process, to avoid duplicates or redundant errors. Without this
18651 you would get an ambiguous errors plus a type not found. We have
18652 beaten the user enough with the first error.
18654 (DeclSparce.FindType): Emit a warning if we have an ambiguous
18657 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
18658 during the resolution process, stop the lookup, this avoids
18659 repeated error reports (same error twice).
18661 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
18663 * typemanager.cs (LookupType): Redo the type lookup code to match
18664 the needs of System.Reflection.
18666 The issue is that System.Reflection requires references to nested
18667 types to begin with a "+" sign instead of a dot. So toplevel
18668 types look like: "NameSpace.TopLevelClass", and nested ones look
18669 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
18672 2002-09-19 Martin Baulig <martin@gnome.org>
18674 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
18675 says that a method always returns or always throws an exception,
18676 don't report the CS0161.
18678 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
18679 set `Returns = new_returns'.
18681 2002-09-19 Martin Baulig <martin@gnome.org>
18683 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
18684 to an enum constant, check for a CS0176.
18686 2002-09-18 Miguel de Icaza <miguel@ximian.com>
18688 * class.cs (TypeContainer.CheckPairedOperators): Now we check
18689 for operators that must be in pairs and report errors.
18691 * ecore.cs (SimpleName.DoResolveType): During the initial type
18692 resolution process, when we define types recursively, we must
18693 check first for types in our current scope before we perform
18694 lookups in the enclosing scopes.
18696 * expression.cs (MakeByteBlob): Handle Decimal blobs.
18698 (Invocation.VerifyArgumentsCompat): Call
18699 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
18700 I thought we were supposed to always call this, but there are a
18701 few places in the code where we dont do it.
18703 2002-09-17 Miguel de Icaza <miguel@ximian.com>
18705 * driver.cs: Add support in -linkres and -resource to specify the
18706 name of the identifier.
18708 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18710 * ecore.cs (StandardConversionExists): Sync with the conversion
18711 code: allow anything-* to void* conversions.
18713 (FindMostSpecificSource): Use an Expression argument
18714 instead of a Type, because we might be handed over a Literal which
18715 gets a few more implicit conversions that plain types do not. So
18716 this information was being lost.
18718 Also, we drop the temporary type-holder expression when not
18721 2002-09-17 Martin Baulig <martin@gnome.org>
18723 * class.cs (PropertyBase.CheckBase): Don't check the base class if
18724 this is an explicit interface implementation.
18726 2002-09-17 Martin Baulig <martin@gnome.org>
18728 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
18729 different `IndexerName' attributes.
18731 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
18732 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
18733 virtual CommonResolve().
18735 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18737 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
18738 and convert that to the UnderlyingType.
18740 * statement.cs (Foreach.Resolve): Indexers are just like variables
18741 or PropertyAccesses.
18743 * cs-tokenizer.cs (consume_string): Track line numbers and columns
18744 inside quoted strings, we were not doing this before.
18746 2002-09-16 Martin Baulig <martin@gnome.org>
18748 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
18749 resolve it. This is needed for the definite assignment check of the
18750 instance expression, fixes bug #29846.
18751 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
18753 2002-09-16 Nick Drochak <ndrochak@gol.com>
18755 * parameter.cs: Fix compile error. Cannot reference static member
18756 from an instance object. Is this an mcs bug?
18758 2002-09-14 Martin Baulig <martin@gnome.org>
18760 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
18761 multiple times. Fixes bug #30295, added test-166.cs.
18763 2002-09-14 Martin Baulig <martin@gnome.org>
18765 * statement.cs (Block.Emit): Don't emit unreachable code.
18766 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
18767 `break' statements.
18768 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
18770 2002-09-14 Martin Baulig <martin@gnome.org>
18772 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
18775 2002-09-14 Martin Baulig <martin@gnome.org>
18777 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
18778 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
18779 be false on the ms runtime.
18781 2002-09-13 Martin Baulig <martin@gnome.org>
18783 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
18784 the CS0038 error message.
18786 2002-09-12 Miguel de Icaza <miguel@ximian.com>
18788 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
18789 constant inside, return it.
18791 2002-09-12 Martin Baulig <martin@gnome.org>
18793 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
18794 implicit conversion can be done between enum types.
18796 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
18797 check whether an implicit conversion to the current enum's UnderlyingType
18798 exists and report an error if not.
18800 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
18801 without debugging support.
18803 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
18804 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
18806 2002-09-12 Martin Baulig <martin@gnome.org>
18808 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
18810 * ecore.cs (IMemberExpr.DeclaringType): New property.
18811 (SimpleName.SimpleNameResolve): Check whether we're accessing a
18812 nonstatic member of an outer type (CS0038).
18814 2002-09-11 Miguel de Icaza <miguel@ximian.com>
18816 * driver.cs: Activate the using-error detector at warning level
18817 4 (at least for MS-compatible APIs).
18819 * namespace.cs (VerifyUsing): Small buglett fix.
18821 * pending.cs (PendingImplementation): pass the container pointer.
18823 * interface.cs (GetMethods): Allow for recursive definition. Long
18824 term, I would like to move every type to support recursive
18825 definitions, not the current ordering mechanism that we have right
18828 The situation is this: Attributes are handled before interfaces,
18829 so we can apply attributes to interfaces. But some attributes
18830 implement interfaces, we will now handle the simple cases
18831 (recursive definitions will just get an error).
18833 * parameter.cs: Only invalidate types at the end if we fail to
18836 2002-09-09 Martin Baulig <martin@gnome.org>
18838 * ecore.cs (PropertyExpr.Emit): Also check for
18839 TypeManager.system_int_array_get_length so this'll also work when
18840 compiling corlib. Fixes #30003.
18842 2002-09-09 Martin Baulig <martin@gnome.org>
18844 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
18845 and throw an exception if we can't get the type's size. Fixed #30040,
18848 2002-09-09 Martin Baulig <martin@gnome.org>
18850 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
18852 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
18853 context. Fixes bug #30027.
18855 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
18856 virtual functions. Fixes bug #30043, added test-164.cs.
18858 2002-09-08 Ravi Pratap <ravi@ximian.com>
18860 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
18862 2002-09-08 Nick Drochak <ndrochak@gol.com>
18864 * driver.cs: Use an object to get the windows codepage since it's not a
18867 2002-09-08 Miguel de Icaza <miguel@ximian.com>
18869 * statement.cs (For.Emit): for infinite loops (test == null)
18870 return whether there is a break inside, not always "true".
18872 * namespace.cs (UsingEntry): New struct to hold the name of the
18873 using definition, the location where it is defined, and whether it
18874 has been used in a successful type lookup.
18876 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
18881 2002-09-06 Ravi Pratap <ravi@ximian.com>
18883 * attribute.cs : Fix incorrect code which relied on catching
18884 a NullReferenceException to detect a null being passed in
18885 where an object was expected.
18887 2002-09-06 Miguel de Icaza <miguel@ximian.com>
18889 * statement.cs (Try): flag the catch variable as assigned
18891 * expression.cs (Cast): Simplified by using ResolveType instead of
18892 manually resolving.
18894 * statement.cs (Catch): Fix bug by using ResolveType.
18896 2002-09-06 Ravi Pratap <ravi@ximian.com>
18898 * expression.cs (BetterConversion): Special case for when we have
18899 a NullLiteral as the argument and we have to choose between string
18900 and object types - we choose string the way csc does.
18902 * attribute.cs (Attribute.Resolve): Catch the
18903 NullReferenceException and report error #182 since the Mono
18904 runtime no more has the bug and having this exception raised means
18905 we tried to select a constructor which takes an object and is
18908 2002-09-05 Ravi Pratap <ravi@ximian.com>
18910 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
18911 message (1502, 1503) when we can't locate a method after overload
18912 resolution. This is much more informative and closes the bug
18915 * interface.cs (PopulateMethod): Return if there are no argument
18916 types. Fixes a NullReferenceException bug.
18918 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
18919 expressions too. Previously we were checking only in one place for
18920 positional arguments leaving out named arguments.
18922 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
18923 type to the enum type is not allowed. Remove code corresponding to
18926 (ConvertNumericExplicit): Allow explicit conversions from
18927 the underlying type to enum type. This precisely follows the spec
18928 and closes a bug filed by Gonzalo.
18930 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18933 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
18935 2002-09-03 Miguel de Icaza <miguel@ximian.com>
18937 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
18938 it was important that we stored the right value after the
18939 reduction in `converted'.
18941 2002-09-04 Martin Baulig <martin@gnome.org>
18943 * location.cs (Location.SymbolDocument): Use full pathnames for the
18946 2002-08-30 Miguel de Icaza <miguel@ximian.com>
18948 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
18949 of the expression resolve mechanism, because that will catch the
18950 SimpleName error failures.
18952 (Conditional): If we can not resolve the
18953 expression, return, do not crash.
18955 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18958 (location): display token name instead of its number.
18960 2002-08-28 Martin Baulig <martin@gnome.org>
18962 * expression.cs (Binary.ResolveOperator): Don't silently return
18963 but return an error if an operator cannot be applied between two
18966 2002-08-28 Martin Baulig <martin@gnome.org>
18968 * class.cs (Constructor.Define): Set the permission attributes
18969 correctly instead of making all constructors public.
18971 2002-08-28 Martin Baulig <martin@gnome.org>
18973 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
18974 for private members before reporting a CS0103; if we find anything,
18977 2002-08-28 Martin Baulig <martin@gnome.org>
18979 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
18980 to check whether `closure_start_type == closure_invocation_type',
18981 we also need to check whether `m.DeclaringType == closure_invocation_type'
18982 before bypassing the permission checks. We might be accessing
18983 protected/private members from the base class.
18984 (TypeManager.RealMemberLookup): Only set private_ok if private
18985 members were requested via BindingFlags.NonPublic.
18987 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
18989 * expression.cs (MemberAccess.ResolveMemberAccess): Set
18990 MethodGroupExpr.IsExplicitImpl if appropriate.
18991 (Invocation.DoResolve): Don't report the CS0120 for explicit
18992 interface implementations.
18994 2002-08-27 Martin Baulig <martin@gnome.org>
18996 * expression.cs (Invocation.DoResolve): If this is a static
18997 method and we don't have an InstanceExpression, we must report
19000 2002-08-25 Martin Baulig <martin@gnome.org>
19002 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
19003 `==' between a valuetype and an object.
19005 2002-08-25 Miguel de Icaza <miguel@ximian.com>
19007 * ecore.cs (TypeExpr): Provide a ToString method.
19009 2002-08-24 Martin Baulig <martin@gnome.org>
19011 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
19012 now called proggie.dbg and it's a binary file.
19014 2002-08-23 Martin Baulig <martin@gnome.org>
19016 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
19018 2002-08-23 Martin Baulig <martin@gnome.org>
19020 * struct.cs (MyStructInfo.ctor): Make this work with empty
19021 structs; it's not allowed to use foreach() on null.
19023 2002-08-23 Martin Baulig <martin@gnome.org>
19025 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
19026 writer the full pathname of the generated assembly.
19028 2002-08-23 Martin Baulig <martin@gnome.org>
19030 * statements.cs (FlowBranching.UsageVector.MergeChildren):
19031 A `finally' block never returns or breaks; improved handling of
19034 2002-08-23 Martin Baulig <martin@gnome.org>
19036 * statement.cs (Throw.Resolve): Allow `throw null'.
19038 2002-08-23 Martin Baulig <martin@gnome.org>
19040 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
19041 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
19042 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
19043 MemberLookup would return a wrong event if this is an explicit
19044 interface implementation and the class has an event with the same
19047 2002-08-23 Martin Baulig <martin@gnome.org>
19049 * statement.cs (Block.AddChildVariableNames): New public method.
19050 (Block.AddChildVariableName): Likewise.
19051 (Block.IsVariableNameUsedInChildBlock): Likewise.
19052 (Block.AddVariable): Check whether a variable name has already
19053 been used in a child block.
19055 * cs-parser.jay (declare_local_variables): Mark all variable names
19056 from the current block as being used in a child block in the
19059 2002-08-23 Martin Baulig <martin@gnome.org>
19061 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
19062 find the symbol writer.
19064 * driver.cs: csc also allows the arguments to /define being
19065 separated by commas, not only by semicolons.
19067 2002-08-23 Martin Baulig <martin@gnome.org>
19069 * interface.cs (Interface.GetMembers): Added static check for events.
19071 2002-08-15 Martin Baulig <martin@gnome.org>
19073 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
19074 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
19076 * ecore.cs (Expression.MemberLookup): Added documentation and explained
19077 why the MethodData.EmitDestructor() change was necessary.
19079 2002-08-20 Martin Baulig <martin@gnome.org>
19081 * class.cs (TypeContainer.FindMembers): Added static check for events.
19083 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
19085 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
19086 use Type.GetEvents(), not Type.FindMembers().
19088 2002-08-20 Martin Baulig <martin@gnome.org>
19090 * decl.cs (MemberCache): Added a special method cache which will
19091 be used for method-only searched. This ensures that a method
19092 search will return a MethodInfo with the correct ReflectedType for
19095 2002-08-20 Martin Baulig <martin@gnome.org>
19097 * decl.cs (DeclSpace.FindMembers): Made this public.
19099 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19101 * delegate.cs: fixed build on windows.
19102 [FIXME: Filed as bug #29150: MCS must report these errors.]
19104 2002-08-19 Ravi Pratap <ravi@ximian.com>
19106 * ecore.cs (StandardConversionExists): Return a false
19107 if we are trying to convert the void type to anything else
19108 since that is not allowed.
19110 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
19111 we flag error 70 in the event an event is trying to be accessed
19112 directly from outside the declaring type.
19114 2002-08-20 Martin Baulig <martin@gnome.org>
19116 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
19117 MemberCache from typemanager.cs to decl.cs.
19119 2002-08-19 Martin Baulig <martin@gnome.org>
19121 * class.cs (TypeContainer): Implement IMemberContainer.
19122 (TypeContainer.DefineMembers): Create the MemberCache.
19123 (TypeContainer.FindMembers): Do better BindingFlags checking; only
19124 return public members if BindingFlags.Public was given, check
19125 whether members are static.
19127 2002-08-16 Martin Baulig <martin@gnome.org>
19129 * decl.cs (DeclSpace.Define): Splitted this in Define and
19130 DefineMembers. DefineMembers is called first and initializes the
19133 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
19134 DefineMembers() on all our DeclSpaces.
19136 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
19137 but call DefineMembers() on all nested interfaces. We call their
19138 Define() in our new Define() function.
19140 * interface.cs (Interface): Implement IMemberContainer.
19141 (Interface.Define): Moved all code except the attribute stuf to
19143 (Interface.DefineMembers): Initialize the member cache.
19145 * typemanager.cs (IMemberFinder): Removed this interface, we don't
19146 need this anymore since we can use MemberCache.FindMembers directly.
19148 2002-08-19 Martin Baulig <martin@gnome.org>
19150 * typemanager.cs (MemberCache): When creating the cache for an
19151 interface type, add all inherited members.
19152 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
19153 to `out bool used_cache' and documented it.
19154 (TypeManager.MemberLookup): If we already used the cache in the first
19155 iteration, we don't need to do the interfaces check.
19157 2002-08-19 Martin Baulig <martin@gnome.org>
19159 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
19160 here from IMemberFinder and don't implement this interface anymore.
19161 (DeclSpace.MemberCache): Moved here from IMemberFinder.
19163 * typemanager.cs (IMemberFinder): This interface is now only used by
19164 classes which actually support the member cache.
19165 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
19166 since we only put DeclSpaces into this Hashtable.
19167 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
19168 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
19170 2002-08-16 Martin Baulig <martin@gnome.org>
19172 * typemanager.cs (ICachingMemberFinder): Removed.
19173 (IMemberFinder.MemberCache): New property.
19174 (TypeManager.FindMembers): Merged this with RealFindMembers().
19175 This function will never be called from TypeManager.MemberLookup()
19176 so we can't use the cache here, just the IMemberFinder.
19177 (TypeManager.MemberLookup_FindMembers): Check whether the
19178 IMemberFinder has a MemberCache and call the cache's FindMembers
19180 (MemberCache): Rewrote larger parts of this yet another time and
19181 cleaned it up a bit.
19183 2002-08-15 Miguel de Icaza <miguel@ximian.com>
19185 * driver.cs (LoadArgs): Support quoting.
19187 (Usage): Show the CSC-like command line arguments.
19189 Improved a few error messages.
19191 2002-08-15 Martin Baulig <martin@gnome.org>
19193 * typemanager.cs (IMemberContainer.Type): New property.
19194 (IMemberContainer.IsInterface): New property.
19196 The following changes are conditional to BROKEN_RUNTIME, which is
19197 defined at the top of the file.
19199 * typemanager.cs (MemberCache.MemberCache): Don't add the base
19200 class'es members, but add all members from TypeHandle.ObjectType
19201 if we're an interface.
19202 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
19203 is the current type.
19204 (MemberCache.CacheEntry.Container): Removed this field.
19205 (TypeHandle.GetMembers): Include inherited members.
19207 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19209 * typemanager.cs: fixed compilation and added a comment on a field that
19212 2002-08-15 Martin Baulig <martin@gnome.org>
19214 * class.cs (ConstructorInitializer.Resolve): In the
19215 Expression.MemberLookup call, use the queried_type as
19218 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
19219 declared' attribute, it's always true.
19220 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
19221 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
19222 temporary wrapper for FindMembers which tells MemberLookup whether
19223 members from the base classes are included in the return value.
19224 This will go away soon.
19225 (TypeManager.MemberLookup): Use this temporary hack here; once the
19226 new MemberCache is completed, we don't need to do the DeclaredOnly
19227 looping here anymore since the MemberCache will take care of this.
19228 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
19229 (MemberCache): When creating the MemberCache for a class, get
19230 members from the current class and all its base classes.
19231 (MemberCache.CacheEntry.Container): New field. This is a
19232 temporary hack until the Mono runtime is fixed to distinguish
19233 between ReflectedType and DeclaringType. It allows us to use MCS
19234 with both the MS runtime and the unfixed Mono runtime without
19235 problems and without accecting performance.
19236 (MemberCache.SearchMembers): The DeclaredOnly looping from
19237 TypeManager.MemberLookup is now done here.
19239 2002-08-14 Martin Baulig <martin@gnome.org>
19241 * statement.cs (MyStructInfo.MyStructInfo): Don't call
19242 Type.GetFields on dynamic types but get the fields from the
19243 corresponding TypeContainer.
19244 (MyStructInfo.GetStructInfo): Added check for enum types.
19246 * typemanager.cs (MemberList.IsSynchronized): Implemented.
19247 (MemberList.SyncRoot): Implemented.
19248 (TypeManager.FilterWithClosure): No need to check permissions if
19249 closure_start_type == closure_invocation_type, don't crash if
19250 closure_invocation_type is null.
19252 2002-08-13 Martin Baulig <martin@gnome.org>
19254 Rewrote TypeContainer.FindMembers to use a member cache. This
19255 gives us a speed increase of about 35% for the self-hosting MCS
19256 build and of about 15-20% for the class libs (both on GNU/Linux).
19258 * report.cs (Timer): New class to get enhanced profiling. This
19259 whole class is "TIMER" conditional since it remarkably slows down
19262 * class.cs (MemberList): New class. This is an IList wrapper
19263 which we're now using instead of passing MemberInfo[]'s around to
19264 avoid copying this array unnecessarily.
19265 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
19266 (ICachingMemberFinder, IMemberContainer): New interface.
19267 (TypeManager.FilterWithClosure): If `criteria' is null, the name
19268 has already been checked, otherwise use it for the name comparision.
19269 (TypeManager.FindMembers): Renamed to RealMemberFinder and
19270 provided wrapper which tries to use ICachingMemberFinder.FindMembers
19271 if possible. Returns a MemberList, not a MemberInfo [].
19272 (TypeHandle): New class, implements IMemberContainer. We create
19273 one instance of this class per type, it contains a MemberCache
19274 which is used to do the member lookups.
19275 (MemberCache): New class. Each instance of this class contains
19276 all members of a type and a name-based hash table.
19277 (MemberCache.FindMembers): This is our new member lookup
19278 function. First, it looks up all members of the requested name in
19279 the hash table. Then, it walks this list and sorts out all
19280 applicable members and returns them.
19282 2002-08-13 Martin Baulig <martin@gnome.org>
19284 In addition to a nice code cleanup, this gives us a performance
19285 increase of about 1.4% on GNU/Linux - not much, but it's already
19286 half a second for the self-hosting MCS compilation.
19288 * typemanager.cs (IMemberFinder): New interface. It is used by
19289 TypeManager.FindMembers to call FindMembers on a TypeContainer,
19290 Enum, Delegate or Interface.
19291 (TypeManager.finder_to_member_finder): New PtrHashtable.
19292 (TypeManager.finder_to_container): Removed.
19293 (TypeManager.finder_to_delegate): Removed.
19294 (TypeManager.finder_to_interface): Removed.
19295 (TypeManager.finder_to_enum): Removed.
19297 * interface.cs (Interface): Implement IMemberFinder.
19299 * delegate.cs (Delegate): Implement IMemberFinder.
19301 * enum.cs (Enum): Implement IMemberFinder.
19303 * class.cs (TypeContainer): Implement IMemberFinder.
19305 2002-08-12 Martin Baulig <martin@gnome.org>
19307 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
19309 2002-08-12 Martin Baulig <martin@gnome.org>
19311 * ecore.cs (ITypeExpression): New interface for expressions which
19313 (TypeExpression): Renamed to TypeLookupExpression.
19314 (Expression.DoResolve): If we're doing a types-only lookup, the
19315 expression must implement the ITypeExpression interface and we
19316 call DoResolveType() on it.
19317 (SimpleName): Implement the new ITypeExpression interface.
19318 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
19319 hack, the situation that we're only looking up types can't happen
19320 anymore when this method is called. Moved the type lookup code to
19321 DoResolveType() and call it.
19322 (SimpleName.DoResolveType): This ITypeExpression interface method
19323 is now doing the types-only lookup.
19324 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
19325 (ResolveFlags): Added MaskExprClass.
19327 * expression.cs (MemberAccess): Implement the ITypeExpression
19329 (MemberAccess.DoResolve): Added support for a types-only lookup
19330 when we're called via ITypeExpression.DoResolveType().
19331 (ComposedCast): Implement the ITypeExpression interface.
19333 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
19334 Expression.Resolve() with ResolveFlags.Type instead.
19336 2002-08-12 Martin Baulig <martin@gnome.org>
19338 * interface.cs (Interface.Define): Apply attributes.
19340 * attribute.cs (Attribute.ApplyAttributes): Added support for
19341 interface attributes.
19343 2002-08-11 Martin Baulig <martin@gnome.org>
19345 * statement.cs (Block.Emit): Only check the "this" variable if we
19346 do not always throw an exception.
19348 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
19349 whether the property has a set accessor.
19351 2002-08-11 Martin Baulig <martin@gnome.org>
19353 Added control flow analysis support for structs.
19355 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
19356 with control flow analysis turned off.
19357 (IVariable): New interface.
19358 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
19359 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
19360 (FieldExpr.DoResolve): Resolve the instance expression with flow
19361 analysis turned off and do the definite assignment check after the
19362 resolving when we know what the expression will resolve to.
19364 * expression.cs (LocalVariableReference, ParameterReference):
19365 Implement the new IVariable interface, only call the flow analysis
19366 code if ec.DoFlowAnalysis is true.
19367 (This): Added constructor which takes a Block argument. Implement
19368 the new IVariable interface.
19369 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
19370 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
19371 This does the definite assignment checks for struct members.
19373 * class.cs (Constructor.Emit): If this is a non-static `struct'
19374 constructor which doesn't have any initializer, call
19375 Block.AddThisVariable() to tell the flow analysis code that all
19376 struct elements must be initialized before control returns from
19379 * statement.cs (MyStructInfo): New public class.
19380 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
19381 argument to this indexer. If non-zero, check an individual struct
19382 member, not the whole struct.
19383 (FlowBranching.CheckOutParameters): Check struct members.
19384 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
19385 overloaded versions of these methods which take an additional
19386 `int field_idx' argument to check struct members.
19387 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
19388 overloaded versions of these methods which take an additional
19389 `string field_name' argument to check struct member.s
19390 (VariableInfo): Implement the IVariable interface.
19391 (VariableInfo.StructInfo): New public property. Returns the
19392 MyStructInfo instance of the variable if it's a struct or null.
19393 (Block.AddThisVariable): New public method. This is called from
19394 Constructor.Emit() for non-static `struct' constructor which do
19395 not have any initializer. It creates a special variable for the
19396 "this" instance variable which will be checked by the flow
19397 analysis code to ensure that all of the struct's fields are
19398 initialized before control returns from the constructor.
19399 (UsageVector): Added support for struct members. If a
19400 variable/parameter is a struct with N members, we reserve a slot
19401 in the usage vector for each member. A struct is considered fully
19402 initialized if either the struct itself (slot 0) or all its
19403 members are initialized.
19405 2002-08-08 Martin Baulig <martin@gnome.org>
19407 * driver.cs (Driver.MainDriver): Only report an error CS5001
19408 if there were no compilation errors.
19410 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
19411 `UnsafeContext' property to determine whether the parent is in
19412 unsafe context rather than checking the parent's ModFlags:
19413 classes nested in an unsafe class are unsafe as well.
19415 2002-08-08 Martin Baulig <martin@gnome.org>
19417 * statement.cs (UsageVector.MergeChildren): Distinguish between
19418 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
19419 we return. Added test17() and test18() to test-154.cs.
19421 2002-08-08 Martin Baulig <martin@gnome.org>
19423 * typemanager.cs (TypeManager.FilterWithClosure): If we have
19424 Family access, make sure the invoking type isn't a subclass of the
19425 queried type (that'd be a CS1540).
19427 * ecore.cs (Expression.MemberLookup): Added overloaded version of
19428 this method which takes an additional `Type invocation_type'.
19430 * expression.cs (BaseAccess.DoResolve): Use the base type as
19431 invocation and query type.
19432 (MemberAccess.DoResolve): If the lookup failed and we're about to
19433 report a CS0122, try a lookup with the ec.ContainerType - if this
19434 succeeds, we must report a CS1540.
19436 2002-08-08 Martin Baulig <martin@gnome.org>
19438 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
19439 (MethodGroupExpr): Implement the IMemberExpr interface.
19441 * expression (MemberAccess.ResolveMemberAccess): No need to have
19442 any special code for MethodGroupExprs anymore, they're now
19445 2002-08-08 Martin Baulig <martin@gnome.org>
19447 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
19448 Family, FamANDAssem and FamORAssem permissions.
19449 (TypeManager.IsSubclassOrNestedChildOf): New public method.
19451 2002-08-08 Martin Baulig <martin@gnome.org>
19453 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
19454 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
19457 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
19459 * driver.cs: implemented /resource option to embed managed resources.
19461 2002-08-07 Martin Baulig <martin@gnome.org>
19463 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
19464 (FieldBase.HasFieldInitializer): New public property.
19465 (FieldBase.GetInitializerExpression): New public method. Resolves and
19466 returns the field initializer and makes sure it is only resolved once.
19467 (TypeContainer.EmitFieldInitializers): Call
19468 FieldBase.GetInitializerExpression to get the initializer, this ensures
19469 that it isn't resolved multiple times.
19471 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
19472 the resolving process (SimpleName/MemberLookup) that we're currently
19473 emitting a field initializer (which must not access any instance members,
19474 this is an error CS0236).
19476 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
19477 argument, if the `IsFieldInitializer' flag is set, we must report and
19478 error CS0236 and not an error CS0120.
19480 2002-08-07 Martin Baulig <martin@gnome.org>
19482 * ecore.cs (IMemberExpr): New public interface.
19483 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
19484 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
19485 if the expression is an IMemberExpr.
19487 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
19488 to be null, implicitly default to `this' if we're non-static in
19489 this case. Simplified the code a lot by using the new IMemberExpr
19490 interface. Also fixed bug #28176 here.
19492 2002-08-06 Martin Baulig <martin@gnome.org>
19494 * cs-parser.jay (SimpleLookup): Removed. We need to create
19495 ParameterReferences during semantic analysis so that we can do a
19496 type-only search when resolving Cast, TypeOf and SizeOf.
19497 (block): Pass the `current_local_parameters' to the Block's
19500 * class.cs (ConstructorInitializer): Added `Parameters parameters'
19501 argument to the constructor.
19502 (ConstructorInitializer.Resolve): Create a temporary implicit
19503 block with the parameters.
19505 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
19506 references here if we aren't doing a type-only search.
19508 * statement.cs (Block): Added constructor which takes a
19509 `Parameters parameters' argument.
19510 (Block.Parameters): New public property.
19512 * support.cs (InternalParameters.Parameters): Renamed `parameters'
19513 to `Parameters' and made it public readonly.
19515 2002-08-06 Martin Baulig <martin@gnome.org>
19517 * ecore.cs (Expression.Warning): Made this public as well.
19519 * report.cs (Report.Debug): Print the contents of collections.
19521 2002-08-06 Martin Baulig <martin@gnome.org>
19523 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
19524 used to tell Resolve() which kinds of expressions it may return.
19525 (Expression.Resolve): Added overloaded version of this method which
19526 takes a `ResolveFlags flags' argument. This can be used to tell
19527 Resolve() which kinds of expressions it may return. Reports a
19529 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
19530 ResolveFlags.SimpleName.
19531 (Expression.Error118): Added overloaded version of this method which
19532 takes a `ResolveFlags flags' argument. It uses the flags to determine
19533 which kinds of expressions are allowed.
19535 * expression.cs (Argument.ResolveMethodGroup): New public method.
19536 Resolves an argument, but allows a MethodGroup to be returned.
19537 This is used when invoking a delegate.
19539 * TODO: Updated a bit.
19541 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19543 Fixed compilation with csc.
19545 * ecore.cs: Expression.Error made public. Is this correct? Should
19546 Warning be made public too?
19548 * expression.cs: use ea.Location instead of ea.loc.
19549 [FIXME: Filed as bug #28607: MCS must report these errors.]
19551 2002-08-06 Martin Baulig <martin@gnome.org>
19553 * ecore.cs (Expression.loc): Moved the location here instead of
19554 duplicating it in all derived classes.
19555 (Expression.Location): New public property.
19556 (Expression.Error, Expression.Warning): Made them non-static and
19557 removed the location argument.
19558 (Expression.Warning): Added overloaded version which takes an
19559 `int level' argument.
19560 (Expression.Error118): Make this non-static and removed the
19561 expression and location arguments.
19562 (TypeExpr): Added location argument to the constructor.
19564 * expression.cs (StaticCallExpr): Added location argument to
19566 (Indirection, PointerArithmetic): Likewise.
19567 (CheckedExpr, UnCheckedExpr): Likewise.
19568 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
19569 (StringPtr): Likewise.
19572 2002-08-05 Martin Baulig <martin@gnome.org>
19574 * expression.cs (BaseAccess.DoResolve): Actually report errors.
19576 * assign.cs (Assign.DoResolve): Check whether the source
19577 expression is a value or variable.
19579 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
19580 while resolving the corresponding blocks.
19582 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
19583 an error, don't silently return null.
19585 * statement.cs (Block.AddVariable): Do the error reporting here
19586 and distinguish between CS0128 and CS0136.
19587 (Block.DoResolve): Report all unused labels (warning CS0164).
19588 (LabeledStatement): Pass the location to the constructor.
19589 (LabeledStatement.HasBeenReferenced): New property.
19590 (LabeledStatement.Resolve): Set it to true here.
19592 * statement.cs (Return.Emit): Return success even after reporting
19593 a type mismatch error (CS0126 or CS0127), this is what csc does and
19594 it avoids confusing the users with any consecutive errors.
19596 2002-08-05 Martin Baulig <martin@gnome.org>
19598 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
19600 * const.cs (Const.LookupConstantValue): Catch circular definitions.
19602 * expression.cs (MemberAccess.DoResolve): Silently return if an
19603 error has already been reported.
19605 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
19606 error has already been reported.
19608 2002-08-05 Martin Baulig <martin@gnome.org>
19610 * statement.cs (UsageVector): Only initialize the `parameters'
19611 vector if we actually have any "out" parameters.
19613 2002-08-05 Martin Baulig <martin@gnome.org>
19615 * expression.cs (Binary.ResolveOperator): When combining delegates,
19616 they must have the same type.
19618 2002-08-05 Martin Baulig <martin@gnome.org>
19620 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
19621 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
19622 work with the ms runtime and we also don't need it: if we're a
19623 PropertyBuilder and not in the `indexer_arguments' hash, then we
19624 are a property and not an indexer.
19626 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
19627 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
19628 since the latter one doesn't work with the ms runtime.
19630 2002-08-03 Martin Baulig <martin@gnome.org>
19632 Fixed bugs #27998 and #22735.
19634 * class.cs (Method.IsOperator): New public field.
19635 (Method.CheckBase): Report CS0111 if there's already a method
19636 with the same parameters in the current class. Report CS0508 when
19637 attempting to change the return type of an inherited method.
19638 (MethodData.Emit): Report CS0179 if a method doesn't have a body
19639 and it's not marked abstract or extern.
19640 (PropertyBase): New abstract base class for Property and Indexer.
19641 (PropertyBase.CheckBase): Moved here from Property and made it work
19643 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
19644 the same so we can reuse it there.
19645 (Property, Indexer): Derive from PropertyBase.
19646 (MethodSignature.inheritable_property_signature_filter): New delegate
19647 to find properties and indexers.
19649 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
19650 argument and improved error reporting.
19652 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
19653 EmptyReadOnlyParameters and made it a property.
19655 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
19656 version of this method which takes a `PropertyInfo indexer'.
19657 (TypeManager.RegisterIndexer): New method.
19659 * class.cs: Added myself as author of this file :-)
19661 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19663 * class.cs: fixed compilation on windoze.
19665 2002-08-03 Martin Baulig <martin@gnome.org>
19667 * interface.cs (Interface.GetInterfaceBases): Check whether all
19668 base interfaces are at least as accessible than the current one.
19670 * class.cs (TypeContainer.GetClassBases): Check whether base types
19671 are at least as accessible than the current type.
19672 (TypeContainer.AsAccessible): Implemented and made non-static.
19673 (MemberBase.CheckParameters): Report errors if the accessibility
19676 * delegate.cs (Delegate.Delegate): The default visibility is
19677 internal for top-level types and private for nested types.
19678 (Delegate.Define): Report errors if the accessibility checks fail.
19680 * enum.cs (Enum.Enum): The default visibility is internal for
19681 top-level types and private for nested types.
19682 (Enum.DefineType): Compute the correct visibility.
19684 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
19685 function which takes a `bool is_toplevel' instead of a TypeContainer.
19687 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
19690 2002-08-02 Martin Baulig <martin@gnome.org>
19692 * expression.cs (LocalVariableReferenc): Added constructor which
19693 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
19694 (LocalVariableReference.IsReadOnly): New property.
19695 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
19696 variable is readonly, use our own readonly flag to do this; you can
19697 use the new constructor to get a writable reference to a read-only
19700 * cs-parser.jay (foreach_statement, using_statement): Get a writable
19701 reference to the local variable.
19703 2002-08-01 Miguel de Icaza <miguel@ximian.com>
19705 * rootcontext.cs (ResolveCore): Also include System.Exception
19707 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
19708 we reach an EmptyStatement.
19710 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
19713 * expression.cs (Binary.ResolveOperator): Check error result in
19716 use brtrue/brfalse directly and avoid compares to null.
19718 2002-08-02 Martin Baulig <martin@gnome.org>
19720 * class.cs (TypeContainer.Define): Define all nested interfaces here.
19721 Fixes bug #28407, added test-155.cs.
19723 2002-08-01 Martin Baulig <martin@gnome.org>
19725 * class.cs (Event.EmitDefaultMethod): Make this work with static
19726 events. Fixes #28311, added verify-3.cs.
19728 2002-08-01 Martin Baulig <martin@gnome.org>
19730 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
19731 `is_disposable' fields.
19732 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
19733 `hm.is_disposable' if we're using the collection pattern.
19734 (Foreach.EmitCollectionForeach): Use the correct type for the
19735 enumerator's local variable, only emit the try/finally block if
19736 necessary (fixes #27713).
19738 2002-08-01 Martin Baulig <martin@gnome.org>
19740 * ecore.cs (Expression.report118): Renamed to Error118 and made
19743 * statement.cs (Throw.Resolve): Check whether the expression is of
19744 the correct type (CS0118) and whether the type derives from
19745 System.Exception (CS0155).
19746 (Catch.Resolve): New method. Do the type lookup here and check
19747 whether it derives from System.Exception (CS0155).
19748 (Catch.CatchType, Catch.IsGeneral): New public properties.
19750 * typemanager.cs (TypeManager.exception_type): Added.
19752 2002-07-31 Miguel de Icaza <miguel@ximian.com>
19754 * driver.cs: Updated About function.
19756 2002-07-31 Martin Baulig <martin@gnome.org>
19758 Implemented Control Flow Analysis.
19760 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
19761 (EmitContext.CurrentBranching): Added.
19762 (EmitContext.StartFlowBranching): Added.
19763 (EmitContext.EndFlowBranching): Added.
19764 (EmitContext.KillFlowBranching): Added.
19765 (EmitContext.IsVariableAssigned): Added.
19766 (EmitContext.SetVariableAssigned): Added.
19767 (EmitContext.IsParameterAssigned): Added.
19768 (EmitContext.SetParameterAssigned): Added.
19769 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
19770 Added control flow analysis stuff here.
19772 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
19773 resolve the expression as lvalue.
19774 (LocalVariableReference.DoResolve): Check whether the variable has
19775 already been assigned.
19776 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
19777 the parameter as assigned here.
19778 (ParameterReference.DoResolve): Check whether the parameter has already
19780 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
19781 expression as lvalue.
19783 * statement.cs (FlowBranching): New class for the flow analysis code.
19784 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
19785 (LabeledStatement.IsDefined): New public property.
19786 (LabeledStatement.AddUsageVector): New public method to tell flow
19787 analyis that the label may be reached via a forward jump.
19788 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
19790 (VariableInfo.Number): New public field. This is used by flow analysis
19791 to number all locals of a block.
19792 (Block.CountVariables): New public property. This is the number of
19793 local variables in this block (including the locals from all parent
19795 (Block.EmitMeta): Number all the variables.
19797 * statement.cs: Added flow analysis support to all classes.
19799 2002-07-31 Martin Baulig <martin@gnome.org>
19801 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
19802 To get debugging messages, compile mcs with /define:MCS_DEBUG and
19803 then use this argument.
19805 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
19807 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
19808 use this to specify /define options.
19810 2002-07-29 Martin Baulig <martin@gnome.org>
19812 * statement.cs (Fixed): Moved all code that does variable lookups
19813 and resolvings from Emit to Resolve.
19815 * statement.cs (For): Moved all code that does variable lookups
19816 and resolvings from Emit to Resolve.
19818 * statement.cs (Using): Moved all code that does variable lookups
19819 and resolvings from Emit to Resolve.
19821 2002-07-29 Martin Baulig <martin@gnome.org>
19823 * attribute.cs (Attribute.Resolve): Explicitly catch a
19824 System.NullReferenceException when creating the
19825 CustromAttributeBuilder and report a different warning message.
19827 2002-07-29 Martin Baulig <martin@gnome.org>
19829 * support.cs (ParameterData.ParameterName): Added method to
19830 get the name of a parameter.
19832 * typemanager.cs (TypeManager.IsValueType): New public method.
19834 2002-07-29 Martin Baulig <martin@gnome.org>
19836 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
19837 is a flag which specifies that it's either ref or out.
19838 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
19839 the out parameter to `out Parameter.Modifier mod', also set the
19840 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
19842 * support.cs (InternalParameters.ParameterModifier): Distinguish
19843 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19844 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19846 * expression.cs (Argument.GetParameterModifier): Distinguish
19847 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19848 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19850 2002-07-29 Martin Baulig <martin@gnome.org>
19852 * expression.cs (ParameterReference.ParameterReference): Added
19853 `Location loc' argument to the constructor.
19855 * cs-parser.jay: Pass location to ParameterReference.
19857 2002-07-28 Miguel de Icaza <miguel@ximian.com>
19859 * statement.cs (Try): Initialize the location.
19861 * cs-parser.jay: pass location to Try.
19863 * expression.cs (Unary.Reduce): Change the prototype to return
19864 whether a constant fold could be performed or not. The result is
19865 returned in an out parameters. In the case of Indirection and
19866 AddressOf, we want to perform the full tests.
19868 2002-07-26 Miguel de Icaza <miguel@ximian.com>
19870 * statement.cs (Statement.Emit): Flag dead code.
19872 2002-07-27 Andrew Birkett <andy@nobugs.org>
19874 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
19876 2002-07-27 Martin Baulig <martin@gnome.org>
19878 * class.cs (MethodData.Define): Put back call to
19879 TypeManager.AddMethod(), accidentally commented this out.
19881 * report.cs (Debug): New public method to print debugging information,
19882 this is `[Conditional ("DEBUG")]'.
19884 2002-07-26 Martin Baulig <martin@gnome.org>
19886 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
19887 (switch_statement): Push the current_block to the switch_stack and
19888 pop it again when we're done with the switch.
19889 (switch_section): The new block is a child of the current_block.
19890 Fixes bug #24007, added test-152.cs.
19892 2002-07-27 Martin Baulig <martin@gnome.org>
19894 * expression.cs (Invocation.EmitArguments): When calling a varargs
19895 function with only its fixed arguments, we need to pass an empty
19898 2002-07-27 Martin Baulig <martin@gnome.org>
19900 Mono 0.13 has been released.
19902 2002-07-25 Miguel de Icaza <miguel@ximian.com>
19904 * driver.cs: Rename --resource to --linkres, because that is what
19905 we do currently, we dont support --resource yet.
19907 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
19909 2002-07-25 Martin Baulig <martin@gnome.org>
19911 * class.cs (MethodData): New public class. This is a `method builder'
19912 class for a method or one accessor of a Property/Indexer/Event.
19913 (MethodData.GetMethodFlags): Moved here from MemberBase.
19914 (MethodData.ApplyAttributes): Likewise.
19915 (MethodData.ApplyObsoleteAttribute): Likewise.
19916 (MethodData.ApplyConditionalAttribute): Likewise.
19917 (MethodData.ApplyDllImportAttribute): Likewise.
19918 (MethodData.CheckAbstractAndExternal): Likewise.
19919 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
19920 (MethodData.Emit): Formerly known as Method.Emit().
19921 (MemberBase): Moved everything which was specific to a single
19922 accessor/method to MethodData.
19923 (Method): Create a new MethodData and call Define() and Emit() on it.
19924 (Property, Indexer, Event): Create a new MethodData objects for each
19925 accessor and call Define() and Emit() on them.
19927 2002-07-25 Martin Baulig <martin@gnome.org>
19929 Made MethodCore derive from MemberBase to reuse the code from there.
19930 MemberBase now also checks for attributes.
19932 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
19933 (MemberBase.GetMethodFlags): Moved here from class Method and marked
19935 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
19936 `CallingConventions cc' and `Attributes opt_attrs' arguments.
19937 (MemberBase.ApplyAttributes): New virtual method; applies the
19938 attributes to a method or accessor.
19939 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
19940 (MemberBase.ApplyConditionalAttribute): Likewise.
19941 (MemberBase.ApplyDllImportAttribute): Likewise.
19942 (MemberBase.CheckAbstractAndExternal): Likewise.
19943 (MethodCore.ParameterTypes): This is now a property instead of a
19944 method, it's initialized from DoDefineParameters().
19945 (MethodCore.ParameterInfo): Removed the set accessor.
19946 (MethodCore.DoDefineParameters): New protected virtual method to
19947 initialize ParameterTypes and ParameterInfo.
19948 (Method.GetReturnType): We can now simply return the MemberType.
19949 (Method.GetMethodFlags): Override the MemberBase version and add
19950 the conditional flags.
19951 (Method.CheckBase): Moved some code from Define() here, call
19952 DoDefineParameters() here.
19953 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
19954 here to avoid some larger code duplication.
19955 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
19956 ensure that abstract and external accessors don't declare a body.
19958 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
19959 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
19960 lookup in the attribute's parent classes, so we need to abort as soon
19961 as we found the first match.
19962 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
19963 the attribute has no arguments.
19965 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
19968 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19970 * cs-parser.jay: reverted previous patch.
19972 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19974 * cs-parser.jay: fixed bug #22119.
19976 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19978 * attribute.cs: fixed compilation. The error was:
19979 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
19980 be assigned to before control leaves the current method."
19981 [FIXME: Filed as bug #28186: MCS must report this error.]
19983 2002-07-25 Martin Baulig <martin@gnome.org>
19985 * attribute.cs (Attribute.Conditional_GetConditionName): New static
19986 method to pull the condition name ouf of a Conditional attribute.
19987 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
19988 the obsolete message and error flag out of an Obsolete attribute.
19990 * class.cs (Method.GetMethodFlags): New public method to get the
19991 TypeManager.MethodFlags for this method.
19992 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
19994 (Method.Define): Get and apply the Obsolete and Conditional attributes;
19995 if we're overriding a virtual function, set the new private variable
19996 `parent_method'; call the new TypeManager.AddMethod().
19998 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
19999 the MethodBuilder and the Method in a PtrHashtable.
20000 (TypeManager.builder_to_method): Added for this purpose.
20001 (TypeManager.MethodFlags): Added IsObsoleteError.
20002 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
20003 Obsolete and Conditional arguments in MethodBuilders. If we discover
20004 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
20005 the message from the attribute.
20007 2002-07-24 Martin Baulig <martin@gnome.org>
20009 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
20010 preprocessor directives, ensure that the argument to #define/#undef is
20011 exactly one identifier and that it's actually an identifier.
20013 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
20016 2002-07-24 Martin Baulig <martin@gnome.org>
20018 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
20019 initialize it to TypeManager.object_type in the constructor.
20020 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
20021 of the `hm.get_current' method if we're using the collection pattern.
20022 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
20023 for the explicit conversion to make it work when we're using the collection
20024 pattern and the `Current' property has a different return type than `object'.
20027 2002-07-24 Martin Baulig <martin@gnome.org>
20029 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
20030 does not match, but don't report any errors. This method is called in
20031 order for all methods in a MethodGroupExpr until a matching method is
20032 found, so we don't want to bail out if the first method doesn't match.
20033 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
20034 matches, report the 123. Fixes #28070.
20036 2002-07-24 Martin Baulig <martin@gnome.org>
20038 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
20039 TypeManager.TypeToCoreType() to the top of the method so the
20040 following equality checks will work. Fixes #28107.
20042 2002-07-24 Martin Baulig <martin@gnome.org>
20044 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
20045 operand is of type uint, and the other operand is of type sbyte,
20046 short or int, the operands are converted to type long." -
20047 Actually do what this comment already told us. Fixes bug #28106,
20050 2002-07-24 Martin Baulig <martin@gnome.org>
20052 * class.cs (MethodBase): New abstract class. This is now a base
20053 class for Property, Indexer and Event to avoid some code duplication
20054 in their Define() and DefineMethods() methods.
20055 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
20056 generic methods for Define() and DefineMethods().
20057 (FieldBase): Derive from MemberBase, not MemberCore.
20058 (Property): Derive from MemberBase, not MemberCore.
20059 (Property.DefineMethod): Moved all the code from this method to the
20060 new MethodBase.DefineAccessor(), just call it with appropriate
20062 (Property.Define): Call the new Property.DoDefine(), this does some
20063 sanity checks and we don't need to duplicate the code everywhere.
20064 (Event): Derive from MemberBase, not MemberCore.
20065 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
20066 accessors, this will also make them work with interface events.
20067 (Indexer): Derive from MemberBase, not MemberCore.
20068 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
20069 (Indexer.Define): Use the new MethodBase functions.
20071 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
20072 argument to the constructor.
20073 (Interface.FindMembers): Added support for interface events.
20074 (Interface.PopluateEvent): Implemented.
20076 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
20078 2002-07-22 Miguel de Icaza <miguel@ximian.com>
20080 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
20081 but this is required to check for a method name being the same as
20082 the containing class.
20086 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20088 * interface.cs: initialize variable.
20090 2002-07-23 Martin Baulig <martin@gnome.org>
20092 Implemented the IndexerName attribute in interfaces.
20094 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
20095 name if this is an explicit interface implementation.
20096 (Indexer.InterfaceIndexerName): New public variable. If we're
20097 implementing an interface indexer, this is the IndexerName in that
20098 interface. Otherwise, it's the IndexerName.
20099 (Indexer.DefineMethod): If we're implementing interface indexer,
20100 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
20101 and Pending.ImplementIndexer methods.
20102 (Indexer.Define): Also define the PropertyBuilder if we're
20103 implementing an interface indexer and this is neither an explicit
20104 interface implementation nor do the IndexerName match the one in
20107 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
20108 If a method is defined here, then we always need to create a proxy
20109 for it. This is used when implementing interface indexers.
20110 (Pending.IsInterfaceIndexer): New public method.
20111 (Pending.ImplementIndexer): New public method.
20112 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
20113 This is used when implementing interface indexers to define a proxy
20115 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
20116 define a proxy if necessary.
20118 * interface.cs (Interface.IndexerName): New public variable.
20119 (Interface.PopulateIndexer): Set the IndexerName.
20120 (Interface.DefineIndexers): New private method. Populate all the
20121 indexers and make sure their IndexerNames match.
20123 * typemanager.cs (IndexerPropertyName): Added support for interface
20126 2002-07-22 Martin Baulig <martin@gnome.org>
20128 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
20129 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
20130 ret if HasReturnLabel.
20131 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
20134 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
20135 and set the ec.LoopBeginTryCatchLevel.
20136 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
20137 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
20138 the current ec.TryCatchLevel, the branch goes out of an exception
20139 block. In this case, we need to use Leave and not Br.
20141 2002-07-22 Martin Baulig <martin@gnome.org>
20143 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
20144 block unless the block does not always return or it is contained in
20145 another try { ... } catch { ... } block. Fixes bug #26506.
20146 Added verify-1.cs to the test suite.
20148 2002-07-22 Martin Baulig <martin@gnome.org>
20150 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
20151 then we do not always return. Fixes bug #24985.
20153 2002-07-22 Martin Baulig <martin@gnome.org>
20155 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
20156 lookup on a per-class level; ie. walk up the class hierarchy until we
20157 found at least one applicable method, then choose the best among them.
20158 Fixes bug #24463 and test-29.cs.
20160 2002-07-22 Martin Baulig <martin@gnome.org>
20162 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
20163 return types of the methods. The return type is not part of the
20164 signature and we must not check it to make the `new' modifier work.
20165 Fixes bug #27999, also added test-147.cs.
20166 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
20168 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
20169 on the method's return type.
20171 2002-07-21 Martin Baulig <martin@gnome.org>
20173 * assign.cs: Make this work if the rightmost source is a constant and
20174 we need to do an implicit type conversion. Also adding a few more tests
20175 to test-38.cs which should have caught this.
20177 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
20178 target in the makefile for this. The makefile.gnu is primarily intended
20179 for end-users who don't want to debug the compiler.
20181 2002-07-21 Martin Baulig <martin@gnome.org>
20183 * assign.cs: Improved the Assign class so it can now handle embedded
20184 assignments (X = Y = Z = something). As a side-effect this'll now also
20185 consume less local variables. test-38.cs now passes with MCS, added
20186 a few new test cases to that test.
20188 2002-07-20 Martin Baulig <martin@gnome.org>
20190 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
20191 instructions. Fixes bug #27977, also added test-146.cs.
20193 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20195 * cs-tokenizer.cs: fixed getHex ().
20197 2002-07-19 Martin Baulig <martin@gnome.org>
20199 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
20200 not Type.GetType() to lookup the array type. This is needed when
20201 we're constructing an array of a user-defined type.
20202 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
20203 single-dimensional arrays, but also for single-dimensial arrays of
20206 2002-07-19 Martin Baulig <martin@gnome.org>
20208 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
20209 this function is called, it's not allowed to share LocalBuilders
20210 among ILGenerators.
20212 2002-07-19 Martin Baulig <martin@gnome.org>
20214 * expression.cs (Argument.Resolve): Report an error 118 when trying
20215 to pass a type as argument.
20217 2002-07-18 Martin Baulig <martin@gnome.org>
20219 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
20220 Conv_R_Un for the signed `long' type.
20222 2002-07-15 Miguel de Icaza <miguel@ximian.com>
20224 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
20225 `expr' for the temporary result, as that will fail if we do
20226 multiple resolves on the same expression.
20228 2002-07-05 Miguel de Icaza <miguel@ximian.com>
20230 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
20231 ec.TypeContainer for looking up aliases.
20233 * class.cs (TypeContainer): Remove LookupAlias from here.
20235 * decl.cs (DeclSpace); Move here.
20237 2002-07-01 Miguel de Icaza <miguel@ximian.com>
20239 * class.cs (FindMembers): Only call filter if the constructor
20240 bulider is not null.
20242 Also handle delegates in `NestedTypes' now. Now we will perform
20243 type lookups using the standard resolution process. This also
20246 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
20247 This uses Expressions (the limited kind that can be parsed by the
20248 tree) instead of strings.
20250 * expression.cs (ComposedCast.ToString): Implement, used to flag
20251 errors since now we have to render expressions.
20253 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
20256 * ecore.cs (SimpleName.ToString): ditto.
20258 * cs-parser.jay: Instead of using strings to assemble types, use
20259 Expressions to assemble the type (using SimpleName, ComposedCast,
20260 MemberAccess). This should fix the type lookups in declarations,
20261 because we were using a different code path for this.
20263 * statement.cs (Block.Resolve): Continue processing statements
20264 even when there is an error.
20266 2002-07-17 Miguel de Icaza <miguel@ximian.com>
20268 * class.cs (Event.Define): Also remove the `remove' method from
20269 the list of pending items.
20271 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
20272 generate more compact code.
20274 2002-07-17 Martin Baulig <martin@gnome.org>
20276 * const.cs (Const.LookupConstantValue): Add support for constant
20277 `unchecked' and `checked' expressions.
20278 Also adding test case test-140.cs for this.
20280 2002-07-17 Martin Baulig <martin@gnome.org>
20282 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
20283 check whether mi.ReturnType implements the IEnumerator interface; the
20284 `==' and the IsAssignableFrom() will fail in this situation.
20286 2002-07-16 Ravi Pratap <ravi@ximian.com>
20288 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
20291 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20293 * expression.cs: fixed bug #27811.
20295 2002-07-14 Miguel de Icaza <miguel@ximian.com>
20297 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
20298 Molaro: when we are a ref, the value already contains a pointer
20299 value, do not take the address of it.
20301 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20302 * removed mb-parser.jay and mb-tokenizer.cs
20304 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
20306 * expression.cs: check against the building corlib void type.
20308 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
20310 * ecore.cs: fix for valuetype static readonly fields: when
20311 initializing them, we need their address, not the address of a copy.
20313 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
20315 * typemanager.cs: register also enum_type in corlib.
20317 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
20319 * class.cs: allow calling this (but not base) initializers in structs.
20321 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
20323 * ecore.cs: make sure we compare against the building base types
20326 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
20328 * typemanager.cs: fix TypeToCoreType() to handle void and object
20329 (corlib gets no more typerefs after this change).
20331 2002-07-12 Miguel de Icaza <miguel@ximian.com>
20333 * expression.cs (ArrayCreation.EmitArrayArguments): use
20334 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
20336 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
20337 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
20338 array indexes, the runtime actually forbids them.
20340 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
20341 for array arguments here.
20343 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
20344 instead of the default for ValueTypes.
20346 (New.DoEmit): Use IsValueType instead of
20347 IsSubclassOf (value_type)
20348 (New.DoResolve): ditto.
20349 (Invocation.EmitCall): ditto.
20351 * assign.cs (Assign): ditto.
20353 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
20354 Statements *are* currently doing part of their resolution during
20357 Expressions do always resolve during resolve, but statements are
20358 only required to propagate resolution to their children.
20360 2002-07-11 Miguel de Icaza <miguel@ximian.com>
20362 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
20364 (LoadAssembly): Do not add the dll if it is already specified
20366 (MainDriver): Add the System directory to the link path at the end,
20367 after all the other -L arguments.
20369 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
20370 wrong opcode for loading bytes and bools (ldelem.i1 instead of
20371 ldelem.u1) and using the opposite for sbytes.
20373 This fixes Digger, and we can finally run it.
20375 * driver.cs (UnixParseOption): Move the option parsing here.
20376 (CSCParseOption): Implement CSC-like parsing of options.
20378 We now support both modes of operation, the old Unix way, and the
20379 new CSC-like way. This should help those who wanted to make cross
20380 platform makefiles.
20382 The only thing broken is that /r:, /reference: and /lib: are not
20383 implemented, because I want to make those have the same semantics
20384 as the CSC compiler has, and kill once and for all the confussion
20385 around this. Will be doing this tomorrow.
20387 * statement.cs (Unsafe.Resolve): The state is checked during
20388 resolve, not emit, so we have to set the flags for IsUnsfe here.
20390 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20392 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
20393 not catch the Error_ObjectRefRequired in SimpleName (as it is
20394 possible to have a class/instance variable name that later gets
20395 deambiguated), we have to check this here.
20397 2002-07-10 Ravi Pratap <ravi@ximian.com>
20399 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
20400 make static and put into Expression.
20402 (Event.Define): Register the private field of the event with the
20403 TypeManager so that GetFieldFromEvent can get at it.
20405 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
20406 keep track of the private field associated with an event which
20409 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
20412 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
20414 2002-07-10 Miguel de Icaza <miguel@ximian.com>
20416 * expression.cs (Binary.EmitBranchable): this routine emits the
20417 Binary expression in a branchable context. This basically means:
20418 we need to branch somewhere, not just get the value on the stack.
20420 This works together with Statement.EmitBoolExpression.
20422 * statement.cs (Statement.EmitBoolExpression): Use
20425 2002-07-09 Miguel de Icaza <miguel@ximian.com>
20427 * statement.cs (For): Reduce the number of jumps in loops.
20429 (For): Implement loop inversion for the For statement.
20431 (Break): We can be breaking out of a Try/Catch controlled section
20432 (foreach might have an implicit try/catch clause), so we need to
20433 use Leave instead of Br.
20435 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
20436 now). If the instace expression supports IMemoryLocation, we use
20437 the AddressOf method from the IMemoryLocation to extract the
20438 address instead of emitting the instance.
20440 This showed up with `This', as we were emitting the instance
20441 always (Emit) instead of the Address of This. Particularly
20442 interesting when This is a value type, as we dont want the Emit
20443 effect (which was to load the object).
20445 2002-07-08 Miguel de Icaza <miguel@ximian.com>
20447 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
20449 * statement.cs (Checked): Set the CheckedState during the resolve
20450 process too, as the ConvCast operations track the checked state on
20451 the resolve process, and not emit.
20453 * cs-parser.jay (namespace_member_declaration): Flag that we have
20454 found a declaration when we do. This is used to flag error 1529
20456 * driver.cs: Report ok when we display the help only.
20458 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
20460 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
20462 2002-07-04 Miguel de Icaza <miguel@ximian.com>
20464 * cs-tokenizer.cs (define): We also have to track locally the
20465 defines. AllDefines is just used for the Conditional Attribute,
20466 but we also need the local defines for the current source code.
20468 2002-07-03 Miguel de Icaza <miguel@ximian.com>
20470 * statement.cs (While, For, Do): These loops can exit through a
20471 Break statement, use this information to tell whether the
20472 statement is the last piece of code.
20474 (Break): Flag that we break.
20476 * codegen.cs (EmitContexts): New `Breaks' state variable.
20478 2002-07-03 Martin Baulig <martin@gnome.org>
20480 * class.cs (TypeContainer.MethodModifiersValid): Allow override
20481 modifiers in method declarations in structs. Otherwise, you won't
20482 be able to override things like Object.Equals().
20484 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20486 * class.cs (Method, Property, Indexer): Do not allow the public
20487 modifier to be used in explicit interface implementations.
20489 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
20490 override modifiers in method declarations in structs
20492 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
20494 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
20495 integer or real overflow, report an error
20497 2002-07-02 Martin Baulig <martin@gnome.org>
20499 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
20500 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
20501 to tell the runtime about our newly created System.Object and
20502 System.ValueType types.
20504 2002-07-02 Miguel de Icaza <miguel@ximian.com>
20506 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
20507 struct instead of Ldarg/Starg.
20509 2002-07-02 Martin Baulig <martin@gnome.org>
20511 * expression.cs (Indirection.Indirection): Call
20512 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
20514 2002-07-02 Martin Baulig <martin@gnome.org>
20516 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
20517 ValueType, call TypeManager.TypeToCoreType() on it.
20518 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
20519 the OpCodes.Newarr argument.
20521 2002-07-02 Martin Baulig <martin@gnome.org>
20523 * expression.cs (Invocation.EmitCall): When compiling corlib,
20524 replace all calls to the system's System.Array type to calls to
20525 the newly created one.
20527 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
20528 System.Array methods.
20529 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
20530 from the system's System.Array type which must be replaced.
20532 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
20534 * typemanager.cs: load unverifiable_code_ctor so we can build
20535 corlib using the correct type. Avoid using GetTypeCode() with
20537 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
20538 TypeManager.object_type to allow building corlib.
20540 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
20542 * ecore.cs: handle System.Enum separately in LoadFromPtr().
20544 2002-07-01 Martin Baulig <martin@gnome.org>
20546 * class.cs: Make the last change actually work, we need to check
20547 whether `ifaces != null' to avoid a crash.
20549 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
20551 * class.cs: when we build structs without fields that implement
20552 interfaces, we need to add the interfaces separately, since there is
20553 no API to both set the size and add the interfaces at type creation
20556 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
20558 * expression.cs: the dimension arguments to the array constructors
20559 need to be converted if they are a long.
20561 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
20563 * class.cs: don't emit ldarg.0 if there is no parent constructor
20564 (fixes showstopper for corlib).
20566 2002-06-29 Martin Baulig <martin@gnome.org>
20568 MCS now compiles corlib on GNU/Linux :-)
20570 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
20571 ie. check for MethodImplOptions.InternalCall.
20573 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
20574 and TypeManager.attribute_type are null, so we must explicitly check
20575 whether parent is not null to find out whether it's an attribute type.
20576 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
20577 and SetBuilder, not only if the property is neither abstract nor external.
20578 This is necessary to set the MethodImplOptions on the accessor methods.
20579 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
20580 SetBuilder, see Property.Emit().
20582 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
20583 populate "System.Object", "System.ValueType" and "System.Attribute" since
20584 they've already been populated from BootCorlib_PopulateCoreTypes().
20586 2002-06-29 Martin Baulig <martin@gnome.org>
20588 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
20589 is the NullLiteral, we also need to make sure that target_type is not
20592 2002-06-29 Martin Baulig <martin@gnome.org>
20594 * rootcontext.cs (RootContext.ResolveCore): We must initialize
20595 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
20596 before calling BootstrapCorlib_ResolveDelegate ().
20598 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20600 * statement.cs: fixed build-breaker. All tests passed ok.
20602 2002-06-27 Martin Baulig <martin@gnome.org>
20604 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
20605 for System.Decimal when compiling corlib.
20607 2002-06-27 Martin Baulig <martin@gnome.org>
20609 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
20610 switch blocks which contain nothing but a default clause.
20612 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
20614 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
20616 2002-06-27 Martin Baulig <martin@gnome.org>
20618 * ecore.cs (PropertyExpr.PropertyExpr): Call
20619 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
20621 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
20622 is already a TypeBuilder.
20624 2002-06-27 Martin Baulig <martin@gnome.org>
20626 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
20627 `target_type == TypeManager.array_type', not IsAssignableFrom() in
20628 the "from an array-type to System.Array" case. This makes it work
20629 when compiling corlib.
20631 2002-06-27 Martin Baulig <martin@gnome.org>
20633 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
20634 non-static PropertyExpr, set its InstanceExpression. This makes
20635 the `ICollection.Count' property work in System/Array.cs.
20637 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
20639 * driver.cs: Made error handling more consistent. Errors now
20640 tracked by Report class, so many methods which used to return int
20641 now return void. Main() now prints success/failure and
20642 errors/warnings message.
20644 Renamed '--probe' compiler argument to '--expect-error'. Removed
20645 the magic number return values (123 and 124). Now, if the
20646 expected error occurs, the compiler exits with success (exit value
20647 0). If the compilation completes without seeing that particular
20648 error, the compiler exits with failure (exit value 1). The
20649 makefile in mcs/errors has been changed to handle the new behaviour.
20651 * report.cs: Made 'expected error' number a property and renamed
20652 it from 'Probe' to 'ExpectedError'.
20654 * genericparser.cs: Removed error handling support, since it is
20655 now all done by Report class.
20657 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
20658 class, so parse() no longer returns an int.
20660 * namespace.cs: Use Report.Error instead of GenericParser.error
20662 2002-06-22 Miguel de Icaza <miguel@ximian.com>
20664 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
20665 TypeContainer.AddOperator): At the front of the list put the
20666 explicit implementations, so they get resolved/defined first.
20668 2002-06-21 Miguel de Icaza <miguel@ximian.com>
20670 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
20671 interface type is implemented by this TypeContainer. Used during
20672 explicit interface implementation.
20674 (Property.Define, Indexer.Define, Method.Define): Validate that
20675 the given interface in the explicit implementation is one of the
20676 base classes for the containing type.
20678 Also if we are explicitly implementing an interface, but there is
20679 no match in the pending implementation table, report an error.
20681 (Property.Define): Only define the property if we are
20682 not explicitly implementing a property from an interface. Use the
20683 correct name also for those properties (the same CSC uses,
20684 although that is really not needed).
20686 (Property.Emit): Do not emit attributes for explicitly implemented
20687 properties, as there is no TypeBuilder.
20689 (Indexer.Emit): ditto.
20691 Hiding then means that we do not really *implement* a pending
20692 implementation, which makes code fail.
20694 2002-06-22 Martin Baulig <martin@gnome.org>
20696 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
20697 the return value of Object.GetType(). [FIXME: we need to do this whenever
20698 we get a type back from the reflection library].
20700 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
20702 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
20704 2002-06-20 Miguel de Icaza <miguel@ximian.com>
20706 * attribute.cs: Return null if we can not look up the type.
20708 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
20709 the interface types found.
20711 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
20712 interface types found.
20714 * typemanager.cs (GetInterfaces): Make this routine returns alll
20715 the interfaces and work around the lame differences between
20716 System.Type and System.Reflection.Emit.TypeBuilder in the results
20717 result for GetInterfaces.
20719 (ExpandInterfaces): Given an array of interface types, expand and
20720 eliminate repeated ocurrences of an interface. This expands in
20721 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
20724 2002-06-21 Martin Baulig <martin@gnome.org>
20726 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
20729 2002-06-21 Martin Baulig <martin@gnome.org>
20731 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
20732 and called with one of the core types, return the corresponding typebuilder for
20735 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
20738 2002-06-21 Martin Baulig <martin@gnome.org>
20740 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
20741 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
20742 (Expression.ConvertReferenceExplicit): Likewise.
20744 * expression.cs (ElementAccess.DoResolve): Likewise.
20745 (ElementAccess.DoResolveLValue): Likewise.
20747 2002-06-10 Martin Baulig <martin@gnome.org>
20749 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
20750 add the "value" parameter to the parameter list.
20752 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
20755 2002-06-19 Miguel de Icaza <miguel@ximian.com>
20757 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
20758 the argument to an int, uint, long or ulong, per the spec. Also
20759 catch negative constants in array creation.
20761 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
20763 * class.cs: do not allow the same interface to appear twice in
20764 the definition list.
20766 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
20768 * ecore.cs: don't use ldlen with System.Array.
20770 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
20772 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
20774 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
20776 * modifiers.cs: produce correct field attributes for protected
20777 internal. Easy fix so miguel can work on ther harder stuff:-)
20779 2002-06-18 Miguel de Icaza <miguel@ximian.com>
20781 * pending.cs: New file. Move the code from class.cs here.
20782 Support clearning the pending flag for all methods (when not doing
20783 explicit interface implementation).
20785 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
20787 * rootcontext.cs: added a couple more types needed to bootstrap.
20789 2002-06-17 Miguel de Icaza <miguel@ximian.com>
20791 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
20792 constructor in the type, instead of any constructor in the type
20793 hierarchy. Thanks to Paolo for finding this bug (it showed up as
20794 a bug in the Mono runtime when applying the params attribute).
20796 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20797 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
20799 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
20801 * expression.cs (Unary.ResolveOperator): Use TypeManager
20802 to resolve the type.
20804 2002-06-13 Ravi Pratap <ravi@ximian.com>
20806 * cs-parser.jay (enum_member_declaration): Pass in the attributes
20809 * enum.cs (AddEnumMember): Add support to store the attributes associated
20810 with each member too.
20812 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
20813 field builders too - this takes care of the enum member case.
20815 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
20817 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
20818 address-of operator on both value types and pointers.
20820 2002-06-10 Martin Baulig <martin@gnome.org>
20822 * interface.cs (Interface.PopulateIndexer): Add the indexer's
20823 PropertyBuilder to the `property_builders' list.
20825 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
20826 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
20827 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
20828 find any indexers which are inherited from an interface.
20830 2002-06-09 Martin Baulig <martin@gnome.org>
20832 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
20833 the same type as the constant if necessary. There's also a test-130.cs
20836 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
20838 * typemanager.cs (TypeManager.ChangeType): Previously known as
20839 Enum.ChangeEnumType().
20841 2002-06-09 Martin Baulig <martin@gnome.org>
20843 * expression.cs (Cast.TryReduce): Added support for consts.
20845 2002-06-08 Ravi Pratap <ravi@ximian.com>
20847 * class.cs (Accessor): Hold attributes information so we can pass
20850 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
20851 Modify to pass in attributes attached to the methods.
20853 (add_accessor_declaration, remove_accessor_declaration): Ditto.
20855 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
20856 to handle the Accessor kind :-)
20858 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
20860 2002-06-08 Martin Baulig <martin@gnome.org>
20862 * expression.cs (Unary.TryReduceNegative): Added support for
20865 2002-06-08 Martin Baulig <martin@gnome.org>
20867 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
20868 name can't be found in the `defined_names' - the caller will do a
20869 MemberLookup in this case and thus find methods in System.Enum
20870 such as Enum.IsDefined().
20872 2002-06-08 Martin Baulig <martin@gnome.org>
20874 * enum.cs (Enum.ChangeEnumType): This is a custom version of
20875 Convert.ChangeType() which works with TypeBuilder created types.
20876 (Enum.LookupEnumValue, Enum.Define): Use it here.
20878 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
20879 `TypeBuilder.BaseType != null' check.
20880 (TypeContainer.FindMembers): Only lookup parent members if we
20881 actually have a parent.
20882 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
20883 (ConstructorInitializer.Resolve): Likewise.
20885 * interface.cs (Interface.FindMembers): Added
20886 `TypeBuilder.BaseType != null' check.
20888 * rootcontext.cs (RootContext.ResolveCore): Added
20889 "System.Runtime.CompilerServices.IndexerNameAttribute" to
20890 classes_second_stage.
20892 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
20893 debug_type and trace_type when compiling with --nostdlib.
20895 2002-06-07 Martin Baulig <martin@gnome.org>
20897 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
20898 (AddField): Set it to true when adding a non-static field.
20899 (DefineType): Use `have_nonstatic_fields' to find out whether we
20900 have non-static fields, not `Fields != null'.
20902 2002-06-02 Miguel de Icaza <miguel@ximian.com>
20904 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
20905 dereferencing a null on the static-field code path)
20907 2002-05-30 Martin Baulig <martin@gnome.org>
20909 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
20910 to take command line arguments. Use reflection to call the new
20911 custom `Initialize' function on the symbol writer and pass it the
20912 command line arguments.
20914 * driver.cs (--debug-args): New command line argument to pass command
20915 line arguments to the symbol writer.
20917 2002-05-28 Miguel de Icaza <miguel@ximian.com>
20919 * assign.cs (DoResolve): Forgot to do the implicit conversion to
20920 the target type for indexers and properties. Thanks to Joe for
20923 2002-05-27 Miguel de Icaza <miguel@ximian.com>
20925 * typemanager.cs (MethodFlags): returns the method flags
20926 (Obsolete/ShouldIgnore) that control warning emission and whether
20927 the invocation should be made, or ignored.
20929 * expression.cs (Invocation.Emit): Remove previous hack, we should
20930 not do this on matching a base type, we should do this based on an attribute
20932 Only emit calls to System.Diagnostics.Debug and
20933 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
20934 on the command line.
20936 * rootcontext.cs: Global settings for tracing and debugging.
20938 * cs-tokenizer.cs (define): New utility function to track
20939 defines. Set the global settings for TRACE and DEBUG if found.
20941 2002-05-25 Ravi Pratap <ravi@ximian.com>
20943 * interface.cs (Populate*): Pass in the TypeContainer as well as
20944 the DeclSpace as parameters so that we can create EmitContexts and
20945 then use that to apply attributes etc.
20947 (PopulateMethod, PopulateEvent, PopulateProperty)
20948 (PopulateIndexer): Apply attributes everywhere.
20950 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
20953 (ApplyAttributes): Update accordingly.
20955 We now apply interface attributes for all members too.
20957 2002-05-26 Miguel de Icaza <miguel@ximian.com>
20959 * class.cs (Indexer.Define); Correctly check if we are explicit
20960 implementation (instead of checking the Name for a ".", we
20961 directly look up if the InterfaceType was specified).
20963 Delay the creation of the PropertyBuilder.
20965 Only create the PropertyBuilder if we are not an explicit
20966 interface implementation. This means that explicit interface
20967 implementation members do not participate in regular function
20968 lookups, and hence fixes another major ambiguity problem in
20969 overload resolution (that was the visible effect).
20971 (DefineMethod): Return whether we are doing an interface
20974 * typemanager.cs: Temporary hack until we get attributes in
20975 interfaces (Ravi is working on that) and we get IndexerName
20976 support in interfaces.
20978 * interface.cs: Register the indexers as properties.
20980 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
20981 warning, I have verified that this is a bug in the .NET runtime
20982 (JavaScript suffers of the same problem).
20984 * typemanager.cs (MemberLookup): When looking up members for
20985 interfaces, the parent of an interface is the implicit
20986 System.Object (so we succeed in searches of Object methods in an
20987 interface method invocation. Example: IEnumerable x; x.ToString
20990 2002-05-25 Miguel de Icaza <miguel@ximian.com>
20992 * class.cs (Event): Events should also register if they do
20993 implement the methods that an interface requires.
20995 * typemanager.cs (MemberLookup); use the new GetInterfaces
20998 (GetInterfaces): The code used to lookup interfaces for a type is
20999 used in more than one place, factor it here.
21001 * driver.cs: Track the errors at the bottom of the file, we kept
21004 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
21005 instance if the method we are calling is static!
21007 2002-05-24 Miguel de Icaza <miguel@ximian.com>
21009 * attribute.cs (ApplyAttributes): Make this function filter out
21010 the IndexerName attribute (as that attribute in reality is never
21011 applied) and return the string constant for the IndexerName
21014 * class.cs (TypeContainer.Emit): Validate that all the indexers
21015 have the same IndexerName attribute, and if so, set the
21016 DefaultName attribute on the class.
21018 * typemanager.cs: The return value might contain other stuff (not
21019 only methods). For instance, consider a method with an "Item"
21020 property and an Item method.
21022 * class.cs: If there is a problem with the parameter types,
21025 2002-05-24 Ravi Pratap <ravi@ximian.com>
21027 * ecore.cs (ImplicitConversionExists): Wrapper function which also
21028 looks at user defined conversion after making a call to
21029 StandardConversionExists - we need this for overload resolution.
21031 * expression.cs : Update accordingly the various method calls.
21033 This fixes 2 bugs filed against implicit user defined conversions
21035 2002-05-22 Miguel de Icaza <miguel@ximian.com>
21037 * statement.cs: Track the result of the assignment.
21039 2002-05-21 Miguel de Icaza <miguel@ximian.com>
21041 * expression.cs (MemberAccess): Improved error reporting for
21042 inaccessible members.
21044 2002-05-22 Martin Baulig <martin@gnome.org>
21046 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
21047 itself with debugging support.
21049 2002-05-22 Martin Baulig <martin@gnome.org>
21051 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
21052 Removed, this isn't needed anymore.
21054 2002-05-20 Martin Baulig <martin@gnome.org>
21056 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
21057 be underlying type for an enum.
21059 2002-05-20 Miguel de Icaza <miguel@ximian.com>
21061 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
21062 that splits out the loading of just the core types.
21064 * rootcontext.cs (ResolveCore): Split the struct resolution in
21065 two, so we can load the enumeration underlying types before any
21068 * expression.cs (Is): Bandaid until we fix properly Switch (see
21069 bug #24985 for details).
21071 * typemanager.cs (ImplementsInterface): The hashtable will contain
21072 a null if there are no interfaces implemented.
21074 2002-05-18 Miguel de Icaza <miguel@ximian.com>
21076 * cs-parser.jay (indexer_declarator): It is fine to have array
21079 2002-05-17 Miguel de Icaza <miguel@ximian.com>
21081 * typemanager.cs: (RegisterBuilder): New function used to register
21082 TypeBuilders that implement interfaces. Since
21083 TypeBuilder.GetInterfaces (as usual) does not work with lame
21085 (AddUserType): register interfaces.
21087 (ImplementsInterface): Use the builder_to_ifaces hash if we are
21088 dealing with TypeBuilder. Also, arrays are showing up as
21089 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
21090 methods can not be invoked on them!
21092 * ecore.cs (ExplicitReferenceConversionExists): Made public.
21093 (ImplicitReferenceConversionExists): Split out from
21094 StandardConversionExists.
21096 * expression.cs (As): We were only implementing one of the three
21097 cases for the as operator. We now implement them all.
21098 (Is): Implement the various other cases for Is as well.
21100 * typemanager.cs (CACHE): New define used to control if we want or
21101 not the FindMembers cache. Seems to have a negative impact on
21102 performance currently
21104 (MemberLookup): Nested types have full acess to
21105 enclosing type members
21107 Remove code that coped with instance/static returns for events, we
21108 now catch this in RealFindMembers.
21110 (RealFindMembers): only perform static lookup if the instance
21111 lookup did not return a type or an event.
21113 2002-05-17 Miguel de Icaza <miguel@ximian.com>
21115 * assign.cs (CompoundAssign): We pass more semantic information
21116 now to Compound Assignments than we did before: now we have all
21117 the information at hand, and now we resolve the target *before* we
21118 do the expression expansion, which allows the "CacheValue" method
21119 to have the effect we intended (before, a [x] += 1 would generate
21120 two differen ArrayAccess expressions from the ElementAccess,
21121 during the resolution process).
21123 (CompoundAssign.DoResolve): Resolve target and original_source here.
21125 2002-05-16 Miguel de Icaza <miguel@ximian.com>
21127 * expression.cs (ArrayAccess): dropped debugging information.
21129 * typemanager.cs: Small bug fix: I was always returning i_members,
21130 instead of one of i_members or s_members (depending on which had
21133 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
21134 method is invoked before any code generation takes place, and it
21135 is a mechanism to inform that the expression will be invoked more
21136 than once, and that the method should use temporary values to
21137 avoid having side effects
21139 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
21141 * ecore.cs (Expression.CacheTemporaries): Provide empty default
21144 * expression.cs (Indirection, ArrayAccess): Add support for
21145 CacheTemporaries in these two bad boys.
21147 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
21148 ldobj or ldind_ref.
21149 (StoreFromPtr): Handle stobj as well.
21151 * expression.cs (UnaryMutator): Share more code.
21153 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
21154 down: I was not tracking the Filter function as well, which
21155 was affecting the results of the cache.
21157 2002-05-15 Miguel de Icaza <miguel@ximian.com>
21159 * attribute.cs: Remove the hack to handle the CharSet property on
21162 2002-05-14 Miguel de Icaza <miguel@ximian.com>
21164 * attribute.cs (DoResolve): More uglyness, we now only try to
21165 resolve the attribute partially, to extract the CharSet
21166 information (only if we are a StructLayout attribute). Otherwise
21168 (GetExtraTypeInfo): Add some code to conditionally kill in the
21169 future this. I am more and more convinced that the .NET
21170 framework has special code to handle the attribute setting on
21173 * expression.cs (IsParamsMethodApplicable): Revert my previous
21174 foreach change here, it was wrong.
21176 2002-05-13 Miguel de Icaza <miguel@ximian.com>
21178 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
21179 (pp_expr): do not abort on unknown input, just return.
21180 (eval): abort if there are pending chars.
21182 * attribute.cs (Attribute.Resolve): Positional parameters are
21183 optional. Deal with that case.
21185 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
21186 the Ansi/Unicode/Auto information for the type.
21188 (TypeContainer.DefineType): instantiate the EmitContext here, as
21189 we will be using it during the type definition (to resolve
21190 attributes) and during the emit phase.
21192 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
21193 to pull type information out of the attributes
21195 (Attribute.Resolve): track the constructor builder, and allow for
21196 multiple invocations (structs and classes will use this).
21198 * ecore.cs (MemberLookupFinal): new version with all the
21199 parameters customizable.
21201 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
21202 constructors. Return if the result value is null (as the error
21203 would have been flagged already by MemberLookupFinal)
21205 Do not allow instances of abstract classes or interfaces to be
21208 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
21209 We have to compare the assembly property here when dealing with
21210 FamANDAssem and Assembly access modifiers, because we might be
21211 creating an assembly from *modules* (that means that we are not
21212 getting TypeBuilders for types defined in other modules that are
21213 part of this assembly).
21215 (Method.Emit): If the method is marked abstract and has a body,
21218 (TypeContainer.DefineMembers): If both the defined member and the
21219 parent name match are methods, then do not emit any warnings: let
21220 the Method.Define routine take care of flagging warnings. But if
21221 there is a mismatch (method overrides something else, or method is
21222 overriwritten by something, then emit warning).
21224 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
21225 set to null, this means `do not check for the return type on the
21228 (Method.Define): set the return type for the method signature to
21229 null, so that we get methods with the same name and parameters and
21230 different return types. This is used to flag warning 114 (you are
21231 hiding a method, and you probably want to use the new/override
21234 * typemanager.cs (MemberLookup): Implemented proper access
21235 control, closing a long standing set of bug reports. The problem
21236 was that the Framework only has two bits: Public and NonPublic,
21237 and NonPublic includes private and protected methods, but we need
21238 to enforce the FamANDAssem, FamOrAssem and Family.
21240 2002-05-11 Miguel de Icaza <miguel@ximian.com>
21242 * statement.cs (GotoCase): Return true: Ammounts to giving up
21243 knowledge on whether we return or not, and letting the other case
21244 be responsible for it.
21246 2002-05-10 Miguel de Icaza <miguel@ximian.com>
21248 * driver.cs: Do not load directories for each file processed, only
21249 do it if there is a pattern.
21251 * ecore.cs: Report readonly assigns here as well, as we might have
21252 been resolved only by MemberAccess.
21254 (SimpleName.SimpleNameResolve): Also be useful for LValue
21255 resolution. We need this to propagate assign to local readonly variables
21257 * typemanager.cs: Use a ptrhashtable for the criteria, because we
21258 do not want to reuse potential criteria memory.
21260 * class.cs (MyEventBuilder): Set reflected_type;
21262 * ecore.cs (Constantify): Added support for constifying bools.
21264 (RootContext.LookupType): Added a cache for values looked up in
21265 the declaration space.
21267 * typemanager.cs (FindMembers): Now is a front-end to
21268 RealFindMembers, and provides a two-level hashtable-based cache to
21271 15% performance improvement: from 22.5 to 19.2 seconds.
21273 * expression.cs (IsParamsMethodApplicable): use foreach.
21274 (Invocation.DoResolve): ditto.
21275 (New.DoResolve): ditto.
21276 (ArrayCreation.DoResolve): ditto.
21278 * ecore.cs (FindMostEncompassingType): use foreach.
21280 * delegate.cs (NewDelegate.DoResolve): Use foreach
21282 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
21283 (RemoveMethods): use foreach.
21285 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
21286 nested foreach statements instead of for, and also break out of
21287 the inner loop once a match is found.
21289 (Invocation.OverloadResolve): Use foreach, simplify the code.
21291 2002-05-08 Miguel de Icaza <miguel@ximian.com>
21293 * cfold.cs (BinaryFold): During an enumeration evaluation context,
21294 we actually unwrap the expression to allow for extra information
21297 * expression.cs: Use Shr_Un on unsigned operations.
21299 2002-05-08 Ravi Pratap <ravi@ximian.com>
21301 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
21302 applicable operators was not being considered correctly. This closes
21303 the bug Miguel reported.
21305 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
21307 * attribute.cs: check that the type derives from System.Attribute
21308 and report the correct error in that case (moved the duplicate code to
21309 its own method, too).
21311 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
21313 * attribute.cs: lookup attribute type name as the spec says: first the
21314 bare attribute name and then name + "Attribute" (nant compiles with
21315 mcs after this fix).
21317 2002-05-07 Miguel de Icaza <miguel@ximian.com>
21319 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
21320 Because of the way we parse things, we should try to see if a
21321 UIntConstant can fit in an integer.
21323 2002-05-07 Ravi Pratap <ravi@ximian.com>
21325 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
21326 when we are in an explicit context.
21328 (ConvertReferenceExplicit): When converting from Iface type S to Class
21329 T make sure the rules are implemented as an OR.
21331 * parameter.cs (ParameterType): Make it a property for now although the
21332 purpose really isn't anything immediate.
21334 * expression.cs (Is*Applicable): Do better checking on the parameter type
21335 of a ref/out parameter. The ones from the system assemblies are already
21336 marked with the correct type so we don't need to do any correction.
21338 * ecore.cs (StandardConversionExists): Conversion from Interface types to
21339 the object type is standard too so include that.
21341 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21343 * ecore.cs (StandardConversionExists): Augment with missing code:
21344 deal with IntConstant, LongConstants and Enumerations.
21346 * assign.cs: Report the error, instead of failing silently
21348 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
21349 typecontainer that they are declared, because the
21350 typecontainer/namespace will have the list of using clauses that
21351 need to be applied.
21353 Assembly Attributes were escaping the normal registration
21356 (EmitCode): Apply attributes within an EmitContext that represents
21357 the container they were declared on.
21359 * cs-parser.jay: Track bases for structs. How did I get this wrong?
21361 2002-05-06 Ravi Pratap <ravi@ximian.com>
21363 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
21364 Revamp completely - make much cleaner as we now operate only
21367 (FindMostSpecificSource, FindMostSpecificTarget): New methods
21368 to implement the logic detailed in the spec more correctly.
21370 (UserDefinedConversion): Update accordingly.
21372 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21374 * statement.cs: Return flow analysis information up.
21376 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
21379 (token): Do not consume an extra character before calling
21382 2002-05-06 Piers Haken <piersh@friskit.com>
21384 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
21386 2002-05-06 Miguel de Icaza <miguel@ximian.com>
21388 * class.cs (Constructor.Emit): Set the IsStatic flag in the
21389 EmitContext during the instance constructor initializer
21390 resolution, to stop access to instance variables.
21392 This is mandated by the spec, last paragraph of the `constructor
21393 initializers' section.
21395 2002-05-05 Miguel de Icaza <miguel@ximian.com>
21397 * cs-parser.jay, class.cs (Accessor): new class used to represent
21398 an accessor (get or set). In the past we used `null' to represent
21399 a missing accessor. But this is ambiguous because there was no
21400 way to tell in abstract indexers/properties if one of them was
21403 Now there is a way of addressing that.
21405 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
21406 instead of FindMembers.
21408 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
21409 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
21411 * attribute.cs: Treat indexers and properties as the same in terms
21412 of applying attributes
21414 * ecore.cs (FindMostEncompassedType): Use statically initialized
21415 EmptyExpressions()s like we do elsewhere to avoid creating useless
21416 objects (and we take this out of the tight loop).
21418 (GetConversionOperators): Move the code to extract the actual
21419 operators to a separate routine to clean things up.
21421 2002-05-04 Miguel de Icaza <miguel@ximian.com>
21423 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
21424 events are always registered FieldBuilders.
21426 * class.cs (FieldBase): New class shared by Fields
21428 * delegate.cs: If we are a toplevel delegate, use our full name.
21429 If we are a nested delegate, then only use our tail name.
21431 2002-05-02 Ravi Pratap <ravi@ximian.com>
21433 * expression.cs (IsApplicable): Ensure that we add the "&" to
21434 ref/out types before comparing it with the type of the argument.
21436 (IsParamsMethodApplicable): Ditto.
21438 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
21441 * delegate.cs : Handle the case when we have more than one applicable
21442 method. Flag an error only when we finish checking all.
21444 2002-05-02 Miguel de Icaza <miguel@ximian.com>
21446 * expression.cs: Add support for boolean static initializers.
21448 2002-05-01 Miguel de Icaza <miguel@ximian.com>
21450 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
21452 * parameter.cs (ComputeParameterTypes,
21453 ComputeAndDefineParameterTypes): Better error handling: now we
21454 clear the `types' cache if we fail during any of the type lookups.
21455 We also return the status code correctly to our caller
21457 * delegate.cs: If we fail to define a delegate, abort the extra
21460 * expression.cs (Binary.ResolveOperator): for
21461 operator==(object,object) and operator !=(object, object) we also
21462 have to verify that there is an implicit conversion from one to
21465 (ArrayAccess.DoResolve): Array Access can operate on
21468 2002-04-30 Miguel de Icaza <miguel@ximian.com>
21470 * assign.cs (CompoundAssign): A new class used as a "flag" that
21471 the assignment actually is happening as part of a compound
21472 assignment operator.
21474 During compound assignment, a few new rules exist to enable things
21481 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
21482 to the type of x) if y is implicitly convertible to the type of x,
21483 and the operator is a builtin operator and the return type of the
21484 operator is explicitly convertible to the type of x.
21486 * rootcontext.cs: Reset warning level to 2. 4 catches various
21487 "interesting" features in mcs, we must clean this up at some
21488 point, but currently am trying to kill other bugs ;-)
21490 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
21491 in container classes as well.
21493 * expression.cs (Binary.ResolveOperator): Handle string case
21494 before anything else (as operator overloading does emit an error
21495 before doing anything else).
21497 This code could go away when we move to a table driven model, but
21498 i could not come up with a good plan last night.
21500 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
21502 * typemanager.cs (CSharpName): reimplementation using regex.
21503 * class.cs: added null check for fields in Emit
21504 * rootcontext.cs: set warninglevel to 4
21506 2002-04-29 Miguel de Icaza <miguel@ximian.com>
21508 * typemanager.cs (CSharpName): reimplemented with Lupus
21511 2002-04-28 Miguel de Icaza <miguel@ximian.com>
21513 * statement.cs (If): correclty implement Resolve, because we were
21514 not catching sem errors in there. The same process is needed
21516 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
21519 (Statement.Warning_DeadCodeFound): Factorize code.
21520 (While): Report dead code here too.
21522 (Statement): Added Resolve virtual method to allow
21523 for resolution split from the emit code.
21525 2002-04-26 Miguel de Icaza <miguel@ximian.com>
21527 * statement.cs (EmitBoolExpression): No longer try to resolve the
21529 (MakeBoolean): New utility function that resolve, implicitly
21530 converts to boolean and tags the expression.
21533 (If, Do): Implement dead code elimination.
21534 (While): Implement loop inversion
21536 (Do, While, For, If): Resolve the expression prior to calling our
21539 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
21542 - added method Report28 (warning: program has more than one entry point)
21543 - added method IsEntryPoint, implements paragraph 10.1 of the spec
21544 - modified method Method.Define, the part at the end of the method
21546 * rootcontext.cs: added static public Location EntryPointLocation;
21548 * ../errors/cs0028.cs : Add test case for the above warning.
21551 - modified method CSharpName to allow arrays of primitive type to
21552 be printed nicely (e.g. instead of System.Int32[][] it now prints
21554 - added method CSharpSignature: returns the signature of a method
21555 in string format to be used in reporting errors, warnings, etc.
21557 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
21560 2002-04-26 Ravi Pratap <ravi@ximian.com>
21562 * delegate.cs (Define): Fix extremely silly bug where I was
21563 setting the type of the 'object' parameter of the BeginInvoke
21564 method to System.IAsyncResult instead of System.Object ;-)
21566 2002-04-26 Miguel de Icaza <miguel@ximian.com>
21568 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
21571 (Constructor.Emit): return if we fail to initialize the
21572 constructor. Another door closed!
21574 * expression.cs (New.DoResolve): Improve error message (from -6 to
21575 1501). Use DeclaredOnly lookup to find the exact constructor.
21577 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
21578 loop. This is useful.
21580 * cs-parser.jay: Adjust the default parameters so that destructors
21581 have the proper signature.
21583 2002-04-26 Martin Baulig <martin@gnome.org>
21585 * driver.cs (LoadAssembly): If `assembly' contains any characters
21586 which are only valid in path names and not in assembly names
21587 (currently slash, backslash and point), use Assembly.LoadFrom ()
21588 instead of Assembly.Load () on the `assembly' (before iteration
21589 over the link_paths).
21591 2002-04-26 Martin Baulig <martin@gnome.org>
21593 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
21595 2002-04-25 Miguel de Icaza <miguel@ximian.com>
21597 * class.cs (Property): use the new typemanager.MemberLookup
21599 (TypeContainer.MemberLookup): Implement using the
21600 TypeManager.MemberLookup now.
21602 * typemanager.cs: Make MemberLookup a function of the TypeManager,
21603 and return MemberInfos, so that these can be used without an
21604 EmitContext (what we had before).
21606 2002-04-24 Miguel de Icaza <miguel@ximian.com>
21608 * expression.cs: Fix the case where the argument to params if the
21609 type of the params. I omitted handling this before. Fixed
21611 2002-04-22 Miguel de Icaza <miguel@ximian.com>
21613 * driver.cs: Call BootCorlib_PopulateCoreType
21615 * class.cs (Property.CheckBase): Check for properties only, not
21618 * interface.cs: Temporary hack: try/catch around the
21619 CustomAttributeBuilder, because I am getting an exception that I
21622 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
21623 types whose definitions are required to be there (attributes are
21624 defined before standard types).
21626 Compute definitions as we boot the various types, as they are used
21627 immediately (value_type class will need object_type, but if we do
21628 not initialize object_type, we will pass a null, which will let
21629 the runtime pick the System.Object from the existing corlib, which
21630 is not what we want).
21632 2002-04-22 Patrik Torstensson <totte@labs2.com>
21634 * cs-tokenizer.cs: fixed a number of trim() issues.
21636 2002-04-22 Ravi Pratap <ravi@ximian.com>
21638 * expression.cs (Argument.Type): Ensure that we return the correct
21639 type when we have out or ref parameters [in which case we
21642 2002-04-22 Miguel de Icaza <miguel@ximian.com>
21644 * class.cs (Property, Indexer): Allow extern modifier in there.
21646 * typemanager.cs (InitBaseTypes): Initializes object_type and
21647 value_type, since those will be used early on during the bootstrap
21648 process to compile corlib.
21650 (InitCoreTypes): Move code from here to InitBaseTypes.
21652 2002-04-21 Miguel de Icaza <miguel@ximian.com>
21654 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
21655 single-dimension arrays as using the ldlen opcode.
21657 Daniel Lewis discovered this optimization.
21659 * typemanager.cs: Add signature for System.Array::get_Length
21661 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21663 * statement.cs: report the error when the foreach does not apply to an
21664 array nor a collection.
21666 2002-04-19 Miguel de Icaza <miguel@ximian.com>
21668 * expression.cs: Add implicit conversions to the operator ~.
21670 * constant.cs (DecimalConstant.Emit): Emit decimal value.
21672 * typemanager.cs: Locate the decimal constructor.
21674 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21676 * attribute.cs: use the new property of TypeOf.
21677 * expression.cs: added 'get' property around typearg.
21679 These changes fix a build breaker reported by NickD. Is this the
21680 correct way to fix? If not, please, revert my changes and make it
21683 2002-04-17 Miguel de Icaza <miguel@ximian.com>
21685 * attribute.cs: Add support for typeof in attribute invocations.
21686 I am not sure that this is right though.
21688 2002-04-14 Duncan Mak <duncan@ximian.com>
21690 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
21691 Binary.Operator.Division case.
21693 2002-04-13 Ravi Pratap <ravi@ximian.com>
21695 * class.cs (DefineType): Ensure that we do a proper check on
21696 attribute types and also register it with the TypeManager.
21698 (TypeContainer.Targets): The default for attribute types is
21699 AttributeTargets.All.
21701 * attribute.cs (ApplyAttributes): Registering the attribute type
21702 is done elsewhere, not when we discover we have a Usage attribute.
21704 2002-04-12 Ravi Pratap <ravi@ximian.com>
21706 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
21707 and get rid of is_delegate parameter.
21709 * everywhere : update.
21711 2002-04-12 Ravi Pratap <ravi@ximian.com>
21713 * cs-parser.jay (compilation_unit): Revamp completely to use
21714 some new ideas that I got from Rhys' grammar to solve the problems
21715 with assembly level attributes.
21717 (outer_declaration): New grammar production.
21719 (attribute_sections): Add.
21721 (opt_attributes): Base on attribute_sections
21723 (namespace_declaration): Allow opt_attributes to tackle the case
21724 when we have assembly level attributes - we are clever in this
21727 * attribute.cs (ApplyAttributes): Do not worry about assembly
21728 attributes in the non-global context.
21730 * rootcontext.cs (AddGlobalAttributes): Go back to using this
21731 instead of SetGlobalAttributes.
21733 * class.cs, rootcontext.cs : Ensure we define and generate
21734 attribute types before anything else.
21736 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
21737 and flag the new error -20 for the case when the attribute type
21738 does not have valid targets specified. csc does not catch this.
21740 * ../errors/errors.txt : update for error # -20
21742 2002-04-11 Ravi Pratap <ravi@ximian.com>
21744 * support.cs (InternalParameters.ParameterModifier): Do some null
21745 checking and return sane values.
21747 * class.cs (Method.Define): If we are a PInvoke method, ensure
21748 that we are static and extern. Report error # 601
21750 * ../errors/cs0601.cs : Add test case for the above error.
21752 2002-04-07 Ravi Pratap <ravi@ximian.com>
21754 * rootcontext.cs (attribute_types): We need to keep type of
21755 all attribute types separately and emit code for them first.
21757 (RegisterAttribute) : Implement.
21759 * class.cs (DefineType): Check if the current Type is a custom
21760 attribute type and register it accordingly.
21762 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
21763 adding the first attribute twice and rename to
21765 (SetGlobalAttributes): this.
21767 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
21770 * attribute.cs (ApplyAttributes): Take an additional argument telling us
21771 if we are processing global arguments. Hmm, I am unsure of this.
21773 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21775 * expression.cs: added static array of strings to avoid calling
21776 Enum.ToString () for Operator in Binary. Significant recover of
21779 2002-04-10 Miguel de Icaza <miguel@ximian.com>
21781 * class.cs (FindMembers): Allow the Builders of the various
21782 members to be null. If they are skip them. This only happens
21783 during the PInvoke declaration.
21785 2002-04-09 Miguel de Icaza <miguel@ximian.com>
21787 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
21788 failure, so we do not keep going afterwards.
21790 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
21791 wanted to pass `false' as the `is_delegate' argument. If this is
21792 the case, why not use delegate_type == null to mean `is_delegate =
21793 false' and anything else as is_delegate = true.
21795 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
21797 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
21798 code for the section, not the beginning of the tests.
21800 2002-04-08 Miguel de Icaza <miguel@ximian.com>
21802 * cfold.cs: Handle operator + (Enum x, Underlying x)
21804 * expression.cs (Binary): same. Warn about errors where we have
21805 Enum/Enum in operator + as well.
21807 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
21810 - added support for switch(bool)
21811 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
21812 - add TableSwitchEmit() to handle table-based switch statements
21814 2002-04-05 Ravi Pratap <ravi@ximian.com>
21816 * expression.cs (Invocation.OverloadResolve): Factor out code which
21817 does parameter compatibility checking with arguments so that we can
21818 re-use the code even from Delegate.VerifyApplicability
21820 (VerifyArgumentsCompat): Move above code here.
21822 * delegate.cs (VerifyApplicability): Get rid of duplicate code
21823 and instead make a call to the above method.
21825 2002-03-31 Ravi Pratap <ravi@ximian.com>
21827 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
21828 We use it to keep track of classes which are attribute types.
21830 2002-04-02 Miguel de Icaza <miguel@ximian.com>
21832 * delegate.cs (Delegate.Define): Correctly define the types in the
21833 presence of fixed and array parameters.
21835 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
21838 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
21839 include NonPublic after the first iteration.
21841 * class.cs (Indexer.CheckBase): Only check if both parents are
21844 * cs-parser.jay (accessor_body): If empty, set to null.
21846 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
21847 same code path here to resolve constants names that we did have in
21848 MemberAccess.DoResolve. There is too much code duplicated here.
21850 2002-04-01 Miguel de Icaza <miguel@ximian.com>
21852 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
21854 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
21857 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
21858 tokens, numbers and strings.
21860 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
21863 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
21864 asyncronous parameters and the regular parameters.
21866 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
21867 specify the target directory.
21869 * expression.cs: (This.DoResolve): Simplify
21870 (As.Emit): Optimize, do not generate IsInst if the expression is
21871 always of the given type.
21873 (Is.DoResolve): Bug fix, we were reporting both always/never for
21876 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
21877 creating too many unnecessary arrays.
21879 2002-03-31 Miguel de Icaza <miguel@ximian.com>
21881 * class.cs (EmitFieldInitializer): Use Assign expression to assign
21882 fields instead of rolling our own initializer. Takes care of all
21883 implicit conversions, and drops unnecessary static checks/argument.
21885 2002-03-31 Dick Porter <dick@ximian.com>
21887 * driver.cs: use the GetDirectories() return values properly, and
21888 use "/" as path separator.
21890 2002-03-30 Miguel de Icaza <miguel@ximian.com>
21892 * expression.cs (Unary): Optimize - - expr into expr.
21893 (Binary): Optimize a + (-b) into a -b.
21895 * codegen.cs (CodeGen): Made all methods static.
21897 2002-03-29 Miguel de Icaza <miguel@ximian.com>
21901 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
21902 TypeBuilder property.
21904 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
21907 * tree.cs: Removed the various RecordXXXX, and replaced with a
21908 single RecordDecl. Removed all the accessor methods, and just
21909 left a single access point Type
21911 * enum.cs: Rename DefineEnum to DefineType.
21913 * decl.cs: New abstract method `DefineType' used to unify the
21914 Defines for Enumerations, Interfaces, TypeContainers and
21917 (FindType): Moved LookupInterfaceOrClass here. Moved the
21918 LookupBaseClasses method that used to live in class.cs and
21919 interface.cs here, and renamed to FindType.
21921 * delegate.cs: Implement DefineType. Take advantage of the
21922 refactored pattern for locating the parent builder without taking
21923 the parent_builder argument (which we know does not work if we are
21924 nested, and triggering a toplevel definition).
21926 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21928 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
21929 accessibility of a member has changed during override and report
21932 * class.cs (Method.Define, Property.Define): Only complain on
21933 overrides if the method is private, any other accessibility is
21934 fine (and since we just checked the permission is the same, we are
21937 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
21938 and elif are processed always. The other pre-processing
21939 directives are only processed if we are "taking" the path
21941 2002-03-29 Martin Baulig <martin@gnome.org>
21943 * class.cs (Method.Emit): Only emit symbolic debugging info if the
21944 current location is not Null.
21946 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
21947 a separate method so we can profile it.
21949 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
21950 `span.Seconds' are just seconds, but no minutes or hours.
21951 (MainDriver): Profile the CodeGen.SaveSymbols calls.
21953 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21955 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
21956 Remove the gratuitous set of Final:
21958 // If an interface implementation, then we can set Final.
21959 if (((flags & MethodAttributes.Abstract) == 0) &&
21960 implementing.DeclaringType.IsInterface)
21961 flags |= MethodAttributes.Final;
21963 I do not know what I was smoking when I used that.
21966 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
21967 step into fixing the name resolution issues for delegates and
21968 unifying the toplevel name resolution.
21970 2002-03-28 Martin Baulig <martin@gnome.org>
21972 * class.cs (Method.Emit): If we have a symbol writer, call its
21973 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
21974 tell it about the current method.
21976 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
21977 writer that we're going to emit the first byte of IL code for a new
21978 statement (a new source line).
21979 (EmitContext.EmitTopBlock): If we have a symbol writer, call
21980 EmitContext.Mark() before emitting any code.
21982 * location.cs (SymbolDocument): Return null when we're Null.
21984 * statement.cs (Statement): Moved the `Location loc' variable here.
21985 (Statement.EmitBoolExpression): If we have a symbol writer, call
21986 ec.Mark() before emitting any code to tell it that we're at the
21987 beginning of a new statement.
21988 (StatementExpression): Added `Location' argument to the constructor.
21989 (Block): Added public readonly variable `StartLocation' and public
21990 variable `EndLocation'. The latter is to be set using SetEndLocation().
21991 (Block): Added constructor which takes a start and end location.
21992 (Block.SetEndLocation): New method. This sets the end location.
21993 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
21994 local variables we create.
21995 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
21996 each statement and do also mark the begin and end of the block.
21998 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
21999 tell it the current lexer.Location, use Location.Null for the end of the
22001 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
22002 current block, set its end location using SetEndLocation().
22003 (statement_expression): StatementExpression constructor now takes the
22004 lexer.Location as additional argument.
22005 (for_statement, declare_local_variables): Likewise.
22006 (declare_local_variables): When creating a new implicit block, use the
22007 new Block constructor and pass it the lexer.Location.
22009 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22011 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
22012 members also on the parent interfaces recursively.
22014 2002-03-27 Miguel de Icaza <miguel@ximian.com>
22016 * report.cs: Use new formats, since Gonzalo finished the missing
22019 * expression.cs (Binary.ResolveOperator): added missing operator|
22020 operator& and operator^ for bool/bool.
22022 * cs-parser.jay: CheckDef now takes a Location argument that is
22023 used to report errors more precisly (instead of reporting the end
22024 of a definition, we try to track something which is a lot closer
22025 to the source of the problem).
22027 * cs-tokenizer.cs: Track global token use, so we can properly flag
22028 the use of #define/#undef after the first token has been seen.
22030 Also, rename the reportXXXX to Error_DescriptiveName
22032 * decl.cs (DeclSpace.IsTopLevel): Move property here from
22033 TypeContainer, so that Enum and Interface can use this too.
22035 * class.cs (TypeContainer.LookupInterfaceOrClass,
22036 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
22037 `builder' argument. Typically this was used to pass the parent
22038 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
22041 The problem is that a nested class could trigger the definition of
22042 a toplevel class, and the builder would be obviously wrong in that
22045 So we drop this argument, and we compute dynamically the
22046 TypeBuilder/ModuleBuilder (the correct information was available
22047 to us anyways from DeclSpace.Parent)
22049 * interface.cs (Interface.DefineInterface): Drop builder
22050 parameter cleanup like class.cs
22052 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
22055 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
22058 (Try.Emit): Propagate the returns value from the statement.
22060 (Return.Emit): Even if we are leavning
22062 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
22064 * modifiers.cs: Fix the computation of MethodAttributes flags.
22066 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
22068 * driver.cs: allow compilation of files that start with '/'.
22069 Add a default case when checking the argument of --target.
22071 2002-03-25 Miguel de Icaza <miguel@ximian.com>
22073 * interface.cs: Implement the same search algorithm for types in
22074 the interface code.
22076 * delegate.cs: Do not allow multiple definition.
22078 * Recovered ChangeLog that got accidentally amputated
22080 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
22082 * rootcontext.cs: Load manually enum to allow core classes to
22083 contain enumerations.
22085 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
22086 Update to new static methods in TypeManager.
22088 * typemanager.cs (GetMethod, GetConstructor): Use our
22089 implementation of FindMembers to find the members, since during
22090 corlib compilation, the types are TypeBuilders and GetMethod and
22091 GetConstructor do not work.
22093 Make all methods in TypeManager static.
22095 (InitCodeHelpers): Split the functionality from
22096 the InitCodeTypes function.
22098 * driver.cs: Call InitCodeHelpers after we have populated the
22101 * cs-parser.jay (delegate_declaration): we did not used to compute
22102 the delegate name correctly for void delegates.
22104 2002-03-24 Miguel de Icaza <miguel@ximian.com>
22106 * rootcontext.cs (RootContext): Init the interface_resolve_order
22107 and type_container_resolve_order always.
22109 (ResolveCore, BootstrapCorlib_ResolveClass,
22110 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
22111 compiler when compiling with --nostdlib
22113 * class.cs (TypeContainer.DefineType): Check that our parent is
22114 not null. This test is most important when we are bootstraping
22117 * codegen.cs: Split out the symbol writing code.
22119 2002-03-25 Martin Baulig <martin@gnome.org>
22121 * driver.cs (-g): Made -g an alias for --debug.
22123 2002-03-24 Martin Baulig <martin@gnome.org>
22125 * codegen.cs (SymbolWriter): New public variable. Returns the
22126 current symbol writer.
22127 (CodeGen): Added `bool want_debugging_support' argument to the
22128 constructor. If true, tell the ModuleBuild that we want debugging
22129 support and ask it for the ISymbolWriter.
22130 (Save): If we have a symbol writer, call it's Close() method after
22131 saving the assembly.
22133 * driver.c (--debug): New command line argument to create a
22134 debugger information file.
22136 * location.cs (SymbolDocument): New public property. Returns an
22137 ISymbolDocumentWriter object for the current source file or null
22138 if we don't have a symbol writer.
22140 2002-03-21 Miguel de Icaza <miguel@ximian.com>
22142 * driver.cs (LoadAssembly): Correctly return when all the paths
22143 have been tried and not before.
22145 * statement.cs (Switch.Emit): return the actual coverage for this
22146 statement (returns/not-returns)
22148 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
22149 switch of the statement if we are the last switch section. That
22150 kills two problems: try/catch problems (we used to emit an empty
22151 nop at the end) and switch statements where all branches would
22154 2002-03-19 Miguel de Icaza <miguel@ximian.com>
22156 * driver.cs: Add default assemblies (the equivalent to the
22157 Microsoft CSC.RSP file)
22159 * cs-tokenizer.cs: When updating `cols and setting it to zero,
22160 also update tokens_seen and set it to false.
22162 * driver.cs: Implement --recurse for Mike.
22164 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
22165 correctly splitting out the paths.
22167 2002-03-18 Miguel de Icaza <miguel@ximian.com>
22169 * interface.cs (Interface.PopulateProperty): Instead of using
22170 `parent' as the declaration space for the set parameters, use
22173 * support.cs (InternalParameters): InternalParameters constructor
22174 takes a DeclSpace instead of a TypeContainer.
22176 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
22177 types are being initialized, load the address of it before calling
22180 (New): Provide a mechanism to disable the generation of local
22181 value type temporaries when the caller will be providing us with
22182 an address to store it.
22184 (ArrayCreation.EmitDynamicInitializers): Use it.
22186 2002-03-17 Miguel de Icaza <miguel@ximian.com>
22188 * expression.cs (Invocation.EmitArguments): Only probe for array
22189 property if there is more than one argument. Sorry about that.
22191 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
22192 empty param arrays.
22194 * class.cs (Method.LabelParameters): Fix incorrect code path that
22195 prevented the `ParamArrayAttribute' from being applied to the
22198 2002-03-16 Miguel de Icaza <miguel@ximian.com>
22200 * support.cs (ReflectionParameters): Correctly compute whether the
22201 last argument is a params array. Fixes the problem with
22204 * typemanager.cs: Make the assemblies array always be non-null
22205 (empty, but non-null)
22207 * tree.cs (RecordDecl): New function that abstracts the recording
22208 of names. This reports error 101, and provides a pointer to the
22209 previous declaration. Fixes a crash in the compiler.
22211 * cs-parser.jay (constructor_declaration): Update to new grammar,
22212 and provide a constructor_body that can be empty.
22214 2002-03-15 Miguel de Icaza <miguel@ximian.com>
22216 * driver.cs: Add support for --resources.
22218 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
22219 Make all types for the various array helper methods be integer.
22221 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
22222 CheckState to ConvCast.
22224 (ConvCast): Now it takes a `checked' state argument, to avoid
22225 depending on the emit context for the conversion, and just using
22226 the resolve time setting.
22228 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
22229 instead of Invocation.EmitArguments. We do not emit the original
22230 arguments, instead we emit those which have been converted to
22231 unsigned int expressions.
22233 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
22235 * codegen.cs: ditto.
22237 * expression.cs (LocalVariableReference): Drop the use of the
22238 Store function that depended on the variable index.
22240 * statement.cs (VariableInfo): Drop the `Idx' property from this
22241 class, as this is not taking into account the indexes for
22242 temporaries tat we generate during the execution, getting the
22245 * class.cs: First emit class initializers, then call the parent
22248 * expression.cs (Binary): Fix opcode emision.
22249 (UnaryMutator.EmitCode): Support checked code generation
22251 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
22252 matches for events for both the Static and Instance scans,
22253 pointing to the same element. Fix that.
22255 2002-03-14 Miguel de Icaza <miguel@ximian.com>
22257 * rootcontext.cs (ResolveTree): Always set the
22258 interface_resolve_order, because nested interfaces will be calling
22261 * class.cs (GetInterfaceOrClass): Track the same resolution
22262 process used by TypeManager.LookupType. This fixes the nested
22263 type lookups in class declarations (separate path from
22266 (TypeContainer.DefineType): Also define nested interfaces.
22267 (TypeContainer.RegisterOrder): New public function used to
22268 register the order in which child interfaces need to be closed.
22270 Nested interfaces need to be closed after their parents have been
22273 * interface.cs (InterfaceAttr): Put all the logic for computing
22274 the interface attribute here.
22276 (DefineInterface): Register our interface order with the
22277 RootContext or with the TypeContainer depending on the case.
22279 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22281 * cs-parser.jay: rework foreach statement to work with the new
22282 changes to the policy on SimpleNames.
22284 * report.cs: support Stacktrace on warnings as well.
22286 * makefile: drop --unsafe and /unsafe from the compile.
22288 2002-03-13 Ravi Pratap <ravi@ximian.com>
22290 * ecore.cs (StandardConversionExists): Modify to take an Expression
22291 as the first parameter. Ensure we do null -> reference type conversion
22294 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
22295 temporary Expression objects.
22297 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
22299 * interface.cs: workaround bug in method overloading resolution
22300 (there is already a bugzilla bug for it).
22302 2002-03-12 Miguel de Icaza <miguel@ximian.com>
22304 We could also solve this problem by having a separate path for
22305 performing type lookups, instead of DoResolve, we could have a
22306 ResolveType entry point, and only participating pieces of the
22307 production (simplename, deref, array) would implement this.
22309 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
22310 signal SimpleName to only resolve type names and not attempt to
22311 resolve anything else.
22313 * expression.cs (Cast): Set the flag.
22315 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
22317 * class.cs: Only report 108 if there is no `new' modifier.
22319 * cs-parser.jay: rework foreach statement to work with the new
22320 changes to the policy on SimpleNames.
22322 * report.cs: support Stacktrace on warnings as well.
22324 * makefile: drop --unsafe and /unsafe from the compile.
22326 2002-03-11 Miguel de Icaza <miguel@ximian.com>
22328 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22329 lookups here, instead of doing that at parse time. This means
22330 that our grammar will not introduce `LocalVariableReferences' as
22331 expressions at this point. That solves the problem of code like
22335 static void Main ()
22339 This is only half the fix. The full fix requires parameters to
22340 also be handled in this way.
22342 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
22343 makes the use more obvious of the DeclSpace. The
22344 ec.TypeContainer.TypeBuilder is now only used to pull the
22345 TypeBuilder for it.
22347 My theory is that I can get rid of the TypeBuilder completely from
22348 the EmitContext, and have typecasts where it is used (from
22349 DeclSpace to where it matters).
22351 The only pending problem is that the code that implements Aliases
22352 is on TypeContainer, and probably should go in DeclSpace.
22354 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
22355 lookups here, instead of doing that at parse time. This means
22356 that our grammar will not introduce `LocalVariableReferences' as
22357 expressions at this point. That solves the problem of code like
22361 static void Main ()
22365 This is only half the fix. The full fix requires parameters to
22366 also be handled in this way.
22368 * class.cs (Property.DefineMethod): When implementing an interface
22369 method, set newslot, when implementing an abstract method, do not
22370 set the flag (before we tried never setting it, or always setting
22371 it, which is the difference).
22372 (Indexer.DefineMethod): same.
22373 (Method.DefineMethod): same.
22375 * ecore.cs: Only set the status used flag if we get back a Field.
22377 * attribute.cs: Temporary hack, so Paolo can keep working.
22379 2002-03-08 Ravi Pratap <ravi@ximian.com>
22381 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
22382 the unmanaged type in the case we have a MarshalAs attribute.
22384 (Resolve): Handle the case when we are parsing the special MarshalAs
22385 attribute [we need to store the unmanaged type to use later]
22387 * typemanager.cs (marshal_as_attr_type): Built in type for the
22388 MarshalAs Attribute.
22390 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
22391 on parameters and accordingly set the marshalling info.
22393 2002-03-09 Miguel de Icaza <miguel@ximian.com>
22395 * class.cs: Optimizing slightly by removing redundant code after
22396 we switched to the `NoTypes' return value.
22397 (Property.DefineMethod): use NoTypes here too.
22399 This fixes the bug I introduced in my last batch of changes.
22401 2002-03-05 Ravi Pratap <ravi@ximian.com>
22403 * tree.cs (RecordEnum): Add. We now keep track of enums too.
22405 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
22406 Enums since those are types too.
22408 * cs-parser.jay (enum_declaration): Record enums as we parse them.
22410 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
22411 thanks to a call during the lookup process.
22413 2002-03-07 Miguel de Icaza <miguel@ximian.com>
22415 * statement.cs (Foreach): Lots of work to accomodate a particular
22416 kind of foreach statement that I had not kept in mind. It is
22417 possible to have foreachs on classes that provide a GetEnumerator
22418 method that return objects that implement the "pattern" for using
22419 a foreach, there is no need to support GetEnumerator
22422 This is needed to compile nant.
22424 * decl.cs: Only report 114 if the member is not `Finalize' and if
22425 the warning level is at least 2.
22427 * class.cs: Moved the compare function from Method to
22430 (MethodSignature.InheritableMemberSignatureCompare): Add new
22431 filter function that is used to extract inheritable methods from a
22434 (Method.Define): Use the new `inheritable_method_signature_filter'
22437 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
22440 2002-03-06 Miguel de Icaza <miguel@ximian.com>
22442 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
22444 * cs-parser.jay: Add opt_semicolon to the interface declaration.
22446 * expression.cs: Pass location information to
22447 ConvertImplicitStandard.
22449 * class.cs: Added debugging code to track return values from
22452 2002-03-05 Miguel de Icaza <miguel@ximian.com>
22454 * expression.cs (Is.DoResolve): If either side of the `is' is an
22455 interface, do not flag the warning.
22457 * ecore.cs (ImplicitReferenceConversion): We need a separate test
22460 * report.cs: Allow for --fatal to be used with --probe.
22462 * typemanager.cs (NoTypes): Move the definition for the empty Type
22465 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
22467 (TypeContainer.DefineProxy): New function used to proxy to parent
22468 implementations when implementing interfaces.
22469 (TypeContainer.ParentImplements): used to lookup if our parent
22470 implements a public function that is required by an interface.
22471 (TypeContainer.VerifyPendingMethods): Hook this up.
22473 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
22474 `modules' and `assemblies' arraylists into arrays. We only grow
22475 these are the very early start up of the program, so this improves
22476 the speedof LookupType (nicely measured).
22478 * expression.cs (MakeByteBlob): Replaced unsafe code with
22479 BitConverter, as suggested by Paolo.
22481 * cfold.cs (ConstantFold.Binary): Special case: perform constant
22482 folding of string concatenation, but if either side is a string,
22483 and the other is not, then return null, and let the runtime use
22484 the concatenation on the string plus the object (using
22485 `Object.ToString').
22487 2002-03-04 Miguel de Icaza <miguel@ximian.com>
22489 Constant Folding has been implemented now.
22491 * expression.cs (Unary.Reduce): Do not throw an exception, catch
22492 the error instead on types that are not supported in one's
22495 * constant.cs (Constant and all children): New set of functions to
22496 perform implict and explicit conversions.
22498 * ecore.cs (EnumConstant): Implement the new functions to perform
22499 conversion by proxying to the child expression.
22501 * codegen.cs: (ConstantCheckState): Constant evaluation has its
22502 own separate setting that can not be turned off from the command
22503 line using --unchecked or --checked and is only controlled using
22504 the checked/unchecked statements and expressions. This setting is
22505 used by the constant folder to flag errors.
22507 * expression.cs (CheckedExpr, UncheckedExpr): Set the
22508 ConstantCheckState as well.
22510 During Resolve, they also have to flag the state, because the
22511 constant folder runs completely in the Resolve phase.
22513 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
22516 2002-03-01 Miguel de Icaza <miguel@ximian.com>
22518 * cfold.cs: New file, this file contains the constant folder.
22520 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
22521 argument to track whether we are using the resulting address to
22522 load or store a value and provide better error messages.
22524 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
22525 new AddressOf arguments.
22527 * statement.cs (Foreach.EmitCollectionForeach): Update
22529 * expression.cs (Argument.Emit): Call AddressOf with proper
22530 arguments to track usage.
22532 (New.DoEmit): Call AddressOf with new arguments.
22534 (Unary.Emit): Adjust AddressOf call.
22536 2002-03-01 Ravi Pratap <ravi@ximian.com>
22538 * cs-parser.jay (member_access): Change the case for pre-defined types
22539 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
22542 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
22545 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
22546 essentially like methods and apply attributes like MethodImplOptions to them too.
22548 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
22551 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
22552 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
22555 * Update code everywhere accordingly.
22557 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
22559 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
22561 2002-02-28 Ravi Pratap <ravi@ximian.com>
22563 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
22564 try performing lookups against those instead of jumping straight into using
22565 the 'using' clauses.
22567 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
22569 (LookupType): Perform lookups in implicit parents too.
22571 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
22572 sequence as RootContext.LookupType.
22574 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
22575 the various cases of namespace lookups into this method.
22577 2002-03-01 Miguel de Icaza <miguel@ximian.com>
22579 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
22580 in positional arguments)
22582 * class.cs (Operator): Update the AllowedModifiers to contain
22585 * cs-parser.jay: Update operator declaration to allow for the
22586 operator body to be empty.
22588 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
22591 2002-02-27 Miguel de Icaza <miguel@ximian.com>
22593 * class.cs (Method.Emit): Label parameters.
22595 * driver.cs: Return 1 or 0 as the program exit code.
22597 2002-02-26 Miguel de Icaza <miguel@ximian.com>
22599 * expression.cs: Special case the `null' object when trying to
22600 auto-compute the type, as anything can be explicitly converted to
22603 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
22604 spotting this Paolo.
22606 (Expression.ImplicitNumericConversion): Perform comparissions of
22607 the type using the underlying type in the case of an enumeration
22608 rather than using the enumeration type for the compare.
22610 Cope with the underlying == type case, which is not possible to
22613 (Expression.ConvertNumericExplicit): Perform comparissions of
22614 the type using the underlying type in the case of an enumeration
22615 rather than using the enumeration type for the compare.
22617 * driver.cs: If the user does not supply an extension, assume .exe
22619 * cs-parser.jay (if_statement): Rewrote so that we can track the
22620 location for the if statement.
22622 * expression.cs (Binary.ConstantFold): Only concat strings when
22623 the operation is "+", not everything ;-)
22625 * statement.cs (Statement.EmitBoolExpression): Take a location
22627 (If, While, Do): Track location.
22629 * expression.cs (Binary.ResolveOperator): In the object + string
22630 case, I was missing a call to ConvertImplicit
22632 2002-02-25 Ravi Pratap <ravi@ximian.com>
22634 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
22635 Location arguments. Ensure we use RootContext.LookupType to do our work
22636 and not try to do a direct Type.GetType and ModuleBuilder.GetType
22638 * interface.cs (PopulateMethod): Handle the type of the parameter being
22641 * expression.cs (Invocation.BetterFunction): Handle the case when we
22642 have a params method with no fixed arguments and a call is made with no
22645 2002-02-25 Miguel de Icaza <miguel@ximian.com>
22647 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
22648 the verbatim-string-literal
22650 * support.cs (InternalParameters.ParameterModifier): handle null
22652 (InternalParameters.ParameterType): ditto.
22654 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
22655 duplicating the name of the variable parameter.
22656 (GetParameterByName): Fix bug where we were not looking up array
22657 paramters if they were the only present (thanks Paolo!).
22658 (GetParameterInfo): We only have an empty set of types if both
22659 fixed and array are set to null.
22660 (GetParameterInfo-idx): Handle FixedParameter == null
22662 * cs-parser.jay: Handle the case where there is no catch
22663 statements (missing null test).
22665 2002-02-22 Miguel de Icaza <miguel@ximian.com>
22667 * driver.cs (MainDriver): Be conservative on our command line
22670 Catch DirectoryNotFoundException when calling GetFiles.
22672 (SplitPathAndPattern): Used to split the input specification into
22673 a path and a pattern that we can feed to Directory.GetFiles.
22675 2002-02-21 Miguel de Icaza <miguel@ximian.com>
22677 * statement.cs (Fixed): Implement the last case of the Fixed
22678 statement (string handling).
22680 * expression.cs (StringPtr): New class used to return a char * to
22681 a string; Used by the Fixed statement.
22683 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
22685 * expression.cs (Binary.ResolveOperator): Remove redundant
22686 MemberLookup pn parent type.
22687 Optimize union call, we do not need a union if the types are the same.
22688 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
22691 Specialize the use of MemberLookup everywhere, instead of using
22692 the default settings.
22694 (StackAlloc): Implement stackalloc keyword.
22696 * cs-parser.jay: Add rule to parse stackalloc.
22698 * driver.cs: Handle /h, /help, /?
22700 * expression.cs (MakeByteBlob): Removed the hacks we had in place
22701 before we supported unsafe code.
22703 * makefile: add --unsafe to the self compilation of mcs.
22705 2002-02-20 Miguel de Icaza <miguel@ximian.com>
22707 * expression.cs (PointerArithmetic): New class that is used to
22708 perform pointer arithmetic.
22709 (Binary.Resolve): Handle pointer arithmetic
22710 Handle pointer comparission.
22711 (ArrayPtr): Utility expression class that is used to take the
22712 address of an array.
22714 (ElementAccess): Implement array access for pointers
22716 * statement.cs (Fixed): Implement fixed statement for arrays, we
22717 are missing one more case before we are done.
22719 * expression.cs (Indirection): Implement EmitAssign and set the
22720 ExprClass to Variable. This allows pointer dereferences to be
22721 treated as variables, and to have values assigned to them.
22723 * ecore.cs (Expression.StoreFromPtr): New utility function to
22724 store values dereferencing.
22726 2002-02-20 Ravi Pratap <ravi@ximian.com>
22728 * expression.cs (Binary.ResolveOperator): Ensure that we are
22729 not trying to operate on a void type - this fixes the reported
22732 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
22733 the parent implementation is sealed.
22735 * ../errors/cs0239.cs : Add.
22737 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
22739 * typemanager.cs (unverifiable_code_type): Corresponds to
22740 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
22741 which have unsafe code in them.
22743 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
22746 2002-02-19 Miguel de Icaza <miguel@ximian.com>
22748 * cs-tokenizer.cs: Add support for @"litreal strings"
22750 Make tokenizer accept pre-processor directives
22751 on any column (remove the old C-like limitation).
22753 * rootcontext.cs (EmitCode): Emit any global attributes.
22754 (AddGlobalAttributes): Used to keep track of assembly attributes.
22756 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
22758 * cs-parser.jay: Add support for global attributes.
22760 2002-02-17 Miguel de Icaza <miguel@ximian.com>
22762 * expression.cs (Indirection): New helper class. Unary will
22763 create Indirection classes to be able to implement the
22764 IMemoryLocation interface on it.
22766 2002-02-16 Miguel de Icaza <miguel@ximian.com>
22768 * cs-parser.jay (fixed_statement): reference the right statement.
22770 * statement.cs (Fixed.Emit): Finish implementing the fixed
22771 statement for the &x case.
22773 2002-02-14 Miguel de Icaza <miguel@ximian.com>
22775 * class.cs (Property.Define, Method.Define): Remove newslot when
22778 * modifiers.cs: My use of NewSlot when `Abstract' was set was
22779 wrong. NewSlot should only be used if the `new' keyword is present.
22781 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
22782 locating our system dir. Sorry about this.
22784 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22786 * driver.cs (GetSystemDir): Compute correctly the location of our
22787 system assemblies. I was using the compiler directory instead of
22788 the library directory.
22790 2002-02-13 Ravi Pratap <ravi@ximian.com>
22792 * expression.cs (BetterFunction): Put back in what Miguel commented out
22793 since it is the correct fix. The problem is elsewhere ;-)
22795 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
22796 parameters of the parms method are themselves compatible or not !
22798 (StandardConversionExists): Fix very dangerous bug where we were forgetting
22799 to check that a class implements an interface before saying that an implicit
22800 conversion was allowed. Use ImplementsInterface to do the checking.
22802 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22804 * class.cs (Method.Define): Track whether we are an explicit
22805 implementation or not. And only call DefineMethodOverride if we
22806 are an explicit implementation.
22808 (Property.DefineMethod): Ditto.
22810 2002-02-11 Ravi Pratap <ravi@ximian.com>
22812 * expression.cs (BetterFunction): Catch hideous bug which was
22813 preventing us from detecting ambiguous calls due to implicit casts i.e
22816 2002-01-29 Miguel de Icaza <miguel@ximian.com>
22818 * support.cs (Pair): Remove un-needed method. I figured why I was
22819 getting the error in cs-parser.jay, the variable in a foreach loop
22820 is readonly, and the compiler does not really treat this as a variable.
22822 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
22823 instead of EQUALS in grammar.
22825 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
22827 * expression.cs (Unary.DoResolve): Check whether the argument is
22830 2002-01-28 Miguel de Icaza <miguel@ximian.com>
22832 * support.cs: Api for Pair to set a value. Despite the fact that
22833 the variables are public the MS C# compiler refuses to compile
22834 code that accesses the field if the variable is part of a foreach
22837 * statement.cs (Fixed): Begin implementation of the fixed
22840 (Block.AddVariable): Return the VariableInfo on success and null
22841 on failure instead of true/false.
22843 * cs-parser.jay (foreach): Catch errors on variables already
22844 defined (we were ignoring this value before) and properly unwind
22845 the block hierarchy
22847 (fixed_statement): grammar for the fixed statement.
22849 2002-01-25 Miguel de Icaza <miguel@ximian.com>
22851 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
22852 pointer types to be incretemented.
22854 (SizeOf): Implement.
22856 * cs-parser.jay (pointer_member_access): Implement
22857 expr->IDENTIFIER production.
22859 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
22860 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
22863 (Unary): Implement indirection.
22865 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
22866 use in non-unsafe context).
22868 (SimpleName.DoResolve): Check for pointers in field access on safe
22871 (Expression.LoadFromPtr): Factor the load-indirect code in this
22872 function. This was duplicated in UnboxCast and ParameterReference
22874 2002-01-24 Miguel de Icaza <miguel@ximian.com>
22876 * expression.cs (ComposedCast): report an error if a pointer cast
22877 is used in a safe region.
22879 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
22880 pointer type casts in unsafe context.
22882 * codegen.cs (EmitContext): Set up IsUnsafe.
22884 * cs-parser.jay (non_expression_type): Add productions for pointer
22887 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
22888 code. We should not use force into static mode if the method is
22889 not virtual. Fixes bug in MIS
22891 * statement.cs (Do.Emit, While.Emit, For.Emit,
22892 Statement.EmitBoolExpression): Add support to Do and While to
22893 propagate infinite loop as `I do return' semantics.
22895 Improve the For case to also test for boolean constants.
22897 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
22898 to the list of attributes we can add.
22900 Remove `EmitContext' argument.
22902 * class.cs (Method.Define): Apply parameter attributes.
22903 (Constructor.Define): Apply parameter attributes.
22904 (MethodCore.LabelParameters): Move here the core of labeling
22907 * support.cs (ReflectionParameters.ParameterModifier,
22908 InternalParameters.ParameterModifier): Use IsByRef on the type and
22909 only return the OUT bit for these parameters instead of in/out/ref
22912 This is because I miss-understood things. The ParameterInfo.IsIn
22913 and IsOut represent whether the parameter has the [In] and [Out]
22916 2002-01-22 Miguel de Icaza <miguel@ximian.com>
22918 * ecore.cs (FieldExpr.Emit): Release temporaries.
22920 * assign.cs (LocalTemporary.Release): new function.
22922 * codegen.cs (EmitContext.GetTemporaryStorage,
22923 EmitContext.FreeTemporaryStorage): Rework the way we deal with
22924 temporary storage. Now we can "put back" localbuilders when we
22927 2002-01-21 Miguel de Icaza <miguel@ximian.com>
22929 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
22930 need to make a copy of the variable to generate verifiable code.
22932 2002-01-19 Miguel de Icaza <miguel@ximian.com>
22934 * driver.cs: Compute dynamically the system directory.
22936 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
22937 Slower, but more generally useful. Used by the abstract
22938 registering implementation.
22940 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
22941 the rules for the special rule on Type/instances. First check if
22942 we have the same name, and if so, try that special static path
22943 rather than the instance path.
22945 2002-01-18 Miguel de Icaza <miguel@ximian.com>
22947 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
22950 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
22951 Enum, ValueType, Delegate or Array for non-corlib compiles.
22953 * cs-tokenizer.cs: Catch long identifiers (645)
22955 * typemanager.cs (IndexerPropetyName): Ravi never tested this
22958 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
22959 fix, we were returning too early, so we were not registering
22960 pending methods from abstract classes.
22962 Do not register pending methods if the class is abstract.
22964 * expression.cs (Conditional.DoResolve): Report circular implicit
22965 conversions when we neecd to compute it for conditional
22968 (Is.DoResolve): If the expression is always of the provided type,
22969 flag warning 183. If the expression can not ever be of the
22970 provided type flag warning 184.
22972 * class.cs: Catch 169 as well.
22974 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
22977 2002-01-18 Nick Drochak <ndrochak@gol.com>
22979 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
22981 2002-01-17 Miguel de Icaza <miguel@ximian.com>
22983 * interface.cs: (PopulateMethod): Check for pointers being defined
22984 only if the unsafe context is active.
22985 (PopulateProperty): ditto.
22986 (PopulateIndexer): ditto.
22988 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
22989 specified. If pointers are present, make sure that they are
22990 present in an unsafe context.
22991 (Constructor, Constructor.Define): ditto.
22992 (Field, Field.Define): ditto.
22993 (Property, Property.Define): ditto.
22994 (Event, Event.Define): ditto.
22996 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
22997 hashtable if there are classes or structs defined.
22999 * expression.cs (LocalVariableReference.DoResolve): Simplify this
23000 code, as the constant resolution moved.
23002 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
23003 the metadata, so we can flag error 133.
23005 * decl.cs (MemberCore.UnsafeOK): New function to test that a
23006 pointer is being declared in an unsafe context.
23008 2002-01-16 Miguel de Icaza <miguel@ximian.com>
23010 * modifiers.cs (Modifiers.Check): Require a Location argument.
23011 Report error 227 for Unsafe use.
23013 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
23015 * statement.cs (For.Emit): If the test is null, then report that
23016 we do `return', as we wont reach anything afterwards.
23018 (Switch.SwitchGoverningType): Track the expression that matched
23021 * driver.cs: Allow negative numbers as an error code to flag.
23023 * cs-parser.jay: Handle 1551.
23025 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
23027 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23029 * cs-parser.jay: Report 1518 (type declaration can only contain
23030 class, struct, interface, enum or delegate)
23032 (switch_label): Report 1523 (keywords `case' or `default' must
23035 (opt_switch_sections): Report 1522 (empty switch)
23037 * driver.cs: Report 1515 (response file specified multiple times)
23038 Report 1516 (Source file specified multiple times).
23040 * expression.cs (Argument.Resolve): Signal 1510
23042 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
23043 access not allowed in static code)
23045 2002-01-11 Ravi Pratap <ravi@ximian.com>
23047 * typemanager.cs (IsPointerType): Utility method which we are going
23050 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
23051 the object type, so we take care of that.
23053 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
23055 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
23056 added to non-params parameters :-)
23058 * typemanager.cs (CSharpName): Include 'void' type too.
23060 (void_ptr_type): Include in the set of core types.
23062 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
23065 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
23068 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
23069 completely forgotten about it.
23071 2002-01-10 Ravi Pratap <ravi@ximian.com>
23073 * cs-parser.jay (pointer_type): Add. This begins our implementation
23074 of parsing rules for unsafe code.
23076 (unsafe_statement): Implement.
23078 (embedded_statement): Modify to include the above.
23080 * statement.cs (Unsafe): Implement new class for unsafe blocks.
23082 * codegen.cs (EmitContext.InUnsafe): Add. This determines
23083 if the current context is an unsafe one.
23085 * cs-parser.jay (local_variable_pointer_type): Since local variable types
23086 are handled differently, we need separate rules for them.
23088 (local_variable_declaration): Update to use local_variable_pointer_type
23089 to allow variable declarations of unmanaged pointer types.
23091 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
23092 in unsafe contexts.
23094 * ../errors/cs0214.cs : Add.
23096 2002-01-16 Nick Drochak <ndrochak@gol.com>
23098 * makefile: remove 'response' file when cleaning.
23100 2002-01-15 Miguel de Icaza <miguel@ximian.com>
23102 * cs-parser.jay: Report 1524.
23104 2002-01-14 Miguel de Icaza <miguel@ximian.com>
23106 * typemanager.cs (RegisterMethod): drop checking if we have
23107 registered this from here
23109 2002-01-12 Miguel de Icaza <miguel@ximian.com>
23111 * class.cs (Method.EmitDestructor): Implement calling our base
23114 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
23115 value of InFinally.
23117 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
23118 this routine and will wrap the call in a try/catch block. Deal
23121 2002-01-11 Miguel de Icaza <miguel@ximian.com>
23123 * ecore.cs (Expression.MemberLookup): instead of taking a
23124 parameter `same_type' that was used to tell whether we could
23125 access private members we compute our containing type from the
23128 (FieldExpr): Added partial support for volatile fields. This does
23129 not work for volatile fields exposed from assemblies, as I can not
23130 figure out how to extract the modreq from it.
23132 Updated all the source files to use this.
23134 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
23135 because it is referenced by MemberLookup very often.
23137 2002-01-09 Ravi Pratap <ravi@ximian.com>
23139 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
23140 TypeBuilder.GetCustomAttributes to retrieve what we need.
23142 Get rid of redundant default_member_attr_type as this is the same as
23143 default_member_type which already exists.
23145 * interface.cs, attribute.cs : Update accordingly.
23147 2002-01-08 Miguel de Icaza <miguel@ximian.com>
23149 * typemanager.cs: Enable IndexerPropertyName again. It does not
23150 work for TYpeBuilders though. Ravi, can you please fix this?
23152 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
23154 * expression.cs (Argument.Emit): Handle the case of ref objects
23155 being passed to ref functions;
23157 (ParameterReference.EmitLoad): Loads the content of the pointer
23158 without dereferencing.
23160 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23162 * cs-tokenizer.cs: Implemented the pre-processing expressions.
23164 2002-01-08 Ravi Pratap <ravi@ximian.com>
23166 * class.cs (Indexer.DefineMethod): Incorporate the interface
23167 type in the name of the method if we are doing explicit interface
23170 * expression.cs (ConversionExists): Remove as it is completely obsolete.
23172 (BetterConversion): Fix extremely trivial bug where we were referring to
23173 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
23176 * ../errors/bug16.cs : Add although we have fixed it.
23178 2002-01-07 Miguel de Icaza <miguel@ximian.com>
23180 * expression.cs (BaseIndexer): Begin implementation.
23182 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
23184 * cs-parser.jay (indexer_declarator): Use qualified_identifier
23185 production directly to remove a shift/reduce, and implement
23186 explicit interface implementation.
23188 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
23189 after a floating point suffix.
23191 * expression.cs (DoNumericPromotions): Improved the conversion for
23192 uint/uint. If we have a constant, we avoid doing a typecast to a
23195 * class.cs (Indexer): Implement explicit interface implementation
23198 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
23200 * class.cs: make the default instance constructor public and hidebysig.
23202 2001-01-03 Ravi Pratap <ravi@ximian.com>
23204 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
23205 so we can call it from elsewhere.
23207 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
23208 we emit it internally if the class has a defined indexer; otherwise the user
23209 emits it by decorating the class definition with the DefaultMemberAttribute.
23211 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
23212 attribute is not used on a type which defines an indexer.
23214 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
23215 character when we skip whitespace.
23217 * ../errors/cs0646.cs : Add.
23219 2002-01-03 Miguel de Icaza <miguel@ximian.com>
23221 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
23224 * makefile: Add practical target `mcs3.exe' which builds the third
23225 generation compiler.
23227 * expression.cs (New): Fix structures constructor calling.
23229 * class.cs (Property, Method, Indexer): Emit Final flag on the
23230 method if we are an interface implementation and we are not
23233 * ecore.cs (PropertyExpr): New public field `IsBase', tells
23234 whether this property is referencing a `base' method.
23236 * expression.cs (Invocation.EmitCall): take an extra argument:
23237 is_base, this is used to determine whether the `call' or
23238 `callvirt' opcode should be used.
23241 * delegate.cs: update EmitCall.
23243 * class.cs (Method.Define): Set NewSlot for the cases where we are
23244 not implementing an interface method.
23246 (Property.Define): ditto.
23248 2002-01-02 Miguel de Icaza <miguel@ximian.com>
23250 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
23251 'r'. Allows mcs to parse itself fully.
23253 2002-01-02 Ravi Pratap <ravi@ximian.com>
23255 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
23256 of the number of initializers that require the InitializeArray method.
23258 (CheckIndices): Store the Expression in all cases - not the plain value. Also
23259 update the above field where necessary.
23261 (MakeByteBlob): Update accordingly.
23263 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
23266 (EmitDynamicInitializers): Update in accordance with the new optimization.
23268 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
23269 same OpCode applies.
23271 * cs-parser.jay : Fix some glaring errors I introduced.
23273 2002-01-01 Ravi Pratap <ravi@ximian.com>
23275 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
23276 so that we can check for name clashes there too.
23278 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
23279 for interface indexers.
23281 * interfaces.cs (Define): Emit the default member attribute.
23283 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
23284 variable was being referred to while setting the value ;-)
23286 2002-01-01 Miguel de Icaza <miguel@ximian.com>
23288 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
23289 byte-by-byte information when we know the data is zero.
23291 Make the block always a multiple of 4, because
23292 DefineInitializedData has a bug.
23294 * assign.cs: Fix, we should assign from the temporary, not from
23297 * expression.cs (MakeByteBlob): Fix my incorrect code.
23299 2001-12-31 Miguel de Icaza <miguel@ximian.com>
23301 * typemanager.cs (EnumToUnderlying): This function is used to get
23302 the underlying type from an enumeration, because it does not
23305 * constant.cs: Use the I4_S form for values between -128 and 127.
23307 * statement.cs (Block.LookupLabel): Looks up a label.
23308 (Block): Drop support for labeled blocks.
23310 (LabeledStatement): New kind of statement that represents a label
23313 (Goto): Finally implement this bad boy.
23315 * cs-parser.jay: Update to reflect new mechanism to implement
23318 2001-12-30 Miguel de Icaza <miguel@ximian.com>
23320 * codegen.cs (EmitContext.This): a codegen property that keeps the
23321 a single instance of this instead of creating many different this
23324 * delegate.cs (Delegate.DoResolve): Update to use the property;
23326 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
23328 * expression.cs (BaseAccess.DoResolve): Ditto.
23330 2001-12-29 Ravi Pratap <ravi@ximian.com>
23332 * typemanager.cs (methodimpl_attr_type): Add to hold the type
23333 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
23335 (InitCoreTypes): Update accordingly.
23337 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
23338 so we can quickly store the state.
23340 (ApplyAttributes): Set the correct implementation flags
23341 for InternalCall methods.
23343 2001-12-29 Miguel de Icaza <miguel@ximian.com>
23345 * expression.cs (EmitCall): if a method is not virtual, then do
23346 not use callvirt on it.
23348 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
23349 user defined stuff) requires the use of stobj, which takes an
23350 address on the stack instead of an array and an index. So emit
23351 the Ldelema operation for it.
23353 (EmitStoreOpcode): Use stobj for valuetypes.
23355 (UnaryMutator.EmitCode): Use the right 1 value depending on
23356 whether we are dealing with int64/uint64, float or doubles.
23358 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
23359 constructors that I implemented last night.
23361 (Constructor.IsDefault): Fix to work properly for static
23364 * cs-parser.jay (CheckDef): report method signature errors.
23365 Update error number 103 to be 132.
23367 * decl.cs: New AdditionResult enumeration value: MethodExists.
23368 Although we do this check for methods later on in the semantic
23369 analysis, catching repeated default constructors is so easy that
23370 we catch these here.
23372 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
23375 (ParameterReference.EmitAssign, Emit): handle
23378 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
23379 (ArrayAccess.EmitStoreOpcode): ditto.
23381 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
23383 * expression.cs (MakeByteBlob): Complete all the missing types
23384 (uint, short, ushort, byte, sbyte)
23386 * class.cs: Only init instance field initializers on instance
23389 Rename `constructors' to instance_constructors.
23391 (TypeContainer.AddConstructor): Only add constructors to the list
23392 if it is not static.
23394 Make sure that we handle default_static_constructor independently
23395 everywhere where we handle instance_constructors
23397 2001-12-28 Miguel de Icaza <miguel@ximian.com>
23399 * class.cs: Do not lookup or create a base initializer for a
23400 static constructor.
23402 (ConstructorInitializer.Resolve): use the proper type to lookup
23405 * cs-parser.jay: Report error 1585 (modifiers between type and name).
23407 * enum.cs, interface.cs: Remove CloseType, this is taken care by
23410 * decl.cs: CloseType is now an virtual method, the default
23411 implementation just closes this type.
23413 2001-12-28 Ravi Pratap <ravi@ximian.com>
23415 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
23416 to PreserveSig by default. Also emit HideBySig on such methods.
23418 Basically, set the defaults to standard values.
23420 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
23421 argument, if candidate is better, it can't be worse than the best !
23423 (Invocation): Re-write bits to differentiate between methods being
23424 applicable in their expanded form and their normal form - for params
23427 Get rid of use_standard everywhere as only standard conversions are allowed
23428 in overload resolution.
23430 More spec conformance.
23432 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23434 * driver.cs: Add --timestamp, to see where the compiler spends
23437 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
23438 `this' in static code.
23440 (SimpleName.DoResolve): Implement in terms of a helper function
23441 that allows static-references to be passed upstream to
23444 (Expression.ResolveWithSimpleName): Resolve specially simple
23445 names when called by MemberAccess to implement the special
23448 (Expression.ImplicitReferenceConversion): Handle conversions from
23449 Null to reference types before others, as Null's type is
23452 * expression.cs (Invocation.EmitCall): Handle the special case of
23453 calling methods declared on a reference type from a ValueType
23454 (Base classes System.Object and System.Enum)
23456 (MemberAccess.Resolve): Only perform lookups on Enumerations if
23457 the left hand side is a TypeExpr, not on every enumeration.
23459 (Binary.Resolve): If types are reference types, then do a cast to
23460 object on operators != and == of both arguments.
23462 * typemanager.cs (FindMembers): Extract instance and static
23463 members if requested.
23465 * interface.cs (PopulateProperty): Use void_type instead of null
23466 as the return type for the setter method.
23468 (PopulateIndexer): ditto.
23470 2001-12-27 Ravi Pratap <ravi@ximian.com>
23472 * support.cs (ReflectionParameters): Fix minor bug where we
23473 were examining the wrong parameter for the ParamArray attribute.
23475 Cope with requests for the type of the parameter at position
23476 greater than the params parameter's. We now return the element
23477 type of the params array as that makes more sense.
23479 * expression.cs (Invocation.IsParamsMethodApplicable): Update
23480 accordingly as we no longer have to extract the element type
23483 (Invocation.OverloadResolve): Update.
23485 2001-12-27 Miguel de Icaza <miguel@ximian.com>
23487 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
23488 against IEnumerator, test whether the return value is a descendant
23489 of the IEnumerator interface.
23491 * class.cs (Indexer.Define): Use an auxiliary method to implement
23492 the other bits of the method definition. Begin support for
23493 explicit interface implementation.
23495 (Property.DefineMethod): Use TypeManager.void_type instead of null
23496 for an empty return value.
23498 2001-12-26 Miguel de Icaza <miguel@ximian.com>
23500 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
23501 dealing with a FieldExpr which is composed of a FieldBuilder, in
23502 the code path we did extract the constant, but we should have
23503 obtained the underlying value to be able to cast it (otherwise we
23504 end up in an infinite loop, this is what Ravi was running into).
23506 (ArrayCreation.UpdateIndices): Arrays might be empty.
23508 (MemberAccess.ResolveMemberAccess): Add support for section
23509 14.5.4.1 that deals with the special case of E.I when E is a type
23510 and something else, that I can be a reference to a static member.
23512 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
23513 handle a particular array type to create byte blobs, it is just
23514 something we dont generate byteblobs for.
23516 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
23519 * location.cs (Push): remove the key from the hashtable that we
23520 are about to add. This happens for empty files.
23522 * driver.cs: Dispose files after we have parsed them.
23524 (tokenize): new function that only runs the tokenizer on its
23525 input, for speed testing.
23527 2001-12-26 Ravi Pratap <ravi@ximian.com>
23529 * class.cs (Event.Define): Define the private field only if there
23530 are no accessors defined.
23532 * expression.cs (ResolveMemberAccess): If there is no associated
23533 field with the event, that means we have an event defined with its
23534 own accessors and we should flag error cs0070 since transforming
23535 ourselves into a field is not valid in that case.
23537 * ecore.cs (SimpleName.DoResolve): Same as above.
23539 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
23540 and charset to sane values.
23542 2001-12-25 Ravi Pratap <ravi@ximian.com>
23544 * assign.cs (DoResolve): Perform check on events only if they
23545 are being accessed outside the declaring type.
23547 * cs-parser.jay (event_declarations): Update rules to correctly
23548 set the type of the implicit parameter etc.
23550 (add_accessor, remove_accessor): Set current local parameters.
23552 * expression.cs (Binary): For delegate addition and subtraction,
23553 cast the return value from the method into the appropriate delegate
23556 2001-12-24 Ravi Pratap <ravi@ximian.com>
23558 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
23559 of these as the workaround is unnecessary.
23561 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
23562 delegate data - none of that is needed at all.
23564 Re-write bits to extract the instance expression and the delegate method
23567 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
23570 * attribute.cs (ApplyAttributes): New method to take care of common tasks
23571 of attaching attributes instead of duplicating code everywhere.
23573 * everywhere : Update code to do attribute emission using the above method.
23575 2001-12-23 Miguel de Icaza <miguel@ximian.com>
23577 * expression.cs (IsParamsMethodApplicable): if there are not
23578 parameters, return immediately.
23580 * ecore.cs: The 0 literal can be implicity converted to an enum
23583 (SimpleName.DoResolve): First lookup the type, then lookup the
23586 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
23587 want to get its address. If the InstanceExpression is not
23588 addressable, store the result in a temporary variable, then get
23591 * codegen.cs: Only display 219 errors on warning level or above.
23593 * expression.cs (ArrayAccess): Make it implement the
23594 IMemoryLocation interface.
23596 (Binary.DoResolve): handle the operator == (object a, object b)
23597 and operator != (object a, object b) without incurring into a
23598 BoxedCast (because 5 != o should never be performed).
23600 Handle binary enumerator operators.
23602 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
23603 value type, otherwise use Ldelem_ref.
23605 Use precomputed names;
23607 (AddressOf): Implement address of
23609 * cs-parser.jay (labeled_statement): Fix recursive block
23610 addition by reworking the production.
23612 * expression.cs (New.DoEmit): New has a special case:
23614 If we are dealing with a ValueType, we have a few
23615 situations to deal with:
23617 * The target of New is a ValueType variable, that is
23618 easy, we just pass this as the variable reference
23620 * The target of New is being passed as an argument,
23621 to a boxing operation or a function that takes a
23624 In this case, we need to create a temporary variable
23625 that is the argument of New.
23628 2001-12-23 Ravi Pratap <ravi@ximian.com>
23630 * rootcontext.cs (LookupType): Check that current_type is not null before
23631 going about looking at nested types.
23633 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
23634 not implement the IAssignMethod interface any more.
23636 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
23637 where we tranform them into FieldExprs if they are being resolved from within
23638 the declaring type.
23640 * ecore.cs (SimpleName.DoResolve): Do the same here.
23642 * assign.cs (DoResolve, Emit): Clean up code considerably.
23644 * ../errors/bug10.cs : Add.
23646 * ../errors/cs0070.cs : Add.
23648 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
23650 * assign.cs : Get rid of EventIsLocal everywhere.
23652 2001-12-23 Miguel de Icaza <miguel@ximian.com>
23654 * ecore.cs (ConvertIntLiteral): finished the implementation.
23656 * statement.cs (SwitchLabel): Convert the value we are using as a
23657 key before looking up the table.
23659 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23661 * codegen.cs (EmitTopBlock): Require a Location argument now.
23663 * cs-parser.jay (constructor_declarator): We need to setup
23664 current_local_parameters before we parse the
23665 opt_constructor_initializer, to allow the variables to be bound
23666 to the constructor arguments.
23668 * rootcontext.cs (LookupType): First lookup nested classes in our
23669 class and our parents before we go looking outside our class.
23671 * expression.cs (ConstantFold): Extract/debox the values at the
23674 * rootcontext.cs (EmitCode): Resolve the constants first before we
23675 resolve the types. This is not really needed, but it helps debugging.
23677 * statement.cs: report location.
23679 * cs-parser.jay: pass location to throw statement.
23681 * driver.cs: Small bug fix.
23683 * report.cs: Updated format to be 4-zero filled digits.
23685 2001-12-22 Ravi Pratap <ravi@ximian.com>
23687 * expression.cs (CheckIndices): Fix minor bug where the wrong
23688 variable was being referred to ;-)
23690 (DoEmit): Do not call EmitStaticInitializers when the
23691 underlying type is System.Object.
23693 2001-12-21 Ravi Pratap <ravi@ximian.com>
23695 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
23696 and do the usual workaround for SRE.
23698 * class.cs (MyEventBuilder.EventType): New member to get at the type
23699 of the event, quickly.
23701 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
23703 * assign.cs (Assign.DoResolve): Handle the case when the target
23704 is an EventExpr and perform the necessary checks.
23706 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
23709 (SimpleName.MemberStaticCheck): Include check for EventExpr.
23711 (EventExpr): Set the type in the constructor itself since we
23712 are meant to be born fully resolved.
23714 (EventExpr.Define): Revert code I wrote earlier.
23716 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
23717 instance expression is null. The instance expression is a This in that case
23718 or a null, depending on whether it is a static method or not.
23720 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
23721 refers to more than one method.
23723 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
23724 and accordingly flag errors.
23726 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23728 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
23730 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23732 * location.cs (ToString): Provide useful rutine.
23734 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23736 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
23737 objects, return the actual integral boxed.
23739 * statement.cs (SwitchLabel): define an ILLabel for each
23742 (Switch.CheckSwitch): If the value is a Literal, extract
23743 the underlying literal.
23745 Also in the unused hashtable we had, add the SwitchLabel so we can
23746 quickly look this value up.
23748 * constant.cs: Implement a bunch of new constants. Rewrite
23749 Literal based on this. Made changes everywhere to adapt to this.
23751 * expression.cs (Expression.MakeByteBlob): Optimize routine by
23752 dereferencing array only once, and also copes with enumrations.
23754 bytes are two bytes wide, not one.
23756 (Cast): Perform constant conversions.
23758 * ecore.cs (TryImplicitIntConversion): Return literals instead of
23759 wrappers to the literals here.
23761 * expression.cs (DoNumericPromotions): long literals can converted
23762 to ulong implicity (this is taken care of elsewhere, but I was
23763 missing this spot).
23765 * ecore.cs (Expression.Literalize): Make the return type Literal,
23766 to improve type checking.
23768 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
23770 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23772 * literal.cs: Revert code from ravi that checked the bounds. The
23773 bounds are sane by the definition of the type itself.
23775 * typemanager.cs: Fix implementation of ImplementsInterface. We
23776 need to actually look up in our parent hierarchy for interfaces
23779 * const.cs: Use the underlying type for enumerations
23781 * delegate.cs: Compute the basename for the delegate creation,
23782 that should fix the delegate test case, and restore the correct
23783 Type Lookup semantics in rootcontext
23785 * rootcontext.cs: Revert Ravi's last patch. The correct way of
23786 referencing a nested type with the Reflection API is using the "+"
23789 * cs-parser.jay: Do not require EOF token at the end.
23791 2001-12-20 Ravi Pratap <ravi@ximian.com>
23793 * rootcontext.cs (LookupType): Concatenate type names with
23794 a '.' instead of a '+' The test suite passes again.
23796 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
23797 field of the enumeration.
23799 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
23800 the case when the member is an EventExpr.
23802 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
23803 static has an associated instance expression.
23805 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
23807 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
23809 * class.cs (Event.Define): Register event and perform appropriate checks
23812 We define the Add and Remove methods even if the use provides none because
23813 in that case, we provide default implementations ourselves.
23815 Define a private field of the type of the event. This is done by the CSC compiler
23816 and we should be doing it too ;-)
23818 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
23819 More methods we use in code we generate.
23821 (multicast_delegate_type, delegate_type): Two separate types since the distinction
23824 (InitCoreTypes): Update accordingly for the above.
23826 * class.cs (Event.Emit): Generate code for default accessors that we provide
23828 (EmitDefaultMethod): Do the job in the above.
23830 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
23833 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23835 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
23836 builders even if we were missing one.
23838 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
23839 pass the Basename as our class name instead of the Name. The
23840 basename will be correctly composed for us.
23842 * parameter.cs (Paramters): Now takes a Location argument.
23844 * decl.cs (DeclSpace.LookupType): Removed convenience function and
23845 make all the code call directly LookupType in RootContext and take
23846 this chance to pass the Location information everywhere.
23848 * Everywhere: pass Location information.
23850 2001-12-19 Miguel de Icaza <miguel@ximian.com>
23852 * class.cs (Constructor.Define): Updated way of detecting the
23853 length of the parameters.
23855 (TypeContainer.DefineType): Use basename as the type name for
23858 (TypeContainer.Define): Do not recursively define types here, as
23859 definition is taken care in order by the RootContext.
23861 * tree.cs: Keep track of namespaces in a per-file basis.
23863 * parameter.cs (Parameter.ComputeSignature): Update to use
23866 (Parameters.GetSignature): ditto.
23868 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
23869 instead of a TypeContainer.
23871 (Interface.SemanticAnalysis): Use `this' instead of our parent to
23872 resolve names. Because we need to be resolve in our context, not
23875 * driver.cs: Implement response files.
23877 * class.cs (TypeContainer.DefineType): If we are defined, do not
23878 redefine ourselves.
23880 (Event.Emit): Emit the code for add/remove handlers.
23881 (Event.Define): Save the MethodBuilders for add/remove.
23883 * typemanager.cs: Use pair here too.
23885 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
23886 DictionaryEntry requires the first argument to be non-null.
23888 (enum_declaration): Compute full name for registering the
23891 (delegate_declaration): Instead of using
23892 formal_parameter_list, use opt_formal_parameter_list as the list
23895 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
23896 (EventParsing): New property that controls whether `add' and
23897 `remove' are returned as tokens or identifiers (for events);
23899 2001-12-19 Ravi Pratap <ravi@ximian.com>
23901 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
23902 use MyEventBuilder only and let it wrap the real builder for us.
23904 (MyEventBuilder): Revamp constructor etc.
23906 Implement all operations that we perform on EventBuilder in precisely the same
23909 (FindMembers): Update to use the EventBuilder member.
23911 (Event.Emit): Update accordingly.
23913 2001-12-18 Ravi Pratap <ravi@ximian.com>
23915 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
23916 by calling the appropriate methods.
23918 (GetCustomAttributes): Make stubs as they cannot possibly do anything
23921 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
23923 2001-12-17 Ravi Pratap <ravi@ximian.com>
23925 * delegate.cs (Delegate.Populate): Check that the return type
23926 and various parameters types are indeed accessible.
23928 * class.cs (Constructor.Define): Same here.
23930 (Field.Define): Ditto.
23932 (Event.Define): Ditto.
23934 (Operator.Define): Check that the underlying Method defined itself
23935 correctly - so it's MethodBuilder should not be null.
23937 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
23938 expression happens to be null.
23940 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
23941 members but as of now we don't seem to be able to do anything really useful with it.
23943 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
23944 not the EventBuilder.
23946 2001-12-18 Miguel de Icaza <miguel@ximian.com>
23948 * cs-tokenizer.cs: Add support for defines.
23949 Add support for #if, #elif, #else, #endif
23951 (eval_var): evaluates a variable.
23952 (eval): stubbed for evaluating functions.
23954 * cs-parser.jay: Pass the defines information
23956 * driver.cs: Add --define command line option.
23958 * decl.cs: Move MemberCore here.
23960 Make it the base class for DeclSpace. This allows us to catch and
23961 report 108 and 109 for everything now.
23963 * class.cs (TypeContainer.Define): Extract all the members
23964 before populating and emit the warning 108 (new keyword required
23965 to override) instead of having each member implement this.
23967 (MemberCore.Define): New abstract method, we will be using this in
23968 the warning reporting engine in Populate.
23970 (Operator.Define): Adjust to new MemberCore protocol.
23972 * const.cs (Const): This does not derive from Expression, it is a
23973 temporary object we use to create fields, it is a MemberCore.
23975 * class.cs (Method.Define): Allow the entry point to be in a
23978 * driver.cs: Rewrite the argument handler to clean it up a bit.
23980 * rootcontext.cs: Made it just an auxiliary namespace feature by
23981 making everything static.
23983 * driver.cs: Adapt code to use RootContext type name instead of
23986 * delegate.cs: Remove RootContext argument.
23988 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
23991 * class.cs (Event.Define): The lookup can fail.
23993 * cs-tokenizer.cs: Begin implementation of pre-procesor.
23995 * expression.cs: Resolve the this instance before invoking the code.
23997 2001-12-17 Miguel de Icaza <miguel@ximian.com>
23999 * cs-parser.jay: Add a production in element_access that allows
24000 the thing to become a "type" reference. This way we can parse
24001 things like "(string [])" as a type.
24003 Note that this still does not handle the more complex rules of
24007 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
24009 * ecore.cs: (CopyNewMethods): new utility function used to
24010 assemble the list of methods from running FindMembers.
24012 (MemberLookup): Rework FindMembers so that
24014 2001-12-16 Miguel de Icaza <miguel@ximian.com>
24016 * class.cs (TypeContainer): Remove Delegates who fail to be
24019 * delegate.cs (Populate): Verify that we dont get null return
24020 values. TODO: Check for AsAccessible.
24022 * cs-parser.jay: Use basename to emit error 574 (destructor should
24023 have the same name as container class), not the full name.
24025 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
24026 possible representation.
24028 Also implements integer type suffixes U and L.
24030 2001-12-15 Miguel de Icaza <miguel@ximian.com>
24032 * expression.cs (ArrayCreation.DoResolve): We need to do the
24033 argument resolution *always*.
24035 * decl.cs: Make this hold the namespace. Hold the root context as
24037 (LookupType): Move here.
24039 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
24041 * location.cs (Row, Name): Fixed the code, it was always returning
24042 references to the first file.
24044 * interface.cs: Register properties defined through interfaces.
24046 * driver.cs: Add support for globbing on the command line
24048 * class.cs (Field): Make it derive from MemberCore as well.
24051 2001-12-15 Ravi Pratap <ravi@ximian.com>
24053 * class.cs (Event::Define): Check that the type of the event is a delegate
24054 type else flag error #66.
24056 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
24059 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
24060 values of EntryPoint, CharSet etc etc.
24062 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
24064 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
24065 be null and we should ignore this. I am not sure if this is really clean. Apparently,
24066 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
24067 which needs this to do its work.
24069 * ../errors/cs0066.cs : Add.
24071 2001-12-14 Miguel de Icaza <miguel@ximian.com>
24073 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
24076 * class.cs: (MethodSignature.MethodSignature): Removed hack that
24077 clears out the parameters field.
24078 (MemberSignatureCompare): Cleanup
24080 (MemberCore): New base class used to share code between MethodCore
24083 (RegisterRequiredImplementations) BindingFlags.Public requires
24084 either BindingFlags.Instace or Static. Use instance here.
24086 (Property): Refactored code to cope better with the full spec.
24088 * parameter.cs (GetParameterInfo): Return an empty array instead
24091 * class.cs (Property): Abstract or extern properties have no bodies.
24093 * parameter.cs (GetParameterInfo): return a zero-sized array.
24095 * class.cs (TypeContainer.MethodModifiersValid): Move all the
24096 method modifier validation to the typecontainer so we can reuse
24097 this on properties.
24099 (MethodCore.ParameterTypes): return an empty sized array of types.
24101 (Property.Define): Test property modifier validity.
24103 Add tests for sealed/override too.
24105 (Method.Emit): abstract or extern methods have no bodies.
24107 2001-12-14 Ravi Pratap <ravi@ximian.com>
24109 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
24112 (Method::Define, ::Emit): Modify accordingly.
24114 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
24116 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
24118 * makefile: Pass in /unsafe.
24120 2001-12-13 Miguel de Icaza <miguel@ximian.com>
24122 * class.cs (MakeKey): Kill routine.
24124 * class.cs (TypeContainer.Define): Correctly define explicit
24125 method implementations (they require the full interface name plus
24128 * typemanager.cs: Deply the PtrHashtable here and stop using the
24129 lame keys. Things work so much better.
24131 This of course broke everyone who depended on `RegisterMethod' to
24132 do the `test for existance' test. This has to be done elsewhere.
24134 * support.cs (PtrHashtable): A hashtable that avoid comparing with
24135 the object stupid Equals method (because, that like fails all over
24136 the place). We still do not use it.
24138 * class.cs (TypeContainer.SetRequiredInterface,
24139 TypeContainer.RequireMethods): Killed these two routines and moved
24140 all the functionality to RegisterRequiredImplementations.
24142 (TypeContainer.RegisterRequiredImplementations): This routine now
24143 registers all the implementations required in an array for the
24144 interfaces and abstract methods. We use an array of structures
24145 which can be computed ahead of time to reduce memory usage and we
24146 also assume that lookups are cheap as most classes will not
24147 implement too many interfaces.
24149 We also avoid creating too many MethodSignatures.
24151 (TypeContainer.IsInterfaceMethod): Update and optionally does not
24152 clear the "pending" bit if we find that there are problems with
24155 (TypeContainer.VerifyPendingMethods): Update to report errors of
24156 methods that look like implementations but are not.
24158 (TypeContainer.Define): Add support for explicit interface method
24161 2001-12-12 Miguel de Icaza <miguel@ximian.com>
24163 * typemanager.cs: Keep track of the parameters here instead of
24164 being a feature of the TypeContainer.
24166 * class.cs: Drop the registration of parameters here, as
24167 InterfaceMethods are also interface declarations.
24169 * delegate.cs: Register methods with the TypeManager not only with
24170 the TypeContainer. This code was buggy.
24172 * interface.cs: Full registation here.
24174 2001-12-11 Miguel de Icaza <miguel@ximian.com>
24176 * expression.cs: Remove reducer for binary expressions, it can not
24179 * const.cs: Put here the code that used to go into constant.cs
24181 * constant.cs: Put here the code for constants, this is a new base
24182 class for Literals.
24184 * literal.cs: Make Literal derive from Constant.
24186 2001-12-09 Miguel de Icaza <miguel@ximian.com>
24188 * statement.cs (Return.Emit): Report error 157 if the user
24189 attempts to return from a finally block.
24191 (Return.Emit): Instead of emitting a return, jump to the end of
24194 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
24195 LocalBuilder to store the result of the function. ReturnLabel is
24196 the target where we jump.
24199 2001-12-09 Radek Doulik <rodo@ximian.com>
24201 * cs-parser.jay: remember alias in current namespace
24203 * ecore.cs (SimpleName::DoResolve): use aliases for types or
24206 * class.cs (LookupAlias): lookup alias in my_namespace
24208 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
24210 (LookupAlias): lookup alias in this and if needed in parent
24213 2001-12-08 Miguel de Icaza <miguel@ximian.com>
24217 * rootcontext.cs: (ModuleBuilder) Made static, first step into
24218 making things static. I need this to avoid passing the
24219 TypeContainer when calling ParameterType.
24221 * support.cs (InternalParameters.ParameterType): Remove ugly hack
24222 that did string manipulation to compute the type and then call
24223 GetType. Use Parameter.ParameterType instead.
24225 * cs-tokenizer.cs: Consume the suffix for floating values.
24227 * expression.cs (ParameterReference): figure out whether this is a
24228 reference parameter or not. Kill an extra variable by computing
24229 the arg_idx during emission.
24231 * parameter.cs (Parameters.GetParameterInfo): New overloaded
24232 function that returns whether a parameter is an out/ref value or not.
24234 (Parameter.ParameterType): The type of the parameter (base,
24235 without ref/out applied).
24237 (Parameter.Resolve): Perform resolution here.
24238 (Parameter.ExternalType): The full type (with ref/out applied).
24240 * statement.cs (Using.Emit, Using.EmitExpression): Implement
24241 support for expressions on the using statement.
24243 2001-12-07 Miguel de Icaza <miguel@ximian.com>
24245 * statement.cs (Using.EmitLocalVariableDecls): Split the
24246 localvariable handling of the using statement.
24248 (Block.EmitMeta): Keep track of variable count across blocks. We
24249 were reusing slots on separate branches of blocks.
24251 (Try.Emit): Emit the general code block, we were not emitting it.
24253 Check the type of the declaration to be an IDisposable or
24254 something that can be implicity converted to it.
24256 Emit conversions if required.
24258 * ecore.cs (EmptyExpression): New utility class.
24259 (Expression.ImplicitConversionExists): New utility function.
24261 2001-12-06 Miguel de Icaza <miguel@ximian.com>
24263 * statement.cs (Using): Implement.
24265 * expression.cs (LocalVariableReference): Support read only variables.
24267 * statement.cs: Remove the explicit emit for the Leave opcode.
24268 (VariableInfo): Add a readonly field.
24270 2001-12-05 Miguel de Icaza <miguel@ximian.com>
24272 * ecore.cs (ConvCast): new class used to encapsulate the various
24273 explicit integer conversions that works in both checked and
24274 unchecked contexts.
24276 (Expression.ConvertNumericExplicit): Use new ConvCast class to
24277 properly generate the overflow opcodes.
24279 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24281 * statement.cs: The correct type for the EmptyExpression is the
24282 element_type, not the variable type. Ravi pointed this out.
24284 2001-12-04 Ravi Pratap <ravi@ximian.com>
24286 * class.cs (Method::Define): Handle PInvoke methods specially
24287 by using DefinePInvokeMethod instead of the usual one.
24289 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
24290 above to do the task of extracting information and defining the method.
24292 2001-12-04 Ravi Pratap <ravi@ximian.com>
24294 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
24295 of the condition for string type.
24297 (Emit): Move that here.
24299 (ArrayCreation::CheckIndices): Keep string literals in their expression
24302 (EmitDynamicInitializers): Handle strings appropriately.
24304 2001-12-04 Miguel de Icaza <miguel@ximian.com>
24306 * codegen.cs (EmitContext): Replace multiple variables with a
24307 single pointer to the current Switch statement.
24309 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
24312 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24316 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
24319 (Foreach.Emit): Foreach on arrays was not setting
24320 up the loop variables (for break/continue).
24322 (GotoCase): Semi-implented.
24324 2001-12-03 Ravi Pratap <ravi@ximian.com>
24326 * attribute.cs (CheckAttribute): Handle system attributes by using
24327 Attribute.GetAttributes to examine information we need.
24329 (GetValidPlaces): Same here.
24331 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
24333 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
24335 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
24337 (Method::Define): Set appropriate flags if we have a DllImport attribute.
24339 (Method::Emit): Handle the case when we are a PInvoke method.
24341 2001-12-03 Miguel de Icaza <miguel@ximian.com>
24343 * expression.cs: Use ResolveWithSimpleName on compound names.
24345 2001-12-02 Ravi Pratap <ravi@ximian.com>
24347 * constant.cs (EmitConstant): Make sure we resolve the associated expression
24348 before trying to reduce it.
24350 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
24352 * constant.cs (LookupConstantValue): Implement.
24354 (EmitConstant): Use the above in emitting the constant.
24356 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
24357 that are user-defined by doing a LookupConstantValue on them.
24359 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
24362 2001-11-29 Miguel de Icaza <miguel@ximian.com>
24364 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
24366 (BaseAccess.DoResolve): Implement.
24368 (MemberAccess.DoResolve): Split this routine into a
24369 ResolveMemberAccess routine that can be used independently
24371 2001-11-28 Miguel de Icaza <miguel@ximian.com>
24373 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
24374 As that share bits of the implementation. Is returns a boolean,
24375 while As returns the Type that is being probed.
24377 2001-12-01 Ravi Pratap <ravi@ximian.com>
24379 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
24380 instead of a Literal - much easier.
24382 (EnumInTransit): Remove - utterly useless :-)
24384 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
24386 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
24388 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
24389 chain when we have no associated expression.
24391 2001-11-30 Ravi Pratap <ravi@ximian.com>
24393 * constant.cs (Define): Use Location while reporting the errror.
24395 Also emit a warning when 'new' is used and there is no inherited
24398 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
24401 (LookupEnumValue): Implement to lookup an enum member's value and define it
24404 (Populate): Re-write accordingly to use the above routine.
24406 2001-11-27 Miguel de Icaza <miguel@ximian.com>
24408 * expression.cs (This): Fix prototype for DoResolveLValue to
24409 override the base class DoResolveLValue.
24411 * cs-parser.cs: Report errors cs574 and cs575 (destructor
24414 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
24415 (we need to load the address of the field here). This fixes
24418 (FieldExpr.DoResolveLValue): Call the DoResolve
24419 function to initialize the Instance expression.
24421 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
24422 correctly the GetEnumerator operation on a value type.
24424 * cs-parser.jay: Add more simple parsing error catches.
24426 * statement.cs (Switch): Add support for string switches.
24427 Handle null specially.
24429 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
24431 2001-11-28 Ravi Pratap <ravi@ximian.com>
24433 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
24435 (declare_local_constant): New helper function.
24437 * statement.cs (AddConstant): Keep a separate record of constants
24439 (IsConstant): Implement to determine if a variable is a constant.
24441 (GetConstantExpression): Implement.
24443 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
24445 * statement.cs (IsVariableDefined): Re-write.
24447 2001-11-27 Ravi Pratap <ravi@ximian.com>
24449 * class.cs (TypeContainer::FindMembers): Look for constants
24450 in the case when we are looking for MemberTypes.Field
24452 * expression.cs (MemberAccess::DoResolve): Check that in the
24453 case we are a FieldExpr and a Literal, we are not being accessed
24454 by an instance reference.
24456 * cs-parser.jay (local_constant_declaration): Implement.
24458 (declaration_statement): Implement for constant declarations.
24460 2001-11-26 Miguel de Icaza <miguel@ximian.com>
24462 * statement.cs (Switch): Catch double defaults.
24464 (Switch): More work on the switch() statement
24465 implementation. It works for integral values now, need to finish
24469 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24471 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
24472 integer literals into other integer literals. To be used by
24475 2001-11-24 Ravi Pratap <ravi@ximian.com>
24477 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
24480 (EmitDynamicInitializers): Cope with the above since we extract data
24481 directly from ArrayData now.
24483 (ExpectInitializers): Keep track of whether initializers are mandatory
24486 (Bounds): Make it a hashtable to prevent the same dimension being
24487 recorded for every element in that dimension.
24489 (EmitDynamicInitializers): Fix bug which prevented the Set array method
24492 Also fix bug which was causing the indices to be emitted in the reverse
24495 2001-11-24 Miguel de Icaza <miguel@ximian.com>
24497 * expression.cs (ArrayCreation): Implement the bits that Ravi left
24498 unfinished. They do not work, because the underlying code is
24501 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24503 * cs-parser.jay: Remove bogus fixme.
24505 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
24506 on Switch statement.
24508 2001-11-23 Ravi Pratap <ravi@ximian.com>
24510 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
24513 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
24514 parameter. Apparently, any expression is allowed.
24516 (ValidateInitializers): Update accordingly.
24518 (CheckIndices): Fix some tricky bugs thanks to recursion.
24520 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
24521 I was being completely brain-dead.
24523 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
24524 and re-write acordingly.
24526 (DelegateInvocation): Re-write accordingly.
24528 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
24530 (MakeByteBlob): Handle types more correctly.
24532 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
24533 initialization from expressions but it is incomplete because I am a complete
24536 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24538 * statement.cs (If.Emit): Fix a bug that generated incorrect code
24539 on If. Basically, we have to return `true' (ie, we do return to
24540 our caller) only if both branches of the if return.
24542 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
24543 short-circuit operators, handle them as short circuit operators.
24545 (Cast.DoResolve): Resolve type.
24546 (Cast.Cast): Take an expression as the target type.
24548 * cs-parser.jay (cast_expression): Remove old hack that only
24549 allowed a limited set of types to be handled. Now we take a
24550 unary_expression and we resolve to a type during semantic
24553 Use the grammar productions from Rhys to handle casts (this is
24554 not complete like Rhys syntax yet, we fail to handle that corner
24555 case that C# has regarding (-x), but we will get there.
24557 2001-11-22 Ravi Pratap <ravi@ximian.com>
24559 * class.cs (EmitFieldInitializer): Take care of the case when we have a
24560 field which is an array type.
24562 * cs-parser.jay (declare_local_variables): Support array initialization too.
24564 * typemanager.cs (MakeKey): Implement.
24566 (everywhere): Use the above appropriately.
24568 * cs-parser.jay (for_statement): Update for array initialization while
24569 declaring variables.
24571 * ecore.cs : The error message was correct, it's the variable's names that
24572 were misleading ;-) Make the code more readable.
24574 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
24575 the correct type etc.
24577 (ConvertExplicit): Handle Enum types by examining the underlying type.
24579 2001-11-21 Ravi Pratap <ravi@ximian.com>
24581 * parameter.cs (GetCallingConvention): Always return
24582 CallingConventions.Standard for now.
24584 2001-11-22 Miguel de Icaza <miguel@ximian.com>
24586 * expression.cs (Binary.ResolveOperator): Update the values of `l'
24587 and `r' after calling DoNumericPromotions.
24589 * ecore.cs: Fix error message (the types were in the wrong order).
24591 * statement.cs (Foreach.ProbeCollectionType): Need to pass
24592 BindingFlags.Instance as well
24594 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
24595 implicit int literal conversion in an empty cast so that we
24596 propagate the right type upstream.
24598 (UnboxCast): new class used to unbox value types.
24599 (Expression.ConvertExplicit): Add explicit type conversions done
24602 (Expression.ImplicitNumericConversion): Oops, forgot to test for
24603 the target type before applying the implicit LongLiterals to ULong
24606 2001-11-21 Miguel de Icaza <miguel@ximian.com>
24608 * cs-parser.jay (for_statement): Reworked the way For works: now
24609 we declare manually any variables that are introduced in
24610 for_initializer to solve the problem of having out-of-band code
24611 emition (that is what got for broken).
24613 (declaration_statement): Perform the actual variable declaration
24614 that used to be done in local_variable_declaration here.
24616 (local_variable_declaration): Do not declare anything, just pass
24617 the information on a DictionaryEntry
24619 2001-11-20 Ravi Pratap <ravi@ximian.com>
24621 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
24622 re-write of the logic to now make it recursive.
24624 (UpdateIndices): Re-write accordingly.
24626 Store element data in a separate ArrayData list in the above methods.
24628 (MakeByteBlob): Implement to dump the array data into a byte array.
24630 2001-11-19 Ravi Pratap <ravi@ximian.com>
24632 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
24635 * constant.cs (Define): Implement.
24637 (EmitConstant): Re-write fully.
24639 Pass in location info.
24641 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
24644 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
24645 DictionaryEntry since we need location info too.
24647 (constant_declaration): Update accordingly.
24649 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
24650 code into another method : UpdateIndices.
24652 2001-11-18 Ravi Pratap <ravi@ximian.com>
24654 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
24655 some type checking etc.
24657 2001-11-17 Ravi Pratap <ravi@ximian.com>
24659 * expression.cs (ArrayCreation::ValidateInitializers): Implement
24660 bits to provide dimension info if the user skips doing that.
24662 Update second constructor to store the rank correctly.
24664 2001-11-16 Ravi Pratap <ravi@ximian.com>
24666 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
24667 and try to implement.
24669 * ../errors/cs0150.cs : Add.
24671 * ../errors/cs0178.cs : Add.
24673 2001-11-16 Miguel de Icaza <miguel@ximian.com>
24675 * statement.cs: Implement foreach on multi-dimensional arrays.
24677 * parameter.cs (Parameters.GetParameterByName): Also lookup the
24678 name of the params argument.
24680 * expression.cs: Use EmitStoreOpcode to get the right opcode while
24681 initializing the array.
24683 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
24684 we can use this elsewhere.
24686 * statement.cs: Finish implementation of foreach for single
24689 * cs-parser.jay: Use an out-of-band stack to pass information
24690 around, I wonder why I need this.
24692 foreach_block: Make the new foreach_block the current_block.
24694 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
24695 function used to return a static Parameters structure. Used for
24696 empty parameters, as those are created very frequently.
24698 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
24700 2001-11-15 Ravi Pratap <ravi@ximian.com>
24702 * interface.cs : Default modifier is private, not public. The
24703 make verify test passes again.
24705 2001-11-15 Ravi Pratap <ravi@ximian.com>
24707 * support.cs (ReflectionParameters): Fix logic to determine
24708 whether the last parameter is a params one. Test 9 passes again.
24710 * delegate.cs (Populate): Register the builders we define with
24711 RegisterParameterForBuilder. Test 19 passes again.
24713 * cs-parser.jay (property_declaration): Reference $6 instead
24714 of $$ to get at the location.
24716 (indexer_declaration): Similar stuff.
24718 (attribute): Ditto.
24720 * class.cs (Property): Register parameters for the Get and Set methods
24721 if they exist. Test 23 passes again.
24723 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
24724 call to EmitArguments as we are sure there aren't any params arguments.
24725 Test 32 passes again.
24727 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
24728 IndexOutOfRangeException.
24730 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
24731 Test 33 now passes again.
24733 2001-11-15 Miguel de Icaza <miguel@ximian.com>
24735 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
24736 broke a bunch of things. Will have to come up with a better way
24737 of tracking locations.
24739 * statement.cs: Implemented foreach for single dimension arrays.
24741 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24743 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
24744 an error. This removes the lookup from the critical path.
24746 * cs-parser.jay: Removed use of temporary_loc, which is completely
24749 2001-11-14 Miguel de Icaza <miguel@ximian.com>
24751 * support.cs (ReflectionParameters.ParameterModifier): Report
24752 whether the argument is a PARAMS argument or not.
24754 * class.cs: Set the attribute `ParamArrayAttribute' on the
24755 parameter argument.
24757 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
24758 and cons_param_array_attribute (ConstructorInfo for
24759 ParamArrayAttribute).,
24761 * codegen.cs: Emit the return using the `Return' statement, that
24762 way we can report the error correctly for missing return values.
24764 * class.cs (Method.Emit): Clean up.
24766 * expression.cs (Argument.Resolve): Take another argument: the
24767 location where this argument is used. Notice that this is not
24768 part of the "Argument" class as to reduce the size of the
24769 structure (we know the approximate location anyways).
24771 Test if the argument is a variable-reference, if not, then
24772 complain with a 206.
24774 (Argument.Emit): Emit addresses of variables.
24776 (Argument.FullDesc): Simplify.
24778 (Invocation.DoResolve): Update for Argument.Resolve.
24780 (ElementAccess.DoResolve): ditto.
24782 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
24783 method should be virtual, as this method is always virtual.
24785 (NewDelegate.DoResolve): Update for Argument.Resolve.
24787 * class.cs (ConstructorInitializer.DoResolve): ditto.
24789 * attribute.cs (Attribute.Resolve): ditto.
24791 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24793 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
24795 * expression.cs (ParameterReference): Drop IStackStorage and implement
24796 IAssignMethod instead.
24798 (LocalVariableReference): ditto.
24800 * ecore.cs (FieldExpr): Drop IStackStorage and implement
24801 IAssignMethod instead.
24803 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24805 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
24806 enumerations that are used in heavily used structures derive from
24807 byte in a laughable and pathetic attempt to reduce memory usage.
24808 This is the kind of pre-optimzations that you should not do at
24809 home without adult supervision.
24811 * expression.cs (UnaryMutator): New class, used to handle ++ and
24812 -- separatedly from the other unary operators. Cleans up the
24813 code, and kills the ExpressionStatement dependency in Unary.
24815 (Unary): Removed `method' and `Arguments' from this class, making
24816 it smaller, and moving it all to SimpleCall, so I can reuse this
24817 code in other locations and avoid creating a lot of transient data
24818 strucutres when not required.
24820 * cs-parser.jay: Adjust for new changes.
24822 2001-11-11 Miguel de Icaza <miguel@ximian.com>
24824 * enum.cs (Enum.Populate): If there is a failure during
24827 * cs-parser.jay (opt_enum_base): we used to catch type errors
24828 here, but this is really incorrect. The type error should be
24829 catched during semantic analysis.
24831 2001-12-11 Ravi Pratap <ravi@ximian.com>
24833 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
24834 current_local_parameters as expected since I, in my stupidity, had forgotten
24837 * attribute.cs (GetValidPlaces): Fix stupid bug.
24839 * class.cs (Method::Emit): Perform check on applicability of attributes.
24841 (Constructor::Emit): Ditto.
24843 (Field::Emit): Ditto.
24845 (Field.Location): Store location information.
24847 (Property, Event, Indexer, Operator): Ditto.
24849 * cs-parser.jay (field_declaration): Pass in location for each field.
24851 * ../errors/cs0592.cs : Add.
24853 2001-11-12 Ravi Pratap <ravi@ximian.com>
24855 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
24857 (InitCoreTypes): Update accordingly.
24859 (RegisterAttrType, LookupAttr): Implement.
24861 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
24862 info about the same.
24864 (Resolve): Update to populate the above as necessary.
24866 (Error592): Helper.
24868 (GetValidPlaces): Helper to the above.
24870 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
24872 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
24874 2001-11-12 Ravi Pratap <ravi@ximian.com>
24876 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
24878 * ../errors/cs0617.cs : Add.
24880 2001-11-11 Ravi Pratap <ravi@ximian.com>
24882 * enum.cs (Emit): Rename to Populate to be more consistent with what
24883 we expect it to do and when exactly it is called.
24885 * class.cs, rootcontext.cs : Update accordingly.
24887 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
24888 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
24890 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
24892 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
24893 of a fieldinfo using the above, when dealing with a FieldBuilder.
24895 2001-11-10 Ravi Pratap <ravi@ximian.com>
24897 * ../errors/cs0031.cs : Add.
24899 * ../errors/cs1008.cs : Add.
24901 * ../errrors/cs0543.cs : Add.
24903 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
24906 (FindMembers): Implement.
24908 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
24909 enums and delegates too.
24911 (enum_types): Rename to builder_to_enum.
24913 (delegate_types): Rename to builder_to_delegate.
24915 * delegate.cs (FindMembers): Implement.
24917 2001-11-09 Ravi Pratap <ravi@ximian.com>
24919 * typemanager.cs (IsEnumType): Implement.
24921 * enum.cs (Emit): Re-write parts to account for the underlying type
24922 better and perform checking etc.
24924 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
24925 of the underlying type.
24927 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
24930 * enum.cs (error31): Helper to report error #31.
24932 * cs-parser.jay (enum_declaration): Store location of each member too.
24934 * enum.cs (member_to_location): New hashtable.
24936 (AddEnumMember): Update location hashtable.
24938 (Emit): Use the location of each member while reporting errors.
24940 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24942 * cs-parser.jay: A for_initializer if is a
24943 local_variable_declaration really ammount to have an implicit
24944 block with the variable declaration and no initializer for for.
24946 * statement.cs (For.Emit): Cope with null initializers.
24948 This fixes the infinite loop on for initializers.
24950 2001-11-08 Miguel de Icaza <miguel@ximian.com>
24952 * enum.cs: More cleanup.
24954 * ecore.cs: Remove dead code.
24956 * class.cs (Property.Emit): More simplification.
24957 (Event.Emit): ditto.
24959 Reworked to have less levels of indentation.
24961 2001-11-08 Ravi Pratap <ravi@ximian.com>
24963 * class.cs (Property): Emit attributes.
24973 * enum.cs (Emit): Ditto.
24975 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
24978 * class.cs (Field, Event, etc.): Move attribute generation into the
24979 Emit method everywhere.
24981 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
24982 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
24983 as we had no way of defining nested enums !
24985 * rootcontext.cs : Adjust code accordingly.
24987 * typemanager.cs (AddEnumType): To keep track of enum types separately.
24989 2001-11-07 Ravi Pratap <ravi@ximian.com>
24991 * expression.cs (EvalConstantExpression): Move into ecore.cs
24993 * enum.cs (Enum): Rename some members and make them public and readonly
24994 according to our convention.
24996 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
24999 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
25001 (Enum::Emit): Write a simple version for now which doesn't try to compute
25002 expressions. I shall modify this to be more robust in just a while.
25004 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
25006 (TypeContainer::CloseType): Create the Enum types too.
25008 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
25010 * expression.cs (EvalConstantExpression): Get rid of completely.
25012 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
25013 user-defined values and other cases.
25015 (IsValidEnumLiteral): Helper function.
25017 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
25018 out there in the case we had a literal FieldExpr.
25020 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
25022 (Literalize): Revamp a bit to take two arguments.
25024 (EnumLiteral): New class which derives from Literal to wrap enum literals.
25026 2001-11-06 Ravi Pratap <ravi@ximian.com>
25028 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
25030 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
25032 (Resolve): Use the above to ensure we have proper initializers.
25034 2001-11-05 Ravi Pratap <ravi@ximian.com>
25036 * expression.cs (Expression::EvalConstantExpression): New method to
25037 evaluate constant expressions.
25039 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
25041 2001-11-07 Miguel de Icaza <miguel@ximian.com>
25043 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
25046 (Binary.ResolveOperator): Handle operator != (object a, object b)
25047 and operator == (object a, object b);
25049 (Binary.DoNumericPromotions): Indicate whether the numeric
25050 promotion was possible.
25052 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
25055 Made the ArrayAccess implement interface IAssignMethod instead of
25056 IStackStore as the order in which arguments are passed reflects
25059 * assign.cs: Instead of using expr.ExprClass to select the way of
25060 assinging, probe for the IStackStore/IAssignMethod interfaces.
25062 * typemanager.cs: Load InitializeArray definition.
25064 * rootcontext.cs (RootContext.MakeStaticData): Used to define
25065 static data that can be used to initialize arrays.
25067 2001-11-05 Miguel de Icaza <miguel@ximian.com>
25069 * expression.cs: Handle operator== and operator!= for booleans.
25071 (Conditioal.Reduce): Implement reducer for the ?: operator.
25073 (Conditional.Resolve): Implement dead code elimination.
25075 (Binary.Resolve): Catch string literals and return a new
25076 concatenated string.
25078 (Unary.Reduce): Implement reduction of unary expressions.
25080 * ecore.cs: Split out the expression core handling here.
25082 (Expression.Reduce): New method used to perform constant folding
25083 and CSE. This is needed to support constant-expressions.
25085 * statement.cs (Statement.EmitBoolExpression): Pass true and false
25086 targets, and optimize for !x.
25088 2001-11-04 Ravi Pratap <ravi@ximian.com>
25090 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
25091 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
25092 set custom atttributes.
25094 * literal.cs (Literal::GetValue): New abstract method to return the actual
25095 value of the literal, cast as an object.
25097 (*Literal): Implement GetValue method.
25099 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
25100 expressions to the arraylist but objects of type Argument.
25102 * class.cs (TypeContainer::Emit): Emit our attributes too.
25104 (Method::Emit, Constructor::Emit): Ditto.
25106 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
25107 to be ignoring earlier.
25109 2001-11-03 Ravi Pratap <ravi@ximian.com>
25111 * attribute.cs (AttributeSection::Define): Implement to do the business
25112 of constructing a CustomAttributeBuilder.
25114 (Attribute): New trivial class. Increases readability of code.
25116 * cs-parser.jay : Update accordingly.
25118 (positional_argument_list, named_argument_list, named_argument): New rules
25120 (attribute_arguments): Use the above so that we are more correct.
25122 2001-11-02 Ravi Pratap <ravi@ximian.com>
25124 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
25125 to perform all checks for a method with a params parameter.
25127 (Invocation::OverloadResolve): Update to use the above method and therefore
25128 cope correctly with params method invocations.
25130 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
25133 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
25134 constructors in our parent too because we can't afford to miss out on
25137 * attribute.cs (AttributeSection): New name for the class Attribute
25139 Other trivial changes to improve readability.
25141 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
25142 use the new class names.
25144 2001-11-01 Ravi Pratap <ravi@ximian.com>
25146 * class.cs (Method::Define): Complete definition for params types too
25148 (Indexer::Define): Ditto.
25150 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
25151 Cope everywhere with a request for info about the array parameter.
25153 2001-11-01 Ravi Pratap <ravi@ximian.com>
25155 * tree.cs (RecordNamespace): Fix up to check for the correct key.
25157 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
25158 local_variable_type to extract the string corresponding to the type.
25160 (local_variable_type): Fixup the action to use the new helper method.
25162 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
25165 * expression.cs : Clean out code which uses the above.
25167 2001-10-31 Ravi Pratap <ravi@ximian.com>
25169 * typemanager.cs (RegisterMethod): Check if we already have an existing key
25170 and bale out if necessary by returning a false.
25172 (RegisterProperty): Ditto.
25174 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
25175 and print out appropriate error messages.
25177 * interface.cs (everywhere): Ditto.
25179 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
25180 location to constructor.
25182 * class.cs (Property, Event, Indexer): Update accordingly.
25184 * ../errors/cs111.cs : Added.
25186 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
25187 of a method, as laid down by the spec.
25189 (Invocation::OverloadResolve): Use the above method.
25191 2001-10-31 Ravi Pratap <ravi@ximian.com>
25193 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
25194 now take a TypeContainer and a Parameters object.
25196 (ParameterData): Modify return type of ParameterModifier method to be
25197 Parameter.Modifier and not a string.
25199 (ReflectionParameters, InternalParameters): Update accordingly.
25201 * expression.cs (Argument::GetParameterModifier): Same here.
25203 * support.cs (InternalParameters::ParameterType): Find a better way of determining
25204 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
25205 symbol in it at all so maybe this is only for now.
25207 2001-10-30 Ravi Pratap <ravi@ximian.com>
25209 * support.cs (InternalParameters): Constructor now takes an extra argument
25210 which is the actual Parameters class.
25212 (ParameterDesc): Update to provide info on ref/out modifiers.
25214 * class.cs (everywhere): Update call to InternalParameters to pass in
25215 the second argument too.
25217 * support.cs (ParameterData): Add ParameterModifier, which is a method
25218 to return the modifier info [ref/out etc]
25220 (InternalParameters, ReflectionParameters): Implement the above.
25222 * expression.cs (Argument::ParameterModifier): Similar function to return
25223 info about the argument's modifiers.
25225 (Invocation::OverloadResolve): Update to take into account matching modifiers
25228 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
25229 a new SetFormalParameters object which we pass to InternalParameters.
25231 2001-10-30 Ravi Pratap <ravi@ximian.com>
25233 * expression.cs (NewArray): Merge into the ArrayCreation class.
25235 2001-10-29 Ravi Pratap <ravi@ximian.com>
25237 * expression.cs (NewArray): Merge classes NewBuiltinArray and
25238 NewUserdefinedArray into one as there wasn't much of a use in having
25241 * expression.cs (Argument): Change field's name to ArgType from Type.
25243 (Type): New readonly property which returns the proper type, taking into
25244 account ref/out modifiers.
25246 (everywhere): Adjust code accordingly for the above.
25248 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
25249 whether we are emitting for a ref or out parameter.
25251 * expression.cs (Argument::Emit): Use the above field to set the state.
25253 (LocalVariableReference::Emit): Update to honour the flag and emit the
25256 * parameter.cs (Attributes): Set the correct flags for ref parameters.
25258 * expression.cs (Argument::FullDesc): New function to provide a full desc.
25260 * support.cs (ParameterData): Add method ParameterDesc to the interface.
25262 (ReflectionParameters, InternalParameters): Implement the above method.
25264 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
25267 (Invocation::FullMethodDesc): Ditto.
25269 2001-10-29 Miguel de Icaza <miguel@ximian.com>
25271 * cs-parser.jay: Add extra production for the second form of array
25274 * expression.cs (ArrayCreation): Update to reflect the above
25277 * Small changes to prepare for Array initialization.
25279 2001-10-28 Miguel de Icaza <miguel@ximian.com>
25281 * typemanager.cs (ImplementsInterface): interface might be null;
25282 Deal with this problem;
25284 Also, we do store negative hits on the cache (null values), so use
25285 this instead of calling t.GetInterfaces on the type everytime.
25287 2001-10-28 Ravi Pratap <ravi@ximian.com>
25289 * typemanager.cs (IsBuiltinType): New method to help determine the same.
25291 * expression.cs (New::DoResolve): Get rid of array creation code and instead
25292 split functionality out into different classes.
25294 (New::FormArrayType): Move into NewBuiltinArray.
25296 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
25299 (NewBuiltinArray): New class to handle creation of built-in arrays.
25301 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
25302 account creation of one-dimensional arrays.
25304 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
25306 (NewUserdefinedArray::DoResolve): Implement.
25308 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
25310 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
25311 we maintain inside the TypeManager. This is necessary to perform lookups on the
25314 (LookupType): Update to perform GetType on the module builders too.
25316 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
25318 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
25320 2001-10-23 Ravi Pratap <ravi@ximian.com>
25322 * expression.cs (New::DoResolve): Implement guts of array creation.
25324 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
25326 2001-10-27 Miguel de Icaza <miguel@ximian.com>
25328 * expression.cs: Fix bug I introduced lsat night that broke
25331 (Expression.Resolve): Report a 246 error (can not resolve name)
25332 if we find a SimpleName in the stream.
25334 (Expression.ResolveLValue): Ditto.
25336 (Expression.ResolveWithSimpleName): This function is a variant of
25337 ResolveName, this one allows SimpleNames to be returned without a
25338 warning. The only consumer of SimpleNames is MemberAccess
25340 2001-10-26 Miguel de Icaza <miguel@ximian.com>
25342 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
25343 might arrive here. I have my doubts that this is correct.
25345 * statement.cs (Lock): Implement lock statement.
25347 * cs-parser.jay: Small fixes to support `lock' and `using'
25349 * cs-tokenizer.cs: Remove extra space
25351 * driver.cs: New flag --checked, allows to turn on integer math
25354 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
25355 Threading.Monitor.Exit
25357 2001-10-23 Miguel de Icaza <miguel@ximian.com>
25359 * expression.cs (IndexerAccess::DoResolveLValue): Set the
25360 Expression Class to be IndexerAccess.
25362 Notice that Indexer::DoResolve sets the eclass to Value.
25364 2001-10-22 Miguel de Icaza <miguel@ximian.com>
25366 * class.cs (TypeContainer::Emit): Emit code for indexers.
25368 * assign.cs (IAssignMethod): New interface implemented by Indexers
25369 and Properties for handling assignment.
25371 (Assign::Emit): Simplify and reuse code.
25373 * expression.cs (IndexerAccess, PropertyExpr): Implement
25374 IAssignMethod, clean up old code.
25376 2001-10-22 Ravi Pratap <ravi@ximian.com>
25378 * typemanager.cs (ImplementsInterface): New method to determine if a type
25379 implements a given interface. Provides a nice cache too.
25381 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
25384 (ConvertReferenceExplicit): Ditto.
25386 * delegate.cs (Delegate::Populate): Update to define the parameters on the
25387 various methods, with correct names etc.
25389 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
25390 Operator.UnaryNegation.
25392 * cs-parser.jay (operator_declarator): Be a little clever in the case where
25393 we have a unary plus or minus operator.
25395 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
25398 * everywhere : update accordingly.
25400 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
25403 * class.cs (Method::Define): For the case where we are implementing a method
25404 inherited from an interface, we need to set the MethodAttributes.Final flag too.
25405 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
25407 2001-10-21 Ravi Pratap <ravi@ximian.com>
25409 * interface.cs (FindMembers): Implement to work around S.R.E
25412 * typemanager.cs (IsInterfaceType): Implement.
25414 (FindMembers): Update to handle interface types too.
25416 * expression.cs (ImplicitReferenceConversion): Re-write bits which
25417 use IsAssignableFrom as that is not correct - it doesn't work.
25419 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
25420 and accordingly override EmitStatement.
25422 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
25423 using the correct logic :-)
25425 2001-10-19 Ravi Pratap <ravi@ximian.com>
25427 * ../errors/cs-11.cs : Add to demonstrate error -11
25429 2001-10-17 Miguel de Icaza <miguel@ximian.com>
25431 * assign.cs (Assign::Resolve): Resolve right hand side first, and
25432 then pass this as a hint to ResolveLValue.
25434 * expression.cs (FieldExpr): Add Location information
25436 (FieldExpr::LValueResolve): Report assignment to readonly
25439 (Expression::ExprClassFromMemberInfo): Pass location information.
25441 (Expression::ResolveLValue): Add new method that resolves an
25444 (Expression::DoResolveLValue): Default invocation calls
25447 (Indexers): New class used to keep track of indexers in a given
25450 (IStackStore): Renamed from LValue, as it did not really describe
25451 what this did. Also ResolveLValue is gone from this interface and
25452 now is part of Expression.
25454 (ElementAccess): Depending on the element access type
25456 * typemanager.cs: Add `indexer_name_type' as a Core type
25457 (System.Runtime.CompilerServices.IndexerNameAttribute)
25459 * statement.cs (Goto): Take a location.
25461 2001-10-18 Ravi Pratap <ravi@ximian.com>
25463 * delegate.cs (Delegate::VerifyDelegate): New method to verify
25464 if two delegates are compatible.
25466 (NewDelegate::DoResolve): Update to take care of the case when
25467 we instantiate a delegate from another delegate.
25469 * typemanager.cs (FindMembers): Don't even try to look up members
25470 of Delegate types for now.
25472 2001-10-18 Ravi Pratap <ravi@ximian.com>
25474 * delegate.cs (NewDelegate): New class to take care of delegate
25477 * expression.cs (New): Split the delegate related code out into
25478 the NewDelegate class.
25480 * delegate.cs (DelegateInvocation): New class to handle delegate
25483 * expression.cs (Invocation): Split out delegate related code into
25484 the DelegateInvocation class.
25486 2001-10-17 Ravi Pratap <ravi@ximian.com>
25488 * expression.cs (New::DoResolve): Implement delegate creation fully
25489 and according to the spec.
25491 (New::DoEmit): Update to handle delegates differently.
25493 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
25494 because of which we were printing out arguments in reverse order !
25496 * delegate.cs (VerifyMethod): Implement to check if the given method
25497 matches the delegate.
25499 (FullDelegateDesc): Implement.
25501 (VerifyApplicability): Implement.
25503 * expression.cs (Invocation::DoResolve): Update to accordingly handle
25504 delegate invocations too.
25506 (Invocation::Emit): Ditto.
25508 * ../errors/cs1593.cs : Added.
25510 * ../errors/cs1594.cs : Added.
25512 * delegate.cs (InstanceExpression, TargetMethod): New properties.
25514 2001-10-16 Ravi Pratap <ravi@ximian.com>
25516 * typemanager.cs (intptr_type): Core type for System.IntPtr
25518 (InitCoreTypes): Update for the same.
25520 (iasyncresult_type, asynccallback_type): Ditto.
25522 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
25525 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
25528 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
25529 the builders for the 4 members of a delegate type :-)
25531 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
25534 * expression.cs (New::DoResolve): Implement guts for delegate creation.
25536 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
25538 2001-10-15 Miguel de Icaza <miguel@ximian.com>
25540 * statement.cs (Break::Emit): Implement.
25541 (Continue::Emit): Implement.
25543 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
25544 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
25545 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
25546 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
25549 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
25550 properties that track the label for the current loop (begin of the
25551 loop and end of the loop).
25553 2001-10-15 Ravi Pratap <ravi@ximian.com>
25555 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
25556 use of emitting anything at all.
25558 * class.cs, rootcontext.cs : Get rid of calls to the same.
25560 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
25562 (Populate): Define the constructor correctly and set the implementation
25565 * typemanager.cs (delegate_types): New hashtable to hold delegates that
25568 (AddDelegateType): Implement.
25570 (IsDelegateType): Implement helper method.
25572 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
25574 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
25575 and accordingly handle it.
25577 * delegate.cs (Populate): Take TypeContainer argument.
25578 Implement bits to define the Invoke method. However, I still haven't figured out
25579 how to take care of the native int bit :-(
25581 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
25582 Qualify the name of the delegate, not its return type !
25584 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
25587 (StandardConversionExists): Checking for array types turns out to be recursive.
25589 (ConvertReferenceExplicit): Implement array conversion.
25591 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
25593 2001-10-12 Ravi Pratap <ravi@ximian.com>
25595 * cs-parser.jay (delegate_declaration): Store the fully qualified
25596 name as it is a type declaration.
25598 * delegate.cs (ReturnType, Name): Rename members to these. Make them
25601 (DefineDelegate): Renamed from Define. Does the same thing essentially,
25602 as TypeContainer::DefineType.
25604 (Populate): Method in which all the definition of the various methods (Invoke)
25607 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
25610 (CloseDelegate): Finally creates the delegate.
25612 * class.cs (TypeContainer::DefineType): Update to define delegates.
25613 (Populate, Emit and CloseType): Do the same thing here too.
25615 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
25616 delegates in all these operations.
25618 2001-10-14 Miguel de Icaza <miguel@ximian.com>
25620 * expression.cs: LocalTemporary: a new expression used to
25621 reference a temporary that has been created.
25623 * assign.cs: Handle PropertyAccess back here, so that we can
25624 provide the proper semantic access to properties.
25626 * expression.cs (Expression::ConvertReferenceExplicit): Implement
25627 a few more explicit conversions.
25629 * modifiers.cs: `NEW' modifier maps to HideBySig.
25631 * expression.cs (PropertyExpr): Make this into an
25632 ExpressionStatement, and support the EmitStatement code path.
25634 Perform get/set error checking, clean up the interface.
25636 * assign.cs: recognize PropertyExprs as targets, and if so, turn
25637 them into toplevel access objects.
25639 2001-10-12 Miguel de Icaza <miguel@ximian.com>
25641 * expression.cs: PropertyExpr::PropertyExpr: use work around the
25644 * typemanager.cs: Keep track here of our PropertyBuilders again to
25645 work around lameness in SRE.
25647 2001-10-11 Miguel de Icaza <miguel@ximian.com>
25649 * expression.cs (LValue::LValueResolve): New method in the
25650 interface, used to perform a second resolution pass for LValues.
25652 (This::DoResolve): Catch the use of this in static methods.
25654 (This::LValueResolve): Implement.
25656 (This::Store): Remove warning, assigning to `this' in structures
25659 (Invocation::Emit): Deal with invocation of
25660 methods on value types. We need to pass the address to structure
25661 methods rather than the object itself. (The equivalent code to
25662 emit "this" for structures leaves the entire structure on the
25663 stack instead of a pointer to it).
25665 (ParameterReference::DoResolve): Compute the real index for the
25666 argument based on whether the method takes or not a `this' pointer
25667 (ie, the method is static).
25669 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
25670 value types returned from functions when we need to invoke a
25671 method on the sturcture.
25674 2001-10-11 Ravi Pratap <ravi@ximian.com>
25676 * class.cs (TypeContainer::DefineType): Method to actually do the business of
25677 defining the type in the Modulebuilder or Typebuilder. This is to take
25678 care of nested types which need to be defined on the TypeBuilder using
25679 DefineNestedMethod.
25681 (TypeContainer::GetClassBases): Implement. Essentially the code from the
25682 methods in RootContext, only ported to be part of TypeContainer.
25684 (TypeContainer::GetInterfaceOrClass): Ditto.
25686 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
25688 * interface.cs (Interface::DefineInterface): New method. Does exactly
25689 what RootContext.CreateInterface did earlier, only it takes care of nested types
25692 (Interface::GetInterfaces): Move from RootContext here and port.
25694 (Interface::GetInterfaceByName): Same here.
25696 * rootcontext.cs (ResolveTree): Re-write.
25698 (PopulateTypes): Re-write.
25700 * class.cs (TypeContainer::Populate): Populate nested types too.
25701 (TypeContainer::Emit): Emit nested members too.
25703 * typemanager.cs (AddUserType): Do not make use of the FullName property,
25704 instead just use the name argument passed in as it is already fully
25707 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
25708 to TypeContainer mapping to see if a type is user-defined.
25710 * class.cs (TypeContainer::CloseType): Implement.
25712 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
25713 the default constructor.
25715 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
25718 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
25720 * interface.cs (CloseType): Create the type here.
25722 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
25725 Remove all the methods which are now in TypeContainer.
25727 2001-10-10 Ravi Pratap <ravi@ximian.com>
25729 * delegate.cs (Define): Re-write bits to define the delegate
25732 2001-10-10 Miguel de Icaza <miguel@ximian.com>
25734 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
25736 * expression.cs (ImplicitReferenceConversion): handle null as well
25737 as a source to convert to any reference type.
25739 * statement.cs (Return): Perform any implicit conversions to
25740 expected return type.
25742 Validate use of return statement.
25744 * codegen.cs (EmitContext): Pass the expected return type here.
25746 * class.cs (Method, Constructor, Property): Pass expected return
25747 type to EmitContext.
25749 2001-10-09 Miguel de Icaza <miguel@ximian.com>
25751 * expression.cs: Make DoResolve take an EmitContext instead of a
25754 Replaced `l' and `location' for `loc', for consistency.
25756 (Error, Warning): Remove unneeded Tc argument.
25758 * assign.cs, literal.cs, constant.cs: Update to new calling
25761 * codegen.cs: EmitContext now contains a flag indicating whether
25762 code is being generated in a static method or not.
25764 * cs-parser.jay: DecomposeQI, new function that replaces the old
25765 QualifiedIdentifier. Now we always decompose the assembled
25766 strings from qualified_identifier productions into a group of
25769 2001-10-08 Miguel de Icaza <miguel@ximian.com>
25771 * rootcontext.cs: Deal with field-less struct types correctly now
25772 by passing the size option to Define Type.
25774 * class.cs: Removed hack that created one static field.
25776 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25778 * statement.cs: Moved most of the code generation here.
25780 2001-10-09 Ravi Pratap <ravi@ximian.com>
25782 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
25785 (ElementAccess): Remove useless bits for now - keep checks as the spec
25788 2001-10-08 Ravi Pratap <ravi@ximian.com>
25790 * expression.cs (ElementAccess::DoResolve): Remove my crap code
25791 and start performing checks according to the spec.
25793 2001-10-07 Ravi Pratap <ravi@ximian.com>
25795 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
25796 rank_specifiers instead.
25798 (rank_specifiers): Change the order in which the rank specifiers are stored
25800 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
25802 * expression.cs (ElementAccess): Implement the LValue interface too.
25804 2001-10-06 Ravi Pratap <ravi@ximian.com>
25806 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
25807 except that user defined conversions are not included.
25809 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
25810 perform the conversion of the return type, if necessary.
25812 (New::DoResolve): Check whether we are creating an array or an object
25813 and accordingly do the needful.
25815 (New::Emit): Same here.
25817 (New::DoResolve): Implement guts of array creation.
25819 (New::FormLookupType): Helper function.
25821 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25823 * codegen.cs: Removed most of the code generation here, and move the
25824 corresponding code generation bits to the statement classes.
25826 Added support for try/catch/finalize and throw.
25828 * cs-parser.jay: Added support for try/catch/finalize.
25830 * class.cs: Catch static methods having the flags override,
25831 virtual or abstract.
25833 * expression.cs (UserCast): This user cast was not really doing
25834 what it was supposed to do. Which is to be born in fully resolved
25835 state. Parts of the resolution were being performed at Emit time!
25839 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25841 * expression.cs: Implicity convert the result from UserCast.
25843 2001-10-05 Ravi Pratap <ravi@ximian.com>
25845 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
25846 prevented it from working correctly.
25848 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
25849 merely ConvertImplicit.
25851 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25853 * typemanager.cs: Make the LookupTypeContainer function static,
25854 and not per-instance.
25856 * class.cs: Make static FindMembers (the one that takes a Type
25859 * codegen.cs: Add EmitForeach here.
25861 * cs-parser.jay: Make foreach a toplevel object instead of the
25862 inline expansion, as we need to perform semantic analysis on it.
25864 2001-10-05 Ravi Pratap <ravi@ximian.com>
25866 * expression.cs (Expression::ImplicitUserConversion): Rename to
25867 UserDefinedConversion.
25869 (Expression::UserDefinedConversion): Take an extra argument specifying
25870 whether we look for explicit user conversions too.
25872 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
25874 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
25876 (ExplicitUserConversion): Make it a call to UserDefinedConversion
25877 with the appropriate arguments.
25879 * cs-parser.jay (cast_expression): Record location too.
25881 * expression.cs (Cast): Record location info.
25883 (Expression::ConvertExplicit): Take location argument.
25885 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
25886 to determine if we are doing explicit conversions.
25888 (UserCast::Emit): Update accordingly.
25890 (Expression::ConvertExplicit): Report an error if everything fails.
25892 * ../errors/cs0030.cs : Add.
25894 2001-10-04 Miguel de Icaza <miguel@ximian.com>
25896 * modifiers.cs: If the ABSTRACT keyword is present, also set the
25897 virtual and newslot bits.
25899 * class.cs (TypeContainer::RegisterRequiredImplementations):
25900 Record methods we need.
25902 (TypeContainer::MakeKey): Helper function to make keys for
25903 MethodBases, since the Methodbase key is useless.
25905 (TypeContainer::Populate): Call RegisterRequiredImplementations
25906 before defining the methods.
25908 Create a mapping for method_builders_to_methods ahead of time
25909 instead of inside a tight loop.
25911 (::RequireMethods): Accept an object as the data to set into the
25912 hashtable so we can report interface vs abstract method mismatch.
25914 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25916 * report.cs: Make all of it static.
25918 * rootcontext.cs: Drop object_type and value_type computations, as
25919 we have those in the TypeManager anyways.
25921 Drop report instance variable too, now it is a global.
25923 * driver.cs: Use try/catch on command line handling.
25925 Add --probe option to debug the error reporting system with a test
25928 * report.cs: Add support for exiting program when a probe
25929 condition is reached.
25931 2001-10-03 Ravi Pratap <ravi@ximian.com>
25933 * expression.cs (Binary::DoNumericPromotions): Fix the case when
25934 we do a forcible conversion regardless of type, to check if
25935 ForceConversion returns a null.
25937 (Binary::error19): Use location to report error.
25939 (Unary::error23): Use location here too.
25941 * ../errors/cs0019.cs : Check in.
25943 * ../errors/cs0023.cs : Check in.
25945 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
25946 case of a non-null MethodInfo object with a length of 0 !
25948 (Binary::ResolveOperator): Flag error if overload resolution fails to find
25949 an applicable member - according to the spec :-)
25950 Also fix logic to find members in base types.
25952 (Unary::ResolveOperator): Same here.
25954 (Unary::report23): Change name to error23 and make first argument a TypeContainer
25955 as I was getting thoroughly confused between this and error19 :-)
25957 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
25958 (::FindMostEncompassedType): Implement.
25959 (::FindMostEncompassingType): Implement.
25960 (::StandardConversionExists): Implement.
25962 (UserImplicitCast): Re-vamp. We now need info about most specific
25963 source and target types so that we can do the necessary conversions.
25965 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
25966 mathematical union with no duplicates.
25968 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25970 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
25971 in order from base classes to child classes, so that we can in
25972 child classes look up in our parent for method names and
25973 attributes (required for handling abstract, virtual, new, override
25974 constructs: we need to instrospect our base class, and if we dont
25975 populate the classes in order, the introspection might be
25976 incorrect. For example, a method could query its parent before
25977 the parent has any methods and would determine that the parent has
25978 no abstract methods (while it could have had them)).
25980 (RootContext::CreateType): Record the order in which we define the
25983 2001-10-02 Miguel de Icaza <miguel@ximian.com>
25985 * class.cs (TypeContainer::Populate): Also method definitions can
25986 fail now, keep track of this.
25988 (TypeContainer::FindMembers): Implement support for
25989 DeclaredOnly/noDeclaredOnly flag.
25991 (Constructor::Emit) Return the ConstructorBuilder.
25993 (Method::Emit) Return the MethodBuilder.
25994 Check for abstract or virtual methods to be public.
25996 * rootcontext.cs (RootContext::CreateType): Register all the
25997 abstract methods required for the class to be complete and the
25998 interface methods that must be implemented.
26000 * cs-parser.jay: Report error 501 (method requires body if it is
26001 not marked abstract or extern).
26003 * expression.cs (TypeOf::Emit): Implement.
26005 * typemanager.cs: runtime_handle_type, new global type.
26007 * class.cs (Property::Emit): Generate code for properties.
26009 2001-10-02 Ravi Pratap <ravi@ximian.com>
26011 * expression.cs (Unary::ResolveOperator): Find operators on base type
26012 too - we now conform exactly to the spec.
26014 (Binary::ResolveOperator): Same here.
26016 * class.cs (Operator::Define): Fix minor quirk in the tests.
26018 * ../errors/cs0215.cs : Added.
26020 * ../errors/cs0556.cs : Added.
26022 * ../errors/cs0555.cs : Added.
26024 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26026 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
26027 single integer which is really efficient
26029 2001-10-01 Ravi Pratap <ravi@ximian.com>
26031 * expression.cs (Expression::ImplicitUserConversion): Use location
26032 even in the case when we are examining True operators.
26034 * class.cs (Operator::Define): Perform extensive checks to conform
26035 with the rules for operator overloading in the spec.
26037 * expression.cs (Expression::ImplicitReferenceConversion): Implement
26038 some of the other conversions mentioned in the spec.
26040 * typemanager.cs (array_type): New static member for the System.Array built-in
26043 (cloneable_interface): For System.ICloneable interface.
26045 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
26046 we start resolving the tree and populating types.
26048 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
26050 2001-10-01 Miguel de Icaza <miguel@ximian.com>
26052 * expression.cs (Expression::ExprClassFromMemberInfo,
26053 Expression::Literalize): Create literal expressions from
26054 FieldInfos which are literals.
26056 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
26057 type casts, because they were wrong. The test suite in tests
26060 (ImplicitNumericConversion): ushort to ulong requires a widening
26063 Int32 constant to long requires widening cast as well.
26065 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
26066 for integers because the type on the stack is not i4.
26068 2001-09-30 Miguel de Icaza <miguel@ximian.com>
26070 * expression.cs (report118): require location argument.
26072 * parameter.cs: Do not dereference potential null value.
26074 * class.cs: Catch methods that lack the `new' keyword when
26075 overriding a name. Report warnings when `new' is used without
26076 anything being there to override.
26078 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
26080 * class.cs: Only add constructor to hashtable if it is non-null
26081 (as now constructors can fail on define).
26083 (TypeManager, Class, Struct): Take location arguments.
26085 Catch field instance initialization in structs as errors.
26087 accepting_filter: a new filter for FindMembers that is static so
26088 that we dont create an instance per invocation.
26090 (Constructor::Define): Catch errors where a struct constructor is
26093 * cs-parser.jay: Pass location information for various new
26096 * delegate.cs (Delegate): take a location argument.
26098 * driver.cs: Do not call EmitCode if there were problesm in the
26099 Definition of the types, as many Builders wont be there.
26101 * decl.cs (Decl::Decl): Require a location argument.
26103 * cs-tokenizer.cs: Handle properly hex constants that can not fit
26104 into integers, and find the most appropiate integer for it.
26106 * literal.cs: Implement ULongLiteral.
26108 * rootcontext.cs: Provide better information about the location of
26109 failure when CreateType fails.
26111 2001-09-29 Miguel de Icaza <miguel@ximian.com>
26113 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
26116 * expression.cs (Binary::CheckShiftArguments): Add missing type
26118 (Binary::ResolveOperator): Add type to the logical and and logical
26119 or, Bitwise And/Or and Exclusive Or code paths, it was missing
26122 (Binary::DoNumericPromotions): In the case where either argument
26123 is ulong (and most signed types combined with ulong cause an
26124 error) perform implicit integer constant conversions as well.
26126 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26128 * expression.cs (UserImplicitCast): Method should always be
26130 (Invocation::BetterConversion): Simplified test for IntLiteral.
26132 (Expression::ImplicitNumericConversion): Split this routine out.
26133 Put the code that performs implicit constant integer conversions
26136 (Expression::Resolve): Become a wrapper around DoResolve so we can
26137 check eclass and type being set after resolve.
26139 (Invocation::Badness): Remove this dead function
26141 (Binary::ResolveOperator): Do not compute the expensive argumnets
26142 unless we have a union for it.
26144 (Probe::Emit): Is needs to do an isinst and then
26145 compare against null.
26147 (::CanConvert): Added Location argument. If the Location argument
26148 is null (Location.Null), then we do not report errors. This is
26149 used by the `probe' mechanism of the Explicit conversion. We do
26150 not want to generate an error for something that the user
26151 explicitly requested to be casted. But the pipeline for an
26152 explicit cast first tests for potential implicit casts.
26154 So for now, if the Location is null, it means `Probe only' to
26155 avoid adding another argument. Might have to revise this
26158 (ClassCast): New class used to type cast objects into arbitrary
26159 classes (used in Explicit Reference Conversions).
26161 Implement `as' as well.
26163 Reverted all the patches from Ravi below: they were broken:
26165 * The use of `level' as a mechanism to stop recursive
26166 invocations is wrong. That was there just to catch the
26167 bug with a strack trace but not as a way of addressing
26170 To fix the problem we have to *understand* what is going
26171 on and the interactions and come up with a plan, not
26172 just get things going.
26174 * The use of the type conversion cache that I proposed
26175 last night had an open topic: How does this work across
26176 protection domains. A user defined conversion might not
26177 be public in the location where we are applying the
26178 conversion, a different conversion might be selected
26179 (ie, private A->B (better) but public B->A (worse),
26180 inside A, A->B applies, but outside it, B->A will
26183 * On top of that (ie, even if the above is solved),
26184 conversions in a cache need to be abstract. Ie, `To
26185 convert from an Int to a Short use an OpcodeCast', not
26186 `To convert from an Int to a Short use the OpcodeCast on
26187 the variable 5' (which is what this patch was doing).
26189 2001-09-28 Ravi Pratap <ravi@ximian.com>
26191 * expression.cs (Invocation::ConversionExists): Re-write to use
26192 the conversion cache
26194 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
26195 cache all conversions done, not just user-defined ones.
26197 (Invocation::BetterConversion): The real culprit. Use ConversionExists
26198 to determine if a conversion exists instead of acutually trying to
26199 perform the conversion. It's faster too.
26201 (Expression::ConvertExplicit): Modify to use ConversionExists to check
26202 and only then attempt the implicit conversion.
26204 2001-09-28 Ravi Pratap <ravi@ximian.com>
26206 * expression.cs (ConvertImplicit): Use a cache for conversions
26207 already found. Check level of recursion and bail out if necessary.
26209 2001-09-28 Miguel de Icaza <miguel@ximian.com>
26211 * typemanager.cs (string_concat_string_string, string_concat_object_object):
26212 Export standard methods that we expect for string operations.
26214 * statement.cs (Block::UsageWarning): Track usage of variables and
26215 report the errors for not used variables.
26217 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
26220 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26222 * codegen.cs: remove unnneded code
26224 * expression.cs: Removed BuiltinTypeAccess class
26226 Fix the order in which implicit conversions are
26229 The previous fixed dropped support for boxed conversions (adding a
26230 test to the test suite now)
26232 (UserImplicitCast::CanConvert): Remove test for source being null,
26233 that code is broken. We should not feed a null to begin with, if
26234 we do, then we should track the bug where the problem originates
26235 and not try to cover it up here.
26237 Return a resolved expression of type UserImplicitCast on success
26238 rather than true/false. Ravi: this is what I was talking about,
26239 the pattern is to use a static method as a "constructor" for
26242 Also, do not create arguments until the very last minute,
26243 otherwise we always create the arguments even for lookups that
26244 will never be performed.
26246 (UserImplicitCast::Resolve): Eliminate, objects of type
26247 UserImplicitCast are born in a fully resolved state.
26249 * typemanager.cs (InitCoreTypes): Init also value_type
26250 (System.ValueType).
26252 * expression.cs (Cast::Resolve): First resolve the child expression.
26254 (LValue): Add new method AddressOf to be used by
26257 Change the argument of Store to take an EmitContext instead of an
26258 ILGenerator, because things like FieldExpr need to be able to call
26259 their children expression to generate the instance code.
26261 (Expression::Error, Expression::Warning): Sugar functions for
26264 (Expression::MemberLookup): Accept a TypeContainer instead of a
26265 Report as the first argument.
26267 (Expression::ResolvePrimary): Killed. I still want to improve
26268 this as currently the code is just not right.
26270 (Expression::ResolveMemberAccess): Simplify, but it is still
26273 (Unary::Resolve): Catch errors in AddressOf operators.
26275 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
26276 index to a byte for the short-version, or the compiler will choose
26277 the wrong Emit call, which generates the wrong data.
26279 (ParameterReference::Emit, ::Store): same.
26281 (FieldExpr::AddressOf): Implement.
26283 * typemanager.cs: TypeManager: made public variable instead of
26286 * driver.cs: document --fatal.
26288 * report.cs (ErrorMessage, WarningMessage): new names for the old
26289 Error and Warning classes.
26291 * cs-parser.jay (member_access): Turn built-in access to types
26292 into a normal simplename
26294 2001-09-27 Ravi Pratap <ravi@ximian.com>
26296 * expression.cs (Invocation::BetterConversion): Fix to cope
26297 with q being null, since this was introducing a bug.
26299 * expression.cs (ConvertImplicit): Do built-in conversions first.
26301 2001-09-27 Ravi Pratap <ravi@ximian.com>
26303 * expression.cs (UserImplicitCast::Resolve): Fix bug.
26305 2001-09-27 Ravi Pratap <ravi@ximian.com>
26307 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
26308 I had introduced long ago (what's new ?).
26310 * expression.cs (UserImplicitCast::CanConvert): Static method to do
26311 the work of all the checking.
26312 (ConvertImplicit): Call CanConvert and only then create object if necessary.
26313 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
26315 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
26316 that is the right way.
26318 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
26319 overloading resolution. Use everywhere instead of cutting and pasting code.
26321 (Binary::ResolveOperator): Use MakeUnionSet.
26323 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
26324 we have to convert to bool types. Not complete yet.
26326 2001-09-27 Miguel de Icaza <miguel@ximian.com>
26328 * typemanager.cs (TypeManager::CSharpName): support ushort.
26330 * expression.cs (Expression::TryImplicitIntConversion): Attempts
26331 to provide an expression that performsn an implicit constant int
26332 conversion (section 6.1.6).
26333 (Expression::ConvertImplicitRequired): Reworked to include
26334 implicit constant expression conversions.
26336 (Expression::ConvertNumericExplicit): Finished.
26338 (Invocation::Emit): If InstanceExpression is null, then it means
26339 that we perform a call on this.
26341 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26343 * expression.cs (Unary::Emit): Remove some dead code.
26344 (Probe): Implement Resolve and Emit for `is'.
26345 (Expression::ConvertImplicitRequired): Attempt to do constant
26346 expression conversions here. Maybe should be moved to
26347 ConvertImplicit, but I am not sure.
26348 (Expression::ImplicitLongConstantConversionPossible,
26349 Expression::ImplicitIntConstantConversionPossible): New functions
26350 that tell whether is it possible to apply an implicit constant
26351 expression conversion.
26353 (ConvertNumericExplicit): Started work on explicit numeric
26356 * cs-parser.jay: Update operator constants.
26358 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
26359 (Parameters::GetSignature): Hook up VerifyArgs here.
26360 (Parameters::VerifyArgs): Verifies that no two arguments have the
26363 * class.cs (Operator): Update the operator names to reflect the
26364 ones that the spec expects (as we are just stringizing the
26367 * expression.cs (Unary::ResolveOperator): Fix bug: Use
26368 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
26369 previous usage did only work for our methods.
26370 (Expression::ConvertImplicit): Handle decimal implicit numeric
26371 conversions as well.
26372 (Expression::InternalTypeConstructor): Used to invoke constructors
26373 on internal types for default promotions.
26375 (Unary::Emit): Implement special handling for the pre/post
26376 increment/decrement for overloaded operators, as they need to have
26377 the same semantics as the other operators.
26379 (Binary::ResolveOperator): ditto.
26380 (Invocation::ConversionExists): ditto.
26381 (UserImplicitCast::Resolve): ditto.
26383 2001-09-26 Ravi Pratap <ravi@ximian.com>
26385 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
26386 operator, return after emitting body. Regression tests pass again !
26388 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
26389 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
26390 (Invocation::OverloadResolve): Ditto.
26391 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
26393 * everywhere : update calls to the above methods accordingly.
26395 2001-09-26 Miguel de Icaza <miguel@ximian.com>
26397 * assign.cs (Assign): Make it inherit from ExpressionStatement.
26399 * expression.cs (ExpressionStatement): New base class used for
26400 expressions that can appear in statements, so that we can provide
26401 an alternate path to generate expression that do not leave a value
26404 (Expression::Emit, and all the derivatives): We no longer return
26405 whether a value is left on the stack or not. Every expression
26406 after being emitted leaves a single value on the stack.
26408 * codegen.cs (EmitContext::EmitStatementExpression): Use the
26409 facilties of ExpressionStatement if possible.
26411 * cs-parser.jay: Update statement_expression.
26413 2001-09-25 Miguel de Icaza <miguel@ximian.com>
26415 * driver.cs: Change the wording of message
26417 2001-09-25 Ravi Pratap <ravi@ximian.com>
26419 * expression.cs (Binary::ResolveOperator): Had forgottten to set
26420 the type of the expression to the return type of the method if
26421 we have an overloaded operator match ! The regression tests pass again !
26422 (Unary::ResolveOperator): Ditto.
26424 * expression.cs (Invocation::ConversionExists): Correct the member lookup
26425 to find "op_Implicit", not "implicit" ;-)
26426 (UserImplicitCast): New class to take care of user-defined implicit conversions.
26427 (ConvertImplicit, ForceConversion): Take TypeContainer argument
26429 * everywhere : Correct calls to the above accordingly.
26431 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
26432 (ConvertImplicit): Do user-defined conversion if it exists.
26434 2001-09-24 Miguel de Icaza <miguel@ximian.com>
26436 * assign.cs: track location.
26437 (Resolve): Use implicit conversions on assignment.
26439 * literal.cs: Oops. Not good, Emit of short access values should
26440 pass (Bytes) or the wrong argument will be selected.
26442 * expression.cs (Unary::Emit): Emit code for -expr.
26444 (Unary::ResolveOperator): Handle `Substract' for non-constants
26445 (substract from zero from the non-constants).
26446 Deal with Doubles as well.
26448 (Expression::ConvertImplicitRequired): New routine that reports an
26449 error if no implicit conversion exists.
26451 (Invocation::OverloadResolve): Store the converted implicit
26452 expressions if we make them
26454 2001-09-24 Ravi Pratap <ravi@ximian.com>
26456 * class.cs (ConstructorInitializer): Take a Location argument.
26457 (ConstructorBaseInitializer): Same here.
26458 (ConstructorThisInitializer): Same here.
26460 * cs-parser.jay : Update all calls accordingly.
26462 * expression.cs (Unary, Binary, New): Take location argument.
26463 Update accordingly everywhere.
26465 * cs-parser.jay : Update all calls to the above to take a location
26468 * class.cs : Ditto.
26470 2001-09-24 Ravi Pratap <ravi@ximian.com>
26472 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
26473 (Invocation::BetterConversion): Same here
26474 (Invocation::ConversionExists): Ditto.
26476 (Invocation::ConversionExists): Implement.
26478 2001-09-22 Ravi Pratap <ravi@ximian.com>
26480 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
26481 Also take an additional TypeContainer argument.
26483 * All over : Pass in TypeContainer as argument to OverloadResolve.
26485 * typemanager.cs (CSharpName): Update to check for the string type and return
26488 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
26491 2001-09-21 Ravi Pratap <ravi@ximian.com>
26493 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
26494 (Invocation::BetterFunction): Implement.
26495 (Invocation::BetterConversion): Implement.
26496 (Invocation::ConversionExists): Skeleton, no implementation yet.
26498 Okay, things work fine !
26500 2001-09-21 Miguel de Icaza <miguel@ximian.com>
26502 * typemanager.cs: declare and load enum_type, delegate_type and
26505 * expression.cs (Expression::Emit): Now emit returns a value that
26506 tells whether a value is left on the stack or not. This strategy
26507 might be reveted tomorrow with a mechanism that would address
26508 multiple assignments.
26509 (Expression::report118): Utility routine to report mismatches on
26512 (Unary::Report23): Report impossible type/operator combination
26515 (Unary::IsIncrementableNumber): Whether the type can be
26516 incremented or decremented with add.
26517 (Unary::ResolveOperator): Also allow enumerations to be bitwise
26519 (Unary::ResolveOperator): Implement ++, !, ~,
26521 (Invocation::Emit): Deal with new Emit convetion.
26523 * All Expression derivatives: Updated their Emit method to return
26524 whether they leave values on the stack or not.
26526 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
26527 stack for expressions that are statements.
26529 2001-09-20 Miguel de Icaza <miguel@ximian.com>
26531 * expression.cs (LValue): New interface. Must be implemented by
26533 (LocalVariableReference, ParameterReference, FieldExpr): Implement
26536 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
26537 interface for generating code, simplifies the code.
26539 2001-09-20 Ravi Pratap <ravi@ximian.com>
26541 * expression.cs (everywhere): Comment out return statements in ::Resolve
26542 methods to avoid the warnings.
26544 2001-09-20 Miguel de Icaza <miguel@ximian.com>
26546 * driver.cs (parse): Report error 2001 if we can not open the
26549 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
26552 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
26555 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
26556 otherwise nested blocks end up with the same index.
26558 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
26560 * expression.cs: Instead of having FIXMEs in the Resolve
26561 functions, throw exceptions so it is obvious that we are facing a
26564 * cs-parser.jay (invocation_expression): Pass Location information.
26566 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
26567 Use a basename for those routines because .NET does not like paths
26570 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
26573 2001-09-19 Miguel de Icaza <miguel@ximian.com>
26575 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
26576 are loading the correct data types (throws an exception if not).
26577 (TypeManager::InitCoreTypes): Use CoreLookupType
26579 * expression.cs (Unary::ResolveOperator): return the child
26580 expression for expressions which are just +expr.
26581 (Unary::ResolveOperator): Return negative literals for -LITERAL
26582 expressions (otherwise they are Unary {Literal}).
26583 (Invocation::Badness): Take into account `Implicit constant
26584 expression conversions'.
26586 * literal.cs (LongLiteral): Implement long literal class.
26587 (IntLiteral): export the `Value' of the intliteral.
26589 2001-09-19 Ravi Pratap <ravi@ximian.com>
26591 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
26593 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
26594 instead of 'Operator'
26596 * expression.cs (Binary::ResolveOperator): Update accordingly.
26597 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
26600 * cs-parser.jay (unary_expression): Update to use the new names.
26602 * gen-treedump.cs (GetUnary): Same here.
26604 * expression.cs (Unary::Resolve): Implement.
26605 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
26606 operators are found instead of making noise ;-)
26607 (Unary::ResolveOperator): New method to do precisely the same thing which
26608 Binary::ResolveOperator does for Binary expressions.
26609 (Unary.method, .Arguments): Add.
26610 (Unary::OperName): Implement.
26611 (Unary::ForceConversion): Copy and Paste !
26613 * class.cs (Operator::Define): Fix a small bug for the case when we have
26616 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
26617 for the inbuilt operators. Only overloading works for now ;-)
26619 2001-09-18 Miguel de Icaza <miguel@ximian.com>
26621 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
26622 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
26624 * expression.cs (This::Emit): Implement.
26625 (This::Resolve): Implement.
26626 (TypeOf:Resolve): Implement.
26627 (Expression::ResolveSimpleName): Add an implicit this to instance
26629 (MemberAccess::Resolve): Deal with Parameters and Fields.
26630 Bind instance variable to Field expressions.
26631 (FieldExpr::Instance): New field used to track the expression that
26632 represents the object instance.
26633 (FieldExpr::Resolve): Track potential errors from MemberLookup not
26635 (FieldExpr::Emit): Implement.
26637 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
26638 the last instruction contains a return opcode to avoid generating
26639 the last `ret' instruction (this generates correct code, and it is
26640 nice to pass the peverify output).
26642 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
26643 initializer for static and instance variables.
26644 (Constructor::Emit): Allow initializer to be null in the case of
26645 static constructors. Only emit initializer for instance
26648 (TypeContainer::FindMembers): Return a null array if there are no
26651 Also fix the code for the MemberTypes.Method branch, as it was not
26652 scanning that for operators (or tried to access null variables before).
26654 * assign.cs (Assign::Emit): Handle instance and static fields.
26658 * driver.cs: Stop compilation if there are parse errors.
26660 * cs-parser.jay (constructor_declaration): Provide default base
26661 initializer for non-static constructors.
26662 (constructor_declarator): Do not provide a default base
26663 initializers if none was specified.
26664 Catch the fact that constructors should not have parameters.
26666 * class.cs: Do not emit parent class initializers for static
26667 constructors, that should be flagged as an error.
26669 2001-09-18 Ravi Pratap <ravi@ximian.com>
26671 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
26672 Move back code into TypeContainer::Populate.
26674 2001-09-18 Ravi Pratap <ravi@ximian.com>
26676 * class.cs (TypeContainer::AddConstructor): Fix the check to
26677 compare against Name, not Basename.
26678 (Operator::OpType): Change Plus and Minus to Add and Subtract.
26680 * cs-parser.jay : Update accordingly.
26682 * class.cs (TypeContainer::FindMembers): For the case where we are searching
26683 for methods, don't forget to look into the operators too.
26684 (RegisterMethodBuilder): Helper method to take care of this for
26685 methods, constructors and operators.
26686 (Operator::Define): Completely revamp.
26687 (Operator.OperatorMethod, MethodName): New fields.
26688 (TypeContainer::Populate): Move the registering of builders into
26689 RegisterMethodBuilder.
26690 (Operator::Emit): Re-write.
26692 * expression.cs (Binary::Emit): Comment out code path to emit method
26693 invocation stuff for the case when we have a user defined operator. I am
26694 just not able to get it right !
26696 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26698 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
26701 (Expression::MemberLookup): Provide a version that allows to
26702 specify the MemberTypes and BindingFlags.
26704 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
26705 so it was not fetching variable information from outer blocks.
26707 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
26708 Beforefieldinit as it was buggy.
26710 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
26711 that Ravi put here.
26713 * class.cs (Constructor::Emit): Only emit if block is not null.
26714 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
26715 deal with this by semantically definining it as if the user had
26718 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
26719 constructors as we now "emit" them at a higher level.
26721 (TypeContainer::DefineDefaultConstructor): Used to define the
26722 default constructors if none was provided.
26724 (ConstructorInitializer): Add methods Resolve and Emit.
26726 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
26728 2001-09-17 Ravi Pratap <ravi@ximian.com>
26730 * class.cs (TypeContainer::EmitDefaultConstructor): Register
26731 the default constructor builder with our hashtable for methodbuilders
26734 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
26735 and argument_count is 0 in which case we have a match.
26736 (Binary::ResolveOperator): More null checking and miscellaneous coding
26739 2001-09-17 Ravi Pratap <ravi@ximian.com>
26741 * rootcontext.cs (IsNameSpace): Compare against null.
26743 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
26745 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
26746 and Unary::Operator.
26748 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
26751 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
26752 we have overloaded operators.
26753 (Binary::ResolveOperator): Implement the part which does the operator overload
26756 * class.cs (Operator::Emit): Implement.
26757 (TypeContainer::Emit): Emit the operators we have too.
26759 * expression.cs (Binary::Emit): Update to emit the appropriate code for
26760 the case when we have a user-defined operator.
26762 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26764 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
26766 2001-09-16 Ravi Pratap <ravi@ximian.com>
26768 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
26769 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
26770 (Constructor::Emit): Implement.
26771 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
26772 if we have no work to do.
26773 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
26776 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
26777 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
26779 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
26782 2001-09-15 Ravi Pratap <ravi@ximian.com>
26784 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
26786 (Tree::RecordNamespace): Method to do what the name says ;-)
26787 (Tree::Namespaces): Property to get at the namespaces hashtable.
26789 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
26792 * rootcontext.cs (IsNamespace): Fixed it :-)
26794 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26796 * class.cs (TypeContainer::FindMembers): Add support for
26798 (MethodCore): New class that encapsulates both the shared aspects
26799 of a Constructor and a Method.
26800 (Method, Constructor): Factored pieces into MethodCore.
26802 * driver.cs: Added --fatal which makes errors throw exceptions.
26803 Load System assembly as well as part of the standard library.
26805 * report.cs: Allow throwing exceptions on errors for debugging.
26807 * modifiers.cs: Do not use `parent', instead use the real type
26808 container to evaluate permission settings.
26810 * class.cs: Put Ravi's patch back in. He is right, and we will
26811 have to cope with the
26813 2001-09-14 Ravi Pratap <ravi@ximian.com>
26815 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
26816 FamORAssem, not FamANDAssem.
26818 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26820 * driver.cs: Added --parse option that only parses its input files
26823 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
26824 incorrect. IsTopLevel is not used to tell whether an object is
26825 root_types or not (that can be achieved by testing this ==
26826 root_types). But to see if this is a top-level *class* (not
26827 necessarly our "toplevel" container).
26829 2001-09-14 Ravi Pratap <ravi@ximian.com>
26831 * enum.cs (Enum::Define): Modify to call the Lookup method on the
26832 parent instead of a direct call to GetType.
26834 2001-09-14 Ravi Pratap <ravi@ximian.com>
26836 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
26837 Modifiers.TypeAttr. This should just be a call to that method.
26839 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
26840 object so that we can determine if we are top-level or not.
26842 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
26845 * enum.cs (Enum::Define): Ditto.
26847 * modifiers.cs (FieldAttr): Re-write.
26849 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
26850 (TypeContainer::HaveStaticConstructor): New property to provide access
26851 to precisely that info.
26853 * modifiers.cs (MethodAttr): Re-write.
26854 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
26856 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
26857 of top-level types as claimed.
26859 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26861 * expression.cs (MemberLookup): Fruitless attempt to lookup
26862 constructors. Maybe I need to emit default constructors? That
26863 might be it (currently .NET emits this for me automatically).
26864 (Invocation::OverloadResolve): Cope with Arguments == null.
26865 (Invocation::EmitArguments): new function, shared by the new
26866 constructor and us.
26867 (Invocation::Emit): Handle static and instance methods. Emit
26868 proper call instruction for virtual or non-virtual invocations.
26869 (New::Emit): Implement.
26870 (New::Resolve): Implement.
26871 (MemberAccess:Resolve): Implement.
26872 (MethodGroupExpr::InstanceExpression): used conforming to the spec
26873 to track instances.
26874 (FieldExpr::Resolve): Set type.
26876 * support.cs: Handle empty arguments.
26878 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
26879 SimpleLookup): Auxiliary routines to help parse a qualifier
26882 Update qualifier_identifier rule.
26884 * codegen.cs: Removed debugging messages.
26886 * class.cs: Make this a global thing, this acts just as a "key" to
26887 objects that we might have around.
26889 (Populate): Only initialize method_builders_to_methods once.
26891 * expression.cs (PropertyExpr): Initialize type from the
26894 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
26895 Resolve pattern. Attempt to implicitly convert value to boolean.
26898 * expression.cs: Set the type for the int32/int32 argument case.
26899 (Binary::ResolveOperator): Set the return type to boolean for
26900 comparission operators
26902 * typemanager.cs: Remove debugging print code.
26904 (Invocation::Resolve): resolve type.
26906 * class.cs: Allocate a MemberInfo of the correct size, as the code
26907 elsewhere depends on the test to reflect the correct contents.
26909 (Method::) Keep track of parameters, due to System.Reflection holes
26911 (TypeContainer::Populate): Keep track of MethodBuilders to Method
26914 (TypeContainer::FindMembers): Use ArrayList and then copy an array
26915 of the exact size and return that.
26917 (Class::LookupMethodByBuilder): New function that maps
26918 MethodBuilders to its methods. Required to locate the information
26919 on methods because System.Reflection bit us again.
26921 * support.cs: New file, contains an interface ParameterData and
26922 two implementations: ReflectionParameters and InternalParameters
26923 used to access Parameter information. We will need to grow this
26926 * expression.cs (Invocation::GetParameterData): implement a cache
26927 and a wrapper around the ParameterData creation for methods.
26928 (Invocation::OverloadResolve): Use new code.
26930 2001-09-13 Ravi Pratap <ravi@ximian.com>
26932 * class.cs (TypeContainer::EmitField): Remove and move into
26933 (Field::Define): here and modify accordingly.
26934 (Field.FieldBuilder): New member.
26935 (TypeContainer::Populate): Update accordingly.
26936 (TypeContainer::FindMembers): Implement.
26938 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26940 * statement.cs: (VariableInfo::VariableType): New field to be
26941 initialized with the full type once it is resolved.
26943 2001-09-12 Miguel de Icaza <miguel@ximian.com>
26945 * parameter.cs (GetParameterInfo): Use a type cache to compute
26946 things only once, and to reuse this information
26948 * expression.cs (LocalVariableReference::Emit): Implement.
26949 (OpcodeCast::Emit): fix.
26951 (ParameterReference::Resolve): Implement.
26952 (ParameterReference::Emit): Implement.
26954 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
26955 that are expressions need to stay as Expressions.
26957 * typemanager.cs (CSharpName): Returns the C# name of a type if
26960 * expression.cs (Expression::ConvertImplicit): New function that
26961 implements implicit type conversions.
26963 (Expression::ImplicitReferenceConversion): Implements implicit
26964 reference conversions.
26966 (EmptyCast): New type for transparent casts.
26968 (OpcodeCast): New type for casts of types that are performed with
26969 a sequence of bytecodes.
26971 (BoxedCast): New type used for casting value types into reference
26972 types. Emits a box opcode.
26974 (Binary::DoNumericPromotions): Implements numeric promotions of
26975 and computation of the Binary::Type.
26977 (Binary::EmitBranchable): Optimization.
26979 (Binary::Emit): Implement code emission for expressions.
26981 * typemanager.cs (TypeManager): Added two new core types: sbyte
26984 2001-09-12 Ravi Pratap <ravi@ximian.com>
26986 * class.cs (TypeContainer::FindMembers): Method which does exactly
26987 what Type.FindMembers does, only we don't have to use reflection. No
26988 implementation yet.
26990 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
26991 typecontainer objects as we need to get at them.
26992 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
26994 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
26995 typecontainer object.
26997 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
26998 of just a Report object.
27000 2001-09-11 Ravi Pratap <ravi@ximian.com>
27002 * class.cs (Event::Define): Go back to using the prefixes "add_" and
27004 (TypeContainer::Populate): Now define the delegates of the type too.
27005 (TypeContainer.Delegates): Property to access the list of delegates defined
27008 * delegates.cs (Delegate::Define): Implement partially.
27010 * modifiers.cs (TypeAttr): Handle more flags.
27012 2001-09-11 Ravi Pratap <ravi@ximian.com>
27014 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
27016 (Operator::Define): Re-write logic to get types by using the LookupType method
27017 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
27018 (Indexer::Define): Ditto.
27019 (Event::Define): Ditto.
27020 (Property::Define): Ditto.
27022 2001-09-10 Ravi Pratap <ravi@ximian.com>
27024 * class.cs (TypeContainer::Populate): Now define operators too.
27025 (TypeContainer.Operators): New property to access the list of operators
27027 (Operator.OperatorMethodBuilder): New member to hold the method builder
27028 for the operator we are defining.
27029 (Operator::Define): Implement.
27031 2001-09-10 Ravi Pratap <ravi@ximian.com>
27033 * class.cs (Event::Define): Make the prefixes of the accessor methods
27034 addOn_ and removeOn_
27036 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
27037 of the location being passed in too. Ideally, this should go later since all
27038 error reporting should be done through the Report object.
27040 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
27041 (Populate): Iterate thru the indexers we have and define them too.
27042 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
27043 for the get and set accessors.
27044 (Indexer::Define): Implement.
27046 2001-09-09 Miguel de Icaza <miguel@ximian.com>
27048 * expression.cs (Binary::Resolve): Beginning of it. I scratched
27049 my previous implementation, did not work.
27051 * typemanager.cs: Add a couple of missing types (the longs).
27053 * literal.cs: Use TypeManager.bool_type instead of getting it.
27055 * expression.cs (EventExpr): New kind of expressions.
27056 (Expressio::ExprClassFromMemberInfo): finish
27058 2001-09-08 Miguel de Icaza <miguel@ximian.com>
27060 * assign.cs: Emit stores to static fields differently.
27062 2001-09-08 Ravi Pratap <ravi@ximian.com>
27064 * Merge in changes and adjust code to tackle conflicts. Backed out my
27065 code in Assign::Resolve ;-)
27067 2001-09-08 Ravi Pratap <ravi@ximian.com>
27069 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
27070 instead Report.Error and also pass in the location.
27071 (CSharpParser::Lexer): New readonly property to return the reference
27072 to the Tokenizer object.
27073 (declare_local_variables): Use Report.Error with location instead of plain
27077 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
27078 (Operator.CheckBinaryOperator): Ditto.
27080 * cs-parser.jay (operator_declarator): Update accordingly.
27082 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
27083 (CheckBinaryOperator): Same here.
27085 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
27086 on the name without any prefixes of namespace names etc. This is because we
27087 already might have something already fully qualified like
27088 'System.Console.WriteLine'
27090 * assign.cs (Resolve): Begin implementation. Stuck ;-)
27092 2001-09-07 Ravi Pratap <ravi@ximian.com>
27094 * cs-tokenizer.cs (location): Return a string which also contains
27097 * expression.cs (ElementAccess): New class for expressions of the
27098 type 'element access.'
27099 (BaseAccess): New class for expressions of the type 'base access.'
27100 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
27103 * cs-parser.jay (element_access): Implement action.
27104 (base_access): Implement actions.
27105 (checked_expression, unchecked_expression): Implement.
27107 * cs-parser.jay (local_variable_type): Correct and implement.
27108 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
27110 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
27112 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
27113 name and the specifiers.
27115 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
27117 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
27118 making them all public ;-)
27120 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
27123 2001-09-07 Miguel de Icaza <miguel@ximian.com>
27125 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
27127 (FieldExpr, PropertyExprs): New resolved expressions.
27128 (SimpleName::MemberStaticCheck): Perform static checks for access
27129 to non-static fields on static methods. Maybe this should be
27130 generalized for MemberAccesses.
27131 (SimpleName::ResolveSimpleName): More work on simple name
27134 * cs-parser.jay (primary_expression/qualified_identifier): track
27135 the parameter index.
27137 * codegen.cs (CodeGen::Save): Catch save exception, report error.
27138 (EmitContext::EmitBoolExpression): Chain to expression generation
27139 instead of temporary hack.
27140 (::EmitStatementExpression): Put generic expression code generation.
27142 * assign.cs (Assign::Emit): Implement variable assignments to
27143 local variables, parameters and fields.
27145 2001-09-06 Miguel de Icaza <miguel@ximian.com>
27147 * statement.cs (Block::GetVariableInfo): New method, returns the
27148 VariableInfo for a variable name in a block.
27149 (Block::GetVariableType): Implement in terms of GetVariableInfo
27151 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
27152 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
27154 2001-09-06 Ravi Pratap <ravi@ximian.com>
27156 * cs-parser.jay (operator_declaration): Continue on my quest : update
27157 to take attributes argument.
27158 (event_declaration): Ditto.
27159 (enum_declaration): Ditto.
27160 (indexer_declaration): Ditto.
27162 * class.cs (Operator::Operator): Update constructor accordingly.
27163 (Event::Event): Ditto.
27165 * delegate.cs (Delegate::Delegate): Same here.
27167 * enum.cs (Enum::Enum): Same here.
27169 2001-09-05 Ravi Pratap <ravi@ximian.com>
27171 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
27173 * ../tests/cs0658.cs : New file to demonstrate error 0658.
27175 * attribute.cs (Attributes): New class to encapsulate all attributes which were
27176 being passed around as an arraylist.
27177 (Attributes::AddAttribute): Method to add attribute sections.
27179 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
27180 (struct_declaration): Update accordingly.
27181 (constant_declaration): Update.
27182 (field_declaration): Update.
27183 (method_header): Update.
27184 (fixed_parameter): Update.
27185 (parameter_array): Ditto.
27186 (property_declaration): Ditto.
27187 (destructor_declaration): Ditto.
27189 * class.cs (Struct::Struct): Update constructors accordingly.
27190 (Class::Class): Ditto.
27191 (Field::Field): Ditto.
27192 (Method::Method): Ditto.
27193 (Property::Property): Ditto.
27194 (TypeContainer::OptAttribute): update property's return type.
27196 * interface.cs (Interface.opt_attributes): New member.
27197 (Interface::Interface): Update to take the extra Attributes argument.
27199 * parameter.cs (Parameter::Parameter): Ditto.
27201 * constant.cs (Constant::Constant): Ditto.
27203 * interface.cs (InterfaceMemberBase): New OptAttributes field.
27204 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
27205 the attributes as a parameter.
27206 (InterfaceProperty): Update constructor call.
27207 (InterfaceEvent): Ditto.
27208 (InterfaceMethod): Ditto.
27209 (InterfaceIndexer): Ditto.
27211 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
27212 pass the attributes too.
27213 (interface_event_declaration): Ditto.
27214 (interface_property_declaration): Ditto.
27215 (interface_method_declaration): Ditto.
27216 (interface_declaration): Ditto.
27218 2001-09-05 Miguel de Icaza <miguel@ximian.com>
27220 * class.cs (Method::Define): Track the "static Main" definition to
27221 create an entry point.
27223 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
27224 EntryPoint if we find it.
27226 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
27227 (EmitContext::ig): Make this variable public.
27229 * driver.cs: Make the default output file be the first file name
27230 with the .exe extension.
27232 Detect empty compilations
27234 Handle various kinds of output targets. Handle --target and
27235 rename -t to --dumper.
27237 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
27238 methods inherited from Expression return now an Expression. This
27239 will is used during the tree rewriting as we resolve them during
27242 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
27243 the spec. Missing entirely is the information about
27244 accessability of elements of it.
27246 (Expression::ExprClassFromMemberInfo): New constructor for
27247 Expressions that creates a fully initialized Expression based on
27248 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
27251 (Invocation::Resolve): Begin implementing resolution of invocations.
27253 * literal.cs (StringLiteral): Implement Emit.
27255 2001-09-05 Ravi Pratap <ravi@ximian.com>
27257 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
27260 2001-09-04 Ravi Pratap <ravi@ximian.com>
27262 * cs-parser.jay (attribute_arguments): Implement actions.
27263 (attribute): Fix bug in production. Implement action.
27264 (attribute_list): Implement.
27265 (attribute_target): Implement.
27266 (attribute_target_specifier, opt_target_specifier): Implement
27267 (CheckAttributeTarget): New method to check if the attribute target
27269 (attribute_section): Implement.
27270 (opt_attributes): Implement.
27272 * attribute.cs : New file to handle attributes.
27273 (Attribute): Class to hold attribute info.
27275 * cs-parser.jay (opt_attribute_target_specifier): Remove production
27276 (attribute_section): Modify production to use 2 different rules to
27277 achieve the same thing. 1 s/r conflict down !
27278 Clean out commented, useless, non-reducing dimension_separator rules.
27280 * class.cs (TypeContainer.attributes): New member to hold list
27281 of attributes for a type.
27282 (Struct::Struct): Modify to take one more argument, the attribute list.
27283 (Class::Class): Ditto.
27284 (Field::Field): Ditto.
27285 (Method::Method): Ditto.
27286 (Property::Property): Ditto.
27288 * cs-parser.jay (struct_declaration): Update constructor call to
27289 pass in the attributes too.
27290 (class_declaration): Ditto.
27291 (constant_declaration): Ditto.
27292 (field_declaration): Ditto.
27293 (method_header): Ditto.
27294 (fixed_parameter): Ditto.
27295 (parameter_array): Ditto.
27296 (property_declaration): Ditto.
27298 * constant.cs (Constant::Constant): Update constructor similarly.
27299 Use System.Collections.
27301 * parameter.cs (Parameter::Parameter): Update as above.
27303 2001-09-02 Ravi Pratap <ravi@ximian.com>
27305 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
27306 (TypeContainer.delegates): New member to hold list of delegates.
27308 * cs-parser.jay (delegate_declaration): Implement the action correctly
27309 this time as I seem to be on crack ;-)
27311 2001-09-02 Miguel de Icaza <miguel@ximian.com>
27313 * rootcontext.cs (RootContext::IsNamespace): new function, used to
27314 tell whether an identifier represents a namespace.
27316 * expression.cs (NamespaceExpr): A namespace expression, used only
27317 temporarly during expression resolution.
27318 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
27319 utility functions to resolve names on expressions.
27321 2001-09-01 Miguel de Icaza <miguel@ximian.com>
27323 * codegen.cs: Add hook for StatementExpressions.
27325 * class.cs: Fix inverted test for static flag in methods.
27327 2001-09-02 Ravi Pratap <ravi@ximian.com>
27329 * class.cs (Operator::CheckUnaryOperator): Correct error number used
27330 to make it coincide with MS' number.
27331 (Operator::CheckBinaryOperator): Ditto.
27333 * ../errors/errors.txt : Remove error numbers added earlier.
27335 * ../errors/cs1019.cs : Test case for error # 1019
27337 * ../errros/cs1020.cs : Test case for error # 1020
27339 * cs-parser.jay : Clean out commented cruft.
27340 (dimension_separators, dimension_separator): Comment out. Ostensibly not
27341 used anywhere - non-reducing rule.
27342 (namespace_declarations): Non-reducing rule - comment out.
27344 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
27345 with TypeContainer::AddEnum.
27347 * delegate.cs : New file for delegate handling classes.
27348 (Delegate): Class for declaring delegates.
27350 * makefile : Update.
27352 * cs-parser.jay (delegate_declaration): Implement.
27354 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
27356 * class.cs (Event::Define): Implement.
27357 (Event.EventBuilder): New member.
27359 * class.cs (TypeContainer::Populate): Update to define all enums and events
27361 (Events): New property for the events arraylist we hold. Shouldn't we move to using
27362 readonly fields for all these cases ?
27364 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27366 * class.cs (Property): Revamp to use the convention of making fields readonly.
27367 Accordingly modify code elsewhere.
27369 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
27370 the Define method of the Property class.
27372 * class.cs : Clean up applied patch and update references to variables etc. Fix
27374 (TypeContainer::Populate): Update to define all the properties we have. Also
27375 define all enumerations.
27377 * enum.cs (Define): Implement.
27379 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
27381 * cs-parser.jay (overloadable_operator): The semantic value is an
27382 enum of the Operator class.
27383 (operator_declarator): Implement actions.
27384 (operator_declaration): Implement.
27386 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
27387 validity of definitions.
27388 (Operator::CheckBinaryOperator): Static method to check for binary operators
27389 (TypeContainer::AddOperator): New method to add an operator to a type.
27391 * cs-parser.jay (indexer_declaration): Added line to actually call the
27392 AddIndexer method so it gets added ;-)
27394 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
27395 already taken care of by the MS compiler ?
27397 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27399 * class.cs (Operator): New class for operator declarations.
27400 (Operator::OpType): Enum for the various operators.
27402 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
27404 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
27405 ostensibly handle this in semantic analysis.
27407 * cs-parser.jay (general_catch_clause): Comment out
27408 (specific_catch_clauses, specific_catch_clause): Ditto.
27409 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
27410 (catch_args, opt_catch_args): New productions.
27411 (catch_clause): Rewrite to use the new productions above
27412 (catch_clauses): Modify accordingly.
27413 (opt_catch_clauses): New production to use in try_statement
27414 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
27415 and re-write the code in the actions to extract the specific and
27416 general catch clauses by being a little smart ;-)
27418 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
27419 Hooray, try and catch statements parse fine !
27421 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27423 * statement.cs (Block::GetVariableType): Fix logic to extract the type
27424 string from the hashtable of variables.
27426 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
27427 I end up making that mistake ;-)
27428 (catch_clauses): Fixed gross error which made Key and Value of the
27429 DictionaryEntry the same : $1 !!
27431 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27433 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
27435 * cs-parser.jay (event_declaration): Correct to remove the semicolon
27436 when the add and remove accessors are specified.
27438 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
27440 * cs-parser.jay (IndexerDeclaration): New helper class to hold
27441 information about indexer_declarator.
27442 (indexer_declarator): Implement actions.
27443 (parsing_indexer): New local boolean used to keep track of whether
27444 we are parsing indexers or properties. This is necessary because
27445 implicit_parameters come into picture even for the get accessor in the
27446 case of an indexer.
27447 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
27449 * class.cs (Indexer): New class for indexer declarations.
27450 (TypeContainer::AddIndexer): New method to add an indexer to a type.
27451 (TypeContainer::indexers): New member to hold list of indexers for the
27454 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27456 * cs-parser.jay (add_accessor_declaration): Implement action.
27457 (remove_accessor_declaration): Implement action.
27458 (event_accessors_declaration): Implement
27459 (variable_declarators): swap statements for first rule - trivial.
27461 * class.cs (Event): New class to hold information about event
27463 (TypeContainer::AddEvent): New method to add an event to a type
27464 (TypeContainer::events): New member to hold list of events.
27466 * cs-parser.jay (event_declaration): Implement actions.
27468 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
27470 * cs-parser.jay (dim_separators): Implement. Make it a string
27471 concatenating all the commas together, just as they appear.
27472 (opt_dim_separators): Modify accordingly
27473 (rank_specifiers): Update accordingly. Basically do the same
27474 thing - instead, collect the brackets here.
27475 (opt_rank_sepcifiers): Modify accordingly.
27476 (array_type): Modify to actually return the complete type string
27477 instead of ignoring the rank_specifiers.
27478 (expression_list): Implement to collect the expressions
27479 (variable_initializer): Implement. We make it a list of expressions
27480 essentially so that we can handle the array_initializer case neatly too.
27481 (variable_initializer_list): Implement.
27482 (array_initializer): Make it a list of variable_initializers
27483 (opt_array_initializer): Modify accordingly.
27485 * expression.cs (New::NType): Add enumeration to help us
27486 keep track of whether we have an object/delegate creation
27487 or an array creation.
27488 (New:NewType, New::Rank, New::Indices, New::Initializers): New
27489 members to hold data about array creation.
27490 (New:New): Modify to update NewType
27491 (New:New): New Overloaded contructor for the array creation
27494 * cs-parser.jay (array_creation_expression): Implement to call
27495 the overloaded New constructor.
27497 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
27499 * class.cs (TypeContainer::Constructors): Return member
27500 constructors instead of returning null.
27502 2001-08-26 Miguel de Icaza <miguel@ximian.com>
27504 * typemanager.cs (InitCoreTypes): Initialize the various core
27505 types after we have populated the type manager with the user
27506 defined types (this distinction will be important later while
27507 compiling corlib.dll)
27509 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
27510 on Expression Classification. Now all expressions have a method
27511 `Resolve' and a method `Emit'.
27513 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
27514 generation from working. Also add some temporary debugging
27517 2001-08-24 Miguel de Icaza <miguel@ximian.com>
27519 * codegen.cs: Lots of code generation pieces. This is only the
27520 beginning, will continue tomorrow with more touches of polish. We
27521 handle the fundamentals of if, while, do, for, return. Others are
27522 trickier and I need to start working on invocations soon.
27524 * gen-treedump.cs: Bug fix, use s.Increment here instead of
27527 * codegen.cs (EmitContext): New struct, used during code
27528 emission to keep a context. Most of the code generation will be
27531 * cs-parser.jay: Add embedded blocks to the list of statements of
27532 this block. So code generation proceeds in a top down fashion.
27534 2001-08-23 Miguel de Icaza <miguel@ximian.com>
27536 * statement.cs: Add support for multiple child blocks.
27538 2001-08-22 Miguel de Icaza <miguel@ximian.com>
27540 * codegen.cs (EmitCode): New function, will emit the code for a
27541 Block of code given a TypeContainer and its ILGenerator.
27543 * statement.cs (Block): Standard public readonly optimization.
27544 (Block::Block constructors): Link children.
27545 (Block::Child): Child Linker.
27546 (Block::EmitVariables): Emits IL variable declarations.
27548 * class.cs: Drop support for MethodGroups here, delay until
27550 (Method::): Applied the same simplification that I did before, and
27551 move from Properties to public readonly fields.
27552 (Method::ParameterTypes): Returns the parameter types for the
27553 function, and implements a cache that will be useful later when I
27554 do error checking and the semantic analysis on the methods is
27556 (Constructor::GetCallingConvention): Renamed from CallingConvetion
27557 and made a method, optional argument tells whether this is a class
27558 or a structure to apply the `has-this' bit.
27559 (Method::GetCallingConvention): Implement, returns the calling
27561 (Method::Define): Defines the type, a second pass is performed
27562 later to populate the methods.
27564 (Constructor::ParameterTypes): implement a cache similar to the
27565 one on Method::ParameterTypes, useful later when we do semantic
27568 (TypeContainer::EmitMethod): New method. Emits methods.
27570 * expression.cs: Removed MethodGroup class from here.
27572 * parameter.cs (Parameters::GetCallingConvention): new method.
27574 2001-08-21 Miguel de Icaza <miguel@ximian.com>
27576 * class.cs (TypeContainer::Populate): Drop RootContext from the
27579 (Constructor::CallingConvention): Returns the calling convention.
27580 (Constructor::ParameterTypes): Returns the constructor parameter
27583 (TypeContainer::AddConstructor): Keep track of default constructor
27584 and the default static constructor.
27586 (Constructor::) Another class that starts using `public readonly'
27587 instead of properties.
27589 (Constructor::IsDefault): Whether this is a default constructor.
27591 (Field::) use readonly public fields instead of properties also.
27593 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
27594 track of static constructors; If none is used, turn on
27595 BeforeFieldInit in the TypeAttributes.
27597 * cs-parser.jay (opt_argument_list): now the return can be null
27598 for the cases where there are no arguments.
27600 (constructor_declarator): If there is no implicit `base' or
27601 `this', then invoke the default parent constructor.
27603 * modifiers.cs (MethodAttr): New static function maps a set of
27604 modifiers flags into a MethodAttributes enum
27605 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
27606 MethodAttr, TypeAttr to represent the various mappings where the
27607 modifiers are used.
27608 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
27610 2001-08-19 Miguel de Icaza <miguel@ximian.com>
27612 * parameter.cs (GetParameterInfo): Fix bug where there would be no
27615 * interface.cs (PopulateIndexer): Implemented the code generator
27616 for interface indexers.
27618 2001-08-17 Miguel de Icaza <miguel@ximian.com>
27620 * interface.cs (InterfaceMemberBase): Now we track the new status
27623 (PopulateProperty): Implement property population. Woohoo! Got
27624 Methods and Properties going today.
27626 Removed all the properties for interfaces, and replaced them with
27627 `public readonly' fields.
27629 2001-08-16 Miguel de Icaza <miguel@ximian.com>
27631 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
27632 initialize their hashtables/arraylists only when they are needed
27633 instead of doing this always.
27635 * parameter.cs: Handle refs and out parameters.
27637 * cs-parser.jay: Use an ArrayList to construct the arguments
27638 instead of the ParameterCollection, and then cast that to a
27641 * parameter.cs: Drop the use of ParameterCollection and use
27642 instead arrays of Parameters.
27644 (GetParameterInfo): Use the Type, not the Name when resolving
27647 2001-08-13 Miguel de Icaza <miguel@ximian.com>
27649 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
27650 and instead use public readonly fields.
27652 * class.cs: Put back walking code for type containers.
27654 2001-08-11 Miguel de Icaza <miguel@ximian.com>
27656 * class.cs (MakeConstant): Code to define constants.
27658 * rootcontext.cs (LookupType): New function. Used to locate types
27661 2001-08-08 Miguel de Icaza <miguel@ximian.com>
27663 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
27664 this System.Reflection code is. Kudos to Microsoft
27666 * typemanager.cs: Implement a type cache and avoid loading all
27667 types at boot time. Wrap in LookupType the internals. This made
27668 the compiler so much faster. Wow. I rule!
27670 * driver.cs: Make sure we always load mscorlib first (for
27671 debugging purposes, nothing really important).
27673 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
27674 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
27676 * rootcontext.cs: Lookup types on their namespace; Lookup types
27677 on namespaces that have been imported using the `using' keyword.
27679 * class.cs (TypeContainer::TypeAttr): Virtualize.
27680 (Class::TypeAttr): Return attributes suitable for this bad boy.
27681 (Struct::TypeAttr): ditto.
27682 Handle nested classes.
27683 (TypeContainer::) Remove all the type visiting code, it is now
27684 replaced with the rootcontext.cs code
27686 * rootcontext.cs (GetClassBases): Added support for structs.
27688 2001-08-06 Miguel de Icaza <miguel@ximian.com>
27690 * interface.cs, statement.cs, class.cs, parameter.cs,
27691 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
27692 Drop use of TypeRefs, and use strings instead.
27694 2001-08-04 Miguel de Icaza <miguel@ximian.com>
27698 * class.cs (Struct::Struct): set the SEALED flags after
27699 checking the modifiers.
27700 (TypeContainer::TypeAttr): new property, returns the
27701 TypeAttributes for a class.
27703 * cs-parser.jay (type_list): Oops, list production was creating a
27704 new list of base types.
27706 * rootcontext.cs (StdLib): New property.
27707 (GetInterfaceTypeByName): returns an interface by type name, and
27708 encapsulates error handling here.
27709 (GetInterfaces): simplified.
27710 (ResolveTree): Encapsulated all the tree resolution here.
27711 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
27714 * driver.cs: Add support for --nostdlib, to avoid loading the
27715 default assemblies.
27716 (Main): Do not put tree resolution here.
27718 * rootcontext.cs: Beginning of the class resolution.
27720 2001-08-03 Miguel de Icaza <miguel@ximian.com>
27722 * rootcontext.cs: Provide better error reporting.
27724 * cs-parser.jay (interface_base): set our $$ to be interfaces.
27726 * rootcontext.cs (CreateInterface): Handle the case where there
27727 are no parent interfaces.
27729 (CloseTypes): Routine to flush types at the end.
27730 (CreateInterface): Track types.
27731 (GetInterfaces): Returns an array of Types from the list of
27732 defined interfaces.
27734 * typemanager.c (AddUserType): Mechanism to track user types (puts
27735 the type on the global type hash, and allows us to close it at the
27738 2001-08-02 Miguel de Icaza <miguel@ximian.com>
27740 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
27741 RecordInterface instead.
27743 * cs-parser.jay: Updated to reflect changes above.
27745 * decl.cs (Definition): Keep track of the TypeBuilder type that
27746 represents this type here. Not sure we will use it in the long
27747 run, but wont hurt for now.
27749 * driver.cs: Smaller changes to accomodate the new code.
27751 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
27754 * rootcontext.cs (CreateInterface): New method, used to create
27755 the System.TypeBuilder type for interfaces.
27756 (ResolveInterfaces): new entry point to resolve the interface
27758 (CodeGen): Property, used to keep track of the code generator.
27760 2001-07-26 Miguel de Icaza <miguel@ximian.com>
27762 * cs-parser.jay: Add a second production for delegate_declaration
27765 (enum_body): Put an opt_comma here instead of putting it on
27766 enum_body or enum_member_declarations so we can handle trailing
27767 commas on enumeration members. Gets rid of a shift/reduce.
27769 (type_list): Need a COMMA in the middle.
27771 (indexer_declaration): Tell tokenizer to recognize get/set
27773 * Remove old targets.
27775 * Re-add the parser target.
27777 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27779 * cs-parser.jay: Add precendence rules for a number of operators
27780 ot reduce the number of shift/reduce conflicts in the grammar.
27782 2001-07-17 Miguel de Icaza <miguel@ximian.com>
27784 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
27787 Get rid of old crufty code.
27789 * rootcontext.cs: Use this to keep track of the parsed
27790 representation and the defined types available to the program.
27792 * gen-treedump.cs: adjust for new convention.
27794 * type.cs: Split out the type manager, and the assembly builder
27797 * typemanager.cs: the type manager will live here now.
27799 * cil-codegen.cs: And the code generator here.
27801 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
27803 * makefile: Fixed up for easy making.
27805 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27807 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
27810 (unary_expression): Expand pre_increment_expression and
27811 post_decrement_expression to reduce a shift/reduce.
27813 2001-07-11 Simon Cozens
27815 * cs-tokenizer.cs: Hex numbers should begin with a 0.
27817 Improve allow_keyword_as_indent name.
27819 2001-06-19 Miguel de Icaza <miguel@ximian.com>
27821 * Adjustments for Beta2.
27823 2001-06-13 Miguel de Icaza <miguel@ximian.com>
27825 * decl.cs: Added `Define' abstract method.
27826 (InTransit): new property, used to catch recursive definitions.
27828 * interface.cs: Implement `Define'.
27830 * modifiers.cs: Map Modifiers.constants to
27831 System.Reflection.TypeAttribute flags.
27833 * class.cs: Keep track of types and user-defined types.
27834 (BuilderInit): New method for creating an assembly
27835 (ResolveType): New function to launch the resolution process, only
27836 used by interfaces for now.
27838 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
27839 that are inserted into the name space.
27841 2001-06-08 Miguel de Icaza <miguel@ximian.com>
27843 * ARGH. I have screwed up my tree so many times due to the use of
27844 rsync rather than using CVS. Going to fix this at once.
27846 * driver.cs: Objetify driver. Load assemblies, use assemblies to
27849 2001-06-07 Miguel de Icaza <miguel@ximian.com>
27851 * Experiment successful: Use System.Type rather that our own
27854 2001-05-25 Miguel de Icaza <miguel@ximian.com>
27856 * cs-parser.jay: Removed nsAliases from here.
27858 Use new namespaces, handle `using XXX;'
27860 * namespace.cs: Reimplemented namespace handling, use a recursive
27861 definition of the class. Now we can keep track of using clauses
27862 and catch invalid using clauses.
27864 2001-05-24 Miguel de Icaza <miguel@ximian.com>
27866 * gen-treedump.cs: Adapted for all the renaming.
27868 * expression.cs (Expression): this class now has a Type property
27869 which returns an expression Type.
27871 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
27872 `Type', as this has a different meaning now in the base
27874 2001-05-22 Miguel de Icaza <miguel@ximian.com>
27876 * interface.cs, class.cs: Removed from all the sources the
27877 references to signature computation, as we can not do method
27878 signature computation during the parsing time, as we are not
27879 trying to solve at that point distinguishing:
27883 void a (NS.Blah x) {}
27886 Which depending on the context might be valid or not, as we do not
27887 know if Blah is the same thing as NS.Blah at that point.
27889 * Redid everything so the code uses TypeRefs now instead of
27890 Types. TypeRefs are just temporary type placeholders, that need
27891 to be resolved. They initially have a pointer to a string and the
27892 current scope in which they are used. This is used later by the
27893 compiler to resolve the reference to an actual Type.
27895 * DeclSpace is no longer a CIR.Type, and neither are
27896 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
27897 are all DeclSpaces, but no Types.
27899 * type.cs (TypeRefManager): This implements the TypeRef manager,
27900 which keeps track of all the types that need to be resolved after
27901 the parsing has finished.
27903 2001-05-13 Miguel de Icaza <miguel@ximian.com>
27905 * ARGH. We are going to have to store `foreach' as a class rather
27906 than resolving it, as we need to verify error 1579 after name
27907 resolution. *OR* we could keep a flag that says `This request to
27908 IEnumerator comes from a foreach statement' which we can then use
27909 to generate the error.
27911 2001-05-10 Miguel de Icaza <miguel@ximian.com>
27913 * class.cs (TypeContainer.AddMethod): we now add methods to the
27914 MethodGroup instead of the method hashtable.
27916 * expression.cs: Add MethodGroup abstraction, which gets us one
27917 step closer to the specification in the way we handle method
27920 * cs-parser.jay (primary_expression): qualified_identifier now
27921 tried to match up an identifier to a local variable reference or
27922 to a parameter reference.
27924 current_local_parameters is now a parser global variable that
27925 points to the current parameters for the block, used during name
27928 (property_declaration): Now creates an implicit `value' argument to
27931 2001-05-09 Miguel de Icaza <miguel@ximian.com>
27933 * parameter.cs: Do not use `param' arguments as part of the
27934 signature, per the spec.
27936 2001-05-08 Miguel de Icaza <miguel@ximian.com>
27938 * decl.cs: Base class for classes, structs and interfaces. This
27939 is the "Declaration Space"
27941 * cs-parser.jay: Use CheckDef for checking declaration errors
27942 instead of having one on each function.
27944 * class.cs: Factor out some code for handling error handling in
27945 accordance to the "Declarations" section in the "Basic Concepts"
27946 chapter in the ECMA C# spec.
27948 * interface.cs: Make all interface member classes derive from
27949 InterfaceMemberBase.
27951 2001-05-07 Miguel de Icaza <miguel@ximian.com>
27953 * Many things: all interfaces are parsed and generated in
27954 gen-treedump. Support for member variables, constructors,
27955 destructors, properties, constants is there.
27957 Beginning of the IL backend, but very little done, just there for
27960 2001-04-29 Miguel de Icaza <miguel@ximian.com>
27962 * cs-parser.jay: Fix labeled statement.
27964 * cs-tokenizer.cs (escape): Escape " and ' always.
27965 ref_line, ref_name: keep track of the line/filename as instructed
27966 by #line by the compiler.
27969 2001-04-27 Miguel de Icaza <miguel@ximian.com>
27971 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
27972 to match the values in System.CodeDOM.
27974 Divid renamed to Divide.
27976 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
27978 (Statements.set): remove.
27980 * System.CodeDOM/CodeCatchClause.cs: always have a valid
27983 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
27984 falseStatements always have valid values.
27986 * cs-parser.jay: Use System.CodeDOM now.