1 2005-01-24 Martin Baulig <martin@ximian.com>
3 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
4 merging an implicit block, just use its reachability.
6 * statement.cs (Block.Resolve): Make the unreachable code check
7 work wrt. implicit blocks; see test-337 from #63842.
9 2005-01-21 Alp Toker <alp@atoker.com>
11 * cs-parser.jay: destructor_declaration's container is PartialContainer
12 not Class when partial types are used, so use Kind prop instead of
15 2005-01-22 Miguel de Icaza <miguel@ximian.com>
17 * cs-parser.jay: Improve error reporting when an interface
20 2005-01-20 Dick Porter <dick@ximian.com>
22 * support.cs: SeekableStreamReader fix from Sandor Dobos
23 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
24 chars are read. Fixes bug 70369.
26 2005-01-20 Raja R Harinath <rharinath@novell.com>
28 * cs-parser.jay (catch_clause): Simplify current_block handling
31 2005-01-17 Miguel de Icaza <miguel@ximian.com>
33 * convert.cs (ImplicitStandardConversionExists): Synchronize the
34 code with ImplicitStandardConversion to handle the implicit
35 conversion of method groups into valid delegate invocations.
37 The problem is that in parameter handling we were using this code
38 path. Fixes bug #64698
40 2005-01-19 Raja R Harinath <rharinath@novell.com>
42 * cs-parser.jay: Fix several infelicities.
43 - Avoid assigning to the parser value stack. Code like
44 '$3 = null' is unclean. Synthesize a value for the code block
46 - Avoid using oob_stack for storing location information. Use ...
47 (_mark_): ... this. New (empty) rule. Saves the current location
49 (foreach_statement): Avoid using oob_stack for current_block
50 handling. Use technique used in for_statement and
51 using_statement. Synthesize a value for the code block to store
52 additional intermediate information.
54 2005-01-13 Miguel de Icaza <miguel@ximian.com>
56 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
57 of a different type is only allowed to private fields of a
58 containing type, not on fields of a base class.
60 See test-174.cs and error cs0122-9.cs
62 2005-01-13 Raja R Harinath <rharinath@novell.com>
64 Fix test-335.cs (bug #58126).
65 * cs-parser.jay (argument): Split out non-expression parts of the
66 rule into 'non_simple_argument'.
67 (invocation_expression): Support parenthesized invocations with
68 multiple arguments, and with single non-simple arguments.
70 2005-01-13 Raja R Harinath <rharinath@novell.com>
72 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
75 2005-01-12 Raja R Harinath <rharinath@novell.com>
77 Fix cs0038-1.cs, cs1640-6.cs.
78 * ecore.cs (Expression.Resolve): Remove special-case for
79 SimpleName in error-handling.
80 (Expression.almostMatchedMembers): Relax access permission to
82 (Expression.MemberLookupFailed): Handle duplicates in
83 almostMatchedMembers list.
84 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
85 * expression.cs (New.DoResolve): Report CS1540 for more cases.
86 * typemanager.cs (GetFullNameSignature): Use the MethodBase
87 overload if the passed in MemberInfo is a MethodBase.
89 2005-01-12 Marek Safar <marek.safar@seznam.cz>
92 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
93 for non-CAS & merge permission sets properly.
95 2005-01-11 Raja R Harinath <rharinath@novell.com>
97 Improve standard-compliance of simple name and member access
98 resolution. Fixes bugs #52697, #57200, #67520, #69519.
99 * ecore.cs (FullNamedExpression): New abstract base class
100 for Namespaces and TypeExpressions.
101 (ResolveFlags.SimpleName): Remove.
102 (SimpleName): Remove support for dotted names.
103 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
104 DeclSpace.FindType and DeclSpace.LookupType.
105 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
106 (Expression.ExprClassName): Make member function.
107 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
108 a namespace. Remove creation of dotted "SimpleName"s.
109 (MemberAccess.DoResolve): Likewise.
110 * decl.cs (DeclSpace.Cache): Make private.
111 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
112 (DeclSpace.FindType): Update.
113 (DeclSpace.LookupType): Move here from RootContext. Return a
115 * namespace.cs (Namespace): Derive from FullNamedExpression
116 so that it can be part of expression resolution.
117 (Namespace.Lookup): Return an FullNamedExpression.
118 (NamespaceEntry.LookupAlias): Lookup aliases only in current
120 * rootcontext.cs (NamespaceLookup): Remove.
121 (LookupType): Move to DeclSpace.
122 * attribute.cs (CheckAttributeType): Update.
123 * doc.cs (FindDocumentedType): Remove allowAlias argument.
124 (FindDocumentedTypeNonArray): Likewise.
126 2005-01-11 Raja R Harinath <rharinath@novell.com>
128 Fix cs0509.cs, cs1632.cs.
129 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
130 is the same as IsInterface.
131 (TypeContainer.GetClassBases): Likewise.
132 * statement.cs (LabeledStatement.ig): New field.
133 (LabeledStatement.LabelTarget): Save ILGenerator which created the
135 (LabeledStatement.DoEmit): Check that the label was created with
136 the same ILGenerator.
138 2005-01-10 Marek Safar <marek.safar@seznam.cz>
141 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
142 accessors to its properties.
144 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
145 from accessors to property.
147 2005-01-10 Marek Safar <marek.safar@seznam.cz>
150 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
153 2005-01-08 Miguel de Icaza <miguel@ximian.com>
155 * attribute.cs: Check for null and empty strings.
157 I have lost another battle to Paolo.
159 2005-01-07 Marek Safar <marek.safar@seznam.cz>
162 * class.cs (PropertyMethod): Set Parent field in ctors.
163 (SetMethod.InternalParameters): Add unsafe switch hack.
164 Override MarkForDuplicationCheck where it is appropriate.
166 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
167 It says whether container allows members with the same name.
169 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
170 Removed is_method parameter.
172 2005-01-06 Duncan Mak <duncan@ximian.com>
174 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
175 because the previous change led to incorrect reporting of CS1032
176 ("Cannot define/undefine preprocessor symbols after first token in
177 file"). Instead of using `tokens_seen' as the only flag that
178 triggers CS1040, introduce `comments_seen'. This new flag is used
179 to signify having seen comments on the current line, so it is
180 unset after a newline.
182 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
184 * doc.cs : When searching for a type, find nested type too.
185 This fixes bug #71040.
187 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
190 - Warn missing member comment on those classes which also does not
191 have doc comments. Fixed bug #71041.
192 - Don't warn missing doc comment on default constructor.
195 2005-01-06 Duncan Mak <duncan@ximian.com>
197 * cs-tokenizer.cs (xtoken): After handling traditional C-style
198 comments, set `tokens_seen' to true. This allows us to detect
199 misplaced preprocessor directives (i.e. not at the beginning of
200 the a line, nor after whitespaces). In that case, report error
201 CS1040. This fixes bug #56460.
203 * cs-parser.jay (interface_member_declaration): Add checks for
204 IsExplicitImpl, and report CS0541 error if an interface member is
205 defined as an explicit interface declaration.
207 2005-01-06 Marek Safar <marek.safar@seznam.cz>
210 * class.cs (PropertyMethod): Set Parent field in ctors.
211 (SetMethod.InternalParameters): Add unsafe switch hack.
213 * decl.cs (MemberCore.Parent): Cannot be readonly.
215 2005-01-06 Raja R Harinath <rharinath@novell.com>
217 * decl.cs (DeclSpace.ResolveType): Remove.
218 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
219 Merge in code from ...
220 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
221 * class.cs, enum.cs: Update to changes.
223 2005-01-06 Miguel de Icaza <miguel@ximian.com>
225 * anonymous.cs: Ensure that we init the scope of our parent if it
226 has not been initialized yet.
228 2004-12-30 Duncan Mak <duncan@ximian.com>
230 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
231 if field.FieldBuilder is null. Fixes #70758.
233 * convert.cs: Fixed some typos and updated some of the comments.
234 (ImplicitStandardConversionExists):
235 (TryImplicitIntConversion): If `target_type' is an interface and
236 the type of `ic' implements this interface, return true or a new
237 BoxedCast instead of null. This fixes #70468.
239 2004-12-29 Duncan Mak <duncan@ximian.com>
241 * expression.cs (Argument.Emit): Check that Expr is
242 IMemoryLocation before casting to it, and report CS1510 otherwise.
246 2004-12-21 Ben Maurer <bmaurer@ximian.com>
248 * statement.cs (Block.ThisVariable): remove the recursion here, to
249 make the --profile more sane.
251 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
253 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
254 assembly, by JB Evain.
256 2004-12-17 Raja R Harinath <rharinath@novell.com>
258 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
259 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
260 "parent" refers to enclosing type/class. "base" refers to superclass.
262 2004-12-17 Raja R Harinath <rharinath@novell.com>
264 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
265 Ensure that we only have GlobalAttributes.
266 * attribute.cs (Attribute.Emit): Make non-virtual.
267 (GlobalAttribute.Emit): Remove.
268 (Attribute.Resolve): Make virtual.
269 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
270 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
271 the argument. Don't create one.
272 (Attribute.GetObsoleteAttribute): Likewise.
273 (Attribute.GetClsCompliantAttributeValue): Likewise.
274 * class.cs, decl.cs: Update to changes.
276 2004-12-17 Marek Safar <marek.safar@seznam.cz>
278 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
280 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
282 * statement.cs (Foreach.Resolve): Add error 186 report.
284 2004-12-16 Marek Safar <marek.safar@seznam.cz>
286 * expression.cs (Conditional.DoResolve): Add warning 429.
288 * statement.cs (If.Resolve): Add warning 665.
290 2004-12-16 Raja R Harinath <rharinath@novell.com>
292 New invariant: RootContext.Tree.Types.NamespaceEntry == null
293 except when in the parser, and in GlobalAttribute.
294 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
295 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
296 RootContext.Tree.Types.NamespaceEntry once work is done.
297 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
298 and resets RootContext.Tree.Types.NamespaceEntry.
300 2004-12-15 Marek Safar <marek.safar@seznam.cz>
302 * cs-parser.jay: Don't create a block for every variable.
304 2004-12-14 Miguel de Icaza <miguel@ximian.com>
306 * location.cs: Provide extra information.
308 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
309 variables from the captured environment, it is the ldarg_0.
311 2004-12-14 Marek Safar <marek.safar@seznam.cz>
313 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
316 * class.cs: Changed warning level for 169 to avoid developer
317 displeasure from warning flooding. It will be changed back when they
318 fix most of current BCL warnings.
320 * RootContext.cs: Pushed default WarningLevel to 3.
322 * statement.cs: Removed unused variable.
324 2004-12-14 Marek Safar <marek.safar@seznam.cz>
326 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
327 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
328 Add error 502 report.
329 (StaticClass.DefineType): Add error 441 report.
330 (Class.AllowedModifiersProp): New virtual property as temporary
331 extension to AllowedModifiers.
332 (Class.DefineType): Add error 418 report. Moved ModFlags check here
333 to share implementation with StaticClass and don't call virtual
336 * driver.cs (MainDriver): Add error 1558 test.
338 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
339 report. Moved error 36 test here.
341 * statement.cs (Throw.Resolve): Add error 724 report.
343 * typemanager.cs: Add out_attribute_type core type.
345 2004-12-13 Marek Safar <marek.safar@seznam.cz>
347 * class.cs (TypeContainer.VerifyClsCompliance): Add error
349 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
351 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
354 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
356 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
357 Add error 3023 report.
358 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
360 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
363 2004-12-12 John Luke <john.luke@gmail.com>
365 * driver.cs (AddArgs): take -- into account when
366 adding arguments, fixes bug 65710
368 2004-12-12 Martin Baulig <martin@ximian.com>
370 * expression.cs (Unary.TryReduceNegative): Added support for
371 SByteConstant and ByteConstant.
372 (Unary.Reduce): Check error values from TryReduceNegative().
374 2004-12-10 Marek Safar <marek.safar@seznam.cz>
376 * attributes.cs (Attribute.Resolve): Avoid multiple error report
377 and report exception as error 182.
379 2004-12-10 Raja R Harinath <rharinath@novell.com>
381 * driver.cs (Main): Fix message when there are warnings.
383 2004-12-09 Miguel de Icaza <miguel@ximian.com>
385 * delegate.cs: Fixed my fix from yesterday, sorry about that.
387 2004-12-09 Marek Safar <marek.safar@seznam.cz>
389 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
390 Reduced number of warnings.
392 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
394 2004-12-08 Miguel de Icaza <miguel@ximian.com>
396 * driver.cs: Removed message.
398 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
400 2004-12-08 <vargaz@freemail.hu>
402 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
404 2004-12-08 Martin Baulig <martin@ximian.com>
406 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
407 instead of a CS3002 for properties and indexer.
409 2004-12-08 Martin Baulig <martin@ximian.com>
411 * decl.cs (MemberName.ToString): Make this work again.
413 2004-12-08 Marek Safar <marek.safar@seznam.cz>
415 * attribute.cs (Resolve): Add error 591 detection.
417 * class.cs (FieldMember.Define): Add error 1547 detection.
418 (Indexer.Define): Add error 620 detection.
419 (Operator.Define): Add error 590 detection.
421 * ecore.cs: Missing argument for error 79.
423 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
426 2004-12-07 Marek Safar <marek.safar@seznam.cz>
429 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
432 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
434 * cs-parser.jay : handle doc comments on implicit/explicit operators.
435 Some operator comments were suppressed.
436 * doc.cs : Implicit/explicit operator name in doc comments are like
437 "op_Explicit(type)~returnType", so added suffix handling.
439 2004-12-07 Martin Baulig <martin@ximian.com>
442 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
443 (MemberCore.GetClsCompliantAttributeValue): Likewise.
444 (DeclSpace.ec): New protected field; store the EmitContext here.
445 (DeclSpace.EmitContext): New public property; moved here from
447 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
450 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
451 (Enum.Emit): Don't create a new EmitContext.
453 * delegate.cs (Delegate.DefineType): Always create the
456 * iterators.cs (Iterators.DefineIterator): Create a new
457 EmitContext and store it in `ec'.
459 2004-08-24 Martin Baulig <martin@ximian.com>
462 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
463 this for accessibility checks.
464 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
465 IsNestedFamilyAccessible.
466 (TypeManager.IsSubclassOf): New method, do what the name actually
469 2004-12-06 Raja R Harinath <rharinath@novell.com>
471 Fix crash on cs0657-17.cs.
472 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
473 Use RootContext.Tree.Types, not 'new RootTypes ()'.
474 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
475 the case where the NamespaceEntry gets overwritten.
477 2004-12-06 Marek Safar <marek.safar@seznam.cz>
480 * ecore.cs (ResolveBoolean): Tiny refactoring.
482 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
483 of right expression resolving when left is false constant and
484 operator is LogicalAnd OR true constant and operator is LogicalOr.
486 * statement.cs (ResolveUnreachable): Always reports warning.
488 2004-12-05 Miguel de Icaza <miguel@ximian.com>
490 * class.cs: Distinguish between 1721 and 1722 (just a little help
493 2004-12-03 Miguel de Icaza <miguel@ximian.com>
495 * delegate.cs: Only allow this on new versions of the language.
497 2004-12-02 Duncan Mak <duncan@ximian.com>
499 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
501 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
502 here as a static method. Take an additional bool out parameter
503 `must_do_cs1540_check' for signaling to InstanceResolve.
504 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
505 member field from PropertyExpr class and made it an argument of
507 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
508 check for MarshalByRefObject, and report CS0122 instead of CS1540.
509 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
510 and `remove_accessor' as well as InstanceResolve: report CS0122
515 2004-12-03 Raja R Harinath <rharinath@novell.com>
517 Fix test-327.cs, test-328.cs, and put in early infrastructure
518 for eventually fixing #52697.
519 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
520 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
522 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
523 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
524 (VerifyUsing, error246): Update.
525 * rootcontext.cs (RootContext.NamespaceLookup): Just use
526 'NamespaceEntry.LookupNamespaceOrType'.
528 2004-12-03 Martin Baulig <martin@ximian.com>
530 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
531 method as our child, call AnonymousMethod.Compatible() on it.
533 2004-12-03 Raja R Harinath <rharinath@novell.com>
535 Disable XML documentation support in 'basic' profile.
536 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
537 Redirect XmlElement to System.Object.
538 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
539 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
540 * mcs.exe.sources: Add doc-bootstrap.cs.
541 * doc-bootstrap.cs: New file. Contains empty stub implementation
544 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
546 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
547 comments are allowed.
549 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
551 * delegate.cs: Add checks for subtypes in paramaters and return values
552 in VerifyMethod () to add support for Covariance/Contravariance
555 2004-12-02 Miguel de Icaza <miguel@ximian.com>
557 * report.cs: Remove extra closing parenthesis.
559 * convert.cs (Error_CannotImplicitConversion): If the name of the
560 types are the same, provide some extra information.
562 * class.cs (FieldBase): Use an unused bit field from the field to
563 encode the `has_offset' property from the FieldMember. This saves
564 a couple of Ks on bootstrap compilation.
566 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
567 method as our child, return the AnonymousMethod resolved
570 * expression.cs (New.DoResolve): Allow return values from
571 NewDelegate to also include AnonymousMethods.
575 2004-12-02 Marek Safar <marek.safar@seznam.cz>
578 * attribute.cs (Resolve): Improved implementation of params
581 * support.cs (ParameterData): Add HasParams to be faster.
583 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
585 all things are for /doc support:
587 * doc.cs: new file that supports XML documentation generation.
588 * mcs.exe.sources: added doc.cs.
590 Handle /doc command line option.
591 Report error 2006 instead of 5 for missing file name for /doc.
592 Generate XML documentation when required, after type resolution.
594 Added support for picking up documentation (/// and /** ... */),
595 including a new XmlCommentState enumeration.
597 Added lines to fill Documentation element for field, constant,
598 property, indexer, method, constructor, destructor, operator, event
599 and class, struct, interface, delegate, enum.
600 Added lines to warn incorrect comment.
602 Added Documentation field (passed only when /doc was specified).
604 Added DocComment, DocCommentHeader, GenerateDocComment() and
605 OnGenerateDocComment() and some supporting private members for
606 /doc feature to MemberCore.
608 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
610 Added overriden DocCommentHeader.
612 Added overriden DocCommentHeader and GenerateDocComment().
614 2004-12-01 Miguel de Icaza <miguel@ximian.com>
616 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
617 unwrapping the enumeration values, chain to
618 DoConstantNumericPromotions again, so we can promote things to the
619 fundamental types (takes care of enums that are bytes, sbytes).
623 2004-12-01 Raja R Harinath <rharinath@novell.com>
625 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
626 Fix long-standing bug in type-lookup. Use FindType instead of
627 LookupType when ec.ResolvingTypeTree.
628 (Attribute.ResolveType, Attribute.Resolve)
629 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
631 (Attributes.Search): Remove internal version. Update.
632 (Attributes.SearchMulti): Update.
633 (Attributes.GetClsCompliantAttribute): Remove.
634 (Attributes.GetIndexerNameAttribute): Remove.
635 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
636 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
637 * class.cs (Indexer.Define): Likewise.
639 2004-12-01 Marek Safar <marek.safar@seznam.cz>
642 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
643 MarshallByReference members access.
645 * expression.cs: Use CheckMarshallByRefAccess;
646 Better error CS0197 message.
648 * report.cs: Print whole related error message.
650 2004-11-30 Raja R Harinath <rharinath@novell.com>
652 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
653 the current directory to help debugging.
655 2004-11-29 Marek Safar <marek.safar@seznam.cz>
657 * class (GetClassBases): Better error 60 report.
658 (EventProperty): Disabled warning 67 detection.
660 2004-11-29 Marek Safar <marek.safar@seznam.cz>
663 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
665 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
668 2004-11-29 Marek Safar <marek.safar@seznam.cz>
671 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
673 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
675 2004-11-26 Miguel de Icaza <miguel@ximian.com>
677 * attribute.cs (Attribute.Resolve): Refine error reporting and
678 report a cs0117 if the identifier does not exist, to distinguish
679 from 0617 which is a miss-use of the actual identifier.
681 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
682 between cs0070 and cs0079.
684 * class.cs (MemberBase.DoDefine): When reporting a wrong
685 accessibility level, we use MethodCore to compare instead of
686 Method (this was a regression in some refactoring effort).
688 So now we correctly report cs0056 again.
690 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
691 testing the target_type (which was known to be object_type) and
692 not the source type (which is anonymous_method).
694 Fixed reporting of error cs1660.
696 * expression.cs (UserCast.Source): Expose the underlying cast.
698 * statement.cs (Switch.SwitchGoverningType): Sort the list of
699 allowed types to find a match to int32 first (most common).
701 In addition, it ignores any ImplicitUserConversions that did an
702 internal implicit conversion (as the switch statement allows only
703 one integral conversion to exist).
705 * class.cs (PartialContainer.Create): rename `name' to
706 `member_name' for clarity. Then replace the string calls with a
707 call to MemberName.GetPartialName, as now using
708 MemberName.ToString is an error (this is due to the side effects
709 it had, that were fixed in the past).
711 This will restore the error reporting on a number of partial class
712 errors that were missusing this (and getting an exception as a
713 results, which is now just a plain textual warning, because
714 yyparse debug output would crash otherwise).
716 2004-11-26 Raja R Harinath <rharinath@novell.com>
718 * Makefile (PROGRAM_INSTALL_DIR): Remove.
720 2004-11-25 Ben Maurer <bmaurer@ximian.com>
722 * rootcontext.cs (LookupType): Make sure to cache lookups that
723 don't give us a negative result. This saves about 5% of corlib
726 2004-11-25 Miguel de Icaza <miguel@ximian.com>
728 * report.cs (AbstractMessage.Print): messages are sent to stderr
730 * class.cs (TypeContainer.GetClassBases): It is an error to have a
731 non-interface in the list of interfaces (at this point, either
732 parent was properly set, or a base class is being listed in the
735 This flags error 1722, and resolves the crash from bug 69259.
737 2004-11-25 Ben Maurer <bmaurer@ximian.com>
739 * statement.cs (Using.EmitExpressionFinally): make this work right
740 for valuetypes. Fixes 69926.
742 2004-11-25 Miguel de Icaza <miguel@ximian.com>
744 * const.cs (Const.ChangeType): Cope with the "0 literal can be
745 converted to an enum" here, before we try to change the underlying
746 type. This code exists, but it is a different code path than the
747 one used while encoding constants.
749 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
750 old bug: when converting from the null literal to a pointer,
751 return an EmptyCast, not the NullLiteral.
753 This fixes #69921, the recent null_type changes probably made this
756 (ImplicitReferenceConversionExists): In addition, resynchronized
757 the code here, so it matches the same code in
758 ImplicitReferenceConversionExists for the `from any class-type S
759 to any interface-type T'.
762 2004-11-25 Marek Safar <marek.safar@seznam.cz>
764 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
766 2004-11-24 Miguel de Icaza <miguel@ximian.com>
768 * cs-parser.jay: Use verbosity accordingly.
770 2004-11-24 Marek Safar <marek.safar@seznam.cz>
772 * expression.cs (Unary.ResolveOperator): Do not report warning;
773 AddressOf reads from variable.
775 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
777 2004-11-24 Marek Safar <marek.safar@seznam.cz>
781 * attribute.cs (Attributable): Removed CheckTargets.
782 (Attributes.Emit): Explicit attribute targets are tested here.
784 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
785 not enabled for interfaces.
787 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
788 (GetAssemblyName): Ouch next bug there.
790 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
792 * expression.cs: Error 275 added.
794 2004-11-23 Marek Safar <marek.safar@seznam.cz>
796 Fix bug #69177 (Implemented decimal constant support)
798 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
799 (BinaryFold): Add DecimalConstant.
801 * const.cs (Define): Decimal constant
803 (ChangeType): Add decimal type handling.
804 (LookupConstantValue): Don't set value for decimal type but
805 emit DecimalConstantAttribute. Needed for constant optimization.
807 * constant.cs (ToDecimal): New method.
808 (ConvertToDecimal): New method.
809 (IntConstant): Implemented ConvertToDecimal.
810 (DecimalConstant.Emit): Emit optimized version for decimals in
813 * expression.cs (ResolveOperator): Changed order of constant
814 reduction to work correctly with native types which have
815 overloaded operators.
816 (ResolveMemberAccess): Extract constant value from attribute
819 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
821 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
822 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
823 (ChangeType): Decimal is special.
824 (TypeToCoreType): Add decimal type.
826 2004-11-22 Marek Safar <marek.safar@seznam.cz>
828 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
831 2004-11-22 Marek Safar <marek.safar@seznam.cz>
833 * class.cs (EventField.ApplyAttributeBuilder): Fix error
836 2004-11-19 Marek Safar <marek.safar@seznam.cz>
838 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
840 * pending.cs (PendingImplementation): Grab only interfaces.
842 2004-11-19 Marek Safar <marek.safar@seznam.cz>
844 * statement.cs (ForeachHelperMethods): Add location member and
847 2004-11-19 Raja R Harinath <rharinath@novell.com>
849 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
850 automatically handled by executable.make.
851 (PROGRAM): Make profile-specific.
853 2004-11-18 Marek Safar <marek.safar@seznam.cz>
855 * expression.cs (DoResolveBase): Fixed wrong warning for out
858 2004-11-18 Martin Baulig <martin@ximian.com>
860 Merged latest changes into gmcs. Please keep this comment in
861 here, it makes it easier for me to see what changed in MCS since
862 the last time I merged.
864 2004-11-17 Raja R Harinath <rharinath@novell.com>
866 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
867 (TypeHandle.GetMemberCache): New.
868 (TypeHandle.TypeHandle): Update.
869 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
870 (TypeManager.LookupParentInterfacesCache):
871 Rename from LookupInterfaceCache. Optimize slightly.
872 (TypeManager.MemberLookup_FindMembers): Update.
873 * decl.cs (MemberCache.MemberCache): Set Container to null in the
875 (AddCacheContents): Rename from AddHashtable.
876 * class.cs (TypeContainer.parent_container): Remove.
877 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
878 (TypeContainer.DoDefineMembers): Don't initialize it.
879 Update to name changes.
881 2004-11-17 Miguel de Icaza <miguel@ximian.com>
883 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
884 that factors the code to check access modifiers on override.
886 (PropertyBase): Use the code here.
888 Patch from Lluis S'anchez, fixes bug #69361.
890 2004-11-15 Miguel de Icaza <miguel@ximian.com>
892 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
893 routine that is used to report the use of a captured variable
894 whose address has been taken.
896 There are two checks: one when variables are being captured and
897 the other check is when the address of a variable is taken.
899 (because an anonymous methods might be resolved before *or* after
900 the address has been taken) and
902 * expression.cs (Conditional.DoResolve): Remove the special
903 casing that Martin added to trueExpr and falseExpr being both
904 NullLiteral. We get the right behavior now just by introducing
905 the null_type into the compiler.
907 * convert.cs (ExplicitConversion): Change the code to use
908 null_type instead of testing `expr is NullLiteral'.
909 (ImplicitConversionStandard): use null_type too.
910 (ImplicitReferenceConversionExists): use null_type too.
911 (ImplicitReferenceConversion): use null_type too.
913 * literal.cs: The type of `NullLiteral' is now null_type instead
915 (Resolve): Set the type here.
917 * typemanager.cs: Introduce null_type.
919 2004-11-17 Martin Baulig <martin@ximian.com>
921 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
922 direction, like FindMembers() does. Fixes #69546, testcase is in
925 2004-11-16 Martin Baulig <martin@ximian.com>
927 This is based on a patch from Marek Safar, see bug #69082.
928 Fixes bugs #63705 and #67130.
930 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
931 method; create a MemberCache for an interface type and cache the
934 * decl.cs (IMemberContainer.ParentContainer): Removed.
935 (IMemberContainer.ParentCache): New property.
936 (MemberCache.SetupCacheForInterface): Removed.
937 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
938 to create a cache for an interface's "parent".
940 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
943 2004-11-16 Martin Baulig <martin@ximian.com>
945 Merged back from gmcs; these changes already went into gmcs a
949 (TypeManager.AddUserType): Removed the `ifaces' argument.
950 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
952 (TypeManager.AddUserInterface): Removed.
953 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
955 (TypeManager.GetInterfaces): Likewise.
956 (TypeManager.GetExplicitInterfaces): Likewise.
958 * ecore.cs (TypeExpr.GetInterfaces): Removed.
960 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
961 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
963 2004-11-14 Ben Maurer <bmaurer@ximian.com>
965 * statement.cs: Avoid adding bools to a hashtable.
967 2004-11-07 Miguel de Icaza <miguel@ximian.com>
969 * expression.cs (Invocation.OverloadResolve): Flag error if we are
970 calling an unsafe method from a safe location.
972 2004-11-06 Marek Safar <marek.safar@seznam.cz>
975 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
977 2004-11-06 Miguel de Icaza <miguel@ximian.com>
979 * namespace.cs (VerifyUsing): use GetPartialName instead of
982 2004-11-05 Miguel de Icaza <miguel@ximian.com>
984 * statement.cs (Return.Resolve): Fix regression in typo: if
985 `in_exc', we have to request a NeedReturnLabel, this was a typo
986 introduced in the anonymous method check-in. Fixes #69131.
988 * Indexers were using the ShortName when defining themselves,
989 causing a regression in the compiler bootstrap when applying the
990 patch from 2004-11-02 (first part), now they use their full name
993 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
995 * driver.cs: Strip the path from the names of embedded resources. Fixes
998 2004-11-04 Raja R Harinath <rharinath@novell.com>
1000 Fix error message regression: cs0104-2.cs.
1001 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
1002 (AliasEntry.Resolve): Update.
1003 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
1005 (RootContext.LookupType): Update.
1007 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
1009 * cs-parser.jay: Add support for handling accessor modifiers
1010 * class: Add support port accessor modifiers and error checking,
1011 define PropertyMethod.Define as virtual (not abstract anymore)
1012 * ecore.cs: Add checking for proeprties access with access modifiers
1013 * iterators.cs: Modify Accessor constructor call based in the modified
1015 2004-11-02 Ben Maurer <bmaurer@ximian.com>
1017 * expression.cs (StringConcat): Handle being called twice,
1018 as when we have a concat in a field init with more than two
1021 2004-11-02 Miguel de Icaza <miguel@ximian.com>
1023 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
1024 special case explicit implementations, we should always produce
1025 the .property or .event declaration.
1027 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
1028 since it will not return correct data if people use this
1029 unresolved in the presence of using statements (see test-313).
1031 * class.cs (MethodData.Define): If we are an explicit interface
1032 implementation, set the method name to the full name of the
1033 interface plus the name of the method.
1035 Notice that using the method.MethodName.GetFullName() does not
1036 work, as it will only contain the name as declared on the source
1037 file (it can be a shorthand in the presence of using statements)
1038 and not the fully qualifed type name, for example:
1042 class D : ICloneable {
1043 object ICloneable.Clone () {
1047 Would produce a method called `ICloneable.Clone' instead of
1048 `System.ICloneable.Clone'.
1050 * namespace.cs (Alias.Resolve): Use GetPartialName.
1052 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1054 * cs-parser.jay: Add error 1055 report.
1056 2004-11-01 Miguel de Icaza <miguel@ximian.com>
1058 * assign.cs (Assign.DoResolve): Only do the transform of
1059 assignment into a New if the types are compatible, if not, fall
1060 through and let the implicit code deal with the errors and with
1061 the necessary conversions.
1063 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1065 * cs-parser.jay: Add error 1031 report.
1067 * cs-tokenizer.cs: Add location for error 1038.
1069 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1071 * cs-parser.jay: Add error 1016 report.
1073 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1075 * cs-parser.jay: Add errors 1575,1611 report.
1077 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1079 * cs-parser.jay: Add error 1001 report.
1081 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1084 * attribute.cs (GetMarshal): Add method argument for
1085 caller identification.
1087 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
1088 agument for GetMarshal and RuntimeMissingSupport.
1090 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1092 * attribute.cs (ExtractSecurityPermissionSet): Removed
1093 TypeManager.code_access_permission_type.
1095 * typemanager.cs: Removed TypeManager.code_access_permission_type.
1097 2004-10-27 Miguel de Icaza <miguel@ximian.com>
1099 * expression.cs (LocalVariableReference.DoResolveLValue): Check
1100 for obsolete use of a variable here. Fixes regression on errors
1101 cs0619-25 and cs0619-26.
1103 2004-10-27 Marek Safar <marek.safar@seznam.cz>
1105 Fix #62358, implemented security attribute encoding.
1107 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
1108 Tests permitted SecurityAction for assembly or other types.
1109 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
1110 data from SecurityPermissionAttribute to PermisionSet class.
1112 * class.cs (ApplyAttributeBuilder): Added special handling
1113 for System.Security.Permissions.SecurityAttribute based types.
1115 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
1116 special handling for System.Security.Permissions.SecurityAttribute
1119 * enum.cs (ApplyAttributeBuilder): Added special handling
1120 for System.Security.Permissions.SecurityAttribute based types.
1122 * parameter.cs (ApplyAttributeBuilder): Added special handling
1123 for System.Security.Permissions.SecurityAttribute based types.
1125 * rootcontext.cs: Next 2 core types.
1127 * typemanager.cs (TypeManager.security_permission_attr_type):
1128 Built in type for the SecurityPermission Attribute.
1129 (code_access_permission_type): Build in type.
1131 2004-10-17 Miguel de Icaza <miguel@ximian.com>
1133 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
1134 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
1135 all of this information into
1136 EmitContext.EmitCapturedVariableInstance.
1138 * codegen.cs (EmitCapturedVariableInstance): move here the
1139 funcionality of emitting an ldarg.0 in the presence of a
1140 remapping. This centralizes the instance emit code.
1142 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
1143 then emit a load of this: it means that we have reached the
1144 topmost ScopeInfo: the one that contains the pointer to the
1145 instance of the class hosting the anonymous method.
1147 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
1148 captures to the topmost CaptureContext.
1150 2004-10-12 Miguel de Icaza <miguel@ximian.com>
1152 * expression.cs (LocalVariableReference): Move the knowledge about
1153 the iterators into codegen's EmitCapturedVariableInstance.
1155 2004-10-11 Miguel de Icaza <miguel@ximian.com>
1157 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
1158 all code paths return a value from an anonymous method (it is the
1159 same as the 161 error, but for anonymous methods).
1161 2004-10-08 Miguel de Icaza <miguel@ximian.com>
1163 The introduction of anonymous methods in the compiler changed
1164 various ways of doing things in the compiler. The most
1165 significant one is the hard split between the resolution phase
1166 and the emission phases of the compiler.
1168 For instance, routines that referenced local variables no
1169 longer can safely create temporary variables during the
1170 resolution phase: they must do so from the emission phase,
1171 since the variable might have been "captured", hence access to
1172 it can not be done with the local-variable operations from the runtime.
1176 (Block.Flags): New flag `IsTopLevel' to indicate that this block
1177 is a toplevel block.
1179 (ToplevelBlock): A new kind of Block, these are the blocks that
1180 are created by the parser for all toplevel method bodies. These
1181 include methods, accessors and anonymous methods.
1183 These contain some extra information not found in regular blocks:
1184 A pointer to an optional CaptureContext (for tracking captured
1185 local variables and parameters). A pointer to the parent
1188 (Return.Resolve): Catch missmatches when returning a value from an
1189 anonymous method (error 1662).
1190 Invoke NeedReturnLabel from the Resolve phase instead of the emit
1193 (Break.Resolve): ditto.
1195 (SwitchLabel): instead of defining the labels during the
1196 resolution phase, we now turned the public ILLabel and ILLabelCode
1197 labels into methods called GetILLabelCode() and GetILLabel() that
1198 only define the label during the Emit phase.
1200 (GotoCase): Track the SwitchLabel instead of the computed label
1201 (its contained therein). Emit the code by using
1202 SwitchLabel.GetILLabelCode ().
1204 (LocalInfo.Flags.Captured): A new flag has been introduce to track
1205 whether the Local has been captured or not.
1207 (LocalInfo.IsCaptured): New property, used to tell whether the
1208 local has been captured.
1210 * anonymous.cs: Vastly updated to contain the anonymous method
1213 The main classes here are: CaptureContext which tracks any
1214 captured information for a toplevel block and ScopeInfo used to
1215 track the activation frames for various local variables.
1217 Each toplevel block has an optional capture context associated
1218 with it. When a method contains an anonymous method both the
1219 toplevel method and the anonymous method will create a capture
1220 context. When variables or parameters are captured, they are
1221 recorded on the CaptureContext that owns them, for example:
1225 MyDelegate d = delegate {
1230 Here `a' will be recorded as captured on the toplevel
1231 CapturedContext, the inner captured context will not have anything
1232 (it will only have data if local variables or parameters from it
1233 are captured in a nested anonymous method.
1235 The ScopeInfo is used to track the activation frames for local
1236 variables, for example:
1238 for (int i = 0; i < 10; i++)
1239 for (int j = 0; j < 10; j++){
1240 MyDelegate d = delegate {
1245 At runtime this captures a single captured variable `i', but it
1246 captures 10 different versions of the variable `j'. The variable
1247 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
1248 recorded on a child.
1250 The toplevel ScopeInfo will also track information like the `this'
1251 pointer if instance variables were referenced (this is necessary
1252 as the anonymous method lives inside a nested class in the host
1253 type of the method).
1255 (AnonymousMethod): Expanded to track the Toplevel, implement
1256 `AnonymousMethod.Compatible' to tell whether an anonymous method
1257 can be converted to a target delegate type.
1259 The routine now also produces the anonymous method content
1261 (AnonymousDelegate): A helper class that derives from
1262 DelegateCreation, this is used to generate the code necessary to
1263 produce the delegate for the anonymous method that was created.
1265 * assign.cs: API adjustments for new changes in
1266 Convert.ImplicitStandardConversionExists.
1268 * class.cs: Adjustments to cope with the fact that now toplevel
1269 blocks are of type `ToplevelBlock'.
1271 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
1272 insteda of standard blocks.
1274 Flag errors if params arguments are passed to anonymous methods.
1276 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
1277 `CurrentAnonymousMethod' which points to the current Anonymous
1278 Method. The variable points to the AnonymousMethod class that
1279 holds the code being compiled. It is set in the new EmitContext
1280 created for the anonymous method.
1282 (EmitContext.Phase): Introduce a variable and an enumeration to
1283 assist in enforcing some rules about when and where we are allowed
1284 to invoke certain methods (EmitContext.NeedsReturnLabel is the
1285 only one that enfonces this right now).
1287 (EmitContext.HaveCaptureInfo): new helper method that returns
1288 whether we have a CapturedContext initialized.
1290 (EmitContext.CaptureVariable): New method used to register that a
1291 LocalInfo must be flagged for capturing.
1293 (EmitContext.CapturedParameter): New method used to register that a
1294 parameters must be flagged for capturing.
1296 (EmitContext.CapturedField): New method used to register that a
1297 field must be flagged for capturing.
1299 (EmitContext.HaveCapturedVariables,
1300 EmitContext.HaveCapturedFields): Return whether there are captured
1301 variables or fields.
1303 (EmitContext.EmitMethodHostInstance): This is used to emit the
1304 instance for the anonymous method. The instance might be null
1305 (static methods), this (for anonymous methods that capture nothing
1306 and happen to live side-by-side with the current method body) or a
1307 more complicated expression if the method has a CaptureContext.
1309 (EmitContext.EmitTopBlock): Routine that drives the emission of
1310 code: it will first resolve the top block, then emit any metadata
1311 and then emit the code. The split is done so that we can extract
1312 any anonymous methods and flag any captured variables/parameters.
1314 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
1315 during this phase, the ILGenerator should not be used as labels
1316 and local variables declared here might not be accessible to any
1317 code that is part of an anonymous method.
1319 Exceptions to this include the temporary variables that are
1320 created by some statements internally for holding temporary
1323 (EmitContext.EmitMeta): New routine, in charge of emitting all the
1326 (EmitContext.TemporaryReturn): This method is typically called
1327 from the Emit phase, and its the only place where we allow the
1328 ReturnLabel to be defined other than the EmitMeta. The reason is
1329 that otherwise we would have to duplicate a lot of logic in the
1330 Resolve phases of various methods that today is on the Emit
1333 (EmitContext.NeedReturnLabel): This no longer creates the label,
1334 as the ILGenerator is not valid during the resolve phase.
1336 (EmitContext.EmitThis): Extended the knowledge in this class to
1337 work in anonymous methods in addition to iterators.
1339 (EmitContext.EmitCapturedVariableInstance): This emits whatever
1340 code is necessary on the stack to access the instance to a local
1341 variable (the variable will be accessed as a field).
1343 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
1344 EmitContext.EmitAddressOfParameter): Routines to support
1345 parameters (not completed at this point).
1347 Removals: Removed RemapLocal and RemapLocalLValue. We probably
1348 will also remove the parameters.
1350 * convert.cs (Convert): Define a `ConstantEC' which points to a
1351 null. This is just to prefity some code that uses
1352 ImplicitStandardConversion code and do not have an EmitContext
1355 The idea is to flag explicitly that at that point in time, it is
1356 known that the conversion will not trigger the delegate checking
1357 code in implicit conversions (which requires a valid
1360 Everywhere: pass new EmitContext parameter since
1361 ImplicitStandardConversionExists now requires it to check for
1362 anonymous method conversions.
1364 (Convert.ImplicitStandardConversionExists): If the type of an
1365 expression is the anonymous_method_type, and the type is a
1366 delegate, we invoke the AnonymousMethod.Compatible method to check
1367 whether an implicit conversion is possible.
1369 (Convert.ImplicitConversionStandard): Only do implicit method
1370 group conversions if the language level is not ISO_1.
1372 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
1373 MethodInfo for the Invoke method. used by Delegate and
1376 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
1377 method conversions if the target type is a delegate.
1379 Removed extra debugging nops.
1381 (LocalVariableReference): Turn the `local_info' into a public
1384 Add `prepared' field, the same hack used for FieldExprs to cope
1385 with composed assignments, as Local variables do not necessarily
1386 operate purely on the stack as they used to: they can be captured
1389 Add `temp' for a temporary result, like fields.
1391 Refactor DoResolve and DoResolveLValue into DoResolveBase.
1393 It now copes with Local variables that are captured and emits the
1394 proper instance variable to load it from a field in the captured
1397 (ParameterReference.DoResolveBase): During the resolve phase,
1398 capture parameters if we are in an anonymous method.
1400 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
1401 anonymous method, use the EmitContext helper routines to emit the
1402 parameter reference.
1404 * iterators.cs: Set RemapToProxy to true/false during the
1407 * parameters.cs (GetParameterByName): New helper method.
1409 * typemanager.cs (anonymous_method_type) a new type that
1410 represents an anonyous method. This is always an internal type,
1411 used as a fencepost to test against the anonymous-methodness of an
1414 2004-10-20 Marek Safar <marek.safar@seznam.cz>
1416 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
1418 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
1420 2004-10-18 Martin Baulig <martin@ximian.com>
1422 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
1423 `Type' directly, but call ResolveType() on it.
1424 (Catch.Resolve): Likewise.
1425 (Foreach.Resolve): Likewise.
1427 2004-10-18 Martin Baulig <martin@ximian.com>
1429 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
1430 `Type' directly, but call ResolveType() on it.
1431 (Probe.DoResolve): Likewise.
1432 (ArrayCreation.LookupType): Likewise.
1433 (TypeOf.DoResolve): Likewise.
1434 (SizeOf.DoResolve): Likewise.
1436 2004-10-18 Martin Baulig <martin@ximian.com>
1438 * expression.cs (Invocation.BetterFunction): Put back
1439 TypeManager.TypeToCoreType().
1441 2004-10-18 Raja R Harinath <rharinath@novell.com>
1443 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
1446 2004-10-18 Martin Baulig <martin@ximian.com>
1448 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
1449 `Type' directly, but call ResolveType() on it.
1451 2004-10-18 Martin Baulig <martin@ximian.com>
1453 * class.cs (FieldMember.Define): Don't access the TypeExpr's
1454 `Type' directly, but call ResolveType() on it.
1455 (MemberBase.DoDefine): Likewise.
1457 * expression.cs (New.DoResolve): Don't access the TypeExpr's
1458 `Type' directly, but call ResolveType() on it.
1459 (ComposedCast.DoResolveAsTypeStep): Likewise.
1461 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
1462 `Type' directly, but call ResolveType() on it.
1464 2004-10-17 John Luke <john.luke@gmail.com>
1466 * class.cs (Operator.GetSignatureForError): use CSharpName
1468 * parameter.cs (Parameter.GetSignatureForError): Returns
1469 correct name even if was not defined.
1471 2004-10-13 Raja R Harinath <rharinath@novell.com>
1474 * class.cs (TypeContainer.EmitContext): New property.
1475 (DefineNestedTypes): Create an emitcontext for each part.
1476 (MethodCore.DoDefineParameters): Use container's emitcontext.
1477 Pass type array to InternalParameters.
1478 (MemberBase.DoDefine): Use container's emitcontext.
1479 (FieldMember.Define): Likewise.
1480 (Event.Define): Likewise.
1481 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1482 Pass type array to InternalParameters.
1483 (SetIndexerMethod.GetParameterInfo): Likewise.
1484 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1485 * delegate.cs (Define): Pass emitcontext to
1486 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1487 array to InternalParameters.
1488 * expression.cs (ParameterReference.DoResolveBase): Pass
1489 emitcontext to GetParameterInfo.
1490 (ComposedCast.DoResolveAsTypeStep): Remove check on
1491 ec.ResolvingTypeTree.
1492 * parameter.cs (Parameter.Resolve): Change argument to
1493 EmitContext. Use ResolveAsTypeTerminal.
1494 (Parameter.GetSignature): Change argument to EmitContext.
1495 (Parameters.ComputeSignature): Likewise.
1496 (Parameters.ComputeParameterTypes): Likewise.
1497 (Parameters.GetParameterInfo): Likewise.
1498 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1499 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1500 * support.cs (InternalParameters..ctor): Remove variant that takes
1502 * typemanager.cs (system_intptr_expr): New.
1503 (InitExpressionTypes): Initialize it.
1505 2004-10-12 Chris Toshok <toshok@ximian.com>
1507 * cs-parser.jay: fix location for try_statement and catch_clause.
1509 2004-10-11 Martin Baulig <martin@ximian.com>
1511 * report.cs: Don't make --fatal abort on warnings, we have
1512 -warnaserror for that.
1514 2004-10-07 Raja R Harinath <rharinath@novell.com>
1516 More DeclSpace.ResolveType avoidance.
1517 * decl.cs (MemberCore.InUnsafe): New property.
1518 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
1519 with newly created EmitContext.
1520 (FieldMember.Define): Likewise.
1521 * delegate.cs (Delegate.Define): Likewise.
1522 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
1523 only if normal name-lookup fails.
1524 (TypeExpr.DoResolve): Enable error-checking.
1525 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
1526 (SizeOf.DoResolve): Likewise.
1527 (ComposedCast.DoResolveAsTypeStep): Likewise.
1528 (StackAlloc.DoResolve): Likewise.
1529 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
1530 (Block.Unsafe): New property.
1531 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
1532 (Unsafe): Set 'unsafe' flag of contained block.
1533 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
1534 (Fixed.Resolve): Likewise.
1535 (Catch.Resolve): Likewise.
1536 (Using.ResolveLocalVariableDecls): Likewise.
1537 (Foreach.Resolve): Likewise.
1539 2004-10-05 John Luke <john.luke@gmail.com>
1541 * cs-parser.jay: add location to error CS0175
1543 2004-10-04 Miguel de Icaza <miguel@ximian.com>
1545 * ecore.cs (Expression.Constantity): Add support for turning null
1548 * const.cs (Const.Define): Allow constants to be reference types
1549 as long as the value is Null.
1551 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
1553 * namespace.cs (NamespaceEntry.Using): No matter which warning
1554 level is set, check if this namespace name has already been added.
1556 2004-10-03 Ben Maurer <bmaurer@ximian.com>
1558 * expression.cs: reftype [!=]= null should always use br[true,false].
1561 2004-10-03 Marek Safar <marek.safar@seznam.cz>
1564 * attribute.cs: Enum conversion moved to
1565 GetAttributeArgumentExpression to be applied to the all
1568 2004-10-01 Raja R Harinath <rharinath@novell.com>
1570 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
1571 * class.c (TypeContainer.DefineType): Flag error if
1572 base types aren't accessible due to access permissions.
1573 * decl.cs (DeclSpace.ResolveType): Move logic to
1574 Expression.ResolveAsTypeTerminal.
1575 (DeclSpace.ResolveTypeExpr): Thin layer over
1576 Expression.ResolveAsTypeTerminal.
1577 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
1578 Refactor code into NestedAccess. Use it.
1579 (DeclSpace.NestedAccess): New.
1580 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
1581 argument to silence errors. Check access permissions.
1582 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
1583 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
1584 (Cast.DoResolve): Likewise.
1585 (New.DoResolve): Likewise.
1586 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
1587 (TypeOf.DoResolve): Likewise.
1589 * expression.cs (Invocation.BetterConversion): Return the Type of
1590 the better conversion. Implement section 14.4.2.3 more faithfully.
1591 (Invocation.BetterFunction): Make boolean. Make correspondence to
1592 section 14.4.2.2 explicit.
1593 (Invocation.OverloadResolve): Update.
1594 (Invocation): Remove is_base field.
1595 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
1596 (Invocation.Emit): Likewise.
1598 2004-09-27 Raja R Harinath <rharinath@novell.com>
1600 * README: Update to changes.
1602 2004-09-24 Marek Safar <marek.safar@seznam.cz>
1604 * cs-parser.jay: Reverted 642 warning fix.
1606 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1609 * decl.cs (FindMemberWithSameName): Indexer can have more than
1612 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1614 * expression.cs (LocalVariableReference.DoResolveLValue):
1615 Do not report warning 219 for out values.
1616 (EmptyExpression.Null): New member to avoid extra allocations.
1618 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1620 * cs-parser.jay: Fix wrong warning 642 report.
1622 * cs-tokenizer.cs (CheckNextToken): New helper;
1623 Inspect next character if is same as expected.
1625 2004-09-23 Martin Baulig <martin@ximian.com>
1627 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1628 (Convert.ImplicitReferenceConversionExists): Likewise.
1630 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1632 * class.cs (Operator.Define): Add error 448 and 559 report.
1634 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1636 * class.cs (MemberBase.IsTypePermitted): New protected
1637 method for checking error CS0610.
1639 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1641 * class.cs (TypeContainer.HasExplicitLayout): New property
1642 Returns whether container has StructLayout attribute set Explicit.
1643 (FieldMember): New abstract class for consts and fields.
1644 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1645 (Field): Reuse FieldMember.
1647 * const.cs (Const): Reuse FieldMember.
1649 * rootcontext.cs: EmitConstants call moved to class.
1651 2004-09-22 Martin Baulig <martin@ximian.com>
1653 Thanks to Peter Sestoft for this bug report.
1655 * expression.cs (Conditional): If both the `trueExpr' and the
1656 `falseExpr' is a NullLiteral, return a NullLiteral.
1658 2004-09-22 Martin Baulig <martin@ximian.com>
1660 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1661 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1662 for the "get_Current" call.
1664 2004-09-22 Martin Baulig <martin@ximian.com>
1666 Marek and me just fixed one of our oldest bugs: #28562 :-)
1668 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1670 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1671 we're an EnumConstant, just return that.
1672 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1673 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1674 to get the value which'll actually be written into the attribute.
1675 However, we have to use GetValue() to access the attribute's value
1678 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1680 * constant.cs (Constant.IsNegative): New abstract property
1683 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1684 (StackAlloc.DoResolve): Reused IsNegative.
1686 2004-09-21 Martin Baulig <martin@ximian.com>
1688 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
1689 if we're used in an iterator, we may be called from different
1692 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
1693 we actually have an exception block.
1695 2004-09-20 John Luke <jluke@cfl.rr.com>
1697 * class.cs, cs-parser.jay: Improve the error report for 1520:
1698 report the actual line where the error happens, not where the
1701 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
1702 Pass location information that was available elsewhere.
1704 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
1706 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
1707 runtime to delay sign assemblies.
1709 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1711 * cs-parser.jay: Do not report the stack trace, this is barely
1714 2004-08-22 John Luke <john.luke@gmail.com>
1716 * driver.cs : check that a resource id is not already used
1717 before adding it, report CS1508 if it is, bug #63637
1719 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1721 * ecore.cs: Removed dead code.
1723 2004-09-18 Marek Safar <marek.safar@seznam.cz>
1725 * class.cs: Do not report warning CS0067 on the interfaces.
1727 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1729 * cs-parser.jay: Add error 504 report.
1731 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1733 * rootcontext.cs: WarningLevel is 4 by default now.
1735 * statement.cs (Fixed.Resolve): Do not null
1738 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1741 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
1742 deep search when property is not virtual.
1743 (PropertyExpr.ResolveAccessors): Make one call for both
1746 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1749 * statement.cs: Error 152 report constains also location.
1751 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1754 * const.cs: Explicitly set constant as static.
1756 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1759 * cs-parser.jay: Add error 1017 report.
1761 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1763 Fixed bug #59980, #64224
1764 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
1766 * typemanager.cs (IsSpecialMethod): Simplified
1768 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1770 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
1771 condition with better params.
1773 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1776 * attribute.cs (Resolve): Property has to have both
1779 2004-09-14 Martin Baulig <martin@ximian.com>
1781 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1783 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1786 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1787 called and is obsolete then this member suppress message
1788 when call is inside next [Obsolete] method or type.
1790 * expression.cs: Use TestObsoleteMethodUsage member.
1792 2004-09-14 Martin Baulig <martin@ximian.com>
1794 * cs-parser.jay: Sync a bit with the GMCS version.
1796 2004-09-14 Martin Baulig <martin@ximian.com>
1798 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
1799 (CSharpParser.yacc_verbose_flag): New public field.
1801 * genericparser.cs: Removed.
1803 2004-09-14 Raja R Harinath <rharinath@novell.com>
1805 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
1807 2004-09-13 Marek Safar <marek.safar@seznam.cz>
1809 * class.cs (MethodCore.CheckBase): Fix bug #65757.
1811 2004-09-10 Martin Baulig <martin@ximian.com>
1813 Backported my MemberName changes from GMCS into MCS.
1815 - we are now using a special `MemberName' class instead of using
1816 strings; in GMCS, the `MemberName' also contains the type
1819 - changed the grammar rules a bit:
1820 * the old `member_name' is now a `namespace_or_type_name':
1821 The rule is that we use `namespace_or_type_name' everywhere
1822 where we expect either a "member name" (GetEnumerator) or a
1823 "member name" with an explicit interface name
1824 (IEnumerable.GetEnumerator).
1825 In GMCS, the explicit interface name may include type arguments
1826 (IEnumerable<T>.GetEnumerator).
1827 * we use `member_name' instead of just `IDENTIFIER' for
1829 The rule is that we use `member_name' wherever a member may
1830 have type parameters in GMCS.
1832 * decl.cs (MemberName): New public class.
1833 (MemberCore.MemberName): New public readonly field.
1834 (MemberCore.ctor): Take a `MemberName' argument, not a string.
1835 (DeclSpace): Likewise.
1837 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
1838 * enum.cs (Enum.ctor): Likewise.
1840 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
1842 (AliasEntry.ctor): Take a MemberName, not an Expression.
1843 (AliasEntry.UsingAlias): Likewise.
1845 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
1846 (IMethodData.MemberName): Changed type from string to MemberName.
1847 (MemberBase.ExplicitInterfaceName): Likewise.
1848 (AbstractPropertyEventMethod.SetupName): Make this private.
1849 (AbstractPropertyEventMethod.ctor): Added `string prefix'
1850 argument; compute the member name here.
1851 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
1852 on the `member.MemberName' and the `prefix'.
1854 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
1856 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
1857 thus, we get a `MemberName' instead of a `string'. These
1858 declarations may have type parameters in GMCS.
1859 (interface_method_declaration, delegate_declaration): Likewise.
1860 (class_declaration, interface_declaration): Likewise.
1861 (method_header): Use `namespace_or_type_name' instead of
1862 `member_name'. We may be an explicit interface implementation.
1863 (property_declaration, event_declaration): Likewise.
1864 (member_name): This is now just an `IDENTIFIER', not a
1865 `namespace_or_type_name'.
1866 (type_name, interface_type): Removed.
1867 (namespace_or_type_name): Return a MemberName, not an Expression.
1868 (primary_expression): Use `member_name' instead of `IDENTIFIER';
1869 call GetTypeExpression() on the MemberName to get an expression.
1870 (IndexerDeclaration.interface_type): Changed type from string to
1872 (MakeName): Operate on MemberName's instead of string's.
1874 2004-09-13 Raja R Harinath <rharinath@novell.com>
1877 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
1878 (NamespaceEntry.Lookup): Add new argument to flag if we want the
1879 lookup to avoid symbols introduced by 'using'.
1880 * rootcontext.cs (NamespaceLookup): Update.
1882 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1884 * class.cs (TypeContainer.DoDefineMembers): Do not call
1885 DefineDefaultConstructor for static classes.
1887 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1889 * attribute.cs (Attribute.Resolve): Add error 653 report.
1891 * class.cs (Class.ApplyAttributeBuilder): Add error 641
1893 (Method.ApplyAttributeBuilder): Add error 685 report.
1894 (Operator.Define): Add error 564 report.
1896 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
1898 * expression.cs (Invocation.DoResolve): Add error
1901 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
1904 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1906 * class.cs (ConstructorInitializer.Resolve):
1907 Wrong error number (515->516).
1909 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1911 * class.cs (Indexer.Define): Add error 631 report.
1913 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1915 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
1917 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1919 * expression.cs (Probe.DoResolve): Add error CS0241 report.
1921 2004-09-10 Marek Safar <marek.safar@seznam.cz>
1923 * cs-parser.jay: Added error CS0241 report.
1925 2004-09-10 Raja R Harinath <rharinath@novell.com>
1927 * cs-parser.jay (fixed_statement): Introduce a scope for the
1928 declaration in the 'fixed' statement.
1930 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1932 * cs-parser.jay: Added CS0230 error report.
1934 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1936 * cs-parser.jay: Added errors CS0231 and CS0257 report.
1938 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1940 * expression.cs (Argument.Resolve): Added error CS0192 and
1943 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1945 C# 2.0 #pragma warning feature
1947 * cs-tokenizer.cs (PreProcessPragma): New method;
1948 Handles #pragma directive.
1950 * report.cs (WarningRegions): New class; Support
1951 class for #pragma warning directive. It tests whether
1952 warning is enabled for a given line.
1954 2004-09-08 Miguel de Icaza <miguel@ximian.com>
1956 * const.cs: Add more descriptive error report, tahnks to
1959 2004-09-08 Marek Safar <marek.safar@seznam.cz>
1961 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
1963 2004-09-07 Miguel de Icaza <miguel@ximian.com>
1965 * expression.cs: Apply patch from Ben: Remove dead code from
1966 ArrayCreation, and remove the TurnintoConstant call in const.cs,
1967 as that code just threw an exception anwyays.
1969 * const.cs: Remove the call to the turnintoconstant, for details
1972 * literal.cs: The type of the null-literal is the null type; So
1973 we use a placeholder type (literal.cs:System.Null, defined here)
1976 * expression.cs (Conditional.DoResolve): Remove some old code that
1977 is no longer needed, conversions have been fixed.
1979 (ArrayCreationExpression.DoResolve): Return false if we fail to
1980 resolve the inner expression.
1982 2004-09-07 Raja R Harinath <rharinath@novell.com>
1985 * cs-parser.jay (delegate_declaration): Record a delegate
1986 declaration as a type declaration.
1987 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
1989 2004-09-06 Miguel de Icaza <miguel@ximian.com>
1991 * parameter.cs: Do not crash if the type can not be resolved.
1993 * expression.cs: Report errors with unsafe pointers, fixes #64896
1995 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
1997 * expression.cs: Pointer arith always needs to do a conv.i
1998 if the operand is a long. fix 65320
2000 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2002 Fixed cs0619-37.cs, cs0619-38.cs
2004 * enum.cs (GetObsoleteAttribute): Removed.
2006 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
2007 on Enum member is double staged. The first is tested member
2010 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2012 Fixed #56986, #63631, #65231
2014 * class.cs: (TypeContainer.AddToMemberContainer): New method,
2015 adds member to name container.
2016 (TypeContainer.AddToTypeContainer): New method, adds type to
2018 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
2019 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
2020 AddOperator): Simplified by reusing AddToMemberContainer.
2021 (TypeContainer.UserDefinedStaticConstructor): Changed to property
2023 (Method.CheckForDuplications): Fixed implementation to test all
2025 (MemberBase): Detection whether member is explicit interface
2026 implementation is now in constructor.
2027 (MemberBase.UpdateMemberName): Handles IndexerName.
2028 (Accessor): Changed to keep also location information.
2029 (AbstractPropertyEventMethod): Is derived from MemberCore.
2030 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
2031 will be emited or not.
2032 (PropertyBase.AreAccessorsDuplicateImplementation):
2033 Tests whether accessors are not in collision with some method.
2034 (Operator): Is derived from MethodCore to simplify common
2037 * decl.cs (Flags.TestMethodDuplication): Test for duplication
2039 (DeclSpace.AddToContainer): Adds the member to defined_names
2040 table. It tests for duplications and enclosing name conflicts.
2042 * enum.cs (EnumMember): Clean up to reuse the base structures
2044 2004-09-03 Martin Baulig <martin@ximian.com>
2046 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
2047 into TypeContainer, to make partial classes work again.
2049 2004-09-03 Martin Baulig <martin@ximian.com>
2051 * rootcontext.cs (RootContext.V2): Removed.
2053 2004-03-23 Martin Baulig <martin@ximian.com>
2055 * expression.cs (Invocation.OverloadResolve): Added `bool
2056 may_fail' argument and use it instead of the Location.IsNull() hack.
2058 2004-09-03 Martin Baulig <martin@ximian.com>
2060 Merged latest changes into gmcs. Please keep this comment in
2061 here, it makes it easier for me to see what changed in MCS since
2062 the last time I merged.
2064 2004-09-03 Raja R Harinath <rharinath@novell.com>
2067 * expression.cs (BetterConversion): Don't allow either conversion
2068 to be null. Remove redundant implicit conversion test when 'q ==
2069 null' -- when this function is invoked, we already know that the
2070 implicit conversion exists.
2071 (BetterFunction): Assume that 'best' is non-null. Remove
2072 redundant reimplementation of IsApplicable when 'best' is null.
2073 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
2074 number of arguments.
2075 (IsAncestralType): Extract from OverloadResolve.
2076 (OverloadResolve): Make robust to the MethodGroupExpr being
2077 unsorted. Implement all the logic of Section 14.5.5.1, and
2078 support overloading of methods from multiple applicable types.
2079 Clean up logic somewhat. Don't pass null methods to BetterFunction.
2081 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
2082 (RealError, Warning): Append type of report to related symbol.
2084 2004-09-03 Marek Safar <marek.safar@seznam.cz>
2086 * enum.cs: Fixed CLS-Compliance checks for enum members.
2087 Error tests cs3008-8.cs, cs3014-8.cs
2089 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2091 Fixed bug #62342, #63102
2092 * class.cs: ImplementIndexer uses member.IsExplicitImpl
2093 like ImplementMethod.
2095 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2097 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2100 2004-09-02 Martin Baulig <martin@ximian.com>
2102 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
2103 TypeManager.GetArgumentTypes() rather than calling GetParameters()
2106 2004-09-01 Marek Safar <marek.safar@seznam.cz>
2108 C# 2.0 Static classes implemented
2110 * class.cs (TypeContainer): instance_constructors,
2111 initialized_fields, initialized_static_fields,
2112 default_constructor, base_inteface_types are protected to be
2113 accessible from StaticClass.
2114 (TypeContainer.DefineDefaultConstructor): New virtual method
2115 for custom default constructor generating
2116 (StaticClass): New class to handle "Static classes" feature.
2118 * cs-parser.jay: Handle static keyword on class like instance
2121 * driver.cs: Added "/langversion" command line switch with two
2122 options (iso-1, default).
2124 2004-08-31 Marek Safar <marek.safar@seznam.cz>
2126 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
2128 2004-08-31 Miguel de Icaza <miguel@ximian.com>
2130 * delegate.cs: Style.
2132 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
2134 * delegate.cs: Add seperate instance expr field for miguel.
2136 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2138 * PointerArithmetic (Resolve): make sure we are not doing
2139 pointer arith on void*. Also, make sure we are resolved
2140 by not setting eclass until resolve.
2142 All callers: Make sure that PointerArithmetic gets resolved.
2144 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2146 * ArrayCreation (LookupType): If the type does not resolve
2147 to an array, give an error.
2149 2004-08-27 Marek Safar <marek.safar@seznam.cz>
2151 * statement.cs (Try.Resolve): Fixed bug #64222
2153 2004-08-27 Martin Baulig <martin@ximian.com>
2156 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
2159 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2161 * ecore.cs (Constantify): Get underlying type via
2162 System.Enum.GetUnderlyingType to avoid StackOverflow on the
2163 Windows in special cases.
2165 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2167 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
2168 for obtaining also private methods.
2169 (GetRemoveMethod): Used GetRemoveMethod (true)
2170 for obtaining also private methods.
2172 2004-08-24 Martin Baulig <martin@ximian.com>
2174 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
2175 MethodAttributes.HideBySig for operators.
2177 2004-08-23 Martin Baulig <martin@ximian.com>
2179 Back to the old error reporting system :-)
2181 * report.cs (Message): Removed.
2182 (Report.MessageData, ErrorData, WarningData): Removed.
2183 (Report.Error, Warning): Back to the old system.
2185 2004-08-23 Martin Baulig <martin@ximian.com>
2187 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
2189 * class.cs (TypeContainer.ParentContainer): New public virtual
2190 method; replaces the explicit interface implementation.
2191 (ClassPart.ParentContainer): Override.
2193 2004-08-23 Martin Baulig <martin@ximian.com>
2195 * statement.cs (Switch): Added support for constant switches; see
2196 #59428 or test-285.cs.
2198 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2201 * statement.cs (GetEnumeratorFilter): Removed useless
2202 logic because C# specs is strict. GetEnumerator must be
2205 2004-08-22 Martin Baulig <martin@ximian.com>
2207 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2208 a switch and may break, reset the barrier. Fixes #59867.
2210 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2212 CLS-Compliance speed up (~5% for corlib)
2214 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
2215 New method. Tests container for CLS-Compliant names
2217 * class.cs (TypeContainer.VerifyClsName): New method.
2218 Checks whether container name is CLS Compliant.
2219 (Constructor): Implements IMethodData.
2221 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
2222 low-case table for CLS Compliance test.
2223 (MemberCache.VerifyClsParameterConflict): New method.
2224 Checks method parameters for CS3006 error.
2226 * enum.cs (EnumMember): Is derived from MemberCore.
2227 (Enum.VerifyClsName): Optimized for better performance.
2229 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2231 * report.cs: Renamed Error_T to Error and changed all
2234 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2236 * class.cs (TypeContainer.IndexerArrayList): New inner class
2237 container for indexers.
2238 (TypeContainer.DefaultIndexerName): New constant for default
2239 indexer name. Replaced all "Item" with this constant.
2240 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
2242 * typemanager.cs (TypeManager.default_member_ctor): Cache here
2243 DefaultMemberAttribute constructor.
2245 2004-08-05 Martin Baulig <martin@ximian.com>
2247 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
2250 2004-08-05 Marek Safar <marek.safar@seznam.cz>
2252 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
2253 multi platforms problem.
2255 * compiler.csproj: Included shared files.
2257 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2259 Fix bug 60333, 55971 in the more general way
2260 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2261 Added arg_type argument for constant conversion.
2262 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
2264 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2267 * class.cs (TypeContainer ): New inner classes MethodArrayList,
2268 OperatorArrayList, MethodCoreArrayList for typecontainer
2269 containers. Changed class member types to these new types.
2270 (MethodArrayList.DefineMembers): Added test for CS0659.
2272 2004-08-04 Miguel de Icaza <miguel@ximian.com>
2274 * cfold.cs: Synchronize the folding with the code in expression.cs
2275 Binary.DoNumericPromotions for uint operands.
2277 * attribute.cs: Revert patch from Raja, it introduced a regression
2278 while building Blam-1.2.1 (hard to isolate a test case).
2280 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2284 (TypeContainer.Define): Renamed to DefineContainerMembers because of
2286 (MethodCore.parent_method): New member. The method we're overriding
2287 if this is an override method.
2288 (MethodCore.CheckBase): Moved from Method class and made common.
2289 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
2291 (MethodCore.CheckForDuplications): New abstract method. For custom
2292 member duplication search in a container
2293 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
2294 method and its return type.
2295 (Event.conflict_symbol): New member. Symbol with same name in the
2299 (MemberCache.FindMemberWithSameName): New method. The method
2300 is looking for conflict with inherited symbols.
2302 2004-08-04 Martin Baulig <martin@ximian.com>
2304 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
2306 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
2308 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2310 * report.cs (Message): New enum for better error, warning reference in
2312 (MessageData): New inner abstract class. It generally handles printing of
2313 error and warning messages.
2314 Removed unused Error, Warning, Message methods.
2316 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2318 Fix for cs0592-8.cs test
2320 (Attributable.ValidAttributeTargets): Made public.
2321 (Attribute.ExplicitTarget): New member for explicit target value.
2322 (Attribute.CheckTargets): Now we translate explicit attribute
2323 target to Target here.
2325 2004-08-03 Ben Maurer <bmaurer@ximian.com>
2327 * ecore.cs (MethodGroupExpr): new IsBase property.
2329 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
2331 * delegate.cs (DelegateCreation): store a MethodGroupExpr
2332 rather than an instance expr.
2334 (DelegateCreation.Emit): Use the method group rather than
2335 the instance expression. Also, if you have base.Foo as the
2336 method for a delegate, make sure to emit ldftn, not ldftnvirt.
2338 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
2340 (NewDelegate.DoResolve): Only check for the existance of Invoke
2341 if the method is going to be needed. Use MethodGroupExpr.
2343 (NewDelegate.Emit): Remove, DelegateCreation implements this.
2345 * expression.cs: For pointer arith., make sure to use
2346 the size of the type, not the size of the pointer to
2349 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2352 * class.cs (Class): Added error CS0502 test.
2354 2004-08-03 John Luke <jluke@cfl.rr.com>
2355 Raja R Harinath <rharinath@novell.com>
2358 * attribute.cs (Attribute.complained_before): New flag.
2359 (Attribute.ResolveType, Attribute.Resolve),
2360 (Attribute.DefinePInvokeMethod): Set it.
2361 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
2363 2004-08-03 Martin Baulig <martin@ximian.com>
2365 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
2366 use a user-defined operator; we still need to do numeric
2367 promotions in case one argument is a builtin type and the other
2368 one has an implicit conversion to that type. Fixes #62322.
2370 2004-08-02 Martin Baulig <martin@ximian.com>
2372 * statement.cs (LocalInfo.Flags): Added `IsThis'.
2373 (LocalInfo.IsThis): New public property.
2374 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
2376 2004-08-01 Martin Baulig <martin@ximian.com>
2378 * class.cs (TypeContainer.GetClassBases): Don't set the default
2379 here since we may get called from GetPartialBases().
2380 (TypeContainer.DefineType): If GetClassBases() didn't return a
2381 parent, use the default one.
2383 2004-07-30 Duncan Mak <duncan@ximian.com>
2385 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
2387 2004-07-30 Martin Baulig <martin@ximian.com>
2389 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
2391 * class.cs (SourceMethod): New public class, derive from the
2392 symbol writer's ISourceMethod.
2393 (Method): Use the new symbol writer API.
2395 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
2396 as argument and use the new symbol writer.
2399 (SourceFile): Implement the symbol writer's ISourceFile.
2400 (Location.SymbolDocument): Removed.
2401 (Location.SourceFile): New public property.
2403 * symbolwriter.cs: Use the new symbol writer API.
2405 2004-07-30 Raja R Harinath <rharinath@novell.com>
2407 * Makefile (install-local): Remove. Functionality moved to
2410 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
2412 * Makefile: Install mcs.exe.config file together with mcs.exe.
2413 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
2414 correct runtime version.
2416 2004-07-25 Martin Baulig <martin@ximian.com>
2419 (TypeContainer.RegisterOrder): Removed, this was unused.
2420 (TypeContainer, interface_order): Removed.
2421 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
2422 TypeContainer as argument since we can also be called with a
2423 `PartialContainer' for a partial class/struct/interface.
2424 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
2425 of checking whether we're an `Interface' - we could be a
2427 (PartialContainer.Register): Override; call
2428 AddClass()/AddStruct()/AddInterface() on our parent.
2430 * cs-parser.jay (interface_member_declaration): Add things to the
2431 `current_container', not the `current_class'.
2433 * rootcontext.cs (RegisterOrder): The overloaded version which
2434 takes an `Interface' was unused, removed.
2436 * typemanager.cs (TypeManager.LookupInterface): Return a
2437 `TypeContainer', not an `Interface'.
2438 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
2439 contain a `PartialContainer' for an interface, so check it's
2440 `Kind' to figure out what it is.
2442 2004-07-25 Martin Baulig <martin@ximian.com>
2444 * class.cs (Class.DefaultTypeAttributes): New public constant.
2445 (Struct.DefaultTypeAttributes): Likewise.
2446 (Interface.DefaultTypeAttributes): Likewise.
2447 (PartialContainer.TypeAttr): Override this and add the
2448 DefaultTypeAttributes.
2450 2004-07-25 Martin Baulig <martin@ximian.com>
2452 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
2453 we can just use the `Parent' field instead.
2455 2004-07-25 Martin Baulig <martin@ximian.com>
2457 * class.cs (TypeContainer.Emit): Renamed to EmitType().
2459 2004-07-25 Martin Baulig <martin@ximian.com>
2461 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
2462 our parts before defining any methods.
2463 (TypeContainer.VerifyImplements): Make this virtual.
2464 (ClassPart.VerifyImplements): Override and call VerifyImplements()
2465 on our PartialContainer.
2467 2004-07-25 Martin Baulig <martin@ximian.com>
2469 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
2471 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
2472 argument, we can just use the `Parent' field instead.
2475 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
2476 (MemberBase.DoDefine): Likewise.
2478 2004-07-24 Martin Baulig <martin@ximian.com>
2480 * decl.cs (MemberCore.Parent): New public field.
2481 (DeclSpace.Parent): Moved to MemberCore.
2483 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
2484 (MemberBase.ctor): Added TypeContainer argument, pass it to our
2486 (FieldBase, Field, Operator): Likewise.
2487 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
2488 (EventField, Event): Likewise.
2490 2004-07-23 Martin Baulig <martin@ximian.com>
2492 * class.cs (PartialContainer): New public class.
2493 (ClassPart): New public class.
2494 (TypeContainer): Added support for partial classes.
2495 (TypeContainer.GetClassBases): Splitted some of the functionality
2496 out into GetNormalBases() and GetPartialBases().
2498 * cs-tokenizer.cs (Token.PARTIAL): New token.
2499 (Tokenizer.consume_identifier): Added some hacks to recognize
2500 `partial', but only if it's immediately followed by `class',
2501 `struct' or `interface'.
2503 * cs-parser.jay: Added support for partial clases.
2505 2004-07-23 Martin Baulig <martin@ximian.com>
2507 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2508 a `DeclSpace' and also made it readonly.
2509 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2510 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2511 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2513 * cs-parser.jay: Pass the `current_class', not the
2514 `current_container' (at the moment, this is still the same thing)
2515 to a new Method, Property, Event, Indexer or Constructor.
2517 2004-07-23 Martin Baulig <martin@ximian.com>
2519 * cs-parser.jay (CSharpParser): Added a new `current_class' field
2520 and removed the `current_interface' one.
2521 (struct_declaration, class_declaration, interface_declaration):
2522 Set `current_class' to the newly created class/struct/interface;
2523 set their `Bases' and call Register() before parsing their body.
2525 2004-07-23 Martin Baulig <martin@ximian.com>
2527 * class.cs (Kind): New public enum.
2528 (TypeContainer): Made this class abstract.
2529 (TypeContainer.Kind): New public readonly field.
2530 (TypeContainer.CheckDef): New public method; moved here from
2532 (TypeContainer.Register): New public abstract method.
2533 (TypeContainer.GetPendingImplementations): New public abstract
2535 (TypeContainer.GetClassBases): Removed the `is_class' and
2536 `is_iface' parameters.
2537 (TypeContainer.DefineNestedTypes): Formerly known as
2539 (ClassOrStruct): Made this class abstract.
2541 * tree.cs (RootTypes): New public type.
2543 2004-07-20 Martin Baulig <martin@ximian.com>
2545 * tree.cs (Tree.RecordNamespace): Removed.
2546 (Tree.Namespaces): Removed.
2548 * rootcontext.cs (RootContext.IsNamespace): Removed.
2550 * cs-parser.jay (namespace_declaration): Just create a new
2551 NamespaceEntry here.
2553 2004-07-20 Martin Baulig <martin@ximian.com>
2555 * statement.cs (ExceptionStatement): New abstract class. This is
2556 now used as a base class for everyone who's using `finally'.
2557 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
2558 our local variables before using them.
2560 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
2561 virtual method. This is used by Yield.Resolve() to "steal" an
2562 outer block's `finally' clauses.
2563 (FlowBranchingException): The .ctor now takes an ExceptionStatement
2566 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
2567 version which takes an ExceptionStatement. This version must be
2568 used to create exception branchings.
2571 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
2572 (Iterator.EmitMoveNext): Added exception support; protect the
2573 block with a `fault' clause, properly handle 'finally' clauses.
2574 (Iterator.EmitDispose): Run all the `finally' clauses here.
2576 2004-07-20 Martin Baulig <martin@ximian.com>
2578 * iterator.cs: This is the first of a set of changes in the
2579 iterator code. Match the spec more closely: if we're an
2580 IEnumerable, then GetEnumerator() must be called. The first time
2581 GetEnumerator() is called, it returns the current instance; all
2582 subsequent invocations (if any) must create a copy.
2584 2004-07-19 Miguel de Icaza <miguel@ximian.com>
2586 * expression.cs: Resolve the constant expression before returning
2589 2004-07-19 Martin Baulig <martin@ximian.com>
2591 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
2592 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
2593 the return type of the new EmitContext.
2595 2004-07-18 Martin Baulig <martin@ximian.com>
2597 * class.cs (Property.Define): Fix iterators.
2599 * iterators.cs (Iterator.Define): Moved the
2600 `container.AddInterator (this)' call here from the .ctor; only do
2601 it if we resolved successfully.
2603 2004-07-17 Miguel de Icaza <miguel@ximian.com>
2605 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
2606 `true' for preprocessing directives that we parse. The return
2607 value indicates whether we should return to regular tokenizing or
2608 not, not whether it was parsed successfully.
2610 In the past if we were in: #if false ... #line #endif, we would
2611 resume parsing after `#line'. See bug 61604.
2613 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
2614 building: IsEnumType should return true only for enums, not for
2615 enums or System.Enum itself. This fixes #61593.
2617 Likely what happened is that corlib was wrong: mcs depended on
2618 this bug in some places. The bug got fixed, we had to add the
2619 hack, which caused bug 61593.
2621 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
2622 that was a workaround for the older conditions.
2624 2004-07-16 Ben Maurer <bmaurer@ximian.com>
2626 * assign.cs: IAssignMethod has a new interface, as documented
2627 inline. All assignment code now uses this new api.
2629 * ecore.cs, expression.cs: All classes which implement
2630 IAssignMethod now use the new interface.
2632 * expression.cs (Invocation): add a hack to EmitCall so that
2633 IndexerAccess can be the target of a compound assignment without
2634 evaluating its arguments twice.
2636 * statement.cs: Handle changes in Invocation api.
2638 2004-07-16 Martin Baulig <martin@ximian.com>
2640 * iterators.cs: Rewrote this. We're now using one single Proxy
2641 class for both the IEnumerable and the IEnumerator interface and
2642 `Iterator' derives from Class so we can use the high-level API.
2644 * class.cs (TypeContainer.AddIterator): New method.
2645 (TypeContainer.DoDefineType): New protected virtual method, which
2646 is called from DefineType().
2647 (TypeContainer.DoDefineMembers): Call DefineType() and
2648 DefineMembers() on all our iterators.
2649 (TypeContainer.Emit): Call Emit() on all our iterators.
2650 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2652 * codegen.cs (EmitContext.CurrentIterator): New public field.
2654 2004-07-15 Martin Baulig <martin@ximian.com>
2657 (TypeManager.not_supported_exception_type): New type.
2659 2004-07-14 Martin Baulig <martin@ximian.com>
2661 * iterators.cs: Use real error numbers.
2663 2004-07-14 Martin Baulig <martin@ximian.com>
2665 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2666 requires this to be a System.Collection.IEnumerable and not a
2667 class implementing that interface.
2668 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2670 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2672 * class.cs: Fixed previous fix, it broke some error tests.
2674 2004-07-12 Martin Baulig <martin@ximian.com>
2676 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2679 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2681 * assign.cs (LocalTemporary): Add new argument: is_address,If
2682 `is_address' is true, then the value that we store is the address
2683 to the real value, and not the value itself.
2685 * ecore.cs (PropertyExpr): use the new local temporary
2686 stuff to allow us to handle X.Y += z (where X is a struct)
2688 2004-07-08 Martin Baulig <martin@ximian.com>
2690 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2691 not always return, just like we're doing in Using.Resolve().
2693 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2695 * cs-parser.jay (fixed_statement): flag this as Pinned.
2697 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2699 * typemanager.cs (TypeManager): Removed MakePinned method, this
2700 mechanism is replaced with the .NET 2.x compatible mechanism of
2701 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2703 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2704 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2705 `IsFixed' property which has a different meaning.
2707 2004-07-02 Raja R Harinath <rharinath@novell.com>
2709 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2710 visible from inside a nested class, not just the names of the
2711 immediately enclosing class.
2714 2004-06-24 Raja R Harinath <rharinath@novell.com>
2716 * expression.cs (BetterConversion): Remove buggy special-case
2717 handling of "implicit constant expression conversions". At this
2718 point, we already know that the conversion is possible -- we're
2719 only checking to see which is better.
2721 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2723 * cs-parser.jay: Added error CS0210 test.
2725 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2727 * cs-parser.jay: Added error CS0134 test.
2729 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2732 * cs-parser.jay: Added error CS0145 test.
2734 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2736 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2738 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2740 * expression.cs (StackAlloc.Resolve): The argument may not
2741 be a constant; deal with this case.
2743 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2745 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2746 GetIndexerAttributeValue.
2747 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2749 * class.cs (Indexer.Define): Added error tests for CS0415,
2752 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2754 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2757 2004-06-23 Martin Baulig <martin@ximian.com>
2759 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2760 neither return nor throw, reset the barrier as well. Fixes #60457.
2762 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2764 * class.cs : EventAttributes is now set to None by default.
2765 This fixes bug #60459.
2767 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2770 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2771 Don't throw exception but return null (it's sufficient now).
2773 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2775 * typemanager.cs (GetArgumentTypes): Faster implementation.
2777 2004-06-18 Martin Baulig <martin@ximian.com>
2779 * attribute.cs (Attribute.Resolve): Check whether we're an
2780 EmptyCast which a Constant child. Fixes #60333.
2782 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2784 * statement.cs (EmitCollectionForeach): Account for the fact that
2785 not all valuetypes are in areas which we can take the address of.
2786 For these variables, we store to a temporary variable. Also, make
2787 sure that we dont emit a `callvirt' on a valuetype method.
2789 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2791 * expression.cs (StackAlloc.DoReSolve): Added test for
2792 negative parameter (CS0247).
2794 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2797 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2799 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2802 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2805 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2807 Fix bug #58254 & cs1555.cs, cs1556.cs
2808 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2810 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2812 * cs-parser.jay: Added error CS1669 test for indexers.
2814 2004-06-11 Martin Baulig <martin@ximian.com>
2816 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2817 call this twice: for params and varargs methods.
2819 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2822 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2824 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2826 * attribute.cs (Attribute.GetValidTargets): Made public.
2829 (AbstractPropertyEventMethod): New class for better code sharing.
2830 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
2832 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
2834 2004-06-11 Raja R Harinath <rharinath@novell.com>
2837 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
2838 that the call to Resolve is part of a MemberAccess.
2839 (Expression.Resolve): Use it for SimpleName resolution.
2840 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
2841 Add 'intermediate' boolean argument.
2842 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
2843 error message when the SimpleName can be resolved ambiguously
2844 between an expression and a type.
2845 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
2847 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
2848 call on the left-side.
2850 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2853 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
2855 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2857 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
2859 2004-06-11 Martin Baulig <martin@ximian.com>
2861 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
2862 varargs methods if applicable.
2864 2004-06-11 Martin Baulig <martin@ximian.com>
2866 * expression.cs (Invocation.EmitCall): Don't use
2867 `method.CallingConvention == CallingConventions.VarArgs' since the
2868 method could also have `CallingConventions.HasThis'.
2870 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2872 * class.cs (Event.GetSignatureForError): Implemented.
2873 Fixed crash in error test cs3010.cs
2875 2004-06-10 Miguel de Icaza <miguel@ximian.com>
2877 * cs-tokenizer.cs: Change the way we track __arglist to be
2878 consistent with the other keywords.
2880 2004-06-09 Miguel de Icaza <miguel@ximian.com>
2882 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
2885 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
2887 * codegen.cs: Check that all referenced assemblies have a strongname
2888 before strongnaming the compiled assembly. If not report error CS1577.
2889 Fix bug #56563. Patch by Jackson Harper.
2890 * typemanager.cs: Added a method to return all referenced assemblies.
2891 Fix bug #56563. Patch by Jackson Harper.
2893 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2896 (Method.ApplyAttributeBuilder): Moved and added conditional
2897 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
2900 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
2902 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2905 * class.cs: (EventField.attribute_targets): Changed default target.
2907 2004-06-08 Martin Baulig <martin@ximian.com>
2909 * expression.cs (Invocation.EmitCall): Enable varargs methods.
2911 2004-06-08 Martin Baulig <martin@ximian.com>
2913 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
2915 2004-06-07 Martin Baulig <martin@ximian.com>
2917 Added support for varargs methods.
2919 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
2922 * cs-parser.jay: Added support for `__arglist'.
2924 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
2926 * expression.cs (Argument.AType): Added `ArgList'.
2927 (Invocation): Added support for varargs methods.
2928 (ArglistAccess): New public class.
2929 (Arglist): New public class.
2931 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
2933 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
2934 a method's top-level block if the method has varargs.
2936 * support.cs (ReflectionParameters, InternalParameters): Added
2937 support for varargs methods.
2939 2004-06-07 Miguel de Icaza <miguel@ximian.com>
2941 * class.cs: Provide location in indexer error report.
2943 * driver.cs: Use standard names.
2945 * namespace.cs: Catch the use of using after a namespace has been
2946 declared also on using aliases.
2948 2004-06-03 Raja R Harinath <rharinath@novell.com>
2951 * typemanager.cs (closure_private_ok, closure_invocation_type)
2952 (closure_qualifier_type, closure_invocation_assembly)
2953 (FilterWithClosure): Move to ...
2954 (Closure): New internal nested class.
2955 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
2956 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
2957 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
2958 (MemberLookup, MemberLookupFailed): Use it.
2959 * expression.cs (New.DoResolve): Treat the lookup for the
2960 constructor as being qualified by the 'new'ed type.
2961 (Indexers.GetIndexersForTypeOrInterface): Update.
2963 2004-06-03 Marek Safar <marek.safar@seznam.cz>
2966 (GetConditionalAttributeValue): New method. Returns
2967 condition of ConditionalAttribute.
2968 (SearchMulti): New method. Returns all attributes of type 't'.
2969 Use it when attribute is AllowMultiple = true.
2970 (IsConditionalMethodExcluded): New method.
2973 (Method.IsExcluded): Implemented. Returns true if method has conditional
2974 attribute and the conditions is not defined (method is excluded).
2975 (IMethodData): Extended interface for ConditionalAttribute support.
2976 (PropertyMethod.IsExcluded): Implemented.
2979 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
2982 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
2985 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
2987 * expression.cs (ArrayCreationExpression): Make this just an
2988 `expression'. It can't be a statement, so the code here was
2991 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2994 * typemanager.cs (GetFullNameSignature): New method for
2997 2004-06-02 Marek Safar <marek.safar@seznam.cz>
3000 * class.cs (MemberBase.GetSignatureForError): New virtual method.
3001 Use this method when MethodBuilder is null.
3002 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
3003 Added test for error CS0626 (MONO reports error for this situation).
3004 (IMethodData.GetSignatureForError): Extended interface.
3006 2004-06-01 Marek Safar <marek.safar@seznam.cz>
3009 (AttributeTester.GetObsoleteAttribute): Returns instance of
3010 ObsoleteAttribute when type is obsolete.
3013 (TypeContainer.VerifyObsoleteAttribute): Override.
3014 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
3015 (MethodCode.VerifyObsoleteAttribute): Override.
3016 (MemberBase.VerifyObsoleteAttribute): Override.
3019 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
3020 and report proper error.
3023 Delegate.VerifyObsoleteAttribute): Override.
3026 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
3027 and report proper error.
3028 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
3031 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
3035 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
3036 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
3037 Added test for ObsoleteAttribute.
3040 (Catch): Derived from Statement.
3042 2004-06-01 Marek Safar <marek.safar@seznam.cz>
3044 Fixed bug #59071 & cs0160.cs
3046 * statement.cs (Try.Resolve): Check here whether order of catch
3047 clauses matches their dependencies.
3049 2004-05-31 Miguel de Icaza <miguel@ximian.com>
3051 * Reverted patch to namespace.cs (Use lookuptypedirect). This
3052 caused a regression: #59343. Referencing nested classes from an
3053 assembly stopped working.
3055 2004-05-31 Martin Baulig <martin@ximian.com>
3057 MCS is now frozen for beta 2.
3059 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3061 * convert.cs: add a trivial cache for overload operator resolution.
3063 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3065 * decl.cs: If possible, use lookuptypedirect here. We can only do
3066 this if there is no `.' after the namespace. Avoids using
3067 LookupType, which does lots of slow processing.
3068 (FindNestedType) New method, does what it says :-).
3069 * namespace.cs: use LookupTypeDirect.
3070 * rootcontext.cs: use membercache, if possible.
3071 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
3073 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3076 According to the spec,
3078 In a member access of the form E.I, if E is a single identifier,
3079 and if the meaning of E as a simple-name (§7.5.2) is a constant,
3080 field, property, localvariable, or parameter with the same type as
3081 the meaning of E as a type-name (§3.8), then both possible
3082 meanings of E are permitted.
3084 We did not check that E as a simple-name had the same type as E as
3087 This trivial check gives us 5-7% on bootstrap time.
3089 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3091 * expression.cs (Invocation.OverloadResolve): Avoid the
3092 use of hashtables and boxing here by allocating on demand.
3094 2004-05-30 Martin Baulig <martin@ximian.com>
3096 * rootcontext.cs (RootContext.LookupType): Don't cache things if
3097 we're doing a silent lookup. Don't try to lookup nested types in
3098 TypeManager.object_type (thanks to Ben Maurer).
3100 2004-05-30 Martin Baulig <martin@ximian.com>
3102 Committing a patch from Ben Maurer.
3104 * rootcontext.cs (RootContext.LookupType): Cache negative results.
3106 2004-05-29 Martin Baulig <martin@ximian.com>
3108 * class.cs (IMethodData.ShouldIgnore): New method.
3110 * typemanager.cs (TypeManager.MethodFlags): Don't take a
3111 `Location' argument, we don't need it anywhere. Use
3112 `IMethodData.ShouldIgnore ()' instead of
3113 `MethodData.GetMethodFlags ()'.
3114 (TypeManager.AddMethod): Removed.
3115 (TypeManager.AddMethod2): Renamed to AddMethod.
3117 2004-05-29 Martin Baulig <martin@ximian.com>
3119 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
3121 * convert.cs (Convert.ImplicitReferenceConversion): If we're
3122 converting from a class type S to an interface type and we already
3123 have an object on the stack, don't box it again. Fixes #52578.
3125 2004-05-29 Martin Baulig <martin@ximian.com>
3127 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3128 Added support for `params' parameters. Fixes #59267.
3130 2004-05-29 Martin Baulig <martin@ximian.com>
3132 * literal.cs (NullPointer): Provide a private .ctor which sets
3133 `type' to TypeManager.object_type. Fixes #59048.
3135 2004-05-29 Martin Baulig <martin@ximian.com>
3137 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
3138 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
3140 * ecore.cs (EventExpr.instance_expr): Make the field private.
3142 2004-05-26 Marek Safar <marek.safar@seznam.cz>
3144 Fixed bug #50080 & cs0214-2.cs
3145 * expression.cs (Cast.DoResolve): Check unsafe context here.
3147 * statement.cs (Resolve.DoResolve): Likewise.
3149 2004-05-26 Martin Baulig <martin@ximian.com>
3151 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
3153 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
3154 (RootContext.LookupType): Pass down the `silent' flag.
3156 2004-05-25 Martin Baulig <martin@ximian.com>
3159 (MethodGroupExpr.IdenticalTypeName): New public property.
3160 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
3161 expression actually refers to a type.
3163 2004-05-25 Martin Baulig <martin@ximian.com>
3165 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
3166 for #56176 and made it actually work.
3168 2004-05-25 Martin Baulig <martin@ximian.com>
3170 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
3171 (FieldExpr, PropertyExpr): Override and implement
3172 CacheTemporaries. Fixes #52279.
3174 2004-05-25 Miguel de Icaza <miguel@ximian.com>
3176 * location.cs: In the new compiler listing a file twice is a
3177 warning, not an error.
3179 2004-05-24 Martin Baulig <martin@ximian.com>
3181 * enum.cs (Enum.DefineType): For the `BaseType' to be a
3182 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
3184 2004-05-24 Martin Baulig <martin@ximian.com>
3186 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
3187 walking the `using' list. Fixes #53921.
3189 2004-05-24 Martin Baulig <martin@ximian.com>
3191 * const.cs (Const.LookupConstantValue): Added support for
3192 EmptyCast's; fixes #55251.
3194 2004-05-24 Martin Baulig <martin@ximian.com>
3196 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
3197 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
3198 which does the CS0135 check. The reason is that we first need to
3199 check whether the variable actually exists.
3201 2004-05-24 Martin Baulig <martin@ximian.com>
3203 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
3204 than RootContext.LookupType() to find the explicit interface
3207 2004-05-24 Raja R Harinath <rharinath@novell.com>
3209 * Makefile: Simplify. Use executable.make.
3210 * mcs.exe.sources: New file. List of sources of mcs.exe.
3212 2004-05-24 Anders Carlsson <andersca@gnome.org>
3216 Use the invariant culture when doing String.Compare for CLS case
3219 2004-05-23 Martin Baulig <martin@ximian.com>
3221 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
3222 don't have any dots. Fixes #52622, added cs0246-8.cs.
3224 * namespace.cs (NamespaceEntry.Lookup): Likewise.
3226 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3228 * class.cs (MemberBase.Define): Reuse MemberType member for
3229 resolved type. Other methods can use it too.
3231 2004-05-23 Martin Baulig <martin@ximian.com>
3233 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
3234 the variable also exists in the current block (otherwise, we need
3235 to report a CS0103). Fixes #58670.
3237 2004-05-23 Martin Baulig <martin@ximian.com>
3239 * flowanalysis.cs (Reachability.Reachable): Compute this
3240 on-the-fly rather than storing it as a field.
3242 2004-05-23 Martin Baulig <martin@ximian.com>
3244 * flowanalysis.cs (Reachability.And): Manually compute the
3245 resulting `barrier' from the reachability.
3247 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3250 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
3251 instance of ObsoleteAttribute when symbol is obsolete.
3254 (IMethodData): Extended interface for ObsoleteAttribute support.
3256 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3258 * attribute.cs: Fix bug #55970
3260 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3264 (GetObsoleteAttribute): New method. Creates the instance of
3266 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
3267 ObsoleteAttribute when member is obsolete.
3268 (AttributeTester.Report_ObsoleteMessage): Common method for
3269 Obsolete error/warning reporting.
3272 (TypeContainer.base_classs_type): New member for storing parent type.
3275 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
3276 for this MemberCore.
3278 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3280 * attribute.cs, const.cs: Fix bug #58590
3282 2004-05-21 Martin Baulig <martin@ximian.com>
3284 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
3285 out parameters if the end of the method is unreachable. Fixes
3288 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3290 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
3291 Hari was right, why extra method.
3293 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3295 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
3297 2004-05-20 Martin Baulig <martin@ximian.com>
3299 Merged this back from gmcs to keep the differences to a minumum.
3301 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
3302 instead of a Declspace.
3303 (Attribute.ResolveType): Likewise.
3304 (Attributes.Search): Likewise.
3305 (Attributes.Contains): Likewise.
3306 (Attributes.GetClsCompliantAttribute): Likewise.
3308 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
3310 (MethodData.ApplyAttributes): Take an EmitContext instead of a
3313 2004-05-19 Marek Safar <marek.safar@seznam.cz>
3315 Fix bug #58688 (MCS does not report error when the same attribute
3318 * attribute.cs (Attribute.Emit): Distinction between null and default.
3320 2004-05-19 Raja R Harinath <rharinath@novell.com>
3322 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
3323 of a top-level attribute without an attribute target.
3324 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
3326 (Attribute.Conditional_GetConditionName),
3327 (Attribute.Obsolete_GetObsoleteMessage): Update.
3328 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
3329 part of ScanForIndexerName.
3330 (Attribute.CanIgnoreInvalidAttribute): New function.
3331 (Attribute.ScanForIndexerName): Move to ...
3332 (Attributes.ScanForIndexerName): ... here.
3333 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
3334 (Attributes.Search): New internal variant that can choose not to
3335 complain if types aren't resolved. The original signature now
3337 (Attributes.GetClsCompliantAttribute): Use internal variant, with
3338 complaints suppressed.
3339 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
3340 only if it not useful.
3341 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
3342 top-level for attributes that are shared between the assembly
3343 and a top-level class.
3344 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
3345 * class.cs: Update to reflect changes.
3346 (DefineIndexers): Fuse loops.
3347 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
3348 a couple more variants of attribute names.
3350 2004-05-18 Marek Safar <marek.safar@seznam.cz>
3352 Fix bug #52585 (Implemented explicit attribute declaration)
3355 (Attributable.ValidAttributeTargets): New abstract method. It gets
3356 list of valid attribute targets for explicit target declaration.
3357 (Attribute.Target): It holds target itself.
3358 (AttributeSection): Removed.
3359 (Attribute.CheckTargets): New method. It checks whether attribute
3360 target is valid for the current element.
3363 (EventProperty): New class. For events that are declared like
3364 property (with add and remove accessors).
3365 (EventField): New class. For events that are declared like field.
3368 * cs-parser.jay: Implemented explicit attribute target declaration.
3370 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
3371 Override ValidAttributeTargets.
3374 (ReturnParameter): Class for applying custom attributes on
3376 (ParameterAtribute): New class. Class for applying custom
3377 attributes on the parameter type.
3379 2004-05-17 Miguel de Icaza <miguel@ximian.com>
3381 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
3384 (Method): Allow UNSAFE here.
3386 * modifiers.cs: Support unsafe reporting.
3388 2004-05-17 Marek Safar <marek.safar@seznam.cz>
3390 * decl.cs: Fix bug #58478.
3392 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3394 * statement.cs: When checking for unreachable code on an EmptyStatement,
3395 set the location. Fixes bug #58488.
3397 2004-05-13 Miguel de Icaza <miguel@ximian.com>
3399 * driver.cs: Add -pkg handling.
3401 From Gonzalo: UseShelLExecute=false
3403 2004-05-12 Marek Safar <marek.safar@seznam.cz>
3406 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
3408 (Attribute.IsClsCompliaceRequired): Moved to base for better
3410 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
3411 when attribute is AttributeUsageAttribute.
3412 (Attribute.GetValidTargets): Simplified.
3413 (Attribute.GetAttributeUsage): New method returns AttributeUsage
3414 attribute for this type.
3415 (Attribute.ApplyAttributes): Method renamed to Emit and make
3417 (GlobalAttributeSection): New class for special handling of global
3418 attributes (assembly, module).
3419 (AttributeSection.Emit): New method.
3421 * class.cs: Implemented Attributable abstract methods.
3422 (MethodCore.LabelParameters): Moved to Parameter class.
3423 (Accessor): Is back simple class.
3424 (PropertyMethod): Implemented Attributable abstract class.
3425 (DelegateMethod): Implemented Attributable abstract class.
3426 (Event): New constructor for disctintion between normal Event
3427 and Event with accessors.
3429 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
3431 * codegen.cs, const.cs, decl.cs, delegate.cs:
3432 (CommonAssemblyModulClass): Implemented Attributable abstract class
3435 * enum.cs: Implement IAttributeSupport interface.
3436 (EnumMember): New class for emum members. Implemented Attributable
3440 (ParameterBase): Is abstract.
3441 (ReturnParameter): New class for easier [return:] attribute handling.
3443 * typemanager.cs: Removed builder_to_attr.
3445 2004-05-11 Raja R Harinath <rharinath@novell.com>
3448 * attribute.cs (Attribute.GetPositionalValue): New function.
3449 * class.cs (TypeContainer.VerifyMembers): New function.
3450 (TypeContainer.Emit): Use it.
3451 (ClassOrStruct): New base class for Class and Struct.
3452 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
3453 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
3455 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
3456 then each non-static field should have a FieldOffset attribute.
3457 Otherwise, none of the fields should have a FieldOffset attribute.
3458 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
3459 and FieldOffset attributes.
3460 * typemanager.cs (TypeManager.struct_layout_attribute_type)
3461 (TypeManager.field_offset_attribute_type): New core types.
3462 (TypeManager.InitCoreTypes): Initialize them.
3464 2004-05-11 Michal Moskal <malekith@pld-linux.org>
3466 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
3467 Return correct type.
3470 2004-05-09 Miguel de Icaza <miguel@ximian.com>
3472 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
3473 be implicitly converted to ulong.
3475 * expression.cs: The logic for allowing operator &, | and ^ worked
3476 was wrong, it worked before because we did not report an error in
3477 an else branch. Fixes 57895.
3479 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
3480 allow volatile fields to be reference types.
3482 2004-05-07 Miguel de Icaza <miguel@ximian.com>
3484 * driver.cs: Add support for /debug-
3486 2004-05-07 Raja R Harinath <rharinath@novell.com>
3488 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
3489 Add a 'complain' parameter to silence errors.
3490 (Attribute.Resolve): Update to changes. Put in sanity check to catch
3491 silently overlooked type-resolutions.
3492 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
3494 (Attributes.Search): New function.
3495 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
3496 (Attributes.GetAttributeFullName): Remove hack.
3497 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
3498 Update to reflect changes.
3499 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
3500 Use Attributes.Search instead of nested loops.
3502 2004-05-07 Marek Safar <marek.safar@seznam.cz>
3505 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
3506 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
3507 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
3509 * report.cs: (Report.Warning): Renamed to Warning_T because of
3510 parameter collision.
3512 2004-05-05 Raja R Harinath <rharinath@novell.com>
3514 * expression.cs (MemberAccess.ResolveMemberAccess):
3515 Exit with non-zero status after Report.Error.
3516 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
3518 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
3520 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3522 * support.cs: Don't hang when the file is empty.
3524 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3526 * support.cs: In SeekableStreamReader, compute the preamble size of the
3527 underlying stream. Position changes should take into account that initial
3530 2004-05-03 Todd Berman <tberman@sevenl.net>
3532 * driver.cs: remove unused GetSysVersion function.
3534 2004-05-03 Todd Berman <tberman@sevenl.net>
3536 * driver.cs: Remove the hack from saturday, as well as the hack
3537 from jackson (LoadAssemblyFromGac), also adds the CWD to the
3538 link_paths to get that bit proper.
3540 2004-05-01 Todd Berman <tberman@sevenl.net>
3542 * driver.cs: Try a LoadFrom before a Load, this checks the current
3543 path. This is currently a bug in mono that is be fixed, however, this
3544 provides a workaround for now. This will be removed when the bug
3547 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
3549 * CryptoConvert.cs: Updated to latest version. Fix issue with
3550 incomplete key pairs (#57941).
3552 2004-05-01 Todd Berman <tberman@sevenl.net>
3554 * driver.cs: Remove '.' from path_chars, now System.* loads properly
3557 2004-04-30 Jackson Harper <jackson@ximian.com>
3559 * codegen.cs: Open keys readonly.
3561 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3563 * typemanager.cs: don't report cyclic struct layout when a struct
3564 contains 2 or more fields of the same type. Failed for Pango.AttrShape
3565 which has 2 Pango.Rectangle fields.
3567 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
3569 * expression.cs: Handle IntPtr comparisons with IL code
3570 rather than a method call.
3572 2004-04-29 Martin Baulig <martin@ximian.com>
3574 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
3575 the list of PropertyInfo's in class hierarchy and find the
3576 accessor. Fixes #56013.
3578 2004-04-29 Martin Baulig <martin@ximian.com>
3580 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
3582 2004-04-29 Martin Baulig <martin@ximian.com>
3584 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3586 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
3588 2004-04-29 Martin Baulig <martin@ximian.com>
3590 * class.cs (ConstructorInitializer.Resolve): Check whether the
3591 parent .ctor is accessible. Fixes #52146.
3593 2004-04-29 Martin Baulig <martin@ximian.com>
3595 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3597 * statement.cs (Using.EmitLocalVariableDecls): Use
3598 TypeManager.idisposable_type, not typeof (IDisposable).
3599 (Foreach.EmitCollectionForeach): Added support for valuetypes.
3601 2004-04-29 Martin Baulig <martin@ximian.com>
3603 * class.cs (Event.Define): Don't emit the field and don't set
3604 RTSpecialName and SpecialName for events on interfaces. Fixes
3607 2004-04-29 Raja R Harinath <rharinath@novell.com>
3609 Refactor Attribute.ApplyAttributes.
3610 * attribute.cs (Attributable): New base class for objects that can
3611 have Attributes applied on them.
3612 (Attribute): Make AttributeUsage fields public.
3613 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
3614 (Attribute.IsInternalCall): New property.
3615 (Attribute.UsageAttr): Convert to a public read-only property.
3616 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3617 (Attribute.ResolveType, Attribute.Resolve)
3618 (Attribute.ScanForIndexerName): Update to reflect changes.
3619 (Attribute.CheckAttributeTarget): Re-format.
3620 (Attribute.ApplyAttributes): Refactor, to various
3621 Attributable.ApplyAttributeBuilder methods.
3622 * decl.cs (MemberCore): Make Attributable.
3623 * class.cs (Accessor): Make Attributable.
3624 (MethodData.ApplyAttributes): Use proper attribute types, not
3626 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
3627 (TypeContainer.ApplyAttributeBuilder)
3628 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
3629 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
3630 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
3631 (Operator.ApplyAttributeBuilder): New factored-out methods.
3632 * const.cs (Const.ApplyAttributeBuilder): Likewise.
3633 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
3634 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
3635 * parameter.cs (ParameterBase): New Attributable base class
3636 that can also represent Return types.
3637 (Parameter): Update to the changes.
3639 2004-04-29 Jackson Harper <jackson@ximian.com>
3641 * driver.cs: Prefer the corlib system version when looking for
3642 assemblies in the GAC. This is still a hack, but its a better hack
3645 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3647 * decl.cs, enum.cs: Improved error 3005 reporting.
3649 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3650 (related_symbols): New private member for list of symbols
3651 related to reported error/warning.
3653 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3655 2004-04-29 Martin Baulig <martin@ximian.com>
3657 * ecore.cs (Expression.Constantify): If we're an enum and
3658 TypeManager.TypeToCoreType() doesn't give us another type, use
3659 t.UnderlyingSystemType. Fixes #56178.
3661 2004-04-29 Martin Baulig <martin@ximian.com>
3663 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3664 interfaces and for each interface, only add members directly
3665 declared in that interface. Fixes #53255.
3667 2004-04-28 Martin Baulig <martin@ximian.com>
3669 * expression.cs (ConditionalLogicalOperator): Use a temporary
3670 variable for `left' to avoid that we evaluate it more than once;
3673 2004-04-28 Martin Baulig <martin@ximian.com>
3675 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
3678 2004-04-28 Martin Baulig <martin@ximian.com>
3680 * statement.cs (LocalInfo.Resolve): Check whether the type is not
3683 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
3684 whether the type is not void (CS1547).
3686 2004-04-28 Martin Baulig <martin@ximian.com>
3688 * expression.cs (Unary.DoResolveLValue): Override this and report
3689 CS0131 for anything but Operator.Indirection.
3691 2004-04-28 Martin Baulig <martin@ximian.com>
3693 Committing a patch from Ben Maurer; see bug #50820.
3695 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3698 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3701 2004-04-28 Martin Baulig <martin@ximian.com>
3703 Committing a patch from Ben Maurer; see bug #50820.
3705 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3708 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3711 2004-04-28 Martin Baulig <martin@ximian.com>
3713 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
3714 (Block.AddLabel): Call DoLookupLabel() to only search in the
3717 2004-04-28 Martin Baulig <martin@ximian.com>
3719 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3720 comparing StringConstants and NullLiterals in Equality and Inequality.
3722 2004-04-28 Jackson Harper <jackson@ximian.com>
3724 * driver.cs: Attempt to load referenced assemblies from the
3725 GAC. This is the quick and dirty version of this method that
3726 doesnt take into account versions and just takes the first
3727 canidate found. Will be good enough for now as we will not have more
3728 then one version installed into the GAC until I update this method.
3730 2004-04-28 Martin Baulig <martin@ximian.com>
3732 * typemanager.cs (TypeManager.CheckStructCycles): New public
3733 static method to check for cycles in the struct layout.
3735 * rootcontext.cs (RootContext.PopulateTypes): Call
3736 TypeManager.CheckStructCycles() for each TypeContainer.
3737 [Note: We only need to visit each type once.]
3739 2004-04-28 Martin Baulig <martin@ximian.com>
3741 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3743 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3744 success and added `out object value'. Use a `bool resolved' field
3745 to check whether we've already been called rather than
3746 `ConstantValue != null' since this breaks for NullLiterals.
3748 2004-04-28 Raja R Harinath <rharinath@novell.com>
3750 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3751 setting of this flag, since the 'set' method may be non-public.
3753 2004-04-28 Raja R Harinath <rharinath@novell.com>
3755 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3756 check on current_vector.Block.
3758 2004-04-27 Martin Baulig <martin@ximian.com>
3760 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3761 a field initializer. Fixes #56459.
3763 2004-04-27 Martin Baulig <martin@ximian.com>
3765 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3766 we're not attempting to use an indexer. Fixes #52154.
3768 2004-04-27 Martin Baulig <martin@ximian.com>
3770 * statement.cs (Return): Don't create a return label if we don't
3771 need it; reverts my change from January 20th. Thanks to Ben
3774 2004-04-27 Martin Baulig <martin@ximian.com>
3776 According to the spec, `goto' can only leave a nested scope, but
3779 * statement.cs (Block.LookupLabel): Only lookup in the current
3780 block, don't recurse into parent or child blocks.
3781 (Block.AddLabel): Check in parent and child blocks, report
3782 CS0140/CS0158 if we find a duplicate.
3783 (Block): Removed this indexer for label lookups.
3784 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3785 this already does the error reporting for us.
3788 (FlowBranching.UsageVector.Block): New public variable; may be null.
3789 (FlowBranching.CreateSibling): Added `Block' argument.
3790 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3791 label for the target of a `goto' and check whether we're not
3792 leaving a `finally'.
3794 2004-04-27 Martin Baulig <martin@ximian.com>
3796 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3797 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3800 2004-04-27 Martin Baulig <martin@ximian.com>
3802 * statement.cs (Block.AddLabel): Also check for implicit blocks
3803 and added a CS0158 check.
3805 2004-04-27 Martin Baulig <martin@ximian.com>
3807 * flowanalysis.cs (FlowBranchingLoop): New class.
3808 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3809 UsageVector's instead of an ArrayList.
3810 (FlowBranching.Label): Likewise.
3811 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3812 (FlowBranching.AddBreakVector): New method.
3814 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3816 * attribute.cs: Small regression fix: only convert the type if we
3817 the type is different, fixes System.Drawing build.
3819 2004-04-27 Martin Baulig <martin@ximian.com>
3821 * attribute.cs (Attribute.Resolve): If we have a constant value
3822 for a named field or property, implicity convert it to the correct
3825 2004-04-27 Raja R Harinath <rharinath@novell.com>
3827 * statement.cs (Block.Block): Implicit blocks share
3828 'child_variable_names' fields with parent blocks.
3829 (Block.AddChildVariableNames): Remove.
3830 (Block.AddVariable): Mark variable as "used by a child block" in
3831 every surrounding block.
3832 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
3833 been used in a child block, complain about violation of "Invariant
3834 meaning in blocks" rule.
3835 * cs-parser.jay (declare_local_variables): Don't use
3836 AddChildVariableNames.
3837 (foreach_statement): Don't create an implicit block: 'foreach'
3840 2004-04-23 Miguel de Icaza <miguel@ximian.com>
3842 * convert.cs (ImplicitNumericConversion): 0 is also positive when
3843 converting from 0L to ulong. Fixes 57522.
3845 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3847 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3848 derived class hides via 'new' keyword field from base class (test-242.cs).
3849 TODO: Handle this in the more general way.
3851 * class.cs (CheckBase): Ditto.
3853 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3855 * decl.cs (caching_flags): New member for storing cached values
3857 (MemberCore.Flags): New enum where bit flags for caching_flags
3859 (MemberCore.cls_compliance): Moved to caching_flags.
3860 (DeclSpace.Created): Moved to caching_flags.
3862 * class.cs: Use caching_flags instead of DeclSpace.Created
3864 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3866 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3867 if we are only a derived class, not a nested class.
3869 * typemanager.cs: Same as above, but do this at the MemberLookup
3870 level (used by field and methods, properties are handled in
3871 PropertyExpr). Allow for the qualified access if we are a nested
3874 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3876 * class.cs: Refactoring.
3877 (IMethodData): New inteface; Holds links to parent members
3878 to avoid member duplication (reduced memory allocation).
3879 (Method): Implemented IMethodData interface.
3880 (PropertyBase): New inner classes for get/set methods.
3881 (PropertyBase.PropertyMethod): Implemented IMethodData interface
3882 (Event): New inner classes for add/remove methods.
3883 (Event.DelegateMethod): Implemented IMethodData interface.
3885 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
3886 EmitContext (related to class.cs refactoring).
3888 2004-04-21 Raja R Harinath <rharinath@novell.com>
3890 * delegate.cs (Delegate.VerifyApplicability): If the number of
3891 arguments are the same as the number of parameters, first try to
3892 verify applicability ignoring any 'params' modifier on the last
3896 2004-04-16 Raja R Harinath <rharinath@novell.com>
3898 * class.cs (TypeContainer.AddIndexer): Use
3899 'ExplicitInterfaceName' to determine if interface name was
3900 explicitly specified. 'InterfaceType' is not initialized at this time.
3901 (TypeContainer.DefineIndexers): Remove use of temporary list. The
3902 Indexers array is already in the required order. Initialize
3903 'IndexerName' only if there are normal indexers.
3904 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
3905 (TypeContainer.Emit): Emit DefaultMember attribute only if
3906 IndexerName is initialized.
3909 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
3911 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
3914 2004-04-15 Raja R Harinath <rharinath@novell.com>
3916 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
3920 * attribute.cs (Attribute.Resolve): Check for duplicate named
3924 2004-04-15 Miguel de Icaza <miguel@ximian.com>
3926 * iterators.cs (MarkYield): track whether we are in an exception,
3927 and generate code accordingly. Use a temporary value to store the
3928 result for our state.
3930 I had ignored a bit the interaction of try/catch with iterators
3931 since their behavior was not entirely obvious, but now it is
3932 possible to verify that our behavior is the same as MS .NET 2.0
3936 2004-04-14 Miguel de Icaza <miguel@ximian.com>
3938 * iterators.cs: Avoid creating temporaries if there is no work to
3941 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
3942 Enumerations, use TypeManager.EnumToUnderlying and call
3945 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
3948 (This.Emit): Use EmitContext.EmitThis to emit our
3951 (This.EmitAssign): Ditto.
3953 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
3954 codepaths, we will move all the functionality into
3957 (FieldExpr.EmitAssign): Ditto.
3959 This fixes several hidden bugs that I uncovered while doing a code
3960 review of this today.
3962 * codegen.cs (EmitThis): reworked so the semantics are more clear
3963 and also support value types "this" instances.
3965 * iterators.cs: Changed so that for iterators in value types, we
3966 do not pass the value type as a parameter.
3968 Initialization of the enumerator helpers is now done in the caller
3969 instead of passing the parameters to the constructors and having
3970 the constructor set the fields.
3972 The fields have now `assembly' visibility instead of private.
3974 2004-04-11 Miguel de Icaza <miguel@ximian.com>
3976 * expression.cs (Argument.Resolve): Check if fields passed as ref
3977 or out are contained in a MarshalByRefObject.
3979 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
3980 another compiler type.
3982 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
3984 * class.cs (Indexer.Define): use the new name checking method.
3985 Also, return false on an error.
3986 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
3987 (is_identifier_[start/part]_character): make static.
3989 2004-04-10 Miguel de Icaza <miguel@ximian.com>
3991 * expression.cs (Binary.ResolveOperator): Do no append strings
3992 twice: since we can be invoked more than once (array evaluation)
3993 on the same concatenation, take care of this here. Based on a fix
3994 from Ben (bug #56454)
3996 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3998 * codegen.cs: Fix another case where CS1548 must be reported (when
3999 delay-sign isn't specified and no private is available #56564). Fix
4000 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
4001 error when MCS is used on the MS runtime and we need to delay-sign
4002 (which seems unsupported by AssemblyBuilder - see #56621).
4004 2004-04-08 Marek Safar <marek.safar@seznam.cz>
4006 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
4007 (TypeManager.ComputeNamespaces): Faster implementation for
4010 * compiler.csproj: Updated AssemblyName to mcs.
4012 2004-04-07 Miguel de Icaza <miguel@ximian.com>
4014 * rootcontext.cs: Add new types to the boot resolution.
4016 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
4017 MulticastDelegate is not allowed.
4019 * typemanager.cs: Add new types to lookup: System.TypedReference
4022 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
4023 check for TypedReference or ArgIterator, they are not allowed.
4025 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
4026 makes us properly catch 1510 in some conditions (see bug 56016 for
4029 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
4031 * CryptoConvert.cs: update from corlib version
4034 2004-04-05 Miguel de Icaza <miguel@ximian.com>
4036 * class.cs (Indexer.Define): Check indexername declaration
4038 2004-04-05 Marek Safar <marek.safar@seznam.cz>
4040 * attribute.cs (IsClsCompliant): Fixed problem with handling
4041 all three states (compliant, not-compliant, undetected).
4043 2004-03-30 Marek Safar <marek.safar@seznam.cz>
4045 * attribute.cs (Attribute): Location is now public.
4046 (Resolve): Store resolved arguments (pos_values) in attribute class.
4047 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
4048 (GetClsCompliantAttributeValue): New method that gets
4049 CLSCompliantAttribute value.
4050 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
4051 if exists else null.
4052 (AttributeTester): New class for CLS-Compliant verification routines.
4054 * class.cs (Emit): Add CLS-Compliant verification.
4055 (Method.GetSignatureForError): Implemented.
4056 (Constructor.GetSignatureForError): Implemented
4057 (Constructor.HasCompliantArgs): Returns if constructor has
4058 CLS-Compliant arguments.
4059 (Constructor.Emit): Override.
4060 (Construcor.IsIdentifierClsCompliant): New method; For constructors
4061 is needed to test only parameters.
4062 (FieldBase.GetSignatureForError): Implemented.
4063 (TypeContainer): New member for storing base interfaces.
4064 (TypeContainer.FindMembers): Search in base interfaces too.
4066 * codegen.cs (GetClsComplianceAttribute): New method that gets
4067 assembly or module CLSCompliantAttribute value.
4068 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
4070 (ModuleClass.Emit): Add error 3012 test.
4072 * const.cs (Emit): Override and call base for CLS-Compliant tests.
4074 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
4075 state for all decl types.
4076 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
4077 if CLS-Compliant tests are required.
4078 (IsClsCompliaceRequired): New method. Analyze whether code
4079 must be CLS-Compliant.
4080 (IsExposedFromAssembly): New method. Returns true when MemberCore
4081 is exposed from assembly.
4082 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
4083 value or gets cached value.
4084 (HasClsCompliantAttribute): New method. Returns true if MemberCore
4085 is explicitly marked with CLSCompliantAttribute.
4086 (IsIdentifierClsCompliant): New abstract method. This method is
4087 used to testing error 3005.
4088 (IsIdentifierAndParamClsCompliant): New method. Common helper method
4089 for identifier and parameters CLS-Compliant testing.
4090 (VerifyClsCompliance): New method. The main virtual method for
4091 CLS-Compliant verifications.
4092 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
4093 null. I don't know why is null (too many public members !).
4094 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
4095 and get value of first CLSCompliantAttribute that found.
4097 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
4098 (VerifyClsCompliance): Override and add extra tests.
4100 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
4101 clscheck- disable CLS-Compliant verification event if assembly is has
4102 CLSCompliantAttribute(true).
4104 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
4105 ApllyAttribute is now called in emit section as in the other cases.
4106 Possible future Emit integration.
4107 (IsIdentifierClsCompliant): New override.
4108 (VerifyClsCompliance): New override.
4109 (GetEnumeratorName): Returns full enum name.
4111 * parameter.cs (GetSignatureForError): Implemented.
4113 * report.cs (WarningData): New struct for Warning message information.
4114 (LocationOfPreviousError): New method.
4115 (Warning): New method. Reports warning based on the warning table.
4116 (Error_T): New method. Reports error based on the error table.
4118 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
4119 verifications are done here.
4121 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
4123 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
4124 CLSCompliantAttribute.
4125 (all_imported_types): New member holds all imported types from other
4127 (LoadAllImportedTypes): New method fills static table with exported types
4128 from all referenced assemblies.
4129 (Modules): New property returns all assembly modules.
4131 2004-03-30 Miguel de Icaza <miguel@ximian.com>
4133 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
4134 throwing a parser error.
4136 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
4137 which removes the hardcoded get_/set_ prefixes for properties, as
4138 IL allows for the properties to be named something else.
4142 * expression.cs: Do not override operand before we know if it is
4145 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4147 * typemanager.cs: support for pinned variables.
4149 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4151 * decl.cs, typemanager.cs: Avoid using an arraylist
4152 as a buffer if there is only one result set.
4154 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4156 * expression.cs: Make sure you cant call a static method
4157 with an instance expression, bug #56174.
4159 2004-03-29 Miguel de Icaza <miguel@ximian.com>
4161 * class.cs (IsDuplicateImplementation): Improve error reporting to
4162 flag 663 (method only differs in parameter modifier).
4164 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
4165 in preprocessor directives.
4167 * location.cs (LookupFile): Allow for the empty path.
4169 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
4170 better approach for some of that patch, but its failing with the
4171 CharSet enumeration. For now try/catch will do.
4173 * typemanager.cs: Do not crash if a struct does not have fields.
4176 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4178 * expression.cs: cs0213, cant fix a fixed expression.
4181 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4183 * cs-parser.jay: detect invalid embeded statements gracefully.
4186 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4188 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
4191 the invocation type may not be a subclass of the tye of the item/
4192 The type of the item must be a subclass of the invocation item.
4197 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
4199 * attribute.cs: Added methods to get a string and a bool from an
4200 attribute. Required to information from AssemblyKeyFileAttribute,
4201 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
4202 * codegen.cs: Modified AssemblyName creation to include support for
4203 strongnames. Catch additional exceptions to report them as CS1548.
4204 * compiler.csproj: Updated include CryptoConvert.cs.
4205 * compiler.csproj.user: Removed file - user specific configuration.
4206 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
4207 Mono.Security assembly. The original class is maintained and tested in
4208 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
4209 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
4210 like CSC 8.0 (C# v2) supports.
4211 * Makefile: Added CryptoConvert.cs to mcs sources.
4212 * rootcontext.cs: Added new options for strongnames.
4214 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
4216 * driver.cs: For --expect-error, report error code `2'
4217 if the program compiled with no errors, error code `1' if
4218 it compiled with an error other than the one expected.
4220 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
4222 * compiler.csproj: Updated for Visual Studio .NET 2003.
4223 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
4224 * compiler.sln: Updated for Visual Studio .NET 2003.
4226 2004-03-24 Ravi Pratap M <ravi@ximian.com>
4228 * expression.cs: Fix bug #47234. We basically need to apply the
4229 rule that we prefer the conversion of null to a reference type
4230 when faced with a conversion to 'object' (csc behaviour).
4232 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4234 * statement.cs: Shorter form for foreach, eliminates
4235 a local variable. r=Martin.
4237 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4239 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
4240 checks if we can use brtrue/brfalse to test for 0.
4241 * expression.cs: use the above in the test for using brtrue/brfalse.
4244 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4246 * expression.cs: Rewrite string concat stuff. Benefits:
4248 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
4249 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
4250 rather than a concat chain.
4252 * typemanager.cs: Add lookups for more concat overloads.
4254 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4256 * expression.cs: Emit shorter il code for array init.
4273 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
4275 * statement.cs: Before, two switch blocks would be merged if the
4276 total size of the blocks (end_item - begin_item + 1) was less than
4277 two times the combined sizes of the blocks.
4279 Now, it will only merge if after the merge at least half of the
4284 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
4286 * class.cs : csc build fix for GetMethods(). See bug #52503.
4288 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
4290 * expression.cs: Make sure fp comparisons work with NaN.
4291 This fixes bug #54303. Mig approved this patch a long
4292 time ago, but we were not able to test b/c the runtime
4295 2004-03-19 Miguel de Icaza <miguel@ximian.com>
4297 * ecore.cs (TypExpr.GetHashCode): implement this overload.
4299 2004-03-19 Martin Baulig <martin@ximian.com>
4301 * class.cs (MemberCore.IsDuplicateImplementation): Report the
4302 error here and not in our caller.
4304 2004-03-19 Martin Baulig <martin@ximian.com>
4306 * interface.cs: Completely killed this file.
4307 (Interface): We're now a TypeContainer and live in class.cs.
4309 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
4310 argument; we're now also called for interfaces.
4311 (TypeContainer.DefineMembers): Allow this method being called
4313 (TypeContainer.GetMethods): New public method; formerly known as
4314 Interface.GetMethod(). This is used by PendingImplementation.
4315 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
4316 it's now private and non-static.
4317 (Interface): Moved this here; it's now implemented similar to
4319 (Method, Property, Event, Indexer): Added `bool is_interface'
4320 argument to their .ctor's.
4321 (MemberBase.IsInterface): New public field.
4323 * cs-parser.jay: Create normal Method, Property, Event, Indexer
4324 instances instead of InterfaceMethod, InterfaceProperty, etc.
4325 (opt_interface_base): Removed; we now use `opt_class_base' instead.
4326 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
4328 2004-03-19 Martin Baulig <martin@ximian.com>
4330 * class.cs (MethodCore.IsDuplicateImplementation): New private
4331 method which does the CS0111 checking.
4332 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
4333 Use IsDuplicateImplementation().
4335 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
4337 * decl.cs (FindMemberToOverride): New method to find the correct
4338 method or property to override in the base class.
4340 - Make Method/Property use the above method to find the
4341 version in the base class.
4342 - Remove the InheritableMemberSignatureCompare as it is now
4345 This patch makes large code bases much faster to compile, as it is
4346 O(n) rather than O(n^2) to do this validation.
4348 Also, it fixes bug 52458 which is that nested classes are not
4349 taken into account when finding the base class member.
4351 Reviewed/Approved by Martin.
4353 2004-03-17 Marek Safar <marek.safar@seznam.cz>
4355 * interface.cs: In all interface classes removed redundant
4356 member initialization.
4358 2004-03-16 Martin Baulig <martin@ximian.com>
4360 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4362 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4364 * decl.cs (DefineTypeAndParents): New helper method to define a
4365 type's containers before the type itself is defined; This is a
4366 bug exposed by the recent changes to Windows.Forms when an
4367 implemented interface was defined inside a class that had not been
4370 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
4372 (Check): Loop correctly to report errors modifiers
4373 (UNSAFE was not in the loop, since it was the same as TOP).
4375 * interface.cs: Every interface member now takes a ModFlags,
4376 instead of a "is_new" bool, which we set on the base MemberCore.
4378 Every place where we called "UnsafeOk" in the interface, now we
4379 call the proper member (InterfaceMethod.UnsafeOK) instead to get
4380 the unsafe settings from the member declaration instead of the
4381 container interface.
4383 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4385 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4386 `set_indexer_name' to the pending bits (one per type).
4388 We fixed a bug today that was picking the wrong method to
4389 override, since for properties the existing InterfaceMethod code
4390 basically ignored the method name. Now we make sure that the
4391 method name is one of the valid indexer names.
4393 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4395 * support.cs (SeekableStreamReader): Keep track of stream byte
4396 positions and don't mix them with character offsets to the buffer.
4398 Patch from Gustavo Giráldez
4400 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4402 * interface.cs (InterfaceSetGetBase): Removed double member
4403 initialization, base class does it as well.
4405 2004-03-13 Martin Baulig <martin@ximian.com>
4407 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4408 when compiling corlib.
4410 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4412 * convert.cs (ExplicitConversion): We were reporting an error on
4413 certain conversions (object_type source to a value type, when the
4414 expression was `null') before we had a chance to pass it through
4415 the user defined conversions.
4417 * driver.cs: Replace / and \ in resource specifications to dots.
4420 * class.cs: Add check for duplicate operators. Fixes 52477
4422 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4424 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4425 that are in the middle of the statements, not only at the end.
4428 * class.cs (TypeContainer.AddField): No longer set the
4429 `HaveStaticConstructor' flag, now we call it
4430 `UserDefineStaticConstructor' to diferentiate the slightly
4431 semantic difference.
4433 The situation is that we were not adding BeforeFieldInit (from
4434 Modifiers.TypeAttr) to classes that could have it.
4435 BeforeFieldInit should be set to classes that have no static
4440 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4442 And most importantly Zoltan's comment:
4444 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4446 "I think beforefieldinit means 'it's ok to initialize the type sometime
4447 before its static fields are used', i.e. initialization does not need
4448 to be triggered by the first access to the type. Setting this flag
4449 helps the JIT to compile better code, since it can run the static
4450 constructor at JIT time, and does not need to generate code to call it
4451 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4452 this flag for lots of classes like String.
4454 csc sets this flag if the type does not have an explicit static
4455 constructor. The reasoning seems to be that if there are only static
4456 initalizers for a type, and no static constructor, then the programmer
4457 does not care when this initialization happens, so beforefieldinit
4460 This bug prevents the AOT compiler from being usable, since it
4461 generates so many calls to mono_runtime_class_init that the AOT code
4462 is much slower than the JITted code. The JITted code is faster,
4463 because it does not generate these calls if the vtable is type is
4464 already initialized, which is true in the majority of cases. But the
4465 AOT compiler can't do this."
4467 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4469 * class.cs (MethodData.Emit): Refactor the code so symbolic
4470 information is generated for destructors; For some reasons we
4471 were taking a code path that did not generate symbolic information
4474 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4476 * class.cs: Create a Constructor.CheckBase method that
4477 takes care of all validation type code. The method
4478 contains some code that was moved from Define.
4480 It also includes new code that checks for duplicate ctors.
4481 This fixes bug #55148.
4483 2004-03-09 Joshua Tauberer <tauberer@for.net>
4485 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4486 a { ... }-style array creation invokes EmitStaticInitializers
4487 which is not good for reference-type arrays. String, decimal
4488 and now null constants (NullCast) are not counted toward
4489 static initializers.
4491 2004-03-05 Martin Baulig <martin@ximian.com>
4493 * location.cs (SourceFile.HasLineDirective): New public field;
4494 specifies whether the file contains or is referenced by a "#line"
4496 (Location.DefineSymbolDocuments): Ignore source files which
4497 either contain or are referenced by a "#line" directive.
4499 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4501 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4502 direct access to our parent, so check the method inline there.
4504 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4506 * expression.cs (Invocation.EmitCall): Miguel's last commit
4507 caused a regression. If you had:
4512 In Foo the implict this would be null.
4514 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4516 * expression.cs (Invocation.EmitCall): If the method is not
4517 virtual, do not emit a CallVirt to it, use Call.
4519 * typemanager.cs (GetFullNameSignature): Improve the method to
4520 cope with ".ctor" and replace it with the type name.
4522 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4523 as an argument the ConstructorBuilder where it is being defined,
4524 to catch the recursive constructor invocations.
4526 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4528 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4529 routines to check if a type is an enumerable/enumerator allow
4530 classes that implement the IEnumerable or IEnumerator interfaces.
4532 * class.cs (Property, Operator): Implement IIteratorContainer, and
4533 implement SetYields.
4535 (Property.Define): Do the block swapping for get_methods in the
4536 context of iterators. We need to check if Properties also
4537 include indexers or not.
4539 (Operator): Assign the Block before invoking the
4540 OperatorMethod.Define, so we can trigger the Iterator code
4543 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4544 Property and Operator classes are not created when we parse the
4545 declarator but until we have the block completed, so we use a
4546 singleton SimpleIteratorContainer.Simple to flag whether the
4547 SetYields has been invoked.
4549 We propagate this setting then to the Property or the Operator to
4550 allow the `yield' to function.
4552 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4554 * codegen.cs: Implemented attribute support for modules.
4555 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4556 Assembly/Module functionality.
4558 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4559 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4560 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4562 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4564 * interface.cs (FindMembers): The operation is performed on all base
4565 interfaces and not only on the first. It is required for future CLS Compliance patch.
4567 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4569 * statement.cs, codegen.cs:
4570 This patch deals with patterns such as:
4572 public class List : IEnumerable {
4574 public MyEnumerator GetEnumerator () {
4575 return new MyEnumerator(this);
4578 IEnumerator IEnumerable.GetEnumerator () {
4582 public struct MyEnumerator : IEnumerator {
4587 Before, there were a few things we did wrong:
4588 1) we would emit callvirt on a struct, which is illegal
4589 2) we emited ldarg when we needed to emit ldarga
4590 3) we would mistakenly call the interface methods on an enumerator
4591 type that derived from IEnumerator and was in another assembly. For example:
4593 public class MyEnumerator : IEnumerator
4595 Would have the interface methods called, even if there were public impls of the
4596 method. In a struct, this lead to invalid IL code.
4598 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4600 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4603 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4605 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4607 * cs-parser.jay: Fix small regression: we were not testing V2
4608 compiler features correctly.
4610 * interface.cs: If the emit context is null, then create one
4612 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4614 * decl.cs (GetSignatureForError): New virtual method to get full name
4617 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4618 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4620 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4621 Duplicated members and code in these classes has been removed.
4622 Better encapsulation in these classes.
4624 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4626 * assign.cs (Assign.DoResolve): When dealing with compound
4627 assignments, there is a new rule in ECMA C# 2.4 (might have been
4628 there before, but it is documented here) that states that in:
4632 If b is of type int, and the `op' is a shift-operator, then the
4633 above is evaluated as:
4637 * expression.cs (Binary.ResolveOperator): Instead of testing for
4638 int/uint/long/ulong, try to implicitly convert to any of those
4639 types and use that in pointer arithmetic.
4641 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4642 method to print information for from the type, not from the
4643 null-method we were given.
4645 2004-02-01 Duncan Mak <duncan@ximian.com>
4647 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4648 parsing for cmd, fixes bug #53694.
4650 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4652 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4653 in the member name duplication tests. Property and operator name duplication
4654 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4656 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4658 * interface.cs (PopulateMethod): Fixed crash when interface method
4659 returns not existing type (error test cs0246-3.cs).
4661 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4663 * cs-parser.jay (interface_accessors): Re-write actions to also
4664 store attributes attached to get and set methods. Fix spelling
4667 (inteface_property_declaration): Modify accordingly.
4669 (InterfaceAccessorInfo): New helper class to store information to pass
4670 around between rules that use interface_accessors.
4672 * interface.cs (Emit): Apply attributes on the get and set
4673 accessors of properties and indexers too.
4675 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4676 right MethodBuilder when applying attributes to the get and set accessors.
4678 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4680 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4682 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4684 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4686 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4688 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4689 changes that treat `yield' specially when present before `break'
4692 * cs-tokenizer.cs: yield is no longer a keyword.
4694 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4696 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4697 setting for default constructors.
4698 For default constructors are almost every time set wrong Modifier. The
4699 generated IL code has been alright. But inside mcs this values was
4700 wrong and this was reason why several of my CLS Compliance tests
4703 2004-01-22 Martin Baulig <martin@ximian.com>
4705 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4706 not a QualifiedIdentifier. This is what `type_name_expression'
4707 was previously doing.
4708 (type_name_expression): Removed; the code is now in
4709 `namespace_or_type_name'.
4710 (qualified_identifier): Removed, use `namespace_or_type_name'
4712 (QualifiedIdentifier): Removed this class.
4714 2004-01-22 Martin Baulig <martin@ximian.com>
4716 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4717 not a string as alias name.
4719 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4721 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4722 #52730 bug, and instead compute correctly the need to use a
4723 temporary variable when requesting an address based on the
4724 static/instace modified of the field and the constructor.
4726 2004-01-21 Martin Baulig <martin@ximian.com>
4728 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4729 class and namespace before looking up aliases. Fixes #52517.
4731 2004-01-21 Martin Baulig <martin@ximian.com>
4733 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4734 assinged in a 'try'; fixes exception4.cs.
4736 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4737 * class.cs : Implemented parameter-less constructor for TypeContainer
4739 * decl.cs: Attributes are now stored here. New property OptAttributes
4741 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4743 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4745 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4747 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4748 (CSharpSignature): New method for indexer and property signature.
4750 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4752 * pending.cs (IsVirtualFilter): Faster implementation.
4754 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4756 * typemanager.cs: Avoid inclusion of same assembly more than once.
4758 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4760 * cs-parser.jay: Fixed problem where the last assembly attribute
4761 has been applied also to following declaration (class, struct, etc.)
4763 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4765 * class.cs: Added error CS0538, CS0539 reporting.
4766 Fixed crash on Microsoft runtime when field type is void.
4768 * cs-parser.jay: Added error CS0537 reporting.
4770 * pending.cs: Added error CS0535 reporting.
4771 Improved error report for errors CS0536, CS0534.
4773 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4775 Merge a few bits from the Anonymous Method MCS tree.
4777 * statement.cs (ToplevelBlock): New class for toplevel methods,
4778 will hold anonymous methods, lifted variables.
4780 * cs-parser.jay: Create toplevel blocks for delegates and for
4781 regular blocks of code.
4783 2004-01-20 Martin Baulig <martin@ximian.com>
4785 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4786 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4787 and `NeedExplicitReturn'; added `IsLastStatement'.
4788 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4789 have a `ReturnLabel' or we're not unreachable.
4791 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4792 child's reachability; don't just override ours with it. Fixes
4793 #58058 (lluis's example).
4794 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4795 InFinally(), InLoop(), InSwitch() and
4796 BreakCrossesTryCatchBoundary() methods.
4798 * statement.cs (Return): Do all error checking in Resolve().
4799 Unless we are the last statement in a top-level block, always
4800 create a return label and jump to it.
4801 (Break, Continue): Do all error checking in Resolve(); also make
4802 sure we aren't leaving a `finally'.
4803 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4804 statement in a top-level block.
4805 (Block.Flags): Added `IsDestructor'.
4806 (Block.IsDestructor): New public property.
4808 2004-01-20 Martin Baulig <martin@ximian.com>
4810 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4812 2004-01-20 Martin Baulig <martin@ximian.com>
4814 * statement.cs (Statement.ResolveUnreachable): New public method.
4815 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4816 (Block.Resolve): Resolve unreachable statements.
4818 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4820 * expression.cs: We need to fix the case where we do
4821 not have a temp variable here.
4823 * assign.cs: Only expression compound assignments need
4824 temporary variables.
4826 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4828 * flowanalysis.cs: Reduce memory allocation in a few ways:
4829 - A block with no variables should not allocate a bit
4831 - A method with no out parameters does not need any tracking
4832 for assignment of the parameters, so we need not allocate
4835 public readonly Type[] VariableTypes;
4836 public readonly string[] VariableNames;
4837 Are redundant. The data is already stored in the variable
4838 map, so we need not allocate another array for it.
4839 - We need to add alot of checks for if (params | locals) == null
4840 due to the first two changes.
4842 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4844 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4845 implement IMemoryLocation, we store a copy on a local variable and
4846 take the address of it. Patch from Benjamin Jemlich
4848 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4849 to use a special "type_name_expression" rule which reduces the
4850 number of "QualifiedIdentifier" classes created, and instead
4851 directly creates MemberAccess expressions.
4853 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4855 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4856 that fixes #52853. Null literal assignment to ValueType
4858 * class.cs (MethodData.Emit): Instead of checking the name of the
4859 method to determine if its a destructor, create a new derived
4860 class from Method called Destructor, and test for that.
4862 * cs-parser.jay: Create a Destructor object instead of a Method.
4864 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4868 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4870 * expression.cs (Binary.ResolveOperator): Perform an implicit
4871 conversion from MethodGroups to their delegate types on the
4874 * delegate.cs: Introduce a new class DelegateCreation that is the
4875 base class for `NewDelegate' and `ImplicitDelegateCreation',
4876 factor some code in here.
4878 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4879 conversion from MethodGroups to compatible delegate types.
4881 * ecore.cs (Expression.Resolve): Do not flag error 654
4882 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4883 we allow conversions from MethodGroups to delegate types now.
4885 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4886 assignments in v2 either.
4888 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4890 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4891 static read-only fields in ctors.
4893 Applied patch from Benjamin Jemlich
4895 * expression.cs (UnaryMutator): Avoid leaking local variables.
4897 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4899 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4900 here to return true, as they can be used like this:
4904 Fixed 49836 and all the other dups
4906 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
4908 * driver.cs: Implement /win32res and /win32icon.
4910 2004-01-08 Miguel de Icaza <miguel@ximian.com>
4912 * cs-parser.jay: Add a rule to improve error handling for the
4913 common mistake of placing modifiers after the type.
4915 2004-01-07 Miguel de Icaza <miguel@ximian.com>
4917 * cs-parser.jay (interface_event_declaration): Catch
4918 initialization of events on interfaces, and report cs0068
4920 * cs-parser.jay (interface_event_declaration): Catch
4921 initialization of events.
4923 * ecore.cs: Better report missing constructors.
4925 * expression.cs (Binary.ResolveOperator): My previous bug fix had
4926 the error reporting done in the wrong place. Fix.
4928 * expression.cs (Binary.ResolveOperator): Catch the
4929 operator + (E x, E y) error earlier, and later allow for implicit
4930 conversions in operator +/- (E e, U x) from U to the underlying
4933 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
4934 52596, if the container class is abstract, the default constructor
4935 is protected otherwise its public (before, we were always public).
4937 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
4940 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
4941 Jemlich that fixes bug #52597, MCS was generating invalid code for
4942 idisposable structs. Thanks to Ben for following up with this
4945 2004-01-06 Miguel de Icaza <miguel@ximian.com>
4947 * driver.cs: Allow assemblies without code to be generated, fixes
4950 2004-01-07 Nick Drochak <ndrochak@gol.com>
4952 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
4954 2004-01-05 Miguel de Icaza <miguel@ximian.com>
4956 * cs-parser.jay: Add rules to improve error reporting if fields or
4957 methods are declared at the namespace level (error 116)
4959 * Add rules to catch event add/remove
4961 2004-01-04 David Sheldon <dave-mono@earth.li>
4963 * expression.cs: Added matching ")" to error message for
4966 2004-01-03 Todd Berman <tberman@gentoo.org>
4968 * ecore.cs, attribute.cs:
4969 Applying fix from #52429.
4971 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4973 * ecore.cs, expression.cs, statement.cs:
4974 Total rewrite of how we handle branching. We
4975 now handle complex boolean expressions with fewer
4976 jumps. As well if (x == 0) no longer emits a ceq.
4978 if (x is Foo) is much faster now, because we generate
4981 Overall, we get a pretty big improvement on our benchmark
4982 tests. The code we generate is smaller and more readable.
4984 I did a full two-stage bootstrap. The patch was reviewed
4985 by Martin and Miguel.
4987 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4989 * cs-parser.jay: Make primary_expression not take a QI.
4990 we dont need this because the member_access rule covers
4991 us here. So we replace the rule with just IDENTIFIER.
4993 This has two good effects. First, we remove a s/r conflict.
4994 Second, we allocate many fewer QualifiedIdentifier objects.
4996 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4998 * attribute.cs: Handle MarshalAs attributes as pseudo, and
4999 set the correct information via SRE. This prevents
5000 hanging on the MS runtime. Fixes #29374.
5002 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5004 * convert.cs: correctly handle conversions to value types
5005 from Enum and ValueType as unboxing conversions.
5007 Fixes bug #52569. Patch by Benjamin Jemlich.
5009 2004-01-02 Ravi Pratap <ravi@ximian.com>
5011 * expression.cs (BetterConversion): Prefer int -> uint
5012 over int -> ulong (csc's behaviour). This fixed bug #52046.
5014 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
5016 * decl.cs (MemberCache.FindMembers): now returns a
5019 * typemanager.cs: In general, go with with ^^.
5020 (CopyNewMethods): take an IList.
5021 (RealMemberLookup): Only allocate an arraylist
5022 if we copy from two sets of methods.
5024 This change basically does two things:
5025 1) Fewer array lists allocated due to CopyNewMethods.
5026 2) the explicit cast in MemberList costed ALOT.
5028 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
5030 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
5031 a hashtable to avoid needless string allocations when an identifier is
5032 used more than once (the common case).
5034 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5036 * pending.cs: MS's TypeBuilder.GetInterfaces ()
5037 is broken, it will not return anything. So, we
5038 have to use the information we have in mcs to
5041 * typemanager.cs: Add a cache for GetInterfaces,
5042 since this will now be used more often (due to ^^)
5044 (GetExplicitInterfaces) New method that gets the
5045 declared, not effective, interfaces on a type
5046 builder (eg, if you have interface IFoo, interface
5047 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
5050 This patch makes MCS able to bootstrap itself on
5053 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5055 * expression.cs: Remove the Nop's that Miguel put
5058 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5060 * report.cs, codegen.cs: Give the real stack trace to
5061 the error when an exception is thrown.
5063 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5065 * decl.cs: only allocate hashtables for ifaces if
5068 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5070 * expression.cs: fix the error from cs0121-2.cs
5071 (a parent interface has two child interfaces that
5072 have a function with the same name and 0 params
5073 and the function is called through the parent).
5075 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
5077 * class.cs, rootcontext.cs, typmanager.cs: do not
5080 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
5082 * codegen.cs: remove stack for the ec flow branching.
5083 It is already a linked list, so no need.
5085 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
5087 * Makefile: Allow custom profiler here.
5089 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5091 * typemanager.cs (LookupType):
5092 - Use a static char [], because split takes
5093 a param array for args, so it was allocating
5095 - Do not store true in a hashtable, it boxes.
5097 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5099 * flowanalysis.cs: bytify common enums.
5101 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5103 * modifiers.cs: Add a new set of flags for the
5104 flags allowed on explicit interface impls.
5105 * cs-parser.jay: catch the use of modifiers in
5106 interfaces correctly.
5107 * class.cs: catch private void IFoo.Blah ().
5109 All related to bug #50572.
5111 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5113 * decl.cs: Rewrite the consistant accessability checking.
5114 Accessability is not linear, it must be implemented in
5115 a tableish way. Fixes #49704.
5117 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5119 * expression.cs: Handle negation in a checked context.
5120 We must use subtraction from zero. Fixes #38674.
5122 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5124 * class.cs: Ignore static void main in DLLs.
5125 * rootcontext.cs: Handle the target type here,
5126 since we are have to access it from class.cs
5127 * driver.cs: account for the above.
5129 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5131 * report.cs: Give line numbers and files if available.
5133 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
5135 * driver.cs: Implement /addmodule.
5137 * typemanager.cs: Change 'modules' field so it now contains Modules not
5140 2003-12-20 Martin Baulig <martin@ximian.com>
5142 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
5143 (FieldBase.IsAssigned): Removed this field.
5144 (FieldBase.SetAssigned): New public method.
5145 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
5147 2003-12-20 Martin Baulig <martin@ximian.com>
5149 * expression.cs (LocalVariableReference.DoResolve): Don't set
5150 `vi.Used' if we're called from DoResolveLValue().
5152 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
5153 returns the usage vector it just merged into the current one -
5154 pass this one to UsageWarning().
5155 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
5156 of the `EmitContext', don't call this recursively on our children.
5158 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
5160 * driver.cs: Implement /target:module.
5162 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
5164 * support.cs (CharArrayHashtable): New helper class.
5166 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
5167 char arrays, not strings, so we can avoid creating a string in
5168 consume_identifier if the identifier is a keyword.
5170 2003-12-16 Martin Baulig <martin@ximian.com>
5172 * statement.cs (LocalInfo.Assigned): Removed this property.
5173 (LocalInfo.Flags): Removed `Assigned'.
5174 (LocalInfo.IsAssigned): New public method; takes the EmitContext
5175 and uses flow analysis.
5176 (Block.UsageWarning): Made this method private.
5177 (Block.Resolve): Call UsageWarning() if appropriate.
5179 * expression.cs (LocalVariableReference.DoResolve): Always set
5180 LocalInfo.Used here.
5182 2003-12-13 Martin Baulig <martin@ximian.com>
5184 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
5185 any value here; we're now using flow analysis to figure out
5186 whether a statement/block returns a value.
5188 2003-12-13 Martin Baulig <martin@ximian.com>
5190 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
5192 (FlowBranching.MergeFinally): Don't call
5193 `branching.CheckOutParameters()' here, this is called in
5195 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
5196 when adding the `finally' vector.
5198 2003-12-13 Martin Baulig <martin@ximian.com>
5201 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
5202 actually work and also fix #48962.
5204 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
5206 * decl.cs: Do not check System.Object for nested types,
5207 since we know it does not have any. Big bang for buck:
5212 corlib: 17.99 seconds
5216 corlib: 17.39 seconds
5218 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
5220 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
5221 time we are returning 0 members, so we save alot here.
5223 2003-12-11 Martin Baulig <martin@ximian.com>
5225 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
5226 `MergeChild()', also just take the `FlowBranching' as argument;
5227 call Merge() on it and return the result.
5228 (FlowBranching.Merge): We don't need to do anything if we just
5231 2003-12-11 Martin Baulig <martin@ximian.com>
5233 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
5234 them in an `ArrayList' to reduce memory usage. Thanks to Ben
5235 Maurer for this idea.
5237 2003-12-11 Martin Baulig <martin@ximian.com>
5239 * flowanalysis.cs (MergeResult): This class is now gone; we now
5240 use the `UsageVector' for this. The reason for this is that if a
5241 branching just has one sibling, we don't need to "merge" them at
5242 all - that's the next step to do.
5243 (FlowBranching.Merge): We now return a `UsageVector' instead of a
5246 2003-12-11 Martin Baulig <martin@ximian.com>
5248 Reworked flow analyis and made it more precise and bug-free. The
5249 most important change is that we're now using a special `Reachability'
5250 class instead of having "magic" meanings of `FlowReturns'. I'll
5251 do some more cleanups and optimizations and also add some more
5252 documentation this week.
5254 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
5255 largely reworked this class.
5256 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
5257 the new `Reachability' class instead of having "magic" values here.
5258 (FlowBranching): We're now using an instance of `Reachability'
5259 instead of having separate `Returns', `Breaks' etc. fields.
5261 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
5262 based on flow analysis; ignore the return value of block.Emit ().
5264 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
5266 * driver.cs typemanager.cs: Find the mono extensions to corlib even
5267 if they are private.
5269 2003-12-09 Martin Baulig <martin@ximian.com>
5271 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
5272 call them directly on the UsageVector.
5274 2003-12-09 Martin Baulig <martin@ximian.com>
5276 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
5277 Changed return type from `FlowReturns' to `Reachability'.
5279 2003-12-09 Martin Baulig <martin@ximian.com>
5281 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
5282 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
5283 `Reachable' fields with a single `Reachability' one.
5285 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5287 * class.cs (FindMembers): Remove foreach's.
5300 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5305 This patch does a few things:
5306 1. EmptyStatement is now a singleton, so it is never reallocated.
5307 2. All blah is EmptyStatement constructs have been changed to
5308 blah == EmptyStatement.Value, which is much faster and valid
5309 now that EmptyStatement is a singleton.
5310 3. When resolving a block, rather than allocating a new array for
5311 the non-empty statements, empty statements are replaced with
5312 EmptyStatement.Value
5313 4. Some recursive functions have been made non-recursive.
5314 Mainly the performance impact is from (3), however (1) and (2) are needed for
5315 this to work. (4) does not make a big difference in normal situations, however
5316 it makes the profile look saner.
5321 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5322 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5323 Total memory allocated: 56397 KB
5326 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
5327 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
5328 Total memory allocated: 55666 KB
5330 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5332 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
5333 than the hashtable in a hashtable version
5335 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
5336 we always end up concating a string. This results in a huge perf
5337 loss, because many strings have to be tracked by the GC. In this
5338 patch, we first use a hashtable that works with two keys, so that
5339 the strings do not need to be concat'ed.
5350 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5352 * Makefile: Add a new target `do-time' that does a quick and simple
5353 profile, leaving easy to parse output.
5355 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
5357 * codegen.cs (Init): Create the dynamic assembly with
5358 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
5360 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
5362 * support.cs: Make the PtrHashtable use only one
5363 instance of its comparer.
5365 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
5367 * typemanager.cs: Fix lookup of GetNamespaces.
5369 2003-11-29 Miguel de Icaza <miguel@ximian.com>
5371 * expression.cs: Removed redundant line.
5373 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
5374 ArrayLists, use for loops with bounds.
5376 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
5379 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
5380 arraylists, use for loop with bounds.
5382 The above three changes give us a 0.071 second performance
5383 improvement out of 3.294 seconds down to 3.223. On my machine
5384 the above changes reduced the memory usage by 1,387 KB during
5387 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5388 QualifiedIdentifiers. Before we created a new string through
5389 concatenation, and mostly later on, the result would be
5390 manipulated by DecomposeQI through string manipulation.
5392 This reduced the compiler memory usage for bootstrapping from
5393 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5394 compile times in 0.05 seconds.
5396 2003-11-28 Dick Porter <dick@ximian.com>
5398 * support.cs: Do string compares with the Invariant culture.
5406 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5407 the comparison is done with the Invariant culture.
5409 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5411 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5412 GetEnumerator method.
5414 (ProbeCollectionType): Iterate starting at the most specific type
5415 upwards looking for a GetEnumerator
5417 * expression.cs: Shift count can be up to 31 for int/uint and 63
5420 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5422 * statement.cs (Block.LookupLabel): Also look for the label on the
5423 children blocks. Use a hash table to keep track of visited
5426 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5427 we actually did transform the other operand, otherwise fall back
5428 to the common codepath that casts to long.
5430 * cs-tokenizer.cs: Use the same code pattern as the int case.
5431 Maybe I should do the parsing myself, and avoid depending on the
5432 Parse routines to get this done.
5434 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5436 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5437 which fixes bug 51347. This time test it.
5439 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5440 attributes for example can not tell the difference between these.
5441 The difference was only a syntax feature of the language.
5443 * attribute.cs: Apply attributes to delegates.
5445 * delegate.cs: Call the apply attributes method.
5447 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5449 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5450 comparing 0 vs Byte.MinValue, not the value
5452 (ImplicitConversionRequired): When reporting a conversion error,
5453 use error 31 to print out the constant error instead of the
5456 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5457 which fixes bug 51347.
5459 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5461 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5462 which fixes the -warnaserror command line option.
5464 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5466 * cfold.cs (DoNumericPromotions): During constant folding of
5467 additions on UIntConstant, special case intconstants with
5468 IntConstants like we do on the expression binary operator.
5470 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5472 * convert.cs (ImplicitReferenceConversion): We were missing a case
5473 (System.Enum are not value types or class types, so we need to
5474 classify them separatedly).
5476 * driver.cs: We do not support error 2007.
5478 2003-11-12 Jackson Harper <jackson@ximian.com>
5480 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5481 system directory. Also use the full file name so users can
5482 libraries names mscorlib-o-tron.dll in a non system dir.
5484 2003-11-10 Martin Baulig <martin@ximian.com>
5486 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5487 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5488 calling `ResolveType()' on them, directly assign their `Type'.
5490 2003-11-08 Martin Baulig <martin@ximian.com>
5492 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5493 return value and the `out parent' parameter.
5494 (TypeContainer.DefineType): Moved the CS0644 check into
5495 GetClassBases(). Don't pass the interface types to the
5496 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5497 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5499 * ecore.cs (TypeExpr.IsAttribute): New property.
5500 (TypeExpr.GetInterfaces): New method.
5502 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5503 TypeExpr instead of a Type.
5504 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5505 (Interface.DefineType): Don't pass the interface types to the
5506 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5507 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5509 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5510 instead of a `Type[]'.
5511 (TypeManager.RegisterBuilder): Likewise.
5512 (TypeManager.AddUserInterface): Likewise.
5513 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5514 `Type[]' and also return a `TypeExpr[]'.
5515 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5517 2003-11-08 Martin Baulig <martin@ximian.com>
5519 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5522 2003-11-08 Martin Baulig <martin@ximian.com>
5524 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5525 TypeManager.ResolveExpressionTypes().
5527 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5528 instead of an Expression.
5529 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5530 (TypeExpression): New public class; formerly known as `TypeExpr'.
5532 * expression.cs (ComposedCast): Derive from TypeExpr.
5534 * typemanager.cs (TypeManager.system_*_expr): These are now
5535 TypExpr's instead of Expression's.
5536 (TypeManager.ResolveExpressionTypes): New public static function;
5537 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5540 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5542 * expression.cs (New.DoResolve): Do not dereference value that
5543 might be a null return.
5545 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5546 sure that the constant value has the right type. Fixes an
5547 unreported bug, similar to 50425.
5549 * const.cs (Const.LookupConstantValue): Call
5550 ImplicitStandardConversionExists before doing a conversion to
5551 avoid havng the TypeManager.ChangeType do conversions.
5553 Reduced the number of casts used
5555 (Const.ChangeType): New routine to enable reuse of the constant
5556 type changing code from statement.
5558 * typemanager.cs (ChangeType): Move common initialization to
5559 static global variables.
5563 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5564 every value type to go through, even if it was void. Fix that.
5566 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5567 character of the define, and the is_identifier_part_character for
5568 the rest of the string.
5570 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5572 * expression.cs (UnaryMutator.EmitCode): When I updated
5573 LocalVariableReference.DoResolve, I overdid it, and dropped an
5574 optimization done on local variable references.
5576 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5578 * ecore.cs: Convert the return from Ldlen into an int.
5580 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5582 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5583 the accessibility, this is a special case for toplevel non-public
5584 classes (internal for instance).
5586 2003-10-20 Nick Drochak <ndrochak@gol.com>
5588 * ecore.cs: Fix typo and build. Needed another right paren.
5590 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5592 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5593 `internal' case regular and protected, but not allowing protected
5594 to be evaluated later. Bug 49840
5596 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5598 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5599 to kb.Nlast, and not the kb.nFirst to isolate the switch
5602 Extract the underlying type, so enumerations of long/ulong are
5603 treated like long/ulong.
5605 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5607 * expression.cs (New): Overload the meaning of RequestedType to
5608 track the possible creation of the NewDelegate type, since
5609 DoResolve is invoked more than once for new constructors on field
5612 See bugs: #48800 and #37014
5614 * cs-parser.jay (declare_local_constants): Take an arraylist
5615 instead of a single constant.
5617 (local_constant_declaration): It should take a
5618 constant_declarators, not a constant_declarator. Fixes 49487
5620 * convert.cs: Fix error report.
5622 2003-10-13 Jackson Harper <jackson@ximian.com>
5624 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5627 2003-10-09 Martin Baulig <martin@ximian.com>
5629 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5631 (MethodCore.DoDefineParameters): Removed the TypeContainer
5632 argument; use the DeclSpace which was passed to the .ctor instead.
5633 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5634 TypeContainer; we only need a DeclSpace here.
5636 2003-10-09 Martin Baulig <martin@ximian.com>
5638 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5640 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5641 EmitContext's .ctor.
5643 2003-10-09 Martin Baulig <martin@ximian.com>
5645 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5646 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5647 AsAccessible(), moved them as well.
5649 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5651 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5653 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5655 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5657 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5658 generation for >=, as spotted by Paolo, bug 48679.
5659 Patch from David Waite.
5661 * cs-tokenizer.cs: Add handling for #pragma.
5663 * cs-parser.jay: Allow for both yield and yield return in the
5664 syntax. The anti-cobolization of C# fight will go on!
5666 * class.cs (TypeBuilder.DefineType): Catch error condition here
5667 (Parent.DefineType erroring out and returning null).
5669 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5670 coping with enumerations variables, we were mistakenly processing
5671 them as a regular value type instead of built-in types. Fixes the
5674 * typemanager.cs (IsBuiltinOrEnum): New method.
5676 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5678 * cs-parser.jay: Upgrade: yield now needs the return clause.
5680 2003-09-19 Martin Baulig <martin@ximian.com>
5682 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5683 `MemberCache parent' argument. Normally, an interface doesn't
5684 have a parent type except System.Object, but we use this in gmcs
5685 for generic type parameters.
5687 2003-09-18 Martin Baulig <martin@ximian.com>
5689 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5690 on `type.IsInterface'; don't check whether the type has a parent
5691 to determine whether it's an interface.
5693 2003-09-15 Martin Baulig <martin@ximian.com>
5695 * class.cs (TypeContainer.DefineType): Added an error flag to
5696 avoid reporting duplicate CS0146's ("class definition is
5699 * driver.cs (Driver.MainDriver): Abort if
5700 RootContext.ResolveTree() reported any errors.
5702 2003-09-07 Martin Baulig <martin@ximian.com>
5704 * report.cs (Error, Warning): Added overloaded versions which take
5705 a `params object[] args' and call String.Format().
5707 2003-09-07 Martin Baulig <martin@ximian.com>
5709 * decl.cs (DeclSpace..ctor): Don't call
5710 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
5711 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
5712 (DeclSpace.RecordDecl): New method.
5714 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
5716 2003-09-02 Ravi Pratap <ravi@ximian.com>
5718 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
5719 value attributes to be applied to ParameterBuilders.
5721 * class.cs (MethodCore.LabelParameters): Make static and more
5722 generic so that it can be used from other places - like interface
5723 methods, for instance.
5725 * interface.cs (Interface.Emit): Call LabelParameters before
5726 emitting attributes on the InterfaceMethod.
5728 2003-08-26 Martin Baulig <martin@ximian.com>
5730 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
5731 resolving aliases; fixes #47927.
5733 2003-08-26 Martin Baulig <martin@ximian.com>
5735 * statement.cs (Using.DoResolve): This is internally emitting a
5736 try/finally clause, so we need to set ec.NeedExplicitReturn if we
5737 do not always return. Fixes #47681.
5739 2003-08-26 Martin Baulig <martin@ximian.com>
5741 * decl.cs (MemberCore): Moved WarningNotHiding(),
5742 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
5744 (AdditionResult): Make this nested in DeclSpace.
5745 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
5746 argument; call NamespaceEntry.Define() unless we're nested in a
5749 * namespace.cs (Namespace.DefineName): New public function. This
5750 is called from DeclSpace's .ctor to add
5751 (Namespace.Lookup): Include DeclSpaces in the lookup.
5753 * class.cs (Operator): Derive from MemberBase, not MemberCore.
5755 * const.cs (Const): Derive from MemberBase, not MemberCore.
5757 2003-08-25 Martin Baulig <martin@ximian.com>
5759 * convert.cs (Convert.ExplicitReferenceConversion): When
5760 converting from an interface type to a class, unbox if the target
5761 type is a struct type. Fixes #47822.
5763 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5765 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
5768 2003-08-22 Martin Baulig <martin@ximian.com>
5770 * class.cs (TypeManager.DefineType): When defining a nested type,
5771 call DefineType() on our parent; fixes #47801.
5773 2003-08-22 Martin Baulig <martin@ximian.com>
5775 * class.cs (MethodData.Define): While checking if a method is an
5776 interface implementation, improve the test a bit more to fix #47654.
5778 2003-08-22 Martin Baulig <martin@ximian.com>
5780 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
5781 correctly; fixes #47722.
5783 2003-08-22 Martin Baulig <martin@ximian.com>
5785 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
5786 LocalVariableReference, ensure it's not read-only. Fixes #47536.
5788 * statement.cs (Fixed.DoResolve): Make all variables read-only.
5790 2003-08-22 Martin Baulig <martin@ximian.com>
5792 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
5793 can only be assigned in static constructors. Fixes #47161.
5795 2003-08-22 Martin Baulig <martin@ximian.com>
5797 Rewrote and improved the flow analysis code.
5799 * flowbranching.cs (FlowBranching): Make this class abstract.
5800 (FlowBranching.CreateBranching): New static function to create a
5802 (FlowBranchingBlock, FlowBranchingException): New classes.
5803 (FlowBranching.UsageVector.Type): New public readonly field.
5804 (FlowBranching.UsageVector.Breaks): Removed the setter.
5805 (FlowBranching.UsageVector.Returns): Removed the setter.
5806 (FlowBranching.UsageVector): Added Break(), Return(),
5807 NeverReachable() and Throw() methods to modify the reachability.
5808 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
5809 done by FlowBranching.Merge().
5810 (FlowBranching.UsageVector.MergeChild): New method; merges the
5811 merge result into the current vector.
5812 (FlowBranching.Merge): New abstract method to merge a branching.
5814 2003-08-12 Martin Baulig <martin@ximian.com>
5816 * expression.cs (Indirection.CacheTemporaries): Create the
5817 LocalTemporary with the pointer type, not its element type.
5819 2003-08-10 Miguel de Icaza <miguel@ximian.com>
5821 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
5822 token was a keyword or not.
5824 Add `error' options where an IDENTIFIER was expected; Provide
5825 CheckToken and CheckIdentifierToken convenience error reporting
5828 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
5830 * decl.cs: Rename `NamespaceEntry Namespace' public field into
5831 NameSpaceEntry NameSpaceEntry.
5833 (LookupInterfaceOrClass): Avoid creating a full qualified name
5834 from namespace and name: avoid doing lookups when we know the
5835 namespace is non-existant. Use new Tree.LookupByNamespace which
5836 looks up DeclSpaces based on their namespace, name pair.
5838 * driver.cs: Provide a new `parser verbose' to display the
5839 exception thrown during parsing. This is turned off by default
5840 now, so the output of a failure from mcs is more graceful.
5842 * namespace.cs: Track all the namespaces defined in a hashtable
5845 (IsNamespace): New method
5847 2003-08-09 Miguel de Icaza <miguel@ximian.com>
5849 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
5850 we know that we need to concatenate (full typename can never be
5855 * statement.cs: Use a bitfield; Do not initialize to null things
5856 which are done by the constructor by default.
5858 * cs-parser.jay: bug fix, parameter was 4, not 3.
5860 * expression.cs: Just use the property;
5862 * statement.cs: No need for GetVariableInfo method.
5864 2003-08-08 Martin Baulig <martin@ximian.com>
5866 * flowanalysis.cs (FlowReturns): This is now nested in the
5867 `FlowBranching' class.
5868 (MyBitVector): Moved this here from statement.cs.
5869 (FlowBranching.SiblingType): New enum type.
5870 (FlowBranching.CreateSibling): Added `SiblingType' argument.
5872 2003-08-07 Martin Baulig <martin@ximian.com>
5874 * flowanalysis.cs (FlowBranchingType): This is now nested in the
5875 `FlowBranching' class and called `BranchingType'.
5877 2003-08-07 Martin Baulig <martin@ximian.com>
5879 * flowanalysis.cs: Moved all the control flow analysis code into
5882 2003-08-07 Martin Baulig <martin@ximian.com>
5884 * assign.cs (Assign.DoResolve): `target' must either be an
5885 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
5888 2003-08-07 Miguel de Icaza <miguel@ximian.com>
5890 * expression.cs (BinaryMethod): This kind of expression is created by the
5891 Binary class if it determines that the operator has to be handled
5894 (BinaryDelegate): This kind of expression is created if we are
5895 dealing with a + or - operator on delegates.
5897 (Binary): remove method, argumetns, and DelegateOperator: when
5898 dealing with methods,
5900 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
5902 * statement.cs (Block): use bitfields for the three extra booleans
5903 we had in use. Remove unused topblock parameter.
5905 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
5907 * assign.cs: Drop extra unneeded tests.
5909 2003-08-06 Miguel de Icaza <miguel@ximian.com>
5911 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
5913 * statement.cs (Foreach): Use VariableStorage instead of
5916 * codegen.cs (VariableStorage): New class used by clients that
5917 require a variable stored: locals or fields for variables that
5918 need to live across yield.
5920 Maybe provide a convenience api for EmitThis+EmitLoad?
5922 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
5925 2003-08-05 Miguel de Icaza <miguel@ximian.com>
5927 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
5928 RemapParameterLValue): New methods that are used to turn a
5929 precomputed FieldInfo into an expression like this:
5933 The idea is to use this instead of making LocalVariableReference
5934 have more than one meaning.
5936 * cs-parser.jay: Add error production to BASE.
5938 * ecore.cs: Deal with TypeManager.GetField returning null, which
5939 is now a valid return value.
5941 (FieldExprNoAddress): New expression for Fields whose address can
5944 * expression.cs (LocalVariableReference): During the resolve
5945 phases, create new expressions if we are in a remapping context.
5946 Remove code that dealt with remapping here.
5948 (ParameterReference): same.
5950 (ProxyInstance): New expression, like the `This' expression, but
5951 it is born fully resolved. We know what we are doing, so remove
5952 the errors that are targeted to user-provided uses of `this'.
5954 * statement.cs (Foreach): our variable is now stored as an
5955 Expression; During resolution, follow the protocol, dont just
5956 assume it will return this.
5958 2003-08-06 Martin Baulig <martin@ximian.com>
5960 * support.cs (SeekableStreamReader.cs): New public class.
5962 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
5963 SeekableStreamReader instead of the normal StreamReader.
5965 2003-08-04 Martin Baulig <martin@ximian.com>
5967 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
5968 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
5969 deambiguate casts and delegate invocations.
5970 (parenthesized_expression): Use the new tokens to ensure this is
5971 not a cast of method invocation.
5973 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
5974 when reading a `)' and Deambiguate_CloseParens () was previously
5977 * expression.cs (ParenthesizedExpression): New class. This is
5978 just used for the CS0075 test.
5979 (Binary.DoResolve): Check for CS0075.
5981 2003-07-29 Ravi Pratap <ravi@ximian.com>
5983 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
5984 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
5985 reference comparison.
5987 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
5988 examine the ReturnType for equality - this is necessary in the
5989 cases of implicit and explicit operators whose signature also
5990 includes the return type.
5992 2003-07-26 Miguel de Icaza <miguel@ximian.com>
5994 * namespace.cs: Cache the result of the namespace computation,
5995 instead of computing it every time.
5997 2003-07-24 Miguel de Icaza <miguel@ximian.com>
5999 * decl.cs: Use a global arraylist that we reuse over invocations
6000 to avoid excesive memory consumption. Reduces memory usage on an
6001 mcs compile by one meg (45 average).
6003 * typemanager.cs (LookupTypeReflection): In .NET pointers are
6004 private, work around that.
6006 2003-07-23 Miguel de Icaza <miguel@ximian.com>
6008 * literal.cs (IntLiteral): Define Zero and One static literals.
6010 * cs-parser.jay (integer_literal): use static literals to reduce
6011 memory usage for the most used literals (0, 1 and -1). 211kb
6012 reduced in memory usage.
6014 Replace all calls to `new ArrayList' with `new
6015 ArrayList(4)' which is a good average number for most allocations,
6016 and also requires only 16 bytes of memory for its buffer by
6019 This reduced MCS memory usage in seven megabytes for the RSS after
6022 2003-07-28 Ravi Pratap <ravi@ximian.com>
6024 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
6025 handle params methods the correct way by forming only one
6026 applicable set with params and normal methods in them. Earlier we
6027 were looking at params methods only if we found no normal methods
6028 which was not the correct thing to do.
6030 (Invocation.BetterFunction): Take separate arguments indicating
6031 when candidate and the best method are params methods in their
6034 This fixes bugs #43367 and #46199.
6036 * attribute.cs: Documentation updates.
6038 (CheckAttribute): Rename to CheckAttributeTarget.
6039 (GetValidPlaces): Rename to GetValidTargets.
6041 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
6042 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
6046 2003-07-28 Martin Baulig <martin@ximian.com>
6048 * class.cs (TypeContainer.DefineMembers): Use the base type's full
6049 name when looking up the base class of a nested class. Fixes #46977.
6051 2003-07-26 Martin Baulig <martin@ximian.com>
6053 * expression.cs (Indexers.Indexer): New nested struct; contains
6054 getter, setter and the indexer's type.
6055 (Indexers.Properties): This is now an ArrayList of
6057 (IndexerAccess.DoResolveLValue): Correctly set the type if the
6058 indexer doesn't have any getters.
6060 * assign.cs (Assign.DoResolve): Also do the implicit conversions
6061 for embedded property and indexer assignments.
6063 2003-07-26 Martin Baulig <martin@ximian.com>
6065 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
6066 preprocessor directive is not the first non-whitespace character
6069 2003-07-26 Martin Baulig <martin@ximian.com>
6071 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
6072 namespace parsing, follow the spec more closely.
6074 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
6075 NamespaceEntry.Lookup().
6077 2003-07-25 Martin Baulig <martin@ximian.com>
6079 * MethodCore.cs (OverridesSomething): New public field; it's set
6080 from TypeContainer.DefineMembers if this method overrides
6081 something (which doesn't need to be a method). Fix #39462.
6083 2003-07-25 Ravi Pratap <ravi@ximian.com>
6085 * typemanager.cs (GetMembers): Ensure that the list of members is
6086 reversed. This keeps things in sync.
6088 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
6089 find an AttributeUsage attribute.
6091 * expression.cs (Invocation.OverloadResolve): Perform the check
6092 which disallows Invoke to be directly called on a Delegate.
6094 (Error_InvokeOnDelegate): Report error cs1533.
6096 2003-07-25 Martin Baulig <martin@ximian.com>
6098 * expression.cs (Indexers.GetIndexersForType): Only look in the
6099 interface hierarchy if the requested type is already an
6100 interface. Fixes #46788 while keeping #46502 fixed.
6102 2003-07-25 Martin Baulig <martin@ximian.com>
6104 * class.cs (TypeContainer.DefineMembers): Check whether all
6105 readonly fields have been assigned and report warning CS0649 if
6108 * statement.cs (LocalInfo.IsFixed): Always return true if this is
6111 2003-07-24 Ravi Pratap <ravi@ximian.com>
6113 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
6114 returned from GetMethods to make things consistent with the
6115 assumptions MCS makes about ordering of methods.
6117 This should comprehensively fix bug #45127 and it does :-)
6119 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
6120 ordering is actually reverse.
6122 * Clean up some debug messages I left lying around.
6124 * interface.cs (Populate*): Get rid of code which emits attributes
6125 since the stage in which we emit attributes is the 'Emit' stage,
6126 not the define stage.
6128 (Emit): Move attribute emission for interface members here.
6130 2003-07-22 Ravi Pratap <ravi@ximian.com>
6132 * expression.cs (Invocation.OverloadResolve): Follow the spec more
6133 closely: we eliminate methods in base types when we have an
6134 applicable method in a top-level type.
6136 Please see section 14.5.5.1 for an exact description of what goes
6139 This fixes bug #45127 and a host of other related to corlib compilation.
6141 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
6142 array is the method corresponding to the top-level type (this is
6143 because of the changes made to icall.c) so we change this
6146 (MethodGroupExpr.Name): This too.
6148 * typemanager.cs (GetElementType): New method which does the right
6149 thing when compiling corlib.
6151 * everywhere: Make use of the above in the relevant places.
6153 2003-07-22 Martin Baulig <martin@ximian.com>
6155 * cs-parser.jay (invocation_expression): Moved
6156 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
6157 `cast_expression', but create a InvocationOrCast which later
6158 resolves to either an Invocation or a Cast.
6160 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
6161 method; call this before EmitStatement() to make sure that this
6162 expression can be used as a statement.
6164 * expression.cs (InvocationOrCast): New class; resolves to either
6165 an Invocation or a Cast.
6167 * statement.cs (StatementExpression): Call ResolveStatement() on
6168 the ExpressionStatement before emitting it.
6170 2003-07-21 Martin Baulig <martin@ximian.com>
6172 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
6173 `ref' and `out' attributes match; fixes #46220.
6174 (MemberAccess.ResolveMemberAccess): You can't reference a type
6175 through an expression; fixes #33180.
6176 (Indexers.GetIndexersForType): Don't return the indexers from
6177 interfaces the class implements; fixes #46502.
6179 2003-07-21 Martin Baulig <martin@ximian.com>
6181 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
6182 CS0661 checks; fixes bug #30442.
6184 2003-07-21 Martin Baulig <martin@ximian.com>
6186 * decl.cs (AdditionResult): Added `Error'.
6188 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
6190 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
6191 makes cs0031.cs actually work.
6193 2003-07-20 Martin Baulig <martin@ximian.com>
6195 * namespace.cs: Fixed that bug which caused a crash when compiling
6198 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6200 * typemanager.cs (LookupTypeReflection): Never expose types which
6201 are NotPublic, NestedPrivate, NestedAssembly, or
6202 NestedFamANDAssem. We used to return these, and later do a check
6203 that would report a meaningful error, but the problem is that we
6204 would not get the real match, if there was a name override.
6206 2003-07-18 Miguel de Icaza <miguel@ximian.com>
6208 * namespace.cs (Namespace, Name): Do not compute the namespace
6209 name dynamically, compute it in the constructor. This reduced
6210 memory usage by 1697 KB.
6212 * driver.cs: Use --pause to pause at the end.
6214 2003-07-17 Peter Williams <peter@newton.cx>
6216 * Makefile: Change the name of the test target so that it doesn't
6217 conflict with the recursive test target.
6219 2003-07-17 Miguel de Icaza <miguel@ximian.com>
6221 * expression.cs (LocalVariableReference.Emit, EmitAssign,
6222 AddressOf): Do not use EmitThis, that was wrong, use the actual
6225 2003-07-15 Miguel de Icaza <miguel@ximian.com>
6227 * class.cs (MethodData.Define): While checking if a method is an
6228 interface implementation, improve the test: If we are not public
6229 (use new test here: use the computed MethodAttributes directly,
6230 instead of the parsed modifier flags) check if the `implementing'
6231 method comes from an interface or not.
6233 * pending.cs (VerifyPendingMethods): Slightly better error
6236 * makefile: add test target that does the mcs bootstrap.
6238 2003-07-16 Ravi Pratap <ravi@ximian.com>
6240 * interface.cs (Define): Do nothing here since there are no
6241 members to populate etc. Move the attribute emission out of here
6242 since this was just totally the wrong place to put it. Attribute
6243 application happens during the 'Emit' phase, not in the 'Define'
6246 (Emit): Add this method and move the attribute emission here
6248 * rootcontext.cs (EmitCode): Call the Emit method on interface
6251 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6253 * expression.cs (OverloadResolve): Report error only if Location
6254 is not 'Null' which means that there was a probe going on.
6256 2003-07-14 Martin Baulig <martin@ximian.com>
6258 * expression.cs (ConditionalLogicalOperator): New public class to
6259 implement user defined conditional logical operators.
6260 This is section 14.11.2 in the spec and bug #40505.
6262 2003-07-14 Martin Baulig <martin@ximian.com>
6264 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
6266 2003-07-14 Martin Baulig <martin@ximian.com>
6268 * codegen.cs (EmitContext.InFixedInitializer): New public field.
6270 * ecore.cs (IVariable.VerifyFixed): New interface method.
6272 * expression.cs (Unary.ResolveOperator): When resolving the `&'
6273 operator, check whether the variable is actually fixed. Fixes bug
6274 #36055. Set a variable definitely assigned when taking its
6275 address as required by the spec.
6277 * statement.cs (LocalInfo.IsFixed): New field.
6278 (LocalInfo.MakePinned): Set `IsFixed' to true.
6280 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6282 * attribute.cs (Attribute.Resolve): While doing a Member lookup
6283 for .ctors, ensure that we only ask for members declared in the
6284 attribute type (BindingFlags.DeclaredOnly).
6288 * expression.cs (Error_WrongNumArguments): Report error 1501
6289 correctly the way CSC does.
6291 2003-07-13 Martin Baulig <martin@ximian.com>
6293 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
6294 lookup on the fully qualified name, to make things like "X.X" work
6295 where "X.X" is a fully qualified type name, but we also have a
6296 namespace "X" in the using list. Fixes #41975.
6298 2003-07-13 Martin Baulig <martin@ximian.com>
6300 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
6301 function. If we're a CompoundAssign, we need to create an embedded
6302 CompoundAssign, not an embedded Assign.
6303 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
6306 2003-07-13 Martin Baulig <martin@ximian.com>
6308 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
6309 work to fix bug #46088.
6311 2003-07-13 Ravi Pratap <ravi@ximian.com>
6313 * class.cs (Operator.Emit): Do not emit attributes here - it is
6314 taken care of by the Method class that we delegate too. This takes
6317 2003-07-10 Martin Baulig <martin@ximian.com>
6319 * expression.cs (TypeOfVoid): New class.
6320 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6322 2003-07-10 Martin Baulig <martin@ximian.com>
6324 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6327 2003-07-10 Martin Baulig <martin@ximian.com>
6329 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6330 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6332 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6334 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6336 2003-07-10 Martin Baulig <martin@ximian.com>
6338 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6339 of decimal. Fixes #42850.
6341 NOTE: I also fixed the created byte blob, but this doesn't work on
6342 the MS runtime and csc never produces any byte blobs for decimal
6345 2003-07-10 Martin Baulig <martin@ximian.com>
6347 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6348 structs; fixes #32068.
6349 (Block.AddChildVariableNames): Fixed #44302.
6351 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6353 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6355 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6357 * attribute.cs: And this test is onger needed.
6359 2003-07-08 Martin Baulig <martin@ximian.com>
6361 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6362 inaccessible types. Fixes #36313.
6364 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6366 * namespace.cs (NamespaceEntry): Create implicit entries for all
6367 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6368 implicit entries for N1.N2 and N1.
6370 2003-07-08 Martin Baulig <martin@ximian.com>
6372 Rewrote the handling of namespaces to fix a lot of the issues
6373 wrt. `using' aliases etc.
6375 * namespace.cs (Namespace): Splitted this class into a
6376 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6378 * typemanager.cs (TypeManager.IsNamespace): Removed.
6379 (TypeManager.ComputeNamespaces): Only compute namespaces from
6380 loaded assemblies here, not the namespaces from the assembly we're
6381 currently compiling.
6383 2003-07-08 Martin Baulig <martin@ximian.com>
6385 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6387 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6389 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6392 I thought about the memory savings here, but LookupTypeReflection
6393 is used under already very constrained scenarios. Compiling
6394 corlib or mcs only exposes one hit, so it would not really reduce
6395 any memory consumption.
6397 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6399 * typemanager.cs: fixes bug #45889 by only adding public types from
6400 other assemblies to the list of known types.
6402 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6404 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6405 on the type we resolved.
6407 2003-07-05 Martin Baulig <martin@ximian.com>
6409 * pending.cs (PendingImplementation.ParentImplements): Don't
6410 create the proxy if the parent is abstract.
6412 * class.cs (TypeContainer.DefineIndexers): Process explicit
6413 interface implementations first. Fixes #37714.
6415 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6417 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6418 defined recursively; but since we modify the input parameters
6419 (left is set to `this' temporarily), we reset this value if the
6420 left_is_explicit is false, which gives the original semantics to
6423 * literal.cs (NullPointer): new class used to represent a null
6424 literal in a pointer context.
6426 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6427 type is a pointer, use a NullPointer object instead of a
6428 NullLiteral. Closes 43687
6430 (ExplicitConversion): Convert pointer values using
6431 the conv opcode to the proper type.
6433 * ecore.cs (New): change ValueTypeVariable property into a method,
6434 that returns whether the valuetype is suitable for being used.
6436 * expression.cs (Binary.DoNumericPromotions): Only return if we
6437 the int constant was a valid uint, and we can return both left and
6438 right as uints. If not, we continue processing, to trigger the
6439 type conversion. This fixes 39018.
6441 * statement.cs (Block.EmitMeta): During constant resolution, set
6442 the CurrentBlock property on the emitcontext, so that we resolve
6443 constants propertly.
6445 2003-07-02 Martin Baulig <martin@ximian.com>
6447 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6448 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6450 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6451 than emitting it here.
6453 * statement.cs: Fixed some more flow analysis bugs.
6455 2003-07-02 Martin Baulig <martin@ximian.com>
6457 * class.cs (MethodData.Define): When implementing interface
6458 methods, set Final unless we're Virtual.
6460 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6461 check work for interface methods.
6463 2003-07-01 Martin Baulig <martin@ximian.com>
6465 * ecore.cs (EmitContext.This): Replaced this property with a
6466 GetThis() method which takes a Location argument. This ensures
6467 that we get the correct error location for a CS0188.
6469 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6471 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6472 ImplicitStandardConversion.
6474 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6476 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6478 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6481 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6483 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6486 (MethodData.Define): Turn off initlocals for unsafe methods.
6488 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6490 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6491 complete; Fixes #37521.
6493 * delegate.cs: Use Modifiers.TypeAttr to compute the
6494 TypeAttributes, instead of rolling our own. This makes the flags
6495 correct for the delegates.
6497 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6499 * class.cs (Constructor.Define): Set the private flag for static
6500 constructors as well.
6502 * cs-parser.jay (statement_expression): Set the return value to
6503 null, to avoid a crash when we catch an error.
6505 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6507 * cs-parser.jay: Applied patch from Jackson that adds support for
6508 extern and unsafe modifiers to destructor declarations.
6510 * expression.cs: Report error 21 if the user is trying to index a
6513 * driver.cs: Add an error message, suggested by the bug report.
6515 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6516 if we do not have a ": this ()" constructor initializer. Fixes 45149
6518 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6520 * namespace.cs: Add some information to reduce FAQs.
6522 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6524 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6525 underlying enumeration types. Fixes #43915.
6527 * expression.cs: Treat ushort/short as legal values to be used in
6530 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6532 * delegate.cs: transfer custom attributes for paramenters from
6533 the delegate declaration to Invoke and BeginInvoke.
6535 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6537 * attribute.cs: handle custom marshalers and emit marshal info
6540 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6542 * makefile.gnu: Added anonymous.cs to the compiler sources.
6544 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6546 * iterators.cs: Change the name of the proxy class to include two
6549 * cs-parser.jay: Update grammar to include anonymous methods.
6551 * anonymous.cs: new file.
6553 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6555 * class.cs (Field.Define): Add missing test for pointers and
6558 2003-05-27 Ravi Pratap <ravi@ximian.com>
6560 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6561 we use the stobj opcode.
6563 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6564 since it wasn't the correct fix.
6566 It still is puzzling that we are required to use stobj for IntPtr
6567 which seems to be a ValueType.
6569 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6571 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6572 during regular simple name resolution. Now, the trick is that
6573 instead of returning for processing the simplename, we do a
6574 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6575 contextual lookup type). If a match is found, return that, if
6576 not, return for further composition.
6578 This fixes long-standing 30485.
6580 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6581 using the address to initialize an object, do an Stobj instead of
6582 using the regular Stelem.
6584 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6585 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6586 Because if we are a BaseIndexerAccess that value will be true.
6589 * statement.cs (GotoCase.Resolve): Return after reporting an
6590 error, do not attempt to continue.
6592 * expression.cs (PointerArithmetic.Emit): If our operand is a
6593 long, convert our constants to match the operand before
6594 multiplying. Convert to I type before adding. Fixes 43670.
6596 2003-05-14 Ravi Pratap <ravi@ximian.com>
6598 * enum.cs (ImplicitConversionExists) : Rename to
6599 ImplicitEnumConversionExists to remove ambiguity.
6601 * ecore.cs (NullCast): New type of cast expression class which
6602 basically is very similar to EmptyCast with the difference being
6603 it still is a constant since it is used only to cast a null to
6607 * convert.cs (ImplicitReferenceConversion): When casting a null
6608 literal, we return a NullCast.
6610 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6611 should be around anymore.
6613 The renaming (reported was slightly wrong). Corrections:
6615 ConvertImplicitStandard -> ImplicitConversionStandard
6616 ConvertExplicitStandard -> ExplicitConversionStandard
6618 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6619 before passing them in !
6621 * convert.cs (ImplicitConversionStandard): When comparing for
6622 equal expr and target types, ensure that expr is not a
6625 In general, we must not be checking (expr_type ==
6626 target_type) in the top level conversion methods
6627 (ImplicitConversion, ExplicitConversion etc). This checking is
6628 done in the methods that they delegate to.
6630 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6632 * convert.cs: Move Error_CannotConvertType,
6633 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6634 ImplicitNumericConversion, ImplicitConversionExists,
6635 ImplicitUserConversionExists, StandardConversionExists,
6636 FindMostEncompassedType, FindMostSpecificSource,
6637 FindMostSpecificTarget, ImplicitUserConversion,
6638 ExplicitUserConversion, GetConversionOperators,
6639 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6640 TryImplicitIntConversion, Error_CannotConvertImplicit,
6641 ConvertImplicitRequired, ConvertNumericExplicit,
6642 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6643 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6646 Perform the following renames:
6648 StandardConversionExists -> ImplicitStandardConversionExists
6649 ConvertImplicit -> ImplicitConversion
6650 ConvertImplicitStandard -> ImplicitStandardConversion
6651 TryImplicitIntConversion -> ImplicitIntConversion
6652 ConvertImplicitRequired -> ImplicitConversionRequired
6653 ConvertNumericExplicit -> ExplicitNumericConversion
6654 ConvertReferenceExplicit -> ExplicitReferenceConversion
6655 ConvertExplicit -> ExplicitConversion
6656 ConvertExplicitStandard -> ExplicitStandardConversion
6658 2003-05-19 Martin Baulig <martin@ximian.com>
6660 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6661 (TypeInfo): Added support for structs having structs as fields.
6663 * ecore.cs (FieldExpr): Implement IVariable.
6664 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6665 VariableInfo for the field.
6667 2003-05-18 Martin Baulig <martin@ximian.com>
6669 * expression.cs (This.DoResolve): Report a CS0027 if we're
6670 emitting a field initializer.
6672 2003-05-18 Martin Baulig <martin@ximian.com>
6674 * expression.cs (This.ResolveBase): New public function.
6675 (This.DoResolve): Check for CS0188.
6677 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
6680 * ecore.cs (MethodGroupExpr.DoResolve): Set the
6681 `instance_expression' to null if we don't have any non-static
6684 2003-05-18 Martin Baulig <martin@ximian.com>
6686 Reworked the way how local variables and parameters are handled by
6687 the flow analysis code.
6689 * statement.cs (TypeInfo, VariableMap): New public classes.
6690 (VariableInfo): New public class. This is now responsible for
6691 checking whether a variable has been assigned. It is used for
6692 parameters and local variables.
6693 (Block.EmitMeta): Take the InternalParameters as argument; compute
6694 the layout of the flow vectors here.
6695 (Block.LocalMap, Block.ParameterMap): New public properties.
6696 (FlowBranching): The .ctor doesn't get the InternalParameters
6697 anymore since Block.EmitMeta() now computes the layout of the flow
6699 (MyStructInfo): This class is now known as `StructInfo' and nested
6700 in `TypeInfo'; we don't access this directly anymore.
6702 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
6703 property and removed IsAssigned(), IsFieldAssigned(),
6704 SetAssigned() and SetFieldAssigned(); we now call them on the
6705 VariableInfo so we don't need to duplicate this code everywhere.
6707 * expression.cs (ParameterReference): Added `Block block' argument
6709 (LocalVariableReference, ParameterReference, This): The new
6710 VariableInfo class is now responsible for all the definite
6713 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
6714 IsParameterAssigned, SetParameterAssigned): Removed.
6716 2003-05-18 Martin Baulig <martin@ximian.com>
6718 * typemanager.cs (InitCoreTypes): Try calling
6719 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
6720 the 3-args-version. Corlib now also needs our `void_type'.
6721 (GetMethod): Added overloaded version which takes an optional
6722 `bool report_errors' to allow lookups of optional methods.
6724 2003-05-12 Martin Baulig <martin@ximian.com>
6726 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
6727 only used for locals and not for parameters.
6729 2003-05-12 Miguel de Icaza <miguel@ximian.com>
6731 * support.cs (InternalParameters.ParameterType): Return the
6732 ExternalType of the parameter.
6734 * parameter.cs (Parameter.ExternalType): drop the two arguments,
6737 2003-05-11 Miguel de Icaza <miguel@ximian.com>
6739 * class.cs (MethodData.Define): Do not set the `newslot' on
6740 interface members, if they are also flagged as "override".
6742 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
6743 better code for ++i and i++. This only works for static fields
6744 and local variables.
6746 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
6747 want to pull the DeclSpace out of the builder_to_declspace instead
6748 of the TypeBuilder (like in TypeContainer.FindMembers).
6750 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
6751 instead of LookupTypeContainer. Fixes the crash on .NET for
6752 looking up interface members.
6754 * const.cs: Create our own emit context during the Definition
6755 stage, so that constants are evaluated in the proper context, when
6756 a recursive definition happens.
6758 2003-05-11 Martin Baulig <martin@ximian.com>
6760 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
6761 new block for a switch section.
6762 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
6763 the adding/lookup in the switch block. Fixes #39828.
6765 2003-05-09 Miguel de Icaza <miguel@ximian.com>
6767 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
6768 functionality: I needed to convert the data after I had performed
6769 the add/sub operation into the operands type size.
6771 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
6772 pass the type for the box operation, otherwise the resulting
6773 object would have been of type object.
6775 (BoxedCast): Add constructor to specify the type to box as.
6777 2003-05-07 Miguel de Icaza <miguel@ximian.com>
6779 * iterators.cs: I was reusing the `count' variable inadvertently,
6780 take steps to not allow this to happen.
6782 2003-05-06 Miguel de Icaza <miguel@ximian.com>
6784 * attribute.cs (Attribute.Resolve): Params attributes are encoded
6785 by creating an array at the point where the params starts and
6786 putting all those arguments there, then adjusting the size of the
6789 2003-05-05 Miguel de Icaza <miguel@ximian.com>
6791 * expression.cs (New.AddressOf): Implement interface
6792 IMemoryLocation. This is used when the `new' operator is used in
6793 the context of an invocation to a method on a value type.
6795 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
6798 * namespace.cs: Also check the using aliases here.
6800 * driver.cs: Move the test for using validity after the types have
6801 been entered, so we do a single pass that also includes the using
6804 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
6805 in the regular case. CreateSiblingForFinally is doing extra
6808 * attribute.cs (GetAttributeArgumentExpression): Store the result
6809 on an out value, and use the return value to indicate failure
6810 instead of using null (which is a valid return for Constant.GetValue).
6812 * statement.cs: Perform the analysis flow for the increment
6813 portion after the statement, because this will be the real flow of
6814 execution. Fixes #42385
6816 * codegen.cs (EmitContext.EmitArgument,
6817 EmitContext.EmitStoreArgument): New helper functions when the
6818 RemapToProxy flag is set.
6820 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
6823 Add support for remapping parameters.
6825 * iterators.cs: Propagate parameter values; Store parameter
6826 values in the proxy classes.
6828 2003-05-04 Miguel de Icaza <miguel@ximian.com>
6830 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
6831 need a proxy reference; I do not know what I was thinking
6833 * cs-parser.jay (constructor_initializer): catch another error,
6834 and display nice message.
6836 (field_declaration): catch void field declaration
6837 to flag a better error.
6839 * class.cs (MemberBase.CheckBase): Report an error instead of a
6840 warning if a new protected member is declared in a struct.
6841 (Field.Define): catch the error of readonly/volatile.
6843 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
6845 (FieldExpr.AddressOf): ditto. Catch error where the address of a
6846 volatile variable is taken
6848 2003-05-02 Miguel de Icaza <miguel@ximian.com>
6850 * statement.cs (Fixed.Resolve): Report an error if we are not in
6853 2003-05-01 Miguel de Icaza <miguel@ximian.com>
6855 * typemanager.cs: reuse the code that handles type clashes for
6856 delegates and enumerations.
6858 * class.cs (Report28): Always report.
6860 * expression.cs (EncodeAsAttribute): Allow nulls here.
6862 2003-04-28 Miguel de Icaza <miguel@ximian.com>
6864 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
6865 the functionality for testing whether an expression is valid for
6866 an attribute here. Also handle the case of arrays of elements
6869 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
6870 encoding a linear array into an array of objects that are suitable
6871 to be passed to an CustomAttributeBuilder.
6873 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
6875 * ecore.cs: (FieldExpr): Handle field remapping here.
6877 * iteratators.cs: Pass the instance variable (if the method is an
6878 instance method) to the constructors, so we can access the field
6879 variables on the class.
6881 TODO: Test this with structs. I think the THIS variable on
6882 structs might have to be a pointer, and not a refenrece
6884 2003-04-27 Miguel de Icaza <miguel@ximian.com>
6886 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
6887 local variables to fields in a proxy class.
6889 * iterators.cs (PopulateProxy): Rename our internal fields to
6891 Create a <THIS> field if we are an instance method, so we can
6892 reference our parent container variables.
6893 (MapVariable): Called back from the EmitContext code to enter a
6894 new variable to field mapping into the proxy class (we just create
6898 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
6899 for using the remapped locals to fields.
6901 I placed the code here, because that gives the same semantics to
6902 local variables, and only changes the Emit code.
6904 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
6905 statements inside iterators.
6906 (VariableInfo): Add a FieldBuilder for the cases when we are
6907 remapping local variables to fields in a proxy class
6909 * ecore.cs (SimpleNameResolve): Avoid testing two times for
6910 current_block != null.
6912 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
6913 not cope with strings, as it has been moved to the
6914 TableSwitchEmit. Fixed bug in switch generation.
6916 * expression.cs (New.DoResolve): Provide more context for the user
6917 when reporting an error.
6919 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
6922 * expression.cs (MemberAccess.DoResolve): When we get a type back,
6923 check the permissions for it. Note than in a type-resolution
6924 context the check was already present in DeclSpace.ResolveType,
6925 but was missing from the MemberAccess.
6927 (ArrayCreation.CheckIndices): warn if the user has
6928 more nested levels of expressions, but there are no more
6929 dimensions specified. Avoids crash on bug 41906.
6931 2003-04-26 Miguel de Icaza <miguel@ximian.com>
6933 * statement.cs (Block): replace Implicit bool, for a generic
6935 New flag: `Unchecked'. This is used during the EmitMeta phase
6936 (which is out-of-line with the regular Resolve/Emit process for a
6937 statement, as this is done ahead of time, but still gets a chance
6938 to call constant resolve).
6940 (Block.Flags): new enum for adding a new flag.
6942 (Block.EmitMeta): track the state of unchecked.
6944 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
6945 to enable constant resolution to work there as well.
6947 2003-04-22 Miguel de Icaza <miguel@ximian.com>
6949 * typemanager.cs (ienumerable_type): Also look up
6950 System.Collections.IEnumerable.
6952 2003-04-21 Miguel de Icaza <miguel@ximian.com>
6954 TODO: Test more than one conditional per method.
6956 * class.cs (Indexer.Define): Report the location where the user is
6957 referencing the unsupported feature.
6959 (MethodData): Overload the use of `conditionals' to
6960 minimize the creation of needless ArrayLists. This saves roughly
6961 212kb on my machine.
6963 (Method): Implement the new IIteratorContainer interface.
6964 (Method.SetYields): Implement the method by setting the ModFlags
6965 to contain METHOD_YIELDS.
6967 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
6968 which just got set to null.
6970 * iterators.cs: New file.
6972 (Yield, YieldBreak): New statements.
6974 * statement.cs (Return.Resolve): Flag an error if we are used in
6977 * codegen.cs (InIterator): New flag set if the code is being
6978 compiled in an iterator method.
6980 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
6981 internal modifier, and we just use it to avoid adding extra
6982 fields, as this is seldom used.
6984 * cs-parser.jay: Add yield_statement (yield and yield break).
6986 * driver.cs: New flag -v2 to turn on version 2 features.
6988 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
6989 hashtable when v2 is enabled.
6991 2003-04-20 Miguel de Icaza <miguel@ximian.com>
6993 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
6994 there is already a namespace defined with this name.
6996 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
6997 people upgraded their corlibs.
6999 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
7000 always use fully qualified types, no need to use the compiler
7003 (TypeManager.IsNamespace): Use binarysearch.
7005 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
7006 AddDelegate): I did not quite use the new IsValid API properly: I
7007 have to pass the short-name and the fullname. I was passing only
7008 the basename instead of the fullname sometimes.
7010 (TypeContainer.DefineType): call NamespaceClash.
7012 * interface.cs (Interface.DefineType): use NamespaceClash before
7015 * delegate.cs (Delegate.DefineType): use NamespaceClash before
7018 * enum.cs: (Enum.DefineType): use NamespaceClash before
7021 * typemanager.cs (: 3-line patch that gives us some tasty 11%
7022 speed increase. First, use the negative_hits cache when we get a
7023 negative. Second, add the type with its full original name
7024 instead of the new . and + encoded name (reflection uses + to
7025 separate type from a nested type). Use LookupTypeReflection
7026 directly which bypasses the type->name hashtable (that we already
7027 know does not contain the type.
7029 * decl.cs (DeclSpace.ResolveTypeExpr): track the
7030 location/container type.
7032 * driver.cs: When passing utf8, use directly the UTF8Encoding.
7034 2003-04-19 Miguel de Icaza <miguel@ximian.com>
7036 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
7038 * delegate.cs (NewDelegate.Resolve): Test whether an instance
7039 method is being referenced in the method group from a static
7040 context, and report error 120 if so.
7042 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
7045 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
7046 is created, we create the A namespace).
7048 * cs-parser.jay: A namespace also introduces a DeclarationFound.
7051 2003-04-18 Miguel de Icaza <miguel@ximian.com>
7053 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
7054 invocation to ModuleBuilder.GetType with the same values will
7055 return a new type instance, so we need to cache its return
7058 * expression.cs (Binary.ResolveOperator): Only allow the compare
7059 operators on enums if they are of the same type.
7061 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
7062 types of ValueType on their own case. Before we were giving them
7063 the same treatment as objects.
7065 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
7066 fullname. Short name is used to compare against container name.
7067 Fullname is used to check against defined namespace names.
7069 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
7070 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
7072 (Method.CheckBase): Call parent.
7073 (MemberBase.CheckBase): Check for protected members on sealed
7075 (PropertyBase.CheckBase): Call parent.
7076 (Field.Define): Call parent.
7078 * report.cs: Negative error codes are now mapped to 8000 - code,
7079 so that the display is render more nicely.
7081 * typemanager.cs: Do not use try/catch, instead report a regular
7084 (GetPointerType, GetReferenceType): These methods provide
7085 mechanisms to obtain the T* and T& from a T. We had the code
7086 previously scattered around the code base, and it also used
7087 TypeManager.LookupType that would go through plenty of caches.
7088 This one goes directly to the type source.
7090 In some places we did the Type.GetType followed by
7091 ModuleBuilder.GetType, but not in others, so this unifies the
7094 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
7095 statements now that we have namespace information.
7097 * typemanager.cs (IsNamespace): New method, returns whether the
7098 string presented is a namespace or not.
7100 (ComputeNamespaces): New public entry point, computes the list of
7101 available namespaces, using the GetNamespaces API call in Mono, or
7102 the slower version in MS.NET.
7104 Now before we start the semantic analysis phase, we have a
7105 complete list of namespaces including everything that the user has
7108 Deleted old code to cache namespaces in .nsc files.
7110 2003-04-17 Miguel de Icaza <miguel@ximian.com>
7112 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
7113 class/struct location definition Location for the implicit
7114 constructor location.
7116 (Operator.Define): Use the location of the operator for the
7117 implicit Method definition.
7119 (Constructor.Emit): use the constructor location for the implicit
7120 base initializer constructor.
7122 * ecore.cs: Remove ITypeExpression. This interface is now gone,
7123 and the Expression class now contains two new methods:
7125 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
7126 isolate type lookup from the rest of the resolution process.
7128 Since we use Expressions to hold type definitions due to the way
7129 we parse the input we have historically overloaded Resolve to
7130 perform the Type lookups if a special flag is passed. Now this is
7131 eliminated and two methods take their place.
7133 The differences in the two methods between xStep and xTerminal is
7134 that xStep is involved in our current lookup system that uses
7135 SimpleNames to compose a name, while xTerminal is used just to
7136 catch the case where the simplename lookup failed.
7138 2003-04-16 Miguel de Icaza <miguel@ximian.com>
7140 * expression.cs (ResolveMemberAccess): Remove redundant code.
7141 TypeExpr expressions are always born fully resolved.
7143 * interface.cs (PopulateMethod): Do not lookup the types twice.
7144 We were doing it once during SemanticAnalysis and once during
7147 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
7148 in local variable type definitions, were being returned as a
7149 SimpleName (we decomposed everything into a string), that is
7150 because primary_expression was being used instead of a type in the
7151 grammar (reduce/reduce conflicts).
7153 The part that was wrong is that we converted the expression into a
7154 string (an oversimplification in one hand, compounded with primary
7155 expressions doing string concatenation).
7161 Would return "A.B.C[]" as a SimpleName. This stopped things like
7162 using clauses from working on this particular context. And a type
7163 was being matched directly against "A.B.C[]".
7165 We now use the correct approach, and allow for ComposedCast to be
7166 part of the unary expression. So the "A.B.C []" become a composed
7167 cast of "A.B.C" (as a nested group of MemberAccess with a
7168 SimpleName at the end) plus the rank composition "[]".
7172 2003-04-10 Miguel de Icaza <miguel@ximian.com>
7174 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
7175 for the access level checking.
7177 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
7178 `TypeContainer container', because I kept getting confused when I
7179 was debugging this code.
7181 * expression.cs (Indexers): Instead of tracking getters/setters,
7182 we now track them in parallel. We create one arraylist less, but
7183 most importantly it is possible now for the LValue code to find a
7184 matching get for a set.
7186 (IndexerAccess.DoResolveLValue): Update the code.
7187 GetIndexersForType has been modified already to extract all the
7188 indexers from a type. The code assumed it did not.
7190 Also make the code set the correct return type for the indexer.
7191 This was fixed a long time ago for properties, but was missing for
7192 indexers. It used to be void_type.
7194 (Binary.Emit): Test first for doubles instead of
7195 floats, as they are more common.
7197 (Binary.EmitBranchable): Use the .un version of the branch opcodes
7198 when dealing with floats and the <=, >= operators. This fixes bug
7201 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
7202 to load the array value by emitting a load on the foreach variable
7203 type. This was incorrect.
7205 We now emit the code to load an element using the the array
7206 variable type, and then we emit the conversion operator.
7210 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
7212 * attribute.cs: Avoid allocation of ArrayLists in the common case.
7214 2003-04-09 Miguel de Icaza <miguel@ximian.com>
7216 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
7217 test for protection before we test for signatures.
7219 (MethodSignature.ToString): implement.
7221 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
7222 to the case where we reduced into a LongConstant.
7224 * decl.cs (CheckAccessLevel): If the type is an array, we can not
7225 depend on whether the information is acurrate, because the
7226 Microsoft runtime will always claim that the array type is public,
7227 regardless of the real state.
7229 If the type is a pointer, another problem happens: the type is
7230 reported as non-public in Microsoft.
7232 In both cases we have to call CheckAccessLevel recursively with
7233 the underlying type as the argument to be tested.
7235 2003-04-08 Miguel de Icaza <miguel@ximian.com>
7237 * assign.cs (Assign.Emit): If we are dealing with a compound
7238 assignment expression, we should use the code path that stores the
7239 intermediate result in a temporary value. This fixes #40903.
7241 *expression.cs (Indirection.ToString): Provide ToString method for
7244 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
7246 * class.cs: Null out fields holding references to Block objects so
7247 they can be garbage collected.
7249 * expression.cs (OverloadResolve): Remove unused local.
7251 2003-04-07 Martin Baulig <martin@ximian.com>
7253 * codegen.cs (EmitContext.CurrentFile): New public field.
7254 (EmitContext.Mark): Use the CurrentFile to check whether the
7255 location is in the correct file.
7256 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
7258 2003-04-07 Martin Baulig <martin@ximian.com>
7260 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
7262 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
7263 location. [FIXME: The location argument which gets passed to this
7264 method is sometimes wrong!]
7266 2003-04-07 Nick Drochak <ndrochak@gol.com>
7268 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
7270 2003-04-07 Miguel de Icaza <miguel@ximian.com>
7272 * expression.cs (Indirection.EmitAssign): We were using the
7273 temporary, but returning immediately instead of continuing the
7276 2003-04-06 Martin Baulig <martin@ximian.com>
7278 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
7279 if it's a nested child, but also deriving from the outer class.
7282 * typemanager.cs (IsNestedChildOf): Make this work if it's a
7283 nested child, but also deriving from the outer class. See
7285 (FilterWithClosure): We may access private members of the outer
7286 class if we're a nested child and deriving from the outer class.
7287 (RealMemberLookup): Only set `closure_private_ok' if the
7288 `original_bf' contained BindingFlags.NonPublic.
7290 2003-04-05 Martin Baulig <martin@ximian.com>
7292 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
7294 2003-04-02 Miguel de Icaza <miguel@ximian.com>
7296 * class.cs (Event.Define): Do not allow abstract events to have
7299 2003-04-01 Miguel de Icaza <miguel@ximian.com>
7301 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
7302 block in event declarations.
7304 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
7305 value type, get its address.
7307 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
7308 leaving a class on the stack instead of a boolean value (int
7309 0/1). Change the code so we compare against null, and then the
7310 result against zero.
7312 * class.cs (TypeContainer.GetClassBases): We were checking for the
7313 parent class being sealed too late.
7315 * expression.cs (Binary.Emit): For <= and >= when dealing with
7316 floating point values, use cgt.un and clt.un instead of cgt and
7319 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7321 * statement.cs: Apply the same optimization as MS: skip the
7322 GetEnumerator returning an IEnumerator, and use the one returning a
7323 CharEnumerator instead. This allows us to avoid the try-finally block
7326 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7328 * cs-parser.jay: Attributes cannot be applied to
7329 namespaces. Fixes #40473
7331 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7334 (Add*): check if the name is valid using the full name for constants,
7335 fields, properties and events.
7337 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7339 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7340 char constants to be part of the enumeration.
7342 * expression.cs (Conditional.DoResolve): Add support for operator
7343 true. Implements the missing functionality from 14.12
7345 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7346 operator true/false as required by the spec.
7348 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7349 implicit conversion to boolean.
7351 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7352 also one where the type implements `operator true'.
7354 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7355 get an expression that will invoke operator true based on an
7358 (GetConversionOperators): Removed the hack that called op_True
7361 (Expression.ResolveBoolean): Move this from Statement.
7363 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7365 * ecore.cs (FieldExpr): do not allow initialization of initonly
7366 fields on derived classes
7368 2003-03-13 Martin Baulig <martin@ximian.com>
7370 * statement.cs (Block.Emit): Call ig.BeginScope() and
7371 ig.EndScope() when compiling with debugging info; call
7372 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7374 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7376 * expression.cs (Indexers): Do not construct immediately, allow
7377 for new members to be appended as we go. Fixes 38143
7379 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7381 * expression.cs: save/restore context when resolving an unchecked
7384 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7386 * cfold.cs: Catch division by zero in modulus operator during
7389 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7391 * interface.cs (Interface.DefineMembers): Avoid defining members
7394 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7396 * driver.cs: handle the +/- options for -noconfig
7398 * statement.cs (Unckeched.Resolve): Also track the state of
7399 unchecked in the Resolve phase.
7401 2003-02-27 Martin Baulig <martin@ximian.com>
7403 * ecore.cs (Expression.MemberLookup): Don't create a
7404 MethodGroupExpr for something which is not a method. Fixes #38291.
7406 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7408 * class.cs (MemberBase.CheckParameters): Also check that the type
7409 is unmanaged if it is a pointer.
7411 * expression.cs (SizeOf.Resolve): Add location information.
7413 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7414 a managed type is declared.
7416 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7417 parameter modifiers as well. Fixes bug 38606
7419 * class.cs: Very sad. Am backing out the speed up changes
7420 introduced by the ArrayList -> Array in the TypeContainer, as they
7421 were not actually that much faster, and introduced a bug (no error
7422 reports on duplicated methods).
7424 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7425 source first, this will guarantee that we have a valid expression
7426 before calling in lower levels functions that will require a
7427 resolved object. Then use this original_source in the
7428 target.ResolveLValue instead of the original source that was
7431 Another change. Use target.Resolve instead of LValueResolve.
7432 Although we are resolving for LValues, we will let the Assign code
7433 take care of that (it will be called again from Resolve). This
7434 basically allows code like this:
7436 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7437 class Y { void A (X x) { x [0] += o; }
7439 The problem was that the indexer was trying to resolve for
7440 set_Item (idx, object o) and never finding one. The real set_Item
7441 was set_Item (idx, X). By delaying the process we get the right
7446 2003-02-23 Martin Baulig <martin@ximian.com>
7448 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7449 while calling DoEmit ().
7451 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7452 source files; if you use the #line directive inside a method, the
7453 compiler stops emitting line numbers for the debugger until it
7454 reaches the end of the method or another #line directive which
7455 restores the original file.
7457 2003-02-23 Martin Baulig <martin@ximian.com>
7459 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7461 2003-02-23 Martin Baulig <martin@ximian.com>
7463 * statement.cs (Block.AddChildVariableNames): We need to call this
7464 recursively, not just for our immediate children.
7466 2003-02-23 Martin Baulig <martin@ximian.com>
7468 * class.cs (Event.Define): Always make the field private, like csc does.
7470 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7471 actually work, fixes bug #37521.
7473 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7475 * delegate.cs: When creating the various temporary "Parameters"
7476 classes, make sure that we call the ComputeAndDefineParameterTypes
7477 on those new parameters (just like we do with the formal ones), to
7478 allow them to be resolved in the context of the DeclSpace.
7480 This fixes the bug that Dick observed in Bugzilla #38530.
7482 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7484 * expression.cs (ResolveMemberAccess): When resolving a constant,
7485 do not attempt to pull a constant if the value was not able to
7486 generate a valid constant.
7488 * const.cs (LookupConstantValue): Do not report more errors than required.
7490 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7492 * expression.cs: fixes bug #38328.
7494 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7496 * class.cs: Changed all the various members that can be part of a
7497 class from being an ArrayList to be an Array of the right type.
7498 During the DefineType type_list, interface_list, delegate_list and
7499 enum_list are turned into types, interfaces, delegates and enums
7502 And during the member population, indexer_list, event_list,
7503 constant_list, field_list, instance_constructor_list, method_list,
7504 operator_list and property_list are turned into their real arrays.
7506 Although we could probably perform this operation earlier, for
7507 good error reporting we need to keep the lists and remove the
7508 lists for longer than required.
7510 This optimization was triggered by Paolo profiling the compiler
7511 speed on the output of `gen-sample-program.pl' perl script.
7513 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7514 not crash in methods like MemberLookupFailed that use this field.
7516 This problem arises when the compiler fails to resolve a type
7517 during interface type definition for example.
7519 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7521 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7522 inherit from System.Object, so we have to stop at null, not only
7523 when reaching System.Object.
7525 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7527 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7528 DeclaredOnly because the parent indexer might have had a different
7529 name, but did not loop until the top of the hierarchy was reached.
7531 The problem this one fixes is 35492: when a class implemented an
7532 indexer from an interface, we were getting the interface method
7533 (which was abstract) and we were flagging an error (can not invoke
7536 This also keeps bug 33089 functioning, and test-148 functioning.
7538 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7539 out if a method is special is to see if it is declared in a
7540 property or event, or whether it is one of the predefined operator
7541 names. This should fix correctly #36804.
7543 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7545 The goal here is to remove the dependency on EmptyCast.Peel ().
7546 Killing it completely.
7548 The problem is that currently in a number of places where
7549 constants are expected, we have to "probe" for an EmptyCast, and
7550 Peel, which is not the correct thing to do, as this will be
7551 repetitive and will likely lead to errors.
7553 The idea is to remove any EmptyCasts that are used in casts that
7554 can be reduced to constants, so we only have to cope with
7557 This bug hunt was triggered by Bug 37363 and the desire to remove
7558 the duplicate pattern where we were "peeling" emptycasts to check
7559 whether they were constants. Now constants will always be
7562 * ecore.cs: Use an enumconstant here instead of wrapping with
7565 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7566 throwing me off. By handling this we can get rid of a few hacks.
7568 * statement.cs (Switch): Removed Peel() code.
7570 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7572 * class.cs: Location information for error 508
7574 * expression.cs (New.DoResolve): Add a guard against double
7575 resolution of an expression.
7577 The New DoResolve might be called twice when initializing field
7578 expressions (see EmitFieldInitializers, the call to
7579 GetInitializerExpression will perform a resolve on the expression,
7580 and later the assign will trigger another resolution
7582 This leads to bugs (#37014)
7584 * delegate.cs: The signature for EndInvoke should contain any ref
7585 or out parameters as well. We were not doing this in the past.
7587 * class.cs (Field.Define): Do not overwrite the type definition
7588 inside the `volatile' group. Turns out that volatile enumerations
7589 were changing the type here to perform a validity test, which
7592 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7594 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7595 and structs, we do not want to load the instance variable
7597 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7598 enum_type has to be handled like an object reference (implicit
7599 conversions exists from this to object), but the regular IsClass
7600 and IsValueType tests will never return true for this one.
7602 Also we use TypeManager.IsValueType instead of type.IsValueType,
7603 just for consistency with the rest of the code (this is only
7604 needed if we ever use the construct exposed by test-180.cs inside
7605 corlib, which we dont today).
7607 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7609 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7612 2003-02-09 Martin Baulig <martin@ximian.com>
7614 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7615 (Namespace.DefineNamespaces): New static public method; this is
7616 called when we're compiling with debugging to add all namespaces
7619 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7620 pass it to the Namespace's .ctor.
7622 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7623 and MethodBase arguments; pass the namespace ID to the symwriter;
7624 pass the MethodBase instead of the token to the symwriter.
7625 (SymbolWriter.DefineNamespace): New method to add a namespace to
7628 2003-02-09 Martin Baulig <martin@ximian.com>
7630 * symbolwriter.cs: New file. This is a wrapper around
7631 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7632 methods here in near future.
7634 2003-02-09 Martin Baulig <martin@ximian.com>
7636 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7637 ILGenerator.MarkSequencePoint() which are actually used by the
7640 2003-02-09 Martin Baulig <martin@ximian.com>
7642 * location.cs (SourceFile): New public sealed class. This
7643 contains the name and an index which is used in the location's token.
7644 (Location): Reserve an appropriate number of bits in the token for
7645 the source file instead of walking over that list, this gives us a
7646 really huge performance improvement when compiling with debugging.
7648 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7649 `SourceFile' argument instead of a string.
7650 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7651 but don't parse/tokenize here, we need to generate the list of all
7652 source files before we do that.
7653 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7656 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7657 instead of a string.
7659 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
7662 2003-02-09 Martin Baulig <martin@ximian.com>
7664 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
7665 filename on `#line default'.
7667 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
7669 * statement.cs: don't clear the pinned var when the fixed statement
7670 returns from the method (fixes bug#37752).
7672 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
7674 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
7677 2003-02-07 Martin Baulig <martin@ximian.com>
7679 * driver.cs: Removed the `--debug-args' command line argument.
7681 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
7682 automatically by the AsssemblyBuilder.
7683 (CodeGen.InitializeSymbolWriter): We don't need to call any
7684 initialization function on the symbol writer anymore. This method
7685 doesn't take any arguments.
7687 2003-02-03 Miguel de Icaza <miguel@ximian.com>
7689 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
7690 from referenced assemblies as well.
7692 2003-02-02 Martin Baulig <martin@ximian.com>
7694 * class.cs (MethodData.Emit): Generate debugging info for external methods.
7696 2003-02-02 Martin Baulig <martin@ximian.com>
7698 * class.cs (Constructor.Emit): Open the symbol writer before
7699 emitting the constructor initializer.
7700 (ConstructorInitializer.Emit): Call ec.Mark() to allow
7701 single-stepping through constructor initializers.
7703 2003-01-30 Miguel de Icaza <miguel@ximian.com>
7705 * class.cs: Handle error 549: do not allow virtual methods in
7708 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
7710 * decl.cs: Check access levels when resolving types
7712 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
7714 * statement.cs: Add parameters and locals set in catch blocks that might
7715 return to set vector
7717 2003-01-29 Miguel de Icaza <miguel@ximian.com>
7719 * class.cs (Operator): Set the SpecialName flags for operators.
7721 * expression.cs (Invocation.DoResolve): Only block calls to
7722 accessors and operators on SpecialName methods.
7724 (Cast.TryReduce): Handle conversions from char constants.
7727 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
7729 * statement.cs: small memory and time optimization in FlowBranching.
7731 2003-01-28 Pedro Mart <yoros@wanadoo.es>
7733 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
7734 problem that the last fix but in the other sid (Set).
7736 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
7737 access when there is no indexer in the hierarchy.
7739 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
7741 * class.cs: Combine some if statements.
7743 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7745 * driver.cs: fixed bug #37187.
7747 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
7749 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
7750 any indexer, it's needed to build a list with all the indexers in the
7751 hierarchy (AllGetters), else we have problems. Fixes #35653.
7753 2003-01-23 Miguel de Icaza <miguel@ximian.com>
7755 * class.cs (MethodData.Define): It is wrong for an interface
7756 implementation to be static in both cases: explicit and implicit.
7757 We were only handling this in one case.
7759 Improve the if situation there to not have negations.
7761 * class.cs (Field.Define): Turns out that we do not need to check
7762 the unsafe bit on field definition, only on usage. Remove the test.
7764 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7766 * driver.cs: use assembly.Location instead of Codebase (the latest
7767 patch made mcs fail when using MS assemblies).
7769 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
7771 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
7772 get the path to *corlib.dll.
7774 2003-01-21 Nick Drochak <ndrochak@gol.com>
7778 * typemanager.cs: Remove compiler warnings
7780 2003-01-20 Duncan Mak <duncan@ximian.com>
7782 * AssemblyInfo.cs: Bump the version number to 0.19.
7784 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7786 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
7788 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
7790 * class.cs (Constructor::Emit): Emit debugging info for constructors.
7792 2003-01-17 Miguel de Icaza <miguel@ximian.com>
7794 * cs-parser.jay: Small fix: we were not comparing the constructor
7795 name correctly. Thanks to Zoltan for the initial pointer.
7797 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
7799 * cs-tokenizer.cs: Set file name when specified with #line
7801 2003-01-15 Miguel de Icaza <miguel@ximian.com>
7803 * cs-parser.jay: Only perform the constructor checks here if we
7804 are named like the class; This will help provider a better
7805 error. The constructor path is taken when a type definition is
7806 not found, but most likely the user forgot to add the type, so
7807 report that rather than the constructor error.
7809 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
7811 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
7814 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7816 * cs-parser.jay: Add cleanup call.
7818 2003-01-13 Duncan Mak <duncan@ximian.com>
7820 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
7821 consistent with other methods.
7823 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7825 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
7827 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
7829 * attribute.cs: only set GuidAttr to true when we have a
7832 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7836 * typemanager.cs: fixes to allow mcs compile corlib with the new
7837 Type.IsSubclassOf fix.
7839 2003-01-08 Miguel de Icaza <miguel@ximian.com>
7841 * expression.cs (LocalVariableReference.DoResolve): Classify a
7842 constant as a value, not as a variable. Also, set the type for
7845 * cs-parser.jay (fixed_statement): take a type instead of a
7846 pointer_type, so we can produce a better error message later.
7848 * statement.cs (Fixed.Resolve): Flag types that are not pointers
7851 (For.DoEmit): Make inifinite loops have a
7852 non-conditional branch back.
7854 (Fixed.DoEmit): First populate the pinned variables, then emit the
7855 statement, then clear the variables. Before I was emitting the
7856 code once for each fixed piece.
7859 2003-01-08 Martin Baulig <martin@ximian.com>
7861 * statement.cs (FlowBranching.MergeChild): A break in a
7862 SWITCH_SECTION does not leave a loop. Fixes #36155.
7864 2003-01-08 Martin Baulig <martin@ximian.com>
7866 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
7867 lives in the same number space than `param_map'. Fixes #36154.
7869 2003-01-07 Miguel de Icaza <miguel@ximian.com>
7871 * cs-parser.jay (constructor_declaration): Set the
7872 Constructor.ModFlags before probing for it. This makes the
7873 compiler report 514, 515 and 132 (the code was there, but got
7876 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
7877 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
7878 (GotoCase.Resolve): Set `Returns' to ALWAYS.
7880 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
7882 * enum.cs: create the enum static fields using the enum type.
7884 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
7886 * class.cs: don't try to create the ParamBuilder for the return
7887 type if it's not needed (and handle it breaking for the ms runtime
7890 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
7892 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
7894 2002-12-29 Miguel de Icaza <miguel@ximian.com>
7896 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
7897 the command. This showed up while compiling the JANET source
7898 code, which used \r as its only newline separator.
7900 2002-12-28 Miguel de Icaza <miguel@ximian.com>
7902 * class.cs (Method.Define): If we are an operator (because it
7903 reuses our code), then set the SpecialName and HideBySig. #36128
7905 2002-12-22 Miguel de Icaza <miguel@ximian.com>
7907 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
7908 exception, report error 120 `object reference required'.
7910 * driver.cs: Add --pause option, used during to measure the size
7911 of the process as it goes with --timestamp.
7913 * expression.cs (Invocation.DoResolve): Do not allow methods with
7914 SpecialName to be invoked.
7916 2002-12-21 Miguel de Icaza <miguel@ximian.com>
7918 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
7919 number before adding it.
7921 2002-12-21 Ravi Pratap <ravi@ximian.com>
7923 * ecore.cs (StandardImplicitConversion): When in an unsafe
7924 context, we allow conversion between void * to any other pointer
7925 type. This fixes bug #35973.
7927 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
7929 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
7930 is not thrown when extensionless outputs are used
7932 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7934 * rootcontext.cs: fixed compilation of corlib.
7936 2002-12-19 Miguel de Icaza <miguel@ximian.com>
7938 * attribute.cs (Attributes.Contains): Add new method.
7940 * class.cs (MethodCore.LabelParameters): if the parameter is an
7941 `out' parameter, check that no attribute `[In]' has been passed.
7943 * enum.cs: Handle the `value__' name in an enumeration.
7945 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
7947 * decl.cs: Added special case to allow overrides on "protected
7950 2002-12-18 Ravi Pratap <ravi@ximian.com>
7952 * attribute.cs (Attributes.AddAttributeSection): Rename to this
7953 since it makes much more sense.
7955 (Attributes.ctor): Don't require a Location parameter.
7957 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
7959 * attribute.cs (ApplyAttributes): Remove extra Location parameters
7960 since we already have that information per attribute.
7962 * everywhere : make appropriate changes.
7964 * class.cs (LabelParameters): Write the code which actually
7965 applies attributes to the return type. We can't do this on the MS
7966 .NET runtime so we flag a warning in the case an exception is
7969 2002-12-18 Miguel de Icaza <miguel@ximian.com>
7971 * const.cs: Handle implicit null conversions here too.
7973 2002-12-17 Ravi Pratap <ravi@ximian.com>
7975 * class.cs (MethodCore.LabelParameters): Remove the extra
7976 Type [] parameter since it is completely unnecessary. Instead
7977 pass in the method's attributes so that we can extract
7978 the "return" attribute.
7980 2002-12-17 Miguel de Icaza <miguel@ximian.com>
7982 * cs-parser.jay (parse): Use Report.Error to flag errors instead
7983 of ignoring it and letting the compile continue.
7985 * typemanager.cs (ChangeType): use an extra argument to return an
7986 error condition instead of throwing an exception.
7988 2002-12-15 Miguel de Icaza <miguel@ximian.com>
7990 * expression.cs (Unary.TryReduce): mimic the code for the regular
7991 code path. Perform an implicit cast in the cases where we can
7992 implicitly convert to one of the integral types, and then reduce
7993 based on that constant. This fixes bug #35483.
7995 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7997 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
7999 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8001 * namespace.cs: fixed bug #35489.
8003 2002-12-12 Miguel de Icaza <miguel@ximian.com>
8005 * class.cs: Remove some dead code.
8007 * cs-parser.jay: Estimate the number of methods needed
8008 (RootContext.MethodCount);
8010 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
8011 numbers instead of StringBuilders.
8013 * support.cs (PtrHashtable): Add constructor with initial size;
8014 We can now reduce reallocations of the method table.
8016 2002-12-10 Ravi Pratap <ravi@ximian.com>
8018 * attribute.cs (ApplyAttributes): Keep track of the emitted
8019 attributes on a per-target basis. This fixes bug #35413.
8021 2002-12-10 Miguel de Icaza <miguel@ximian.com>
8023 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
8024 default to the Windows 1252 encoding.
8026 (UnixParseOption): Support version, thanks to Alp for the missing
8029 * AssemblyInfo.cs: Add nice assembly information.
8031 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
8034 * cs-parser.jay: Allow a trailing comma before the close bracked
8035 in the attribute_section production.
8037 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
8038 address of the instance was being taken, I will take this out,
8039 because we take the address of the object immediately here.
8041 2002-12-09 Ravi Pratap <ravi@ximian.com>
8043 * typemanager.cs (AreMultipleAllowed): Take care of the most
8044 obvious case where attribute type is not in the current assembly -
8047 2002-12-08 Miguel de Icaza <miguel@ximian.com>
8049 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
8050 definitions, instead of doing that afterwards.
8052 Also we use a nice little hack, depending on the constructor, we
8053 know if we are a "composed" name or a simple name. Hence, we
8054 avoid the IndexOf test, and we avoid
8056 * codegen.cs: Add code to assist in a bug reporter to track down
8057 the source of a compiler crash.
8059 2002-12-07 Ravi Pratap <ravi@ximian.com>
8061 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
8062 types have been emitted for a given element and flag an error
8063 if something which does not have AllowMultiple set is used more
8066 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
8067 attribute types and their corresponding AllowMultiple properties
8069 (AreMultipleAllowed): Check the property for a given type.
8071 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
8072 property in the case we have a TypeContainer.
8074 (Attributes.AddAttribute): Detect duplicates and just skip on
8075 adding them. This trivial fix catches a pretty gross error in our
8076 attribute emission - global attributes were being emitted twice!
8078 Bugzilla bug #33187 is now fixed.
8080 2002-12-06 Miguel de Icaza <miguel@ximian.com>
8082 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
8085 * expression.cs (Binary.ResolveOperator): I can only use the
8086 Concat (string, string, string) and Concat (string, string,
8087 string, string) if the child is actually a concatenation of
8090 2002-12-04 Miguel de Icaza <miguel@ximian.com>
8092 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
8093 context where we need a 2-character lookahead.
8095 * pending.cs (PendingImplementation): Rework so we can keep track
8096 of interface types all the time, and flag those which were
8097 implemented by parents as optional.
8099 2002-12-03 Miguel de Icaza <miguel@ximian.com>
8101 * expression.cs (Binary.ResolveOperator): Use
8102 String.Concat(string,string,string) or
8103 String.Concat(string,string,string,string) when possible.
8105 * typemanager: More helper methods.
8108 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
8110 * pending.cs: remove the bogus return from GetMissingInterfaces()
8111 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
8113 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8115 * namespace.cs: avoid duplicated 'using xxx' being added to
8116 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
8117 when we get more than one 'using' statement for the same namespace.
8118 Report a CS0105 warning for it.
8120 2002-11-30 Miguel de Icaza <miguel@ximian.com>
8122 * cs-tokenizer.cs (consume_identifier): use read directly, instead
8123 of calling getChar/putback, uses internal knowledge of it.
8125 (xtoken): Reorder tokenizer so most common patterns are checked
8126 first. This reduces the compilation time in another 5% (from 8.11s
8127 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
8129 The parsing time is 22% of the compilation in mcs, and from that
8130 64% is spent on the tokenization process.
8132 I tried using a binary search for keywords, but this is slower
8133 than the hashtable. Another option would be to do a couple of
8136 * Not use a StringBuilder, instead use an array of chars,
8137 with a set value. Notice that this way we could catch
8138 the 645 error without having to do it *afterwards*.
8140 * We could write a hand-parser to avoid the hashtable
8141 compares altogether.
8143 The identifier consumption process takes 37% of the tokenization
8144 time. Another 15% is spent on is_number. 56% of the time spent
8145 on is_number is spent on Int64.Parse:
8147 * We could probably choose based on the string length to
8148 use Int32.Parse or Int64.Parse and avoid all the 64-bit
8151 Another 3% is spend on wrapping `xtoken' in the `token' function.
8153 Handle 0xa0 as whitespace (#34752)
8155 2002-11-26 Miguel de Icaza <miguel@ximian.com>
8157 * typemanager.cs (IsCLRType): New routine to tell whether a type
8158 is one of the builtin types.
8160 Maybe it needs to use TypeCodes to be faster. Maybe we could use
8161 typecode in more places instead of doing pointer comparissions.
8162 We could leverage some knowledge about the way the typecodes are
8165 New code to cache namespaces in assemblies, it is currently not
8166 invoked, to be used soon.
8168 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
8170 * expression.cs (Binary.ResolveOperator): specially handle
8171 strings, and do not perform user-defined operator overloading for
8174 2002-11-24 Miguel de Icaza <miguel@ximian.com>
8176 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
8177 internalcall as it is a pretty simple operation; Avoid whenever
8178 possible to call Char.IsLetter.
8180 (consume_identifier): Cut by half the number of
8181 hashtable calls by merging the is_keyword and GetKeyword behavior.
8183 Do not short-circuit, because if we do, we
8184 report errors (ie, #if false && true would produce an invalid
8188 2002-11-24 Martin Baulig <martin@ximian.com>
8190 * expression.cs (Cast.TryReduce): If we're in checked syntax,
8191 check constant ranges and report a CS0221. Fixes #33186.
8193 2002-11-24 Martin Baulig <martin@ximian.com>
8195 * cs-parser.jay: Make this work for uninitialized variable
8196 declarations in the `for' initializer. Fixes #32416.
8198 2002-11-24 Martin Baulig <martin@ximian.com>
8200 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
8201 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
8203 2002-11-24 Martin Baulig <martin@ximian.com>
8205 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
8206 argument; if true, we also check for user-defined conversions.
8207 This is only needed if both arguments are of a user-defined type.
8208 Fixes #30443, added test-175.cs.
8209 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
8211 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
8213 2002-11-24 Martin Baulig <martin@ximian.com>
8215 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
8216 function to get the store opcode.
8217 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
8218 only emit the Ldelema if the store opcode is Stobj. You must run
8219 both test-34 and test-167 to test this. Fixes #34529.
8221 2002-11-23 Martin Baulig <martin@ximian.com>
8223 * ecore.cs (Expression.MemberLookup): Added additional
8224 `qualifier_type' argument which is used when we're being called
8225 from MemberAccess.DoResolve() and null if we're called from a
8227 (Expression.MemberLookupFailed): New method to report errors; this
8228 does the CS1540 check and reports the correct error message.
8230 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
8231 argument for the CS1540 check and redone the way how we're dealing
8232 with private members. See the comment in the source code for details.
8233 (FilterWithClosure): Reverted this back to revision 1.197; renamed
8234 `closure_start_type' to `closure_qualifier_type' and check whether
8235 it's not null. It was not this filter being broken, it was just
8236 being called with the wrong arguments.
8238 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
8239 and pass it the correct `qualifier_type'; this also does the error
8242 2002-11-22 Miguel de Icaza <miguel@ximian.com>
8244 * expression.cs (Invocation.EmitParams): If the we are dealing
8245 with a non-built-in value type, load its address as well.
8247 (ArrayCreation): Use a a pretty constant instead
8248 of the hardcoded value 2. Use 6 instead of 2 for the number of
8249 static initializers.
8251 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
8252 because they are not really value types, just glorified integers.
8254 * driver.cs: Do not append .exe, the CSC compiler does not do it.
8256 * ecore.cs: Remove redundant code for enumerations, make them use
8257 the same code path as everything else, fixes the casting issue
8258 with enumerations in Windows.Forms.
8260 * attribute.cs: Do only cast to string if it is a string, the
8261 validation happens later.
8263 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
8264 people upgrade their corlibs.
8266 * ecore.cs: Oops, enumerations were not following the entire code path
8268 2002-11-21 Miguel de Icaza <miguel@ximian.com>
8270 * typemanager.cs (FilterWithClosure): Commented out the test for
8271 1540 in typemanager.cs, as it has problems when accessing
8272 protected methods from a parent class (see test-174.cs).
8274 * attribute.cs (Attribute.ValidateGuid): new method.
8275 (Attribute.Resolve): Use above.
8277 2002-11-19 Miguel de Icaza <miguel@ximian.com>
8279 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
8281 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
8282 handling for enumerations, as we only needed the TypeContainer
8283 functionality to begin with (this is required for the fix below to
8284 work for enums that reference constants in a container class for
8287 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
8289 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
8290 a valid TypeBuilder to perform lookups on.o
8292 * class.cs (InheritableMemberSignatureCompare): Use true in the
8293 call to GetGetMethod and GetSetMethod, because we are comparing
8294 the signature, and we need to get the methods *even* if they are
8297 (PropertyBase.CheckBase): ditto.
8299 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
8300 GotoCase.Resolve): Use Peel on EmpytCasts.
8302 * ecore.cs (EmptyCast): drop child, add Peel method.
8304 2002-11-17 Martin Baulig <martin@ximian.com>
8306 * ecore.cs (EmptyCast.Child): New public property.
8308 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
8309 label resolved to an EmptyCast. Fixes #34162.
8310 (GotoCase.Resolve): Likewise.
8311 (Block.EmitMeta): Likewise.
8313 2002-11-17 Martin Baulig <martin@ximian.com>
8315 * expression.cs (Invocation.BetterConversion): Prefer int over
8316 uint; short over ushort; long over ulong for integer literals.
8317 Use ImplicitConversionExists instead of StandardConversionExists
8318 since we also need to check for user-defined implicit conversions.
8319 Fixes #34165. Added test-173.cs.
8321 2002-11-16 Martin Baulig <martin@ximian.com>
8323 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8324 with the `true' and `false' literals. Fixes #33151.
8326 2002-11-16 Martin Baulig <martin@ximian.com>
8328 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8329 October 22nd; don't do the cs1540 check for static members.
8331 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8332 now using our own filter here and doing the cs1540 check again.
8334 2002-11-16 Martin Baulig <martin@ximian.com>
8336 * support.cs (InternalParameters): Don't crash if we don't have
8337 any fixed parameters. Fixes #33532.
8339 2002-11-16 Martin Baulig <martin@ximian.com>
8341 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8342 when looking up static methods to make this work on Windows.
8345 2002-11-16 Martin Baulig <martin@ximian.com>
8347 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8348 a setter rather than using PropertyInfo.CanWrite.
8350 2002-11-15 Nick Drochak <ndrochak@gol.com>
8352 * class.cs: Allow acces to block member by subclasses. Fixes build
8355 2002-11-14 Martin Baulig <martin@ximian.com>
8357 * class.cs (Constructor.Emit): Added the extern/block check.
8360 2002-11-14 Martin Baulig <martin@ximian.com>
8362 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8363 iteration while looking for indexers, this is needed because the
8364 indexer may have a different name in our base classes. Fixed the
8365 error reporting (no indexers at all, not get accessor, no
8366 overloaded match). Fixes bug #33089.
8367 (IndexerAccess.DoResolveLValue): Likewise.
8369 2002-11-14 Martin Baulig <martin@ximian.com>
8371 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8372 indexers. Fixes the first part of bug #33089.
8373 (MethodSignature.InheritableMemberSignatureCompare): Added support
8376 2002-11-13 Ravi Pratap <ravi@ximian.com>
8378 * attribute.cs (Attribute.Resolve): Catch the
8379 NullReferenceException and report it since it isn't supposed to
8382 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8384 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8385 LogicalOr and LogicalAnd that can benefit from recursively
8386 handling EmitBranchable. The code now should be nice for Paolo.
8388 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8390 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8391 the Type lookups, as we perform quite a number of lookups on
8392 non-Types. This can be removed once we can deterministically tell
8393 whether we have a type or a namespace in advance.
8395 But this might require special hacks from our corlib.
8399 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8400 and double which avoids a conversion from an integer to a double.
8402 * expression.cs: tiny optimization, avoid calling IsConstant,
8403 because it effectively performs the lookup twice.
8405 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8407 But a bogus return here to keep the semantics of the old code
8408 until the Mono runtime is fixed.
8410 * pending.cs (GetMissingInterfaces): New method used to remove all
8411 the interfaces that are already implemented by our parent
8412 classes from the list of pending methods.
8414 * interface.cs: Add checks for calls after ResolveTypeExpr.
8416 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8418 * class.cs (Class.Emit): Report warning 67: event not used if the
8419 warning level is beyond 3.
8421 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8422 being a NullLiteral.
8424 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8427 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8428 path that might fail if a type can not be resolved.
8430 * expression.cs (Binary.Emit): Emit unsigned versions of the
8433 * driver.cs: use error 5.
8435 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8437 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8439 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8441 * cs-parser.jay (switch_section): A beautiful patch from Martin
8442 Baulig that fixed 33094.
8444 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8446 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8447 Check whether the base is abstract and report an error if so.
8449 * expression.cs (IndexerAccess.DoResolveLValue,
8450 IndexerAccess.DoResolve): ditto.
8452 (Invocation.DoResolve): ditto.
8454 (Invocation.FullMethodDesc): Improve the report string.
8456 * statement.cs (Block): Eliminate IsVariableDefined as it is
8457 basically just a wrapper for GetVariableInfo.
8459 * ecore.cs (SimpleName): Use new
8461 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8462 type, as we return the actual parameter ref/unref state on a
8465 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8467 * support.cs: Return proper flags REF/OUT fixing the previous
8470 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8471 not used to mean `ref' but `ref or out' in ParameterReference
8473 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8474 full type signature instead of calling TypeManger.CSharpName
8477 * support.cs (InternalParameters.ParameterDesc): Do not compare
8478 directly to the modflags, because REF/OUT will actually be bitsets
8481 * delegate.cs (VerifyMethod): Check also the modifiers.
8483 * cs-tokenizer.cs: Fix bug where floating point values with an
8484 exponent where a sign was missing was ignored.
8486 * driver.cs: Allow multiple assemblies to be specified in a single
8489 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8491 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8492 because identifiers after a parenthesis would end up in this kind
8493 of production, and we needed to desamiguate it for having casts
8496 (UserDefinedType *) xxx
8498 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8500 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8501 we should set on the Bindingflags.NonPublic, but not turn on
8502 private_ok. private_ok controls whether a Private member is
8503 returned (this is chekced on the filter routine), while the
8504 BindingFlags.NonPublic just controls whether private/protected
8505 will be allowed. This fixes the problem part of the problem of
8506 private properties being allowed to be used in derived classes.
8508 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8509 so we can call the children DoResolveLValue method (this will
8510 properly signal errors on lvalue assignments to base properties)
8512 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8513 getter are null, and we have a property info, we know that this
8514 happened because the lookup failed, so we report an error 122 for
8515 protection level violation.
8517 We also silently return if setter and getter are null in the
8518 resolve functions, this condition only happens if we have flagged
8519 the error before. This is the other half of the problem.
8521 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8522 not have accessibility information, that is why we were returning
8523 true in the filter function in typemanager.cs.
8525 To properly report 122 (property is inaccessible because of its
8526 protection level) correctly, we report this error in ResolveAccess
8527 by failing if both the setter and the getter are lacking (ie, the
8530 DoResolve and DoLResolve have been modified to check for both
8531 setter/getter being null and returning silently, the reason being
8532 that I did not want to put the knowledge about this error in upper
8535 int old = Report.Errors;
8536 x = new PropertyExpr (...);
8537 if (old != Report.Errors)
8542 So the property expr is returned, but it is invalid, so the error
8543 will be flagged during the resolve process.
8545 * class.cs: Remove InheritablePropertySignatureCompare from the
8546 class, as we no longer depend on the property signature to compute
8547 whether it is possible to implement a method or not.
8549 The reason is that calling PropertyInfo.GetGetMethod will return
8550 null (in .NET, in Mono it works, and we should change this), in
8551 cases where the Get Method does not exist in that particular
8556 class X { public virtual int A { get { return 1; } } }
8558 class Z : Y { public override int A { get { return 2; } } }
8560 Would fail in Z because the parent (Y) would not have the property
8561 defined. So we avoid this completely now (because the alternative
8562 fix was ugly and slow), and we now depend exclusively on the
8565 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8566 reference method, instead of using the property.
8568 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8569 routines are gone now.
8571 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8572 names, they were incorrectly named.
8574 * cs-tokenizer.cs: Return are more gentle token on failure.
8576 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8577 had an out-of-sync index variable, which caused it to remove from
8578 the list of pending methods the wrong method sometimes.
8580 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8582 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8583 CanWrite, because those refer to this particular instance of the
8584 property, and do not take into account the fact that we can
8585 override single members of a property.
8587 Constructor requires an EmitContext. The resolution process does
8588 not happen here, but we need to compute the accessors before,
8589 because the resolution does not always happen for properties.
8591 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8592 subclass, before we did not update this flag, but we did update
8595 (GetAccessors): Drop this routine, as it did not work in the
8596 presence of partially overwritten set/get methods.
8598 Notice that this broke the cs1540 detection, but that will require
8601 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8605 * driver.cs: issue a warning instead of an error if we don't support
8606 debugging for the platform. Also ignore a couple of errors that may
8607 arise when trying to write the symbols. Undo my previous patch.
8609 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8611 * driver.cs: ignore /debug switch except for Unix platforms.
8613 2002-10-23 Nick Drochak <ndrochak@gol.com>
8615 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8617 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8619 * driver.cs: Do not make mcs-debug conditional, so we do not break
8622 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8623 review this patch. But basically after all the children variables
8624 have been merged, the value of "Breaks" was not being set to
8625 new_breaks for Switch blocks. I think that it should be set after
8626 it has executed. Currently I set this to the value of new_breaks,
8627 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8628 conservative, but I do not understand this code very well.
8630 I did not break anything in the build, so that is good ;-)
8632 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8634 2002-10-20 Mark Crichton <crichton@gimp.org>
8636 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8638 2002-10-20 Nick Drochak <ndrochak@gol.com>
8640 * cfold.cs: Fixed compile blocker.
8642 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8644 * driver.cs: I was chekcing the key, not the file.
8646 2002-10-19 Ravi Pratap <ravi@ximian.com>
8648 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8649 message that we were generating - we just need to silently return
8652 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8654 * class.cs (Event.Define): Change my previous commit, as this
8655 breaks the debugger. This is a temporary hack, as it seems like
8656 the compiler is generating events incorrectly to begin with.
8658 * expression.cs (Binary.ResolveOperator): Added support for
8659 "U operator - (E x, E y)"
8661 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
8664 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
8665 init-only variables, but this path did not take into account that
8666 there might be also instance readonly variables. Correct this
8669 This fixes bug 32253
8671 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
8674 * driver.cs: Change the extension for modules to `netmodule'
8676 * cs-parser.jay: Improved slightly the location tracking for
8677 the debugger symbols.
8679 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
8680 modifiers that were specified instead of the hardcoded value
8681 (FamAndAssem). This was basically ignoring the static modifier,
8682 and others. Fixes 32429.
8684 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
8685 fixed a bug in the process (32476)
8687 * expression.cs (ArrayAccess.EmitAssign): Patch from
8688 hwang_rob@yahoo.ca that fixes bug 31834.3
8690 2002-10-18 Miguel de Icaza <miguel@ximian.com>
8692 * driver.cs: Make the module extension .netmodule.
8694 2002-10-16 Miguel de Icaza <miguel@ximian.com>
8696 * driver.cs: Report an error if the resource file is not found
8697 instead of crashing.
8699 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
8700 false, like Emit does.
8702 2002-10-16 Nick Drochak <ndrochak@gol.com>
8704 * typemanager.cs: Remove unused private member. Also reported mcs
8705 bug to report this as a warning like csc.
8707 2002-10-15 Martin Baulig <martin@gnome.org>
8709 * statement.cs (Statement.Emit): Made this a virtual method; emits
8710 the line number info and calls DoEmit().
8711 (Statement.DoEmit): New protected abstract method, formerly knows
8712 as Statement.Emit().
8714 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
8716 2002-10-11 Miguel de Icaza <miguel@ximian.com>
8718 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
8719 have fixed a remaining problem: not every AddXXXX was adding a
8720 fully qualified name.
8722 Now everyone registers a fully qualified name in the DeclSpace as
8723 being defined instead of the partial name.
8725 Downsides: we are slower than we need to be due to the excess
8726 copies and the names being registered this way.
8728 The reason for this is that we currently depend (on the corlib
8729 bootstrap for instance) that types are fully qualified, because
8730 we dump all the types in the namespace, and we should really have
8731 types inserted into the proper namespace, so we can only store the
8732 basenames in the defined_names array.
8734 2002-10-10 Martin Baulig <martin@gnome.org>
8736 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
8737 from bug #31834, see the bug report for a testcase which is
8740 2002-10-10 Martin Baulig <martin@gnome.org>
8742 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
8743 flow analysis code for this.
8745 * statement.cs (Do, While, For): Tell the flow analysis code about
8747 (FlowBranching.UsageVector): Added support for infinite loops.
8748 (Block.Resolve): Moved the dead code elimination here and use flow
8751 2002-10-09 Miguel de Icaza <miguel@ximian.com>
8753 * class.cs (Field.Define): Catch cycles on struct type
8756 * typemanager.cs (IsUnmanagedtype): Do not recursively check
8757 fields if the fields are static. We only need to check instance
8760 * expression.cs (As.DoResolve): Test for reference type.
8762 * statement.cs (Using.ResolveExpression): Use
8763 ConvertImplicitRequired, not ConvertImplicit which reports an
8765 (Using.ResolveLocalVariableDecls): ditto.
8767 * expression.cs (Binary.ResolveOperator): Report errors in a few
8768 places where we had to.
8770 * typemanager.cs (IsUnmanagedtype): Finish implementation.
8772 2002-10-08 Miguel de Icaza <miguel@ximian.com>
8774 * expression.cs: Use StoreFromPtr instead of extracting the type
8775 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
8777 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
8778 an enumeration value to a System.Enum, but System.Enum is not a
8779 value type, but an class type, so we need to box.
8781 (Expression.ConvertExplicit): One codepath could return
8782 errors but not flag them. Fix this. Fixes #31853
8784 * parameter.cs (Resolve): Do not allow void as a parameter type.
8786 2002-10-06 Martin Baulig <martin@gnome.org>
8788 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
8789 if it's a class type and not a struct. Fixes #31815.
8791 2002-10-06 Martin Baulig <martin@gnome.org>
8793 * statement.cs: Reworked the flow analysis code a bit to make it
8794 usable for dead code elimination.
8796 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8798 * cs-parser.jay: allow empty source files. Fixes bug #31781.
8800 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8802 * expression.cs (ComposedCast.DoResolveType): A quick workaround
8803 to fix the test 165, will investigate deeper.
8805 2002-10-04 Martin Baulig <martin@gnome.org>
8807 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
8808 finally blocks actually work.
8809 (Try.Resolve): We don't need to create a sibling for `finally' if
8810 there is no finally block.
8812 2002-10-04 Martin Baulig <martin@gnome.org>
8814 * class.cs (Constructor.Define): The default accessibility for a
8815 non-default constructor is private, not public.
8817 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8819 * class.cs (Constructor): Make AllowedModifiers public, add
8822 * cs-parser.jay: Perform the modifiers test here, as the
8823 constructor for the Constructor class usually receives a zero
8824 because of the way we create it (first we create, later we
8825 customize, and we were never checking the modifiers).
8827 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
8828 is a version of LookupTypeReflection that includes the type-name
8829 cache. This can be used as a fast path for functions that know
8830 the fully qualified name and are only calling into *.GetType() to
8831 obtain a composed type.
8833 This is also used by TypeManager.LookupType during its type
8836 (LookupType): We now also track the real type name, as sometimes
8837 we can get a quey for the real type name from things like
8838 ComposedCast. This fixes bug 31422.
8840 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
8841 complete type fullname, it does not have to go through the type
8842 resolution system to obtain the composed version of the type (for
8843 obtaining arrays or pointers).
8845 (Conditional.Emit): Use the EmitBoolExpression to
8846 generate nicer code, as requested by Paolo.
8848 (ArrayCreation.CheckIndices): Use the patch from
8849 hwang_rob@yahoo.ca to validate the array initializers.
8851 2002-10-03 Miguel de Icaza <miguel@ximian.com>
8853 * class.cs (ConstructorInitializer.Emit): simplify code by using
8854 Invocation.EmitCall, and at the same time, fix the bugs in calling
8855 parent constructors that took variable arguments.
8857 * ecore.cs (Expression.ConvertNumericExplicit,
8858 Expression.ImplicitNumericConversion): Remove the code that
8859 manually wrapped decimal (InternalTypeConstructor call is now gone
8862 * expression.cs (Cast.TryReduce): Also handle decimal types when
8863 trying to perform a constant fold on the type.
8865 * typemanager.cs (IsUnmanagedtype): Partially implemented.
8867 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
8868 that only turned off an error report, and did nothing else.
8870 2002-10-02 Miguel de Icaza <miguel@ximian.com>
8872 * driver.cs: Handle and ignore /fullpaths
8874 2002-10-01 Miguel de Icaza <miguel@ximian.com>
8876 * expression.cs (Binary.ResolveOperator): Catch the case where
8877 DoNumericPromotions returns true,
8879 (Binary.DoNumericPromotions): Simplify the code, and the tests.
8881 2002-09-27 Miguel de Icaza <miguel@ximian.com>
8883 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
8886 2002-09-26 Miguel de Icaza <miguel@ximian.com>
8888 * ecore.cs (ConvertNumericExplicit): It is not enough that the
8889 conversion exists, but it is also required that the conversion be
8890 performed. This manifested in "(Type64Enum) 2".
8892 * class.cs (TypeManager.AddMethod): The fix is not to change
8893 AddEnum, because that one was using a fully qualified name (every
8894 DeclSpace derivative does), but to change the AddMethod routine
8895 that was using an un-namespaced name. This now correctly reports
8896 the duplicated name.
8898 Revert patch until I can properly fix it. The issue
8899 is that we have a shared Type space across all namespaces
8900 currently, which is wrong.
8902 Options include making the Namespace a DeclSpace, and merge
8903 current_namespace/current_container in the parser.
8905 2002-09-25 Miguel de Icaza <miguel@ximian.com>
8907 * cs-parser.jay: Improve error reporting when we get a different
8908 kind of expression in local_variable_type and
8909 local_variable_pointer_type.
8911 Propagate this to avoid missleading errors being reported.
8913 * ecore.cs (ImplicitReferenceConversion): treat
8914 TypeManager.value_type as a target just like object_type. As
8919 Is valid, and needs to result in the int 1 being boxed before it
8920 is assigned to the value type v.
8922 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
8923 to validate the enumeration name.
8925 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
8926 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
8927 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
8929 * ecore.cs (TryImplicitIntConversion): When doing an
8930 implicit-enumeration-conversion, check if the type is 64-bits and
8931 perform a conversion before passing to EnumConstant.
8933 2002-09-23 Miguel de Icaza <miguel@ximian.com>
8935 * decl.cs (Error_AmbiguousTypeReference); New routine used to
8936 report ambiguous type references. Unlike the MS version, we
8937 report what the ambiguity is. Innovation at work ;-)
8939 (DeclSpace.FindType): Require a location argument to
8940 display when we display an ambiguous error.
8942 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
8944 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
8946 * expression.cs (EmitDynamicInitializers): Apply patch from
8947 hwang_rob@yahoo.ca that fixes the order in which we emit our
8950 2002-09-21 Martin Baulig <martin@gnome.org>
8952 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
8953 delegate takes no arguments.
8955 2002-09-20 Miguel de Icaza <miguel@ximian.com>
8957 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
8960 * expression.cs: Extract the underlying type.
8962 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
8964 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
8966 2002-09-19 Miguel de Icaza <miguel@ximian.com>
8968 * class.cs (TypeContainer.DefineType): We can not use the nice
8969 PackingSize with the size set to 1 DefineType method, because it
8970 will not allow us to define the interfaces that the struct
8973 This completes the fixing of bug 27287
8975 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
8976 means also structs. This fixes part of the problem.
8977 (Expresion.ImplicitReferenceConversionExists): ditto.
8979 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
8980 error if there were no errors reported during the type lookup
8981 process, to avoid duplicates or redundant errors. Without this
8982 you would get an ambiguous errors plus a type not found. We have
8983 beaten the user enough with the first error.
8985 (DeclSparce.FindType): Emit a warning if we have an ambiguous
8988 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
8989 during the resolution process, stop the lookup, this avoids
8990 repeated error reports (same error twice).
8992 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
8994 * typemanager.cs (LookupType): Redo the type lookup code to match
8995 the needs of System.Reflection.
8997 The issue is that System.Reflection requires references to nested
8998 types to begin with a "+" sign instead of a dot. So toplevel
8999 types look like: "NameSpace.TopLevelClass", and nested ones look
9000 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
9003 2002-09-19 Martin Baulig <martin@gnome.org>
9005 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
9006 says that a method always returns or always throws an exception,
9007 don't report the CS0161.
9009 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
9010 set `Returns = new_returns'.
9012 2002-09-19 Martin Baulig <martin@gnome.org>
9014 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
9015 to an enum constant, check for a CS0176.
9017 2002-09-18 Miguel de Icaza <miguel@ximian.com>
9019 * class.cs (TypeContainer.CheckPairedOperators): Now we check
9020 for operators that must be in pairs and report errors.
9022 * ecore.cs (SimpleName.DoResolveType): During the initial type
9023 resolution process, when we define types recursively, we must
9024 check first for types in our current scope before we perform
9025 lookups in the enclosing scopes.
9027 * expression.cs (MakeByteBlob): Handle Decimal blobs.
9029 (Invocation.VerifyArgumentsCompat): Call
9030 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
9031 I thought we were supposed to always call this, but there are a
9032 few places in the code where we dont do it.
9034 2002-09-17 Miguel de Icaza <miguel@ximian.com>
9036 * driver.cs: Add support in -linkres and -resource to specify the
9037 name of the identifier.
9039 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9041 * ecore.cs (StandardConversionExists): Sync with the conversion
9042 code: allow anything-* to void* conversions.
9044 (FindMostSpecificSource): Use an Expression argument
9045 instead of a Type, because we might be handed over a Literal which
9046 gets a few more implicit conversions that plain types do not. So
9047 this information was being lost.
9049 Also, we drop the temporary type-holder expression when not
9052 2002-09-17 Martin Baulig <martin@gnome.org>
9054 * class.cs (PropertyBase.CheckBase): Don't check the base class if
9055 this is an explicit interface implementation.
9057 2002-09-17 Martin Baulig <martin@gnome.org>
9059 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
9060 different `IndexerName' attributes.
9062 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
9063 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
9064 virtual CommonResolve().
9066 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9068 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
9069 and convert that to the UnderlyingType.
9071 * statement.cs (Foreach.Resolve): Indexers are just like variables
9072 or PropertyAccesses.
9074 * cs-tokenizer.cs (consume_string): Track line numbers and columns
9075 inside quoted strings, we were not doing this before.
9077 2002-09-16 Martin Baulig <martin@gnome.org>
9079 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
9080 resolve it. This is needed for the definite assignment check of the
9081 instance expression, fixes bug #29846.
9082 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
9084 2002-09-16 Nick Drochak <ndrochak@gol.com>
9086 * parameter.cs: Fix compile error. Cannot reference static member
9087 from an instance object. Is this an mcs bug?
9089 2002-09-14 Martin Baulig <martin@gnome.org>
9091 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
9092 multiple times. Fixes bug #30295, added test-166.cs.
9094 2002-09-14 Martin Baulig <martin@gnome.org>
9096 * statement.cs (Block.Emit): Don't emit unreachable code.
9097 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
9099 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
9101 2002-09-14 Martin Baulig <martin@gnome.org>
9103 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
9106 2002-09-14 Martin Baulig <martin@gnome.org>
9108 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
9109 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
9110 be false on the ms runtime.
9112 2002-09-13 Martin Baulig <martin@gnome.org>
9114 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
9115 the CS0038 error message.
9117 2002-09-12 Miguel de Icaza <miguel@ximian.com>
9119 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
9120 constant inside, return it.
9122 2002-09-12 Martin Baulig <martin@gnome.org>
9124 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
9125 implicit conversion can be done between enum types.
9127 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
9128 check whether an implicit conversion to the current enum's UnderlyingType
9129 exists and report an error if not.
9131 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
9132 without debugging support.
9134 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
9135 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
9137 2002-09-12 Martin Baulig <martin@gnome.org>
9139 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
9141 * ecore.cs (IMemberExpr.DeclaringType): New property.
9142 (SimpleName.SimpleNameResolve): Check whether we're accessing a
9143 nonstatic member of an outer type (CS0038).
9145 2002-09-11 Miguel de Icaza <miguel@ximian.com>
9147 * driver.cs: Activate the using-error detector at warning level
9148 4 (at least for MS-compatible APIs).
9150 * namespace.cs (VerifyUsing): Small buglett fix.
9152 * pending.cs (PendingImplementation): pass the container pointer.
9154 * interface.cs (GetMethods): Allow for recursive definition. Long
9155 term, I would like to move every type to support recursive
9156 definitions, not the current ordering mechanism that we have right
9159 The situation is this: Attributes are handled before interfaces,
9160 so we can apply attributes to interfaces. But some attributes
9161 implement interfaces, we will now handle the simple cases
9162 (recursive definitions will just get an error).
9164 * parameter.cs: Only invalidate types at the end if we fail to
9167 2002-09-09 Martin Baulig <martin@gnome.org>
9169 * ecore.cs (PropertyExpr.Emit): Also check for
9170 TypeManager.system_int_array_get_length so this'll also work when
9171 compiling corlib. Fixes #30003.
9173 2002-09-09 Martin Baulig <martin@gnome.org>
9175 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
9176 and throw an exception if we can't get the type's size. Fixed #30040,
9179 2002-09-09 Martin Baulig <martin@gnome.org>
9181 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
9183 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
9184 context. Fixes bug #30027.
9186 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
9187 virtual functions. Fixes bug #30043, added test-164.cs.
9189 2002-09-08 Ravi Pratap <ravi@ximian.com>
9191 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
9193 2002-09-08 Nick Drochak <ndrochak@gol.com>
9195 * driver.cs: Use an object to get the windows codepage since it's not a
9198 2002-09-08 Miguel de Icaza <miguel@ximian.com>
9200 * statement.cs (For.Emit): for infinite loops (test == null)
9201 return whether there is a break inside, not always "true".
9203 * namespace.cs (UsingEntry): New struct to hold the name of the
9204 using definition, the location where it is defined, and whether it
9205 has been used in a successful type lookup.
9207 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
9212 2002-09-06 Ravi Pratap <ravi@ximian.com>
9214 * attribute.cs : Fix incorrect code which relied on catching
9215 a NullReferenceException to detect a null being passed in
9216 where an object was expected.
9218 2002-09-06 Miguel de Icaza <miguel@ximian.com>
9220 * statement.cs (Try): flag the catch variable as assigned
9222 * expression.cs (Cast): Simplified by using ResolveType instead of
9225 * statement.cs (Catch): Fix bug by using ResolveType.
9227 2002-09-06 Ravi Pratap <ravi@ximian.com>
9229 * expression.cs (BetterConversion): Special case for when we have
9230 a NullLiteral as the argument and we have to choose between string
9231 and object types - we choose string the way csc does.
9233 * attribute.cs (Attribute.Resolve): Catch the
9234 NullReferenceException and report error #182 since the Mono
9235 runtime no more has the bug and having this exception raised means
9236 we tried to select a constructor which takes an object and is
9239 2002-09-05 Ravi Pratap <ravi@ximian.com>
9241 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
9242 message (1502, 1503) when we can't locate a method after overload
9243 resolution. This is much more informative and closes the bug
9246 * interface.cs (PopulateMethod): Return if there are no argument
9247 types. Fixes a NullReferenceException bug.
9249 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
9250 expressions too. Previously we were checking only in one place for
9251 positional arguments leaving out named arguments.
9253 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
9254 type to the enum type is not allowed. Remove code corresponding to
9257 (ConvertNumericExplicit): Allow explicit conversions from
9258 the underlying type to enum type. This precisely follows the spec
9259 and closes a bug filed by Gonzalo.
9261 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9264 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
9266 2002-09-03 Miguel de Icaza <miguel@ximian.com>
9268 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
9269 it was important that we stored the right value after the
9270 reduction in `converted'.
9272 2002-09-04 Martin Baulig <martin@gnome.org>
9274 * location.cs (Location.SymbolDocument): Use full pathnames for the
9277 2002-08-30 Miguel de Icaza <miguel@ximian.com>
9279 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
9280 of the expression resolve mechanism, because that will catch the
9281 SimpleName error failures.
9283 (Conditional): If we can not resolve the
9284 expression, return, do not crash.
9286 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9289 (location): display token name instead of its number.
9291 2002-08-28 Martin Baulig <martin@gnome.org>
9293 * expression.cs (Binary.ResolveOperator): Don't silently return
9294 but return an error if an operator cannot be applied between two
9297 2002-08-28 Martin Baulig <martin@gnome.org>
9299 * class.cs (Constructor.Define): Set the permission attributes
9300 correctly instead of making all constructors public.
9302 2002-08-28 Martin Baulig <martin@gnome.org>
9304 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
9305 for private members before reporting a CS0103; if we find anything,
9308 2002-08-28 Martin Baulig <martin@gnome.org>
9310 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9311 to check whether `closure_start_type == closure_invocation_type',
9312 we also need to check whether `m.DeclaringType == closure_invocation_type'
9313 before bypassing the permission checks. We might be accessing
9314 protected/private members from the base class.
9315 (TypeManager.RealMemberLookup): Only set private_ok if private
9316 members were requested via BindingFlags.NonPublic.
9318 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9320 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9321 MethodGroupExpr.IsExplicitImpl if appropriate.
9322 (Invocation.DoResolve): Don't report the CS0120 for explicit
9323 interface implementations.
9325 2002-08-27 Martin Baulig <martin@gnome.org>
9327 * expression.cs (Invocation.DoResolve): If this is a static
9328 method and we don't have an InstanceExpression, we must report
9331 2002-08-25 Martin Baulig <martin@gnome.org>
9333 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9334 `==' between a valuetype and an object.
9336 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9338 * ecore.cs (TypeExpr): Provide a ToString method.
9340 2002-08-24 Martin Baulig <martin@gnome.org>
9342 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9343 now called proggie.dbg and it's a binary file.
9345 2002-08-23 Martin Baulig <martin@gnome.org>
9347 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9349 2002-08-23 Martin Baulig <martin@gnome.org>
9351 * struct.cs (MyStructInfo.ctor): Make this work with empty
9352 structs; it's not allowed to use foreach() on null.
9354 2002-08-23 Martin Baulig <martin@gnome.org>
9356 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9357 writer the full pathname of the generated assembly.
9359 2002-08-23 Martin Baulig <martin@gnome.org>
9361 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9362 A `finally' block never returns or breaks; improved handling of
9365 2002-08-23 Martin Baulig <martin@gnome.org>
9367 * statement.cs (Throw.Resolve): Allow `throw null'.
9369 2002-08-23 Martin Baulig <martin@gnome.org>
9371 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9372 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9373 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9374 MemberLookup would return a wrong event if this is an explicit
9375 interface implementation and the class has an event with the same
9378 2002-08-23 Martin Baulig <martin@gnome.org>
9380 * statement.cs (Block.AddChildVariableNames): New public method.
9381 (Block.AddChildVariableName): Likewise.
9382 (Block.IsVariableNameUsedInChildBlock): Likewise.
9383 (Block.AddVariable): Check whether a variable name has already
9384 been used in a child block.
9386 * cs-parser.jay (declare_local_variables): Mark all variable names
9387 from the current block as being used in a child block in the
9390 2002-08-23 Martin Baulig <martin@gnome.org>
9392 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9393 find the symbol writer.
9395 * driver.cs: csc also allows the arguments to /define being
9396 separated by commas, not only by semicolons.
9398 2002-08-23 Martin Baulig <martin@gnome.org>
9400 * interface.cs (Interface.GetMembers): Added static check for events.
9402 2002-08-15 Martin Baulig <martin@gnome.org>
9404 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9405 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9407 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9408 why the MethodData.EmitDestructor() change was necessary.
9410 2002-08-20 Martin Baulig <martin@gnome.org>
9412 * class.cs (TypeContainer.FindMembers): Added static check for events.
9414 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9416 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9417 use Type.GetEvents(), not Type.FindMembers().
9419 2002-08-20 Martin Baulig <martin@gnome.org>
9421 * decl.cs (MemberCache): Added a special method cache which will
9422 be used for method-only searched. This ensures that a method
9423 search will return a MethodInfo with the correct ReflectedType for
9426 2002-08-20 Martin Baulig <martin@gnome.org>
9428 * decl.cs (DeclSpace.FindMembers): Made this public.
9430 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9432 * delegate.cs: fixed build on windows.
9433 [FIXME: Filed as bug #29150: MCS must report these errors.]
9435 2002-08-19 Ravi Pratap <ravi@ximian.com>
9437 * ecore.cs (StandardConversionExists): Return a false
9438 if we are trying to convert the void type to anything else
9439 since that is not allowed.
9441 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9442 we flag error 70 in the event an event is trying to be accessed
9443 directly from outside the declaring type.
9445 2002-08-20 Martin Baulig <martin@gnome.org>
9447 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9448 MemberCache from typemanager.cs to decl.cs.
9450 2002-08-19 Martin Baulig <martin@gnome.org>
9452 * class.cs (TypeContainer): Implement IMemberContainer.
9453 (TypeContainer.DefineMembers): Create the MemberCache.
9454 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9455 return public members if BindingFlags.Public was given, check
9456 whether members are static.
9458 2002-08-16 Martin Baulig <martin@gnome.org>
9460 * decl.cs (DeclSpace.Define): Splitted this in Define and
9461 DefineMembers. DefineMembers is called first and initializes the
9464 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9465 DefineMembers() on all our DeclSpaces.
9467 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9468 but call DefineMembers() on all nested interfaces. We call their
9469 Define() in our new Define() function.
9471 * interface.cs (Interface): Implement IMemberContainer.
9472 (Interface.Define): Moved all code except the attribute stuf to
9474 (Interface.DefineMembers): Initialize the member cache.
9476 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9477 need this anymore since we can use MemberCache.FindMembers directly.
9479 2002-08-19 Martin Baulig <martin@gnome.org>
9481 * typemanager.cs (MemberCache): When creating the cache for an
9482 interface type, add all inherited members.
9483 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9484 to `out bool used_cache' and documented it.
9485 (TypeManager.MemberLookup): If we already used the cache in the first
9486 iteration, we don't need to do the interfaces check.
9488 2002-08-19 Martin Baulig <martin@gnome.org>
9490 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9491 here from IMemberFinder and don't implement this interface anymore.
9492 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9494 * typemanager.cs (IMemberFinder): This interface is now only used by
9495 classes which actually support the member cache.
9496 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9497 since we only put DeclSpaces into this Hashtable.
9498 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9499 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9501 2002-08-16 Martin Baulig <martin@gnome.org>
9503 * typemanager.cs (ICachingMemberFinder): Removed.
9504 (IMemberFinder.MemberCache): New property.
9505 (TypeManager.FindMembers): Merged this with RealFindMembers().
9506 This function will never be called from TypeManager.MemberLookup()
9507 so we can't use the cache here, just the IMemberFinder.
9508 (TypeManager.MemberLookup_FindMembers): Check whether the
9509 IMemberFinder has a MemberCache and call the cache's FindMembers
9511 (MemberCache): Rewrote larger parts of this yet another time and
9512 cleaned it up a bit.
9514 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9516 * driver.cs (LoadArgs): Support quoting.
9518 (Usage): Show the CSC-like command line arguments.
9520 Improved a few error messages.
9522 2002-08-15 Martin Baulig <martin@gnome.org>
9524 * typemanager.cs (IMemberContainer.Type): New property.
9525 (IMemberContainer.IsInterface): New property.
9527 The following changes are conditional to BROKEN_RUNTIME, which is
9528 defined at the top of the file.
9530 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9531 class'es members, but add all members from TypeHandle.ObjectType
9532 if we're an interface.
9533 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9534 is the current type.
9535 (MemberCache.CacheEntry.Container): Removed this field.
9536 (TypeHandle.GetMembers): Include inherited members.
9538 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9540 * typemanager.cs: fixed compilation and added a comment on a field that
9543 2002-08-15 Martin Baulig <martin@gnome.org>
9545 * class.cs (ConstructorInitializer.Resolve): In the
9546 Expression.MemberLookup call, use the queried_type as
9549 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9550 declared' attribute, it's always true.
9551 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9552 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9553 temporary wrapper for FindMembers which tells MemberLookup whether
9554 members from the base classes are included in the return value.
9555 This will go away soon.
9556 (TypeManager.MemberLookup): Use this temporary hack here; once the
9557 new MemberCache is completed, we don't need to do the DeclaredOnly
9558 looping here anymore since the MemberCache will take care of this.
9559 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9560 (MemberCache): When creating the MemberCache for a class, get
9561 members from the current class and all its base classes.
9562 (MemberCache.CacheEntry.Container): New field. This is a
9563 temporary hack until the Mono runtime is fixed to distinguish
9564 between ReflectedType and DeclaringType. It allows us to use MCS
9565 with both the MS runtime and the unfixed Mono runtime without
9566 problems and without accecting performance.
9567 (MemberCache.SearchMembers): The DeclaredOnly looping from
9568 TypeManager.MemberLookup is now done here.
9570 2002-08-14 Martin Baulig <martin@gnome.org>
9572 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9573 Type.GetFields on dynamic types but get the fields from the
9574 corresponding TypeContainer.
9575 (MyStructInfo.GetStructInfo): Added check for enum types.
9577 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9578 (MemberList.SyncRoot): Implemented.
9579 (TypeManager.FilterWithClosure): No need to check permissions if
9580 closure_start_type == closure_invocation_type, don't crash if
9581 closure_invocation_type is null.
9583 2002-08-13 Martin Baulig <martin@gnome.org>
9585 Rewrote TypeContainer.FindMembers to use a member cache. This
9586 gives us a speed increase of about 35% for the self-hosting MCS
9587 build and of about 15-20% for the class libs (both on GNU/Linux).
9589 * report.cs (Timer): New class to get enhanced profiling. This
9590 whole class is "TIMER" conditional since it remarkably slows down
9593 * class.cs (MemberList): New class. This is an IList wrapper
9594 which we're now using instead of passing MemberInfo[]'s around to
9595 avoid copying this array unnecessarily.
9596 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9597 (ICachingMemberFinder, IMemberContainer): New interface.
9598 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9599 has already been checked, otherwise use it for the name comparision.
9600 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9601 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9602 if possible. Returns a MemberList, not a MemberInfo [].
9603 (TypeHandle): New class, implements IMemberContainer. We create
9604 one instance of this class per type, it contains a MemberCache
9605 which is used to do the member lookups.
9606 (MemberCache): New class. Each instance of this class contains
9607 all members of a type and a name-based hash table.
9608 (MemberCache.FindMembers): This is our new member lookup
9609 function. First, it looks up all members of the requested name in
9610 the hash table. Then, it walks this list and sorts out all
9611 applicable members and returns them.
9613 2002-08-13 Martin Baulig <martin@gnome.org>
9615 In addition to a nice code cleanup, this gives us a performance
9616 increase of about 1.4% on GNU/Linux - not much, but it's already
9617 half a second for the self-hosting MCS compilation.
9619 * typemanager.cs (IMemberFinder): New interface. It is used by
9620 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9621 Enum, Delegate or Interface.
9622 (TypeManager.finder_to_member_finder): New PtrHashtable.
9623 (TypeManager.finder_to_container): Removed.
9624 (TypeManager.finder_to_delegate): Removed.
9625 (TypeManager.finder_to_interface): Removed.
9626 (TypeManager.finder_to_enum): Removed.
9628 * interface.cs (Interface): Implement IMemberFinder.
9630 * delegate.cs (Delegate): Implement IMemberFinder.
9632 * enum.cs (Enum): Implement IMemberFinder.
9634 * class.cs (TypeContainer): Implement IMemberFinder.
9636 2002-08-12 Martin Baulig <martin@gnome.org>
9638 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9640 2002-08-12 Martin Baulig <martin@gnome.org>
9642 * ecore.cs (ITypeExpression): New interface for expressions which
9644 (TypeExpression): Renamed to TypeLookupExpression.
9645 (Expression.DoResolve): If we're doing a types-only lookup, the
9646 expression must implement the ITypeExpression interface and we
9647 call DoResolveType() on it.
9648 (SimpleName): Implement the new ITypeExpression interface.
9649 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9650 hack, the situation that we're only looking up types can't happen
9651 anymore when this method is called. Moved the type lookup code to
9652 DoResolveType() and call it.
9653 (SimpleName.DoResolveType): This ITypeExpression interface method
9654 is now doing the types-only lookup.
9655 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9656 (ResolveFlags): Added MaskExprClass.
9658 * expression.cs (MemberAccess): Implement the ITypeExpression
9660 (MemberAccess.DoResolve): Added support for a types-only lookup
9661 when we're called via ITypeExpression.DoResolveType().
9662 (ComposedCast): Implement the ITypeExpression interface.
9664 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
9665 Expression.Resolve() with ResolveFlags.Type instead.
9667 2002-08-12 Martin Baulig <martin@gnome.org>
9669 * interface.cs (Interface.Define): Apply attributes.
9671 * attribute.cs (Attribute.ApplyAttributes): Added support for
9672 interface attributes.
9674 2002-08-11 Martin Baulig <martin@gnome.org>
9676 * statement.cs (Block.Emit): Only check the "this" variable if we
9677 do not always throw an exception.
9679 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
9680 whether the property has a set accessor.
9682 2002-08-11 Martin Baulig <martin@gnome.org>
9684 Added control flow analysis support for structs.
9686 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
9687 with control flow analysis turned off.
9688 (IVariable): New interface.
9689 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
9690 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
9691 (FieldExpr.DoResolve): Resolve the instance expression with flow
9692 analysis turned off and do the definite assignment check after the
9693 resolving when we know what the expression will resolve to.
9695 * expression.cs (LocalVariableReference, ParameterReference):
9696 Implement the new IVariable interface, only call the flow analysis
9697 code if ec.DoFlowAnalysis is true.
9698 (This): Added constructor which takes a Block argument. Implement
9699 the new IVariable interface.
9700 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
9701 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
9702 This does the definite assignment checks for struct members.
9704 * class.cs (Constructor.Emit): If this is a non-static `struct'
9705 constructor which doesn't have any initializer, call
9706 Block.AddThisVariable() to tell the flow analysis code that all
9707 struct elements must be initialized before control returns from
9710 * statement.cs (MyStructInfo): New public class.
9711 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
9712 argument to this indexer. If non-zero, check an individual struct
9713 member, not the whole struct.
9714 (FlowBranching.CheckOutParameters): Check struct members.
9715 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
9716 overloaded versions of these methods which take an additional
9717 `int field_idx' argument to check struct members.
9718 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
9719 overloaded versions of these methods which take an additional
9720 `string field_name' argument to check struct member.s
9721 (VariableInfo): Implement the IVariable interface.
9722 (VariableInfo.StructInfo): New public property. Returns the
9723 MyStructInfo instance of the variable if it's a struct or null.
9724 (Block.AddThisVariable): New public method. This is called from
9725 Constructor.Emit() for non-static `struct' constructor which do
9726 not have any initializer. It creates a special variable for the
9727 "this" instance variable which will be checked by the flow
9728 analysis code to ensure that all of the struct's fields are
9729 initialized before control returns from the constructor.
9730 (UsageVector): Added support for struct members. If a
9731 variable/parameter is a struct with N members, we reserve a slot
9732 in the usage vector for each member. A struct is considered fully
9733 initialized if either the struct itself (slot 0) or all its
9734 members are initialized.
9736 2002-08-08 Martin Baulig <martin@gnome.org>
9738 * driver.cs (Driver.MainDriver): Only report an error CS5001
9739 if there were no compilation errors.
9741 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
9742 `UnsafeContext' property to determine whether the parent is in
9743 unsafe context rather than checking the parent's ModFlags:
9744 classes nested in an unsafe class are unsafe as well.
9746 2002-08-08 Martin Baulig <martin@gnome.org>
9748 * statement.cs (UsageVector.MergeChildren): Distinguish between
9749 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
9750 we return. Added test17() and test18() to test-154.cs.
9752 2002-08-08 Martin Baulig <martin@gnome.org>
9754 * typemanager.cs (TypeManager.FilterWithClosure): If we have
9755 Family access, make sure the invoking type isn't a subclass of the
9756 queried type (that'd be a CS1540).
9758 * ecore.cs (Expression.MemberLookup): Added overloaded version of
9759 this method which takes an additional `Type invocation_type'.
9761 * expression.cs (BaseAccess.DoResolve): Use the base type as
9762 invocation and query type.
9763 (MemberAccess.DoResolve): If the lookup failed and we're about to
9764 report a CS0122, try a lookup with the ec.ContainerType - if this
9765 succeeds, we must report a CS1540.
9767 2002-08-08 Martin Baulig <martin@gnome.org>
9769 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
9770 (MethodGroupExpr): Implement the IMemberExpr interface.
9772 * expression (MemberAccess.ResolveMemberAccess): No need to have
9773 any special code for MethodGroupExprs anymore, they're now
9776 2002-08-08 Martin Baulig <martin@gnome.org>
9778 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
9779 Family, FamANDAssem and FamORAssem permissions.
9780 (TypeManager.IsSubclassOrNestedChildOf): New public method.
9782 2002-08-08 Martin Baulig <martin@gnome.org>
9784 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
9785 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
9788 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
9790 * driver.cs: implemented /resource option to embed managed resources.
9792 2002-08-07 Martin Baulig <martin@gnome.org>
9794 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
9795 (FieldBase.HasFieldInitializer): New public property.
9796 (FieldBase.GetInitializerExpression): New public method. Resolves and
9797 returns the field initializer and makes sure it is only resolved once.
9798 (TypeContainer.EmitFieldInitializers): Call
9799 FieldBase.GetInitializerExpression to get the initializer, this ensures
9800 that it isn't resolved multiple times.
9802 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
9803 the resolving process (SimpleName/MemberLookup) that we're currently
9804 emitting a field initializer (which must not access any instance members,
9805 this is an error CS0236).
9807 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
9808 argument, if the `IsFieldInitializer' flag is set, we must report and
9809 error CS0236 and not an error CS0120.
9811 2002-08-07 Martin Baulig <martin@gnome.org>
9813 * ecore.cs (IMemberExpr): New public interface.
9814 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
9815 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
9816 if the expression is an IMemberExpr.
9818 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
9819 to be null, implicitly default to `this' if we're non-static in
9820 this case. Simplified the code a lot by using the new IMemberExpr
9821 interface. Also fixed bug #28176 here.
9823 2002-08-06 Martin Baulig <martin@gnome.org>
9825 * cs-parser.jay (SimpleLookup): Removed. We need to create
9826 ParameterReferences during semantic analysis so that we can do a
9827 type-only search when resolving Cast, TypeOf and SizeOf.
9828 (block): Pass the `current_local_parameters' to the Block's
9831 * class.cs (ConstructorInitializer): Added `Parameters parameters'
9832 argument to the constructor.
9833 (ConstructorInitializer.Resolve): Create a temporary implicit
9834 block with the parameters.
9836 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
9837 references here if we aren't doing a type-only search.
9839 * statement.cs (Block): Added constructor which takes a
9840 `Parameters parameters' argument.
9841 (Block.Parameters): New public property.
9843 * support.cs (InternalParameters.Parameters): Renamed `parameters'
9844 to `Parameters' and made it public readonly.
9846 2002-08-06 Martin Baulig <martin@gnome.org>
9848 * ecore.cs (Expression.Warning): Made this public as well.
9850 * report.cs (Report.Debug): Print the contents of collections.
9852 2002-08-06 Martin Baulig <martin@gnome.org>
9854 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
9855 used to tell Resolve() which kinds of expressions it may return.
9856 (Expression.Resolve): Added overloaded version of this method which
9857 takes a `ResolveFlags flags' argument. This can be used to tell
9858 Resolve() which kinds of expressions it may return. Reports a
9860 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
9861 ResolveFlags.SimpleName.
9862 (Expression.Error118): Added overloaded version of this method which
9863 takes a `ResolveFlags flags' argument. It uses the flags to determine
9864 which kinds of expressions are allowed.
9866 * expression.cs (Argument.ResolveMethodGroup): New public method.
9867 Resolves an argument, but allows a MethodGroup to be returned.
9868 This is used when invoking a delegate.
9870 * TODO: Updated a bit.
9872 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9874 Fixed compilation with csc.
9876 * ecore.cs: Expression.Error made public. Is this correct? Should
9877 Warning be made public too?
9879 * expression.cs: use ea.Location instead of ea.loc.
9880 [FIXME: Filed as bug #28607: MCS must report these errors.]
9882 2002-08-06 Martin Baulig <martin@gnome.org>
9884 * ecore.cs (Expression.loc): Moved the location here instead of
9885 duplicating it in all derived classes.
9886 (Expression.Location): New public property.
9887 (Expression.Error, Expression.Warning): Made them non-static and
9888 removed the location argument.
9889 (Expression.Warning): Added overloaded version which takes an
9890 `int level' argument.
9891 (Expression.Error118): Make this non-static and removed the
9892 expression and location arguments.
9893 (TypeExpr): Added location argument to the constructor.
9895 * expression.cs (StaticCallExpr): Added location argument to
9897 (Indirection, PointerArithmetic): Likewise.
9898 (CheckedExpr, UnCheckedExpr): Likewise.
9899 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
9900 (StringPtr): Likewise.
9903 2002-08-05 Martin Baulig <martin@gnome.org>
9905 * expression.cs (BaseAccess.DoResolve): Actually report errors.
9907 * assign.cs (Assign.DoResolve): Check whether the source
9908 expression is a value or variable.
9910 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
9911 while resolving the corresponding blocks.
9913 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
9914 an error, don't silently return null.
9916 * statement.cs (Block.AddVariable): Do the error reporting here
9917 and distinguish between CS0128 and CS0136.
9918 (Block.DoResolve): Report all unused labels (warning CS0164).
9919 (LabeledStatement): Pass the location to the constructor.
9920 (LabeledStatement.HasBeenReferenced): New property.
9921 (LabeledStatement.Resolve): Set it to true here.
9923 * statement.cs (Return.Emit): Return success even after reporting
9924 a type mismatch error (CS0126 or CS0127), this is what csc does and
9925 it avoids confusing the users with any consecutive errors.
9927 2002-08-05 Martin Baulig <martin@gnome.org>
9929 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
9931 * const.cs (Const.LookupConstantValue): Catch circular definitions.
9933 * expression.cs (MemberAccess.DoResolve): Silently return if an
9934 error has already been reported.
9936 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
9937 error has already been reported.
9939 2002-08-05 Martin Baulig <martin@gnome.org>
9941 * statement.cs (UsageVector): Only initialize the `parameters'
9942 vector if we actually have any "out" parameters.
9944 2002-08-05 Martin Baulig <martin@gnome.org>
9946 * expression.cs (Binary.ResolveOperator): When combining delegates,
9947 they must have the same type.
9949 2002-08-05 Martin Baulig <martin@gnome.org>
9951 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
9952 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
9953 work with the ms runtime and we also don't need it: if we're a
9954 PropertyBuilder and not in the `indexer_arguments' hash, then we
9955 are a property and not an indexer.
9957 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
9958 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
9959 since the latter one doesn't work with the ms runtime.
9961 2002-08-03 Martin Baulig <martin@gnome.org>
9963 Fixed bugs #27998 and #22735.
9965 * class.cs (Method.IsOperator): New public field.
9966 (Method.CheckBase): Report CS0111 if there's already a method
9967 with the same parameters in the current class. Report CS0508 when
9968 attempting to change the return type of an inherited method.
9969 (MethodData.Emit): Report CS0179 if a method doesn't have a body
9970 and it's not marked abstract or extern.
9971 (PropertyBase): New abstract base class for Property and Indexer.
9972 (PropertyBase.CheckBase): Moved here from Property and made it work
9974 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
9975 the same so we can reuse it there.
9976 (Property, Indexer): Derive from PropertyBase.
9977 (MethodSignature.inheritable_property_signature_filter): New delegate
9978 to find properties and indexers.
9980 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
9981 argument and improved error reporting.
9983 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
9984 EmptyReadOnlyParameters and made it a property.
9986 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
9987 version of this method which takes a `PropertyInfo indexer'.
9988 (TypeManager.RegisterIndexer): New method.
9990 * class.cs: Added myself as author of this file :-)
9992 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9994 * class.cs: fixed compilation on windoze.
9996 2002-08-03 Martin Baulig <martin@gnome.org>
9998 * interface.cs (Interface.GetInterfaceBases): Check whether all
9999 base interfaces are at least as accessible than the current one.
10001 * class.cs (TypeContainer.GetClassBases): Check whether base types
10002 are at least as accessible than the current type.
10003 (TypeContainer.AsAccessible): Implemented and made non-static.
10004 (MemberBase.CheckParameters): Report errors if the accessibility
10007 * delegate.cs (Delegate.Delegate): The default visibility is
10008 internal for top-level types and private for nested types.
10009 (Delegate.Define): Report errors if the accessibility checks fail.
10011 * enum.cs (Enum.Enum): The default visibility is internal for
10012 top-level types and private for nested types.
10013 (Enum.DefineType): Compute the correct visibility.
10015 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
10016 function which takes a `bool is_toplevel' instead of a TypeContainer.
10018 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
10021 2002-08-02 Martin Baulig <martin@gnome.org>
10023 * expression.cs (LocalVariableReferenc): Added constructor which
10024 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
10025 (LocalVariableReference.IsReadOnly): New property.
10026 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
10027 variable is readonly, use our own readonly flag to do this; you can
10028 use the new constructor to get a writable reference to a read-only
10031 * cs-parser.jay (foreach_statement, using_statement): Get a writable
10032 reference to the local variable.
10034 2002-08-01 Miguel de Icaza <miguel@ximian.com>
10036 * rootcontext.cs (ResolveCore): Also include System.Exception
10038 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
10039 we reach an EmptyStatement.
10041 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
10044 * expression.cs (Binary.ResolveOperator): Check error result in
10047 use brtrue/brfalse directly and avoid compares to null.
10049 2002-08-02 Martin Baulig <martin@gnome.org>
10051 * class.cs (TypeContainer.Define): Define all nested interfaces here.
10052 Fixes bug #28407, added test-155.cs.
10054 2002-08-01 Martin Baulig <martin@gnome.org>
10056 * class.cs (Event.EmitDefaultMethod): Make this work with static
10057 events. Fixes #28311, added verify-3.cs.
10059 2002-08-01 Martin Baulig <martin@gnome.org>
10061 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
10062 `is_disposable' fields.
10063 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
10064 `hm.is_disposable' if we're using the collection pattern.
10065 (Foreach.EmitCollectionForeach): Use the correct type for the
10066 enumerator's local variable, only emit the try/finally block if
10067 necessary (fixes #27713).
10069 2002-08-01 Martin Baulig <martin@gnome.org>
10071 * ecore.cs (Expression.report118): Renamed to Error118 and made
10074 * statement.cs (Throw.Resolve): Check whether the expression is of
10075 the correct type (CS0118) and whether the type derives from
10076 System.Exception (CS0155).
10077 (Catch.Resolve): New method. Do the type lookup here and check
10078 whether it derives from System.Exception (CS0155).
10079 (Catch.CatchType, Catch.IsGeneral): New public properties.
10081 * typemanager.cs (TypeManager.exception_type): Added.
10083 2002-07-31 Miguel de Icaza <miguel@ximian.com>
10085 * driver.cs: Updated About function.
10087 2002-07-31 Martin Baulig <martin@gnome.org>
10089 Implemented Control Flow Analysis.
10091 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
10092 (EmitContext.CurrentBranching): Added.
10093 (EmitContext.StartFlowBranching): Added.
10094 (EmitContext.EndFlowBranching): Added.
10095 (EmitContext.KillFlowBranching): Added.
10096 (EmitContext.IsVariableAssigned): Added.
10097 (EmitContext.SetVariableAssigned): Added.
10098 (EmitContext.IsParameterAssigned): Added.
10099 (EmitContext.SetParameterAssigned): Added.
10100 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
10101 Added control flow analysis stuff here.
10103 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
10104 resolve the expression as lvalue.
10105 (LocalVariableReference.DoResolve): Check whether the variable has
10106 already been assigned.
10107 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
10108 the parameter as assigned here.
10109 (ParameterReference.DoResolve): Check whether the parameter has already
10111 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
10112 expression as lvalue.
10114 * statement.cs (FlowBranching): New class for the flow analysis code.
10115 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
10116 (LabeledStatement.IsDefined): New public property.
10117 (LabeledStatement.AddUsageVector): New public method to tell flow
10118 analyis that the label may be reached via a forward jump.
10119 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
10121 (VariableInfo.Number): New public field. This is used by flow analysis
10122 to number all locals of a block.
10123 (Block.CountVariables): New public property. This is the number of
10124 local variables in this block (including the locals from all parent
10126 (Block.EmitMeta): Number all the variables.
10128 * statement.cs: Added flow analysis support to all classes.
10130 2002-07-31 Martin Baulig <martin@gnome.org>
10132 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
10133 To get debugging messages, compile mcs with /define:MCS_DEBUG and
10134 then use this argument.
10136 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
10138 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
10139 use this to specify /define options.
10141 2002-07-29 Martin Baulig <martin@gnome.org>
10143 * statement.cs (Fixed): Moved all code that does variable lookups
10144 and resolvings from Emit to Resolve.
10146 * statement.cs (For): Moved all code that does variable lookups
10147 and resolvings from Emit to Resolve.
10149 * statement.cs (Using): Moved all code that does variable lookups
10150 and resolvings from Emit to Resolve.
10152 2002-07-29 Martin Baulig <martin@gnome.org>
10154 * attribute.cs (Attribute.Resolve): Explicitly catch a
10155 System.NullReferenceException when creating the
10156 CustromAttributeBuilder and report a different warning message.
10158 2002-07-29 Martin Baulig <martin@gnome.org>
10160 * support.cs (ParameterData.ParameterName): Added method to
10161 get the name of a parameter.
10163 * typemanager.cs (TypeManager.IsValueType): New public method.
10165 2002-07-29 Martin Baulig <martin@gnome.org>
10167 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
10168 is a flag which specifies that it's either ref or out.
10169 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
10170 the out parameter to `out Parameter.Modifier mod', also set the
10171 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
10173 * support.cs (InternalParameters.ParameterModifier): Distinguish
10174 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10175 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10177 * expression.cs (Argument.GetParameterModifier): Distinguish
10178 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10179 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10181 2002-07-29 Martin Baulig <martin@gnome.org>
10183 * expression.cs (ParameterReference.ParameterReference): Added
10184 `Location loc' argument to the constructor.
10186 * cs-parser.jay: Pass location to ParameterReference.
10188 2002-07-28 Miguel de Icaza <miguel@ximian.com>
10190 * statement.cs (Try): Initialize the location.
10192 * cs-parser.jay: pass location to Try.
10194 * expression.cs (Unary.Reduce): Change the prototype to return
10195 whether a constant fold could be performed or not. The result is
10196 returned in an out parameters. In the case of Indirection and
10197 AddressOf, we want to perform the full tests.
10199 2002-07-26 Miguel de Icaza <miguel@ximian.com>
10201 * statement.cs (Statement.Emit): Flag dead code.
10203 2002-07-27 Andrew Birkett <andy@nobugs.org>
10205 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
10207 2002-07-27 Martin Baulig <martin@gnome.org>
10209 * class.cs (MethodData.Define): Put back call to
10210 TypeManager.AddMethod(), accidentally commented this out.
10212 * report.cs (Debug): New public method to print debugging information,
10213 this is `[Conditional ("DEBUG")]'.
10215 2002-07-26 Martin Baulig <martin@gnome.org>
10217 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
10218 (switch_statement): Push the current_block to the switch_stack and
10219 pop it again when we're done with the switch.
10220 (switch_section): The new block is a child of the current_block.
10221 Fixes bug #24007, added test-152.cs.
10223 2002-07-27 Martin Baulig <martin@gnome.org>
10225 * expression.cs (Invocation.EmitArguments): When calling a varargs
10226 function with only its fixed arguments, we need to pass an empty
10229 2002-07-27 Martin Baulig <martin@gnome.org>
10231 Mono 0.13 has been released.
10233 2002-07-25 Miguel de Icaza <miguel@ximian.com>
10235 * driver.cs: Rename --resource to --linkres, because that is what
10236 we do currently, we dont support --resource yet.
10238 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
10240 2002-07-25 Martin Baulig <martin@gnome.org>
10242 * class.cs (MethodData): New public class. This is a `method builder'
10243 class for a method or one accessor of a Property/Indexer/Event.
10244 (MethodData.GetMethodFlags): Moved here from MemberBase.
10245 (MethodData.ApplyAttributes): Likewise.
10246 (MethodData.ApplyObsoleteAttribute): Likewise.
10247 (MethodData.ApplyConditionalAttribute): Likewise.
10248 (MethodData.ApplyDllImportAttribute): Likewise.
10249 (MethodData.CheckAbstractAndExternal): Likewise.
10250 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
10251 (MethodData.Emit): Formerly known as Method.Emit().
10252 (MemberBase): Moved everything which was specific to a single
10253 accessor/method to MethodData.
10254 (Method): Create a new MethodData and call Define() and Emit() on it.
10255 (Property, Indexer, Event): Create a new MethodData objects for each
10256 accessor and call Define() and Emit() on them.
10258 2002-07-25 Martin Baulig <martin@gnome.org>
10260 Made MethodCore derive from MemberBase to reuse the code from there.
10261 MemberBase now also checks for attributes.
10263 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
10264 (MemberBase.GetMethodFlags): Moved here from class Method and marked
10266 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
10267 `CallingConventions cc' and `Attributes opt_attrs' arguments.
10268 (MemberBase.ApplyAttributes): New virtual method; applies the
10269 attributes to a method or accessor.
10270 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
10271 (MemberBase.ApplyConditionalAttribute): Likewise.
10272 (MemberBase.ApplyDllImportAttribute): Likewise.
10273 (MemberBase.CheckAbstractAndExternal): Likewise.
10274 (MethodCore.ParameterTypes): This is now a property instead of a
10275 method, it's initialized from DoDefineParameters().
10276 (MethodCore.ParameterInfo): Removed the set accessor.
10277 (MethodCore.DoDefineParameters): New protected virtual method to
10278 initialize ParameterTypes and ParameterInfo.
10279 (Method.GetReturnType): We can now simply return the MemberType.
10280 (Method.GetMethodFlags): Override the MemberBase version and add
10281 the conditional flags.
10282 (Method.CheckBase): Moved some code from Define() here, call
10283 DoDefineParameters() here.
10284 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
10285 here to avoid some larger code duplication.
10286 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
10287 ensure that abstract and external accessors don't declare a body.
10289 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
10290 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
10291 lookup in the attribute's parent classes, so we need to abort as soon
10292 as we found the first match.
10293 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
10294 the attribute has no arguments.
10296 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
10299 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10301 * cs-parser.jay: reverted previous patch.
10303 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10305 * cs-parser.jay: fixed bug #22119.
10307 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10309 * attribute.cs: fixed compilation. The error was:
10310 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10311 be assigned to before control leaves the current method."
10312 [FIXME: Filed as bug #28186: MCS must report this error.]
10314 2002-07-25 Martin Baulig <martin@gnome.org>
10316 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10317 method to pull the condition name ouf of a Conditional attribute.
10318 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10319 the obsolete message and error flag out of an Obsolete attribute.
10321 * class.cs (Method.GetMethodFlags): New public method to get the
10322 TypeManager.MethodFlags for this method.
10323 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10325 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10326 if we're overriding a virtual function, set the new private variable
10327 `parent_method'; call the new TypeManager.AddMethod().
10329 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10330 the MethodBuilder and the Method in a PtrHashtable.
10331 (TypeManager.builder_to_method): Added for this purpose.
10332 (TypeManager.MethodFlags): Added IsObsoleteError.
10333 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10334 Obsolete and Conditional arguments in MethodBuilders. If we discover
10335 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10336 the message from the attribute.
10338 2002-07-24 Martin Baulig <martin@gnome.org>
10340 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10341 preprocessor directives, ensure that the argument to #define/#undef is
10342 exactly one identifier and that it's actually an identifier.
10344 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10347 2002-07-24 Martin Baulig <martin@gnome.org>
10349 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10350 initialize it to TypeManager.object_type in the constructor.
10351 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10352 of the `hm.get_current' method if we're using the collection pattern.
10353 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10354 for the explicit conversion to make it work when we're using the collection
10355 pattern and the `Current' property has a different return type than `object'.
10358 2002-07-24 Martin Baulig <martin@gnome.org>
10360 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10361 does not match, but don't report any errors. This method is called in
10362 order for all methods in a MethodGroupExpr until a matching method is
10363 found, so we don't want to bail out if the first method doesn't match.
10364 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10365 matches, report the 123. Fixes #28070.
10367 2002-07-24 Martin Baulig <martin@gnome.org>
10369 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10370 TypeManager.TypeToCoreType() to the top of the method so the
10371 following equality checks will work. Fixes #28107.
10373 2002-07-24 Martin Baulig <martin@gnome.org>
10375 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10376 operand is of type uint, and the other operand is of type sbyte,
10377 short or int, the operands are converted to type long." -
10378 Actually do what this comment already told us. Fixes bug #28106,
10381 2002-07-24 Martin Baulig <martin@gnome.org>
10383 * class.cs (MethodBase): New abstract class. This is now a base
10384 class for Property, Indexer and Event to avoid some code duplication
10385 in their Define() and DefineMethods() methods.
10386 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10387 generic methods for Define() and DefineMethods().
10388 (FieldBase): Derive from MemberBase, not MemberCore.
10389 (Property): Derive from MemberBase, not MemberCore.
10390 (Property.DefineMethod): Moved all the code from this method to the
10391 new MethodBase.DefineAccessor(), just call it with appropriate
10393 (Property.Define): Call the new Property.DoDefine(), this does some
10394 sanity checks and we don't need to duplicate the code everywhere.
10395 (Event): Derive from MemberBase, not MemberCore.
10396 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10397 accessors, this will also make them work with interface events.
10398 (Indexer): Derive from MemberBase, not MemberCore.
10399 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10400 (Indexer.Define): Use the new MethodBase functions.
10402 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10403 argument to the constructor.
10404 (Interface.FindMembers): Added support for interface events.
10405 (Interface.PopluateEvent): Implemented.
10407 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10409 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10411 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10412 but this is required to check for a method name being the same as
10413 the containing class.
10417 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10419 * interface.cs: initialize variable.
10421 2002-07-23 Martin Baulig <martin@gnome.org>
10423 Implemented the IndexerName attribute in interfaces.
10425 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10426 name if this is an explicit interface implementation.
10427 (Indexer.InterfaceIndexerName): New public variable. If we're
10428 implementing an interface indexer, this is the IndexerName in that
10429 interface. Otherwise, it's the IndexerName.
10430 (Indexer.DefineMethod): If we're implementing interface indexer,
10431 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10432 and Pending.ImplementIndexer methods.
10433 (Indexer.Define): Also define the PropertyBuilder if we're
10434 implementing an interface indexer and this is neither an explicit
10435 interface implementation nor do the IndexerName match the one in
10438 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10439 If a method is defined here, then we always need to create a proxy
10440 for it. This is used when implementing interface indexers.
10441 (Pending.IsInterfaceIndexer): New public method.
10442 (Pending.ImplementIndexer): New public method.
10443 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10444 This is used when implementing interface indexers to define a proxy
10446 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10447 define a proxy if necessary.
10449 * interface.cs (Interface.IndexerName): New public variable.
10450 (Interface.PopulateIndexer): Set the IndexerName.
10451 (Interface.DefineIndexers): New private method. Populate all the
10452 indexers and make sure their IndexerNames match.
10454 * typemanager.cs (IndexerPropertyName): Added support for interface
10457 2002-07-22 Martin Baulig <martin@gnome.org>
10459 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10460 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10461 ret if HasReturnLabel.
10462 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10465 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10466 and set the ec.LoopBeginTryCatchLevel.
10467 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10468 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10469 the current ec.TryCatchLevel, the branch goes out of an exception
10470 block. In this case, we need to use Leave and not Br.
10472 2002-07-22 Martin Baulig <martin@gnome.org>
10474 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10475 block unless the block does not always return or it is contained in
10476 another try { ... } catch { ... } block. Fixes bug #26506.
10477 Added verify-1.cs to the test suite.
10479 2002-07-22 Martin Baulig <martin@gnome.org>
10481 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10482 then we do not always return. Fixes bug #24985.
10484 2002-07-22 Martin Baulig <martin@gnome.org>
10486 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10487 lookup on a per-class level; ie. walk up the class hierarchy until we
10488 found at least one applicable method, then choose the best among them.
10489 Fixes bug #24463 and test-29.cs.
10491 2002-07-22 Martin Baulig <martin@gnome.org>
10493 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10494 return types of the methods. The return type is not part of the
10495 signature and we must not check it to make the `new' modifier work.
10496 Fixes bug #27999, also added test-147.cs.
10497 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10499 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10500 on the method's return type.
10502 2002-07-21 Martin Baulig <martin@gnome.org>
10504 * assign.cs: Make this work if the rightmost source is a constant and
10505 we need to do an implicit type conversion. Also adding a few more tests
10506 to test-38.cs which should have caught this.
10508 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10509 target in the makefile for this. The makefile.gnu is primarily intended
10510 for end-users who don't want to debug the compiler.
10512 2002-07-21 Martin Baulig <martin@gnome.org>
10514 * assign.cs: Improved the Assign class so it can now handle embedded
10515 assignments (X = Y = Z = something). As a side-effect this'll now also
10516 consume less local variables. test-38.cs now passes with MCS, added
10517 a few new test cases to that test.
10519 2002-07-20 Martin Baulig <martin@gnome.org>
10521 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10522 instructions. Fixes bug #27977, also added test-146.cs.
10524 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10526 * cs-tokenizer.cs: fixed getHex ().
10528 2002-07-19 Martin Baulig <martin@gnome.org>
10530 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10531 not Type.GetType() to lookup the array type. This is needed when
10532 we're constructing an array of a user-defined type.
10533 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10534 single-dimensional arrays, but also for single-dimensial arrays of
10537 2002-07-19 Martin Baulig <martin@gnome.org>
10539 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10540 this function is called, it's not allowed to share LocalBuilders
10541 among ILGenerators.
10543 2002-07-19 Martin Baulig <martin@gnome.org>
10545 * expression.cs (Argument.Resolve): Report an error 118 when trying
10546 to pass a type as argument.
10548 2002-07-18 Martin Baulig <martin@gnome.org>
10550 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10551 Conv_R_Un for the signed `long' type.
10553 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10555 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10556 `expr' for the temporary result, as that will fail if we do
10557 multiple resolves on the same expression.
10559 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10561 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10562 ec.TypeContainer for looking up aliases.
10564 * class.cs (TypeContainer): Remove LookupAlias from here.
10566 * decl.cs (DeclSpace); Move here.
10568 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10570 * class.cs (FindMembers): Only call filter if the constructor
10571 bulider is not null.
10573 Also handle delegates in `NestedTypes' now. Now we will perform
10574 type lookups using the standard resolution process. This also
10577 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10578 This uses Expressions (the limited kind that can be parsed by the
10579 tree) instead of strings.
10581 * expression.cs (ComposedCast.ToString): Implement, used to flag
10582 errors since now we have to render expressions.
10584 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10587 * ecore.cs (SimpleName.ToString): ditto.
10589 * cs-parser.jay: Instead of using strings to assemble types, use
10590 Expressions to assemble the type (using SimpleName, ComposedCast,
10591 MemberAccess). This should fix the type lookups in declarations,
10592 because we were using a different code path for this.
10594 * statement.cs (Block.Resolve): Continue processing statements
10595 even when there is an error.
10597 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10599 * class.cs (Event.Define): Also remove the `remove' method from
10600 the list of pending items.
10602 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10603 generate more compact code.
10605 2002-07-17 Martin Baulig <martin@gnome.org>
10607 * const.cs (Const.LookupConstantValue): Add support for constant
10608 `unchecked' and `checked' expressions.
10609 Also adding test case test-140.cs for this.
10611 2002-07-17 Martin Baulig <martin@gnome.org>
10613 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10614 check whether mi.ReturnType implements the IEnumerator interface; the
10615 `==' and the IsAssignableFrom() will fail in this situation.
10617 2002-07-16 Ravi Pratap <ravi@ximian.com>
10619 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10622 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10624 * expression.cs: fixed bug #27811.
10626 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10628 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10629 Molaro: when we are a ref, the value already contains a pointer
10630 value, do not take the address of it.
10632 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10633 * removed mb-parser.jay and mb-tokenizer.cs
10635 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10637 * expression.cs: check against the building corlib void type.
10639 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10641 * ecore.cs: fix for valuetype static readonly fields: when
10642 initializing them, we need their address, not the address of a copy.
10644 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10646 * typemanager.cs: register also enum_type in corlib.
10648 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10650 * class.cs: allow calling this (but not base) initializers in structs.
10652 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10654 * ecore.cs: make sure we compare against the building base types
10657 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
10659 * typemanager.cs: fix TypeToCoreType() to handle void and object
10660 (corlib gets no more typerefs after this change).
10662 2002-07-12 Miguel de Icaza <miguel@ximian.com>
10664 * expression.cs (ArrayCreation.EmitArrayArguments): use
10665 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
10667 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
10668 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
10669 array indexes, the runtime actually forbids them.
10671 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
10672 for array arguments here.
10674 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
10675 instead of the default for ValueTypes.
10677 (New.DoEmit): Use IsValueType instead of
10678 IsSubclassOf (value_type)
10679 (New.DoResolve): ditto.
10680 (Invocation.EmitCall): ditto.
10682 * assign.cs (Assign): ditto.
10684 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
10685 Statements *are* currently doing part of their resolution during
10688 Expressions do always resolve during resolve, but statements are
10689 only required to propagate resolution to their children.
10691 2002-07-11 Miguel de Icaza <miguel@ximian.com>
10693 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
10695 (LoadAssembly): Do not add the dll if it is already specified
10697 (MainDriver): Add the System directory to the link path at the end,
10698 after all the other -L arguments.
10700 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
10701 wrong opcode for loading bytes and bools (ldelem.i1 instead of
10702 ldelem.u1) and using the opposite for sbytes.
10704 This fixes Digger, and we can finally run it.
10706 * driver.cs (UnixParseOption): Move the option parsing here.
10707 (CSCParseOption): Implement CSC-like parsing of options.
10709 We now support both modes of operation, the old Unix way, and the
10710 new CSC-like way. This should help those who wanted to make cross
10711 platform makefiles.
10713 The only thing broken is that /r:, /reference: and /lib: are not
10714 implemented, because I want to make those have the same semantics
10715 as the CSC compiler has, and kill once and for all the confussion
10716 around this. Will be doing this tomorrow.
10718 * statement.cs (Unsafe.Resolve): The state is checked during
10719 resolve, not emit, so we have to set the flags for IsUnsfe here.
10721 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10723 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
10724 not catch the Error_ObjectRefRequired in SimpleName (as it is
10725 possible to have a class/instance variable name that later gets
10726 deambiguated), we have to check this here.
10728 2002-07-10 Ravi Pratap <ravi@ximian.com>
10730 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
10731 make static and put into Expression.
10733 (Event.Define): Register the private field of the event with the
10734 TypeManager so that GetFieldFromEvent can get at it.
10736 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
10737 keep track of the private field associated with an event which
10740 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
10743 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
10745 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10747 * expression.cs (Binary.EmitBranchable): this routine emits the
10748 Binary expression in a branchable context. This basically means:
10749 we need to branch somewhere, not just get the value on the stack.
10751 This works together with Statement.EmitBoolExpression.
10753 * statement.cs (Statement.EmitBoolExpression): Use
10756 2002-07-09 Miguel de Icaza <miguel@ximian.com>
10758 * statement.cs (For): Reduce the number of jumps in loops.
10760 (For): Implement loop inversion for the For statement.
10762 (Break): We can be breaking out of a Try/Catch controlled section
10763 (foreach might have an implicit try/catch clause), so we need to
10764 use Leave instead of Br.
10766 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
10767 now). If the instace expression supports IMemoryLocation, we use
10768 the AddressOf method from the IMemoryLocation to extract the
10769 address instead of emitting the instance.
10771 This showed up with `This', as we were emitting the instance
10772 always (Emit) instead of the Address of This. Particularly
10773 interesting when This is a value type, as we dont want the Emit
10774 effect (which was to load the object).
10776 2002-07-08 Miguel de Icaza <miguel@ximian.com>
10778 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
10780 * statement.cs (Checked): Set the CheckedState during the resolve
10781 process too, as the ConvCast operations track the checked state on
10782 the resolve process, and not emit.
10784 * cs-parser.jay (namespace_member_declaration): Flag that we have
10785 found a declaration when we do. This is used to flag error 1529
10787 * driver.cs: Report ok when we display the help only.
10789 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
10791 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
10793 2002-07-04 Miguel de Icaza <miguel@ximian.com>
10795 * cs-tokenizer.cs (define): We also have to track locally the
10796 defines. AllDefines is just used for the Conditional Attribute,
10797 but we also need the local defines for the current source code.
10799 2002-07-03 Miguel de Icaza <miguel@ximian.com>
10801 * statement.cs (While, For, Do): These loops can exit through a
10802 Break statement, use this information to tell whether the
10803 statement is the last piece of code.
10805 (Break): Flag that we break.
10807 * codegen.cs (EmitContexts): New `Breaks' state variable.
10809 2002-07-03 Martin Baulig <martin@gnome.org>
10811 * class.cs (TypeContainer.MethodModifiersValid): Allow override
10812 modifiers in method declarations in structs. Otherwise, you won't
10813 be able to override things like Object.Equals().
10815 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10817 * class.cs (Method, Property, Indexer): Do not allow the public
10818 modifier to be used in explicit interface implementations.
10820 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
10821 override modifiers in method declarations in structs
10823 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
10825 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
10826 integer or real overflow, report an error
10828 2002-07-02 Martin Baulig <martin@gnome.org>
10830 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
10831 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
10832 to tell the runtime about our newly created System.Object and
10833 System.ValueType types.
10835 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10837 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
10838 struct instead of Ldarg/Starg.
10840 2002-07-02 Martin Baulig <martin@gnome.org>
10842 * expression.cs (Indirection.Indirection): Call
10843 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
10845 2002-07-02 Martin Baulig <martin@gnome.org>
10847 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
10848 ValueType, call TypeManager.TypeToCoreType() on it.
10849 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
10850 the OpCodes.Newarr argument.
10852 2002-07-02 Martin Baulig <martin@gnome.org>
10854 * expression.cs (Invocation.EmitCall): When compiling corlib,
10855 replace all calls to the system's System.Array type to calls to
10856 the newly created one.
10858 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
10859 System.Array methods.
10860 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
10861 from the system's System.Array type which must be replaced.
10863 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
10865 * typemanager.cs: load unverifiable_code_ctor so we can build
10866 corlib using the correct type. Avoid using GetTypeCode() with
10868 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
10869 TypeManager.object_type to allow building corlib.
10871 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
10873 * ecore.cs: handle System.Enum separately in LoadFromPtr().
10875 2002-07-01 Martin Baulig <martin@gnome.org>
10877 * class.cs: Make the last change actually work, we need to check
10878 whether `ifaces != null' to avoid a crash.
10880 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10882 * class.cs: when we build structs without fields that implement
10883 interfaces, we need to add the interfaces separately, since there is
10884 no API to both set the size and add the interfaces at type creation
10887 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10889 * expression.cs: the dimension arguments to the array constructors
10890 need to be converted if they are a long.
10892 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
10894 * class.cs: don't emit ldarg.0 if there is no parent constructor
10895 (fixes showstopper for corlib).
10897 2002-06-29 Martin Baulig <martin@gnome.org>
10899 MCS now compiles corlib on GNU/Linux :-)
10901 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
10902 ie. check for MethodImplOptions.InternalCall.
10904 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
10905 and TypeManager.attribute_type are null, so we must explicitly check
10906 whether parent is not null to find out whether it's an attribute type.
10907 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
10908 and SetBuilder, not only if the property is neither abstract nor external.
10909 This is necessary to set the MethodImplOptions on the accessor methods.
10910 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
10911 SetBuilder, see Property.Emit().
10913 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
10914 populate "System.Object", "System.ValueType" and "System.Attribute" since
10915 they've already been populated from BootCorlib_PopulateCoreTypes().
10917 2002-06-29 Martin Baulig <martin@gnome.org>
10919 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
10920 is the NullLiteral, we also need to make sure that target_type is not
10923 2002-06-29 Martin Baulig <martin@gnome.org>
10925 * rootcontext.cs (RootContext.ResolveCore): We must initialize
10926 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
10927 before calling BootstrapCorlib_ResolveDelegate ().
10929 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10931 * statement.cs: fixed build-breaker. All tests passed ok.
10933 2002-06-27 Martin Baulig <martin@gnome.org>
10935 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
10936 for System.Decimal when compiling corlib.
10938 2002-06-27 Martin Baulig <martin@gnome.org>
10940 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
10941 switch blocks which contain nothing but a default clause.
10943 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
10945 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
10947 2002-06-27 Martin Baulig <martin@gnome.org>
10949 * ecore.cs (PropertyExpr.PropertyExpr): Call
10950 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
10952 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
10953 is already a TypeBuilder.
10955 2002-06-27 Martin Baulig <martin@gnome.org>
10957 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
10958 `target_type == TypeManager.array_type', not IsAssignableFrom() in
10959 the "from an array-type to System.Array" case. This makes it work
10960 when compiling corlib.
10962 2002-06-27 Martin Baulig <martin@gnome.org>
10964 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
10965 non-static PropertyExpr, set its InstanceExpression. This makes
10966 the `ICollection.Count' property work in System/Array.cs.
10968 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
10970 * driver.cs: Made error handling more consistent. Errors now
10971 tracked by Report class, so many methods which used to return int
10972 now return void. Main() now prints success/failure and
10973 errors/warnings message.
10975 Renamed '--probe' compiler argument to '--expect-error'. Removed
10976 the magic number return values (123 and 124). Now, if the
10977 expected error occurs, the compiler exits with success (exit value
10978 0). If the compilation completes without seeing that particular
10979 error, the compiler exits with failure (exit value 1). The
10980 makefile in mcs/errors has been changed to handle the new behaviour.
10982 * report.cs: Made 'expected error' number a property and renamed
10983 it from 'Probe' to 'ExpectedError'.
10985 * genericparser.cs: Removed error handling support, since it is
10986 now all done by Report class.
10988 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
10989 class, so parse() no longer returns an int.
10991 * namespace.cs: Use Report.Error instead of GenericParser.error
10993 2002-06-22 Miguel de Icaza <miguel@ximian.com>
10995 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
10996 TypeContainer.AddOperator): At the front of the list put the
10997 explicit implementations, so they get resolved/defined first.
10999 2002-06-21 Miguel de Icaza <miguel@ximian.com>
11001 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
11002 interface type is implemented by this TypeContainer. Used during
11003 explicit interface implementation.
11005 (Property.Define, Indexer.Define, Method.Define): Validate that
11006 the given interface in the explicit implementation is one of the
11007 base classes for the containing type.
11009 Also if we are explicitly implementing an interface, but there is
11010 no match in the pending implementation table, report an error.
11012 (Property.Define): Only define the property if we are
11013 not explicitly implementing a property from an interface. Use the
11014 correct name also for those properties (the same CSC uses,
11015 although that is really not needed).
11017 (Property.Emit): Do not emit attributes for explicitly implemented
11018 properties, as there is no TypeBuilder.
11020 (Indexer.Emit): ditto.
11022 Hiding then means that we do not really *implement* a pending
11023 implementation, which makes code fail.
11025 2002-06-22 Martin Baulig <martin@gnome.org>
11027 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
11028 the return value of Object.GetType(). [FIXME: we need to do this whenever
11029 we get a type back from the reflection library].
11031 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
11033 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
11035 2002-06-20 Miguel de Icaza <miguel@ximian.com>
11037 * attribute.cs: Return null if we can not look up the type.
11039 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
11040 the interface types found.
11042 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
11043 interface types found.
11045 * typemanager.cs (GetInterfaces): Make this routine returns alll
11046 the interfaces and work around the lame differences between
11047 System.Type and System.Reflection.Emit.TypeBuilder in the results
11048 result for GetInterfaces.
11050 (ExpandInterfaces): Given an array of interface types, expand and
11051 eliminate repeated ocurrences of an interface. This expands in
11052 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
11055 2002-06-21 Martin Baulig <martin@gnome.org>
11057 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
11060 2002-06-21 Martin Baulig <martin@gnome.org>
11062 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
11063 and called with one of the core types, return the corresponding typebuilder for
11066 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
11069 2002-06-21 Martin Baulig <martin@gnome.org>
11071 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
11072 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
11073 (Expression.ConvertReferenceExplicit): Likewise.
11075 * expression.cs (ElementAccess.DoResolve): Likewise.
11076 (ElementAccess.DoResolveLValue): Likewise.
11078 2002-06-10 Martin Baulig <martin@gnome.org>
11080 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
11081 add the "value" parameter to the parameter list.
11083 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
11086 2002-06-19 Miguel de Icaza <miguel@ximian.com>
11088 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
11089 the argument to an int, uint, long or ulong, per the spec. Also
11090 catch negative constants in array creation.
11092 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
11094 * class.cs: do not allow the same interface to appear twice in
11095 the definition list.
11097 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
11099 * ecore.cs: don't use ldlen with System.Array.
11101 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
11103 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
11105 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
11107 * modifiers.cs: produce correct field attributes for protected
11108 internal. Easy fix so miguel can work on ther harder stuff:-)
11110 2002-06-18 Miguel de Icaza <miguel@ximian.com>
11112 * pending.cs: New file. Move the code from class.cs here.
11113 Support clearning the pending flag for all methods (when not doing
11114 explicit interface implementation).
11116 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
11118 * rootcontext.cs: added a couple more types needed to bootstrap.
11120 2002-06-17 Miguel de Icaza <miguel@ximian.com>
11122 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
11123 constructor in the type, instead of any constructor in the type
11124 hierarchy. Thanks to Paolo for finding this bug (it showed up as
11125 a bug in the Mono runtime when applying the params attribute).
11127 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11128 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
11130 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
11132 * expression.cs (Unary.ResolveOperator): Use TypeManager
11133 to resolve the type.
11135 2002-06-13 Ravi Pratap <ravi@ximian.com>
11137 * cs-parser.jay (enum_member_declaration): Pass in the attributes
11140 * enum.cs (AddEnumMember): Add support to store the attributes associated
11141 with each member too.
11143 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
11144 field builders too - this takes care of the enum member case.
11146 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
11148 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
11149 address-of operator on both value types and pointers.
11151 2002-06-10 Martin Baulig <martin@gnome.org>
11153 * interface.cs (Interface.PopulateIndexer): Add the indexer's
11154 PropertyBuilder to the `property_builders' list.
11156 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
11157 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
11158 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
11159 find any indexers which are inherited from an interface.
11161 2002-06-09 Martin Baulig <martin@gnome.org>
11163 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
11164 the same type as the constant if necessary. There's also a test-130.cs
11167 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
11169 * typemanager.cs (TypeManager.ChangeType): Previously known as
11170 Enum.ChangeEnumType().
11172 2002-06-09 Martin Baulig <martin@gnome.org>
11174 * expression.cs (Cast.TryReduce): Added support for consts.
11176 2002-06-08 Ravi Pratap <ravi@ximian.com>
11178 * class.cs (Accessor): Hold attributes information so we can pass
11181 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
11182 Modify to pass in attributes attached to the methods.
11184 (add_accessor_declaration, remove_accessor_declaration): Ditto.
11186 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
11187 to handle the Accessor kind :-)
11189 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
11191 2002-06-08 Martin Baulig <martin@gnome.org>
11193 * expression.cs (Unary.TryReduceNegative): Added support for
11196 2002-06-08 Martin Baulig <martin@gnome.org>
11198 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
11199 name can't be found in the `defined_names' - the caller will do a
11200 MemberLookup in this case and thus find methods in System.Enum
11201 such as Enum.IsDefined().
11203 2002-06-08 Martin Baulig <martin@gnome.org>
11205 * enum.cs (Enum.ChangeEnumType): This is a custom version of
11206 Convert.ChangeType() which works with TypeBuilder created types.
11207 (Enum.LookupEnumValue, Enum.Define): Use it here.
11209 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
11210 `TypeBuilder.BaseType != null' check.
11211 (TypeContainer.FindMembers): Only lookup parent members if we
11212 actually have a parent.
11213 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
11214 (ConstructorInitializer.Resolve): Likewise.
11216 * interface.cs (Interface.FindMembers): Added
11217 `TypeBuilder.BaseType != null' check.
11219 * rootcontext.cs (RootContext.ResolveCore): Added
11220 "System.Runtime.CompilerServices.IndexerNameAttribute" to
11221 classes_second_stage.
11223 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
11224 debug_type and trace_type when compiling with --nostdlib.
11226 2002-06-07 Martin Baulig <martin@gnome.org>
11228 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
11229 (AddField): Set it to true when adding a non-static field.
11230 (DefineType): Use `have_nonstatic_fields' to find out whether we
11231 have non-static fields, not `Fields != null'.
11233 2002-06-02 Miguel de Icaza <miguel@ximian.com>
11235 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
11236 dereferencing a null on the static-field code path)
11238 2002-05-30 Martin Baulig <martin@gnome.org>
11240 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
11241 to take command line arguments. Use reflection to call the new
11242 custom `Initialize' function on the symbol writer and pass it the
11243 command line arguments.
11245 * driver.cs (--debug-args): New command line argument to pass command
11246 line arguments to the symbol writer.
11248 2002-05-28 Miguel de Icaza <miguel@ximian.com>
11250 * assign.cs (DoResolve): Forgot to do the implicit conversion to
11251 the target type for indexers and properties. Thanks to Joe for
11254 2002-05-27 Miguel de Icaza <miguel@ximian.com>
11256 * typemanager.cs (MethodFlags): returns the method flags
11257 (Obsolete/ShouldIgnore) that control warning emission and whether
11258 the invocation should be made, or ignored.
11260 * expression.cs (Invocation.Emit): Remove previous hack, we should
11261 not do this on matching a base type, we should do this based on an attribute
11263 Only emit calls to System.Diagnostics.Debug and
11264 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
11265 on the command line.
11267 * rootcontext.cs: Global settings for tracing and debugging.
11269 * cs-tokenizer.cs (define): New utility function to track
11270 defines. Set the global settings for TRACE and DEBUG if found.
11272 2002-05-25 Ravi Pratap <ravi@ximian.com>
11274 * interface.cs (Populate*): Pass in the TypeContainer as well as
11275 the DeclSpace as parameters so that we can create EmitContexts and
11276 then use that to apply attributes etc.
11278 (PopulateMethod, PopulateEvent, PopulateProperty)
11279 (PopulateIndexer): Apply attributes everywhere.
11281 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
11284 (ApplyAttributes): Update accordingly.
11286 We now apply interface attributes for all members too.
11288 2002-05-26 Miguel de Icaza <miguel@ximian.com>
11290 * class.cs (Indexer.Define); Correctly check if we are explicit
11291 implementation (instead of checking the Name for a ".", we
11292 directly look up if the InterfaceType was specified).
11294 Delay the creation of the PropertyBuilder.
11296 Only create the PropertyBuilder if we are not an explicit
11297 interface implementation. This means that explicit interface
11298 implementation members do not participate in regular function
11299 lookups, and hence fixes another major ambiguity problem in
11300 overload resolution (that was the visible effect).
11302 (DefineMethod): Return whether we are doing an interface
11305 * typemanager.cs: Temporary hack until we get attributes in
11306 interfaces (Ravi is working on that) and we get IndexerName
11307 support in interfaces.
11309 * interface.cs: Register the indexers as properties.
11311 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11312 warning, I have verified that this is a bug in the .NET runtime
11313 (JavaScript suffers of the same problem).
11315 * typemanager.cs (MemberLookup): When looking up members for
11316 interfaces, the parent of an interface is the implicit
11317 System.Object (so we succeed in searches of Object methods in an
11318 interface method invocation. Example: IEnumerable x; x.ToString
11321 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11323 * class.cs (Event): Events should also register if they do
11324 implement the methods that an interface requires.
11326 * typemanager.cs (MemberLookup); use the new GetInterfaces
11329 (GetInterfaces): The code used to lookup interfaces for a type is
11330 used in more than one place, factor it here.
11332 * driver.cs: Track the errors at the bottom of the file, we kept
11335 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11336 instance if the method we are calling is static!
11338 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11340 * attribute.cs (ApplyAttributes): Make this function filter out
11341 the IndexerName attribute (as that attribute in reality is never
11342 applied) and return the string constant for the IndexerName
11345 * class.cs (TypeContainer.Emit): Validate that all the indexers
11346 have the same IndexerName attribute, and if so, set the
11347 DefaultName attribute on the class.
11349 * typemanager.cs: The return value might contain other stuff (not
11350 only methods). For instance, consider a method with an "Item"
11351 property and an Item method.
11353 * class.cs: If there is a problem with the parameter types,
11356 2002-05-24 Ravi Pratap <ravi@ximian.com>
11358 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11359 looks at user defined conversion after making a call to
11360 StandardConversionExists - we need this for overload resolution.
11362 * expression.cs : Update accordingly the various method calls.
11364 This fixes 2 bugs filed against implicit user defined conversions
11366 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11368 * statement.cs: Track the result of the assignment.
11370 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11372 * expression.cs (MemberAccess): Improved error reporting for
11373 inaccessible members.
11375 2002-05-22 Martin Baulig <martin@gnome.org>
11377 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11378 itself with debugging support.
11380 2002-05-22 Martin Baulig <martin@gnome.org>
11382 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11383 Removed, this isn't needed anymore.
11385 2002-05-20 Martin Baulig <martin@gnome.org>
11387 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11388 be underlying type for an enum.
11390 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11392 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11393 that splits out the loading of just the core types.
11395 * rootcontext.cs (ResolveCore): Split the struct resolution in
11396 two, so we can load the enumeration underlying types before any
11399 * expression.cs (Is): Bandaid until we fix properly Switch (see
11400 bug #24985 for details).
11402 * typemanager.cs (ImplementsInterface): The hashtable will contain
11403 a null if there are no interfaces implemented.
11405 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11407 * cs-parser.jay (indexer_declarator): It is fine to have array
11410 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11412 * typemanager.cs: (RegisterBuilder): New function used to register
11413 TypeBuilders that implement interfaces. Since
11414 TypeBuilder.GetInterfaces (as usual) does not work with lame
11416 (AddUserType): register interfaces.
11418 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11419 dealing with TypeBuilder. Also, arrays are showing up as
11420 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11421 methods can not be invoked on them!
11423 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11424 (ImplicitReferenceConversionExists): Split out from
11425 StandardConversionExists.
11427 * expression.cs (As): We were only implementing one of the three
11428 cases for the as operator. We now implement them all.
11429 (Is): Implement the various other cases for Is as well.
11431 * typemanager.cs (CACHE): New define used to control if we want or
11432 not the FindMembers cache. Seems to have a negative impact on
11433 performance currently
11435 (MemberLookup): Nested types have full acess to
11436 enclosing type members
11438 Remove code that coped with instance/static returns for events, we
11439 now catch this in RealFindMembers.
11441 (RealFindMembers): only perform static lookup if the instance
11442 lookup did not return a type or an event.
11444 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11446 * assign.cs (CompoundAssign): We pass more semantic information
11447 now to Compound Assignments than we did before: now we have all
11448 the information at hand, and now we resolve the target *before* we
11449 do the expression expansion, which allows the "CacheValue" method
11450 to have the effect we intended (before, a [x] += 1 would generate
11451 two differen ArrayAccess expressions from the ElementAccess,
11452 during the resolution process).
11454 (CompoundAssign.DoResolve): Resolve target and original_source here.
11456 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11458 * expression.cs (ArrayAccess): dropped debugging information.
11460 * typemanager.cs: Small bug fix: I was always returning i_members,
11461 instead of one of i_members or s_members (depending on which had
11464 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11465 method is invoked before any code generation takes place, and it
11466 is a mechanism to inform that the expression will be invoked more
11467 than once, and that the method should use temporary values to
11468 avoid having side effects
11470 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11472 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11475 * expression.cs (Indirection, ArrayAccess): Add support for
11476 CacheTemporaries in these two bad boys.
11478 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11479 ldobj or ldind_ref.
11480 (StoreFromPtr): Handle stobj as well.
11482 * expression.cs (UnaryMutator): Share more code.
11484 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11485 down: I was not tracking the Filter function as well, which
11486 was affecting the results of the cache.
11488 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11490 * attribute.cs: Remove the hack to handle the CharSet property on
11493 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11495 * attribute.cs (DoResolve): More uglyness, we now only try to
11496 resolve the attribute partially, to extract the CharSet
11497 information (only if we are a StructLayout attribute). Otherwise
11499 (GetExtraTypeInfo): Add some code to conditionally kill in the
11500 future this. I am more and more convinced that the .NET
11501 framework has special code to handle the attribute setting on
11504 * expression.cs (IsParamsMethodApplicable): Revert my previous
11505 foreach change here, it was wrong.
11507 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11509 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11510 (pp_expr): do not abort on unknown input, just return.
11511 (eval): abort if there are pending chars.
11513 * attribute.cs (Attribute.Resolve): Positional parameters are
11514 optional. Deal with that case.
11516 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11517 the Ansi/Unicode/Auto information for the type.
11519 (TypeContainer.DefineType): instantiate the EmitContext here, as
11520 we will be using it during the type definition (to resolve
11521 attributes) and during the emit phase.
11523 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11524 to pull type information out of the attributes
11526 (Attribute.Resolve): track the constructor builder, and allow for
11527 multiple invocations (structs and classes will use this).
11529 * ecore.cs (MemberLookupFinal): new version with all the
11530 parameters customizable.
11532 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11533 constructors. Return if the result value is null (as the error
11534 would have been flagged already by MemberLookupFinal)
11536 Do not allow instances of abstract classes or interfaces to be
11539 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11540 We have to compare the assembly property here when dealing with
11541 FamANDAssem and Assembly access modifiers, because we might be
11542 creating an assembly from *modules* (that means that we are not
11543 getting TypeBuilders for types defined in other modules that are
11544 part of this assembly).
11546 (Method.Emit): If the method is marked abstract and has a body,
11549 (TypeContainer.DefineMembers): If both the defined member and the
11550 parent name match are methods, then do not emit any warnings: let
11551 the Method.Define routine take care of flagging warnings. But if
11552 there is a mismatch (method overrides something else, or method is
11553 overriwritten by something, then emit warning).
11555 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11556 set to null, this means `do not check for the return type on the
11559 (Method.Define): set the return type for the method signature to
11560 null, so that we get methods with the same name and parameters and
11561 different return types. This is used to flag warning 114 (you are
11562 hiding a method, and you probably want to use the new/override
11565 * typemanager.cs (MemberLookup): Implemented proper access
11566 control, closing a long standing set of bug reports. The problem
11567 was that the Framework only has two bits: Public and NonPublic,
11568 and NonPublic includes private and protected methods, but we need
11569 to enforce the FamANDAssem, FamOrAssem and Family.
11571 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11573 * statement.cs (GotoCase): Return true: Ammounts to giving up
11574 knowledge on whether we return or not, and letting the other case
11575 be responsible for it.
11577 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11579 * driver.cs: Do not load directories for each file processed, only
11580 do it if there is a pattern.
11582 * ecore.cs: Report readonly assigns here as well, as we might have
11583 been resolved only by MemberAccess.
11585 (SimpleName.SimpleNameResolve): Also be useful for LValue
11586 resolution. We need this to propagate assign to local readonly variables
11588 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11589 do not want to reuse potential criteria memory.
11591 * class.cs (MyEventBuilder): Set reflected_type;
11593 * ecore.cs (Constantify): Added support for constifying bools.
11595 (RootContext.LookupType): Added a cache for values looked up in
11596 the declaration space.
11598 * typemanager.cs (FindMembers): Now is a front-end to
11599 RealFindMembers, and provides a two-level hashtable-based cache to
11602 15% performance improvement: from 22.5 to 19.2 seconds.
11604 * expression.cs (IsParamsMethodApplicable): use foreach.
11605 (Invocation.DoResolve): ditto.
11606 (New.DoResolve): ditto.
11607 (ArrayCreation.DoResolve): ditto.
11609 * ecore.cs (FindMostEncompassingType): use foreach.
11611 * delegate.cs (NewDelegate.DoResolve): Use foreach
11613 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11614 (RemoveMethods): use foreach.
11616 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11617 nested foreach statements instead of for, and also break out of
11618 the inner loop once a match is found.
11620 (Invocation.OverloadResolve): Use foreach, simplify the code.
11622 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11624 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11625 we actually unwrap the expression to allow for extra information
11628 * expression.cs: Use Shr_Un on unsigned operations.
11630 2002-05-08 Ravi Pratap <ravi@ximian.com>
11632 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11633 applicable operators was not being considered correctly. This closes
11634 the bug Miguel reported.
11636 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11638 * attribute.cs: check that the type derives from System.Attribute
11639 and report the correct error in that case (moved the duplicate code to
11640 its own method, too).
11642 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11644 * attribute.cs: lookup attribute type name as the spec says: first the
11645 bare attribute name and then name + "Attribute" (nant compiles with
11646 mcs after this fix).
11648 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11650 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11651 Because of the way we parse things, we should try to see if a
11652 UIntConstant can fit in an integer.
11654 2002-05-07 Ravi Pratap <ravi@ximian.com>
11656 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11657 when we are in an explicit context.
11659 (ConvertReferenceExplicit): When converting from Iface type S to Class
11660 T make sure the rules are implemented as an OR.
11662 * parameter.cs (ParameterType): Make it a property for now although the
11663 purpose really isn't anything immediate.
11665 * expression.cs (Is*Applicable): Do better checking on the parameter type
11666 of a ref/out parameter. The ones from the system assemblies are already
11667 marked with the correct type so we don't need to do any correction.
11669 * ecore.cs (StandardConversionExists): Conversion from Interface types to
11670 the object type is standard too so include that.
11672 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11674 * ecore.cs (StandardConversionExists): Augment with missing code:
11675 deal with IntConstant, LongConstants and Enumerations.
11677 * assign.cs: Report the error, instead of failing silently
11679 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
11680 typecontainer that they are declared, because the
11681 typecontainer/namespace will have the list of using clauses that
11682 need to be applied.
11684 Assembly Attributes were escaping the normal registration
11687 (EmitCode): Apply attributes within an EmitContext that represents
11688 the container they were declared on.
11690 * cs-parser.jay: Track bases for structs. How did I get this wrong?
11692 2002-05-06 Ravi Pratap <ravi@ximian.com>
11694 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
11695 Revamp completely - make much cleaner as we now operate only
11698 (FindMostSpecificSource, FindMostSpecificTarget): New methods
11699 to implement the logic detailed in the spec more correctly.
11701 (UserDefinedConversion): Update accordingly.
11703 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11705 * statement.cs: Return flow analysis information up.
11707 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
11710 (token): Do not consume an extra character before calling
11713 2002-05-06 Piers Haken <piersh@friskit.com>
11715 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
11717 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11719 * class.cs (Constructor.Emit): Set the IsStatic flag in the
11720 EmitContext during the instance constructor initializer
11721 resolution, to stop access to instance variables.
11723 This is mandated by the spec, last paragraph of the `constructor
11724 initializers' section.
11726 2002-05-05 Miguel de Icaza <miguel@ximian.com>
11728 * cs-parser.jay, class.cs (Accessor): new class used to represent
11729 an accessor (get or set). In the past we used `null' to represent
11730 a missing accessor. But this is ambiguous because there was no
11731 way to tell in abstract indexers/properties if one of them was
11734 Now there is a way of addressing that.
11736 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
11737 instead of FindMembers.
11739 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
11740 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
11742 * attribute.cs: Treat indexers and properties as the same in terms
11743 of applying attributes
11745 * ecore.cs (FindMostEncompassedType): Use statically initialized
11746 EmptyExpressions()s like we do elsewhere to avoid creating useless
11747 objects (and we take this out of the tight loop).
11749 (GetConversionOperators): Move the code to extract the actual
11750 operators to a separate routine to clean things up.
11752 2002-05-04 Miguel de Icaza <miguel@ximian.com>
11754 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
11755 events are always registered FieldBuilders.
11757 * class.cs (FieldBase): New class shared by Fields
11759 * delegate.cs: If we are a toplevel delegate, use our full name.
11760 If we are a nested delegate, then only use our tail name.
11762 2002-05-02 Ravi Pratap <ravi@ximian.com>
11764 * expression.cs (IsApplicable): Ensure that we add the "&" to
11765 ref/out types before comparing it with the type of the argument.
11767 (IsParamsMethodApplicable): Ditto.
11769 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
11772 * delegate.cs : Handle the case when we have more than one applicable
11773 method. Flag an error only when we finish checking all.
11775 2002-05-02 Miguel de Icaza <miguel@ximian.com>
11777 * expression.cs: Add support for boolean static initializers.
11779 2002-05-01 Miguel de Icaza <miguel@ximian.com>
11781 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
11783 * parameter.cs (ComputeParameterTypes,
11784 ComputeAndDefineParameterTypes): Better error handling: now we
11785 clear the `types' cache if we fail during any of the type lookups.
11786 We also return the status code correctly to our caller
11788 * delegate.cs: If we fail to define a delegate, abort the extra
11791 * expression.cs (Binary.ResolveOperator): for
11792 operator==(object,object) and operator !=(object, object) we also
11793 have to verify that there is an implicit conversion from one to
11796 (ArrayAccess.DoResolve): Array Access can operate on
11799 2002-04-30 Miguel de Icaza <miguel@ximian.com>
11801 * assign.cs (CompoundAssign): A new class used as a "flag" that
11802 the assignment actually is happening as part of a compound
11803 assignment operator.
11805 During compound assignment, a few new rules exist to enable things
11812 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
11813 to the type of x) if y is implicitly convertible to the type of x,
11814 and the operator is a builtin operator and the return type of the
11815 operator is explicitly convertible to the type of x.
11817 * rootcontext.cs: Reset warning level to 2. 4 catches various
11818 "interesting" features in mcs, we must clean this up at some
11819 point, but currently am trying to kill other bugs ;-)
11821 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
11822 in container classes as well.
11824 * expression.cs (Binary.ResolveOperator): Handle string case
11825 before anything else (as operator overloading does emit an error
11826 before doing anything else).
11828 This code could go away when we move to a table driven model, but
11829 i could not come up with a good plan last night.
11831 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
11833 * typemanager.cs (CSharpName): reimplementation using regex.
11834 * class.cs: added null check for fields in Emit
11835 * rootcontext.cs: set warninglevel to 4
11837 2002-04-29 Miguel de Icaza <miguel@ximian.com>
11839 * typemanager.cs (CSharpName): reimplemented with Lupus
11842 2002-04-28 Miguel de Icaza <miguel@ximian.com>
11844 * statement.cs (If): correclty implement Resolve, because we were
11845 not catching sem errors in there. The same process is needed
11847 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
11850 (Statement.Warning_DeadCodeFound): Factorize code.
11851 (While): Report dead code here too.
11853 (Statement): Added Resolve virtual method to allow
11854 for resolution split from the emit code.
11856 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11858 * statement.cs (EmitBoolExpression): No longer try to resolve the
11860 (MakeBoolean): New utility function that resolve, implicitly
11861 converts to boolean and tags the expression.
11864 (If, Do): Implement dead code elimination.
11865 (While): Implement loop inversion
11867 (Do, While, For, If): Resolve the expression prior to calling our
11870 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
11873 - added method Report28 (warning: program has more than one entry point)
11874 - added method IsEntryPoint, implements paragraph 10.1 of the spec
11875 - modified method Method.Define, the part at the end of the method
11877 * rootcontext.cs: added static public Location EntryPointLocation;
11879 * ../errors/cs0028.cs : Add test case for the above warning.
11882 - modified method CSharpName to allow arrays of primitive type to
11883 be printed nicely (e.g. instead of System.Int32[][] it now prints
11885 - added method CSharpSignature: returns the signature of a method
11886 in string format to be used in reporting errors, warnings, etc.
11888 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
11891 2002-04-26 Ravi Pratap <ravi@ximian.com>
11893 * delegate.cs (Define): Fix extremely silly bug where I was
11894 setting the type of the 'object' parameter of the BeginInvoke
11895 method to System.IAsyncResult instead of System.Object ;-)
11897 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11899 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
11902 (Constructor.Emit): return if we fail to initialize the
11903 constructor. Another door closed!
11905 * expression.cs (New.DoResolve): Improve error message (from -6 to
11906 1501). Use DeclaredOnly lookup to find the exact constructor.
11908 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
11909 loop. This is useful.
11911 * cs-parser.jay: Adjust the default parameters so that destructors
11912 have the proper signature.
11914 2002-04-26 Martin Baulig <martin@gnome.org>
11916 * driver.cs (LoadAssembly): If `assembly' contains any characters
11917 which are only valid in path names and not in assembly names
11918 (currently slash, backslash and point), use Assembly.LoadFrom ()
11919 instead of Assembly.Load () on the `assembly' (before iteration
11920 over the link_paths).
11922 2002-04-26 Martin Baulig <martin@gnome.org>
11924 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
11926 2002-04-25 Miguel de Icaza <miguel@ximian.com>
11928 * class.cs (Property): use the new typemanager.MemberLookup
11930 (TypeContainer.MemberLookup): Implement using the
11931 TypeManager.MemberLookup now.
11933 * typemanager.cs: Make MemberLookup a function of the TypeManager,
11934 and return MemberInfos, so that these can be used without an
11935 EmitContext (what we had before).
11937 2002-04-24 Miguel de Icaza <miguel@ximian.com>
11939 * expression.cs: Fix the case where the argument to params if the
11940 type of the params. I omitted handling this before. Fixed
11942 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11944 * driver.cs: Call BootCorlib_PopulateCoreType
11946 * class.cs (Property.CheckBase): Check for properties only, not
11949 * interface.cs: Temporary hack: try/catch around the
11950 CustomAttributeBuilder, because I am getting an exception that I
11953 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
11954 types whose definitions are required to be there (attributes are
11955 defined before standard types).
11957 Compute definitions as we boot the various types, as they are used
11958 immediately (value_type class will need object_type, but if we do
11959 not initialize object_type, we will pass a null, which will let
11960 the runtime pick the System.Object from the existing corlib, which
11961 is not what we want).
11963 2002-04-22 Patrik Torstensson <totte@labs2.com>
11965 * cs-tokenizer.cs: fixed a number of trim() issues.
11967 2002-04-22 Ravi Pratap <ravi@ximian.com>
11969 * expression.cs (Argument.Type): Ensure that we return the correct
11970 type when we have out or ref parameters [in which case we
11973 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11975 * class.cs (Property, Indexer): Allow extern modifier in there.
11977 * typemanager.cs (InitBaseTypes): Initializes object_type and
11978 value_type, since those will be used early on during the bootstrap
11979 process to compile corlib.
11981 (InitCoreTypes): Move code from here to InitBaseTypes.
11983 2002-04-21 Miguel de Icaza <miguel@ximian.com>
11985 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
11986 single-dimension arrays as using the ldlen opcode.
11988 Daniel Lewis discovered this optimization.
11990 * typemanager.cs: Add signature for System.Array::get_Length
11992 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11994 * statement.cs: report the error when the foreach does not apply to an
11995 array nor a collection.
11997 2002-04-19 Miguel de Icaza <miguel@ximian.com>
11999 * expression.cs: Add implicit conversions to the operator ~.
12001 * constant.cs (DecimalConstant.Emit): Emit decimal value.
12003 * typemanager.cs: Locate the decimal constructor.
12005 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12007 * attribute.cs: use the new property of TypeOf.
12008 * expression.cs: added 'get' property around typearg.
12010 These changes fix a build breaker reported by NickD. Is this the
12011 correct way to fix? If not, please, revert my changes and make it
12014 2002-04-17 Miguel de Icaza <miguel@ximian.com>
12016 * attribute.cs: Add support for typeof in attribute invocations.
12017 I am not sure that this is right though.
12019 2002-04-14 Duncan Mak <duncan@ximian.com>
12021 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
12022 Binary.Operator.Division case.
12024 2002-04-13 Ravi Pratap <ravi@ximian.com>
12026 * class.cs (DefineType): Ensure that we do a proper check on
12027 attribute types and also register it with the TypeManager.
12029 (TypeContainer.Targets): The default for attribute types is
12030 AttributeTargets.All.
12032 * attribute.cs (ApplyAttributes): Registering the attribute type
12033 is done elsewhere, not when we discover we have a Usage attribute.
12035 2002-04-12 Ravi Pratap <ravi@ximian.com>
12037 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
12038 and get rid of is_delegate parameter.
12040 * everywhere : update.
12042 2002-04-12 Ravi Pratap <ravi@ximian.com>
12044 * cs-parser.jay (compilation_unit): Revamp completely to use
12045 some new ideas that I got from Rhys' grammar to solve the problems
12046 with assembly level attributes.
12048 (outer_declaration): New grammar production.
12050 (attribute_sections): Add.
12052 (opt_attributes): Base on attribute_sections
12054 (namespace_declaration): Allow opt_attributes to tackle the case
12055 when we have assembly level attributes - we are clever in this
12058 * attribute.cs (ApplyAttributes): Do not worry about assembly
12059 attributes in the non-global context.
12061 * rootcontext.cs (AddGlobalAttributes): Go back to using this
12062 instead of SetGlobalAttributes.
12064 * class.cs, rootcontext.cs : Ensure we define and generate
12065 attribute types before anything else.
12067 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
12068 and flag the new error -20 for the case when the attribute type
12069 does not have valid targets specified. csc does not catch this.
12071 * ../errors/errors.txt : update for error # -20
12073 2002-04-11 Ravi Pratap <ravi@ximian.com>
12075 * support.cs (InternalParameters.ParameterModifier): Do some null
12076 checking and return sane values.
12078 * class.cs (Method.Define): If we are a PInvoke method, ensure
12079 that we are static and extern. Report error # 601
12081 * ../errors/cs0601.cs : Add test case for the above error.
12083 2002-04-07 Ravi Pratap <ravi@ximian.com>
12085 * rootcontext.cs (attribute_types): We need to keep type of
12086 all attribute types separately and emit code for them first.
12088 (RegisterAttribute) : Implement.
12090 * class.cs (DefineType): Check if the current Type is a custom
12091 attribute type and register it accordingly.
12093 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
12094 adding the first attribute twice and rename to
12096 (SetGlobalAttributes): this.
12098 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
12101 * attribute.cs (ApplyAttributes): Take an additional argument telling us
12102 if we are processing global arguments. Hmm, I am unsure of this.
12104 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12106 * expression.cs: added static array of strings to avoid calling
12107 Enum.ToString () for Operator in Binary. Significant recover of
12110 2002-04-10 Miguel de Icaza <miguel@ximian.com>
12112 * class.cs (FindMembers): Allow the Builders of the various
12113 members to be null. If they are skip them. This only happens
12114 during the PInvoke declaration.
12116 2002-04-09 Miguel de Icaza <miguel@ximian.com>
12118 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
12119 failure, so we do not keep going afterwards.
12121 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
12122 wanted to pass `false' as the `is_delegate' argument. If this is
12123 the case, why not use delegate_type == null to mean `is_delegate =
12124 false' and anything else as is_delegate = true.
12126 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
12128 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
12129 code for the section, not the beginning of the tests.
12131 2002-04-08 Miguel de Icaza <miguel@ximian.com>
12133 * cfold.cs: Handle operator + (Enum x, Underlying x)
12135 * expression.cs (Binary): same. Warn about errors where we have
12136 Enum/Enum in operator + as well.
12138 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
12141 - added support for switch(bool)
12142 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
12143 - add TableSwitchEmit() to handle table-based switch statements
12145 2002-04-05 Ravi Pratap <ravi@ximian.com>
12147 * expression.cs (Invocation.OverloadResolve): Factor out code which
12148 does parameter compatibility checking with arguments so that we can
12149 re-use the code even from Delegate.VerifyApplicability
12151 (VerifyArgumentsCompat): Move above code here.
12153 * delegate.cs (VerifyApplicability): Get rid of duplicate code
12154 and instead make a call to the above method.
12156 2002-03-31 Ravi Pratap <ravi@ximian.com>
12158 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
12159 We use it to keep track of classes which are attribute types.
12161 2002-04-02 Miguel de Icaza <miguel@ximian.com>
12163 * delegate.cs (Delegate.Define): Correctly define the types in the
12164 presence of fixed and array parameters.
12166 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
12169 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
12170 include NonPublic after the first iteration.
12172 * class.cs (Indexer.CheckBase): Only check if both parents are
12175 * cs-parser.jay (accessor_body): If empty, set to null.
12177 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
12178 same code path here to resolve constants names that we did have in
12179 MemberAccess.DoResolve. There is too much code duplicated here.
12181 2002-04-01 Miguel de Icaza <miguel@ximian.com>
12183 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
12185 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
12188 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
12189 tokens, numbers and strings.
12191 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
12194 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
12195 asyncronous parameters and the regular parameters.
12197 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
12198 specify the target directory.
12200 * expression.cs: (This.DoResolve): Simplify
12201 (As.Emit): Optimize, do not generate IsInst if the expression is
12202 always of the given type.
12204 (Is.DoResolve): Bug fix, we were reporting both always/never for
12207 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
12208 creating too many unnecessary arrays.
12210 2002-03-31 Miguel de Icaza <miguel@ximian.com>
12212 * class.cs (EmitFieldInitializer): Use Assign expression to assign
12213 fields instead of rolling our own initializer. Takes care of all
12214 implicit conversions, and drops unnecessary static checks/argument.
12216 2002-03-31 Dick Porter <dick@ximian.com>
12218 * driver.cs: use the GetDirectories() return values properly, and
12219 use "/" as path separator.
12221 2002-03-30 Miguel de Icaza <miguel@ximian.com>
12223 * expression.cs (Unary): Optimize - - expr into expr.
12224 (Binary): Optimize a + (-b) into a -b.
12226 * codegen.cs (CodeGen): Made all methods static.
12228 2002-03-29 Miguel de Icaza <miguel@ximian.com>
12232 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
12233 TypeBuilder property.
12235 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
12238 * tree.cs: Removed the various RecordXXXX, and replaced with a
12239 single RecordDecl. Removed all the accessor methods, and just
12240 left a single access point Type
12242 * enum.cs: Rename DefineEnum to DefineType.
12244 * decl.cs: New abstract method `DefineType' used to unify the
12245 Defines for Enumerations, Interfaces, TypeContainers and
12248 (FindType): Moved LookupInterfaceOrClass here. Moved the
12249 LookupBaseClasses method that used to live in class.cs and
12250 interface.cs here, and renamed to FindType.
12252 * delegate.cs: Implement DefineType. Take advantage of the
12253 refactored pattern for locating the parent builder without taking
12254 the parent_builder argument (which we know does not work if we are
12255 nested, and triggering a toplevel definition).
12257 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12259 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
12260 accessibility of a member has changed during override and report
12263 * class.cs (Method.Define, Property.Define): Only complain on
12264 overrides if the method is private, any other accessibility is
12265 fine (and since we just checked the permission is the same, we are
12268 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
12269 and elif are processed always. The other pre-processing
12270 directives are only processed if we are "taking" the path
12272 2002-03-29 Martin Baulig <martin@gnome.org>
12274 * class.cs (Method.Emit): Only emit symbolic debugging info if the
12275 current location is not Null.
12277 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
12278 a separate method so we can profile it.
12280 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
12281 `span.Seconds' are just seconds, but no minutes or hours.
12282 (MainDriver): Profile the CodeGen.SaveSymbols calls.
12284 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12286 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
12287 Remove the gratuitous set of Final:
12289 // If an interface implementation, then we can set Final.
12290 if (((flags & MethodAttributes.Abstract) == 0) &&
12291 implementing.DeclaringType.IsInterface)
12292 flags |= MethodAttributes.Final;
12294 I do not know what I was smoking when I used that.
12297 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
12298 step into fixing the name resolution issues for delegates and
12299 unifying the toplevel name resolution.
12301 2002-03-28 Martin Baulig <martin@gnome.org>
12303 * class.cs (Method.Emit): If we have a symbol writer, call its
12304 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
12305 tell it about the current method.
12307 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
12308 writer that we're going to emit the first byte of IL code for a new
12309 statement (a new source line).
12310 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12311 EmitContext.Mark() before emitting any code.
12313 * location.cs (SymbolDocument): Return null when we're Null.
12315 * statement.cs (Statement): Moved the `Location loc' variable here.
12316 (Statement.EmitBoolExpression): If we have a symbol writer, call
12317 ec.Mark() before emitting any code to tell it that we're at the
12318 beginning of a new statement.
12319 (StatementExpression): Added `Location' argument to the constructor.
12320 (Block): Added public readonly variable `StartLocation' and public
12321 variable `EndLocation'. The latter is to be set using SetEndLocation().
12322 (Block): Added constructor which takes a start and end location.
12323 (Block.SetEndLocation): New method. This sets the end location.
12324 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12325 local variables we create.
12326 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12327 each statement and do also mark the begin and end of the block.
12329 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12330 tell it the current lexer.Location, use Location.Null for the end of the
12332 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12333 current block, set its end location using SetEndLocation().
12334 (statement_expression): StatementExpression constructor now takes the
12335 lexer.Location as additional argument.
12336 (for_statement, declare_local_variables): Likewise.
12337 (declare_local_variables): When creating a new implicit block, use the
12338 new Block constructor and pass it the lexer.Location.
12340 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12342 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12343 members also on the parent interfaces recursively.
12345 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12347 * report.cs: Use new formats, since Gonzalo finished the missing
12350 * expression.cs (Binary.ResolveOperator): added missing operator|
12351 operator& and operator^ for bool/bool.
12353 * cs-parser.jay: CheckDef now takes a Location argument that is
12354 used to report errors more precisly (instead of reporting the end
12355 of a definition, we try to track something which is a lot closer
12356 to the source of the problem).
12358 * cs-tokenizer.cs: Track global token use, so we can properly flag
12359 the use of #define/#undef after the first token has been seen.
12361 Also, rename the reportXXXX to Error_DescriptiveName
12363 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12364 TypeContainer, so that Enum and Interface can use this too.
12366 * class.cs (TypeContainer.LookupInterfaceOrClass,
12367 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12368 `builder' argument. Typically this was used to pass the parent
12369 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12372 The problem is that a nested class could trigger the definition of
12373 a toplevel class, and the builder would be obviously wrong in that
12376 So we drop this argument, and we compute dynamically the
12377 TypeBuilder/ModuleBuilder (the correct information was available
12378 to us anyways from DeclSpace.Parent)
12380 * interface.cs (Interface.DefineInterface): Drop builder
12381 parameter cleanup like class.cs
12383 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12386 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12389 (Try.Emit): Propagate the returns value from the statement.
12391 (Return.Emit): Even if we are leavning
12393 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12395 * modifiers.cs: Fix the computation of MethodAttributes flags.
12397 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12399 * driver.cs: allow compilation of files that start with '/'.
12400 Add a default case when checking the argument of --target.
12402 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12404 * interface.cs: Implement the same search algorithm for types in
12405 the interface code.
12407 * delegate.cs: Do not allow multiple definition.
12409 * Recovered ChangeLog that got accidentally amputated
12411 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12413 * rootcontext.cs: Load manually enum to allow core classes to
12414 contain enumerations.
12416 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12417 Update to new static methods in TypeManager.
12419 * typemanager.cs (GetMethod, GetConstructor): Use our
12420 implementation of FindMembers to find the members, since during
12421 corlib compilation, the types are TypeBuilders and GetMethod and
12422 GetConstructor do not work.
12424 Make all methods in TypeManager static.
12426 (InitCodeHelpers): Split the functionality from
12427 the InitCodeTypes function.
12429 * driver.cs: Call InitCodeHelpers after we have populated the
12432 * cs-parser.jay (delegate_declaration): we did not used to compute
12433 the delegate name correctly for void delegates.
12435 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12437 * rootcontext.cs (RootContext): Init the interface_resolve_order
12438 and type_container_resolve_order always.
12440 (ResolveCore, BootstrapCorlib_ResolveClass,
12441 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12442 compiler when compiling with --nostdlib
12444 * class.cs (TypeContainer.DefineType): Check that our parent is
12445 not null. This test is most important when we are bootstraping
12448 * codegen.cs: Split out the symbol writing code.
12450 2002-03-25 Martin Baulig <martin@gnome.org>
12452 * driver.cs (-g): Made -g an alias for --debug.
12454 2002-03-24 Martin Baulig <martin@gnome.org>
12456 * codegen.cs (SymbolWriter): New public variable. Returns the
12457 current symbol writer.
12458 (CodeGen): Added `bool want_debugging_support' argument to the
12459 constructor. If true, tell the ModuleBuild that we want debugging
12460 support and ask it for the ISymbolWriter.
12461 (Save): If we have a symbol writer, call it's Close() method after
12462 saving the assembly.
12464 * driver.c (--debug): New command line argument to create a
12465 debugger information file.
12467 * location.cs (SymbolDocument): New public property. Returns an
12468 ISymbolDocumentWriter object for the current source file or null
12469 if we don't have a symbol writer.
12471 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12473 * driver.cs (LoadAssembly): Correctly return when all the paths
12474 have been tried and not before.
12476 * statement.cs (Switch.Emit): return the actual coverage for this
12477 statement (returns/not-returns)
12479 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12480 switch of the statement if we are the last switch section. That
12481 kills two problems: try/catch problems (we used to emit an empty
12482 nop at the end) and switch statements where all branches would
12485 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12487 * driver.cs: Add default assemblies (the equivalent to the
12488 Microsoft CSC.RSP file)
12490 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12491 also update tokens_seen and set it to false.
12493 * driver.cs: Implement --recurse for Mike.
12495 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12496 correctly splitting out the paths.
12498 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12500 * interface.cs (Interface.PopulateProperty): Instead of using
12501 `parent' as the declaration space for the set parameters, use
12504 * support.cs (InternalParameters): InternalParameters constructor
12505 takes a DeclSpace instead of a TypeContainer.
12507 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12508 types are being initialized, load the address of it before calling
12511 (New): Provide a mechanism to disable the generation of local
12512 value type temporaries when the caller will be providing us with
12513 an address to store it.
12515 (ArrayCreation.EmitDynamicInitializers): Use it.
12517 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12519 * expression.cs (Invocation.EmitArguments): Only probe for array
12520 property if there is more than one argument. Sorry about that.
12522 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12523 empty param arrays.
12525 * class.cs (Method.LabelParameters): Fix incorrect code path that
12526 prevented the `ParamArrayAttribute' from being applied to the
12529 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12531 * support.cs (ReflectionParameters): Correctly compute whether the
12532 last argument is a params array. Fixes the problem with
12535 * typemanager.cs: Make the assemblies array always be non-null
12536 (empty, but non-null)
12538 * tree.cs (RecordDecl): New function that abstracts the recording
12539 of names. This reports error 101, and provides a pointer to the
12540 previous declaration. Fixes a crash in the compiler.
12542 * cs-parser.jay (constructor_declaration): Update to new grammar,
12543 and provide a constructor_body that can be empty.
12545 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12547 * driver.cs: Add support for --resources.
12549 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12550 Make all types for the various array helper methods be integer.
12552 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12553 CheckState to ConvCast.
12555 (ConvCast): Now it takes a `checked' state argument, to avoid
12556 depending on the emit context for the conversion, and just using
12557 the resolve time setting.
12559 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12560 instead of Invocation.EmitArguments. We do not emit the original
12561 arguments, instead we emit those which have been converted to
12562 unsigned int expressions.
12564 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12566 * codegen.cs: ditto.
12568 * expression.cs (LocalVariableReference): Drop the use of the
12569 Store function that depended on the variable index.
12571 * statement.cs (VariableInfo): Drop the `Idx' property from this
12572 class, as this is not taking into account the indexes for
12573 temporaries tat we generate during the execution, getting the
12576 * class.cs: First emit class initializers, then call the parent
12579 * expression.cs (Binary): Fix opcode emision.
12580 (UnaryMutator.EmitCode): Support checked code generation
12582 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12583 matches for events for both the Static and Instance scans,
12584 pointing to the same element. Fix that.
12586 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12588 * rootcontext.cs (ResolveTree): Always set the
12589 interface_resolve_order, because nested interfaces will be calling
12592 * class.cs (GetInterfaceOrClass): Track the same resolution
12593 process used by TypeManager.LookupType. This fixes the nested
12594 type lookups in class declarations (separate path from
12597 (TypeContainer.DefineType): Also define nested interfaces.
12598 (TypeContainer.RegisterOrder): New public function used to
12599 register the order in which child interfaces need to be closed.
12601 Nested interfaces need to be closed after their parents have been
12604 * interface.cs (InterfaceAttr): Put all the logic for computing
12605 the interface attribute here.
12607 (DefineInterface): Register our interface order with the
12608 RootContext or with the TypeContainer depending on the case.
12610 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12612 * cs-parser.jay: rework foreach statement to work with the new
12613 changes to the policy on SimpleNames.
12615 * report.cs: support Stacktrace on warnings as well.
12617 * makefile: drop --unsafe and /unsafe from the compile.
12619 2002-03-13 Ravi Pratap <ravi@ximian.com>
12621 * ecore.cs (StandardConversionExists): Modify to take an Expression
12622 as the first parameter. Ensure we do null -> reference type conversion
12625 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12626 temporary Expression objects.
12628 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12630 * interface.cs: workaround bug in method overloading resolution
12631 (there is already a bugzilla bug for it).
12633 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12635 We could also solve this problem by having a separate path for
12636 performing type lookups, instead of DoResolve, we could have a
12637 ResolveType entry point, and only participating pieces of the
12638 production (simplename, deref, array) would implement this.
12640 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12641 signal SimpleName to only resolve type names and not attempt to
12642 resolve anything else.
12644 * expression.cs (Cast): Set the flag.
12646 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12648 * class.cs: Only report 108 if there is no `new' modifier.
12650 * cs-parser.jay: rework foreach statement to work with the new
12651 changes to the policy on SimpleNames.
12653 * report.cs: support Stacktrace on warnings as well.
12655 * makefile: drop --unsafe and /unsafe from the compile.
12657 2002-03-11 Miguel de Icaza <miguel@ximian.com>
12659 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12660 lookups here, instead of doing that at parse time. This means
12661 that our grammar will not introduce `LocalVariableReferences' as
12662 expressions at this point. That solves the problem of code like
12666 static void Main ()
12670 This is only half the fix. The full fix requires parameters to
12671 also be handled in this way.
12673 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
12674 makes the use more obvious of the DeclSpace. The
12675 ec.TypeContainer.TypeBuilder is now only used to pull the
12676 TypeBuilder for it.
12678 My theory is that I can get rid of the TypeBuilder completely from
12679 the EmitContext, and have typecasts where it is used (from
12680 DeclSpace to where it matters).
12682 The only pending problem is that the code that implements Aliases
12683 is on TypeContainer, and probably should go in DeclSpace.
12685 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12686 lookups here, instead of doing that at parse time. This means
12687 that our grammar will not introduce `LocalVariableReferences' as
12688 expressions at this point. That solves the problem of code like
12692 static void Main ()
12696 This is only half the fix. The full fix requires parameters to
12697 also be handled in this way.
12699 * class.cs (Property.DefineMethod): When implementing an interface
12700 method, set newslot, when implementing an abstract method, do not
12701 set the flag (before we tried never setting it, or always setting
12702 it, which is the difference).
12703 (Indexer.DefineMethod): same.
12704 (Method.DefineMethod): same.
12706 * ecore.cs: Only set the status used flag if we get back a Field.
12708 * attribute.cs: Temporary hack, so Paolo can keep working.
12710 2002-03-08 Ravi Pratap <ravi@ximian.com>
12712 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
12713 the unmanaged type in the case we have a MarshalAs attribute.
12715 (Resolve): Handle the case when we are parsing the special MarshalAs
12716 attribute [we need to store the unmanaged type to use later]
12718 * typemanager.cs (marshal_as_attr_type): Built in type for the
12719 MarshalAs Attribute.
12721 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
12722 on parameters and accordingly set the marshalling info.
12724 2002-03-09 Miguel de Icaza <miguel@ximian.com>
12726 * class.cs: Optimizing slightly by removing redundant code after
12727 we switched to the `NoTypes' return value.
12728 (Property.DefineMethod): use NoTypes here too.
12730 This fixes the bug I introduced in my last batch of changes.
12732 2002-03-05 Ravi Pratap <ravi@ximian.com>
12734 * tree.cs (RecordEnum): Add. We now keep track of enums too.
12736 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
12737 Enums since those are types too.
12739 * cs-parser.jay (enum_declaration): Record enums as we parse them.
12741 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
12742 thanks to a call during the lookup process.
12744 2002-03-07 Miguel de Icaza <miguel@ximian.com>
12746 * statement.cs (Foreach): Lots of work to accomodate a particular
12747 kind of foreach statement that I had not kept in mind. It is
12748 possible to have foreachs on classes that provide a GetEnumerator
12749 method that return objects that implement the "pattern" for using
12750 a foreach, there is no need to support GetEnumerator
12753 This is needed to compile nant.
12755 * decl.cs: Only report 114 if the member is not `Finalize' and if
12756 the warning level is at least 2.
12758 * class.cs: Moved the compare function from Method to
12761 (MethodSignature.InheritableMemberSignatureCompare): Add new
12762 filter function that is used to extract inheritable methods from a
12765 (Method.Define): Use the new `inheritable_method_signature_filter'
12768 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
12771 2002-03-06 Miguel de Icaza <miguel@ximian.com>
12773 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
12775 * cs-parser.jay: Add opt_semicolon to the interface declaration.
12777 * expression.cs: Pass location information to
12778 ConvertImplicitStandard.
12780 * class.cs: Added debugging code to track return values from
12783 2002-03-05 Miguel de Icaza <miguel@ximian.com>
12785 * expression.cs (Is.DoResolve): If either side of the `is' is an
12786 interface, do not flag the warning.
12788 * ecore.cs (ImplicitReferenceConversion): We need a separate test
12791 * report.cs: Allow for --fatal to be used with --probe.
12793 * typemanager.cs (NoTypes): Move the definition for the empty Type
12796 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
12798 (TypeContainer.DefineProxy): New function used to proxy to parent
12799 implementations when implementing interfaces.
12800 (TypeContainer.ParentImplements): used to lookup if our parent
12801 implements a public function that is required by an interface.
12802 (TypeContainer.VerifyPendingMethods): Hook this up.
12804 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
12805 `modules' and `assemblies' arraylists into arrays. We only grow
12806 these are the very early start up of the program, so this improves
12807 the speedof LookupType (nicely measured).
12809 * expression.cs (MakeByteBlob): Replaced unsafe code with
12810 BitConverter, as suggested by Paolo.
12812 * cfold.cs (ConstantFold.Binary): Special case: perform constant
12813 folding of string concatenation, but if either side is a string,
12814 and the other is not, then return null, and let the runtime use
12815 the concatenation on the string plus the object (using
12816 `Object.ToString').
12818 2002-03-04 Miguel de Icaza <miguel@ximian.com>
12820 Constant Folding has been implemented now.
12822 * expression.cs (Unary.Reduce): Do not throw an exception, catch
12823 the error instead on types that are not supported in one's
12826 * constant.cs (Constant and all children): New set of functions to
12827 perform implict and explicit conversions.
12829 * ecore.cs (EnumConstant): Implement the new functions to perform
12830 conversion by proxying to the child expression.
12832 * codegen.cs: (ConstantCheckState): Constant evaluation has its
12833 own separate setting that can not be turned off from the command
12834 line using --unchecked or --checked and is only controlled using
12835 the checked/unchecked statements and expressions. This setting is
12836 used by the constant folder to flag errors.
12838 * expression.cs (CheckedExpr, UncheckedExpr): Set the
12839 ConstantCheckState as well.
12841 During Resolve, they also have to flag the state, because the
12842 constant folder runs completely in the Resolve phase.
12844 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
12847 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12849 * cfold.cs: New file, this file contains the constant folder.
12851 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
12852 argument to track whether we are using the resulting address to
12853 load or store a value and provide better error messages.
12855 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
12856 new AddressOf arguments.
12858 * statement.cs (Foreach.EmitCollectionForeach): Update
12860 * expression.cs (Argument.Emit): Call AddressOf with proper
12861 arguments to track usage.
12863 (New.DoEmit): Call AddressOf with new arguments.
12865 (Unary.Emit): Adjust AddressOf call.
12867 2002-03-01 Ravi Pratap <ravi@ximian.com>
12869 * cs-parser.jay (member_access): Change the case for pre-defined types
12870 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
12873 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
12876 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
12877 essentially like methods and apply attributes like MethodImplOptions to them too.
12879 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
12882 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
12883 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
12886 * Update code everywhere accordingly.
12888 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
12890 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
12892 2002-02-28 Ravi Pratap <ravi@ximian.com>
12894 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
12895 try performing lookups against those instead of jumping straight into using
12896 the 'using' clauses.
12898 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
12900 (LookupType): Perform lookups in implicit parents too.
12902 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
12903 sequence as RootContext.LookupType.
12905 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
12906 the various cases of namespace lookups into this method.
12908 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12910 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
12911 in positional arguments)
12913 * class.cs (Operator): Update the AllowedModifiers to contain
12916 * cs-parser.jay: Update operator declaration to allow for the
12917 operator body to be empty.
12919 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
12922 2002-02-27 Miguel de Icaza <miguel@ximian.com>
12924 * class.cs (Method.Emit): Label parameters.
12926 * driver.cs: Return 1 or 0 as the program exit code.
12928 2002-02-26 Miguel de Icaza <miguel@ximian.com>
12930 * expression.cs: Special case the `null' object when trying to
12931 auto-compute the type, as anything can be explicitly converted to
12934 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
12935 spotting this Paolo.
12937 (Expression.ImplicitNumericConversion): Perform comparissions of
12938 the type using the underlying type in the case of an enumeration
12939 rather than using the enumeration type for the compare.
12941 Cope with the underlying == type case, which is not possible to
12944 (Expression.ConvertNumericExplicit): Perform comparissions of
12945 the type using the underlying type in the case of an enumeration
12946 rather than using the enumeration type for the compare.
12948 * driver.cs: If the user does not supply an extension, assume .exe
12950 * cs-parser.jay (if_statement): Rewrote so that we can track the
12951 location for the if statement.
12953 * expression.cs (Binary.ConstantFold): Only concat strings when
12954 the operation is "+", not everything ;-)
12956 * statement.cs (Statement.EmitBoolExpression): Take a location
12958 (If, While, Do): Track location.
12960 * expression.cs (Binary.ResolveOperator): In the object + string
12961 case, I was missing a call to ConvertImplicit
12963 2002-02-25 Ravi Pratap <ravi@ximian.com>
12965 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
12966 Location arguments. Ensure we use RootContext.LookupType to do our work
12967 and not try to do a direct Type.GetType and ModuleBuilder.GetType
12969 * interface.cs (PopulateMethod): Handle the type of the parameter being
12972 * expression.cs (Invocation.BetterFunction): Handle the case when we
12973 have a params method with no fixed arguments and a call is made with no
12976 2002-02-25 Miguel de Icaza <miguel@ximian.com>
12978 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
12979 the verbatim-string-literal
12981 * support.cs (InternalParameters.ParameterModifier): handle null
12983 (InternalParameters.ParameterType): ditto.
12985 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
12986 duplicating the name of the variable parameter.
12987 (GetParameterByName): Fix bug where we were not looking up array
12988 paramters if they were the only present (thanks Paolo!).
12989 (GetParameterInfo): We only have an empty set of types if both
12990 fixed and array are set to null.
12991 (GetParameterInfo-idx): Handle FixedParameter == null
12993 * cs-parser.jay: Handle the case where there is no catch
12994 statements (missing null test).
12996 2002-02-22 Miguel de Icaza <miguel@ximian.com>
12998 * driver.cs (MainDriver): Be conservative on our command line
13001 Catch DirectoryNotFoundException when calling GetFiles.
13003 (SplitPathAndPattern): Used to split the input specification into
13004 a path and a pattern that we can feed to Directory.GetFiles.
13006 2002-02-21 Miguel de Icaza <miguel@ximian.com>
13008 * statement.cs (Fixed): Implement the last case of the Fixed
13009 statement (string handling).
13011 * expression.cs (StringPtr): New class used to return a char * to
13012 a string; Used by the Fixed statement.
13014 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
13016 * expression.cs (Binary.ResolveOperator): Remove redundant
13017 MemberLookup pn parent type.
13018 Optimize union call, we do not need a union if the types are the same.
13019 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
13022 Specialize the use of MemberLookup everywhere, instead of using
13023 the default settings.
13025 (StackAlloc): Implement stackalloc keyword.
13027 * cs-parser.jay: Add rule to parse stackalloc.
13029 * driver.cs: Handle /h, /help, /?
13031 * expression.cs (MakeByteBlob): Removed the hacks we had in place
13032 before we supported unsafe code.
13034 * makefile: add --unsafe to the self compilation of mcs.
13036 2002-02-20 Miguel de Icaza <miguel@ximian.com>
13038 * expression.cs (PointerArithmetic): New class that is used to
13039 perform pointer arithmetic.
13040 (Binary.Resolve): Handle pointer arithmetic
13041 Handle pointer comparission.
13042 (ArrayPtr): Utility expression class that is used to take the
13043 address of an array.
13045 (ElementAccess): Implement array access for pointers
13047 * statement.cs (Fixed): Implement fixed statement for arrays, we
13048 are missing one more case before we are done.
13050 * expression.cs (Indirection): Implement EmitAssign and set the
13051 ExprClass to Variable. This allows pointer dereferences to be
13052 treated as variables, and to have values assigned to them.
13054 * ecore.cs (Expression.StoreFromPtr): New utility function to
13055 store values dereferencing.
13057 2002-02-20 Ravi Pratap <ravi@ximian.com>
13059 * expression.cs (Binary.ResolveOperator): Ensure that we are
13060 not trying to operate on a void type - this fixes the reported
13063 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
13064 the parent implementation is sealed.
13066 * ../errors/cs0239.cs : Add.
13068 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
13070 * typemanager.cs (unverifiable_code_type): Corresponds to
13071 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
13072 which have unsafe code in them.
13074 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
13077 2002-02-19 Miguel de Icaza <miguel@ximian.com>
13079 * cs-tokenizer.cs: Add support for @"litreal strings"
13081 Make tokenizer accept pre-processor directives
13082 on any column (remove the old C-like limitation).
13084 * rootcontext.cs (EmitCode): Emit any global attributes.
13085 (AddGlobalAttributes): Used to keep track of assembly attributes.
13087 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
13089 * cs-parser.jay: Add support for global attributes.
13091 2002-02-17 Miguel de Icaza <miguel@ximian.com>
13093 * expression.cs (Indirection): New helper class. Unary will
13094 create Indirection classes to be able to implement the
13095 IMemoryLocation interface on it.
13097 2002-02-16 Miguel de Icaza <miguel@ximian.com>
13099 * cs-parser.jay (fixed_statement): reference the right statement.
13101 * statement.cs (Fixed.Emit): Finish implementing the fixed
13102 statement for the &x case.
13104 2002-02-14 Miguel de Icaza <miguel@ximian.com>
13106 * class.cs (Property.Define, Method.Define): Remove newslot when
13109 * modifiers.cs: My use of NewSlot when `Abstract' was set was
13110 wrong. NewSlot should only be used if the `new' keyword is present.
13112 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
13113 locating our system dir. Sorry about this.
13115 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13117 * driver.cs (GetSystemDir): Compute correctly the location of our
13118 system assemblies. I was using the compiler directory instead of
13119 the library directory.
13121 2002-02-13 Ravi Pratap <ravi@ximian.com>
13123 * expression.cs (BetterFunction): Put back in what Miguel commented out
13124 since it is the correct fix. The problem is elsewhere ;-)
13126 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
13127 parameters of the parms method are themselves compatible or not !
13129 (StandardConversionExists): Fix very dangerous bug where we were forgetting
13130 to check that a class implements an interface before saying that an implicit
13131 conversion was allowed. Use ImplementsInterface to do the checking.
13133 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13135 * class.cs (Method.Define): Track whether we are an explicit
13136 implementation or not. And only call DefineMethodOverride if we
13137 are an explicit implementation.
13139 (Property.DefineMethod): Ditto.
13141 2002-02-11 Ravi Pratap <ravi@ximian.com>
13143 * expression.cs (BetterFunction): Catch hideous bug which was
13144 preventing us from detecting ambiguous calls due to implicit casts i.e
13147 2002-01-29 Miguel de Icaza <miguel@ximian.com>
13149 * support.cs (Pair): Remove un-needed method. I figured why I was
13150 getting the error in cs-parser.jay, the variable in a foreach loop
13151 is readonly, and the compiler does not really treat this as a variable.
13153 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
13154 instead of EQUALS in grammar.
13156 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
13158 * expression.cs (Unary.DoResolve): Check whether the argument is
13161 2002-01-28 Miguel de Icaza <miguel@ximian.com>
13163 * support.cs: Api for Pair to set a value. Despite the fact that
13164 the variables are public the MS C# compiler refuses to compile
13165 code that accesses the field if the variable is part of a foreach
13168 * statement.cs (Fixed): Begin implementation of the fixed
13171 (Block.AddVariable): Return the VariableInfo on success and null
13172 on failure instead of true/false.
13174 * cs-parser.jay (foreach): Catch errors on variables already
13175 defined (we were ignoring this value before) and properly unwind
13176 the block hierarchy
13178 (fixed_statement): grammar for the fixed statement.
13180 2002-01-25 Miguel de Icaza <miguel@ximian.com>
13182 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
13183 pointer types to be incretemented.
13185 (SizeOf): Implement.
13187 * cs-parser.jay (pointer_member_access): Implement
13188 expr->IDENTIFIER production.
13190 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
13191 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
13194 (Unary): Implement indirection.
13196 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
13197 use in non-unsafe context).
13199 (SimpleName.DoResolve): Check for pointers in field access on safe
13202 (Expression.LoadFromPtr): Factor the load-indirect code in this
13203 function. This was duplicated in UnboxCast and ParameterReference
13205 2002-01-24 Miguel de Icaza <miguel@ximian.com>
13207 * expression.cs (ComposedCast): report an error if a pointer cast
13208 is used in a safe region.
13210 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
13211 pointer type casts in unsafe context.
13213 * codegen.cs (EmitContext): Set up IsUnsafe.
13215 * cs-parser.jay (non_expression_type): Add productions for pointer
13218 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
13219 code. We should not use force into static mode if the method is
13220 not virtual. Fixes bug in MIS
13222 * statement.cs (Do.Emit, While.Emit, For.Emit,
13223 Statement.EmitBoolExpression): Add support to Do and While to
13224 propagate infinite loop as `I do return' semantics.
13226 Improve the For case to also test for boolean constants.
13228 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
13229 to the list of attributes we can add.
13231 Remove `EmitContext' argument.
13233 * class.cs (Method.Define): Apply parameter attributes.
13234 (Constructor.Define): Apply parameter attributes.
13235 (MethodCore.LabelParameters): Move here the core of labeling
13238 * support.cs (ReflectionParameters.ParameterModifier,
13239 InternalParameters.ParameterModifier): Use IsByRef on the type and
13240 only return the OUT bit for these parameters instead of in/out/ref
13243 This is because I miss-understood things. The ParameterInfo.IsIn
13244 and IsOut represent whether the parameter has the [In] and [Out]
13247 2002-01-22 Miguel de Icaza <miguel@ximian.com>
13249 * ecore.cs (FieldExpr.Emit): Release temporaries.
13251 * assign.cs (LocalTemporary.Release): new function.
13253 * codegen.cs (EmitContext.GetTemporaryStorage,
13254 EmitContext.FreeTemporaryStorage): Rework the way we deal with
13255 temporary storage. Now we can "put back" localbuilders when we
13258 2002-01-21 Miguel de Icaza <miguel@ximian.com>
13260 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
13261 need to make a copy of the variable to generate verifiable code.
13263 2002-01-19 Miguel de Icaza <miguel@ximian.com>
13265 * driver.cs: Compute dynamically the system directory.
13267 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
13268 Slower, but more generally useful. Used by the abstract
13269 registering implementation.
13271 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
13272 the rules for the special rule on Type/instances. First check if
13273 we have the same name, and if so, try that special static path
13274 rather than the instance path.
13276 2002-01-18 Miguel de Icaza <miguel@ximian.com>
13278 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
13281 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
13282 Enum, ValueType, Delegate or Array for non-corlib compiles.
13284 * cs-tokenizer.cs: Catch long identifiers (645)
13286 * typemanager.cs (IndexerPropetyName): Ravi never tested this
13289 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
13290 fix, we were returning too early, so we were not registering
13291 pending methods from abstract classes.
13293 Do not register pending methods if the class is abstract.
13295 * expression.cs (Conditional.DoResolve): Report circular implicit
13296 conversions when we neecd to compute it for conditional
13299 (Is.DoResolve): If the expression is always of the provided type,
13300 flag warning 183. If the expression can not ever be of the
13301 provided type flag warning 184.
13303 * class.cs: Catch 169 as well.
13305 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
13308 2002-01-18 Nick Drochak <ndrochak@gol.com>
13310 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13312 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13314 * interface.cs: (PopulateMethod): Check for pointers being defined
13315 only if the unsafe context is active.
13316 (PopulateProperty): ditto.
13317 (PopulateIndexer): ditto.
13319 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13320 specified. If pointers are present, make sure that they are
13321 present in an unsafe context.
13322 (Constructor, Constructor.Define): ditto.
13323 (Field, Field.Define): ditto.
13324 (Property, Property.Define): ditto.
13325 (Event, Event.Define): ditto.
13327 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13328 hashtable if there are classes or structs defined.
13330 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13331 code, as the constant resolution moved.
13333 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13334 the metadata, so we can flag error 133.
13336 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13337 pointer is being declared in an unsafe context.
13339 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13341 * modifiers.cs (Modifiers.Check): Require a Location argument.
13342 Report error 227 for Unsafe use.
13344 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13346 * statement.cs (For.Emit): If the test is null, then report that
13347 we do `return', as we wont reach anything afterwards.
13349 (Switch.SwitchGoverningType): Track the expression that matched
13352 * driver.cs: Allow negative numbers as an error code to flag.
13354 * cs-parser.jay: Handle 1551.
13356 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13358 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13360 * cs-parser.jay: Report 1518 (type declaration can only contain
13361 class, struct, interface, enum or delegate)
13363 (switch_label): Report 1523 (keywords `case' or `default' must
13366 (opt_switch_sections): Report 1522 (empty switch)
13368 * driver.cs: Report 1515 (response file specified multiple times)
13369 Report 1516 (Source file specified multiple times).
13371 * expression.cs (Argument.Resolve): Signal 1510
13373 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13374 access not allowed in static code)
13376 2002-01-11 Ravi Pratap <ravi@ximian.com>
13378 * typemanager.cs (IsPointerType): Utility method which we are going
13381 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13382 the object type, so we take care of that.
13384 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13386 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13387 added to non-params parameters :-)
13389 * typemanager.cs (CSharpName): Include 'void' type too.
13391 (void_ptr_type): Include in the set of core types.
13393 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13396 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13399 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13400 completely forgotten about it.
13402 2002-01-10 Ravi Pratap <ravi@ximian.com>
13404 * cs-parser.jay (pointer_type): Add. This begins our implementation
13405 of parsing rules for unsafe code.
13407 (unsafe_statement): Implement.
13409 (embedded_statement): Modify to include the above.
13411 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13413 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13414 if the current context is an unsafe one.
13416 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13417 are handled differently, we need separate rules for them.
13419 (local_variable_declaration): Update to use local_variable_pointer_type
13420 to allow variable declarations of unmanaged pointer types.
13422 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13423 in unsafe contexts.
13425 * ../errors/cs0214.cs : Add.
13427 2002-01-16 Nick Drochak <ndrochak@gol.com>
13429 * makefile: remove 'response' file when cleaning.
13431 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13433 * cs-parser.jay: Report 1524.
13435 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13437 * typemanager.cs (RegisterMethod): drop checking if we have
13438 registered this from here
13440 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13442 * class.cs (Method.EmitDestructor): Implement calling our base
13445 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13446 value of InFinally.
13448 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13449 this routine and will wrap the call in a try/catch block. Deal
13452 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13454 * ecore.cs (Expression.MemberLookup): instead of taking a
13455 parameter `same_type' that was used to tell whether we could
13456 access private members we compute our containing type from the
13459 (FieldExpr): Added partial support for volatile fields. This does
13460 not work for volatile fields exposed from assemblies, as I can not
13461 figure out how to extract the modreq from it.
13463 Updated all the source files to use this.
13465 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13466 because it is referenced by MemberLookup very often.
13468 2002-01-09 Ravi Pratap <ravi@ximian.com>
13470 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13471 TypeBuilder.GetCustomAttributes to retrieve what we need.
13473 Get rid of redundant default_member_attr_type as this is the same as
13474 default_member_type which already exists.
13476 * interface.cs, attribute.cs : Update accordingly.
13478 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13480 * typemanager.cs: Enable IndexerPropertyName again. It does not
13481 work for TYpeBuilders though. Ravi, can you please fix this?
13483 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13485 * expression.cs (Argument.Emit): Handle the case of ref objects
13486 being passed to ref functions;
13488 (ParameterReference.EmitLoad): Loads the content of the pointer
13489 without dereferencing.
13491 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13493 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13495 2002-01-08 Ravi Pratap <ravi@ximian.com>
13497 * class.cs (Indexer.DefineMethod): Incorporate the interface
13498 type in the name of the method if we are doing explicit interface
13501 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13503 (BetterConversion): Fix extremely trivial bug where we were referring to
13504 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13507 * ../errors/bug16.cs : Add although we have fixed it.
13509 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13511 * expression.cs (BaseIndexer): Begin implementation.
13513 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13515 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13516 production directly to remove a shift/reduce, and implement
13517 explicit interface implementation.
13519 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13520 after a floating point suffix.
13522 * expression.cs (DoNumericPromotions): Improved the conversion for
13523 uint/uint. If we have a constant, we avoid doing a typecast to a
13526 * class.cs (Indexer): Implement explicit interface implementation
13529 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13531 * class.cs: make the default instance constructor public and hidebysig.
13533 2001-01-03 Ravi Pratap <ravi@ximian.com>
13535 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13536 so we can call it from elsewhere.
13538 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13539 we emit it internally if the class has a defined indexer; otherwise the user
13540 emits it by decorating the class definition with the DefaultMemberAttribute.
13542 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13543 attribute is not used on a type which defines an indexer.
13545 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13546 character when we skip whitespace.
13548 * ../errors/cs0646.cs : Add.
13550 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13552 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13555 * makefile: Add practical target `mcs3.exe' which builds the third
13556 generation compiler.
13558 * expression.cs (New): Fix structures constructor calling.
13560 * class.cs (Property, Method, Indexer): Emit Final flag on the
13561 method if we are an interface implementation and we are not
13564 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13565 whether this property is referencing a `base' method.
13567 * expression.cs (Invocation.EmitCall): take an extra argument:
13568 is_base, this is used to determine whether the `call' or
13569 `callvirt' opcode should be used.
13572 * delegate.cs: update EmitCall.
13574 * class.cs (Method.Define): Set NewSlot for the cases where we are
13575 not implementing an interface method.
13577 (Property.Define): ditto.
13579 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13581 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13582 'r'. Allows mcs to parse itself fully.
13584 2002-01-02 Ravi Pratap <ravi@ximian.com>
13586 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13587 of the number of initializers that require the InitializeArray method.
13589 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13590 update the above field where necessary.
13592 (MakeByteBlob): Update accordingly.
13594 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13597 (EmitDynamicInitializers): Update in accordance with the new optimization.
13599 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13600 same OpCode applies.
13602 * cs-parser.jay : Fix some glaring errors I introduced.
13604 2002-01-01 Ravi Pratap <ravi@ximian.com>
13606 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13607 so that we can check for name clashes there too.
13609 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13610 for interface indexers.
13612 * interfaces.cs (Define): Emit the default member attribute.
13614 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13615 variable was being referred to while setting the value ;-)
13617 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13619 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13620 byte-by-byte information when we know the data is zero.
13622 Make the block always a multiple of 4, because
13623 DefineInitializedData has a bug.
13625 * assign.cs: Fix, we should assign from the temporary, not from
13628 * expression.cs (MakeByteBlob): Fix my incorrect code.
13630 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13632 * typemanager.cs (EnumToUnderlying): This function is used to get
13633 the underlying type from an enumeration, because it does not
13636 * constant.cs: Use the I4_S form for values between -128 and 127.
13638 * statement.cs (Block.LookupLabel): Looks up a label.
13639 (Block): Drop support for labeled blocks.
13641 (LabeledStatement): New kind of statement that represents a label
13644 (Goto): Finally implement this bad boy.
13646 * cs-parser.jay: Update to reflect new mechanism to implement
13649 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13651 * codegen.cs (EmitContext.This): a codegen property that keeps the
13652 a single instance of this instead of creating many different this
13655 * delegate.cs (Delegate.DoResolve): Update to use the property;
13657 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
13659 * expression.cs (BaseAccess.DoResolve): Ditto.
13661 2001-12-29 Ravi Pratap <ravi@ximian.com>
13663 * typemanager.cs (methodimpl_attr_type): Add to hold the type
13664 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
13666 (InitCoreTypes): Update accordingly.
13668 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
13669 so we can quickly store the state.
13671 (ApplyAttributes): Set the correct implementation flags
13672 for InternalCall methods.
13674 2001-12-29 Miguel de Icaza <miguel@ximian.com>
13676 * expression.cs (EmitCall): if a method is not virtual, then do
13677 not use callvirt on it.
13679 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
13680 user defined stuff) requires the use of stobj, which takes an
13681 address on the stack instead of an array and an index. So emit
13682 the Ldelema operation for it.
13684 (EmitStoreOpcode): Use stobj for valuetypes.
13686 (UnaryMutator.EmitCode): Use the right 1 value depending on
13687 whether we are dealing with int64/uint64, float or doubles.
13689 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
13690 constructors that I implemented last night.
13692 (Constructor.IsDefault): Fix to work properly for static
13695 * cs-parser.jay (CheckDef): report method signature errors.
13696 Update error number 103 to be 132.
13698 * decl.cs: New AdditionResult enumeration value: MethodExists.
13699 Although we do this check for methods later on in the semantic
13700 analysis, catching repeated default constructors is so easy that
13701 we catch these here.
13703 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
13706 (ParameterReference.EmitAssign, Emit): handle
13709 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
13710 (ArrayAccess.EmitStoreOpcode): ditto.
13712 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
13714 * expression.cs (MakeByteBlob): Complete all the missing types
13715 (uint, short, ushort, byte, sbyte)
13717 * class.cs: Only init instance field initializers on instance
13720 Rename `constructors' to instance_constructors.
13722 (TypeContainer.AddConstructor): Only add constructors to the list
13723 if it is not static.
13725 Make sure that we handle default_static_constructor independently
13726 everywhere where we handle instance_constructors
13728 2001-12-28 Miguel de Icaza <miguel@ximian.com>
13730 * class.cs: Do not lookup or create a base initializer for a
13731 static constructor.
13733 (ConstructorInitializer.Resolve): use the proper type to lookup
13736 * cs-parser.jay: Report error 1585 (modifiers between type and name).
13738 * enum.cs, interface.cs: Remove CloseType, this is taken care by
13741 * decl.cs: CloseType is now an virtual method, the default
13742 implementation just closes this type.
13744 2001-12-28 Ravi Pratap <ravi@ximian.com>
13746 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
13747 to PreserveSig by default. Also emit HideBySig on such methods.
13749 Basically, set the defaults to standard values.
13751 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
13752 argument, if candidate is better, it can't be worse than the best !
13754 (Invocation): Re-write bits to differentiate between methods being
13755 applicable in their expanded form and their normal form - for params
13758 Get rid of use_standard everywhere as only standard conversions are allowed
13759 in overload resolution.
13761 More spec conformance.
13763 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13765 * driver.cs: Add --timestamp, to see where the compiler spends
13768 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
13769 `this' in static code.
13771 (SimpleName.DoResolve): Implement in terms of a helper function
13772 that allows static-references to be passed upstream to
13775 (Expression.ResolveWithSimpleName): Resolve specially simple
13776 names when called by MemberAccess to implement the special
13779 (Expression.ImplicitReferenceConversion): Handle conversions from
13780 Null to reference types before others, as Null's type is
13783 * expression.cs (Invocation.EmitCall): Handle the special case of
13784 calling methods declared on a reference type from a ValueType
13785 (Base classes System.Object and System.Enum)
13787 (MemberAccess.Resolve): Only perform lookups on Enumerations if
13788 the left hand side is a TypeExpr, not on every enumeration.
13790 (Binary.Resolve): If types are reference types, then do a cast to
13791 object on operators != and == of both arguments.
13793 * typemanager.cs (FindMembers): Extract instance and static
13794 members if requested.
13796 * interface.cs (PopulateProperty): Use void_type instead of null
13797 as the return type for the setter method.
13799 (PopulateIndexer): ditto.
13801 2001-12-27 Ravi Pratap <ravi@ximian.com>
13803 * support.cs (ReflectionParameters): Fix minor bug where we
13804 were examining the wrong parameter for the ParamArray attribute.
13806 Cope with requests for the type of the parameter at position
13807 greater than the params parameter's. We now return the element
13808 type of the params array as that makes more sense.
13810 * expression.cs (Invocation.IsParamsMethodApplicable): Update
13811 accordingly as we no longer have to extract the element type
13814 (Invocation.OverloadResolve): Update.
13816 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13818 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
13819 against IEnumerator, test whether the return value is a descendant
13820 of the IEnumerator interface.
13822 * class.cs (Indexer.Define): Use an auxiliary method to implement
13823 the other bits of the method definition. Begin support for
13824 explicit interface implementation.
13826 (Property.DefineMethod): Use TypeManager.void_type instead of null
13827 for an empty return value.
13829 2001-12-26 Miguel de Icaza <miguel@ximian.com>
13831 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
13832 dealing with a FieldExpr which is composed of a FieldBuilder, in
13833 the code path we did extract the constant, but we should have
13834 obtained the underlying value to be able to cast it (otherwise we
13835 end up in an infinite loop, this is what Ravi was running into).
13837 (ArrayCreation.UpdateIndices): Arrays might be empty.
13839 (MemberAccess.ResolveMemberAccess): Add support for section
13840 14.5.4.1 that deals with the special case of E.I when E is a type
13841 and something else, that I can be a reference to a static member.
13843 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
13844 handle a particular array type to create byte blobs, it is just
13845 something we dont generate byteblobs for.
13847 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
13850 * location.cs (Push): remove the key from the hashtable that we
13851 are about to add. This happens for empty files.
13853 * driver.cs: Dispose files after we have parsed them.
13855 (tokenize): new function that only runs the tokenizer on its
13856 input, for speed testing.
13858 2001-12-26 Ravi Pratap <ravi@ximian.com>
13860 * class.cs (Event.Define): Define the private field only if there
13861 are no accessors defined.
13863 * expression.cs (ResolveMemberAccess): If there is no associated
13864 field with the event, that means we have an event defined with its
13865 own accessors and we should flag error cs0070 since transforming
13866 ourselves into a field is not valid in that case.
13868 * ecore.cs (SimpleName.DoResolve): Same as above.
13870 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
13871 and charset to sane values.
13873 2001-12-25 Ravi Pratap <ravi@ximian.com>
13875 * assign.cs (DoResolve): Perform check on events only if they
13876 are being accessed outside the declaring type.
13878 * cs-parser.jay (event_declarations): Update rules to correctly
13879 set the type of the implicit parameter etc.
13881 (add_accessor, remove_accessor): Set current local parameters.
13883 * expression.cs (Binary): For delegate addition and subtraction,
13884 cast the return value from the method into the appropriate delegate
13887 2001-12-24 Ravi Pratap <ravi@ximian.com>
13889 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
13890 of these as the workaround is unnecessary.
13892 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
13893 delegate data - none of that is needed at all.
13895 Re-write bits to extract the instance expression and the delegate method
13898 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
13901 * attribute.cs (ApplyAttributes): New method to take care of common tasks
13902 of attaching attributes instead of duplicating code everywhere.
13904 * everywhere : Update code to do attribute emission using the above method.
13906 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13908 * expression.cs (IsParamsMethodApplicable): if there are not
13909 parameters, return immediately.
13911 * ecore.cs: The 0 literal can be implicity converted to an enum
13914 (SimpleName.DoResolve): First lookup the type, then lookup the
13917 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
13918 want to get its address. If the InstanceExpression is not
13919 addressable, store the result in a temporary variable, then get
13922 * codegen.cs: Only display 219 errors on warning level or above.
13924 * expression.cs (ArrayAccess): Make it implement the
13925 IMemoryLocation interface.
13927 (Binary.DoResolve): handle the operator == (object a, object b)
13928 and operator != (object a, object b) without incurring into a
13929 BoxedCast (because 5 != o should never be performed).
13931 Handle binary enumerator operators.
13933 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
13934 value type, otherwise use Ldelem_ref.
13936 Use precomputed names;
13938 (AddressOf): Implement address of
13940 * cs-parser.jay (labeled_statement): Fix recursive block
13941 addition by reworking the production.
13943 * expression.cs (New.DoEmit): New has a special case:
13945 If we are dealing with a ValueType, we have a few
13946 situations to deal with:
13948 * The target of New is a ValueType variable, that is
13949 easy, we just pass this as the variable reference
13951 * The target of New is being passed as an argument,
13952 to a boxing operation or a function that takes a
13955 In this case, we need to create a temporary variable
13956 that is the argument of New.
13959 2001-12-23 Ravi Pratap <ravi@ximian.com>
13961 * rootcontext.cs (LookupType): Check that current_type is not null before
13962 going about looking at nested types.
13964 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
13965 not implement the IAssignMethod interface any more.
13967 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
13968 where we tranform them into FieldExprs if they are being resolved from within
13969 the declaring type.
13971 * ecore.cs (SimpleName.DoResolve): Do the same here.
13973 * assign.cs (DoResolve, Emit): Clean up code considerably.
13975 * ../errors/bug10.cs : Add.
13977 * ../errors/cs0070.cs : Add.
13979 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
13981 * assign.cs : Get rid of EventIsLocal everywhere.
13983 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13985 * ecore.cs (ConvertIntLiteral): finished the implementation.
13987 * statement.cs (SwitchLabel): Convert the value we are using as a
13988 key before looking up the table.
13990 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13992 * codegen.cs (EmitTopBlock): Require a Location argument now.
13994 * cs-parser.jay (constructor_declarator): We need to setup
13995 current_local_parameters before we parse the
13996 opt_constructor_initializer, to allow the variables to be bound
13997 to the constructor arguments.
13999 * rootcontext.cs (LookupType): First lookup nested classes in our
14000 class and our parents before we go looking outside our class.
14002 * expression.cs (ConstantFold): Extract/debox the values at the
14005 * rootcontext.cs (EmitCode): Resolve the constants first before we
14006 resolve the types. This is not really needed, but it helps debugging.
14008 * statement.cs: report location.
14010 * cs-parser.jay: pass location to throw statement.
14012 * driver.cs: Small bug fix.
14014 * report.cs: Updated format to be 4-zero filled digits.
14016 2001-12-22 Ravi Pratap <ravi@ximian.com>
14018 * expression.cs (CheckIndices): Fix minor bug where the wrong
14019 variable was being referred to ;-)
14021 (DoEmit): Do not call EmitStaticInitializers when the
14022 underlying type is System.Object.
14024 2001-12-21 Ravi Pratap <ravi@ximian.com>
14026 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
14027 and do the usual workaround for SRE.
14029 * class.cs (MyEventBuilder.EventType): New member to get at the type
14030 of the event, quickly.
14032 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
14034 * assign.cs (Assign.DoResolve): Handle the case when the target
14035 is an EventExpr and perform the necessary checks.
14037 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
14040 (SimpleName.MemberStaticCheck): Include check for EventExpr.
14042 (EventExpr): Set the type in the constructor itself since we
14043 are meant to be born fully resolved.
14045 (EventExpr.Define): Revert code I wrote earlier.
14047 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
14048 instance expression is null. The instance expression is a This in that case
14049 or a null, depending on whether it is a static method or not.
14051 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
14052 refers to more than one method.
14054 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
14055 and accordingly flag errors.
14057 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14059 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
14061 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14063 * location.cs (ToString): Provide useful rutine.
14065 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14067 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
14068 objects, return the actual integral boxed.
14070 * statement.cs (SwitchLabel): define an ILLabel for each
14073 (Switch.CheckSwitch): If the value is a Literal, extract
14074 the underlying literal.
14076 Also in the unused hashtable we had, add the SwitchLabel so we can
14077 quickly look this value up.
14079 * constant.cs: Implement a bunch of new constants. Rewrite
14080 Literal based on this. Made changes everywhere to adapt to this.
14082 * expression.cs (Expression.MakeByteBlob): Optimize routine by
14083 dereferencing array only once, and also copes with enumrations.
14085 bytes are two bytes wide, not one.
14087 (Cast): Perform constant conversions.
14089 * ecore.cs (TryImplicitIntConversion): Return literals instead of
14090 wrappers to the literals here.
14092 * expression.cs (DoNumericPromotions): long literals can converted
14093 to ulong implicity (this is taken care of elsewhere, but I was
14094 missing this spot).
14096 * ecore.cs (Expression.Literalize): Make the return type Literal,
14097 to improve type checking.
14099 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
14101 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14103 * literal.cs: Revert code from ravi that checked the bounds. The
14104 bounds are sane by the definition of the type itself.
14106 * typemanager.cs: Fix implementation of ImplementsInterface. We
14107 need to actually look up in our parent hierarchy for interfaces
14110 * const.cs: Use the underlying type for enumerations
14112 * delegate.cs: Compute the basename for the delegate creation,
14113 that should fix the delegate test case, and restore the correct
14114 Type Lookup semantics in rootcontext
14116 * rootcontext.cs: Revert Ravi's last patch. The correct way of
14117 referencing a nested type with the Reflection API is using the "+"
14120 * cs-parser.jay: Do not require EOF token at the end.
14122 2001-12-20 Ravi Pratap <ravi@ximian.com>
14124 * rootcontext.cs (LookupType): Concatenate type names with
14125 a '.' instead of a '+' The test suite passes again.
14127 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
14128 field of the enumeration.
14130 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
14131 the case when the member is an EventExpr.
14133 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
14134 static has an associated instance expression.
14136 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
14138 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
14140 * class.cs (Event.Define): Register event and perform appropriate checks
14143 We define the Add and Remove methods even if the use provides none because
14144 in that case, we provide default implementations ourselves.
14146 Define a private field of the type of the event. This is done by the CSC compiler
14147 and we should be doing it too ;-)
14149 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
14150 More methods we use in code we generate.
14152 (multicast_delegate_type, delegate_type): Two separate types since the distinction
14155 (InitCoreTypes): Update accordingly for the above.
14157 * class.cs (Event.Emit): Generate code for default accessors that we provide
14159 (EmitDefaultMethod): Do the job in the above.
14161 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
14164 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14166 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
14167 builders even if we were missing one.
14169 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
14170 pass the Basename as our class name instead of the Name. The
14171 basename will be correctly composed for us.
14173 * parameter.cs (Paramters): Now takes a Location argument.
14175 * decl.cs (DeclSpace.LookupType): Removed convenience function and
14176 make all the code call directly LookupType in RootContext and take
14177 this chance to pass the Location information everywhere.
14179 * Everywhere: pass Location information.
14181 2001-12-19 Miguel de Icaza <miguel@ximian.com>
14183 * class.cs (Constructor.Define): Updated way of detecting the
14184 length of the parameters.
14186 (TypeContainer.DefineType): Use basename as the type name for
14189 (TypeContainer.Define): Do not recursively define types here, as
14190 definition is taken care in order by the RootContext.
14192 * tree.cs: Keep track of namespaces in a per-file basis.
14194 * parameter.cs (Parameter.ComputeSignature): Update to use
14197 (Parameters.GetSignature): ditto.
14199 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
14200 instead of a TypeContainer.
14202 (Interface.SemanticAnalysis): Use `this' instead of our parent to
14203 resolve names. Because we need to be resolve in our context, not
14206 * driver.cs: Implement response files.
14208 * class.cs (TypeContainer.DefineType): If we are defined, do not
14209 redefine ourselves.
14211 (Event.Emit): Emit the code for add/remove handlers.
14212 (Event.Define): Save the MethodBuilders for add/remove.
14214 * typemanager.cs: Use pair here too.
14216 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
14217 DictionaryEntry requires the first argument to be non-null.
14219 (enum_declaration): Compute full name for registering the
14222 (delegate_declaration): Instead of using
14223 formal_parameter_list, use opt_formal_parameter_list as the list
14226 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
14227 (EventParsing): New property that controls whether `add' and
14228 `remove' are returned as tokens or identifiers (for events);
14230 2001-12-19 Ravi Pratap <ravi@ximian.com>
14232 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
14233 use MyEventBuilder only and let it wrap the real builder for us.
14235 (MyEventBuilder): Revamp constructor etc.
14237 Implement all operations that we perform on EventBuilder in precisely the same
14240 (FindMembers): Update to use the EventBuilder member.
14242 (Event.Emit): Update accordingly.
14244 2001-12-18 Ravi Pratap <ravi@ximian.com>
14246 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
14247 by calling the appropriate methods.
14249 (GetCustomAttributes): Make stubs as they cannot possibly do anything
14252 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
14254 2001-12-17 Ravi Pratap <ravi@ximian.com>
14256 * delegate.cs (Delegate.Populate): Check that the return type
14257 and various parameters types are indeed accessible.
14259 * class.cs (Constructor.Define): Same here.
14261 (Field.Define): Ditto.
14263 (Event.Define): Ditto.
14265 (Operator.Define): Check that the underlying Method defined itself
14266 correctly - so it's MethodBuilder should not be null.
14268 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
14269 expression happens to be null.
14271 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
14272 members but as of now we don't seem to be able to do anything really useful with it.
14274 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
14275 not the EventBuilder.
14277 2001-12-18 Miguel de Icaza <miguel@ximian.com>
14279 * cs-tokenizer.cs: Add support for defines.
14280 Add support for #if, #elif, #else, #endif
14282 (eval_var): evaluates a variable.
14283 (eval): stubbed for evaluating functions.
14285 * cs-parser.jay: Pass the defines information
14287 * driver.cs: Add --define command line option.
14289 * decl.cs: Move MemberCore here.
14291 Make it the base class for DeclSpace. This allows us to catch and
14292 report 108 and 109 for everything now.
14294 * class.cs (TypeContainer.Define): Extract all the members
14295 before populating and emit the warning 108 (new keyword required
14296 to override) instead of having each member implement this.
14298 (MemberCore.Define): New abstract method, we will be using this in
14299 the warning reporting engine in Populate.
14301 (Operator.Define): Adjust to new MemberCore protocol.
14303 * const.cs (Const): This does not derive from Expression, it is a
14304 temporary object we use to create fields, it is a MemberCore.
14306 * class.cs (Method.Define): Allow the entry point to be in a
14309 * driver.cs: Rewrite the argument handler to clean it up a bit.
14311 * rootcontext.cs: Made it just an auxiliary namespace feature by
14312 making everything static.
14314 * driver.cs: Adapt code to use RootContext type name instead of
14317 * delegate.cs: Remove RootContext argument.
14319 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14322 * class.cs (Event.Define): The lookup can fail.
14324 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14326 * expression.cs: Resolve the this instance before invoking the code.
14328 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14330 * cs-parser.jay: Add a production in element_access that allows
14331 the thing to become a "type" reference. This way we can parse
14332 things like "(string [])" as a type.
14334 Note that this still does not handle the more complex rules of
14338 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14340 * ecore.cs: (CopyNewMethods): new utility function used to
14341 assemble the list of methods from running FindMembers.
14343 (MemberLookup): Rework FindMembers so that
14345 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14347 * class.cs (TypeContainer): Remove Delegates who fail to be
14350 * delegate.cs (Populate): Verify that we dont get null return
14351 values. TODO: Check for AsAccessible.
14353 * cs-parser.jay: Use basename to emit error 574 (destructor should
14354 have the same name as container class), not the full name.
14356 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14357 possible representation.
14359 Also implements integer type suffixes U and L.
14361 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14363 * expression.cs (ArrayCreation.DoResolve): We need to do the
14364 argument resolution *always*.
14366 * decl.cs: Make this hold the namespace. Hold the root context as
14368 (LookupType): Move here.
14370 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14372 * location.cs (Row, Name): Fixed the code, it was always returning
14373 references to the first file.
14375 * interface.cs: Register properties defined through interfaces.
14377 * driver.cs: Add support for globbing on the command line
14379 * class.cs (Field): Make it derive from MemberCore as well.
14382 2001-12-15 Ravi Pratap <ravi@ximian.com>
14384 * class.cs (Event::Define): Check that the type of the event is a delegate
14385 type else flag error #66.
14387 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14390 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14391 values of EntryPoint, CharSet etc etc.
14393 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14395 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14396 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14397 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14398 which needs this to do its work.
14400 * ../errors/cs0066.cs : Add.
14402 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14404 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14407 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14408 clears out the parameters field.
14409 (MemberSignatureCompare): Cleanup
14411 (MemberCore): New base class used to share code between MethodCore
14414 (RegisterRequiredImplementations) BindingFlags.Public requires
14415 either BindingFlags.Instace or Static. Use instance here.
14417 (Property): Refactored code to cope better with the full spec.
14419 * parameter.cs (GetParameterInfo): Return an empty array instead
14422 * class.cs (Property): Abstract or extern properties have no bodies.
14424 * parameter.cs (GetParameterInfo): return a zero-sized array.
14426 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14427 method modifier validation to the typecontainer so we can reuse
14428 this on properties.
14430 (MethodCore.ParameterTypes): return an empty sized array of types.
14432 (Property.Define): Test property modifier validity.
14434 Add tests for sealed/override too.
14436 (Method.Emit): abstract or extern methods have no bodies.
14438 2001-12-14 Ravi Pratap <ravi@ximian.com>
14440 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14443 (Method::Define, ::Emit): Modify accordingly.
14445 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14447 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14449 * makefile: Pass in /unsafe.
14451 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14453 * class.cs (MakeKey): Kill routine.
14455 * class.cs (TypeContainer.Define): Correctly define explicit
14456 method implementations (they require the full interface name plus
14459 * typemanager.cs: Deply the PtrHashtable here and stop using the
14460 lame keys. Things work so much better.
14462 This of course broke everyone who depended on `RegisterMethod' to
14463 do the `test for existance' test. This has to be done elsewhere.
14465 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14466 the object stupid Equals method (because, that like fails all over
14467 the place). We still do not use it.
14469 * class.cs (TypeContainer.SetRequiredInterface,
14470 TypeContainer.RequireMethods): Killed these two routines and moved
14471 all the functionality to RegisterRequiredImplementations.
14473 (TypeContainer.RegisterRequiredImplementations): This routine now
14474 registers all the implementations required in an array for the
14475 interfaces and abstract methods. We use an array of structures
14476 which can be computed ahead of time to reduce memory usage and we
14477 also assume that lookups are cheap as most classes will not
14478 implement too many interfaces.
14480 We also avoid creating too many MethodSignatures.
14482 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14483 clear the "pending" bit if we find that there are problems with
14486 (TypeContainer.VerifyPendingMethods): Update to report errors of
14487 methods that look like implementations but are not.
14489 (TypeContainer.Define): Add support for explicit interface method
14492 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14494 * typemanager.cs: Keep track of the parameters here instead of
14495 being a feature of the TypeContainer.
14497 * class.cs: Drop the registration of parameters here, as
14498 InterfaceMethods are also interface declarations.
14500 * delegate.cs: Register methods with the TypeManager not only with
14501 the TypeContainer. This code was buggy.
14503 * interface.cs: Full registation here.
14505 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14507 * expression.cs: Remove reducer for binary expressions, it can not
14510 * const.cs: Put here the code that used to go into constant.cs
14512 * constant.cs: Put here the code for constants, this is a new base
14513 class for Literals.
14515 * literal.cs: Make Literal derive from Constant.
14517 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14519 * statement.cs (Return.Emit): Report error 157 if the user
14520 attempts to return from a finally block.
14522 (Return.Emit): Instead of emitting a return, jump to the end of
14525 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14526 LocalBuilder to store the result of the function. ReturnLabel is
14527 the target where we jump.
14530 2001-12-09 Radek Doulik <rodo@ximian.com>
14532 * cs-parser.jay: remember alias in current namespace
14534 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14537 * class.cs (LookupAlias): lookup alias in my_namespace
14539 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14541 (LookupAlias): lookup alias in this and if needed in parent
14544 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14548 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14549 making things static. I need this to avoid passing the
14550 TypeContainer when calling ParameterType.
14552 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14553 that did string manipulation to compute the type and then call
14554 GetType. Use Parameter.ParameterType instead.
14556 * cs-tokenizer.cs: Consume the suffix for floating values.
14558 * expression.cs (ParameterReference): figure out whether this is a
14559 reference parameter or not. Kill an extra variable by computing
14560 the arg_idx during emission.
14562 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14563 function that returns whether a parameter is an out/ref value or not.
14565 (Parameter.ParameterType): The type of the parameter (base,
14566 without ref/out applied).
14568 (Parameter.Resolve): Perform resolution here.
14569 (Parameter.ExternalType): The full type (with ref/out applied).
14571 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14572 support for expressions on the using statement.
14574 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14576 * statement.cs (Using.EmitLocalVariableDecls): Split the
14577 localvariable handling of the using statement.
14579 (Block.EmitMeta): Keep track of variable count across blocks. We
14580 were reusing slots on separate branches of blocks.
14582 (Try.Emit): Emit the general code block, we were not emitting it.
14584 Check the type of the declaration to be an IDisposable or
14585 something that can be implicity converted to it.
14587 Emit conversions if required.
14589 * ecore.cs (EmptyExpression): New utility class.
14590 (Expression.ImplicitConversionExists): New utility function.
14592 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14594 * statement.cs (Using): Implement.
14596 * expression.cs (LocalVariableReference): Support read only variables.
14598 * statement.cs: Remove the explicit emit for the Leave opcode.
14599 (VariableInfo): Add a readonly field.
14601 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14603 * ecore.cs (ConvCast): new class used to encapsulate the various
14604 explicit integer conversions that works in both checked and
14605 unchecked contexts.
14607 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14608 properly generate the overflow opcodes.
14610 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14612 * statement.cs: The correct type for the EmptyExpression is the
14613 element_type, not the variable type. Ravi pointed this out.
14615 2001-12-04 Ravi Pratap <ravi@ximian.com>
14617 * class.cs (Method::Define): Handle PInvoke methods specially
14618 by using DefinePInvokeMethod instead of the usual one.
14620 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14621 above to do the task of extracting information and defining the method.
14623 2001-12-04 Ravi Pratap <ravi@ximian.com>
14625 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14626 of the condition for string type.
14628 (Emit): Move that here.
14630 (ArrayCreation::CheckIndices): Keep string literals in their expression
14633 (EmitDynamicInitializers): Handle strings appropriately.
14635 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14637 * codegen.cs (EmitContext): Replace multiple variables with a
14638 single pointer to the current Switch statement.
14640 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14643 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14647 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14650 (Foreach.Emit): Foreach on arrays was not setting
14651 up the loop variables (for break/continue).
14653 (GotoCase): Semi-implented.
14655 2001-12-03 Ravi Pratap <ravi@ximian.com>
14657 * attribute.cs (CheckAttribute): Handle system attributes by using
14658 Attribute.GetAttributes to examine information we need.
14660 (GetValidPlaces): Same here.
14662 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
14664 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
14666 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
14668 (Method::Define): Set appropriate flags if we have a DllImport attribute.
14670 (Method::Emit): Handle the case when we are a PInvoke method.
14672 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14674 * expression.cs: Use ResolveWithSimpleName on compound names.
14676 2001-12-02 Ravi Pratap <ravi@ximian.com>
14678 * constant.cs (EmitConstant): Make sure we resolve the associated expression
14679 before trying to reduce it.
14681 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
14683 * constant.cs (LookupConstantValue): Implement.
14685 (EmitConstant): Use the above in emitting the constant.
14687 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
14688 that are user-defined by doing a LookupConstantValue on them.
14690 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
14693 2001-11-29 Miguel de Icaza <miguel@ximian.com>
14695 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
14697 (BaseAccess.DoResolve): Implement.
14699 (MemberAccess.DoResolve): Split this routine into a
14700 ResolveMemberAccess routine that can be used independently
14702 2001-11-28 Miguel de Icaza <miguel@ximian.com>
14704 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
14705 As that share bits of the implementation. Is returns a boolean,
14706 while As returns the Type that is being probed.
14708 2001-12-01 Ravi Pratap <ravi@ximian.com>
14710 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
14711 instead of a Literal - much easier.
14713 (EnumInTransit): Remove - utterly useless :-)
14715 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
14717 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
14719 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
14720 chain when we have no associated expression.
14722 2001-11-30 Ravi Pratap <ravi@ximian.com>
14724 * constant.cs (Define): Use Location while reporting the errror.
14726 Also emit a warning when 'new' is used and there is no inherited
14729 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
14732 (LookupEnumValue): Implement to lookup an enum member's value and define it
14735 (Populate): Re-write accordingly to use the above routine.
14737 2001-11-27 Miguel de Icaza <miguel@ximian.com>
14739 * expression.cs (This): Fix prototype for DoResolveLValue to
14740 override the base class DoResolveLValue.
14742 * cs-parser.cs: Report errors cs574 and cs575 (destructor
14745 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
14746 (we need to load the address of the field here). This fixes
14749 (FieldExpr.DoResolveLValue): Call the DoResolve
14750 function to initialize the Instance expression.
14752 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
14753 correctly the GetEnumerator operation on a value type.
14755 * cs-parser.jay: Add more simple parsing error catches.
14757 * statement.cs (Switch): Add support for string switches.
14758 Handle null specially.
14760 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
14762 2001-11-28 Ravi Pratap <ravi@ximian.com>
14764 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
14766 (declare_local_constant): New helper function.
14768 * statement.cs (AddConstant): Keep a separate record of constants
14770 (IsConstant): Implement to determine if a variable is a constant.
14772 (GetConstantExpression): Implement.
14774 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
14776 * statement.cs (IsVariableDefined): Re-write.
14778 2001-11-27 Ravi Pratap <ravi@ximian.com>
14780 * class.cs (TypeContainer::FindMembers): Look for constants
14781 in the case when we are looking for MemberTypes.Field
14783 * expression.cs (MemberAccess::DoResolve): Check that in the
14784 case we are a FieldExpr and a Literal, we are not being accessed
14785 by an instance reference.
14787 * cs-parser.jay (local_constant_declaration): Implement.
14789 (declaration_statement): Implement for constant declarations.
14791 2001-11-26 Miguel de Icaza <miguel@ximian.com>
14793 * statement.cs (Switch): Catch double defaults.
14795 (Switch): More work on the switch() statement
14796 implementation. It works for integral values now, need to finish
14800 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14802 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
14803 integer literals into other integer literals. To be used by
14806 2001-11-24 Ravi Pratap <ravi@ximian.com>
14808 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
14811 (EmitDynamicInitializers): Cope with the above since we extract data
14812 directly from ArrayData now.
14814 (ExpectInitializers): Keep track of whether initializers are mandatory
14817 (Bounds): Make it a hashtable to prevent the same dimension being
14818 recorded for every element in that dimension.
14820 (EmitDynamicInitializers): Fix bug which prevented the Set array method
14823 Also fix bug which was causing the indices to be emitted in the reverse
14826 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14828 * expression.cs (ArrayCreation): Implement the bits that Ravi left
14829 unfinished. They do not work, because the underlying code is
14832 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14834 * cs-parser.jay: Remove bogus fixme.
14836 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
14837 on Switch statement.
14839 2001-11-23 Ravi Pratap <ravi@ximian.com>
14841 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
14844 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
14845 parameter. Apparently, any expression is allowed.
14847 (ValidateInitializers): Update accordingly.
14849 (CheckIndices): Fix some tricky bugs thanks to recursion.
14851 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
14852 I was being completely brain-dead.
14854 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
14855 and re-write acordingly.
14857 (DelegateInvocation): Re-write accordingly.
14859 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
14861 (MakeByteBlob): Handle types more correctly.
14863 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
14864 initialization from expressions but it is incomplete because I am a complete
14867 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14869 * statement.cs (If.Emit): Fix a bug that generated incorrect code
14870 on If. Basically, we have to return `true' (ie, we do return to
14871 our caller) only if both branches of the if return.
14873 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
14874 short-circuit operators, handle them as short circuit operators.
14876 (Cast.DoResolve): Resolve type.
14877 (Cast.Cast): Take an expression as the target type.
14879 * cs-parser.jay (cast_expression): Remove old hack that only
14880 allowed a limited set of types to be handled. Now we take a
14881 unary_expression and we resolve to a type during semantic
14884 Use the grammar productions from Rhys to handle casts (this is
14885 not complete like Rhys syntax yet, we fail to handle that corner
14886 case that C# has regarding (-x), but we will get there.
14888 2001-11-22 Ravi Pratap <ravi@ximian.com>
14890 * class.cs (EmitFieldInitializer): Take care of the case when we have a
14891 field which is an array type.
14893 * cs-parser.jay (declare_local_variables): Support array initialization too.
14895 * typemanager.cs (MakeKey): Implement.
14897 (everywhere): Use the above appropriately.
14899 * cs-parser.jay (for_statement): Update for array initialization while
14900 declaring variables.
14902 * ecore.cs : The error message was correct, it's the variable's names that
14903 were misleading ;-) Make the code more readable.
14905 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
14906 the correct type etc.
14908 (ConvertExplicit): Handle Enum types by examining the underlying type.
14910 2001-11-21 Ravi Pratap <ravi@ximian.com>
14912 * parameter.cs (GetCallingConvention): Always return
14913 CallingConventions.Standard for now.
14915 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14917 * expression.cs (Binary.ResolveOperator): Update the values of `l'
14918 and `r' after calling DoNumericPromotions.
14920 * ecore.cs: Fix error message (the types were in the wrong order).
14922 * statement.cs (Foreach.ProbeCollectionType): Need to pass
14923 BindingFlags.Instance as well
14925 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
14926 implicit int literal conversion in an empty cast so that we
14927 propagate the right type upstream.
14929 (UnboxCast): new class used to unbox value types.
14930 (Expression.ConvertExplicit): Add explicit type conversions done
14933 (Expression.ImplicitNumericConversion): Oops, forgot to test for
14934 the target type before applying the implicit LongLiterals to ULong
14937 2001-11-21 Miguel de Icaza <miguel@ximian.com>
14939 * cs-parser.jay (for_statement): Reworked the way For works: now
14940 we declare manually any variables that are introduced in
14941 for_initializer to solve the problem of having out-of-band code
14942 emition (that is what got for broken).
14944 (declaration_statement): Perform the actual variable declaration
14945 that used to be done in local_variable_declaration here.
14947 (local_variable_declaration): Do not declare anything, just pass
14948 the information on a DictionaryEntry
14950 2001-11-20 Ravi Pratap <ravi@ximian.com>
14952 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
14953 re-write of the logic to now make it recursive.
14955 (UpdateIndices): Re-write accordingly.
14957 Store element data in a separate ArrayData list in the above methods.
14959 (MakeByteBlob): Implement to dump the array data into a byte array.
14961 2001-11-19 Ravi Pratap <ravi@ximian.com>
14963 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
14966 * constant.cs (Define): Implement.
14968 (EmitConstant): Re-write fully.
14970 Pass in location info.
14972 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
14975 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
14976 DictionaryEntry since we need location info too.
14978 (constant_declaration): Update accordingly.
14980 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
14981 code into another method : UpdateIndices.
14983 2001-11-18 Ravi Pratap <ravi@ximian.com>
14985 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
14986 some type checking etc.
14988 2001-11-17 Ravi Pratap <ravi@ximian.com>
14990 * expression.cs (ArrayCreation::ValidateInitializers): Implement
14991 bits to provide dimension info if the user skips doing that.
14993 Update second constructor to store the rank correctly.
14995 2001-11-16 Ravi Pratap <ravi@ximian.com>
14997 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
14998 and try to implement.
15000 * ../errors/cs0150.cs : Add.
15002 * ../errors/cs0178.cs : Add.
15004 2001-11-16 Miguel de Icaza <miguel@ximian.com>
15006 * statement.cs: Implement foreach on multi-dimensional arrays.
15008 * parameter.cs (Parameters.GetParameterByName): Also lookup the
15009 name of the params argument.
15011 * expression.cs: Use EmitStoreOpcode to get the right opcode while
15012 initializing the array.
15014 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
15015 we can use this elsewhere.
15017 * statement.cs: Finish implementation of foreach for single
15020 * cs-parser.jay: Use an out-of-band stack to pass information
15021 around, I wonder why I need this.
15023 foreach_block: Make the new foreach_block the current_block.
15025 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
15026 function used to return a static Parameters structure. Used for
15027 empty parameters, as those are created very frequently.
15029 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
15031 2001-11-15 Ravi Pratap <ravi@ximian.com>
15033 * interface.cs : Default modifier is private, not public. The
15034 make verify test passes again.
15036 2001-11-15 Ravi Pratap <ravi@ximian.com>
15038 * support.cs (ReflectionParameters): Fix logic to determine
15039 whether the last parameter is a params one. Test 9 passes again.
15041 * delegate.cs (Populate): Register the builders we define with
15042 RegisterParameterForBuilder. Test 19 passes again.
15044 * cs-parser.jay (property_declaration): Reference $6 instead
15045 of $$ to get at the location.
15047 (indexer_declaration): Similar stuff.
15049 (attribute): Ditto.
15051 * class.cs (Property): Register parameters for the Get and Set methods
15052 if they exist. Test 23 passes again.
15054 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
15055 call to EmitArguments as we are sure there aren't any params arguments.
15056 Test 32 passes again.
15058 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
15059 IndexOutOfRangeException.
15061 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
15062 Test 33 now passes again.
15064 2001-11-15 Miguel de Icaza <miguel@ximian.com>
15066 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
15067 broke a bunch of things. Will have to come up with a better way
15068 of tracking locations.
15070 * statement.cs: Implemented foreach for single dimension arrays.
15072 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15074 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
15075 an error. This removes the lookup from the critical path.
15077 * cs-parser.jay: Removed use of temporary_loc, which is completely
15080 2001-11-14 Miguel de Icaza <miguel@ximian.com>
15082 * support.cs (ReflectionParameters.ParameterModifier): Report
15083 whether the argument is a PARAMS argument or not.
15085 * class.cs: Set the attribute `ParamArrayAttribute' on the
15086 parameter argument.
15088 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
15089 and cons_param_array_attribute (ConstructorInfo for
15090 ParamArrayAttribute).,
15092 * codegen.cs: Emit the return using the `Return' statement, that
15093 way we can report the error correctly for missing return values.
15095 * class.cs (Method.Emit): Clean up.
15097 * expression.cs (Argument.Resolve): Take another argument: the
15098 location where this argument is used. Notice that this is not
15099 part of the "Argument" class as to reduce the size of the
15100 structure (we know the approximate location anyways).
15102 Test if the argument is a variable-reference, if not, then
15103 complain with a 206.
15105 (Argument.Emit): Emit addresses of variables.
15107 (Argument.FullDesc): Simplify.
15109 (Invocation.DoResolve): Update for Argument.Resolve.
15111 (ElementAccess.DoResolve): ditto.
15113 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
15114 method should be virtual, as this method is always virtual.
15116 (NewDelegate.DoResolve): Update for Argument.Resolve.
15118 * class.cs (ConstructorInitializer.DoResolve): ditto.
15120 * attribute.cs (Attribute.Resolve): ditto.
15122 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15124 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
15126 * expression.cs (ParameterReference): Drop IStackStorage and implement
15127 IAssignMethod instead.
15129 (LocalVariableReference): ditto.
15131 * ecore.cs (FieldExpr): Drop IStackStorage and implement
15132 IAssignMethod instead.
15134 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15136 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
15137 enumerations that are used in heavily used structures derive from
15138 byte in a laughable and pathetic attempt to reduce memory usage.
15139 This is the kind of pre-optimzations that you should not do at
15140 home without adult supervision.
15142 * expression.cs (UnaryMutator): New class, used to handle ++ and
15143 -- separatedly from the other unary operators. Cleans up the
15144 code, and kills the ExpressionStatement dependency in Unary.
15146 (Unary): Removed `method' and `Arguments' from this class, making
15147 it smaller, and moving it all to SimpleCall, so I can reuse this
15148 code in other locations and avoid creating a lot of transient data
15149 strucutres when not required.
15151 * cs-parser.jay: Adjust for new changes.
15153 2001-11-11 Miguel de Icaza <miguel@ximian.com>
15155 * enum.cs (Enum.Populate): If there is a failure during
15158 * cs-parser.jay (opt_enum_base): we used to catch type errors
15159 here, but this is really incorrect. The type error should be
15160 catched during semantic analysis.
15162 2001-12-11 Ravi Pratap <ravi@ximian.com>
15164 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
15165 current_local_parameters as expected since I, in my stupidity, had forgotten
15168 * attribute.cs (GetValidPlaces): Fix stupid bug.
15170 * class.cs (Method::Emit): Perform check on applicability of attributes.
15172 (Constructor::Emit): Ditto.
15174 (Field::Emit): Ditto.
15176 (Field.Location): Store location information.
15178 (Property, Event, Indexer, Operator): Ditto.
15180 * cs-parser.jay (field_declaration): Pass in location for each field.
15182 * ../errors/cs0592.cs : Add.
15184 2001-11-12 Ravi Pratap <ravi@ximian.com>
15186 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
15188 (InitCoreTypes): Update accordingly.
15190 (RegisterAttrType, LookupAttr): Implement.
15192 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
15193 info about the same.
15195 (Resolve): Update to populate the above as necessary.
15197 (Error592): Helper.
15199 (GetValidPlaces): Helper to the above.
15201 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
15203 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
15205 2001-11-12 Ravi Pratap <ravi@ximian.com>
15207 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
15209 * ../errors/cs0617.cs : Add.
15211 2001-11-11 Ravi Pratap <ravi@ximian.com>
15213 * enum.cs (Emit): Rename to Populate to be more consistent with what
15214 we expect it to do and when exactly it is called.
15216 * class.cs, rootcontext.cs : Update accordingly.
15218 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
15219 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
15221 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
15223 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
15224 of a fieldinfo using the above, when dealing with a FieldBuilder.
15226 2001-11-10 Ravi Pratap <ravi@ximian.com>
15228 * ../errors/cs0031.cs : Add.
15230 * ../errors/cs1008.cs : Add.
15232 * ../errrors/cs0543.cs : Add.
15234 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
15237 (FindMembers): Implement.
15239 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
15240 enums and delegates too.
15242 (enum_types): Rename to builder_to_enum.
15244 (delegate_types): Rename to builder_to_delegate.
15246 * delegate.cs (FindMembers): Implement.
15248 2001-11-09 Ravi Pratap <ravi@ximian.com>
15250 * typemanager.cs (IsEnumType): Implement.
15252 * enum.cs (Emit): Re-write parts to account for the underlying type
15253 better and perform checking etc.
15255 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
15256 of the underlying type.
15258 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
15261 * enum.cs (error31): Helper to report error #31.
15263 * cs-parser.jay (enum_declaration): Store location of each member too.
15265 * enum.cs (member_to_location): New hashtable.
15267 (AddEnumMember): Update location hashtable.
15269 (Emit): Use the location of each member while reporting errors.
15271 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15273 * cs-parser.jay: A for_initializer if is a
15274 local_variable_declaration really ammount to have an implicit
15275 block with the variable declaration and no initializer for for.
15277 * statement.cs (For.Emit): Cope with null initializers.
15279 This fixes the infinite loop on for initializers.
15281 2001-11-08 Miguel de Icaza <miguel@ximian.com>
15283 * enum.cs: More cleanup.
15285 * ecore.cs: Remove dead code.
15287 * class.cs (Property.Emit): More simplification.
15288 (Event.Emit): ditto.
15290 Reworked to have less levels of indentation.
15292 2001-11-08 Ravi Pratap <ravi@ximian.com>
15294 * class.cs (Property): Emit attributes.
15304 * enum.cs (Emit): Ditto.
15306 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
15309 * class.cs (Field, Event, etc.): Move attribute generation into the
15310 Emit method everywhere.
15312 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15313 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15314 as we had no way of defining nested enums !
15316 * rootcontext.cs : Adjust code accordingly.
15318 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15320 2001-11-07 Ravi Pratap <ravi@ximian.com>
15322 * expression.cs (EvalConstantExpression): Move into ecore.cs
15324 * enum.cs (Enum): Rename some members and make them public and readonly
15325 according to our convention.
15327 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15330 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15332 (Enum::Emit): Write a simple version for now which doesn't try to compute
15333 expressions. I shall modify this to be more robust in just a while.
15335 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15337 (TypeContainer::CloseType): Create the Enum types too.
15339 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15341 * expression.cs (EvalConstantExpression): Get rid of completely.
15343 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15344 user-defined values and other cases.
15346 (IsValidEnumLiteral): Helper function.
15348 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15349 out there in the case we had a literal FieldExpr.
15351 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15353 (Literalize): Revamp a bit to take two arguments.
15355 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15357 2001-11-06 Ravi Pratap <ravi@ximian.com>
15359 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15361 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15363 (Resolve): Use the above to ensure we have proper initializers.
15365 2001-11-05 Ravi Pratap <ravi@ximian.com>
15367 * expression.cs (Expression::EvalConstantExpression): New method to
15368 evaluate constant expressions.
15370 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15372 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15374 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15377 (Binary.ResolveOperator): Handle operator != (object a, object b)
15378 and operator == (object a, object b);
15380 (Binary.DoNumericPromotions): Indicate whether the numeric
15381 promotion was possible.
15383 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15386 Made the ArrayAccess implement interface IAssignMethod instead of
15387 IStackStore as the order in which arguments are passed reflects
15390 * assign.cs: Instead of using expr.ExprClass to select the way of
15391 assinging, probe for the IStackStore/IAssignMethod interfaces.
15393 * typemanager.cs: Load InitializeArray definition.
15395 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15396 static data that can be used to initialize arrays.
15398 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15400 * expression.cs: Handle operator== and operator!= for booleans.
15402 (Conditioal.Reduce): Implement reducer for the ?: operator.
15404 (Conditional.Resolve): Implement dead code elimination.
15406 (Binary.Resolve): Catch string literals and return a new
15407 concatenated string.
15409 (Unary.Reduce): Implement reduction of unary expressions.
15411 * ecore.cs: Split out the expression core handling here.
15413 (Expression.Reduce): New method used to perform constant folding
15414 and CSE. This is needed to support constant-expressions.
15416 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15417 targets, and optimize for !x.
15419 2001-11-04 Ravi Pratap <ravi@ximian.com>
15421 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15422 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15423 set custom atttributes.
15425 * literal.cs (Literal::GetValue): New abstract method to return the actual
15426 value of the literal, cast as an object.
15428 (*Literal): Implement GetValue method.
15430 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15431 expressions to the arraylist but objects of type Argument.
15433 * class.cs (TypeContainer::Emit): Emit our attributes too.
15435 (Method::Emit, Constructor::Emit): Ditto.
15437 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15438 to be ignoring earlier.
15440 2001-11-03 Ravi Pratap <ravi@ximian.com>
15442 * attribute.cs (AttributeSection::Define): Implement to do the business
15443 of constructing a CustomAttributeBuilder.
15445 (Attribute): New trivial class. Increases readability of code.
15447 * cs-parser.jay : Update accordingly.
15449 (positional_argument_list, named_argument_list, named_argument): New rules
15451 (attribute_arguments): Use the above so that we are more correct.
15453 2001-11-02 Ravi Pratap <ravi@ximian.com>
15455 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15456 to perform all checks for a method with a params parameter.
15458 (Invocation::OverloadResolve): Update to use the above method and therefore
15459 cope correctly with params method invocations.
15461 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15464 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15465 constructors in our parent too because we can't afford to miss out on
15468 * attribute.cs (AttributeSection): New name for the class Attribute
15470 Other trivial changes to improve readability.
15472 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15473 use the new class names.
15475 2001-11-01 Ravi Pratap <ravi@ximian.com>
15477 * class.cs (Method::Define): Complete definition for params types too
15479 (Indexer::Define): Ditto.
15481 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15482 Cope everywhere with a request for info about the array parameter.
15484 2001-11-01 Ravi Pratap <ravi@ximian.com>
15486 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15488 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15489 local_variable_type to extract the string corresponding to the type.
15491 (local_variable_type): Fixup the action to use the new helper method.
15493 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15496 * expression.cs : Clean out code which uses the above.
15498 2001-10-31 Ravi Pratap <ravi@ximian.com>
15500 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15501 and bale out if necessary by returning a false.
15503 (RegisterProperty): Ditto.
15505 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15506 and print out appropriate error messages.
15508 * interface.cs (everywhere): Ditto.
15510 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15511 location to constructor.
15513 * class.cs (Property, Event, Indexer): Update accordingly.
15515 * ../errors/cs111.cs : Added.
15517 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15518 of a method, as laid down by the spec.
15520 (Invocation::OverloadResolve): Use the above method.
15522 2001-10-31 Ravi Pratap <ravi@ximian.com>
15524 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15525 now take a TypeContainer and a Parameters object.
15527 (ParameterData): Modify return type of ParameterModifier method to be
15528 Parameter.Modifier and not a string.
15530 (ReflectionParameters, InternalParameters): Update accordingly.
15532 * expression.cs (Argument::GetParameterModifier): Same here.
15534 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15535 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15536 symbol in it at all so maybe this is only for now.
15538 2001-10-30 Ravi Pratap <ravi@ximian.com>
15540 * support.cs (InternalParameters): Constructor now takes an extra argument
15541 which is the actual Parameters class.
15543 (ParameterDesc): Update to provide info on ref/out modifiers.
15545 * class.cs (everywhere): Update call to InternalParameters to pass in
15546 the second argument too.
15548 * support.cs (ParameterData): Add ParameterModifier, which is a method
15549 to return the modifier info [ref/out etc]
15551 (InternalParameters, ReflectionParameters): Implement the above.
15553 * expression.cs (Argument::ParameterModifier): Similar function to return
15554 info about the argument's modifiers.
15556 (Invocation::OverloadResolve): Update to take into account matching modifiers
15559 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15560 a new SetFormalParameters object which we pass to InternalParameters.
15562 2001-10-30 Ravi Pratap <ravi@ximian.com>
15564 * expression.cs (NewArray): Merge into the ArrayCreation class.
15566 2001-10-29 Ravi Pratap <ravi@ximian.com>
15568 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15569 NewUserdefinedArray into one as there wasn't much of a use in having
15572 * expression.cs (Argument): Change field's name to ArgType from Type.
15574 (Type): New readonly property which returns the proper type, taking into
15575 account ref/out modifiers.
15577 (everywhere): Adjust code accordingly for the above.
15579 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15580 whether we are emitting for a ref or out parameter.
15582 * expression.cs (Argument::Emit): Use the above field to set the state.
15584 (LocalVariableReference::Emit): Update to honour the flag and emit the
15587 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15589 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15591 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15593 (ReflectionParameters, InternalParameters): Implement the above method.
15595 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15598 (Invocation::FullMethodDesc): Ditto.
15600 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15602 * cs-parser.jay: Add extra production for the second form of array
15605 * expression.cs (ArrayCreation): Update to reflect the above
15608 * Small changes to prepare for Array initialization.
15610 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15612 * typemanager.cs (ImplementsInterface): interface might be null;
15613 Deal with this problem;
15615 Also, we do store negative hits on the cache (null values), so use
15616 this instead of calling t.GetInterfaces on the type everytime.
15618 2001-10-28 Ravi Pratap <ravi@ximian.com>
15620 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15622 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15623 split functionality out into different classes.
15625 (New::FormArrayType): Move into NewBuiltinArray.
15627 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15630 (NewBuiltinArray): New class to handle creation of built-in arrays.
15632 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15633 account creation of one-dimensional arrays.
15635 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15637 (NewUserdefinedArray::DoResolve): Implement.
15639 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15641 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15642 we maintain inside the TypeManager. This is necessary to perform lookups on the
15645 (LookupType): Update to perform GetType on the module builders too.
15647 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15649 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15651 2001-10-23 Ravi Pratap <ravi@ximian.com>
15653 * expression.cs (New::DoResolve): Implement guts of array creation.
15655 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15657 2001-10-27 Miguel de Icaza <miguel@ximian.com>
15659 * expression.cs: Fix bug I introduced lsat night that broke
15662 (Expression.Resolve): Report a 246 error (can not resolve name)
15663 if we find a SimpleName in the stream.
15665 (Expression.ResolveLValue): Ditto.
15667 (Expression.ResolveWithSimpleName): This function is a variant of
15668 ResolveName, this one allows SimpleNames to be returned without a
15669 warning. The only consumer of SimpleNames is MemberAccess
15671 2001-10-26 Miguel de Icaza <miguel@ximian.com>
15673 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
15674 might arrive here. I have my doubts that this is correct.
15676 * statement.cs (Lock): Implement lock statement.
15678 * cs-parser.jay: Small fixes to support `lock' and `using'
15680 * cs-tokenizer.cs: Remove extra space
15682 * driver.cs: New flag --checked, allows to turn on integer math
15685 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
15686 Threading.Monitor.Exit
15688 2001-10-23 Miguel de Icaza <miguel@ximian.com>
15690 * expression.cs (IndexerAccess::DoResolveLValue): Set the
15691 Expression Class to be IndexerAccess.
15693 Notice that Indexer::DoResolve sets the eclass to Value.
15695 2001-10-22 Miguel de Icaza <miguel@ximian.com>
15697 * class.cs (TypeContainer::Emit): Emit code for indexers.
15699 * assign.cs (IAssignMethod): New interface implemented by Indexers
15700 and Properties for handling assignment.
15702 (Assign::Emit): Simplify and reuse code.
15704 * expression.cs (IndexerAccess, PropertyExpr): Implement
15705 IAssignMethod, clean up old code.
15707 2001-10-22 Ravi Pratap <ravi@ximian.com>
15709 * typemanager.cs (ImplementsInterface): New method to determine if a type
15710 implements a given interface. Provides a nice cache too.
15712 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
15715 (ConvertReferenceExplicit): Ditto.
15717 * delegate.cs (Delegate::Populate): Update to define the parameters on the
15718 various methods, with correct names etc.
15720 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
15721 Operator.UnaryNegation.
15723 * cs-parser.jay (operator_declarator): Be a little clever in the case where
15724 we have a unary plus or minus operator.
15726 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
15729 * everywhere : update accordingly.
15731 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
15734 * class.cs (Method::Define): For the case where we are implementing a method
15735 inherited from an interface, we need to set the MethodAttributes.Final flag too.
15736 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
15738 2001-10-21 Ravi Pratap <ravi@ximian.com>
15740 * interface.cs (FindMembers): Implement to work around S.R.E
15743 * typemanager.cs (IsInterfaceType): Implement.
15745 (FindMembers): Update to handle interface types too.
15747 * expression.cs (ImplicitReferenceConversion): Re-write bits which
15748 use IsAssignableFrom as that is not correct - it doesn't work.
15750 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
15751 and accordingly override EmitStatement.
15753 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
15754 using the correct logic :-)
15756 2001-10-19 Ravi Pratap <ravi@ximian.com>
15758 * ../errors/cs-11.cs : Add to demonstrate error -11
15760 2001-10-17 Miguel de Icaza <miguel@ximian.com>
15762 * assign.cs (Assign::Resolve): Resolve right hand side first, and
15763 then pass this as a hint to ResolveLValue.
15765 * expression.cs (FieldExpr): Add Location information
15767 (FieldExpr::LValueResolve): Report assignment to readonly
15770 (Expression::ExprClassFromMemberInfo): Pass location information.
15772 (Expression::ResolveLValue): Add new method that resolves an
15775 (Expression::DoResolveLValue): Default invocation calls
15778 (Indexers): New class used to keep track of indexers in a given
15781 (IStackStore): Renamed from LValue, as it did not really describe
15782 what this did. Also ResolveLValue is gone from this interface and
15783 now is part of Expression.
15785 (ElementAccess): Depending on the element access type
15787 * typemanager.cs: Add `indexer_name_type' as a Core type
15788 (System.Runtime.CompilerServices.IndexerNameAttribute)
15790 * statement.cs (Goto): Take a location.
15792 2001-10-18 Ravi Pratap <ravi@ximian.com>
15794 * delegate.cs (Delegate::VerifyDelegate): New method to verify
15795 if two delegates are compatible.
15797 (NewDelegate::DoResolve): Update to take care of the case when
15798 we instantiate a delegate from another delegate.
15800 * typemanager.cs (FindMembers): Don't even try to look up members
15801 of Delegate types for now.
15803 2001-10-18 Ravi Pratap <ravi@ximian.com>
15805 * delegate.cs (NewDelegate): New class to take care of delegate
15808 * expression.cs (New): Split the delegate related code out into
15809 the NewDelegate class.
15811 * delegate.cs (DelegateInvocation): New class to handle delegate
15814 * expression.cs (Invocation): Split out delegate related code into
15815 the DelegateInvocation class.
15817 2001-10-17 Ravi Pratap <ravi@ximian.com>
15819 * expression.cs (New::DoResolve): Implement delegate creation fully
15820 and according to the spec.
15822 (New::DoEmit): Update to handle delegates differently.
15824 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
15825 because of which we were printing out arguments in reverse order !
15827 * delegate.cs (VerifyMethod): Implement to check if the given method
15828 matches the delegate.
15830 (FullDelegateDesc): Implement.
15832 (VerifyApplicability): Implement.
15834 * expression.cs (Invocation::DoResolve): Update to accordingly handle
15835 delegate invocations too.
15837 (Invocation::Emit): Ditto.
15839 * ../errors/cs1593.cs : Added.
15841 * ../errors/cs1594.cs : Added.
15843 * delegate.cs (InstanceExpression, TargetMethod): New properties.
15845 2001-10-16 Ravi Pratap <ravi@ximian.com>
15847 * typemanager.cs (intptr_type): Core type for System.IntPtr
15849 (InitCoreTypes): Update for the same.
15851 (iasyncresult_type, asynccallback_type): Ditto.
15853 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
15856 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
15859 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
15860 the builders for the 4 members of a delegate type :-)
15862 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
15865 * expression.cs (New::DoResolve): Implement guts for delegate creation.
15867 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
15869 2001-10-15 Miguel de Icaza <miguel@ximian.com>
15871 * statement.cs (Break::Emit): Implement.
15872 (Continue::Emit): Implement.
15874 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
15875 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
15876 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
15877 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
15880 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
15881 properties that track the label for the current loop (begin of the
15882 loop and end of the loop).
15884 2001-10-15 Ravi Pratap <ravi@ximian.com>
15886 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
15887 use of emitting anything at all.
15889 * class.cs, rootcontext.cs : Get rid of calls to the same.
15891 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
15893 (Populate): Define the constructor correctly and set the implementation
15896 * typemanager.cs (delegate_types): New hashtable to hold delegates that
15899 (AddDelegateType): Implement.
15901 (IsDelegateType): Implement helper method.
15903 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
15905 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
15906 and accordingly handle it.
15908 * delegate.cs (Populate): Take TypeContainer argument.
15909 Implement bits to define the Invoke method. However, I still haven't figured out
15910 how to take care of the native int bit :-(
15912 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
15913 Qualify the name of the delegate, not its return type !
15915 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
15918 (StandardConversionExists): Checking for array types turns out to be recursive.
15920 (ConvertReferenceExplicit): Implement array conversion.
15922 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
15924 2001-10-12 Ravi Pratap <ravi@ximian.com>
15926 * cs-parser.jay (delegate_declaration): Store the fully qualified
15927 name as it is a type declaration.
15929 * delegate.cs (ReturnType, Name): Rename members to these. Make them
15932 (DefineDelegate): Renamed from Define. Does the same thing essentially,
15933 as TypeContainer::DefineType.
15935 (Populate): Method in which all the definition of the various methods (Invoke)
15938 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
15941 (CloseDelegate): Finally creates the delegate.
15943 * class.cs (TypeContainer::DefineType): Update to define delegates.
15944 (Populate, Emit and CloseType): Do the same thing here too.
15946 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
15947 delegates in all these operations.
15949 2001-10-14 Miguel de Icaza <miguel@ximian.com>
15951 * expression.cs: LocalTemporary: a new expression used to
15952 reference a temporary that has been created.
15954 * assign.cs: Handle PropertyAccess back here, so that we can
15955 provide the proper semantic access to properties.
15957 * expression.cs (Expression::ConvertReferenceExplicit): Implement
15958 a few more explicit conversions.
15960 * modifiers.cs: `NEW' modifier maps to HideBySig.
15962 * expression.cs (PropertyExpr): Make this into an
15963 ExpressionStatement, and support the EmitStatement code path.
15965 Perform get/set error checking, clean up the interface.
15967 * assign.cs: recognize PropertyExprs as targets, and if so, turn
15968 them into toplevel access objects.
15970 2001-10-12 Miguel de Icaza <miguel@ximian.com>
15972 * expression.cs: PropertyExpr::PropertyExpr: use work around the
15975 * typemanager.cs: Keep track here of our PropertyBuilders again to
15976 work around lameness in SRE.
15978 2001-10-11 Miguel de Icaza <miguel@ximian.com>
15980 * expression.cs (LValue::LValueResolve): New method in the
15981 interface, used to perform a second resolution pass for LValues.
15983 (This::DoResolve): Catch the use of this in static methods.
15985 (This::LValueResolve): Implement.
15987 (This::Store): Remove warning, assigning to `this' in structures
15990 (Invocation::Emit): Deal with invocation of
15991 methods on value types. We need to pass the address to structure
15992 methods rather than the object itself. (The equivalent code to
15993 emit "this" for structures leaves the entire structure on the
15994 stack instead of a pointer to it).
15996 (ParameterReference::DoResolve): Compute the real index for the
15997 argument based on whether the method takes or not a `this' pointer
15998 (ie, the method is static).
16000 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
16001 value types returned from functions when we need to invoke a
16002 method on the sturcture.
16005 2001-10-11 Ravi Pratap <ravi@ximian.com>
16007 * class.cs (TypeContainer::DefineType): Method to actually do the business of
16008 defining the type in the Modulebuilder or Typebuilder. This is to take
16009 care of nested types which need to be defined on the TypeBuilder using
16010 DefineNestedMethod.
16012 (TypeContainer::GetClassBases): Implement. Essentially the code from the
16013 methods in RootContext, only ported to be part of TypeContainer.
16015 (TypeContainer::GetInterfaceOrClass): Ditto.
16017 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
16019 * interface.cs (Interface::DefineInterface): New method. Does exactly
16020 what RootContext.CreateInterface did earlier, only it takes care of nested types
16023 (Interface::GetInterfaces): Move from RootContext here and port.
16025 (Interface::GetInterfaceByName): Same here.
16027 * rootcontext.cs (ResolveTree): Re-write.
16029 (PopulateTypes): Re-write.
16031 * class.cs (TypeContainer::Populate): Populate nested types too.
16032 (TypeContainer::Emit): Emit nested members too.
16034 * typemanager.cs (AddUserType): Do not make use of the FullName property,
16035 instead just use the name argument passed in as it is already fully
16038 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
16039 to TypeContainer mapping to see if a type is user-defined.
16041 * class.cs (TypeContainer::CloseType): Implement.
16043 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
16044 the default constructor.
16046 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
16049 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
16051 * interface.cs (CloseType): Create the type here.
16053 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
16056 Remove all the methods which are now in TypeContainer.
16058 2001-10-10 Ravi Pratap <ravi@ximian.com>
16060 * delegate.cs (Define): Re-write bits to define the delegate
16063 2001-10-10 Miguel de Icaza <miguel@ximian.com>
16065 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
16067 * expression.cs (ImplicitReferenceConversion): handle null as well
16068 as a source to convert to any reference type.
16070 * statement.cs (Return): Perform any implicit conversions to
16071 expected return type.
16073 Validate use of return statement.
16075 * codegen.cs (EmitContext): Pass the expected return type here.
16077 * class.cs (Method, Constructor, Property): Pass expected return
16078 type to EmitContext.
16080 2001-10-09 Miguel de Icaza <miguel@ximian.com>
16082 * expression.cs: Make DoResolve take an EmitContext instead of a
16085 Replaced `l' and `location' for `loc', for consistency.
16087 (Error, Warning): Remove unneeded Tc argument.
16089 * assign.cs, literal.cs, constant.cs: Update to new calling
16092 * codegen.cs: EmitContext now contains a flag indicating whether
16093 code is being generated in a static method or not.
16095 * cs-parser.jay: DecomposeQI, new function that replaces the old
16096 QualifiedIdentifier. Now we always decompose the assembled
16097 strings from qualified_identifier productions into a group of
16100 2001-10-08 Miguel de Icaza <miguel@ximian.com>
16102 * rootcontext.cs: Deal with field-less struct types correctly now
16103 by passing the size option to Define Type.
16105 * class.cs: Removed hack that created one static field.
16107 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16109 * statement.cs: Moved most of the code generation here.
16111 2001-10-09 Ravi Pratap <ravi@ximian.com>
16113 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
16116 (ElementAccess): Remove useless bits for now - keep checks as the spec
16119 2001-10-08 Ravi Pratap <ravi@ximian.com>
16121 * expression.cs (ElementAccess::DoResolve): Remove my crap code
16122 and start performing checks according to the spec.
16124 2001-10-07 Ravi Pratap <ravi@ximian.com>
16126 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
16127 rank_specifiers instead.
16129 (rank_specifiers): Change the order in which the rank specifiers are stored
16131 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
16133 * expression.cs (ElementAccess): Implement the LValue interface too.
16135 2001-10-06 Ravi Pratap <ravi@ximian.com>
16137 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
16138 except that user defined conversions are not included.
16140 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
16141 perform the conversion of the return type, if necessary.
16143 (New::DoResolve): Check whether we are creating an array or an object
16144 and accordingly do the needful.
16146 (New::Emit): Same here.
16148 (New::DoResolve): Implement guts of array creation.
16150 (New::FormLookupType): Helper function.
16152 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16154 * codegen.cs: Removed most of the code generation here, and move the
16155 corresponding code generation bits to the statement classes.
16157 Added support for try/catch/finalize and throw.
16159 * cs-parser.jay: Added support for try/catch/finalize.
16161 * class.cs: Catch static methods having the flags override,
16162 virtual or abstract.
16164 * expression.cs (UserCast): This user cast was not really doing
16165 what it was supposed to do. Which is to be born in fully resolved
16166 state. Parts of the resolution were being performed at Emit time!
16170 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16172 * expression.cs: Implicity convert the result from UserCast.
16174 2001-10-05 Ravi Pratap <ravi@ximian.com>
16176 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
16177 prevented it from working correctly.
16179 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
16180 merely ConvertImplicit.
16182 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16184 * typemanager.cs: Make the LookupTypeContainer function static,
16185 and not per-instance.
16187 * class.cs: Make static FindMembers (the one that takes a Type
16190 * codegen.cs: Add EmitForeach here.
16192 * cs-parser.jay: Make foreach a toplevel object instead of the
16193 inline expansion, as we need to perform semantic analysis on it.
16195 2001-10-05 Ravi Pratap <ravi@ximian.com>
16197 * expression.cs (Expression::ImplicitUserConversion): Rename to
16198 UserDefinedConversion.
16200 (Expression::UserDefinedConversion): Take an extra argument specifying
16201 whether we look for explicit user conversions too.
16203 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
16205 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
16207 (ExplicitUserConversion): Make it a call to UserDefinedConversion
16208 with the appropriate arguments.
16210 * cs-parser.jay (cast_expression): Record location too.
16212 * expression.cs (Cast): Record location info.
16214 (Expression::ConvertExplicit): Take location argument.
16216 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
16217 to determine if we are doing explicit conversions.
16219 (UserCast::Emit): Update accordingly.
16221 (Expression::ConvertExplicit): Report an error if everything fails.
16223 * ../errors/cs0030.cs : Add.
16225 2001-10-04 Miguel de Icaza <miguel@ximian.com>
16227 * modifiers.cs: If the ABSTRACT keyword is present, also set the
16228 virtual and newslot bits.
16230 * class.cs (TypeContainer::RegisterRequiredImplementations):
16231 Record methods we need.
16233 (TypeContainer::MakeKey): Helper function to make keys for
16234 MethodBases, since the Methodbase key is useless.
16236 (TypeContainer::Populate): Call RegisterRequiredImplementations
16237 before defining the methods.
16239 Create a mapping for method_builders_to_methods ahead of time
16240 instead of inside a tight loop.
16242 (::RequireMethods): Accept an object as the data to set into the
16243 hashtable so we can report interface vs abstract method mismatch.
16245 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16247 * report.cs: Make all of it static.
16249 * rootcontext.cs: Drop object_type and value_type computations, as
16250 we have those in the TypeManager anyways.
16252 Drop report instance variable too, now it is a global.
16254 * driver.cs: Use try/catch on command line handling.
16256 Add --probe option to debug the error reporting system with a test
16259 * report.cs: Add support for exiting program when a probe
16260 condition is reached.
16262 2001-10-03 Ravi Pratap <ravi@ximian.com>
16264 * expression.cs (Binary::DoNumericPromotions): Fix the case when
16265 we do a forcible conversion regardless of type, to check if
16266 ForceConversion returns a null.
16268 (Binary::error19): Use location to report error.
16270 (Unary::error23): Use location here too.
16272 * ../errors/cs0019.cs : Check in.
16274 * ../errors/cs0023.cs : Check in.
16276 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
16277 case of a non-null MethodInfo object with a length of 0 !
16279 (Binary::ResolveOperator): Flag error if overload resolution fails to find
16280 an applicable member - according to the spec :-)
16281 Also fix logic to find members in base types.
16283 (Unary::ResolveOperator): Same here.
16285 (Unary::report23): Change name to error23 and make first argument a TypeContainer
16286 as I was getting thoroughly confused between this and error19 :-)
16288 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
16289 (::FindMostEncompassedType): Implement.
16290 (::FindMostEncompassingType): Implement.
16291 (::StandardConversionExists): Implement.
16293 (UserImplicitCast): Re-vamp. We now need info about most specific
16294 source and target types so that we can do the necessary conversions.
16296 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
16297 mathematical union with no duplicates.
16299 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16301 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
16302 in order from base classes to child classes, so that we can in
16303 child classes look up in our parent for method names and
16304 attributes (required for handling abstract, virtual, new, override
16305 constructs: we need to instrospect our base class, and if we dont
16306 populate the classes in order, the introspection might be
16307 incorrect. For example, a method could query its parent before
16308 the parent has any methods and would determine that the parent has
16309 no abstract methods (while it could have had them)).
16311 (RootContext::CreateType): Record the order in which we define the
16314 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16316 * class.cs (TypeContainer::Populate): Also method definitions can
16317 fail now, keep track of this.
16319 (TypeContainer::FindMembers): Implement support for
16320 DeclaredOnly/noDeclaredOnly flag.
16322 (Constructor::Emit) Return the ConstructorBuilder.
16324 (Method::Emit) Return the MethodBuilder.
16325 Check for abstract or virtual methods to be public.
16327 * rootcontext.cs (RootContext::CreateType): Register all the
16328 abstract methods required for the class to be complete and the
16329 interface methods that must be implemented.
16331 * cs-parser.jay: Report error 501 (method requires body if it is
16332 not marked abstract or extern).
16334 * expression.cs (TypeOf::Emit): Implement.
16336 * typemanager.cs: runtime_handle_type, new global type.
16338 * class.cs (Property::Emit): Generate code for properties.
16340 2001-10-02 Ravi Pratap <ravi@ximian.com>
16342 * expression.cs (Unary::ResolveOperator): Find operators on base type
16343 too - we now conform exactly to the spec.
16345 (Binary::ResolveOperator): Same here.
16347 * class.cs (Operator::Define): Fix minor quirk in the tests.
16349 * ../errors/cs0215.cs : Added.
16351 * ../errors/cs0556.cs : Added.
16353 * ../errors/cs0555.cs : Added.
16355 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16357 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16358 single integer which is really efficient
16360 2001-10-01 Ravi Pratap <ravi@ximian.com>
16362 * expression.cs (Expression::ImplicitUserConversion): Use location
16363 even in the case when we are examining True operators.
16365 * class.cs (Operator::Define): Perform extensive checks to conform
16366 with the rules for operator overloading in the spec.
16368 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16369 some of the other conversions mentioned in the spec.
16371 * typemanager.cs (array_type): New static member for the System.Array built-in
16374 (cloneable_interface): For System.ICloneable interface.
16376 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16377 we start resolving the tree and populating types.
16379 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16381 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16383 * expression.cs (Expression::ExprClassFromMemberInfo,
16384 Expression::Literalize): Create literal expressions from
16385 FieldInfos which are literals.
16387 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16388 type casts, because they were wrong. The test suite in tests
16391 (ImplicitNumericConversion): ushort to ulong requires a widening
16394 Int32 constant to long requires widening cast as well.
16396 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16397 for integers because the type on the stack is not i4.
16399 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16401 * expression.cs (report118): require location argument.
16403 * parameter.cs: Do not dereference potential null value.
16405 * class.cs: Catch methods that lack the `new' keyword when
16406 overriding a name. Report warnings when `new' is used without
16407 anything being there to override.
16409 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16411 * class.cs: Only add constructor to hashtable if it is non-null
16412 (as now constructors can fail on define).
16414 (TypeManager, Class, Struct): Take location arguments.
16416 Catch field instance initialization in structs as errors.
16418 accepting_filter: a new filter for FindMembers that is static so
16419 that we dont create an instance per invocation.
16421 (Constructor::Define): Catch errors where a struct constructor is
16424 * cs-parser.jay: Pass location information for various new
16427 * delegate.cs (Delegate): take a location argument.
16429 * driver.cs: Do not call EmitCode if there were problesm in the
16430 Definition of the types, as many Builders wont be there.
16432 * decl.cs (Decl::Decl): Require a location argument.
16434 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16435 into integers, and find the most appropiate integer for it.
16437 * literal.cs: Implement ULongLiteral.
16439 * rootcontext.cs: Provide better information about the location of
16440 failure when CreateType fails.
16442 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16444 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16447 * expression.cs (Binary::CheckShiftArguments): Add missing type
16449 (Binary::ResolveOperator): Add type to the logical and and logical
16450 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16453 (Binary::DoNumericPromotions): In the case where either argument
16454 is ulong (and most signed types combined with ulong cause an
16455 error) perform implicit integer constant conversions as well.
16457 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16459 * expression.cs (UserImplicitCast): Method should always be
16461 (Invocation::BetterConversion): Simplified test for IntLiteral.
16463 (Expression::ImplicitNumericConversion): Split this routine out.
16464 Put the code that performs implicit constant integer conversions
16467 (Expression::Resolve): Become a wrapper around DoResolve so we can
16468 check eclass and type being set after resolve.
16470 (Invocation::Badness): Remove this dead function
16472 (Binary::ResolveOperator): Do not compute the expensive argumnets
16473 unless we have a union for it.
16475 (Probe::Emit): Is needs to do an isinst and then
16476 compare against null.
16478 (::CanConvert): Added Location argument. If the Location argument
16479 is null (Location.Null), then we do not report errors. This is
16480 used by the `probe' mechanism of the Explicit conversion. We do
16481 not want to generate an error for something that the user
16482 explicitly requested to be casted. But the pipeline for an
16483 explicit cast first tests for potential implicit casts.
16485 So for now, if the Location is null, it means `Probe only' to
16486 avoid adding another argument. Might have to revise this
16489 (ClassCast): New class used to type cast objects into arbitrary
16490 classes (used in Explicit Reference Conversions).
16492 Implement `as' as well.
16494 Reverted all the patches from Ravi below: they were broken:
16496 * The use of `level' as a mechanism to stop recursive
16497 invocations is wrong. That was there just to catch the
16498 bug with a strack trace but not as a way of addressing
16501 To fix the problem we have to *understand* what is going
16502 on and the interactions and come up with a plan, not
16503 just get things going.
16505 * The use of the type conversion cache that I proposed
16506 last night had an open topic: How does this work across
16507 protection domains. A user defined conversion might not
16508 be public in the location where we are applying the
16509 conversion, a different conversion might be selected
16510 (ie, private A->B (better) but public B->A (worse),
16511 inside A, A->B applies, but outside it, B->A will
16514 * On top of that (ie, even if the above is solved),
16515 conversions in a cache need to be abstract. Ie, `To
16516 convert from an Int to a Short use an OpcodeCast', not
16517 `To convert from an Int to a Short use the OpcodeCast on
16518 the variable 5' (which is what this patch was doing).
16520 2001-09-28 Ravi Pratap <ravi@ximian.com>
16522 * expression.cs (Invocation::ConversionExists): Re-write to use
16523 the conversion cache
16525 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16526 cache all conversions done, not just user-defined ones.
16528 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16529 to determine if a conversion exists instead of acutually trying to
16530 perform the conversion. It's faster too.
16532 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16533 and only then attempt the implicit conversion.
16535 2001-09-28 Ravi Pratap <ravi@ximian.com>
16537 * expression.cs (ConvertImplicit): Use a cache for conversions
16538 already found. Check level of recursion and bail out if necessary.
16540 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16542 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16543 Export standard methods that we expect for string operations.
16545 * statement.cs (Block::UsageWarning): Track usage of variables and
16546 report the errors for not used variables.
16548 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16551 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16553 * codegen.cs: remove unnneded code
16555 * expression.cs: Removed BuiltinTypeAccess class
16557 Fix the order in which implicit conversions are
16560 The previous fixed dropped support for boxed conversions (adding a
16561 test to the test suite now)
16563 (UserImplicitCast::CanConvert): Remove test for source being null,
16564 that code is broken. We should not feed a null to begin with, if
16565 we do, then we should track the bug where the problem originates
16566 and not try to cover it up here.
16568 Return a resolved expression of type UserImplicitCast on success
16569 rather than true/false. Ravi: this is what I was talking about,
16570 the pattern is to use a static method as a "constructor" for
16573 Also, do not create arguments until the very last minute,
16574 otherwise we always create the arguments even for lookups that
16575 will never be performed.
16577 (UserImplicitCast::Resolve): Eliminate, objects of type
16578 UserImplicitCast are born in a fully resolved state.
16580 * typemanager.cs (InitCoreTypes): Init also value_type
16581 (System.ValueType).
16583 * expression.cs (Cast::Resolve): First resolve the child expression.
16585 (LValue): Add new method AddressOf to be used by
16588 Change the argument of Store to take an EmitContext instead of an
16589 ILGenerator, because things like FieldExpr need to be able to call
16590 their children expression to generate the instance code.
16592 (Expression::Error, Expression::Warning): Sugar functions for
16595 (Expression::MemberLookup): Accept a TypeContainer instead of a
16596 Report as the first argument.
16598 (Expression::ResolvePrimary): Killed. I still want to improve
16599 this as currently the code is just not right.
16601 (Expression::ResolveMemberAccess): Simplify, but it is still
16604 (Unary::Resolve): Catch errors in AddressOf operators.
16606 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16607 index to a byte for the short-version, or the compiler will choose
16608 the wrong Emit call, which generates the wrong data.
16610 (ParameterReference::Emit, ::Store): same.
16612 (FieldExpr::AddressOf): Implement.
16614 * typemanager.cs: TypeManager: made public variable instead of
16617 * driver.cs: document --fatal.
16619 * report.cs (ErrorMessage, WarningMessage): new names for the old
16620 Error and Warning classes.
16622 * cs-parser.jay (member_access): Turn built-in access to types
16623 into a normal simplename
16625 2001-09-27 Ravi Pratap <ravi@ximian.com>
16627 * expression.cs (Invocation::BetterConversion): Fix to cope
16628 with q being null, since this was introducing a bug.
16630 * expression.cs (ConvertImplicit): Do built-in conversions first.
16632 2001-09-27 Ravi Pratap <ravi@ximian.com>
16634 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16636 2001-09-27 Ravi Pratap <ravi@ximian.com>
16638 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16639 I had introduced long ago (what's new ?).
16641 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16642 the work of all the checking.
16643 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16644 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16646 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16647 that is the right way.
16649 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16650 overloading resolution. Use everywhere instead of cutting and pasting code.
16652 (Binary::ResolveOperator): Use MakeUnionSet.
16654 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16655 we have to convert to bool types. Not complete yet.
16657 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16659 * typemanager.cs (TypeManager::CSharpName): support ushort.
16661 * expression.cs (Expression::TryImplicitIntConversion): Attempts
16662 to provide an expression that performsn an implicit constant int
16663 conversion (section 6.1.6).
16664 (Expression::ConvertImplicitRequired): Reworked to include
16665 implicit constant expression conversions.
16667 (Expression::ConvertNumericExplicit): Finished.
16669 (Invocation::Emit): If InstanceExpression is null, then it means
16670 that we perform a call on this.
16672 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16674 * expression.cs (Unary::Emit): Remove some dead code.
16675 (Probe): Implement Resolve and Emit for `is'.
16676 (Expression::ConvertImplicitRequired): Attempt to do constant
16677 expression conversions here. Maybe should be moved to
16678 ConvertImplicit, but I am not sure.
16679 (Expression::ImplicitLongConstantConversionPossible,
16680 Expression::ImplicitIntConstantConversionPossible): New functions
16681 that tell whether is it possible to apply an implicit constant
16682 expression conversion.
16684 (ConvertNumericExplicit): Started work on explicit numeric
16687 * cs-parser.jay: Update operator constants.
16689 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
16690 (Parameters::GetSignature): Hook up VerifyArgs here.
16691 (Parameters::VerifyArgs): Verifies that no two arguments have the
16694 * class.cs (Operator): Update the operator names to reflect the
16695 ones that the spec expects (as we are just stringizing the
16698 * expression.cs (Unary::ResolveOperator): Fix bug: Use
16699 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
16700 previous usage did only work for our methods.
16701 (Expression::ConvertImplicit): Handle decimal implicit numeric
16702 conversions as well.
16703 (Expression::InternalTypeConstructor): Used to invoke constructors
16704 on internal types for default promotions.
16706 (Unary::Emit): Implement special handling for the pre/post
16707 increment/decrement for overloaded operators, as they need to have
16708 the same semantics as the other operators.
16710 (Binary::ResolveOperator): ditto.
16711 (Invocation::ConversionExists): ditto.
16712 (UserImplicitCast::Resolve): ditto.
16714 2001-09-26 Ravi Pratap <ravi@ximian.com>
16716 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
16717 operator, return after emitting body. Regression tests pass again !
16719 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
16720 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
16721 (Invocation::OverloadResolve): Ditto.
16722 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
16724 * everywhere : update calls to the above methods accordingly.
16726 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16728 * assign.cs (Assign): Make it inherit from ExpressionStatement.
16730 * expression.cs (ExpressionStatement): New base class used for
16731 expressions that can appear in statements, so that we can provide
16732 an alternate path to generate expression that do not leave a value
16735 (Expression::Emit, and all the derivatives): We no longer return
16736 whether a value is left on the stack or not. Every expression
16737 after being emitted leaves a single value on the stack.
16739 * codegen.cs (EmitContext::EmitStatementExpression): Use the
16740 facilties of ExpressionStatement if possible.
16742 * cs-parser.jay: Update statement_expression.
16744 2001-09-25 Miguel de Icaza <miguel@ximian.com>
16746 * driver.cs: Change the wording of message
16748 2001-09-25 Ravi Pratap <ravi@ximian.com>
16750 * expression.cs (Binary::ResolveOperator): Had forgottten to set
16751 the type of the expression to the return type of the method if
16752 we have an overloaded operator match ! The regression tests pass again !
16753 (Unary::ResolveOperator): Ditto.
16755 * expression.cs (Invocation::ConversionExists): Correct the member lookup
16756 to find "op_Implicit", not "implicit" ;-)
16757 (UserImplicitCast): New class to take care of user-defined implicit conversions.
16758 (ConvertImplicit, ForceConversion): Take TypeContainer argument
16760 * everywhere : Correct calls to the above accordingly.
16762 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
16763 (ConvertImplicit): Do user-defined conversion if it exists.
16765 2001-09-24 Miguel de Icaza <miguel@ximian.com>
16767 * assign.cs: track location.
16768 (Resolve): Use implicit conversions on assignment.
16770 * literal.cs: Oops. Not good, Emit of short access values should
16771 pass (Bytes) or the wrong argument will be selected.
16773 * expression.cs (Unary::Emit): Emit code for -expr.
16775 (Unary::ResolveOperator): Handle `Substract' for non-constants
16776 (substract from zero from the non-constants).
16777 Deal with Doubles as well.
16779 (Expression::ConvertImplicitRequired): New routine that reports an
16780 error if no implicit conversion exists.
16782 (Invocation::OverloadResolve): Store the converted implicit
16783 expressions if we make them
16785 2001-09-24 Ravi Pratap <ravi@ximian.com>
16787 * class.cs (ConstructorInitializer): Take a Location argument.
16788 (ConstructorBaseInitializer): Same here.
16789 (ConstructorThisInitializer): Same here.
16791 * cs-parser.jay : Update all calls accordingly.
16793 * expression.cs (Unary, Binary, New): Take location argument.
16794 Update accordingly everywhere.
16796 * cs-parser.jay : Update all calls to the above to take a location
16799 * class.cs : Ditto.
16801 2001-09-24 Ravi Pratap <ravi@ximian.com>
16803 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
16804 (Invocation::BetterConversion): Same here
16805 (Invocation::ConversionExists): Ditto.
16807 (Invocation::ConversionExists): Implement.
16809 2001-09-22 Ravi Pratap <ravi@ximian.com>
16811 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
16812 Also take an additional TypeContainer argument.
16814 * All over : Pass in TypeContainer as argument to OverloadResolve.
16816 * typemanager.cs (CSharpName): Update to check for the string type and return
16819 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
16822 2001-09-21 Ravi Pratap <ravi@ximian.com>
16824 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
16825 (Invocation::BetterFunction): Implement.
16826 (Invocation::BetterConversion): Implement.
16827 (Invocation::ConversionExists): Skeleton, no implementation yet.
16829 Okay, things work fine !
16831 2001-09-21 Miguel de Icaza <miguel@ximian.com>
16833 * typemanager.cs: declare and load enum_type, delegate_type and
16836 * expression.cs (Expression::Emit): Now emit returns a value that
16837 tells whether a value is left on the stack or not. This strategy
16838 might be reveted tomorrow with a mechanism that would address
16839 multiple assignments.
16840 (Expression::report118): Utility routine to report mismatches on
16843 (Unary::Report23): Report impossible type/operator combination
16846 (Unary::IsIncrementableNumber): Whether the type can be
16847 incremented or decremented with add.
16848 (Unary::ResolveOperator): Also allow enumerations to be bitwise
16850 (Unary::ResolveOperator): Implement ++, !, ~,
16852 (Invocation::Emit): Deal with new Emit convetion.
16854 * All Expression derivatives: Updated their Emit method to return
16855 whether they leave values on the stack or not.
16857 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
16858 stack for expressions that are statements.
16860 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16862 * expression.cs (LValue): New interface. Must be implemented by
16864 (LocalVariableReference, ParameterReference, FieldExpr): Implement
16867 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
16868 interface for generating code, simplifies the code.
16870 2001-09-20 Ravi Pratap <ravi@ximian.com>
16872 * expression.cs (everywhere): Comment out return statements in ::Resolve
16873 methods to avoid the warnings.
16875 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16877 * driver.cs (parse): Report error 2001 if we can not open the
16880 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
16883 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
16886 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
16887 otherwise nested blocks end up with the same index.
16889 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
16891 * expression.cs: Instead of having FIXMEs in the Resolve
16892 functions, throw exceptions so it is obvious that we are facing a
16895 * cs-parser.jay (invocation_expression): Pass Location information.
16897 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
16898 Use a basename for those routines because .NET does not like paths
16901 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
16904 2001-09-19 Miguel de Icaza <miguel@ximian.com>
16906 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
16907 are loading the correct data types (throws an exception if not).
16908 (TypeManager::InitCoreTypes): Use CoreLookupType
16910 * expression.cs (Unary::ResolveOperator): return the child
16911 expression for expressions which are just +expr.
16912 (Unary::ResolveOperator): Return negative literals for -LITERAL
16913 expressions (otherwise they are Unary {Literal}).
16914 (Invocation::Badness): Take into account `Implicit constant
16915 expression conversions'.
16917 * literal.cs (LongLiteral): Implement long literal class.
16918 (IntLiteral): export the `Value' of the intliteral.
16920 2001-09-19 Ravi Pratap <ravi@ximian.com>
16922 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
16924 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
16925 instead of 'Operator'
16927 * expression.cs (Binary::ResolveOperator): Update accordingly.
16928 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
16931 * cs-parser.jay (unary_expression): Update to use the new names.
16933 * gen-treedump.cs (GetUnary): Same here.
16935 * expression.cs (Unary::Resolve): Implement.
16936 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
16937 operators are found instead of making noise ;-)
16938 (Unary::ResolveOperator): New method to do precisely the same thing which
16939 Binary::ResolveOperator does for Binary expressions.
16940 (Unary.method, .Arguments): Add.
16941 (Unary::OperName): Implement.
16942 (Unary::ForceConversion): Copy and Paste !
16944 * class.cs (Operator::Define): Fix a small bug for the case when we have
16947 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
16948 for the inbuilt operators. Only overloading works for now ;-)
16950 2001-09-18 Miguel de Icaza <miguel@ximian.com>
16952 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
16953 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
16955 * expression.cs (This::Emit): Implement.
16956 (This::Resolve): Implement.
16957 (TypeOf:Resolve): Implement.
16958 (Expression::ResolveSimpleName): Add an implicit this to instance
16960 (MemberAccess::Resolve): Deal with Parameters and Fields.
16961 Bind instance variable to Field expressions.
16962 (FieldExpr::Instance): New field used to track the expression that
16963 represents the object instance.
16964 (FieldExpr::Resolve): Track potential errors from MemberLookup not
16966 (FieldExpr::Emit): Implement.
16968 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
16969 the last instruction contains a return opcode to avoid generating
16970 the last `ret' instruction (this generates correct code, and it is
16971 nice to pass the peverify output).
16973 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
16974 initializer for static and instance variables.
16975 (Constructor::Emit): Allow initializer to be null in the case of
16976 static constructors. Only emit initializer for instance
16979 (TypeContainer::FindMembers): Return a null array if there are no
16982 Also fix the code for the MemberTypes.Method branch, as it was not
16983 scanning that for operators (or tried to access null variables before).
16985 * assign.cs (Assign::Emit): Handle instance and static fields.
16989 * driver.cs: Stop compilation if there are parse errors.
16991 * cs-parser.jay (constructor_declaration): Provide default base
16992 initializer for non-static constructors.
16993 (constructor_declarator): Do not provide a default base
16994 initializers if none was specified.
16995 Catch the fact that constructors should not have parameters.
16997 * class.cs: Do not emit parent class initializers for static
16998 constructors, that should be flagged as an error.
17000 2001-09-18 Ravi Pratap <ravi@ximian.com>
17002 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
17003 Move back code into TypeContainer::Populate.
17005 2001-09-18 Ravi Pratap <ravi@ximian.com>
17007 * class.cs (TypeContainer::AddConstructor): Fix the check to
17008 compare against Name, not Basename.
17009 (Operator::OpType): Change Plus and Minus to Add and Subtract.
17011 * cs-parser.jay : Update accordingly.
17013 * class.cs (TypeContainer::FindMembers): For the case where we are searching
17014 for methods, don't forget to look into the operators too.
17015 (RegisterMethodBuilder): Helper method to take care of this for
17016 methods, constructors and operators.
17017 (Operator::Define): Completely revamp.
17018 (Operator.OperatorMethod, MethodName): New fields.
17019 (TypeContainer::Populate): Move the registering of builders into
17020 RegisterMethodBuilder.
17021 (Operator::Emit): Re-write.
17023 * expression.cs (Binary::Emit): Comment out code path to emit method
17024 invocation stuff for the case when we have a user defined operator. I am
17025 just not able to get it right !
17027 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17029 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
17032 (Expression::MemberLookup): Provide a version that allows to
17033 specify the MemberTypes and BindingFlags.
17035 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
17036 so it was not fetching variable information from outer blocks.
17038 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
17039 Beforefieldinit as it was buggy.
17041 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
17042 that Ravi put here.
17044 * class.cs (Constructor::Emit): Only emit if block is not null.
17045 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
17046 deal with this by semantically definining it as if the user had
17049 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
17050 constructors as we now "emit" them at a higher level.
17052 (TypeContainer::DefineDefaultConstructor): Used to define the
17053 default constructors if none was provided.
17055 (ConstructorInitializer): Add methods Resolve and Emit.
17057 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
17059 2001-09-17 Ravi Pratap <ravi@ximian.com>
17061 * class.cs (TypeContainer::EmitDefaultConstructor): Register
17062 the default constructor builder with our hashtable for methodbuilders
17065 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
17066 and argument_count is 0 in which case we have a match.
17067 (Binary::ResolveOperator): More null checking and miscellaneous coding
17070 2001-09-17 Ravi Pratap <ravi@ximian.com>
17072 * rootcontext.cs (IsNameSpace): Compare against null.
17074 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
17076 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
17077 and Unary::Operator.
17079 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
17082 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
17083 we have overloaded operators.
17084 (Binary::ResolveOperator): Implement the part which does the operator overload
17087 * class.cs (Operator::Emit): Implement.
17088 (TypeContainer::Emit): Emit the operators we have too.
17090 * expression.cs (Binary::Emit): Update to emit the appropriate code for
17091 the case when we have a user-defined operator.
17093 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17095 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
17097 2001-09-16 Ravi Pratap <ravi@ximian.com>
17099 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
17100 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
17101 (Constructor::Emit): Implement.
17102 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
17103 if we have no work to do.
17104 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
17107 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
17108 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
17110 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
17113 2001-09-15 Ravi Pratap <ravi@ximian.com>
17115 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
17117 (Tree::RecordNamespace): Method to do what the name says ;-)
17118 (Tree::Namespaces): Property to get at the namespaces hashtable.
17120 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
17123 * rootcontext.cs (IsNamespace): Fixed it :-)
17125 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17127 * class.cs (TypeContainer::FindMembers): Add support for
17129 (MethodCore): New class that encapsulates both the shared aspects
17130 of a Constructor and a Method.
17131 (Method, Constructor): Factored pieces into MethodCore.
17133 * driver.cs: Added --fatal which makes errors throw exceptions.
17134 Load System assembly as well as part of the standard library.
17136 * report.cs: Allow throwing exceptions on errors for debugging.
17138 * modifiers.cs: Do not use `parent', instead use the real type
17139 container to evaluate permission settings.
17141 * class.cs: Put Ravi's patch back in. He is right, and we will
17142 have to cope with the
17144 2001-09-14 Ravi Pratap <ravi@ximian.com>
17146 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
17147 FamORAssem, not FamANDAssem.
17149 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17151 * driver.cs: Added --parse option that only parses its input files
17154 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
17155 incorrect. IsTopLevel is not used to tell whether an object is
17156 root_types or not (that can be achieved by testing this ==
17157 root_types). But to see if this is a top-level *class* (not
17158 necessarly our "toplevel" container).
17160 2001-09-14 Ravi Pratap <ravi@ximian.com>
17162 * enum.cs (Enum::Define): Modify to call the Lookup method on the
17163 parent instead of a direct call to GetType.
17165 2001-09-14 Ravi Pratap <ravi@ximian.com>
17167 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
17168 Modifiers.TypeAttr. This should just be a call to that method.
17170 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
17171 object so that we can determine if we are top-level or not.
17173 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
17176 * enum.cs (Enum::Define): Ditto.
17178 * modifiers.cs (FieldAttr): Re-write.
17180 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
17181 (TypeContainer::HaveStaticConstructor): New property to provide access
17182 to precisely that info.
17184 * modifiers.cs (MethodAttr): Re-write.
17185 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
17187 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
17188 of top-level types as claimed.
17190 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17192 * expression.cs (MemberLookup): Fruitless attempt to lookup
17193 constructors. Maybe I need to emit default constructors? That
17194 might be it (currently .NET emits this for me automatically).
17195 (Invocation::OverloadResolve): Cope with Arguments == null.
17196 (Invocation::EmitArguments): new function, shared by the new
17197 constructor and us.
17198 (Invocation::Emit): Handle static and instance methods. Emit
17199 proper call instruction for virtual or non-virtual invocations.
17200 (New::Emit): Implement.
17201 (New::Resolve): Implement.
17202 (MemberAccess:Resolve): Implement.
17203 (MethodGroupExpr::InstanceExpression): used conforming to the spec
17204 to track instances.
17205 (FieldExpr::Resolve): Set type.
17207 * support.cs: Handle empty arguments.
17209 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
17210 SimpleLookup): Auxiliary routines to help parse a qualifier
17213 Update qualifier_identifier rule.
17215 * codegen.cs: Removed debugging messages.
17217 * class.cs: Make this a global thing, this acts just as a "key" to
17218 objects that we might have around.
17220 (Populate): Only initialize method_builders_to_methods once.
17222 * expression.cs (PropertyExpr): Initialize type from the
17225 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
17226 Resolve pattern. Attempt to implicitly convert value to boolean.
17229 * expression.cs: Set the type for the int32/int32 argument case.
17230 (Binary::ResolveOperator): Set the return type to boolean for
17231 comparission operators
17233 * typemanager.cs: Remove debugging print code.
17235 (Invocation::Resolve): resolve type.
17237 * class.cs: Allocate a MemberInfo of the correct size, as the code
17238 elsewhere depends on the test to reflect the correct contents.
17240 (Method::) Keep track of parameters, due to System.Reflection holes
17242 (TypeContainer::Populate): Keep track of MethodBuilders to Method
17245 (TypeContainer::FindMembers): Use ArrayList and then copy an array
17246 of the exact size and return that.
17248 (Class::LookupMethodByBuilder): New function that maps
17249 MethodBuilders to its methods. Required to locate the information
17250 on methods because System.Reflection bit us again.
17252 * support.cs: New file, contains an interface ParameterData and
17253 two implementations: ReflectionParameters and InternalParameters
17254 used to access Parameter information. We will need to grow this
17257 * expression.cs (Invocation::GetParameterData): implement a cache
17258 and a wrapper around the ParameterData creation for methods.
17259 (Invocation::OverloadResolve): Use new code.
17261 2001-09-13 Ravi Pratap <ravi@ximian.com>
17263 * class.cs (TypeContainer::EmitField): Remove and move into
17264 (Field::Define): here and modify accordingly.
17265 (Field.FieldBuilder): New member.
17266 (TypeContainer::Populate): Update accordingly.
17267 (TypeContainer::FindMembers): Implement.
17269 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17271 * statement.cs: (VariableInfo::VariableType): New field to be
17272 initialized with the full type once it is resolved.
17274 2001-09-12 Miguel de Icaza <miguel@ximian.com>
17276 * parameter.cs (GetParameterInfo): Use a type cache to compute
17277 things only once, and to reuse this information
17279 * expression.cs (LocalVariableReference::Emit): Implement.
17280 (OpcodeCast::Emit): fix.
17282 (ParameterReference::Resolve): Implement.
17283 (ParameterReference::Emit): Implement.
17285 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
17286 that are expressions need to stay as Expressions.
17288 * typemanager.cs (CSharpName): Returns the C# name of a type if
17291 * expression.cs (Expression::ConvertImplicit): New function that
17292 implements implicit type conversions.
17294 (Expression::ImplicitReferenceConversion): Implements implicit
17295 reference conversions.
17297 (EmptyCast): New type for transparent casts.
17299 (OpcodeCast): New type for casts of types that are performed with
17300 a sequence of bytecodes.
17302 (BoxedCast): New type used for casting value types into reference
17303 types. Emits a box opcode.
17305 (Binary::DoNumericPromotions): Implements numeric promotions of
17306 and computation of the Binary::Type.
17308 (Binary::EmitBranchable): Optimization.
17310 (Binary::Emit): Implement code emission for expressions.
17312 * typemanager.cs (TypeManager): Added two new core types: sbyte
17315 2001-09-12 Ravi Pratap <ravi@ximian.com>
17317 * class.cs (TypeContainer::FindMembers): Method which does exactly
17318 what Type.FindMembers does, only we don't have to use reflection. No
17319 implementation yet.
17321 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17322 typecontainer objects as we need to get at them.
17323 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17325 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17326 typecontainer object.
17328 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17329 of just a Report object.
17331 2001-09-11 Ravi Pratap <ravi@ximian.com>
17333 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17335 (TypeContainer::Populate): Now define the delegates of the type too.
17336 (TypeContainer.Delegates): Property to access the list of delegates defined
17339 * delegates.cs (Delegate::Define): Implement partially.
17341 * modifiers.cs (TypeAttr): Handle more flags.
17343 2001-09-11 Ravi Pratap <ravi@ximian.com>
17345 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17347 (Operator::Define): Re-write logic to get types by using the LookupType method
17348 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17349 (Indexer::Define): Ditto.
17350 (Event::Define): Ditto.
17351 (Property::Define): Ditto.
17353 2001-09-10 Ravi Pratap <ravi@ximian.com>
17355 * class.cs (TypeContainer::Populate): Now define operators too.
17356 (TypeContainer.Operators): New property to access the list of operators
17358 (Operator.OperatorMethodBuilder): New member to hold the method builder
17359 for the operator we are defining.
17360 (Operator::Define): Implement.
17362 2001-09-10 Ravi Pratap <ravi@ximian.com>
17364 * class.cs (Event::Define): Make the prefixes of the accessor methods
17365 addOn_ and removeOn_
17367 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17368 of the location being passed in too. Ideally, this should go later since all
17369 error reporting should be done through the Report object.
17371 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17372 (Populate): Iterate thru the indexers we have and define them too.
17373 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17374 for the get and set accessors.
17375 (Indexer::Define): Implement.
17377 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17379 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17380 my previous implementation, did not work.
17382 * typemanager.cs: Add a couple of missing types (the longs).
17384 * literal.cs: Use TypeManager.bool_type instead of getting it.
17386 * expression.cs (EventExpr): New kind of expressions.
17387 (Expressio::ExprClassFromMemberInfo): finish
17389 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17391 * assign.cs: Emit stores to static fields differently.
17393 2001-09-08 Ravi Pratap <ravi@ximian.com>
17395 * Merge in changes and adjust code to tackle conflicts. Backed out my
17396 code in Assign::Resolve ;-)
17398 2001-09-08 Ravi Pratap <ravi@ximian.com>
17400 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17401 instead Report.Error and also pass in the location.
17402 (CSharpParser::Lexer): New readonly property to return the reference
17403 to the Tokenizer object.
17404 (declare_local_variables): Use Report.Error with location instead of plain
17408 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17409 (Operator.CheckBinaryOperator): Ditto.
17411 * cs-parser.jay (operator_declarator): Update accordingly.
17413 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17414 (CheckBinaryOperator): Same here.
17416 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17417 on the name without any prefixes of namespace names etc. This is because we
17418 already might have something already fully qualified like
17419 'System.Console.WriteLine'
17421 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17423 2001-09-07 Ravi Pratap <ravi@ximian.com>
17425 * cs-tokenizer.cs (location): Return a string which also contains
17428 * expression.cs (ElementAccess): New class for expressions of the
17429 type 'element access.'
17430 (BaseAccess): New class for expressions of the type 'base access.'
17431 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17434 * cs-parser.jay (element_access): Implement action.
17435 (base_access): Implement actions.
17436 (checked_expression, unchecked_expression): Implement.
17438 * cs-parser.jay (local_variable_type): Correct and implement.
17439 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17441 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17443 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17444 name and the specifiers.
17446 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17448 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17449 making them all public ;-)
17451 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17454 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17456 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17458 (FieldExpr, PropertyExprs): New resolved expressions.
17459 (SimpleName::MemberStaticCheck): Perform static checks for access
17460 to non-static fields on static methods. Maybe this should be
17461 generalized for MemberAccesses.
17462 (SimpleName::ResolveSimpleName): More work on simple name
17465 * cs-parser.jay (primary_expression/qualified_identifier): track
17466 the parameter index.
17468 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17469 (EmitContext::EmitBoolExpression): Chain to expression generation
17470 instead of temporary hack.
17471 (::EmitStatementExpression): Put generic expression code generation.
17473 * assign.cs (Assign::Emit): Implement variable assignments to
17474 local variables, parameters and fields.
17476 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17478 * statement.cs (Block::GetVariableInfo): New method, returns the
17479 VariableInfo for a variable name in a block.
17480 (Block::GetVariableType): Implement in terms of GetVariableInfo
17482 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17483 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17485 2001-09-06 Ravi Pratap <ravi@ximian.com>
17487 * cs-parser.jay (operator_declaration): Continue on my quest : update
17488 to take attributes argument.
17489 (event_declaration): Ditto.
17490 (enum_declaration): Ditto.
17491 (indexer_declaration): Ditto.
17493 * class.cs (Operator::Operator): Update constructor accordingly.
17494 (Event::Event): Ditto.
17496 * delegate.cs (Delegate::Delegate): Same here.
17498 * enum.cs (Enum::Enum): Same here.
17500 2001-09-05 Ravi Pratap <ravi@ximian.com>
17502 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17504 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17506 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17507 being passed around as an arraylist.
17508 (Attributes::AddAttribute): Method to add attribute sections.
17510 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17511 (struct_declaration): Update accordingly.
17512 (constant_declaration): Update.
17513 (field_declaration): Update.
17514 (method_header): Update.
17515 (fixed_parameter): Update.
17516 (parameter_array): Ditto.
17517 (property_declaration): Ditto.
17518 (destructor_declaration): Ditto.
17520 * class.cs (Struct::Struct): Update constructors accordingly.
17521 (Class::Class): Ditto.
17522 (Field::Field): Ditto.
17523 (Method::Method): Ditto.
17524 (Property::Property): Ditto.
17525 (TypeContainer::OptAttribute): update property's return type.
17527 * interface.cs (Interface.opt_attributes): New member.
17528 (Interface::Interface): Update to take the extra Attributes argument.
17530 * parameter.cs (Parameter::Parameter): Ditto.
17532 * constant.cs (Constant::Constant): Ditto.
17534 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17535 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17536 the attributes as a parameter.
17537 (InterfaceProperty): Update constructor call.
17538 (InterfaceEvent): Ditto.
17539 (InterfaceMethod): Ditto.
17540 (InterfaceIndexer): Ditto.
17542 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17543 pass the attributes too.
17544 (interface_event_declaration): Ditto.
17545 (interface_property_declaration): Ditto.
17546 (interface_method_declaration): Ditto.
17547 (interface_declaration): Ditto.
17549 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17551 * class.cs (Method::Define): Track the "static Main" definition to
17552 create an entry point.
17554 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17555 EntryPoint if we find it.
17557 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17558 (EmitContext::ig): Make this variable public.
17560 * driver.cs: Make the default output file be the first file name
17561 with the .exe extension.
17563 Detect empty compilations
17565 Handle various kinds of output targets. Handle --target and
17566 rename -t to --dumper.
17568 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17569 methods inherited from Expression return now an Expression. This
17570 will is used during the tree rewriting as we resolve them during
17573 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17574 the spec. Missing entirely is the information about
17575 accessability of elements of it.
17577 (Expression::ExprClassFromMemberInfo): New constructor for
17578 Expressions that creates a fully initialized Expression based on
17579 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17582 (Invocation::Resolve): Begin implementing resolution of invocations.
17584 * literal.cs (StringLiteral): Implement Emit.
17586 2001-09-05 Ravi Pratap <ravi@ximian.com>
17588 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17591 2001-09-04 Ravi Pratap <ravi@ximian.com>
17593 * cs-parser.jay (attribute_arguments): Implement actions.
17594 (attribute): Fix bug in production. Implement action.
17595 (attribute_list): Implement.
17596 (attribute_target): Implement.
17597 (attribute_target_specifier, opt_target_specifier): Implement
17598 (CheckAttributeTarget): New method to check if the attribute target
17600 (attribute_section): Implement.
17601 (opt_attributes): Implement.
17603 * attribute.cs : New file to handle attributes.
17604 (Attribute): Class to hold attribute info.
17606 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17607 (attribute_section): Modify production to use 2 different rules to
17608 achieve the same thing. 1 s/r conflict down !
17609 Clean out commented, useless, non-reducing dimension_separator rules.
17611 * class.cs (TypeContainer.attributes): New member to hold list
17612 of attributes for a type.
17613 (Struct::Struct): Modify to take one more argument, the attribute list.
17614 (Class::Class): Ditto.
17615 (Field::Field): Ditto.
17616 (Method::Method): Ditto.
17617 (Property::Property): Ditto.
17619 * cs-parser.jay (struct_declaration): Update constructor call to
17620 pass in the attributes too.
17621 (class_declaration): Ditto.
17622 (constant_declaration): Ditto.
17623 (field_declaration): Ditto.
17624 (method_header): Ditto.
17625 (fixed_parameter): Ditto.
17626 (parameter_array): Ditto.
17627 (property_declaration): Ditto.
17629 * constant.cs (Constant::Constant): Update constructor similarly.
17630 Use System.Collections.
17632 * parameter.cs (Parameter::Parameter): Update as above.
17634 2001-09-02 Ravi Pratap <ravi@ximian.com>
17636 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17637 (TypeContainer.delegates): New member to hold list of delegates.
17639 * cs-parser.jay (delegate_declaration): Implement the action correctly
17640 this time as I seem to be on crack ;-)
17642 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17644 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17645 tell whether an identifier represents a namespace.
17647 * expression.cs (NamespaceExpr): A namespace expression, used only
17648 temporarly during expression resolution.
17649 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17650 utility functions to resolve names on expressions.
17652 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17654 * codegen.cs: Add hook for StatementExpressions.
17656 * class.cs: Fix inverted test for static flag in methods.
17658 2001-09-02 Ravi Pratap <ravi@ximian.com>
17660 * class.cs (Operator::CheckUnaryOperator): Correct error number used
17661 to make it coincide with MS' number.
17662 (Operator::CheckBinaryOperator): Ditto.
17664 * ../errors/errors.txt : Remove error numbers added earlier.
17666 * ../errors/cs1019.cs : Test case for error # 1019
17668 * ../errros/cs1020.cs : Test case for error # 1020
17670 * cs-parser.jay : Clean out commented cruft.
17671 (dimension_separators, dimension_separator): Comment out. Ostensibly not
17672 used anywhere - non-reducing rule.
17673 (namespace_declarations): Non-reducing rule - comment out.
17675 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
17676 with TypeContainer::AddEnum.
17678 * delegate.cs : New file for delegate handling classes.
17679 (Delegate): Class for declaring delegates.
17681 * makefile : Update.
17683 * cs-parser.jay (delegate_declaration): Implement.
17685 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
17687 * class.cs (Event::Define): Implement.
17688 (Event.EventBuilder): New member.
17690 * class.cs (TypeContainer::Populate): Update to define all enums and events
17692 (Events): New property for the events arraylist we hold. Shouldn't we move to using
17693 readonly fields for all these cases ?
17695 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17697 * class.cs (Property): Revamp to use the convention of making fields readonly.
17698 Accordingly modify code elsewhere.
17700 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
17701 the Define method of the Property class.
17703 * class.cs : Clean up applied patch and update references to variables etc. Fix
17705 (TypeContainer::Populate): Update to define all the properties we have. Also
17706 define all enumerations.
17708 * enum.cs (Define): Implement.
17710 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17712 * cs-parser.jay (overloadable_operator): The semantic value is an
17713 enum of the Operator class.
17714 (operator_declarator): Implement actions.
17715 (operator_declaration): Implement.
17717 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
17718 validity of definitions.
17719 (Operator::CheckBinaryOperator): Static method to check for binary operators
17720 (TypeContainer::AddOperator): New method to add an operator to a type.
17722 * cs-parser.jay (indexer_declaration): Added line to actually call the
17723 AddIndexer method so it gets added ;-)
17725 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
17726 already taken care of by the MS compiler ?
17728 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17730 * class.cs (Operator): New class for operator declarations.
17731 (Operator::OpType): Enum for the various operators.
17733 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17735 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
17736 ostensibly handle this in semantic analysis.
17738 * cs-parser.jay (general_catch_clause): Comment out
17739 (specific_catch_clauses, specific_catch_clause): Ditto.
17740 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
17741 (catch_args, opt_catch_args): New productions.
17742 (catch_clause): Rewrite to use the new productions above
17743 (catch_clauses): Modify accordingly.
17744 (opt_catch_clauses): New production to use in try_statement
17745 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
17746 and re-write the code in the actions to extract the specific and
17747 general catch clauses by being a little smart ;-)
17749 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
17750 Hooray, try and catch statements parse fine !
17752 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17754 * statement.cs (Block::GetVariableType): Fix logic to extract the type
17755 string from the hashtable of variables.
17757 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
17758 I end up making that mistake ;-)
17759 (catch_clauses): Fixed gross error which made Key and Value of the
17760 DictionaryEntry the same : $1 !!
17762 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17764 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
17766 * cs-parser.jay (event_declaration): Correct to remove the semicolon
17767 when the add and remove accessors are specified.
17769 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17771 * cs-parser.jay (IndexerDeclaration): New helper class to hold
17772 information about indexer_declarator.
17773 (indexer_declarator): Implement actions.
17774 (parsing_indexer): New local boolean used to keep track of whether
17775 we are parsing indexers or properties. This is necessary because
17776 implicit_parameters come into picture even for the get accessor in the
17777 case of an indexer.
17778 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
17780 * class.cs (Indexer): New class for indexer declarations.
17781 (TypeContainer::AddIndexer): New method to add an indexer to a type.
17782 (TypeContainer::indexers): New member to hold list of indexers for the
17785 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17787 * cs-parser.jay (add_accessor_declaration): Implement action.
17788 (remove_accessor_declaration): Implement action.
17789 (event_accessors_declaration): Implement
17790 (variable_declarators): swap statements for first rule - trivial.
17792 * class.cs (Event): New class to hold information about event
17794 (TypeContainer::AddEvent): New method to add an event to a type
17795 (TypeContainer::events): New member to hold list of events.
17797 * cs-parser.jay (event_declaration): Implement actions.
17799 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17801 * cs-parser.jay (dim_separators): Implement. Make it a string
17802 concatenating all the commas together, just as they appear.
17803 (opt_dim_separators): Modify accordingly
17804 (rank_specifiers): Update accordingly. Basically do the same
17805 thing - instead, collect the brackets here.
17806 (opt_rank_sepcifiers): Modify accordingly.
17807 (array_type): Modify to actually return the complete type string
17808 instead of ignoring the rank_specifiers.
17809 (expression_list): Implement to collect the expressions
17810 (variable_initializer): Implement. We make it a list of expressions
17811 essentially so that we can handle the array_initializer case neatly too.
17812 (variable_initializer_list): Implement.
17813 (array_initializer): Make it a list of variable_initializers
17814 (opt_array_initializer): Modify accordingly.
17816 * expression.cs (New::NType): Add enumeration to help us
17817 keep track of whether we have an object/delegate creation
17818 or an array creation.
17819 (New:NewType, New::Rank, New::Indices, New::Initializers): New
17820 members to hold data about array creation.
17821 (New:New): Modify to update NewType
17822 (New:New): New Overloaded contructor for the array creation
17825 * cs-parser.jay (array_creation_expression): Implement to call
17826 the overloaded New constructor.
17828 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
17830 * class.cs (TypeContainer::Constructors): Return member
17831 constructors instead of returning null.
17833 2001-08-26 Miguel de Icaza <miguel@ximian.com>
17835 * typemanager.cs (InitCoreTypes): Initialize the various core
17836 types after we have populated the type manager with the user
17837 defined types (this distinction will be important later while
17838 compiling corlib.dll)
17840 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
17841 on Expression Classification. Now all expressions have a method
17842 `Resolve' and a method `Emit'.
17844 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
17845 generation from working. Also add some temporary debugging
17848 2001-08-24 Miguel de Icaza <miguel@ximian.com>
17850 * codegen.cs: Lots of code generation pieces. This is only the
17851 beginning, will continue tomorrow with more touches of polish. We
17852 handle the fundamentals of if, while, do, for, return. Others are
17853 trickier and I need to start working on invocations soon.
17855 * gen-treedump.cs: Bug fix, use s.Increment here instead of
17858 * codegen.cs (EmitContext): New struct, used during code
17859 emission to keep a context. Most of the code generation will be
17862 * cs-parser.jay: Add embedded blocks to the list of statements of
17863 this block. So code generation proceeds in a top down fashion.
17865 2001-08-23 Miguel de Icaza <miguel@ximian.com>
17867 * statement.cs: Add support for multiple child blocks.
17869 2001-08-22 Miguel de Icaza <miguel@ximian.com>
17871 * codegen.cs (EmitCode): New function, will emit the code for a
17872 Block of code given a TypeContainer and its ILGenerator.
17874 * statement.cs (Block): Standard public readonly optimization.
17875 (Block::Block constructors): Link children.
17876 (Block::Child): Child Linker.
17877 (Block::EmitVariables): Emits IL variable declarations.
17879 * class.cs: Drop support for MethodGroups here, delay until
17881 (Method::): Applied the same simplification that I did before, and
17882 move from Properties to public readonly fields.
17883 (Method::ParameterTypes): Returns the parameter types for the
17884 function, and implements a cache that will be useful later when I
17885 do error checking and the semantic analysis on the methods is
17887 (Constructor::GetCallingConvention): Renamed from CallingConvetion
17888 and made a method, optional argument tells whether this is a class
17889 or a structure to apply the `has-this' bit.
17890 (Method::GetCallingConvention): Implement, returns the calling
17892 (Method::Define): Defines the type, a second pass is performed
17893 later to populate the methods.
17895 (Constructor::ParameterTypes): implement a cache similar to the
17896 one on Method::ParameterTypes, useful later when we do semantic
17899 (TypeContainer::EmitMethod): New method. Emits methods.
17901 * expression.cs: Removed MethodGroup class from here.
17903 * parameter.cs (Parameters::GetCallingConvention): new method.
17905 2001-08-21 Miguel de Icaza <miguel@ximian.com>
17907 * class.cs (TypeContainer::Populate): Drop RootContext from the
17910 (Constructor::CallingConvention): Returns the calling convention.
17911 (Constructor::ParameterTypes): Returns the constructor parameter
17914 (TypeContainer::AddConstructor): Keep track of default constructor
17915 and the default static constructor.
17917 (Constructor::) Another class that starts using `public readonly'
17918 instead of properties.
17920 (Constructor::IsDefault): Whether this is a default constructor.
17922 (Field::) use readonly public fields instead of properties also.
17924 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
17925 track of static constructors; If none is used, turn on
17926 BeforeFieldInit in the TypeAttributes.
17928 * cs-parser.jay (opt_argument_list): now the return can be null
17929 for the cases where there are no arguments.
17931 (constructor_declarator): If there is no implicit `base' or
17932 `this', then invoke the default parent constructor.
17934 * modifiers.cs (MethodAttr): New static function maps a set of
17935 modifiers flags into a MethodAttributes enum
17936 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
17937 MethodAttr, TypeAttr to represent the various mappings where the
17938 modifiers are used.
17939 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
17941 2001-08-19 Miguel de Icaza <miguel@ximian.com>
17943 * parameter.cs (GetParameterInfo): Fix bug where there would be no
17946 * interface.cs (PopulateIndexer): Implemented the code generator
17947 for interface indexers.
17949 2001-08-17 Miguel de Icaza <miguel@ximian.com>
17951 * interface.cs (InterfaceMemberBase): Now we track the new status
17954 (PopulateProperty): Implement property population. Woohoo! Got
17955 Methods and Properties going today.
17957 Removed all the properties for interfaces, and replaced them with
17958 `public readonly' fields.
17960 2001-08-16 Miguel de Icaza <miguel@ximian.com>
17962 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
17963 initialize their hashtables/arraylists only when they are needed
17964 instead of doing this always.
17966 * parameter.cs: Handle refs and out parameters.
17968 * cs-parser.jay: Use an ArrayList to construct the arguments
17969 instead of the ParameterCollection, and then cast that to a
17972 * parameter.cs: Drop the use of ParameterCollection and use
17973 instead arrays of Parameters.
17975 (GetParameterInfo): Use the Type, not the Name when resolving
17978 2001-08-13 Miguel de Icaza <miguel@ximian.com>
17980 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
17981 and instead use public readonly fields.
17983 * class.cs: Put back walking code for type containers.
17985 2001-08-11 Miguel de Icaza <miguel@ximian.com>
17987 * class.cs (MakeConstant): Code to define constants.
17989 * rootcontext.cs (LookupType): New function. Used to locate types
17992 2001-08-08 Miguel de Icaza <miguel@ximian.com>
17994 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
17995 this System.Reflection code is. Kudos to Microsoft
17997 * typemanager.cs: Implement a type cache and avoid loading all
17998 types at boot time. Wrap in LookupType the internals. This made
17999 the compiler so much faster. Wow. I rule!
18001 * driver.cs: Make sure we always load mscorlib first (for
18002 debugging purposes, nothing really important).
18004 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
18005 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
18007 * rootcontext.cs: Lookup types on their namespace; Lookup types
18008 on namespaces that have been imported using the `using' keyword.
18010 * class.cs (TypeContainer::TypeAttr): Virtualize.
18011 (Class::TypeAttr): Return attributes suitable for this bad boy.
18012 (Struct::TypeAttr): ditto.
18013 Handle nested classes.
18014 (TypeContainer::) Remove all the type visiting code, it is now
18015 replaced with the rootcontext.cs code
18017 * rootcontext.cs (GetClassBases): Added support for structs.
18019 2001-08-06 Miguel de Icaza <miguel@ximian.com>
18021 * interface.cs, statement.cs, class.cs, parameter.cs,
18022 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
18023 Drop use of TypeRefs, and use strings instead.
18025 2001-08-04 Miguel de Icaza <miguel@ximian.com>
18029 * class.cs (Struct::Struct): set the SEALED flags after
18030 checking the modifiers.
18031 (TypeContainer::TypeAttr): new property, returns the
18032 TypeAttributes for a class.
18034 * cs-parser.jay (type_list): Oops, list production was creating a
18035 new list of base types.
18037 * rootcontext.cs (StdLib): New property.
18038 (GetInterfaceTypeByName): returns an interface by type name, and
18039 encapsulates error handling here.
18040 (GetInterfaces): simplified.
18041 (ResolveTree): Encapsulated all the tree resolution here.
18042 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
18045 * driver.cs: Add support for --nostdlib, to avoid loading the
18046 default assemblies.
18047 (Main): Do not put tree resolution here.
18049 * rootcontext.cs: Beginning of the class resolution.
18051 2001-08-03 Miguel de Icaza <miguel@ximian.com>
18053 * rootcontext.cs: Provide better error reporting.
18055 * cs-parser.jay (interface_base): set our $$ to be interfaces.
18057 * rootcontext.cs (CreateInterface): Handle the case where there
18058 are no parent interfaces.
18060 (CloseTypes): Routine to flush types at the end.
18061 (CreateInterface): Track types.
18062 (GetInterfaces): Returns an array of Types from the list of
18063 defined interfaces.
18065 * typemanager.c (AddUserType): Mechanism to track user types (puts
18066 the type on the global type hash, and allows us to close it at the
18069 2001-08-02 Miguel de Icaza <miguel@ximian.com>
18071 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
18072 RecordInterface instead.
18074 * cs-parser.jay: Updated to reflect changes above.
18076 * decl.cs (Definition): Keep track of the TypeBuilder type that
18077 represents this type here. Not sure we will use it in the long
18078 run, but wont hurt for now.
18080 * driver.cs: Smaller changes to accomodate the new code.
18082 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
18085 * rootcontext.cs (CreateInterface): New method, used to create
18086 the System.TypeBuilder type for interfaces.
18087 (ResolveInterfaces): new entry point to resolve the interface
18089 (CodeGen): Property, used to keep track of the code generator.
18091 2001-07-26 Miguel de Icaza <miguel@ximian.com>
18093 * cs-parser.jay: Add a second production for delegate_declaration
18096 (enum_body): Put an opt_comma here instead of putting it on
18097 enum_body or enum_member_declarations so we can handle trailing
18098 commas on enumeration members. Gets rid of a shift/reduce.
18100 (type_list): Need a COMMA in the middle.
18102 (indexer_declaration): Tell tokenizer to recognize get/set
18104 * Remove old targets.
18106 * Re-add the parser target.
18108 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18110 * cs-parser.jay: Add precendence rules for a number of operators
18111 ot reduce the number of shift/reduce conflicts in the grammar.
18113 2001-07-17 Miguel de Icaza <miguel@ximian.com>
18115 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
18118 Get rid of old crufty code.
18120 * rootcontext.cs: Use this to keep track of the parsed
18121 representation and the defined types available to the program.
18123 * gen-treedump.cs: adjust for new convention.
18125 * type.cs: Split out the type manager, and the assembly builder
18128 * typemanager.cs: the type manager will live here now.
18130 * cil-codegen.cs: And the code generator here.
18132 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
18134 * makefile: Fixed up for easy making.
18136 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18138 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
18141 (unary_expression): Expand pre_increment_expression and
18142 post_decrement_expression to reduce a shift/reduce.
18144 2001-07-11 Simon Cozens
18146 * cs-tokenizer.cs: Hex numbers should begin with a 0.
18148 Improve allow_keyword_as_indent name.
18150 2001-06-19 Miguel de Icaza <miguel@ximian.com>
18152 * Adjustments for Beta2.
18154 2001-06-13 Miguel de Icaza <miguel@ximian.com>
18156 * decl.cs: Added `Define' abstract method.
18157 (InTransit): new property, used to catch recursive definitions.
18159 * interface.cs: Implement `Define'.
18161 * modifiers.cs: Map Modifiers.constants to
18162 System.Reflection.TypeAttribute flags.
18164 * class.cs: Keep track of types and user-defined types.
18165 (BuilderInit): New method for creating an assembly
18166 (ResolveType): New function to launch the resolution process, only
18167 used by interfaces for now.
18169 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
18170 that are inserted into the name space.
18172 2001-06-08 Miguel de Icaza <miguel@ximian.com>
18174 * ARGH. I have screwed up my tree so many times due to the use of
18175 rsync rather than using CVS. Going to fix this at once.
18177 * driver.cs: Objetify driver. Load assemblies, use assemblies to
18180 2001-06-07 Miguel de Icaza <miguel@ximian.com>
18182 * Experiment successful: Use System.Type rather that our own
18185 2001-05-25 Miguel de Icaza <miguel@ximian.com>
18187 * cs-parser.jay: Removed nsAliases from here.
18189 Use new namespaces, handle `using XXX;'
18191 * namespace.cs: Reimplemented namespace handling, use a recursive
18192 definition of the class. Now we can keep track of using clauses
18193 and catch invalid using clauses.
18195 2001-05-24 Miguel de Icaza <miguel@ximian.com>
18197 * gen-treedump.cs: Adapted for all the renaming.
18199 * expression.cs (Expression): this class now has a Type property
18200 which returns an expression Type.
18202 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
18203 `Type', as this has a different meaning now in the base
18205 2001-05-22 Miguel de Icaza <miguel@ximian.com>
18207 * interface.cs, class.cs: Removed from all the sources the
18208 references to signature computation, as we can not do method
18209 signature computation during the parsing time, as we are not
18210 trying to solve at that point distinguishing:
18214 void a (NS.Blah x) {}
18217 Which depending on the context might be valid or not, as we do not
18218 know if Blah is the same thing as NS.Blah at that point.
18220 * Redid everything so the code uses TypeRefs now instead of
18221 Types. TypeRefs are just temporary type placeholders, that need
18222 to be resolved. They initially have a pointer to a string and the
18223 current scope in which they are used. This is used later by the
18224 compiler to resolve the reference to an actual Type.
18226 * DeclSpace is no longer a CIR.Type, and neither are
18227 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
18228 are all DeclSpaces, but no Types.
18230 * type.cs (TypeRefManager): This implements the TypeRef manager,
18231 which keeps track of all the types that need to be resolved after
18232 the parsing has finished.
18234 2001-05-13 Miguel de Icaza <miguel@ximian.com>
18236 * ARGH. We are going to have to store `foreach' as a class rather
18237 than resolving it, as we need to verify error 1579 after name
18238 resolution. *OR* we could keep a flag that says `This request to
18239 IEnumerator comes from a foreach statement' which we can then use
18240 to generate the error.
18242 2001-05-10 Miguel de Icaza <miguel@ximian.com>
18244 * class.cs (TypeContainer.AddMethod): we now add methods to the
18245 MethodGroup instead of the method hashtable.
18247 * expression.cs: Add MethodGroup abstraction, which gets us one
18248 step closer to the specification in the way we handle method
18251 * cs-parser.jay (primary_expression): qualified_identifier now
18252 tried to match up an identifier to a local variable reference or
18253 to a parameter reference.
18255 current_local_parameters is now a parser global variable that
18256 points to the current parameters for the block, used during name
18259 (property_declaration): Now creates an implicit `value' argument to
18262 2001-05-09 Miguel de Icaza <miguel@ximian.com>
18264 * parameter.cs: Do not use `param' arguments as part of the
18265 signature, per the spec.
18267 2001-05-08 Miguel de Icaza <miguel@ximian.com>
18269 * decl.cs: Base class for classes, structs and interfaces. This
18270 is the "Declaration Space"
18272 * cs-parser.jay: Use CheckDef for checking declaration errors
18273 instead of having one on each function.
18275 * class.cs: Factor out some code for handling error handling in
18276 accordance to the "Declarations" section in the "Basic Concepts"
18277 chapter in the ECMA C# spec.
18279 * interface.cs: Make all interface member classes derive from
18280 InterfaceMemberBase.
18282 2001-05-07 Miguel de Icaza <miguel@ximian.com>
18284 * Many things: all interfaces are parsed and generated in
18285 gen-treedump. Support for member variables, constructors,
18286 destructors, properties, constants is there.
18288 Beginning of the IL backend, but very little done, just there for
18291 2001-04-29 Miguel de Icaza <miguel@ximian.com>
18293 * cs-parser.jay: Fix labeled statement.
18295 * cs-tokenizer.cs (escape): Escape " and ' always.
18296 ref_line, ref_name: keep track of the line/filename as instructed
18297 by #line by the compiler.
18300 2001-04-27 Miguel de Icaza <miguel@ximian.com>
18302 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
18303 to match the values in System.CodeDOM.
18305 Divid renamed to Divide.
18307 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
18309 (Statements.set): remove.
18311 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18314 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18315 falseStatements always have valid values.
18317 * cs-parser.jay: Use System.CodeDOM now.