1 2005-02-09 Raja R Harinath <rharinath@novell.com>
3 Combine two near-redundant caches.
4 * typemanager.cs (method_params): Rename from method_internal_params.
5 (TypeManager.GetParameterData): New. Replace
6 Invocation.GetParameterData.
7 (TypeManager.LookupParametersByBuilder): Remove.
8 * expression.cs (Invocation.method_parameter_cache): Remove.
9 (Invocation.GetParameterData): Remove.
11 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
14 2005-02-08 Raja R Harinath <rharinath@novell.com>
17 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
18 TypeManager.multicast_delegate_type is null, resolve it by looking
19 up "System.MulticastDelegate".
20 * rootcontext.cs (RootContext.ResolveCore): Simplify.
22 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
23 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
24 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
27 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
28 (LabeledStatement.AddReference): New. Set 'referenced'.
29 (Goto.Resolve): Use it.
31 2005-02-05 John Luke <john.luke@gmail.com>
33 * driver.cs: remove duplicate -doc line in Usage ()
35 2005-02-04 Raja R Harinath <rharinath@novell.com>
37 * location.cs (Location.AddFile): Fix CS2002 error report.
39 2005-02-02 Martin Baulig <martin@ximian.com>
41 * delegate.cs (Delegate.DefineType): Report an internal error if
42 TypeManager.multicast_delegate_type is null. See bug #72015 for
45 2005-02-02 Raja R Harinath <rharinath@novell.com>
47 Fix a crasher in a variant of #31984.
48 * const.cs (Constant.CheckBase): New override that defers the
49 new-or-override check in case the base type hasn't been populated
51 (Constant.Define): Ensure the new-or-override check is performed.
53 2005-02-01 Duncan Mak <duncan@ximian.com>
55 * const.cs (LookupConstantValue): Check that `ce' is not null
56 before calling GetValue ().
58 2005-02-01 Raja R Harinath <rharinath@novell.com>
60 Fix test-334.cs (#69519).
61 * cs-parser.jay (using_alias_directive): Pass in an expression to
62 NamespaceEntry.UsingAlias.
63 (using_namespace_directive): Pass in an expression to
65 (namespace_name): Don't flatten to a string.
66 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
67 (NamespaceEntry.AliasEntry.Resolve): Lookup using
69 (NamespaceEntry.UsingEntry): Likewise.
70 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
72 (NamespaceEntry.LookupForUsing): Remove.
73 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
75 (NamespaceEntry.Lookup): Remove support for dotted names.
77 2005-02-01 Raja R Harinath <rharinath@novell.com>
79 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
81 (NamespaceEntry.ImplicitParent): Compute on demand.
82 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
83 parallels the current.
84 (NamespaceEntry.LookupForUsing): Use it.
85 (NamespaceEntry.Lookup): If the current namespace-entry is
86 implicit, don't search aliases and using tables.
88 2005-02-01 Raja R Harinath <rharinath@novell.com>
91 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
93 (TypeContainer.BaseCache): Compute on demand.
94 (TypeContainer.FindMembers): Define constants and types if they're
96 (FieldMember.Define): Move resetting of ec.InUnsafe before error
98 * const.cs (Constant.Define): Make idempotent.
100 2005-01-29 Miguel de Icaza <miguel@novell.com>
102 * pending.cs: Produce better code (no nops produced by using Ldarg
105 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
106 i - 1' it should be arg + 1.
110 2005-01-28 Raja R Harinath <rharinath@novell.com>
112 * attribute.cs (Attribute.CheckAttributeType): Make private
114 (Attribute.ResolveType): Make virtual.
115 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
116 handling of RootContext.Tree.Types.
118 2005-01-27 Raja R Harinath <rharinath@novell.com>
120 Update attribute-handling to use the SimpleName/MemberAccess
122 * cs-parser.jay (attribute): Pass in an expression to the
123 constructors of Attribute and GlobalAttribute.
124 * attribute.cs (Attribute): Take an expression for the name.
125 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
126 passed in attribute name expression.
127 (Attribute.CheckAttributeType): Use it.
128 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
129 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
130 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
131 argument to prevent error messages if the lookup fails.
133 2005-01-27 Marek Safar <marek.safar@seznam.cz>
135 * expression.cs (Indirection): Implemented IVariable interface
136 to support indirection in AddressOf operator.
137 (PointerArithmetic.Emit): Add optimalization for case where
138 result can be precomputed.
140 2005-01-26 Martin Baulig <martin@ximian.com>
142 * class.cs (TypeContainer.AttributeTargets): Return the correct
143 AttributeTargets depending on our `Kind' instead of throwing an
144 exception; fixes #71632.
146 2005-01-26 Marek Safar <marek.safar@seznam.cz>
149 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
152 2005-01-25 Raja R Harinath <rharinath@novell.com>
155 * expression.cs (MemberAccess.DoResolve): Don't complain with
156 cs0572 when the LHS of a member access has identical name and type
159 2005-01-25 Marek Safar <marek.safar@seznam.cz>
162 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
164 Create custom PermissionSet only for PermissionSetAttribute.
166 2005-01-24 Marek Safar <marek.safar@seznam.cz>
169 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
170 delegates in static class.
172 2005-01-24 Martin Baulig <martin@ximian.com>
174 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
175 merging an implicit block, just use its reachability.
177 * statement.cs (Block.Resolve): Make the unreachable code check
178 work wrt. implicit blocks; see test-337 from #63842.
180 2005-01-21 Alp Toker <alp@atoker.com>
182 * cs-parser.jay: destructor_declaration's container is PartialContainer
183 not Class when partial types are used, so use Kind prop instead of
186 2005-01-22 Miguel de Icaza <miguel@ximian.com>
188 * cs-parser.jay: Improve error reporting when an interface
191 2005-01-20 Dick Porter <dick@ximian.com>
193 * support.cs: SeekableStreamReader fix from Sandor Dobos
194 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
195 chars are read. Fixes bug 70369.
197 2005-01-20 Raja R Harinath <rharinath@novell.com>
199 * cs-parser.jay (catch_clause): Simplify current_block handling
202 2005-01-17 Miguel de Icaza <miguel@ximian.com>
204 * convert.cs (ImplicitStandardConversionExists): Synchronize the
205 code with ImplicitStandardConversion to handle the implicit
206 conversion of method groups into valid delegate invocations.
208 The problem is that in parameter handling we were using this code
209 path. Fixes bug #64698
211 2005-01-19 Raja R Harinath <rharinath@novell.com>
213 * cs-parser.jay: Fix several infelicities.
214 - Avoid assigning to the parser value stack. Code like
215 '$3 = null' is unclean. Synthesize a value for the code block
217 - Avoid using oob_stack for storing location information. Use ...
218 (_mark_): ... this. New (empty) rule. Saves the current location
220 (foreach_statement): Avoid using oob_stack for current_block
221 handling. Use technique used in for_statement and
222 using_statement. Synthesize a value for the code block to store
223 additional intermediate information.
225 2005-01-13 Miguel de Icaza <miguel@ximian.com>
227 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
228 of a different type is only allowed to private fields of a
229 containing type, not on fields of a base class.
231 See test-174.cs and error cs0122-9.cs
233 2005-01-13 Raja R Harinath <rharinath@novell.com>
235 Fix test-335.cs (bug #58126).
236 * cs-parser.jay (argument): Split out non-expression parts of the
237 rule into 'non_simple_argument'.
238 (invocation_expression): Support parenthesized invocations with
239 multiple arguments, and with single non-simple arguments.
241 2005-01-13 Raja R Harinath <rharinath@novell.com>
243 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
246 2005-01-12 Raja R Harinath <rharinath@novell.com>
248 Fix cs0038-1.cs, cs1640-6.cs.
249 * ecore.cs (Expression.Resolve): Remove special-case for
250 SimpleName in error-handling.
251 (Expression.almostMatchedMembers): Relax access permission to
253 (Expression.MemberLookupFailed): Handle duplicates in
254 almostMatchedMembers list.
255 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
256 * expression.cs (New.DoResolve): Report CS1540 for more cases.
257 * typemanager.cs (GetFullNameSignature): Use the MethodBase
258 overload if the passed in MemberInfo is a MethodBase.
260 2005-01-12 Marek Safar <marek.safar@seznam.cz>
263 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
264 for non-CAS & merge permission sets properly.
266 2005-01-11 Raja R Harinath <rharinath@novell.com>
268 Improve standard-compliance of simple name and member access
269 resolution. Fixes bugs #52697, #57200, #67520, #69519.
270 * ecore.cs (FullNamedExpression): New abstract base class
271 for Namespaces and TypeExpressions.
272 (ResolveFlags.SimpleName): Remove.
273 (SimpleName): Remove support for dotted names.
274 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
275 DeclSpace.FindType and DeclSpace.LookupType.
276 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
277 (Expression.ExprClassName): Make member function.
278 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
279 a namespace. Remove creation of dotted "SimpleName"s.
280 (MemberAccess.DoResolve): Likewise.
281 * decl.cs (DeclSpace.Cache): Make private.
282 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
283 (DeclSpace.FindType): Update.
284 (DeclSpace.LookupType): Move here from RootContext. Return a
286 * namespace.cs (Namespace): Derive from FullNamedExpression
287 so that it can be part of expression resolution.
288 (Namespace.Lookup): Return an FullNamedExpression.
289 (NamespaceEntry.LookupAlias): Lookup aliases only in current
291 * rootcontext.cs (NamespaceLookup): Remove.
292 (LookupType): Move to DeclSpace.
293 * attribute.cs (CheckAttributeType): Update.
294 * doc.cs (FindDocumentedType): Remove allowAlias argument.
295 (FindDocumentedTypeNonArray): Likewise.
297 2005-01-11 Raja R Harinath <rharinath@novell.com>
299 Fix cs0509.cs, cs1632.cs.
300 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
301 is the same as IsInterface.
302 (TypeContainer.GetClassBases): Likewise.
303 * statement.cs (LabeledStatement.ig): New field.
304 (LabeledStatement.LabelTarget): Save ILGenerator which created the
306 (LabeledStatement.DoEmit): Check that the label was created with
307 the same ILGenerator.
309 2005-01-10 Marek Safar <marek.safar@seznam.cz>
312 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
313 accessors to its properties.
315 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
316 from accessors to property.
318 2005-01-10 Marek Safar <marek.safar@seznam.cz>
321 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
324 2005-01-08 Miguel de Icaza <miguel@ximian.com>
326 * attribute.cs: Check for null and empty strings.
328 I have lost another battle to Paolo.
330 2005-01-07 Marek Safar <marek.safar@seznam.cz>
333 * class.cs (PropertyMethod): Set Parent field in ctors.
334 (SetMethod.InternalParameters): Add unsafe switch hack.
335 Override MarkForDuplicationCheck where it is appropriate.
337 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
338 It says whether container allows members with the same name.
340 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
341 Removed is_method parameter.
343 2005-01-06 Duncan Mak <duncan@ximian.com>
345 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
346 because the previous change led to incorrect reporting of CS1032
347 ("Cannot define/undefine preprocessor symbols after first token in
348 file"). Instead of using `tokens_seen' as the only flag that
349 triggers CS1040, introduce `comments_seen'. This new flag is used
350 to signify having seen comments on the current line, so it is
351 unset after a newline.
353 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
355 * doc.cs : When searching for a type, find nested type too.
356 This fixes bug #71040.
358 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
361 - Warn missing member comment on those classes which also does not
362 have doc comments. Fixed bug #71041.
363 - Don't warn missing doc comment on default constructor.
366 2005-01-06 Duncan Mak <duncan@ximian.com>
368 * cs-tokenizer.cs (xtoken): After handling traditional C-style
369 comments, set `tokens_seen' to true. This allows us to detect
370 misplaced preprocessor directives (i.e. not at the beginning of
371 the a line, nor after whitespaces). In that case, report error
372 CS1040. This fixes bug #56460.
374 * cs-parser.jay (interface_member_declaration): Add checks for
375 IsExplicitImpl, and report CS0541 error if an interface member is
376 defined as an explicit interface declaration.
378 2005-01-06 Marek Safar <marek.safar@seznam.cz>
381 * class.cs (PropertyMethod): Set Parent field in ctors.
382 (SetMethod.InternalParameters): Add unsafe switch hack.
384 * decl.cs (MemberCore.Parent): Cannot be readonly.
386 2005-01-06 Raja R Harinath <rharinath@novell.com>
388 * decl.cs (DeclSpace.ResolveType): Remove.
389 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
390 Merge in code from ...
391 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
392 * class.cs, enum.cs: Update to changes.
394 2005-01-06 Miguel de Icaza <miguel@ximian.com>
396 * anonymous.cs: Ensure that we init the scope of our parent if it
397 has not been initialized yet.
399 2004-12-30 Duncan Mak <duncan@ximian.com>
401 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
402 if field.FieldBuilder is null. Fixes #70758.
404 * convert.cs: Fixed some typos and updated some of the comments.
405 (ImplicitStandardConversionExists):
406 (TryImplicitIntConversion): If `target_type' is an interface and
407 the type of `ic' implements this interface, return true or a new
408 BoxedCast instead of null. This fixes #70468.
410 2004-12-29 Duncan Mak <duncan@ximian.com>
412 * expression.cs (Argument.Emit): Check that Expr is
413 IMemoryLocation before casting to it, and report CS1510 otherwise.
417 2004-12-21 Ben Maurer <bmaurer@ximian.com>
419 * statement.cs (Block.ThisVariable): remove the recursion here, to
420 make the --profile more sane.
422 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
424 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
425 assembly, by JB Evain.
427 2004-12-17 Raja R Harinath <rharinath@novell.com>
429 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
430 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
431 "parent" refers to enclosing type/class. "base" refers to superclass.
433 2004-12-17 Raja R Harinath <rharinath@novell.com>
435 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
436 Ensure that we only have GlobalAttributes.
437 * attribute.cs (Attribute.Emit): Make non-virtual.
438 (GlobalAttribute.Emit): Remove.
439 (Attribute.Resolve): Make virtual.
440 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
441 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
442 the argument. Don't create one.
443 (Attribute.GetObsoleteAttribute): Likewise.
444 (Attribute.GetClsCompliantAttributeValue): Likewise.
445 * class.cs, decl.cs: Update to changes.
447 2004-12-17 Marek Safar <marek.safar@seznam.cz>
449 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
451 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
453 * statement.cs (Foreach.Resolve): Add error 186 report.
455 2004-12-16 Marek Safar <marek.safar@seznam.cz>
457 * expression.cs (Conditional.DoResolve): Add warning 429.
459 * statement.cs (If.Resolve): Add warning 665.
461 2004-12-16 Raja R Harinath <rharinath@novell.com>
463 New invariant: RootContext.Tree.Types.NamespaceEntry == null
464 except when in the parser, and in GlobalAttribute.
465 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
466 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
467 RootContext.Tree.Types.NamespaceEntry once work is done.
468 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
469 and resets RootContext.Tree.Types.NamespaceEntry.
471 2004-12-15 Marek Safar <marek.safar@seznam.cz>
473 * cs-parser.jay: Don't create a block for every variable.
475 2004-12-14 Miguel de Icaza <miguel@ximian.com>
477 * location.cs: Provide extra information.
479 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
480 variables from the captured environment, it is the ldarg_0.
482 2004-12-14 Marek Safar <marek.safar@seznam.cz>
484 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
487 * class.cs: Changed warning level for 169 to avoid developer
488 displeasure from warning flooding. It will be changed back when they
489 fix most of current BCL warnings.
491 * RootContext.cs: Pushed default WarningLevel to 3.
493 * statement.cs: Removed unused variable.
495 2004-12-14 Marek Safar <marek.safar@seznam.cz>
497 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
498 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
499 Add error 502 report.
500 (StaticClass.DefineType): Add error 441 report.
501 (Class.AllowedModifiersProp): New virtual property as temporary
502 extension to AllowedModifiers.
503 (Class.DefineType): Add error 418 report. Moved ModFlags check here
504 to share implementation with StaticClass and don't call virtual
507 * driver.cs (MainDriver): Add error 1558 test.
509 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
510 report. Moved error 36 test here.
512 * statement.cs (Throw.Resolve): Add error 724 report.
514 * typemanager.cs: Add out_attribute_type core type.
516 2004-12-13 Marek Safar <marek.safar@seznam.cz>
518 * class.cs (TypeContainer.VerifyClsCompliance): Add error
520 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
522 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
525 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
527 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
528 Add error 3023 report.
529 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
531 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
534 2004-12-12 John Luke <john.luke@gmail.com>
536 * driver.cs (AddArgs): take -- into account when
537 adding arguments, fixes bug 65710
539 2004-12-12 Martin Baulig <martin@ximian.com>
541 * expression.cs (Unary.TryReduceNegative): Added support for
542 SByteConstant and ByteConstant.
543 (Unary.Reduce): Check error values from TryReduceNegative().
545 2004-12-10 Marek Safar <marek.safar@seznam.cz>
547 * attributes.cs (Attribute.Resolve): Avoid multiple error report
548 and report exception as error 182.
550 2004-12-10 Raja R Harinath <rharinath@novell.com>
552 * driver.cs (Main): Fix message when there are warnings.
554 2004-12-09 Miguel de Icaza <miguel@ximian.com>
556 * delegate.cs: Fixed my fix from yesterday, sorry about that.
558 2004-12-09 Marek Safar <marek.safar@seznam.cz>
560 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
561 Reduced number of warnings.
563 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
565 2004-12-08 Miguel de Icaza <miguel@ximian.com>
567 * driver.cs: Removed message.
569 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
571 2004-12-08 <vargaz@freemail.hu>
573 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
575 2004-12-08 Martin Baulig <martin@ximian.com>
577 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
578 instead of a CS3002 for properties and indexer.
580 2004-12-08 Martin Baulig <martin@ximian.com>
582 * decl.cs (MemberName.ToString): Make this work again.
584 2004-12-08 Marek Safar <marek.safar@seznam.cz>
586 * attribute.cs (Resolve): Add error 591 detection.
588 * class.cs (FieldMember.Define): Add error 1547 detection.
589 (Indexer.Define): Add error 620 detection.
590 (Operator.Define): Add error 590 detection.
592 * ecore.cs: Missing argument for error 79.
594 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
597 2004-12-07 Marek Safar <marek.safar@seznam.cz>
600 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
603 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
605 * cs-parser.jay : handle doc comments on implicit/explicit operators.
606 Some operator comments were suppressed.
607 * doc.cs : Implicit/explicit operator name in doc comments are like
608 "op_Explicit(type)~returnType", so added suffix handling.
610 2004-12-07 Martin Baulig <martin@ximian.com>
613 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
614 (MemberCore.GetClsCompliantAttributeValue): Likewise.
615 (DeclSpace.ec): New protected field; store the EmitContext here.
616 (DeclSpace.EmitContext): New public property; moved here from
618 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
621 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
622 (Enum.Emit): Don't create a new EmitContext.
624 * delegate.cs (Delegate.DefineType): Always create the
627 * iterators.cs (Iterators.DefineIterator): Create a new
628 EmitContext and store it in `ec'.
630 2004-08-24 Martin Baulig <martin@ximian.com>
633 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
634 this for accessibility checks.
635 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
636 IsNestedFamilyAccessible.
637 (TypeManager.IsSubclassOf): New method, do what the name actually
640 2004-12-06 Raja R Harinath <rharinath@novell.com>
642 Fix crash on cs0657-17.cs.
643 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
644 Use RootContext.Tree.Types, not 'new RootTypes ()'.
645 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
646 the case where the NamespaceEntry gets overwritten.
648 2004-12-06 Marek Safar <marek.safar@seznam.cz>
651 * ecore.cs (ResolveBoolean): Tiny refactoring.
653 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
654 of right expression resolving when left is false constant and
655 operator is LogicalAnd OR true constant and operator is LogicalOr.
657 * statement.cs (ResolveUnreachable): Always reports warning.
659 2004-12-05 Miguel de Icaza <miguel@ximian.com>
661 * class.cs: Distinguish between 1721 and 1722 (just a little help
664 2004-12-03 Miguel de Icaza <miguel@ximian.com>
666 * delegate.cs: Only allow this on new versions of the language.
668 2004-12-02 Duncan Mak <duncan@ximian.com>
670 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
672 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
673 here as a static method. Take an additional bool out parameter
674 `must_do_cs1540_check' for signaling to InstanceResolve.
675 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
676 member field from PropertyExpr class and made it an argument of
678 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
679 check for MarshalByRefObject, and report CS0122 instead of CS1540.
680 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
681 and `remove_accessor' as well as InstanceResolve: report CS0122
686 2004-12-03 Raja R Harinath <rharinath@novell.com>
688 Fix test-327.cs, test-328.cs, and put in early infrastructure
689 for eventually fixing #52697.
690 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
691 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
693 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
694 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
695 (VerifyUsing, error246): Update.
696 * rootcontext.cs (RootContext.NamespaceLookup): Just use
697 'NamespaceEntry.LookupNamespaceOrType'.
699 2004-12-03 Martin Baulig <martin@ximian.com>
701 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
702 method as our child, call AnonymousMethod.Compatible() on it.
704 2004-12-03 Raja R Harinath <rharinath@novell.com>
706 Disable XML documentation support in 'basic' profile.
707 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
708 Redirect XmlElement to System.Object.
709 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
710 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
711 * mcs.exe.sources: Add doc-bootstrap.cs.
712 * doc-bootstrap.cs: New file. Contains empty stub implementation
715 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
717 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
718 comments are allowed.
720 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
722 * delegate.cs: Add checks for subtypes in paramaters and return values
723 in VerifyMethod () to add support for Covariance/Contravariance
726 2004-12-02 Miguel de Icaza <miguel@ximian.com>
728 * report.cs: Remove extra closing parenthesis.
730 * convert.cs (Error_CannotImplicitConversion): If the name of the
731 types are the same, provide some extra information.
733 * class.cs (FieldBase): Use an unused bit field from the field to
734 encode the `has_offset' property from the FieldMember. This saves
735 a couple of Ks on bootstrap compilation.
737 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
738 method as our child, return the AnonymousMethod resolved
741 * expression.cs (New.DoResolve): Allow return values from
742 NewDelegate to also include AnonymousMethods.
746 2004-12-02 Marek Safar <marek.safar@seznam.cz>
749 * attribute.cs (Resolve): Improved implementation of params
752 * support.cs (ParameterData): Add HasParams to be faster.
754 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
756 all things are for /doc support:
758 * doc.cs: new file that supports XML documentation generation.
759 * mcs.exe.sources: added doc.cs.
761 Handle /doc command line option.
762 Report error 2006 instead of 5 for missing file name for /doc.
763 Generate XML documentation when required, after type resolution.
765 Added support for picking up documentation (/// and /** ... */),
766 including a new XmlCommentState enumeration.
768 Added lines to fill Documentation element for field, constant,
769 property, indexer, method, constructor, destructor, operator, event
770 and class, struct, interface, delegate, enum.
771 Added lines to warn incorrect comment.
773 Added Documentation field (passed only when /doc was specified).
775 Added DocComment, DocCommentHeader, GenerateDocComment() and
776 OnGenerateDocComment() and some supporting private members for
777 /doc feature to MemberCore.
779 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
781 Added overriden DocCommentHeader.
783 Added overriden DocCommentHeader and GenerateDocComment().
785 2004-12-01 Miguel de Icaza <miguel@ximian.com>
787 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
788 unwrapping the enumeration values, chain to
789 DoConstantNumericPromotions again, so we can promote things to the
790 fundamental types (takes care of enums that are bytes, sbytes).
794 2004-12-01 Raja R Harinath <rharinath@novell.com>
796 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
797 Fix long-standing bug in type-lookup. Use FindType instead of
798 LookupType when ec.ResolvingTypeTree.
799 (Attribute.ResolveType, Attribute.Resolve)
800 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
802 (Attributes.Search): Remove internal version. Update.
803 (Attributes.SearchMulti): Update.
804 (Attributes.GetClsCompliantAttribute): Remove.
805 (Attributes.GetIndexerNameAttribute): Remove.
806 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
807 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
808 * class.cs (Indexer.Define): Likewise.
810 2004-12-01 Marek Safar <marek.safar@seznam.cz>
813 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
814 MarshallByReference members access.
816 * expression.cs: Use CheckMarshallByRefAccess;
817 Better error CS0197 message.
819 * report.cs: Print whole related error message.
821 2004-11-30 Raja R Harinath <rharinath@novell.com>
823 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
824 the current directory to help debugging.
826 2004-11-29 Marek Safar <marek.safar@seznam.cz>
828 * class (GetClassBases): Better error 60 report.
829 (EventProperty): Disabled warning 67 detection.
831 2004-11-29 Marek Safar <marek.safar@seznam.cz>
834 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
836 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
839 2004-11-29 Marek Safar <marek.safar@seznam.cz>
842 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
844 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
846 2004-11-26 Miguel de Icaza <miguel@ximian.com>
848 * attribute.cs (Attribute.Resolve): Refine error reporting and
849 report a cs0117 if the identifier does not exist, to distinguish
850 from 0617 which is a miss-use of the actual identifier.
852 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
853 between cs0070 and cs0079.
855 * class.cs (MemberBase.DoDefine): When reporting a wrong
856 accessibility level, we use MethodCore to compare instead of
857 Method (this was a regression in some refactoring effort).
859 So now we correctly report cs0056 again.
861 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
862 testing the target_type (which was known to be object_type) and
863 not the source type (which is anonymous_method).
865 Fixed reporting of error cs1660.
867 * expression.cs (UserCast.Source): Expose the underlying cast.
869 * statement.cs (Switch.SwitchGoverningType): Sort the list of
870 allowed types to find a match to int32 first (most common).
872 In addition, it ignores any ImplicitUserConversions that did an
873 internal implicit conversion (as the switch statement allows only
874 one integral conversion to exist).
876 * class.cs (PartialContainer.Create): rename `name' to
877 `member_name' for clarity. Then replace the string calls with a
878 call to MemberName.GetPartialName, as now using
879 MemberName.ToString is an error (this is due to the side effects
880 it had, that were fixed in the past).
882 This will restore the error reporting on a number of partial class
883 errors that were missusing this (and getting an exception as a
884 results, which is now just a plain textual warning, because
885 yyparse debug output would crash otherwise).
887 2004-11-26 Raja R Harinath <rharinath@novell.com>
889 * Makefile (PROGRAM_INSTALL_DIR): Remove.
891 2004-11-25 Ben Maurer <bmaurer@ximian.com>
893 * rootcontext.cs (LookupType): Make sure to cache lookups that
894 don't give us a negative result. This saves about 5% of corlib
897 2004-11-25 Miguel de Icaza <miguel@ximian.com>
899 * report.cs (AbstractMessage.Print): messages are sent to stderr
901 * class.cs (TypeContainer.GetClassBases): It is an error to have a
902 non-interface in the list of interfaces (at this point, either
903 parent was properly set, or a base class is being listed in the
906 This flags error 1722, and resolves the crash from bug 69259.
908 2004-11-25 Ben Maurer <bmaurer@ximian.com>
910 * statement.cs (Using.EmitExpressionFinally): make this work right
911 for valuetypes. Fixes 69926.
913 2004-11-25 Miguel de Icaza <miguel@ximian.com>
915 * const.cs (Const.ChangeType): Cope with the "0 literal can be
916 converted to an enum" here, before we try to change the underlying
917 type. This code exists, but it is a different code path than the
918 one used while encoding constants.
920 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
921 old bug: when converting from the null literal to a pointer,
922 return an EmptyCast, not the NullLiteral.
924 This fixes #69921, the recent null_type changes probably made this
927 (ImplicitReferenceConversionExists): In addition, resynchronized
928 the code here, so it matches the same code in
929 ImplicitReferenceConversionExists for the `from any class-type S
930 to any interface-type T'.
933 2004-11-25 Marek Safar <marek.safar@seznam.cz>
935 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
937 2004-11-24 Miguel de Icaza <miguel@ximian.com>
939 * cs-parser.jay: Use verbosity accordingly.
941 2004-11-24 Marek Safar <marek.safar@seznam.cz>
943 * expression.cs (Unary.ResolveOperator): Do not report warning;
944 AddressOf reads from variable.
946 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
948 2004-11-24 Marek Safar <marek.safar@seznam.cz>
952 * attribute.cs (Attributable): Removed CheckTargets.
953 (Attributes.Emit): Explicit attribute targets are tested here.
955 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
956 not enabled for interfaces.
958 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
959 (GetAssemblyName): Ouch next bug there.
961 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
963 * expression.cs: Error 275 added.
965 2004-11-23 Marek Safar <marek.safar@seznam.cz>
967 Fix bug #69177 (Implemented decimal constant support)
969 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
970 (BinaryFold): Add DecimalConstant.
972 * const.cs (Define): Decimal constant
974 (ChangeType): Add decimal type handling.
975 (LookupConstantValue): Don't set value for decimal type but
976 emit DecimalConstantAttribute. Needed for constant optimization.
978 * constant.cs (ToDecimal): New method.
979 (ConvertToDecimal): New method.
980 (IntConstant): Implemented ConvertToDecimal.
981 (DecimalConstant.Emit): Emit optimized version for decimals in
984 * expression.cs (ResolveOperator): Changed order of constant
985 reduction to work correctly with native types which have
986 overloaded operators.
987 (ResolveMemberAccess): Extract constant value from attribute
990 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
992 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
993 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
994 (ChangeType): Decimal is special.
995 (TypeToCoreType): Add decimal type.
997 2004-11-22 Marek Safar <marek.safar@seznam.cz>
999 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
1002 2004-11-22 Marek Safar <marek.safar@seznam.cz>
1004 * class.cs (EventField.ApplyAttributeBuilder): Fix error
1007 2004-11-19 Marek Safar <marek.safar@seznam.cz>
1009 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
1011 * pending.cs (PendingImplementation): Grab only interfaces.
1013 2004-11-19 Marek Safar <marek.safar@seznam.cz>
1015 * statement.cs (ForeachHelperMethods): Add location member and
1016 error 202 detection.
1018 2004-11-19 Raja R Harinath <rharinath@novell.com>
1020 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
1021 automatically handled by executable.make.
1022 (PROGRAM): Make profile-specific.
1024 2004-11-18 Marek Safar <marek.safar@seznam.cz>
1026 * expression.cs (DoResolveBase): Fixed wrong warning for out
1029 2004-11-18 Martin Baulig <martin@ximian.com>
1031 Merged latest changes into gmcs. Please keep this comment in
1032 here, it makes it easier for me to see what changed in MCS since
1033 the last time I merged.
1035 2004-11-17 Raja R Harinath <rharinath@novell.com>
1037 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
1038 (TypeHandle.GetMemberCache): New.
1039 (TypeHandle.TypeHandle): Update.
1040 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
1041 (TypeManager.LookupParentInterfacesCache):
1042 Rename from LookupInterfaceCache. Optimize slightly.
1043 (TypeManager.MemberLookup_FindMembers): Update.
1044 * decl.cs (MemberCache.MemberCache): Set Container to null in the
1046 (AddCacheContents): Rename from AddHashtable.
1047 * class.cs (TypeContainer.parent_container): Remove.
1048 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
1049 (TypeContainer.DoDefineMembers): Don't initialize it.
1050 Update to name changes.
1052 2004-11-17 Miguel de Icaza <miguel@ximian.com>
1054 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
1055 that factors the code to check access modifiers on override.
1057 (PropertyBase): Use the code here.
1059 Patch from Lluis S'anchez, fixes bug #69361.
1061 2004-11-15 Miguel de Icaza <miguel@ximian.com>
1063 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
1064 routine that is used to report the use of a captured variable
1065 whose address has been taken.
1067 There are two checks: one when variables are being captured and
1068 the other check is when the address of a variable is taken.
1070 (because an anonymous methods might be resolved before *or* after
1071 the address has been taken) and
1073 * expression.cs (Conditional.DoResolve): Remove the special
1074 casing that Martin added to trueExpr and falseExpr being both
1075 NullLiteral. We get the right behavior now just by introducing
1076 the null_type into the compiler.
1078 * convert.cs (ExplicitConversion): Change the code to use
1079 null_type instead of testing `expr is NullLiteral'.
1080 (ImplicitConversionStandard): use null_type too.
1081 (ImplicitReferenceConversionExists): use null_type too.
1082 (ImplicitReferenceConversion): use null_type too.
1084 * literal.cs: The type of `NullLiteral' is now null_type instead
1086 (Resolve): Set the type here.
1088 * typemanager.cs: Introduce null_type.
1090 2004-11-17 Martin Baulig <martin@ximian.com>
1092 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
1093 direction, like FindMembers() does. Fixes #69546, testcase is in
1096 2004-11-16 Martin Baulig <martin@ximian.com>
1098 This is based on a patch from Marek Safar, see bug #69082.
1099 Fixes bugs #63705 and #67130.
1101 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
1102 method; create a MemberCache for an interface type and cache the
1105 * decl.cs (IMemberContainer.ParentContainer): Removed.
1106 (IMemberContainer.ParentCache): New property.
1107 (MemberCache.SetupCacheForInterface): Removed.
1108 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
1109 to create a cache for an interface's "parent".
1111 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
1114 2004-11-16 Martin Baulig <martin@ximian.com>
1116 Merged back from gmcs; these changes already went into gmcs a
1117 couple of weeks ago.
1120 (TypeManager.AddUserType): Removed the `ifaces' argument.
1121 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
1123 (TypeManager.AddUserInterface): Removed.
1124 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
1126 (TypeManager.GetInterfaces): Likewise.
1127 (TypeManager.GetExplicitInterfaces): Likewise.
1129 * ecore.cs (TypeExpr.GetInterfaces): Removed.
1131 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
1132 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
1134 2004-11-14 Ben Maurer <bmaurer@ximian.com>
1136 * statement.cs: Avoid adding bools to a hashtable.
1138 2004-11-07 Miguel de Icaza <miguel@ximian.com>
1140 * expression.cs (Invocation.OverloadResolve): Flag error if we are
1141 calling an unsafe method from a safe location.
1143 2004-11-06 Marek Safar <marek.safar@seznam.cz>
1146 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
1148 2004-11-06 Miguel de Icaza <miguel@ximian.com>
1150 * namespace.cs (VerifyUsing): use GetPartialName instead of
1153 2004-11-05 Miguel de Icaza <miguel@ximian.com>
1155 * statement.cs (Return.Resolve): Fix regression in typo: if
1156 `in_exc', we have to request a NeedReturnLabel, this was a typo
1157 introduced in the anonymous method check-in. Fixes #69131.
1159 * Indexers were using the ShortName when defining themselves,
1160 causing a regression in the compiler bootstrap when applying the
1161 patch from 2004-11-02 (first part), now they use their full name
1162 and the bug is gone.
1164 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
1166 * driver.cs: Strip the path from the names of embedded resources. Fixes
1169 2004-11-04 Raja R Harinath <rharinath@novell.com>
1171 Fix error message regression: cs0104-2.cs.
1172 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
1173 (AliasEntry.Resolve): Update.
1174 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
1176 (RootContext.LookupType): Update.
1178 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
1180 * cs-parser.jay: Add support for handling accessor modifiers
1181 * class: Add support port accessor modifiers and error checking,
1182 define PropertyMethod.Define as virtual (not abstract anymore)
1183 * ecore.cs: Add checking for proeprties access with access modifiers
1184 * iterators.cs: Modify Accessor constructor call based in the modified
1186 2004-11-02 Ben Maurer <bmaurer@ximian.com>
1188 * expression.cs (StringConcat): Handle being called twice,
1189 as when we have a concat in a field init with more than two
1192 2004-11-02 Miguel de Icaza <miguel@ximian.com>
1194 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
1195 special case explicit implementations, we should always produce
1196 the .property or .event declaration.
1198 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
1199 since it will not return correct data if people use this
1200 unresolved in the presence of using statements (see test-313).
1202 * class.cs (MethodData.Define): If we are an explicit interface
1203 implementation, set the method name to the full name of the
1204 interface plus the name of the method.
1206 Notice that using the method.MethodName.GetFullName() does not
1207 work, as it will only contain the name as declared on the source
1208 file (it can be a shorthand in the presence of using statements)
1209 and not the fully qualifed type name, for example:
1213 class D : ICloneable {
1214 object ICloneable.Clone () {
1218 Would produce a method called `ICloneable.Clone' instead of
1219 `System.ICloneable.Clone'.
1221 * namespace.cs (Alias.Resolve): Use GetPartialName.
1223 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1225 * cs-parser.jay: Add error 1055 report.
1227 2004-11-01 Miguel de Icaza <miguel@ximian.com>
1229 * assign.cs (Assign.DoResolve): Only do the transform of
1230 assignment into a New if the types are compatible, if not, fall
1231 through and let the implicit code deal with the errors and with
1232 the necessary conversions.
1234 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1236 * cs-parser.jay: Add error 1031 report.
1238 * cs-tokenizer.cs: Add location for error 1038.
1240 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1242 * cs-parser.jay: Add error 1016 report.
1244 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1246 * cs-parser.jay: Add errors 1575,1611 report.
1248 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1250 * cs-parser.jay: Add error 1001 report.
1252 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1255 * attribute.cs (GetMarshal): Add method argument for
1256 caller identification.
1258 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
1259 agument for GetMarshal and RuntimeMissingSupport.
1261 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1263 * attribute.cs (ExtractSecurityPermissionSet): Removed
1264 TypeManager.code_access_permission_type.
1266 * typemanager.cs: Removed TypeManager.code_access_permission_type.
1268 2004-10-27 Miguel de Icaza <miguel@ximian.com>
1270 * expression.cs (LocalVariableReference.DoResolveLValue): Check
1271 for obsolete use of a variable here. Fixes regression on errors
1272 cs0619-25 and cs0619-26.
1274 2004-10-27 Marek Safar <marek.safar@seznam.cz>
1276 Fix #62358, implemented security attribute encoding.
1278 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
1279 Tests permitted SecurityAction for assembly or other types.
1280 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
1281 data from SecurityPermissionAttribute to PermisionSet class.
1283 * class.cs (ApplyAttributeBuilder): Added special handling
1284 for System.Security.Permissions.SecurityAttribute based types.
1286 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
1287 special handling for System.Security.Permissions.SecurityAttribute
1290 * enum.cs (ApplyAttributeBuilder): Added special handling
1291 for System.Security.Permissions.SecurityAttribute based types.
1293 * parameter.cs (ApplyAttributeBuilder): Added special handling
1294 for System.Security.Permissions.SecurityAttribute based types.
1296 * rootcontext.cs: Next 2 core types.
1298 * typemanager.cs (TypeManager.security_permission_attr_type):
1299 Built in type for the SecurityPermission Attribute.
1300 (code_access_permission_type): Build in type.
1302 2004-10-17 Miguel de Icaza <miguel@ximian.com>
1304 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
1305 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
1306 all of this information into
1307 EmitContext.EmitCapturedVariableInstance.
1309 * codegen.cs (EmitCapturedVariableInstance): move here the
1310 funcionality of emitting an ldarg.0 in the presence of a
1311 remapping. This centralizes the instance emit code.
1313 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
1314 then emit a load of this: it means that we have reached the
1315 topmost ScopeInfo: the one that contains the pointer to the
1316 instance of the class hosting the anonymous method.
1318 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
1319 captures to the topmost CaptureContext.
1321 2004-10-12 Miguel de Icaza <miguel@ximian.com>
1323 * expression.cs (LocalVariableReference): Move the knowledge about
1324 the iterators into codegen's EmitCapturedVariableInstance.
1326 2004-10-11 Miguel de Icaza <miguel@ximian.com>
1328 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
1329 all code paths return a value from an anonymous method (it is the
1330 same as the 161 error, but for anonymous methods).
1332 2004-10-08 Miguel de Icaza <miguel@ximian.com>
1334 The introduction of anonymous methods in the compiler changed
1335 various ways of doing things in the compiler. The most
1336 significant one is the hard split between the resolution phase
1337 and the emission phases of the compiler.
1339 For instance, routines that referenced local variables no
1340 longer can safely create temporary variables during the
1341 resolution phase: they must do so from the emission phase,
1342 since the variable might have been "captured", hence access to
1343 it can not be done with the local-variable operations from the runtime.
1347 (Block.Flags): New flag `IsTopLevel' to indicate that this block
1348 is a toplevel block.
1350 (ToplevelBlock): A new kind of Block, these are the blocks that
1351 are created by the parser for all toplevel method bodies. These
1352 include methods, accessors and anonymous methods.
1354 These contain some extra information not found in regular blocks:
1355 A pointer to an optional CaptureContext (for tracking captured
1356 local variables and parameters). A pointer to the parent
1359 (Return.Resolve): Catch missmatches when returning a value from an
1360 anonymous method (error 1662).
1361 Invoke NeedReturnLabel from the Resolve phase instead of the emit
1364 (Break.Resolve): ditto.
1366 (SwitchLabel): instead of defining the labels during the
1367 resolution phase, we now turned the public ILLabel and ILLabelCode
1368 labels into methods called GetILLabelCode() and GetILLabel() that
1369 only define the label during the Emit phase.
1371 (GotoCase): Track the SwitchLabel instead of the computed label
1372 (its contained therein). Emit the code by using
1373 SwitchLabel.GetILLabelCode ().
1375 (LocalInfo.Flags.Captured): A new flag has been introduce to track
1376 whether the Local has been captured or not.
1378 (LocalInfo.IsCaptured): New property, used to tell whether the
1379 local has been captured.
1381 * anonymous.cs: Vastly updated to contain the anonymous method
1384 The main classes here are: CaptureContext which tracks any
1385 captured information for a toplevel block and ScopeInfo used to
1386 track the activation frames for various local variables.
1388 Each toplevel block has an optional capture context associated
1389 with it. When a method contains an anonymous method both the
1390 toplevel method and the anonymous method will create a capture
1391 context. When variables or parameters are captured, they are
1392 recorded on the CaptureContext that owns them, for example:
1396 MyDelegate d = delegate {
1401 Here `a' will be recorded as captured on the toplevel
1402 CapturedContext, the inner captured context will not have anything
1403 (it will only have data if local variables or parameters from it
1404 are captured in a nested anonymous method.
1406 The ScopeInfo is used to track the activation frames for local
1407 variables, for example:
1409 for (int i = 0; i < 10; i++)
1410 for (int j = 0; j < 10; j++){
1411 MyDelegate d = delegate {
1416 At runtime this captures a single captured variable `i', but it
1417 captures 10 different versions of the variable `j'. The variable
1418 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
1419 recorded on a child.
1421 The toplevel ScopeInfo will also track information like the `this'
1422 pointer if instance variables were referenced (this is necessary
1423 as the anonymous method lives inside a nested class in the host
1424 type of the method).
1426 (AnonymousMethod): Expanded to track the Toplevel, implement
1427 `AnonymousMethod.Compatible' to tell whether an anonymous method
1428 can be converted to a target delegate type.
1430 The routine now also produces the anonymous method content
1432 (AnonymousDelegate): A helper class that derives from
1433 DelegateCreation, this is used to generate the code necessary to
1434 produce the delegate for the anonymous method that was created.
1436 * assign.cs: API adjustments for new changes in
1437 Convert.ImplicitStandardConversionExists.
1439 * class.cs: Adjustments to cope with the fact that now toplevel
1440 blocks are of type `ToplevelBlock'.
1442 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
1443 insteda of standard blocks.
1445 Flag errors if params arguments are passed to anonymous methods.
1447 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
1448 `CurrentAnonymousMethod' which points to the current Anonymous
1449 Method. The variable points to the AnonymousMethod class that
1450 holds the code being compiled. It is set in the new EmitContext
1451 created for the anonymous method.
1453 (EmitContext.Phase): Introduce a variable and an enumeration to
1454 assist in enforcing some rules about when and where we are allowed
1455 to invoke certain methods (EmitContext.NeedsReturnLabel is the
1456 only one that enfonces this right now).
1458 (EmitContext.HaveCaptureInfo): new helper method that returns
1459 whether we have a CapturedContext initialized.
1461 (EmitContext.CaptureVariable): New method used to register that a
1462 LocalInfo must be flagged for capturing.
1464 (EmitContext.CapturedParameter): New method used to register that a
1465 parameters must be flagged for capturing.
1467 (EmitContext.CapturedField): New method used to register that a
1468 field must be flagged for capturing.
1470 (EmitContext.HaveCapturedVariables,
1471 EmitContext.HaveCapturedFields): Return whether there are captured
1472 variables or fields.
1474 (EmitContext.EmitMethodHostInstance): This is used to emit the
1475 instance for the anonymous method. The instance might be null
1476 (static methods), this (for anonymous methods that capture nothing
1477 and happen to live side-by-side with the current method body) or a
1478 more complicated expression if the method has a CaptureContext.
1480 (EmitContext.EmitTopBlock): Routine that drives the emission of
1481 code: it will first resolve the top block, then emit any metadata
1482 and then emit the code. The split is done so that we can extract
1483 any anonymous methods and flag any captured variables/parameters.
1485 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
1486 during this phase, the ILGenerator should not be used as labels
1487 and local variables declared here might not be accessible to any
1488 code that is part of an anonymous method.
1490 Exceptions to this include the temporary variables that are
1491 created by some statements internally for holding temporary
1494 (EmitContext.EmitMeta): New routine, in charge of emitting all the
1497 (EmitContext.TemporaryReturn): This method is typically called
1498 from the Emit phase, and its the only place where we allow the
1499 ReturnLabel to be defined other than the EmitMeta. The reason is
1500 that otherwise we would have to duplicate a lot of logic in the
1501 Resolve phases of various methods that today is on the Emit
1504 (EmitContext.NeedReturnLabel): This no longer creates the label,
1505 as the ILGenerator is not valid during the resolve phase.
1507 (EmitContext.EmitThis): Extended the knowledge in this class to
1508 work in anonymous methods in addition to iterators.
1510 (EmitContext.EmitCapturedVariableInstance): This emits whatever
1511 code is necessary on the stack to access the instance to a local
1512 variable (the variable will be accessed as a field).
1514 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
1515 EmitContext.EmitAddressOfParameter): Routines to support
1516 parameters (not completed at this point).
1518 Removals: Removed RemapLocal and RemapLocalLValue. We probably
1519 will also remove the parameters.
1521 * convert.cs (Convert): Define a `ConstantEC' which points to a
1522 null. This is just to prefity some code that uses
1523 ImplicitStandardConversion code and do not have an EmitContext
1526 The idea is to flag explicitly that at that point in time, it is
1527 known that the conversion will not trigger the delegate checking
1528 code in implicit conversions (which requires a valid
1531 Everywhere: pass new EmitContext parameter since
1532 ImplicitStandardConversionExists now requires it to check for
1533 anonymous method conversions.
1535 (Convert.ImplicitStandardConversionExists): If the type of an
1536 expression is the anonymous_method_type, and the type is a
1537 delegate, we invoke the AnonymousMethod.Compatible method to check
1538 whether an implicit conversion is possible.
1540 (Convert.ImplicitConversionStandard): Only do implicit method
1541 group conversions if the language level is not ISO_1.
1543 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
1544 MethodInfo for the Invoke method. used by Delegate and
1547 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
1548 method conversions if the target type is a delegate.
1550 Removed extra debugging nops.
1552 (LocalVariableReference): Turn the `local_info' into a public
1555 Add `prepared' field, the same hack used for FieldExprs to cope
1556 with composed assignments, as Local variables do not necessarily
1557 operate purely on the stack as they used to: they can be captured
1560 Add `temp' for a temporary result, like fields.
1562 Refactor DoResolve and DoResolveLValue into DoResolveBase.
1564 It now copes with Local variables that are captured and emits the
1565 proper instance variable to load it from a field in the captured
1568 (ParameterReference.DoResolveBase): During the resolve phase,
1569 capture parameters if we are in an anonymous method.
1571 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
1572 anonymous method, use the EmitContext helper routines to emit the
1573 parameter reference.
1575 * iterators.cs: Set RemapToProxy to true/false during the
1578 * parameters.cs (GetParameterByName): New helper method.
1580 * typemanager.cs (anonymous_method_type) a new type that
1581 represents an anonyous method. This is always an internal type,
1582 used as a fencepost to test against the anonymous-methodness of an
1585 2004-10-20 Marek Safar <marek.safar@seznam.cz>
1587 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
1589 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
1591 2004-10-18 Martin Baulig <martin@ximian.com>
1593 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
1594 `Type' directly, but call ResolveType() on it.
1595 (Catch.Resolve): Likewise.
1596 (Foreach.Resolve): Likewise.
1598 2004-10-18 Martin Baulig <martin@ximian.com>
1600 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
1601 `Type' directly, but call ResolveType() on it.
1602 (Probe.DoResolve): Likewise.
1603 (ArrayCreation.LookupType): Likewise.
1604 (TypeOf.DoResolve): Likewise.
1605 (SizeOf.DoResolve): Likewise.
1607 2004-10-18 Martin Baulig <martin@ximian.com>
1609 * expression.cs (Invocation.BetterFunction): Put back
1610 TypeManager.TypeToCoreType().
1612 2004-10-18 Raja R Harinath <rharinath@novell.com>
1614 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
1617 2004-10-18 Martin Baulig <martin@ximian.com>
1619 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
1620 `Type' directly, but call ResolveType() on it.
1622 2004-10-18 Martin Baulig <martin@ximian.com>
1624 * class.cs (FieldMember.Define): Don't access the TypeExpr's
1625 `Type' directly, but call ResolveType() on it.
1626 (MemberBase.DoDefine): Likewise.
1628 * expression.cs (New.DoResolve): Don't access the TypeExpr's
1629 `Type' directly, but call ResolveType() on it.
1630 (ComposedCast.DoResolveAsTypeStep): Likewise.
1632 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
1633 `Type' directly, but call ResolveType() on it.
1635 2004-10-17 John Luke <john.luke@gmail.com>
1637 * class.cs (Operator.GetSignatureForError): use CSharpName
1639 * parameter.cs (Parameter.GetSignatureForError): Returns
1640 correct name even if was not defined.
1642 2004-10-13 Raja R Harinath <rharinath@novell.com>
1645 * class.cs (TypeContainer.EmitContext): New property.
1646 (DefineNestedTypes): Create an emitcontext for each part.
1647 (MethodCore.DoDefineParameters): Use container's emitcontext.
1648 Pass type array to InternalParameters.
1649 (MemberBase.DoDefine): Use container's emitcontext.
1650 (FieldMember.Define): Likewise.
1651 (Event.Define): Likewise.
1652 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1653 Pass type array to InternalParameters.
1654 (SetIndexerMethod.GetParameterInfo): Likewise.
1655 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1656 * delegate.cs (Define): Pass emitcontext to
1657 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1658 array to InternalParameters.
1659 * expression.cs (ParameterReference.DoResolveBase): Pass
1660 emitcontext to GetParameterInfo.
1661 (ComposedCast.DoResolveAsTypeStep): Remove check on
1662 ec.ResolvingTypeTree.
1663 * parameter.cs (Parameter.Resolve): Change argument to
1664 EmitContext. Use ResolveAsTypeTerminal.
1665 (Parameter.GetSignature): Change argument to EmitContext.
1666 (Parameters.ComputeSignature): Likewise.
1667 (Parameters.ComputeParameterTypes): Likewise.
1668 (Parameters.GetParameterInfo): Likewise.
1669 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1670 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1671 * support.cs (InternalParameters..ctor): Remove variant that takes
1673 * typemanager.cs (system_intptr_expr): New.
1674 (InitExpressionTypes): Initialize it.
1676 2004-10-12 Chris Toshok <toshok@ximian.com>
1678 * cs-parser.jay: fix location for try_statement and catch_clause.
1680 2004-10-11 Martin Baulig <martin@ximian.com>
1682 * report.cs: Don't make --fatal abort on warnings, we have
1683 -warnaserror for that.
1685 2004-10-07 Raja R Harinath <rharinath@novell.com>
1687 More DeclSpace.ResolveType avoidance.
1688 * decl.cs (MemberCore.InUnsafe): New property.
1689 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
1690 with newly created EmitContext.
1691 (FieldMember.Define): Likewise.
1692 * delegate.cs (Delegate.Define): Likewise.
1693 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
1694 only if normal name-lookup fails.
1695 (TypeExpr.DoResolve): Enable error-checking.
1696 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
1697 (SizeOf.DoResolve): Likewise.
1698 (ComposedCast.DoResolveAsTypeStep): Likewise.
1699 (StackAlloc.DoResolve): Likewise.
1700 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
1701 (Block.Unsafe): New property.
1702 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
1703 (Unsafe): Set 'unsafe' flag of contained block.
1704 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
1705 (Fixed.Resolve): Likewise.
1706 (Catch.Resolve): Likewise.
1707 (Using.ResolveLocalVariableDecls): Likewise.
1708 (Foreach.Resolve): Likewise.
1710 2004-10-05 John Luke <john.luke@gmail.com>
1712 * cs-parser.jay: add location to error CS0175
1714 2004-10-04 Miguel de Icaza <miguel@ximian.com>
1716 * ecore.cs (Expression.Constantity): Add support for turning null
1719 * const.cs (Const.Define): Allow constants to be reference types
1720 as long as the value is Null.
1722 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
1724 * namespace.cs (NamespaceEntry.Using): No matter which warning
1725 level is set, check if this namespace name has already been added.
1727 2004-10-03 Ben Maurer <bmaurer@ximian.com>
1729 * expression.cs: reftype [!=]= null should always use br[true,false].
1732 2004-10-03 Marek Safar <marek.safar@seznam.cz>
1735 * attribute.cs: Enum conversion moved to
1736 GetAttributeArgumentExpression to be applied to the all
1739 2004-10-01 Raja R Harinath <rharinath@novell.com>
1741 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
1742 * class.c (TypeContainer.DefineType): Flag error if
1743 base types aren't accessible due to access permissions.
1744 * decl.cs (DeclSpace.ResolveType): Move logic to
1745 Expression.ResolveAsTypeTerminal.
1746 (DeclSpace.ResolveTypeExpr): Thin layer over
1747 Expression.ResolveAsTypeTerminal.
1748 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
1749 Refactor code into NestedAccess. Use it.
1750 (DeclSpace.NestedAccess): New.
1751 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
1752 argument to silence errors. Check access permissions.
1753 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
1754 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
1755 (Cast.DoResolve): Likewise.
1756 (New.DoResolve): Likewise.
1757 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
1758 (TypeOf.DoResolve): Likewise.
1760 * expression.cs (Invocation.BetterConversion): Return the Type of
1761 the better conversion. Implement section 14.4.2.3 more faithfully.
1762 (Invocation.BetterFunction): Make boolean. Make correspondence to
1763 section 14.4.2.2 explicit.
1764 (Invocation.OverloadResolve): Update.
1765 (Invocation): Remove is_base field.
1766 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
1767 (Invocation.Emit): Likewise.
1769 2004-09-27 Raja R Harinath <rharinath@novell.com>
1771 * README: Update to changes.
1773 2004-09-24 Marek Safar <marek.safar@seznam.cz>
1775 * cs-parser.jay: Reverted 642 warning fix.
1777 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1780 * decl.cs (FindMemberWithSameName): Indexer can have more than
1783 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1785 * expression.cs (LocalVariableReference.DoResolveLValue):
1786 Do not report warning 219 for out values.
1787 (EmptyExpression.Null): New member to avoid extra allocations.
1789 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1791 * cs-parser.jay: Fix wrong warning 642 report.
1793 * cs-tokenizer.cs (CheckNextToken): New helper;
1794 Inspect next character if is same as expected.
1796 2004-09-23 Martin Baulig <martin@ximian.com>
1798 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1799 (Convert.ImplicitReferenceConversionExists): Likewise.
1801 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1803 * class.cs (Operator.Define): Add error 448 and 559 report.
1805 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1807 * class.cs (MemberBase.IsTypePermitted): New protected
1808 method for checking error CS0610.
1810 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1812 * class.cs (TypeContainer.HasExplicitLayout): New property
1813 Returns whether container has StructLayout attribute set Explicit.
1814 (FieldMember): New abstract class for consts and fields.
1815 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1816 (Field): Reuse FieldMember.
1818 * const.cs (Const): Reuse FieldMember.
1820 * rootcontext.cs: EmitConstants call moved to class.
1822 2004-09-22 Martin Baulig <martin@ximian.com>
1824 Thanks to Peter Sestoft for this bug report.
1826 * expression.cs (Conditional): If both the `trueExpr' and the
1827 `falseExpr' is a NullLiteral, return a NullLiteral.
1829 2004-09-22 Martin Baulig <martin@ximian.com>
1831 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1832 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1833 for the "get_Current" call.
1835 2004-09-22 Martin Baulig <martin@ximian.com>
1837 Marek and me just fixed one of our oldest bugs: #28562 :-)
1839 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1841 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1842 we're an EnumConstant, just return that.
1843 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1844 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1845 to get the value which'll actually be written into the attribute.
1846 However, we have to use GetValue() to access the attribute's value
1849 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1851 * constant.cs (Constant.IsNegative): New abstract property
1854 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1855 (StackAlloc.DoResolve): Reused IsNegative.
1857 2004-09-21 Martin Baulig <martin@ximian.com>
1859 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
1860 if we're used in an iterator, we may be called from different
1863 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
1864 we actually have an exception block.
1866 2004-09-20 John Luke <jluke@cfl.rr.com>
1868 * class.cs, cs-parser.jay: Improve the error report for 1520:
1869 report the actual line where the error happens, not where the
1872 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
1873 Pass location information that was available elsewhere.
1875 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
1877 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
1878 runtime to delay sign assemblies.
1880 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1882 * cs-parser.jay: Do not report the stack trace, this is barely
1885 2004-08-22 John Luke <john.luke@gmail.com>
1887 * driver.cs : check that a resource id is not already used
1888 before adding it, report CS1508 if it is, bug #63637
1890 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1892 * ecore.cs: Removed dead code.
1894 2004-09-18 Marek Safar <marek.safar@seznam.cz>
1896 * class.cs: Do not report warning CS0067 on the interfaces.
1898 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1900 * cs-parser.jay: Add error 504 report.
1902 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1904 * rootcontext.cs: WarningLevel is 4 by default now.
1906 * statement.cs (Fixed.Resolve): Do not null
1909 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1912 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
1913 deep search when property is not virtual.
1914 (PropertyExpr.ResolveAccessors): Make one call for both
1917 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1920 * statement.cs: Error 152 report constains also location.
1922 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1925 * const.cs: Explicitly set constant as static.
1927 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1930 * cs-parser.jay: Add error 1017 report.
1932 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1934 Fixed bug #59980, #64224
1935 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
1937 * typemanager.cs (IsSpecialMethod): Simplified
1939 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1941 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
1942 condition with better params.
1944 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1947 * attribute.cs (Resolve): Property has to have both
1950 2004-09-14 Martin Baulig <martin@ximian.com>
1952 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1954 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1957 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1958 called and is obsolete then this member suppress message
1959 when call is inside next [Obsolete] method or type.
1961 * expression.cs: Use TestObsoleteMethodUsage member.
1963 2004-09-14 Martin Baulig <martin@ximian.com>
1965 * cs-parser.jay: Sync a bit with the GMCS version.
1967 2004-09-14 Martin Baulig <martin@ximian.com>
1969 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
1970 (CSharpParser.yacc_verbose_flag): New public field.
1972 * genericparser.cs: Removed.
1974 2004-09-14 Raja R Harinath <rharinath@novell.com>
1976 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
1978 2004-09-13 Marek Safar <marek.safar@seznam.cz>
1980 * class.cs (MethodCore.CheckBase): Fix bug #65757.
1982 2004-09-10 Martin Baulig <martin@ximian.com>
1984 Backported my MemberName changes from GMCS into MCS.
1986 - we are now using a special `MemberName' class instead of using
1987 strings; in GMCS, the `MemberName' also contains the type
1990 - changed the grammar rules a bit:
1991 * the old `member_name' is now a `namespace_or_type_name':
1992 The rule is that we use `namespace_or_type_name' everywhere
1993 where we expect either a "member name" (GetEnumerator) or a
1994 "member name" with an explicit interface name
1995 (IEnumerable.GetEnumerator).
1996 In GMCS, the explicit interface name may include type arguments
1997 (IEnumerable<T>.GetEnumerator).
1998 * we use `member_name' instead of just `IDENTIFIER' for
2000 The rule is that we use `member_name' wherever a member may
2001 have type parameters in GMCS.
2003 * decl.cs (MemberName): New public class.
2004 (MemberCore.MemberName): New public readonly field.
2005 (MemberCore.ctor): Take a `MemberName' argument, not a string.
2006 (DeclSpace): Likewise.
2008 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
2009 * enum.cs (Enum.ctor): Likewise.
2011 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
2013 (AliasEntry.ctor): Take a MemberName, not an Expression.
2014 (AliasEntry.UsingAlias): Likewise.
2016 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
2017 (IMethodData.MemberName): Changed type from string to MemberName.
2018 (MemberBase.ExplicitInterfaceName): Likewise.
2019 (AbstractPropertyEventMethod.SetupName): Make this private.
2020 (AbstractPropertyEventMethod.ctor): Added `string prefix'
2021 argument; compute the member name here.
2022 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
2023 on the `member.MemberName' and the `prefix'.
2025 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
2027 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
2028 thus, we get a `MemberName' instead of a `string'. These
2029 declarations may have type parameters in GMCS.
2030 (interface_method_declaration, delegate_declaration): Likewise.
2031 (class_declaration, interface_declaration): Likewise.
2032 (method_header): Use `namespace_or_type_name' instead of
2033 `member_name'. We may be an explicit interface implementation.
2034 (property_declaration, event_declaration): Likewise.
2035 (member_name): This is now just an `IDENTIFIER', not a
2036 `namespace_or_type_name'.
2037 (type_name, interface_type): Removed.
2038 (namespace_or_type_name): Return a MemberName, not an Expression.
2039 (primary_expression): Use `member_name' instead of `IDENTIFIER';
2040 call GetTypeExpression() on the MemberName to get an expression.
2041 (IndexerDeclaration.interface_type): Changed type from string to
2043 (MakeName): Operate on MemberName's instead of string's.
2045 2004-09-13 Raja R Harinath <rharinath@novell.com>
2048 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
2049 (NamespaceEntry.Lookup): Add new argument to flag if we want the
2050 lookup to avoid symbols introduced by 'using'.
2051 * rootcontext.cs (NamespaceLookup): Update.
2053 2004-09-12 Marek Safar <marek.safar@seznam.cz>
2055 * class.cs (TypeContainer.DoDefineMembers): Do not call
2056 DefineDefaultConstructor for static classes.
2058 2004-09-12 Marek Safar <marek.safar@seznam.cz>
2060 * attribute.cs (Attribute.Resolve): Add error 653 report.
2062 * class.cs (Class.ApplyAttributeBuilder): Add error 641
2064 (Method.ApplyAttributeBuilder): Add error 685 report.
2065 (Operator.Define): Add error 564 report.
2067 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
2069 * expression.cs (Invocation.DoResolve): Add error
2072 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
2075 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2077 * class.cs (ConstructorInitializer.Resolve):
2078 Wrong error number (515->516).
2080 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2082 * class.cs (Indexer.Define): Add error 631 report.
2084 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2086 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
2088 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2090 * expression.cs (Probe.DoResolve): Add error CS0241 report.
2092 2004-09-10 Marek Safar <marek.safar@seznam.cz>
2094 * cs-parser.jay: Added error CS0241 report.
2096 2004-09-10 Raja R Harinath <rharinath@novell.com>
2098 * cs-parser.jay (fixed_statement): Introduce a scope for the
2099 declaration in the 'fixed' statement.
2101 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2103 * cs-parser.jay: Added CS0230 error report.
2105 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2107 * cs-parser.jay: Added errors CS0231 and CS0257 report.
2109 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2111 * expression.cs (Argument.Resolve): Added error CS0192 and
2114 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2116 C# 2.0 #pragma warning feature
2118 * cs-tokenizer.cs (PreProcessPragma): New method;
2119 Handles #pragma directive.
2121 * report.cs (WarningRegions): New class; Support
2122 class for #pragma warning directive. It tests whether
2123 warning is enabled for a given line.
2125 2004-09-08 Miguel de Icaza <miguel@ximian.com>
2127 * const.cs: Add more descriptive error report, tahnks to
2130 2004-09-08 Marek Safar <marek.safar@seznam.cz>
2132 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
2134 2004-09-07 Miguel de Icaza <miguel@ximian.com>
2136 * expression.cs: Apply patch from Ben: Remove dead code from
2137 ArrayCreation, and remove the TurnintoConstant call in const.cs,
2138 as that code just threw an exception anwyays.
2140 * const.cs: Remove the call to the turnintoconstant, for details
2143 * literal.cs: The type of the null-literal is the null type; So
2144 we use a placeholder type (literal.cs:System.Null, defined here)
2147 * expression.cs (Conditional.DoResolve): Remove some old code that
2148 is no longer needed, conversions have been fixed.
2150 (ArrayCreationExpression.DoResolve): Return false if we fail to
2151 resolve the inner expression.
2153 2004-09-07 Raja R Harinath <rharinath@novell.com>
2156 * cs-parser.jay (delegate_declaration): Record a delegate
2157 declaration as a type declaration.
2158 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
2160 2004-09-06 Miguel de Icaza <miguel@ximian.com>
2162 * parameter.cs: Do not crash if the type can not be resolved.
2164 * expression.cs: Report errors with unsafe pointers, fixes #64896
2166 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
2168 * expression.cs: Pointer arith always needs to do a conv.i
2169 if the operand is a long. fix 65320
2171 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2173 Fixed cs0619-37.cs, cs0619-38.cs
2175 * enum.cs (GetObsoleteAttribute): Removed.
2177 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
2178 on Enum member is double staged. The first is tested member
2181 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2183 Fixed #56986, #63631, #65231
2185 * class.cs: (TypeContainer.AddToMemberContainer): New method,
2186 adds member to name container.
2187 (TypeContainer.AddToTypeContainer): New method, adds type to
2189 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
2190 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
2191 AddOperator): Simplified by reusing AddToMemberContainer.
2192 (TypeContainer.UserDefinedStaticConstructor): Changed to property
2194 (Method.CheckForDuplications): Fixed implementation to test all
2196 (MemberBase): Detection whether member is explicit interface
2197 implementation is now in constructor.
2198 (MemberBase.UpdateMemberName): Handles IndexerName.
2199 (Accessor): Changed to keep also location information.
2200 (AbstractPropertyEventMethod): Is derived from MemberCore.
2201 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
2202 will be emited or not.
2203 (PropertyBase.AreAccessorsDuplicateImplementation):
2204 Tests whether accessors are not in collision with some method.
2205 (Operator): Is derived from MethodCore to simplify common
2208 * decl.cs (Flags.TestMethodDuplication): Test for duplication
2210 (DeclSpace.AddToContainer): Adds the member to defined_names
2211 table. It tests for duplications and enclosing name conflicts.
2213 * enum.cs (EnumMember): Clean up to reuse the base structures
2215 2004-09-03 Martin Baulig <martin@ximian.com>
2217 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
2218 into TypeContainer, to make partial classes work again.
2220 2004-09-03 Martin Baulig <martin@ximian.com>
2222 * rootcontext.cs (RootContext.V2): Removed.
2224 2004-03-23 Martin Baulig <martin@ximian.com>
2226 * expression.cs (Invocation.OverloadResolve): Added `bool
2227 may_fail' argument and use it instead of the Location.IsNull() hack.
2229 2004-09-03 Martin Baulig <martin@ximian.com>
2231 Merged latest changes into gmcs. Please keep this comment in
2232 here, it makes it easier for me to see what changed in MCS since
2233 the last time I merged.
2235 2004-09-03 Raja R Harinath <rharinath@novell.com>
2238 * expression.cs (BetterConversion): Don't allow either conversion
2239 to be null. Remove redundant implicit conversion test when 'q ==
2240 null' -- when this function is invoked, we already know that the
2241 implicit conversion exists.
2242 (BetterFunction): Assume that 'best' is non-null. Remove
2243 redundant reimplementation of IsApplicable when 'best' is null.
2244 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
2245 number of arguments.
2246 (IsAncestralType): Extract from OverloadResolve.
2247 (OverloadResolve): Make robust to the MethodGroupExpr being
2248 unsorted. Implement all the logic of Section 14.5.5.1, and
2249 support overloading of methods from multiple applicable types.
2250 Clean up logic somewhat. Don't pass null methods to BetterFunction.
2252 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
2253 (RealError, Warning): Append type of report to related symbol.
2255 2004-09-03 Marek Safar <marek.safar@seznam.cz>
2257 * enum.cs: Fixed CLS-Compliance checks for enum members.
2258 Error tests cs3008-8.cs, cs3014-8.cs
2260 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2262 Fixed bug #62342, #63102
2263 * class.cs: ImplementIndexer uses member.IsExplicitImpl
2264 like ImplementMethod.
2266 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2268 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2271 2004-09-02 Martin Baulig <martin@ximian.com>
2273 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
2274 TypeManager.GetArgumentTypes() rather than calling GetParameters()
2277 2004-09-01 Marek Safar <marek.safar@seznam.cz>
2279 C# 2.0 Static classes implemented
2281 * class.cs (TypeContainer): instance_constructors,
2282 initialized_fields, initialized_static_fields,
2283 default_constructor, base_inteface_types are protected to be
2284 accessible from StaticClass.
2285 (TypeContainer.DefineDefaultConstructor): New virtual method
2286 for custom default constructor generating
2287 (StaticClass): New class to handle "Static classes" feature.
2289 * cs-parser.jay: Handle static keyword on class like instance
2292 * driver.cs: Added "/langversion" command line switch with two
2293 options (iso-1, default).
2295 2004-08-31 Marek Safar <marek.safar@seznam.cz>
2297 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
2299 2004-08-31 Miguel de Icaza <miguel@ximian.com>
2301 * delegate.cs: Style.
2303 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
2305 * delegate.cs: Add seperate instance expr field for miguel.
2307 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2309 * PointerArithmetic (Resolve): make sure we are not doing
2310 pointer arith on void*. Also, make sure we are resolved
2311 by not setting eclass until resolve.
2313 All callers: Make sure that PointerArithmetic gets resolved.
2315 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2317 * ArrayCreation (LookupType): If the type does not resolve
2318 to an array, give an error.
2320 2004-08-27 Marek Safar <marek.safar@seznam.cz>
2322 * statement.cs (Try.Resolve): Fixed bug #64222
2324 2004-08-27 Martin Baulig <martin@ximian.com>
2327 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
2330 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2332 * ecore.cs (Constantify): Get underlying type via
2333 System.Enum.GetUnderlyingType to avoid StackOverflow on the
2334 Windows in special cases.
2336 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2338 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
2339 for obtaining also private methods.
2340 (GetRemoveMethod): Used GetRemoveMethod (true)
2341 for obtaining also private methods.
2343 2004-08-24 Martin Baulig <martin@ximian.com>
2345 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
2346 MethodAttributes.HideBySig for operators.
2348 2004-08-23 Martin Baulig <martin@ximian.com>
2350 Back to the old error reporting system :-)
2352 * report.cs (Message): Removed.
2353 (Report.MessageData, ErrorData, WarningData): Removed.
2354 (Report.Error, Warning): Back to the old system.
2356 2004-08-23 Martin Baulig <martin@ximian.com>
2358 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
2360 * class.cs (TypeContainer.ParentContainer): New public virtual
2361 method; replaces the explicit interface implementation.
2362 (ClassPart.ParentContainer): Override.
2364 2004-08-23 Martin Baulig <martin@ximian.com>
2366 * statement.cs (Switch): Added support for constant switches; see
2367 #59428 or test-285.cs.
2369 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2372 * statement.cs (GetEnumeratorFilter): Removed useless
2373 logic because C# specs is strict. GetEnumerator must be
2376 2004-08-22 Martin Baulig <martin@ximian.com>
2378 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2379 a switch and may break, reset the barrier. Fixes #59867.
2381 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2383 CLS-Compliance speed up (~5% for corlib)
2385 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
2386 New method. Tests container for CLS-Compliant names
2388 * class.cs (TypeContainer.VerifyClsName): New method.
2389 Checks whether container name is CLS Compliant.
2390 (Constructor): Implements IMethodData.
2392 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
2393 low-case table for CLS Compliance test.
2394 (MemberCache.VerifyClsParameterConflict): New method.
2395 Checks method parameters for CS3006 error.
2397 * enum.cs (EnumMember): Is derived from MemberCore.
2398 (Enum.VerifyClsName): Optimized for better performance.
2400 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2402 * report.cs: Renamed Error_T to Error and changed all
2405 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2407 * class.cs (TypeContainer.IndexerArrayList): New inner class
2408 container for indexers.
2409 (TypeContainer.DefaultIndexerName): New constant for default
2410 indexer name. Replaced all "Item" with this constant.
2411 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
2413 * typemanager.cs (TypeManager.default_member_ctor): Cache here
2414 DefaultMemberAttribute constructor.
2416 2004-08-05 Martin Baulig <martin@ximian.com>
2418 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
2421 2004-08-05 Marek Safar <marek.safar@seznam.cz>
2423 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
2424 multi platforms problem.
2426 * compiler.csproj: Included shared files.
2428 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2430 Fix bug 60333, 55971 in the more general way
2431 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2432 Added arg_type argument for constant conversion.
2433 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
2435 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2438 * class.cs (TypeContainer ): New inner classes MethodArrayList,
2439 OperatorArrayList, MethodCoreArrayList for typecontainer
2440 containers. Changed class member types to these new types.
2441 (MethodArrayList.DefineMembers): Added test for CS0659.
2443 2004-08-04 Miguel de Icaza <miguel@ximian.com>
2445 * cfold.cs: Synchronize the folding with the code in expression.cs
2446 Binary.DoNumericPromotions for uint operands.
2448 * attribute.cs: Revert patch from Raja, it introduced a regression
2449 while building Blam-1.2.1 (hard to isolate a test case).
2451 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2455 (TypeContainer.Define): Renamed to DefineContainerMembers because of
2457 (MethodCore.parent_method): New member. The method we're overriding
2458 if this is an override method.
2459 (MethodCore.CheckBase): Moved from Method class and made common.
2460 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
2462 (MethodCore.CheckForDuplications): New abstract method. For custom
2463 member duplication search in a container
2464 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
2465 method and its return type.
2466 (Event.conflict_symbol): New member. Symbol with same name in the
2470 (MemberCache.FindMemberWithSameName): New method. The method
2471 is looking for conflict with inherited symbols.
2473 2004-08-04 Martin Baulig <martin@ximian.com>
2475 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
2477 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
2479 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2481 * report.cs (Message): New enum for better error, warning reference in
2483 (MessageData): New inner abstract class. It generally handles printing of
2484 error and warning messages.
2485 Removed unused Error, Warning, Message methods.
2487 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2489 Fix for cs0592-8.cs test
2491 (Attributable.ValidAttributeTargets): Made public.
2492 (Attribute.ExplicitTarget): New member for explicit target value.
2493 (Attribute.CheckTargets): Now we translate explicit attribute
2494 target to Target here.
2496 2004-08-03 Ben Maurer <bmaurer@ximian.com>
2498 * ecore.cs (MethodGroupExpr): new IsBase property.
2500 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
2502 * delegate.cs (DelegateCreation): store a MethodGroupExpr
2503 rather than an instance expr.
2505 (DelegateCreation.Emit): Use the method group rather than
2506 the instance expression. Also, if you have base.Foo as the
2507 method for a delegate, make sure to emit ldftn, not ldftnvirt.
2509 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
2511 (NewDelegate.DoResolve): Only check for the existance of Invoke
2512 if the method is going to be needed. Use MethodGroupExpr.
2514 (NewDelegate.Emit): Remove, DelegateCreation implements this.
2516 * expression.cs: For pointer arith., make sure to use
2517 the size of the type, not the size of the pointer to
2520 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2523 * class.cs (Class): Added error CS0502 test.
2525 2004-08-03 John Luke <jluke@cfl.rr.com>
2526 Raja R Harinath <rharinath@novell.com>
2529 * attribute.cs (Attribute.complained_before): New flag.
2530 (Attribute.ResolveType, Attribute.Resolve),
2531 (Attribute.DefinePInvokeMethod): Set it.
2532 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
2534 2004-08-03 Martin Baulig <martin@ximian.com>
2536 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
2537 use a user-defined operator; we still need to do numeric
2538 promotions in case one argument is a builtin type and the other
2539 one has an implicit conversion to that type. Fixes #62322.
2541 2004-08-02 Martin Baulig <martin@ximian.com>
2543 * statement.cs (LocalInfo.Flags): Added `IsThis'.
2544 (LocalInfo.IsThis): New public property.
2545 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
2547 2004-08-01 Martin Baulig <martin@ximian.com>
2549 * class.cs (TypeContainer.GetClassBases): Don't set the default
2550 here since we may get called from GetPartialBases().
2551 (TypeContainer.DefineType): If GetClassBases() didn't return a
2552 parent, use the default one.
2554 2004-07-30 Duncan Mak <duncan@ximian.com>
2556 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
2558 2004-07-30 Martin Baulig <martin@ximian.com>
2560 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
2562 * class.cs (SourceMethod): New public class, derive from the
2563 symbol writer's ISourceMethod.
2564 (Method): Use the new symbol writer API.
2566 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
2567 as argument and use the new symbol writer.
2570 (SourceFile): Implement the symbol writer's ISourceFile.
2571 (Location.SymbolDocument): Removed.
2572 (Location.SourceFile): New public property.
2574 * symbolwriter.cs: Use the new symbol writer API.
2576 2004-07-30 Raja R Harinath <rharinath@novell.com>
2578 * Makefile (install-local): Remove. Functionality moved to
2581 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
2583 * Makefile: Install mcs.exe.config file together with mcs.exe.
2584 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
2585 correct runtime version.
2587 2004-07-25 Martin Baulig <martin@ximian.com>
2590 (TypeContainer.RegisterOrder): Removed, this was unused.
2591 (TypeContainer, interface_order): Removed.
2592 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
2593 TypeContainer as argument since we can also be called with a
2594 `PartialContainer' for a partial class/struct/interface.
2595 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
2596 of checking whether we're an `Interface' - we could be a
2598 (PartialContainer.Register): Override; call
2599 AddClass()/AddStruct()/AddInterface() on our parent.
2601 * cs-parser.jay (interface_member_declaration): Add things to the
2602 `current_container', not the `current_class'.
2604 * rootcontext.cs (RegisterOrder): The overloaded version which
2605 takes an `Interface' was unused, removed.
2607 * typemanager.cs (TypeManager.LookupInterface): Return a
2608 `TypeContainer', not an `Interface'.
2609 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
2610 contain a `PartialContainer' for an interface, so check it's
2611 `Kind' to figure out what it is.
2613 2004-07-25 Martin Baulig <martin@ximian.com>
2615 * class.cs (Class.DefaultTypeAttributes): New public constant.
2616 (Struct.DefaultTypeAttributes): Likewise.
2617 (Interface.DefaultTypeAttributes): Likewise.
2618 (PartialContainer.TypeAttr): Override this and add the
2619 DefaultTypeAttributes.
2621 2004-07-25 Martin Baulig <martin@ximian.com>
2623 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
2624 we can just use the `Parent' field instead.
2626 2004-07-25 Martin Baulig <martin@ximian.com>
2628 * class.cs (TypeContainer.Emit): Renamed to EmitType().
2630 2004-07-25 Martin Baulig <martin@ximian.com>
2632 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
2633 our parts before defining any methods.
2634 (TypeContainer.VerifyImplements): Make this virtual.
2635 (ClassPart.VerifyImplements): Override and call VerifyImplements()
2636 on our PartialContainer.
2638 2004-07-25 Martin Baulig <martin@ximian.com>
2640 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
2642 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
2643 argument, we can just use the `Parent' field instead.
2646 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
2647 (MemberBase.DoDefine): Likewise.
2649 2004-07-24 Martin Baulig <martin@ximian.com>
2651 * decl.cs (MemberCore.Parent): New public field.
2652 (DeclSpace.Parent): Moved to MemberCore.
2654 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
2655 (MemberBase.ctor): Added TypeContainer argument, pass it to our
2657 (FieldBase, Field, Operator): Likewise.
2658 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
2659 (EventField, Event): Likewise.
2661 2004-07-23 Martin Baulig <martin@ximian.com>
2663 * class.cs (PartialContainer): New public class.
2664 (ClassPart): New public class.
2665 (TypeContainer): Added support for partial classes.
2666 (TypeContainer.GetClassBases): Splitted some of the functionality
2667 out into GetNormalBases() and GetPartialBases().
2669 * cs-tokenizer.cs (Token.PARTIAL): New token.
2670 (Tokenizer.consume_identifier): Added some hacks to recognize
2671 `partial', but only if it's immediately followed by `class',
2672 `struct' or `interface'.
2674 * cs-parser.jay: Added support for partial clases.
2676 2004-07-23 Martin Baulig <martin@ximian.com>
2678 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2679 a `DeclSpace' and also made it readonly.
2680 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2681 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2682 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2684 * cs-parser.jay: Pass the `current_class', not the
2685 `current_container' (at the moment, this is still the same thing)
2686 to a new Method, Property, Event, Indexer or Constructor.
2688 2004-07-23 Martin Baulig <martin@ximian.com>
2690 * cs-parser.jay (CSharpParser): Added a new `current_class' field
2691 and removed the `current_interface' one.
2692 (struct_declaration, class_declaration, interface_declaration):
2693 Set `current_class' to the newly created class/struct/interface;
2694 set their `Bases' and call Register() before parsing their body.
2696 2004-07-23 Martin Baulig <martin@ximian.com>
2698 * class.cs (Kind): New public enum.
2699 (TypeContainer): Made this class abstract.
2700 (TypeContainer.Kind): New public readonly field.
2701 (TypeContainer.CheckDef): New public method; moved here from
2703 (TypeContainer.Register): New public abstract method.
2704 (TypeContainer.GetPendingImplementations): New public abstract
2706 (TypeContainer.GetClassBases): Removed the `is_class' and
2707 `is_iface' parameters.
2708 (TypeContainer.DefineNestedTypes): Formerly known as
2710 (ClassOrStruct): Made this class abstract.
2712 * tree.cs (RootTypes): New public type.
2714 2004-07-20 Martin Baulig <martin@ximian.com>
2716 * tree.cs (Tree.RecordNamespace): Removed.
2717 (Tree.Namespaces): Removed.
2719 * rootcontext.cs (RootContext.IsNamespace): Removed.
2721 * cs-parser.jay (namespace_declaration): Just create a new
2722 NamespaceEntry here.
2724 2004-07-20 Martin Baulig <martin@ximian.com>
2726 * statement.cs (ExceptionStatement): New abstract class. This is
2727 now used as a base class for everyone who's using `finally'.
2728 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
2729 our local variables before using them.
2731 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
2732 virtual method. This is used by Yield.Resolve() to "steal" an
2733 outer block's `finally' clauses.
2734 (FlowBranchingException): The .ctor now takes an ExceptionStatement
2737 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
2738 version which takes an ExceptionStatement. This version must be
2739 used to create exception branchings.
2742 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
2743 (Iterator.EmitMoveNext): Added exception support; protect the
2744 block with a `fault' clause, properly handle 'finally' clauses.
2745 (Iterator.EmitDispose): Run all the `finally' clauses here.
2747 2004-07-20 Martin Baulig <martin@ximian.com>
2749 * iterator.cs: This is the first of a set of changes in the
2750 iterator code. Match the spec more closely: if we're an
2751 IEnumerable, then GetEnumerator() must be called. The first time
2752 GetEnumerator() is called, it returns the current instance; all
2753 subsequent invocations (if any) must create a copy.
2755 2004-07-19 Miguel de Icaza <miguel@ximian.com>
2757 * expression.cs: Resolve the constant expression before returning
2760 2004-07-19 Martin Baulig <martin@ximian.com>
2762 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
2763 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
2764 the return type of the new EmitContext.
2766 2004-07-18 Martin Baulig <martin@ximian.com>
2768 * class.cs (Property.Define): Fix iterators.
2770 * iterators.cs (Iterator.Define): Moved the
2771 `container.AddInterator (this)' call here from the .ctor; only do
2772 it if we resolved successfully.
2774 2004-07-17 Miguel de Icaza <miguel@ximian.com>
2776 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
2777 `true' for preprocessing directives that we parse. The return
2778 value indicates whether we should return to regular tokenizing or
2779 not, not whether it was parsed successfully.
2781 In the past if we were in: #if false ... #line #endif, we would
2782 resume parsing after `#line'. See bug 61604.
2784 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
2785 building: IsEnumType should return true only for enums, not for
2786 enums or System.Enum itself. This fixes #61593.
2788 Likely what happened is that corlib was wrong: mcs depended on
2789 this bug in some places. The bug got fixed, we had to add the
2790 hack, which caused bug 61593.
2792 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
2793 that was a workaround for the older conditions.
2795 2004-07-16 Ben Maurer <bmaurer@ximian.com>
2797 * assign.cs: IAssignMethod has a new interface, as documented
2798 inline. All assignment code now uses this new api.
2800 * ecore.cs, expression.cs: All classes which implement
2801 IAssignMethod now use the new interface.
2803 * expression.cs (Invocation): add a hack to EmitCall so that
2804 IndexerAccess can be the target of a compound assignment without
2805 evaluating its arguments twice.
2807 * statement.cs: Handle changes in Invocation api.
2809 2004-07-16 Martin Baulig <martin@ximian.com>
2811 * iterators.cs: Rewrote this. We're now using one single Proxy
2812 class for both the IEnumerable and the IEnumerator interface and
2813 `Iterator' derives from Class so we can use the high-level API.
2815 * class.cs (TypeContainer.AddIterator): New method.
2816 (TypeContainer.DoDefineType): New protected virtual method, which
2817 is called from DefineType().
2818 (TypeContainer.DoDefineMembers): Call DefineType() and
2819 DefineMembers() on all our iterators.
2820 (TypeContainer.Emit): Call Emit() on all our iterators.
2821 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2823 * codegen.cs (EmitContext.CurrentIterator): New public field.
2825 2004-07-15 Martin Baulig <martin@ximian.com>
2828 (TypeManager.not_supported_exception_type): New type.
2830 2004-07-14 Martin Baulig <martin@ximian.com>
2832 * iterators.cs: Use real error numbers.
2834 2004-07-14 Martin Baulig <martin@ximian.com>
2836 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2837 requires this to be a System.Collection.IEnumerable and not a
2838 class implementing that interface.
2839 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2841 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2843 * class.cs: Fixed previous fix, it broke some error tests.
2845 2004-07-12 Martin Baulig <martin@ximian.com>
2847 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2850 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2852 * assign.cs (LocalTemporary): Add new argument: is_address,If
2853 `is_address' is true, then the value that we store is the address
2854 to the real value, and not the value itself.
2856 * ecore.cs (PropertyExpr): use the new local temporary
2857 stuff to allow us to handle X.Y += z (where X is a struct)
2859 2004-07-08 Martin Baulig <martin@ximian.com>
2861 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2862 not always return, just like we're doing in Using.Resolve().
2864 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2866 * cs-parser.jay (fixed_statement): flag this as Pinned.
2868 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2870 * typemanager.cs (TypeManager): Removed MakePinned method, this
2871 mechanism is replaced with the .NET 2.x compatible mechanism of
2872 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2874 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2875 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2876 `IsFixed' property which has a different meaning.
2878 2004-07-02 Raja R Harinath <rharinath@novell.com>
2880 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2881 visible from inside a nested class, not just the names of the
2882 immediately enclosing class.
2885 2004-06-24 Raja R Harinath <rharinath@novell.com>
2887 * expression.cs (BetterConversion): Remove buggy special-case
2888 handling of "implicit constant expression conversions". At this
2889 point, we already know that the conversion is possible -- we're
2890 only checking to see which is better.
2892 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2894 * cs-parser.jay: Added error CS0210 test.
2896 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2898 * cs-parser.jay: Added error CS0134 test.
2900 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2903 * cs-parser.jay: Added error CS0145 test.
2905 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2907 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2909 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2911 * expression.cs (StackAlloc.Resolve): The argument may not
2912 be a constant; deal with this case.
2914 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2916 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2917 GetIndexerAttributeValue.
2918 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2920 * class.cs (Indexer.Define): Added error tests for CS0415,
2923 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2925 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2928 2004-06-23 Martin Baulig <martin@ximian.com>
2930 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2931 neither return nor throw, reset the barrier as well. Fixes #60457.
2933 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2935 * class.cs : EventAttributes is now set to None by default.
2936 This fixes bug #60459.
2938 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2941 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2942 Don't throw exception but return null (it's sufficient now).
2944 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2946 * typemanager.cs (GetArgumentTypes): Faster implementation.
2948 2004-06-18 Martin Baulig <martin@ximian.com>
2950 * attribute.cs (Attribute.Resolve): Check whether we're an
2951 EmptyCast which a Constant child. Fixes #60333.
2953 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2955 * statement.cs (EmitCollectionForeach): Account for the fact that
2956 not all valuetypes are in areas which we can take the address of.
2957 For these variables, we store to a temporary variable. Also, make
2958 sure that we dont emit a `callvirt' on a valuetype method.
2960 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2962 * expression.cs (StackAlloc.DoReSolve): Added test for
2963 negative parameter (CS0247).
2965 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2968 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2970 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2973 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2976 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2978 Fix bug #58254 & cs1555.cs, cs1556.cs
2979 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2981 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2983 * cs-parser.jay: Added error CS1669 test for indexers.
2985 2004-06-11 Martin Baulig <martin@ximian.com>
2987 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2988 call this twice: for params and varargs methods.
2990 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2993 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2995 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2997 * attribute.cs (Attribute.GetValidTargets): Made public.
3000 (AbstractPropertyEventMethod): New class for better code sharing.
3001 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
3003 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
3005 2004-06-11 Raja R Harinath <rharinath@novell.com>
3008 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
3009 that the call to Resolve is part of a MemberAccess.
3010 (Expression.Resolve): Use it for SimpleName resolution.
3011 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
3012 Add 'intermediate' boolean argument.
3013 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
3014 error message when the SimpleName can be resolved ambiguously
3015 between an expression and a type.
3016 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
3018 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
3019 call on the left-side.
3021 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3024 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
3026 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3028 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
3030 2004-06-11 Martin Baulig <martin@ximian.com>
3032 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
3033 varargs methods if applicable.
3035 2004-06-11 Martin Baulig <martin@ximian.com>
3037 * expression.cs (Invocation.EmitCall): Don't use
3038 `method.CallingConvention == CallingConventions.VarArgs' since the
3039 method could also have `CallingConventions.HasThis'.
3041 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3043 * class.cs (Event.GetSignatureForError): Implemented.
3044 Fixed crash in error test cs3010.cs
3046 2004-06-10 Miguel de Icaza <miguel@ximian.com>
3048 * cs-tokenizer.cs: Change the way we track __arglist to be
3049 consistent with the other keywords.
3051 2004-06-09 Miguel de Icaza <miguel@ximian.com>
3053 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
3056 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
3058 * codegen.cs: Check that all referenced assemblies have a strongname
3059 before strongnaming the compiled assembly. If not report error CS1577.
3060 Fix bug #56563. Patch by Jackson Harper.
3061 * typemanager.cs: Added a method to return all referenced assemblies.
3062 Fix bug #56563. Patch by Jackson Harper.
3064 2004-06-08 Marek Safar <marek.safar@seznam.cz>
3067 (Method.ApplyAttributeBuilder): Moved and added conditional
3068 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
3071 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
3073 2004-06-08 Marek Safar <marek.safar@seznam.cz>
3076 * class.cs: (EventField.attribute_targets): Changed default target.
3078 2004-06-08 Martin Baulig <martin@ximian.com>
3080 * expression.cs (Invocation.EmitCall): Enable varargs methods.
3082 2004-06-08 Martin Baulig <martin@ximian.com>
3084 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
3086 2004-06-07 Martin Baulig <martin@ximian.com>
3088 Added support for varargs methods.
3090 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
3093 * cs-parser.jay: Added support for `__arglist'.
3095 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
3097 * expression.cs (Argument.AType): Added `ArgList'.
3098 (Invocation): Added support for varargs methods.
3099 (ArglistAccess): New public class.
3100 (Arglist): New public class.
3102 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
3104 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
3105 a method's top-level block if the method has varargs.
3107 * support.cs (ReflectionParameters, InternalParameters): Added
3108 support for varargs methods.
3110 2004-06-07 Miguel de Icaza <miguel@ximian.com>
3112 * class.cs: Provide location in indexer error report.
3114 * driver.cs: Use standard names.
3116 * namespace.cs: Catch the use of using after a namespace has been
3117 declared also on using aliases.
3119 2004-06-03 Raja R Harinath <rharinath@novell.com>
3122 * typemanager.cs (closure_private_ok, closure_invocation_type)
3123 (closure_qualifier_type, closure_invocation_assembly)
3124 (FilterWithClosure): Move to ...
3125 (Closure): New internal nested class.
3126 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
3127 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
3128 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
3129 (MemberLookup, MemberLookupFailed): Use it.
3130 * expression.cs (New.DoResolve): Treat the lookup for the
3131 constructor as being qualified by the 'new'ed type.
3132 (Indexers.GetIndexersForTypeOrInterface): Update.
3134 2004-06-03 Marek Safar <marek.safar@seznam.cz>
3137 (GetConditionalAttributeValue): New method. Returns
3138 condition of ConditionalAttribute.
3139 (SearchMulti): New method. Returns all attributes of type 't'.
3140 Use it when attribute is AllowMultiple = true.
3141 (IsConditionalMethodExcluded): New method.
3144 (Method.IsExcluded): Implemented. Returns true if method has conditional
3145 attribute and the conditions is not defined (method is excluded).
3146 (IMethodData): Extended interface for ConditionalAttribute support.
3147 (PropertyMethod.IsExcluded): Implemented.
3150 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
3153 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
3156 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
3158 * expression.cs (ArrayCreationExpression): Make this just an
3159 `expression'. It can't be a statement, so the code here was
3162 2004-06-02 Marek Safar <marek.safar@seznam.cz>
3165 * typemanager.cs (GetFullNameSignature): New method for
3168 2004-06-02 Marek Safar <marek.safar@seznam.cz>
3171 * class.cs (MemberBase.GetSignatureForError): New virtual method.
3172 Use this method when MethodBuilder is null.
3173 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
3174 Added test for error CS0626 (MONO reports error for this situation).
3175 (IMethodData.GetSignatureForError): Extended interface.
3177 2004-06-01 Marek Safar <marek.safar@seznam.cz>
3180 (AttributeTester.GetObsoleteAttribute): Returns instance of
3181 ObsoleteAttribute when type is obsolete.
3184 (TypeContainer.VerifyObsoleteAttribute): Override.
3185 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
3186 (MethodCode.VerifyObsoleteAttribute): Override.
3187 (MemberBase.VerifyObsoleteAttribute): Override.
3190 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
3191 and report proper error.
3194 Delegate.VerifyObsoleteAttribute): Override.
3197 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
3198 and report proper error.
3199 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
3202 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
3206 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
3207 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
3208 Added test for ObsoleteAttribute.
3211 (Catch): Derived from Statement.
3213 2004-06-01 Marek Safar <marek.safar@seznam.cz>
3215 Fixed bug #59071 & cs0160.cs
3217 * statement.cs (Try.Resolve): Check here whether order of catch
3218 clauses matches their dependencies.
3220 2004-05-31 Miguel de Icaza <miguel@ximian.com>
3222 * Reverted patch to namespace.cs (Use lookuptypedirect). This
3223 caused a regression: #59343. Referencing nested classes from an
3224 assembly stopped working.
3226 2004-05-31 Martin Baulig <martin@ximian.com>
3228 MCS is now frozen for beta 2.
3230 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3232 * convert.cs: add a trivial cache for overload operator resolution.
3234 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3236 * decl.cs: If possible, use lookuptypedirect here. We can only do
3237 this if there is no `.' after the namespace. Avoids using
3238 LookupType, which does lots of slow processing.
3239 (FindNestedType) New method, does what it says :-).
3240 * namespace.cs: use LookupTypeDirect.
3241 * rootcontext.cs: use membercache, if possible.
3242 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
3244 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3247 According to the spec,
3249 In a member access of the form E.I, if E is a single identifier,
3250 and if the meaning of E as a simple-name (§7.5.2) is a constant,
3251 field, property, localvariable, or parameter with the same type as
3252 the meaning of E as a type-name (§3.8), then both possible
3253 meanings of E are permitted.
3255 We did not check that E as a simple-name had the same type as E as
3258 This trivial check gives us 5-7% on bootstrap time.
3260 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3262 * expression.cs (Invocation.OverloadResolve): Avoid the
3263 use of hashtables and boxing here by allocating on demand.
3265 2004-05-30 Martin Baulig <martin@ximian.com>
3267 * rootcontext.cs (RootContext.LookupType): Don't cache things if
3268 we're doing a silent lookup. Don't try to lookup nested types in
3269 TypeManager.object_type (thanks to Ben Maurer).
3271 2004-05-30 Martin Baulig <martin@ximian.com>
3273 Committing a patch from Ben Maurer.
3275 * rootcontext.cs (RootContext.LookupType): Cache negative results.
3277 2004-05-29 Martin Baulig <martin@ximian.com>
3279 * class.cs (IMethodData.ShouldIgnore): New method.
3281 * typemanager.cs (TypeManager.MethodFlags): Don't take a
3282 `Location' argument, we don't need it anywhere. Use
3283 `IMethodData.ShouldIgnore ()' instead of
3284 `MethodData.GetMethodFlags ()'.
3285 (TypeManager.AddMethod): Removed.
3286 (TypeManager.AddMethod2): Renamed to AddMethod.
3288 2004-05-29 Martin Baulig <martin@ximian.com>
3290 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
3292 * convert.cs (Convert.ImplicitReferenceConversion): If we're
3293 converting from a class type S to an interface type and we already
3294 have an object on the stack, don't box it again. Fixes #52578.
3296 2004-05-29 Martin Baulig <martin@ximian.com>
3298 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3299 Added support for `params' parameters. Fixes #59267.
3301 2004-05-29 Martin Baulig <martin@ximian.com>
3303 * literal.cs (NullPointer): Provide a private .ctor which sets
3304 `type' to TypeManager.object_type. Fixes #59048.
3306 2004-05-29 Martin Baulig <martin@ximian.com>
3308 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
3309 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
3311 * ecore.cs (EventExpr.instance_expr): Make the field private.
3313 2004-05-26 Marek Safar <marek.safar@seznam.cz>
3315 Fixed bug #50080 & cs0214-2.cs
3316 * expression.cs (Cast.DoResolve): Check unsafe context here.
3318 * statement.cs (Resolve.DoResolve): Likewise.
3320 2004-05-26 Martin Baulig <martin@ximian.com>
3322 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
3324 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
3325 (RootContext.LookupType): Pass down the `silent' flag.
3327 2004-05-25 Martin Baulig <martin@ximian.com>
3330 (MethodGroupExpr.IdenticalTypeName): New public property.
3331 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
3332 expression actually refers to a type.
3334 2004-05-25 Martin Baulig <martin@ximian.com>
3336 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
3337 for #56176 and made it actually work.
3339 2004-05-25 Martin Baulig <martin@ximian.com>
3341 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
3342 (FieldExpr, PropertyExpr): Override and implement
3343 CacheTemporaries. Fixes #52279.
3345 2004-05-25 Miguel de Icaza <miguel@ximian.com>
3347 * location.cs: In the new compiler listing a file twice is a
3348 warning, not an error.
3350 2004-05-24 Martin Baulig <martin@ximian.com>
3352 * enum.cs (Enum.DefineType): For the `BaseType' to be a
3353 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
3355 2004-05-24 Martin Baulig <martin@ximian.com>
3357 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
3358 walking the `using' list. Fixes #53921.
3360 2004-05-24 Martin Baulig <martin@ximian.com>
3362 * const.cs (Const.LookupConstantValue): Added support for
3363 EmptyCast's; fixes #55251.
3365 2004-05-24 Martin Baulig <martin@ximian.com>
3367 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
3368 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
3369 which does the CS0135 check. The reason is that we first need to
3370 check whether the variable actually exists.
3372 2004-05-24 Martin Baulig <martin@ximian.com>
3374 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
3375 than RootContext.LookupType() to find the explicit interface
3378 2004-05-24 Raja R Harinath <rharinath@novell.com>
3380 * Makefile: Simplify. Use executable.make.
3381 * mcs.exe.sources: New file. List of sources of mcs.exe.
3383 2004-05-24 Anders Carlsson <andersca@gnome.org>
3387 Use the invariant culture when doing String.Compare for CLS case
3390 2004-05-23 Martin Baulig <martin@ximian.com>
3392 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
3393 don't have any dots. Fixes #52622, added cs0246-8.cs.
3395 * namespace.cs (NamespaceEntry.Lookup): Likewise.
3397 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3399 * class.cs (MemberBase.Define): Reuse MemberType member for
3400 resolved type. Other methods can use it too.
3402 2004-05-23 Martin Baulig <martin@ximian.com>
3404 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
3405 the variable also exists in the current block (otherwise, we need
3406 to report a CS0103). Fixes #58670.
3408 2004-05-23 Martin Baulig <martin@ximian.com>
3410 * flowanalysis.cs (Reachability.Reachable): Compute this
3411 on-the-fly rather than storing it as a field.
3413 2004-05-23 Martin Baulig <martin@ximian.com>
3415 * flowanalysis.cs (Reachability.And): Manually compute the
3416 resulting `barrier' from the reachability.
3418 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3421 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
3422 instance of ObsoleteAttribute when symbol is obsolete.
3425 (IMethodData): Extended interface for ObsoleteAttribute support.
3427 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3429 * attribute.cs: Fix bug #55970
3431 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3435 (GetObsoleteAttribute): New method. Creates the instance of
3437 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
3438 ObsoleteAttribute when member is obsolete.
3439 (AttributeTester.Report_ObsoleteMessage): Common method for
3440 Obsolete error/warning reporting.
3443 (TypeContainer.base_classs_type): New member for storing parent type.
3446 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
3447 for this MemberCore.
3449 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3451 * attribute.cs, const.cs: Fix bug #58590
3453 2004-05-21 Martin Baulig <martin@ximian.com>
3455 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
3456 out parameters if the end of the method is unreachable. Fixes
3459 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3461 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
3462 Hari was right, why extra method.
3464 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3466 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
3468 2004-05-20 Martin Baulig <martin@ximian.com>
3470 Merged this back from gmcs to keep the differences to a minumum.
3472 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
3473 instead of a Declspace.
3474 (Attribute.ResolveType): Likewise.
3475 (Attributes.Search): Likewise.
3476 (Attributes.Contains): Likewise.
3477 (Attributes.GetClsCompliantAttribute): Likewise.
3479 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
3481 (MethodData.ApplyAttributes): Take an EmitContext instead of a
3484 2004-05-19 Marek Safar <marek.safar@seznam.cz>
3486 Fix bug #58688 (MCS does not report error when the same attribute
3489 * attribute.cs (Attribute.Emit): Distinction between null and default.
3491 2004-05-19 Raja R Harinath <rharinath@novell.com>
3493 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
3494 of a top-level attribute without an attribute target.
3495 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
3497 (Attribute.Conditional_GetConditionName),
3498 (Attribute.Obsolete_GetObsoleteMessage): Update.
3499 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
3500 part of ScanForIndexerName.
3501 (Attribute.CanIgnoreInvalidAttribute): New function.
3502 (Attribute.ScanForIndexerName): Move to ...
3503 (Attributes.ScanForIndexerName): ... here.
3504 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
3505 (Attributes.Search): New internal variant that can choose not to
3506 complain if types aren't resolved. The original signature now
3508 (Attributes.GetClsCompliantAttribute): Use internal variant, with
3509 complaints suppressed.
3510 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
3511 only if it not useful.
3512 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
3513 top-level for attributes that are shared between the assembly
3514 and a top-level class.
3515 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
3516 * class.cs: Update to reflect changes.
3517 (DefineIndexers): Fuse loops.
3518 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
3519 a couple more variants of attribute names.
3521 2004-05-18 Marek Safar <marek.safar@seznam.cz>
3523 Fix bug #52585 (Implemented explicit attribute declaration)
3526 (Attributable.ValidAttributeTargets): New abstract method. It gets
3527 list of valid attribute targets for explicit target declaration.
3528 (Attribute.Target): It holds target itself.
3529 (AttributeSection): Removed.
3530 (Attribute.CheckTargets): New method. It checks whether attribute
3531 target is valid for the current element.
3534 (EventProperty): New class. For events that are declared like
3535 property (with add and remove accessors).
3536 (EventField): New class. For events that are declared like field.
3539 * cs-parser.jay: Implemented explicit attribute target declaration.
3541 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
3542 Override ValidAttributeTargets.
3545 (ReturnParameter): Class for applying custom attributes on
3547 (ParameterAtribute): New class. Class for applying custom
3548 attributes on the parameter type.
3550 2004-05-17 Miguel de Icaza <miguel@ximian.com>
3552 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
3555 (Method): Allow UNSAFE here.
3557 * modifiers.cs: Support unsafe reporting.
3559 2004-05-17 Marek Safar <marek.safar@seznam.cz>
3561 * decl.cs: Fix bug #58478.
3563 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3565 * statement.cs: When checking for unreachable code on an EmptyStatement,
3566 set the location. Fixes bug #58488.
3568 2004-05-13 Miguel de Icaza <miguel@ximian.com>
3570 * driver.cs: Add -pkg handling.
3572 From Gonzalo: UseShelLExecute=false
3574 2004-05-12 Marek Safar <marek.safar@seznam.cz>
3577 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
3579 (Attribute.IsClsCompliaceRequired): Moved to base for better
3581 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
3582 when attribute is AttributeUsageAttribute.
3583 (Attribute.GetValidTargets): Simplified.
3584 (Attribute.GetAttributeUsage): New method returns AttributeUsage
3585 attribute for this type.
3586 (Attribute.ApplyAttributes): Method renamed to Emit and make
3588 (GlobalAttributeSection): New class for special handling of global
3589 attributes (assembly, module).
3590 (AttributeSection.Emit): New method.
3592 * class.cs: Implemented Attributable abstract methods.
3593 (MethodCore.LabelParameters): Moved to Parameter class.
3594 (Accessor): Is back simple class.
3595 (PropertyMethod): Implemented Attributable abstract class.
3596 (DelegateMethod): Implemented Attributable abstract class.
3597 (Event): New constructor for disctintion between normal Event
3598 and Event with accessors.
3600 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
3602 * codegen.cs, const.cs, decl.cs, delegate.cs:
3603 (CommonAssemblyModulClass): Implemented Attributable abstract class
3606 * enum.cs: Implement IAttributeSupport interface.
3607 (EnumMember): New class for emum members. Implemented Attributable
3611 (ParameterBase): Is abstract.
3612 (ReturnParameter): New class for easier [return:] attribute handling.
3614 * typemanager.cs: Removed builder_to_attr.
3616 2004-05-11 Raja R Harinath <rharinath@novell.com>
3619 * attribute.cs (Attribute.GetPositionalValue): New function.
3620 * class.cs (TypeContainer.VerifyMembers): New function.
3621 (TypeContainer.Emit): Use it.
3622 (ClassOrStruct): New base class for Class and Struct.
3623 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
3624 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
3626 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
3627 then each non-static field should have a FieldOffset attribute.
3628 Otherwise, none of the fields should have a FieldOffset attribute.
3629 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
3630 and FieldOffset attributes.
3631 * typemanager.cs (TypeManager.struct_layout_attribute_type)
3632 (TypeManager.field_offset_attribute_type): New core types.
3633 (TypeManager.InitCoreTypes): Initialize them.
3635 2004-05-11 Michal Moskal <malekith@pld-linux.org>
3637 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
3638 Return correct type.
3641 2004-05-09 Miguel de Icaza <miguel@ximian.com>
3643 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
3644 be implicitly converted to ulong.
3646 * expression.cs: The logic for allowing operator &, | and ^ worked
3647 was wrong, it worked before because we did not report an error in
3648 an else branch. Fixes 57895.
3650 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
3651 allow volatile fields to be reference types.
3653 2004-05-07 Miguel de Icaza <miguel@ximian.com>
3655 * driver.cs: Add support for /debug-
3657 2004-05-07 Raja R Harinath <rharinath@novell.com>
3659 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
3660 Add a 'complain' parameter to silence errors.
3661 (Attribute.Resolve): Update to changes. Put in sanity check to catch
3662 silently overlooked type-resolutions.
3663 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
3665 (Attributes.Search): New function.
3666 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
3667 (Attributes.GetAttributeFullName): Remove hack.
3668 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
3669 Update to reflect changes.
3670 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
3671 Use Attributes.Search instead of nested loops.
3673 2004-05-07 Marek Safar <marek.safar@seznam.cz>
3676 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
3677 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
3678 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
3680 * report.cs: (Report.Warning): Renamed to Warning_T because of
3681 parameter collision.
3683 2004-05-05 Raja R Harinath <rharinath@novell.com>
3685 * expression.cs (MemberAccess.ResolveMemberAccess):
3686 Exit with non-zero status after Report.Error.
3687 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
3689 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
3691 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3693 * support.cs: Don't hang when the file is empty.
3695 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3697 * support.cs: In SeekableStreamReader, compute the preamble size of the
3698 underlying stream. Position changes should take into account that initial
3701 2004-05-03 Todd Berman <tberman@sevenl.net>
3703 * driver.cs: remove unused GetSysVersion function.
3705 2004-05-03 Todd Berman <tberman@sevenl.net>
3707 * driver.cs: Remove the hack from saturday, as well as the hack
3708 from jackson (LoadAssemblyFromGac), also adds the CWD to the
3709 link_paths to get that bit proper.
3711 2004-05-01 Todd Berman <tberman@sevenl.net>
3713 * driver.cs: Try a LoadFrom before a Load, this checks the current
3714 path. This is currently a bug in mono that is be fixed, however, this
3715 provides a workaround for now. This will be removed when the bug
3718 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
3720 * CryptoConvert.cs: Updated to latest version. Fix issue with
3721 incomplete key pairs (#57941).
3723 2004-05-01 Todd Berman <tberman@sevenl.net>
3725 * driver.cs: Remove '.' from path_chars, now System.* loads properly
3728 2004-04-30 Jackson Harper <jackson@ximian.com>
3730 * codegen.cs: Open keys readonly.
3732 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3734 * typemanager.cs: don't report cyclic struct layout when a struct
3735 contains 2 or more fields of the same type. Failed for Pango.AttrShape
3736 which has 2 Pango.Rectangle fields.
3738 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
3740 * expression.cs: Handle IntPtr comparisons with IL code
3741 rather than a method call.
3743 2004-04-29 Martin Baulig <martin@ximian.com>
3745 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
3746 the list of PropertyInfo's in class hierarchy and find the
3747 accessor. Fixes #56013.
3749 2004-04-29 Martin Baulig <martin@ximian.com>
3751 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
3753 2004-04-29 Martin Baulig <martin@ximian.com>
3755 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3757 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
3759 2004-04-29 Martin Baulig <martin@ximian.com>
3761 * class.cs (ConstructorInitializer.Resolve): Check whether the
3762 parent .ctor is accessible. Fixes #52146.
3764 2004-04-29 Martin Baulig <martin@ximian.com>
3766 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3768 * statement.cs (Using.EmitLocalVariableDecls): Use
3769 TypeManager.idisposable_type, not typeof (IDisposable).
3770 (Foreach.EmitCollectionForeach): Added support for valuetypes.
3772 2004-04-29 Martin Baulig <martin@ximian.com>
3774 * class.cs (Event.Define): Don't emit the field and don't set
3775 RTSpecialName and SpecialName for events on interfaces. Fixes
3778 2004-04-29 Raja R Harinath <rharinath@novell.com>
3780 Refactor Attribute.ApplyAttributes.
3781 * attribute.cs (Attributable): New base class for objects that can
3782 have Attributes applied on them.
3783 (Attribute): Make AttributeUsage fields public.
3784 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
3785 (Attribute.IsInternalCall): New property.
3786 (Attribute.UsageAttr): Convert to a public read-only property.
3787 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3788 (Attribute.ResolveType, Attribute.Resolve)
3789 (Attribute.ScanForIndexerName): Update to reflect changes.
3790 (Attribute.CheckAttributeTarget): Re-format.
3791 (Attribute.ApplyAttributes): Refactor, to various
3792 Attributable.ApplyAttributeBuilder methods.
3793 * decl.cs (MemberCore): Make Attributable.
3794 * class.cs (Accessor): Make Attributable.
3795 (MethodData.ApplyAttributes): Use proper attribute types, not
3797 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
3798 (TypeContainer.ApplyAttributeBuilder)
3799 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
3800 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
3801 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
3802 (Operator.ApplyAttributeBuilder): New factored-out methods.
3803 * const.cs (Const.ApplyAttributeBuilder): Likewise.
3804 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
3805 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
3806 * parameter.cs (ParameterBase): New Attributable base class
3807 that can also represent Return types.
3808 (Parameter): Update to the changes.
3810 2004-04-29 Jackson Harper <jackson@ximian.com>
3812 * driver.cs: Prefer the corlib system version when looking for
3813 assemblies in the GAC. This is still a hack, but its a better hack
3816 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3818 * decl.cs, enum.cs: Improved error 3005 reporting.
3820 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3821 (related_symbols): New private member for list of symbols
3822 related to reported error/warning.
3824 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3826 2004-04-29 Martin Baulig <martin@ximian.com>
3828 * ecore.cs (Expression.Constantify): If we're an enum and
3829 TypeManager.TypeToCoreType() doesn't give us another type, use
3830 t.UnderlyingSystemType. Fixes #56178.
3832 2004-04-29 Martin Baulig <martin@ximian.com>
3834 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3835 interfaces and for each interface, only add members directly
3836 declared in that interface. Fixes #53255.
3838 2004-04-28 Martin Baulig <martin@ximian.com>
3840 * expression.cs (ConditionalLogicalOperator): Use a temporary
3841 variable for `left' to avoid that we evaluate it more than once;
3844 2004-04-28 Martin Baulig <martin@ximian.com>
3846 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
3849 2004-04-28 Martin Baulig <martin@ximian.com>
3851 * statement.cs (LocalInfo.Resolve): Check whether the type is not
3854 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
3855 whether the type is not void (CS1547).
3857 2004-04-28 Martin Baulig <martin@ximian.com>
3859 * expression.cs (Unary.DoResolveLValue): Override this and report
3860 CS0131 for anything but Operator.Indirection.
3862 2004-04-28 Martin Baulig <martin@ximian.com>
3864 Committing a patch from Ben Maurer; see bug #50820.
3866 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3869 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3872 2004-04-28 Martin Baulig <martin@ximian.com>
3874 Committing a patch from Ben Maurer; see bug #50820.
3876 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3879 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3882 2004-04-28 Martin Baulig <martin@ximian.com>
3884 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
3885 (Block.AddLabel): Call DoLookupLabel() to only search in the
3888 2004-04-28 Martin Baulig <martin@ximian.com>
3890 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3891 comparing StringConstants and NullLiterals in Equality and Inequality.
3893 2004-04-28 Jackson Harper <jackson@ximian.com>
3895 * driver.cs: Attempt to load referenced assemblies from the
3896 GAC. This is the quick and dirty version of this method that
3897 doesnt take into account versions and just takes the first
3898 canidate found. Will be good enough for now as we will not have more
3899 then one version installed into the GAC until I update this method.
3901 2004-04-28 Martin Baulig <martin@ximian.com>
3903 * typemanager.cs (TypeManager.CheckStructCycles): New public
3904 static method to check for cycles in the struct layout.
3906 * rootcontext.cs (RootContext.PopulateTypes): Call
3907 TypeManager.CheckStructCycles() for each TypeContainer.
3908 [Note: We only need to visit each type once.]
3910 2004-04-28 Martin Baulig <martin@ximian.com>
3912 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3914 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3915 success and added `out object value'. Use a `bool resolved' field
3916 to check whether we've already been called rather than
3917 `ConstantValue != null' since this breaks for NullLiterals.
3919 2004-04-28 Raja R Harinath <rharinath@novell.com>
3921 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3922 setting of this flag, since the 'set' method may be non-public.
3924 2004-04-28 Raja R Harinath <rharinath@novell.com>
3926 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3927 check on current_vector.Block.
3929 2004-04-27 Martin Baulig <martin@ximian.com>
3931 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3932 a field initializer. Fixes #56459.
3934 2004-04-27 Martin Baulig <martin@ximian.com>
3936 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3937 we're not attempting to use an indexer. Fixes #52154.
3939 2004-04-27 Martin Baulig <martin@ximian.com>
3941 * statement.cs (Return): Don't create a return label if we don't
3942 need it; reverts my change from January 20th. Thanks to Ben
3945 2004-04-27 Martin Baulig <martin@ximian.com>
3947 According to the spec, `goto' can only leave a nested scope, but
3950 * statement.cs (Block.LookupLabel): Only lookup in the current
3951 block, don't recurse into parent or child blocks.
3952 (Block.AddLabel): Check in parent and child blocks, report
3953 CS0140/CS0158 if we find a duplicate.
3954 (Block): Removed this indexer for label lookups.
3955 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3956 this already does the error reporting for us.
3959 (FlowBranching.UsageVector.Block): New public variable; may be null.
3960 (FlowBranching.CreateSibling): Added `Block' argument.
3961 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3962 label for the target of a `goto' and check whether we're not
3963 leaving a `finally'.
3965 2004-04-27 Martin Baulig <martin@ximian.com>
3967 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3968 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3971 2004-04-27 Martin Baulig <martin@ximian.com>
3973 * statement.cs (Block.AddLabel): Also check for implicit blocks
3974 and added a CS0158 check.
3976 2004-04-27 Martin Baulig <martin@ximian.com>
3978 * flowanalysis.cs (FlowBranchingLoop): New class.
3979 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3980 UsageVector's instead of an ArrayList.
3981 (FlowBranching.Label): Likewise.
3982 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3983 (FlowBranching.AddBreakVector): New method.
3985 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3987 * attribute.cs: Small regression fix: only convert the type if we
3988 the type is different, fixes System.Drawing build.
3990 2004-04-27 Martin Baulig <martin@ximian.com>
3992 * attribute.cs (Attribute.Resolve): If we have a constant value
3993 for a named field or property, implicity convert it to the correct
3996 2004-04-27 Raja R Harinath <rharinath@novell.com>
3998 * statement.cs (Block.Block): Implicit blocks share
3999 'child_variable_names' fields with parent blocks.
4000 (Block.AddChildVariableNames): Remove.
4001 (Block.AddVariable): Mark variable as "used by a child block" in
4002 every surrounding block.
4003 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
4004 been used in a child block, complain about violation of "Invariant
4005 meaning in blocks" rule.
4006 * cs-parser.jay (declare_local_variables): Don't use
4007 AddChildVariableNames.
4008 (foreach_statement): Don't create an implicit block: 'foreach'
4011 2004-04-23 Miguel de Icaza <miguel@ximian.com>
4013 * convert.cs (ImplicitNumericConversion): 0 is also positive when
4014 converting from 0L to ulong. Fixes 57522.
4016 2004-04-22 Marek Safar <marek.safar@seznam.cz>
4018 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
4019 derived class hides via 'new' keyword field from base class (test-242.cs).
4020 TODO: Handle this in the more general way.
4022 * class.cs (CheckBase): Ditto.
4024 2004-04-22 Marek Safar <marek.safar@seznam.cz>
4026 * decl.cs (caching_flags): New member for storing cached values
4028 (MemberCore.Flags): New enum where bit flags for caching_flags
4030 (MemberCore.cls_compliance): Moved to caching_flags.
4031 (DeclSpace.Created): Moved to caching_flags.
4033 * class.cs: Use caching_flags instead of DeclSpace.Created
4035 2004-04-21 Miguel de Icaza <miguel@ximian.com>
4037 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
4038 if we are only a derived class, not a nested class.
4040 * typemanager.cs: Same as above, but do this at the MemberLookup
4041 level (used by field and methods, properties are handled in
4042 PropertyExpr). Allow for the qualified access if we are a nested
4045 2004-04-21 Marek Safar <marek.safar@seznam.cz>
4047 * class.cs: Refactoring.
4048 (IMethodData): New inteface; Holds links to parent members
4049 to avoid member duplication (reduced memory allocation).
4050 (Method): Implemented IMethodData interface.
4051 (PropertyBase): New inner classes for get/set methods.
4052 (PropertyBase.PropertyMethod): Implemented IMethodData interface
4053 (Event): New inner classes for add/remove methods.
4054 (Event.DelegateMethod): Implemented IMethodData interface.
4056 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
4057 EmitContext (related to class.cs refactoring).
4059 2004-04-21 Raja R Harinath <rharinath@novell.com>
4061 * delegate.cs (Delegate.VerifyApplicability): If the number of
4062 arguments are the same as the number of parameters, first try to
4063 verify applicability ignoring any 'params' modifier on the last
4067 2004-04-16 Raja R Harinath <rharinath@novell.com>
4069 * class.cs (TypeContainer.AddIndexer): Use
4070 'ExplicitInterfaceName' to determine if interface name was
4071 explicitly specified. 'InterfaceType' is not initialized at this time.
4072 (TypeContainer.DefineIndexers): Remove use of temporary list. The
4073 Indexers array is already in the required order. Initialize
4074 'IndexerName' only if there are normal indexers.
4075 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
4076 (TypeContainer.Emit): Emit DefaultMember attribute only if
4077 IndexerName is initialized.
4080 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
4082 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
4085 2004-04-15 Raja R Harinath <rharinath@novell.com>
4087 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
4091 * attribute.cs (Attribute.Resolve): Check for duplicate named
4095 2004-04-15 Miguel de Icaza <miguel@ximian.com>
4097 * iterators.cs (MarkYield): track whether we are in an exception,
4098 and generate code accordingly. Use a temporary value to store the
4099 result for our state.
4101 I had ignored a bit the interaction of try/catch with iterators
4102 since their behavior was not entirely obvious, but now it is
4103 possible to verify that our behavior is the same as MS .NET 2.0
4107 2004-04-14 Miguel de Icaza <miguel@ximian.com>
4109 * iterators.cs: Avoid creating temporaries if there is no work to
4112 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
4113 Enumerations, use TypeManager.EnumToUnderlying and call
4116 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
4119 (This.Emit): Use EmitContext.EmitThis to emit our
4122 (This.EmitAssign): Ditto.
4124 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
4125 codepaths, we will move all the functionality into
4128 (FieldExpr.EmitAssign): Ditto.
4130 This fixes several hidden bugs that I uncovered while doing a code
4131 review of this today.
4133 * codegen.cs (EmitThis): reworked so the semantics are more clear
4134 and also support value types "this" instances.
4136 * iterators.cs: Changed so that for iterators in value types, we
4137 do not pass the value type as a parameter.
4139 Initialization of the enumerator helpers is now done in the caller
4140 instead of passing the parameters to the constructors and having
4141 the constructor set the fields.
4143 The fields have now `assembly' visibility instead of private.
4145 2004-04-11 Miguel de Icaza <miguel@ximian.com>
4147 * expression.cs (Argument.Resolve): Check if fields passed as ref
4148 or out are contained in a MarshalByRefObject.
4150 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
4151 another compiler type.
4153 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
4155 * class.cs (Indexer.Define): use the new name checking method.
4156 Also, return false on an error.
4157 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
4158 (is_identifier_[start/part]_character): make static.
4160 2004-04-10 Miguel de Icaza <miguel@ximian.com>
4162 * expression.cs (Binary.ResolveOperator): Do no append strings
4163 twice: since we can be invoked more than once (array evaluation)
4164 on the same concatenation, take care of this here. Based on a fix
4165 from Ben (bug #56454)
4167 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
4169 * codegen.cs: Fix another case where CS1548 must be reported (when
4170 delay-sign isn't specified and no private is available #56564). Fix
4171 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
4172 error when MCS is used on the MS runtime and we need to delay-sign
4173 (which seems unsupported by AssemblyBuilder - see #56621).
4175 2004-04-08 Marek Safar <marek.safar@seznam.cz>
4177 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
4178 (TypeManager.ComputeNamespaces): Faster implementation for
4181 * compiler.csproj: Updated AssemblyName to mcs.
4183 2004-04-07 Miguel de Icaza <miguel@ximian.com>
4185 * rootcontext.cs: Add new types to the boot resolution.
4187 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
4188 MulticastDelegate is not allowed.
4190 * typemanager.cs: Add new types to lookup: System.TypedReference
4193 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
4194 check for TypedReference or ArgIterator, they are not allowed.
4196 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
4197 makes us properly catch 1510 in some conditions (see bug 56016 for
4200 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
4202 * CryptoConvert.cs: update from corlib version
4205 2004-04-05 Miguel de Icaza <miguel@ximian.com>
4207 * class.cs (Indexer.Define): Check indexername declaration
4209 2004-04-05 Marek Safar <marek.safar@seznam.cz>
4211 * attribute.cs (IsClsCompliant): Fixed problem with handling
4212 all three states (compliant, not-compliant, undetected).
4214 2004-03-30 Marek Safar <marek.safar@seznam.cz>
4216 * attribute.cs (Attribute): Location is now public.
4217 (Resolve): Store resolved arguments (pos_values) in attribute class.
4218 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
4219 (GetClsCompliantAttributeValue): New method that gets
4220 CLSCompliantAttribute value.
4221 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
4222 if exists else null.
4223 (AttributeTester): New class for CLS-Compliant verification routines.
4225 * class.cs (Emit): Add CLS-Compliant verification.
4226 (Method.GetSignatureForError): Implemented.
4227 (Constructor.GetSignatureForError): Implemented
4228 (Constructor.HasCompliantArgs): Returns if constructor has
4229 CLS-Compliant arguments.
4230 (Constructor.Emit): Override.
4231 (Construcor.IsIdentifierClsCompliant): New method; For constructors
4232 is needed to test only parameters.
4233 (FieldBase.GetSignatureForError): Implemented.
4234 (TypeContainer): New member for storing base interfaces.
4235 (TypeContainer.FindMembers): Search in base interfaces too.
4237 * codegen.cs (GetClsComplianceAttribute): New method that gets
4238 assembly or module CLSCompliantAttribute value.
4239 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
4241 (ModuleClass.Emit): Add error 3012 test.
4243 * const.cs (Emit): Override and call base for CLS-Compliant tests.
4245 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
4246 state for all decl types.
4247 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
4248 if CLS-Compliant tests are required.
4249 (IsClsCompliaceRequired): New method. Analyze whether code
4250 must be CLS-Compliant.
4251 (IsExposedFromAssembly): New method. Returns true when MemberCore
4252 is exposed from assembly.
4253 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
4254 value or gets cached value.
4255 (HasClsCompliantAttribute): New method. Returns true if MemberCore
4256 is explicitly marked with CLSCompliantAttribute.
4257 (IsIdentifierClsCompliant): New abstract method. This method is
4258 used to testing error 3005.
4259 (IsIdentifierAndParamClsCompliant): New method. Common helper method
4260 for identifier and parameters CLS-Compliant testing.
4261 (VerifyClsCompliance): New method. The main virtual method for
4262 CLS-Compliant verifications.
4263 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
4264 null. I don't know why is null (too many public members !).
4265 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
4266 and get value of first CLSCompliantAttribute that found.
4268 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
4269 (VerifyClsCompliance): Override and add extra tests.
4271 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
4272 clscheck- disable CLS-Compliant verification event if assembly is has
4273 CLSCompliantAttribute(true).
4275 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
4276 ApllyAttribute is now called in emit section as in the other cases.
4277 Possible future Emit integration.
4278 (IsIdentifierClsCompliant): New override.
4279 (VerifyClsCompliance): New override.
4280 (GetEnumeratorName): Returns full enum name.
4282 * parameter.cs (GetSignatureForError): Implemented.
4284 * report.cs (WarningData): New struct for Warning message information.
4285 (LocationOfPreviousError): New method.
4286 (Warning): New method. Reports warning based on the warning table.
4287 (Error_T): New method. Reports error based on the error table.
4289 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
4290 verifications are done here.
4292 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
4294 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
4295 CLSCompliantAttribute.
4296 (all_imported_types): New member holds all imported types from other
4298 (LoadAllImportedTypes): New method fills static table with exported types
4299 from all referenced assemblies.
4300 (Modules): New property returns all assembly modules.
4302 2004-03-30 Miguel de Icaza <miguel@ximian.com>
4304 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
4305 throwing a parser error.
4307 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
4308 which removes the hardcoded get_/set_ prefixes for properties, as
4309 IL allows for the properties to be named something else.
4313 * expression.cs: Do not override operand before we know if it is
4316 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4318 * typemanager.cs: support for pinned variables.
4320 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4322 * decl.cs, typemanager.cs: Avoid using an arraylist
4323 as a buffer if there is only one result set.
4325 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4327 * expression.cs: Make sure you cant call a static method
4328 with an instance expression, bug #56174.
4330 2004-03-29 Miguel de Icaza <miguel@ximian.com>
4332 * class.cs (IsDuplicateImplementation): Improve error reporting to
4333 flag 663 (method only differs in parameter modifier).
4335 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
4336 in preprocessor directives.
4338 * location.cs (LookupFile): Allow for the empty path.
4340 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
4341 better approach for some of that patch, but its failing with the
4342 CharSet enumeration. For now try/catch will do.
4344 * typemanager.cs: Do not crash if a struct does not have fields.
4347 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4349 * expression.cs: cs0213, cant fix a fixed expression.
4352 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4354 * cs-parser.jay: detect invalid embeded statements gracefully.
4357 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4359 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
4362 the invocation type may not be a subclass of the tye of the item/
4363 The type of the item must be a subclass of the invocation item.
4368 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
4370 * attribute.cs: Added methods to get a string and a bool from an
4371 attribute. Required to information from AssemblyKeyFileAttribute,
4372 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
4373 * codegen.cs: Modified AssemblyName creation to include support for
4374 strongnames. Catch additional exceptions to report them as CS1548.
4375 * compiler.csproj: Updated include CryptoConvert.cs.
4376 * compiler.csproj.user: Removed file - user specific configuration.
4377 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
4378 Mono.Security assembly. The original class is maintained and tested in
4379 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
4380 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
4381 like CSC 8.0 (C# v2) supports.
4382 * Makefile: Added CryptoConvert.cs to mcs sources.
4383 * rootcontext.cs: Added new options for strongnames.
4385 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
4387 * driver.cs: For --expect-error, report error code `2'
4388 if the program compiled with no errors, error code `1' if
4389 it compiled with an error other than the one expected.
4391 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
4393 * compiler.csproj: Updated for Visual Studio .NET 2003.
4394 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
4395 * compiler.sln: Updated for Visual Studio .NET 2003.
4397 2004-03-24 Ravi Pratap M <ravi@ximian.com>
4399 * expression.cs: Fix bug #47234. We basically need to apply the
4400 rule that we prefer the conversion of null to a reference type
4401 when faced with a conversion to 'object' (csc behaviour).
4403 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4405 * statement.cs: Shorter form for foreach, eliminates
4406 a local variable. r=Martin.
4408 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4410 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
4411 checks if we can use brtrue/brfalse to test for 0.
4412 * expression.cs: use the above in the test for using brtrue/brfalse.
4415 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4417 * expression.cs: Rewrite string concat stuff. Benefits:
4419 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
4420 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
4421 rather than a concat chain.
4423 * typemanager.cs: Add lookups for more concat overloads.
4425 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4427 * expression.cs: Emit shorter il code for array init.
4444 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
4446 * statement.cs: Before, two switch blocks would be merged if the
4447 total size of the blocks (end_item - begin_item + 1) was less than
4448 two times the combined sizes of the blocks.
4450 Now, it will only merge if after the merge at least half of the
4455 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
4457 * class.cs : csc build fix for GetMethods(). See bug #52503.
4459 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
4461 * expression.cs: Make sure fp comparisons work with NaN.
4462 This fixes bug #54303. Mig approved this patch a long
4463 time ago, but we were not able to test b/c the runtime
4466 2004-03-19 Miguel de Icaza <miguel@ximian.com>
4468 * ecore.cs (TypExpr.GetHashCode): implement this overload.
4470 2004-03-19 Martin Baulig <martin@ximian.com>
4472 * class.cs (MemberCore.IsDuplicateImplementation): Report the
4473 error here and not in our caller.
4475 2004-03-19 Martin Baulig <martin@ximian.com>
4477 * interface.cs: Completely killed this file.
4478 (Interface): We're now a TypeContainer and live in class.cs.
4480 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
4481 argument; we're now also called for interfaces.
4482 (TypeContainer.DefineMembers): Allow this method being called
4484 (TypeContainer.GetMethods): New public method; formerly known as
4485 Interface.GetMethod(). This is used by PendingImplementation.
4486 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
4487 it's now private and non-static.
4488 (Interface): Moved this here; it's now implemented similar to
4490 (Method, Property, Event, Indexer): Added `bool is_interface'
4491 argument to their .ctor's.
4492 (MemberBase.IsInterface): New public field.
4494 * cs-parser.jay: Create normal Method, Property, Event, Indexer
4495 instances instead of InterfaceMethod, InterfaceProperty, etc.
4496 (opt_interface_base): Removed; we now use `opt_class_base' instead.
4497 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
4499 2004-03-19 Martin Baulig <martin@ximian.com>
4501 * class.cs (MethodCore.IsDuplicateImplementation): New private
4502 method which does the CS0111 checking.
4503 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
4504 Use IsDuplicateImplementation().
4506 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
4508 * decl.cs (FindMemberToOverride): New method to find the correct
4509 method or property to override in the base class.
4511 - Make Method/Property use the above method to find the
4512 version in the base class.
4513 - Remove the InheritableMemberSignatureCompare as it is now
4516 This patch makes large code bases much faster to compile, as it is
4517 O(n) rather than O(n^2) to do this validation.
4519 Also, it fixes bug 52458 which is that nested classes are not
4520 taken into account when finding the base class member.
4522 Reviewed/Approved by Martin.
4524 2004-03-17 Marek Safar <marek.safar@seznam.cz>
4526 * interface.cs: In all interface classes removed redundant
4527 member initialization.
4529 2004-03-16 Martin Baulig <martin@ximian.com>
4531 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4533 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4535 * decl.cs (DefineTypeAndParents): New helper method to define a
4536 type's containers before the type itself is defined; This is a
4537 bug exposed by the recent changes to Windows.Forms when an
4538 implemented interface was defined inside a class that had not been
4541 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
4543 (Check): Loop correctly to report errors modifiers
4544 (UNSAFE was not in the loop, since it was the same as TOP).
4546 * interface.cs: Every interface member now takes a ModFlags,
4547 instead of a "is_new" bool, which we set on the base MemberCore.
4549 Every place where we called "UnsafeOk" in the interface, now we
4550 call the proper member (InterfaceMethod.UnsafeOK) instead to get
4551 the unsafe settings from the member declaration instead of the
4552 container interface.
4554 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4556 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4557 `set_indexer_name' to the pending bits (one per type).
4559 We fixed a bug today that was picking the wrong method to
4560 override, since for properties the existing InterfaceMethod code
4561 basically ignored the method name. Now we make sure that the
4562 method name is one of the valid indexer names.
4564 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4566 * support.cs (SeekableStreamReader): Keep track of stream byte
4567 positions and don't mix them with character offsets to the buffer.
4569 Patch from Gustavo Giráldez
4571 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4573 * interface.cs (InterfaceSetGetBase): Removed double member
4574 initialization, base class does it as well.
4576 2004-03-13 Martin Baulig <martin@ximian.com>
4578 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4579 when compiling corlib.
4581 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4583 * convert.cs (ExplicitConversion): We were reporting an error on
4584 certain conversions (object_type source to a value type, when the
4585 expression was `null') before we had a chance to pass it through
4586 the user defined conversions.
4588 * driver.cs: Replace / and \ in resource specifications to dots.
4591 * class.cs: Add check for duplicate operators. Fixes 52477
4593 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4595 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4596 that are in the middle of the statements, not only at the end.
4599 * class.cs (TypeContainer.AddField): No longer set the
4600 `HaveStaticConstructor' flag, now we call it
4601 `UserDefineStaticConstructor' to diferentiate the slightly
4602 semantic difference.
4604 The situation is that we were not adding BeforeFieldInit (from
4605 Modifiers.TypeAttr) to classes that could have it.
4606 BeforeFieldInit should be set to classes that have no static
4611 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4613 And most importantly Zoltan's comment:
4615 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4617 "I think beforefieldinit means 'it's ok to initialize the type sometime
4618 before its static fields are used', i.e. initialization does not need
4619 to be triggered by the first access to the type. Setting this flag
4620 helps the JIT to compile better code, since it can run the static
4621 constructor at JIT time, and does not need to generate code to call it
4622 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4623 this flag for lots of classes like String.
4625 csc sets this flag if the type does not have an explicit static
4626 constructor. The reasoning seems to be that if there are only static
4627 initalizers for a type, and no static constructor, then the programmer
4628 does not care when this initialization happens, so beforefieldinit
4631 This bug prevents the AOT compiler from being usable, since it
4632 generates so many calls to mono_runtime_class_init that the AOT code
4633 is much slower than the JITted code. The JITted code is faster,
4634 because it does not generate these calls if the vtable is type is
4635 already initialized, which is true in the majority of cases. But the
4636 AOT compiler can't do this."
4638 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4640 * class.cs (MethodData.Emit): Refactor the code so symbolic
4641 information is generated for destructors; For some reasons we
4642 were taking a code path that did not generate symbolic information
4645 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4647 * class.cs: Create a Constructor.CheckBase method that
4648 takes care of all validation type code. The method
4649 contains some code that was moved from Define.
4651 It also includes new code that checks for duplicate ctors.
4652 This fixes bug #55148.
4654 2004-03-09 Joshua Tauberer <tauberer@for.net>
4656 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4657 a { ... }-style array creation invokes EmitStaticInitializers
4658 which is not good for reference-type arrays. String, decimal
4659 and now null constants (NullCast) are not counted toward
4660 static initializers.
4662 2004-03-05 Martin Baulig <martin@ximian.com>
4664 * location.cs (SourceFile.HasLineDirective): New public field;
4665 specifies whether the file contains or is referenced by a "#line"
4667 (Location.DefineSymbolDocuments): Ignore source files which
4668 either contain or are referenced by a "#line" directive.
4670 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4672 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4673 direct access to our parent, so check the method inline there.
4675 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4677 * expression.cs (Invocation.EmitCall): Miguel's last commit
4678 caused a regression. If you had:
4683 In Foo the implict this would be null.
4685 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4687 * expression.cs (Invocation.EmitCall): If the method is not
4688 virtual, do not emit a CallVirt to it, use Call.
4690 * typemanager.cs (GetFullNameSignature): Improve the method to
4691 cope with ".ctor" and replace it with the type name.
4693 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4694 as an argument the ConstructorBuilder where it is being defined,
4695 to catch the recursive constructor invocations.
4697 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4699 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4700 routines to check if a type is an enumerable/enumerator allow
4701 classes that implement the IEnumerable or IEnumerator interfaces.
4703 * class.cs (Property, Operator): Implement IIteratorContainer, and
4704 implement SetYields.
4706 (Property.Define): Do the block swapping for get_methods in the
4707 context of iterators. We need to check if Properties also
4708 include indexers or not.
4710 (Operator): Assign the Block before invoking the
4711 OperatorMethod.Define, so we can trigger the Iterator code
4714 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4715 Property and Operator classes are not created when we parse the
4716 declarator but until we have the block completed, so we use a
4717 singleton SimpleIteratorContainer.Simple to flag whether the
4718 SetYields has been invoked.
4720 We propagate this setting then to the Property or the Operator to
4721 allow the `yield' to function.
4723 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4725 * codegen.cs: Implemented attribute support for modules.
4726 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4727 Assembly/Module functionality.
4729 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4730 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4731 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4733 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4735 * interface.cs (FindMembers): The operation is performed on all base
4736 interfaces and not only on the first. It is required for future CLS Compliance patch.
4738 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4740 * statement.cs, codegen.cs:
4741 This patch deals with patterns such as:
4743 public class List : IEnumerable {
4745 public MyEnumerator GetEnumerator () {
4746 return new MyEnumerator(this);
4749 IEnumerator IEnumerable.GetEnumerator () {
4753 public struct MyEnumerator : IEnumerator {
4758 Before, there were a few things we did wrong:
4759 1) we would emit callvirt on a struct, which is illegal
4760 2) we emited ldarg when we needed to emit ldarga
4761 3) we would mistakenly call the interface methods on an enumerator
4762 type that derived from IEnumerator and was in another assembly. For example:
4764 public class MyEnumerator : IEnumerator
4766 Would have the interface methods called, even if there were public impls of the
4767 method. In a struct, this lead to invalid IL code.
4769 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4771 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4774 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4776 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4778 * cs-parser.jay: Fix small regression: we were not testing V2
4779 compiler features correctly.
4781 * interface.cs: If the emit context is null, then create one
4783 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4785 * decl.cs (GetSignatureForError): New virtual method to get full name
4788 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4789 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4791 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4792 Duplicated members and code in these classes has been removed.
4793 Better encapsulation in these classes.
4795 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4797 * assign.cs (Assign.DoResolve): When dealing with compound
4798 assignments, there is a new rule in ECMA C# 2.4 (might have been
4799 there before, but it is documented here) that states that in:
4803 If b is of type int, and the `op' is a shift-operator, then the
4804 above is evaluated as:
4808 * expression.cs (Binary.ResolveOperator): Instead of testing for
4809 int/uint/long/ulong, try to implicitly convert to any of those
4810 types and use that in pointer arithmetic.
4812 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4813 method to print information for from the type, not from the
4814 null-method we were given.
4816 2004-02-01 Duncan Mak <duncan@ximian.com>
4818 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4819 parsing for cmd, fixes bug #53694.
4821 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4823 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4824 in the member name duplication tests. Property and operator name duplication
4825 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4827 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4829 * interface.cs (PopulateMethod): Fixed crash when interface method
4830 returns not existing type (error test cs0246-3.cs).
4832 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4834 * cs-parser.jay (interface_accessors): Re-write actions to also
4835 store attributes attached to get and set methods. Fix spelling
4838 (inteface_property_declaration): Modify accordingly.
4840 (InterfaceAccessorInfo): New helper class to store information to pass
4841 around between rules that use interface_accessors.
4843 * interface.cs (Emit): Apply attributes on the get and set
4844 accessors of properties and indexers too.
4846 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4847 right MethodBuilder when applying attributes to the get and set accessors.
4849 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4851 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4853 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4855 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4857 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4859 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4860 changes that treat `yield' specially when present before `break'
4863 * cs-tokenizer.cs: yield is no longer a keyword.
4865 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4867 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4868 setting for default constructors.
4869 For default constructors are almost every time set wrong Modifier. The
4870 generated IL code has been alright. But inside mcs this values was
4871 wrong and this was reason why several of my CLS Compliance tests
4874 2004-01-22 Martin Baulig <martin@ximian.com>
4876 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4877 not a QualifiedIdentifier. This is what `type_name_expression'
4878 was previously doing.
4879 (type_name_expression): Removed; the code is now in
4880 `namespace_or_type_name'.
4881 (qualified_identifier): Removed, use `namespace_or_type_name'
4883 (QualifiedIdentifier): Removed this class.
4885 2004-01-22 Martin Baulig <martin@ximian.com>
4887 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4888 not a string as alias name.
4890 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4892 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4893 #52730 bug, and instead compute correctly the need to use a
4894 temporary variable when requesting an address based on the
4895 static/instace modified of the field and the constructor.
4897 2004-01-21 Martin Baulig <martin@ximian.com>
4899 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4900 class and namespace before looking up aliases. Fixes #52517.
4902 2004-01-21 Martin Baulig <martin@ximian.com>
4904 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4905 assinged in a 'try'; fixes exception4.cs.
4907 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4908 * class.cs : Implemented parameter-less constructor for TypeContainer
4910 * decl.cs: Attributes are now stored here. New property OptAttributes
4912 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4914 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4916 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4918 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4919 (CSharpSignature): New method for indexer and property signature.
4921 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4923 * pending.cs (IsVirtualFilter): Faster implementation.
4925 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4927 * typemanager.cs: Avoid inclusion of same assembly more than once.
4929 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4931 * cs-parser.jay: Fixed problem where the last assembly attribute
4932 has been applied also to following declaration (class, struct, etc.)
4934 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4936 * class.cs: Added error CS0538, CS0539 reporting.
4937 Fixed crash on Microsoft runtime when field type is void.
4939 * cs-parser.jay: Added error CS0537 reporting.
4941 * pending.cs: Added error CS0535 reporting.
4942 Improved error report for errors CS0536, CS0534.
4944 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4946 Merge a few bits from the Anonymous Method MCS tree.
4948 * statement.cs (ToplevelBlock): New class for toplevel methods,
4949 will hold anonymous methods, lifted variables.
4951 * cs-parser.jay: Create toplevel blocks for delegates and for
4952 regular blocks of code.
4954 2004-01-20 Martin Baulig <martin@ximian.com>
4956 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4957 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4958 and `NeedExplicitReturn'; added `IsLastStatement'.
4959 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4960 have a `ReturnLabel' or we're not unreachable.
4962 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4963 child's reachability; don't just override ours with it. Fixes
4964 #58058 (lluis's example).
4965 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4966 InFinally(), InLoop(), InSwitch() and
4967 BreakCrossesTryCatchBoundary() methods.
4969 * statement.cs (Return): Do all error checking in Resolve().
4970 Unless we are the last statement in a top-level block, always
4971 create a return label and jump to it.
4972 (Break, Continue): Do all error checking in Resolve(); also make
4973 sure we aren't leaving a `finally'.
4974 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4975 statement in a top-level block.
4976 (Block.Flags): Added `IsDestructor'.
4977 (Block.IsDestructor): New public property.
4979 2004-01-20 Martin Baulig <martin@ximian.com>
4981 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4983 2004-01-20 Martin Baulig <martin@ximian.com>
4985 * statement.cs (Statement.ResolveUnreachable): New public method.
4986 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4987 (Block.Resolve): Resolve unreachable statements.
4989 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4991 * expression.cs: We need to fix the case where we do
4992 not have a temp variable here.
4994 * assign.cs: Only expression compound assignments need
4995 temporary variables.
4997 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4999 * flowanalysis.cs: Reduce memory allocation in a few ways:
5000 - A block with no variables should not allocate a bit
5002 - A method with no out parameters does not need any tracking
5003 for assignment of the parameters, so we need not allocate
5006 public readonly Type[] VariableTypes;
5007 public readonly string[] VariableNames;
5008 Are redundant. The data is already stored in the variable
5009 map, so we need not allocate another array for it.
5010 - We need to add alot of checks for if (params | locals) == null
5011 due to the first two changes.
5013 2004-01-18 Miguel de Icaza <miguel@ximian.com>
5015 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
5016 implement IMemoryLocation, we store a copy on a local variable and
5017 take the address of it. Patch from Benjamin Jemlich
5019 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
5020 to use a special "type_name_expression" rule which reduces the
5021 number of "QualifiedIdentifier" classes created, and instead
5022 directly creates MemberAccess expressions.
5024 2004-01-17 Miguel de Icaza <miguel@ximian.com>
5026 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
5027 that fixes #52853. Null literal assignment to ValueType
5029 * class.cs (MethodData.Emit): Instead of checking the name of the
5030 method to determine if its a destructor, create a new derived
5031 class from Method called Destructor, and test for that.
5033 * cs-parser.jay: Create a Destructor object instead of a Method.
5035 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
5039 2004-01-16 Miguel de Icaza <miguel@ximian.com>
5041 * expression.cs (Binary.ResolveOperator): Perform an implicit
5042 conversion from MethodGroups to their delegate types on the
5045 * delegate.cs: Introduce a new class DelegateCreation that is the
5046 base class for `NewDelegate' and `ImplicitDelegateCreation',
5047 factor some code in here.
5049 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
5050 conversion from MethodGroups to compatible delegate types.
5052 * ecore.cs (Expression.Resolve): Do not flag error 654
5053 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
5054 we allow conversions from MethodGroups to delegate types now.
5056 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
5057 assignments in v2 either.
5059 2004-01-10 Miguel de Icaza <miguel@ximian.com>
5061 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
5062 static read-only fields in ctors.
5064 Applied patch from Benjamin Jemlich
5066 * expression.cs (UnaryMutator): Avoid leaking local variables.
5068 2004-01-09 Miguel de Icaza <miguel@ximian.com>
5070 * cs-tokenizer.cs (IsCastToken): Allow the various native types
5071 here to return true, as they can be used like this:
5075 Fixed 49836 and all the other dups
5077 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
5079 * driver.cs: Implement /win32res and /win32icon.
5081 2004-01-08 Miguel de Icaza <miguel@ximian.com>
5083 * cs-parser.jay: Add a rule to improve error handling for the
5084 common mistake of placing modifiers after the type.
5086 2004-01-07 Miguel de Icaza <miguel@ximian.com>
5088 * cs-parser.jay (interface_event_declaration): Catch
5089 initialization of events on interfaces, and report cs0068
5091 * cs-parser.jay (interface_event_declaration): Catch
5092 initialization of events.
5094 * ecore.cs: Better report missing constructors.
5096 * expression.cs (Binary.ResolveOperator): My previous bug fix had
5097 the error reporting done in the wrong place. Fix.
5099 * expression.cs (Binary.ResolveOperator): Catch the
5100 operator + (E x, E y) error earlier, and later allow for implicit
5101 conversions in operator +/- (E e, U x) from U to the underlying
5104 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
5105 52596, if the container class is abstract, the default constructor
5106 is protected otherwise its public (before, we were always public).
5108 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
5111 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
5112 Jemlich that fixes bug #52597, MCS was generating invalid code for
5113 idisposable structs. Thanks to Ben for following up with this
5116 2004-01-06 Miguel de Icaza <miguel@ximian.com>
5118 * driver.cs: Allow assemblies without code to be generated, fixes
5121 2004-01-07 Nick Drochak <ndrochak@gol.com>
5123 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
5125 2004-01-05 Miguel de Icaza <miguel@ximian.com>
5127 * cs-parser.jay: Add rules to improve error reporting if fields or
5128 methods are declared at the namespace level (error 116)
5130 * Add rules to catch event add/remove
5132 2004-01-04 David Sheldon <dave-mono@earth.li>
5134 * expression.cs: Added matching ")" to error message for
5137 2004-01-03 Todd Berman <tberman@gentoo.org>
5139 * ecore.cs, attribute.cs:
5140 Applying fix from #52429.
5142 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5144 * ecore.cs, expression.cs, statement.cs:
5145 Total rewrite of how we handle branching. We
5146 now handle complex boolean expressions with fewer
5147 jumps. As well if (x == 0) no longer emits a ceq.
5149 if (x is Foo) is much faster now, because we generate
5152 Overall, we get a pretty big improvement on our benchmark
5153 tests. The code we generate is smaller and more readable.
5155 I did a full two-stage bootstrap. The patch was reviewed
5156 by Martin and Miguel.
5158 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5160 * cs-parser.jay: Make primary_expression not take a QI.
5161 we dont need this because the member_access rule covers
5162 us here. So we replace the rule with just IDENTIFIER.
5164 This has two good effects. First, we remove a s/r conflict.
5165 Second, we allocate many fewer QualifiedIdentifier objects.
5167 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5169 * attribute.cs: Handle MarshalAs attributes as pseudo, and
5170 set the correct information via SRE. This prevents
5171 hanging on the MS runtime. Fixes #29374.
5173 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5175 * convert.cs: correctly handle conversions to value types
5176 from Enum and ValueType as unboxing conversions.
5178 Fixes bug #52569. Patch by Benjamin Jemlich.
5180 2004-01-02 Ravi Pratap <ravi@ximian.com>
5182 * expression.cs (BetterConversion): Prefer int -> uint
5183 over int -> ulong (csc's behaviour). This fixed bug #52046.
5185 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
5187 * decl.cs (MemberCache.FindMembers): now returns a
5190 * typemanager.cs: In general, go with with ^^.
5191 (CopyNewMethods): take an IList.
5192 (RealMemberLookup): Only allocate an arraylist
5193 if we copy from two sets of methods.
5195 This change basically does two things:
5196 1) Fewer array lists allocated due to CopyNewMethods.
5197 2) the explicit cast in MemberList costed ALOT.
5199 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
5201 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
5202 a hashtable to avoid needless string allocations when an identifier is
5203 used more than once (the common case).
5205 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5207 * pending.cs: MS's TypeBuilder.GetInterfaces ()
5208 is broken, it will not return anything. So, we
5209 have to use the information we have in mcs to
5212 * typemanager.cs: Add a cache for GetInterfaces,
5213 since this will now be used more often (due to ^^)
5215 (GetExplicitInterfaces) New method that gets the
5216 declared, not effective, interfaces on a type
5217 builder (eg, if you have interface IFoo, interface
5218 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
5221 This patch makes MCS able to bootstrap itself on
5224 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5226 * expression.cs: Remove the Nop's that Miguel put
5229 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5231 * report.cs, codegen.cs: Give the real stack trace to
5232 the error when an exception is thrown.
5234 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5236 * decl.cs: only allocate hashtables for ifaces if
5239 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5241 * expression.cs: fix the error from cs0121-2.cs
5242 (a parent interface has two child interfaces that
5243 have a function with the same name and 0 params
5244 and the function is called through the parent).
5246 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
5248 * class.cs, rootcontext.cs, typmanager.cs: do not
5251 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
5253 * codegen.cs: remove stack for the ec flow branching.
5254 It is already a linked list, so no need.
5256 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
5258 * Makefile: Allow custom profiler here.
5260 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5262 * typemanager.cs (LookupType):
5263 - Use a static char [], because split takes
5264 a param array for args, so it was allocating
5266 - Do not store true in a hashtable, it boxes.
5268 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5270 * flowanalysis.cs: bytify common enums.
5272 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5274 * modifiers.cs: Add a new set of flags for the
5275 flags allowed on explicit interface impls.
5276 * cs-parser.jay: catch the use of modifiers in
5277 interfaces correctly.
5278 * class.cs: catch private void IFoo.Blah ().
5280 All related to bug #50572.
5282 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5284 * decl.cs: Rewrite the consistant accessability checking.
5285 Accessability is not linear, it must be implemented in
5286 a tableish way. Fixes #49704.
5288 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5290 * expression.cs: Handle negation in a checked context.
5291 We must use subtraction from zero. Fixes #38674.
5293 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5295 * class.cs: Ignore static void main in DLLs.
5296 * rootcontext.cs: Handle the target type here,
5297 since we are have to access it from class.cs
5298 * driver.cs: account for the above.
5300 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5302 * report.cs: Give line numbers and files if available.
5304 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
5306 * driver.cs: Implement /addmodule.
5308 * typemanager.cs: Change 'modules' field so it now contains Modules not
5311 2003-12-20 Martin Baulig <martin@ximian.com>
5313 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
5314 (FieldBase.IsAssigned): Removed this field.
5315 (FieldBase.SetAssigned): New public method.
5316 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
5318 2003-12-20 Martin Baulig <martin@ximian.com>
5320 * expression.cs (LocalVariableReference.DoResolve): Don't set
5321 `vi.Used' if we're called from DoResolveLValue().
5323 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
5324 returns the usage vector it just merged into the current one -
5325 pass this one to UsageWarning().
5326 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
5327 of the `EmitContext', don't call this recursively on our children.
5329 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
5331 * driver.cs: Implement /target:module.
5333 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
5335 * support.cs (CharArrayHashtable): New helper class.
5337 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
5338 char arrays, not strings, so we can avoid creating a string in
5339 consume_identifier if the identifier is a keyword.
5341 2003-12-16 Martin Baulig <martin@ximian.com>
5343 * statement.cs (LocalInfo.Assigned): Removed this property.
5344 (LocalInfo.Flags): Removed `Assigned'.
5345 (LocalInfo.IsAssigned): New public method; takes the EmitContext
5346 and uses flow analysis.
5347 (Block.UsageWarning): Made this method private.
5348 (Block.Resolve): Call UsageWarning() if appropriate.
5350 * expression.cs (LocalVariableReference.DoResolve): Always set
5351 LocalInfo.Used here.
5353 2003-12-13 Martin Baulig <martin@ximian.com>
5355 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
5356 any value here; we're now using flow analysis to figure out
5357 whether a statement/block returns a value.
5359 2003-12-13 Martin Baulig <martin@ximian.com>
5361 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
5363 (FlowBranching.MergeFinally): Don't call
5364 `branching.CheckOutParameters()' here, this is called in
5366 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
5367 when adding the `finally' vector.
5369 2003-12-13 Martin Baulig <martin@ximian.com>
5372 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
5373 actually work and also fix #48962.
5375 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
5377 * decl.cs: Do not check System.Object for nested types,
5378 since we know it does not have any. Big bang for buck:
5383 corlib: 17.99 seconds
5387 corlib: 17.39 seconds
5389 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
5391 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
5392 time we are returning 0 members, so we save alot here.
5394 2003-12-11 Martin Baulig <martin@ximian.com>
5396 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
5397 `MergeChild()', also just take the `FlowBranching' as argument;
5398 call Merge() on it and return the result.
5399 (FlowBranching.Merge): We don't need to do anything if we just
5402 2003-12-11 Martin Baulig <martin@ximian.com>
5404 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
5405 them in an `ArrayList' to reduce memory usage. Thanks to Ben
5406 Maurer for this idea.
5408 2003-12-11 Martin Baulig <martin@ximian.com>
5410 * flowanalysis.cs (MergeResult): This class is now gone; we now
5411 use the `UsageVector' for this. The reason for this is that if a
5412 branching just has one sibling, we don't need to "merge" them at
5413 all - that's the next step to do.
5414 (FlowBranching.Merge): We now return a `UsageVector' instead of a
5417 2003-12-11 Martin Baulig <martin@ximian.com>
5419 Reworked flow analyis and made it more precise and bug-free. The
5420 most important change is that we're now using a special `Reachability'
5421 class instead of having "magic" meanings of `FlowReturns'. I'll
5422 do some more cleanups and optimizations and also add some more
5423 documentation this week.
5425 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
5426 largely reworked this class.
5427 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
5428 the new `Reachability' class instead of having "magic" values here.
5429 (FlowBranching): We're now using an instance of `Reachability'
5430 instead of having separate `Returns', `Breaks' etc. fields.
5432 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
5433 based on flow analysis; ignore the return value of block.Emit ().
5435 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
5437 * driver.cs typemanager.cs: Find the mono extensions to corlib even
5438 if they are private.
5440 2003-12-09 Martin Baulig <martin@ximian.com>
5442 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
5443 call them directly on the UsageVector.
5445 2003-12-09 Martin Baulig <martin@ximian.com>
5447 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
5448 Changed return type from `FlowReturns' to `Reachability'.
5450 2003-12-09 Martin Baulig <martin@ximian.com>
5452 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
5453 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
5454 `Reachable' fields with a single `Reachability' one.
5456 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5458 * class.cs (FindMembers): Remove foreach's.
5471 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5476 This patch does a few things:
5477 1. EmptyStatement is now a singleton, so it is never reallocated.
5478 2. All blah is EmptyStatement constructs have been changed to
5479 blah == EmptyStatement.Value, which is much faster and valid
5480 now that EmptyStatement is a singleton.
5481 3. When resolving a block, rather than allocating a new array for
5482 the non-empty statements, empty statements are replaced with
5483 EmptyStatement.Value
5484 4. Some recursive functions have been made non-recursive.
5485 Mainly the performance impact is from (3), however (1) and (2) are needed for
5486 this to work. (4) does not make a big difference in normal situations, however
5487 it makes the profile look saner.
5492 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5493 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5494 Total memory allocated: 56397 KB
5497 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
5498 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
5499 Total memory allocated: 55666 KB
5501 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5503 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
5504 than the hashtable in a hashtable version
5506 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
5507 we always end up concating a string. This results in a huge perf
5508 loss, because many strings have to be tracked by the GC. In this
5509 patch, we first use a hashtable that works with two keys, so that
5510 the strings do not need to be concat'ed.
5521 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5523 * Makefile: Add a new target `do-time' that does a quick and simple
5524 profile, leaving easy to parse output.
5526 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
5528 * codegen.cs (Init): Create the dynamic assembly with
5529 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
5531 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
5533 * support.cs: Make the PtrHashtable use only one
5534 instance of its comparer.
5536 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
5538 * typemanager.cs: Fix lookup of GetNamespaces.
5540 2003-11-29 Miguel de Icaza <miguel@ximian.com>
5542 * expression.cs: Removed redundant line.
5544 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
5545 ArrayLists, use for loops with bounds.
5547 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
5550 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
5551 arraylists, use for loop with bounds.
5553 The above three changes give us a 0.071 second performance
5554 improvement out of 3.294 seconds down to 3.223. On my machine
5555 the above changes reduced the memory usage by 1,387 KB during
5558 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5559 QualifiedIdentifiers. Before we created a new string through
5560 concatenation, and mostly later on, the result would be
5561 manipulated by DecomposeQI through string manipulation.
5563 This reduced the compiler memory usage for bootstrapping from
5564 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5565 compile times in 0.05 seconds.
5567 2003-11-28 Dick Porter <dick@ximian.com>
5569 * support.cs: Do string compares with the Invariant culture.
5577 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5578 the comparison is done with the Invariant culture.
5580 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5582 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5583 GetEnumerator method.
5585 (ProbeCollectionType): Iterate starting at the most specific type
5586 upwards looking for a GetEnumerator
5588 * expression.cs: Shift count can be up to 31 for int/uint and 63
5591 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5593 * statement.cs (Block.LookupLabel): Also look for the label on the
5594 children blocks. Use a hash table to keep track of visited
5597 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5598 we actually did transform the other operand, otherwise fall back
5599 to the common codepath that casts to long.
5601 * cs-tokenizer.cs: Use the same code pattern as the int case.
5602 Maybe I should do the parsing myself, and avoid depending on the
5603 Parse routines to get this done.
5605 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5607 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5608 which fixes bug 51347. This time test it.
5610 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5611 attributes for example can not tell the difference between these.
5612 The difference was only a syntax feature of the language.
5614 * attribute.cs: Apply attributes to delegates.
5616 * delegate.cs: Call the apply attributes method.
5618 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5620 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5621 comparing 0 vs Byte.MinValue, not the value
5623 (ImplicitConversionRequired): When reporting a conversion error,
5624 use error 31 to print out the constant error instead of the
5627 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5628 which fixes bug 51347.
5630 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5632 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5633 which fixes the -warnaserror command line option.
5635 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5637 * cfold.cs (DoNumericPromotions): During constant folding of
5638 additions on UIntConstant, special case intconstants with
5639 IntConstants like we do on the expression binary operator.
5641 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5643 * convert.cs (ImplicitReferenceConversion): We were missing a case
5644 (System.Enum are not value types or class types, so we need to
5645 classify them separatedly).
5647 * driver.cs: We do not support error 2007.
5649 2003-11-12 Jackson Harper <jackson@ximian.com>
5651 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5652 system directory. Also use the full file name so users can
5653 libraries names mscorlib-o-tron.dll in a non system dir.
5655 2003-11-10 Martin Baulig <martin@ximian.com>
5657 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5658 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5659 calling `ResolveType()' on them, directly assign their `Type'.
5661 2003-11-08 Martin Baulig <martin@ximian.com>
5663 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5664 return value and the `out parent' parameter.
5665 (TypeContainer.DefineType): Moved the CS0644 check into
5666 GetClassBases(). Don't pass the interface types to the
5667 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5668 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5670 * ecore.cs (TypeExpr.IsAttribute): New property.
5671 (TypeExpr.GetInterfaces): New method.
5673 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5674 TypeExpr instead of a Type.
5675 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5676 (Interface.DefineType): Don't pass the interface types to the
5677 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5678 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5680 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5681 instead of a `Type[]'.
5682 (TypeManager.RegisterBuilder): Likewise.
5683 (TypeManager.AddUserInterface): Likewise.
5684 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5685 `Type[]' and also return a `TypeExpr[]'.
5686 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5688 2003-11-08 Martin Baulig <martin@ximian.com>
5690 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5693 2003-11-08 Martin Baulig <martin@ximian.com>
5695 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5696 TypeManager.ResolveExpressionTypes().
5698 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5699 instead of an Expression.
5700 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5701 (TypeExpression): New public class; formerly known as `TypeExpr'.
5703 * expression.cs (ComposedCast): Derive from TypeExpr.
5705 * typemanager.cs (TypeManager.system_*_expr): These are now
5706 TypExpr's instead of Expression's.
5707 (TypeManager.ResolveExpressionTypes): New public static function;
5708 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5711 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5713 * expression.cs (New.DoResolve): Do not dereference value that
5714 might be a null return.
5716 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5717 sure that the constant value has the right type. Fixes an
5718 unreported bug, similar to 50425.
5720 * const.cs (Const.LookupConstantValue): Call
5721 ImplicitStandardConversionExists before doing a conversion to
5722 avoid havng the TypeManager.ChangeType do conversions.
5724 Reduced the number of casts used
5726 (Const.ChangeType): New routine to enable reuse of the constant
5727 type changing code from statement.
5729 * typemanager.cs (ChangeType): Move common initialization to
5730 static global variables.
5734 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5735 every value type to go through, even if it was void. Fix that.
5737 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5738 character of the define, and the is_identifier_part_character for
5739 the rest of the string.
5741 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5743 * expression.cs (UnaryMutator.EmitCode): When I updated
5744 LocalVariableReference.DoResolve, I overdid it, and dropped an
5745 optimization done on local variable references.
5747 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5749 * ecore.cs: Convert the return from Ldlen into an int.
5751 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5753 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5754 the accessibility, this is a special case for toplevel non-public
5755 classes (internal for instance).
5757 2003-10-20 Nick Drochak <ndrochak@gol.com>
5759 * ecore.cs: Fix typo and build. Needed another right paren.
5761 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5763 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5764 `internal' case regular and protected, but not allowing protected
5765 to be evaluated later. Bug 49840
5767 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5769 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5770 to kb.Nlast, and not the kb.nFirst to isolate the switch
5773 Extract the underlying type, so enumerations of long/ulong are
5774 treated like long/ulong.
5776 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5778 * expression.cs (New): Overload the meaning of RequestedType to
5779 track the possible creation of the NewDelegate type, since
5780 DoResolve is invoked more than once for new constructors on field
5783 See bugs: #48800 and #37014
5785 * cs-parser.jay (declare_local_constants): Take an arraylist
5786 instead of a single constant.
5788 (local_constant_declaration): It should take a
5789 constant_declarators, not a constant_declarator. Fixes 49487
5791 * convert.cs: Fix error report.
5793 2003-10-13 Jackson Harper <jackson@ximian.com>
5795 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5798 2003-10-09 Martin Baulig <martin@ximian.com>
5800 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5802 (MethodCore.DoDefineParameters): Removed the TypeContainer
5803 argument; use the DeclSpace which was passed to the .ctor instead.
5804 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5805 TypeContainer; we only need a DeclSpace here.
5807 2003-10-09 Martin Baulig <martin@ximian.com>
5809 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5811 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5812 EmitContext's .ctor.
5814 2003-10-09 Martin Baulig <martin@ximian.com>
5816 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5817 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5818 AsAccessible(), moved them as well.
5820 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5822 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5824 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5826 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5828 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5829 generation for >=, as spotted by Paolo, bug 48679.
5830 Patch from David Waite.
5832 * cs-tokenizer.cs: Add handling for #pragma.
5834 * cs-parser.jay: Allow for both yield and yield return in the
5835 syntax. The anti-cobolization of C# fight will go on!
5837 * class.cs (TypeBuilder.DefineType): Catch error condition here
5838 (Parent.DefineType erroring out and returning null).
5840 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5841 coping with enumerations variables, we were mistakenly processing
5842 them as a regular value type instead of built-in types. Fixes the
5845 * typemanager.cs (IsBuiltinOrEnum): New method.
5847 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5849 * cs-parser.jay: Upgrade: yield now needs the return clause.
5851 2003-09-19 Martin Baulig <martin@ximian.com>
5853 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5854 `MemberCache parent' argument. Normally, an interface doesn't
5855 have a parent type except System.Object, but we use this in gmcs
5856 for generic type parameters.
5858 2003-09-18 Martin Baulig <martin@ximian.com>
5860 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5861 on `type.IsInterface'; don't check whether the type has a parent
5862 to determine whether it's an interface.
5864 2003-09-15 Martin Baulig <martin@ximian.com>
5866 * class.cs (TypeContainer.DefineType): Added an error flag to
5867 avoid reporting duplicate CS0146's ("class definition is
5870 * driver.cs (Driver.MainDriver): Abort if
5871 RootContext.ResolveTree() reported any errors.
5873 2003-09-07 Martin Baulig <martin@ximian.com>
5875 * report.cs (Error, Warning): Added overloaded versions which take
5876 a `params object[] args' and call String.Format().
5878 2003-09-07 Martin Baulig <martin@ximian.com>
5880 * decl.cs (DeclSpace..ctor): Don't call
5881 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
5882 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
5883 (DeclSpace.RecordDecl): New method.
5885 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
5887 2003-09-02 Ravi Pratap <ravi@ximian.com>
5889 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
5890 value attributes to be applied to ParameterBuilders.
5892 * class.cs (MethodCore.LabelParameters): Make static and more
5893 generic so that it can be used from other places - like interface
5894 methods, for instance.
5896 * interface.cs (Interface.Emit): Call LabelParameters before
5897 emitting attributes on the InterfaceMethod.
5899 2003-08-26 Martin Baulig <martin@ximian.com>
5901 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
5902 resolving aliases; fixes #47927.
5904 2003-08-26 Martin Baulig <martin@ximian.com>
5906 * statement.cs (Using.DoResolve): This is internally emitting a
5907 try/finally clause, so we need to set ec.NeedExplicitReturn if we
5908 do not always return. Fixes #47681.
5910 2003-08-26 Martin Baulig <martin@ximian.com>
5912 * decl.cs (MemberCore): Moved WarningNotHiding(),
5913 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
5915 (AdditionResult): Make this nested in DeclSpace.
5916 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
5917 argument; call NamespaceEntry.Define() unless we're nested in a
5920 * namespace.cs (Namespace.DefineName): New public function. This
5921 is called from DeclSpace's .ctor to add
5922 (Namespace.Lookup): Include DeclSpaces in the lookup.
5924 * class.cs (Operator): Derive from MemberBase, not MemberCore.
5926 * const.cs (Const): Derive from MemberBase, not MemberCore.
5928 2003-08-25 Martin Baulig <martin@ximian.com>
5930 * convert.cs (Convert.ExplicitReferenceConversion): When
5931 converting from an interface type to a class, unbox if the target
5932 type is a struct type. Fixes #47822.
5934 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5936 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
5939 2003-08-22 Martin Baulig <martin@ximian.com>
5941 * class.cs (TypeManager.DefineType): When defining a nested type,
5942 call DefineType() on our parent; fixes #47801.
5944 2003-08-22 Martin Baulig <martin@ximian.com>
5946 * class.cs (MethodData.Define): While checking if a method is an
5947 interface implementation, improve the test a bit more to fix #47654.
5949 2003-08-22 Martin Baulig <martin@ximian.com>
5951 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
5952 correctly; fixes #47722.
5954 2003-08-22 Martin Baulig <martin@ximian.com>
5956 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
5957 LocalVariableReference, ensure it's not read-only. Fixes #47536.
5959 * statement.cs (Fixed.DoResolve): Make all variables read-only.
5961 2003-08-22 Martin Baulig <martin@ximian.com>
5963 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
5964 can only be assigned in static constructors. Fixes #47161.
5966 2003-08-22 Martin Baulig <martin@ximian.com>
5968 Rewrote and improved the flow analysis code.
5970 * flowbranching.cs (FlowBranching): Make this class abstract.
5971 (FlowBranching.CreateBranching): New static function to create a
5973 (FlowBranchingBlock, FlowBranchingException): New classes.
5974 (FlowBranching.UsageVector.Type): New public readonly field.
5975 (FlowBranching.UsageVector.Breaks): Removed the setter.
5976 (FlowBranching.UsageVector.Returns): Removed the setter.
5977 (FlowBranching.UsageVector): Added Break(), Return(),
5978 NeverReachable() and Throw() methods to modify the reachability.
5979 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
5980 done by FlowBranching.Merge().
5981 (FlowBranching.UsageVector.MergeChild): New method; merges the
5982 merge result into the current vector.
5983 (FlowBranching.Merge): New abstract method to merge a branching.
5985 2003-08-12 Martin Baulig <martin@ximian.com>
5987 * expression.cs (Indirection.CacheTemporaries): Create the
5988 LocalTemporary with the pointer type, not its element type.
5990 2003-08-10 Miguel de Icaza <miguel@ximian.com>
5992 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
5993 token was a keyword or not.
5995 Add `error' options where an IDENTIFIER was expected; Provide
5996 CheckToken and CheckIdentifierToken convenience error reporting
5999 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
6001 * decl.cs: Rename `NamespaceEntry Namespace' public field into
6002 NameSpaceEntry NameSpaceEntry.
6004 (LookupInterfaceOrClass): Avoid creating a full qualified name
6005 from namespace and name: avoid doing lookups when we know the
6006 namespace is non-existant. Use new Tree.LookupByNamespace which
6007 looks up DeclSpaces based on their namespace, name pair.
6009 * driver.cs: Provide a new `parser verbose' to display the
6010 exception thrown during parsing. This is turned off by default
6011 now, so the output of a failure from mcs is more graceful.
6013 * namespace.cs: Track all the namespaces defined in a hashtable
6016 (IsNamespace): New method
6018 2003-08-09 Miguel de Icaza <miguel@ximian.com>
6020 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
6021 we know that we need to concatenate (full typename can never be
6026 * statement.cs: Use a bitfield; Do not initialize to null things
6027 which are done by the constructor by default.
6029 * cs-parser.jay: bug fix, parameter was 4, not 3.
6031 * expression.cs: Just use the property;
6033 * statement.cs: No need for GetVariableInfo method.
6035 2003-08-08 Martin Baulig <martin@ximian.com>
6037 * flowanalysis.cs (FlowReturns): This is now nested in the
6038 `FlowBranching' class.
6039 (MyBitVector): Moved this here from statement.cs.
6040 (FlowBranching.SiblingType): New enum type.
6041 (FlowBranching.CreateSibling): Added `SiblingType' argument.
6043 2003-08-07 Martin Baulig <martin@ximian.com>
6045 * flowanalysis.cs (FlowBranchingType): This is now nested in the
6046 `FlowBranching' class and called `BranchingType'.
6048 2003-08-07 Martin Baulig <martin@ximian.com>
6050 * flowanalysis.cs: Moved all the control flow analysis code into
6053 2003-08-07 Martin Baulig <martin@ximian.com>
6055 * assign.cs (Assign.DoResolve): `target' must either be an
6056 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
6059 2003-08-07 Miguel de Icaza <miguel@ximian.com>
6061 * expression.cs (BinaryMethod): This kind of expression is created by the
6062 Binary class if it determines that the operator has to be handled
6065 (BinaryDelegate): This kind of expression is created if we are
6066 dealing with a + or - operator on delegates.
6068 (Binary): remove method, argumetns, and DelegateOperator: when
6069 dealing with methods,
6071 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
6073 * statement.cs (Block): use bitfields for the three extra booleans
6074 we had in use. Remove unused topblock parameter.
6076 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
6078 * assign.cs: Drop extra unneeded tests.
6080 2003-08-06 Miguel de Icaza <miguel@ximian.com>
6082 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
6084 * statement.cs (Foreach): Use VariableStorage instead of
6087 * codegen.cs (VariableStorage): New class used by clients that
6088 require a variable stored: locals or fields for variables that
6089 need to live across yield.
6091 Maybe provide a convenience api for EmitThis+EmitLoad?
6093 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
6096 2003-08-05 Miguel de Icaza <miguel@ximian.com>
6098 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
6099 RemapParameterLValue): New methods that are used to turn a
6100 precomputed FieldInfo into an expression like this:
6104 The idea is to use this instead of making LocalVariableReference
6105 have more than one meaning.
6107 * cs-parser.jay: Add error production to BASE.
6109 * ecore.cs: Deal with TypeManager.GetField returning null, which
6110 is now a valid return value.
6112 (FieldExprNoAddress): New expression for Fields whose address can
6115 * expression.cs (LocalVariableReference): During the resolve
6116 phases, create new expressions if we are in a remapping context.
6117 Remove code that dealt with remapping here.
6119 (ParameterReference): same.
6121 (ProxyInstance): New expression, like the `This' expression, but
6122 it is born fully resolved. We know what we are doing, so remove
6123 the errors that are targeted to user-provided uses of `this'.
6125 * statement.cs (Foreach): our variable is now stored as an
6126 Expression; During resolution, follow the protocol, dont just
6127 assume it will return this.
6129 2003-08-06 Martin Baulig <martin@ximian.com>
6131 * support.cs (SeekableStreamReader.cs): New public class.
6133 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
6134 SeekableStreamReader instead of the normal StreamReader.
6136 2003-08-04 Martin Baulig <martin@ximian.com>
6138 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
6139 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
6140 deambiguate casts and delegate invocations.
6141 (parenthesized_expression): Use the new tokens to ensure this is
6142 not a cast of method invocation.
6144 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
6145 when reading a `)' and Deambiguate_CloseParens () was previously
6148 * expression.cs (ParenthesizedExpression): New class. This is
6149 just used for the CS0075 test.
6150 (Binary.DoResolve): Check for CS0075.
6152 2003-07-29 Ravi Pratap <ravi@ximian.com>
6154 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
6155 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
6156 reference comparison.
6158 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
6159 examine the ReturnType for equality - this is necessary in the
6160 cases of implicit and explicit operators whose signature also
6161 includes the return type.
6163 2003-07-26 Miguel de Icaza <miguel@ximian.com>
6165 * namespace.cs: Cache the result of the namespace computation,
6166 instead of computing it every time.
6168 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6170 * decl.cs: Use a global arraylist that we reuse over invocations
6171 to avoid excesive memory consumption. Reduces memory usage on an
6172 mcs compile by one meg (45 average).
6174 * typemanager.cs (LookupTypeReflection): In .NET pointers are
6175 private, work around that.
6177 2003-07-23 Miguel de Icaza <miguel@ximian.com>
6179 * literal.cs (IntLiteral): Define Zero and One static literals.
6181 * cs-parser.jay (integer_literal): use static literals to reduce
6182 memory usage for the most used literals (0, 1 and -1). 211kb
6183 reduced in memory usage.
6185 Replace all calls to `new ArrayList' with `new
6186 ArrayList(4)' which is a good average number for most allocations,
6187 and also requires only 16 bytes of memory for its buffer by
6190 This reduced MCS memory usage in seven megabytes for the RSS after
6193 2003-07-28 Ravi Pratap <ravi@ximian.com>
6195 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
6196 handle params methods the correct way by forming only one
6197 applicable set with params and normal methods in them. Earlier we
6198 were looking at params methods only if we found no normal methods
6199 which was not the correct thing to do.
6201 (Invocation.BetterFunction): Take separate arguments indicating
6202 when candidate and the best method are params methods in their
6205 This fixes bugs #43367 and #46199.
6207 * attribute.cs: Documentation updates.
6209 (CheckAttribute): Rename to CheckAttributeTarget.
6210 (GetValidPlaces): Rename to GetValidTargets.
6212 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
6213 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
6217 2003-07-28 Martin Baulig <martin@ximian.com>
6219 * class.cs (TypeContainer.DefineMembers): Use the base type's full
6220 name when looking up the base class of a nested class. Fixes #46977.
6222 2003-07-26 Martin Baulig <martin@ximian.com>
6224 * expression.cs (Indexers.Indexer): New nested struct; contains
6225 getter, setter and the indexer's type.
6226 (Indexers.Properties): This is now an ArrayList of
6228 (IndexerAccess.DoResolveLValue): Correctly set the type if the
6229 indexer doesn't have any getters.
6231 * assign.cs (Assign.DoResolve): Also do the implicit conversions
6232 for embedded property and indexer assignments.
6234 2003-07-26 Martin Baulig <martin@ximian.com>
6236 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
6237 preprocessor directive is not the first non-whitespace character
6240 2003-07-26 Martin Baulig <martin@ximian.com>
6242 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
6243 namespace parsing, follow the spec more closely.
6245 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
6246 NamespaceEntry.Lookup().
6248 2003-07-25 Martin Baulig <martin@ximian.com>
6250 * MethodCore.cs (OverridesSomething): New public field; it's set
6251 from TypeContainer.DefineMembers if this method overrides
6252 something (which doesn't need to be a method). Fix #39462.
6254 2003-07-25 Ravi Pratap <ravi@ximian.com>
6256 * typemanager.cs (GetMembers): Ensure that the list of members is
6257 reversed. This keeps things in sync.
6259 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
6260 find an AttributeUsage attribute.
6262 * expression.cs (Invocation.OverloadResolve): Perform the check
6263 which disallows Invoke to be directly called on a Delegate.
6265 (Error_InvokeOnDelegate): Report error cs1533.
6267 2003-07-25 Martin Baulig <martin@ximian.com>
6269 * expression.cs (Indexers.GetIndexersForType): Only look in the
6270 interface hierarchy if the requested type is already an
6271 interface. Fixes #46788 while keeping #46502 fixed.
6273 2003-07-25 Martin Baulig <martin@ximian.com>
6275 * class.cs (TypeContainer.DefineMembers): Check whether all
6276 readonly fields have been assigned and report warning CS0649 if
6279 * statement.cs (LocalInfo.IsFixed): Always return true if this is
6282 2003-07-24 Ravi Pratap <ravi@ximian.com>
6284 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
6285 returned from GetMethods to make things consistent with the
6286 assumptions MCS makes about ordering of methods.
6288 This should comprehensively fix bug #45127 and it does :-)
6290 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
6291 ordering is actually reverse.
6293 * Clean up some debug messages I left lying around.
6295 * interface.cs (Populate*): Get rid of code which emits attributes
6296 since the stage in which we emit attributes is the 'Emit' stage,
6297 not the define stage.
6299 (Emit): Move attribute emission for interface members here.
6301 2003-07-22 Ravi Pratap <ravi@ximian.com>
6303 * expression.cs (Invocation.OverloadResolve): Follow the spec more
6304 closely: we eliminate methods in base types when we have an
6305 applicable method in a top-level type.
6307 Please see section 14.5.5.1 for an exact description of what goes
6310 This fixes bug #45127 and a host of other related to corlib compilation.
6312 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
6313 array is the method corresponding to the top-level type (this is
6314 because of the changes made to icall.c) so we change this
6317 (MethodGroupExpr.Name): This too.
6319 * typemanager.cs (GetElementType): New method which does the right
6320 thing when compiling corlib.
6322 * everywhere: Make use of the above in the relevant places.
6324 2003-07-22 Martin Baulig <martin@ximian.com>
6326 * cs-parser.jay (invocation_expression): Moved
6327 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
6328 `cast_expression', but create a InvocationOrCast which later
6329 resolves to either an Invocation or a Cast.
6331 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
6332 method; call this before EmitStatement() to make sure that this
6333 expression can be used as a statement.
6335 * expression.cs (InvocationOrCast): New class; resolves to either
6336 an Invocation or a Cast.
6338 * statement.cs (StatementExpression): Call ResolveStatement() on
6339 the ExpressionStatement before emitting it.
6341 2003-07-21 Martin Baulig <martin@ximian.com>
6343 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
6344 `ref' and `out' attributes match; fixes #46220.
6345 (MemberAccess.ResolveMemberAccess): You can't reference a type
6346 through an expression; fixes #33180.
6347 (Indexers.GetIndexersForType): Don't return the indexers from
6348 interfaces the class implements; fixes #46502.
6350 2003-07-21 Martin Baulig <martin@ximian.com>
6352 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
6353 CS0661 checks; fixes bug #30442.
6355 2003-07-21 Martin Baulig <martin@ximian.com>
6357 * decl.cs (AdditionResult): Added `Error'.
6359 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
6361 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
6362 makes cs0031.cs actually work.
6364 2003-07-20 Martin Baulig <martin@ximian.com>
6366 * namespace.cs: Fixed that bug which caused a crash when compiling
6369 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6371 * typemanager.cs (LookupTypeReflection): Never expose types which
6372 are NotPublic, NestedPrivate, NestedAssembly, or
6373 NestedFamANDAssem. We used to return these, and later do a check
6374 that would report a meaningful error, but the problem is that we
6375 would not get the real match, if there was a name override.
6377 2003-07-18 Miguel de Icaza <miguel@ximian.com>
6379 * namespace.cs (Namespace, Name): Do not compute the namespace
6380 name dynamically, compute it in the constructor. This reduced
6381 memory usage by 1697 KB.
6383 * driver.cs: Use --pause to pause at the end.
6385 2003-07-17 Peter Williams <peter@newton.cx>
6387 * Makefile: Change the name of the test target so that it doesn't
6388 conflict with the recursive test target.
6390 2003-07-17 Miguel de Icaza <miguel@ximian.com>
6392 * expression.cs (LocalVariableReference.Emit, EmitAssign,
6393 AddressOf): Do not use EmitThis, that was wrong, use the actual
6396 2003-07-15 Miguel de Icaza <miguel@ximian.com>
6398 * class.cs (MethodData.Define): While checking if a method is an
6399 interface implementation, improve the test: If we are not public
6400 (use new test here: use the computed MethodAttributes directly,
6401 instead of the parsed modifier flags) check if the `implementing'
6402 method comes from an interface or not.
6404 * pending.cs (VerifyPendingMethods): Slightly better error
6407 * makefile: add test target that does the mcs bootstrap.
6409 2003-07-16 Ravi Pratap <ravi@ximian.com>
6411 * interface.cs (Define): Do nothing here since there are no
6412 members to populate etc. Move the attribute emission out of here
6413 since this was just totally the wrong place to put it. Attribute
6414 application happens during the 'Emit' phase, not in the 'Define'
6417 (Emit): Add this method and move the attribute emission here
6419 * rootcontext.cs (EmitCode): Call the Emit method on interface
6422 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6424 * expression.cs (OverloadResolve): Report error only if Location
6425 is not 'Null' which means that there was a probe going on.
6427 2003-07-14 Martin Baulig <martin@ximian.com>
6429 * expression.cs (ConditionalLogicalOperator): New public class to
6430 implement user defined conditional logical operators.
6431 This is section 14.11.2 in the spec and bug #40505.
6433 2003-07-14 Martin Baulig <martin@ximian.com>
6435 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
6437 2003-07-14 Martin Baulig <martin@ximian.com>
6439 * codegen.cs (EmitContext.InFixedInitializer): New public field.
6441 * ecore.cs (IVariable.VerifyFixed): New interface method.
6443 * expression.cs (Unary.ResolveOperator): When resolving the `&'
6444 operator, check whether the variable is actually fixed. Fixes bug
6445 #36055. Set a variable definitely assigned when taking its
6446 address as required by the spec.
6448 * statement.cs (LocalInfo.IsFixed): New field.
6449 (LocalInfo.MakePinned): Set `IsFixed' to true.
6451 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6453 * attribute.cs (Attribute.Resolve): While doing a Member lookup
6454 for .ctors, ensure that we only ask for members declared in the
6455 attribute type (BindingFlags.DeclaredOnly).
6459 * expression.cs (Error_WrongNumArguments): Report error 1501
6460 correctly the way CSC does.
6462 2003-07-13 Martin Baulig <martin@ximian.com>
6464 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
6465 lookup on the fully qualified name, to make things like "X.X" work
6466 where "X.X" is a fully qualified type name, but we also have a
6467 namespace "X" in the using list. Fixes #41975.
6469 2003-07-13 Martin Baulig <martin@ximian.com>
6471 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
6472 function. If we're a CompoundAssign, we need to create an embedded
6473 CompoundAssign, not an embedded Assign.
6474 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
6477 2003-07-13 Martin Baulig <martin@ximian.com>
6479 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
6480 work to fix bug #46088.
6482 2003-07-13 Ravi Pratap <ravi@ximian.com>
6484 * class.cs (Operator.Emit): Do not emit attributes here - it is
6485 taken care of by the Method class that we delegate too. This takes
6488 2003-07-10 Martin Baulig <martin@ximian.com>
6490 * expression.cs (TypeOfVoid): New class.
6491 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6493 2003-07-10 Martin Baulig <martin@ximian.com>
6495 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6498 2003-07-10 Martin Baulig <martin@ximian.com>
6500 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6501 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6503 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6505 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6507 2003-07-10 Martin Baulig <martin@ximian.com>
6509 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6510 of decimal. Fixes #42850.
6512 NOTE: I also fixed the created byte blob, but this doesn't work on
6513 the MS runtime and csc never produces any byte blobs for decimal
6516 2003-07-10 Martin Baulig <martin@ximian.com>
6518 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6519 structs; fixes #32068.
6520 (Block.AddChildVariableNames): Fixed #44302.
6522 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6524 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6526 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6528 * attribute.cs: And this test is onger needed.
6530 2003-07-08 Martin Baulig <martin@ximian.com>
6532 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6533 inaccessible types. Fixes #36313.
6535 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6537 * namespace.cs (NamespaceEntry): Create implicit entries for all
6538 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6539 implicit entries for N1.N2 and N1.
6541 2003-07-08 Martin Baulig <martin@ximian.com>
6543 Rewrote the handling of namespaces to fix a lot of the issues
6544 wrt. `using' aliases etc.
6546 * namespace.cs (Namespace): Splitted this class into a
6547 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6549 * typemanager.cs (TypeManager.IsNamespace): Removed.
6550 (TypeManager.ComputeNamespaces): Only compute namespaces from
6551 loaded assemblies here, not the namespaces from the assembly we're
6552 currently compiling.
6554 2003-07-08 Martin Baulig <martin@ximian.com>
6556 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6558 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6560 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6563 I thought about the memory savings here, but LookupTypeReflection
6564 is used under already very constrained scenarios. Compiling
6565 corlib or mcs only exposes one hit, so it would not really reduce
6566 any memory consumption.
6568 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6570 * typemanager.cs: fixes bug #45889 by only adding public types from
6571 other assemblies to the list of known types.
6573 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6575 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6576 on the type we resolved.
6578 2003-07-05 Martin Baulig <martin@ximian.com>
6580 * pending.cs (PendingImplementation.ParentImplements): Don't
6581 create the proxy if the parent is abstract.
6583 * class.cs (TypeContainer.DefineIndexers): Process explicit
6584 interface implementations first. Fixes #37714.
6586 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6588 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6589 defined recursively; but since we modify the input parameters
6590 (left is set to `this' temporarily), we reset this value if the
6591 left_is_explicit is false, which gives the original semantics to
6594 * literal.cs (NullPointer): new class used to represent a null
6595 literal in a pointer context.
6597 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6598 type is a pointer, use a NullPointer object instead of a
6599 NullLiteral. Closes 43687
6601 (ExplicitConversion): Convert pointer values using
6602 the conv opcode to the proper type.
6604 * ecore.cs (New): change ValueTypeVariable property into a method,
6605 that returns whether the valuetype is suitable for being used.
6607 * expression.cs (Binary.DoNumericPromotions): Only return if we
6608 the int constant was a valid uint, and we can return both left and
6609 right as uints. If not, we continue processing, to trigger the
6610 type conversion. This fixes 39018.
6612 * statement.cs (Block.EmitMeta): During constant resolution, set
6613 the CurrentBlock property on the emitcontext, so that we resolve
6614 constants propertly.
6616 2003-07-02 Martin Baulig <martin@ximian.com>
6618 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6619 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6621 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6622 than emitting it here.
6624 * statement.cs: Fixed some more flow analysis bugs.
6626 2003-07-02 Martin Baulig <martin@ximian.com>
6628 * class.cs (MethodData.Define): When implementing interface
6629 methods, set Final unless we're Virtual.
6631 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6632 check work for interface methods.
6634 2003-07-01 Martin Baulig <martin@ximian.com>
6636 * ecore.cs (EmitContext.This): Replaced this property with a
6637 GetThis() method which takes a Location argument. This ensures
6638 that we get the correct error location for a CS0188.
6640 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6642 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6643 ImplicitStandardConversion.
6645 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6647 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6649 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6652 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6654 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6657 (MethodData.Define): Turn off initlocals for unsafe methods.
6659 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6661 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6662 complete; Fixes #37521.
6664 * delegate.cs: Use Modifiers.TypeAttr to compute the
6665 TypeAttributes, instead of rolling our own. This makes the flags
6666 correct for the delegates.
6668 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6670 * class.cs (Constructor.Define): Set the private flag for static
6671 constructors as well.
6673 * cs-parser.jay (statement_expression): Set the return value to
6674 null, to avoid a crash when we catch an error.
6676 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6678 * cs-parser.jay: Applied patch from Jackson that adds support for
6679 extern and unsafe modifiers to destructor declarations.
6681 * expression.cs: Report error 21 if the user is trying to index a
6684 * driver.cs: Add an error message, suggested by the bug report.
6686 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6687 if we do not have a ": this ()" constructor initializer. Fixes 45149
6689 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6691 * namespace.cs: Add some information to reduce FAQs.
6693 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6695 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6696 underlying enumeration types. Fixes #43915.
6698 * expression.cs: Treat ushort/short as legal values to be used in
6701 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6703 * delegate.cs: transfer custom attributes for paramenters from
6704 the delegate declaration to Invoke and BeginInvoke.
6706 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6708 * attribute.cs: handle custom marshalers and emit marshal info
6711 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6713 * makefile.gnu: Added anonymous.cs to the compiler sources.
6715 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6717 * iterators.cs: Change the name of the proxy class to include two
6720 * cs-parser.jay: Update grammar to include anonymous methods.
6722 * anonymous.cs: new file.
6724 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6726 * class.cs (Field.Define): Add missing test for pointers and
6729 2003-05-27 Ravi Pratap <ravi@ximian.com>
6731 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6732 we use the stobj opcode.
6734 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6735 since it wasn't the correct fix.
6737 It still is puzzling that we are required to use stobj for IntPtr
6738 which seems to be a ValueType.
6740 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6742 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6743 during regular simple name resolution. Now, the trick is that
6744 instead of returning for processing the simplename, we do a
6745 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6746 contextual lookup type). If a match is found, return that, if
6747 not, return for further composition.
6749 This fixes long-standing 30485.
6751 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6752 using the address to initialize an object, do an Stobj instead of
6753 using the regular Stelem.
6755 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6756 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6757 Because if we are a BaseIndexerAccess that value will be true.
6760 * statement.cs (GotoCase.Resolve): Return after reporting an
6761 error, do not attempt to continue.
6763 * expression.cs (PointerArithmetic.Emit): If our operand is a
6764 long, convert our constants to match the operand before
6765 multiplying. Convert to I type before adding. Fixes 43670.
6767 2003-05-14 Ravi Pratap <ravi@ximian.com>
6769 * enum.cs (ImplicitConversionExists) : Rename to
6770 ImplicitEnumConversionExists to remove ambiguity.
6772 * ecore.cs (NullCast): New type of cast expression class which
6773 basically is very similar to EmptyCast with the difference being
6774 it still is a constant since it is used only to cast a null to
6778 * convert.cs (ImplicitReferenceConversion): When casting a null
6779 literal, we return a NullCast.
6781 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6782 should be around anymore.
6784 The renaming (reported was slightly wrong). Corrections:
6786 ConvertImplicitStandard -> ImplicitConversionStandard
6787 ConvertExplicitStandard -> ExplicitConversionStandard
6789 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6790 before passing them in !
6792 * convert.cs (ImplicitConversionStandard): When comparing for
6793 equal expr and target types, ensure that expr is not a
6796 In general, we must not be checking (expr_type ==
6797 target_type) in the top level conversion methods
6798 (ImplicitConversion, ExplicitConversion etc). This checking is
6799 done in the methods that they delegate to.
6801 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6803 * convert.cs: Move Error_CannotConvertType,
6804 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6805 ImplicitNumericConversion, ImplicitConversionExists,
6806 ImplicitUserConversionExists, StandardConversionExists,
6807 FindMostEncompassedType, FindMostSpecificSource,
6808 FindMostSpecificTarget, ImplicitUserConversion,
6809 ExplicitUserConversion, GetConversionOperators,
6810 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6811 TryImplicitIntConversion, Error_CannotConvertImplicit,
6812 ConvertImplicitRequired, ConvertNumericExplicit,
6813 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6814 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6817 Perform the following renames:
6819 StandardConversionExists -> ImplicitStandardConversionExists
6820 ConvertImplicit -> ImplicitConversion
6821 ConvertImplicitStandard -> ImplicitStandardConversion
6822 TryImplicitIntConversion -> ImplicitIntConversion
6823 ConvertImplicitRequired -> ImplicitConversionRequired
6824 ConvertNumericExplicit -> ExplicitNumericConversion
6825 ConvertReferenceExplicit -> ExplicitReferenceConversion
6826 ConvertExplicit -> ExplicitConversion
6827 ConvertExplicitStandard -> ExplicitStandardConversion
6829 2003-05-19 Martin Baulig <martin@ximian.com>
6831 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6832 (TypeInfo): Added support for structs having structs as fields.
6834 * ecore.cs (FieldExpr): Implement IVariable.
6835 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6836 VariableInfo for the field.
6838 2003-05-18 Martin Baulig <martin@ximian.com>
6840 * expression.cs (This.DoResolve): Report a CS0027 if we're
6841 emitting a field initializer.
6843 2003-05-18 Martin Baulig <martin@ximian.com>
6845 * expression.cs (This.ResolveBase): New public function.
6846 (This.DoResolve): Check for CS0188.
6848 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
6851 * ecore.cs (MethodGroupExpr.DoResolve): Set the
6852 `instance_expression' to null if we don't have any non-static
6855 2003-05-18 Martin Baulig <martin@ximian.com>
6857 Reworked the way how local variables and parameters are handled by
6858 the flow analysis code.
6860 * statement.cs (TypeInfo, VariableMap): New public classes.
6861 (VariableInfo): New public class. This is now responsible for
6862 checking whether a variable has been assigned. It is used for
6863 parameters and local variables.
6864 (Block.EmitMeta): Take the InternalParameters as argument; compute
6865 the layout of the flow vectors here.
6866 (Block.LocalMap, Block.ParameterMap): New public properties.
6867 (FlowBranching): The .ctor doesn't get the InternalParameters
6868 anymore since Block.EmitMeta() now computes the layout of the flow
6870 (MyStructInfo): This class is now known as `StructInfo' and nested
6871 in `TypeInfo'; we don't access this directly anymore.
6873 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
6874 property and removed IsAssigned(), IsFieldAssigned(),
6875 SetAssigned() and SetFieldAssigned(); we now call them on the
6876 VariableInfo so we don't need to duplicate this code everywhere.
6878 * expression.cs (ParameterReference): Added `Block block' argument
6880 (LocalVariableReference, ParameterReference, This): The new
6881 VariableInfo class is now responsible for all the definite
6884 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
6885 IsParameterAssigned, SetParameterAssigned): Removed.
6887 2003-05-18 Martin Baulig <martin@ximian.com>
6889 * typemanager.cs (InitCoreTypes): Try calling
6890 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
6891 the 3-args-version. Corlib now also needs our `void_type'.
6892 (GetMethod): Added overloaded version which takes an optional
6893 `bool report_errors' to allow lookups of optional methods.
6895 2003-05-12 Martin Baulig <martin@ximian.com>
6897 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
6898 only used for locals and not for parameters.
6900 2003-05-12 Miguel de Icaza <miguel@ximian.com>
6902 * support.cs (InternalParameters.ParameterType): Return the
6903 ExternalType of the parameter.
6905 * parameter.cs (Parameter.ExternalType): drop the two arguments,
6908 2003-05-11 Miguel de Icaza <miguel@ximian.com>
6910 * class.cs (MethodData.Define): Do not set the `newslot' on
6911 interface members, if they are also flagged as "override".
6913 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
6914 better code for ++i and i++. This only works for static fields
6915 and local variables.
6917 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
6918 want to pull the DeclSpace out of the builder_to_declspace instead
6919 of the TypeBuilder (like in TypeContainer.FindMembers).
6921 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
6922 instead of LookupTypeContainer. Fixes the crash on .NET for
6923 looking up interface members.
6925 * const.cs: Create our own emit context during the Definition
6926 stage, so that constants are evaluated in the proper context, when
6927 a recursive definition happens.
6929 2003-05-11 Martin Baulig <martin@ximian.com>
6931 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
6932 new block for a switch section.
6933 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
6934 the adding/lookup in the switch block. Fixes #39828.
6936 2003-05-09 Miguel de Icaza <miguel@ximian.com>
6938 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
6939 functionality: I needed to convert the data after I had performed
6940 the add/sub operation into the operands type size.
6942 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
6943 pass the type for the box operation, otherwise the resulting
6944 object would have been of type object.
6946 (BoxedCast): Add constructor to specify the type to box as.
6948 2003-05-07 Miguel de Icaza <miguel@ximian.com>
6950 * iterators.cs: I was reusing the `count' variable inadvertently,
6951 take steps to not allow this to happen.
6953 2003-05-06 Miguel de Icaza <miguel@ximian.com>
6955 * attribute.cs (Attribute.Resolve): Params attributes are encoded
6956 by creating an array at the point where the params starts and
6957 putting all those arguments there, then adjusting the size of the
6960 2003-05-05 Miguel de Icaza <miguel@ximian.com>
6962 * expression.cs (New.AddressOf): Implement interface
6963 IMemoryLocation. This is used when the `new' operator is used in
6964 the context of an invocation to a method on a value type.
6966 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
6969 * namespace.cs: Also check the using aliases here.
6971 * driver.cs: Move the test for using validity after the types have
6972 been entered, so we do a single pass that also includes the using
6975 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
6976 in the regular case. CreateSiblingForFinally is doing extra
6979 * attribute.cs (GetAttributeArgumentExpression): Store the result
6980 on an out value, and use the return value to indicate failure
6981 instead of using null (which is a valid return for Constant.GetValue).
6983 * statement.cs: Perform the analysis flow for the increment
6984 portion after the statement, because this will be the real flow of
6985 execution. Fixes #42385
6987 * codegen.cs (EmitContext.EmitArgument,
6988 EmitContext.EmitStoreArgument): New helper functions when the
6989 RemapToProxy flag is set.
6991 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
6994 Add support for remapping parameters.
6996 * iterators.cs: Propagate parameter values; Store parameter
6997 values in the proxy classes.
6999 2003-05-04 Miguel de Icaza <miguel@ximian.com>
7001 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
7002 need a proxy reference; I do not know what I was thinking
7004 * cs-parser.jay (constructor_initializer): catch another error,
7005 and display nice message.
7007 (field_declaration): catch void field declaration
7008 to flag a better error.
7010 * class.cs (MemberBase.CheckBase): Report an error instead of a
7011 warning if a new protected member is declared in a struct.
7012 (Field.Define): catch the error of readonly/volatile.
7014 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
7016 (FieldExpr.AddressOf): ditto. Catch error where the address of a
7017 volatile variable is taken
7019 2003-05-02 Miguel de Icaza <miguel@ximian.com>
7021 * statement.cs (Fixed.Resolve): Report an error if we are not in
7024 2003-05-01 Miguel de Icaza <miguel@ximian.com>
7026 * typemanager.cs: reuse the code that handles type clashes for
7027 delegates and enumerations.
7029 * class.cs (Report28): Always report.
7031 * expression.cs (EncodeAsAttribute): Allow nulls here.
7033 2003-04-28 Miguel de Icaza <miguel@ximian.com>
7035 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
7036 the functionality for testing whether an expression is valid for
7037 an attribute here. Also handle the case of arrays of elements
7040 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
7041 encoding a linear array into an array of objects that are suitable
7042 to be passed to an CustomAttributeBuilder.
7044 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
7046 * ecore.cs: (FieldExpr): Handle field remapping here.
7048 * iteratators.cs: Pass the instance variable (if the method is an
7049 instance method) to the constructors, so we can access the field
7050 variables on the class.
7052 TODO: Test this with structs. I think the THIS variable on
7053 structs might have to be a pointer, and not a refenrece
7055 2003-04-27 Miguel de Icaza <miguel@ximian.com>
7057 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
7058 local variables to fields in a proxy class.
7060 * iterators.cs (PopulateProxy): Rename our internal fields to
7062 Create a <THIS> field if we are an instance method, so we can
7063 reference our parent container variables.
7064 (MapVariable): Called back from the EmitContext code to enter a
7065 new variable to field mapping into the proxy class (we just create
7069 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
7070 for using the remapped locals to fields.
7072 I placed the code here, because that gives the same semantics to
7073 local variables, and only changes the Emit code.
7075 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
7076 statements inside iterators.
7077 (VariableInfo): Add a FieldBuilder for the cases when we are
7078 remapping local variables to fields in a proxy class
7080 * ecore.cs (SimpleNameResolve): Avoid testing two times for
7081 current_block != null.
7083 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
7084 not cope with strings, as it has been moved to the
7085 TableSwitchEmit. Fixed bug in switch generation.
7087 * expression.cs (New.DoResolve): Provide more context for the user
7088 when reporting an error.
7090 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
7093 * expression.cs (MemberAccess.DoResolve): When we get a type back,
7094 check the permissions for it. Note than in a type-resolution
7095 context the check was already present in DeclSpace.ResolveType,
7096 but was missing from the MemberAccess.
7098 (ArrayCreation.CheckIndices): warn if the user has
7099 more nested levels of expressions, but there are no more
7100 dimensions specified. Avoids crash on bug 41906.
7102 2003-04-26 Miguel de Icaza <miguel@ximian.com>
7104 * statement.cs (Block): replace Implicit bool, for a generic
7106 New flag: `Unchecked'. This is used during the EmitMeta phase
7107 (which is out-of-line with the regular Resolve/Emit process for a
7108 statement, as this is done ahead of time, but still gets a chance
7109 to call constant resolve).
7111 (Block.Flags): new enum for adding a new flag.
7113 (Block.EmitMeta): track the state of unchecked.
7115 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
7116 to enable constant resolution to work there as well.
7118 2003-04-22 Miguel de Icaza <miguel@ximian.com>
7120 * typemanager.cs (ienumerable_type): Also look up
7121 System.Collections.IEnumerable.
7123 2003-04-21 Miguel de Icaza <miguel@ximian.com>
7125 TODO: Test more than one conditional per method.
7127 * class.cs (Indexer.Define): Report the location where the user is
7128 referencing the unsupported feature.
7130 (MethodData): Overload the use of `conditionals' to
7131 minimize the creation of needless ArrayLists. This saves roughly
7132 212kb on my machine.
7134 (Method): Implement the new IIteratorContainer interface.
7135 (Method.SetYields): Implement the method by setting the ModFlags
7136 to contain METHOD_YIELDS.
7138 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
7139 which just got set to null.
7141 * iterators.cs: New file.
7143 (Yield, YieldBreak): New statements.
7145 * statement.cs (Return.Resolve): Flag an error if we are used in
7148 * codegen.cs (InIterator): New flag set if the code is being
7149 compiled in an iterator method.
7151 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
7152 internal modifier, and we just use it to avoid adding extra
7153 fields, as this is seldom used.
7155 * cs-parser.jay: Add yield_statement (yield and yield break).
7157 * driver.cs: New flag -v2 to turn on version 2 features.
7159 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
7160 hashtable when v2 is enabled.
7162 2003-04-20 Miguel de Icaza <miguel@ximian.com>
7164 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
7165 there is already a namespace defined with this name.
7167 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
7168 people upgraded their corlibs.
7170 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
7171 always use fully qualified types, no need to use the compiler
7174 (TypeManager.IsNamespace): Use binarysearch.
7176 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
7177 AddDelegate): I did not quite use the new IsValid API properly: I
7178 have to pass the short-name and the fullname. I was passing only
7179 the basename instead of the fullname sometimes.
7181 (TypeContainer.DefineType): call NamespaceClash.
7183 * interface.cs (Interface.DefineType): use NamespaceClash before
7186 * delegate.cs (Delegate.DefineType): use NamespaceClash before
7189 * enum.cs: (Enum.DefineType): use NamespaceClash before
7192 * typemanager.cs (: 3-line patch that gives us some tasty 11%
7193 speed increase. First, use the negative_hits cache when we get a
7194 negative. Second, add the type with its full original name
7195 instead of the new . and + encoded name (reflection uses + to
7196 separate type from a nested type). Use LookupTypeReflection
7197 directly which bypasses the type->name hashtable (that we already
7198 know does not contain the type.
7200 * decl.cs (DeclSpace.ResolveTypeExpr): track the
7201 location/container type.
7203 * driver.cs: When passing utf8, use directly the UTF8Encoding.
7205 2003-04-19 Miguel de Icaza <miguel@ximian.com>
7207 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
7209 * delegate.cs (NewDelegate.Resolve): Test whether an instance
7210 method is being referenced in the method group from a static
7211 context, and report error 120 if so.
7213 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
7216 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
7217 is created, we create the A namespace).
7219 * cs-parser.jay: A namespace also introduces a DeclarationFound.
7222 2003-04-18 Miguel de Icaza <miguel@ximian.com>
7224 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
7225 invocation to ModuleBuilder.GetType with the same values will
7226 return a new type instance, so we need to cache its return
7229 * expression.cs (Binary.ResolveOperator): Only allow the compare
7230 operators on enums if they are of the same type.
7232 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
7233 types of ValueType on their own case. Before we were giving them
7234 the same treatment as objects.
7236 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
7237 fullname. Short name is used to compare against container name.
7238 Fullname is used to check against defined namespace names.
7240 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
7241 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
7243 (Method.CheckBase): Call parent.
7244 (MemberBase.CheckBase): Check for protected members on sealed
7246 (PropertyBase.CheckBase): Call parent.
7247 (Field.Define): Call parent.
7249 * report.cs: Negative error codes are now mapped to 8000 - code,
7250 so that the display is render more nicely.
7252 * typemanager.cs: Do not use try/catch, instead report a regular
7255 (GetPointerType, GetReferenceType): These methods provide
7256 mechanisms to obtain the T* and T& from a T. We had the code
7257 previously scattered around the code base, and it also used
7258 TypeManager.LookupType that would go through plenty of caches.
7259 This one goes directly to the type source.
7261 In some places we did the Type.GetType followed by
7262 ModuleBuilder.GetType, but not in others, so this unifies the
7265 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
7266 statements now that we have namespace information.
7268 * typemanager.cs (IsNamespace): New method, returns whether the
7269 string presented is a namespace or not.
7271 (ComputeNamespaces): New public entry point, computes the list of
7272 available namespaces, using the GetNamespaces API call in Mono, or
7273 the slower version in MS.NET.
7275 Now before we start the semantic analysis phase, we have a
7276 complete list of namespaces including everything that the user has
7279 Deleted old code to cache namespaces in .nsc files.
7281 2003-04-17 Miguel de Icaza <miguel@ximian.com>
7283 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
7284 class/struct location definition Location for the implicit
7285 constructor location.
7287 (Operator.Define): Use the location of the operator for the
7288 implicit Method definition.
7290 (Constructor.Emit): use the constructor location for the implicit
7291 base initializer constructor.
7293 * ecore.cs: Remove ITypeExpression. This interface is now gone,
7294 and the Expression class now contains two new methods:
7296 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
7297 isolate type lookup from the rest of the resolution process.
7299 Since we use Expressions to hold type definitions due to the way
7300 we parse the input we have historically overloaded Resolve to
7301 perform the Type lookups if a special flag is passed. Now this is
7302 eliminated and two methods take their place.
7304 The differences in the two methods between xStep and xTerminal is
7305 that xStep is involved in our current lookup system that uses
7306 SimpleNames to compose a name, while xTerminal is used just to
7307 catch the case where the simplename lookup failed.
7309 2003-04-16 Miguel de Icaza <miguel@ximian.com>
7311 * expression.cs (ResolveMemberAccess): Remove redundant code.
7312 TypeExpr expressions are always born fully resolved.
7314 * interface.cs (PopulateMethod): Do not lookup the types twice.
7315 We were doing it once during SemanticAnalysis and once during
7318 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
7319 in local variable type definitions, were being returned as a
7320 SimpleName (we decomposed everything into a string), that is
7321 because primary_expression was being used instead of a type in the
7322 grammar (reduce/reduce conflicts).
7324 The part that was wrong is that we converted the expression into a
7325 string (an oversimplification in one hand, compounded with primary
7326 expressions doing string concatenation).
7332 Would return "A.B.C[]" as a SimpleName. This stopped things like
7333 using clauses from working on this particular context. And a type
7334 was being matched directly against "A.B.C[]".
7336 We now use the correct approach, and allow for ComposedCast to be
7337 part of the unary expression. So the "A.B.C []" become a composed
7338 cast of "A.B.C" (as a nested group of MemberAccess with a
7339 SimpleName at the end) plus the rank composition "[]".
7343 2003-04-10 Miguel de Icaza <miguel@ximian.com>
7345 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
7346 for the access level checking.
7348 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
7349 `TypeContainer container', because I kept getting confused when I
7350 was debugging this code.
7352 * expression.cs (Indexers): Instead of tracking getters/setters,
7353 we now track them in parallel. We create one arraylist less, but
7354 most importantly it is possible now for the LValue code to find a
7355 matching get for a set.
7357 (IndexerAccess.DoResolveLValue): Update the code.
7358 GetIndexersForType has been modified already to extract all the
7359 indexers from a type. The code assumed it did not.
7361 Also make the code set the correct return type for the indexer.
7362 This was fixed a long time ago for properties, but was missing for
7363 indexers. It used to be void_type.
7365 (Binary.Emit): Test first for doubles instead of
7366 floats, as they are more common.
7368 (Binary.EmitBranchable): Use the .un version of the branch opcodes
7369 when dealing with floats and the <=, >= operators. This fixes bug
7372 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
7373 to load the array value by emitting a load on the foreach variable
7374 type. This was incorrect.
7376 We now emit the code to load an element using the the array
7377 variable type, and then we emit the conversion operator.
7381 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
7383 * attribute.cs: Avoid allocation of ArrayLists in the common case.
7385 2003-04-09 Miguel de Icaza <miguel@ximian.com>
7387 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
7388 test for protection before we test for signatures.
7390 (MethodSignature.ToString): implement.
7392 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
7393 to the case where we reduced into a LongConstant.
7395 * decl.cs (CheckAccessLevel): If the type is an array, we can not
7396 depend on whether the information is acurrate, because the
7397 Microsoft runtime will always claim that the array type is public,
7398 regardless of the real state.
7400 If the type is a pointer, another problem happens: the type is
7401 reported as non-public in Microsoft.
7403 In both cases we have to call CheckAccessLevel recursively with
7404 the underlying type as the argument to be tested.
7406 2003-04-08 Miguel de Icaza <miguel@ximian.com>
7408 * assign.cs (Assign.Emit): If we are dealing with a compound
7409 assignment expression, we should use the code path that stores the
7410 intermediate result in a temporary value. This fixes #40903.
7412 *expression.cs (Indirection.ToString): Provide ToString method for
7415 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
7417 * class.cs: Null out fields holding references to Block objects so
7418 they can be garbage collected.
7420 * expression.cs (OverloadResolve): Remove unused local.
7422 2003-04-07 Martin Baulig <martin@ximian.com>
7424 * codegen.cs (EmitContext.CurrentFile): New public field.
7425 (EmitContext.Mark): Use the CurrentFile to check whether the
7426 location is in the correct file.
7427 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
7429 2003-04-07 Martin Baulig <martin@ximian.com>
7431 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
7433 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
7434 location. [FIXME: The location argument which gets passed to this
7435 method is sometimes wrong!]
7437 2003-04-07 Nick Drochak <ndrochak@gol.com>
7439 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
7441 2003-04-07 Miguel de Icaza <miguel@ximian.com>
7443 * expression.cs (Indirection.EmitAssign): We were using the
7444 temporary, but returning immediately instead of continuing the
7447 2003-04-06 Martin Baulig <martin@ximian.com>
7449 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
7450 if it's a nested child, but also deriving from the outer class.
7453 * typemanager.cs (IsNestedChildOf): Make this work if it's a
7454 nested child, but also deriving from the outer class. See
7456 (FilterWithClosure): We may access private members of the outer
7457 class if we're a nested child and deriving from the outer class.
7458 (RealMemberLookup): Only set `closure_private_ok' if the
7459 `original_bf' contained BindingFlags.NonPublic.
7461 2003-04-05 Martin Baulig <martin@ximian.com>
7463 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
7465 2003-04-02 Miguel de Icaza <miguel@ximian.com>
7467 * class.cs (Event.Define): Do not allow abstract events to have
7470 2003-04-01 Miguel de Icaza <miguel@ximian.com>
7472 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
7473 block in event declarations.
7475 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
7476 value type, get its address.
7478 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
7479 leaving a class on the stack instead of a boolean value (int
7480 0/1). Change the code so we compare against null, and then the
7481 result against zero.
7483 * class.cs (TypeContainer.GetClassBases): We were checking for the
7484 parent class being sealed too late.
7486 * expression.cs (Binary.Emit): For <= and >= when dealing with
7487 floating point values, use cgt.un and clt.un instead of cgt and
7490 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7492 * statement.cs: Apply the same optimization as MS: skip the
7493 GetEnumerator returning an IEnumerator, and use the one returning a
7494 CharEnumerator instead. This allows us to avoid the try-finally block
7497 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7499 * cs-parser.jay: Attributes cannot be applied to
7500 namespaces. Fixes #40473
7502 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7505 (Add*): check if the name is valid using the full name for constants,
7506 fields, properties and events.
7508 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7510 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7511 char constants to be part of the enumeration.
7513 * expression.cs (Conditional.DoResolve): Add support for operator
7514 true. Implements the missing functionality from 14.12
7516 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7517 operator true/false as required by the spec.
7519 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7520 implicit conversion to boolean.
7522 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7523 also one where the type implements `operator true'.
7525 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7526 get an expression that will invoke operator true based on an
7529 (GetConversionOperators): Removed the hack that called op_True
7532 (Expression.ResolveBoolean): Move this from Statement.
7534 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7536 * ecore.cs (FieldExpr): do not allow initialization of initonly
7537 fields on derived classes
7539 2003-03-13 Martin Baulig <martin@ximian.com>
7541 * statement.cs (Block.Emit): Call ig.BeginScope() and
7542 ig.EndScope() when compiling with debugging info; call
7543 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7545 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7547 * expression.cs (Indexers): Do not construct immediately, allow
7548 for new members to be appended as we go. Fixes 38143
7550 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7552 * expression.cs: save/restore context when resolving an unchecked
7555 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7557 * cfold.cs: Catch division by zero in modulus operator during
7560 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7562 * interface.cs (Interface.DefineMembers): Avoid defining members
7565 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7567 * driver.cs: handle the +/- options for -noconfig
7569 * statement.cs (Unckeched.Resolve): Also track the state of
7570 unchecked in the Resolve phase.
7572 2003-02-27 Martin Baulig <martin@ximian.com>
7574 * ecore.cs (Expression.MemberLookup): Don't create a
7575 MethodGroupExpr for something which is not a method. Fixes #38291.
7577 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7579 * class.cs (MemberBase.CheckParameters): Also check that the type
7580 is unmanaged if it is a pointer.
7582 * expression.cs (SizeOf.Resolve): Add location information.
7584 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7585 a managed type is declared.
7587 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7588 parameter modifiers as well. Fixes bug 38606
7590 * class.cs: Very sad. Am backing out the speed up changes
7591 introduced by the ArrayList -> Array in the TypeContainer, as they
7592 were not actually that much faster, and introduced a bug (no error
7593 reports on duplicated methods).
7595 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7596 source first, this will guarantee that we have a valid expression
7597 before calling in lower levels functions that will require a
7598 resolved object. Then use this original_source in the
7599 target.ResolveLValue instead of the original source that was
7602 Another change. Use target.Resolve instead of LValueResolve.
7603 Although we are resolving for LValues, we will let the Assign code
7604 take care of that (it will be called again from Resolve). This
7605 basically allows code like this:
7607 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7608 class Y { void A (X x) { x [0] += o; }
7610 The problem was that the indexer was trying to resolve for
7611 set_Item (idx, object o) and never finding one. The real set_Item
7612 was set_Item (idx, X). By delaying the process we get the right
7617 2003-02-23 Martin Baulig <martin@ximian.com>
7619 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7620 while calling DoEmit ().
7622 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7623 source files; if you use the #line directive inside a method, the
7624 compiler stops emitting line numbers for the debugger until it
7625 reaches the end of the method or another #line directive which
7626 restores the original file.
7628 2003-02-23 Martin Baulig <martin@ximian.com>
7630 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7632 2003-02-23 Martin Baulig <martin@ximian.com>
7634 * statement.cs (Block.AddChildVariableNames): We need to call this
7635 recursively, not just for our immediate children.
7637 2003-02-23 Martin Baulig <martin@ximian.com>
7639 * class.cs (Event.Define): Always make the field private, like csc does.
7641 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7642 actually work, fixes bug #37521.
7644 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7646 * delegate.cs: When creating the various temporary "Parameters"
7647 classes, make sure that we call the ComputeAndDefineParameterTypes
7648 on those new parameters (just like we do with the formal ones), to
7649 allow them to be resolved in the context of the DeclSpace.
7651 This fixes the bug that Dick observed in Bugzilla #38530.
7653 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7655 * expression.cs (ResolveMemberAccess): When resolving a constant,
7656 do not attempt to pull a constant if the value was not able to
7657 generate a valid constant.
7659 * const.cs (LookupConstantValue): Do not report more errors than required.
7661 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7663 * expression.cs: fixes bug #38328.
7665 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7667 * class.cs: Changed all the various members that can be part of a
7668 class from being an ArrayList to be an Array of the right type.
7669 During the DefineType type_list, interface_list, delegate_list and
7670 enum_list are turned into types, interfaces, delegates and enums
7673 And during the member population, indexer_list, event_list,
7674 constant_list, field_list, instance_constructor_list, method_list,
7675 operator_list and property_list are turned into their real arrays.
7677 Although we could probably perform this operation earlier, for
7678 good error reporting we need to keep the lists and remove the
7679 lists for longer than required.
7681 This optimization was triggered by Paolo profiling the compiler
7682 speed on the output of `gen-sample-program.pl' perl script.
7684 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7685 not crash in methods like MemberLookupFailed that use this field.
7687 This problem arises when the compiler fails to resolve a type
7688 during interface type definition for example.
7690 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7692 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7693 inherit from System.Object, so we have to stop at null, not only
7694 when reaching System.Object.
7696 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7698 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7699 DeclaredOnly because the parent indexer might have had a different
7700 name, but did not loop until the top of the hierarchy was reached.
7702 The problem this one fixes is 35492: when a class implemented an
7703 indexer from an interface, we were getting the interface method
7704 (which was abstract) and we were flagging an error (can not invoke
7707 This also keeps bug 33089 functioning, and test-148 functioning.
7709 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7710 out if a method is special is to see if it is declared in a
7711 property or event, or whether it is one of the predefined operator
7712 names. This should fix correctly #36804.
7714 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7716 The goal here is to remove the dependency on EmptyCast.Peel ().
7717 Killing it completely.
7719 The problem is that currently in a number of places where
7720 constants are expected, we have to "probe" for an EmptyCast, and
7721 Peel, which is not the correct thing to do, as this will be
7722 repetitive and will likely lead to errors.
7724 The idea is to remove any EmptyCasts that are used in casts that
7725 can be reduced to constants, so we only have to cope with
7728 This bug hunt was triggered by Bug 37363 and the desire to remove
7729 the duplicate pattern where we were "peeling" emptycasts to check
7730 whether they were constants. Now constants will always be
7733 * ecore.cs: Use an enumconstant here instead of wrapping with
7736 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7737 throwing me off. By handling this we can get rid of a few hacks.
7739 * statement.cs (Switch): Removed Peel() code.
7741 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7743 * class.cs: Location information for error 508
7745 * expression.cs (New.DoResolve): Add a guard against double
7746 resolution of an expression.
7748 The New DoResolve might be called twice when initializing field
7749 expressions (see EmitFieldInitializers, the call to
7750 GetInitializerExpression will perform a resolve on the expression,
7751 and later the assign will trigger another resolution
7753 This leads to bugs (#37014)
7755 * delegate.cs: The signature for EndInvoke should contain any ref
7756 or out parameters as well. We were not doing this in the past.
7758 * class.cs (Field.Define): Do not overwrite the type definition
7759 inside the `volatile' group. Turns out that volatile enumerations
7760 were changing the type here to perform a validity test, which
7763 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7765 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7766 and structs, we do not want to load the instance variable
7768 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7769 enum_type has to be handled like an object reference (implicit
7770 conversions exists from this to object), but the regular IsClass
7771 and IsValueType tests will never return true for this one.
7773 Also we use TypeManager.IsValueType instead of type.IsValueType,
7774 just for consistency with the rest of the code (this is only
7775 needed if we ever use the construct exposed by test-180.cs inside
7776 corlib, which we dont today).
7778 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7780 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7783 2003-02-09 Martin Baulig <martin@ximian.com>
7785 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7786 (Namespace.DefineNamespaces): New static public method; this is
7787 called when we're compiling with debugging to add all namespaces
7790 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7791 pass it to the Namespace's .ctor.
7793 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7794 and MethodBase arguments; pass the namespace ID to the symwriter;
7795 pass the MethodBase instead of the token to the symwriter.
7796 (SymbolWriter.DefineNamespace): New method to add a namespace to
7799 2003-02-09 Martin Baulig <martin@ximian.com>
7801 * symbolwriter.cs: New file. This is a wrapper around
7802 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7803 methods here in near future.
7805 2003-02-09 Martin Baulig <martin@ximian.com>
7807 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7808 ILGenerator.MarkSequencePoint() which are actually used by the
7811 2003-02-09 Martin Baulig <martin@ximian.com>
7813 * location.cs (SourceFile): New public sealed class. This
7814 contains the name and an index which is used in the location's token.
7815 (Location): Reserve an appropriate number of bits in the token for
7816 the source file instead of walking over that list, this gives us a
7817 really huge performance improvement when compiling with debugging.
7819 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7820 `SourceFile' argument instead of a string.
7821 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7822 but don't parse/tokenize here, we need to generate the list of all
7823 source files before we do that.
7824 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7827 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7828 instead of a string.
7830 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
7833 2003-02-09 Martin Baulig <martin@ximian.com>
7835 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
7836 filename on `#line default'.
7838 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
7840 * statement.cs: don't clear the pinned var when the fixed statement
7841 returns from the method (fixes bug#37752).
7843 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
7845 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
7848 2003-02-07 Martin Baulig <martin@ximian.com>
7850 * driver.cs: Removed the `--debug-args' command line argument.
7852 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
7853 automatically by the AsssemblyBuilder.
7854 (CodeGen.InitializeSymbolWriter): We don't need to call any
7855 initialization function on the symbol writer anymore. This method
7856 doesn't take any arguments.
7858 2003-02-03 Miguel de Icaza <miguel@ximian.com>
7860 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
7861 from referenced assemblies as well.
7863 2003-02-02 Martin Baulig <martin@ximian.com>
7865 * class.cs (MethodData.Emit): Generate debugging info for external methods.
7867 2003-02-02 Martin Baulig <martin@ximian.com>
7869 * class.cs (Constructor.Emit): Open the symbol writer before
7870 emitting the constructor initializer.
7871 (ConstructorInitializer.Emit): Call ec.Mark() to allow
7872 single-stepping through constructor initializers.
7874 2003-01-30 Miguel de Icaza <miguel@ximian.com>
7876 * class.cs: Handle error 549: do not allow virtual methods in
7879 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
7881 * decl.cs: Check access levels when resolving types
7883 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
7885 * statement.cs: Add parameters and locals set in catch blocks that might
7886 return to set vector
7888 2003-01-29 Miguel de Icaza <miguel@ximian.com>
7890 * class.cs (Operator): Set the SpecialName flags for operators.
7892 * expression.cs (Invocation.DoResolve): Only block calls to
7893 accessors and operators on SpecialName methods.
7895 (Cast.TryReduce): Handle conversions from char constants.
7898 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
7900 * statement.cs: small memory and time optimization in FlowBranching.
7902 2003-01-28 Pedro Mart <yoros@wanadoo.es>
7904 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
7905 problem that the last fix but in the other sid (Set).
7907 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
7908 access when there is no indexer in the hierarchy.
7910 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
7912 * class.cs: Combine some if statements.
7914 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7916 * driver.cs: fixed bug #37187.
7918 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
7920 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
7921 any indexer, it's needed to build a list with all the indexers in the
7922 hierarchy (AllGetters), else we have problems. Fixes #35653.
7924 2003-01-23 Miguel de Icaza <miguel@ximian.com>
7926 * class.cs (MethodData.Define): It is wrong for an interface
7927 implementation to be static in both cases: explicit and implicit.
7928 We were only handling this in one case.
7930 Improve the if situation there to not have negations.
7932 * class.cs (Field.Define): Turns out that we do not need to check
7933 the unsafe bit on field definition, only on usage. Remove the test.
7935 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7937 * driver.cs: use assembly.Location instead of Codebase (the latest
7938 patch made mcs fail when using MS assemblies).
7940 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
7942 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
7943 get the path to *corlib.dll.
7945 2003-01-21 Nick Drochak <ndrochak@gol.com>
7949 * typemanager.cs: Remove compiler warnings
7951 2003-01-20 Duncan Mak <duncan@ximian.com>
7953 * AssemblyInfo.cs: Bump the version number to 0.19.
7955 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7957 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
7959 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
7961 * class.cs (Constructor::Emit): Emit debugging info for constructors.
7963 2003-01-17 Miguel de Icaza <miguel@ximian.com>
7965 * cs-parser.jay: Small fix: we were not comparing the constructor
7966 name correctly. Thanks to Zoltan for the initial pointer.
7968 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
7970 * cs-tokenizer.cs: Set file name when specified with #line
7972 2003-01-15 Miguel de Icaza <miguel@ximian.com>
7974 * cs-parser.jay: Only perform the constructor checks here if we
7975 are named like the class; This will help provider a better
7976 error. The constructor path is taken when a type definition is
7977 not found, but most likely the user forgot to add the type, so
7978 report that rather than the constructor error.
7980 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
7982 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
7985 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7987 * cs-parser.jay: Add cleanup call.
7989 2003-01-13 Duncan Mak <duncan@ximian.com>
7991 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
7992 consistent with other methods.
7994 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7996 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
7998 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
8000 * attribute.cs: only set GuidAttr to true when we have a
8003 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8007 * typemanager.cs: fixes to allow mcs compile corlib with the new
8008 Type.IsSubclassOf fix.
8010 2003-01-08 Miguel de Icaza <miguel@ximian.com>
8012 * expression.cs (LocalVariableReference.DoResolve): Classify a
8013 constant as a value, not as a variable. Also, set the type for
8016 * cs-parser.jay (fixed_statement): take a type instead of a
8017 pointer_type, so we can produce a better error message later.
8019 * statement.cs (Fixed.Resolve): Flag types that are not pointers
8022 (For.DoEmit): Make inifinite loops have a
8023 non-conditional branch back.
8025 (Fixed.DoEmit): First populate the pinned variables, then emit the
8026 statement, then clear the variables. Before I was emitting the
8027 code once for each fixed piece.
8030 2003-01-08 Martin Baulig <martin@ximian.com>
8032 * statement.cs (FlowBranching.MergeChild): A break in a
8033 SWITCH_SECTION does not leave a loop. Fixes #36155.
8035 2003-01-08 Martin Baulig <martin@ximian.com>
8037 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
8038 lives in the same number space than `param_map'. Fixes #36154.
8040 2003-01-07 Miguel de Icaza <miguel@ximian.com>
8042 * cs-parser.jay (constructor_declaration): Set the
8043 Constructor.ModFlags before probing for it. This makes the
8044 compiler report 514, 515 and 132 (the code was there, but got
8047 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
8048 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
8049 (GotoCase.Resolve): Set `Returns' to ALWAYS.
8051 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
8053 * enum.cs: create the enum static fields using the enum type.
8055 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
8057 * class.cs: don't try to create the ParamBuilder for the return
8058 type if it's not needed (and handle it breaking for the ms runtime
8061 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
8063 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
8065 2002-12-29 Miguel de Icaza <miguel@ximian.com>
8067 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
8068 the command. This showed up while compiling the JANET source
8069 code, which used \r as its only newline separator.
8071 2002-12-28 Miguel de Icaza <miguel@ximian.com>
8073 * class.cs (Method.Define): If we are an operator (because it
8074 reuses our code), then set the SpecialName and HideBySig. #36128
8076 2002-12-22 Miguel de Icaza <miguel@ximian.com>
8078 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
8079 exception, report error 120 `object reference required'.
8081 * driver.cs: Add --pause option, used during to measure the size
8082 of the process as it goes with --timestamp.
8084 * expression.cs (Invocation.DoResolve): Do not allow methods with
8085 SpecialName to be invoked.
8087 2002-12-21 Miguel de Icaza <miguel@ximian.com>
8089 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
8090 number before adding it.
8092 2002-12-21 Ravi Pratap <ravi@ximian.com>
8094 * ecore.cs (StandardImplicitConversion): When in an unsafe
8095 context, we allow conversion between void * to any other pointer
8096 type. This fixes bug #35973.
8098 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
8100 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
8101 is not thrown when extensionless outputs are used
8103 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8105 * rootcontext.cs: fixed compilation of corlib.
8107 2002-12-19 Miguel de Icaza <miguel@ximian.com>
8109 * attribute.cs (Attributes.Contains): Add new method.
8111 * class.cs (MethodCore.LabelParameters): if the parameter is an
8112 `out' parameter, check that no attribute `[In]' has been passed.
8114 * enum.cs: Handle the `value__' name in an enumeration.
8116 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
8118 * decl.cs: Added special case to allow overrides on "protected
8121 2002-12-18 Ravi Pratap <ravi@ximian.com>
8123 * attribute.cs (Attributes.AddAttributeSection): Rename to this
8124 since it makes much more sense.
8126 (Attributes.ctor): Don't require a Location parameter.
8128 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
8130 * attribute.cs (ApplyAttributes): Remove extra Location parameters
8131 since we already have that information per attribute.
8133 * everywhere : make appropriate changes.
8135 * class.cs (LabelParameters): Write the code which actually
8136 applies attributes to the return type. We can't do this on the MS
8137 .NET runtime so we flag a warning in the case an exception is
8140 2002-12-18 Miguel de Icaza <miguel@ximian.com>
8142 * const.cs: Handle implicit null conversions here too.
8144 2002-12-17 Ravi Pratap <ravi@ximian.com>
8146 * class.cs (MethodCore.LabelParameters): Remove the extra
8147 Type [] parameter since it is completely unnecessary. Instead
8148 pass in the method's attributes so that we can extract
8149 the "return" attribute.
8151 2002-12-17 Miguel de Icaza <miguel@ximian.com>
8153 * cs-parser.jay (parse): Use Report.Error to flag errors instead
8154 of ignoring it and letting the compile continue.
8156 * typemanager.cs (ChangeType): use an extra argument to return an
8157 error condition instead of throwing an exception.
8159 2002-12-15 Miguel de Icaza <miguel@ximian.com>
8161 * expression.cs (Unary.TryReduce): mimic the code for the regular
8162 code path. Perform an implicit cast in the cases where we can
8163 implicitly convert to one of the integral types, and then reduce
8164 based on that constant. This fixes bug #35483.
8166 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8168 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
8170 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8172 * namespace.cs: fixed bug #35489.
8174 2002-12-12 Miguel de Icaza <miguel@ximian.com>
8176 * class.cs: Remove some dead code.
8178 * cs-parser.jay: Estimate the number of methods needed
8179 (RootContext.MethodCount);
8181 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
8182 numbers instead of StringBuilders.
8184 * support.cs (PtrHashtable): Add constructor with initial size;
8185 We can now reduce reallocations of the method table.
8187 2002-12-10 Ravi Pratap <ravi@ximian.com>
8189 * attribute.cs (ApplyAttributes): Keep track of the emitted
8190 attributes on a per-target basis. This fixes bug #35413.
8192 2002-12-10 Miguel de Icaza <miguel@ximian.com>
8194 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
8195 default to the Windows 1252 encoding.
8197 (UnixParseOption): Support version, thanks to Alp for the missing
8200 * AssemblyInfo.cs: Add nice assembly information.
8202 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
8205 * cs-parser.jay: Allow a trailing comma before the close bracked
8206 in the attribute_section production.
8208 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
8209 address of the instance was being taken, I will take this out,
8210 because we take the address of the object immediately here.
8212 2002-12-09 Ravi Pratap <ravi@ximian.com>
8214 * typemanager.cs (AreMultipleAllowed): Take care of the most
8215 obvious case where attribute type is not in the current assembly -
8218 2002-12-08 Miguel de Icaza <miguel@ximian.com>
8220 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
8221 definitions, instead of doing that afterwards.
8223 Also we use a nice little hack, depending on the constructor, we
8224 know if we are a "composed" name or a simple name. Hence, we
8225 avoid the IndexOf test, and we avoid
8227 * codegen.cs: Add code to assist in a bug reporter to track down
8228 the source of a compiler crash.
8230 2002-12-07 Ravi Pratap <ravi@ximian.com>
8232 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
8233 types have been emitted for a given element and flag an error
8234 if something which does not have AllowMultiple set is used more
8237 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
8238 attribute types and their corresponding AllowMultiple properties
8240 (AreMultipleAllowed): Check the property for a given type.
8242 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
8243 property in the case we have a TypeContainer.
8245 (Attributes.AddAttribute): Detect duplicates and just skip on
8246 adding them. This trivial fix catches a pretty gross error in our
8247 attribute emission - global attributes were being emitted twice!
8249 Bugzilla bug #33187 is now fixed.
8251 2002-12-06 Miguel de Icaza <miguel@ximian.com>
8253 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
8256 * expression.cs (Binary.ResolveOperator): I can only use the
8257 Concat (string, string, string) and Concat (string, string,
8258 string, string) if the child is actually a concatenation of
8261 2002-12-04 Miguel de Icaza <miguel@ximian.com>
8263 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
8264 context where we need a 2-character lookahead.
8266 * pending.cs (PendingImplementation): Rework so we can keep track
8267 of interface types all the time, and flag those which were
8268 implemented by parents as optional.
8270 2002-12-03 Miguel de Icaza <miguel@ximian.com>
8272 * expression.cs (Binary.ResolveOperator): Use
8273 String.Concat(string,string,string) or
8274 String.Concat(string,string,string,string) when possible.
8276 * typemanager: More helper methods.
8279 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
8281 * pending.cs: remove the bogus return from GetMissingInterfaces()
8282 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
8284 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8286 * namespace.cs: avoid duplicated 'using xxx' being added to
8287 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
8288 when we get more than one 'using' statement for the same namespace.
8289 Report a CS0105 warning for it.
8291 2002-11-30 Miguel de Icaza <miguel@ximian.com>
8293 * cs-tokenizer.cs (consume_identifier): use read directly, instead
8294 of calling getChar/putback, uses internal knowledge of it.
8296 (xtoken): Reorder tokenizer so most common patterns are checked
8297 first. This reduces the compilation time in another 5% (from 8.11s
8298 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
8300 The parsing time is 22% of the compilation in mcs, and from that
8301 64% is spent on the tokenization process.
8303 I tried using a binary search for keywords, but this is slower
8304 than the hashtable. Another option would be to do a couple of
8307 * Not use a StringBuilder, instead use an array of chars,
8308 with a set value. Notice that this way we could catch
8309 the 645 error without having to do it *afterwards*.
8311 * We could write a hand-parser to avoid the hashtable
8312 compares altogether.
8314 The identifier consumption process takes 37% of the tokenization
8315 time. Another 15% is spent on is_number. 56% of the time spent
8316 on is_number is spent on Int64.Parse:
8318 * We could probably choose based on the string length to
8319 use Int32.Parse or Int64.Parse and avoid all the 64-bit
8322 Another 3% is spend on wrapping `xtoken' in the `token' function.
8324 Handle 0xa0 as whitespace (#34752)
8326 2002-11-26 Miguel de Icaza <miguel@ximian.com>
8328 * typemanager.cs (IsCLRType): New routine to tell whether a type
8329 is one of the builtin types.
8331 Maybe it needs to use TypeCodes to be faster. Maybe we could use
8332 typecode in more places instead of doing pointer comparissions.
8333 We could leverage some knowledge about the way the typecodes are
8336 New code to cache namespaces in assemblies, it is currently not
8337 invoked, to be used soon.
8339 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
8341 * expression.cs (Binary.ResolveOperator): specially handle
8342 strings, and do not perform user-defined operator overloading for
8345 2002-11-24 Miguel de Icaza <miguel@ximian.com>
8347 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
8348 internalcall as it is a pretty simple operation; Avoid whenever
8349 possible to call Char.IsLetter.
8351 (consume_identifier): Cut by half the number of
8352 hashtable calls by merging the is_keyword and GetKeyword behavior.
8354 Do not short-circuit, because if we do, we
8355 report errors (ie, #if false && true would produce an invalid
8359 2002-11-24 Martin Baulig <martin@ximian.com>
8361 * expression.cs (Cast.TryReduce): If we're in checked syntax,
8362 check constant ranges and report a CS0221. Fixes #33186.
8364 2002-11-24 Martin Baulig <martin@ximian.com>
8366 * cs-parser.jay: Make this work for uninitialized variable
8367 declarations in the `for' initializer. Fixes #32416.
8369 2002-11-24 Martin Baulig <martin@ximian.com>
8371 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
8372 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
8374 2002-11-24 Martin Baulig <martin@ximian.com>
8376 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
8377 argument; if true, we also check for user-defined conversions.
8378 This is only needed if both arguments are of a user-defined type.
8379 Fixes #30443, added test-175.cs.
8380 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
8382 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
8384 2002-11-24 Martin Baulig <martin@ximian.com>
8386 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
8387 function to get the store opcode.
8388 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
8389 only emit the Ldelema if the store opcode is Stobj. You must run
8390 both test-34 and test-167 to test this. Fixes #34529.
8392 2002-11-23 Martin Baulig <martin@ximian.com>
8394 * ecore.cs (Expression.MemberLookup): Added additional
8395 `qualifier_type' argument which is used when we're being called
8396 from MemberAccess.DoResolve() and null if we're called from a
8398 (Expression.MemberLookupFailed): New method to report errors; this
8399 does the CS1540 check and reports the correct error message.
8401 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
8402 argument for the CS1540 check and redone the way how we're dealing
8403 with private members. See the comment in the source code for details.
8404 (FilterWithClosure): Reverted this back to revision 1.197; renamed
8405 `closure_start_type' to `closure_qualifier_type' and check whether
8406 it's not null. It was not this filter being broken, it was just
8407 being called with the wrong arguments.
8409 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
8410 and pass it the correct `qualifier_type'; this also does the error
8413 2002-11-22 Miguel de Icaza <miguel@ximian.com>
8415 * expression.cs (Invocation.EmitParams): If the we are dealing
8416 with a non-built-in value type, load its address as well.
8418 (ArrayCreation): Use a a pretty constant instead
8419 of the hardcoded value 2. Use 6 instead of 2 for the number of
8420 static initializers.
8422 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
8423 because they are not really value types, just glorified integers.
8425 * driver.cs: Do not append .exe, the CSC compiler does not do it.
8427 * ecore.cs: Remove redundant code for enumerations, make them use
8428 the same code path as everything else, fixes the casting issue
8429 with enumerations in Windows.Forms.
8431 * attribute.cs: Do only cast to string if it is a string, the
8432 validation happens later.
8434 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
8435 people upgrade their corlibs.
8437 * ecore.cs: Oops, enumerations were not following the entire code path
8439 2002-11-21 Miguel de Icaza <miguel@ximian.com>
8441 * typemanager.cs (FilterWithClosure): Commented out the test for
8442 1540 in typemanager.cs, as it has problems when accessing
8443 protected methods from a parent class (see test-174.cs).
8445 * attribute.cs (Attribute.ValidateGuid): new method.
8446 (Attribute.Resolve): Use above.
8448 2002-11-19 Miguel de Icaza <miguel@ximian.com>
8450 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
8452 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
8453 handling for enumerations, as we only needed the TypeContainer
8454 functionality to begin with (this is required for the fix below to
8455 work for enums that reference constants in a container class for
8458 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
8460 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
8461 a valid TypeBuilder to perform lookups on.o
8463 * class.cs (InheritableMemberSignatureCompare): Use true in the
8464 call to GetGetMethod and GetSetMethod, because we are comparing
8465 the signature, and we need to get the methods *even* if they are
8468 (PropertyBase.CheckBase): ditto.
8470 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
8471 GotoCase.Resolve): Use Peel on EmpytCasts.
8473 * ecore.cs (EmptyCast): drop child, add Peel method.
8475 2002-11-17 Martin Baulig <martin@ximian.com>
8477 * ecore.cs (EmptyCast.Child): New public property.
8479 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
8480 label resolved to an EmptyCast. Fixes #34162.
8481 (GotoCase.Resolve): Likewise.
8482 (Block.EmitMeta): Likewise.
8484 2002-11-17 Martin Baulig <martin@ximian.com>
8486 * expression.cs (Invocation.BetterConversion): Prefer int over
8487 uint; short over ushort; long over ulong for integer literals.
8488 Use ImplicitConversionExists instead of StandardConversionExists
8489 since we also need to check for user-defined implicit conversions.
8490 Fixes #34165. Added test-173.cs.
8492 2002-11-16 Martin Baulig <martin@ximian.com>
8494 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8495 with the `true' and `false' literals. Fixes #33151.
8497 2002-11-16 Martin Baulig <martin@ximian.com>
8499 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8500 October 22nd; don't do the cs1540 check for static members.
8502 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8503 now using our own filter here and doing the cs1540 check again.
8505 2002-11-16 Martin Baulig <martin@ximian.com>
8507 * support.cs (InternalParameters): Don't crash if we don't have
8508 any fixed parameters. Fixes #33532.
8510 2002-11-16 Martin Baulig <martin@ximian.com>
8512 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8513 when looking up static methods to make this work on Windows.
8516 2002-11-16 Martin Baulig <martin@ximian.com>
8518 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8519 a setter rather than using PropertyInfo.CanWrite.
8521 2002-11-15 Nick Drochak <ndrochak@gol.com>
8523 * class.cs: Allow acces to block member by subclasses. Fixes build
8526 2002-11-14 Martin Baulig <martin@ximian.com>
8528 * class.cs (Constructor.Emit): Added the extern/block check.
8531 2002-11-14 Martin Baulig <martin@ximian.com>
8533 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8534 iteration while looking for indexers, this is needed because the
8535 indexer may have a different name in our base classes. Fixed the
8536 error reporting (no indexers at all, not get accessor, no
8537 overloaded match). Fixes bug #33089.
8538 (IndexerAccess.DoResolveLValue): Likewise.
8540 2002-11-14 Martin Baulig <martin@ximian.com>
8542 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8543 indexers. Fixes the first part of bug #33089.
8544 (MethodSignature.InheritableMemberSignatureCompare): Added support
8547 2002-11-13 Ravi Pratap <ravi@ximian.com>
8549 * attribute.cs (Attribute.Resolve): Catch the
8550 NullReferenceException and report it since it isn't supposed to
8553 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8555 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8556 LogicalOr and LogicalAnd that can benefit from recursively
8557 handling EmitBranchable. The code now should be nice for Paolo.
8559 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8561 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8562 the Type lookups, as we perform quite a number of lookups on
8563 non-Types. This can be removed once we can deterministically tell
8564 whether we have a type or a namespace in advance.
8566 But this might require special hacks from our corlib.
8570 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8571 and double which avoids a conversion from an integer to a double.
8573 * expression.cs: tiny optimization, avoid calling IsConstant,
8574 because it effectively performs the lookup twice.
8576 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8578 But a bogus return here to keep the semantics of the old code
8579 until the Mono runtime is fixed.
8581 * pending.cs (GetMissingInterfaces): New method used to remove all
8582 the interfaces that are already implemented by our parent
8583 classes from the list of pending methods.
8585 * interface.cs: Add checks for calls after ResolveTypeExpr.
8587 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8589 * class.cs (Class.Emit): Report warning 67: event not used if the
8590 warning level is beyond 3.
8592 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8593 being a NullLiteral.
8595 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8598 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8599 path that might fail if a type can not be resolved.
8601 * expression.cs (Binary.Emit): Emit unsigned versions of the
8604 * driver.cs: use error 5.
8606 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8608 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8610 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8612 * cs-parser.jay (switch_section): A beautiful patch from Martin
8613 Baulig that fixed 33094.
8615 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8617 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8618 Check whether the base is abstract and report an error if so.
8620 * expression.cs (IndexerAccess.DoResolveLValue,
8621 IndexerAccess.DoResolve): ditto.
8623 (Invocation.DoResolve): ditto.
8625 (Invocation.FullMethodDesc): Improve the report string.
8627 * statement.cs (Block): Eliminate IsVariableDefined as it is
8628 basically just a wrapper for GetVariableInfo.
8630 * ecore.cs (SimpleName): Use new
8632 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8633 type, as we return the actual parameter ref/unref state on a
8636 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8638 * support.cs: Return proper flags REF/OUT fixing the previous
8641 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8642 not used to mean `ref' but `ref or out' in ParameterReference
8644 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8645 full type signature instead of calling TypeManger.CSharpName
8648 * support.cs (InternalParameters.ParameterDesc): Do not compare
8649 directly to the modflags, because REF/OUT will actually be bitsets
8652 * delegate.cs (VerifyMethod): Check also the modifiers.
8654 * cs-tokenizer.cs: Fix bug where floating point values with an
8655 exponent where a sign was missing was ignored.
8657 * driver.cs: Allow multiple assemblies to be specified in a single
8660 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8662 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8663 because identifiers after a parenthesis would end up in this kind
8664 of production, and we needed to desamiguate it for having casts
8667 (UserDefinedType *) xxx
8669 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8671 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8672 we should set on the Bindingflags.NonPublic, but not turn on
8673 private_ok. private_ok controls whether a Private member is
8674 returned (this is chekced on the filter routine), while the
8675 BindingFlags.NonPublic just controls whether private/protected
8676 will be allowed. This fixes the problem part of the problem of
8677 private properties being allowed to be used in derived classes.
8679 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8680 so we can call the children DoResolveLValue method (this will
8681 properly signal errors on lvalue assignments to base properties)
8683 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8684 getter are null, and we have a property info, we know that this
8685 happened because the lookup failed, so we report an error 122 for
8686 protection level violation.
8688 We also silently return if setter and getter are null in the
8689 resolve functions, this condition only happens if we have flagged
8690 the error before. This is the other half of the problem.
8692 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8693 not have accessibility information, that is why we were returning
8694 true in the filter function in typemanager.cs.
8696 To properly report 122 (property is inaccessible because of its
8697 protection level) correctly, we report this error in ResolveAccess
8698 by failing if both the setter and the getter are lacking (ie, the
8701 DoResolve and DoLResolve have been modified to check for both
8702 setter/getter being null and returning silently, the reason being
8703 that I did not want to put the knowledge about this error in upper
8706 int old = Report.Errors;
8707 x = new PropertyExpr (...);
8708 if (old != Report.Errors)
8713 So the property expr is returned, but it is invalid, so the error
8714 will be flagged during the resolve process.
8716 * class.cs: Remove InheritablePropertySignatureCompare from the
8717 class, as we no longer depend on the property signature to compute
8718 whether it is possible to implement a method or not.
8720 The reason is that calling PropertyInfo.GetGetMethod will return
8721 null (in .NET, in Mono it works, and we should change this), in
8722 cases where the Get Method does not exist in that particular
8727 class X { public virtual int A { get { return 1; } } }
8729 class Z : Y { public override int A { get { return 2; } } }
8731 Would fail in Z because the parent (Y) would not have the property
8732 defined. So we avoid this completely now (because the alternative
8733 fix was ugly and slow), and we now depend exclusively on the
8736 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8737 reference method, instead of using the property.
8739 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8740 routines are gone now.
8742 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8743 names, they were incorrectly named.
8745 * cs-tokenizer.cs: Return are more gentle token on failure.
8747 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8748 had an out-of-sync index variable, which caused it to remove from
8749 the list of pending methods the wrong method sometimes.
8751 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8753 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8754 CanWrite, because those refer to this particular instance of the
8755 property, and do not take into account the fact that we can
8756 override single members of a property.
8758 Constructor requires an EmitContext. The resolution process does
8759 not happen here, but we need to compute the accessors before,
8760 because the resolution does not always happen for properties.
8762 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8763 subclass, before we did not update this flag, but we did update
8766 (GetAccessors): Drop this routine, as it did not work in the
8767 presence of partially overwritten set/get methods.
8769 Notice that this broke the cs1540 detection, but that will require
8772 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8776 * driver.cs: issue a warning instead of an error if we don't support
8777 debugging for the platform. Also ignore a couple of errors that may
8778 arise when trying to write the symbols. Undo my previous patch.
8780 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8782 * driver.cs: ignore /debug switch except for Unix platforms.
8784 2002-10-23 Nick Drochak <ndrochak@gol.com>
8786 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8788 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8790 * driver.cs: Do not make mcs-debug conditional, so we do not break
8793 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8794 review this patch. But basically after all the children variables
8795 have been merged, the value of "Breaks" was not being set to
8796 new_breaks for Switch blocks. I think that it should be set after
8797 it has executed. Currently I set this to the value of new_breaks,
8798 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8799 conservative, but I do not understand this code very well.
8801 I did not break anything in the build, so that is good ;-)
8803 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8805 2002-10-20 Mark Crichton <crichton@gimp.org>
8807 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8809 2002-10-20 Nick Drochak <ndrochak@gol.com>
8811 * cfold.cs: Fixed compile blocker.
8813 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8815 * driver.cs: I was chekcing the key, not the file.
8817 2002-10-19 Ravi Pratap <ravi@ximian.com>
8819 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8820 message that we were generating - we just need to silently return
8823 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8825 * class.cs (Event.Define): Change my previous commit, as this
8826 breaks the debugger. This is a temporary hack, as it seems like
8827 the compiler is generating events incorrectly to begin with.
8829 * expression.cs (Binary.ResolveOperator): Added support for
8830 "U operator - (E x, E y)"
8832 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
8835 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
8836 init-only variables, but this path did not take into account that
8837 there might be also instance readonly variables. Correct this
8840 This fixes bug 32253
8842 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
8845 * driver.cs: Change the extension for modules to `netmodule'
8847 * cs-parser.jay: Improved slightly the location tracking for
8848 the debugger symbols.
8850 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
8851 modifiers that were specified instead of the hardcoded value
8852 (FamAndAssem). This was basically ignoring the static modifier,
8853 and others. Fixes 32429.
8855 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
8856 fixed a bug in the process (32476)
8858 * expression.cs (ArrayAccess.EmitAssign): Patch from
8859 hwang_rob@yahoo.ca that fixes bug 31834.3
8861 2002-10-18 Miguel de Icaza <miguel@ximian.com>
8863 * driver.cs: Make the module extension .netmodule.
8865 2002-10-16 Miguel de Icaza <miguel@ximian.com>
8867 * driver.cs: Report an error if the resource file is not found
8868 instead of crashing.
8870 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
8871 false, like Emit does.
8873 2002-10-16 Nick Drochak <ndrochak@gol.com>
8875 * typemanager.cs: Remove unused private member. Also reported mcs
8876 bug to report this as a warning like csc.
8878 2002-10-15 Martin Baulig <martin@gnome.org>
8880 * statement.cs (Statement.Emit): Made this a virtual method; emits
8881 the line number info and calls DoEmit().
8882 (Statement.DoEmit): New protected abstract method, formerly knows
8883 as Statement.Emit().
8885 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
8887 2002-10-11 Miguel de Icaza <miguel@ximian.com>
8889 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
8890 have fixed a remaining problem: not every AddXXXX was adding a
8891 fully qualified name.
8893 Now everyone registers a fully qualified name in the DeclSpace as
8894 being defined instead of the partial name.
8896 Downsides: we are slower than we need to be due to the excess
8897 copies and the names being registered this way.
8899 The reason for this is that we currently depend (on the corlib
8900 bootstrap for instance) that types are fully qualified, because
8901 we dump all the types in the namespace, and we should really have
8902 types inserted into the proper namespace, so we can only store the
8903 basenames in the defined_names array.
8905 2002-10-10 Martin Baulig <martin@gnome.org>
8907 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
8908 from bug #31834, see the bug report for a testcase which is
8911 2002-10-10 Martin Baulig <martin@gnome.org>
8913 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
8914 flow analysis code for this.
8916 * statement.cs (Do, While, For): Tell the flow analysis code about
8918 (FlowBranching.UsageVector): Added support for infinite loops.
8919 (Block.Resolve): Moved the dead code elimination here and use flow
8922 2002-10-09 Miguel de Icaza <miguel@ximian.com>
8924 * class.cs (Field.Define): Catch cycles on struct type
8927 * typemanager.cs (IsUnmanagedtype): Do not recursively check
8928 fields if the fields are static. We only need to check instance
8931 * expression.cs (As.DoResolve): Test for reference type.
8933 * statement.cs (Using.ResolveExpression): Use
8934 ConvertImplicitRequired, not ConvertImplicit which reports an
8936 (Using.ResolveLocalVariableDecls): ditto.
8938 * expression.cs (Binary.ResolveOperator): Report errors in a few
8939 places where we had to.
8941 * typemanager.cs (IsUnmanagedtype): Finish implementation.
8943 2002-10-08 Miguel de Icaza <miguel@ximian.com>
8945 * expression.cs: Use StoreFromPtr instead of extracting the type
8946 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
8948 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
8949 an enumeration value to a System.Enum, but System.Enum is not a
8950 value type, but an class type, so we need to box.
8952 (Expression.ConvertExplicit): One codepath could return
8953 errors but not flag them. Fix this. Fixes #31853
8955 * parameter.cs (Resolve): Do not allow void as a parameter type.
8957 2002-10-06 Martin Baulig <martin@gnome.org>
8959 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
8960 if it's a class type and not a struct. Fixes #31815.
8962 2002-10-06 Martin Baulig <martin@gnome.org>
8964 * statement.cs: Reworked the flow analysis code a bit to make it
8965 usable for dead code elimination.
8967 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8969 * cs-parser.jay: allow empty source files. Fixes bug #31781.
8971 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8973 * expression.cs (ComposedCast.DoResolveType): A quick workaround
8974 to fix the test 165, will investigate deeper.
8976 2002-10-04 Martin Baulig <martin@gnome.org>
8978 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
8979 finally blocks actually work.
8980 (Try.Resolve): We don't need to create a sibling for `finally' if
8981 there is no finally block.
8983 2002-10-04 Martin Baulig <martin@gnome.org>
8985 * class.cs (Constructor.Define): The default accessibility for a
8986 non-default constructor is private, not public.
8988 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8990 * class.cs (Constructor): Make AllowedModifiers public, add
8993 * cs-parser.jay: Perform the modifiers test here, as the
8994 constructor for the Constructor class usually receives a zero
8995 because of the way we create it (first we create, later we
8996 customize, and we were never checking the modifiers).
8998 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
8999 is a version of LookupTypeReflection that includes the type-name
9000 cache. This can be used as a fast path for functions that know
9001 the fully qualified name and are only calling into *.GetType() to
9002 obtain a composed type.
9004 This is also used by TypeManager.LookupType during its type
9007 (LookupType): We now also track the real type name, as sometimes
9008 we can get a quey for the real type name from things like
9009 ComposedCast. This fixes bug 31422.
9011 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
9012 complete type fullname, it does not have to go through the type
9013 resolution system to obtain the composed version of the type (for
9014 obtaining arrays or pointers).
9016 (Conditional.Emit): Use the EmitBoolExpression to
9017 generate nicer code, as requested by Paolo.
9019 (ArrayCreation.CheckIndices): Use the patch from
9020 hwang_rob@yahoo.ca to validate the array initializers.
9022 2002-10-03 Miguel de Icaza <miguel@ximian.com>
9024 * class.cs (ConstructorInitializer.Emit): simplify code by using
9025 Invocation.EmitCall, and at the same time, fix the bugs in calling
9026 parent constructors that took variable arguments.
9028 * ecore.cs (Expression.ConvertNumericExplicit,
9029 Expression.ImplicitNumericConversion): Remove the code that
9030 manually wrapped decimal (InternalTypeConstructor call is now gone
9033 * expression.cs (Cast.TryReduce): Also handle decimal types when
9034 trying to perform a constant fold on the type.
9036 * typemanager.cs (IsUnmanagedtype): Partially implemented.
9038 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
9039 that only turned off an error report, and did nothing else.
9041 2002-10-02 Miguel de Icaza <miguel@ximian.com>
9043 * driver.cs: Handle and ignore /fullpaths
9045 2002-10-01 Miguel de Icaza <miguel@ximian.com>
9047 * expression.cs (Binary.ResolveOperator): Catch the case where
9048 DoNumericPromotions returns true,
9050 (Binary.DoNumericPromotions): Simplify the code, and the tests.
9052 2002-09-27 Miguel de Icaza <miguel@ximian.com>
9054 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
9057 2002-09-26 Miguel de Icaza <miguel@ximian.com>
9059 * ecore.cs (ConvertNumericExplicit): It is not enough that the
9060 conversion exists, but it is also required that the conversion be
9061 performed. This manifested in "(Type64Enum) 2".
9063 * class.cs (TypeManager.AddMethod): The fix is not to change
9064 AddEnum, because that one was using a fully qualified name (every
9065 DeclSpace derivative does), but to change the AddMethod routine
9066 that was using an un-namespaced name. This now correctly reports
9067 the duplicated name.
9069 Revert patch until I can properly fix it. The issue
9070 is that we have a shared Type space across all namespaces
9071 currently, which is wrong.
9073 Options include making the Namespace a DeclSpace, and merge
9074 current_namespace/current_container in the parser.
9076 2002-09-25 Miguel de Icaza <miguel@ximian.com>
9078 * cs-parser.jay: Improve error reporting when we get a different
9079 kind of expression in local_variable_type and
9080 local_variable_pointer_type.
9082 Propagate this to avoid missleading errors being reported.
9084 * ecore.cs (ImplicitReferenceConversion): treat
9085 TypeManager.value_type as a target just like object_type. As
9090 Is valid, and needs to result in the int 1 being boxed before it
9091 is assigned to the value type v.
9093 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
9094 to validate the enumeration name.
9096 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
9097 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
9098 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
9100 * ecore.cs (TryImplicitIntConversion): When doing an
9101 implicit-enumeration-conversion, check if the type is 64-bits and
9102 perform a conversion before passing to EnumConstant.
9104 2002-09-23 Miguel de Icaza <miguel@ximian.com>
9106 * decl.cs (Error_AmbiguousTypeReference); New routine used to
9107 report ambiguous type references. Unlike the MS version, we
9108 report what the ambiguity is. Innovation at work ;-)
9110 (DeclSpace.FindType): Require a location argument to
9111 display when we display an ambiguous error.
9113 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
9115 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
9117 * expression.cs (EmitDynamicInitializers): Apply patch from
9118 hwang_rob@yahoo.ca that fixes the order in which we emit our
9121 2002-09-21 Martin Baulig <martin@gnome.org>
9123 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
9124 delegate takes no arguments.
9126 2002-09-20 Miguel de Icaza <miguel@ximian.com>
9128 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
9131 * expression.cs: Extract the underlying type.
9133 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
9135 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
9137 2002-09-19 Miguel de Icaza <miguel@ximian.com>
9139 * class.cs (TypeContainer.DefineType): We can not use the nice
9140 PackingSize with the size set to 1 DefineType method, because it
9141 will not allow us to define the interfaces that the struct
9144 This completes the fixing of bug 27287
9146 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
9147 means also structs. This fixes part of the problem.
9148 (Expresion.ImplicitReferenceConversionExists): ditto.
9150 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
9151 error if there were no errors reported during the type lookup
9152 process, to avoid duplicates or redundant errors. Without this
9153 you would get an ambiguous errors plus a type not found. We have
9154 beaten the user enough with the first error.
9156 (DeclSparce.FindType): Emit a warning if we have an ambiguous
9159 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
9160 during the resolution process, stop the lookup, this avoids
9161 repeated error reports (same error twice).
9163 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
9165 * typemanager.cs (LookupType): Redo the type lookup code to match
9166 the needs of System.Reflection.
9168 The issue is that System.Reflection requires references to nested
9169 types to begin with a "+" sign instead of a dot. So toplevel
9170 types look like: "NameSpace.TopLevelClass", and nested ones look
9171 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
9174 2002-09-19 Martin Baulig <martin@gnome.org>
9176 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
9177 says that a method always returns or always throws an exception,
9178 don't report the CS0161.
9180 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
9181 set `Returns = new_returns'.
9183 2002-09-19 Martin Baulig <martin@gnome.org>
9185 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
9186 to an enum constant, check for a CS0176.
9188 2002-09-18 Miguel de Icaza <miguel@ximian.com>
9190 * class.cs (TypeContainer.CheckPairedOperators): Now we check
9191 for operators that must be in pairs and report errors.
9193 * ecore.cs (SimpleName.DoResolveType): During the initial type
9194 resolution process, when we define types recursively, we must
9195 check first for types in our current scope before we perform
9196 lookups in the enclosing scopes.
9198 * expression.cs (MakeByteBlob): Handle Decimal blobs.
9200 (Invocation.VerifyArgumentsCompat): Call
9201 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
9202 I thought we were supposed to always call this, but there are a
9203 few places in the code where we dont do it.
9205 2002-09-17 Miguel de Icaza <miguel@ximian.com>
9207 * driver.cs: Add support in -linkres and -resource to specify the
9208 name of the identifier.
9210 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9212 * ecore.cs (StandardConversionExists): Sync with the conversion
9213 code: allow anything-* to void* conversions.
9215 (FindMostSpecificSource): Use an Expression argument
9216 instead of a Type, because we might be handed over a Literal which
9217 gets a few more implicit conversions that plain types do not. So
9218 this information was being lost.
9220 Also, we drop the temporary type-holder expression when not
9223 2002-09-17 Martin Baulig <martin@gnome.org>
9225 * class.cs (PropertyBase.CheckBase): Don't check the base class if
9226 this is an explicit interface implementation.
9228 2002-09-17 Martin Baulig <martin@gnome.org>
9230 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
9231 different `IndexerName' attributes.
9233 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
9234 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
9235 virtual CommonResolve().
9237 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9239 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
9240 and convert that to the UnderlyingType.
9242 * statement.cs (Foreach.Resolve): Indexers are just like variables
9243 or PropertyAccesses.
9245 * cs-tokenizer.cs (consume_string): Track line numbers and columns
9246 inside quoted strings, we were not doing this before.
9248 2002-09-16 Martin Baulig <martin@gnome.org>
9250 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
9251 resolve it. This is needed for the definite assignment check of the
9252 instance expression, fixes bug #29846.
9253 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
9255 2002-09-16 Nick Drochak <ndrochak@gol.com>
9257 * parameter.cs: Fix compile error. Cannot reference static member
9258 from an instance object. Is this an mcs bug?
9260 2002-09-14 Martin Baulig <martin@gnome.org>
9262 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
9263 multiple times. Fixes bug #30295, added test-166.cs.
9265 2002-09-14 Martin Baulig <martin@gnome.org>
9267 * statement.cs (Block.Emit): Don't emit unreachable code.
9268 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
9270 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
9272 2002-09-14 Martin Baulig <martin@gnome.org>
9274 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
9277 2002-09-14 Martin Baulig <martin@gnome.org>
9279 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
9280 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
9281 be false on the ms runtime.
9283 2002-09-13 Martin Baulig <martin@gnome.org>
9285 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
9286 the CS0038 error message.
9288 2002-09-12 Miguel de Icaza <miguel@ximian.com>
9290 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
9291 constant inside, return it.
9293 2002-09-12 Martin Baulig <martin@gnome.org>
9295 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
9296 implicit conversion can be done between enum types.
9298 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
9299 check whether an implicit conversion to the current enum's UnderlyingType
9300 exists and report an error if not.
9302 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
9303 without debugging support.
9305 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
9306 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
9308 2002-09-12 Martin Baulig <martin@gnome.org>
9310 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
9312 * ecore.cs (IMemberExpr.DeclaringType): New property.
9313 (SimpleName.SimpleNameResolve): Check whether we're accessing a
9314 nonstatic member of an outer type (CS0038).
9316 2002-09-11 Miguel de Icaza <miguel@ximian.com>
9318 * driver.cs: Activate the using-error detector at warning level
9319 4 (at least for MS-compatible APIs).
9321 * namespace.cs (VerifyUsing): Small buglett fix.
9323 * pending.cs (PendingImplementation): pass the container pointer.
9325 * interface.cs (GetMethods): Allow for recursive definition. Long
9326 term, I would like to move every type to support recursive
9327 definitions, not the current ordering mechanism that we have right
9330 The situation is this: Attributes are handled before interfaces,
9331 so we can apply attributes to interfaces. But some attributes
9332 implement interfaces, we will now handle the simple cases
9333 (recursive definitions will just get an error).
9335 * parameter.cs: Only invalidate types at the end if we fail to
9338 2002-09-09 Martin Baulig <martin@gnome.org>
9340 * ecore.cs (PropertyExpr.Emit): Also check for
9341 TypeManager.system_int_array_get_length so this'll also work when
9342 compiling corlib. Fixes #30003.
9344 2002-09-09 Martin Baulig <martin@gnome.org>
9346 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
9347 and throw an exception if we can't get the type's size. Fixed #30040,
9350 2002-09-09 Martin Baulig <martin@gnome.org>
9352 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
9354 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
9355 context. Fixes bug #30027.
9357 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
9358 virtual functions. Fixes bug #30043, added test-164.cs.
9360 2002-09-08 Ravi Pratap <ravi@ximian.com>
9362 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
9364 2002-09-08 Nick Drochak <ndrochak@gol.com>
9366 * driver.cs: Use an object to get the windows codepage since it's not a
9369 2002-09-08 Miguel de Icaza <miguel@ximian.com>
9371 * statement.cs (For.Emit): for infinite loops (test == null)
9372 return whether there is a break inside, not always "true".
9374 * namespace.cs (UsingEntry): New struct to hold the name of the
9375 using definition, the location where it is defined, and whether it
9376 has been used in a successful type lookup.
9378 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
9383 2002-09-06 Ravi Pratap <ravi@ximian.com>
9385 * attribute.cs : Fix incorrect code which relied on catching
9386 a NullReferenceException to detect a null being passed in
9387 where an object was expected.
9389 2002-09-06 Miguel de Icaza <miguel@ximian.com>
9391 * statement.cs (Try): flag the catch variable as assigned
9393 * expression.cs (Cast): Simplified by using ResolveType instead of
9396 * statement.cs (Catch): Fix bug by using ResolveType.
9398 2002-09-06 Ravi Pratap <ravi@ximian.com>
9400 * expression.cs (BetterConversion): Special case for when we have
9401 a NullLiteral as the argument and we have to choose between string
9402 and object types - we choose string the way csc does.
9404 * attribute.cs (Attribute.Resolve): Catch the
9405 NullReferenceException and report error #182 since the Mono
9406 runtime no more has the bug and having this exception raised means
9407 we tried to select a constructor which takes an object and is
9410 2002-09-05 Ravi Pratap <ravi@ximian.com>
9412 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
9413 message (1502, 1503) when we can't locate a method after overload
9414 resolution. This is much more informative and closes the bug
9417 * interface.cs (PopulateMethod): Return if there are no argument
9418 types. Fixes a NullReferenceException bug.
9420 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
9421 expressions too. Previously we were checking only in one place for
9422 positional arguments leaving out named arguments.
9424 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
9425 type to the enum type is not allowed. Remove code corresponding to
9428 (ConvertNumericExplicit): Allow explicit conversions from
9429 the underlying type to enum type. This precisely follows the spec
9430 and closes a bug filed by Gonzalo.
9432 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9435 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
9437 2002-09-03 Miguel de Icaza <miguel@ximian.com>
9439 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
9440 it was important that we stored the right value after the
9441 reduction in `converted'.
9443 2002-09-04 Martin Baulig <martin@gnome.org>
9445 * location.cs (Location.SymbolDocument): Use full pathnames for the
9448 2002-08-30 Miguel de Icaza <miguel@ximian.com>
9450 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
9451 of the expression resolve mechanism, because that will catch the
9452 SimpleName error failures.
9454 (Conditional): If we can not resolve the
9455 expression, return, do not crash.
9457 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9460 (location): display token name instead of its number.
9462 2002-08-28 Martin Baulig <martin@gnome.org>
9464 * expression.cs (Binary.ResolveOperator): Don't silently return
9465 but return an error if an operator cannot be applied between two
9468 2002-08-28 Martin Baulig <martin@gnome.org>
9470 * class.cs (Constructor.Define): Set the permission attributes
9471 correctly instead of making all constructors public.
9473 2002-08-28 Martin Baulig <martin@gnome.org>
9475 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
9476 for private members before reporting a CS0103; if we find anything,
9479 2002-08-28 Martin Baulig <martin@gnome.org>
9481 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9482 to check whether `closure_start_type == closure_invocation_type',
9483 we also need to check whether `m.DeclaringType == closure_invocation_type'
9484 before bypassing the permission checks. We might be accessing
9485 protected/private members from the base class.
9486 (TypeManager.RealMemberLookup): Only set private_ok if private
9487 members were requested via BindingFlags.NonPublic.
9489 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9491 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9492 MethodGroupExpr.IsExplicitImpl if appropriate.
9493 (Invocation.DoResolve): Don't report the CS0120 for explicit
9494 interface implementations.
9496 2002-08-27 Martin Baulig <martin@gnome.org>
9498 * expression.cs (Invocation.DoResolve): If this is a static
9499 method and we don't have an InstanceExpression, we must report
9502 2002-08-25 Martin Baulig <martin@gnome.org>
9504 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9505 `==' between a valuetype and an object.
9507 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9509 * ecore.cs (TypeExpr): Provide a ToString method.
9511 2002-08-24 Martin Baulig <martin@gnome.org>
9513 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9514 now called proggie.dbg and it's a binary file.
9516 2002-08-23 Martin Baulig <martin@gnome.org>
9518 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9520 2002-08-23 Martin Baulig <martin@gnome.org>
9522 * struct.cs (MyStructInfo.ctor): Make this work with empty
9523 structs; it's not allowed to use foreach() on null.
9525 2002-08-23 Martin Baulig <martin@gnome.org>
9527 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9528 writer the full pathname of the generated assembly.
9530 2002-08-23 Martin Baulig <martin@gnome.org>
9532 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9533 A `finally' block never returns or breaks; improved handling of
9536 2002-08-23 Martin Baulig <martin@gnome.org>
9538 * statement.cs (Throw.Resolve): Allow `throw null'.
9540 2002-08-23 Martin Baulig <martin@gnome.org>
9542 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9543 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9544 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9545 MemberLookup would return a wrong event if this is an explicit
9546 interface implementation and the class has an event with the same
9549 2002-08-23 Martin Baulig <martin@gnome.org>
9551 * statement.cs (Block.AddChildVariableNames): New public method.
9552 (Block.AddChildVariableName): Likewise.
9553 (Block.IsVariableNameUsedInChildBlock): Likewise.
9554 (Block.AddVariable): Check whether a variable name has already
9555 been used in a child block.
9557 * cs-parser.jay (declare_local_variables): Mark all variable names
9558 from the current block as being used in a child block in the
9561 2002-08-23 Martin Baulig <martin@gnome.org>
9563 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9564 find the symbol writer.
9566 * driver.cs: csc also allows the arguments to /define being
9567 separated by commas, not only by semicolons.
9569 2002-08-23 Martin Baulig <martin@gnome.org>
9571 * interface.cs (Interface.GetMembers): Added static check for events.
9573 2002-08-15 Martin Baulig <martin@gnome.org>
9575 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9576 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9578 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9579 why the MethodData.EmitDestructor() change was necessary.
9581 2002-08-20 Martin Baulig <martin@gnome.org>
9583 * class.cs (TypeContainer.FindMembers): Added static check for events.
9585 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9587 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9588 use Type.GetEvents(), not Type.FindMembers().
9590 2002-08-20 Martin Baulig <martin@gnome.org>
9592 * decl.cs (MemberCache): Added a special method cache which will
9593 be used for method-only searched. This ensures that a method
9594 search will return a MethodInfo with the correct ReflectedType for
9597 2002-08-20 Martin Baulig <martin@gnome.org>
9599 * decl.cs (DeclSpace.FindMembers): Made this public.
9601 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9603 * delegate.cs: fixed build on windows.
9604 [FIXME: Filed as bug #29150: MCS must report these errors.]
9606 2002-08-19 Ravi Pratap <ravi@ximian.com>
9608 * ecore.cs (StandardConversionExists): Return a false
9609 if we are trying to convert the void type to anything else
9610 since that is not allowed.
9612 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9613 we flag error 70 in the event an event is trying to be accessed
9614 directly from outside the declaring type.
9616 2002-08-20 Martin Baulig <martin@gnome.org>
9618 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9619 MemberCache from typemanager.cs to decl.cs.
9621 2002-08-19 Martin Baulig <martin@gnome.org>
9623 * class.cs (TypeContainer): Implement IMemberContainer.
9624 (TypeContainer.DefineMembers): Create the MemberCache.
9625 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9626 return public members if BindingFlags.Public was given, check
9627 whether members are static.
9629 2002-08-16 Martin Baulig <martin@gnome.org>
9631 * decl.cs (DeclSpace.Define): Splitted this in Define and
9632 DefineMembers. DefineMembers is called first and initializes the
9635 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9636 DefineMembers() on all our DeclSpaces.
9638 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9639 but call DefineMembers() on all nested interfaces. We call their
9640 Define() in our new Define() function.
9642 * interface.cs (Interface): Implement IMemberContainer.
9643 (Interface.Define): Moved all code except the attribute stuf to
9645 (Interface.DefineMembers): Initialize the member cache.
9647 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9648 need this anymore since we can use MemberCache.FindMembers directly.
9650 2002-08-19 Martin Baulig <martin@gnome.org>
9652 * typemanager.cs (MemberCache): When creating the cache for an
9653 interface type, add all inherited members.
9654 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9655 to `out bool used_cache' and documented it.
9656 (TypeManager.MemberLookup): If we already used the cache in the first
9657 iteration, we don't need to do the interfaces check.
9659 2002-08-19 Martin Baulig <martin@gnome.org>
9661 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9662 here from IMemberFinder and don't implement this interface anymore.
9663 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9665 * typemanager.cs (IMemberFinder): This interface is now only used by
9666 classes which actually support the member cache.
9667 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9668 since we only put DeclSpaces into this Hashtable.
9669 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9670 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9672 2002-08-16 Martin Baulig <martin@gnome.org>
9674 * typemanager.cs (ICachingMemberFinder): Removed.
9675 (IMemberFinder.MemberCache): New property.
9676 (TypeManager.FindMembers): Merged this with RealFindMembers().
9677 This function will never be called from TypeManager.MemberLookup()
9678 so we can't use the cache here, just the IMemberFinder.
9679 (TypeManager.MemberLookup_FindMembers): Check whether the
9680 IMemberFinder has a MemberCache and call the cache's FindMembers
9682 (MemberCache): Rewrote larger parts of this yet another time and
9683 cleaned it up a bit.
9685 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9687 * driver.cs (LoadArgs): Support quoting.
9689 (Usage): Show the CSC-like command line arguments.
9691 Improved a few error messages.
9693 2002-08-15 Martin Baulig <martin@gnome.org>
9695 * typemanager.cs (IMemberContainer.Type): New property.
9696 (IMemberContainer.IsInterface): New property.
9698 The following changes are conditional to BROKEN_RUNTIME, which is
9699 defined at the top of the file.
9701 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9702 class'es members, but add all members from TypeHandle.ObjectType
9703 if we're an interface.
9704 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9705 is the current type.
9706 (MemberCache.CacheEntry.Container): Removed this field.
9707 (TypeHandle.GetMembers): Include inherited members.
9709 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9711 * typemanager.cs: fixed compilation and added a comment on a field that
9714 2002-08-15 Martin Baulig <martin@gnome.org>
9716 * class.cs (ConstructorInitializer.Resolve): In the
9717 Expression.MemberLookup call, use the queried_type as
9720 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9721 declared' attribute, it's always true.
9722 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9723 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9724 temporary wrapper for FindMembers which tells MemberLookup whether
9725 members from the base classes are included in the return value.
9726 This will go away soon.
9727 (TypeManager.MemberLookup): Use this temporary hack here; once the
9728 new MemberCache is completed, we don't need to do the DeclaredOnly
9729 looping here anymore since the MemberCache will take care of this.
9730 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9731 (MemberCache): When creating the MemberCache for a class, get
9732 members from the current class and all its base classes.
9733 (MemberCache.CacheEntry.Container): New field. This is a
9734 temporary hack until the Mono runtime is fixed to distinguish
9735 between ReflectedType and DeclaringType. It allows us to use MCS
9736 with both the MS runtime and the unfixed Mono runtime without
9737 problems and without accecting performance.
9738 (MemberCache.SearchMembers): The DeclaredOnly looping from
9739 TypeManager.MemberLookup is now done here.
9741 2002-08-14 Martin Baulig <martin@gnome.org>
9743 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9744 Type.GetFields on dynamic types but get the fields from the
9745 corresponding TypeContainer.
9746 (MyStructInfo.GetStructInfo): Added check for enum types.
9748 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9749 (MemberList.SyncRoot): Implemented.
9750 (TypeManager.FilterWithClosure): No need to check permissions if
9751 closure_start_type == closure_invocation_type, don't crash if
9752 closure_invocation_type is null.
9754 2002-08-13 Martin Baulig <martin@gnome.org>
9756 Rewrote TypeContainer.FindMembers to use a member cache. This
9757 gives us a speed increase of about 35% for the self-hosting MCS
9758 build and of about 15-20% for the class libs (both on GNU/Linux).
9760 * report.cs (Timer): New class to get enhanced profiling. This
9761 whole class is "TIMER" conditional since it remarkably slows down
9764 * class.cs (MemberList): New class. This is an IList wrapper
9765 which we're now using instead of passing MemberInfo[]'s around to
9766 avoid copying this array unnecessarily.
9767 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9768 (ICachingMemberFinder, IMemberContainer): New interface.
9769 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9770 has already been checked, otherwise use it for the name comparision.
9771 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9772 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9773 if possible. Returns a MemberList, not a MemberInfo [].
9774 (TypeHandle): New class, implements IMemberContainer. We create
9775 one instance of this class per type, it contains a MemberCache
9776 which is used to do the member lookups.
9777 (MemberCache): New class. Each instance of this class contains
9778 all members of a type and a name-based hash table.
9779 (MemberCache.FindMembers): This is our new member lookup
9780 function. First, it looks up all members of the requested name in
9781 the hash table. Then, it walks this list and sorts out all
9782 applicable members and returns them.
9784 2002-08-13 Martin Baulig <martin@gnome.org>
9786 In addition to a nice code cleanup, this gives us a performance
9787 increase of about 1.4% on GNU/Linux - not much, but it's already
9788 half a second for the self-hosting MCS compilation.
9790 * typemanager.cs (IMemberFinder): New interface. It is used by
9791 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9792 Enum, Delegate or Interface.
9793 (TypeManager.finder_to_member_finder): New PtrHashtable.
9794 (TypeManager.finder_to_container): Removed.
9795 (TypeManager.finder_to_delegate): Removed.
9796 (TypeManager.finder_to_interface): Removed.
9797 (TypeManager.finder_to_enum): Removed.
9799 * interface.cs (Interface): Implement IMemberFinder.
9801 * delegate.cs (Delegate): Implement IMemberFinder.
9803 * enum.cs (Enum): Implement IMemberFinder.
9805 * class.cs (TypeContainer): Implement IMemberFinder.
9807 2002-08-12 Martin Baulig <martin@gnome.org>
9809 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9811 2002-08-12 Martin Baulig <martin@gnome.org>
9813 * ecore.cs (ITypeExpression): New interface for expressions which
9815 (TypeExpression): Renamed to TypeLookupExpression.
9816 (Expression.DoResolve): If we're doing a types-only lookup, the
9817 expression must implement the ITypeExpression interface and we
9818 call DoResolveType() on it.
9819 (SimpleName): Implement the new ITypeExpression interface.
9820 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9821 hack, the situation that we're only looking up types can't happen
9822 anymore when this method is called. Moved the type lookup code to
9823 DoResolveType() and call it.
9824 (SimpleName.DoResolveType): This ITypeExpression interface method
9825 is now doing the types-only lookup.
9826 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9827 (ResolveFlags): Added MaskExprClass.
9829 * expression.cs (MemberAccess): Implement the ITypeExpression
9831 (MemberAccess.DoResolve): Added support for a types-only lookup
9832 when we're called via ITypeExpression.DoResolveType().
9833 (ComposedCast): Implement the ITypeExpression interface.
9835 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
9836 Expression.Resolve() with ResolveFlags.Type instead.
9838 2002-08-12 Martin Baulig <martin@gnome.org>
9840 * interface.cs (Interface.Define): Apply attributes.
9842 * attribute.cs (Attribute.ApplyAttributes): Added support for
9843 interface attributes.
9845 2002-08-11 Martin Baulig <martin@gnome.org>
9847 * statement.cs (Block.Emit): Only check the "this" variable if we
9848 do not always throw an exception.
9850 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
9851 whether the property has a set accessor.
9853 2002-08-11 Martin Baulig <martin@gnome.org>
9855 Added control flow analysis support for structs.
9857 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
9858 with control flow analysis turned off.
9859 (IVariable): New interface.
9860 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
9861 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
9862 (FieldExpr.DoResolve): Resolve the instance expression with flow
9863 analysis turned off and do the definite assignment check after the
9864 resolving when we know what the expression will resolve to.
9866 * expression.cs (LocalVariableReference, ParameterReference):
9867 Implement the new IVariable interface, only call the flow analysis
9868 code if ec.DoFlowAnalysis is true.
9869 (This): Added constructor which takes a Block argument. Implement
9870 the new IVariable interface.
9871 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
9872 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
9873 This does the definite assignment checks for struct members.
9875 * class.cs (Constructor.Emit): If this is a non-static `struct'
9876 constructor which doesn't have any initializer, call
9877 Block.AddThisVariable() to tell the flow analysis code that all
9878 struct elements must be initialized before control returns from
9881 * statement.cs (MyStructInfo): New public class.
9882 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
9883 argument to this indexer. If non-zero, check an individual struct
9884 member, not the whole struct.
9885 (FlowBranching.CheckOutParameters): Check struct members.
9886 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
9887 overloaded versions of these methods which take an additional
9888 `int field_idx' argument to check struct members.
9889 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
9890 overloaded versions of these methods which take an additional
9891 `string field_name' argument to check struct member.s
9892 (VariableInfo): Implement the IVariable interface.
9893 (VariableInfo.StructInfo): New public property. Returns the
9894 MyStructInfo instance of the variable if it's a struct or null.
9895 (Block.AddThisVariable): New public method. This is called from
9896 Constructor.Emit() for non-static `struct' constructor which do
9897 not have any initializer. It creates a special variable for the
9898 "this" instance variable which will be checked by the flow
9899 analysis code to ensure that all of the struct's fields are
9900 initialized before control returns from the constructor.
9901 (UsageVector): Added support for struct members. If a
9902 variable/parameter is a struct with N members, we reserve a slot
9903 in the usage vector for each member. A struct is considered fully
9904 initialized if either the struct itself (slot 0) or all its
9905 members are initialized.
9907 2002-08-08 Martin Baulig <martin@gnome.org>
9909 * driver.cs (Driver.MainDriver): Only report an error CS5001
9910 if there were no compilation errors.
9912 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
9913 `UnsafeContext' property to determine whether the parent is in
9914 unsafe context rather than checking the parent's ModFlags:
9915 classes nested in an unsafe class are unsafe as well.
9917 2002-08-08 Martin Baulig <martin@gnome.org>
9919 * statement.cs (UsageVector.MergeChildren): Distinguish between
9920 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
9921 we return. Added test17() and test18() to test-154.cs.
9923 2002-08-08 Martin Baulig <martin@gnome.org>
9925 * typemanager.cs (TypeManager.FilterWithClosure): If we have
9926 Family access, make sure the invoking type isn't a subclass of the
9927 queried type (that'd be a CS1540).
9929 * ecore.cs (Expression.MemberLookup): Added overloaded version of
9930 this method which takes an additional `Type invocation_type'.
9932 * expression.cs (BaseAccess.DoResolve): Use the base type as
9933 invocation and query type.
9934 (MemberAccess.DoResolve): If the lookup failed and we're about to
9935 report a CS0122, try a lookup with the ec.ContainerType - if this
9936 succeeds, we must report a CS1540.
9938 2002-08-08 Martin Baulig <martin@gnome.org>
9940 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
9941 (MethodGroupExpr): Implement the IMemberExpr interface.
9943 * expression (MemberAccess.ResolveMemberAccess): No need to have
9944 any special code for MethodGroupExprs anymore, they're now
9947 2002-08-08 Martin Baulig <martin@gnome.org>
9949 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
9950 Family, FamANDAssem and FamORAssem permissions.
9951 (TypeManager.IsSubclassOrNestedChildOf): New public method.
9953 2002-08-08 Martin Baulig <martin@gnome.org>
9955 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
9956 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
9959 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
9961 * driver.cs: implemented /resource option to embed managed resources.
9963 2002-08-07 Martin Baulig <martin@gnome.org>
9965 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
9966 (FieldBase.HasFieldInitializer): New public property.
9967 (FieldBase.GetInitializerExpression): New public method. Resolves and
9968 returns the field initializer and makes sure it is only resolved once.
9969 (TypeContainer.EmitFieldInitializers): Call
9970 FieldBase.GetInitializerExpression to get the initializer, this ensures
9971 that it isn't resolved multiple times.
9973 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
9974 the resolving process (SimpleName/MemberLookup) that we're currently
9975 emitting a field initializer (which must not access any instance members,
9976 this is an error CS0236).
9978 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
9979 argument, if the `IsFieldInitializer' flag is set, we must report and
9980 error CS0236 and not an error CS0120.
9982 2002-08-07 Martin Baulig <martin@gnome.org>
9984 * ecore.cs (IMemberExpr): New public interface.
9985 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
9986 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
9987 if the expression is an IMemberExpr.
9989 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
9990 to be null, implicitly default to `this' if we're non-static in
9991 this case. Simplified the code a lot by using the new IMemberExpr
9992 interface. Also fixed bug #28176 here.
9994 2002-08-06 Martin Baulig <martin@gnome.org>
9996 * cs-parser.jay (SimpleLookup): Removed. We need to create
9997 ParameterReferences during semantic analysis so that we can do a
9998 type-only search when resolving Cast, TypeOf and SizeOf.
9999 (block): Pass the `current_local_parameters' to the Block's
10002 * class.cs (ConstructorInitializer): Added `Parameters parameters'
10003 argument to the constructor.
10004 (ConstructorInitializer.Resolve): Create a temporary implicit
10005 block with the parameters.
10007 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
10008 references here if we aren't doing a type-only search.
10010 * statement.cs (Block): Added constructor which takes a
10011 `Parameters parameters' argument.
10012 (Block.Parameters): New public property.
10014 * support.cs (InternalParameters.Parameters): Renamed `parameters'
10015 to `Parameters' and made it public readonly.
10017 2002-08-06 Martin Baulig <martin@gnome.org>
10019 * ecore.cs (Expression.Warning): Made this public as well.
10021 * report.cs (Report.Debug): Print the contents of collections.
10023 2002-08-06 Martin Baulig <martin@gnome.org>
10025 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
10026 used to tell Resolve() which kinds of expressions it may return.
10027 (Expression.Resolve): Added overloaded version of this method which
10028 takes a `ResolveFlags flags' argument. This can be used to tell
10029 Resolve() which kinds of expressions it may return. Reports a
10031 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
10032 ResolveFlags.SimpleName.
10033 (Expression.Error118): Added overloaded version of this method which
10034 takes a `ResolveFlags flags' argument. It uses the flags to determine
10035 which kinds of expressions are allowed.
10037 * expression.cs (Argument.ResolveMethodGroup): New public method.
10038 Resolves an argument, but allows a MethodGroup to be returned.
10039 This is used when invoking a delegate.
10041 * TODO: Updated a bit.
10043 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10045 Fixed compilation with csc.
10047 * ecore.cs: Expression.Error made public. Is this correct? Should
10048 Warning be made public too?
10050 * expression.cs: use ea.Location instead of ea.loc.
10051 [FIXME: Filed as bug #28607: MCS must report these errors.]
10053 2002-08-06 Martin Baulig <martin@gnome.org>
10055 * ecore.cs (Expression.loc): Moved the location here instead of
10056 duplicating it in all derived classes.
10057 (Expression.Location): New public property.
10058 (Expression.Error, Expression.Warning): Made them non-static and
10059 removed the location argument.
10060 (Expression.Warning): Added overloaded version which takes an
10061 `int level' argument.
10062 (Expression.Error118): Make this non-static and removed the
10063 expression and location arguments.
10064 (TypeExpr): Added location argument to the constructor.
10066 * expression.cs (StaticCallExpr): Added location argument to
10068 (Indirection, PointerArithmetic): Likewise.
10069 (CheckedExpr, UnCheckedExpr): Likewise.
10070 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
10071 (StringPtr): Likewise.
10074 2002-08-05 Martin Baulig <martin@gnome.org>
10076 * expression.cs (BaseAccess.DoResolve): Actually report errors.
10078 * assign.cs (Assign.DoResolve): Check whether the source
10079 expression is a value or variable.
10081 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
10082 while resolving the corresponding blocks.
10084 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
10085 an error, don't silently return null.
10087 * statement.cs (Block.AddVariable): Do the error reporting here
10088 and distinguish between CS0128 and CS0136.
10089 (Block.DoResolve): Report all unused labels (warning CS0164).
10090 (LabeledStatement): Pass the location to the constructor.
10091 (LabeledStatement.HasBeenReferenced): New property.
10092 (LabeledStatement.Resolve): Set it to true here.
10094 * statement.cs (Return.Emit): Return success even after reporting
10095 a type mismatch error (CS0126 or CS0127), this is what csc does and
10096 it avoids confusing the users with any consecutive errors.
10098 2002-08-05 Martin Baulig <martin@gnome.org>
10100 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
10102 * const.cs (Const.LookupConstantValue): Catch circular definitions.
10104 * expression.cs (MemberAccess.DoResolve): Silently return if an
10105 error has already been reported.
10107 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
10108 error has already been reported.
10110 2002-08-05 Martin Baulig <martin@gnome.org>
10112 * statement.cs (UsageVector): Only initialize the `parameters'
10113 vector if we actually have any "out" parameters.
10115 2002-08-05 Martin Baulig <martin@gnome.org>
10117 * expression.cs (Binary.ResolveOperator): When combining delegates,
10118 they must have the same type.
10120 2002-08-05 Martin Baulig <martin@gnome.org>
10122 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
10123 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
10124 work with the ms runtime and we also don't need it: if we're a
10125 PropertyBuilder and not in the `indexer_arguments' hash, then we
10126 are a property and not an indexer.
10128 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
10129 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
10130 since the latter one doesn't work with the ms runtime.
10132 2002-08-03 Martin Baulig <martin@gnome.org>
10134 Fixed bugs #27998 and #22735.
10136 * class.cs (Method.IsOperator): New public field.
10137 (Method.CheckBase): Report CS0111 if there's already a method
10138 with the same parameters in the current class. Report CS0508 when
10139 attempting to change the return type of an inherited method.
10140 (MethodData.Emit): Report CS0179 if a method doesn't have a body
10141 and it's not marked abstract or extern.
10142 (PropertyBase): New abstract base class for Property and Indexer.
10143 (PropertyBase.CheckBase): Moved here from Property and made it work
10145 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
10146 the same so we can reuse it there.
10147 (Property, Indexer): Derive from PropertyBase.
10148 (MethodSignature.inheritable_property_signature_filter): New delegate
10149 to find properties and indexers.
10151 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
10152 argument and improved error reporting.
10154 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
10155 EmptyReadOnlyParameters and made it a property.
10157 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
10158 version of this method which takes a `PropertyInfo indexer'.
10159 (TypeManager.RegisterIndexer): New method.
10161 * class.cs: Added myself as author of this file :-)
10163 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10165 * class.cs: fixed compilation on windoze.
10167 2002-08-03 Martin Baulig <martin@gnome.org>
10169 * interface.cs (Interface.GetInterfaceBases): Check whether all
10170 base interfaces are at least as accessible than the current one.
10172 * class.cs (TypeContainer.GetClassBases): Check whether base types
10173 are at least as accessible than the current type.
10174 (TypeContainer.AsAccessible): Implemented and made non-static.
10175 (MemberBase.CheckParameters): Report errors if the accessibility
10178 * delegate.cs (Delegate.Delegate): The default visibility is
10179 internal for top-level types and private for nested types.
10180 (Delegate.Define): Report errors if the accessibility checks fail.
10182 * enum.cs (Enum.Enum): The default visibility is internal for
10183 top-level types and private for nested types.
10184 (Enum.DefineType): Compute the correct visibility.
10186 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
10187 function which takes a `bool is_toplevel' instead of a TypeContainer.
10189 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
10192 2002-08-02 Martin Baulig <martin@gnome.org>
10194 * expression.cs (LocalVariableReferenc): Added constructor which
10195 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
10196 (LocalVariableReference.IsReadOnly): New property.
10197 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
10198 variable is readonly, use our own readonly flag to do this; you can
10199 use the new constructor to get a writable reference to a read-only
10202 * cs-parser.jay (foreach_statement, using_statement): Get a writable
10203 reference to the local variable.
10205 2002-08-01 Miguel de Icaza <miguel@ximian.com>
10207 * rootcontext.cs (ResolveCore): Also include System.Exception
10209 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
10210 we reach an EmptyStatement.
10212 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
10215 * expression.cs (Binary.ResolveOperator): Check error result in
10218 use brtrue/brfalse directly and avoid compares to null.
10220 2002-08-02 Martin Baulig <martin@gnome.org>
10222 * class.cs (TypeContainer.Define): Define all nested interfaces here.
10223 Fixes bug #28407, added test-155.cs.
10225 2002-08-01 Martin Baulig <martin@gnome.org>
10227 * class.cs (Event.EmitDefaultMethod): Make this work with static
10228 events. Fixes #28311, added verify-3.cs.
10230 2002-08-01 Martin Baulig <martin@gnome.org>
10232 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
10233 `is_disposable' fields.
10234 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
10235 `hm.is_disposable' if we're using the collection pattern.
10236 (Foreach.EmitCollectionForeach): Use the correct type for the
10237 enumerator's local variable, only emit the try/finally block if
10238 necessary (fixes #27713).
10240 2002-08-01 Martin Baulig <martin@gnome.org>
10242 * ecore.cs (Expression.report118): Renamed to Error118 and made
10245 * statement.cs (Throw.Resolve): Check whether the expression is of
10246 the correct type (CS0118) and whether the type derives from
10247 System.Exception (CS0155).
10248 (Catch.Resolve): New method. Do the type lookup here and check
10249 whether it derives from System.Exception (CS0155).
10250 (Catch.CatchType, Catch.IsGeneral): New public properties.
10252 * typemanager.cs (TypeManager.exception_type): Added.
10254 2002-07-31 Miguel de Icaza <miguel@ximian.com>
10256 * driver.cs: Updated About function.
10258 2002-07-31 Martin Baulig <martin@gnome.org>
10260 Implemented Control Flow Analysis.
10262 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
10263 (EmitContext.CurrentBranching): Added.
10264 (EmitContext.StartFlowBranching): Added.
10265 (EmitContext.EndFlowBranching): Added.
10266 (EmitContext.KillFlowBranching): Added.
10267 (EmitContext.IsVariableAssigned): Added.
10268 (EmitContext.SetVariableAssigned): Added.
10269 (EmitContext.IsParameterAssigned): Added.
10270 (EmitContext.SetParameterAssigned): Added.
10271 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
10272 Added control flow analysis stuff here.
10274 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
10275 resolve the expression as lvalue.
10276 (LocalVariableReference.DoResolve): Check whether the variable has
10277 already been assigned.
10278 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
10279 the parameter as assigned here.
10280 (ParameterReference.DoResolve): Check whether the parameter has already
10282 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
10283 expression as lvalue.
10285 * statement.cs (FlowBranching): New class for the flow analysis code.
10286 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
10287 (LabeledStatement.IsDefined): New public property.
10288 (LabeledStatement.AddUsageVector): New public method to tell flow
10289 analyis that the label may be reached via a forward jump.
10290 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
10292 (VariableInfo.Number): New public field. This is used by flow analysis
10293 to number all locals of a block.
10294 (Block.CountVariables): New public property. This is the number of
10295 local variables in this block (including the locals from all parent
10297 (Block.EmitMeta): Number all the variables.
10299 * statement.cs: Added flow analysis support to all classes.
10301 2002-07-31 Martin Baulig <martin@gnome.org>
10303 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
10304 To get debugging messages, compile mcs with /define:MCS_DEBUG and
10305 then use this argument.
10307 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
10309 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
10310 use this to specify /define options.
10312 2002-07-29 Martin Baulig <martin@gnome.org>
10314 * statement.cs (Fixed): Moved all code that does variable lookups
10315 and resolvings from Emit to Resolve.
10317 * statement.cs (For): Moved all code that does variable lookups
10318 and resolvings from Emit to Resolve.
10320 * statement.cs (Using): Moved all code that does variable lookups
10321 and resolvings from Emit to Resolve.
10323 2002-07-29 Martin Baulig <martin@gnome.org>
10325 * attribute.cs (Attribute.Resolve): Explicitly catch a
10326 System.NullReferenceException when creating the
10327 CustromAttributeBuilder and report a different warning message.
10329 2002-07-29 Martin Baulig <martin@gnome.org>
10331 * support.cs (ParameterData.ParameterName): Added method to
10332 get the name of a parameter.
10334 * typemanager.cs (TypeManager.IsValueType): New public method.
10336 2002-07-29 Martin Baulig <martin@gnome.org>
10338 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
10339 is a flag which specifies that it's either ref or out.
10340 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
10341 the out parameter to `out Parameter.Modifier mod', also set the
10342 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
10344 * support.cs (InternalParameters.ParameterModifier): Distinguish
10345 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10346 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10348 * expression.cs (Argument.GetParameterModifier): Distinguish
10349 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10350 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10352 2002-07-29 Martin Baulig <martin@gnome.org>
10354 * expression.cs (ParameterReference.ParameterReference): Added
10355 `Location loc' argument to the constructor.
10357 * cs-parser.jay: Pass location to ParameterReference.
10359 2002-07-28 Miguel de Icaza <miguel@ximian.com>
10361 * statement.cs (Try): Initialize the location.
10363 * cs-parser.jay: pass location to Try.
10365 * expression.cs (Unary.Reduce): Change the prototype to return
10366 whether a constant fold could be performed or not. The result is
10367 returned in an out parameters. In the case of Indirection and
10368 AddressOf, we want to perform the full tests.
10370 2002-07-26 Miguel de Icaza <miguel@ximian.com>
10372 * statement.cs (Statement.Emit): Flag dead code.
10374 2002-07-27 Andrew Birkett <andy@nobugs.org>
10376 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
10378 2002-07-27 Martin Baulig <martin@gnome.org>
10380 * class.cs (MethodData.Define): Put back call to
10381 TypeManager.AddMethod(), accidentally commented this out.
10383 * report.cs (Debug): New public method to print debugging information,
10384 this is `[Conditional ("DEBUG")]'.
10386 2002-07-26 Martin Baulig <martin@gnome.org>
10388 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
10389 (switch_statement): Push the current_block to the switch_stack and
10390 pop it again when we're done with the switch.
10391 (switch_section): The new block is a child of the current_block.
10392 Fixes bug #24007, added test-152.cs.
10394 2002-07-27 Martin Baulig <martin@gnome.org>
10396 * expression.cs (Invocation.EmitArguments): When calling a varargs
10397 function with only its fixed arguments, we need to pass an empty
10400 2002-07-27 Martin Baulig <martin@gnome.org>
10402 Mono 0.13 has been released.
10404 2002-07-25 Miguel de Icaza <miguel@ximian.com>
10406 * driver.cs: Rename --resource to --linkres, because that is what
10407 we do currently, we dont support --resource yet.
10409 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
10411 2002-07-25 Martin Baulig <martin@gnome.org>
10413 * class.cs (MethodData): New public class. This is a `method builder'
10414 class for a method or one accessor of a Property/Indexer/Event.
10415 (MethodData.GetMethodFlags): Moved here from MemberBase.
10416 (MethodData.ApplyAttributes): Likewise.
10417 (MethodData.ApplyObsoleteAttribute): Likewise.
10418 (MethodData.ApplyConditionalAttribute): Likewise.
10419 (MethodData.ApplyDllImportAttribute): Likewise.
10420 (MethodData.CheckAbstractAndExternal): Likewise.
10421 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
10422 (MethodData.Emit): Formerly known as Method.Emit().
10423 (MemberBase): Moved everything which was specific to a single
10424 accessor/method to MethodData.
10425 (Method): Create a new MethodData and call Define() and Emit() on it.
10426 (Property, Indexer, Event): Create a new MethodData objects for each
10427 accessor and call Define() and Emit() on them.
10429 2002-07-25 Martin Baulig <martin@gnome.org>
10431 Made MethodCore derive from MemberBase to reuse the code from there.
10432 MemberBase now also checks for attributes.
10434 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
10435 (MemberBase.GetMethodFlags): Moved here from class Method and marked
10437 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
10438 `CallingConventions cc' and `Attributes opt_attrs' arguments.
10439 (MemberBase.ApplyAttributes): New virtual method; applies the
10440 attributes to a method or accessor.
10441 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
10442 (MemberBase.ApplyConditionalAttribute): Likewise.
10443 (MemberBase.ApplyDllImportAttribute): Likewise.
10444 (MemberBase.CheckAbstractAndExternal): Likewise.
10445 (MethodCore.ParameterTypes): This is now a property instead of a
10446 method, it's initialized from DoDefineParameters().
10447 (MethodCore.ParameterInfo): Removed the set accessor.
10448 (MethodCore.DoDefineParameters): New protected virtual method to
10449 initialize ParameterTypes and ParameterInfo.
10450 (Method.GetReturnType): We can now simply return the MemberType.
10451 (Method.GetMethodFlags): Override the MemberBase version and add
10452 the conditional flags.
10453 (Method.CheckBase): Moved some code from Define() here, call
10454 DoDefineParameters() here.
10455 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
10456 here to avoid some larger code duplication.
10457 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
10458 ensure that abstract and external accessors don't declare a body.
10460 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
10461 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
10462 lookup in the attribute's parent classes, so we need to abort as soon
10463 as we found the first match.
10464 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
10465 the attribute has no arguments.
10467 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
10470 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10472 * cs-parser.jay: reverted previous patch.
10474 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10476 * cs-parser.jay: fixed bug #22119.
10478 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10480 * attribute.cs: fixed compilation. The error was:
10481 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10482 be assigned to before control leaves the current method."
10483 [FIXME: Filed as bug #28186: MCS must report this error.]
10485 2002-07-25 Martin Baulig <martin@gnome.org>
10487 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10488 method to pull the condition name ouf of a Conditional attribute.
10489 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10490 the obsolete message and error flag out of an Obsolete attribute.
10492 * class.cs (Method.GetMethodFlags): New public method to get the
10493 TypeManager.MethodFlags for this method.
10494 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10496 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10497 if we're overriding a virtual function, set the new private variable
10498 `parent_method'; call the new TypeManager.AddMethod().
10500 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10501 the MethodBuilder and the Method in a PtrHashtable.
10502 (TypeManager.builder_to_method): Added for this purpose.
10503 (TypeManager.MethodFlags): Added IsObsoleteError.
10504 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10505 Obsolete and Conditional arguments in MethodBuilders. If we discover
10506 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10507 the message from the attribute.
10509 2002-07-24 Martin Baulig <martin@gnome.org>
10511 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10512 preprocessor directives, ensure that the argument to #define/#undef is
10513 exactly one identifier and that it's actually an identifier.
10515 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10518 2002-07-24 Martin Baulig <martin@gnome.org>
10520 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10521 initialize it to TypeManager.object_type in the constructor.
10522 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10523 of the `hm.get_current' method if we're using the collection pattern.
10524 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10525 for the explicit conversion to make it work when we're using the collection
10526 pattern and the `Current' property has a different return type than `object'.
10529 2002-07-24 Martin Baulig <martin@gnome.org>
10531 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10532 does not match, but don't report any errors. This method is called in
10533 order for all methods in a MethodGroupExpr until a matching method is
10534 found, so we don't want to bail out if the first method doesn't match.
10535 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10536 matches, report the 123. Fixes #28070.
10538 2002-07-24 Martin Baulig <martin@gnome.org>
10540 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10541 TypeManager.TypeToCoreType() to the top of the method so the
10542 following equality checks will work. Fixes #28107.
10544 2002-07-24 Martin Baulig <martin@gnome.org>
10546 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10547 operand is of type uint, and the other operand is of type sbyte,
10548 short or int, the operands are converted to type long." -
10549 Actually do what this comment already told us. Fixes bug #28106,
10552 2002-07-24 Martin Baulig <martin@gnome.org>
10554 * class.cs (MethodBase): New abstract class. This is now a base
10555 class for Property, Indexer and Event to avoid some code duplication
10556 in their Define() and DefineMethods() methods.
10557 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10558 generic methods for Define() and DefineMethods().
10559 (FieldBase): Derive from MemberBase, not MemberCore.
10560 (Property): Derive from MemberBase, not MemberCore.
10561 (Property.DefineMethod): Moved all the code from this method to the
10562 new MethodBase.DefineAccessor(), just call it with appropriate
10564 (Property.Define): Call the new Property.DoDefine(), this does some
10565 sanity checks and we don't need to duplicate the code everywhere.
10566 (Event): Derive from MemberBase, not MemberCore.
10567 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10568 accessors, this will also make them work with interface events.
10569 (Indexer): Derive from MemberBase, not MemberCore.
10570 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10571 (Indexer.Define): Use the new MethodBase functions.
10573 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10574 argument to the constructor.
10575 (Interface.FindMembers): Added support for interface events.
10576 (Interface.PopluateEvent): Implemented.
10578 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10580 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10582 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10583 but this is required to check for a method name being the same as
10584 the containing class.
10588 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10590 * interface.cs: initialize variable.
10592 2002-07-23 Martin Baulig <martin@gnome.org>
10594 Implemented the IndexerName attribute in interfaces.
10596 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10597 name if this is an explicit interface implementation.
10598 (Indexer.InterfaceIndexerName): New public variable. If we're
10599 implementing an interface indexer, this is the IndexerName in that
10600 interface. Otherwise, it's the IndexerName.
10601 (Indexer.DefineMethod): If we're implementing interface indexer,
10602 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10603 and Pending.ImplementIndexer methods.
10604 (Indexer.Define): Also define the PropertyBuilder if we're
10605 implementing an interface indexer and this is neither an explicit
10606 interface implementation nor do the IndexerName match the one in
10609 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10610 If a method is defined here, then we always need to create a proxy
10611 for it. This is used when implementing interface indexers.
10612 (Pending.IsInterfaceIndexer): New public method.
10613 (Pending.ImplementIndexer): New public method.
10614 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10615 This is used when implementing interface indexers to define a proxy
10617 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10618 define a proxy if necessary.
10620 * interface.cs (Interface.IndexerName): New public variable.
10621 (Interface.PopulateIndexer): Set the IndexerName.
10622 (Interface.DefineIndexers): New private method. Populate all the
10623 indexers and make sure their IndexerNames match.
10625 * typemanager.cs (IndexerPropertyName): Added support for interface
10628 2002-07-22 Martin Baulig <martin@gnome.org>
10630 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10631 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10632 ret if HasReturnLabel.
10633 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10636 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10637 and set the ec.LoopBeginTryCatchLevel.
10638 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10639 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10640 the current ec.TryCatchLevel, the branch goes out of an exception
10641 block. In this case, we need to use Leave and not Br.
10643 2002-07-22 Martin Baulig <martin@gnome.org>
10645 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10646 block unless the block does not always return or it is contained in
10647 another try { ... } catch { ... } block. Fixes bug #26506.
10648 Added verify-1.cs to the test suite.
10650 2002-07-22 Martin Baulig <martin@gnome.org>
10652 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10653 then we do not always return. Fixes bug #24985.
10655 2002-07-22 Martin Baulig <martin@gnome.org>
10657 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10658 lookup on a per-class level; ie. walk up the class hierarchy until we
10659 found at least one applicable method, then choose the best among them.
10660 Fixes bug #24463 and test-29.cs.
10662 2002-07-22 Martin Baulig <martin@gnome.org>
10664 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10665 return types of the methods. The return type is not part of the
10666 signature and we must not check it to make the `new' modifier work.
10667 Fixes bug #27999, also added test-147.cs.
10668 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10670 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10671 on the method's return type.
10673 2002-07-21 Martin Baulig <martin@gnome.org>
10675 * assign.cs: Make this work if the rightmost source is a constant and
10676 we need to do an implicit type conversion. Also adding a few more tests
10677 to test-38.cs which should have caught this.
10679 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10680 target in the makefile for this. The makefile.gnu is primarily intended
10681 for end-users who don't want to debug the compiler.
10683 2002-07-21 Martin Baulig <martin@gnome.org>
10685 * assign.cs: Improved the Assign class so it can now handle embedded
10686 assignments (X = Y = Z = something). As a side-effect this'll now also
10687 consume less local variables. test-38.cs now passes with MCS, added
10688 a few new test cases to that test.
10690 2002-07-20 Martin Baulig <martin@gnome.org>
10692 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10693 instructions. Fixes bug #27977, also added test-146.cs.
10695 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10697 * cs-tokenizer.cs: fixed getHex ().
10699 2002-07-19 Martin Baulig <martin@gnome.org>
10701 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10702 not Type.GetType() to lookup the array type. This is needed when
10703 we're constructing an array of a user-defined type.
10704 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10705 single-dimensional arrays, but also for single-dimensial arrays of
10708 2002-07-19 Martin Baulig <martin@gnome.org>
10710 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10711 this function is called, it's not allowed to share LocalBuilders
10712 among ILGenerators.
10714 2002-07-19 Martin Baulig <martin@gnome.org>
10716 * expression.cs (Argument.Resolve): Report an error 118 when trying
10717 to pass a type as argument.
10719 2002-07-18 Martin Baulig <martin@gnome.org>
10721 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10722 Conv_R_Un for the signed `long' type.
10724 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10726 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10727 `expr' for the temporary result, as that will fail if we do
10728 multiple resolves on the same expression.
10730 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10732 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10733 ec.TypeContainer for looking up aliases.
10735 * class.cs (TypeContainer): Remove LookupAlias from here.
10737 * decl.cs (DeclSpace); Move here.
10739 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10741 * class.cs (FindMembers): Only call filter if the constructor
10742 bulider is not null.
10744 Also handle delegates in `NestedTypes' now. Now we will perform
10745 type lookups using the standard resolution process. This also
10748 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10749 This uses Expressions (the limited kind that can be parsed by the
10750 tree) instead of strings.
10752 * expression.cs (ComposedCast.ToString): Implement, used to flag
10753 errors since now we have to render expressions.
10755 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10758 * ecore.cs (SimpleName.ToString): ditto.
10760 * cs-parser.jay: Instead of using strings to assemble types, use
10761 Expressions to assemble the type (using SimpleName, ComposedCast,
10762 MemberAccess). This should fix the type lookups in declarations,
10763 because we were using a different code path for this.
10765 * statement.cs (Block.Resolve): Continue processing statements
10766 even when there is an error.
10768 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10770 * class.cs (Event.Define): Also remove the `remove' method from
10771 the list of pending items.
10773 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10774 generate more compact code.
10776 2002-07-17 Martin Baulig <martin@gnome.org>
10778 * const.cs (Const.LookupConstantValue): Add support for constant
10779 `unchecked' and `checked' expressions.
10780 Also adding test case test-140.cs for this.
10782 2002-07-17 Martin Baulig <martin@gnome.org>
10784 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10785 check whether mi.ReturnType implements the IEnumerator interface; the
10786 `==' and the IsAssignableFrom() will fail in this situation.
10788 2002-07-16 Ravi Pratap <ravi@ximian.com>
10790 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10793 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10795 * expression.cs: fixed bug #27811.
10797 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10799 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10800 Molaro: when we are a ref, the value already contains a pointer
10801 value, do not take the address of it.
10803 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10804 * removed mb-parser.jay and mb-tokenizer.cs
10806 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10808 * expression.cs: check against the building corlib void type.
10810 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10812 * ecore.cs: fix for valuetype static readonly fields: when
10813 initializing them, we need their address, not the address of a copy.
10815 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10817 * typemanager.cs: register also enum_type in corlib.
10819 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10821 * class.cs: allow calling this (but not base) initializers in structs.
10823 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10825 * ecore.cs: make sure we compare against the building base types
10828 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
10830 * typemanager.cs: fix TypeToCoreType() to handle void and object
10831 (corlib gets no more typerefs after this change).
10833 2002-07-12 Miguel de Icaza <miguel@ximian.com>
10835 * expression.cs (ArrayCreation.EmitArrayArguments): use
10836 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
10838 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
10839 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
10840 array indexes, the runtime actually forbids them.
10842 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
10843 for array arguments here.
10845 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
10846 instead of the default for ValueTypes.
10848 (New.DoEmit): Use IsValueType instead of
10849 IsSubclassOf (value_type)
10850 (New.DoResolve): ditto.
10851 (Invocation.EmitCall): ditto.
10853 * assign.cs (Assign): ditto.
10855 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
10856 Statements *are* currently doing part of their resolution during
10859 Expressions do always resolve during resolve, but statements are
10860 only required to propagate resolution to their children.
10862 2002-07-11 Miguel de Icaza <miguel@ximian.com>
10864 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
10866 (LoadAssembly): Do not add the dll if it is already specified
10868 (MainDriver): Add the System directory to the link path at the end,
10869 after all the other -L arguments.
10871 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
10872 wrong opcode for loading bytes and bools (ldelem.i1 instead of
10873 ldelem.u1) and using the opposite for sbytes.
10875 This fixes Digger, and we can finally run it.
10877 * driver.cs (UnixParseOption): Move the option parsing here.
10878 (CSCParseOption): Implement CSC-like parsing of options.
10880 We now support both modes of operation, the old Unix way, and the
10881 new CSC-like way. This should help those who wanted to make cross
10882 platform makefiles.
10884 The only thing broken is that /r:, /reference: and /lib: are not
10885 implemented, because I want to make those have the same semantics
10886 as the CSC compiler has, and kill once and for all the confussion
10887 around this. Will be doing this tomorrow.
10889 * statement.cs (Unsafe.Resolve): The state is checked during
10890 resolve, not emit, so we have to set the flags for IsUnsfe here.
10892 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10894 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
10895 not catch the Error_ObjectRefRequired in SimpleName (as it is
10896 possible to have a class/instance variable name that later gets
10897 deambiguated), we have to check this here.
10899 2002-07-10 Ravi Pratap <ravi@ximian.com>
10901 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
10902 make static and put into Expression.
10904 (Event.Define): Register the private field of the event with the
10905 TypeManager so that GetFieldFromEvent can get at it.
10907 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
10908 keep track of the private field associated with an event which
10911 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
10914 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
10916 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10918 * expression.cs (Binary.EmitBranchable): this routine emits the
10919 Binary expression in a branchable context. This basically means:
10920 we need to branch somewhere, not just get the value on the stack.
10922 This works together with Statement.EmitBoolExpression.
10924 * statement.cs (Statement.EmitBoolExpression): Use
10927 2002-07-09 Miguel de Icaza <miguel@ximian.com>
10929 * statement.cs (For): Reduce the number of jumps in loops.
10931 (For): Implement loop inversion for the For statement.
10933 (Break): We can be breaking out of a Try/Catch controlled section
10934 (foreach might have an implicit try/catch clause), so we need to
10935 use Leave instead of Br.
10937 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
10938 now). If the instace expression supports IMemoryLocation, we use
10939 the AddressOf method from the IMemoryLocation to extract the
10940 address instead of emitting the instance.
10942 This showed up with `This', as we were emitting the instance
10943 always (Emit) instead of the Address of This. Particularly
10944 interesting when This is a value type, as we dont want the Emit
10945 effect (which was to load the object).
10947 2002-07-08 Miguel de Icaza <miguel@ximian.com>
10949 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
10951 * statement.cs (Checked): Set the CheckedState during the resolve
10952 process too, as the ConvCast operations track the checked state on
10953 the resolve process, and not emit.
10955 * cs-parser.jay (namespace_member_declaration): Flag that we have
10956 found a declaration when we do. This is used to flag error 1529
10958 * driver.cs: Report ok when we display the help only.
10960 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
10962 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
10964 2002-07-04 Miguel de Icaza <miguel@ximian.com>
10966 * cs-tokenizer.cs (define): We also have to track locally the
10967 defines. AllDefines is just used for the Conditional Attribute,
10968 but we also need the local defines for the current source code.
10970 2002-07-03 Miguel de Icaza <miguel@ximian.com>
10972 * statement.cs (While, For, Do): These loops can exit through a
10973 Break statement, use this information to tell whether the
10974 statement is the last piece of code.
10976 (Break): Flag that we break.
10978 * codegen.cs (EmitContexts): New `Breaks' state variable.
10980 2002-07-03 Martin Baulig <martin@gnome.org>
10982 * class.cs (TypeContainer.MethodModifiersValid): Allow override
10983 modifiers in method declarations in structs. Otherwise, you won't
10984 be able to override things like Object.Equals().
10986 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10988 * class.cs (Method, Property, Indexer): Do not allow the public
10989 modifier to be used in explicit interface implementations.
10991 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
10992 override modifiers in method declarations in structs
10994 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
10996 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
10997 integer or real overflow, report an error
10999 2002-07-02 Martin Baulig <martin@gnome.org>
11001 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
11002 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
11003 to tell the runtime about our newly created System.Object and
11004 System.ValueType types.
11006 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11008 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
11009 struct instead of Ldarg/Starg.
11011 2002-07-02 Martin Baulig <martin@gnome.org>
11013 * expression.cs (Indirection.Indirection): Call
11014 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
11016 2002-07-02 Martin Baulig <martin@gnome.org>
11018 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
11019 ValueType, call TypeManager.TypeToCoreType() on it.
11020 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
11021 the OpCodes.Newarr argument.
11023 2002-07-02 Martin Baulig <martin@gnome.org>
11025 * expression.cs (Invocation.EmitCall): When compiling corlib,
11026 replace all calls to the system's System.Array type to calls to
11027 the newly created one.
11029 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
11030 System.Array methods.
11031 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
11032 from the system's System.Array type which must be replaced.
11034 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
11036 * typemanager.cs: load unverifiable_code_ctor so we can build
11037 corlib using the correct type. Avoid using GetTypeCode() with
11039 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
11040 TypeManager.object_type to allow building corlib.
11042 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
11044 * ecore.cs: handle System.Enum separately in LoadFromPtr().
11046 2002-07-01 Martin Baulig <martin@gnome.org>
11048 * class.cs: Make the last change actually work, we need to check
11049 whether `ifaces != null' to avoid a crash.
11051 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
11053 * class.cs: when we build structs without fields that implement
11054 interfaces, we need to add the interfaces separately, since there is
11055 no API to both set the size and add the interfaces at type creation
11058 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
11060 * expression.cs: the dimension arguments to the array constructors
11061 need to be converted if they are a long.
11063 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
11065 * class.cs: don't emit ldarg.0 if there is no parent constructor
11066 (fixes showstopper for corlib).
11068 2002-06-29 Martin Baulig <martin@gnome.org>
11070 MCS now compiles corlib on GNU/Linux :-)
11072 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
11073 ie. check for MethodImplOptions.InternalCall.
11075 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
11076 and TypeManager.attribute_type are null, so we must explicitly check
11077 whether parent is not null to find out whether it's an attribute type.
11078 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
11079 and SetBuilder, not only if the property is neither abstract nor external.
11080 This is necessary to set the MethodImplOptions on the accessor methods.
11081 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
11082 SetBuilder, see Property.Emit().
11084 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
11085 populate "System.Object", "System.ValueType" and "System.Attribute" since
11086 they've already been populated from BootCorlib_PopulateCoreTypes().
11088 2002-06-29 Martin Baulig <martin@gnome.org>
11090 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
11091 is the NullLiteral, we also need to make sure that target_type is not
11094 2002-06-29 Martin Baulig <martin@gnome.org>
11096 * rootcontext.cs (RootContext.ResolveCore): We must initialize
11097 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
11098 before calling BootstrapCorlib_ResolveDelegate ().
11100 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11102 * statement.cs: fixed build-breaker. All tests passed ok.
11104 2002-06-27 Martin Baulig <martin@gnome.org>
11106 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
11107 for System.Decimal when compiling corlib.
11109 2002-06-27 Martin Baulig <martin@gnome.org>
11111 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
11112 switch blocks which contain nothing but a default clause.
11114 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
11116 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
11118 2002-06-27 Martin Baulig <martin@gnome.org>
11120 * ecore.cs (PropertyExpr.PropertyExpr): Call
11121 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
11123 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
11124 is already a TypeBuilder.
11126 2002-06-27 Martin Baulig <martin@gnome.org>
11128 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
11129 `target_type == TypeManager.array_type', not IsAssignableFrom() in
11130 the "from an array-type to System.Array" case. This makes it work
11131 when compiling corlib.
11133 2002-06-27 Martin Baulig <martin@gnome.org>
11135 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
11136 non-static PropertyExpr, set its InstanceExpression. This makes
11137 the `ICollection.Count' property work in System/Array.cs.
11139 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
11141 * driver.cs: Made error handling more consistent. Errors now
11142 tracked by Report class, so many methods which used to return int
11143 now return void. Main() now prints success/failure and
11144 errors/warnings message.
11146 Renamed '--probe' compiler argument to '--expect-error'. Removed
11147 the magic number return values (123 and 124). Now, if the
11148 expected error occurs, the compiler exits with success (exit value
11149 0). If the compilation completes without seeing that particular
11150 error, the compiler exits with failure (exit value 1). The
11151 makefile in mcs/errors has been changed to handle the new behaviour.
11153 * report.cs: Made 'expected error' number a property and renamed
11154 it from 'Probe' to 'ExpectedError'.
11156 * genericparser.cs: Removed error handling support, since it is
11157 now all done by Report class.
11159 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
11160 class, so parse() no longer returns an int.
11162 * namespace.cs: Use Report.Error instead of GenericParser.error
11164 2002-06-22 Miguel de Icaza <miguel@ximian.com>
11166 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
11167 TypeContainer.AddOperator): At the front of the list put the
11168 explicit implementations, so they get resolved/defined first.
11170 2002-06-21 Miguel de Icaza <miguel@ximian.com>
11172 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
11173 interface type is implemented by this TypeContainer. Used during
11174 explicit interface implementation.
11176 (Property.Define, Indexer.Define, Method.Define): Validate that
11177 the given interface in the explicit implementation is one of the
11178 base classes for the containing type.
11180 Also if we are explicitly implementing an interface, but there is
11181 no match in the pending implementation table, report an error.
11183 (Property.Define): Only define the property if we are
11184 not explicitly implementing a property from an interface. Use the
11185 correct name also for those properties (the same CSC uses,
11186 although that is really not needed).
11188 (Property.Emit): Do not emit attributes for explicitly implemented
11189 properties, as there is no TypeBuilder.
11191 (Indexer.Emit): ditto.
11193 Hiding then means that we do not really *implement* a pending
11194 implementation, which makes code fail.
11196 2002-06-22 Martin Baulig <martin@gnome.org>
11198 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
11199 the return value of Object.GetType(). [FIXME: we need to do this whenever
11200 we get a type back from the reflection library].
11202 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
11204 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
11206 2002-06-20 Miguel de Icaza <miguel@ximian.com>
11208 * attribute.cs: Return null if we can not look up the type.
11210 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
11211 the interface types found.
11213 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
11214 interface types found.
11216 * typemanager.cs (GetInterfaces): Make this routine returns alll
11217 the interfaces and work around the lame differences between
11218 System.Type and System.Reflection.Emit.TypeBuilder in the results
11219 result for GetInterfaces.
11221 (ExpandInterfaces): Given an array of interface types, expand and
11222 eliminate repeated ocurrences of an interface. This expands in
11223 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
11226 2002-06-21 Martin Baulig <martin@gnome.org>
11228 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
11231 2002-06-21 Martin Baulig <martin@gnome.org>
11233 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
11234 and called with one of the core types, return the corresponding typebuilder for
11237 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
11240 2002-06-21 Martin Baulig <martin@gnome.org>
11242 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
11243 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
11244 (Expression.ConvertReferenceExplicit): Likewise.
11246 * expression.cs (ElementAccess.DoResolve): Likewise.
11247 (ElementAccess.DoResolveLValue): Likewise.
11249 2002-06-10 Martin Baulig <martin@gnome.org>
11251 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
11252 add the "value" parameter to the parameter list.
11254 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
11257 2002-06-19 Miguel de Icaza <miguel@ximian.com>
11259 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
11260 the argument to an int, uint, long or ulong, per the spec. Also
11261 catch negative constants in array creation.
11263 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
11265 * class.cs: do not allow the same interface to appear twice in
11266 the definition list.
11268 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
11270 * ecore.cs: don't use ldlen with System.Array.
11272 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
11274 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
11276 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
11278 * modifiers.cs: produce correct field attributes for protected
11279 internal. Easy fix so miguel can work on ther harder stuff:-)
11281 2002-06-18 Miguel de Icaza <miguel@ximian.com>
11283 * pending.cs: New file. Move the code from class.cs here.
11284 Support clearning the pending flag for all methods (when not doing
11285 explicit interface implementation).
11287 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
11289 * rootcontext.cs: added a couple more types needed to bootstrap.
11291 2002-06-17 Miguel de Icaza <miguel@ximian.com>
11293 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
11294 constructor in the type, instead of any constructor in the type
11295 hierarchy. Thanks to Paolo for finding this bug (it showed up as
11296 a bug in the Mono runtime when applying the params attribute).
11298 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11299 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
11301 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
11303 * expression.cs (Unary.ResolveOperator): Use TypeManager
11304 to resolve the type.
11306 2002-06-13 Ravi Pratap <ravi@ximian.com>
11308 * cs-parser.jay (enum_member_declaration): Pass in the attributes
11311 * enum.cs (AddEnumMember): Add support to store the attributes associated
11312 with each member too.
11314 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
11315 field builders too - this takes care of the enum member case.
11317 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
11319 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
11320 address-of operator on both value types and pointers.
11322 2002-06-10 Martin Baulig <martin@gnome.org>
11324 * interface.cs (Interface.PopulateIndexer): Add the indexer's
11325 PropertyBuilder to the `property_builders' list.
11327 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
11328 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
11329 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
11330 find any indexers which are inherited from an interface.
11332 2002-06-09 Martin Baulig <martin@gnome.org>
11334 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
11335 the same type as the constant if necessary. There's also a test-130.cs
11338 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
11340 * typemanager.cs (TypeManager.ChangeType): Previously known as
11341 Enum.ChangeEnumType().
11343 2002-06-09 Martin Baulig <martin@gnome.org>
11345 * expression.cs (Cast.TryReduce): Added support for consts.
11347 2002-06-08 Ravi Pratap <ravi@ximian.com>
11349 * class.cs (Accessor): Hold attributes information so we can pass
11352 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
11353 Modify to pass in attributes attached to the methods.
11355 (add_accessor_declaration, remove_accessor_declaration): Ditto.
11357 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
11358 to handle the Accessor kind :-)
11360 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
11362 2002-06-08 Martin Baulig <martin@gnome.org>
11364 * expression.cs (Unary.TryReduceNegative): Added support for
11367 2002-06-08 Martin Baulig <martin@gnome.org>
11369 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
11370 name can't be found in the `defined_names' - the caller will do a
11371 MemberLookup in this case and thus find methods in System.Enum
11372 such as Enum.IsDefined().
11374 2002-06-08 Martin Baulig <martin@gnome.org>
11376 * enum.cs (Enum.ChangeEnumType): This is a custom version of
11377 Convert.ChangeType() which works with TypeBuilder created types.
11378 (Enum.LookupEnumValue, Enum.Define): Use it here.
11380 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
11381 `TypeBuilder.BaseType != null' check.
11382 (TypeContainer.FindMembers): Only lookup parent members if we
11383 actually have a parent.
11384 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
11385 (ConstructorInitializer.Resolve): Likewise.
11387 * interface.cs (Interface.FindMembers): Added
11388 `TypeBuilder.BaseType != null' check.
11390 * rootcontext.cs (RootContext.ResolveCore): Added
11391 "System.Runtime.CompilerServices.IndexerNameAttribute" to
11392 classes_second_stage.
11394 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
11395 debug_type and trace_type when compiling with --nostdlib.
11397 2002-06-07 Martin Baulig <martin@gnome.org>
11399 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
11400 (AddField): Set it to true when adding a non-static field.
11401 (DefineType): Use `have_nonstatic_fields' to find out whether we
11402 have non-static fields, not `Fields != null'.
11404 2002-06-02 Miguel de Icaza <miguel@ximian.com>
11406 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
11407 dereferencing a null on the static-field code path)
11409 2002-05-30 Martin Baulig <martin@gnome.org>
11411 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
11412 to take command line arguments. Use reflection to call the new
11413 custom `Initialize' function on the symbol writer and pass it the
11414 command line arguments.
11416 * driver.cs (--debug-args): New command line argument to pass command
11417 line arguments to the symbol writer.
11419 2002-05-28 Miguel de Icaza <miguel@ximian.com>
11421 * assign.cs (DoResolve): Forgot to do the implicit conversion to
11422 the target type for indexers and properties. Thanks to Joe for
11425 2002-05-27 Miguel de Icaza <miguel@ximian.com>
11427 * typemanager.cs (MethodFlags): returns the method flags
11428 (Obsolete/ShouldIgnore) that control warning emission and whether
11429 the invocation should be made, or ignored.
11431 * expression.cs (Invocation.Emit): Remove previous hack, we should
11432 not do this on matching a base type, we should do this based on an attribute
11434 Only emit calls to System.Diagnostics.Debug and
11435 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
11436 on the command line.
11438 * rootcontext.cs: Global settings for tracing and debugging.
11440 * cs-tokenizer.cs (define): New utility function to track
11441 defines. Set the global settings for TRACE and DEBUG if found.
11443 2002-05-25 Ravi Pratap <ravi@ximian.com>
11445 * interface.cs (Populate*): Pass in the TypeContainer as well as
11446 the DeclSpace as parameters so that we can create EmitContexts and
11447 then use that to apply attributes etc.
11449 (PopulateMethod, PopulateEvent, PopulateProperty)
11450 (PopulateIndexer): Apply attributes everywhere.
11452 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
11455 (ApplyAttributes): Update accordingly.
11457 We now apply interface attributes for all members too.
11459 2002-05-26 Miguel de Icaza <miguel@ximian.com>
11461 * class.cs (Indexer.Define); Correctly check if we are explicit
11462 implementation (instead of checking the Name for a ".", we
11463 directly look up if the InterfaceType was specified).
11465 Delay the creation of the PropertyBuilder.
11467 Only create the PropertyBuilder if we are not an explicit
11468 interface implementation. This means that explicit interface
11469 implementation members do not participate in regular function
11470 lookups, and hence fixes another major ambiguity problem in
11471 overload resolution (that was the visible effect).
11473 (DefineMethod): Return whether we are doing an interface
11476 * typemanager.cs: Temporary hack until we get attributes in
11477 interfaces (Ravi is working on that) and we get IndexerName
11478 support in interfaces.
11480 * interface.cs: Register the indexers as properties.
11482 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11483 warning, I have verified that this is a bug in the .NET runtime
11484 (JavaScript suffers of the same problem).
11486 * typemanager.cs (MemberLookup): When looking up members for
11487 interfaces, the parent of an interface is the implicit
11488 System.Object (so we succeed in searches of Object methods in an
11489 interface method invocation. Example: IEnumerable x; x.ToString
11492 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11494 * class.cs (Event): Events should also register if they do
11495 implement the methods that an interface requires.
11497 * typemanager.cs (MemberLookup); use the new GetInterfaces
11500 (GetInterfaces): The code used to lookup interfaces for a type is
11501 used in more than one place, factor it here.
11503 * driver.cs: Track the errors at the bottom of the file, we kept
11506 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11507 instance if the method we are calling is static!
11509 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11511 * attribute.cs (ApplyAttributes): Make this function filter out
11512 the IndexerName attribute (as that attribute in reality is never
11513 applied) and return the string constant for the IndexerName
11516 * class.cs (TypeContainer.Emit): Validate that all the indexers
11517 have the same IndexerName attribute, and if so, set the
11518 DefaultName attribute on the class.
11520 * typemanager.cs: The return value might contain other stuff (not
11521 only methods). For instance, consider a method with an "Item"
11522 property and an Item method.
11524 * class.cs: If there is a problem with the parameter types,
11527 2002-05-24 Ravi Pratap <ravi@ximian.com>
11529 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11530 looks at user defined conversion after making a call to
11531 StandardConversionExists - we need this for overload resolution.
11533 * expression.cs : Update accordingly the various method calls.
11535 This fixes 2 bugs filed against implicit user defined conversions
11537 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11539 * statement.cs: Track the result of the assignment.
11541 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11543 * expression.cs (MemberAccess): Improved error reporting for
11544 inaccessible members.
11546 2002-05-22 Martin Baulig <martin@gnome.org>
11548 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11549 itself with debugging support.
11551 2002-05-22 Martin Baulig <martin@gnome.org>
11553 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11554 Removed, this isn't needed anymore.
11556 2002-05-20 Martin Baulig <martin@gnome.org>
11558 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11559 be underlying type for an enum.
11561 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11563 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11564 that splits out the loading of just the core types.
11566 * rootcontext.cs (ResolveCore): Split the struct resolution in
11567 two, so we can load the enumeration underlying types before any
11570 * expression.cs (Is): Bandaid until we fix properly Switch (see
11571 bug #24985 for details).
11573 * typemanager.cs (ImplementsInterface): The hashtable will contain
11574 a null if there are no interfaces implemented.
11576 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11578 * cs-parser.jay (indexer_declarator): It is fine to have array
11581 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11583 * typemanager.cs: (RegisterBuilder): New function used to register
11584 TypeBuilders that implement interfaces. Since
11585 TypeBuilder.GetInterfaces (as usual) does not work with lame
11587 (AddUserType): register interfaces.
11589 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11590 dealing with TypeBuilder. Also, arrays are showing up as
11591 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11592 methods can not be invoked on them!
11594 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11595 (ImplicitReferenceConversionExists): Split out from
11596 StandardConversionExists.
11598 * expression.cs (As): We were only implementing one of the three
11599 cases for the as operator. We now implement them all.
11600 (Is): Implement the various other cases for Is as well.
11602 * typemanager.cs (CACHE): New define used to control if we want or
11603 not the FindMembers cache. Seems to have a negative impact on
11604 performance currently
11606 (MemberLookup): Nested types have full acess to
11607 enclosing type members
11609 Remove code that coped with instance/static returns for events, we
11610 now catch this in RealFindMembers.
11612 (RealFindMembers): only perform static lookup if the instance
11613 lookup did not return a type or an event.
11615 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11617 * assign.cs (CompoundAssign): We pass more semantic information
11618 now to Compound Assignments than we did before: now we have all
11619 the information at hand, and now we resolve the target *before* we
11620 do the expression expansion, which allows the "CacheValue" method
11621 to have the effect we intended (before, a [x] += 1 would generate
11622 two differen ArrayAccess expressions from the ElementAccess,
11623 during the resolution process).
11625 (CompoundAssign.DoResolve): Resolve target and original_source here.
11627 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11629 * expression.cs (ArrayAccess): dropped debugging information.
11631 * typemanager.cs: Small bug fix: I was always returning i_members,
11632 instead of one of i_members or s_members (depending on which had
11635 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11636 method is invoked before any code generation takes place, and it
11637 is a mechanism to inform that the expression will be invoked more
11638 than once, and that the method should use temporary values to
11639 avoid having side effects
11641 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11643 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11646 * expression.cs (Indirection, ArrayAccess): Add support for
11647 CacheTemporaries in these two bad boys.
11649 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11650 ldobj or ldind_ref.
11651 (StoreFromPtr): Handle stobj as well.
11653 * expression.cs (UnaryMutator): Share more code.
11655 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11656 down: I was not tracking the Filter function as well, which
11657 was affecting the results of the cache.
11659 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11661 * attribute.cs: Remove the hack to handle the CharSet property on
11664 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11666 * attribute.cs (DoResolve): More uglyness, we now only try to
11667 resolve the attribute partially, to extract the CharSet
11668 information (only if we are a StructLayout attribute). Otherwise
11670 (GetExtraTypeInfo): Add some code to conditionally kill in the
11671 future this. I am more and more convinced that the .NET
11672 framework has special code to handle the attribute setting on
11675 * expression.cs (IsParamsMethodApplicable): Revert my previous
11676 foreach change here, it was wrong.
11678 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11680 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11681 (pp_expr): do not abort on unknown input, just return.
11682 (eval): abort if there are pending chars.
11684 * attribute.cs (Attribute.Resolve): Positional parameters are
11685 optional. Deal with that case.
11687 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11688 the Ansi/Unicode/Auto information for the type.
11690 (TypeContainer.DefineType): instantiate the EmitContext here, as
11691 we will be using it during the type definition (to resolve
11692 attributes) and during the emit phase.
11694 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11695 to pull type information out of the attributes
11697 (Attribute.Resolve): track the constructor builder, and allow for
11698 multiple invocations (structs and classes will use this).
11700 * ecore.cs (MemberLookupFinal): new version with all the
11701 parameters customizable.
11703 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11704 constructors. Return if the result value is null (as the error
11705 would have been flagged already by MemberLookupFinal)
11707 Do not allow instances of abstract classes or interfaces to be
11710 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11711 We have to compare the assembly property here when dealing with
11712 FamANDAssem and Assembly access modifiers, because we might be
11713 creating an assembly from *modules* (that means that we are not
11714 getting TypeBuilders for types defined in other modules that are
11715 part of this assembly).
11717 (Method.Emit): If the method is marked abstract and has a body,
11720 (TypeContainer.DefineMembers): If both the defined member and the
11721 parent name match are methods, then do not emit any warnings: let
11722 the Method.Define routine take care of flagging warnings. But if
11723 there is a mismatch (method overrides something else, or method is
11724 overriwritten by something, then emit warning).
11726 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11727 set to null, this means `do not check for the return type on the
11730 (Method.Define): set the return type for the method signature to
11731 null, so that we get methods with the same name and parameters and
11732 different return types. This is used to flag warning 114 (you are
11733 hiding a method, and you probably want to use the new/override
11736 * typemanager.cs (MemberLookup): Implemented proper access
11737 control, closing a long standing set of bug reports. The problem
11738 was that the Framework only has two bits: Public and NonPublic,
11739 and NonPublic includes private and protected methods, but we need
11740 to enforce the FamANDAssem, FamOrAssem and Family.
11742 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11744 * statement.cs (GotoCase): Return true: Ammounts to giving up
11745 knowledge on whether we return or not, and letting the other case
11746 be responsible for it.
11748 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11750 * driver.cs: Do not load directories for each file processed, only
11751 do it if there is a pattern.
11753 * ecore.cs: Report readonly assigns here as well, as we might have
11754 been resolved only by MemberAccess.
11756 (SimpleName.SimpleNameResolve): Also be useful for LValue
11757 resolution. We need this to propagate assign to local readonly variables
11759 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11760 do not want to reuse potential criteria memory.
11762 * class.cs (MyEventBuilder): Set reflected_type;
11764 * ecore.cs (Constantify): Added support for constifying bools.
11766 (RootContext.LookupType): Added a cache for values looked up in
11767 the declaration space.
11769 * typemanager.cs (FindMembers): Now is a front-end to
11770 RealFindMembers, and provides a two-level hashtable-based cache to
11773 15% performance improvement: from 22.5 to 19.2 seconds.
11775 * expression.cs (IsParamsMethodApplicable): use foreach.
11776 (Invocation.DoResolve): ditto.
11777 (New.DoResolve): ditto.
11778 (ArrayCreation.DoResolve): ditto.
11780 * ecore.cs (FindMostEncompassingType): use foreach.
11782 * delegate.cs (NewDelegate.DoResolve): Use foreach
11784 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11785 (RemoveMethods): use foreach.
11787 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11788 nested foreach statements instead of for, and also break out of
11789 the inner loop once a match is found.
11791 (Invocation.OverloadResolve): Use foreach, simplify the code.
11793 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11795 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11796 we actually unwrap the expression to allow for extra information
11799 * expression.cs: Use Shr_Un on unsigned operations.
11801 2002-05-08 Ravi Pratap <ravi@ximian.com>
11803 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11804 applicable operators was not being considered correctly. This closes
11805 the bug Miguel reported.
11807 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11809 * attribute.cs: check that the type derives from System.Attribute
11810 and report the correct error in that case (moved the duplicate code to
11811 its own method, too).
11813 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11815 * attribute.cs: lookup attribute type name as the spec says: first the
11816 bare attribute name and then name + "Attribute" (nant compiles with
11817 mcs after this fix).
11819 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11821 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11822 Because of the way we parse things, we should try to see if a
11823 UIntConstant can fit in an integer.
11825 2002-05-07 Ravi Pratap <ravi@ximian.com>
11827 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11828 when we are in an explicit context.
11830 (ConvertReferenceExplicit): When converting from Iface type S to Class
11831 T make sure the rules are implemented as an OR.
11833 * parameter.cs (ParameterType): Make it a property for now although the
11834 purpose really isn't anything immediate.
11836 * expression.cs (Is*Applicable): Do better checking on the parameter type
11837 of a ref/out parameter. The ones from the system assemblies are already
11838 marked with the correct type so we don't need to do any correction.
11840 * ecore.cs (StandardConversionExists): Conversion from Interface types to
11841 the object type is standard too so include that.
11843 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11845 * ecore.cs (StandardConversionExists): Augment with missing code:
11846 deal with IntConstant, LongConstants and Enumerations.
11848 * assign.cs: Report the error, instead of failing silently
11850 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
11851 typecontainer that they are declared, because the
11852 typecontainer/namespace will have the list of using clauses that
11853 need to be applied.
11855 Assembly Attributes were escaping the normal registration
11858 (EmitCode): Apply attributes within an EmitContext that represents
11859 the container they were declared on.
11861 * cs-parser.jay: Track bases for structs. How did I get this wrong?
11863 2002-05-06 Ravi Pratap <ravi@ximian.com>
11865 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
11866 Revamp completely - make much cleaner as we now operate only
11869 (FindMostSpecificSource, FindMostSpecificTarget): New methods
11870 to implement the logic detailed in the spec more correctly.
11872 (UserDefinedConversion): Update accordingly.
11874 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11876 * statement.cs: Return flow analysis information up.
11878 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
11881 (token): Do not consume an extra character before calling
11884 2002-05-06 Piers Haken <piersh@friskit.com>
11886 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
11888 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11890 * class.cs (Constructor.Emit): Set the IsStatic flag in the
11891 EmitContext during the instance constructor initializer
11892 resolution, to stop access to instance variables.
11894 This is mandated by the spec, last paragraph of the `constructor
11895 initializers' section.
11897 2002-05-05 Miguel de Icaza <miguel@ximian.com>
11899 * cs-parser.jay, class.cs (Accessor): new class used to represent
11900 an accessor (get or set). In the past we used `null' to represent
11901 a missing accessor. But this is ambiguous because there was no
11902 way to tell in abstract indexers/properties if one of them was
11905 Now there is a way of addressing that.
11907 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
11908 instead of FindMembers.
11910 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
11911 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
11913 * attribute.cs: Treat indexers and properties as the same in terms
11914 of applying attributes
11916 * ecore.cs (FindMostEncompassedType): Use statically initialized
11917 EmptyExpressions()s like we do elsewhere to avoid creating useless
11918 objects (and we take this out of the tight loop).
11920 (GetConversionOperators): Move the code to extract the actual
11921 operators to a separate routine to clean things up.
11923 2002-05-04 Miguel de Icaza <miguel@ximian.com>
11925 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
11926 events are always registered FieldBuilders.
11928 * class.cs (FieldBase): New class shared by Fields
11930 * delegate.cs: If we are a toplevel delegate, use our full name.
11931 If we are a nested delegate, then only use our tail name.
11933 2002-05-02 Ravi Pratap <ravi@ximian.com>
11935 * expression.cs (IsApplicable): Ensure that we add the "&" to
11936 ref/out types before comparing it with the type of the argument.
11938 (IsParamsMethodApplicable): Ditto.
11940 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
11943 * delegate.cs : Handle the case when we have more than one applicable
11944 method. Flag an error only when we finish checking all.
11946 2002-05-02 Miguel de Icaza <miguel@ximian.com>
11948 * expression.cs: Add support for boolean static initializers.
11950 2002-05-01 Miguel de Icaza <miguel@ximian.com>
11952 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
11954 * parameter.cs (ComputeParameterTypes,
11955 ComputeAndDefineParameterTypes): Better error handling: now we
11956 clear the `types' cache if we fail during any of the type lookups.
11957 We also return the status code correctly to our caller
11959 * delegate.cs: If we fail to define a delegate, abort the extra
11962 * expression.cs (Binary.ResolveOperator): for
11963 operator==(object,object) and operator !=(object, object) we also
11964 have to verify that there is an implicit conversion from one to
11967 (ArrayAccess.DoResolve): Array Access can operate on
11970 2002-04-30 Miguel de Icaza <miguel@ximian.com>
11972 * assign.cs (CompoundAssign): A new class used as a "flag" that
11973 the assignment actually is happening as part of a compound
11974 assignment operator.
11976 During compound assignment, a few new rules exist to enable things
11983 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
11984 to the type of x) if y is implicitly convertible to the type of x,
11985 and the operator is a builtin operator and the return type of the
11986 operator is explicitly convertible to the type of x.
11988 * rootcontext.cs: Reset warning level to 2. 4 catches various
11989 "interesting" features in mcs, we must clean this up at some
11990 point, but currently am trying to kill other bugs ;-)
11992 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
11993 in container classes as well.
11995 * expression.cs (Binary.ResolveOperator): Handle string case
11996 before anything else (as operator overloading does emit an error
11997 before doing anything else).
11999 This code could go away when we move to a table driven model, but
12000 i could not come up with a good plan last night.
12002 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
12004 * typemanager.cs (CSharpName): reimplementation using regex.
12005 * class.cs: added null check for fields in Emit
12006 * rootcontext.cs: set warninglevel to 4
12008 2002-04-29 Miguel de Icaza <miguel@ximian.com>
12010 * typemanager.cs (CSharpName): reimplemented with Lupus
12013 2002-04-28 Miguel de Icaza <miguel@ximian.com>
12015 * statement.cs (If): correclty implement Resolve, because we were
12016 not catching sem errors in there. The same process is needed
12018 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
12021 (Statement.Warning_DeadCodeFound): Factorize code.
12022 (While): Report dead code here too.
12024 (Statement): Added Resolve virtual method to allow
12025 for resolution split from the emit code.
12027 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12029 * statement.cs (EmitBoolExpression): No longer try to resolve the
12031 (MakeBoolean): New utility function that resolve, implicitly
12032 converts to boolean and tags the expression.
12035 (If, Do): Implement dead code elimination.
12036 (While): Implement loop inversion
12038 (Do, While, For, If): Resolve the expression prior to calling our
12041 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
12044 - added method Report28 (warning: program has more than one entry point)
12045 - added method IsEntryPoint, implements paragraph 10.1 of the spec
12046 - modified method Method.Define, the part at the end of the method
12048 * rootcontext.cs: added static public Location EntryPointLocation;
12050 * ../errors/cs0028.cs : Add test case for the above warning.
12053 - modified method CSharpName to allow arrays of primitive type to
12054 be printed nicely (e.g. instead of System.Int32[][] it now prints
12056 - added method CSharpSignature: returns the signature of a method
12057 in string format to be used in reporting errors, warnings, etc.
12059 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
12062 2002-04-26 Ravi Pratap <ravi@ximian.com>
12064 * delegate.cs (Define): Fix extremely silly bug where I was
12065 setting the type of the 'object' parameter of the BeginInvoke
12066 method to System.IAsyncResult instead of System.Object ;-)
12068 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12070 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
12073 (Constructor.Emit): return if we fail to initialize the
12074 constructor. Another door closed!
12076 * expression.cs (New.DoResolve): Improve error message (from -6 to
12077 1501). Use DeclaredOnly lookup to find the exact constructor.
12079 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
12080 loop. This is useful.
12082 * cs-parser.jay: Adjust the default parameters so that destructors
12083 have the proper signature.
12085 2002-04-26 Martin Baulig <martin@gnome.org>
12087 * driver.cs (LoadAssembly): If `assembly' contains any characters
12088 which are only valid in path names and not in assembly names
12089 (currently slash, backslash and point), use Assembly.LoadFrom ()
12090 instead of Assembly.Load () on the `assembly' (before iteration
12091 over the link_paths).
12093 2002-04-26 Martin Baulig <martin@gnome.org>
12095 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
12097 2002-04-25 Miguel de Icaza <miguel@ximian.com>
12099 * class.cs (Property): use the new typemanager.MemberLookup
12101 (TypeContainer.MemberLookup): Implement using the
12102 TypeManager.MemberLookup now.
12104 * typemanager.cs: Make MemberLookup a function of the TypeManager,
12105 and return MemberInfos, so that these can be used without an
12106 EmitContext (what we had before).
12108 2002-04-24 Miguel de Icaza <miguel@ximian.com>
12110 * expression.cs: Fix the case where the argument to params if the
12111 type of the params. I omitted handling this before. Fixed
12113 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12115 * driver.cs: Call BootCorlib_PopulateCoreType
12117 * class.cs (Property.CheckBase): Check for properties only, not
12120 * interface.cs: Temporary hack: try/catch around the
12121 CustomAttributeBuilder, because I am getting an exception that I
12124 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
12125 types whose definitions are required to be there (attributes are
12126 defined before standard types).
12128 Compute definitions as we boot the various types, as they are used
12129 immediately (value_type class will need object_type, but if we do
12130 not initialize object_type, we will pass a null, which will let
12131 the runtime pick the System.Object from the existing corlib, which
12132 is not what we want).
12134 2002-04-22 Patrik Torstensson <totte@labs2.com>
12136 * cs-tokenizer.cs: fixed a number of trim() issues.
12138 2002-04-22 Ravi Pratap <ravi@ximian.com>
12140 * expression.cs (Argument.Type): Ensure that we return the correct
12141 type when we have out or ref parameters [in which case we
12144 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12146 * class.cs (Property, Indexer): Allow extern modifier in there.
12148 * typemanager.cs (InitBaseTypes): Initializes object_type and
12149 value_type, since those will be used early on during the bootstrap
12150 process to compile corlib.
12152 (InitCoreTypes): Move code from here to InitBaseTypes.
12154 2002-04-21 Miguel de Icaza <miguel@ximian.com>
12156 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
12157 single-dimension arrays as using the ldlen opcode.
12159 Daniel Lewis discovered this optimization.
12161 * typemanager.cs: Add signature for System.Array::get_Length
12163 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12165 * statement.cs: report the error when the foreach does not apply to an
12166 array nor a collection.
12168 2002-04-19 Miguel de Icaza <miguel@ximian.com>
12170 * expression.cs: Add implicit conversions to the operator ~.
12172 * constant.cs (DecimalConstant.Emit): Emit decimal value.
12174 * typemanager.cs: Locate the decimal constructor.
12176 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12178 * attribute.cs: use the new property of TypeOf.
12179 * expression.cs: added 'get' property around typearg.
12181 These changes fix a build breaker reported by NickD. Is this the
12182 correct way to fix? If not, please, revert my changes and make it
12185 2002-04-17 Miguel de Icaza <miguel@ximian.com>
12187 * attribute.cs: Add support for typeof in attribute invocations.
12188 I am not sure that this is right though.
12190 2002-04-14 Duncan Mak <duncan@ximian.com>
12192 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
12193 Binary.Operator.Division case.
12195 2002-04-13 Ravi Pratap <ravi@ximian.com>
12197 * class.cs (DefineType): Ensure that we do a proper check on
12198 attribute types and also register it with the TypeManager.
12200 (TypeContainer.Targets): The default for attribute types is
12201 AttributeTargets.All.
12203 * attribute.cs (ApplyAttributes): Registering the attribute type
12204 is done elsewhere, not when we discover we have a Usage attribute.
12206 2002-04-12 Ravi Pratap <ravi@ximian.com>
12208 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
12209 and get rid of is_delegate parameter.
12211 * everywhere : update.
12213 2002-04-12 Ravi Pratap <ravi@ximian.com>
12215 * cs-parser.jay (compilation_unit): Revamp completely to use
12216 some new ideas that I got from Rhys' grammar to solve the problems
12217 with assembly level attributes.
12219 (outer_declaration): New grammar production.
12221 (attribute_sections): Add.
12223 (opt_attributes): Base on attribute_sections
12225 (namespace_declaration): Allow opt_attributes to tackle the case
12226 when we have assembly level attributes - we are clever in this
12229 * attribute.cs (ApplyAttributes): Do not worry about assembly
12230 attributes in the non-global context.
12232 * rootcontext.cs (AddGlobalAttributes): Go back to using this
12233 instead of SetGlobalAttributes.
12235 * class.cs, rootcontext.cs : Ensure we define and generate
12236 attribute types before anything else.
12238 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
12239 and flag the new error -20 for the case when the attribute type
12240 does not have valid targets specified. csc does not catch this.
12242 * ../errors/errors.txt : update for error # -20
12244 2002-04-11 Ravi Pratap <ravi@ximian.com>
12246 * support.cs (InternalParameters.ParameterModifier): Do some null
12247 checking and return sane values.
12249 * class.cs (Method.Define): If we are a PInvoke method, ensure
12250 that we are static and extern. Report error # 601
12252 * ../errors/cs0601.cs : Add test case for the above error.
12254 2002-04-07 Ravi Pratap <ravi@ximian.com>
12256 * rootcontext.cs (attribute_types): We need to keep type of
12257 all attribute types separately and emit code for them first.
12259 (RegisterAttribute) : Implement.
12261 * class.cs (DefineType): Check if the current Type is a custom
12262 attribute type and register it accordingly.
12264 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
12265 adding the first attribute twice and rename to
12267 (SetGlobalAttributes): this.
12269 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
12272 * attribute.cs (ApplyAttributes): Take an additional argument telling us
12273 if we are processing global arguments. Hmm, I am unsure of this.
12275 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12277 * expression.cs: added static array of strings to avoid calling
12278 Enum.ToString () for Operator in Binary. Significant recover of
12281 2002-04-10 Miguel de Icaza <miguel@ximian.com>
12283 * class.cs (FindMembers): Allow the Builders of the various
12284 members to be null. If they are skip them. This only happens
12285 during the PInvoke declaration.
12287 2002-04-09 Miguel de Icaza <miguel@ximian.com>
12289 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
12290 failure, so we do not keep going afterwards.
12292 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
12293 wanted to pass `false' as the `is_delegate' argument. If this is
12294 the case, why not use delegate_type == null to mean `is_delegate =
12295 false' and anything else as is_delegate = true.
12297 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
12299 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
12300 code for the section, not the beginning of the tests.
12302 2002-04-08 Miguel de Icaza <miguel@ximian.com>
12304 * cfold.cs: Handle operator + (Enum x, Underlying x)
12306 * expression.cs (Binary): same. Warn about errors where we have
12307 Enum/Enum in operator + as well.
12309 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
12312 - added support for switch(bool)
12313 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
12314 - add TableSwitchEmit() to handle table-based switch statements
12316 2002-04-05 Ravi Pratap <ravi@ximian.com>
12318 * expression.cs (Invocation.OverloadResolve): Factor out code which
12319 does parameter compatibility checking with arguments so that we can
12320 re-use the code even from Delegate.VerifyApplicability
12322 (VerifyArgumentsCompat): Move above code here.
12324 * delegate.cs (VerifyApplicability): Get rid of duplicate code
12325 and instead make a call to the above method.
12327 2002-03-31 Ravi Pratap <ravi@ximian.com>
12329 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
12330 We use it to keep track of classes which are attribute types.
12332 2002-04-02 Miguel de Icaza <miguel@ximian.com>
12334 * delegate.cs (Delegate.Define): Correctly define the types in the
12335 presence of fixed and array parameters.
12337 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
12340 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
12341 include NonPublic after the first iteration.
12343 * class.cs (Indexer.CheckBase): Only check if both parents are
12346 * cs-parser.jay (accessor_body): If empty, set to null.
12348 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
12349 same code path here to resolve constants names that we did have in
12350 MemberAccess.DoResolve. There is too much code duplicated here.
12352 2002-04-01 Miguel de Icaza <miguel@ximian.com>
12354 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
12356 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
12359 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
12360 tokens, numbers and strings.
12362 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
12365 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
12366 asyncronous parameters and the regular parameters.
12368 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
12369 specify the target directory.
12371 * expression.cs: (This.DoResolve): Simplify
12372 (As.Emit): Optimize, do not generate IsInst if the expression is
12373 always of the given type.
12375 (Is.DoResolve): Bug fix, we were reporting both always/never for
12378 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
12379 creating too many unnecessary arrays.
12381 2002-03-31 Miguel de Icaza <miguel@ximian.com>
12383 * class.cs (EmitFieldInitializer): Use Assign expression to assign
12384 fields instead of rolling our own initializer. Takes care of all
12385 implicit conversions, and drops unnecessary static checks/argument.
12387 2002-03-31 Dick Porter <dick@ximian.com>
12389 * driver.cs: use the GetDirectories() return values properly, and
12390 use "/" as path separator.
12392 2002-03-30 Miguel de Icaza <miguel@ximian.com>
12394 * expression.cs (Unary): Optimize - - expr into expr.
12395 (Binary): Optimize a + (-b) into a -b.
12397 * codegen.cs (CodeGen): Made all methods static.
12399 2002-03-29 Miguel de Icaza <miguel@ximian.com>
12403 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
12404 TypeBuilder property.
12406 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
12409 * tree.cs: Removed the various RecordXXXX, and replaced with a
12410 single RecordDecl. Removed all the accessor methods, and just
12411 left a single access point Type
12413 * enum.cs: Rename DefineEnum to DefineType.
12415 * decl.cs: New abstract method `DefineType' used to unify the
12416 Defines for Enumerations, Interfaces, TypeContainers and
12419 (FindType): Moved LookupInterfaceOrClass here. Moved the
12420 LookupBaseClasses method that used to live in class.cs and
12421 interface.cs here, and renamed to FindType.
12423 * delegate.cs: Implement DefineType. Take advantage of the
12424 refactored pattern for locating the parent builder without taking
12425 the parent_builder argument (which we know does not work if we are
12426 nested, and triggering a toplevel definition).
12428 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12430 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
12431 accessibility of a member has changed during override and report
12434 * class.cs (Method.Define, Property.Define): Only complain on
12435 overrides if the method is private, any other accessibility is
12436 fine (and since we just checked the permission is the same, we are
12439 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
12440 and elif are processed always. The other pre-processing
12441 directives are only processed if we are "taking" the path
12443 2002-03-29 Martin Baulig <martin@gnome.org>
12445 * class.cs (Method.Emit): Only emit symbolic debugging info if the
12446 current location is not Null.
12448 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
12449 a separate method so we can profile it.
12451 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
12452 `span.Seconds' are just seconds, but no minutes or hours.
12453 (MainDriver): Profile the CodeGen.SaveSymbols calls.
12455 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12457 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
12458 Remove the gratuitous set of Final:
12460 // If an interface implementation, then we can set Final.
12461 if (((flags & MethodAttributes.Abstract) == 0) &&
12462 implementing.DeclaringType.IsInterface)
12463 flags |= MethodAttributes.Final;
12465 I do not know what I was smoking when I used that.
12468 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
12469 step into fixing the name resolution issues for delegates and
12470 unifying the toplevel name resolution.
12472 2002-03-28 Martin Baulig <martin@gnome.org>
12474 * class.cs (Method.Emit): If we have a symbol writer, call its
12475 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
12476 tell it about the current method.
12478 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
12479 writer that we're going to emit the first byte of IL code for a new
12480 statement (a new source line).
12481 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12482 EmitContext.Mark() before emitting any code.
12484 * location.cs (SymbolDocument): Return null when we're Null.
12486 * statement.cs (Statement): Moved the `Location loc' variable here.
12487 (Statement.EmitBoolExpression): If we have a symbol writer, call
12488 ec.Mark() before emitting any code to tell it that we're at the
12489 beginning of a new statement.
12490 (StatementExpression): Added `Location' argument to the constructor.
12491 (Block): Added public readonly variable `StartLocation' and public
12492 variable `EndLocation'. The latter is to be set using SetEndLocation().
12493 (Block): Added constructor which takes a start and end location.
12494 (Block.SetEndLocation): New method. This sets the end location.
12495 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12496 local variables we create.
12497 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12498 each statement and do also mark the begin and end of the block.
12500 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12501 tell it the current lexer.Location, use Location.Null for the end of the
12503 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12504 current block, set its end location using SetEndLocation().
12505 (statement_expression): StatementExpression constructor now takes the
12506 lexer.Location as additional argument.
12507 (for_statement, declare_local_variables): Likewise.
12508 (declare_local_variables): When creating a new implicit block, use the
12509 new Block constructor and pass it the lexer.Location.
12511 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12513 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12514 members also on the parent interfaces recursively.
12516 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12518 * report.cs: Use new formats, since Gonzalo finished the missing
12521 * expression.cs (Binary.ResolveOperator): added missing operator|
12522 operator& and operator^ for bool/bool.
12524 * cs-parser.jay: CheckDef now takes a Location argument that is
12525 used to report errors more precisly (instead of reporting the end
12526 of a definition, we try to track something which is a lot closer
12527 to the source of the problem).
12529 * cs-tokenizer.cs: Track global token use, so we can properly flag
12530 the use of #define/#undef after the first token has been seen.
12532 Also, rename the reportXXXX to Error_DescriptiveName
12534 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12535 TypeContainer, so that Enum and Interface can use this too.
12537 * class.cs (TypeContainer.LookupInterfaceOrClass,
12538 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12539 `builder' argument. Typically this was used to pass the parent
12540 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12543 The problem is that a nested class could trigger the definition of
12544 a toplevel class, and the builder would be obviously wrong in that
12547 So we drop this argument, and we compute dynamically the
12548 TypeBuilder/ModuleBuilder (the correct information was available
12549 to us anyways from DeclSpace.Parent)
12551 * interface.cs (Interface.DefineInterface): Drop builder
12552 parameter cleanup like class.cs
12554 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12557 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12560 (Try.Emit): Propagate the returns value from the statement.
12562 (Return.Emit): Even if we are leavning
12564 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12566 * modifiers.cs: Fix the computation of MethodAttributes flags.
12568 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12570 * driver.cs: allow compilation of files that start with '/'.
12571 Add a default case when checking the argument of --target.
12573 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12575 * interface.cs: Implement the same search algorithm for types in
12576 the interface code.
12578 * delegate.cs: Do not allow multiple definition.
12580 * Recovered ChangeLog that got accidentally amputated
12582 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12584 * rootcontext.cs: Load manually enum to allow core classes to
12585 contain enumerations.
12587 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12588 Update to new static methods in TypeManager.
12590 * typemanager.cs (GetMethod, GetConstructor): Use our
12591 implementation of FindMembers to find the members, since during
12592 corlib compilation, the types are TypeBuilders and GetMethod and
12593 GetConstructor do not work.
12595 Make all methods in TypeManager static.
12597 (InitCodeHelpers): Split the functionality from
12598 the InitCodeTypes function.
12600 * driver.cs: Call InitCodeHelpers after we have populated the
12603 * cs-parser.jay (delegate_declaration): we did not used to compute
12604 the delegate name correctly for void delegates.
12606 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12608 * rootcontext.cs (RootContext): Init the interface_resolve_order
12609 and type_container_resolve_order always.
12611 (ResolveCore, BootstrapCorlib_ResolveClass,
12612 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12613 compiler when compiling with --nostdlib
12615 * class.cs (TypeContainer.DefineType): Check that our parent is
12616 not null. This test is most important when we are bootstraping
12619 * codegen.cs: Split out the symbol writing code.
12621 2002-03-25 Martin Baulig <martin@gnome.org>
12623 * driver.cs (-g): Made -g an alias for --debug.
12625 2002-03-24 Martin Baulig <martin@gnome.org>
12627 * codegen.cs (SymbolWriter): New public variable. Returns the
12628 current symbol writer.
12629 (CodeGen): Added `bool want_debugging_support' argument to the
12630 constructor. If true, tell the ModuleBuild that we want debugging
12631 support and ask it for the ISymbolWriter.
12632 (Save): If we have a symbol writer, call it's Close() method after
12633 saving the assembly.
12635 * driver.c (--debug): New command line argument to create a
12636 debugger information file.
12638 * location.cs (SymbolDocument): New public property. Returns an
12639 ISymbolDocumentWriter object for the current source file or null
12640 if we don't have a symbol writer.
12642 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12644 * driver.cs (LoadAssembly): Correctly return when all the paths
12645 have been tried and not before.
12647 * statement.cs (Switch.Emit): return the actual coverage for this
12648 statement (returns/not-returns)
12650 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12651 switch of the statement if we are the last switch section. That
12652 kills two problems: try/catch problems (we used to emit an empty
12653 nop at the end) and switch statements where all branches would
12656 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12658 * driver.cs: Add default assemblies (the equivalent to the
12659 Microsoft CSC.RSP file)
12661 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12662 also update tokens_seen and set it to false.
12664 * driver.cs: Implement --recurse for Mike.
12666 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12667 correctly splitting out the paths.
12669 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12671 * interface.cs (Interface.PopulateProperty): Instead of using
12672 `parent' as the declaration space for the set parameters, use
12675 * support.cs (InternalParameters): InternalParameters constructor
12676 takes a DeclSpace instead of a TypeContainer.
12678 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12679 types are being initialized, load the address of it before calling
12682 (New): Provide a mechanism to disable the generation of local
12683 value type temporaries when the caller will be providing us with
12684 an address to store it.
12686 (ArrayCreation.EmitDynamicInitializers): Use it.
12688 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12690 * expression.cs (Invocation.EmitArguments): Only probe for array
12691 property if there is more than one argument. Sorry about that.
12693 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12694 empty param arrays.
12696 * class.cs (Method.LabelParameters): Fix incorrect code path that
12697 prevented the `ParamArrayAttribute' from being applied to the
12700 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12702 * support.cs (ReflectionParameters): Correctly compute whether the
12703 last argument is a params array. Fixes the problem with
12706 * typemanager.cs: Make the assemblies array always be non-null
12707 (empty, but non-null)
12709 * tree.cs (RecordDecl): New function that abstracts the recording
12710 of names. This reports error 101, and provides a pointer to the
12711 previous declaration. Fixes a crash in the compiler.
12713 * cs-parser.jay (constructor_declaration): Update to new grammar,
12714 and provide a constructor_body that can be empty.
12716 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12718 * driver.cs: Add support for --resources.
12720 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12721 Make all types for the various array helper methods be integer.
12723 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12724 CheckState to ConvCast.
12726 (ConvCast): Now it takes a `checked' state argument, to avoid
12727 depending on the emit context for the conversion, and just using
12728 the resolve time setting.
12730 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12731 instead of Invocation.EmitArguments. We do not emit the original
12732 arguments, instead we emit those which have been converted to
12733 unsigned int expressions.
12735 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12737 * codegen.cs: ditto.
12739 * expression.cs (LocalVariableReference): Drop the use of the
12740 Store function that depended on the variable index.
12742 * statement.cs (VariableInfo): Drop the `Idx' property from this
12743 class, as this is not taking into account the indexes for
12744 temporaries tat we generate during the execution, getting the
12747 * class.cs: First emit class initializers, then call the parent
12750 * expression.cs (Binary): Fix opcode emision.
12751 (UnaryMutator.EmitCode): Support checked code generation
12753 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12754 matches for events for both the Static and Instance scans,
12755 pointing to the same element. Fix that.
12757 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12759 * rootcontext.cs (ResolveTree): Always set the
12760 interface_resolve_order, because nested interfaces will be calling
12763 * class.cs (GetInterfaceOrClass): Track the same resolution
12764 process used by TypeManager.LookupType. This fixes the nested
12765 type lookups in class declarations (separate path from
12768 (TypeContainer.DefineType): Also define nested interfaces.
12769 (TypeContainer.RegisterOrder): New public function used to
12770 register the order in which child interfaces need to be closed.
12772 Nested interfaces need to be closed after their parents have been
12775 * interface.cs (InterfaceAttr): Put all the logic for computing
12776 the interface attribute here.
12778 (DefineInterface): Register our interface order with the
12779 RootContext or with the TypeContainer depending on the case.
12781 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12783 * cs-parser.jay: rework foreach statement to work with the new
12784 changes to the policy on SimpleNames.
12786 * report.cs: support Stacktrace on warnings as well.
12788 * makefile: drop --unsafe and /unsafe from the compile.
12790 2002-03-13 Ravi Pratap <ravi@ximian.com>
12792 * ecore.cs (StandardConversionExists): Modify to take an Expression
12793 as the first parameter. Ensure we do null -> reference type conversion
12796 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12797 temporary Expression objects.
12799 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12801 * interface.cs: workaround bug in method overloading resolution
12802 (there is already a bugzilla bug for it).
12804 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12806 We could also solve this problem by having a separate path for
12807 performing type lookups, instead of DoResolve, we could have a
12808 ResolveType entry point, and only participating pieces of the
12809 production (simplename, deref, array) would implement this.
12811 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12812 signal SimpleName to only resolve type names and not attempt to
12813 resolve anything else.
12815 * expression.cs (Cast): Set the flag.
12817 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12819 * class.cs: Only report 108 if there is no `new' modifier.
12821 * cs-parser.jay: rework foreach statement to work with the new
12822 changes to the policy on SimpleNames.
12824 * report.cs: support Stacktrace on warnings as well.
12826 * makefile: drop --unsafe and /unsafe from the compile.
12828 2002-03-11 Miguel de Icaza <miguel@ximian.com>
12830 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12831 lookups here, instead of doing that at parse time. This means
12832 that our grammar will not introduce `LocalVariableReferences' as
12833 expressions at this point. That solves the problem of code like
12837 static void Main ()
12841 This is only half the fix. The full fix requires parameters to
12842 also be handled in this way.
12844 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
12845 makes the use more obvious of the DeclSpace. The
12846 ec.TypeContainer.TypeBuilder is now only used to pull the
12847 TypeBuilder for it.
12849 My theory is that I can get rid of the TypeBuilder completely from
12850 the EmitContext, and have typecasts where it is used (from
12851 DeclSpace to where it matters).
12853 The only pending problem is that the code that implements Aliases
12854 is on TypeContainer, and probably should go in DeclSpace.
12856 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12857 lookups here, instead of doing that at parse time. This means
12858 that our grammar will not introduce `LocalVariableReferences' as
12859 expressions at this point. That solves the problem of code like
12863 static void Main ()
12867 This is only half the fix. The full fix requires parameters to
12868 also be handled in this way.
12870 * class.cs (Property.DefineMethod): When implementing an interface
12871 method, set newslot, when implementing an abstract method, do not
12872 set the flag (before we tried never setting it, or always setting
12873 it, which is the difference).
12874 (Indexer.DefineMethod): same.
12875 (Method.DefineMethod): same.
12877 * ecore.cs: Only set the status used flag if we get back a Field.
12879 * attribute.cs: Temporary hack, so Paolo can keep working.
12881 2002-03-08 Ravi Pratap <ravi@ximian.com>
12883 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
12884 the unmanaged type in the case we have a MarshalAs attribute.
12886 (Resolve): Handle the case when we are parsing the special MarshalAs
12887 attribute [we need to store the unmanaged type to use later]
12889 * typemanager.cs (marshal_as_attr_type): Built in type for the
12890 MarshalAs Attribute.
12892 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
12893 on parameters and accordingly set the marshalling info.
12895 2002-03-09 Miguel de Icaza <miguel@ximian.com>
12897 * class.cs: Optimizing slightly by removing redundant code after
12898 we switched to the `NoTypes' return value.
12899 (Property.DefineMethod): use NoTypes here too.
12901 This fixes the bug I introduced in my last batch of changes.
12903 2002-03-05 Ravi Pratap <ravi@ximian.com>
12905 * tree.cs (RecordEnum): Add. We now keep track of enums too.
12907 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
12908 Enums since those are types too.
12910 * cs-parser.jay (enum_declaration): Record enums as we parse them.
12912 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
12913 thanks to a call during the lookup process.
12915 2002-03-07 Miguel de Icaza <miguel@ximian.com>
12917 * statement.cs (Foreach): Lots of work to accomodate a particular
12918 kind of foreach statement that I had not kept in mind. It is
12919 possible to have foreachs on classes that provide a GetEnumerator
12920 method that return objects that implement the "pattern" for using
12921 a foreach, there is no need to support GetEnumerator
12924 This is needed to compile nant.
12926 * decl.cs: Only report 114 if the member is not `Finalize' and if
12927 the warning level is at least 2.
12929 * class.cs: Moved the compare function from Method to
12932 (MethodSignature.InheritableMemberSignatureCompare): Add new
12933 filter function that is used to extract inheritable methods from a
12936 (Method.Define): Use the new `inheritable_method_signature_filter'
12939 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
12942 2002-03-06 Miguel de Icaza <miguel@ximian.com>
12944 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
12946 * cs-parser.jay: Add opt_semicolon to the interface declaration.
12948 * expression.cs: Pass location information to
12949 ConvertImplicitStandard.
12951 * class.cs: Added debugging code to track return values from
12954 2002-03-05 Miguel de Icaza <miguel@ximian.com>
12956 * expression.cs (Is.DoResolve): If either side of the `is' is an
12957 interface, do not flag the warning.
12959 * ecore.cs (ImplicitReferenceConversion): We need a separate test
12962 * report.cs: Allow for --fatal to be used with --probe.
12964 * typemanager.cs (NoTypes): Move the definition for the empty Type
12967 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
12969 (TypeContainer.DefineProxy): New function used to proxy to parent
12970 implementations when implementing interfaces.
12971 (TypeContainer.ParentImplements): used to lookup if our parent
12972 implements a public function that is required by an interface.
12973 (TypeContainer.VerifyPendingMethods): Hook this up.
12975 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
12976 `modules' and `assemblies' arraylists into arrays. We only grow
12977 these are the very early start up of the program, so this improves
12978 the speedof LookupType (nicely measured).
12980 * expression.cs (MakeByteBlob): Replaced unsafe code with
12981 BitConverter, as suggested by Paolo.
12983 * cfold.cs (ConstantFold.Binary): Special case: perform constant
12984 folding of string concatenation, but if either side is a string,
12985 and the other is not, then return null, and let the runtime use
12986 the concatenation on the string plus the object (using
12987 `Object.ToString').
12989 2002-03-04 Miguel de Icaza <miguel@ximian.com>
12991 Constant Folding has been implemented now.
12993 * expression.cs (Unary.Reduce): Do not throw an exception, catch
12994 the error instead on types that are not supported in one's
12997 * constant.cs (Constant and all children): New set of functions to
12998 perform implict and explicit conversions.
13000 * ecore.cs (EnumConstant): Implement the new functions to perform
13001 conversion by proxying to the child expression.
13003 * codegen.cs: (ConstantCheckState): Constant evaluation has its
13004 own separate setting that can not be turned off from the command
13005 line using --unchecked or --checked and is only controlled using
13006 the checked/unchecked statements and expressions. This setting is
13007 used by the constant folder to flag errors.
13009 * expression.cs (CheckedExpr, UncheckedExpr): Set the
13010 ConstantCheckState as well.
13012 During Resolve, they also have to flag the state, because the
13013 constant folder runs completely in the Resolve phase.
13015 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
13018 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13020 * cfold.cs: New file, this file contains the constant folder.
13022 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
13023 argument to track whether we are using the resulting address to
13024 load or store a value and provide better error messages.
13026 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
13027 new AddressOf arguments.
13029 * statement.cs (Foreach.EmitCollectionForeach): Update
13031 * expression.cs (Argument.Emit): Call AddressOf with proper
13032 arguments to track usage.
13034 (New.DoEmit): Call AddressOf with new arguments.
13036 (Unary.Emit): Adjust AddressOf call.
13038 2002-03-01 Ravi Pratap <ravi@ximian.com>
13040 * cs-parser.jay (member_access): Change the case for pre-defined types
13041 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
13044 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
13047 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
13048 essentially like methods and apply attributes like MethodImplOptions to them too.
13050 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
13053 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
13054 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
13057 * Update code everywhere accordingly.
13059 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
13061 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
13063 2002-02-28 Ravi Pratap <ravi@ximian.com>
13065 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
13066 try performing lookups against those instead of jumping straight into using
13067 the 'using' clauses.
13069 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
13071 (LookupType): Perform lookups in implicit parents too.
13073 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
13074 sequence as RootContext.LookupType.
13076 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
13077 the various cases of namespace lookups into this method.
13079 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13081 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
13082 in positional arguments)
13084 * class.cs (Operator): Update the AllowedModifiers to contain
13087 * cs-parser.jay: Update operator declaration to allow for the
13088 operator body to be empty.
13090 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
13093 2002-02-27 Miguel de Icaza <miguel@ximian.com>
13095 * class.cs (Method.Emit): Label parameters.
13097 * driver.cs: Return 1 or 0 as the program exit code.
13099 2002-02-26 Miguel de Icaza <miguel@ximian.com>
13101 * expression.cs: Special case the `null' object when trying to
13102 auto-compute the type, as anything can be explicitly converted to
13105 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
13106 spotting this Paolo.
13108 (Expression.ImplicitNumericConversion): Perform comparissions of
13109 the type using the underlying type in the case of an enumeration
13110 rather than using the enumeration type for the compare.
13112 Cope with the underlying == type case, which is not possible to
13115 (Expression.ConvertNumericExplicit): Perform comparissions of
13116 the type using the underlying type in the case of an enumeration
13117 rather than using the enumeration type for the compare.
13119 * driver.cs: If the user does not supply an extension, assume .exe
13121 * cs-parser.jay (if_statement): Rewrote so that we can track the
13122 location for the if statement.
13124 * expression.cs (Binary.ConstantFold): Only concat strings when
13125 the operation is "+", not everything ;-)
13127 * statement.cs (Statement.EmitBoolExpression): Take a location
13129 (If, While, Do): Track location.
13131 * expression.cs (Binary.ResolveOperator): In the object + string
13132 case, I was missing a call to ConvertImplicit
13134 2002-02-25 Ravi Pratap <ravi@ximian.com>
13136 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
13137 Location arguments. Ensure we use RootContext.LookupType to do our work
13138 and not try to do a direct Type.GetType and ModuleBuilder.GetType
13140 * interface.cs (PopulateMethod): Handle the type of the parameter being
13143 * expression.cs (Invocation.BetterFunction): Handle the case when we
13144 have a params method with no fixed arguments and a call is made with no
13147 2002-02-25 Miguel de Icaza <miguel@ximian.com>
13149 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
13150 the verbatim-string-literal
13152 * support.cs (InternalParameters.ParameterModifier): handle null
13154 (InternalParameters.ParameterType): ditto.
13156 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
13157 duplicating the name of the variable parameter.
13158 (GetParameterByName): Fix bug where we were not looking up array
13159 paramters if they were the only present (thanks Paolo!).
13160 (GetParameterInfo): We only have an empty set of types if both
13161 fixed and array are set to null.
13162 (GetParameterInfo-idx): Handle FixedParameter == null
13164 * cs-parser.jay: Handle the case where there is no catch
13165 statements (missing null test).
13167 2002-02-22 Miguel de Icaza <miguel@ximian.com>
13169 * driver.cs (MainDriver): Be conservative on our command line
13172 Catch DirectoryNotFoundException when calling GetFiles.
13174 (SplitPathAndPattern): Used to split the input specification into
13175 a path and a pattern that we can feed to Directory.GetFiles.
13177 2002-02-21 Miguel de Icaza <miguel@ximian.com>
13179 * statement.cs (Fixed): Implement the last case of the Fixed
13180 statement (string handling).
13182 * expression.cs (StringPtr): New class used to return a char * to
13183 a string; Used by the Fixed statement.
13185 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
13187 * expression.cs (Binary.ResolveOperator): Remove redundant
13188 MemberLookup pn parent type.
13189 Optimize union call, we do not need a union if the types are the same.
13190 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
13193 Specialize the use of MemberLookup everywhere, instead of using
13194 the default settings.
13196 (StackAlloc): Implement stackalloc keyword.
13198 * cs-parser.jay: Add rule to parse stackalloc.
13200 * driver.cs: Handle /h, /help, /?
13202 * expression.cs (MakeByteBlob): Removed the hacks we had in place
13203 before we supported unsafe code.
13205 * makefile: add --unsafe to the self compilation of mcs.
13207 2002-02-20 Miguel de Icaza <miguel@ximian.com>
13209 * expression.cs (PointerArithmetic): New class that is used to
13210 perform pointer arithmetic.
13211 (Binary.Resolve): Handle pointer arithmetic
13212 Handle pointer comparission.
13213 (ArrayPtr): Utility expression class that is used to take the
13214 address of an array.
13216 (ElementAccess): Implement array access for pointers
13218 * statement.cs (Fixed): Implement fixed statement for arrays, we
13219 are missing one more case before we are done.
13221 * expression.cs (Indirection): Implement EmitAssign and set the
13222 ExprClass to Variable. This allows pointer dereferences to be
13223 treated as variables, and to have values assigned to them.
13225 * ecore.cs (Expression.StoreFromPtr): New utility function to
13226 store values dereferencing.
13228 2002-02-20 Ravi Pratap <ravi@ximian.com>
13230 * expression.cs (Binary.ResolveOperator): Ensure that we are
13231 not trying to operate on a void type - this fixes the reported
13234 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
13235 the parent implementation is sealed.
13237 * ../errors/cs0239.cs : Add.
13239 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
13241 * typemanager.cs (unverifiable_code_type): Corresponds to
13242 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
13243 which have unsafe code in them.
13245 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
13248 2002-02-19 Miguel de Icaza <miguel@ximian.com>
13250 * cs-tokenizer.cs: Add support for @"litreal strings"
13252 Make tokenizer accept pre-processor directives
13253 on any column (remove the old C-like limitation).
13255 * rootcontext.cs (EmitCode): Emit any global attributes.
13256 (AddGlobalAttributes): Used to keep track of assembly attributes.
13258 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
13260 * cs-parser.jay: Add support for global attributes.
13262 2002-02-17 Miguel de Icaza <miguel@ximian.com>
13264 * expression.cs (Indirection): New helper class. Unary will
13265 create Indirection classes to be able to implement the
13266 IMemoryLocation interface on it.
13268 2002-02-16 Miguel de Icaza <miguel@ximian.com>
13270 * cs-parser.jay (fixed_statement): reference the right statement.
13272 * statement.cs (Fixed.Emit): Finish implementing the fixed
13273 statement for the &x case.
13275 2002-02-14 Miguel de Icaza <miguel@ximian.com>
13277 * class.cs (Property.Define, Method.Define): Remove newslot when
13280 * modifiers.cs: My use of NewSlot when `Abstract' was set was
13281 wrong. NewSlot should only be used if the `new' keyword is present.
13283 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
13284 locating our system dir. Sorry about this.
13286 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13288 * driver.cs (GetSystemDir): Compute correctly the location of our
13289 system assemblies. I was using the compiler directory instead of
13290 the library directory.
13292 2002-02-13 Ravi Pratap <ravi@ximian.com>
13294 * expression.cs (BetterFunction): Put back in what Miguel commented out
13295 since it is the correct fix. The problem is elsewhere ;-)
13297 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
13298 parameters of the parms method are themselves compatible or not !
13300 (StandardConversionExists): Fix very dangerous bug where we were forgetting
13301 to check that a class implements an interface before saying that an implicit
13302 conversion was allowed. Use ImplementsInterface to do the checking.
13304 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13306 * class.cs (Method.Define): Track whether we are an explicit
13307 implementation or not. And only call DefineMethodOverride if we
13308 are an explicit implementation.
13310 (Property.DefineMethod): Ditto.
13312 2002-02-11 Ravi Pratap <ravi@ximian.com>
13314 * expression.cs (BetterFunction): Catch hideous bug which was
13315 preventing us from detecting ambiguous calls due to implicit casts i.e
13318 2002-01-29 Miguel de Icaza <miguel@ximian.com>
13320 * support.cs (Pair): Remove un-needed method. I figured why I was
13321 getting the error in cs-parser.jay, the variable in a foreach loop
13322 is readonly, and the compiler does not really treat this as a variable.
13324 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
13325 instead of EQUALS in grammar.
13327 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
13329 * expression.cs (Unary.DoResolve): Check whether the argument is
13332 2002-01-28 Miguel de Icaza <miguel@ximian.com>
13334 * support.cs: Api for Pair to set a value. Despite the fact that
13335 the variables are public the MS C# compiler refuses to compile
13336 code that accesses the field if the variable is part of a foreach
13339 * statement.cs (Fixed): Begin implementation of the fixed
13342 (Block.AddVariable): Return the VariableInfo on success and null
13343 on failure instead of true/false.
13345 * cs-parser.jay (foreach): Catch errors on variables already
13346 defined (we were ignoring this value before) and properly unwind
13347 the block hierarchy
13349 (fixed_statement): grammar for the fixed statement.
13351 2002-01-25 Miguel de Icaza <miguel@ximian.com>
13353 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
13354 pointer types to be incretemented.
13356 (SizeOf): Implement.
13358 * cs-parser.jay (pointer_member_access): Implement
13359 expr->IDENTIFIER production.
13361 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
13362 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
13365 (Unary): Implement indirection.
13367 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
13368 use in non-unsafe context).
13370 (SimpleName.DoResolve): Check for pointers in field access on safe
13373 (Expression.LoadFromPtr): Factor the load-indirect code in this
13374 function. This was duplicated in UnboxCast and ParameterReference
13376 2002-01-24 Miguel de Icaza <miguel@ximian.com>
13378 * expression.cs (ComposedCast): report an error if a pointer cast
13379 is used in a safe region.
13381 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
13382 pointer type casts in unsafe context.
13384 * codegen.cs (EmitContext): Set up IsUnsafe.
13386 * cs-parser.jay (non_expression_type): Add productions for pointer
13389 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
13390 code. We should not use force into static mode if the method is
13391 not virtual. Fixes bug in MIS
13393 * statement.cs (Do.Emit, While.Emit, For.Emit,
13394 Statement.EmitBoolExpression): Add support to Do and While to
13395 propagate infinite loop as `I do return' semantics.
13397 Improve the For case to also test for boolean constants.
13399 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
13400 to the list of attributes we can add.
13402 Remove `EmitContext' argument.
13404 * class.cs (Method.Define): Apply parameter attributes.
13405 (Constructor.Define): Apply parameter attributes.
13406 (MethodCore.LabelParameters): Move here the core of labeling
13409 * support.cs (ReflectionParameters.ParameterModifier,
13410 InternalParameters.ParameterModifier): Use IsByRef on the type and
13411 only return the OUT bit for these parameters instead of in/out/ref
13414 This is because I miss-understood things. The ParameterInfo.IsIn
13415 and IsOut represent whether the parameter has the [In] and [Out]
13418 2002-01-22 Miguel de Icaza <miguel@ximian.com>
13420 * ecore.cs (FieldExpr.Emit): Release temporaries.
13422 * assign.cs (LocalTemporary.Release): new function.
13424 * codegen.cs (EmitContext.GetTemporaryStorage,
13425 EmitContext.FreeTemporaryStorage): Rework the way we deal with
13426 temporary storage. Now we can "put back" localbuilders when we
13429 2002-01-21 Miguel de Icaza <miguel@ximian.com>
13431 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
13432 need to make a copy of the variable to generate verifiable code.
13434 2002-01-19 Miguel de Icaza <miguel@ximian.com>
13436 * driver.cs: Compute dynamically the system directory.
13438 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
13439 Slower, but more generally useful. Used by the abstract
13440 registering implementation.
13442 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
13443 the rules for the special rule on Type/instances. First check if
13444 we have the same name, and if so, try that special static path
13445 rather than the instance path.
13447 2002-01-18 Miguel de Icaza <miguel@ximian.com>
13449 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
13452 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
13453 Enum, ValueType, Delegate or Array for non-corlib compiles.
13455 * cs-tokenizer.cs: Catch long identifiers (645)
13457 * typemanager.cs (IndexerPropetyName): Ravi never tested this
13460 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
13461 fix, we were returning too early, so we were not registering
13462 pending methods from abstract classes.
13464 Do not register pending methods if the class is abstract.
13466 * expression.cs (Conditional.DoResolve): Report circular implicit
13467 conversions when we neecd to compute it for conditional
13470 (Is.DoResolve): If the expression is always of the provided type,
13471 flag warning 183. If the expression can not ever be of the
13472 provided type flag warning 184.
13474 * class.cs: Catch 169 as well.
13476 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
13479 2002-01-18 Nick Drochak <ndrochak@gol.com>
13481 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13483 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13485 * interface.cs: (PopulateMethod): Check for pointers being defined
13486 only if the unsafe context is active.
13487 (PopulateProperty): ditto.
13488 (PopulateIndexer): ditto.
13490 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13491 specified. If pointers are present, make sure that they are
13492 present in an unsafe context.
13493 (Constructor, Constructor.Define): ditto.
13494 (Field, Field.Define): ditto.
13495 (Property, Property.Define): ditto.
13496 (Event, Event.Define): ditto.
13498 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13499 hashtable if there are classes or structs defined.
13501 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13502 code, as the constant resolution moved.
13504 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13505 the metadata, so we can flag error 133.
13507 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13508 pointer is being declared in an unsafe context.
13510 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13512 * modifiers.cs (Modifiers.Check): Require a Location argument.
13513 Report error 227 for Unsafe use.
13515 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13517 * statement.cs (For.Emit): If the test is null, then report that
13518 we do `return', as we wont reach anything afterwards.
13520 (Switch.SwitchGoverningType): Track the expression that matched
13523 * driver.cs: Allow negative numbers as an error code to flag.
13525 * cs-parser.jay: Handle 1551.
13527 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13529 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13531 * cs-parser.jay: Report 1518 (type declaration can only contain
13532 class, struct, interface, enum or delegate)
13534 (switch_label): Report 1523 (keywords `case' or `default' must
13537 (opt_switch_sections): Report 1522 (empty switch)
13539 * driver.cs: Report 1515 (response file specified multiple times)
13540 Report 1516 (Source file specified multiple times).
13542 * expression.cs (Argument.Resolve): Signal 1510
13544 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13545 access not allowed in static code)
13547 2002-01-11 Ravi Pratap <ravi@ximian.com>
13549 * typemanager.cs (IsPointerType): Utility method which we are going
13552 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13553 the object type, so we take care of that.
13555 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13557 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13558 added to non-params parameters :-)
13560 * typemanager.cs (CSharpName): Include 'void' type too.
13562 (void_ptr_type): Include in the set of core types.
13564 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13567 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13570 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13571 completely forgotten about it.
13573 2002-01-10 Ravi Pratap <ravi@ximian.com>
13575 * cs-parser.jay (pointer_type): Add. This begins our implementation
13576 of parsing rules for unsafe code.
13578 (unsafe_statement): Implement.
13580 (embedded_statement): Modify to include the above.
13582 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13584 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13585 if the current context is an unsafe one.
13587 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13588 are handled differently, we need separate rules for them.
13590 (local_variable_declaration): Update to use local_variable_pointer_type
13591 to allow variable declarations of unmanaged pointer types.
13593 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13594 in unsafe contexts.
13596 * ../errors/cs0214.cs : Add.
13598 2002-01-16 Nick Drochak <ndrochak@gol.com>
13600 * makefile: remove 'response' file when cleaning.
13602 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13604 * cs-parser.jay: Report 1524.
13606 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13608 * typemanager.cs (RegisterMethod): drop checking if we have
13609 registered this from here
13611 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13613 * class.cs (Method.EmitDestructor): Implement calling our base
13616 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13617 value of InFinally.
13619 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13620 this routine and will wrap the call in a try/catch block. Deal
13623 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13625 * ecore.cs (Expression.MemberLookup): instead of taking a
13626 parameter `same_type' that was used to tell whether we could
13627 access private members we compute our containing type from the
13630 (FieldExpr): Added partial support for volatile fields. This does
13631 not work for volatile fields exposed from assemblies, as I can not
13632 figure out how to extract the modreq from it.
13634 Updated all the source files to use this.
13636 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13637 because it is referenced by MemberLookup very often.
13639 2002-01-09 Ravi Pratap <ravi@ximian.com>
13641 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13642 TypeBuilder.GetCustomAttributes to retrieve what we need.
13644 Get rid of redundant default_member_attr_type as this is the same as
13645 default_member_type which already exists.
13647 * interface.cs, attribute.cs : Update accordingly.
13649 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13651 * typemanager.cs: Enable IndexerPropertyName again. It does not
13652 work for TYpeBuilders though. Ravi, can you please fix this?
13654 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13656 * expression.cs (Argument.Emit): Handle the case of ref objects
13657 being passed to ref functions;
13659 (ParameterReference.EmitLoad): Loads the content of the pointer
13660 without dereferencing.
13662 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13664 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13666 2002-01-08 Ravi Pratap <ravi@ximian.com>
13668 * class.cs (Indexer.DefineMethod): Incorporate the interface
13669 type in the name of the method if we are doing explicit interface
13672 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13674 (BetterConversion): Fix extremely trivial bug where we were referring to
13675 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13678 * ../errors/bug16.cs : Add although we have fixed it.
13680 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13682 * expression.cs (BaseIndexer): Begin implementation.
13684 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13686 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13687 production directly to remove a shift/reduce, and implement
13688 explicit interface implementation.
13690 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13691 after a floating point suffix.
13693 * expression.cs (DoNumericPromotions): Improved the conversion for
13694 uint/uint. If we have a constant, we avoid doing a typecast to a
13697 * class.cs (Indexer): Implement explicit interface implementation
13700 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13702 * class.cs: make the default instance constructor public and hidebysig.
13704 2001-01-03 Ravi Pratap <ravi@ximian.com>
13706 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13707 so we can call it from elsewhere.
13709 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13710 we emit it internally if the class has a defined indexer; otherwise the user
13711 emits it by decorating the class definition with the DefaultMemberAttribute.
13713 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13714 attribute is not used on a type which defines an indexer.
13716 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13717 character when we skip whitespace.
13719 * ../errors/cs0646.cs : Add.
13721 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13723 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13726 * makefile: Add practical target `mcs3.exe' which builds the third
13727 generation compiler.
13729 * expression.cs (New): Fix structures constructor calling.
13731 * class.cs (Property, Method, Indexer): Emit Final flag on the
13732 method if we are an interface implementation and we are not
13735 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13736 whether this property is referencing a `base' method.
13738 * expression.cs (Invocation.EmitCall): take an extra argument:
13739 is_base, this is used to determine whether the `call' or
13740 `callvirt' opcode should be used.
13743 * delegate.cs: update EmitCall.
13745 * class.cs (Method.Define): Set NewSlot for the cases where we are
13746 not implementing an interface method.
13748 (Property.Define): ditto.
13750 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13752 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13753 'r'. Allows mcs to parse itself fully.
13755 2002-01-02 Ravi Pratap <ravi@ximian.com>
13757 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13758 of the number of initializers that require the InitializeArray method.
13760 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13761 update the above field where necessary.
13763 (MakeByteBlob): Update accordingly.
13765 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13768 (EmitDynamicInitializers): Update in accordance with the new optimization.
13770 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13771 same OpCode applies.
13773 * cs-parser.jay : Fix some glaring errors I introduced.
13775 2002-01-01 Ravi Pratap <ravi@ximian.com>
13777 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13778 so that we can check for name clashes there too.
13780 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13781 for interface indexers.
13783 * interfaces.cs (Define): Emit the default member attribute.
13785 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13786 variable was being referred to while setting the value ;-)
13788 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13790 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13791 byte-by-byte information when we know the data is zero.
13793 Make the block always a multiple of 4, because
13794 DefineInitializedData has a bug.
13796 * assign.cs: Fix, we should assign from the temporary, not from
13799 * expression.cs (MakeByteBlob): Fix my incorrect code.
13801 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13803 * typemanager.cs (EnumToUnderlying): This function is used to get
13804 the underlying type from an enumeration, because it does not
13807 * constant.cs: Use the I4_S form for values between -128 and 127.
13809 * statement.cs (Block.LookupLabel): Looks up a label.
13810 (Block): Drop support for labeled blocks.
13812 (LabeledStatement): New kind of statement that represents a label
13815 (Goto): Finally implement this bad boy.
13817 * cs-parser.jay: Update to reflect new mechanism to implement
13820 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13822 * codegen.cs (EmitContext.This): a codegen property that keeps the
13823 a single instance of this instead of creating many different this
13826 * delegate.cs (Delegate.DoResolve): Update to use the property;
13828 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
13830 * expression.cs (BaseAccess.DoResolve): Ditto.
13832 2001-12-29 Ravi Pratap <ravi@ximian.com>
13834 * typemanager.cs (methodimpl_attr_type): Add to hold the type
13835 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
13837 (InitCoreTypes): Update accordingly.
13839 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
13840 so we can quickly store the state.
13842 (ApplyAttributes): Set the correct implementation flags
13843 for InternalCall methods.
13845 2001-12-29 Miguel de Icaza <miguel@ximian.com>
13847 * expression.cs (EmitCall): if a method is not virtual, then do
13848 not use callvirt on it.
13850 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
13851 user defined stuff) requires the use of stobj, which takes an
13852 address on the stack instead of an array and an index. So emit
13853 the Ldelema operation for it.
13855 (EmitStoreOpcode): Use stobj for valuetypes.
13857 (UnaryMutator.EmitCode): Use the right 1 value depending on
13858 whether we are dealing with int64/uint64, float or doubles.
13860 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
13861 constructors that I implemented last night.
13863 (Constructor.IsDefault): Fix to work properly for static
13866 * cs-parser.jay (CheckDef): report method signature errors.
13867 Update error number 103 to be 132.
13869 * decl.cs: New AdditionResult enumeration value: MethodExists.
13870 Although we do this check for methods later on in the semantic
13871 analysis, catching repeated default constructors is so easy that
13872 we catch these here.
13874 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
13877 (ParameterReference.EmitAssign, Emit): handle
13880 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
13881 (ArrayAccess.EmitStoreOpcode): ditto.
13883 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
13885 * expression.cs (MakeByteBlob): Complete all the missing types
13886 (uint, short, ushort, byte, sbyte)
13888 * class.cs: Only init instance field initializers on instance
13891 Rename `constructors' to instance_constructors.
13893 (TypeContainer.AddConstructor): Only add constructors to the list
13894 if it is not static.
13896 Make sure that we handle default_static_constructor independently
13897 everywhere where we handle instance_constructors
13899 2001-12-28 Miguel de Icaza <miguel@ximian.com>
13901 * class.cs: Do not lookup or create a base initializer for a
13902 static constructor.
13904 (ConstructorInitializer.Resolve): use the proper type to lookup
13907 * cs-parser.jay: Report error 1585 (modifiers between type and name).
13909 * enum.cs, interface.cs: Remove CloseType, this is taken care by
13912 * decl.cs: CloseType is now an virtual method, the default
13913 implementation just closes this type.
13915 2001-12-28 Ravi Pratap <ravi@ximian.com>
13917 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
13918 to PreserveSig by default. Also emit HideBySig on such methods.
13920 Basically, set the defaults to standard values.
13922 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
13923 argument, if candidate is better, it can't be worse than the best !
13925 (Invocation): Re-write bits to differentiate between methods being
13926 applicable in their expanded form and their normal form - for params
13929 Get rid of use_standard everywhere as only standard conversions are allowed
13930 in overload resolution.
13932 More spec conformance.
13934 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13936 * driver.cs: Add --timestamp, to see where the compiler spends
13939 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
13940 `this' in static code.
13942 (SimpleName.DoResolve): Implement in terms of a helper function
13943 that allows static-references to be passed upstream to
13946 (Expression.ResolveWithSimpleName): Resolve specially simple
13947 names when called by MemberAccess to implement the special
13950 (Expression.ImplicitReferenceConversion): Handle conversions from
13951 Null to reference types before others, as Null's type is
13954 * expression.cs (Invocation.EmitCall): Handle the special case of
13955 calling methods declared on a reference type from a ValueType
13956 (Base classes System.Object and System.Enum)
13958 (MemberAccess.Resolve): Only perform lookups on Enumerations if
13959 the left hand side is a TypeExpr, not on every enumeration.
13961 (Binary.Resolve): If types are reference types, then do a cast to
13962 object on operators != and == of both arguments.
13964 * typemanager.cs (FindMembers): Extract instance and static
13965 members if requested.
13967 * interface.cs (PopulateProperty): Use void_type instead of null
13968 as the return type for the setter method.
13970 (PopulateIndexer): ditto.
13972 2001-12-27 Ravi Pratap <ravi@ximian.com>
13974 * support.cs (ReflectionParameters): Fix minor bug where we
13975 were examining the wrong parameter for the ParamArray attribute.
13977 Cope with requests for the type of the parameter at position
13978 greater than the params parameter's. We now return the element
13979 type of the params array as that makes more sense.
13981 * expression.cs (Invocation.IsParamsMethodApplicable): Update
13982 accordingly as we no longer have to extract the element type
13985 (Invocation.OverloadResolve): Update.
13987 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13989 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
13990 against IEnumerator, test whether the return value is a descendant
13991 of the IEnumerator interface.
13993 * class.cs (Indexer.Define): Use an auxiliary method to implement
13994 the other bits of the method definition. Begin support for
13995 explicit interface implementation.
13997 (Property.DefineMethod): Use TypeManager.void_type instead of null
13998 for an empty return value.
14000 2001-12-26 Miguel de Icaza <miguel@ximian.com>
14002 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
14003 dealing with a FieldExpr which is composed of a FieldBuilder, in
14004 the code path we did extract the constant, but we should have
14005 obtained the underlying value to be able to cast it (otherwise we
14006 end up in an infinite loop, this is what Ravi was running into).
14008 (ArrayCreation.UpdateIndices): Arrays might be empty.
14010 (MemberAccess.ResolveMemberAccess): Add support for section
14011 14.5.4.1 that deals with the special case of E.I when E is a type
14012 and something else, that I can be a reference to a static member.
14014 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
14015 handle a particular array type to create byte blobs, it is just
14016 something we dont generate byteblobs for.
14018 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
14021 * location.cs (Push): remove the key from the hashtable that we
14022 are about to add. This happens for empty files.
14024 * driver.cs: Dispose files after we have parsed them.
14026 (tokenize): new function that only runs the tokenizer on its
14027 input, for speed testing.
14029 2001-12-26 Ravi Pratap <ravi@ximian.com>
14031 * class.cs (Event.Define): Define the private field only if there
14032 are no accessors defined.
14034 * expression.cs (ResolveMemberAccess): If there is no associated
14035 field with the event, that means we have an event defined with its
14036 own accessors and we should flag error cs0070 since transforming
14037 ourselves into a field is not valid in that case.
14039 * ecore.cs (SimpleName.DoResolve): Same as above.
14041 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
14042 and charset to sane values.
14044 2001-12-25 Ravi Pratap <ravi@ximian.com>
14046 * assign.cs (DoResolve): Perform check on events only if they
14047 are being accessed outside the declaring type.
14049 * cs-parser.jay (event_declarations): Update rules to correctly
14050 set the type of the implicit parameter etc.
14052 (add_accessor, remove_accessor): Set current local parameters.
14054 * expression.cs (Binary): For delegate addition and subtraction,
14055 cast the return value from the method into the appropriate delegate
14058 2001-12-24 Ravi Pratap <ravi@ximian.com>
14060 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
14061 of these as the workaround is unnecessary.
14063 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
14064 delegate data - none of that is needed at all.
14066 Re-write bits to extract the instance expression and the delegate method
14069 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
14072 * attribute.cs (ApplyAttributes): New method to take care of common tasks
14073 of attaching attributes instead of duplicating code everywhere.
14075 * everywhere : Update code to do attribute emission using the above method.
14077 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14079 * expression.cs (IsParamsMethodApplicable): if there are not
14080 parameters, return immediately.
14082 * ecore.cs: The 0 literal can be implicity converted to an enum
14085 (SimpleName.DoResolve): First lookup the type, then lookup the
14088 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
14089 want to get its address. If the InstanceExpression is not
14090 addressable, store the result in a temporary variable, then get
14093 * codegen.cs: Only display 219 errors on warning level or above.
14095 * expression.cs (ArrayAccess): Make it implement the
14096 IMemoryLocation interface.
14098 (Binary.DoResolve): handle the operator == (object a, object b)
14099 and operator != (object a, object b) without incurring into a
14100 BoxedCast (because 5 != o should never be performed).
14102 Handle binary enumerator operators.
14104 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
14105 value type, otherwise use Ldelem_ref.
14107 Use precomputed names;
14109 (AddressOf): Implement address of
14111 * cs-parser.jay (labeled_statement): Fix recursive block
14112 addition by reworking the production.
14114 * expression.cs (New.DoEmit): New has a special case:
14116 If we are dealing with a ValueType, we have a few
14117 situations to deal with:
14119 * The target of New is a ValueType variable, that is
14120 easy, we just pass this as the variable reference
14122 * The target of New is being passed as an argument,
14123 to a boxing operation or a function that takes a
14126 In this case, we need to create a temporary variable
14127 that is the argument of New.
14130 2001-12-23 Ravi Pratap <ravi@ximian.com>
14132 * rootcontext.cs (LookupType): Check that current_type is not null before
14133 going about looking at nested types.
14135 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
14136 not implement the IAssignMethod interface any more.
14138 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
14139 where we tranform them into FieldExprs if they are being resolved from within
14140 the declaring type.
14142 * ecore.cs (SimpleName.DoResolve): Do the same here.
14144 * assign.cs (DoResolve, Emit): Clean up code considerably.
14146 * ../errors/bug10.cs : Add.
14148 * ../errors/cs0070.cs : Add.
14150 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
14152 * assign.cs : Get rid of EventIsLocal everywhere.
14154 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14156 * ecore.cs (ConvertIntLiteral): finished the implementation.
14158 * statement.cs (SwitchLabel): Convert the value we are using as a
14159 key before looking up the table.
14161 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14163 * codegen.cs (EmitTopBlock): Require a Location argument now.
14165 * cs-parser.jay (constructor_declarator): We need to setup
14166 current_local_parameters before we parse the
14167 opt_constructor_initializer, to allow the variables to be bound
14168 to the constructor arguments.
14170 * rootcontext.cs (LookupType): First lookup nested classes in our
14171 class and our parents before we go looking outside our class.
14173 * expression.cs (ConstantFold): Extract/debox the values at the
14176 * rootcontext.cs (EmitCode): Resolve the constants first before we
14177 resolve the types. This is not really needed, but it helps debugging.
14179 * statement.cs: report location.
14181 * cs-parser.jay: pass location to throw statement.
14183 * driver.cs: Small bug fix.
14185 * report.cs: Updated format to be 4-zero filled digits.
14187 2001-12-22 Ravi Pratap <ravi@ximian.com>
14189 * expression.cs (CheckIndices): Fix minor bug where the wrong
14190 variable was being referred to ;-)
14192 (DoEmit): Do not call EmitStaticInitializers when the
14193 underlying type is System.Object.
14195 2001-12-21 Ravi Pratap <ravi@ximian.com>
14197 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
14198 and do the usual workaround for SRE.
14200 * class.cs (MyEventBuilder.EventType): New member to get at the type
14201 of the event, quickly.
14203 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
14205 * assign.cs (Assign.DoResolve): Handle the case when the target
14206 is an EventExpr and perform the necessary checks.
14208 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
14211 (SimpleName.MemberStaticCheck): Include check for EventExpr.
14213 (EventExpr): Set the type in the constructor itself since we
14214 are meant to be born fully resolved.
14216 (EventExpr.Define): Revert code I wrote earlier.
14218 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
14219 instance expression is null. The instance expression is a This in that case
14220 or a null, depending on whether it is a static method or not.
14222 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
14223 refers to more than one method.
14225 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
14226 and accordingly flag errors.
14228 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14230 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
14232 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14234 * location.cs (ToString): Provide useful rutine.
14236 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14238 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
14239 objects, return the actual integral boxed.
14241 * statement.cs (SwitchLabel): define an ILLabel for each
14244 (Switch.CheckSwitch): If the value is a Literal, extract
14245 the underlying literal.
14247 Also in the unused hashtable we had, add the SwitchLabel so we can
14248 quickly look this value up.
14250 * constant.cs: Implement a bunch of new constants. Rewrite
14251 Literal based on this. Made changes everywhere to adapt to this.
14253 * expression.cs (Expression.MakeByteBlob): Optimize routine by
14254 dereferencing array only once, and also copes with enumrations.
14256 bytes are two bytes wide, not one.
14258 (Cast): Perform constant conversions.
14260 * ecore.cs (TryImplicitIntConversion): Return literals instead of
14261 wrappers to the literals here.
14263 * expression.cs (DoNumericPromotions): long literals can converted
14264 to ulong implicity (this is taken care of elsewhere, but I was
14265 missing this spot).
14267 * ecore.cs (Expression.Literalize): Make the return type Literal,
14268 to improve type checking.
14270 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
14272 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14274 * literal.cs: Revert code from ravi that checked the bounds. The
14275 bounds are sane by the definition of the type itself.
14277 * typemanager.cs: Fix implementation of ImplementsInterface. We
14278 need to actually look up in our parent hierarchy for interfaces
14281 * const.cs: Use the underlying type for enumerations
14283 * delegate.cs: Compute the basename for the delegate creation,
14284 that should fix the delegate test case, and restore the correct
14285 Type Lookup semantics in rootcontext
14287 * rootcontext.cs: Revert Ravi's last patch. The correct way of
14288 referencing a nested type with the Reflection API is using the "+"
14291 * cs-parser.jay: Do not require EOF token at the end.
14293 2001-12-20 Ravi Pratap <ravi@ximian.com>
14295 * rootcontext.cs (LookupType): Concatenate type names with
14296 a '.' instead of a '+' The test suite passes again.
14298 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
14299 field of the enumeration.
14301 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
14302 the case when the member is an EventExpr.
14304 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
14305 static has an associated instance expression.
14307 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
14309 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
14311 * class.cs (Event.Define): Register event and perform appropriate checks
14314 We define the Add and Remove methods even if the use provides none because
14315 in that case, we provide default implementations ourselves.
14317 Define a private field of the type of the event. This is done by the CSC compiler
14318 and we should be doing it too ;-)
14320 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
14321 More methods we use in code we generate.
14323 (multicast_delegate_type, delegate_type): Two separate types since the distinction
14326 (InitCoreTypes): Update accordingly for the above.
14328 * class.cs (Event.Emit): Generate code for default accessors that we provide
14330 (EmitDefaultMethod): Do the job in the above.
14332 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
14335 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14337 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
14338 builders even if we were missing one.
14340 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
14341 pass the Basename as our class name instead of the Name. The
14342 basename will be correctly composed for us.
14344 * parameter.cs (Paramters): Now takes a Location argument.
14346 * decl.cs (DeclSpace.LookupType): Removed convenience function and
14347 make all the code call directly LookupType in RootContext and take
14348 this chance to pass the Location information everywhere.
14350 * Everywhere: pass Location information.
14352 2001-12-19 Miguel de Icaza <miguel@ximian.com>
14354 * class.cs (Constructor.Define): Updated way of detecting the
14355 length of the parameters.
14357 (TypeContainer.DefineType): Use basename as the type name for
14360 (TypeContainer.Define): Do not recursively define types here, as
14361 definition is taken care in order by the RootContext.
14363 * tree.cs: Keep track of namespaces in a per-file basis.
14365 * parameter.cs (Parameter.ComputeSignature): Update to use
14368 (Parameters.GetSignature): ditto.
14370 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
14371 instead of a TypeContainer.
14373 (Interface.SemanticAnalysis): Use `this' instead of our parent to
14374 resolve names. Because we need to be resolve in our context, not
14377 * driver.cs: Implement response files.
14379 * class.cs (TypeContainer.DefineType): If we are defined, do not
14380 redefine ourselves.
14382 (Event.Emit): Emit the code for add/remove handlers.
14383 (Event.Define): Save the MethodBuilders for add/remove.
14385 * typemanager.cs: Use pair here too.
14387 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
14388 DictionaryEntry requires the first argument to be non-null.
14390 (enum_declaration): Compute full name for registering the
14393 (delegate_declaration): Instead of using
14394 formal_parameter_list, use opt_formal_parameter_list as the list
14397 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
14398 (EventParsing): New property that controls whether `add' and
14399 `remove' are returned as tokens or identifiers (for events);
14401 2001-12-19 Ravi Pratap <ravi@ximian.com>
14403 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
14404 use MyEventBuilder only and let it wrap the real builder for us.
14406 (MyEventBuilder): Revamp constructor etc.
14408 Implement all operations that we perform on EventBuilder in precisely the same
14411 (FindMembers): Update to use the EventBuilder member.
14413 (Event.Emit): Update accordingly.
14415 2001-12-18 Ravi Pratap <ravi@ximian.com>
14417 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
14418 by calling the appropriate methods.
14420 (GetCustomAttributes): Make stubs as they cannot possibly do anything
14423 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
14425 2001-12-17 Ravi Pratap <ravi@ximian.com>
14427 * delegate.cs (Delegate.Populate): Check that the return type
14428 and various parameters types are indeed accessible.
14430 * class.cs (Constructor.Define): Same here.
14432 (Field.Define): Ditto.
14434 (Event.Define): Ditto.
14436 (Operator.Define): Check that the underlying Method defined itself
14437 correctly - so it's MethodBuilder should not be null.
14439 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
14440 expression happens to be null.
14442 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
14443 members but as of now we don't seem to be able to do anything really useful with it.
14445 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
14446 not the EventBuilder.
14448 2001-12-18 Miguel de Icaza <miguel@ximian.com>
14450 * cs-tokenizer.cs: Add support for defines.
14451 Add support for #if, #elif, #else, #endif
14453 (eval_var): evaluates a variable.
14454 (eval): stubbed for evaluating functions.
14456 * cs-parser.jay: Pass the defines information
14458 * driver.cs: Add --define command line option.
14460 * decl.cs: Move MemberCore here.
14462 Make it the base class for DeclSpace. This allows us to catch and
14463 report 108 and 109 for everything now.
14465 * class.cs (TypeContainer.Define): Extract all the members
14466 before populating and emit the warning 108 (new keyword required
14467 to override) instead of having each member implement this.
14469 (MemberCore.Define): New abstract method, we will be using this in
14470 the warning reporting engine in Populate.
14472 (Operator.Define): Adjust to new MemberCore protocol.
14474 * const.cs (Const): This does not derive from Expression, it is a
14475 temporary object we use to create fields, it is a MemberCore.
14477 * class.cs (Method.Define): Allow the entry point to be in a
14480 * driver.cs: Rewrite the argument handler to clean it up a bit.
14482 * rootcontext.cs: Made it just an auxiliary namespace feature by
14483 making everything static.
14485 * driver.cs: Adapt code to use RootContext type name instead of
14488 * delegate.cs: Remove RootContext argument.
14490 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14493 * class.cs (Event.Define): The lookup can fail.
14495 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14497 * expression.cs: Resolve the this instance before invoking the code.
14499 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14501 * cs-parser.jay: Add a production in element_access that allows
14502 the thing to become a "type" reference. This way we can parse
14503 things like "(string [])" as a type.
14505 Note that this still does not handle the more complex rules of
14509 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14511 * ecore.cs: (CopyNewMethods): new utility function used to
14512 assemble the list of methods from running FindMembers.
14514 (MemberLookup): Rework FindMembers so that
14516 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14518 * class.cs (TypeContainer): Remove Delegates who fail to be
14521 * delegate.cs (Populate): Verify that we dont get null return
14522 values. TODO: Check for AsAccessible.
14524 * cs-parser.jay: Use basename to emit error 574 (destructor should
14525 have the same name as container class), not the full name.
14527 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14528 possible representation.
14530 Also implements integer type suffixes U and L.
14532 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14534 * expression.cs (ArrayCreation.DoResolve): We need to do the
14535 argument resolution *always*.
14537 * decl.cs: Make this hold the namespace. Hold the root context as
14539 (LookupType): Move here.
14541 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14543 * location.cs (Row, Name): Fixed the code, it was always returning
14544 references to the first file.
14546 * interface.cs: Register properties defined through interfaces.
14548 * driver.cs: Add support for globbing on the command line
14550 * class.cs (Field): Make it derive from MemberCore as well.
14553 2001-12-15 Ravi Pratap <ravi@ximian.com>
14555 * class.cs (Event::Define): Check that the type of the event is a delegate
14556 type else flag error #66.
14558 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14561 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14562 values of EntryPoint, CharSet etc etc.
14564 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14566 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14567 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14568 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14569 which needs this to do its work.
14571 * ../errors/cs0066.cs : Add.
14573 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14575 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14578 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14579 clears out the parameters field.
14580 (MemberSignatureCompare): Cleanup
14582 (MemberCore): New base class used to share code between MethodCore
14585 (RegisterRequiredImplementations) BindingFlags.Public requires
14586 either BindingFlags.Instace or Static. Use instance here.
14588 (Property): Refactored code to cope better with the full spec.
14590 * parameter.cs (GetParameterInfo): Return an empty array instead
14593 * class.cs (Property): Abstract or extern properties have no bodies.
14595 * parameter.cs (GetParameterInfo): return a zero-sized array.
14597 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14598 method modifier validation to the typecontainer so we can reuse
14599 this on properties.
14601 (MethodCore.ParameterTypes): return an empty sized array of types.
14603 (Property.Define): Test property modifier validity.
14605 Add tests for sealed/override too.
14607 (Method.Emit): abstract or extern methods have no bodies.
14609 2001-12-14 Ravi Pratap <ravi@ximian.com>
14611 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14614 (Method::Define, ::Emit): Modify accordingly.
14616 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14618 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14620 * makefile: Pass in /unsafe.
14622 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14624 * class.cs (MakeKey): Kill routine.
14626 * class.cs (TypeContainer.Define): Correctly define explicit
14627 method implementations (they require the full interface name plus
14630 * typemanager.cs: Deply the PtrHashtable here and stop using the
14631 lame keys. Things work so much better.
14633 This of course broke everyone who depended on `RegisterMethod' to
14634 do the `test for existance' test. This has to be done elsewhere.
14636 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14637 the object stupid Equals method (because, that like fails all over
14638 the place). We still do not use it.
14640 * class.cs (TypeContainer.SetRequiredInterface,
14641 TypeContainer.RequireMethods): Killed these two routines and moved
14642 all the functionality to RegisterRequiredImplementations.
14644 (TypeContainer.RegisterRequiredImplementations): This routine now
14645 registers all the implementations required in an array for the
14646 interfaces and abstract methods. We use an array of structures
14647 which can be computed ahead of time to reduce memory usage and we
14648 also assume that lookups are cheap as most classes will not
14649 implement too many interfaces.
14651 We also avoid creating too many MethodSignatures.
14653 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14654 clear the "pending" bit if we find that there are problems with
14657 (TypeContainer.VerifyPendingMethods): Update to report errors of
14658 methods that look like implementations but are not.
14660 (TypeContainer.Define): Add support for explicit interface method
14663 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14665 * typemanager.cs: Keep track of the parameters here instead of
14666 being a feature of the TypeContainer.
14668 * class.cs: Drop the registration of parameters here, as
14669 InterfaceMethods are also interface declarations.
14671 * delegate.cs: Register methods with the TypeManager not only with
14672 the TypeContainer. This code was buggy.
14674 * interface.cs: Full registation here.
14676 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14678 * expression.cs: Remove reducer for binary expressions, it can not
14681 * const.cs: Put here the code that used to go into constant.cs
14683 * constant.cs: Put here the code for constants, this is a new base
14684 class for Literals.
14686 * literal.cs: Make Literal derive from Constant.
14688 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14690 * statement.cs (Return.Emit): Report error 157 if the user
14691 attempts to return from a finally block.
14693 (Return.Emit): Instead of emitting a return, jump to the end of
14696 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14697 LocalBuilder to store the result of the function. ReturnLabel is
14698 the target where we jump.
14701 2001-12-09 Radek Doulik <rodo@ximian.com>
14703 * cs-parser.jay: remember alias in current namespace
14705 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14708 * class.cs (LookupAlias): lookup alias in my_namespace
14710 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14712 (LookupAlias): lookup alias in this and if needed in parent
14715 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14719 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14720 making things static. I need this to avoid passing the
14721 TypeContainer when calling ParameterType.
14723 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14724 that did string manipulation to compute the type and then call
14725 GetType. Use Parameter.ParameterType instead.
14727 * cs-tokenizer.cs: Consume the suffix for floating values.
14729 * expression.cs (ParameterReference): figure out whether this is a
14730 reference parameter or not. Kill an extra variable by computing
14731 the arg_idx during emission.
14733 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14734 function that returns whether a parameter is an out/ref value or not.
14736 (Parameter.ParameterType): The type of the parameter (base,
14737 without ref/out applied).
14739 (Parameter.Resolve): Perform resolution here.
14740 (Parameter.ExternalType): The full type (with ref/out applied).
14742 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14743 support for expressions on the using statement.
14745 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14747 * statement.cs (Using.EmitLocalVariableDecls): Split the
14748 localvariable handling of the using statement.
14750 (Block.EmitMeta): Keep track of variable count across blocks. We
14751 were reusing slots on separate branches of blocks.
14753 (Try.Emit): Emit the general code block, we were not emitting it.
14755 Check the type of the declaration to be an IDisposable or
14756 something that can be implicity converted to it.
14758 Emit conversions if required.
14760 * ecore.cs (EmptyExpression): New utility class.
14761 (Expression.ImplicitConversionExists): New utility function.
14763 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14765 * statement.cs (Using): Implement.
14767 * expression.cs (LocalVariableReference): Support read only variables.
14769 * statement.cs: Remove the explicit emit for the Leave opcode.
14770 (VariableInfo): Add a readonly field.
14772 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14774 * ecore.cs (ConvCast): new class used to encapsulate the various
14775 explicit integer conversions that works in both checked and
14776 unchecked contexts.
14778 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14779 properly generate the overflow opcodes.
14781 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14783 * statement.cs: The correct type for the EmptyExpression is the
14784 element_type, not the variable type. Ravi pointed this out.
14786 2001-12-04 Ravi Pratap <ravi@ximian.com>
14788 * class.cs (Method::Define): Handle PInvoke methods specially
14789 by using DefinePInvokeMethod instead of the usual one.
14791 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14792 above to do the task of extracting information and defining the method.
14794 2001-12-04 Ravi Pratap <ravi@ximian.com>
14796 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14797 of the condition for string type.
14799 (Emit): Move that here.
14801 (ArrayCreation::CheckIndices): Keep string literals in their expression
14804 (EmitDynamicInitializers): Handle strings appropriately.
14806 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14808 * codegen.cs (EmitContext): Replace multiple variables with a
14809 single pointer to the current Switch statement.
14811 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14814 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14818 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14821 (Foreach.Emit): Foreach on arrays was not setting
14822 up the loop variables (for break/continue).
14824 (GotoCase): Semi-implented.
14826 2001-12-03 Ravi Pratap <ravi@ximian.com>
14828 * attribute.cs (CheckAttribute): Handle system attributes by using
14829 Attribute.GetAttributes to examine information we need.
14831 (GetValidPlaces): Same here.
14833 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
14835 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
14837 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
14839 (Method::Define): Set appropriate flags if we have a DllImport attribute.
14841 (Method::Emit): Handle the case when we are a PInvoke method.
14843 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14845 * expression.cs: Use ResolveWithSimpleName on compound names.
14847 2001-12-02 Ravi Pratap <ravi@ximian.com>
14849 * constant.cs (EmitConstant): Make sure we resolve the associated expression
14850 before trying to reduce it.
14852 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
14854 * constant.cs (LookupConstantValue): Implement.
14856 (EmitConstant): Use the above in emitting the constant.
14858 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
14859 that are user-defined by doing a LookupConstantValue on them.
14861 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
14864 2001-11-29 Miguel de Icaza <miguel@ximian.com>
14866 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
14868 (BaseAccess.DoResolve): Implement.
14870 (MemberAccess.DoResolve): Split this routine into a
14871 ResolveMemberAccess routine that can be used independently
14873 2001-11-28 Miguel de Icaza <miguel@ximian.com>
14875 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
14876 As that share bits of the implementation. Is returns a boolean,
14877 while As returns the Type that is being probed.
14879 2001-12-01 Ravi Pratap <ravi@ximian.com>
14881 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
14882 instead of a Literal - much easier.
14884 (EnumInTransit): Remove - utterly useless :-)
14886 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
14888 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
14890 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
14891 chain when we have no associated expression.
14893 2001-11-30 Ravi Pratap <ravi@ximian.com>
14895 * constant.cs (Define): Use Location while reporting the errror.
14897 Also emit a warning when 'new' is used and there is no inherited
14900 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
14903 (LookupEnumValue): Implement to lookup an enum member's value and define it
14906 (Populate): Re-write accordingly to use the above routine.
14908 2001-11-27 Miguel de Icaza <miguel@ximian.com>
14910 * expression.cs (This): Fix prototype for DoResolveLValue to
14911 override the base class DoResolveLValue.
14913 * cs-parser.cs: Report errors cs574 and cs575 (destructor
14916 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
14917 (we need to load the address of the field here). This fixes
14920 (FieldExpr.DoResolveLValue): Call the DoResolve
14921 function to initialize the Instance expression.
14923 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
14924 correctly the GetEnumerator operation on a value type.
14926 * cs-parser.jay: Add more simple parsing error catches.
14928 * statement.cs (Switch): Add support for string switches.
14929 Handle null specially.
14931 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
14933 2001-11-28 Ravi Pratap <ravi@ximian.com>
14935 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
14937 (declare_local_constant): New helper function.
14939 * statement.cs (AddConstant): Keep a separate record of constants
14941 (IsConstant): Implement to determine if a variable is a constant.
14943 (GetConstantExpression): Implement.
14945 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
14947 * statement.cs (IsVariableDefined): Re-write.
14949 2001-11-27 Ravi Pratap <ravi@ximian.com>
14951 * class.cs (TypeContainer::FindMembers): Look for constants
14952 in the case when we are looking for MemberTypes.Field
14954 * expression.cs (MemberAccess::DoResolve): Check that in the
14955 case we are a FieldExpr and a Literal, we are not being accessed
14956 by an instance reference.
14958 * cs-parser.jay (local_constant_declaration): Implement.
14960 (declaration_statement): Implement for constant declarations.
14962 2001-11-26 Miguel de Icaza <miguel@ximian.com>
14964 * statement.cs (Switch): Catch double defaults.
14966 (Switch): More work on the switch() statement
14967 implementation. It works for integral values now, need to finish
14971 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14973 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
14974 integer literals into other integer literals. To be used by
14977 2001-11-24 Ravi Pratap <ravi@ximian.com>
14979 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
14982 (EmitDynamicInitializers): Cope with the above since we extract data
14983 directly from ArrayData now.
14985 (ExpectInitializers): Keep track of whether initializers are mandatory
14988 (Bounds): Make it a hashtable to prevent the same dimension being
14989 recorded for every element in that dimension.
14991 (EmitDynamicInitializers): Fix bug which prevented the Set array method
14994 Also fix bug which was causing the indices to be emitted in the reverse
14997 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14999 * expression.cs (ArrayCreation): Implement the bits that Ravi left
15000 unfinished. They do not work, because the underlying code is
15003 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15005 * cs-parser.jay: Remove bogus fixme.
15007 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
15008 on Switch statement.
15010 2001-11-23 Ravi Pratap <ravi@ximian.com>
15012 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
15015 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
15016 parameter. Apparently, any expression is allowed.
15018 (ValidateInitializers): Update accordingly.
15020 (CheckIndices): Fix some tricky bugs thanks to recursion.
15022 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
15023 I was being completely brain-dead.
15025 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
15026 and re-write acordingly.
15028 (DelegateInvocation): Re-write accordingly.
15030 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
15032 (MakeByteBlob): Handle types more correctly.
15034 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
15035 initialization from expressions but it is incomplete because I am a complete
15038 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15040 * statement.cs (If.Emit): Fix a bug that generated incorrect code
15041 on If. Basically, we have to return `true' (ie, we do return to
15042 our caller) only if both branches of the if return.
15044 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
15045 short-circuit operators, handle them as short circuit operators.
15047 (Cast.DoResolve): Resolve type.
15048 (Cast.Cast): Take an expression as the target type.
15050 * cs-parser.jay (cast_expression): Remove old hack that only
15051 allowed a limited set of types to be handled. Now we take a
15052 unary_expression and we resolve to a type during semantic
15055 Use the grammar productions from Rhys to handle casts (this is
15056 not complete like Rhys syntax yet, we fail to handle that corner
15057 case that C# has regarding (-x), but we will get there.
15059 2001-11-22 Ravi Pratap <ravi@ximian.com>
15061 * class.cs (EmitFieldInitializer): Take care of the case when we have a
15062 field which is an array type.
15064 * cs-parser.jay (declare_local_variables): Support array initialization too.
15066 * typemanager.cs (MakeKey): Implement.
15068 (everywhere): Use the above appropriately.
15070 * cs-parser.jay (for_statement): Update for array initialization while
15071 declaring variables.
15073 * ecore.cs : The error message was correct, it's the variable's names that
15074 were misleading ;-) Make the code more readable.
15076 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
15077 the correct type etc.
15079 (ConvertExplicit): Handle Enum types by examining the underlying type.
15081 2001-11-21 Ravi Pratap <ravi@ximian.com>
15083 * parameter.cs (GetCallingConvention): Always return
15084 CallingConventions.Standard for now.
15086 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15088 * expression.cs (Binary.ResolveOperator): Update the values of `l'
15089 and `r' after calling DoNumericPromotions.
15091 * ecore.cs: Fix error message (the types were in the wrong order).
15093 * statement.cs (Foreach.ProbeCollectionType): Need to pass
15094 BindingFlags.Instance as well
15096 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
15097 implicit int literal conversion in an empty cast so that we
15098 propagate the right type upstream.
15100 (UnboxCast): new class used to unbox value types.
15101 (Expression.ConvertExplicit): Add explicit type conversions done
15104 (Expression.ImplicitNumericConversion): Oops, forgot to test for
15105 the target type before applying the implicit LongLiterals to ULong
15108 2001-11-21 Miguel de Icaza <miguel@ximian.com>
15110 * cs-parser.jay (for_statement): Reworked the way For works: now
15111 we declare manually any variables that are introduced in
15112 for_initializer to solve the problem of having out-of-band code
15113 emition (that is what got for broken).
15115 (declaration_statement): Perform the actual variable declaration
15116 that used to be done in local_variable_declaration here.
15118 (local_variable_declaration): Do not declare anything, just pass
15119 the information on a DictionaryEntry
15121 2001-11-20 Ravi Pratap <ravi@ximian.com>
15123 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
15124 re-write of the logic to now make it recursive.
15126 (UpdateIndices): Re-write accordingly.
15128 Store element data in a separate ArrayData list in the above methods.
15130 (MakeByteBlob): Implement to dump the array data into a byte array.
15132 2001-11-19 Ravi Pratap <ravi@ximian.com>
15134 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
15137 * constant.cs (Define): Implement.
15139 (EmitConstant): Re-write fully.
15141 Pass in location info.
15143 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
15146 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
15147 DictionaryEntry since we need location info too.
15149 (constant_declaration): Update accordingly.
15151 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
15152 code into another method : UpdateIndices.
15154 2001-11-18 Ravi Pratap <ravi@ximian.com>
15156 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
15157 some type checking etc.
15159 2001-11-17 Ravi Pratap <ravi@ximian.com>
15161 * expression.cs (ArrayCreation::ValidateInitializers): Implement
15162 bits to provide dimension info if the user skips doing that.
15164 Update second constructor to store the rank correctly.
15166 2001-11-16 Ravi Pratap <ravi@ximian.com>
15168 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
15169 and try to implement.
15171 * ../errors/cs0150.cs : Add.
15173 * ../errors/cs0178.cs : Add.
15175 2001-11-16 Miguel de Icaza <miguel@ximian.com>
15177 * statement.cs: Implement foreach on multi-dimensional arrays.
15179 * parameter.cs (Parameters.GetParameterByName): Also lookup the
15180 name of the params argument.
15182 * expression.cs: Use EmitStoreOpcode to get the right opcode while
15183 initializing the array.
15185 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
15186 we can use this elsewhere.
15188 * statement.cs: Finish implementation of foreach for single
15191 * cs-parser.jay: Use an out-of-band stack to pass information
15192 around, I wonder why I need this.
15194 foreach_block: Make the new foreach_block the current_block.
15196 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
15197 function used to return a static Parameters structure. Used for
15198 empty parameters, as those are created very frequently.
15200 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
15202 2001-11-15 Ravi Pratap <ravi@ximian.com>
15204 * interface.cs : Default modifier is private, not public. The
15205 make verify test passes again.
15207 2001-11-15 Ravi Pratap <ravi@ximian.com>
15209 * support.cs (ReflectionParameters): Fix logic to determine
15210 whether the last parameter is a params one. Test 9 passes again.
15212 * delegate.cs (Populate): Register the builders we define with
15213 RegisterParameterForBuilder. Test 19 passes again.
15215 * cs-parser.jay (property_declaration): Reference $6 instead
15216 of $$ to get at the location.
15218 (indexer_declaration): Similar stuff.
15220 (attribute): Ditto.
15222 * class.cs (Property): Register parameters for the Get and Set methods
15223 if they exist. Test 23 passes again.
15225 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
15226 call to EmitArguments as we are sure there aren't any params arguments.
15227 Test 32 passes again.
15229 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
15230 IndexOutOfRangeException.
15232 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
15233 Test 33 now passes again.
15235 2001-11-15 Miguel de Icaza <miguel@ximian.com>
15237 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
15238 broke a bunch of things. Will have to come up with a better way
15239 of tracking locations.
15241 * statement.cs: Implemented foreach for single dimension arrays.
15243 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15245 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
15246 an error. This removes the lookup from the critical path.
15248 * cs-parser.jay: Removed use of temporary_loc, which is completely
15251 2001-11-14 Miguel de Icaza <miguel@ximian.com>
15253 * support.cs (ReflectionParameters.ParameterModifier): Report
15254 whether the argument is a PARAMS argument or not.
15256 * class.cs: Set the attribute `ParamArrayAttribute' on the
15257 parameter argument.
15259 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
15260 and cons_param_array_attribute (ConstructorInfo for
15261 ParamArrayAttribute).,
15263 * codegen.cs: Emit the return using the `Return' statement, that
15264 way we can report the error correctly for missing return values.
15266 * class.cs (Method.Emit): Clean up.
15268 * expression.cs (Argument.Resolve): Take another argument: the
15269 location where this argument is used. Notice that this is not
15270 part of the "Argument" class as to reduce the size of the
15271 structure (we know the approximate location anyways).
15273 Test if the argument is a variable-reference, if not, then
15274 complain with a 206.
15276 (Argument.Emit): Emit addresses of variables.
15278 (Argument.FullDesc): Simplify.
15280 (Invocation.DoResolve): Update for Argument.Resolve.
15282 (ElementAccess.DoResolve): ditto.
15284 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
15285 method should be virtual, as this method is always virtual.
15287 (NewDelegate.DoResolve): Update for Argument.Resolve.
15289 * class.cs (ConstructorInitializer.DoResolve): ditto.
15291 * attribute.cs (Attribute.Resolve): ditto.
15293 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15295 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
15297 * expression.cs (ParameterReference): Drop IStackStorage and implement
15298 IAssignMethod instead.
15300 (LocalVariableReference): ditto.
15302 * ecore.cs (FieldExpr): Drop IStackStorage and implement
15303 IAssignMethod instead.
15305 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15307 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
15308 enumerations that are used in heavily used structures derive from
15309 byte in a laughable and pathetic attempt to reduce memory usage.
15310 This is the kind of pre-optimzations that you should not do at
15311 home without adult supervision.
15313 * expression.cs (UnaryMutator): New class, used to handle ++ and
15314 -- separatedly from the other unary operators. Cleans up the
15315 code, and kills the ExpressionStatement dependency in Unary.
15317 (Unary): Removed `method' and `Arguments' from this class, making
15318 it smaller, and moving it all to SimpleCall, so I can reuse this
15319 code in other locations and avoid creating a lot of transient data
15320 strucutres when not required.
15322 * cs-parser.jay: Adjust for new changes.
15324 2001-11-11 Miguel de Icaza <miguel@ximian.com>
15326 * enum.cs (Enum.Populate): If there is a failure during
15329 * cs-parser.jay (opt_enum_base): we used to catch type errors
15330 here, but this is really incorrect. The type error should be
15331 catched during semantic analysis.
15333 2001-12-11 Ravi Pratap <ravi@ximian.com>
15335 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
15336 current_local_parameters as expected since I, in my stupidity, had forgotten
15339 * attribute.cs (GetValidPlaces): Fix stupid bug.
15341 * class.cs (Method::Emit): Perform check on applicability of attributes.
15343 (Constructor::Emit): Ditto.
15345 (Field::Emit): Ditto.
15347 (Field.Location): Store location information.
15349 (Property, Event, Indexer, Operator): Ditto.
15351 * cs-parser.jay (field_declaration): Pass in location for each field.
15353 * ../errors/cs0592.cs : Add.
15355 2001-11-12 Ravi Pratap <ravi@ximian.com>
15357 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
15359 (InitCoreTypes): Update accordingly.
15361 (RegisterAttrType, LookupAttr): Implement.
15363 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
15364 info about the same.
15366 (Resolve): Update to populate the above as necessary.
15368 (Error592): Helper.
15370 (GetValidPlaces): Helper to the above.
15372 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
15374 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
15376 2001-11-12 Ravi Pratap <ravi@ximian.com>
15378 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
15380 * ../errors/cs0617.cs : Add.
15382 2001-11-11 Ravi Pratap <ravi@ximian.com>
15384 * enum.cs (Emit): Rename to Populate to be more consistent with what
15385 we expect it to do and when exactly it is called.
15387 * class.cs, rootcontext.cs : Update accordingly.
15389 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
15390 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
15392 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
15394 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
15395 of a fieldinfo using the above, when dealing with a FieldBuilder.
15397 2001-11-10 Ravi Pratap <ravi@ximian.com>
15399 * ../errors/cs0031.cs : Add.
15401 * ../errors/cs1008.cs : Add.
15403 * ../errrors/cs0543.cs : Add.
15405 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
15408 (FindMembers): Implement.
15410 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
15411 enums and delegates too.
15413 (enum_types): Rename to builder_to_enum.
15415 (delegate_types): Rename to builder_to_delegate.
15417 * delegate.cs (FindMembers): Implement.
15419 2001-11-09 Ravi Pratap <ravi@ximian.com>
15421 * typemanager.cs (IsEnumType): Implement.
15423 * enum.cs (Emit): Re-write parts to account for the underlying type
15424 better and perform checking etc.
15426 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
15427 of the underlying type.
15429 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
15432 * enum.cs (error31): Helper to report error #31.
15434 * cs-parser.jay (enum_declaration): Store location of each member too.
15436 * enum.cs (member_to_location): New hashtable.
15438 (AddEnumMember): Update location hashtable.
15440 (Emit): Use the location of each member while reporting errors.
15442 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15444 * cs-parser.jay: A for_initializer if is a
15445 local_variable_declaration really ammount to have an implicit
15446 block with the variable declaration and no initializer for for.
15448 * statement.cs (For.Emit): Cope with null initializers.
15450 This fixes the infinite loop on for initializers.
15452 2001-11-08 Miguel de Icaza <miguel@ximian.com>
15454 * enum.cs: More cleanup.
15456 * ecore.cs: Remove dead code.
15458 * class.cs (Property.Emit): More simplification.
15459 (Event.Emit): ditto.
15461 Reworked to have less levels of indentation.
15463 2001-11-08 Ravi Pratap <ravi@ximian.com>
15465 * class.cs (Property): Emit attributes.
15475 * enum.cs (Emit): Ditto.
15477 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
15480 * class.cs (Field, Event, etc.): Move attribute generation into the
15481 Emit method everywhere.
15483 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15484 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15485 as we had no way of defining nested enums !
15487 * rootcontext.cs : Adjust code accordingly.
15489 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15491 2001-11-07 Ravi Pratap <ravi@ximian.com>
15493 * expression.cs (EvalConstantExpression): Move into ecore.cs
15495 * enum.cs (Enum): Rename some members and make them public and readonly
15496 according to our convention.
15498 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15501 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15503 (Enum::Emit): Write a simple version for now which doesn't try to compute
15504 expressions. I shall modify this to be more robust in just a while.
15506 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15508 (TypeContainer::CloseType): Create the Enum types too.
15510 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15512 * expression.cs (EvalConstantExpression): Get rid of completely.
15514 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15515 user-defined values and other cases.
15517 (IsValidEnumLiteral): Helper function.
15519 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15520 out there in the case we had a literal FieldExpr.
15522 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15524 (Literalize): Revamp a bit to take two arguments.
15526 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15528 2001-11-06 Ravi Pratap <ravi@ximian.com>
15530 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15532 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15534 (Resolve): Use the above to ensure we have proper initializers.
15536 2001-11-05 Ravi Pratap <ravi@ximian.com>
15538 * expression.cs (Expression::EvalConstantExpression): New method to
15539 evaluate constant expressions.
15541 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15543 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15545 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15548 (Binary.ResolveOperator): Handle operator != (object a, object b)
15549 and operator == (object a, object b);
15551 (Binary.DoNumericPromotions): Indicate whether the numeric
15552 promotion was possible.
15554 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15557 Made the ArrayAccess implement interface IAssignMethod instead of
15558 IStackStore as the order in which arguments are passed reflects
15561 * assign.cs: Instead of using expr.ExprClass to select the way of
15562 assinging, probe for the IStackStore/IAssignMethod interfaces.
15564 * typemanager.cs: Load InitializeArray definition.
15566 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15567 static data that can be used to initialize arrays.
15569 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15571 * expression.cs: Handle operator== and operator!= for booleans.
15573 (Conditioal.Reduce): Implement reducer for the ?: operator.
15575 (Conditional.Resolve): Implement dead code elimination.
15577 (Binary.Resolve): Catch string literals and return a new
15578 concatenated string.
15580 (Unary.Reduce): Implement reduction of unary expressions.
15582 * ecore.cs: Split out the expression core handling here.
15584 (Expression.Reduce): New method used to perform constant folding
15585 and CSE. This is needed to support constant-expressions.
15587 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15588 targets, and optimize for !x.
15590 2001-11-04 Ravi Pratap <ravi@ximian.com>
15592 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15593 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15594 set custom atttributes.
15596 * literal.cs (Literal::GetValue): New abstract method to return the actual
15597 value of the literal, cast as an object.
15599 (*Literal): Implement GetValue method.
15601 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15602 expressions to the arraylist but objects of type Argument.
15604 * class.cs (TypeContainer::Emit): Emit our attributes too.
15606 (Method::Emit, Constructor::Emit): Ditto.
15608 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15609 to be ignoring earlier.
15611 2001-11-03 Ravi Pratap <ravi@ximian.com>
15613 * attribute.cs (AttributeSection::Define): Implement to do the business
15614 of constructing a CustomAttributeBuilder.
15616 (Attribute): New trivial class. Increases readability of code.
15618 * cs-parser.jay : Update accordingly.
15620 (positional_argument_list, named_argument_list, named_argument): New rules
15622 (attribute_arguments): Use the above so that we are more correct.
15624 2001-11-02 Ravi Pratap <ravi@ximian.com>
15626 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15627 to perform all checks for a method with a params parameter.
15629 (Invocation::OverloadResolve): Update to use the above method and therefore
15630 cope correctly with params method invocations.
15632 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15635 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15636 constructors in our parent too because we can't afford to miss out on
15639 * attribute.cs (AttributeSection): New name for the class Attribute
15641 Other trivial changes to improve readability.
15643 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15644 use the new class names.
15646 2001-11-01 Ravi Pratap <ravi@ximian.com>
15648 * class.cs (Method::Define): Complete definition for params types too
15650 (Indexer::Define): Ditto.
15652 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15653 Cope everywhere with a request for info about the array parameter.
15655 2001-11-01 Ravi Pratap <ravi@ximian.com>
15657 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15659 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15660 local_variable_type to extract the string corresponding to the type.
15662 (local_variable_type): Fixup the action to use the new helper method.
15664 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15667 * expression.cs : Clean out code which uses the above.
15669 2001-10-31 Ravi Pratap <ravi@ximian.com>
15671 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15672 and bale out if necessary by returning a false.
15674 (RegisterProperty): Ditto.
15676 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15677 and print out appropriate error messages.
15679 * interface.cs (everywhere): Ditto.
15681 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15682 location to constructor.
15684 * class.cs (Property, Event, Indexer): Update accordingly.
15686 * ../errors/cs111.cs : Added.
15688 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15689 of a method, as laid down by the spec.
15691 (Invocation::OverloadResolve): Use the above method.
15693 2001-10-31 Ravi Pratap <ravi@ximian.com>
15695 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15696 now take a TypeContainer and a Parameters object.
15698 (ParameterData): Modify return type of ParameterModifier method to be
15699 Parameter.Modifier and not a string.
15701 (ReflectionParameters, InternalParameters): Update accordingly.
15703 * expression.cs (Argument::GetParameterModifier): Same here.
15705 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15706 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15707 symbol in it at all so maybe this is only for now.
15709 2001-10-30 Ravi Pratap <ravi@ximian.com>
15711 * support.cs (InternalParameters): Constructor now takes an extra argument
15712 which is the actual Parameters class.
15714 (ParameterDesc): Update to provide info on ref/out modifiers.
15716 * class.cs (everywhere): Update call to InternalParameters to pass in
15717 the second argument too.
15719 * support.cs (ParameterData): Add ParameterModifier, which is a method
15720 to return the modifier info [ref/out etc]
15722 (InternalParameters, ReflectionParameters): Implement the above.
15724 * expression.cs (Argument::ParameterModifier): Similar function to return
15725 info about the argument's modifiers.
15727 (Invocation::OverloadResolve): Update to take into account matching modifiers
15730 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15731 a new SetFormalParameters object which we pass to InternalParameters.
15733 2001-10-30 Ravi Pratap <ravi@ximian.com>
15735 * expression.cs (NewArray): Merge into the ArrayCreation class.
15737 2001-10-29 Ravi Pratap <ravi@ximian.com>
15739 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15740 NewUserdefinedArray into one as there wasn't much of a use in having
15743 * expression.cs (Argument): Change field's name to ArgType from Type.
15745 (Type): New readonly property which returns the proper type, taking into
15746 account ref/out modifiers.
15748 (everywhere): Adjust code accordingly for the above.
15750 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15751 whether we are emitting for a ref or out parameter.
15753 * expression.cs (Argument::Emit): Use the above field to set the state.
15755 (LocalVariableReference::Emit): Update to honour the flag and emit the
15758 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15760 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15762 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15764 (ReflectionParameters, InternalParameters): Implement the above method.
15766 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15769 (Invocation::FullMethodDesc): Ditto.
15771 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15773 * cs-parser.jay: Add extra production for the second form of array
15776 * expression.cs (ArrayCreation): Update to reflect the above
15779 * Small changes to prepare for Array initialization.
15781 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15783 * typemanager.cs (ImplementsInterface): interface might be null;
15784 Deal with this problem;
15786 Also, we do store negative hits on the cache (null values), so use
15787 this instead of calling t.GetInterfaces on the type everytime.
15789 2001-10-28 Ravi Pratap <ravi@ximian.com>
15791 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15793 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15794 split functionality out into different classes.
15796 (New::FormArrayType): Move into NewBuiltinArray.
15798 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15801 (NewBuiltinArray): New class to handle creation of built-in arrays.
15803 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15804 account creation of one-dimensional arrays.
15806 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15808 (NewUserdefinedArray::DoResolve): Implement.
15810 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15812 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15813 we maintain inside the TypeManager. This is necessary to perform lookups on the
15816 (LookupType): Update to perform GetType on the module builders too.
15818 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15820 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15822 2001-10-23 Ravi Pratap <ravi@ximian.com>
15824 * expression.cs (New::DoResolve): Implement guts of array creation.
15826 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15828 2001-10-27 Miguel de Icaza <miguel@ximian.com>
15830 * expression.cs: Fix bug I introduced lsat night that broke
15833 (Expression.Resolve): Report a 246 error (can not resolve name)
15834 if we find a SimpleName in the stream.
15836 (Expression.ResolveLValue): Ditto.
15838 (Expression.ResolveWithSimpleName): This function is a variant of
15839 ResolveName, this one allows SimpleNames to be returned without a
15840 warning. The only consumer of SimpleNames is MemberAccess
15842 2001-10-26 Miguel de Icaza <miguel@ximian.com>
15844 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
15845 might arrive here. I have my doubts that this is correct.
15847 * statement.cs (Lock): Implement lock statement.
15849 * cs-parser.jay: Small fixes to support `lock' and `using'
15851 * cs-tokenizer.cs: Remove extra space
15853 * driver.cs: New flag --checked, allows to turn on integer math
15856 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
15857 Threading.Monitor.Exit
15859 2001-10-23 Miguel de Icaza <miguel@ximian.com>
15861 * expression.cs (IndexerAccess::DoResolveLValue): Set the
15862 Expression Class to be IndexerAccess.
15864 Notice that Indexer::DoResolve sets the eclass to Value.
15866 2001-10-22 Miguel de Icaza <miguel@ximian.com>
15868 * class.cs (TypeContainer::Emit): Emit code for indexers.
15870 * assign.cs (IAssignMethod): New interface implemented by Indexers
15871 and Properties for handling assignment.
15873 (Assign::Emit): Simplify and reuse code.
15875 * expression.cs (IndexerAccess, PropertyExpr): Implement
15876 IAssignMethod, clean up old code.
15878 2001-10-22 Ravi Pratap <ravi@ximian.com>
15880 * typemanager.cs (ImplementsInterface): New method to determine if a type
15881 implements a given interface. Provides a nice cache too.
15883 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
15886 (ConvertReferenceExplicit): Ditto.
15888 * delegate.cs (Delegate::Populate): Update to define the parameters on the
15889 various methods, with correct names etc.
15891 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
15892 Operator.UnaryNegation.
15894 * cs-parser.jay (operator_declarator): Be a little clever in the case where
15895 we have a unary plus or minus operator.
15897 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
15900 * everywhere : update accordingly.
15902 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
15905 * class.cs (Method::Define): For the case where we are implementing a method
15906 inherited from an interface, we need to set the MethodAttributes.Final flag too.
15907 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
15909 2001-10-21 Ravi Pratap <ravi@ximian.com>
15911 * interface.cs (FindMembers): Implement to work around S.R.E
15914 * typemanager.cs (IsInterfaceType): Implement.
15916 (FindMembers): Update to handle interface types too.
15918 * expression.cs (ImplicitReferenceConversion): Re-write bits which
15919 use IsAssignableFrom as that is not correct - it doesn't work.
15921 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
15922 and accordingly override EmitStatement.
15924 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
15925 using the correct logic :-)
15927 2001-10-19 Ravi Pratap <ravi@ximian.com>
15929 * ../errors/cs-11.cs : Add to demonstrate error -11
15931 2001-10-17 Miguel de Icaza <miguel@ximian.com>
15933 * assign.cs (Assign::Resolve): Resolve right hand side first, and
15934 then pass this as a hint to ResolveLValue.
15936 * expression.cs (FieldExpr): Add Location information
15938 (FieldExpr::LValueResolve): Report assignment to readonly
15941 (Expression::ExprClassFromMemberInfo): Pass location information.
15943 (Expression::ResolveLValue): Add new method that resolves an
15946 (Expression::DoResolveLValue): Default invocation calls
15949 (Indexers): New class used to keep track of indexers in a given
15952 (IStackStore): Renamed from LValue, as it did not really describe
15953 what this did. Also ResolveLValue is gone from this interface and
15954 now is part of Expression.
15956 (ElementAccess): Depending on the element access type
15958 * typemanager.cs: Add `indexer_name_type' as a Core type
15959 (System.Runtime.CompilerServices.IndexerNameAttribute)
15961 * statement.cs (Goto): Take a location.
15963 2001-10-18 Ravi Pratap <ravi@ximian.com>
15965 * delegate.cs (Delegate::VerifyDelegate): New method to verify
15966 if two delegates are compatible.
15968 (NewDelegate::DoResolve): Update to take care of the case when
15969 we instantiate a delegate from another delegate.
15971 * typemanager.cs (FindMembers): Don't even try to look up members
15972 of Delegate types for now.
15974 2001-10-18 Ravi Pratap <ravi@ximian.com>
15976 * delegate.cs (NewDelegate): New class to take care of delegate
15979 * expression.cs (New): Split the delegate related code out into
15980 the NewDelegate class.
15982 * delegate.cs (DelegateInvocation): New class to handle delegate
15985 * expression.cs (Invocation): Split out delegate related code into
15986 the DelegateInvocation class.
15988 2001-10-17 Ravi Pratap <ravi@ximian.com>
15990 * expression.cs (New::DoResolve): Implement delegate creation fully
15991 and according to the spec.
15993 (New::DoEmit): Update to handle delegates differently.
15995 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
15996 because of which we were printing out arguments in reverse order !
15998 * delegate.cs (VerifyMethod): Implement to check if the given method
15999 matches the delegate.
16001 (FullDelegateDesc): Implement.
16003 (VerifyApplicability): Implement.
16005 * expression.cs (Invocation::DoResolve): Update to accordingly handle
16006 delegate invocations too.
16008 (Invocation::Emit): Ditto.
16010 * ../errors/cs1593.cs : Added.
16012 * ../errors/cs1594.cs : Added.
16014 * delegate.cs (InstanceExpression, TargetMethod): New properties.
16016 2001-10-16 Ravi Pratap <ravi@ximian.com>
16018 * typemanager.cs (intptr_type): Core type for System.IntPtr
16020 (InitCoreTypes): Update for the same.
16022 (iasyncresult_type, asynccallback_type): Ditto.
16024 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
16027 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
16030 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
16031 the builders for the 4 members of a delegate type :-)
16033 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
16036 * expression.cs (New::DoResolve): Implement guts for delegate creation.
16038 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
16040 2001-10-15 Miguel de Icaza <miguel@ximian.com>
16042 * statement.cs (Break::Emit): Implement.
16043 (Continue::Emit): Implement.
16045 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
16046 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
16047 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
16048 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
16051 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
16052 properties that track the label for the current loop (begin of the
16053 loop and end of the loop).
16055 2001-10-15 Ravi Pratap <ravi@ximian.com>
16057 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
16058 use of emitting anything at all.
16060 * class.cs, rootcontext.cs : Get rid of calls to the same.
16062 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
16064 (Populate): Define the constructor correctly and set the implementation
16067 * typemanager.cs (delegate_types): New hashtable to hold delegates that
16070 (AddDelegateType): Implement.
16072 (IsDelegateType): Implement helper method.
16074 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
16076 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
16077 and accordingly handle it.
16079 * delegate.cs (Populate): Take TypeContainer argument.
16080 Implement bits to define the Invoke method. However, I still haven't figured out
16081 how to take care of the native int bit :-(
16083 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
16084 Qualify the name of the delegate, not its return type !
16086 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
16089 (StandardConversionExists): Checking for array types turns out to be recursive.
16091 (ConvertReferenceExplicit): Implement array conversion.
16093 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
16095 2001-10-12 Ravi Pratap <ravi@ximian.com>
16097 * cs-parser.jay (delegate_declaration): Store the fully qualified
16098 name as it is a type declaration.
16100 * delegate.cs (ReturnType, Name): Rename members to these. Make them
16103 (DefineDelegate): Renamed from Define. Does the same thing essentially,
16104 as TypeContainer::DefineType.
16106 (Populate): Method in which all the definition of the various methods (Invoke)
16109 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
16112 (CloseDelegate): Finally creates the delegate.
16114 * class.cs (TypeContainer::DefineType): Update to define delegates.
16115 (Populate, Emit and CloseType): Do the same thing here too.
16117 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
16118 delegates in all these operations.
16120 2001-10-14 Miguel de Icaza <miguel@ximian.com>
16122 * expression.cs: LocalTemporary: a new expression used to
16123 reference a temporary that has been created.
16125 * assign.cs: Handle PropertyAccess back here, so that we can
16126 provide the proper semantic access to properties.
16128 * expression.cs (Expression::ConvertReferenceExplicit): Implement
16129 a few more explicit conversions.
16131 * modifiers.cs: `NEW' modifier maps to HideBySig.
16133 * expression.cs (PropertyExpr): Make this into an
16134 ExpressionStatement, and support the EmitStatement code path.
16136 Perform get/set error checking, clean up the interface.
16138 * assign.cs: recognize PropertyExprs as targets, and if so, turn
16139 them into toplevel access objects.
16141 2001-10-12 Miguel de Icaza <miguel@ximian.com>
16143 * expression.cs: PropertyExpr::PropertyExpr: use work around the
16146 * typemanager.cs: Keep track here of our PropertyBuilders again to
16147 work around lameness in SRE.
16149 2001-10-11 Miguel de Icaza <miguel@ximian.com>
16151 * expression.cs (LValue::LValueResolve): New method in the
16152 interface, used to perform a second resolution pass for LValues.
16154 (This::DoResolve): Catch the use of this in static methods.
16156 (This::LValueResolve): Implement.
16158 (This::Store): Remove warning, assigning to `this' in structures
16161 (Invocation::Emit): Deal with invocation of
16162 methods on value types. We need to pass the address to structure
16163 methods rather than the object itself. (The equivalent code to
16164 emit "this" for structures leaves the entire structure on the
16165 stack instead of a pointer to it).
16167 (ParameterReference::DoResolve): Compute the real index for the
16168 argument based on whether the method takes or not a `this' pointer
16169 (ie, the method is static).
16171 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
16172 value types returned from functions when we need to invoke a
16173 method on the sturcture.
16176 2001-10-11 Ravi Pratap <ravi@ximian.com>
16178 * class.cs (TypeContainer::DefineType): Method to actually do the business of
16179 defining the type in the Modulebuilder or Typebuilder. This is to take
16180 care of nested types which need to be defined on the TypeBuilder using
16181 DefineNestedMethod.
16183 (TypeContainer::GetClassBases): Implement. Essentially the code from the
16184 methods in RootContext, only ported to be part of TypeContainer.
16186 (TypeContainer::GetInterfaceOrClass): Ditto.
16188 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
16190 * interface.cs (Interface::DefineInterface): New method. Does exactly
16191 what RootContext.CreateInterface did earlier, only it takes care of nested types
16194 (Interface::GetInterfaces): Move from RootContext here and port.
16196 (Interface::GetInterfaceByName): Same here.
16198 * rootcontext.cs (ResolveTree): Re-write.
16200 (PopulateTypes): Re-write.
16202 * class.cs (TypeContainer::Populate): Populate nested types too.
16203 (TypeContainer::Emit): Emit nested members too.
16205 * typemanager.cs (AddUserType): Do not make use of the FullName property,
16206 instead just use the name argument passed in as it is already fully
16209 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
16210 to TypeContainer mapping to see if a type is user-defined.
16212 * class.cs (TypeContainer::CloseType): Implement.
16214 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
16215 the default constructor.
16217 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
16220 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
16222 * interface.cs (CloseType): Create the type here.
16224 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
16227 Remove all the methods which are now in TypeContainer.
16229 2001-10-10 Ravi Pratap <ravi@ximian.com>
16231 * delegate.cs (Define): Re-write bits to define the delegate
16234 2001-10-10 Miguel de Icaza <miguel@ximian.com>
16236 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
16238 * expression.cs (ImplicitReferenceConversion): handle null as well
16239 as a source to convert to any reference type.
16241 * statement.cs (Return): Perform any implicit conversions to
16242 expected return type.
16244 Validate use of return statement.
16246 * codegen.cs (EmitContext): Pass the expected return type here.
16248 * class.cs (Method, Constructor, Property): Pass expected return
16249 type to EmitContext.
16251 2001-10-09 Miguel de Icaza <miguel@ximian.com>
16253 * expression.cs: Make DoResolve take an EmitContext instead of a
16256 Replaced `l' and `location' for `loc', for consistency.
16258 (Error, Warning): Remove unneeded Tc argument.
16260 * assign.cs, literal.cs, constant.cs: Update to new calling
16263 * codegen.cs: EmitContext now contains a flag indicating whether
16264 code is being generated in a static method or not.
16266 * cs-parser.jay: DecomposeQI, new function that replaces the old
16267 QualifiedIdentifier. Now we always decompose the assembled
16268 strings from qualified_identifier productions into a group of
16271 2001-10-08 Miguel de Icaza <miguel@ximian.com>
16273 * rootcontext.cs: Deal with field-less struct types correctly now
16274 by passing the size option to Define Type.
16276 * class.cs: Removed hack that created one static field.
16278 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16280 * statement.cs: Moved most of the code generation here.
16282 2001-10-09 Ravi Pratap <ravi@ximian.com>
16284 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
16287 (ElementAccess): Remove useless bits for now - keep checks as the spec
16290 2001-10-08 Ravi Pratap <ravi@ximian.com>
16292 * expression.cs (ElementAccess::DoResolve): Remove my crap code
16293 and start performing checks according to the spec.
16295 2001-10-07 Ravi Pratap <ravi@ximian.com>
16297 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
16298 rank_specifiers instead.
16300 (rank_specifiers): Change the order in which the rank specifiers are stored
16302 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
16304 * expression.cs (ElementAccess): Implement the LValue interface too.
16306 2001-10-06 Ravi Pratap <ravi@ximian.com>
16308 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
16309 except that user defined conversions are not included.
16311 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
16312 perform the conversion of the return type, if necessary.
16314 (New::DoResolve): Check whether we are creating an array or an object
16315 and accordingly do the needful.
16317 (New::Emit): Same here.
16319 (New::DoResolve): Implement guts of array creation.
16321 (New::FormLookupType): Helper function.
16323 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16325 * codegen.cs: Removed most of the code generation here, and move the
16326 corresponding code generation bits to the statement classes.
16328 Added support for try/catch/finalize and throw.
16330 * cs-parser.jay: Added support for try/catch/finalize.
16332 * class.cs: Catch static methods having the flags override,
16333 virtual or abstract.
16335 * expression.cs (UserCast): This user cast was not really doing
16336 what it was supposed to do. Which is to be born in fully resolved
16337 state. Parts of the resolution were being performed at Emit time!
16341 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16343 * expression.cs: Implicity convert the result from UserCast.
16345 2001-10-05 Ravi Pratap <ravi@ximian.com>
16347 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
16348 prevented it from working correctly.
16350 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
16351 merely ConvertImplicit.
16353 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16355 * typemanager.cs: Make the LookupTypeContainer function static,
16356 and not per-instance.
16358 * class.cs: Make static FindMembers (the one that takes a Type
16361 * codegen.cs: Add EmitForeach here.
16363 * cs-parser.jay: Make foreach a toplevel object instead of the
16364 inline expansion, as we need to perform semantic analysis on it.
16366 2001-10-05 Ravi Pratap <ravi@ximian.com>
16368 * expression.cs (Expression::ImplicitUserConversion): Rename to
16369 UserDefinedConversion.
16371 (Expression::UserDefinedConversion): Take an extra argument specifying
16372 whether we look for explicit user conversions too.
16374 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
16376 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
16378 (ExplicitUserConversion): Make it a call to UserDefinedConversion
16379 with the appropriate arguments.
16381 * cs-parser.jay (cast_expression): Record location too.
16383 * expression.cs (Cast): Record location info.
16385 (Expression::ConvertExplicit): Take location argument.
16387 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
16388 to determine if we are doing explicit conversions.
16390 (UserCast::Emit): Update accordingly.
16392 (Expression::ConvertExplicit): Report an error if everything fails.
16394 * ../errors/cs0030.cs : Add.
16396 2001-10-04 Miguel de Icaza <miguel@ximian.com>
16398 * modifiers.cs: If the ABSTRACT keyword is present, also set the
16399 virtual and newslot bits.
16401 * class.cs (TypeContainer::RegisterRequiredImplementations):
16402 Record methods we need.
16404 (TypeContainer::MakeKey): Helper function to make keys for
16405 MethodBases, since the Methodbase key is useless.
16407 (TypeContainer::Populate): Call RegisterRequiredImplementations
16408 before defining the methods.
16410 Create a mapping for method_builders_to_methods ahead of time
16411 instead of inside a tight loop.
16413 (::RequireMethods): Accept an object as the data to set into the
16414 hashtable so we can report interface vs abstract method mismatch.
16416 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16418 * report.cs: Make all of it static.
16420 * rootcontext.cs: Drop object_type and value_type computations, as
16421 we have those in the TypeManager anyways.
16423 Drop report instance variable too, now it is a global.
16425 * driver.cs: Use try/catch on command line handling.
16427 Add --probe option to debug the error reporting system with a test
16430 * report.cs: Add support for exiting program when a probe
16431 condition is reached.
16433 2001-10-03 Ravi Pratap <ravi@ximian.com>
16435 * expression.cs (Binary::DoNumericPromotions): Fix the case when
16436 we do a forcible conversion regardless of type, to check if
16437 ForceConversion returns a null.
16439 (Binary::error19): Use location to report error.
16441 (Unary::error23): Use location here too.
16443 * ../errors/cs0019.cs : Check in.
16445 * ../errors/cs0023.cs : Check in.
16447 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
16448 case of a non-null MethodInfo object with a length of 0 !
16450 (Binary::ResolveOperator): Flag error if overload resolution fails to find
16451 an applicable member - according to the spec :-)
16452 Also fix logic to find members in base types.
16454 (Unary::ResolveOperator): Same here.
16456 (Unary::report23): Change name to error23 and make first argument a TypeContainer
16457 as I was getting thoroughly confused between this and error19 :-)
16459 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
16460 (::FindMostEncompassedType): Implement.
16461 (::FindMostEncompassingType): Implement.
16462 (::StandardConversionExists): Implement.
16464 (UserImplicitCast): Re-vamp. We now need info about most specific
16465 source and target types so that we can do the necessary conversions.
16467 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
16468 mathematical union with no duplicates.
16470 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16472 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
16473 in order from base classes to child classes, so that we can in
16474 child classes look up in our parent for method names and
16475 attributes (required for handling abstract, virtual, new, override
16476 constructs: we need to instrospect our base class, and if we dont
16477 populate the classes in order, the introspection might be
16478 incorrect. For example, a method could query its parent before
16479 the parent has any methods and would determine that the parent has
16480 no abstract methods (while it could have had them)).
16482 (RootContext::CreateType): Record the order in which we define the
16485 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16487 * class.cs (TypeContainer::Populate): Also method definitions can
16488 fail now, keep track of this.
16490 (TypeContainer::FindMembers): Implement support for
16491 DeclaredOnly/noDeclaredOnly flag.
16493 (Constructor::Emit) Return the ConstructorBuilder.
16495 (Method::Emit) Return the MethodBuilder.
16496 Check for abstract or virtual methods to be public.
16498 * rootcontext.cs (RootContext::CreateType): Register all the
16499 abstract methods required for the class to be complete and the
16500 interface methods that must be implemented.
16502 * cs-parser.jay: Report error 501 (method requires body if it is
16503 not marked abstract or extern).
16505 * expression.cs (TypeOf::Emit): Implement.
16507 * typemanager.cs: runtime_handle_type, new global type.
16509 * class.cs (Property::Emit): Generate code for properties.
16511 2001-10-02 Ravi Pratap <ravi@ximian.com>
16513 * expression.cs (Unary::ResolveOperator): Find operators on base type
16514 too - we now conform exactly to the spec.
16516 (Binary::ResolveOperator): Same here.
16518 * class.cs (Operator::Define): Fix minor quirk in the tests.
16520 * ../errors/cs0215.cs : Added.
16522 * ../errors/cs0556.cs : Added.
16524 * ../errors/cs0555.cs : Added.
16526 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16528 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16529 single integer which is really efficient
16531 2001-10-01 Ravi Pratap <ravi@ximian.com>
16533 * expression.cs (Expression::ImplicitUserConversion): Use location
16534 even in the case when we are examining True operators.
16536 * class.cs (Operator::Define): Perform extensive checks to conform
16537 with the rules for operator overloading in the spec.
16539 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16540 some of the other conversions mentioned in the spec.
16542 * typemanager.cs (array_type): New static member for the System.Array built-in
16545 (cloneable_interface): For System.ICloneable interface.
16547 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16548 we start resolving the tree and populating types.
16550 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16552 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16554 * expression.cs (Expression::ExprClassFromMemberInfo,
16555 Expression::Literalize): Create literal expressions from
16556 FieldInfos which are literals.
16558 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16559 type casts, because they were wrong. The test suite in tests
16562 (ImplicitNumericConversion): ushort to ulong requires a widening
16565 Int32 constant to long requires widening cast as well.
16567 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16568 for integers because the type on the stack is not i4.
16570 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16572 * expression.cs (report118): require location argument.
16574 * parameter.cs: Do not dereference potential null value.
16576 * class.cs: Catch methods that lack the `new' keyword when
16577 overriding a name. Report warnings when `new' is used without
16578 anything being there to override.
16580 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16582 * class.cs: Only add constructor to hashtable if it is non-null
16583 (as now constructors can fail on define).
16585 (TypeManager, Class, Struct): Take location arguments.
16587 Catch field instance initialization in structs as errors.
16589 accepting_filter: a new filter for FindMembers that is static so
16590 that we dont create an instance per invocation.
16592 (Constructor::Define): Catch errors where a struct constructor is
16595 * cs-parser.jay: Pass location information for various new
16598 * delegate.cs (Delegate): take a location argument.
16600 * driver.cs: Do not call EmitCode if there were problesm in the
16601 Definition of the types, as many Builders wont be there.
16603 * decl.cs (Decl::Decl): Require a location argument.
16605 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16606 into integers, and find the most appropiate integer for it.
16608 * literal.cs: Implement ULongLiteral.
16610 * rootcontext.cs: Provide better information about the location of
16611 failure when CreateType fails.
16613 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16615 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16618 * expression.cs (Binary::CheckShiftArguments): Add missing type
16620 (Binary::ResolveOperator): Add type to the logical and and logical
16621 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16624 (Binary::DoNumericPromotions): In the case where either argument
16625 is ulong (and most signed types combined with ulong cause an
16626 error) perform implicit integer constant conversions as well.
16628 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16630 * expression.cs (UserImplicitCast): Method should always be
16632 (Invocation::BetterConversion): Simplified test for IntLiteral.
16634 (Expression::ImplicitNumericConversion): Split this routine out.
16635 Put the code that performs implicit constant integer conversions
16638 (Expression::Resolve): Become a wrapper around DoResolve so we can
16639 check eclass and type being set after resolve.
16641 (Invocation::Badness): Remove this dead function
16643 (Binary::ResolveOperator): Do not compute the expensive argumnets
16644 unless we have a union for it.
16646 (Probe::Emit): Is needs to do an isinst and then
16647 compare against null.
16649 (::CanConvert): Added Location argument. If the Location argument
16650 is null (Location.Null), then we do not report errors. This is
16651 used by the `probe' mechanism of the Explicit conversion. We do
16652 not want to generate an error for something that the user
16653 explicitly requested to be casted. But the pipeline for an
16654 explicit cast first tests for potential implicit casts.
16656 So for now, if the Location is null, it means `Probe only' to
16657 avoid adding another argument. Might have to revise this
16660 (ClassCast): New class used to type cast objects into arbitrary
16661 classes (used in Explicit Reference Conversions).
16663 Implement `as' as well.
16665 Reverted all the patches from Ravi below: they were broken:
16667 * The use of `level' as a mechanism to stop recursive
16668 invocations is wrong. That was there just to catch the
16669 bug with a strack trace but not as a way of addressing
16672 To fix the problem we have to *understand* what is going
16673 on and the interactions and come up with a plan, not
16674 just get things going.
16676 * The use of the type conversion cache that I proposed
16677 last night had an open topic: How does this work across
16678 protection domains. A user defined conversion might not
16679 be public in the location where we are applying the
16680 conversion, a different conversion might be selected
16681 (ie, private A->B (better) but public B->A (worse),
16682 inside A, A->B applies, but outside it, B->A will
16685 * On top of that (ie, even if the above is solved),
16686 conversions in a cache need to be abstract. Ie, `To
16687 convert from an Int to a Short use an OpcodeCast', not
16688 `To convert from an Int to a Short use the OpcodeCast on
16689 the variable 5' (which is what this patch was doing).
16691 2001-09-28 Ravi Pratap <ravi@ximian.com>
16693 * expression.cs (Invocation::ConversionExists): Re-write to use
16694 the conversion cache
16696 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16697 cache all conversions done, not just user-defined ones.
16699 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16700 to determine if a conversion exists instead of acutually trying to
16701 perform the conversion. It's faster too.
16703 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16704 and only then attempt the implicit conversion.
16706 2001-09-28 Ravi Pratap <ravi@ximian.com>
16708 * expression.cs (ConvertImplicit): Use a cache for conversions
16709 already found. Check level of recursion and bail out if necessary.
16711 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16713 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16714 Export standard methods that we expect for string operations.
16716 * statement.cs (Block::UsageWarning): Track usage of variables and
16717 report the errors for not used variables.
16719 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16722 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16724 * codegen.cs: remove unnneded code
16726 * expression.cs: Removed BuiltinTypeAccess class
16728 Fix the order in which implicit conversions are
16731 The previous fixed dropped support for boxed conversions (adding a
16732 test to the test suite now)
16734 (UserImplicitCast::CanConvert): Remove test for source being null,
16735 that code is broken. We should not feed a null to begin with, if
16736 we do, then we should track the bug where the problem originates
16737 and not try to cover it up here.
16739 Return a resolved expression of type UserImplicitCast on success
16740 rather than true/false. Ravi: this is what I was talking about,
16741 the pattern is to use a static method as a "constructor" for
16744 Also, do not create arguments until the very last minute,
16745 otherwise we always create the arguments even for lookups that
16746 will never be performed.
16748 (UserImplicitCast::Resolve): Eliminate, objects of type
16749 UserImplicitCast are born in a fully resolved state.
16751 * typemanager.cs (InitCoreTypes): Init also value_type
16752 (System.ValueType).
16754 * expression.cs (Cast::Resolve): First resolve the child expression.
16756 (LValue): Add new method AddressOf to be used by
16759 Change the argument of Store to take an EmitContext instead of an
16760 ILGenerator, because things like FieldExpr need to be able to call
16761 their children expression to generate the instance code.
16763 (Expression::Error, Expression::Warning): Sugar functions for
16766 (Expression::MemberLookup): Accept a TypeContainer instead of a
16767 Report as the first argument.
16769 (Expression::ResolvePrimary): Killed. I still want to improve
16770 this as currently the code is just not right.
16772 (Expression::ResolveMemberAccess): Simplify, but it is still
16775 (Unary::Resolve): Catch errors in AddressOf operators.
16777 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16778 index to a byte for the short-version, or the compiler will choose
16779 the wrong Emit call, which generates the wrong data.
16781 (ParameterReference::Emit, ::Store): same.
16783 (FieldExpr::AddressOf): Implement.
16785 * typemanager.cs: TypeManager: made public variable instead of
16788 * driver.cs: document --fatal.
16790 * report.cs (ErrorMessage, WarningMessage): new names for the old
16791 Error and Warning classes.
16793 * cs-parser.jay (member_access): Turn built-in access to types
16794 into a normal simplename
16796 2001-09-27 Ravi Pratap <ravi@ximian.com>
16798 * expression.cs (Invocation::BetterConversion): Fix to cope
16799 with q being null, since this was introducing a bug.
16801 * expression.cs (ConvertImplicit): Do built-in conversions first.
16803 2001-09-27 Ravi Pratap <ravi@ximian.com>
16805 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16807 2001-09-27 Ravi Pratap <ravi@ximian.com>
16809 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16810 I had introduced long ago (what's new ?).
16812 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16813 the work of all the checking.
16814 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16815 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16817 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16818 that is the right way.
16820 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16821 overloading resolution. Use everywhere instead of cutting and pasting code.
16823 (Binary::ResolveOperator): Use MakeUnionSet.
16825 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16826 we have to convert to bool types. Not complete yet.
16828 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16830 * typemanager.cs (TypeManager::CSharpName): support ushort.
16832 * expression.cs (Expression::TryImplicitIntConversion): Attempts
16833 to provide an expression that performsn an implicit constant int
16834 conversion (section 6.1.6).
16835 (Expression::ConvertImplicitRequired): Reworked to include
16836 implicit constant expression conversions.
16838 (Expression::ConvertNumericExplicit): Finished.
16840 (Invocation::Emit): If InstanceExpression is null, then it means
16841 that we perform a call on this.
16843 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16845 * expression.cs (Unary::Emit): Remove some dead code.
16846 (Probe): Implement Resolve and Emit for `is'.
16847 (Expression::ConvertImplicitRequired): Attempt to do constant
16848 expression conversions here. Maybe should be moved to
16849 ConvertImplicit, but I am not sure.
16850 (Expression::ImplicitLongConstantConversionPossible,
16851 Expression::ImplicitIntConstantConversionPossible): New functions
16852 that tell whether is it possible to apply an implicit constant
16853 expression conversion.
16855 (ConvertNumericExplicit): Started work on explicit numeric
16858 * cs-parser.jay: Update operator constants.
16860 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
16861 (Parameters::GetSignature): Hook up VerifyArgs here.
16862 (Parameters::VerifyArgs): Verifies that no two arguments have the
16865 * class.cs (Operator): Update the operator names to reflect the
16866 ones that the spec expects (as we are just stringizing the
16869 * expression.cs (Unary::ResolveOperator): Fix bug: Use
16870 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
16871 previous usage did only work for our methods.
16872 (Expression::ConvertImplicit): Handle decimal implicit numeric
16873 conversions as well.
16874 (Expression::InternalTypeConstructor): Used to invoke constructors
16875 on internal types for default promotions.
16877 (Unary::Emit): Implement special handling for the pre/post
16878 increment/decrement for overloaded operators, as they need to have
16879 the same semantics as the other operators.
16881 (Binary::ResolveOperator): ditto.
16882 (Invocation::ConversionExists): ditto.
16883 (UserImplicitCast::Resolve): ditto.
16885 2001-09-26 Ravi Pratap <ravi@ximian.com>
16887 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
16888 operator, return after emitting body. Regression tests pass again !
16890 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
16891 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
16892 (Invocation::OverloadResolve): Ditto.
16893 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
16895 * everywhere : update calls to the above methods accordingly.
16897 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16899 * assign.cs (Assign): Make it inherit from ExpressionStatement.
16901 * expression.cs (ExpressionStatement): New base class used for
16902 expressions that can appear in statements, so that we can provide
16903 an alternate path to generate expression that do not leave a value
16906 (Expression::Emit, and all the derivatives): We no longer return
16907 whether a value is left on the stack or not. Every expression
16908 after being emitted leaves a single value on the stack.
16910 * codegen.cs (EmitContext::EmitStatementExpression): Use the
16911 facilties of ExpressionStatement if possible.
16913 * cs-parser.jay: Update statement_expression.
16915 2001-09-25 Miguel de Icaza <miguel@ximian.com>
16917 * driver.cs: Change the wording of message
16919 2001-09-25 Ravi Pratap <ravi@ximian.com>
16921 * expression.cs (Binary::ResolveOperator): Had forgottten to set
16922 the type of the expression to the return type of the method if
16923 we have an overloaded operator match ! The regression tests pass again !
16924 (Unary::ResolveOperator): Ditto.
16926 * expression.cs (Invocation::ConversionExists): Correct the member lookup
16927 to find "op_Implicit", not "implicit" ;-)
16928 (UserImplicitCast): New class to take care of user-defined implicit conversions.
16929 (ConvertImplicit, ForceConversion): Take TypeContainer argument
16931 * everywhere : Correct calls to the above accordingly.
16933 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
16934 (ConvertImplicit): Do user-defined conversion if it exists.
16936 2001-09-24 Miguel de Icaza <miguel@ximian.com>
16938 * assign.cs: track location.
16939 (Resolve): Use implicit conversions on assignment.
16941 * literal.cs: Oops. Not good, Emit of short access values should
16942 pass (Bytes) or the wrong argument will be selected.
16944 * expression.cs (Unary::Emit): Emit code for -expr.
16946 (Unary::ResolveOperator): Handle `Substract' for non-constants
16947 (substract from zero from the non-constants).
16948 Deal with Doubles as well.
16950 (Expression::ConvertImplicitRequired): New routine that reports an
16951 error if no implicit conversion exists.
16953 (Invocation::OverloadResolve): Store the converted implicit
16954 expressions if we make them
16956 2001-09-24 Ravi Pratap <ravi@ximian.com>
16958 * class.cs (ConstructorInitializer): Take a Location argument.
16959 (ConstructorBaseInitializer): Same here.
16960 (ConstructorThisInitializer): Same here.
16962 * cs-parser.jay : Update all calls accordingly.
16964 * expression.cs (Unary, Binary, New): Take location argument.
16965 Update accordingly everywhere.
16967 * cs-parser.jay : Update all calls to the above to take a location
16970 * class.cs : Ditto.
16972 2001-09-24 Ravi Pratap <ravi@ximian.com>
16974 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
16975 (Invocation::BetterConversion): Same here
16976 (Invocation::ConversionExists): Ditto.
16978 (Invocation::ConversionExists): Implement.
16980 2001-09-22 Ravi Pratap <ravi@ximian.com>
16982 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
16983 Also take an additional TypeContainer argument.
16985 * All over : Pass in TypeContainer as argument to OverloadResolve.
16987 * typemanager.cs (CSharpName): Update to check for the string type and return
16990 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
16993 2001-09-21 Ravi Pratap <ravi@ximian.com>
16995 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
16996 (Invocation::BetterFunction): Implement.
16997 (Invocation::BetterConversion): Implement.
16998 (Invocation::ConversionExists): Skeleton, no implementation yet.
17000 Okay, things work fine !
17002 2001-09-21 Miguel de Icaza <miguel@ximian.com>
17004 * typemanager.cs: declare and load enum_type, delegate_type and
17007 * expression.cs (Expression::Emit): Now emit returns a value that
17008 tells whether a value is left on the stack or not. This strategy
17009 might be reveted tomorrow with a mechanism that would address
17010 multiple assignments.
17011 (Expression::report118): Utility routine to report mismatches on
17014 (Unary::Report23): Report impossible type/operator combination
17017 (Unary::IsIncrementableNumber): Whether the type can be
17018 incremented or decremented with add.
17019 (Unary::ResolveOperator): Also allow enumerations to be bitwise
17021 (Unary::ResolveOperator): Implement ++, !, ~,
17023 (Invocation::Emit): Deal with new Emit convetion.
17025 * All Expression derivatives: Updated their Emit method to return
17026 whether they leave values on the stack or not.
17028 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
17029 stack for expressions that are statements.
17031 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17033 * expression.cs (LValue): New interface. Must be implemented by
17035 (LocalVariableReference, ParameterReference, FieldExpr): Implement
17038 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
17039 interface for generating code, simplifies the code.
17041 2001-09-20 Ravi Pratap <ravi@ximian.com>
17043 * expression.cs (everywhere): Comment out return statements in ::Resolve
17044 methods to avoid the warnings.
17046 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17048 * driver.cs (parse): Report error 2001 if we can not open the
17051 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
17054 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
17057 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
17058 otherwise nested blocks end up with the same index.
17060 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
17062 * expression.cs: Instead of having FIXMEs in the Resolve
17063 functions, throw exceptions so it is obvious that we are facing a
17066 * cs-parser.jay (invocation_expression): Pass Location information.
17068 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
17069 Use a basename for those routines because .NET does not like paths
17072 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
17075 2001-09-19 Miguel de Icaza <miguel@ximian.com>
17077 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
17078 are loading the correct data types (throws an exception if not).
17079 (TypeManager::InitCoreTypes): Use CoreLookupType
17081 * expression.cs (Unary::ResolveOperator): return the child
17082 expression for expressions which are just +expr.
17083 (Unary::ResolveOperator): Return negative literals for -LITERAL
17084 expressions (otherwise they are Unary {Literal}).
17085 (Invocation::Badness): Take into account `Implicit constant
17086 expression conversions'.
17088 * literal.cs (LongLiteral): Implement long literal class.
17089 (IntLiteral): export the `Value' of the intliteral.
17091 2001-09-19 Ravi Pratap <ravi@ximian.com>
17093 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
17095 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
17096 instead of 'Operator'
17098 * expression.cs (Binary::ResolveOperator): Update accordingly.
17099 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
17102 * cs-parser.jay (unary_expression): Update to use the new names.
17104 * gen-treedump.cs (GetUnary): Same here.
17106 * expression.cs (Unary::Resolve): Implement.
17107 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
17108 operators are found instead of making noise ;-)
17109 (Unary::ResolveOperator): New method to do precisely the same thing which
17110 Binary::ResolveOperator does for Binary expressions.
17111 (Unary.method, .Arguments): Add.
17112 (Unary::OperName): Implement.
17113 (Unary::ForceConversion): Copy and Paste !
17115 * class.cs (Operator::Define): Fix a small bug for the case when we have
17118 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
17119 for the inbuilt operators. Only overloading works for now ;-)
17121 2001-09-18 Miguel de Icaza <miguel@ximian.com>
17123 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
17124 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
17126 * expression.cs (This::Emit): Implement.
17127 (This::Resolve): Implement.
17128 (TypeOf:Resolve): Implement.
17129 (Expression::ResolveSimpleName): Add an implicit this to instance
17131 (MemberAccess::Resolve): Deal with Parameters and Fields.
17132 Bind instance variable to Field expressions.
17133 (FieldExpr::Instance): New field used to track the expression that
17134 represents the object instance.
17135 (FieldExpr::Resolve): Track potential errors from MemberLookup not
17137 (FieldExpr::Emit): Implement.
17139 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
17140 the last instruction contains a return opcode to avoid generating
17141 the last `ret' instruction (this generates correct code, and it is
17142 nice to pass the peverify output).
17144 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
17145 initializer for static and instance variables.
17146 (Constructor::Emit): Allow initializer to be null in the case of
17147 static constructors. Only emit initializer for instance
17150 (TypeContainer::FindMembers): Return a null array if there are no
17153 Also fix the code for the MemberTypes.Method branch, as it was not
17154 scanning that for operators (or tried to access null variables before).
17156 * assign.cs (Assign::Emit): Handle instance and static fields.
17160 * driver.cs: Stop compilation if there are parse errors.
17162 * cs-parser.jay (constructor_declaration): Provide default base
17163 initializer for non-static constructors.
17164 (constructor_declarator): Do not provide a default base
17165 initializers if none was specified.
17166 Catch the fact that constructors should not have parameters.
17168 * class.cs: Do not emit parent class initializers for static
17169 constructors, that should be flagged as an error.
17171 2001-09-18 Ravi Pratap <ravi@ximian.com>
17173 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
17174 Move back code into TypeContainer::Populate.
17176 2001-09-18 Ravi Pratap <ravi@ximian.com>
17178 * class.cs (TypeContainer::AddConstructor): Fix the check to
17179 compare against Name, not Basename.
17180 (Operator::OpType): Change Plus and Minus to Add and Subtract.
17182 * cs-parser.jay : Update accordingly.
17184 * class.cs (TypeContainer::FindMembers): For the case where we are searching
17185 for methods, don't forget to look into the operators too.
17186 (RegisterMethodBuilder): Helper method to take care of this for
17187 methods, constructors and operators.
17188 (Operator::Define): Completely revamp.
17189 (Operator.OperatorMethod, MethodName): New fields.
17190 (TypeContainer::Populate): Move the registering of builders into
17191 RegisterMethodBuilder.
17192 (Operator::Emit): Re-write.
17194 * expression.cs (Binary::Emit): Comment out code path to emit method
17195 invocation stuff for the case when we have a user defined operator. I am
17196 just not able to get it right !
17198 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17200 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
17203 (Expression::MemberLookup): Provide a version that allows to
17204 specify the MemberTypes and BindingFlags.
17206 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
17207 so it was not fetching variable information from outer blocks.
17209 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
17210 Beforefieldinit as it was buggy.
17212 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
17213 that Ravi put here.
17215 * class.cs (Constructor::Emit): Only emit if block is not null.
17216 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
17217 deal with this by semantically definining it as if the user had
17220 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
17221 constructors as we now "emit" them at a higher level.
17223 (TypeContainer::DefineDefaultConstructor): Used to define the
17224 default constructors if none was provided.
17226 (ConstructorInitializer): Add methods Resolve and Emit.
17228 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
17230 2001-09-17 Ravi Pratap <ravi@ximian.com>
17232 * class.cs (TypeContainer::EmitDefaultConstructor): Register
17233 the default constructor builder with our hashtable for methodbuilders
17236 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
17237 and argument_count is 0 in which case we have a match.
17238 (Binary::ResolveOperator): More null checking and miscellaneous coding
17241 2001-09-17 Ravi Pratap <ravi@ximian.com>
17243 * rootcontext.cs (IsNameSpace): Compare against null.
17245 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
17247 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
17248 and Unary::Operator.
17250 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
17253 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
17254 we have overloaded operators.
17255 (Binary::ResolveOperator): Implement the part which does the operator overload
17258 * class.cs (Operator::Emit): Implement.
17259 (TypeContainer::Emit): Emit the operators we have too.
17261 * expression.cs (Binary::Emit): Update to emit the appropriate code for
17262 the case when we have a user-defined operator.
17264 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17266 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
17268 2001-09-16 Ravi Pratap <ravi@ximian.com>
17270 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
17271 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
17272 (Constructor::Emit): Implement.
17273 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
17274 if we have no work to do.
17275 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
17278 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
17279 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
17281 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
17284 2001-09-15 Ravi Pratap <ravi@ximian.com>
17286 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
17288 (Tree::RecordNamespace): Method to do what the name says ;-)
17289 (Tree::Namespaces): Property to get at the namespaces hashtable.
17291 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
17294 * rootcontext.cs (IsNamespace): Fixed it :-)
17296 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17298 * class.cs (TypeContainer::FindMembers): Add support for
17300 (MethodCore): New class that encapsulates both the shared aspects
17301 of a Constructor and a Method.
17302 (Method, Constructor): Factored pieces into MethodCore.
17304 * driver.cs: Added --fatal which makes errors throw exceptions.
17305 Load System assembly as well as part of the standard library.
17307 * report.cs: Allow throwing exceptions on errors for debugging.
17309 * modifiers.cs: Do not use `parent', instead use the real type
17310 container to evaluate permission settings.
17312 * class.cs: Put Ravi's patch back in. He is right, and we will
17313 have to cope with the
17315 2001-09-14 Ravi Pratap <ravi@ximian.com>
17317 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
17318 FamORAssem, not FamANDAssem.
17320 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17322 * driver.cs: Added --parse option that only parses its input files
17325 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
17326 incorrect. IsTopLevel is not used to tell whether an object is
17327 root_types or not (that can be achieved by testing this ==
17328 root_types). But to see if this is a top-level *class* (not
17329 necessarly our "toplevel" container).
17331 2001-09-14 Ravi Pratap <ravi@ximian.com>
17333 * enum.cs (Enum::Define): Modify to call the Lookup method on the
17334 parent instead of a direct call to GetType.
17336 2001-09-14 Ravi Pratap <ravi@ximian.com>
17338 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
17339 Modifiers.TypeAttr. This should just be a call to that method.
17341 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
17342 object so that we can determine if we are top-level or not.
17344 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
17347 * enum.cs (Enum::Define): Ditto.
17349 * modifiers.cs (FieldAttr): Re-write.
17351 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
17352 (TypeContainer::HaveStaticConstructor): New property to provide access
17353 to precisely that info.
17355 * modifiers.cs (MethodAttr): Re-write.
17356 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
17358 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
17359 of top-level types as claimed.
17361 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17363 * expression.cs (MemberLookup): Fruitless attempt to lookup
17364 constructors. Maybe I need to emit default constructors? That
17365 might be it (currently .NET emits this for me automatically).
17366 (Invocation::OverloadResolve): Cope with Arguments == null.
17367 (Invocation::EmitArguments): new function, shared by the new
17368 constructor and us.
17369 (Invocation::Emit): Handle static and instance methods. Emit
17370 proper call instruction for virtual or non-virtual invocations.
17371 (New::Emit): Implement.
17372 (New::Resolve): Implement.
17373 (MemberAccess:Resolve): Implement.
17374 (MethodGroupExpr::InstanceExpression): used conforming to the spec
17375 to track instances.
17376 (FieldExpr::Resolve): Set type.
17378 * support.cs: Handle empty arguments.
17380 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
17381 SimpleLookup): Auxiliary routines to help parse a qualifier
17384 Update qualifier_identifier rule.
17386 * codegen.cs: Removed debugging messages.
17388 * class.cs: Make this a global thing, this acts just as a "key" to
17389 objects that we might have around.
17391 (Populate): Only initialize method_builders_to_methods once.
17393 * expression.cs (PropertyExpr): Initialize type from the
17396 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
17397 Resolve pattern. Attempt to implicitly convert value to boolean.
17400 * expression.cs: Set the type for the int32/int32 argument case.
17401 (Binary::ResolveOperator): Set the return type to boolean for
17402 comparission operators
17404 * typemanager.cs: Remove debugging print code.
17406 (Invocation::Resolve): resolve type.
17408 * class.cs: Allocate a MemberInfo of the correct size, as the code
17409 elsewhere depends on the test to reflect the correct contents.
17411 (Method::) Keep track of parameters, due to System.Reflection holes
17413 (TypeContainer::Populate): Keep track of MethodBuilders to Method
17416 (TypeContainer::FindMembers): Use ArrayList and then copy an array
17417 of the exact size and return that.
17419 (Class::LookupMethodByBuilder): New function that maps
17420 MethodBuilders to its methods. Required to locate the information
17421 on methods because System.Reflection bit us again.
17423 * support.cs: New file, contains an interface ParameterData and
17424 two implementations: ReflectionParameters and InternalParameters
17425 used to access Parameter information. We will need to grow this
17428 * expression.cs (Invocation::GetParameterData): implement a cache
17429 and a wrapper around the ParameterData creation for methods.
17430 (Invocation::OverloadResolve): Use new code.
17432 2001-09-13 Ravi Pratap <ravi@ximian.com>
17434 * class.cs (TypeContainer::EmitField): Remove and move into
17435 (Field::Define): here and modify accordingly.
17436 (Field.FieldBuilder): New member.
17437 (TypeContainer::Populate): Update accordingly.
17438 (TypeContainer::FindMembers): Implement.
17440 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17442 * statement.cs: (VariableInfo::VariableType): New field to be
17443 initialized with the full type once it is resolved.
17445 2001-09-12 Miguel de Icaza <miguel@ximian.com>
17447 * parameter.cs (GetParameterInfo): Use a type cache to compute
17448 things only once, and to reuse this information
17450 * expression.cs (LocalVariableReference::Emit): Implement.
17451 (OpcodeCast::Emit): fix.
17453 (ParameterReference::Resolve): Implement.
17454 (ParameterReference::Emit): Implement.
17456 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
17457 that are expressions need to stay as Expressions.
17459 * typemanager.cs (CSharpName): Returns the C# name of a type if
17462 * expression.cs (Expression::ConvertImplicit): New function that
17463 implements implicit type conversions.
17465 (Expression::ImplicitReferenceConversion): Implements implicit
17466 reference conversions.
17468 (EmptyCast): New type for transparent casts.
17470 (OpcodeCast): New type for casts of types that are performed with
17471 a sequence of bytecodes.
17473 (BoxedCast): New type used for casting value types into reference
17474 types. Emits a box opcode.
17476 (Binary::DoNumericPromotions): Implements numeric promotions of
17477 and computation of the Binary::Type.
17479 (Binary::EmitBranchable): Optimization.
17481 (Binary::Emit): Implement code emission for expressions.
17483 * typemanager.cs (TypeManager): Added two new core types: sbyte
17486 2001-09-12 Ravi Pratap <ravi@ximian.com>
17488 * class.cs (TypeContainer::FindMembers): Method which does exactly
17489 what Type.FindMembers does, only we don't have to use reflection. No
17490 implementation yet.
17492 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17493 typecontainer objects as we need to get at them.
17494 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17496 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17497 typecontainer object.
17499 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17500 of just a Report object.
17502 2001-09-11 Ravi Pratap <ravi@ximian.com>
17504 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17506 (TypeContainer::Populate): Now define the delegates of the type too.
17507 (TypeContainer.Delegates): Property to access the list of delegates defined
17510 * delegates.cs (Delegate::Define): Implement partially.
17512 * modifiers.cs (TypeAttr): Handle more flags.
17514 2001-09-11 Ravi Pratap <ravi@ximian.com>
17516 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17518 (Operator::Define): Re-write logic to get types by using the LookupType method
17519 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17520 (Indexer::Define): Ditto.
17521 (Event::Define): Ditto.
17522 (Property::Define): Ditto.
17524 2001-09-10 Ravi Pratap <ravi@ximian.com>
17526 * class.cs (TypeContainer::Populate): Now define operators too.
17527 (TypeContainer.Operators): New property to access the list of operators
17529 (Operator.OperatorMethodBuilder): New member to hold the method builder
17530 for the operator we are defining.
17531 (Operator::Define): Implement.
17533 2001-09-10 Ravi Pratap <ravi@ximian.com>
17535 * class.cs (Event::Define): Make the prefixes of the accessor methods
17536 addOn_ and removeOn_
17538 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17539 of the location being passed in too. Ideally, this should go later since all
17540 error reporting should be done through the Report object.
17542 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17543 (Populate): Iterate thru the indexers we have and define them too.
17544 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17545 for the get and set accessors.
17546 (Indexer::Define): Implement.
17548 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17550 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17551 my previous implementation, did not work.
17553 * typemanager.cs: Add a couple of missing types (the longs).
17555 * literal.cs: Use TypeManager.bool_type instead of getting it.
17557 * expression.cs (EventExpr): New kind of expressions.
17558 (Expressio::ExprClassFromMemberInfo): finish
17560 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17562 * assign.cs: Emit stores to static fields differently.
17564 2001-09-08 Ravi Pratap <ravi@ximian.com>
17566 * Merge in changes and adjust code to tackle conflicts. Backed out my
17567 code in Assign::Resolve ;-)
17569 2001-09-08 Ravi Pratap <ravi@ximian.com>
17571 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17572 instead Report.Error and also pass in the location.
17573 (CSharpParser::Lexer): New readonly property to return the reference
17574 to the Tokenizer object.
17575 (declare_local_variables): Use Report.Error with location instead of plain
17579 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17580 (Operator.CheckBinaryOperator): Ditto.
17582 * cs-parser.jay (operator_declarator): Update accordingly.
17584 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17585 (CheckBinaryOperator): Same here.
17587 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17588 on the name without any prefixes of namespace names etc. This is because we
17589 already might have something already fully qualified like
17590 'System.Console.WriteLine'
17592 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17594 2001-09-07 Ravi Pratap <ravi@ximian.com>
17596 * cs-tokenizer.cs (location): Return a string which also contains
17599 * expression.cs (ElementAccess): New class for expressions of the
17600 type 'element access.'
17601 (BaseAccess): New class for expressions of the type 'base access.'
17602 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17605 * cs-parser.jay (element_access): Implement action.
17606 (base_access): Implement actions.
17607 (checked_expression, unchecked_expression): Implement.
17609 * cs-parser.jay (local_variable_type): Correct and implement.
17610 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17612 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17614 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17615 name and the specifiers.
17617 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17619 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17620 making them all public ;-)
17622 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17625 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17627 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17629 (FieldExpr, PropertyExprs): New resolved expressions.
17630 (SimpleName::MemberStaticCheck): Perform static checks for access
17631 to non-static fields on static methods. Maybe this should be
17632 generalized for MemberAccesses.
17633 (SimpleName::ResolveSimpleName): More work on simple name
17636 * cs-parser.jay (primary_expression/qualified_identifier): track
17637 the parameter index.
17639 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17640 (EmitContext::EmitBoolExpression): Chain to expression generation
17641 instead of temporary hack.
17642 (::EmitStatementExpression): Put generic expression code generation.
17644 * assign.cs (Assign::Emit): Implement variable assignments to
17645 local variables, parameters and fields.
17647 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17649 * statement.cs (Block::GetVariableInfo): New method, returns the
17650 VariableInfo for a variable name in a block.
17651 (Block::GetVariableType): Implement in terms of GetVariableInfo
17653 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17654 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17656 2001-09-06 Ravi Pratap <ravi@ximian.com>
17658 * cs-parser.jay (operator_declaration): Continue on my quest : update
17659 to take attributes argument.
17660 (event_declaration): Ditto.
17661 (enum_declaration): Ditto.
17662 (indexer_declaration): Ditto.
17664 * class.cs (Operator::Operator): Update constructor accordingly.
17665 (Event::Event): Ditto.
17667 * delegate.cs (Delegate::Delegate): Same here.
17669 * enum.cs (Enum::Enum): Same here.
17671 2001-09-05 Ravi Pratap <ravi@ximian.com>
17673 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17675 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17677 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17678 being passed around as an arraylist.
17679 (Attributes::AddAttribute): Method to add attribute sections.
17681 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17682 (struct_declaration): Update accordingly.
17683 (constant_declaration): Update.
17684 (field_declaration): Update.
17685 (method_header): Update.
17686 (fixed_parameter): Update.
17687 (parameter_array): Ditto.
17688 (property_declaration): Ditto.
17689 (destructor_declaration): Ditto.
17691 * class.cs (Struct::Struct): Update constructors accordingly.
17692 (Class::Class): Ditto.
17693 (Field::Field): Ditto.
17694 (Method::Method): Ditto.
17695 (Property::Property): Ditto.
17696 (TypeContainer::OptAttribute): update property's return type.
17698 * interface.cs (Interface.opt_attributes): New member.
17699 (Interface::Interface): Update to take the extra Attributes argument.
17701 * parameter.cs (Parameter::Parameter): Ditto.
17703 * constant.cs (Constant::Constant): Ditto.
17705 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17706 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17707 the attributes as a parameter.
17708 (InterfaceProperty): Update constructor call.
17709 (InterfaceEvent): Ditto.
17710 (InterfaceMethod): Ditto.
17711 (InterfaceIndexer): Ditto.
17713 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17714 pass the attributes too.
17715 (interface_event_declaration): Ditto.
17716 (interface_property_declaration): Ditto.
17717 (interface_method_declaration): Ditto.
17718 (interface_declaration): Ditto.
17720 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17722 * class.cs (Method::Define): Track the "static Main" definition to
17723 create an entry point.
17725 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17726 EntryPoint if we find it.
17728 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17729 (EmitContext::ig): Make this variable public.
17731 * driver.cs: Make the default output file be the first file name
17732 with the .exe extension.
17734 Detect empty compilations
17736 Handle various kinds of output targets. Handle --target and
17737 rename -t to --dumper.
17739 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17740 methods inherited from Expression return now an Expression. This
17741 will is used during the tree rewriting as we resolve them during
17744 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17745 the spec. Missing entirely is the information about
17746 accessability of elements of it.
17748 (Expression::ExprClassFromMemberInfo): New constructor for
17749 Expressions that creates a fully initialized Expression based on
17750 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17753 (Invocation::Resolve): Begin implementing resolution of invocations.
17755 * literal.cs (StringLiteral): Implement Emit.
17757 2001-09-05 Ravi Pratap <ravi@ximian.com>
17759 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17762 2001-09-04 Ravi Pratap <ravi@ximian.com>
17764 * cs-parser.jay (attribute_arguments): Implement actions.
17765 (attribute): Fix bug in production. Implement action.
17766 (attribute_list): Implement.
17767 (attribute_target): Implement.
17768 (attribute_target_specifier, opt_target_specifier): Implement
17769 (CheckAttributeTarget): New method to check if the attribute target
17771 (attribute_section): Implement.
17772 (opt_attributes): Implement.
17774 * attribute.cs : New file to handle attributes.
17775 (Attribute): Class to hold attribute info.
17777 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17778 (attribute_section): Modify production to use 2 different rules to
17779 achieve the same thing. 1 s/r conflict down !
17780 Clean out commented, useless, non-reducing dimension_separator rules.
17782 * class.cs (TypeContainer.attributes): New member to hold list
17783 of attributes for a type.
17784 (Struct::Struct): Modify to take one more argument, the attribute list.
17785 (Class::Class): Ditto.
17786 (Field::Field): Ditto.
17787 (Method::Method): Ditto.
17788 (Property::Property): Ditto.
17790 * cs-parser.jay (struct_declaration): Update constructor call to
17791 pass in the attributes too.
17792 (class_declaration): Ditto.
17793 (constant_declaration): Ditto.
17794 (field_declaration): Ditto.
17795 (method_header): Ditto.
17796 (fixed_parameter): Ditto.
17797 (parameter_array): Ditto.
17798 (property_declaration): Ditto.
17800 * constant.cs (Constant::Constant): Update constructor similarly.
17801 Use System.Collections.
17803 * parameter.cs (Parameter::Parameter): Update as above.
17805 2001-09-02 Ravi Pratap <ravi@ximian.com>
17807 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17808 (TypeContainer.delegates): New member to hold list of delegates.
17810 * cs-parser.jay (delegate_declaration): Implement the action correctly
17811 this time as I seem to be on crack ;-)
17813 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17815 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17816 tell whether an identifier represents a namespace.
17818 * expression.cs (NamespaceExpr): A namespace expression, used only
17819 temporarly during expression resolution.
17820 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17821 utility functions to resolve names on expressions.
17823 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17825 * codegen.cs: Add hook for StatementExpressions.
17827 * class.cs: Fix inverted test for static flag in methods.
17829 2001-09-02 Ravi Pratap <ravi@ximian.com>
17831 * class.cs (Operator::CheckUnaryOperator): Correct error number used
17832 to make it coincide with MS' number.
17833 (Operator::CheckBinaryOperator): Ditto.
17835 * ../errors/errors.txt : Remove error numbers added earlier.
17837 * ../errors/cs1019.cs : Test case for error # 1019
17839 * ../errros/cs1020.cs : Test case for error # 1020
17841 * cs-parser.jay : Clean out commented cruft.
17842 (dimension_separators, dimension_separator): Comment out. Ostensibly not
17843 used anywhere - non-reducing rule.
17844 (namespace_declarations): Non-reducing rule - comment out.
17846 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
17847 with TypeContainer::AddEnum.
17849 * delegate.cs : New file for delegate handling classes.
17850 (Delegate): Class for declaring delegates.
17852 * makefile : Update.
17854 * cs-parser.jay (delegate_declaration): Implement.
17856 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
17858 * class.cs (Event::Define): Implement.
17859 (Event.EventBuilder): New member.
17861 * class.cs (TypeContainer::Populate): Update to define all enums and events
17863 (Events): New property for the events arraylist we hold. Shouldn't we move to using
17864 readonly fields for all these cases ?
17866 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17868 * class.cs (Property): Revamp to use the convention of making fields readonly.
17869 Accordingly modify code elsewhere.
17871 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
17872 the Define method of the Property class.
17874 * class.cs : Clean up applied patch and update references to variables etc. Fix
17876 (TypeContainer::Populate): Update to define all the properties we have. Also
17877 define all enumerations.
17879 * enum.cs (Define): Implement.
17881 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17883 * cs-parser.jay (overloadable_operator): The semantic value is an
17884 enum of the Operator class.
17885 (operator_declarator): Implement actions.
17886 (operator_declaration): Implement.
17888 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
17889 validity of definitions.
17890 (Operator::CheckBinaryOperator): Static method to check for binary operators
17891 (TypeContainer::AddOperator): New method to add an operator to a type.
17893 * cs-parser.jay (indexer_declaration): Added line to actually call the
17894 AddIndexer method so it gets added ;-)
17896 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
17897 already taken care of by the MS compiler ?
17899 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17901 * class.cs (Operator): New class for operator declarations.
17902 (Operator::OpType): Enum for the various operators.
17904 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17906 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
17907 ostensibly handle this in semantic analysis.
17909 * cs-parser.jay (general_catch_clause): Comment out
17910 (specific_catch_clauses, specific_catch_clause): Ditto.
17911 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
17912 (catch_args, opt_catch_args): New productions.
17913 (catch_clause): Rewrite to use the new productions above
17914 (catch_clauses): Modify accordingly.
17915 (opt_catch_clauses): New production to use in try_statement
17916 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
17917 and re-write the code in the actions to extract the specific and
17918 general catch clauses by being a little smart ;-)
17920 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
17921 Hooray, try and catch statements parse fine !
17923 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17925 * statement.cs (Block::GetVariableType): Fix logic to extract the type
17926 string from the hashtable of variables.
17928 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
17929 I end up making that mistake ;-)
17930 (catch_clauses): Fixed gross error which made Key and Value of the
17931 DictionaryEntry the same : $1 !!
17933 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17935 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
17937 * cs-parser.jay (event_declaration): Correct to remove the semicolon
17938 when the add and remove accessors are specified.
17940 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17942 * cs-parser.jay (IndexerDeclaration): New helper class to hold
17943 information about indexer_declarator.
17944 (indexer_declarator): Implement actions.
17945 (parsing_indexer): New local boolean used to keep track of whether
17946 we are parsing indexers or properties. This is necessary because
17947 implicit_parameters come into picture even for the get accessor in the
17948 case of an indexer.
17949 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
17951 * class.cs (Indexer): New class for indexer declarations.
17952 (TypeContainer::AddIndexer): New method to add an indexer to a type.
17953 (TypeContainer::indexers): New member to hold list of indexers for the
17956 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17958 * cs-parser.jay (add_accessor_declaration): Implement action.
17959 (remove_accessor_declaration): Implement action.
17960 (event_accessors_declaration): Implement
17961 (variable_declarators): swap statements for first rule - trivial.
17963 * class.cs (Event): New class to hold information about event
17965 (TypeContainer::AddEvent): New method to add an event to a type
17966 (TypeContainer::events): New member to hold list of events.
17968 * cs-parser.jay (event_declaration): Implement actions.
17970 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17972 * cs-parser.jay (dim_separators): Implement. Make it a string
17973 concatenating all the commas together, just as they appear.
17974 (opt_dim_separators): Modify accordingly
17975 (rank_specifiers): Update accordingly. Basically do the same
17976 thing - instead, collect the brackets here.
17977 (opt_rank_sepcifiers): Modify accordingly.
17978 (array_type): Modify to actually return the complete type string
17979 instead of ignoring the rank_specifiers.
17980 (expression_list): Implement to collect the expressions
17981 (variable_initializer): Implement. We make it a list of expressions
17982 essentially so that we can handle the array_initializer case neatly too.
17983 (variable_initializer_list): Implement.
17984 (array_initializer): Make it a list of variable_initializers
17985 (opt_array_initializer): Modify accordingly.
17987 * expression.cs (New::NType): Add enumeration to help us
17988 keep track of whether we have an object/delegate creation
17989 or an array creation.
17990 (New:NewType, New::Rank, New::Indices, New::Initializers): New
17991 members to hold data about array creation.
17992 (New:New): Modify to update NewType
17993 (New:New): New Overloaded contructor for the array creation
17996 * cs-parser.jay (array_creation_expression): Implement to call
17997 the overloaded New constructor.
17999 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
18001 * class.cs (TypeContainer::Constructors): Return member
18002 constructors instead of returning null.
18004 2001-08-26 Miguel de Icaza <miguel@ximian.com>
18006 * typemanager.cs (InitCoreTypes): Initialize the various core
18007 types after we have populated the type manager with the user
18008 defined types (this distinction will be important later while
18009 compiling corlib.dll)
18011 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
18012 on Expression Classification. Now all expressions have a method
18013 `Resolve' and a method `Emit'.
18015 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
18016 generation from working. Also add some temporary debugging
18019 2001-08-24 Miguel de Icaza <miguel@ximian.com>
18021 * codegen.cs: Lots of code generation pieces. This is only the
18022 beginning, will continue tomorrow with more touches of polish. We
18023 handle the fundamentals of if, while, do, for, return. Others are
18024 trickier and I need to start working on invocations soon.
18026 * gen-treedump.cs: Bug fix, use s.Increment here instead of
18029 * codegen.cs (EmitContext): New struct, used during code
18030 emission to keep a context. Most of the code generation will be
18033 * cs-parser.jay: Add embedded blocks to the list of statements of
18034 this block. So code generation proceeds in a top down fashion.
18036 2001-08-23 Miguel de Icaza <miguel@ximian.com>
18038 * statement.cs: Add support for multiple child blocks.
18040 2001-08-22 Miguel de Icaza <miguel@ximian.com>
18042 * codegen.cs (EmitCode): New function, will emit the code for a
18043 Block of code given a TypeContainer and its ILGenerator.
18045 * statement.cs (Block): Standard public readonly optimization.
18046 (Block::Block constructors): Link children.
18047 (Block::Child): Child Linker.
18048 (Block::EmitVariables): Emits IL variable declarations.
18050 * class.cs: Drop support for MethodGroups here, delay until
18052 (Method::): Applied the same simplification that I did before, and
18053 move from Properties to public readonly fields.
18054 (Method::ParameterTypes): Returns the parameter types for the
18055 function, and implements a cache that will be useful later when I
18056 do error checking and the semantic analysis on the methods is
18058 (Constructor::GetCallingConvention): Renamed from CallingConvetion
18059 and made a method, optional argument tells whether this is a class
18060 or a structure to apply the `has-this' bit.
18061 (Method::GetCallingConvention): Implement, returns the calling
18063 (Method::Define): Defines the type, a second pass is performed
18064 later to populate the methods.
18066 (Constructor::ParameterTypes): implement a cache similar to the
18067 one on Method::ParameterTypes, useful later when we do semantic
18070 (TypeContainer::EmitMethod): New method. Emits methods.
18072 * expression.cs: Removed MethodGroup class from here.
18074 * parameter.cs (Parameters::GetCallingConvention): new method.
18076 2001-08-21 Miguel de Icaza <miguel@ximian.com>
18078 * class.cs (TypeContainer::Populate): Drop RootContext from the
18081 (Constructor::CallingConvention): Returns the calling convention.
18082 (Constructor::ParameterTypes): Returns the constructor parameter
18085 (TypeContainer::AddConstructor): Keep track of default constructor
18086 and the default static constructor.
18088 (Constructor::) Another class that starts using `public readonly'
18089 instead of properties.
18091 (Constructor::IsDefault): Whether this is a default constructor.
18093 (Field::) use readonly public fields instead of properties also.
18095 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
18096 track of static constructors; If none is used, turn on
18097 BeforeFieldInit in the TypeAttributes.
18099 * cs-parser.jay (opt_argument_list): now the return can be null
18100 for the cases where there are no arguments.
18102 (constructor_declarator): If there is no implicit `base' or
18103 `this', then invoke the default parent constructor.
18105 * modifiers.cs (MethodAttr): New static function maps a set of
18106 modifiers flags into a MethodAttributes enum
18107 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
18108 MethodAttr, TypeAttr to represent the various mappings where the
18109 modifiers are used.
18110 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
18112 2001-08-19 Miguel de Icaza <miguel@ximian.com>
18114 * parameter.cs (GetParameterInfo): Fix bug where there would be no
18117 * interface.cs (PopulateIndexer): Implemented the code generator
18118 for interface indexers.
18120 2001-08-17 Miguel de Icaza <miguel@ximian.com>
18122 * interface.cs (InterfaceMemberBase): Now we track the new status
18125 (PopulateProperty): Implement property population. Woohoo! Got
18126 Methods and Properties going today.
18128 Removed all the properties for interfaces, and replaced them with
18129 `public readonly' fields.
18131 2001-08-16 Miguel de Icaza <miguel@ximian.com>
18133 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
18134 initialize their hashtables/arraylists only when they are needed
18135 instead of doing this always.
18137 * parameter.cs: Handle refs and out parameters.
18139 * cs-parser.jay: Use an ArrayList to construct the arguments
18140 instead of the ParameterCollection, and then cast that to a
18143 * parameter.cs: Drop the use of ParameterCollection and use
18144 instead arrays of Parameters.
18146 (GetParameterInfo): Use the Type, not the Name when resolving
18149 2001-08-13 Miguel de Icaza <miguel@ximian.com>
18151 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
18152 and instead use public readonly fields.
18154 * class.cs: Put back walking code for type containers.
18156 2001-08-11 Miguel de Icaza <miguel@ximian.com>
18158 * class.cs (MakeConstant): Code to define constants.
18160 * rootcontext.cs (LookupType): New function. Used to locate types
18163 2001-08-08 Miguel de Icaza <miguel@ximian.com>
18165 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
18166 this System.Reflection code is. Kudos to Microsoft
18168 * typemanager.cs: Implement a type cache and avoid loading all
18169 types at boot time. Wrap in LookupType the internals. This made
18170 the compiler so much faster. Wow. I rule!
18172 * driver.cs: Make sure we always load mscorlib first (for
18173 debugging purposes, nothing really important).
18175 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
18176 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
18178 * rootcontext.cs: Lookup types on their namespace; Lookup types
18179 on namespaces that have been imported using the `using' keyword.
18181 * class.cs (TypeContainer::TypeAttr): Virtualize.
18182 (Class::TypeAttr): Return attributes suitable for this bad boy.
18183 (Struct::TypeAttr): ditto.
18184 Handle nested classes.
18185 (TypeContainer::) Remove all the type visiting code, it is now
18186 replaced with the rootcontext.cs code
18188 * rootcontext.cs (GetClassBases): Added support for structs.
18190 2001-08-06 Miguel de Icaza <miguel@ximian.com>
18192 * interface.cs, statement.cs, class.cs, parameter.cs,
18193 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
18194 Drop use of TypeRefs, and use strings instead.
18196 2001-08-04 Miguel de Icaza <miguel@ximian.com>
18200 * class.cs (Struct::Struct): set the SEALED flags after
18201 checking the modifiers.
18202 (TypeContainer::TypeAttr): new property, returns the
18203 TypeAttributes for a class.
18205 * cs-parser.jay (type_list): Oops, list production was creating a
18206 new list of base types.
18208 * rootcontext.cs (StdLib): New property.
18209 (GetInterfaceTypeByName): returns an interface by type name, and
18210 encapsulates error handling here.
18211 (GetInterfaces): simplified.
18212 (ResolveTree): Encapsulated all the tree resolution here.
18213 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
18216 * driver.cs: Add support for --nostdlib, to avoid loading the
18217 default assemblies.
18218 (Main): Do not put tree resolution here.
18220 * rootcontext.cs: Beginning of the class resolution.
18222 2001-08-03 Miguel de Icaza <miguel@ximian.com>
18224 * rootcontext.cs: Provide better error reporting.
18226 * cs-parser.jay (interface_base): set our $$ to be interfaces.
18228 * rootcontext.cs (CreateInterface): Handle the case where there
18229 are no parent interfaces.
18231 (CloseTypes): Routine to flush types at the end.
18232 (CreateInterface): Track types.
18233 (GetInterfaces): Returns an array of Types from the list of
18234 defined interfaces.
18236 * typemanager.c (AddUserType): Mechanism to track user types (puts
18237 the type on the global type hash, and allows us to close it at the
18240 2001-08-02 Miguel de Icaza <miguel@ximian.com>
18242 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
18243 RecordInterface instead.
18245 * cs-parser.jay: Updated to reflect changes above.
18247 * decl.cs (Definition): Keep track of the TypeBuilder type that
18248 represents this type here. Not sure we will use it in the long
18249 run, but wont hurt for now.
18251 * driver.cs: Smaller changes to accomodate the new code.
18253 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
18256 * rootcontext.cs (CreateInterface): New method, used to create
18257 the System.TypeBuilder type for interfaces.
18258 (ResolveInterfaces): new entry point to resolve the interface
18260 (CodeGen): Property, used to keep track of the code generator.
18262 2001-07-26 Miguel de Icaza <miguel@ximian.com>
18264 * cs-parser.jay: Add a second production for delegate_declaration
18267 (enum_body): Put an opt_comma here instead of putting it on
18268 enum_body or enum_member_declarations so we can handle trailing
18269 commas on enumeration members. Gets rid of a shift/reduce.
18271 (type_list): Need a COMMA in the middle.
18273 (indexer_declaration): Tell tokenizer to recognize get/set
18275 * Remove old targets.
18277 * Re-add the parser target.
18279 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18281 * cs-parser.jay: Add precendence rules for a number of operators
18282 ot reduce the number of shift/reduce conflicts in the grammar.
18284 2001-07-17 Miguel de Icaza <miguel@ximian.com>
18286 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
18289 Get rid of old crufty code.
18291 * rootcontext.cs: Use this to keep track of the parsed
18292 representation and the defined types available to the program.
18294 * gen-treedump.cs: adjust for new convention.
18296 * type.cs: Split out the type manager, and the assembly builder
18299 * typemanager.cs: the type manager will live here now.
18301 * cil-codegen.cs: And the code generator here.
18303 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
18305 * makefile: Fixed up for easy making.
18307 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18309 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
18312 (unary_expression): Expand pre_increment_expression and
18313 post_decrement_expression to reduce a shift/reduce.
18315 2001-07-11 Simon Cozens
18317 * cs-tokenizer.cs: Hex numbers should begin with a 0.
18319 Improve allow_keyword_as_indent name.
18321 2001-06-19 Miguel de Icaza <miguel@ximian.com>
18323 * Adjustments for Beta2.
18325 2001-06-13 Miguel de Icaza <miguel@ximian.com>
18327 * decl.cs: Added `Define' abstract method.
18328 (InTransit): new property, used to catch recursive definitions.
18330 * interface.cs: Implement `Define'.
18332 * modifiers.cs: Map Modifiers.constants to
18333 System.Reflection.TypeAttribute flags.
18335 * class.cs: Keep track of types and user-defined types.
18336 (BuilderInit): New method for creating an assembly
18337 (ResolveType): New function to launch the resolution process, only
18338 used by interfaces for now.
18340 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
18341 that are inserted into the name space.
18343 2001-06-08 Miguel de Icaza <miguel@ximian.com>
18345 * ARGH. I have screwed up my tree so many times due to the use of
18346 rsync rather than using CVS. Going to fix this at once.
18348 * driver.cs: Objetify driver. Load assemblies, use assemblies to
18351 2001-06-07 Miguel de Icaza <miguel@ximian.com>
18353 * Experiment successful: Use System.Type rather that our own
18356 2001-05-25 Miguel de Icaza <miguel@ximian.com>
18358 * cs-parser.jay: Removed nsAliases from here.
18360 Use new namespaces, handle `using XXX;'
18362 * namespace.cs: Reimplemented namespace handling, use a recursive
18363 definition of the class. Now we can keep track of using clauses
18364 and catch invalid using clauses.
18366 2001-05-24 Miguel de Icaza <miguel@ximian.com>
18368 * gen-treedump.cs: Adapted for all the renaming.
18370 * expression.cs (Expression): this class now has a Type property
18371 which returns an expression Type.
18373 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
18374 `Type', as this has a different meaning now in the base
18376 2001-05-22 Miguel de Icaza <miguel@ximian.com>
18378 * interface.cs, class.cs: Removed from all the sources the
18379 references to signature computation, as we can not do method
18380 signature computation during the parsing time, as we are not
18381 trying to solve at that point distinguishing:
18385 void a (NS.Blah x) {}
18388 Which depending on the context might be valid or not, as we do not
18389 know if Blah is the same thing as NS.Blah at that point.
18391 * Redid everything so the code uses TypeRefs now instead of
18392 Types. TypeRefs are just temporary type placeholders, that need
18393 to be resolved. They initially have a pointer to a string and the
18394 current scope in which they are used. This is used later by the
18395 compiler to resolve the reference to an actual Type.
18397 * DeclSpace is no longer a CIR.Type, and neither are
18398 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
18399 are all DeclSpaces, but no Types.
18401 * type.cs (TypeRefManager): This implements the TypeRef manager,
18402 which keeps track of all the types that need to be resolved after
18403 the parsing has finished.
18405 2001-05-13 Miguel de Icaza <miguel@ximian.com>
18407 * ARGH. We are going to have to store `foreach' as a class rather
18408 than resolving it, as we need to verify error 1579 after name
18409 resolution. *OR* we could keep a flag that says `This request to
18410 IEnumerator comes from a foreach statement' which we can then use
18411 to generate the error.
18413 2001-05-10 Miguel de Icaza <miguel@ximian.com>
18415 * class.cs (TypeContainer.AddMethod): we now add methods to the
18416 MethodGroup instead of the method hashtable.
18418 * expression.cs: Add MethodGroup abstraction, which gets us one
18419 step closer to the specification in the way we handle method
18422 * cs-parser.jay (primary_expression): qualified_identifier now
18423 tried to match up an identifier to a local variable reference or
18424 to a parameter reference.
18426 current_local_parameters is now a parser global variable that
18427 points to the current parameters for the block, used during name
18430 (property_declaration): Now creates an implicit `value' argument to
18433 2001-05-09 Miguel de Icaza <miguel@ximian.com>
18435 * parameter.cs: Do not use `param' arguments as part of the
18436 signature, per the spec.
18438 2001-05-08 Miguel de Icaza <miguel@ximian.com>
18440 * decl.cs: Base class for classes, structs and interfaces. This
18441 is the "Declaration Space"
18443 * cs-parser.jay: Use CheckDef for checking declaration errors
18444 instead of having one on each function.
18446 * class.cs: Factor out some code for handling error handling in
18447 accordance to the "Declarations" section in the "Basic Concepts"
18448 chapter in the ECMA C# spec.
18450 * interface.cs: Make all interface member classes derive from
18451 InterfaceMemberBase.
18453 2001-05-07 Miguel de Icaza <miguel@ximian.com>
18455 * Many things: all interfaces are parsed and generated in
18456 gen-treedump. Support for member variables, constructors,
18457 destructors, properties, constants is there.
18459 Beginning of the IL backend, but very little done, just there for
18462 2001-04-29 Miguel de Icaza <miguel@ximian.com>
18464 * cs-parser.jay: Fix labeled statement.
18466 * cs-tokenizer.cs (escape): Escape " and ' always.
18467 ref_line, ref_name: keep track of the line/filename as instructed
18468 by #line by the compiler.
18471 2001-04-27 Miguel de Icaza <miguel@ximian.com>
18473 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
18474 to match the values in System.CodeDOM.
18476 Divid renamed to Divide.
18478 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
18480 (Statements.set): remove.
18482 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18485 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18486 falseStatements always have valid values.
18488 * cs-parser.jay: Use System.CodeDOM now.