1 2003-05-18 Martin Baulig <martin@ximian.com>
3 Reworked the way how local variables and parameters are handled by
4 the flow analysis code.
6 * statement.cs (TypeInfo, VariableMap): New public classes.
7 (VariableInfo): New public class. This is now responsible for
8 checking whether a variable has been assigned. It is used for
9 parameters and local variables.
10 (Block.EmitMeta): Take the InternalParameters as argument; compute
11 the layout of the flow vectors here.
12 (Block.LocalMap, Block.ParameterMap): New public properties.
13 (FlowBranching): The .ctor doesn't get the InternalParameters
14 anymore since Block.EmitMeta() now computes the layout of the flow
16 (MyStructInfo): This class is now known as `StructInfo' and nested
17 in `TypeInfo'; we don't access this directly anymore.
19 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
20 property and removed IsAssigned(), IsFieldAssigned(),
21 SetAssigned() and SetFieldAssigned(); we now call them on the
22 VariableInfo so we don't need to duplicate this code everywhere.
24 * expression.cs (ParameterReference): Added `Block block' argument
26 (LocalVariableReference, ParameterReference, This): The new
27 VariableInfo class is now responsible for all the definite
30 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
31 IsParameterAssigned, SetParameterAssigned): Removed.
33 2003-05-18 Martin Baulig <martin@ximian.com>
35 * typemanager.cs (InitCoreTypes): Try calling
36 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
37 the 3-args-version. Corlib now also needs our `void_type'.
38 (GetMethod): Added overloaded version which takes an optional
39 `bool report_errors' to allow lookups of optional methods.
41 2003-05-12 Martin Baulig <martin@ximian.com>
43 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
44 only used for locals and not for parameters.
46 2003-05-12 Miguel de Icaza <miguel@ximian.com>
48 * support.cs (InternalParameters.ParameterType): Return the
49 ExternalType of the parameter.
51 * parameter.cs (Parameter.ExternalType): drop the two arguments,
54 s2003-05-11 Miguel de Icaza <miguel@ximian.com>
56 * class.cs (MethodData.Define): Do not set the `newslot' on
57 interface members, if they are also flagged as "override".
59 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
60 better code for ++i and i++. This only works for static fields
63 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
64 want to pull the DeclSpace out of the builder_to_declspace instead
65 of the TypeBuilder (like in TypeContainer.FindMembers).
67 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
68 instead of LookupTypeContainer. Fixes the crash on .NET for
69 looking up interface members.
71 * const.cs: Create our own emit context during the Definition
72 stage, so that constants are evaluated in the proper context, when
73 a recursive definition happens.
75 2003-05-11 Martin Baulig <martin@ximian.com>
77 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
78 new block for a switch section.
79 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
80 the adding/lookup in the switch block. Fixes #39828.
82 2003-05-09 Miguel de Icaza <miguel@ximian.com>
84 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
85 functionality: I needed to convert the data after I had performed
86 the add/sub operation into the operands type size.
88 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
89 pass the type for the box operation, otherwise the resulting
90 object would have been of type object.
92 (BoxedCast): Add constructor to specify the type to box as.
94 2003-05-07 Miguel de Icaza <miguel@ximian.com>
96 * iterators.cs: I was reusing the `count' variable inadvertently,
97 take steps to not allow this to happen.
99 2003-05-06 Miguel de Icaza <miguel@ximian.com>
101 * attribute.cs (Attribute.Resolve): Params attributes are encoded
102 by creating an array at the point where the params starts and
103 putting all those arguments there, then adjusting the size of the
106 2003-05-05 Miguel de Icaza <miguel@ximian.com>
108 * expression.cs (New.AddressOf): Implement interface
109 IMemoryLocation. This is used when the `new' operator is used in
110 the context of an invocation to a method on a value type.
112 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
115 * namespace.cs: Also check the using aliases here.
117 * driver.cs: Move the test for using validity after the types have
118 been entered, so we do a single pass that also includes the using
121 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
122 in the regular case. CreateSiblingForFinally is doing extra
125 * attribute.cs (GetAttributeArgumentExpression): Store the result
126 on an out value, and use the return value to indicate failure
127 instead of using null (which is a valid return for Constant.GetValue).
129 * statement.cs: Perform the analysis flow for the increment
130 portion after the statement, because this will be the real flow of
131 execution. Fixes #42385
133 * codegen.cs (EmitContext.EmitArgument,
134 EmitContext.EmitStoreArgument): New helper functions when the
135 RemapToProxy flag is set.
137 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
140 Add support for remapping parameters.
142 * iterators.cs: Propagate parameter values; Store parameter
143 values in the proxy classes.
145 2003-05-04 Miguel de Icaza <miguel@ximian.com>
147 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
148 need a proxy reference; I do not know what I was thinking
150 * cs-parser.jay (constructor_initializer): catch another error,
151 and display nice message.
153 (field_declaration): catch void field declaration
154 to flag a better error.
156 * class.cs (MemberBase.CheckBase): Report an error instead of a
157 warning if a new protected member is declared in a struct.
158 (Field.Define): catch the error of readonly/volatile.
160 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
162 (FieldExpr.AddressOf): ditto. Catch error where the address of a
163 volatile variable is taken
165 2003-05-02 Miguel de Icaza <miguel@ximian.com>
167 * statement.cs (Fixed.Resolve): Report an error if we are not in
170 2003-05-01 Miguel de Icaza <miguel@ximian.com>
172 * typemanager.cs: reuse the code that handles type clashes for
173 delegates and enumerations.
175 * class.cs (Report28): Always report.
177 * expression.cs (EncodeAsAttribute): Allow nulls here.
179 2003-04-28 Miguel de Icaza <miguel@ximian.com>
181 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
182 the functionality for testing whether an expression is valid for
183 an attribute here. Also handle the case of arrays of elements
186 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
187 encoding a linear array into an array of objects that are suitable
188 to be passed to an CustomAttributeBuilder.
190 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
192 * ecore.cs: (FieldExpr): Handle field remapping here.
194 * iteratators.cs: Pass the instance variable (if the method is an
195 instance method) to the constructors, so we can access the field
196 variables on the class.
198 TODO: Test this with structs. I think the THIS variable on
199 structs might have to be a pointer, and not a refenrece
201 2003-04-27 Miguel de Icaza <miguel@ximian.com>
203 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
204 local variables to fields in a proxy class.
206 * iterators.cs (PopulateProxy): Rename our internal fields to
208 Create a <THIS> field if we are an instance method, so we can
209 reference our parent container variables.
210 (MapVariable): Called back from the EmitContext code to enter a
211 new variable to field mapping into the proxy class (we just create
215 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
216 for using the remapped locals to fields.
218 I placed the code here, because that gives the same semantics to
219 local variables, and only changes the Emit code.
221 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
222 statements inside iterators.
223 (VariableInfo): Add a FieldBuilder for the cases when we are
224 remapping local variables to fields in a proxy class
226 * ecore.cs (SimpleNameResolve): Avoid testing two times for
227 current_block != null.
229 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
230 not cope with strings, as it has been moved to the
231 TableSwitchEmit. Fixed bug in switch generation.
233 * expression.cs (New.DoResolve): Provide more context for the user
234 when reporting an error.
236 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
239 * expression.cs (MemberAccess.DoResolve): When we get a type back,
240 check the permissions for it. Note than in a type-resolution
241 context the check was already present in DeclSpace.ResolveType,
242 but was missing from the MemberAccess.
244 (ArrayCreation.CheckIndices): warn if the user has
245 more nested levels of expressions, but there are no more
246 dimensions specified. Avoids crash on bug 41906.
248 2003-04-26 Miguel de Icaza <miguel@ximian.com>
250 * statement.cs (Block): replace Implicit bool, for a generic
252 New flag: `Unchecked'. This is used during the EmitMeta phase
253 (which is out-of-line with the regular Resolve/Emit process for a
254 statement, as this is done ahead of time, but still gets a chance
255 to call constant resolve).
257 (Block.Flags): new enum for adding a new flag.
259 (Block.EmitMeta): track the state of unchecked.
261 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
262 to enable constant resolution to work there as well.
264 2003-04-22 Miguel de Icaza <miguel@ximian.com>
266 * typemanager.cs (ienumerable_type): Also look up
267 System.Collections.IEnumerable.
269 2003-04-21 Miguel de Icaza <miguel@ximian.com>
271 TODO: Test more than one conditional per method.
273 * class.cs (Indexer.Define): Report the location where the user is
274 referencing the unsupported feature.
276 (MethodData): Overload the use of `conditionals' to
277 minimize the creation of needless ArrayLists. This saves roughly
280 (Method): Implement the new IIteratorContainer interface.
281 (Method.SetYields): Implement the method by setting the ModFlags
282 to contain METHOD_YIELDS.
284 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
285 which just got set to null.
287 * iterators.cs: New file.
289 (Yield, YieldBreak): New statements.
291 * statement.cs (Return.Resolve): Flag an error if we are used in
294 * codegen.cs (InIterator): New flag set if the code is being
295 compiled in an iterator method.
297 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
298 internal modifier, and we just use it to avoid adding extra
299 fields, as this is seldom used.
301 * cs-parser.jay: Add yield_statement (yield and yield break).
303 * driver.cs: New flag -v2 to turn on version 2 features.
305 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
306 hashtable when v2 is enabled.
308 2003-04-20 Miguel de Icaza <miguel@ximian.com>
310 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
311 there is already a namespace defined with this name.
313 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
314 people upgraded their corlibs.
316 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
317 always use fully qualified types, no need to use the compiler
320 (TypeManager.IsNamespace): Use binarysearch.
322 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
323 AddDelegate): I did not quite use the new IsValid API properly: I
324 have to pass the short-name and the fullname. I was passing only
325 the basename instead of the fullname sometimes.
327 (TypeContainer.DefineType): call NamespaceClash.
329 * interface.cs (Interface.DefineType): use NamespaceClash before
332 * delegate.cs (Delegate.DefineType): use NamespaceClash before
335 * enum.cs: (Enum.DefineType): use NamespaceClash before
338 * typemanager.cs (: 3-line patch that gives us some tasty 11%
339 speed increase. First, use the negative_hits cache when we get a
340 negative. Second, add the type with its full original name
341 instead of the new . and + encoded name (reflection uses + to
342 separate type from a nested type). Use LookupTypeReflection
343 directly which bypasses the type->name hashtable (that we already
344 know does not contain the type.
346 * decl.cs (DeclSpace.ResolveTypeExpr): track the
347 location/container type.
349 * driver.cs: When passing utf8, use directly the UTF8Encoding.
351 2003-04-19 Miguel de Icaza <miguel@ximian.com>
353 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
355 * delegate.cs (NewDelegate.Resolve): Test whether an instance
356 method is being referenced in the method group from a static
357 context, and report error 120 if so.
359 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
362 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
363 is created, we create the A namespace).
365 * cs-parser.jay: A namespace also introduces a DeclarationFound.
368 2003-04-18 Miguel de Icaza <miguel@ximian.com>
370 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
371 invocation to ModuleBuilder.GetType with the same values will
372 return a new type instance, so we need to cache its return
375 * expression.cs (Binary.ResolveOperator): Only allow the compare
376 operators on enums if they are of the same type.
378 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
379 types of ValueType on their own case. Before we were giving them
380 the same treatment as objects.
382 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
383 fullname. Short name is used to compare against container name.
384 Fullname is used to check against defined namespace names.
386 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
387 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
389 (Method.CheckBase): Call parent.
390 (MemberBase.CheckBase): Check for protected members on sealed
392 (PropertyBase.CheckBase): Call parent.
393 (Field.Define): Call parent.
395 * report.cs: Negative error codes are now mapped to 8000 - code,
396 so that the display is render more nicely.
398 * typemanager.cs: Do not use try/catch, instead report a regular
401 (GetPointerType, GetReferenceType): These methods provide
402 mechanisms to obtain the T* and T& from a T. We had the code
403 previously scattered around the code base, and it also used
404 TypeManager.LookupType that would go through plenty of caches.
405 This one goes directly to the type source.
407 In some places we did the Type.GetType followed by
408 ModuleBuilder.GetType, but not in others, so this unifies the
411 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
412 statements now that we have namespace information.
414 * typemanager.cs (IsNamespace): New method, returns whether the
415 string presented is a namespace or not.
417 (ComputeNamespaces): New public entry point, computes the list of
418 available namespaces, using the GetNamespaces API call in Mono, or
419 the slower version in MS.NET.
421 Now before we start the semantic analysis phase, we have a
422 complete list of namespaces including everything that the user has
425 Deleted old code to cache namespaces in .nsc files.
427 2003-04-17 Miguel de Icaza <miguel@ximian.com>
429 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
430 class/struct location definition Location for the implicit
431 constructor location.
433 (Operator.Define): Use the location of the operator for the
434 implicit Method definition.
436 (Constructor.Emit): use the constructor location for the implicit
437 base initializer constructor.
439 * ecore.cs: Remove ITypeExpression. This interface is now gone,
440 and the Expression class now contains two new methods:
442 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
443 isolate type lookup from the rest of the resolution process.
445 Since we use Expressions to hold type definitions due to the way
446 we parse the input we have historically overloaded Resolve to
447 perform the Type lookups if a special flag is passed. Now this is
448 eliminated and two methods take their place.
450 The differences in the two methods between xStep and xTerminal is
451 that xStep is involved in our current lookup system that uses
452 SimpleNames to compose a name, while xTerminal is used just to
453 catch the case where the simplename lookup failed.
455 2003-04-16 Miguel de Icaza <miguel@ximian.com>
457 * expression.cs (ResolveMemberAccess): Remove redundant code.
458 TypeExpr expressions are always born fully resolved.
460 * interface.cs (PopulateMethod): Do not lookup the types twice.
461 We were doing it once during SemanticAnalysis and once during
464 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
465 in local variable type definitions, were being returned as a
466 SimpleName (we decomposed everything into a string), that is
467 because primary_expression was being used instead of a type in the
468 grammar (reduce/reduce conflicts).
470 The part that was wrong is that we converted the expression into a
471 string (an oversimplification in one hand, compounded with primary
472 expressions doing string concatenation).
478 Would return "A.B.C[]" as a SimpleName. This stopped things like
479 using clauses from working on this particular context. And a type
480 was being matched directly against "A.B.C[]".
482 We now use the correct approach, and allow for ComposedCast to be
483 part of the unary expression. So the "A.B.C []" become a composed
484 cast of "A.B.C" (as a nested group of MemberAccess with a
485 SimpleName at the end) plus the rank composition "[]".
489 2003-04-10 Miguel de Icaza <miguel@ximian.com>
491 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
492 for the access level checking.
494 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
495 `TypeContainer container', because I kept getting confused when I
496 was debugging this code.
498 * expression.cs (Indexers): Instead of tracking getters/setters,
499 we now track them in parallel. We create one arraylist less, but
500 most importantly it is possible now for the LValue code to find a
501 matching get for a set.
503 (IndexerAccess.DoResolveLValue): Update the code.
504 GetIndexersForType has been modified already to extract all the
505 indexers from a type. The code assumed it did not.
507 Also make the code set the correct return type for the indexer.
508 This was fixed a long time ago for properties, but was missing for
509 indexers. It used to be void_type.
511 (Binary.Emit): Test first for doubles instead of
512 floats, as they are more common.
514 (Binary.EmitBranchable): Use the .un version of the branch opcodes
515 when dealing with floats and the <=, >= operators. This fixes bug
518 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
519 to load the array value by emitting a load on the foreach variable
520 type. This was incorrect.
522 We now emit the code to load an element using the the array
523 variable type, and then we emit the conversion operator.
527 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
529 * attribute.cs: Avoid allocation of ArrayLists in the common case.
531 2003-04-09 Miguel de Icaza <miguel@ximian.com>
533 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
534 test for protection before we test for signatures.
536 (MethodSignature.ToString): implement.
538 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
539 to the case where we reduced into a LongConstant.
541 * decl.cs (CheckAccessLevel): If the type is an array, we can not
542 depend on whether the information is acurrate, because the
543 Microsoft runtime will always claim that the array type is public,
544 regardless of the real state.
546 If the type is a pointer, another problem happens: the type is
547 reported as non-public in Microsoft.
549 In both cases we have to call CheckAccessLevel recursively with
550 the underlying type as the argument to be tested.
552 2003-04-08 Miguel de Icaza <miguel@ximian.com>
554 * assign.cs (Assign.Emit): If we are dealing with a compound
555 assignment expression, we should use the code path that stores the
556 intermediate result in a temporary value. This fixes #40903.
558 *expression.cs (Indirection.ToString): Provide ToString method for
561 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
563 * class.cs: Null out fields holding references to Block objects so
564 they can be garbage collected.
566 * expression.cs (OverloadResolve): Remove unused local.
568 2003-04-07 Martin Baulig <martin@ximian.com>
570 * codegen.cs (EmitContext.CurrentFile): New public field.
571 (EmitContext.Mark): Use the CurrentFile to check whether the
572 location is in the correct file.
573 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
575 2003-04-07 Martin Baulig <martin@ximian.com>
577 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
579 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
580 location. [FIXME: The location argument which gets passed to this
581 method is sometimes wrong!]
583 2003-04-07 Nick Drochak <ndrochak@gol.com>
585 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
587 2003-04-07 Miguel de Icaza <miguel@ximian.com>
589 * expression.cs (Indirection.EmitAssign): We were using the
590 temporary, but returning immediately instead of continuing the
593 2003-04-06 Martin Baulig <martin@ximian.com>
595 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
596 if it's a nested child, but also deriving from the outer class.
599 * typemanager.cs (IsNestedChildOf): Make this work if it's a
600 nested child, but also deriving from the outer class. See
602 (FilterWithClosure): We may access private members of the outer
603 class if we're a nested child and deriving from the outer class.
604 (RealMemberLookup): Only set `closure_private_ok' if the
605 `original_bf' contained BindingFlags.NonPublic.
607 2003-04-05 Martin Baulig <martin@ximian.com>
609 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
611 2003-04-02 Miguel de Icaza <miguel@ximian.com>
613 * class.cs (Event.Define): Do not allow abstract events to have
616 2003-04-01 Miguel de Icaza <miguel@ximian.com>
618 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
619 block in event declarations.
621 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
622 value type, get its address.
624 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
625 leaving a class on the stack instead of a boolean value (int
626 0/1). Change the code so we compare against null, and then the
629 * class.cs (TypeContainer.GetClassBases): We were checking for the
630 parent class being sealed too late.
632 * expression.cs (Binary.Emit): For <= and >= when dealing with
633 floating point values, use cgt.un and clt.un instead of cgt and
636 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
638 * statement.cs: Apply the same optimization as MS: skip the
639 GetEnumerator returning an IEnumerator, and use the one returning a
640 CharEnumerator instead. This allows us to avoid the try-finally block
643 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
645 * cs-parser.jay: Attributes cannot be applied to
646 namespaces. Fixes #40473
648 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
651 (Add*): check if the name is valid using the full name for constants,
652 fields, properties and events.
654 2003-03-28 Miguel de Icaza <miguel@ximian.com>
656 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
657 char constants to be part of the enumeration.
659 * expression.cs (Conditional.DoResolve): Add support for operator
660 true. Implements the missing functionality from 14.12
662 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
663 operator true/false as required by the spec.
665 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
666 implicit conversion to boolean.
668 * statement.cs (Statement.ResolveBoolean): A boolean expression is
669 also one where the type implements `operator true'.
671 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
672 get an expression that will invoke operator true based on an
675 (GetConversionOperators): Removed the hack that called op_True
678 (Expression.ResolveBoolean): Move this from Statement.
680 2003-03-17 Miguel de Icaza <miguel@ximian.com>
682 * ecore.cs (FieldExpr): do not allow initialization of initonly
683 fields on derived classes
685 2003-03-13 Martin Baulig <martin@ximian.com>
687 * statement.cs (Block.Emit): Call ig.BeginScope() and
688 ig.EndScope() when compiling with debugging info; call
689 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
691 2003-03-08 Miguel de Icaza <miguel@ximian.com>
693 * expression.cs (Indexers): Do not construct immediately, allow
694 for new members to be appended as we go. Fixes 38143
696 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
698 * expression.cs: save/restore context when resolving an unchecked
701 2003-03-05 Miguel de Icaza <miguel@ximian.com>
703 * cfold.cs: Catch division by zero in modulus operator during
706 2003-03-03 Miguel de Icaza <miguel@ximian.com>
708 * interface.cs (Interface.DefineMembers): Avoid defining members
711 2003-02-27 Miguel de Icaza <miguel@ximian.com>
713 * driver.cs: handle the +/- options for -noconfig
715 * statement.cs (Unckeched.Resolve): Also track the state of
716 unchecked in the Resolve phase.
718 2003-02-27 Martin Baulig <martin@ximian.com>
720 * ecore.cs (Expression.MemberLookup): Don't create a
721 MethodGroupExpr for something which is not a method. Fixes #38291.
723 2003-02-25 Miguel de Icaza <miguel@ximian.com>
725 * class.cs (MemberBase.CheckParameters): Also check that the type
726 is unmanaged if it is a pointer.
728 * expression.cs (SizeOf.Resolve): Add location information.
730 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
731 a managed type is declared.
733 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
734 parameter modifiers as well. Fixes bug 38606
736 * class.cs: Very sad. Am backing out the speed up changes
737 introduced by the ArrayList -> Array in the TypeContainer, as they
738 were not actually that much faster, and introduced a bug (no error
739 reports on duplicated methods).
741 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
742 source first, this will guarantee that we have a valid expression
743 before calling in lower levels functions that will require a
744 resolved object. Then use this original_source in the
745 target.ResolveLValue instead of the original source that was
748 Another change. Use target.Resolve instead of LValueResolve.
749 Although we are resolving for LValues, we will let the Assign code
750 take care of that (it will be called again from Resolve). This
751 basically allows code like this:
753 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
754 class Y { void A (X x) { x [0] += o; }
756 The problem was that the indexer was trying to resolve for
757 set_Item (idx, object o) and never finding one. The real set_Item
758 was set_Item (idx, X). By delaying the process we get the right
763 2003-02-23 Martin Baulig <martin@ximian.com>
765 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
766 while calling DoEmit ().
768 * codegen.cs (EmitContext.Mark): Don't mark locations in other
769 source files; if you use the #line directive inside a method, the
770 compiler stops emitting line numbers for the debugger until it
771 reaches the end of the method or another #line directive which
772 restores the original file.
774 2003-02-23 Martin Baulig <martin@ximian.com>
776 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
778 2003-02-23 Martin Baulig <martin@ximian.com>
780 * statement.cs (Block.AddChildVariableNames): We need to call this
781 recursively, not just for our immediate children.
783 2003-02-23 Martin Baulig <martin@ximian.com>
785 * class.cs (Event.Define): Always make the field private, like csc does.
787 * typemanager.cs (TypeManager.RealMemberLookup): Make events
788 actually work, fixes bug #37521.
790 2003-02-23 Miguel de Icaza <miguel@ximian.com>
792 * delegate.cs: When creating the various temporary "Parameters"
793 classes, make sure that we call the ComputeAndDefineParameterTypes
794 on those new parameters (just like we do with the formal ones), to
795 allow them to be resolved in the context of the DeclSpace.
797 This fixes the bug that Dick observed in Bugzilla #38530.
799 2003-02-22 Miguel de Icaza <miguel@ximian.com>
801 * expression.cs (ResolveMemberAccess): When resolving a constant,
802 do not attempt to pull a constant if the value was not able to
803 generate a valid constant.
805 * const.cs (LookupConstantValue): Do not report more errors than required.
807 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
809 * expression.cs: fixes bug #38328.
811 2003-02-18 Miguel de Icaza <miguel@ximian.com>
813 * class.cs: Changed all the various members that can be part of a
814 class from being an ArrayList to be an Array of the right type.
815 During the DefineType type_list, interface_list, delegate_list and
816 enum_list are turned into types, interfaces, delegates and enums
819 And during the member population, indexer_list, event_list,
820 constant_list, field_list, instance_constructor_list, method_list,
821 operator_list and property_list are turned into their real arrays.
823 Although we could probably perform this operation earlier, for
824 good error reporting we need to keep the lists and remove the
825 lists for longer than required.
827 This optimization was triggered by Paolo profiling the compiler
828 speed on the output of `gen-sample-program.pl' perl script.
830 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
831 not crash in methods like MemberLookupFailed that use this field.
833 This problem arises when the compiler fails to resolve a type
834 during interface type definition for example.
836 2003-02-18 Miguel de Icaza <miguel@ximian.com>
838 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
839 inherit from System.Object, so we have to stop at null, not only
840 when reaching System.Object.
842 2003-02-17 Miguel de Icaza <miguel@ximian.com>
844 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
845 DeclaredOnly because the parent indexer might have had a different
846 name, but did not loop until the top of the hierarchy was reached.
848 The problem this one fixes is 35492: when a class implemented an
849 indexer from an interface, we were getting the interface method
850 (which was abstract) and we were flagging an error (can not invoke
853 This also keeps bug 33089 functioning, and test-148 functioning.
855 * typemanager.cs (IsSpecialMethod): The correct way of figuring
856 out if a method is special is to see if it is declared in a
857 property or event, or whether it is one of the predefined operator
858 names. This should fix correctly #36804.
860 2003-02-15 Miguel de Icaza <miguel@ximian.com>
862 The goal here is to remove the dependency on EmptyCast.Peel ().
863 Killing it completely.
865 The problem is that currently in a number of places where
866 constants are expected, we have to "probe" for an EmptyCast, and
867 Peel, which is not the correct thing to do, as this will be
868 repetitive and will likely lead to errors.
870 The idea is to remove any EmptyCasts that are used in casts that
871 can be reduced to constants, so we only have to cope with
874 This bug hunt was triggered by Bug 37363 and the desire to remove
875 the duplicate pattern where we were "peeling" emptycasts to check
876 whether they were constants. Now constants will always be
879 * ecore.cs: Use an enumconstant here instead of wrapping with
882 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
883 throwing me off. By handling this we can get rid of a few hacks.
885 * statement.cs (Switch): Removed Peel() code.
887 2003-02-14 Miguel de Icaza <miguel@ximian.com>
889 * class.cs: Location information for error 508
891 * expression.cs (New.DoResolve): Add a guard against double
892 resolution of an expression.
894 The New DoResolve might be called twice when initializing field
895 expressions (see EmitFieldInitializers, the call to
896 GetInitializerExpression will perform a resolve on the expression,
897 and later the assign will trigger another resolution
899 This leads to bugs (#37014)
901 * delegate.cs: The signature for EndInvoke should contain any ref
902 or out parameters as well. We were not doing this in the past.
904 * class.cs (Field.Define): Do not overwrite the type definition
905 inside the `volatile' group. Turns out that volatile enumerations
906 were changing the type here to perform a validity test, which
909 2003-02-12 Miguel de Icaza <miguel@ximian.com>
911 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
912 and structs, we do not want to load the instance variable
914 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
915 enum_type has to be handled like an object reference (implicit
916 conversions exists from this to object), but the regular IsClass
917 and IsValueType tests will never return true for this one.
919 Also we use TypeManager.IsValueType instead of type.IsValueType,
920 just for consistency with the rest of the code (this is only
921 needed if we ever use the construct exposed by test-180.cs inside
922 corlib, which we dont today).
924 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
926 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
929 2003-02-09 Martin Baulig <martin@ximian.com>
931 * namespace.cs (Namespace..ctor): Added SourceFile argument.
932 (Namespace.DefineNamespaces): New static public method; this is
933 called when we're compiling with debugging to add all namespaces
936 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
937 pass it to the Namespace's .ctor.
939 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
940 and MethodBase arguments; pass the namespace ID to the symwriter;
941 pass the MethodBase instead of the token to the symwriter.
942 (SymbolWriter.DefineNamespace): New method to add a namespace to
945 2003-02-09 Martin Baulig <martin@ximian.com>
947 * symbolwriter.cs: New file. This is a wrapper around
948 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
949 methods here in near future.
951 2003-02-09 Martin Baulig <martin@ximian.com>
953 * codegen.cs (EmitContext.Mark): Just pass the arguments to
954 ILGenerator.MarkSequencePoint() which are actually used by the
957 2003-02-09 Martin Baulig <martin@ximian.com>
959 * location.cs (SourceFile): New public sealed class. This
960 contains the name and an index which is used in the location's token.
961 (Location): Reserve an appropriate number of bits in the token for
962 the source file instead of walking over that list, this gives us a
963 really huge performance improvement when compiling with debugging.
965 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
966 `SourceFile' argument instead of a string.
967 (Driver.ProcessFile): Add all the files via Location.AddFile(),
968 but don't parse/tokenize here, we need to generate the list of all
969 source files before we do that.
970 (Driver.ProcessFiles): New static function. Parses/tokenizes all
973 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
976 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
979 2003-02-09 Martin Baulig <martin@ximian.com>
981 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
982 filename on `#line default'.
984 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
986 * statement.cs: don't clear the pinned var when the fixed statement
987 returns from the method (fixes bug#37752).
989 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
991 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
994 2003-02-07 Martin Baulig <martin@ximian.com>
996 * driver.cs: Removed the `--debug-args' command line argument.
998 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
999 automatically by the AsssemblyBuilder.
1000 (CodeGen.InitializeSymbolWriter): We don't need to call any
1001 initialization function on the symbol writer anymore. This method
1002 doesn't take any arguments.
1004 2003-02-03 Miguel de Icaza <miguel@ximian.com>
1006 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
1007 from referenced assemblies as well.
1009 2003-02-02 Martin Baulig <martin@ximian.com>
1011 * class.cs (MethodData.Emit): Generate debugging info for external methods.
1013 2003-02-02 Martin Baulig <martin@ximian.com>
1015 * class.cs (Constructor.Emit): Open the symbol writer before
1016 emitting the constructor initializer.
1017 (ConstructorInitializer.Emit): Call ec.Mark() to allow
1018 single-stepping through constructor initializers.
1020 2003-01-30 Miguel de Icaza <miguel@ximian.com>
1022 * class.cs: Handle error 549: do not allow virtual methods in
1025 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
1027 * decl.cs: Check access levels when resolving types
1029 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
1031 * statement.cs: Add parameters and locals set in catch blocks that might
1032 return to set vector
1034 2003-01-29 Miguel de Icaza <miguel@ximian.com>
1036 * class.cs (Operator): Set the SpecialName flags for operators.
1038 * expression.cs (Invocation.DoResolve): Only block calls to
1039 accessors and operators on SpecialName methods.
1041 (Cast.TryReduce): Handle conversions from char constants.
1044 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
1046 * statement.cs: small memory and time optimization in FlowBranching.
1048 2003-01-28 Pedro Mart <yoros@wanadoo.es>
1050 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
1051 problem that the last fix but in the other sid (Set).
1053 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
1054 access when there is no indexer in the hierarchy.
1056 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
1058 * class.cs: Combine some if statements.
1060 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1062 * driver.cs: fixed bug #37187.
1064 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
1066 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
1067 any indexer, it's needed to build a list with all the indexers in the
1068 hierarchy (AllGetters), else we have problems. Fixes #35653.
1070 2003-01-23 Miguel de Icaza <miguel@ximian.com>
1072 * class.cs (MethodData.Define): It is wrong for an interface
1073 implementation to be static in both cases: explicit and implicit.
1074 We were only handling this in one case.
1076 Improve the if situation there to not have negations.
1078 * class.cs (Field.Define): Turns out that we do not need to check
1079 the unsafe bit on field definition, only on usage. Remove the test.
1081 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1083 * driver.cs: use assembly.Location instead of Codebase (the latest
1084 patch made mcs fail when using MS assemblies).
1086 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
1088 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
1089 get the path to *corlib.dll.
1091 2003-01-21 Nick Drochak <ndrochak@gol.com>
1095 * typemanager.cs: Remove compiler warnings
1097 2003-01-20 Duncan Mak <duncan@ximian.com>
1099 * AssemblyInfo.cs: Bump the version number to 0.19.
1101 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1103 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
1105 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
1107 * class.cs (Constructor::Emit): Emit debugging info for constructors.
1109 2003-01-17 Miguel de Icaza <miguel@ximian.com>
1111 * cs-parser.jay: Small fix: we were not comparing the constructor
1112 name correctly. Thanks to Zoltan for the initial pointer.
1114 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
1116 * cs-tokenizer.cs: Set file name when specified with #line
1118 2003-01-15 Miguel de Icaza <miguel@ximian.com>
1120 * cs-parser.jay: Only perform the constructor checks here if we
1121 are named like the class; This will help provider a better
1122 error. The constructor path is taken when a type definition is
1123 not found, but most likely the user forgot to add the type, so
1124 report that rather than the constructor error.
1126 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
1128 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
1131 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
1133 * cs-parser.jay: Add cleanup call.
1135 2003-01-13 Duncan Mak <duncan@ximian.com>
1137 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
1138 consistent with other methods.
1140 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
1142 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
1144 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
1146 * attribute.cs: only set GuidAttr to true when we have a
1149 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1153 * typemanager.cs: fixes to allow mcs compile corlib with the new
1154 Type.IsSubclassOf fix.
1156 2003-01-08 Miguel de Icaza <miguel@ximian.com>
1158 * expression.cs (LocalVariableReference.DoResolve): Classify a
1159 constant as a value, not as a variable. Also, set the type for
1162 * cs-parser.jay (fixed_statement): take a type instead of a
1163 pointer_type, so we can produce a better error message later.
1165 * statement.cs (Fixed.Resolve): Flag types that are not pointers
1168 (For.DoEmit): Make inifinite loops have a
1169 non-conditional branch back.
1171 (Fixed.DoEmit): First populate the pinned variables, then emit the
1172 statement, then clear the variables. Before I was emitting the
1173 code once for each fixed piece.
1176 2003-01-08 Martin Baulig <martin@ximian.com>
1178 * statement.cs (FlowBranching.MergeChild): A break in a
1179 SWITCH_SECTION does not leave a loop. Fixes #36155.
1181 2003-01-08 Martin Baulig <martin@ximian.com>
1183 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
1184 lives in the same number space than `param_map'. Fixes #36154.
1186 2003-01-07 Miguel de Icaza <miguel@ximian.com>
1188 * cs-parser.jay (constructor_declaration): Set the
1189 Constructor.ModFlags before probing for it. This makes the
1190 compiler report 514, 515 and 132 (the code was there, but got
1193 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
1194 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
1195 (GotoCase.Resolve): Set `Returns' to ALWAYS.
1197 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
1199 * enum.cs: create the enum static fields using the enum type.
1201 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
1203 * class.cs: don't try to create the ParamBuilder for the return
1204 type if it's not needed (and handle it breaking for the ms runtime
1207 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
1209 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
1211 2002-12-29 Miguel de Icaza <miguel@ximian.com>
1213 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
1214 the command. This showed up while compiling the JANET source
1215 code, which used \r as its only newline separator.
1217 2002-12-28 Miguel de Icaza <miguel@ximian.com>
1219 * class.cs (Method.Define): If we are an operator (because it
1220 reuses our code), then set the SpecialName and HideBySig. #36128
1222 2002-12-22 Miguel de Icaza <miguel@ximian.com>
1224 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
1225 exception, report error 120 `object reference required'.
1227 * driver.cs: Add --pause option, used during to measure the size
1228 of the process as it goes with --timestamp.
1230 * expression.cs (Invocation.DoResolve): Do not allow methods with
1231 SpecialName to be invoked.
1233 2002-12-21 Miguel de Icaza <miguel@ximian.com>
1235 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
1236 number before adding it.
1238 2002-12-21 Ravi Pratap <ravi@ximian.com>
1240 * ecore.cs (StandardImplicitConversion): When in an unsafe
1241 context, we allow conversion between void * to any other pointer
1242 type. This fixes bug #35973.
1244 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
1246 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
1247 is not thrown when extensionless outputs are used
1249 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1251 * rootcontext.cs: fixed compilation of corlib.
1253 2002-12-19 Miguel de Icaza <miguel@ximian.com>
1255 * attribute.cs (Attributes.Contains): Add new method.
1257 * class.cs (MethodCore.LabelParameters): if the parameter is an
1258 `out' parameter, check that no attribute `[In]' has been passed.
1260 * enum.cs: Handle the `value__' name in an enumeration.
1262 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
1264 * decl.cs: Added special case to allow overrides on "protected
1267 2002-12-18 Ravi Pratap <ravi@ximian.com>
1269 * attribute.cs (Attributes.AddAttributeSection): Rename to this
1270 since it makes much more sense.
1272 (Attributes.ctor): Don't require a Location parameter.
1274 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
1276 * attribute.cs (ApplyAttributes): Remove extra Location parameters
1277 since we already have that information per attribute.
1279 * everywhere : make appropriate changes.
1281 * class.cs (LabelParameters): Write the code which actually
1282 applies attributes to the return type. We can't do this on the MS
1283 .NET runtime so we flag a warning in the case an exception is
1286 2002-12-18 Miguel de Icaza <miguel@ximian.com>
1288 * const.cs: Handle implicit null conversions here too.
1290 2002-12-17 Ravi Pratap <ravi@ximian.com>
1292 * class.cs (MethodCore.LabelParameters): Remove the extra
1293 Type [] parameter since it is completely unnecessary. Instead
1294 pass in the method's attributes so that we can extract
1295 the "return" attribute.
1297 2002-12-17 Miguel de Icaza <miguel@ximian.com>
1299 * cs-parser.jay (parse): Use Report.Error to flag errors instead
1300 of ignoring it and letting the compile continue.
1302 * typemanager.cs (ChangeType): use an extra argument to return an
1303 error condition instead of throwing an exception.
1305 2002-12-15 Miguel de Icaza <miguel@ximian.com>
1307 * expression.cs (Unary.TryReduce): mimic the code for the regular
1308 code path. Perform an implicit cast in the cases where we can
1309 implicitly convert to one of the integral types, and then reduce
1310 based on that constant. This fixes bug #35483.
1312 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1314 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
1316 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1318 * namespace.cs: fixed bug #35489.
1320 2002-12-12 Miguel de Icaza <miguel@ximian.com>
1322 * class.cs: Remove some dead code.
1324 * cs-parser.jay: Estimate the number of methods needed
1325 (RootContext.MethodCount);
1327 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
1328 numbers instead of StringBuilders.
1330 * support.cs (PtrHashtable): Add constructor with initial size;
1331 We can now reduce reallocations of the method table.
1333 2002-12-10 Ravi Pratap <ravi@ximian.com>
1335 * attribute.cs (ApplyAttributes): Keep track of the emitted
1336 attributes on a per-target basis. This fixes bug #35413.
1338 2002-12-10 Miguel de Icaza <miguel@ximian.com>
1340 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
1341 default to the Windows 1252 encoding.
1343 (UnixParseOption): Support version, thanks to Alp for the missing
1346 * AssemblyInfo.cs: Add nice assembly information.
1348 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
1351 * cs-parser.jay: Allow a trailing comma before the close bracked
1352 in the attribute_section production.
1354 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
1355 address of the instance was being taken, I will take this out,
1356 because we take the address of the object immediately here.
1358 2002-12-09 Ravi Pratap <ravi@ximian.com>
1360 * typemanager.cs (AreMultipleAllowed): Take care of the most
1361 obvious case where attribute type is not in the current assembly -
1364 2002-12-08 Miguel de Icaza <miguel@ximian.com>
1366 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
1367 definitions, instead of doing that afterwards.
1369 Also we use a nice little hack, depending on the constructor, we
1370 know if we are a "composed" name or a simple name. Hence, we
1371 avoid the IndexOf test, and we avoid
1373 * codegen.cs: Add code to assist in a bug reporter to track down
1374 the source of a compiler crash.
1376 2002-12-07 Ravi Pratap <ravi@ximian.com>
1378 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
1379 types have been emitted for a given element and flag an error
1380 if something which does not have AllowMultiple set is used more
1383 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
1384 attribute types and their corresponding AllowMultiple properties
1386 (AreMultipleAllowed): Check the property for a given type.
1388 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
1389 property in the case we have a TypeContainer.
1391 (Attributes.AddAttribute): Detect duplicates and just skip on
1392 adding them. This trivial fix catches a pretty gross error in our
1393 attribute emission - global attributes were being emitted twice!
1395 Bugzilla bug #33187 is now fixed.
1397 2002-12-06 Miguel de Icaza <miguel@ximian.com>
1399 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
1402 * expression.cs (Binary.ResolveOperator): I can only use the
1403 Concat (string, string, string) and Concat (string, string,
1404 string, string) if the child is actually a concatenation of
1407 2002-12-04 Miguel de Icaza <miguel@ximian.com>
1409 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
1410 context where we need a 2-character lookahead.
1412 * pending.cs (PendingImplementation): Rework so we can keep track
1413 of interface types all the time, and flag those which were
1414 implemented by parents as optional.
1416 2002-12-03 Miguel de Icaza <miguel@ximian.com>
1418 * expression.cs (Binary.ResolveOperator): Use
1419 String.Concat(string,string,string) or
1420 String.Concat(string,string,string,string) when possible.
1422 * typemanager: More helper methods.
1425 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
1427 * pending.cs: remove the bogus return from GetMissingInterfaces()
1428 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
1430 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1432 * namespace.cs: avoid duplicated 'using xxx' being added to
1433 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
1434 when we get more than one 'using' statement for the same namespace.
1435 Report a CS0105 warning for it.
1437 2002-11-30 Miguel de Icaza <miguel@ximian.com>
1439 * cs-tokenizer.cs (consume_identifier): use read directly, instead
1440 of calling getChar/putback, uses internal knowledge of it.
1442 (xtoken): Reorder tokenizer so most common patterns are checked
1443 first. This reduces the compilation time in another 5% (from 8.11s
1444 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
1446 The parsing time is 22% of the compilation in mcs, and from that
1447 64% is spent on the tokenization process.
1449 I tried using a binary search for keywords, but this is slower
1450 than the hashtable. Another option would be to do a couple of
1453 * Not use a StringBuilder, instead use an array of chars,
1454 with a set value. Notice that this way we could catch
1455 the 645 error without having to do it *afterwards*.
1457 * We could write a hand-parser to avoid the hashtable
1458 compares altogether.
1460 The identifier consumption process takes 37% of the tokenization
1461 time. Another 15% is spent on is_number. 56% of the time spent
1462 on is_number is spent on Int64.Parse:
1464 * We could probably choose based on the string length to
1465 use Int32.Parse or Int64.Parse and avoid all the 64-bit
1468 Another 3% is spend on wrapping `xtoken' in the `token' function.
1470 Handle 0xa0 as whitespace (#34752)
1472 2002-11-26 Miguel de Icaza <miguel@ximian.com>
1474 * typemanager.cs (IsCLRType): New routine to tell whether a type
1475 is one of the builtin types.
1477 Maybe it needs to use TypeCodes to be faster. Maybe we could use
1478 typecode in more places instead of doing pointer comparissions.
1479 We could leverage some knowledge about the way the typecodes are
1482 New code to cache namespaces in assemblies, it is currently not
1483 invoked, to be used soon.
1485 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
1487 * expression.cs (Binary.ResolveOperator): specially handle
1488 strings, and do not perform user-defined operator overloading for
1491 2002-11-24 Miguel de Icaza <miguel@ximian.com>
1493 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
1494 internalcall as it is a pretty simple operation; Avoid whenever
1495 possible to call Char.IsLetter.
1497 (consume_identifier): Cut by half the number of
1498 hashtable calls by merging the is_keyword and GetKeyword behavior.
1500 Do not short-circuit, because if we do, we
1501 report errors (ie, #if false && true would produce an invalid
1505 2002-11-24 Martin Baulig <martin@ximian.com>
1507 * expression.cs (Cast.TryReduce): If we're in checked syntax,
1508 check constant ranges and report a CS0221. Fixes #33186.
1510 2002-11-24 Martin Baulig <martin@ximian.com>
1512 * cs-parser.jay: Make this work for uninitialized variable
1513 declarations in the `for' initializer. Fixes #32416.
1515 2002-11-24 Martin Baulig <martin@ximian.com>
1517 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
1518 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
1520 2002-11-24 Martin Baulig <martin@ximian.com>
1522 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
1523 argument; if true, we also check for user-defined conversions.
1524 This is only needed if both arguments are of a user-defined type.
1525 Fixes #30443, added test-175.cs.
1526 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
1528 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
1530 2002-11-24 Martin Baulig <martin@ximian.com>
1532 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
1533 function to get the store opcode.
1534 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
1535 only emit the Ldelema if the store opcode is Stobj. You must run
1536 both test-34 and test-167 to test this. Fixes #34529.
1538 2002-11-23 Martin Baulig <martin@ximian.com>
1540 * ecore.cs (Expression.MemberLookup): Added additional
1541 `qualifier_type' argument which is used when we're being called
1542 from MemberAccess.DoResolve() and null if we're called from a
1544 (Expression.MemberLookupFailed): New method to report errors; this
1545 does the CS1540 check and reports the correct error message.
1547 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
1548 argument for the CS1540 check and redone the way how we're dealing
1549 with private members. See the comment in the source code for details.
1550 (FilterWithClosure): Reverted this back to revision 1.197; renamed
1551 `closure_start_type' to `closure_qualifier_type' and check whether
1552 it's not null. It was not this filter being broken, it was just
1553 being called with the wrong arguments.
1555 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
1556 and pass it the correct `qualifier_type'; this also does the error
1559 2002-11-22 Miguel de Icaza <miguel@ximian.com>
1561 * expression.cs (Invocation.EmitParams): If the we are dealing
1562 with a non-built-in value type, load its address as well.
1564 (ArrayCreation): Use a a pretty constant instead
1565 of the hardcoded value 2. Use 6 instead of 2 for the number of
1566 static initializers.
1568 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
1569 because they are not really value types, just glorified integers.
1571 * driver.cs: Do not append .exe, the CSC compiler does not do it.
1573 * ecore.cs: Remove redundant code for enumerations, make them use
1574 the same code path as everything else, fixes the casting issue
1575 with enumerations in Windows.Forms.
1577 * attribute.cs: Do only cast to string if it is a string, the
1578 validation happens later.
1580 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
1581 people upgrade their corlibs.
1583 * ecore.cs: Oops, enumerations were not following the entire code path
1585 2002-11-21 Miguel de Icaza <miguel@ximian.com>
1587 * typemanager.cs (FilterWithClosure): Commented out the test for
1588 1540 in typemanager.cs, as it has problems when accessing
1589 protected methods from a parent class (see test-174.cs).
1591 * attribute.cs (Attribute.ValidateGuid): new method.
1592 (Attribute.Resolve): Use above.
1594 2002-11-19 Miguel de Icaza <miguel@ximian.com>
1596 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
1598 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
1599 handling for enumerations, as we only needed the TypeContainer
1600 functionality to begin with (this is required for the fix below to
1601 work for enums that reference constants in a container class for
1604 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
1606 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
1607 a valid TypeBuilder to perform lookups on.o
1609 * class.cs (InheritableMemberSignatureCompare): Use true in the
1610 call to GetGetMethod and GetSetMethod, because we are comparing
1611 the signature, and we need to get the methods *even* if they are
1614 (PropertyBase.CheckBase): ditto.
1616 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
1617 GotoCase.Resolve): Use Peel on EmpytCasts.
1619 * ecore.cs (EmptyCast): drop child, add Peel method.
1621 2002-11-17 Martin Baulig <martin@ximian.com>
1623 * ecore.cs (EmptyCast.Child): New public property.
1625 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
1626 label resolved to an EmptyCast. Fixes #34162.
1627 (GotoCase.Resolve): Likewise.
1628 (Block.EmitMeta): Likewise.
1630 2002-11-17 Martin Baulig <martin@ximian.com>
1632 * expression.cs (Invocation.BetterConversion): Prefer int over
1633 uint; short over ushort; long over ulong for integer literals.
1634 Use ImplicitConversionExists instead of StandardConversionExists
1635 since we also need to check for user-defined implicit conversions.
1636 Fixes #34165. Added test-173.cs.
1638 2002-11-16 Martin Baulig <martin@ximian.com>
1640 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
1641 with the `true' and `false' literals. Fixes #33151.
1643 2002-11-16 Martin Baulig <martin@ximian.com>
1645 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
1646 October 22nd; don't do the cs1540 check for static members.
1648 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
1649 now using our own filter here and doing the cs1540 check again.
1651 2002-11-16 Martin Baulig <martin@ximian.com>
1653 * support.cs (InternalParameters): Don't crash if we don't have
1654 any fixed parameters. Fixes #33532.
1656 2002-11-16 Martin Baulig <martin@ximian.com>
1658 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
1659 when looking up static methods to make this work on Windows.
1662 2002-11-16 Martin Baulig <martin@ximian.com>
1664 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
1665 a setter rather than using PropertyInfo.CanWrite.
1667 2002-11-15 Nick Drochak <ndrochak@gol.com>
1669 * class.cs: Allow acces to block member by subclasses. Fixes build
1672 2002-11-14 Martin Baulig <martin@ximian.com>
1674 * class.cs (Constructor.Emit): Added the extern/block check.
1677 2002-11-14 Martin Baulig <martin@ximian.com>
1679 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
1680 iteration while looking for indexers, this is needed because the
1681 indexer may have a different name in our base classes. Fixed the
1682 error reporting (no indexers at all, not get accessor, no
1683 overloaded match). Fixes bug #33089.
1684 (IndexerAccess.DoResolveLValue): Likewise.
1686 2002-11-14 Martin Baulig <martin@ximian.com>
1688 * class.cs (PropertyBase.CheckBase): Make this work for multiple
1689 indexers. Fixes the first part of bug #33089.
1690 (MethodSignature.InheritableMemberSignatureCompare): Added support
1693 2002-11-13 Ravi Pratap <ravi@ximian.com>
1695 * attribute.cs (Attribute.Resolve): Catch the
1696 NullReferenceException and report it since it isn't supposed to
1699 2002-11-12 Miguel de Icaza <miguel@ximian.com>
1701 * expression.cs (Binary.EmitBranchable): Also handle the cases for
1702 LogicalOr and LogicalAnd that can benefit from recursively
1703 handling EmitBranchable. The code now should be nice for Paolo.
1705 2002-11-08 Miguel de Icaza <miguel@ximian.com>
1707 * typemanager.cs (LookupType): Added a negative-hit hashtable for
1708 the Type lookups, as we perform quite a number of lookups on
1709 non-Types. This can be removed once we can deterministically tell
1710 whether we have a type or a namespace in advance.
1712 But this might require special hacks from our corlib.
1716 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
1717 and double which avoids a conversion from an integer to a double.
1719 * expression.cs: tiny optimization, avoid calling IsConstant,
1720 because it effectively performs the lookup twice.
1722 2002-11-06 Miguel de Icaza <miguel@ximian.com>
1724 But a bogus return here to keep the semantics of the old code
1725 until the Mono runtime is fixed.
1727 * pending.cs (GetMissingInterfaces): New method used to remove all
1728 the interfaces that are already implemented by our parent
1729 classes from the list of pending methods.
1731 * interface.cs: Add checks for calls after ResolveTypeExpr.
1733 2002-11-05 Miguel de Icaza <miguel@ximian.com>
1735 * class.cs (Class.Emit): Report warning 67: event not used if the
1736 warning level is beyond 3.
1738 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
1739 being a NullLiteral.
1741 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
1744 * class.cs (TypeContainer.GetClassBases): Cover a missing code
1745 path that might fail if a type can not be resolved.
1747 * expression.cs (Binary.Emit): Emit unsigned versions of the
1750 * driver.cs: use error 5.
1752 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
1754 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
1756 2002-11-01 Miguel de Icaza <miguel@ximian.com>
1758 * cs-parser.jay (switch_section): A beautiful patch from Martin
1759 Baulig that fixed 33094.
1761 2002-10-31 Miguel de Icaza <miguel@ximian.com>
1763 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
1764 Check whether the base is abstract and report an error if so.
1766 * expression.cs (IndexerAccess.DoResolveLValue,
1767 IndexerAccess.DoResolve): ditto.
1769 (Invocation.DoResolve): ditto.
1771 (Invocation.FullMethodDesc): Improve the report string.
1773 * statement.cs (Block): Eliminate IsVariableDefined as it is
1774 basically just a wrapper for GetVariableInfo.
1776 * ecore.cs (SimpleName): Use new
1778 * support.cs (ReflectionParamter.ParameterType): We unwrap the
1779 type, as we return the actual parameter ref/unref state on a
1782 2002-10-30 Miguel de Icaza <miguel@ximian.com>
1784 * support.cs: Return proper flags REF/OUT fixing the previous
1787 * expression.cs: Reverted last patch, that was wrong. Is_ref is
1788 not used to mean `ref' but `ref or out' in ParameterReference
1790 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
1791 full type signature instead of calling TypeManger.CSharpName
1794 * support.cs (InternalParameters.ParameterDesc): Do not compare
1795 directly to the modflags, because REF/OUT will actually be bitsets
1798 * delegate.cs (VerifyMethod): Check also the modifiers.
1800 * cs-tokenizer.cs: Fix bug where floating point values with an
1801 exponent where a sign was missing was ignored.
1803 * driver.cs: Allow multiple assemblies to be specified in a single
1806 2002-10-28 Miguel de Icaza <miguel@ximian.com>
1808 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
1809 because identifiers after a parenthesis would end up in this kind
1810 of production, and we needed to desamiguate it for having casts
1813 (UserDefinedType *) xxx
1815 2002-10-24 Miguel de Icaza <miguel@ximian.com>
1817 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
1818 we should set on the Bindingflags.NonPublic, but not turn on
1819 private_ok. private_ok controls whether a Private member is
1820 returned (this is chekced on the filter routine), while the
1821 BindingFlags.NonPublic just controls whether private/protected
1822 will be allowed. This fixes the problem part of the problem of
1823 private properties being allowed to be used in derived classes.
1825 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
1826 so we can call the children DoResolveLValue method (this will
1827 properly signal errors on lvalue assignments to base properties)
1829 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
1830 getter are null, and we have a property info, we know that this
1831 happened because the lookup failed, so we report an error 122 for
1832 protection level violation.
1834 We also silently return if setter and getter are null in the
1835 resolve functions, this condition only happens if we have flagged
1836 the error before. This is the other half of the problem.
1838 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
1839 not have accessibility information, that is why we were returning
1840 true in the filter function in typemanager.cs.
1842 To properly report 122 (property is inaccessible because of its
1843 protection level) correctly, we report this error in ResolveAccess
1844 by failing if both the setter and the getter are lacking (ie, the
1847 DoResolve and DoLResolve have been modified to check for both
1848 setter/getter being null and returning silently, the reason being
1849 that I did not want to put the knowledge about this error in upper
1852 int old = Report.Errors;
1853 x = new PropertyExpr (...);
1854 if (old != Report.Errors)
1859 So the property expr is returned, but it is invalid, so the error
1860 will be flagged during the resolve process.
1862 * class.cs: Remove InheritablePropertySignatureCompare from the
1863 class, as we no longer depend on the property signature to compute
1864 whether it is possible to implement a method or not.
1866 The reason is that calling PropertyInfo.GetGetMethod will return
1867 null (in .NET, in Mono it works, and we should change this), in
1868 cases where the Get Method does not exist in that particular
1873 class X { public virtual int A { get { return 1; } } }
1875 class Z : Y { public override int A { get { return 2; } } }
1877 Would fail in Z because the parent (Y) would not have the property
1878 defined. So we avoid this completely now (because the alternative
1879 fix was ugly and slow), and we now depend exclusively on the
1882 (PropertyBase.CheckBase): Use a method-base mechanism to find our
1883 reference method, instead of using the property.
1885 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
1886 routines are gone now.
1888 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
1889 names, they were incorrectly named.
1891 * cs-tokenizer.cs: Return are more gentle token on failure.
1893 * pending.cs (PendingImplementation.InterfaceMethod): This routine
1894 had an out-of-sync index variable, which caused it to remove from
1895 the list of pending methods the wrong method sometimes.
1897 2002-10-22 Miguel de Icaza <miguel@ximian.com>
1899 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
1900 CanWrite, because those refer to this particular instance of the
1901 property, and do not take into account the fact that we can
1902 override single members of a property.
1904 Constructor requires an EmitContext. The resolution process does
1905 not happen here, but we need to compute the accessors before,
1906 because the resolution does not always happen for properties.
1908 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
1909 subclass, before we did not update this flag, but we did update
1912 (GetAccessors): Drop this routine, as it did not work in the
1913 presence of partially overwritten set/get methods.
1915 Notice that this broke the cs1540 detection, but that will require
1918 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1922 * driver.cs: issue a warning instead of an error if we don't support
1923 debugging for the platform. Also ignore a couple of errors that may
1924 arise when trying to write the symbols. Undo my previous patch.
1926 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1928 * driver.cs: ignore /debug switch except for Unix platforms.
1930 2002-10-23 Nick Drochak <ndrochak@gol.com>
1932 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
1934 2002-10-21 Miguel de Icaza <miguel@ximian.com>
1936 * driver.cs: Do not make mcs-debug conditional, so we do not break
1939 * statement.cs (UsageVector.MergeChildren): I would like Martin to
1940 review this patch. But basically after all the children variables
1941 have been merged, the value of "Breaks" was not being set to
1942 new_breaks for Switch blocks. I think that it should be set after
1943 it has executed. Currently I set this to the value of new_breaks,
1944 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
1945 conservative, but I do not understand this code very well.
1947 I did not break anything in the build, so that is good ;-)
1949 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
1951 2002-10-20 Mark Crichton <crichton@gimp.org>
1953 * cfold.cs: Fixed compile blocker. Really fixed it this time.
1955 2002-10-20 Nick Drochak <ndrochak@gol.com>
1957 * cfold.cs: Fixed compile blocker.
1959 2002-10-20 Miguel de Icaza <miguel@ximian.com>
1961 * driver.cs: I was chekcing the key, not the file.
1963 2002-10-19 Ravi Pratap <ravi@ximian.com>
1965 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
1966 message that we were generating - we just need to silently return
1969 2002-10-19 Miguel de Icaza <miguel@ximian.com>
1971 * class.cs (Event.Define): Change my previous commit, as this
1972 breaks the debugger. This is a temporary hack, as it seems like
1973 the compiler is generating events incorrectly to begin with.
1975 * expression.cs (Binary.ResolveOperator): Added support for
1976 "U operator - (E x, E y)"
1978 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
1981 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
1982 init-only variables, but this path did not take into account that
1983 there might be also instance readonly variables. Correct this
1986 This fixes bug 32253
1988 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
1991 * driver.cs: Change the extension for modules to `netmodule'
1993 * cs-parser.jay: Improved slightly the location tracking for
1994 the debugger symbols.
1996 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
1997 modifiers that were specified instead of the hardcoded value
1998 (FamAndAssem). This was basically ignoring the static modifier,
1999 and others. Fixes 32429.
2001 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
2002 fixed a bug in the process (32476)
2004 * expression.cs (ArrayAccess.EmitAssign): Patch from
2005 hwang_rob@yahoo.ca that fixes bug 31834.3
2007 2002-10-18 Miguel de Icaza <miguel@ximian.com>
2009 * driver.cs: Make the module extension .netmodule.
2011 2002-10-16 Miguel de Icaza <miguel@ximian.com>
2013 * driver.cs: Report an error if the resource file is not found
2014 instead of crashing.
2016 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
2017 false, like Emit does.
2019 2002-10-16 Nick Drochak <ndrochak@gol.com>
2021 * typemanager.cs: Remove unused private member. Also reported mcs
2022 bug to report this as a warning like csc.
2024 2002-10-15 Martin Baulig <martin@gnome.org>
2026 * statement.cs (Statement.Emit): Made this a virtual method; emits
2027 the line number info and calls DoEmit().
2028 (Statement.DoEmit): New protected abstract method, formerly knows
2029 as Statement.Emit().
2031 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
2033 2002-10-11 Miguel de Icaza <miguel@ximian.com>
2035 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
2036 have fixed a remaining problem: not every AddXXXX was adding a
2037 fully qualified name.
2039 Now everyone registers a fully qualified name in the DeclSpace as
2040 being defined instead of the partial name.
2042 Downsides: we are slower than we need to be due to the excess
2043 copies and the names being registered this way.
2045 The reason for this is that we currently depend (on the corlib
2046 bootstrap for instance) that types are fully qualified, because
2047 we dump all the types in the namespace, and we should really have
2048 types inserted into the proper namespace, so we can only store the
2049 basenames in the defined_names array.
2051 2002-10-10 Martin Baulig <martin@gnome.org>
2053 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
2054 from bug #31834, see the bug report for a testcase which is
2057 2002-10-10 Martin Baulig <martin@gnome.org>
2059 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
2060 flow analysis code for this.
2062 * statement.cs (Do, While, For): Tell the flow analysis code about
2064 (FlowBranching.UsageVector): Added support for infinite loops.
2065 (Block.Resolve): Moved the dead code elimination here and use flow
2068 2002-10-09 Miguel de Icaza <miguel@ximian.com>
2070 * class.cs (Field.Define): Catch cycles on struct type
2073 * typemanager.cs (IsUnmanagedtype): Do not recursively check
2074 fields if the fields are static. We only need to check instance
2077 * expression.cs (As.DoResolve): Test for reference type.
2079 * statement.cs (Using.ResolveExpression): Use
2080 ConvertImplicitRequired, not ConvertImplicit which reports an
2082 (Using.ResolveLocalVariableDecls): ditto.
2084 * expression.cs (Binary.ResolveOperator): Report errors in a few
2085 places where we had to.
2087 * typemanager.cs (IsUnmanagedtype): Finish implementation.
2089 2002-10-08 Miguel de Icaza <miguel@ximian.com>
2091 * expression.cs: Use StoreFromPtr instead of extracting the type
2092 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
2094 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
2095 an enumeration value to a System.Enum, but System.Enum is not a
2096 value type, but an class type, so we need to box.
2098 (Expression.ConvertExplicit): One codepath could return
2099 errors but not flag them. Fix this. Fixes #31853
2101 * parameter.cs (Resolve): Do not allow void as a parameter type.
2103 2002-10-06 Martin Baulig <martin@gnome.org>
2105 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
2106 if it's a class type and not a struct. Fixes #31815.
2108 2002-10-06 Martin Baulig <martin@gnome.org>
2110 * statement.cs: Reworked the flow analysis code a bit to make it
2111 usable for dead code elimination.
2113 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2115 * cs-parser.jay: allow empty source files. Fixes bug #31781.
2117 2002-10-04 Miguel de Icaza <miguel@ximian.com>
2119 * expression.cs (ComposedCast.DoResolveType): A quick workaround
2120 to fix the test 165, will investigate deeper.
2122 2002-10-04 Martin Baulig <martin@gnome.org>
2124 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
2125 finally blocks actually work.
2126 (Try.Resolve): We don't need to create a sibling for `finally' if
2127 there is no finally block.
2129 2002-10-04 Martin Baulig <martin@gnome.org>
2131 * class.cs (Constructor.Define): The default accessibility for a
2132 non-default constructor is private, not public.
2134 2002-10-04 Miguel de Icaza <miguel@ximian.com>
2136 * class.cs (Constructor): Make AllowedModifiers public, add
2139 * cs-parser.jay: Perform the modifiers test here, as the
2140 constructor for the Constructor class usually receives a zero
2141 because of the way we create it (first we create, later we
2142 customize, and we were never checking the modifiers).
2144 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
2145 is a version of LookupTypeReflection that includes the type-name
2146 cache. This can be used as a fast path for functions that know
2147 the fully qualified name and are only calling into *.GetType() to
2148 obtain a composed type.
2150 This is also used by TypeManager.LookupType during its type
2153 (LookupType): We now also track the real type name, as sometimes
2154 we can get a quey for the real type name from things like
2155 ComposedCast. This fixes bug 31422.
2157 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
2158 complete type fullname, it does not have to go through the type
2159 resolution system to obtain the composed version of the type (for
2160 obtaining arrays or pointers).
2162 (Conditional.Emit): Use the EmitBoolExpression to
2163 generate nicer code, as requested by Paolo.
2165 (ArrayCreation.CheckIndices): Use the patch from
2166 hwang_rob@yahoo.ca to validate the array initializers.
2168 2002-10-03 Miguel de Icaza <miguel@ximian.com>
2170 * class.cs (ConstructorInitializer.Emit): simplify code by using
2171 Invocation.EmitCall, and at the same time, fix the bugs in calling
2172 parent constructors that took variable arguments.
2174 * ecore.cs (Expression.ConvertNumericExplicit,
2175 Expression.ImplicitNumericConversion): Remove the code that
2176 manually wrapped decimal (InternalTypeConstructor call is now gone
2179 * expression.cs (Cast.TryReduce): Also handle decimal types when
2180 trying to perform a constant fold on the type.
2182 * typemanager.cs (IsUnmanagedtype): Partially implemented.
2184 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
2185 that only turned off an error report, and did nothing else.
2187 2002-10-02 Miguel de Icaza <miguel@ximian.com>
2189 * driver.cs: Handle and ignore /fullpaths
2191 2002-10-01 Miguel de Icaza <miguel@ximian.com>
2193 * expression.cs (Binary.ResolveOperator): Catch the case where
2194 DoNumericPromotions returns true,
2196 (Binary.DoNumericPromotions): Simplify the code, and the tests.
2198 2002-09-27 Miguel de Icaza <miguel@ximian.com>
2200 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
2203 2002-09-26 Miguel de Icaza <miguel@ximian.com>
2205 * ecore.cs (ConvertNumericExplicit): It is not enough that the
2206 conversion exists, but it is also required that the conversion be
2207 performed. This manifested in "(Type64Enum) 2".
2209 * class.cs (TypeManager.AddMethod): The fix is not to change
2210 AddEnum, because that one was using a fully qualified name (every
2211 DeclSpace derivative does), but to change the AddMethod routine
2212 that was using an un-namespaced name. This now correctly reports
2213 the duplicated name.
2215 Revert patch until I can properly fix it. The issue
2216 is that we have a shared Type space across all namespaces
2217 currently, which is wrong.
2219 Options include making the Namespace a DeclSpace, and merge
2220 current_namespace/current_container in the parser.
2222 2002-09-25 Miguel de Icaza <miguel@ximian.com>
2224 * cs-parser.jay: Improve error reporting when we get a different
2225 kind of expression in local_variable_type and
2226 local_variable_pointer_type.
2228 Propagate this to avoid missleading errors being reported.
2230 * ecore.cs (ImplicitReferenceConversion): treat
2231 TypeManager.value_type as a target just like object_type. As
2236 Is valid, and needs to result in the int 1 being boxed before it
2237 is assigned to the value type v.
2239 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
2240 to validate the enumeration name.
2242 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
2243 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
2244 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
2246 * ecore.cs (TryImplicitIntConversion): When doing an
2247 implicit-enumeration-conversion, check if the type is 64-bits and
2248 perform a conversion before passing to EnumConstant.
2250 2002-09-23 Miguel de Icaza <miguel@ximian.com>
2252 * decl.cs (Error_AmbiguousTypeReference); New routine used to
2253 report ambiguous type references. Unlike the MS version, we
2254 report what the ambiguity is. Innovation at work ;-)
2256 (DeclSpace.FindType): Require a location argument to
2257 display when we display an ambiguous error.
2259 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
2261 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
2263 * expression.cs (EmitDynamicInitializers): Apply patch from
2264 hwang_rob@yahoo.ca that fixes the order in which we emit our
2267 2002-09-21 Martin Baulig <martin@gnome.org>
2269 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
2270 delegate takes no arguments.
2272 2002-09-20 Miguel de Icaza <miguel@ximian.com>
2274 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
2277 * expression.cs: Extract the underlying type.
2279 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
2281 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
2283 2002-09-19 Miguel de Icaza <miguel@ximian.com>
2285 * class.cs (TypeContainer.DefineType): We can not use the nice
2286 PackingSize with the size set to 1 DefineType method, because it
2287 will not allow us to define the interfaces that the struct
2290 This completes the fixing of bug 27287
2292 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
2293 means also structs. This fixes part of the problem.
2294 (Expresion.ImplicitReferenceConversionExists): ditto.
2296 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
2297 error if there were no errors reported during the type lookup
2298 process, to avoid duplicates or redundant errors. Without this
2299 you would get an ambiguous errors plus a type not found. We have
2300 beaten the user enough with the first error.
2302 (DeclSparce.FindType): Emit a warning if we have an ambiguous
2305 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
2306 during the resolution process, stop the lookup, this avoids
2307 repeated error reports (same error twice).
2309 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
2311 * typemanager.cs (LookupType): Redo the type lookup code to match
2312 the needs of System.Reflection.
2314 The issue is that System.Reflection requires references to nested
2315 types to begin with a "+" sign instead of a dot. So toplevel
2316 types look like: "NameSpace.TopLevelClass", and nested ones look
2317 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
2320 2002-09-19 Martin Baulig <martin@gnome.org>
2322 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
2323 says that a method always returns or always throws an exception,
2324 don't report the CS0161.
2326 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
2327 set `Returns = new_returns'.
2329 2002-09-19 Martin Baulig <martin@gnome.org>
2331 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
2332 to an enum constant, check for a CS0176.
2334 2002-09-18 Miguel de Icaza <miguel@ximian.com>
2336 * class.cs (TypeContainer.CheckPairedOperators): Now we check
2337 for operators that must be in pairs and report errors.
2339 * ecore.cs (SimpleName.DoResolveType): During the initial type
2340 resolution process, when we define types recursively, we must
2341 check first for types in our current scope before we perform
2342 lookups in the enclosing scopes.
2344 * expression.cs (MakeByteBlob): Handle Decimal blobs.
2346 (Invocation.VerifyArgumentsCompat): Call
2347 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
2348 I thought we were supposed to always call this, but there are a
2349 few places in the code where we dont do it.
2351 2002-09-17 Miguel de Icaza <miguel@ximian.com>
2353 * driver.cs: Add support in -linkres and -resource to specify the
2354 name of the identifier.
2356 2002-09-16 Miguel de Icaza <miguel@ximian.com>
2358 * ecore.cs (StandardConversionExists): Sync with the conversion
2359 code: allow anything-* to void* conversions.
2361 (FindMostSpecificSource): Use an Expression argument
2362 instead of a Type, because we might be handed over a Literal which
2363 gets a few more implicit conversions that plain types do not. So
2364 this information was being lost.
2366 Also, we drop the temporary type-holder expression when not
2369 2002-09-17 Martin Baulig <martin@gnome.org>
2371 * class.cs (PropertyBase.CheckBase): Don't check the base class if
2372 this is an explicit interface implementation.
2374 2002-09-17 Martin Baulig <martin@gnome.org>
2376 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
2377 different `IndexerName' attributes.
2379 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
2380 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
2381 virtual CommonResolve().
2383 2002-09-16 Miguel de Icaza <miguel@ximian.com>
2385 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
2386 and convert that to the UnderlyingType.
2388 * statement.cs (Foreach.Resolve): Indexers are just like variables
2389 or PropertyAccesses.
2391 * cs-tokenizer.cs (consume_string): Track line numbers and columns
2392 inside quoted strings, we were not doing this before.
2394 2002-09-16 Martin Baulig <martin@gnome.org>
2396 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
2397 resolve it. This is needed for the definite assignment check of the
2398 instance expression, fixes bug #29846.
2399 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
2401 2002-09-16 Nick Drochak <ndrochak@gol.com>
2403 * parameter.cs: Fix compile error. Cannot reference static member
2404 from an instance object. Is this an mcs bug?
2406 2002-09-14 Martin Baulig <martin@gnome.org>
2408 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
2409 multiple times. Fixes bug #30295, added test-166.cs.
2411 2002-09-14 Martin Baulig <martin@gnome.org>
2413 * statement.cs (Block.Emit): Don't emit unreachable code.
2414 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
2416 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
2418 2002-09-14 Martin Baulig <martin@gnome.org>
2420 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
2423 2002-09-14 Martin Baulig <martin@gnome.org>
2425 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
2426 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
2427 be false on the ms runtime.
2429 2002-09-13 Martin Baulig <martin@gnome.org>
2431 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
2432 the CS0038 error message.
2434 2002-09-12 Miguel de Icaza <miguel@ximian.com>
2436 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
2437 constant inside, return it.
2439 2002-09-12 Martin Baulig <martin@gnome.org>
2441 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
2442 implicit conversion can be done between enum types.
2444 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
2445 check whether an implicit conversion to the current enum's UnderlyingType
2446 exists and report an error if not.
2448 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
2449 without debugging support.
2451 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
2452 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
2454 2002-09-12 Martin Baulig <martin@gnome.org>
2456 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
2458 * ecore.cs (IMemberExpr.DeclaringType): New property.
2459 (SimpleName.SimpleNameResolve): Check whether we're accessing a
2460 nonstatic member of an outer type (CS0038).
2462 2002-09-11 Miguel de Icaza <miguel@ximian.com>
2464 * driver.cs: Activate the using-error detector at warning level
2465 4 (at least for MS-compatible APIs).
2467 * namespace.cs (VerifyUsing): Small buglett fix.
2469 * pending.cs (PendingImplementation): pass the container pointer.
2471 * interface.cs (GetMethods): Allow for recursive definition. Long
2472 term, I would like to move every type to support recursive
2473 definitions, not the current ordering mechanism that we have right
2476 The situation is this: Attributes are handled before interfaces,
2477 so we can apply attributes to interfaces. But some attributes
2478 implement interfaces, we will now handle the simple cases
2479 (recursive definitions will just get an error).
2481 * parameter.cs: Only invalidate types at the end if we fail to
2484 2002-09-09 Martin Baulig <martin@gnome.org>
2486 * ecore.cs (PropertyExpr.Emit): Also check for
2487 TypeManager.system_int_array_get_length so this'll also work when
2488 compiling corlib. Fixes #30003.
2490 2002-09-09 Martin Baulig <martin@gnome.org>
2492 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
2493 and throw an exception if we can't get the type's size. Fixed #30040,
2496 2002-09-09 Martin Baulig <martin@gnome.org>
2498 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
2500 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
2501 context. Fixes bug #30027.
2503 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
2504 virtual functions. Fixes bug #30043, added test-164.cs.
2506 2002-09-08 Ravi Pratap <ravi@ximian.com>
2508 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
2510 2002-09-08 Nick Drochak <ndrochak@gol.com>
2512 * driver.cs: Use an object to get the windows codepage since it's not a
2515 2002-09-08 Miguel de Icaza <miguel@ximian.com>
2517 * statement.cs (For.Emit): for infinite loops (test == null)
2518 return whether there is a break inside, not always "true".
2520 * namespace.cs (UsingEntry): New struct to hold the name of the
2521 using definition, the location where it is defined, and whether it
2522 has been used in a successful type lookup.
2524 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
2529 2002-09-06 Ravi Pratap <ravi@ximian.com>
2531 * attribute.cs : Fix incorrect code which relied on catching
2532 a NullReferenceException to detect a null being passed in
2533 where an object was expected.
2535 2002-09-06 Miguel de Icaza <miguel@ximian.com>
2537 * statement.cs (Try): flag the catch variable as assigned
2539 * expression.cs (Cast): Simplified by using ResolveType instead of
2542 * statement.cs (Catch): Fix bug by using ResolveType.
2544 2002-09-06 Ravi Pratap <ravi@ximian.com>
2546 * expression.cs (BetterConversion): Special case for when we have
2547 a NullLiteral as the argument and we have to choose between string
2548 and object types - we choose string the way csc does.
2550 * attribute.cs (Attribute.Resolve): Catch the
2551 NullReferenceException and report error #182 since the Mono
2552 runtime no more has the bug and having this exception raised means
2553 we tried to select a constructor which takes an object and is
2556 2002-09-05 Ravi Pratap <ravi@ximian.com>
2558 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
2559 message (1502, 1503) when we can't locate a method after overload
2560 resolution. This is much more informative and closes the bug
2563 * interface.cs (PopulateMethod): Return if there are no argument
2564 types. Fixes a NullReferenceException bug.
2566 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
2567 expressions too. Previously we were checking only in one place for
2568 positional arguments leaving out named arguments.
2570 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
2571 type to the enum type is not allowed. Remove code corresponding to
2574 (ConvertNumericExplicit): Allow explicit conversions from
2575 the underlying type to enum type. This precisely follows the spec
2576 and closes a bug filed by Gonzalo.
2578 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2581 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
2583 2002-09-03 Miguel de Icaza <miguel@ximian.com>
2585 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
2586 it was important that we stored the right value after the
2587 reduction in `converted'.
2589 2002-09-04 Martin Baulig <martin@gnome.org>
2591 * location.cs (Location.SymbolDocument): Use full pathnames for the
2594 2002-08-30 Miguel de Icaza <miguel@ximian.com>
2596 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
2597 of the expression resolve mechanism, because that will catch the
2598 SimpleName error failures.
2600 (Conditional): If we can not resolve the
2601 expression, return, do not crash.
2603 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2606 (location): display token name instead of its number.
2608 2002-08-28 Martin Baulig <martin@gnome.org>
2610 * expression.cs (Binary.ResolveOperator): Don't silently return
2611 but return an error if an operator cannot be applied between two
2614 2002-08-28 Martin Baulig <martin@gnome.org>
2616 * class.cs (Constructor.Define): Set the permission attributes
2617 correctly instead of making all constructors public.
2619 2002-08-28 Martin Baulig <martin@gnome.org>
2621 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
2622 for private members before reporting a CS0103; if we find anything,
2625 2002-08-28 Martin Baulig <martin@gnome.org>
2627 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
2628 to check whether `closure_start_type == closure_invocation_type',
2629 we also need to check whether `m.DeclaringType == closure_invocation_type'
2630 before bypassing the permission checks. We might be accessing
2631 protected/private members from the base class.
2632 (TypeManager.RealMemberLookup): Only set private_ok if private
2633 members were requested via BindingFlags.NonPublic.
2635 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
2637 * expression.cs (MemberAccess.ResolveMemberAccess): Set
2638 MethodGroupExpr.IsExplicitImpl if appropriate.
2639 (Invocation.DoResolve): Don't report the CS0120 for explicit
2640 interface implementations.
2642 2002-08-27 Martin Baulig <martin@gnome.org>
2644 * expression.cs (Invocation.DoResolve): If this is a static
2645 method and we don't have an InstanceExpression, we must report
2648 2002-08-25 Martin Baulig <martin@gnome.org>
2650 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
2651 `==' between a valuetype and an object.
2653 2002-08-25 Miguel de Icaza <miguel@ximian.com>
2655 * ecore.cs (TypeExpr): Provide a ToString method.
2657 2002-08-24 Martin Baulig <martin@gnome.org>
2659 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
2660 now called proggie.dbg and it's a binary file.
2662 2002-08-23 Martin Baulig <martin@gnome.org>
2664 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
2666 2002-08-23 Martin Baulig <martin@gnome.org>
2668 * struct.cs (MyStructInfo.ctor): Make this work with empty
2669 structs; it's not allowed to use foreach() on null.
2671 2002-08-23 Martin Baulig <martin@gnome.org>
2673 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
2674 writer the full pathname of the generated assembly.
2676 2002-08-23 Martin Baulig <martin@gnome.org>
2678 * statements.cs (FlowBranching.UsageVector.MergeChildren):
2679 A `finally' block never returns or breaks; improved handling of
2682 2002-08-23 Martin Baulig <martin@gnome.org>
2684 * statement.cs (Throw.Resolve): Allow `throw null'.
2686 2002-08-23 Martin Baulig <martin@gnome.org>
2688 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
2689 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
2690 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
2691 MemberLookup would return a wrong event if this is an explicit
2692 interface implementation and the class has an event with the same
2695 2002-08-23 Martin Baulig <martin@gnome.org>
2697 * statement.cs (Block.AddChildVariableNames): New public method.
2698 (Block.AddChildVariableName): Likewise.
2699 (Block.IsVariableNameUsedInChildBlock): Likewise.
2700 (Block.AddVariable): Check whether a variable name has already
2701 been used in a child block.
2703 * cs-parser.jay (declare_local_variables): Mark all variable names
2704 from the current block as being used in a child block in the
2707 2002-08-23 Martin Baulig <martin@gnome.org>
2709 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
2710 find the symbol writer.
2712 * driver.cs: csc also allows the arguments to /define being
2713 separated by commas, not only by semicolons.
2715 2002-08-23 Martin Baulig <martin@gnome.org>
2717 * interface.cs (Interface.GetMembers): Added static check for events.
2719 2002-08-15 Martin Baulig <martin@gnome.org>
2721 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
2722 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
2724 * ecore.cs (Expression.MemberLookup): Added documentation and explained
2725 why the MethodData.EmitDestructor() change was necessary.
2727 2002-08-20 Martin Baulig <martin@gnome.org>
2729 * class.cs (TypeContainer.FindMembers): Added static check for events.
2731 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
2733 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
2734 use Type.GetEvents(), not Type.FindMembers().
2736 2002-08-20 Martin Baulig <martin@gnome.org>
2738 * decl.cs (MemberCache): Added a special method cache which will
2739 be used for method-only searched. This ensures that a method
2740 search will return a MethodInfo with the correct ReflectedType for
2743 2002-08-20 Martin Baulig <martin@gnome.org>
2745 * decl.cs (DeclSpace.FindMembers): Made this public.
2747 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2749 * delegate.cs: fixed build on windows.
2750 [FIXME: Filed as bug #29150: MCS must report these errors.]
2752 2002-08-19 Ravi Pratap <ravi@ximian.com>
2754 * ecore.cs (StandardConversionExists): Return a false
2755 if we are trying to convert the void type to anything else
2756 since that is not allowed.
2758 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
2759 we flag error 70 in the event an event is trying to be accessed
2760 directly from outside the declaring type.
2762 2002-08-20 Martin Baulig <martin@gnome.org>
2764 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
2765 MemberCache from typemanager.cs to decl.cs.
2767 2002-08-19 Martin Baulig <martin@gnome.org>
2769 * class.cs (TypeContainer): Implement IMemberContainer.
2770 (TypeContainer.DefineMembers): Create the MemberCache.
2771 (TypeContainer.FindMembers): Do better BindingFlags checking; only
2772 return public members if BindingFlags.Public was given, check
2773 whether members are static.
2775 2002-08-16 Martin Baulig <martin@gnome.org>
2777 * decl.cs (DeclSpace.Define): Splitted this in Define and
2778 DefineMembers. DefineMembers is called first and initializes the
2781 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
2782 DefineMembers() on all our DeclSpaces.
2784 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
2785 but call DefineMembers() on all nested interfaces. We call their
2786 Define() in our new Define() function.
2788 * interface.cs (Interface): Implement IMemberContainer.
2789 (Interface.Define): Moved all code except the attribute stuf to
2791 (Interface.DefineMembers): Initialize the member cache.
2793 * typemanager.cs (IMemberFinder): Removed this interface, we don't
2794 need this anymore since we can use MemberCache.FindMembers directly.
2796 2002-08-19 Martin Baulig <martin@gnome.org>
2798 * typemanager.cs (MemberCache): When creating the cache for an
2799 interface type, add all inherited members.
2800 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
2801 to `out bool used_cache' and documented it.
2802 (TypeManager.MemberLookup): If we already used the cache in the first
2803 iteration, we don't need to do the interfaces check.
2805 2002-08-19 Martin Baulig <martin@gnome.org>
2807 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
2808 here from IMemberFinder and don't implement this interface anymore.
2809 (DeclSpace.MemberCache): Moved here from IMemberFinder.
2811 * typemanager.cs (IMemberFinder): This interface is now only used by
2812 classes which actually support the member cache.
2813 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
2814 since we only put DeclSpaces into this Hashtable.
2815 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
2816 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
2818 2002-08-16 Martin Baulig <martin@gnome.org>
2820 * typemanager.cs (ICachingMemberFinder): Removed.
2821 (IMemberFinder.MemberCache): New property.
2822 (TypeManager.FindMembers): Merged this with RealFindMembers().
2823 This function will never be called from TypeManager.MemberLookup()
2824 so we can't use the cache here, just the IMemberFinder.
2825 (TypeManager.MemberLookup_FindMembers): Check whether the
2826 IMemberFinder has a MemberCache and call the cache's FindMembers
2828 (MemberCache): Rewrote larger parts of this yet another time and
2829 cleaned it up a bit.
2831 2002-08-15 Miguel de Icaza <miguel@ximian.com>
2833 * driver.cs (LoadArgs): Support quoting.
2835 (Usage): Show the CSC-like command line arguments.
2837 Improved a few error messages.
2839 2002-08-15 Martin Baulig <martin@gnome.org>
2841 * typemanager.cs (IMemberContainer.Type): New property.
2842 (IMemberContainer.IsInterface): New property.
2844 The following changes are conditional to BROKEN_RUNTIME, which is
2845 defined at the top of the file.
2847 * typemanager.cs (MemberCache.MemberCache): Don't add the base
2848 class'es members, but add all members from TypeHandle.ObjectType
2849 if we're an interface.
2850 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
2851 is the current type.
2852 (MemberCache.CacheEntry.Container): Removed this field.
2853 (TypeHandle.GetMembers): Include inherited members.
2855 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2857 * typemanager.cs: fixed compilation and added a comment on a field that
2860 2002-08-15 Martin Baulig <martin@gnome.org>
2862 * class.cs (ConstructorInitializer.Resolve): In the
2863 Expression.MemberLookup call, use the queried_type as
2866 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
2867 declared' attribute, it's always true.
2868 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
2869 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
2870 temporary wrapper for FindMembers which tells MemberLookup whether
2871 members from the base classes are included in the return value.
2872 This will go away soon.
2873 (TypeManager.MemberLookup): Use this temporary hack here; once the
2874 new MemberCache is completed, we don't need to do the DeclaredOnly
2875 looping here anymore since the MemberCache will take care of this.
2876 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
2877 (MemberCache): When creating the MemberCache for a class, get
2878 members from the current class and all its base classes.
2879 (MemberCache.CacheEntry.Container): New field. This is a
2880 temporary hack until the Mono runtime is fixed to distinguish
2881 between ReflectedType and DeclaringType. It allows us to use MCS
2882 with both the MS runtime and the unfixed Mono runtime without
2883 problems and without accecting performance.
2884 (MemberCache.SearchMembers): The DeclaredOnly looping from
2885 TypeManager.MemberLookup is now done here.
2887 2002-08-14 Martin Baulig <martin@gnome.org>
2889 * statement.cs (MyStructInfo.MyStructInfo): Don't call
2890 Type.GetFields on dynamic types but get the fields from the
2891 corresponding TypeContainer.
2892 (MyStructInfo.GetStructInfo): Added check for enum types.
2894 * typemanager.cs (MemberList.IsSynchronized): Implemented.
2895 (MemberList.SyncRoot): Implemented.
2896 (TypeManager.FilterWithClosure): No need to check permissions if
2897 closure_start_type == closure_invocation_type, don't crash if
2898 closure_invocation_type is null.
2900 2002-08-13 Martin Baulig <martin@gnome.org>
2902 Rewrote TypeContainer.FindMembers to use a member cache. This
2903 gives us a speed increase of about 35% for the self-hosting MCS
2904 build and of about 15-20% for the class libs (both on GNU/Linux).
2906 * report.cs (Timer): New class to get enhanced profiling. This
2907 whole class is "TIMER" conditional since it remarkably slows down
2910 * class.cs (MemberList): New class. This is an IList wrapper
2911 which we're now using instead of passing MemberInfo[]'s around to
2912 avoid copying this array unnecessarily.
2913 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
2914 (ICachingMemberFinder, IMemberContainer): New interface.
2915 (TypeManager.FilterWithClosure): If `criteria' is null, the name
2916 has already been checked, otherwise use it for the name comparision.
2917 (TypeManager.FindMembers): Renamed to RealMemberFinder and
2918 provided wrapper which tries to use ICachingMemberFinder.FindMembers
2919 if possible. Returns a MemberList, not a MemberInfo [].
2920 (TypeHandle): New class, implements IMemberContainer. We create
2921 one instance of this class per type, it contains a MemberCache
2922 which is used to do the member lookups.
2923 (MemberCache): New class. Each instance of this class contains
2924 all members of a type and a name-based hash table.
2925 (MemberCache.FindMembers): This is our new member lookup
2926 function. First, it looks up all members of the requested name in
2927 the hash table. Then, it walks this list and sorts out all
2928 applicable members and returns them.
2930 2002-08-13 Martin Baulig <martin@gnome.org>
2932 In addition to a nice code cleanup, this gives us a performance
2933 increase of about 1.4% on GNU/Linux - not much, but it's already
2934 half a second for the self-hosting MCS compilation.
2936 * typemanager.cs (IMemberFinder): New interface. It is used by
2937 TypeManager.FindMembers to call FindMembers on a TypeContainer,
2938 Enum, Delegate or Interface.
2939 (TypeManager.finder_to_member_finder): New PtrHashtable.
2940 (TypeManager.finder_to_container): Removed.
2941 (TypeManager.finder_to_delegate): Removed.
2942 (TypeManager.finder_to_interface): Removed.
2943 (TypeManager.finder_to_enum): Removed.
2945 * interface.cs (Interface): Implement IMemberFinder.
2947 * delegate.cs (Delegate): Implement IMemberFinder.
2949 * enum.cs (Enum): Implement IMemberFinder.
2951 * class.cs (TypeContainer): Implement IMemberFinder.
2953 2002-08-12 Martin Baulig <martin@gnome.org>
2955 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
2957 2002-08-12 Martin Baulig <martin@gnome.org>
2959 * ecore.cs (ITypeExpression): New interface for expressions which
2961 (TypeExpression): Renamed to TypeLookupExpression.
2962 (Expression.DoResolve): If we're doing a types-only lookup, the
2963 expression must implement the ITypeExpression interface and we
2964 call DoResolveType() on it.
2965 (SimpleName): Implement the new ITypeExpression interface.
2966 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
2967 hack, the situation that we're only looking up types can't happen
2968 anymore when this method is called. Moved the type lookup code to
2969 DoResolveType() and call it.
2970 (SimpleName.DoResolveType): This ITypeExpression interface method
2971 is now doing the types-only lookup.
2972 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
2973 (ResolveFlags): Added MaskExprClass.
2975 * expression.cs (MemberAccess): Implement the ITypeExpression
2977 (MemberAccess.DoResolve): Added support for a types-only lookup
2978 when we're called via ITypeExpression.DoResolveType().
2979 (ComposedCast): Implement the ITypeExpression interface.
2981 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
2982 Expression.Resolve() with ResolveFlags.Type instead.
2984 2002-08-12 Martin Baulig <martin@gnome.org>
2986 * interface.cs (Interface.Define): Apply attributes.
2988 * attribute.cs (Attribute.ApplyAttributes): Added support for
2989 interface attributes.
2991 2002-08-11 Martin Baulig <martin@gnome.org>
2993 * statement.cs (Block.Emit): Only check the "this" variable if we
2994 do not always throw an exception.
2996 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
2997 whether the property has a set accessor.
2999 2002-08-11 Martin Baulig <martin@gnome.org>
3001 Added control flow analysis support for structs.
3003 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
3004 with control flow analysis turned off.
3005 (IVariable): New interface.
3006 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
3007 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
3008 (FieldExpr.DoResolve): Resolve the instance expression with flow
3009 analysis turned off and do the definite assignment check after the
3010 resolving when we know what the expression will resolve to.
3012 * expression.cs (LocalVariableReference, ParameterReference):
3013 Implement the new IVariable interface, only call the flow analysis
3014 code if ec.DoFlowAnalysis is true.
3015 (This): Added constructor which takes a Block argument. Implement
3016 the new IVariable interface.
3017 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
3018 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
3019 This does the definite assignment checks for struct members.
3021 * class.cs (Constructor.Emit): If this is a non-static `struct'
3022 constructor which doesn't have any initializer, call
3023 Block.AddThisVariable() to tell the flow analysis code that all
3024 struct elements must be initialized before control returns from
3027 * statement.cs (MyStructInfo): New public class.
3028 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
3029 argument to this indexer. If non-zero, check an individual struct
3030 member, not the whole struct.
3031 (FlowBranching.CheckOutParameters): Check struct members.
3032 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
3033 overloaded versions of these methods which take an additional
3034 `int field_idx' argument to check struct members.
3035 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
3036 overloaded versions of these methods which take an additional
3037 `string field_name' argument to check struct member.s
3038 (VariableInfo): Implement the IVariable interface.
3039 (VariableInfo.StructInfo): New public property. Returns the
3040 MyStructInfo instance of the variable if it's a struct or null.
3041 (Block.AddThisVariable): New public method. This is called from
3042 Constructor.Emit() for non-static `struct' constructor which do
3043 not have any initializer. It creates a special variable for the
3044 "this" instance variable which will be checked by the flow
3045 analysis code to ensure that all of the struct's fields are
3046 initialized before control returns from the constructor.
3047 (UsageVector): Added support for struct members. If a
3048 variable/parameter is a struct with N members, we reserve a slot
3049 in the usage vector for each member. A struct is considered fully
3050 initialized if either the struct itself (slot 0) or all its
3051 members are initialized.
3053 2002-08-08 Martin Baulig <martin@gnome.org>
3055 * driver.cs (Driver.MainDriver): Only report an error CS5001
3056 if there were no compilation errors.
3058 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
3059 `UnsafeContext' property to determine whether the parent is in
3060 unsafe context rather than checking the parent's ModFlags:
3061 classes nested in an unsafe class are unsafe as well.
3063 2002-08-08 Martin Baulig <martin@gnome.org>
3065 * statement.cs (UsageVector.MergeChildren): Distinguish between
3066 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
3067 we return. Added test17() and test18() to test-154.cs.
3069 2002-08-08 Martin Baulig <martin@gnome.org>
3071 * typemanager.cs (TypeManager.FilterWithClosure): If we have
3072 Family access, make sure the invoking type isn't a subclass of the
3073 queried type (that'd be a CS1540).
3075 * ecore.cs (Expression.MemberLookup): Added overloaded version of
3076 this method which takes an additional `Type invocation_type'.
3078 * expression.cs (BaseAccess.DoResolve): Use the base type as
3079 invocation and query type.
3080 (MemberAccess.DoResolve): If the lookup failed and we're about to
3081 report a CS0122, try a lookup with the ec.ContainerType - if this
3082 succeeds, we must report a CS1540.
3084 2002-08-08 Martin Baulig <martin@gnome.org>
3086 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
3087 (MethodGroupExpr): Implement the IMemberExpr interface.
3089 * expression (MemberAccess.ResolveMemberAccess): No need to have
3090 any special code for MethodGroupExprs anymore, they're now
3093 2002-08-08 Martin Baulig <martin@gnome.org>
3095 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
3096 Family, FamANDAssem and FamORAssem permissions.
3097 (TypeManager.IsSubclassOrNestedChildOf): New public method.
3099 2002-08-08 Martin Baulig <martin@gnome.org>
3101 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
3102 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
3105 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
3107 * driver.cs: implemented /resource option to embed managed resources.
3109 2002-08-07 Martin Baulig <martin@gnome.org>
3111 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
3112 (FieldBase.HasFieldInitializer): New public property.
3113 (FieldBase.GetInitializerExpression): New public method. Resolves and
3114 returns the field initializer and makes sure it is only resolved once.
3115 (TypeContainer.EmitFieldInitializers): Call
3116 FieldBase.GetInitializerExpression to get the initializer, this ensures
3117 that it isn't resolved multiple times.
3119 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
3120 the resolving process (SimpleName/MemberLookup) that we're currently
3121 emitting a field initializer (which must not access any instance members,
3122 this is an error CS0236).
3124 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
3125 argument, if the `IsFieldInitializer' flag is set, we must report and
3126 error CS0236 and not an error CS0120.
3128 2002-08-07 Martin Baulig <martin@gnome.org>
3130 * ecore.cs (IMemberExpr): New public interface.
3131 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
3132 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
3133 if the expression is an IMemberExpr.
3135 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
3136 to be null, implicitly default to `this' if we're non-static in
3137 this case. Simplified the code a lot by using the new IMemberExpr
3138 interface. Also fixed bug #28176 here.
3140 2002-08-06 Martin Baulig <martin@gnome.org>
3142 * cs-parser.jay (SimpleLookup): Removed. We need to create
3143 ParameterReferences during semantic analysis so that we can do a
3144 type-only search when resolving Cast, TypeOf and SizeOf.
3145 (block): Pass the `current_local_parameters' to the Block's
3148 * class.cs (ConstructorInitializer): Added `Parameters parameters'
3149 argument to the constructor.
3150 (ConstructorInitializer.Resolve): Create a temporary implicit
3151 block with the parameters.
3153 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
3154 references here if we aren't doing a type-only search.
3156 * statement.cs (Block): Added constructor which takes a
3157 `Parameters parameters' argument.
3158 (Block.Parameters): New public property.
3160 * support.cs (InternalParameters.Parameters): Renamed `parameters'
3161 to `Parameters' and made it public readonly.
3163 2002-08-06 Martin Baulig <martin@gnome.org>
3165 * ecore.cs (Expression.Warning): Made this public as well.
3167 * report.cs (Report.Debug): Print the contents of collections.
3169 2002-08-06 Martin Baulig <martin@gnome.org>
3171 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
3172 used to tell Resolve() which kinds of expressions it may return.
3173 (Expression.Resolve): Added overloaded version of this method which
3174 takes a `ResolveFlags flags' argument. This can be used to tell
3175 Resolve() which kinds of expressions it may return. Reports a
3177 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
3178 ResolveFlags.SimpleName.
3179 (Expression.Error118): Added overloaded version of this method which
3180 takes a `ResolveFlags flags' argument. It uses the flags to determine
3181 which kinds of expressions are allowed.
3183 * expression.cs (Argument.ResolveMethodGroup): New public method.
3184 Resolves an argument, but allows a MethodGroup to be returned.
3185 This is used when invoking a delegate.
3187 * TODO: Updated a bit.
3189 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3191 Fixed compilation with csc.
3193 * ecore.cs: Expression.Error made public. Is this correct? Should
3194 Warning be made public too?
3196 * expression.cs: use ea.Location instead of ea.loc.
3197 [FIXME: Filed as bug #28607: MCS must report these errors.]
3199 2002-08-06 Martin Baulig <martin@gnome.org>
3201 * ecore.cs (Expression.loc): Moved the location here instead of
3202 duplicating it in all derived classes.
3203 (Expression.Location): New public property.
3204 (Expression.Error, Expression.Warning): Made them non-static and
3205 removed the location argument.
3206 (Expression.Warning): Added overloaded version which takes an
3207 `int level' argument.
3208 (Expression.Error118): Make this non-static and removed the
3209 expression and location arguments.
3210 (TypeExpr): Added location argument to the constructor.
3212 * expression.cs (StaticCallExpr): Added location argument to
3214 (Indirection, PointerArithmetic): Likewise.
3215 (CheckedExpr, UnCheckedExpr): Likewise.
3216 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
3217 (StringPtr): Likewise.
3220 2002-08-05 Martin Baulig <martin@gnome.org>
3222 * expression.cs (BaseAccess.DoResolve): Actually report errors.
3224 * assign.cs (Assign.DoResolve): Check whether the source
3225 expression is a value or variable.
3227 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
3228 while resolving the corresponding blocks.
3230 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
3231 an error, don't silently return null.
3233 * statement.cs (Block.AddVariable): Do the error reporting here
3234 and distinguish between CS0128 and CS0136.
3235 (Block.DoResolve): Report all unused labels (warning CS0164).
3236 (LabeledStatement): Pass the location to the constructor.
3237 (LabeledStatement.HasBeenReferenced): New property.
3238 (LabeledStatement.Resolve): Set it to true here.
3240 * statement.cs (Return.Emit): Return success even after reporting
3241 a type mismatch error (CS0126 or CS0127), this is what csc does and
3242 it avoids confusing the users with any consecutive errors.
3244 2002-08-05 Martin Baulig <martin@gnome.org>
3246 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
3248 * const.cs (Const.LookupConstantValue): Catch circular definitions.
3250 * expression.cs (MemberAccess.DoResolve): Silently return if an
3251 error has already been reported.
3253 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
3254 error has already been reported.
3256 2002-08-05 Martin Baulig <martin@gnome.org>
3258 * statement.cs (UsageVector): Only initialize the `parameters'
3259 vector if we actually have any "out" parameters.
3261 2002-08-05 Martin Baulig <martin@gnome.org>
3263 * expression.cs (Binary.ResolveOperator): When combining delegates,
3264 they must have the same type.
3266 2002-08-05 Martin Baulig <martin@gnome.org>
3268 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
3269 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
3270 work with the ms runtime and we also don't need it: if we're a
3271 PropertyBuilder and not in the `indexer_arguments' hash, then we
3272 are a property and not an indexer.
3274 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
3275 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
3276 since the latter one doesn't work with the ms runtime.
3278 2002-08-03 Martin Baulig <martin@gnome.org>
3280 Fixed bugs #27998 and #22735.
3282 * class.cs (Method.IsOperator): New public field.
3283 (Method.CheckBase): Report CS0111 if there's already a method
3284 with the same parameters in the current class. Report CS0508 when
3285 attempting to change the return type of an inherited method.
3286 (MethodData.Emit): Report CS0179 if a method doesn't have a body
3287 and it's not marked abstract or extern.
3288 (PropertyBase): New abstract base class for Property and Indexer.
3289 (PropertyBase.CheckBase): Moved here from Property and made it work
3291 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
3292 the same so we can reuse it there.
3293 (Property, Indexer): Derive from PropertyBase.
3294 (MethodSignature.inheritable_property_signature_filter): New delegate
3295 to find properties and indexers.
3297 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
3298 argument and improved error reporting.
3300 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
3301 EmptyReadOnlyParameters and made it a property.
3303 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
3304 version of this method which takes a `PropertyInfo indexer'.
3305 (TypeManager.RegisterIndexer): New method.
3307 * class.cs: Added myself as author of this file :-)
3309 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3311 * class.cs: fixed compilation on windoze.
3313 2002-08-03 Martin Baulig <martin@gnome.org>
3315 * interface.cs (Interface.GetInterfaceBases): Check whether all
3316 base interfaces are at least as accessible than the current one.
3318 * class.cs (TypeContainer.GetClassBases): Check whether base types
3319 are at least as accessible than the current type.
3320 (TypeContainer.AsAccessible): Implemented and made non-static.
3321 (MemberBase.CheckParameters): Report errors if the accessibility
3324 * delegate.cs (Delegate.Delegate): The default visibility is
3325 internal for top-level types and private for nested types.
3326 (Delegate.Define): Report errors if the accessibility checks fail.
3328 * enum.cs (Enum.Enum): The default visibility is internal for
3329 top-level types and private for nested types.
3330 (Enum.DefineType): Compute the correct visibility.
3332 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
3333 function which takes a `bool is_toplevel' instead of a TypeContainer.
3335 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
3338 2002-08-02 Martin Baulig <martin@gnome.org>
3340 * expression.cs (LocalVariableReferenc): Added constructor which
3341 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
3342 (LocalVariableReference.IsReadOnly): New property.
3343 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
3344 variable is readonly, use our own readonly flag to do this; you can
3345 use the new constructor to get a writable reference to a read-only
3348 * cs-parser.jay (foreach_statement, using_statement): Get a writable
3349 reference to the local variable.
3351 2002-08-01 Miguel de Icaza <miguel@ximian.com>
3353 * rootcontext.cs (ResolveCore): Also include System.Exception
3355 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
3356 we reach an EmptyStatement.
3358 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
3361 * expression.cs (Binary.ResolveOperator): Check error result in
3364 use brtrue/brfalse directly and avoid compares to null.
3366 2002-08-02 Martin Baulig <martin@gnome.org>
3368 * class.cs (TypeContainer.Define): Define all nested interfaces here.
3369 Fixes bug #28407, added test-155.cs.
3371 2002-08-01 Martin Baulig <martin@gnome.org>
3373 * class.cs (Event.EmitDefaultMethod): Make this work with static
3374 events. Fixes #28311, added verify-3.cs.
3376 2002-08-01 Martin Baulig <martin@gnome.org>
3378 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
3379 `is_disposable' fields.
3380 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
3381 `hm.is_disposable' if we're using the collection pattern.
3382 (Foreach.EmitCollectionForeach): Use the correct type for the
3383 enumerator's local variable, only emit the try/finally block if
3384 necessary (fixes #27713).
3386 2002-08-01 Martin Baulig <martin@gnome.org>
3388 * ecore.cs (Expression.report118): Renamed to Error118 and made
3391 * statement.cs (Throw.Resolve): Check whether the expression is of
3392 the correct type (CS0118) and whether the type derives from
3393 System.Exception (CS0155).
3394 (Catch.Resolve): New method. Do the type lookup here and check
3395 whether it derives from System.Exception (CS0155).
3396 (Catch.CatchType, Catch.IsGeneral): New public properties.
3398 * typemanager.cs (TypeManager.exception_type): Added.
3400 2002-07-31 Miguel de Icaza <miguel@ximian.com>
3402 * driver.cs: Updated About function.
3404 2002-07-31 Martin Baulig <martin@gnome.org>
3406 Implemented Control Flow Analysis.
3408 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
3409 (EmitContext.CurrentBranching): Added.
3410 (EmitContext.StartFlowBranching): Added.
3411 (EmitContext.EndFlowBranching): Added.
3412 (EmitContext.KillFlowBranching): Added.
3413 (EmitContext.IsVariableAssigned): Added.
3414 (EmitContext.SetVariableAssigned): Added.
3415 (EmitContext.IsParameterAssigned): Added.
3416 (EmitContext.SetParameterAssigned): Added.
3417 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
3418 Added control flow analysis stuff here.
3420 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
3421 resolve the expression as lvalue.
3422 (LocalVariableReference.DoResolve): Check whether the variable has
3423 already been assigned.
3424 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
3425 the parameter as assigned here.
3426 (ParameterReference.DoResolve): Check whether the parameter has already
3428 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
3429 expression as lvalue.
3431 * statement.cs (FlowBranching): New class for the flow analysis code.
3432 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
3433 (LabeledStatement.IsDefined): New public property.
3434 (LabeledStatement.AddUsageVector): New public method to tell flow
3435 analyis that the label may be reached via a forward jump.
3436 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
3438 (VariableInfo.Number): New public field. This is used by flow analysis
3439 to number all locals of a block.
3440 (Block.CountVariables): New public property. This is the number of
3441 local variables in this block (including the locals from all parent
3443 (Block.EmitMeta): Number all the variables.
3445 * statement.cs: Added flow analysis support to all classes.
3447 2002-07-31 Martin Baulig <martin@gnome.org>
3449 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
3450 To get debugging messages, compile mcs with /define:MCS_DEBUG and
3451 then use this argument.
3453 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
3455 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
3456 use this to specify /define options.
3458 2002-07-29 Martin Baulig <martin@gnome.org>
3460 * statement.cs (Fixed): Moved all code that does variable lookups
3461 and resolvings from Emit to Resolve.
3463 * statement.cs (For): Moved all code that does variable lookups
3464 and resolvings from Emit to Resolve.
3466 * statement.cs (Using): Moved all code that does variable lookups
3467 and resolvings from Emit to Resolve.
3469 2002-07-29 Martin Baulig <martin@gnome.org>
3471 * attribute.cs (Attribute.Resolve): Explicitly catch a
3472 System.NullReferenceException when creating the
3473 CustromAttributeBuilder and report a different warning message.
3475 2002-07-29 Martin Baulig <martin@gnome.org>
3477 * support.cs (ParameterData.ParameterName): Added method to
3478 get the name of a parameter.
3480 * typemanager.cs (TypeManager.IsValueType): New public method.
3482 2002-07-29 Martin Baulig <martin@gnome.org>
3484 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
3485 is a flag which specifies that it's either ref or out.
3486 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
3487 the out parameter to `out Parameter.Modifier mod', also set the
3488 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
3490 * support.cs (InternalParameters.ParameterModifier): Distinguish
3491 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
3492 Parameter.Modifier.ISBYREF flag if it's either ref or out.
3494 * expression.cs (Argument.GetParameterModifier): Distinguish
3495 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
3496 Parameter.Modifier.ISBYREF flag if it's either ref or out.
3498 2002-07-29 Martin Baulig <martin@gnome.org>
3500 * expression.cs (ParameterReference.ParameterReference): Added
3501 `Location loc' argument to the constructor.
3503 * cs-parser.jay: Pass location to ParameterReference.
3505 2002-07-28 Miguel de Icaza <miguel@ximian.com>
3507 * statement.cs (Try): Initialize the location.
3509 * cs-parser.jay: pass location to Try.
3511 * expression.cs (Unary.Reduce): Change the prototype to return
3512 whether a constant fold could be performed or not. The result is
3513 returned in an out parameters. In the case of Indirection and
3514 AddressOf, we want to perform the full tests.
3516 2002-07-26 Miguel de Icaza <miguel@ximian.com>
3518 * statement.cs (Statement.Emit): Flag dead code.
3520 2002-07-27 Andrew Birkett <andy@nobugs.org>
3522 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
3524 2002-07-27 Martin Baulig <martin@gnome.org>
3526 * class.cs (MethodData.Define): Put back call to
3527 TypeManager.AddMethod(), accidentally commented this out.
3529 * report.cs (Debug): New public method to print debugging information,
3530 this is `[Conditional ("DEBUG")]'.
3532 2002-07-26 Martin Baulig <martin@gnome.org>
3534 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
3535 (switch_statement): Push the current_block to the switch_stack and
3536 pop it again when we're done with the switch.
3537 (switch_section): The new block is a child of the current_block.
3538 Fixes bug #24007, added test-152.cs.
3540 2002-07-27 Martin Baulig <martin@gnome.org>
3542 * expression.cs (Invocation.EmitArguments): When calling a varargs
3543 function with only its fixed arguments, we need to pass an empty
3546 2002-07-27 Martin Baulig <martin@gnome.org>
3548 Mono 0.13 has been released.
3550 2002-07-25 Miguel de Icaza <miguel@ximian.com>
3552 * driver.cs: Rename --resource to --linkres, because that is what
3553 we do currently, we dont support --resource yet.
3555 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
3557 2002-07-25 Martin Baulig <martin@gnome.org>
3559 * class.cs (MethodData): New public class. This is a `method builder'
3560 class for a method or one accessor of a Property/Indexer/Event.
3561 (MethodData.GetMethodFlags): Moved here from MemberBase.
3562 (MethodData.ApplyAttributes): Likewise.
3563 (MethodData.ApplyObsoleteAttribute): Likewise.
3564 (MethodData.ApplyConditionalAttribute): Likewise.
3565 (MethodData.ApplyDllImportAttribute): Likewise.
3566 (MethodData.CheckAbstractAndExternal): Likewise.
3567 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
3568 (MethodData.Emit): Formerly known as Method.Emit().
3569 (MemberBase): Moved everything which was specific to a single
3570 accessor/method to MethodData.
3571 (Method): Create a new MethodData and call Define() and Emit() on it.
3572 (Property, Indexer, Event): Create a new MethodData objects for each
3573 accessor and call Define() and Emit() on them.
3575 2002-07-25 Martin Baulig <martin@gnome.org>
3577 Made MethodCore derive from MemberBase to reuse the code from there.
3578 MemberBase now also checks for attributes.
3580 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
3581 (MemberBase.GetMethodFlags): Moved here from class Method and marked
3583 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
3584 `CallingConventions cc' and `Attributes opt_attrs' arguments.
3585 (MemberBase.ApplyAttributes): New virtual method; applies the
3586 attributes to a method or accessor.
3587 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
3588 (MemberBase.ApplyConditionalAttribute): Likewise.
3589 (MemberBase.ApplyDllImportAttribute): Likewise.
3590 (MemberBase.CheckAbstractAndExternal): Likewise.
3591 (MethodCore.ParameterTypes): This is now a property instead of a
3592 method, it's initialized from DoDefineParameters().
3593 (MethodCore.ParameterInfo): Removed the set accessor.
3594 (MethodCore.DoDefineParameters): New protected virtual method to
3595 initialize ParameterTypes and ParameterInfo.
3596 (Method.GetReturnType): We can now simply return the MemberType.
3597 (Method.GetMethodFlags): Override the MemberBase version and add
3598 the conditional flags.
3599 (Method.CheckBase): Moved some code from Define() here, call
3600 DoDefineParameters() here.
3601 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
3602 here to avoid some larger code duplication.
3603 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
3604 ensure that abstract and external accessors don't declare a body.
3606 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
3607 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
3608 lookup in the attribute's parent classes, so we need to abort as soon
3609 as we found the first match.
3610 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
3611 the attribute has no arguments.
3613 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
3616 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3618 * cs-parser.jay: reverted previous patch.
3620 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3622 * cs-parser.jay: fixed bug #22119.
3624 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3626 * attribute.cs: fixed compilation. The error was:
3627 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
3628 be assigned to before control leaves the current method."
3629 [FIXME: Filed as bug #28186: MCS must report this error.]
3631 2002-07-25 Martin Baulig <martin@gnome.org>
3633 * attribute.cs (Attribute.Conditional_GetConditionName): New static
3634 method to pull the condition name ouf of a Conditional attribute.
3635 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
3636 the obsolete message and error flag out of an Obsolete attribute.
3638 * class.cs (Method.GetMethodFlags): New public method to get the
3639 TypeManager.MethodFlags for this method.
3640 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
3642 (Method.Define): Get and apply the Obsolete and Conditional attributes;
3643 if we're overriding a virtual function, set the new private variable
3644 `parent_method'; call the new TypeManager.AddMethod().
3646 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
3647 the MethodBuilder and the Method in a PtrHashtable.
3648 (TypeManager.builder_to_method): Added for this purpose.
3649 (TypeManager.MethodFlags): Added IsObsoleteError.
3650 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
3651 Obsolete and Conditional arguments in MethodBuilders. If we discover
3652 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
3653 the message from the attribute.
3655 2002-07-24 Martin Baulig <martin@gnome.org>
3657 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
3658 preprocessor directives, ensure that the argument to #define/#undef is
3659 exactly one identifier and that it's actually an identifier.
3661 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
3664 2002-07-24 Martin Baulig <martin@gnome.org>
3666 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
3667 initialize it to TypeManager.object_type in the constructor.
3668 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
3669 of the `hm.get_current' method if we're using the collection pattern.
3670 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
3671 for the explicit conversion to make it work when we're using the collection
3672 pattern and the `Current' property has a different return type than `object'.
3675 2002-07-24 Martin Baulig <martin@gnome.org>
3677 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
3678 does not match, but don't report any errors. This method is called in
3679 order for all methods in a MethodGroupExpr until a matching method is
3680 found, so we don't want to bail out if the first method doesn't match.
3681 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
3682 matches, report the 123. Fixes #28070.
3684 2002-07-24 Martin Baulig <martin@gnome.org>
3686 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
3687 TypeManager.TypeToCoreType() to the top of the method so the
3688 following equality checks will work. Fixes #28107.
3690 2002-07-24 Martin Baulig <martin@gnome.org>
3692 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
3693 operand is of type uint, and the other operand is of type sbyte,
3694 short or int, the operands are converted to type long." -
3695 Actually do what this comment already told us. Fixes bug #28106,
3698 2002-07-24 Martin Baulig <martin@gnome.org>
3700 * class.cs (MethodBase): New abstract class. This is now a base
3701 class for Property, Indexer and Event to avoid some code duplication
3702 in their Define() and DefineMethods() methods.
3703 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
3704 generic methods for Define() and DefineMethods().
3705 (FieldBase): Derive from MemberBase, not MemberCore.
3706 (Property): Derive from MemberBase, not MemberCore.
3707 (Property.DefineMethod): Moved all the code from this method to the
3708 new MethodBase.DefineAccessor(), just call it with appropriate
3710 (Property.Define): Call the new Property.DoDefine(), this does some
3711 sanity checks and we don't need to duplicate the code everywhere.
3712 (Event): Derive from MemberBase, not MemberCore.
3713 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
3714 accessors, this will also make them work with interface events.
3715 (Indexer): Derive from MemberBase, not MemberCore.
3716 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
3717 (Indexer.Define): Use the new MethodBase functions.
3719 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
3720 argument to the constructor.
3721 (Interface.FindMembers): Added support for interface events.
3722 (Interface.PopluateEvent): Implemented.
3724 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
3726 2002-07-22 Miguel de Icaza <miguel@ximian.com>
3728 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
3729 but this is required to check for a method name being the same as
3730 the containing class.
3734 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3736 * interface.cs: initialize variable.
3738 2002-07-23 Martin Baulig <martin@gnome.org>
3740 Implemented the IndexerName attribute in interfaces.
3742 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
3743 name if this is an explicit interface implementation.
3744 (Indexer.InterfaceIndexerName): New public variable. If we're
3745 implementing an interface indexer, this is the IndexerName in that
3746 interface. Otherwise, it's the IndexerName.
3747 (Indexer.DefineMethod): If we're implementing interface indexer,
3748 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
3749 and Pending.ImplementIndexer methods.
3750 (Indexer.Define): Also define the PropertyBuilder if we're
3751 implementing an interface indexer and this is neither an explicit
3752 interface implementation nor do the IndexerName match the one in
3755 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
3756 If a method is defined here, then we always need to create a proxy
3757 for it. This is used when implementing interface indexers.
3758 (Pending.IsInterfaceIndexer): New public method.
3759 (Pending.ImplementIndexer): New public method.
3760 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
3761 This is used when implementing interface indexers to define a proxy
3763 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
3764 define a proxy if necessary.
3766 * interface.cs (Interface.IndexerName): New public variable.
3767 (Interface.PopulateIndexer): Set the IndexerName.
3768 (Interface.DefineIndexers): New private method. Populate all the
3769 indexers and make sure their IndexerNames match.
3771 * typemanager.cs (IndexerPropertyName): Added support for interface
3774 2002-07-22 Martin Baulig <martin@gnome.org>
3776 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
3777 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
3778 ret if HasReturnLabel.
3779 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
3782 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
3783 and set the ec.LoopBeginTryCatchLevel.
3784 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
3785 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
3786 the current ec.TryCatchLevel, the branch goes out of an exception
3787 block. In this case, we need to use Leave and not Br.
3789 2002-07-22 Martin Baulig <martin@gnome.org>
3791 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
3792 block unless the block does not always return or it is contained in
3793 another try { ... } catch { ... } block. Fixes bug #26506.
3794 Added verify-1.cs to the test suite.
3796 2002-07-22 Martin Baulig <martin@gnome.org>
3798 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
3799 then we do not always return. Fixes bug #24985.
3801 2002-07-22 Martin Baulig <martin@gnome.org>
3803 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
3804 lookup on a per-class level; ie. walk up the class hierarchy until we
3805 found at least one applicable method, then choose the best among them.
3806 Fixes bug #24463 and test-29.cs.
3808 2002-07-22 Martin Baulig <martin@gnome.org>
3810 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
3811 return types of the methods. The return type is not part of the
3812 signature and we must not check it to make the `new' modifier work.
3813 Fixes bug #27999, also added test-147.cs.
3814 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
3816 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
3817 on the method's return type.
3819 2002-07-21 Martin Baulig <martin@gnome.org>
3821 * assign.cs: Make this work if the rightmost source is a constant and
3822 we need to do an implicit type conversion. Also adding a few more tests
3823 to test-38.cs which should have caught this.
3825 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
3826 target in the makefile for this. The makefile.gnu is primarily intended
3827 for end-users who don't want to debug the compiler.
3829 2002-07-21 Martin Baulig <martin@gnome.org>
3831 * assign.cs: Improved the Assign class so it can now handle embedded
3832 assignments (X = Y = Z = something). As a side-effect this'll now also
3833 consume less local variables. test-38.cs now passes with MCS, added
3834 a few new test cases to that test.
3836 2002-07-20 Martin Baulig <martin@gnome.org>
3838 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
3839 instructions. Fixes bug #27977, also added test-146.cs.
3841 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3843 * cs-tokenizer.cs: fixed getHex ().
3845 2002-07-19 Martin Baulig <martin@gnome.org>
3847 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
3848 not Type.GetType() to lookup the array type. This is needed when
3849 we're constructing an array of a user-defined type.
3850 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
3851 single-dimensional arrays, but also for single-dimensial arrays of
3854 2002-07-19 Martin Baulig <martin@gnome.org>
3856 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
3857 this function is called, it's not allowed to share LocalBuilders
3860 2002-07-19 Martin Baulig <martin@gnome.org>
3862 * expression.cs (Argument.Resolve): Report an error 118 when trying
3863 to pass a type as argument.
3865 2002-07-18 Martin Baulig <martin@gnome.org>
3867 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
3868 Conv_R_Un for the signed `long' type.
3870 2002-07-15 Miguel de Icaza <miguel@ximian.com>
3872 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
3873 `expr' for the temporary result, as that will fail if we do
3874 multiple resolves on the same expression.
3876 2002-07-05 Miguel de Icaza <miguel@ximian.com>
3878 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
3879 ec.TypeContainer for looking up aliases.
3881 * class.cs (TypeContainer): Remove LookupAlias from here.
3883 * decl.cs (DeclSpace); Move here.
3885 2002-07-01 Miguel de Icaza <miguel@ximian.com>
3887 * class.cs (FindMembers): Only call filter if the constructor
3888 bulider is not null.
3890 Also handle delegates in `NestedTypes' now. Now we will perform
3891 type lookups using the standard resolution process. This also
3894 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
3895 This uses Expressions (the limited kind that can be parsed by the
3896 tree) instead of strings.
3898 * expression.cs (ComposedCast.ToString): Implement, used to flag
3899 errors since now we have to render expressions.
3901 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
3904 * ecore.cs (SimpleName.ToString): ditto.
3906 * cs-parser.jay: Instead of using strings to assemble types, use
3907 Expressions to assemble the type (using SimpleName, ComposedCast,
3908 MemberAccess). This should fix the type lookups in declarations,
3909 because we were using a different code path for this.
3911 * statement.cs (Block.Resolve): Continue processing statements
3912 even when there is an error.
3914 2002-07-17 Miguel de Icaza <miguel@ximian.com>
3916 * class.cs (Event.Define): Also remove the `remove' method from
3917 the list of pending items.
3919 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
3920 generate more compact code.
3922 2002-07-17 Martin Baulig <martin@gnome.org>
3924 * const.cs (Const.LookupConstantValue): Add support for constant
3925 `unchecked' and `checked' expressions.
3926 Also adding test case test-140.cs for this.
3928 2002-07-17 Martin Baulig <martin@gnome.org>
3930 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
3931 check whether mi.ReturnType implements the IEnumerator interface; the
3932 `==' and the IsAssignableFrom() will fail in this situation.
3934 2002-07-16 Ravi Pratap <ravi@ximian.com>
3936 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
3939 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3941 * expression.cs: fixed bug #27811.
3943 2002-07-14 Miguel de Icaza <miguel@ximian.com>
3945 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
3946 Molaro: when we are a ref, the value already contains a pointer
3947 value, do not take the address of it.
3949 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
3950 * removed mb-parser.jay and mb-tokenizer.cs
3952 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
3954 * expression.cs: check against the building corlib void type.
3956 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
3958 * ecore.cs: fix for valuetype static readonly fields: when
3959 initializing them, we need their address, not the address of a copy.
3961 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
3963 * typemanager.cs: register also enum_type in corlib.
3965 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
3967 * class.cs: allow calling this (but not base) initializers in structs.
3969 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
3971 * ecore.cs: make sure we compare against the building base types
3974 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
3976 * typemanager.cs: fix TypeToCoreType() to handle void and object
3977 (corlib gets no more typerefs after this change).
3979 2002-07-12 Miguel de Icaza <miguel@ximian.com>
3981 * expression.cs (ArrayCreation.EmitArrayArguments): use
3982 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
3984 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
3985 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
3986 array indexes, the runtime actually forbids them.
3988 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
3989 for array arguments here.
3991 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
3992 instead of the default for ValueTypes.
3994 (New.DoEmit): Use IsValueType instead of
3995 IsSubclassOf (value_type)
3996 (New.DoResolve): ditto.
3997 (Invocation.EmitCall): ditto.
3999 * assign.cs (Assign): ditto.
4001 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
4002 Statements *are* currently doing part of their resolution during
4005 Expressions do always resolve during resolve, but statements are
4006 only required to propagate resolution to their children.
4008 2002-07-11 Miguel de Icaza <miguel@ximian.com>
4010 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
4012 (LoadAssembly): Do not add the dll if it is already specified
4014 (MainDriver): Add the System directory to the link path at the end,
4015 after all the other -L arguments.
4017 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
4018 wrong opcode for loading bytes and bools (ldelem.i1 instead of
4019 ldelem.u1) and using the opposite for sbytes.
4021 This fixes Digger, and we can finally run it.
4023 * driver.cs (UnixParseOption): Move the option parsing here.
4024 (CSCParseOption): Implement CSC-like parsing of options.
4026 We now support both modes of operation, the old Unix way, and the
4027 new CSC-like way. This should help those who wanted to make cross
4030 The only thing broken is that /r:, /reference: and /lib: are not
4031 implemented, because I want to make those have the same semantics
4032 as the CSC compiler has, and kill once and for all the confussion
4033 around this. Will be doing this tomorrow.
4035 * statement.cs (Unsafe.Resolve): The state is checked during
4036 resolve, not emit, so we have to set the flags for IsUnsfe here.
4038 2002-07-10 Miguel de Icaza <miguel@ximian.com>
4040 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
4041 not catch the Error_ObjectRefRequired in SimpleName (as it is
4042 possible to have a class/instance variable name that later gets
4043 deambiguated), we have to check this here.
4045 2002-07-10 Ravi Pratap <ravi@ximian.com>
4047 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
4048 make static and put into Expression.
4050 (Event.Define): Register the private field of the event with the
4051 TypeManager so that GetFieldFromEvent can get at it.
4053 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
4054 keep track of the private field associated with an event which
4057 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
4060 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
4062 2002-07-10 Miguel de Icaza <miguel@ximian.com>
4064 * expression.cs (Binary.EmitBranchable): this routine emits the
4065 Binary expression in a branchable context. This basically means:
4066 we need to branch somewhere, not just get the value on the stack.
4068 This works together with Statement.EmitBoolExpression.
4070 * statement.cs (Statement.EmitBoolExpression): Use
4073 2002-07-09 Miguel de Icaza <miguel@ximian.com>
4075 * statement.cs (For): Reduce the number of jumps in loops.
4077 (For): Implement loop inversion for the For statement.
4079 (Break): We can be breaking out of a Try/Catch controlled section
4080 (foreach might have an implicit try/catch clause), so we need to
4081 use Leave instead of Br.
4083 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
4084 now). If the instace expression supports IMemoryLocation, we use
4085 the AddressOf method from the IMemoryLocation to extract the
4086 address instead of emitting the instance.
4088 This showed up with `This', as we were emitting the instance
4089 always (Emit) instead of the Address of This. Particularly
4090 interesting when This is a value type, as we dont want the Emit
4091 effect (which was to load the object).
4093 2002-07-08 Miguel de Icaza <miguel@ximian.com>
4095 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
4097 * statement.cs (Checked): Set the CheckedState during the resolve
4098 process too, as the ConvCast operations track the checked state on
4099 the resolve process, and not emit.
4101 * cs-parser.jay (namespace_member_declaration): Flag that we have
4102 found a declaration when we do. This is used to flag error 1529
4104 * driver.cs: Report ok when we display the help only.
4106 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
4108 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
4110 2002-07-04 Miguel de Icaza <miguel@ximian.com>
4112 * cs-tokenizer.cs (define): We also have to track locally the
4113 defines. AllDefines is just used for the Conditional Attribute,
4114 but we also need the local defines for the current source code.
4116 2002-07-03 Miguel de Icaza <miguel@ximian.com>
4118 * statement.cs (While, For, Do): These loops can exit through a
4119 Break statement, use this information to tell whether the
4120 statement is the last piece of code.
4122 (Break): Flag that we break.
4124 * codegen.cs (EmitContexts): New `Breaks' state variable.
4126 2002-07-03 Martin Baulig <martin@gnome.org>
4128 * class.cs (TypeContainer.MethodModifiersValid): Allow override
4129 modifiers in method declarations in structs. Otherwise, you won't
4130 be able to override things like Object.Equals().
4132 2002-07-02 Miguel de Icaza <miguel@ximian.com>
4134 * class.cs (Method, Property, Indexer): Do not allow the public
4135 modifier to be used in explicit interface implementations.
4137 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
4138 override modifiers in method declarations in structs
4140 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
4142 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
4143 integer or real overflow, report an error
4145 2002-07-02 Martin Baulig <martin@gnome.org>
4147 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
4148 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
4149 to tell the runtime about our newly created System.Object and
4150 System.ValueType types.
4152 2002-07-02 Miguel de Icaza <miguel@ximian.com>
4154 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
4155 struct instead of Ldarg/Starg.
4157 2002-07-02 Martin Baulig <martin@gnome.org>
4159 * expression.cs (Indirection.Indirection): Call
4160 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
4162 2002-07-02 Martin Baulig <martin@gnome.org>
4164 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
4165 ValueType, call TypeManager.TypeToCoreType() on it.
4166 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
4167 the OpCodes.Newarr argument.
4169 2002-07-02 Martin Baulig <martin@gnome.org>
4171 * expression.cs (Invocation.EmitCall): When compiling corlib,
4172 replace all calls to the system's System.Array type to calls to
4173 the newly created one.
4175 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
4176 System.Array methods.
4177 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
4178 from the system's System.Array type which must be replaced.
4180 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
4182 * typemanager.cs: load unverifiable_code_ctor so we can build
4183 corlib using the correct type. Avoid using GetTypeCode() with
4185 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
4186 TypeManager.object_type to allow building corlib.
4188 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
4190 * ecore.cs: handle System.Enum separately in LoadFromPtr().
4192 2002-07-01 Martin Baulig <martin@gnome.org>
4194 * class.cs: Make the last change actually work, we need to check
4195 whether `ifaces != null' to avoid a crash.
4197 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
4199 * class.cs: when we build structs without fields that implement
4200 interfaces, we need to add the interfaces separately, since there is
4201 no API to both set the size and add the interfaces at type creation
4204 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
4206 * expression.cs: the dimension arguments to the array constructors
4207 need to be converted if they are a long.
4209 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
4211 * class.cs: don't emit ldarg.0 if there is no parent constructor
4212 (fixes showstopper for corlib).
4214 2002-06-29 Martin Baulig <martin@gnome.org>
4216 MCS now compiles corlib on GNU/Linux :-)
4218 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
4219 ie. check for MethodImplOptions.InternalCall.
4221 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
4222 and TypeManager.attribute_type are null, so we must explicitly check
4223 whether parent is not null to find out whether it's an attribute type.
4224 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
4225 and SetBuilder, not only if the property is neither abstract nor external.
4226 This is necessary to set the MethodImplOptions on the accessor methods.
4227 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
4228 SetBuilder, see Property.Emit().
4230 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
4231 populate "System.Object", "System.ValueType" and "System.Attribute" since
4232 they've already been populated from BootCorlib_PopulateCoreTypes().
4234 2002-06-29 Martin Baulig <martin@gnome.org>
4236 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
4237 is the NullLiteral, we also need to make sure that target_type is not
4240 2002-06-29 Martin Baulig <martin@gnome.org>
4242 * rootcontext.cs (RootContext.ResolveCore): We must initialize
4243 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
4244 before calling BootstrapCorlib_ResolveDelegate ().
4246 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4248 * statement.cs: fixed build-breaker. All tests passed ok.
4250 2002-06-27 Martin Baulig <martin@gnome.org>
4252 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
4253 for System.Decimal when compiling corlib.
4255 2002-06-27 Martin Baulig <martin@gnome.org>
4257 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
4258 switch blocks which contain nothing but a default clause.
4260 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
4262 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
4264 2002-06-27 Martin Baulig <martin@gnome.org>
4266 * ecore.cs (PropertyExpr.PropertyExpr): Call
4267 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
4269 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
4270 is already a TypeBuilder.
4272 2002-06-27 Martin Baulig <martin@gnome.org>
4274 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
4275 `target_type == TypeManager.array_type', not IsAssignableFrom() in
4276 the "from an array-type to System.Array" case. This makes it work
4277 when compiling corlib.
4279 2002-06-27 Martin Baulig <martin@gnome.org>
4281 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
4282 non-static PropertyExpr, set its InstanceExpression. This makes
4283 the `ICollection.Count' property work in System/Array.cs.
4285 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
4287 * driver.cs: Made error handling more consistent. Errors now
4288 tracked by Report class, so many methods which used to return int
4289 now return void. Main() now prints success/failure and
4290 errors/warnings message.
4292 Renamed '--probe' compiler argument to '--expect-error'. Removed
4293 the magic number return values (123 and 124). Now, if the
4294 expected error occurs, the compiler exits with success (exit value
4295 0). If the compilation completes without seeing that particular
4296 error, the compiler exits with failure (exit value 1). The
4297 makefile in mcs/errors has been changed to handle the new behaviour.
4299 * report.cs: Made 'expected error' number a property and renamed
4300 it from 'Probe' to 'ExpectedError'.
4302 * genericparser.cs: Removed error handling support, since it is
4303 now all done by Report class.
4305 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
4306 class, so parse() no longer returns an int.
4308 * namespace.cs: Use Report.Error instead of GenericParser.error
4310 2002-06-22 Miguel de Icaza <miguel@ximian.com>
4312 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
4313 TypeContainer.AddOperator): At the front of the list put the
4314 explicit implementations, so they get resolved/defined first.
4316 2002-06-21 Miguel de Icaza <miguel@ximian.com>
4318 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
4319 interface type is implemented by this TypeContainer. Used during
4320 explicit interface implementation.
4322 (Property.Define, Indexer.Define, Method.Define): Validate that
4323 the given interface in the explicit implementation is one of the
4324 base classes for the containing type.
4326 Also if we are explicitly implementing an interface, but there is
4327 no match in the pending implementation table, report an error.
4329 (Property.Define): Only define the property if we are
4330 not explicitly implementing a property from an interface. Use the
4331 correct name also for those properties (the same CSC uses,
4332 although that is really not needed).
4334 (Property.Emit): Do not emit attributes for explicitly implemented
4335 properties, as there is no TypeBuilder.
4337 (Indexer.Emit): ditto.
4339 Hiding then means that we do not really *implement* a pending
4340 implementation, which makes code fail.
4342 2002-06-22 Martin Baulig <martin@gnome.org>
4344 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
4345 the return value of Object.GetType(). [FIXME: we need to do this whenever
4346 we get a type back from the reflection library].
4348 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
4350 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
4352 2002-06-20 Miguel de Icaza <miguel@ximian.com>
4354 * attribute.cs: Return null if we can not look up the type.
4356 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
4357 the interface types found.
4359 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
4360 interface types found.
4362 * typemanager.cs (GetInterfaces): Make this routine returns alll
4363 the interfaces and work around the lame differences between
4364 System.Type and System.Reflection.Emit.TypeBuilder in the results
4365 result for GetInterfaces.
4367 (ExpandInterfaces): Given an array of interface types, expand and
4368 eliminate repeated ocurrences of an interface. This expands in
4369 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
4372 2002-06-21 Martin Baulig <martin@gnome.org>
4374 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
4377 2002-06-21 Martin Baulig <martin@gnome.org>
4379 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
4380 and called with one of the core types, return the corresponding typebuilder for
4383 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
4386 2002-06-21 Martin Baulig <martin@gnome.org>
4388 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
4389 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
4390 (Expression.ConvertReferenceExplicit): Likewise.
4392 * expression.cs (ElementAccess.DoResolve): Likewise.
4393 (ElementAccess.DoResolveLValue): Likewise.
4395 2002-06-10 Martin Baulig <martin@gnome.org>
4397 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
4398 add the "value" parameter to the parameter list.
4400 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
4403 2002-06-19 Miguel de Icaza <miguel@ximian.com>
4405 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
4406 the argument to an int, uint, long or ulong, per the spec. Also
4407 catch negative constants in array creation.
4409 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
4411 * class.cs: do not allow the same interface to appear twice in
4412 the definition list.
4414 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
4416 * ecore.cs: don't use ldlen with System.Array.
4418 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
4420 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
4422 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
4424 * modifiers.cs: produce correct field attributes for protected
4425 internal. Easy fix so miguel can work on ther harder stuff:-)
4427 2002-06-18 Miguel de Icaza <miguel@ximian.com>
4429 * pending.cs: New file. Move the code from class.cs here.
4430 Support clearning the pending flag for all methods (when not doing
4431 explicit interface implementation).
4433 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
4435 * rootcontext.cs: added a couple more types needed to bootstrap.
4437 2002-06-17 Miguel de Icaza <miguel@ximian.com>
4439 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
4440 constructor in the type, instead of any constructor in the type
4441 hierarchy. Thanks to Paolo for finding this bug (it showed up as
4442 a bug in the Mono runtime when applying the params attribute).
4444 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
4445 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
4447 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
4449 * expression.cs (Unary.ResolveOperator): Use TypeManager
4450 to resolve the type.
4452 2002-06-13 Ravi Pratap <ravi@ximian.com>
4454 * cs-parser.jay (enum_member_declaration): Pass in the attributes
4457 * enum.cs (AddEnumMember): Add support to store the attributes associated
4458 with each member too.
4460 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
4461 field builders too - this takes care of the enum member case.
4463 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
4465 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
4466 address-of operator on both value types and pointers.
4468 2002-06-10 Martin Baulig <martin@gnome.org>
4470 * interface.cs (Interface.PopulateIndexer): Add the indexer's
4471 PropertyBuilder to the `property_builders' list.
4473 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
4474 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
4475 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
4476 find any indexers which are inherited from an interface.
4478 2002-06-09 Martin Baulig <martin@gnome.org>
4480 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
4481 the same type as the constant if necessary. There's also a test-130.cs
4484 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
4486 * typemanager.cs (TypeManager.ChangeType): Previously known as
4487 Enum.ChangeEnumType().
4489 2002-06-09 Martin Baulig <martin@gnome.org>
4491 * expression.cs (Cast.TryReduce): Added support for consts.
4493 2002-06-08 Ravi Pratap <ravi@ximian.com>
4495 * class.cs (Accessor): Hold attributes information so we can pass
4498 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
4499 Modify to pass in attributes attached to the methods.
4501 (add_accessor_declaration, remove_accessor_declaration): Ditto.
4503 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
4504 to handle the Accessor kind :-)
4506 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
4508 2002-06-08 Martin Baulig <martin@gnome.org>
4510 * expression.cs (Unary.TryReduceNegative): Added support for
4513 2002-06-08 Martin Baulig <martin@gnome.org>
4515 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
4516 name can't be found in the `defined_names' - the caller will do a
4517 MemberLookup in this case and thus find methods in System.Enum
4518 such as Enum.IsDefined().
4520 2002-06-08 Martin Baulig <martin@gnome.org>
4522 * enum.cs (Enum.ChangeEnumType): This is a custom version of
4523 Convert.ChangeType() which works with TypeBuilder created types.
4524 (Enum.LookupEnumValue, Enum.Define): Use it here.
4526 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
4527 `TypeBuilder.BaseType != null' check.
4528 (TypeContainer.FindMembers): Only lookup parent members if we
4529 actually have a parent.
4530 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
4531 (ConstructorInitializer.Resolve): Likewise.
4533 * interface.cs (Interface.FindMembers): Added
4534 `TypeBuilder.BaseType != null' check.
4536 * rootcontext.cs (RootContext.ResolveCore): Added
4537 "System.Runtime.CompilerServices.IndexerNameAttribute" to
4538 classes_second_stage.
4540 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
4541 debug_type and trace_type when compiling with --nostdlib.
4543 2002-06-07 Martin Baulig <martin@gnome.org>
4545 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
4546 (AddField): Set it to true when adding a non-static field.
4547 (DefineType): Use `have_nonstatic_fields' to find out whether we
4548 have non-static fields, not `Fields != null'.
4550 2002-06-02 Miguel de Icaza <miguel@ximian.com>
4552 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
4553 dereferencing a null on the static-field code path)
4555 2002-05-30 Martin Baulig <martin@gnome.org>
4557 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
4558 to take command line arguments. Use reflection to call the new
4559 custom `Initialize' function on the symbol writer and pass it the
4560 command line arguments.
4562 * driver.cs (--debug-args): New command line argument to pass command
4563 line arguments to the symbol writer.
4565 2002-05-28 Miguel de Icaza <miguel@ximian.com>
4567 * assign.cs (DoResolve): Forgot to do the implicit conversion to
4568 the target type for indexers and properties. Thanks to Joe for
4571 2002-05-27 Miguel de Icaza <miguel@ximian.com>
4573 * typemanager.cs (MethodFlags): returns the method flags
4574 (Obsolete/ShouldIgnore) that control warning emission and whether
4575 the invocation should be made, or ignored.
4577 * expression.cs (Invocation.Emit): Remove previous hack, we should
4578 not do this on matching a base type, we should do this based on an attribute
4580 Only emit calls to System.Diagnostics.Debug and
4581 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
4582 on the command line.
4584 * rootcontext.cs: Global settings for tracing and debugging.
4586 * cs-tokenizer.cs (define): New utility function to track
4587 defines. Set the global settings for TRACE and DEBUG if found.
4589 2002-05-25 Ravi Pratap <ravi@ximian.com>
4591 * interface.cs (Populate*): Pass in the TypeContainer as well as
4592 the DeclSpace as parameters so that we can create EmitContexts and
4593 then use that to apply attributes etc.
4595 (PopulateMethod, PopulateEvent, PopulateProperty)
4596 (PopulateIndexer): Apply attributes everywhere.
4598 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
4601 (ApplyAttributes): Update accordingly.
4603 We now apply interface attributes for all members too.
4605 2002-05-26 Miguel de Icaza <miguel@ximian.com>
4607 * class.cs (Indexer.Define); Correctly check if we are explicit
4608 implementation (instead of checking the Name for a ".", we
4609 directly look up if the InterfaceType was specified).
4611 Delay the creation of the PropertyBuilder.
4613 Only create the PropertyBuilder if we are not an explicit
4614 interface implementation. This means that explicit interface
4615 implementation members do not participate in regular function
4616 lookups, and hence fixes another major ambiguity problem in
4617 overload resolution (that was the visible effect).
4619 (DefineMethod): Return whether we are doing an interface
4622 * typemanager.cs: Temporary hack until we get attributes in
4623 interfaces (Ravi is working on that) and we get IndexerName
4624 support in interfaces.
4626 * interface.cs: Register the indexers as properties.
4628 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
4629 warning, I have verified that this is a bug in the .NET runtime
4630 (JavaScript suffers of the same problem).
4632 * typemanager.cs (MemberLookup): When looking up members for
4633 interfaces, the parent of an interface is the implicit
4634 System.Object (so we succeed in searches of Object methods in an
4635 interface method invocation. Example: IEnumerable x; x.ToString
4638 2002-05-25 Miguel de Icaza <miguel@ximian.com>
4640 * class.cs (Event): Events should also register if they do
4641 implement the methods that an interface requires.
4643 * typemanager.cs (MemberLookup); use the new GetInterfaces
4646 (GetInterfaces): The code used to lookup interfaces for a type is
4647 used in more than one place, factor it here.
4649 * driver.cs: Track the errors at the bottom of the file, we kept
4652 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
4653 instance if the method we are calling is static!
4655 2002-05-24 Miguel de Icaza <miguel@ximian.com>
4657 * attribute.cs (ApplyAttributes): Make this function filter out
4658 the IndexerName attribute (as that attribute in reality is never
4659 applied) and return the string constant for the IndexerName
4662 * class.cs (TypeContainer.Emit): Validate that all the indexers
4663 have the same IndexerName attribute, and if so, set the
4664 DefaultName attribute on the class.
4666 * typemanager.cs: The return value might contain other stuff (not
4667 only methods). For instance, consider a method with an "Item"
4668 property and an Item method.
4670 * class.cs: If there is a problem with the parameter types,
4673 2002-05-24 Ravi Pratap <ravi@ximian.com>
4675 * ecore.cs (ImplicitConversionExists): Wrapper function which also
4676 looks at user defined conversion after making a call to
4677 StandardConversionExists - we need this for overload resolution.
4679 * expression.cs : Update accordingly the various method calls.
4681 This fixes 2 bugs filed against implicit user defined conversions
4683 2002-05-22 Miguel de Icaza <miguel@ximian.com>
4685 * statement.cs: Track the result of the assignment.
4687 2002-05-21 Miguel de Icaza <miguel@ximian.com>
4689 * expression.cs (MemberAccess): Improved error reporting for
4690 inaccessible members.
4692 2002-05-22 Martin Baulig <martin@gnome.org>
4694 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
4695 itself with debugging support.
4697 2002-05-22 Martin Baulig <martin@gnome.org>
4699 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
4700 Removed, this isn't needed anymore.
4702 2002-05-20 Martin Baulig <martin@gnome.org>
4704 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
4705 be underlying type for an enum.
4707 2002-05-20 Miguel de Icaza <miguel@ximian.com>
4709 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
4710 that splits out the loading of just the core types.
4712 * rootcontext.cs (ResolveCore): Split the struct resolution in
4713 two, so we can load the enumeration underlying types before any
4716 * expression.cs (Is): Bandaid until we fix properly Switch (see
4717 bug #24985 for details).
4719 * typemanager.cs (ImplementsInterface): The hashtable will contain
4720 a null if there are no interfaces implemented.
4722 2002-05-18 Miguel de Icaza <miguel@ximian.com>
4724 * cs-parser.jay (indexer_declarator): It is fine to have array
4727 2002-05-17 Miguel de Icaza <miguel@ximian.com>
4729 * typemanager.cs: (RegisterBuilder): New function used to register
4730 TypeBuilders that implement interfaces. Since
4731 TypeBuilder.GetInterfaces (as usual) does not work with lame
4733 (AddUserType): register interfaces.
4735 (ImplementsInterface): Use the builder_to_ifaces hash if we are
4736 dealing with TypeBuilder. Also, arrays are showing up as
4737 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
4738 methods can not be invoked on them!
4740 * ecore.cs (ExplicitReferenceConversionExists): Made public.
4741 (ImplicitReferenceConversionExists): Split out from
4742 StandardConversionExists.
4744 * expression.cs (As): We were only implementing one of the three
4745 cases for the as operator. We now implement them all.
4746 (Is): Implement the various other cases for Is as well.
4748 * typemanager.cs (CACHE): New define used to control if we want or
4749 not the FindMembers cache. Seems to have a negative impact on
4750 performance currently
4752 (MemberLookup): Nested types have full acess to
4753 enclosing type members
4755 Remove code that coped with instance/static returns for events, we
4756 now catch this in RealFindMembers.
4758 (RealFindMembers): only perform static lookup if the instance
4759 lookup did not return a type or an event.
4761 2002-05-17 Miguel de Icaza <miguel@ximian.com>
4763 * assign.cs (CompoundAssign): We pass more semantic information
4764 now to Compound Assignments than we did before: now we have all
4765 the information at hand, and now we resolve the target *before* we
4766 do the expression expansion, which allows the "CacheValue" method
4767 to have the effect we intended (before, a [x] += 1 would generate
4768 two differen ArrayAccess expressions from the ElementAccess,
4769 during the resolution process).
4771 (CompoundAssign.DoResolve): Resolve target and original_source here.
4773 2002-05-16 Miguel de Icaza <miguel@ximian.com>
4775 * expression.cs (ArrayAccess): dropped debugging information.
4777 * typemanager.cs: Small bug fix: I was always returning i_members,
4778 instead of one of i_members or s_members (depending on which had
4781 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
4782 method is invoked before any code generation takes place, and it
4783 is a mechanism to inform that the expression will be invoked more
4784 than once, and that the method should use temporary values to
4785 avoid having side effects
4787 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
4789 * ecore.cs (Expression.CacheTemporaries): Provide empty default
4792 * expression.cs (Indirection, ArrayAccess): Add support for
4793 CacheTemporaries in these two bad boys.
4795 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
4797 (StoreFromPtr): Handle stobj as well.
4799 * expression.cs (UnaryMutator): Share more code.
4801 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
4802 down: I was not tracking the Filter function as well, which
4803 was affecting the results of the cache.
4805 2002-05-15 Miguel de Icaza <miguel@ximian.com>
4807 * attribute.cs: Remove the hack to handle the CharSet property on
4810 2002-05-14 Miguel de Icaza <miguel@ximian.com>
4812 * attribute.cs (DoResolve): More uglyness, we now only try to
4813 resolve the attribute partially, to extract the CharSet
4814 information (only if we are a StructLayout attribute). Otherwise
4816 (GetExtraTypeInfo): Add some code to conditionally kill in the
4817 future this. I am more and more convinced that the .NET
4818 framework has special code to handle the attribute setting on
4821 * expression.cs (IsParamsMethodApplicable): Revert my previous
4822 foreach change here, it was wrong.
4824 2002-05-13 Miguel de Icaza <miguel@ximian.com>
4826 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
4827 (pp_expr): do not abort on unknown input, just return.
4828 (eval): abort if there are pending chars.
4830 * attribute.cs (Attribute.Resolve): Positional parameters are
4831 optional. Deal with that case.
4833 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
4834 the Ansi/Unicode/Auto information for the type.
4836 (TypeContainer.DefineType): instantiate the EmitContext here, as
4837 we will be using it during the type definition (to resolve
4838 attributes) and during the emit phase.
4840 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
4841 to pull type information out of the attributes
4843 (Attribute.Resolve): track the constructor builder, and allow for
4844 multiple invocations (structs and classes will use this).
4846 * ecore.cs (MemberLookupFinal): new version with all the
4847 parameters customizable.
4849 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
4850 constructors. Return if the result value is null (as the error
4851 would have been flagged already by MemberLookupFinal)
4853 Do not allow instances of abstract classes or interfaces to be
4856 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
4857 We have to compare the assembly property here when dealing with
4858 FamANDAssem and Assembly access modifiers, because we might be
4859 creating an assembly from *modules* (that means that we are not
4860 getting TypeBuilders for types defined in other modules that are
4861 part of this assembly).
4863 (Method.Emit): If the method is marked abstract and has a body,
4866 (TypeContainer.DefineMembers): If both the defined member and the
4867 parent name match are methods, then do not emit any warnings: let
4868 the Method.Define routine take care of flagging warnings. But if
4869 there is a mismatch (method overrides something else, or method is
4870 overriwritten by something, then emit warning).
4872 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
4873 set to null, this means `do not check for the return type on the
4876 (Method.Define): set the return type for the method signature to
4877 null, so that we get methods with the same name and parameters and
4878 different return types. This is used to flag warning 114 (you are
4879 hiding a method, and you probably want to use the new/override
4882 * typemanager.cs (MemberLookup): Implemented proper access
4883 control, closing a long standing set of bug reports. The problem
4884 was that the Framework only has two bits: Public and NonPublic,
4885 and NonPublic includes private and protected methods, but we need
4886 to enforce the FamANDAssem, FamOrAssem and Family.
4888 2002-05-11 Miguel de Icaza <miguel@ximian.com>
4890 * statement.cs (GotoCase): Return true: Ammounts to giving up
4891 knowledge on whether we return or not, and letting the other case
4892 be responsible for it.
4894 2002-05-10 Miguel de Icaza <miguel@ximian.com>
4896 * driver.cs: Do not load directories for each file processed, only
4897 do it if there is a pattern.
4899 * ecore.cs: Report readonly assigns here as well, as we might have
4900 been resolved only by MemberAccess.
4902 (SimpleName.SimpleNameResolve): Also be useful for LValue
4903 resolution. We need this to propagate assign to local readonly variables
4905 * typemanager.cs: Use a ptrhashtable for the criteria, because we
4906 do not want to reuse potential criteria memory.
4908 * class.cs (MyEventBuilder): Set reflected_type;
4910 * ecore.cs (Constantify): Added support for constifying bools.
4912 (RootContext.LookupType): Added a cache for values looked up in
4913 the declaration space.
4915 * typemanager.cs (FindMembers): Now is a front-end to
4916 RealFindMembers, and provides a two-level hashtable-based cache to
4919 15% performance improvement: from 22.5 to 19.2 seconds.
4921 * expression.cs (IsParamsMethodApplicable): use foreach.
4922 (Invocation.DoResolve): ditto.
4923 (New.DoResolve): ditto.
4924 (ArrayCreation.DoResolve): ditto.
4926 * ecore.cs (FindMostEncompassingType): use foreach.
4928 * delegate.cs (NewDelegate.DoResolve): Use foreach
4930 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
4931 (RemoveMethods): use foreach.
4933 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
4934 nested foreach statements instead of for, and also break out of
4935 the inner loop once a match is found.
4937 (Invocation.OverloadResolve): Use foreach, simplify the code.
4939 2002-05-08 Miguel de Icaza <miguel@ximian.com>
4941 * cfold.cs (BinaryFold): During an enumeration evaluation context,
4942 we actually unwrap the expression to allow for extra information
4945 * expression.cs: Use Shr_Un on unsigned operations.
4947 2002-05-08 Ravi Pratap <ravi@ximian.com>
4949 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
4950 applicable operators was not being considered correctly. This closes
4951 the bug Miguel reported.
4953 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
4955 * attribute.cs: check that the type derives from System.Attribute
4956 and report the correct error in that case (moved the duplicate code to
4957 its own method, too).
4959 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
4961 * attribute.cs: lookup attribute type name as the spec says: first the
4962 bare attribute name and then name + "Attribute" (nant compiles with
4963 mcs after this fix).
4965 2002-05-07 Miguel de Icaza <miguel@ximian.com>
4967 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
4968 Because of the way we parse things, we should try to see if a
4969 UIntConstant can fit in an integer.
4971 2002-05-07 Ravi Pratap <ravi@ximian.com>
4973 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
4974 when we are in an explicit context.
4976 (ConvertReferenceExplicit): When converting from Iface type S to Class
4977 T make sure the rules are implemented as an OR.
4979 * parameter.cs (ParameterType): Make it a property for now although the
4980 purpose really isn't anything immediate.
4982 * expression.cs (Is*Applicable): Do better checking on the parameter type
4983 of a ref/out parameter. The ones from the system assemblies are already
4984 marked with the correct type so we don't need to do any correction.
4986 * ecore.cs (StandardConversionExists): Conversion from Interface types to
4987 the object type is standard too so include that.
4989 2002-05-06 Miguel de Icaza <miguel@ximian.com>
4991 * ecore.cs (StandardConversionExists): Augment with missing code:
4992 deal with IntConstant, LongConstants and Enumerations.
4994 * assign.cs: Report the error, instead of failing silently
4996 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
4997 typecontainer that they are declared, because the
4998 typecontainer/namespace will have the list of using clauses that
5001 Assembly Attributes were escaping the normal registration
5004 (EmitCode): Apply attributes within an EmitContext that represents
5005 the container they were declared on.
5007 * cs-parser.jay: Track bases for structs. How did I get this wrong?
5009 2002-05-06 Ravi Pratap <ravi@ximian.com>
5011 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
5012 Revamp completely - make much cleaner as we now operate only
5015 (FindMostSpecificSource, FindMostSpecificTarget): New methods
5016 to implement the logic detailed in the spec more correctly.
5018 (UserDefinedConversion): Update accordingly.
5020 2002-05-06 Miguel de Icaza <miguel@ximian.com>
5022 * statement.cs: Return flow analysis information up.
5024 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
5027 (token): Do not consume an extra character before calling
5030 2002-05-06 Piers Haken <piersh@friskit.com>
5032 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
5034 2002-05-06 Miguel de Icaza <miguel@ximian.com>
5036 * class.cs (Constructor.Emit): Set the IsStatic flag in the
5037 EmitContext during the instance constructor initializer
5038 resolution, to stop access to instance variables.
5040 This is mandated by the spec, last paragraph of the `constructor
5041 initializers' section.
5043 2002-05-05 Miguel de Icaza <miguel@ximian.com>
5045 * cs-parser.jay, class.cs (Accessor): new class used to represent
5046 an accessor (get or set). In the past we used `null' to represent
5047 a missing accessor. But this is ambiguous because there was no
5048 way to tell in abstract indexers/properties if one of them was
5051 Now there is a way of addressing that.
5053 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
5054 instead of FindMembers.
5056 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
5057 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
5059 * attribute.cs: Treat indexers and properties as the same in terms
5060 of applying attributes
5062 * ecore.cs (FindMostEncompassedType): Use statically initialized
5063 EmptyExpressions()s like we do elsewhere to avoid creating useless
5064 objects (and we take this out of the tight loop).
5066 (GetConversionOperators): Move the code to extract the actual
5067 operators to a separate routine to clean things up.
5069 2002-05-04 Miguel de Icaza <miguel@ximian.com>
5071 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
5072 events are always registered FieldBuilders.
5074 * class.cs (FieldBase): New class shared by Fields
5076 * delegate.cs: If we are a toplevel delegate, use our full name.
5077 If we are a nested delegate, then only use our tail name.
5079 2002-05-02 Ravi Pratap <ravi@ximian.com>
5081 * expression.cs (IsApplicable): Ensure that we add the "&" to
5082 ref/out types before comparing it with the type of the argument.
5084 (IsParamsMethodApplicable): Ditto.
5086 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
5089 * delegate.cs : Handle the case when we have more than one applicable
5090 method. Flag an error only when we finish checking all.
5092 2002-05-02 Miguel de Icaza <miguel@ximian.com>
5094 * expression.cs: Add support for boolean static initializers.
5096 2002-05-01 Miguel de Icaza <miguel@ximian.com>
5098 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
5100 * parameter.cs (ComputeParameterTypes,
5101 ComputeAndDefineParameterTypes): Better error handling: now we
5102 clear the `types' cache if we fail during any of the type lookups.
5103 We also return the status code correctly to our caller
5105 * delegate.cs: If we fail to define a delegate, abort the extra
5108 * expression.cs (Binary.ResolveOperator): for
5109 operator==(object,object) and operator !=(object, object) we also
5110 have to verify that there is an implicit conversion from one to
5113 (ArrayAccess.DoResolve): Array Access can operate on
5116 2002-04-30 Miguel de Icaza <miguel@ximian.com>
5118 * assign.cs (CompoundAssign): A new class used as a "flag" that
5119 the assignment actually is happening as part of a compound
5120 assignment operator.
5122 During compound assignment, a few new rules exist to enable things
5129 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
5130 to the type of x) if y is implicitly convertible to the type of x,
5131 and the operator is a builtin operator and the return type of the
5132 operator is explicitly convertible to the type of x.
5134 * rootcontext.cs: Reset warning level to 2. 4 catches various
5135 "interesting" features in mcs, we must clean this up at some
5136 point, but currently am trying to kill other bugs ;-)
5138 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
5139 in container classes as well.
5141 * expression.cs (Binary.ResolveOperator): Handle string case
5142 before anything else (as operator overloading does emit an error
5143 before doing anything else).
5145 This code could go away when we move to a table driven model, but
5146 i could not come up with a good plan last night.
5148 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
5150 * typemanager.cs (CSharpName): reimplementation using regex.
5151 * class.cs: added null check for fields in Emit
5152 * rootcontext.cs: set warninglevel to 4
5154 2002-04-29 Miguel de Icaza <miguel@ximian.com>
5156 * typemanager.cs (CSharpName): reimplemented with Lupus
5159 2002-04-28 Miguel de Icaza <miguel@ximian.com>
5161 * statement.cs (If): correclty implement Resolve, because we were
5162 not catching sem errors in there. The same process is needed
5164 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
5167 (Statement.Warning_DeadCodeFound): Factorize code.
5168 (While): Report dead code here too.
5170 (Statement): Added Resolve virtual method to allow
5171 for resolution split from the emit code.
5173 2002-04-26 Miguel de Icaza <miguel@ximian.com>
5175 * statement.cs (EmitBoolExpression): No longer try to resolve the
5177 (MakeBoolean): New utility function that resolve, implicitly
5178 converts to boolean and tags the expression.
5181 (If, Do): Implement dead code elimination.
5182 (While): Implement loop inversion
5184 (Do, While, For, If): Resolve the expression prior to calling our
5187 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
5190 - added method Report28 (warning: program has more than one entry point)
5191 - added method IsEntryPoint, implements paragraph 10.1 of the spec
5192 - modified method Method.Define, the part at the end of the method
5194 * rootcontext.cs: added static public Location EntryPointLocation;
5196 * ../errors/cs0028.cs : Add test case for the above warning.
5199 - modified method CSharpName to allow arrays of primitive type to
5200 be printed nicely (e.g. instead of System.Int32[][] it now prints
5202 - added method CSharpSignature: returns the signature of a method
5203 in string format to be used in reporting errors, warnings, etc.
5205 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
5208 2002-04-26 Ravi Pratap <ravi@ximian.com>
5210 * delegate.cs (Define): Fix extremely silly bug where I was
5211 setting the type of the 'object' parameter of the BeginInvoke
5212 method to System.IAsyncResult instead of System.Object ;-)
5214 2002-04-26 Miguel de Icaza <miguel@ximian.com>
5216 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
5219 (Constructor.Emit): return if we fail to initialize the
5220 constructor. Another door closed!
5222 * expression.cs (New.DoResolve): Improve error message (from -6 to
5223 1501). Use DeclaredOnly lookup to find the exact constructor.
5225 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
5226 loop. This is useful.
5228 * cs-parser.jay: Adjust the default parameters so that destructors
5229 have the proper signature.
5231 2002-04-26 Martin Baulig <martin@gnome.org>
5233 * driver.cs (LoadAssembly): If `assembly' contains any characters
5234 which are only valid in path names and not in assembly names
5235 (currently slash, backslash and point), use Assembly.LoadFrom ()
5236 instead of Assembly.Load () on the `assembly' (before iteration
5237 over the link_paths).
5239 2002-04-26 Martin Baulig <martin@gnome.org>
5241 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
5243 2002-04-25 Miguel de Icaza <miguel@ximian.com>
5245 * class.cs (Property): use the new typemanager.MemberLookup
5247 (TypeContainer.MemberLookup): Implement using the
5248 TypeManager.MemberLookup now.
5250 * typemanager.cs: Make MemberLookup a function of the TypeManager,
5251 and return MemberInfos, so that these can be used without an
5252 EmitContext (what we had before).
5254 2002-04-24 Miguel de Icaza <miguel@ximian.com>
5256 * expression.cs: Fix the case where the argument to params if the
5257 type of the params. I omitted handling this before. Fixed
5259 2002-04-22 Miguel de Icaza <miguel@ximian.com>
5261 * driver.cs: Call BootCorlib_PopulateCoreType
5263 * class.cs (Property.CheckBase): Check for properties only, not
5266 * interface.cs: Temporary hack: try/catch around the
5267 CustomAttributeBuilder, because I am getting an exception that I
5270 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
5271 types whose definitions are required to be there (attributes are
5272 defined before standard types).
5274 Compute definitions as we boot the various types, as they are used
5275 immediately (value_type class will need object_type, but if we do
5276 not initialize object_type, we will pass a null, which will let
5277 the runtime pick the System.Object from the existing corlib, which
5278 is not what we want).
5280 2002-04-22 Patrik Torstensson <totte@labs2.com>
5282 * cs-tokenizer.cs: fixed a number of trim() issues.
5284 2002-04-22 Ravi Pratap <ravi@ximian.com>
5286 * expression.cs (Argument.Type): Ensure that we return the correct
5287 type when we have out or ref parameters [in which case we
5290 2002-04-22 Miguel de Icaza <miguel@ximian.com>
5292 * class.cs (Property, Indexer): Allow extern modifier in there.
5294 * typemanager.cs (InitBaseTypes): Initializes object_type and
5295 value_type, since those will be used early on during the bootstrap
5296 process to compile corlib.
5298 (InitCoreTypes): Move code from here to InitBaseTypes.
5300 2002-04-21 Miguel de Icaza <miguel@ximian.com>
5302 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
5303 single-dimension arrays as using the ldlen opcode.
5305 Daniel Lewis discovered this optimization.
5307 * typemanager.cs: Add signature for System.Array::get_Length
5309 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5311 * statement.cs: report the error when the foreach does not apply to an
5312 array nor a collection.
5314 2002-04-19 Miguel de Icaza <miguel@ximian.com>
5316 * expression.cs: Add implicit conversions to the operator ~.
5318 * constant.cs (DecimalConstant.Emit): Emit decimal value.
5320 * typemanager.cs: Locate the decimal constructor.
5322 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5324 * attribute.cs: use the new property of TypeOf.
5325 * expression.cs: added 'get' property around typearg.
5327 These changes fix a build breaker reported by NickD. Is this the
5328 correct way to fix? If not, please, revert my changes and make it
5331 2002-04-17 Miguel de Icaza <miguel@ximian.com>
5333 * attribute.cs: Add support for typeof in attribute invocations.
5334 I am not sure that this is right though.
5336 2002-04-14 Duncan Mak <duncan@ximian.com>
5338 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
5339 Binary.Operator.Division case.
5341 2002-04-13 Ravi Pratap <ravi@ximian.com>
5343 * class.cs (DefineType): Ensure that we do a proper check on
5344 attribute types and also register it with the TypeManager.
5346 (TypeContainer.Targets): The default for attribute types is
5347 AttributeTargets.All.
5349 * attribute.cs (ApplyAttributes): Registering the attribute type
5350 is done elsewhere, not when we discover we have a Usage attribute.
5352 2002-04-12 Ravi Pratap <ravi@ximian.com>
5354 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
5355 and get rid of is_delegate parameter.
5357 * everywhere : update.
5359 2002-04-12 Ravi Pratap <ravi@ximian.com>
5361 * cs-parser.jay (compilation_unit): Revamp completely to use
5362 some new ideas that I got from Rhys' grammar to solve the problems
5363 with assembly level attributes.
5365 (outer_declaration): New grammar production.
5367 (attribute_sections): Add.
5369 (opt_attributes): Base on attribute_sections
5371 (namespace_declaration): Allow opt_attributes to tackle the case
5372 when we have assembly level attributes - we are clever in this
5375 * attribute.cs (ApplyAttributes): Do not worry about assembly
5376 attributes in the non-global context.
5378 * rootcontext.cs (AddGlobalAttributes): Go back to using this
5379 instead of SetGlobalAttributes.
5381 * class.cs, rootcontext.cs : Ensure we define and generate
5382 attribute types before anything else.
5384 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
5385 and flag the new error -20 for the case when the attribute type
5386 does not have valid targets specified. csc does not catch this.
5388 * ../errors/errors.txt : update for error # -20
5390 2002-04-11 Ravi Pratap <ravi@ximian.com>
5392 * support.cs (InternalParameters.ParameterModifier): Do some null
5393 checking and return sane values.
5395 * class.cs (Method.Define): If we are a PInvoke method, ensure
5396 that we are static and extern. Report error # 601
5398 * ../errors/cs0601.cs : Add test case for the above error.
5400 2002-04-07 Ravi Pratap <ravi@ximian.com>
5402 * rootcontext.cs (attribute_types): We need to keep type of
5403 all attribute types separately and emit code for them first.
5405 (RegisterAttribute) : Implement.
5407 * class.cs (DefineType): Check if the current Type is a custom
5408 attribute type and register it accordingly.
5410 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
5411 adding the first attribute twice and rename to
5413 (SetGlobalAttributes): this.
5415 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
5418 * attribute.cs (ApplyAttributes): Take an additional argument telling us
5419 if we are processing global arguments. Hmm, I am unsure of this.
5421 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5423 * expression.cs: added static array of strings to avoid calling
5424 Enum.ToString () for Operator in Binary. Significant recover of
5427 2002-04-10 Miguel de Icaza <miguel@ximian.com>
5429 * class.cs (FindMembers): Allow the Builders of the various
5430 members to be null. If they are skip them. This only happens
5431 during the PInvoke declaration.
5433 2002-04-09 Miguel de Icaza <miguel@ximian.com>
5435 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
5436 failure, so we do not keep going afterwards.
5438 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
5439 wanted to pass `false' as the `is_delegate' argument. If this is
5440 the case, why not use delegate_type == null to mean `is_delegate =
5441 false' and anything else as is_delegate = true.
5443 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
5445 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
5446 code for the section, not the beginning of the tests.
5448 2002-04-08 Miguel de Icaza <miguel@ximian.com>
5450 * cfold.cs: Handle operator + (Enum x, Underlying x)
5452 * expression.cs (Binary): same. Warn about errors where we have
5453 Enum/Enum in operator + as well.
5455 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
5458 - added support for switch(bool)
5459 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
5460 - add TableSwitchEmit() to handle table-based switch statements
5462 2002-04-05 Ravi Pratap <ravi@ximian.com>
5464 * expression.cs (Invocation.OverloadResolve): Factor out code which
5465 does parameter compatibility checking with arguments so that we can
5466 re-use the code even from Delegate.VerifyApplicability
5468 (VerifyArgumentsCompat): Move above code here.
5470 * delegate.cs (VerifyApplicability): Get rid of duplicate code
5471 and instead make a call to the above method.
5473 2002-03-31 Ravi Pratap <ravi@ximian.com>
5475 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
5476 We use it to keep track of classes which are attribute types.
5478 2002-04-02 Miguel de Icaza <miguel@ximian.com>
5480 * delegate.cs (Delegate.Define): Correctly define the types in the
5481 presence of fixed and array parameters.
5483 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
5486 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
5487 include NonPublic after the first iteration.
5489 * class.cs (Indexer.CheckBase): Only check if both parents are
5492 * cs-parser.jay (accessor_body): If empty, set to null.
5494 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
5495 same code path here to resolve constants names that we did have in
5496 MemberAccess.DoResolve. There is too much code duplicated here.
5498 2002-04-01 Miguel de Icaza <miguel@ximian.com>
5500 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
5502 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
5505 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
5506 tokens, numbers and strings.
5508 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
5511 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
5512 asyncronous parameters and the regular parameters.
5514 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
5515 specify the target directory.
5517 * expression.cs: (This.DoResolve): Simplify
5518 (As.Emit): Optimize, do not generate IsInst if the expression is
5519 always of the given type.
5521 (Is.DoResolve): Bug fix, we were reporting both always/never for
5524 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
5525 creating too many unnecessary arrays.
5527 2002-03-31 Miguel de Icaza <miguel@ximian.com>
5529 * class.cs (EmitFieldInitializer): Use Assign expression to assign
5530 fields instead of rolling our own initializer. Takes care of all
5531 implicit conversions, and drops unnecessary static checks/argument.
5533 2002-03-31 Dick Porter <dick@ximian.com>
5535 * driver.cs: use the GetDirectories() return values properly, and
5536 use "/" as path separator.
5538 2002-03-30 Miguel de Icaza <miguel@ximian.com>
5540 * expression.cs (Unary): Optimize - - expr into expr.
5541 (Binary): Optimize a + (-b) into a -b.
5543 * codegen.cs (CodeGen): Made all methods static.
5545 2002-03-29 Miguel de Icaza <miguel@ximian.com>
5549 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
5550 TypeBuilder property.
5552 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
5555 * tree.cs: Removed the various RecordXXXX, and replaced with a
5556 single RecordDecl. Removed all the accessor methods, and just
5557 left a single access point Type
5559 * enum.cs: Rename DefineEnum to DefineType.
5561 * decl.cs: New abstract method `DefineType' used to unify the
5562 Defines for Enumerations, Interfaces, TypeContainers and
5565 (FindType): Moved LookupInterfaceOrClass here. Moved the
5566 LookupBaseClasses method that used to live in class.cs and
5567 interface.cs here, and renamed to FindType.
5569 * delegate.cs: Implement DefineType. Take advantage of the
5570 refactored pattern for locating the parent builder without taking
5571 the parent_builder argument (which we know does not work if we are
5572 nested, and triggering a toplevel definition).
5574 2002-03-28 Miguel de Icaza <miguel@ximian.com>
5576 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
5577 accessibility of a member has changed during override and report
5580 * class.cs (Method.Define, Property.Define): Only complain on
5581 overrides if the method is private, any other accessibility is
5582 fine (and since we just checked the permission is the same, we are
5585 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
5586 and elif are processed always. The other pre-processing
5587 directives are only processed if we are "taking" the path
5589 2002-03-29 Martin Baulig <martin@gnome.org>
5591 * class.cs (Method.Emit): Only emit symbolic debugging info if the
5592 current location is not Null.
5594 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
5595 a separate method so we can profile it.
5597 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
5598 `span.Seconds' are just seconds, but no minutes or hours.
5599 (MainDriver): Profile the CodeGen.SaveSymbols calls.
5601 2002-03-28 Miguel de Icaza <miguel@ximian.com>
5603 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
5604 Remove the gratuitous set of Final:
5606 // If an interface implementation, then we can set Final.
5607 if (((flags & MethodAttributes.Abstract) == 0) &&
5608 implementing.DeclaringType.IsInterface)
5609 flags |= MethodAttributes.Final;
5611 I do not know what I was smoking when I used that.
5614 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
5615 step into fixing the name resolution issues for delegates and
5616 unifying the toplevel name resolution.
5618 2002-03-28 Martin Baulig <martin@gnome.org>
5620 * class.cs (Method.Emit): If we have a symbol writer, call its
5621 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
5622 tell it about the current method.
5624 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
5625 writer that we're going to emit the first byte of IL code for a new
5626 statement (a new source line).
5627 (EmitContext.EmitTopBlock): If we have a symbol writer, call
5628 EmitContext.Mark() before emitting any code.
5630 * location.cs (SymbolDocument): Return null when we're Null.
5632 * statement.cs (Statement): Moved the `Location loc' variable here.
5633 (Statement.EmitBoolExpression): If we have a symbol writer, call
5634 ec.Mark() before emitting any code to tell it that we're at the
5635 beginning of a new statement.
5636 (StatementExpression): Added `Location' argument to the constructor.
5637 (Block): Added public readonly variable `StartLocation' and public
5638 variable `EndLocation'. The latter is to be set using SetEndLocation().
5639 (Block): Added constructor which takes a start and end location.
5640 (Block.SetEndLocation): New method. This sets the end location.
5641 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
5642 local variables we create.
5643 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
5644 each statement and do also mark the begin and end of the block.
5646 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
5647 tell it the current lexer.Location, use Location.Null for the end of the
5649 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
5650 current block, set its end location using SetEndLocation().
5651 (statement_expression): StatementExpression constructor now takes the
5652 lexer.Location as additional argument.
5653 (for_statement, declare_local_variables): Likewise.
5654 (declare_local_variables): When creating a new implicit block, use the
5655 new Block constructor and pass it the lexer.Location.
5657 2002-03-28 Miguel de Icaza <miguel@ximian.com>
5659 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
5660 members also on the parent interfaces recursively.
5662 2002-03-27 Miguel de Icaza <miguel@ximian.com>
5664 * report.cs: Use new formats, since Gonzalo finished the missing
5667 * expression.cs (Binary.ResolveOperator): added missing operator|
5668 operator& and operator^ for bool/bool.
5670 * cs-parser.jay: CheckDef now takes a Location argument that is
5671 used to report errors more precisly (instead of reporting the end
5672 of a definition, we try to track something which is a lot closer
5673 to the source of the problem).
5675 * cs-tokenizer.cs: Track global token use, so we can properly flag
5676 the use of #define/#undef after the first token has been seen.
5678 Also, rename the reportXXXX to Error_DescriptiveName
5680 * decl.cs (DeclSpace.IsTopLevel): Move property here from
5681 TypeContainer, so that Enum and Interface can use this too.
5683 * class.cs (TypeContainer.LookupInterfaceOrClass,
5684 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
5685 `builder' argument. Typically this was used to pass the parent
5686 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
5689 The problem is that a nested class could trigger the definition of
5690 a toplevel class, and the builder would be obviously wrong in that
5693 So we drop this argument, and we compute dynamically the
5694 TypeBuilder/ModuleBuilder (the correct information was available
5695 to us anyways from DeclSpace.Parent)
5697 * interface.cs (Interface.DefineInterface): Drop builder
5698 parameter cleanup like class.cs
5700 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
5703 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
5706 (Try.Emit): Propagate the returns value from the statement.
5708 (Return.Emit): Even if we are leavning
5710 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
5712 * modifiers.cs: Fix the computation of MethodAttributes flags.
5714 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
5716 * driver.cs: allow compilation of files that start with '/'.
5717 Add a default case when checking the argument of --target.
5719 2002-03-25 Miguel de Icaza <miguel@ximian.com>
5721 * interface.cs: Implement the same search algorithm for types in
5724 * delegate.cs: Do not allow multiple definition.
5726 * Recovered ChangeLog that got accidentally amputated
5728 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
5730 * rootcontext.cs: Load manually enum to allow core classes to
5731 contain enumerations.
5733 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
5734 Update to new static methods in TypeManager.
5736 * typemanager.cs (GetMethod, GetConstructor): Use our
5737 implementation of FindMembers to find the members, since during
5738 corlib compilation, the types are TypeBuilders and GetMethod and
5739 GetConstructor do not work.
5741 Make all methods in TypeManager static.
5743 (InitCodeHelpers): Split the functionality from
5744 the InitCodeTypes function.
5746 * driver.cs: Call InitCodeHelpers after we have populated the
5749 * cs-parser.jay (delegate_declaration): we did not used to compute
5750 the delegate name correctly for void delegates.
5752 2002-03-24 Miguel de Icaza <miguel@ximian.com>
5754 * rootcontext.cs (RootContext): Init the interface_resolve_order
5755 and type_container_resolve_order always.
5757 (ResolveCore, BootstrapCorlib_ResolveClass,
5758 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
5759 compiler when compiling with --nostdlib
5761 * class.cs (TypeContainer.DefineType): Check that our parent is
5762 not null. This test is most important when we are bootstraping
5765 * codegen.cs: Split out the symbol writing code.
5767 2002-03-25 Martin Baulig <martin@gnome.org>
5769 * driver.cs (-g): Made -g an alias for --debug.
5771 2002-03-24 Martin Baulig <martin@gnome.org>
5773 * codegen.cs (SymbolWriter): New public variable. Returns the
5774 current symbol writer.
5775 (CodeGen): Added `bool want_debugging_support' argument to the
5776 constructor. If true, tell the ModuleBuild that we want debugging
5777 support and ask it for the ISymbolWriter.
5778 (Save): If we have a symbol writer, call it's Close() method after
5779 saving the assembly.
5781 * driver.c (--debug): New command line argument to create a
5782 debugger information file.
5784 * location.cs (SymbolDocument): New public property. Returns an
5785 ISymbolDocumentWriter object for the current source file or null
5786 if we don't have a symbol writer.
5788 2002-03-21 Miguel de Icaza <miguel@ximian.com>
5790 * driver.cs (LoadAssembly): Correctly return when all the paths
5791 have been tried and not before.
5793 * statement.cs (Switch.Emit): return the actual coverage for this
5794 statement (returns/not-returns)
5796 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
5797 switch of the statement if we are the last switch section. That
5798 kills two problems: try/catch problems (we used to emit an empty
5799 nop at the end) and switch statements where all branches would
5802 2002-03-19 Miguel de Icaza <miguel@ximian.com>
5804 * driver.cs: Add default assemblies (the equivalent to the
5805 Microsoft CSC.RSP file)
5807 * cs-tokenizer.cs: When updating `cols and setting it to zero,
5808 also update tokens_seen and set it to false.
5810 * driver.cs: Implement --recurse for Mike.
5812 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
5813 correctly splitting out the paths.
5815 2002-03-18 Miguel de Icaza <miguel@ximian.com>
5817 * interface.cs (Interface.PopulateProperty): Instead of using
5818 `parent' as the declaration space for the set parameters, use
5821 * support.cs (InternalParameters): InternalParameters constructor
5822 takes a DeclSpace instead of a TypeContainer.
5824 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
5825 types are being initialized, load the address of it before calling
5828 (New): Provide a mechanism to disable the generation of local
5829 value type temporaries when the caller will be providing us with
5830 an address to store it.
5832 (ArrayCreation.EmitDynamicInitializers): Use it.
5834 2002-03-17 Miguel de Icaza <miguel@ximian.com>
5836 * expression.cs (Invocation.EmitArguments): Only probe for array
5837 property if there is more than one argument. Sorry about that.
5839 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
5842 * class.cs (Method.LabelParameters): Fix incorrect code path that
5843 prevented the `ParamArrayAttribute' from being applied to the
5846 2002-03-16 Miguel de Icaza <miguel@ximian.com>
5848 * support.cs (ReflectionParameters): Correctly compute whether the
5849 last argument is a params array. Fixes the problem with
5852 * typemanager.cs: Make the assemblies array always be non-null
5853 (empty, but non-null)
5855 * tree.cs (RecordDecl): New function that abstracts the recording
5856 of names. This reports error 101, and provides a pointer to the
5857 previous declaration. Fixes a crash in the compiler.
5859 * cs-parser.jay (constructor_declaration): Update to new grammar,
5860 and provide a constructor_body that can be empty.
5862 2002-03-15 Miguel de Icaza <miguel@ximian.com>
5864 * driver.cs: Add support for --resources.
5866 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
5867 Make all types for the various array helper methods be integer.
5869 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
5870 CheckState to ConvCast.
5872 (ConvCast): Now it takes a `checked' state argument, to avoid
5873 depending on the emit context for the conversion, and just using
5874 the resolve time setting.
5876 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
5877 instead of Invocation.EmitArguments. We do not emit the original
5878 arguments, instead we emit those which have been converted to
5879 unsigned int expressions.
5881 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
5883 * codegen.cs: ditto.
5885 * expression.cs (LocalVariableReference): Drop the use of the
5886 Store function that depended on the variable index.
5888 * statement.cs (VariableInfo): Drop the `Idx' property from this
5889 class, as this is not taking into account the indexes for
5890 temporaries tat we generate during the execution, getting the
5893 * class.cs: First emit class initializers, then call the parent
5896 * expression.cs (Binary): Fix opcode emision.
5897 (UnaryMutator.EmitCode): Support checked code generation
5899 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
5900 matches for events for both the Static and Instance scans,
5901 pointing to the same element. Fix that.
5903 2002-03-14 Miguel de Icaza <miguel@ximian.com>
5905 * rootcontext.cs (ResolveTree): Always set the
5906 interface_resolve_order, because nested interfaces will be calling
5909 * class.cs (GetInterfaceOrClass): Track the same resolution
5910 process used by TypeManager.LookupType. This fixes the nested
5911 type lookups in class declarations (separate path from
5914 (TypeContainer.DefineType): Also define nested interfaces.
5915 (TypeContainer.RegisterOrder): New public function used to
5916 register the order in which child interfaces need to be closed.
5918 Nested interfaces need to be closed after their parents have been
5921 * interface.cs (InterfaceAttr): Put all the logic for computing
5922 the interface attribute here.
5924 (DefineInterface): Register our interface order with the
5925 RootContext or with the TypeContainer depending on the case.
5927 2002-03-12 Miguel de Icaza <miguel@ximian.com>
5929 * cs-parser.jay: rework foreach statement to work with the new
5930 changes to the policy on SimpleNames.
5932 * report.cs: support Stacktrace on warnings as well.
5934 * makefile: drop --unsafe and /unsafe from the compile.
5936 2002-03-13 Ravi Pratap <ravi@ximian.com>
5938 * ecore.cs (StandardConversionExists): Modify to take an Expression
5939 as the first parameter. Ensure we do null -> reference type conversion
5942 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
5943 temporary Expression objects.
5945 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
5947 * interface.cs: workaround bug in method overloading resolution
5948 (there is already a bugzilla bug for it).
5950 2002-03-12 Miguel de Icaza <miguel@ximian.com>
5952 We could also solve this problem by having a separate path for
5953 performing type lookups, instead of DoResolve, we could have a
5954 ResolveType entry point, and only participating pieces of the
5955 production (simplename, deref, array) would implement this.
5957 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
5958 signal SimpleName to only resolve type names and not attempt to
5959 resolve anything else.
5961 * expression.cs (Cast): Set the flag.
5963 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
5965 * class.cs: Only report 108 if there is no `new' modifier.
5967 * cs-parser.jay: rework foreach statement to work with the new
5968 changes to the policy on SimpleNames.
5970 * report.cs: support Stacktrace on warnings as well.
5972 * makefile: drop --unsafe and /unsafe from the compile.
5974 2002-03-11 Miguel de Icaza <miguel@ximian.com>
5976 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
5977 lookups here, instead of doing that at parse time. This means
5978 that our grammar will not introduce `LocalVariableReferences' as
5979 expressions at this point. That solves the problem of code like
5987 This is only half the fix. The full fix requires parameters to
5988 also be handled in this way.
5990 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
5991 makes the use more obvious of the DeclSpace. The
5992 ec.TypeContainer.TypeBuilder is now only used to pull the
5995 My theory is that I can get rid of the TypeBuilder completely from
5996 the EmitContext, and have typecasts where it is used (from
5997 DeclSpace to where it matters).
5999 The only pending problem is that the code that implements Aliases
6000 is on TypeContainer, and probably should go in DeclSpace.
6002 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
6003 lookups here, instead of doing that at parse time. This means
6004 that our grammar will not introduce `LocalVariableReferences' as
6005 expressions at this point. That solves the problem of code like
6013 This is only half the fix. The full fix requires parameters to
6014 also be handled in this way.
6016 * class.cs (Property.DefineMethod): When implementing an interface
6017 method, set newslot, when implementing an abstract method, do not
6018 set the flag (before we tried never setting it, or always setting
6019 it, which is the difference).
6020 (Indexer.DefineMethod): same.
6021 (Method.DefineMethod): same.
6023 * ecore.cs: Only set the status used flag if we get back a Field.
6025 * attribute.cs: Temporary hack, so Paolo can keep working.
6027 2002-03-08 Ravi Pratap <ravi@ximian.com>
6029 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
6030 the unmanaged type in the case we have a MarshalAs attribute.
6032 (Resolve): Handle the case when we are parsing the special MarshalAs
6033 attribute [we need to store the unmanaged type to use later]
6035 * typemanager.cs (marshal_as_attr_type): Built in type for the
6036 MarshalAs Attribute.
6038 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
6039 on parameters and accordingly set the marshalling info.
6041 2002-03-09 Miguel de Icaza <miguel@ximian.com>
6043 * class.cs: Optimizing slightly by removing redundant code after
6044 we switched to the `NoTypes' return value.
6045 (Property.DefineMethod): use NoTypes here too.
6047 This fixes the bug I introduced in my last batch of changes.
6049 2002-03-05 Ravi Pratap <ravi@ximian.com>
6051 * tree.cs (RecordEnum): Add. We now keep track of enums too.
6053 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
6054 Enums since those are types too.
6056 * cs-parser.jay (enum_declaration): Record enums as we parse them.
6058 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
6059 thanks to a call during the lookup process.
6061 2002-03-07 Miguel de Icaza <miguel@ximian.com>
6063 * statement.cs (Foreach): Lots of work to accomodate a particular
6064 kind of foreach statement that I had not kept in mind. It is
6065 possible to have foreachs on classes that provide a GetEnumerator
6066 method that return objects that implement the "pattern" for using
6067 a foreach, there is no need to support GetEnumerator
6070 This is needed to compile nant.
6072 * decl.cs: Only report 114 if the member is not `Finalize' and if
6073 the warning level is at least 2.
6075 * class.cs: Moved the compare function from Method to
6078 (MethodSignature.InheritableMemberSignatureCompare): Add new
6079 filter function that is used to extract inheritable methods from a
6082 (Method.Define): Use the new `inheritable_method_signature_filter'
6085 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
6088 2002-03-06 Miguel de Icaza <miguel@ximian.com>
6090 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
6092 * cs-parser.jay: Add opt_semicolon to the interface declaration.
6094 * expression.cs: Pass location information to
6095 ConvertImplicitStandard.
6097 * class.cs: Added debugging code to track return values from
6100 2002-03-05 Miguel de Icaza <miguel@ximian.com>
6102 * expression.cs (Is.DoResolve): If either side of the `is' is an
6103 interface, do not flag the warning.
6105 * ecore.cs (ImplicitReferenceConversion): We need a separate test
6108 * report.cs: Allow for --fatal to be used with --probe.
6110 * typemanager.cs (NoTypes): Move the definition for the empty Type
6113 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
6115 (TypeContainer.DefineProxy): New function used to proxy to parent
6116 implementations when implementing interfaces.
6117 (TypeContainer.ParentImplements): used to lookup if our parent
6118 implements a public function that is required by an interface.
6119 (TypeContainer.VerifyPendingMethods): Hook this up.
6121 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
6122 `modules' and `assemblies' arraylists into arrays. We only grow
6123 these are the very early start up of the program, so this improves
6124 the speedof LookupType (nicely measured).
6126 * expression.cs (MakeByteBlob): Replaced unsafe code with
6127 BitConverter, as suggested by Paolo.
6129 * cfold.cs (ConstantFold.Binary): Special case: perform constant
6130 folding of string concatenation, but if either side is a string,
6131 and the other is not, then return null, and let the runtime use
6132 the concatenation on the string plus the object (using
6135 2002-03-04 Miguel de Icaza <miguel@ximian.com>
6137 Constant Folding has been implemented now.
6139 * expression.cs (Unary.Reduce): Do not throw an exception, catch
6140 the error instead on types that are not supported in one's
6143 * constant.cs (Constant and all children): New set of functions to
6144 perform implict and explicit conversions.
6146 * ecore.cs (EnumConstant): Implement the new functions to perform
6147 conversion by proxying to the child expression.
6149 * codegen.cs: (ConstantCheckState): Constant evaluation has its
6150 own separate setting that can not be turned off from the command
6151 line using --unchecked or --checked and is only controlled using
6152 the checked/unchecked statements and expressions. This setting is
6153 used by the constant folder to flag errors.
6155 * expression.cs (CheckedExpr, UncheckedExpr): Set the
6156 ConstantCheckState as well.
6158 During Resolve, they also have to flag the state, because the
6159 constant folder runs completely in the Resolve phase.
6161 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
6164 2002-03-01 Miguel de Icaza <miguel@ximian.com>
6166 * cfold.cs: New file, this file contains the constant folder.
6168 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
6169 argument to track whether we are using the resulting address to
6170 load or store a value and provide better error messages.
6172 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
6173 new AddressOf arguments.
6175 * statement.cs (Foreach.EmitCollectionForeach): Update
6177 * expression.cs (Argument.Emit): Call AddressOf with proper
6178 arguments to track usage.
6180 (New.DoEmit): Call AddressOf with new arguments.
6182 (Unary.Emit): Adjust AddressOf call.
6184 2002-03-01 Ravi Pratap <ravi@ximian.com>
6186 * cs-parser.jay (member_access): Change the case for pre-defined types
6187 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
6190 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
6193 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
6194 essentially like methods and apply attributes like MethodImplOptions to them too.
6196 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
6199 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
6200 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
6203 * Update code everywhere accordingly.
6205 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
6207 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
6209 2002-02-28 Ravi Pratap <ravi@ximian.com>
6211 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
6212 try performing lookups against those instead of jumping straight into using
6213 the 'using' clauses.
6215 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
6217 (LookupType): Perform lookups in implicit parents too.
6219 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
6220 sequence as RootContext.LookupType.
6222 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
6223 the various cases of namespace lookups into this method.
6225 2002-03-01 Miguel de Icaza <miguel@ximian.com>
6227 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
6228 in positional arguments)
6230 * class.cs (Operator): Update the AllowedModifiers to contain
6233 * cs-parser.jay: Update operator declaration to allow for the
6234 operator body to be empty.
6236 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
6239 2002-02-27 Miguel de Icaza <miguel@ximian.com>
6241 * class.cs (Method.Emit): Label parameters.
6243 * driver.cs: Return 1 or 0 as the program exit code.
6245 2002-02-26 Miguel de Icaza <miguel@ximian.com>
6247 * expression.cs: Special case the `null' object when trying to
6248 auto-compute the type, as anything can be explicitly converted to
6251 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
6252 spotting this Paolo.
6254 (Expression.ImplicitNumericConversion): Perform comparissions of
6255 the type using the underlying type in the case of an enumeration
6256 rather than using the enumeration type for the compare.
6258 Cope with the underlying == type case, which is not possible to
6261 (Expression.ConvertNumericExplicit): Perform comparissions of
6262 the type using the underlying type in the case of an enumeration
6263 rather than using the enumeration type for the compare.
6265 * driver.cs: If the user does not supply an extension, assume .exe
6267 * cs-parser.jay (if_statement): Rewrote so that we can track the
6268 location for the if statement.
6270 * expression.cs (Binary.ConstantFold): Only concat strings when
6271 the operation is "+", not everything ;-)
6273 * statement.cs (Statement.EmitBoolExpression): Take a location
6275 (If, While, Do): Track location.
6277 * expression.cs (Binary.ResolveOperator): In the object + string
6278 case, I was missing a call to ConvertImplicit
6280 2002-02-25 Ravi Pratap <ravi@ximian.com>
6282 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
6283 Location arguments. Ensure we use RootContext.LookupType to do our work
6284 and not try to do a direct Type.GetType and ModuleBuilder.GetType
6286 * interface.cs (PopulateMethod): Handle the type of the parameter being
6289 * expression.cs (Invocation.BetterFunction): Handle the case when we
6290 have a params method with no fixed arguments and a call is made with no
6293 2002-02-25 Miguel de Icaza <miguel@ximian.com>
6295 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
6296 the verbatim-string-literal
6298 * support.cs (InternalParameters.ParameterModifier): handle null
6300 (InternalParameters.ParameterType): ditto.
6302 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
6303 duplicating the name of the variable parameter.
6304 (GetParameterByName): Fix bug where we were not looking up array
6305 paramters if they were the only present (thanks Paolo!).
6306 (GetParameterInfo): We only have an empty set of types if both
6307 fixed and array are set to null.
6308 (GetParameterInfo-idx): Handle FixedParameter == null
6310 * cs-parser.jay: Handle the case where there is no catch
6311 statements (missing null test).
6313 2002-02-22 Miguel de Icaza <miguel@ximian.com>
6315 * driver.cs (MainDriver): Be conservative on our command line
6318 Catch DirectoryNotFoundException when calling GetFiles.
6320 (SplitPathAndPattern): Used to split the input specification into
6321 a path and a pattern that we can feed to Directory.GetFiles.
6323 2002-02-21 Miguel de Icaza <miguel@ximian.com>
6325 * statement.cs (Fixed): Implement the last case of the Fixed
6326 statement (string handling).
6328 * expression.cs (StringPtr): New class used to return a char * to
6329 a string; Used by the Fixed statement.
6331 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
6333 * expression.cs (Binary.ResolveOperator): Remove redundant
6334 MemberLookup pn parent type.
6335 Optimize union call, we do not need a union if the types are the same.
6336 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
6339 Specialize the use of MemberLookup everywhere, instead of using
6340 the default settings.
6342 (StackAlloc): Implement stackalloc keyword.
6344 * cs-parser.jay: Add rule to parse stackalloc.
6346 * driver.cs: Handle /h, /help, /?
6348 * expression.cs (MakeByteBlob): Removed the hacks we had in place
6349 before we supported unsafe code.
6351 * makefile: add --unsafe to the self compilation of mcs.
6353 2002-02-20 Miguel de Icaza <miguel@ximian.com>
6355 * expression.cs (PointerArithmetic): New class that is used to
6356 perform pointer arithmetic.
6357 (Binary.Resolve): Handle pointer arithmetic
6358 Handle pointer comparission.
6359 (ArrayPtr): Utility expression class that is used to take the
6360 address of an array.
6362 (ElementAccess): Implement array access for pointers
6364 * statement.cs (Fixed): Implement fixed statement for arrays, we
6365 are missing one more case before we are done.
6367 * expression.cs (Indirection): Implement EmitAssign and set the
6368 ExprClass to Variable. This allows pointer dereferences to be
6369 treated as variables, and to have values assigned to them.
6371 * ecore.cs (Expression.StoreFromPtr): New utility function to
6372 store values dereferencing.
6374 2002-02-20 Ravi Pratap <ravi@ximian.com>
6376 * expression.cs (Binary.ResolveOperator): Ensure that we are
6377 not trying to operate on a void type - this fixes the reported
6380 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
6381 the parent implementation is sealed.
6383 * ../errors/cs0239.cs : Add.
6385 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
6387 * typemanager.cs (unverifiable_code_type): Corresponds to
6388 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
6389 which have unsafe code in them.
6391 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
6394 2002-02-19 Miguel de Icaza <miguel@ximian.com>
6396 * cs-tokenizer.cs: Add support for @"litreal strings"
6398 Make tokenizer accept pre-processor directives
6399 on any column (remove the old C-like limitation).
6401 * rootcontext.cs (EmitCode): Emit any global attributes.
6402 (AddGlobalAttributes): Used to keep track of assembly attributes.
6404 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
6406 * cs-parser.jay: Add support for global attributes.
6408 2002-02-17 Miguel de Icaza <miguel@ximian.com>
6410 * expression.cs (Indirection): New helper class. Unary will
6411 create Indirection classes to be able to implement the
6412 IMemoryLocation interface on it.
6414 2002-02-16 Miguel de Icaza <miguel@ximian.com>
6416 * cs-parser.jay (fixed_statement): reference the right statement.
6418 * statement.cs (Fixed.Emit): Finish implementing the fixed
6419 statement for the &x case.
6421 2002-02-14 Miguel de Icaza <miguel@ximian.com>
6423 * class.cs (Property.Define, Method.Define): Remove newslot when
6426 * modifiers.cs: My use of NewSlot when `Abstract' was set was
6427 wrong. NewSlot should only be used if the `new' keyword is present.
6429 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
6430 locating our system dir. Sorry about this.
6432 2002-02-13 Miguel de Icaza <miguel@ximian.com>
6434 * driver.cs (GetSystemDir): Compute correctly the location of our
6435 system assemblies. I was using the compiler directory instead of
6436 the library directory.
6438 2002-02-13 Ravi Pratap <ravi@ximian.com>
6440 * expression.cs (BetterFunction): Put back in what Miguel commented out
6441 since it is the correct fix. The problem is elsewhere ;-)
6443 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
6444 parameters of the parms method are themselves compatible or not !
6446 (StandardConversionExists): Fix very dangerous bug where we were forgetting
6447 to check that a class implements an interface before saying that an implicit
6448 conversion was allowed. Use ImplementsInterface to do the checking.
6450 2002-02-13 Miguel de Icaza <miguel@ximian.com>
6452 * class.cs (Method.Define): Track whether we are an explicit
6453 implementation or not. And only call DefineMethodOverride if we
6454 are an explicit implementation.
6456 (Property.DefineMethod): Ditto.
6458 2002-02-11 Ravi Pratap <ravi@ximian.com>
6460 * expression.cs (BetterFunction): Catch hideous bug which was
6461 preventing us from detecting ambiguous calls due to implicit casts i.e
6464 2002-01-29 Miguel de Icaza <miguel@ximian.com>
6466 * support.cs (Pair): Remove un-needed method. I figured why I was
6467 getting the error in cs-parser.jay, the variable in a foreach loop
6468 is readonly, and the compiler does not really treat this as a variable.
6470 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
6471 instead of EQUALS in grammar.
6473 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
6475 * expression.cs (Unary.DoResolve): Check whether the argument is
6478 2002-01-28 Miguel de Icaza <miguel@ximian.com>
6480 * support.cs: Api for Pair to set a value. Despite the fact that
6481 the variables are public the MS C# compiler refuses to compile
6482 code that accesses the field if the variable is part of a foreach
6485 * statement.cs (Fixed): Begin implementation of the fixed
6488 (Block.AddVariable): Return the VariableInfo on success and null
6489 on failure instead of true/false.
6491 * cs-parser.jay (foreach): Catch errors on variables already
6492 defined (we were ignoring this value before) and properly unwind
6495 (fixed_statement): grammar for the fixed statement.
6497 2002-01-25 Miguel de Icaza <miguel@ximian.com>
6499 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
6500 pointer types to be incretemented.
6502 (SizeOf): Implement.
6504 * cs-parser.jay (pointer_member_access): Implement
6505 expr->IDENTIFIER production.
6507 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
6508 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
6511 (Unary): Implement indirection.
6513 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
6514 use in non-unsafe context).
6516 (SimpleName.DoResolve): Check for pointers in field access on safe
6519 (Expression.LoadFromPtr): Factor the load-indirect code in this
6520 function. This was duplicated in UnboxCast and ParameterReference
6522 2002-01-24 Miguel de Icaza <miguel@ximian.com>
6524 * expression.cs (ComposedCast): report an error if a pointer cast
6525 is used in a safe region.
6527 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
6528 pointer type casts in unsafe context.
6530 * codegen.cs (EmitContext): Set up IsUnsafe.
6532 * cs-parser.jay (non_expression_type): Add productions for pointer
6535 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
6536 code. We should not use force into static mode if the method is
6537 not virtual. Fixes bug in MIS
6539 * statement.cs (Do.Emit, While.Emit, For.Emit,
6540 Statement.EmitBoolExpression): Add support to Do and While to
6541 propagate infinite loop as `I do return' semantics.
6543 Improve the For case to also test for boolean constants.
6545 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
6546 to the list of attributes we can add.
6548 Remove `EmitContext' argument.
6550 * class.cs (Method.Define): Apply parameter attributes.
6551 (Constructor.Define): Apply parameter attributes.
6552 (MethodCore.LabelParameters): Move here the core of labeling
6555 * support.cs (ReflectionParameters.ParameterModifier,
6556 InternalParameters.ParameterModifier): Use IsByRef on the type and
6557 only return the OUT bit for these parameters instead of in/out/ref
6560 This is because I miss-understood things. The ParameterInfo.IsIn
6561 and IsOut represent whether the parameter has the [In] and [Out]
6564 2002-01-22 Miguel de Icaza <miguel@ximian.com>
6566 * ecore.cs (FieldExpr.Emit): Release temporaries.
6568 * assign.cs (LocalTemporary.Release): new function.
6570 * codegen.cs (EmitContext.GetTemporaryStorage,
6571 EmitContext.FreeTemporaryStorage): Rework the way we deal with
6572 temporary storage. Now we can "put back" localbuilders when we
6575 2002-01-21 Miguel de Icaza <miguel@ximian.com>
6577 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
6578 need to make a copy of the variable to generate verifiable code.
6580 2002-01-19 Miguel de Icaza <miguel@ximian.com>
6582 * driver.cs: Compute dynamically the system directory.
6584 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
6585 Slower, but more generally useful. Used by the abstract
6586 registering implementation.
6588 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
6589 the rules for the special rule on Type/instances. First check if
6590 we have the same name, and if so, try that special static path
6591 rather than the instance path.
6593 2002-01-18 Miguel de Icaza <miguel@ximian.com>
6595 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
6598 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
6599 Enum, ValueType, Delegate or Array for non-corlib compiles.
6601 * cs-tokenizer.cs: Catch long identifiers (645)
6603 * typemanager.cs (IndexerPropetyName): Ravi never tested this
6606 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
6607 fix, we were returning too early, so we were not registering
6608 pending methods from abstract classes.
6610 Do not register pending methods if the class is abstract.
6612 * expression.cs (Conditional.DoResolve): Report circular implicit
6613 conversions when we neecd to compute it for conditional
6616 (Is.DoResolve): If the expression is always of the provided type,
6617 flag warning 183. If the expression can not ever be of the
6618 provided type flag warning 184.
6620 * class.cs: Catch 169 as well.
6622 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
6625 2002-01-18 Nick Drochak <ndrochak@gol.com>
6627 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
6629 2002-01-17 Miguel de Icaza <miguel@ximian.com>
6631 * interface.cs: (PopulateMethod): Check for pointers being defined
6632 only if the unsafe context is active.
6633 (PopulateProperty): ditto.
6634 (PopulateIndexer): ditto.
6636 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
6637 specified. If pointers are present, make sure that they are
6638 present in an unsafe context.
6639 (Constructor, Constructor.Define): ditto.
6640 (Field, Field.Define): ditto.
6641 (Property, Property.Define): ditto.
6642 (Event, Event.Define): ditto.
6644 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
6645 hashtable if there are classes or structs defined.
6647 * expression.cs (LocalVariableReference.DoResolve): Simplify this
6648 code, as the constant resolution moved.
6650 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
6651 the metadata, so we can flag error 133.
6653 * decl.cs (MemberCore.UnsafeOK): New function to test that a
6654 pointer is being declared in an unsafe context.
6656 2002-01-16 Miguel de Icaza <miguel@ximian.com>
6658 * modifiers.cs (Modifiers.Check): Require a Location argument.
6659 Report error 227 for Unsafe use.
6661 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
6663 * statement.cs (For.Emit): If the test is null, then report that
6664 we do `return', as we wont reach anything afterwards.
6666 (Switch.SwitchGoverningType): Track the expression that matched
6669 * driver.cs: Allow negative numbers as an error code to flag.
6671 * cs-parser.jay: Handle 1551.
6673 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
6675 2002-01-15 Miguel de Icaza <miguel@ximian.com>
6677 * cs-parser.jay: Report 1518 (type declaration can only contain
6678 class, struct, interface, enum or delegate)
6680 (switch_label): Report 1523 (keywords `case' or `default' must
6683 (opt_switch_sections): Report 1522 (empty switch)
6685 * driver.cs: Report 1515 (response file specified multiple times)
6686 Report 1516 (Source file specified multiple times).
6688 * expression.cs (Argument.Resolve): Signal 1510
6690 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
6691 access not allowed in static code)
6693 2002-01-11 Ravi Pratap <ravi@ximian.com>
6695 * typemanager.cs (IsPointerType): Utility method which we are going
6698 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
6699 the object type, so we take care of that.
6701 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
6703 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
6704 added to non-params parameters :-)
6706 * typemanager.cs (CSharpName): Include 'void' type too.
6708 (void_ptr_type): Include in the set of core types.
6710 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
6713 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
6716 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
6717 completely forgotten about it.
6719 2002-01-10 Ravi Pratap <ravi@ximian.com>
6721 * cs-parser.jay (pointer_type): Add. This begins our implementation
6722 of parsing rules for unsafe code.
6724 (unsafe_statement): Implement.
6726 (embedded_statement): Modify to include the above.
6728 * statement.cs (Unsafe): Implement new class for unsafe blocks.
6730 * codegen.cs (EmitContext.InUnsafe): Add. This determines
6731 if the current context is an unsafe one.
6733 * cs-parser.jay (local_variable_pointer_type): Since local variable types
6734 are handled differently, we need separate rules for them.
6736 (local_variable_declaration): Update to use local_variable_pointer_type
6737 to allow variable declarations of unmanaged pointer types.
6739 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
6742 * ../errors/cs0214.cs : Add.
6744 2002-01-16 Nick Drochak <ndrochak@gol.com>
6746 * makefile: remove 'response' file when cleaning.
6748 2002-01-15 Miguel de Icaza <miguel@ximian.com>
6750 * cs-parser.jay: Report 1524.
6752 2002-01-14 Miguel de Icaza <miguel@ximian.com>
6754 * typemanager.cs (RegisterMethod): drop checking if we have
6755 registered this from here
6757 2002-01-12 Miguel de Icaza <miguel@ximian.com>
6759 * class.cs (Method.EmitDestructor): Implement calling our base
6762 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
6765 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
6766 this routine and will wrap the call in a try/catch block. Deal
6769 2002-01-11 Miguel de Icaza <miguel@ximian.com>
6771 * ecore.cs (Expression.MemberLookup): instead of taking a
6772 parameter `same_type' that was used to tell whether we could
6773 access private members we compute our containing type from the
6776 (FieldExpr): Added partial support for volatile fields. This does
6777 not work for volatile fields exposed from assemblies, as I can not
6778 figure out how to extract the modreq from it.
6780 Updated all the source files to use this.
6782 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
6783 because it is referenced by MemberLookup very often.
6785 2002-01-09 Ravi Pratap <ravi@ximian.com>
6787 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
6788 TypeBuilder.GetCustomAttributes to retrieve what we need.
6790 Get rid of redundant default_member_attr_type as this is the same as
6791 default_member_type which already exists.
6793 * interface.cs, attribute.cs : Update accordingly.
6795 2002-01-08 Miguel de Icaza <miguel@ximian.com>
6797 * typemanager.cs: Enable IndexerPropertyName again. It does not
6798 work for TYpeBuilders though. Ravi, can you please fix this?
6800 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
6802 * expression.cs (Argument.Emit): Handle the case of ref objects
6803 being passed to ref functions;
6805 (ParameterReference.EmitLoad): Loads the content of the pointer
6806 without dereferencing.
6808 2002-01-07 Miguel de Icaza <miguel@ximian.com>
6810 * cs-tokenizer.cs: Implemented the pre-processing expressions.
6812 2002-01-08 Ravi Pratap <ravi@ximian.com>
6814 * class.cs (Indexer.DefineMethod): Incorporate the interface
6815 type in the name of the method if we are doing explicit interface
6818 * expression.cs (ConversionExists): Remove as it is completely obsolete.
6820 (BetterConversion): Fix extremely trivial bug where we were referring to
6821 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
6824 * ../errors/bug16.cs : Add although we have fixed it.
6826 2002-01-07 Miguel de Icaza <miguel@ximian.com>
6828 * expression.cs (BaseIndexer): Begin implementation.
6830 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
6832 * cs-parser.jay (indexer_declarator): Use qualified_identifier
6833 production directly to remove a shift/reduce, and implement
6834 explicit interface implementation.
6836 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
6837 after a floating point suffix.
6839 * expression.cs (DoNumericPromotions): Improved the conversion for
6840 uint/uint. If we have a constant, we avoid doing a typecast to a
6843 * class.cs (Indexer): Implement explicit interface implementation
6846 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
6848 * class.cs: make the default instance constructor public and hidebysig.
6850 2001-01-03 Ravi Pratap <ravi@ximian.com>
6852 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
6853 so we can call it from elsewhere.
6855 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
6856 we emit it internally if the class has a defined indexer; otherwise the user
6857 emits it by decorating the class definition with the DefaultMemberAttribute.
6859 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
6860 attribute is not used on a type which defines an indexer.
6862 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
6863 character when we skip whitespace.
6865 * ../errors/cs0646.cs : Add.
6867 2002-01-03 Miguel de Icaza <miguel@ximian.com>
6869 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
6872 * makefile: Add practical target `mcs3.exe' which builds the third
6873 generation compiler.
6875 * expression.cs (New): Fix structures constructor calling.
6877 * class.cs (Property, Method, Indexer): Emit Final flag on the
6878 method if we are an interface implementation and we are not
6881 * ecore.cs (PropertyExpr): New public field `IsBase', tells
6882 whether this property is referencing a `base' method.
6884 * expression.cs (Invocation.EmitCall): take an extra argument:
6885 is_base, this is used to determine whether the `call' or
6886 `callvirt' opcode should be used.
6889 * delegate.cs: update EmitCall.
6891 * class.cs (Method.Define): Set NewSlot for the cases where we are
6892 not implementing an interface method.
6894 (Property.Define): ditto.
6896 2002-01-02 Miguel de Icaza <miguel@ximian.com>
6898 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
6899 'r'. Allows mcs to parse itself fully.
6901 2002-01-02 Ravi Pratap <ravi@ximian.com>
6903 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
6904 of the number of initializers that require the InitializeArray method.
6906 (CheckIndices): Store the Expression in all cases - not the plain value. Also
6907 update the above field where necessary.
6909 (MakeByteBlob): Update accordingly.
6911 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
6914 (EmitDynamicInitializers): Update in accordance with the new optimization.
6916 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
6917 same OpCode applies.
6919 * cs-parser.jay : Fix some glaring errors I introduced.
6921 2002-01-01 Ravi Pratap <ravi@ximian.com>
6923 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
6924 so that we can check for name clashes there too.
6926 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
6927 for interface indexers.
6929 * interfaces.cs (Define): Emit the default member attribute.
6931 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
6932 variable was being referred to while setting the value ;-)
6934 2002-01-01 Miguel de Icaza <miguel@ximian.com>
6936 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
6937 byte-by-byte information when we know the data is zero.
6939 Make the block always a multiple of 4, because
6940 DefineInitializedData has a bug.
6942 * assign.cs: Fix, we should assign from the temporary, not from
6945 * expression.cs (MakeByteBlob): Fix my incorrect code.
6947 2001-12-31 Miguel de Icaza <miguel@ximian.com>
6949 * typemanager.cs (EnumToUnderlying): This function is used to get
6950 the underlying type from an enumeration, because it does not
6953 * constant.cs: Use the I4_S form for values between -128 and 127.
6955 * statement.cs (Block.LookupLabel): Looks up a label.
6956 (Block): Drop support for labeled blocks.
6958 (LabeledStatement): New kind of statement that represents a label
6961 (Goto): Finally implement this bad boy.
6963 * cs-parser.jay: Update to reflect new mechanism to implement
6966 2001-12-30 Miguel de Icaza <miguel@ximian.com>
6968 * codegen.cs (EmitContext.This): a codegen property that keeps the
6969 a single instance of this instead of creating many different this
6972 * delegate.cs (Delegate.DoResolve): Update to use the property;
6974 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
6976 * expression.cs (BaseAccess.DoResolve): Ditto.
6978 2001-12-29 Ravi Pratap <ravi@ximian.com>
6980 * typemanager.cs (methodimpl_attr_type): Add to hold the type
6981 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
6983 (InitCoreTypes): Update accordingly.
6985 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
6986 so we can quickly store the state.
6988 (ApplyAttributes): Set the correct implementation flags
6989 for InternalCall methods.
6991 2001-12-29 Miguel de Icaza <miguel@ximian.com>
6993 * expression.cs (EmitCall): if a method is not virtual, then do
6994 not use callvirt on it.
6996 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
6997 user defined stuff) requires the use of stobj, which takes an
6998 address on the stack instead of an array and an index. So emit
6999 the Ldelema operation for it.
7001 (EmitStoreOpcode): Use stobj for valuetypes.
7003 (UnaryMutator.EmitCode): Use the right 1 value depending on
7004 whether we are dealing with int64/uint64, float or doubles.
7006 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
7007 constructors that I implemented last night.
7009 (Constructor.IsDefault): Fix to work properly for static
7012 * cs-parser.jay (CheckDef): report method signature errors.
7013 Update error number 103 to be 132.
7015 * decl.cs: New AdditionResult enumeration value: MethodExists.
7016 Although we do this check for methods later on in the semantic
7017 analysis, catching repeated default constructors is so easy that
7018 we catch these here.
7020 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
7023 (ParameterReference.EmitAssign, Emit): handle
7026 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
7027 (ArrayAccess.EmitStoreOpcode): ditto.
7029 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
7031 * expression.cs (MakeByteBlob): Complete all the missing types
7032 (uint, short, ushort, byte, sbyte)
7034 * class.cs: Only init instance field initializers on instance
7037 Rename `constructors' to instance_constructors.
7039 (TypeContainer.AddConstructor): Only add constructors to the list
7040 if it is not static.
7042 Make sure that we handle default_static_constructor independently
7043 everywhere where we handle instance_constructors
7045 2001-12-28 Miguel de Icaza <miguel@ximian.com>
7047 * class.cs: Do not lookup or create a base initializer for a
7050 (ConstructorInitializer.Resolve): use the proper type to lookup
7053 * cs-parser.jay: Report error 1585 (modifiers between type and name).
7055 * enum.cs, interface.cs: Remove CloseType, this is taken care by
7058 * decl.cs: CloseType is now an virtual method, the default
7059 implementation just closes this type.
7061 2001-12-28 Ravi Pratap <ravi@ximian.com>
7063 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
7064 to PreserveSig by default. Also emit HideBySig on such methods.
7066 Basically, set the defaults to standard values.
7068 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
7069 argument, if candidate is better, it can't be worse than the best !
7071 (Invocation): Re-write bits to differentiate between methods being
7072 applicable in their expanded form and their normal form - for params
7075 Get rid of use_standard everywhere as only standard conversions are allowed
7076 in overload resolution.
7078 More spec conformance.
7080 2001-12-27 Miguel de Icaza <miguel@ximian.com>
7082 * driver.cs: Add --timestamp, to see where the compiler spends
7085 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
7086 `this' in static code.
7088 (SimpleName.DoResolve): Implement in terms of a helper function
7089 that allows static-references to be passed upstream to
7092 (Expression.ResolveWithSimpleName): Resolve specially simple
7093 names when called by MemberAccess to implement the special
7096 (Expression.ImplicitReferenceConversion): Handle conversions from
7097 Null to reference types before others, as Null's type is
7100 * expression.cs (Invocation.EmitCall): Handle the special case of
7101 calling methods declared on a reference type from a ValueType
7102 (Base classes System.Object and System.Enum)
7104 (MemberAccess.Resolve): Only perform lookups on Enumerations if
7105 the left hand side is a TypeExpr, not on every enumeration.
7107 (Binary.Resolve): If types are reference types, then do a cast to
7108 object on operators != and == of both arguments.
7110 * typemanager.cs (FindMembers): Extract instance and static
7111 members if requested.
7113 * interface.cs (PopulateProperty): Use void_type instead of null
7114 as the return type for the setter method.
7116 (PopulateIndexer): ditto.
7118 2001-12-27 Ravi Pratap <ravi@ximian.com>
7120 * support.cs (ReflectionParameters): Fix minor bug where we
7121 were examining the wrong parameter for the ParamArray attribute.
7123 Cope with requests for the type of the parameter at position
7124 greater than the params parameter's. We now return the element
7125 type of the params array as that makes more sense.
7127 * expression.cs (Invocation.IsParamsMethodApplicable): Update
7128 accordingly as we no longer have to extract the element type
7131 (Invocation.OverloadResolve): Update.
7133 2001-12-27 Miguel de Icaza <miguel@ximian.com>
7135 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
7136 against IEnumerator, test whether the return value is a descendant
7137 of the IEnumerator interface.
7139 * class.cs (Indexer.Define): Use an auxiliary method to implement
7140 the other bits of the method definition. Begin support for
7141 explicit interface implementation.
7143 (Property.DefineMethod): Use TypeManager.void_type instead of null
7144 for an empty return value.
7146 2001-12-26 Miguel de Icaza <miguel@ximian.com>
7148 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
7149 dealing with a FieldExpr which is composed of a FieldBuilder, in
7150 the code path we did extract the constant, but we should have
7151 obtained the underlying value to be able to cast it (otherwise we
7152 end up in an infinite loop, this is what Ravi was running into).
7154 (ArrayCreation.UpdateIndices): Arrays might be empty.
7156 (MemberAccess.ResolveMemberAccess): Add support for section
7157 14.5.4.1 that deals with the special case of E.I when E is a type
7158 and something else, that I can be a reference to a static member.
7160 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
7161 handle a particular array type to create byte blobs, it is just
7162 something we dont generate byteblobs for.
7164 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
7167 * location.cs (Push): remove the key from the hashtable that we
7168 are about to add. This happens for empty files.
7170 * driver.cs: Dispose files after we have parsed them.
7172 (tokenize): new function that only runs the tokenizer on its
7173 input, for speed testing.
7175 2001-12-26 Ravi Pratap <ravi@ximian.com>
7177 * class.cs (Event.Define): Define the private field only if there
7178 are no accessors defined.
7180 * expression.cs (ResolveMemberAccess): If there is no associated
7181 field with the event, that means we have an event defined with its
7182 own accessors and we should flag error cs0070 since transforming
7183 ourselves into a field is not valid in that case.
7185 * ecore.cs (SimpleName.DoResolve): Same as above.
7187 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
7188 and charset to sane values.
7190 2001-12-25 Ravi Pratap <ravi@ximian.com>
7192 * assign.cs (DoResolve): Perform check on events only if they
7193 are being accessed outside the declaring type.
7195 * cs-parser.jay (event_declarations): Update rules to correctly
7196 set the type of the implicit parameter etc.
7198 (add_accessor, remove_accessor): Set current local parameters.
7200 * expression.cs (Binary): For delegate addition and subtraction,
7201 cast the return value from the method into the appropriate delegate
7204 2001-12-24 Ravi Pratap <ravi@ximian.com>
7206 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
7207 of these as the workaround is unnecessary.
7209 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
7210 delegate data - none of that is needed at all.
7212 Re-write bits to extract the instance expression and the delegate method
7215 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
7218 * attribute.cs (ApplyAttributes): New method to take care of common tasks
7219 of attaching attributes instead of duplicating code everywhere.
7221 * everywhere : Update code to do attribute emission using the above method.
7223 2001-12-23 Miguel de Icaza <miguel@ximian.com>
7225 * expression.cs (IsParamsMethodApplicable): if there are not
7226 parameters, return immediately.
7228 * ecore.cs: The 0 literal can be implicity converted to an enum
7231 (SimpleName.DoResolve): First lookup the type, then lookup the
7234 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
7235 want to get its address. If the InstanceExpression is not
7236 addressable, store the result in a temporary variable, then get
7239 * codegen.cs: Only display 219 errors on warning level or above.
7241 * expression.cs (ArrayAccess): Make it implement the
7242 IMemoryLocation interface.
7244 (Binary.DoResolve): handle the operator == (object a, object b)
7245 and operator != (object a, object b) without incurring into a
7246 BoxedCast (because 5 != o should never be performed).
7248 Handle binary enumerator operators.
7250 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
7251 value type, otherwise use Ldelem_ref.
7253 Use precomputed names;
7255 (AddressOf): Implement address of
7257 * cs-parser.jay (labeled_statement): Fix recursive block
7258 addition by reworking the production.
7260 * expression.cs (New.DoEmit): New has a special case:
7262 If we are dealing with a ValueType, we have a few
7263 situations to deal with:
7265 * The target of New is a ValueType variable, that is
7266 easy, we just pass this as the variable reference
7268 * The target of New is being passed as an argument,
7269 to a boxing operation or a function that takes a
7272 In this case, we need to create a temporary variable
7273 that is the argument of New.
7276 2001-12-23 Ravi Pratap <ravi@ximian.com>
7278 * rootcontext.cs (LookupType): Check that current_type is not null before
7279 going about looking at nested types.
7281 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
7282 not implement the IAssignMethod interface any more.
7284 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
7285 where we tranform them into FieldExprs if they are being resolved from within
7288 * ecore.cs (SimpleName.DoResolve): Do the same here.
7290 * assign.cs (DoResolve, Emit): Clean up code considerably.
7292 * ../errors/bug10.cs : Add.
7294 * ../errors/cs0070.cs : Add.
7296 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
7298 * assign.cs : Get rid of EventIsLocal everywhere.
7300 2001-12-23 Miguel de Icaza <miguel@ximian.com>
7302 * ecore.cs (ConvertIntLiteral): finished the implementation.
7304 * statement.cs (SwitchLabel): Convert the value we are using as a
7305 key before looking up the table.
7307 2001-12-22 Miguel de Icaza <miguel@ximian.com>
7309 * codegen.cs (EmitTopBlock): Require a Location argument now.
7311 * cs-parser.jay (constructor_declarator): We need to setup
7312 current_local_parameters before we parse the
7313 opt_constructor_initializer, to allow the variables to be bound
7314 to the constructor arguments.
7316 * rootcontext.cs (LookupType): First lookup nested classes in our
7317 class and our parents before we go looking outside our class.
7319 * expression.cs (ConstantFold): Extract/debox the values at the
7322 * rootcontext.cs (EmitCode): Resolve the constants first before we
7323 resolve the types. This is not really needed, but it helps debugging.
7325 * statement.cs: report location.
7327 * cs-parser.jay: pass location to throw statement.
7329 * driver.cs: Small bug fix.
7331 * report.cs: Updated format to be 4-zero filled digits.
7333 2001-12-22 Ravi Pratap <ravi@ximian.com>
7335 * expression.cs (CheckIndices): Fix minor bug where the wrong
7336 variable was being referred to ;-)
7338 (DoEmit): Do not call EmitStaticInitializers when the
7339 underlying type is System.Object.
7341 2001-12-21 Ravi Pratap <ravi@ximian.com>
7343 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
7344 and do the usual workaround for SRE.
7346 * class.cs (MyEventBuilder.EventType): New member to get at the type
7347 of the event, quickly.
7349 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
7351 * assign.cs (Assign.DoResolve): Handle the case when the target
7352 is an EventExpr and perform the necessary checks.
7354 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
7357 (SimpleName.MemberStaticCheck): Include check for EventExpr.
7359 (EventExpr): Set the type in the constructor itself since we
7360 are meant to be born fully resolved.
7362 (EventExpr.Define): Revert code I wrote earlier.
7364 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
7365 instance expression is null. The instance expression is a This in that case
7366 or a null, depending on whether it is a static method or not.
7368 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
7369 refers to more than one method.
7371 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
7372 and accordingly flag errors.
7374 2001-12-21 Miguel de Icaza <miguel@ximian.com>
7376 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
7378 2001-12-22 Miguel de Icaza <miguel@ximian.com>
7380 * location.cs (ToString): Provide useful rutine.
7382 2001-12-21 Miguel de Icaza <miguel@ximian.com>
7384 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
7385 objects, return the actual integral boxed.
7387 * statement.cs (SwitchLabel): define an ILLabel for each
7390 (Switch.CheckSwitch): If the value is a Literal, extract
7391 the underlying literal.
7393 Also in the unused hashtable we had, add the SwitchLabel so we can
7394 quickly look this value up.
7396 * constant.cs: Implement a bunch of new constants. Rewrite
7397 Literal based on this. Made changes everywhere to adapt to this.
7399 * expression.cs (Expression.MakeByteBlob): Optimize routine by
7400 dereferencing array only once, and also copes with enumrations.
7402 bytes are two bytes wide, not one.
7404 (Cast): Perform constant conversions.
7406 * ecore.cs (TryImplicitIntConversion): Return literals instead of
7407 wrappers to the literals here.
7409 * expression.cs (DoNumericPromotions): long literals can converted
7410 to ulong implicity (this is taken care of elsewhere, but I was
7413 * ecore.cs (Expression.Literalize): Make the return type Literal,
7414 to improve type checking.
7416 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
7418 2001-12-20 Miguel de Icaza <miguel@ximian.com>
7420 * literal.cs: Revert code from ravi that checked the bounds. The
7421 bounds are sane by the definition of the type itself.
7423 * typemanager.cs: Fix implementation of ImplementsInterface. We
7424 need to actually look up in our parent hierarchy for interfaces
7427 * const.cs: Use the underlying type for enumerations
7429 * delegate.cs: Compute the basename for the delegate creation,
7430 that should fix the delegate test case, and restore the correct
7431 Type Lookup semantics in rootcontext
7433 * rootcontext.cs: Revert Ravi's last patch. The correct way of
7434 referencing a nested type with the Reflection API is using the "+"
7437 * cs-parser.jay: Do not require EOF token at the end.
7439 2001-12-20 Ravi Pratap <ravi@ximian.com>
7441 * rootcontext.cs (LookupType): Concatenate type names with
7442 a '.' instead of a '+' The test suite passes again.
7444 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
7445 field of the enumeration.
7447 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
7448 the case when the member is an EventExpr.
7450 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
7451 static has an associated instance expression.
7453 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
7455 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
7457 * class.cs (Event.Define): Register event and perform appropriate checks
7460 We define the Add and Remove methods even if the use provides none because
7461 in that case, we provide default implementations ourselves.
7463 Define a private field of the type of the event. This is done by the CSC compiler
7464 and we should be doing it too ;-)
7466 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
7467 More methods we use in code we generate.
7469 (multicast_delegate_type, delegate_type): Two separate types since the distinction
7472 (InitCoreTypes): Update accordingly for the above.
7474 * class.cs (Event.Emit): Generate code for default accessors that we provide
7476 (EmitDefaultMethod): Do the job in the above.
7478 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
7481 2001-12-20 Miguel de Icaza <miguel@ximian.com>
7483 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
7484 builders even if we were missing one.
7486 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
7487 pass the Basename as our class name instead of the Name. The
7488 basename will be correctly composed for us.
7490 * parameter.cs (Paramters): Now takes a Location argument.
7492 * decl.cs (DeclSpace.LookupType): Removed convenience function and
7493 make all the code call directly LookupType in RootContext and take
7494 this chance to pass the Location information everywhere.
7496 * Everywhere: pass Location information.
7498 2001-12-19 Miguel de Icaza <miguel@ximian.com>
7500 * class.cs (Constructor.Define): Updated way of detecting the
7501 length of the parameters.
7503 (TypeContainer.DefineType): Use basename as the type name for
7506 (TypeContainer.Define): Do not recursively define types here, as
7507 definition is taken care in order by the RootContext.
7509 * tree.cs: Keep track of namespaces in a per-file basis.
7511 * parameter.cs (Parameter.ComputeSignature): Update to use
7514 (Parameters.GetSignature): ditto.
7516 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
7517 instead of a TypeContainer.
7519 (Interface.SemanticAnalysis): Use `this' instead of our parent to
7520 resolve names. Because we need to be resolve in our context, not
7523 * driver.cs: Implement response files.
7525 * class.cs (TypeContainer.DefineType): If we are defined, do not
7528 (Event.Emit): Emit the code for add/remove handlers.
7529 (Event.Define): Save the MethodBuilders for add/remove.
7531 * typemanager.cs: Use pair here too.
7533 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
7534 DictionaryEntry requires the first argument to be non-null.
7536 (enum_declaration): Compute full name for registering the
7539 (delegate_declaration): Instead of using
7540 formal_parameter_list, use opt_formal_parameter_list as the list
7543 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
7544 (EventParsing): New property that controls whether `add' and
7545 `remove' are returned as tokens or identifiers (for events);
7547 2001-12-19 Ravi Pratap <ravi@ximian.com>
7549 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
7550 use MyEventBuilder only and let it wrap the real builder for us.
7552 (MyEventBuilder): Revamp constructor etc.
7554 Implement all operations that we perform on EventBuilder in precisely the same
7557 (FindMembers): Update to use the EventBuilder member.
7559 (Event.Emit): Update accordingly.
7561 2001-12-18 Ravi Pratap <ravi@ximian.com>
7563 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
7564 by calling the appropriate methods.
7566 (GetCustomAttributes): Make stubs as they cannot possibly do anything
7569 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
7571 2001-12-17 Ravi Pratap <ravi@ximian.com>
7573 * delegate.cs (Delegate.Populate): Check that the return type
7574 and various parameters types are indeed accessible.
7576 * class.cs (Constructor.Define): Same here.
7578 (Field.Define): Ditto.
7580 (Event.Define): Ditto.
7582 (Operator.Define): Check that the underlying Method defined itself
7583 correctly - so it's MethodBuilder should not be null.
7585 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
7586 expression happens to be null.
7588 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
7589 members but as of now we don't seem to be able to do anything really useful with it.
7591 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
7592 not the EventBuilder.
7594 2001-12-18 Miguel de Icaza <miguel@ximian.com>
7596 * cs-tokenizer.cs: Add support for defines.
7597 Add support for #if, #elif, #else, #endif
7599 (eval_var): evaluates a variable.
7600 (eval): stubbed for evaluating functions.
7602 * cs-parser.jay: Pass the defines information
7604 * driver.cs: Add --define command line option.
7606 * decl.cs: Move MemberCore here.
7608 Make it the base class for DeclSpace. This allows us to catch and
7609 report 108 and 109 for everything now.
7611 * class.cs (TypeContainer.Define): Extract all the members
7612 before populating and emit the warning 108 (new keyword required
7613 to override) instead of having each member implement this.
7615 (MemberCore.Define): New abstract method, we will be using this in
7616 the warning reporting engine in Populate.
7618 (Operator.Define): Adjust to new MemberCore protocol.
7620 * const.cs (Const): This does not derive from Expression, it is a
7621 temporary object we use to create fields, it is a MemberCore.
7623 * class.cs (Method.Define): Allow the entry point to be in a
7626 * driver.cs: Rewrite the argument handler to clean it up a bit.
7628 * rootcontext.cs: Made it just an auxiliary namespace feature by
7629 making everything static.
7631 * driver.cs: Adapt code to use RootContext type name instead of
7634 * delegate.cs: Remove RootContext argument.
7636 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
7639 * class.cs (Event.Define): The lookup can fail.
7641 * cs-tokenizer.cs: Begin implementation of pre-procesor.
7643 * expression.cs: Resolve the this instance before invoking the code.
7645 2001-12-17 Miguel de Icaza <miguel@ximian.com>
7647 * cs-parser.jay: Add a production in element_access that allows
7648 the thing to become a "type" reference. This way we can parse
7649 things like "(string [])" as a type.
7651 Note that this still does not handle the more complex rules of
7655 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
7657 * ecore.cs: (CopyNewMethods): new utility function used to
7658 assemble the list of methods from running FindMembers.
7660 (MemberLookup): Rework FindMembers so that
7662 2001-12-16 Miguel de Icaza <miguel@ximian.com>
7664 * class.cs (TypeContainer): Remove Delegates who fail to be
7667 * delegate.cs (Populate): Verify that we dont get null return
7668 values. TODO: Check for AsAccessible.
7670 * cs-parser.jay: Use basename to emit error 574 (destructor should
7671 have the same name as container class), not the full name.
7673 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
7674 possible representation.
7676 Also implements integer type suffixes U and L.
7678 2001-12-15 Miguel de Icaza <miguel@ximian.com>
7680 * expression.cs (ArrayCreation.DoResolve): We need to do the
7681 argument resolution *always*.
7683 * decl.cs: Make this hold the namespace. Hold the root context as
7685 (LookupType): Move here.
7687 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
7689 * location.cs (Row, Name): Fixed the code, it was always returning
7690 references to the first file.
7692 * interface.cs: Register properties defined through interfaces.
7694 * driver.cs: Add support for globbing on the command line
7696 * class.cs (Field): Make it derive from MemberCore as well.
7699 2001-12-15 Ravi Pratap <ravi@ximian.com>
7701 * class.cs (Event::Define): Check that the type of the event is a delegate
7702 type else flag error #66.
7704 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
7707 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
7708 values of EntryPoint, CharSet etc etc.
7710 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
7712 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
7713 be null and we should ignore this. I am not sure if this is really clean. Apparently,
7714 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
7715 which needs this to do its work.
7717 * ../errors/cs0066.cs : Add.
7719 2001-12-14 Miguel de Icaza <miguel@ximian.com>
7721 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
7724 * class.cs: (MethodSignature.MethodSignature): Removed hack that
7725 clears out the parameters field.
7726 (MemberSignatureCompare): Cleanup
7728 (MemberCore): New base class used to share code between MethodCore
7731 (RegisterRequiredImplementations) BindingFlags.Public requires
7732 either BindingFlags.Instace or Static. Use instance here.
7734 (Property): Refactored code to cope better with the full spec.
7736 * parameter.cs (GetParameterInfo): Return an empty array instead
7739 * class.cs (Property): Abstract or extern properties have no bodies.
7741 * parameter.cs (GetParameterInfo): return a zero-sized array.
7743 * class.cs (TypeContainer.MethodModifiersValid): Move all the
7744 method modifier validation to the typecontainer so we can reuse
7747 (MethodCore.ParameterTypes): return an empty sized array of types.
7749 (Property.Define): Test property modifier validity.
7751 Add tests for sealed/override too.
7753 (Method.Emit): abstract or extern methods have no bodies.
7755 2001-12-14 Ravi Pratap <ravi@ximian.com>
7757 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
7760 (Method::Define, ::Emit): Modify accordingly.
7762 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
7764 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
7766 * makefile: Pass in /unsafe.
7768 2001-12-13 Miguel de Icaza <miguel@ximian.com>
7770 * class.cs (MakeKey): Kill routine.
7772 * class.cs (TypeContainer.Define): Correctly define explicit
7773 method implementations (they require the full interface name plus
7776 * typemanager.cs: Deply the PtrHashtable here and stop using the
7777 lame keys. Things work so much better.
7779 This of course broke everyone who depended on `RegisterMethod' to
7780 do the `test for existance' test. This has to be done elsewhere.
7782 * support.cs (PtrHashtable): A hashtable that avoid comparing with
7783 the object stupid Equals method (because, that like fails all over
7784 the place). We still do not use it.
7786 * class.cs (TypeContainer.SetRequiredInterface,
7787 TypeContainer.RequireMethods): Killed these two routines and moved
7788 all the functionality to RegisterRequiredImplementations.
7790 (TypeContainer.RegisterRequiredImplementations): This routine now
7791 registers all the implementations required in an array for the
7792 interfaces and abstract methods. We use an array of structures
7793 which can be computed ahead of time to reduce memory usage and we
7794 also assume that lookups are cheap as most classes will not
7795 implement too many interfaces.
7797 We also avoid creating too many MethodSignatures.
7799 (TypeContainer.IsInterfaceMethod): Update and optionally does not
7800 clear the "pending" bit if we find that there are problems with
7803 (TypeContainer.VerifyPendingMethods): Update to report errors of
7804 methods that look like implementations but are not.
7806 (TypeContainer.Define): Add support for explicit interface method
7809 2001-12-12 Miguel de Icaza <miguel@ximian.com>
7811 * typemanager.cs: Keep track of the parameters here instead of
7812 being a feature of the TypeContainer.
7814 * class.cs: Drop the registration of parameters here, as
7815 InterfaceMethods are also interface declarations.
7817 * delegate.cs: Register methods with the TypeManager not only with
7818 the TypeContainer. This code was buggy.
7820 * interface.cs: Full registation here.
7822 2001-12-11 Miguel de Icaza <miguel@ximian.com>
7824 * expression.cs: Remove reducer for binary expressions, it can not
7827 * const.cs: Put here the code that used to go into constant.cs
7829 * constant.cs: Put here the code for constants, this is a new base
7832 * literal.cs: Make Literal derive from Constant.
7834 2001-12-09 Miguel de Icaza <miguel@ximian.com>
7836 * statement.cs (Return.Emit): Report error 157 if the user
7837 attempts to return from a finally block.
7839 (Return.Emit): Instead of emitting a return, jump to the end of
7842 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
7843 LocalBuilder to store the result of the function. ReturnLabel is
7844 the target where we jump.
7847 2001-12-09 Radek Doulik <rodo@ximian.com>
7849 * cs-parser.jay: remember alias in current namespace
7851 * ecore.cs (SimpleName::DoResolve): use aliases for types or
7854 * class.cs (LookupAlias): lookup alias in my_namespace
7856 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
7858 (LookupAlias): lookup alias in this and if needed in parent
7861 2001-12-08 Miguel de Icaza <miguel@ximian.com>
7865 * rootcontext.cs: (ModuleBuilder) Made static, first step into
7866 making things static. I need this to avoid passing the
7867 TypeContainer when calling ParameterType.
7869 * support.cs (InternalParameters.ParameterType): Remove ugly hack
7870 that did string manipulation to compute the type and then call
7871 GetType. Use Parameter.ParameterType instead.
7873 * cs-tokenizer.cs: Consume the suffix for floating values.
7875 * expression.cs (ParameterReference): figure out whether this is a
7876 reference parameter or not. Kill an extra variable by computing
7877 the arg_idx during emission.
7879 * parameter.cs (Parameters.GetParameterInfo): New overloaded
7880 function that returns whether a parameter is an out/ref value or not.
7882 (Parameter.ParameterType): The type of the parameter (base,
7883 without ref/out applied).
7885 (Parameter.Resolve): Perform resolution here.
7886 (Parameter.ExternalType): The full type (with ref/out applied).
7888 * statement.cs (Using.Emit, Using.EmitExpression): Implement
7889 support for expressions on the using statement.
7891 2001-12-07 Miguel de Icaza <miguel@ximian.com>
7893 * statement.cs (Using.EmitLocalVariableDecls): Split the
7894 localvariable handling of the using statement.
7896 (Block.EmitMeta): Keep track of variable count across blocks. We
7897 were reusing slots on separate branches of blocks.
7899 (Try.Emit): Emit the general code block, we were not emitting it.
7901 Check the type of the declaration to be an IDisposable or
7902 something that can be implicity converted to it.
7904 Emit conversions if required.
7906 * ecore.cs (EmptyExpression): New utility class.
7907 (Expression.ImplicitConversionExists): New utility function.
7909 2001-12-06 Miguel de Icaza <miguel@ximian.com>
7911 * statement.cs (Using): Implement.
7913 * expression.cs (LocalVariableReference): Support read only variables.
7915 * statement.cs: Remove the explicit emit for the Leave opcode.
7916 (VariableInfo): Add a readonly field.
7918 2001-12-05 Miguel de Icaza <miguel@ximian.com>
7920 * ecore.cs (ConvCast): new class used to encapsulate the various
7921 explicit integer conversions that works in both checked and
7924 (Expression.ConvertNumericExplicit): Use new ConvCast class to
7925 properly generate the overflow opcodes.
7927 2001-12-04 Miguel de Icaza <miguel@ximian.com>
7929 * statement.cs: The correct type for the EmptyExpression is the
7930 element_type, not the variable type. Ravi pointed this out.
7932 2001-12-04 Ravi Pratap <ravi@ximian.com>
7934 * class.cs (Method::Define): Handle PInvoke methods specially
7935 by using DefinePInvokeMethod instead of the usual one.
7937 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
7938 above to do the task of extracting information and defining the method.
7940 2001-12-04 Ravi Pratap <ravi@ximian.com>
7942 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
7943 of the condition for string type.
7945 (Emit): Move that here.
7947 (ArrayCreation::CheckIndices): Keep string literals in their expression
7950 (EmitDynamicInitializers): Handle strings appropriately.
7952 2001-12-04 Miguel de Icaza <miguel@ximian.com>
7954 * codegen.cs (EmitContext): Replace multiple variables with a
7955 single pointer to the current Switch statement.
7957 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
7960 2001-12-03 Miguel de Icaza <miguel@ximian.com>
7964 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
7967 (Foreach.Emit): Foreach on arrays was not setting
7968 up the loop variables (for break/continue).
7970 (GotoCase): Semi-implented.
7972 2001-12-03 Ravi Pratap <ravi@ximian.com>
7974 * attribute.cs (CheckAttribute): Handle system attributes by using
7975 Attribute.GetAttributes to examine information we need.
7977 (GetValidPlaces): Same here.
7979 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
7981 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
7983 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
7985 (Method::Define): Set appropriate flags if we have a DllImport attribute.
7987 (Method::Emit): Handle the case when we are a PInvoke method.
7989 2001-12-03 Miguel de Icaza <miguel@ximian.com>
7991 * expression.cs: Use ResolveWithSimpleName on compound names.
7993 2001-12-02 Ravi Pratap <ravi@ximian.com>
7995 * constant.cs (EmitConstant): Make sure we resolve the associated expression
7996 before trying to reduce it.
7998 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
8000 * constant.cs (LookupConstantValue): Implement.
8002 (EmitConstant): Use the above in emitting the constant.
8004 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
8005 that are user-defined by doing a LookupConstantValue on them.
8007 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
8010 2001-11-29 Miguel de Icaza <miguel@ximian.com>
8012 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
8014 (BaseAccess.DoResolve): Implement.
8016 (MemberAccess.DoResolve): Split this routine into a
8017 ResolveMemberAccess routine that can be used independently
8019 2001-11-28 Miguel de Icaza <miguel@ximian.com>
8021 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
8022 As that share bits of the implementation. Is returns a boolean,
8023 while As returns the Type that is being probed.
8025 2001-12-01 Ravi Pratap <ravi@ximian.com>
8027 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
8028 instead of a Literal - much easier.
8030 (EnumInTransit): Remove - utterly useless :-)
8032 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
8034 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
8036 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
8037 chain when we have no associated expression.
8039 2001-11-30 Ravi Pratap <ravi@ximian.com>
8041 * constant.cs (Define): Use Location while reporting the errror.
8043 Also emit a warning when 'new' is used and there is no inherited
8046 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
8049 (LookupEnumValue): Implement to lookup an enum member's value and define it
8052 (Populate): Re-write accordingly to use the above routine.
8054 2001-11-27 Miguel de Icaza <miguel@ximian.com>
8056 * expression.cs (This): Fix prototype for DoResolveLValue to
8057 override the base class DoResolveLValue.
8059 * cs-parser.cs: Report errors cs574 and cs575 (destructor
8062 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
8063 (we need to load the address of the field here). This fixes
8066 (FieldExpr.DoResolveLValue): Call the DoResolve
8067 function to initialize the Instance expression.
8069 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
8070 correctly the GetEnumerator operation on a value type.
8072 * cs-parser.jay: Add more simple parsing error catches.
8074 * statement.cs (Switch): Add support for string switches.
8075 Handle null specially.
8077 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
8079 2001-11-28 Ravi Pratap <ravi@ximian.com>
8081 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
8083 (declare_local_constant): New helper function.
8085 * statement.cs (AddConstant): Keep a separate record of constants
8087 (IsConstant): Implement to determine if a variable is a constant.
8089 (GetConstantExpression): Implement.
8091 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
8093 * statement.cs (IsVariableDefined): Re-write.
8095 2001-11-27 Ravi Pratap <ravi@ximian.com>
8097 * class.cs (TypeContainer::FindMembers): Look for constants
8098 in the case when we are looking for MemberTypes.Field
8100 * expression.cs (MemberAccess::DoResolve): Check that in the
8101 case we are a FieldExpr and a Literal, we are not being accessed
8102 by an instance reference.
8104 * cs-parser.jay (local_constant_declaration): Implement.
8106 (declaration_statement): Implement for constant declarations.
8108 2001-11-26 Miguel de Icaza <miguel@ximian.com>
8110 * statement.cs (Switch): Catch double defaults.
8112 (Switch): More work on the switch() statement
8113 implementation. It works for integral values now, need to finish
8117 2001-11-24 Miguel de Icaza <miguel@ximian.com>
8119 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
8120 integer literals into other integer literals. To be used by
8123 2001-11-24 Ravi Pratap <ravi@ximian.com>
8125 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
8128 (EmitDynamicInitializers): Cope with the above since we extract data
8129 directly from ArrayData now.
8131 (ExpectInitializers): Keep track of whether initializers are mandatory
8134 (Bounds): Make it a hashtable to prevent the same dimension being
8135 recorded for every element in that dimension.
8137 (EmitDynamicInitializers): Fix bug which prevented the Set array method
8140 Also fix bug which was causing the indices to be emitted in the reverse
8143 2001-11-24 Miguel de Icaza <miguel@ximian.com>
8145 * expression.cs (ArrayCreation): Implement the bits that Ravi left
8146 unfinished. They do not work, because the underlying code is
8149 2001-11-22 Miguel de Icaza <miguel@ximian.com>
8151 * cs-parser.jay: Remove bogus fixme.
8153 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
8154 on Switch statement.
8156 2001-11-23 Ravi Pratap <ravi@ximian.com>
8158 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
8161 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
8162 parameter. Apparently, any expression is allowed.
8164 (ValidateInitializers): Update accordingly.
8166 (CheckIndices): Fix some tricky bugs thanks to recursion.
8168 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
8169 I was being completely brain-dead.
8171 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
8172 and re-write acordingly.
8174 (DelegateInvocation): Re-write accordingly.
8176 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
8178 (MakeByteBlob): Handle types more correctly.
8180 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
8181 initialization from expressions but it is incomplete because I am a complete
8184 2001-11-22 Miguel de Icaza <miguel@ximian.com>
8186 * statement.cs (If.Emit): Fix a bug that generated incorrect code
8187 on If. Basically, we have to return `true' (ie, we do return to
8188 our caller) only if both branches of the if return.
8190 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
8191 short-circuit operators, handle them as short circuit operators.
8193 (Cast.DoResolve): Resolve type.
8194 (Cast.Cast): Take an expression as the target type.
8196 * cs-parser.jay (cast_expression): Remove old hack that only
8197 allowed a limited set of types to be handled. Now we take a
8198 unary_expression and we resolve to a type during semantic
8201 Use the grammar productions from Rhys to handle casts (this is
8202 not complete like Rhys syntax yet, we fail to handle that corner
8203 case that C# has regarding (-x), but we will get there.
8205 2001-11-22 Ravi Pratap <ravi@ximian.com>
8207 * class.cs (EmitFieldInitializer): Take care of the case when we have a
8208 field which is an array type.
8210 * cs-parser.jay (declare_local_variables): Support array initialization too.
8212 * typemanager.cs (MakeKey): Implement.
8214 (everywhere): Use the above appropriately.
8216 * cs-parser.jay (for_statement): Update for array initialization while
8217 declaring variables.
8219 * ecore.cs : The error message was correct, it's the variable's names that
8220 were misleading ;-) Make the code more readable.
8222 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
8223 the correct type etc.
8225 (ConvertExplicit): Handle Enum types by examining the underlying type.
8227 2001-11-21 Ravi Pratap <ravi@ximian.com>
8229 * parameter.cs (GetCallingConvention): Always return
8230 CallingConventions.Standard for now.
8232 2001-11-22 Miguel de Icaza <miguel@ximian.com>
8234 * expression.cs (Binary.ResolveOperator): Update the values of `l'
8235 and `r' after calling DoNumericPromotions.
8237 * ecore.cs: Fix error message (the types were in the wrong order).
8239 * statement.cs (Foreach.ProbeCollectionType): Need to pass
8240 BindingFlags.Instance as well
8242 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
8243 implicit int literal conversion in an empty cast so that we
8244 propagate the right type upstream.
8246 (UnboxCast): new class used to unbox value types.
8247 (Expression.ConvertExplicit): Add explicit type conversions done
8250 (Expression.ImplicitNumericConversion): Oops, forgot to test for
8251 the target type before applying the implicit LongLiterals to ULong
8254 2001-11-21 Miguel de Icaza <miguel@ximian.com>
8256 * cs-parser.jay (for_statement): Reworked the way For works: now
8257 we declare manually any variables that are introduced in
8258 for_initializer to solve the problem of having out-of-band code
8259 emition (that is what got for broken).
8261 (declaration_statement): Perform the actual variable declaration
8262 that used to be done in local_variable_declaration here.
8264 (local_variable_declaration): Do not declare anything, just pass
8265 the information on a DictionaryEntry
8267 2001-11-20 Ravi Pratap <ravi@ximian.com>
8269 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
8270 re-write of the logic to now make it recursive.
8272 (UpdateIndices): Re-write accordingly.
8274 Store element data in a separate ArrayData list in the above methods.
8276 (MakeByteBlob): Implement to dump the array data into a byte array.
8278 2001-11-19 Ravi Pratap <ravi@ximian.com>
8280 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
8283 * constant.cs (Define): Implement.
8285 (EmitConstant): Re-write fully.
8287 Pass in location info.
8289 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
8292 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
8293 DictionaryEntry since we need location info too.
8295 (constant_declaration): Update accordingly.
8297 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
8298 code into another method : UpdateIndices.
8300 2001-11-18 Ravi Pratap <ravi@ximian.com>
8302 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
8303 some type checking etc.
8305 2001-11-17 Ravi Pratap <ravi@ximian.com>
8307 * expression.cs (ArrayCreation::ValidateInitializers): Implement
8308 bits to provide dimension info if the user skips doing that.
8310 Update second constructor to store the rank correctly.
8312 2001-11-16 Ravi Pratap <ravi@ximian.com>
8314 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
8315 and try to implement.
8317 * ../errors/cs0150.cs : Add.
8319 * ../errors/cs0178.cs : Add.
8321 2001-11-16 Miguel de Icaza <miguel@ximian.com>
8323 * statement.cs: Implement foreach on multi-dimensional arrays.
8325 * parameter.cs (Parameters.GetParameterByName): Also lookup the
8326 name of the params argument.
8328 * expression.cs: Use EmitStoreOpcode to get the right opcode while
8329 initializing the array.
8331 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
8332 we can use this elsewhere.
8334 * statement.cs: Finish implementation of foreach for single
8337 * cs-parser.jay: Use an out-of-band stack to pass information
8338 around, I wonder why I need this.
8340 foreach_block: Make the new foreach_block the current_block.
8342 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
8343 function used to return a static Parameters structure. Used for
8344 empty parameters, as those are created very frequently.
8346 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
8348 2001-11-15 Ravi Pratap <ravi@ximian.com>
8350 * interface.cs : Default modifier is private, not public. The
8351 make verify test passes again.
8353 2001-11-15 Ravi Pratap <ravi@ximian.com>
8355 * support.cs (ReflectionParameters): Fix logic to determine
8356 whether the last parameter is a params one. Test 9 passes again.
8358 * delegate.cs (Populate): Register the builders we define with
8359 RegisterParameterForBuilder. Test 19 passes again.
8361 * cs-parser.jay (property_declaration): Reference $6 instead
8362 of $$ to get at the location.
8364 (indexer_declaration): Similar stuff.
8368 * class.cs (Property): Register parameters for the Get and Set methods
8369 if they exist. Test 23 passes again.
8371 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
8372 call to EmitArguments as we are sure there aren't any params arguments.
8373 Test 32 passes again.
8375 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
8376 IndexOutOfRangeException.
8378 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
8379 Test 33 now passes again.
8381 2001-11-15 Miguel de Icaza <miguel@ximian.com>
8383 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
8384 broke a bunch of things. Will have to come up with a better way
8385 of tracking locations.
8387 * statement.cs: Implemented foreach for single dimension arrays.
8389 2001-11-09 Miguel de Icaza <miguel@ximian.com>
8391 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
8392 an error. This removes the lookup from the critical path.
8394 * cs-parser.jay: Removed use of temporary_loc, which is completely
8397 2001-11-14 Miguel de Icaza <miguel@ximian.com>
8399 * support.cs (ReflectionParameters.ParameterModifier): Report
8400 whether the argument is a PARAMS argument or not.
8402 * class.cs: Set the attribute `ParamArrayAttribute' on the
8405 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
8406 and cons_param_array_attribute (ConstructorInfo for
8407 ParamArrayAttribute).,
8409 * codegen.cs: Emit the return using the `Return' statement, that
8410 way we can report the error correctly for missing return values.
8412 * class.cs (Method.Emit): Clean up.
8414 * expression.cs (Argument.Resolve): Take another argument: the
8415 location where this argument is used. Notice that this is not
8416 part of the "Argument" class as to reduce the size of the
8417 structure (we know the approximate location anyways).
8419 Test if the argument is a variable-reference, if not, then
8420 complain with a 206.
8422 (Argument.Emit): Emit addresses of variables.
8424 (Argument.FullDesc): Simplify.
8426 (Invocation.DoResolve): Update for Argument.Resolve.
8428 (ElementAccess.DoResolve): ditto.
8430 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
8431 method should be virtual, as this method is always virtual.
8433 (NewDelegate.DoResolve): Update for Argument.Resolve.
8435 * class.cs (ConstructorInitializer.DoResolve): ditto.
8437 * attribute.cs (Attribute.Resolve): ditto.
8439 2001-11-13 Miguel de Icaza <miguel@ximian.com>
8441 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
8443 * expression.cs (ParameterReference): Drop IStackStorage and implement
8444 IAssignMethod instead.
8446 (LocalVariableReference): ditto.
8448 * ecore.cs (FieldExpr): Drop IStackStorage and implement
8449 IAssignMethod instead.
8451 2001-11-13 Miguel de Icaza <miguel@ximian.com>
8453 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
8454 enumerations that are used in heavily used structures derive from
8455 byte in a laughable and pathetic attempt to reduce memory usage.
8456 This is the kind of pre-optimzations that you should not do at
8457 home without adult supervision.
8459 * expression.cs (UnaryMutator): New class, used to handle ++ and
8460 -- separatedly from the other unary operators. Cleans up the
8461 code, and kills the ExpressionStatement dependency in Unary.
8463 (Unary): Removed `method' and `Arguments' from this class, making
8464 it smaller, and moving it all to SimpleCall, so I can reuse this
8465 code in other locations and avoid creating a lot of transient data
8466 strucutres when not required.
8468 * cs-parser.jay: Adjust for new changes.
8470 2001-11-11 Miguel de Icaza <miguel@ximian.com>
8472 * enum.cs (Enum.Populate): If there is a failure during
8475 * cs-parser.jay (opt_enum_base): we used to catch type errors
8476 here, but this is really incorrect. The type error should be
8477 catched during semantic analysis.
8479 2001-12-11 Ravi Pratap <ravi@ximian.com>
8481 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
8482 current_local_parameters as expected since I, in my stupidity, had forgotten
8485 * attribute.cs (GetValidPlaces): Fix stupid bug.
8487 * class.cs (Method::Emit): Perform check on applicability of attributes.
8489 (Constructor::Emit): Ditto.
8491 (Field::Emit): Ditto.
8493 (Field.Location): Store location information.
8495 (Property, Event, Indexer, Operator): Ditto.
8497 * cs-parser.jay (field_declaration): Pass in location for each field.
8499 * ../errors/cs0592.cs : Add.
8501 2001-11-12 Ravi Pratap <ravi@ximian.com>
8503 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
8505 (InitCoreTypes): Update accordingly.
8507 (RegisterAttrType, LookupAttr): Implement.
8509 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
8510 info about the same.
8512 (Resolve): Update to populate the above as necessary.
8516 (GetValidPlaces): Helper to the above.
8518 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
8520 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
8522 2001-11-12 Ravi Pratap <ravi@ximian.com>
8524 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
8526 * ../errors/cs0617.cs : Add.
8528 2001-11-11 Ravi Pratap <ravi@ximian.com>
8530 * enum.cs (Emit): Rename to Populate to be more consistent with what
8531 we expect it to do and when exactly it is called.
8533 * class.cs, rootcontext.cs : Update accordingly.
8535 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
8536 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
8538 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
8540 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
8541 of a fieldinfo using the above, when dealing with a FieldBuilder.
8543 2001-11-10 Ravi Pratap <ravi@ximian.com>
8545 * ../errors/cs0031.cs : Add.
8547 * ../errors/cs1008.cs : Add.
8549 * ../errrors/cs0543.cs : Add.
8551 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
8554 (FindMembers): Implement.
8556 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
8557 enums and delegates too.
8559 (enum_types): Rename to builder_to_enum.
8561 (delegate_types): Rename to builder_to_delegate.
8563 * delegate.cs (FindMembers): Implement.
8565 2001-11-09 Ravi Pratap <ravi@ximian.com>
8567 * typemanager.cs (IsEnumType): Implement.
8569 * enum.cs (Emit): Re-write parts to account for the underlying type
8570 better and perform checking etc.
8572 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
8573 of the underlying type.
8575 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
8578 * enum.cs (error31): Helper to report error #31.
8580 * cs-parser.jay (enum_declaration): Store location of each member too.
8582 * enum.cs (member_to_location): New hashtable.
8584 (AddEnumMember): Update location hashtable.
8586 (Emit): Use the location of each member while reporting errors.
8588 2001-11-09 Miguel de Icaza <miguel@ximian.com>
8590 * cs-parser.jay: A for_initializer if is a
8591 local_variable_declaration really ammount to have an implicit
8592 block with the variable declaration and no initializer for for.
8594 * statement.cs (For.Emit): Cope with null initializers.
8596 This fixes the infinite loop on for initializers.
8598 2001-11-08 Miguel de Icaza <miguel@ximian.com>
8600 * enum.cs: More cleanup.
8602 * ecore.cs: Remove dead code.
8604 * class.cs (Property.Emit): More simplification.
8605 (Event.Emit): ditto.
8607 Reworked to have less levels of indentation.
8609 2001-11-08 Ravi Pratap <ravi@ximian.com>
8611 * class.cs (Property): Emit attributes.
8621 * enum.cs (Emit): Ditto.
8623 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
8626 * class.cs (Field, Event, etc.): Move attribute generation into the
8627 Emit method everywhere.
8629 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
8630 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
8631 as we had no way of defining nested enums !
8633 * rootcontext.cs : Adjust code accordingly.
8635 * typemanager.cs (AddEnumType): To keep track of enum types separately.
8637 2001-11-07 Ravi Pratap <ravi@ximian.com>
8639 * expression.cs (EvalConstantExpression): Move into ecore.cs
8641 * enum.cs (Enum): Rename some members and make them public and readonly
8642 according to our convention.
8644 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
8647 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
8649 (Enum::Emit): Write a simple version for now which doesn't try to compute
8650 expressions. I shall modify this to be more robust in just a while.
8652 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
8654 (TypeContainer::CloseType): Create the Enum types too.
8656 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
8658 * expression.cs (EvalConstantExpression): Get rid of completely.
8660 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
8661 user-defined values and other cases.
8663 (IsValidEnumLiteral): Helper function.
8665 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
8666 out there in the case we had a literal FieldExpr.
8668 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
8670 (Literalize): Revamp a bit to take two arguments.
8672 (EnumLiteral): New class which derives from Literal to wrap enum literals.
8674 2001-11-06 Ravi Pratap <ravi@ximian.com>
8676 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
8678 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
8680 (Resolve): Use the above to ensure we have proper initializers.
8682 2001-11-05 Ravi Pratap <ravi@ximian.com>
8684 * expression.cs (Expression::EvalConstantExpression): New method to
8685 evaluate constant expressions.
8687 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
8689 2001-11-07 Miguel de Icaza <miguel@ximian.com>
8691 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
8694 (Binary.ResolveOperator): Handle operator != (object a, object b)
8695 and operator == (object a, object b);
8697 (Binary.DoNumericPromotions): Indicate whether the numeric
8698 promotion was possible.
8700 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
8703 Made the ArrayAccess implement interface IAssignMethod instead of
8704 IStackStore as the order in which arguments are passed reflects
8707 * assign.cs: Instead of using expr.ExprClass to select the way of
8708 assinging, probe for the IStackStore/IAssignMethod interfaces.
8710 * typemanager.cs: Load InitializeArray definition.
8712 * rootcontext.cs (RootContext.MakeStaticData): Used to define
8713 static data that can be used to initialize arrays.
8715 2001-11-05 Miguel de Icaza <miguel@ximian.com>
8717 * expression.cs: Handle operator== and operator!= for booleans.
8719 (Conditioal.Reduce): Implement reducer for the ?: operator.
8721 (Conditional.Resolve): Implement dead code elimination.
8723 (Binary.Resolve): Catch string literals and return a new
8724 concatenated string.
8726 (Unary.Reduce): Implement reduction of unary expressions.
8728 * ecore.cs: Split out the expression core handling here.
8730 (Expression.Reduce): New method used to perform constant folding
8731 and CSE. This is needed to support constant-expressions.
8733 * statement.cs (Statement.EmitBoolExpression): Pass true and false
8734 targets, and optimize for !x.
8736 2001-11-04 Ravi Pratap <ravi@ximian.com>
8738 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
8739 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
8740 set custom atttributes.
8742 * literal.cs (Literal::GetValue): New abstract method to return the actual
8743 value of the literal, cast as an object.
8745 (*Literal): Implement GetValue method.
8747 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
8748 expressions to the arraylist but objects of type Argument.
8750 * class.cs (TypeContainer::Emit): Emit our attributes too.
8752 (Method::Emit, Constructor::Emit): Ditto.
8754 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
8755 to be ignoring earlier.
8757 2001-11-03 Ravi Pratap <ravi@ximian.com>
8759 * attribute.cs (AttributeSection::Define): Implement to do the business
8760 of constructing a CustomAttributeBuilder.
8762 (Attribute): New trivial class. Increases readability of code.
8764 * cs-parser.jay : Update accordingly.
8766 (positional_argument_list, named_argument_list, named_argument): New rules
8768 (attribute_arguments): Use the above so that we are more correct.
8770 2001-11-02 Ravi Pratap <ravi@ximian.com>
8772 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
8773 to perform all checks for a method with a params parameter.
8775 (Invocation::OverloadResolve): Update to use the above method and therefore
8776 cope correctly with params method invocations.
8778 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
8781 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
8782 constructors in our parent too because we can't afford to miss out on
8785 * attribute.cs (AttributeSection): New name for the class Attribute
8787 Other trivial changes to improve readability.
8789 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
8790 use the new class names.
8792 2001-11-01 Ravi Pratap <ravi@ximian.com>
8794 * class.cs (Method::Define): Complete definition for params types too
8796 (Indexer::Define): Ditto.
8798 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
8799 Cope everywhere with a request for info about the array parameter.
8801 2001-11-01 Ravi Pratap <ravi@ximian.com>
8803 * tree.cs (RecordNamespace): Fix up to check for the correct key.
8805 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
8806 local_variable_type to extract the string corresponding to the type.
8808 (local_variable_type): Fixup the action to use the new helper method.
8810 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
8813 * expression.cs : Clean out code which uses the above.
8815 2001-10-31 Ravi Pratap <ravi@ximian.com>
8817 * typemanager.cs (RegisterMethod): Check if we already have an existing key
8818 and bale out if necessary by returning a false.
8820 (RegisterProperty): Ditto.
8822 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
8823 and print out appropriate error messages.
8825 * interface.cs (everywhere): Ditto.
8827 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
8828 location to constructor.
8830 * class.cs (Property, Event, Indexer): Update accordingly.
8832 * ../errors/cs111.cs : Added.
8834 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
8835 of a method, as laid down by the spec.
8837 (Invocation::OverloadResolve): Use the above method.
8839 2001-10-31 Ravi Pratap <ravi@ximian.com>
8841 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
8842 now take a TypeContainer and a Parameters object.
8844 (ParameterData): Modify return type of ParameterModifier method to be
8845 Parameter.Modifier and not a string.
8847 (ReflectionParameters, InternalParameters): Update accordingly.
8849 * expression.cs (Argument::GetParameterModifier): Same here.
8851 * support.cs (InternalParameters::ParameterType): Find a better way of determining
8852 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
8853 symbol in it at all so maybe this is only for now.
8855 2001-10-30 Ravi Pratap <ravi@ximian.com>
8857 * support.cs (InternalParameters): Constructor now takes an extra argument
8858 which is the actual Parameters class.
8860 (ParameterDesc): Update to provide info on ref/out modifiers.
8862 * class.cs (everywhere): Update call to InternalParameters to pass in
8863 the second argument too.
8865 * support.cs (ParameterData): Add ParameterModifier, which is a method
8866 to return the modifier info [ref/out etc]
8868 (InternalParameters, ReflectionParameters): Implement the above.
8870 * expression.cs (Argument::ParameterModifier): Similar function to return
8871 info about the argument's modifiers.
8873 (Invocation::OverloadResolve): Update to take into account matching modifiers
8876 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
8877 a new SetFormalParameters object which we pass to InternalParameters.
8879 2001-10-30 Ravi Pratap <ravi@ximian.com>
8881 * expression.cs (NewArray): Merge into the ArrayCreation class.
8883 2001-10-29 Ravi Pratap <ravi@ximian.com>
8885 * expression.cs (NewArray): Merge classes NewBuiltinArray and
8886 NewUserdefinedArray into one as there wasn't much of a use in having
8889 * expression.cs (Argument): Change field's name to ArgType from Type.
8891 (Type): New readonly property which returns the proper type, taking into
8892 account ref/out modifiers.
8894 (everywhere): Adjust code accordingly for the above.
8896 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
8897 whether we are emitting for a ref or out parameter.
8899 * expression.cs (Argument::Emit): Use the above field to set the state.
8901 (LocalVariableReference::Emit): Update to honour the flag and emit the
8904 * parameter.cs (Attributes): Set the correct flags for ref parameters.
8906 * expression.cs (Argument::FullDesc): New function to provide a full desc.
8908 * support.cs (ParameterData): Add method ParameterDesc to the interface.
8910 (ReflectionParameters, InternalParameters): Implement the above method.
8912 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
8915 (Invocation::FullMethodDesc): Ditto.
8917 2001-10-29 Miguel de Icaza <miguel@ximian.com>
8919 * cs-parser.jay: Add extra production for the second form of array
8922 * expression.cs (ArrayCreation): Update to reflect the above
8925 * Small changes to prepare for Array initialization.
8927 2001-10-28 Miguel de Icaza <miguel@ximian.com>
8929 * typemanager.cs (ImplementsInterface): interface might be null;
8930 Deal with this problem;
8932 Also, we do store negative hits on the cache (null values), so use
8933 this instead of calling t.GetInterfaces on the type everytime.
8935 2001-10-28 Ravi Pratap <ravi@ximian.com>
8937 * typemanager.cs (IsBuiltinType): New method to help determine the same.
8939 * expression.cs (New::DoResolve): Get rid of array creation code and instead
8940 split functionality out into different classes.
8942 (New::FormArrayType): Move into NewBuiltinArray.
8944 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
8947 (NewBuiltinArray): New class to handle creation of built-in arrays.
8949 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
8950 account creation of one-dimensional arrays.
8952 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
8954 (NewUserdefinedArray::DoResolve): Implement.
8956 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
8958 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
8959 we maintain inside the TypeManager. This is necessary to perform lookups on the
8962 (LookupType): Update to perform GetType on the module builders too.
8964 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
8966 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
8968 2001-10-23 Ravi Pratap <ravi@ximian.com>
8970 * expression.cs (New::DoResolve): Implement guts of array creation.
8972 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
8974 2001-10-27 Miguel de Icaza <miguel@ximian.com>
8976 * expression.cs: Fix bug I introduced lsat night that broke
8979 (Expression.Resolve): Report a 246 error (can not resolve name)
8980 if we find a SimpleName in the stream.
8982 (Expression.ResolveLValue): Ditto.
8984 (Expression.ResolveWithSimpleName): This function is a variant of
8985 ResolveName, this one allows SimpleNames to be returned without a
8986 warning. The only consumer of SimpleNames is MemberAccess
8988 2001-10-26 Miguel de Icaza <miguel@ximian.com>
8990 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
8991 might arrive here. I have my doubts that this is correct.
8993 * statement.cs (Lock): Implement lock statement.
8995 * cs-parser.jay: Small fixes to support `lock' and `using'
8997 * cs-tokenizer.cs: Remove extra space
8999 * driver.cs: New flag --checked, allows to turn on integer math
9002 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
9003 Threading.Monitor.Exit
9005 2001-10-23 Miguel de Icaza <miguel@ximian.com>
9007 * expression.cs (IndexerAccess::DoResolveLValue): Set the
9008 Expression Class to be IndexerAccess.
9010 Notice that Indexer::DoResolve sets the eclass to Value.
9012 2001-10-22 Miguel de Icaza <miguel@ximian.com>
9014 * class.cs (TypeContainer::Emit): Emit code for indexers.
9016 * assign.cs (IAssignMethod): New interface implemented by Indexers
9017 and Properties for handling assignment.
9019 (Assign::Emit): Simplify and reuse code.
9021 * expression.cs (IndexerAccess, PropertyExpr): Implement
9022 IAssignMethod, clean up old code.
9024 2001-10-22 Ravi Pratap <ravi@ximian.com>
9026 * typemanager.cs (ImplementsInterface): New method to determine if a type
9027 implements a given interface. Provides a nice cache too.
9029 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
9032 (ConvertReferenceExplicit): Ditto.
9034 * delegate.cs (Delegate::Populate): Update to define the parameters on the
9035 various methods, with correct names etc.
9037 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
9038 Operator.UnaryNegation.
9040 * cs-parser.jay (operator_declarator): Be a little clever in the case where
9041 we have a unary plus or minus operator.
9043 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
9046 * everywhere : update accordingly.
9048 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
9051 * class.cs (Method::Define): For the case where we are implementing a method
9052 inherited from an interface, we need to set the MethodAttributes.Final flag too.
9053 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
9055 2001-10-21 Ravi Pratap <ravi@ximian.com>
9057 * interface.cs (FindMembers): Implement to work around S.R.E
9060 * typemanager.cs (IsInterfaceType): Implement.
9062 (FindMembers): Update to handle interface types too.
9064 * expression.cs (ImplicitReferenceConversion): Re-write bits which
9065 use IsAssignableFrom as that is not correct - it doesn't work.
9067 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
9068 and accordingly override EmitStatement.
9070 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
9071 using the correct logic :-)
9073 2001-10-19 Ravi Pratap <ravi@ximian.com>
9075 * ../errors/cs-11.cs : Add to demonstrate error -11
9077 2001-10-17 Miguel de Icaza <miguel@ximian.com>
9079 * assign.cs (Assign::Resolve): Resolve right hand side first, and
9080 then pass this as a hint to ResolveLValue.
9082 * expression.cs (FieldExpr): Add Location information
9084 (FieldExpr::LValueResolve): Report assignment to readonly
9087 (Expression::ExprClassFromMemberInfo): Pass location information.
9089 (Expression::ResolveLValue): Add new method that resolves an
9092 (Expression::DoResolveLValue): Default invocation calls
9095 (Indexers): New class used to keep track of indexers in a given
9098 (IStackStore): Renamed from LValue, as it did not really describe
9099 what this did. Also ResolveLValue is gone from this interface and
9100 now is part of Expression.
9102 (ElementAccess): Depending on the element access type
9104 * typemanager.cs: Add `indexer_name_type' as a Core type
9105 (System.Runtime.CompilerServices.IndexerNameAttribute)
9107 * statement.cs (Goto): Take a location.
9109 2001-10-18 Ravi Pratap <ravi@ximian.com>
9111 * delegate.cs (Delegate::VerifyDelegate): New method to verify
9112 if two delegates are compatible.
9114 (NewDelegate::DoResolve): Update to take care of the case when
9115 we instantiate a delegate from another delegate.
9117 * typemanager.cs (FindMembers): Don't even try to look up members
9118 of Delegate types for now.
9120 2001-10-18 Ravi Pratap <ravi@ximian.com>
9122 * delegate.cs (NewDelegate): New class to take care of delegate
9125 * expression.cs (New): Split the delegate related code out into
9126 the NewDelegate class.
9128 * delegate.cs (DelegateInvocation): New class to handle delegate
9131 * expression.cs (Invocation): Split out delegate related code into
9132 the DelegateInvocation class.
9134 2001-10-17 Ravi Pratap <ravi@ximian.com>
9136 * expression.cs (New::DoResolve): Implement delegate creation fully
9137 and according to the spec.
9139 (New::DoEmit): Update to handle delegates differently.
9141 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
9142 because of which we were printing out arguments in reverse order !
9144 * delegate.cs (VerifyMethod): Implement to check if the given method
9145 matches the delegate.
9147 (FullDelegateDesc): Implement.
9149 (VerifyApplicability): Implement.
9151 * expression.cs (Invocation::DoResolve): Update to accordingly handle
9152 delegate invocations too.
9154 (Invocation::Emit): Ditto.
9156 * ../errors/cs1593.cs : Added.
9158 * ../errors/cs1594.cs : Added.
9160 * delegate.cs (InstanceExpression, TargetMethod): New properties.
9162 2001-10-16 Ravi Pratap <ravi@ximian.com>
9164 * typemanager.cs (intptr_type): Core type for System.IntPtr
9166 (InitCoreTypes): Update for the same.
9168 (iasyncresult_type, asynccallback_type): Ditto.
9170 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
9173 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
9176 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
9177 the builders for the 4 members of a delegate type :-)
9179 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
9182 * expression.cs (New::DoResolve): Implement guts for delegate creation.
9184 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
9186 2001-10-15 Miguel de Icaza <miguel@ximian.com>
9188 * statement.cs (Break::Emit): Implement.
9189 (Continue::Emit): Implement.
9191 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
9192 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
9193 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
9194 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
9197 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
9198 properties that track the label for the current loop (begin of the
9199 loop and end of the loop).
9201 2001-10-15 Ravi Pratap <ravi@ximian.com>
9203 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
9204 use of emitting anything at all.
9206 * class.cs, rootcontext.cs : Get rid of calls to the same.
9208 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
9210 (Populate): Define the constructor correctly and set the implementation
9213 * typemanager.cs (delegate_types): New hashtable to hold delegates that
9216 (AddDelegateType): Implement.
9218 (IsDelegateType): Implement helper method.
9220 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
9222 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
9223 and accordingly handle it.
9225 * delegate.cs (Populate): Take TypeContainer argument.
9226 Implement bits to define the Invoke method. However, I still haven't figured out
9227 how to take care of the native int bit :-(
9229 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
9230 Qualify the name of the delegate, not its return type !
9232 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
9235 (StandardConversionExists): Checking for array types turns out to be recursive.
9237 (ConvertReferenceExplicit): Implement array conversion.
9239 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
9241 2001-10-12 Ravi Pratap <ravi@ximian.com>
9243 * cs-parser.jay (delegate_declaration): Store the fully qualified
9244 name as it is a type declaration.
9246 * delegate.cs (ReturnType, Name): Rename members to these. Make them
9249 (DefineDelegate): Renamed from Define. Does the same thing essentially,
9250 as TypeContainer::DefineType.
9252 (Populate): Method in which all the definition of the various methods (Invoke)
9255 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
9258 (CloseDelegate): Finally creates the delegate.
9260 * class.cs (TypeContainer::DefineType): Update to define delegates.
9261 (Populate, Emit and CloseType): Do the same thing here too.
9263 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
9264 delegates in all these operations.
9266 2001-10-14 Miguel de Icaza <miguel@ximian.com>
9268 * expression.cs: LocalTemporary: a new expression used to
9269 reference a temporary that has been created.
9271 * assign.cs: Handle PropertyAccess back here, so that we can
9272 provide the proper semantic access to properties.
9274 * expression.cs (Expression::ConvertReferenceExplicit): Implement
9275 a few more explicit conversions.
9277 * modifiers.cs: `NEW' modifier maps to HideBySig.
9279 * expression.cs (PropertyExpr): Make this into an
9280 ExpressionStatement, and support the EmitStatement code path.
9282 Perform get/set error checking, clean up the interface.
9284 * assign.cs: recognize PropertyExprs as targets, and if so, turn
9285 them into toplevel access objects.
9287 2001-10-12 Miguel de Icaza <miguel@ximian.com>
9289 * expression.cs: PropertyExpr::PropertyExpr: use work around the
9292 * typemanager.cs: Keep track here of our PropertyBuilders again to
9293 work around lameness in SRE.
9295 2001-10-11 Miguel de Icaza <miguel@ximian.com>
9297 * expression.cs (LValue::LValueResolve): New method in the
9298 interface, used to perform a second resolution pass for LValues.
9300 (This::DoResolve): Catch the use of this in static methods.
9302 (This::LValueResolve): Implement.
9304 (This::Store): Remove warning, assigning to `this' in structures
9307 (Invocation::Emit): Deal with invocation of
9308 methods on value types. We need to pass the address to structure
9309 methods rather than the object itself. (The equivalent code to
9310 emit "this" for structures leaves the entire structure on the
9311 stack instead of a pointer to it).
9313 (ParameterReference::DoResolve): Compute the real index for the
9314 argument based on whether the method takes or not a `this' pointer
9315 (ie, the method is static).
9317 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
9318 value types returned from functions when we need to invoke a
9319 method on the sturcture.
9322 2001-10-11 Ravi Pratap <ravi@ximian.com>
9324 * class.cs (TypeContainer::DefineType): Method to actually do the business of
9325 defining the type in the Modulebuilder or Typebuilder. This is to take
9326 care of nested types which need to be defined on the TypeBuilder using
9329 (TypeContainer::GetClassBases): Implement. Essentially the code from the
9330 methods in RootContext, only ported to be part of TypeContainer.
9332 (TypeContainer::GetInterfaceOrClass): Ditto.
9334 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
9336 * interface.cs (Interface::DefineInterface): New method. Does exactly
9337 what RootContext.CreateInterface did earlier, only it takes care of nested types
9340 (Interface::GetInterfaces): Move from RootContext here and port.
9342 (Interface::GetInterfaceByName): Same here.
9344 * rootcontext.cs (ResolveTree): Re-write.
9346 (PopulateTypes): Re-write.
9348 * class.cs (TypeContainer::Populate): Populate nested types too.
9349 (TypeContainer::Emit): Emit nested members too.
9351 * typemanager.cs (AddUserType): Do not make use of the FullName property,
9352 instead just use the name argument passed in as it is already fully
9355 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
9356 to TypeContainer mapping to see if a type is user-defined.
9358 * class.cs (TypeContainer::CloseType): Implement.
9360 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
9361 the default constructor.
9363 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
9366 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
9368 * interface.cs (CloseType): Create the type here.
9370 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
9373 Remove all the methods which are now in TypeContainer.
9375 2001-10-10 Ravi Pratap <ravi@ximian.com>
9377 * delegate.cs (Define): Re-write bits to define the delegate
9380 2001-10-10 Miguel de Icaza <miguel@ximian.com>
9382 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
9384 * expression.cs (ImplicitReferenceConversion): handle null as well
9385 as a source to convert to any reference type.
9387 * statement.cs (Return): Perform any implicit conversions to
9388 expected return type.
9390 Validate use of return statement.
9392 * codegen.cs (EmitContext): Pass the expected return type here.
9394 * class.cs (Method, Constructor, Property): Pass expected return
9395 type to EmitContext.
9397 2001-10-09 Miguel de Icaza <miguel@ximian.com>
9399 * expression.cs: Make DoResolve take an EmitContext instead of a
9402 Replaced `l' and `location' for `loc', for consistency.
9404 (Error, Warning): Remove unneeded Tc argument.
9406 * assign.cs, literal.cs, constant.cs: Update to new calling
9409 * codegen.cs: EmitContext now contains a flag indicating whether
9410 code is being generated in a static method or not.
9412 * cs-parser.jay: DecomposeQI, new function that replaces the old
9413 QualifiedIdentifier. Now we always decompose the assembled
9414 strings from qualified_identifier productions into a group of
9417 2001-10-08 Miguel de Icaza <miguel@ximian.com>
9419 * rootcontext.cs: Deal with field-less struct types correctly now
9420 by passing the size option to Define Type.
9422 * class.cs: Removed hack that created one static field.
9424 2001-10-07 Miguel de Icaza <miguel@ximian.com>
9426 * statement.cs: Moved most of the code generation here.
9428 2001-10-09 Ravi Pratap <ravi@ximian.com>
9430 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
9433 (ElementAccess): Remove useless bits for now - keep checks as the spec
9436 2001-10-08 Ravi Pratap <ravi@ximian.com>
9438 * expression.cs (ElementAccess::DoResolve): Remove my crap code
9439 and start performing checks according to the spec.
9441 2001-10-07 Ravi Pratap <ravi@ximian.com>
9443 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
9444 rank_specifiers instead.
9446 (rank_specifiers): Change the order in which the rank specifiers are stored
9448 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
9450 * expression.cs (ElementAccess): Implement the LValue interface too.
9452 2001-10-06 Ravi Pratap <ravi@ximian.com>
9454 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
9455 except that user defined conversions are not included.
9457 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
9458 perform the conversion of the return type, if necessary.
9460 (New::DoResolve): Check whether we are creating an array or an object
9461 and accordingly do the needful.
9463 (New::Emit): Same here.
9465 (New::DoResolve): Implement guts of array creation.
9467 (New::FormLookupType): Helper function.
9469 2001-10-07 Miguel de Icaza <miguel@ximian.com>
9471 * codegen.cs: Removed most of the code generation here, and move the
9472 corresponding code generation bits to the statement classes.
9474 Added support for try/catch/finalize and throw.
9476 * cs-parser.jay: Added support for try/catch/finalize.
9478 * class.cs: Catch static methods having the flags override,
9479 virtual or abstract.
9481 * expression.cs (UserCast): This user cast was not really doing
9482 what it was supposed to do. Which is to be born in fully resolved
9483 state. Parts of the resolution were being performed at Emit time!
9487 2001-10-05 Miguel de Icaza <miguel@ximian.com>
9489 * expression.cs: Implicity convert the result from UserCast.
9491 2001-10-05 Ravi Pratap <ravi@ximian.com>
9493 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
9494 prevented it from working correctly.
9496 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
9497 merely ConvertImplicit.
9499 2001-10-05 Miguel de Icaza <miguel@ximian.com>
9501 * typemanager.cs: Make the LookupTypeContainer function static,
9502 and not per-instance.
9504 * class.cs: Make static FindMembers (the one that takes a Type
9507 * codegen.cs: Add EmitForeach here.
9509 * cs-parser.jay: Make foreach a toplevel object instead of the
9510 inline expansion, as we need to perform semantic analysis on it.
9512 2001-10-05 Ravi Pratap <ravi@ximian.com>
9514 * expression.cs (Expression::ImplicitUserConversion): Rename to
9515 UserDefinedConversion.
9517 (Expression::UserDefinedConversion): Take an extra argument specifying
9518 whether we look for explicit user conversions too.
9520 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
9522 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
9524 (ExplicitUserConversion): Make it a call to UserDefinedConversion
9525 with the appropriate arguments.
9527 * cs-parser.jay (cast_expression): Record location too.
9529 * expression.cs (Cast): Record location info.
9531 (Expression::ConvertExplicit): Take location argument.
9533 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
9534 to determine if we are doing explicit conversions.
9536 (UserCast::Emit): Update accordingly.
9538 (Expression::ConvertExplicit): Report an error if everything fails.
9540 * ../errors/cs0030.cs : Add.
9542 2001-10-04 Miguel de Icaza <miguel@ximian.com>
9544 * modifiers.cs: If the ABSTRACT keyword is present, also set the
9545 virtual and newslot bits.
9547 * class.cs (TypeContainer::RegisterRequiredImplementations):
9548 Record methods we need.
9550 (TypeContainer::MakeKey): Helper function to make keys for
9551 MethodBases, since the Methodbase key is useless.
9553 (TypeContainer::Populate): Call RegisterRequiredImplementations
9554 before defining the methods.
9556 Create a mapping for method_builders_to_methods ahead of time
9557 instead of inside a tight loop.
9559 (::RequireMethods): Accept an object as the data to set into the
9560 hashtable so we can report interface vs abstract method mismatch.
9562 2001-10-03 Miguel de Icaza <miguel@ximian.com>
9564 * report.cs: Make all of it static.
9566 * rootcontext.cs: Drop object_type and value_type computations, as
9567 we have those in the TypeManager anyways.
9569 Drop report instance variable too, now it is a global.
9571 * driver.cs: Use try/catch on command line handling.
9573 Add --probe option to debug the error reporting system with a test
9576 * report.cs: Add support for exiting program when a probe
9577 condition is reached.
9579 2001-10-03 Ravi Pratap <ravi@ximian.com>
9581 * expression.cs (Binary::DoNumericPromotions): Fix the case when
9582 we do a forcible conversion regardless of type, to check if
9583 ForceConversion returns a null.
9585 (Binary::error19): Use location to report error.
9587 (Unary::error23): Use location here too.
9589 * ../errors/cs0019.cs : Check in.
9591 * ../errors/cs0023.cs : Check in.
9593 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
9594 case of a non-null MethodInfo object with a length of 0 !
9596 (Binary::ResolveOperator): Flag error if overload resolution fails to find
9597 an applicable member - according to the spec :-)
9598 Also fix logic to find members in base types.
9600 (Unary::ResolveOperator): Same here.
9602 (Unary::report23): Change name to error23 and make first argument a TypeContainer
9603 as I was getting thoroughly confused between this and error19 :-)
9605 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
9606 (::FindMostEncompassedType): Implement.
9607 (::FindMostEncompassingType): Implement.
9608 (::StandardConversionExists): Implement.
9610 (UserImplicitCast): Re-vamp. We now need info about most specific
9611 source and target types so that we can do the necessary conversions.
9613 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
9614 mathematical union with no duplicates.
9616 2001-10-03 Miguel de Icaza <miguel@ximian.com>
9618 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
9619 in order from base classes to child classes, so that we can in
9620 child classes look up in our parent for method names and
9621 attributes (required for handling abstract, virtual, new, override
9622 constructs: we need to instrospect our base class, and if we dont
9623 populate the classes in order, the introspection might be
9624 incorrect. For example, a method could query its parent before
9625 the parent has any methods and would determine that the parent has
9626 no abstract methods (while it could have had them)).
9628 (RootContext::CreateType): Record the order in which we define the
9631 2001-10-02 Miguel de Icaza <miguel@ximian.com>
9633 * class.cs (TypeContainer::Populate): Also method definitions can
9634 fail now, keep track of this.
9636 (TypeContainer::FindMembers): Implement support for
9637 DeclaredOnly/noDeclaredOnly flag.
9639 (Constructor::Emit) Return the ConstructorBuilder.
9641 (Method::Emit) Return the MethodBuilder.
9642 Check for abstract or virtual methods to be public.
9644 * rootcontext.cs (RootContext::CreateType): Register all the
9645 abstract methods required for the class to be complete and the
9646 interface methods that must be implemented.
9648 * cs-parser.jay: Report error 501 (method requires body if it is
9649 not marked abstract or extern).
9651 * expression.cs (TypeOf::Emit): Implement.
9653 * typemanager.cs: runtime_handle_type, new global type.
9655 * class.cs (Property::Emit): Generate code for properties.
9657 2001-10-02 Ravi Pratap <ravi@ximian.com>
9659 * expression.cs (Unary::ResolveOperator): Find operators on base type
9660 too - we now conform exactly to the spec.
9662 (Binary::ResolveOperator): Same here.
9664 * class.cs (Operator::Define): Fix minor quirk in the tests.
9666 * ../errors/cs0215.cs : Added.
9668 * ../errors/cs0556.cs : Added.
9670 * ../errors/cs0555.cs : Added.
9672 2001-10-01 Miguel de Icaza <miguel@ximian.com>
9674 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
9675 single integer which is really efficient
9677 2001-10-01 Ravi Pratap <ravi@ximian.com>
9679 * expression.cs (Expression::ImplicitUserConversion): Use location
9680 even in the case when we are examining True operators.
9682 * class.cs (Operator::Define): Perform extensive checks to conform
9683 with the rules for operator overloading in the spec.
9685 * expression.cs (Expression::ImplicitReferenceConversion): Implement
9686 some of the other conversions mentioned in the spec.
9688 * typemanager.cs (array_type): New static member for the System.Array built-in
9691 (cloneable_interface): For System.ICloneable interface.
9693 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
9694 we start resolving the tree and populating types.
9696 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
9698 2001-10-01 Miguel de Icaza <miguel@ximian.com>
9700 * expression.cs (Expression::ExprClassFromMemberInfo,
9701 Expression::Literalize): Create literal expressions from
9702 FieldInfos which are literals.
9704 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
9705 type casts, because they were wrong. The test suite in tests
9708 (ImplicitNumericConversion): ushort to ulong requires a widening
9711 Int32 constant to long requires widening cast as well.
9713 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
9714 for integers because the type on the stack is not i4.
9716 2001-09-30 Miguel de Icaza <miguel@ximian.com>
9718 * expression.cs (report118): require location argument.
9720 * parameter.cs: Do not dereference potential null value.
9722 * class.cs: Catch methods that lack the `new' keyword when
9723 overriding a name. Report warnings when `new' is used without
9724 anything being there to override.
9726 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
9728 * class.cs: Only add constructor to hashtable if it is non-null
9729 (as now constructors can fail on define).
9731 (TypeManager, Class, Struct): Take location arguments.
9733 Catch field instance initialization in structs as errors.
9735 accepting_filter: a new filter for FindMembers that is static so
9736 that we dont create an instance per invocation.
9738 (Constructor::Define): Catch errors where a struct constructor is
9741 * cs-parser.jay: Pass location information for various new
9744 * delegate.cs (Delegate): take a location argument.
9746 * driver.cs: Do not call EmitCode if there were problesm in the
9747 Definition of the types, as many Builders wont be there.
9749 * decl.cs (Decl::Decl): Require a location argument.
9751 * cs-tokenizer.cs: Handle properly hex constants that can not fit
9752 into integers, and find the most appropiate integer for it.
9754 * literal.cs: Implement ULongLiteral.
9756 * rootcontext.cs: Provide better information about the location of
9757 failure when CreateType fails.
9759 2001-09-29 Miguel de Icaza <miguel@ximian.com>
9761 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
9764 * expression.cs (Binary::CheckShiftArguments): Add missing type
9766 (Binary::ResolveOperator): Add type to the logical and and logical
9767 or, Bitwise And/Or and Exclusive Or code paths, it was missing
9770 (Binary::DoNumericPromotions): In the case where either argument
9771 is ulong (and most signed types combined with ulong cause an
9772 error) perform implicit integer constant conversions as well.
9774 2001-09-28 Miguel de Icaza <miguel@ximian.com>
9776 * expression.cs (UserImplicitCast): Method should always be
9778 (Invocation::BetterConversion): Simplified test for IntLiteral.
9780 (Expression::ImplicitNumericConversion): Split this routine out.
9781 Put the code that performs implicit constant integer conversions
9784 (Expression::Resolve): Become a wrapper around DoResolve so we can
9785 check eclass and type being set after resolve.
9787 (Invocation::Badness): Remove this dead function
9789 (Binary::ResolveOperator): Do not compute the expensive argumnets
9790 unless we have a union for it.
9792 (Probe::Emit): Is needs to do an isinst and then
9793 compare against null.
9795 (::CanConvert): Added Location argument. If the Location argument
9796 is null (Location.Null), then we do not report errors. This is
9797 used by the `probe' mechanism of the Explicit conversion. We do
9798 not want to generate an error for something that the user
9799 explicitly requested to be casted. But the pipeline for an
9800 explicit cast first tests for potential implicit casts.
9802 So for now, if the Location is null, it means `Probe only' to
9803 avoid adding another argument. Might have to revise this
9806 (ClassCast): New class used to type cast objects into arbitrary
9807 classes (used in Explicit Reference Conversions).
9809 Implement `as' as well.
9811 Reverted all the patches from Ravi below: they were broken:
9813 * The use of `level' as a mechanism to stop recursive
9814 invocations is wrong. That was there just to catch the
9815 bug with a strack trace but not as a way of addressing
9818 To fix the problem we have to *understand* what is going
9819 on and the interactions and come up with a plan, not
9820 just get things going.
9822 * The use of the type conversion cache that I proposed
9823 last night had an open topic: How does this work across
9824 protection domains. A user defined conversion might not
9825 be public in the location where we are applying the
9826 conversion, a different conversion might be selected
9827 (ie, private A->B (better) but public B->A (worse),
9828 inside A, A->B applies, but outside it, B->A will
9831 * On top of that (ie, even if the above is solved),
9832 conversions in a cache need to be abstract. Ie, `To
9833 convert from an Int to a Short use an OpcodeCast', not
9834 `To convert from an Int to a Short use the OpcodeCast on
9835 the variable 5' (which is what this patch was doing).
9837 2001-09-28 Ravi Pratap <ravi@ximian.com>
9839 * expression.cs (Invocation::ConversionExists): Re-write to use
9840 the conversion cache
9842 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
9843 cache all conversions done, not just user-defined ones.
9845 (Invocation::BetterConversion): The real culprit. Use ConversionExists
9846 to determine if a conversion exists instead of acutually trying to
9847 perform the conversion. It's faster too.
9849 (Expression::ConvertExplicit): Modify to use ConversionExists to check
9850 and only then attempt the implicit conversion.
9852 2001-09-28 Ravi Pratap <ravi@ximian.com>
9854 * expression.cs (ConvertImplicit): Use a cache for conversions
9855 already found. Check level of recursion and bail out if necessary.
9857 2001-09-28 Miguel de Icaza <miguel@ximian.com>
9859 * typemanager.cs (string_concat_string_string, string_concat_object_object):
9860 Export standard methods that we expect for string operations.
9862 * statement.cs (Block::UsageWarning): Track usage of variables and
9863 report the errors for not used variables.
9865 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
9868 2001-09-27 Miguel de Icaza <miguel@ximian.com>
9870 * codegen.cs: remove unnneded code
9872 * expression.cs: Removed BuiltinTypeAccess class
9874 Fix the order in which implicit conversions are
9877 The previous fixed dropped support for boxed conversions (adding a
9878 test to the test suite now)
9880 (UserImplicitCast::CanConvert): Remove test for source being null,
9881 that code is broken. We should not feed a null to begin with, if
9882 we do, then we should track the bug where the problem originates
9883 and not try to cover it up here.
9885 Return a resolved expression of type UserImplicitCast on success
9886 rather than true/false. Ravi: this is what I was talking about,
9887 the pattern is to use a static method as a "constructor" for
9890 Also, do not create arguments until the very last minute,
9891 otherwise we always create the arguments even for lookups that
9892 will never be performed.
9894 (UserImplicitCast::Resolve): Eliminate, objects of type
9895 UserImplicitCast are born in a fully resolved state.
9897 * typemanager.cs (InitCoreTypes): Init also value_type
9900 * expression.cs (Cast::Resolve): First resolve the child expression.
9902 (LValue): Add new method AddressOf to be used by
9905 Change the argument of Store to take an EmitContext instead of an
9906 ILGenerator, because things like FieldExpr need to be able to call
9907 their children expression to generate the instance code.
9909 (Expression::Error, Expression::Warning): Sugar functions for
9912 (Expression::MemberLookup): Accept a TypeContainer instead of a
9913 Report as the first argument.
9915 (Expression::ResolvePrimary): Killed. I still want to improve
9916 this as currently the code is just not right.
9918 (Expression::ResolveMemberAccess): Simplify, but it is still
9921 (Unary::Resolve): Catch errors in AddressOf operators.
9923 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
9924 index to a byte for the short-version, or the compiler will choose
9925 the wrong Emit call, which generates the wrong data.
9927 (ParameterReference::Emit, ::Store): same.
9929 (FieldExpr::AddressOf): Implement.
9931 * typemanager.cs: TypeManager: made public variable instead of
9934 * driver.cs: document --fatal.
9936 * report.cs (ErrorMessage, WarningMessage): new names for the old
9937 Error and Warning classes.
9939 * cs-parser.jay (member_access): Turn built-in access to types
9940 into a normal simplename
9942 2001-09-27 Ravi Pratap <ravi@ximian.com>
9944 * expression.cs (Invocation::BetterConversion): Fix to cope
9945 with q being null, since this was introducing a bug.
9947 * expression.cs (ConvertImplicit): Do built-in conversions first.
9949 2001-09-27 Ravi Pratap <ravi@ximian.com>
9951 * expression.cs (UserImplicitCast::Resolve): Fix bug.
9953 2001-09-27 Ravi Pratap <ravi@ximian.com>
9955 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
9956 I had introduced long ago (what's new ?).
9958 * expression.cs (UserImplicitCast::CanConvert): Static method to do
9959 the work of all the checking.
9960 (ConvertImplicit): Call CanConvert and only then create object if necessary.
9961 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
9963 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
9964 that is the right way.
9966 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
9967 overloading resolution. Use everywhere instead of cutting and pasting code.
9969 (Binary::ResolveOperator): Use MakeUnionSet.
9971 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
9972 we have to convert to bool types. Not complete yet.
9974 2001-09-27 Miguel de Icaza <miguel@ximian.com>
9976 * typemanager.cs (TypeManager::CSharpName): support ushort.
9978 * expression.cs (Expression::TryImplicitIntConversion): Attempts
9979 to provide an expression that performsn an implicit constant int
9980 conversion (section 6.1.6).
9981 (Expression::ConvertImplicitRequired): Reworked to include
9982 implicit constant expression conversions.
9984 (Expression::ConvertNumericExplicit): Finished.
9986 (Invocation::Emit): If InstanceExpression is null, then it means
9987 that we perform a call on this.
9989 2001-09-26 Miguel de Icaza <miguel@ximian.com>
9991 * expression.cs (Unary::Emit): Remove some dead code.
9992 (Probe): Implement Resolve and Emit for `is'.
9993 (Expression::ConvertImplicitRequired): Attempt to do constant
9994 expression conversions here. Maybe should be moved to
9995 ConvertImplicit, but I am not sure.
9996 (Expression::ImplicitLongConstantConversionPossible,
9997 Expression::ImplicitIntConstantConversionPossible): New functions
9998 that tell whether is it possible to apply an implicit constant
9999 expression conversion.
10001 (ConvertNumericExplicit): Started work on explicit numeric
10004 * cs-parser.jay: Update operator constants.
10006 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
10007 (Parameters::GetSignature): Hook up VerifyArgs here.
10008 (Parameters::VerifyArgs): Verifies that no two arguments have the
10011 * class.cs (Operator): Update the operator names to reflect the
10012 ones that the spec expects (as we are just stringizing the
10015 * expression.cs (Unary::ResolveOperator): Fix bug: Use
10016 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
10017 previous usage did only work for our methods.
10018 (Expression::ConvertImplicit): Handle decimal implicit numeric
10019 conversions as well.
10020 (Expression::InternalTypeConstructor): Used to invoke constructors
10021 on internal types for default promotions.
10023 (Unary::Emit): Implement special handling for the pre/post
10024 increment/decrement for overloaded operators, as they need to have
10025 the same semantics as the other operators.
10027 (Binary::ResolveOperator): ditto.
10028 (Invocation::ConversionExists): ditto.
10029 (UserImplicitCast::Resolve): ditto.
10031 2001-09-26 Ravi Pratap <ravi@ximian.com>
10033 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
10034 operator, return after emitting body. Regression tests pass again !
10036 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
10037 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
10038 (Invocation::OverloadResolve): Ditto.
10039 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
10041 * everywhere : update calls to the above methods accordingly.
10043 2001-09-26 Miguel de Icaza <miguel@ximian.com>
10045 * assign.cs (Assign): Make it inherit from ExpressionStatement.
10047 * expression.cs (ExpressionStatement): New base class used for
10048 expressions that can appear in statements, so that we can provide
10049 an alternate path to generate expression that do not leave a value
10052 (Expression::Emit, and all the derivatives): We no longer return
10053 whether a value is left on the stack or not. Every expression
10054 after being emitted leaves a single value on the stack.
10056 * codegen.cs (EmitContext::EmitStatementExpression): Use the
10057 facilties of ExpressionStatement if possible.
10059 * cs-parser.jay: Update statement_expression.
10061 2001-09-25 Miguel de Icaza <miguel@ximian.com>
10063 * driver.cs: Change the wording of message
10065 2001-09-25 Ravi Pratap <ravi@ximian.com>
10067 * expression.cs (Binary::ResolveOperator): Had forgottten to set
10068 the type of the expression to the return type of the method if
10069 we have an overloaded operator match ! The regression tests pass again !
10070 (Unary::ResolveOperator): Ditto.
10072 * expression.cs (Invocation::ConversionExists): Correct the member lookup
10073 to find "op_Implicit", not "implicit" ;-)
10074 (UserImplicitCast): New class to take care of user-defined implicit conversions.
10075 (ConvertImplicit, ForceConversion): Take TypeContainer argument
10077 * everywhere : Correct calls to the above accordingly.
10079 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
10080 (ConvertImplicit): Do user-defined conversion if it exists.
10082 2001-09-24 Miguel de Icaza <miguel@ximian.com>
10084 * assign.cs: track location.
10085 (Resolve): Use implicit conversions on assignment.
10087 * literal.cs: Oops. Not good, Emit of short access values should
10088 pass (Bytes) or the wrong argument will be selected.
10090 * expression.cs (Unary::Emit): Emit code for -expr.
10092 (Unary::ResolveOperator): Handle `Substract' for non-constants
10093 (substract from zero from the non-constants).
10094 Deal with Doubles as well.
10096 (Expression::ConvertImplicitRequired): New routine that reports an
10097 error if no implicit conversion exists.
10099 (Invocation::OverloadResolve): Store the converted implicit
10100 expressions if we make them
10102 2001-09-24 Ravi Pratap <ravi@ximian.com>
10104 * class.cs (ConstructorInitializer): Take a Location argument.
10105 (ConstructorBaseInitializer): Same here.
10106 (ConstructorThisInitializer): Same here.
10108 * cs-parser.jay : Update all calls accordingly.
10110 * expression.cs (Unary, Binary, New): Take location argument.
10111 Update accordingly everywhere.
10113 * cs-parser.jay : Update all calls to the above to take a location
10116 * class.cs : Ditto.
10118 2001-09-24 Ravi Pratap <ravi@ximian.com>
10120 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
10121 (Invocation::BetterConversion): Same here
10122 (Invocation::ConversionExists): Ditto.
10124 (Invocation::ConversionExists): Implement.
10126 2001-09-22 Ravi Pratap <ravi@ximian.com>
10128 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
10129 Also take an additional TypeContainer argument.
10131 * All over : Pass in TypeContainer as argument to OverloadResolve.
10133 * typemanager.cs (CSharpName): Update to check for the string type and return
10136 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
10139 2001-09-21 Ravi Pratap <ravi@ximian.com>
10141 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
10142 (Invocation::BetterFunction): Implement.
10143 (Invocation::BetterConversion): Implement.
10144 (Invocation::ConversionExists): Skeleton, no implementation yet.
10146 Okay, things work fine !
10148 2001-09-21 Miguel de Icaza <miguel@ximian.com>
10150 * typemanager.cs: declare and load enum_type, delegate_type and
10153 * expression.cs (Expression::Emit): Now emit returns a value that
10154 tells whether a value is left on the stack or not. This strategy
10155 might be reveted tomorrow with a mechanism that would address
10156 multiple assignments.
10157 (Expression::report118): Utility routine to report mismatches on
10160 (Unary::Report23): Report impossible type/operator combination
10163 (Unary::IsIncrementableNumber): Whether the type can be
10164 incremented or decremented with add.
10165 (Unary::ResolveOperator): Also allow enumerations to be bitwise
10167 (Unary::ResolveOperator): Implement ++, !, ~,
10169 (Invocation::Emit): Deal with new Emit convetion.
10171 * All Expression derivatives: Updated their Emit method to return
10172 whether they leave values on the stack or not.
10174 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
10175 stack for expressions that are statements.
10177 2001-09-20 Miguel de Icaza <miguel@ximian.com>
10179 * expression.cs (LValue): New interface. Must be implemented by
10181 (LocalVariableReference, ParameterReference, FieldExpr): Implement
10184 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
10185 interface for generating code, simplifies the code.
10187 2001-09-20 Ravi Pratap <ravi@ximian.com>
10189 * expression.cs (everywhere): Comment out return statements in ::Resolve
10190 methods to avoid the warnings.
10192 2001-09-20 Miguel de Icaza <miguel@ximian.com>
10194 * driver.cs (parse): Report error 2001 if we can not open the
10197 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
10200 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
10203 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
10204 otherwise nested blocks end up with the same index.
10206 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
10208 * expression.cs: Instead of having FIXMEs in the Resolve
10209 functions, throw exceptions so it is obvious that we are facing a
10212 * cs-parser.jay (invocation_expression): Pass Location information.
10214 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
10215 Use a basename for those routines because .NET does not like paths
10218 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
10221 2001-09-19 Miguel de Icaza <miguel@ximian.com>
10223 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
10224 are loading the correct data types (throws an exception if not).
10225 (TypeManager::InitCoreTypes): Use CoreLookupType
10227 * expression.cs (Unary::ResolveOperator): return the child
10228 expression for expressions which are just +expr.
10229 (Unary::ResolveOperator): Return negative literals for -LITERAL
10230 expressions (otherwise they are Unary {Literal}).
10231 (Invocation::Badness): Take into account `Implicit constant
10232 expression conversions'.
10234 * literal.cs (LongLiteral): Implement long literal class.
10235 (IntLiteral): export the `Value' of the intliteral.
10237 2001-09-19 Ravi Pratap <ravi@ximian.com>
10239 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
10241 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
10242 instead of 'Operator'
10244 * expression.cs (Binary::ResolveOperator): Update accordingly.
10245 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
10248 * cs-parser.jay (unary_expression): Update to use the new names.
10250 * gen-treedump.cs (GetUnary): Same here.
10252 * expression.cs (Unary::Resolve): Implement.
10253 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
10254 operators are found instead of making noise ;-)
10255 (Unary::ResolveOperator): New method to do precisely the same thing which
10256 Binary::ResolveOperator does for Binary expressions.
10257 (Unary.method, .Arguments): Add.
10258 (Unary::OperName): Implement.
10259 (Unary::ForceConversion): Copy and Paste !
10261 * class.cs (Operator::Define): Fix a small bug for the case when we have
10264 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
10265 for the inbuilt operators. Only overloading works for now ;-)
10267 2001-09-18 Miguel de Icaza <miguel@ximian.com>
10269 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
10270 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
10272 * expression.cs (This::Emit): Implement.
10273 (This::Resolve): Implement.
10274 (TypeOf:Resolve): Implement.
10275 (Expression::ResolveSimpleName): Add an implicit this to instance
10277 (MemberAccess::Resolve): Deal with Parameters and Fields.
10278 Bind instance variable to Field expressions.
10279 (FieldExpr::Instance): New field used to track the expression that
10280 represents the object instance.
10281 (FieldExpr::Resolve): Track potential errors from MemberLookup not
10283 (FieldExpr::Emit): Implement.
10285 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
10286 the last instruction contains a return opcode to avoid generating
10287 the last `ret' instruction (this generates correct code, and it is
10288 nice to pass the peverify output).
10290 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
10291 initializer for static and instance variables.
10292 (Constructor::Emit): Allow initializer to be null in the case of
10293 static constructors. Only emit initializer for instance
10296 (TypeContainer::FindMembers): Return a null array if there are no
10299 Also fix the code for the MemberTypes.Method branch, as it was not
10300 scanning that for operators (or tried to access null variables before).
10302 * assign.cs (Assign::Emit): Handle instance and static fields.
10306 * driver.cs: Stop compilation if there are parse errors.
10308 * cs-parser.jay (constructor_declaration): Provide default base
10309 initializer for non-static constructors.
10310 (constructor_declarator): Do not provide a default base
10311 initializers if none was specified.
10312 Catch the fact that constructors should not have parameters.
10314 * class.cs: Do not emit parent class initializers for static
10315 constructors, that should be flagged as an error.
10317 2001-09-18 Ravi Pratap <ravi@ximian.com>
10319 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
10320 Move back code into TypeContainer::Populate.
10322 2001-09-18 Ravi Pratap <ravi@ximian.com>
10324 * class.cs (TypeContainer::AddConstructor): Fix the check to
10325 compare against Name, not Basename.
10326 (Operator::OpType): Change Plus and Minus to Add and Subtract.
10328 * cs-parser.jay : Update accordingly.
10330 * class.cs (TypeContainer::FindMembers): For the case where we are searching
10331 for methods, don't forget to look into the operators too.
10332 (RegisterMethodBuilder): Helper method to take care of this for
10333 methods, constructors and operators.
10334 (Operator::Define): Completely revamp.
10335 (Operator.OperatorMethod, MethodName): New fields.
10336 (TypeContainer::Populate): Move the registering of builders into
10337 RegisterMethodBuilder.
10338 (Operator::Emit): Re-write.
10340 * expression.cs (Binary::Emit): Comment out code path to emit method
10341 invocation stuff for the case when we have a user defined operator. I am
10342 just not able to get it right !
10344 2001-09-17 Miguel de Icaza <miguel@ximian.com>
10346 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
10349 (Expression::MemberLookup): Provide a version that allows to
10350 specify the MemberTypes and BindingFlags.
10352 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
10353 so it was not fetching variable information from outer blocks.
10355 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
10356 Beforefieldinit as it was buggy.
10358 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
10359 that Ravi put here.
10361 * class.cs (Constructor::Emit): Only emit if block is not null.
10362 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
10363 deal with this by semantically definining it as if the user had
10366 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
10367 constructors as we now "emit" them at a higher level.
10369 (TypeContainer::DefineDefaultConstructor): Used to define the
10370 default constructors if none was provided.
10372 (ConstructorInitializer): Add methods Resolve and Emit.
10374 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
10376 2001-09-17 Ravi Pratap <ravi@ximian.com>
10378 * class.cs (TypeContainer::EmitDefaultConstructor): Register
10379 the default constructor builder with our hashtable for methodbuilders
10382 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
10383 and argument_count is 0 in which case we have a match.
10384 (Binary::ResolveOperator): More null checking and miscellaneous coding
10387 2001-09-17 Ravi Pratap <ravi@ximian.com>
10389 * rootcontext.cs (IsNameSpace): Compare against null.
10391 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
10393 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
10394 and Unary::Operator.
10396 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
10399 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
10400 we have overloaded operators.
10401 (Binary::ResolveOperator): Implement the part which does the operator overload
10404 * class.cs (Operator::Emit): Implement.
10405 (TypeContainer::Emit): Emit the operators we have too.
10407 * expression.cs (Binary::Emit): Update to emit the appropriate code for
10408 the case when we have a user-defined operator.
10410 2001-09-17 Miguel de Icaza <miguel@ximian.com>
10412 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
10414 2001-09-16 Ravi Pratap <ravi@ximian.com>
10416 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
10417 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
10418 (Constructor::Emit): Implement.
10419 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
10420 if we have no work to do.
10421 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
10424 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
10425 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
10427 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
10430 2001-09-15 Ravi Pratap <ravi@ximian.com>
10432 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
10434 (Tree::RecordNamespace): Method to do what the name says ;-)
10435 (Tree::Namespaces): Property to get at the namespaces hashtable.
10437 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
10440 * rootcontext.cs (IsNamespace): Fixed it :-)
10442 2001-09-14 Miguel de Icaza <miguel@ximian.com>
10444 * class.cs (TypeContainer::FindMembers): Add support for
10446 (MethodCore): New class that encapsulates both the shared aspects
10447 of a Constructor and a Method.
10448 (Method, Constructor): Factored pieces into MethodCore.
10450 * driver.cs: Added --fatal which makes errors throw exceptions.
10451 Load System assembly as well as part of the standard library.
10453 * report.cs: Allow throwing exceptions on errors for debugging.
10455 * modifiers.cs: Do not use `parent', instead use the real type
10456 container to evaluate permission settings.
10458 * class.cs: Put Ravi's patch back in. He is right, and we will
10459 have to cope with the
10461 2001-09-14 Ravi Pratap <ravi@ximian.com>
10463 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
10464 FamORAssem, not FamANDAssem.
10466 2001-09-14 Miguel de Icaza <miguel@ximian.com>
10468 * driver.cs: Added --parse option that only parses its input files
10471 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
10472 incorrect. IsTopLevel is not used to tell whether an object is
10473 root_types or not (that can be achieved by testing this ==
10474 root_types). But to see if this is a top-level *class* (not
10475 necessarly our "toplevel" container).
10477 2001-09-14 Ravi Pratap <ravi@ximian.com>
10479 * enum.cs (Enum::Define): Modify to call the Lookup method on the
10480 parent instead of a direct call to GetType.
10482 2001-09-14 Ravi Pratap <ravi@ximian.com>
10484 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
10485 Modifiers.TypeAttr. This should just be a call to that method.
10487 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
10488 object so that we can determine if we are top-level or not.
10490 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
10493 * enum.cs (Enum::Define): Ditto.
10495 * modifiers.cs (FieldAttr): Re-write.
10497 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
10498 (TypeContainer::HaveStaticConstructor): New property to provide access
10499 to precisely that info.
10501 * modifiers.cs (MethodAttr): Re-write.
10502 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
10504 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
10505 of top-level types as claimed.
10507 2001-09-13 Miguel de Icaza <miguel@ximian.com>
10509 * expression.cs (MemberLookup): Fruitless attempt to lookup
10510 constructors. Maybe I need to emit default constructors? That
10511 might be it (currently .NET emits this for me automatically).
10512 (Invocation::OverloadResolve): Cope with Arguments == null.
10513 (Invocation::EmitArguments): new function, shared by the new
10514 constructor and us.
10515 (Invocation::Emit): Handle static and instance methods. Emit
10516 proper call instruction for virtual or non-virtual invocations.
10517 (New::Emit): Implement.
10518 (New::Resolve): Implement.
10519 (MemberAccess:Resolve): Implement.
10520 (MethodGroupExpr::InstanceExpression): used conforming to the spec
10521 to track instances.
10522 (FieldExpr::Resolve): Set type.
10524 * support.cs: Handle empty arguments.
10526 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
10527 SimpleLookup): Auxiliary routines to help parse a qualifier
10530 Update qualifier_identifier rule.
10532 * codegen.cs: Removed debugging messages.
10534 * class.cs: Make this a global thing, this acts just as a "key" to
10535 objects that we might have around.
10537 (Populate): Only initialize method_builders_to_methods once.
10539 * expression.cs (PropertyExpr): Initialize type from the
10542 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
10543 Resolve pattern. Attempt to implicitly convert value to boolean.
10546 * expression.cs: Set the type for the int32/int32 argument case.
10547 (Binary::ResolveOperator): Set the return type to boolean for
10548 comparission operators
10550 * typemanager.cs: Remove debugging print code.
10552 (Invocation::Resolve): resolve type.
10554 * class.cs: Allocate a MemberInfo of the correct size, as the code
10555 elsewhere depends on the test to reflect the correct contents.
10557 (Method::) Keep track of parameters, due to System.Reflection holes
10559 (TypeContainer::Populate): Keep track of MethodBuilders to Method
10562 (TypeContainer::FindMembers): Use ArrayList and then copy an array
10563 of the exact size and return that.
10565 (Class::LookupMethodByBuilder): New function that maps
10566 MethodBuilders to its methods. Required to locate the information
10567 on methods because System.Reflection bit us again.
10569 * support.cs: New file, contains an interface ParameterData and
10570 two implementations: ReflectionParameters and InternalParameters
10571 used to access Parameter information. We will need to grow this
10574 * expression.cs (Invocation::GetParameterData): implement a cache
10575 and a wrapper around the ParameterData creation for methods.
10576 (Invocation::OverloadResolve): Use new code.
10578 2001-09-13 Ravi Pratap <ravi@ximian.com>
10580 * class.cs (TypeContainer::EmitField): Remove and move into
10581 (Field::Define): here and modify accordingly.
10582 (Field.FieldBuilder): New member.
10583 (TypeContainer::Populate): Update accordingly.
10584 (TypeContainer::FindMembers): Implement.
10586 2001-09-13 Miguel de Icaza <miguel@ximian.com>
10588 * statement.cs: (VariableInfo::VariableType): New field to be
10589 initialized with the full type once it is resolved.
10591 2001-09-12 Miguel de Icaza <miguel@ximian.com>
10593 * parameter.cs (GetParameterInfo): Use a type cache to compute
10594 things only once, and to reuse this information
10596 * expression.cs (LocalVariableReference::Emit): Implement.
10597 (OpcodeCast::Emit): fix.
10599 (ParameterReference::Resolve): Implement.
10600 (ParameterReference::Emit): Implement.
10602 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
10603 that are expressions need to stay as Expressions.
10605 * typemanager.cs (CSharpName): Returns the C# name of a type if
10608 * expression.cs (Expression::ConvertImplicit): New function that
10609 implements implicit type conversions.
10611 (Expression::ImplicitReferenceConversion): Implements implicit
10612 reference conversions.
10614 (EmptyCast): New type for transparent casts.
10616 (OpcodeCast): New type for casts of types that are performed with
10617 a sequence of bytecodes.
10619 (BoxedCast): New type used for casting value types into reference
10620 types. Emits a box opcode.
10622 (Binary::DoNumericPromotions): Implements numeric promotions of
10623 and computation of the Binary::Type.
10625 (Binary::EmitBranchable): Optimization.
10627 (Binary::Emit): Implement code emission for expressions.
10629 * typemanager.cs (TypeManager): Added two new core types: sbyte
10632 2001-09-12 Ravi Pratap <ravi@ximian.com>
10634 * class.cs (TypeContainer::FindMembers): Method which does exactly
10635 what Type.FindMembers does, only we don't have to use reflection. No
10636 implementation yet.
10638 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
10639 typecontainer objects as we need to get at them.
10640 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
10642 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
10643 typecontainer object.
10645 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
10646 of just a Report object.
10648 2001-09-11 Ravi Pratap <ravi@ximian.com>
10650 * class.cs (Event::Define): Go back to using the prefixes "add_" and
10652 (TypeContainer::Populate): Now define the delegates of the type too.
10653 (TypeContainer.Delegates): Property to access the list of delegates defined
10656 * delegates.cs (Delegate::Define): Implement partially.
10658 * modifiers.cs (TypeAttr): Handle more flags.
10660 2001-09-11 Ravi Pratap <ravi@ximian.com>
10662 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
10664 (Operator::Define): Re-write logic to get types by using the LookupType method
10665 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
10666 (Indexer::Define): Ditto.
10667 (Event::Define): Ditto.
10668 (Property::Define): Ditto.
10670 2001-09-10 Ravi Pratap <ravi@ximian.com>
10672 * class.cs (TypeContainer::Populate): Now define operators too.
10673 (TypeContainer.Operators): New property to access the list of operators
10675 (Operator.OperatorMethodBuilder): New member to hold the method builder
10676 for the operator we are defining.
10677 (Operator::Define): Implement.
10679 2001-09-10 Ravi Pratap <ravi@ximian.com>
10681 * class.cs (Event::Define): Make the prefixes of the accessor methods
10682 addOn_ and removeOn_
10684 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
10685 of the location being passed in too. Ideally, this should go later since all
10686 error reporting should be done through the Report object.
10688 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
10689 (Populate): Iterate thru the indexers we have and define them too.
10690 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
10691 for the get and set accessors.
10692 (Indexer::Define): Implement.
10694 2001-09-09 Miguel de Icaza <miguel@ximian.com>
10696 * expression.cs (Binary::Resolve): Beginning of it. I scratched
10697 my previous implementation, did not work.
10699 * typemanager.cs: Add a couple of missing types (the longs).
10701 * literal.cs: Use TypeManager.bool_type instead of getting it.
10703 * expression.cs (EventExpr): New kind of expressions.
10704 (Expressio::ExprClassFromMemberInfo): finish
10706 2001-09-08 Miguel de Icaza <miguel@ximian.com>
10708 * assign.cs: Emit stores to static fields differently.
10710 2001-09-08 Ravi Pratap <ravi@ximian.com>
10712 * Merge in changes and adjust code to tackle conflicts. Backed out my
10713 code in Assign::Resolve ;-)
10715 2001-09-08 Ravi Pratap <ravi@ximian.com>
10717 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
10718 instead Report.Error and also pass in the location.
10719 (CSharpParser::Lexer): New readonly property to return the reference
10720 to the Tokenizer object.
10721 (declare_local_variables): Use Report.Error with location instead of plain
10725 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
10726 (Operator.CheckBinaryOperator): Ditto.
10728 * cs-parser.jay (operator_declarator): Update accordingly.
10730 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
10731 (CheckBinaryOperator): Same here.
10733 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
10734 on the name without any prefixes of namespace names etc. This is because we
10735 already might have something already fully qualified like
10736 'System.Console.WriteLine'
10738 * assign.cs (Resolve): Begin implementation. Stuck ;-)
10740 2001-09-07 Ravi Pratap <ravi@ximian.com>
10742 * cs-tokenizer.cs (location): Return a string which also contains
10745 * expression.cs (ElementAccess): New class for expressions of the
10746 type 'element access.'
10747 (BaseAccess): New class for expressions of the type 'base access.'
10748 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
10751 * cs-parser.jay (element_access): Implement action.
10752 (base_access): Implement actions.
10753 (checked_expression, unchecked_expression): Implement.
10755 * cs-parser.jay (local_variable_type): Correct and implement.
10756 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
10758 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
10760 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
10761 name and the specifiers.
10763 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
10765 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
10766 making them all public ;-)
10768 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
10771 2001-09-07 Miguel de Icaza <miguel@ximian.com>
10773 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
10775 (FieldExpr, PropertyExprs): New resolved expressions.
10776 (SimpleName::MemberStaticCheck): Perform static checks for access
10777 to non-static fields on static methods. Maybe this should be
10778 generalized for MemberAccesses.
10779 (SimpleName::ResolveSimpleName): More work on simple name
10782 * cs-parser.jay (primary_expression/qualified_identifier): track
10783 the parameter index.
10785 * codegen.cs (CodeGen::Save): Catch save exception, report error.
10786 (EmitContext::EmitBoolExpression): Chain to expression generation
10787 instead of temporary hack.
10788 (::EmitStatementExpression): Put generic expression code generation.
10790 * assign.cs (Assign::Emit): Implement variable assignments to
10791 local variables, parameters and fields.
10793 2001-09-06 Miguel de Icaza <miguel@ximian.com>
10795 * statement.cs (Block::GetVariableInfo): New method, returns the
10796 VariableInfo for a variable name in a block.
10797 (Block::GetVariableType): Implement in terms of GetVariableInfo
10799 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
10800 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
10802 2001-09-06 Ravi Pratap <ravi@ximian.com>
10804 * cs-parser.jay (operator_declaration): Continue on my quest : update
10805 to take attributes argument.
10806 (event_declaration): Ditto.
10807 (enum_declaration): Ditto.
10808 (indexer_declaration): Ditto.
10810 * class.cs (Operator::Operator): Update constructor accordingly.
10811 (Event::Event): Ditto.
10813 * delegate.cs (Delegate::Delegate): Same here.
10815 * enum.cs (Enum::Enum): Same here.
10817 2001-09-05 Ravi Pratap <ravi@ximian.com>
10819 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
10821 * ../tests/cs0658.cs : New file to demonstrate error 0658.
10823 * attribute.cs (Attributes): New class to encapsulate all attributes which were
10824 being passed around as an arraylist.
10825 (Attributes::AddAttribute): Method to add attribute sections.
10827 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
10828 (struct_declaration): Update accordingly.
10829 (constant_declaration): Update.
10830 (field_declaration): Update.
10831 (method_header): Update.
10832 (fixed_parameter): Update.
10833 (parameter_array): Ditto.
10834 (property_declaration): Ditto.
10835 (destructor_declaration): Ditto.
10837 * class.cs (Struct::Struct): Update constructors accordingly.
10838 (Class::Class): Ditto.
10839 (Field::Field): Ditto.
10840 (Method::Method): Ditto.
10841 (Property::Property): Ditto.
10842 (TypeContainer::OptAttribute): update property's return type.
10844 * interface.cs (Interface.opt_attributes): New member.
10845 (Interface::Interface): Update to take the extra Attributes argument.
10847 * parameter.cs (Parameter::Parameter): Ditto.
10849 * constant.cs (Constant::Constant): Ditto.
10851 * interface.cs (InterfaceMemberBase): New OptAttributes field.
10852 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
10853 the attributes as a parameter.
10854 (InterfaceProperty): Update constructor call.
10855 (InterfaceEvent): Ditto.
10856 (InterfaceMethod): Ditto.
10857 (InterfaceIndexer): Ditto.
10859 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
10860 pass the attributes too.
10861 (interface_event_declaration): Ditto.
10862 (interface_property_declaration): Ditto.
10863 (interface_method_declaration): Ditto.
10864 (interface_declaration): Ditto.
10866 2001-09-05 Miguel de Icaza <miguel@ximian.com>
10868 * class.cs (Method::Define): Track the "static Main" definition to
10869 create an entry point.
10871 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
10872 EntryPoint if we find it.
10874 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
10875 (EmitContext::ig): Make this variable public.
10877 * driver.cs: Make the default output file be the first file name
10878 with the .exe extension.
10880 Detect empty compilations
10882 Handle various kinds of output targets. Handle --target and
10883 rename -t to --dumper.
10885 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
10886 methods inherited from Expression return now an Expression. This
10887 will is used during the tree rewriting as we resolve them during
10890 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
10891 the spec. Missing entirely is the information about
10892 accessability of elements of it.
10894 (Expression::ExprClassFromMemberInfo): New constructor for
10895 Expressions that creates a fully initialized Expression based on
10896 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
10899 (Invocation::Resolve): Begin implementing resolution of invocations.
10901 * literal.cs (StringLiteral): Implement Emit.
10903 2001-09-05 Ravi Pratap <ravi@ximian.com>
10905 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
10908 2001-09-04 Ravi Pratap <ravi@ximian.com>
10910 * cs-parser.jay (attribute_arguments): Implement actions.
10911 (attribute): Fix bug in production. Implement action.
10912 (attribute_list): Implement.
10913 (attribute_target): Implement.
10914 (attribute_target_specifier, opt_target_specifier): Implement
10915 (CheckAttributeTarget): New method to check if the attribute target
10917 (attribute_section): Implement.
10918 (opt_attributes): Implement.
10920 * attribute.cs : New file to handle attributes.
10921 (Attribute): Class to hold attribute info.
10923 * cs-parser.jay (opt_attribute_target_specifier): Remove production
10924 (attribute_section): Modify production to use 2 different rules to
10925 achieve the same thing. 1 s/r conflict down !
10926 Clean out commented, useless, non-reducing dimension_separator rules.
10928 * class.cs (TypeContainer.attributes): New member to hold list
10929 of attributes for a type.
10930 (Struct::Struct): Modify to take one more argument, the attribute list.
10931 (Class::Class): Ditto.
10932 (Field::Field): Ditto.
10933 (Method::Method): Ditto.
10934 (Property::Property): Ditto.
10936 * cs-parser.jay (struct_declaration): Update constructor call to
10937 pass in the attributes too.
10938 (class_declaration): Ditto.
10939 (constant_declaration): Ditto.
10940 (field_declaration): Ditto.
10941 (method_header): Ditto.
10942 (fixed_parameter): Ditto.
10943 (parameter_array): Ditto.
10944 (property_declaration): Ditto.
10946 * constant.cs (Constant::Constant): Update constructor similarly.
10947 Use System.Collections.
10949 * parameter.cs (Parameter::Parameter): Update as above.
10951 2001-09-02 Ravi Pratap <ravi@ximian.com>
10953 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
10954 (TypeContainer.delegates): New member to hold list of delegates.
10956 * cs-parser.jay (delegate_declaration): Implement the action correctly
10957 this time as I seem to be on crack ;-)
10959 2001-09-02 Miguel de Icaza <miguel@ximian.com>
10961 * rootcontext.cs (RootContext::IsNamespace): new function, used to
10962 tell whether an identifier represents a namespace.
10964 * expression.cs (NamespaceExpr): A namespace expression, used only
10965 temporarly during expression resolution.
10966 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
10967 utility functions to resolve names on expressions.
10969 2001-09-01 Miguel de Icaza <miguel@ximian.com>
10971 * codegen.cs: Add hook for StatementExpressions.
10973 * class.cs: Fix inverted test for static flag in methods.
10975 2001-09-02 Ravi Pratap <ravi@ximian.com>
10977 * class.cs (Operator::CheckUnaryOperator): Correct error number used
10978 to make it coincide with MS' number.
10979 (Operator::CheckBinaryOperator): Ditto.
10981 * ../errors/errors.txt : Remove error numbers added earlier.
10983 * ../errors/cs1019.cs : Test case for error # 1019
10985 * ../errros/cs1020.cs : Test case for error # 1020
10987 * cs-parser.jay : Clean out commented cruft.
10988 (dimension_separators, dimension_separator): Comment out. Ostensibly not
10989 used anywhere - non-reducing rule.
10990 (namespace_declarations): Non-reducing rule - comment out.
10992 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
10993 with TypeContainer::AddEnum.
10995 * delegate.cs : New file for delegate handling classes.
10996 (Delegate): Class for declaring delegates.
10998 * makefile : Update.
11000 * cs-parser.jay (delegate_declaration): Implement.
11002 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
11004 * class.cs (Event::Define): Implement.
11005 (Event.EventBuilder): New member.
11007 * class.cs (TypeContainer::Populate): Update to define all enums and events
11009 (Events): New property for the events arraylist we hold. Shouldn't we move to using
11010 readonly fields for all these cases ?
11012 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
11014 * class.cs (Property): Revamp to use the convention of making fields readonly.
11015 Accordingly modify code elsewhere.
11017 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
11018 the Define method of the Property class.
11020 * class.cs : Clean up applied patch and update references to variables etc. Fix
11022 (TypeContainer::Populate): Update to define all the properties we have. Also
11023 define all enumerations.
11025 * enum.cs (Define): Implement.
11027 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
11029 * cs-parser.jay (overloadable_operator): The semantic value is an
11030 enum of the Operator class.
11031 (operator_declarator): Implement actions.
11032 (operator_declaration): Implement.
11034 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
11035 validity of definitions.
11036 (Operator::CheckBinaryOperator): Static method to check for binary operators
11037 (TypeContainer::AddOperator): New method to add an operator to a type.
11039 * cs-parser.jay (indexer_declaration): Added line to actually call the
11040 AddIndexer method so it gets added ;-)
11042 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
11043 already taken care of by the MS compiler ?
11045 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
11047 * class.cs (Operator): New class for operator declarations.
11048 (Operator::OpType): Enum for the various operators.
11050 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
11052 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
11053 ostensibly handle this in semantic analysis.
11055 * cs-parser.jay (general_catch_clause): Comment out
11056 (specific_catch_clauses, specific_catch_clause): Ditto.
11057 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
11058 (catch_args, opt_catch_args): New productions.
11059 (catch_clause): Rewrite to use the new productions above
11060 (catch_clauses): Modify accordingly.
11061 (opt_catch_clauses): New production to use in try_statement
11062 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
11063 and re-write the code in the actions to extract the specific and
11064 general catch clauses by being a little smart ;-)
11066 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
11067 Hooray, try and catch statements parse fine !
11069 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
11071 * statement.cs (Block::GetVariableType): Fix logic to extract the type
11072 string from the hashtable of variables.
11074 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
11075 I end up making that mistake ;-)
11076 (catch_clauses): Fixed gross error which made Key and Value of the
11077 DictionaryEntry the same : $1 !!
11079 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
11081 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
11083 * cs-parser.jay (event_declaration): Correct to remove the semicolon
11084 when the add and remove accessors are specified.
11086 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
11088 * cs-parser.jay (IndexerDeclaration): New helper class to hold
11089 information about indexer_declarator.
11090 (indexer_declarator): Implement actions.
11091 (parsing_indexer): New local boolean used to keep track of whether
11092 we are parsing indexers or properties. This is necessary because
11093 implicit_parameters come into picture even for the get accessor in the
11094 case of an indexer.
11095 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
11097 * class.cs (Indexer): New class for indexer declarations.
11098 (TypeContainer::AddIndexer): New method to add an indexer to a type.
11099 (TypeContainer::indexers): New member to hold list of indexers for the
11102 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
11104 * cs-parser.jay (add_accessor_declaration): Implement action.
11105 (remove_accessor_declaration): Implement action.
11106 (event_accessors_declaration): Implement
11107 (variable_declarators): swap statements for first rule - trivial.
11109 * class.cs (Event): New class to hold information about event
11111 (TypeContainer::AddEvent): New method to add an event to a type
11112 (TypeContainer::events): New member to hold list of events.
11114 * cs-parser.jay (event_declaration): Implement actions.
11116 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
11118 * cs-parser.jay (dim_separators): Implement. Make it a string
11119 concatenating all the commas together, just as they appear.
11120 (opt_dim_separators): Modify accordingly
11121 (rank_specifiers): Update accordingly. Basically do the same
11122 thing - instead, collect the brackets here.
11123 (opt_rank_sepcifiers): Modify accordingly.
11124 (array_type): Modify to actually return the complete type string
11125 instead of ignoring the rank_specifiers.
11126 (expression_list): Implement to collect the expressions
11127 (variable_initializer): Implement. We make it a list of expressions
11128 essentially so that we can handle the array_initializer case neatly too.
11129 (variable_initializer_list): Implement.
11130 (array_initializer): Make it a list of variable_initializers
11131 (opt_array_initializer): Modify accordingly.
11133 * expression.cs (New::NType): Add enumeration to help us
11134 keep track of whether we have an object/delegate creation
11135 or an array creation.
11136 (New:NewType, New::Rank, New::Indices, New::Initializers): New
11137 members to hold data about array creation.
11138 (New:New): Modify to update NewType
11139 (New:New): New Overloaded contructor for the array creation
11142 * cs-parser.jay (array_creation_expression): Implement to call
11143 the overloaded New constructor.
11145 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
11147 * class.cs (TypeContainer::Constructors): Return member
11148 constructors instead of returning null.
11150 2001-08-26 Miguel de Icaza <miguel@ximian.com>
11152 * typemanager.cs (InitCoreTypes): Initialize the various core
11153 types after we have populated the type manager with the user
11154 defined types (this distinction will be important later while
11155 compiling corlib.dll)
11157 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
11158 on Expression Classification. Now all expressions have a method
11159 `Resolve' and a method `Emit'.
11161 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
11162 generation from working. Also add some temporary debugging
11165 2001-08-24 Miguel de Icaza <miguel@ximian.com>
11167 * codegen.cs: Lots of code generation pieces. This is only the
11168 beginning, will continue tomorrow with more touches of polish. We
11169 handle the fundamentals of if, while, do, for, return. Others are
11170 trickier and I need to start working on invocations soon.
11172 * gen-treedump.cs: Bug fix, use s.Increment here instead of
11175 * codegen.cs (EmitContext): New struct, used during code
11176 emission to keep a context. Most of the code generation will be
11179 * cs-parser.jay: Add embedded blocks to the list of statements of
11180 this block. So code generation proceeds in a top down fashion.
11182 2001-08-23 Miguel de Icaza <miguel@ximian.com>
11184 * statement.cs: Add support for multiple child blocks.
11186 2001-08-22 Miguel de Icaza <miguel@ximian.com>
11188 * codegen.cs (EmitCode): New function, will emit the code for a
11189 Block of code given a TypeContainer and its ILGenerator.
11191 * statement.cs (Block): Standard public readonly optimization.
11192 (Block::Block constructors): Link children.
11193 (Block::Child): Child Linker.
11194 (Block::EmitVariables): Emits IL variable declarations.
11196 * class.cs: Drop support for MethodGroups here, delay until
11198 (Method::): Applied the same simplification that I did before, and
11199 move from Properties to public readonly fields.
11200 (Method::ParameterTypes): Returns the parameter types for the
11201 function, and implements a cache that will be useful later when I
11202 do error checking and the semantic analysis on the methods is
11204 (Constructor::GetCallingConvention): Renamed from CallingConvetion
11205 and made a method, optional argument tells whether this is a class
11206 or a structure to apply the `has-this' bit.
11207 (Method::GetCallingConvention): Implement, returns the calling
11209 (Method::Define): Defines the type, a second pass is performed
11210 later to populate the methods.
11212 (Constructor::ParameterTypes): implement a cache similar to the
11213 one on Method::ParameterTypes, useful later when we do semantic
11216 (TypeContainer::EmitMethod): New method. Emits methods.
11218 * expression.cs: Removed MethodGroup class from here.
11220 * parameter.cs (Parameters::GetCallingConvention): new method.
11222 2001-08-21 Miguel de Icaza <miguel@ximian.com>
11224 * class.cs (TypeContainer::Populate): Drop RootContext from the
11227 (Constructor::CallingConvention): Returns the calling convention.
11228 (Constructor::ParameterTypes): Returns the constructor parameter
11231 (TypeContainer::AddConstructor): Keep track of default constructor
11232 and the default static constructor.
11234 (Constructor::) Another class that starts using `public readonly'
11235 instead of properties.
11237 (Constructor::IsDefault): Whether this is a default constructor.
11239 (Field::) use readonly public fields instead of properties also.
11241 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
11242 track of static constructors; If none is used, turn on
11243 BeforeFieldInit in the TypeAttributes.
11245 * cs-parser.jay (opt_argument_list): now the return can be null
11246 for the cases where there are no arguments.
11248 (constructor_declarator): If there is no implicit `base' or
11249 `this', then invoke the default parent constructor.
11251 * modifiers.cs (MethodAttr): New static function maps a set of
11252 modifiers flags into a MethodAttributes enum
11253 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
11254 MethodAttr, TypeAttr to represent the various mappings where the
11255 modifiers are used.
11256 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
11258 2001-08-19 Miguel de Icaza <miguel@ximian.com>
11260 * parameter.cs (GetParameterInfo): Fix bug where there would be no
11263 * interface.cs (PopulateIndexer): Implemented the code generator
11264 for interface indexers.
11266 2001-08-17 Miguel de Icaza <miguel@ximian.com>
11268 * interface.cs (InterfaceMemberBase): Now we track the new status
11271 (PopulateProperty): Implement property population. Woohoo! Got
11272 Methods and Properties going today.
11274 Removed all the properties for interfaces, and replaced them with
11275 `public readonly' fields.
11277 2001-08-16 Miguel de Icaza <miguel@ximian.com>
11279 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
11280 initialize their hashtables/arraylists only when they are needed
11281 instead of doing this always.
11283 * parameter.cs: Handle refs and out parameters.
11285 * cs-parser.jay: Use an ArrayList to construct the arguments
11286 instead of the ParameterCollection, and then cast that to a
11289 * parameter.cs: Drop the use of ParameterCollection and use
11290 instead arrays of Parameters.
11292 (GetParameterInfo): Use the Type, not the Name when resolving
11295 2001-08-13 Miguel de Icaza <miguel@ximian.com>
11297 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
11298 and instead use public readonly fields.
11300 * class.cs: Put back walking code for type containers.
11302 2001-08-11 Miguel de Icaza <miguel@ximian.com>
11304 * class.cs (MakeConstant): Code to define constants.
11306 * rootcontext.cs (LookupType): New function. Used to locate types
11309 2001-08-08 Miguel de Icaza <miguel@ximian.com>
11311 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
11312 this System.Reflection code is. Kudos to Microsoft
11314 * typemanager.cs: Implement a type cache and avoid loading all
11315 types at boot time. Wrap in LookupType the internals. This made
11316 the compiler so much faster. Wow. I rule!
11318 * driver.cs: Make sure we always load mscorlib first (for
11319 debugging purposes, nothing really important).
11321 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
11322 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
11324 * rootcontext.cs: Lookup types on their namespace; Lookup types
11325 on namespaces that have been imported using the `using' keyword.
11327 * class.cs (TypeContainer::TypeAttr): Virtualize.
11328 (Class::TypeAttr): Return attributes suitable for this bad boy.
11329 (Struct::TypeAttr): ditto.
11330 Handle nested classes.
11331 (TypeContainer::) Remove all the type visiting code, it is now
11332 replaced with the rootcontext.cs code
11334 * rootcontext.cs (GetClassBases): Added support for structs.
11336 2001-08-06 Miguel de Icaza <miguel@ximian.com>
11338 * interface.cs, statement.cs, class.cs, parameter.cs,
11339 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
11340 Drop use of TypeRefs, and use strings instead.
11342 2001-08-04 Miguel de Icaza <miguel@ximian.com>
11346 * class.cs (Struct::Struct): set the SEALED flags after
11347 checking the modifiers.
11348 (TypeContainer::TypeAttr): new property, returns the
11349 TypeAttributes for a class.
11351 * cs-parser.jay (type_list): Oops, list production was creating a
11352 new list of base types.
11354 * rootcontext.cs (StdLib): New property.
11355 (GetInterfaceTypeByName): returns an interface by type name, and
11356 encapsulates error handling here.
11357 (GetInterfaces): simplified.
11358 (ResolveTree): Encapsulated all the tree resolution here.
11359 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
11362 * driver.cs: Add support for --nostdlib, to avoid loading the
11363 default assemblies.
11364 (Main): Do not put tree resolution here.
11366 * rootcontext.cs: Beginning of the class resolution.
11368 2001-08-03 Miguel de Icaza <miguel@ximian.com>
11370 * rootcontext.cs: Provide better error reporting.
11372 * cs-parser.jay (interface_base): set our $$ to be interfaces.
11374 * rootcontext.cs (CreateInterface): Handle the case where there
11375 are no parent interfaces.
11377 (CloseTypes): Routine to flush types at the end.
11378 (CreateInterface): Track types.
11379 (GetInterfaces): Returns an array of Types from the list of
11380 defined interfaces.
11382 * typemanager.c (AddUserType): Mechanism to track user types (puts
11383 the type on the global type hash, and allows us to close it at the
11386 2001-08-02 Miguel de Icaza <miguel@ximian.com>
11388 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
11389 RecordInterface instead.
11391 * cs-parser.jay: Updated to reflect changes above.
11393 * decl.cs (Definition): Keep track of the TypeBuilder type that
11394 represents this type here. Not sure we will use it in the long
11395 run, but wont hurt for now.
11397 * driver.cs: Smaller changes to accomodate the new code.
11399 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
11402 * rootcontext.cs (CreateInterface): New method, used to create
11403 the System.TypeBuilder type for interfaces.
11404 (ResolveInterfaces): new entry point to resolve the interface
11406 (CodeGen): Property, used to keep track of the code generator.
11408 2001-07-26 Miguel de Icaza <miguel@ximian.com>
11410 * cs-parser.jay: Add a second production for delegate_declaration
11413 (enum_body): Put an opt_comma here instead of putting it on
11414 enum_body or enum_member_declarations so we can handle trailing
11415 commas on enumeration members. Gets rid of a shift/reduce.
11417 (type_list): Need a COMMA in the middle.
11419 (indexer_declaration): Tell tokenizer to recognize get/set
11421 * Remove old targets.
11423 * Re-add the parser target.
11425 2001-07-13 Simon Cozens <simon@simon-cozens.org>
11427 * cs-parser.jay: Add precendence rules for a number of operators
11428 ot reduce the number of shift/reduce conflicts in the grammar.
11430 2001-07-17 Miguel de Icaza <miguel@ximian.com>
11432 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
11435 Get rid of old crufty code.
11437 * rootcontext.cs: Use this to keep track of the parsed
11438 representation and the defined types available to the program.
11440 * gen-treedump.cs: adjust for new convention.
11442 * type.cs: Split out the type manager, and the assembly builder
11445 * typemanager.cs: the type manager will live here now.
11447 * cil-codegen.cs: And the code generator here.
11449 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
11451 * makefile: Fixed up for easy making.
11453 2001-07-13 Simon Cozens <simon@simon-cozens.org>
11455 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
11458 (unary_expression): Expand pre_increment_expression and
11459 post_decrement_expression to reduce a shift/reduce.
11461 2001-07-11 Simon Cozens
11463 * cs-tokenizer.cs: Hex numbers should begin with a 0.
11465 Improve allow_keyword_as_indent name.
11467 2001-06-19 Miguel de Icaza <miguel@ximian.com>
11469 * Adjustments for Beta2.
11471 2001-06-13 Miguel de Icaza <miguel@ximian.com>
11473 * decl.cs: Added `Define' abstract method.
11474 (InTransit): new property, used to catch recursive definitions.
11476 * interface.cs: Implement `Define'.
11478 * modifiers.cs: Map Modifiers.constants to
11479 System.Reflection.TypeAttribute flags.
11481 * class.cs: Keep track of types and user-defined types.
11482 (BuilderInit): New method for creating an assembly
11483 (ResolveType): New function to launch the resolution process, only
11484 used by interfaces for now.
11486 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
11487 that are inserted into the name space.
11489 2001-06-08 Miguel de Icaza <miguel@ximian.com>
11491 * ARGH. I have screwed up my tree so many times due to the use of
11492 rsync rather than using CVS. Going to fix this at once.
11494 * driver.cs: Objetify driver. Load assemblies, use assemblies to
11497 2001-06-07 Miguel de Icaza <miguel@ximian.com>
11499 * Experiment successful: Use System.Type rather that our own
11502 2001-05-25 Miguel de Icaza <miguel@ximian.com>
11504 * cs-parser.jay: Removed nsAliases from here.
11506 Use new namespaces, handle `using XXX;'
11508 * namespace.cs: Reimplemented namespace handling, use a recursive
11509 definition of the class. Now we can keep track of using clauses
11510 and catch invalid using clauses.
11512 2001-05-24 Miguel de Icaza <miguel@ximian.com>
11514 * gen-treedump.cs: Adapted for all the renaming.
11516 * expression.cs (Expression): this class now has a Type property
11517 which returns an expression Type.
11519 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
11520 `Type', as this has a different meaning now in the base
11522 2001-05-22 Miguel de Icaza <miguel@ximian.com>
11524 * interface.cs, class.cs: Removed from all the sources the
11525 references to signature computation, as we can not do method
11526 signature computation during the parsing time, as we are not
11527 trying to solve at that point distinguishing:
11531 void a (NS.Blah x) {}
11534 Which depending on the context might be valid or not, as we do not
11535 know if Blah is the same thing as NS.Blah at that point.
11537 * Redid everything so the code uses TypeRefs now instead of
11538 Types. TypeRefs are just temporary type placeholders, that need
11539 to be resolved. They initially have a pointer to a string and the
11540 current scope in which they are used. This is used later by the
11541 compiler to resolve the reference to an actual Type.
11543 * DeclSpace is no longer a CIR.Type, and neither are
11544 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
11545 are all DeclSpaces, but no Types.
11547 * type.cs (TypeRefManager): This implements the TypeRef manager,
11548 which keeps track of all the types that need to be resolved after
11549 the parsing has finished.
11551 2001-05-13 Miguel de Icaza <miguel@ximian.com>
11553 * ARGH. We are going to have to store `foreach' as a class rather
11554 than resolving it, as we need to verify error 1579 after name
11555 resolution. *OR* we could keep a flag that says `This request to
11556 IEnumerator comes from a foreach statement' which we can then use
11557 to generate the error.
11559 2001-05-10 Miguel de Icaza <miguel@ximian.com>
11561 * class.cs (TypeContainer.AddMethod): we now add methods to the
11562 MethodGroup instead of the method hashtable.
11564 * expression.cs: Add MethodGroup abstraction, which gets us one
11565 step closer to the specification in the way we handle method
11568 * cs-parser.jay (primary_expression): qualified_identifier now
11569 tried to match up an identifier to a local variable reference or
11570 to a parameter reference.
11572 current_local_parameters is now a parser global variable that
11573 points to the current parameters for the block, used during name
11576 (property_declaration): Now creates an implicit `value' argument to
11579 2001-05-09 Miguel de Icaza <miguel@ximian.com>
11581 * parameter.cs: Do not use `param' arguments as part of the
11582 signature, per the spec.
11584 2001-05-08 Miguel de Icaza <miguel@ximian.com>
11586 * decl.cs: Base class for classes, structs and interfaces. This
11587 is the "Declaration Space"
11589 * cs-parser.jay: Use CheckDef for checking declaration errors
11590 instead of having one on each function.
11592 * class.cs: Factor out some code for handling error handling in
11593 accordance to the "Declarations" section in the "Basic Concepts"
11594 chapter in the ECMA C# spec.
11596 * interface.cs: Make all interface member classes derive from
11597 InterfaceMemberBase.
11599 2001-05-07 Miguel de Icaza <miguel@ximian.com>
11601 * Many things: all interfaces are parsed and generated in
11602 gen-treedump. Support for member variables, constructors,
11603 destructors, properties, constants is there.
11605 Beginning of the IL backend, but very little done, just there for
11608 2001-04-29 Miguel de Icaza <miguel@ximian.com>
11610 * cs-parser.jay: Fix labeled statement.
11612 * cs-tokenizer.cs (escape): Escape " and ' always.
11613 ref_line, ref_name: keep track of the line/filename as instructed
11614 by #line by the compiler.
11617 2001-04-27 Miguel de Icaza <miguel@ximian.com>
11619 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
11620 to match the values in System.CodeDOM.
11622 Divid renamed to Divide.
11624 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
11626 (Statements.set): remove.
11628 * System.CodeDOM/CodeCatchClause.cs: always have a valid
11631 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
11632 falseStatements always have valid values.
11634 * cs-parser.jay: Use System.CodeDOM now.