1 2008-04-22 Marek Safar <marek.safar@gmail.com>
3 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
5 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
8 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
9 needing final 'ret' instruction.
11 2008-04-22 Marek Safar <marek.safar@gmail.com>
13 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
15 2008-04-21 Marek Safar <marek.safar@gmail.com>
17 * expression.cs: Emit ldnull and not null expression as an instance argument
18 of static method expression calls.
20 2008-04-21 Marek Safar <marek.safar@gmail.com>
23 * expression.cs: Fixed crash when creating parameterless expression tree
26 2008-04-21 Marek Safar <marek.safar@gmail.com>
29 * anonymous.cs: Fixed crash when inferring from null argument anonymous
32 2008-04-21 Marek Safar <marek.safar@gmail.com>
35 * decl.cs, class.cs: Emit delegate type argument attributes.
37 2008-04-21 Marek Safar <marek.safar@gmail.com>
40 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
42 2008-04-21 Marek Safar <marek.safar@gmail.com>
44 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
47 2008-04-21 Marek Safar <marek.safar@gmail.com>
49 * generic.cs (TypeParameter): Removed redundant location.
51 2008-04-19 Marek Safar <marek.safar@gmail.com>
53 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
54 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
55 FullNamedExpression in all declaration type expression, statements will come
58 2008-04-18 Marek Safar <marek.safar@gmail.com>
60 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
61 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
63 2008-04-18 Marek Safar <marek.safar@gmail.com>
65 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
68 2008-04-17 Marek Safar <marek.safar@gmail.com>
70 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
73 2008-04-17 Marek Safar <marek.safar@gmail.com>
75 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
79 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
81 Hook up 'EmitSideEffect'
82 * constant.cs (Constant.EmitSideEffect): New.
83 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
84 (SideEffectConstant.EmitSideEffect): New.
85 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
86 unconditional branch in EmitBranchable.
87 (FieldExpr.EmitBranchable): New.
88 * expression.cs (Unary.EmitSideEffect): New.
89 (Binary.EmitSideEffect): New.
90 (VariableReference.EmitSideEffect): New. Do nothing.
92 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
94 Introduce 'EmitSideEffect'
95 * ecore.cs (Expression.EmitSideEffect): New.
96 (TypeCast): Rename from EmptyCast.
98 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
99 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
100 * convert.cs, nullable.cs: Update to changes.
102 2008-04-16 Marek Safar <marek.safar@gmail.com>
104 * class.cs, cs-parser.jay: Early check for base types expression.
106 2008-04-16 Marek Safar <marek.safar@gmail.com>
108 * decl.cs (MemberName): Declare PrettyName as obsolete.
110 2008-04-16 Marek Safar <marek.safar@gmail.com>
112 * namespace.cs: Use MemberName comparison.
114 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
117 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
119 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
120 (MemberName.FullyQualifiedName): New. Provides the functionality
121 that users assume FullName would have.
122 * ecore.cs, namespace.cs: Update to changes.
124 * statement.cs (Using.assign): Make into ExpressionStatement.
125 (Using.EmitPreTryBody): Simplify.
127 2008-04-16 Marek Safar <marek.safar@gmail.com>
129 * report.cs: ColorFormat is protected.
131 * rootcontext.cs: Unused fields clean-up.
133 * namespace.cs: Made UsingEntry name private.
135 2008-04-16 Marek Safar <marek.safar@gmail.com>
137 * cs-tokenizer.cs, location.cs: Removed unused field.
139 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
140 Raja R Harinath <harinath@hurrynot.org>
143 * constant.cs (SideEffectConstant.value): Rename from 'left'.
144 (SideEffectConstant.side_effect): Rename from 'right'.
145 (SideEffectConstant..ctor): Normalize 'side_effect'.
146 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
147 value of this constant.
148 * cfold.cs: Update to changes.
150 2008-04-15 Marek Safar <marek.safar@gmail.com>
152 * cs-paser.jay: Removed unused variable.
154 * driver.cs: Made Compile instance method.
156 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
158 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
160 2008-04-15 Marek Safar <marek.safar@gmail.com>
162 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
164 2008-04-13 Jb Evain <jbevain@novell.com>
166 * namespace.cs: update the System.Core fullname for 2.1
167 * driver.cs: update the list of required assemblies for 2.1.
168 Merged from the Moonlight 2 branch.
170 2008-04-11 Marek Safar <marek.safar@gmail.com>
172 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
173 types and user defined operators. User operators arguments has to be checked
174 for null value before invocation, which also means no operator is called
175 when any argument is not convertible to unwrapped nullable type.
177 2008-04-09 Marek Safar <marek.safar@gmail.com>
179 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
180 of Unary expressions to follow operator overloading rules precisely.
181 Also fixes #321794, #323794
183 2008-04-08 Marek Safar <marek.safar@gmail.com>
185 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
188 2008-04-08 Marek Safar <marek.safar@gmail.com>
190 * expression.cs, ecore.cs: Implemented MemberInit expression.
192 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
194 Fix mono/tests/exception4.cs
195 * statement.cs (ExceptionStatement, TryCatch): Revert to using
196 ec.NeedReturnLabel () rather emitting a 'nop'.
198 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
200 (TryCatch.SomeCodeFollows): Likewise.
201 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
202 for 'break', 'continue' and 'return' statements inside a try.
203 We're fairly sure that the generated IL stream will have more
204 instructions textually following the try.
205 (FlowBranchingTryCatch): Likewise.
207 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
208 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
211 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
212 wrapper -- forward everything to CollectionForeach.
213 (CollectionForeach.NonDisposableWrapper): New.
214 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
215 instead of a pop + branch to end.
217 2008-04-07 Marek Safar <marek.safar@gmail.com>
219 A fix for bug #377485
220 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
221 Propagate location for extension method groups. Report conversion failure at
224 2008-04-07 Marek Safar <marek.safar@gmail.com>
226 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
227 ListInit and Field expressions.
229 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
231 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
232 Since $PC is always -1 inside the body of MoveNext, the fault
234 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
235 * statement.cs (ExceptionStatement.emit_finally): Likewise.
236 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
238 The denouement! Fix #324708
239 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
240 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
241 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
242 'finally' inside the finally clause.
244 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
245 inside an iterator. Don't emit the body of the 'finally' inside
246 the finally clause yet.
248 Use the ResumableStatement infrastructure for MoveNext ()
249 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
250 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
251 'old_resume_points'. Move dispatcher upfront.
252 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
253 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
254 in an enumerator. This encodes the main fix in this patch series
255 -- we can only jump into the first instruction of a try from the
256 outside, but we want to emit try/finally regions in iterators and
257 resume in the middle of them.
259 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
261 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
262 of NeedReturnLabel here.
264 Introduce a common point for emitting try/finally to IL
265 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
266 features of the various subclasses, which are now driven by ...
267 (ExceptionStatement.EmitPreTryBody): ... this and ...
268 (ExceptionStatement.EmitTryBody): ... this and the original
270 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
271 Remove DoEmit and update to follow above protocol.
273 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
274 of the dispatcher are the same, skip emitting the 'switch'.
275 * iterator.cs (Iterator.EmitDispose): Update to changes.
277 Clean up handling of 'using' statement
278 * statement.cs (UsingTemporary): New. Carved out of ...
279 (Using): ... this. Simplify drastically. Handle exactly
281 * cs-parser.jay (using_statement): Split. Create UsingTemporary
282 or Using as appropriate. If there are multiple variable declared,
283 create nested Using statements.
284 (resource_acquisition): Kill.
286 * statement.cs (ExceptionStatement.EmitForDispose): Use
287 EmitFinallyBody, not EmitFinally.
289 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
290 * iterator.cs: Update to changes.
292 Start using the ResumableStatement infrastructure
293 * statement.cs (ResumeableStatement.PrepareForDispose): New.
294 (ResumableStatement.EmitForDispose): New.
295 (ExceptionStatement): Override them.
296 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
297 EmitForDispose to create the body of the Dispose method. Don't
300 * iterator.cs (Iterator.AddResumePoint): Move here from ...
301 * statement.cs (Toplevel.AddResumePoint): ... here.
302 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
303 * flowanalysis.cs (FlowBranchingIterator): New.
304 * codegen.cs (EmitContext): Update to changes.
306 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
307 (Iterator.old_resume_points): Rename from 'resume_points'.
308 (Iterator.MoveNextStatement): Remove unused class.
310 New infrastructure for try/finally in iterators (still unused)
311 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
312 (FlowBranchingToplevel.AddResumePoint): Hook into
313 ToplevelBlock.AddResumePoint.
314 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
315 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
316 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
317 resume points and assign program-counter values.
318 (ExceptionBlock.AddResumePoint): Collect resume points for
319 de-muxer at the top of try block.
320 * iterators.cs (Yield.CheckContext): Simplify.
321 (Yield.Resolve): Use FlowBranching.AddResumePoint.
323 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
325 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
326 argument to an ExitStatement.
327 (FlowBranchingException): Refactor saved origins code.
328 * statement.cs (ExitStatement): Update to cahges.
329 * iterator.cs (YieldBreak): Likewise.
331 * statement.cs (ResumableStatement): New. Common base class for
332 YieldReturn and ExceptionStatement.
333 (ExitStatement): New. Common base class for Return and YieldBreak.
334 (Return): Update to changes.
335 * iterator.cs (YieldBreak): Likewise.
336 * lambda.cs (ContextualReturn): Likewise.
339 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
340 emit a meaningful error message.
343 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
344 (VariableInfo.SetAssigned): Set it.
345 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
346 determine if CS0219 or CS0168 is appropriate. Don't use
347 flow-analysis information.
348 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
349 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
350 (EmitContext.EndFlowBranching): ... this.
352 2008-04-03 Marek Safar <marek.safar@gmail.com>
354 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
356 2008-04-03 Marek Safar <marek.safar@gmail.com>
358 A fix for bug #376508
359 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
360 ImplicitConversionExists.
362 2008-04-03 Marek Safar <marek.safar@gmail.com>
364 * expression.cs (Binary): Added remaining binary operators to expression
367 * nullable.cs: Optimize shift with null argument.
369 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
371 Fix minor IL regression
372 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
373 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
374 * cs-parser.jay (try_statement): Update to changes.
376 * statement.cs (TryFinally.need_exc_block): Delete.
377 (TryFinally): Update to changes.
379 Now all ExceptionStatements are unconditional
380 * statement.cs (CollectionForeach.DisposableWrapper): New.
381 Extract out the try/finally code into a new wrapper.
382 (CollectionForeach.Resolve): Use it to simplify the code.
384 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
386 Start at simplifying ExceptionStatement semantics a bit
387 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
388 * cs-parser.jay (try_statement): Update to changes.
389 (opt_catch_clauses): Remove.
390 * flowanalysis.cs: Update to changes.
391 (FlowBranching.BranchingType.TryCatch): New.
392 (FlowBranchingTryCatch): New.
394 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
395 (FlowBranching.CreateBranching): Update to changes.
396 (FlowBranchingBlock.AddSibling): Add sanity check.
397 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
400 * iterators.cs (Iterator.MarkFinally): Remove.
401 * statement.cs (ExceptionStatement): Update to changes.
403 Add support for skipping over finally blocks at runtime. First
404 in a series to fix #324708
405 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
406 (Iterator.EmitMoveNext): Initialize it.
407 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
408 branch over the body of the 'finally' clause.
410 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
412 Avoid lopsided use of Foo/DoFoo names
413 * statement.cs (ExpressionStatement.EmitFinallyBody):
414 Rename from EmitFinally.
415 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
416 * iterator.cs: Update to changes.
418 2008-04-02 Marek Safar <marek.safar@gmail.com>
420 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
421 based on UserOperatorCall. More binary nullable operators clean up.
423 2008-04-02 Martin Baulig <martin@ximian.com>
425 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
427 2008-04-02 Marek Safar <marek.safar@gmail.com>
429 * nullable.cs: Merge user and empty conversions when lifting expression
432 * expression.cs (StringConcat): Implemented expression tree representation.
434 2008-04-01 Marek Safar <marek.safar@gmail.com>
436 * nullable.cs: When lifting null literal and a user operator exists, no call
439 2008-04-01 Marek Safar <marek.safar@gmail.com>
441 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
444 2008-04-01 Marek Safar <marek.safar@gmail.com>
446 * nullable.cs, expression.cs: Use namespace instead heavily nested
447 monster abstract class.
449 2008-04-01 Marek Safar <marek.safar@gmail.com>
451 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
452 lifting of null literal and user operators. Clean up of some temporary
455 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
457 Fix #368224, test-629.cs
458 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
459 if it crossed an unwind-protect boundary.
460 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
461 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
462 inside an unwind-protected region.
463 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
464 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
465 'leave' instead of a 'br' if unwind-protected.
466 (Iterator.EmitYieldBreak): Likewise.
468 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
470 * driver.cs: Only define versioninfo resources if no win32 resource
473 2008-03-28 Marek Safar <marek.safar@gmail.com>
475 A fix for bug #372375
476 * convert.cs: Fixed boxing of nullable types.
478 2008-03-28 Marek Safar <marek.safar@gmail.com>
480 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
483 2008-03-28 Marek Safar <marek.safar@gmail.com>
485 A fix for bug #374619
486 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
488 2008-03-27 Marek Safar <marek.safar@gmail.com>
490 * lambda.cs: Check return type only for invocation.
492 2008-03-27 Marek Safar <marek.safar@gmail.com>
494 A fix for bug #374214
495 * ecore.cs: Correctly report argument type mismatch.
497 2008-03-27 Marek Safar <marek.safar@gmail.com>
499 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
500 and not rely on broken IsEnum.
502 2008-03-27 Marek Safar <marek.safar@gmail.com>
504 * nullable.cs: New file, extracted from generic.cs.
506 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
508 2008-03-27 Marek Safar <marek.safar@gmail.com>
510 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
511 predefined comparison operators and null literals.
513 * report.cs: New warning ID.
515 2008-03-25 Marek Safar <marek.safar@gmail.com>
517 A fix for bug #370577
518 * lambda.cs: Check return type too.
520 2008-03-25 Marek Safar <marek.safar@gmail.com>
522 A fix for bug #372846
523 * class.cs: Automatic properties can be declared as unsafe.
525 2008-03-20 Marek Safar <marek.safar@gmail.com>
527 * location.cs: Use string based concatenation.
529 * expression.cs: LiftedBinaryOperator is gmcs only.
531 2008-03-20 Marek Safar <marek.safar@gmail.com>
533 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
534 conversions rules and expression trees.
536 2008-03-19 Marek Safar <marek.safar@gmail.com>
538 * delegate.cs: Use extension method source as delegate target.
540 2008-03-19 Marek Safar <marek.safar@gmail.com>
542 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
543 binary operations to be purely based on binary operations and optimized
544 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
545 and other ET refactoring.
547 * typemanager.cs: Fixed warning.
549 2008-03-17 Marek Safar <marek.safar@gmail.com>
551 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
553 * symbolwriter.cs: Fixed.
555 2008-03-17 Marek Safar <marek.safar@gmail.com>
557 * anonymous.cs, driver.cs: Reset anonymous types counters.
559 2008-03-17 Marek Safar <marek.safar@gmail.com>
561 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
563 * class.cs: Use fullname for all type member definitions.
565 2008-02-19 Martin Baulig <martin@ximian.com>
568 (IMethodData.EmitExtraSymbolInfo): New interface method.
569 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
570 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
571 interface method here as an empty public virtual method.
574 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
575 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
576 CodeGen.SymbolWriter.SetRealMethodName().
578 2008-02-18 Martin Baulig <martin@ximian.com>
581 (ScopeInfo.EmitType): Override this and emit debugging
582 information for captured variables.
583 (RootScopeInfo.EmitType): Override this and emit symbol
584 information for a captured `this'.
586 2008-02-15 Martin Baulig <martin@ximian.com>
588 * iterators.cs: Emit debugging info.
591 (EmitContext.Flags): Add `OmitDebuggingInfo'.
592 (EmitContext.OmitDebuggingInfo): New public property.
595 (While): Override Emit() and don't emit symbol info there; do it
596 inside DoEmit() instead.
597 (Block.Emit): Omit symbol information while emitting the scope
598 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
600 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
601 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
602 .ctor to make `IsIterator' work.
604 2008-03-14 Martin Baulig <martin@ximian.com>
606 * symbolwriter.cs: Added the new symbol writer function from the
607 debugger's `terrania' branch; temporarily enclose them inside
608 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
611 2008-03-14 Martin Baulig <martin@ximian.com>
614 (SymbolWriter): Make this a public static class.
617 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
618 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
620 2008-03-14 Marek Safar <marek.safar@gmail.com>
622 A fix for bug #370577
623 * statement.cs, lambda.cs: Added extra limitations when dealing with void
626 2008-03-14 Marek Safar <marek.safar@gmail.com>
628 * typemanager.cs (CSharpName): Made 250 times faster.
630 2008-03-13 Marek Safar <marek.safar@gmail.com>
632 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
634 2008-03-12 Marek Safar <marek.safar@gmail.com>
636 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
637 crash when predefined field does not exist.
639 2008-03-12 Marek Safar <marek.safar@gmail.com>
641 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
643 2008-03-12 Marek Safar <marek.safar@gmail.com>
645 * class.cs (FixedField): Don't crash when contructors are missing.
647 2008-03-11 Marek Safar <marek.safar@gmail.com>
649 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
650 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
651 check internal types accessibility for internal and external types.
652 Replaced EnumToUnderlying by GetEnumUnderlyingType.
654 2008-03-11 Marek Safar <marek.safar@gmail.com>
656 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
657 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
658 attribute.cs, statement: Use corect instance of predefined types (work
661 2008-03-07 Marek Safar <marek.safar@gmail.com>
663 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
665 2008-03-07 Marek Safar <marek.safar@gmail.com>
667 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
668 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
669 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
670 predefined types clean up, delayed predefined types members initialization
671 (work related to #364674).
673 2008-03-05 Marek Safar <marek.safar@gmail.com>
675 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
677 2008-03-05 Marek Safar <marek.safar@gmail.com>
679 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
680 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
681 predefined types clean up (work related to #364674).
683 2008-03-04 Marek Safar <marek.safar@gmail.com>
685 * ecore.cs: Print an error message instead of throwing exception.
687 2008-03-04 Marek Safar <marek.safar@gmail.com>
689 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
690 expression.cs, statement.cs: Unififed null literal representation.
692 2008-03-03 Marek Safar <marek.safar@gmail.com>
694 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
695 expression.cs: Refactored binary operators resolve phase and improved speed.
696 The nullable code is still missing and won't work correctly, more fixes
699 It also fixes #323726, #324312, #324248, and many other unreported issues.
701 2008-02-29 Zoltan Varga <vargaz@gmail.com>
703 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
706 2008-02-27 Marek Safar <marek.safar@gmail.com>
708 * ecore.cs: Clean-up and split BetterConversion.
710 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
713 * enum.cs (EnumMember.Value): Only access 'value' if
714 ResolveValue says it's ok.
715 (EnumMember.DoResolveValue): Don't set prev_member.value.
716 (Enum.GetDefinition): Reverse arguments of Equals --
717 EnumMember.Value can return 'null'.
719 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
721 2008-02-22 Marek Safar <marek.safar@gmail.com>
723 * generic.cs, expression.cs: More ongoing work on expression trees.
725 2008-02-21 Marek Safar <marek.safar@gmail.com>
727 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
728 handle missing matches when mutiple operators exist.
730 2008-02-20 Marek Safar <marek.safar@gmail.com>
732 A fix for bug #363218
733 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
736 2008-02-20 Marek Safar <marek.safar@gmail.com>
738 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
739 update. This time to deal correctly with SideEffectConstant expression used
740 as an argument for another constant folding.
742 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
744 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
747 2008-02-19 Marek Safar <marek.safar@gmail.com>
749 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
751 2008-02-19 Marek Safar <marek.safar@gmail.com>
753 A fix for bug #328136
754 * expression.cs: Do not fold immediately LogicalAnd operators when the left
755 side is a false constant, because we still need to evaluate the right-hand
758 * statement.cs (If): Emit two types of boolean constants (simple constant,
759 side-effect constant).
761 2008-02-19 Marek Safar <marek.safar@gmail.com>
763 * constant.cs (SideEffectConstant): Don't emit boolean constant.
765 * expression.cs: Fold immediately LogicalAnd operators when both sides are
768 2008-02-18 Marek Safar <marek.safar@gmail.com>
770 A fix for bug #361457
771 * ecore.cs (IsApplicable): Params methods have lower priority.
773 * support.cs: Return correct parameter modifier for params types.
775 2008-02-18 Marek Safar <marek.safar@gmail.com>
777 * generic.cs (TypeParameter): Cache attribute target name.
779 * support.cs: Removed unused variable.
781 * typemanager.cs: Removed debugging leftover.
783 * ecore.cs: Use local type instead of a property;
785 * class.cs (VerifyMembers): Consider also parent to test whether type member
788 * expression.cs (FullMethodDesc): Removed.
790 * attribute.cs (IsValidArgumentType): Made static.
792 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
794 Cleanup to be more readable.
795 * Makefile (GMCS_PROFILE): Remove.
796 (COMPILER_NAME): New helper.
798 2008-02-15 Miguel de Icaza <miguel@novell.com>
800 * cs-tokenizer.cs: if a conditional expression happens inside a
801 (...) this also means that we do not need to de-ambiguate between
802 an parenthesized expression and a cast.
806 * constant.cs (SideEffectConstant): a constant value that happens
807 to have a side effect.
809 Fixes the build regressions introduced by the fix for #359789
811 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
813 * expression.cs (Conditional.Emit): when emitting the ternary
814 operator, use local variables to generate code verifiable code.
816 The verifier cannot infer that the type on stack before the
817 stloc.0 is executed is of type ParentB. This happens because the
818 stack merge algorithm uses only parent types when deciding which
819 is the common type. This is described in Part III 1.8.1.3 of ECMA
822 This code compiled with mcs is not verifiable under MS. The MS
823 verifier picks the first common interface of Foo and Bar, which is
824 wrong, but doesn't use a full join type of the 2 interfaces.
826 CSC uses a clever hack to compile such code in a verifiable
827 way. It stores the intermediate values in a local variable with
832 2008-02-14 Miguel de Icaza <miguel@novell.com>
834 * expression.cs: Do not fold BitwiseAnd operators when the left
835 side is a false constant, because we still need to evaluate the
840 * support.cs: Instead of throwing an InternalErrorException when
841 the position of the stream is outside the boundary of our buffer,
842 reset the state of the reader, and restart the reading from the
843 beginning of the file.
845 2008-02-14 Marek Safar <marek.safar@gmail.com>
847 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
849 2008-02-14 Marek Safar <marek.safar@gmail.com>
851 A fix for bug #361686
852 * decl.cs: A protected types used inside a private class which parents
853 derives from the protected class are accessible.
855 2008-02-13 Marek Safar <marek.safar@gmail.com>
857 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
858 the parameterless constructor.
860 2008-02-13 Marek Safar <marek.safar@gmail.com>
862 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
863 lookup methods to use standard member cache when doing member lookup.
865 2008-02-12 Marek Safar <marek.safar@gmail.com>
867 * driver.cs: Don't report full path for referenced module as assembly error.
869 2008-02-12 Marek Safar <marek.safar@gmail.com>
871 * Makefile: Fixed `qh' target to work on all machines.
873 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
874 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
875 and HasElementType with TypeManager implementation.
877 2008-02-08 Marek Safar <marek.safar@gmail.com>
879 A fix for bugs #325134, #359749
880 * expression.cs, ecore.cs: Try to resolve an extension method even if the
881 first binds point to non-method member expression.
883 2008-02-08 Marek Safar <marek.safar@gmail.com>
885 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
887 2008-02-08 Marek Safar <marek.safar@gmail.com>
889 A fix for bugs #321394, #323028
890 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
891 Reworked naive IsAccessibleAs implementation to handle nested types.
893 2008-02-05 Jb Evain <jbevain@novell.com>
895 * class.cs: use generic type comparison for parameters
898 2008-02-05 Marek Safar <marek.safar@gmail.com>
900 A fix for bug #325372
901 * class.cs: Use generic type comparison when testing method signatures.
903 2008-02-05 Marek Safar <marek.safar@gmail.com>
905 A fix for bug #357047
906 * ecore.cs: Applied C# 3.0 changes to better conversion.
908 2008-02-05 Marek Safar <marek.safar@gmail.com>
910 A fix for bug #358374
911 * cs-parser.jay: Correctly set modifiers for all constructor types.
913 2008-02-04 Marek Safar <marek.safar@gmail.com>
915 A fix for bug #355251
916 * generic.cs: Added base class constraint based type inference.
918 2008-02-01 Marek Safar <marek.safar@gmail.com>
920 A fix for bug #357255
921 * decl.cs: One more missing visibility check.
923 2008-02-01 Marek Safar <marek.safar@gmail.com>
925 * support.cs: Fixed broken return.
927 2008-01-25 Marek Safar <marek.safar@gmail.com>
929 * report.cs: Correctly reset warnings count after probing.
931 2008-01-25 Martin Baulig <martin@ximian.com>
934 (NamespaceEntry.SymbolFileID): Make this work again after
935 MemberName.ToString() is gone.
937 2008-01-25 Marek Safar <marek.safar@gmail.com>
939 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
942 2008-01-25 Marek Safar <marek.safar@gmail.com>
944 * generic.cs: Use full implicit conversion for type inference fixing.
946 2008-01-24 Marek Safar <marek.safar@gmail.com>
948 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
949 Fixed user operator conversions.
951 2008-01-24 Marek Safar <marek.safar@gmail.com>
953 * generic.cs: Do nullable type to null comparison optimization during
956 2008-01-24 Marek Safar <marek.safar@gmail.com>
958 A fix for bug #355163
959 * generic.cs: Enabled l-value resolve on nullable expressions.
961 2008-01-24 Marek Safar <marek.safar@gmail.com>
963 A fix for bug #353986
964 * class.cs: Ingore static ctors with parameters for any further checks.
966 2008-01-24 Marek Safar <marek.safar@gmail.com>
968 A fix for bug #354310
969 * namespace.cs: Removed redundant check.
971 2008-01-24 Marek Safar <marek.safar@gmail.com>
973 A fix for bug #354928
974 * expression.cs: ElementInitializers can be resolved only once.
976 2008-01-24 Marek Safar <marek.safar@gmail.com>
978 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
979 Condition expressions.
981 2008-01-23 Marek Safar <marek.safar@gmail.com>
983 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
985 2008-01-22 Marek Safar <marek.safar@gmail.com>
987 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
990 * generic.cs: Implemented coalesce expression.
992 2008-01-22 Marek Safar <marek.safar@gmail.com>
994 A fix for bug #355145
995 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
996 expression tree type inference.
998 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
1001 * expression.cs (Binary.IsUnsignedType): Fix typo.
1003 2008-01-22 Marek Safar <marek.safar@gmail.com>
1005 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
1007 2008-01-22 Marek Safar <marek.safar@gmail.com>
1009 A fix for bug #355161
1010 * ecore.cs, expression.cs: Wider range of extension method supported
1013 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
1015 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
1016 AssemblyBuilder to operate in compiler context. Fixes mcs part of
1019 2008-01-22 Marek Safar <marek.safar@gmail.com>
1021 A fix for bug #355148
1022 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
1024 2008-01-22 Miguel de Icaza <miguel@novell.com>
1026 * expression.cs (CreateExpressionTree): Add support for or and
1027 logical or, and indent following the coding conventions.
1029 * typemanager.cs (LinqExpression): renamed from
1030 ExpressionTreeManager, for a shorter name.
1032 Use TypeManager.CoreLookupType to lookup types from our core
1033 assemblies and turn those into "Type" variables.
1035 Consumers that previously used "Namespace" and "Type" from this
1036 class should instead use the TypeExpression which is a type that
1037 is fully resolved (without involving the regular C# resolution
1040 This typically looks like this:
1042 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
1043 new MemberAccess (texpr, name, type_arguments, loc)
1045 This avoids the problem in: #355178
1047 2008-01-21 Marek Safar <marek.safar@gmail.com>
1049 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
1050 feature in parser only as we do in other cases.
1052 2008-01-21 Marek Safar <marek.safar@gmail.com>
1054 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
1055 typemanager.cs: A refactoring of params arguments to reuse existing
1056 expressions (params -> array initializer) to emit params argument instead
1057 of specialized handling.
1058 It was required by expression tree implementation and it has other benefits
1059 as well, we now apply same optimization for params arguments as we do for
1062 2008-01-18 Marek Safar <marek.safar@gmail.com>
1064 A fix for bug #353526
1065 * generic.cs: A type inference of params arguments may not required any
1066 temporary array creation.
1068 2008-01-18 Marek Safar <marek.safar@gmail.com>
1070 A fix for bug #353534
1071 * generic.cs, ecore.cs, expression.cs: A method group type inference is
1072 supported for delegates only.
1074 2008-01-18 Marek Safar <marek.safar@gmail.com>
1076 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
1077 type for more than 1 candidates.
1079 2008-01-18 Marek Safar <marek.safar@gmail.com>
1081 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
1084 2008-01-16 Marek Safar <marek.safar@gmail.com>
1086 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
1087 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
1088 operator) expressions.
1090 2008-01-16 Zoltan Varga <vargaz@gmail.com>
1092 * statement.cs: Avoid declaring an IL variable for this_variable since it is
1093 not accessed from the generated IL.
1095 2008-01-14 Marek Safar <marek.safar@gmail.com>
1097 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
1098 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
1099 statement.cs: The first expression tree implementation drop, mostly
1100 infrastructure work.
1102 2008-01-14 Marek Safar <marek.safar@gmail.com>
1104 * ecore.cs (IsNestedChild): Refactored.
1106 2008-01-11 Marek Safar <marek.safar@gmail.com>
1108 * lambda.cs: Don't use a cast on unknown expression statement.
1110 2008-01-10 Geoff Norton <gnorton@novell.com>
1112 * cs-tokenizer.cs: One more token to distinguish between method and lambda
1115 2008-01-09 Marek Safar <marek.safar@gmail.com>
1117 * doc.cs: Report better /doc crash details.
1119 2008-01-09 Marek Safar <marek.safar@gmail.com>
1121 A fix for bug #352536
1122 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
1124 2008-01-08 Marek Safar <marek.safar@gmail.com>
1126 A fix for bug #352287
1127 * ecore.cs, expression.cs: Do `this' access checking in all member access
1130 2008-01-08 Marek Safar <marek.safar@gmail.com>
1132 * rootcontext.cs, driver.cs: Switch to linq mode by default.
1134 * report.cs: Reset message stacks.
1136 2008-01-08 Marek Safar <marek.safar@gmail.com>
1138 * generic.cs (InferInPhases): Correctly calculate params position.
1140 2008-01-08 Marek Safar <marek.safar@gmail.com>
1142 * cs-tokenizer.cs: No need to parse full string when parsing lambda
1145 2008-01-07 Marek Safar <marek.safar@gmail.com>
1147 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
1149 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
1151 * driver.cs: Updated --help option.
1153 2008-01-07 Marek Safar <marek.safar@gmail.com>
1155 * generic.cs (InferParamsTypeArguments): Removed.
1156 (InferInPhases): Add params type inference.
1157 (LowerBoundInference): Fixed scoring mechanism.
1159 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
1161 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
1163 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
1164 byte array for unsigned "baked" assemblies.
1166 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
1168 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
1169 array for assemblies that are not strongnamed.
1171 2008-01-04 Marek Safar <marek.safar@gmail.com>
1173 A fix for bug #351481
1174 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
1175 declaring type for nested generic types.
1177 2008-01-04 Marek Safar <marek.safar@gmail.com>
1179 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
1180 instead of ToString.
1182 2008-01-03 Marek Safar <marek.safar@gmail.com>
1184 A fix for bug #351047
1185 * expression.cs (Binary.ResolveOperator): Allow equality operators between
1186 null and structs only when equality and inequality operators are defined
1187 either as an user-operators or predefined operators.
1189 2008-01-03 Marek Safar <marek.safar@gmail.com>
1191 A fix for bug #351047
1192 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
1194 2008-01-03 Marek Safar <marek.safar@gmail.com>
1196 A fix for bug #351257
1197 * cs-tokenizer.cs: Advance line number for '\r' correctly.
1199 2008-01-03 Marek Safar <marek.safar@gmail.com>
1201 A fix for bug #351157
1202 * class.cs (Using): Fixed yet another broken cloning.
1204 (Block): Put back more sensible default value for statements.
1206 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
1208 * codegen.cs: Allow AssemblyVersion with only major version component.
1211 2007-12-29 Marek Safar <marek.safar@gmail.com>
1213 A fix for bug #324654
1214 * class.cs: Use FullName property as member name.
1216 2007-12-28 Marek Safar <marek.safar@gmail.com>
1218 A fix for bug #342117
1219 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
1220 constructor constraint.
1222 2007-12-28 Marek Safar <marek.safar@gmail.com>
1224 A fix for bug #338273
1225 * class.cs (ProbertyBase): Access modifier checks are required for overrides
1228 2007-12-28 Marek Safar <marek.safar@gmail.com>
1230 A fix for bug #350839
1231 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
1233 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1235 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1238 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1240 * statement.cs: Changed some Hashtables to use HybridDictionaries
1241 instead. It was observed that some HashTables only contained a few
1242 items in the vast majority of cases. Since HybridDictionary is
1243 more efficient on small sets (<10 elements), "known_variables"
1244 from class ExplicitBlock as well as "labels" and "constants " from
1245 class Block were changed to HybridDictionaries.
1247 Atsai results: (56216kb->54987kb)
1249 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
1252 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1254 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1257 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1259 * expression.cs: foreach loop to for loop, saved on allocation of
1260 enumerator (59333kb->59141kb)
1262 * statement.cs. Changed foreach loops to for loops, saved on
1263 allocation of enumerator (59141kb->59006kb)
1265 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
1266 when constructed with no specified capacity. This was causing a
1267 few ArrayLists to allocate more memory than they would potentially
1268 need in the Block class and MemberCache class. Setting the
1269 ArrayLists to construct with a capacity of 1 saves some
1270 memory. (56216kb->55585kb)
1272 2007-12-27 Marek Safar <marek.safar@gmail.com>
1274 A fix for bug #347189 (2nd issue)
1275 * expression.cs (MemberAccess): Nested type can be found in base non-generic
1278 2007-12-27 Miguel de Icaza <miguel@novell.com>
1280 * report.cs: Do not use colors if stdout and stderr are not a
1283 2007-12-27 Marek Safar <marek.safar@gmail.com>
1285 A fix for bug #346998
1286 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
1289 2007-12-27 Marek Safar <marek.safar@gmail.com>
1291 A fix for bug #343465
1292 * class.cs: Explicit method name for nested types uses dots only.
1294 2007-12-27 Marek Safar <marek.safar@gmail.com>
1296 A fix for bug #343707
1297 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
1299 2007-12-27 Marek Safar <marek.safar@gmail.com>
1301 * ecore.cs: Report type inference errors only when arguments count matches
1304 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
1306 * expression.cs, report.cs: New warning.
1308 * typemanager.cs: Catch anonymous method type too.
1310 2007-12-23 Marek Safar <marek.safar@gmail.com>
1312 A fix for bug #346379
1313 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
1315 2007-12-23 Marek Safar <marek.safar@gmail.com>
1317 A fix for bug #347359
1318 * expression.cs (Invocation): Don't resolve already resolved expression.
1320 2007-12-23 Marek Safar <marek.safar@gmail.com>
1322 A fix for bug #347189
1323 * class.cs (FixedField): Use non-dependent code only in the define phase.
1325 2007-12-23 Marek Safar <marek.safar@gmail.com>
1327 A fix for bug #348076
1328 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
1330 2007-12-22 Marek Safar <marek.safar@gmail.com>
1332 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
1333 discovered extension methods.
1335 2007-12-22 Marek Safar <marek.safar@gmail.com>
1337 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
1340 2007-12-21 Miguel de Icaza <miguel@novell.com>
1342 * report.cs (ErrorMessage): Add support for using colors on
1343 terminals that support it.
1345 2007-12-21 Marek Safar <marek.safar@gmail.com>
1347 * ecore.cs: Use information about expanded params for error reporting.
1349 2007-12-21 Marek Safar <marek.safar@gmail.com>
1351 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
1352 and logic for params overloads.
1354 2007-12-15 Miguel de Icaza <miguel@novell.com>
1356 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
1357 as this is also created from the parser. Fixes #349034
1359 2007-12-12 Miguel de Icaza <miguel@novell.com>
1361 * statement.cs (Throw.CloneTo): it is valid to have empty
1362 expressions for throw.
1364 2007-12-03 Marek Safar <marek.safar@gmail.com>
1366 * cs-parser.jay: Set delegate constraint parsing region correctly.
1368 2007-12-03 Marek Safar <marek.safar@gmail.com>
1370 A fix for bug #345467
1371 * typemanager.cs (IsEqual): Compare generic parameters position only.
1373 2007-11-28 Marek Safar <marek.safar@gmail.com>
1375 * expression.cs (BaseAccess): Type arguments can be null.
1377 2007-11-27 Raja R Harinath <harinath@gmail.com>
1379 * statement.cs (Block.Resolve): Ensure flow-branching tree is
1380 consistent even when an error has occured.
1381 (Switch.Resolve): Likewise.
1383 2007-11-22 Marek Safar <marek.safar@gmail.com>
1385 A fix for bug #334505
1386 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
1389 2007-11-22 Marek Safar <marek.safar@gmail.com>
1391 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
1392 refactorings required to resolve extension methods correctly when mixing
1393 generics and non-generics members.
1395 2007-11-20 Marek Safar <marek.safar@gmail.com>
1397 A fix for bug #342584
1398 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
1401 2007-11-19 Marek Safar <marek.safar@gmail.com>
1403 A fix for bug #342512
1404 * delegate.cs: Use delegate argument expression when is available. Don't
1405 emit virtual call when class is sealed.
1407 2007-11-16 Marek Safar <marek.safar@gmail.com>
1409 A fix for bug #325423
1410 * assign.cs (FieldInitializer): Use resolved expression for emit.
1412 * class.cs: Print less confusing error message.
1414 2007-11-16 Marek Safar <marek.safar@gmail.com>
1416 * cs-tokenizer.cs: Removed GMCS ifdefs.
1418 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
1421 * cs-parser.jay: Disabled nullable check.
1423 * generic-mcs: Copied more generic stuff.
1425 2007-11-16 Marek Safar <marek.safar@gmail.com>
1427 * gcs-parser.jay: Merged to cs-parser.jay.
1429 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
1430 * *.csproj, *.sources: Updated to use only jay parser file.
1432 2007-11-16 Marek Safar <marek.safar@gmail.com>
1434 * gcs-parser.jay: Added nullable and default expression feature checks.
1436 2007-11-16 Marek Safar <marek.safar@gmail.com>
1438 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
1439 it fixes many TODOs and hidden bugs.
1441 * expression: Removed duplicate error check.
1443 2007-11-15 Marek Safar <marek.safar@gmail.com>
1445 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
1446 implicitly type local variable only when it is used in a declaration.
1448 2007-11-15 Marek Safar <marek.safar@gmail.com>
1450 * attribute.cs: Use CS0612 for empty strings.
1452 2007-11-14 Marek Safar <marek.safar@gmail.com>
1454 * lambda.cs, statement.cs: Contextual return may act as a statement.
1456 2007-11-14 Marek Safar <marek.safar@gmail.com>
1458 A fix for a regression cause by #324222
1459 * class.cs: Don't report unused even when it implements an interface.
1461 2007-11-13 Marek Safar <marek.safar@gmail.com>
1463 A fix for bug #341205
1464 * ecore.cs, expression.cs: Method group expression cannot do static
1465 method access with an instance reference check before overloading takes
1468 2007-11-13 Marek Safar <marek.safar@gmail.com>
1470 A fix for bug #325359
1471 * class.cs: Use predictable name for automatically generated property.
1473 2007-11-12 Marek Safar <marek.safar@gmail.com>
1475 A fix for bug #324996
1476 * expression.cs (Is): Handle case where D is nullable and T is not
1479 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
1481 2007-11-12 Marek Safar <marek.safar@gmail.com>
1483 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
1484 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
1485 Flush small error reporting changes.
1487 2007-11-09 Marek Safar <marek.safar@gmail.com>
1489 A fix for bug #324996
1490 * expression.cs: Rewrote Is expression implementation to work with
1491 generics, nullable types, anonymous method. A const result expression
1492 uses existing infrastructure instead of custom not fully-featured one.
1494 2007-11-08 Marek Safar <marek.safar@gmail.com>
1496 A fix for bug #340202
1497 * class.cs: Consider generics for volatile field.
1499 2007-11-08 Marek Safar <marek.safar@gmail.com>
1501 A fix for bug #335594
1502 * expression.cs: Use conversion rules when handling string addition.
1504 2007-11-07 Marek Safar <marek.safar@gmail.com>
1506 A fix for bug #336651
1507 * expression.cs: Fixed a crash when probing is on.
1509 2007-11-07 Marek Safar <marek.safar@gmail.com>
1511 A fix for bug #324242
1512 * covert.cs: Added a conversion from any nullable-type with an
1513 underlying enum-type to the type System.Enum.
1515 2007-11-07 Marek Safar <marek.safar@gmail.com>
1517 A fix for bug #324222
1518 * class.cs: Report all non-used event fields.
1520 2007-11-07 Marek Safar <marek.safar@gmail.com>
1522 A fix for bug #325161
1523 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
1524 qualifier for generic types.
1526 2007-11-07 Marek Safar <marek.safar@gmail.com>
1528 A fix for bug #322971
1529 * expression.cs, ecore.cs: Added intermediate result value check for
1532 2007-11-07 Marek Safar <marek.safar@gmail.com>
1534 A fix for bug #324754
1535 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
1536 when it was requested.
1538 2007-11-07 Marek Safar <marek.safar@gmail.com>
1540 A fix for bug #325101
1541 * expression.cs: Do type not value comparison for `is' expression.
1543 2007-11-07 Marek Safar <marek.safar@gmail.com>
1545 A fix for bug #320236
1546 * convert.cs: Don't apply user conversion on underlying target type.
1548 2007-11-06 Marek Safar <marek.safar@gmail.com>
1550 * expression.cs: Don't use unresolved expression for error reporting.
1552 2007-11-06 Marek Safar <marek.safar@gmail.com>
1554 A fix for bugs #337712, #324490
1555 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
1556 overloading resolution too.
1558 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
1559 the process consistent and more robust.
1561 * expression.cs, linq.cs, report.cs: Update.
1563 2007-11-02 Marek Safar <marek.safar@gmail.com>
1565 A fix for bug #332909
1566 * attribute.cs: Resolve attributes in correct context using error
1569 * rootcontext.cs: Define Obsolete attribute members as core members.
1571 2007-11-02 Marek Safar <marek.safar@gmail.com>
1573 * statement.cs: Removed unused methods.
1575 2007-10-31 Wade Berrier <wberrier@novell.com>
1577 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
1578 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
1581 2007-10-31 Marek Safar <marek.safar@gmail.com>
1583 A fix for bug #338102
1584 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
1585 methods registered as non-generics.
1587 2007-10-31 Marek Safar <marek.safar@gmail.com>
1589 A fix for bugs #337712, #324490
1590 * delegate.cs: Delegate covariance and contravariance is not allowed for
1593 2007-10-31 Marek Safar <marek.safar@gmail.com>
1595 A fix for bug #337719
1596 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
1599 2007-10-30 Marek Safar <marek.safar@gmail.com>
1601 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
1603 2007-10-29 Marek Safar <marek.safar@gmail.com>
1605 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
1608 2007-10-29 Raja R Harinath <rharinath@novell.com>
1610 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
1612 2007-10-29 Marek Safar <marek.safar@gmail.com>
1614 A fix for bug #334652
1615 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
1616 extension methods when we have not found the best candidate in normal
1619 2007-10-27 Marek Safar <marek.safar@gmail.com>
1621 * AssemblyInfo.cs: Keep up-to-date.
1623 2007-10-27 Marek Safar <marek.safar@gmail.com>
1625 * Makefile: Fixed generics compiler name.
1627 2007-10-27 Marek Safar <marek.safar@gmail.com>
1629 * lambda.test: removed, lambda parsing is done differently.
1631 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
1633 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
1635 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
1637 2007-10-27 Marek Safar <marek.safar@gmail.com>
1639 * Makefile, *.sources : All C# compilers are in mcs folder.
1641 * *.cs: Use existing 2_1 define for smcs.
1643 2007-10-26 Marek Safar <marek.safar@gmail.com>
1645 A fix for bug #335847
1646 * assign.cs, expression.cs: Couple of changes to avoid creating a
1647 temporary variable for each object initializer assignment statement. It
1648 simplifies struct initialization too, otherwise two temporary variables
1650 Implemented optimization of redundant default element initializers.
1652 2007-10-25 Marek Safar <marek.safar@gmail.com>
1654 A fix for bug #336766
1655 * expression.cs (Class.CheckBase): Use generic name when method is
1658 2007-10-25 Marek Safar <marek.safar@gmail.com>
1660 A fix for bug #334737
1661 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
1662 variable and not variable argument for prepared copies.
1664 2007-10-24 Marek Safar <marek.safar@gmail.com>
1666 A fix for bug #325110
1667 * class.cs, expression.cs, attribute.cs: Use open generic method when
1668 checking conditional attribute.
1670 2007-10-24 Marek Safar <marek.safar@gmail.com>
1672 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
1673 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
1674 FeatureIsNotAvailable.
1676 2007-10-24 Marek Safar <marek.safar@gmail.com>
1678 ** C# 3.0 Partial methods
1680 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
1681 methods support. Because of member cache issue with generics only
1682 non-generics partial methods are fully supported.
1684 2007-10-23 Marek Safar <marek.safar@gmail.com>
1686 * class.cs, decl.cs: Rewrote member overloads check to cope with
1687 generics and to use member cache for member checking. It also improves
1688 performance and fixes remaining overloads issues.
1690 2007-10-20 Marek Safar <marek.safar@gmail.com>
1692 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
1693 roottypes.cs, typemanager.cs:
1695 A member cache creation logic changed to add members immediately and
1696 not rely on fallback. The member cache is now only prefered way
1697 how to access and find type declaration members. It saves 5 MB of memory
1698 during MWF compilation and makes code ready for more optimizations and
1699 clean-ups, it's also a pre-requirement for partial methods.
1701 2007-10-18 Raja R Harinath <harinath@gmail.com>
1703 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
1704 handling for generic parameters.
1706 2007-10-15 Marek Safar <marek.safar@gmail.com>
1708 * class.cs (FixedField): Removed redundant volatile check.
1710 2007-10-15 Marek Safar <marek.safar@gmail.com>
1712 * class.cs, decl.cs: Fixed overload members verification to do only one
1713 check per possible collision.
1715 2007-10-13 Marek Safar <marek.safar@gmail.com>
1717 A fix for bug #325478
1718 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
1719 and create only one disposable flags container.
1721 2007-10-12 Marek Safar <marek.safar@gmail.com>
1723 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
1724 * statement.cs (Fixed): Fixed variables cloning.
1726 2007-10-12 Marek Safar <marek.safar@gmail.com>
1728 A fix for bug #333342
1729 * class.cs (EventField): Don't mark value type event as synchronized.
1731 2007-10-12 Marek Safar <marek.safar@gmail.com>
1733 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
1734 inference to identify best candidate method correctly.
1735 (ProperyExpr): A range variable is read only and cannot be modified.
1737 2007-10-11 Marek Safar <marek.safar@gmail.com>
1739 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
1740 logic to identify best candidate method correctly.
1742 2007-10-11 Marek Safar <marek.safar@gmail.com>
1744 * location.cs (Equals, GetHashCode): Removed.
1746 2007-10-11 Marek Safar <marek.safar@gmail.com>
1748 * report.cs: Implemented message recorder. It is used mainly for lambda
1749 expressions to capture otherwise swallowed error messages.
1751 * anonymous.cs, lambda.cs.cs: Do full parameters check.
1753 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
1755 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
1757 * expression.cs (MemberAccess): Always report lookup failure.
1759 * location.cs: Implemented Equals, GetHashCode.
1761 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
1763 2007-10-10 Jb Evain <jbevain@novell.com>
1765 * codegen.cs: re-enable assembly version check.
1767 2007-10-09 Marek Safar <marek.safar@gmail.com>
1769 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
1772 * namespace.cs (UsingAlias): Do correct version check.
1774 2007-10-08 Marek Safar <marek.safar@gmail.com>
1776 * expresison.cs, ecore.cs: Issue extension method error message when
1779 * rootcontext.cs: Added ISO_2 compiler mode option.
1781 2007-10-08 Marek Safar <marek.safar@gmail.com>
1783 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
1786 2007-10-08 Marek Safar <marek.safar@gmail.com>
1788 * attribute.cs (GetString, GetBoolean): Work with both literal and
1791 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
1792 Moved method overload specific methods to MethodGroupExpr.
1794 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
1795 it should be less memory consuming.
1797 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
1799 * codegen.cs: remove the assembly version check until the buildbot is
1802 2007-10-07 Jb Evain <jbevain@novell.com>
1804 * attribute.cs (Attribute.GetString): if the value
1805 expression is a StringConstant, return its string value.
1807 2007-10-07 Jb Evain <jbevain@novell.com>
1809 * typemanager.cs: add `assembly_version_attribute_type`.
1810 * codegen.cs: on attribute emission, check that the
1811 AssemblyVersionAttribute doesn't overflow.
1813 2007-10-05 Marek Safar <marek.safar@gmail.com>
1815 A fix for bug #324677
1816 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
1817 parent container of a scope container with currently resolved one.
1819 2007-10-05 Marek Safar <marek.safar@gmail.com>
1821 A fix for bug #325534
1822 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
1825 2007-10-05 Marek Safar <marek.safar@gmail.com>
1827 A fix for bug #327504
1828 * class.cs (Operator.Define): Refactored implicit and explicit user
1829 operator conversion rules.
1831 2007-10-05 Marek Safar <marek.safar@gmail.com>
1833 A fix for bug #327520
1834 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
1836 2007-10-04 Marek Safar <marek.safar@gmail.com>
1838 A fix for bug #328022
1839 * class.cs (MethodData.Define): Use correct method to check whether
1840 a method implementents an accessor.
1842 2007-10-04 Marek Safar <marek.safar@gmail.com>
1844 A fix for bug #330069
1845 * statement.cs (Fixed.Resolve): Read the first array element only when
1846 an array is instantiated.
1848 2007-10-04 Marek Safar <marek.safar@gmail.com>
1850 * expression.cs, assign.cs, generics.cs: Print correct operator when
1851 compound assignment is used.
1853 2007-10-04 Marek Safar <marek.safar@gmail.com>
1855 A fix for bug #325841
1856 * expression.cs (ArrayAccess): Use full argument cloning only for
1857 string compound concatenation.
1859 2007-10-03 Marek Safar <marek.safar@gmail.com>
1861 A fix for bug #328774
1862 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
1864 (PropertyExpr.EmitAssign): Fixed string concatenation compound
1867 2007-10-03 Raja R Harinath <rharinath@novell.com>
1870 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
1871 Event accessibility checks here. Remove some bogus code that
1872 accidently made GenericMethods work.
1873 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
1875 2007-09-25 Marek Safar <marek.safar@gmail.com>
1877 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
1879 * statement.cs (Block): Refactored AddVariable to allow error handling
1882 * generic.cs: New stub.
1884 2007-09-23 Marek Safar <marek.safar@gmail.com>
1886 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
1889 2007-09-17 Marek Safar <marek.safar@gmail.com>
1891 * class.cs: Use partial container to record whether any partial part
1892 contains static field initializer and therefore default contructor has
1895 2007-09-14 Marek Safar <marek.safar@gmail.com>
1897 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
1898 mono-list when only one of two partial parts has defined accessibility
1901 2007-09-14 Marek Safar <marek.safar@gmail.com>
1903 A fix for bug #82845
1905 * class.cs (TypeContainer): Set correct resolve context for all field
1908 2007-09-13 Marek Safar <marek.safar@gmail.com>
1910 * assign.cs: Fixed a crash when field is resolved twice with an error.
1912 * codegen.cs: Changed InFieldInitializer to be flag.
1914 * anonymous.cs, ecore.cs, expression.cs: Update after
1915 IsInFieldInitializer rename.
1917 * const.cs: Removed unused parameter.
1919 * class.cs: Changed the way how we resolve and emit field initializers.
1920 The field initilizers have to have access to contructor block to emit
1921 compiler generated code.
1923 2007-09-13 Marek Safar <marek.safar@gmail.com>
1925 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
1926 generics use TypeContainer instead.
1928 2007-09-12 Marek Safar <marek.safar@gmail.com>
1930 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
1932 * lambda.cs (ResolveParameters): Use more powerful
1933 InflateGenericArgument.
1935 * parameters.cs: Better exception message.
1937 2007-09-10 Marek Safar <marek.safar@gmail.com>
1939 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
1940 correct expression block type.
1942 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
1944 * expression.cs (Invocation): Extracted method group resolve to
1947 2007-09-07 Marek Safar <marek.safar@gmail.com>
1949 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
1950 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
1952 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
1953 generic extension methods.
1955 2007-09-06 Marek Safar <marek.safar@gmail.com>
1957 A fix for bug #82676 (Do I get it right now?)
1958 * convert.cs (Binary.ResolveOperator): An interface is converted to the
1959 object before a standard conversion is applied.
1961 2007-09-06 Marek Safar <marek.safar@gmail.com>
1963 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
1966 2007-09-05 Marek Safar <marek.safar@gmail.com>
1968 A fix for bug #82676
1969 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
1970 non-generic interface types.
1972 2007-09-05 Marek Safar <marek.safar@gmail.com>
1974 A fix for bug #82690
1975 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
1977 2007-09-05 Marek Safar <marek.safar@gmail.com>
1979 A fix for bug #82571
1980 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
1981 modifier for container based methods.
1983 2007-09-05 Marek Safar <marek.safar@gmail.com>
1985 A fix for bug #82676
1986 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
1987 any interface-type T means to any of interface type T.
1989 2007-09-04 Marek Safar <marek.safar@gmail.com>
1991 * namespace.cs: We have 2 versions of System.Core assembly.
1993 2007-09-04 Marek Safar <marek.safar@gmail.com>
1995 A fix for bug #82652
1996 * class.cs (Class.GetClassBases): Compare types and not expressions.
1998 2007-09-04 Marek Safar <marek.safar@gmail.com>
2000 A fix for bug #82620
2001 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
2002 actually never worked before.
2003 (IndexerAccess): Emit prepared arguments before they are modified.
2005 2007-09-04 Marek Safar <marek.safar@gmail.com>
2007 A fix for bug #82563
2008 * assign.cs: Revert wrong fix.
2010 * expression.cs (VariableReference.EmitAssign): Handle ref reference
2012 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
2013 Instead of ldelema/stdind we have to use temporary variables to handle
2014 cases like String.Concat (params string[]).
2016 2007-08-31 Marek Safar <marek.safar@gmail.com>
2018 * class.cs: EmitAttributes to Emit rename.
2020 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
2022 (MemberCore.HasClsCompliantAttribute): Don't depend on
2023 GetClsCompliantAttributeValue execution.
2025 2007-08-31 Marek Safar <marek.safar@gmail.com>
2027 * anonymous.cs: Use shorter type prefix.
2029 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
2032 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
2033 variables when probing is on.
2035 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
2036 unresolved variables.
2037 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
2038 handle transparent identifiers.
2040 2007-08-26 Marek Safar <marek.safar@gmail.com>
2042 * attribute.cs (IsClsCompliant): Add nullable types test.
2044 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
2046 * doc.cs : catch other types of exception than XmlException to
2047 report CS1570. Fixed bug #82565.
2049 2007-08-23 Marek Safar <marek.safar@gmail.com>
2051 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
2052 The number of delegate parameters has to match.
2053 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
2056 2007-08-21 Marek Safar <marek.safar@gmail.com>
2058 * anonymous.cs (AnonymousMethod): Generate private anonymous method
2059 to fix problem with private arguments.
2061 2007-08-20 Marek Safar <marek.safar@gmail.com>
2063 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
2065 * decl.cs (MemberName): Ignore generic type with no generic arguments.
2067 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
2068 empty. Add cloning suport.
2070 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
2072 2007-08-20 Marek Safar <marek.safar@gmail.com>
2074 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
2075 to create EmptyCast. It handles EmptyConstantCast specialization for
2078 2007-08-18 Marek Safar <marek.safar@gmail.com>
2080 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
2081 (EmitArrayArgument): One routine for array arguments.
2082 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
2084 2007-08-17 Marek Safar <marek.safar@gmail.com>
2086 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
2088 2007-08-17 Marek Safar <marek.safar@gmail.com>
2090 * anonymous.cs: MemberLookupFinal update.
2092 * class.cs (ConstructorInitializer): Is expression based.
2094 * delegate.cs: MethodGroupExpr update.
2096 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
2098 (Error_MemberLookupFailed): Customizable error override.
2099 (MethodGroupExpr): Keep queried type for later usage.
2100 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
2103 * expression.cs: Error_MemberLookupFailed refactoring.
2104 (New.DoResolve): Resolve as much as possible.
2105 (ElementInitializer.Error_MemberLookupFailed): Object initializer
2106 customization for invalid member types.
2108 * statement.cs: MethodGroupExpr update.
2110 2007-08-16 Marek Safar <marek.safar@gmail.com>
2112 * modifier.cs (Check): Check all modifiers and not only accessibility
2115 2007-08-16 Marek Safar <marek.safar@gmail.com>
2117 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
2118 type and not an expression.
2120 2007-08-16 Marek Safar <marek.safar@gmail.com>
2122 * statement.cs (Catch.Clone): Type and variable can be null.
2124 2007-08-16 Marek Safar <marek.safar@gmail.com>
2126 A fix for bug #81979
2127 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
2128 I am really not sure whether this is the best fix.
2130 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
2133 2007-08-14 Marek Safar <marek.safar@gmail.com>
2135 ** C# 3.0 Object and collection initializers (major re-write)
2137 * assign.cs (DoResolve): Initializers are not assign related.
2139 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
2140 used during collection or object initialization.
2142 * expression.cs (Error_InvalidArguments): Add initializers specific
2143 messages. More will come later because it requires some general
2145 (New.DoResolve): Better error handling for unsafe types.
2146 (EmptyExpressionStatement): New class.
2147 (ElementInitializer): An object initializer expression.
2148 (CollectionElementInitializer): A collection initializer expression.
2149 (CollectionOrObjectInitializers): A block of object or collection
2151 (NewInitialize): New expression with element/object initializers.
2153 * statement.cs: Reverted object/collection initializer hacks.
2155 * typemanager.cs (CSharpName): Filter __arglist type.
2157 2007-08-09 Marek Safar <marek.safar@gmail.com>
2159 ** C# 3.0 Anonymous Types (update to the latest standard)
2161 * expression.cs (Binary.ResolveOperator): Threat all null based types
2163 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
2164 (AnonymousTypeParameter): Updated.
2166 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
2167 (AnonymousTypeClass): New anonymous type container.
2169 * class.cs (AddField): Return operation result.
2171 * generic.cs: Another empty TypeArguments overload.
2173 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
2174 are stored at top of normal hierarchy.
2176 * typemanager.cs (CSharpName): Filter anonymous types.
2178 2007-08-09 Marek Safar <marek.safar@gmail.com>
2180 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
2181 as single Concat call. How could we miss that :-(
2183 2007-08-08 Marek Safar <marek.safar@gmail.com>
2185 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
2187 2007-08-07 Miguel de Icaza <miguel@novell.com>
2189 * expression.cs: Fix the previous commit, the creation of the
2190 arguments array list needs also to be conditional on the arguments
2193 * class.cs: Add a little bit of help to help narrow down problems.
2195 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
2196 not try to copy in that case.
2198 * driver.cs: When building SMCS, include a new different set of
2199 default assemblies here. Do this here so we can control whether
2200 to include the default assemblies with /noconfig.
2202 2007-08-03 Marek Safar <marek.safar@gmail.com>
2204 A fix for bug #81979
2205 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
2208 2007-08-03 Marek Safar <marek.safar@gmail.com>
2210 A fix for bug #82300
2212 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
2213 we are in probing scope.
2215 2007-08-03 Marek Safar <marek.safar@gmail.com>
2217 A fix for bug #82301
2219 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
2220 (Statement.CloneTo): Clone and not map children blocks.
2222 2007-08-03 Marek Safar <marek.safar@gmail.com>
2224 A fix for bug #82299
2226 * expression.cs (LocalVariableReference.CloneTo): Remap local info
2229 * statement.cs (Statement.CloneTo): Clone variables before statements
2230 to allow remaping of local variables.
2232 2007-08-03 Marek Safar <marek.safar@gmail.com>
2234 A fix for bug #82296
2237 * report.cs: Log crash details for future clone problems.
2239 * statement.cs (Return.Clone): Don't clone non-existent expression.
2241 2007-08-03 Raja R Harinath <harinath@gmail.com>
2243 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
2244 (Class.AddBasesForPart): Move CS0537 check here from ...
2245 * cs-parser.jay (class_declaration): ... here. Move calling of
2246 'AddBasesForPart' to ...
2247 (class_bases): ... here.
2248 (struct_declaration, interface_declaration): Update to changes.
2250 2007-08-02 Marek Safar <marek.safar@gmail.com>
2252 A fix for bug #81923
2254 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
2255 conversion is allowed.
2257 2007-08-02 Marek Safar <marek.safar@gmail.com>
2259 A fix for bug #81564
2261 * ecore.cs (EventExpr): Add IsBase handling.
2263 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
2266 2007-08-02 Raja R Harinath <harinath@gmail.com>
2268 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
2269 * cs-parser.jay: Some whitespace cleanups.
2270 (current_delegate): New.
2272 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
2273 a dummy code block, and use 'type_name' instead of 'member_name'.
2274 (interface_declaration, class_declaration): Likewise.
2275 (delegate_declaration): Likewise. Rearrange slightly and use
2277 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
2278 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
2280 2007-08-02 Marek Safar <marek.safar@gmail.com>
2282 A fix for bug #82039
2284 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
2287 * typemanager.cs (CSharpName): Split to string overload.
2289 2007-08-02 Marek Safar <marek.safar@gmail.com>
2292 * report.cs: Updated warning CS0472.
2294 2007-08-01 Marek Safar <marek.safar@gmail.com>
2296 A fix for bug #82181
2298 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
2300 2007-08-01 Marek Safar <marek.safar@gmail.com>
2302 A fix for bug #82277
2303 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
2305 2007-08-01 Marek Safar <marek.safar@gmail.com>
2307 ** C# 3.0 Type Inference (major bits are working)
2309 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
2310 (.ImplicitStandardConversionExists): Uses compatible.
2311 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
2312 (.InferReturnType): New method.
2313 (.Compatible): Refactored.
2314 (.ResolveParameters): Uses factory to create resolved parameters.
2315 (.CompatibleMethod): Add probing mode support.
2316 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
2317 clearly distinguish between 2 different operations.
2318 (LambdaMethod): Moved to lambda.cs.
2319 (AnonymousMethod): Removed unused fields and methods.
2320 (AnonymousDelegate): Simplified.
2322 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
2324 * convert. cs (ImplicitConversionStandard): Compatible works differently.
2326 * delegate.cs (Delegate): New mehods to reduce code duplication.
2327 (.GetConstructor): New method.
2328 (.GetInvokeMethod): New method.
2329 (DelegateCreation): Updated.
2331 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
2333 (OverloadResolve): Made probing little bit faster.
2335 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
2338 * generic.cs (TypeInferenceContext): Dummy implementation.
2340 * iterators.cs: Updated after Resolve/Define rename.
2342 * lambda.cs (LambdaExpression)
2343 (.ResolveParameters): Handles both type of arguments and type inference too.
2345 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
2346 (InflateTypes): Updated.
2348 * support.cs (InflateTypes): Changed signature and updated.
2350 * typemanager.cs (LookupMemberCache): Better dynamic type check.
2351 (MemberLookup_FindMembers): More MS tricks.
2352 (GetParameterData): Ditto.
2353 (GetDelegateParameters): Uses quick path for dynamic types.
2355 2007-08-01 Marek Safar <marek.safar@gmail.com>
2357 * class.cs (MethodData.Define): EmitContext is required for generic stuff
2360 2007-07-31 Marek Safar <marek.safar@gmail.com>
2362 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
2365 2007-07-26 Jb Evain <jbevain@novell.com>
2367 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
2368 which takes a boolean 'report_errors', similar to the GetMethod.
2369 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
2370 in .net 2.1, do not report errors here.
2372 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
2373 System.Runtime.CompilerServices.RequiredAttributeAttribute and
2374 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
2377 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
2378 of the type InternalsVisibleToAttribute before the first call
2379 to CoreLookupType which is allowed to fail (third boolean parameter
2380 to true). Because, during the resolution for a type that is not
2381 immediately found, we try to check if the type is not defined in
2382 a friend assembly, and to do so, we need the
2383 InternalVisibleToAttribute.
2385 2007-07-23 Miguel de Icaza <miguel@novell.com>
2387 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
2388 feature that allows structs to be compared against null and inline
2389 the result as true or false.
2391 Notice that the same code is not permitted inside a generic block
2392 of code that would do:
2394 class Foo<T> where T : struct {
2401 It is only allowed if the type of T is not bound (no where
2402 clause). In my opinion, this CSC 2 behavior is broken but people
2403 seem to be using it (IronRuby does, a few bug reports on bugzilla
2404 have it and some people have complained about it).
2406 All of the users that depend on this behavior have code that is
2409 * report.cs (Warning, Error): make these take object arguments,
2410 not strings, as that allows us to take advantage of Format.
2412 2007-07-20 William Holmes <billholmes54@gmail.com>
2414 * decl.cs: Changed MemberName.CountTypeArguments to also check the
2415 Left member variable for the Count.
2416 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
2417 MemberName.CountTypeArguments to avoid a NRE.
2419 This code is contributed under the MIT X11 license
2421 2007-07-18 Marek Safar <marek.safar@gmail.com>
2423 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
2425 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2427 * doc.cs : generic method arguments are written as ``x while generic
2428 type arguments are `x. Combined with the previous change, fixed bug
2431 2007-07-18 Raja R Harinath <rharinath@novell.com>
2434 * expression.cs (Binary.ResolveOperator): When converting
2435 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
2437 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2439 * doc.cs : when T: or whatever x: is specified, it does not really
2440 check the doc comment's syntax correctness. Fixed bug #82006.
2442 2007-07-18 Marek Safar <marek.safar@gmail.com>
2444 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
2445 LambdaExpression better.
2447 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
2449 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
2451 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
2452 as it can be generated.
2454 * expression.cs (Invocation.Error_InvalidArguments): Show correct
2457 * lambda.cs (LambdaExpression): Refactored to share same code with
2458 AnonymousMethodExpression.
2460 2007-07-17 Marek Safar <marek.safar@gmail.com>
2462 * anonymous.cs (MakeName): Include host name for easier debugging.
2463 (LambdaMethod): New class for lambda spcecific stuff.
2465 * attribute.cs: Set EmitContext return type.
2467 * class.cs: Set EmitContext return type.
2469 * codegen.cs (EmitContext): Return type cannot be null to stop messing
2470 with null/void meaning.
2472 * iterators.cs (ContainerType): Implemented.
2474 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
2476 * statement.cs (Return): Updated to lambda expressions.
2477 (Block.CloneTo): Parent can be null.
2479 2007-07-13 Marek Safar <marek.safar@gmail.com>
2481 A fix for bug #81917
2482 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
2484 * class.cs (FixedField): Check whether field is in unsafe scope.
2486 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
2487 (FieldExpr.Emit): Fixed buffers cannot be volatile.
2489 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
2492 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
2494 2007-07-13 Marek Safar <marek.safar@gmail.com>
2496 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
2497 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
2500 2007-07-13 Marek Safar <marek.safar@gmail.com>
2502 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
2504 2007-07-13 Marek Safar <marek.safar@gmail.com>
2506 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
2507 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
2509 * codegen.cs(EmitContext): Add ProbingMode flag.
2511 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
2513 * driver.cs: For now set both warning values.
2515 * ecore.cs (SimpleName): Name is readonly.
2516 (MethodGroup.OverloadResolve): One quick path for probing.
2518 * expression.cs (Unary): Set Oper r/o.
2519 (Binary): Set Oper r/o.
2520 (ParameterReference): Set few instance variables as r/o.
2521 (ParameterReference.DoResolveBase): Don't capture aruments when
2523 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
2524 (Arglist): arguments are private.
2525 (SizeOf): type is private and r/o.
2526 (MemberAccess): arguments are private.
2528 * report.cs: Enhanced reporting on/off capabilities.
2530 * lambda.cs: Uses ec.IsInProbingMode.
2531 (ContextualReturn): Derives from return.
2533 * rootcontext.cs: For now set both warning values.
2535 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
2537 (Return.Resolve): Don't die immediately.
2538 (Block.Resolve): Speed-up probing.
2539 (Block.CloneTo): Clone only child blocks.
2541 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
2543 * iterators.cs: reverted Miguel's latest change (r81925) as it
2544 breaks the build in System.
2546 2007-07-13 Miguel de Icaza <miguel@novell.com>
2548 * iterators.cs (Yield.CheckContext): Check for the iterator type
2549 also here as we can call into Yield even in codepaths that are not
2551 (MethodOrOperator is the only path that was checked).
2553 In addition to the standard check, use a more specific check for
2554 constructors to report a more verbose error.
2556 2007-07-12 Miguel de Icaza <miguel@novell.com>
2558 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
2559 report the warning and continue
2561 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
2562 values on the stack on the call to Emit. Use EmitStatement if
2563 possible, or using Emit + Pop if not possible. Fixes #82064
2565 2007-07-12 Raja R Harinath <rharinath@novell.com>
2567 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
2568 avoid try...finally in some cases.
2570 2007-07-10 Marek Safar <marek.safar@gmail.com>
2572 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
2574 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
2575 instead of method. Re-use standard error handling.
2576 (ConstructorInitializer.Emit): Simplified.
2578 * delegate.cs: Updated after Invocation.EmitCall change.
2580 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
2581 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
2582 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
2583 method and don't permanently changing input arguments.
2584 (MethodGroupExpr): Introduced resolved best_candidate, when method group
2585 is resolved it has one of the candidates is the best one which is later
2586 used to emit. Removed a few unused method.
2587 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
2589 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
2590 (Binary.ResolveOperator): Ditto.
2591 (ConditionalLogicalOperator.DoResolve): Ditto.
2592 (Invocation): Uses method group.
2593 (Invocation.DoResolve): Simplified.
2594 (Invocation.EmitCall): Removed useless is_static.
2595 (Invocation.Emit): Delegate to method group.
2596 (Invocation.EmitStatement): Simplified.
2597 (New): Uses method group.
2598 (MemberAccess.DoResolve): Don't destroy original expression.
2600 * statement.cs (ForEach.Resolve): Use null for no method arguments.
2602 2007-07-04 Marek Safar <marek.safar@gmail.com>
2604 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
2607 * lambda.cs: Add custom error message type.
2609 2007-07-03 Marek Safar <marek.safar@gmail.com>
2611 * lambda.cs: Simplified little bit.
2613 * parameter.cs: Introduced ImplicitLambdaParameter.
2614 (Parameters.CreateFullyResolved): New factory instead of ctor.
2618 * delegate.cs: Updated parameter creation.
2620 2007-07-03 Marek Safar <marek.safar@gmail.com>
2622 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
2625 * generic.cs: Synchronized with gmcs.
2627 2007-07-03 Marek Safar <marek.safar@gmail.com>
2629 * class.cs (Indexer): Check return type as soon as possible.
2631 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
2634 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
2636 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
2638 * parameter.cs (Parameter): Use expression type when it is available.
2640 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
2641 method modifier for the first parameter only.
2643 2007-06-24 Marek Safar <marek.safar@gmail.com>
2645 A fix for bug #81938
2646 * typemanager.cs (ChangeType): Fixed couple of char conversions.
2648 * constant.cs: Tide up an exception message.
2650 2007-06-22 Marek Safar <marek.safar@gmail.com>
2652 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
2653 an uninitialized variable is used.
2655 * expression.cs (LocalVariableReference.DoResolve): Ditto.
2657 2007-06-22 Marek Safar <marek.safar@gmail.com>
2659 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
2660 not found error handling.
2662 * expression.cs (ArrayCreation): Removed redundant fields and little bit
2664 (ArrayCreation.ResolveArrayElement): To be ready to customization.
2665 (ArrayCreation.DoResolve): Simplified.
2666 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
2667 its own resolve process.
2668 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
2670 2007-06-20 Marek Safar <marek.safar@gmail.com>
2672 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
2675 2007-06-20 Marek Safar <marek.safar@gmail.com>
2677 * cs-tokenizer.cs: Removed var related stuff.
2679 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
2680 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
2681 a type and a keyword at same time.
2683 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
2686 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
2687 implicitly typed arrays, more changes will follow.
2689 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
2691 2007-06-19 Marek Safar <marek.safar@gmail.com>
2693 * ecore.cs (VarExpr): Removed Handled field.
2695 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
2696 build-in assign functionality.
2697 (ForEach.Resolve): Removed all implicitly typed local variable code and
2699 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
2700 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
2702 2007-06-18 Marek Safar <marek.safar@gmail.com>
2704 * assign.cs: Removed implicitly typed local variable check.
2706 * expression.cs (LocalVariableReference.DoResolve): Add check for self
2707 referencing implicitly typed local variable.
2708 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
2711 * statement.cs (Fixed): Removed unsupported implicitly typed local
2714 2007-06-15 Marek Safar <marek.safar@gmail.com>
2716 * decl.cs (MemberName): Moved all Unbound stuff to parser.
2718 2007-06-14 Marek Safar <marek.safar@gmail.com>
2720 A fix for bugs #81855 and #76274
2721 * attribute.cs (AttachTo): Always set owner for global attributes to
2724 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
2727 * cs-parser.jay: Assembly and module attributes must precede all other
2728 elements except using clauses and extern alias declarations.
2730 2007-06-13 Marek Safar <marek.safar@gmail.com>
2732 A fix for bug #81748
2734 * expression.cs: More checks for non ISO-1 features.
2736 2007-06-12 Marek Safar <marek.safar@gmail.com>
2738 A fix for bug #81807
2739 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
2740 present inside switch statement and it is required by nullable check.
2742 2007-06-12 Marek Safar <marek.safar@gmail.com>
2744 A fix for bug #81840
2745 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
2746 when type matching fails.
2748 * namespace.cs: Tiny error message change.
2750 2007-06-12 Marek Safar <marek.safar@gmail.com>
2752 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
2753 reporting. Added automatic property check.
2755 * class.cs: Updated after CheckAbstractAndExtern relocation.
2756 (AEventPropertyAccessor.GetSignatureForError): Customized.
2758 2007-06-11 Marek Safar <marek.safar@gmail.com>
2760 * class.cs (DefineBaseTypes): Base type can be undefined.
2762 * ecore.cs (TypeLookup): Minor refactoring.
2763 (DoResolveAsTypeStep): Removed redundant check.
2765 * namespace.cs (Lookup): Removed redundant check.
2767 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
2768 ResolveAsTypeTerminal step.
2769 (BootstrapCorlib_*): Simplified.
2770 (PopulateCoreType): Core types can be now external.
2772 2007-06-07 Marek Safar <marek.safar@gmail.com>
2774 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
2776 (InferTypeArguments): Infers anonymous expression type arguments.
2777 (Compatible): Split to Compatible and InferTypeArguments.
2779 * lambda.cs: Updated.
2781 2007-06-08 Marek Safar <marek.safar@gmail.com>
2783 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
2785 2007-06-07 Raja R Harinath <harinath@gmail.com>
2787 Fix #80477, cs0135-2.cs, cs0135-3.cs
2788 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
2789 names to the "known" variables list.
2790 (Block.CheckInvariantMeaningInBlock): Handle the fact the
2791 parameter names are also "known".
2792 (Block.CheckError136): Remove.
2793 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
2796 2007-06-07 Marek Safar <marek.safar@gmail.com>
2798 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
2800 2007-06-06 Marek Safar <marek.safar@gmail.com>
2802 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
2803 internal error not an user error.
2805 * expression.cs (IsApplicable): Refactored to make debugging easier.
2807 * support.cs: More tricks for non-mono runtimes.
2809 * typemanager.cs (CoreLookupType): Made public.
2810 (InitSystemCore): All linq specific stuff moved to linq.cs
2812 2007-06-05 Marek Safar <marek.safar@gmail.com>
2814 * typemanager.cs (CSharpSignature): One more missing build-in types
2816 More tricks for non-mono runtime.
2818 2007-06-05 Raja R Harinath <harinath@gmail.com>
2820 * statement.cs (Block.CheckError136_InParents): Remove.
2821 (Block.AddVariable): Use GetParameterInfo instead.
2822 (ToplevelBlock.ProcessArguments): Likewise.
2824 2007-06-04 Raja R Harinath <rharinath@novell.com>
2826 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
2828 (ToplevelBlock.GetParameterInfo): Split out of ...
2829 (ToplevelBlock.GetParameterRefernce): ... this.
2830 (ToplevelBlock.ParameterMap): Remove.
2831 * expression.cs (ParameterReference): Update to use
2832 ToplevelParameterInfo.
2834 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
2837 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
2838 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
2840 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
2841 (ToplevelBlock.ProcessParameters) ... here.
2842 (ToplevelBlock..ctor): Invoke it.
2844 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
2847 * statement.cs (IKnownVariable): New interface.
2848 (LocalInfo): Implement it.
2849 (ToplevelParameterInfo): New class.
2850 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
2851 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
2852 GetKnownVariableInfo.
2854 2007-06-03 Raja R Harinath <harinath@gmail.com>
2856 Partly speed up CS0136 error checks.
2857 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
2858 'recurse' parameter.
2859 (Block.DoCheckError136): Only check errors in parameters. Move
2860 local variable checks ...
2861 (Block.AddVariable): ... here, and ...
2862 (ToplevelBlock.ResolveMeta): ... here.
2864 2007-06-02 Raja R Harinath <harinath@gmail.com>
2866 * statement.cs (Block.IsChildOf): Remove.
2868 * statement.cs (Statement.Clone): Move special case code ...
2869 (Block.CloneTo): ... here.
2871 2007-05-29 Raja R Harinath <rharinath@novell.com>
2873 * statement.cs (ToplevelBlock.container): Remove field. It's
2874 redundant with 'Parent'.
2875 (ToplevelBlock.ContainerBlock): Remove accessor.
2876 (ToplevelBlock..ctor): Update to changes. Register anonymous
2877 child with parent here, ...
2878 * cs-parser.jay (end_anonymous): ... not here. Don't modify
2880 (start_anonymous): Don't save current_block.
2881 (top_current_block): Remove.
2883 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
2884 (Block.Resolve): Update to changes.
2885 (Block..ctor): Move setting of "correct" 'Toplevel'
2886 and 'Explicit' fields to ...
2887 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
2889 2007-05-27 Raja R Harinath <harinath@gmail.com>
2892 * statement.cs (Block.Implicit): Remove.
2893 (Block): Update to changes.
2894 * flowanalysis.cs: Likewise.
2896 Mildly speed up CheckInvariantMeaningInBlock
2897 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
2898 Recursively call AddKnownVariable to all enclosing blocks.
2899 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
2900 Remove recursive calls.
2901 (Block): Update to changes.
2903 New ExplicitBlock invariants
2904 * statement.cs (Block.Explicit): New field. It points to the
2905 immediately enclosing non-implicit block.
2906 (Block..ctor): Maintain the invariant.
2907 * cs-parser.jay: Take advantage of invariant.
2909 Introduce ExplicitBlock
2910 * statement.cs (ExplicitBlock): New.
2911 (ToplevelBlock): Derive from it.
2912 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
2914 (Block.Implicit): Update to changes.
2915 * cs-parser.jay: Update to changes.
2918 * codegen.cs (EmitContext.IsLastStatement): Remove.
2919 * statement.cs (Block.DoEmit): Update to changes.
2921 2007-05-25 Raja R Harinath <rharinath@novell.com>
2923 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
2924 modifying current_block directly.
2926 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
2928 * class.cs: Implemented automatic properties (C# 3.0)
2929 Thanks to Marek for the help.
2931 2007-05-23 Raja R Harinath <rharinath@novell.com>
2933 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
2934 variable as assigned, note also that all its components are
2936 (MyBitVector.SetRange): New. Function to set multiple bits to true.
2938 2007-05-19 Marek Safar <marek.safar@gmail.com>
2940 * anonymous.cs, class.cs: Emit Compiler generated attribute when
2941 member is marked as compiler generated.
2943 * decl.cs (MemberCore): Refactored ModFlags into property.
2945 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
2946 (Check): Check only accessibility modifiers.
2948 2007-05-18 Raja R Harinath <rharinath@novell.com>
2950 Track all assignable slots in one bit array
2951 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
2952 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
2953 logic from VariableMap constructor here. Use the same 'offset'
2954 variable that's later used for computing offsets of local
2956 * flowanalysis.cs (UsageVector.parameters): Remove.
2957 (UsageVector): Update to changes.
2958 (VariableMap): Remove.
2960 Avoid creating ParameterMap in every block
2961 * statement.cs (Block.ParameterMap): Move ...
2962 (ToplevelBlock.ParameterMap): ... here.
2963 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
2965 * flowanalysis.cs (FlowBranching.param_map): Remove.
2966 (FlowBranching.UsageVector): Update to changes.
2967 (FlowBranchingToplevel.CheckOutParameters): Likewise.
2969 * statement.cs (Block.CloneTo): Clone Toplevel field too.
2971 * expression.cs (ParameterReference): Distinguish between block
2972 where parameter was referenced and declared.
2974 2007-05-18 Marek Safar <marek.safar@gmail.com>
2976 * flowanalysis.cs, statement.cs: Put back improved error handling.
2978 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
2982 Imporved object and collection initialization (C# 3.0).
2984 2007-05-15 Marek Safar <marek.safar@gmail.com>
2986 A fix for bug #81380
2987 * expression.cs (Is.DoResolve): Only value types have constant `is'
2990 2007-05-15 Raja R Harinath <rharinath@novell.com>
2992 * statement.cs (ToplevelBlock.child): Remove.
2994 2007-05-15 Raja R Harinath <harinath@gmail.com>
2996 Rationalize ResolveMeta: refactoring
2997 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
2998 out constant handling code into ...
2999 (Block.DoResolveConstants): ... this.
3001 Rationalize ResolveMeta: kill local_map
3002 * statement.cs (Block.local_map, Block.LocalMap): Remove.
3003 (Block.AssignableSlots): New.
3004 (Block.ResolveMeta): Make protected. Don't create a VariableMap
3005 for locals -- move code from VariableMap here. Avoid unnecessary
3007 * flowanalysis.cs (FlowBranching.local_map): Remove.
3008 (FlowBranching..ctor): Use Block.AssignableSlots.
3009 (VariableMap): Remove unused constructors.
3011 2007-05-11 Raja R Harinath <rharinath@novell.com>
3013 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
3015 2007-05-11 Marek Safar <marek.safar@gmail.com>
3017 * typemanager.cs (IsFriendAssembly): Should not be called for building
3020 2007-05-09 Marek Safar <marek.safar@gmail.com>
3022 * literal.cs (NullConstant): Print null in all cases.
3024 * expression.cs (Binary.ResolveOperator): Implemented delegate
3025 comparison based on C# 2.0 changes.
3027 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
3029 This code is contributed under the MIT X11 license
3031 The following enables support for several C# 3.0 language features:
3033 * cs-tokenizer.cs: Added support for the "var" keyword.
3035 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
3036 Added VarExpr class to facilitate type inferencing.
3038 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
3039 to support anonymous types.
3041 * assign.cs: Added support for type inferencing and initialization.
3043 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
3045 * expression.cs: Added implicit array support to ArrayCreation.
3046 Added 5 types and 1 interface:
3048 IInitializable Implementing classes can inject initializing
3049 statements after object instantiation.
3051 Initializer Stores data for object initialization.
3053 AnonymousType An expression for anonymous types.
3055 AnonymousTypeParameter Stores data about an anonymous type's field.
3057 NewInitialize An expression for object initialization.
3059 CollectionInitialize An expression for collection initialization.
3061 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
3064 2007-05-06 Marek Safar <marek.safar@gmail.com>
3066 A fix for bug #81500
3067 * cs-tokenizer.cs: Add special handling for coalescing operator.
3069 2007-05-06 Marek Safar <marek.safar@gmail.com>
3071 A fix for bug #81529
3072 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
3073 its value from base class until it is redefined.
3075 2007-05-02 Raja R Harinath <rharinath@novell.com>
3077 Fix regression in cs0631-3.cs
3078 * cs-parser.jay (operator_declarator): Add opt_attributes to error
3079 fallback. Make error fallback catch more cases.
3081 2007-05-01 Miguel de Icaza <miguel@novell.com>
3083 * cs-parser.jay: Allow parameters in operator declarations to have
3086 2007-04-27 Miguel de Icaza <miguel@novell.com>
3088 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
3091 * lambda.cs (ContextualReturn.Resolve): An expression is valid
3092 inside the ContextualReturn, it does not have to be an
3093 ExpressionStatement.
3095 2007-04-24 Miguel de Icaza <miguel@novell.com>
3097 * lambda.cs (ContextualReturn.Resolve): if the return type is not
3100 2007-04-23 Miguel de Icaza <miguel@novell.com>
3102 * anonymous.cs (AnonymousContainer): split the virtual Resolve
3103 method in two methods: ResolveNoDefine and Resolve.
3105 ResolveNoDefine will stop just after ResolveTopBlock has been
3108 Resolve will then continue by creating a method and issuing the
3109 call to method.Define ().
3111 (AnonymousMethod): Split and implement the new Resolve and
3112 ResolveNoDefine as well.
3114 * lambda.cs (LambdaExpression): Split the anonymous method
3115 resolution code into a separate routine (CoreCompatibilityTest)
3116 from DoCompatibleTest.
3118 (LambdaExpression.TryBuild): New method, this method tries to
3119 build the LambdaExpression with the given set of types to be used
3120 as the types for the various parameters of the lambda expression.
3122 If the compilation succeed with the given types, the infered type
3123 of the Anonymous method is returned, otherwise null is returned.
3125 2007-04-23 Marek Safar <marek.safar@gmail.com>
3127 A fix for bug #81414
3128 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
3130 2007-04-22 Miguel de Icaza <miguel@novell.com>
3132 * cs-tokenizer.cs: Change various identifiers here from the
3133 camelCasing to the recommended Linux-like style for instance
3134 variables from the Coding Guidelines.
3136 2007-04-19 Martin Baulig <martin@ximian.com>
3139 (Convert.ImplicitReferenceConversionCore): Allow conversions from
3140 System.Enum to System.ValueType.
3142 2007-04-13 Martin Baulig <martin@ximian.com>
3144 Rewrote implicit reference conversions. We need to distinguish
3145 between implicit reference conversions (13.1.4) and implicit
3146 boxing conversions (13.1.5).
3148 According to the spec, there's an an implicit conversion
3149 "From a one-dimensional array-type S[] to IList<T> and base
3150 interfaces of this interface, provided there is an implicit
3151 reference conversion from S to T." Note that this does not
3152 include boxing conversions.
3155 (Convert.ImplicitTypeParameterBoxingConversion): New method.
3156 (Convert.ImplicitReferenceConversion): Split into
3157 ImplicitReferenceConversionCore() and
3158 ImplicitBoxingConversionExist().
3159 (Convert.ImplicitReferenceConversionExists): Use the new
3160 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
3162 2007-04-12 Martin Baulig <martin@ximian.com>
3164 * convert.cs (Convert.ImplicitReferenceConversion): Move the
3165 `TypeManager.null_type' checks up to the top of the method.
3167 2007-04-11 Marek Safar <marek.safar@gmail.com>
3169 A fix for bug #81350
3170 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
3173 2007-04-11 Martin Baulig <martin@ximian.com>
3175 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
3176 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
3177 to make this work for generic classes; fixes #79561.
3179 2007-04-11 Martin Baulig <martin@ximian.com>
3181 * expression.cs (As): Add support for nullable types; fixes #79371.
3183 2007-04-11 Martin Baulig <martin@ximian.com>
3185 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
3186 `type.FullName' is null; fixes #80243.
3188 2007-04-11 Martin Baulig <martin@ximian.com>
3190 * expression.cs (Invocation.IsApplicable): Don't modify the method
3191 if type inference succeeded, but the method was not applicable.
3194 2007-04-10 Marek Safar <marek.safar@gmail.com>
3196 A fix for bug #81324
3197 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
3198 internal and external namespaces containers.
3200 2007-04-10 Martin Baulig <martin@ximian.com>
3202 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
3203 TypeManager.DropGenericMethodArguments() so we also call
3204 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
3206 2007-04-10 Martin Baulig <martin@ximian.com>
3208 * iterators.cs (Iterator.CreateIterator): Don't crash if
3209 `method.ReturnType' is null. This happens if something went wrong
3210 while resolving that typ (we already reported an error in this case).
3212 2007-04-10 Martin Baulig <martin@ximian.com>
3214 * expression.cs (New.DoResolve): Don't call CheckComImport() on
3215 generic interfaces; report the CS0144 directly.
3217 2007-04-10 Martin Baulig <martin@ximian.com>
3219 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
3220 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
3222 2007-04-10 Martin Baulig <martin@ximian.com>
3224 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
3226 2007-04-09 Raja R Harinath <rharinath@novell.com>
3229 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
3230 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
3233 * statement.cs (For.Resolve): If resolution fails, use
3236 2007-04-08 Marek Safar <marek.safar@gmail.com>
3238 * anonymous.cs (MakeName): Make faster and zero-based.
3239 (VerifyExplicitParameterCompatibility): Back to mode where generic
3240 parameter is ignored.
3241 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
3243 * class.cs (EmitType): Method can emit another new method.
3245 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
3247 * driver.cs: Updated.
3249 * lambda.cs: Reuse predefined empty parameters.
3251 * parameter.cs: Updated
3253 * support.cs: Implemented InflateTypes.
3255 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
3256 (InitSystemCore): Introduced to isolate 3.0 dependencies.
3258 2007-04-03 Martin Baulig <martin@ximian.com>
3262 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
3263 version of TypeManager.IsOverride() which also works with generic
3266 2007-04-03 Martin Baulig <martin@ximian.com>
3271 (Convert.ExplicitReferenceConversion): We need to cast when
3272 converting from IList<T> to S[].
3274 2007-04-01 Marek Safar <marek.safar@gmail.com>
3276 * decl.cs (FindExtensionMethods): Consider all candidates with same name
3279 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
3281 2007-03-31 Marek Safar <marek.safar@gmail.com>
3283 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
3284 argument and return type inferring.
3286 * codegen.cs (InferReturnType): Flag whether return can be inferred.
3287 (ReturnType): Turned to property.
3289 * statement.cs (Return): Implemented return type inferring.
3291 * support.cs (ReflectionParameters): Use local types if possible.
3293 2007-03-30 Raja R Harinath <rharinath@novell.com>
3295 * flowanalysis.cs (FlowBranching.Reachability): Remove.
3296 (FlowBranching.UsageVector): Update to changes.
3298 Prepare to kill 'Reachability'
3299 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
3300 argument of constructor.
3302 2007-03-29 Raja R Harinath <rharinath@novell.com>
3304 Prepare to kill 'Reachability'
3305 * flowanalysis.cs (UsageVector.is_unreachable): New.
3306 (UsageVector): Update to maintain 'is_unreachable' in parallel to
3307 'reachability', and verify they're consistent.
3310 * expression.cs (New.EmitStatement): Handle type parameters here too.
3312 2007-03-29 Martin Baulig <martin@ximian.com>
3317 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
3318 CompilerGeneratedClass.
3319 (ScopeInfo.EmitScopeInstance): Make this protected.
3320 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
3321 `ec.CurrentAnonymousMethod.Scope == Scope'.
3323 * statement.cs (Block.ScopeInfo): Make this a property.
3325 2007-03-27 Raja R Harinath <harinath@gmail.com>
3327 Prepare to kill 'Reachability'
3328 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
3329 (FlowBranching.UsageVector.Reachability): Remove property.
3330 (FlowBranching.UsageVector.IsUnreachable): New property.
3331 (FlowBranching.UsageVector.ResetBarrier): New.
3332 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
3333 * codegen.cs, statement.cs: Update to changes.
3335 2007-03-27 Martin Baulig <martin@ximian.com>
3340 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
3343 2007-03-26 Raja R Harinath <rharinath@novell.com>
3345 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
3346 instead of TriState. Remove all mention of TriState.
3348 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
3349 replaced by a boolean. Add boolean 'is_unreachable' field, check
3350 and maintain invariants.
3352 2007-03-25 Marek Safar <marek.safar@gmail.com>
3354 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
3356 2007-03-25 Marek Safar <marek.safar@gmail.com>
3358 * expression.cs: Stop using obsolete 2.0 opcodes.
3360 2007-03-25 Marek Safar <marek.safar@gmail.com>
3362 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
3363 one of the latests Martin's fixes.
3365 2007-03-23 Miguel de Icaza <miguel@novell.com>
3367 * expression.cs: On BigEndian systems, swap the bytes, temporary
3368 solution until we get a new bitconverter class.
3370 2007-03-23 Martin Baulig <martin@ximian.com>
3374 * decl.cs (MemberCache.AddMembers): Add generic methods both as
3375 "Method" and "Method`1". Normally, a cache lookup is done on the
3376 "Method" form (ie. without the generic arity), but this one makes
3377 lookups on the full form work as well.
3379 2007-03-22 Raja R Harinath <rharinath@novell.com>
3381 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
3384 2007-03-20 Bill Holmes <billholmes54@gmail.com>
3386 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
3387 ordered_member_list, to TypeBuilder to store members to be defined
3388 in the order they were parsed in.
3389 - ordered_explicit_member_list contains all properties indexers
3390 and methods that are defined as explicit implementation of an
3391 interface or base class.
3392 - ordered_member_list contains all properties indexers and methods
3393 that are not defined as explicit implementation of an interface
3396 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
3397 functionality in these removed classes has been replaced with
3398 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
3399 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
3401 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
3402 to CheckForDuplications inside GetMethod and SetMethod Define Method
3403 to handle method property and indexer name conflicts.
3407 All code is contributed under the MIT/X11 license.
3409 2007-03-20 Martin Baulig <martin@ximian.com>
3411 * class.cs (TypeContainer.Interfaces): Removed; they're now
3412 included in `TypeContainer.Types'.
3414 2007-03-20 Martin Baulig <martin@ximian.com>
3416 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
3418 * class.cs (TypeContainer.CreateType): New public method. This is
3419 now called before DefineType() to create the TypeBuilders.
3420 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
3421 has already been created by CreateType().
3422 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
3423 don't resolve our base classes here; this has been moved into
3424 DefineBaseTypes(). We're now called from CreateType().
3425 (TypeContainer.DefineBaseTypes): New private method; resolve our
3426 base classes here. We're now called from DefineType().
3429 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
3430 our types first to create all the TypeBuilders. After that, call
3431 TypeContainer.DefineType() on all the types which'll resolve their
3432 base classes and setup the resolve order.
3434 2007-03-20 Martin Baulig <martin@ximian.com>
3436 * class.cs (TypeContainer.Enums): Removed; they're now included in
3437 `TypeContainer.Types'.
3439 2007-03-20 Martin Baulig <martin@ximian.com>
3442 (TypeContainer.DefineType): Don't call ResolveMembers() here.
3443 (TypeContainer.DoResolveMembers): Call DefineType() on our
3444 `compiler_generated' classes; moved here from DefineNestedTypes().
3447 (RootContext.ResolveTree): Call ResolveMembers() on all
3448 TypeContainer's in the `type_container_resolve_order'.
3450 2007-03-19 Marek Safar <marek.safar@gmail.com>
3452 * class.cs: Use corlib to handle InternalMethodImplAttribute.
3454 2007-03-17 Marek Safar <marek.safar@gmail.com>
3456 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
3457 implementation flags.
3459 2007-03-17 Marek Safar <marek.safar@gmail.com>
3461 * class.cs: More optimizations for type parameters.
3463 2007-03-15 Marek Safar <marek.safar@gmail.com>
3465 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
3467 * ecore.cs, parameter.cs: More common code for both corlibs.
3469 * typemanager.cs (IsGenericMethod): Simplified.
3471 2007-03-15 Raja R Harinath <rharinath@novell.com>
3473 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3475 * statement.cs, iterators.cs, lambda.cs: Update to changes.
3477 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
3478 unconditionally. Simplify explanation.
3479 (Try.Resolve, Using.Resolve): Likewise.
3481 2007-03-15 Martin Baulig <martin@ximian.com>
3485 * decl.cs (DeclSpace): If we're a partial class, use our
3486 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
3488 2007-03-15 Raja R Harinath <rharinath@novell.com>
3490 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3492 (FlowBranching.UsageVector): Update to changes.
3493 (FlowBranching.MergeSiblings): Likewise.
3494 * statement.cs: Likewise.
3496 2007-03-15 Martin Baulig <martin@ximian.com>
3501 (MemberCache): Added a special .ctor for type parameters.
3504 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
3507 2007-03-09 Martin Baulig <martin@ximian.com>
3509 * enum.cs (Enum): Make this a TypeContainer.
3510 (EnumMember): Derive from `Const'.
3513 (Const.DoResolveValue): New protected virtual method; move most of
3514 the functionality of ResolveValue() here so we can override it in
3516 (Const.CreateConstantReference): Make this virtual.
3518 * class.cs (Kind): Add `Kind.Enum'.
3519 (TypeContainer.Emit): Don't emit the enums here; they're already
3520 in the `RootContext.typecontainer_resolve_order'.
3522 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
3523 here; they're already in the `typecontainer_resolve_order'.
3525 * ecore.cs (EnumConstant.ConvertImplicitly): Add
3526 TypeManager.DropGenericTypeArguments().
3529 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
3530 (TypeManager.IsEnumType): Likewise.
3531 (TypeManager.EnumToUnderlying): Likewise.
3532 (TypeManager.IsEqual): Add support for enums.
3534 2007-03-12 Raja R Harinath <rharinath@novell.com>
3536 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
3537 DefaultParameterValueAttribute to be undefined, say if System.dll
3540 2007-03-11 Marek Safar <marek.safar@gmail.com>
3542 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
3545 2007-03-10 Marek Safar <marek.safar@gmail.com>
3547 * class.cs, parameter.cs: Unified parameters verification.
3549 2007-03-08 Martin Baulig <martin@ximian.com>
3551 * cs-parser.jay (constructor_header): Pass the location to the
3552 newly created TopLevelBlock.
3554 2007-03-07 Martin Baulig <martin@ximian.com>
3556 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
3558 2007-03-06 Miguel de Icaza <miguel@novell.com>
3560 * convert.cs (ExplicitReferenceConversionExists): Sync this method
3561 with the changes from David, fixes the build.
3563 2007-03-05 David Mitchell <dmitchell@logos.com>
3565 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
3566 and its base interfaces to a one-dimensional array type S[],
3567 provided there is an implicit or explicit reference conversion
3570 2007-03-03 Marek Safar <marek.safar@gmail.com>
3572 * cs-tokenizer.cs: Implemented basic linq grammar.
3574 * driver.cs: Set linq lang version on demand.
3576 2007-02-26 Marek Safar <marek.safar@gmail.com>
3578 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
3580 2007-02-25 Marek Safar <marek.safar@gmail.com>
3582 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
3585 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
3587 Check property and event extern attributes.
3589 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
3592 2007-02-24 Marek Safar <marek.safar@gmail.com>
3594 A fix for bug #80407
3595 * ecore.cs: Don't report ambiguity error when methods have same parent.
3597 2007-02-23 Marek Safar <marek.safar@gmail.com>
3599 A fix for bug #80878
3600 * class.cs, cs-parser.jay: Event property can host anonymous methods.
3602 2007-02-22 Marek Safar <marek.safar@gmail.com>
3604 * attribute.cs: Enable ExtensionAttribute presence test.
3606 2007-02-22 Marek Safar <marek.safar@gmail.com>
3608 * class.cs: Warn about missing GetHashCode only when Equals is override.
3610 * decl.cs: Check accessibility of type arguments.
3612 * typemanager.cs: Correctly report nullable array.
3614 2007-02-20 Marek Safar <marek.safar@gmail.com>
3616 * class.cs, report.cs: Capture more details when things go wrong.
3618 2007-02-20 Marek Safar <marek.safar@gmail.com>
3620 A fix for bug #80650
3621 * cs-parser.jay: Anonymous container starts at constructor declaration
3622 and not at block beginning because it has to be usable in constructor
3625 * statement.cs: Use context location and not block one for error reporting.
3627 2007-02-18 Marek Safar <marek.safar@gmail.com>
3629 A fix for bug #78712
3630 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
3633 2007-02-18 Marek Safar <marek.safar@gmail.com>
3635 A fix for bug #80493 by Atsushi Enomoto
3636 * cs-parser.jay: Ignore invalid attribute target.
3638 2007-02-18 Marek Safar <marek.safar@gmail.com>
3640 * cs-tokenizer.cs: Ignore '\0' as white space character.
3642 2007-02-17 Miguel de Icaza <miguel@novell.com>
3644 * cs-parser.jay: Add support for lambda expressions to the mcs
3647 * lambda.cs: Only clone when we are probing, not on the final call
3648 (Compatible is the final call).
3650 * statement.cs (CloneContext): Introduce class to provide block
3651 remapping during clone.
3653 All statements Clone themselves now.
3655 (Clone): special handling for blocks, when we clone a block, we
3656 register the block inside this routine, as children of the block
3657 might trigger a lookup.
3659 * expression.cs: Add support for CloneContext in all expressions.
3661 2007-02-17 Marek Safar <marek.safar@gmail.com>
3663 A fix for bug #80493
3664 * statement.cs: Report ambiguous warning when interfaces are not related.
3666 2007-02-15 Marek Safar <marek.safar@gmail.com>
3668 C# 3.0 extension methods.
3670 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
3671 cannot be used directly.
3673 * class.cs (Class.Emit): Emit extension attribute if any class method
3674 is extension method.
3675 (Method.Define): Add basic extension method validation conditions.
3676 (Method.Emit): Emit extension attribute for method.
3678 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
3679 extension method exists. Currently we follow same approach as Microsoft
3680 does, emit even if a method or a class are private but this can change
3683 * cs-parser.jay: Add handling of `this' keyword in method parameters
3686 * decl.cs (DeclSpace.IsStaticClass): New property.
3687 (MemberCache.FindExtensionMethods): Looks for extension methods with
3688 defined name and extension type.
3690 * doc.cs: Updated after OverloadResolve changes.
3692 * driver.cs: Add new soft reference to System.Core.dll.
3694 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
3695 (ExtensionMethodGroupExpr): Represents group of extension methods.
3697 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
3698 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
3699 to MethodGroupExpr and made non-static for easier customization.
3700 (Invocation.DoResolve): Add extension method lookup when no standard
3702 (MemberAccess.DoResolve): Try extension methods if no member exists.
3704 * modifiers.cs: Add METHOD_EXTENSION modifier.
3706 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
3707 as well as candidate extension type.
3708 (ComputeNamespaces): When assembly constains extension methods registers
3710 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
3711 extension method lookup.
3712 (Namespace.LookupExtensionMethod): Looks for extension method in this
3714 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
3715 find a method which matches name and extensionType.
3717 * parameter.cs (Parameter): Add This modifer.
3718 (HasExtensionMethodModifier): New property.
3719 (Resolve): Add extension parameter check.
3720 (ModFlags): turned to property to exclude this modifier as it is not real
3722 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
3724 * support.cs (ParameterData): Add ExtensionMethodType.
3725 (ReflectionParameters): Implemented ExtensionMethodType interface property.
3727 * typemanager.cs: Add type and ctor extension attribute type.
3729 2007-02-15 Miguel de Icaza <miguel@novell.com>
3731 * report.cs (DisableErrors, EnableErrors): used to prevent error
3732 output when we are "trying" to compile various methods with
3735 * ecore.cs (Expression): Add Clone method that calls the virtual
3736 CloneTo method. The current CloneTo method in Expression throws
3737 an exception so we can track down all the places where this must
3738 be implemented (not using abstract, because that would be a lot of
3739 up-front-work before we can start testing the implementation
3742 Important: we only need Clone capabilities for expressions created
3743 by the parser, as the expressions we will be cloning are
3744 expressions in the pre-resolved state. This vastly simplifies
3747 (SimpleName): Add CloneTo that does nothing.
3748 (EmptyCast): Add CloneTo.
3750 * expression.cs (Binary): Implement CloneTo.
3751 (Invocation.IsApplicable): Store the current ec in
3752 EmitContext.TempEc and restore it on return. This is used so we
3753 do not have to sprinkle hundres of methods with an extra
3754 EmitContext, we know that the only user is the lambda expression
3755 ImplicitConversionExists code.
3757 (Argument): Add Cloning capabilities.
3758 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
3759 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
3760 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
3761 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
3762 IndexerAccess): Add Clone capability.
3764 (LocalVariableReference, This): TODO: needs cloned Block mapping.
3766 (Argument): Add cloning capability.
3768 * assign.cs (Assign): Implement CloneTo.
3770 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
3772 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
3773 version by calling Convert with the EmitContext (that we are
3774 currently storing in ec, this is not great, but will do for now,
3775 to avoid passing EmitContext parameters to hundreds of functions
3776 that do not need them now).
3778 (SetExpression): Remove, it is not needed.
3780 (ContextualReturn): Implement CloneTo.
3782 * statement.cs (Statement): Implement cloning infrastructure,
3783 similar to expressions.
3785 (Block): Partial implementation of Clone for statements.
3787 (Return): Implement clone.
3789 * constant.cs (Constant.CloneTo): New method, does nothing.
3791 * codegen.cs (TempEc): Add a static EmitContext as a temporary
3792 solution, until we decide how to exactly do this.
3794 2007-02-14 Marek Safar <marek.safar@gmail.com>
3796 A fix for bug #80493
3797 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
3798 a property is override we need to use second accessor.
3800 2007-02-13 Marek Safar <marek.safar@gmail.com>
3802 A fix for bug #80418
3803 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
3806 2007-02-13 Marek Safar <marek.safar@gmail.com>
3808 Another fix for bug #80749
3809 * pending.cs: Abstract class has priority over interfaces.
3811 2007-02-13 Marek Safar <marek.safar@gmail.com>
3813 Another fix for bug #80749
3814 * pending.cs: Abstract class has priority over interfaces.
3816 2007-02-13 Marek Safar <marek.safar@gmail.com>
3818 Another fix for bug #80749
3819 * pending.cs: Abstract class has priority over interfaces.
3821 2007-02-13 Marek Safar <marek.safar@gmail.com>
3823 Another fix for bug #80749
3824 * pending.cs: Abstract class has priority over interfaces.
3826 2007-02-13 Marek Safar <marek.safar@gmail.com>
3828 * class.cs Better error message.
3830 * driver.cs: Add shorter versions of -optimize option.
3832 2007-02-13 Martin Baulig <martin@ximian.com>
3834 * class.cs (Constructor.Emit): Check the return value of
3835 ec.ResolveTopBlock() and return on error.
3837 2007-02-13 Raja R Harinath <rharinath@novell.com>
3839 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
3840 message to fix error message regression.
3842 2007-02-12 Marek Safar <marek.safar@gmail.com>
3844 * delegate.cs: Delegate creation expression cannot be of Nullable type.
3846 2007-02-12 Marek Safar <marek.safar@gmail.com>
3848 A fix for bug #80749
3849 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
3850 its parent container.
3852 * class.cs (DefineFieldInitializers): Each initializer can has different
3855 * const.cs: Updated.
3857 2007-02-11 Miguel de Icaza <miguel@novell.com>
3859 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
3860 now all the heavy lifting to check that embedded statements or
3861 expressions have the right form is done in the ContextualReturn.
3863 (ContextualReturn): New class.
3865 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
3866 method that can be invoked to report 201, so we do not replicate
3869 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
3871 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
3872 treating tabs as spaces.
3874 2007-02-09 Marek Safar <marek.safar@gmail.com>
3876 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
3877 * assign.cs: Use full implicit conversion for right side check.
3879 2007-02-09 Marek Safar <marek.safar@gmail.com>
3881 * statement.cs (Switch): Switch over boolean type is not standardized.
3883 2007-02-08 Marek Safar <marek.safar@gmail.com>
3885 A fix for bug #80755
3886 * decl.cs (FindBaseEvent): Don't use method cache for events.
3888 2007-02-07 Marek Safar <marek.safar@gmail.com>
3890 * cs-parser.jay: Better syntax error handling.
3892 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
3893 instead of underlying type value.
3895 2007-02-06 Marek Safar <marek.safar@gmail.com>
3897 * driver.cs: Check define identifier before is registered.
3899 * namespace.cs: Use existing error message.
3901 * report.cs: New warning.
3903 2007-02-06 Marek Safar <marek.safar@gmail.com>
3905 A fix for bug #80742
3906 * expression.cs: Delegate Invoke method can be called directly.
3908 2007-02-06 Marek Safar <marek.safar@gmail.com>
3910 A fix for bug #80676
3911 * class.cs (IsEntryPoint): The Main method can have params modifier.
3913 2007-02-04 Miguel de Icaza <miguel@novell.com>
3915 * parameter.cs (Parameter, Parameters): Add Clone method.
3917 * anonymous.cs (Compatible): Turn method into virtual method, so
3918 LambdaExpression can implement a different behavior.
3920 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
3921 out the basic checking here, so it can be used by
3924 * lambda.cs: Introduce "Compatible" function that will do the
3927 2007-02-02 Marek Safar <marek.safar@gmail.com>
3929 * attribute.cs: Unified one error message.
3931 * class.cs (Class): Use type attributes and not properties to test static
3933 (IsEntryPoint): Don's pass local variable.
3935 * convert.cs: Removed duplicate check.
3937 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
3939 * driver.cs: Don't crash when soft reference does not exist.
3941 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
3942 (UsingEntry): Removed redundant allocation.
3944 * parameter.cs: Add fast path for type parameters.
3946 * support.cs: Don't allocate attribute when it's not used.
3948 2007-01-30 Miguel de Icaza <miguel@novell.com>
3951 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
3952 this into a virtual method, so we can override it in LambdaExpression.
3954 * driver.cs: Improve diagnostics in case of failure.
3956 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
3957 write a function that is slightly more complex and that parses:
3959 type identifier [, type identifier]* )
3961 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
3964 (canEmpty ? i >= 0 : i > 0)
3966 2007-01-30 Raja R Harinath <rharinath@novell.com>
3968 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
3969 exception on possibly valid code.
3971 2007-01-29 Raja R Harinath <rharinath@novell.com>
3973 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
3975 (parse_opt_type_arguments): Remove. It's almost the same as
3977 (parse_namespace_or_typename): Use parse_less_than.
3979 2007-01-28 Miguel de Icaza <miguel@novell.com>
3981 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
3982 this bug took a few hours to find, because the state saved and
3983 restored by PushPosition and PopPosition was ignoring the state of
3984 parse_generic_less_than.
3986 I can also now remove the handling of OP_LT and OP_GT, this solves
3989 * cs-tokenizer.cs: store the location for the ARROW token, we use
3992 (PushPosition, PopPosition): save/restore also `current_token',
3993 restore `parse_generic_less_than' (was missing).
3995 (parse_opt_type_arguments): use parse_type, not
3996 parse_namespace_or_typename to parse types.
3998 * lambda.cs: Empty new file, will eventually have the lambda
3999 expression implementation.
4001 * lambda.test: used to test the internal tokenizer.
4003 * report.cs (FeatureIsNotISO1): Rename from
4004 FeatureIsNotStandardized, because it was about the language level
4005 (1 vs 2) it was not about standarization.
4007 (FeatureRequiresLINQ): New.
4009 * support.cs (SeekableStreamReader): Only require that the reader
4010 is a TextReader, not a StreamReader, so we can plug StringReader.
4012 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
4013 given position in the input stream the following tokens can be
4014 parsed as a type followed by an identifier.
4016 (is_punct): after a '(' if parse_type_and_parameter returns true,
4017 then return a special token OPEN_PARENS_LAMBDA which is used to
4018 avoid reduce/reduce errors in the grammar for the
4019 lambda_expression rules.
4021 (parse_type): implement a type parser inside the
4022 tokenizer, the parser only returns true or false depending on
4023 whether the input at a given position can be parsed as a type.
4025 (peek_token): new method used during type parsing.
4027 2007-01-28 Raja R Harinath <rharinath@novell.com>
4030 * anonymous.cs (ScopeInfo.InflateParameters): New.
4031 (AnonymousContainer.Resolve): Use it to redirect types of
4032 delegate parameters.
4034 2007-01-27 Raja R Harinath <rharinath@novell.com>
4037 * expression.cs (Error_InvalidArguments): Don't use two different
4038 messages for CS1503. Use ExtraInformation and
4039 SymbolRelatedToPreviousError instead.
4042 * decl.cs (DeclSpace.initialize_type_params): Don't access
4043 'type_params' of a partial class directly.
4045 2007-01-26 Miguel de Icaza <miguel@novell.com>
4047 * constant.cs: Removed a handful of out-of-range checks that were
4050 2007-01-25 Marek Safar <marek.safar@gmail.com>
4052 * expression.cs (CheckUselessComparison): Add additional check for char
4055 * namespace.cs: Fixed typo.
4057 2007-01-23 Miguel de Icaza <miguel@novell.com>
4059 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
4060 gone, instead we inline the test, preventing the needless casts to
4061 longs, ulongs and doubles for the parameters, avoiding calls to
4062 methods that overchecked stuff, and instead inlined things
4065 2007-01-20 Marek Safar <marek.safar@gmail.com>
4067 * cs-parser.jay: Better parameter error handling.
4069 2007-01-17 Marek Safar <marek.safar@gmail.com>
4071 A fix for bug #80368, #80522
4072 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
4073 whether array initializer contains constants only.
4074 (ArrayCreation.Emit): Use better formula to decide when
4075 are array initializers for static initialization.
4076 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
4077 have to emit even constants otherwise they are pre-initialized.
4079 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
4080 Raja R Harinath <rharinath@novell.com>
4082 Fix emit order of 'get' vs. 'set'.
4083 * support.cs (Accessors): New.
4084 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
4085 Note the order in which accessors are declared in the source.
4086 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
4087 Refactored from Property.Define and Indexer.Define.
4088 (PropertyBase.DefineAccessors): New helper that calls the above in
4089 appropriate order as noted by the parser.
4090 (Property.Define, Indexer.Define): Update to changes.
4091 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
4093 2007-01-17 Raja R Harinath <rharinath@novell.com>
4095 Fix cs0029-6.cs and gcs0029-2.cs (regression)
4096 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
4097 there's an implicit conversion from the current type to the target
4098 type before converting the underlying constant.
4100 2007-01-16 Marek Safar <marek.safar@gmail.com>
4102 * const.cs (ResolveValue): Updated after constant conversion was made more
4105 * constant.cs (GetAttributableValue): constant to object conversion is
4106 used for attributes only.
4107 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
4108 constant conversions.
4109 (LongConstant.ConvertImplicitly): Ditto.
4111 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
4112 (ImplicitConversionStandard): Handle constant conversion as extra step.
4113 It solves the issue when constant conversion was called indirectly like
4114 inside array initializer and constant folding was skipped.
4116 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
4119 * statement.cs(ImplicitConversionStandard): Updated after constant
4120 conversion was made more generic.
4122 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
4124 * expression.cs (As.DoResolve): Use GenericConstraints instead of
4125 Constraints, solves the problem where the compiler incorrectly
4126 reported that a type parameter was not constrained to a class (Bug
4129 2007-01-14 Marek Habersack <grendello@gmail.com>
4131 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
4133 2007-01-14 Marek Safar <marek.safar@gmail.com>
4135 A fix for bug #80368
4136 * assign.cs (FieldInitializer): New class implements field
4137 initializer statement.
4139 * attribute.cs: Update after FieldMember rename.
4141 * class.cs (PropertyBasedMember): New common class for property based
4143 (InterfaceMemberBase): New base class for all members which can be used as
4144 an interface members.
4145 (MethodCore): Moved really common code to InterfaceMemberBase.
4146 (Method.Define): Equal and GetHasCode detection is relevant for methods
4148 (MethodData.Define): Don't assume that public event implements an
4149 interface automatically.
4150 (MethodData.DefineMethodBuilder): Issue an error even if only extern
4152 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
4153 (FieldMember): Merged with FieldBase.
4154 (EventProperty.AEventPropertyAccessor): New specialization to check whether
4155 event extern modifier can be used.
4156 (EventField.EventFieldAccessor): Moved event field specific code here.
4157 (Event.AllowedModifiers): Even event can be extern.
4158 (Event.FindOutBaseMethod): New override specific to events.
4159 (Indexer.parameters): Reintroduce parameters because base class holds
4160 only properties common data.
4161 (Indexer.CheckForDuplications): Indexers are threated as methods so we
4162 need do extra parameters check.
4164 * const.cs: Update after FieldMember rename.
4166 * decl.cs (MemberCache.FindBaseEvent): New method.
4168 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
4169 to reflect that indexer is now derived from PropertyBased.
4171 * ecore.cs (GetMemberType): Made public.
4172 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
4175 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
4177 * typemanager.cs (CSharpSignature): Correctly print event accessors.
4178 (RegisterEvent): Removed.
4179 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
4180 (GetPrivateFieldOfEvent): Renamed to GetEventField.
4182 2007-01-11 Raja R Harinath <rharinath@novell.com>
4185 * statement.cs (CollectionForeach.TryType): Prefer generic
4186 GetEnumerator over non-generic variant. Fix code to follow comments.
4188 2007-01-09 Raja R Harinath <rharinath@novell.com>
4191 * support.cs (ReflectionParameter): Don't use an invalid index on
4192 the generic parameter data.
4194 2007-01-08 Miguel de Icaza <miguel@novell.com>
4196 * driver.cs: Just add a tiny bit of infrastructure.
4198 2007-01-02 Marek Safar <marek.safar@gmail.com>
4200 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
4201 where field type is struct from current assembly.
4203 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
4206 2007-01-02 Marek Safar <marek.safar@gmail.com>
4208 A fix for bug #80381
4209 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
4212 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
4214 (Namespace.LookupType): Always use core types from corlib when speficied.
4216 * report.cs: A new warning.
4218 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
4219 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
4220 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
4222 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
4223 (InitCoreTypes): Set expression type of object_type and value_type
4224 immediately after lookup.
4226 2007-01-01 Miguel de Icaza <miguel@novell.com>
4228 * cs-tokenizer.cs: Accept Pc class characters (Connector
4229 Punctuation) as valid identifiers. Fixes #78259
4231 * expression.cs (Invocation.DoResolve): Moved the check for the
4232 use of `this' for doing method calls to the Invocation resolution
4233 step, after overload resolution has taken place instead of doing
4234 the check at the low-level `This.DoResolve' level.
4236 The `This.DoResolve'(appens before overload resolution, so it has
4237 no way of knowing if the method that will be called will be
4238 instace or static, triggering an erroneous report for cs0188 (Bug
4241 We now do the check for instance method invocations after we know
4242 what method will be called.
4244 (This.CheckThisUsage): Move the actual use of this structure
4245 checking into its own method and expose it.
4247 * Everywhere that called Error_ValueCannotBeConverted: pass a new
4250 Exceptions: Null.ConvertImplicitly,
4251 Constant.ImplicitConversionRequired as there are too many call
4252 sites for passing the ec.
4254 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
4255 EmitContext, if the value is null, then we do not try to provide
4256 the extra information from the error (If a userdefined conversion
4257 exists, as UserDefinedConversion requires a non null-EmitContext).
4261 2006-12-30 Raja R Harinath <rharinath@novell.com>
4263 * flowanalysis.cs (MyBitVector): Document some invariants.
4264 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
4265 introduced below, and add a couple of others,
4267 2006-12-30 Marek Safar <marek.safar@gmail.com>
4269 * attribute.cs (GetMethodObsoleteAttribute): Uses new
4270 GetPropertyFromAccessor and GetEventFromAccessor.
4272 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
4273 overrides non-obsolete one.
4274 (Indexer.Define): Error message has been moved to the parser.
4276 * cs-parser.jay: Better syntax errors handling.
4278 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
4279 when an invocation has no arguments.
4281 * ecore.cs: Removed not used caching.
4283 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
4286 * report.cs: Add a new warning.
4288 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
4290 * typemanager.cs (enumeration_type): Removed.
4291 (CSharpSignature): Reuses IsSpecialMethod.
4292 (IsEqual): Hack for MS BCL.
4293 (GetPropertyFromAccessor): New method.
4294 (GetEventFromAccessor): New method.
4295 (IsSpecialMethod): Fixed to handle more cases.
4297 2006-12-30 Marek Safar <marek.safar@gmail.com>
4299 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
4300 Made white spaces array static.
4302 * ecore.cs (RemoveGenericArity): Optimized.
4304 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
4306 (MyBitVector.initialize_vector): Simplified.
4308 2006-12-22 Miguel de Icaza <miguel@novell.com>
4310 * ecore.cs: Am not entirely happy with this hack, but it seems to
4311 address the issue in 80257 (a small test case for
4314 I set the MethodGroupExpr.Type to an internal compiler type
4315 (itself in this case) to force the resolution to take place. Why
4316 it does not take place with a null is beyond me.
4318 2006-12-20 Marek Safar <marek.safar@gmail.com>
4320 A fix for bug #80288
4321 * expression.cs (ResolveOperator): Consider user defined conversion for
4322 logical and operator too.
4323 (EmitBranchable): Optimization for logical and when full constant folding
4324 could not be applied but one operand is constant.
4326 2006-12-19 Marek Safar <marek.safar@gmail.com>
4328 * class.cs (GetClassBases): Write 5 times every day, will never use
4329 FullName for error reporting.
4331 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
4333 2006-12-19 Martin Baulig <martin@ximian.com>
4335 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
4336 the symbol file info here.
4338 2006-12-18 Marek Safar <marek.safar@gmail.com>
4340 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
4341 of `elseif' is taking then following sections are not taking.
4342 Fixes an issue reported on mono mailing list.
4344 2006-12-18 Marek Safar <marek.safar@gmail.com>
4346 A fix for bug #80300
4347 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
4348 a caller is not taking.
4350 2006-12-18 Raja R Harinath <rharinath@novell.com>
4352 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
4353 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
4354 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
4355 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
4356 * class.cs: Update to changes.
4358 2006-12-17 Marek Safar <marek.safar@gmail.com>
4360 A fix for bug #79934
4361 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
4364 * class.cs (ResolveMembers): Register an iterator in current container and
4367 2006-12-16 Raja R Harinath <rharinath@novell.com>
4370 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
4371 satisfy a params annotated parameter.
4373 2006-12-16 Marek Safar <marek.safar@gmail.com>
4375 A fix for bug #77014
4376 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
4377 paramters correctly and not rely on hacks in Parameters class.
4378 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
4380 (Invocation.VerifyArgumentsCompat): Ditto.
4381 (Invocation.EmitArguments): Changed to correctly emit params arguments at
4384 * parameter.cs (HasParams): Don't assume that params is the last one.
4386 * support.cs (ReflectionParameters.ctor): Look for params attribute
4388 (ReflectionParameters.ParameterType): Removed hack when we returned last
4389 parameter for out of range parameters.
4390 (ParameterName, ParameterModifier): Ditto.
4392 2006-12-14 Marek Safar <marek.safar@gmail.com>
4394 A fix for bug #79987
4395 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
4396 when assembly is not CLS compliant but type is. I have no idea why is this
4399 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
4401 2006-12-13 Miguel de Icaza <miguel@novell.com>
4403 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
4404 in struct constructors, they are basically no-ops.
4406 2006-12-12 Marek Safar <marek.safar@gmail.com>
4408 * cs-tokenizer.cs (Position): Save preprocessor status too.
4410 2006-12-12 Marek Safar <marek.safar@gmail.com>
4412 A fix for bug #77794
4413 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
4415 2006-12-12 Marek Safar <marek.safar@gmail.com>
4417 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
4419 (pp_expr): Report error for an invalid expression.
4420 (handle_preprocessing_directive): Simplified; add more error checking.
4422 2006-12-11 Marek Safar <marek.safar@gmail.com>
4424 A fix for bug #74939
4425 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
4426 directives handling.
4428 2006-12-10 Marek Safar <marek.safar@gmail.com>
4430 A fix for bugs #80093, and #75984
4431 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
4432 logic, it seems to me as it worked before "by coincidence".
4433 (xtoken): Simplified to use reworked handle_preprocessing_directive.
4434 (cleanup): Enabled endif check.
4436 2006-12-09 Marek Safar <marek.safar@gmail.com>
4438 A fix for bug #80162
4439 * statement.cs (CollectionForeach.TryType): Generics and non-generics
4440 enumerators are never ambiguous.
4442 2006-12-08 Raja R Harinath <rharinath@novell.com>
4445 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
4447 2006-12-06 Marek Safar <marek.safar@gmail.com>
4449 A fix for bug #80144
4450 * class.cs (EventProperty.Define): Explicit implementation means
4451 that an even is used.
4453 2006-12-06 Marek Safar <marek.safar@gmail.com>
4455 Fixes the operators implementation (part II)
4457 * cfold.cs (DoConstantNumericPromotions): Renamed to
4458 DoBinaryNumericPromotions and simplified.
4459 (BinaryFold): Couple of conversion fixes; simplified.
4461 * constant.cs, ecore.cs, literal.cs
4462 (ToType): Renamed to ConvertImplicitly.
4463 (Reduce): Renamed to ConvertExplicitly.
4465 * class.cs, convert.cs: Updated.
4467 * expression.cs: TryReduce doesn't throw an exception.
4469 2006-12-01 Marek Safar <marek.safar@gmail.com>
4471 A fix for bug #80108
4472 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
4475 2006-11-30 Marek Safar <marek.safar@gmail.com>
4477 Fixes unary operators implementation (part I)
4480 * cfold.cs (Error_CompileTimeOverflow): Made internal
4482 * const.cs (IConstant): Changed to use reference to constant and
4483 not constant itself.
4484 Updated IConstant implementations.
4486 * constant.cs (CreateConstant): New factory method.
4487 Updated IConstant implementation.
4489 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
4491 * ecore.cs: Updated to use CreateConstantReference.
4493 * enum.cs: Reflects IConstant changes.
4495 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
4497 * literal.cs (NullConstant): Change to be independently usable.
4499 2006-11-29 Martin Baulig <martin@ximian.com>
4501 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
4502 we need to emit the scope initializer before calling the base .ctor.
4504 * anonymous.cs: Merged back from the new anonymous methods branch.
4505 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
4507 * expression.cs (ParameterReference.DoResolveBase): Create a
4508 "normal" ScopeInfo when capturing parameters rather than using the
4509 root scope; this makes things work with anonymous methods having
4513 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
4515 2006-11-22 Marek Safar <marek.safar@gmail.com>
4517 A fix for bug #79987
4518 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
4519 check to a base class.
4520 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
4521 only when assembly has missing attribute.
4522 * report.cs: Update.
4524 2006-11-21 Marek Safar <marek.safar@gmail.com>
4526 * cs-tokenizer.cs: Merged with gmcs version.
4528 2006-11-20 Marek Safar <marek.safar@gmail.com>
4531 * cs-parser.jay: Better error message when partial keyword is misplaced.
4533 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
4535 A fix for bug #79810
4536 report.cs: CS1058 only applies to 2.0 profile (gmcs).
4537 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
4538 a RuntimeWrappedException by default.
4540 2006-11-18 Marek Safar <marek.safar@gmail.com>
4542 A fix for bug #79843
4543 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
4545 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
4547 2006-11-18 Marek Safar <marek.safar@gmail.com>
4549 * driver.cs, namespace.cs: Uses faster IndexOf version.
4551 2006-11-17 Marek Safar <marek.safar@gmail.com>
4553 A fix for bug #79941
4554 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
4556 (Operator.Define): Implicit/Explicit operator of same type is duplicate
4557 even if internal name is different.
4558 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
4559 (UserDefinedConversion): Simplified as the operators cannot be internal.
4560 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
4562 (MethodLookup): Replaced EmitContext with parentType.
4563 * expression.cs: Updated.
4565 2006-11-09 Raja R Harinath <rharinath@novell.com>
4567 * driver.cs (BadAssembly): Handle all the ugliness of
4568 DefineDynamicAssembly.
4570 2006-11-08 Raja R Harinath <rharinath@novell.com>
4572 Address parts of #58244 -- most of what's left is in the runtime
4573 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
4574 CS1509 error checks, and handle them for all assembly loads, not
4575 just the first invocation.
4576 (LoadModule): Likewise. Move handling of 'adder_method' ...
4577 * codegen.cs (AssemblyClass.AddModule): ... here.
4579 2006-11-02 Marek Safar <marek.safar@gmail.com>
4581 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
4582 IEnumerable<T> is ambiguous.
4584 2006-10-31 Marek Safar <marek.safar@gmail.com>
4586 A fix for bug #67689
4587 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
4588 GetEnumerator is ambiguous.
4590 * report.cs: Add new warning.
4592 2006-10-29 Marek Safar <marek.safar@gmail.com>
4594 A fix for bug #78602
4595 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4596 to protected member can be nested type.
4598 2006-10-28 Marek Safar <marek.safar@gmail.com>
4600 A fix for bug #78965
4601 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4602 to protected member must derive from current type.
4604 2006-10-27 Marek Safar <marek.safar@gmail.com>
4606 assign.cs: Reuses error method.
4608 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
4609 instead of type for constants.
4610 (Expression.Error_ValueAssignment): Common error method.
4612 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
4615 2006-10-27 Marek Safar <marek.safar@gmail.com>
4617 A fix for bug #79081
4618 * expression.cs (MemberAccess.DoResolve): Check nested type
4621 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
4623 * doc.cs : nested delegates were not handled. Fixed bug #79754.
4625 2006-10-26 Marek Safar <marek.safar@gmail.com>
4627 A fix for bug #76591
4628 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
4630 2006-10-26 Marek Safar <marek.safar@gmail.com>
4632 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
4633 type forwarder of the same type multiple times.
4635 2006-10-26 Raja R Harinath <rharinath@novell.com>
4638 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
4639 instance as an rvalue, even when we later resolve as an lvalue.
4641 2006-10-25 Martin Baulig <martin@ximian.com>
4643 * anonymous.cs: Fix #79673.
4645 2006-10-24 Marek Safar <marek.safar@seznam.cz>
4647 A fix for bug #79666
4648 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
4649 ignored when is optimized (= default value) as its value is already set.
4651 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4653 A fix for bug #79724
4654 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
4655 TypeContainer for type lookup.
4657 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4659 A fix for bug #79231
4660 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
4661 * expression.cs (OverloadResolve): Always convert type name for
4663 (ResolveNamespaceOrType): Don't confuse a nested type with any
4666 2006-10-18 Martin Baulig <martin@ximian.com>
4668 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
4670 2006-10-17 Miguel de Icaza <miguel@novell.com>
4672 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
4673 an int32, but requesting an int64 from the conversion
4675 2006-10-12 Martin Baulig <martin@ximian.com>
4678 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
4680 2006-10-12 Martin Baulig <martin@ximian.com>
4683 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
4685 2006-10-11 Miguel de Icaza <miguel@novell.com>
4687 * convert.cs: Remove broken code: I was doing the "Existance"
4688 tests for Implicit conversions.
4690 2006-10-10 Miguel de Icaza <miguel@novell.com>
4692 * convert.cs: Added one missing case in
4693 ImplicitStandardConversionExists uint64 to intptr.
4697 * typemanager.cs (uintptr_type): another core known type.
4699 * ecore.cs (OperatorCast): routine used to do cast operations that
4700 depend on op_Explicit. We could change some of the Decimal
4701 conversions to use this.
4703 This one has a probe mechanism that checks both types for an op_
4704 which it coudl be used to eliminate two classes: CastToDecimal
4705 and CastFromDecimal.
4707 * convert.cs: Implement the conversions documented in #59800
4709 2006-10-10 Martin Baulig <martin@ximian.com>
4711 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
4712 before RootScope.ResolveMembers().
4714 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
4715 `CurrentType' if appropriate.
4717 2006-10-09 Marek Safar <marek.safar@seznam.cz>
4719 A fix for bug #78568
4720 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
4721 when contains binary operators.
4722 * cs-parser.jay: Updated.
4724 2006-10-09 Martin Baulig <martin@ximian.com>
4727 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
4728 moved that into Define() and also do the other type parameter
4729 checks there. Fixes #79094. Added gtest-292.cs.
4732 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
4733 since that doesn't include type parameters; don't use `Ldelema'
4734 for type parameters. Fixes #78980. Added gtest-293.cs.
4736 2006-10-08 Marek Safar <marek.safar@seznam.cz>
4739 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
4740 conversion is allowed.
4742 2006-10-06 Marek Safar <marek.safar@seznam.cz>
4744 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
4745 error reporting when no error occurs.
4747 2006-10-06 Marek Safar <marek.safar@seznam.cz>
4749 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
4752 2006-10-06 Raja R Harinath <rharinath@novell.com>
4755 * class.cs (DefineTypeBuilder): Check circular dependencies before
4756 setting the parent of the TypeBuilder.
4757 (CheckRecursiveDefinition): Don't use 'BaseType', since
4758 it may not be valid until after DefineTypeBuilder. Use
4759 'base_type' instead.
4761 2006-10-04 Martin Baulig <martin@ximian.com>
4763 Merged the Anonymous Methods patch.
4765 * anonymous.cs, iterators.cs: The new anonymous methods code.
4767 * statement.cs (Variable): New public abstract class.
4768 (LocalInfo.Variable): New public property.
4769 (LocalInfo.ResolveVariable): New public method.
4770 (Block.Flags): Add `IsIterator'.
4771 (Block.AddVariable): Improved the CS0136 check.
4772 (Block.AnonymousChildren): New public property.
4773 (Block.AddAnonymousChild): New public method.
4774 (ToplevelBlock): Update to use the new anonymous method framework.
4775 (ToplevelBlock.ctor): `container' is now a `Block' and not a
4776 `ToplevelBlock'; this is required to correctly implement the
4778 (Fixed, Using): Use `TemporaryVariable' instead of directly
4779 creating the `LocalBuilder'.
4781 * parameter.cs (Parameter.ResolveVariable): New public method.
4782 (Parameters.ResolveVariable): Likewise.
4784 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
4786 * class.cs (TypeContainer): Replaced the `iterators' list and
4787 corresponding methods with a list of `CompilerGeneratedClass'es.
4788 (TypeContainer.ResolveMembers): New public method.
4789 (Method): `IIteratorContainer' has been replaced by
4792 * expression.cs (VariableReference): New public abstract base
4793 class for `LocalVariableReference', `ParameterReference' and
4796 * codegen.cs (EmitContext): Removed `capture_context',
4797 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
4798 (EmitContext.EmitThis): Removed.
4800 * cs-parser.jay: Replace `iterator_container' with
4803 2006-10-04 Martin Baulig <martin@ximian.com>
4805 * generic.cs (GenericMethod): Don't make this abstract.
4806 (Constraints.Clone): Added dummy implementation.
4808 2006-10-04 Raja R Harinath <harinath@gmail.com>
4811 * namespace.cs (LookForAnyGenericType): Avoid nullref on
4812 'declspaces'. Avoid allocating arrays willy-nilly.
4815 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
4816 cases out of the switch.
4818 2006-09-28 Marek Safar <marek.safar@seznam.cz>
4820 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
4821 message when non-generic type is used with the type arguments.
4822 * expression.cs: Updated.
4824 2006-09-28 Raja R Harinath <rharinath@novell.com>
4827 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
4828 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
4829 Change semantics slightly. Don't insist on having only one
4830 temporary EmptyExpression -- just throttle the creation of new ones.
4833 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
4834 non-interfaces too. If no methods are found, don't try to create
4837 2006-09-28 Marek Safar <marek.safar@seznam.cz>
4839 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
4842 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
4843 us produce better error message.
4845 2006-09-27 Marek Safar <marek.safar@seznam.cz>
4847 * expression.cs (Binary.ResolveOperator): Warn about a side effect
4848 of the `|' operator.
4850 * report.cs: A new warning added.
4852 2006-09-27 Martin Baulig <martin@ximian.com>
4854 * generic.cs (GenericMethod): Don't make this abstract.
4856 2006-09-27 Martin Baulig <martin@ximian.com>
4859 (InternalErrorException): Added overloaded ctor taking a params array.
4861 2006-09-26 Marek Safar <marek.safar@seznam.cz>
4863 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
4864 Fixed the cases when same error was reported twice.
4866 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
4867 now report symbol information.
4869 2006-09-25 Martin Baulig <martin@ximian.com>
4871 * class.cs: Completely unified with the gmcs version.
4873 2006-09-25 Martin Baulig <martin@ximian.com>
4875 * typemanager.cs (TypeManager.IsNullableType): New public function.
4876 (TypeManager.IsNullableTypeOf): Likewise.
4877 (TypeManager.IsNullableValueType): Likewise.
4879 * class.cs (MethodCore): Added the `GenericMethod' argument from
4880 gmcs and also unified all classes derived from `MethodCore' with gmcs.
4882 2006-09-24 Raja R Harinath <harinath@gmail.com>
4884 * convert.cs: Unify with gmcs version.
4886 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4888 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
4889 verify them as well.
4891 * report.cs: New warning.
4893 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4895 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
4896 for anonymous block with out argument.
4898 2006-09-24 Marek Safar <marek.safar@seznam.cz>
4900 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
4901 not used private events only.
4903 2006-09-23 Marek Safar <marek.safar@seznam.cz>
4905 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
4907 * const.cs (Const.Define): Check for constant type.
4908 (Const.IsConstantTypeValid): Looks for valid constant types.
4910 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
4912 * ecore.cs (EmptyConstantCast): New common class for all constant based
4915 * expression.cs (Is.DoResolve): Handle null constant especially.
4916 (New.DoResolve): Check for new void().
4917 (MemberAccess.DoResolve): Cope with all kind of nulls.
4919 * literal.cs (NullConstant): Uses EmptyConstantCast.
4920 (NullDefault): Based on EmptyConstantCast.
4921 (NullLiteral): Uses EmptyConstantCast.
4923 * statement.cs (Block.ResolveMeta): Check for constant type.
4925 2006-09-22 Martin Baulig <martin@ximian.com>
4927 * delegate.cs, attribute.cs: Merged with the gmcs versions.
4929 2006-09-22 Raja R Harinath <rharinath@novell.com>
4931 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
4935 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
4936 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
4939 2006-09-22 Martin Baulig <martin@ximian.com>
4941 * ecore.cs: Merged with the gmcs version.
4943 * generic.cs (ConstructedType): New dummy class.
4944 (TypeArguments): Don't make this abstract.
4947 (TypeManager.IsGenericTypeDefinition): New method.
4948 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
4950 2006-09-22 Raja R Harinath <rharinath@novell.com>
4952 * expression.cs (ComposedCast): Check for arrays of TypedReference
4953 before creating the type, not after.
4955 2006-09-21 Marek Safar <marek.safar@seznam.cz>
4957 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
4958 after ToType change.
4960 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
4961 when constant must be implicitly convertible.
4963 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
4965 * ecore.cs (NullCast): Derives from NullConstant.
4967 * expression.cs (Is.DoResolve): Removed useless variables.
4968 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
4969 (New.Constantify): Add enum support.
4970 (MemberAccess.DoResolve): Add warning when accessing null constant or
4973 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
4976 * literal.cs (NullConstant): New abstract class with common
4977 functionality for all null specializations.
4978 (NullDefault): Represents default(X) when result can be
4980 (NullLiteral): Updated.
4982 * report.cs: Add new warning.
4984 2006-09-21 Martin Baulig <martin@ximian.com>
4986 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
4988 2006-09-21 Martin Baulig <martin@ximian.com>
4990 * generic.cs (GenericConstraints): New dummy class.
4991 (Constraints): Likewise.
4992 (TypeParameter): Likewise.
4993 (TypeParameterName): Likewise.
4994 (GenericMethod): Likewise.
4996 * typemanager.cs (TypeManager.GetGenericArguments): New method.
4998 * decl.cs: Merged with the gmcs version.
5000 2006-09-21 Raja R Harinath <rharinath@novell.com>
5002 * generic.cs (TypeParameter): Implement IMemberContainer.
5003 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
5005 * rootcontext.cs: Unify with gmcs version.
5007 * report.cs: Unify with gmcs version.
5008 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
5009 from gmcs/generics.cs.
5010 * generics.cs (TypeParameter): New dummy class.
5012 * support.cs: Unify with gmcs version.
5014 2006-09-20 Raja R Harinath <rharinath@novell.com>
5016 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
5017 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
5019 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
5020 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
5021 * mcs.exe.sources: Add generic.cs.
5023 * codegen.cs: Unify with gmcs version.
5025 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
5026 (EmitContext): Add GenericDeclContainer implementation.
5027 * decl.cs (MemberCore, DeclSpace): Likewise.
5028 * namespace.cs: Remove #ifdef GMCS_SOURCE.
5030 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
5031 MCS TypeManager has a corresponding dummy method.
5033 2006-09-19 Martin Baulig <martin@ximian.com>
5035 * expression.cs: Completely merged with the gmcs version.
5037 2006-09-19 Martin Baulig <martin@ximian.com>
5039 * expression.cs (Invocation): Merged with the gmcs version.
5040 (ArrayAccess.GetStoreOpcode): Likewise.
5042 2006-09-19 Martin Baulig <martin@ximian.com>
5045 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
5046 (TypeManager.IsGenericMethodDefinition): Likewise.
5048 2006-09-19 Martin Baulig <martin@ximian.com>
5051 (TypeManager.IsEqual): Moved the gmcs implementation here.
5052 (TypeManager.DropGenericTypeArguments): Likewise.
5053 (TypeManager.DropGenericMethodArguments): Likewise.
5054 (TypeManager.GetTypeArguments): Moved here from gmcs.
5055 (TypeManager.HasGenericArguments): Likewise.
5057 2006-09-19 Martin Baulig <martin@ximian.com>
5059 * expression.cs (Binary): Merged with the gmcs version.
5061 2006-09-19 Martin Baulig <martin@ximian.com>
5063 * expression.cs (Probe, As, Is): Merged with the gmcs version.
5065 2006-09-19 Martin Baulig <martin@ximian.com>
5067 * typemanager.cs: Merged with the gmcs version.
5069 2006-09-16 Raja R Harinath <rharinath@novell.com>
5071 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
5072 * driver.cs: Likewise.
5074 2006-09-16 Marek Safar <marek.safar@seznam.cz>
5077 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
5078 only if parent type is class.
5079 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
5082 2006-09-15 Marek Safar <marek.safar@seznam.cz>
5085 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
5087 * typemanager.cs(CSharpName): Converts NullType to null.
5089 2006-09-15 Martin Baulig <martin@ximian.com>
5092 (TypeManager.GetMethodName): Added mcs implementation.
5093 (TypeManager.IsEqual): Likewise.
5096 (SimpleName.RemoveGenericArity): Added dummy implementation.
5098 * pending.cs: Merged with the gmcs version.
5100 2006-09-15 Martin Baulig <martin@ximian.com>
5102 * statement.cs: Merge with the gmcs version.
5104 2006-09-15 Martin Baulig <martin@ximian.com>
5106 * statement.cs (Switch): Merge with the gmcs implementation
5107 (without nullables), which is newer.
5109 2006-09-15 Martin Baulig <martin@ximian.com>
5111 * statement.cs (Block.Variables): Make this public.
5112 (ToplevelBlock.Parameters): Make this a property.
5113 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
5115 2006-09-15 Martin Baulig <martin@ximian.com>
5117 * namespace.cs: Merge with the gmcs version.
5119 2006-09-15 Martin Baulig <martin@ximian.com>
5121 * decl.cs (MemberName): Minor code cleanups.
5123 2006-09-15 Martin Baulig <martin@ximian.com>
5125 * parameter.cs: Merge with the gmcs version.
5127 2006-09-15 Martin Baulig <martin@ximian.com>
5129 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
5130 and an error in mcs.
5132 2006-09-15 Martin Baulig <martin@ximian.com>
5134 * flowanalysis.cs: Merged from GMCS; added the generics code into
5135 a `GMCS_SOURCE' conditional so we can share this file.
5137 2006-09-08 Martin Baulig <martin@ximian.com>
5139 * typemanager.cs (TypeManager.interlocked_type): New public field.
5140 (TypeManager.int_interlocked_compare-exchange): New public field.
5141 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
5142 enumerator types here and call InitGenericCoreTypes().
5143 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
5144 after calling InitEnumUnderlyingTypes().
5147 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
5148 `classes_second_stage'.
5150 2006-09-14 Marek Safar <marek.safar@seznam.cz>
5152 * assign.cs, ecore.cs, expression.cs: Share error message text.
5153 * class.cs (FieldMember.Define): Check for varible of static type.
5154 * driver.cs (LoadAssembly): Uses error output for errors.
5155 * statement.cs: Updated.
5157 2006-09-08 Marek Safar <marek.safar@seznam.cz>
5159 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
5162 2006-09-07 Martin Baulig <martin@ximian.com>
5165 (MainDriver): Revert r62663 from Marek; see #70506 for details.
5167 2006-08-29 Miguel de Icaza <miguel@novell.com>
5169 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
5171 2006-08-17 Miguel de Icaza <miguel@novell.com>
5173 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
5174 #52019 and #79064, the use of the \uXXXX sequence in source code
5175 to represent unicode characters.
5177 2006-08-15 Marek Safar <marek.safar@seznam.cz>
5179 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
5181 * class.cs, ecore.cs, statement.cs: Merged to one error message.
5183 2006-08-13 Miguel de Icaza <miguel@novell.com>
5185 * assign.cs: Catch attempts to assign to a method groups in += and
5188 2006-08-13 Marek Safar <marek.safar@seznam.cz>
5191 * cs-parser.jay: Don't destroy current array type by typeof of array's.
5193 2006-08-12 Marek Safar <marek.safar@seznam.cz>
5195 * class.cs (Method.Define): Issue a warning when generic method looks like
5197 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
5200 2006-08-09 Marek Safar <marek.safar@seznam.cz>
5202 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
5204 * decl.cs (MemberCache.FindMembers): When container is interface we need to
5205 search all base interfaces as a member can be ambiguous.
5206 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
5207 Constructor member type filter.
5208 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
5209 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
5210 reporting for returned memberinfos.
5211 * report.cs: Updated.
5212 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
5213 version to work on all runtimes.
5214 (TypeManager.RealMemberLookup): Removed members filtering.
5216 2006-08-08 Raja R Harinath <rharinath@novell.com>
5218 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
5219 (PropertyExpr.EmitAssign): Likewise.
5220 * expression.cs (Indirection.EmitAssign): Likewise.
5221 (LocalVariableReference.EmitAssign): Likewise.
5222 (ParameterReference.EmitAssign): Likewise.
5223 (Invocation.EmitArguments): Likewise.
5224 (ArrayAccess.EmitAssign): Likewise.
5225 (IndexerAccess.EmitAssign): Likewise.
5226 (This.EmitAssign): Likewise.
5227 (ConditionalLogicalOperator.Emit): Likewise.
5230 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
5231 instead of ArrayList. If the hashtable has a LocalBuilder, don't
5232 leave it in after returning it.
5233 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
5235 2006-08-06 Marek Safar <marek.safar@seznam.cz>
5237 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
5240 2006-08-03 Raja R Harinath <rharinath@novell.com>
5242 Fix cs0146-3.cs and cs0146-4.cs.
5243 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
5244 enclosing types don't depend on the current type.
5246 2006-08-02 Raja R Harinath <rharinath@novell.com>
5249 * class.cs (TypeContainer.DoDefineMembers): Use
5250 FindBaseMemberWithSameName on Parent, since we're interested in
5251 whether we hide inherited members or not.
5252 (FindBaseMemberWithSameName): Make slightly more robust.
5254 Fix the non-generic testcase from #77396
5255 * decl.cs (DeclSpace.DeclContainer): Remove override.
5257 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
5258 declspaces for doppelgangers too.
5259 (UsingEntry): Implement IResolveContext.
5260 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
5261 'this' as the resolve context.
5262 (LocalAliasEntry): Likewise.
5264 Implement parts of #77403
5265 * roottypes.cs (RootDeclSpace): New. Used to represent the
5266 toplevel declaration space. Each namespace declaration introduces
5267 a "partial" root declaretion space.
5268 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
5269 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
5270 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
5271 from 'current_namespace.SlaveDeclSpace'.
5272 (namespace_declaration): Likewise.
5273 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
5274 check. It can't happen now.
5275 * decl.cs (DeclSpace.LookupType): Likewise.
5276 * driver.cs (MainDriver): Sanity check.
5278 2006-08-01 Raja R Harinath <rharinath@novell.com>
5280 * decl.cs (DeclSpace.FindNestedType): Remove.
5281 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
5282 LookupTypeContainer to get the container of the nested type.
5283 * class.cs (TypeContainer.FindNestedType): Make non-override.
5285 2006-07-31 Raja R Harinath <rharinath@novell.com>
5287 * decl.cs (DeclSpace.PartialContainer): Move field from ...
5288 * class.cs (TypeContainer.PartialContainer): ... here.
5289 (TypeContainer.AddBasesForPart): New helper.
5290 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
5292 * cs-parser.jay (current_class): Convert to DeclSpace.
5293 (struct_declaration, interface_declaration, class_declaration):
5294 Use AddBasesForPart instead of .Bases directly.
5295 * const.cs, iterators.cs: Update to changes.
5297 2006-07-28 Raja R Harinath <rharinath@novell.com>
5299 * class.cs (TypeContainer.AddMemberType): Rename from
5301 (TypeContainer.AddMember): Rename from AddToMemberContainer.
5302 (AddTypeContainer): New. Combine AddClassOrStruct and
5304 (AddPartial): Update. Add 'is_partial' argument.
5305 * roottypes.cs: Update to changes.
5306 * cs-parser.jay (push_current_class): New helper for handling
5307 current_container and current_class.
5308 (struct_declaration, interface_declaration, class_declaration):
5311 2006-07-26 Raja R Harinath <rharinath@novell.com>
5313 * roottypes.cs: Rename from tree.cs.
5315 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
5316 * tree.cs (Tree, ITreeDump): Remove types.
5317 * rootcontext.cs (tree, Tree): Remove fields.
5318 (root, ToplevelTypes): New.
5319 * *.cs: Update to rename.
5321 * tree.cs (Tree.RecordDecl): Remove.
5322 (RootTypes.AddToTypeContainer): Record the toplevel type in its
5324 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
5326 2006-07-23 Raja R Harinath <harinath@gmail.com>
5328 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
5329 DoFlowAnalysis and OmitStructFlowAnalysis here.
5330 (ec.With): Rename from WithUnsafe and generalize.
5331 (ec.WithCheckState): Remove. All users can be handled by 'With'.
5332 (ec.WithFlowAnalyis): New.
5333 * ecore.cs, expression.cs, statement.cs: Update.
5335 2006-07-22 Raja R Harinath <harinath@gmail.com>
5337 * statement.cs (Block.ResolveMeta): Simplify slightly.
5339 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
5340 multiple boolean fields. Convert InUnsafe, constant_check_state,
5341 check_state to flags.
5342 (CheckState, ConstantCheckState): Update.
5343 (InUnsafe): New read-only property.
5344 (FlagsHandle): Rename from CheckStateHandle and convert to handle
5346 (WithUnsafe): New helper similar to WithCheckState.
5347 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
5348 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
5350 2006-07-21 Raja R Harinath <rharinath@novell.com>
5352 Make comparisons use the same IL irrespective of whether they're
5353 in a 'checked' or 'unchecked' context: one of the issues in #78899
5354 * codegen.cs (EmitContext.CheckState): Make read-only property.
5355 (EmitContext.ConstantCheckState): Likewise.
5356 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
5357 helper that implement a save/restore stack for CheckState
5358 values. This is the only way to change check-state.
5359 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
5360 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
5361 (CheckedExpr.EmitBranchable): New forwarding method.
5362 (UnCheckedExpr): Likewise.
5363 * statement.cs (Block.ResolveMeta): Use WithCheckState.
5364 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
5365 (Checked.Resolve, checked.DoEmit): Likewise.
5367 2006-07-20 Miguel de Icaza <miguel@novell.com>
5369 * anonymous.cs: Cache the resolved anonymous delegate, and return
5370 this so that the ResolveTopBlock is only triggered once, not
5373 Currently we trigger ResolvetopBlock twice due to a first pass of
5374 argument check compatibility, and a second pass that does the
5377 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5379 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
5381 * rootcontext.cs (Reset): Add helper_classes.
5383 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5386 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
5389 2006-07-13 Miguel de Icaza <miguel@novell.com>
5391 * statement.cs (Lock): Handle expressions of type
5392 TypeManager.null_type specially. Fixes #78770
5394 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5396 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
5399 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5401 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
5402 for accessors as well.
5403 * ecore.cs (EventExpr): Add AccessorTable.
5405 2006-07-01 Marek Safar <marek.safar@seznam.cz>
5408 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
5409 for CS0122 where appropriate.
5410 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
5412 (Filter): Assembly can be null in the case of top level attributes.
5414 2006-06-25 Marek Safar <marek.safar@seznam.cz>
5418 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
5419 is done at global level.
5421 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5423 A fix for #77002, Implemented TypeForwarder support.
5425 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
5426 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
5427 * typemanager.cs (): Add type_forwarder_attr_type.
5429 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5431 * report.cs: Add CS0469 warning.
5433 2006-06-21 Martin Baulig <martin@ximian.com>
5435 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
5436 the `try'-block, so we also report CS0016 etc. there.
5438 2006-06-21 Martin Baulig <martin@ximian.com>
5441 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
5443 2006-06-21 Martin Baulig <martin@ximian.com>
5445 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
5446 also report CS1686 for parameters.
5448 2006-06-21 Martin Baulig <martin@ximian.com>
5450 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
5451 instead of an error if the value is not implicitly convertible to
5452 the switch types; fixes #77964.
5454 2006-06-21 Raja R Harinath <rharinath@novell.com>
5457 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
5458 FieldBuilder is null.
5461 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
5462 'left' and 'right' before error-checking.
5464 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
5466 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
5468 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
5469 (FieldExpr.DoResolve): likewise.
5470 (PropertyExpr.InstanceResolve): likewise.
5471 (EventExpr.InstanceResolve): likewise.
5473 2006-06-04 Marek Safar <marek.safar@seznam.cz>
5475 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
5476 attribute applicable tests for attribute argument.
5478 2006-06-02 Raja R Harinath <rharinath@novell.com>
5481 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
5482 (Binary.OverloadResolve_PredefinedIntegral): New.
5483 (Binary.OverloadResolve_PredefinedFloating): New.
5484 (Binary.OverloadResolve_PredefinedString): New.
5485 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
5486 Follow the standard more closely, and treat numeric promotions in
5487 terms of overload resolution.
5488 (Binary.CheckShiftArguments): Simplify.
5490 2006-06-01 Raja R Harinath <rharinath@novell.com>
5492 * flowanalysis.cs (MyBitVector): Simplify representation.
5493 (MyBitVector.Clone): Avoid allocating BitArray.
5494 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
5495 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
5496 (*): Update. Change all references to MyBitVector.And and
5497 MyBitVector.Or to &= and |=.
5499 2006-05-29 Raja R Harinath <rharinath@novell.com>
5502 * cs-parser.jay (formal_parameter_list): Extend the pattern below
5503 to param arguments too.
5505 2006-05-26 Miguel de Icaza <miguel@novell.com>
5507 * cs-parser.jay: Catch another parsing form for arglist being
5508 followed by other arguments. Fixes #78313.
5510 2006-05-24 Raja R Harinath <rharinath@novell.com>
5512 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
5513 checking of out parameters to ...
5514 (FlowBranchingToplevel.Merge): ... here.
5515 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
5516 set, propagate the origin upward, and only complain if there was
5518 (FlowBranchingException.AddContinueOrigin): Likewise.
5519 (FlowBranchingException.AddReturnOrigin): Likewise.
5520 (FlowBranchingException.AddGotoOrigin): Likewise.
5522 2006-05-23 Raja R Harinath <rharinath@novell.com>
5524 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
5525 unreachable, skip it.
5526 (FlowBranchingException.Merge): Always propagate jumps, even if
5527 the finally block renders subsequent code unreachable.
5529 2006-05-18 Raja R Harinath <rharinath@novell.com>
5532 * statement.cs (Goto.Resolve): Move responsibility for resolving
5533 'goto' to FlowBranching.AddGotoOrigin.
5534 (Goto.SetResolvedTarget): New. Callback to set the
5535 LabeledStatement that's the target of the goto.
5536 (Goto.DoEmit): Use Leave instead of Br when crossing an
5537 unwind-protect boundary.
5538 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
5539 LookupLabel and adjust to new semantics.
5540 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
5541 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
5542 Goto.SetResolvedTarget to update target.
5543 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
5544 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
5545 AddBreakOrigin & co. Delay propagation until ...
5546 (FlowBranchingException.Merge): ... this.
5548 * statement.cs (Block.Resolve): Always depend on flow-branching to
5549 determine unreachability. Kill workaround that originally emitted
5550 only one statement after an "unreachable" label (see infloop in
5553 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
5554 This is still "wrong", but anything better would probably need a
5555 multi-pass algorithm.
5556 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
5557 usage vector. Force current usage vector to be reachable, to
5558 optimistically signify backward jumps.
5559 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
5561 (FlowBranchingLabeled.Merge): New. If no backward jump was
5562 detected, return the original salted-away usage vector instead,
5563 updated with appropriate changes. Print unreachable warning if
5565 * statement.cs (Block.Resolve): Don't print unreachable warning on
5566 a labeled statement.
5568 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
5570 * driver.cs: Pass filename without path to AssemblyBuilder's
5571 AddResourceFile. Fixes bug #78407.
5573 2006-05-17 Raja R Harinath <rharinath@novell.com>
5575 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
5576 * flowanalysis.cs (FlowBranchingLabeled): ... here.
5577 (FlowBranching.MergeChild): Overwrite
5578 reachability information from Labeled branchings too.
5580 2006-05-16 Raja R Harinath <rharinath@novell.com>
5582 * statement.cs (Goto.Resolve): Merge jump origins here ...
5583 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
5585 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
5586 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
5587 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
5588 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
5590 * statement.cs (Goto.Resolve): ... not here.
5591 (Goto.Emit): Remove CS1632 check.
5593 2006-05-14 Marek Safar <marek.safar@seznam.cz>
5595 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
5598 2006-05-11 Raja R Harinath <rharinath@novell.com>
5600 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
5601 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
5602 (FlowBranchingException.Label): Likewise.
5604 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
5606 (MyBitVector.Or): Use it to avoid losing information (Count).
5607 (FlowBranching.MergeOrigins): Likewise.
5609 * flowanalysis.cs (UsageVector.IsDirty): Remove.
5610 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
5611 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
5612 (UsageVector.ToString): Simplify.
5613 (UsageVector.MergeSiblings): Move here from ...
5614 (FlowBranching.Merge): ... here.
5615 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
5618 2006-05-10 Raja R Harinath <rharinath@novell.com>
5620 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
5621 null bitvector is treated as all-true.
5623 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
5624 (MyBitVector): Rationalize invariants. 'vector != null' implies
5625 that we have our own copy of the bitvector. Otherwise,
5626 'InheritsFrom == null' implies all inherited bits are true.
5628 2006-05-09 Marek Safar <marek.safar@seznam.cz>
5630 * statement.cs (LocalInfo): Add IsConstant.
5631 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
5632 local variable for constants.
5634 2006-05-09 Raja R Harinath <rharinath@novell.com>
5636 * flowanalysis.cs (MyBitVector.Empty): New.
5637 (MyBitVector): Don't allow InheritedFrom to be null.
5638 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
5639 (UsageVector, FlowBranching): Update to changes.
5641 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
5642 recursion. The 'Parent == null' condition isn't sufficient for
5644 (FlowBranching.AddBreakOrigin): Likewise.
5645 (FlowBranching.AddContinueOrigin): Likewise.
5646 (FlowBranching.AddReturnOrigin): Likewise.
5647 (FlowBranching.StealFinallyClauses): Likewise.
5648 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
5649 (FlowBranching.CheckOutParameters): Likewise.
5650 (FlowBranchingToplevel): Terminate all the above recursions here.
5651 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
5652 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
5654 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
5656 (FlowBranchingToplevel): New. Empty for now.
5657 (FlowBranching.MergeTopBlock): Update.
5658 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
5659 branching for the anonymous delegate.
5660 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
5662 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
5663 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
5664 information at the start of the merge. Reorganize.
5666 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5668 * class.cs (MethodData.Define): Method cannot implement interface accessor.
5670 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5672 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
5673 to newly introduced ctor.
5675 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
5676 message to one place.
5677 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
5680 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5682 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
5684 * ecore.cs (Expression.ResolveAsConstant): Updated.
5686 * statement.cs (ResolveMeta): Updated.
5688 2006-05-06 Marek Safar <marek.safar@seznam.cz>
5690 * cs-parser.jay: __arglist cannot be used in initializer.
5692 2006-05-06 Marek Safar <marek.safar@seznam.cz>
5695 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
5698 2006-05-05 Raja R Harinath <rharinath@novell.com>
5700 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
5701 (LabeledStatement): Add 'name' parameter.
5702 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
5703 (Block.AddLabel): Update to changes.
5704 * cs-parser.jay (labeled_statement): Likewise.
5706 * flowanalysis.cs (BranchingType.Labeled): New.
5707 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
5708 (FlowBranchingLabeled): New. Does nothing for now, but will
5709 eventually handle 'goto' flows.
5710 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
5711 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
5712 that's terminated ...
5713 (Block.Resolve): ... here.
5715 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
5716 (UsageVector.MergeFinallyOrigins): Likewise.
5717 (FlowBranching.InTryOrCatch): Likewise.
5718 (FlowBranching.AddFinallyVector): Likewise.
5719 (FlowBranchingException): Update to changes.
5722 * statement.cs (Return.Resolve): Move error checking to ...
5723 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
5724 (FlowBranchingException): Handle return origins like break and
5726 (FlowBranching.UsageVector.CheckOutParameters): Remove.
5728 2006-05-04 Marek Safar <marek.safar@seznam.cz>
5731 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
5734 2006-05-04 Marek Safar <marek.safar@seznam.cz>
5737 * class.cs (MethodData.Define): Do public accessor check only when method
5738 implements an interface.
5740 2006-05-04 Raja R Harinath <rharinath@novell.com>
5742 Remove special handling of 'break'
5743 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
5744 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
5745 (UsageVector.Break): Remove.
5746 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
5748 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
5750 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
5751 UsageVector.Breaks (). Don't set NeedsReturnLabel.
5753 2006-05-03 Marek Safar <marek.safar@seznam.cz>
5756 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
5757 be the interface member.
5759 2006-05-03 Marek Safar <marek.safar@seznam.cz>
5762 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
5763 for emitting small (int) values.
5765 2006-05-03 Raja R Harinath <rharinath@novell.com>
5768 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
5769 control-flow passes through the 'finally' after merging-in all the
5770 control-flows from 'try' and the 'catch' clauses.
5772 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
5773 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
5774 always true at the only non-recursive entry point.
5775 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
5776 FlowBranchingBreakable.
5777 (FlowBranchingLoop): Remove.
5778 * statement.cs (Return.DoResolve): Update to changes.
5781 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
5782 (FlowBranching.CreateBranching): Handle it: create a
5783 FlowBranchingContinuable.
5784 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
5785 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
5786 except that it handles the 'continue' command.
5787 (FlowBranching.UsageVector.MergeOrigins): Rename from
5789 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
5790 except that it overrides AddContinueOrigin.
5791 (FlowBranchingException): Override AddContinueOrigin, similar to
5793 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
5794 Create a new branching around the embedded statement.
5795 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
5796 control flow after the embedded statement.
5797 (Continue.Resolve): Move all error checking to AddContinueOrigin.
5799 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
5800 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
5801 FlowBranchingBreakable.
5802 (FlowBranchingSwitch): Remove.
5805 * statement.cs (Break.Resolve): Simplify. Move responsibility for
5806 error reporting to ...
5807 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
5808 Rename from 'AddBreakVector'. Add new location argument. Return
5809 a bool indicating whether the 'break' crosses an unwind-protect.
5810 (FlowBranchingException.AddBreakOrigin): Add.
5811 (FlowBranchingException.Merge): Propagate 'break's to surrounding
5812 flowbranching after updating with the effects of the 'finally'
5814 (FlowBranchingBreakable): New common base class for
5815 FlowBranchingLoop and FlowBranchingSwitch.
5817 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
5819 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
5821 2006-05-02 Raja R Harinath <rharinath@novell.com>
5823 * statement.cs (Do.Resolve): If the loop is infinite, set the
5825 (While.Resolve, For.Resolve): Set a barrier after the embedded
5826 statement. There's no direct control flow that goes from the end
5827 of the embedded statement to the end of the loop.
5828 * flowanalysis.cs (FlowBranching.Infinite): Remove.
5829 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
5830 above ensure that the reachability is correctly computed.
5832 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
5833 (UsageVector.MergeBreakOrigins): If the current path is
5834 unreachable, treat it as if all parameters/locals are initialized.
5835 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
5836 infinite loops before merging-in break origins.
5838 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
5839 (Reachability.Reachable): Split part into ...
5840 (Reachability.Unreachable): ... this. Simplify.
5841 (Reachability.IsUnreachable): Use 'Unreachable' instead.
5843 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
5844 (Reachability.SetThrowsSometimes): Likewise.
5845 (FlowBranchingBlock.MergeTopBlock): Don't compare against
5846 TriState.Always, use corresponding property.
5847 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
5848 (Block.Resolve): Likewise. Remove some redundant checks.
5850 2006-05-02 Raja R Harinath <harinath@gmail.com>
5852 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
5853 (Reachability.Meet): Don't bother checking AlwaysThrows --
5854 barrier is always set.
5855 (FlowBranchingBlock.Merge): Likewise.
5857 2006-05-01 Raja R Harinath <harinath@gmail.com>
5859 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
5860 checks for unreachable.
5862 2006-05-01 Marek Safar <marek.safar@seznam.cz>
5865 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
5867 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
5868 whether field is really assigned.
5870 2006-04-30 Raja R Harinath <harinath@gmail.com>
5872 * flowanalysis.cs (Reachability): Make 4-argument constructor
5874 (Reachability.Meet): Rename from 'And'. Remove static variant.
5875 (Reachability.Always): Rename from the highly misleading
5876 'Reachability.Never'.
5877 (FlowBranching.Merge): Update to changes. Mark an impossible
5878 situation with a 'throw'.
5879 (*): Update to changes.
5881 2006-04-29 Raja R Harinath <harinath@gmail.com>
5883 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
5885 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
5886 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
5887 (*): Update to changes.
5888 * statement.cs: Update to changes.
5890 2006-04-28 Marek Safar <marek.safar@seznam.cz>
5893 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
5895 2006-04-28 Raja R Harinath <harinath@gmail.com>
5897 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
5900 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
5901 argument to two arguments: an usage-vector and a bool. Move call
5902 to FlowBranching.Merge () ...
5903 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
5905 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
5906 handling of loop and switch reachability to ...
5907 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
5909 2006-04-27 Raja R Harinath <harinath@gmail.com>
5911 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
5912 handling to FlowBranchingLoop.InLoop.
5913 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
5915 2006-04-26 Marek Safar <marek.safar@seznam.cz>
5918 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
5919 anonymous method is allowed from AnonymousContainer here.
5921 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
5923 2006-04-24 Raja R Harinath <rharinath@novell.com>
5926 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
5928 2006-04-23 Marek Safar <marek.safar@seznam.cz>
5931 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
5932 (DoubleConstant.Reduce): Ditto.
5934 2006-04-23 Raja R Harinath <rharinath@novell.com>
5936 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
5937 Remove 'lvalue_right_side' argument. Move parts to ...
5938 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
5939 (LocalVariable.DoResolveLValue): ... these.
5941 2006-04-21 Raja R Harinath <rharinath@novell.com>
5944 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
5945 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
5946 (LocalVariableReference.DoResolveBase): Use it to implement new
5948 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
5949 (Argument.Resolve): Simplify. Move CS1510 check ...
5950 * ecore.cs (Expression.ResolveLValue): ... here.
5951 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
5952 (PropertyExpr.DoResolveLValue): Likewise.
5953 (FieldExpr.Report_AssignToReadonly): Likewise.
5954 (FieldExpr.DoResolve): Add 'out_access' argument. Use
5955 LValueMemberAccess or LValueMemberOutAccess on instance depending
5957 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
5958 DoResolve as appropriate.
5960 2006-04-20 Raja R Harinath <rharinath@novell.com>
5963 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
5964 implicit conversions on 'out' and 'ref' arguments.
5966 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
5967 improve clarity. Remove dead code.
5970 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
5971 (Catch.Resolve): Resolve VarBlock if it exists.
5973 2006-04-19 Miguel de Icaza <miguel@novell.com>
5975 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
5976 twice, this was some residual code, the enumerator was emitted
5977 properly in the two branche of if later.
5979 2006-04-19 Raja R Harinath <rharinath@novell.com>
5981 * expression.cs (Cast.ResolveLValue): Remove. The result of a
5982 cast is never an lvalue.
5983 (Cast.DoResolve, Cast.ResolveRest): Combine.
5984 (Argument.Emit): Simplify slightly. Move 'Expr is
5985 IMemoryLocation' check ...
5986 (Argument.Resolve): ... here.
5987 (Argument.Error_LValueRequired): Remove. Inline into only user.
5989 Simplifications. Fix cs0191-2.cs
5990 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
5991 CS1649 and CS1651 to ...
5992 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
5993 the actual selection of the error code and message to a lookup
5994 table. Add a dummy return value to simplify callsites.
5995 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
5996 readonly fields of other instances of the same type. Move CS0197
5998 * expression.cs (Argument.Resolve): ... here. Simplify code.
5999 Ensure that ec.InRefOutArgumentResolving is only set during LValue
6000 resolution of an out or ref argument. The code simplification
6001 above uses this invariant.
6003 2006-04-18 Raja R Harinath <rharinath@novell.com>
6005 Possibly fix #77752. Fix cs1690-[4-7].cs.
6006 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
6007 CheckMarshallByRefAccess. Drop parameter.
6008 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
6010 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
6012 * report.cs (AllWarnings): Add CS1690.
6013 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
6015 (LocalVariableReference.DoResolveBase): Update.
6017 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6019 * class.cs (MethodOrOperator): Moved common parts from method class.
6020 detect obsolete attributes.
6021 (Method.Define): Simplified as it reuses code from base.
6022 (Constructor.ValidAttributeTargets): Fixed issue found during
6024 (Destructor.ValidAttributeTargets): Fixed issue found during
6026 (Operator): Finished refactoring set off by #78020. Operator class is now
6027 ordinary method class.
6029 * anonymous.cs: Updated.
6031 * decl.cs (DeclSpace): Add IsGeneric
6033 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6035 * class.cs (Constructor.Emit): Don't emit the attributes twice.
6037 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6039 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
6040 detect obsolete attributes.
6041 (Method.CreateEmitContext): Moved to MethodOrOperator.
6043 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6046 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
6047 customized exception to make crash detection easier.
6048 (MethodOrOperator): Started to work on new base class for methods and
6050 (Method): Derives from MethodOrOperator.
6051 (Constructor.Emit): Emits its own attributes.
6052 (AbstractPropertyEventMethod.Emit): Ditto.
6053 (Operator): Derives from MethodOrOperator, will refactor fully in extra
6055 (Operator.Emit): It's temporary more tricky than should be.
6057 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
6059 * report.cs (InternalErrorException): Add ctor with inner exception.
6061 2006-04-08 Marek Safar <marek.safar@seznam.cz>
6064 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
6067 2006-04-07 Marek Safar <marek.safar@seznam.cz>
6070 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
6073 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6075 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
6076 attribute is present and Guid not.
6077 (Interface.ApplyAttributeBuilder): Ditto.
6079 * attribute.cs: Add error message.
6081 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6085 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
6086 sources (it's composite) so hold them in extra array as they are used in
6087 Emit phase only. It worked in the previous versions by mistake.
6088 (Attribute.Emit): Emit attribute for more owners when exist.
6090 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
6091 it has now different behaviour.
6093 2006-04-04 Marek Safar <marek.safar@seznam.cz>
6095 * constant.cs (Constant.IsDefaultInitializer): New method.
6097 * class.cs: Updated.
6099 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
6100 re-initialize default values. It saves KBs almost for every assembly.
6101 Thanks Zoltan for the idea.
6102 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
6103 (ArrayCreation.DoResolve): Resolve only once.
6104 (ArrayCreation.Emit): Emit static initializer only when it is faster.
6105 (ArrayCreation.GetAttributableValue): Cope with optimized values.
6107 2006-04-03 Zoltan Varga <vargaz@gmail.com>
6109 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
6112 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6114 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
6115 in an embedded statement too.
6117 2006-04-01 Raja R Harinath <rharinath@novell.com>
6120 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
6122 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6126 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
6129 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
6131 2006-03-31 Marek Safar <marek.safar@seznam.cz>
6133 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
6136 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
6137 LocalTemporary change.
6139 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
6141 (ClassOrStruct.DefineFieldInitializers): Implemented static field
6142 initializers optimization.
6143 (ClassOrStruct.TypeAttr): Moved from modifiers.
6144 (Constructor.CheckBase): Don't crash when static ctor has parameters.
6145 (FieldBase.ResolveInitializer): Resolves initializer.
6146 (FieldBase.HasDefaultInitializer): New property.
6148 * cs-parser.jay: Removed message.
6150 * expression.cs (CompilerGeneratedThis): New specialization.
6152 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
6154 2006-03-28 Marek Safar <marek.safar@seznam.cz>
6156 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
6158 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6160 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
6161 be now EnumConstants only.
6163 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6165 * attribute.cs, driver.cs: Reset more caches.
6167 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6169 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
6171 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6173 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
6174 for easier reuse. Updated all overrides.
6175 (IntegralConstant): New base class for all integral constants.
6176 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
6177 of the constant range, report custom error.
6178 (UIntConstant.Reduce): Fixed uint conversion.
6180 * ecore.cs, literal.cs: Reduce updates.
6182 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6186 * class.cs (Constructor.Define): Removed extra if for default ctors.
6187 A patch from Atsushi Enomoto.
6189 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6191 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
6192 GetAttributableValue.
6194 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
6197 * convert.cs (ImplicitConversionRequired): Error message moved to
6200 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
6201 automatic implicit conversion of an output value.
6202 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
6204 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
6206 (TypeOf.GetAttributableValue): Add extra handling for object type.
6208 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
6209 special error message.
6211 2006-03-25 Marek Safar <marek.safar@seznam.cz>
6213 * class.cs (Constructor.Emit): Don't crash when struct ctor is
6215 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
6216 compatible with MS runtime.
6218 2006-03-23 Marek Safar <marek.safar@seznam.cz>
6220 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
6221 attribute arguments here.
6223 * class.cs (Indexer.Define): The check was moved to attribute class.
6225 2006-03-22 Marek Safar <marek.safar@seznam.cz>
6227 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
6228 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
6231 2006-03-22 Raja R Harinath <rharinath@novell.com>
6233 Support ParameterDefaultValueAttribute in gmcs. Also applied to
6234 mcs to keep code differences small.
6235 * attribute.cs (Attribute.GetParameterDefaultValue): New.
6236 * typemanager.cs (parameter_default_value_attribute_type): New.
6237 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
6240 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6242 * expression.cs (StringConcat.Append): Reverted back to no warning state.
6244 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6246 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
6248 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
6251 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
6253 * doc-bootstrap.cs : fix build.
6255 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6257 * expression.cs (StringConcat.Append): Issue a warning when empty string
6260 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6262 * assign.cs (CompoundAssign.ResolveSource): Removed.
6264 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
6267 * class.cs (TypeContainer.FindMethods): Removed.
6268 (TypeContainer.CheckMemberUsage): Made static.
6270 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
6272 * constant.cs (CheckRange): Removed unused type argument.
6273 (CheckUnsigned): Removed unused type argument.
6275 * cs-parser.jay: Updated after MemberAccess clean up.
6276 Uses Length for empty string test.
6278 * cs-tokenizer.cs: Uses Length for empty string test.
6279 (IsCastToken): Made static.
6280 (is_hex): Made static.
6281 (real_type_suffix): Made static.
6283 * decl.cs (SetupCache): Made static.
6284 (OnGenerateDocComment): Removed unused ds argument.
6286 * delegate.cs (VerifyDelegate): Removed unused argument.
6288 * doc.cs: Uses Length for empty string test.
6290 * driver.cs: Uses Length for empty string test.
6292 * enum.cs (IsValidEnumType): Made static
6294 * expression.cs (EnumLiftUp): Removed unused argument.
6295 (ResolveMethodGroup): Ditto.
6296 (BetterConversion): Ditto.
6297 (GetVarargsTypes): Ditto.
6298 (UpdateIndices): Ditto.
6299 (ValidateInitializers): Ditto.
6300 (MemberAccess.ctor): Ditto.
6301 (GetIndexersForType): Ditto.
6303 * flowanalysis.cs: (MergeFinally): Removed unused argument.
6305 * iterators.cs: Updated after MemberAccess clean up.
6307 * location.cs: Uses Length for empty string test.
6309 * namespace.cs: Uses Length for empty string test.
6311 * report.cs (CheckWarningCode): Made static.
6313 * statement.cs (LabeledStatement): Removed unused argument.
6315 * typemanager.cs (FilterNone): Removed.
6317 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6319 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
6322 * class.cs: Updated.
6324 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6326 * cs-parser.jay.cs: __arglist is not allowed for delegates.
6328 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6332 * expression.cs (VerifyArgumentsCompat): Reverted to double error
6333 reporting, it's more tricky than I thought.
6335 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6339 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
6341 (AnonymousMethod.ImplicitStandardConversionExists): New method.
6342 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
6343 Add more error reporting; Fixed issue with params.
6345 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
6347 * cs-parser.jay: AnonymousMethod requires host container.
6349 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
6351 2006-03-18 Raja R Harinath <harinath@gmail.com>
6353 * class.cs: Change 'TypeContainer ds' constructor argument to
6354 'DeclSpace parent'. Some classes were missed below due to
6355 different naming convention.
6357 * class.cs (MemberCore.Parent): Delete. This makes the
6358 ParentContainer changes below enforceable by the compiler.
6360 Treat pointers to enclosing declaration space as 'DeclSpace', not
6362 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
6363 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
6365 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
6367 (Block.AddThisVariable): Likewise.
6368 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
6369 (AbstractPropertyEventMethod.Emit): Likewise.
6370 (AbstractPropertyEventMethod.EmitMethod): Likewise.
6371 (GetMethod.Define, SetMethod.Define): Likewise.
6372 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
6373 (DelegateMethod.EmitMethod): Likewise.
6375 Fix regression test-partial-13.cs.
6376 Rationalize use of PartialContainer. Ensure that the partial
6377 class semantics can be tied to type-correctness, i.e., any
6378 violation will cause a compile error.
6379 * class.cs, const.cs: Access all fields that belong to class
6380 TypeContainer via ParentContainer. Arguments of EmitContexts and
6381 Resolve()-like functions still use 'Parent'.
6383 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
6384 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
6385 (PropertyMethod.CheckModifiers): Remove unused argument.
6386 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
6389 2006-03-17 Raja R Harinath <harinath@gmail.com>
6391 Make semantics of PartialContainer simpler.
6392 * decl.cs (DeclSpace.IsPartial): Remove.
6393 * class.cs (TypeContainer.IsPartial): Likewise.
6394 (TypeContainer..ctor): Set PartialContainer to point to self.
6395 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
6396 (TypeContainer.FindNestedType): Likewise.
6397 (MemberCore.ParentContainer): Simplify. Remove deprecation.
6399 2006-03-17 Marek Safar <marek.safar@seznam.cz>
6401 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
6403 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6405 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
6408 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6410 * class.cs (Operator.Define): An error for base conversion was not
6413 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
6415 * iterator.cs : yield break is allowed in try statement which has
6416 catch clauses. Fixed bug #77767.
6418 2006-03-13 Marek Safar <marek.safar@seznam.cz>
6420 A fix for #77593, #77574.
6422 * class.cs (MethodCore.CheckBase): Another if for operator.
6424 2006-03-09 Marek Safar <marek.safar@seznam.cz>
6426 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
6429 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
6430 (DelegateCreation.ImplicitStandardConversionExists): New method for just
6433 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
6436 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
6437 Updated after another emitcontext usage was clean up. It should help us to
6438 synchronize with gmcs easier.
6440 2006-03-04 Marek Safar <marek.safar@seznam.cz>
6444 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
6445 (Event.Define): ditto
6446 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
6448 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
6449 Removed redundant code and set NewSlot for Invoke method too.
6451 * parameter.cs (Parameters.ctor): Add custom, type ctor.
6452 (Parameters.MergeGenerated): New method. Use this method when you merge
6453 compiler generated argument with user arguments.
6455 2006-03-03 Marek Safar <marek.safar@seznam.cz>
6457 * attribute.cs (ResolveAsTypeTerminal): Removed.
6459 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
6460 specialization for predefined types; 30% speed up.
6461 Finally placed obsolete check to right place.
6462 (Expression.ResolveType): Removed.
6464 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
6465 Updated after ResolveType was removed.
6467 * expression.cs (Cast.ctor): Check void cast.
6468 (Binary.ResolveAsTypeTerminal): Is never type.
6469 (Conditional.ResolveAsTypeTerminal): Is never type.
6471 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
6473 2006-03-01 Raja R Harinath <rharinath@novell.com>
6476 * expression.cs (ParameterReference.DoResolveBase): Change return
6478 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
6482 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
6485 * typemanager.cs (GetFullNameSignature): Don't nullref on
6486 protected accessors.
6488 2006-02-27 Marek Safar <marek.safar@seznam.cz>
6490 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
6491 these two separated members to simplify the code.
6492 (Attribute.Resolve): Refactored to use new fields and methods.
6493 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
6494 implemented obsolete attribute checking.
6495 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
6496 implemented obsolete checking again. It look line never ending quest ;-)
6497 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
6499 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
6501 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
6503 *class.cs (Property.Define): Add RegisterProperty call.
6505 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
6506 argument groups (only 2).
6508 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
6509 encoding expression to arguments.
6510 (Expression.ExprClassToResolveFlags): Just turned to property.
6512 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
6513 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
6514 optimized as well as implemented support for zero-length attributes.
6516 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
6517 Add caching of PropertyInfo's.
6519 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6521 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
6522 error multiple times.
6524 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6526 New partial class implementation.
6527 A fix for #77027, #77029, #77403
6529 * attribute.cs (Attributable): Made attributes protected.
6531 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
6532 the replacements of ClassPart and PartialContainer.
6533 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
6534 (TypeContainer.AddInterface): Ditto.
6535 (TypeContainer.AddPartial): The main method for partial classes. It checks
6536 for errors and merges ModFlags and attributes. At the end class is added to
6538 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
6540 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
6541 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
6542 from the rest of partial classes.
6543 (TypeContainer.GetClassBases): Simplified.
6544 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
6546 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
6547 (TypeContainer.HasExplicitLayout): Uses Flags now.
6548 (PartialContainer): Removed.
6549 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
6550 (StaticClass): Was merged with Class.
6551 (Class.GetClassBases): class and static class bases are verified here.
6552 (Class.TypeAttr): Added static attributes when class is static.
6553 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
6554 (MemberBase): In some cases we need to call parent container for partial
6555 class. It should be eliminated but it's not easy now.
6557 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
6559 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
6560 partial classed to accumulate class comments.
6561 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
6563 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
6565 * driver.cs (MainDriver): Tree.GetDecl was removed.
6567 * modifiers.cs (Modifiers): Add partial modifier.
6569 * tree.cs (Tree.decl): Removed.
6570 (RootTypes): Started to use this class more often for root types
6573 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6577 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
6578 external interface does not have an attribute.
6580 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6582 Another prerequisites for new partial classs implementation.
6584 * attribute.cs (Attribute.Equal): Implemented.
6585 (Attribute.Emit): Changed as attributes can be applied more than twice.
6586 (Attributes.Emit): Check for duplicate attributes here.
6588 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
6589 as a parameter, clean-up.
6591 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6595 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
6596 contains obsolete attribute check which can in some cases look for base
6597 type of current class which is not initialized yet.
6598 (TypeContainer.BaseType): Replacement of ptype.
6600 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
6602 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6604 First of prerequisites for new partial classs implemention.
6606 * attribute.cs (Attributable): Extended by ResolveContext;
6607 Attributes finally have correct context for resolving in all cases.
6608 (AttachTo): Attribute owner is assigned here.
6610 * codegen.cs (IResolveContext): Introduce new interface to hold
6611 all information needed in resolving phase.
6612 (EmitContext): Implements IResolveContext; more clean-up needed here.
6614 * decl.cs (MemberCore): Implemented IResolveContext.
6616 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
6617 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
6618 parameter.cs, statement.cs, tree.cs, typemanager.cs:
6619 Refactored to use new IResolveContext instead of EmitContext; cleanup
6621 2006-02-06 Miguel de Icaza <miguel@novell.com>
6623 * codegen.cs (EmitScopeInitFromBlock): check here the
6624 capture_context, there is no need to make two calls to the
6627 * anonymous.cs: Add some debugging messages that might help me
6628 track other instances of this problem in the future (the
6629 regression of test 467).
6631 * cs-parser.jay: track the variable block, as we need to initalize
6632 any captured variables declared in this block for the "catch"
6633 portion of the "Try" statement.
6635 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
6636 scope initialization for captured variables.
6638 Also, move the emit for the variables after the block location has
6641 2006-02-06 Marek Safar <marek.safar@seznam.cz>
6643 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
6645 2006-02-02 Miguel de Icaza <miguel@novell.com>
6647 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
6648 commit yesterday, the initialization for the roots is necessary.
6649 What is not necessary is the scope activation.
6651 2006-02-02 Raja R Harinath <rharinath@novell.com>
6653 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
6654 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
6656 (Argument.Resolve): Remove CS0206 checks.
6658 2006-02-01 Miguel de Icaza <miguel@novell.com>
6660 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
6661 scopes for all the roots, the scopes will now be emitted when the
6662 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
6664 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
6665 code. This reduces a lot of existing cruft.
6667 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
6668 that the ScopeInfo is generated as we enter the scope, not at the
6669 time of use, which is what we used to do before.
6671 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
6672 every time a Block is about to be emitted if we have a
6675 2006-02-01 Raja R Harinath <rharinath@novell.com>
6677 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
6679 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
6681 * typemanager.cs (cons_param_array_attribute): Make private.
6682 (Reset): Set it to null.
6683 (InitCoreHelpers): Don't initialize it.
6684 (ConsParamArrayAttribute): New. Initialize it as needed.
6685 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
6687 2006-01-31 Miguel de Icaza <miguel@novell.com>
6689 * expression.cs: There might be errors reported during the
6690 selection of applicable methods. If there are errors, do not
6691 continue execution as it will lead the compiler to crash.
6693 2006-01-30 Miguel de Icaza <miguel@novell.com>
6695 * expression.cs: Member access is not allowed on anonymous
6696 methods. Fixes #77402.
6698 2006-01-30 Raja R Harinath <rharinath@novell.com>
6701 * cs-parser.jay (VariableDeclaration): Don't set
6702 current_array_type to null.
6703 (field_declaration, event_declaration, declaration_statement):
6704 Set it to null here.
6706 2006-01-28 Raja R Harinath <harinath@gmail.com>
6708 * typemanager.cs (GenericParameterPosition): New.
6711 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
6713 * doc.cs : To process "include" elements, first we should create
6714 another list than XmlNodeList, because it could result in node
6715 removal, which could result in that the XmlNodeList gives up
6718 (Also made code identical to gmcs again.)
6720 2006-01-25 Miguel de Icaza <miguel@novell.com>
6722 * ecore.cs: Introduce an error report that we were not catching
6723 before, if not silent, we must report the error. Gonzalo ran into
6726 2006-01-23 Miguel de Icaza <miguel@novell.com>
6728 A fix for bug: #76957
6730 * iterators.cs (MoveNextMethod.CreateMethodHost): call
6731 ComputeMethodHost before creating the method, this is a new
6734 * anonymous.cs (AnonymousContainer): Now we track all the scopes
6735 that this method references (RegisterScope). The actual scope
6736 where the method is hosted is computed with the ComputeMethodHost
6737 before we create the method.
6739 Moved the Deepest routine here.
6741 (AnonymousContainer.ComputeMethodHost): New routine used to
6742 compute the proper ScopeInfo that will host the anonymous method.
6744 (ScopeInfo): Deal with multiple roots. The problem was that we
6745 did not have a unique root where all ScopeInfos could be hanged
6746 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
6749 Remove AdjustMethodScope which is now computed at the end. Remove
6750 LinkScope which did a partial link, instead link all ScopeInfos
6751 before code generation from the new "LinkScopes" routine.
6753 Simplify all the Add* routines as they no longer need to maintain
6754 the tree, they just need to record that they are using variables
6757 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
6758 routines to produce the forest of ScopeInfo trees.
6760 * class.cs (TypeContainer.AppendMethod): This is just like
6761 AddMethod, but ensures that an interface implementation method
6762 (IEnumerable.XXX) is not inserted at the beginning of the queue of
6763 methods, but at the end.
6765 We use this functionality to ensure that the generated MoveNext
6766 method in the iterator class is resolved/emitted before the
6767 enumerator methods created.
6769 This is required because the MoveNext method computes the right
6770 ScopeInfo for the method. And the other methods will eventually
6771 need to resolve and fetch information computed from the anonymous
6774 2006-01-21 Raja R Harinath <harinath@gmail.com>
6775 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6778 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
6780 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
6781 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
6783 2006-01-18 Raja R Harinath <rharinath@novell.com>
6785 Fix #76656, cs0231-2.cs.
6786 * cs-parser.jay (formal_parameter_list): Make error case catch
6788 (parenthesized_expression_0): Add CS1026 check.
6789 (invocation_expression): Remove unused { $$ = lexer.Location }.
6791 2006-01-17 Raja R Harinath <rharinath@novell.com>
6794 * cs-parser.jay (statement_expression): Don't list out the
6795 individual statement-expressions. Convert syntax error into
6798 2006-01-16 Raja R Harinath <rharinath@novell.com>
6801 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
6802 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
6803 CheckIntermediateModification.
6804 (FieldExpr.DoResolve): Add new two-argument version that
6805 allows us to resolve the InstanceExpression as an lvalue.
6806 The one-argument variant is now just a wrapper.
6807 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
6808 Resolve the lhs as an lvalue if the it has a value type.
6809 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
6810 from Assign.DoResolve.
6811 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
6812 resolved as an lvalue.
6813 (PropertyExpr.DoResolve): Update.
6814 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
6815 has a value type. Move CS1612 check here from
6816 CheckIntermediateModification.
6817 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
6818 * expression.cs (EmptyExpression.OutAccess): New. Used as the
6819 'right_side' of a ResolveLValue on an 'out' argument.
6820 (EmptyExpression.LValueMemberAccess): New. Used as the
6821 'right_side' of a propagated ResolveLValue on a value type.
6822 (LocalVariableReference.DoResolveBase): Recognize
6823 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
6825 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
6826 EmptyExpression.Null.
6828 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
6830 * typemanager.cs : added IsGenericParameter(). In mcs it always
6832 * doc.cs : for generic parameters, use GenericParameterPosition,
6835 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
6837 * expression.cs: Fix Console.WriteLine ((this = x).foo);
6839 2006-01-12 Miguel de Icaza <miguel@novell.com>
6841 This fixes the problem where we used ldfld instead of ldflda to
6842 load the "THIS" pointer on captured parameters, when THIS is a
6843 value type. See bug #77205.
6845 * iterators.cs (CapturedThisReference.Emit): Pass false to
6846 EmitThis (we do not need the address).
6848 * codegen.cs (EmitThis): it needs to know whether we need the
6849 address of `this' or not. This is used by value types.
6851 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
6852 every other call passes false.
6854 2006-01-12 Raja R Harinath <rharinath@novell.com>
6857 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
6859 * expression.cs (Invocation.OverloadResolve): Update.
6860 (Invocation.DoResolve): Avoid double resolution of invocation.
6862 2006-01-11 Raja R Harinath <rharinath@novell.com>
6865 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
6866 unary negation of floating point types as 0-expr; negation cannot
6867 overflow in floating point types.
6870 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
6871 on operands of 'void' type.
6874 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
6875 and ExclusiveOr for boolean constants too.
6877 2006-01-09 Raja R Harinath <rharinath@novell.com>
6880 * expression.cs (Invocation.OverloadResolve): Replace reflected
6881 override methods with their base virtual methods, rather than
6883 * typemanager.cs (TypeManager.GetOverride): New.
6885 2006-01-05 Jb Evain <jbevain@gmail.com>
6887 * class.cs (Property.Define, Indexer.Define): do not tag the
6888 properties as SpecialName | RTSpecialName.
6890 2006-01-04 Miguel de Icaza <miguel@novell.com>
6892 * class.cs (MethodCore.IsDuplicateImplementation): This method was
6893 doing a low-level comparission of parameter types. It was lacking
6894 a check for __argslist.
6896 2005-12-30 Miguel de Icaza <miguel@novell.com>
6898 * expression.cs (ParameterReference.DoResolveBase): Allow
6899 reference parameters if they are local to this block.
6901 This allows the ref and out parameters of a delegate to be used in
6902 an anonymous method, for example:
6904 delegate void set (out int x);
6906 set s = delegate (out int x){
6910 This is used by functionality introduced late in the C# language.
6912 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
6913 method that take ref and out parameters.
6915 Fixes #77119 which was a late change in the spec.
6917 2005-12-23 Miguel de Icaza <miguel@novell.com>
6919 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
6920 parent if its the same scope. Fixes #77060.
6922 2005-12-21 Miguel de Icaza <miguel@novell.com>
6924 * driver.cs: Report the case of no source files and no -out:
6927 2005-12-20 Raja R Harinath <rharinath@novell.com>
6930 * expression.cs (ComposedCast.GetSignatureForError): Define.
6932 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6936 * namespace.cs (NamespaceEntry): Add extern_aliases as a
6937 ListDictionary, to contain the ExternAliasEntry entries (in
6938 addition to the NamespaceEntry.aliases hashtable). This field is
6939 shared between the original entry and its doppelganger (bodyless
6941 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
6942 extern_aliases field.
6943 (NamespaceEntry.Lookup): Move the IsImplicit check after the
6944 lookup in extern_aliases.
6946 2005-12-16 Raja R Harinath <rharinath@novell.com>
6949 * class.cs (TypeContainer.Mark_HasEquals): New.
6950 (TypeContainer.Mark_HasGetHashCode): New.
6951 (ClassPart): Override them.
6952 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
6955 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
6956 'parent' argument to the base constructor.
6958 Remove all mention of TypeContainer from decl.cs.
6959 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
6960 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
6961 (DeclSpace.DeclSpace): Likewise.
6962 (DeclSpace.DefineMembers): Remove unused argument.
6963 * cs-parser.jay (pop_current_class): Update to changes. Simplify
6964 debugging check -- we don't care if the debug code throws an
6965 InvalidCastException instead of an InternalErrorException.
6966 * class.cs (TypeContainer.DefineMembers): Update to changes.
6967 (TypeContainer.DoDefineMembers): Likewise.
6968 (TypeContainer.GetMethods): Likewise.
6969 (PropertyMember.Define): Likewise.
6970 (MemberBase.Parent): New property that forwards to
6971 MemberCore.Parent, but ensures that we get a TypeContainer.
6972 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
6973 (RootContext.PopulateTypes): Likewise. Remove special case code
6974 for !RootContext.StdLib: DefineMembers is idempotent.
6976 2005-12-14 Miguel de Icaza <miguel@novell.com>
6978 * convert.cs (ExplicitConversionCore): Check the return value from
6979 ExplicitConversionCore which can return null on failure. Fixes #76914
6981 2005-12-13 Marek Safar <marek.safar@seznam.cz>
6983 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
6985 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
6987 * doc.cs : The search for referenced namespace was insufficient to
6988 get global one as it used to do. Fixed bug #76965.
6990 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
6992 * doc.cs : check name in cref in the last phase that whether it is
6995 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
6997 * cs-tokenizer.cs : reverted the latest change: it somehow broke
7000 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7002 * doc.cs : so it turned out that we cannot skip override check for
7003 interface members. Fixed bug #76954.
7005 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7007 * cs-tokenizer.cs : fixed bug #75984:
7008 - #warning and #error should not be handled when the source line
7010 - #line is not checked strictly when the source line is disabled.
7011 - #define and #undef is on the other hand checked strictly at any
7014 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
7016 * cs-tokenizer.cs : missing Location (actually, filename) in one of
7019 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7021 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
7023 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
7025 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
7026 (FieldBase.Initializer): Initializer is now optional.
7027 (EventField.Define): Only event field can have initializer.
7029 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
7031 * const.cs (Const): Reuse initializer.
7033 * cs-parser.jay: Updated after FieldBase changes.
7034 Added current_array_type to simplify array initializers.
7036 * ecore.cs (NullCast.IsDefaultValue): Implemented.
7038 * expression.cs, iterators.cs: Updated.
7040 * namespace.cs (NamespaceEntry): Made UsingFound private.
7042 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7044 * parameterCollection.cs: Obsolete, removed.
7045 * parser.cs: Obsolete, removed.
7047 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7050 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
7052 * enum.cs (Enum.Define): Set obsolete context here.
7054 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
7057 - FindDocumentedMember() now expects 1) paramList as null
7058 when "we don't have to check the number of parameters" and
7059 2) Type.EmptyTypes when "there is no arguments".
7060 - Introduced FoundMember struct to hold the exact type which was
7061 used to find the documented member (the above change broke
7062 test-xml-044; it might be better just to use DeclaringType than
7063 what MS does, like this change does, but it depends on usage.)
7065 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
7067 * doc.cs : documented member might be from DeclaringType for nested
7068 types. Fixed bug #76782.
7070 2005-12-03 Ben Maurer <bmaurer@ximian.com>
7072 * anonymous.cs: Have the param code handle leaving copies on the
7073 stack etc. Allows anonymous params to take part in the assignment
7074 code (++, +=, etc). Fixes bug #76550
7076 * expression.cs: Handle the prepare_for_load/leave_copy by passing
7077 it down to the anon code.
7079 * iterators.cs: Use dummy var here
7081 * codegen.cs: Handle new vars
7083 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7086 * class.cs (MethodData.Define): Set proper Obsolete context.
7088 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
7090 (FieldExpr.DoResolve): Ditto.
7092 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7095 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
7096 parent is not obsolete.
7098 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
7100 * doc.cs : (FindDocumentedMember) find parameterless members first
7101 and get CS0419 in the early stage. Fixed first case of bug #76727.
7103 2005-11-30 Marek Safar <marek.safar@seznam.cz>
7106 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
7107 no error was reported.
7109 *expression.cs (Binary.DoResolve): left can be null.
7111 2005-11-22 Marek Safar <marek.safar@seznam.cz>
7114 * class.cs (MethodData.Emit): Parameters should be labeled first.
7116 2005-11-21 Marek Safar <marek.safar@seznam.cz>
7119 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
7121 2005-11-18 Marek Safar <marek.safar@seznam.cz>
7123 * attribute.cs (AreParametersCompliant): Moved to Parameter.
7125 * class.cs (MethodCore): Parameter clean up.
7126 (IMethodData): Added ParameterInfo.
7127 (MethodData): Parameter clean up.
7128 (Indexer.Define): Parameter clean up.
7140 * typemanager.cs: Parameter clean up.
7142 * delegate.cs (Define): Get rid of duplicated code.
7144 * expression.cs (ParameterReference): Removed useless parameters
7146 (Invocation): Ditto.
7148 * parameter.cs (ParamsParameter): New class, params specialization.
7149 (ArglistParameter): Attemp to separate arglist.
7150 (Parameter): Refactored to be reusable and faster.
7151 (Parameter.Modifier): Made understandable.
7152 (Parameters): Changed to be used as a class for `this' assembly
7153 parameters. Refactored to use new specialized classes.
7155 * support.cs (ParameterData): Added Types property.
7156 (InternalParameters): Deleted.
7158 2005-08-20 Martin Baulig <martin@ximian.com>
7160 Merging this patch from GMCS to fix #75867.
7162 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7163 scope if we don't already have it.
7165 2005-11-17 Martin Baulig <martin@ximian.com>
7168 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
7169 inherit the scope from our parent. Fixes #76653.
7171 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7173 * doc.cs : the previous patch does not actually fix the bug.
7174 PropertyInfo override check is now implemented and really fixed it.
7175 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
7177 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7179 * doc.cs : apply "override filter" also to properties.
7182 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7184 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
7185 no need to check overrides. For classes, omit those results from
7186 interfaces since they must exist in the class. Fixed bug #76726.
7188 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7190 * typemanager.cs : (GetFullNameSignature) differentiate indexers
7191 with different parameters. Fixed the second problem in #76685.
7193 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7195 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
7196 get expected 'protected' access in CheckValidFamilyAccess()).
7199 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7201 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
7202 Fixed bug #76705. CS1569 was incorrectly commented out.
7204 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7206 * doc.cs : use Invocation.IsOverride() to do real override check.
7207 * expression.cs : made Invocation.IsOverride() internal.
7209 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7211 * doc.cs : use TypeManager.FindMembers() instead of (possible)
7212 TypeBuilder.FindMembers() and filter overriden base members out.
7215 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7217 * doc.cs : ref/out parameters are represented as '@' (instead of
7218 '&' in type FullName). Fixed bug #76630 (additionally crefs).
7220 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7222 * doc.cs : when there was no '.' in cref to methods in doc comment,
7223 then parameters were missing in the output. Fixed bug #76691.
7225 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7227 * driver.cs : don't output docs when there is an error.
7230 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7233 Now it should detect indexers. Fixed primary concern in bug #76685.
7234 Fixed CS0419 message to not show the identical member signature in
7237 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7239 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
7240 instead of Type.FindMembers() since it does not handle events.
7243 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
7245 * codegen.cs: Fixed typo (speficied -> specified).
7247 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7250 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
7252 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7254 * attribute.cs: Changed error message.
7256 * cs-tokenizer.cs: One more check.
7258 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7260 * statement.cs (Block.Resolve): Ignore empty statement.
7262 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7264 * report.cs: Made error/warning methods more strict to avoid
7267 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
7268 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
7269 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
7270 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
7272 2005-11-08 Marek Safar <marek.safar@seznam.cz>
7274 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
7275 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
7277 * class.cs (TypeContainer.IsComImport): New property.
7278 (Constructor.Define): Create proper ctor for ComImport types.
7280 * expression.cs (New.CheckComImport): Fixed.
7282 2005-11-07 Miguel de Icaza <miguel@novell.com>
7284 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
7285 that a parameter has been captured does not mean that we do not
7286 have to do the rest of the processing. This fixes the second part
7287 of #76592. If there was another anonymous method capturing
7288 values in the past, the Scope would never be set for the second
7289 method that captured the same parameter.
7291 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
7292 properly manipulate the stack. Second part of fix for #76592.
7294 * expression.cs (New): Add support for invoking "new" on
7295 interfaces that have been flagged with the ComImport attribute and
7296 the CoClass. Fixes #76637
7298 * statement.cs (Try.DoEmit): When a variable is captured, do not
7299 try to emit the vi.LocalBuilder variable as it has been captured.
7300 Create a temporary variable and store the results on the
7301 FieldBuilder. Fixes #76642
7303 2005-11-07 Marek Safar <marek.safar@seznam.cz>
7305 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
7307 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
7309 * expression.cs (Binary.DoResolve): Added && optimalization.
7311 * typemanager.cs (AddUserType): Removed useless argument.
7313 2005-11-04 Marek Safar <marek.safar@seznam.cz>
7315 * statement.cs (Block.variables): Uses ListDictionary.
7317 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7320 * class.cs (PartialContainer.EmitType): Customized to emit
7321 security attributes.
7322 (ClassPart.ApplyAttributeBuilder): Transform security attribute
7323 for partial classes.
7325 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7328 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
7329 access has to be fixed.
7331 * typemanager.cs (IsUnmanagedType): Wrong common field type.
7333 2005-11-01 Marek Safar <marek.safar@seznam.cz>
7336 * ecore.cs (NullCast.Reduce): Implemented.
7338 * expression.cs (ArrayCreation.CheckIndices): Correcly check
7341 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
7343 (Foreach.Resolve): Catch null properly.
7345 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7347 * cs-tokenizer.cs: Warning text fix.
7349 * driver.cs: AllWarningNumbers exposed on public interface.
7351 * report.cs (): Reviewed warning numbers.
7352 (IsValidWarning): Use binary search.
7354 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7356 * driver.cs: Implemeted resource visibility.
7357 (Resources): New class for code sharing between /res: and
7360 2005-10-28 Marek Safar <marek.safar@seznam.cz>
7363 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
7366 * convert (Convert.ImplicitReferenceConversion): NullCast holds
7369 * ecore.cs (NullCast): Child is contant only.
7371 * literal.cs (NullLiteral.Reduce): null can be converted to any
7374 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
7376 * driver.cs: Use Encoding.Default as default code page instead
7379 2005-10-27 Raja R Harinath <rharinath@novell.com>
7382 * expression.cs (Invocation.Error_InvalidArguments): Handle
7383 __arglist parameters.
7384 (Invocation.VerifyArgumentsCompat): Likewise.
7385 * support.cs (ReflectionParameters.GetSignatureForError): Print
7386 __arglist parameters.
7387 (InternalParamters.GetSignatureForError): Likewise.
7388 * parameter.cs (Parameters.GetSignatureForError): Likewise.
7390 2005-10-26 Marek Safar <marek.safar@seznam.cz>
7392 * attribute.cs (GetPropertyValue): Made public.
7394 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
7396 Add new property WrapNonExceptionThrows to handle 2.0 assembly
7398 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
7401 * driver.cs: Reflect method name change.
7403 * statement.cs (Try.Resolve): Warn when try has both general
7406 * typemanager.cs: runtime_compatibility_attr_type new predefined
7409 2005-10-26 Raja R Harinath <harinath@gmail.com>
7412 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
7413 treat it as an empty parameter list.
7415 2005-10-26 Raja R Harinath <rharinath@novell.com>
7418 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
7419 ResolveAsTypeStep silent.
7420 * statement.cs (Block.AddConstant): Mark block as used.
7421 (Block.ResolveMeta): Avoid piling on error messages
7422 if a constant initializer resolution fails.
7424 2005-10-25 Raja R Harinath <rharinath@novell.com>
7426 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
7428 (NamespaceEntry.VerifyAllUsing): New.
7429 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
7430 behaviour. Delegates actual resolution of alias to ...
7431 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
7432 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
7434 * driver.cs (Driver.MainDriver): Update.
7436 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
7437 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
7439 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
7441 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
7442 RootNamespace.DefineNamespacesForAll.
7444 2005-10-24 Raja R Harinath <harinath@gmail.com>
7446 * typemanager.cs (assemblies, external_aliases, modules)
7447 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
7448 (ComputeNamespaces, GetRootNamespace): Remove extra staging
7449 overhead. Move resposibility ...
7450 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
7451 * driver.cs, attribute.cs, codegen.cs: Update to changes.
7453 2005-10-23 Raja R Harinath <harinath@gmail.com>
7455 * namespace.cs (RootNamespace.all_namespaces): Renamed from
7456 cached_namespaces. Improve usage.
7457 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
7458 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
7459 Move from GlobalRootNamespace and simplify.
7460 (RootNamespace.Global): Make instance variable.
7461 (RootNamespace.RootNamespace): Add "alias name" parameter.
7462 (GlobalRootNamespace): Simplify drastically.
7463 (Namespace.Lookup): Don't use GetNamespace.
7464 * typemanager.cs (GetRootNamespace): Rename from
7465 ComputeNamespaceForAlias.
7466 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
7468 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7470 * anonymous.cs (AnonymousContainer): Don't crash when container
7473 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7475 * expression.cs (Binary.DoResolve): Warn when comparing same
7478 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7481 * expression.cs (Binary.DoResolve): It looks like there are no
7482 convetsion rules in enum context.
7484 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7486 Add support for extern alias qualifiers.
7487 * typemanager.cs: Move some LookupTypeReflection code
7488 to namespace.cs, to have cleaner code. Added some methods
7489 to help us keep track of the extern aliased references.
7490 * driver.cs: Add suport for extern alias assemblies on command
7491 line and check for their warnings/errors. Also keep track of the
7492 extern aliased assemblies.
7493 * namespace.cs: Move the global functionality of Namespace
7494 to GlobalRootNamespace/RootNamespace. Now the global namespace
7495 is GlobalRootNamespace.Globa. Also the code moved from
7496 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
7497 Finally added LocalAliasEntry (AliasEntry before) and
7498 ExternAliasEntry, to handle alias statements.
7499 * cs-parser.jay: Add support in the grammar for extern alias
7501 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
7502 Update callings to Namespace (now in GlobalRootNamespace).
7504 2005-10-18 Raja R Harinath <rharinath@novell.com>
7507 * class.cs (TypeContainer.DefineType): Move updating of
7508 topological sort earlier in the code.
7509 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
7511 2005-10-18 Marek Safar <marek.safar@seznam.cz>
7514 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
7516 * constant.cs (Constant.TryReduce): Moved from Cast class.
7517 (Reduce): Made little bit more OO and fixed missing conversions.
7519 * ecore.cs (Reduce): Implemented.
7520 (Binary.EnumLiftUp): New method to upgrade values to enum values.
7522 * literal.cs (Reduce): Implemented.
7524 * class.cs: Reverted Miguel's wrong commit.
7526 2005-10-14 Miguel de Icaza <miguel@novell.com>
7528 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
7530 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
7532 * cs-parser.jay, expression.cs : CS0214 was missing error location
7533 for constants. Fixed bug #76404.
7535 2005-10-11 Marek Safar <marek.safar@seznam.cz>
7538 * convert.cs (ExplicitConversionCore): Fixed object->enum
7541 2005-10-10 Raja R Harinath <rharinath@novell.com>
7543 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
7545 (PropertyExpr.EmitCall): Likewise.
7546 * expression.cs (Invocation.EmitArguments): Handle case where
7548 (Invocation.EmitCall): Avoid allocating temporary variable if
7549 there are no arguments.
7551 2005-10-07 Raja R Harinath <rharinath@novell.com>
7554 * convert.cs (ImplicitConversionStandard): Move conversion of
7555 void* to arbitrary pointer types ...
7556 (ExplicitConversionStandard): .. here.
7557 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
7558 error to always print typenames.
7560 2005-10-07 Raja R Harinath <rharinath@novell.com>
7562 * convert.cs (GetConversionOperator): Rename from
7563 GetConversionOperators. Move operator selection code from ...
7564 (UserDefinedConversion): ... here.
7566 2005-10-06 Marek Safar <marek.safar@seznam.cz>
7568 * convert.cs (ExplicitConversionCore): Removed duplicate enum
7571 2005-10-05 Marek Safar <marek.safar@seznam.cz>
7573 * assign.cs (Assign.DoResolve): Error method changed.
7575 * cfold.cs (DoConstantNumericPromotions): Error method changed.
7577 * const.cs (ResolveValue): Reset in_transit immediately.
7579 * constant.cs: Error method changed.
7581 * convert.cs: Removed useless location parameter.
7582 (ExplicitNumericConversion): Don't do double enum check.
7583 (ExplicitConversionCore): Renamed from ExplicitConversion.
7584 (ExplicitUnsafe): Extracted from ExplicitConversion.
7585 (ExplicitConversion): Uses for error reporting.
7587 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
7589 (ResolveBoolean): Uses common error method.
7590 (CastToDecimal): Get rid of ec.
7591 (CastFromDecimal): Optimized.
7592 (ConvCast): Get rid of ec.
7594 * enum.cs (ResolveValue): Reset in_transit immediately.
7595 (Emit): Return after first error.
7597 * expression.cs: Convert changes.
7599 * literal.cs: Error method changed.
7601 * statement.cs: Error method changed.
7603 2005-10-03 Raja R Harinath <rharinath@novell.com>
7605 * support.cs (SeekableStreamReader.Position): Don't error out when
7606 the requested position is just beyond the end of the current
7609 2005-09-28 Raja R Harinath <rharinath@novell.com>
7611 * support.cs (SeekableStreamReader): Simplify drastically. Don't
7612 try to keep in sync with the byte count of the underlying Stream.
7613 However, this limits us to a window size of 2048 characters: i.e.,
7614 the maximum lookahead of our lexer/parser can be 2048 characters.
7616 2005-09-28 Marek Safar <marek.safar@seznam.cz>
7619 * driver.cs: Fix compilation files with full root path.
7621 2005-09-25 Miguel de Icaza <miguel@novell.com>
7623 * report.cs (SymbolRelatedToPreviousError): Format the output so
7624 it does not use an open parenthesis that is never closed.
7626 * driver.cs: Follow coding guidelines
7628 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7631 * const.cs (Const.ResolveValue): Check for assigning non-null
7632 value to reference type.
7634 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7636 * anonymous.cs: Implemented ExprClassName.
7638 * assign.cs (Assign.DoResolve): Don't chrash when type is not
7641 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
7644 * class.cs (StaticClass.DefineContainerMembers): Report protected
7647 * codegen.cs: if(ed) PRODUCTION.
7649 * convert.cs (Error_CannotImplicitConversion): Better error
7652 * cs-parser.jay: More error checks.
7654 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
7656 * driver.cs (CSCParseOption): Enabled wrong option check.
7658 * ecore.cs (Expression.ExprClassName): Turned to property.
7659 (MemberExpr.CheckIntermediateModification): For checking boxed
7660 value types modification.
7662 * statement.cs (Fixed.Resolve): Expression type must be
7663 convertible to fixed type.
7664 (CollectionForeach.GetEnumeratorFilter,TryType):
7665 Small refactoring for easier error checking.
7667 2005-09-26 Marek Safar <marek.safar@seznam.cz>
7669 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
7672 * class.cs (GeneratedBaseInitializer): New class for customization
7673 compiler generated initializers.
7674 (MemberBase.DoDefine): Check Obsolete attribute here.
7675 (FieldMember.DoDefine): Ditto.
7677 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
7680 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
7681 (MemberCore.GetObsoleteAttribute): Removed argument.
7682 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
7683 (MemberCore.CheckObsoleteType): New helper.
7687 * statement.cs: Updates after MemberCore changes.
7689 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
7690 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
7692 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
7693 obsolete attribute for compiler construct.
7694 (As.DoResolve): Cache result.
7696 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
7698 2005-09-26 Raja R Harinath <rharinath@novell.com>
7701 * expression.cs (This.VerifyFixed): In a value type T, the type of
7702 'this' is T&, iow, 'this' is either an out or ref parameter. In a
7703 value type R, 'this' is treated as a value parameter.
7705 2005-09-22 Miguel de Icaza <miguel@novell.com>
7707 * statement.cs (Lock): Use the TemporaryVariable class instead of
7708 manually using local variables as those do not work when variables
7711 * ecore.cs: Moved the TemporaryVariable class from being a nested
7712 class inside Foreach to be a public class that can be employed in
7715 2005-09-19 Marek Safar <marek.safar@seznam.cz>
7717 * cs-parser.jay: interface_accessors replaced by
7718 accessor_declarations.
7720 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
7723 * statement.cs (GotoCase.Resolve): Convert null constant to
7725 (SwitchLabel.ResolveAndReduce): Ditto.
7726 (SwitchLabel.NullStringCase): Custom null stamp.
7727 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
7729 typemanager.cs (CSharpSignature): Don't skip first argument
7732 2005-09-18 Miguel de Icaza <miguel@novell.com>
7734 * driver.cs: Set InEmacs based on the environment variable EMACS.
7736 * location.cs (InEmacs): in this mode, do not report column
7737 location as it confuses Emacs.
7739 2005-09-16 Marek Safar <marek.safar@seznam.cz>
7741 * cfold.cs, constant.cs, convert.cs, ecore.cs,
7742 expression.cs, iterators.cs, literal.cs: Store constants and
7745 * class.cs (MemberBase.ShortName): Pass location.
7747 * cs-parser.jay: Some location fixes.
7749 * ecore.cs (Expression.Location): Made virtual.
7751 2005-09-05 Miguel de Icaza <miguel@novell.com>
7753 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
7754 if the underlying types are the same, otherwise we need to produce
7755 code that will do the proper cast.
7757 This was exposed by Marek's constant rewrite which produced
7758 invalid code for the call site:
7761 void Method (X v) {}
7765 This fixes test-49.cs
7767 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
7769 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
7770 Type/Object should be allowed as well. Fixed bug #75968.
7772 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
7774 * expression.cs : (Binary.DoResolve): when one is enum constant and
7775 another is constant 0, then return enum one *as enum type*.
7778 2005-09-02 Raja R Harinath <rharinath@novell.com>
7780 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
7784 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
7785 flow-branching for LocalVariableReferences in case we were invoked
7786 from a MemberAccess.
7787 * expression.cs (LocalVariableReference.VerifyAssigned): New.
7789 (LocalVariableReference.DoResolveBase): ... this.
7790 (MemberAccess.Resolve): Do the check that was disabled during
7793 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
7796 (PartialContainer.Create): check abstract/sealed/static strictly
7797 but abstract/sealed can exist only at one side. Fixed bug #75883.
7799 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
7802 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
7803 specified, don't default to UnmanagedType.I4.
7805 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
7807 * expression.cs : conditional operator should check possibly
7808 incorrect assign expression. Fixed bug #75946.
7810 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
7812 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
7813 Reverting the change. gmcs is much complex than mcs on this matter.
7815 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
7817 * cs-tokenizer.cs : To read another token ahead of the actual
7818 consumption, use new SavedToken and cache token instead of moving
7819 back the stream with SeekableStreamReader (it seemed problematic).
7821 driver.cs : Thus use StreamReader directly.
7822 * support.cs : Thus removed SeekableStreamReader.
7824 2005-08-30 Raja R Harinath <rharinath@novell.com>
7827 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
7828 (ScopeInfo.EmitScopeType): Use it to construct field names from
7829 names of captured locals.
7832 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
7833 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
7834 Pass 'target_type' to BoxedCast. Don't default to 'object'.
7835 (ExplicitConversion): Remove enum cases already handled by
7836 implicit conversion. Move implicit conversion check to the beginning.
7837 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
7838 * expression.cs (ArrayCreation.EmitDynamicInitializers):
7839 Don't treat System.Enum as a struct.
7841 2005-08-30 Jb Evain <jbevain@gmail.com>
7843 * attribute.cs: handles as expression in parameters.
7845 2005-08-30 Raja R Harinath <rharinath@novell.com>
7848 * class.cs (TypeContainer.VerifyClsName): Don't use a
7849 PartialContainer when verifying CLS compliance.
7850 (AbstractPropertyEventMethod): Set Parent here, ...
7851 (PropertyMethod): ... not here.
7853 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
7855 * attribute.cs : escaped attribute name should not be allowed to be
7856 resolved (e.g. @class as classAttribute). Fixed bug #75930.
7858 2005-08-29 Raja R Harinath <rharinath@novell.com>
7861 * convert.cs (ImplicitStandardConversionExists): Allow zero also
7862 when converting a long constant to unsigned long.
7863 * expression.cs (Invocation.OverloadResolve): Add sanity check to
7864 detect where IsApplicable and VerifyArgumentsCompat disagree.
7866 2005-08-29 Raja R Harinath <rharinath@novell.com>
7867 and Carlos Alberto Cortez <carlos@unixmexico.org>
7870 * class.cs (TypeContainer.CanElideInitializer): New helper.
7871 (TypeContainer.EmitFieldInitializers): Use it to determine if we
7872 can safely emitting the initializer of a field.
7874 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7876 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
7877 allowed inside a switch (without loop). Fixed bug #75433.
7879 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
7881 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
7882 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
7884 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7886 * driver.cs : kinda reverting the default encoding changes (not exact
7887 revert since I noticed that "codepage:reset" might not work fine).
7889 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7891 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
7892 Location. Now getter and setter store location correctly.
7893 (errors/cs0111-12.cs now reports the expected location.)
7895 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
7897 * driver.cs : Use default encoding on the environment.
7898 Removed (now that) extra parameter for SeekableStreamReader.
7899 * support.cs : (SeekableStreamReader) third .ctor() argument for
7900 StreamReader is not required (always true). preamble size could
7901 be acquired in simpler and safe way.
7903 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
7905 * cs-parser.jay: report CS0642 at warning level 3
7906 and report CS0642 for an if else statement also
7907 fixes bug #74745. Patch by John Luke (and a bit
7909 Removed extra CS0642 warning check for "while",
7911 * statement.cs: In Block.Resolve(), CS0642 check
7912 is reimplemented to check a sequence of an empty
7913 statement and a block.
7915 Both fix bug #66777.
7917 2005-08-24 Marek Safar <marek.safar@seznam.cz>
7919 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
7920 detection until I fix it.
7922 * cs-tokenizer.cs: Changed error message.
7924 * cs-parser.jay: Fixed 2 error locations.
7926 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
7927 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
7930 * enum.cs (GetSignatureForError): Fixed.
7932 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
7936 * typemanager.cs (RegisterProperty): Removed.
7938 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
7940 2005-08-24 Raja R Harinath <rharinath@novell.com>
7943 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
7944 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
7946 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7948 * expression.cs : tiny fix is required for not warning positive ulong.
7951 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7953 * expression.cs : add CS0652 check for constant and integral
7954 expression. Fixed bug #53974.
7956 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7958 * expression.cs : in DoNumericPromotions(), check if there is implicit
7959 conversion overload for string (to check CS0034). Fixed bug #52492.
7961 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7963 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
7965 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7967 * ecore.cs : report location when it is *not* Null.
7969 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
7975 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
7976 correctly. Fixed bug #75721.
7978 2005-08-23 Raja R Harinath <rharinath@novell.com>
7980 * support.cs (SeekableStreamReader.Position): Avoid an expensive
7981 loop that performs 'min (pos, char_count)'.
7984 * expression.cs (Unary.ResolveOperator): Don't discard implicit
7985 converted value in Operator.OnesComplement.
7987 2005-08-22 Ben Maurer <bmaurer@ximian.com>
7989 * anonymous.cs: If the anon method is pulled into a helper class,
7990 it needs to be `internal' not `private'. Fixes runtime behavior on
7993 2005-08-20 Martin Baulig <martin@ximian.com>
7995 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7996 scope if we don't already have it.
7998 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
7999 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
8002 2005-08-17 Marek Safar <marek.safar@seznam.cz>
8005 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
8008 2005-08-16 Marek Safar <marek.safar@seznam.cz>
8010 The big constants rewrite
8011 Fix #75746, #75685 and more
8012 As a side effect saved 1MB for MWF ;-)
8014 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
8015 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
8016 enum based for corlib compilation.
8018 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
8021 * class.cs (FixedField.Define): Use ResolveAsConstant.
8023 * const.cs (IConstant): Interface constants and enums.
8024 (Const.ResolveValue): New method for constant resolvning.
8025 (ExternalConstant): Constants from imported assemblies.
8027 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
8028 conversion; like enums.
8029 (Constant.ToType): Converts this constant to different type.
8030 (Constant.Increment): Adds 1.
8032 * convert.cs (ImplicitConversionRequired): Simplified.
8034 * cs-parser.jay: Create EnumMember directly.
8036 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
8038 * doc.cs (GenerateEnumDocComment): Removed.
8040 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
8041 (ConvertIntLiteral): Removed.
8042 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
8044 * enum.cs (EnumMember): Implement IConstant.
8045 (Enum.IsValidEnumConstant): Removed.
8046 (Enum.GetNextDefaultValue): Removed.
8047 (Enum.FindMembers): Updated.
8048 (Enum.GenerateDocComment): Iterate enum members.
8050 * expression.cs (Cast.TryReduce): Handle enums correctly.
8051 (New.Constantify): Made public.
8052 (MemberAccess.DoResolve): Removed contant specific if(s).
8054 * literal.cs (NullLiteral): Implement new abstract methods.
8056 * statement.cs (GotoCase.Resolve): Use new constant methods.
8057 (SwitchLabel.ResolveAndReduce): Use new constant methods.
8059 * typemanager.cs (LookupEnum): Removed.
8060 (IsEnumType): Fixed to work with corlib.
8061 (RegisterConstant): Removed.
8062 (LookupConstant): Removed.
8063 (GetConstant): Changed to work with IConstant.
8065 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
8067 * location.cs : Fixed overflown (>255) column number.
8069 2005-08-03 Raja R Harinath <rharinath@novell.com>
8071 First cut of the qualified-alias-member feature.
8072 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
8074 * cs-parser.jay (DOUBLE_COLON): New token.
8075 (namespace_or_type_name): Add rule for recognizing
8076 qualified-alias-members.
8077 (primary_expression): Likewise.
8078 (element_access): Allow QualifiedAliasMember as a possible
8079 type-bearing expression.
8080 (local_variable_type, local_variable_pointer_type): Likewise.
8081 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
8082 aliases in the current and enclosing namespace declarations.
8083 (NamespaceEntry.UsingAlias): Add CS0440 warning.
8084 * decl.cs (MemberName.is_double_colon): New.
8085 (MemberName.MemberName): Add new constructor for alias-member.
8086 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
8087 * expression.cs (QualifiedAliasMember): New expression type.
8089 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8091 * location.cs : it borked when no argument was specified.
8093 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8095 * location.cs : tiny ToString() format fix.
8097 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8099 * statement.cs : oops, it was missing.
8101 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8103 A set of fixes for precise line/column location.
8106 "token" field now holds a file/line "delta", a line number offset
8107 from the segment, and a column number. See also:
8108 http://lists.ximian.com/pipermail/mono-devel-list/2004-
8109 December/009508.html
8110 Removed static IsNull. Use instance IsNull property instead.
8112 For some tokens it stores Location. For Identifier it stores
8113 LocatedToken which is a pair of string name and location.
8114 Column numbers are adjusted only at getChar().
8116 Use Location.ToString() for reporting (it now contains column).
8118 Largely modified to use LocatedToken instead of
8119 string (IDENTIFIER), and to acquire Location from some tokens.
8120 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
8121 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
8123 Now MemberName holds Location. DeclSpace.ctor() receives Location
8124 as a parameter. Removed extra parameters to all derived classes.
8125 Replaced Location.IsNull() with instance property.
8126 * assign.cs, expression.cs :
8127 Added .ctor() overload that omits Location.
8129 Added "nameEscaped" flag that indicates the identifier was escaped
8130 in the source file. This fixes bug #57047.
8132 2005-08-02 Marek Safar <marek.safar@seznam.cz>
8134 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
8135 New method, looking for lo-case imported cls type.
8137 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
8140 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
8142 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
8144 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
8146 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
8148 Optimized to save 3.5 MB for SWF compilation.
8150 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8152 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
8153 (PartialContainer.Create): Moved logic AddToContainer.
8154 (PartialContainer.MarkForDuplicationCheck): Shares name.
8156 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
8159 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
8161 (Namespace.GetSignatureForError): New method.
8163 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
8164 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
8166 2005-08-01 Raja R Harinath <rharinath@novell.com>
8169 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
8170 member lookup rather than qualifier_type, since qualifier_type can
8173 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8175 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
8178 2005-07-31 Miguel de Icaza <miguel@novell.com>
8180 * statement.cs: Copy the local exception into the exception
8181 captured local. Fixes 75674
8183 2005-07-31 Raja R Harinath <harinath@gmail.com>
8186 * expression.cs (Invocation.OverloadResolve): Don't report error
8187 CS1501 if error CS1502 has been reported.
8188 (New.DoResolve): Delegate CS1501 reporting to
8189 Invocation.OverloadResolve.
8192 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
8193 invariant-meaning-in-block property in an enclosing block if
8196 2005-07-29 Marek Safar <marek.safar@seznam.cz>
8198 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
8199 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
8200 (Switch.CheckSwitch): Just save 50kb for SWF.
8202 2005-07-27 Martin Baulig <martin@ximian.com>
8204 * anonymous.cs (CaptureContext.AddField): Added
8205 `AnonymousContainer am' argument; compute its toplevel scope if
8206 it's not already computed. Fixes #75649.
8208 2005-07-26 Raja R Harinath <rharinath@novell.com>
8211 * class.cs (Constructor.Emit): Reset block to null if the block
8214 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8216 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
8218 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8220 * class.cs (MethodData.Define): Check whether accessor implementing
8221 interface is public.
8223 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
8225 2005-07-22 Marek Safar <marek.safar@seznam.cz>
8228 * namespace.cs (LookupType): Moved same type check to...
8230 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
8233 2005-07-21 Raja R Harinath <rharinath@novell.com>
8235 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
8236 already found a typebuilder.
8237 * class.cs (MethodCore.IsDuplicateImplementation): Compare
8238 MemberNames, not strings.
8240 * const.cs (Error_ExpressionMustBeConst):
8241 Rename from Error_EpressionMustBeConst.
8242 * const.cs, class.cs, statement.cd: Update.
8244 2005-07-21 Marek Safar <marek.safar@seznam.cz>
8248 * const.cs (Const.LookupConstantValue): Report missing contant expression
8250 (Error_EpressionMustBeConstant): Only one error method.
8252 * class.cs, statement.c: Updated.
8254 2005-07-20 Raja R Harinath <rharinath@novell.com>
8256 * statement.cs (Block.Flags): Add back HasVarargs.
8257 (Block.flags): Make protected.
8258 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
8260 * typemanager.cs (types, typecontainers, user_types): Remove.
8261 (UserTypes, TypeContainers): Likewise.
8262 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
8263 (CleanUp, Reset): Update.
8264 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
8265 (GetNestedType): Use Type.GetNestedType.
8266 (CoreLookupType): Take two arguments, the namespace and the
8267 basename of the type. Update to use the Namespace.Lookup
8269 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
8270 (RealMemberLookup): Use IsNestedChildOf instead of playing with
8271 string concatenation and substring matches.
8272 * class.cs, enum.cs, delegate.cs: Update to changes.
8274 2005-07-20 Marek Safar <marek.safar@seznam.cz>
8276 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
8277 Expression and made virtual.
8279 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
8280 (ImplicitStandardConversionExists): Fixed `byte' typo ?
8282 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
8284 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
8287 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
8290 2005-07-18 Marek Safar <marek.safar@seznam.cz>
8293 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
8294 AssemblyCultureAttribute is not used on executable.
8297 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
8299 2005-07-16 Raja R Harinath <rharinath@novell.com>
8302 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
8303 New. Reports CS0252/CS0253.
8304 Mostly taken from preliminary patch by Duncak Mak.
8305 (Binary.DoResolveOperator): Store results of operator lookup.
8306 Use them to detect if we need to warn about unintended reference
8309 2005-07-15 Raja R Harinath <rharinath@novell.com>
8312 * namespace.cs (Namespace.Lookup): Add back location parameter.
8313 (Namespace.LookupType): Add CS0436 report. Add location parameter.
8314 * delegate.cs, ecore.cs, expression.cs: Update to changes.
8316 * codegen.cs (EmitContext.DeclSpace): Make readonly.
8317 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
8318 (Namespace.LookupType): ... this.
8319 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
8321 * typemanager.cs (LookupTypeReflection): Remove buggy code that
8322 purported to handle pointers.
8323 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
8326 2005-07-15 Marek Safar <marek.safar@seznam.cz>
8328 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
8331 2005-07-15 Raja R Harinath <rharinath@novell.com>
8333 * namespace.cs (Namespace.Lookup): Drop location parameter.
8334 (NamespaceEntry.LookupAlias): Remove. Merge into ...
8335 (NamespaceEntry.Lookup): ... this.
8336 (NamespaceEntry.Error_AmbiguousTypeReference):
8337 Move here from DeclSpace.
8338 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
8340 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
8341 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
8342 Move to NamespaceEntry.
8343 * delegate.cs, expression.cs: Update to changes.
8345 2005-07-14 Marek Safar <marek.safar@seznam.cz>
8347 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
8348 CheckAttributeType and refactored.
8349 (Attribute.ResolvePossibleAttributeType): Changed to reuse
8350 ResolveAsTypeTerminal error handling.
8351 (ResolveAsTypeTerminal): Introduced because of global attributes extra
8353 (GetSignatureForError): Print errors in same way.
8356 * codegen.cs: Reflect attribute GetSignatureForError change.
8359 * expression.cs: Add silent parameter to ResolveAsTypeStep.
8361 * namespace.cs (UsingEntry): Refactored to make fields private.
8364 statement.cs: Error_UnexpectedKind has extra parameter.
8366 2005-07-14 Raja R Harinath <rharinath@novell.com>
8368 * ecore.cs (IAlias): Remove.
8369 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
8370 that implement the interface.
8371 * namespace.cs (Namespace): Likewise.
8372 (Namespace.declspaces): Renamed from 'defined_names'.
8373 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
8374 DeclSpace instead of an IAlias.
8375 * tree.cs (Tree.AddDecl): Update.
8377 2005-07-12 Raja R Harinath <rharinath@novell.com>
8379 * statement.cs (Block.Flags); Remove HasVarargs.
8380 (Block.HasVarargs): Move to ToplevelBlock.
8381 (Block.ThisVariable, Block.AddThisVariable): Likewise.
8382 (Block.Variables): Make protected. Initialize variable hashtable
8384 (Block.AddVariable): Update.
8385 (Block.Resolve): Update to changes.
8386 (ToplevelBlock.HasVarargs): New boolean.
8387 (ToplevelBlock.ThisVariable): Move here from Block.
8388 (ToplevelBlock.AddThisVariable): Likewise.
8389 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
8390 * expression.cs (This.ResolveBase): Update to changes.
8391 (ArglistAccess.DoResolve): Likewise.
8393 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8396 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
8398 * class.cs (TypeContainer.VerifyMembers): Distinguish between
8399 not used and not used & assigned.
8400 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
8402 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8405 * expression.cs (Is.DoResolve): null is never provided type.
8407 2005-07-08 Marek Safar <marek.safar@seznam.cz>
8410 * cs-parser.jay: Less strict event error rule to catch more errors.
8412 2005-07-08 Martin Baulig <martin@ximian.com>
8414 Fix test-iter-10.cs - distinguish whether we `yield' in a property
8415 gettter (allowed) or setter (not allowed).
8417 * class.cs (Accessor): Implement IIteratorContainer.
8418 (Accessor.Yields): New public field.
8419 (PropertyBase.PropertyMethod.Define): Handle iterators on a
8423 (get_accessor_declaration, set_accessor_declaration): Set the
8424 `yields' flag on the accessor, not the property.
8425 (property_declaration): Do the iterators check on a per-accessor
8426 basis and not for the whole property.
8428 2005-07-08 Martin Baulig <martin@ximian.com>
8430 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
8431 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
8433 2005-07-07 Marek Safar <marek.safar@seznam.cz>
8436 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
8437 (ExtractSecurityPermissionSet): Cope with self referencing security
8438 attributes properly.
8440 * driver.cs (SetOutputFile): Made public property OutputFile.
8442 2005-07-07 Raja R Harinath <rharinath@novell.com>
8445 * class.cs (TypeContainer.first_nonstatic_field): Rename from
8446 has_nonstatic_fields. Make into a FieldBase pointer.
8447 (TypeContainer.AddField): Add CS0282 check.
8448 (TypeContainer.EmitType): Update.
8450 2005-07-06 Miguel de Icaza <miguel@novell.com>
8452 * cs-tokenizer.cs (consume_identifier): Do not create strings to
8453 compare if they start with __.
8455 2005-07-06 Raja R Harinath <rharinath@novell.com>
8457 * statement.cs (Switch.SwitchGoverningType): Only look at
8458 UserCasts that don't need implicit standard conversions to one of
8459 the allowed switch types (Fixes test-322.cs).
8460 (LocalInfo.Resolve): Re-enable sanity-test.
8462 2005-07-06 Marek Safar <marek.safar@seznam.cz>
8464 * cs-tokenizer.cs (consume_identifier): Detect double undescores
8466 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
8468 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
8470 2005-07-06 Raja R Harinath <rharinath@novell.com>
8473 * ecore.cs (SimpleName.GetSignatureForError): Add.
8474 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
8475 (MemberAccess.GetSignatureForError): Add.
8477 2005-07-05 Marek Safar <marek.safar@seznam.cz>
8479 The big error and warning messages review.
8509 * typemanager.cs: Updated.
8511 * class.cs: (MethodCore.SetYields): Moved here to share.
8512 (PropertyMethod.Define): Moved iterator setup here.
8514 * iterators.cs: Add orig_method to have full access to parent
8517 2005-07-05 Raja R Harinath <rharinath@novell.com>
8519 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
8520 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
8521 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
8522 variable of struct type.
8523 * expression.cs (Unary.ResolveOperator): Update to change.
8524 (Indirection.VerifyFixed): Likewise.
8525 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
8526 (ParameterReference.VerifyFixed): Value parameters are fixed.
8527 (This.VerifyFixed): Treat 'this' as a value parameter.
8528 * statement.cs (LocalInfo.IsFixed): Remove.
8530 2005-07-01 Martin Baulig <martin@ximian.com>
8532 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
8533 `ec.EmitThis ()' to get the correct scope.
8535 2005-07-01 Martin Baulig <martin@ximian.com>
8537 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
8538 instance is a ParameterReference; fixes #75299.
8540 2005-07-01 Martin Baulig <martin@ximian.com>
8542 Reverted Marek's latest patch (r46725):
8543 - it contains structural changes which are neither mentioned in
8544 the ChangeLog nor explained anywhere; for example the additional
8545 argument of EmitContext's and Iterator's .ctor's and the
8546 TypeContainer.DefineMembers() change.
8547 - structural changes like this should go in in seperate patches
8548 and not be hidden in a huge patch which just seems to affect
8549 warnings and errors.
8550 a big and hard to understand patch.
8551 - it breaks iterators and causes regressions, for instance in
8554 2005-06-30 Raja R Harinath <rharinath@novell.com>
8557 * expression.cs (Indexers.map): Remove.
8558 (Indexers.Append): Filter out inaccessible setters and getters.
8559 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
8562 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
8564 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
8565 (FieldExpr.Emit, PropertyExpr.Emit): Update.
8566 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
8567 * expression.cs (Invocation.EmitCall): Add CS0120 check.
8569 2005-06-30 Marek Safar <marek.safar@seznam.cz>
8572 * class.cs (FieldBase.GetInitializerExpression): One more field
8575 2005-06-28 Miguel de Icaza <miguel@novell.com>
8577 * pending.cs: Do not define a proxy if the base method is virtual,
8578 it will be picked up by the runtime (bug 75270).
8580 2005-06-08 Martin Baulig <martin@ximian.com>
8582 The big Iterators rewrite :-)
8584 * iterators.cs: Rewrite this to use the anonymous methods framework.
8586 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
8587 before the TypeContainers; see 2test-21.cs.
8590 (TypeContainer.DefineType): Don't create a new EmitContext if we
8591 already have one (this only happens if we're an Iterator).
8592 (TypeContainer.Define): Also call Define() on all our iterators.
8593 (Method.CreateEmitContext): Added support for iterators.
8596 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
8597 (AnonymousContainer.CreateMethodHost): Moved here from
8598 AnonymousMethod and made abstract.
8599 (AnonymousContainer.CreateScopeType): New abstract method.
8600 (AnonymousContainer.IsIterator): New public property.
8601 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
8602 get the ScopeTypeBuilder rather than manually defining it here.
8603 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
8606 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
8607 before RootContext.DefineTypes().
8609 * codegen.cs (EmitContext.RemapToProxy): Removed.
8610 (EmitContext.CurrentAnonymousMethod): Changed type from
8611 AnonymousMethod -> AnonymousContainer.
8612 (EmitContext.ResolveTopBlock): Protect from being called twice.
8613 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
8614 (EmitContext.EmitThis): Removed the iterators hacks; use the
8615 anonymous methods framework for that.
8618 (ToplevelBlock.Container): Make this a property, not a field.
8619 (ToplevelBlock.ReParent): New public method; move the
8620 ToplevelBlock into a new container.
8621 (Foreach.TemporaryVariable): Simplify.
8623 2005-06-05 Martin Baulig <martin@ximian.com>
8625 * statement.cs (LocalInfo.CompilerGenerated): New flag.
8626 (Block.AddTemporaryVariable): New public method; creates a new
8627 `LocalInfo' for a temporary variable.
8628 (Block.EmitMeta): Create the LocalBuilders for all the temporary
8630 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
8631 non-iterator variables.
8633 2005-06-05 Martin Baulig <martin@ximian.com>
8635 * statement.cs (Foreach.TemporaryVariable): Create the
8636 LocalBuilder in the Emit phase and not in Resolve since in some
8637 situations, we don't have an ILGenerator during Resolve; see
8638 2test-19.cs for an example.
8640 2005-06-04 Martin Baulig <martin@ximian.com>
8642 **** Merged r45395 from GCS ****
8644 The big Foreach rewrite - Part II.
8646 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
8647 with `PropertyInfo ienumerator_getcurrent'.
8649 * codegen.cs (VariableStorage): Removed.
8652 (Foreach): Derive from Statement, not ExceptionStatement.
8653 (Foreach.CollectionForeach): New nested class. Moved all the code
8654 dealing with collection foreach here.
8655 (Foreach.ForeachHelperMethods): Removed.
8656 (Foreach.TemporaryVariable): Implement IMemoryLocation.
8658 2005-05-23 Martin Baulig <martin@ximian.com>
8660 * statement.cs (Try.DoResolve): Don't create a `finally' if we
8661 don't need to. Fix #75014.
8663 2005-05-20 Martin Baulig <martin@ximian.com>
8665 Merged r44808 from GMCS.
8667 * class.cs (TypeContainer.CircularDepException): Removed.
8668 (TypeContainer.DefineType): Removed the `InTransit' stuff.
8669 (TypeContainer.CheckRecursiveDefinition): Check for circular class
8670 (CS0146) and interface (CS0529) dependencies here.
8672 2005-06-21 Raja R Harinath <rharinath@novell.com>
8674 * expression.cs (Invocation.EmitCall): Fix initialization
8675 'this_call' to reflect current behaviour. Fix indentation.
8677 * convert.cs (FindMostEncompassedType): Add two trivial special
8678 cases (number_of_types == 0 || number_of_types == 1).
8679 (FindMostEncompasingType): Likewise.
8681 2005-06-17 Raja R Harinath <rharinath@novell.com>
8683 Some cleanups preparing for the fix of #75283.
8684 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
8686 (EventExpr.InstanceResolve): Likewise.
8687 (EventExpr.DoResolve): Remove redundant checks.
8689 2005-06-10 Duncan Mak <duncan@novell.com>
8691 * cs-tokenizer.cs (process_directives): New flag for controlling
8692 the processing of preprocessor directives.
8693 (x_token): After seeing a '#', return Token.NONE instead of going
8694 to handle_preprocessing_directive() when not processing
8695 directives. This avoids unnecessary processing during the token peek in
8700 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
8701 the existing error reporting methods instead of Report.Error.
8703 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
8704 after Raja's rewrite.
8706 2005-06-08 Miguel de Icaza <miguel@novell.com>
8708 * class.cs: Small fix.
8710 2005-06-08 Raja R Harinath <rharinath@novell.com>
8713 * class.cs (GetPartialBases): Fix return value check of
8716 2005-06-07 Raja R Harinath <rharinath@novell.com>
8718 Ensure that partial classes are registered in their enclosing
8719 namespace. Initial part of fix of #75160.
8720 * tree.cs (Tree.RecordDecl): Add new namespace argument.
8721 Register declspace with namespace here, not in
8722 DeclSpace.RecordDecl.
8723 * cs-parser.jay: Pass namespace to RecordDecl.
8724 * class.cs (PartialContainer.Create): Likewise.
8725 (ClassPart.DefineType): New sanity-check. Throws an exception if
8727 * decl.cs (Declspace.RecordDecl): Remove.
8728 * namespace.cs (NamespaceEntry.DefineName): Remove.
8730 2005-06-06 Marek Safar <marek.safar@seznam.cz>
8732 * rootcontext.cs: Reset TargetExt as well.
8734 2005-06-03 Raja R Harinath <rharinath@novell.com>
8736 * ecore.cs (Expression.Resolve): Emit CS0654 error when
8739 2005-06-02 Raja R Harinath <rharinath@novell.com>
8741 Fix #75080, cs0119.cs.
8742 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
8744 (Expression.Resolve): ... this. Use it. Remove bogus code
8745 allowing ExprClass.Type and ExprClass.Namespace for
8746 ResolveFlags.VariableOrValue.
8747 (Expression.Resolve) [1-argument variant]: Change default resolve
8748 flags based on language version.
8749 (Expression.Error_UnexpectedKind): Use a simple string array
8750 rather than an ArrayList.
8751 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
8753 (TypeOfVoid.DoResolve): Likewise.
8754 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
8755 flags argument -- it always has the same value.
8757 2005-05-31 Raja R Harinath <rharinath@novell.com>
8760 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
8761 Use it in the error message.
8762 * assign.cs, expression.cs, statement.cs: Update.
8764 2005-05-30 Raja R Harinath <rharinath@novell.com>
8767 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
8768 the "almostMatchedMember" case too.
8769 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
8770 that failed the accessibility checks to 'almost_match'.
8772 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
8774 * attribute.cs: Use internal MethodBuilder methods to set
8775 ExactSpelling and SetLastError on PInvoke methods, instead
8776 of passing them via charset. Fixes #75060.
8778 2005-05-27 Raja R Harinath <rharinath@novell.com>
8780 * parameter.cs (Parameter): Remove TODO comment.
8781 (Parameter.DefineParameter): Remove Location parameter.
8782 (Parameters.LabelParameters): Likewise.
8783 * class.cs (Constructor.Emit): Update to change.
8784 (MethodData.Emit): Likewise.
8785 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
8786 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
8788 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
8791 Removed Parameters.Location and added Parameter.Location instead.
8792 Removed Location parameter from Emit() and GetSignature().
8799 Modified all related calls.
8801 2005-05-26 Raja R Harinath <rharinath@novell.com>
8803 Improve user-defined conversion handling.
8804 * convert.cs (GetConversionOperators): Rewrite. Return only the
8805 applicable operators.
8806 (AddConversionOperators): New. Helper for GetConversionOperators.
8807 (FindMostEncompassedType, FindMostEncompassingType): Verify that
8808 there is only one most encompassed/encompassing type.
8809 (FindMostSpecificSource, FindMostSpecificTarget): Remove
8810 "applicable operator" handling.
8811 (UserConversion): Move cache here from GetConversionOperators.
8812 Directly cache the chosen operator, rather than the whole
8814 (ExplicitNumericConversion): Fix buggy implementation of Decimal
8815 case. Allow conversion of decimal to sbyte and byte too.
8816 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
8817 New static methods. Used to avoid allocating EmptyExpressions in
8820 2005-05-24 Duncan Mak <duncan@novell.com>
8822 * ecore.cs (CastFromDecimal): New class for casting a decimal to
8823 another class, used in Convert.ExplicitNumericConversion.
8824 (CastToDecimal): New class, similar to above, but casts to
8825 System.Decimal, used in Convert.ImplicitNumericConversion and also
8826 in explicit convesion from double/float to decimal.
8828 * convert.cs (ImplicitNumericConversion): Handle implicit
8829 conversions to System.Decimal.
8830 (ExplicitNumericConversion): handle explicit conversions to
8835 2005-05-20 Miguel de Icaza <miguel@novell.com>
8837 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
8838 know the type at this stage, just break through. Fixes #75008
8840 2005-05-19 Martin Baulig <martin@ximian.com>
8843 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
8844 to disable error reporting.
8846 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
8847 here since we don't want to report an error; see the new test-336.cs.
8849 2005-05-19 Raja R Harinath <rharinath@novell.com>
8851 * statement.cs (ToplevelBlock.GetParameterReference)
8852 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
8853 Move here from class Block.
8854 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
8855 * expression.cs (ParameterReference.DoResolveBase): Likewise.
8857 2005-05-18 Martin Baulig <martin@ximian.com>
8862 (FlowBranching.Reachability): Add non-static public And() and Or()
8864 (FlowBranchingSwitch): New class; do the `break_origins' thing
8865 like in FlowBranchingLoop.
8866 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
8867 reachability, not just locals and parameters.
8868 (FlowBranching.MergeChild): Remove some of the hacks for loop and
8869 switch; MergeBreakOrigins() now takes care of that.
8871 2005-05-18 Martin Baulig <martin@ximian.com>
8873 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
8874 a loop and may leave it, reset the barrier; fixes #74974.
8876 2005-05-17 Marek Safar <marek.safar@seznam.cz>
8878 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
8881 * cs-parser.jay: Catch more lexical errors.
8883 * report.cs: Add one more Error method.
8886 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
8888 2005-05-17 Martin Baulig <martin@ximian.com>
8890 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
8893 2005-05-16 Raja R Harinath <rharinath@novell.com>
8895 Fix test-382.cs. Emit values of decimal constants.
8896 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
8898 (TypeContainer.AddField): ... this.
8899 (TypeContainer.EmitFieldInitializers): Allow the list of fields
8900 with initializers to include 'Const's.
8901 (ClassPart.RegisterFieldForInitialization): Forward to
8903 * const.cs (Const.Const): Pass initializer to base class.
8904 (Const.Define): In case of decimal constants, register them for
8905 initialization in a static constructor.
8907 2005-05-14 Martin Baulig <martin@ximian.com>
8909 * statement.cs (Block.Resolve): Correctly handle unreachable code;
8910 do not call ResolveUnreachable() on unreachable statements in
8911 here, see the comment in the source code.
8913 2005-05-13 Raja R Harinath <rharinath@novell.com>
8916 * expression.cs (BinaryResolveOperator): If one of the operands of
8917 an equality comparison is 'null' and the other is a pointer type,
8918 convert the null to a NullPointer.
8919 * convert.cs (ImplicitReferenceConversion): If the expression is a
8920 NullLiteral and the target type is a pointer type, return a
8921 NullPointer instead.
8922 (ImplicitConversionStandard): Likewise.
8924 2005-05-13 Marek Safar <marek.safar@seznam.cz>
8926 * cs-parser.jay: Set readonly context based on special constructs.
8928 * expression.cs (LocalVariableReference.DoResolveBase): Improved
8929 readonly variable error handling.
8931 * rootcontext.cs (EmitCode): Don't verify members when error
8934 * statement.cs (LocalInfo): Add reaodnly context information.
8935 (SetReadOnlyContext, GetReadOnlyContext): New methods.
8937 2005-05-13 Raja R Harinath <rharinath@novell.com>
8939 * statement.cs (Block.Resolve): Revert change below. Modify fix
8940 for #74041 to initialize 'resolved' to false only for explicit
8941 blocks. Fixes #74873.
8943 2005-05-12 Raja R Harinath <harinath@gmail.com>
8946 * typemanager.cs (unmanaged_enclosing_types): New.
8947 (IsUnmanagedType): Avoid infloops by using
8948 'unmanaged_enclosing_types' to talk with recursive invocations.
8950 2005-05-13 Martin Baulig <martin@ximian.com>
8952 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
8953 instance variable, not a local. Fix #74873.
8954 (Block.ResolveUnreachable): Set it to true here.
8956 2005-05-11 Duncan Mak <duncan@novell.com>
8958 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
8959 continuing to process for 'arg'.
8960 (handle_preprocessing_directive): Check the argument of the #endif
8961 directive and report error CS1025 if there are any trailing
8964 According to the C# spec, having even whitespace after the #endif
8965 directive is illegal; however, because we call arg.TrimEnd ()
8966 beforehand, we have the same behavior as csc, allowing whitespace
8967 after the directive.
8971 2005-05-11 Marek Safar <marek.safar@seznam.cz>
8975 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
8976 (Constructor.GetObsoleteAttribute): Implemented correctly.
8978 2005-05-10 Martin Baulig <martin@ximian.com>
8980 * support.cs (ReflectionParameters.ParameterModifier): Use
8981 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
8982 and `ParameterAttributes.In'. Fixes #74884.
8984 2005-05-10 Marek Safar <marek.safar@seznam.cz>
8986 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
8988 * expression.cs (Argument.GetParameterModifier): Turned to property.
8989 (Invocation.Error_InvalidArguments): Add more descriptive errors.
8991 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
8994 2005-05-09 Raja R Harinath <rharinath@novell.com>
8997 * decl.cs (MemberCache.AddMethods): Register override methods,
8998 rather than non-override methods.
8999 * typemanager.cs (RegisterOverride): New.
9000 (IsOverride): Update.
9002 2005-05-09 Marek Safar <marek.safar@seznam.cz>
9006 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
9007 recursive declaration.
9009 * statement.cs (Block.ResolveMeta): Report any error in resolving.
9011 2005-05-06 Marek Safar <marek.safar@seznam.cz>
9013 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
9015 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
9017 2005-05-05 Raja R Harinath <rharinath@novell.com>
9020 * decl.cs (DeclSpace.FamilyAccessible):
9021 Use TypeManager.IsNestedFamilyAccessible.
9023 Fix reopened #64812.
9024 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
9027 2005-05-04 Raja R Harinath <rharinath@novell.com>
9028 Abin Thomas <projectmonokochi@rediffmail.com>
9029 Anoob V E <projectmonokochi@rediffmail.com>
9030 Harilal P R <projectmonokochi@rediffmail.com>
9033 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
9034 allow access to all static members.
9036 2005-05-04 Martin Baulig <martin@ximian.com>
9038 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
9040 2005-05-04 Martin Baulig <martin@ximian.com>
9044 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
9045 section at the end; make things work if `default' is not the last
9048 2005-05-04 Martin Baulig <martin@ximian.com>
9052 * statement.cs (Switch): Replaced the `got_default' field with a
9053 `default_section' one.
9054 (Switch.CheckSwitch): Set `default_section' here.
9055 (Switch.Resolve): If we're a constant switch and the constant is
9056 not found, use the default section.
9058 2005-05-03 Martin Baulig <martin@ximian.com>
9060 * expression.cs (ArrayAccess.EmitGetLength): New public method.
9062 * statement.cs (Foreach.ArrayForeach): New nested class.
9063 (Foreach.TemporaryVariable): New nested class.
9064 (Foreach.EmitArrayForeach): Removed; this is now in the new
9067 2005-05-03 Raja R Harinath <rharinath@novell.com>
9069 * pending.cs (BaseImplements): Move the #74773 fix here. This is
9071 (VerifyPendingMethods): Revert change below.
9073 * typemanager.cs (IsOverride, RegisterNonOverride): New.
9074 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
9075 that used to trigger warning -28. Remove warning -28.
9076 * expression.cs (Invocation.OverloadResolve): Use
9077 TypeManager.IsOverride to distinguish override methods.
9080 * pending.cs (VerifyPendingMethods): If a base type implements the
9081 requested interface, don't bother checking individual methods of
9082 the base type. As a side-effect, this prevents the creation of
9083 unnecessary proxies.
9085 2005-05-02 Martin Baulig <martin@ximian.com>
9089 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9090 Also `And' the locals if the old vector is null.
9091 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
9092 null; in this case we basically reset all the variables.
9094 2005-05-02 Martin Baulig <martin@ximian.com>
9098 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
9099 Added `FlowBranching branching' argument; always `and' the
9100 variables instead of `or'ing them unless we're an infinite loop.
9102 * statement.cs (While.Resolve): Create a new sibling unless we're
9105 2005-05-02 Martin Baulig <martin@ximian.com>
9109 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
9110 arguments; use it instead of creating a new TopLevelBlock.
9111 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
9112 our ConstructorInitializer.
9115 (TopLevelBlock.TopLevelBranching): New public property.
9116 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
9117 and create our `TopLevelBranching'.
9119 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
9120 anonymous method host, use `block.TopLevelBranching' rather than
9121 creating a new branching.
9123 2005-04-20 Miguel de Icaza <miguel@novell.com>
9125 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
9126 a ScopeInfo, if any of the current children is a child of the new
9127 entry, move those children there.
9129 2005-04-30 Martin Baulig <martin@ximian.com>
9131 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
9132 at the beginning of a SwitchSection. Fix #73335.
9134 2005-04-27 Marek Safar <marek.safar@seznam.cz>
9137 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
9139 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
9140 (FieldExpr.DoResolve): Obsolete members are ignored for field
9143 2005-04-26 Marek Safar <marek.safar@seznam.cz>
9145 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
9146 of arrays detection.
9148 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
9150 (Field.VerifyClsCompliance): Volatile fields are not compliant.
9152 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
9155 2005-04-25 Ben Maurer <bmaurer@ximian.com>
9157 * cs-parser.jay: Use the prefered version of -unsafe in error
9160 2005-04-22 Marek Safar <marek.safar@seznam.cz>
9162 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
9165 2005-04-20 John Luke <john.luke@gmail.com>
9167 * driver.cs: fix typo in error message, --outout to --output
9169 2005-04-20 Marek Safar <marek.safar@seznam.cz>
9171 * codegen.cs (InRefOutArgumentResolving): New field.
9173 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
9174 fields outside contructor.
9176 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
9178 2005-04-19 Miguel de Icaza <miguel@novell.com>
9180 * anonymous.cs (CaptureContext.EmitParameterInstance): The
9181 parameter code was not completed ever, so it was not as up-to-date
9182 as local variables. Must finish it.
9184 The bug fix was to compare the Toplevel of the block, not the
9185 current block. Thanks for Ben for pointing this out.
9187 2005-04-19 Raja R Harinath <rharinath@novell.com>
9189 * decl.cs (AddMethods): Use the declaring type of the problem
9190 method to determine if we want to squash a warning.
9192 2005-04-19 Marek Safar <marek.safar@seznam.cz>
9194 * attribute.cs: Removed debug output.
9196 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
9198 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
9201 2005-04-18 Raja R Harinath <rharinath@novell.com>
9204 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
9205 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
9206 all null comparisons against reference types.
9208 2005-04-18 Marek Safar <marek.safar@seznam.cz>
9211 * class.cs (TypeContainer.CircularDepException) New nested
9213 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
9214 (TypeContainer.DefineType): Removed error, reset InTransit before
9216 (Class.DefineType): Throw exception when is in Transit.
9217 Catch exception and report error.
9218 (Struct.DefineType): Throw exception when is in Transit.
9219 Catch exception and report error.
9220 (Interface.DefineType): Throw exception when is in Transit.
9221 Catch exception and report error.
9223 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
9224 handle nested exception handlers.
9226 * flowanalysis.cs (InTryWithCatch): New method, search for try with
9229 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
9230 InFinally and InCatch storage.
9232 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
9233 (Catch.Resolve): Set and Restore ec.InCatch.
9234 (Try.Resolve): Set and Restore ec.InFinally.
9235 (Try.HasCatch): True when try has catch.
9237 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
9239 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
9240 for the same event member, so exclude such cases from warning 419.
9243 2005-04-16 Miguel de Icaza <miguel@novell.com>
9245 * expression.cs (Binary.ResolveOperator): Apply patch from John
9246 Luke to fix bug 59864: operators &, | and ^ on enumerations
9247 require that the same enum type on both sides.
9249 * driver.cs: Add warnings to old flag usage, this is to assist
9250 people who produce Makefiles and hope that the Makefiles will be
9253 * class.cs (TypeContainer.EmitType): Moved the definition of the
9254 special $PRIVATE$ field from the resolve phase to the Emit phase.
9255 During resolve we do not know if we are a struct with
9256 HasExplicitLayout, we know this only after the attributes for the
9259 Set the FieldOffset to zero on the dummy field that we create for
9260 the class. Fixes 74590.
9262 2005-04-16 Raja R Harinath <rharinath@novell.com>
9265 * ecore.cs (PropertyExpr.resolved): New.
9266 (DoResolve): Use it to handle a case of double resolution here.
9267 Handle a case of identical-name-and-type-name.
9268 * expression.cs (ArrayCreation.CheckIndices): Avoid double
9269 resolution by storing the results of expression resolution back
9270 into the "probes" array.
9272 2005-04-15 Raja R Harinath <rharinath@novell.com>
9274 Fix cs0208-7.cs and cs0208-8.cs.
9275 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
9276 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
9277 error reporting to point out the reason a struct is not unmanaged.
9279 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9281 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
9282 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
9284 2005-04-13 Raja R Harinath <rharinath@novell.com>
9287 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
9288 IdenticalNameAndTypeName here.
9289 (EventExpr.InstanceResolve): Likewise.
9291 2005-04-13 Marek Safar <marek.safar@seznam.cz>
9293 C# 2.0 DefaultCharSetAttribute implementation
9295 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
9296 which allows us to set GlobalNamespace for every resolve.
9297 (Attribute.ResolveArguments): Cut from Resolve.
9298 (Attribute.GetCharSetValue): Returns CharSet named argument.
9299 (Attribute.DefinePInvokeMethod): Gets default charset from
9301 (GlobalAttribute.ResolveAsTypeStep): Override.
9302 (GlobalAttribute.ResolveArguments): Override.
9304 * class.cs (TypeAttr): Is protected.
9306 * codegen.cs (ModuleClass.DefaultCharSet): New member.
9307 (ModuleClass.DefaultCharSetType): New memeber.
9308 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
9310 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
9311 charset from module.
9313 * delegate.cs (TypeAttr): Override.
9314 (Delegate.DefineType): Use this TypeAttr.
9316 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
9317 at very early stage (before types are defined) to resolve model
9318 module attributes. It will probably not work with corlib but it
9321 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
9322 charset from module.
9324 * typemanager.cs (default_charset_type): New type.
9326 2005-04-13 Raja R Harinath <rharinath@novell.com>
9328 * decl.cs (MemberCache.AddMethods): Don't warn if
9329 System.Object.Finalize has buggy MethodAttributes.
9331 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
9334 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9336 * doc.cs : detect ambiguous reference to overloaded members.
9337 Fixed bug #71603. MS 1.1 csc does not detect it.
9339 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9341 * doc.cs : delegates must not be referenced with parameters.
9344 2005-04-12 Miguel de Icaza <miguel@novell.com>
9346 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
9348 2005-04-10 Miguel de Icaza <miguel@novell.com>
9350 * driver.cs (MainDriver): Stop processing if the CLS stage found
9353 (CompilerCallableEntryPoint.InvokeCompiler): Always
9354 reset after execution; Take a TextWriter argument for the
9357 * report.cs: Use the error stream instead of hardcoding stderr.
9359 2005-04-09 Miguel de Icaza <miguel@novell.com>
9361 * class.cs: Reduce code paths to test, too small of an
9362 optimization to make it worth the extra testing. Always perform
9365 2005-04-08 Raja R Harinath <rharinath@novell.com>
9368 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
9369 operators that had errors reported on them.
9371 2005-04-08 Marek Safar <marek.safar@seznam.cz>
9373 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
9375 (Attribute.Resolve): Add named argument type checking.
9377 * class.cs (FixedField.Define): Use IsPrimitiveType
9379 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
9381 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
9382 unsafe parameter types.
9384 * statement.cs (Using.ResolveExpression): Add better error description.
9386 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
9388 2005-04-08 Raja R Harinath <rharinath@novell.com>
9391 * attribute.cs (Attribute.GetAttributeUsage): Resolve
9392 AttributeUsageAttribute in the emitcontext of the attribute class,
9393 not in the emitcontext of the attributable entity it was attached to.
9394 * cs-parser.jay: Use 'current_class', not 'current_container',
9395 when creating a GlobalAttribute.
9397 2005-04-08 Alp Toker <alp@atoker.com>
9399 * pending.cs: The fix to #58413 failed to compile methods implementing
9400 interfaces with/without params modifiers and vice versa, even though
9401 params modifiers aren't part of the signature. Make the modifier check
9402 less strict as in csc.
9404 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
9405 Anoob V E <projectmonokochi@rediffmail.com>
9406 Harilal P R <projectmonokochi@rediffmail.com>
9409 * pending.cs (TypeAndMethods.mods): New. Store the parameter
9410 modifiers of pending methods.
9411 (PendingImplementation.PendingImplementation): Initialize it.
9412 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
9413 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
9414 with ParameterData. Add check for modifiers.
9415 * class.cs (MethodData.Define): Update to changes.
9417 2005-04-07 Raja R Harinath <rharinath@novell.com>
9419 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
9421 2005-04-07 Marek Safar <marek.safar@seznam.cz>
9423 * class.cs (PropertyMethod.Define): Check private accessor in abstract
9426 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
9429 * typemanager.cs: Registered RequiredAttributeAttribute.
9431 2005-04-06 Marek Safar <marek.safar@seznam.cz>
9433 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
9434 Warning CS0169 is back at level 3.
9435 (IMethodData.SetMemberIsUsed): New method.
9437 * decl.cs (IsUsed): New value; moved from FieldBase.Status
9438 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
9440 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
9442 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
9444 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
9447 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
9450 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
9451 to avoid the problems with nested types.
9453 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
9454 Anoob V.E <projectmonokochi@rediffmail.com>
9455 Harilal P.R <projectmonokochi@rediffmail.com>
9456 Raja R Harinath <rharinath@novell.com>
9459 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
9461 * typemanager (GetConstructor): Make public.
9463 2005-04-05 John Luke <john.luke@gmail.com>
9464 Raja R Harinath <rharinath@novell.com>
9467 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
9468 struct too. Return false quicker in a few cases.
9469 (VerifyUnManaged): Use it.
9471 2005-04-05 Raja R Harinath <rharinath@novell.com>
9474 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
9475 not 'unreachable_seen'.
9477 2005-04-04 Marek Safar <marek.safar@seznam.cz>
9479 * attribute.cs (Attribute.GetValue): Removed unused.
9481 * codegen.cs (CodeGen.TrimExt): Removed unused.
9483 * cs-parser.jay (output): Removed unused.
9485 * cs-tokenizer.cs (hex_digits): Removed unused.
9487 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
9489 * expression.cs (Indirection.LoadExprValue): Removed unused.
9490 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
9492 * iterators.cs (Iterator.param_types): Removed unused.
9494 * statement.cs (Goto.block): Removed unused.
9495 (ToplevelBlock.did): Removed unused.
9496 (Switch.ResolveConstantSwitch): Removed unused.
9498 2005-04-01 Ben Maurer <bmaurer@ximian.com>
9500 * rootcontext.cs: Allow mcs to bootstrap with the compilation
9503 2005-04-01 Raja R Harinath <rharinath@novell.com>
9505 Fix #74232 and cs0208-3.cs.
9506 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
9507 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
9508 unmanaged type. Don't use FieldBuilders when 't' is a
9509 TypeBuilder. Use ModFlags and MemberType fields.
9510 * class.cs (MemberBase.member_type): Rename from MemberType.
9511 (MemberBase.MemberType): New property. Determines member_type on
9513 (MemberBase.DoDefine): Don't initialize MemberType here.
9514 (FieldMember.Define): Likewise.
9516 2005-04-01 Marek Safar <marek.safar@seznam.cz>
9519 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
9520 Attributes are emitted there.
9522 2005-04-01 Raja R Harinath <rharinath@novell.com>
9524 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
9525 keyword in 'partial enum' too.
9526 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
9528 Report from Kamil Skalski <nazgul@omega.pl>.
9531 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
9532 have partial containers too.
9534 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
9535 in block' checks to Block.CheckInvariantMeaningInBlock.
9536 * statement.cs (Block.GetKnownVariableInfo): Make private.
9537 (Block.IsVariableUsedInChildBlock): Remove.
9538 (Block.IsVariableUsedInBlock): Likewise.
9539 (Block.CheckInvariantMeaningInBlock): New. Show location of
9540 conflicting declaration.
9541 (Block.AddVariable): Make error messages less long-winded and more
9542 specific. Show location of conflicting declaration.
9543 * parameter.cs (Parameters.Location): New readonly property.
9545 2005-03-31 Raja R Harinath <rharinath@novell.com>
9547 Clean up semantics of invoking ResolveMemberAccess.
9548 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
9549 can have an instance, ensure that we pass in a non-TypeExpression
9550 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
9551 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
9552 argument. Update to changes and simplify.
9553 (FieldExpr.Emitinstance): Remove CS0120 check.
9554 (PropertyExpr.EmitInstance): Likewise.
9555 * expression.cs (Argument.Resolve): Likewise.
9556 (Invocation.DoResolve): Update to changes in semantics of
9559 2005-03-31 Marek Safar <marek.safar@seznam.cz>
9562 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
9565 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
9567 2005-03-31 Raja R Harinath <rharinath@novell.com>
9569 Fix difference in behaviour with commandline invocation.
9570 * driver.cs (Driver.Reset): New.
9571 (CompilerCallableEntryPoint): Call it.
9573 * statement.cs (If.Resolve): Avoid spurious "uninitialized
9574 variable" warnings if the boolean expression failed to resolve.
9576 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
9578 * attribute.cs: Fix the union of several permissions when some of them
9579 are unrestricted (so the result isn't an unrestricted permission set).
9582 2005-03-30 Raja R Harinath <rharinath@novell.com>
9584 * ecore.cs (MemberExpr): New class. Convert from interface
9586 (MemberExpr.ResolveMemberAccess): Refactor and move here from
9587 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
9589 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
9590 (MethodGroupExpr.IsExplicitImpl): Remove.
9591 (Expression.GetFieldFromEvent): Remove.
9592 (SimpleName.MemberStaticCheck): Remove.
9593 (SimpleName.DoSimpleNameResolve): Update to changes.
9594 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
9595 (MemberAccess.IdenticalNameAndTypeName): Remove.
9596 (MemberAccess.error176): Move to MemberExpr.
9597 (MemberAccess.DoResolve): Update to changes.
9598 (BaseAccess.DoResolve): Likewise.
9600 2005-03-30 Marek Safar <marek.safar@seznam.cz>
9602 C# 2.0 Conditional attribute class implementation
9604 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
9605 Analyzes class whether it has attribute which has ConditionalAttribute
9606 and its condition is not defined.
9608 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
9609 (Class.IsExcluded): New method. Search for at least one defined
9610 condition in ConditionalAttribute of attribute class.
9612 2005-03-30 Raja R Harinath <rharinath@novell.com>
9614 * ecore.cs (PropertyExpr): Derive from Expression, not
9615 ExpressionStatement.
9616 (PropertyExpr.EmitStatement): Remove.
9618 2005-03-29 Raja R Harinath <rharinath@novell.com>
9621 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
9622 internal field "value__" of an enum be private. The examples for
9623 "value__" that I found on MSDN all used FieldAttributes.Private.
9625 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
9626 Don't mention IL method attribute names.
9628 Fix #47991. Remove a TODO.
9629 * statement.cs (Block.Toplevel): Make into a field.
9630 (Block.Parameters): Move into ToplevelBlock.
9631 (Block.known_variables): Rename from child_variable_names.
9632 (Block.Block): Remove variants that take Parameters. Initialize
9633 'Toplevel' with the immediately surrounding toplevel block.
9634 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
9635 LocalInfo parameter.
9636 (Block.GetKnownVariableInfo): New.
9637 (Block.IsVariableNameUsedInChildBlock): Update.
9638 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
9639 the block, even though it may not be in scope.
9640 (Block.AddVariable): Remove Parameters parameter. Use
9641 Toplevel.Parameters instead.
9642 (Block.AddConstant): Remove Parameters parameter.
9643 (Block.GetParameterReference): Update to use Toplevel.Parameters.
9644 (Block.IsParamaterReference): Likewise.
9645 (Block.IsLocalParameter): Likewise. Simplify a lot.
9646 (ToplevelBlock.Parameters): New. Moved from Block.
9647 (ToplevelBlock.ToplevelBlock): Update to changes. Always
9648 initialize Parameters to a non-null value.
9649 * cs-parser.jay: Update to changes.
9650 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
9651 simple names that mean different things in the same block. Use
9652 Block.IsVariableNameUsedInBlock.
9654 2005-03-28 Raja R Harinath <rharinath@novell.com>
9656 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
9657 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
9658 GetTypeHandle. It is possible for a reflected type to derive from
9659 a TypeBuilder (e.g., int[] derives from the TypeBuilder
9660 System.Array during mscorlib compilation).
9661 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
9662 contain a method_hash, don't create one either. Don't create a
9663 deep copy of the base cache's method_hash.
9664 (MemberCache.SetupCache): Rename back from DeepCopy.
9665 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
9666 already initialized. If we see an override function, add its
9667 underlying base virtual function to the member_hash too.
9669 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
9671 2005-03-26 Raja R Harinath <harinath@acm.org>
9674 * assign.cs (Assign.DoResolve): When the RHS of an assignment
9675 fails to resolve, ensure that the LHS is still resolved as an
9678 2005-03-25 Raja R Harinath <harinath@acm.org>
9680 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
9682 (Enum.current_ec): Remove.
9683 (Enum.LookupEnumValue): Remove EmitContext argument.
9684 Just uses the one created during DefineType.
9685 (Enum.FindMembers): Update.
9686 * expression.cs (MemberAccess.DoResolve): Update.
9688 2005-03-22 Marek Safar <marek.safar@seznam.cz>
9690 * assign.cs (Assign.DoResolve): Check for CS1717 when
9691 source and target are same (uses Equals).
9693 * expression.cs (LocalVariableReference, ParameterReference,
9694 This): Implemented Equals, GetHashCode.
9696 * statement.cs (Block.GetParameterReference): Removed useless
9699 2005-03-22 Raja R Harinath <rharinath@novell.com>
9702 * statement.cs (Block.AddVariable): Ensure that we skip implicit
9703 blocks before deciding whether the error is cs0136 or cs0128.
9705 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
9706 (using_alias_directive, using_namespace_directive): Pass
9707 MemberName, not an expression to Namespace.UsingAlias and
9709 (MakeName): Use the MemberName of the namespace.
9710 * namespace.cs (Namespace.MemberName): New.
9711 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
9712 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
9714 * decl.cs (MemberName.Name): Make readonly.
9715 (MemberName.FromDotted): New "constructor".
9716 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
9717 (MemberCore.Name): Compute from MemberName on demand.
9718 (MemberCore.SetMemberName): Provide a way to change the
9720 (MemberCore.AddToContainer): Don't take a fullname parameter.
9721 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
9722 fully qualified name of the container to the member name.
9723 (TypeContainer.AddToTypeContainer): Use a fully qualified name
9724 only if the type is a member of the root container.
9725 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
9726 MemberName.Left rather than searching for an embedded ".".
9727 (PartialContainer.CreatePart): Update to changes in RootContext.
9728 (MemberBase.ShortName): Turn into a property. Use
9729 MemberCore.SetMemberName.
9730 (MemberBase.ExplicitInterfaceName): Remove.
9731 (MemberBase.UpdateMemberName): Remove.
9732 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
9733 (PropertyBase.SetMemberName): New override.
9734 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
9735 (Tree.GetDecl): New.
9736 (Tree.AllDecls): Rename from Decls.
9737 * attribute.cs, enum.cs, report.cs: Update to changes.
9738 * driver.cs (MainDriver): Use MemberName.FromDotted on
9739 RootContext.MainClass.
9741 2005-03-21 Marek Safar <marek.safar@seznam.cz>
9743 * class.cs (FixedField.Define): Check for CS1664 and more sanity
9746 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
9748 2005-03-18 Marek Safar <marek.safar@seznam.cz>
9750 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
9751 property accessor modifiers.
9753 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
9754 fixed buffer attribute (CS1716).
9755 (PropertyMethod.HasCustomAccessModifier): When property accessor
9756 has custom modifier.
9758 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
9760 (PropertyExpr.DoResolveLValue): Add CS0272.
9762 2005-03-17 Miguel de Icaza <miguel@novell.com>
9764 * convert.cs: When converting to a pointer, use the proper Conv.U
9765 or Conv.I depending on the source data type.
9767 * cs-tokenizer.cs: Make the size for large decimal constants,
9770 2005-03-17 Martin Baulig <martin@ximian.com>
9772 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
9773 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
9775 2005-03-17 Martin Baulig <martin@ximian.com>
9777 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
9778 to bool so we can return an error condition.
9779 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
9782 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
9784 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
9787 2005-03-16 Raja R Harinath <rharinath@novell.com>
9789 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
9790 Refactor to avoid traversing the list of assemblies, and to avoid
9791 string concatenation.
9792 * typemanager.cs (guid_attr_type): Remove.
9793 (negative_hits, pointers, references): Remove hashes.
9795 (GetConstructedType): New. Uses type_hash to handle constructed
9796 types (arrays, references, pointers).
9797 (GetReferenceType, GetPointerType): Use it.
9798 (GetNestedType): New. Uses type_hash to handle nested types of
9800 (LookupType, LookupTypeDirect): Remove.
9801 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
9802 'types' hash and LookupTypeReflection directly.
9803 (params_string, params_object): Use GetConstructedType.
9804 * namespace.cs (Namespace.cached_types): New. Cache of reflected
9806 (Namespace.Lookup): Use cached_types.
9807 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
9808 provided by old TypeManager.LookupType.
9809 * rootcontext.cs (MakeFQN): Remove.
9810 * decl.cs (DeclSpace.MakeFQN): Likewise.
9811 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
9812 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
9813 TypeManager.GetConstructedType.
9814 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
9816 2005-03-15 Marek Safar <marek.safar@seznam.cz>
9818 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
9821 * cs-parser.jay: Reports CS1527 for any namespace element.
9823 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
9826 * expression.cs (ParameterReference.IsAssigned): Changed error to
9828 (Error_WrongNumArguments): Moved CS0245 detection here.
9830 * statement.cs (Return.Resolve): Add CS1622 report.
9832 2005-03-11 Marek Safar <marek.safar@seznam.cz>
9834 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
9836 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
9838 * attribute.cs expression.cs: Get rid of some allocations.
9840 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
9842 * doc.cs : just eliminate the latest change.
9844 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
9846 * doc.cs : commented out the latest change. It breaks xml-030.cs
9848 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
9850 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
9851 fail. So invoke CreateType() in FindDocumentedType().
9853 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
9855 * cs-tokenizer.cs : added IsKeyword().
9856 * doc.cs : Detect keyword incorrectly used as identifier.
9857 Allow identifiers prefixed by @.
9859 2005-03-10 Marek Safar <marek.safar@seznam.cz>
9861 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
9862 It caused exception in namespace resolving (again!).
9864 * class.cs (Class.ctor): Removed exit.
9865 (PropertyMethod.ctor): ditto.
9867 * codegen.cs (Codegen.Reset): Reset static data.
9868 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
9870 * cs-tokenizer.cs (Cleanup): Removed.
9872 * driver.cs (GetSystemDir): Rewrote to one line command.
9873 It caused problem with unloaded dynamic modules.
9874 (UnixParseOption): Removed Exit.
9875 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
9876 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
9877 Now can be mcs used as library.
9879 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
9882 * location.cs (Reset): Reset static data.
9884 * namespace.cs (Reset): Reset static data.
9886 * report.cs (Report.Reset): Reset static data.
9888 * rootcontext.cs (RootContext.Reset): Reset static data.
9890 * tree.cs (RootTypes.ctor): Use Location.Null
9892 * typemanager.cs (TypeManager.Reset): Reset static data.
9893 (CoreLookupType): Removed Exit.
9894 (TypeHandle.Reset): Reset static data.
9896 2005-03-10 Raja R Harinath <rharinath@novell.com>
9899 * typemanager.cs (ComputeNamespaces): Import namespaces from
9900 referenced modules too.
9902 2005-03-09 Raja R Harinath <rharinath@novell.com>
9904 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
9907 2005-03-09 Raja R Harinath <rharinath@novell.com>
9909 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
9910 enclosing DeclSpace. This ensures that a name-lookup populates
9911 more caches and there are fewer 'TypeExpression's. Carve out
9912 nested type lookup into ...
9913 (LookupNestedTypeInHierarchy): ... this.
9915 2005-03-09 Raja R Harinath <rharinath@novell.com>
9917 Clean up a few partial-class semantics.
9918 Fixes test-357.cs and cs1618-2.cs.
9919 * cs-parser.jay (struct_declaration): Use 'current_class' as
9920 parent of newly-created struct. Remove call to Register ().
9921 Use 'pop_current_class' to complete handing the current struct.
9922 (interface_declaration): Likewise.
9923 (class_declaration): Likewise.
9924 (enum_declaration): Use 'current_class' as parent of newly created
9926 (delegate_declaration): Likewise.
9927 (pop_current_class): New function. This is used to handle closing
9928 up the 'current_class' and 'current_container', and pointing them
9929 to the enclosing class/container.
9930 (CSharpParser): Initialize 'current_class' too.
9931 * decl.cs (MemberCore): Add check for invariant: a partial
9932 container is not a parsed entity, and thus does not enclose any
9934 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
9935 (DeclSpace.BaseTypeExpr): Use it.
9936 (DeclSpace.LookupType): Add check for invariant.
9937 * class.cs (TypeContainer): Add check for invariant: a nested
9938 class should have the same NamespaceEntry as its enclosing class.
9939 (TypeContainer.EmitFieldInitializers): Make virtual.
9940 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
9942 (TypeContainer.Register): Remove.
9943 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
9944 null. Use TypeResolveEmitContext for resolving base types and
9945 interfaces. Move initialization of Parts.TypeBuilder here from
9947 (TypeContainer.DefineNestedTypes): ... here.
9948 (PartialContainer): Take a Namespace not a NamespaceEntry.
9949 (PartialContainer.Create): Don't use Register. Call the
9950 appropriate Add... function directly.
9951 (ClassPart): Take both the PartialContainer and the enclosing
9952 class as constructor arguments.
9953 (ClassPart.EmitFieldInitializers): Override.
9954 (ClassPart.PartFindNestedTypes): Remove.
9955 (FieldBase.GetInitializerExpression): Resolve the initializer
9956 expression in the emit context of the enclosing class.
9957 * tree.cs (RootTypes): Remove Register ().
9959 2005-03-08 Marek Safar <marek.safar@seznam.cz>
9961 * cs-parser.jay: Removed CS0134.
9963 * driver.cs: Removed CS1901.
9965 * expression.cs (SizeOf.DoResolve): Don't report CS0233
9966 for predefined types.
9968 2005-03-07 Duncan Mak <duncan@novell.com>
9970 * codegen.cs (Save): Catch UnauthorizedAccessException as
9971 well. Fixes bug #73454.
9973 2005-03-07 Marek Safar <marek.safar@seznam.cz>
9975 * cs-tokenizer.cs (xtoken): Add CS1035.
9977 * class.cs (MethodData.Define): Add CS0683.
9978 (FieldMember.ctor): Add CS0681.
9980 2005-03-07 Raja R Harinath <rharinath@novell.com>
9982 * ecore.cs (SimpleName.DoResolve): Rename from
9983 SimpleName.DoResolveAllowStatic.
9984 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
9985 Pass 'intermediate' flag to MemberStaticCheck.
9986 (SimpleName.MemberStaticCheck): Skip "static check" only in case
9987 of "intermediate" lookups via MemberAccess.
9988 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
9989 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
9991 2005-03-07 Raja R Harinath <rharinath@novell.com>
9994 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
9995 slipped in because of variable names that are identical to a
9996 builtin type's BCL equivalent ('string String;', 'int Int32;').
9997 (PropertyExpr.EmitInstance): Likewise.
9999 2005-03-04 Marek Safar <marek.safar@seznam.cz>
10001 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
10003 * report.cs (warning_ignore_table): Made public.
10005 2005-03-04 Raja R Harinath <rharinath@novell.com>
10008 * class.cs (MethodData.Emit): Pass 'container' to
10009 container.GetObsoleteAttribute instead of 'container.Parent'.
10011 2005-03-03 Marek Safar <marek.safar@seznam.cz>
10013 * cs-parser.jay: Add 1534 error test.
10015 * iterators.cs (Yield.CheckContext): Add error 1629.
10016 (Iterator.ctor): Save unsafe modifier.
10017 (MoveNextMethod.DoEmit): Restore unsafe context.
10019 * namespace.cs (UsingAlias): Better error message.
10021 2005-03-03 Dan Winship <danw@novell.com>
10023 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
10024 the warning message [#73219]
10026 2005-03-03 Raja R Harinath <rharinath@novell.com>
10028 Fix compile with MCS 1.0.0.0.
10029 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
10030 w_restore to not depend on string constant folding.
10032 2005-03-03 Raja R Harinath <rharinath@novell.com>
10034 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
10035 CS0246 check to users who passed 'silent = false'.
10036 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
10038 (SimpleName.SimpleNameResolve): Update.
10039 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
10040 (MemberAccess.IdenticalNameAndTypeName): Update.
10041 * doc.cs (FindDocumentedTypeNonArray): Update.
10043 2005-03-03 Raja R Harinath <rharinath@novell.com>
10045 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
10046 * parameters.cs (ComputeAndDefineParameters): Remove.
10047 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
10048 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
10049 Use GetParameterInfo.
10051 2005-03-02 Marek Safar <marek.safar@seznam.cz>
10053 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
10055 2005-03-02 Raja R Harinath <rharinath@novell.com>
10057 Unify DeclSpace.LookupType and DeclSpace.FindType.
10058 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
10059 is in charge of defining nested types on demand.
10060 (DeclSpace.LookupType): Use it when the current_type is a
10061 TypeBuilder. Use LookupTypeDirect for reflected types.
10062 (DeclSpace.FindType): Remove.
10063 (DeclSpace.LookupInterfaceOrClass): Likewise.
10064 (DeclSpace.DefineTypeAndParents): Likewise.
10065 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
10066 DeclSpace.LookupType.
10067 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
10068 * typemanager.cs (LookupType): Simplify.
10069 (AddUserType): Remove type from negative_hits.
10070 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
10071 * class.cs (TypeContainer.FindMembers): Move handling of nested
10073 (TypeContainer.FindMembers_NestedTypes): ... here.
10074 (TypeContainer.FindNestedType): Implement override.
10075 (ClassPart.FindNestedType): Delegate to PartialContainer.
10076 (ClassPart.PartFindNestedType): Looks up the nested types of the
10079 2005-03-02 Martin Baulig <martin@ximian.com>
10081 * class.cs (TypeContainer.DoDefineMembers): We also need a default
10082 static constructor in static classes.
10084 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
10086 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
10087 sizeParamIndex is not specified.
10089 2005-03-01 Marek Safar <marek.safar@seznam.cz>
10092 * report.cs (WarningMessage.IsEnabled): Missing null check.
10094 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10096 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
10097 in the fields and not in the properties.
10099 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
10101 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
10104 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10106 * attribute.cs: Small refactoring (improved robustness).
10107 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
10108 (ValidateGuid): Removed.
10109 (Resolve): Removed referenced to above mentioned.
10110 (GetAttributeUsage): Made private and changed to work without
10112 (GetIndexerAttributeValue): Don't crash.
10113 (GetConditionalAttributeValue): Ditto.
10114 (GetClsCompliantAttributeValue): Ditto.
10115 (ExtractSecurityPermissionSet): All attributes exceptions are
10117 (GetPropertyValue): New helper.
10118 (GetMethodImplOptions): New method.
10119 (DefinePInvokeMethod): Reuse common code. Implemented handling of
10120 some missing properties.
10122 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
10123 (Method.ApplyAttributeBuilder): Updated.
10125 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
10128 2005-02-28 Raja R Harinath <rharinath@novell.com>
10131 * report.cs (Report.SymbolRelatedToPreviousError): Handle
10132 non-simple types (array, pointer, reference).
10134 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10136 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
10138 * class.cs (MethodCore.IsDuplicateImplementation): Special error
10140 (Method.CheckBase): Catch wrong destructor here.
10141 (MethodData.Define): Add errors 550, 668.
10143 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
10145 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
10147 * pending.cs (VerifyPendingMethods): Add error 551.
10149 * typemanager.cs (CSharpName): Next error report helper.
10151 2005-02-25 Marek Safar <marek.safar@seznam.cz>
10153 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
10154 attributes. Removed useless attribute double check.
10155 It saves almost 2MBs for corlib.
10157 2005-02-25 Raja R Harinath <rharinath@novell.com>
10160 * statement.cs (ExpressionStatement.Resolve): Make robust to being
10161 called twice in case of error.
10163 2005-02-23 Chris Toshok <toshok@ximian.com>
10165 Fix compiler portions of #72827.
10166 * statement.cs (Block.Emit): call Begin/EndScope on the
10167 EmitContext instead of the ILGenerator.
10169 * codegen.cs (EmitContext.BeginScope): new method, call
10170 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
10172 (EmitContext.BeginScope): same, but EndScope and CloseScope
10174 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
10175 offset and call the superclass's OpenScope(int) with it.
10176 (SymbolWriter.CloseScope): get the current il
10177 offset and call superclass's CloseScope(int) with it.
10179 2005-02-23 Marek Safar <marek.safar@seznam.cz>
10181 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
10182 CS1677 for out and ref as well.
10184 * class.cs (Method.Define): Add error CS1599 detection.
10186 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
10188 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
10190 * delegate.cs (Delegate.Define): Add error CS1599 detection.
10192 * support.cs.cs (ModifierDesc): New helper method.
10194 2005-02-23 Raja R Harinath <rharinath@novell.com>
10195 Abin Thomas <projectmonokochi@rediffmail.com>
10196 Anoob V E <projectmonokochi@rediffmail.com>
10197 Harilal P R <projectmonokochi@rediffmail.com>
10199 Fix #57851, #72718.
10200 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
10201 MemberLookup (used for error reporting) actually returns a result.
10202 Fix error report number (122, not 112).
10204 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
10205 Anoob V E <projectmonokochi@rediffmail.com>
10206 Harilal P R <projectmonokochi@rediffmail.com>
10209 * pending.cs (PendingImplementation.GetAbstractMethods):
10210 Find NonPublic members too.
10212 2005-02-22 Marek Safar <marek.safar@seznam.cz>
10214 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
10217 * class.cs (MethodCore.CheckMethodAgainstBase):
10218 Add error 239 report.
10220 2005-02-21 Raja R Harinath <rharinath@novell.com>
10223 * expression.cs (Invocation.IsApplicable): Make public.
10224 (Invocation.IsParamsMethodApplicable): Likewise.
10225 * delegate.cs (Delegate.VerifyApplicability): Don't use
10226 Invocation.VerifyArgumentCompat for parameter applicability
10227 testing. Use Invocation.IsApplicable and
10228 Invocation.IsParamsMethodApplicable.
10230 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10232 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
10234 * class.cs (Operator.Define): Add error 217 report.
10236 2005-02-21 Raja R Harinath <rharinath@novell.com>
10238 * namespace.cs (UsingEntry.Resolve): Undo change below.
10240 2005-02-21 Raja R Harinath <rharinath@novell.com>
10243 * ecore.cs (Expression.MemberLookupFailed): Add argument to
10244 disable the error message when the extended MemberLookup also
10246 (Expression.MemberLookupFinal): Update.
10247 (SimpleName.DoSimpleNameResolve): Update.
10248 * expression.cs (MemberAccess.ResolveNamespaceOrType):
10249 Don't use MemberLookupFinal.
10250 (New.DoResolve): Update.
10251 (BaseAccess.CommonResolve): Update.
10253 2005-02-21 Raja R Harinath <rharinath@novell.com>
10256 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
10257 occured previously, don't resolve again.
10259 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10262 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
10263 argument. Call ResolveAttributeUsage for unresolved.
10264 when types doesn't match ctor arguments.
10266 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
10267 for nested attribute classes.
10268 (Class.attribute_usage): Removed.
10269 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
10270 for attribute class.
10272 * ecore.cs (IsAttribute): Removed.
10274 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
10276 * rootcontext.cs (RegisterAttribute): Removed, attributes are
10278 (attribute_types): Removed.
10279 (EmitCode): Global attributes are emited as the latest.
10281 2005-02-18 Marek Safar <marek.safar@seznam.cz>
10283 * class.cs (EmitFieldInitializers): Don't emit field initializer
10284 for default values when optimilization is on.
10286 * constant.cs (Constant.IsDefaultValue): New property.
10288 * driver.cs: Add /optimize handling.
10292 * literal.cs: Implement new IsDefaultValue property.
10294 * rootcontext.cs (Optimize): New field, holds /optimize option.
10296 2005-02-18 Raja R Harinath <rharinath@novell.com>
10298 Fix crasher in re-opened #72347.
10299 * namespace.cs (Namespace.Lookup): Return null if
10300 DeclSpace.DefineType returns null.
10303 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
10305 2005-02-18 Raja R Harinath <rharinath@novell.com>
10307 Fix remainder of #63202. Change semantics of DoResolveLValue: it
10308 now returns null if it cannot resolve to an lvalue.
10309 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
10310 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
10311 returned null. Remove check for SimpleName.
10312 (EventExpr.DoResolveLValue): New.
10313 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
10314 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
10316 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
10317 avoid CS0131 error.
10318 (Unary.ResolveOperator): Move CS0211 check ...
10319 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
10321 (Unary.DoResolveLValue): Simplify.
10322 (AddressOf.DoResolveLValue): New.
10323 (ArrayAccess.DoResolveLValue): New.
10325 2005-02-16 Marek Safar <marek.safar@seznam.cz>
10327 * attribute.cs (Attribute.Resolve): Add arguments casting for
10328 when types doesn't match ctor arguments.
10330 2005-02-16 Raja R Harinath <rharinath@novell.com>
10332 Fix parts of #63202.
10333 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
10334 lookup of operator in base type. Ensure that all checks happen
10335 when the operator resolves to an "op_..." method.
10337 2005-02-15 Raja R Harinath <rharinath@novell.com>
10340 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
10341 'ignore_cs0104' parameter. Pass it to ...
10342 (NamespaceEntry.Lookup): ... this.
10343 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
10344 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
10345 (TypeLookupExpression.DoResolveAsTypeStep): Update.
10346 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
10347 Update. Request that cs0104 errors be ignored.
10348 (ComposedCast.ResolveAsTypeStep): Update.
10350 2005-02-14 Raja R Harinath <rharinath@novell.com>
10353 * expression.cs (Invocation.BetterFunction): Remove support for
10354 comparing virtual functions and their overrides.
10355 (Invocation.IsOverride): New.
10356 (Invocation.OverloadResolve): Don't consider 'override' functions
10357 during candidate selection. Store them in a lookaside list.
10358 If the selected method is a 'virtual' function, use the list to
10359 find any overrides that are closer to the LHS type.
10361 2005-02-14 Marek Safar <marek.safar@seznam.cz>
10363 * expression.cs (New.DoResolve): Add complex core type reduction.
10364 (New.Constantify): Converts complex core type syntax like 'new int ()'
10365 to simple constant.
10367 2005-02-14 Raja R Harinath <rharinath@novell.com>
10369 * decl.cs (EntryType.EntryType): New constructor to create an
10370 updated copy of a cache entry.
10371 (MemberCache.AddMethods): Use it.
10372 (MemberCache.ClearDeclaredOnly): Remove.
10373 (MemberCache.MemberCache): Update.
10375 2005-02-11 Miguel de Icaza <miguel@novell.com>
10377 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
10378 variable. This one is represents the actual low-level declaration
10379 of the method, as opposed to the semantic level `IsStatic'.
10381 An anonymous method which is hosted into a static method might be
10382 actually an instance method. IsStatic would reflect the
10383 container, while MethodIsStatic represents the actual code
10386 * expression.cs (ParameterReference): Use the new MethodIsStatic
10387 instead of IsStatic.
10389 * anonymous.cs (AnonymousMethod.Compatible): Pass the
10390 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
10391 set on the current EmitContext.
10393 * expression.cs (Cast): Overload DoResolveLValue so we can pass
10394 resolve our casted expression as an LValue. This triggers the
10395 proper LValue processing that is later required by Assign.
10399 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
10401 2005-02-11 Marek Safar <marek.safar@seznam.cz>
10403 C# 2.0 Fixed buffer implementation
10405 * anonymous.cs: Update after RegisterHelperClass renaming.
10407 * attribute.cs (AttributeTester.fixed_buffer_cache):
10408 Cache of external fixed buffers.
10409 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
10410 implementation if field is fixed buffer else null.
10413 (TypeContainer.AddField): Accept FieldMember instead of Field.
10414 (FieldBase.IsFieldClsCompliant): Extracted code from
10415 VerifyClsCompliance descendant customization.
10416 (FixedField): New class handles fixed buffer fields.
10417 (FixedFieldExternal): Keeps information about imported fixed
10419 (IFixedField): Make access to internal or external fixed buffer
10422 * cs-parser.jay: Add fixed buffer parsing.
10424 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
10427 * expression.cs (Indirection): Extended implementation to accept
10428 fixed buffer field.
10429 (PointerArithmetic.Emit): Get element from fixed buffer as well.
10430 (ElementAccess.MakePointerAccess): Get type as parameter.
10431 (DoResolve): Add fixed buffer field expression conversion.
10432 (DoResolveLValue): Ditto.
10433 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
10434 (ArrayPtr): Derives from FixedBufferPtr.
10435 (ArrayPtr.Emit): Add extra emit for array elements.
10437 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
10439 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
10440 for compiler generated types.
10441 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
10443 * statement.cs (Fixed): Refactored to be easier add fixed buffer
10444 and consume less memory.
10445 (Fixed.Resolve): Add fixed buffer case.
10447 * typemanager.cs (compiler_generated_attr_ctor,
10448 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
10449 (HasElementType): Add our own implementation to work on every
10452 2005-02-11 Miguel de Icaza <miguel@novell.com>
10454 * anonymous.cs (CaptureContext): Track whether `this' has been
10457 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
10458 only captured `this' if it was implicitly done (instance
10459 methods/variables were used).
10461 * codegen.cs (EmitContext.CaptureThis): New method to flag that
10462 `this' must be captured.
10464 2005-01-30 Miguel de Icaza <miguel@novell.com>
10466 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
10467 is null it means that there has been no need to capture anything,
10468 so we just create a sibling.
10470 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
10472 Just a partial fix. The other half is fairly elusive.
10474 2005-02-10 Raja R Harinath <rharinath@novell.com>
10476 Fix #52586, cs0121-4.cs.
10477 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
10478 and return a hashtable.
10479 (MemberCache.ClearDeclaredOnly): New.
10480 (MemberCache.MemberCache): Update to change. Make a deep copy of
10481 the method_hash of a base type too.
10482 (MemberCache.AddMethods): Adapt to having a deep copy of the base
10483 type methods. Overwrite entries with the same MethodHandle so
10484 that the ReflectedType is correct. The process leaves in base
10485 virtual functions and their overrides as distinct entries.
10486 (CacheEntry): Now a class instead of a struct. It shouldn't alter
10487 matters since it was boxed in a ArrayList before.
10488 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
10490 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
10491 case of a virtual function and its override (choose the overload
10493 (Invocation.OverloadResolve): Avoid 'override' members during
10494 'applicable_type' calculation.
10496 2005-02-09 Raja R Harinath <rharinath@novell.com>
10498 Combine two near-redundant caches.
10499 * typemanager.cs (method_params): Rename from method_internal_params.
10500 (TypeManager.GetParameterData): New. Replace
10501 Invocation.GetParameterData.
10502 (TypeManager.LookupParametersByBuilder): Remove.
10503 * expression.cs (Invocation.method_parameter_cache): Remove.
10504 (Invocation.GetParameterData): Remove.
10506 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
10509 2005-02-08 Raja R Harinath <rharinath@novell.com>
10512 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
10513 TypeManager.multicast_delegate_type is null, resolve it by looking
10514 up "System.MulticastDelegate".
10515 * rootcontext.cs (RootContext.ResolveCore): Simplify.
10517 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
10518 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
10519 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
10522 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
10523 (LabeledStatement.AddReference): New. Set 'referenced'.
10524 (Goto.Resolve): Use it.
10526 2005-02-05 John Luke <john.luke@gmail.com>
10528 * driver.cs: remove duplicate -doc line in Usage ()
10530 2005-02-04 Raja R Harinath <rharinath@novell.com>
10532 * location.cs (Location.AddFile): Fix CS2002 error report.
10534 2005-02-02 Martin Baulig <martin@ximian.com>
10536 * delegate.cs (Delegate.DefineType): Report an internal error if
10537 TypeManager.multicast_delegate_type is null. See bug #72015 for
10540 2005-02-02 Raja R Harinath <rharinath@novell.com>
10542 Fix a crasher in a variant of #31984.
10543 * const.cs (Constant.CheckBase): New override that defers the
10544 new-or-override check in case the base type hasn't been populated
10546 (Constant.Define): Ensure the new-or-override check is performed.
10548 2005-02-01 Duncan Mak <duncan@ximian.com>
10550 * const.cs (LookupConstantValue): Check that `ce' is not null
10551 before calling GetValue ().
10553 2005-02-01 Raja R Harinath <rharinath@novell.com>
10555 Fix test-334.cs (#69519).
10556 * cs-parser.jay (using_alias_directive): Pass in an expression to
10557 NamespaceEntry.UsingAlias.
10558 (using_namespace_directive): Pass in an expression to
10559 NamespaceEntry.Using.
10560 (namespace_name): Don't flatten to a string.
10561 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
10562 (NamespaceEntry.AliasEntry.Resolve): Lookup using
10564 (NamespaceEntry.UsingEntry): Likewise.
10565 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
10567 (NamespaceEntry.LookupForUsing): Remove.
10568 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
10570 (NamespaceEntry.Lookup): Remove support for dotted names.
10572 2005-02-01 Raja R Harinath <rharinath@novell.com>
10574 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
10576 (NamespaceEntry.ImplicitParent): Compute on demand.
10577 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
10578 parallels the current.
10579 (NamespaceEntry.LookupForUsing): Use it.
10580 (NamespaceEntry.Lookup): If the current namespace-entry is
10581 implicit, don't search aliases and using tables.
10583 2005-02-01 Raja R Harinath <rharinath@novell.com>
10586 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
10588 (TypeContainer.BaseCache): Compute on demand.
10589 (TypeContainer.FindMembers): Define constants and types if they're
10590 not already created.
10591 (FieldMember.Define): Move resetting of ec.InUnsafe before error
10593 * const.cs (Constant.Define): Make idempotent.
10595 2005-01-29 Miguel de Icaza <miguel@novell.com>
10597 * pending.cs: Produce better code (no nops produced by using Ldarg
10600 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
10601 i - 1' it should be arg + 1.
10605 2005-01-28 Raja R Harinath <rharinath@novell.com>
10607 * attribute.cs (Attribute.CheckAttributeType): Make private
10609 (Attribute.ResolveType): Make virtual.
10610 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
10611 handling of RootContext.Tree.Types.
10613 2005-01-27 Raja R Harinath <rharinath@novell.com>
10615 Update attribute-handling to use the SimpleName/MemberAccess
10617 * cs-parser.jay (attribute): Pass in an expression to the
10618 constructors of Attribute and GlobalAttribute.
10619 * attribute.cs (Attribute): Take an expression for the name.
10620 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
10621 passed in attribute name expression.
10622 (Attribute.CheckAttributeType): Use it.
10623 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
10624 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
10625 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
10626 argument to prevent error messages if the lookup fails.
10628 2005-01-27 Marek Safar <marek.safar@seznam.cz>
10630 * expression.cs (Indirection): Implemented IVariable interface
10631 to support indirection in AddressOf operator.
10632 (PointerArithmetic.Emit): Add optimalization for case where
10633 result can be precomputed.
10635 2005-01-26 Martin Baulig <martin@ximian.com>
10637 * class.cs (TypeContainer.AttributeTargets): Return the correct
10638 AttributeTargets depending on our `Kind' instead of throwing an
10639 exception; fixes #71632.
10641 2005-01-26 Marek Safar <marek.safar@seznam.cz>
10644 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
10647 2005-01-25 Raja R Harinath <rharinath@novell.com>
10650 * expression.cs (MemberAccess.DoResolve): Don't complain with
10651 cs0572 when the LHS of a member access has identical name and type
10654 2005-01-25 Marek Safar <marek.safar@seznam.cz>
10657 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
10659 Create custom PermissionSet only for PermissionSetAttribute.
10661 2005-01-24 Marek Safar <marek.safar@seznam.cz>
10664 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
10665 delegates in static class.
10667 2005-01-24 Martin Baulig <martin@ximian.com>
10669 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
10670 merging an implicit block, just use its reachability.
10672 * statement.cs (Block.Resolve): Make the unreachable code check
10673 work wrt. implicit blocks; see test-337 from #63842.
10675 2005-01-21 Alp Toker <alp@atoker.com>
10677 * cs-parser.jay: destructor_declaration's container is PartialContainer
10678 not Class when partial types are used, so use Kind prop instead of
10681 2005-01-22 Miguel de Icaza <miguel@ximian.com>
10683 * cs-parser.jay: Improve error reporting when an interface
10684 declares new types.
10686 2005-01-20 Dick Porter <dick@ximian.com>
10688 * support.cs: SeekableStreamReader fix from Sandor Dobos
10689 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
10690 chars are read. Fixes bug 70369.
10692 2005-01-20 Raja R Harinath <rharinath@novell.com>
10694 * cs-parser.jay (catch_clause): Simplify current_block handling
10697 2005-01-17 Miguel de Icaza <miguel@ximian.com>
10699 * convert.cs (ImplicitStandardConversionExists): Synchronize the
10700 code with ImplicitStandardConversion to handle the implicit
10701 conversion of method groups into valid delegate invocations.
10703 The problem is that in parameter handling we were using this code
10704 path. Fixes bug #64698
10706 2005-01-19 Raja R Harinath <rharinath@novell.com>
10708 * cs-parser.jay: Fix several infelicities.
10709 - Avoid assigning to the parser value stack. Code like
10710 '$3 = null' is unclean. Synthesize a value for the code block
10712 - Avoid using oob_stack for storing location information. Use ...
10713 (_mark_): ... this. New (empty) rule. Saves the current location
10715 (foreach_statement): Avoid using oob_stack for current_block
10716 handling. Use technique used in for_statement and
10717 using_statement. Synthesize a value for the code block to store
10718 additional intermediate information.
10720 2005-01-13 Miguel de Icaza <miguel@ximian.com>
10722 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
10723 of a different type is only allowed to private fields of a
10724 containing type, not on fields of a base class.
10726 See test-174.cs and error cs0122-9.cs
10728 2005-01-13 Raja R Harinath <rharinath@novell.com>
10730 Fix test-335.cs (bug #58126).
10731 * cs-parser.jay (argument): Split out non-expression parts of the
10732 rule into 'non_simple_argument'.
10733 (invocation_expression): Support parenthesized invocations with
10734 multiple arguments, and with single non-simple arguments.
10736 2005-01-13 Raja R Harinath <rharinath@novell.com>
10738 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
10741 2005-01-12 Raja R Harinath <rharinath@novell.com>
10743 Fix cs0038-1.cs, cs1640-6.cs.
10744 * ecore.cs (Expression.Resolve): Remove special-case for
10745 SimpleName in error-handling.
10746 (Expression.almostMatchedMembers): Relax access permission to
10748 (Expression.MemberLookupFailed): Handle duplicates in
10749 almostMatchedMembers list.
10750 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
10751 * expression.cs (New.DoResolve): Report CS1540 for more cases.
10752 * typemanager.cs (GetFullNameSignature): Use the MethodBase
10753 overload if the passed in MemberInfo is a MethodBase.
10755 2005-01-12 Marek Safar <marek.safar@seznam.cz>
10758 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
10759 for non-CAS & merge permission sets properly.
10761 2005-01-11 Raja R Harinath <rharinath@novell.com>
10763 Improve standard-compliance of simple name and member access
10764 resolution. Fixes bugs #52697, #57200, #67520, #69519.
10765 * ecore.cs (FullNamedExpression): New abstract base class
10766 for Namespaces and TypeExpressions.
10767 (ResolveFlags.SimpleName): Remove.
10768 (SimpleName): Remove support for dotted names.
10769 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
10770 DeclSpace.FindType and DeclSpace.LookupType.
10771 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
10772 (Expression.ExprClassName): Make member function.
10773 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
10774 a namespace. Remove creation of dotted "SimpleName"s.
10775 (MemberAccess.DoResolve): Likewise.
10776 * decl.cs (DeclSpace.Cache): Make private.
10777 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
10778 (DeclSpace.FindType): Update.
10779 (DeclSpace.LookupType): Move here from RootContext. Return a
10780 FullNamedExpression.
10781 * namespace.cs (Namespace): Derive from FullNamedExpression
10782 so that it can be part of expression resolution.
10783 (Namespace.Lookup): Return an FullNamedExpression.
10784 (NamespaceEntry.LookupAlias): Lookup aliases only in current
10786 * rootcontext.cs (NamespaceLookup): Remove.
10787 (LookupType): Move to DeclSpace.
10788 * attribute.cs (CheckAttributeType): Update.
10789 * doc.cs (FindDocumentedType): Remove allowAlias argument.
10790 (FindDocumentedTypeNonArray): Likewise.
10792 2005-01-11 Raja R Harinath <rharinath@novell.com>
10794 Fix cs0509.cs, cs1632.cs.
10795 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
10796 is the same as IsInterface.
10797 (TypeContainer.GetClassBases): Likewise.
10798 * statement.cs (LabeledStatement.ig): New field.
10799 (LabeledStatement.LabelTarget): Save ILGenerator which created the
10801 (LabeledStatement.DoEmit): Check that the label was created with
10802 the same ILGenerator.
10804 2005-01-10 Marek Safar <marek.safar@seznam.cz>
10807 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
10808 accessors to its properties.
10810 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
10811 from accessors to property.
10813 2005-01-10 Marek Safar <marek.safar@seznam.cz>
10816 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
10817 only for overrides.
10819 2005-01-08 Miguel de Icaza <miguel@ximian.com>
10821 * attribute.cs: Check for null and empty strings.
10823 I have lost another battle to Paolo.
10825 2005-01-07 Marek Safar <marek.safar@seznam.cz>
10828 * class.cs (PropertyMethod): Set Parent field in ctors.
10829 (SetMethod.InternalParameters): Add unsafe switch hack.
10830 Override MarkForDuplicationCheck where it is appropriate.
10832 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
10833 It says whether container allows members with the same name.
10834 Base default is no.
10835 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
10836 Removed is_method parameter.
10838 2005-01-06 Duncan Mak <duncan@ximian.com>
10840 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
10841 because the previous change led to incorrect reporting of CS1032
10842 ("Cannot define/undefine preprocessor symbols after first token in
10843 file"). Instead of using `tokens_seen' as the only flag that
10844 triggers CS1040, introduce `comments_seen'. This new flag is used
10845 to signify having seen comments on the current line, so it is
10846 unset after a newline.
10848 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
10850 * doc.cs : When searching for a type, find nested type too.
10851 This fixes bug #71040.
10853 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
10856 - Warn missing member comment on those classes which also does not
10857 have doc comments. Fixed bug #71041.
10858 - Don't warn missing doc comment on default constructor.
10861 2005-01-06 Duncan Mak <duncan@ximian.com>
10863 * cs-tokenizer.cs (xtoken): After handling traditional C-style
10864 comments, set `tokens_seen' to true. This allows us to detect
10865 misplaced preprocessor directives (i.e. not at the beginning of
10866 the a line, nor after whitespaces). In that case, report error
10867 CS1040. This fixes bug #56460.
10869 * cs-parser.jay (interface_member_declaration): Add checks for
10870 IsExplicitImpl, and report CS0541 error if an interface member is
10871 defined as an explicit interface declaration.
10873 2005-01-06 Marek Safar <marek.safar@seznam.cz>
10876 * class.cs (PropertyMethod): Set Parent field in ctors.
10877 (SetMethod.InternalParameters): Add unsafe switch hack.
10879 * decl.cs (MemberCore.Parent): Cannot be readonly.
10881 2005-01-06 Raja R Harinath <rharinath@novell.com>
10883 * decl.cs (DeclSpace.ResolveType): Remove.
10884 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
10885 Merge in code from ...
10886 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
10887 * class.cs, enum.cs: Update to changes.
10889 2005-01-06 Miguel de Icaza <miguel@ximian.com>
10891 * anonymous.cs: Ensure that we init the scope of our parent if it
10892 has not been initialized yet.
10894 2004-12-30 Duncan Mak <duncan@ximian.com>
10896 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
10897 if field.FieldBuilder is null. Fixes #70758.
10899 * convert.cs: Fixed some typos and updated some of the comments.
10900 (ImplicitStandardConversionExists):
10901 (TryImplicitIntConversion): If `target_type' is an interface and
10902 the type of `ic' implements this interface, return true or a new
10903 BoxedCast instead of null. This fixes #70468.
10905 2004-12-29 Duncan Mak <duncan@ximian.com>
10907 * expression.cs (Argument.Emit): Check that Expr is
10908 IMemoryLocation before casting to it, and report CS1510 otherwise.
10912 2004-12-21 Ben Maurer <bmaurer@ximian.com>
10914 * statement.cs (Block.ThisVariable): remove the recursion here, to
10915 make the --profile more sane.
10917 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
10919 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
10920 assembly, by JB Evain.
10922 2004-12-17 Raja R Harinath <rharinath@novell.com>
10924 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
10925 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
10926 "parent" refers to enclosing type/class. "base" refers to superclass.
10928 2004-12-17 Raja R Harinath <rharinath@novell.com>
10930 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10931 Ensure that we only have GlobalAttributes.
10932 * attribute.cs (Attribute.Emit): Make non-virtual.
10933 (GlobalAttribute.Emit): Remove.
10934 (Attribute.Resolve): Make virtual.
10935 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
10936 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
10937 the argument. Don't create one.
10938 (Attribute.GetObsoleteAttribute): Likewise.
10939 (Attribute.GetClsCompliantAttributeValue): Likewise.
10940 * class.cs, decl.cs: Update to changes.
10942 2004-12-17 Marek Safar <marek.safar@seznam.cz>
10944 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
10946 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
10948 * statement.cs (Foreach.Resolve): Add error 186 report.
10950 2004-12-16 Marek Safar <marek.safar@seznam.cz>
10952 * expression.cs (Conditional.DoResolve): Add warning 429.
10954 * statement.cs (If.Resolve): Add warning 665.
10956 2004-12-16 Raja R Harinath <rharinath@novell.com>
10958 New invariant: RootContext.Tree.Types.NamespaceEntry == null
10959 except when in the parser, and in GlobalAttribute.
10960 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
10961 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
10962 RootContext.Tree.Types.NamespaceEntry once work is done.
10963 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
10964 and resets RootContext.Tree.Types.NamespaceEntry.
10966 2004-12-15 Marek Safar <marek.safar@seznam.cz>
10968 * cs-parser.jay: Don't create a block for every variable.
10970 2004-12-14 Miguel de Icaza <miguel@ximian.com>
10972 * location.cs: Provide extra information.
10974 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
10975 variables from the captured environment, it is the ldarg_0.
10977 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10979 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
10982 * class.cs: Changed warning level for 169 to avoid developer
10983 displeasure from warning flooding. It will be changed back when they
10984 fix most of current BCL warnings.
10986 * RootContext.cs: Pushed default WarningLevel to 3.
10988 * statement.cs: Removed unused variable.
10990 2004-12-14 Marek Safar <marek.safar@seznam.cz>
10992 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
10993 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
10994 Add error 502 report.
10995 (StaticClass.DefineType): Add error 441 report.
10996 (Class.AllowedModifiersProp): New virtual property as temporary
10997 extension to AllowedModifiers.
10998 (Class.DefineType): Add error 418 report. Moved ModFlags check here
10999 to share implementation with StaticClass and don't call virtual
11002 * driver.cs (MainDriver): Add error 1558 test.
11004 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
11005 report. Moved error 36 test here.
11007 * statement.cs (Throw.Resolve): Add error 724 report.
11009 * typemanager.cs: Add out_attribute_type core type.
11011 2004-12-13 Marek Safar <marek.safar@seznam.cz>
11013 * class.cs (TypeContainer.VerifyClsCompliance): Add error
11015 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
11017 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
11020 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
11022 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
11023 Add error 3023 report.
11024 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
11026 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
11029 2004-12-12 John Luke <john.luke@gmail.com>
11031 * driver.cs (AddArgs): take -- into account when
11032 adding arguments, fixes bug 65710
11034 2004-12-12 Martin Baulig <martin@ximian.com>
11036 * expression.cs (Unary.TryReduceNegative): Added support for
11037 SByteConstant and ByteConstant.
11038 (Unary.Reduce): Check error values from TryReduceNegative().
11040 2004-12-10 Marek Safar <marek.safar@seznam.cz>
11042 * attributes.cs (Attribute.Resolve): Avoid multiple error report
11043 and report exception as error 182.
11045 2004-12-10 Raja R Harinath <rharinath@novell.com>
11047 * driver.cs (Main): Fix message when there are warnings.
11049 2004-12-09 Miguel de Icaza <miguel@ximian.com>
11051 * delegate.cs: Fixed my fix from yesterday, sorry about that.
11053 2004-12-09 Marek Safar <marek.safar@seznam.cz>
11055 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
11056 Reduced number of warnings.
11058 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
11060 2004-12-08 Miguel de Icaza <miguel@ximian.com>
11062 * driver.cs: Removed message.
11064 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
11066 2004-12-08 <vargaz@freemail.hu>
11068 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
11070 2004-12-08 Martin Baulig <martin@ximian.com>
11072 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
11073 instead of a CS3002 for properties and indexer.
11075 2004-12-08 Martin Baulig <martin@ximian.com>
11077 * decl.cs (MemberName.ToString): Make this work again.
11079 2004-12-08 Marek Safar <marek.safar@seznam.cz>
11081 * attribute.cs (Resolve): Add error 591 detection.
11083 * class.cs (FieldMember.Define): Add error 1547 detection.
11084 (Indexer.Define): Add error 620 detection.
11085 (Operator.Define): Add error 590 detection.
11087 * ecore.cs: Missing argument for error 79.
11089 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
11092 2004-12-07 Marek Safar <marek.safar@seznam.cz>
11095 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
11098 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
11100 * cs-parser.jay : handle doc comments on implicit/explicit operators.
11101 Some operator comments were suppressed.
11102 * doc.cs : Implicit/explicit operator name in doc comments are like
11103 "op_Explicit(type)~returnType", so added suffix handling.
11105 2004-12-07 Martin Baulig <martin@ximian.com>
11108 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
11109 (MemberCore.GetClsCompliantAttributeValue): Likewise.
11110 (DeclSpace.ec): New protected field; store the EmitContext here.
11111 (DeclSpace.EmitContext): New public property; moved here from
11113 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
11116 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
11117 (Enum.Emit): Don't create a new EmitContext.
11119 * delegate.cs (Delegate.DefineType): Always create the
11122 * iterators.cs (Iterators.DefineIterator): Create a new
11123 EmitContext and store it in `ec'.
11125 2004-08-24 Martin Baulig <martin@ximian.com>
11128 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
11129 this for accessibility checks.
11130 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
11131 IsNestedFamilyAccessible.
11132 (TypeManager.IsSubclassOf): New method, do what the name actually
11135 2004-12-06 Raja R Harinath <rharinath@novell.com>
11137 Fix crash on cs0657-17.cs.
11138 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11139 Use RootContext.Tree.Types, not 'new RootTypes ()'.
11140 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
11141 the case where the NamespaceEntry gets overwritten.
11143 2004-12-06 Marek Safar <marek.safar@seznam.cz>
11145 Fixed #69195, #56821
11146 * ecore.cs (ResolveBoolean): Tiny refactoring.
11148 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
11149 of right expression resolving when left is false constant and
11150 operator is LogicalAnd OR true constant and operator is LogicalOr.
11152 * statement.cs (ResolveUnreachable): Always reports warning.
11154 2004-12-05 Miguel de Icaza <miguel@ximian.com>
11156 * class.cs: Distinguish between 1721 and 1722 (just a little help
11157 for the programmer).
11159 2004-12-03 Miguel de Icaza <miguel@ximian.com>
11161 * delegate.cs: Only allow this on new versions of the language.
11163 2004-12-02 Duncan Mak <duncan@ximian.com>
11165 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
11167 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
11168 here as a static method. Take an additional bool out parameter
11169 `must_do_cs1540_check' for signaling to InstanceResolve.
11170 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
11171 member field from PropertyExpr class and made it an argument of
11172 the method instead.
11173 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
11174 check for MarshalByRefObject, and report CS0122 instead of CS1540.
11175 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
11176 and `remove_accessor' as well as InstanceResolve: report CS0122
11181 2004-12-03 Raja R Harinath <rharinath@novell.com>
11183 Fix test-327.cs, test-328.cs, and put in early infrastructure
11184 for eventually fixing #52697.
11185 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
11186 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
11187 from other methods.
11188 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
11189 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
11190 (VerifyUsing, error246): Update.
11191 * rootcontext.cs (RootContext.NamespaceLookup): Just use
11192 'NamespaceEntry.LookupNamespaceOrType'.
11194 2004-12-03 Martin Baulig <martin@ximian.com>
11196 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11197 method as our child, call AnonymousMethod.Compatible() on it.
11199 2004-12-03 Raja R Harinath <rharinath@novell.com>
11201 Disable XML documentation support in 'basic' profile.
11202 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
11203 Redirect XmlElement to System.Object.
11204 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
11205 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
11206 * mcs.exe.sources: Add doc-bootstrap.cs.
11207 * doc-bootstrap.cs: New file. Contains empty stub implementation
11210 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
11212 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
11213 comments are allowed.
11215 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11217 * delegate.cs: Add checks for subtypes in paramaters and return values
11218 in VerifyMethod () to add support for Covariance/Contravariance
11221 2004-12-02 Miguel de Icaza <miguel@ximian.com>
11223 * report.cs: Remove extra closing parenthesis.
11225 * convert.cs (Error_CannotImplicitConversion): If the name of the
11226 types are the same, provide some extra information.
11228 * class.cs (FieldBase): Use an unused bit field from the field to
11229 encode the `has_offset' property from the FieldMember. This saves
11230 a couple of Ks on bootstrap compilation.
11232 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11233 method as our child, return the AnonymousMethod resolved
11236 * expression.cs (New.DoResolve): Allow return values from
11237 NewDelegate to also include AnonymousMethods.
11241 2004-12-02 Marek Safar <marek.safar@seznam.cz>
11244 * attribute.cs (Resolve): Improved implementation of params
11245 attribute arguments.
11247 * support.cs (ParameterData): Add HasParams to be faster.
11249 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
11251 all things are for /doc support:
11253 * doc.cs: new file that supports XML documentation generation.
11254 * mcs.exe.sources: added doc.cs.
11256 Handle /doc command line option.
11257 Report error 2006 instead of 5 for missing file name for /doc.
11258 Generate XML documentation when required, after type resolution.
11260 Added support for picking up documentation (/// and /** ... */),
11261 including a new XmlCommentState enumeration.
11263 Added lines to fill Documentation element for field, constant,
11264 property, indexer, method, constructor, destructor, operator, event
11265 and class, struct, interface, delegate, enum.
11266 Added lines to warn incorrect comment.
11268 Added Documentation field (passed only when /doc was specified).
11270 Added DocComment, DocCommentHeader, GenerateDocComment() and
11271 OnGenerateDocComment() and some supporting private members for
11272 /doc feature to MemberCore.
11274 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
11276 Added overriden DocCommentHeader.
11278 Added overriden DocCommentHeader and GenerateDocComment().
11280 2004-12-01 Miguel de Icaza <miguel@ximian.com>
11282 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
11283 unwrapping the enumeration values, chain to
11284 DoConstantNumericPromotions again, so we can promote things to the
11285 fundamental types (takes care of enums that are bytes, sbytes).
11289 2004-12-01 Raja R Harinath <rharinath@novell.com>
11291 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
11292 Fix long-standing bug in type-lookup. Use FindType instead of
11293 LookupType when ec.ResolvingTypeTree.
11294 (Attribute.ResolveType, Attribute.Resolve)
11295 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
11297 (Attributes.Search): Remove internal version. Update.
11298 (Attributes.SearchMulti): Update.
11299 (Attributes.GetClsCompliantAttribute): Remove.
11300 (Attributes.GetIndexerNameAttribute): Remove.
11301 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
11302 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
11303 * class.cs (Indexer.Define): Likewise.
11305 2004-12-01 Marek Safar <marek.safar@seznam.cz>
11308 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
11309 MarshallByReference members access.
11311 * expression.cs: Use CheckMarshallByRefAccess;
11312 Better error CS0197 message.
11314 * report.cs: Print whole related error message.
11316 2004-11-30 Raja R Harinath <rharinath@novell.com>
11318 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
11319 the current directory to help debugging.
11321 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11323 * class (GetClassBases): Better error 60 report.
11324 (EventProperty): Disabled warning 67 detection.
11326 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11329 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
11331 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
11334 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11337 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
11339 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
11341 2004-11-26 Miguel de Icaza <miguel@ximian.com>
11343 * attribute.cs (Attribute.Resolve): Refine error reporting and
11344 report a cs0117 if the identifier does not exist, to distinguish
11345 from 0617 which is a miss-use of the actual identifier.
11347 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
11348 between cs0070 and cs0079.
11350 * class.cs (MemberBase.DoDefine): When reporting a wrong
11351 accessibility level, we use MethodCore to compare instead of
11352 Method (this was a regression in some refactoring effort).
11354 So now we correctly report cs0056 again.
11356 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
11357 testing the target_type (which was known to be object_type) and
11358 not the source type (which is anonymous_method).
11360 Fixed reporting of error cs1660.
11362 * expression.cs (UserCast.Source): Expose the underlying cast.
11364 * statement.cs (Switch.SwitchGoverningType): Sort the list of
11365 allowed types to find a match to int32 first (most common).
11367 In addition, it ignores any ImplicitUserConversions that did an
11368 internal implicit conversion (as the switch statement allows only
11369 one integral conversion to exist).
11371 * class.cs (PartialContainer.Create): rename `name' to
11372 `member_name' for clarity. Then replace the string calls with a
11373 call to MemberName.GetPartialName, as now using
11374 MemberName.ToString is an error (this is due to the side effects
11375 it had, that were fixed in the past).
11377 This will restore the error reporting on a number of partial class
11378 errors that were missusing this (and getting an exception as a
11379 results, which is now just a plain textual warning, because
11380 yyparse debug output would crash otherwise).
11382 2004-11-26 Raja R Harinath <rharinath@novell.com>
11384 * Makefile (PROGRAM_INSTALL_DIR): Remove.
11386 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11388 * rootcontext.cs (LookupType): Make sure to cache lookups that
11389 don't give us a negative result. This saves about 5% of corlib
11392 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11394 * report.cs (AbstractMessage.Print): messages are sent to stderr
11396 * class.cs (TypeContainer.GetClassBases): It is an error to have a
11397 non-interface in the list of interfaces (at this point, either
11398 parent was properly set, or a base class is being listed in the
11399 interfaces section).
11401 This flags error 1722, and resolves the crash from bug 69259.
11403 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11405 * statement.cs (Using.EmitExpressionFinally): make this work right
11406 for valuetypes. Fixes 69926.
11408 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11410 * const.cs (Const.ChangeType): Cope with the "0 literal can be
11411 converted to an enum" here, before we try to change the underlying
11412 type. This code exists, but it is a different code path than the
11413 one used while encoding constants.
11415 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
11416 old bug: when converting from the null literal to a pointer,
11417 return an EmptyCast, not the NullLiteral.
11419 This fixes #69921, the recent null_type changes probably made this
11420 bug more prominent.
11422 (ImplicitReferenceConversionExists): In addition, resynchronized
11423 the code here, so it matches the same code in
11424 ImplicitReferenceConversionExists for the `from any class-type S
11425 to any interface-type T'.
11428 2004-11-25 Marek Safar <marek.safar@seznam.cz>
11430 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
11432 2004-11-24 Miguel de Icaza <miguel@ximian.com>
11434 * cs-parser.jay: Use verbosity accordingly.
11436 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11438 * expression.cs (Unary.ResolveOperator): Do not report warning;
11439 AddressOf reads from variable.
11441 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
11443 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11447 * attribute.cs (Attributable): Removed CheckTargets.
11448 (Attributes.Emit): Explicit attribute targets are tested here.
11450 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
11451 not enabled for interfaces.
11453 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
11454 (GetAssemblyName): Ouch next bug there.
11456 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11458 * expression.cs: Error 275 added.
11460 2004-11-23 Marek Safar <marek.safar@seznam.cz>
11462 Fix bug #69177 (Implemented decimal constant support)
11464 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
11465 (BinaryFold): Add DecimalConstant.
11467 * const.cs (Define): Decimal constant
11469 (ChangeType): Add decimal type handling.
11470 (LookupConstantValue): Don't set value for decimal type but
11471 emit DecimalConstantAttribute. Needed for constant optimization.
11473 * constant.cs (ToDecimal): New method.
11474 (ConvertToDecimal): New method.
11475 (IntConstant): Implemented ConvertToDecimal.
11476 (DecimalConstant.Emit): Emit optimized version for decimals in
11479 * expression.cs (ResolveOperator): Changed order of constant
11480 reduction to work correctly with native types which have
11481 overloaded operators.
11482 (ResolveMemberAccess): Extract constant value from attribute
11485 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
11487 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
11488 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
11489 (ChangeType): Decimal is special.
11490 (TypeToCoreType): Add decimal type.
11492 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11494 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
11497 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11499 * class.cs (EventField.ApplyAttributeBuilder): Fix error
11502 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11504 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
11506 * pending.cs (PendingImplementation): Grab only interfaces.
11508 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11510 * statement.cs (ForeachHelperMethods): Add location member and
11511 error 202 detection.
11513 2004-11-19 Raja R Harinath <rharinath@novell.com>
11515 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
11516 automatically handled by executable.make.
11517 (PROGRAM): Make profile-specific.
11519 2004-11-18 Marek Safar <marek.safar@seznam.cz>
11521 * expression.cs (DoResolveBase): Fixed wrong warning for out
11524 2004-11-18 Martin Baulig <martin@ximian.com>
11526 Merged latest changes into gmcs. Please keep this comment in
11527 here, it makes it easier for me to see what changed in MCS since
11528 the last time I merged.
11530 2004-11-17 Raja R Harinath <rharinath@novell.com>
11532 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
11533 (TypeHandle.GetMemberCache): New.
11534 (TypeHandle.TypeHandle): Update.
11535 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
11536 (TypeManager.LookupParentInterfacesCache):
11537 Rename from LookupInterfaceCache. Optimize slightly.
11538 (TypeManager.MemberLookup_FindMembers): Update.
11539 * decl.cs (MemberCache.MemberCache): Set Container to null in the
11540 multi-type variant.
11541 (AddCacheContents): Rename from AddHashtable.
11542 * class.cs (TypeContainer.parent_container): Remove.
11543 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
11544 (TypeContainer.DoDefineMembers): Don't initialize it.
11545 Update to name changes.
11547 2004-11-17 Miguel de Icaza <miguel@ximian.com>
11549 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
11550 that factors the code to check access modifiers on override.
11552 (PropertyBase): Use the code here.
11554 Patch from Lluis S'anchez, fixes bug #69361.
11556 2004-11-15 Miguel de Icaza <miguel@ximian.com>
11558 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
11559 routine that is used to report the use of a captured variable
11560 whose address has been taken.
11562 There are two checks: one when variables are being captured and
11563 the other check is when the address of a variable is taken.
11565 (because an anonymous methods might be resolved before *or* after
11566 the address has been taken) and
11568 * expression.cs (Conditional.DoResolve): Remove the special
11569 casing that Martin added to trueExpr and falseExpr being both
11570 NullLiteral. We get the right behavior now just by introducing
11571 the null_type into the compiler.
11573 * convert.cs (ExplicitConversion): Change the code to use
11574 null_type instead of testing `expr is NullLiteral'.
11575 (ImplicitConversionStandard): use null_type too.
11576 (ImplicitReferenceConversionExists): use null_type too.
11577 (ImplicitReferenceConversion): use null_type too.
11579 * literal.cs: The type of `NullLiteral' is now null_type instead
11581 (Resolve): Set the type here.
11583 * typemanager.cs: Introduce null_type.
11585 2004-11-17 Martin Baulig <martin@ximian.com>
11587 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
11588 direction, like FindMembers() does. Fixes #69546, testcase is in
11591 2004-11-16 Martin Baulig <martin@ximian.com>
11593 This is based on a patch from Marek Safar, see bug #69082.
11594 Fixes bugs #63705 and #67130.
11596 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
11597 method; create a MemberCache for an interface type and cache the
11600 * decl.cs (IMemberContainer.ParentContainer): Removed.
11601 (IMemberContainer.ParentCache): New property.
11602 (MemberCache.SetupCacheForInterface): Removed.
11603 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
11604 to create a cache for an interface's "parent".
11606 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
11609 2004-11-16 Martin Baulig <martin@ximian.com>
11611 Merged back from gmcs; these changes already went into gmcs a
11612 couple of weeks ago.
11615 (TypeManager.AddUserType): Removed the `ifaces' argument.
11616 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
11618 (TypeManager.AddUserInterface): Removed.
11619 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
11621 (TypeManager.GetInterfaces): Likewise.
11622 (TypeManager.GetExplicitInterfaces): Likewise.
11624 * ecore.cs (TypeExpr.GetInterfaces): Removed.
11626 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
11627 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
11629 2004-11-14 Ben Maurer <bmaurer@ximian.com>
11631 * statement.cs: Avoid adding bools to a hashtable.
11633 2004-11-07 Miguel de Icaza <miguel@ximian.com>
11635 * expression.cs (Invocation.OverloadResolve): Flag error if we are
11636 calling an unsafe method from a safe location.
11638 2004-11-06 Marek Safar <marek.safar@seznam.cz>
11641 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
11643 2004-11-06 Miguel de Icaza <miguel@ximian.com>
11645 * namespace.cs (VerifyUsing): use GetPartialName instead of
11648 2004-11-05 Miguel de Icaza <miguel@ximian.com>
11650 * statement.cs (Return.Resolve): Fix regression in typo: if
11651 `in_exc', we have to request a NeedReturnLabel, this was a typo
11652 introduced in the anonymous method check-in. Fixes #69131.
11654 * Indexers were using the ShortName when defining themselves,
11655 causing a regression in the compiler bootstrap when applying the
11656 patch from 2004-11-02 (first part), now they use their full name
11657 and the bug is gone.
11659 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
11661 * driver.cs: Strip the path from the names of embedded resources. Fixes
11664 2004-11-04 Raja R Harinath <rharinath@novell.com>
11666 Fix error message regression: cs0104-2.cs.
11667 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
11668 (AliasEntry.Resolve): Update.
11669 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
11671 (RootContext.LookupType): Update.
11673 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
11675 * cs-parser.jay: Add support for handling accessor modifiers
11676 * class: Add support port accessor modifiers and error checking,
11677 define PropertyMethod.Define as virtual (not abstract anymore)
11678 * ecore.cs: Add checking for proeprties access with access modifiers
11679 * iterators.cs: Modify Accessor constructor call based in the modified
11681 2004-11-02 Ben Maurer <bmaurer@ximian.com>
11683 * expression.cs (StringConcat): Handle being called twice,
11684 as when we have a concat in a field init with more than two
11687 2004-11-02 Miguel de Icaza <miguel@ximian.com>
11689 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
11690 special case explicit implementations, we should always produce
11691 the .property or .event declaration.
11693 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
11694 since it will not return correct data if people use this
11695 unresolved in the presence of using statements (see test-313).
11697 * class.cs (MethodData.Define): If we are an explicit interface
11698 implementation, set the method name to the full name of the
11699 interface plus the name of the method.
11701 Notice that using the method.MethodName.GetFullName() does not
11702 work, as it will only contain the name as declared on the source
11703 file (it can be a shorthand in the presence of using statements)
11704 and not the fully qualifed type name, for example:
11708 class D : ICloneable {
11709 object ICloneable.Clone () {
11713 Would produce a method called `ICloneable.Clone' instead of
11714 `System.ICloneable.Clone'.
11716 * namespace.cs (Alias.Resolve): Use GetPartialName.
11718 2004-11-01 Marek Safar <marek.safar@seznam.cz>
11720 * cs-parser.jay: Add error 1055 report.
11722 2004-11-01 Miguel de Icaza <miguel@ximian.com>
11724 * assign.cs (Assign.DoResolve): Only do the transform of
11725 assignment into a New if the types are compatible, if not, fall
11726 through and let the implicit code deal with the errors and with
11727 the necessary conversions.
11729 2004-11-01 Marek Safar <marek.safar@seznam.cz>
11731 * cs-parser.jay: Add error 1031 report.
11733 * cs-tokenizer.cs: Add location for error 1038.
11735 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11737 * cs-parser.jay: Add error 1016 report.
11739 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11741 * cs-parser.jay: Add errors 1575,1611 report.
11743 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11745 * cs-parser.jay: Add error 1001 report.
11747 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11750 * attribute.cs (GetMarshal): Add method argument for
11751 caller identification.
11753 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
11754 agument for GetMarshal and RuntimeMissingSupport.
11756 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11758 * attribute.cs (ExtractSecurityPermissionSet): Removed
11759 TypeManager.code_access_permission_type.
11761 * typemanager.cs: Removed TypeManager.code_access_permission_type.
11763 2004-10-27 Miguel de Icaza <miguel@ximian.com>
11765 * expression.cs (LocalVariableReference.DoResolveLValue): Check
11766 for obsolete use of a variable here. Fixes regression on errors
11767 cs0619-25 and cs0619-26.
11769 2004-10-27 Marek Safar <marek.safar@seznam.cz>
11771 Fix #62358, implemented security attribute encoding.
11773 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
11774 Tests permitted SecurityAction for assembly or other types.
11775 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
11776 data from SecurityPermissionAttribute to PermisionSet class.
11778 * class.cs (ApplyAttributeBuilder): Added special handling
11779 for System.Security.Permissions.SecurityAttribute based types.
11781 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
11782 special handling for System.Security.Permissions.SecurityAttribute
11785 * enum.cs (ApplyAttributeBuilder): Added special handling
11786 for System.Security.Permissions.SecurityAttribute based types.
11788 * parameter.cs (ApplyAttributeBuilder): Added special handling
11789 for System.Security.Permissions.SecurityAttribute based types.
11791 * rootcontext.cs: Next 2 core types.
11793 * typemanager.cs (TypeManager.security_permission_attr_type):
11794 Built in type for the SecurityPermission Attribute.
11795 (code_access_permission_type): Build in type.
11797 2004-10-17 Miguel de Icaza <miguel@ximian.com>
11799 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
11800 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
11801 all of this information into
11802 EmitContext.EmitCapturedVariableInstance.
11804 * codegen.cs (EmitCapturedVariableInstance): move here the
11805 funcionality of emitting an ldarg.0 in the presence of a
11806 remapping. This centralizes the instance emit code.
11808 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
11809 then emit a load of this: it means that we have reached the
11810 topmost ScopeInfo: the one that contains the pointer to the
11811 instance of the class hosting the anonymous method.
11813 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
11814 captures to the topmost CaptureContext.
11816 2004-10-12 Miguel de Icaza <miguel@ximian.com>
11818 * expression.cs (LocalVariableReference): Move the knowledge about
11819 the iterators into codegen's EmitCapturedVariableInstance.
11821 2004-10-11 Miguel de Icaza <miguel@ximian.com>
11823 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
11824 all code paths return a value from an anonymous method (it is the
11825 same as the 161 error, but for anonymous methods).
11827 2004-10-08 Miguel de Icaza <miguel@ximian.com>
11829 The introduction of anonymous methods in the compiler changed
11830 various ways of doing things in the compiler. The most
11831 significant one is the hard split between the resolution phase
11832 and the emission phases of the compiler.
11834 For instance, routines that referenced local variables no
11835 longer can safely create temporary variables during the
11836 resolution phase: they must do so from the emission phase,
11837 since the variable might have been "captured", hence access to
11838 it can not be done with the local-variable operations from the runtime.
11842 (Block.Flags): New flag `IsTopLevel' to indicate that this block
11843 is a toplevel block.
11845 (ToplevelBlock): A new kind of Block, these are the blocks that
11846 are created by the parser for all toplevel method bodies. These
11847 include methods, accessors and anonymous methods.
11849 These contain some extra information not found in regular blocks:
11850 A pointer to an optional CaptureContext (for tracking captured
11851 local variables and parameters). A pointer to the parent
11854 (Return.Resolve): Catch missmatches when returning a value from an
11855 anonymous method (error 1662).
11856 Invoke NeedReturnLabel from the Resolve phase instead of the emit
11859 (Break.Resolve): ditto.
11861 (SwitchLabel): instead of defining the labels during the
11862 resolution phase, we now turned the public ILLabel and ILLabelCode
11863 labels into methods called GetILLabelCode() and GetILLabel() that
11864 only define the label during the Emit phase.
11866 (GotoCase): Track the SwitchLabel instead of the computed label
11867 (its contained therein). Emit the code by using
11868 SwitchLabel.GetILLabelCode ().
11870 (LocalInfo.Flags.Captured): A new flag has been introduce to track
11871 whether the Local has been captured or not.
11873 (LocalInfo.IsCaptured): New property, used to tell whether the
11874 local has been captured.
11876 * anonymous.cs: Vastly updated to contain the anonymous method
11879 The main classes here are: CaptureContext which tracks any
11880 captured information for a toplevel block and ScopeInfo used to
11881 track the activation frames for various local variables.
11883 Each toplevel block has an optional capture context associated
11884 with it. When a method contains an anonymous method both the
11885 toplevel method and the anonymous method will create a capture
11886 context. When variables or parameters are captured, they are
11887 recorded on the CaptureContext that owns them, for example:
11891 MyDelegate d = delegate {
11896 Here `a' will be recorded as captured on the toplevel
11897 CapturedContext, the inner captured context will not have anything
11898 (it will only have data if local variables or parameters from it
11899 are captured in a nested anonymous method.
11901 The ScopeInfo is used to track the activation frames for local
11902 variables, for example:
11904 for (int i = 0; i < 10; i++)
11905 for (int j = 0; j < 10; j++){
11906 MyDelegate d = delegate {
11911 At runtime this captures a single captured variable `i', but it
11912 captures 10 different versions of the variable `j'. The variable
11913 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
11914 recorded on a child.
11916 The toplevel ScopeInfo will also track information like the `this'
11917 pointer if instance variables were referenced (this is necessary
11918 as the anonymous method lives inside a nested class in the host
11919 type of the method).
11921 (AnonymousMethod): Expanded to track the Toplevel, implement
11922 `AnonymousMethod.Compatible' to tell whether an anonymous method
11923 can be converted to a target delegate type.
11925 The routine now also produces the anonymous method content
11927 (AnonymousDelegate): A helper class that derives from
11928 DelegateCreation, this is used to generate the code necessary to
11929 produce the delegate for the anonymous method that was created.
11931 * assign.cs: API adjustments for new changes in
11932 Convert.ImplicitStandardConversionExists.
11934 * class.cs: Adjustments to cope with the fact that now toplevel
11935 blocks are of type `ToplevelBlock'.
11937 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
11938 insteda of standard blocks.
11940 Flag errors if params arguments are passed to anonymous methods.
11942 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
11943 `CurrentAnonymousMethod' which points to the current Anonymous
11944 Method. The variable points to the AnonymousMethod class that
11945 holds the code being compiled. It is set in the new EmitContext
11946 created for the anonymous method.
11948 (EmitContext.Phase): Introduce a variable and an enumeration to
11949 assist in enforcing some rules about when and where we are allowed
11950 to invoke certain methods (EmitContext.NeedsReturnLabel is the
11951 only one that enfonces this right now).
11953 (EmitContext.HaveCaptureInfo): new helper method that returns
11954 whether we have a CapturedContext initialized.
11956 (EmitContext.CaptureVariable): New method used to register that a
11957 LocalInfo must be flagged for capturing.
11959 (EmitContext.CapturedParameter): New method used to register that a
11960 parameters must be flagged for capturing.
11962 (EmitContext.CapturedField): New method used to register that a
11963 field must be flagged for capturing.
11965 (EmitContext.HaveCapturedVariables,
11966 EmitContext.HaveCapturedFields): Return whether there are captured
11967 variables or fields.
11969 (EmitContext.EmitMethodHostInstance): This is used to emit the
11970 instance for the anonymous method. The instance might be null
11971 (static methods), this (for anonymous methods that capture nothing
11972 and happen to live side-by-side with the current method body) or a
11973 more complicated expression if the method has a CaptureContext.
11975 (EmitContext.EmitTopBlock): Routine that drives the emission of
11976 code: it will first resolve the top block, then emit any metadata
11977 and then emit the code. The split is done so that we can extract
11978 any anonymous methods and flag any captured variables/parameters.
11980 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
11981 during this phase, the ILGenerator should not be used as labels
11982 and local variables declared here might not be accessible to any
11983 code that is part of an anonymous method.
11985 Exceptions to this include the temporary variables that are
11986 created by some statements internally for holding temporary
11989 (EmitContext.EmitMeta): New routine, in charge of emitting all the
11992 (EmitContext.TemporaryReturn): This method is typically called
11993 from the Emit phase, and its the only place where we allow the
11994 ReturnLabel to be defined other than the EmitMeta. The reason is
11995 that otherwise we would have to duplicate a lot of logic in the
11996 Resolve phases of various methods that today is on the Emit
11999 (EmitContext.NeedReturnLabel): This no longer creates the label,
12000 as the ILGenerator is not valid during the resolve phase.
12002 (EmitContext.EmitThis): Extended the knowledge in this class to
12003 work in anonymous methods in addition to iterators.
12005 (EmitContext.EmitCapturedVariableInstance): This emits whatever
12006 code is necessary on the stack to access the instance to a local
12007 variable (the variable will be accessed as a field).
12009 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
12010 EmitContext.EmitAddressOfParameter): Routines to support
12011 parameters (not completed at this point).
12013 Removals: Removed RemapLocal and RemapLocalLValue. We probably
12014 will also remove the parameters.
12016 * convert.cs (Convert): Define a `ConstantEC' which points to a
12017 null. This is just to prefity some code that uses
12018 ImplicitStandardConversion code and do not have an EmitContext
12021 The idea is to flag explicitly that at that point in time, it is
12022 known that the conversion will not trigger the delegate checking
12023 code in implicit conversions (which requires a valid
12026 Everywhere: pass new EmitContext parameter since
12027 ImplicitStandardConversionExists now requires it to check for
12028 anonymous method conversions.
12030 (Convert.ImplicitStandardConversionExists): If the type of an
12031 expression is the anonymous_method_type, and the type is a
12032 delegate, we invoke the AnonymousMethod.Compatible method to check
12033 whether an implicit conversion is possible.
12035 (Convert.ImplicitConversionStandard): Only do implicit method
12036 group conversions if the language level is not ISO_1.
12038 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
12039 MethodInfo for the Invoke method. used by Delegate and
12042 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
12043 method conversions if the target type is a delegate.
12045 Removed extra debugging nops.
12047 (LocalVariableReference): Turn the `local_info' into a public
12050 Add `prepared' field, the same hack used for FieldExprs to cope
12051 with composed assignments, as Local variables do not necessarily
12052 operate purely on the stack as they used to: they can be captured
12055 Add `temp' for a temporary result, like fields.
12057 Refactor DoResolve and DoResolveLValue into DoResolveBase.
12059 It now copes with Local variables that are captured and emits the
12060 proper instance variable to load it from a field in the captured
12063 (ParameterReference.DoResolveBase): During the resolve phase,
12064 capture parameters if we are in an anonymous method.
12066 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
12067 anonymous method, use the EmitContext helper routines to emit the
12068 parameter reference.
12070 * iterators.cs: Set RemapToProxy to true/false during the
12073 * parameters.cs (GetParameterByName): New helper method.
12075 * typemanager.cs (anonymous_method_type) a new type that
12076 represents an anonyous method. This is always an internal type,
12077 used as a fencepost to test against the anonymous-methodness of an
12080 2004-10-20 Marek Safar <marek.safar@seznam.cz>
12082 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
12084 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
12086 2004-10-18 Martin Baulig <martin@ximian.com>
12088 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
12089 `Type' directly, but call ResolveType() on it.
12090 (Catch.Resolve): Likewise.
12091 (Foreach.Resolve): Likewise.
12093 2004-10-18 Martin Baulig <martin@ximian.com>
12095 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
12096 `Type' directly, but call ResolveType() on it.
12097 (Probe.DoResolve): Likewise.
12098 (ArrayCreation.LookupType): Likewise.
12099 (TypeOf.DoResolve): Likewise.
12100 (SizeOf.DoResolve): Likewise.
12102 2004-10-18 Martin Baulig <martin@ximian.com>
12104 * expression.cs (Invocation.BetterFunction): Put back
12105 TypeManager.TypeToCoreType().
12107 2004-10-18 Raja R Harinath <rharinath@novell.com>
12109 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
12112 2004-10-18 Martin Baulig <martin@ximian.com>
12114 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
12115 `Type' directly, but call ResolveType() on it.
12117 2004-10-18 Martin Baulig <martin@ximian.com>
12119 * class.cs (FieldMember.Define): Don't access the TypeExpr's
12120 `Type' directly, but call ResolveType() on it.
12121 (MemberBase.DoDefine): Likewise.
12123 * expression.cs (New.DoResolve): Don't access the TypeExpr's
12124 `Type' directly, but call ResolveType() on it.
12125 (ComposedCast.DoResolveAsTypeStep): Likewise.
12127 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
12128 `Type' directly, but call ResolveType() on it.
12130 2004-10-17 John Luke <john.luke@gmail.com>
12132 * class.cs (Operator.GetSignatureForError): use CSharpName
12134 * parameter.cs (Parameter.GetSignatureForError): Returns
12135 correct name even if was not defined.
12137 2004-10-13 Raja R Harinath <rharinath@novell.com>
12140 * class.cs (TypeContainer.EmitContext): New property.
12141 (DefineNestedTypes): Create an emitcontext for each part.
12142 (MethodCore.DoDefineParameters): Use container's emitcontext.
12143 Pass type array to InternalParameters.
12144 (MemberBase.DoDefine): Use container's emitcontext.
12145 (FieldMember.Define): Likewise.
12146 (Event.Define): Likewise.
12147 (SetMethod.GetParameterInfo): Change argument to EmitContext.
12148 Pass type array to InternalParameters.
12149 (SetIndexerMethod.GetParameterInfo): Likewise.
12150 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
12151 * delegate.cs (Define): Pass emitcontext to
12152 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
12153 array to InternalParameters.
12154 * expression.cs (ParameterReference.DoResolveBase): Pass
12155 emitcontext to GetParameterInfo.
12156 (ComposedCast.DoResolveAsTypeStep): Remove check on
12157 ec.ResolvingTypeTree.
12158 * parameter.cs (Parameter.Resolve): Change argument to
12159 EmitContext. Use ResolveAsTypeTerminal.
12160 (Parameter.GetSignature): Change argument to EmitContext.
12161 (Parameters.ComputeSignature): Likewise.
12162 (Parameters.ComputeParameterTypes): Likewise.
12163 (Parameters.GetParameterInfo): Likewise.
12164 (Parameters.ComputeAndDefineParameterTypes): Likewise.
12165 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
12166 * support.cs (InternalParameters..ctor): Remove variant that takes
12168 * typemanager.cs (system_intptr_expr): New.
12169 (InitExpressionTypes): Initialize it.
12171 2004-10-12 Chris Toshok <toshok@ximian.com>
12173 * cs-parser.jay: fix location for try_statement and catch_clause.
12175 2004-10-11 Martin Baulig <martin@ximian.com>
12177 * report.cs: Don't make --fatal abort on warnings, we have
12178 -warnaserror for that.
12180 2004-10-07 Raja R Harinath <rharinath@novell.com>
12182 More DeclSpace.ResolveType avoidance.
12183 * decl.cs (MemberCore.InUnsafe): New property.
12184 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
12185 with newly created EmitContext.
12186 (FieldMember.Define): Likewise.
12187 * delegate.cs (Delegate.Define): Likewise.
12188 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
12189 only if normal name-lookup fails.
12190 (TypeExpr.DoResolve): Enable error-checking.
12191 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
12192 (SizeOf.DoResolve): Likewise.
12193 (ComposedCast.DoResolveAsTypeStep): Likewise.
12194 (StackAlloc.DoResolve): Likewise.
12195 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
12196 (Block.Unsafe): New property.
12197 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
12198 (Unsafe): Set 'unsafe' flag of contained block.
12199 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
12200 (Fixed.Resolve): Likewise.
12201 (Catch.Resolve): Likewise.
12202 (Using.ResolveLocalVariableDecls): Likewise.
12203 (Foreach.Resolve): Likewise.
12205 2004-10-05 John Luke <john.luke@gmail.com>
12207 * cs-parser.jay: add location to error CS0175
12209 2004-10-04 Miguel de Icaza <miguel@ximian.com>
12211 * ecore.cs (Expression.Constantity): Add support for turning null
12214 * const.cs (Const.Define): Allow constants to be reference types
12215 as long as the value is Null.
12217 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
12219 * namespace.cs (NamespaceEntry.Using): No matter which warning
12220 level is set, check if this namespace name has already been added.
12222 2004-10-03 Ben Maurer <bmaurer@ximian.com>
12224 * expression.cs: reftype [!=]= null should always use br[true,false].
12227 2004-10-03 Marek Safar <marek.safar@seznam.cz>
12230 * attribute.cs: Enum conversion moved to
12231 GetAttributeArgumentExpression to be applied to the all
12234 2004-10-01 Raja R Harinath <rharinath@novell.com>
12236 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
12237 * class.c (TypeContainer.DefineType): Flag error if
12238 base types aren't accessible due to access permissions.
12239 * decl.cs (DeclSpace.ResolveType): Move logic to
12240 Expression.ResolveAsTypeTerminal.
12241 (DeclSpace.ResolveTypeExpr): Thin layer over
12242 Expression.ResolveAsTypeTerminal.
12243 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
12244 Refactor code into NestedAccess. Use it.
12245 (DeclSpace.NestedAccess): New.
12246 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
12247 argument to silence errors. Check access permissions.
12248 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
12249 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
12250 (Cast.DoResolve): Likewise.
12251 (New.DoResolve): Likewise.
12252 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
12253 (TypeOf.DoResolve): Likewise.
12255 * expression.cs (Invocation.BetterConversion): Return the Type of
12256 the better conversion. Implement section 14.4.2.3 more faithfully.
12257 (Invocation.BetterFunction): Make boolean. Make correspondence to
12258 section 14.4.2.2 explicit.
12259 (Invocation.OverloadResolve): Update.
12260 (Invocation): Remove is_base field.
12261 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
12262 (Invocation.Emit): Likewise.
12264 2004-09-27 Raja R Harinath <rharinath@novell.com>
12266 * README: Update to changes.
12268 2004-09-24 Marek Safar <marek.safar@seznam.cz>
12270 * cs-parser.jay: Reverted 642 warning fix.
12272 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12275 * decl.cs (FindMemberWithSameName): Indexer can have more than
12278 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12280 * expression.cs (LocalVariableReference.DoResolveLValue):
12281 Do not report warning 219 for out values.
12282 (EmptyExpression.Null): New member to avoid extra allocations.
12284 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12286 * cs-parser.jay: Fix wrong warning 642 report.
12288 * cs-tokenizer.cs (CheckNextToken): New helper;
12289 Inspect next character if is same as expected.
12291 2004-09-23 Martin Baulig <martin@ximian.com>
12293 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
12294 (Convert.ImplicitReferenceConversionExists): Likewise.
12296 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12298 * class.cs (Operator.Define): Add error 448 and 559 report.
12300 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12302 * class.cs (MemberBase.IsTypePermitted): New protected
12303 method for checking error CS0610.
12305 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12307 * class.cs (TypeContainer.HasExplicitLayout): New property
12308 Returns whether container has StructLayout attribute set Explicit.
12309 (FieldMember): New abstract class for consts and fields.
12310 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
12311 (Field): Reuse FieldMember.
12313 * const.cs (Const): Reuse FieldMember.
12315 * rootcontext.cs: EmitConstants call moved to class.
12317 2004-09-22 Martin Baulig <martin@ximian.com>
12319 Thanks to Peter Sestoft for this bug report.
12321 * expression.cs (Conditional): If both the `trueExpr' and the
12322 `falseExpr' is a NullLiteral, return a NullLiteral.
12324 2004-09-22 Martin Baulig <martin@ximian.com>
12326 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
12327 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
12328 for the "get_Current" call.
12330 2004-09-22 Martin Baulig <martin@ximian.com>
12332 Marek and me just fixed one of our oldest bugs: #28562 :-)
12334 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
12336 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
12337 we're an EnumConstant, just return that.
12338 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
12339 an EnumConstant. In this case, we need to use GetValueAsEnumType()
12340 to get the value which'll actually be written into the attribute.
12341 However, we have to use GetValue() to access the attribute's value
12344 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12346 * constant.cs (Constant.IsNegative): New abstract property
12349 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
12350 (StackAlloc.DoResolve): Reused IsNegative.
12352 2004-09-21 Martin Baulig <martin@ximian.com>
12354 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
12355 if we're used in an iterator, we may be called from different
12358 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
12359 we actually have an exception block.
12361 2004-09-20 John Luke <jluke@cfl.rr.com>
12363 * class.cs, cs-parser.jay: Improve the error report for 1520:
12364 report the actual line where the error happens, not where the
12365 class was declared.
12367 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
12368 Pass location information that was available elsewhere.
12370 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
12372 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
12373 runtime to delay sign assemblies.
12375 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12377 * cs-parser.jay: Do not report the stack trace, this is barely
12380 2004-08-22 John Luke <john.luke@gmail.com>
12382 * driver.cs : check that a resource id is not already used
12383 before adding it, report CS1508 if it is, bug #63637
12385 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12387 * ecore.cs: Removed dead code.
12389 2004-09-18 Marek Safar <marek.safar@seznam.cz>
12391 * class.cs: Do not report warning CS0067 on the interfaces.
12393 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12395 * cs-parser.jay: Add error 504 report.
12397 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12399 * rootcontext.cs: WarningLevel is 4 by default now.
12401 * statement.cs (Fixed.Resolve): Do not null
12404 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12407 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
12408 deep search when property is not virtual.
12409 (PropertyExpr.ResolveAccessors): Make one call for both
12412 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12415 * statement.cs: Error 152 report constains also location.
12417 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12420 * const.cs: Explicitly set constant as static.
12422 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12425 * cs-parser.jay: Add error 1017 report.
12427 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12429 Fixed bug #59980, #64224
12430 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
12432 * typemanager.cs (IsSpecialMethod): Simplified
12434 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12436 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
12437 condition with better params.
12439 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12442 * attribute.cs (Resolve): Property has to have both
12445 2004-09-14 Martin Baulig <martin@ximian.com>
12447 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
12449 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12452 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
12453 called and is obsolete then this member suppress message
12454 when call is inside next [Obsolete] method or type.
12456 * expression.cs: Use TestObsoleteMethodUsage member.
12458 2004-09-14 Martin Baulig <martin@ximian.com>
12460 * cs-parser.jay: Sync a bit with the GMCS version.
12462 2004-09-14 Martin Baulig <martin@ximian.com>
12464 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
12465 (CSharpParser.yacc_verbose_flag): New public field.
12467 * genericparser.cs: Removed.
12469 2004-09-14 Raja R Harinath <rharinath@novell.com>
12471 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
12473 2004-09-13 Marek Safar <marek.safar@seznam.cz>
12475 * class.cs (MethodCore.CheckBase): Fix bug #65757.
12477 2004-09-10 Martin Baulig <martin@ximian.com>
12479 Backported my MemberName changes from GMCS into MCS.
12481 - we are now using a special `MemberName' class instead of using
12482 strings; in GMCS, the `MemberName' also contains the type
12485 - changed the grammar rules a bit:
12486 * the old `member_name' is now a `namespace_or_type_name':
12487 The rule is that we use `namespace_or_type_name' everywhere
12488 where we expect either a "member name" (GetEnumerator) or a
12489 "member name" with an explicit interface name
12490 (IEnumerable.GetEnumerator).
12491 In GMCS, the explicit interface name may include type arguments
12492 (IEnumerable<T>.GetEnumerator).
12493 * we use `member_name' instead of just `IDENTIFIER' for
12495 The rule is that we use `member_name' wherever a member may
12496 have type parameters in GMCS.
12498 * decl.cs (MemberName): New public class.
12499 (MemberCore.MemberName): New public readonly field.
12500 (MemberCore.ctor): Take a `MemberName' argument, not a string.
12501 (DeclSpace): Likewise.
12503 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
12504 * enum.cs (Enum.ctor): Likewise.
12506 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
12508 (AliasEntry.ctor): Take a MemberName, not an Expression.
12509 (AliasEntry.UsingAlias): Likewise.
12511 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
12512 (IMethodData.MemberName): Changed type from string to MemberName.
12513 (MemberBase.ExplicitInterfaceName): Likewise.
12514 (AbstractPropertyEventMethod.SetupName): Make this private.
12515 (AbstractPropertyEventMethod.ctor): Added `string prefix'
12516 argument; compute the member name here.
12517 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
12518 on the `member.MemberName' and the `prefix'.
12520 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
12522 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
12523 thus, we get a `MemberName' instead of a `string'. These
12524 declarations may have type parameters in GMCS.
12525 (interface_method_declaration, delegate_declaration): Likewise.
12526 (class_declaration, interface_declaration): Likewise.
12527 (method_header): Use `namespace_or_type_name' instead of
12528 `member_name'. We may be an explicit interface implementation.
12529 (property_declaration, event_declaration): Likewise.
12530 (member_name): This is now just an `IDENTIFIER', not a
12531 `namespace_or_type_name'.
12532 (type_name, interface_type): Removed.
12533 (namespace_or_type_name): Return a MemberName, not an Expression.
12534 (primary_expression): Use `member_name' instead of `IDENTIFIER';
12535 call GetTypeExpression() on the MemberName to get an expression.
12536 (IndexerDeclaration.interface_type): Changed type from string to
12538 (MakeName): Operate on MemberName's instead of string's.
12540 2004-09-13 Raja R Harinath <rharinath@novell.com>
12543 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
12544 (NamespaceEntry.Lookup): Add new argument to flag if we want the
12545 lookup to avoid symbols introduced by 'using'.
12546 * rootcontext.cs (NamespaceLookup): Update.
12548 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12550 * class.cs (TypeContainer.DoDefineMembers): Do not call
12551 DefineDefaultConstructor for static classes.
12553 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12555 * attribute.cs (Attribute.Resolve): Add error 653 report.
12557 * class.cs (Class.ApplyAttributeBuilder): Add error 641
12559 (Method.ApplyAttributeBuilder): Add error 685 report.
12560 (Operator.Define): Add error 564 report.
12562 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
12564 * expression.cs (Invocation.DoResolve): Add error
12565 245 and 250 report.
12567 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
12570 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12572 * class.cs (ConstructorInitializer.Resolve):
12573 Wrong error number (515->516).
12575 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12577 * class.cs (Indexer.Define): Add error 631 report.
12579 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12581 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
12583 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12585 * expression.cs (Probe.DoResolve): Add error CS0241 report.
12587 2004-09-10 Marek Safar <marek.safar@seznam.cz>
12589 * cs-parser.jay: Added error CS0241 report.
12591 2004-09-10 Raja R Harinath <rharinath@novell.com>
12593 * cs-parser.jay (fixed_statement): Introduce a scope for the
12594 declaration in the 'fixed' statement.
12596 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12598 * cs-parser.jay: Added CS0230 error report.
12600 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12602 * cs-parser.jay: Added errors CS0231 and CS0257 report.
12604 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12606 * expression.cs (Argument.Resolve): Added error CS0192 and
12609 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12611 C# 2.0 #pragma warning feature
12613 * cs-tokenizer.cs (PreProcessPragma): New method;
12614 Handles #pragma directive.
12616 * report.cs (WarningRegions): New class; Support
12617 class for #pragma warning directive. It tests whether
12618 warning is enabled for a given line.
12620 2004-09-08 Miguel de Icaza <miguel@ximian.com>
12622 * const.cs: Add more descriptive error report, tahnks to
12625 2004-09-08 Marek Safar <marek.safar@seznam.cz>
12627 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
12629 2004-09-07 Miguel de Icaza <miguel@ximian.com>
12631 * expression.cs: Apply patch from Ben: Remove dead code from
12632 ArrayCreation, and remove the TurnintoConstant call in const.cs,
12633 as that code just threw an exception anwyays.
12635 * const.cs: Remove the call to the turnintoconstant, for details
12638 * literal.cs: The type of the null-literal is the null type; So
12639 we use a placeholder type (literal.cs:System.Null, defined here)
12642 * expression.cs (Conditional.DoResolve): Remove some old code that
12643 is no longer needed, conversions have been fixed.
12645 (ArrayCreationExpression.DoResolve): Return false if we fail to
12646 resolve the inner expression.
12648 2004-09-07 Raja R Harinath <rharinath@novell.com>
12651 * cs-parser.jay (delegate_declaration): Record a delegate
12652 declaration as a type declaration.
12653 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
12655 2004-09-06 Miguel de Icaza <miguel@ximian.com>
12657 * parameter.cs: Do not crash if the type can not be resolved.
12659 * expression.cs: Report errors with unsafe pointers, fixes #64896
12661 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
12663 * expression.cs: Pointer arith always needs to do a conv.i
12664 if the operand is a long. fix 65320
12666 2004-09-04 Marek Safar <marek.safar@seznam.cz>
12668 Fixed cs0619-37.cs, cs0619-38.cs
12670 * enum.cs (GetObsoleteAttribute): Removed.
12672 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
12673 on Enum member is double staged. The first is tested member
12676 2004-09-04 Marek Safar <marek.safar@seznam.cz>
12678 Fixed #56986, #63631, #65231
12680 * class.cs: (TypeContainer.AddToMemberContainer): New method,
12681 adds member to name container.
12682 (TypeContainer.AddToTypeContainer): New method, adds type to
12684 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
12685 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
12686 AddOperator): Simplified by reusing AddToMemberContainer.
12687 (TypeContainer.UserDefinedStaticConstructor): Changed to property
12689 (Method.CheckForDuplications): Fixed implementation to test all
12691 (MemberBase): Detection whether member is explicit interface
12692 implementation is now in constructor.
12693 (MemberBase.UpdateMemberName): Handles IndexerName.
12694 (Accessor): Changed to keep also location information.
12695 (AbstractPropertyEventMethod): Is derived from MemberCore.
12696 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
12697 will be emited or not.
12698 (PropertyBase.AreAccessorsDuplicateImplementation):
12699 Tests whether accessors are not in collision with some method.
12700 (Operator): Is derived from MethodCore to simplify common
12703 * decl.cs (Flags.TestMethodDuplication): Test for duplication
12705 (DeclSpace.AddToContainer): Adds the member to defined_names
12706 table. It tests for duplications and enclosing name conflicts.
12708 * enum.cs (EnumMember): Clean up to reuse the base structures
12710 2004-09-03 Martin Baulig <martin@ximian.com>
12712 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
12713 into TypeContainer, to make partial classes work again.
12715 2004-09-03 Martin Baulig <martin@ximian.com>
12717 * rootcontext.cs (RootContext.V2): Removed.
12719 2004-03-23 Martin Baulig <martin@ximian.com>
12721 * expression.cs (Invocation.OverloadResolve): Added `bool
12722 may_fail' argument and use it instead of the Location.IsNull() hack.
12724 2004-09-03 Martin Baulig <martin@ximian.com>
12726 Merged latest changes into gmcs. Please keep this comment in
12727 here, it makes it easier for me to see what changed in MCS since
12728 the last time I merged.
12730 2004-09-03 Raja R Harinath <rharinath@novell.com>
12733 * expression.cs (BetterConversion): Don't allow either conversion
12734 to be null. Remove redundant implicit conversion test when 'q ==
12735 null' -- when this function is invoked, we already know that the
12736 implicit conversion exists.
12737 (BetterFunction): Assume that 'best' is non-null. Remove
12738 redundant reimplementation of IsApplicable when 'best' is null.
12739 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
12740 number of arguments.
12741 (IsAncestralType): Extract from OverloadResolve.
12742 (OverloadResolve): Make robust to the MethodGroupExpr being
12743 unsorted. Implement all the logic of Section 14.5.5.1, and
12744 support overloading of methods from multiple applicable types.
12745 Clean up logic somewhat. Don't pass null methods to BetterFunction.
12747 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
12748 (RealError, Warning): Append type of report to related symbol.
12750 2004-09-03 Marek Safar <marek.safar@seznam.cz>
12752 * enum.cs: Fixed CLS-Compliance checks for enum members.
12753 Error tests cs3008-8.cs, cs3014-8.cs
12755 2004-09-02 Marek Safar <marek.safar@seznam.cz>
12757 Fixed bug #62342, #63102
12758 * class.cs: ImplementIndexer uses member.IsExplicitImpl
12759 like ImplementMethod.
12761 2004-09-02 Marek Safar <marek.safar@seznam.cz>
12763 * attribute.cs (Attribute.GetAttributeArgumentExpression):
12766 2004-09-02 Martin Baulig <martin@ximian.com>
12768 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
12769 TypeManager.GetArgumentTypes() rather than calling GetParameters()
12772 2004-09-01 Marek Safar <marek.safar@seznam.cz>
12774 C# 2.0 Static classes implemented
12776 * class.cs (TypeContainer): instance_constructors,
12777 initialized_fields, initialized_static_fields,
12778 default_constructor, base_inteface_types are protected to be
12779 accessible from StaticClass.
12780 (TypeContainer.DefineDefaultConstructor): New virtual method
12781 for custom default constructor generating
12782 (StaticClass): New class to handle "Static classes" feature.
12784 * cs-parser.jay: Handle static keyword on class like instance
12787 * driver.cs: Added "/langversion" command line switch with two
12788 options (iso-1, default).
12790 2004-08-31 Marek Safar <marek.safar@seznam.cz>
12792 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
12794 2004-08-31 Miguel de Icaza <miguel@ximian.com>
12796 * delegate.cs: Style.
12798 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
12800 * delegate.cs: Add seperate instance expr field for miguel.
12802 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
12804 * PointerArithmetic (Resolve): make sure we are not doing
12805 pointer arith on void*. Also, make sure we are resolved
12806 by not setting eclass until resolve.
12808 All callers: Make sure that PointerArithmetic gets resolved.
12810 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
12812 * ArrayCreation (LookupType): If the type does not resolve
12813 to an array, give an error.
12815 2004-08-27 Marek Safar <marek.safar@seznam.cz>
12817 * statement.cs (Try.Resolve): Fixed bug #64222
12819 2004-08-27 Martin Baulig <martin@ximian.com>
12822 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
12825 2004-08-26 Marek Safar <marek.safar@seznam.cz>
12827 * ecore.cs (Constantify): Get underlying type via
12828 System.Enum.GetUnderlyingType to avoid StackOverflow on the
12829 Windows in special cases.
12831 2004-08-26 Marek Safar <marek.safar@seznam.cz>
12833 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
12834 for obtaining also private methods.
12835 (GetRemoveMethod): Used GetRemoveMethod (true)
12836 for obtaining also private methods.
12838 2004-08-24 Martin Baulig <martin@ximian.com>
12840 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
12841 MethodAttributes.HideBySig for operators.
12843 2004-08-23 Martin Baulig <martin@ximian.com>
12845 Back to the old error reporting system :-)
12847 * report.cs (Message): Removed.
12848 (Report.MessageData, ErrorData, WarningData): Removed.
12849 (Report.Error, Warning): Back to the old system.
12851 2004-08-23 Martin Baulig <martin@ximian.com>
12853 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
12855 * class.cs (TypeContainer.ParentContainer): New public virtual
12856 method; replaces the explicit interface implementation.
12857 (ClassPart.ParentContainer): Override.
12859 2004-08-23 Martin Baulig <martin@ximian.com>
12861 * statement.cs (Switch): Added support for constant switches; see
12862 #59428 or test-285.cs.
12864 2004-08-22 Marek Safar <marek.safar@seznam.cz>
12867 * statement.cs (GetEnumeratorFilter): Removed useless
12868 logic because C# specs is strict. GetEnumerator must be
12871 2004-08-22 Martin Baulig <martin@ximian.com>
12873 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
12874 a switch and may break, reset the barrier. Fixes #59867.
12876 2004-08-22 Marek Safar <marek.safar@seznam.cz>
12878 CLS-Compliance speed up (~5% for corlib)
12880 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
12881 New method. Tests container for CLS-Compliant names
12883 * class.cs (TypeContainer.VerifyClsName): New method.
12884 Checks whether container name is CLS Compliant.
12885 (Constructor): Implements IMethodData.
12887 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
12888 low-case table for CLS Compliance test.
12889 (MemberCache.VerifyClsParameterConflict): New method.
12890 Checks method parameters for CS3006 error.
12892 * enum.cs (EnumMember): Is derived from MemberCore.
12893 (Enum.VerifyClsName): Optimized for better performance.
12895 2004-08-06 Marek Safar <marek.safar@seznam.cz>
12897 * report.cs: Renamed Error_T to Error and changed all
12900 2004-08-06 Marek Safar <marek.safar@seznam.cz>
12902 * class.cs (TypeContainer.IndexerArrayList): New inner class
12903 container for indexers.
12904 (TypeContainer.DefaultIndexerName): New constant for default
12905 indexer name. Replaced all "Item" with this constant.
12906 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
12908 * typemanager.cs (TypeManager.default_member_ctor): Cache here
12909 DefaultMemberAttribute constructor.
12911 2004-08-05 Martin Baulig <martin@ximian.com>
12913 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
12916 2004-08-05 Marek Safar <marek.safar@seznam.cz>
12918 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
12919 multi platforms problem.
12921 * compiler.csproj: Included shared files.
12923 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12925 Fix bug 60333, 55971 in the more general way
12926 * attribute.cs (Attribute.GetAttributeArgumentExpression):
12927 Added arg_type argument for constant conversion.
12928 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
12930 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12933 * class.cs (TypeContainer ): New inner classes MethodArrayList,
12934 OperatorArrayList, MethodCoreArrayList for typecontainer
12935 containers. Changed class member types to these new types.
12936 (MethodArrayList.DefineMembers): Added test for CS0659.
12938 2004-08-04 Miguel de Icaza <miguel@ximian.com>
12940 * cfold.cs: Synchronize the folding with the code in expression.cs
12941 Binary.DoNumericPromotions for uint operands.
12943 * attribute.cs: Revert patch from Raja, it introduced a regression
12944 while building Blam-1.2.1 (hard to isolate a test case).
12946 2004-08-04 Marek Safar <marek.safar@seznam.cz>
12950 (TypeContainer.Define): Renamed to DefineContainerMembers because of
12952 (MethodCore.parent_method): New member. The method we're overriding
12953 if this is an override method.
12954 (MethodCore.CheckBase): Moved from Method class and made common.
12955 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
12957 (MethodCore.CheckForDuplications): New abstract method. For custom
12958 member duplication search in a container
12959 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
12960 method and its return type.
12961 (Event.conflict_symbol): New member. Symbol with same name in the
12965 (MemberCache.FindMemberWithSameName): New method. The method
12966 is looking for conflict with inherited symbols.
12968 2004-08-04 Martin Baulig <martin@ximian.com>
12970 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
12972 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
12974 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12976 * report.cs (Message): New enum for better error, warning reference in
12978 (MessageData): New inner abstract class. It generally handles printing of
12979 error and warning messages.
12980 Removed unused Error, Warning, Message methods.
12982 2004-08-03 Marek Safar <marek.safar@seznam.cz>
12984 Fix for cs0592-8.cs test
12986 (Attributable.ValidAttributeTargets): Made public.
12987 (Attribute.ExplicitTarget): New member for explicit target value.
12988 (Attribute.CheckTargets): Now we translate explicit attribute
12989 target to Target here.
12991 2004-08-03 Ben Maurer <bmaurer@ximian.com>
12993 * ecore.cs (MethodGroupExpr): new IsBase property.
12995 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
12997 * delegate.cs (DelegateCreation): store a MethodGroupExpr
12998 rather than an instance expr.
13000 (DelegateCreation.Emit): Use the method group rather than
13001 the instance expression. Also, if you have base.Foo as the
13002 method for a delegate, make sure to emit ldftn, not ldftnvirt.
13004 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
13006 (NewDelegate.DoResolve): Only check for the existance of Invoke
13007 if the method is going to be needed. Use MethodGroupExpr.
13009 (NewDelegate.Emit): Remove, DelegateCreation implements this.
13011 * expression.cs: For pointer arith., make sure to use
13012 the size of the type, not the size of the pointer to
13015 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13018 * class.cs (Class): Added error CS0502 test.
13020 2004-08-03 John Luke <jluke@cfl.rr.com>
13021 Raja R Harinath <rharinath@novell.com>
13024 * attribute.cs (Attribute.complained_before): New flag.
13025 (Attribute.ResolveType, Attribute.Resolve),
13026 (Attribute.DefinePInvokeMethod): Set it.
13027 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
13029 2004-08-03 Martin Baulig <martin@ximian.com>
13031 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
13032 use a user-defined operator; we still need to do numeric
13033 promotions in case one argument is a builtin type and the other
13034 one has an implicit conversion to that type. Fixes #62322.
13036 2004-08-02 Martin Baulig <martin@ximian.com>
13038 * statement.cs (LocalInfo.Flags): Added `IsThis'.
13039 (LocalInfo.IsThis): New public property.
13040 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
13042 2004-08-01 Martin Baulig <martin@ximian.com>
13044 * class.cs (TypeContainer.GetClassBases): Don't set the default
13045 here since we may get called from GetPartialBases().
13046 (TypeContainer.DefineType): If GetClassBases() didn't return a
13047 parent, use the default one.
13049 2004-07-30 Duncan Mak <duncan@ximian.com>
13051 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
13053 2004-07-30 Martin Baulig <martin@ximian.com>
13055 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
13057 * class.cs (SourceMethod): New public class, derive from the
13058 symbol writer's ISourceMethod.
13059 (Method): Use the new symbol writer API.
13061 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
13062 as argument and use the new symbol writer.
13065 (SourceFile): Implement the symbol writer's ISourceFile.
13066 (Location.SymbolDocument): Removed.
13067 (Location.SourceFile): New public property.
13069 * symbolwriter.cs: Use the new symbol writer API.
13071 2004-07-30 Raja R Harinath <rharinath@novell.com>
13073 * Makefile (install-local): Remove. Functionality moved to
13076 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
13078 * Makefile: Install mcs.exe.config file together with mcs.exe.
13079 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
13080 correct runtime version.
13082 2004-07-25 Martin Baulig <martin@ximian.com>
13085 (TypeContainer.RegisterOrder): Removed, this was unused.
13086 (TypeContainer, interface_order): Removed.
13087 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
13088 TypeContainer as argument since we can also be called with a
13089 `PartialContainer' for a partial class/struct/interface.
13090 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
13091 of checking whether we're an `Interface' - we could be a
13092 `PartialContainer'.
13093 (PartialContainer.Register): Override; call
13094 AddClass()/AddStruct()/AddInterface() on our parent.
13096 * cs-parser.jay (interface_member_declaration): Add things to the
13097 `current_container', not the `current_class'.
13099 * rootcontext.cs (RegisterOrder): The overloaded version which
13100 takes an `Interface' was unused, removed.
13102 * typemanager.cs (TypeManager.LookupInterface): Return a
13103 `TypeContainer', not an `Interface'.
13104 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
13105 contain a `PartialContainer' for an interface, so check it's
13106 `Kind' to figure out what it is.
13108 2004-07-25 Martin Baulig <martin@ximian.com>
13110 * class.cs (Class.DefaultTypeAttributes): New public constant.
13111 (Struct.DefaultTypeAttributes): Likewise.
13112 (Interface.DefaultTypeAttributes): Likewise.
13113 (PartialContainer.TypeAttr): Override this and add the
13114 DefaultTypeAttributes.
13116 2004-07-25 Martin Baulig <martin@ximian.com>
13118 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
13119 we can just use the `Parent' field instead.
13121 2004-07-25 Martin Baulig <martin@ximian.com>
13123 * class.cs (TypeContainer.Emit): Renamed to EmitType().
13125 2004-07-25 Martin Baulig <martin@ximian.com>
13127 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
13128 our parts before defining any methods.
13129 (TypeContainer.VerifyImplements): Make this virtual.
13130 (ClassPart.VerifyImplements): Override and call VerifyImplements()
13131 on our PartialContainer.
13133 2004-07-25 Martin Baulig <martin@ximian.com>
13135 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
13137 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
13138 argument, we can just use the `Parent' field instead.
13141 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
13142 (MemberBase.DoDefine): Likewise.
13144 2004-07-24 Martin Baulig <martin@ximian.com>
13146 * decl.cs (MemberCore.Parent): New public field.
13147 (DeclSpace.Parent): Moved to MemberCore.
13149 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
13150 (MemberBase.ctor): Added TypeContainer argument, pass it to our
13152 (FieldBase, Field, Operator): Likewise.
13153 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
13154 (EventField, Event): Likewise.
13156 2004-07-23 Martin Baulig <martin@ximian.com>
13158 * class.cs (PartialContainer): New public class.
13159 (ClassPart): New public class.
13160 (TypeContainer): Added support for partial classes.
13161 (TypeContainer.GetClassBases): Splitted some of the functionality
13162 out into GetNormalBases() and GetPartialBases().
13164 * cs-tokenizer.cs (Token.PARTIAL): New token.
13165 (Tokenizer.consume_identifier): Added some hacks to recognize
13166 `partial', but only if it's immediately followed by `class',
13167 `struct' or `interface'.
13169 * cs-parser.jay: Added support for partial clases.
13171 2004-07-23 Martin Baulig <martin@ximian.com>
13173 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
13174 a `DeclSpace' and also made it readonly.
13175 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
13176 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
13177 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
13179 * cs-parser.jay: Pass the `current_class', not the
13180 `current_container' (at the moment, this is still the same thing)
13181 to a new Method, Property, Event, Indexer or Constructor.
13183 2004-07-23 Martin Baulig <martin@ximian.com>
13185 * cs-parser.jay (CSharpParser): Added a new `current_class' field
13186 and removed the `current_interface' one.
13187 (struct_declaration, class_declaration, interface_declaration):
13188 Set `current_class' to the newly created class/struct/interface;
13189 set their `Bases' and call Register() before parsing their body.
13191 2004-07-23 Martin Baulig <martin@ximian.com>
13193 * class.cs (Kind): New public enum.
13194 (TypeContainer): Made this class abstract.
13195 (TypeContainer.Kind): New public readonly field.
13196 (TypeContainer.CheckDef): New public method; moved here from
13198 (TypeContainer.Register): New public abstract method.
13199 (TypeContainer.GetPendingImplementations): New public abstract
13201 (TypeContainer.GetClassBases): Removed the `is_class' and
13202 `is_iface' parameters.
13203 (TypeContainer.DefineNestedTypes): Formerly known as
13205 (ClassOrStruct): Made this class abstract.
13207 * tree.cs (RootTypes): New public type.
13209 2004-07-20 Martin Baulig <martin@ximian.com>
13211 * tree.cs (Tree.RecordNamespace): Removed.
13212 (Tree.Namespaces): Removed.
13214 * rootcontext.cs (RootContext.IsNamespace): Removed.
13216 * cs-parser.jay (namespace_declaration): Just create a new
13217 NamespaceEntry here.
13219 2004-07-20 Martin Baulig <martin@ximian.com>
13221 * statement.cs (ExceptionStatement): New abstract class. This is
13222 now used as a base class for everyone who's using `finally'.
13223 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
13224 our local variables before using them.
13226 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
13227 virtual method. This is used by Yield.Resolve() to "steal" an
13228 outer block's `finally' clauses.
13229 (FlowBranchingException): The .ctor now takes an ExceptionStatement
13232 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
13233 version which takes an ExceptionStatement. This version must be
13234 used to create exception branchings.
13237 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
13238 (Iterator.EmitMoveNext): Added exception support; protect the
13239 block with a `fault' clause, properly handle 'finally' clauses.
13240 (Iterator.EmitDispose): Run all the `finally' clauses here.
13242 2004-07-20 Martin Baulig <martin@ximian.com>
13244 * iterator.cs: This is the first of a set of changes in the
13245 iterator code. Match the spec more closely: if we're an
13246 IEnumerable, then GetEnumerator() must be called. The first time
13247 GetEnumerator() is called, it returns the current instance; all
13248 subsequent invocations (if any) must create a copy.
13250 2004-07-19 Miguel de Icaza <miguel@ximian.com>
13252 * expression.cs: Resolve the constant expression before returning
13255 2004-07-19 Martin Baulig <martin@ximian.com>
13257 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
13258 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
13259 the return type of the new EmitContext.
13261 2004-07-18 Martin Baulig <martin@ximian.com>
13263 * class.cs (Property.Define): Fix iterators.
13265 * iterators.cs (Iterator.Define): Moved the
13266 `container.AddInterator (this)' call here from the .ctor; only do
13267 it if we resolved successfully.
13269 2004-07-17 Miguel de Icaza <miguel@ximian.com>
13271 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
13272 `true' for preprocessing directives that we parse. The return
13273 value indicates whether we should return to regular tokenizing or
13274 not, not whether it was parsed successfully.
13276 In the past if we were in: #if false ... #line #endif, we would
13277 resume parsing after `#line'. See bug 61604.
13279 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
13280 building: IsEnumType should return true only for enums, not for
13281 enums or System.Enum itself. This fixes #61593.
13283 Likely what happened is that corlib was wrong: mcs depended on
13284 this bug in some places. The bug got fixed, we had to add the
13285 hack, which caused bug 61593.
13287 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
13288 that was a workaround for the older conditions.
13290 2004-07-16 Ben Maurer <bmaurer@ximian.com>
13292 * assign.cs: IAssignMethod has a new interface, as documented
13293 inline. All assignment code now uses this new api.
13295 * ecore.cs, expression.cs: All classes which implement
13296 IAssignMethod now use the new interface.
13298 * expression.cs (Invocation): add a hack to EmitCall so that
13299 IndexerAccess can be the target of a compound assignment without
13300 evaluating its arguments twice.
13302 * statement.cs: Handle changes in Invocation api.
13304 2004-07-16 Martin Baulig <martin@ximian.com>
13306 * iterators.cs: Rewrote this. We're now using one single Proxy
13307 class for both the IEnumerable and the IEnumerator interface and
13308 `Iterator' derives from Class so we can use the high-level API.
13310 * class.cs (TypeContainer.AddIterator): New method.
13311 (TypeContainer.DoDefineType): New protected virtual method, which
13312 is called from DefineType().
13313 (TypeContainer.DoDefineMembers): Call DefineType() and
13314 DefineMembers() on all our iterators.
13315 (TypeContainer.Emit): Call Emit() on all our iterators.
13316 (TypeContainer.CloseType): Call CloseType() on all our iterators.
13318 * codegen.cs (EmitContext.CurrentIterator): New public field.
13320 2004-07-15 Martin Baulig <martin@ximian.com>
13323 (TypeManager.not_supported_exception_type): New type.
13325 2004-07-14 Martin Baulig <martin@ximian.com>
13327 * iterators.cs: Use real error numbers.
13329 2004-07-14 Martin Baulig <martin@ximian.com>
13331 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
13332 requires this to be a System.Collection.IEnumerable and not a
13333 class implementing that interface.
13334 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
13336 2004-07-13 Marek Safar <marek.safar@seznam.cz>
13338 * class.cs: Fixed previous fix, it broke some error tests.
13340 2004-07-12 Martin Baulig <martin@ximian.com>
13342 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
13345 2004-07-09 Miguel de Icaza <miguel@ximian.com>
13347 * assign.cs (LocalTemporary): Add new argument: is_address,If
13348 `is_address' is true, then the value that we store is the address
13349 to the real value, and not the value itself.
13351 * ecore.cs (PropertyExpr): use the new local temporary
13352 stuff to allow us to handle X.Y += z (where X is a struct)
13354 2004-07-08 Martin Baulig <martin@ximian.com>
13356 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
13357 not always return, just like we're doing in Using.Resolve().
13359 2004-07-07 Miguel de Icaza <miguel@ximian.com>
13361 * cs-parser.jay (fixed_statement): flag this as Pinned.
13363 2004-07-06 Miguel de Icaza <miguel@ximian.com>
13365 * typemanager.cs (TypeManager): Removed MakePinned method, this
13366 mechanism is replaced with the .NET 2.x compatible mechanism of
13367 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
13369 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
13370 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
13371 `IsFixed' property which has a different meaning.
13373 2004-07-02 Raja R Harinath <rharinath@novell.com>
13375 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
13376 visible from inside a nested class, not just the names of the
13377 immediately enclosing class.
13378 Fix for bug #60730.
13380 2004-06-24 Raja R Harinath <rharinath@novell.com>
13382 * expression.cs (BetterConversion): Remove buggy special-case
13383 handling of "implicit constant expression conversions". At this
13384 point, we already know that the conversion is possible -- we're
13385 only checking to see which is better.
13387 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13389 * cs-parser.jay: Added error CS0210 test.
13391 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13393 * cs-parser.jay: Added error CS0134 test.
13395 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13398 * cs-parser.jay: Added error CS0145 test.
13400 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13402 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
13404 2004-06-23 Ben Maurer <bmaurer@ximian.com>
13406 * expression.cs (StackAlloc.Resolve): The argument may not
13407 be a constant; deal with this case.
13409 2004-06-23 Marek Safar <marek.safar@seznam.cz>
13411 * attribute.cs (IndexerName_GetIndexerName): Renamed to
13412 GetIndexerAttributeValue.
13413 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
13415 * class.cs (Indexer.Define): Added error tests for CS0415,
13418 2004-06-23 Miguel de Icaza <miguel@ximian.com>
13420 * attribute.cs (Attribute.Resolve): Keep field code in sync with
13423 2004-06-23 Martin Baulig <martin@ximian.com>
13425 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
13426 neither return nor throw, reset the barrier as well. Fixes #60457.
13428 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
13430 * class.cs : EventAttributes is now set to None by default.
13431 This fixes bug #60459.
13433 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13436 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
13437 Don't throw exception but return null (it's sufficient now).
13439 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13441 * typemanager.cs (GetArgumentTypes): Faster implementation.
13443 2004-06-18 Martin Baulig <martin@ximian.com>
13445 * attribute.cs (Attribute.Resolve): Check whether we're an
13446 EmptyCast which a Constant child. Fixes #60333.
13448 2004-06-17 Ben Maurer <bmaurer@ximian.com>
13450 * statement.cs (EmitCollectionForeach): Account for the fact that
13451 not all valuetypes are in areas which we can take the address of.
13452 For these variables, we store to a temporary variable. Also, make
13453 sure that we dont emit a `callvirt' on a valuetype method.
13455 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13457 * expression.cs (StackAlloc.DoReSolve): Added test for
13458 negative parameter (CS0247).
13460 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13463 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
13465 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13468 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
13471 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13473 Fix bug #58254 & cs1555.cs, cs1556.cs
13474 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
13476 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13478 * cs-parser.jay: Added error CS1669 test for indexers.
13480 2004-06-11 Martin Baulig <martin@ximian.com>
13482 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
13483 call this twice: for params and varargs methods.
13485 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13488 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
13490 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13492 * attribute.cs (Attribute.GetValidTargets): Made public.
13495 (AbstractPropertyEventMethod): New class for better code sharing.
13496 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
13498 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
13500 2004-06-11 Raja R Harinath <rharinath@novell.com>
13503 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
13504 that the call to Resolve is part of a MemberAccess.
13505 (Expression.Resolve): Use it for SimpleName resolution.
13506 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
13507 Add 'intermediate' boolean argument.
13508 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
13509 error message when the SimpleName can be resolved ambiguously
13510 between an expression and a type.
13511 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
13513 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
13514 call on the left-side.
13516 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13519 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
13521 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13523 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
13525 2004-06-11 Martin Baulig <martin@ximian.com>
13527 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
13528 varargs methods if applicable.
13530 2004-06-11 Martin Baulig <martin@ximian.com>
13532 * expression.cs (Invocation.EmitCall): Don't use
13533 `method.CallingConvention == CallingConventions.VarArgs' since the
13534 method could also have `CallingConventions.HasThis'.
13536 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13538 * class.cs (Event.GetSignatureForError): Implemented.
13539 Fixed crash in error test cs3010.cs
13541 2004-06-10 Miguel de Icaza <miguel@ximian.com>
13543 * cs-tokenizer.cs: Change the way we track __arglist to be
13544 consistent with the other keywords.
13546 2004-06-09 Miguel de Icaza <miguel@ximian.com>
13548 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
13551 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
13553 * codegen.cs: Check that all referenced assemblies have a strongname
13554 before strongnaming the compiled assembly. If not report error CS1577.
13555 Fix bug #56563. Patch by Jackson Harper.
13556 * typemanager.cs: Added a method to return all referenced assemblies.
13557 Fix bug #56563. Patch by Jackson Harper.
13559 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13562 (Method.ApplyAttributeBuilder): Moved and added conditional
13563 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
13566 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
13568 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13571 * class.cs: (EventField.attribute_targets): Changed default target.
13573 2004-06-08 Martin Baulig <martin@ximian.com>
13575 * expression.cs (Invocation.EmitCall): Enable varargs methods.
13577 2004-06-08 Martin Baulig <martin@ximian.com>
13579 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
13581 2004-06-07 Martin Baulig <martin@ximian.com>
13583 Added support for varargs methods.
13585 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
13588 * cs-parser.jay: Added support for `__arglist'.
13590 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
13592 * expression.cs (Argument.AType): Added `ArgList'.
13593 (Invocation): Added support for varargs methods.
13594 (ArglistAccess): New public class.
13595 (Arglist): New public class.
13597 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
13599 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
13600 a method's top-level block if the method has varargs.
13602 * support.cs (ReflectionParameters, InternalParameters): Added
13603 support for varargs methods.
13605 2004-06-07 Miguel de Icaza <miguel@ximian.com>
13607 * class.cs: Provide location in indexer error report.
13609 * driver.cs: Use standard names.
13611 * namespace.cs: Catch the use of using after a namespace has been
13612 declared also on using aliases.
13614 2004-06-03 Raja R Harinath <rharinath@novell.com>
13617 * typemanager.cs (closure_private_ok, closure_invocation_type)
13618 (closure_qualifier_type, closure_invocation_assembly)
13619 (FilterWithClosure): Move to ...
13620 (Closure): New internal nested class.
13621 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
13622 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
13623 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
13624 (MemberLookup, MemberLookupFailed): Use it.
13625 * expression.cs (New.DoResolve): Treat the lookup for the
13626 constructor as being qualified by the 'new'ed type.
13627 (Indexers.GetIndexersForTypeOrInterface): Update.
13629 2004-06-03 Marek Safar <marek.safar@seznam.cz>
13632 (GetConditionalAttributeValue): New method. Returns
13633 condition of ConditionalAttribute.
13634 (SearchMulti): New method. Returns all attributes of type 't'.
13635 Use it when attribute is AllowMultiple = true.
13636 (IsConditionalMethodExcluded): New method.
13639 (Method.IsExcluded): Implemented. Returns true if method has conditional
13640 attribute and the conditions is not defined (method is excluded).
13641 (IMethodData): Extended interface for ConditionalAttribute support.
13642 (PropertyMethod.IsExcluded): Implemented.
13645 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
13648 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
13651 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
13653 * expression.cs (ArrayCreationExpression): Make this just an
13654 `expression'. It can't be a statement, so the code here was
13657 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13660 * typemanager.cs (GetFullNameSignature): New method for
13663 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13666 * class.cs (MemberBase.GetSignatureForError): New virtual method.
13667 Use this method when MethodBuilder is null.
13668 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
13669 Added test for error CS0626 (MONO reports error for this situation).
13670 (IMethodData.GetSignatureForError): Extended interface.
13672 2004-06-01 Marek Safar <marek.safar@seznam.cz>
13675 (AttributeTester.GetObsoleteAttribute): Returns instance of
13676 ObsoleteAttribute when type is obsolete.
13679 (TypeContainer.VerifyObsoleteAttribute): Override.
13680 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
13681 (MethodCode.VerifyObsoleteAttribute): Override.
13682 (MemberBase.VerifyObsoleteAttribute): Override.
13685 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
13686 and report proper error.
13689 Delegate.VerifyObsoleteAttribute): Override.
13692 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
13693 and report proper error.
13694 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
13697 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
13701 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
13702 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
13703 Added test for ObsoleteAttribute.
13706 (Catch): Derived from Statement.
13708 2004-06-01 Marek Safar <marek.safar@seznam.cz>
13710 Fixed bug #59071 & cs0160.cs
13712 * statement.cs (Try.Resolve): Check here whether order of catch
13713 clauses matches their dependencies.
13715 2004-05-31 Miguel de Icaza <miguel@ximian.com>
13717 * Reverted patch to namespace.cs (Use lookuptypedirect). This
13718 caused a regression: #59343. Referencing nested classes from an
13719 assembly stopped working.
13721 2004-05-31 Martin Baulig <martin@ximian.com>
13723 MCS is now frozen for beta 2.
13725 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13727 * convert.cs: add a trivial cache for overload operator resolution.
13729 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13731 * decl.cs: If possible, use lookuptypedirect here. We can only do
13732 this if there is no `.' after the namespace. Avoids using
13733 LookupType, which does lots of slow processing.
13734 (FindNestedType) New method, does what it says :-).
13735 * namespace.cs: use LookupTypeDirect.
13736 * rootcontext.cs: use membercache, if possible.
13737 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
13739 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13742 According to the spec,
13744 In a member access of the form E.I, if E is a single identifier,
13745 and if the meaning of E as a simple-name (§7.5.2) is a constant,
13746 field, property, localvariable, or parameter with the same type as
13747 the meaning of E as a type-name (§3.8), then both possible
13748 meanings of E are permitted.
13750 We did not check that E as a simple-name had the same type as E as
13753 This trivial check gives us 5-7% on bootstrap time.
13755 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13757 * expression.cs (Invocation.OverloadResolve): Avoid the
13758 use of hashtables and boxing here by allocating on demand.
13760 2004-05-30 Martin Baulig <martin@ximian.com>
13762 * rootcontext.cs (RootContext.LookupType): Don't cache things if
13763 we're doing a silent lookup. Don't try to lookup nested types in
13764 TypeManager.object_type (thanks to Ben Maurer).
13766 2004-05-30 Martin Baulig <martin@ximian.com>
13768 Committing a patch from Ben Maurer.
13770 * rootcontext.cs (RootContext.LookupType): Cache negative results.
13772 2004-05-29 Martin Baulig <martin@ximian.com>
13774 * class.cs (IMethodData.ShouldIgnore): New method.
13776 * typemanager.cs (TypeManager.MethodFlags): Don't take a
13777 `Location' argument, we don't need it anywhere. Use
13778 `IMethodData.ShouldIgnore ()' instead of
13779 `MethodData.GetMethodFlags ()'.
13780 (TypeManager.AddMethod): Removed.
13781 (TypeManager.AddMethod2): Renamed to AddMethod.
13783 2004-05-29 Martin Baulig <martin@ximian.com>
13785 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
13787 * convert.cs (Convert.ImplicitReferenceConversion): If we're
13788 converting from a class type S to an interface type and we already
13789 have an object on the stack, don't box it again. Fixes #52578.
13791 2004-05-29 Martin Baulig <martin@ximian.com>
13793 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
13794 Added support for `params' parameters. Fixes #59267.
13796 2004-05-29 Martin Baulig <martin@ximian.com>
13798 * literal.cs (NullPointer): Provide a private .ctor which sets
13799 `type' to TypeManager.object_type. Fixes #59048.
13801 2004-05-29 Martin Baulig <martin@ximian.com>
13803 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
13804 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
13806 * ecore.cs (EventExpr.instance_expr): Make the field private.
13808 2004-05-26 Marek Safar <marek.safar@seznam.cz>
13810 Fixed bug #50080 & cs0214-2.cs
13811 * expression.cs (Cast.DoResolve): Check unsafe context here.
13813 * statement.cs (Resolve.DoResolve): Likewise.
13815 2004-05-26 Martin Baulig <martin@ximian.com>
13817 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
13819 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
13820 (RootContext.LookupType): Pass down the `silent' flag.
13822 2004-05-25 Martin Baulig <martin@ximian.com>
13825 (MethodGroupExpr.IdenticalTypeName): New public property.
13826 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
13827 expression actually refers to a type.
13829 2004-05-25 Martin Baulig <martin@ximian.com>
13831 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
13832 for #56176 and made it actually work.
13834 2004-05-25 Martin Baulig <martin@ximian.com>
13836 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
13837 (FieldExpr, PropertyExpr): Override and implement
13838 CacheTemporaries. Fixes #52279.
13840 2004-05-25 Miguel de Icaza <miguel@ximian.com>
13842 * location.cs: In the new compiler listing a file twice is a
13843 warning, not an error.
13845 2004-05-24 Martin Baulig <martin@ximian.com>
13847 * enum.cs (Enum.DefineType): For the `BaseType' to be a
13848 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
13850 2004-05-24 Martin Baulig <martin@ximian.com>
13852 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
13853 walking the `using' list. Fixes #53921.
13855 2004-05-24 Martin Baulig <martin@ximian.com>
13857 * const.cs (Const.LookupConstantValue): Added support for
13858 EmptyCast's; fixes #55251.
13860 2004-05-24 Martin Baulig <martin@ximian.com>
13862 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
13863 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
13864 which does the CS0135 check. The reason is that we first need to
13865 check whether the variable actually exists.
13867 2004-05-24 Martin Baulig <martin@ximian.com>
13869 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
13870 than RootContext.LookupType() to find the explicit interface
13871 type. Fixes #58584.
13873 2004-05-24 Raja R Harinath <rharinath@novell.com>
13875 * Makefile: Simplify. Use executable.make.
13876 * mcs.exe.sources: New file. List of sources of mcs.exe.
13878 2004-05-24 Anders Carlsson <andersca@gnome.org>
13882 Use the invariant culture when doing String.Compare for CLS case
13885 2004-05-23 Martin Baulig <martin@ximian.com>
13887 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
13888 don't have any dots. Fixes #52622, added cs0246-8.cs.
13890 * namespace.cs (NamespaceEntry.Lookup): Likewise.
13892 2004-05-23 Marek Safar <marek.safar@seznam.cz>
13894 * class.cs (MemberBase.Define): Reuse MemberType member for
13895 resolved type. Other methods can use it too.
13897 2004-05-23 Martin Baulig <martin@ximian.com>
13899 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
13900 the variable also exists in the current block (otherwise, we need
13901 to report a CS0103). Fixes #58670.
13903 2004-05-23 Martin Baulig <martin@ximian.com>
13905 * flowanalysis.cs (Reachability.Reachable): Compute this
13906 on-the-fly rather than storing it as a field.
13908 2004-05-23 Martin Baulig <martin@ximian.com>
13910 * flowanalysis.cs (Reachability.And): Manually compute the
13911 resulting `barrier' from the reachability.
13913 2004-05-23 Marek Safar <marek.safar@seznam.cz>
13916 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
13917 instance of ObsoleteAttribute when symbol is obsolete.
13920 (IMethodData): Extended interface for ObsoleteAttribute support.
13922 2004-05-22 Marek Safar <marek.safar@seznam.cz>
13924 * attribute.cs: Fix bug #55970
13926 2004-05-22 Marek Safar <marek.safar@seznam.cz>
13930 (GetObsoleteAttribute): New method. Creates the instance of
13932 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
13933 ObsoleteAttribute when member is obsolete.
13934 (AttributeTester.Report_ObsoleteMessage): Common method for
13935 Obsolete error/warning reporting.
13938 (TypeContainer.base_classs_type): New member for storing parent type.
13941 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
13942 for this MemberCore.
13944 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13946 * attribute.cs, const.cs: Fix bug #58590
13948 2004-05-21 Martin Baulig <martin@ximian.com>
13950 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
13951 out parameters if the end of the method is unreachable. Fixes
13954 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13956 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
13957 Hari was right, why extra method.
13959 2004-05-21 Marek Safar <marek.safar@seznam.cz>
13961 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
13963 2004-05-20 Martin Baulig <martin@ximian.com>
13965 Merged this back from gmcs to keep the differences to a minumum.
13967 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
13968 instead of a Declspace.
13969 (Attribute.ResolveType): Likewise.
13970 (Attributes.Search): Likewise.
13971 (Attributes.Contains): Likewise.
13972 (Attributes.GetClsCompliantAttribute): Likewise.
13974 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
13976 (MethodData.ApplyAttributes): Take an EmitContext instead of a
13979 2004-05-19 Marek Safar <marek.safar@seznam.cz>
13981 Fix bug #58688 (MCS does not report error when the same attribute
13984 * attribute.cs (Attribute.Emit): Distinction between null and default.
13986 2004-05-19 Raja R Harinath <rharinath@novell.com>
13988 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
13989 of a top-level attribute without an attribute target.
13990 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
13992 (Attribute.Conditional_GetConditionName),
13993 (Attribute.Obsolete_GetObsoleteMessage): Update.
13994 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
13995 part of ScanForIndexerName.
13996 (Attribute.CanIgnoreInvalidAttribute): New function.
13997 (Attribute.ScanForIndexerName): Move to ...
13998 (Attributes.ScanForIndexerName): ... here.
13999 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
14000 (Attributes.Search): New internal variant that can choose not to
14001 complain if types aren't resolved. The original signature now
14003 (Attributes.GetClsCompliantAttribute): Use internal variant, with
14004 complaints suppressed.
14005 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
14006 only if it not useful.
14007 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
14008 top-level for attributes that are shared between the assembly
14009 and a top-level class.
14010 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
14011 * class.cs: Update to reflect changes.
14012 (DefineIndexers): Fuse loops.
14013 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
14014 a couple more variants of attribute names.
14016 2004-05-18 Marek Safar <marek.safar@seznam.cz>
14018 Fix bug #52585 (Implemented explicit attribute declaration)
14021 (Attributable.ValidAttributeTargets): New abstract method. It gets
14022 list of valid attribute targets for explicit target declaration.
14023 (Attribute.Target): It holds target itself.
14024 (AttributeSection): Removed.
14025 (Attribute.CheckTargets): New method. It checks whether attribute
14026 target is valid for the current element.
14029 (EventProperty): New class. For events that are declared like
14030 property (with add and remove accessors).
14031 (EventField): New class. For events that are declared like field.
14034 * cs-parser.jay: Implemented explicit attribute target declaration.
14036 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
14037 Override ValidAttributeTargets.
14040 (ReturnParameter): Class for applying custom attributes on
14042 (ParameterAtribute): New class. Class for applying custom
14043 attributes on the parameter type.
14045 2004-05-17 Miguel de Icaza <miguel@ximian.com>
14047 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
14050 (Method): Allow UNSAFE here.
14052 * modifiers.cs: Support unsafe reporting.
14054 2004-05-17 Marek Safar <marek.safar@seznam.cz>
14056 * decl.cs: Fix bug #58478.
14058 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14060 * statement.cs: When checking for unreachable code on an EmptyStatement,
14061 set the location. Fixes bug #58488.
14063 2004-05-13 Miguel de Icaza <miguel@ximian.com>
14065 * driver.cs: Add -pkg handling.
14067 From Gonzalo: UseShelLExecute=false
14069 2004-05-12 Marek Safar <marek.safar@seznam.cz>
14072 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
14074 (Attribute.IsClsCompliaceRequired): Moved to base for better
14076 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
14077 when attribute is AttributeUsageAttribute.
14078 (Attribute.GetValidTargets): Simplified.
14079 (Attribute.GetAttributeUsage): New method returns AttributeUsage
14080 attribute for this type.
14081 (Attribute.ApplyAttributes): Method renamed to Emit and make
14083 (GlobalAttributeSection): New class for special handling of global
14084 attributes (assembly, module).
14085 (AttributeSection.Emit): New method.
14087 * class.cs: Implemented Attributable abstract methods.
14088 (MethodCore.LabelParameters): Moved to Parameter class.
14089 (Accessor): Is back simple class.
14090 (PropertyMethod): Implemented Attributable abstract class.
14091 (DelegateMethod): Implemented Attributable abstract class.
14092 (Event): New constructor for disctintion between normal Event
14093 and Event with accessors.
14095 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
14097 * codegen.cs, const.cs, decl.cs, delegate.cs:
14098 (CommonAssemblyModulClass): Implemented Attributable abstract class
14101 * enum.cs: Implement IAttributeSupport interface.
14102 (EnumMember): New class for emum members. Implemented Attributable
14106 (ParameterBase): Is abstract.
14107 (ReturnParameter): New class for easier [return:] attribute handling.
14109 * typemanager.cs: Removed builder_to_attr.
14111 2004-05-11 Raja R Harinath <rharinath@novell.com>
14114 * attribute.cs (Attribute.GetPositionalValue): New function.
14115 * class.cs (TypeContainer.VerifyMembers): New function.
14116 (TypeContainer.Emit): Use it.
14117 (ClassOrStruct): New base class for Class and Struct.
14118 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
14119 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
14121 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
14122 then each non-static field should have a FieldOffset attribute.
14123 Otherwise, none of the fields should have a FieldOffset attribute.
14124 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
14125 and FieldOffset attributes.
14126 * typemanager.cs (TypeManager.struct_layout_attribute_type)
14127 (TypeManager.field_offset_attribute_type): New core types.
14128 (TypeManager.InitCoreTypes): Initialize them.
14130 2004-05-11 Michal Moskal <malekith@pld-linux.org>
14132 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
14133 Return correct type.
14136 2004-05-09 Miguel de Icaza <miguel@ximian.com>
14138 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
14139 be implicitly converted to ulong.
14141 * expression.cs: The logic for allowing operator &, | and ^ worked
14142 was wrong, it worked before because we did not report an error in
14143 an else branch. Fixes 57895.
14145 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
14146 allow volatile fields to be reference types.
14148 2004-05-07 Miguel de Icaza <miguel@ximian.com>
14150 * driver.cs: Add support for /debug-
14152 2004-05-07 Raja R Harinath <rharinath@novell.com>
14154 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
14155 Add a 'complain' parameter to silence errors.
14156 (Attribute.Resolve): Update to changes. Put in sanity check to catch
14157 silently overlooked type-resolutions.
14158 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
14159 to reflect changes.
14160 (Attributes.Search): New function.
14161 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
14162 (Attributes.GetAttributeFullName): Remove hack.
14163 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
14164 Update to reflect changes.
14165 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14166 Use Attributes.Search instead of nested loops.
14168 2004-05-07 Marek Safar <marek.safar@seznam.cz>
14171 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
14172 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
14173 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
14175 * report.cs: (Report.Warning): Renamed to Warning_T because of
14176 parameter collision.
14178 2004-05-05 Raja R Harinath <rharinath@novell.com>
14180 * expression.cs (MemberAccess.ResolveMemberAccess):
14181 Exit with non-zero status after Report.Error.
14182 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
14184 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
14186 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14188 * support.cs: Don't hang when the file is empty.
14190 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14192 * support.cs: In SeekableStreamReader, compute the preamble size of the
14193 underlying stream. Position changes should take into account that initial
14196 2004-05-03 Todd Berman <tberman@sevenl.net>
14198 * driver.cs: remove unused GetSysVersion function.
14200 2004-05-03 Todd Berman <tberman@sevenl.net>
14202 * driver.cs: Remove the hack from saturday, as well as the hack
14203 from jackson (LoadAssemblyFromGac), also adds the CWD to the
14204 link_paths to get that bit proper.
14206 2004-05-01 Todd Berman <tberman@sevenl.net>
14208 * driver.cs: Try a LoadFrom before a Load, this checks the current
14209 path. This is currently a bug in mono that is be fixed, however, this
14210 provides a workaround for now. This will be removed when the bug
14213 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
14215 * CryptoConvert.cs: Updated to latest version. Fix issue with
14216 incomplete key pairs (#57941).
14218 2004-05-01 Todd Berman <tberman@sevenl.net>
14220 * driver.cs: Remove '.' from path_chars, now System.* loads properly
14223 2004-04-30 Jackson Harper <jackson@ximian.com>
14225 * codegen.cs: Open keys readonly.
14227 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14229 * typemanager.cs: don't report cyclic struct layout when a struct
14230 contains 2 or more fields of the same type. Failed for Pango.AttrShape
14231 which has 2 Pango.Rectangle fields.
14233 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
14235 * expression.cs: Handle IntPtr comparisons with IL code
14236 rather than a method call.
14238 2004-04-29 Martin Baulig <martin@ximian.com>
14240 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
14241 the list of PropertyInfo's in class hierarchy and find the
14242 accessor. Fixes #56013.
14244 2004-04-29 Martin Baulig <martin@ximian.com>
14246 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
14248 2004-04-29 Martin Baulig <martin@ximian.com>
14250 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14252 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
14254 2004-04-29 Martin Baulig <martin@ximian.com>
14256 * class.cs (ConstructorInitializer.Resolve): Check whether the
14257 parent .ctor is accessible. Fixes #52146.
14259 2004-04-29 Martin Baulig <martin@ximian.com>
14261 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14263 * statement.cs (Using.EmitLocalVariableDecls): Use
14264 TypeManager.idisposable_type, not typeof (IDisposable).
14265 (Foreach.EmitCollectionForeach): Added support for valuetypes.
14267 2004-04-29 Martin Baulig <martin@ximian.com>
14269 * class.cs (Event.Define): Don't emit the field and don't set
14270 RTSpecialName and SpecialName for events on interfaces. Fixes
14273 2004-04-29 Raja R Harinath <rharinath@novell.com>
14275 Refactor Attribute.ApplyAttributes.
14276 * attribute.cs (Attributable): New base class for objects that can
14277 have Attributes applied on them.
14278 (Attribute): Make AttributeUsage fields public.
14279 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
14280 (Attribute.IsInternalCall): New property.
14281 (Attribute.UsageAttr): Convert to a public read-only property.
14282 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
14283 (Attribute.ResolveType, Attribute.Resolve)
14284 (Attribute.ScanForIndexerName): Update to reflect changes.
14285 (Attribute.CheckAttributeTarget): Re-format.
14286 (Attribute.ApplyAttributes): Refactor, to various
14287 Attributable.ApplyAttributeBuilder methods.
14288 * decl.cs (MemberCore): Make Attributable.
14289 * class.cs (Accessor): Make Attributable.
14290 (MethodData.ApplyAttributes): Use proper attribute types, not
14292 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
14293 (TypeContainer.ApplyAttributeBuilder)
14294 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
14295 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
14296 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
14297 (Operator.ApplyAttributeBuilder): New factored-out methods.
14298 * const.cs (Const.ApplyAttributeBuilder): Likewise.
14299 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
14300 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
14301 * parameter.cs (ParameterBase): New Attributable base class
14302 that can also represent Return types.
14303 (Parameter): Update to the changes.
14305 2004-04-29 Jackson Harper <jackson@ximian.com>
14307 * driver.cs: Prefer the corlib system version when looking for
14308 assemblies in the GAC. This is still a hack, but its a better hack
14311 2004-04-29 Marek Safar <marek.safar@seznam.cz>
14313 * decl.cs, enum.cs: Improved error 3005 reporting.
14315 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
14316 (related_symbols): New private member for list of symbols
14317 related to reported error/warning.
14319 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
14321 2004-04-29 Martin Baulig <martin@ximian.com>
14323 * ecore.cs (Expression.Constantify): If we're an enum and
14324 TypeManager.TypeToCoreType() doesn't give us another type, use
14325 t.UnderlyingSystemType. Fixes #56178.
14327 2004-04-29 Martin Baulig <martin@ximian.com>
14329 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
14330 interfaces and for each interface, only add members directly
14331 declared in that interface. Fixes #53255.
14333 2004-04-28 Martin Baulig <martin@ximian.com>
14335 * expression.cs (ConditionalLogicalOperator): Use a temporary
14336 variable for `left' to avoid that we evaluate it more than once;
14339 2004-04-28 Martin Baulig <martin@ximian.com>
14341 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
14344 2004-04-28 Martin Baulig <martin@ximian.com>
14346 * statement.cs (LocalInfo.Resolve): Check whether the type is not
14349 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
14350 whether the type is not void (CS1547).
14352 2004-04-28 Martin Baulig <martin@ximian.com>
14354 * expression.cs (Unary.DoResolveLValue): Override this and report
14355 CS0131 for anything but Operator.Indirection.
14357 2004-04-28 Martin Baulig <martin@ximian.com>
14359 Committing a patch from Ben Maurer; see bug #50820.
14361 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14364 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14367 2004-04-28 Martin Baulig <martin@ximian.com>
14369 Committing a patch from Ben Maurer; see bug #50820.
14371 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14374 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14377 2004-04-28 Martin Baulig <martin@ximian.com>
14379 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
14380 (Block.AddLabel): Call DoLookupLabel() to only search in the
14383 2004-04-28 Martin Baulig <martin@ximian.com>
14385 * cfold.cs (ConstantFold.BinaryFold): Added special support for
14386 comparing StringConstants and NullLiterals in Equality and Inequality.
14388 2004-04-28 Jackson Harper <jackson@ximian.com>
14390 * driver.cs: Attempt to load referenced assemblies from the
14391 GAC. This is the quick and dirty version of this method that
14392 doesnt take into account versions and just takes the first
14393 canidate found. Will be good enough for now as we will not have more
14394 then one version installed into the GAC until I update this method.
14396 2004-04-28 Martin Baulig <martin@ximian.com>
14398 * typemanager.cs (TypeManager.CheckStructCycles): New public
14399 static method to check for cycles in the struct layout.
14401 * rootcontext.cs (RootContext.PopulateTypes): Call
14402 TypeManager.CheckStructCycles() for each TypeContainer.
14403 [Note: We only need to visit each type once.]
14405 2004-04-28 Martin Baulig <martin@ximian.com>
14407 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
14409 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
14410 success and added `out object value'. Use a `bool resolved' field
14411 to check whether we've already been called rather than
14412 `ConstantValue != null' since this breaks for NullLiterals.
14414 2004-04-28 Raja R Harinath <rharinath@novell.com>
14416 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
14417 setting of this flag, since the 'set' method may be non-public.
14419 2004-04-28 Raja R Harinath <rharinath@novell.com>
14421 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
14422 check on current_vector.Block.
14424 2004-04-27 Martin Baulig <martin@ximian.com>
14426 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
14427 a field initializer. Fixes #56459.
14429 2004-04-27 Martin Baulig <martin@ximian.com>
14431 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
14432 we're not attempting to use an indexer. Fixes #52154.
14434 2004-04-27 Martin Baulig <martin@ximian.com>
14436 * statement.cs (Return): Don't create a return label if we don't
14437 need it; reverts my change from January 20th. Thanks to Ben
14440 2004-04-27 Martin Baulig <martin@ximian.com>
14442 According to the spec, `goto' can only leave a nested scope, but
14445 * statement.cs (Block.LookupLabel): Only lookup in the current
14446 block, don't recurse into parent or child blocks.
14447 (Block.AddLabel): Check in parent and child blocks, report
14448 CS0140/CS0158 if we find a duplicate.
14449 (Block): Removed this indexer for label lookups.
14450 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
14451 this already does the error reporting for us.
14454 (FlowBranching.UsageVector.Block): New public variable; may be null.
14455 (FlowBranching.CreateSibling): Added `Block' argument.
14456 (FlowBranching.LookupLabel): New public virtual method. Lookup a
14457 label for the target of a `goto' and check whether we're not
14458 leaving a `finally'.
14460 2004-04-27 Martin Baulig <martin@ximian.com>
14462 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14463 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
14466 2004-04-27 Martin Baulig <martin@ximian.com>
14468 * statement.cs (Block.AddLabel): Also check for implicit blocks
14469 and added a CS0158 check.
14471 2004-04-27 Martin Baulig <martin@ximian.com>
14473 * flowanalysis.cs (FlowBranchingLoop): New class.
14474 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
14475 UsageVector's instead of an ArrayList.
14476 (FlowBranching.Label): Likewise.
14477 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
14478 (FlowBranching.AddBreakVector): New method.
14480 2004-04-27 Miguel de Icaza <miguel@ximian.com>
14482 * attribute.cs: Small regression fix: only convert the type if we
14483 the type is different, fixes System.Drawing build.
14485 2004-04-27 Martin Baulig <martin@ximian.com>
14487 * attribute.cs (Attribute.Resolve): If we have a constant value
14488 for a named field or property, implicity convert it to the correct
14491 2004-04-27 Raja R Harinath <rharinath@novell.com>
14493 * statement.cs (Block.Block): Implicit blocks share
14494 'child_variable_names' fields with parent blocks.
14495 (Block.AddChildVariableNames): Remove.
14496 (Block.AddVariable): Mark variable as "used by a child block" in
14497 every surrounding block.
14498 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
14499 been used in a child block, complain about violation of "Invariant
14500 meaning in blocks" rule.
14501 * cs-parser.jay (declare_local_variables): Don't use
14502 AddChildVariableNames.
14503 (foreach_statement): Don't create an implicit block: 'foreach'
14504 introduces a scope.
14506 2004-04-23 Miguel de Icaza <miguel@ximian.com>
14508 * convert.cs (ImplicitNumericConversion): 0 is also positive when
14509 converting from 0L to ulong. Fixes 57522.
14511 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14513 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
14514 derived class hides via 'new' keyword field from base class (test-242.cs).
14515 TODO: Handle this in the more general way.
14517 * class.cs (CheckBase): Ditto.
14519 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14521 * decl.cs (caching_flags): New member for storing cached values
14523 (MemberCore.Flags): New enum where bit flags for caching_flags
14525 (MemberCore.cls_compliance): Moved to caching_flags.
14526 (DeclSpace.Created): Moved to caching_flags.
14528 * class.cs: Use caching_flags instead of DeclSpace.Created
14530 2004-04-21 Miguel de Icaza <miguel@ximian.com>
14532 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
14533 if we are only a derived class, not a nested class.
14535 * typemanager.cs: Same as above, but do this at the MemberLookup
14536 level (used by field and methods, properties are handled in
14537 PropertyExpr). Allow for the qualified access if we are a nested
14540 2004-04-21 Marek Safar <marek.safar@seznam.cz>
14542 * class.cs: Refactoring.
14543 (IMethodData): New inteface; Holds links to parent members
14544 to avoid member duplication (reduced memory allocation).
14545 (Method): Implemented IMethodData interface.
14546 (PropertyBase): New inner classes for get/set methods.
14547 (PropertyBase.PropertyMethod): Implemented IMethodData interface
14548 (Event): New inner classes for add/remove methods.
14549 (Event.DelegateMethod): Implemented IMethodData interface.
14551 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
14552 EmitContext (related to class.cs refactoring).
14554 2004-04-21 Raja R Harinath <rharinath@novell.com>
14556 * delegate.cs (Delegate.VerifyApplicability): If the number of
14557 arguments are the same as the number of parameters, first try to
14558 verify applicability ignoring any 'params' modifier on the last
14562 2004-04-16 Raja R Harinath <rharinath@novell.com>
14564 * class.cs (TypeContainer.AddIndexer): Use
14565 'ExplicitInterfaceName' to determine if interface name was
14566 explicitly specified. 'InterfaceType' is not initialized at this time.
14567 (TypeContainer.DefineIndexers): Remove use of temporary list. The
14568 Indexers array is already in the required order. Initialize
14569 'IndexerName' only if there are normal indexers.
14570 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
14571 (TypeContainer.Emit): Emit DefaultMember attribute only if
14572 IndexerName is initialized.
14575 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
14577 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
14580 2004-04-15 Raja R Harinath <rharinath@novell.com>
14582 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
14586 * attribute.cs (Attribute.Resolve): Check for duplicate named
14590 2004-04-15 Miguel de Icaza <miguel@ximian.com>
14592 * iterators.cs (MarkYield): track whether we are in an exception,
14593 and generate code accordingly. Use a temporary value to store the
14594 result for our state.
14596 I had ignored a bit the interaction of try/catch with iterators
14597 since their behavior was not entirely obvious, but now it is
14598 possible to verify that our behavior is the same as MS .NET 2.0
14602 2004-04-14 Miguel de Icaza <miguel@ximian.com>
14604 * iterators.cs: Avoid creating temporaries if there is no work to
14607 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
14608 Enumerations, use TypeManager.EnumToUnderlying and call
14611 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
14614 (This.Emit): Use EmitContext.EmitThis to emit our
14617 (This.EmitAssign): Ditto.
14619 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
14620 codepaths, we will move all the functionality into
14623 (FieldExpr.EmitAssign): Ditto.
14625 This fixes several hidden bugs that I uncovered while doing a code
14626 review of this today.
14628 * codegen.cs (EmitThis): reworked so the semantics are more clear
14629 and also support value types "this" instances.
14631 * iterators.cs: Changed so that for iterators in value types, we
14632 do not pass the value type as a parameter.
14634 Initialization of the enumerator helpers is now done in the caller
14635 instead of passing the parameters to the constructors and having
14636 the constructor set the fields.
14638 The fields have now `assembly' visibility instead of private.
14640 2004-04-11 Miguel de Icaza <miguel@ximian.com>
14642 * expression.cs (Argument.Resolve): Check if fields passed as ref
14643 or out are contained in a MarshalByRefObject.
14645 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
14646 another compiler type.
14648 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
14650 * class.cs (Indexer.Define): use the new name checking method.
14651 Also, return false on an error.
14652 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
14653 (is_identifier_[start/part]_character): make static.
14655 2004-04-10 Miguel de Icaza <miguel@ximian.com>
14657 * expression.cs (Binary.ResolveOperator): Do no append strings
14658 twice: since we can be invoked more than once (array evaluation)
14659 on the same concatenation, take care of this here. Based on a fix
14660 from Ben (bug #56454)
14662 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
14664 * codegen.cs: Fix another case where CS1548 must be reported (when
14665 delay-sign isn't specified and no private is available #56564). Fix
14666 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
14667 error when MCS is used on the MS runtime and we need to delay-sign
14668 (which seems unsupported by AssemblyBuilder - see #56621).
14670 2004-04-08 Marek Safar <marek.safar@seznam.cz>
14672 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
14673 (TypeManager.ComputeNamespaces): Faster implementation for
14676 * compiler.csproj: Updated AssemblyName to mcs.
14678 2004-04-07 Miguel de Icaza <miguel@ximian.com>
14680 * rootcontext.cs: Add new types to the boot resolution.
14682 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
14683 MulticastDelegate is not allowed.
14685 * typemanager.cs: Add new types to lookup: System.TypedReference
14688 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
14689 check for TypedReference or ArgIterator, they are not allowed.
14691 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
14692 makes us properly catch 1510 in some conditions (see bug 56016 for
14695 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
14697 * CryptoConvert.cs: update from corlib version
14700 2004-04-05 Miguel de Icaza <miguel@ximian.com>
14702 * class.cs (Indexer.Define): Check indexername declaration
14704 2004-04-05 Marek Safar <marek.safar@seznam.cz>
14706 * attribute.cs (IsClsCompliant): Fixed problem with handling
14707 all three states (compliant, not-compliant, undetected).
14709 2004-03-30 Marek Safar <marek.safar@seznam.cz>
14711 * attribute.cs (Attribute): Location is now public.
14712 (Resolve): Store resolved arguments (pos_values) in attribute class.
14713 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
14714 (GetClsCompliantAttributeValue): New method that gets
14715 CLSCompliantAttribute value.
14716 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
14717 if exists else null.
14718 (AttributeTester): New class for CLS-Compliant verification routines.
14720 * class.cs (Emit): Add CLS-Compliant verification.
14721 (Method.GetSignatureForError): Implemented.
14722 (Constructor.GetSignatureForError): Implemented
14723 (Constructor.HasCompliantArgs): Returns if constructor has
14724 CLS-Compliant arguments.
14725 (Constructor.Emit): Override.
14726 (Construcor.IsIdentifierClsCompliant): New method; For constructors
14727 is needed to test only parameters.
14728 (FieldBase.GetSignatureForError): Implemented.
14729 (TypeContainer): New member for storing base interfaces.
14730 (TypeContainer.FindMembers): Search in base interfaces too.
14732 * codegen.cs (GetClsComplianceAttribute): New method that gets
14733 assembly or module CLSCompliantAttribute value.
14734 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
14736 (ModuleClass.Emit): Add error 3012 test.
14738 * const.cs (Emit): Override and call base for CLS-Compliant tests.
14740 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
14741 state for all decl types.
14742 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
14743 if CLS-Compliant tests are required.
14744 (IsClsCompliaceRequired): New method. Analyze whether code
14745 must be CLS-Compliant.
14746 (IsExposedFromAssembly): New method. Returns true when MemberCore
14747 is exposed from assembly.
14748 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
14749 value or gets cached value.
14750 (HasClsCompliantAttribute): New method. Returns true if MemberCore
14751 is explicitly marked with CLSCompliantAttribute.
14752 (IsIdentifierClsCompliant): New abstract method. This method is
14753 used to testing error 3005.
14754 (IsIdentifierAndParamClsCompliant): New method. Common helper method
14755 for identifier and parameters CLS-Compliant testing.
14756 (VerifyClsCompliance): New method. The main virtual method for
14757 CLS-Compliant verifications.
14758 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
14759 null. I don't know why is null (too many public members !).
14760 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
14761 and get value of first CLSCompliantAttribute that found.
14763 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
14764 (VerifyClsCompliance): Override and add extra tests.
14766 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
14767 clscheck- disable CLS-Compliant verification event if assembly is has
14768 CLSCompliantAttribute(true).
14770 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
14771 ApllyAttribute is now called in emit section as in the other cases.
14772 Possible future Emit integration.
14773 (IsIdentifierClsCompliant): New override.
14774 (VerifyClsCompliance): New override.
14775 (GetEnumeratorName): Returns full enum name.
14777 * parameter.cs (GetSignatureForError): Implemented.
14779 * report.cs (WarningData): New struct for Warning message information.
14780 (LocationOfPreviousError): New method.
14781 (Warning): New method. Reports warning based on the warning table.
14782 (Error_T): New method. Reports error based on the error table.
14784 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
14785 verifications are done here.
14787 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
14789 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
14790 CLSCompliantAttribute.
14791 (all_imported_types): New member holds all imported types from other
14793 (LoadAllImportedTypes): New method fills static table with exported types
14794 from all referenced assemblies.
14795 (Modules): New property returns all assembly modules.
14797 2004-03-30 Miguel de Icaza <miguel@ximian.com>
14799 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
14800 throwing a parser error.
14802 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
14803 which removes the hardcoded get_/set_ prefixes for properties, as
14804 IL allows for the properties to be named something else.
14808 * expression.cs: Do not override operand before we know if it is
14809 non-null. Fix 56207
14811 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
14813 * typemanager.cs: support for pinned variables.
14815 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
14817 * decl.cs, typemanager.cs: Avoid using an arraylist
14818 as a buffer if there is only one result set.
14820 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
14822 * expression.cs: Make sure you cant call a static method
14823 with an instance expression, bug #56174.
14825 2004-03-29 Miguel de Icaza <miguel@ximian.com>
14827 * class.cs (IsDuplicateImplementation): Improve error reporting to
14828 flag 663 (method only differs in parameter modifier).
14830 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
14831 in preprocessor directives.
14833 * location.cs (LookupFile): Allow for the empty path.
14835 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
14836 better approach for some of that patch, but its failing with the
14837 CharSet enumeration. For now try/catch will do.
14839 * typemanager.cs: Do not crash if a struct does not have fields.
14842 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
14844 * expression.cs: cs0213, cant fix a fixed expression.
14847 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
14849 * cs-parser.jay: detect invalid embeded statements gracefully.
14852 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
14854 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
14857 the invocation type may not be a subclass of the tye of the item/
14858 The type of the item must be a subclass of the invocation item.
14863 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
14865 * attribute.cs: Added methods to get a string and a bool from an
14866 attribute. Required to information from AssemblyKeyFileAttribute,
14867 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
14868 * codegen.cs: Modified AssemblyName creation to include support for
14869 strongnames. Catch additional exceptions to report them as CS1548.
14870 * compiler.csproj: Updated include CryptoConvert.cs.
14871 * compiler.csproj.user: Removed file - user specific configuration.
14872 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
14873 Mono.Security assembly. The original class is maintained and tested in
14874 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
14875 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
14876 like CSC 8.0 (C# v2) supports.
14877 * Makefile: Added CryptoConvert.cs to mcs sources.
14878 * rootcontext.cs: Added new options for strongnames.
14880 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
14882 * driver.cs: For --expect-error, report error code `2'
14883 if the program compiled with no errors, error code `1' if
14884 it compiled with an error other than the one expected.
14886 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
14888 * compiler.csproj: Updated for Visual Studio .NET 2003.
14889 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
14890 * compiler.sln: Updated for Visual Studio .NET 2003.
14892 2004-03-24 Ravi Pratap M <ravi@ximian.com>
14894 * expression.cs: Fix bug #47234. We basically need to apply the
14895 rule that we prefer the conversion of null to a reference type
14896 when faced with a conversion to 'object' (csc behaviour).
14898 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14900 * statement.cs: Shorter form for foreach, eliminates
14901 a local variable. r=Martin.
14903 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14905 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
14906 checks if we can use brtrue/brfalse to test for 0.
14907 * expression.cs: use the above in the test for using brtrue/brfalse.
14908 cleanup code a bit.
14910 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14912 * expression.cs: Rewrite string concat stuff. Benefits:
14914 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
14915 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
14916 rather than a concat chain.
14918 * typemanager.cs: Add lookups for more concat overloads.
14920 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
14922 * expression.cs: Emit shorter il code for array init.
14939 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
14941 * statement.cs: Before, two switch blocks would be merged if the
14942 total size of the blocks (end_item - begin_item + 1) was less than
14943 two times the combined sizes of the blocks.
14945 Now, it will only merge if after the merge at least half of the
14950 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
14952 * class.cs : csc build fix for GetMethods(). See bug #52503.
14954 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
14956 * expression.cs: Make sure fp comparisons work with NaN.
14957 This fixes bug #54303. Mig approved this patch a long
14958 time ago, but we were not able to test b/c the runtime
14961 2004-03-19 Miguel de Icaza <miguel@ximian.com>
14963 * ecore.cs (TypExpr.GetHashCode): implement this overload.
14965 2004-03-19 Martin Baulig <martin@ximian.com>
14967 * class.cs (MemberCore.IsDuplicateImplementation): Report the
14968 error here and not in our caller.
14970 2004-03-19 Martin Baulig <martin@ximian.com>
14972 * interface.cs: Completely killed this file.
14973 (Interface): We're now a TypeContainer and live in class.cs.
14975 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
14976 argument; we're now also called for interfaces.
14977 (TypeContainer.DefineMembers): Allow this method being called
14979 (TypeContainer.GetMethods): New public method; formerly known as
14980 Interface.GetMethod(). This is used by PendingImplementation.
14981 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
14982 it's now private and non-static.
14983 (Interface): Moved this here; it's now implemented similar to
14985 (Method, Property, Event, Indexer): Added `bool is_interface'
14986 argument to their .ctor's.
14987 (MemberBase.IsInterface): New public field.
14989 * cs-parser.jay: Create normal Method, Property, Event, Indexer
14990 instances instead of InterfaceMethod, InterfaceProperty, etc.
14991 (opt_interface_base): Removed; we now use `opt_class_base' instead.
14992 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
14994 2004-03-19 Martin Baulig <martin@ximian.com>
14996 * class.cs (MethodCore.IsDuplicateImplementation): New private
14997 method which does the CS0111 checking.
14998 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
14999 Use IsDuplicateImplementation().
15001 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
15003 * decl.cs (FindMemberToOverride): New method to find the correct
15004 method or property to override in the base class.
15006 - Make Method/Property use the above method to find the
15007 version in the base class.
15008 - Remove the InheritableMemberSignatureCompare as it is now
15011 This patch makes large code bases much faster to compile, as it is
15012 O(n) rather than O(n^2) to do this validation.
15014 Also, it fixes bug 52458 which is that nested classes are not
15015 taken into account when finding the base class member.
15017 Reviewed/Approved by Martin.
15019 2004-03-17 Marek Safar <marek.safar@seznam.cz>
15021 * interface.cs: In all interface classes removed redundant
15022 member initialization.
15024 2004-03-16 Martin Baulig <martin@ximian.com>
15026 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
15028 2004-03-15 Miguel de Icaza <miguel@ximian.com>
15030 * decl.cs (DefineTypeAndParents): New helper method to define a
15031 type's containers before the type itself is defined; This is a
15032 bug exposed by the recent changes to Windows.Forms when an
15033 implemented interface was defined inside a class that had not been
15036 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
15038 (Check): Loop correctly to report errors modifiers
15039 (UNSAFE was not in the loop, since it was the same as TOP).
15041 * interface.cs: Every interface member now takes a ModFlags,
15042 instead of a "is_new" bool, which we set on the base MemberCore.
15044 Every place where we called "UnsafeOk" in the interface, now we
15045 call the proper member (InterfaceMethod.UnsafeOK) instead to get
15046 the unsafe settings from the member declaration instead of the
15047 container interface.
15049 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
15051 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
15052 `set_indexer_name' to the pending bits (one per type).
15054 We fixed a bug today that was picking the wrong method to
15055 override, since for properties the existing InterfaceMethod code
15056 basically ignored the method name. Now we make sure that the
15057 method name is one of the valid indexer names.
15059 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
15061 * support.cs (SeekableStreamReader): Keep track of stream byte
15062 positions and don't mix them with character offsets to the buffer.
15064 Patch from Gustavo Giráldez
15066 2004-03-15 Marek Safar <marek.safar@seznam.cz>
15068 * interface.cs (InterfaceSetGetBase): Removed double member
15069 initialization, base class does it as well.
15071 2004-03-13 Martin Baulig <martin@ximian.com>
15073 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
15074 when compiling corlib.
15076 2004-03-13 Miguel de Icaza <miguel@ximian.com>
15078 * convert.cs (ExplicitConversion): We were reporting an error on
15079 certain conversions (object_type source to a value type, when the
15080 expression was `null') before we had a chance to pass it through
15081 the user defined conversions.
15083 * driver.cs: Replace / and \ in resource specifications to dots.
15086 * class.cs: Add check for duplicate operators. Fixes 52477
15088 2004-03-11 Miguel de Icaza <miguel@ximian.com>
15090 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
15091 that are in the middle of the statements, not only at the end.
15094 * class.cs (TypeContainer.AddField): No longer set the
15095 `HaveStaticConstructor' flag, now we call it
15096 `UserDefineStaticConstructor' to diferentiate the slightly
15097 semantic difference.
15099 The situation is that we were not adding BeforeFieldInit (from
15100 Modifiers.TypeAttr) to classes that could have it.
15101 BeforeFieldInit should be set to classes that have no static
15106 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
15108 And most importantly Zoltan's comment:
15110 http://bugzilla.ximian.com/show_bug.cgi?id=44229
15112 "I think beforefieldinit means 'it's ok to initialize the type sometime
15113 before its static fields are used', i.e. initialization does not need
15114 to be triggered by the first access to the type. Setting this flag
15115 helps the JIT to compile better code, since it can run the static
15116 constructor at JIT time, and does not need to generate code to call it
15117 (possibly lots of times) at runtime. Unfortunately, mcs does not set
15118 this flag for lots of classes like String.
15120 csc sets this flag if the type does not have an explicit static
15121 constructor. The reasoning seems to be that if there are only static
15122 initalizers for a type, and no static constructor, then the programmer
15123 does not care when this initialization happens, so beforefieldinit
15126 This bug prevents the AOT compiler from being usable, since it
15127 generates so many calls to mono_runtime_class_init that the AOT code
15128 is much slower than the JITted code. The JITted code is faster,
15129 because it does not generate these calls if the vtable is type is
15130 already initialized, which is true in the majority of cases. But the
15131 AOT compiler can't do this."
15133 2004-03-10 Miguel de Icaza <miguel@ximian.com>
15135 * class.cs (MethodData.Emit): Refactor the code so symbolic
15136 information is generated for destructors; For some reasons we
15137 were taking a code path that did not generate symbolic information
15140 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
15142 * class.cs: Create a Constructor.CheckBase method that
15143 takes care of all validation type code. The method
15144 contains some code that was moved from Define.
15146 It also includes new code that checks for duplicate ctors.
15147 This fixes bug #55148.
15149 2004-03-09 Joshua Tauberer <tauberer@for.net>
15151 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
15152 a { ... }-style array creation invokes EmitStaticInitializers
15153 which is not good for reference-type arrays. String, decimal
15154 and now null constants (NullCast) are not counted toward
15155 static initializers.
15157 2004-03-05 Martin Baulig <martin@ximian.com>
15159 * location.cs (SourceFile.HasLineDirective): New public field;
15160 specifies whether the file contains or is referenced by a "#line"
15162 (Location.DefineSymbolDocuments): Ignore source files which
15163 either contain or are referenced by a "#line" directive.
15165 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
15167 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
15168 direct access to our parent, so check the method inline there.
15170 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
15172 * expression.cs (Invocation.EmitCall): Miguel's last commit
15173 caused a regression. If you had:
15178 In Foo the implict this would be null.
15180 2004-02-27 Miguel de Icaza <miguel@ximian.com>
15182 * expression.cs (Invocation.EmitCall): If the method is not
15183 virtual, do not emit a CallVirt to it, use Call.
15185 * typemanager.cs (GetFullNameSignature): Improve the method to
15186 cope with ".ctor" and replace it with the type name.
15188 * class.cs (ConstructorInitializer.Resolve): Now the method takes
15189 as an argument the ConstructorBuilder where it is being defined,
15190 to catch the recursive constructor invocations.
15192 2004-02-26 Miguel de Icaza <miguel@ximian.com>
15194 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
15195 routines to check if a type is an enumerable/enumerator allow
15196 classes that implement the IEnumerable or IEnumerator interfaces.
15198 * class.cs (Property, Operator): Implement IIteratorContainer, and
15199 implement SetYields.
15201 (Property.Define): Do the block swapping for get_methods in the
15202 context of iterators. We need to check if Properties also
15203 include indexers or not.
15205 (Operator): Assign the Block before invoking the
15206 OperatorMethod.Define, so we can trigger the Iterator code
15209 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
15210 Property and Operator classes are not created when we parse the
15211 declarator but until we have the block completed, so we use a
15212 singleton SimpleIteratorContainer.Simple to flag whether the
15213 SetYields has been invoked.
15215 We propagate this setting then to the Property or the Operator to
15216 allow the `yield' to function.
15218 2004-02-25 Marek Safar <marek.safar@seznam.cz>
15220 * codegen.cs: Implemented attribute support for modules.
15221 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
15222 Assembly/Module functionality.
15224 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
15225 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
15226 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
15228 2004-02-16 Marek Safar <marek.safar@seznam.cz>
15230 * interface.cs (FindMembers): The operation is performed on all base
15231 interfaces and not only on the first. It is required for future CLS Compliance patch.
15233 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
15235 * statement.cs, codegen.cs:
15236 This patch deals with patterns such as:
15238 public class List : IEnumerable {
15240 public MyEnumerator GetEnumerator () {
15241 return new MyEnumerator(this);
15244 IEnumerator IEnumerable.GetEnumerator () {
15248 public struct MyEnumerator : IEnumerator {
15253 Before, there were a few things we did wrong:
15254 1) we would emit callvirt on a struct, which is illegal
15255 2) we emited ldarg when we needed to emit ldarga
15256 3) we would mistakenly call the interface methods on an enumerator
15257 type that derived from IEnumerator and was in another assembly. For example:
15259 public class MyEnumerator : IEnumerator
15261 Would have the interface methods called, even if there were public impls of the
15262 method. In a struct, this lead to invalid IL code.
15264 2004-02-11 Marek Safar <marek.safar@seznam.cz>
15266 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
15269 * delegate.cs (Define): Fixed crash when delegate type is undefined.
15271 2004-02-11 Miguel de Icaza <miguel@ximian.com>
15273 * cs-parser.jay: Fix small regression: we were not testing V2
15274 compiler features correctly.
15276 * interface.cs: If the emit context is null, then create one
15278 2004-02-09 Marek Safar <marek.safar@seznam.cz>
15280 * decl.cs (GetSignatureForError): New virtual method to get full name
15281 for error messages.
15283 * attribute.cs (IAttributeSupport): New interface for attribute setting.
15284 Now it is possible to rewrite ApplyAttributes method to be less if/else.
15286 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
15287 Duplicated members and code in these classes has been removed.
15288 Better encapsulation in these classes.
15290 2004-02-07 Miguel de Icaza <miguel@ximian.com>
15292 * assign.cs (Assign.DoResolve): When dealing with compound
15293 assignments, there is a new rule in ECMA C# 2.4 (might have been
15294 there before, but it is documented here) that states that in:
15298 If b is of type int, and the `op' is a shift-operator, then the
15299 above is evaluated as:
15303 * expression.cs (Binary.ResolveOperator): Instead of testing for
15304 int/uint/long/ulong, try to implicitly convert to any of those
15305 types and use that in pointer arithmetic.
15307 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
15308 method to print information for from the type, not from the
15309 null-method we were given.
15311 2004-02-01 Duncan Mak <duncan@ximian.com>
15313 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
15314 parsing for cmd, fixes bug #53694.
15316 2004-02-04 Marek Safar <marek.safar@seznam.cz>
15318 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
15319 in the member name duplication tests. Property and operator name duplication
15320 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
15322 2004-02-03 Marek Safar <marek.safar@seznam.cz>
15324 * interface.cs (PopulateMethod): Fixed crash when interface method
15325 returns not existing type (error test cs0246-3.cs).
15327 2004-02-02 Ravi Pratap M <ravi@ximian.com>
15329 * cs-parser.jay (interface_accessors): Re-write actions to also
15330 store attributes attached to get and set methods. Fix spelling
15333 (inteface_property_declaration): Modify accordingly.
15335 (InterfaceAccessorInfo): New helper class to store information to pass
15336 around between rules that use interface_accessors.
15338 * interface.cs (Emit): Apply attributes on the get and set
15339 accessors of properties and indexers too.
15341 * attribute.cs (ApplyAttributes): Modify accordingly to use the
15342 right MethodBuilder when applying attributes to the get and set accessors.
15344 2004-01-31 Miguel de Icaza <miguel@ximian.com>
15346 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
15348 2004-01-26 Miguel de Icaza <miguel@ximian.com>
15350 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
15352 2004-01-25 Miguel de Icaza <miguel@ximian.com>
15354 * cs-parser.jay: Remove YIELD token, instead use the new grammar
15355 changes that treat `yield' specially when present before `break'
15356 or `return' tokens.
15358 * cs-tokenizer.cs: yield is no longer a keyword.
15360 2004-01-23 Marek Safar <marek.safar@seznam.cz>
15362 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
15363 setting for default constructors.
15364 For default constructors are almost every time set wrong Modifier. The
15365 generated IL code has been alright. But inside mcs this values was
15366 wrong and this was reason why several of my CLS Compliance tests
15369 2004-01-22 Martin Baulig <martin@ximian.com>
15371 * cs-parser.jay (namespace_or_type_name): Return an Expression,
15372 not a QualifiedIdentifier. This is what `type_name_expression'
15373 was previously doing.
15374 (type_name_expression): Removed; the code is now in
15375 `namespace_or_type_name'.
15376 (qualified_identifier): Removed, use `namespace_or_type_name'
15378 (QualifiedIdentifier): Removed this class.
15380 2004-01-22 Martin Baulig <martin@ximian.com>
15382 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
15383 not a string as alias name.
15385 2004-01-21 Miguel de Icaza <miguel@ximian.com>
15387 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
15388 #52730 bug, and instead compute correctly the need to use a
15389 temporary variable when requesting an address based on the
15390 static/instace modified of the field and the constructor.
15392 2004-01-21 Martin Baulig <martin@ximian.com>
15394 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
15395 class and namespace before looking up aliases. Fixes #52517.
15397 2004-01-21 Martin Baulig <martin@ximian.com>
15399 * flowanalysis.cs (UsageVector.Merge): Allow variables being
15400 assinged in a 'try'; fixes exception4.cs.
15402 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15403 * class.cs : Implemented parameter-less constructor for TypeContainer
15405 * decl.cs: Attributes are now stored here. New property OptAttributes
15407 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
15409 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
15411 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15413 * typemanager.cs (CSharpSignature): Now reports also inner class name.
15414 (CSharpSignature): New method for indexer and property signature.
15416 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15418 * pending.cs (IsVirtualFilter): Faster implementation.
15420 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15422 * typemanager.cs: Avoid inclusion of same assembly more than once.
15424 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15426 * cs-parser.jay: Fixed problem where the last assembly attribute
15427 has been applied also to following declaration (class, struct, etc.)
15429 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15431 * class.cs: Added error CS0538, CS0539 reporting.
15432 Fixed crash on Microsoft runtime when field type is void.
15434 * cs-parser.jay: Added error CS0537 reporting.
15436 * pending.cs: Added error CS0535 reporting.
15437 Improved error report for errors CS0536, CS0534.
15439 2004-01-20 Miguel de Icaza <miguel@ximian.com>
15441 Merge a few bits from the Anonymous Method MCS tree.
15443 * statement.cs (ToplevelBlock): New class for toplevel methods,
15444 will hold anonymous methods, lifted variables.
15446 * cs-parser.jay: Create toplevel blocks for delegates and for
15447 regular blocks of code.
15449 2004-01-20 Martin Baulig <martin@ximian.com>
15451 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
15452 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
15453 and `NeedExplicitReturn'; added `IsLastStatement'.
15454 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
15455 have a `ReturnLabel' or we're not unreachable.
15457 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
15458 child's reachability; don't just override ours with it. Fixes
15459 #58058 (lluis's example).
15460 (FlowBranching): Added public InTryOrCatch(), InCatch(),
15461 InFinally(), InLoop(), InSwitch() and
15462 BreakCrossesTryCatchBoundary() methods.
15464 * statement.cs (Return): Do all error checking in Resolve().
15465 Unless we are the last statement in a top-level block, always
15466 create a return label and jump to it.
15467 (Break, Continue): Do all error checking in Resolve(); also make
15468 sure we aren't leaving a `finally'.
15469 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
15470 statement in a top-level block.
15471 (Block.Flags): Added `IsDestructor'.
15472 (Block.IsDestructor): New public property.
15474 2004-01-20 Martin Baulig <martin@ximian.com>
15476 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
15478 2004-01-20 Martin Baulig <martin@ximian.com>
15480 * statement.cs (Statement.ResolveUnreachable): New public method.
15481 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
15482 (Block.Resolve): Resolve unreachable statements.
15484 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15486 * expression.cs: We need to fix the case where we do
15487 not have a temp variable here.
15489 * assign.cs: Only expression compound assignments need
15490 temporary variables.
15492 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15494 * flowanalysis.cs: Reduce memory allocation in a few ways:
15495 - A block with no variables should not allocate a bit
15497 - A method with no out parameters does not need any tracking
15498 for assignment of the parameters, so we need not allocate
15501 public readonly Type[] VariableTypes;
15502 public readonly string[] VariableNames;
15503 Are redundant. The data is already stored in the variable
15504 map, so we need not allocate another array for it.
15505 - We need to add alot of checks for if (params | locals) == null
15506 due to the first two changes.
15508 2004-01-18 Miguel de Icaza <miguel@ximian.com>
15510 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
15511 implement IMemoryLocation, we store a copy on a local variable and
15512 take the address of it. Patch from Benjamin Jemlich
15514 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
15515 to use a special "type_name_expression" rule which reduces the
15516 number of "QualifiedIdentifier" classes created, and instead
15517 directly creates MemberAccess expressions.
15519 2004-01-17 Miguel de Icaza <miguel@ximian.com>
15521 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
15522 that fixes #52853. Null literal assignment to ValueType
15524 * class.cs (MethodData.Emit): Instead of checking the name of the
15525 method to determine if its a destructor, create a new derived
15526 class from Method called Destructor, and test for that.
15528 * cs-parser.jay: Create a Destructor object instead of a Method.
15530 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
15534 2004-01-16 Miguel de Icaza <miguel@ximian.com>
15536 * expression.cs (Binary.ResolveOperator): Perform an implicit
15537 conversion from MethodGroups to their delegate types on the
15538 Addition operation.
15540 * delegate.cs: Introduce a new class DelegateCreation that is the
15541 base class for `NewDelegate' and `ImplicitDelegateCreation',
15542 factor some code in here.
15544 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
15545 conversion from MethodGroups to compatible delegate types.
15547 * ecore.cs (Expression.Resolve): Do not flag error 654
15548 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
15549 we allow conversions from MethodGroups to delegate types now.
15551 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
15552 assignments in v2 either.
15554 2004-01-10 Miguel de Icaza <miguel@ximian.com>
15556 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
15557 static read-only fields in ctors.
15559 Applied patch from Benjamin Jemlich
15561 * expression.cs (UnaryMutator): Avoid leaking local variables.
15563 2004-01-09 Miguel de Icaza <miguel@ximian.com>
15565 * cs-tokenizer.cs (IsCastToken): Allow the various native types
15566 here to return true, as they can be used like this:
15568 (XXX) int.MEMBER ()
15570 Fixed 49836 and all the other dups
15572 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
15574 * driver.cs: Implement /win32res and /win32icon.
15576 2004-01-08 Miguel de Icaza <miguel@ximian.com>
15578 * cs-parser.jay: Add a rule to improve error handling for the
15579 common mistake of placing modifiers after the type.
15581 2004-01-07 Miguel de Icaza <miguel@ximian.com>
15583 * cs-parser.jay (interface_event_declaration): Catch
15584 initialization of events on interfaces, and report cs0068
15586 * cs-parser.jay (interface_event_declaration): Catch
15587 initialization of events.
15589 * ecore.cs: Better report missing constructors.
15591 * expression.cs (Binary.ResolveOperator): My previous bug fix had
15592 the error reporting done in the wrong place. Fix.
15594 * expression.cs (Binary.ResolveOperator): Catch the
15595 operator + (E x, E y) error earlier, and later allow for implicit
15596 conversions in operator +/- (E e, U x) from U to the underlying
15599 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
15600 52596, if the container class is abstract, the default constructor
15601 is protected otherwise its public (before, we were always public).
15603 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
15606 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
15607 Jemlich that fixes bug #52597, MCS was generating invalid code for
15608 idisposable structs. Thanks to Ben for following up with this
15611 2004-01-06 Miguel de Icaza <miguel@ximian.com>
15613 * driver.cs: Allow assemblies without code to be generated, fixes
15616 2004-01-07 Nick Drochak <ndrochak@gol.com>
15618 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
15620 2004-01-05 Miguel de Icaza <miguel@ximian.com>
15622 * cs-parser.jay: Add rules to improve error reporting if fields or
15623 methods are declared at the namespace level (error 116)
15625 * Add rules to catch event add/remove
15627 2004-01-04 David Sheldon <dave-mono@earth.li>
15629 * expression.cs: Added matching ")" to error message for
15632 2004-01-03 Todd Berman <tberman@gentoo.org>
15634 * ecore.cs, attribute.cs:
15635 Applying fix from #52429.
15637 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15639 * ecore.cs, expression.cs, statement.cs:
15640 Total rewrite of how we handle branching. We
15641 now handle complex boolean expressions with fewer
15642 jumps. As well if (x == 0) no longer emits a ceq.
15644 if (x is Foo) is much faster now, because we generate
15647 Overall, we get a pretty big improvement on our benchmark
15648 tests. The code we generate is smaller and more readable.
15650 I did a full two-stage bootstrap. The patch was reviewed
15651 by Martin and Miguel.
15653 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15655 * cs-parser.jay: Make primary_expression not take a QI.
15656 we dont need this because the member_access rule covers
15657 us here. So we replace the rule with just IDENTIFIER.
15659 This has two good effects. First, we remove a s/r conflict.
15660 Second, we allocate many fewer QualifiedIdentifier objects.
15662 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15664 * attribute.cs: Handle MarshalAs attributes as pseudo, and
15665 set the correct information via SRE. This prevents
15666 hanging on the MS runtime. Fixes #29374.
15668 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15670 * convert.cs: correctly handle conversions to value types
15671 from Enum and ValueType as unboxing conversions.
15673 Fixes bug #52569. Patch by Benjamin Jemlich.
15675 2004-01-02 Ravi Pratap <ravi@ximian.com>
15677 * expression.cs (BetterConversion): Prefer int -> uint
15678 over int -> ulong (csc's behaviour). This fixed bug #52046.
15680 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
15682 * decl.cs (MemberCache.FindMembers): now returns a
15685 * typemanager.cs: In general, go with with ^^.
15686 (CopyNewMethods): take an IList.
15687 (RealMemberLookup): Only allocate an arraylist
15688 if we copy from two sets of methods.
15690 This change basically does two things:
15691 1) Fewer array lists allocated due to CopyNewMethods.
15692 2) the explicit cast in MemberList costed ALOT.
15694 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
15696 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
15697 a hashtable to avoid needless string allocations when an identifier is
15698 used more than once (the common case).
15700 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
15702 * pending.cs: MS's TypeBuilder.GetInterfaces ()
15703 is broken, it will not return anything. So, we
15704 have to use the information we have in mcs to
15707 * typemanager.cs: Add a cache for GetInterfaces,
15708 since this will now be used more often (due to ^^)
15710 (GetExplicitInterfaces) New method that gets the
15711 declared, not effective, interfaces on a type
15712 builder (eg, if you have interface IFoo, interface
15713 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
15716 This patch makes MCS able to bootstrap itself on
15719 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
15721 * expression.cs: Remove the Nop's that Miguel put
15724 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15726 * report.cs, codegen.cs: Give the real stack trace to
15727 the error when an exception is thrown.
15729 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15731 * decl.cs: only allocate hashtables for ifaces if
15734 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15736 * expression.cs: fix the error from cs0121-2.cs
15737 (a parent interface has two child interfaces that
15738 have a function with the same name and 0 params
15739 and the function is called through the parent).
15741 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
15743 * class.cs, rootcontext.cs, typmanager.cs: do not
15746 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
15748 * codegen.cs: remove stack for the ec flow branching.
15749 It is already a linked list, so no need.
15751 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
15753 * Makefile: Allow custom profiler here.
15755 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
15757 * typemanager.cs (LookupType):
15758 - Use a static char [], because split takes
15759 a param array for args, so it was allocating
15761 - Do not store true in a hashtable, it boxes.
15763 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
15765 * flowanalysis.cs: bytify common enums.
15767 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
15769 * modifiers.cs: Add a new set of flags for the
15770 flags allowed on explicit interface impls.
15771 * cs-parser.jay: catch the use of modifiers in
15772 interfaces correctly.
15773 * class.cs: catch private void IFoo.Blah ().
15775 All related to bug #50572.
15777 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
15779 * decl.cs: Rewrite the consistant accessability checking.
15780 Accessability is not linear, it must be implemented in
15781 a tableish way. Fixes #49704.
15783 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
15785 * expression.cs: Handle negation in a checked context.
15786 We must use subtraction from zero. Fixes #38674.
15788 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
15790 * class.cs: Ignore static void main in DLLs.
15791 * rootcontext.cs: Handle the target type here,
15792 since we are have to access it from class.cs
15793 * driver.cs: account for the above.
15795 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
15797 * report.cs: Give line numbers and files if available.
15799 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
15801 * driver.cs: Implement /addmodule.
15803 * typemanager.cs: Change 'modules' field so it now contains Modules not
15806 2003-12-20 Martin Baulig <martin@ximian.com>
15808 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
15809 (FieldBase.IsAssigned): Removed this field.
15810 (FieldBase.SetAssigned): New public method.
15811 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
15813 2003-12-20 Martin Baulig <martin@ximian.com>
15815 * expression.cs (LocalVariableReference.DoResolve): Don't set
15816 `vi.Used' if we're called from DoResolveLValue().
15818 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
15819 returns the usage vector it just merged into the current one -
15820 pass this one to UsageWarning().
15821 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
15822 of the `EmitContext', don't call this recursively on our children.
15824 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
15826 * driver.cs: Implement /target:module.
15828 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
15830 * support.cs (CharArrayHashtable): New helper class.
15832 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
15833 char arrays, not strings, so we can avoid creating a string in
15834 consume_identifier if the identifier is a keyword.
15836 2003-12-16 Martin Baulig <martin@ximian.com>
15838 * statement.cs (LocalInfo.Assigned): Removed this property.
15839 (LocalInfo.Flags): Removed `Assigned'.
15840 (LocalInfo.IsAssigned): New public method; takes the EmitContext
15841 and uses flow analysis.
15842 (Block.UsageWarning): Made this method private.
15843 (Block.Resolve): Call UsageWarning() if appropriate.
15845 * expression.cs (LocalVariableReference.DoResolve): Always set
15846 LocalInfo.Used here.
15848 2003-12-13 Martin Baulig <martin@ximian.com>
15850 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
15851 any value here; we're now using flow analysis to figure out
15852 whether a statement/block returns a value.
15854 2003-12-13 Martin Baulig <martin@ximian.com>
15856 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
15858 (FlowBranching.MergeFinally): Don't call
15859 `branching.CheckOutParameters()' here, this is called in
15861 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
15862 when adding the `finally' vector.
15864 2003-12-13 Martin Baulig <martin@ximian.com>
15867 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
15868 actually work and also fix #48962.
15870 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
15872 * decl.cs: Do not check System.Object for nested types,
15873 since we know it does not have any. Big bang for buck:
15876 Run 1: 8.35 seconds
15877 Run 2: 8.32 seconds
15878 corlib: 17.99 seconds
15880 Run 1: 8.17 seconds
15881 Run 2: 8.17 seconds
15882 corlib: 17.39 seconds
15884 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
15886 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
15887 time we are returning 0 members, so we save alot here.
15889 2003-12-11 Martin Baulig <martin@ximian.com>
15891 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
15892 `MergeChild()', also just take the `FlowBranching' as argument;
15893 call Merge() on it and return the result.
15894 (FlowBranching.Merge): We don't need to do anything if we just
15897 2003-12-11 Martin Baulig <martin@ximian.com>
15899 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
15900 them in an `ArrayList' to reduce memory usage. Thanks to Ben
15901 Maurer for this idea.
15903 2003-12-11 Martin Baulig <martin@ximian.com>
15905 * flowanalysis.cs (MergeResult): This class is now gone; we now
15906 use the `UsageVector' for this. The reason for this is that if a
15907 branching just has one sibling, we don't need to "merge" them at
15908 all - that's the next step to do.
15909 (FlowBranching.Merge): We now return a `UsageVector' instead of a
15912 2003-12-11 Martin Baulig <martin@ximian.com>
15914 Reworked flow analyis and made it more precise and bug-free. The
15915 most important change is that we're now using a special `Reachability'
15916 class instead of having "magic" meanings of `FlowReturns'. I'll
15917 do some more cleanups and optimizations and also add some more
15918 documentation this week.
15920 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
15921 largely reworked this class.
15922 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
15923 the new `Reachability' class instead of having "magic" values here.
15924 (FlowBranching): We're now using an instance of `Reachability'
15925 instead of having separate `Returns', `Breaks' etc. fields.
15927 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
15928 based on flow analysis; ignore the return value of block.Emit ().
15930 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
15932 * driver.cs typemanager.cs: Find the mono extensions to corlib even
15933 if they are private.
15935 2003-12-09 Martin Baulig <martin@ximian.com>
15937 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
15938 call them directly on the UsageVector.
15940 2003-12-09 Martin Baulig <martin@ximian.com>
15942 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
15943 Changed return type from `FlowReturns' to `Reachability'.
15945 2003-12-09 Martin Baulig <martin@ximian.com>
15947 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
15948 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
15949 `Reachable' fields with a single `Reachability' one.
15951 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15953 * class.cs (FindMembers): Remove foreach's.
15958 Run 1: 8.74 seconds
15959 Run 2: 8.71 seconds
15962 Run 1: 8.64 seconds
15963 Run 2: 8.58 seconds
15966 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15971 This patch does a few things:
15972 1. EmptyStatement is now a singleton, so it is never reallocated.
15973 2. All blah is EmptyStatement constructs have been changed to
15974 blah == EmptyStatement.Value, which is much faster and valid
15975 now that EmptyStatement is a singleton.
15976 3. When resolving a block, rather than allocating a new array for
15977 the non-empty statements, empty statements are replaced with
15978 EmptyStatement.Value
15979 4. Some recursive functions have been made non-recursive.
15980 Mainly the performance impact is from (3), however (1) and (2) are needed for
15981 this to work. (4) does not make a big difference in normal situations, however
15982 it makes the profile look saner.
15987 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15988 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
15989 Total memory allocated: 56397 KB
15992 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
15993 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
15994 Total memory allocated: 55666 KB
15996 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
15998 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
15999 than the hashtable in a hashtable version
16001 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
16002 we always end up concating a string. This results in a huge perf
16003 loss, because many strings have to be tracked by the GC. In this
16004 patch, we first use a hashtable that works with two keys, so that
16005 the strings do not need to be concat'ed.
16009 Run 1: 8.74 seconds
16010 Run 2: 8.71 seconds
16013 Run 1: 8.65 seconds
16014 Run 2: 8.56 seconds
16016 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16018 * Makefile: Add a new target `do-time' that does a quick and simple
16019 profile, leaving easy to parse output.
16021 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
16023 * codegen.cs (Init): Create the dynamic assembly with
16024 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
16026 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
16028 * support.cs: Make the PtrHashtable use only one
16029 instance of its comparer.
16031 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
16033 * typemanager.cs: Fix lookup of GetNamespaces.
16035 2003-11-29 Miguel de Icaza <miguel@ximian.com>
16037 * expression.cs: Removed redundant line.
16039 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
16040 ArrayLists, use for loops with bounds.
16042 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
16045 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
16046 arraylists, use for loop with bounds.
16048 The above three changes give us a 0.071 second performance
16049 improvement out of 3.294 seconds down to 3.223. On my machine
16050 the above changes reduced the memory usage by 1,387 KB during
16051 compiler bootstrap.
16053 * cs-parser.jay (QualifiedIdentifier): New class used to represent
16054 QualifiedIdentifiers. Before we created a new string through
16055 concatenation, and mostly later on, the result would be
16056 manipulated by DecomposeQI through string manipulation.
16058 This reduced the compiler memory usage for bootstrapping from
16059 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
16060 compile times in 0.05 seconds.
16062 2003-11-28 Dick Porter <dick@ximian.com>
16064 * support.cs: Do string compares with the Invariant culture.
16072 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
16073 the comparison is done with the Invariant culture.
16075 2003-11-27 Miguel de Icaza <miguel@ximian.com>
16077 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
16078 GetEnumerator method.
16080 (ProbeCollectionType): Iterate starting at the most specific type
16081 upwards looking for a GetEnumerator
16083 * expression.cs: Shift count can be up to 31 for int/uint and 63
16086 2003-11-26 Miguel de Icaza <miguel@ximian.com>
16088 * statement.cs (Block.LookupLabel): Also look for the label on the
16089 children blocks. Use a hash table to keep track of visited
16092 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
16093 we actually did transform the other operand, otherwise fall back
16094 to the common codepath that casts to long.
16096 * cs-tokenizer.cs: Use the same code pattern as the int case.
16097 Maybe I should do the parsing myself, and avoid depending on the
16098 Parse routines to get this done.
16100 2003-11-25 Miguel de Icaza <miguel@ximian.com>
16102 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16103 which fixes bug 51347. This time test it.
16105 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
16106 attributes for example can not tell the difference between these.
16107 The difference was only a syntax feature of the language.
16109 * attribute.cs: Apply attributes to delegates.
16111 * delegate.cs: Call the apply attributes method.
16113 2003-11-24 Miguel de Icaza <miguel@ximian.com>
16115 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
16116 comparing 0 vs Byte.MinValue, not the value
16118 (ImplicitConversionRequired): When reporting a conversion error,
16119 use error 31 to print out the constant error instead of the
16122 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16123 which fixes bug 51347.
16125 2003-11-22 Miguel de Icaza <miguel@ximian.com>
16127 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
16128 which fixes the -warnaserror command line option.
16130 2003-11-21 Miguel de Icaza <miguel@ximian.com>
16132 * cfold.cs (DoNumericPromotions): During constant folding of
16133 additions on UIntConstant, special case intconstants with
16134 IntConstants like we do on the expression binary operator.
16136 2003-11-12 Miguel de Icaza <miguel@ximian.com>
16138 * convert.cs (ImplicitReferenceConversion): We were missing a case
16139 (System.Enum are not value types or class types, so we need to
16140 classify them separatedly).
16142 * driver.cs: We do not support error 2007.
16144 2003-11-12 Jackson Harper <jackson@ximian.com>
16146 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
16147 system directory. Also use the full file name so users can
16148 libraries names mscorlib-o-tron.dll in a non system dir.
16150 2003-11-10 Martin Baulig <martin@ximian.com>
16152 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
16153 (TypeManager.InitCoreTypes): Initialize them here, but instead of
16154 calling `ResolveType()' on them, directly assign their `Type'.
16156 2003-11-08 Martin Baulig <martin@ximian.com>
16158 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
16159 return value and the `out parent' parameter.
16160 (TypeContainer.DefineType): Moved the CS0644 check into
16161 GetClassBases(). Don't pass the interface types to the
16162 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
16163 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
16165 * ecore.cs (TypeExpr.IsAttribute): New property.
16166 (TypeExpr.GetInterfaces): New method.
16168 * interface.cs (Interface.GetInterfaceTypeByName): Return a
16169 TypeExpr instead of a Type.
16170 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
16171 (Interface.DefineType): Don't pass the interface types to the
16172 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
16173 them later and then call `TypeBulider.AddInterfaceImplementation()'.
16175 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
16176 instead of a `Type[]'.
16177 (TypeManager.RegisterBuilder): Likewise.
16178 (TypeManager.AddUserInterface): Likewise.
16179 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
16180 `Type[]' and also return a `TypeExpr[]'.
16181 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
16183 2003-11-08 Martin Baulig <martin@ximian.com>
16185 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
16188 2003-11-08 Martin Baulig <martin@ximian.com>
16190 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
16191 TypeManager.ResolveExpressionTypes().
16193 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
16194 instead of an Expression.
16195 (TypeExpr): This is now an abstract base class for `TypeExpression'.
16196 (TypeExpression): New public class; formerly known as `TypeExpr'.
16198 * expression.cs (ComposedCast): Derive from TypeExpr.
16200 * typemanager.cs (TypeManager.system_*_expr): These are now
16201 TypExpr's instead of Expression's.
16202 (TypeManager.ResolveExpressionTypes): New public static function;
16203 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
16206 2003-11-06 Miguel de Icaza <miguel@ximian.com>
16208 * expression.cs (New.DoResolve): Do not dereference value that
16209 might be a null return.
16211 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
16212 sure that the constant value has the right type. Fixes an
16213 unreported bug, similar to 50425.
16215 * const.cs (Const.LookupConstantValue): Call
16216 ImplicitStandardConversionExists before doing a conversion to
16217 avoid havng the TypeManager.ChangeType do conversions.
16219 Reduced the number of casts used
16221 (Const.ChangeType): New routine to enable reuse of the constant
16222 type changing code from statement.
16224 * typemanager.cs (ChangeType): Move common initialization to
16225 static global variables.
16229 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
16230 every value type to go through, even if it was void. Fix that.
16232 * cs-tokenizer.cs: Use is_identifier_start_character on the start
16233 character of the define, and the is_identifier_part_character for
16234 the rest of the string.
16236 2003-11-05 Miguel de Icaza <miguel@ximian.com>
16238 * expression.cs (UnaryMutator.EmitCode): When I updated
16239 LocalVariableReference.DoResolve, I overdid it, and dropped an
16240 optimization done on local variable references.
16242 2003-11-04 Miguel de Icaza <miguel@ximian.com>
16244 * ecore.cs: Convert the return from Ldlen into an int.
16246 2003-10-20 Miguel de Icaza <miguel@ximian.com>
16248 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
16249 the accessibility, this is a special case for toplevel non-public
16250 classes (internal for instance).
16252 2003-10-20 Nick Drochak <ndrochak@gol.com>
16254 * ecore.cs: Fix typo and build. Needed another right paren.
16256 2003-10-19 Miguel de Icaza <miguel@ximian.com>
16258 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
16259 `internal' case regular and protected, but not allowing protected
16260 to be evaluated later. Bug 49840
16262 2003-10-15 Miguel de Icaza <miguel@ximian.com>
16264 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
16265 to kb.Nlast, and not the kb.nFirst to isolate the switch
16268 Extract the underlying type, so enumerations of long/ulong are
16269 treated like long/ulong.
16271 2003-10-14 Miguel de Icaza <miguel@ximian.com>
16273 * expression.cs (New): Overload the meaning of RequestedType to
16274 track the possible creation of the NewDelegate type, since
16275 DoResolve is invoked more than once for new constructors on field
16278 See bugs: #48800 and #37014
16280 * cs-parser.jay (declare_local_constants): Take an arraylist
16281 instead of a single constant.
16283 (local_constant_declaration): It should take a
16284 constant_declarators, not a constant_declarator. Fixes 49487
16286 * convert.cs: Fix error report.
16288 2003-10-13 Jackson Harper <jackson@ximian.com>
16290 * typemanager.cs (TypeToCoreType): Add float and double this fixes
16293 2003-10-09 Martin Baulig <martin@ximian.com>
16295 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
16297 (MethodCore.DoDefineParameters): Removed the TypeContainer
16298 argument; use the DeclSpace which was passed to the .ctor instead.
16299 (MethodCore.CheckParameter): Take a DeclSpace instead of a
16300 TypeContainer; we only need a DeclSpace here.
16302 2003-10-09 Martin Baulig <martin@ximian.com>
16304 * class.cs (MethodData): Added additional `DeclSpace ds' argument
16306 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
16307 EmitContext's .ctor.
16309 2003-10-09 Martin Baulig <martin@ximian.com>
16311 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
16312 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
16313 AsAccessible(), moved them as well.
16315 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
16317 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
16319 * cs-parser.jay : Renamed yyName to yyNames related to jay.
16321 2003-10-07 Miguel de Icaza <miguel@ximian.com>
16323 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
16324 generation for >=, as spotted by Paolo, bug 48679.
16325 Patch from David Waite.
16327 * cs-tokenizer.cs: Add handling for #pragma.
16329 * cs-parser.jay: Allow for both yield and yield return in the
16330 syntax. The anti-cobolization of C# fight will go on!
16332 * class.cs (TypeBuilder.DefineType): Catch error condition here
16333 (Parent.DefineType erroring out and returning null).
16335 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16336 coping with enumerations variables, we were mistakenly processing
16337 them as a regular value type instead of built-in types. Fixes the
16340 * typemanager.cs (IsBuiltinOrEnum): New method.
16342 2003-09-30 Miguel de Icaza <miguel@ximian.com>
16344 * cs-parser.jay: Upgrade: yield now needs the return clause.
16346 2003-09-19 Martin Baulig <martin@ximian.com>
16348 * decl.cs (MemberCache.SetupCacheForInterface): Take a
16349 `MemberCache parent' argument. Normally, an interface doesn't
16350 have a parent type except System.Object, but we use this in gmcs
16351 for generic type parameters.
16353 2003-09-18 Martin Baulig <martin@ximian.com>
16355 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
16356 on `type.IsInterface'; don't check whether the type has a parent
16357 to determine whether it's an interface.
16359 2003-09-15 Martin Baulig <martin@ximian.com>
16361 * class.cs (TypeContainer.DefineType): Added an error flag to
16362 avoid reporting duplicate CS0146's ("class definition is
16365 * driver.cs (Driver.MainDriver): Abort if
16366 RootContext.ResolveTree() reported any errors.
16368 2003-09-07 Martin Baulig <martin@ximian.com>
16370 * report.cs (Error, Warning): Added overloaded versions which take
16371 a `params object[] args' and call String.Format().
16373 2003-09-07 Martin Baulig <martin@ximian.com>
16375 * decl.cs (DeclSpace..ctor): Don't call
16376 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
16377 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
16378 (DeclSpace.RecordDecl): New method.
16380 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
16382 2003-09-02 Ravi Pratap <ravi@ximian.com>
16384 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
16385 value attributes to be applied to ParameterBuilders.
16387 * class.cs (MethodCore.LabelParameters): Make static and more
16388 generic so that it can be used from other places - like interface
16389 methods, for instance.
16391 * interface.cs (Interface.Emit): Call LabelParameters before
16392 emitting attributes on the InterfaceMethod.
16394 2003-08-26 Martin Baulig <martin@ximian.com>
16396 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
16397 resolving aliases; fixes #47927.
16399 2003-08-26 Martin Baulig <martin@ximian.com>
16401 * statement.cs (Using.DoResolve): This is internally emitting a
16402 try/finally clause, so we need to set ec.NeedExplicitReturn if we
16403 do not always return. Fixes #47681.
16405 2003-08-26 Martin Baulig <martin@ximian.com>
16407 * decl.cs (MemberCore): Moved WarningNotHiding(),
16408 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
16410 (AdditionResult): Make this nested in DeclSpace.
16411 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
16412 argument; call NamespaceEntry.Define() unless we're nested in a
16415 * namespace.cs (Namespace.DefineName): New public function. This
16416 is called from DeclSpace's .ctor to add
16417 (Namespace.Lookup): Include DeclSpaces in the lookup.
16419 * class.cs (Operator): Derive from MemberBase, not MemberCore.
16421 * const.cs (Const): Derive from MemberBase, not MemberCore.
16423 2003-08-25 Martin Baulig <martin@ximian.com>
16425 * convert.cs (Convert.ExplicitReferenceConversion): When
16426 converting from an interface type to a class, unbox if the target
16427 type is a struct type. Fixes #47822.
16429 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16431 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
16434 2003-08-22 Martin Baulig <martin@ximian.com>
16436 * class.cs (TypeManager.DefineType): When defining a nested type,
16437 call DefineType() on our parent; fixes #47801.
16439 2003-08-22 Martin Baulig <martin@ximian.com>
16441 * class.cs (MethodData.Define): While checking if a method is an
16442 interface implementation, improve the test a bit more to fix #47654.
16444 2003-08-22 Martin Baulig <martin@ximian.com>
16446 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
16447 correctly; fixes #47722.
16449 2003-08-22 Martin Baulig <martin@ximian.com>
16451 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
16452 LocalVariableReference, ensure it's not read-only. Fixes #47536.
16454 * statement.cs (Fixed.DoResolve): Make all variables read-only.
16456 2003-08-22 Martin Baulig <martin@ximian.com>
16458 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
16459 can only be assigned in static constructors. Fixes #47161.
16461 2003-08-22 Martin Baulig <martin@ximian.com>
16463 Rewrote and improved the flow analysis code.
16465 * flowbranching.cs (FlowBranching): Make this class abstract.
16466 (FlowBranching.CreateBranching): New static function to create a
16467 new flow branching.
16468 (FlowBranchingBlock, FlowBranchingException): New classes.
16469 (FlowBranching.UsageVector.Type): New public readonly field.
16470 (FlowBranching.UsageVector.Breaks): Removed the setter.
16471 (FlowBranching.UsageVector.Returns): Removed the setter.
16472 (FlowBranching.UsageVector): Added Break(), Return(),
16473 NeverReachable() and Throw() methods to modify the reachability.
16474 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
16475 done by FlowBranching.Merge().
16476 (FlowBranching.UsageVector.MergeChild): New method; merges the
16477 merge result into the current vector.
16478 (FlowBranching.Merge): New abstract method to merge a branching.
16480 2003-08-12 Martin Baulig <martin@ximian.com>
16482 * expression.cs (Indirection.CacheTemporaries): Create the
16483 LocalTemporary with the pointer type, not its element type.
16485 2003-08-10 Miguel de Icaza <miguel@ximian.com>
16487 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
16488 token was a keyword or not.
16490 Add `error' options where an IDENTIFIER was expected; Provide
16491 CheckToken and CheckIdentifierToken convenience error reporting
16494 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
16496 * decl.cs: Rename `NamespaceEntry Namespace' public field into
16497 NameSpaceEntry NameSpaceEntry.
16499 (LookupInterfaceOrClass): Avoid creating a full qualified name
16500 from namespace and name: avoid doing lookups when we know the
16501 namespace is non-existant. Use new Tree.LookupByNamespace which
16502 looks up DeclSpaces based on their namespace, name pair.
16504 * driver.cs: Provide a new `parser verbose' to display the
16505 exception thrown during parsing. This is turned off by default
16506 now, so the output of a failure from mcs is more graceful.
16508 * namespace.cs: Track all the namespaces defined in a hashtable
16511 (IsNamespace): New method
16513 2003-08-09 Miguel de Icaza <miguel@ximian.com>
16515 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
16516 we know that we need to concatenate (full typename can never be
16521 * statement.cs: Use a bitfield; Do not initialize to null things
16522 which are done by the constructor by default.
16524 * cs-parser.jay: bug fix, parameter was 4, not 3.
16526 * expression.cs: Just use the property;
16528 * statement.cs: No need for GetVariableInfo method.
16530 2003-08-08 Martin Baulig <martin@ximian.com>
16532 * flowanalysis.cs (FlowReturns): This is now nested in the
16533 `FlowBranching' class.
16534 (MyBitVector): Moved this here from statement.cs.
16535 (FlowBranching.SiblingType): New enum type.
16536 (FlowBranching.CreateSibling): Added `SiblingType' argument.
16538 2003-08-07 Martin Baulig <martin@ximian.com>
16540 * flowanalysis.cs (FlowBranchingType): This is now nested in the
16541 `FlowBranching' class and called `BranchingType'.
16543 2003-08-07 Martin Baulig <martin@ximian.com>
16545 * flowanalysis.cs: Moved all the control flow analysis code into
16548 2003-08-07 Martin Baulig <martin@ximian.com>
16550 * assign.cs (Assign.DoResolve): `target' must either be an
16551 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
16554 2003-08-07 Miguel de Icaza <miguel@ximian.com>
16556 * expression.cs (BinaryMethod): This kind of expression is created by the
16557 Binary class if it determines that the operator has to be handled
16560 (BinaryDelegate): This kind of expression is created if we are
16561 dealing with a + or - operator on delegates.
16563 (Binary): remove method, argumetns, and DelegateOperator: when
16564 dealing with methods,
16566 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
16568 * statement.cs (Block): use bitfields for the three extra booleans
16569 we had in use. Remove unused topblock parameter.
16571 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
16573 * assign.cs: Drop extra unneeded tests.
16575 2003-08-06 Miguel de Icaza <miguel@ximian.com>
16577 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
16579 * statement.cs (Foreach): Use VariableStorage instead of
16582 * codegen.cs (VariableStorage): New class used by clients that
16583 require a variable stored: locals or fields for variables that
16584 need to live across yield.
16586 Maybe provide a convenience api for EmitThis+EmitLoad?
16588 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
16591 2003-08-05 Miguel de Icaza <miguel@ximian.com>
16593 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
16594 RemapParameterLValue): New methods that are used to turn a
16595 precomputed FieldInfo into an expression like this:
16599 The idea is to use this instead of making LocalVariableReference
16600 have more than one meaning.
16602 * cs-parser.jay: Add error production to BASE.
16604 * ecore.cs: Deal with TypeManager.GetField returning null, which
16605 is now a valid return value.
16607 (FieldExprNoAddress): New expression for Fields whose address can
16610 * expression.cs (LocalVariableReference): During the resolve
16611 phases, create new expressions if we are in a remapping context.
16612 Remove code that dealt with remapping here.
16614 (ParameterReference): same.
16616 (ProxyInstance): New expression, like the `This' expression, but
16617 it is born fully resolved. We know what we are doing, so remove
16618 the errors that are targeted to user-provided uses of `this'.
16620 * statement.cs (Foreach): our variable is now stored as an
16621 Expression; During resolution, follow the protocol, dont just
16622 assume it will return this.
16624 2003-08-06 Martin Baulig <martin@ximian.com>
16626 * support.cs (SeekableStreamReader.cs): New public class.
16628 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
16629 SeekableStreamReader instead of the normal StreamReader.
16631 2003-08-04 Martin Baulig <martin@ximian.com>
16633 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
16634 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
16635 deambiguate casts and delegate invocations.
16636 (parenthesized_expression): Use the new tokens to ensure this is
16637 not a cast of method invocation.
16639 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
16640 when reading a `)' and Deambiguate_CloseParens () was previously
16643 * expression.cs (ParenthesizedExpression): New class. This is
16644 just used for the CS0075 test.
16645 (Binary.DoResolve): Check for CS0075.
16647 2003-07-29 Ravi Pratap <ravi@ximian.com>
16649 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
16650 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
16651 reference comparison.
16653 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
16654 examine the ReturnType for equality - this is necessary in the
16655 cases of implicit and explicit operators whose signature also
16656 includes the return type.
16658 2003-07-26 Miguel de Icaza <miguel@ximian.com>
16660 * namespace.cs: Cache the result of the namespace computation,
16661 instead of computing it every time.
16663 2003-07-24 Miguel de Icaza <miguel@ximian.com>
16665 * decl.cs: Use a global arraylist that we reuse over invocations
16666 to avoid excesive memory consumption. Reduces memory usage on an
16667 mcs compile by one meg (45 average).
16669 * typemanager.cs (LookupTypeReflection): In .NET pointers are
16670 private, work around that.
16672 2003-07-23 Miguel de Icaza <miguel@ximian.com>
16674 * literal.cs (IntLiteral): Define Zero and One static literals.
16676 * cs-parser.jay (integer_literal): use static literals to reduce
16677 memory usage for the most used literals (0, 1 and -1). 211kb
16678 reduced in memory usage.
16680 Replace all calls to `new ArrayList' with `new
16681 ArrayList(4)' which is a good average number for most allocations,
16682 and also requires only 16 bytes of memory for its buffer by
16685 This reduced MCS memory usage in seven megabytes for the RSS after
16688 2003-07-28 Ravi Pratap <ravi@ximian.com>
16690 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
16691 handle params methods the correct way by forming only one
16692 applicable set with params and normal methods in them. Earlier we
16693 were looking at params methods only if we found no normal methods
16694 which was not the correct thing to do.
16696 (Invocation.BetterFunction): Take separate arguments indicating
16697 when candidate and the best method are params methods in their
16700 This fixes bugs #43367 and #46199.
16702 * attribute.cs: Documentation updates.
16704 (CheckAttribute): Rename to CheckAttributeTarget.
16705 (GetValidPlaces): Rename to GetValidTargets.
16707 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
16708 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
16712 2003-07-28 Martin Baulig <martin@ximian.com>
16714 * class.cs (TypeContainer.DefineMembers): Use the base type's full
16715 name when looking up the base class of a nested class. Fixes #46977.
16717 2003-07-26 Martin Baulig <martin@ximian.com>
16719 * expression.cs (Indexers.Indexer): New nested struct; contains
16720 getter, setter and the indexer's type.
16721 (Indexers.Properties): This is now an ArrayList of
16722 Indexers.Indexer's.
16723 (IndexerAccess.DoResolveLValue): Correctly set the type if the
16724 indexer doesn't have any getters.
16726 * assign.cs (Assign.DoResolve): Also do the implicit conversions
16727 for embedded property and indexer assignments.
16729 2003-07-26 Martin Baulig <martin@ximian.com>
16731 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
16732 preprocessor directive is not the first non-whitespace character
16735 2003-07-26 Martin Baulig <martin@ximian.com>
16737 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
16738 namespace parsing, follow the spec more closely.
16740 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
16741 NamespaceEntry.Lookup().
16743 2003-07-25 Martin Baulig <martin@ximian.com>
16745 * MethodCore.cs (OverridesSomething): New public field; it's set
16746 from TypeContainer.DefineMembers if this method overrides
16747 something (which doesn't need to be a method). Fix #39462.
16749 2003-07-25 Ravi Pratap <ravi@ximian.com>
16751 * typemanager.cs (GetMembers): Ensure that the list of members is
16752 reversed. This keeps things in sync.
16754 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
16755 find an AttributeUsage attribute.
16757 * expression.cs (Invocation.OverloadResolve): Perform the check
16758 which disallows Invoke to be directly called on a Delegate.
16760 (Error_InvokeOnDelegate): Report error cs1533.
16762 2003-07-25 Martin Baulig <martin@ximian.com>
16764 * expression.cs (Indexers.GetIndexersForType): Only look in the
16765 interface hierarchy if the requested type is already an
16766 interface. Fixes #46788 while keeping #46502 fixed.
16768 2003-07-25 Martin Baulig <martin@ximian.com>
16770 * class.cs (TypeContainer.DefineMembers): Check whether all
16771 readonly fields have been assigned and report warning CS0649 if
16774 * statement.cs (LocalInfo.IsFixed): Always return true if this is
16777 2003-07-24 Ravi Pratap <ravi@ximian.com>
16779 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
16780 returned from GetMethods to make things consistent with the
16781 assumptions MCS makes about ordering of methods.
16783 This should comprehensively fix bug #45127 and it does :-)
16785 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
16786 ordering is actually reverse.
16788 * Clean up some debug messages I left lying around.
16790 * interface.cs (Populate*): Get rid of code which emits attributes
16791 since the stage in which we emit attributes is the 'Emit' stage,
16792 not the define stage.
16794 (Emit): Move attribute emission for interface members here.
16796 2003-07-22 Ravi Pratap <ravi@ximian.com>
16798 * expression.cs (Invocation.OverloadResolve): Follow the spec more
16799 closely: we eliminate methods in base types when we have an
16800 applicable method in a top-level type.
16802 Please see section 14.5.5.1 for an exact description of what goes
16805 This fixes bug #45127 and a host of other related to corlib compilation.
16807 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
16808 array is the method corresponding to the top-level type (this is
16809 because of the changes made to icall.c) so we change this
16812 (MethodGroupExpr.Name): This too.
16814 * typemanager.cs (GetElementType): New method which does the right
16815 thing when compiling corlib.
16817 * everywhere: Make use of the above in the relevant places.
16819 2003-07-22 Martin Baulig <martin@ximian.com>
16821 * cs-parser.jay (invocation_expression): Moved
16822 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
16823 `cast_expression', but create a InvocationOrCast which later
16824 resolves to either an Invocation or a Cast.
16826 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
16827 method; call this before EmitStatement() to make sure that this
16828 expression can be used as a statement.
16830 * expression.cs (InvocationOrCast): New class; resolves to either
16831 an Invocation or a Cast.
16833 * statement.cs (StatementExpression): Call ResolveStatement() on
16834 the ExpressionStatement before emitting it.
16836 2003-07-21 Martin Baulig <martin@ximian.com>
16838 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
16839 `ref' and `out' attributes match; fixes #46220.
16840 (MemberAccess.ResolveMemberAccess): You can't reference a type
16841 through an expression; fixes #33180.
16842 (Indexers.GetIndexersForType): Don't return the indexers from
16843 interfaces the class implements; fixes #46502.
16845 2003-07-21 Martin Baulig <martin@ximian.com>
16847 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
16848 CS0661 checks; fixes bug #30442.
16850 2003-07-21 Martin Baulig <martin@ximian.com>
16852 * decl.cs (AdditionResult): Added `Error'.
16854 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
16856 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
16857 makes cs0031.cs actually work.
16859 2003-07-20 Martin Baulig <martin@ximian.com>
16861 * namespace.cs: Fixed that bug which caused a crash when compiling
16862 the debugger's GUI.
16864 2003-07-20 Miguel de Icaza <miguel@ximian.com>
16866 * typemanager.cs (LookupTypeReflection): Never expose types which
16867 are NotPublic, NestedPrivate, NestedAssembly, or
16868 NestedFamANDAssem. We used to return these, and later do a check
16869 that would report a meaningful error, but the problem is that we
16870 would not get the real match, if there was a name override.
16872 2003-07-18 Miguel de Icaza <miguel@ximian.com>
16874 * namespace.cs (Namespace, Name): Do not compute the namespace
16875 name dynamically, compute it in the constructor. This reduced
16876 memory usage by 1697 KB.
16878 * driver.cs: Use --pause to pause at the end.
16880 2003-07-17 Peter Williams <peter@newton.cx>
16882 * Makefile: Change the name of the test target so that it doesn't
16883 conflict with the recursive test target.
16885 2003-07-17 Miguel de Icaza <miguel@ximian.com>
16887 * expression.cs (LocalVariableReference.Emit, EmitAssign,
16888 AddressOf): Do not use EmitThis, that was wrong, use the actual
16891 2003-07-15 Miguel de Icaza <miguel@ximian.com>
16893 * class.cs (MethodData.Define): While checking if a method is an
16894 interface implementation, improve the test: If we are not public
16895 (use new test here: use the computed MethodAttributes directly,
16896 instead of the parsed modifier flags) check if the `implementing'
16897 method comes from an interface or not.
16899 * pending.cs (VerifyPendingMethods): Slightly better error
16902 * makefile: add test target that does the mcs bootstrap.
16904 2003-07-16 Ravi Pratap <ravi@ximian.com>
16906 * interface.cs (Define): Do nothing here since there are no
16907 members to populate etc. Move the attribute emission out of here
16908 since this was just totally the wrong place to put it. Attribute
16909 application happens during the 'Emit' phase, not in the 'Define'
16912 (Emit): Add this method and move the attribute emission here
16914 * rootcontext.cs (EmitCode): Call the Emit method on interface
16917 2003-07-14 Ravi Pratap M <ravi@ximian.com>
16919 * expression.cs (OverloadResolve): Report error only if Location
16920 is not 'Null' which means that there was a probe going on.
16922 2003-07-14 Martin Baulig <martin@ximian.com>
16924 * expression.cs (ConditionalLogicalOperator): New public class to
16925 implement user defined conditional logical operators.
16926 This is section 14.11.2 in the spec and bug #40505.
16928 2003-07-14 Martin Baulig <martin@ximian.com>
16930 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
16932 2003-07-14 Martin Baulig <martin@ximian.com>
16934 * codegen.cs (EmitContext.InFixedInitializer): New public field.
16936 * ecore.cs (IVariable.VerifyFixed): New interface method.
16938 * expression.cs (Unary.ResolveOperator): When resolving the `&'
16939 operator, check whether the variable is actually fixed. Fixes bug
16940 #36055. Set a variable definitely assigned when taking its
16941 address as required by the spec.
16943 * statement.cs (LocalInfo.IsFixed): New field.
16944 (LocalInfo.MakePinned): Set `IsFixed' to true.
16946 2003-07-14 Ravi Pratap M <ravi@ximian.com>
16948 * attribute.cs (Attribute.Resolve): While doing a Member lookup
16949 for .ctors, ensure that we only ask for members declared in the
16950 attribute type (BindingFlags.DeclaredOnly).
16954 * expression.cs (Error_WrongNumArguments): Report error 1501
16955 correctly the way CSC does.
16957 2003-07-13 Martin Baulig <martin@ximian.com>
16959 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
16960 lookup on the fully qualified name, to make things like "X.X" work
16961 where "X.X" is a fully qualified type name, but we also have a
16962 namespace "X" in the using list. Fixes #41975.
16964 2003-07-13 Martin Baulig <martin@ximian.com>
16966 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
16967 function. If we're a CompoundAssign, we need to create an embedded
16968 CompoundAssign, not an embedded Assign.
16969 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
16972 2003-07-13 Martin Baulig <martin@ximian.com>
16974 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
16975 work to fix bug #46088.
16977 2003-07-13 Ravi Pratap <ravi@ximian.com>
16979 * class.cs (Operator.Emit): Do not emit attributes here - it is
16980 taken care of by the Method class that we delegate too. This takes
16981 care of bug #45876.
16983 2003-07-10 Martin Baulig <martin@ximian.com>
16985 * expression.cs (TypeOfVoid): New class.
16986 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
16988 2003-07-10 Martin Baulig <martin@ximian.com>
16990 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
16993 2003-07-10 Martin Baulig <martin@ximian.com>
16995 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
16996 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
16998 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
17000 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
17002 2003-07-10 Martin Baulig <martin@ximian.com>
17004 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
17005 of decimal. Fixes #42850.
17007 NOTE: I also fixed the created byte blob, but this doesn't work on
17008 the MS runtime and csc never produces any byte blobs for decimal
17011 2003-07-10 Martin Baulig <martin@ximian.com>
17013 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
17014 structs; fixes #32068.
17015 (Block.AddChildVariableNames): Fixed #44302.
17017 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17019 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
17021 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17023 * attribute.cs: And this test is onger needed.
17025 2003-07-08 Martin Baulig <martin@ximian.com>
17027 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
17028 inaccessible types. Fixes #36313.
17030 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
17032 * namespace.cs (NamespaceEntry): Create implicit entries for all
17033 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
17034 implicit entries for N1.N2 and N1.
17036 2003-07-08 Martin Baulig <martin@ximian.com>
17038 Rewrote the handling of namespaces to fix a lot of the issues
17039 wrt. `using' aliases etc.
17041 * namespace.cs (Namespace): Splitted this class into a
17042 per-assembly `Namespace' and a per-file `NamespaceEntry'.
17044 * typemanager.cs (TypeManager.IsNamespace): Removed.
17045 (TypeManager.ComputeNamespaces): Only compute namespaces from
17046 loaded assemblies here, not the namespaces from the assembly we're
17047 currently compiling.
17049 2003-07-08 Martin Baulig <martin@ximian.com>
17051 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
17053 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17055 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
17058 I thought about the memory savings here, but LookupTypeReflection
17059 is used under already very constrained scenarios. Compiling
17060 corlib or mcs only exposes one hit, so it would not really reduce
17061 any memory consumption.
17063 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17065 * typemanager.cs: fixes bug #45889 by only adding public types from
17066 other assemblies to the list of known types.
17068 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17070 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
17071 on the type we resolved.
17073 2003-07-05 Martin Baulig <martin@ximian.com>
17075 * pending.cs (PendingImplementation.ParentImplements): Don't
17076 create the proxy if the parent is abstract.
17078 * class.cs (TypeContainer.DefineIndexers): Process explicit
17079 interface implementations first. Fixes #37714.
17081 2003-07-04 Miguel de Icaza <miguel@ximian.com>
17083 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
17084 defined recursively; but since we modify the input parameters
17085 (left is set to `this' temporarily), we reset this value if the
17086 left_is_explicit is false, which gives the original semantics to
17089 * literal.cs (NullPointer): new class used to represent a null
17090 literal in a pointer context.
17092 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
17093 type is a pointer, use a NullPointer object instead of a
17094 NullLiteral. Closes 43687
17096 (ExplicitConversion): Convert pointer values using
17097 the conv opcode to the proper type.
17099 * ecore.cs (New): change ValueTypeVariable property into a method,
17100 that returns whether the valuetype is suitable for being used.
17102 * expression.cs (Binary.DoNumericPromotions): Only return if we
17103 the int constant was a valid uint, and we can return both left and
17104 right as uints. If not, we continue processing, to trigger the
17105 type conversion. This fixes 39018.
17107 * statement.cs (Block.EmitMeta): During constant resolution, set
17108 the CurrentBlock property on the emitcontext, so that we resolve
17109 constants propertly.
17111 2003-07-02 Martin Baulig <martin@ximian.com>
17113 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
17114 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
17116 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
17117 than emitting it here.
17119 * statement.cs: Fixed some more flow analysis bugs.
17121 2003-07-02 Martin Baulig <martin@ximian.com>
17123 * class.cs (MethodData.Define): When implementing interface
17124 methods, set Final unless we're Virtual.
17126 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
17127 check work for interface methods.
17129 2003-07-01 Martin Baulig <martin@ximian.com>
17131 * ecore.cs (EmitContext.This): Replaced this property with a
17132 GetThis() method which takes a Location argument. This ensures
17133 that we get the correct error location for a CS0188.
17135 2003-07-01 Miguel de Icaza <miguel@ximian.com>
17137 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
17138 ImplicitStandardConversion.
17140 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
17142 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
17144 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
17147 2003-06-30 Miguel de Icaza <miguel@ximian.com>
17149 * class.cs (Constructor.Define): Turn off initlocals for unsafe
17152 (MethodData.Define): Turn off initlocals for unsafe methods.
17154 2003-06-29 Miguel de Icaza <miguel@ximian.com>
17156 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
17157 complete; Fixes #37521.
17159 * delegate.cs: Use Modifiers.TypeAttr to compute the
17160 TypeAttributes, instead of rolling our own. This makes the flags
17161 correct for the delegates.
17163 2003-06-28 Miguel de Icaza <miguel@ximian.com>
17165 * class.cs (Constructor.Define): Set the private flag for static
17166 constructors as well.
17168 * cs-parser.jay (statement_expression): Set the return value to
17169 null, to avoid a crash when we catch an error.
17171 2003-06-24 Miguel de Icaza <miguel@ximian.com>
17173 * cs-parser.jay: Applied patch from Jackson that adds support for
17174 extern and unsafe modifiers to destructor declarations.
17176 * expression.cs: Report error 21 if the user is trying to index a
17179 * driver.cs: Add an error message, suggested by the bug report.
17181 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
17182 if we do not have a ": this ()" constructor initializer. Fixes 45149
17184 2003-06-14 Miguel de Icaza <miguel@ximian.com>
17186 * namespace.cs: Add some information to reduce FAQs.
17188 2003-06-13 Miguel de Icaza <miguel@ximian.com>
17190 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
17191 underlying enumeration types. Fixes #43915.
17193 * expression.cs: Treat ushort/short as legal values to be used in
17194 bitwise operations.
17196 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
17198 * delegate.cs: transfer custom attributes for paramenters from
17199 the delegate declaration to Invoke and BeginInvoke.
17201 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
17203 * attribute.cs: handle custom marshalers and emit marshal info
17206 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
17208 * makefile.gnu: Added anonymous.cs to the compiler sources.
17210 2003-05-28 Miguel de Icaza <miguel@ximian.com>
17212 * iterators.cs: Change the name of the proxy class to include two
17215 * cs-parser.jay: Update grammar to include anonymous methods.
17217 * anonymous.cs: new file.
17219 2003-05-27 Miguel de Icaza <miguel@ximian.com>
17221 * class.cs (Field.Define): Add missing test for pointers and
17224 2003-05-27 Ravi Pratap <ravi@ximian.com>
17226 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
17227 we use the stobj opcode.
17229 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
17230 since it wasn't the correct fix.
17232 It still is puzzling that we are required to use stobj for IntPtr
17233 which seems to be a ValueType.
17235 2003-05-26 Miguel de Icaza <miguel@ximian.com>
17237 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
17238 during regular simple name resolution. Now, the trick is that
17239 instead of returning for processing the simplename, we do a
17240 TypeManager.LookupType (ie, a rooted lookup as opposed to a
17241 contextual lookup type). If a match is found, return that, if
17242 not, return for further composition.
17244 This fixes long-standing 30485.
17246 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
17247 using the address to initialize an object, do an Stobj instead of
17248 using the regular Stelem.
17250 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
17251 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
17252 Because if we are a BaseIndexerAccess that value will be true.
17255 * statement.cs (GotoCase.Resolve): Return after reporting an
17256 error, do not attempt to continue.
17258 * expression.cs (PointerArithmetic.Emit): If our operand is a
17259 long, convert our constants to match the operand before
17260 multiplying. Convert to I type before adding. Fixes 43670.
17262 2003-05-14 Ravi Pratap <ravi@ximian.com>
17264 * enum.cs (ImplicitConversionExists) : Rename to
17265 ImplicitEnumConversionExists to remove ambiguity.
17267 * ecore.cs (NullCast): New type of cast expression class which
17268 basically is very similar to EmptyCast with the difference being
17269 it still is a constant since it is used only to cast a null to
17271 (eg. (string) null)
17273 * convert.cs (ImplicitReferenceConversion): When casting a null
17274 literal, we return a NullCast.
17276 * literal.cs (NullLiteralTyped): Remove - I don't see why this
17277 should be around anymore.
17279 The renaming (reported was slightly wrong). Corrections:
17281 ConvertImplicitStandard -> ImplicitConversionStandard
17282 ConvertExplicitStandard -> ExplicitConversionStandard
17284 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
17285 before passing them in !
17287 * convert.cs (ImplicitConversionStandard): When comparing for
17288 equal expr and target types, ensure that expr is not a
17291 In general, we must not be checking (expr_type ==
17292 target_type) in the top level conversion methods
17293 (ImplicitConversion, ExplicitConversion etc). This checking is
17294 done in the methods that they delegate to.
17296 2003-05-20 Miguel de Icaza <miguel@ximian.com>
17298 * convert.cs: Move Error_CannotConvertType,
17299 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
17300 ImplicitNumericConversion, ImplicitConversionExists,
17301 ImplicitUserConversionExists, StandardConversionExists,
17302 FindMostEncompassedType, FindMostSpecificSource,
17303 FindMostSpecificTarget, ImplicitUserConversion,
17304 ExplicitUserConversion, GetConversionOperators,
17305 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
17306 TryImplicitIntConversion, Error_CannotConvertImplicit,
17307 ConvertImplicitRequired, ConvertNumericExplicit,
17308 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
17309 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
17312 Perform the following renames:
17314 StandardConversionExists -> ImplicitStandardConversionExists
17315 ConvertImplicit -> ImplicitConversion
17316 ConvertImplicitStandard -> ImplicitStandardConversion
17317 TryImplicitIntConversion -> ImplicitIntConversion
17318 ConvertImplicitRequired -> ImplicitConversionRequired
17319 ConvertNumericExplicit -> ExplicitNumericConversion
17320 ConvertReferenceExplicit -> ExplicitReferenceConversion
17321 ConvertExplicit -> ExplicitConversion
17322 ConvertExplicitStandard -> ExplicitStandardConversion
17324 2003-05-19 Martin Baulig <martin@ximian.com>
17326 * statement.cs (TypeInfo.StructInfo): Made this type protected.
17327 (TypeInfo): Added support for structs having structs as fields.
17329 * ecore.cs (FieldExpr): Implement IVariable.
17330 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
17331 VariableInfo for the field.
17333 2003-05-18 Martin Baulig <martin@ximian.com>
17335 * expression.cs (This.DoResolve): Report a CS0027 if we're
17336 emitting a field initializer.
17338 2003-05-18 Martin Baulig <martin@ximian.com>
17340 * expression.cs (This.ResolveBase): New public function.
17341 (This.DoResolve): Check for CS0188.
17343 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
17346 * ecore.cs (MethodGroupExpr.DoResolve): Set the
17347 `instance_expression' to null if we don't have any non-static
17350 2003-05-18 Martin Baulig <martin@ximian.com>
17352 Reworked the way how local variables and parameters are handled by
17353 the flow analysis code.
17355 * statement.cs (TypeInfo, VariableMap): New public classes.
17356 (VariableInfo): New public class. This is now responsible for
17357 checking whether a variable has been assigned. It is used for
17358 parameters and local variables.
17359 (Block.EmitMeta): Take the InternalParameters as argument; compute
17360 the layout of the flow vectors here.
17361 (Block.LocalMap, Block.ParameterMap): New public properties.
17362 (FlowBranching): The .ctor doesn't get the InternalParameters
17363 anymore since Block.EmitMeta() now computes the layout of the flow
17365 (MyStructInfo): This class is now known as `StructInfo' and nested
17366 in `TypeInfo'; we don't access this directly anymore.
17368 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
17369 property and removed IsAssigned(), IsFieldAssigned(),
17370 SetAssigned() and SetFieldAssigned(); we now call them on the
17371 VariableInfo so we don't need to duplicate this code everywhere.
17373 * expression.cs (ParameterReference): Added `Block block' argument
17375 (LocalVariableReference, ParameterReference, This): The new
17376 VariableInfo class is now responsible for all the definite
17379 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
17380 IsParameterAssigned, SetParameterAssigned): Removed.
17382 2003-05-18 Martin Baulig <martin@ximian.com>
17384 * typemanager.cs (InitCoreTypes): Try calling
17385 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
17386 the 3-args-version. Corlib now also needs our `void_type'.
17387 (GetMethod): Added overloaded version which takes an optional
17388 `bool report_errors' to allow lookups of optional methods.
17390 2003-05-12 Martin Baulig <martin@ximian.com>
17392 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
17393 only used for locals and not for parameters.
17395 2003-05-12 Miguel de Icaza <miguel@ximian.com>
17397 * support.cs (InternalParameters.ParameterType): Return the
17398 ExternalType of the parameter.
17400 * parameter.cs (Parameter.ExternalType): drop the two arguments,
17403 2003-05-11 Miguel de Icaza <miguel@ximian.com>
17405 * class.cs (MethodData.Define): Do not set the `newslot' on
17406 interface members, if they are also flagged as "override".
17408 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
17409 better code for ++i and i++. This only works for static fields
17410 and local variables.
17412 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
17413 want to pull the DeclSpace out of the builder_to_declspace instead
17414 of the TypeBuilder (like in TypeContainer.FindMembers).
17416 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
17417 instead of LookupTypeContainer. Fixes the crash on .NET for
17418 looking up interface members.
17420 * const.cs: Create our own emit context during the Definition
17421 stage, so that constants are evaluated in the proper context, when
17422 a recursive definition happens.
17424 2003-05-11 Martin Baulig <martin@ximian.com>
17426 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
17427 new block for a switch section.
17428 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
17429 the adding/lookup in the switch block. Fixes #39828.
17431 2003-05-09 Miguel de Icaza <miguel@ximian.com>
17433 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
17434 functionality: I needed to convert the data after I had performed
17435 the add/sub operation into the operands type size.
17437 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
17438 pass the type for the box operation, otherwise the resulting
17439 object would have been of type object.
17441 (BoxedCast): Add constructor to specify the type to box as.
17443 2003-05-07 Miguel de Icaza <miguel@ximian.com>
17445 * iterators.cs: I was reusing the `count' variable inadvertently,
17446 take steps to not allow this to happen.
17448 2003-05-06 Miguel de Icaza <miguel@ximian.com>
17450 * attribute.cs (Attribute.Resolve): Params attributes are encoded
17451 by creating an array at the point where the params starts and
17452 putting all those arguments there, then adjusting the size of the
17455 2003-05-05 Miguel de Icaza <miguel@ximian.com>
17457 * expression.cs (New.AddressOf): Implement interface
17458 IMemoryLocation. This is used when the `new' operator is used in
17459 the context of an invocation to a method on a value type.
17461 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
17464 * namespace.cs: Also check the using aliases here.
17466 * driver.cs: Move the test for using validity after the types have
17467 been entered, so we do a single pass that also includes the using
17470 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
17471 in the regular case. CreateSiblingForFinally is doing extra
17474 * attribute.cs (GetAttributeArgumentExpression): Store the result
17475 on an out value, and use the return value to indicate failure
17476 instead of using null (which is a valid return for Constant.GetValue).
17478 * statement.cs: Perform the analysis flow for the increment
17479 portion after the statement, because this will be the real flow of
17480 execution. Fixes #42385
17482 * codegen.cs (EmitContext.EmitArgument,
17483 EmitContext.EmitStoreArgument): New helper functions when the
17484 RemapToProxy flag is set.
17486 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
17489 Add support for remapping parameters.
17491 * iterators.cs: Propagate parameter values; Store parameter
17492 values in the proxy classes.
17494 2003-05-04 Miguel de Icaza <miguel@ximian.com>
17496 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
17497 need a proxy reference; I do not know what I was thinking
17499 * cs-parser.jay (constructor_initializer): catch another error,
17500 and display nice message.
17502 (field_declaration): catch void field declaration
17503 to flag a better error.
17505 * class.cs (MemberBase.CheckBase): Report an error instead of a
17506 warning if a new protected member is declared in a struct.
17507 (Field.Define): catch the error of readonly/volatile.
17509 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
17511 (FieldExpr.AddressOf): ditto. Catch error where the address of a
17512 volatile variable is taken
17514 2003-05-02 Miguel de Icaza <miguel@ximian.com>
17516 * statement.cs (Fixed.Resolve): Report an error if we are not in
17519 2003-05-01 Miguel de Icaza <miguel@ximian.com>
17521 * typemanager.cs: reuse the code that handles type clashes for
17522 delegates and enumerations.
17524 * class.cs (Report28): Always report.
17526 * expression.cs (EncodeAsAttribute): Allow nulls here.
17528 2003-04-28 Miguel de Icaza <miguel@ximian.com>
17530 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
17531 the functionality for testing whether an expression is valid for
17532 an attribute here. Also handle the case of arrays of elements
17535 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
17536 encoding a linear array into an array of objects that are suitable
17537 to be passed to an CustomAttributeBuilder.
17539 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
17541 * ecore.cs: (FieldExpr): Handle field remapping here.
17543 * iteratators.cs: Pass the instance variable (if the method is an
17544 instance method) to the constructors, so we can access the field
17545 variables on the class.
17547 TODO: Test this with structs. I think the THIS variable on
17548 structs might have to be a pointer, and not a refenrece
17550 2003-04-27 Miguel de Icaza <miguel@ximian.com>
17552 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
17553 local variables to fields in a proxy class.
17555 * iterators.cs (PopulateProxy): Rename our internal fields to
17557 Create a <THIS> field if we are an instance method, so we can
17558 reference our parent container variables.
17559 (MapVariable): Called back from the EmitContext code to enter a
17560 new variable to field mapping into the proxy class (we just create
17564 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
17565 for using the remapped locals to fields.
17567 I placed the code here, because that gives the same semantics to
17568 local variables, and only changes the Emit code.
17570 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
17571 statements inside iterators.
17572 (VariableInfo): Add a FieldBuilder for the cases when we are
17573 remapping local variables to fields in a proxy class
17575 * ecore.cs (SimpleNameResolve): Avoid testing two times for
17576 current_block != null.
17578 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
17579 not cope with strings, as it has been moved to the
17580 TableSwitchEmit. Fixed bug in switch generation.
17582 * expression.cs (New.DoResolve): Provide more context for the user
17583 when reporting an error.
17585 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
17588 * expression.cs (MemberAccess.DoResolve): When we get a type back,
17589 check the permissions for it. Note than in a type-resolution
17590 context the check was already present in DeclSpace.ResolveType,
17591 but was missing from the MemberAccess.
17593 (ArrayCreation.CheckIndices): warn if the user has
17594 more nested levels of expressions, but there are no more
17595 dimensions specified. Avoids crash on bug 41906.
17597 2003-04-26 Miguel de Icaza <miguel@ximian.com>
17599 * statement.cs (Block): replace Implicit bool, for a generic
17601 New flag: `Unchecked'. This is used during the EmitMeta phase
17602 (which is out-of-line with the regular Resolve/Emit process for a
17603 statement, as this is done ahead of time, but still gets a chance
17604 to call constant resolve).
17606 (Block.Flags): new enum for adding a new flag.
17608 (Block.EmitMeta): track the state of unchecked.
17610 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
17611 to enable constant resolution to work there as well.
17613 2003-04-22 Miguel de Icaza <miguel@ximian.com>
17615 * typemanager.cs (ienumerable_type): Also look up
17616 System.Collections.IEnumerable.
17618 2003-04-21 Miguel de Icaza <miguel@ximian.com>
17620 TODO: Test more than one conditional per method.
17622 * class.cs (Indexer.Define): Report the location where the user is
17623 referencing the unsupported feature.
17625 (MethodData): Overload the use of `conditionals' to
17626 minimize the creation of needless ArrayLists. This saves roughly
17627 212kb on my machine.
17629 (Method): Implement the new IIteratorContainer interface.
17630 (Method.SetYields): Implement the method by setting the ModFlags
17631 to contain METHOD_YIELDS.
17633 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
17634 which just got set to null.
17636 * iterators.cs: New file.
17638 (Yield, YieldBreak): New statements.
17640 * statement.cs (Return.Resolve): Flag an error if we are used in
17641 an iterator method.
17643 * codegen.cs (InIterator): New flag set if the code is being
17644 compiled in an iterator method.
17646 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
17647 internal modifier, and we just use it to avoid adding extra
17648 fields, as this is seldom used.
17650 * cs-parser.jay: Add yield_statement (yield and yield break).
17652 * driver.cs: New flag -v2 to turn on version 2 features.
17654 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
17655 hashtable when v2 is enabled.
17657 2003-04-20 Miguel de Icaza <miguel@ximian.com>
17659 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
17660 there is already a namespace defined with this name.
17662 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
17663 people upgraded their corlibs.
17665 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
17666 always use fully qualified types, no need to use the compiler
17669 (TypeManager.IsNamespace): Use binarysearch.
17671 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
17672 AddDelegate): I did not quite use the new IsValid API properly: I
17673 have to pass the short-name and the fullname. I was passing only
17674 the basename instead of the fullname sometimes.
17676 (TypeContainer.DefineType): call NamespaceClash.
17678 * interface.cs (Interface.DefineType): use NamespaceClash before
17681 * delegate.cs (Delegate.DefineType): use NamespaceClash before
17684 * enum.cs: (Enum.DefineType): use NamespaceClash before
17687 * typemanager.cs (: 3-line patch that gives us some tasty 11%
17688 speed increase. First, use the negative_hits cache when we get a
17689 negative. Second, add the type with its full original name
17690 instead of the new . and + encoded name (reflection uses + to
17691 separate type from a nested type). Use LookupTypeReflection
17692 directly which bypasses the type->name hashtable (that we already
17693 know does not contain the type.
17695 * decl.cs (DeclSpace.ResolveTypeExpr): track the
17696 location/container type.
17698 * driver.cs: When passing utf8, use directly the UTF8Encoding.
17700 2003-04-19 Miguel de Icaza <miguel@ximian.com>
17702 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
17704 * delegate.cs (NewDelegate.Resolve): Test whether an instance
17705 method is being referenced in the method group from a static
17706 context, and report error 120 if so.
17708 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
17711 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
17712 is created, we create the A namespace).
17714 * cs-parser.jay: A namespace also introduces a DeclarationFound.
17717 2003-04-18 Miguel de Icaza <miguel@ximian.com>
17719 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
17720 invocation to ModuleBuilder.GetType with the same values will
17721 return a new type instance, so we need to cache its return
17724 * expression.cs (Binary.ResolveOperator): Only allow the compare
17725 operators on enums if they are of the same type.
17727 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
17728 types of ValueType on their own case. Before we were giving them
17729 the same treatment as objects.
17731 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
17732 fullname. Short name is used to compare against container name.
17733 Fullname is used to check against defined namespace names.
17735 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
17736 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
17738 (Method.CheckBase): Call parent.
17739 (MemberBase.CheckBase): Check for protected members on sealed
17741 (PropertyBase.CheckBase): Call parent.
17742 (Field.Define): Call parent.
17744 * report.cs: Negative error codes are now mapped to 8000 - code,
17745 so that the display is render more nicely.
17747 * typemanager.cs: Do not use try/catch, instead report a regular
17750 (GetPointerType, GetReferenceType): These methods provide
17751 mechanisms to obtain the T* and T& from a T. We had the code
17752 previously scattered around the code base, and it also used
17753 TypeManager.LookupType that would go through plenty of caches.
17754 This one goes directly to the type source.
17756 In some places we did the Type.GetType followed by
17757 ModuleBuilder.GetType, but not in others, so this unifies the
17758 processing as well.
17760 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
17761 statements now that we have namespace information.
17763 * typemanager.cs (IsNamespace): New method, returns whether the
17764 string presented is a namespace or not.
17766 (ComputeNamespaces): New public entry point, computes the list of
17767 available namespaces, using the GetNamespaces API call in Mono, or
17768 the slower version in MS.NET.
17770 Now before we start the semantic analysis phase, we have a
17771 complete list of namespaces including everything that the user has
17774 Deleted old code to cache namespaces in .nsc files.
17776 2003-04-17 Miguel de Icaza <miguel@ximian.com>
17778 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
17779 class/struct location definition Location for the implicit
17780 constructor location.
17782 (Operator.Define): Use the location of the operator for the
17783 implicit Method definition.
17785 (Constructor.Emit): use the constructor location for the implicit
17786 base initializer constructor.
17788 * ecore.cs: Remove ITypeExpression. This interface is now gone,
17789 and the Expression class now contains two new methods:
17791 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
17792 isolate type lookup from the rest of the resolution process.
17794 Since we use Expressions to hold type definitions due to the way
17795 we parse the input we have historically overloaded Resolve to
17796 perform the Type lookups if a special flag is passed. Now this is
17797 eliminated and two methods take their place.
17799 The differences in the two methods between xStep and xTerminal is
17800 that xStep is involved in our current lookup system that uses
17801 SimpleNames to compose a name, while xTerminal is used just to
17802 catch the case where the simplename lookup failed.
17804 2003-04-16 Miguel de Icaza <miguel@ximian.com>
17806 * expression.cs (ResolveMemberAccess): Remove redundant code.
17807 TypeExpr expressions are always born fully resolved.
17809 * interface.cs (PopulateMethod): Do not lookup the types twice.
17810 We were doing it once during SemanticAnalysis and once during
17813 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
17814 in local variable type definitions, were being returned as a
17815 SimpleName (we decomposed everything into a string), that is
17816 because primary_expression was being used instead of a type in the
17817 grammar (reduce/reduce conflicts).
17819 The part that was wrong is that we converted the expression into a
17820 string (an oversimplification in one hand, compounded with primary
17821 expressions doing string concatenation).
17827 Would return "A.B.C[]" as a SimpleName. This stopped things like
17828 using clauses from working on this particular context. And a type
17829 was being matched directly against "A.B.C[]".
17831 We now use the correct approach, and allow for ComposedCast to be
17832 part of the unary expression. So the "A.B.C []" become a composed
17833 cast of "A.B.C" (as a nested group of MemberAccess with a
17834 SimpleName at the end) plus the rank composition "[]".
17838 2003-04-10 Miguel de Icaza <miguel@ximian.com>
17840 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
17841 for the access level checking.
17843 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
17844 `TypeContainer container', because I kept getting confused when I
17845 was debugging this code.
17847 * expression.cs (Indexers): Instead of tracking getters/setters,
17848 we now track them in parallel. We create one arraylist less, but
17849 most importantly it is possible now for the LValue code to find a
17850 matching get for a set.
17852 (IndexerAccess.DoResolveLValue): Update the code.
17853 GetIndexersForType has been modified already to extract all the
17854 indexers from a type. The code assumed it did not.
17856 Also make the code set the correct return type for the indexer.
17857 This was fixed a long time ago for properties, but was missing for
17858 indexers. It used to be void_type.
17860 (Binary.Emit): Test first for doubles instead of
17861 floats, as they are more common.
17863 (Binary.EmitBranchable): Use the .un version of the branch opcodes
17864 when dealing with floats and the <=, >= operators. This fixes bug
17867 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
17868 to load the array value by emitting a load on the foreach variable
17869 type. This was incorrect.
17871 We now emit the code to load an element using the the array
17872 variable type, and then we emit the conversion operator.
17876 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
17878 * attribute.cs: Avoid allocation of ArrayLists in the common case.
17880 2003-04-09 Miguel de Icaza <miguel@ximian.com>
17882 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
17883 test for protection before we test for signatures.
17885 (MethodSignature.ToString): implement.
17887 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
17888 to the case where we reduced into a LongConstant.
17890 * decl.cs (CheckAccessLevel): If the type is an array, we can not
17891 depend on whether the information is acurrate, because the
17892 Microsoft runtime will always claim that the array type is public,
17893 regardless of the real state.
17895 If the type is a pointer, another problem happens: the type is
17896 reported as non-public in Microsoft.
17898 In both cases we have to call CheckAccessLevel recursively with
17899 the underlying type as the argument to be tested.
17901 2003-04-08 Miguel de Icaza <miguel@ximian.com>
17903 * assign.cs (Assign.Emit): If we are dealing with a compound
17904 assignment expression, we should use the code path that stores the
17905 intermediate result in a temporary value. This fixes #40903.
17907 *expression.cs (Indirection.ToString): Provide ToString method for
17910 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
17912 * class.cs: Null out fields holding references to Block objects so
17913 they can be garbage collected.
17915 * expression.cs (OverloadResolve): Remove unused local.
17917 2003-04-07 Martin Baulig <martin@ximian.com>
17919 * codegen.cs (EmitContext.CurrentFile): New public field.
17920 (EmitContext.Mark): Use the CurrentFile to check whether the
17921 location is in the correct file.
17922 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
17924 2003-04-07 Martin Baulig <martin@ximian.com>
17926 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
17928 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
17929 location. [FIXME: The location argument which gets passed to this
17930 method is sometimes wrong!]
17932 2003-04-07 Nick Drochak <ndrochak@gol.com>
17934 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
17936 2003-04-07 Miguel de Icaza <miguel@ximian.com>
17938 * expression.cs (Indirection.EmitAssign): We were using the
17939 temporary, but returning immediately instead of continuing the
17942 2003-04-06 Martin Baulig <martin@ximian.com>
17944 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
17945 if it's a nested child, but also deriving from the outer class.
17948 * typemanager.cs (IsNestedChildOf): Make this work if it's a
17949 nested child, but also deriving from the outer class. See
17951 (FilterWithClosure): We may access private members of the outer
17952 class if we're a nested child and deriving from the outer class.
17953 (RealMemberLookup): Only set `closure_private_ok' if the
17954 `original_bf' contained BindingFlags.NonPublic.
17956 2003-04-05 Martin Baulig <martin@ximian.com>
17958 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
17960 2003-04-02 Miguel de Icaza <miguel@ximian.com>
17962 * class.cs (Event.Define): Do not allow abstract events to have
17965 2003-04-01 Miguel de Icaza <miguel@ximian.com>
17967 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
17968 block in event declarations.
17970 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
17971 value type, get its address.
17973 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
17974 leaving a class on the stack instead of a boolean value (int
17975 0/1). Change the code so we compare against null, and then the
17976 result against zero.
17978 * class.cs (TypeContainer.GetClassBases): We were checking for the
17979 parent class being sealed too late.
17981 * expression.cs (Binary.Emit): For <= and >= when dealing with
17982 floating point values, use cgt.un and clt.un instead of cgt and
17985 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
17987 * statement.cs: Apply the same optimization as MS: skip the
17988 GetEnumerator returning an IEnumerator, and use the one returning a
17989 CharEnumerator instead. This allows us to avoid the try-finally block
17992 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
17994 * cs-parser.jay: Attributes cannot be applied to
17995 namespaces. Fixes #40473
17997 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18000 (Add*): check if the name is valid using the full name for constants,
18001 fields, properties and events.
18003 2003-03-28 Miguel de Icaza <miguel@ximian.com>
18005 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
18006 char constants to be part of the enumeration.
18008 * expression.cs (Conditional.DoResolve): Add support for operator
18009 true. Implements the missing functionality from 14.12
18011 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
18012 operator true/false as required by the spec.
18014 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
18015 implicit conversion to boolean.
18017 * statement.cs (Statement.ResolveBoolean): A boolean expression is
18018 also one where the type implements `operator true'.
18020 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
18021 get an expression that will invoke operator true based on an
18024 (GetConversionOperators): Removed the hack that called op_True
18027 (Expression.ResolveBoolean): Move this from Statement.
18029 2003-03-17 Miguel de Icaza <miguel@ximian.com>
18031 * ecore.cs (FieldExpr): do not allow initialization of initonly
18032 fields on derived classes
18034 2003-03-13 Martin Baulig <martin@ximian.com>
18036 * statement.cs (Block.Emit): Call ig.BeginScope() and
18037 ig.EndScope() when compiling with debugging info; call
18038 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
18040 2003-03-08 Miguel de Icaza <miguel@ximian.com>
18042 * expression.cs (Indexers): Do not construct immediately, allow
18043 for new members to be appended as we go. Fixes 38143
18045 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18047 * expression.cs: save/restore context when resolving an unchecked
18050 2003-03-05 Miguel de Icaza <miguel@ximian.com>
18052 * cfold.cs: Catch division by zero in modulus operator during
18055 2003-03-03 Miguel de Icaza <miguel@ximian.com>
18057 * interface.cs (Interface.DefineMembers): Avoid defining members
18060 2003-02-27 Miguel de Icaza <miguel@ximian.com>
18062 * driver.cs: handle the +/- options for -noconfig
18064 * statement.cs (Unckeched.Resolve): Also track the state of
18065 unchecked in the Resolve phase.
18067 2003-02-27 Martin Baulig <martin@ximian.com>
18069 * ecore.cs (Expression.MemberLookup): Don't create a
18070 MethodGroupExpr for something which is not a method. Fixes #38291.
18072 2003-02-25 Miguel de Icaza <miguel@ximian.com>
18074 * class.cs (MemberBase.CheckParameters): Also check that the type
18075 is unmanaged if it is a pointer.
18077 * expression.cs (SizeOf.Resolve): Add location information.
18079 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
18080 a managed type is declared.
18082 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
18083 parameter modifiers as well. Fixes bug 38606
18085 * class.cs: Very sad. Am backing out the speed up changes
18086 introduced by the ArrayList -> Array in the TypeContainer, as they
18087 were not actually that much faster, and introduced a bug (no error
18088 reports on duplicated methods).
18090 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
18091 source first, this will guarantee that we have a valid expression
18092 before calling in lower levels functions that will require a
18093 resolved object. Then use this original_source in the
18094 target.ResolveLValue instead of the original source that was
18097 Another change. Use target.Resolve instead of LValueResolve.
18098 Although we are resolving for LValues, we will let the Assign code
18099 take care of that (it will be called again from Resolve). This
18100 basically allows code like this:
18102 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
18103 class Y { void A (X x) { x [0] += o; }
18105 The problem was that the indexer was trying to resolve for
18106 set_Item (idx, object o) and never finding one. The real set_Item
18107 was set_Item (idx, X). By delaying the process we get the right
18112 2003-02-23 Martin Baulig <martin@ximian.com>
18114 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
18115 while calling DoEmit ().
18117 * codegen.cs (EmitContext.Mark): Don't mark locations in other
18118 source files; if you use the #line directive inside a method, the
18119 compiler stops emitting line numbers for the debugger until it
18120 reaches the end of the method or another #line directive which
18121 restores the original file.
18123 2003-02-23 Martin Baulig <martin@ximian.com>
18125 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
18127 2003-02-23 Martin Baulig <martin@ximian.com>
18129 * statement.cs (Block.AddChildVariableNames): We need to call this
18130 recursively, not just for our immediate children.
18132 2003-02-23 Martin Baulig <martin@ximian.com>
18134 * class.cs (Event.Define): Always make the field private, like csc does.
18136 * typemanager.cs (TypeManager.RealMemberLookup): Make events
18137 actually work, fixes bug #37521.
18139 2003-02-23 Miguel de Icaza <miguel@ximian.com>
18141 * delegate.cs: When creating the various temporary "Parameters"
18142 classes, make sure that we call the ComputeAndDefineParameterTypes
18143 on those new parameters (just like we do with the formal ones), to
18144 allow them to be resolved in the context of the DeclSpace.
18146 This fixes the bug that Dick observed in Bugzilla #38530.
18148 2003-02-22 Miguel de Icaza <miguel@ximian.com>
18150 * expression.cs (ResolveMemberAccess): When resolving a constant,
18151 do not attempt to pull a constant if the value was not able to
18152 generate a valid constant.
18154 * const.cs (LookupConstantValue): Do not report more errors than required.
18156 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18158 * expression.cs: fixes bug #38328.
18160 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18162 * class.cs: Changed all the various members that can be part of a
18163 class from being an ArrayList to be an Array of the right type.
18164 During the DefineType type_list, interface_list, delegate_list and
18165 enum_list are turned into types, interfaces, delegates and enums
18168 And during the member population, indexer_list, event_list,
18169 constant_list, field_list, instance_constructor_list, method_list,
18170 operator_list and property_list are turned into their real arrays.
18172 Although we could probably perform this operation earlier, for
18173 good error reporting we need to keep the lists and remove the
18174 lists for longer than required.
18176 This optimization was triggered by Paolo profiling the compiler
18177 speed on the output of `gen-sample-program.pl' perl script.
18179 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
18180 not crash in methods like MemberLookupFailed that use this field.
18182 This problem arises when the compiler fails to resolve a type
18183 during interface type definition for example.
18185 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18187 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
18188 inherit from System.Object, so we have to stop at null, not only
18189 when reaching System.Object.
18191 2003-02-17 Miguel de Icaza <miguel@ximian.com>
18193 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
18194 DeclaredOnly because the parent indexer might have had a different
18195 name, but did not loop until the top of the hierarchy was reached.
18197 The problem this one fixes is 35492: when a class implemented an
18198 indexer from an interface, we were getting the interface method
18199 (which was abstract) and we were flagging an error (can not invoke
18202 This also keeps bug 33089 functioning, and test-148 functioning.
18204 * typemanager.cs (IsSpecialMethod): The correct way of figuring
18205 out if a method is special is to see if it is declared in a
18206 property or event, or whether it is one of the predefined operator
18207 names. This should fix correctly #36804.
18209 2003-02-15 Miguel de Icaza <miguel@ximian.com>
18211 The goal here is to remove the dependency on EmptyCast.Peel ().
18212 Killing it completely.
18214 The problem is that currently in a number of places where
18215 constants are expected, we have to "probe" for an EmptyCast, and
18216 Peel, which is not the correct thing to do, as this will be
18217 repetitive and will likely lead to errors.
18219 The idea is to remove any EmptyCasts that are used in casts that
18220 can be reduced to constants, so we only have to cope with
18223 This bug hunt was triggered by Bug 37363 and the desire to remove
18224 the duplicate pattern where we were "peeling" emptycasts to check
18225 whether they were constants. Now constants will always be
18228 * ecore.cs: Use an enumconstant here instead of wrapping with
18231 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
18232 throwing me off. By handling this we can get rid of a few hacks.
18234 * statement.cs (Switch): Removed Peel() code.
18236 2003-02-14 Miguel de Icaza <miguel@ximian.com>
18238 * class.cs: Location information for error 508
18240 * expression.cs (New.DoResolve): Add a guard against double
18241 resolution of an expression.
18243 The New DoResolve might be called twice when initializing field
18244 expressions (see EmitFieldInitializers, the call to
18245 GetInitializerExpression will perform a resolve on the expression,
18246 and later the assign will trigger another resolution
18248 This leads to bugs (#37014)
18250 * delegate.cs: The signature for EndInvoke should contain any ref
18251 or out parameters as well. We were not doing this in the past.
18253 * class.cs (Field.Define): Do not overwrite the type definition
18254 inside the `volatile' group. Turns out that volatile enumerations
18255 were changing the type here to perform a validity test, which
18258 2003-02-12 Miguel de Icaza <miguel@ximian.com>
18260 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
18261 and structs, we do not want to load the instance variable
18263 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
18264 enum_type has to be handled like an object reference (implicit
18265 conversions exists from this to object), but the regular IsClass
18266 and IsValueType tests will never return true for this one.
18268 Also we use TypeManager.IsValueType instead of type.IsValueType,
18269 just for consistency with the rest of the code (this is only
18270 needed if we ever use the construct exposed by test-180.cs inside
18271 corlib, which we dont today).
18273 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
18275 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
18278 2003-02-09 Martin Baulig <martin@ximian.com>
18280 * namespace.cs (Namespace..ctor): Added SourceFile argument.
18281 (Namespace.DefineNamespaces): New static public method; this is
18282 called when we're compiling with debugging to add all namespaces
18283 to the symbol file.
18285 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
18286 pass it to the Namespace's .ctor.
18288 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
18289 and MethodBase arguments; pass the namespace ID to the symwriter;
18290 pass the MethodBase instead of the token to the symwriter.
18291 (SymbolWriter.DefineNamespace): New method to add a namespace to
18294 2003-02-09 Martin Baulig <martin@ximian.com>
18296 * symbolwriter.cs: New file. This is a wrapper around
18297 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
18298 methods here in near future.
18300 2003-02-09 Martin Baulig <martin@ximian.com>
18302 * codegen.cs (EmitContext.Mark): Just pass the arguments to
18303 ILGenerator.MarkSequencePoint() which are actually used by the
18306 2003-02-09 Martin Baulig <martin@ximian.com>
18308 * location.cs (SourceFile): New public sealed class. This
18309 contains the name and an index which is used in the location's token.
18310 (Location): Reserve an appropriate number of bits in the token for
18311 the source file instead of walking over that list, this gives us a
18312 really huge performance improvement when compiling with debugging.
18314 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
18315 `SourceFile' argument instead of a string.
18316 (Driver.ProcessFile): Add all the files via Location.AddFile(),
18317 but don't parse/tokenize here, we need to generate the list of all
18318 source files before we do that.
18319 (Driver.ProcessFiles): New static function. Parses/tokenizes all
18322 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
18323 instead of a string.
18325 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
18328 2003-02-09 Martin Baulig <martin@ximian.com>
18330 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
18331 filename on `#line default'.
18333 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
18335 * statement.cs: don't clear the pinned var when the fixed statement
18336 returns from the method (fixes bug#37752).
18338 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
18340 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
18343 2003-02-07 Martin Baulig <martin@ximian.com>
18345 * driver.cs: Removed the `--debug-args' command line argument.
18347 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
18348 automatically by the AsssemblyBuilder.
18349 (CodeGen.InitializeSymbolWriter): We don't need to call any
18350 initialization function on the symbol writer anymore. This method
18351 doesn't take any arguments.
18353 2003-02-03 Miguel de Icaza <miguel@ximian.com>
18355 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
18356 from referenced assemblies as well.
18358 2003-02-02 Martin Baulig <martin@ximian.com>
18360 * class.cs (MethodData.Emit): Generate debugging info for external methods.
18362 2003-02-02 Martin Baulig <martin@ximian.com>
18364 * class.cs (Constructor.Emit): Open the symbol writer before
18365 emitting the constructor initializer.
18366 (ConstructorInitializer.Emit): Call ec.Mark() to allow
18367 single-stepping through constructor initializers.
18369 2003-01-30 Miguel de Icaza <miguel@ximian.com>
18371 * class.cs: Handle error 549: do not allow virtual methods in
18374 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
18376 * decl.cs: Check access levels when resolving types
18378 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
18380 * statement.cs: Add parameters and locals set in catch blocks that might
18381 return to set vector
18383 2003-01-29 Miguel de Icaza <miguel@ximian.com>
18385 * class.cs (Operator): Set the SpecialName flags for operators.
18387 * expression.cs (Invocation.DoResolve): Only block calls to
18388 accessors and operators on SpecialName methods.
18390 (Cast.TryReduce): Handle conversions from char constants.
18393 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
18395 * statement.cs: small memory and time optimization in FlowBranching.
18397 2003-01-28 Pedro Mart <yoros@wanadoo.es>
18399 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
18400 problem that the last fix but in the other sid (Set).
18402 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
18403 access when there is no indexer in the hierarchy.
18405 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
18407 * class.cs: Combine some if statements.
18409 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18411 * driver.cs: fixed bug #37187.
18413 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
18415 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
18416 any indexer, it's needed to build a list with all the indexers in the
18417 hierarchy (AllGetters), else we have problems. Fixes #35653.
18419 2003-01-23 Miguel de Icaza <miguel@ximian.com>
18421 * class.cs (MethodData.Define): It is wrong for an interface
18422 implementation to be static in both cases: explicit and implicit.
18423 We were only handling this in one case.
18425 Improve the if situation there to not have negations.
18427 * class.cs (Field.Define): Turns out that we do not need to check
18428 the unsafe bit on field definition, only on usage. Remove the test.
18430 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18432 * driver.cs: use assembly.Location instead of Codebase (the latest
18433 patch made mcs fail when using MS assemblies).
18435 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
18437 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
18438 get the path to *corlib.dll.
18440 2003-01-21 Nick Drochak <ndrochak@gol.com>
18444 * typemanager.cs: Remove compiler warnings
18446 2003-01-20 Duncan Mak <duncan@ximian.com>
18448 * AssemblyInfo.cs: Bump the version number to 0.19.
18450 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18452 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
18454 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
18456 * class.cs (Constructor::Emit): Emit debugging info for constructors.
18458 2003-01-17 Miguel de Icaza <miguel@ximian.com>
18460 * cs-parser.jay: Small fix: we were not comparing the constructor
18461 name correctly. Thanks to Zoltan for the initial pointer.
18463 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
18465 * cs-tokenizer.cs: Set file name when specified with #line
18467 2003-01-15 Miguel de Icaza <miguel@ximian.com>
18469 * cs-parser.jay: Only perform the constructor checks here if we
18470 are named like the class; This will help provider a better
18471 error. The constructor path is taken when a type definition is
18472 not found, but most likely the user forgot to add the type, so
18473 report that rather than the constructor error.
18475 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
18477 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
18480 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18482 * cs-parser.jay: Add cleanup call.
18484 2003-01-13 Duncan Mak <duncan@ximian.com>
18486 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
18487 consistent with other methods.
18489 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18491 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
18493 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
18495 * attribute.cs: only set GuidAttr to true when we have a
18498 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18502 * typemanager.cs: fixes to allow mcs compile corlib with the new
18503 Type.IsSubclassOf fix.
18505 2003-01-08 Miguel de Icaza <miguel@ximian.com>
18507 * expression.cs (LocalVariableReference.DoResolve): Classify a
18508 constant as a value, not as a variable. Also, set the type for
18511 * cs-parser.jay (fixed_statement): take a type instead of a
18512 pointer_type, so we can produce a better error message later.
18514 * statement.cs (Fixed.Resolve): Flag types that are not pointers
18517 (For.DoEmit): Make inifinite loops have a
18518 non-conditional branch back.
18520 (Fixed.DoEmit): First populate the pinned variables, then emit the
18521 statement, then clear the variables. Before I was emitting the
18522 code once for each fixed piece.
18525 2003-01-08 Martin Baulig <martin@ximian.com>
18527 * statement.cs (FlowBranching.MergeChild): A break in a
18528 SWITCH_SECTION does not leave a loop. Fixes #36155.
18530 2003-01-08 Martin Baulig <martin@ximian.com>
18532 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
18533 lives in the same number space than `param_map'. Fixes #36154.
18535 2003-01-07 Miguel de Icaza <miguel@ximian.com>
18537 * cs-parser.jay (constructor_declaration): Set the
18538 Constructor.ModFlags before probing for it. This makes the
18539 compiler report 514, 515 and 132 (the code was there, but got
18542 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
18543 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
18544 (GotoCase.Resolve): Set `Returns' to ALWAYS.
18546 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
18548 * enum.cs: create the enum static fields using the enum type.
18550 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
18552 * class.cs: don't try to create the ParamBuilder for the return
18553 type if it's not needed (and handle it breaking for the ms runtime
18556 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
18558 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
18560 2002-12-29 Miguel de Icaza <miguel@ximian.com>
18562 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
18563 the command. This showed up while compiling the JANET source
18564 code, which used \r as its only newline separator.
18566 2002-12-28 Miguel de Icaza <miguel@ximian.com>
18568 * class.cs (Method.Define): If we are an operator (because it
18569 reuses our code), then set the SpecialName and HideBySig. #36128
18571 2002-12-22 Miguel de Icaza <miguel@ximian.com>
18573 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
18574 exception, report error 120 `object reference required'.
18576 * driver.cs: Add --pause option, used during to measure the size
18577 of the process as it goes with --timestamp.
18579 * expression.cs (Invocation.DoResolve): Do not allow methods with
18580 SpecialName to be invoked.
18582 2002-12-21 Miguel de Icaza <miguel@ximian.com>
18584 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
18585 number before adding it.
18587 2002-12-21 Ravi Pratap <ravi@ximian.com>
18589 * ecore.cs (StandardImplicitConversion): When in an unsafe
18590 context, we allow conversion between void * to any other pointer
18591 type. This fixes bug #35973.
18593 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
18595 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
18596 is not thrown when extensionless outputs are used
18598 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18600 * rootcontext.cs: fixed compilation of corlib.
18602 2002-12-19 Miguel de Icaza <miguel@ximian.com>
18604 * attribute.cs (Attributes.Contains): Add new method.
18606 * class.cs (MethodCore.LabelParameters): if the parameter is an
18607 `out' parameter, check that no attribute `[In]' has been passed.
18609 * enum.cs: Handle the `value__' name in an enumeration.
18611 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
18613 * decl.cs: Added special case to allow overrides on "protected
18616 2002-12-18 Ravi Pratap <ravi@ximian.com>
18618 * attribute.cs (Attributes.AddAttributeSection): Rename to this
18619 since it makes much more sense.
18621 (Attributes.ctor): Don't require a Location parameter.
18623 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
18625 * attribute.cs (ApplyAttributes): Remove extra Location parameters
18626 since we already have that information per attribute.
18628 * everywhere : make appropriate changes.
18630 * class.cs (LabelParameters): Write the code which actually
18631 applies attributes to the return type. We can't do this on the MS
18632 .NET runtime so we flag a warning in the case an exception is
18635 2002-12-18 Miguel de Icaza <miguel@ximian.com>
18637 * const.cs: Handle implicit null conversions here too.
18639 2002-12-17 Ravi Pratap <ravi@ximian.com>
18641 * class.cs (MethodCore.LabelParameters): Remove the extra
18642 Type [] parameter since it is completely unnecessary. Instead
18643 pass in the method's attributes so that we can extract
18644 the "return" attribute.
18646 2002-12-17 Miguel de Icaza <miguel@ximian.com>
18648 * cs-parser.jay (parse): Use Report.Error to flag errors instead
18649 of ignoring it and letting the compile continue.
18651 * typemanager.cs (ChangeType): use an extra argument to return an
18652 error condition instead of throwing an exception.
18654 2002-12-15 Miguel de Icaza <miguel@ximian.com>
18656 * expression.cs (Unary.TryReduce): mimic the code for the regular
18657 code path. Perform an implicit cast in the cases where we can
18658 implicitly convert to one of the integral types, and then reduce
18659 based on that constant. This fixes bug #35483.
18661 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18663 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
18665 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18667 * namespace.cs: fixed bug #35489.
18669 2002-12-12 Miguel de Icaza <miguel@ximian.com>
18671 * class.cs: Remove some dead code.
18673 * cs-parser.jay: Estimate the number of methods needed
18674 (RootContext.MethodCount);
18676 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
18677 numbers instead of StringBuilders.
18679 * support.cs (PtrHashtable): Add constructor with initial size;
18680 We can now reduce reallocations of the method table.
18682 2002-12-10 Ravi Pratap <ravi@ximian.com>
18684 * attribute.cs (ApplyAttributes): Keep track of the emitted
18685 attributes on a per-target basis. This fixes bug #35413.
18687 2002-12-10 Miguel de Icaza <miguel@ximian.com>
18689 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
18690 default to the Windows 1252 encoding.
18692 (UnixParseOption): Support version, thanks to Alp for the missing
18695 * AssemblyInfo.cs: Add nice assembly information.
18697 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
18700 * cs-parser.jay: Allow a trailing comma before the close bracked
18701 in the attribute_section production.
18703 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
18704 address of the instance was being taken, I will take this out,
18705 because we take the address of the object immediately here.
18707 2002-12-09 Ravi Pratap <ravi@ximian.com>
18709 * typemanager.cs (AreMultipleAllowed): Take care of the most
18710 obvious case where attribute type is not in the current assembly -
18713 2002-12-08 Miguel de Icaza <miguel@ximian.com>
18715 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
18716 definitions, instead of doing that afterwards.
18718 Also we use a nice little hack, depending on the constructor, we
18719 know if we are a "composed" name or a simple name. Hence, we
18720 avoid the IndexOf test, and we avoid
18722 * codegen.cs: Add code to assist in a bug reporter to track down
18723 the source of a compiler crash.
18725 2002-12-07 Ravi Pratap <ravi@ximian.com>
18727 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
18728 types have been emitted for a given element and flag an error
18729 if something which does not have AllowMultiple set is used more
18732 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
18733 attribute types and their corresponding AllowMultiple properties
18735 (AreMultipleAllowed): Check the property for a given type.
18737 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
18738 property in the case we have a TypeContainer.
18740 (Attributes.AddAttribute): Detect duplicates and just skip on
18741 adding them. This trivial fix catches a pretty gross error in our
18742 attribute emission - global attributes were being emitted twice!
18744 Bugzilla bug #33187 is now fixed.
18746 2002-12-06 Miguel de Icaza <miguel@ximian.com>
18748 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
18749 instead of pp_and).
18751 * expression.cs (Binary.ResolveOperator): I can only use the
18752 Concat (string, string, string) and Concat (string, string,
18753 string, string) if the child is actually a concatenation of
18756 2002-12-04 Miguel de Icaza <miguel@ximian.com>
18758 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
18759 context where we need a 2-character lookahead.
18761 * pending.cs (PendingImplementation): Rework so we can keep track
18762 of interface types all the time, and flag those which were
18763 implemented by parents as optional.
18765 2002-12-03 Miguel de Icaza <miguel@ximian.com>
18767 * expression.cs (Binary.ResolveOperator): Use
18768 String.Concat(string,string,string) or
18769 String.Concat(string,string,string,string) when possible.
18771 * typemanager: More helper methods.
18774 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
18776 * pending.cs: remove the bogus return from GetMissingInterfaces()
18777 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
18779 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18781 * namespace.cs: avoid duplicated 'using xxx' being added to
18782 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
18783 when we get more than one 'using' statement for the same namespace.
18784 Report a CS0105 warning for it.
18786 2002-11-30 Miguel de Icaza <miguel@ximian.com>
18788 * cs-tokenizer.cs (consume_identifier): use read directly, instead
18789 of calling getChar/putback, uses internal knowledge of it.
18791 (xtoken): Reorder tokenizer so most common patterns are checked
18792 first. This reduces the compilation time in another 5% (from 8.11s
18793 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
18795 The parsing time is 22% of the compilation in mcs, and from that
18796 64% is spent on the tokenization process.
18798 I tried using a binary search for keywords, but this is slower
18799 than the hashtable. Another option would be to do a couple of
18802 * Not use a StringBuilder, instead use an array of chars,
18803 with a set value. Notice that this way we could catch
18804 the 645 error without having to do it *afterwards*.
18806 * We could write a hand-parser to avoid the hashtable
18807 compares altogether.
18809 The identifier consumption process takes 37% of the tokenization
18810 time. Another 15% is spent on is_number. 56% of the time spent
18811 on is_number is spent on Int64.Parse:
18813 * We could probably choose based on the string length to
18814 use Int32.Parse or Int64.Parse and avoid all the 64-bit
18817 Another 3% is spend on wrapping `xtoken' in the `token' function.
18819 Handle 0xa0 as whitespace (#34752)
18821 2002-11-26 Miguel de Icaza <miguel@ximian.com>
18823 * typemanager.cs (IsCLRType): New routine to tell whether a type
18824 is one of the builtin types.
18826 Maybe it needs to use TypeCodes to be faster. Maybe we could use
18827 typecode in more places instead of doing pointer comparissions.
18828 We could leverage some knowledge about the way the typecodes are
18831 New code to cache namespaces in assemblies, it is currently not
18832 invoked, to be used soon.
18834 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
18836 * expression.cs (Binary.ResolveOperator): specially handle
18837 strings, and do not perform user-defined operator overloading for
18840 2002-11-24 Miguel de Icaza <miguel@ximian.com>
18842 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
18843 internalcall as it is a pretty simple operation; Avoid whenever
18844 possible to call Char.IsLetter.
18846 (consume_identifier): Cut by half the number of
18847 hashtable calls by merging the is_keyword and GetKeyword behavior.
18849 Do not short-circuit, because if we do, we
18850 report errors (ie, #if false && true would produce an invalid
18854 2002-11-24 Martin Baulig <martin@ximian.com>
18856 * expression.cs (Cast.TryReduce): If we're in checked syntax,
18857 check constant ranges and report a CS0221. Fixes #33186.
18859 2002-11-24 Martin Baulig <martin@ximian.com>
18861 * cs-parser.jay: Make this work for uninitialized variable
18862 declarations in the `for' initializer. Fixes #32416.
18864 2002-11-24 Martin Baulig <martin@ximian.com>
18866 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
18867 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
18869 2002-11-24 Martin Baulig <martin@ximian.com>
18871 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
18872 argument; if true, we also check for user-defined conversions.
18873 This is only needed if both arguments are of a user-defined type.
18874 Fixes #30443, added test-175.cs.
18875 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
18877 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
18879 2002-11-24 Martin Baulig <martin@ximian.com>
18881 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
18882 function to get the store opcode.
18883 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
18884 only emit the Ldelema if the store opcode is Stobj. You must run
18885 both test-34 and test-167 to test this. Fixes #34529.
18887 2002-11-23 Martin Baulig <martin@ximian.com>
18889 * ecore.cs (Expression.MemberLookup): Added additional
18890 `qualifier_type' argument which is used when we're being called
18891 from MemberAccess.DoResolve() and null if we're called from a
18893 (Expression.MemberLookupFailed): New method to report errors; this
18894 does the CS1540 check and reports the correct error message.
18896 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
18897 argument for the CS1540 check and redone the way how we're dealing
18898 with private members. See the comment in the source code for details.
18899 (FilterWithClosure): Reverted this back to revision 1.197; renamed
18900 `closure_start_type' to `closure_qualifier_type' and check whether
18901 it's not null. It was not this filter being broken, it was just
18902 being called with the wrong arguments.
18904 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
18905 and pass it the correct `qualifier_type'; this also does the error
18908 2002-11-22 Miguel de Icaza <miguel@ximian.com>
18910 * expression.cs (Invocation.EmitParams): If the we are dealing
18911 with a non-built-in value type, load its address as well.
18913 (ArrayCreation): Use a a pretty constant instead
18914 of the hardcoded value 2. Use 6 instead of 2 for the number of
18915 static initializers.
18917 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
18918 because they are not really value types, just glorified integers.
18920 * driver.cs: Do not append .exe, the CSC compiler does not do it.
18922 * ecore.cs: Remove redundant code for enumerations, make them use
18923 the same code path as everything else, fixes the casting issue
18924 with enumerations in Windows.Forms.
18926 * attribute.cs: Do only cast to string if it is a string, the
18927 validation happens later.
18929 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
18930 people upgrade their corlibs.
18932 * ecore.cs: Oops, enumerations were not following the entire code path
18934 2002-11-21 Miguel de Icaza <miguel@ximian.com>
18936 * typemanager.cs (FilterWithClosure): Commented out the test for
18937 1540 in typemanager.cs, as it has problems when accessing
18938 protected methods from a parent class (see test-174.cs).
18940 * attribute.cs (Attribute.ValidateGuid): new method.
18941 (Attribute.Resolve): Use above.
18943 2002-11-19 Miguel de Icaza <miguel@ximian.com>
18945 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
18947 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
18948 handling for enumerations, as we only needed the TypeContainer
18949 functionality to begin with (this is required for the fix below to
18950 work for enums that reference constants in a container class for
18953 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
18955 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
18956 a valid TypeBuilder to perform lookups on.o
18958 * class.cs (InheritableMemberSignatureCompare): Use true in the
18959 call to GetGetMethod and GetSetMethod, because we are comparing
18960 the signature, and we need to get the methods *even* if they are
18963 (PropertyBase.CheckBase): ditto.
18965 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
18966 GotoCase.Resolve): Use Peel on EmpytCasts.
18968 * ecore.cs (EmptyCast): drop child, add Peel method.
18970 2002-11-17 Martin Baulig <martin@ximian.com>
18972 * ecore.cs (EmptyCast.Child): New public property.
18974 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
18975 label resolved to an EmptyCast. Fixes #34162.
18976 (GotoCase.Resolve): Likewise.
18977 (Block.EmitMeta): Likewise.
18979 2002-11-17 Martin Baulig <martin@ximian.com>
18981 * expression.cs (Invocation.BetterConversion): Prefer int over
18982 uint; short over ushort; long over ulong for integer literals.
18983 Use ImplicitConversionExists instead of StandardConversionExists
18984 since we also need to check for user-defined implicit conversions.
18985 Fixes #34165. Added test-173.cs.
18987 2002-11-16 Martin Baulig <martin@ximian.com>
18989 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
18990 with the `true' and `false' literals. Fixes #33151.
18992 2002-11-16 Martin Baulig <martin@ximian.com>
18994 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
18995 October 22nd; don't do the cs1540 check for static members.
18997 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
18998 now using our own filter here and doing the cs1540 check again.
19000 2002-11-16 Martin Baulig <martin@ximian.com>
19002 * support.cs (InternalParameters): Don't crash if we don't have
19003 any fixed parameters. Fixes #33532.
19005 2002-11-16 Martin Baulig <martin@ximian.com>
19007 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
19008 when looking up static methods to make this work on Windows.
19011 2002-11-16 Martin Baulig <martin@ximian.com>
19013 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
19014 a setter rather than using PropertyInfo.CanWrite.
19016 2002-11-15 Nick Drochak <ndrochak@gol.com>
19018 * class.cs: Allow acces to block member by subclasses. Fixes build
19021 2002-11-14 Martin Baulig <martin@ximian.com>
19023 * class.cs (Constructor.Emit): Added the extern/block check.
19026 2002-11-14 Martin Baulig <martin@ximian.com>
19028 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
19029 iteration while looking for indexers, this is needed because the
19030 indexer may have a different name in our base classes. Fixed the
19031 error reporting (no indexers at all, not get accessor, no
19032 overloaded match). Fixes bug #33089.
19033 (IndexerAccess.DoResolveLValue): Likewise.
19035 2002-11-14 Martin Baulig <martin@ximian.com>
19037 * class.cs (PropertyBase.CheckBase): Make this work for multiple
19038 indexers. Fixes the first part of bug #33089.
19039 (MethodSignature.InheritableMemberSignatureCompare): Added support
19042 2002-11-13 Ravi Pratap <ravi@ximian.com>
19044 * attribute.cs (Attribute.Resolve): Catch the
19045 NullReferenceException and report it since it isn't supposed to
19048 2002-11-12 Miguel de Icaza <miguel@ximian.com>
19050 * expression.cs (Binary.EmitBranchable): Also handle the cases for
19051 LogicalOr and LogicalAnd that can benefit from recursively
19052 handling EmitBranchable. The code now should be nice for Paolo.
19054 2002-11-08 Miguel de Icaza <miguel@ximian.com>
19056 * typemanager.cs (LookupType): Added a negative-hit hashtable for
19057 the Type lookups, as we perform quite a number of lookups on
19058 non-Types. This can be removed once we can deterministically tell
19059 whether we have a type or a namespace in advance.
19061 But this might require special hacks from our corlib.
19065 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
19066 and double which avoids a conversion from an integer to a double.
19068 * expression.cs: tiny optimization, avoid calling IsConstant,
19069 because it effectively performs the lookup twice.
19071 2002-11-06 Miguel de Icaza <miguel@ximian.com>
19073 But a bogus return here to keep the semantics of the old code
19074 until the Mono runtime is fixed.
19076 * pending.cs (GetMissingInterfaces): New method used to remove all
19077 the interfaces that are already implemented by our parent
19078 classes from the list of pending methods.
19080 * interface.cs: Add checks for calls after ResolveTypeExpr.
19082 2002-11-05 Miguel de Icaza <miguel@ximian.com>
19084 * class.cs (Class.Emit): Report warning 67: event not used if the
19085 warning level is beyond 3.
19087 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
19088 being a NullLiteral.
19090 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
19093 * class.cs (TypeContainer.GetClassBases): Cover a missing code
19094 path that might fail if a type can not be resolved.
19096 * expression.cs (Binary.Emit): Emit unsigned versions of the
19099 * driver.cs: use error 5.
19101 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
19103 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
19105 2002-11-01 Miguel de Icaza <miguel@ximian.com>
19107 * cs-parser.jay (switch_section): A beautiful patch from Martin
19108 Baulig that fixed 33094.
19110 2002-10-31 Miguel de Icaza <miguel@ximian.com>
19112 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
19113 Check whether the base is abstract and report an error if so.
19115 * expression.cs (IndexerAccess.DoResolveLValue,
19116 IndexerAccess.DoResolve): ditto.
19118 (Invocation.DoResolve): ditto.
19120 (Invocation.FullMethodDesc): Improve the report string.
19122 * statement.cs (Block): Eliminate IsVariableDefined as it is
19123 basically just a wrapper for GetVariableInfo.
19125 * ecore.cs (SimpleName): Use new
19127 * support.cs (ReflectionParamter.ParameterType): We unwrap the
19128 type, as we return the actual parameter ref/unref state on a
19131 2002-10-30 Miguel de Icaza <miguel@ximian.com>
19133 * support.cs: Return proper flags REF/OUT fixing the previous
19136 * expression.cs: Reverted last patch, that was wrong. Is_ref is
19137 not used to mean `ref' but `ref or out' in ParameterReference
19139 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
19140 full type signature instead of calling TypeManger.CSharpName
19143 * support.cs (InternalParameters.ParameterDesc): Do not compare
19144 directly to the modflags, because REF/OUT will actually be bitsets
19147 * delegate.cs (VerifyMethod): Check also the modifiers.
19149 * cs-tokenizer.cs: Fix bug where floating point values with an
19150 exponent where a sign was missing was ignored.
19152 * driver.cs: Allow multiple assemblies to be specified in a single
19155 2002-10-28 Miguel de Icaza <miguel@ximian.com>
19157 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
19158 because identifiers after a parenthesis would end up in this kind
19159 of production, and we needed to desamiguate it for having casts
19162 (UserDefinedType *) xxx
19164 2002-10-24 Miguel de Icaza <miguel@ximian.com>
19166 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
19167 we should set on the Bindingflags.NonPublic, but not turn on
19168 private_ok. private_ok controls whether a Private member is
19169 returned (this is chekced on the filter routine), while the
19170 BindingFlags.NonPublic just controls whether private/protected
19171 will be allowed. This fixes the problem part of the problem of
19172 private properties being allowed to be used in derived classes.
19174 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
19175 so we can call the children DoResolveLValue method (this will
19176 properly signal errors on lvalue assignments to base properties)
19178 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
19179 getter are null, and we have a property info, we know that this
19180 happened because the lookup failed, so we report an error 122 for
19181 protection level violation.
19183 We also silently return if setter and getter are null in the
19184 resolve functions, this condition only happens if we have flagged
19185 the error before. This is the other half of the problem.
19187 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
19188 not have accessibility information, that is why we were returning
19189 true in the filter function in typemanager.cs.
19191 To properly report 122 (property is inaccessible because of its
19192 protection level) correctly, we report this error in ResolveAccess
19193 by failing if both the setter and the getter are lacking (ie, the
19196 DoResolve and DoLResolve have been modified to check for both
19197 setter/getter being null and returning silently, the reason being
19198 that I did not want to put the knowledge about this error in upper
19201 int old = Report.Errors;
19202 x = new PropertyExpr (...);
19203 if (old != Report.Errors)
19208 So the property expr is returned, but it is invalid, so the error
19209 will be flagged during the resolve process.
19211 * class.cs: Remove InheritablePropertySignatureCompare from the
19212 class, as we no longer depend on the property signature to compute
19213 whether it is possible to implement a method or not.
19215 The reason is that calling PropertyInfo.GetGetMethod will return
19216 null (in .NET, in Mono it works, and we should change this), in
19217 cases where the Get Method does not exist in that particular
19222 class X { public virtual int A { get { return 1; } } }
19224 class Z : Y { public override int A { get { return 2; } } }
19226 Would fail in Z because the parent (Y) would not have the property
19227 defined. So we avoid this completely now (because the alternative
19228 fix was ugly and slow), and we now depend exclusively on the
19231 (PropertyBase.CheckBase): Use a method-base mechanism to find our
19232 reference method, instead of using the property.
19234 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
19235 routines are gone now.
19237 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
19238 names, they were incorrectly named.
19240 * cs-tokenizer.cs: Return are more gentle token on failure.
19242 * pending.cs (PendingImplementation.InterfaceMethod): This routine
19243 had an out-of-sync index variable, which caused it to remove from
19244 the list of pending methods the wrong method sometimes.
19246 2002-10-22 Miguel de Icaza <miguel@ximian.com>
19248 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
19249 CanWrite, because those refer to this particular instance of the
19250 property, and do not take into account the fact that we can
19251 override single members of a property.
19253 Constructor requires an EmitContext. The resolution process does
19254 not happen here, but we need to compute the accessors before,
19255 because the resolution does not always happen for properties.
19257 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
19258 subclass, before we did not update this flag, but we did update
19261 (GetAccessors): Drop this routine, as it did not work in the
19262 presence of partially overwritten set/get methods.
19264 Notice that this broke the cs1540 detection, but that will require
19267 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19271 * driver.cs: issue a warning instead of an error if we don't support
19272 debugging for the platform. Also ignore a couple of errors that may
19273 arise when trying to write the symbols. Undo my previous patch.
19275 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19277 * driver.cs: ignore /debug switch except for Unix platforms.
19279 2002-10-23 Nick Drochak <ndrochak@gol.com>
19281 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
19283 2002-10-21 Miguel de Icaza <miguel@ximian.com>
19285 * driver.cs: Do not make mcs-debug conditional, so we do not break
19286 builds that use it.
19288 * statement.cs (UsageVector.MergeChildren): I would like Martin to
19289 review this patch. But basically after all the children variables
19290 have been merged, the value of "Breaks" was not being set to
19291 new_breaks for Switch blocks. I think that it should be set after
19292 it has executed. Currently I set this to the value of new_breaks,
19293 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
19294 conservative, but I do not understand this code very well.
19296 I did not break anything in the build, so that is good ;-)
19298 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
19300 2002-10-20 Mark Crichton <crichton@gimp.org>
19302 * cfold.cs: Fixed compile blocker. Really fixed it this time.
19304 2002-10-20 Nick Drochak <ndrochak@gol.com>
19306 * cfold.cs: Fixed compile blocker.
19308 2002-10-20 Miguel de Icaza <miguel@ximian.com>
19310 * driver.cs: I was chekcing the key, not the file.
19312 2002-10-19 Ravi Pratap <ravi@ximian.com>
19314 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
19315 message that we were generating - we just need to silently return
19318 2002-10-19 Miguel de Icaza <miguel@ximian.com>
19320 * class.cs (Event.Define): Change my previous commit, as this
19321 breaks the debugger. This is a temporary hack, as it seems like
19322 the compiler is generating events incorrectly to begin with.
19324 * expression.cs (Binary.ResolveOperator): Added support for
19325 "U operator - (E x, E y)"
19327 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
19330 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
19331 init-only variables, but this path did not take into account that
19332 there might be also instance readonly variables. Correct this
19335 This fixes bug 32253
19337 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
19340 * driver.cs: Change the extension for modules to `netmodule'
19342 * cs-parser.jay: Improved slightly the location tracking for
19343 the debugger symbols.
19345 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
19346 modifiers that were specified instead of the hardcoded value
19347 (FamAndAssem). This was basically ignoring the static modifier,
19348 and others. Fixes 32429.
19350 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
19351 fixed a bug in the process (32476)
19353 * expression.cs (ArrayAccess.EmitAssign): Patch from
19354 hwang_rob@yahoo.ca that fixes bug 31834.3
19356 2002-10-18 Miguel de Icaza <miguel@ximian.com>
19358 * driver.cs: Make the module extension .netmodule.
19360 2002-10-16 Miguel de Icaza <miguel@ximian.com>
19362 * driver.cs: Report an error if the resource file is not found
19363 instead of crashing.
19365 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
19366 false, like Emit does.
19368 2002-10-16 Nick Drochak <ndrochak@gol.com>
19370 * typemanager.cs: Remove unused private member. Also reported mcs
19371 bug to report this as a warning like csc.
19373 2002-10-15 Martin Baulig <martin@gnome.org>
19375 * statement.cs (Statement.Emit): Made this a virtual method; emits
19376 the line number info and calls DoEmit().
19377 (Statement.DoEmit): New protected abstract method, formerly knows
19378 as Statement.Emit().
19380 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
19382 2002-10-11 Miguel de Icaza <miguel@ximian.com>
19384 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
19385 have fixed a remaining problem: not every AddXXXX was adding a
19386 fully qualified name.
19388 Now everyone registers a fully qualified name in the DeclSpace as
19389 being defined instead of the partial name.
19391 Downsides: we are slower than we need to be due to the excess
19392 copies and the names being registered this way.
19394 The reason for this is that we currently depend (on the corlib
19395 bootstrap for instance) that types are fully qualified, because
19396 we dump all the types in the namespace, and we should really have
19397 types inserted into the proper namespace, so we can only store the
19398 basenames in the defined_names array.
19400 2002-10-10 Martin Baulig <martin@gnome.org>
19402 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
19403 from bug #31834, see the bug report for a testcase which is
19406 2002-10-10 Martin Baulig <martin@gnome.org>
19408 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
19409 flow analysis code for this.
19411 * statement.cs (Do, While, For): Tell the flow analysis code about
19413 (FlowBranching.UsageVector): Added support for infinite loops.
19414 (Block.Resolve): Moved the dead code elimination here and use flow
19417 2002-10-09 Miguel de Icaza <miguel@ximian.com>
19419 * class.cs (Field.Define): Catch cycles on struct type
19422 * typemanager.cs (IsUnmanagedtype): Do not recursively check
19423 fields if the fields are static. We only need to check instance
19426 * expression.cs (As.DoResolve): Test for reference type.
19428 * statement.cs (Using.ResolveExpression): Use
19429 ConvertImplicitRequired, not ConvertImplicit which reports an
19431 (Using.ResolveLocalVariableDecls): ditto.
19433 * expression.cs (Binary.ResolveOperator): Report errors in a few
19434 places where we had to.
19436 * typemanager.cs (IsUnmanagedtype): Finish implementation.
19438 2002-10-08 Miguel de Icaza <miguel@ximian.com>
19440 * expression.cs: Use StoreFromPtr instead of extracting the type
19441 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
19443 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
19444 an enumeration value to a System.Enum, but System.Enum is not a
19445 value type, but an class type, so we need to box.
19447 (Expression.ConvertExplicit): One codepath could return
19448 errors but not flag them. Fix this. Fixes #31853
19450 * parameter.cs (Resolve): Do not allow void as a parameter type.
19452 2002-10-06 Martin Baulig <martin@gnome.org>
19454 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
19455 if it's a class type and not a struct. Fixes #31815.
19457 2002-10-06 Martin Baulig <martin@gnome.org>
19459 * statement.cs: Reworked the flow analysis code a bit to make it
19460 usable for dead code elimination.
19462 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19464 * cs-parser.jay: allow empty source files. Fixes bug #31781.
19466 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19468 * expression.cs (ComposedCast.DoResolveType): A quick workaround
19469 to fix the test 165, will investigate deeper.
19471 2002-10-04 Martin Baulig <martin@gnome.org>
19473 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
19474 finally blocks actually work.
19475 (Try.Resolve): We don't need to create a sibling for `finally' if
19476 there is no finally block.
19478 2002-10-04 Martin Baulig <martin@gnome.org>
19480 * class.cs (Constructor.Define): The default accessibility for a
19481 non-default constructor is private, not public.
19483 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19485 * class.cs (Constructor): Make AllowedModifiers public, add
19488 * cs-parser.jay: Perform the modifiers test here, as the
19489 constructor for the Constructor class usually receives a zero
19490 because of the way we create it (first we create, later we
19491 customize, and we were never checking the modifiers).
19493 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
19494 is a version of LookupTypeReflection that includes the type-name
19495 cache. This can be used as a fast path for functions that know
19496 the fully qualified name and are only calling into *.GetType() to
19497 obtain a composed type.
19499 This is also used by TypeManager.LookupType during its type
19502 (LookupType): We now also track the real type name, as sometimes
19503 we can get a quey for the real type name from things like
19504 ComposedCast. This fixes bug 31422.
19506 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
19507 complete type fullname, it does not have to go through the type
19508 resolution system to obtain the composed version of the type (for
19509 obtaining arrays or pointers).
19511 (Conditional.Emit): Use the EmitBoolExpression to
19512 generate nicer code, as requested by Paolo.
19514 (ArrayCreation.CheckIndices): Use the patch from
19515 hwang_rob@yahoo.ca to validate the array initializers.
19517 2002-10-03 Miguel de Icaza <miguel@ximian.com>
19519 * class.cs (ConstructorInitializer.Emit): simplify code by using
19520 Invocation.EmitCall, and at the same time, fix the bugs in calling
19521 parent constructors that took variable arguments.
19523 * ecore.cs (Expression.ConvertNumericExplicit,
19524 Expression.ImplicitNumericConversion): Remove the code that
19525 manually wrapped decimal (InternalTypeConstructor call is now gone
19528 * expression.cs (Cast.TryReduce): Also handle decimal types when
19529 trying to perform a constant fold on the type.
19531 * typemanager.cs (IsUnmanagedtype): Partially implemented.
19533 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
19534 that only turned off an error report, and did nothing else.
19536 2002-10-02 Miguel de Icaza <miguel@ximian.com>
19538 * driver.cs: Handle and ignore /fullpaths
19540 2002-10-01 Miguel de Icaza <miguel@ximian.com>
19542 * expression.cs (Binary.ResolveOperator): Catch the case where
19543 DoNumericPromotions returns true,
19545 (Binary.DoNumericPromotions): Simplify the code, and the tests.
19547 2002-09-27 Miguel de Icaza <miguel@ximian.com>
19549 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
19552 2002-09-26 Miguel de Icaza <miguel@ximian.com>
19554 * ecore.cs (ConvertNumericExplicit): It is not enough that the
19555 conversion exists, but it is also required that the conversion be
19556 performed. This manifested in "(Type64Enum) 2".
19558 * class.cs (TypeManager.AddMethod): The fix is not to change
19559 AddEnum, because that one was using a fully qualified name (every
19560 DeclSpace derivative does), but to change the AddMethod routine
19561 that was using an un-namespaced name. This now correctly reports
19562 the duplicated name.
19564 Revert patch until I can properly fix it. The issue
19565 is that we have a shared Type space across all namespaces
19566 currently, which is wrong.
19568 Options include making the Namespace a DeclSpace, and merge
19569 current_namespace/current_container in the parser.
19571 2002-09-25 Miguel de Icaza <miguel@ximian.com>
19573 * cs-parser.jay: Improve error reporting when we get a different
19574 kind of expression in local_variable_type and
19575 local_variable_pointer_type.
19577 Propagate this to avoid missleading errors being reported.
19579 * ecore.cs (ImplicitReferenceConversion): treat
19580 TypeManager.value_type as a target just like object_type. As
19585 Is valid, and needs to result in the int 1 being boxed before it
19586 is assigned to the value type v.
19588 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
19589 to validate the enumeration name.
19591 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
19592 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
19593 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
19595 * ecore.cs (TryImplicitIntConversion): When doing an
19596 implicit-enumeration-conversion, check if the type is 64-bits and
19597 perform a conversion before passing to EnumConstant.
19599 2002-09-23 Miguel de Icaza <miguel@ximian.com>
19601 * decl.cs (Error_AmbiguousTypeReference); New routine used to
19602 report ambiguous type references. Unlike the MS version, we
19603 report what the ambiguity is. Innovation at work ;-)
19605 (DeclSpace.FindType): Require a location argument to
19606 display when we display an ambiguous error.
19608 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
19610 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
19612 * expression.cs (EmitDynamicInitializers): Apply patch from
19613 hwang_rob@yahoo.ca that fixes the order in which we emit our
19616 2002-09-21 Martin Baulig <martin@gnome.org>
19618 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
19619 delegate takes no arguments.
19621 2002-09-20 Miguel de Icaza <miguel@ximian.com>
19623 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
19626 * expression.cs: Extract the underlying type.
19628 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
19630 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
19632 2002-09-19 Miguel de Icaza <miguel@ximian.com>
19634 * class.cs (TypeContainer.DefineType): We can not use the nice
19635 PackingSize with the size set to 1 DefineType method, because it
19636 will not allow us to define the interfaces that the struct
19639 This completes the fixing of bug 27287
19641 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
19642 means also structs. This fixes part of the problem.
19643 (Expresion.ImplicitReferenceConversionExists): ditto.
19645 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
19646 error if there were no errors reported during the type lookup
19647 process, to avoid duplicates or redundant errors. Without this
19648 you would get an ambiguous errors plus a type not found. We have
19649 beaten the user enough with the first error.
19651 (DeclSparce.FindType): Emit a warning if we have an ambiguous
19654 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
19655 during the resolution process, stop the lookup, this avoids
19656 repeated error reports (same error twice).
19658 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
19660 * typemanager.cs (LookupType): Redo the type lookup code to match
19661 the needs of System.Reflection.
19663 The issue is that System.Reflection requires references to nested
19664 types to begin with a "+" sign instead of a dot. So toplevel
19665 types look like: "NameSpace.TopLevelClass", and nested ones look
19666 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
19669 2002-09-19 Martin Baulig <martin@gnome.org>
19671 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
19672 says that a method always returns or always throws an exception,
19673 don't report the CS0161.
19675 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
19676 set `Returns = new_returns'.
19678 2002-09-19 Martin Baulig <martin@gnome.org>
19680 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
19681 to an enum constant, check for a CS0176.
19683 2002-09-18 Miguel de Icaza <miguel@ximian.com>
19685 * class.cs (TypeContainer.CheckPairedOperators): Now we check
19686 for operators that must be in pairs and report errors.
19688 * ecore.cs (SimpleName.DoResolveType): During the initial type
19689 resolution process, when we define types recursively, we must
19690 check first for types in our current scope before we perform
19691 lookups in the enclosing scopes.
19693 * expression.cs (MakeByteBlob): Handle Decimal blobs.
19695 (Invocation.VerifyArgumentsCompat): Call
19696 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
19697 I thought we were supposed to always call this, but there are a
19698 few places in the code where we dont do it.
19700 2002-09-17 Miguel de Icaza <miguel@ximian.com>
19702 * driver.cs: Add support in -linkres and -resource to specify the
19703 name of the identifier.
19705 2002-09-16 Miguel de Icaza <miguel@ximian.com>
19707 * ecore.cs (StandardConversionExists): Sync with the conversion
19708 code: allow anything-* to void* conversions.
19710 (FindMostSpecificSource): Use an Expression argument
19711 instead of a Type, because we might be handed over a Literal which
19712 gets a few more implicit conversions that plain types do not. So
19713 this information was being lost.
19715 Also, we drop the temporary type-holder expression when not
19718 2002-09-17 Martin Baulig <martin@gnome.org>
19720 * class.cs (PropertyBase.CheckBase): Don't check the base class if
19721 this is an explicit interface implementation.
19723 2002-09-17 Martin Baulig <martin@gnome.org>
19725 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
19726 different `IndexerName' attributes.
19728 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
19729 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
19730 virtual CommonResolve().
19732 2002-09-16 Miguel de Icaza <miguel@ximian.com>
19734 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
19735 and convert that to the UnderlyingType.
19737 * statement.cs (Foreach.Resolve): Indexers are just like variables
19738 or PropertyAccesses.
19740 * cs-tokenizer.cs (consume_string): Track line numbers and columns
19741 inside quoted strings, we were not doing this before.
19743 2002-09-16 Martin Baulig <martin@gnome.org>
19745 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
19746 resolve it. This is needed for the definite assignment check of the
19747 instance expression, fixes bug #29846.
19748 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
19750 2002-09-16 Nick Drochak <ndrochak@gol.com>
19752 * parameter.cs: Fix compile error. Cannot reference static member
19753 from an instance object. Is this an mcs bug?
19755 2002-09-14 Martin Baulig <martin@gnome.org>
19757 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
19758 multiple times. Fixes bug #30295, added test-166.cs.
19760 2002-09-14 Martin Baulig <martin@gnome.org>
19762 * statement.cs (Block.Emit): Don't emit unreachable code.
19763 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
19764 `break' statements.
19765 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
19767 2002-09-14 Martin Baulig <martin@gnome.org>
19769 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
19772 2002-09-14 Martin Baulig <martin@gnome.org>
19774 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
19775 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
19776 be false on the ms runtime.
19778 2002-09-13 Martin Baulig <martin@gnome.org>
19780 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
19781 the CS0038 error message.
19783 2002-09-12 Miguel de Icaza <miguel@ximian.com>
19785 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
19786 constant inside, return it.
19788 2002-09-12 Martin Baulig <martin@gnome.org>
19790 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
19791 implicit conversion can be done between enum types.
19793 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
19794 check whether an implicit conversion to the current enum's UnderlyingType
19795 exists and report an error if not.
19797 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
19798 without debugging support.
19800 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
19801 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
19803 2002-09-12 Martin Baulig <martin@gnome.org>
19805 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
19807 * ecore.cs (IMemberExpr.DeclaringType): New property.
19808 (SimpleName.SimpleNameResolve): Check whether we're accessing a
19809 nonstatic member of an outer type (CS0038).
19811 2002-09-11 Miguel de Icaza <miguel@ximian.com>
19813 * driver.cs: Activate the using-error detector at warning level
19814 4 (at least for MS-compatible APIs).
19816 * namespace.cs (VerifyUsing): Small buglett fix.
19818 * pending.cs (PendingImplementation): pass the container pointer.
19820 * interface.cs (GetMethods): Allow for recursive definition. Long
19821 term, I would like to move every type to support recursive
19822 definitions, not the current ordering mechanism that we have right
19825 The situation is this: Attributes are handled before interfaces,
19826 so we can apply attributes to interfaces. But some attributes
19827 implement interfaces, we will now handle the simple cases
19828 (recursive definitions will just get an error).
19830 * parameter.cs: Only invalidate types at the end if we fail to
19833 2002-09-09 Martin Baulig <martin@gnome.org>
19835 * ecore.cs (PropertyExpr.Emit): Also check for
19836 TypeManager.system_int_array_get_length so this'll also work when
19837 compiling corlib. Fixes #30003.
19839 2002-09-09 Martin Baulig <martin@gnome.org>
19841 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
19842 and throw an exception if we can't get the type's size. Fixed #30040,
19845 2002-09-09 Martin Baulig <martin@gnome.org>
19847 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
19849 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
19850 context. Fixes bug #30027.
19852 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
19853 virtual functions. Fixes bug #30043, added test-164.cs.
19855 2002-09-08 Ravi Pratap <ravi@ximian.com>
19857 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
19859 2002-09-08 Nick Drochak <ndrochak@gol.com>
19861 * driver.cs: Use an object to get the windows codepage since it's not a
19864 2002-09-08 Miguel de Icaza <miguel@ximian.com>
19866 * statement.cs (For.Emit): for infinite loops (test == null)
19867 return whether there is a break inside, not always "true".
19869 * namespace.cs (UsingEntry): New struct to hold the name of the
19870 using definition, the location where it is defined, and whether it
19871 has been used in a successful type lookup.
19873 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
19878 2002-09-06 Ravi Pratap <ravi@ximian.com>
19880 * attribute.cs : Fix incorrect code which relied on catching
19881 a NullReferenceException to detect a null being passed in
19882 where an object was expected.
19884 2002-09-06 Miguel de Icaza <miguel@ximian.com>
19886 * statement.cs (Try): flag the catch variable as assigned
19888 * expression.cs (Cast): Simplified by using ResolveType instead of
19889 manually resolving.
19891 * statement.cs (Catch): Fix bug by using ResolveType.
19893 2002-09-06 Ravi Pratap <ravi@ximian.com>
19895 * expression.cs (BetterConversion): Special case for when we have
19896 a NullLiteral as the argument and we have to choose between string
19897 and object types - we choose string the way csc does.
19899 * attribute.cs (Attribute.Resolve): Catch the
19900 NullReferenceException and report error #182 since the Mono
19901 runtime no more has the bug and having this exception raised means
19902 we tried to select a constructor which takes an object and is
19905 2002-09-05 Ravi Pratap <ravi@ximian.com>
19907 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
19908 message (1502, 1503) when we can't locate a method after overload
19909 resolution. This is much more informative and closes the bug
19912 * interface.cs (PopulateMethod): Return if there are no argument
19913 types. Fixes a NullReferenceException bug.
19915 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
19916 expressions too. Previously we were checking only in one place for
19917 positional arguments leaving out named arguments.
19919 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
19920 type to the enum type is not allowed. Remove code corresponding to
19923 (ConvertNumericExplicit): Allow explicit conversions from
19924 the underlying type to enum type. This precisely follows the spec
19925 and closes a bug filed by Gonzalo.
19927 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19930 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
19932 2002-09-03 Miguel de Icaza <miguel@ximian.com>
19934 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
19935 it was important that we stored the right value after the
19936 reduction in `converted'.
19938 2002-09-04 Martin Baulig <martin@gnome.org>
19940 * location.cs (Location.SymbolDocument): Use full pathnames for the
19943 2002-08-30 Miguel de Icaza <miguel@ximian.com>
19945 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
19946 of the expression resolve mechanism, because that will catch the
19947 SimpleName error failures.
19949 (Conditional): If we can not resolve the
19950 expression, return, do not crash.
19952 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19955 (location): display token name instead of its number.
19957 2002-08-28 Martin Baulig <martin@gnome.org>
19959 * expression.cs (Binary.ResolveOperator): Don't silently return
19960 but return an error if an operator cannot be applied between two
19963 2002-08-28 Martin Baulig <martin@gnome.org>
19965 * class.cs (Constructor.Define): Set the permission attributes
19966 correctly instead of making all constructors public.
19968 2002-08-28 Martin Baulig <martin@gnome.org>
19970 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
19971 for private members before reporting a CS0103; if we find anything,
19974 2002-08-28 Martin Baulig <martin@gnome.org>
19976 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
19977 to check whether `closure_start_type == closure_invocation_type',
19978 we also need to check whether `m.DeclaringType == closure_invocation_type'
19979 before bypassing the permission checks. We might be accessing
19980 protected/private members from the base class.
19981 (TypeManager.RealMemberLookup): Only set private_ok if private
19982 members were requested via BindingFlags.NonPublic.
19984 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
19986 * expression.cs (MemberAccess.ResolveMemberAccess): Set
19987 MethodGroupExpr.IsExplicitImpl if appropriate.
19988 (Invocation.DoResolve): Don't report the CS0120 for explicit
19989 interface implementations.
19991 2002-08-27 Martin Baulig <martin@gnome.org>
19993 * expression.cs (Invocation.DoResolve): If this is a static
19994 method and we don't have an InstanceExpression, we must report
19997 2002-08-25 Martin Baulig <martin@gnome.org>
19999 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
20000 `==' between a valuetype and an object.
20002 2002-08-25 Miguel de Icaza <miguel@ximian.com>
20004 * ecore.cs (TypeExpr): Provide a ToString method.
20006 2002-08-24 Martin Baulig <martin@gnome.org>
20008 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
20009 now called proggie.dbg and it's a binary file.
20011 2002-08-23 Martin Baulig <martin@gnome.org>
20013 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
20015 2002-08-23 Martin Baulig <martin@gnome.org>
20017 * struct.cs (MyStructInfo.ctor): Make this work with empty
20018 structs; it's not allowed to use foreach() on null.
20020 2002-08-23 Martin Baulig <martin@gnome.org>
20022 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
20023 writer the full pathname of the generated assembly.
20025 2002-08-23 Martin Baulig <martin@gnome.org>
20027 * statements.cs (FlowBranching.UsageVector.MergeChildren):
20028 A `finally' block never returns or breaks; improved handling of
20031 2002-08-23 Martin Baulig <martin@gnome.org>
20033 * statement.cs (Throw.Resolve): Allow `throw null'.
20035 2002-08-23 Martin Baulig <martin@gnome.org>
20037 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
20038 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
20039 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
20040 MemberLookup would return a wrong event if this is an explicit
20041 interface implementation and the class has an event with the same
20044 2002-08-23 Martin Baulig <martin@gnome.org>
20046 * statement.cs (Block.AddChildVariableNames): New public method.
20047 (Block.AddChildVariableName): Likewise.
20048 (Block.IsVariableNameUsedInChildBlock): Likewise.
20049 (Block.AddVariable): Check whether a variable name has already
20050 been used in a child block.
20052 * cs-parser.jay (declare_local_variables): Mark all variable names
20053 from the current block as being used in a child block in the
20056 2002-08-23 Martin Baulig <martin@gnome.org>
20058 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
20059 find the symbol writer.
20061 * driver.cs: csc also allows the arguments to /define being
20062 separated by commas, not only by semicolons.
20064 2002-08-23 Martin Baulig <martin@gnome.org>
20066 * interface.cs (Interface.GetMembers): Added static check for events.
20068 2002-08-15 Martin Baulig <martin@gnome.org>
20070 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
20071 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
20073 * ecore.cs (Expression.MemberLookup): Added documentation and explained
20074 why the MethodData.EmitDestructor() change was necessary.
20076 2002-08-20 Martin Baulig <martin@gnome.org>
20078 * class.cs (TypeContainer.FindMembers): Added static check for events.
20080 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
20082 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
20083 use Type.GetEvents(), not Type.FindMembers().
20085 2002-08-20 Martin Baulig <martin@gnome.org>
20087 * decl.cs (MemberCache): Added a special method cache which will
20088 be used for method-only searched. This ensures that a method
20089 search will return a MethodInfo with the correct ReflectedType for
20092 2002-08-20 Martin Baulig <martin@gnome.org>
20094 * decl.cs (DeclSpace.FindMembers): Made this public.
20096 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20098 * delegate.cs: fixed build on windows.
20099 [FIXME: Filed as bug #29150: MCS must report these errors.]
20101 2002-08-19 Ravi Pratap <ravi@ximian.com>
20103 * ecore.cs (StandardConversionExists): Return a false
20104 if we are trying to convert the void type to anything else
20105 since that is not allowed.
20107 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
20108 we flag error 70 in the event an event is trying to be accessed
20109 directly from outside the declaring type.
20111 2002-08-20 Martin Baulig <martin@gnome.org>
20113 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
20114 MemberCache from typemanager.cs to decl.cs.
20116 2002-08-19 Martin Baulig <martin@gnome.org>
20118 * class.cs (TypeContainer): Implement IMemberContainer.
20119 (TypeContainer.DefineMembers): Create the MemberCache.
20120 (TypeContainer.FindMembers): Do better BindingFlags checking; only
20121 return public members if BindingFlags.Public was given, check
20122 whether members are static.
20124 2002-08-16 Martin Baulig <martin@gnome.org>
20126 * decl.cs (DeclSpace.Define): Splitted this in Define and
20127 DefineMembers. DefineMembers is called first and initializes the
20130 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
20131 DefineMembers() on all our DeclSpaces.
20133 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
20134 but call DefineMembers() on all nested interfaces. We call their
20135 Define() in our new Define() function.
20137 * interface.cs (Interface): Implement IMemberContainer.
20138 (Interface.Define): Moved all code except the attribute stuf to
20140 (Interface.DefineMembers): Initialize the member cache.
20142 * typemanager.cs (IMemberFinder): Removed this interface, we don't
20143 need this anymore since we can use MemberCache.FindMembers directly.
20145 2002-08-19 Martin Baulig <martin@gnome.org>
20147 * typemanager.cs (MemberCache): When creating the cache for an
20148 interface type, add all inherited members.
20149 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
20150 to `out bool used_cache' and documented it.
20151 (TypeManager.MemberLookup): If we already used the cache in the first
20152 iteration, we don't need to do the interfaces check.
20154 2002-08-19 Martin Baulig <martin@gnome.org>
20156 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
20157 here from IMemberFinder and don't implement this interface anymore.
20158 (DeclSpace.MemberCache): Moved here from IMemberFinder.
20160 * typemanager.cs (IMemberFinder): This interface is now only used by
20161 classes which actually support the member cache.
20162 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
20163 since we only put DeclSpaces into this Hashtable.
20164 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
20165 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
20167 2002-08-16 Martin Baulig <martin@gnome.org>
20169 * typemanager.cs (ICachingMemberFinder): Removed.
20170 (IMemberFinder.MemberCache): New property.
20171 (TypeManager.FindMembers): Merged this with RealFindMembers().
20172 This function will never be called from TypeManager.MemberLookup()
20173 so we can't use the cache here, just the IMemberFinder.
20174 (TypeManager.MemberLookup_FindMembers): Check whether the
20175 IMemberFinder has a MemberCache and call the cache's FindMembers
20177 (MemberCache): Rewrote larger parts of this yet another time and
20178 cleaned it up a bit.
20180 2002-08-15 Miguel de Icaza <miguel@ximian.com>
20182 * driver.cs (LoadArgs): Support quoting.
20184 (Usage): Show the CSC-like command line arguments.
20186 Improved a few error messages.
20188 2002-08-15 Martin Baulig <martin@gnome.org>
20190 * typemanager.cs (IMemberContainer.Type): New property.
20191 (IMemberContainer.IsInterface): New property.
20193 The following changes are conditional to BROKEN_RUNTIME, which is
20194 defined at the top of the file.
20196 * typemanager.cs (MemberCache.MemberCache): Don't add the base
20197 class'es members, but add all members from TypeHandle.ObjectType
20198 if we're an interface.
20199 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
20200 is the current type.
20201 (MemberCache.CacheEntry.Container): Removed this field.
20202 (TypeHandle.GetMembers): Include inherited members.
20204 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20206 * typemanager.cs: fixed compilation and added a comment on a field that
20209 2002-08-15 Martin Baulig <martin@gnome.org>
20211 * class.cs (ConstructorInitializer.Resolve): In the
20212 Expression.MemberLookup call, use the queried_type as
20215 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
20216 declared' attribute, it's always true.
20217 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
20218 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
20219 temporary wrapper for FindMembers which tells MemberLookup whether
20220 members from the base classes are included in the return value.
20221 This will go away soon.
20222 (TypeManager.MemberLookup): Use this temporary hack here; once the
20223 new MemberCache is completed, we don't need to do the DeclaredOnly
20224 looping here anymore since the MemberCache will take care of this.
20225 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
20226 (MemberCache): When creating the MemberCache for a class, get
20227 members from the current class and all its base classes.
20228 (MemberCache.CacheEntry.Container): New field. This is a
20229 temporary hack until the Mono runtime is fixed to distinguish
20230 between ReflectedType and DeclaringType. It allows us to use MCS
20231 with both the MS runtime and the unfixed Mono runtime without
20232 problems and without accecting performance.
20233 (MemberCache.SearchMembers): The DeclaredOnly looping from
20234 TypeManager.MemberLookup is now done here.
20236 2002-08-14 Martin Baulig <martin@gnome.org>
20238 * statement.cs (MyStructInfo.MyStructInfo): Don't call
20239 Type.GetFields on dynamic types but get the fields from the
20240 corresponding TypeContainer.
20241 (MyStructInfo.GetStructInfo): Added check for enum types.
20243 * typemanager.cs (MemberList.IsSynchronized): Implemented.
20244 (MemberList.SyncRoot): Implemented.
20245 (TypeManager.FilterWithClosure): No need to check permissions if
20246 closure_start_type == closure_invocation_type, don't crash if
20247 closure_invocation_type is null.
20249 2002-08-13 Martin Baulig <martin@gnome.org>
20251 Rewrote TypeContainer.FindMembers to use a member cache. This
20252 gives us a speed increase of about 35% for the self-hosting MCS
20253 build and of about 15-20% for the class libs (both on GNU/Linux).
20255 * report.cs (Timer): New class to get enhanced profiling. This
20256 whole class is "TIMER" conditional since it remarkably slows down
20259 * class.cs (MemberList): New class. This is an IList wrapper
20260 which we're now using instead of passing MemberInfo[]'s around to
20261 avoid copying this array unnecessarily.
20262 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
20263 (ICachingMemberFinder, IMemberContainer): New interface.
20264 (TypeManager.FilterWithClosure): If `criteria' is null, the name
20265 has already been checked, otherwise use it for the name comparision.
20266 (TypeManager.FindMembers): Renamed to RealMemberFinder and
20267 provided wrapper which tries to use ICachingMemberFinder.FindMembers
20268 if possible. Returns a MemberList, not a MemberInfo [].
20269 (TypeHandle): New class, implements IMemberContainer. We create
20270 one instance of this class per type, it contains a MemberCache
20271 which is used to do the member lookups.
20272 (MemberCache): New class. Each instance of this class contains
20273 all members of a type and a name-based hash table.
20274 (MemberCache.FindMembers): This is our new member lookup
20275 function. First, it looks up all members of the requested name in
20276 the hash table. Then, it walks this list and sorts out all
20277 applicable members and returns them.
20279 2002-08-13 Martin Baulig <martin@gnome.org>
20281 In addition to a nice code cleanup, this gives us a performance
20282 increase of about 1.4% on GNU/Linux - not much, but it's already
20283 half a second for the self-hosting MCS compilation.
20285 * typemanager.cs (IMemberFinder): New interface. It is used by
20286 TypeManager.FindMembers to call FindMembers on a TypeContainer,
20287 Enum, Delegate or Interface.
20288 (TypeManager.finder_to_member_finder): New PtrHashtable.
20289 (TypeManager.finder_to_container): Removed.
20290 (TypeManager.finder_to_delegate): Removed.
20291 (TypeManager.finder_to_interface): Removed.
20292 (TypeManager.finder_to_enum): Removed.
20294 * interface.cs (Interface): Implement IMemberFinder.
20296 * delegate.cs (Delegate): Implement IMemberFinder.
20298 * enum.cs (Enum): Implement IMemberFinder.
20300 * class.cs (TypeContainer): Implement IMemberFinder.
20302 2002-08-12 Martin Baulig <martin@gnome.org>
20304 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
20306 2002-08-12 Martin Baulig <martin@gnome.org>
20308 * ecore.cs (ITypeExpression): New interface for expressions which
20310 (TypeExpression): Renamed to TypeLookupExpression.
20311 (Expression.DoResolve): If we're doing a types-only lookup, the
20312 expression must implement the ITypeExpression interface and we
20313 call DoResolveType() on it.
20314 (SimpleName): Implement the new ITypeExpression interface.
20315 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
20316 hack, the situation that we're only looking up types can't happen
20317 anymore when this method is called. Moved the type lookup code to
20318 DoResolveType() and call it.
20319 (SimpleName.DoResolveType): This ITypeExpression interface method
20320 is now doing the types-only lookup.
20321 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
20322 (ResolveFlags): Added MaskExprClass.
20324 * expression.cs (MemberAccess): Implement the ITypeExpression
20326 (MemberAccess.DoResolve): Added support for a types-only lookup
20327 when we're called via ITypeExpression.DoResolveType().
20328 (ComposedCast): Implement the ITypeExpression interface.
20330 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
20331 Expression.Resolve() with ResolveFlags.Type instead.
20333 2002-08-12 Martin Baulig <martin@gnome.org>
20335 * interface.cs (Interface.Define): Apply attributes.
20337 * attribute.cs (Attribute.ApplyAttributes): Added support for
20338 interface attributes.
20340 2002-08-11 Martin Baulig <martin@gnome.org>
20342 * statement.cs (Block.Emit): Only check the "this" variable if we
20343 do not always throw an exception.
20345 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
20346 whether the property has a set accessor.
20348 2002-08-11 Martin Baulig <martin@gnome.org>
20350 Added control flow analysis support for structs.
20352 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
20353 with control flow analysis turned off.
20354 (IVariable): New interface.
20355 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
20356 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
20357 (FieldExpr.DoResolve): Resolve the instance expression with flow
20358 analysis turned off and do the definite assignment check after the
20359 resolving when we know what the expression will resolve to.
20361 * expression.cs (LocalVariableReference, ParameterReference):
20362 Implement the new IVariable interface, only call the flow analysis
20363 code if ec.DoFlowAnalysis is true.
20364 (This): Added constructor which takes a Block argument. Implement
20365 the new IVariable interface.
20366 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
20367 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
20368 This does the definite assignment checks for struct members.
20370 * class.cs (Constructor.Emit): If this is a non-static `struct'
20371 constructor which doesn't have any initializer, call
20372 Block.AddThisVariable() to tell the flow analysis code that all
20373 struct elements must be initialized before control returns from
20376 * statement.cs (MyStructInfo): New public class.
20377 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
20378 argument to this indexer. If non-zero, check an individual struct
20379 member, not the whole struct.
20380 (FlowBranching.CheckOutParameters): Check struct members.
20381 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
20382 overloaded versions of these methods which take an additional
20383 `int field_idx' argument to check struct members.
20384 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
20385 overloaded versions of these methods which take an additional
20386 `string field_name' argument to check struct member.s
20387 (VariableInfo): Implement the IVariable interface.
20388 (VariableInfo.StructInfo): New public property. Returns the
20389 MyStructInfo instance of the variable if it's a struct or null.
20390 (Block.AddThisVariable): New public method. This is called from
20391 Constructor.Emit() for non-static `struct' constructor which do
20392 not have any initializer. It creates a special variable for the
20393 "this" instance variable which will be checked by the flow
20394 analysis code to ensure that all of the struct's fields are
20395 initialized before control returns from the constructor.
20396 (UsageVector): Added support for struct members. If a
20397 variable/parameter is a struct with N members, we reserve a slot
20398 in the usage vector for each member. A struct is considered fully
20399 initialized if either the struct itself (slot 0) or all its
20400 members are initialized.
20402 2002-08-08 Martin Baulig <martin@gnome.org>
20404 * driver.cs (Driver.MainDriver): Only report an error CS5001
20405 if there were no compilation errors.
20407 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
20408 `UnsafeContext' property to determine whether the parent is in
20409 unsafe context rather than checking the parent's ModFlags:
20410 classes nested in an unsafe class are unsafe as well.
20412 2002-08-08 Martin Baulig <martin@gnome.org>
20414 * statement.cs (UsageVector.MergeChildren): Distinguish between
20415 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
20416 we return. Added test17() and test18() to test-154.cs.
20418 2002-08-08 Martin Baulig <martin@gnome.org>
20420 * typemanager.cs (TypeManager.FilterWithClosure): If we have
20421 Family access, make sure the invoking type isn't a subclass of the
20422 queried type (that'd be a CS1540).
20424 * ecore.cs (Expression.MemberLookup): Added overloaded version of
20425 this method which takes an additional `Type invocation_type'.
20427 * expression.cs (BaseAccess.DoResolve): Use the base type as
20428 invocation and query type.
20429 (MemberAccess.DoResolve): If the lookup failed and we're about to
20430 report a CS0122, try a lookup with the ec.ContainerType - if this
20431 succeeds, we must report a CS1540.
20433 2002-08-08 Martin Baulig <martin@gnome.org>
20435 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
20436 (MethodGroupExpr): Implement the IMemberExpr interface.
20438 * expression (MemberAccess.ResolveMemberAccess): No need to have
20439 any special code for MethodGroupExprs anymore, they're now
20442 2002-08-08 Martin Baulig <martin@gnome.org>
20444 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
20445 Family, FamANDAssem and FamORAssem permissions.
20446 (TypeManager.IsSubclassOrNestedChildOf): New public method.
20448 2002-08-08 Martin Baulig <martin@gnome.org>
20450 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
20451 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
20454 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
20456 * driver.cs: implemented /resource option to embed managed resources.
20458 2002-08-07 Martin Baulig <martin@gnome.org>
20460 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
20461 (FieldBase.HasFieldInitializer): New public property.
20462 (FieldBase.GetInitializerExpression): New public method. Resolves and
20463 returns the field initializer and makes sure it is only resolved once.
20464 (TypeContainer.EmitFieldInitializers): Call
20465 FieldBase.GetInitializerExpression to get the initializer, this ensures
20466 that it isn't resolved multiple times.
20468 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
20469 the resolving process (SimpleName/MemberLookup) that we're currently
20470 emitting a field initializer (which must not access any instance members,
20471 this is an error CS0236).
20473 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
20474 argument, if the `IsFieldInitializer' flag is set, we must report and
20475 error CS0236 and not an error CS0120.
20477 2002-08-07 Martin Baulig <martin@gnome.org>
20479 * ecore.cs (IMemberExpr): New public interface.
20480 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
20481 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
20482 if the expression is an IMemberExpr.
20484 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
20485 to be null, implicitly default to `this' if we're non-static in
20486 this case. Simplified the code a lot by using the new IMemberExpr
20487 interface. Also fixed bug #28176 here.
20489 2002-08-06 Martin Baulig <martin@gnome.org>
20491 * cs-parser.jay (SimpleLookup): Removed. We need to create
20492 ParameterReferences during semantic analysis so that we can do a
20493 type-only search when resolving Cast, TypeOf and SizeOf.
20494 (block): Pass the `current_local_parameters' to the Block's
20497 * class.cs (ConstructorInitializer): Added `Parameters parameters'
20498 argument to the constructor.
20499 (ConstructorInitializer.Resolve): Create a temporary implicit
20500 block with the parameters.
20502 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
20503 references here if we aren't doing a type-only search.
20505 * statement.cs (Block): Added constructor which takes a
20506 `Parameters parameters' argument.
20507 (Block.Parameters): New public property.
20509 * support.cs (InternalParameters.Parameters): Renamed `parameters'
20510 to `Parameters' and made it public readonly.
20512 2002-08-06 Martin Baulig <martin@gnome.org>
20514 * ecore.cs (Expression.Warning): Made this public as well.
20516 * report.cs (Report.Debug): Print the contents of collections.
20518 2002-08-06 Martin Baulig <martin@gnome.org>
20520 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
20521 used to tell Resolve() which kinds of expressions it may return.
20522 (Expression.Resolve): Added overloaded version of this method which
20523 takes a `ResolveFlags flags' argument. This can be used to tell
20524 Resolve() which kinds of expressions it may return. Reports a
20526 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
20527 ResolveFlags.SimpleName.
20528 (Expression.Error118): Added overloaded version of this method which
20529 takes a `ResolveFlags flags' argument. It uses the flags to determine
20530 which kinds of expressions are allowed.
20532 * expression.cs (Argument.ResolveMethodGroup): New public method.
20533 Resolves an argument, but allows a MethodGroup to be returned.
20534 This is used when invoking a delegate.
20536 * TODO: Updated a bit.
20538 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20540 Fixed compilation with csc.
20542 * ecore.cs: Expression.Error made public. Is this correct? Should
20543 Warning be made public too?
20545 * expression.cs: use ea.Location instead of ea.loc.
20546 [FIXME: Filed as bug #28607: MCS must report these errors.]
20548 2002-08-06 Martin Baulig <martin@gnome.org>
20550 * ecore.cs (Expression.loc): Moved the location here instead of
20551 duplicating it in all derived classes.
20552 (Expression.Location): New public property.
20553 (Expression.Error, Expression.Warning): Made them non-static and
20554 removed the location argument.
20555 (Expression.Warning): Added overloaded version which takes an
20556 `int level' argument.
20557 (Expression.Error118): Make this non-static and removed the
20558 expression and location arguments.
20559 (TypeExpr): Added location argument to the constructor.
20561 * expression.cs (StaticCallExpr): Added location argument to
20563 (Indirection, PointerArithmetic): Likewise.
20564 (CheckedExpr, UnCheckedExpr): Likewise.
20565 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
20566 (StringPtr): Likewise.
20569 2002-08-05 Martin Baulig <martin@gnome.org>
20571 * expression.cs (BaseAccess.DoResolve): Actually report errors.
20573 * assign.cs (Assign.DoResolve): Check whether the source
20574 expression is a value or variable.
20576 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
20577 while resolving the corresponding blocks.
20579 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
20580 an error, don't silently return null.
20582 * statement.cs (Block.AddVariable): Do the error reporting here
20583 and distinguish between CS0128 and CS0136.
20584 (Block.DoResolve): Report all unused labels (warning CS0164).
20585 (LabeledStatement): Pass the location to the constructor.
20586 (LabeledStatement.HasBeenReferenced): New property.
20587 (LabeledStatement.Resolve): Set it to true here.
20589 * statement.cs (Return.Emit): Return success even after reporting
20590 a type mismatch error (CS0126 or CS0127), this is what csc does and
20591 it avoids confusing the users with any consecutive errors.
20593 2002-08-05 Martin Baulig <martin@gnome.org>
20595 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
20597 * const.cs (Const.LookupConstantValue): Catch circular definitions.
20599 * expression.cs (MemberAccess.DoResolve): Silently return if an
20600 error has already been reported.
20602 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
20603 error has already been reported.
20605 2002-08-05 Martin Baulig <martin@gnome.org>
20607 * statement.cs (UsageVector): Only initialize the `parameters'
20608 vector if we actually have any "out" parameters.
20610 2002-08-05 Martin Baulig <martin@gnome.org>
20612 * expression.cs (Binary.ResolveOperator): When combining delegates,
20613 they must have the same type.
20615 2002-08-05 Martin Baulig <martin@gnome.org>
20617 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
20618 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
20619 work with the ms runtime and we also don't need it: if we're a
20620 PropertyBuilder and not in the `indexer_arguments' hash, then we
20621 are a property and not an indexer.
20623 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
20624 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
20625 since the latter one doesn't work with the ms runtime.
20627 2002-08-03 Martin Baulig <martin@gnome.org>
20629 Fixed bugs #27998 and #22735.
20631 * class.cs (Method.IsOperator): New public field.
20632 (Method.CheckBase): Report CS0111 if there's already a method
20633 with the same parameters in the current class. Report CS0508 when
20634 attempting to change the return type of an inherited method.
20635 (MethodData.Emit): Report CS0179 if a method doesn't have a body
20636 and it's not marked abstract or extern.
20637 (PropertyBase): New abstract base class for Property and Indexer.
20638 (PropertyBase.CheckBase): Moved here from Property and made it work
20640 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
20641 the same so we can reuse it there.
20642 (Property, Indexer): Derive from PropertyBase.
20643 (MethodSignature.inheritable_property_signature_filter): New delegate
20644 to find properties and indexers.
20646 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
20647 argument and improved error reporting.
20649 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
20650 EmptyReadOnlyParameters and made it a property.
20652 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
20653 version of this method which takes a `PropertyInfo indexer'.
20654 (TypeManager.RegisterIndexer): New method.
20656 * class.cs: Added myself as author of this file :-)
20658 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20660 * class.cs: fixed compilation on windoze.
20662 2002-08-03 Martin Baulig <martin@gnome.org>
20664 * interface.cs (Interface.GetInterfaceBases): Check whether all
20665 base interfaces are at least as accessible than the current one.
20667 * class.cs (TypeContainer.GetClassBases): Check whether base types
20668 are at least as accessible than the current type.
20669 (TypeContainer.AsAccessible): Implemented and made non-static.
20670 (MemberBase.CheckParameters): Report errors if the accessibility
20673 * delegate.cs (Delegate.Delegate): The default visibility is
20674 internal for top-level types and private for nested types.
20675 (Delegate.Define): Report errors if the accessibility checks fail.
20677 * enum.cs (Enum.Enum): The default visibility is internal for
20678 top-level types and private for nested types.
20679 (Enum.DefineType): Compute the correct visibility.
20681 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
20682 function which takes a `bool is_toplevel' instead of a TypeContainer.
20684 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
20687 2002-08-02 Martin Baulig <martin@gnome.org>
20689 * expression.cs (LocalVariableReferenc): Added constructor which
20690 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
20691 (LocalVariableReference.IsReadOnly): New property.
20692 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
20693 variable is readonly, use our own readonly flag to do this; you can
20694 use the new constructor to get a writable reference to a read-only
20697 * cs-parser.jay (foreach_statement, using_statement): Get a writable
20698 reference to the local variable.
20700 2002-08-01 Miguel de Icaza <miguel@ximian.com>
20702 * rootcontext.cs (ResolveCore): Also include System.Exception
20704 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
20705 we reach an EmptyStatement.
20707 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
20710 * expression.cs (Binary.ResolveOperator): Check error result in
20713 use brtrue/brfalse directly and avoid compares to null.
20715 2002-08-02 Martin Baulig <martin@gnome.org>
20717 * class.cs (TypeContainer.Define): Define all nested interfaces here.
20718 Fixes bug #28407, added test-155.cs.
20720 2002-08-01 Martin Baulig <martin@gnome.org>
20722 * class.cs (Event.EmitDefaultMethod): Make this work with static
20723 events. Fixes #28311, added verify-3.cs.
20725 2002-08-01 Martin Baulig <martin@gnome.org>
20727 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
20728 `is_disposable' fields.
20729 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
20730 `hm.is_disposable' if we're using the collection pattern.
20731 (Foreach.EmitCollectionForeach): Use the correct type for the
20732 enumerator's local variable, only emit the try/finally block if
20733 necessary (fixes #27713).
20735 2002-08-01 Martin Baulig <martin@gnome.org>
20737 * ecore.cs (Expression.report118): Renamed to Error118 and made
20740 * statement.cs (Throw.Resolve): Check whether the expression is of
20741 the correct type (CS0118) and whether the type derives from
20742 System.Exception (CS0155).
20743 (Catch.Resolve): New method. Do the type lookup here and check
20744 whether it derives from System.Exception (CS0155).
20745 (Catch.CatchType, Catch.IsGeneral): New public properties.
20747 * typemanager.cs (TypeManager.exception_type): Added.
20749 2002-07-31 Miguel de Icaza <miguel@ximian.com>
20751 * driver.cs: Updated About function.
20753 2002-07-31 Martin Baulig <martin@gnome.org>
20755 Implemented Control Flow Analysis.
20757 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
20758 (EmitContext.CurrentBranching): Added.
20759 (EmitContext.StartFlowBranching): Added.
20760 (EmitContext.EndFlowBranching): Added.
20761 (EmitContext.KillFlowBranching): Added.
20762 (EmitContext.IsVariableAssigned): Added.
20763 (EmitContext.SetVariableAssigned): Added.
20764 (EmitContext.IsParameterAssigned): Added.
20765 (EmitContext.SetParameterAssigned): Added.
20766 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
20767 Added control flow analysis stuff here.
20769 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
20770 resolve the expression as lvalue.
20771 (LocalVariableReference.DoResolve): Check whether the variable has
20772 already been assigned.
20773 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
20774 the parameter as assigned here.
20775 (ParameterReference.DoResolve): Check whether the parameter has already
20777 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
20778 expression as lvalue.
20780 * statement.cs (FlowBranching): New class for the flow analysis code.
20781 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
20782 (LabeledStatement.IsDefined): New public property.
20783 (LabeledStatement.AddUsageVector): New public method to tell flow
20784 analyis that the label may be reached via a forward jump.
20785 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
20787 (VariableInfo.Number): New public field. This is used by flow analysis
20788 to number all locals of a block.
20789 (Block.CountVariables): New public property. This is the number of
20790 local variables in this block (including the locals from all parent
20792 (Block.EmitMeta): Number all the variables.
20794 * statement.cs: Added flow analysis support to all classes.
20796 2002-07-31 Martin Baulig <martin@gnome.org>
20798 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
20799 To get debugging messages, compile mcs with /define:MCS_DEBUG and
20800 then use this argument.
20802 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
20804 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
20805 use this to specify /define options.
20807 2002-07-29 Martin Baulig <martin@gnome.org>
20809 * statement.cs (Fixed): Moved all code that does variable lookups
20810 and resolvings from Emit to Resolve.
20812 * statement.cs (For): Moved all code that does variable lookups
20813 and resolvings from Emit to Resolve.
20815 * statement.cs (Using): Moved all code that does variable lookups
20816 and resolvings from Emit to Resolve.
20818 2002-07-29 Martin Baulig <martin@gnome.org>
20820 * attribute.cs (Attribute.Resolve): Explicitly catch a
20821 System.NullReferenceException when creating the
20822 CustromAttributeBuilder and report a different warning message.
20824 2002-07-29 Martin Baulig <martin@gnome.org>
20826 * support.cs (ParameterData.ParameterName): Added method to
20827 get the name of a parameter.
20829 * typemanager.cs (TypeManager.IsValueType): New public method.
20831 2002-07-29 Martin Baulig <martin@gnome.org>
20833 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
20834 is a flag which specifies that it's either ref or out.
20835 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
20836 the out parameter to `out Parameter.Modifier mod', also set the
20837 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
20839 * support.cs (InternalParameters.ParameterModifier): Distinguish
20840 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
20841 Parameter.Modifier.ISBYREF flag if it's either ref or out.
20843 * expression.cs (Argument.GetParameterModifier): Distinguish
20844 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
20845 Parameter.Modifier.ISBYREF flag if it's either ref or out.
20847 2002-07-29 Martin Baulig <martin@gnome.org>
20849 * expression.cs (ParameterReference.ParameterReference): Added
20850 `Location loc' argument to the constructor.
20852 * cs-parser.jay: Pass location to ParameterReference.
20854 2002-07-28 Miguel de Icaza <miguel@ximian.com>
20856 * statement.cs (Try): Initialize the location.
20858 * cs-parser.jay: pass location to Try.
20860 * expression.cs (Unary.Reduce): Change the prototype to return
20861 whether a constant fold could be performed or not. The result is
20862 returned in an out parameters. In the case of Indirection and
20863 AddressOf, we want to perform the full tests.
20865 2002-07-26 Miguel de Icaza <miguel@ximian.com>
20867 * statement.cs (Statement.Emit): Flag dead code.
20869 2002-07-27 Andrew Birkett <andy@nobugs.org>
20871 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
20873 2002-07-27 Martin Baulig <martin@gnome.org>
20875 * class.cs (MethodData.Define): Put back call to
20876 TypeManager.AddMethod(), accidentally commented this out.
20878 * report.cs (Debug): New public method to print debugging information,
20879 this is `[Conditional ("DEBUG")]'.
20881 2002-07-26 Martin Baulig <martin@gnome.org>
20883 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
20884 (switch_statement): Push the current_block to the switch_stack and
20885 pop it again when we're done with the switch.
20886 (switch_section): The new block is a child of the current_block.
20887 Fixes bug #24007, added test-152.cs.
20889 2002-07-27 Martin Baulig <martin@gnome.org>
20891 * expression.cs (Invocation.EmitArguments): When calling a varargs
20892 function with only its fixed arguments, we need to pass an empty
20895 2002-07-27 Martin Baulig <martin@gnome.org>
20897 Mono 0.13 has been released.
20899 2002-07-25 Miguel de Icaza <miguel@ximian.com>
20901 * driver.cs: Rename --resource to --linkres, because that is what
20902 we do currently, we dont support --resource yet.
20904 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
20906 2002-07-25 Martin Baulig <martin@gnome.org>
20908 * class.cs (MethodData): New public class. This is a `method builder'
20909 class for a method or one accessor of a Property/Indexer/Event.
20910 (MethodData.GetMethodFlags): Moved here from MemberBase.
20911 (MethodData.ApplyAttributes): Likewise.
20912 (MethodData.ApplyObsoleteAttribute): Likewise.
20913 (MethodData.ApplyConditionalAttribute): Likewise.
20914 (MethodData.ApplyDllImportAttribute): Likewise.
20915 (MethodData.CheckAbstractAndExternal): Likewise.
20916 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
20917 (MethodData.Emit): Formerly known as Method.Emit().
20918 (MemberBase): Moved everything which was specific to a single
20919 accessor/method to MethodData.
20920 (Method): Create a new MethodData and call Define() and Emit() on it.
20921 (Property, Indexer, Event): Create a new MethodData objects for each
20922 accessor and call Define() and Emit() on them.
20924 2002-07-25 Martin Baulig <martin@gnome.org>
20926 Made MethodCore derive from MemberBase to reuse the code from there.
20927 MemberBase now also checks for attributes.
20929 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
20930 (MemberBase.GetMethodFlags): Moved here from class Method and marked
20932 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
20933 `CallingConventions cc' and `Attributes opt_attrs' arguments.
20934 (MemberBase.ApplyAttributes): New virtual method; applies the
20935 attributes to a method or accessor.
20936 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
20937 (MemberBase.ApplyConditionalAttribute): Likewise.
20938 (MemberBase.ApplyDllImportAttribute): Likewise.
20939 (MemberBase.CheckAbstractAndExternal): Likewise.
20940 (MethodCore.ParameterTypes): This is now a property instead of a
20941 method, it's initialized from DoDefineParameters().
20942 (MethodCore.ParameterInfo): Removed the set accessor.
20943 (MethodCore.DoDefineParameters): New protected virtual method to
20944 initialize ParameterTypes and ParameterInfo.
20945 (Method.GetReturnType): We can now simply return the MemberType.
20946 (Method.GetMethodFlags): Override the MemberBase version and add
20947 the conditional flags.
20948 (Method.CheckBase): Moved some code from Define() here, call
20949 DoDefineParameters() here.
20950 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
20951 here to avoid some larger code duplication.
20952 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
20953 ensure that abstract and external accessors don't declare a body.
20955 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
20956 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
20957 lookup in the attribute's parent classes, so we need to abort as soon
20958 as we found the first match.
20959 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
20960 the attribute has no arguments.
20962 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
20965 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20967 * cs-parser.jay: reverted previous patch.
20969 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20971 * cs-parser.jay: fixed bug #22119.
20973 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20975 * attribute.cs: fixed compilation. The error was:
20976 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
20977 be assigned to before control leaves the current method."
20978 [FIXME: Filed as bug #28186: MCS must report this error.]
20980 2002-07-25 Martin Baulig <martin@gnome.org>
20982 * attribute.cs (Attribute.Conditional_GetConditionName): New static
20983 method to pull the condition name ouf of a Conditional attribute.
20984 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
20985 the obsolete message and error flag out of an Obsolete attribute.
20987 * class.cs (Method.GetMethodFlags): New public method to get the
20988 TypeManager.MethodFlags for this method.
20989 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
20991 (Method.Define): Get and apply the Obsolete and Conditional attributes;
20992 if we're overriding a virtual function, set the new private variable
20993 `parent_method'; call the new TypeManager.AddMethod().
20995 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
20996 the MethodBuilder and the Method in a PtrHashtable.
20997 (TypeManager.builder_to_method): Added for this purpose.
20998 (TypeManager.MethodFlags): Added IsObsoleteError.
20999 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
21000 Obsolete and Conditional arguments in MethodBuilders. If we discover
21001 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
21002 the message from the attribute.
21004 2002-07-24 Martin Baulig <martin@gnome.org>
21006 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
21007 preprocessor directives, ensure that the argument to #define/#undef is
21008 exactly one identifier and that it's actually an identifier.
21010 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
21013 2002-07-24 Martin Baulig <martin@gnome.org>
21015 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
21016 initialize it to TypeManager.object_type in the constructor.
21017 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
21018 of the `hm.get_current' method if we're using the collection pattern.
21019 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
21020 for the explicit conversion to make it work when we're using the collection
21021 pattern and the `Current' property has a different return type than `object'.
21024 2002-07-24 Martin Baulig <martin@gnome.org>
21026 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
21027 does not match, but don't report any errors. This method is called in
21028 order for all methods in a MethodGroupExpr until a matching method is
21029 found, so we don't want to bail out if the first method doesn't match.
21030 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
21031 matches, report the 123. Fixes #28070.
21033 2002-07-24 Martin Baulig <martin@gnome.org>
21035 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
21036 TypeManager.TypeToCoreType() to the top of the method so the
21037 following equality checks will work. Fixes #28107.
21039 2002-07-24 Martin Baulig <martin@gnome.org>
21041 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
21042 operand is of type uint, and the other operand is of type sbyte,
21043 short or int, the operands are converted to type long." -
21044 Actually do what this comment already told us. Fixes bug #28106,
21047 2002-07-24 Martin Baulig <martin@gnome.org>
21049 * class.cs (MethodBase): New abstract class. This is now a base
21050 class for Property, Indexer and Event to avoid some code duplication
21051 in their Define() and DefineMethods() methods.
21052 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
21053 generic methods for Define() and DefineMethods().
21054 (FieldBase): Derive from MemberBase, not MemberCore.
21055 (Property): Derive from MemberBase, not MemberCore.
21056 (Property.DefineMethod): Moved all the code from this method to the
21057 new MethodBase.DefineAccessor(), just call it with appropriate
21059 (Property.Define): Call the new Property.DoDefine(), this does some
21060 sanity checks and we don't need to duplicate the code everywhere.
21061 (Event): Derive from MemberBase, not MemberCore.
21062 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
21063 accessors, this will also make them work with interface events.
21064 (Indexer): Derive from MemberBase, not MemberCore.
21065 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
21066 (Indexer.Define): Use the new MethodBase functions.
21068 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
21069 argument to the constructor.
21070 (Interface.FindMembers): Added support for interface events.
21071 (Interface.PopluateEvent): Implemented.
21073 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
21075 2002-07-22 Miguel de Icaza <miguel@ximian.com>
21077 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
21078 but this is required to check for a method name being the same as
21079 the containing class.
21083 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21085 * interface.cs: initialize variable.
21087 2002-07-23 Martin Baulig <martin@gnome.org>
21089 Implemented the IndexerName attribute in interfaces.
21091 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
21092 name if this is an explicit interface implementation.
21093 (Indexer.InterfaceIndexerName): New public variable. If we're
21094 implementing an interface indexer, this is the IndexerName in that
21095 interface. Otherwise, it's the IndexerName.
21096 (Indexer.DefineMethod): If we're implementing interface indexer,
21097 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
21098 and Pending.ImplementIndexer methods.
21099 (Indexer.Define): Also define the PropertyBuilder if we're
21100 implementing an interface indexer and this is neither an explicit
21101 interface implementation nor do the IndexerName match the one in
21104 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
21105 If a method is defined here, then we always need to create a proxy
21106 for it. This is used when implementing interface indexers.
21107 (Pending.IsInterfaceIndexer): New public method.
21108 (Pending.ImplementIndexer): New public method.
21109 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
21110 This is used when implementing interface indexers to define a proxy
21112 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
21113 define a proxy if necessary.
21115 * interface.cs (Interface.IndexerName): New public variable.
21116 (Interface.PopulateIndexer): Set the IndexerName.
21117 (Interface.DefineIndexers): New private method. Populate all the
21118 indexers and make sure their IndexerNames match.
21120 * typemanager.cs (IndexerPropertyName): Added support for interface
21123 2002-07-22 Martin Baulig <martin@gnome.org>
21125 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
21126 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
21127 ret if HasReturnLabel.
21128 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
21131 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
21132 and set the ec.LoopBeginTryCatchLevel.
21133 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
21134 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
21135 the current ec.TryCatchLevel, the branch goes out of an exception
21136 block. In this case, we need to use Leave and not Br.
21138 2002-07-22 Martin Baulig <martin@gnome.org>
21140 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
21141 block unless the block does not always return or it is contained in
21142 another try { ... } catch { ... } block. Fixes bug #26506.
21143 Added verify-1.cs to the test suite.
21145 2002-07-22 Martin Baulig <martin@gnome.org>
21147 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
21148 then we do not always return. Fixes bug #24985.
21150 2002-07-22 Martin Baulig <martin@gnome.org>
21152 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
21153 lookup on a per-class level; ie. walk up the class hierarchy until we
21154 found at least one applicable method, then choose the best among them.
21155 Fixes bug #24463 and test-29.cs.
21157 2002-07-22 Martin Baulig <martin@gnome.org>
21159 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
21160 return types of the methods. The return type is not part of the
21161 signature and we must not check it to make the `new' modifier work.
21162 Fixes bug #27999, also added test-147.cs.
21163 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
21165 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
21166 on the method's return type.
21168 2002-07-21 Martin Baulig <martin@gnome.org>
21170 * assign.cs: Make this work if the rightmost source is a constant and
21171 we need to do an implicit type conversion. Also adding a few more tests
21172 to test-38.cs which should have caught this.
21174 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
21175 target in the makefile for this. The makefile.gnu is primarily intended
21176 for end-users who don't want to debug the compiler.
21178 2002-07-21 Martin Baulig <martin@gnome.org>
21180 * assign.cs: Improved the Assign class so it can now handle embedded
21181 assignments (X = Y = Z = something). As a side-effect this'll now also
21182 consume less local variables. test-38.cs now passes with MCS, added
21183 a few new test cases to that test.
21185 2002-07-20 Martin Baulig <martin@gnome.org>
21187 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
21188 instructions. Fixes bug #27977, also added test-146.cs.
21190 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21192 * cs-tokenizer.cs: fixed getHex ().
21194 2002-07-19 Martin Baulig <martin@gnome.org>
21196 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
21197 not Type.GetType() to lookup the array type. This is needed when
21198 we're constructing an array of a user-defined type.
21199 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
21200 single-dimensional arrays, but also for single-dimensial arrays of
21203 2002-07-19 Martin Baulig <martin@gnome.org>
21205 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
21206 this function is called, it's not allowed to share LocalBuilders
21207 among ILGenerators.
21209 2002-07-19 Martin Baulig <martin@gnome.org>
21211 * expression.cs (Argument.Resolve): Report an error 118 when trying
21212 to pass a type as argument.
21214 2002-07-18 Martin Baulig <martin@gnome.org>
21216 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
21217 Conv_R_Un for the signed `long' type.
21219 2002-07-15 Miguel de Icaza <miguel@ximian.com>
21221 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
21222 `expr' for the temporary result, as that will fail if we do
21223 multiple resolves on the same expression.
21225 2002-07-05 Miguel de Icaza <miguel@ximian.com>
21227 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
21228 ec.TypeContainer for looking up aliases.
21230 * class.cs (TypeContainer): Remove LookupAlias from here.
21232 * decl.cs (DeclSpace); Move here.
21234 2002-07-01 Miguel de Icaza <miguel@ximian.com>
21236 * class.cs (FindMembers): Only call filter if the constructor
21237 bulider is not null.
21239 Also handle delegates in `NestedTypes' now. Now we will perform
21240 type lookups using the standard resolution process. This also
21243 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
21244 This uses Expressions (the limited kind that can be parsed by the
21245 tree) instead of strings.
21247 * expression.cs (ComposedCast.ToString): Implement, used to flag
21248 errors since now we have to render expressions.
21250 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
21253 * ecore.cs (SimpleName.ToString): ditto.
21255 * cs-parser.jay: Instead of using strings to assemble types, use
21256 Expressions to assemble the type (using SimpleName, ComposedCast,
21257 MemberAccess). This should fix the type lookups in declarations,
21258 because we were using a different code path for this.
21260 * statement.cs (Block.Resolve): Continue processing statements
21261 even when there is an error.
21263 2002-07-17 Miguel de Icaza <miguel@ximian.com>
21265 * class.cs (Event.Define): Also remove the `remove' method from
21266 the list of pending items.
21268 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
21269 generate more compact code.
21271 2002-07-17 Martin Baulig <martin@gnome.org>
21273 * const.cs (Const.LookupConstantValue): Add support for constant
21274 `unchecked' and `checked' expressions.
21275 Also adding test case test-140.cs for this.
21277 2002-07-17 Martin Baulig <martin@gnome.org>
21279 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
21280 check whether mi.ReturnType implements the IEnumerator interface; the
21281 `==' and the IsAssignableFrom() will fail in this situation.
21283 2002-07-16 Ravi Pratap <ravi@ximian.com>
21285 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
21288 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21290 * expression.cs: fixed bug #27811.
21292 2002-07-14 Miguel de Icaza <miguel@ximian.com>
21294 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
21295 Molaro: when we are a ref, the value already contains a pointer
21296 value, do not take the address of it.
21298 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
21299 * removed mb-parser.jay and mb-tokenizer.cs
21301 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21303 * expression.cs: check against the building corlib void type.
21305 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
21307 * ecore.cs: fix for valuetype static readonly fields: when
21308 initializing them, we need their address, not the address of a copy.
21310 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
21312 * typemanager.cs: register also enum_type in corlib.
21314 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21316 * class.cs: allow calling this (but not base) initializers in structs.
21318 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
21320 * ecore.cs: make sure we compare against the building base types
21323 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
21325 * typemanager.cs: fix TypeToCoreType() to handle void and object
21326 (corlib gets no more typerefs after this change).
21328 2002-07-12 Miguel de Icaza <miguel@ximian.com>
21330 * expression.cs (ArrayCreation.EmitArrayArguments): use
21331 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
21333 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
21334 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
21335 array indexes, the runtime actually forbids them.
21337 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
21338 for array arguments here.
21340 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
21341 instead of the default for ValueTypes.
21343 (New.DoEmit): Use IsValueType instead of
21344 IsSubclassOf (value_type)
21345 (New.DoResolve): ditto.
21346 (Invocation.EmitCall): ditto.
21348 * assign.cs (Assign): ditto.
21350 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
21351 Statements *are* currently doing part of their resolution during
21354 Expressions do always resolve during resolve, but statements are
21355 only required to propagate resolution to their children.
21357 2002-07-11 Miguel de Icaza <miguel@ximian.com>
21359 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
21361 (LoadAssembly): Do not add the dll if it is already specified
21363 (MainDriver): Add the System directory to the link path at the end,
21364 after all the other -L arguments.
21366 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
21367 wrong opcode for loading bytes and bools (ldelem.i1 instead of
21368 ldelem.u1) and using the opposite for sbytes.
21370 This fixes Digger, and we can finally run it.
21372 * driver.cs (UnixParseOption): Move the option parsing here.
21373 (CSCParseOption): Implement CSC-like parsing of options.
21375 We now support both modes of operation, the old Unix way, and the
21376 new CSC-like way. This should help those who wanted to make cross
21377 platform makefiles.
21379 The only thing broken is that /r:, /reference: and /lib: are not
21380 implemented, because I want to make those have the same semantics
21381 as the CSC compiler has, and kill once and for all the confussion
21382 around this. Will be doing this tomorrow.
21384 * statement.cs (Unsafe.Resolve): The state is checked during
21385 resolve, not emit, so we have to set the flags for IsUnsfe here.
21387 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21389 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
21390 not catch the Error_ObjectRefRequired in SimpleName (as it is
21391 possible to have a class/instance variable name that later gets
21392 deambiguated), we have to check this here.
21394 2002-07-10 Ravi Pratap <ravi@ximian.com>
21396 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
21397 make static and put into Expression.
21399 (Event.Define): Register the private field of the event with the
21400 TypeManager so that GetFieldFromEvent can get at it.
21402 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
21403 keep track of the private field associated with an event which
21406 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
21409 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
21411 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21413 * expression.cs (Binary.EmitBranchable): this routine emits the
21414 Binary expression in a branchable context. This basically means:
21415 we need to branch somewhere, not just get the value on the stack.
21417 This works together with Statement.EmitBoolExpression.
21419 * statement.cs (Statement.EmitBoolExpression): Use
21422 2002-07-09 Miguel de Icaza <miguel@ximian.com>
21424 * statement.cs (For): Reduce the number of jumps in loops.
21426 (For): Implement loop inversion for the For statement.
21428 (Break): We can be breaking out of a Try/Catch controlled section
21429 (foreach might have an implicit try/catch clause), so we need to
21430 use Leave instead of Br.
21432 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
21433 now). If the instace expression supports IMemoryLocation, we use
21434 the AddressOf method from the IMemoryLocation to extract the
21435 address instead of emitting the instance.
21437 This showed up with `This', as we were emitting the instance
21438 always (Emit) instead of the Address of This. Particularly
21439 interesting when This is a value type, as we dont want the Emit
21440 effect (which was to load the object).
21442 2002-07-08 Miguel de Icaza <miguel@ximian.com>
21444 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
21446 * statement.cs (Checked): Set the CheckedState during the resolve
21447 process too, as the ConvCast operations track the checked state on
21448 the resolve process, and not emit.
21450 * cs-parser.jay (namespace_member_declaration): Flag that we have
21451 found a declaration when we do. This is used to flag error 1529
21453 * driver.cs: Report ok when we display the help only.
21455 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
21457 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
21459 2002-07-04 Miguel de Icaza <miguel@ximian.com>
21461 * cs-tokenizer.cs (define): We also have to track locally the
21462 defines. AllDefines is just used for the Conditional Attribute,
21463 but we also need the local defines for the current source code.
21465 2002-07-03 Miguel de Icaza <miguel@ximian.com>
21467 * statement.cs (While, For, Do): These loops can exit through a
21468 Break statement, use this information to tell whether the
21469 statement is the last piece of code.
21471 (Break): Flag that we break.
21473 * codegen.cs (EmitContexts): New `Breaks' state variable.
21475 2002-07-03 Martin Baulig <martin@gnome.org>
21477 * class.cs (TypeContainer.MethodModifiersValid): Allow override
21478 modifiers in method declarations in structs. Otherwise, you won't
21479 be able to override things like Object.Equals().
21481 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21483 * class.cs (Method, Property, Indexer): Do not allow the public
21484 modifier to be used in explicit interface implementations.
21486 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
21487 override modifiers in method declarations in structs
21489 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
21491 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
21492 integer or real overflow, report an error
21494 2002-07-02 Martin Baulig <martin@gnome.org>
21496 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
21497 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
21498 to tell the runtime about our newly created System.Object and
21499 System.ValueType types.
21501 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21503 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
21504 struct instead of Ldarg/Starg.
21506 2002-07-02 Martin Baulig <martin@gnome.org>
21508 * expression.cs (Indirection.Indirection): Call
21509 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
21511 2002-07-02 Martin Baulig <martin@gnome.org>
21513 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
21514 ValueType, call TypeManager.TypeToCoreType() on it.
21515 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
21516 the OpCodes.Newarr argument.
21518 2002-07-02 Martin Baulig <martin@gnome.org>
21520 * expression.cs (Invocation.EmitCall): When compiling corlib,
21521 replace all calls to the system's System.Array type to calls to
21522 the newly created one.
21524 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
21525 System.Array methods.
21526 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
21527 from the system's System.Array type which must be replaced.
21529 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
21531 * typemanager.cs: load unverifiable_code_ctor so we can build
21532 corlib using the correct type. Avoid using GetTypeCode() with
21534 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
21535 TypeManager.object_type to allow building corlib.
21537 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
21539 * ecore.cs: handle System.Enum separately in LoadFromPtr().
21541 2002-07-01 Martin Baulig <martin@gnome.org>
21543 * class.cs: Make the last change actually work, we need to check
21544 whether `ifaces != null' to avoid a crash.
21546 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21548 * class.cs: when we build structs without fields that implement
21549 interfaces, we need to add the interfaces separately, since there is
21550 no API to both set the size and add the interfaces at type creation
21553 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21555 * expression.cs: the dimension arguments to the array constructors
21556 need to be converted if they are a long.
21558 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
21560 * class.cs: don't emit ldarg.0 if there is no parent constructor
21561 (fixes showstopper for corlib).
21563 2002-06-29 Martin Baulig <martin@gnome.org>
21565 MCS now compiles corlib on GNU/Linux :-)
21567 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
21568 ie. check for MethodImplOptions.InternalCall.
21570 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
21571 and TypeManager.attribute_type are null, so we must explicitly check
21572 whether parent is not null to find out whether it's an attribute type.
21573 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
21574 and SetBuilder, not only if the property is neither abstract nor external.
21575 This is necessary to set the MethodImplOptions on the accessor methods.
21576 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
21577 SetBuilder, see Property.Emit().
21579 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
21580 populate "System.Object", "System.ValueType" and "System.Attribute" since
21581 they've already been populated from BootCorlib_PopulateCoreTypes().
21583 2002-06-29 Martin Baulig <martin@gnome.org>
21585 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
21586 is the NullLiteral, we also need to make sure that target_type is not
21589 2002-06-29 Martin Baulig <martin@gnome.org>
21591 * rootcontext.cs (RootContext.ResolveCore): We must initialize
21592 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
21593 before calling BootstrapCorlib_ResolveDelegate ().
21595 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21597 * statement.cs: fixed build-breaker. All tests passed ok.
21599 2002-06-27 Martin Baulig <martin@gnome.org>
21601 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
21602 for System.Decimal when compiling corlib.
21604 2002-06-27 Martin Baulig <martin@gnome.org>
21606 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
21607 switch blocks which contain nothing but a default clause.
21609 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
21611 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
21613 2002-06-27 Martin Baulig <martin@gnome.org>
21615 * ecore.cs (PropertyExpr.PropertyExpr): Call
21616 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
21618 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
21619 is already a TypeBuilder.
21621 2002-06-27 Martin Baulig <martin@gnome.org>
21623 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
21624 `target_type == TypeManager.array_type', not IsAssignableFrom() in
21625 the "from an array-type to System.Array" case. This makes it work
21626 when compiling corlib.
21628 2002-06-27 Martin Baulig <martin@gnome.org>
21630 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
21631 non-static PropertyExpr, set its InstanceExpression. This makes
21632 the `ICollection.Count' property work in System/Array.cs.
21634 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
21636 * driver.cs: Made error handling more consistent. Errors now
21637 tracked by Report class, so many methods which used to return int
21638 now return void. Main() now prints success/failure and
21639 errors/warnings message.
21641 Renamed '--probe' compiler argument to '--expect-error'. Removed
21642 the magic number return values (123 and 124). Now, if the
21643 expected error occurs, the compiler exits with success (exit value
21644 0). If the compilation completes without seeing that particular
21645 error, the compiler exits with failure (exit value 1). The
21646 makefile in mcs/errors has been changed to handle the new behaviour.
21648 * report.cs: Made 'expected error' number a property and renamed
21649 it from 'Probe' to 'ExpectedError'.
21651 * genericparser.cs: Removed error handling support, since it is
21652 now all done by Report class.
21654 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
21655 class, so parse() no longer returns an int.
21657 * namespace.cs: Use Report.Error instead of GenericParser.error
21659 2002-06-22 Miguel de Icaza <miguel@ximian.com>
21661 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
21662 TypeContainer.AddOperator): At the front of the list put the
21663 explicit implementations, so they get resolved/defined first.
21665 2002-06-21 Miguel de Icaza <miguel@ximian.com>
21667 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
21668 interface type is implemented by this TypeContainer. Used during
21669 explicit interface implementation.
21671 (Property.Define, Indexer.Define, Method.Define): Validate that
21672 the given interface in the explicit implementation is one of the
21673 base classes for the containing type.
21675 Also if we are explicitly implementing an interface, but there is
21676 no match in the pending implementation table, report an error.
21678 (Property.Define): Only define the property if we are
21679 not explicitly implementing a property from an interface. Use the
21680 correct name also for those properties (the same CSC uses,
21681 although that is really not needed).
21683 (Property.Emit): Do not emit attributes for explicitly implemented
21684 properties, as there is no TypeBuilder.
21686 (Indexer.Emit): ditto.
21688 Hiding then means that we do not really *implement* a pending
21689 implementation, which makes code fail.
21691 2002-06-22 Martin Baulig <martin@gnome.org>
21693 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
21694 the return value of Object.GetType(). [FIXME: we need to do this whenever
21695 we get a type back from the reflection library].
21697 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
21699 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
21701 2002-06-20 Miguel de Icaza <miguel@ximian.com>
21703 * attribute.cs: Return null if we can not look up the type.
21705 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
21706 the interface types found.
21708 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
21709 interface types found.
21711 * typemanager.cs (GetInterfaces): Make this routine returns alll
21712 the interfaces and work around the lame differences between
21713 System.Type and System.Reflection.Emit.TypeBuilder in the results
21714 result for GetInterfaces.
21716 (ExpandInterfaces): Given an array of interface types, expand and
21717 eliminate repeated ocurrences of an interface. This expands in
21718 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
21721 2002-06-21 Martin Baulig <martin@gnome.org>
21723 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
21726 2002-06-21 Martin Baulig <martin@gnome.org>
21728 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
21729 and called with one of the core types, return the corresponding typebuilder for
21732 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
21735 2002-06-21 Martin Baulig <martin@gnome.org>
21737 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
21738 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
21739 (Expression.ConvertReferenceExplicit): Likewise.
21741 * expression.cs (ElementAccess.DoResolve): Likewise.
21742 (ElementAccess.DoResolveLValue): Likewise.
21744 2002-06-10 Martin Baulig <martin@gnome.org>
21746 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
21747 add the "value" parameter to the parameter list.
21749 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
21752 2002-06-19 Miguel de Icaza <miguel@ximian.com>
21754 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
21755 the argument to an int, uint, long or ulong, per the spec. Also
21756 catch negative constants in array creation.
21758 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
21760 * class.cs: do not allow the same interface to appear twice in
21761 the definition list.
21763 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
21765 * ecore.cs: don't use ldlen with System.Array.
21767 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
21769 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
21771 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
21773 * modifiers.cs: produce correct field attributes for protected
21774 internal. Easy fix so miguel can work on ther harder stuff:-)
21776 2002-06-18 Miguel de Icaza <miguel@ximian.com>
21778 * pending.cs: New file. Move the code from class.cs here.
21779 Support clearning the pending flag for all methods (when not doing
21780 explicit interface implementation).
21782 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
21784 * rootcontext.cs: added a couple more types needed to bootstrap.
21786 2002-06-17 Miguel de Icaza <miguel@ximian.com>
21788 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
21789 constructor in the type, instead of any constructor in the type
21790 hierarchy. Thanks to Paolo for finding this bug (it showed up as
21791 a bug in the Mono runtime when applying the params attribute).
21793 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
21794 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
21796 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
21798 * expression.cs (Unary.ResolveOperator): Use TypeManager
21799 to resolve the type.
21801 2002-06-13 Ravi Pratap <ravi@ximian.com>
21803 * cs-parser.jay (enum_member_declaration): Pass in the attributes
21806 * enum.cs (AddEnumMember): Add support to store the attributes associated
21807 with each member too.
21809 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
21810 field builders too - this takes care of the enum member case.
21812 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
21814 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
21815 address-of operator on both value types and pointers.
21817 2002-06-10 Martin Baulig <martin@gnome.org>
21819 * interface.cs (Interface.PopulateIndexer): Add the indexer's
21820 PropertyBuilder to the `property_builders' list.
21822 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
21823 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
21824 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
21825 find any indexers which are inherited from an interface.
21827 2002-06-09 Martin Baulig <martin@gnome.org>
21829 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
21830 the same type as the constant if necessary. There's also a test-130.cs
21833 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
21835 * typemanager.cs (TypeManager.ChangeType): Previously known as
21836 Enum.ChangeEnumType().
21838 2002-06-09 Martin Baulig <martin@gnome.org>
21840 * expression.cs (Cast.TryReduce): Added support for consts.
21842 2002-06-08 Ravi Pratap <ravi@ximian.com>
21844 * class.cs (Accessor): Hold attributes information so we can pass
21847 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
21848 Modify to pass in attributes attached to the methods.
21850 (add_accessor_declaration, remove_accessor_declaration): Ditto.
21852 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
21853 to handle the Accessor kind :-)
21855 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
21857 2002-06-08 Martin Baulig <martin@gnome.org>
21859 * expression.cs (Unary.TryReduceNegative): Added support for
21862 2002-06-08 Martin Baulig <martin@gnome.org>
21864 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
21865 name can't be found in the `defined_names' - the caller will do a
21866 MemberLookup in this case and thus find methods in System.Enum
21867 such as Enum.IsDefined().
21869 2002-06-08 Martin Baulig <martin@gnome.org>
21871 * enum.cs (Enum.ChangeEnumType): This is a custom version of
21872 Convert.ChangeType() which works with TypeBuilder created types.
21873 (Enum.LookupEnumValue, Enum.Define): Use it here.
21875 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
21876 `TypeBuilder.BaseType != null' check.
21877 (TypeContainer.FindMembers): Only lookup parent members if we
21878 actually have a parent.
21879 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
21880 (ConstructorInitializer.Resolve): Likewise.
21882 * interface.cs (Interface.FindMembers): Added
21883 `TypeBuilder.BaseType != null' check.
21885 * rootcontext.cs (RootContext.ResolveCore): Added
21886 "System.Runtime.CompilerServices.IndexerNameAttribute" to
21887 classes_second_stage.
21889 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
21890 debug_type and trace_type when compiling with --nostdlib.
21892 2002-06-07 Martin Baulig <martin@gnome.org>
21894 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
21895 (AddField): Set it to true when adding a non-static field.
21896 (DefineType): Use `have_nonstatic_fields' to find out whether we
21897 have non-static fields, not `Fields != null'.
21899 2002-06-02 Miguel de Icaza <miguel@ximian.com>
21901 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
21902 dereferencing a null on the static-field code path)
21904 2002-05-30 Martin Baulig <martin@gnome.org>
21906 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
21907 to take command line arguments. Use reflection to call the new
21908 custom `Initialize' function on the symbol writer and pass it the
21909 command line arguments.
21911 * driver.cs (--debug-args): New command line argument to pass command
21912 line arguments to the symbol writer.
21914 2002-05-28 Miguel de Icaza <miguel@ximian.com>
21916 * assign.cs (DoResolve): Forgot to do the implicit conversion to
21917 the target type for indexers and properties. Thanks to Joe for
21920 2002-05-27 Miguel de Icaza <miguel@ximian.com>
21922 * typemanager.cs (MethodFlags): returns the method flags
21923 (Obsolete/ShouldIgnore) that control warning emission and whether
21924 the invocation should be made, or ignored.
21926 * expression.cs (Invocation.Emit): Remove previous hack, we should
21927 not do this on matching a base type, we should do this based on an attribute
21929 Only emit calls to System.Diagnostics.Debug and
21930 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
21931 on the command line.
21933 * rootcontext.cs: Global settings for tracing and debugging.
21935 * cs-tokenizer.cs (define): New utility function to track
21936 defines. Set the global settings for TRACE and DEBUG if found.
21938 2002-05-25 Ravi Pratap <ravi@ximian.com>
21940 * interface.cs (Populate*): Pass in the TypeContainer as well as
21941 the DeclSpace as parameters so that we can create EmitContexts and
21942 then use that to apply attributes etc.
21944 (PopulateMethod, PopulateEvent, PopulateProperty)
21945 (PopulateIndexer): Apply attributes everywhere.
21947 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
21950 (ApplyAttributes): Update accordingly.
21952 We now apply interface attributes for all members too.
21954 2002-05-26 Miguel de Icaza <miguel@ximian.com>
21956 * class.cs (Indexer.Define); Correctly check if we are explicit
21957 implementation (instead of checking the Name for a ".", we
21958 directly look up if the InterfaceType was specified).
21960 Delay the creation of the PropertyBuilder.
21962 Only create the PropertyBuilder if we are not an explicit
21963 interface implementation. This means that explicit interface
21964 implementation members do not participate in regular function
21965 lookups, and hence fixes another major ambiguity problem in
21966 overload resolution (that was the visible effect).
21968 (DefineMethod): Return whether we are doing an interface
21971 * typemanager.cs: Temporary hack until we get attributes in
21972 interfaces (Ravi is working on that) and we get IndexerName
21973 support in interfaces.
21975 * interface.cs: Register the indexers as properties.
21977 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
21978 warning, I have verified that this is a bug in the .NET runtime
21979 (JavaScript suffers of the same problem).
21981 * typemanager.cs (MemberLookup): When looking up members for
21982 interfaces, the parent of an interface is the implicit
21983 System.Object (so we succeed in searches of Object methods in an
21984 interface method invocation. Example: IEnumerable x; x.ToString
21987 2002-05-25 Miguel de Icaza <miguel@ximian.com>
21989 * class.cs (Event): Events should also register if they do
21990 implement the methods that an interface requires.
21992 * typemanager.cs (MemberLookup); use the new GetInterfaces
21995 (GetInterfaces): The code used to lookup interfaces for a type is
21996 used in more than one place, factor it here.
21998 * driver.cs: Track the errors at the bottom of the file, we kept
22001 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
22002 instance if the method we are calling is static!
22004 2002-05-24 Miguel de Icaza <miguel@ximian.com>
22006 * attribute.cs (ApplyAttributes): Make this function filter out
22007 the IndexerName attribute (as that attribute in reality is never
22008 applied) and return the string constant for the IndexerName
22011 * class.cs (TypeContainer.Emit): Validate that all the indexers
22012 have the same IndexerName attribute, and if so, set the
22013 DefaultName attribute on the class.
22015 * typemanager.cs: The return value might contain other stuff (not
22016 only methods). For instance, consider a method with an "Item"
22017 property and an Item method.
22019 * class.cs: If there is a problem with the parameter types,
22022 2002-05-24 Ravi Pratap <ravi@ximian.com>
22024 * ecore.cs (ImplicitConversionExists): Wrapper function which also
22025 looks at user defined conversion after making a call to
22026 StandardConversionExists - we need this for overload resolution.
22028 * expression.cs : Update accordingly the various method calls.
22030 This fixes 2 bugs filed against implicit user defined conversions
22032 2002-05-22 Miguel de Icaza <miguel@ximian.com>
22034 * statement.cs: Track the result of the assignment.
22036 2002-05-21 Miguel de Icaza <miguel@ximian.com>
22038 * expression.cs (MemberAccess): Improved error reporting for
22039 inaccessible members.
22041 2002-05-22 Martin Baulig <martin@gnome.org>
22043 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
22044 itself with debugging support.
22046 2002-05-22 Martin Baulig <martin@gnome.org>
22048 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
22049 Removed, this isn't needed anymore.
22051 2002-05-20 Martin Baulig <martin@gnome.org>
22053 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
22054 be underlying type for an enum.
22056 2002-05-20 Miguel de Icaza <miguel@ximian.com>
22058 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
22059 that splits out the loading of just the core types.
22061 * rootcontext.cs (ResolveCore): Split the struct resolution in
22062 two, so we can load the enumeration underlying types before any
22065 * expression.cs (Is): Bandaid until we fix properly Switch (see
22066 bug #24985 for details).
22068 * typemanager.cs (ImplementsInterface): The hashtable will contain
22069 a null if there are no interfaces implemented.
22071 2002-05-18 Miguel de Icaza <miguel@ximian.com>
22073 * cs-parser.jay (indexer_declarator): It is fine to have array
22076 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22078 * typemanager.cs: (RegisterBuilder): New function used to register
22079 TypeBuilders that implement interfaces. Since
22080 TypeBuilder.GetInterfaces (as usual) does not work with lame
22082 (AddUserType): register interfaces.
22084 (ImplementsInterface): Use the builder_to_ifaces hash if we are
22085 dealing with TypeBuilder. Also, arrays are showing up as
22086 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
22087 methods can not be invoked on them!
22089 * ecore.cs (ExplicitReferenceConversionExists): Made public.
22090 (ImplicitReferenceConversionExists): Split out from
22091 StandardConversionExists.
22093 * expression.cs (As): We were only implementing one of the three
22094 cases for the as operator. We now implement them all.
22095 (Is): Implement the various other cases for Is as well.
22097 * typemanager.cs (CACHE): New define used to control if we want or
22098 not the FindMembers cache. Seems to have a negative impact on
22099 performance currently
22101 (MemberLookup): Nested types have full acess to
22102 enclosing type members
22104 Remove code that coped with instance/static returns for events, we
22105 now catch this in RealFindMembers.
22107 (RealFindMembers): only perform static lookup if the instance
22108 lookup did not return a type or an event.
22110 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22112 * assign.cs (CompoundAssign): We pass more semantic information
22113 now to Compound Assignments than we did before: now we have all
22114 the information at hand, and now we resolve the target *before* we
22115 do the expression expansion, which allows the "CacheValue" method
22116 to have the effect we intended (before, a [x] += 1 would generate
22117 two differen ArrayAccess expressions from the ElementAccess,
22118 during the resolution process).
22120 (CompoundAssign.DoResolve): Resolve target and original_source here.
22122 2002-05-16 Miguel de Icaza <miguel@ximian.com>
22124 * expression.cs (ArrayAccess): dropped debugging information.
22126 * typemanager.cs: Small bug fix: I was always returning i_members,
22127 instead of one of i_members or s_members (depending on which had
22130 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
22131 method is invoked before any code generation takes place, and it
22132 is a mechanism to inform that the expression will be invoked more
22133 than once, and that the method should use temporary values to
22134 avoid having side effects
22136 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
22138 * ecore.cs (Expression.CacheTemporaries): Provide empty default
22141 * expression.cs (Indirection, ArrayAccess): Add support for
22142 CacheTemporaries in these two bad boys.
22144 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
22145 ldobj or ldind_ref.
22146 (StoreFromPtr): Handle stobj as well.
22148 * expression.cs (UnaryMutator): Share more code.
22150 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
22151 down: I was not tracking the Filter function as well, which
22152 was affecting the results of the cache.
22154 2002-05-15 Miguel de Icaza <miguel@ximian.com>
22156 * attribute.cs: Remove the hack to handle the CharSet property on
22159 2002-05-14 Miguel de Icaza <miguel@ximian.com>
22161 * attribute.cs (DoResolve): More uglyness, we now only try to
22162 resolve the attribute partially, to extract the CharSet
22163 information (only if we are a StructLayout attribute). Otherwise
22165 (GetExtraTypeInfo): Add some code to conditionally kill in the
22166 future this. I am more and more convinced that the .NET
22167 framework has special code to handle the attribute setting on
22170 * expression.cs (IsParamsMethodApplicable): Revert my previous
22171 foreach change here, it was wrong.
22173 2002-05-13 Miguel de Icaza <miguel@ximian.com>
22175 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
22176 (pp_expr): do not abort on unknown input, just return.
22177 (eval): abort if there are pending chars.
22179 * attribute.cs (Attribute.Resolve): Positional parameters are
22180 optional. Deal with that case.
22182 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
22183 the Ansi/Unicode/Auto information for the type.
22185 (TypeContainer.DefineType): instantiate the EmitContext here, as
22186 we will be using it during the type definition (to resolve
22187 attributes) and during the emit phase.
22189 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
22190 to pull type information out of the attributes
22192 (Attribute.Resolve): track the constructor builder, and allow for
22193 multiple invocations (structs and classes will use this).
22195 * ecore.cs (MemberLookupFinal): new version with all the
22196 parameters customizable.
22198 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
22199 constructors. Return if the result value is null (as the error
22200 would have been flagged already by MemberLookupFinal)
22202 Do not allow instances of abstract classes or interfaces to be
22205 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
22206 We have to compare the assembly property here when dealing with
22207 FamANDAssem and Assembly access modifiers, because we might be
22208 creating an assembly from *modules* (that means that we are not
22209 getting TypeBuilders for types defined in other modules that are
22210 part of this assembly).
22212 (Method.Emit): If the method is marked abstract and has a body,
22215 (TypeContainer.DefineMembers): If both the defined member and the
22216 parent name match are methods, then do not emit any warnings: let
22217 the Method.Define routine take care of flagging warnings. But if
22218 there is a mismatch (method overrides something else, or method is
22219 overriwritten by something, then emit warning).
22221 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
22222 set to null, this means `do not check for the return type on the
22225 (Method.Define): set the return type for the method signature to
22226 null, so that we get methods with the same name and parameters and
22227 different return types. This is used to flag warning 114 (you are
22228 hiding a method, and you probably want to use the new/override
22231 * typemanager.cs (MemberLookup): Implemented proper access
22232 control, closing a long standing set of bug reports. The problem
22233 was that the Framework only has two bits: Public and NonPublic,
22234 and NonPublic includes private and protected methods, but we need
22235 to enforce the FamANDAssem, FamOrAssem and Family.
22237 2002-05-11 Miguel de Icaza <miguel@ximian.com>
22239 * statement.cs (GotoCase): Return true: Ammounts to giving up
22240 knowledge on whether we return or not, and letting the other case
22241 be responsible for it.
22243 2002-05-10 Miguel de Icaza <miguel@ximian.com>
22245 * driver.cs: Do not load directories for each file processed, only
22246 do it if there is a pattern.
22248 * ecore.cs: Report readonly assigns here as well, as we might have
22249 been resolved only by MemberAccess.
22251 (SimpleName.SimpleNameResolve): Also be useful for LValue
22252 resolution. We need this to propagate assign to local readonly variables
22254 * typemanager.cs: Use a ptrhashtable for the criteria, because we
22255 do not want to reuse potential criteria memory.
22257 * class.cs (MyEventBuilder): Set reflected_type;
22259 * ecore.cs (Constantify): Added support for constifying bools.
22261 (RootContext.LookupType): Added a cache for values looked up in
22262 the declaration space.
22264 * typemanager.cs (FindMembers): Now is a front-end to
22265 RealFindMembers, and provides a two-level hashtable-based cache to
22268 15% performance improvement: from 22.5 to 19.2 seconds.
22270 * expression.cs (IsParamsMethodApplicable): use foreach.
22271 (Invocation.DoResolve): ditto.
22272 (New.DoResolve): ditto.
22273 (ArrayCreation.DoResolve): ditto.
22275 * ecore.cs (FindMostEncompassingType): use foreach.
22277 * delegate.cs (NewDelegate.DoResolve): Use foreach
22279 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
22280 (RemoveMethods): use foreach.
22282 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
22283 nested foreach statements instead of for, and also break out of
22284 the inner loop once a match is found.
22286 (Invocation.OverloadResolve): Use foreach, simplify the code.
22288 2002-05-08 Miguel de Icaza <miguel@ximian.com>
22290 * cfold.cs (BinaryFold): During an enumeration evaluation context,
22291 we actually unwrap the expression to allow for extra information
22294 * expression.cs: Use Shr_Un on unsigned operations.
22296 2002-05-08 Ravi Pratap <ravi@ximian.com>
22298 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
22299 applicable operators was not being considered correctly. This closes
22300 the bug Miguel reported.
22302 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
22304 * attribute.cs: check that the type derives from System.Attribute
22305 and report the correct error in that case (moved the duplicate code to
22306 its own method, too).
22308 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
22310 * attribute.cs: lookup attribute type name as the spec says: first the
22311 bare attribute name and then name + "Attribute" (nant compiles with
22312 mcs after this fix).
22314 2002-05-07 Miguel de Icaza <miguel@ximian.com>
22316 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
22317 Because of the way we parse things, we should try to see if a
22318 UIntConstant can fit in an integer.
22320 2002-05-07 Ravi Pratap <ravi@ximian.com>
22322 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
22323 when we are in an explicit context.
22325 (ConvertReferenceExplicit): When converting from Iface type S to Class
22326 T make sure the rules are implemented as an OR.
22328 * parameter.cs (ParameterType): Make it a property for now although the
22329 purpose really isn't anything immediate.
22331 * expression.cs (Is*Applicable): Do better checking on the parameter type
22332 of a ref/out parameter. The ones from the system assemblies are already
22333 marked with the correct type so we don't need to do any correction.
22335 * ecore.cs (StandardConversionExists): Conversion from Interface types to
22336 the object type is standard too so include that.
22338 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22340 * ecore.cs (StandardConversionExists): Augment with missing code:
22341 deal with IntConstant, LongConstants and Enumerations.
22343 * assign.cs: Report the error, instead of failing silently
22345 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
22346 typecontainer that they are declared, because the
22347 typecontainer/namespace will have the list of using clauses that
22348 need to be applied.
22350 Assembly Attributes were escaping the normal registration
22353 (EmitCode): Apply attributes within an EmitContext that represents
22354 the container they were declared on.
22356 * cs-parser.jay: Track bases for structs. How did I get this wrong?
22358 2002-05-06 Ravi Pratap <ravi@ximian.com>
22360 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
22361 Revamp completely - make much cleaner as we now operate only
22364 (FindMostSpecificSource, FindMostSpecificTarget): New methods
22365 to implement the logic detailed in the spec more correctly.
22367 (UserDefinedConversion): Update accordingly.
22369 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22371 * statement.cs: Return flow analysis information up.
22373 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
22376 (token): Do not consume an extra character before calling
22379 2002-05-06 Piers Haken <piersh@friskit.com>
22381 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
22383 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22385 * class.cs (Constructor.Emit): Set the IsStatic flag in the
22386 EmitContext during the instance constructor initializer
22387 resolution, to stop access to instance variables.
22389 This is mandated by the spec, last paragraph of the `constructor
22390 initializers' section.
22392 2002-05-05 Miguel de Icaza <miguel@ximian.com>
22394 * cs-parser.jay, class.cs (Accessor): new class used to represent
22395 an accessor (get or set). In the past we used `null' to represent
22396 a missing accessor. But this is ambiguous because there was no
22397 way to tell in abstract indexers/properties if one of them was
22400 Now there is a way of addressing that.
22402 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
22403 instead of FindMembers.
22405 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
22406 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
22408 * attribute.cs: Treat indexers and properties as the same in terms
22409 of applying attributes
22411 * ecore.cs (FindMostEncompassedType): Use statically initialized
22412 EmptyExpressions()s like we do elsewhere to avoid creating useless
22413 objects (and we take this out of the tight loop).
22415 (GetConversionOperators): Move the code to extract the actual
22416 operators to a separate routine to clean things up.
22418 2002-05-04 Miguel de Icaza <miguel@ximian.com>
22420 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
22421 events are always registered FieldBuilders.
22423 * class.cs (FieldBase): New class shared by Fields
22425 * delegate.cs: If we are a toplevel delegate, use our full name.
22426 If we are a nested delegate, then only use our tail name.
22428 2002-05-02 Ravi Pratap <ravi@ximian.com>
22430 * expression.cs (IsApplicable): Ensure that we add the "&" to
22431 ref/out types before comparing it with the type of the argument.
22433 (IsParamsMethodApplicable): Ditto.
22435 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
22438 * delegate.cs : Handle the case when we have more than one applicable
22439 method. Flag an error only when we finish checking all.
22441 2002-05-02 Miguel de Icaza <miguel@ximian.com>
22443 * expression.cs: Add support for boolean static initializers.
22445 2002-05-01 Miguel de Icaza <miguel@ximian.com>
22447 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
22449 * parameter.cs (ComputeParameterTypes,
22450 ComputeAndDefineParameterTypes): Better error handling: now we
22451 clear the `types' cache if we fail during any of the type lookups.
22452 We also return the status code correctly to our caller
22454 * delegate.cs: If we fail to define a delegate, abort the extra
22457 * expression.cs (Binary.ResolveOperator): for
22458 operator==(object,object) and operator !=(object, object) we also
22459 have to verify that there is an implicit conversion from one to
22462 (ArrayAccess.DoResolve): Array Access can operate on
22465 2002-04-30 Miguel de Icaza <miguel@ximian.com>
22467 * assign.cs (CompoundAssign): A new class used as a "flag" that
22468 the assignment actually is happening as part of a compound
22469 assignment operator.
22471 During compound assignment, a few new rules exist to enable things
22478 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
22479 to the type of x) if y is implicitly convertible to the type of x,
22480 and the operator is a builtin operator and the return type of the
22481 operator is explicitly convertible to the type of x.
22483 * rootcontext.cs: Reset warning level to 2. 4 catches various
22484 "interesting" features in mcs, we must clean this up at some
22485 point, but currently am trying to kill other bugs ;-)
22487 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
22488 in container classes as well.
22490 * expression.cs (Binary.ResolveOperator): Handle string case
22491 before anything else (as operator overloading does emit an error
22492 before doing anything else).
22494 This code could go away when we move to a table driven model, but
22495 i could not come up with a good plan last night.
22497 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
22499 * typemanager.cs (CSharpName): reimplementation using regex.
22500 * class.cs: added null check for fields in Emit
22501 * rootcontext.cs: set warninglevel to 4
22503 2002-04-29 Miguel de Icaza <miguel@ximian.com>
22505 * typemanager.cs (CSharpName): reimplemented with Lupus
22508 2002-04-28 Miguel de Icaza <miguel@ximian.com>
22510 * statement.cs (If): correclty implement Resolve, because we were
22511 not catching sem errors in there. The same process is needed
22513 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
22516 (Statement.Warning_DeadCodeFound): Factorize code.
22517 (While): Report dead code here too.
22519 (Statement): Added Resolve virtual method to allow
22520 for resolution split from the emit code.
22522 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22524 * statement.cs (EmitBoolExpression): No longer try to resolve the
22526 (MakeBoolean): New utility function that resolve, implicitly
22527 converts to boolean and tags the expression.
22530 (If, Do): Implement dead code elimination.
22531 (While): Implement loop inversion
22533 (Do, While, For, If): Resolve the expression prior to calling our
22536 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
22539 - added method Report28 (warning: program has more than one entry point)
22540 - added method IsEntryPoint, implements paragraph 10.1 of the spec
22541 - modified method Method.Define, the part at the end of the method
22543 * rootcontext.cs: added static public Location EntryPointLocation;
22545 * ../errors/cs0028.cs : Add test case for the above warning.
22548 - modified method CSharpName to allow arrays of primitive type to
22549 be printed nicely (e.g. instead of System.Int32[][] it now prints
22551 - added method CSharpSignature: returns the signature of a method
22552 in string format to be used in reporting errors, warnings, etc.
22554 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
22557 2002-04-26 Ravi Pratap <ravi@ximian.com>
22559 * delegate.cs (Define): Fix extremely silly bug where I was
22560 setting the type of the 'object' parameter of the BeginInvoke
22561 method to System.IAsyncResult instead of System.Object ;-)
22563 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22565 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
22568 (Constructor.Emit): return if we fail to initialize the
22569 constructor. Another door closed!
22571 * expression.cs (New.DoResolve): Improve error message (from -6 to
22572 1501). Use DeclaredOnly lookup to find the exact constructor.
22574 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
22575 loop. This is useful.
22577 * cs-parser.jay: Adjust the default parameters so that destructors
22578 have the proper signature.
22580 2002-04-26 Martin Baulig <martin@gnome.org>
22582 * driver.cs (LoadAssembly): If `assembly' contains any characters
22583 which are only valid in path names and not in assembly names
22584 (currently slash, backslash and point), use Assembly.LoadFrom ()
22585 instead of Assembly.Load () on the `assembly' (before iteration
22586 over the link_paths).
22588 2002-04-26 Martin Baulig <martin@gnome.org>
22590 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
22592 2002-04-25 Miguel de Icaza <miguel@ximian.com>
22594 * class.cs (Property): use the new typemanager.MemberLookup
22596 (TypeContainer.MemberLookup): Implement using the
22597 TypeManager.MemberLookup now.
22599 * typemanager.cs: Make MemberLookup a function of the TypeManager,
22600 and return MemberInfos, so that these can be used without an
22601 EmitContext (what we had before).
22603 2002-04-24 Miguel de Icaza <miguel@ximian.com>
22605 * expression.cs: Fix the case where the argument to params if the
22606 type of the params. I omitted handling this before. Fixed
22608 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22610 * driver.cs: Call BootCorlib_PopulateCoreType
22612 * class.cs (Property.CheckBase): Check for properties only, not
22615 * interface.cs: Temporary hack: try/catch around the
22616 CustomAttributeBuilder, because I am getting an exception that I
22619 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
22620 types whose definitions are required to be there (attributes are
22621 defined before standard types).
22623 Compute definitions as we boot the various types, as they are used
22624 immediately (value_type class will need object_type, but if we do
22625 not initialize object_type, we will pass a null, which will let
22626 the runtime pick the System.Object from the existing corlib, which
22627 is not what we want).
22629 2002-04-22 Patrik Torstensson <totte@labs2.com>
22631 * cs-tokenizer.cs: fixed a number of trim() issues.
22633 2002-04-22 Ravi Pratap <ravi@ximian.com>
22635 * expression.cs (Argument.Type): Ensure that we return the correct
22636 type when we have out or ref parameters [in which case we
22639 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22641 * class.cs (Property, Indexer): Allow extern modifier in there.
22643 * typemanager.cs (InitBaseTypes): Initializes object_type and
22644 value_type, since those will be used early on during the bootstrap
22645 process to compile corlib.
22647 (InitCoreTypes): Move code from here to InitBaseTypes.
22649 2002-04-21 Miguel de Icaza <miguel@ximian.com>
22651 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
22652 single-dimension arrays as using the ldlen opcode.
22654 Daniel Lewis discovered this optimization.
22656 * typemanager.cs: Add signature for System.Array::get_Length
22658 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22660 * statement.cs: report the error when the foreach does not apply to an
22661 array nor a collection.
22663 2002-04-19 Miguel de Icaza <miguel@ximian.com>
22665 * expression.cs: Add implicit conversions to the operator ~.
22667 * constant.cs (DecimalConstant.Emit): Emit decimal value.
22669 * typemanager.cs: Locate the decimal constructor.
22671 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22673 * attribute.cs: use the new property of TypeOf.
22674 * expression.cs: added 'get' property around typearg.
22676 These changes fix a build breaker reported by NickD. Is this the
22677 correct way to fix? If not, please, revert my changes and make it
22680 2002-04-17 Miguel de Icaza <miguel@ximian.com>
22682 * attribute.cs: Add support for typeof in attribute invocations.
22683 I am not sure that this is right though.
22685 2002-04-14 Duncan Mak <duncan@ximian.com>
22687 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
22688 Binary.Operator.Division case.
22690 2002-04-13 Ravi Pratap <ravi@ximian.com>
22692 * class.cs (DefineType): Ensure that we do a proper check on
22693 attribute types and also register it with the TypeManager.
22695 (TypeContainer.Targets): The default for attribute types is
22696 AttributeTargets.All.
22698 * attribute.cs (ApplyAttributes): Registering the attribute type
22699 is done elsewhere, not when we discover we have a Usage attribute.
22701 2002-04-12 Ravi Pratap <ravi@ximian.com>
22703 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
22704 and get rid of is_delegate parameter.
22706 * everywhere : update.
22708 2002-04-12 Ravi Pratap <ravi@ximian.com>
22710 * cs-parser.jay (compilation_unit): Revamp completely to use
22711 some new ideas that I got from Rhys' grammar to solve the problems
22712 with assembly level attributes.
22714 (outer_declaration): New grammar production.
22716 (attribute_sections): Add.
22718 (opt_attributes): Base on attribute_sections
22720 (namespace_declaration): Allow opt_attributes to tackle the case
22721 when we have assembly level attributes - we are clever in this
22724 * attribute.cs (ApplyAttributes): Do not worry about assembly
22725 attributes in the non-global context.
22727 * rootcontext.cs (AddGlobalAttributes): Go back to using this
22728 instead of SetGlobalAttributes.
22730 * class.cs, rootcontext.cs : Ensure we define and generate
22731 attribute types before anything else.
22733 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
22734 and flag the new error -20 for the case when the attribute type
22735 does not have valid targets specified. csc does not catch this.
22737 * ../errors/errors.txt : update for error # -20
22739 2002-04-11 Ravi Pratap <ravi@ximian.com>
22741 * support.cs (InternalParameters.ParameterModifier): Do some null
22742 checking and return sane values.
22744 * class.cs (Method.Define): If we are a PInvoke method, ensure
22745 that we are static and extern. Report error # 601
22747 * ../errors/cs0601.cs : Add test case for the above error.
22749 2002-04-07 Ravi Pratap <ravi@ximian.com>
22751 * rootcontext.cs (attribute_types): We need to keep type of
22752 all attribute types separately and emit code for them first.
22754 (RegisterAttribute) : Implement.
22756 * class.cs (DefineType): Check if the current Type is a custom
22757 attribute type and register it accordingly.
22759 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
22760 adding the first attribute twice and rename to
22762 (SetGlobalAttributes): this.
22764 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
22767 * attribute.cs (ApplyAttributes): Take an additional argument telling us
22768 if we are processing global arguments. Hmm, I am unsure of this.
22770 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22772 * expression.cs: added static array of strings to avoid calling
22773 Enum.ToString () for Operator in Binary. Significant recover of
22776 2002-04-10 Miguel de Icaza <miguel@ximian.com>
22778 * class.cs (FindMembers): Allow the Builders of the various
22779 members to be null. If they are skip them. This only happens
22780 during the PInvoke declaration.
22782 2002-04-09 Miguel de Icaza <miguel@ximian.com>
22784 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
22785 failure, so we do not keep going afterwards.
22787 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
22788 wanted to pass `false' as the `is_delegate' argument. If this is
22789 the case, why not use delegate_type == null to mean `is_delegate =
22790 false' and anything else as is_delegate = true.
22792 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
22794 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
22795 code for the section, not the beginning of the tests.
22797 2002-04-08 Miguel de Icaza <miguel@ximian.com>
22799 * cfold.cs: Handle operator + (Enum x, Underlying x)
22801 * expression.cs (Binary): same. Warn about errors where we have
22802 Enum/Enum in operator + as well.
22804 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
22807 - added support for switch(bool)
22808 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
22809 - add TableSwitchEmit() to handle table-based switch statements
22811 2002-04-05 Ravi Pratap <ravi@ximian.com>
22813 * expression.cs (Invocation.OverloadResolve): Factor out code which
22814 does parameter compatibility checking with arguments so that we can
22815 re-use the code even from Delegate.VerifyApplicability
22817 (VerifyArgumentsCompat): Move above code here.
22819 * delegate.cs (VerifyApplicability): Get rid of duplicate code
22820 and instead make a call to the above method.
22822 2002-03-31 Ravi Pratap <ravi@ximian.com>
22824 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
22825 We use it to keep track of classes which are attribute types.
22827 2002-04-02 Miguel de Icaza <miguel@ximian.com>
22829 * delegate.cs (Delegate.Define): Correctly define the types in the
22830 presence of fixed and array parameters.
22832 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
22835 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
22836 include NonPublic after the first iteration.
22838 * class.cs (Indexer.CheckBase): Only check if both parents are
22841 * cs-parser.jay (accessor_body): If empty, set to null.
22843 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
22844 same code path here to resolve constants names that we did have in
22845 MemberAccess.DoResolve. There is too much code duplicated here.
22847 2002-04-01 Miguel de Icaza <miguel@ximian.com>
22849 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
22851 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
22854 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
22855 tokens, numbers and strings.
22857 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
22860 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
22861 asyncronous parameters and the regular parameters.
22863 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
22864 specify the target directory.
22866 * expression.cs: (This.DoResolve): Simplify
22867 (As.Emit): Optimize, do not generate IsInst if the expression is
22868 always of the given type.
22870 (Is.DoResolve): Bug fix, we were reporting both always/never for
22873 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
22874 creating too many unnecessary arrays.
22876 2002-03-31 Miguel de Icaza <miguel@ximian.com>
22878 * class.cs (EmitFieldInitializer): Use Assign expression to assign
22879 fields instead of rolling our own initializer. Takes care of all
22880 implicit conversions, and drops unnecessary static checks/argument.
22882 2002-03-31 Dick Porter <dick@ximian.com>
22884 * driver.cs: use the GetDirectories() return values properly, and
22885 use "/" as path separator.
22887 2002-03-30 Miguel de Icaza <miguel@ximian.com>
22889 * expression.cs (Unary): Optimize - - expr into expr.
22890 (Binary): Optimize a + (-b) into a -b.
22892 * codegen.cs (CodeGen): Made all methods static.
22894 2002-03-29 Miguel de Icaza <miguel@ximian.com>
22898 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
22899 TypeBuilder property.
22901 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
22904 * tree.cs: Removed the various RecordXXXX, and replaced with a
22905 single RecordDecl. Removed all the accessor methods, and just
22906 left a single access point Type
22908 * enum.cs: Rename DefineEnum to DefineType.
22910 * decl.cs: New abstract method `DefineType' used to unify the
22911 Defines for Enumerations, Interfaces, TypeContainers and
22914 (FindType): Moved LookupInterfaceOrClass here. Moved the
22915 LookupBaseClasses method that used to live in class.cs and
22916 interface.cs here, and renamed to FindType.
22918 * delegate.cs: Implement DefineType. Take advantage of the
22919 refactored pattern for locating the parent builder without taking
22920 the parent_builder argument (which we know does not work if we are
22921 nested, and triggering a toplevel definition).
22923 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22925 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
22926 accessibility of a member has changed during override and report
22929 * class.cs (Method.Define, Property.Define): Only complain on
22930 overrides if the method is private, any other accessibility is
22931 fine (and since we just checked the permission is the same, we are
22934 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
22935 and elif are processed always. The other pre-processing
22936 directives are only processed if we are "taking" the path
22938 2002-03-29 Martin Baulig <martin@gnome.org>
22940 * class.cs (Method.Emit): Only emit symbolic debugging info if the
22941 current location is not Null.
22943 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
22944 a separate method so we can profile it.
22946 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
22947 `span.Seconds' are just seconds, but no minutes or hours.
22948 (MainDriver): Profile the CodeGen.SaveSymbols calls.
22950 2002-03-28 Miguel de Icaza <miguel@ximian.com>
22952 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
22953 Remove the gratuitous set of Final:
22955 // If an interface implementation, then we can set Final.
22956 if (((flags & MethodAttributes.Abstract) == 0) &&
22957 implementing.DeclaringType.IsInterface)
22958 flags |= MethodAttributes.Final;
22960 I do not know what I was smoking when I used that.
22963 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
22964 step into fixing the name resolution issues for delegates and
22965 unifying the toplevel name resolution.
22967 2002-03-28 Martin Baulig <martin@gnome.org>
22969 * class.cs (Method.Emit): If we have a symbol writer, call its
22970 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
22971 tell it about the current method.
22973 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
22974 writer that we're going to emit the first byte of IL code for a new
22975 statement (a new source line).
22976 (EmitContext.EmitTopBlock): If we have a symbol writer, call
22977 EmitContext.Mark() before emitting any code.
22979 * location.cs (SymbolDocument): Return null when we're Null.
22981 * statement.cs (Statement): Moved the `Location loc' variable here.
22982 (Statement.EmitBoolExpression): If we have a symbol writer, call
22983 ec.Mark() before emitting any code to tell it that we're at the
22984 beginning of a new statement.
22985 (StatementExpression): Added `Location' argument to the constructor.
22986 (Block): Added public readonly variable `StartLocation' and public
22987 variable `EndLocation'. The latter is to be set using SetEndLocation().
22988 (Block): Added constructor which takes a start and end location.
22989 (Block.SetEndLocation): New method. This sets the end location.
22990 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
22991 local variables we create.
22992 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
22993 each statement and do also mark the begin and end of the block.
22995 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
22996 tell it the current lexer.Location, use Location.Null for the end of the
22998 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
22999 current block, set its end location using SetEndLocation().
23000 (statement_expression): StatementExpression constructor now takes the
23001 lexer.Location as additional argument.
23002 (for_statement, declare_local_variables): Likewise.
23003 (declare_local_variables): When creating a new implicit block, use the
23004 new Block constructor and pass it the lexer.Location.
23006 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23008 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
23009 members also on the parent interfaces recursively.
23011 2002-03-27 Miguel de Icaza <miguel@ximian.com>
23013 * report.cs: Use new formats, since Gonzalo finished the missing
23016 * expression.cs (Binary.ResolveOperator): added missing operator|
23017 operator& and operator^ for bool/bool.
23019 * cs-parser.jay: CheckDef now takes a Location argument that is
23020 used to report errors more precisly (instead of reporting the end
23021 of a definition, we try to track something which is a lot closer
23022 to the source of the problem).
23024 * cs-tokenizer.cs: Track global token use, so we can properly flag
23025 the use of #define/#undef after the first token has been seen.
23027 Also, rename the reportXXXX to Error_DescriptiveName
23029 * decl.cs (DeclSpace.IsTopLevel): Move property here from
23030 TypeContainer, so that Enum and Interface can use this too.
23032 * class.cs (TypeContainer.LookupInterfaceOrClass,
23033 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
23034 `builder' argument. Typically this was used to pass the parent
23035 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
23038 The problem is that a nested class could trigger the definition of
23039 a toplevel class, and the builder would be obviously wrong in that
23042 So we drop this argument, and we compute dynamically the
23043 TypeBuilder/ModuleBuilder (the correct information was available
23044 to us anyways from DeclSpace.Parent)
23046 * interface.cs (Interface.DefineInterface): Drop builder
23047 parameter cleanup like class.cs
23049 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
23052 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
23055 (Try.Emit): Propagate the returns value from the statement.
23057 (Return.Emit): Even if we are leavning
23059 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
23061 * modifiers.cs: Fix the computation of MethodAttributes flags.
23063 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
23065 * driver.cs: allow compilation of files that start with '/'.
23066 Add a default case when checking the argument of --target.
23068 2002-03-25 Miguel de Icaza <miguel@ximian.com>
23070 * interface.cs: Implement the same search algorithm for types in
23071 the interface code.
23073 * delegate.cs: Do not allow multiple definition.
23075 * Recovered ChangeLog that got accidentally amputated
23077 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
23079 * rootcontext.cs: Load manually enum to allow core classes to
23080 contain enumerations.
23082 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
23083 Update to new static methods in TypeManager.
23085 * typemanager.cs (GetMethod, GetConstructor): Use our
23086 implementation of FindMembers to find the members, since during
23087 corlib compilation, the types are TypeBuilders and GetMethod and
23088 GetConstructor do not work.
23090 Make all methods in TypeManager static.
23092 (InitCodeHelpers): Split the functionality from
23093 the InitCodeTypes function.
23095 * driver.cs: Call InitCodeHelpers after we have populated the
23098 * cs-parser.jay (delegate_declaration): we did not used to compute
23099 the delegate name correctly for void delegates.
23101 2002-03-24 Miguel de Icaza <miguel@ximian.com>
23103 * rootcontext.cs (RootContext): Init the interface_resolve_order
23104 and type_container_resolve_order always.
23106 (ResolveCore, BootstrapCorlib_ResolveClass,
23107 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
23108 compiler when compiling with --nostdlib
23110 * class.cs (TypeContainer.DefineType): Check that our parent is
23111 not null. This test is most important when we are bootstraping
23114 * codegen.cs: Split out the symbol writing code.
23116 2002-03-25 Martin Baulig <martin@gnome.org>
23118 * driver.cs (-g): Made -g an alias for --debug.
23120 2002-03-24 Martin Baulig <martin@gnome.org>
23122 * codegen.cs (SymbolWriter): New public variable. Returns the
23123 current symbol writer.
23124 (CodeGen): Added `bool want_debugging_support' argument to the
23125 constructor. If true, tell the ModuleBuild that we want debugging
23126 support and ask it for the ISymbolWriter.
23127 (Save): If we have a symbol writer, call it's Close() method after
23128 saving the assembly.
23130 * driver.c (--debug): New command line argument to create a
23131 debugger information file.
23133 * location.cs (SymbolDocument): New public property. Returns an
23134 ISymbolDocumentWriter object for the current source file or null
23135 if we don't have a symbol writer.
23137 2002-03-21 Miguel de Icaza <miguel@ximian.com>
23139 * driver.cs (LoadAssembly): Correctly return when all the paths
23140 have been tried and not before.
23142 * statement.cs (Switch.Emit): return the actual coverage for this
23143 statement (returns/not-returns)
23145 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
23146 switch of the statement if we are the last switch section. That
23147 kills two problems: try/catch problems (we used to emit an empty
23148 nop at the end) and switch statements where all branches would
23151 2002-03-19 Miguel de Icaza <miguel@ximian.com>
23153 * driver.cs: Add default assemblies (the equivalent to the
23154 Microsoft CSC.RSP file)
23156 * cs-tokenizer.cs: When updating `cols and setting it to zero,
23157 also update tokens_seen and set it to false.
23159 * driver.cs: Implement --recurse for Mike.
23161 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
23162 correctly splitting out the paths.
23164 2002-03-18 Miguel de Icaza <miguel@ximian.com>
23166 * interface.cs (Interface.PopulateProperty): Instead of using
23167 `parent' as the declaration space for the set parameters, use
23170 * support.cs (InternalParameters): InternalParameters constructor
23171 takes a DeclSpace instead of a TypeContainer.
23173 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
23174 types are being initialized, load the address of it before calling
23177 (New): Provide a mechanism to disable the generation of local
23178 value type temporaries when the caller will be providing us with
23179 an address to store it.
23181 (ArrayCreation.EmitDynamicInitializers): Use it.
23183 2002-03-17 Miguel de Icaza <miguel@ximian.com>
23185 * expression.cs (Invocation.EmitArguments): Only probe for array
23186 property if there is more than one argument. Sorry about that.
23188 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
23189 empty param arrays.
23191 * class.cs (Method.LabelParameters): Fix incorrect code path that
23192 prevented the `ParamArrayAttribute' from being applied to the
23195 2002-03-16 Miguel de Icaza <miguel@ximian.com>
23197 * support.cs (ReflectionParameters): Correctly compute whether the
23198 last argument is a params array. Fixes the problem with
23201 * typemanager.cs: Make the assemblies array always be non-null
23202 (empty, but non-null)
23204 * tree.cs (RecordDecl): New function that abstracts the recording
23205 of names. This reports error 101, and provides a pointer to the
23206 previous declaration. Fixes a crash in the compiler.
23208 * cs-parser.jay (constructor_declaration): Update to new grammar,
23209 and provide a constructor_body that can be empty.
23211 2002-03-15 Miguel de Icaza <miguel@ximian.com>
23213 * driver.cs: Add support for --resources.
23215 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
23216 Make all types for the various array helper methods be integer.
23218 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
23219 CheckState to ConvCast.
23221 (ConvCast): Now it takes a `checked' state argument, to avoid
23222 depending on the emit context for the conversion, and just using
23223 the resolve time setting.
23225 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
23226 instead of Invocation.EmitArguments. We do not emit the original
23227 arguments, instead we emit those which have been converted to
23228 unsigned int expressions.
23230 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
23232 * codegen.cs: ditto.
23234 * expression.cs (LocalVariableReference): Drop the use of the
23235 Store function that depended on the variable index.
23237 * statement.cs (VariableInfo): Drop the `Idx' property from this
23238 class, as this is not taking into account the indexes for
23239 temporaries tat we generate during the execution, getting the
23242 * class.cs: First emit class initializers, then call the parent
23245 * expression.cs (Binary): Fix opcode emision.
23246 (UnaryMutator.EmitCode): Support checked code generation
23248 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
23249 matches for events for both the Static and Instance scans,
23250 pointing to the same element. Fix that.
23252 2002-03-14 Miguel de Icaza <miguel@ximian.com>
23254 * rootcontext.cs (ResolveTree): Always set the
23255 interface_resolve_order, because nested interfaces will be calling
23258 * class.cs (GetInterfaceOrClass): Track the same resolution
23259 process used by TypeManager.LookupType. This fixes the nested
23260 type lookups in class declarations (separate path from
23263 (TypeContainer.DefineType): Also define nested interfaces.
23264 (TypeContainer.RegisterOrder): New public function used to
23265 register the order in which child interfaces need to be closed.
23267 Nested interfaces need to be closed after their parents have been
23270 * interface.cs (InterfaceAttr): Put all the logic for computing
23271 the interface attribute here.
23273 (DefineInterface): Register our interface order with the
23274 RootContext or with the TypeContainer depending on the case.
23276 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23278 * cs-parser.jay: rework foreach statement to work with the new
23279 changes to the policy on SimpleNames.
23281 * report.cs: support Stacktrace on warnings as well.
23283 * makefile: drop --unsafe and /unsafe from the compile.
23285 2002-03-13 Ravi Pratap <ravi@ximian.com>
23287 * ecore.cs (StandardConversionExists): Modify to take an Expression
23288 as the first parameter. Ensure we do null -> reference type conversion
23291 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
23292 temporary Expression objects.
23294 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
23296 * interface.cs: workaround bug in method overloading resolution
23297 (there is already a bugzilla bug for it).
23299 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23301 We could also solve this problem by having a separate path for
23302 performing type lookups, instead of DoResolve, we could have a
23303 ResolveType entry point, and only participating pieces of the
23304 production (simplename, deref, array) would implement this.
23306 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
23307 signal SimpleName to only resolve type names and not attempt to
23308 resolve anything else.
23310 * expression.cs (Cast): Set the flag.
23312 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
23314 * class.cs: Only report 108 if there is no `new' modifier.
23316 * cs-parser.jay: rework foreach statement to work with the new
23317 changes to the policy on SimpleNames.
23319 * report.cs: support Stacktrace on warnings as well.
23321 * makefile: drop --unsafe and /unsafe from the compile.
23323 2002-03-11 Miguel de Icaza <miguel@ximian.com>
23325 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23326 lookups here, instead of doing that at parse time. This means
23327 that our grammar will not introduce `LocalVariableReferences' as
23328 expressions at this point. That solves the problem of code like
23332 static void Main ()
23336 This is only half the fix. The full fix requires parameters to
23337 also be handled in this way.
23339 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
23340 makes the use more obvious of the DeclSpace. The
23341 ec.TypeContainer.TypeBuilder is now only used to pull the
23342 TypeBuilder for it.
23344 My theory is that I can get rid of the TypeBuilder completely from
23345 the EmitContext, and have typecasts where it is used (from
23346 DeclSpace to where it matters).
23348 The only pending problem is that the code that implements Aliases
23349 is on TypeContainer, and probably should go in DeclSpace.
23351 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23352 lookups here, instead of doing that at parse time. This means
23353 that our grammar will not introduce `LocalVariableReferences' as
23354 expressions at this point. That solves the problem of code like
23358 static void Main ()
23362 This is only half the fix. The full fix requires parameters to
23363 also be handled in this way.
23365 * class.cs (Property.DefineMethod): When implementing an interface
23366 method, set newslot, when implementing an abstract method, do not
23367 set the flag (before we tried never setting it, or always setting
23368 it, which is the difference).
23369 (Indexer.DefineMethod): same.
23370 (Method.DefineMethod): same.
23372 * ecore.cs: Only set the status used flag if we get back a Field.
23374 * attribute.cs: Temporary hack, so Paolo can keep working.
23376 2002-03-08 Ravi Pratap <ravi@ximian.com>
23378 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
23379 the unmanaged type in the case we have a MarshalAs attribute.
23381 (Resolve): Handle the case when we are parsing the special MarshalAs
23382 attribute [we need to store the unmanaged type to use later]
23384 * typemanager.cs (marshal_as_attr_type): Built in type for the
23385 MarshalAs Attribute.
23387 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
23388 on parameters and accordingly set the marshalling info.
23390 2002-03-09 Miguel de Icaza <miguel@ximian.com>
23392 * class.cs: Optimizing slightly by removing redundant code after
23393 we switched to the `NoTypes' return value.
23394 (Property.DefineMethod): use NoTypes here too.
23396 This fixes the bug I introduced in my last batch of changes.
23398 2002-03-05 Ravi Pratap <ravi@ximian.com>
23400 * tree.cs (RecordEnum): Add. We now keep track of enums too.
23402 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
23403 Enums since those are types too.
23405 * cs-parser.jay (enum_declaration): Record enums as we parse them.
23407 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
23408 thanks to a call during the lookup process.
23410 2002-03-07 Miguel de Icaza <miguel@ximian.com>
23412 * statement.cs (Foreach): Lots of work to accomodate a particular
23413 kind of foreach statement that I had not kept in mind. It is
23414 possible to have foreachs on classes that provide a GetEnumerator
23415 method that return objects that implement the "pattern" for using
23416 a foreach, there is no need to support GetEnumerator
23419 This is needed to compile nant.
23421 * decl.cs: Only report 114 if the member is not `Finalize' and if
23422 the warning level is at least 2.
23424 * class.cs: Moved the compare function from Method to
23427 (MethodSignature.InheritableMemberSignatureCompare): Add new
23428 filter function that is used to extract inheritable methods from a
23431 (Method.Define): Use the new `inheritable_method_signature_filter'
23434 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
23437 2002-03-06 Miguel de Icaza <miguel@ximian.com>
23439 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
23441 * cs-parser.jay: Add opt_semicolon to the interface declaration.
23443 * expression.cs: Pass location information to
23444 ConvertImplicitStandard.
23446 * class.cs: Added debugging code to track return values from
23449 2002-03-05 Miguel de Icaza <miguel@ximian.com>
23451 * expression.cs (Is.DoResolve): If either side of the `is' is an
23452 interface, do not flag the warning.
23454 * ecore.cs (ImplicitReferenceConversion): We need a separate test
23457 * report.cs: Allow for --fatal to be used with --probe.
23459 * typemanager.cs (NoTypes): Move the definition for the empty Type
23462 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
23464 (TypeContainer.DefineProxy): New function used to proxy to parent
23465 implementations when implementing interfaces.
23466 (TypeContainer.ParentImplements): used to lookup if our parent
23467 implements a public function that is required by an interface.
23468 (TypeContainer.VerifyPendingMethods): Hook this up.
23470 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
23471 `modules' and `assemblies' arraylists into arrays. We only grow
23472 these are the very early start up of the program, so this improves
23473 the speedof LookupType (nicely measured).
23475 * expression.cs (MakeByteBlob): Replaced unsafe code with
23476 BitConverter, as suggested by Paolo.
23478 * cfold.cs (ConstantFold.Binary): Special case: perform constant
23479 folding of string concatenation, but if either side is a string,
23480 and the other is not, then return null, and let the runtime use
23481 the concatenation on the string plus the object (using
23482 `Object.ToString').
23484 2002-03-04 Miguel de Icaza <miguel@ximian.com>
23486 Constant Folding has been implemented now.
23488 * expression.cs (Unary.Reduce): Do not throw an exception, catch
23489 the error instead on types that are not supported in one's
23492 * constant.cs (Constant and all children): New set of functions to
23493 perform implict and explicit conversions.
23495 * ecore.cs (EnumConstant): Implement the new functions to perform
23496 conversion by proxying to the child expression.
23498 * codegen.cs: (ConstantCheckState): Constant evaluation has its
23499 own separate setting that can not be turned off from the command
23500 line using --unchecked or --checked and is only controlled using
23501 the checked/unchecked statements and expressions. This setting is
23502 used by the constant folder to flag errors.
23504 * expression.cs (CheckedExpr, UncheckedExpr): Set the
23505 ConstantCheckState as well.
23507 During Resolve, they also have to flag the state, because the
23508 constant folder runs completely in the Resolve phase.
23510 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
23513 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23515 * cfold.cs: New file, this file contains the constant folder.
23517 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
23518 argument to track whether we are using the resulting address to
23519 load or store a value and provide better error messages.
23521 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
23522 new AddressOf arguments.
23524 * statement.cs (Foreach.EmitCollectionForeach): Update
23526 * expression.cs (Argument.Emit): Call AddressOf with proper
23527 arguments to track usage.
23529 (New.DoEmit): Call AddressOf with new arguments.
23531 (Unary.Emit): Adjust AddressOf call.
23533 2002-03-01 Ravi Pratap <ravi@ximian.com>
23535 * cs-parser.jay (member_access): Change the case for pre-defined types
23536 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
23539 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
23542 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
23543 essentially like methods and apply attributes like MethodImplOptions to them too.
23545 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
23548 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
23549 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
23552 * Update code everywhere accordingly.
23554 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
23556 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
23558 2002-02-28 Ravi Pratap <ravi@ximian.com>
23560 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
23561 try performing lookups against those instead of jumping straight into using
23562 the 'using' clauses.
23564 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
23566 (LookupType): Perform lookups in implicit parents too.
23568 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
23569 sequence as RootContext.LookupType.
23571 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
23572 the various cases of namespace lookups into this method.
23574 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23576 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
23577 in positional arguments)
23579 * class.cs (Operator): Update the AllowedModifiers to contain
23582 * cs-parser.jay: Update operator declaration to allow for the
23583 operator body to be empty.
23585 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
23588 2002-02-27 Miguel de Icaza <miguel@ximian.com>
23590 * class.cs (Method.Emit): Label parameters.
23592 * driver.cs: Return 1 or 0 as the program exit code.
23594 2002-02-26 Miguel de Icaza <miguel@ximian.com>
23596 * expression.cs: Special case the `null' object when trying to
23597 auto-compute the type, as anything can be explicitly converted to
23600 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
23601 spotting this Paolo.
23603 (Expression.ImplicitNumericConversion): Perform comparissions of
23604 the type using the underlying type in the case of an enumeration
23605 rather than using the enumeration type for the compare.
23607 Cope with the underlying == type case, which is not possible to
23610 (Expression.ConvertNumericExplicit): Perform comparissions of
23611 the type using the underlying type in the case of an enumeration
23612 rather than using the enumeration type for the compare.
23614 * driver.cs: If the user does not supply an extension, assume .exe
23616 * cs-parser.jay (if_statement): Rewrote so that we can track the
23617 location for the if statement.
23619 * expression.cs (Binary.ConstantFold): Only concat strings when
23620 the operation is "+", not everything ;-)
23622 * statement.cs (Statement.EmitBoolExpression): Take a location
23624 (If, While, Do): Track location.
23626 * expression.cs (Binary.ResolveOperator): In the object + string
23627 case, I was missing a call to ConvertImplicit
23629 2002-02-25 Ravi Pratap <ravi@ximian.com>
23631 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
23632 Location arguments. Ensure we use RootContext.LookupType to do our work
23633 and not try to do a direct Type.GetType and ModuleBuilder.GetType
23635 * interface.cs (PopulateMethod): Handle the type of the parameter being
23638 * expression.cs (Invocation.BetterFunction): Handle the case when we
23639 have a params method with no fixed arguments and a call is made with no
23642 2002-02-25 Miguel de Icaza <miguel@ximian.com>
23644 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
23645 the verbatim-string-literal
23647 * support.cs (InternalParameters.ParameterModifier): handle null
23649 (InternalParameters.ParameterType): ditto.
23651 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
23652 duplicating the name of the variable parameter.
23653 (GetParameterByName): Fix bug where we were not looking up array
23654 paramters if they were the only present (thanks Paolo!).
23655 (GetParameterInfo): We only have an empty set of types if both
23656 fixed and array are set to null.
23657 (GetParameterInfo-idx): Handle FixedParameter == null
23659 * cs-parser.jay: Handle the case where there is no catch
23660 statements (missing null test).
23662 2002-02-22 Miguel de Icaza <miguel@ximian.com>
23664 * driver.cs (MainDriver): Be conservative on our command line
23667 Catch DirectoryNotFoundException when calling GetFiles.
23669 (SplitPathAndPattern): Used to split the input specification into
23670 a path and a pattern that we can feed to Directory.GetFiles.
23672 2002-02-21 Miguel de Icaza <miguel@ximian.com>
23674 * statement.cs (Fixed): Implement the last case of the Fixed
23675 statement (string handling).
23677 * expression.cs (StringPtr): New class used to return a char * to
23678 a string; Used by the Fixed statement.
23680 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
23682 * expression.cs (Binary.ResolveOperator): Remove redundant
23683 MemberLookup pn parent type.
23684 Optimize union call, we do not need a union if the types are the same.
23685 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
23688 Specialize the use of MemberLookup everywhere, instead of using
23689 the default settings.
23691 (StackAlloc): Implement stackalloc keyword.
23693 * cs-parser.jay: Add rule to parse stackalloc.
23695 * driver.cs: Handle /h, /help, /?
23697 * expression.cs (MakeByteBlob): Removed the hacks we had in place
23698 before we supported unsafe code.
23700 * makefile: add --unsafe to the self compilation of mcs.
23702 2002-02-20 Miguel de Icaza <miguel@ximian.com>
23704 * expression.cs (PointerArithmetic): New class that is used to
23705 perform pointer arithmetic.
23706 (Binary.Resolve): Handle pointer arithmetic
23707 Handle pointer comparission.
23708 (ArrayPtr): Utility expression class that is used to take the
23709 address of an array.
23711 (ElementAccess): Implement array access for pointers
23713 * statement.cs (Fixed): Implement fixed statement for arrays, we
23714 are missing one more case before we are done.
23716 * expression.cs (Indirection): Implement EmitAssign and set the
23717 ExprClass to Variable. This allows pointer dereferences to be
23718 treated as variables, and to have values assigned to them.
23720 * ecore.cs (Expression.StoreFromPtr): New utility function to
23721 store values dereferencing.
23723 2002-02-20 Ravi Pratap <ravi@ximian.com>
23725 * expression.cs (Binary.ResolveOperator): Ensure that we are
23726 not trying to operate on a void type - this fixes the reported
23729 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
23730 the parent implementation is sealed.
23732 * ../errors/cs0239.cs : Add.
23734 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
23736 * typemanager.cs (unverifiable_code_type): Corresponds to
23737 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
23738 which have unsafe code in them.
23740 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
23743 2002-02-19 Miguel de Icaza <miguel@ximian.com>
23745 * cs-tokenizer.cs: Add support for @"litreal strings"
23747 Make tokenizer accept pre-processor directives
23748 on any column (remove the old C-like limitation).
23750 * rootcontext.cs (EmitCode): Emit any global attributes.
23751 (AddGlobalAttributes): Used to keep track of assembly attributes.
23753 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
23755 * cs-parser.jay: Add support for global attributes.
23757 2002-02-17 Miguel de Icaza <miguel@ximian.com>
23759 * expression.cs (Indirection): New helper class. Unary will
23760 create Indirection classes to be able to implement the
23761 IMemoryLocation interface on it.
23763 2002-02-16 Miguel de Icaza <miguel@ximian.com>
23765 * cs-parser.jay (fixed_statement): reference the right statement.
23767 * statement.cs (Fixed.Emit): Finish implementing the fixed
23768 statement for the &x case.
23770 2002-02-14 Miguel de Icaza <miguel@ximian.com>
23772 * class.cs (Property.Define, Method.Define): Remove newslot when
23775 * modifiers.cs: My use of NewSlot when `Abstract' was set was
23776 wrong. NewSlot should only be used if the `new' keyword is present.
23778 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
23779 locating our system dir. Sorry about this.
23781 2002-02-13 Miguel de Icaza <miguel@ximian.com>
23783 * driver.cs (GetSystemDir): Compute correctly the location of our
23784 system assemblies. I was using the compiler directory instead of
23785 the library directory.
23787 2002-02-13 Ravi Pratap <ravi@ximian.com>
23789 * expression.cs (BetterFunction): Put back in what Miguel commented out
23790 since it is the correct fix. The problem is elsewhere ;-)
23792 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
23793 parameters of the parms method are themselves compatible or not !
23795 (StandardConversionExists): Fix very dangerous bug where we were forgetting
23796 to check that a class implements an interface before saying that an implicit
23797 conversion was allowed. Use ImplementsInterface to do the checking.
23799 2002-02-13 Miguel de Icaza <miguel@ximian.com>
23801 * class.cs (Method.Define): Track whether we are an explicit
23802 implementation or not. And only call DefineMethodOverride if we
23803 are an explicit implementation.
23805 (Property.DefineMethod): Ditto.
23807 2002-02-11 Ravi Pratap <ravi@ximian.com>
23809 * expression.cs (BetterFunction): Catch hideous bug which was
23810 preventing us from detecting ambiguous calls due to implicit casts i.e
23813 2002-01-29 Miguel de Icaza <miguel@ximian.com>
23815 * support.cs (Pair): Remove un-needed method. I figured why I was
23816 getting the error in cs-parser.jay, the variable in a foreach loop
23817 is readonly, and the compiler does not really treat this as a variable.
23819 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
23820 instead of EQUALS in grammar.
23822 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
23824 * expression.cs (Unary.DoResolve): Check whether the argument is
23827 2002-01-28 Miguel de Icaza <miguel@ximian.com>
23829 * support.cs: Api for Pair to set a value. Despite the fact that
23830 the variables are public the MS C# compiler refuses to compile
23831 code that accesses the field if the variable is part of a foreach
23834 * statement.cs (Fixed): Begin implementation of the fixed
23837 (Block.AddVariable): Return the VariableInfo on success and null
23838 on failure instead of true/false.
23840 * cs-parser.jay (foreach): Catch errors on variables already
23841 defined (we were ignoring this value before) and properly unwind
23842 the block hierarchy
23844 (fixed_statement): grammar for the fixed statement.
23846 2002-01-25 Miguel de Icaza <miguel@ximian.com>
23848 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
23849 pointer types to be incretemented.
23851 (SizeOf): Implement.
23853 * cs-parser.jay (pointer_member_access): Implement
23854 expr->IDENTIFIER production.
23856 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
23857 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
23860 (Unary): Implement indirection.
23862 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
23863 use in non-unsafe context).
23865 (SimpleName.DoResolve): Check for pointers in field access on safe
23868 (Expression.LoadFromPtr): Factor the load-indirect code in this
23869 function. This was duplicated in UnboxCast and ParameterReference
23871 2002-01-24 Miguel de Icaza <miguel@ximian.com>
23873 * expression.cs (ComposedCast): report an error if a pointer cast
23874 is used in a safe region.
23876 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
23877 pointer type casts in unsafe context.
23879 * codegen.cs (EmitContext): Set up IsUnsafe.
23881 * cs-parser.jay (non_expression_type): Add productions for pointer
23884 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
23885 code. We should not use force into static mode if the method is
23886 not virtual. Fixes bug in MIS
23888 * statement.cs (Do.Emit, While.Emit, For.Emit,
23889 Statement.EmitBoolExpression): Add support to Do and While to
23890 propagate infinite loop as `I do return' semantics.
23892 Improve the For case to also test for boolean constants.
23894 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
23895 to the list of attributes we can add.
23897 Remove `EmitContext' argument.
23899 * class.cs (Method.Define): Apply parameter attributes.
23900 (Constructor.Define): Apply parameter attributes.
23901 (MethodCore.LabelParameters): Move here the core of labeling
23904 * support.cs (ReflectionParameters.ParameterModifier,
23905 InternalParameters.ParameterModifier): Use IsByRef on the type and
23906 only return the OUT bit for these parameters instead of in/out/ref
23909 This is because I miss-understood things. The ParameterInfo.IsIn
23910 and IsOut represent whether the parameter has the [In] and [Out]
23913 2002-01-22 Miguel de Icaza <miguel@ximian.com>
23915 * ecore.cs (FieldExpr.Emit): Release temporaries.
23917 * assign.cs (LocalTemporary.Release): new function.
23919 * codegen.cs (EmitContext.GetTemporaryStorage,
23920 EmitContext.FreeTemporaryStorage): Rework the way we deal with
23921 temporary storage. Now we can "put back" localbuilders when we
23924 2002-01-21 Miguel de Icaza <miguel@ximian.com>
23926 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
23927 need to make a copy of the variable to generate verifiable code.
23929 2002-01-19 Miguel de Icaza <miguel@ximian.com>
23931 * driver.cs: Compute dynamically the system directory.
23933 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
23934 Slower, but more generally useful. Used by the abstract
23935 registering implementation.
23937 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
23938 the rules for the special rule on Type/instances. First check if
23939 we have the same name, and if so, try that special static path
23940 rather than the instance path.
23942 2002-01-18 Miguel de Icaza <miguel@ximian.com>
23944 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
23947 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
23948 Enum, ValueType, Delegate or Array for non-corlib compiles.
23950 * cs-tokenizer.cs: Catch long identifiers (645)
23952 * typemanager.cs (IndexerPropetyName): Ravi never tested this
23955 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
23956 fix, we were returning too early, so we were not registering
23957 pending methods from abstract classes.
23959 Do not register pending methods if the class is abstract.
23961 * expression.cs (Conditional.DoResolve): Report circular implicit
23962 conversions when we neecd to compute it for conditional
23965 (Is.DoResolve): If the expression is always of the provided type,
23966 flag warning 183. If the expression can not ever be of the
23967 provided type flag warning 184.
23969 * class.cs: Catch 169 as well.
23971 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
23974 2002-01-18 Nick Drochak <ndrochak@gol.com>
23976 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
23978 2002-01-17 Miguel de Icaza <miguel@ximian.com>
23980 * interface.cs: (PopulateMethod): Check for pointers being defined
23981 only if the unsafe context is active.
23982 (PopulateProperty): ditto.
23983 (PopulateIndexer): ditto.
23985 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
23986 specified. If pointers are present, make sure that they are
23987 present in an unsafe context.
23988 (Constructor, Constructor.Define): ditto.
23989 (Field, Field.Define): ditto.
23990 (Property, Property.Define): ditto.
23991 (Event, Event.Define): ditto.
23993 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
23994 hashtable if there are classes or structs defined.
23996 * expression.cs (LocalVariableReference.DoResolve): Simplify this
23997 code, as the constant resolution moved.
23999 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
24000 the metadata, so we can flag error 133.
24002 * decl.cs (MemberCore.UnsafeOK): New function to test that a
24003 pointer is being declared in an unsafe context.
24005 2002-01-16 Miguel de Icaza <miguel@ximian.com>
24007 * modifiers.cs (Modifiers.Check): Require a Location argument.
24008 Report error 227 for Unsafe use.
24010 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
24012 * statement.cs (For.Emit): If the test is null, then report that
24013 we do `return', as we wont reach anything afterwards.
24015 (Switch.SwitchGoverningType): Track the expression that matched
24018 * driver.cs: Allow negative numbers as an error code to flag.
24020 * cs-parser.jay: Handle 1551.
24022 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
24024 2002-01-15 Miguel de Icaza <miguel@ximian.com>
24026 * cs-parser.jay: Report 1518 (type declaration can only contain
24027 class, struct, interface, enum or delegate)
24029 (switch_label): Report 1523 (keywords `case' or `default' must
24032 (opt_switch_sections): Report 1522 (empty switch)
24034 * driver.cs: Report 1515 (response file specified multiple times)
24035 Report 1516 (Source file specified multiple times).
24037 * expression.cs (Argument.Resolve): Signal 1510
24039 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
24040 access not allowed in static code)
24042 2002-01-11 Ravi Pratap <ravi@ximian.com>
24044 * typemanager.cs (IsPointerType): Utility method which we are going
24047 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
24048 the object type, so we take care of that.
24050 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
24052 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
24053 added to non-params parameters :-)
24055 * typemanager.cs (CSharpName): Include 'void' type too.
24057 (void_ptr_type): Include in the set of core types.
24059 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
24062 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
24065 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
24066 completely forgotten about it.
24068 2002-01-10 Ravi Pratap <ravi@ximian.com>
24070 * cs-parser.jay (pointer_type): Add. This begins our implementation
24071 of parsing rules for unsafe code.
24073 (unsafe_statement): Implement.
24075 (embedded_statement): Modify to include the above.
24077 * statement.cs (Unsafe): Implement new class for unsafe blocks.
24079 * codegen.cs (EmitContext.InUnsafe): Add. This determines
24080 if the current context is an unsafe one.
24082 * cs-parser.jay (local_variable_pointer_type): Since local variable types
24083 are handled differently, we need separate rules for them.
24085 (local_variable_declaration): Update to use local_variable_pointer_type
24086 to allow variable declarations of unmanaged pointer types.
24088 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
24089 in unsafe contexts.
24091 * ../errors/cs0214.cs : Add.
24093 2002-01-16 Nick Drochak <ndrochak@gol.com>
24095 * makefile: remove 'response' file when cleaning.
24097 2002-01-15 Miguel de Icaza <miguel@ximian.com>
24099 * cs-parser.jay: Report 1524.
24101 2002-01-14 Miguel de Icaza <miguel@ximian.com>
24103 * typemanager.cs (RegisterMethod): drop checking if we have
24104 registered this from here
24106 2002-01-12 Miguel de Icaza <miguel@ximian.com>
24108 * class.cs (Method.EmitDestructor): Implement calling our base
24111 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
24112 value of InFinally.
24114 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
24115 this routine and will wrap the call in a try/catch block. Deal
24118 2002-01-11 Miguel de Icaza <miguel@ximian.com>
24120 * ecore.cs (Expression.MemberLookup): instead of taking a
24121 parameter `same_type' that was used to tell whether we could
24122 access private members we compute our containing type from the
24125 (FieldExpr): Added partial support for volatile fields. This does
24126 not work for volatile fields exposed from assemblies, as I can not
24127 figure out how to extract the modreq from it.
24129 Updated all the source files to use this.
24131 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
24132 because it is referenced by MemberLookup very often.
24134 2002-01-09 Ravi Pratap <ravi@ximian.com>
24136 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
24137 TypeBuilder.GetCustomAttributes to retrieve what we need.
24139 Get rid of redundant default_member_attr_type as this is the same as
24140 default_member_type which already exists.
24142 * interface.cs, attribute.cs : Update accordingly.
24144 2002-01-08 Miguel de Icaza <miguel@ximian.com>
24146 * typemanager.cs: Enable IndexerPropertyName again. It does not
24147 work for TYpeBuilders though. Ravi, can you please fix this?
24149 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
24151 * expression.cs (Argument.Emit): Handle the case of ref objects
24152 being passed to ref functions;
24154 (ParameterReference.EmitLoad): Loads the content of the pointer
24155 without dereferencing.
24157 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24159 * cs-tokenizer.cs: Implemented the pre-processing expressions.
24161 2002-01-08 Ravi Pratap <ravi@ximian.com>
24163 * class.cs (Indexer.DefineMethod): Incorporate the interface
24164 type in the name of the method if we are doing explicit interface
24167 * expression.cs (ConversionExists): Remove as it is completely obsolete.
24169 (BetterConversion): Fix extremely trivial bug where we were referring to
24170 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
24173 * ../errors/bug16.cs : Add although we have fixed it.
24175 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24177 * expression.cs (BaseIndexer): Begin implementation.
24179 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
24181 * cs-parser.jay (indexer_declarator): Use qualified_identifier
24182 production directly to remove a shift/reduce, and implement
24183 explicit interface implementation.
24185 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
24186 after a floating point suffix.
24188 * expression.cs (DoNumericPromotions): Improved the conversion for
24189 uint/uint. If we have a constant, we avoid doing a typecast to a
24192 * class.cs (Indexer): Implement explicit interface implementation
24195 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
24197 * class.cs: make the default instance constructor public and hidebysig.
24199 2001-01-03 Ravi Pratap <ravi@ximian.com>
24201 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
24202 so we can call it from elsewhere.
24204 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
24205 we emit it internally if the class has a defined indexer; otherwise the user
24206 emits it by decorating the class definition with the DefaultMemberAttribute.
24208 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
24209 attribute is not used on a type which defines an indexer.
24211 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
24212 character when we skip whitespace.
24214 * ../errors/cs0646.cs : Add.
24216 2002-01-03 Miguel de Icaza <miguel@ximian.com>
24218 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
24221 * makefile: Add practical target `mcs3.exe' which builds the third
24222 generation compiler.
24224 * expression.cs (New): Fix structures constructor calling.
24226 * class.cs (Property, Method, Indexer): Emit Final flag on the
24227 method if we are an interface implementation and we are not
24230 * ecore.cs (PropertyExpr): New public field `IsBase', tells
24231 whether this property is referencing a `base' method.
24233 * expression.cs (Invocation.EmitCall): take an extra argument:
24234 is_base, this is used to determine whether the `call' or
24235 `callvirt' opcode should be used.
24238 * delegate.cs: update EmitCall.
24240 * class.cs (Method.Define): Set NewSlot for the cases where we are
24241 not implementing an interface method.
24243 (Property.Define): ditto.
24245 2002-01-02 Miguel de Icaza <miguel@ximian.com>
24247 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
24248 'r'. Allows mcs to parse itself fully.
24250 2002-01-02 Ravi Pratap <ravi@ximian.com>
24252 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
24253 of the number of initializers that require the InitializeArray method.
24255 (CheckIndices): Store the Expression in all cases - not the plain value. Also
24256 update the above field where necessary.
24258 (MakeByteBlob): Update accordingly.
24260 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
24263 (EmitDynamicInitializers): Update in accordance with the new optimization.
24265 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
24266 same OpCode applies.
24268 * cs-parser.jay : Fix some glaring errors I introduced.
24270 2002-01-01 Ravi Pratap <ravi@ximian.com>
24272 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
24273 so that we can check for name clashes there too.
24275 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
24276 for interface indexers.
24278 * interfaces.cs (Define): Emit the default member attribute.
24280 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
24281 variable was being referred to while setting the value ;-)
24283 2002-01-01 Miguel de Icaza <miguel@ximian.com>
24285 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
24286 byte-by-byte information when we know the data is zero.
24288 Make the block always a multiple of 4, because
24289 DefineInitializedData has a bug.
24291 * assign.cs: Fix, we should assign from the temporary, not from
24294 * expression.cs (MakeByteBlob): Fix my incorrect code.
24296 2001-12-31 Miguel de Icaza <miguel@ximian.com>
24298 * typemanager.cs (EnumToUnderlying): This function is used to get
24299 the underlying type from an enumeration, because it does not
24302 * constant.cs: Use the I4_S form for values between -128 and 127.
24304 * statement.cs (Block.LookupLabel): Looks up a label.
24305 (Block): Drop support for labeled blocks.
24307 (LabeledStatement): New kind of statement that represents a label
24310 (Goto): Finally implement this bad boy.
24312 * cs-parser.jay: Update to reflect new mechanism to implement
24315 2001-12-30 Miguel de Icaza <miguel@ximian.com>
24317 * codegen.cs (EmitContext.This): a codegen property that keeps the
24318 a single instance of this instead of creating many different this
24321 * delegate.cs (Delegate.DoResolve): Update to use the property;
24323 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
24325 * expression.cs (BaseAccess.DoResolve): Ditto.
24327 2001-12-29 Ravi Pratap <ravi@ximian.com>
24329 * typemanager.cs (methodimpl_attr_type): Add to hold the type
24330 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
24332 (InitCoreTypes): Update accordingly.
24334 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
24335 so we can quickly store the state.
24337 (ApplyAttributes): Set the correct implementation flags
24338 for InternalCall methods.
24340 2001-12-29 Miguel de Icaza <miguel@ximian.com>
24342 * expression.cs (EmitCall): if a method is not virtual, then do
24343 not use callvirt on it.
24345 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
24346 user defined stuff) requires the use of stobj, which takes an
24347 address on the stack instead of an array and an index. So emit
24348 the Ldelema operation for it.
24350 (EmitStoreOpcode): Use stobj for valuetypes.
24352 (UnaryMutator.EmitCode): Use the right 1 value depending on
24353 whether we are dealing with int64/uint64, float or doubles.
24355 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
24356 constructors that I implemented last night.
24358 (Constructor.IsDefault): Fix to work properly for static
24361 * cs-parser.jay (CheckDef): report method signature errors.
24362 Update error number 103 to be 132.
24364 * decl.cs: New AdditionResult enumeration value: MethodExists.
24365 Although we do this check for methods later on in the semantic
24366 analysis, catching repeated default constructors is so easy that
24367 we catch these here.
24369 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
24372 (ParameterReference.EmitAssign, Emit): handle
24375 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
24376 (ArrayAccess.EmitStoreOpcode): ditto.
24378 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
24380 * expression.cs (MakeByteBlob): Complete all the missing types
24381 (uint, short, ushort, byte, sbyte)
24383 * class.cs: Only init instance field initializers on instance
24386 Rename `constructors' to instance_constructors.
24388 (TypeContainer.AddConstructor): Only add constructors to the list
24389 if it is not static.
24391 Make sure that we handle default_static_constructor independently
24392 everywhere where we handle instance_constructors
24394 2001-12-28 Miguel de Icaza <miguel@ximian.com>
24396 * class.cs: Do not lookup or create a base initializer for a
24397 static constructor.
24399 (ConstructorInitializer.Resolve): use the proper type to lookup
24402 * cs-parser.jay: Report error 1585 (modifiers between type and name).
24404 * enum.cs, interface.cs: Remove CloseType, this is taken care by
24407 * decl.cs: CloseType is now an virtual method, the default
24408 implementation just closes this type.
24410 2001-12-28 Ravi Pratap <ravi@ximian.com>
24412 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
24413 to PreserveSig by default. Also emit HideBySig on such methods.
24415 Basically, set the defaults to standard values.
24417 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
24418 argument, if candidate is better, it can't be worse than the best !
24420 (Invocation): Re-write bits to differentiate between methods being
24421 applicable in their expanded form and their normal form - for params
24424 Get rid of use_standard everywhere as only standard conversions are allowed
24425 in overload resolution.
24427 More spec conformance.
24429 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24431 * driver.cs: Add --timestamp, to see where the compiler spends
24434 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
24435 `this' in static code.
24437 (SimpleName.DoResolve): Implement in terms of a helper function
24438 that allows static-references to be passed upstream to
24441 (Expression.ResolveWithSimpleName): Resolve specially simple
24442 names when called by MemberAccess to implement the special
24445 (Expression.ImplicitReferenceConversion): Handle conversions from
24446 Null to reference types before others, as Null's type is
24449 * expression.cs (Invocation.EmitCall): Handle the special case of
24450 calling methods declared on a reference type from a ValueType
24451 (Base classes System.Object and System.Enum)
24453 (MemberAccess.Resolve): Only perform lookups on Enumerations if
24454 the left hand side is a TypeExpr, not on every enumeration.
24456 (Binary.Resolve): If types are reference types, then do a cast to
24457 object on operators != and == of both arguments.
24459 * typemanager.cs (FindMembers): Extract instance and static
24460 members if requested.
24462 * interface.cs (PopulateProperty): Use void_type instead of null
24463 as the return type for the setter method.
24465 (PopulateIndexer): ditto.
24467 2001-12-27 Ravi Pratap <ravi@ximian.com>
24469 * support.cs (ReflectionParameters): Fix minor bug where we
24470 were examining the wrong parameter for the ParamArray attribute.
24472 Cope with requests for the type of the parameter at position
24473 greater than the params parameter's. We now return the element
24474 type of the params array as that makes more sense.
24476 * expression.cs (Invocation.IsParamsMethodApplicable): Update
24477 accordingly as we no longer have to extract the element type
24480 (Invocation.OverloadResolve): Update.
24482 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24484 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
24485 against IEnumerator, test whether the return value is a descendant
24486 of the IEnumerator interface.
24488 * class.cs (Indexer.Define): Use an auxiliary method to implement
24489 the other bits of the method definition. Begin support for
24490 explicit interface implementation.
24492 (Property.DefineMethod): Use TypeManager.void_type instead of null
24493 for an empty return value.
24495 2001-12-26 Miguel de Icaza <miguel@ximian.com>
24497 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
24498 dealing with a FieldExpr which is composed of a FieldBuilder, in
24499 the code path we did extract the constant, but we should have
24500 obtained the underlying value to be able to cast it (otherwise we
24501 end up in an infinite loop, this is what Ravi was running into).
24503 (ArrayCreation.UpdateIndices): Arrays might be empty.
24505 (MemberAccess.ResolveMemberAccess): Add support for section
24506 14.5.4.1 that deals with the special case of E.I when E is a type
24507 and something else, that I can be a reference to a static member.
24509 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
24510 handle a particular array type to create byte blobs, it is just
24511 something we dont generate byteblobs for.
24513 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
24516 * location.cs (Push): remove the key from the hashtable that we
24517 are about to add. This happens for empty files.
24519 * driver.cs: Dispose files after we have parsed them.
24521 (tokenize): new function that only runs the tokenizer on its
24522 input, for speed testing.
24524 2001-12-26 Ravi Pratap <ravi@ximian.com>
24526 * class.cs (Event.Define): Define the private field only if there
24527 are no accessors defined.
24529 * expression.cs (ResolveMemberAccess): If there is no associated
24530 field with the event, that means we have an event defined with its
24531 own accessors and we should flag error cs0070 since transforming
24532 ourselves into a field is not valid in that case.
24534 * ecore.cs (SimpleName.DoResolve): Same as above.
24536 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
24537 and charset to sane values.
24539 2001-12-25 Ravi Pratap <ravi@ximian.com>
24541 * assign.cs (DoResolve): Perform check on events only if they
24542 are being accessed outside the declaring type.
24544 * cs-parser.jay (event_declarations): Update rules to correctly
24545 set the type of the implicit parameter etc.
24547 (add_accessor, remove_accessor): Set current local parameters.
24549 * expression.cs (Binary): For delegate addition and subtraction,
24550 cast the return value from the method into the appropriate delegate
24553 2001-12-24 Ravi Pratap <ravi@ximian.com>
24555 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
24556 of these as the workaround is unnecessary.
24558 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
24559 delegate data - none of that is needed at all.
24561 Re-write bits to extract the instance expression and the delegate method
24564 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
24567 * attribute.cs (ApplyAttributes): New method to take care of common tasks
24568 of attaching attributes instead of duplicating code everywhere.
24570 * everywhere : Update code to do attribute emission using the above method.
24572 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24574 * expression.cs (IsParamsMethodApplicable): if there are not
24575 parameters, return immediately.
24577 * ecore.cs: The 0 literal can be implicity converted to an enum
24580 (SimpleName.DoResolve): First lookup the type, then lookup the
24583 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
24584 want to get its address. If the InstanceExpression is not
24585 addressable, store the result in a temporary variable, then get
24588 * codegen.cs: Only display 219 errors on warning level or above.
24590 * expression.cs (ArrayAccess): Make it implement the
24591 IMemoryLocation interface.
24593 (Binary.DoResolve): handle the operator == (object a, object b)
24594 and operator != (object a, object b) without incurring into a
24595 BoxedCast (because 5 != o should never be performed).
24597 Handle binary enumerator operators.
24599 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
24600 value type, otherwise use Ldelem_ref.
24602 Use precomputed names;
24604 (AddressOf): Implement address of
24606 * cs-parser.jay (labeled_statement): Fix recursive block
24607 addition by reworking the production.
24609 * expression.cs (New.DoEmit): New has a special case:
24611 If we are dealing with a ValueType, we have a few
24612 situations to deal with:
24614 * The target of New is a ValueType variable, that is
24615 easy, we just pass this as the variable reference
24617 * The target of New is being passed as an argument,
24618 to a boxing operation or a function that takes a
24621 In this case, we need to create a temporary variable
24622 that is the argument of New.
24625 2001-12-23 Ravi Pratap <ravi@ximian.com>
24627 * rootcontext.cs (LookupType): Check that current_type is not null before
24628 going about looking at nested types.
24630 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
24631 not implement the IAssignMethod interface any more.
24633 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
24634 where we tranform them into FieldExprs if they are being resolved from within
24635 the declaring type.
24637 * ecore.cs (SimpleName.DoResolve): Do the same here.
24639 * assign.cs (DoResolve, Emit): Clean up code considerably.
24641 * ../errors/bug10.cs : Add.
24643 * ../errors/cs0070.cs : Add.
24645 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
24647 * assign.cs : Get rid of EventIsLocal everywhere.
24649 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24651 * ecore.cs (ConvertIntLiteral): finished the implementation.
24653 * statement.cs (SwitchLabel): Convert the value we are using as a
24654 key before looking up the table.
24656 2001-12-22 Miguel de Icaza <miguel@ximian.com>
24658 * codegen.cs (EmitTopBlock): Require a Location argument now.
24660 * cs-parser.jay (constructor_declarator): We need to setup
24661 current_local_parameters before we parse the
24662 opt_constructor_initializer, to allow the variables to be bound
24663 to the constructor arguments.
24665 * rootcontext.cs (LookupType): First lookup nested classes in our
24666 class and our parents before we go looking outside our class.
24668 * expression.cs (ConstantFold): Extract/debox the values at the
24671 * rootcontext.cs (EmitCode): Resolve the constants first before we
24672 resolve the types. This is not really needed, but it helps debugging.
24674 * statement.cs: report location.
24676 * cs-parser.jay: pass location to throw statement.
24678 * driver.cs: Small bug fix.
24680 * report.cs: Updated format to be 4-zero filled digits.
24682 2001-12-22 Ravi Pratap <ravi@ximian.com>
24684 * expression.cs (CheckIndices): Fix minor bug where the wrong
24685 variable was being referred to ;-)
24687 (DoEmit): Do not call EmitStaticInitializers when the
24688 underlying type is System.Object.
24690 2001-12-21 Ravi Pratap <ravi@ximian.com>
24692 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
24693 and do the usual workaround for SRE.
24695 * class.cs (MyEventBuilder.EventType): New member to get at the type
24696 of the event, quickly.
24698 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
24700 * assign.cs (Assign.DoResolve): Handle the case when the target
24701 is an EventExpr and perform the necessary checks.
24703 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
24706 (SimpleName.MemberStaticCheck): Include check for EventExpr.
24708 (EventExpr): Set the type in the constructor itself since we
24709 are meant to be born fully resolved.
24711 (EventExpr.Define): Revert code I wrote earlier.
24713 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
24714 instance expression is null. The instance expression is a This in that case
24715 or a null, depending on whether it is a static method or not.
24717 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
24718 refers to more than one method.
24720 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
24721 and accordingly flag errors.
24723 2001-12-21 Miguel de Icaza <miguel@ximian.com>
24725 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
24727 2001-12-22 Miguel de Icaza <miguel@ximian.com>
24729 * location.cs (ToString): Provide useful rutine.
24731 2001-12-21 Miguel de Icaza <miguel@ximian.com>
24733 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
24734 objects, return the actual integral boxed.
24736 * statement.cs (SwitchLabel): define an ILLabel for each
24739 (Switch.CheckSwitch): If the value is a Literal, extract
24740 the underlying literal.
24742 Also in the unused hashtable we had, add the SwitchLabel so we can
24743 quickly look this value up.
24745 * constant.cs: Implement a bunch of new constants. Rewrite
24746 Literal based on this. Made changes everywhere to adapt to this.
24748 * expression.cs (Expression.MakeByteBlob): Optimize routine by
24749 dereferencing array only once, and also copes with enumrations.
24751 bytes are two bytes wide, not one.
24753 (Cast): Perform constant conversions.
24755 * ecore.cs (TryImplicitIntConversion): Return literals instead of
24756 wrappers to the literals here.
24758 * expression.cs (DoNumericPromotions): long literals can converted
24759 to ulong implicity (this is taken care of elsewhere, but I was
24760 missing this spot).
24762 * ecore.cs (Expression.Literalize): Make the return type Literal,
24763 to improve type checking.
24765 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
24767 2001-12-20 Miguel de Icaza <miguel@ximian.com>
24769 * literal.cs: Revert code from ravi that checked the bounds. The
24770 bounds are sane by the definition of the type itself.
24772 * typemanager.cs: Fix implementation of ImplementsInterface. We
24773 need to actually look up in our parent hierarchy for interfaces
24776 * const.cs: Use the underlying type for enumerations
24778 * delegate.cs: Compute the basename for the delegate creation,
24779 that should fix the delegate test case, and restore the correct
24780 Type Lookup semantics in rootcontext
24782 * rootcontext.cs: Revert Ravi's last patch. The correct way of
24783 referencing a nested type with the Reflection API is using the "+"
24786 * cs-parser.jay: Do not require EOF token at the end.
24788 2001-12-20 Ravi Pratap <ravi@ximian.com>
24790 * rootcontext.cs (LookupType): Concatenate type names with
24791 a '.' instead of a '+' The test suite passes again.
24793 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
24794 field of the enumeration.
24796 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
24797 the case when the member is an EventExpr.
24799 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
24800 static has an associated instance expression.
24802 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
24804 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
24806 * class.cs (Event.Define): Register event and perform appropriate checks
24809 We define the Add and Remove methods even if the use provides none because
24810 in that case, we provide default implementations ourselves.
24812 Define a private field of the type of the event. This is done by the CSC compiler
24813 and we should be doing it too ;-)
24815 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
24816 More methods we use in code we generate.
24818 (multicast_delegate_type, delegate_type): Two separate types since the distinction
24821 (InitCoreTypes): Update accordingly for the above.
24823 * class.cs (Event.Emit): Generate code for default accessors that we provide
24825 (EmitDefaultMethod): Do the job in the above.
24827 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
24830 2001-12-20 Miguel de Icaza <miguel@ximian.com>
24832 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
24833 builders even if we were missing one.
24835 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
24836 pass the Basename as our class name instead of the Name. The
24837 basename will be correctly composed for us.
24839 * parameter.cs (Paramters): Now takes a Location argument.
24841 * decl.cs (DeclSpace.LookupType): Removed convenience function and
24842 make all the code call directly LookupType in RootContext and take
24843 this chance to pass the Location information everywhere.
24845 * Everywhere: pass Location information.
24847 2001-12-19 Miguel de Icaza <miguel@ximian.com>
24849 * class.cs (Constructor.Define): Updated way of detecting the
24850 length of the parameters.
24852 (TypeContainer.DefineType): Use basename as the type name for
24855 (TypeContainer.Define): Do not recursively define types here, as
24856 definition is taken care in order by the RootContext.
24858 * tree.cs: Keep track of namespaces in a per-file basis.
24860 * parameter.cs (Parameter.ComputeSignature): Update to use
24863 (Parameters.GetSignature): ditto.
24865 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
24866 instead of a TypeContainer.
24868 (Interface.SemanticAnalysis): Use `this' instead of our parent to
24869 resolve names. Because we need to be resolve in our context, not
24872 * driver.cs: Implement response files.
24874 * class.cs (TypeContainer.DefineType): If we are defined, do not
24875 redefine ourselves.
24877 (Event.Emit): Emit the code for add/remove handlers.
24878 (Event.Define): Save the MethodBuilders for add/remove.
24880 * typemanager.cs: Use pair here too.
24882 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
24883 DictionaryEntry requires the first argument to be non-null.
24885 (enum_declaration): Compute full name for registering the
24888 (delegate_declaration): Instead of using
24889 formal_parameter_list, use opt_formal_parameter_list as the list
24892 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
24893 (EventParsing): New property that controls whether `add' and
24894 `remove' are returned as tokens or identifiers (for events);
24896 2001-12-19 Ravi Pratap <ravi@ximian.com>
24898 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
24899 use MyEventBuilder only and let it wrap the real builder for us.
24901 (MyEventBuilder): Revamp constructor etc.
24903 Implement all operations that we perform on EventBuilder in precisely the same
24906 (FindMembers): Update to use the EventBuilder member.
24908 (Event.Emit): Update accordingly.
24910 2001-12-18 Ravi Pratap <ravi@ximian.com>
24912 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
24913 by calling the appropriate methods.
24915 (GetCustomAttributes): Make stubs as they cannot possibly do anything
24918 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
24920 2001-12-17 Ravi Pratap <ravi@ximian.com>
24922 * delegate.cs (Delegate.Populate): Check that the return type
24923 and various parameters types are indeed accessible.
24925 * class.cs (Constructor.Define): Same here.
24927 (Field.Define): Ditto.
24929 (Event.Define): Ditto.
24931 (Operator.Define): Check that the underlying Method defined itself
24932 correctly - so it's MethodBuilder should not be null.
24934 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
24935 expression happens to be null.
24937 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
24938 members but as of now we don't seem to be able to do anything really useful with it.
24940 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
24941 not the EventBuilder.
24943 2001-12-18 Miguel de Icaza <miguel@ximian.com>
24945 * cs-tokenizer.cs: Add support for defines.
24946 Add support for #if, #elif, #else, #endif
24948 (eval_var): evaluates a variable.
24949 (eval): stubbed for evaluating functions.
24951 * cs-parser.jay: Pass the defines information
24953 * driver.cs: Add --define command line option.
24955 * decl.cs: Move MemberCore here.
24957 Make it the base class for DeclSpace. This allows us to catch and
24958 report 108 and 109 for everything now.
24960 * class.cs (TypeContainer.Define): Extract all the members
24961 before populating and emit the warning 108 (new keyword required
24962 to override) instead of having each member implement this.
24964 (MemberCore.Define): New abstract method, we will be using this in
24965 the warning reporting engine in Populate.
24967 (Operator.Define): Adjust to new MemberCore protocol.
24969 * const.cs (Const): This does not derive from Expression, it is a
24970 temporary object we use to create fields, it is a MemberCore.
24972 * class.cs (Method.Define): Allow the entry point to be in a
24975 * driver.cs: Rewrite the argument handler to clean it up a bit.
24977 * rootcontext.cs: Made it just an auxiliary namespace feature by
24978 making everything static.
24980 * driver.cs: Adapt code to use RootContext type name instead of
24983 * delegate.cs: Remove RootContext argument.
24985 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
24988 * class.cs (Event.Define): The lookup can fail.
24990 * cs-tokenizer.cs: Begin implementation of pre-procesor.
24992 * expression.cs: Resolve the this instance before invoking the code.
24994 2001-12-17 Miguel de Icaza <miguel@ximian.com>
24996 * cs-parser.jay: Add a production in element_access that allows
24997 the thing to become a "type" reference. This way we can parse
24998 things like "(string [])" as a type.
25000 Note that this still does not handle the more complex rules of
25004 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
25006 * ecore.cs: (CopyNewMethods): new utility function used to
25007 assemble the list of methods from running FindMembers.
25009 (MemberLookup): Rework FindMembers so that
25011 2001-12-16 Miguel de Icaza <miguel@ximian.com>
25013 * class.cs (TypeContainer): Remove Delegates who fail to be
25016 * delegate.cs (Populate): Verify that we dont get null return
25017 values. TODO: Check for AsAccessible.
25019 * cs-parser.jay: Use basename to emit error 574 (destructor should
25020 have the same name as container class), not the full name.
25022 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
25023 possible representation.
25025 Also implements integer type suffixes U and L.
25027 2001-12-15 Miguel de Icaza <miguel@ximian.com>
25029 * expression.cs (ArrayCreation.DoResolve): We need to do the
25030 argument resolution *always*.
25032 * decl.cs: Make this hold the namespace. Hold the root context as
25034 (LookupType): Move here.
25036 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
25038 * location.cs (Row, Name): Fixed the code, it was always returning
25039 references to the first file.
25041 * interface.cs: Register properties defined through interfaces.
25043 * driver.cs: Add support for globbing on the command line
25045 * class.cs (Field): Make it derive from MemberCore as well.
25048 2001-12-15 Ravi Pratap <ravi@ximian.com>
25050 * class.cs (Event::Define): Check that the type of the event is a delegate
25051 type else flag error #66.
25053 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
25056 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
25057 values of EntryPoint, CharSet etc etc.
25059 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
25061 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
25062 be null and we should ignore this. I am not sure if this is really clean. Apparently,
25063 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
25064 which needs this to do its work.
25066 * ../errors/cs0066.cs : Add.
25068 2001-12-14 Miguel de Icaza <miguel@ximian.com>
25070 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
25073 * class.cs: (MethodSignature.MethodSignature): Removed hack that
25074 clears out the parameters field.
25075 (MemberSignatureCompare): Cleanup
25077 (MemberCore): New base class used to share code between MethodCore
25080 (RegisterRequiredImplementations) BindingFlags.Public requires
25081 either BindingFlags.Instace or Static. Use instance here.
25083 (Property): Refactored code to cope better with the full spec.
25085 * parameter.cs (GetParameterInfo): Return an empty array instead
25088 * class.cs (Property): Abstract or extern properties have no bodies.
25090 * parameter.cs (GetParameterInfo): return a zero-sized array.
25092 * class.cs (TypeContainer.MethodModifiersValid): Move all the
25093 method modifier validation to the typecontainer so we can reuse
25094 this on properties.
25096 (MethodCore.ParameterTypes): return an empty sized array of types.
25098 (Property.Define): Test property modifier validity.
25100 Add tests for sealed/override too.
25102 (Method.Emit): abstract or extern methods have no bodies.
25104 2001-12-14 Ravi Pratap <ravi@ximian.com>
25106 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
25109 (Method::Define, ::Emit): Modify accordingly.
25111 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
25113 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
25115 * makefile: Pass in /unsafe.
25117 2001-12-13 Miguel de Icaza <miguel@ximian.com>
25119 * class.cs (MakeKey): Kill routine.
25121 * class.cs (TypeContainer.Define): Correctly define explicit
25122 method implementations (they require the full interface name plus
25125 * typemanager.cs: Deply the PtrHashtable here and stop using the
25126 lame keys. Things work so much better.
25128 This of course broke everyone who depended on `RegisterMethod' to
25129 do the `test for existance' test. This has to be done elsewhere.
25131 * support.cs (PtrHashtable): A hashtable that avoid comparing with
25132 the object stupid Equals method (because, that like fails all over
25133 the place). We still do not use it.
25135 * class.cs (TypeContainer.SetRequiredInterface,
25136 TypeContainer.RequireMethods): Killed these two routines and moved
25137 all the functionality to RegisterRequiredImplementations.
25139 (TypeContainer.RegisterRequiredImplementations): This routine now
25140 registers all the implementations required in an array for the
25141 interfaces and abstract methods. We use an array of structures
25142 which can be computed ahead of time to reduce memory usage and we
25143 also assume that lookups are cheap as most classes will not
25144 implement too many interfaces.
25146 We also avoid creating too many MethodSignatures.
25148 (TypeContainer.IsInterfaceMethod): Update and optionally does not
25149 clear the "pending" bit if we find that there are problems with
25152 (TypeContainer.VerifyPendingMethods): Update to report errors of
25153 methods that look like implementations but are not.
25155 (TypeContainer.Define): Add support for explicit interface method
25158 2001-12-12 Miguel de Icaza <miguel@ximian.com>
25160 * typemanager.cs: Keep track of the parameters here instead of
25161 being a feature of the TypeContainer.
25163 * class.cs: Drop the registration of parameters here, as
25164 InterfaceMethods are also interface declarations.
25166 * delegate.cs: Register methods with the TypeManager not only with
25167 the TypeContainer. This code was buggy.
25169 * interface.cs: Full registation here.
25171 2001-12-11 Miguel de Icaza <miguel@ximian.com>
25173 * expression.cs: Remove reducer for binary expressions, it can not
25176 * const.cs: Put here the code that used to go into constant.cs
25178 * constant.cs: Put here the code for constants, this is a new base
25179 class for Literals.
25181 * literal.cs: Make Literal derive from Constant.
25183 2001-12-09 Miguel de Icaza <miguel@ximian.com>
25185 * statement.cs (Return.Emit): Report error 157 if the user
25186 attempts to return from a finally block.
25188 (Return.Emit): Instead of emitting a return, jump to the end of
25191 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
25192 LocalBuilder to store the result of the function. ReturnLabel is
25193 the target where we jump.
25196 2001-12-09 Radek Doulik <rodo@ximian.com>
25198 * cs-parser.jay: remember alias in current namespace
25200 * ecore.cs (SimpleName::DoResolve): use aliases for types or
25203 * class.cs (LookupAlias): lookup alias in my_namespace
25205 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
25207 (LookupAlias): lookup alias in this and if needed in parent
25210 2001-12-08 Miguel de Icaza <miguel@ximian.com>
25214 * rootcontext.cs: (ModuleBuilder) Made static, first step into
25215 making things static. I need this to avoid passing the
25216 TypeContainer when calling ParameterType.
25218 * support.cs (InternalParameters.ParameterType): Remove ugly hack
25219 that did string manipulation to compute the type and then call
25220 GetType. Use Parameter.ParameterType instead.
25222 * cs-tokenizer.cs: Consume the suffix for floating values.
25224 * expression.cs (ParameterReference): figure out whether this is a
25225 reference parameter or not. Kill an extra variable by computing
25226 the arg_idx during emission.
25228 * parameter.cs (Parameters.GetParameterInfo): New overloaded
25229 function that returns whether a parameter is an out/ref value or not.
25231 (Parameter.ParameterType): The type of the parameter (base,
25232 without ref/out applied).
25234 (Parameter.Resolve): Perform resolution here.
25235 (Parameter.ExternalType): The full type (with ref/out applied).
25237 * statement.cs (Using.Emit, Using.EmitExpression): Implement
25238 support for expressions on the using statement.
25240 2001-12-07 Miguel de Icaza <miguel@ximian.com>
25242 * statement.cs (Using.EmitLocalVariableDecls): Split the
25243 localvariable handling of the using statement.
25245 (Block.EmitMeta): Keep track of variable count across blocks. We
25246 were reusing slots on separate branches of blocks.
25248 (Try.Emit): Emit the general code block, we were not emitting it.
25250 Check the type of the declaration to be an IDisposable or
25251 something that can be implicity converted to it.
25253 Emit conversions if required.
25255 * ecore.cs (EmptyExpression): New utility class.
25256 (Expression.ImplicitConversionExists): New utility function.
25258 2001-12-06 Miguel de Icaza <miguel@ximian.com>
25260 * statement.cs (Using): Implement.
25262 * expression.cs (LocalVariableReference): Support read only variables.
25264 * statement.cs: Remove the explicit emit for the Leave opcode.
25265 (VariableInfo): Add a readonly field.
25267 2001-12-05 Miguel de Icaza <miguel@ximian.com>
25269 * ecore.cs (ConvCast): new class used to encapsulate the various
25270 explicit integer conversions that works in both checked and
25271 unchecked contexts.
25273 (Expression.ConvertNumericExplicit): Use new ConvCast class to
25274 properly generate the overflow opcodes.
25276 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25278 * statement.cs: The correct type for the EmptyExpression is the
25279 element_type, not the variable type. Ravi pointed this out.
25281 2001-12-04 Ravi Pratap <ravi@ximian.com>
25283 * class.cs (Method::Define): Handle PInvoke methods specially
25284 by using DefinePInvokeMethod instead of the usual one.
25286 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
25287 above to do the task of extracting information and defining the method.
25289 2001-12-04 Ravi Pratap <ravi@ximian.com>
25291 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
25292 of the condition for string type.
25294 (Emit): Move that here.
25296 (ArrayCreation::CheckIndices): Keep string literals in their expression
25299 (EmitDynamicInitializers): Handle strings appropriately.
25301 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25303 * codegen.cs (EmitContext): Replace multiple variables with a
25304 single pointer to the current Switch statement.
25306 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
25309 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25313 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
25316 (Foreach.Emit): Foreach on arrays was not setting
25317 up the loop variables (for break/continue).
25319 (GotoCase): Semi-implented.
25321 2001-12-03 Ravi Pratap <ravi@ximian.com>
25323 * attribute.cs (CheckAttribute): Handle system attributes by using
25324 Attribute.GetAttributes to examine information we need.
25326 (GetValidPlaces): Same here.
25328 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
25330 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
25332 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
25334 (Method::Define): Set appropriate flags if we have a DllImport attribute.
25336 (Method::Emit): Handle the case when we are a PInvoke method.
25338 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25340 * expression.cs: Use ResolveWithSimpleName on compound names.
25342 2001-12-02 Ravi Pratap <ravi@ximian.com>
25344 * constant.cs (EmitConstant): Make sure we resolve the associated expression
25345 before trying to reduce it.
25347 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
25349 * constant.cs (LookupConstantValue): Implement.
25351 (EmitConstant): Use the above in emitting the constant.
25353 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
25354 that are user-defined by doing a LookupConstantValue on them.
25356 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
25359 2001-11-29 Miguel de Icaza <miguel@ximian.com>
25361 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
25363 (BaseAccess.DoResolve): Implement.
25365 (MemberAccess.DoResolve): Split this routine into a
25366 ResolveMemberAccess routine that can be used independently
25368 2001-11-28 Miguel de Icaza <miguel@ximian.com>
25370 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
25371 As that share bits of the implementation. Is returns a boolean,
25372 while As returns the Type that is being probed.
25374 2001-12-01 Ravi Pratap <ravi@ximian.com>
25376 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
25377 instead of a Literal - much easier.
25379 (EnumInTransit): Remove - utterly useless :-)
25381 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
25383 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
25385 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
25386 chain when we have no associated expression.
25388 2001-11-30 Ravi Pratap <ravi@ximian.com>
25390 * constant.cs (Define): Use Location while reporting the errror.
25392 Also emit a warning when 'new' is used and there is no inherited
25395 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
25398 (LookupEnumValue): Implement to lookup an enum member's value and define it
25401 (Populate): Re-write accordingly to use the above routine.
25403 2001-11-27 Miguel de Icaza <miguel@ximian.com>
25405 * expression.cs (This): Fix prototype for DoResolveLValue to
25406 override the base class DoResolveLValue.
25408 * cs-parser.cs: Report errors cs574 and cs575 (destructor
25411 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
25412 (we need to load the address of the field here). This fixes
25415 (FieldExpr.DoResolveLValue): Call the DoResolve
25416 function to initialize the Instance expression.
25418 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
25419 correctly the GetEnumerator operation on a value type.
25421 * cs-parser.jay: Add more simple parsing error catches.
25423 * statement.cs (Switch): Add support for string switches.
25424 Handle null specially.
25426 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
25428 2001-11-28 Ravi Pratap <ravi@ximian.com>
25430 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
25432 (declare_local_constant): New helper function.
25434 * statement.cs (AddConstant): Keep a separate record of constants
25436 (IsConstant): Implement to determine if a variable is a constant.
25438 (GetConstantExpression): Implement.
25440 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
25442 * statement.cs (IsVariableDefined): Re-write.
25444 2001-11-27 Ravi Pratap <ravi@ximian.com>
25446 * class.cs (TypeContainer::FindMembers): Look for constants
25447 in the case when we are looking for MemberTypes.Field
25449 * expression.cs (MemberAccess::DoResolve): Check that in the
25450 case we are a FieldExpr and a Literal, we are not being accessed
25451 by an instance reference.
25453 * cs-parser.jay (local_constant_declaration): Implement.
25455 (declaration_statement): Implement for constant declarations.
25457 2001-11-26 Miguel de Icaza <miguel@ximian.com>
25459 * statement.cs (Switch): Catch double defaults.
25461 (Switch): More work on the switch() statement
25462 implementation. It works for integral values now, need to finish
25466 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25468 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
25469 integer literals into other integer literals. To be used by
25472 2001-11-24 Ravi Pratap <ravi@ximian.com>
25474 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
25477 (EmitDynamicInitializers): Cope with the above since we extract data
25478 directly from ArrayData now.
25480 (ExpectInitializers): Keep track of whether initializers are mandatory
25483 (Bounds): Make it a hashtable to prevent the same dimension being
25484 recorded for every element in that dimension.
25486 (EmitDynamicInitializers): Fix bug which prevented the Set array method
25489 Also fix bug which was causing the indices to be emitted in the reverse
25492 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25494 * expression.cs (ArrayCreation): Implement the bits that Ravi left
25495 unfinished. They do not work, because the underlying code is
25498 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25500 * cs-parser.jay: Remove bogus fixme.
25502 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
25503 on Switch statement.
25505 2001-11-23 Ravi Pratap <ravi@ximian.com>
25507 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
25510 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
25511 parameter. Apparently, any expression is allowed.
25513 (ValidateInitializers): Update accordingly.
25515 (CheckIndices): Fix some tricky bugs thanks to recursion.
25517 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
25518 I was being completely brain-dead.
25520 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
25521 and re-write acordingly.
25523 (DelegateInvocation): Re-write accordingly.
25525 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
25527 (MakeByteBlob): Handle types more correctly.
25529 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
25530 initialization from expressions but it is incomplete because I am a complete
25533 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25535 * statement.cs (If.Emit): Fix a bug that generated incorrect code
25536 on If. Basically, we have to return `true' (ie, we do return to
25537 our caller) only if both branches of the if return.
25539 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
25540 short-circuit operators, handle them as short circuit operators.
25542 (Cast.DoResolve): Resolve type.
25543 (Cast.Cast): Take an expression as the target type.
25545 * cs-parser.jay (cast_expression): Remove old hack that only
25546 allowed a limited set of types to be handled. Now we take a
25547 unary_expression and we resolve to a type during semantic
25550 Use the grammar productions from Rhys to handle casts (this is
25551 not complete like Rhys syntax yet, we fail to handle that corner
25552 case that C# has regarding (-x), but we will get there.
25554 2001-11-22 Ravi Pratap <ravi@ximian.com>
25556 * class.cs (EmitFieldInitializer): Take care of the case when we have a
25557 field which is an array type.
25559 * cs-parser.jay (declare_local_variables): Support array initialization too.
25561 * typemanager.cs (MakeKey): Implement.
25563 (everywhere): Use the above appropriately.
25565 * cs-parser.jay (for_statement): Update for array initialization while
25566 declaring variables.
25568 * ecore.cs : The error message was correct, it's the variable's names that
25569 were misleading ;-) Make the code more readable.
25571 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
25572 the correct type etc.
25574 (ConvertExplicit): Handle Enum types by examining the underlying type.
25576 2001-11-21 Ravi Pratap <ravi@ximian.com>
25578 * parameter.cs (GetCallingConvention): Always return
25579 CallingConventions.Standard for now.
25581 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25583 * expression.cs (Binary.ResolveOperator): Update the values of `l'
25584 and `r' after calling DoNumericPromotions.
25586 * ecore.cs: Fix error message (the types were in the wrong order).
25588 * statement.cs (Foreach.ProbeCollectionType): Need to pass
25589 BindingFlags.Instance as well
25591 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
25592 implicit int literal conversion in an empty cast so that we
25593 propagate the right type upstream.
25595 (UnboxCast): new class used to unbox value types.
25596 (Expression.ConvertExplicit): Add explicit type conversions done
25599 (Expression.ImplicitNumericConversion): Oops, forgot to test for
25600 the target type before applying the implicit LongLiterals to ULong
25603 2001-11-21 Miguel de Icaza <miguel@ximian.com>
25605 * cs-parser.jay (for_statement): Reworked the way For works: now
25606 we declare manually any variables that are introduced in
25607 for_initializer to solve the problem of having out-of-band code
25608 emition (that is what got for broken).
25610 (declaration_statement): Perform the actual variable declaration
25611 that used to be done in local_variable_declaration here.
25613 (local_variable_declaration): Do not declare anything, just pass
25614 the information on a DictionaryEntry
25616 2001-11-20 Ravi Pratap <ravi@ximian.com>
25618 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
25619 re-write of the logic to now make it recursive.
25621 (UpdateIndices): Re-write accordingly.
25623 Store element data in a separate ArrayData list in the above methods.
25625 (MakeByteBlob): Implement to dump the array data into a byte array.
25627 2001-11-19 Ravi Pratap <ravi@ximian.com>
25629 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
25632 * constant.cs (Define): Implement.
25634 (EmitConstant): Re-write fully.
25636 Pass in location info.
25638 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
25641 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
25642 DictionaryEntry since we need location info too.
25644 (constant_declaration): Update accordingly.
25646 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
25647 code into another method : UpdateIndices.
25649 2001-11-18 Ravi Pratap <ravi@ximian.com>
25651 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
25652 some type checking etc.
25654 2001-11-17 Ravi Pratap <ravi@ximian.com>
25656 * expression.cs (ArrayCreation::ValidateInitializers): Implement
25657 bits to provide dimension info if the user skips doing that.
25659 Update second constructor to store the rank correctly.
25661 2001-11-16 Ravi Pratap <ravi@ximian.com>
25663 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
25664 and try to implement.
25666 * ../errors/cs0150.cs : Add.
25668 * ../errors/cs0178.cs : Add.
25670 2001-11-16 Miguel de Icaza <miguel@ximian.com>
25672 * statement.cs: Implement foreach on multi-dimensional arrays.
25674 * parameter.cs (Parameters.GetParameterByName): Also lookup the
25675 name of the params argument.
25677 * expression.cs: Use EmitStoreOpcode to get the right opcode while
25678 initializing the array.
25680 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
25681 we can use this elsewhere.
25683 * statement.cs: Finish implementation of foreach for single
25686 * cs-parser.jay: Use an out-of-band stack to pass information
25687 around, I wonder why I need this.
25689 foreach_block: Make the new foreach_block the current_block.
25691 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
25692 function used to return a static Parameters structure. Used for
25693 empty parameters, as those are created very frequently.
25695 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
25697 2001-11-15 Ravi Pratap <ravi@ximian.com>
25699 * interface.cs : Default modifier is private, not public. The
25700 make verify test passes again.
25702 2001-11-15 Ravi Pratap <ravi@ximian.com>
25704 * support.cs (ReflectionParameters): Fix logic to determine
25705 whether the last parameter is a params one. Test 9 passes again.
25707 * delegate.cs (Populate): Register the builders we define with
25708 RegisterParameterForBuilder. Test 19 passes again.
25710 * cs-parser.jay (property_declaration): Reference $6 instead
25711 of $$ to get at the location.
25713 (indexer_declaration): Similar stuff.
25715 (attribute): Ditto.
25717 * class.cs (Property): Register parameters for the Get and Set methods
25718 if they exist. Test 23 passes again.
25720 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
25721 call to EmitArguments as we are sure there aren't any params arguments.
25722 Test 32 passes again.
25724 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
25725 IndexOutOfRangeException.
25727 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
25728 Test 33 now passes again.
25730 2001-11-15 Miguel de Icaza <miguel@ximian.com>
25732 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
25733 broke a bunch of things. Will have to come up with a better way
25734 of tracking locations.
25736 * statement.cs: Implemented foreach for single dimension arrays.
25738 2001-11-09 Miguel de Icaza <miguel@ximian.com>
25740 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
25741 an error. This removes the lookup from the critical path.
25743 * cs-parser.jay: Removed use of temporary_loc, which is completely
25746 2001-11-14 Miguel de Icaza <miguel@ximian.com>
25748 * support.cs (ReflectionParameters.ParameterModifier): Report
25749 whether the argument is a PARAMS argument or not.
25751 * class.cs: Set the attribute `ParamArrayAttribute' on the
25752 parameter argument.
25754 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
25755 and cons_param_array_attribute (ConstructorInfo for
25756 ParamArrayAttribute).,
25758 * codegen.cs: Emit the return using the `Return' statement, that
25759 way we can report the error correctly for missing return values.
25761 * class.cs (Method.Emit): Clean up.
25763 * expression.cs (Argument.Resolve): Take another argument: the
25764 location where this argument is used. Notice that this is not
25765 part of the "Argument" class as to reduce the size of the
25766 structure (we know the approximate location anyways).
25768 Test if the argument is a variable-reference, if not, then
25769 complain with a 206.
25771 (Argument.Emit): Emit addresses of variables.
25773 (Argument.FullDesc): Simplify.
25775 (Invocation.DoResolve): Update for Argument.Resolve.
25777 (ElementAccess.DoResolve): ditto.
25779 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
25780 method should be virtual, as this method is always virtual.
25782 (NewDelegate.DoResolve): Update for Argument.Resolve.
25784 * class.cs (ConstructorInitializer.DoResolve): ditto.
25786 * attribute.cs (Attribute.Resolve): ditto.
25788 2001-11-13 Miguel de Icaza <miguel@ximian.com>
25790 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
25792 * expression.cs (ParameterReference): Drop IStackStorage and implement
25793 IAssignMethod instead.
25795 (LocalVariableReference): ditto.
25797 * ecore.cs (FieldExpr): Drop IStackStorage and implement
25798 IAssignMethod instead.
25800 2001-11-13 Miguel de Icaza <miguel@ximian.com>
25802 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
25803 enumerations that are used in heavily used structures derive from
25804 byte in a laughable and pathetic attempt to reduce memory usage.
25805 This is the kind of pre-optimzations that you should not do at
25806 home without adult supervision.
25808 * expression.cs (UnaryMutator): New class, used to handle ++ and
25809 -- separatedly from the other unary operators. Cleans up the
25810 code, and kills the ExpressionStatement dependency in Unary.
25812 (Unary): Removed `method' and `Arguments' from this class, making
25813 it smaller, and moving it all to SimpleCall, so I can reuse this
25814 code in other locations and avoid creating a lot of transient data
25815 strucutres when not required.
25817 * cs-parser.jay: Adjust for new changes.
25819 2001-11-11 Miguel de Icaza <miguel@ximian.com>
25821 * enum.cs (Enum.Populate): If there is a failure during
25824 * cs-parser.jay (opt_enum_base): we used to catch type errors
25825 here, but this is really incorrect. The type error should be
25826 catched during semantic analysis.
25828 2001-12-11 Ravi Pratap <ravi@ximian.com>
25830 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
25831 current_local_parameters as expected since I, in my stupidity, had forgotten
25834 * attribute.cs (GetValidPlaces): Fix stupid bug.
25836 * class.cs (Method::Emit): Perform check on applicability of attributes.
25838 (Constructor::Emit): Ditto.
25840 (Field::Emit): Ditto.
25842 (Field.Location): Store location information.
25844 (Property, Event, Indexer, Operator): Ditto.
25846 * cs-parser.jay (field_declaration): Pass in location for each field.
25848 * ../errors/cs0592.cs : Add.
25850 2001-11-12 Ravi Pratap <ravi@ximian.com>
25852 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
25854 (InitCoreTypes): Update accordingly.
25856 (RegisterAttrType, LookupAttr): Implement.
25858 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
25859 info about the same.
25861 (Resolve): Update to populate the above as necessary.
25863 (Error592): Helper.
25865 (GetValidPlaces): Helper to the above.
25867 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
25869 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
25871 2001-11-12 Ravi Pratap <ravi@ximian.com>
25873 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
25875 * ../errors/cs0617.cs : Add.
25877 2001-11-11 Ravi Pratap <ravi@ximian.com>
25879 * enum.cs (Emit): Rename to Populate to be more consistent with what
25880 we expect it to do and when exactly it is called.
25882 * class.cs, rootcontext.cs : Update accordingly.
25884 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
25885 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
25887 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
25889 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
25890 of a fieldinfo using the above, when dealing with a FieldBuilder.
25892 2001-11-10 Ravi Pratap <ravi@ximian.com>
25894 * ../errors/cs0031.cs : Add.
25896 * ../errors/cs1008.cs : Add.
25898 * ../errrors/cs0543.cs : Add.
25900 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
25903 (FindMembers): Implement.
25905 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
25906 enums and delegates too.
25908 (enum_types): Rename to builder_to_enum.
25910 (delegate_types): Rename to builder_to_delegate.
25912 * delegate.cs (FindMembers): Implement.
25914 2001-11-09 Ravi Pratap <ravi@ximian.com>
25916 * typemanager.cs (IsEnumType): Implement.
25918 * enum.cs (Emit): Re-write parts to account for the underlying type
25919 better and perform checking etc.
25921 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
25922 of the underlying type.
25924 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
25927 * enum.cs (error31): Helper to report error #31.
25929 * cs-parser.jay (enum_declaration): Store location of each member too.
25931 * enum.cs (member_to_location): New hashtable.
25933 (AddEnumMember): Update location hashtable.
25935 (Emit): Use the location of each member while reporting errors.
25937 2001-11-09 Miguel de Icaza <miguel@ximian.com>
25939 * cs-parser.jay: A for_initializer if is a
25940 local_variable_declaration really ammount to have an implicit
25941 block with the variable declaration and no initializer for for.
25943 * statement.cs (For.Emit): Cope with null initializers.
25945 This fixes the infinite loop on for initializers.
25947 2001-11-08 Miguel de Icaza <miguel@ximian.com>
25949 * enum.cs: More cleanup.
25951 * ecore.cs: Remove dead code.
25953 * class.cs (Property.Emit): More simplification.
25954 (Event.Emit): ditto.
25956 Reworked to have less levels of indentation.
25958 2001-11-08 Ravi Pratap <ravi@ximian.com>
25960 * class.cs (Property): Emit attributes.
25970 * enum.cs (Emit): Ditto.
25972 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
25975 * class.cs (Field, Event, etc.): Move attribute generation into the
25976 Emit method everywhere.
25978 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
25979 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
25980 as we had no way of defining nested enums !
25982 * rootcontext.cs : Adjust code accordingly.
25984 * typemanager.cs (AddEnumType): To keep track of enum types separately.
25986 2001-11-07 Ravi Pratap <ravi@ximian.com>
25988 * expression.cs (EvalConstantExpression): Move into ecore.cs
25990 * enum.cs (Enum): Rename some members and make them public and readonly
25991 according to our convention.
25993 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
25996 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
25998 (Enum::Emit): Write a simple version for now which doesn't try to compute
25999 expressions. I shall modify this to be more robust in just a while.
26001 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
26003 (TypeContainer::CloseType): Create the Enum types too.
26005 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
26007 * expression.cs (EvalConstantExpression): Get rid of completely.
26009 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
26010 user-defined values and other cases.
26012 (IsValidEnumLiteral): Helper function.
26014 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
26015 out there in the case we had a literal FieldExpr.
26017 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
26019 (Literalize): Revamp a bit to take two arguments.
26021 (EnumLiteral): New class which derives from Literal to wrap enum literals.
26023 2001-11-06 Ravi Pratap <ravi@ximian.com>
26025 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
26027 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
26029 (Resolve): Use the above to ensure we have proper initializers.
26031 2001-11-05 Ravi Pratap <ravi@ximian.com>
26033 * expression.cs (Expression::EvalConstantExpression): New method to
26034 evaluate constant expressions.
26036 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
26038 2001-11-07 Miguel de Icaza <miguel@ximian.com>
26040 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
26043 (Binary.ResolveOperator): Handle operator != (object a, object b)
26044 and operator == (object a, object b);
26046 (Binary.DoNumericPromotions): Indicate whether the numeric
26047 promotion was possible.
26049 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
26052 Made the ArrayAccess implement interface IAssignMethod instead of
26053 IStackStore as the order in which arguments are passed reflects
26056 * assign.cs: Instead of using expr.ExprClass to select the way of
26057 assinging, probe for the IStackStore/IAssignMethod interfaces.
26059 * typemanager.cs: Load InitializeArray definition.
26061 * rootcontext.cs (RootContext.MakeStaticData): Used to define
26062 static data that can be used to initialize arrays.
26064 2001-11-05 Miguel de Icaza <miguel@ximian.com>
26066 * expression.cs: Handle operator== and operator!= for booleans.
26068 (Conditioal.Reduce): Implement reducer for the ?: operator.
26070 (Conditional.Resolve): Implement dead code elimination.
26072 (Binary.Resolve): Catch string literals and return a new
26073 concatenated string.
26075 (Unary.Reduce): Implement reduction of unary expressions.
26077 * ecore.cs: Split out the expression core handling here.
26079 (Expression.Reduce): New method used to perform constant folding
26080 and CSE. This is needed to support constant-expressions.
26082 * statement.cs (Statement.EmitBoolExpression): Pass true and false
26083 targets, and optimize for !x.
26085 2001-11-04 Ravi Pratap <ravi@ximian.com>
26087 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
26088 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
26089 set custom atttributes.
26091 * literal.cs (Literal::GetValue): New abstract method to return the actual
26092 value of the literal, cast as an object.
26094 (*Literal): Implement GetValue method.
26096 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
26097 expressions to the arraylist but objects of type Argument.
26099 * class.cs (TypeContainer::Emit): Emit our attributes too.
26101 (Method::Emit, Constructor::Emit): Ditto.
26103 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
26104 to be ignoring earlier.
26106 2001-11-03 Ravi Pratap <ravi@ximian.com>
26108 * attribute.cs (AttributeSection::Define): Implement to do the business
26109 of constructing a CustomAttributeBuilder.
26111 (Attribute): New trivial class. Increases readability of code.
26113 * cs-parser.jay : Update accordingly.
26115 (positional_argument_list, named_argument_list, named_argument): New rules
26117 (attribute_arguments): Use the above so that we are more correct.
26119 2001-11-02 Ravi Pratap <ravi@ximian.com>
26121 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
26122 to perform all checks for a method with a params parameter.
26124 (Invocation::OverloadResolve): Update to use the above method and therefore
26125 cope correctly with params method invocations.
26127 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
26130 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
26131 constructors in our parent too because we can't afford to miss out on
26134 * attribute.cs (AttributeSection): New name for the class Attribute
26136 Other trivial changes to improve readability.
26138 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
26139 use the new class names.
26141 2001-11-01 Ravi Pratap <ravi@ximian.com>
26143 * class.cs (Method::Define): Complete definition for params types too
26145 (Indexer::Define): Ditto.
26147 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
26148 Cope everywhere with a request for info about the array parameter.
26150 2001-11-01 Ravi Pratap <ravi@ximian.com>
26152 * tree.cs (RecordNamespace): Fix up to check for the correct key.
26154 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
26155 local_variable_type to extract the string corresponding to the type.
26157 (local_variable_type): Fixup the action to use the new helper method.
26159 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
26162 * expression.cs : Clean out code which uses the above.
26164 2001-10-31 Ravi Pratap <ravi@ximian.com>
26166 * typemanager.cs (RegisterMethod): Check if we already have an existing key
26167 and bale out if necessary by returning a false.
26169 (RegisterProperty): Ditto.
26171 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
26172 and print out appropriate error messages.
26174 * interface.cs (everywhere): Ditto.
26176 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
26177 location to constructor.
26179 * class.cs (Property, Event, Indexer): Update accordingly.
26181 * ../errors/cs111.cs : Added.
26183 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
26184 of a method, as laid down by the spec.
26186 (Invocation::OverloadResolve): Use the above method.
26188 2001-10-31 Ravi Pratap <ravi@ximian.com>
26190 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
26191 now take a TypeContainer and a Parameters object.
26193 (ParameterData): Modify return type of ParameterModifier method to be
26194 Parameter.Modifier and not a string.
26196 (ReflectionParameters, InternalParameters): Update accordingly.
26198 * expression.cs (Argument::GetParameterModifier): Same here.
26200 * support.cs (InternalParameters::ParameterType): Find a better way of determining
26201 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
26202 symbol in it at all so maybe this is only for now.
26204 2001-10-30 Ravi Pratap <ravi@ximian.com>
26206 * support.cs (InternalParameters): Constructor now takes an extra argument
26207 which is the actual Parameters class.
26209 (ParameterDesc): Update to provide info on ref/out modifiers.
26211 * class.cs (everywhere): Update call to InternalParameters to pass in
26212 the second argument too.
26214 * support.cs (ParameterData): Add ParameterModifier, which is a method
26215 to return the modifier info [ref/out etc]
26217 (InternalParameters, ReflectionParameters): Implement the above.
26219 * expression.cs (Argument::ParameterModifier): Similar function to return
26220 info about the argument's modifiers.
26222 (Invocation::OverloadResolve): Update to take into account matching modifiers
26225 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
26226 a new SetFormalParameters object which we pass to InternalParameters.
26228 2001-10-30 Ravi Pratap <ravi@ximian.com>
26230 * expression.cs (NewArray): Merge into the ArrayCreation class.
26232 2001-10-29 Ravi Pratap <ravi@ximian.com>
26234 * expression.cs (NewArray): Merge classes NewBuiltinArray and
26235 NewUserdefinedArray into one as there wasn't much of a use in having
26238 * expression.cs (Argument): Change field's name to ArgType from Type.
26240 (Type): New readonly property which returns the proper type, taking into
26241 account ref/out modifiers.
26243 (everywhere): Adjust code accordingly for the above.
26245 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
26246 whether we are emitting for a ref or out parameter.
26248 * expression.cs (Argument::Emit): Use the above field to set the state.
26250 (LocalVariableReference::Emit): Update to honour the flag and emit the
26253 * parameter.cs (Attributes): Set the correct flags for ref parameters.
26255 * expression.cs (Argument::FullDesc): New function to provide a full desc.
26257 * support.cs (ParameterData): Add method ParameterDesc to the interface.
26259 (ReflectionParameters, InternalParameters): Implement the above method.
26261 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
26264 (Invocation::FullMethodDesc): Ditto.
26266 2001-10-29 Miguel de Icaza <miguel@ximian.com>
26268 * cs-parser.jay: Add extra production for the second form of array
26271 * expression.cs (ArrayCreation): Update to reflect the above
26274 * Small changes to prepare for Array initialization.
26276 2001-10-28 Miguel de Icaza <miguel@ximian.com>
26278 * typemanager.cs (ImplementsInterface): interface might be null;
26279 Deal with this problem;
26281 Also, we do store negative hits on the cache (null values), so use
26282 this instead of calling t.GetInterfaces on the type everytime.
26284 2001-10-28 Ravi Pratap <ravi@ximian.com>
26286 * typemanager.cs (IsBuiltinType): New method to help determine the same.
26288 * expression.cs (New::DoResolve): Get rid of array creation code and instead
26289 split functionality out into different classes.
26291 (New::FormArrayType): Move into NewBuiltinArray.
26293 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
26296 (NewBuiltinArray): New class to handle creation of built-in arrays.
26298 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
26299 account creation of one-dimensional arrays.
26301 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
26303 (NewUserdefinedArray::DoResolve): Implement.
26305 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
26307 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
26308 we maintain inside the TypeManager. This is necessary to perform lookups on the
26311 (LookupType): Update to perform GetType on the module builders too.
26313 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
26315 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
26317 2001-10-23 Ravi Pratap <ravi@ximian.com>
26319 * expression.cs (New::DoResolve): Implement guts of array creation.
26321 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
26323 2001-10-27 Miguel de Icaza <miguel@ximian.com>
26325 * expression.cs: Fix bug I introduced lsat night that broke
26328 (Expression.Resolve): Report a 246 error (can not resolve name)
26329 if we find a SimpleName in the stream.
26331 (Expression.ResolveLValue): Ditto.
26333 (Expression.ResolveWithSimpleName): This function is a variant of
26334 ResolveName, this one allows SimpleNames to be returned without a
26335 warning. The only consumer of SimpleNames is MemberAccess
26337 2001-10-26 Miguel de Icaza <miguel@ximian.com>
26339 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
26340 might arrive here. I have my doubts that this is correct.
26342 * statement.cs (Lock): Implement lock statement.
26344 * cs-parser.jay: Small fixes to support `lock' and `using'
26346 * cs-tokenizer.cs: Remove extra space
26348 * driver.cs: New flag --checked, allows to turn on integer math
26351 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
26352 Threading.Monitor.Exit
26354 2001-10-23 Miguel de Icaza <miguel@ximian.com>
26356 * expression.cs (IndexerAccess::DoResolveLValue): Set the
26357 Expression Class to be IndexerAccess.
26359 Notice that Indexer::DoResolve sets the eclass to Value.
26361 2001-10-22 Miguel de Icaza <miguel@ximian.com>
26363 * class.cs (TypeContainer::Emit): Emit code for indexers.
26365 * assign.cs (IAssignMethod): New interface implemented by Indexers
26366 and Properties for handling assignment.
26368 (Assign::Emit): Simplify and reuse code.
26370 * expression.cs (IndexerAccess, PropertyExpr): Implement
26371 IAssignMethod, clean up old code.
26373 2001-10-22 Ravi Pratap <ravi@ximian.com>
26375 * typemanager.cs (ImplementsInterface): New method to determine if a type
26376 implements a given interface. Provides a nice cache too.
26378 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
26381 (ConvertReferenceExplicit): Ditto.
26383 * delegate.cs (Delegate::Populate): Update to define the parameters on the
26384 various methods, with correct names etc.
26386 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
26387 Operator.UnaryNegation.
26389 * cs-parser.jay (operator_declarator): Be a little clever in the case where
26390 we have a unary plus or minus operator.
26392 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
26395 * everywhere : update accordingly.
26397 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
26400 * class.cs (Method::Define): For the case where we are implementing a method
26401 inherited from an interface, we need to set the MethodAttributes.Final flag too.
26402 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
26404 2001-10-21 Ravi Pratap <ravi@ximian.com>
26406 * interface.cs (FindMembers): Implement to work around S.R.E
26409 * typemanager.cs (IsInterfaceType): Implement.
26411 (FindMembers): Update to handle interface types too.
26413 * expression.cs (ImplicitReferenceConversion): Re-write bits which
26414 use IsAssignableFrom as that is not correct - it doesn't work.
26416 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
26417 and accordingly override EmitStatement.
26419 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
26420 using the correct logic :-)
26422 2001-10-19 Ravi Pratap <ravi@ximian.com>
26424 * ../errors/cs-11.cs : Add to demonstrate error -11
26426 2001-10-17 Miguel de Icaza <miguel@ximian.com>
26428 * assign.cs (Assign::Resolve): Resolve right hand side first, and
26429 then pass this as a hint to ResolveLValue.
26431 * expression.cs (FieldExpr): Add Location information
26433 (FieldExpr::LValueResolve): Report assignment to readonly
26436 (Expression::ExprClassFromMemberInfo): Pass location information.
26438 (Expression::ResolveLValue): Add new method that resolves an
26441 (Expression::DoResolveLValue): Default invocation calls
26444 (Indexers): New class used to keep track of indexers in a given
26447 (IStackStore): Renamed from LValue, as it did not really describe
26448 what this did. Also ResolveLValue is gone from this interface and
26449 now is part of Expression.
26451 (ElementAccess): Depending on the element access type
26453 * typemanager.cs: Add `indexer_name_type' as a Core type
26454 (System.Runtime.CompilerServices.IndexerNameAttribute)
26456 * statement.cs (Goto): Take a location.
26458 2001-10-18 Ravi Pratap <ravi@ximian.com>
26460 * delegate.cs (Delegate::VerifyDelegate): New method to verify
26461 if two delegates are compatible.
26463 (NewDelegate::DoResolve): Update to take care of the case when
26464 we instantiate a delegate from another delegate.
26466 * typemanager.cs (FindMembers): Don't even try to look up members
26467 of Delegate types for now.
26469 2001-10-18 Ravi Pratap <ravi@ximian.com>
26471 * delegate.cs (NewDelegate): New class to take care of delegate
26474 * expression.cs (New): Split the delegate related code out into
26475 the NewDelegate class.
26477 * delegate.cs (DelegateInvocation): New class to handle delegate
26480 * expression.cs (Invocation): Split out delegate related code into
26481 the DelegateInvocation class.
26483 2001-10-17 Ravi Pratap <ravi@ximian.com>
26485 * expression.cs (New::DoResolve): Implement delegate creation fully
26486 and according to the spec.
26488 (New::DoEmit): Update to handle delegates differently.
26490 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
26491 because of which we were printing out arguments in reverse order !
26493 * delegate.cs (VerifyMethod): Implement to check if the given method
26494 matches the delegate.
26496 (FullDelegateDesc): Implement.
26498 (VerifyApplicability): Implement.
26500 * expression.cs (Invocation::DoResolve): Update to accordingly handle
26501 delegate invocations too.
26503 (Invocation::Emit): Ditto.
26505 * ../errors/cs1593.cs : Added.
26507 * ../errors/cs1594.cs : Added.
26509 * delegate.cs (InstanceExpression, TargetMethod): New properties.
26511 2001-10-16 Ravi Pratap <ravi@ximian.com>
26513 * typemanager.cs (intptr_type): Core type for System.IntPtr
26515 (InitCoreTypes): Update for the same.
26517 (iasyncresult_type, asynccallback_type): Ditto.
26519 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
26522 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
26525 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
26526 the builders for the 4 members of a delegate type :-)
26528 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
26531 * expression.cs (New::DoResolve): Implement guts for delegate creation.
26533 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
26535 2001-10-15 Miguel de Icaza <miguel@ximian.com>
26537 * statement.cs (Break::Emit): Implement.
26538 (Continue::Emit): Implement.
26540 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
26541 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
26542 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
26543 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
26546 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
26547 properties that track the label for the current loop (begin of the
26548 loop and end of the loop).
26550 2001-10-15 Ravi Pratap <ravi@ximian.com>
26552 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
26553 use of emitting anything at all.
26555 * class.cs, rootcontext.cs : Get rid of calls to the same.
26557 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
26559 (Populate): Define the constructor correctly and set the implementation
26562 * typemanager.cs (delegate_types): New hashtable to hold delegates that
26565 (AddDelegateType): Implement.
26567 (IsDelegateType): Implement helper method.
26569 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
26571 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
26572 and accordingly handle it.
26574 * delegate.cs (Populate): Take TypeContainer argument.
26575 Implement bits to define the Invoke method. However, I still haven't figured out
26576 how to take care of the native int bit :-(
26578 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
26579 Qualify the name of the delegate, not its return type !
26581 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
26584 (StandardConversionExists): Checking for array types turns out to be recursive.
26586 (ConvertReferenceExplicit): Implement array conversion.
26588 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
26590 2001-10-12 Ravi Pratap <ravi@ximian.com>
26592 * cs-parser.jay (delegate_declaration): Store the fully qualified
26593 name as it is a type declaration.
26595 * delegate.cs (ReturnType, Name): Rename members to these. Make them
26598 (DefineDelegate): Renamed from Define. Does the same thing essentially,
26599 as TypeContainer::DefineType.
26601 (Populate): Method in which all the definition of the various methods (Invoke)
26604 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
26607 (CloseDelegate): Finally creates the delegate.
26609 * class.cs (TypeContainer::DefineType): Update to define delegates.
26610 (Populate, Emit and CloseType): Do the same thing here too.
26612 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
26613 delegates in all these operations.
26615 2001-10-14 Miguel de Icaza <miguel@ximian.com>
26617 * expression.cs: LocalTemporary: a new expression used to
26618 reference a temporary that has been created.
26620 * assign.cs: Handle PropertyAccess back here, so that we can
26621 provide the proper semantic access to properties.
26623 * expression.cs (Expression::ConvertReferenceExplicit): Implement
26624 a few more explicit conversions.
26626 * modifiers.cs: `NEW' modifier maps to HideBySig.
26628 * expression.cs (PropertyExpr): Make this into an
26629 ExpressionStatement, and support the EmitStatement code path.
26631 Perform get/set error checking, clean up the interface.
26633 * assign.cs: recognize PropertyExprs as targets, and if so, turn
26634 them into toplevel access objects.
26636 2001-10-12 Miguel de Icaza <miguel@ximian.com>
26638 * expression.cs: PropertyExpr::PropertyExpr: use work around the
26641 * typemanager.cs: Keep track here of our PropertyBuilders again to
26642 work around lameness in SRE.
26644 2001-10-11 Miguel de Icaza <miguel@ximian.com>
26646 * expression.cs (LValue::LValueResolve): New method in the
26647 interface, used to perform a second resolution pass for LValues.
26649 (This::DoResolve): Catch the use of this in static methods.
26651 (This::LValueResolve): Implement.
26653 (This::Store): Remove warning, assigning to `this' in structures
26656 (Invocation::Emit): Deal with invocation of
26657 methods on value types. We need to pass the address to structure
26658 methods rather than the object itself. (The equivalent code to
26659 emit "this" for structures leaves the entire structure on the
26660 stack instead of a pointer to it).
26662 (ParameterReference::DoResolve): Compute the real index for the
26663 argument based on whether the method takes or not a `this' pointer
26664 (ie, the method is static).
26666 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
26667 value types returned from functions when we need to invoke a
26668 method on the sturcture.
26671 2001-10-11 Ravi Pratap <ravi@ximian.com>
26673 * class.cs (TypeContainer::DefineType): Method to actually do the business of
26674 defining the type in the Modulebuilder or Typebuilder. This is to take
26675 care of nested types which need to be defined on the TypeBuilder using
26676 DefineNestedMethod.
26678 (TypeContainer::GetClassBases): Implement. Essentially the code from the
26679 methods in RootContext, only ported to be part of TypeContainer.
26681 (TypeContainer::GetInterfaceOrClass): Ditto.
26683 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
26685 * interface.cs (Interface::DefineInterface): New method. Does exactly
26686 what RootContext.CreateInterface did earlier, only it takes care of nested types
26689 (Interface::GetInterfaces): Move from RootContext here and port.
26691 (Interface::GetInterfaceByName): Same here.
26693 * rootcontext.cs (ResolveTree): Re-write.
26695 (PopulateTypes): Re-write.
26697 * class.cs (TypeContainer::Populate): Populate nested types too.
26698 (TypeContainer::Emit): Emit nested members too.
26700 * typemanager.cs (AddUserType): Do not make use of the FullName property,
26701 instead just use the name argument passed in as it is already fully
26704 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
26705 to TypeContainer mapping to see if a type is user-defined.
26707 * class.cs (TypeContainer::CloseType): Implement.
26709 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
26710 the default constructor.
26712 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
26715 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
26717 * interface.cs (CloseType): Create the type here.
26719 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
26722 Remove all the methods which are now in TypeContainer.
26724 2001-10-10 Ravi Pratap <ravi@ximian.com>
26726 * delegate.cs (Define): Re-write bits to define the delegate
26729 2001-10-10 Miguel de Icaza <miguel@ximian.com>
26731 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
26733 * expression.cs (ImplicitReferenceConversion): handle null as well
26734 as a source to convert to any reference type.
26736 * statement.cs (Return): Perform any implicit conversions to
26737 expected return type.
26739 Validate use of return statement.
26741 * codegen.cs (EmitContext): Pass the expected return type here.
26743 * class.cs (Method, Constructor, Property): Pass expected return
26744 type to EmitContext.
26746 2001-10-09 Miguel de Icaza <miguel@ximian.com>
26748 * expression.cs: Make DoResolve take an EmitContext instead of a
26751 Replaced `l' and `location' for `loc', for consistency.
26753 (Error, Warning): Remove unneeded Tc argument.
26755 * assign.cs, literal.cs, constant.cs: Update to new calling
26758 * codegen.cs: EmitContext now contains a flag indicating whether
26759 code is being generated in a static method or not.
26761 * cs-parser.jay: DecomposeQI, new function that replaces the old
26762 QualifiedIdentifier. Now we always decompose the assembled
26763 strings from qualified_identifier productions into a group of
26766 2001-10-08 Miguel de Icaza <miguel@ximian.com>
26768 * rootcontext.cs: Deal with field-less struct types correctly now
26769 by passing the size option to Define Type.
26771 * class.cs: Removed hack that created one static field.
26773 2001-10-07 Miguel de Icaza <miguel@ximian.com>
26775 * statement.cs: Moved most of the code generation here.
26777 2001-10-09 Ravi Pratap <ravi@ximian.com>
26779 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
26782 (ElementAccess): Remove useless bits for now - keep checks as the spec
26785 2001-10-08 Ravi Pratap <ravi@ximian.com>
26787 * expression.cs (ElementAccess::DoResolve): Remove my crap code
26788 and start performing checks according to the spec.
26790 2001-10-07 Ravi Pratap <ravi@ximian.com>
26792 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
26793 rank_specifiers instead.
26795 (rank_specifiers): Change the order in which the rank specifiers are stored
26797 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
26799 * expression.cs (ElementAccess): Implement the LValue interface too.
26801 2001-10-06 Ravi Pratap <ravi@ximian.com>
26803 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
26804 except that user defined conversions are not included.
26806 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
26807 perform the conversion of the return type, if necessary.
26809 (New::DoResolve): Check whether we are creating an array or an object
26810 and accordingly do the needful.
26812 (New::Emit): Same here.
26814 (New::DoResolve): Implement guts of array creation.
26816 (New::FormLookupType): Helper function.
26818 2001-10-07 Miguel de Icaza <miguel@ximian.com>
26820 * codegen.cs: Removed most of the code generation here, and move the
26821 corresponding code generation bits to the statement classes.
26823 Added support for try/catch/finalize and throw.
26825 * cs-parser.jay: Added support for try/catch/finalize.
26827 * class.cs: Catch static methods having the flags override,
26828 virtual or abstract.
26830 * expression.cs (UserCast): This user cast was not really doing
26831 what it was supposed to do. Which is to be born in fully resolved
26832 state. Parts of the resolution were being performed at Emit time!
26836 2001-10-05 Miguel de Icaza <miguel@ximian.com>
26838 * expression.cs: Implicity convert the result from UserCast.
26840 2001-10-05 Ravi Pratap <ravi@ximian.com>
26842 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
26843 prevented it from working correctly.
26845 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
26846 merely ConvertImplicit.
26848 2001-10-05 Miguel de Icaza <miguel@ximian.com>
26850 * typemanager.cs: Make the LookupTypeContainer function static,
26851 and not per-instance.
26853 * class.cs: Make static FindMembers (the one that takes a Type
26856 * codegen.cs: Add EmitForeach here.
26858 * cs-parser.jay: Make foreach a toplevel object instead of the
26859 inline expansion, as we need to perform semantic analysis on it.
26861 2001-10-05 Ravi Pratap <ravi@ximian.com>
26863 * expression.cs (Expression::ImplicitUserConversion): Rename to
26864 UserDefinedConversion.
26866 (Expression::UserDefinedConversion): Take an extra argument specifying
26867 whether we look for explicit user conversions too.
26869 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
26871 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
26873 (ExplicitUserConversion): Make it a call to UserDefinedConversion
26874 with the appropriate arguments.
26876 * cs-parser.jay (cast_expression): Record location too.
26878 * expression.cs (Cast): Record location info.
26880 (Expression::ConvertExplicit): Take location argument.
26882 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
26883 to determine if we are doing explicit conversions.
26885 (UserCast::Emit): Update accordingly.
26887 (Expression::ConvertExplicit): Report an error if everything fails.
26889 * ../errors/cs0030.cs : Add.
26891 2001-10-04 Miguel de Icaza <miguel@ximian.com>
26893 * modifiers.cs: If the ABSTRACT keyword is present, also set the
26894 virtual and newslot bits.
26896 * class.cs (TypeContainer::RegisterRequiredImplementations):
26897 Record methods we need.
26899 (TypeContainer::MakeKey): Helper function to make keys for
26900 MethodBases, since the Methodbase key is useless.
26902 (TypeContainer::Populate): Call RegisterRequiredImplementations
26903 before defining the methods.
26905 Create a mapping for method_builders_to_methods ahead of time
26906 instead of inside a tight loop.
26908 (::RequireMethods): Accept an object as the data to set into the
26909 hashtable so we can report interface vs abstract method mismatch.
26911 2001-10-03 Miguel de Icaza <miguel@ximian.com>
26913 * report.cs: Make all of it static.
26915 * rootcontext.cs: Drop object_type and value_type computations, as
26916 we have those in the TypeManager anyways.
26918 Drop report instance variable too, now it is a global.
26920 * driver.cs: Use try/catch on command line handling.
26922 Add --probe option to debug the error reporting system with a test
26925 * report.cs: Add support for exiting program when a probe
26926 condition is reached.
26928 2001-10-03 Ravi Pratap <ravi@ximian.com>
26930 * expression.cs (Binary::DoNumericPromotions): Fix the case when
26931 we do a forcible conversion regardless of type, to check if
26932 ForceConversion returns a null.
26934 (Binary::error19): Use location to report error.
26936 (Unary::error23): Use location here too.
26938 * ../errors/cs0019.cs : Check in.
26940 * ../errors/cs0023.cs : Check in.
26942 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
26943 case of a non-null MethodInfo object with a length of 0 !
26945 (Binary::ResolveOperator): Flag error if overload resolution fails to find
26946 an applicable member - according to the spec :-)
26947 Also fix logic to find members in base types.
26949 (Unary::ResolveOperator): Same here.
26951 (Unary::report23): Change name to error23 and make first argument a TypeContainer
26952 as I was getting thoroughly confused between this and error19 :-)
26954 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
26955 (::FindMostEncompassedType): Implement.
26956 (::FindMostEncompassingType): Implement.
26957 (::StandardConversionExists): Implement.
26959 (UserImplicitCast): Re-vamp. We now need info about most specific
26960 source and target types so that we can do the necessary conversions.
26962 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
26963 mathematical union with no duplicates.
26965 2001-10-03 Miguel de Icaza <miguel@ximian.com>
26967 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
26968 in order from base classes to child classes, so that we can in
26969 child classes look up in our parent for method names and
26970 attributes (required for handling abstract, virtual, new, override
26971 constructs: we need to instrospect our base class, and if we dont
26972 populate the classes in order, the introspection might be
26973 incorrect. For example, a method could query its parent before
26974 the parent has any methods and would determine that the parent has
26975 no abstract methods (while it could have had them)).
26977 (RootContext::CreateType): Record the order in which we define the
26980 2001-10-02 Miguel de Icaza <miguel@ximian.com>
26982 * class.cs (TypeContainer::Populate): Also method definitions can
26983 fail now, keep track of this.
26985 (TypeContainer::FindMembers): Implement support for
26986 DeclaredOnly/noDeclaredOnly flag.
26988 (Constructor::Emit) Return the ConstructorBuilder.
26990 (Method::Emit) Return the MethodBuilder.
26991 Check for abstract or virtual methods to be public.
26993 * rootcontext.cs (RootContext::CreateType): Register all the
26994 abstract methods required for the class to be complete and the
26995 interface methods that must be implemented.
26997 * cs-parser.jay: Report error 501 (method requires body if it is
26998 not marked abstract or extern).
27000 * expression.cs (TypeOf::Emit): Implement.
27002 * typemanager.cs: runtime_handle_type, new global type.
27004 * class.cs (Property::Emit): Generate code for properties.
27006 2001-10-02 Ravi Pratap <ravi@ximian.com>
27008 * expression.cs (Unary::ResolveOperator): Find operators on base type
27009 too - we now conform exactly to the spec.
27011 (Binary::ResolveOperator): Same here.
27013 * class.cs (Operator::Define): Fix minor quirk in the tests.
27015 * ../errors/cs0215.cs : Added.
27017 * ../errors/cs0556.cs : Added.
27019 * ../errors/cs0555.cs : Added.
27021 2001-10-01 Miguel de Icaza <miguel@ximian.com>
27023 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
27024 single integer which is really efficient
27026 2001-10-01 Ravi Pratap <ravi@ximian.com>
27028 * expression.cs (Expression::ImplicitUserConversion): Use location
27029 even in the case when we are examining True operators.
27031 * class.cs (Operator::Define): Perform extensive checks to conform
27032 with the rules for operator overloading in the spec.
27034 * expression.cs (Expression::ImplicitReferenceConversion): Implement
27035 some of the other conversions mentioned in the spec.
27037 * typemanager.cs (array_type): New static member for the System.Array built-in
27040 (cloneable_interface): For System.ICloneable interface.
27042 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
27043 we start resolving the tree and populating types.
27045 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
27047 2001-10-01 Miguel de Icaza <miguel@ximian.com>
27049 * expression.cs (Expression::ExprClassFromMemberInfo,
27050 Expression::Literalize): Create literal expressions from
27051 FieldInfos which are literals.
27053 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
27054 type casts, because they were wrong. The test suite in tests
27057 (ImplicitNumericConversion): ushort to ulong requires a widening
27060 Int32 constant to long requires widening cast as well.
27062 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
27063 for integers because the type on the stack is not i4.
27065 2001-09-30 Miguel de Icaza <miguel@ximian.com>
27067 * expression.cs (report118): require location argument.
27069 * parameter.cs: Do not dereference potential null value.
27071 * class.cs: Catch methods that lack the `new' keyword when
27072 overriding a name. Report warnings when `new' is used without
27073 anything being there to override.
27075 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
27077 * class.cs: Only add constructor to hashtable if it is non-null
27078 (as now constructors can fail on define).
27080 (TypeManager, Class, Struct): Take location arguments.
27082 Catch field instance initialization in structs as errors.
27084 accepting_filter: a new filter for FindMembers that is static so
27085 that we dont create an instance per invocation.
27087 (Constructor::Define): Catch errors where a struct constructor is
27090 * cs-parser.jay: Pass location information for various new
27093 * delegate.cs (Delegate): take a location argument.
27095 * driver.cs: Do not call EmitCode if there were problesm in the
27096 Definition of the types, as many Builders wont be there.
27098 * decl.cs (Decl::Decl): Require a location argument.
27100 * cs-tokenizer.cs: Handle properly hex constants that can not fit
27101 into integers, and find the most appropiate integer for it.
27103 * literal.cs: Implement ULongLiteral.
27105 * rootcontext.cs: Provide better information about the location of
27106 failure when CreateType fails.
27108 2001-09-29 Miguel de Icaza <miguel@ximian.com>
27110 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
27113 * expression.cs (Binary::CheckShiftArguments): Add missing type
27115 (Binary::ResolveOperator): Add type to the logical and and logical
27116 or, Bitwise And/Or and Exclusive Or code paths, it was missing
27119 (Binary::DoNumericPromotions): In the case where either argument
27120 is ulong (and most signed types combined with ulong cause an
27121 error) perform implicit integer constant conversions as well.
27123 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27125 * expression.cs (UserImplicitCast): Method should always be
27127 (Invocation::BetterConversion): Simplified test for IntLiteral.
27129 (Expression::ImplicitNumericConversion): Split this routine out.
27130 Put the code that performs implicit constant integer conversions
27133 (Expression::Resolve): Become a wrapper around DoResolve so we can
27134 check eclass and type being set after resolve.
27136 (Invocation::Badness): Remove this dead function
27138 (Binary::ResolveOperator): Do not compute the expensive argumnets
27139 unless we have a union for it.
27141 (Probe::Emit): Is needs to do an isinst and then
27142 compare against null.
27144 (::CanConvert): Added Location argument. If the Location argument
27145 is null (Location.Null), then we do not report errors. This is
27146 used by the `probe' mechanism of the Explicit conversion. We do
27147 not want to generate an error for something that the user
27148 explicitly requested to be casted. But the pipeline for an
27149 explicit cast first tests for potential implicit casts.
27151 So for now, if the Location is null, it means `Probe only' to
27152 avoid adding another argument. Might have to revise this
27155 (ClassCast): New class used to type cast objects into arbitrary
27156 classes (used in Explicit Reference Conversions).
27158 Implement `as' as well.
27160 Reverted all the patches from Ravi below: they were broken:
27162 * The use of `level' as a mechanism to stop recursive
27163 invocations is wrong. That was there just to catch the
27164 bug with a strack trace but not as a way of addressing
27167 To fix the problem we have to *understand* what is going
27168 on and the interactions and come up with a plan, not
27169 just get things going.
27171 * The use of the type conversion cache that I proposed
27172 last night had an open topic: How does this work across
27173 protection domains. A user defined conversion might not
27174 be public in the location where we are applying the
27175 conversion, a different conversion might be selected
27176 (ie, private A->B (better) but public B->A (worse),
27177 inside A, A->B applies, but outside it, B->A will
27180 * On top of that (ie, even if the above is solved),
27181 conversions in a cache need to be abstract. Ie, `To
27182 convert from an Int to a Short use an OpcodeCast', not
27183 `To convert from an Int to a Short use the OpcodeCast on
27184 the variable 5' (which is what this patch was doing).
27186 2001-09-28 Ravi Pratap <ravi@ximian.com>
27188 * expression.cs (Invocation::ConversionExists): Re-write to use
27189 the conversion cache
27191 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
27192 cache all conversions done, not just user-defined ones.
27194 (Invocation::BetterConversion): The real culprit. Use ConversionExists
27195 to determine if a conversion exists instead of acutually trying to
27196 perform the conversion. It's faster too.
27198 (Expression::ConvertExplicit): Modify to use ConversionExists to check
27199 and only then attempt the implicit conversion.
27201 2001-09-28 Ravi Pratap <ravi@ximian.com>
27203 * expression.cs (ConvertImplicit): Use a cache for conversions
27204 already found. Check level of recursion and bail out if necessary.
27206 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27208 * typemanager.cs (string_concat_string_string, string_concat_object_object):
27209 Export standard methods that we expect for string operations.
27211 * statement.cs (Block::UsageWarning): Track usage of variables and
27212 report the errors for not used variables.
27214 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
27217 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27219 * codegen.cs: remove unnneded code
27221 * expression.cs: Removed BuiltinTypeAccess class
27223 Fix the order in which implicit conversions are
27226 The previous fixed dropped support for boxed conversions (adding a
27227 test to the test suite now)
27229 (UserImplicitCast::CanConvert): Remove test for source being null,
27230 that code is broken. We should not feed a null to begin with, if
27231 we do, then we should track the bug where the problem originates
27232 and not try to cover it up here.
27234 Return a resolved expression of type UserImplicitCast on success
27235 rather than true/false. Ravi: this is what I was talking about,
27236 the pattern is to use a static method as a "constructor" for
27239 Also, do not create arguments until the very last minute,
27240 otherwise we always create the arguments even for lookups that
27241 will never be performed.
27243 (UserImplicitCast::Resolve): Eliminate, objects of type
27244 UserImplicitCast are born in a fully resolved state.
27246 * typemanager.cs (InitCoreTypes): Init also value_type
27247 (System.ValueType).
27249 * expression.cs (Cast::Resolve): First resolve the child expression.
27251 (LValue): Add new method AddressOf to be used by
27254 Change the argument of Store to take an EmitContext instead of an
27255 ILGenerator, because things like FieldExpr need to be able to call
27256 their children expression to generate the instance code.
27258 (Expression::Error, Expression::Warning): Sugar functions for
27261 (Expression::MemberLookup): Accept a TypeContainer instead of a
27262 Report as the first argument.
27264 (Expression::ResolvePrimary): Killed. I still want to improve
27265 this as currently the code is just not right.
27267 (Expression::ResolveMemberAccess): Simplify, but it is still
27270 (Unary::Resolve): Catch errors in AddressOf operators.
27272 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
27273 index to a byte for the short-version, or the compiler will choose
27274 the wrong Emit call, which generates the wrong data.
27276 (ParameterReference::Emit, ::Store): same.
27278 (FieldExpr::AddressOf): Implement.
27280 * typemanager.cs: TypeManager: made public variable instead of
27283 * driver.cs: document --fatal.
27285 * report.cs (ErrorMessage, WarningMessage): new names for the old
27286 Error and Warning classes.
27288 * cs-parser.jay (member_access): Turn built-in access to types
27289 into a normal simplename
27291 2001-09-27 Ravi Pratap <ravi@ximian.com>
27293 * expression.cs (Invocation::BetterConversion): Fix to cope
27294 with q being null, since this was introducing a bug.
27296 * expression.cs (ConvertImplicit): Do built-in conversions first.
27298 2001-09-27 Ravi Pratap <ravi@ximian.com>
27300 * expression.cs (UserImplicitCast::Resolve): Fix bug.
27302 2001-09-27 Ravi Pratap <ravi@ximian.com>
27304 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
27305 I had introduced long ago (what's new ?).
27307 * expression.cs (UserImplicitCast::CanConvert): Static method to do
27308 the work of all the checking.
27309 (ConvertImplicit): Call CanConvert and only then create object if necessary.
27310 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
27312 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
27313 that is the right way.
27315 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
27316 overloading resolution. Use everywhere instead of cutting and pasting code.
27318 (Binary::ResolveOperator): Use MakeUnionSet.
27320 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
27321 we have to convert to bool types. Not complete yet.
27323 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27325 * typemanager.cs (TypeManager::CSharpName): support ushort.
27327 * expression.cs (Expression::TryImplicitIntConversion): Attempts
27328 to provide an expression that performsn an implicit constant int
27329 conversion (section 6.1.6).
27330 (Expression::ConvertImplicitRequired): Reworked to include
27331 implicit constant expression conversions.
27333 (Expression::ConvertNumericExplicit): Finished.
27335 (Invocation::Emit): If InstanceExpression is null, then it means
27336 that we perform a call on this.
27338 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27340 * expression.cs (Unary::Emit): Remove some dead code.
27341 (Probe): Implement Resolve and Emit for `is'.
27342 (Expression::ConvertImplicitRequired): Attempt to do constant
27343 expression conversions here. Maybe should be moved to
27344 ConvertImplicit, but I am not sure.
27345 (Expression::ImplicitLongConstantConversionPossible,
27346 Expression::ImplicitIntConstantConversionPossible): New functions
27347 that tell whether is it possible to apply an implicit constant
27348 expression conversion.
27350 (ConvertNumericExplicit): Started work on explicit numeric
27353 * cs-parser.jay: Update operator constants.
27355 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
27356 (Parameters::GetSignature): Hook up VerifyArgs here.
27357 (Parameters::VerifyArgs): Verifies that no two arguments have the
27360 * class.cs (Operator): Update the operator names to reflect the
27361 ones that the spec expects (as we are just stringizing the
27364 * expression.cs (Unary::ResolveOperator): Fix bug: Use
27365 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
27366 previous usage did only work for our methods.
27367 (Expression::ConvertImplicit): Handle decimal implicit numeric
27368 conversions as well.
27369 (Expression::InternalTypeConstructor): Used to invoke constructors
27370 on internal types for default promotions.
27372 (Unary::Emit): Implement special handling for the pre/post
27373 increment/decrement for overloaded operators, as they need to have
27374 the same semantics as the other operators.
27376 (Binary::ResolveOperator): ditto.
27377 (Invocation::ConversionExists): ditto.
27378 (UserImplicitCast::Resolve): ditto.
27380 2001-09-26 Ravi Pratap <ravi@ximian.com>
27382 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
27383 operator, return after emitting body. Regression tests pass again !
27385 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
27386 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
27387 (Invocation::OverloadResolve): Ditto.
27388 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
27390 * everywhere : update calls to the above methods accordingly.
27392 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27394 * assign.cs (Assign): Make it inherit from ExpressionStatement.
27396 * expression.cs (ExpressionStatement): New base class used for
27397 expressions that can appear in statements, so that we can provide
27398 an alternate path to generate expression that do not leave a value
27401 (Expression::Emit, and all the derivatives): We no longer return
27402 whether a value is left on the stack or not. Every expression
27403 after being emitted leaves a single value on the stack.
27405 * codegen.cs (EmitContext::EmitStatementExpression): Use the
27406 facilties of ExpressionStatement if possible.
27408 * cs-parser.jay: Update statement_expression.
27410 2001-09-25 Miguel de Icaza <miguel@ximian.com>
27412 * driver.cs: Change the wording of message
27414 2001-09-25 Ravi Pratap <ravi@ximian.com>
27416 * expression.cs (Binary::ResolveOperator): Had forgottten to set
27417 the type of the expression to the return type of the method if
27418 we have an overloaded operator match ! The regression tests pass again !
27419 (Unary::ResolveOperator): Ditto.
27421 * expression.cs (Invocation::ConversionExists): Correct the member lookup
27422 to find "op_Implicit", not "implicit" ;-)
27423 (UserImplicitCast): New class to take care of user-defined implicit conversions.
27424 (ConvertImplicit, ForceConversion): Take TypeContainer argument
27426 * everywhere : Correct calls to the above accordingly.
27428 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
27429 (ConvertImplicit): Do user-defined conversion if it exists.
27431 2001-09-24 Miguel de Icaza <miguel@ximian.com>
27433 * assign.cs: track location.
27434 (Resolve): Use implicit conversions on assignment.
27436 * literal.cs: Oops. Not good, Emit of short access values should
27437 pass (Bytes) or the wrong argument will be selected.
27439 * expression.cs (Unary::Emit): Emit code for -expr.
27441 (Unary::ResolveOperator): Handle `Substract' for non-constants
27442 (substract from zero from the non-constants).
27443 Deal with Doubles as well.
27445 (Expression::ConvertImplicitRequired): New routine that reports an
27446 error if no implicit conversion exists.
27448 (Invocation::OverloadResolve): Store the converted implicit
27449 expressions if we make them
27451 2001-09-24 Ravi Pratap <ravi@ximian.com>
27453 * class.cs (ConstructorInitializer): Take a Location argument.
27454 (ConstructorBaseInitializer): Same here.
27455 (ConstructorThisInitializer): Same here.
27457 * cs-parser.jay : Update all calls accordingly.
27459 * expression.cs (Unary, Binary, New): Take location argument.
27460 Update accordingly everywhere.
27462 * cs-parser.jay : Update all calls to the above to take a location
27465 * class.cs : Ditto.
27467 2001-09-24 Ravi Pratap <ravi@ximian.com>
27469 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
27470 (Invocation::BetterConversion): Same here
27471 (Invocation::ConversionExists): Ditto.
27473 (Invocation::ConversionExists): Implement.
27475 2001-09-22 Ravi Pratap <ravi@ximian.com>
27477 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
27478 Also take an additional TypeContainer argument.
27480 * All over : Pass in TypeContainer as argument to OverloadResolve.
27482 * typemanager.cs (CSharpName): Update to check for the string type and return
27485 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
27488 2001-09-21 Ravi Pratap <ravi@ximian.com>
27490 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
27491 (Invocation::BetterFunction): Implement.
27492 (Invocation::BetterConversion): Implement.
27493 (Invocation::ConversionExists): Skeleton, no implementation yet.
27495 Okay, things work fine !
27497 2001-09-21 Miguel de Icaza <miguel@ximian.com>
27499 * typemanager.cs: declare and load enum_type, delegate_type and
27502 * expression.cs (Expression::Emit): Now emit returns a value that
27503 tells whether a value is left on the stack or not. This strategy
27504 might be reveted tomorrow with a mechanism that would address
27505 multiple assignments.
27506 (Expression::report118): Utility routine to report mismatches on
27509 (Unary::Report23): Report impossible type/operator combination
27512 (Unary::IsIncrementableNumber): Whether the type can be
27513 incremented or decremented with add.
27514 (Unary::ResolveOperator): Also allow enumerations to be bitwise
27516 (Unary::ResolveOperator): Implement ++, !, ~,
27518 (Invocation::Emit): Deal with new Emit convetion.
27520 * All Expression derivatives: Updated their Emit method to return
27521 whether they leave values on the stack or not.
27523 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
27524 stack for expressions that are statements.
27526 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27528 * expression.cs (LValue): New interface. Must be implemented by
27530 (LocalVariableReference, ParameterReference, FieldExpr): Implement
27533 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
27534 interface for generating code, simplifies the code.
27536 2001-09-20 Ravi Pratap <ravi@ximian.com>
27538 * expression.cs (everywhere): Comment out return statements in ::Resolve
27539 methods to avoid the warnings.
27541 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27543 * driver.cs (parse): Report error 2001 if we can not open the
27546 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
27549 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
27552 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
27553 otherwise nested blocks end up with the same index.
27555 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
27557 * expression.cs: Instead of having FIXMEs in the Resolve
27558 functions, throw exceptions so it is obvious that we are facing a
27561 * cs-parser.jay (invocation_expression): Pass Location information.
27563 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
27564 Use a basename for those routines because .NET does not like paths
27567 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
27570 2001-09-19 Miguel de Icaza <miguel@ximian.com>
27572 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
27573 are loading the correct data types (throws an exception if not).
27574 (TypeManager::InitCoreTypes): Use CoreLookupType
27576 * expression.cs (Unary::ResolveOperator): return the child
27577 expression for expressions which are just +expr.
27578 (Unary::ResolveOperator): Return negative literals for -LITERAL
27579 expressions (otherwise they are Unary {Literal}).
27580 (Invocation::Badness): Take into account `Implicit constant
27581 expression conversions'.
27583 * literal.cs (LongLiteral): Implement long literal class.
27584 (IntLiteral): export the `Value' of the intliteral.
27586 2001-09-19 Ravi Pratap <ravi@ximian.com>
27588 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
27590 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
27591 instead of 'Operator'
27593 * expression.cs (Binary::ResolveOperator): Update accordingly.
27594 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
27597 * cs-parser.jay (unary_expression): Update to use the new names.
27599 * gen-treedump.cs (GetUnary): Same here.
27601 * expression.cs (Unary::Resolve): Implement.
27602 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
27603 operators are found instead of making noise ;-)
27604 (Unary::ResolveOperator): New method to do precisely the same thing which
27605 Binary::ResolveOperator does for Binary expressions.
27606 (Unary.method, .Arguments): Add.
27607 (Unary::OperName): Implement.
27608 (Unary::ForceConversion): Copy and Paste !
27610 * class.cs (Operator::Define): Fix a small bug for the case when we have
27613 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
27614 for the inbuilt operators. Only overloading works for now ;-)
27616 2001-09-18 Miguel de Icaza <miguel@ximian.com>
27618 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
27619 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
27621 * expression.cs (This::Emit): Implement.
27622 (This::Resolve): Implement.
27623 (TypeOf:Resolve): Implement.
27624 (Expression::ResolveSimpleName): Add an implicit this to instance
27626 (MemberAccess::Resolve): Deal with Parameters and Fields.
27627 Bind instance variable to Field expressions.
27628 (FieldExpr::Instance): New field used to track the expression that
27629 represents the object instance.
27630 (FieldExpr::Resolve): Track potential errors from MemberLookup not
27632 (FieldExpr::Emit): Implement.
27634 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
27635 the last instruction contains a return opcode to avoid generating
27636 the last `ret' instruction (this generates correct code, and it is
27637 nice to pass the peverify output).
27639 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
27640 initializer for static and instance variables.
27641 (Constructor::Emit): Allow initializer to be null in the case of
27642 static constructors. Only emit initializer for instance
27645 (TypeContainer::FindMembers): Return a null array if there are no
27648 Also fix the code for the MemberTypes.Method branch, as it was not
27649 scanning that for operators (or tried to access null variables before).
27651 * assign.cs (Assign::Emit): Handle instance and static fields.
27655 * driver.cs: Stop compilation if there are parse errors.
27657 * cs-parser.jay (constructor_declaration): Provide default base
27658 initializer for non-static constructors.
27659 (constructor_declarator): Do not provide a default base
27660 initializers if none was specified.
27661 Catch the fact that constructors should not have parameters.
27663 * class.cs: Do not emit parent class initializers for static
27664 constructors, that should be flagged as an error.
27666 2001-09-18 Ravi Pratap <ravi@ximian.com>
27668 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
27669 Move back code into TypeContainer::Populate.
27671 2001-09-18 Ravi Pratap <ravi@ximian.com>
27673 * class.cs (TypeContainer::AddConstructor): Fix the check to
27674 compare against Name, not Basename.
27675 (Operator::OpType): Change Plus and Minus to Add and Subtract.
27677 * cs-parser.jay : Update accordingly.
27679 * class.cs (TypeContainer::FindMembers): For the case where we are searching
27680 for methods, don't forget to look into the operators too.
27681 (RegisterMethodBuilder): Helper method to take care of this for
27682 methods, constructors and operators.
27683 (Operator::Define): Completely revamp.
27684 (Operator.OperatorMethod, MethodName): New fields.
27685 (TypeContainer::Populate): Move the registering of builders into
27686 RegisterMethodBuilder.
27687 (Operator::Emit): Re-write.
27689 * expression.cs (Binary::Emit): Comment out code path to emit method
27690 invocation stuff for the case when we have a user defined operator. I am
27691 just not able to get it right !
27693 2001-09-17 Miguel de Icaza <miguel@ximian.com>
27695 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
27698 (Expression::MemberLookup): Provide a version that allows to
27699 specify the MemberTypes and BindingFlags.
27701 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
27702 so it was not fetching variable information from outer blocks.
27704 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
27705 Beforefieldinit as it was buggy.
27707 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
27708 that Ravi put here.
27710 * class.cs (Constructor::Emit): Only emit if block is not null.
27711 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
27712 deal with this by semantically definining it as if the user had
27715 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
27716 constructors as we now "emit" them at a higher level.
27718 (TypeContainer::DefineDefaultConstructor): Used to define the
27719 default constructors if none was provided.
27721 (ConstructorInitializer): Add methods Resolve and Emit.
27723 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
27725 2001-09-17 Ravi Pratap <ravi@ximian.com>
27727 * class.cs (TypeContainer::EmitDefaultConstructor): Register
27728 the default constructor builder with our hashtable for methodbuilders
27731 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
27732 and argument_count is 0 in which case we have a match.
27733 (Binary::ResolveOperator): More null checking and miscellaneous coding
27736 2001-09-17 Ravi Pratap <ravi@ximian.com>
27738 * rootcontext.cs (IsNameSpace): Compare against null.
27740 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
27742 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
27743 and Unary::Operator.
27745 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
27748 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
27749 we have overloaded operators.
27750 (Binary::ResolveOperator): Implement the part which does the operator overload
27753 * class.cs (Operator::Emit): Implement.
27754 (TypeContainer::Emit): Emit the operators we have too.
27756 * expression.cs (Binary::Emit): Update to emit the appropriate code for
27757 the case when we have a user-defined operator.
27759 2001-09-17 Miguel de Icaza <miguel@ximian.com>
27761 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
27763 2001-09-16 Ravi Pratap <ravi@ximian.com>
27765 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
27766 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
27767 (Constructor::Emit): Implement.
27768 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
27769 if we have no work to do.
27770 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
27773 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
27774 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
27776 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
27779 2001-09-15 Ravi Pratap <ravi@ximian.com>
27781 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
27783 (Tree::RecordNamespace): Method to do what the name says ;-)
27784 (Tree::Namespaces): Property to get at the namespaces hashtable.
27786 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
27789 * rootcontext.cs (IsNamespace): Fixed it :-)
27791 2001-09-14 Miguel de Icaza <miguel@ximian.com>
27793 * class.cs (TypeContainer::FindMembers): Add support for
27795 (MethodCore): New class that encapsulates both the shared aspects
27796 of a Constructor and a Method.
27797 (Method, Constructor): Factored pieces into MethodCore.
27799 * driver.cs: Added --fatal which makes errors throw exceptions.
27800 Load System assembly as well as part of the standard library.
27802 * report.cs: Allow throwing exceptions on errors for debugging.
27804 * modifiers.cs: Do not use `parent', instead use the real type
27805 container to evaluate permission settings.
27807 * class.cs: Put Ravi's patch back in. He is right, and we will
27808 have to cope with the
27810 2001-09-14 Ravi Pratap <ravi@ximian.com>
27812 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
27813 FamORAssem, not FamANDAssem.
27815 2001-09-14 Miguel de Icaza <miguel@ximian.com>
27817 * driver.cs: Added --parse option that only parses its input files
27820 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
27821 incorrect. IsTopLevel is not used to tell whether an object is
27822 root_types or not (that can be achieved by testing this ==
27823 root_types). But to see if this is a top-level *class* (not
27824 necessarly our "toplevel" container).
27826 2001-09-14 Ravi Pratap <ravi@ximian.com>
27828 * enum.cs (Enum::Define): Modify to call the Lookup method on the
27829 parent instead of a direct call to GetType.
27831 2001-09-14 Ravi Pratap <ravi@ximian.com>
27833 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
27834 Modifiers.TypeAttr. This should just be a call to that method.
27836 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
27837 object so that we can determine if we are top-level or not.
27839 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
27842 * enum.cs (Enum::Define): Ditto.
27844 * modifiers.cs (FieldAttr): Re-write.
27846 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
27847 (TypeContainer::HaveStaticConstructor): New property to provide access
27848 to precisely that info.
27850 * modifiers.cs (MethodAttr): Re-write.
27851 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
27853 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
27854 of top-level types as claimed.
27856 2001-09-13 Miguel de Icaza <miguel@ximian.com>
27858 * expression.cs (MemberLookup): Fruitless attempt to lookup
27859 constructors. Maybe I need to emit default constructors? That
27860 might be it (currently .NET emits this for me automatically).
27861 (Invocation::OverloadResolve): Cope with Arguments == null.
27862 (Invocation::EmitArguments): new function, shared by the new
27863 constructor and us.
27864 (Invocation::Emit): Handle static and instance methods. Emit
27865 proper call instruction for virtual or non-virtual invocations.
27866 (New::Emit): Implement.
27867 (New::Resolve): Implement.
27868 (MemberAccess:Resolve): Implement.
27869 (MethodGroupExpr::InstanceExpression): used conforming to the spec
27870 to track instances.
27871 (FieldExpr::Resolve): Set type.
27873 * support.cs: Handle empty arguments.
27875 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
27876 SimpleLookup): Auxiliary routines to help parse a qualifier
27879 Update qualifier_identifier rule.
27881 * codegen.cs: Removed debugging messages.
27883 * class.cs: Make this a global thing, this acts just as a "key" to
27884 objects that we might have around.
27886 (Populate): Only initialize method_builders_to_methods once.
27888 * expression.cs (PropertyExpr): Initialize type from the
27891 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
27892 Resolve pattern. Attempt to implicitly convert value to boolean.
27895 * expression.cs: Set the type for the int32/int32 argument case.
27896 (Binary::ResolveOperator): Set the return type to boolean for
27897 comparission operators
27899 * typemanager.cs: Remove debugging print code.
27901 (Invocation::Resolve): resolve type.
27903 * class.cs: Allocate a MemberInfo of the correct size, as the code
27904 elsewhere depends on the test to reflect the correct contents.
27906 (Method::) Keep track of parameters, due to System.Reflection holes
27908 (TypeContainer::Populate): Keep track of MethodBuilders to Method
27911 (TypeContainer::FindMembers): Use ArrayList and then copy an array
27912 of the exact size and return that.
27914 (Class::LookupMethodByBuilder): New function that maps
27915 MethodBuilders to its methods. Required to locate the information
27916 on methods because System.Reflection bit us again.
27918 * support.cs: New file, contains an interface ParameterData and
27919 two implementations: ReflectionParameters and InternalParameters
27920 used to access Parameter information. We will need to grow this
27923 * expression.cs (Invocation::GetParameterData): implement a cache
27924 and a wrapper around the ParameterData creation for methods.
27925 (Invocation::OverloadResolve): Use new code.
27927 2001-09-13 Ravi Pratap <ravi@ximian.com>
27929 * class.cs (TypeContainer::EmitField): Remove and move into
27930 (Field::Define): here and modify accordingly.
27931 (Field.FieldBuilder): New member.
27932 (TypeContainer::Populate): Update accordingly.
27933 (TypeContainer::FindMembers): Implement.
27935 2001-09-13 Miguel de Icaza <miguel@ximian.com>
27937 * statement.cs: (VariableInfo::VariableType): New field to be
27938 initialized with the full type once it is resolved.
27940 2001-09-12 Miguel de Icaza <miguel@ximian.com>
27942 * parameter.cs (GetParameterInfo): Use a type cache to compute
27943 things only once, and to reuse this information
27945 * expression.cs (LocalVariableReference::Emit): Implement.
27946 (OpcodeCast::Emit): fix.
27948 (ParameterReference::Resolve): Implement.
27949 (ParameterReference::Emit): Implement.
27951 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
27952 that are expressions need to stay as Expressions.
27954 * typemanager.cs (CSharpName): Returns the C# name of a type if
27957 * expression.cs (Expression::ConvertImplicit): New function that
27958 implements implicit type conversions.
27960 (Expression::ImplicitReferenceConversion): Implements implicit
27961 reference conversions.
27963 (EmptyCast): New type for transparent casts.
27965 (OpcodeCast): New type for casts of types that are performed with
27966 a sequence of bytecodes.
27968 (BoxedCast): New type used for casting value types into reference
27969 types. Emits a box opcode.
27971 (Binary::DoNumericPromotions): Implements numeric promotions of
27972 and computation of the Binary::Type.
27974 (Binary::EmitBranchable): Optimization.
27976 (Binary::Emit): Implement code emission for expressions.
27978 * typemanager.cs (TypeManager): Added two new core types: sbyte
27981 2001-09-12 Ravi Pratap <ravi@ximian.com>
27983 * class.cs (TypeContainer::FindMembers): Method which does exactly
27984 what Type.FindMembers does, only we don't have to use reflection. No
27985 implementation yet.
27987 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
27988 typecontainer objects as we need to get at them.
27989 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
27991 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
27992 typecontainer object.
27994 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
27995 of just a Report object.
27997 2001-09-11 Ravi Pratap <ravi@ximian.com>
27999 * class.cs (Event::Define): Go back to using the prefixes "add_" and
28001 (TypeContainer::Populate): Now define the delegates of the type too.
28002 (TypeContainer.Delegates): Property to access the list of delegates defined
28005 * delegates.cs (Delegate::Define): Implement partially.
28007 * modifiers.cs (TypeAttr): Handle more flags.
28009 2001-09-11 Ravi Pratap <ravi@ximian.com>
28011 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
28013 (Operator::Define): Re-write logic to get types by using the LookupType method
28014 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
28015 (Indexer::Define): Ditto.
28016 (Event::Define): Ditto.
28017 (Property::Define): Ditto.
28019 2001-09-10 Ravi Pratap <ravi@ximian.com>
28021 * class.cs (TypeContainer::Populate): Now define operators too.
28022 (TypeContainer.Operators): New property to access the list of operators
28024 (Operator.OperatorMethodBuilder): New member to hold the method builder
28025 for the operator we are defining.
28026 (Operator::Define): Implement.
28028 2001-09-10 Ravi Pratap <ravi@ximian.com>
28030 * class.cs (Event::Define): Make the prefixes of the accessor methods
28031 addOn_ and removeOn_
28033 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
28034 of the location being passed in too. Ideally, this should go later since all
28035 error reporting should be done through the Report object.
28037 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
28038 (Populate): Iterate thru the indexers we have and define them too.
28039 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
28040 for the get and set accessors.
28041 (Indexer::Define): Implement.
28043 2001-09-09 Miguel de Icaza <miguel@ximian.com>
28045 * expression.cs (Binary::Resolve): Beginning of it. I scratched
28046 my previous implementation, did not work.
28048 * typemanager.cs: Add a couple of missing types (the longs).
28050 * literal.cs: Use TypeManager.bool_type instead of getting it.
28052 * expression.cs (EventExpr): New kind of expressions.
28053 (Expressio::ExprClassFromMemberInfo): finish
28055 2001-09-08 Miguel de Icaza <miguel@ximian.com>
28057 * assign.cs: Emit stores to static fields differently.
28059 2001-09-08 Ravi Pratap <ravi@ximian.com>
28061 * Merge in changes and adjust code to tackle conflicts. Backed out my
28062 code in Assign::Resolve ;-)
28064 2001-09-08 Ravi Pratap <ravi@ximian.com>
28066 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
28067 instead Report.Error and also pass in the location.
28068 (CSharpParser::Lexer): New readonly property to return the reference
28069 to the Tokenizer object.
28070 (declare_local_variables): Use Report.Error with location instead of plain
28074 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
28075 (Operator.CheckBinaryOperator): Ditto.
28077 * cs-parser.jay (operator_declarator): Update accordingly.
28079 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
28080 (CheckBinaryOperator): Same here.
28082 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
28083 on the name without any prefixes of namespace names etc. This is because we
28084 already might have something already fully qualified like
28085 'System.Console.WriteLine'
28087 * assign.cs (Resolve): Begin implementation. Stuck ;-)
28089 2001-09-07 Ravi Pratap <ravi@ximian.com>
28091 * cs-tokenizer.cs (location): Return a string which also contains
28094 * expression.cs (ElementAccess): New class for expressions of the
28095 type 'element access.'
28096 (BaseAccess): New class for expressions of the type 'base access.'
28097 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
28100 * cs-parser.jay (element_access): Implement action.
28101 (base_access): Implement actions.
28102 (checked_expression, unchecked_expression): Implement.
28104 * cs-parser.jay (local_variable_type): Correct and implement.
28105 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
28107 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
28109 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
28110 name and the specifiers.
28112 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
28114 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
28115 making them all public ;-)
28117 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
28120 2001-09-07 Miguel de Icaza <miguel@ximian.com>
28122 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
28124 (FieldExpr, PropertyExprs): New resolved expressions.
28125 (SimpleName::MemberStaticCheck): Perform static checks for access
28126 to non-static fields on static methods. Maybe this should be
28127 generalized for MemberAccesses.
28128 (SimpleName::ResolveSimpleName): More work on simple name
28131 * cs-parser.jay (primary_expression/qualified_identifier): track
28132 the parameter index.
28134 * codegen.cs (CodeGen::Save): Catch save exception, report error.
28135 (EmitContext::EmitBoolExpression): Chain to expression generation
28136 instead of temporary hack.
28137 (::EmitStatementExpression): Put generic expression code generation.
28139 * assign.cs (Assign::Emit): Implement variable assignments to
28140 local variables, parameters and fields.
28142 2001-09-06 Miguel de Icaza <miguel@ximian.com>
28144 * statement.cs (Block::GetVariableInfo): New method, returns the
28145 VariableInfo for a variable name in a block.
28146 (Block::GetVariableType): Implement in terms of GetVariableInfo
28148 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
28149 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
28151 2001-09-06 Ravi Pratap <ravi@ximian.com>
28153 * cs-parser.jay (operator_declaration): Continue on my quest : update
28154 to take attributes argument.
28155 (event_declaration): Ditto.
28156 (enum_declaration): Ditto.
28157 (indexer_declaration): Ditto.
28159 * class.cs (Operator::Operator): Update constructor accordingly.
28160 (Event::Event): Ditto.
28162 * delegate.cs (Delegate::Delegate): Same here.
28164 * enum.cs (Enum::Enum): Same here.
28166 2001-09-05 Ravi Pratap <ravi@ximian.com>
28168 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
28170 * ../tests/cs0658.cs : New file to demonstrate error 0658.
28172 * attribute.cs (Attributes): New class to encapsulate all attributes which were
28173 being passed around as an arraylist.
28174 (Attributes::AddAttribute): Method to add attribute sections.
28176 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
28177 (struct_declaration): Update accordingly.
28178 (constant_declaration): Update.
28179 (field_declaration): Update.
28180 (method_header): Update.
28181 (fixed_parameter): Update.
28182 (parameter_array): Ditto.
28183 (property_declaration): Ditto.
28184 (destructor_declaration): Ditto.
28186 * class.cs (Struct::Struct): Update constructors accordingly.
28187 (Class::Class): Ditto.
28188 (Field::Field): Ditto.
28189 (Method::Method): Ditto.
28190 (Property::Property): Ditto.
28191 (TypeContainer::OptAttribute): update property's return type.
28193 * interface.cs (Interface.opt_attributes): New member.
28194 (Interface::Interface): Update to take the extra Attributes argument.
28196 * parameter.cs (Parameter::Parameter): Ditto.
28198 * constant.cs (Constant::Constant): Ditto.
28200 * interface.cs (InterfaceMemberBase): New OptAttributes field.
28201 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
28202 the attributes as a parameter.
28203 (InterfaceProperty): Update constructor call.
28204 (InterfaceEvent): Ditto.
28205 (InterfaceMethod): Ditto.
28206 (InterfaceIndexer): Ditto.
28208 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
28209 pass the attributes too.
28210 (interface_event_declaration): Ditto.
28211 (interface_property_declaration): Ditto.
28212 (interface_method_declaration): Ditto.
28213 (interface_declaration): Ditto.
28215 2001-09-05 Miguel de Icaza <miguel@ximian.com>
28217 * class.cs (Method::Define): Track the "static Main" definition to
28218 create an entry point.
28220 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
28221 EntryPoint if we find it.
28223 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
28224 (EmitContext::ig): Make this variable public.
28226 * driver.cs: Make the default output file be the first file name
28227 with the .exe extension.
28229 Detect empty compilations
28231 Handle various kinds of output targets. Handle --target and
28232 rename -t to --dumper.
28234 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
28235 methods inherited from Expression return now an Expression. This
28236 will is used during the tree rewriting as we resolve them during
28239 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
28240 the spec. Missing entirely is the information about
28241 accessability of elements of it.
28243 (Expression::ExprClassFromMemberInfo): New constructor for
28244 Expressions that creates a fully initialized Expression based on
28245 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
28248 (Invocation::Resolve): Begin implementing resolution of invocations.
28250 * literal.cs (StringLiteral): Implement Emit.
28252 2001-09-05 Ravi Pratap <ravi@ximian.com>
28254 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
28257 2001-09-04 Ravi Pratap <ravi@ximian.com>
28259 * cs-parser.jay (attribute_arguments): Implement actions.
28260 (attribute): Fix bug in production. Implement action.
28261 (attribute_list): Implement.
28262 (attribute_target): Implement.
28263 (attribute_target_specifier, opt_target_specifier): Implement
28264 (CheckAttributeTarget): New method to check if the attribute target
28266 (attribute_section): Implement.
28267 (opt_attributes): Implement.
28269 * attribute.cs : New file to handle attributes.
28270 (Attribute): Class to hold attribute info.
28272 * cs-parser.jay (opt_attribute_target_specifier): Remove production
28273 (attribute_section): Modify production to use 2 different rules to
28274 achieve the same thing. 1 s/r conflict down !
28275 Clean out commented, useless, non-reducing dimension_separator rules.
28277 * class.cs (TypeContainer.attributes): New member to hold list
28278 of attributes for a type.
28279 (Struct::Struct): Modify to take one more argument, the attribute list.
28280 (Class::Class): Ditto.
28281 (Field::Field): Ditto.
28282 (Method::Method): Ditto.
28283 (Property::Property): Ditto.
28285 * cs-parser.jay (struct_declaration): Update constructor call to
28286 pass in the attributes too.
28287 (class_declaration): Ditto.
28288 (constant_declaration): Ditto.
28289 (field_declaration): Ditto.
28290 (method_header): Ditto.
28291 (fixed_parameter): Ditto.
28292 (parameter_array): Ditto.
28293 (property_declaration): Ditto.
28295 * constant.cs (Constant::Constant): Update constructor similarly.
28296 Use System.Collections.
28298 * parameter.cs (Parameter::Parameter): Update as above.
28300 2001-09-02 Ravi Pratap <ravi@ximian.com>
28302 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
28303 (TypeContainer.delegates): New member to hold list of delegates.
28305 * cs-parser.jay (delegate_declaration): Implement the action correctly
28306 this time as I seem to be on crack ;-)
28308 2001-09-02 Miguel de Icaza <miguel@ximian.com>
28310 * rootcontext.cs (RootContext::IsNamespace): new function, used to
28311 tell whether an identifier represents a namespace.
28313 * expression.cs (NamespaceExpr): A namespace expression, used only
28314 temporarly during expression resolution.
28315 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
28316 utility functions to resolve names on expressions.
28318 2001-09-01 Miguel de Icaza <miguel@ximian.com>
28320 * codegen.cs: Add hook for StatementExpressions.
28322 * class.cs: Fix inverted test for static flag in methods.
28324 2001-09-02 Ravi Pratap <ravi@ximian.com>
28326 * class.cs (Operator::CheckUnaryOperator): Correct error number used
28327 to make it coincide with MS' number.
28328 (Operator::CheckBinaryOperator): Ditto.
28330 * ../errors/errors.txt : Remove error numbers added earlier.
28332 * ../errors/cs1019.cs : Test case for error # 1019
28334 * ../errros/cs1020.cs : Test case for error # 1020
28336 * cs-parser.jay : Clean out commented cruft.
28337 (dimension_separators, dimension_separator): Comment out. Ostensibly not
28338 used anywhere - non-reducing rule.
28339 (namespace_declarations): Non-reducing rule - comment out.
28341 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
28342 with TypeContainer::AddEnum.
28344 * delegate.cs : New file for delegate handling classes.
28345 (Delegate): Class for declaring delegates.
28347 * makefile : Update.
28349 * cs-parser.jay (delegate_declaration): Implement.
28351 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
28353 * class.cs (Event::Define): Implement.
28354 (Event.EventBuilder): New member.
28356 * class.cs (TypeContainer::Populate): Update to define all enums and events
28358 (Events): New property for the events arraylist we hold. Shouldn't we move to using
28359 readonly fields for all these cases ?
28361 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28363 * class.cs (Property): Revamp to use the convention of making fields readonly.
28364 Accordingly modify code elsewhere.
28366 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
28367 the Define method of the Property class.
28369 * class.cs : Clean up applied patch and update references to variables etc. Fix
28371 (TypeContainer::Populate): Update to define all the properties we have. Also
28372 define all enumerations.
28374 * enum.cs (Define): Implement.
28376 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28378 * cs-parser.jay (overloadable_operator): The semantic value is an
28379 enum of the Operator class.
28380 (operator_declarator): Implement actions.
28381 (operator_declaration): Implement.
28383 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
28384 validity of definitions.
28385 (Operator::CheckBinaryOperator): Static method to check for binary operators
28386 (TypeContainer::AddOperator): New method to add an operator to a type.
28388 * cs-parser.jay (indexer_declaration): Added line to actually call the
28389 AddIndexer method so it gets added ;-)
28391 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
28392 already taken care of by the MS compiler ?
28394 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28396 * class.cs (Operator): New class for operator declarations.
28397 (Operator::OpType): Enum for the various operators.
28399 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28401 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
28402 ostensibly handle this in semantic analysis.
28404 * cs-parser.jay (general_catch_clause): Comment out
28405 (specific_catch_clauses, specific_catch_clause): Ditto.
28406 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
28407 (catch_args, opt_catch_args): New productions.
28408 (catch_clause): Rewrite to use the new productions above
28409 (catch_clauses): Modify accordingly.
28410 (opt_catch_clauses): New production to use in try_statement
28411 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
28412 and re-write the code in the actions to extract the specific and
28413 general catch clauses by being a little smart ;-)
28415 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
28416 Hooray, try and catch statements parse fine !
28418 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28420 * statement.cs (Block::GetVariableType): Fix logic to extract the type
28421 string from the hashtable of variables.
28423 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
28424 I end up making that mistake ;-)
28425 (catch_clauses): Fixed gross error which made Key and Value of the
28426 DictionaryEntry the same : $1 !!
28428 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28430 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
28432 * cs-parser.jay (event_declaration): Correct to remove the semicolon
28433 when the add and remove accessors are specified.
28435 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28437 * cs-parser.jay (IndexerDeclaration): New helper class to hold
28438 information about indexer_declarator.
28439 (indexer_declarator): Implement actions.
28440 (parsing_indexer): New local boolean used to keep track of whether
28441 we are parsing indexers or properties. This is necessary because
28442 implicit_parameters come into picture even for the get accessor in the
28443 case of an indexer.
28444 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
28446 * class.cs (Indexer): New class for indexer declarations.
28447 (TypeContainer::AddIndexer): New method to add an indexer to a type.
28448 (TypeContainer::indexers): New member to hold list of indexers for the
28451 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28453 * cs-parser.jay (add_accessor_declaration): Implement action.
28454 (remove_accessor_declaration): Implement action.
28455 (event_accessors_declaration): Implement
28456 (variable_declarators): swap statements for first rule - trivial.
28458 * class.cs (Event): New class to hold information about event
28460 (TypeContainer::AddEvent): New method to add an event to a type
28461 (TypeContainer::events): New member to hold list of events.
28463 * cs-parser.jay (event_declaration): Implement actions.
28465 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28467 * cs-parser.jay (dim_separators): Implement. Make it a string
28468 concatenating all the commas together, just as they appear.
28469 (opt_dim_separators): Modify accordingly
28470 (rank_specifiers): Update accordingly. Basically do the same
28471 thing - instead, collect the brackets here.
28472 (opt_rank_sepcifiers): Modify accordingly.
28473 (array_type): Modify to actually return the complete type string
28474 instead of ignoring the rank_specifiers.
28475 (expression_list): Implement to collect the expressions
28476 (variable_initializer): Implement. We make it a list of expressions
28477 essentially so that we can handle the array_initializer case neatly too.
28478 (variable_initializer_list): Implement.
28479 (array_initializer): Make it a list of variable_initializers
28480 (opt_array_initializer): Modify accordingly.
28482 * expression.cs (New::NType): Add enumeration to help us
28483 keep track of whether we have an object/delegate creation
28484 or an array creation.
28485 (New:NewType, New::Rank, New::Indices, New::Initializers): New
28486 members to hold data about array creation.
28487 (New:New): Modify to update NewType
28488 (New:New): New Overloaded contructor for the array creation
28491 * cs-parser.jay (array_creation_expression): Implement to call
28492 the overloaded New constructor.
28494 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
28496 * class.cs (TypeContainer::Constructors): Return member
28497 constructors instead of returning null.
28499 2001-08-26 Miguel de Icaza <miguel@ximian.com>
28501 * typemanager.cs (InitCoreTypes): Initialize the various core
28502 types after we have populated the type manager with the user
28503 defined types (this distinction will be important later while
28504 compiling corlib.dll)
28506 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
28507 on Expression Classification. Now all expressions have a method
28508 `Resolve' and a method `Emit'.
28510 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
28511 generation from working. Also add some temporary debugging
28514 2001-08-24 Miguel de Icaza <miguel@ximian.com>
28516 * codegen.cs: Lots of code generation pieces. This is only the
28517 beginning, will continue tomorrow with more touches of polish. We
28518 handle the fundamentals of if, while, do, for, return. Others are
28519 trickier and I need to start working on invocations soon.
28521 * gen-treedump.cs: Bug fix, use s.Increment here instead of
28524 * codegen.cs (EmitContext): New struct, used during code
28525 emission to keep a context. Most of the code generation will be
28528 * cs-parser.jay: Add embedded blocks to the list of statements of
28529 this block. So code generation proceeds in a top down fashion.
28531 2001-08-23 Miguel de Icaza <miguel@ximian.com>
28533 * statement.cs: Add support for multiple child blocks.
28535 2001-08-22 Miguel de Icaza <miguel@ximian.com>
28537 * codegen.cs (EmitCode): New function, will emit the code for a
28538 Block of code given a TypeContainer and its ILGenerator.
28540 * statement.cs (Block): Standard public readonly optimization.
28541 (Block::Block constructors): Link children.
28542 (Block::Child): Child Linker.
28543 (Block::EmitVariables): Emits IL variable declarations.
28545 * class.cs: Drop support for MethodGroups here, delay until
28547 (Method::): Applied the same simplification that I did before, and
28548 move from Properties to public readonly fields.
28549 (Method::ParameterTypes): Returns the parameter types for the
28550 function, and implements a cache that will be useful later when I
28551 do error checking and the semantic analysis on the methods is
28553 (Constructor::GetCallingConvention): Renamed from CallingConvetion
28554 and made a method, optional argument tells whether this is a class
28555 or a structure to apply the `has-this' bit.
28556 (Method::GetCallingConvention): Implement, returns the calling
28558 (Method::Define): Defines the type, a second pass is performed
28559 later to populate the methods.
28561 (Constructor::ParameterTypes): implement a cache similar to the
28562 one on Method::ParameterTypes, useful later when we do semantic
28565 (TypeContainer::EmitMethod): New method. Emits methods.
28567 * expression.cs: Removed MethodGroup class from here.
28569 * parameter.cs (Parameters::GetCallingConvention): new method.
28571 2001-08-21 Miguel de Icaza <miguel@ximian.com>
28573 * class.cs (TypeContainer::Populate): Drop RootContext from the
28576 (Constructor::CallingConvention): Returns the calling convention.
28577 (Constructor::ParameterTypes): Returns the constructor parameter
28580 (TypeContainer::AddConstructor): Keep track of default constructor
28581 and the default static constructor.
28583 (Constructor::) Another class that starts using `public readonly'
28584 instead of properties.
28586 (Constructor::IsDefault): Whether this is a default constructor.
28588 (Field::) use readonly public fields instead of properties also.
28590 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
28591 track of static constructors; If none is used, turn on
28592 BeforeFieldInit in the TypeAttributes.
28594 * cs-parser.jay (opt_argument_list): now the return can be null
28595 for the cases where there are no arguments.
28597 (constructor_declarator): If there is no implicit `base' or
28598 `this', then invoke the default parent constructor.
28600 * modifiers.cs (MethodAttr): New static function maps a set of
28601 modifiers flags into a MethodAttributes enum
28602 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
28603 MethodAttr, TypeAttr to represent the various mappings where the
28604 modifiers are used.
28605 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
28607 2001-08-19 Miguel de Icaza <miguel@ximian.com>
28609 * parameter.cs (GetParameterInfo): Fix bug where there would be no
28612 * interface.cs (PopulateIndexer): Implemented the code generator
28613 for interface indexers.
28615 2001-08-17 Miguel de Icaza <miguel@ximian.com>
28617 * interface.cs (InterfaceMemberBase): Now we track the new status
28620 (PopulateProperty): Implement property population. Woohoo! Got
28621 Methods and Properties going today.
28623 Removed all the properties for interfaces, and replaced them with
28624 `public readonly' fields.
28626 2001-08-16 Miguel de Icaza <miguel@ximian.com>
28628 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
28629 initialize their hashtables/arraylists only when they are needed
28630 instead of doing this always.
28632 * parameter.cs: Handle refs and out parameters.
28634 * cs-parser.jay: Use an ArrayList to construct the arguments
28635 instead of the ParameterCollection, and then cast that to a
28638 * parameter.cs: Drop the use of ParameterCollection and use
28639 instead arrays of Parameters.
28641 (GetParameterInfo): Use the Type, not the Name when resolving
28644 2001-08-13 Miguel de Icaza <miguel@ximian.com>
28646 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
28647 and instead use public readonly fields.
28649 * class.cs: Put back walking code for type containers.
28651 2001-08-11 Miguel de Icaza <miguel@ximian.com>
28653 * class.cs (MakeConstant): Code to define constants.
28655 * rootcontext.cs (LookupType): New function. Used to locate types
28658 2001-08-08 Miguel de Icaza <miguel@ximian.com>
28660 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
28661 this System.Reflection code is. Kudos to Microsoft
28663 * typemanager.cs: Implement a type cache and avoid loading all
28664 types at boot time. Wrap in LookupType the internals. This made
28665 the compiler so much faster. Wow. I rule!
28667 * driver.cs: Make sure we always load mscorlib first (for
28668 debugging purposes, nothing really important).
28670 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
28671 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
28673 * rootcontext.cs: Lookup types on their namespace; Lookup types
28674 on namespaces that have been imported using the `using' keyword.
28676 * class.cs (TypeContainer::TypeAttr): Virtualize.
28677 (Class::TypeAttr): Return attributes suitable for this bad boy.
28678 (Struct::TypeAttr): ditto.
28679 Handle nested classes.
28680 (TypeContainer::) Remove all the type visiting code, it is now
28681 replaced with the rootcontext.cs code
28683 * rootcontext.cs (GetClassBases): Added support for structs.
28685 2001-08-06 Miguel de Icaza <miguel@ximian.com>
28687 * interface.cs, statement.cs, class.cs, parameter.cs,
28688 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
28689 Drop use of TypeRefs, and use strings instead.
28691 2001-08-04 Miguel de Icaza <miguel@ximian.com>
28695 * class.cs (Struct::Struct): set the SEALED flags after
28696 checking the modifiers.
28697 (TypeContainer::TypeAttr): new property, returns the
28698 TypeAttributes for a class.
28700 * cs-parser.jay (type_list): Oops, list production was creating a
28701 new list of base types.
28703 * rootcontext.cs (StdLib): New property.
28704 (GetInterfaceTypeByName): returns an interface by type name, and
28705 encapsulates error handling here.
28706 (GetInterfaces): simplified.
28707 (ResolveTree): Encapsulated all the tree resolution here.
28708 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
28711 * driver.cs: Add support for --nostdlib, to avoid loading the
28712 default assemblies.
28713 (Main): Do not put tree resolution here.
28715 * rootcontext.cs: Beginning of the class resolution.
28717 2001-08-03 Miguel de Icaza <miguel@ximian.com>
28719 * rootcontext.cs: Provide better error reporting.
28721 * cs-parser.jay (interface_base): set our $$ to be interfaces.
28723 * rootcontext.cs (CreateInterface): Handle the case where there
28724 are no parent interfaces.
28726 (CloseTypes): Routine to flush types at the end.
28727 (CreateInterface): Track types.
28728 (GetInterfaces): Returns an array of Types from the list of
28729 defined interfaces.
28731 * typemanager.c (AddUserType): Mechanism to track user types (puts
28732 the type on the global type hash, and allows us to close it at the
28735 2001-08-02 Miguel de Icaza <miguel@ximian.com>
28737 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
28738 RecordInterface instead.
28740 * cs-parser.jay: Updated to reflect changes above.
28742 * decl.cs (Definition): Keep track of the TypeBuilder type that
28743 represents this type here. Not sure we will use it in the long
28744 run, but wont hurt for now.
28746 * driver.cs: Smaller changes to accomodate the new code.
28748 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
28751 * rootcontext.cs (CreateInterface): New method, used to create
28752 the System.TypeBuilder type for interfaces.
28753 (ResolveInterfaces): new entry point to resolve the interface
28755 (CodeGen): Property, used to keep track of the code generator.
28757 2001-07-26 Miguel de Icaza <miguel@ximian.com>
28759 * cs-parser.jay: Add a second production for delegate_declaration
28762 (enum_body): Put an opt_comma here instead of putting it on
28763 enum_body or enum_member_declarations so we can handle trailing
28764 commas on enumeration members. Gets rid of a shift/reduce.
28766 (type_list): Need a COMMA in the middle.
28768 (indexer_declaration): Tell tokenizer to recognize get/set
28770 * Remove old targets.
28772 * Re-add the parser target.
28774 2001-07-13 Simon Cozens <simon@simon-cozens.org>
28776 * cs-parser.jay: Add precendence rules for a number of operators
28777 ot reduce the number of shift/reduce conflicts in the grammar.
28779 2001-07-17 Miguel de Icaza <miguel@ximian.com>
28781 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
28784 Get rid of old crufty code.
28786 * rootcontext.cs: Use this to keep track of the parsed
28787 representation and the defined types available to the program.
28789 * gen-treedump.cs: adjust for new convention.
28791 * type.cs: Split out the type manager, and the assembly builder
28794 * typemanager.cs: the type manager will live here now.
28796 * cil-codegen.cs: And the code generator here.
28798 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
28800 * makefile: Fixed up for easy making.
28802 2001-07-13 Simon Cozens <simon@simon-cozens.org>
28804 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
28807 (unary_expression): Expand pre_increment_expression and
28808 post_decrement_expression to reduce a shift/reduce.
28810 2001-07-11 Simon Cozens
28812 * cs-tokenizer.cs: Hex numbers should begin with a 0.
28814 Improve allow_keyword_as_indent name.
28816 2001-06-19 Miguel de Icaza <miguel@ximian.com>
28818 * Adjustments for Beta2.
28820 2001-06-13 Miguel de Icaza <miguel@ximian.com>
28822 * decl.cs: Added `Define' abstract method.
28823 (InTransit): new property, used to catch recursive definitions.
28825 * interface.cs: Implement `Define'.
28827 * modifiers.cs: Map Modifiers.constants to
28828 System.Reflection.TypeAttribute flags.
28830 * class.cs: Keep track of types and user-defined types.
28831 (BuilderInit): New method for creating an assembly
28832 (ResolveType): New function to launch the resolution process, only
28833 used by interfaces for now.
28835 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
28836 that are inserted into the name space.
28838 2001-06-08 Miguel de Icaza <miguel@ximian.com>
28840 * ARGH. I have screwed up my tree so many times due to the use of
28841 rsync rather than using CVS. Going to fix this at once.
28843 * driver.cs: Objetify driver. Load assemblies, use assemblies to
28846 2001-06-07 Miguel de Icaza <miguel@ximian.com>
28848 * Experiment successful: Use System.Type rather that our own
28851 2001-05-25 Miguel de Icaza <miguel@ximian.com>
28853 * cs-parser.jay: Removed nsAliases from here.
28855 Use new namespaces, handle `using XXX;'
28857 * namespace.cs: Reimplemented namespace handling, use a recursive
28858 definition of the class. Now we can keep track of using clauses
28859 and catch invalid using clauses.
28861 2001-05-24 Miguel de Icaza <miguel@ximian.com>
28863 * gen-treedump.cs: Adapted for all the renaming.
28865 * expression.cs (Expression): this class now has a Type property
28866 which returns an expression Type.
28868 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
28869 `Type', as this has a different meaning now in the base
28871 2001-05-22 Miguel de Icaza <miguel@ximian.com>
28873 * interface.cs, class.cs: Removed from all the sources the
28874 references to signature computation, as we can not do method
28875 signature computation during the parsing time, as we are not
28876 trying to solve at that point distinguishing:
28880 void a (NS.Blah x) {}
28883 Which depending on the context might be valid or not, as we do not
28884 know if Blah is the same thing as NS.Blah at that point.
28886 * Redid everything so the code uses TypeRefs now instead of
28887 Types. TypeRefs are just temporary type placeholders, that need
28888 to be resolved. They initially have a pointer to a string and the
28889 current scope in which they are used. This is used later by the
28890 compiler to resolve the reference to an actual Type.
28892 * DeclSpace is no longer a CIR.Type, and neither are
28893 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
28894 are all DeclSpaces, but no Types.
28896 * type.cs (TypeRefManager): This implements the TypeRef manager,
28897 which keeps track of all the types that need to be resolved after
28898 the parsing has finished.
28900 2001-05-13 Miguel de Icaza <miguel@ximian.com>
28902 * ARGH. We are going to have to store `foreach' as a class rather
28903 than resolving it, as we need to verify error 1579 after name
28904 resolution. *OR* we could keep a flag that says `This request to
28905 IEnumerator comes from a foreach statement' which we can then use
28906 to generate the error.
28908 2001-05-10 Miguel de Icaza <miguel@ximian.com>
28910 * class.cs (TypeContainer.AddMethod): we now add methods to the
28911 MethodGroup instead of the method hashtable.
28913 * expression.cs: Add MethodGroup abstraction, which gets us one
28914 step closer to the specification in the way we handle method
28917 * cs-parser.jay (primary_expression): qualified_identifier now
28918 tried to match up an identifier to a local variable reference or
28919 to a parameter reference.
28921 current_local_parameters is now a parser global variable that
28922 points to the current parameters for the block, used during name
28925 (property_declaration): Now creates an implicit `value' argument to
28928 2001-05-09 Miguel de Icaza <miguel@ximian.com>
28930 * parameter.cs: Do not use `param' arguments as part of the
28931 signature, per the spec.
28933 2001-05-08 Miguel de Icaza <miguel@ximian.com>
28935 * decl.cs: Base class for classes, structs and interfaces. This
28936 is the "Declaration Space"
28938 * cs-parser.jay: Use CheckDef for checking declaration errors
28939 instead of having one on each function.
28941 * class.cs: Factor out some code for handling error handling in
28942 accordance to the "Declarations" section in the "Basic Concepts"
28943 chapter in the ECMA C# spec.
28945 * interface.cs: Make all interface member classes derive from
28946 InterfaceMemberBase.
28948 2001-05-07 Miguel de Icaza <miguel@ximian.com>
28950 * Many things: all interfaces are parsed and generated in
28951 gen-treedump. Support for member variables, constructors,
28952 destructors, properties, constants is there.
28954 Beginning of the IL backend, but very little done, just there for
28957 2001-04-29 Miguel de Icaza <miguel@ximian.com>
28959 * cs-parser.jay: Fix labeled statement.
28961 * cs-tokenizer.cs (escape): Escape " and ' always.
28962 ref_line, ref_name: keep track of the line/filename as instructed
28963 by #line by the compiler.
28966 2001-04-27 Miguel de Icaza <miguel@ximian.com>
28968 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
28969 to match the values in System.CodeDOM.
28971 Divid renamed to Divide.
28973 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
28975 (Statements.set): remove.
28977 * System.CodeDOM/CodeCatchClause.cs: always have a valid
28980 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
28981 falseStatements always have valid values.
28983 * cs-parser.jay: Use System.CodeDOM now.