1 2010-05-28 Marek Safar <marek.safar@gmail.com>
4 * import.cs: Check private modifier correctly.
6 2010-05-28 Marek Safar <marek.safar@gmail.com>
9 * ecore.cs: Don't ignore override methods when looking for base
12 2010-05-27 Marek Safar <marek.safar@gmail.com>
14 A fix for bugs #608007, #572540, #566130, #476358
16 * generic.cs, linq.cs, expression.cs, statement.cs, cs-parser.jay:
17 More tricky refactoring of implicit linq blocks.
19 2010-05-25 Marek Safar <marek.safar@gmail.com>
21 * linq.cs, cs-parser.jay: Keep location for all linq clauses.
23 2010-05-25 Marek Safar <marek.safar@gmail.com>
25 * context.cs, expression.cs, cs-parser.jay: Don't store current
26 block in This expression (it's too early for linq blocks).
28 2010-05-21 Marek Safar <marek.safar@gmail.com>
30 * expression.cs: Use constrained prefix more broadly to avoid boxing.
32 2010-05-20 Marek Safar <marek.safar@gmail.com>
35 * nullable.cs: Don't double wrap same expression.
37 2010-05-20 Marek Safar <marek.safar@gmail.com>
40 * anonymous.cs: Any issued error in probing mode means no match.
42 2010-05-20 Marek Safar <marek.safar@gmail.com>
44 * expression.cs: Search for base indexer using the closest match
47 2010-05-20 Marek Safar <marek.safar@gmail.com>
50 * method.cs: Set override constraints using unexpanded interface
53 2010-05-20 Marek Safar <marek.safar@gmail.com>
56 * ecore.cs: Include secondary extension method lookup in probing
59 2010-05-19 Marek Safar <marek.safar@gmail.com>
62 * typespec.cs (MayBecomeEqualGenericTypes): Recursively check
65 2010-05-19 Marek Safar <marek.safar@gmail.com>
68 * pending.cs: Advance counter correctly.
70 2010-05-19 Marek Safar <marek.safar@gmail.com>
73 * method.cs, pending.cs: Indexer override uses base name.
75 2010-05-19 Marek Safar <marek.safar@gmail.com>
78 * generic.cs: Replace original with inflated type parameter on
81 2010-05-19 Marek Safar <marek.safar@gmail.com>
84 * parameter.cs: Extension attribute can be defined in each assembly.
86 2010-05-18 Marek Safar <marek.safar@gmail.com>
89 * method.cs: Only one method can implement an interface.
91 2010-05-18 Marek Safar <marek.safar@gmail.com>
94 * convert.cs, constant.cs, expression.cs, literal.cs, ecore.cs:
95 Typed null can be used as a source for expression methods.
97 2010-05-18 Marek Safar <marek.safar@gmail.com>
100 * namespace.cs: Using directive imports only types and not nested
103 2010-05-17 Marek Safar <marek.safar@gmail.com>
105 * typespec.cs, expression.cs, statement.cs, ecore.cs, complete.cs,
106 delegate.cs: Member instance is resolved after member overload
107 definitely resolves static/instance property of member expression.
108 Fixes #545047, #358848, #456605, #460016, #603299
110 2010-05-12 Marek Safar <marek.safar@gmail.com>
112 A fix for bug #604981
113 * generic.cs, decl.cs, anonymous.cs: Reset more type arguments
114 details for nested anonymous methods stories.
116 2010-05-11 Marek Safar <marek.safar@gmail.com>
118 A fix for bug #604735
119 * namespace.cs: Don't report namespace collision.
121 2010-05-11 Marek Safar <marek.safar@gmail.com>
123 A fix for bug #604748
124 * class.cs, typespec.cs: Search full imported attribute hierarchy
127 2010-05-11 Marek Safar <marek.safar@gmail.com>
129 * namespace.cs: Ignore missing dependencies failure at
132 2010-05-11 Marek Safar <marek.safar@gmail.com>
134 A fix for bug #604640
135 * namespace.cs: Don't resolve using constraints too early.
137 2010-05-11 Marek Safar <marek.safar@gmail.com>
139 A fix for bug #604239
140 * generic.cs: Copy partial type constraints to partial container.
142 2010-05-10 Marek Safar <marek.safar@gmail.com>
144 A fix for bug #557210
145 * import.cs: Relax underlying enum field rules.
147 2010-05-10 Marek Safar <marek.safar@gmail.com>
149 A fix for bug #603476
150 * property.cs: Implement IParametersMember for indexer accessors.
152 2010-05-07 Marek Safar <marek.safar@gmail.com>
154 A fix for bug #601141
155 * class.cs: Update all partial modifiers.
157 2010-05-06 Marek Safar <marek.safar@gmail.com>
159 A fix for bug #601708
160 * method.cs, membercache.cs: Destructors cannot be hidden.
162 2010-05-06 Marek Safar <marek.safar@gmail.com>
164 A fix for bug #602551
165 * class.cs: Resursive reference of type definition is allowed.
167 2010-05-06 Marek Safar <marek.safar@gmail.com>
169 * anonymous.cs: Mutate cached storey instance types too.
171 2010-05-06 Marek Safar <marek.safar@gmail.com>
173 A fix for bug #602443
174 * convert.cs: Explicit enum conversion cannot involve user operators
176 2010-05-05 Miguel de Icaza <miguel@novell.com>
178 * class.cs (TypeContainer.DefineBaseTypes)
179 (TypeContainer.CheckRecursiveDefinition): check for the iface not
180 being null, as we could have failed resolution and crashed;
183 * cs-parser.jay: Productions to catch common mistakes when other
184 punctuation operators are used instead of comma. Fixes 571702
186 2010-05-05 Marek Safar <marek.safar@gmail.com>
188 * anonymous.cs: Mutate correct set of constraints.
190 2010-05-05 Marek Safar <marek.safar@gmail.com>
192 A fix for bug #602842
193 * expression.cs: Resolve all array bound arguments.
195 2010-05-05 Marek Safar <marek.safar@gmail.com>
197 * import.cs: Don't import private fields.
199 2010-04-30 Marek Safar <marek.safar@gmail.com>
201 Partially based on patch by <sami.lamti@gmail.com>
203 * eval.cs, ecore.cs: Fixed eval show methods.
205 2010-04-30 Marek Safar <marek.safar@gmail.com>
207 * generic.cs, delegate.cs: Implement output type inference of
208 methodgroup now when the specification was cleared at least little
211 2010-04-29 Marek Safar <marek.safar@gmail.com>
213 A fix for bug #575611
214 * class.cs: Fix recursive unmanaged recursice sruct check.
216 2010-04-29 Marek Safar <marek.safar@gmail.com>
218 A fix for bug #479776
219 * expression.cs: Implement typeof unbounded nested generic types.
221 2010-04-29 Marek Safar <marek.safar@gmail.com>
223 A fix for bug #474953
224 * class.cs: Fix valid recursive base type definition.
226 2010-04-29 Marek Safar <marek.safar@gmail.com>
228 A fix for bug #421737
229 * convert.cs, expression.cs: A boxing conversion exists from a
230 nullable-type to a reference type, if a boxing conversion exists
231 from the underlying non-nullable-value-type to the reference type.
233 2010-04-29 Marek Safar <marek.safar@gmail.com>
235 A fix for bug #376875
236 * import.cs: Import volatile modifier.
238 2010-04-29 Marek Safar <marek.safar@gmail.com>
240 A fix for bug #372412
241 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
244 2010-04-29 Marek Safar <marek.safar@gmail.com>
246 A fix for bug #568955
247 * statements.cs: Handle recursive scope initializers.
249 2010-04-28 Marek Safar <marek.safar@gmail.com>
251 A fix for bug #566511
252 * anonymous.cs: Always get inflated version of hoisted variable
253 on generic type definition.
255 2010-04-28 Marek Safar <marek.safar@gmail.com>
257 * import.cs, membercache.cs: Relax rules for valid properties.
259 2010-04-28 Marek Safar <marek.safar@gmail.com>
261 * import.cs: Intern arrays used in generic arguments.
263 2010-04-28 Marek Safar <marek.safar@gmail.com>
265 A fix for bug #600398
266 * convert.cs: Actually use effective base type for the comparison.
268 2010-04-28 Marek Safar <marek.safar@gmail.com>
270 A fix for bug #600326
271 * ecore.cs: Pass arity to base member lookup.
273 2010-04-28 Marek Safar <marek.safar@gmail.com>
275 A fix for bug #573385
276 * expression.cs: MemberAccess is of generic type based on right
279 2010-05-28 Marek Safar <marek.safar@gmail.com>
281 * cs-tokenizer.cs: Made tab size configurable.
283 2010-05-27 Marek Safar <marek.safar@gmail.com>
285 * attribute.cs: Ensure Obsolete members are defined before doing
288 2010-05-27 Marek Safar <marek.safar@gmail.com>
290 * visit.cs: Add DOM visitor skeleton.
294 2010-05-27 Marek Safar <marek.safar@gmail.com>
296 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
298 2010-05-27 Marek Safar <marek.safar@gmail.com>
300 * *.cs: Major rewrite of compiler internals to better work with
301 unmodified System.Reflection.Emit. Some of the key changes are
302 - TypeSpec replaces reflection specific System.Type.
303 - All Type(TypeSpec) operations are now done in compiler therefore
304 no dependency on SRE to inflate generic members and types or to
305 query unclosed types.
306 - MemberCache is now the only and full hierarchical topology.
307 - Generic constraints are implemented properly.
308 - And as a bonus compilation is on average 30% faster.
310 2010-04-15 Jb Evain <jbevain@novell.com>
312 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
314 2010-04-12 Marek Safar <marek.safar@gmail.com>
316 * expression.cs, attribute.cs, parameter.cs: More attribute type
319 2010-04-12 Marek Safar <marek.safar@gmail.com>
321 A fix for bug #593342
323 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
324 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
325 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
326 codegen.cs: Add custom attribute encoder to deal with unfinished
327 types and easier corlib bootstrap from its own types.
329 2010-03-26 Marek Safar <marek.safar@gmail.com>
331 * cs-parser.jay: Report invalid constraint types.
333 2010-03-16 Jb Evain <jbevain@novell.com>
335 * Makefile: rename the net_2_1 profile to moonlight.
337 2010-03-11 Marek Safar <marek.safar@gmail.com>
339 * statement.cs, cs-parser.jay: Use correct location for empty
342 2010-03-11 Marek Safar <marek.safar@gmail.com>
344 * cs-parser.jay: Disable Location from expression.
346 * generic.cs: Check constraints for overrides in the parser.
348 2010-03-09 Marek Safar <marek.safar@gmail.com>
350 * cs-parser.jay (GetLocation): Use an expression when available.
352 2010-03-04 Marek Safar <marek.safar@gmail.com>
354 A fix for bug #582579
355 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
357 2010-03-04 Marek Safar <marek.safar@gmail.com>
359 A patch by kornelpal@gmail.com
361 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
362 compiler generated classes sealed by default. Emit and close top
363 level compiler generated classes as well.
365 * support.cs: Use RuntimeHelpers.GetHashCode.
367 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
369 * Makefile: We need to use the internal bootstrapping gmcs for
370 net_2_1_bootstrap too now.
372 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
374 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
376 2010-03-02 Marek Safar <marek.safar@gmail.com>
378 * cs-tokenizer.cs: Missed few locations in previous fix.
380 2010-03-02 Marek Safar <marek.safar@gmail.com>
382 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
383 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
384 Report correct location for operator errors.
386 2010-03-02 Marek Safar <marek.safar@gmail.com>
388 * typemanager.cs (IsDynamicType): Don't check external types when
389 the attribute is not external.
391 2010-02-24 Marek Safar <marek.safar@gmail.com>
393 A fix for bug #582579
394 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
397 2010-02-24 Marek Safar <marek.safar@gmail.com>
399 A fix for bug #581804
400 * ecore.cs: Fixed type comparison.
402 2010-02-08 Miguel de Icaza <miguel@novell.com>
404 * namespace.cs (CompletionGetTypesStartingWith): Do not include
405 private types in the completion results.
407 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
410 2010-02-17 Marek Safar <marek.safar@gmail.com>
412 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
415 2010-02-14 Miguel de Icaza <miguel@novell.com>
417 * eval.cs: Do not do the report printer dance unless the user has
418 set the DescribeTypes feature.
420 2010-02-10 Marek Safar <marek.safar@gmail.com>
422 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
424 2010-02-08 Marek Safar <marek.safar@gmail.com>
426 A fix for bug #577029
427 * anonymous.cs: Fixed TypeBuilder* check.
429 2010-02-06 Miguel de Icaza <miguel@novell.com>
431 * eval.cs (CompileBlock): Also undo if there are problems during
432 semantic analysis, fixes various cases where invalid C# code would
433 be reported, but the internal changes would not be undone.
435 2010-02-03 Miguel de Icaza <miguel@novell.com>
437 * driver.cs: Change the --fatal flag to allow a number to be
438 passed, this ignores the first N fatal errors. Useful to debug
439 errors that do not happen on the first hit.
441 * cs-parser.jay (invocation_expression): accept both the
442 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
443 inside an invocation.
445 * driver.cs: Expose FatalErrors.
447 * eval.cs: Initialize the printer's Fatal property from the
448 Driver's FatalError flag, this allows csharp --fatal to work
451 Add support for calling Describe (typeof (TYPE)) if the expression
454 2010-02-02 Marek Safar <marek.safar@gmail.com>
456 A fix for bug #574991
457 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
460 2010-02-02 Marek Safar <marek.safar@gmail.com>
462 A fix for bug #575986
463 * expression.cs: Don't mutate typeof type definitions.
465 2010-01-28 Marek Safar <marek.safar@gmail.com>
467 * decl.cs: Use only one set of modifiers.
469 2010-01-26 Marek Safar <marek.safar@gmail.com>
471 A fix for bug #573329
472 * eval.cs: Don't disable error reporting completely on silent mode.
474 2010-01-25 Marek Safar <marek.safar@gmail.com>
476 A fix for bug #573312
477 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
478 pointer index of unknown size types greater than 2.
480 2010-01-15 Marek Safar <marek.safar@gmail.com>
482 * *.cs: Use only 1 member kind enum.
484 2010-01-15 Marek Safar <marek.safar@gmail.com>
486 * *.cs: Add event specification.
488 2010-01-14 Marek Safar <marek.safar@gmail.com>
490 * membercache.cs: Extracted from decl.cs.
492 * *.cs: Put more infrastructure in place.
494 2010-01-13 Marek Safar <marek.safar@gmail.com>
496 * *.cs: Add property specification, unused yet.
498 2010-01-13 Marek Safar <marek.safar@gmail.com>
500 * property.cs: Move all property based declarations into a new file.
502 2010-01-13 Marek Safar <marek.safar at gmail.com>
504 * expression.cs (Conditional): Resolve reduced expression.
506 2010-01-13 Marek Safar <marek.safar at gmail.com>
508 * *.cs: Introduced non-generic method specification.
510 2010-01-07 Marek Safar <marek.safar@gmail.com>
512 * method.cs: Move all method based declarations into a new file.
514 2010-01-07 Marek Safar <marek.safar@gmail.com>
516 * *.cs: Extract field specification.
518 2009-12-17 Marek Safar <marek.safar@gmail.com>
520 * field.cs: Extracted from class.cs
522 2009-12-15 Marek Safar <marek.safar@gmail.com>
524 * attribute.cs (GetFixedBuffer): Work on field definition only.
526 2009-12-15 Marek Safar <marek.safar@gmail.com>
528 * *.cs: Clean up NET_4_0 conditional where possible.
530 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
532 support.cs (DynamicType): Assembly property returns the assembly builder.
533 This is required due to how compiler context works in corlib.
535 2009-12-14 Marek Safar <marek.safar@gmail.com>
537 A fix for bug #564376
538 * assign.cs (LocalTemporary): Removed no longer needed special
541 2009-12-11 Marek Safar <marek.safar@gmail.com>
543 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
544 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
545 enum for easier debugging.
547 2009-12-10 Marek Safar <marek.safar@gmail.com>
549 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
552 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
555 2009-12-10 Marek Safar <marek.safar@gmail.com>
557 * cs-parser.jay, statement.cs: Handle parser error in code
560 2009-12-10 Marek Safar <marek.safar@gmail.com>
562 * ecore.cs: Ignore base imported methods when they are already
565 * eval.cs: Handle non-existent keys.
567 * report.cs, driver.cs: Make fatal work with console printer only.
569 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
571 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
573 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
575 * typemanager.cs: Add MakeGenericMethod that checks if the method
576 is really the generic method definition.
578 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
579 to inflate generic methods.
581 2009-12-08 Marek Safar <marek.safar@gmail.com>
583 A fix for bug #561149
584 * anonymous.cs: Use actual type parameters when checking for generic
587 2009-12-08 Marek Safar <marek.safar@gmail.com>
589 A fix for bug #561369
590 * expression.cs (DoNumericPromotion): Fixed typo.
592 2009-12-08 Marek Safar <marek.safar@gmail.com>
594 *.cs: Moving to generics world.
596 cs-parser.jay: Removed current_array_type.
598 2009-12-07 Marek Safar <marek.safar@gmail.com>
600 *.cs: Moving to generics world.
602 2009-12-04 Marek Safar <marek.safar@gmail.com>
604 *.cs: Moving to generics world (day 2).
606 2009-12-03 Marek Safar <marek.safar@gmail.com>
608 *.cs: Moving to generics world.
610 2009-12-02 Marek Safar <marek.safar@gmail.com>
612 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
613 Encode dynamic type attribute for elements where attributes cannot
616 2009-12-01 Marek Safar <marek.safar@gmail.com>
618 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
621 2009-12-01 Marek Safar <marek.safar@gmail.com>
623 A fix for bug #360455
624 * class.cs: Never report a unused warning for generic events to
625 workaround wrong expression type.
627 2009-11-30 Marek Safar <marek.safar@gmail.com>
629 A fix for bug #558305
630 * decl.cs, class.cs: Check partial method definitions using correct
633 2009-11-30 Marek Safar <marek.safar@gmail.com>
635 * argument.cs: Don't cache rarely used dynamic flag.
637 2009-11-27 Marek Safar <marek.safar@gmail.com>
639 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
641 2009-11-27 Marek Safar <marek.safar@gmail.com>
643 * ecore.cs (SimpleName): Removed no longer needed in_transit as
644 Resolve is now non-reentrant (saves ~0.6MB for corlib).
646 2009-11-26 Marek Safar <marek.safar@gmail.com>
648 A fix for bug #545081
649 * decl.cs: Check private nested types of nested types recursively.
651 2009-11-26 Marek Safar <marek.safar@gmail.com>
653 A fix for bug #558305
654 * location.cs: Ignore self referencing #line directive
656 2009-11-26 Marek Safar <marek.safar@gmail.com>
658 A fix for bug #558292
659 * class.cs: Allow single unsafe fixed buffer fields.
661 2009-11-26 Marek Safar <marek.safar@gmail.com>
663 * expression: Optimize few more zero-based operations.
665 2009-11-26 Marek Safar <marek.safar@gmail.com>
667 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
668 avoids boxing of literal values.
670 2009-11-26 Marek Safar <marek.safar@gmail.com>
672 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
673 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
674 codegen.cs: LocatedToken redesing to avoid excessive allocation and
675 boxing (saves ~7MB for corlib). Also fixes presise token location.
677 2009-11-25 Marek Safar <marek.safar@gmail.com>
679 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
682 2009-11-24 Marek Safar <marek.safar@gmail.com>
684 * expression.cs: Lower static array initializer barrier.
686 * support.cs, driver.cs: Share reader buffer.
688 2009-11-23 Marek Safar <marek.safar@gmail.com>
690 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
692 2009-11-23 Marek Safar <marek.safar@gmail.com>
694 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
695 cleanup some obsolete code.
697 2009-11-20 Marek Safar <marek.safar@gmail.com>
699 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
702 2009-11-20 Marek Safar <marek.safar@gmail.com>
704 * *.cs: Resolved expressions are never resolved again, this helps to
705 uncover some not easy to find bugs and improve the performance.
707 2009-11-19 Marek Safar <marek.safar@gmail.com>
709 * *.cs: Made constant expressions fully compatible with any other
712 2009-11-19 Marek Safar <marek.safar@gmail.com>
714 * *.cs: DoResolve is a worker method and has to be protected.
716 2009-11-18 Marek Safar <marek.safar@gmail.com>
718 * *.cs: More context specific handling.
720 2009-11-17 Marek Safar <marek.safar@gmail.com>
722 * *.cs: More context specific handling.
724 2009-11-16 Marek Safar <marek.safar@gmail.com>
726 * dynamic.cs, class.cs: Removed few fixed user types conversions.
728 * symbolwriter.cs: Uses public ILOffset.
730 2009-11-13 Marek Safar <marek.safar@gmail.com>
732 A fix for bug #553650
733 * generic.cs: Another missing TypeToCoreType, still too many to fix.
735 2009-11-13 Marek Safar <marek.safar@gmail.com>
737 A fix for bug #555170
739 * class.cs, delegate.cs, enum.cs: Constants have to be available
740 for parameters resolve.
742 2009-11-12 Marek Safar <marek.safar@gmail.com>
744 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
747 2009-11-12 Marek Safar <marek.safar@gmail.com>
749 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
750 with a statically known candidate set.
752 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
754 * generic.cs: Made type inflation for generic constraint checks
755 recursive. This fixes BGO #553655.
757 2009-11-11 Marek Safar <marek.safar@gmail.com>
759 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
762 2009-11-10 Marek Safar <marek.safar@gmail.com>
764 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
765 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
766 attribute.cs: Add some dynamic error checking.
768 2009-11-07 Marek Safar <marek.safar@gmail.com>
770 A fix for bug #553465
772 * expression.cs: Fixed mixed version of expression tree anonymous
775 2009-11-06 Marek Safar <marek.safar@gmail.com>
777 A fix for bug #553031
779 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
780 expression tree version of anonymous type with members declaration.
782 2009-11-05 Marek Safar <marek.safar@gmail.com>
784 * parameter.cs: Handle nullable parameter default expression.
786 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
787 class.cs, attribute.cs: Check for wrong dynamic arguments.
789 2009-11-05 Marek Safar <marek.safar@gmail.com>
791 * statement.cs: Dynamic statements.
793 2009-11-04 Marek Safar <marek.safar@gmail.com>
795 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
796 Compound assignments over dynamic type.
798 2009-11-03 Marek Safar <marek.safar@gmail.com>
800 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
801 constructor arguments.
803 2009-10-30 Marek Safar <marek.safar@gmail.com>
805 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
806 codegen.cs: Unary mutator on dynamic member access expression.
808 2009-10-29 Marek Safar <marek.safar@gmail.com>
810 A fix for bug #550580
811 * convert.cs: Don't eliminate explicit precission casts.
813 2009-10-28 Marek Safar <marek.safar@gmail.com>
815 A fix for bug #550404
817 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
818 expression.cs, statement.cs, ecore.cs: Quote any nested expression
821 2009-10-27 Marek Safar <marek.safar@gmail.com>
823 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
826 * class.cs: Allow nullable binary user operators.
828 2009-10-26 Marek Safar <marek.safar@gmail.com>
830 * expression.cs: Move binary expression optimization at the end of
833 2009-10-23 Marek Safar <marek.safar@gmail.com>
835 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
836 Separate NullConstant from NullLiteral.
838 2009-10-23 Marek Safar <marek.safar@gmail.com>
840 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
841 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
842 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
843 ModuleContainer. Add common unclosed member check routine.
845 2009-10-22 Marek Safar <marek.safar@gmail.com>
847 * argument.cs: Use literal flag for real literals only.
849 * dynamic.cs: Use correct return type for custom delegates.
851 2009-10-22 Marek Safar <marek.safar@gmail.com>
853 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
856 2009-10-22 Marek Safar <marek.safar@gmail.com>
858 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
860 2009-10-21 Marek Safar <marek.safar@gmail.com>
862 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
865 2009-10-21 Marek Safar <marek.safar@gmail.com>
867 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
870 2009-10-20 Marek Safar <marek.safar@gmail.com>
872 * argument.cs, dynamic.cs, expression.cs: Latest API update.
874 2009-10-19 Marek Safar <marek.safar@gmail.com>
876 * typemanager.cs, expression.cs: Dynamic array initializer.
878 2009-10-16 Marek Safar <marek.safar@gmail.com>
880 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
883 2009-10-16 Marek Safar <marek.safar@gmail.com>
885 A fix for bug #493523, #507067
886 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
887 standard nullable conversion using underlying standard conversion
888 and not full conversion.
890 2009-10-15 Marek Safar <marek.safar@gmail.com>
892 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
893 type in VerifyArgumentsCompat.
895 2009-10-15 Marek Safar <marek.safar@gmail.com>
897 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
898 Reject variable used with type arguments.
900 2009-10-14 Marek Safar <marek.safar@gmail.com>
902 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
903 Implement dynamic expressions assignment.
905 2009-10-14 Marek Safar <marek.safar@gmail.com>
907 * expression.cs: Build underlying expression when resolving unary
910 2009-10-14 Marek Safar <marek.safar@gmail.com>
912 * expression.cs: Emit enum array initializer using binary blob.
914 2009-10-08 Marek Safar <marek.safar@gmail.com>
916 * typemanager.cs, constant.cs: Optimize decimal constants which fit
919 2009-10-07 Marek Safar <marek.safar@gmail.com>
921 * typemanager.cs: Reset object_type.
923 * assign: Made SimpleAssign public.
925 2009-10-06 Marek Safar <marek.safar@gmail.com>
927 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
928 invocation assembly to IsThisOrFriendAssembly.
930 2009-10-05 Marek Safar <marek.safar@gmail.com>
932 * expression.cs: Equality comparison of generic parameter with
935 2009-10-05 Marek Safar <marek.safar@gmail.com>
937 A fix for bug #543570
938 * generic.cs: Import predefined constraints correctly.
940 2009-10-02 Marek Safar <marek.safar@gmail.com>
942 * ecore.cs: Don't crash on overloads with optional paremeters where
943 arguments count overflows.
945 * parameter.cs: Import optional parameter constants using optional
948 2009-10-01 Marek Safar <marek.safar@gmail.com>
950 * Makefile: Default is gmcs compiler.
952 2009-10-01 Marek Safar <marek.safar@gmail.com>
954 * cs-parser.jay: Fixed few NRE.
956 2009-10-01 Marek Safar <marek.safar@gmail.com>
958 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
960 2009-09-30 Marek Safar <marek.safar@gmail.com>
962 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
963 ShimExpression, ImplicitCast.
965 2009-09-30 Marek Safar <marek.safar@gmail.com>
967 A fix for bug #542959
968 * delegate.cs: Emit correct delegate instance variable when there
969 are static and non-static overloads.
971 2009-09-29 Marek Safar <marek.safar@gmail.com>
973 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
974 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
976 2009-09-28 Marek Safar <marek.safar@gmail.com>
978 A fix for bug #542487
979 * ecore.cs: Resolve extension methods hidden by properties.
981 2009-09-25 Marek Safar <marek.safar@gmail.com>
983 * expression.cs, ecore.cs: More dynamic binary expressions.
985 2009-09-22 Marek Safar <marek.safar@gmail.com>
987 * nullable.cs, expression.cs: Fixed null lifted conversion for
988 bitwise enum operations.
990 2009-09-22 Marek Safar <marek.safar@gmail.com>
992 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
993 values in checked context.
995 2009-09-22 Marek Safar <marek.safar@gmail.com>
997 * expression.cs, ecore.cs: Fixed array index constant conversion.
999 2009-09-20 Miguel de Icaza <miguel@novell.com>
1001 * expression.cs: Do not crash when MemberLookup returns something
1002 that is not a MemberExpr here. Report error 582 instead.
1006 2009-09-18 Marek Safar <marek.safar@gmail.com>
1008 * decl.cs, class.cs: Check protected property accessors.
1010 2009-09-18 Marek Safar <marek.safar@gmail.com>
1012 * dynamic.cs, assign.cs: Dynamic compound assignment.
1014 2009-09-17 Marek Safar <marek.safar@gmail.com>
1016 * expression.cs: Fixed compound assignment explicit conversion.
1018 2009-09-17 Marek Safar <marek.safar@gmail.com>
1020 * expression.cs, ecore.cs: Cannot infer variables from method group.
1022 2009-09-16 Marek Safar <marek.safar@gmail.com>
1024 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
1025 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
1026 codegen.cs: Dynamic binary operations scaffolding.
1028 2009-09-15 Marek Safar <marek.safar@gmail.com>
1030 * expression.cs: Fixes nullable promotion for enum type variables.
1032 2009-09-11 Marek Safar <marek.safar@gmail.com>
1034 * driver.cs, dynamic.cs: Reset more static variables.
1036 2009-09-11 Marek Safar <marek.safar@gmail.com>
1038 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
1039 driver.cs: Introduced Expression::MakeExpression.
1041 2009-09-11 Marek Safar <marek.safar@gmail.com>
1043 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
1045 2009-09-09 Marek Safar <marek.safar@gmail.com>
1047 * eval.cs, report.cs: Use Console.Out for all eval error or warning
1050 2009-09-09 Marek Safar <marek.safar@gmail.com>
1052 A fix for bug #518707
1053 * expression.cs (Is): Optimize only generic parameter type
1054 expression probing value type generic parameter.
1056 2009-09-09 Marek Safar <marek.safar@gmail.com>
1058 A fix for bug #532571
1059 * ecore.cs: Check for simple name type arguments used with
1062 2009-09-08 Marek Safar <marek.safar@gmail.com>
1064 A fix for bug #497421
1065 * generic.cs (CheckConstraint): Don't use buildin types to check for
1066 parameterless constructor.
1068 2009-09-08 Marek Safar <marek.safar@gmail.com>
1070 A fix for bug #537402
1071 * generic.cs (CheckConstraint): Correctly inflate generic type
1072 arguments when checking generic method.
1074 2009-09-08 Marek Safar <marek.safar@gmail.com>
1076 A fix for bug #536463
1077 * decl.cs (AddToContainer): Don't report collision between explicit
1078 and parameterless non-explicit members.
1080 2009-09-08 Marek Safar <marek.safar@gmail.com>
1082 * eval.cs: Reset more static stuff.
1084 2009-09-07 Marek Safar <marek.safar@gmail.com>
1086 A fix for bug #324625
1087 * expression.cs, ecore.cs: Create nested generic type expression
1088 using declaring and not current type.
1090 2009-09-07 Marek Safar <marek.safar@gmail.com>
1092 * *.cs: Changed Report class to accept various output printers and
1093 be an instance class. An expression resolver can now use different
1094 message reporter for each call and Report.Error can safely throw
1095 an exception. Part of ongoing work to turn mcs into proper library.
1097 2009-09-04 Marek Safar <marek.safar@gmail.com>
1099 * statement.cs, ecore.cs: Removed error reporting from emit code.
1101 2009-09-04 Marek Safar <marek.safar@gmail.com>
1103 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
1105 2009-09-03 Marek Safar <marek.safar@gmail.com>
1107 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
1108 parser checks out of constructors.
1110 2009-09-02 Marek Safar <marek.safar@gmail.com>
1112 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
1114 2009-09-02 Marek Safar <marek.safar@gmail.com>
1116 A fix for bug #535448
1117 * anonymous.cs, class.cs: Copy return label between all contexts.
1119 2009-09-02 Marek Safar <marek.safar@gmail.com>
1121 A fix for bug #535395
1122 * namespace.cs: Resolve context can be null.
1124 2009-08-25 Marek Safar <marek.safar@gmail.com>
1126 A fix for bug #533912
1127 * generic.cs: Use correct context for constraints resolving.
1129 2009-08-25 Marek Safar <marek.safar@gmail.com>
1131 A fix for bug #532630
1132 * driver.cs: Trim conditional symbols.
1134 2009-08-25 Marek Safar <marek.safar@gmail.com>
1136 * context.cs: New file.
1138 * *.exe.sources, *.csproj: Updated.
1140 2009-08-25 Marek Safar <marek.safar@gmail.com>
1142 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1143 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1144 IMembercontext, some small cleanups.
1146 2009-08-24 Marek Safar <marek.safar@gmail.com>
1148 * *.cs: Split ResolveContext and EmitContext.
1150 2009-08-24 Marek Safar <marek.safar@gmail.com>
1152 * *.cs: Only ResolveContext implements IMemberContext.
1154 2009-08-21 Marek Safar <marek.safar@gmail.com>
1156 * *.cs: Renamed IResolveContext to IMemberContext.
1158 2009-08-21 Marek Safar <marek.safar@gmail.com>
1160 * *.cs: Detached ResolveContext from EmitContext.
1162 2009-08-21 Marek Safar <marek.safar@gmail.com>
1164 * codegen.cs: Moved flow-analysis to BlockContext.
1166 2009-08-21 Marek Safar <marek.safar@gmail.com>
1168 * *.cs: Detached BlockContext from EmitContext.
1170 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1172 * statement.cs: avoid nullref when the return value of GetEnumerator()
1173 does not contain any MoveNext() method.
1175 2009-08-19 Marek Safar <marek.safar@gmail.com>
1177 * *.cs: Removed IResolveContext::GenericDeclContainer.
1179 2009-08-19 Marek Safar <marek.safar@gmail.com>
1181 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1183 2009-08-19 Marek Safar <marek.safar@gmail.com>
1185 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1186 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1188 2009-08-18 Marek Safar <marek.safar@gmail.com>
1190 * *.cs: Removed boolean fields from EmitContext.
1192 2009-08-18 Marek Safar <marek.safar@gmail.com>
1194 * *.cs: Add IResolveContext::IsStatic.
1196 2009-08-18 Marek Safar <marek.safar@gmail.com>
1198 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1200 2009-08-17 Marek Safar <marek.safar@gmail.com>
1202 * *.cs: Removed DeclContainer from EmitContext.
1204 2009-08-17 Marek Safar <marek.safar@gmail.com>
1206 * *.cs: Add IResolveContext::CurrentTypeParameters.
1208 2009-08-14 Marek Safar <marek.safar@gmail.com>
1210 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1212 2009-08-14 Marek Safar <marek.safar@gmail.com>
1214 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1215 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1217 2009-08-13 Marek Safar <marek.safar@gmail.com>
1219 * decl.cs: Look in PartialContainer for parent type parameters.
1221 2009-08-13 Marek Safar <marek.safar@gmail.com>
1223 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1224 codegen.cs: Add IResolveContext::LookupTypeParameter.
1226 2009-08-13 Marek Safar <marek.safar@gmail.com>
1228 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1229 Moved resolved logic from Emit to Resolve.
1231 2009-08-13 Marek Safar <marek.safar@gmail.com>
1233 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1234 codegen.cs: Reworked atttributes handling of ResolveContext.
1236 2009-08-12 Marek Safar <marek.safar@gmail.com>
1238 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1239 LookupNamespaceOrType to ResolveContext.
1241 2009-08-12 Marek Safar <marek.safar@gmail.com>
1243 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1244 class.cs: Removed unused parameters and methods.
1246 2009-08-11 Marek Safar <marek.safar@gmail.com>
1248 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1249 codegen.cs: Finding the best common type of a set of expressions for
1252 2009-08-07 Marek Safar <marek.safar@gmail.com>
1254 * dynamic.cs, expression.cs: More dynamic conversions.
1256 2009-08-06 Miguel de Icaza <miguel@novell.com>
1258 * generic.cs: This loop was incorrect, it was increment ii, but
1259 checking for `i'. This was a change introduced to fix #327497,
1262 * class.cs: Catch another case for cs0533 error, fixes #324782.
1264 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1266 * typemanager.cs (GetGenericArguments): SRE returns null for
1267 generic methods on type builder instances if they are not generic
1268 themselves. For example, for Foo<int>::Bar() it returns null, but
1269 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1271 2009-08-05 Marek Safar <marek.safar@gmail.com>
1273 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1274 delegate.cs: Work on dynamic binding.
1276 2009-08-04 Marek Safar <marek.safar@gmail.com>
1278 A second fix for bug #525342
1279 * class.cs: Attach partial method attributes to method
1282 2009-08-03 Marek Safar <marek.safar@gmail.com>
1284 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1287 * rootcontext.cs: Default to langversion v4.
1289 2009-08-03 Marek Safar <marek.safar@gmail.com>
1291 * pending.cs: Check return type before member info is set.
1293 2009-08-03 Marek Safar <marek.safar@gmail.com>
1295 * anonymous.cs: Fully initialize generic hoisted field expression.
1297 2009-08-02 Miguel de Icaza <miguel@novell.com>
1299 * cs-parser.jay: Flag variables declared on the interactive shell
1300 as used to prevent the 168 warning about local variable not being
1303 2009-07-31 Marek Safar <marek.safar@gmail.com>
1305 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1306 attribute.cs: Emit dynamic export attribute.
1308 2009-07-30 Marek Safar <marek.safar@gmail.com>
1310 * expression.cs: More verifier work.
1312 2009-07-29 Marek Safar <marek.safar@gmail.com>
1314 * nullable.cs: Fixed SRE crash during corlib compilation.
1316 2009-07-29 Marek Safar <marek.safar@gmail.com>
1318 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1319 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1320 More TypeManager.TypeToCoreType needed.
1322 2009-07-29 Marek Safar <marek.safar@gmail.com>
1324 * anonymous.cs: Update after recent SRE fixes.
1326 2009-07-28 Marek Safar <marek.safar@gmail.com>
1328 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1329 version of GetFieldHandle for fields of generic types.
1331 2009-07-27 Marek Safar <marek.safar@gmail.com>
1333 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1334 ecore.cs: Add TypeManager.IsDynamicType,
1335 PredefinedAttributes.Dynamic.
1337 2009-07-27 Marek Safar <marek.safar@gmail.com>
1339 A fix for bug #415375
1340 * expression.cs: Fixed object and reference type parameter
1343 2009-07-27 Marek Safar <marek.safar@gmail.com>
1345 A fix for bug #525342
1346 * class.cs: Attach partial method attributes to method
1349 2009-07-24 Marek Safar <marek.safar@gmail.com>
1351 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1354 2009-07-24 Marek Safar <marek.safar@gmail.com>
1356 * anonymous.cs (MutateField): Add imported types handling.
1358 2009-07-23 Marek Safar <marek.safar@gmail.com>
1360 * expression.cs, delegate.cs: Moved arguments resolve into their
1361 counterparts expressions. Removed argument resolve from
1362 CollectionElementInitializer.
1364 2009-07-23 Marek Safar <marek.safar@gmail.com>
1366 A fix for bug #523683
1367 * convert.cs, delegate.cs: Use common overload mechanism for method
1368 group conversion check.
1370 2009-07-22 Marek Safar <marek.safar@gmail.com>
1372 A fix for bug #523899
1373 * generics.cs: Exact type inference with other bound types.
1375 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1377 Don't complain when the same type is implemented by the output
1378 assembly as well as multiple referenced assemblies
1379 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1380 'must_be_unique' flag.
1381 (GlobalRootNamespace): Update to changes.
1382 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1383 already have a type in hand.
1385 2009-07-22 Marek Safar <marek.safar@gmail.com>
1387 * expression.cs: More verifier instrumentation.
1389 * statement.cs: Do proper throw expression conversion.
1391 2009-07-22 Marek Safar <marek.safar@gmail.com>
1393 A fix for bug #522789
1394 * expression.cs: Mutate invocation return type.
1396 2009-07-16 Marek Safar <marek.safar@gmail.com>
1398 * anonymous.cs: Split assignable and readonly generated variable
1401 2009-07-16 Marek Safar <marek.safar@gmail.com>
1403 A fix for bug #521671
1404 * statement.cs: Fixed crash when checking missing type.
1406 2009-07-16 Marek Safar <marek.safar@gmail.com>
1408 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1409 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1410 class.cs, driver.cs: Work on dynamic binding.
1412 * dynamic.cs: New file.
1414 * *.sources, *.proj: Updated.
1416 2009-07-15 Marek Safar <marek.safar@gmail.com>
1418 * expression.cs (Conditional): Avoid double Resolve.
1420 2009-07-13 Marcus Griep <marcus@griep.us>
1422 * ecore.cs: Fix obscure bug with resolving members of interfaces
1423 that hide parent interface members. Fixes bug #444388 and corrects
1426 2009-07-13 Marek Safar <marek.safar@gmail.com>
1428 * expression.cs (LocalVariableReference): Bounce resolve.
1430 2009-07-10 Marek Safar <marek.safar@gmail.com>
1432 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1433 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1436 * support.cs: New dynamic type wrapper.
1438 2009-07-08 Marek Safar <marek.safar@gmail.com>
1440 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1441 typed local variable.
1443 2009-07-06 Marek Safar <marek.safar@gmail.com>
1445 A fix for bug #519005
1446 * anonymous.cs: Use null_type as no return type placeholder.
1448 2009-07-02 Marek Safar <marek.safar@gmail.com>
1450 * generic.cs: Handle type inference of identical type parameters
1451 with different bounds.
1453 2009-07-01 Marek Safar <marek.safar@gmail.com>
1455 * expression.cs, class.cs: Events variance.
1457 * cs-parser.jay: Interface events error messages.
1459 2009-07-01 Marek Safar <marek.safar@gmail.com>
1461 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1463 2009-06-29 Marek Safar <marek.safar@gmail.com>
1465 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1466 parameter expression can be value-type New.
1468 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1470 2009-06-26 Marek Safar <marek.safar@gmail.com>
1472 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1473 Implemented C# 4.0 named arguments.
1475 2009-06-24 Marek Safar <marek.safar@gmail.com>
1477 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1478 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1479 parameter modifier. Also fixes bug #515497.
1481 2009-06-24 Marek Safar <marek.safar@gmail.com>
1483 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1484 arguments expression to be implemented.
1486 *.sources: Add argument.cs
1488 2009-06-23 Marek Safar <marek.safar@gmail.com>
1490 * parameter.cs: Moved GetParameterIndexByName to base class.
1492 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1493 unused AType. Use argument's version of GetExpressionTree.
1495 2009-06-22 Marek Safar <marek.safar@gmail.com>
1497 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1500 2009-06-17 Marek Safar <marek.safar@gmail.com>
1502 A fix for bug #514096
1503 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1505 2009-06-17 Marek Safar <marek.safar@gmail.com>
1507 * expression.cs: The first multi-dimensional array nested array
1508 initializers was not checked.
1510 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1512 2009-06-17 Marek Safar <marek.safar@gmail.com>
1514 A fix for bug #513400
1515 * nullable.cs (EmitEquality): Operands emit could be simplified for
1516 built-in types when we now emit user operators differently.
1518 2009-06-16 Marek Safar <marek.safar@gmail.com>
1520 * ecore.cs: Report inaccessible delegate methods correctly.
1522 2009-06-16 Marek Safar <marek.safar@gmail.com>
1524 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1525 cs-parser.jay: Implemented C# 4.0 optional parameters.
1527 2009-06-16 Marek Safar <marek.safar@gmail.com>
1529 * driver.cs: Removed broken DefineManifestResource.
1531 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1533 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1534 Use $(BOOTSTRAP_PROFILE) instead.
1536 2009-06-12 Jb Evain <jbevain@novell.com>
1538 * rootcontext.cs: add a Platform field.
1539 * driver.cs: handle /platform.
1540 * codegen.cs: pass the proper flags according to
1541 the platform when saving the assembly.
1543 2009-06-11 Marek Safar <marek.safar@gmail.com>
1545 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1546 Add optional parameters grammar.
1548 2009-06-10 Marek Safar <marek.safar@gmail.com>
1550 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1551 driver.cs: Split lang version and metadata version.
1553 2009-06-10 Marek Safar <marek.safar@gmail.com>
1555 * decl.cs: Better overload ctor collision error message.
1557 2009-06-05 Jb Evain <jbevain@novell.com>
1559 * driver.cs (EmbededResource): avoid using an internal method
1560 in gmcs to embed manifest resources.
1562 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1564 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1565 the compiler from older mono versions (like moon's bots)
1567 2009-06-04 Marek Safar <marek.safar@gmail.com>
1569 * namespace.cs (LookupTypeReflection): Ignore collisions between
1572 2009-06-04 Marek Safar <marek.safar@gmail.com>
1574 * codegen.cs: Enabled generic type forwarders.
1576 2009-06-04 Marek Safar <marek.safar@gmail.com>
1578 * dmcs.*: Add another version of SRE compiler.
1580 2009-06-03 Marek Safar <marek.safar@gmail.com>
1582 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1583 generic-mcs.cs: Fixed variant type conversions.
1585 2009-06-02 Marek Safar <marek.safar@gmail.com>
1587 A fix for bug #507863
1588 * codegen.cs: Fixes a crash on invalid string value attribute.
1590 2009-06-01 Marek Safar <marek.safar@gmail.com>
1592 A fix for bug #508334
1593 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1594 cs-parser.jay: Fully import __arglist modifier.
1596 2009-05-29 Marek Safar <marek.safar@gmail.com>
1598 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1599 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1600 actually work with closed generic types.
1602 2009-05-27 Alan McGovern <amcgovern@novell.com>
1604 * class.cs, decl.cs, delegate.cs, parameter.cs:
1605 Fix the build by replacing the use of 'var' with the actual type.
1607 2009-05-27 Marek Safar <marek.safar@gmail.com>
1609 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1610 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1613 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1616 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1617 Marek Safar <marek.safar@gmail.com>
1619 A fix for bug #377509
1620 * parameter.cs: Use predefined and not empty name for implicit
1623 2009-05-21 Marek Safar <marek.safar@gmail.com>
1625 * class.cs: Don't report wrong warnings for event fields.
1627 2009-05-21 Marek Safar <marek.safar@gmail.com>
1629 A fix for bug #504667
1630 * class.cs: Check for static class using parent container instead of
1633 2009-05-08 Marek Safar <marek.safar@gmail.com>
1635 A fix for bug #496922
1636 * expression.cs: Always use temporary variable when using object
1639 2009-04-28 Marek Safar <marek.safar@gmail.com>
1641 A fix for bug #495112
1642 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1645 2009-04-27 Miguel de Icaza <miguel@novell.com>
1647 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1649 2009-04-24 Miguel de Icaza <miguel@novell.com>
1651 * complete.cs: No idea how gonzalo got a null in the list, but
1654 2009-04-24 Miguel de Icaza <miguel@novell.com>
1656 * complete.cs (CompletionElementInitializer): New completion class
1657 to support completing inside a C# 3 element initializer, so this
1658 allows completion for Silverlight situations where it is very
1661 new TextBlock () { Fo<TAB>
1663 (CompletionSimpleName): Expose the prefix that was
1664 passed to the simple name.
1666 * cs-parser.jay (object_or_collection_initializer): Add support
1667 for element_initializers.
1669 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1670 special case completion expressions as this method aggressively
1671 collects data before it operates, and errors were being thrown
1672 earlier than we were able to complete.
1674 2009-04-23 Miguel de Icaza <miguel@novell.com>
1676 * eval.cs: Make getcompletions silent and enable debugging output
1677 if the -v option is passed.
1679 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1680 Consider looking up the namespace that matches the prefix being
1683 This is part of the support for allowing completions like:
1684 `System.Co<TAB>' to complete to System.Console.
1686 * complete.cs (CompletionSimpleName.AppendResults): Make this
1689 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1691 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1692 COMPLETE_COMPLETION as internal.
1694 2009-04-17 Miguel de Icaza <miguel@novell.com>
1696 * complete.cs: Include namespace resolution in simple names as
1697 well as global types and types in the using scope in the
1700 * namespace.cs: Supporting infrastrcture to provide completions
1701 based on the current using scope.
1703 * eval.cs: Introduce an entry point that allows for initialization
1704 to return a list of the files passed on the command line.
1706 2009-04-14 Marek Safar <marek.safar@gmail.com>
1708 A fix for bug #494243
1709 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1711 2009-04-13 Marek Safar <marek.safar@gmail.com>
1713 A fix for bug #493887
1714 * statement.cs: Don't skip string multi-section with default or
1715 null label when populating string hashtable.
1717 2009-04-06 Marek Safar <marek.safar@gmail.com>
1719 A fix for bug #492329
1720 * expression.cs (New): Load variable when assigning type parameter
1723 2009-04-06 Marek Safar <marek.safar@gmail.com>
1725 A fix for bug #488960
1726 * decl.cs: Compare MVAR types using non-null values.
1728 2009-03-27 Marek Safar <marek.safar@gmail.com>
1730 * typemanager.cs, expression.cs: Removed unused nullable checks.
1732 2009-03-27 Marek Safar <marek.safar@gmail.com>
1734 * *.cs: Removed some gmcs conditionals.
1736 2009-03-26 Marek Safar <marek.safar@gmail.com>
1738 * generic.cs, support.cs: Moved generics stuff out of support.cs
1740 2009-03-24 Marek Safar <marek.safar@gmail.com>
1742 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1745 2009-03-23 Marek Safar <marek.safar@gmail.com>
1747 * attribute.cs: Consider all members for error reporting when
1748 checking named arguments.
1750 2009-03-23 Marek Safar <marek.safar@gmail.com>
1752 A fix for bug #487625
1753 * namespace.cs: Use a warning for all predefined type conflicts.
1755 2009-03-23 Marek Safar <marek.safar@gmail.com>
1757 A fix for bug #485706
1758 * statement.cs: Explicitly type catch type argument to pass verifier
1761 2009-03-22 Miguel de Icaza <miguel@novell.com>
1763 Initial support to provide code completion facilities to consumers
1764 of the evaluator API.
1766 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1767 support the completion engine. When we reach the end of the
1768 input stream instead of returning EOF, when this flag is true the
1769 tokenizer instead produces:
1771 One GENERATE_COMPLETION token: this token then must be
1772 handled in the grammar at every point where the user
1773 would likely request a completion.
1775 As many COMPLETE_COMPLETION tokens as necessary. These
1776 tokens are generated to assist the parser in unwinding and
1777 producing a valid parse tree.
1779 The parser rules do not have to be perfect, the parser needs to be
1780 augmented with judicious use of GENERATE_COMPLETION tokens to
1781 improve the areas where we can provide completion and the parser
1782 needs to add support for COMPLETE_COMPLETION tokens in productions
1785 It is common to not have enough support for COMPLETE_COMPLETION
1786 under certain rules and that even if we generated the
1787 GENERATE_COMPLETION token that the resulting tree will be invalid
1788 due to the missing rules that support COMPLETE_COMPLETION.
1790 The final EOF token is produced by having the parser notify the
1791 tokenizer when it reaches the root production that the next token
1794 * support.cs (CompletionResult): New Exception. This exception
1795 is thrown to return the completion results when one of the special
1796 completion expressions is reached.
1798 This exception is thrown by the completing ExpressionStatements
1799 classes that live in complete.cs
1801 * complete.cs (CompletingExpression): a new base class for
1802 completing expressions. This derives from the
1803 ExpressionStatement class and not from Expression as it allows
1804 completion to happen not only where expressions are expected in
1805 the grammar, but also where statements are expected.
1807 (CompletionSimpleName): A new class used to provide completions
1808 for SimpleNames. This currently only resolves to local
1809 variables from the evaluator context (GetVars call).
1811 (CompletionMemberAccess): Implements support for completing member
1814 * cs-parser.jay: Add support for completion in a few places.
1816 * eval.cs (GetCompletions): New public API for the evaluator that
1817 returns a list of possible completions given the input. The
1818 return value is an array of completions
1820 * anonymous.cs (Compatible): If the exception thrown from the
1821 resolved expression is a CompletionResult exception let that one
1822 through instead of printing a diagnostic error in the try/catch.
1824 2009-03-22 Miguel de Icaza <miguel@novell.com>
1828 * driver.cs (Main): Use Environment.Exit to quit quickly and
1829 prevent the compiler from doing the usual wait for helper thread
1832 This is to prevent a slowdown that was reported by Gonzalo on
1835 2009-03-19 Marek Safar <marek.safar@gmail.com>
1837 * ecore.cs: Load build-in types directly instead of accessing
1840 2009-03-18 Marek Safar <marek.safar@gmail.com>
1842 * ecore.cs: Always use unbox.any when available.
1844 2009-03-18 Marek Safar <marek.safar@gmail.com>
1846 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1848 2009-03-17 Marek Safar <marek.safar@gmail.com>
1850 * generic.cs: Removed obsolete version of type inference.
1852 2009-03-16 Marek Safar <marek.safar@gmail.com>
1854 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1855 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1856 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1857 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1859 2009-03-11 Marek Safar <marek.safar@gmail.com>
1861 A fix for bug #482996
1862 * anonymous.cs: Make sure we are not infering return type when
1863 checking type compatibility.
1865 2009-03-11 Marek Safar <marek.safar@gmail.com>
1867 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1868 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1869 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1870 attributes in their own structure. Needed when accessing their
1871 properties before they are resolved.
1873 2009-03-09 Marek Safar <marek.safar@gmail.com>
1875 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1876 hashtable (~10x faster).
1878 * driver.cs: Removed wrong Reset.
1880 2009-03-08 Marek Safar <marek.safar@gmail.com>
1882 * class.cs: Use correct common base type for unmanaged delayed
1885 * rootcontext.cs: Wrap unhandled exception.
1887 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1889 Make SeekableStreamReader self-tuning and arbitrarily seekable
1890 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1892 (SeekableStreamReader.Position.set): Use it. Simplify logic
1893 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1894 buffer size when the stream needs to be re-read from the beginning.
1896 2009-03-05 Marek Safar <marek.safar@gmail.com>
1898 A fix for bug #480100
1899 * parameter.cs: A parameter is not hoisted when used directly as ET.
1901 2009-03-04 Marek Safar <marek.safar@gmail.com>
1903 * statement.cs: Fixed an issue when using variable is of interface
1906 2009-03-03 Marek Safar <marek.safar@gmail.com>
1908 A fix for bug #480319
1909 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1911 2009-03-03 Marek Safar <marek.safar@gmail.com>
1913 A fix for bug #480867
1914 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1915 expression to have no valid type.
1917 2009-03-03 Marek Safar <marek.safar@gmail.com>
1919 A fix for bug #481258
1920 * class.cs: Set extension method flag in partial container.
1922 2009-03-03 Marek Safar <marek.safar@gmail.com>
1924 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1926 * attribute.cs: Add sanity check.
1928 2009-02-27 Marek Safar <marek.safar@gmail.com>
1930 * class.cs: Add external constructor error.
1932 2009-02-26 Marek Safar <marek.safar@gmail.com>
1934 A fix for bug #475354
1935 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1936 correctly user defined nullable equality operators.
1938 2009-02-25 Marek Safar <marek.safar@gmail.com>
1940 A fix for bug #479532
1941 * expression.cs: Implement NewInitialize::AddressOf.
1943 2009-02-25 Marek Safar <marek.safar@gmail.com>
1945 A fix for bug #413633
1946 * expression.cs: Iterate all base class-constraint types.
1948 2009-02-24 Marek Safar <marek.safar@gmail.com>
1950 A fix for bug #479209
1951 * literal.cs: Mutate null underlying type.
1953 2009-02-24 Marek Safar <marek.safar@gmail.com>
1955 A fix for bug #476295
1956 * convert.cs: Avoid wrapping implicitly convertible reference type.
1958 2009-02-23 Marek Safar <marek.safar@gmail.com>
1960 * iterators.cs: Create MemberName correctly.
1962 2009-02-23 Marek Safar <marek.safar@gmail.com>
1964 A fix for bug #478655
1965 * literal.cs: Check also underlying null type conversion.
1967 2009-02-21 Marek Safar <marek.safar@gmail.com>
1969 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1971 2009-02-20 Marek Safar <marek.safar@gmail.com>
1973 A fix for bug #477447
1974 * statement.cs: Add reference to correct parent storey when this
1975 is accessible from deep children storey (more than 1 level).
1977 2009-02-19 Marek Safar <marek.safar@gmail.com>
1979 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1980 * class.cs: Define base type members before setting up member cache.
1982 2009-02-18 Marek Safar <marek.safar@gmail.com>
1984 A fix for bug #477378
1985 * nullable.cs, expression.cs, statement.cs: More precise null type
1988 2009-02-18 Marek Safar <marek.safar@gmail.com>
1990 A fix for bug #472805
1991 * typemanager.cs, namespace.cs: Import only visible extension method
1994 2009-02-18 Marek Safar <marek.safar@gmail.com>
1996 A fix for bug #476895
1997 * attribute.cs: Use correct resolve context for attribute type.
1999 2009-02-18 Marek Safar <marek.safar@gmail.com>
2001 A fix for bug #476266
2002 * anonymous.cs: Mutate multi-dimensional arrays.
2004 2009-02-18 Marek Safar <marek.safar@gmail.com>
2006 A fix for bug #476400
2007 * statement.cs, expression.cs: Removed wrong Dispose optimization.
2009 2009-02-18 Marek Safar <marek.safar@gmail.com>
2011 A fix for bug #476811
2012 * generics.cs: Fixed null-literal check.
2014 2009-02-17 Marek Safar <marek.safar@gmail.com>
2016 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
2017 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
2018 messing with static variables.
2020 2009-02-16 Marek Safar <marek.safar@gmail.com>
2022 A fix for bug #475965
2023 * generics.cs: Check generic parameter type after extracting from
2026 2009-02-16 Marek Safar <marek.safar@gmail.com>
2028 A fix for bug #475823
2029 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
2032 2009-02-14 Marek Safar <marek.safar@gmail.com>
2034 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
2035 Simplified event field definition using backing field and not
2036 field builder directly.
2038 * expression.cs (EmitLdArg): Optimize fast paths.
2040 2009-02-13 Marek Safar <marek.safar@gmail.com>
2042 A fix for bug #475327
2043 * expression.cs (ArrayCreation): Don't mutate values optimized away.
2045 2009-02-13 Marek Safar <marek.safar@gmail.com>
2047 A fix for bug #475342
2048 * cs-parser.jay: Using 'super' instead of 'base' to call base
2049 constructor crashes compiler.
2051 2009-02-13 Marek Safar <marek.safar@gmail.com>
2053 A fix for bug #475354
2054 * expression.cs (Constantify): Add nullable types.
2056 * const.cs (EmitDecimalConstant): Avoid explicit cast.
2058 2009-02-12 Marek Safar <marek.safar@gmail.com>
2060 A fix for bug #475246
2061 * expression.cs: More broken flowanalysis hacking needed.
2063 2009-02-12 Marek Safar <marek.safar@gmail.com>
2065 * attribute.cs: Compare only ref/out array modifiers.
2067 2009-02-11 Marek Safar <marek.safar@gmail.com>
2069 * statement.cs: Use member cache when looking for foreach members.
2071 2009-02-11 Marek Safar <marek.safar@gmail.com>
2073 * expression.cs: Don't expose internal initializer types.
2075 * statement.cs: Check also explicit conversions for goto case.
2077 2009-02-11 Marek Safar <marek.safar@gmail.com>
2079 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
2081 2009-02-10 Marek Safar <marek.safar@gmail.com>
2083 * *.cs: Replace null-type with NullLiteral where appropriate.
2085 2009-02-09 Marek Safar <marek.safar@gmail.com>
2087 * expression.cs: Initializer of reference argument use temporary
2088 variable to be verifiable.
2090 * parameter.cs: Share EmitLdArg.
2092 2009-02-09 Marek Safar <marek.safar@gmail.com>
2094 A fix for bug #473559
2095 * class.cs: Fixed: Not reporting error about nested class with the
2098 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
2100 Contributed under the MIT/X11 license.
2102 * generic.cs: Added VerifyVariantTypeParameters which performs new
2103 variance verification logic. The old logic, based on the spec, was
2104 wrong because the spec is full of LIES!
2106 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
2108 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
2111 * ecore.cs: Added calls to the new variance verification logic.
2114 * delegate.cs: Removed calls to the old variance verification logic.
2116 2009-02-06 Marek Safar <marek.safar@gmail.com>
2118 * delegate.cs: Use cached Invoke method directly.
2120 2009-02-06 Marek Safar <marek.safar@gmail.com>
2122 * expression.cs: Emit expression tree for hoisted variable access.
2124 2009-02-04 Marek Safar <marek.safar@gmail.com>
2126 * namespace.cs: Add better extension class check.
2128 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2130 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2132 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2134 This patch adds initial generic variance support to the compiler.
2135 It is contributed under the MIT/X11 license.
2137 * typemanager.cs: Modified ImplementsInterface to check variance.
2138 Added VerifyVariantTypeParameters which checks the specified type to see
2139 if it uses a variant type parameter as a type argument (which is not
2140 allowed). Added IsVariantOf which determins if the first type is a
2141 variant of the second. NOTE: This only supports reference types at
2142 the moment to conform with the current level of VM support. When the
2143 VM supports value types, this will follow step.
2145 * generic.cs: Added the Variance enum. Added a Variance property to
2146 TypeParameter and added variance support to definition phase. Added a
2147 Variance property to TypeParameterName. Also check to make sure that
2148 no variant types appear in generic method parameters.
2150 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2151 keywords if the langversion supports it.
2153 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2154 that variant types are only used in legal positions. Also added
2155 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2158 * decl.cs: Construct TypeParameter with the variance information.
2160 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2161 and ImplicitConversionStandard.
2163 * rootcontext.cs: Added new "Future" language version.
2165 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2166 type parameters are not used as type arguments in interface inheritance.
2167 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2168 parameters are not used as method return types. In MemberBase.
2169 ResolveMemberType, ensure that variant type parameters are not used
2170 as type arguments. Also call VerifyNoVariantTypeParameters on every
2171 set of parameters which are resolved.
2173 * delegate.cs: Modified Delegate.Define to ensure that variant
2174 parameters are not used as type arguments and that a contravariant
2175 parameter is not used as the return type. Also call
2176 VerifyNoVariantTypeParameters on the delegate parameters.
2178 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2179 to specify generic variance.
2181 * driver.cs: Added support for LanguageVersion.Future in the form of
2182 "-langversion:future".
2184 * generic-mcs.cs: Stubbed out new members in generic.cs.
2186 2009-02-03 Marek Safar <marek.safar@gmail.com>
2188 * class.cs, generic.cs: Emit type parameter constraints for nested
2191 2009-02-02 Marek Safar <marek.safar@gmail.com>
2193 A fix for bug #471213
2194 * class.cs: Avoid emitting backing field for abstract event fields.
2196 2009-02-01 Marek Safar <marek.safar@gmail.com>
2198 A fix for bug #359731
2199 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2202 2009-01-30 Marek Safar <marek.safar@gmail.com>
2204 A fix for bug #470767
2205 * statement.cs: Introduced BlockScopeExpression, needed when
2206 expression tree conversion has to emit scope variables.
2208 2009-01-29 Marek Safar <marek.safar@gmail.com>
2210 * class.cs: Remove duplicate CallingConvention.
2212 2009-01-29 Marek Safar <marek.safar@gmail.com>
2214 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2215 when I finally found the right naming convention.
2217 2009-01-29 Marek Safar <marek.safar@gmail.com>
2219 * cs-tokenizer.cs: Put back different open parens optimization.
2221 2009-01-28 Marek Safar <marek.safar@gmail.com>
2223 A fix for bug #470227
2224 * cs-tokenizer.cs: Remove too agressive parser optimization.
2226 2009-01-28 Marek Safar <marek.safar@gmail.com>
2228 A fix for bug #324319
2229 * class.cs: Remove too early base type resolve.
2231 2009-01-27 Marek Safar <marek.safar@gmail.com>
2233 A fix for bug #324319
2234 * ecore.cs: Explicitly type null when assigning to type argument to
2235 make pass verifier check.
2237 2009-01-27 Marek Safar <marek.safar@gmail.com>
2239 * anonymous.cs: Fixed recent regression when initializing captured
2242 2009-01-26 Marek Safar <marek.safar@gmail.com>
2244 A fix for bug #469019
2245 * anonymous.cs: Use all parent type parameters when instantiating
2246 nested generic storey.
2248 2009-01-26 Marek Safar <marek.safar@gmail.com>
2250 * expression.cs: Check for null instance methodgroup expression.
2252 2009-01-26 Marek Safar <marek.safar@gmail.com>
2254 A fix for bug #469244
2255 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2256 instance inside a conditional expression.
2258 2009-01-23 Marek Safar <marek.safar@gmail.com>
2260 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2261 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2262 GetElementType and HasElementType. IsValueType clean up.
2264 2009-01-23 Marek Safar <marek.safar@gmail.com>
2266 * nullable.cs: Use common EmitCall.
2268 * expression.cs: Emit constraint. for virtual calls only.
2270 2009-01-23 Marek Safar <marek.safar@gmail.com>
2272 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2273 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2274 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2277 2009-01-22 Jb Evain <jbevain@novell.com>
2279 * anonymous.cs: make anonymous types' ToString implementation
2280 match what csc outputs.
2282 2009-01-21 Marek Safar <marek.safar@gmail.com>
2284 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2287 2009-01-17 Marek Safar <marek.safar@gmail.com>
2289 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2292 2009-01-16 Marek Safar <marek.safar@gmail.com>
2294 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2297 2009-01-15 Marek Safar <marek.safar@gmail.com>
2299 A fix for bug #466634
2300 * statement.cs: Add reference for nested storey when only this
2303 2009-01-15 Marek Safar <marek.safar@gmail.com>
2305 A fix for bug #466474
2306 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2309 2009-01-15 Marek Safar <marek.safar@gmail.com>
2311 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2312 Fixed nested stories parent referencing process. Also fixes #463985.
2314 2009-01-06 Marek Safar <marek.safar@gmail.com>
2316 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2317 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2318 implementation. Also fixes #463108.
2320 2009-01-05 Marek Safar <marek.safar@gmail.com>
2322 A fix for bug #416109
2323 * decl.cs: Issue correct CLSAttribute warning location.
2325 2009-01-05 Marek Safar <marek.safar@gmail.com>
2327 A fix for bug #456775
2328 * attribute.cs: Use attribute owner scope when resolving attribute
2331 2009-01-05 Marek Safar <marek.safar@gmail.com>
2333 A fix for bug #457257
2334 * decl.cs: Fixed incorrect member declaring type comparison.
2336 2009-01-05 Marek Safar <marek.safar@gmail.com>
2338 A fix for bug #460896
2339 * driver.cs: Handle /RES resources as embeddable.
2341 2009-01-05 Marek Safar <marek.safar@gmail.com>
2343 A fix for bug #462515
2344 * ecore.cs: Report inacessible members upwards.
2346 2009-01-05 Marek Safar <marek.safar@gmail.com>
2348 A fix for bug #463190, #463192
2349 * decl.cs, namespace.cs: Also import internal extension classes.
2351 2009-01-04 Marek Safar <marek.safar@gmail.com>
2353 A fix for bug #463415
2354 * generic.cs: Use right index for RemoveDependentTypes.
2356 2009-01-02 Marek Safar <marek.safar@gmail.com>
2358 A fix for bug #463196
2359 * expression.cs: Fixed enum to null comparison.
2361 2009-01-02 Marek Safar <marek.safar@gmail.com>
2363 A fix for bug #463121
2364 * nullable.cs: Fixed nullable user equality operator comparison.
2366 2009-01-02 Marek Safar <marek.safar@gmail.com>
2368 A fix for bug #462950
2369 * class.cs, decl.cs: Use full explicit name when defining automatic
2370 property backing field.
2372 2009-01-02 Marek Safar <marek.safar@gmail.com>
2374 A fix for bug #462592
2375 * pending.cs: Emit type arguments for generic proxy method.
2377 2008-12-30 Marek Safar <marek.safar@gmail.com>
2379 * expression.cs (As): Mutate all type arguments.
2381 2008-12-29 Marek Safar <marek.safar@gmail.com>
2383 A fix for bug #462622
2384 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2387 2008-12-29 Marek Safar <marek.safar@gmail.com>
2389 A fix for bug #450782
2390 * ecore.cs: Consider more variables of form V.I to be fixed.
2392 2008-12-29 Marek Safar <marek.safar@gmail.com>
2394 A fix for bug #460712
2395 * typemanager.cs: Core types could be imported.
2397 2008-12-28 Marek Safar <marek.safar@gmail.com>
2399 A fix for bugs #460847, #460772, #458049, #457339, #447807
2400 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2401 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2402 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2403 user lambdas used inside query clauses.
2405 2008-12-18 Marek Safar <marek.safar@gmail.com>
2407 A fix for bug #460229
2408 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2410 2008-12-18 Marek Safar <marek.safar@gmail.com>
2412 A fix for bug #459952
2413 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2415 2008-12-18 Marek Safar <marek.safar@gmail.com>
2417 A fix for bug #459630
2418 * convert.cs: Enum to valuetype conversion is not allowed.
2420 2008-12-18 Marek Safar <marek.safar@gmail.com>
2422 A fix for bug #457087
2423 * generic.cs: Don't crash when constraint comes from type
2426 2008-12-16 Marek Safar <marek.safar@gmail.com>
2428 A fix for bug #459221
2429 * anonymous.cs, statement.cs: Delay only captured this
2432 2008-12-12 Marek Safar <marek.safar@gmail.com>
2434 A fix for bug #457489
2435 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2436 and initialization to capture scope initializers correctly.
2438 2008-12-11 Marek Safar <marek.safar@gmail.com>
2440 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2441 ParameterReference refactoring.
2443 2008-12-03 Marek Safar <marek.safar@gmail.com>
2445 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2446 to be imported from any assembly.
2448 2008-12-03 Marek Safar <marek.safar@gmail.com>
2450 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2451 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2452 from anonymous method and lambda expression.
2454 2008-12-01 Marek Safar <marek.safar@gmail.com>
2456 A fix for bug #448560
2457 * expression.cs (As): Box any generic type arguments to be
2460 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2462 Add tripwire for implicit conversion bugs
2463 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2465 (MethodGroupExpr.OverloadResolve): Add sanity check between
2466 IsApplicable and VerifyArgumentsCompat.
2467 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2469 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2471 Fix build break in System.Data_test
2472 * convert.cs (ImplicitConversionExists): Move NullLiteral
2474 (ImplicitStandardConversionExists): ... here.
2476 2008-11-28 Marek Safar <marek.safar@gmail.com>
2478 * literal.cs: Emit correctly explicit null to nullable cast.
2480 2008-11-28 Marek Safar <marek.safar@gmail.com>
2482 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2485 2008-11-28 Marek Safar <marek.safar@gmail.com>
2487 A fix for bug #449005
2488 * convert.cs, nullable.cs: Use only one implicit nullable
2491 2008-11-27 Marek Safar <marek.safar@gmail.com>
2493 * convert.cs, literal.cs: More Convert cleanup is needed.
2495 2008-11-27 Marek Safar <marek.safar@gmail.com>
2497 * decl.cs, class.cs: Fixed misleading error message.
2499 2008-11-26 Marek Safar <marek.safar@gmail.com>
2501 A fix for bug #449005
2502 * nullable.cs (EmitEquality): Disable optimization for user operator
2505 2008-11-25 Marek Safar <marek.safar@gmail.com>
2507 A fix for bug #447027
2508 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2509 with context variables stored as expression instances.
2511 2008-11-25 Marek Safar <marek.safar@gmail.com>
2513 A fix for bug #447027
2514 * delegate.cs: Fixed delegate VerifyMethod logic.
2516 2008-11-24 Marek Safar <marek.safar@gmail.com>
2518 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2521 2008-11-21 Marek Safar <marek.safar@gmail.com>
2523 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2524 member type resolve to follow normal flow, instead of random
2527 2008-11-21 Marek Safar <marek.safar@gmail.com>
2529 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2532 2008-11-21 Marek Safar <marek.safar@gmail.com>
2534 * const.cs: Emit decimal array constant as literal.
2536 2008-11-20 Marek Safar <marek.safar@gmail.com>
2538 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2540 2008-11-19 Marek Safar <marek.safar@gmail.com>
2542 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2543 into real property (saves 8 MB for corlib compilation).
2545 2008-11-19 Marek Safar <marek.safar@gmail.com>
2547 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2548 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2549 generic-mcs.cs: Small cleanup of TypeArguments.
2551 2008-11-18 Marek Safar <marek.safar@gmail.com>
2553 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2554 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2555 of ConstructedType expression, renamed to GenericTypeExpr.
2557 2008-11-17 Marek Safar <marek.safar@gmail.com>
2559 A fix for bug #445303
2560 * location.cs (IsConditionalDefined): Handle undefined global
2563 2008-11-17 Marek Safar <marek.safar@gmail.com>
2565 A fix for bug #444678
2566 * expression.cs (TryReduceConstant): Always create new constant
2569 2008-11-17 Marek Safar <marek.safar@gmail.com>
2571 A fix for bug #444673
2572 * ecore.cs: Ignore open generic types when used as generic type
2575 2008-11-17 Marek Safar <marek.safar@gmail.com>
2577 A fix for bug #445458
2578 * expression.cs, cs-parser.jay: Don't crash when an expression
2581 2008-11-17 Marek Safar <marek.safar@gmail.com>
2583 A fix for bug #445464
2584 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2585 inside unbound type.
2587 2008-11-14 Jb Evain <jbevain@novell.com>
2589 * driver.cs: ignore empty -nowarn argument such as
2590 the one in -nowarn:12,13,,.
2592 2008-11-13 Marek Safar <marek.safar@gmail.com>
2594 A fix for bug #444271
2595 * anonymous.cs: Rescan parent storeys when best candidate was
2598 2008-11-13 Marek Safar <marek.safar@gmail.com>
2600 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2601 useless UnboundTypeExpression.
2603 * attribute.cs: Do check obsolete attribute on generic types.
2605 2008-11-12 Marek Safar <marek.safar@gmail.com>
2607 A fix for bugs #425680, #400139
2608 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2611 2008-11-11 Marek Safar <marek.safar@gmail.com>
2613 A fix for bug #435747
2614 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2615 compound value types assignment. Few micro optimizations added.
2617 2008-11-10 Marek Safar <marek.safar@gmail.com>
2619 A fix for bug #442610
2620 * anonymous.cs (MutateConstructor): More SRE hacking.
2622 2008-11-10 Marek Safar <marek.safar@gmail.com>
2624 A fix for bug #442579
2625 * ecore.cs: Also initialize expanded form of a method with 1 params
2628 2008-11-06 Marek Safar <marek.safar@gmail.com>
2630 * expression.cs (UnaryMutator): Do early l-side check.
2632 2008-11-05 Miguel de Icaza <miguel@novell.com>
2634 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2635 Init, otherwise we would crash later on when checking for friend
2638 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2639 Otherwise we never get any meaningful information as to what
2642 2008-11-05 Marek Safar <marek.safar@gmail.com>
2644 A fix for bug #436318
2645 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2647 2008-11-05 Miguel de Icaza <miguel@novell.com>
2649 * namespace.cs: Turns out that it was a really bad idea to hide
2650 the errors for namespaces not found here in eval mode.
2652 * eval.cs: When we process using clauses, only enter those into
2653 the list of valid using clauses after they have been validated.
2655 The above change gives the proper semantics: it does not
2656 senselessly report the same errors with broken using statements by
2657 never storing them in the first place when they are invalid.
2659 2008-11-05 Marek Safar <marek.safar@gmail.com>
2661 A fix for bug #421839
2662 * cs-parser.jay: Remove expression from coalesce rule to force lower
2663 priority than the assignment operator.
2665 2008-11-05 Marek Safar <marek.safar@gmail.com>
2667 A fix for bug #437875
2668 * nullable.cs: Compile correctly method group operand used with null
2669 coalescing operator.
2671 2008-11-04 Marek Safar <marek.safar@gmail.com>
2673 A fix for bug #434589
2674 * expression.cs (Binary): Ignore lifted conversions when at least
2675 one operand is of reference type.
2677 2008-11-04 Marek Safar <marek.safar@gmail.com>
2679 * cs-parser.jay: Better syntax error report.
2681 2008-11-03 Marek Safar <marek.safar@gmail.com>
2683 A fix for bug #436792
2684 * cs-parser.jay: Use GetLocation to access location.
2686 2008-11-03 Marek Safar <marek.safar@gmail.com>
2688 A fix for bug #440774
2689 * cs-parser.jay: Also set current_array_type when parsing local
2692 2008-11-03 Marek Safar <marek.safar@gmail.com>
2694 A fix for bug #440785
2695 * expression.cs (As): Don't resolve self modifing expression
2698 2008-11-03 Marek Safar <marek.safar@gmail.com>
2700 A fix for bug #439447
2701 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2703 2008-11-03 Marek Safar <marek.safar@gmail.com>
2705 A fix for bug #437571
2706 * cs-parser.jay: Fixes internal error for invalid expression
2709 2008-10-17 Marek Safar <marek.safar@gmail.com>
2711 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2713 2008-10-17 Marek Safar <marek.safar@gmail.com>
2715 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2717 2008-10-17 Marek Safar <marek.safar@gmail.com>
2719 * cs-tokenizer.cs: More precise cast parsing.
2721 2008-10-16 Martin Baulig <martin@ximian.com>
2723 * anonymous.cs (AnonymousMethodStorey): Put back the
2724 `hoisted_locals' hashtable and use it in EmitType().
2726 2008-10-15 Marek Safar <marek.safar@gmail.com>
2728 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2729 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2732 2008-10-14 Marek Safar <marek.safar@gmail.com>
2734 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2736 2008-10-14 Marek Safar <marek.safar@gmail.com>
2738 * statement.cs: Mutate scope initializers.
2740 2008-10-14 Marek Safar <marek.safar@gmail.com>
2742 * expression.cs: Use typeless value for This constant.
2744 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2746 2008-10-14 Marek Safar <marek.safar@gmail.com>
2748 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2751 2008-10-13 Marek Safar <marek.safar@gmail.com>
2753 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2756 2008-10-13 Marek Safar <marek.safar@gmail.com>
2758 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2759 parser and tokenizer. Fixes many ambiguities including #433258.
2761 2008-10-10 Marek Safar <marek.safar@gmail.com>
2763 * cs-parser.jay: Fixed missing accessor recovery.
2765 2008-10-10 Marek Safar <marek.safar@gmail.com>
2767 A fix for bug #433701
2768 * expression.cs: Better error message.
2770 2008-10-10 Marek Safar <marek.safar@gmail.com>
2772 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2774 * Makefile: Disabled unused debug symbols.
2776 Also fixes: #320556, #321097, #321656, #321876, #351316
2778 2008-10-09 Miguel de Icaza <miguel@novell.com>
2780 * eval.cs: rename "<interactive>" to "{interactive}", to work
2781 around a requirement in the compiler that this be a valid
2782 filename, and in Windows it is not (433886).
2784 2008-10-09 Marek Safar <marek.safar@gmail.com>
2786 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2788 2008-10-08 Marek Safar <marek.safar@gmail.com>
2790 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2791 cs-parser.jay: Generic type declaration and type arguments cleanup.
2793 2008-10-05 Marek Safar <marek.safar@gmail.com>
2795 * cs-parser.jay: Allow parsing weird array creation construct.
2797 2008-10-05 Marek Safar <marek.safar@gmail.com>
2799 * cs-parser.jay: Conflicts reduction.
2801 2008-10-04 Marek Safar <marek.safar@gmail.com>
2803 * cs-parser.jay: Conflicts reduction.
2805 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2808 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2809 property. Add a 'count' hint about the use of the shared vector.
2810 Ensure that we don't leak out dirty bits.
2811 (UsageVector.MergeChild): Throw away information about variables
2813 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2815 2008-10-03 Marek Safar <marek.safar@gmail.com>
2817 A fix for bug #431746
2818 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2819 parameters when iterator is created.
2821 2008-10-03 Marek Safar <marek.safar@gmail.com>
2823 A fix for bug #431827
2824 * expression.cs: Fixed right based pointer arithmetic operations
2827 2008-10-03 Marek Safar <marek.safar@gmail.com>
2829 A fix for bug #353779
2830 * assign.cs, expression.cs: Fixed compound assignment conversions.
2832 2008-10-02 Marek Safar <marek.safar@gmail.com>
2834 A fix for bug #375262
2835 * statement.cs: Refactor ArrayForeach to be usable with string
2836 indexer. Optimized single dimentional arrays foreach.
2838 2008-10-02 Marek Safar <marek.safar@gmail.com>
2840 A fix for bug #431255
2841 * anonymous.cs, expression.cs: Removed broken optimization.
2843 2008-10-01 Marek Safar <marek.safar@gmail.com>
2845 * anonymous.cs: Use full type parameters of parent generic
2846 containers. Removed unnecessary AddParentStoreyReference call.
2848 2008-10-01 Marek Safar <marek.safar@gmail.com>
2850 A fix for bug #324702
2851 * class.cs: Use better shorter names for explicit interface member
2854 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2856 2008-10-01 Marek Safar <marek.safar@gmail.com>
2858 * expression.cs: Use new interface to check fixed expression.
2860 2008-10-01 Marek Safar <marek.safar@gmail.com>
2862 A fix for bug #421101
2863 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2864 interface to check for fixed fixed-buffers.
2866 2008-10-01 Marek Safar <marek.safar@gmail.com>
2868 A fix for bug #429264
2869 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2871 * delegate.cs: Removed unnecessary casts.
2873 2008-09-30 Marek Safar <marek.safar@gmail.com>
2875 A fix for bug #352151
2876 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2877 class.cs: Fixed already defined explicit interface members check.
2879 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2881 cs-tokenizer.cs: Fix typo.
2883 2008-09-28 Miguel de Icaza <miguel@novell.com>
2885 * eval.cs (InteractiveBase): The quit command now just sets a
2886 flag, instead of calling Environment.Exit(), it is milder on
2889 CompiledMethod is now in Mono.CSharp, not nested inside
2890 the Evaluator, it was inconvenient to use.
2892 2008-09-27 Miguel de Icaza <miguel@novell.com>
2894 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2895 code to be invoked without having to reparse.
2897 2008-09-27 Miguel de Icaza <miguel@novell.com>
2899 * ecore.cs: The recent changes to FieldExpr broke this as well.
2900 Fixes LINQ queries in the interactive shell.
2902 * Multiple files: indentation fixing for the Mono coding
2903 guidelines for the switch statement.
2905 * eval.cs: Make the Evaluator API thread safe.
2907 2008-09-26 Marek Safar <marek.safar@gmail.com>
2909 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2910 constructor parsing.
2912 2008-09-26 Marek Safar <marek.safar@gmail.com>
2914 A fix for bug #325326
2915 * statement.cs: Check possible mistaken empty statement using
2916 explicit blocks only.
2918 2008-09-25 Miguel de Icaza <miguel@novell.com>
2920 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2921 RootNamespace.ComputeNamespaces to update the internal list of
2922 namespaces, this is no longer done for us.
2924 (InteractiveBase): Use the Evaluator APIs instead of calling into
2927 2008-09-25 Marek Safar <marek.safar@gmail.com>
2929 A fix for bug #429264
2930 * expression.cs: Missing mutator for access to multidimensional
2933 2008-09-25 Marek Safar <marek.safar@gmail.com>
2935 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2938 * driver.cs: Missing input argument check.
2940 2008-09-25 Marek Safar <marek.safar@gmail.com>
2942 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2943 expression.cs, statement.cs, rootcontext.cs, class.cs,
2944 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2947 2008-09-24 Miguel de Icaza <miguel@novell.com>
2949 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2950 fully constructed FieldExpr, fixes the regression introduced in
2953 * ecore.cs, expression.cs: Plug back the eclass initialization as
2954 otherwise it regresses `csharp'.
2956 2008-09-24 Marek Safar <marek.safar@gmail.com>
2958 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2959 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2960 phase to resolve phase. It resolves problems with expression trees
2961 and fixes bugs #323796, #325156.
2963 2008-09-23 Marek Safar <marek.safar@gmail.com>
2965 * codegen.cs: Report better error when symbol writer is missing.
2967 2008-09-23 Marek Safar <marek.safar@gmail.com>
2969 * codegen.cs: Set .NET symbol writer.
2971 * decl.cs: Guard against null generic arguments.
2973 * report.cs: Don't report exactly same additional details.
2975 2008-09-22 Marek Safar <marek.safar@gmail.com>
2977 A fix for bug #324917
2978 * cs-parser.jay: Add missing multidimensional non-expression type
2981 2008-09-22 Marek Safar <marek.safar@gmail.com>
2983 A fix for bug #428191
2984 * anonymous.cs: Create an outer generic fields also for non-storey
2987 2008-09-22 Marek Safar <marek.safar@gmail.com>
2989 A fix for bug #378294
2990 * class.cs: Make fixed size buffers gmcs feature only.
2992 2008-09-22 Marek Safar <marek.safar@gmail.com>
2994 A fix for bug #355622, #324993
2995 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2998 2008-09-19 Marek Safar <marek.safar@gmail.com>
3000 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
3003 2008-09-19 Marek Safar <marek.safar@gmail.com>
3005 A fix for bug #416110
3006 * generic.cs: Struct constraint results in default ctor and
3007 ValueType base type constraint to be set.
3009 2008-09-19 Marek Safar <marek.safar@gmail.com>
3011 A fix for bug #423791
3012 * generic.cs: Fixed params output type type-inference.
3014 2008-09-19 Marek Safar <marek.safar@gmail.com>
3016 * cs-parser.jay, expression.cs: Fixed few expression crashes.
3018 2008-09-19 Marek Safar <marek.safar@gmail.com>
3020 * cs-tokenizer.cs: Don't break on extra partial modifier.
3022 2008-09-19 Marek Safar <marek.safar@gmail.com>
3024 A fix for bug #427592
3025 * generic.cs: Use common parameter resolve method.
3027 2008-09-18 Marek Safar <marek.safar@gmail.com>
3029 A fix for bug #414758
3030 * expression.cs, ecore.cs: Fixed crash when accessing non-static
3033 2008-09-18 Marek Safar <marek.safar@gmail.com>
3035 * driver.cs, namespace.cs: Read types and namespaces after all
3036 requested assemblies are loaded, fixes issues with System.Core
3037 auto-reference, and #419888.
3039 2008-09-18 Marek Safar <marek.safar@gmail.com>
3041 A fix for bug #417705
3042 * cs-parser.jay: Fixed as/is operator expression split.
3044 2008-09-18 Marek Safar <marek.safar@gmail.com>
3046 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
3047 Fixed expression tree representation of empty new expression and
3048 new initializer expression.
3050 2008-09-18 Miguel de Icaza <miguel@novell.com>
3052 * eval.cs: Remove warning, keep reference to driver around.
3054 * Hide fields that do not need to be public.
3056 2008-09-17 Marek Safar <marek.safar@gmail.com>
3058 A fix for bug #426385
3059 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
3060 conversion for array elements.
3062 2008-09-17 Marek Safar <marek.safar@gmail.com>
3064 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
3065 void parsing conflicts.
3067 2008-09-15 Marek Safar <marek.safar@gmail.com>
3069 A fix for bug #425601
3070 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
3071 System.Core only when there is no custom ExtensionAttribute
3074 2008-09-15 Miguel de Icaza <miguel@novell.com>
3076 * namespace.cs: Do not report CS0246 (name
3078 2008-09-12 Marek Safar <marek.safar@gmail.com>
3080 A fix for bug #425669
3081 * generic.cs: Don't cache generic static anonymous method
3084 2008-09-12 Marek Safar <marek.safar@gmail.com>
3086 * generic.cs, class.cs, delegate.cs: Check recursive inherited
3087 conflicting constraints.
3089 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
3091 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
3094 2008-09-12 Marek Safar <marek.safar@gmail.com>
3096 * literal.cs, convert.cs, expression.cs, statement.cs: More null
3097 to null pointer conversion fixes.
3099 2008-09-11 Marek Safar <marek.safar@gmail.com>
3101 * cs-parser.jay, expression.cs: An implicitly typed local variable
3102 declarator cannot use an array initializer.
3104 2008-09-11 Marek Safar <marek.safar@gmail.com>
3106 * cs-parser.jay: Reduced number of printed tokens, add sorting.
3108 2008-09-11 Marek Safar <marek.safar@gmail.com>
3110 * generic.cs (InflatedConstraints): Don't crash when constraints
3113 * cs-parser.jay: const_declarator is a block.
3115 * constant.cs: Check for not allowed NaN conversions.
3117 2008-09-10 Miguel de Icaza <miguel@novell.com>
3119 * driver.cs: Drop --shell argument, the compiler is no longer a
3122 * eval.cs: Move most of the code that deals with evaluation into
3123 this file and document the public API from repl.cs
3125 * repl.cs: Remove from here.
3127 2008-09-10 Marek Safar <marek.safar@gmail.com>
3129 A fix for bug #424684
3130 * generic.cs: Generic class constraints must come first.
3132 2008-09-09 Miguel de Icaza <miguel@novell.com>
3134 * cs-parser.jay: Improve error reporting for syntax errors in
3135 statements and expressions, we now report the expected tokens
3136 instead of reporting the useless "; expected".
3138 Drop the strings from the token declaration, it turns out that
3139 they did not do what I thought they did. Instead they were adding
3140 two sets of tokens to the tables.
3142 2008-09-09 Marek Safar <marek.safar@gmail.com>
3144 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3145 delegate.cs: Share special type check.
3147 2008-09-09 Marek Safar <marek.safar@gmail.com>
3149 A fix for bug #423981
3150 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3152 2008-09-09 Marek Safar <marek.safar@gmail.com>
3154 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3157 2008-09-09 Marek Safar <marek.safar@gmail.com>
3159 A fix for bugs: #324750, #335946
3160 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3161 lookup rule to determine ?-based tokens.
3163 2008-09-08 Miguel de Icaza <miguel@novell.com>
3165 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3166 expressions (like event adding or removing) end up here, so we
3167 need to treat those as statements.
3169 Add LoadAssembly method.
3171 2008-09-04 Miguel de Icaza <miguel@novell.com>
3173 * repl.cs: Add Time method.
3175 2008-09-05 Marek Safar <marek.safar@gmail.com>
3177 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3179 2008-09-05 Miguel de Icaza <miguel@novell.com>
3181 * repl.cs: Add workaround for old compilers.
3183 2008-09-04 Jb Evain <jbevain@novell.com>
3185 * repl.cs (PrettyPrint): pretty print everything that
3186 implements IDictionary, as well as IEnumerables. Also,
3187 add a quit helper property.
3189 2008-09-04 Marek Safar <marek.safar@gmail.com>
3191 * constant.cs: Better error reporting for decimal literals.
3193 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3196 2008-09-04 Marek Safar <marek.safar@gmail.com>
3197 Miguel de Icaza <miguel@novell.com>
3199 A fix for bug #422951
3200 * assign.cs (Assign.DoResolve): Perform the type conversions
3201 checks before we attempt to initialize `New' initializers.
3203 2008-09-04 Marek Safar <marek.safar@gmail.com>
3205 A fix for bug #422853
3206 * delegate.cs (DelegateCreation): Add special handling for
3207 EmptyExpression.Null instance expression which is just another
3208 hack for undecided member instance exression.
3210 2008-09-04 Marek Safar <marek.safar@gmail.com>
3212 * expression.cs, ecore.cs: Emit full expression tree for reduced
3215 2008-09-04 Marek Safar <marek.safar@gmail.com>
3217 * expression.cs (This): Guard against multi-resolving.
3219 * ecore.cs, statement.cs (Throw): Simplified.
3221 * flowanalysis.cs: Also verify event fields.
3223 2008-09-04 Miguel de Icaza <miguel@novell.com>
3225 * assign.cs (Assign.DoResolve): Perform the type conversions
3226 checks before we attempt to initialize `New' initializers.
3228 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3230 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3233 * repl.cs: Update help.
3235 2008-09-03 Miguel de Icaza <miguel@novell.com>
3237 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3238 handling of the default config handling, including the special
3239 treatment of System.Core assembly.
3241 Fixes the REPL processing for LINQ.
3243 2008-09-03 Marek Safar <marek.safar@gmail.com>
3245 A fix for bug #422507
3246 * expression.cs (UnboxCast): Add missing child expression mutator.
3248 2008-09-03 Marek Safar <marek.safar@gmail.com>
3250 * driver.cs: Don't self reference System.Core assembly.
3252 2008-09-03 Marek Safar <marek.safar@gmail.com>
3254 A fix for bug #422507
3255 * expression.cs (StringConcat): Add missing type mutator.
3257 2008-09-03 Marek Safar <marek.safar@gmail.com>
3259 * generic.cs (TypeInferenceContext): Follow equality rule for
3260 constructed type lower bound type inference.
3262 2008-09-02 Miguel de Icaza <miguel@novell.com>
3264 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3265 <dblank@cs.brynmawr.edu> which updates the cursor position on
3268 2008-09-02 Marek Safar <marek.safar@gmail.com>
3270 A fix for bug #367145
3271 * driver.cs: Fixed import of extension methods when using -noconfig
3274 2008-09-02 Marek Safar <marek.safar@gmail.com>
3276 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3277 version from non-generic implementation instead.
3279 2008-09-01 Marek Safar <marek.safar@gmail.com>
3281 A fix for bug #418908
3282 * class.cs: Use AddScopeStatement for field initializers.
3284 2008-09-01 Marek Safar <marek.safar@gmail.com>
3286 A fix for bug #415385
3287 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3289 2008-09-01 Marek Safar <marek.safar@gmail.com>
3291 A fix for bug #421736
3292 * iterators.cs: Don't crash on unreachable iterators.
3294 2008-09-01 Marek Safar <marek.safar@gmail.com>
3296 A fix for bug #421628
3297 * parameter.cs, attribute.cs: Clone also parameter attributes.
3299 2008-08-30 Miguel de Icaza <miguel@novell.com>
3301 * namespace.cs (LookupType): In EvalMode, try to replace
3302 the TypeBuilder from our cache with a Type as Reflection.Emit does
3303 not like to mix code from older assemblies emitted and new
3306 This sounds like a serious Mono bug that prevents multiple
3307 assemblies to be generated and consumed at the same time.
3309 * cs-parser.jay (push_current_class): Do not make interactive
3310 classes internal or private, make them public as we currently
3311 generate each new class in a new assembly.
3313 2008-08-29 Miguel de Icaza <miguel@novell.com>
3315 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3316 remove types that are entered into the global namespace during
3317 parsing so that we can remove them on failure.
3319 * cs-parser.jay: Parsing: we now keep track of types that are
3320 entered into global variables and queue those in case the parsing
3323 This happens in a few situations: during partial-input, we invoke
3324 the parser repeatedly for example with the string "class X", this
3325 would cause X to be registed, and we need to remove this
3326 registration so that another parse attempt later with say "class X {"
3327 would actually work.
3329 Additionally, if there is an error in the resolution phase, for
3330 example: "class X : NonExistant {}" th
3332 * cs-parser.jay: Be more precise with the errors being raised,
3333 instead of flagging all exceptions during parsing to be attributed
3334 to the parsing process, distinguish those from errors happening in
3335 the actions and hint that using -v would produce the actual
3338 * repl.cs: Do not load all compiler references on each reset,
3339 doing the partial reset takes care of this.
3341 2008-08-28 Miguel de Icaza <miguel@novell.com>
3343 * repl.cs: Add support for loading all the files from
3344 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3347 Introduce a micro-parser that is able to deambiguate on its input
3348 whether we are dealing with a compilation unit (namespace, class,
3349 interface, struct, delegate) declaration or a statement. This
3350 allows both declarations and statements to be entered.
3352 Set history size by default to 300 lines.
3354 Instead of distinguishing based on the parser.InteractiveResult,
3355 have only two cases: statements were parsed, or a compilation unit
3356 was. Always pull the Using statement additions from the
3357 compilation unit parse.
3359 * cs-tokenizer.cs: Rename tokens to better describe their intent
3360 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3362 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3363 EvalMode is used to trigger the lookup of global variables while
3364 StatementMode is used turn variable declarations into static
3367 * getline.cs: Allow history size to be set.
3369 2008-08-29 Marek Safar <marek.safar@gmail.com>
3371 A fix for bug #360755
3372 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3374 2008-08-29 Marek Safar <marek.safar@gmail.com>
3376 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3378 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3379 member name, it is too confusing
3381 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3383 * rootcontext.cs: Finally default to warning level 4.
3385 2008-08-28 Marek Safar <marek.safar@gmail.com>
3387 * class.cs (CheckBase): Ignore overloaded operators.
3389 2008-08-28 Marek Safar <marek.safar@gmail.com>
3391 A fix for bug #420830
3392 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3394 2008-08-28 Marek Safar <marek.safar@gmail.com>
3396 A fix for bug #420832
3397 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3399 2008-08-28 Marek Safar <marek.safar@gmail.com>
3401 A fix for bug #420386
3402 * nullables.cs: Fixed logic of nullable user comparison operators involving
3405 2008-08-28 Marek Safar <marek.safar@gmail.com>
3407 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3409 2008-08-27 Miguel de Icaza <miguel@novell.com>
3411 * repl.cs: Add support for aborting the running code with C-c.
3413 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3415 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3417 2008-08-27 Miguel de Icaza <miguel@novell.com>
3419 * cs-parser.jay (interactive_statement_list): A new set of rules
3420 for hosting statements that uses the "interactive_" prefix.
3422 * repl.cs: Add support for parsing `using' as a statement or as a
3423 directive. Deambiguating before passing this to the parser.
3425 We need to distinguish statement_expressions that occur at the
3426 toplevel vs those that occur embedded into expressions.
3428 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3429 that fixes the cursor key handling, and a history bug.
3431 2008-08-26 Miguel de Icaza <miguel@novell.com>
3433 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3434 limitations in Console, instead the 2.0 bootstrap libraries now
3435 include the Console bits.
3437 Also, remove the use of Nullables from getline.cs
3441 Interactive support for the C# compiler. Use gmcs --shell to
3442 enter a read-eval-print loop shell.
3444 Docs: http://www.mono-project.com/CsharpRepl
3446 * sources: include repl.cs here and getline.cs for gmcs.exe,
3447 everything else is getline.cs impaired.
3449 * Makefile: when bootstrapping pass a special flag
3450 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3451 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3452 This distinguishes those two cases.
3454 * repl.cs: Support for a read-eval-print loop. Will be soon
3455 refactored into eval support and then REPL on top of it.
3457 * ecore.cs: If a simplename lookup fails, before erroring out,
3458 if we are in EvalMode to resolve the name to a declaration in the
3461 This means that variable declarations that happened in previous
3462 classes (as repl puts every statement in a separate class) are
3463 made visible in this way.
3465 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3466 triggered an error due to the end of file being reached. This is
3467 used to do multi-line input, and notify the caller that the user
3468 needs to provide more text before a successful parse.
3470 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3471 to drive the evaluation with a custom wrapper.
3473 * driver.cs: Add support for --shell, and refactor some code to be
3476 * namespace.cs: Add support for serializing the contents of the
3477 namespaces and reloading them.
3479 * getline.cs: A managed implementation of ReadLine under
3480 X11/Apache2 license terms. Easy to embed in other applications as
3483 * namespace.cs: Add some functions to save and restore the
3486 * rootcontext.cs: New public field.
3488 * cs-tokenizer.cs: Add support for one of the possible characters
3489 we introduce into the token stream.
3491 This patch does not affect the regular tokenization process, the
3492 only performance hit would happen if there is an invalid character
3493 on the input string.
3495 * support.cs: Move isatty helper routine here.
3497 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3498 code generator for in-memory assemblies.
3500 2008-08-26 Marek Safar <marek.safar@gmail.com>
3502 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3503 parameter cannot be always used as a type.
3505 2008-08-21 Marek Safar <marek.safar@gmail.com>
3507 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3509 2008-08-21 Marek Safar <marek.safar@gmail.com>
3511 * convert.cs: Implement explicit array to IList<T> conversion.
3513 2008-08-20 Marek Safar <marek.safar@gmail.com>
3515 A fix for bug #362740
3516 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3518 2008-08-20 Marek Safar <marek.safar@gmail.com>
3520 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3521 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3522 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3523 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3524 handling to use just one type of infrastructure and deal with generics
3527 2008-07-23 Martin Baulig <martin@ximian.com>
3529 *** Merged this from trunk revision 108527 ***
3532 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3533 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3536 2008-08-15 Marek Safar <marek.safar@gmail.com>
3538 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3541 2008-08-15 Marek Safar <marek.safar@gmail.com>
3543 * delegate.cs: Fixed compiler crash when creating delegate using partial
3546 * typemanager.cs: MulticastDelegate is not a delegate.
3548 2008-08-14 Marek Safar <marek.safar@gmail.com>
3550 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3553 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3555 * cs-parser.jay (type): Allow 'var' in mcs too.
3556 (local_variable_type): Likewise.
3558 2008-08-14 Marek Safar <marek.safar@gmail.com>
3560 * driver.cs: Removed broken -noconfig variants.
3562 2008-08-14 Marek Safar <marek.safar@gmail.com>
3564 A fix for bug #417078
3565 * expression.cs: Emit correctly left side pointer operators.
3567 2008-08-13 Marek Safar <marek.safar@gmail.com>
3569 * generic.cs, lambda.cs: Inflate method generic arguments only.
3571 2008-08-12 Marek Safar <marek.safar@gmail.com>
3573 * class.cs: Fixed struct layout check regression.
3575 2008-08-12 Marek Safar <marek.safar@gmail.com>
3577 * cs-parser.jay, enum.cs: Simplified enum parsing.
3579 * decl.cs: Check all type parameters conflicts.
3581 * expression.cs, statement.cs, attribute.cs: More expression checks.
3583 2008-08-11 Marek Safar <marek.safar@gmail.com>
3585 * generic.cs: Add type inference types restriction.
3587 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3588 anonymous.cs, expression.cs: Allocate less accessor parameters.
3590 2008-08-08 Marek Safar <marek.safar@gmail.com>
3592 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3595 2008-08-08 Marek Safar <marek.safar@gmail.com>
3597 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3599 2008-08-07 Marek Safar <marek.safar@gmail.com>
3601 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3602 Also fixes #362146 and #381592.
3604 2008-08-07 Marek Safar <marek.safar@gmail.com>
3606 * ecore.cs: Reduced constant cannot be used as an attribute value.
3608 * cs-parser.jay: Base expression has to be a type.
3610 * expression.cs (Conditional): Uses ReducedExpression.
3612 2008-08-06 Marek Safar <marek.safar@gmail.com>
3614 A fix for bug #376826
3615 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3616 address of hoisted local variable or parameter cannot be taken.
3618 2008-08-05 Marek Safar <marek.safar@gmail.com>
3620 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3621 anonymous method inside checked/unchecked expression.
3623 2008-08-05 Marek Safar <marek.safar@gmail.com>
3625 * typemanager.cs (IsEqual): Guard against null.
3627 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3628 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3629 routine. Fixed few misleading conversion errors.
3631 2008-08-04 Marek Safar <marek.safar@gmail.com>
3633 * class.cs: Consider generics when checking cycles in struct layout.
3635 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3637 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3639 2008-08-04 Marek Safar <marek.safar@gmail.com>
3641 A fix for bug #414165
3642 * anonymous.cs: Use same anonymous implementation method for all anonymous
3645 2008-08-04 Marek Safar <marek.safar@gmail.com>
3647 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3650 2008-08-04 Marek Safar <marek.safar@gmail.com>
3652 * cs-parser.jay: Typeof argument has to be a type expression.
3654 * namespace.cs: Check alias and namespace definitions collisions.
3656 * class.cs, pending.cs: Moved explicit interface accessor implementation
3659 * delegate.cs, expression.cs: Verify special name invocations.
3661 2008-08-01 Marek Safar <marek.safar@gmail.com>
3663 * cs-parser.jay: Don't choke on empty generic type arguments.
3665 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3667 * expression.cs, ecore.cs: Minor expressions bugs.
3669 2008-08-01 Marek Safar <marek.safar@gmail.com>
3671 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3672 and added more error handling.
3674 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3676 * modifiers.cs, enum.cs: Fixed.
3678 2008-07-31 Jb Evain <jbevain@novell.com>
3680 * driver.cs: remove -pkg ability of smcs.
3682 2008-07-30 Marek Safar <marek.safar@gmail.com>
3684 * statement.cs (Switch): Correctly set empty default target for single
3687 2008-07-30 Marek Safar <marek.safar@gmail.com>
3689 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3690 string switch statement implementation to use string dictionary which
3691 significantly (2-8x) improves performance of generated code.
3693 2008-07-29 Marek Safar <marek.safar@gmail.com>
3695 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3696 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3698 2008-07-29 Marek Safar <marek.safar@gmail.com>
3700 A fix for bug #412595
3701 * typemanager.cs, convert.cs, expression.cs: Some types are never
3702 convertible to each other.
3704 2008-07-29 Marek Safar <marek.safar@gmail.com>
3706 * nullable.cs (CreateNullConstant): An error messages update.
3708 2008-07-29 Marek Safar <marek.safar@gmail.com>
3710 A fix for bug #412595
3711 * cfold.cs: Don't cast undefined bool constant.
3713 2008-07-29 Martin Baulig <martin@ximian.com>
3716 (SymbolWriter.Reset): New public static method.
3719 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3721 2008-07-28 Marek Safar <marek.safar@gmail.com>
3723 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3725 * expression.cs (ElementAccess): Exact size allocation.
3727 2008-07-26 Marek Safar <marek.safar@gmail.com>
3729 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3731 2008-07-25 Marek Safar <marek.safar@gmail.com>
3733 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3735 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3738 2008-07-25 Marek Safar <marek.safar@gmail.com>
3740 A fix for bug #412217
3741 * assign.cs: Mutate also assignment type.
3743 2008-07-25 Marek Safar <marek.safar@gmail.com>
3745 A fix for bug #323644
3746 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3749 2008-07-25 Marek Safar <marek.safar@gmail.com>
3751 A fix for bug #412134
3752 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3753 non-enumerable operands when overloading equality or bitwise operators.
3755 2008-07-25 Marek Safar <marek.safar@gmail.com>
3757 * anonymous.cs: Cache closed generic anonymous method delegates.
3759 2008-07-24 Marek Safar <marek.safar@gmail.com>
3761 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3762 anonymous.cs, statement.cs: Always emit anonymous method as static method
3763 when is instance free. Use nesting for nested anynomous methods blocks.
3765 2008-07-23 Marek Safar <marek.safar@gmail.com>
3767 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3770 2008-07-23 Marek Safar <marek.safar@gmail.com>
3772 * expression.cs: Removed MakeSimpleCall.
3774 2008-07-23 Marek Safar <marek.safar@gmail.com>
3776 A fix for bug #323012
3777 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3778 Base method implementing interface has to be public.
3780 2008-07-23 Marek Safar <marek.safar@gmail.com>
3782 * cs-parser.jay: Don't break on missing argument.
3784 2008-07-22 Marek Safar <marek.safar@gmail.com>
3786 A fix for bug #320993
3787 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3788 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3790 2008-07-22 Marek Safar <marek.safar@gmail.com>
3792 A fix for bug #320748
3793 * convert.cs: Implicit user operators cannot convert to interfaces
3795 2008-07-22 Marek Safar <marek.safar@gmail.com>
3797 A fix for bug #312686
3798 * driver.cs: Ignore empty assembly references.
3800 2008-07-22 Marek Safar <marek.safar@gmail.com>
3802 A fix for bug #387040
3803 * ecore.cs: Skip constrains check for an explicit implementation.
3805 2008-07-21 Marek Safar <marek.safar@gmail.com>
3807 A fix for bug #409045
3808 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3809 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3810 identifiers are file specific unless passed as input arguments.
3812 2008-07-21 Marek Safar <marek.safar@gmail.com>
3814 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3815 to emit UnmanagedMarshal data under 2.0 profile.
3817 2008-07-21 Marek Safar <marek.safar@gmail.com>
3819 A fix for bug #410369
3820 * parameter.cs: Clone correctly ParamsParameter.
3822 2008-07-21 Marek Safar <marek.safar@gmail.com>
3824 * expression.cs (Argument): Always report type for type based expressions
3827 2008-07-18 Marek Safar <marek.safar@gmail.com>
3829 A fix for bug #410666
3830 * anonymous.cs: Correctly initialize generic storey reference.
3832 2008-07-18 Marek Safar <marek.safar@gmail.com>
3834 * convert.cs: Don't box same type arguments.
3836 2008-07-18 Marek Safar <marek.safar@gmail.com>
3838 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3839 Finished missing generic type mutators.
3841 2008-07-18 Marek Safar <marek.safar@gmail.com>
3843 * iterators.cs, statement.cs: Finished statements CloneTo.
3845 2008-07-18 Marek Safar <marek.safar@gmail.com>
3847 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3849 * expression.cs: Emit optimized default value expressions in expression tree
3852 2008-07-18 Marek Safar <marek.safar@gmail.com>
3854 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3856 2008-07-17 Marek Safar <marek.safar@gmail.com>
3858 A fix for bug #367536
3859 * cs-parser.jay: Check static constructor of generic types for an access
3862 2008-07-17 Marek Safar <marek.safar@gmail.com>
3864 A fix for bug #353800
3865 * lambda.cs: Emit ret for contextual statements.
3867 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3868 up emitting redundant ret for all anonymous methods with return.
3870 2008-07-17 Marek Safar <marek.safar@gmail.com>
3872 A fix for bug #365188
3873 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3874 create anonymous method storey in unreachable block.
3876 2008-07-17 Marek Safar <marek.safar@gmail.com>
3878 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3879 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3880 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3881 statement.cs: Fixed relevant defects found by Gendarme.
3883 2008-07-17 Marek Safar <marek.safar@gmail.com>
3885 A fix for bug #325291
3886 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3887 statement.cs: Replaced IAnonymousHost with top level block flag.
3889 2008-07-17 Marek Safar <marek.safar@gmail.com>
3891 * cs-parser.jay: Clean up unused open_parens.
3893 2008-07-17 Marek Safar <marek.safar@gmail.com>
3895 * ecore.cs: Custom error message for a range variable assignment.
3897 2008-07-16 Marek Safar <marek.safar@gmail.com>
3899 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3902 2008-07-16 Marek Safar <marek.safar@gmail.com>
3904 * literal.cs: Null literal is of object type.
3906 2008-07-16 Marek Safar <marek.safar@gmail.com>
3908 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3909 expression of nullable equality comparison.
3911 2008-07-15 Marek Safar <marek.safar@gmail.com>
3913 * expression.cs(PointerArithmetic): Removed redundant assignment.
3915 2008-07-15 Marek Safar <marek.safar@gmail.com>
3917 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3919 2008-07-14 Marek Safar <marek.safar@gmail.com>
3921 A fix for bug #408361
3922 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3923 they are replaced by GetMethod.
3925 2008-07-14 Marek Safar <marek.safar@gmail.com>
3927 A fix for bug #408721 by jeremie.laval@gmail.com
3928 * expression.cs (Indirection): Implemented CloneTo.
3930 2008-07-14 Marek Safar <marek.safar@gmail.com>
3932 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3935 2008-07-14 Marek Safar <marek.safar@gmail.com>
3937 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3939 2008-07-11 Marek Safar <marek.safar@gmail.com>
3941 * linq.cs: Reset tranparent parameter counter in probing mode.
3943 2008-07-11 Marek Safar <marek.safar@gmail.com>
3945 * anonymous.cs: Mutate anonymous method type.
3947 2008-07-11 Marek Safar <marek.safar@gmail.com>
3949 * ecore.cs, anonymous.cs: Mutate field expressions.
3951 2008-07-10 Marek Safar <marek.safar@gmail.com>
3953 A fix for bug #369670
3954 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3956 2008-07-10 Marek Safar <marek.safar@gmail.com>
3958 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3960 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3963 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3964 only one '>', and finds a '>>', abort the generic lookahead.
3966 2008-07-10 Marek Safar <marek.safar@gmail.com>
3968 A fix for bug #319902
3969 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3971 2008-07-10 Marek Safar <marek.safar@gmail.com>
3973 A fix for bug #406371
3974 * statement.cs: Moved EmitSymbolInfo to Block.
3976 2008-07-09 Marek Safar <marek.safar@gmail.com>
3978 * ecore.cs: Report better error for extension method overload failures.
3980 2008-07-09 Marek Safar <marek.safar@gmail.com>
3982 * expression.cs (Is): No need to box reference values.
3984 2008-07-09 Marek Safar <marek.safar@gmail.com>
3986 * class.cs: Use event resolve context when initializing CreateEmitContext.
3988 2008-07-09 Marek Safar <marek.safar@gmail.com>
3990 A fix for bug #394436
3991 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3992 method used inside expression trees. Added more LINQ to expression tree
3995 2008-07-08 Marek Safar <marek.safar@gmail.com>
3997 A fix for bug #378189, #370577
3998 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
4001 2008-07-08 Marek Safar <marek.safar@gmail.com>
4003 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
4006 2008-07-08 Marek Safar <marek.safar@gmail.com>
4008 A fix for bug #406702
4009 * anonymous.cs: Always park anonymous method in the nearest parent storey.
4011 2008-07-07 Marek Safar <marek.safar@gmail.com>
4013 A fix for bug #406648
4014 * cs-parser.jay: Report nullable use in mcs for some cases.
4016 2008-07-07 Marek Safar <marek.safar@gmail.com>
4018 * ecore.cs: Improved argument mismatch error messages.
4020 2008-07-07 Marek Safar <marek.safar@gmail.com>
4022 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
4024 2008-07-07 Marek Safar <marek.safar@gmail.com>
4026 * expression.cs (TypeOf): Mutate type argument.
4028 2008-07-04 Marek Safar <marek.safar@gmail.com>
4030 * class.cs: Report missing partial modifier for correct type.
4032 2008-07-04 Marek Safar <marek.safar@gmail.com>
4034 * ecore.cs, expression.cs (VariableReference): Variable property is
4037 2008-07-04 Marek Safar <marek.safar@gmail.com>
4039 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
4041 2008-07-04 Marek Safar <marek.safar@gmail.com>
4043 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
4046 2008-07-04 Marek Safar <marek.safar@gmail.com>
4048 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
4049 anonymous method storey to an instance method when only "this" is hoisted.
4051 2008-07-03 Marek Safar <marek.safar@gmail.com>
4053 A fix for bug #321615
4054 * expression.cs: Pointer comparisons use unsigned operator.
4056 2008-07-03 Marek Safar <marek.safar@gmail.com>
4058 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
4060 2008-07-02 Marek Safar <marek.safar@gmail.com>
4062 A fix for bug #404905
4063 * class.cs: Always initialize local unsafe variables.
4065 2008-06-30 Marek Safar <marek.safar@gmail.com>
4067 A fix for bug #396987
4068 * expression.cs (NewInitialize): Clear local temporary variable for next run
4070 2008-06-27 Marek Safar <marek.safar@gmail.com>
4072 A fix for bug #401020
4073 * ecore.cs: Both types and modifiers have to match for ref and out arguments
4075 2008-06-27 Marek Safar <marek.safar@gmail.com>
4077 A fix for bug #398319
4078 * cs-parser.jay: Implemented undocumented base access expression inside
4081 2008-06-26 Marek Safar <marek.safar@gmail.com>
4083 A fix for bug #404227
4084 * cs-parser.jay: Parse namespace declaration using qualified identifier.
4086 2008-06-26 Marek Safar <marek.safar@gmail.com>
4088 A fix for bug #404227
4089 * convert.cs: Fixed explicit array to interface cast.
4091 2008-06-26 Marek Safar <marek.safar@gmail.com>
4093 A fix for bug #403894
4094 * delegate.cs: Mutate DelegateInvocation type.
4096 2008-06-26 Marek Safar <marek.safar@gmail.com>
4098 A fix for bug #379348
4099 * delegate.cs: Box a load of generic parameters.
4101 2008-06-26 Marek Safar <marek.safar@gmail.com>
4103 * expression.cs: Add an array creation arguments mutate.
4105 2008-06-26 Marek Safar <marek.safar@gmail.com>
4107 A fix for bug #386068
4108 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
4111 2008-06-25 Marek Safar <marek.safar@gmail.com>
4113 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4116 2008-06-25 Marek Safar <marek.safar@gmail.com>
4118 A fix for bug #403518
4119 * delegate.cs: Type correctly anonymous method new invocation.
4121 2008-06-24 Marek Safar <marek.safar@gmail.com>
4123 A fix for bug #394826
4124 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4127 2008-06-24 Marek Safar <marek.safar@gmail.com>
4129 A fix for bug #394826
4130 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4133 2008-06-24 Marek Safar <marek.safar@gmail.com>
4135 * class.cs: Clone indexer parameters for localized capturing.
4137 2008-06-24 Marek Safar <marek.safar@gmail.com>
4139 A fix for bug #402379
4140 * expression.cs: Don't crash when an object initializer resolve fails.
4142 2008-06-24 Marek Safar <marek.safar@gmail.com>
4144 A fix for bug #402888
4145 * expression.cs: Mutate conditional expression.
4147 2008-06-24 Marek Safar <marek.safar@gmail.com>
4149 A fix for bug #401012
4150 * class.cs: Keep StructLayout in shared container.
4152 2008-06-24 Marek Safar <marek.safar@gmail.com>
4154 A fix for bug #400438
4155 * decl.cs, class.cs: Only properties can be automatically implemented.
4157 2008-06-24 Marek Safar <marek.safar@gmail.com>
4159 * statement.cs (ChangeToIterator): Copy also labels.
4161 2008-06-23 Marek Safar <marek.safar@gmail.com>
4163 * ecore.cs: Pass type argument details to parent extension method.
4165 2008-06-23 Marek Safar <marek.safar@gmail.com>
4167 A fix for bug #375966
4168 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4170 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4172 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4174 2008-06-22 Marek Safar <marek.safar@gmail.com>
4176 A fix for bug #394347
4177 * anonymous.cs: Cache compatible delegates as compatibility check produces
4178 a new method every time.
4180 2008-06-20 Marek Safar <marek.safar@gmail.com>
4182 * anonymous.cs: Propagate storey reference for single references.
4184 2008-06-20 Marek Safar <marek.safar@gmail.com>
4186 A fix for bug #387615
4187 * assign.cs, expression.cs: Correctly clone compound assignment.
4189 2008-06-19 Marek Safar <marek.safar@gmail.com>
4191 A fix for bug #359611, #359604
4192 * anonymous.cs: Mutate all types of hoisted parameters.
4194 2008-06-19 Marek Safar <marek.safar@gmail.com>
4196 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4197 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4198 expression.cs, codegen.cs, statement.cs
4200 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4201 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4203 ** Anonymous methods, lambda expressions rewrite **
4205 Anonymous expressions are now resolved when an explicit block is resolved
4206 and they don't require any registration procedure anymore. Further,
4207 anonymous methods are defined when explicit block is emitted which allows
4208 better control of whole process and opens possibilities for more
4209 optimizations as well as alternative to reverse whole process.
4211 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4212 process consistent and to correctly emit hoisted generic methods when they
4213 have at least 1 hoisted variable.
4215 2008-06-17 Martin Baulig <martin@ximian.com>
4217 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4219 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4220 virtual property; check it in Emit().
4221 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4223 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4225 (Indexer.Define): Likewise.
4227 2008-06-17 Marek Safar <marek.safar@gmail.com>
4229 * convert.cs: Don't use IsInterface on type arguments.
4231 * delegate.cs: DelegateInvocation uses MethodInfo.
4233 * parameter.cs: Removed IsTypeParameter.
4235 * generic-mcs.cs: More missing stuff.
4237 2008-06-16 Martin Baulig <martin@ximian.com>
4240 (Modifiers.DEBUGGER_HIDDEN): New public const.
4243 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4246 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4247 (AbstractPropertyEventMethod): Likewise.
4248 (Constructor.Emit): Likewise.
4249 (SourceMethod.SetCompilerGenerated): Removed.
4251 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4255 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4256 if we're an `IteratorHost'.
4257 (AnonymousMethodMethod..ctor): Don't set
4258 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4261 2008-06-16 Marek Safar <marek.safar@gmail.com>
4263 * statement.cs: Clean-up foreach statements.
4265 2008-06-12 Marek Safar <marek.safar@gmail.com>
4267 * class.cs: Stop using public method which should not exist
4268 (MethodBuilder.SetGenericMethodSignature).
4270 2008-06-11 Martin Baulig <martin@ximian.com>
4273 (Location.LookupFile): Add `CompilationUnit' argument; when given
4274 a relative file name, make it relative to the directory the .cs
4275 file is located in instead of using the current directory.
4277 2008-06-11 Martin Baulig <martin@ximian.com>
4280 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4281 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4282 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4283 (SourceMethod.SetCompilerGenerated): Likewise.
4285 2008-06-11 Marek Safar <marek.safar@gmail.com>
4287 * codegen.cs, driver: Only write symbol file when it's asked for.
4289 2008-06-11 Marek Safar <marek.safar@gmail.com>
4291 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4293 2008-06-10 Martin Baulig <martin@ximian.com>
4295 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4297 2008-06-09 Marek Safar <marek.safar@gmail.com>
4299 A fix for bug #316290
4300 * expression.cs: Include decimal operators in predefined table.
4302 * parameters.cs: More readonlyness.
4304 2008-06-09 Marek Safar <marek.safar@gmail.com>
4306 A fix for bug #397213
4307 * cs-parser.jay: One more missing current_local_parameters reset.
4309 2008-06-09 Marek Safar <marek.safar@gmail.com>
4311 A fix for bug #396633
4312 * class.cs: Host backing field in partial container.
4314 2008-06-09 Marek Safar <marek.safar@gmail.com>
4316 A fix for bug #397068
4317 * expression.cs: Check both operand types when predefined operator is used.
4319 2008-06-05 Martin Baulig <martin@ximian.com>
4321 Merged the `debugger-kahalo' branch.
4324 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4325 we're an iterator method.
4326 (SourceMethod): Reflect latest symbol writer changes;
4327 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4328 now `start_row' and `end_row'.
4329 (Constructor.Emit): Fix the logic whether to emit symbol information.
4331 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4335 (CompilationUnit): New public class; derives from `SourceFile'.
4336 (SourceFileEntry.DefineSymbolInfo): New public method.
4337 (SourceFileEntry.SetChecksum): New public method.
4338 (Location): Encode hidden line numbers by using `column == 255';
4339 the .ctor now accepts `column == -1' to mark a hidden line number.
4340 (Location.Hidden): New public property.
4341 (Location.CheckPoint): Add `CompilationUnit'.
4342 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4343 (Location.Push): Add `CompilationUnit compile_unit' argument.
4344 (Location.CompilationUnit): New public property.
4347 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4349 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4351 * driver.cs: `SourceFile' -> `CompilationUnit'.
4353 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4355 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4357 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4361 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4362 new symbol writer API to also pass the file.
4364 2008-06-05 Marek Safar <marek.safar@gmail.com>
4366 * statement.cs: Emit catch variable assignment using variable expression.
4368 2008-06-05 Marek Safar <marek.safar@gmail.com>
4370 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4371 with other variable types.
4373 2008-06-04 Marek Safar <marek.safar@gmail.com>
4375 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4376 GetLength method emit, it breaks resolve rules.
4378 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4379 Marek Safar <marek.safar@gmail.com>
4381 A fix for bug #395542
4382 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4385 2008-06-02 Marek Safar <marek.safar@gmail.com>
4387 A fix for bug #395287
4388 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4390 2008-05-31 Marek Safar <marek.safar@gmail.com>
4392 A fix for bug #395845
4393 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4394 non-nullable parameter type.
4396 2008-05-31 Marek Safar <marek.safar@gmail.com>
4398 * class.cs: Handle contructor initializer as a statement in top-level block.
4400 2008-05-30 Marek Safar <marek.safar@gmail.com>
4402 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4403 security attributes.
4405 2008-05-24 Marek Safar <marek.safar@gmail.com>
4407 * ecore.cs, expression.cs: Small IVariable refactoring.
4409 2008-05-22 Marek Safar <marek.safar@gmail.com>
4411 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4413 2008-05-21 Marek Safar <marek.safar@gmail.com>
4415 * cs-parser.jay: Removed redundant catch type check.
4417 2008-05-21 Marek Safar <marek.safar@gmail.com>
4419 A fix for bug #390372
4420 * nullable.cs: Set correct return type.
4422 2008-05-21 Marek Safar <marek.safar@gmail.com>
4424 A fix for bug #391062
4425 * typemanager.cs: Fixed crash when comparing null types.
4427 2008-05-21 Marek Safar <marek.safar@gmail.com>
4429 A fix for bug #391871
4430 * cs-parser.jay: Better error handling for invalid catch type.
4432 2008-05-20 Marek Safar <marek.safar@gmail.com>
4434 A fix for bug #392155
4435 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4437 2008-05-15 Marek Safar <marek.safar@gmail.com>
4439 A fix for bug #390666
4440 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4443 2008-05-15 Marek Safar <marek.safar@gmail.com>
4445 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4448 2008-05-13 Marek Safar <marek.safar@gmail.com>
4450 A fix for bug #389625
4451 * delegate.cs, generic.cs: Some progress on method group return type
4454 2008-05-13 Marek Safar <marek.safar@gmail.com>
4456 A fix for bug #378419
4457 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4459 2008-05-12 Marek Safar <marek.safar@gmail.com>
4461 * class.cs (Constructor): Added IsCompilerGenerated.
4463 2008-05-12 Marek Safar <marek.safar@gmail.com>
4465 * expression.cs: Enum binary operators can accept non-enum operand only when
4466 is implicitly convertible to underlying type.
4468 2008-05-12 Marek Safar <marek.safar@gmail.com>
4470 A fix for bug #389272
4471 * support.cs: Workaround System.InvalidOperationException for enums.
4473 2008-05-12 Marek Safar <marek.safar@gmail.com>
4475 A fix for bug #389073
4476 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4478 2008-05-10 Marek Safar <marek.safar@gmail.com>
4480 * driver.cs: Split Parse.
4482 * location.cs (LookupFile): Uses string.Empty.
4484 2008-05-07 Marek Safar <marek.safar@gmail.com>
4486 * expression.cs, parameter.cs: Small ParameterReference clean up.
4488 2008-05-07 Marek Safar <marek.safar@gmail.com>
4490 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4491 hack. Fixes #387502.
4493 2008-05-06 Martin Baulig <martin@ximian.com>
4495 * class.cs (Constructor.Emit): Fix the logic whether to emit
4498 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4501 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4502 InvalidOperationException when the iterator is before the start or
4505 2008-05-06 Marek Safar <marek.safar@gmail.com>
4507 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4508 when left is nullable type.
4510 2008-05-06 Marek Safar <marek.safar@gmail.com>
4512 A fix for bug #386628
4513 * expression.cs (LocalVariableReference): Continue in resolving when
4514 variable is not assigned.
4516 2008-05-05 Marek Safar <marek.safar@gmail.com>
4518 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4519 nullable operations.
4521 2008-05-04 Marek Safar <marek.safar@gmail.com>
4523 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4524 it saves many redundant temporary variables for nullable operations.
4526 2008-05-03 Marek Safar <marek.safar@gmail.com>
4528 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4530 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4533 * nullable.cs: Constant coalescing operator optimizations.
4535 2008-05-03 Marek Safar <marek.safar@gmail.com>
4537 * constant.cs: Use unsigned conversion for values which are unsigned only.
4539 2008-05-03 Marek Safar <marek.safar@gmail.com>
4541 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4542 coalescing operator as it should be.
4544 2008-05-02 Marek Safar <marek.safar@gmail.com>
4546 A fix for bug #371016
4547 * expression.cs: All predefined delegate operators require implicit method
4550 2008-05-02 Marek Safar <marek.safar@gmail.com>
4552 * constant.cs: Emit long constant as uint when fits the range.
4554 * convert.cs, expression.cs: Fixed few unsafe conversions.
4556 2008-05-02 Marek Safar <marek.safar@gmail.com>
4558 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4560 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4563 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4565 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4567 2008-05-01 Marek Safar <marek.safar@gmail.com>
4569 * constant.cs, literal.cs: IsLiteral property for error reporting.
4571 * ecore.cs, expression.cs: Implemented Property expression.
4573 2008-05-01 Marek Safar <marek.safar@gmail.com>
4575 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4577 * nullable.cs: Implemented nullable coalescing null operator.
4579 * ecore.cs, expression.cs: Expression trees work.
4581 2008-05-01 Marek Safar <marek.safar@gmail.com>
4583 * ecore.cs: CreateExpressionTree is finally abstract.
4585 * expression.cs, linq.cs: Updated.
4587 2008-05-01 Marek Safar <marek.safar@gmail.com>
4589 * expression.cs, ecore.cs: Block base access expression inside expression
4592 2008-05-01 Marek Safar <marek.safar@gmail.com>
4594 A fix for bug #385058
4595 * expression.cs: User-defined operator implementations always take
4596 precedence over predefined operator implementations.
4598 2008-04-30 Marek Safar <marek.safar@gmail.com>
4600 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4601 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4602 expression tree conversions.
4604 2008-04-30 Marek Safar <marek.safar@gmail.com>
4606 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4607 operators method details to Operator class.
4609 2008-04-30 Marek Safar <marek.safar@gmail.com>
4611 * anonymous.cs: Pass unsafe flags to anonymous container.
4613 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4614 inside expression tree.
4616 2008-04-29 Martin Baulig <martin@ximian.com>
4618 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4619 (Tokenizer.PopPosition): Also restore the `line'.
4621 2008-04-29 Marek Safar <marek.safar@gmail.com>
4623 * delegate.cs: Implemented Invoke expression.
4625 2008-04-29 Marek Safar <marek.safar@gmail.com>
4627 * expression.cs: Fixed equality reference comparison regression.
4629 2008-04-29 Marek Safar <marek.safar@gmail.com>
4631 * ecore.cs: Clean up EmptyCast hack.
4633 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4634 using correct conversion rules. Also fixes #383993.
4636 2008-04-28 Martin Baulig <martin@ximian.com>
4638 * class.cs (Constructor.Emit): Don't emit debugging information
4639 for generated default .ctor's.
4641 2008-04-28 Marek Safar <marek.safar@gmail.com>
4643 * convert.cs: Empty-cast ushort to int conversion.
4645 2008-04-28 Marek Safar <marek.safar@gmail.com>
4647 A fix for bug #384191
4648 * ecore.cs, expression.cs: Fixed expression cloning.
4650 2008-04-28 Marek Safar <marek.safar@gmail.com>
4652 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4654 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4656 Fix #381559, test-638.cs, test-639.cs
4657 * assign.cs (CompoundAssign.Helper): New wrapper.
4658 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4660 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4661 Pass unconverted expressions to the params array creation expression.
4662 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4663 (PropertyExpr.EmitAssign): Likewise.
4664 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4665 element if it is of kind CompoundAssign.Helper.
4666 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4667 first before anything else.
4668 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4669 (ArrayAccess.LoadArrayAndArguments): Simplify.
4671 2008-04-27 Marek Safar <marek.safar@gmail.com>
4673 * expression.cs: Fixed cloning of typeof(void).
4675 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4677 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4678 (Assign.Emit): Likewise. Move it to ...
4679 (CompoundAssign.DoResolve): ... here and ...
4680 (CompoundAssign.Emit): ... here.
4681 (EventAddOrRemove): New helper to handle += and -= on events, and
4682 avoid the use of BinaryDelegates.
4683 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4684 (EventExpr.EmitAddOrRemove): Improve.
4685 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4687 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4688 create VarExprs for 'foo.bar.var'.
4689 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4690 is a highly inappropriate name for its functionality.
4692 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4694 Simplify handling of multiple assignments
4695 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4697 (SimpleAssign): New. Class to be used for normal assignments.
4698 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4699 * expression.cs, parameter.cs, statement.cs: Likewise.
4701 2008-04-25 Marek Safar <marek.safar@gmail.com>
4703 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4704 for incompatible underlying types, more to come, uff.
4706 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4709 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4710 Handle 'leave_copy'.
4712 2008-04-25 Marek Safar <marek.safar@gmail.com>
4714 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4716 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4718 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4719 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4720 * statement.cs (While, Do, For): Allow test to have side effects.
4721 (For.DoEmit): Always emit InitStatement.
4724 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4725 Always create SideEffectConstant.
4726 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4727 of type EnumConstant.
4729 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4730 Handle 'right' being SideEffectConstant of type 'bool'.
4732 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4733 Use left.EmitBranchable instead of open coding it, so as to
4734 improve optimization opportunities.
4736 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4738 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4740 (Expression.EmitSideEffect): Document.
4742 2008-04-23 Marek Safar <marek.safar@gmail.com>
4744 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4746 2008-04-23 Marek Safar <marek.safar@gmail.com>
4748 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4750 2008-04-23 Marek Safar <marek.safar@gmail.com>
4752 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4753 conversion to expression tree.
4755 2008-04-23 Marek Safar <marek.safar@gmail.com>
4757 * ecore.cs: Removed unused expression.
4759 2008-04-22 Marek Safar <marek.safar@gmail.com>
4761 * expression.cs: Implemented NegateChecked and New expressions.
4763 2008-04-22 Marek Safar <marek.safar@gmail.com>
4765 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4767 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4770 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4771 needing final 'ret' instruction.
4773 2008-04-22 Marek Safar <marek.safar@gmail.com>
4775 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4777 2008-04-21 Marek Safar <marek.safar@gmail.com>
4779 * expression.cs: Emit ldnull and not null expression as an instance argument
4780 of static method expression calls.
4782 2008-04-21 Marek Safar <marek.safar@gmail.com>
4784 A fix for bug #378200
4785 * expression.cs: Fixed crash when creating parameterless expression tree
4788 2008-04-21 Marek Safar <marek.safar@gmail.com>
4790 A fix for bug #375297
4791 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4794 2008-04-21 Marek Safar <marek.safar@gmail.com>
4796 A fix for bug #377596
4797 * decl.cs, class.cs: Emit delegate type argument attributes.
4799 2008-04-21 Marek Safar <marek.safar@gmail.com>
4801 A fix for bug #365314
4802 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4804 2008-04-21 Marek Safar <marek.safar@gmail.com>
4806 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4809 2008-04-21 Marek Safar <marek.safar@gmail.com>
4811 * generic.cs (TypeParameter): Removed redundant location.
4813 2008-04-19 Marek Safar <marek.safar@gmail.com>
4815 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4816 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4817 FullNamedExpression in all declaration type expression, statements will come
4820 2008-04-18 Marek Safar <marek.safar@gmail.com>
4822 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4823 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4825 2008-04-18 Marek Safar <marek.safar@gmail.com>
4827 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4830 2008-04-17 Marek Safar <marek.safar@gmail.com>
4832 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4835 2008-04-17 Marek Safar <marek.safar@gmail.com>
4837 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4841 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4843 Hook up 'EmitSideEffect'
4844 * constant.cs (Constant.EmitSideEffect): New.
4845 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4846 (SideEffectConstant.EmitSideEffect): New.
4847 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4848 unconditional branch in EmitBranchable.
4849 (FieldExpr.EmitBranchable): New.
4850 * expression.cs (Unary.EmitSideEffect): New.
4851 (Binary.EmitSideEffect): New.
4852 (VariableReference.EmitSideEffect): New. Do nothing.
4854 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4856 Introduce 'EmitSideEffect'
4857 * ecore.cs (Expression.EmitSideEffect): New.
4858 (TypeCast): Rename from EmptyCast.
4860 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4861 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4862 * convert.cs, nullable.cs: Update to changes.
4864 2008-04-16 Marek Safar <marek.safar@gmail.com>
4866 * class.cs, cs-parser.jay: Early check for base types expression.
4868 2008-04-16 Marek Safar <marek.safar@gmail.com>
4870 * decl.cs (MemberName): Declare PrettyName as obsolete.
4872 2008-04-16 Marek Safar <marek.safar@gmail.com>
4874 * namespace.cs: Use MemberName comparison.
4876 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4879 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4881 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4882 (MemberName.FullyQualifiedName): New. Provides the functionality
4883 that users assume FullName would have.
4884 * ecore.cs, namespace.cs: Update to changes.
4886 * statement.cs (Using.assign): Make into ExpressionStatement.
4887 (Using.EmitPreTryBody): Simplify.
4889 2008-04-16 Marek Safar <marek.safar@gmail.com>
4891 * report.cs: ColorFormat is protected.
4893 * rootcontext.cs: Unused fields clean-up.
4895 * namespace.cs: Made UsingEntry name private.
4897 2008-04-16 Marek Safar <marek.safar@gmail.com>
4899 * cs-tokenizer.cs, location.cs: Removed unused field.
4901 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4902 Raja R Harinath <harinath@hurrynot.org>
4905 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4906 (SideEffectConstant.side_effect): Rename from 'right'.
4907 (SideEffectConstant..ctor): Normalize 'side_effect'.
4908 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4909 value of this constant.
4910 * cfold.cs: Update to changes.
4912 2008-04-15 Marek Safar <marek.safar@gmail.com>
4914 * cs-paser.jay: Removed unused variable.
4916 * driver.cs: Made Compile instance method.
4918 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4920 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4922 2008-04-15 Marek Safar <marek.safar@gmail.com>
4924 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4926 2008-04-13 Jb Evain <jbevain@novell.com>
4928 * namespace.cs: update the System.Core fullname for 2.1
4929 * driver.cs: update the list of required assemblies for 2.1.
4930 Merged from the Moonlight 2 branch.
4932 2008-04-11 Marek Safar <marek.safar@gmail.com>
4934 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4935 types and user defined operators. User operators arguments has to be checked
4936 for null value before invocation, which also means no operator is called
4937 when any argument is not convertible to unwrapped nullable type.
4939 2008-04-09 Marek Safar <marek.safar@gmail.com>
4941 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4942 of Unary expressions to follow operator overloading rules precisely.
4943 Also fixes #321794, #323794
4945 2008-04-08 Marek Safar <marek.safar@gmail.com>
4947 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4950 2008-04-08 Marek Safar <marek.safar@gmail.com>
4952 * expression.cs, ecore.cs: Implemented MemberInit expression.
4954 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4956 Fix mono/tests/exception4.cs
4957 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4958 ec.NeedReturnLabel () rather emitting a 'nop'.
4960 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4962 (TryCatch.SomeCodeFollows): Likewise.
4963 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4964 for 'break', 'continue' and 'return' statements inside a try.
4965 We're fairly sure that the generated IL stream will have more
4966 instructions textually following the try.
4967 (FlowBranchingTryCatch): Likewise.
4969 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4970 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4973 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4974 wrapper -- forward everything to CollectionForeach.
4975 (CollectionForeach.NonDisposableWrapper): New.
4976 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4977 instead of a pop + branch to end.
4979 2008-04-07 Marek Safar <marek.safar@gmail.com>
4981 A fix for bug #377485
4982 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4983 Propagate location for extension method groups. Report conversion failure at
4986 2008-04-07 Marek Safar <marek.safar@gmail.com>
4988 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4989 ListInit and Field expressions.
4991 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4993 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4994 Since $PC is always -1 inside the body of MoveNext, the fault
4996 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4997 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4998 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
5000 The denouement! Fix #324708
5001 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
5002 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
5003 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
5004 'finally' inside the finally clause.
5006 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
5007 inside an iterator. Don't emit the body of the 'finally' inside
5008 the finally clause yet.
5010 Use the ResumableStatement infrastructure for MoveNext ()
5011 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
5012 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
5013 'old_resume_points'. Move dispatcher upfront.
5014 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
5015 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
5016 in an enumerator. This encodes the main fix in this patch series
5017 -- we can only jump into the first instruction of a try from the
5018 outside, but we want to emit try/finally regions in iterators and
5019 resume in the middle of them.
5021 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
5023 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
5024 of NeedReturnLabel here.
5026 Introduce a common point for emitting try/finally to IL
5027 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
5028 features of the various subclasses, which are now driven by ...
5029 (ExceptionStatement.EmitPreTryBody): ... this and ...
5030 (ExceptionStatement.EmitTryBody): ... this and the original
5032 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
5033 Remove DoEmit and update to follow above protocol.
5035 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
5036 of the dispatcher are the same, skip emitting the 'switch'.
5037 * iterator.cs (Iterator.EmitDispose): Update to changes.
5039 Clean up handling of 'using' statement
5040 * statement.cs (UsingTemporary): New. Carved out of ...
5041 (Using): ... this. Simplify drastically. Handle exactly
5043 * cs-parser.jay (using_statement): Split. Create UsingTemporary
5044 or Using as appropriate. If there are multiple variable declared,
5045 create nested Using statements.
5046 (resource_acquisition): Kill.
5048 * statement.cs (ExceptionStatement.EmitForDispose): Use
5049 EmitFinallyBody, not EmitFinally.
5051 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
5052 * iterator.cs: Update to changes.
5054 Start using the ResumableStatement infrastructure
5055 * statement.cs (ResumeableStatement.PrepareForDispose): New.
5056 (ResumableStatement.EmitForDispose): New.
5057 (ExceptionStatement): Override them.
5058 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
5059 EmitForDispose to create the body of the Dispose method. Don't
5062 * iterator.cs (Iterator.AddResumePoint): Move here from ...
5063 * statement.cs (Toplevel.AddResumePoint): ... here.
5064 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
5065 * flowanalysis.cs (FlowBranchingIterator): New.
5066 * codegen.cs (EmitContext): Update to changes.
5068 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
5069 (Iterator.old_resume_points): Rename from 'resume_points'.
5070 (Iterator.MoveNextStatement): Remove unused class.
5072 New infrastructure for try/finally in iterators (still unused)
5073 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
5074 (FlowBranchingToplevel.AddResumePoint): Hook into
5075 ToplevelBlock.AddResumePoint.
5076 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
5077 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
5078 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
5079 resume points and assign program-counter values.
5080 (ExceptionBlock.AddResumePoint): Collect resume points for
5081 de-muxer at the top of try block.
5082 * iterators.cs (Yield.CheckContext): Simplify.
5083 (Yield.Resolve): Use FlowBranching.AddResumePoint.
5085 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
5087 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
5088 argument to an ExitStatement.
5089 (FlowBranchingException): Refactor saved origins code.
5090 * statement.cs (ExitStatement): Update to cahges.
5091 * iterator.cs (YieldBreak): Likewise.
5093 * statement.cs (ResumableStatement): New. Common base class for
5094 YieldReturn and ExceptionStatement.
5095 (ExitStatement): New. Common base class for Return and YieldBreak.
5096 (Return): Update to changes.
5097 * iterator.cs (YieldBreak): Likewise.
5098 * lambda.cs (ContextualReturn): Likewise.
5101 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
5102 emit a meaningful error message.
5104 Fix #324765, #319508
5105 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
5106 (VariableInfo.SetAssigned): Set it.
5107 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
5108 determine if CS0219 or CS0168 is appropriate. Don't use
5109 flow-analysis information.
5110 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
5111 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
5112 (EmitContext.EndFlowBranching): ... this.
5114 2008-04-03 Marek Safar <marek.safar@gmail.com>
5116 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5118 2008-04-03 Marek Safar <marek.safar@gmail.com>
5120 A fix for bug #376508
5121 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5122 ImplicitConversionExists.
5124 2008-04-03 Marek Safar <marek.safar@gmail.com>
5126 * expression.cs (Binary): Added remaining binary operators to expression
5129 * nullable.cs: Optimize shift with null argument.
5131 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5133 Fix minor IL regression
5134 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5135 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5136 * cs-parser.jay (try_statement): Update to changes.
5138 * statement.cs (TryFinally.need_exc_block): Delete.
5139 (TryFinally): Update to changes.
5141 Now all ExceptionStatements are unconditional
5142 * statement.cs (CollectionForeach.DisposableWrapper): New.
5143 Extract out the try/finally code into a new wrapper.
5144 (CollectionForeach.Resolve): Use it to simplify the code.
5146 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5148 Start at simplifying ExceptionStatement semantics a bit
5149 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5150 * cs-parser.jay (try_statement): Update to changes.
5151 (opt_catch_clauses): Remove.
5152 * flowanalysis.cs: Update to changes.
5153 (FlowBranching.BranchingType.TryCatch): New.
5154 (FlowBranchingTryCatch): New.
5156 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5157 (FlowBranching.CreateBranching): Update to changes.
5158 (FlowBranchingBlock.AddSibling): Add sanity check.
5159 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5162 * iterators.cs (Iterator.MarkFinally): Remove.
5163 * statement.cs (ExceptionStatement): Update to changes.
5165 Add support for skipping over finally blocks at runtime. First
5166 in a series to fix #324708
5167 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5168 (Iterator.EmitMoveNext): Initialize it.
5169 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5170 branch over the body of the 'finally' clause.
5172 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5174 Avoid lopsided use of Foo/DoFoo names
5175 * statement.cs (ExpressionStatement.EmitFinallyBody):
5176 Rename from EmitFinally.
5177 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5178 * iterator.cs: Update to changes.
5180 2008-04-02 Marek Safar <marek.safar@gmail.com>
5182 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5183 based on UserOperatorCall. More binary nullable operators clean up.
5185 2008-04-02 Martin Baulig <martin@ximian.com>
5187 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5189 2008-04-02 Marek Safar <marek.safar@gmail.com>
5191 * nullable.cs: Merge user and empty conversions when lifting expression
5194 * expression.cs (StringConcat): Implemented expression tree representation.
5196 2008-04-01 Marek Safar <marek.safar@gmail.com>
5198 * nullable.cs: When lifting null literal and a user operator exists, no call
5201 2008-04-01 Marek Safar <marek.safar@gmail.com>
5203 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5206 2008-04-01 Marek Safar <marek.safar@gmail.com>
5208 * nullable.cs, expression.cs: Use namespace instead heavily nested
5209 monster abstract class.
5211 2008-04-01 Marek Safar <marek.safar@gmail.com>
5213 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5214 lifting of null literal and user operators. Clean up of some temporary
5217 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5219 Fix #368224, test-629.cs
5220 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5221 if it crossed an unwind-protect boundary.
5222 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5223 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5224 inside an unwind-protected region.
5225 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5226 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5227 'leave' instead of a 'br' if unwind-protected.
5228 (Iterator.EmitYieldBreak): Likewise.
5230 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5232 * driver.cs: Only define versioninfo resources if no win32 resource
5235 2008-03-28 Marek Safar <marek.safar@gmail.com>
5237 A fix for bug #372375
5238 * convert.cs: Fixed boxing of nullable types.
5240 2008-03-28 Marek Safar <marek.safar@gmail.com>
5242 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5245 2008-03-28 Marek Safar <marek.safar@gmail.com>
5247 A fix for bug #374619
5248 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5250 2008-03-27 Marek Safar <marek.safar@gmail.com>
5252 * lambda.cs: Check return type only for invocation.
5254 2008-03-27 Marek Safar <marek.safar@gmail.com>
5256 A fix for bug #374214
5257 * ecore.cs: Correctly report argument type mismatch.
5259 2008-03-27 Marek Safar <marek.safar@gmail.com>
5261 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5262 and not rely on broken IsEnum.
5264 2008-03-27 Marek Safar <marek.safar@gmail.com>
5266 * nullable.cs: New file, extracted from generic.cs.
5268 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5270 2008-03-27 Marek Safar <marek.safar@gmail.com>
5272 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5273 predefined comparison operators and null literals.
5275 * report.cs: New warning ID.
5277 2008-03-25 Marek Safar <marek.safar@gmail.com>
5279 A fix for bug #370577
5280 * lambda.cs: Check return type too.
5282 2008-03-25 Marek Safar <marek.safar@gmail.com>
5284 A fix for bug #372846
5285 * class.cs: Automatic properties can be declared as unsafe.
5287 2008-03-20 Marek Safar <marek.safar@gmail.com>
5289 * location.cs: Use string based concatenation.
5291 * expression.cs: LiftedBinaryOperator is gmcs only.
5293 2008-03-20 Marek Safar <marek.safar@gmail.com>
5295 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5296 conversions rules and expression trees.
5298 2008-03-19 Marek Safar <marek.safar@gmail.com>
5300 * delegate.cs: Use extension method source as delegate target.
5302 2008-03-19 Marek Safar <marek.safar@gmail.com>
5304 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5305 binary operations to be purely based on binary operations and optimized
5306 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5307 and other ET refactoring.
5309 * typemanager.cs: Fixed warning.
5311 2008-03-17 Marek Safar <marek.safar@gmail.com>
5313 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5315 * symbolwriter.cs: Fixed.
5317 2008-03-17 Marek Safar <marek.safar@gmail.com>
5319 * anonymous.cs, driver.cs: Reset anonymous types counters.
5321 2008-03-17 Marek Safar <marek.safar@gmail.com>
5323 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5325 * class.cs: Use fullname for all type member definitions.
5327 2008-02-19 Martin Baulig <martin@ximian.com>
5330 (IMethodData.EmitExtraSymbolInfo): New interface method.
5331 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5332 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5333 interface method here as an empty public virtual method.
5336 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5337 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5338 CodeGen.SymbolWriter.SetRealMethodName().
5340 2008-02-18 Martin Baulig <martin@ximian.com>
5343 (ScopeInfo.EmitType): Override this and emit debugging
5344 information for captured variables.
5345 (RootScopeInfo.EmitType): Override this and emit symbol
5346 information for a captured `this'.
5348 2008-02-15 Martin Baulig <martin@ximian.com>
5350 * iterators.cs: Emit debugging info.
5353 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5354 (EmitContext.OmitDebuggingInfo): New public property.
5357 (While): Override Emit() and don't emit symbol info there; do it
5358 inside DoEmit() instead.
5359 (Block.Emit): Omit symbol information while emitting the scope
5360 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5362 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5363 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5364 .ctor to make `IsIterator' work.
5366 2008-03-14 Martin Baulig <martin@ximian.com>
5368 * symbolwriter.cs: Added the new symbol writer function from the
5369 debugger's `terrania' branch; temporarily enclose them inside
5370 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5373 2008-03-14 Martin Baulig <martin@ximian.com>
5376 (SymbolWriter): Make this a public static class.
5379 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5380 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5382 2008-03-14 Marek Safar <marek.safar@gmail.com>
5384 A fix for bug #370577
5385 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5388 2008-03-14 Marek Safar <marek.safar@gmail.com>
5390 * typemanager.cs (CSharpName): Made 250 times faster.
5392 2008-03-13 Marek Safar <marek.safar@gmail.com>
5394 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5396 2008-03-12 Marek Safar <marek.safar@gmail.com>
5398 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5399 crash when predefined field does not exist.
5401 2008-03-12 Marek Safar <marek.safar@gmail.com>
5403 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5405 2008-03-12 Marek Safar <marek.safar@gmail.com>
5407 * class.cs (FixedField): Don't crash when contructors are missing.
5409 2008-03-11 Marek Safar <marek.safar@gmail.com>
5411 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5412 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5413 check internal types accessibility for internal and external types.
5414 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5416 2008-03-11 Marek Safar <marek.safar@gmail.com>
5418 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5419 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5420 attribute.cs, statement: Use corect instance of predefined types (work
5421 related to #364674).
5423 2008-03-07 Marek Safar <marek.safar@gmail.com>
5425 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5427 2008-03-07 Marek Safar <marek.safar@gmail.com>
5429 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5430 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5431 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5432 predefined types clean up, delayed predefined types members initialization
5433 (work related to #364674).
5435 2008-03-05 Marek Safar <marek.safar@gmail.com>
5437 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5439 2008-03-05 Marek Safar <marek.safar@gmail.com>
5441 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5442 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5443 predefined types clean up (work related to #364674).
5445 2008-03-04 Marek Safar <marek.safar@gmail.com>
5447 * ecore.cs: Print an error message instead of throwing exception.
5449 2008-03-04 Marek Safar <marek.safar@gmail.com>
5451 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5452 expression.cs, statement.cs: Unififed null literal representation.
5454 2008-03-03 Marek Safar <marek.safar@gmail.com>
5456 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5457 expression.cs: Refactored binary operators resolve phase and improved speed.
5458 The nullable code is still missing and won't work correctly, more fixes
5461 It also fixes #323726, #324312, #324248, and many other unreported issues.
5463 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5465 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5468 2008-02-27 Marek Safar <marek.safar@gmail.com>
5470 * ecore.cs: Clean-up and split BetterConversion.
5472 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5475 * enum.cs (EnumMember.Value): Only access 'value' if
5476 ResolveValue says it's ok.
5477 (EnumMember.DoResolveValue): Don't set prev_member.value.
5478 (Enum.GetDefinition): Reverse arguments of Equals --
5479 EnumMember.Value can return 'null'.
5481 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5483 2008-02-22 Marek Safar <marek.safar@gmail.com>
5485 * generic.cs, expression.cs: More ongoing work on expression trees.
5487 2008-02-21 Marek Safar <marek.safar@gmail.com>
5489 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5490 handle missing matches when mutiple operators exist.
5492 2008-02-20 Marek Safar <marek.safar@gmail.com>
5494 A fix for bug #363218
5495 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5498 2008-02-20 Marek Safar <marek.safar@gmail.com>
5500 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5501 update. This time to deal correctly with SideEffectConstant expression used
5502 as an argument for another constant folding.
5504 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5506 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5509 2008-02-19 Marek Safar <marek.safar@gmail.com>
5511 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5513 2008-02-19 Marek Safar <marek.safar@gmail.com>
5515 A fix for bug #328136
5516 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5517 side is a false constant, because we still need to evaluate the right-hand
5520 * statement.cs (If): Emit two types of boolean constants (simple constant,
5521 side-effect constant).
5523 2008-02-19 Marek Safar <marek.safar@gmail.com>
5525 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5527 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5530 2008-02-18 Marek Safar <marek.safar@gmail.com>
5532 A fix for bug #361457
5533 * ecore.cs (IsApplicable): Params methods have lower priority.
5535 * support.cs: Return correct parameter modifier for params types.
5537 2008-02-18 Marek Safar <marek.safar@gmail.com>
5539 * generic.cs (TypeParameter): Cache attribute target name.
5541 * support.cs: Removed unused variable.
5543 * typemanager.cs: Removed debugging leftover.
5545 * ecore.cs: Use local type instead of a property;
5547 * class.cs (VerifyMembers): Consider also parent to test whether type member
5550 * expression.cs (FullMethodDesc): Removed.
5552 * attribute.cs (IsValidArgumentType): Made static.
5554 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5556 Cleanup to be more readable.
5557 * Makefile (GMCS_PROFILE): Remove.
5558 (COMPILER_NAME): New helper.
5560 2008-02-15 Miguel de Icaza <miguel@novell.com>
5562 * cs-tokenizer.cs: if a conditional expression happens inside a
5563 (...) this also means that we do not need to de-ambiguate between
5564 an parenthesized expression and a cast.
5568 * constant.cs (SideEffectConstant): a constant value that happens
5569 to have a side effect.
5571 Fixes the build regressions introduced by the fix for #359789
5573 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5575 * expression.cs (Conditional.Emit): when emitting the ternary
5576 operator, use local variables to generate code verifiable code.
5578 The verifier cannot infer that the type on stack before the
5579 stloc.0 is executed is of type ParentB. This happens because the
5580 stack merge algorithm uses only parent types when deciding which
5581 is the common type. This is described in Part III 1.8.1.3 of ECMA
5584 This code compiled with mcs is not verifiable under MS. The MS
5585 verifier picks the first common interface of Foo and Bar, which is
5586 wrong, but doesn't use a full join type of the 2 interfaces.
5588 CSC uses a clever hack to compile such code in a verifiable
5589 way. It stores the intermediate values in a local variable with
5594 2008-02-14 Miguel de Icaza <miguel@novell.com>
5596 * expression.cs: Do not fold BitwiseAnd operators when the left
5597 side is a false constant, because we still need to evaluate the
5602 * support.cs: Instead of throwing an InternalErrorException when
5603 the position of the stream is outside the boundary of our buffer,
5604 reset the state of the reader, and restart the reading from the
5605 beginning of the file.
5607 2008-02-14 Marek Safar <marek.safar@gmail.com>
5609 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5611 2008-02-14 Marek Safar <marek.safar@gmail.com>
5613 A fix for bug #361686
5614 * decl.cs: A protected types used inside a private class which parents
5615 derives from the protected class are accessible.
5617 2008-02-13 Marek Safar <marek.safar@gmail.com>
5619 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5620 the parameterless constructor.
5622 2008-02-13 Marek Safar <marek.safar@gmail.com>
5624 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5625 lookup methods to use standard member cache when doing member lookup.
5627 2008-02-12 Marek Safar <marek.safar@gmail.com>
5629 * driver.cs: Don't report full path for referenced module as assembly error.
5631 2008-02-12 Marek Safar <marek.safar@gmail.com>
5633 * Makefile: Fixed `qh' target to work on all machines.
5635 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5636 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5637 and HasElementType with TypeManager implementation.
5639 2008-02-08 Marek Safar <marek.safar@gmail.com>
5641 A fix for bugs #325134, #359749
5642 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5643 first binds point to non-method member expression.
5645 2008-02-08 Marek Safar <marek.safar@gmail.com>
5647 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5649 2008-02-08 Marek Safar <marek.safar@gmail.com>
5651 A fix for bugs #321394, #323028
5652 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5653 Reworked naive IsAccessibleAs implementation to handle nested types.
5655 2008-02-05 Jb Evain <jbevain@novell.com>
5657 * class.cs: use generic type comparison for parameters
5660 2008-02-05 Marek Safar <marek.safar@gmail.com>
5662 A fix for bug #325372
5663 * class.cs: Use generic type comparison when testing method signatures.
5665 2008-02-05 Marek Safar <marek.safar@gmail.com>
5667 A fix for bug #357047
5668 * ecore.cs: Applied C# 3.0 changes to better conversion.
5670 2008-02-05 Marek Safar <marek.safar@gmail.com>
5672 A fix for bug #358374
5673 * cs-parser.jay: Correctly set modifiers for all constructor types.
5675 2008-02-04 Marek Safar <marek.safar@gmail.com>
5677 A fix for bug #355251
5678 * generic.cs: Added base class constraint based type inference.
5680 2008-02-01 Marek Safar <marek.safar@gmail.com>
5682 A fix for bug #357255
5683 * decl.cs: One more missing visibility check.
5685 2008-02-01 Marek Safar <marek.safar@gmail.com>
5687 * support.cs: Fixed broken return.
5689 2008-01-25 Marek Safar <marek.safar@gmail.com>
5691 * report.cs: Correctly reset warnings count after probing.
5693 2008-01-25 Martin Baulig <martin@ximian.com>
5696 (NamespaceEntry.SymbolFileID): Make this work again after
5697 MemberName.ToString() is gone.
5699 2008-01-25 Marek Safar <marek.safar@gmail.com>
5701 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5704 2008-01-25 Marek Safar <marek.safar@gmail.com>
5706 * generic.cs: Use full implicit conversion for type inference fixing.
5708 2008-01-24 Marek Safar <marek.safar@gmail.com>
5710 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5711 Fixed user operator conversions.
5713 2008-01-24 Marek Safar <marek.safar@gmail.com>
5715 * generic.cs: Do nullable type to null comparison optimization during
5718 2008-01-24 Marek Safar <marek.safar@gmail.com>
5720 A fix for bug #355163
5721 * generic.cs: Enabled l-value resolve on nullable expressions.
5723 2008-01-24 Marek Safar <marek.safar@gmail.com>
5725 A fix for bug #353986
5726 * class.cs: Ingore static ctors with parameters for any further checks.
5728 2008-01-24 Marek Safar <marek.safar@gmail.com>
5730 A fix for bug #354310
5731 * namespace.cs: Removed redundant check.
5733 2008-01-24 Marek Safar <marek.safar@gmail.com>
5735 A fix for bug #354928
5736 * expression.cs: ElementInitializers can be resolved only once.
5738 2008-01-24 Marek Safar <marek.safar@gmail.com>
5740 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5741 Condition expressions.
5743 2008-01-23 Marek Safar <marek.safar@gmail.com>
5745 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5747 2008-01-22 Marek Safar <marek.safar@gmail.com>
5749 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5752 * generic.cs: Implemented coalesce expression.
5754 2008-01-22 Marek Safar <marek.safar@gmail.com>
5756 A fix for bug #355145
5757 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5758 expression tree type inference.
5760 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5763 * expression.cs (Binary.IsUnsignedType): Fix typo.
5765 2008-01-22 Marek Safar <marek.safar@gmail.com>
5767 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5769 2008-01-22 Marek Safar <marek.safar@gmail.com>
5771 A fix for bug #355161
5772 * ecore.cs, expression.cs: Wider range of extension method supported
5775 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5777 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5778 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5781 2008-01-22 Marek Safar <marek.safar@gmail.com>
5783 A fix for bug #355148
5784 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5786 2008-01-22 Miguel de Icaza <miguel@novell.com>
5788 * expression.cs (CreateExpressionTree): Add support for or and
5789 logical or, and indent following the coding conventions.
5791 * typemanager.cs (LinqExpression): renamed from
5792 ExpressionTreeManager, for a shorter name.
5794 Use TypeManager.CoreLookupType to lookup types from our core
5795 assemblies and turn those into "Type" variables.
5797 Consumers that previously used "Namespace" and "Type" from this
5798 class should instead use the TypeExpression which is a type that
5799 is fully resolved (without involving the regular C# resolution
5802 This typically looks like this:
5804 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5805 new MemberAccess (texpr, name, type_arguments, loc)
5807 This avoids the problem in: #355178
5809 2008-01-21 Marek Safar <marek.safar@gmail.com>
5811 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5812 feature in parser only as we do in other cases.
5814 2008-01-21 Marek Safar <marek.safar@gmail.com>
5816 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5817 typemanager.cs: A refactoring of params arguments to reuse existing
5818 expressions (params -> array initializer) to emit params argument instead
5819 of specialized handling.
5820 It was required by expression tree implementation and it has other benefits
5821 as well, we now apply same optimization for params arguments as we do for
5824 2008-01-18 Marek Safar <marek.safar@gmail.com>
5826 A fix for bug #353526
5827 * generic.cs: A type inference of params arguments may not required any
5828 temporary array creation.
5830 2008-01-18 Marek Safar <marek.safar@gmail.com>
5832 A fix for bug #353534
5833 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5834 supported for delegates only.
5836 2008-01-18 Marek Safar <marek.safar@gmail.com>
5838 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5839 type for more than 1 candidates.
5841 2008-01-18 Marek Safar <marek.safar@gmail.com>
5843 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5846 2008-01-16 Marek Safar <marek.safar@gmail.com>
5848 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5849 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5850 operator) expressions.
5852 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5854 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5855 not accessed from the generated IL.
5857 2008-01-14 Marek Safar <marek.safar@gmail.com>
5859 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5860 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5861 statement.cs: The first expression tree implementation drop, mostly
5862 infrastructure work.
5864 2008-01-14 Marek Safar <marek.safar@gmail.com>
5866 * ecore.cs (IsNestedChild): Refactored.
5868 2008-01-11 Marek Safar <marek.safar@gmail.com>
5870 * lambda.cs: Don't use a cast on unknown expression statement.
5872 2008-01-10 Geoff Norton <gnorton@novell.com>
5874 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5877 2008-01-09 Marek Safar <marek.safar@gmail.com>
5879 * doc.cs: Report better /doc crash details.
5881 2008-01-09 Marek Safar <marek.safar@gmail.com>
5883 A fix for bug #352536
5884 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5886 2008-01-08 Marek Safar <marek.safar@gmail.com>
5888 A fix for bug #352287
5889 * ecore.cs, expression.cs: Do `this' access checking in all member access
5892 2008-01-08 Marek Safar <marek.safar@gmail.com>
5894 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5896 * report.cs: Reset message stacks.
5898 2008-01-08 Marek Safar <marek.safar@gmail.com>
5900 * generic.cs (InferInPhases): Correctly calculate params position.
5902 2008-01-08 Marek Safar <marek.safar@gmail.com>
5904 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5907 2008-01-07 Marek Safar <marek.safar@gmail.com>
5909 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5911 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5913 * driver.cs: Updated --help option.
5915 2008-01-07 Marek Safar <marek.safar@gmail.com>
5917 * generic.cs (InferParamsTypeArguments): Removed.
5918 (InferInPhases): Add params type inference.
5919 (LowerBoundInference): Fixed scoring mechanism.
5921 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5923 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5925 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5926 byte array for unsigned "baked" assemblies.
5928 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5930 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5931 array for assemblies that are not strongnamed.
5933 2008-01-04 Marek Safar <marek.safar@gmail.com>
5935 A fix for bug #351481
5936 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5937 declaring type for nested generic types.
5939 2008-01-04 Marek Safar <marek.safar@gmail.com>
5941 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5942 instead of ToString.
5944 2008-01-03 Marek Safar <marek.safar@gmail.com>
5946 A fix for bug #351047
5947 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5948 null and structs only when equality and inequality operators are defined
5949 either as an user-operators or predefined operators.
5951 2008-01-03 Marek Safar <marek.safar@gmail.com>
5953 A fix for bug #351047
5954 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5956 2008-01-03 Marek Safar <marek.safar@gmail.com>
5958 A fix for bug #351257
5959 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5961 2008-01-03 Marek Safar <marek.safar@gmail.com>
5963 A fix for bug #351157
5964 * class.cs (Using): Fixed yet another broken cloning.
5966 (Block): Put back more sensible default value for statements.
5968 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5970 * codegen.cs: Allow AssemblyVersion with only major version component.
5973 2007-12-29 Marek Safar <marek.safar@gmail.com>
5975 A fix for bug #324654
5976 * class.cs: Use FullName property as member name.
5978 2007-12-28 Marek Safar <marek.safar@gmail.com>
5980 A fix for bug #342117
5981 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5982 constructor constraint.
5984 2007-12-28 Marek Safar <marek.safar@gmail.com>
5986 A fix for bug #338273
5987 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5990 2007-12-28 Marek Safar <marek.safar@gmail.com>
5992 A fix for bug #350839
5993 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5995 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5997 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6000 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6002 * statement.cs: Changed some Hashtables to use HybridDictionaries
6003 instead. It was observed that some HashTables only contained a few
6004 items in the vast majority of cases. Since HybridDictionary is
6005 more efficient on small sets (<10 elements), "known_variables"
6006 from class ExplicitBlock as well as "labels" and "constants " from
6007 class Block were changed to HybridDictionaries.
6009 Atsai results: (56216kb->54987kb)
6011 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
6014 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6016 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6019 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6021 * expression.cs: foreach loop to for loop, saved on allocation of
6022 enumerator (59333kb->59141kb)
6024 * statement.cs. Changed foreach loops to for loops, saved on
6025 allocation of enumerator (59141kb->59006kb)
6027 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
6028 when constructed with no specified capacity. This was causing a
6029 few ArrayLists to allocate more memory than they would potentially
6030 need in the Block class and MemberCache class. Setting the
6031 ArrayLists to construct with a capacity of 1 saves some
6032 memory. (56216kb->55585kb)
6034 2007-12-27 Marek Safar <marek.safar@gmail.com>
6036 A fix for bug #347189 (2nd issue)
6037 * expression.cs (MemberAccess): Nested type can be found in base non-generic
6040 2007-12-27 Miguel de Icaza <miguel@novell.com>
6042 * report.cs: Do not use colors if stdout and stderr are not a
6045 2007-12-27 Marek Safar <marek.safar@gmail.com>
6047 A fix for bug #346998
6048 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
6051 2007-12-27 Marek Safar <marek.safar@gmail.com>
6053 A fix for bug #343465
6054 * class.cs: Explicit method name for nested types uses dots only.
6056 2007-12-27 Marek Safar <marek.safar@gmail.com>
6058 A fix for bug #343707
6059 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
6061 2007-12-27 Marek Safar <marek.safar@gmail.com>
6063 * ecore.cs: Report type inference errors only when arguments count matches
6066 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
6068 * expression.cs, report.cs: New warning.
6070 * typemanager.cs: Catch anonymous method type too.
6072 2007-12-23 Marek Safar <marek.safar@gmail.com>
6074 A fix for bug #346379
6075 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
6077 2007-12-23 Marek Safar <marek.safar@gmail.com>
6079 A fix for bug #347359
6080 * expression.cs (Invocation): Don't resolve already resolved expression.
6082 2007-12-23 Marek Safar <marek.safar@gmail.com>
6084 A fix for bug #347189
6085 * class.cs (FixedField): Use non-dependent code only in the define phase.
6087 2007-12-23 Marek Safar <marek.safar@gmail.com>
6089 A fix for bug #348076
6090 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
6092 2007-12-22 Marek Safar <marek.safar@gmail.com>
6094 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
6095 discovered extension methods.
6097 2007-12-22 Marek Safar <marek.safar@gmail.com>
6099 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
6102 2007-12-21 Miguel de Icaza <miguel@novell.com>
6104 * report.cs (ErrorMessage): Add support for using colors on
6105 terminals that support it.
6107 2007-12-21 Marek Safar <marek.safar@gmail.com>
6109 * ecore.cs: Use information about expanded params for error reporting.
6111 2007-12-21 Marek Safar <marek.safar@gmail.com>
6113 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
6114 and logic for params overloads.
6116 2007-12-15 Miguel de Icaza <miguel@novell.com>
6118 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6119 as this is also created from the parser. Fixes #349034
6121 2007-12-12 Miguel de Icaza <miguel@novell.com>
6123 * statement.cs (Throw.CloneTo): it is valid to have empty
6124 expressions for throw.
6126 2007-12-03 Marek Safar <marek.safar@gmail.com>
6128 * cs-parser.jay: Set delegate constraint parsing region correctly.
6130 2007-12-03 Marek Safar <marek.safar@gmail.com>
6132 A fix for bug #345467
6133 * typemanager.cs (IsEqual): Compare generic parameters position only.
6135 2007-11-28 Marek Safar <marek.safar@gmail.com>
6137 * expression.cs (BaseAccess): Type arguments can be null.
6139 2007-11-27 Raja R Harinath <harinath@gmail.com>
6141 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6142 consistent even when an error has occured.
6143 (Switch.Resolve): Likewise.
6145 2007-11-22 Marek Safar <marek.safar@gmail.com>
6147 A fix for bug #334505
6148 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6151 2007-11-22 Marek Safar <marek.safar@gmail.com>
6153 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6154 refactorings required to resolve extension methods correctly when mixing
6155 generics and non-generics members.
6157 2007-11-20 Marek Safar <marek.safar@gmail.com>
6159 A fix for bug #342584
6160 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6163 2007-11-19 Marek Safar <marek.safar@gmail.com>
6165 A fix for bug #342512
6166 * delegate.cs: Use delegate argument expression when is available. Don't
6167 emit virtual call when class is sealed.
6169 2007-11-16 Marek Safar <marek.safar@gmail.com>
6171 A fix for bug #325423
6172 * assign.cs (FieldInitializer): Use resolved expression for emit.
6174 * class.cs: Print less confusing error message.
6176 2007-11-16 Marek Safar <marek.safar@gmail.com>
6178 * cs-tokenizer.cs: Removed GMCS ifdefs.
6180 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6183 * cs-parser.jay: Disabled nullable check.
6185 * generic-mcs: Copied more generic stuff.
6187 2007-11-16 Marek Safar <marek.safar@gmail.com>
6189 * gcs-parser.jay: Merged to cs-parser.jay.
6191 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6192 * *.csproj, *.sources: Updated to use only jay parser file.
6194 2007-11-16 Marek Safar <marek.safar@gmail.com>
6196 * gcs-parser.jay: Added nullable and default expression feature checks.
6198 2007-11-16 Marek Safar <marek.safar@gmail.com>
6200 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6201 it fixes many TODOs and hidden bugs.
6203 * expression: Removed duplicate error check.
6205 2007-11-15 Marek Safar <marek.safar@gmail.com>
6207 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6208 implicitly type local variable only when it is used in a declaration.
6210 2007-11-15 Marek Safar <marek.safar@gmail.com>
6212 * attribute.cs: Use CS0612 for empty strings.
6214 2007-11-14 Marek Safar <marek.safar@gmail.com>
6216 * lambda.cs, statement.cs: Contextual return may act as a statement.
6218 2007-11-14 Marek Safar <marek.safar@gmail.com>
6220 A fix for a regression cause by #324222
6221 * class.cs: Don't report unused even when it implements an interface.
6223 2007-11-13 Marek Safar <marek.safar@gmail.com>
6225 A fix for bug #341205
6226 * ecore.cs, expression.cs: Method group expression cannot do static
6227 method access with an instance reference check before overloading takes
6230 2007-11-13 Marek Safar <marek.safar@gmail.com>
6232 A fix for bug #325359
6233 * class.cs: Use predictable name for automatically generated property.
6235 2007-11-12 Marek Safar <marek.safar@gmail.com>
6237 A fix for bug #324996
6238 * expression.cs (Is): Handle case where D is nullable and T is not
6241 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6243 2007-11-12 Marek Safar <marek.safar@gmail.com>
6245 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6246 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6247 Flush small error reporting changes.
6249 2007-11-09 Marek Safar <marek.safar@gmail.com>
6251 A fix for bug #324996
6252 * expression.cs: Rewrote Is expression implementation to work with
6253 generics, nullable types, anonymous method. A const result expression
6254 uses existing infrastructure instead of custom not fully-featured one.
6256 2007-11-08 Marek Safar <marek.safar@gmail.com>
6258 A fix for bug #340202
6259 * class.cs: Consider generics for volatile field.
6261 2007-11-08 Marek Safar <marek.safar@gmail.com>
6263 A fix for bug #335594
6264 * expression.cs: Use conversion rules when handling string addition.
6266 2007-11-07 Marek Safar <marek.safar@gmail.com>
6268 A fix for bug #336651
6269 * expression.cs: Fixed a crash when probing is on.
6271 2007-11-07 Marek Safar <marek.safar@gmail.com>
6273 A fix for bug #324242
6274 * covert.cs: Added a conversion from any nullable-type with an
6275 underlying enum-type to the type System.Enum.
6277 2007-11-07 Marek Safar <marek.safar@gmail.com>
6279 A fix for bug #324222
6280 * class.cs: Report all non-used event fields.
6282 2007-11-07 Marek Safar <marek.safar@gmail.com>
6284 A fix for bug #325161
6285 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6286 qualifier for generic types.
6288 2007-11-07 Marek Safar <marek.safar@gmail.com>
6290 A fix for bug #322971
6291 * expression.cs, ecore.cs: Added intermediate result value check for
6294 2007-11-07 Marek Safar <marek.safar@gmail.com>
6296 A fix for bug #324754
6297 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6298 when it was requested.
6300 2007-11-07 Marek Safar <marek.safar@gmail.com>
6302 A fix for bug #325101
6303 * expression.cs: Do type not value comparison for `is' expression.
6305 2007-11-07 Marek Safar <marek.safar@gmail.com>
6307 A fix for bug #320236
6308 * convert.cs: Don't apply user conversion on underlying target type.
6310 2007-11-06 Marek Safar <marek.safar@gmail.com>
6312 * expression.cs: Don't use unresolved expression for error reporting.
6314 2007-11-06 Marek Safar <marek.safar@gmail.com>
6316 A fix for bugs #337712, #324490
6317 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6318 overloading resolution too.
6320 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6321 the process consistent and more robust.
6323 * expression.cs, linq.cs, report.cs: Update.
6325 2007-11-02 Marek Safar <marek.safar@gmail.com>
6327 A fix for bug #332909
6328 * attribute.cs: Resolve attributes in correct context using error
6331 * rootcontext.cs: Define Obsolete attribute members as core members.
6333 2007-11-02 Marek Safar <marek.safar@gmail.com>
6335 * statement.cs: Removed unused methods.
6337 2007-10-31 Wade Berrier <wberrier@novell.com>
6339 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6340 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6343 2007-10-31 Marek Safar <marek.safar@gmail.com>
6345 A fix for bug #338102
6346 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6347 methods registered as non-generics.
6349 2007-10-31 Marek Safar <marek.safar@gmail.com>
6351 A fix for bugs #337712, #324490
6352 * delegate.cs: Delegate covariance and contravariance is not allowed for
6355 2007-10-31 Marek Safar <marek.safar@gmail.com>
6357 A fix for bug #337719
6358 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6361 2007-10-30 Marek Safar <marek.safar@gmail.com>
6363 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6365 2007-10-29 Marek Safar <marek.safar@gmail.com>
6367 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6370 2007-10-29 Raja R Harinath <rharinath@novell.com>
6372 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6374 2007-10-29 Marek Safar <marek.safar@gmail.com>
6376 A fix for bug #334652
6377 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6378 extension methods when we have not found the best candidate in normal
6381 2007-10-27 Marek Safar <marek.safar@gmail.com>
6383 * AssemblyInfo.cs: Keep up-to-date.
6385 2007-10-27 Marek Safar <marek.safar@gmail.com>
6387 * Makefile: Fixed generics compiler name.
6389 2007-10-27 Marek Safar <marek.safar@gmail.com>
6391 * lambda.test: removed, lambda parsing is done differently.
6393 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6395 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6397 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6399 2007-10-27 Marek Safar <marek.safar@gmail.com>
6401 * Makefile, *.sources : All C# compilers are in mcs folder.
6403 * *.cs: Use existing 2_1 define for smcs.
6405 2007-10-26 Marek Safar <marek.safar@gmail.com>
6407 A fix for bug #335847
6408 * assign.cs, expression.cs: Couple of changes to avoid creating a
6409 temporary variable for each object initializer assignment statement. It
6410 simplifies struct initialization too, otherwise two temporary variables
6412 Implemented optimization of redundant default element initializers.
6414 2007-10-25 Marek Safar <marek.safar@gmail.com>
6416 A fix for bug #336766
6417 * expression.cs (Class.CheckBase): Use generic name when method is
6420 2007-10-25 Marek Safar <marek.safar@gmail.com>
6422 A fix for bug #334737
6423 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6424 variable and not variable argument for prepared copies.
6426 2007-10-24 Marek Safar <marek.safar@gmail.com>
6428 A fix for bug #325110
6429 * class.cs, expression.cs, attribute.cs: Use open generic method when
6430 checking conditional attribute.
6432 2007-10-24 Marek Safar <marek.safar@gmail.com>
6434 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6435 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6436 FeatureIsNotAvailable.
6438 2007-10-24 Marek Safar <marek.safar@gmail.com>
6440 ** C# 3.0 Partial methods
6442 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6443 methods support. Because of member cache issue with generics only
6444 non-generics partial methods are fully supported.
6446 2007-10-23 Marek Safar <marek.safar@gmail.com>
6448 * class.cs, decl.cs: Rewrote member overloads check to cope with
6449 generics and to use member cache for member checking. It also improves
6450 performance and fixes remaining overloads issues.
6452 2007-10-20 Marek Safar <marek.safar@gmail.com>
6454 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6455 roottypes.cs, typemanager.cs:
6457 A member cache creation logic changed to add members immediately and
6458 not rely on fallback. The member cache is now only prefered way
6459 how to access and find type declaration members. It saves 5 MB of memory
6460 during MWF compilation and makes code ready for more optimizations and
6461 clean-ups, it's also a pre-requirement for partial methods.
6463 2007-10-18 Raja R Harinath <harinath@gmail.com>
6465 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6466 handling for generic parameters.
6468 2007-10-15 Marek Safar <marek.safar@gmail.com>
6470 * class.cs (FixedField): Removed redundant volatile check.
6472 2007-10-15 Marek Safar <marek.safar@gmail.com>
6474 * class.cs, decl.cs: Fixed overload members verification to do only one
6475 check per possible collision.
6477 2007-10-13 Marek Safar <marek.safar@gmail.com>
6479 A fix for bug #325478
6480 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6481 and create only one disposable flags container.
6483 2007-10-12 Marek Safar <marek.safar@gmail.com>
6485 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6486 * statement.cs (Fixed): Fixed variables cloning.
6488 2007-10-12 Marek Safar <marek.safar@gmail.com>
6490 A fix for bug #333342
6491 * class.cs (EventField): Don't mark value type event as synchronized.
6493 2007-10-12 Marek Safar <marek.safar@gmail.com>
6495 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6496 inference to identify best candidate method correctly.
6497 (ProperyExpr): A range variable is read only and cannot be modified.
6499 2007-10-11 Marek Safar <marek.safar@gmail.com>
6501 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6502 logic to identify best candidate method correctly.
6504 2007-10-11 Marek Safar <marek.safar@gmail.com>
6506 * location.cs (Equals, GetHashCode): Removed.
6508 2007-10-11 Marek Safar <marek.safar@gmail.com>
6510 * report.cs: Implemented message recorder. It is used mainly for lambda
6511 expressions to capture otherwise swallowed error messages.
6513 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6515 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6517 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6519 * expression.cs (MemberAccess): Always report lookup failure.
6521 * location.cs: Implemented Equals, GetHashCode.
6523 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6525 2007-10-10 Jb Evain <jbevain@novell.com>
6527 * codegen.cs: re-enable assembly version check.
6529 2007-10-09 Marek Safar <marek.safar@gmail.com>
6531 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6534 * namespace.cs (UsingAlias): Do correct version check.
6536 2007-10-08 Marek Safar <marek.safar@gmail.com>
6538 * expresison.cs, ecore.cs: Issue extension method error message when
6541 * rootcontext.cs: Added ISO_2 compiler mode option.
6543 2007-10-08 Marek Safar <marek.safar@gmail.com>
6545 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6548 2007-10-08 Marek Safar <marek.safar@gmail.com>
6550 * attribute.cs (GetString, GetBoolean): Work with both literal and
6553 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6554 Moved method overload specific methods to MethodGroupExpr.
6556 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6557 it should be less memory consuming.
6559 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6561 * codegen.cs: remove the assembly version check until the buildbot is
6564 2007-10-07 Jb Evain <jbevain@novell.com>
6566 * attribute.cs (Attribute.GetString): if the value
6567 expression is a StringConstant, return its string value.
6569 2007-10-07 Jb Evain <jbevain@novell.com>
6571 * typemanager.cs: add `assembly_version_attribute_type`.
6572 * codegen.cs: on attribute emission, check that the
6573 AssemblyVersionAttribute doesn't overflow.
6575 2007-10-05 Marek Safar <marek.safar@gmail.com>
6577 A fix for bug #324677
6578 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6579 parent container of a scope container with currently resolved one.
6581 2007-10-05 Marek Safar <marek.safar@gmail.com>
6583 A fix for bug #325534
6584 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6587 2007-10-05 Marek Safar <marek.safar@gmail.com>
6589 A fix for bug #327504
6590 * class.cs (Operator.Define): Refactored implicit and explicit user
6591 operator conversion rules.
6593 2007-10-05 Marek Safar <marek.safar@gmail.com>
6595 A fix for bug #327520
6596 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6598 2007-10-04 Marek Safar <marek.safar@gmail.com>
6600 A fix for bug #328022
6601 * class.cs (MethodData.Define): Use correct method to check whether
6602 a method implementents an accessor.
6604 2007-10-04 Marek Safar <marek.safar@gmail.com>
6606 A fix for bug #330069
6607 * statement.cs (Fixed.Resolve): Read the first array element only when
6608 an array is instantiated.
6610 2007-10-04 Marek Safar <marek.safar@gmail.com>
6612 * expression.cs, assign.cs, generics.cs: Print correct operator when
6613 compound assignment is used.
6615 2007-10-04 Marek Safar <marek.safar@gmail.com>
6617 A fix for bug #325841
6618 * expression.cs (ArrayAccess): Use full argument cloning only for
6619 string compound concatenation.
6621 2007-10-03 Marek Safar <marek.safar@gmail.com>
6623 A fix for bug #328774
6624 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6626 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6629 2007-10-03 Raja R Harinath <rharinath@novell.com>
6632 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6633 Event accessibility checks here. Remove some bogus code that
6634 accidently made GenericMethods work.
6635 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6637 2007-09-25 Marek Safar <marek.safar@gmail.com>
6639 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6641 * statement.cs (Block): Refactored AddVariable to allow error handling
6644 * generic.cs: New stub.
6646 2007-09-23 Marek Safar <marek.safar@gmail.com>
6648 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6651 2007-09-17 Marek Safar <marek.safar@gmail.com>
6653 * class.cs: Use partial container to record whether any partial part
6654 contains static field initializer and therefore default contructor has
6657 2007-09-14 Marek Safar <marek.safar@gmail.com>
6659 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6660 mono-list when only one of two partial parts has defined accessibility
6663 2007-09-14 Marek Safar <marek.safar@gmail.com>
6665 A fix for bug #82845
6667 * class.cs (TypeContainer): Set correct resolve context for all field
6670 2007-09-13 Marek Safar <marek.safar@gmail.com>
6672 * assign.cs: Fixed a crash when field is resolved twice with an error.
6674 * codegen.cs: Changed InFieldInitializer to be flag.
6676 * anonymous.cs, ecore.cs, expression.cs: Update after
6677 IsInFieldInitializer rename.
6679 * const.cs: Removed unused parameter.
6681 * class.cs: Changed the way how we resolve and emit field initializers.
6682 The field initilizers have to have access to contructor block to emit
6683 compiler generated code.
6685 2007-09-13 Marek Safar <marek.safar@gmail.com>
6687 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6688 generics use TypeContainer instead.
6690 2007-09-12 Marek Safar <marek.safar@gmail.com>
6692 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6694 * lambda.cs (ResolveParameters): Use more powerful
6695 InflateGenericArgument.
6697 * parameters.cs: Better exception message.
6699 2007-09-10 Marek Safar <marek.safar@gmail.com>
6701 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6702 correct expression block type.
6704 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6706 * expression.cs (Invocation): Extracted method group resolve to
6709 2007-09-07 Marek Safar <marek.safar@gmail.com>
6711 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6712 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6714 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6715 generic extension methods.
6717 2007-09-06 Marek Safar <marek.safar@gmail.com>
6719 A fix for bug #82676 (Do I get it right now?)
6720 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6721 object before a standard conversion is applied.
6723 2007-09-06 Marek Safar <marek.safar@gmail.com>
6725 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6728 2007-09-05 Marek Safar <marek.safar@gmail.com>
6730 A fix for bug #82676
6731 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6732 non-generic interface types.
6734 2007-09-05 Marek Safar <marek.safar@gmail.com>
6736 A fix for bug #82690
6737 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6739 2007-09-05 Marek Safar <marek.safar@gmail.com>
6741 A fix for bug #82571
6742 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6743 modifier for container based methods.
6745 2007-09-05 Marek Safar <marek.safar@gmail.com>
6747 A fix for bug #82676
6748 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6749 any interface-type T means to any of interface type T.
6751 2007-09-04 Marek Safar <marek.safar@gmail.com>
6753 * namespace.cs: We have 2 versions of System.Core assembly.
6755 2007-09-04 Marek Safar <marek.safar@gmail.com>
6757 A fix for bug #82652
6758 * class.cs (Class.GetClassBases): Compare types and not expressions.
6760 2007-09-04 Marek Safar <marek.safar@gmail.com>
6762 A fix for bug #82620
6763 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6764 actually never worked before.
6765 (IndexerAccess): Emit prepared arguments before they are modified.
6767 2007-09-04 Marek Safar <marek.safar@gmail.com>
6769 A fix for bug #82563
6770 * assign.cs: Revert wrong fix.
6772 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6774 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6775 Instead of ldelema/stdind we have to use temporary variables to handle
6776 cases like String.Concat (params string[]).
6778 2007-08-31 Marek Safar <marek.safar@gmail.com>
6780 * class.cs: EmitAttributes to Emit rename.
6782 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6784 (MemberCore.HasClsCompliantAttribute): Don't depend on
6785 GetClsCompliantAttributeValue execution.
6787 2007-08-31 Marek Safar <marek.safar@gmail.com>
6789 * anonymous.cs: Use shorter type prefix.
6791 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6794 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6795 variables when probing is on.
6797 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6798 unresolved variables.
6799 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6800 handle transparent identifiers.
6802 2007-08-26 Marek Safar <marek.safar@gmail.com>
6804 * attribute.cs (IsClsCompliant): Add nullable types test.
6806 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6808 * doc.cs : catch other types of exception than XmlException to
6809 report CS1570. Fixed bug #82565.
6811 2007-08-23 Marek Safar <marek.safar@gmail.com>
6813 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6814 The number of delegate parameters has to match.
6815 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6818 2007-08-21 Marek Safar <marek.safar@gmail.com>
6820 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6821 to fix problem with private arguments.
6823 2007-08-20 Marek Safar <marek.safar@gmail.com>
6825 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6827 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6829 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6830 empty. Add cloning suport.
6832 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6834 2007-08-20 Marek Safar <marek.safar@gmail.com>
6836 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6837 to create EmptyCast. It handles EmptyConstantCast specialization for
6840 2007-08-18 Marek Safar <marek.safar@gmail.com>
6842 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6843 (EmitArrayArgument): One routine for array arguments.
6844 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6846 2007-08-17 Marek Safar <marek.safar@gmail.com>
6848 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6850 2007-08-17 Marek Safar <marek.safar@gmail.com>
6852 * anonymous.cs: MemberLookupFinal update.
6854 * class.cs (ConstructorInitializer): Is expression based.
6856 * delegate.cs: MethodGroupExpr update.
6858 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6860 (Error_MemberLookupFailed): Customizable error override.
6861 (MethodGroupExpr): Keep queried type for later usage.
6862 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6865 * expression.cs: Error_MemberLookupFailed refactoring.
6866 (New.DoResolve): Resolve as much as possible.
6867 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6868 customization for invalid member types.
6870 * statement.cs: MethodGroupExpr update.
6872 2007-08-16 Marek Safar <marek.safar@gmail.com>
6874 * modifier.cs (Check): Check all modifiers and not only accessibility
6877 2007-08-16 Marek Safar <marek.safar@gmail.com>
6879 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6880 type and not an expression.
6882 2007-08-16 Marek Safar <marek.safar@gmail.com>
6884 * statement.cs (Catch.Clone): Type and variable can be null.
6886 2007-08-16 Marek Safar <marek.safar@gmail.com>
6888 A fix for bug #81979
6889 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6890 I am really not sure whether this is the best fix.
6892 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6895 2007-08-14 Marek Safar <marek.safar@gmail.com>
6897 ** C# 3.0 Object and collection initializers (major re-write)
6899 * assign.cs (DoResolve): Initializers are not assign related.
6901 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6902 used during collection or object initialization.
6904 * expression.cs (Error_InvalidArguments): Add initializers specific
6905 messages. More will come later because it requires some general
6907 (New.DoResolve): Better error handling for unsafe types.
6908 (EmptyExpressionStatement): New class.
6909 (ElementInitializer): An object initializer expression.
6910 (CollectionElementInitializer): A collection initializer expression.
6911 (CollectionOrObjectInitializers): A block of object or collection
6913 (NewInitialize): New expression with element/object initializers.
6915 * statement.cs: Reverted object/collection initializer hacks.
6917 * typemanager.cs (CSharpName): Filter __arglist type.
6919 2007-08-09 Marek Safar <marek.safar@gmail.com>
6921 ** C# 3.0 Anonymous Types (update to the latest standard)
6923 * expression.cs (Binary.ResolveOperator): Threat all null based types
6925 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6926 (AnonymousTypeParameter): Updated.
6928 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6929 (AnonymousTypeClass): New anonymous type container.
6931 * class.cs (AddField): Return operation result.
6933 * generic.cs: Another empty TypeArguments overload.
6935 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6936 are stored at top of normal hierarchy.
6938 * typemanager.cs (CSharpName): Filter anonymous types.
6940 2007-08-09 Marek Safar <marek.safar@gmail.com>
6942 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6943 as single Concat call. How could we miss that :-(
6945 2007-08-08 Marek Safar <marek.safar@gmail.com>
6947 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6949 2007-08-07 Miguel de Icaza <miguel@novell.com>
6951 * expression.cs: Fix the previous commit, the creation of the
6952 arguments array list needs also to be conditional on the arguments
6955 * class.cs: Add a little bit of help to help narrow down problems.
6957 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6958 not try to copy in that case.
6960 * driver.cs: When building SMCS, include a new different set of
6961 default assemblies here. Do this here so we can control whether
6962 to include the default assemblies with /noconfig.
6964 2007-08-03 Marek Safar <marek.safar@gmail.com>
6966 A fix for bug #81979
6967 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6970 2007-08-03 Marek Safar <marek.safar@gmail.com>
6972 A fix for bug #82300
6974 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6975 we are in probing scope.
6977 2007-08-03 Marek Safar <marek.safar@gmail.com>
6979 A fix for bug #82301
6981 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6982 (Statement.CloneTo): Clone and not map children blocks.
6984 2007-08-03 Marek Safar <marek.safar@gmail.com>
6986 A fix for bug #82299
6988 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6991 * statement.cs (Statement.CloneTo): Clone variables before statements
6992 to allow remaping of local variables.
6994 2007-08-03 Marek Safar <marek.safar@gmail.com>
6996 A fix for bug #82296
6999 * report.cs: Log crash details for future clone problems.
7001 * statement.cs (Return.Clone): Don't clone non-existent expression.
7003 2007-08-03 Raja R Harinath <harinath@gmail.com>
7005 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
7006 (Class.AddBasesForPart): Move CS0537 check here from ...
7007 * cs-parser.jay (class_declaration): ... here. Move calling of
7008 'AddBasesForPart' to ...
7009 (class_bases): ... here.
7010 (struct_declaration, interface_declaration): Update to changes.
7012 2007-08-02 Marek Safar <marek.safar@gmail.com>
7014 A fix for bug #81923
7016 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
7017 conversion is allowed.
7019 2007-08-02 Marek Safar <marek.safar@gmail.com>
7021 A fix for bug #81564
7023 * ecore.cs (EventExpr): Add IsBase handling.
7025 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
7028 2007-08-02 Raja R Harinath <harinath@gmail.com>
7030 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
7031 * cs-parser.jay: Some whitespace cleanups.
7032 (current_delegate): New.
7034 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
7035 a dummy code block, and use 'type_name' instead of 'member_name'.
7036 (interface_declaration, class_declaration): Likewise.
7037 (delegate_declaration): Likewise. Rearrange slightly and use
7039 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
7040 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
7042 2007-08-02 Marek Safar <marek.safar@gmail.com>
7044 A fix for bug #82039
7046 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
7049 * typemanager.cs (CSharpName): Split to string overload.
7051 2007-08-02 Marek Safar <marek.safar@gmail.com>
7054 * report.cs: Updated warning CS0472.
7056 2007-08-01 Marek Safar <marek.safar@gmail.com>
7058 A fix for bug #82181
7060 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
7062 2007-08-01 Marek Safar <marek.safar@gmail.com>
7064 A fix for bug #82277
7065 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
7067 2007-08-01 Marek Safar <marek.safar@gmail.com>
7069 ** C# 3.0 Type Inference (major bits are working)
7071 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
7072 (.ImplicitStandardConversionExists): Uses compatible.
7073 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
7074 (.InferReturnType): New method.
7075 (.Compatible): Refactored.
7076 (.ResolveParameters): Uses factory to create resolved parameters.
7077 (.CompatibleMethod): Add probing mode support.
7078 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
7079 clearly distinguish between 2 different operations.
7080 (LambdaMethod): Moved to lambda.cs.
7081 (AnonymousMethod): Removed unused fields and methods.
7082 (AnonymousDelegate): Simplified.
7084 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
7086 * convert. cs (ImplicitConversionStandard): Compatible works differently.
7088 * delegate.cs (Delegate): New mehods to reduce code duplication.
7089 (.GetConstructor): New method.
7090 (.GetInvokeMethod): New method.
7091 (DelegateCreation): Updated.
7093 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
7095 (OverloadResolve): Made probing little bit faster.
7097 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
7100 * generic.cs (TypeInferenceContext): Dummy implementation.
7102 * iterators.cs: Updated after Resolve/Define rename.
7104 * lambda.cs (LambdaExpression)
7105 (.ResolveParameters): Handles both type of arguments and type inference too.
7107 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
7108 (InflateTypes): Updated.
7110 * support.cs (InflateTypes): Changed signature and updated.
7112 * typemanager.cs (LookupMemberCache): Better dynamic type check.
7113 (MemberLookup_FindMembers): More MS tricks.
7114 (GetParameterData): Ditto.
7115 (GetDelegateParameters): Uses quick path for dynamic types.
7117 2007-08-01 Marek Safar <marek.safar@gmail.com>
7119 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7122 2007-07-31 Marek Safar <marek.safar@gmail.com>
7124 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7127 2007-07-26 Jb Evain <jbevain@novell.com>
7129 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7130 which takes a boolean 'report_errors', similar to the GetMethod.
7131 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7132 in .net 2.1, do not report errors here.
7134 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7135 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7136 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7139 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7140 of the type InternalsVisibleToAttribute before the first call
7141 to CoreLookupType which is allowed to fail (third boolean parameter
7142 to true). Because, during the resolution for a type that is not
7143 immediately found, we try to check if the type is not defined in
7144 a friend assembly, and to do so, we need the
7145 InternalVisibleToAttribute.
7147 2007-07-23 Miguel de Icaza <miguel@novell.com>
7149 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7150 feature that allows structs to be compared against null and inline
7151 the result as true or false.
7153 Notice that the same code is not permitted inside a generic block
7154 of code that would do:
7156 class Foo<T> where T : struct {
7163 It is only allowed if the type of T is not bound (no where
7164 clause). In my opinion, this CSC 2 behavior is broken but people
7165 seem to be using it (IronRuby does, a few bug reports on bugzilla
7166 have it and some people have complained about it).
7168 All of the users that depend on this behavior have code that is
7171 * report.cs (Warning, Error): make these take object arguments,
7172 not strings, as that allows us to take advantage of Format.
7174 2007-07-20 William Holmes <billholmes54@gmail.com>
7176 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7177 Left member variable for the Count.
7178 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7179 MemberName.CountTypeArguments to avoid a NRE.
7181 This code is contributed under the MIT X11 license
7183 2007-07-18 Marek Safar <marek.safar@gmail.com>
7185 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7187 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7189 * doc.cs : generic method arguments are written as ``x while generic
7190 type arguments are `x. Combined with the previous change, fixed bug
7193 2007-07-18 Raja R Harinath <rharinath@novell.com>
7196 * expression.cs (Binary.ResolveOperator): When converting
7197 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7199 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7201 * doc.cs : when T: or whatever x: is specified, it does not really
7202 check the doc comment's syntax correctness. Fixed bug #82006.
7204 2007-07-18 Marek Safar <marek.safar@gmail.com>
7206 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7207 LambdaExpression better.
7209 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7211 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7213 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7214 as it can be generated.
7216 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7219 * lambda.cs (LambdaExpression): Refactored to share same code with
7220 AnonymousMethodExpression.
7222 2007-07-17 Marek Safar <marek.safar@gmail.com>
7224 * anonymous.cs (MakeName): Include host name for easier debugging.
7225 (LambdaMethod): New class for lambda spcecific stuff.
7227 * attribute.cs: Set EmitContext return type.
7229 * class.cs: Set EmitContext return type.
7231 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7232 with null/void meaning.
7234 * iterators.cs (ContainerType): Implemented.
7236 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7238 * statement.cs (Return): Updated to lambda expressions.
7239 (Block.CloneTo): Parent can be null.
7241 2007-07-13 Marek Safar <marek.safar@gmail.com>
7243 A fix for bug #81917
7244 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7246 * class.cs (FixedField): Check whether field is in unsafe scope.
7248 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7249 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7251 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7254 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7256 2007-07-13 Marek Safar <marek.safar@gmail.com>
7258 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7259 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7262 2007-07-13 Marek Safar <marek.safar@gmail.com>
7264 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7266 2007-07-13 Marek Safar <marek.safar@gmail.com>
7268 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7269 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7271 * codegen.cs(EmitContext): Add ProbingMode flag.
7273 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7275 * driver.cs: For now set both warning values.
7277 * ecore.cs (SimpleName): Name is readonly.
7278 (MethodGroup.OverloadResolve): One quick path for probing.
7280 * expression.cs (Unary): Set Oper r/o.
7281 (Binary): Set Oper r/o.
7282 (ParameterReference): Set few instance variables as r/o.
7283 (ParameterReference.DoResolveBase): Don't capture aruments when
7285 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7286 (Arglist): arguments are private.
7287 (SizeOf): type is private and r/o.
7288 (MemberAccess): arguments are private.
7290 * report.cs: Enhanced reporting on/off capabilities.
7292 * lambda.cs: Uses ec.IsInProbingMode.
7293 (ContextualReturn): Derives from return.
7295 * rootcontext.cs: For now set both warning values.
7297 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7299 (Return.Resolve): Don't die immediately.
7300 (Block.Resolve): Speed-up probing.
7301 (Block.CloneTo): Clone only child blocks.
7303 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7305 * iterators.cs: reverted Miguel's latest change (r81925) as it
7306 breaks the build in System.
7308 2007-07-13 Miguel de Icaza <miguel@novell.com>
7310 * iterators.cs (Yield.CheckContext): Check for the iterator type
7311 also here as we can call into Yield even in codepaths that are not
7313 (MethodOrOperator is the only path that was checked).
7315 In addition to the standard check, use a more specific check for
7316 constructors to report a more verbose error.
7318 2007-07-12 Miguel de Icaza <miguel@novell.com>
7320 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7321 report the warning and continue
7323 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7324 values on the stack on the call to Emit. Use EmitStatement if
7325 possible, or using Emit + Pop if not possible. Fixes #82064
7327 2007-07-12 Raja R Harinath <rharinath@novell.com>
7329 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7330 avoid try...finally in some cases.
7332 2007-07-10 Marek Safar <marek.safar@gmail.com>
7334 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7336 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7337 instead of method. Re-use standard error handling.
7338 (ConstructorInitializer.Emit): Simplified.
7340 * delegate.cs: Updated after Invocation.EmitCall change.
7342 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7343 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7344 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7345 method and don't permanently changing input arguments.
7346 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7347 is resolved it has one of the candidates is the best one which is later
7348 used to emit. Removed a few unused method.
7349 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7351 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7352 (Binary.ResolveOperator): Ditto.
7353 (ConditionalLogicalOperator.DoResolve): Ditto.
7354 (Invocation): Uses method group.
7355 (Invocation.DoResolve): Simplified.
7356 (Invocation.EmitCall): Removed useless is_static.
7357 (Invocation.Emit): Delegate to method group.
7358 (Invocation.EmitStatement): Simplified.
7359 (New): Uses method group.
7360 (MemberAccess.DoResolve): Don't destroy original expression.
7362 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7364 2007-07-04 Marek Safar <marek.safar@gmail.com>
7366 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7369 * lambda.cs: Add custom error message type.
7371 2007-07-03 Marek Safar <marek.safar@gmail.com>
7373 * lambda.cs: Simplified little bit.
7375 * parameter.cs: Introduced ImplicitLambdaParameter.
7376 (Parameters.CreateFullyResolved): New factory instead of ctor.
7380 * delegate.cs: Updated parameter creation.
7382 2007-07-03 Marek Safar <marek.safar@gmail.com>
7384 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7387 * generic.cs: Synchronized with gmcs.
7389 2007-07-03 Marek Safar <marek.safar@gmail.com>
7391 * class.cs (Indexer): Check return type as soon as possible.
7393 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7396 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7398 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7400 * parameter.cs (Parameter): Use expression type when it is available.
7402 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7403 method modifier for the first parameter only.
7405 2007-06-24 Marek Safar <marek.safar@gmail.com>
7407 A fix for bug #81938
7408 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7410 * constant.cs: Tide up an exception message.
7412 2007-06-22 Marek Safar <marek.safar@gmail.com>
7414 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7415 an uninitialized variable is used.
7417 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7419 2007-06-22 Marek Safar <marek.safar@gmail.com>
7421 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7422 not found error handling.
7424 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7426 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7427 (ArrayCreation.DoResolve): Simplified.
7428 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7429 its own resolve process.
7430 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7432 2007-06-20 Marek Safar <marek.safar@gmail.com>
7434 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7437 2007-06-20 Marek Safar <marek.safar@gmail.com>
7439 * cs-tokenizer.cs: Removed var related stuff.
7441 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7442 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7443 a type and a keyword at same time.
7445 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7448 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7449 implicitly typed arrays, more changes will follow.
7451 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7453 2007-06-19 Marek Safar <marek.safar@gmail.com>
7455 * ecore.cs (VarExpr): Removed Handled field.
7457 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7458 build-in assign functionality.
7459 (ForEach.Resolve): Removed all implicitly typed local variable code and
7461 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7462 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7464 2007-06-18 Marek Safar <marek.safar@gmail.com>
7466 * assign.cs: Removed implicitly typed local variable check.
7468 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7469 referencing implicitly typed local variable.
7470 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7473 * statement.cs (Fixed): Removed unsupported implicitly typed local
7476 2007-06-15 Marek Safar <marek.safar@gmail.com>
7478 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7480 2007-06-14 Marek Safar <marek.safar@gmail.com>
7482 A fix for bugs #81855 and #76274
7483 * attribute.cs (AttachTo): Always set owner for global attributes to
7486 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7489 * cs-parser.jay: Assembly and module attributes must precede all other
7490 elements except using clauses and extern alias declarations.
7492 2007-06-13 Marek Safar <marek.safar@gmail.com>
7494 A fix for bug #81748
7496 * expression.cs: More checks for non ISO-1 features.
7498 2007-06-12 Marek Safar <marek.safar@gmail.com>
7500 A fix for bug #81807
7501 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7502 present inside switch statement and it is required by nullable check.
7504 2007-06-12 Marek Safar <marek.safar@gmail.com>
7506 A fix for bug #81840
7507 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7508 when type matching fails.
7510 * namespace.cs: Tiny error message change.
7512 2007-06-12 Marek Safar <marek.safar@gmail.com>
7514 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7515 reporting. Added automatic property check.
7517 * class.cs: Updated after CheckAbstractAndExtern relocation.
7518 (AEventPropertyAccessor.GetSignatureForError): Customized.
7520 2007-06-11 Marek Safar <marek.safar@gmail.com>
7522 * class.cs (DefineBaseTypes): Base type can be undefined.
7524 * ecore.cs (TypeLookup): Minor refactoring.
7525 (DoResolveAsTypeStep): Removed redundant check.
7527 * namespace.cs (Lookup): Removed redundant check.
7529 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7530 ResolveAsTypeTerminal step.
7531 (BootstrapCorlib_*): Simplified.
7532 (PopulateCoreType): Core types can be now external.
7534 2007-06-07 Marek Safar <marek.safar@gmail.com>
7536 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7538 (InferTypeArguments): Infers anonymous expression type arguments.
7539 (Compatible): Split to Compatible and InferTypeArguments.
7541 * lambda.cs: Updated.
7543 2007-06-08 Marek Safar <marek.safar@gmail.com>
7545 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7547 2007-06-07 Raja R Harinath <harinath@gmail.com>
7549 Fix #80477, cs0135-2.cs, cs0135-3.cs
7550 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7551 names to the "known" variables list.
7552 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7553 parameter names are also "known".
7554 (Block.CheckError136): Remove.
7555 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7558 2007-06-07 Marek Safar <marek.safar@gmail.com>
7560 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7562 2007-06-06 Marek Safar <marek.safar@gmail.com>
7564 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7565 internal error not an user error.
7567 * expression.cs (IsApplicable): Refactored to make debugging easier.
7569 * support.cs: More tricks for non-mono runtimes.
7571 * typemanager.cs (CoreLookupType): Made public.
7572 (InitSystemCore): All linq specific stuff moved to linq.cs
7574 2007-06-05 Marek Safar <marek.safar@gmail.com>
7576 * typemanager.cs (CSharpSignature): One more missing build-in types
7578 More tricks for non-mono runtime.
7580 2007-06-05 Raja R Harinath <harinath@gmail.com>
7582 * statement.cs (Block.CheckError136_InParents): Remove.
7583 (Block.AddVariable): Use GetParameterInfo instead.
7584 (ToplevelBlock.ProcessArguments): Likewise.
7586 2007-06-04 Raja R Harinath <rharinath@novell.com>
7588 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7590 (ToplevelBlock.GetParameterInfo): Split out of ...
7591 (ToplevelBlock.GetParameterRefernce): ... this.
7592 (ToplevelBlock.ParameterMap): Remove.
7593 * expression.cs (ParameterReference): Update to use
7594 ToplevelParameterInfo.
7596 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7599 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7600 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7602 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7603 (ToplevelBlock.ProcessParameters) ... here.
7604 (ToplevelBlock..ctor): Invoke it.
7606 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7609 * statement.cs (IKnownVariable): New interface.
7610 (LocalInfo): Implement it.
7611 (ToplevelParameterInfo): New class.
7612 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7613 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7614 GetKnownVariableInfo.
7616 2007-06-03 Raja R Harinath <harinath@gmail.com>
7618 Partly speed up CS0136 error checks.
7619 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7620 'recurse' parameter.
7621 (Block.DoCheckError136): Only check errors in parameters. Move
7622 local variable checks ...
7623 (Block.AddVariable): ... here, and ...
7624 (ToplevelBlock.ResolveMeta): ... here.
7626 2007-06-02 Raja R Harinath <harinath@gmail.com>
7628 * statement.cs (Block.IsChildOf): Remove.
7630 * statement.cs (Statement.Clone): Move special case code ...
7631 (Block.CloneTo): ... here.
7633 2007-05-29 Raja R Harinath <rharinath@novell.com>
7635 * statement.cs (ToplevelBlock.container): Remove field. It's
7636 redundant with 'Parent'.
7637 (ToplevelBlock.ContainerBlock): Remove accessor.
7638 (ToplevelBlock..ctor): Update to changes. Register anonymous
7639 child with parent here, ...
7640 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7642 (start_anonymous): Don't save current_block.
7643 (top_current_block): Remove.
7645 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7646 (Block.Resolve): Update to changes.
7647 (Block..ctor): Move setting of "correct" 'Toplevel'
7648 and 'Explicit' fields to ...
7649 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7651 2007-05-27 Raja R Harinath <harinath@gmail.com>
7654 * statement.cs (Block.Implicit): Remove.
7655 (Block): Update to changes.
7656 * flowanalysis.cs: Likewise.
7658 Mildly speed up CheckInvariantMeaningInBlock
7659 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7660 Recursively call AddKnownVariable to all enclosing blocks.
7661 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7662 Remove recursive calls.
7663 (Block): Update to changes.
7665 New ExplicitBlock invariants
7666 * statement.cs (Block.Explicit): New field. It points to the
7667 immediately enclosing non-implicit block.
7668 (Block..ctor): Maintain the invariant.
7669 * cs-parser.jay: Take advantage of invariant.
7671 Introduce ExplicitBlock
7672 * statement.cs (ExplicitBlock): New.
7673 (ToplevelBlock): Derive from it.
7674 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7676 (Block.Implicit): Update to changes.
7677 * cs-parser.jay: Update to changes.
7680 * codegen.cs (EmitContext.IsLastStatement): Remove.
7681 * statement.cs (Block.DoEmit): Update to changes.
7683 2007-05-25 Raja R Harinath <rharinath@novell.com>
7685 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7686 modifying current_block directly.
7688 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7690 * class.cs: Implemented automatic properties (C# 3.0)
7691 Thanks to Marek for the help.
7693 2007-05-23 Raja R Harinath <rharinath@novell.com>
7695 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7696 variable as assigned, note also that all its components are
7698 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7700 2007-05-19 Marek Safar <marek.safar@gmail.com>
7702 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7703 member is marked as compiler generated.
7705 * decl.cs (MemberCore): Refactored ModFlags into property.
7707 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7708 (Check): Check only accessibility modifiers.
7710 2007-05-18 Raja R Harinath <rharinath@novell.com>
7712 Track all assignable slots in one bit array
7713 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7714 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7715 logic from VariableMap constructor here. Use the same 'offset'
7716 variable that's later used for computing offsets of local
7718 * flowanalysis.cs (UsageVector.parameters): Remove.
7719 (UsageVector): Update to changes.
7720 (VariableMap): Remove.
7722 Avoid creating ParameterMap in every block
7723 * statement.cs (Block.ParameterMap): Move ...
7724 (ToplevelBlock.ParameterMap): ... here.
7725 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7727 * flowanalysis.cs (FlowBranching.param_map): Remove.
7728 (FlowBranching.UsageVector): Update to changes.
7729 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7731 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7733 * expression.cs (ParameterReference): Distinguish between block
7734 where parameter was referenced and declared.
7736 2007-05-18 Marek Safar <marek.safar@gmail.com>
7738 * flowanalysis.cs, statement.cs: Put back improved error handling.
7740 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7744 Imporved object and collection initialization (C# 3.0).
7746 2007-05-15 Marek Safar <marek.safar@gmail.com>
7748 A fix for bug #81380
7749 * expression.cs (Is.DoResolve): Only value types have constant `is'
7752 2007-05-15 Raja R Harinath <rharinath@novell.com>
7754 * statement.cs (ToplevelBlock.child): Remove.
7756 2007-05-15 Raja R Harinath <harinath@gmail.com>
7758 Rationalize ResolveMeta: refactoring
7759 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7760 out constant handling code into ...
7761 (Block.DoResolveConstants): ... this.
7763 Rationalize ResolveMeta: kill local_map
7764 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7765 (Block.AssignableSlots): New.
7766 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7767 for locals -- move code from VariableMap here. Avoid unnecessary
7769 * flowanalysis.cs (FlowBranching.local_map): Remove.
7770 (FlowBranching..ctor): Use Block.AssignableSlots.
7771 (VariableMap): Remove unused constructors.
7773 2007-05-11 Raja R Harinath <rharinath@novell.com>
7775 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7777 2007-05-11 Marek Safar <marek.safar@gmail.com>
7779 * typemanager.cs (IsFriendAssembly): Should not be called for building
7782 2007-05-09 Marek Safar <marek.safar@gmail.com>
7784 * literal.cs (NullConstant): Print null in all cases.
7786 * expression.cs (Binary.ResolveOperator): Implemented delegate
7787 comparison based on C# 2.0 changes.
7789 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7791 This code is contributed under the MIT X11 license
7793 The following enables support for several C# 3.0 language features:
7795 * cs-tokenizer.cs: Added support for the "var" keyword.
7797 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7798 Added VarExpr class to facilitate type inferencing.
7800 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7801 to support anonymous types.
7803 * assign.cs: Added support for type inferencing and initialization.
7805 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7807 * expression.cs: Added implicit array support to ArrayCreation.
7808 Added 5 types and 1 interface:
7810 IInitializable Implementing classes can inject initializing
7811 statements after object instantiation.
7813 Initializer Stores data for object initialization.
7815 AnonymousType An expression for anonymous types.
7817 AnonymousTypeParameter Stores data about an anonymous type's field.
7819 NewInitialize An expression for object initialization.
7821 CollectionInitialize An expression for collection initialization.
7823 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7826 2007-05-06 Marek Safar <marek.safar@gmail.com>
7828 A fix for bug #81500
7829 * cs-tokenizer.cs: Add special handling for coalescing operator.
7831 2007-05-06 Marek Safar <marek.safar@gmail.com>
7833 A fix for bug #81529
7834 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7835 its value from base class until it is redefined.
7837 2007-05-02 Raja R Harinath <rharinath@novell.com>
7839 Fix regression in cs0631-3.cs
7840 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7841 fallback. Make error fallback catch more cases.
7843 2007-05-01 Miguel de Icaza <miguel@novell.com>
7845 * cs-parser.jay: Allow parameters in operator declarations to have
7848 2007-04-27 Miguel de Icaza <miguel@novell.com>
7850 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7853 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7854 inside the ContextualReturn, it does not have to be an
7855 ExpressionStatement.
7857 2007-04-24 Miguel de Icaza <miguel@novell.com>
7859 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7862 2007-04-23 Miguel de Icaza <miguel@novell.com>
7864 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7865 method in two methods: ResolveNoDefine and Resolve.
7867 ResolveNoDefine will stop just after ResolveTopBlock has been
7870 Resolve will then continue by creating a method and issuing the
7871 call to method.Define ().
7873 (AnonymousMethod): Split and implement the new Resolve and
7874 ResolveNoDefine as well.
7876 * lambda.cs (LambdaExpression): Split the anonymous method
7877 resolution code into a separate routine (CoreCompatibilityTest)
7878 from DoCompatibleTest.
7880 (LambdaExpression.TryBuild): New method, this method tries to
7881 build the LambdaExpression with the given set of types to be used
7882 as the types for the various parameters of the lambda expression.
7884 If the compilation succeed with the given types, the infered type
7885 of the Anonymous method is returned, otherwise null is returned.
7887 2007-04-23 Marek Safar <marek.safar@gmail.com>
7889 A fix for bug #81414
7890 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7892 2007-04-22 Miguel de Icaza <miguel@novell.com>
7894 * cs-tokenizer.cs: Change various identifiers here from the
7895 camelCasing to the recommended Linux-like style for instance
7896 variables from the Coding Guidelines.
7898 2007-04-19 Martin Baulig <martin@ximian.com>
7901 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7902 System.Enum to System.ValueType.
7904 2007-04-13 Martin Baulig <martin@ximian.com>
7906 Rewrote implicit reference conversions. We need to distinguish
7907 between implicit reference conversions (13.1.4) and implicit
7908 boxing conversions (13.1.5).
7910 According to the spec, there's an an implicit conversion
7911 "From a one-dimensional array-type S[] to IList<T> and base
7912 interfaces of this interface, provided there is an implicit
7913 reference conversion from S to T." Note that this does not
7914 include boxing conversions.
7917 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7918 (Convert.ImplicitReferenceConversion): Split into
7919 ImplicitReferenceConversionCore() and
7920 ImplicitBoxingConversionExist().
7921 (Convert.ImplicitReferenceConversionExists): Use the new
7922 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7924 2007-04-12 Martin Baulig <martin@ximian.com>
7926 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7927 `TypeManager.null_type' checks up to the top of the method.
7929 2007-04-11 Marek Safar <marek.safar@gmail.com>
7931 A fix for bug #81350
7932 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7935 2007-04-11 Martin Baulig <martin@ximian.com>
7937 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7938 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7939 to make this work for generic classes; fixes #79561.
7941 2007-04-11 Martin Baulig <martin@ximian.com>
7943 * expression.cs (As): Add support for nullable types; fixes #79371.
7945 2007-04-11 Martin Baulig <martin@ximian.com>
7947 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7948 `type.FullName' is null; fixes #80243.
7950 2007-04-11 Martin Baulig <martin@ximian.com>
7952 * expression.cs (Invocation.IsApplicable): Don't modify the method
7953 if type inference succeeded, but the method was not applicable.
7956 2007-04-10 Marek Safar <marek.safar@gmail.com>
7958 A fix for bug #81324
7959 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7960 internal and external namespaces containers.
7962 2007-04-10 Martin Baulig <martin@ximian.com>
7964 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7965 TypeManager.DropGenericMethodArguments() so we also call
7966 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7968 2007-04-10 Martin Baulig <martin@ximian.com>
7970 * iterators.cs (Iterator.CreateIterator): Don't crash if
7971 `method.ReturnType' is null. This happens if something went wrong
7972 while resolving that typ (we already reported an error in this case).
7974 2007-04-10 Martin Baulig <martin@ximian.com>
7976 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7977 generic interfaces; report the CS0144 directly.
7979 2007-04-10 Martin Baulig <martin@ximian.com>
7981 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7982 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7984 2007-04-10 Martin Baulig <martin@ximian.com>
7986 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7988 2007-04-09 Raja R Harinath <rharinath@novell.com>
7991 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7992 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7995 * statement.cs (For.Resolve): If resolution fails, use
7998 2007-04-08 Marek Safar <marek.safar@gmail.com>
8000 * anonymous.cs (MakeName): Make faster and zero-based.
8001 (VerifyExplicitParameterCompatibility): Back to mode where generic
8002 parameter is ignored.
8003 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
8005 * class.cs (EmitType): Method can emit another new method.
8007 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
8009 * driver.cs: Updated.
8011 * lambda.cs: Reuse predefined empty parameters.
8013 * parameter.cs: Updated
8015 * support.cs: Implemented InflateTypes.
8017 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
8018 (InitSystemCore): Introduced to isolate 3.0 dependencies.
8020 2007-04-03 Martin Baulig <martin@ximian.com>
8024 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
8025 version of TypeManager.IsOverride() which also works with generic
8028 2007-04-03 Martin Baulig <martin@ximian.com>
8033 (Convert.ExplicitReferenceConversion): We need to cast when
8034 converting from IList<T> to S[].
8036 2007-04-01 Marek Safar <marek.safar@gmail.com>
8038 * decl.cs (FindExtensionMethods): Consider all candidates with same name
8041 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
8043 2007-03-31 Marek Safar <marek.safar@gmail.com>
8045 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
8046 argument and return type inferring.
8048 * codegen.cs (InferReturnType): Flag whether return can be inferred.
8049 (ReturnType): Turned to property.
8051 * statement.cs (Return): Implemented return type inferring.
8053 * support.cs (ReflectionParameters): Use local types if possible.
8055 2007-03-30 Raja R Harinath <rharinath@novell.com>
8057 * flowanalysis.cs (FlowBranching.Reachability): Remove.
8058 (FlowBranching.UsageVector): Update to changes.
8060 Prepare to kill 'Reachability'
8061 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
8062 argument of constructor.
8064 2007-03-29 Raja R Harinath <rharinath@novell.com>
8066 Prepare to kill 'Reachability'
8067 * flowanalysis.cs (UsageVector.is_unreachable): New.
8068 (UsageVector): Update to maintain 'is_unreachable' in parallel to
8069 'reachability', and verify they're consistent.
8072 * expression.cs (New.EmitStatement): Handle type parameters here too.
8074 2007-03-29 Martin Baulig <martin@ximian.com>
8079 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
8080 CompilerGeneratedClass.
8081 (ScopeInfo.EmitScopeInstance): Make this protected.
8082 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
8083 `ec.CurrentAnonymousMethod.Scope == Scope'.
8085 * statement.cs (Block.ScopeInfo): Make this a property.
8087 2007-03-27 Raja R Harinath <harinath@gmail.com>
8089 Prepare to kill 'Reachability'
8090 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
8091 (FlowBranching.UsageVector.Reachability): Remove property.
8092 (FlowBranching.UsageVector.IsUnreachable): New property.
8093 (FlowBranching.UsageVector.ResetBarrier): New.
8094 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
8095 * codegen.cs, statement.cs: Update to changes.
8097 2007-03-27 Martin Baulig <martin@ximian.com>
8102 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
8105 2007-03-26 Raja R Harinath <rharinath@novell.com>
8107 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
8108 instead of TriState. Remove all mention of TriState.
8110 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
8111 replaced by a boolean. Add boolean 'is_unreachable' field, check
8112 and maintain invariants.
8114 2007-03-25 Marek Safar <marek.safar@gmail.com>
8116 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8118 2007-03-25 Marek Safar <marek.safar@gmail.com>
8120 * expression.cs: Stop using obsolete 2.0 opcodes.
8122 2007-03-25 Marek Safar <marek.safar@gmail.com>
8124 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8125 one of the latests Martin's fixes.
8127 2007-03-23 Miguel de Icaza <miguel@novell.com>
8129 * expression.cs: On BigEndian systems, swap the bytes, temporary
8130 solution until we get a new bitconverter class.
8132 2007-03-23 Martin Baulig <martin@ximian.com>
8136 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8137 "Method" and "Method`1". Normally, a cache lookup is done on the
8138 "Method" form (ie. without the generic arity), but this one makes
8139 lookups on the full form work as well.
8141 2007-03-22 Raja R Harinath <rharinath@novell.com>
8143 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8146 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8148 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8149 ordered_member_list, to TypeBuilder to store members to be defined
8150 in the order they were parsed in.
8151 - ordered_explicit_member_list contains all properties indexers
8152 and methods that are defined as explicit implementation of an
8153 interface or base class.
8154 - ordered_member_list contains all properties indexers and methods
8155 that are not defined as explicit implementation of an interface
8158 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8159 functionality in these removed classes has been replaced with
8160 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8161 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8163 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8164 to CheckForDuplications inside GetMethod and SetMethod Define Method
8165 to handle method property and indexer name conflicts.
8169 All code is contributed under the MIT/X11 license.
8171 2007-03-20 Martin Baulig <martin@ximian.com>
8173 * class.cs (TypeContainer.Interfaces): Removed; they're now
8174 included in `TypeContainer.Types'.
8176 2007-03-20 Martin Baulig <martin@ximian.com>
8178 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8180 * class.cs (TypeContainer.CreateType): New public method. This is
8181 now called before DefineType() to create the TypeBuilders.
8182 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8183 has already been created by CreateType().
8184 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8185 don't resolve our base classes here; this has been moved into
8186 DefineBaseTypes(). We're now called from CreateType().
8187 (TypeContainer.DefineBaseTypes): New private method; resolve our
8188 base classes here. We're now called from DefineType().
8191 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8192 our types first to create all the TypeBuilders. After that, call
8193 TypeContainer.DefineType() on all the types which'll resolve their
8194 base classes and setup the resolve order.
8196 2007-03-20 Martin Baulig <martin@ximian.com>
8198 * class.cs (TypeContainer.Enums): Removed; they're now included in
8199 `TypeContainer.Types'.
8201 2007-03-20 Martin Baulig <martin@ximian.com>
8204 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8205 (TypeContainer.DoResolveMembers): Call DefineType() on our
8206 `compiler_generated' classes; moved here from DefineNestedTypes().
8209 (RootContext.ResolveTree): Call ResolveMembers() on all
8210 TypeContainer's in the `type_container_resolve_order'.
8212 2007-03-19 Marek Safar <marek.safar@gmail.com>
8214 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8216 2007-03-17 Marek Safar <marek.safar@gmail.com>
8218 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8219 implementation flags.
8221 2007-03-17 Marek Safar <marek.safar@gmail.com>
8223 * class.cs: More optimizations for type parameters.
8225 2007-03-15 Marek Safar <marek.safar@gmail.com>
8227 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8229 * ecore.cs, parameter.cs: More common code for both corlibs.
8231 * typemanager.cs (IsGenericMethod): Simplified.
8233 2007-03-15 Raja R Harinath <rharinath@novell.com>
8235 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8237 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8239 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8240 unconditionally. Simplify explanation.
8241 (Try.Resolve, Using.Resolve): Likewise.
8243 2007-03-15 Martin Baulig <martin@ximian.com>
8247 * decl.cs (DeclSpace): If we're a partial class, use our
8248 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8250 2007-03-15 Raja R Harinath <rharinath@novell.com>
8252 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8254 (FlowBranching.UsageVector): Update to changes.
8255 (FlowBranching.MergeSiblings): Likewise.
8256 * statement.cs: Likewise.
8258 2007-03-15 Martin Baulig <martin@ximian.com>
8263 (MemberCache): Added a special .ctor for type parameters.
8266 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8269 2007-03-09 Martin Baulig <martin@ximian.com>
8271 * enum.cs (Enum): Make this a TypeContainer.
8272 (EnumMember): Derive from `Const'.
8275 (Const.DoResolveValue): New protected virtual method; move most of
8276 the functionality of ResolveValue() here so we can override it in
8278 (Const.CreateConstantReference): Make this virtual.
8280 * class.cs (Kind): Add `Kind.Enum'.
8281 (TypeContainer.Emit): Don't emit the enums here; they're already
8282 in the `RootContext.typecontainer_resolve_order'.
8284 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8285 here; they're already in the `typecontainer_resolve_order'.
8287 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8288 TypeManager.DropGenericTypeArguments().
8291 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8292 (TypeManager.IsEnumType): Likewise.
8293 (TypeManager.EnumToUnderlying): Likewise.
8294 (TypeManager.IsEqual): Add support for enums.
8296 2007-03-12 Raja R Harinath <rharinath@novell.com>
8298 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8299 DefaultParameterValueAttribute to be undefined, say if System.dll
8302 2007-03-11 Marek Safar <marek.safar@gmail.com>
8304 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8307 2007-03-10 Marek Safar <marek.safar@gmail.com>
8309 * class.cs, parameter.cs: Unified parameters verification.
8311 2007-03-08 Martin Baulig <martin@ximian.com>
8313 * cs-parser.jay (constructor_header): Pass the location to the
8314 newly created TopLevelBlock.
8316 2007-03-07 Martin Baulig <martin@ximian.com>
8318 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8320 2007-03-06 Miguel de Icaza <miguel@novell.com>
8322 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8323 with the changes from David, fixes the build.
8325 2007-03-05 David Mitchell <dmitchell@logos.com>
8327 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8328 and its base interfaces to a one-dimensional array type S[],
8329 provided there is an implicit or explicit reference conversion
8332 2007-03-03 Marek Safar <marek.safar@gmail.com>
8334 * cs-tokenizer.cs: Implemented basic linq grammar.
8336 * driver.cs: Set linq lang version on demand.
8338 2007-02-26 Marek Safar <marek.safar@gmail.com>
8340 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8342 2007-02-25 Marek Safar <marek.safar@gmail.com>
8344 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8347 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8349 Check property and event extern attributes.
8351 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8354 2007-02-24 Marek Safar <marek.safar@gmail.com>
8356 A fix for bug #80407
8357 * ecore.cs: Don't report ambiguity error when methods have same parent.
8359 2007-02-23 Marek Safar <marek.safar@gmail.com>
8361 A fix for bug #80878
8362 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8364 2007-02-22 Marek Safar <marek.safar@gmail.com>
8366 * attribute.cs: Enable ExtensionAttribute presence test.
8368 2007-02-22 Marek Safar <marek.safar@gmail.com>
8370 * class.cs: Warn about missing GetHashCode only when Equals is override.
8372 * decl.cs: Check accessibility of type arguments.
8374 * typemanager.cs: Correctly report nullable array.
8376 2007-02-20 Marek Safar <marek.safar@gmail.com>
8378 * class.cs, report.cs: Capture more details when things go wrong.
8380 2007-02-20 Marek Safar <marek.safar@gmail.com>
8382 A fix for bug #80650
8383 * cs-parser.jay: Anonymous container starts at constructor declaration
8384 and not at block beginning because it has to be usable in constructor
8387 * statement.cs: Use context location and not block one for error reporting.
8389 2007-02-18 Marek Safar <marek.safar@gmail.com>
8391 A fix for bug #78712
8392 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8395 2007-02-18 Marek Safar <marek.safar@gmail.com>
8397 A fix for bug #80493 by Atsushi Enomoto
8398 * cs-parser.jay: Ignore invalid attribute target.
8400 2007-02-18 Marek Safar <marek.safar@gmail.com>
8402 * cs-tokenizer.cs: Ignore '\0' as white space character.
8404 2007-02-17 Miguel de Icaza <miguel@novell.com>
8406 * cs-parser.jay: Add support for lambda expressions to the mcs
8409 * lambda.cs: Only clone when we are probing, not on the final call
8410 (Compatible is the final call).
8412 * statement.cs (CloneContext): Introduce class to provide block
8413 remapping during clone.
8415 All statements Clone themselves now.
8417 (Clone): special handling for blocks, when we clone a block, we
8418 register the block inside this routine, as children of the block
8419 might trigger a lookup.
8421 * expression.cs: Add support for CloneContext in all expressions.
8423 2007-02-17 Marek Safar <marek.safar@gmail.com>
8425 A fix for bug #80493
8426 * statement.cs: Report ambiguous warning when interfaces are not related.
8428 2007-02-15 Marek Safar <marek.safar@gmail.com>
8430 C# 3.0 extension methods.
8432 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8433 cannot be used directly.
8435 * class.cs (Class.Emit): Emit extension attribute if any class method
8436 is extension method.
8437 (Method.Define): Add basic extension method validation conditions.
8438 (Method.Emit): Emit extension attribute for method.
8440 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8441 extension method exists. Currently we follow same approach as Microsoft
8442 does, emit even if a method or a class are private but this can change
8445 * cs-parser.jay: Add handling of `this' keyword in method parameters
8448 * decl.cs (DeclSpace.IsStaticClass): New property.
8449 (MemberCache.FindExtensionMethods): Looks for extension methods with
8450 defined name and extension type.
8452 * doc.cs: Updated after OverloadResolve changes.
8454 * driver.cs: Add new soft reference to System.Core.dll.
8456 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8457 (ExtensionMethodGroupExpr): Represents group of extension methods.
8459 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8460 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8461 to MethodGroupExpr and made non-static for easier customization.
8462 (Invocation.DoResolve): Add extension method lookup when no standard
8464 (MemberAccess.DoResolve): Try extension methods if no member exists.
8466 * modifiers.cs: Add METHOD_EXTENSION modifier.
8468 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8469 as well as candidate extension type.
8470 (ComputeNamespaces): When assembly constains extension methods registers
8472 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8473 extension method lookup.
8474 (Namespace.LookupExtensionMethod): Looks for extension method in this
8476 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8477 find a method which matches name and extensionType.
8479 * parameter.cs (Parameter): Add This modifer.
8480 (HasExtensionMethodModifier): New property.
8481 (Resolve): Add extension parameter check.
8482 (ModFlags): turned to property to exclude this modifier as it is not real
8484 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8486 * support.cs (ParameterData): Add ExtensionMethodType.
8487 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8489 * typemanager.cs: Add type and ctor extension attribute type.
8491 2007-02-15 Miguel de Icaza <miguel@novell.com>
8493 * report.cs (DisableErrors, EnableErrors): used to prevent error
8494 output when we are "trying" to compile various methods with
8497 * ecore.cs (Expression): Add Clone method that calls the virtual
8498 CloneTo method. The current CloneTo method in Expression throws
8499 an exception so we can track down all the places where this must
8500 be implemented (not using abstract, because that would be a lot of
8501 up-front-work before we can start testing the implementation
8504 Important: we only need Clone capabilities for expressions created
8505 by the parser, as the expressions we will be cloning are
8506 expressions in the pre-resolved state. This vastly simplifies
8509 (SimpleName): Add CloneTo that does nothing.
8510 (EmptyCast): Add CloneTo.
8512 * expression.cs (Binary): Implement CloneTo.
8513 (Invocation.IsApplicable): Store the current ec in
8514 EmitContext.TempEc and restore it on return. This is used so we
8515 do not have to sprinkle hundres of methods with an extra
8516 EmitContext, we know that the only user is the lambda expression
8517 ImplicitConversionExists code.
8519 (Argument): Add Cloning capabilities.
8520 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8521 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8522 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8523 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8524 IndexerAccess): Add Clone capability.
8526 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8528 (Argument): Add cloning capability.
8530 * assign.cs (Assign): Implement CloneTo.
8532 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8534 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8535 version by calling Convert with the EmitContext (that we are
8536 currently storing in ec, this is not great, but will do for now,
8537 to avoid passing EmitContext parameters to hundreds of functions
8538 that do not need them now).
8540 (SetExpression): Remove, it is not needed.
8542 (ContextualReturn): Implement CloneTo.
8544 * statement.cs (Statement): Implement cloning infrastructure,
8545 similar to expressions.
8547 (Block): Partial implementation of Clone for statements.
8549 (Return): Implement clone.
8551 * constant.cs (Constant.CloneTo): New method, does nothing.
8553 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8554 solution, until we decide how to exactly do this.
8556 2007-02-14 Marek Safar <marek.safar@gmail.com>
8558 A fix for bug #80493
8559 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8560 a property is override we need to use second accessor.
8562 2007-02-13 Marek Safar <marek.safar@gmail.com>
8564 A fix for bug #80418
8565 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8568 2007-02-13 Marek Safar <marek.safar@gmail.com>
8570 Another fix for bug #80749
8571 * pending.cs: Abstract class has priority over interfaces.
8573 2007-02-13 Marek Safar <marek.safar@gmail.com>
8575 Another fix for bug #80749
8576 * pending.cs: Abstract class has priority over interfaces.
8578 2007-02-13 Marek Safar <marek.safar@gmail.com>
8580 Another fix for bug #80749
8581 * pending.cs: Abstract class has priority over interfaces.
8583 2007-02-13 Marek Safar <marek.safar@gmail.com>
8585 Another fix for bug #80749
8586 * pending.cs: Abstract class has priority over interfaces.
8588 2007-02-13 Marek Safar <marek.safar@gmail.com>
8590 * class.cs Better error message.
8592 * driver.cs: Add shorter versions of -optimize option.
8594 2007-02-13 Martin Baulig <martin@ximian.com>
8596 * class.cs (Constructor.Emit): Check the return value of
8597 ec.ResolveTopBlock() and return on error.
8599 2007-02-13 Raja R Harinath <rharinath@novell.com>
8601 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8602 message to fix error message regression.
8604 2007-02-12 Marek Safar <marek.safar@gmail.com>
8606 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8608 2007-02-12 Marek Safar <marek.safar@gmail.com>
8610 A fix for bug #80749
8611 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8612 its parent container.
8614 * class.cs (DefineFieldInitializers): Each initializer can has different
8617 * const.cs: Updated.
8619 2007-02-11 Miguel de Icaza <miguel@novell.com>
8621 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8622 now all the heavy lifting to check that embedded statements or
8623 expressions have the right form is done in the ContextualReturn.
8625 (ContextualReturn): New class.
8627 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8628 method that can be invoked to report 201, so we do not replicate
8631 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8633 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8634 treating tabs as spaces.
8636 2007-02-09 Marek Safar <marek.safar@gmail.com>
8638 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8639 * assign.cs: Use full implicit conversion for right side check.
8641 2007-02-09 Marek Safar <marek.safar@gmail.com>
8643 * statement.cs (Switch): Switch over boolean type is not standardized.
8645 2007-02-08 Marek Safar <marek.safar@gmail.com>
8647 A fix for bug #80755
8648 * decl.cs (FindBaseEvent): Don't use method cache for events.
8650 2007-02-07 Marek Safar <marek.safar@gmail.com>
8652 * cs-parser.jay: Better syntax error handling.
8654 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8655 instead of underlying type value.
8657 2007-02-06 Marek Safar <marek.safar@gmail.com>
8659 * driver.cs: Check define identifier before is registered.
8661 * namespace.cs: Use existing error message.
8663 * report.cs: New warning.
8665 2007-02-06 Marek Safar <marek.safar@gmail.com>
8667 A fix for bug #80742
8668 * expression.cs: Delegate Invoke method can be called directly.
8670 2007-02-06 Marek Safar <marek.safar@gmail.com>
8672 A fix for bug #80676
8673 * class.cs (IsEntryPoint): The Main method can have params modifier.
8675 2007-02-04 Miguel de Icaza <miguel@novell.com>
8677 * parameter.cs (Parameter, Parameters): Add Clone method.
8679 * anonymous.cs (Compatible): Turn method into virtual method, so
8680 LambdaExpression can implement a different behavior.
8682 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8683 out the basic checking here, so it can be used by
8686 * lambda.cs: Introduce "Compatible" function that will do the
8689 2007-02-02 Marek Safar <marek.safar@gmail.com>
8691 * attribute.cs: Unified one error message.
8693 * class.cs (Class): Use type attributes and not properties to test static
8695 (IsEntryPoint): Don's pass local variable.
8697 * convert.cs: Removed duplicate check.
8699 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8701 * driver.cs: Don't crash when soft reference does not exist.
8703 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8704 (UsingEntry): Removed redundant allocation.
8706 * parameter.cs: Add fast path for type parameters.
8708 * support.cs: Don't allocate attribute when it's not used.
8710 2007-01-30 Miguel de Icaza <miguel@novell.com>
8713 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8714 this into a virtual method, so we can override it in LambdaExpression.
8716 * driver.cs: Improve diagnostics in case of failure.
8718 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8719 write a function that is slightly more complex and that parses:
8721 type identifier [, type identifier]* )
8723 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8726 (canEmpty ? i >= 0 : i > 0)
8728 2007-01-30 Raja R Harinath <rharinath@novell.com>
8730 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8731 exception on possibly valid code.
8733 2007-01-29 Raja R Harinath <rharinath@novell.com>
8735 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8737 (parse_opt_type_arguments): Remove. It's almost the same as
8739 (parse_namespace_or_typename): Use parse_less_than.
8741 2007-01-28 Miguel de Icaza <miguel@novell.com>
8743 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8744 this bug took a few hours to find, because the state saved and
8745 restored by PushPosition and PopPosition was ignoring the state of
8746 parse_generic_less_than.
8748 I can also now remove the handling of OP_LT and OP_GT, this solves
8751 * cs-tokenizer.cs: store the location for the ARROW token, we use
8754 (PushPosition, PopPosition): save/restore also `current_token',
8755 restore `parse_generic_less_than' (was missing).
8757 (parse_opt_type_arguments): use parse_type, not
8758 parse_namespace_or_typename to parse types.
8760 * lambda.cs: Empty new file, will eventually have the lambda
8761 expression implementation.
8763 * lambda.test: used to test the internal tokenizer.
8765 * report.cs (FeatureIsNotISO1): Rename from
8766 FeatureIsNotStandardized, because it was about the language level
8767 (1 vs 2) it was not about standarization.
8769 (FeatureRequiresLINQ): New.
8771 * support.cs (SeekableStreamReader): Only require that the reader
8772 is a TextReader, not a StreamReader, so we can plug StringReader.
8774 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8775 given position in the input stream the following tokens can be
8776 parsed as a type followed by an identifier.
8778 (is_punct): after a '(' if parse_type_and_parameter returns true,
8779 then return a special token OPEN_PARENS_LAMBDA which is used to
8780 avoid reduce/reduce errors in the grammar for the
8781 lambda_expression rules.
8783 (parse_type): implement a type parser inside the
8784 tokenizer, the parser only returns true or false depending on
8785 whether the input at a given position can be parsed as a type.
8787 (peek_token): new method used during type parsing.
8789 2007-01-28 Raja R Harinath <rharinath@novell.com>
8792 * anonymous.cs (ScopeInfo.InflateParameters): New.
8793 (AnonymousContainer.Resolve): Use it to redirect types of
8794 delegate parameters.
8796 2007-01-27 Raja R Harinath <rharinath@novell.com>
8799 * expression.cs (Error_InvalidArguments): Don't use two different
8800 messages for CS1503. Use ExtraInformation and
8801 SymbolRelatedToPreviousError instead.
8804 * decl.cs (DeclSpace.initialize_type_params): Don't access
8805 'type_params' of a partial class directly.
8807 2007-01-26 Miguel de Icaza <miguel@novell.com>
8809 * constant.cs: Removed a handful of out-of-range checks that were
8812 2007-01-25 Marek Safar <marek.safar@gmail.com>
8814 * expression.cs (CheckUselessComparison): Add additional check for char
8817 * namespace.cs: Fixed typo.
8819 2007-01-23 Miguel de Icaza <miguel@novell.com>
8821 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8822 gone, instead we inline the test, preventing the needless casts to
8823 longs, ulongs and doubles for the parameters, avoiding calls to
8824 methods that overchecked stuff, and instead inlined things
8827 2007-01-20 Marek Safar <marek.safar@gmail.com>
8829 * cs-parser.jay: Better parameter error handling.
8831 2007-01-17 Marek Safar <marek.safar@gmail.com>
8833 A fix for bug #80368, #80522
8834 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8835 whether array initializer contains constants only.
8836 (ArrayCreation.Emit): Use better formula to decide when
8837 are array initializers for static initialization.
8838 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8839 have to emit even constants otherwise they are pre-initialized.
8841 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8842 Raja R Harinath <rharinath@novell.com>
8844 Fix emit order of 'get' vs. 'set'.
8845 * support.cs (Accessors): New.
8846 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8847 Note the order in which accessors are declared in the source.
8848 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8849 Refactored from Property.Define and Indexer.Define.
8850 (PropertyBase.DefineAccessors): New helper that calls the above in
8851 appropriate order as noted by the parser.
8852 (Property.Define, Indexer.Define): Update to changes.
8853 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8855 2007-01-17 Raja R Harinath <rharinath@novell.com>
8857 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8858 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8859 there's an implicit conversion from the current type to the target
8860 type before converting the underlying constant.
8862 2007-01-16 Marek Safar <marek.safar@gmail.com>
8864 * const.cs (ResolveValue): Updated after constant conversion was made more
8867 * constant.cs (GetAttributableValue): constant to object conversion is
8868 used for attributes only.
8869 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8870 constant conversions.
8871 (LongConstant.ConvertImplicitly): Ditto.
8873 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8874 (ImplicitConversionStandard): Handle constant conversion as extra step.
8875 It solves the issue when constant conversion was called indirectly like
8876 inside array initializer and constant folding was skipped.
8878 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8881 * statement.cs(ImplicitConversionStandard): Updated after constant
8882 conversion was made more generic.
8884 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8886 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8887 Constraints, solves the problem where the compiler incorrectly
8888 reported that a type parameter was not constrained to a class (Bug
8891 2007-01-14 Marek Habersack <grendello@gmail.com>
8893 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8895 2007-01-14 Marek Safar <marek.safar@gmail.com>
8897 A fix for bug #80368
8898 * assign.cs (FieldInitializer): New class implements field
8899 initializer statement.
8901 * attribute.cs: Update after FieldMember rename.
8903 * class.cs (PropertyBasedMember): New common class for property based
8905 (InterfaceMemberBase): New base class for all members which can be used as
8906 an interface members.
8907 (MethodCore): Moved really common code to InterfaceMemberBase.
8908 (Method.Define): Equal and GetHasCode detection is relevant for methods
8910 (MethodData.Define): Don't assume that public event implements an
8911 interface automatically.
8912 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8914 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8915 (FieldMember): Merged with FieldBase.
8916 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8917 event extern modifier can be used.
8918 (EventField.EventFieldAccessor): Moved event field specific code here.
8919 (Event.AllowedModifiers): Even event can be extern.
8920 (Event.FindOutBaseMethod): New override specific to events.
8921 (Indexer.parameters): Reintroduce parameters because base class holds
8922 only properties common data.
8923 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8924 need do extra parameters check.
8926 * const.cs: Update after FieldMember rename.
8928 * decl.cs (MemberCache.FindBaseEvent): New method.
8930 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8931 to reflect that indexer is now derived from PropertyBased.
8933 * ecore.cs (GetMemberType): Made public.
8934 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8937 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8939 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8940 (RegisterEvent): Removed.
8941 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8942 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8944 2007-01-11 Raja R Harinath <rharinath@novell.com>
8947 * statement.cs (CollectionForeach.TryType): Prefer generic
8948 GetEnumerator over non-generic variant. Fix code to follow comments.
8950 2007-01-09 Raja R Harinath <rharinath@novell.com>
8953 * support.cs (ReflectionParameter): Don't use an invalid index on
8954 the generic parameter data.
8956 2007-01-08 Miguel de Icaza <miguel@novell.com>
8958 * driver.cs: Just add a tiny bit of infrastructure.
8960 2007-01-02 Marek Safar <marek.safar@gmail.com>
8962 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8963 where field type is struct from current assembly.
8965 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8968 2007-01-02 Marek Safar <marek.safar@gmail.com>
8970 A fix for bug #80381
8971 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8974 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8976 (Namespace.LookupType): Always use core types from corlib when speficied.
8978 * report.cs: A new warning.
8980 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8981 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8982 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8984 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8985 (InitCoreTypes): Set expression type of object_type and value_type
8986 immediately after lookup.
8988 2007-01-01 Miguel de Icaza <miguel@novell.com>
8990 * cs-tokenizer.cs: Accept Pc class characters (Connector
8991 Punctuation) as valid identifiers. Fixes #78259
8993 * expression.cs (Invocation.DoResolve): Moved the check for the
8994 use of `this' for doing method calls to the Invocation resolution
8995 step, after overload resolution has taken place instead of doing
8996 the check at the low-level `This.DoResolve' level.
8998 The `This.DoResolve'(appens before overload resolution, so it has
8999 no way of knowing if the method that will be called will be
9000 instace or static, triggering an erroneous report for cs0188 (Bug
9003 We now do the check for instance method invocations after we know
9004 what method will be called.
9006 (This.CheckThisUsage): Move the actual use of this structure
9007 checking into its own method and expose it.
9009 * Everywhere that called Error_ValueCannotBeConverted: pass a new
9012 Exceptions: Null.ConvertImplicitly,
9013 Constant.ImplicitConversionRequired as there are too many call
9014 sites for passing the ec.
9016 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
9017 EmitContext, if the value is null, then we do not try to provide
9018 the extra information from the error (If a userdefined conversion
9019 exists, as UserDefinedConversion requires a non null-EmitContext).
9023 2006-12-30 Raja R Harinath <rharinath@novell.com>
9025 * flowanalysis.cs (MyBitVector): Document some invariants.
9026 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
9027 introduced below, and add a couple of others,
9029 2006-12-30 Marek Safar <marek.safar@gmail.com>
9031 * attribute.cs (GetMethodObsoleteAttribute): Uses new
9032 GetPropertyFromAccessor and GetEventFromAccessor.
9034 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
9035 overrides non-obsolete one.
9036 (Indexer.Define): Error message has been moved to the parser.
9038 * cs-parser.jay: Better syntax errors handling.
9040 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
9041 when an invocation has no arguments.
9043 * ecore.cs: Removed not used caching.
9045 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
9048 * report.cs: Add a new warning.
9050 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
9052 * typemanager.cs (enumeration_type): Removed.
9053 (CSharpSignature): Reuses IsSpecialMethod.
9054 (IsEqual): Hack for MS BCL.
9055 (GetPropertyFromAccessor): New method.
9056 (GetEventFromAccessor): New method.
9057 (IsSpecialMethod): Fixed to handle more cases.
9059 2006-12-30 Marek Safar <marek.safar@gmail.com>
9061 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
9062 Made white spaces array static.
9064 * ecore.cs (RemoveGenericArity): Optimized.
9066 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
9068 (MyBitVector.initialize_vector): Simplified.
9070 2006-12-22 Miguel de Icaza <miguel@novell.com>
9072 * ecore.cs: Am not entirely happy with this hack, but it seems to
9073 address the issue in 80257 (a small test case for
9076 I set the MethodGroupExpr.Type to an internal compiler type
9077 (itself in this case) to force the resolution to take place. Why
9078 it does not take place with a null is beyond me.
9080 2006-12-20 Marek Safar <marek.safar@gmail.com>
9082 A fix for bug #80288
9083 * expression.cs (ResolveOperator): Consider user defined conversion for
9084 logical and operator too.
9085 (EmitBranchable): Optimization for logical and when full constant folding
9086 could not be applied but one operand is constant.
9088 2006-12-19 Marek Safar <marek.safar@gmail.com>
9090 * class.cs (GetClassBases): Write 5 times every day, will never use
9091 FullName for error reporting.
9093 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
9095 2006-12-19 Martin Baulig <martin@ximian.com>
9097 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
9098 the symbol file info here.
9100 2006-12-18 Marek Safar <marek.safar@gmail.com>
9102 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
9103 of `elseif' is taking then following sections are not taking.
9104 Fixes an issue reported on mono mailing list.
9106 2006-12-18 Marek Safar <marek.safar@gmail.com>
9108 A fix for bug #80300
9109 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
9110 a caller is not taking.
9112 2006-12-18 Raja R Harinath <rharinath@novell.com>
9114 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9115 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9116 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9117 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9118 * class.cs: Update to changes.
9120 2006-12-17 Marek Safar <marek.safar@gmail.com>
9122 A fix for bug #79934
9123 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9126 * class.cs (ResolveMembers): Register an iterator in current container and
9129 2006-12-16 Raja R Harinath <rharinath@novell.com>
9132 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9133 satisfy a params annotated parameter.
9135 2006-12-16 Marek Safar <marek.safar@gmail.com>
9137 A fix for bug #77014
9138 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9139 paramters correctly and not rely on hacks in Parameters class.
9140 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9142 (Invocation.VerifyArgumentsCompat): Ditto.
9143 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9146 * parameter.cs (HasParams): Don't assume that params is the last one.
9148 * support.cs (ReflectionParameters.ctor): Look for params attribute
9150 (ReflectionParameters.ParameterType): Removed hack when we returned last
9151 parameter for out of range parameters.
9152 (ParameterName, ParameterModifier): Ditto.
9154 2006-12-14 Marek Safar <marek.safar@gmail.com>
9156 A fix for bug #79987
9157 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9158 when assembly is not CLS compliant but type is. I have no idea why is this
9161 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9163 2006-12-13 Miguel de Icaza <miguel@novell.com>
9165 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9166 in struct constructors, they are basically no-ops.
9168 2006-12-12 Marek Safar <marek.safar@gmail.com>
9170 * cs-tokenizer.cs (Position): Save preprocessor status too.
9172 2006-12-12 Marek Safar <marek.safar@gmail.com>
9174 A fix for bug #77794
9175 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9177 2006-12-12 Marek Safar <marek.safar@gmail.com>
9179 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9181 (pp_expr): Report error for an invalid expression.
9182 (handle_preprocessing_directive): Simplified; add more error checking.
9184 2006-12-11 Marek Safar <marek.safar@gmail.com>
9186 A fix for bug #74939
9187 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9188 directives handling.
9190 2006-12-10 Marek Safar <marek.safar@gmail.com>
9192 A fix for bugs #80093, and #75984
9193 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9194 logic, it seems to me as it worked before "by coincidence".
9195 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9196 (cleanup): Enabled endif check.
9198 2006-12-09 Marek Safar <marek.safar@gmail.com>
9200 A fix for bug #80162
9201 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9202 enumerators are never ambiguous.
9204 2006-12-08 Raja R Harinath <rharinath@novell.com>
9207 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9209 2006-12-06 Marek Safar <marek.safar@gmail.com>
9211 A fix for bug #80144
9212 * class.cs (EventProperty.Define): Explicit implementation means
9213 that an even is used.
9215 2006-12-06 Marek Safar <marek.safar@gmail.com>
9217 Fixes the operators implementation (part II)
9219 * cfold.cs (DoConstantNumericPromotions): Renamed to
9220 DoBinaryNumericPromotions and simplified.
9221 (BinaryFold): Couple of conversion fixes; simplified.
9223 * constant.cs, ecore.cs, literal.cs
9224 (ToType): Renamed to ConvertImplicitly.
9225 (Reduce): Renamed to ConvertExplicitly.
9227 * class.cs, convert.cs: Updated.
9229 * expression.cs: TryReduce doesn't throw an exception.
9231 2006-12-01 Marek Safar <marek.safar@gmail.com>
9233 A fix for bug #80108
9234 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9237 2006-11-30 Marek Safar <marek.safar@gmail.com>
9239 Fixes unary operators implementation (part I)
9242 * cfold.cs (Error_CompileTimeOverflow): Made internal
9244 * const.cs (IConstant): Changed to use reference to constant and
9245 not constant itself.
9246 Updated IConstant implementations.
9248 * constant.cs (CreateConstant): New factory method.
9249 Updated IConstant implementation.
9251 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9253 * ecore.cs: Updated to use CreateConstantReference.
9255 * enum.cs: Reflects IConstant changes.
9257 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9259 * literal.cs (NullConstant): Change to be independently usable.
9261 2006-11-29 Martin Baulig <martin@ximian.com>
9263 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9264 we need to emit the scope initializer before calling the base .ctor.
9266 * anonymous.cs: Merged back from the new anonymous methods branch.
9267 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9269 * expression.cs (ParameterReference.DoResolveBase): Create a
9270 "normal" ScopeInfo when capturing parameters rather than using the
9271 root scope; this makes things work with anonymous methods having
9275 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9277 2006-11-22 Marek Safar <marek.safar@gmail.com>
9279 A fix for bug #79987
9280 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9281 check to a base class.
9282 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9283 only when assembly has missing attribute.
9284 * report.cs: Update.
9286 2006-11-21 Marek Safar <marek.safar@gmail.com>
9288 * cs-tokenizer.cs: Merged with gmcs version.
9290 2006-11-20 Marek Safar <marek.safar@gmail.com>
9293 * cs-parser.jay: Better error message when partial keyword is misplaced.
9295 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9297 A fix for bug #79810
9298 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9299 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9300 a RuntimeWrappedException by default.
9302 2006-11-18 Marek Safar <marek.safar@gmail.com>
9304 A fix for bug #79843
9305 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9307 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9309 2006-11-18 Marek Safar <marek.safar@gmail.com>
9311 * driver.cs, namespace.cs: Uses faster IndexOf version.
9313 2006-11-17 Marek Safar <marek.safar@gmail.com>
9315 A fix for bug #79941
9316 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9318 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9319 even if internal name is different.
9320 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9321 (UserDefinedConversion): Simplified as the operators cannot be internal.
9322 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9324 (MethodLookup): Replaced EmitContext with parentType.
9325 * expression.cs: Updated.
9327 2006-11-09 Raja R Harinath <rharinath@novell.com>
9329 * driver.cs (BadAssembly): Handle all the ugliness of
9330 DefineDynamicAssembly.
9332 2006-11-08 Raja R Harinath <rharinath@novell.com>
9334 Address parts of #58244 -- most of what's left is in the runtime
9335 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9336 CS1509 error checks, and handle them for all assembly loads, not
9337 just the first invocation.
9338 (LoadModule): Likewise. Move handling of 'adder_method' ...
9339 * codegen.cs (AssemblyClass.AddModule): ... here.
9341 2006-11-02 Marek Safar <marek.safar@gmail.com>
9343 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9344 IEnumerable<T> is ambiguous.
9346 2006-10-31 Marek Safar <marek.safar@gmail.com>
9348 A fix for bug #67689
9349 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9350 GetEnumerator is ambiguous.
9352 * report.cs: Add new warning.
9354 2006-10-29 Marek Safar <marek.safar@gmail.com>
9356 A fix for bug #78602
9357 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9358 to protected member can be nested type.
9360 2006-10-28 Marek Safar <marek.safar@gmail.com>
9362 A fix for bug #78965
9363 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9364 to protected member must derive from current type.
9366 2006-10-27 Marek Safar <marek.safar@gmail.com>
9368 assign.cs: Reuses error method.
9370 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9371 instead of type for constants.
9372 (Expression.Error_ValueAssignment): Common error method.
9374 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9377 2006-10-27 Marek Safar <marek.safar@gmail.com>
9379 A fix for bug #79081
9380 * expression.cs (MemberAccess.DoResolve): Check nested type
9383 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9385 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9387 2006-10-26 Marek Safar <marek.safar@gmail.com>
9389 A fix for bug #76591
9390 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9392 2006-10-26 Marek Safar <marek.safar@gmail.com>
9394 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9395 type forwarder of the same type multiple times.
9397 2006-10-26 Raja R Harinath <rharinath@novell.com>
9400 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9401 instance as an rvalue, even when we later resolve as an lvalue.
9403 2006-10-25 Martin Baulig <martin@ximian.com>
9405 * anonymous.cs: Fix #79673.
9407 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9409 A fix for bug #79666
9410 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9411 ignored when is optimized (= default value) as its value is already set.
9413 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9415 A fix for bug #79724
9416 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9417 TypeContainer for type lookup.
9419 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9421 A fix for bug #79231
9422 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9423 * expression.cs (OverloadResolve): Always convert type name for
9425 (ResolveNamespaceOrType): Don't confuse a nested type with any
9428 2006-10-18 Martin Baulig <martin@ximian.com>
9430 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9432 2006-10-17 Miguel de Icaza <miguel@novell.com>
9434 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9435 an int32, but requesting an int64 from the conversion
9437 2006-10-12 Martin Baulig <martin@ximian.com>
9440 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9442 2006-10-12 Martin Baulig <martin@ximian.com>
9445 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9447 2006-10-11 Miguel de Icaza <miguel@novell.com>
9449 * convert.cs: Remove broken code: I was doing the "Existance"
9450 tests for Implicit conversions.
9452 2006-10-10 Miguel de Icaza <miguel@novell.com>
9454 * convert.cs: Added one missing case in
9455 ImplicitStandardConversionExists uint64 to intptr.
9459 * typemanager.cs (uintptr_type): another core known type.
9461 * ecore.cs (OperatorCast): routine used to do cast operations that
9462 depend on op_Explicit. We could change some of the Decimal
9463 conversions to use this.
9465 This one has a probe mechanism that checks both types for an op_
9466 which it coudl be used to eliminate two classes: CastToDecimal
9467 and CastFromDecimal.
9469 * convert.cs: Implement the conversions documented in #59800
9471 2006-10-10 Martin Baulig <martin@ximian.com>
9473 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9474 before RootScope.ResolveMembers().
9476 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9477 `CurrentType' if appropriate.
9479 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9481 A fix for bug #78568
9482 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9483 when contains binary operators.
9484 * cs-parser.jay: Updated.
9486 2006-10-09 Martin Baulig <martin@ximian.com>
9489 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9490 moved that into Define() and also do the other type parameter
9491 checks there. Fixes #79094. Added gtest-292.cs.
9494 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9495 since that doesn't include type parameters; don't use `Ldelema'
9496 for type parameters. Fixes #78980. Added gtest-293.cs.
9498 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9501 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9502 conversion is allowed.
9504 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9506 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9507 error reporting when no error occurs.
9509 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9511 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9514 2006-10-06 Raja R Harinath <rharinath@novell.com>
9517 * class.cs (DefineTypeBuilder): Check circular dependencies before
9518 setting the parent of the TypeBuilder.
9519 (CheckRecursiveDefinition): Don't use 'BaseType', since
9520 it may not be valid until after DefineTypeBuilder. Use
9521 'base_type' instead.
9523 2006-10-04 Martin Baulig <martin@ximian.com>
9525 Merged the Anonymous Methods patch.
9527 * anonymous.cs, iterators.cs: The new anonymous methods code.
9529 * statement.cs (Variable): New public abstract class.
9530 (LocalInfo.Variable): New public property.
9531 (LocalInfo.ResolveVariable): New public method.
9532 (Block.Flags): Add `IsIterator'.
9533 (Block.AddVariable): Improved the CS0136 check.
9534 (Block.AnonymousChildren): New public property.
9535 (Block.AddAnonymousChild): New public method.
9536 (ToplevelBlock): Update to use the new anonymous method framework.
9537 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9538 `ToplevelBlock'; this is required to correctly implement the
9540 (Fixed, Using): Use `TemporaryVariable' instead of directly
9541 creating the `LocalBuilder'.
9543 * parameter.cs (Parameter.ResolveVariable): New public method.
9544 (Parameters.ResolveVariable): Likewise.
9546 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9548 * class.cs (TypeContainer): Replaced the `iterators' list and
9549 corresponding methods with a list of `CompilerGeneratedClass'es.
9550 (TypeContainer.ResolveMembers): New public method.
9551 (Method): `IIteratorContainer' has been replaced by
9554 * expression.cs (VariableReference): New public abstract base
9555 class for `LocalVariableReference', `ParameterReference' and
9558 * codegen.cs (EmitContext): Removed `capture_context',
9559 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9560 (EmitContext.EmitThis): Removed.
9562 * cs-parser.jay: Replace `iterator_container' with
9565 2006-10-04 Martin Baulig <martin@ximian.com>
9567 * generic.cs (GenericMethod): Don't make this abstract.
9568 (Constraints.Clone): Added dummy implementation.
9570 2006-10-04 Raja R Harinath <harinath@gmail.com>
9573 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9574 'declspaces'. Avoid allocating arrays willy-nilly.
9577 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9578 cases out of the switch.
9580 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9582 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9583 message when non-generic type is used with the type arguments.
9584 * expression.cs: Updated.
9586 2006-09-28 Raja R Harinath <rharinath@novell.com>
9589 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9590 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9591 Change semantics slightly. Don't insist on having only one
9592 temporary EmptyExpression -- just throttle the creation of new ones.
9595 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9596 non-interfaces too. If no methods are found, don't try to create
9599 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9601 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9604 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9605 us produce better error message.
9607 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9609 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9610 of the `|' operator.
9612 * report.cs: A new warning added.
9614 2006-09-27 Martin Baulig <martin@ximian.com>
9616 * generic.cs (GenericMethod): Don't make this abstract.
9618 2006-09-27 Martin Baulig <martin@ximian.com>
9621 (InternalErrorException): Added overloaded ctor taking a params array.
9623 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9625 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9626 Fixed the cases when same error was reported twice.
9628 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9629 now report symbol information.
9631 2006-09-25 Martin Baulig <martin@ximian.com>
9633 * class.cs: Completely unified with the gmcs version.
9635 2006-09-25 Martin Baulig <martin@ximian.com>
9637 * typemanager.cs (TypeManager.IsNullableType): New public function.
9638 (TypeManager.IsNullableTypeOf): Likewise.
9639 (TypeManager.IsNullableValueType): Likewise.
9641 * class.cs (MethodCore): Added the `GenericMethod' argument from
9642 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9644 2006-09-24 Raja R Harinath <harinath@gmail.com>
9646 * convert.cs: Unify with gmcs version.
9648 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9650 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9651 verify them as well.
9653 * report.cs: New warning.
9655 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9657 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9658 for anonymous block with out argument.
9660 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9662 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9663 not used private events only.
9665 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9667 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9669 * const.cs (Const.Define): Check for constant type.
9670 (Const.IsConstantTypeValid): Looks for valid constant types.
9672 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9674 * ecore.cs (EmptyConstantCast): New common class for all constant based
9677 * expression.cs (Is.DoResolve): Handle null constant especially.
9678 (New.DoResolve): Check for new void().
9679 (MemberAccess.DoResolve): Cope with all kind of nulls.
9681 * literal.cs (NullConstant): Uses EmptyConstantCast.
9682 (NullDefault): Based on EmptyConstantCast.
9683 (NullLiteral): Uses EmptyConstantCast.
9685 * statement.cs (Block.ResolveMeta): Check for constant type.
9687 2006-09-22 Martin Baulig <martin@ximian.com>
9689 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9691 2006-09-22 Raja R Harinath <rharinath@novell.com>
9693 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9697 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9698 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9701 2006-09-22 Martin Baulig <martin@ximian.com>
9703 * ecore.cs: Merged with the gmcs version.
9705 * generic.cs (ConstructedType): New dummy class.
9706 (TypeArguments): Don't make this abstract.
9709 (TypeManager.IsGenericTypeDefinition): New method.
9710 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9712 2006-09-22 Raja R Harinath <rharinath@novell.com>
9714 * expression.cs (ComposedCast): Check for arrays of TypedReference
9715 before creating the type, not after.
9717 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9719 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9720 after ToType change.
9722 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9723 when constant must be implicitly convertible.
9725 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9727 * ecore.cs (NullCast): Derives from NullConstant.
9729 * expression.cs (Is.DoResolve): Removed useless variables.
9730 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9731 (New.Constantify): Add enum support.
9732 (MemberAccess.DoResolve): Add warning when accessing null constant or
9735 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9738 * literal.cs (NullConstant): New abstract class with common
9739 functionality for all null specializations.
9740 (NullDefault): Represents default(X) when result can be
9742 (NullLiteral): Updated.
9744 * report.cs: Add new warning.
9746 2006-09-21 Martin Baulig <martin@ximian.com>
9748 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9750 2006-09-21 Martin Baulig <martin@ximian.com>
9752 * generic.cs (GenericConstraints): New dummy class.
9753 (Constraints): Likewise.
9754 (TypeParameter): Likewise.
9755 (TypeParameterName): Likewise.
9756 (GenericMethod): Likewise.
9758 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9760 * decl.cs: Merged with the gmcs version.
9762 2006-09-21 Raja R Harinath <rharinath@novell.com>
9764 * generic.cs (TypeParameter): Implement IMemberContainer.
9765 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9767 * rootcontext.cs: Unify with gmcs version.
9769 * report.cs: Unify with gmcs version.
9770 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9771 from gmcs/generics.cs.
9772 * generics.cs (TypeParameter): New dummy class.
9774 * support.cs: Unify with gmcs version.
9776 2006-09-20 Raja R Harinath <rharinath@novell.com>
9778 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9779 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9781 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9782 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9783 * mcs.exe.sources: Add generic.cs.
9785 * codegen.cs: Unify with gmcs version.
9787 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9788 (EmitContext): Add GenericDeclContainer implementation.
9789 * decl.cs (MemberCore, DeclSpace): Likewise.
9790 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9792 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9793 MCS TypeManager has a corresponding dummy method.
9795 2006-09-19 Martin Baulig <martin@ximian.com>
9797 * expression.cs: Completely merged with the gmcs version.
9799 2006-09-19 Martin Baulig <martin@ximian.com>
9801 * expression.cs (Invocation): Merged with the gmcs version.
9802 (ArrayAccess.GetStoreOpcode): Likewise.
9804 2006-09-19 Martin Baulig <martin@ximian.com>
9807 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9808 (TypeManager.IsGenericMethodDefinition): Likewise.
9810 2006-09-19 Martin Baulig <martin@ximian.com>
9813 (TypeManager.IsEqual): Moved the gmcs implementation here.
9814 (TypeManager.DropGenericTypeArguments): Likewise.
9815 (TypeManager.DropGenericMethodArguments): Likewise.
9816 (TypeManager.GetTypeArguments): Moved here from gmcs.
9817 (TypeManager.HasGenericArguments): Likewise.
9819 2006-09-19 Martin Baulig <martin@ximian.com>
9821 * expression.cs (Binary): Merged with the gmcs version.
9823 2006-09-19 Martin Baulig <martin@ximian.com>
9825 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9827 2006-09-19 Martin Baulig <martin@ximian.com>
9829 * typemanager.cs: Merged with the gmcs version.
9831 2006-09-16 Raja R Harinath <rharinath@novell.com>
9833 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9834 * driver.cs: Likewise.
9836 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9839 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9840 only if parent type is class.
9841 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9844 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9847 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9849 * typemanager.cs(CSharpName): Converts NullType to null.
9851 2006-09-15 Martin Baulig <martin@ximian.com>
9854 (TypeManager.GetMethodName): Added mcs implementation.
9855 (TypeManager.IsEqual): Likewise.
9858 (SimpleName.RemoveGenericArity): Added dummy implementation.
9860 * pending.cs: Merged with the gmcs version.
9862 2006-09-15 Martin Baulig <martin@ximian.com>
9864 * statement.cs: Merge with the gmcs version.
9866 2006-09-15 Martin Baulig <martin@ximian.com>
9868 * statement.cs (Switch): Merge with the gmcs implementation
9869 (without nullables), which is newer.
9871 2006-09-15 Martin Baulig <martin@ximian.com>
9873 * statement.cs (Block.Variables): Make this public.
9874 (ToplevelBlock.Parameters): Make this a property.
9875 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9877 2006-09-15 Martin Baulig <martin@ximian.com>
9879 * namespace.cs: Merge with the gmcs version.
9881 2006-09-15 Martin Baulig <martin@ximian.com>
9883 * decl.cs (MemberName): Minor code cleanups.
9885 2006-09-15 Martin Baulig <martin@ximian.com>
9887 * parameter.cs: Merge with the gmcs version.
9889 2006-09-15 Martin Baulig <martin@ximian.com>
9891 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9892 and an error in mcs.
9894 2006-09-15 Martin Baulig <martin@ximian.com>
9896 * flowanalysis.cs: Merged from GMCS; added the generics code into
9897 a `GMCS_SOURCE' conditional so we can share this file.
9899 2006-09-08 Martin Baulig <martin@ximian.com>
9901 * typemanager.cs (TypeManager.interlocked_type): New public field.
9902 (TypeManager.int_interlocked_compare-exchange): New public field.
9903 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9904 enumerator types here and call InitGenericCoreTypes().
9905 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9906 after calling InitEnumUnderlyingTypes().
9909 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9910 `classes_second_stage'.
9912 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9914 * assign.cs, ecore.cs, expression.cs: Share error message text.
9915 * class.cs (FieldMember.Define): Check for varible of static type.
9916 * driver.cs (LoadAssembly): Uses error output for errors.
9917 * statement.cs: Updated.
9919 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9921 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9924 2006-09-07 Martin Baulig <martin@ximian.com>
9927 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9929 2006-08-29 Miguel de Icaza <miguel@novell.com>
9931 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9933 2006-08-17 Miguel de Icaza <miguel@novell.com>
9935 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9936 #52019 and #79064, the use of the \uXXXX sequence in source code
9937 to represent unicode characters.
9939 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9941 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9943 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9945 2006-08-13 Miguel de Icaza <miguel@novell.com>
9947 * assign.cs: Catch attempts to assign to a method groups in += and
9950 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9953 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9955 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9957 * class.cs (Method.Define): Issue a warning when generic method looks like
9959 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9962 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9964 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9966 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9967 search all base interfaces as a member can be ambiguous.
9968 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9969 Constructor member type filter.
9970 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9971 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9972 reporting for returned memberinfos.
9973 * report.cs: Updated.
9974 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9975 version to work on all runtimes.
9976 (TypeManager.RealMemberLookup): Removed members filtering.
9978 2006-08-08 Raja R Harinath <rharinath@novell.com>
9980 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9981 (PropertyExpr.EmitAssign): Likewise.
9982 * expression.cs (Indirection.EmitAssign): Likewise.
9983 (LocalVariableReference.EmitAssign): Likewise.
9984 (ParameterReference.EmitAssign): Likewise.
9985 (Invocation.EmitArguments): Likewise.
9986 (ArrayAccess.EmitAssign): Likewise.
9987 (IndexerAccess.EmitAssign): Likewise.
9988 (This.EmitAssign): Likewise.
9989 (ConditionalLogicalOperator.Emit): Likewise.
9992 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9993 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9994 leave it in after returning it.
9995 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9997 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9999 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
10002 2006-08-03 Raja R Harinath <rharinath@novell.com>
10004 Fix cs0146-3.cs and cs0146-4.cs.
10005 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
10006 enclosing types don't depend on the current type.
10008 2006-08-02 Raja R Harinath <rharinath@novell.com>
10011 * class.cs (TypeContainer.DoDefineMembers): Use
10012 FindBaseMemberWithSameName on Parent, since we're interested in
10013 whether we hide inherited members or not.
10014 (FindBaseMemberWithSameName): Make slightly more robust.
10016 Fix the non-generic testcase from #77396
10017 * decl.cs (DeclSpace.DeclContainer): Remove override.
10019 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
10020 declspaces for doppelgangers too.
10021 (UsingEntry): Implement IResolveContext.
10022 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
10023 'this' as the resolve context.
10024 (LocalAliasEntry): Likewise.
10026 Implement parts of #77403
10027 * roottypes.cs (RootDeclSpace): New. Used to represent the
10028 toplevel declaration space. Each namespace declaration introduces
10029 a "partial" root declaretion space.
10030 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
10031 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
10032 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
10033 from 'current_namespace.SlaveDeclSpace'.
10034 (namespace_declaration): Likewise.
10035 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
10036 check. It can't happen now.
10037 * decl.cs (DeclSpace.LookupType): Likewise.
10038 * driver.cs (MainDriver): Sanity check.
10040 2006-08-01 Raja R Harinath <rharinath@novell.com>
10042 * decl.cs (DeclSpace.FindNestedType): Remove.
10043 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
10044 LookupTypeContainer to get the container of the nested type.
10045 * class.cs (TypeContainer.FindNestedType): Make non-override.
10047 2006-07-31 Raja R Harinath <rharinath@novell.com>
10049 * decl.cs (DeclSpace.PartialContainer): Move field from ...
10050 * class.cs (TypeContainer.PartialContainer): ... here.
10051 (TypeContainer.AddBasesForPart): New helper.
10052 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
10054 * cs-parser.jay (current_class): Convert to DeclSpace.
10055 (struct_declaration, interface_declaration, class_declaration):
10056 Use AddBasesForPart instead of .Bases directly.
10057 * const.cs, iterators.cs: Update to changes.
10059 2006-07-28 Raja R Harinath <rharinath@novell.com>
10061 * class.cs (TypeContainer.AddMemberType): Rename from
10062 AddToTypeContainer.
10063 (TypeContainer.AddMember): Rename from AddToMemberContainer.
10064 (AddTypeContainer): New. Combine AddClassOrStruct and
10066 (AddPartial): Update. Add 'is_partial' argument.
10067 * roottypes.cs: Update to changes.
10068 * cs-parser.jay (push_current_class): New helper for handling
10069 current_container and current_class.
10070 (struct_declaration, interface_declaration, class_declaration):
10073 2006-07-26 Raja R Harinath <rharinath@novell.com>
10075 * roottypes.cs: Rename from tree.cs.
10077 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
10078 * tree.cs (Tree, ITreeDump): Remove types.
10079 * rootcontext.cs (tree, Tree): Remove fields.
10080 (root, ToplevelTypes): New.
10081 * *.cs: Update to rename.
10083 * tree.cs (Tree.RecordDecl): Remove.
10084 (RootTypes.AddToTypeContainer): Record the toplevel type in its
10086 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
10088 2006-07-23 Raja R Harinath <harinath@gmail.com>
10090 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
10091 DoFlowAnalysis and OmitStructFlowAnalysis here.
10092 (ec.With): Rename from WithUnsafe and generalize.
10093 (ec.WithCheckState): Remove. All users can be handled by 'With'.
10094 (ec.WithFlowAnalyis): New.
10095 * ecore.cs, expression.cs, statement.cs: Update.
10097 2006-07-22 Raja R Harinath <harinath@gmail.com>
10099 * statement.cs (Block.ResolveMeta): Simplify slightly.
10101 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
10102 multiple boolean fields. Convert InUnsafe, constant_check_state,
10103 check_state to flags.
10104 (CheckState, ConstantCheckState): Update.
10105 (InUnsafe): New read-only property.
10106 (FlagsHandle): Rename from CheckStateHandle and convert to handle
10108 (WithUnsafe): New helper similar to WithCheckState.
10109 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
10110 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
10112 2006-07-21 Raja R Harinath <rharinath@novell.com>
10114 Make comparisons use the same IL irrespective of whether they're
10115 in a 'checked' or 'unchecked' context: one of the issues in #78899
10116 * codegen.cs (EmitContext.CheckState): Make read-only property.
10117 (EmitContext.ConstantCheckState): Likewise.
10118 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10119 helper that implement a save/restore stack for CheckState
10120 values. This is the only way to change check-state.
10121 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10122 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10123 (CheckedExpr.EmitBranchable): New forwarding method.
10124 (UnCheckedExpr): Likewise.
10125 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10126 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10127 (Checked.Resolve, checked.DoEmit): Likewise.
10129 2006-07-20 Miguel de Icaza <miguel@novell.com>
10131 * anonymous.cs: Cache the resolved anonymous delegate, and return
10132 this so that the ResolveTopBlock is only triggered once, not
10135 Currently we trigger ResolvetopBlock twice due to a first pass of
10136 argument check compatibility, and a second pass that does the
10139 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10141 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10143 * rootcontext.cs (Reset): Add helper_classes.
10145 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10148 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10151 2006-07-13 Miguel de Icaza <miguel@novell.com>
10153 * statement.cs (Lock): Handle expressions of type
10154 TypeManager.null_type specially. Fixes #78770
10156 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10158 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10161 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10163 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10164 for accessors as well.
10165 * ecore.cs (EventExpr): Add AccessorTable.
10167 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10170 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10171 for CS0122 where appropriate.
10172 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10174 (Filter): Assembly can be null in the case of top level attributes.
10176 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10180 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10181 is done at global level.
10183 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10185 A fix for #77002, Implemented TypeForwarder support.
10187 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10188 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10189 * typemanager.cs (): Add type_forwarder_attr_type.
10191 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10193 * report.cs: Add CS0469 warning.
10195 2006-06-21 Martin Baulig <martin@ximian.com>
10197 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10198 the `try'-block, so we also report CS0016 etc. there.
10200 2006-06-21 Martin Baulig <martin@ximian.com>
10203 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10205 2006-06-21 Martin Baulig <martin@ximian.com>
10207 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10208 also report CS1686 for parameters.
10210 2006-06-21 Martin Baulig <martin@ximian.com>
10212 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10213 instead of an error if the value is not implicitly convertible to
10214 the switch types; fixes #77964.
10216 2006-06-21 Raja R Harinath <rharinath@novell.com>
10219 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10220 FieldBuilder is null.
10223 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10224 'left' and 'right' before error-checking.
10226 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10228 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10230 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10231 (FieldExpr.DoResolve): likewise.
10232 (PropertyExpr.InstanceResolve): likewise.
10233 (EventExpr.InstanceResolve): likewise.
10235 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10237 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10238 attribute applicable tests for attribute argument.
10240 2006-06-02 Raja R Harinath <rharinath@novell.com>
10243 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10244 (Binary.OverloadResolve_PredefinedIntegral): New.
10245 (Binary.OverloadResolve_PredefinedFloating): New.
10246 (Binary.OverloadResolve_PredefinedString): New.
10247 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10248 Follow the standard more closely, and treat numeric promotions in
10249 terms of overload resolution.
10250 (Binary.CheckShiftArguments): Simplify.
10252 2006-06-01 Raja R Harinath <rharinath@novell.com>
10254 * flowanalysis.cs (MyBitVector): Simplify representation.
10255 (MyBitVector.Clone): Avoid allocating BitArray.
10256 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10257 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10258 (*): Update. Change all references to MyBitVector.And and
10259 MyBitVector.Or to &= and |=.
10261 2006-05-29 Raja R Harinath <rharinath@novell.com>
10263 Fix cs0231-[34].cs.
10264 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10265 to param arguments too.
10267 2006-05-26 Miguel de Icaza <miguel@novell.com>
10269 * cs-parser.jay: Catch another parsing form for arglist being
10270 followed by other arguments. Fixes #78313.
10272 2006-05-24 Raja R Harinath <rharinath@novell.com>
10274 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10275 checking of out parameters to ...
10276 (FlowBranchingToplevel.Merge): ... here.
10277 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10278 set, propagate the origin upward, and only complain if there was
10280 (FlowBranchingException.AddContinueOrigin): Likewise.
10281 (FlowBranchingException.AddReturnOrigin): Likewise.
10282 (FlowBranchingException.AddGotoOrigin): Likewise.
10284 2006-05-23 Raja R Harinath <rharinath@novell.com>
10286 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10287 unreachable, skip it.
10288 (FlowBranchingException.Merge): Always propagate jumps, even if
10289 the finally block renders subsequent code unreachable.
10291 2006-05-18 Raja R Harinath <rharinath@novell.com>
10294 * statement.cs (Goto.Resolve): Move responsibility for resolving
10295 'goto' to FlowBranching.AddGotoOrigin.
10296 (Goto.SetResolvedTarget): New. Callback to set the
10297 LabeledStatement that's the target of the goto.
10298 (Goto.DoEmit): Use Leave instead of Br when crossing an
10299 unwind-protect boundary.
10300 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10301 LookupLabel and adjust to new semantics.
10302 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10303 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10304 Goto.SetResolvedTarget to update target.
10305 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10306 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10307 AddBreakOrigin & co. Delay propagation until ...
10308 (FlowBranchingException.Merge): ... this.
10310 * statement.cs (Block.Resolve): Always depend on flow-branching to
10311 determine unreachability. Kill workaround that originally emitted
10312 only one statement after an "unreachable" label (see infloop in
10315 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10316 This is still "wrong", but anything better would probably need a
10317 multi-pass algorithm.
10318 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10319 usage vector. Force current usage vector to be reachable, to
10320 optimistically signify backward jumps.
10321 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10323 (FlowBranchingLabeled.Merge): New. If no backward jump was
10324 detected, return the original salted-away usage vector instead,
10325 updated with appropriate changes. Print unreachable warning if
10327 * statement.cs (Block.Resolve): Don't print unreachable warning on
10328 a labeled statement.
10330 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10332 * driver.cs: Pass filename without path to AssemblyBuilder's
10333 AddResourceFile. Fixes bug #78407.
10335 2006-05-17 Raja R Harinath <rharinath@novell.com>
10337 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10338 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10339 (FlowBranching.MergeChild): Overwrite
10340 reachability information from Labeled branchings too.
10342 2006-05-16 Raja R Harinath <rharinath@novell.com>
10344 * statement.cs (Goto.Resolve): Merge jump origins here ...
10345 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10347 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10348 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10349 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10350 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10352 * statement.cs (Goto.Resolve): ... not here.
10353 (Goto.Emit): Remove CS1632 check.
10355 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10357 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10360 2006-05-11 Raja R Harinath <rharinath@novell.com>
10362 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10363 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10364 (FlowBranchingException.Label): Likewise.
10366 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10368 (MyBitVector.Or): Use it to avoid losing information (Count).
10369 (FlowBranching.MergeOrigins): Likewise.
10371 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10372 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10373 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10374 (UsageVector.ToString): Simplify.
10375 (UsageVector.MergeSiblings): Move here from ...
10376 (FlowBranching.Merge): ... here.
10377 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10380 2006-05-10 Raja R Harinath <rharinath@novell.com>
10382 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10383 null bitvector is treated as all-true.
10385 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10386 (MyBitVector): Rationalize invariants. 'vector != null' implies
10387 that we have our own copy of the bitvector. Otherwise,
10388 'InheritsFrom == null' implies all inherited bits are true.
10390 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10392 * statement.cs (LocalInfo): Add IsConstant.
10393 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10394 local variable for constants.
10396 2006-05-09 Raja R Harinath <rharinath@novell.com>
10398 * flowanalysis.cs (MyBitVector.Empty): New.
10399 (MyBitVector): Don't allow InheritedFrom to be null.
10400 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10401 (UsageVector, FlowBranching): Update to changes.
10403 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10404 recursion. The 'Parent == null' condition isn't sufficient for
10406 (FlowBranching.AddBreakOrigin): Likewise.
10407 (FlowBranching.AddContinueOrigin): Likewise.
10408 (FlowBranching.AddReturnOrigin): Likewise.
10409 (FlowBranching.StealFinallyClauses): Likewise.
10410 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10411 (FlowBranching.CheckOutParameters): Likewise.
10412 (FlowBranchingToplevel): Terminate all the above recursions here.
10413 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10414 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10416 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10418 (FlowBranchingToplevel): New. Empty for now.
10419 (FlowBranching.MergeTopBlock): Update.
10420 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10421 branching for the anonymous delegate.
10422 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10424 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10425 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10426 information at the start of the merge. Reorganize.
10428 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10430 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10432 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10434 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10435 to newly introduced ctor.
10437 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10438 message to one place.
10439 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10442 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10444 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10446 * ecore.cs (Expression.ResolveAsConstant): Updated.
10448 * statement.cs (ResolveMeta): Updated.
10450 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10452 * cs-parser.jay: __arglist cannot be used in initializer.
10454 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10457 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10460 2006-05-05 Raja R Harinath <rharinath@novell.com>
10462 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10463 (LabeledStatement): Add 'name' parameter.
10464 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10465 (Block.AddLabel): Update to changes.
10466 * cs-parser.jay (labeled_statement): Likewise.
10468 * flowanalysis.cs (BranchingType.Labeled): New.
10469 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10470 (FlowBranchingLabeled): New. Does nothing for now, but will
10471 eventually handle 'goto' flows.
10472 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10473 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10474 that's terminated ...
10475 (Block.Resolve): ... here.
10477 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10478 (UsageVector.MergeFinallyOrigins): Likewise.
10479 (FlowBranching.InTryOrCatch): Likewise.
10480 (FlowBranching.AddFinallyVector): Likewise.
10481 (FlowBranchingException): Update to changes.
10484 * statement.cs (Return.Resolve): Move error checking to ...
10485 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10486 (FlowBranchingException): Handle return origins like break and
10488 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10490 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10493 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10496 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10499 * class.cs (MethodData.Define): Do public accessor check only when method
10500 implements an interface.
10502 2006-05-04 Raja R Harinath <rharinath@novell.com>
10504 Remove special handling of 'break'
10505 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10506 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10507 (UsageVector.Break): Remove.
10508 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10510 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10512 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10513 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10515 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10518 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10519 be the interface member.
10521 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10524 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10525 for emitting small (int) values.
10527 2006-05-03 Raja R Harinath <rharinath@novell.com>
10530 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10531 control-flow passes through the 'finally' after merging-in all the
10532 control-flows from 'try' and the 'catch' clauses.
10534 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10535 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10536 always true at the only non-recursive entry point.
10537 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10538 FlowBranchingBreakable.
10539 (FlowBranchingLoop): Remove.
10540 * statement.cs (Return.DoResolve): Update to changes.
10543 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10544 (FlowBranching.CreateBranching): Handle it: create a
10545 FlowBranchingContinuable.
10546 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10547 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10548 except that it handles the 'continue' command.
10549 (FlowBranching.UsageVector.MergeOrigins): Rename from
10551 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10552 except that it overrides AddContinueOrigin.
10553 (FlowBranchingException): Override AddContinueOrigin, similar to
10555 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10556 Create a new branching around the embedded statement.
10557 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10558 control flow after the embedded statement.
10559 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10561 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10562 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10563 FlowBranchingBreakable.
10564 (FlowBranchingSwitch): Remove.
10567 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10568 error reporting to ...
10569 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10570 Rename from 'AddBreakVector'. Add new location argument. Return
10571 a bool indicating whether the 'break' crosses an unwind-protect.
10572 (FlowBranchingException.AddBreakOrigin): Add.
10573 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10574 flowbranching after updating with the effects of the 'finally'
10576 (FlowBranchingBreakable): New common base class for
10577 FlowBranchingLoop and FlowBranchingSwitch.
10579 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10580 embedded statement.
10581 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10583 2006-05-02 Raja R Harinath <rharinath@novell.com>
10585 * statement.cs (Do.Resolve): If the loop is infinite, set the
10587 (While.Resolve, For.Resolve): Set a barrier after the embedded
10588 statement. There's no direct control flow that goes from the end
10589 of the embedded statement to the end of the loop.
10590 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10591 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10592 above ensure that the reachability is correctly computed.
10594 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10595 (UsageVector.MergeBreakOrigins): If the current path is
10596 unreachable, treat it as if all parameters/locals are initialized.
10597 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10598 infinite loops before merging-in break origins.
10600 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10601 (Reachability.Reachable): Split part into ...
10602 (Reachability.Unreachable): ... this. Simplify.
10603 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10605 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10606 (Reachability.SetThrowsSometimes): Likewise.
10607 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10608 TriState.Always, use corresponding property.
10609 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10610 (Block.Resolve): Likewise. Remove some redundant checks.
10612 2006-05-02 Raja R Harinath <harinath@gmail.com>
10614 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10615 (Reachability.Meet): Don't bother checking AlwaysThrows --
10616 barrier is always set.
10617 (FlowBranchingBlock.Merge): Likewise.
10619 2006-05-01 Raja R Harinath <harinath@gmail.com>
10621 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10622 checks for unreachable.
10624 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10627 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10629 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10630 whether field is really assigned.
10632 2006-04-30 Raja R Harinath <harinath@gmail.com>
10634 * flowanalysis.cs (Reachability): Make 4-argument constructor
10636 (Reachability.Meet): Rename from 'And'. Remove static variant.
10637 (Reachability.Always): Rename from the highly misleading
10638 'Reachability.Never'.
10639 (FlowBranching.Merge): Update to changes. Mark an impossible
10640 situation with a 'throw'.
10641 (*): Update to changes.
10643 2006-04-29 Raja R Harinath <harinath@gmail.com>
10645 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10646 Remove 'Undefined'.
10647 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10648 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10649 (*): Update to changes.
10650 * statement.cs: Update to changes.
10652 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10655 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10657 2006-04-28 Raja R Harinath <harinath@gmail.com>
10659 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10662 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10663 argument to two arguments: an usage-vector and a bool. Move call
10664 to FlowBranching.Merge () ...
10665 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10667 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10668 handling of loop and switch reachability to ...
10669 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10671 2006-04-27 Raja R Harinath <harinath@gmail.com>
10673 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10674 handling to FlowBranchingLoop.InLoop.
10675 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10677 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10680 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10681 anonymous method is allowed from AnonymousContainer here.
10683 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10685 2006-04-24 Raja R Harinath <rharinath@novell.com>
10688 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10690 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10693 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10694 (DoubleConstant.Reduce): Ditto.
10696 2006-04-23 Raja R Harinath <rharinath@novell.com>
10698 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10699 Remove 'lvalue_right_side' argument. Move parts to ...
10700 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10701 (LocalVariable.DoResolveLValue): ... these.
10703 2006-04-21 Raja R Harinath <rharinath@novell.com>
10706 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10707 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10708 (LocalVariableReference.DoResolveBase): Use it to implement new
10710 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10711 (Argument.Resolve): Simplify. Move CS1510 check ...
10712 * ecore.cs (Expression.ResolveLValue): ... here.
10713 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10714 (PropertyExpr.DoResolveLValue): Likewise.
10715 (FieldExpr.Report_AssignToReadonly): Likewise.
10716 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10717 LValueMemberAccess or LValueMemberOutAccess on instance depending
10719 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10720 DoResolve as appropriate.
10722 2006-04-20 Raja R Harinath <rharinath@novell.com>
10725 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10726 implicit conversions on 'out' and 'ref' arguments.
10728 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10729 improve clarity. Remove dead code.
10732 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10733 (Catch.Resolve): Resolve VarBlock if it exists.
10735 2006-04-19 Miguel de Icaza <miguel@novell.com>
10737 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10738 twice, this was some residual code, the enumerator was emitted
10739 properly in the two branche of if later.
10741 2006-04-19 Raja R Harinath <rharinath@novell.com>
10743 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10744 cast is never an lvalue.
10745 (Cast.DoResolve, Cast.ResolveRest): Combine.
10746 (Argument.Emit): Simplify slightly. Move 'Expr is
10747 IMemoryLocation' check ...
10748 (Argument.Resolve): ... here.
10749 (Argument.Error_LValueRequired): Remove. Inline into only user.
10751 Simplifications. Fix cs0191-2.cs
10752 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10753 CS1649 and CS1651 to ...
10754 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10755 the actual selection of the error code and message to a lookup
10756 table. Add a dummy return value to simplify callsites.
10757 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10758 readonly fields of other instances of the same type. Move CS0197
10760 * expression.cs (Argument.Resolve): ... here. Simplify code.
10761 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10762 resolution of an out or ref argument. The code simplification
10763 above uses this invariant.
10765 2006-04-18 Raja R Harinath <rharinath@novell.com>
10767 Possibly fix #77752. Fix cs1690-[4-7].cs.
10768 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10769 CheckMarshallByRefAccess. Drop parameter.
10770 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10772 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10773 InstanceExpression.
10774 * report.cs (AllWarnings): Add CS1690.
10775 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10776 for ref access too.
10777 (LocalVariableReference.DoResolveBase): Update.
10779 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10781 * class.cs (MethodOrOperator): Moved common parts from method class.
10782 detect obsolete attributes.
10783 (Method.Define): Simplified as it reuses code from base.
10784 (Constructor.ValidAttributeTargets): Fixed issue found during
10786 (Destructor.ValidAttributeTargets): Fixed issue found during
10788 (Operator): Finished refactoring set off by #78020. Operator class is now
10789 ordinary method class.
10791 * anonymous.cs: Updated.
10793 * decl.cs (DeclSpace): Add IsGeneric
10795 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10797 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10799 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10801 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10802 detect obsolete attributes.
10803 (Method.CreateEmitContext): Moved to MethodOrOperator.
10805 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10808 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10809 customized exception to make crash detection easier.
10810 (MethodOrOperator): Started to work on new base class for methods and
10812 (Method): Derives from MethodOrOperator.
10813 (Constructor.Emit): Emits its own attributes.
10814 (AbstractPropertyEventMethod.Emit): Ditto.
10815 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10817 (Operator.Emit): It's temporary more tricky than should be.
10819 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10821 * report.cs (InternalErrorException): Add ctor with inner exception.
10823 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10826 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10829 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10832 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10835 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10837 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10838 attribute is present and Guid not.
10839 (Interface.ApplyAttributeBuilder): Ditto.
10841 * attribute.cs: Add error message.
10843 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10847 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10848 sources (it's composite) so hold them in extra array as they are used in
10849 Emit phase only. It worked in the previous versions by mistake.
10850 (Attribute.Emit): Emit attribute for more owners when exist.
10852 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10853 it has now different behaviour.
10855 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10857 * constant.cs (Constant.IsDefaultInitializer): New method.
10859 * class.cs: Updated.
10861 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10862 re-initialize default values. It saves KBs almost for every assembly.
10863 Thanks Zoltan for the idea.
10864 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10865 (ArrayCreation.DoResolve): Resolve only once.
10866 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10867 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10869 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10871 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10874 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10876 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10877 in an embedded statement too.
10879 2006-04-01 Raja R Harinath <rharinath@novell.com>
10882 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10884 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10888 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10891 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10893 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10895 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10898 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10899 LocalTemporary change.
10901 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10903 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10904 initializers optimization.
10905 (ClassOrStruct.TypeAttr): Moved from modifiers.
10906 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10907 (FieldBase.ResolveInitializer): Resolves initializer.
10908 (FieldBase.HasDefaultInitializer): New property.
10910 * cs-parser.jay: Removed message.
10912 * expression.cs (CompilerGeneratedThis): New specialization.
10914 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10916 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10918 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10920 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10922 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10923 be now EnumConstants only.
10925 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10927 * attribute.cs, driver.cs: Reset more caches.
10929 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10931 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10933 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10935 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10936 for easier reuse. Updated all overrides.
10937 (IntegralConstant): New base class for all integral constants.
10938 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10939 of the constant range, report custom error.
10940 (UIntConstant.Reduce): Fixed uint conversion.
10942 * ecore.cs, literal.cs: Reduce updates.
10944 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10948 * class.cs (Constructor.Define): Removed extra if for default ctors.
10949 A patch from Atsushi Enomoto.
10951 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10953 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10954 GetAttributableValue.
10956 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10959 * convert.cs (ImplicitConversionRequired): Error message moved to
10962 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10963 automatic implicit conversion of an output value.
10964 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10966 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10968 (TypeOf.GetAttributableValue): Add extra handling for object type.
10970 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10971 special error message.
10973 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10975 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10977 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10978 compatible with MS runtime.
10980 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10982 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10983 attribute arguments here.
10985 * class.cs (Indexer.Define): The check was moved to attribute class.
10987 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10989 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10990 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10993 2006-03-22 Raja R Harinath <rharinath@novell.com>
10995 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10996 mcs to keep code differences small.
10997 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10998 * typemanager.cs (parameter_default_value_attribute_type): New.
10999 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
11002 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11004 * expression.cs (StringConcat.Append): Reverted back to no warning state.
11006 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11008 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
11010 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
11013 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
11015 * doc-bootstrap.cs : fix build.
11017 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11019 * expression.cs (StringConcat.Append): Issue a warning when empty string
11020 is going to append.
11022 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11024 * assign.cs (CompoundAssign.ResolveSource): Removed.
11026 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
11029 * class.cs (TypeContainer.FindMethods): Removed.
11030 (TypeContainer.CheckMemberUsage): Made static.
11032 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
11034 * constant.cs (CheckRange): Removed unused type argument.
11035 (CheckUnsigned): Removed unused type argument.
11037 * cs-parser.jay: Updated after MemberAccess clean up.
11038 Uses Length for empty string test.
11040 * cs-tokenizer.cs: Uses Length for empty string test.
11041 (IsCastToken): Made static.
11042 (is_hex): Made static.
11043 (real_type_suffix): Made static.
11045 * decl.cs (SetupCache): Made static.
11046 (OnGenerateDocComment): Removed unused ds argument.
11048 * delegate.cs (VerifyDelegate): Removed unused argument.
11050 * doc.cs: Uses Length for empty string test.
11052 * driver.cs: Uses Length for empty string test.
11054 * enum.cs (IsValidEnumType): Made static
11056 * expression.cs (EnumLiftUp): Removed unused argument.
11057 (ResolveMethodGroup): Ditto.
11058 (BetterConversion): Ditto.
11059 (GetVarargsTypes): Ditto.
11060 (UpdateIndices): Ditto.
11061 (ValidateInitializers): Ditto.
11062 (MemberAccess.ctor): Ditto.
11063 (GetIndexersForType): Ditto.
11065 * flowanalysis.cs: (MergeFinally): Removed unused argument.
11067 * iterators.cs: Updated after MemberAccess clean up.
11069 * location.cs: Uses Length for empty string test.
11071 * namespace.cs: Uses Length for empty string test.
11073 * report.cs (CheckWarningCode): Made static.
11075 * statement.cs (LabeledStatement): Removed unused argument.
11077 * typemanager.cs (FilterNone): Removed.
11079 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11081 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
11084 * class.cs: Updated.
11086 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11088 * cs-parser.jay.cs: __arglist is not allowed for delegates.
11090 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11094 * expression.cs (VerifyArgumentsCompat): Reverted to double error
11095 reporting, it's more tricky than I thought.
11097 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11101 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
11103 (AnonymousMethod.ImplicitStandardConversionExists): New method.
11104 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
11105 Add more error reporting; Fixed issue with params.
11107 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
11109 * cs-parser.jay: AnonymousMethod requires host container.
11111 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
11113 2006-03-18 Raja R Harinath <harinath@gmail.com>
11115 * class.cs: Change 'TypeContainer ds' constructor argument to
11116 'DeclSpace parent'. Some classes were missed below due to
11117 different naming convention.
11119 * class.cs (MemberCore.Parent): Delete. This makes the
11120 ParentContainer changes below enforceable by the compiler.
11122 Treat pointers to enclosing declaration space as 'DeclSpace', not
11124 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11125 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11127 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11129 (Block.AddThisVariable): Likewise.
11130 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11131 (AbstractPropertyEventMethod.Emit): Likewise.
11132 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11133 (GetMethod.Define, SetMethod.Define): Likewise.
11134 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11135 (DelegateMethod.EmitMethod): Likewise.
11137 Fix regression test-partial-13.cs.
11138 Rationalize use of PartialContainer. Ensure that the partial
11139 class semantics can be tied to type-correctness, i.e., any
11140 violation will cause a compile error.
11141 * class.cs, const.cs: Access all fields that belong to class
11142 TypeContainer via ParentContainer. Arguments of EmitContexts and
11143 Resolve()-like functions still use 'Parent'.
11145 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11146 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11147 (PropertyMethod.CheckModifiers): Remove unused argument.
11148 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11151 2006-03-17 Raja R Harinath <harinath@gmail.com>
11153 Make semantics of PartialContainer simpler.
11154 * decl.cs (DeclSpace.IsPartial): Remove.
11155 * class.cs (TypeContainer.IsPartial): Likewise.
11156 (TypeContainer..ctor): Set PartialContainer to point to self.
11157 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11158 (TypeContainer.FindNestedType): Likewise.
11159 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11161 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11163 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11165 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11167 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11170 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11172 * class.cs (Operator.Define): An error for base conversion was not
11173 reported correctly.
11175 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11177 * iterator.cs : yield break is allowed in try statement which has
11178 catch clauses. Fixed bug #77767.
11180 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11182 A fix for #77593, #77574.
11184 * class.cs (MethodCore.CheckBase): Another if for operator.
11186 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11188 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11191 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11192 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11195 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11198 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11199 Updated after another emitcontext usage was clean up. It should help us to
11200 synchronize with gmcs easier.
11202 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11206 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11207 (Event.Define): ditto
11208 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11210 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11211 Removed redundant code and set NewSlot for Invoke method too.
11213 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11214 (Parameters.MergeGenerated): New method. Use this method when you merge
11215 compiler generated argument with user arguments.
11217 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11219 * attribute.cs (ResolveAsTypeTerminal): Removed.
11221 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11222 specialization for predefined types; 30% speed up.
11223 Finally placed obsolete check to right place.
11224 (Expression.ResolveType): Removed.
11226 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11227 Updated after ResolveType was removed.
11229 * expression.cs (Cast.ctor): Check void cast.
11230 (Binary.ResolveAsTypeTerminal): Is never type.
11231 (Conditional.ResolveAsTypeTerminal): Is never type.
11233 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11235 2006-03-01 Raja R Harinath <rharinath@novell.com>
11238 * expression.cs (ParameterReference.DoResolveBase): Change return
11240 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11244 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11247 * typemanager.cs (GetFullNameSignature): Don't nullref on
11248 protected accessors.
11250 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11252 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11253 these two separated members to simplify the code.
11254 (Attribute.Resolve): Refactored to use new fields and methods.
11255 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11256 implemented obsolete attribute checking.
11257 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11258 implemented obsolete checking again. It look line never ending quest ;-)
11259 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11261 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11263 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11265 *class.cs (Property.Define): Add RegisterProperty call.
11267 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11268 argument groups (only 2).
11270 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11271 encoding expression to arguments.
11272 (Expression.ExprClassToResolveFlags): Just turned to property.
11274 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11275 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11276 optimized as well as implemented support for zero-length attributes.
11278 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11279 Add caching of PropertyInfo's.
11281 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11283 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11284 error multiple times.
11286 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11288 New partial class implementation.
11289 A fix for #77027, #77029, #77403
11291 * attribute.cs (Attributable): Made attributes protected.
11293 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11294 the replacements of ClassPart and PartialContainer.
11295 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11296 (TypeContainer.AddInterface): Ditto.
11297 (TypeContainer.AddPartial): The main method for partial classes. It checks
11298 for errors and merges ModFlags and attributes. At the end class is added to
11299 partial_parts list.
11300 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11302 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11303 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11304 from the rest of partial classes.
11305 (TypeContainer.GetClassBases): Simplified.
11306 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11308 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11309 (TypeContainer.HasExplicitLayout): Uses Flags now.
11310 (PartialContainer): Removed.
11311 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11312 (StaticClass): Was merged with Class.
11313 (Class.GetClassBases): class and static class bases are verified here.
11314 (Class.TypeAttr): Added static attributes when class is static.
11315 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11316 (MemberBase): In some cases we need to call parent container for partial
11317 class. It should be eliminated but it's not easy now.
11319 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11321 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11322 partial classed to accumulate class comments.
11323 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11325 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11327 * driver.cs (MainDriver): Tree.GetDecl was removed.
11329 * modifiers.cs (Modifiers): Add partial modifier.
11331 * tree.cs (Tree.decl): Removed.
11332 (RootTypes): Started to use this class more often for root types
11335 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11339 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11340 external interface does not have an attribute.
11342 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11344 Another prerequisites for new partial classs implementation.
11346 * attribute.cs (Attribute.Equal): Implemented.
11347 (Attribute.Emit): Changed as attributes can be applied more than twice.
11348 (Attributes.Emit): Check for duplicate attributes here.
11350 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11351 as a parameter, clean-up.
11353 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11357 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11358 contains obsolete attribute check which can in some cases look for base
11359 type of current class which is not initialized yet.
11360 (TypeContainer.BaseType): Replacement of ptype.
11362 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11364 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11366 First of prerequisites for new partial classs implemention.
11368 * attribute.cs (Attributable): Extended by ResolveContext;
11369 Attributes finally have correct context for resolving in all cases.
11370 (AttachTo): Attribute owner is assigned here.
11372 * codegen.cs (IResolveContext): Introduce new interface to hold
11373 all information needed in resolving phase.
11374 (EmitContext): Implements IResolveContext; more clean-up needed here.
11376 * decl.cs (MemberCore): Implemented IResolveContext.
11378 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11379 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11380 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11381 Refactored to use new IResolveContext instead of EmitContext; cleanup
11383 2006-02-06 Miguel de Icaza <miguel@novell.com>
11385 * codegen.cs (EmitScopeInitFromBlock): check here the
11386 capture_context, there is no need to make two calls to the
11389 * anonymous.cs: Add some debugging messages that might help me
11390 track other instances of this problem in the future (the
11391 regression of test 467).
11393 * cs-parser.jay: track the variable block, as we need to initalize
11394 any captured variables declared in this block for the "catch"
11395 portion of the "Try" statement.
11397 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11398 scope initialization for captured variables.
11400 Also, move the emit for the variables after the block location has
11403 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11405 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11407 2006-02-02 Miguel de Icaza <miguel@novell.com>
11409 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11410 commit yesterday, the initialization for the roots is necessary.
11411 What is not necessary is the scope activation.
11413 2006-02-02 Raja R Harinath <rharinath@novell.com>
11415 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11416 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11418 (Argument.Resolve): Remove CS0206 checks.
11420 2006-02-01 Miguel de Icaza <miguel@novell.com>
11422 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11423 scopes for all the roots, the scopes will now be emitted when the
11424 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11426 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11427 code. This reduces a lot of existing cruft.
11429 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11430 that the ScopeInfo is generated as we enter the scope, not at the
11431 time of use, which is what we used to do before.
11433 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11434 every time a Block is about to be emitted if we have a
11437 2006-02-01 Raja R Harinath <rharinath@novell.com>
11439 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11441 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11443 * typemanager.cs (cons_param_array_attribute): Make private.
11444 (Reset): Set it to null.
11445 (InitCoreHelpers): Don't initialize it.
11446 (ConsParamArrayAttribute): New. Initialize it as needed.
11447 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11449 2006-01-31 Miguel de Icaza <miguel@novell.com>
11451 * expression.cs: There might be errors reported during the
11452 selection of applicable methods. If there are errors, do not
11453 continue execution as it will lead the compiler to crash.
11455 2006-01-30 Miguel de Icaza <miguel@novell.com>
11457 * expression.cs: Member access is not allowed on anonymous
11458 methods. Fixes #77402.
11460 2006-01-30 Raja R Harinath <rharinath@novell.com>
11463 * cs-parser.jay (VariableDeclaration): Don't set
11464 current_array_type to null.
11465 (field_declaration, event_declaration, declaration_statement):
11466 Set it to null here.
11468 2006-01-28 Raja R Harinath <harinath@gmail.com>
11470 * typemanager.cs (GenericParameterPosition): New.
11473 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11475 * doc.cs : To process "include" elements, first we should create
11476 another list than XmlNodeList, because it could result in node
11477 removal, which could result in that the XmlNodeList gives up
11478 yielding next node.
11480 (Also made code identical to gmcs again.)
11482 2006-01-25 Miguel de Icaza <miguel@novell.com>
11484 * ecore.cs: Introduce an error report that we were not catching
11485 before, if not silent, we must report the error. Gonzalo ran into
11488 2006-01-23 Miguel de Icaza <miguel@novell.com>
11490 A fix for bug: #76957
11492 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11493 ComputeMethodHost before creating the method, this is a new
11496 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11497 that this method references (RegisterScope). The actual scope
11498 where the method is hosted is computed with the ComputeMethodHost
11499 before we create the method.
11501 Moved the Deepest routine here.
11503 (AnonymousContainer.ComputeMethodHost): New routine used to
11504 compute the proper ScopeInfo that will host the anonymous method.
11506 (ScopeInfo): Deal with multiple roots. The problem was that we
11507 did not have a unique root where all ScopeInfos could be hanged
11508 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11511 Remove AdjustMethodScope which is now computed at the end. Remove
11512 LinkScope which did a partial link, instead link all ScopeInfos
11513 before code generation from the new "LinkScopes" routine.
11515 Simplify all the Add* routines as they no longer need to maintain
11516 the tree, they just need to record that they are using variables
11519 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11520 routines to produce the forest of ScopeInfo trees.
11522 * class.cs (TypeContainer.AppendMethod): This is just like
11523 AddMethod, but ensures that an interface implementation method
11524 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11525 methods, but at the end.
11527 We use this functionality to ensure that the generated MoveNext
11528 method in the iterator class is resolved/emitted before the
11529 enumerator methods created.
11531 This is required because the MoveNext method computes the right
11532 ScopeInfo for the method. And the other methods will eventually
11533 need to resolve and fetch information computed from the anonymous
11536 2006-01-21 Raja R Harinath <harinath@gmail.com>
11537 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11539 Fix rest of #76995.
11540 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11541 the 'aliases' hash.
11542 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11543 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11545 2006-01-18 Raja R Harinath <rharinath@novell.com>
11547 Fix #76656, cs0231-2.cs.
11548 * cs-parser.jay (formal_parameter_list): Make error case catch
11550 (parenthesized_expression_0): Add CS1026 check.
11551 (invocation_expression): Remove unused { $$ = lexer.Location }.
11553 2006-01-17 Raja R Harinath <rharinath@novell.com>
11556 * cs-parser.jay (statement_expression): Don't list out the
11557 individual statement-expressions. Convert syntax error into
11560 2006-01-16 Raja R Harinath <rharinath@novell.com>
11563 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11564 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11565 CheckIntermediateModification.
11566 (FieldExpr.DoResolve): Add new two-argument version that
11567 allows us to resolve the InstanceExpression as an lvalue.
11568 The one-argument variant is now just a wrapper.
11569 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11570 Resolve the lhs as an lvalue if the it has a value type.
11571 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11572 from Assign.DoResolve.
11573 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11574 resolved as an lvalue.
11575 (PropertyExpr.DoResolve): Update.
11576 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11577 has a value type. Move CS1612 check here from
11578 CheckIntermediateModification.
11579 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11580 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11581 'right_side' of a ResolveLValue on an 'out' argument.
11582 (EmptyExpression.LValueMemberAccess): New. Used as the
11583 'right_side' of a propagated ResolveLValue on a value type.
11584 (LocalVariableReference.DoResolveBase): Recognize
11585 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11587 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11588 EmptyExpression.Null.
11590 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11592 * typemanager.cs : added IsGenericParameter(). In mcs it always
11594 * doc.cs : for generic parameters, use GenericParameterPosition,
11597 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11599 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11601 2006-01-12 Miguel de Icaza <miguel@novell.com>
11603 This fixes the problem where we used ldfld instead of ldflda to
11604 load the "THIS" pointer on captured parameters, when THIS is a
11605 value type. See bug #77205.
11607 * iterators.cs (CapturedThisReference.Emit): Pass false to
11608 EmitThis (we do not need the address).
11610 * codegen.cs (EmitThis): it needs to know whether we need the
11611 address of `this' or not. This is used by value types.
11613 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11614 every other call passes false.
11616 2006-01-12 Raja R Harinath <rharinath@novell.com>
11619 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11621 * expression.cs (Invocation.OverloadResolve): Update.
11622 (Invocation.DoResolve): Avoid double resolution of invocation.
11624 2006-01-11 Raja R Harinath <rharinath@novell.com>
11627 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11628 unary negation of floating point types as 0-expr; negation cannot
11629 overflow in floating point types.
11632 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11633 on operands of 'void' type.
11636 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11637 and ExclusiveOr for boolean constants too.
11639 2006-01-09 Raja R Harinath <rharinath@novell.com>
11642 * expression.cs (Invocation.OverloadResolve): Replace reflected
11643 override methods with their base virtual methods, rather than
11644 skipping over them.
11645 * typemanager.cs (TypeManager.GetOverride): New.
11647 2006-01-05 Jb Evain <jbevain@gmail.com>
11649 * class.cs (Property.Define, Indexer.Define): do not tag the
11650 properties as SpecialName | RTSpecialName.
11652 2006-01-04 Miguel de Icaza <miguel@novell.com>
11654 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11655 doing a low-level comparission of parameter types. It was lacking
11656 a check for __argslist.
11658 2005-12-30 Miguel de Icaza <miguel@novell.com>
11660 * expression.cs (ParameterReference.DoResolveBase): Allow
11661 reference parameters if they are local to this block.
11663 This allows the ref and out parameters of a delegate to be used in
11664 an anonymous method, for example:
11666 delegate void set (out int x);
11668 set s = delegate (out int x){
11672 This is used by functionality introduced late in the C# language.
11674 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11675 method that take ref and out parameters.
11677 Fixes #77119 which was a late change in the spec.
11679 2005-12-23 Miguel de Icaza <miguel@novell.com>
11681 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11682 parent if its the same scope. Fixes #77060.
11684 2005-12-21 Miguel de Icaza <miguel@novell.com>
11686 * driver.cs: Report the case of no source files and no -out:
11689 2005-12-20 Raja R Harinath <rharinath@novell.com>
11692 * expression.cs (ComposedCast.GetSignatureForError): Define.
11694 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11698 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11699 ListDictionary, to contain the ExternAliasEntry entries (in
11700 addition to the NamespaceEntry.aliases hashtable). This field is
11701 shared between the original entry and its doppelganger (bodyless
11703 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11704 extern_aliases field.
11705 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11706 lookup in extern_aliases.
11708 2005-12-16 Raja R Harinath <rharinath@novell.com>
11711 * class.cs (TypeContainer.Mark_HasEquals): New.
11712 (TypeContainer.Mark_HasGetHashCode): New.
11713 (ClassPart): Override them.
11714 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11717 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11718 'parent' argument to the base constructor.
11720 Remove all mention of TypeContainer from decl.cs.
11721 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11722 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11723 (DeclSpace.DeclSpace): Likewise.
11724 (DeclSpace.DefineMembers): Remove unused argument.
11725 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11726 debugging check -- we don't care if the debug code throws an
11727 InvalidCastException instead of an InternalErrorException.
11728 * class.cs (TypeContainer.DefineMembers): Update to changes.
11729 (TypeContainer.DoDefineMembers): Likewise.
11730 (TypeContainer.GetMethods): Likewise.
11731 (PropertyMember.Define): Likewise.
11732 (MemberBase.Parent): New property that forwards to
11733 MemberCore.Parent, but ensures that we get a TypeContainer.
11734 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11735 (RootContext.PopulateTypes): Likewise. Remove special case code
11736 for !RootContext.StdLib: DefineMembers is idempotent.
11738 2005-12-14 Miguel de Icaza <miguel@novell.com>
11740 * convert.cs (ExplicitConversionCore): Check the return value from
11741 ExplicitConversionCore which can return null on failure. Fixes #76914
11743 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11745 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11747 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11749 * doc.cs : The search for referenced namespace was insufficient to
11750 get global one as it used to do. Fixed bug #76965.
11752 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11754 * doc.cs : check name in cref in the last phase that whether it is
11757 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11759 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11762 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11764 * doc.cs : so it turned out that we cannot skip override check for
11765 interface members. Fixed bug #76954.
11767 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11769 * cs-tokenizer.cs : fixed bug #75984:
11770 - #warning and #error should not be handled when the source line
11772 - #line is not checked strictly when the source line is disabled.
11773 - #define and #undef is on the other hand checked strictly at any
11776 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11778 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11781 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11783 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11785 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11786 event initializers.
11787 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11788 (FieldBase.Initializer): Initializer is now optional.
11789 (EventField.Define): Only event field can have initializer.
11791 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11793 * const.cs (Const): Reuse initializer.
11795 * cs-parser.jay: Updated after FieldBase changes.
11796 Added current_array_type to simplify array initializers.
11798 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11800 * expression.cs, iterators.cs: Updated.
11802 * namespace.cs (NamespaceEntry): Made UsingFound private.
11804 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11806 * parameterCollection.cs: Obsolete, removed.
11807 * parser.cs: Obsolete, removed.
11809 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11812 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11814 * enum.cs (Enum.Define): Set obsolete context here.
11816 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11819 - FindDocumentedMember() now expects 1) paramList as null
11820 when "we don't have to check the number of parameters" and
11821 2) Type.EmptyTypes when "there is no arguments".
11822 - Introduced FoundMember struct to hold the exact type which was
11823 used to find the documented member (the above change broke
11824 test-xml-044; it might be better just to use DeclaringType than
11825 what MS does, like this change does, but it depends on usage.)
11827 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11829 * doc.cs : documented member might be from DeclaringType for nested
11830 types. Fixed bug #76782.
11832 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11834 * anonymous.cs: Have the param code handle leaving copies on the
11835 stack etc. Allows anonymous params to take part in the assignment
11836 code (++, +=, etc). Fixes bug #76550
11838 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11839 it down to the anon code.
11841 * iterators.cs: Use dummy var here
11843 * codegen.cs: Handle new vars
11845 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11848 * class.cs (MethodData.Define): Set proper Obsolete context.
11850 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11852 (FieldExpr.DoResolve): Ditto.
11854 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11857 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11858 parent is not obsolete.
11860 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11862 * doc.cs : (FindDocumentedMember) find parameterless members first
11863 and get CS0419 in the early stage. Fixed first case of bug #76727.
11865 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11868 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11869 no error was reported.
11871 *expression.cs (Binary.DoResolve): left can be null.
11873 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11876 * class.cs (MethodData.Emit): Parameters should be labeled first.
11878 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11881 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11883 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11885 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11887 * class.cs (MethodCore): Parameter clean up.
11888 (IMethodData): Added ParameterInfo.
11889 (MethodData): Parameter clean up.
11890 (Indexer.Define): Parameter clean up.
11902 * typemanager.cs: Parameter clean up.
11904 * delegate.cs (Define): Get rid of duplicated code.
11906 * expression.cs (ParameterReference): Removed useless parameters
11908 (Invocation): Ditto.
11910 * parameter.cs (ParamsParameter): New class, params specialization.
11911 (ArglistParameter): Attemp to separate arglist.
11912 (Parameter): Refactored to be reusable and faster.
11913 (Parameter.Modifier): Made understandable.
11914 (Parameters): Changed to be used as a class for `this' assembly
11915 parameters. Refactored to use new specialized classes.
11917 * support.cs (ParameterData): Added Types property.
11918 (InternalParameters): Deleted.
11920 2005-08-20 Martin Baulig <martin@ximian.com>
11922 Merging this patch from GMCS to fix #75867.
11924 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11925 scope if we don't already have it.
11927 2005-11-17 Martin Baulig <martin@ximian.com>
11930 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11931 inherit the scope from our parent. Fixes #76653.
11933 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11935 * doc.cs : the previous patch does not actually fix the bug.
11936 PropertyInfo override check is now implemented and really fixed it.
11937 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11939 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11941 * doc.cs : apply "override filter" also to properties.
11944 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11946 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11947 no need to check overrides. For classes, omit those results from
11948 interfaces since they must exist in the class. Fixed bug #76726.
11950 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11952 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11953 with different parameters. Fixed the second problem in #76685.
11955 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11957 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11958 get expected 'protected' access in CheckValidFamilyAccess()).
11961 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11963 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11964 Fixed bug #76705. CS1569 was incorrectly commented out.
11966 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11968 * doc.cs : use Invocation.IsOverride() to do real override check.
11969 * expression.cs : made Invocation.IsOverride() internal.
11971 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11973 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11974 TypeBuilder.FindMembers() and filter overriden base members out.
11977 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11979 * doc.cs : ref/out parameters are represented as '@' (instead of
11980 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11982 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11984 * doc.cs : when there was no '.' in cref to methods in doc comment,
11985 then parameters were missing in the output. Fixed bug #76691.
11987 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11989 * driver.cs : don't output docs when there is an error.
11992 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11995 Now it should detect indexers. Fixed primary concern in bug #76685.
11996 Fixed CS0419 message to not show the identical member signature in
11999 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12001 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
12002 instead of Type.FindMembers() since it does not handle events.
12005 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
12007 * codegen.cs: Fixed typo (speficied -> specified).
12009 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12012 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
12014 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12016 * attribute.cs: Changed error message.
12018 * cs-tokenizer.cs: One more check.
12020 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12022 * statement.cs (Block.Resolve): Ignore empty statement.
12024 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12026 * report.cs: Made error/warning methods more strict to avoid
12029 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
12030 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
12031 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
12032 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
12034 2005-11-08 Marek Safar <marek.safar@seznam.cz>
12036 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
12037 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
12039 * class.cs (TypeContainer.IsComImport): New property.
12040 (Constructor.Define): Create proper ctor for ComImport types.
12042 * expression.cs (New.CheckComImport): Fixed.
12044 2005-11-07 Miguel de Icaza <miguel@novell.com>
12046 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
12047 that a parameter has been captured does not mean that we do not
12048 have to do the rest of the processing. This fixes the second part
12049 of #76592. If there was another anonymous method capturing
12050 values in the past, the Scope would never be set for the second
12051 method that captured the same parameter.
12053 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
12054 properly manipulate the stack. Second part of fix for #76592.
12056 * expression.cs (New): Add support for invoking "new" on
12057 interfaces that have been flagged with the ComImport attribute and
12058 the CoClass. Fixes #76637
12060 * statement.cs (Try.DoEmit): When a variable is captured, do not
12061 try to emit the vi.LocalBuilder variable as it has been captured.
12062 Create a temporary variable and store the results on the
12063 FieldBuilder. Fixes #76642
12065 2005-11-07 Marek Safar <marek.safar@seznam.cz>
12067 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
12069 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
12071 * expression.cs (Binary.DoResolve): Added && optimalization.
12073 * typemanager.cs (AddUserType): Removed useless argument.
12075 2005-11-04 Marek Safar <marek.safar@seznam.cz>
12077 * statement.cs (Block.variables): Uses ListDictionary.
12079 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12082 * class.cs (PartialContainer.EmitType): Customized to emit
12083 security attributes.
12084 (ClassPart.ApplyAttributeBuilder): Transform security attribute
12085 for partial classes.
12087 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12090 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
12091 access has to be fixed.
12093 * typemanager.cs (IsUnmanagedType): Wrong common field type.
12095 2005-11-01 Marek Safar <marek.safar@seznam.cz>
12098 * ecore.cs (NullCast.Reduce): Implemented.
12100 * expression.cs (ArrayCreation.CheckIndices): Correcly check
12103 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
12105 (Foreach.Resolve): Catch null properly.
12107 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12109 * cs-tokenizer.cs: Warning text fix.
12111 * driver.cs: AllWarningNumbers exposed on public interface.
12113 * report.cs (): Reviewed warning numbers.
12114 (IsValidWarning): Use binary search.
12116 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12118 * driver.cs: Implemeted resource visibility.
12119 (Resources): New class for code sharing between /res: and
12122 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12125 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12128 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12131 * ecore.cs (NullCast): Child is contant only.
12133 * literal.cs (NullLiteral.Reduce): null can be converted to any
12136 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12138 * driver.cs: Use Encoding.Default as default code page instead
12141 2005-10-27 Raja R Harinath <rharinath@novell.com>
12144 * expression.cs (Invocation.Error_InvalidArguments): Handle
12145 __arglist parameters.
12146 (Invocation.VerifyArgumentsCompat): Likewise.
12147 * support.cs (ReflectionParameters.GetSignatureForError): Print
12148 __arglist parameters.
12149 (InternalParamters.GetSignatureForError): Likewise.
12150 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12152 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12154 * attribute.cs (GetPropertyValue): Made public.
12156 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12158 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12160 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12163 * driver.cs: Reflect method name change.
12165 * statement.cs (Try.Resolve): Warn when try has both general
12166 exception handlers.
12168 * typemanager.cs: runtime_compatibility_attr_type new predefined
12171 2005-10-26 Raja R Harinath <harinath@gmail.com>
12174 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12175 treat it as an empty parameter list.
12177 2005-10-26 Raja R Harinath <rharinath@novell.com>
12180 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12181 ResolveAsTypeStep silent.
12182 * statement.cs (Block.AddConstant): Mark block as used.
12183 (Block.ResolveMeta): Avoid piling on error messages
12184 if a constant initializer resolution fails.
12186 2005-10-25 Raja R Harinath <rharinath@novell.com>
12188 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12190 (NamespaceEntry.VerifyAllUsing): New.
12191 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12192 behaviour. Delegates actual resolution of alias to ...
12193 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12194 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12196 * driver.cs (Driver.MainDriver): Update.
12198 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12199 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12201 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12203 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12204 RootNamespace.DefineNamespacesForAll.
12206 2005-10-24 Raja R Harinath <harinath@gmail.com>
12208 * typemanager.cs (assemblies, external_aliases, modules)
12209 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12210 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12211 overhead. Move resposibility ...
12212 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12213 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12215 2005-10-23 Raja R Harinath <harinath@gmail.com>
12217 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12218 cached_namespaces. Improve usage.
12219 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12220 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12221 Move from GlobalRootNamespace and simplify.
12222 (RootNamespace.Global): Make instance variable.
12223 (RootNamespace.RootNamespace): Add "alias name" parameter.
12224 (GlobalRootNamespace): Simplify drastically.
12225 (Namespace.Lookup): Don't use GetNamespace.
12226 * typemanager.cs (GetRootNamespace): Rename from
12227 ComputeNamespaceForAlias.
12228 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12230 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12232 * anonymous.cs (AnonymousContainer): Don't crash when container
12235 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12237 * expression.cs (Binary.DoResolve): Warn when comparing same
12240 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12243 * expression.cs (Binary.DoResolve): It looks like there are no
12244 convetsion rules in enum context.
12246 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12248 Add support for extern alias qualifiers.
12249 * typemanager.cs: Move some LookupTypeReflection code
12250 to namespace.cs, to have cleaner code. Added some methods
12251 to help us keep track of the extern aliased references.
12252 * driver.cs: Add suport for extern alias assemblies on command
12253 line and check for their warnings/errors. Also keep track of the
12254 extern aliased assemblies.
12255 * namespace.cs: Move the global functionality of Namespace
12256 to GlobalRootNamespace/RootNamespace. Now the global namespace
12257 is GlobalRootNamespace.Globa. Also the code moved from
12258 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12259 Finally added LocalAliasEntry (AliasEntry before) and
12260 ExternAliasEntry, to handle alias statements.
12261 * cs-parser.jay: Add support in the grammar for extern alias
12263 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12264 Update callings to Namespace (now in GlobalRootNamespace).
12266 2005-10-18 Raja R Harinath <rharinath@novell.com>
12269 * class.cs (TypeContainer.DefineType): Move updating of
12270 topological sort earlier in the code.
12271 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12273 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12276 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12278 * constant.cs (Constant.TryReduce): Moved from Cast class.
12279 (Reduce): Made little bit more OO and fixed missing conversions.
12281 * ecore.cs (Reduce): Implemented.
12282 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12284 * literal.cs (Reduce): Implemented.
12286 * class.cs: Reverted Miguel's wrong commit.
12288 2005-10-14 Miguel de Icaza <miguel@novell.com>
12290 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12292 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12294 * cs-parser.jay, expression.cs : CS0214 was missing error location
12295 for constants. Fixed bug #76404.
12297 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12300 * convert.cs (ExplicitConversionCore): Fixed object->enum
12303 2005-10-10 Raja R Harinath <rharinath@novell.com>
12305 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12306 InstanceExpression.
12307 (PropertyExpr.EmitCall): Likewise.
12308 * expression.cs (Invocation.EmitArguments): Handle case where
12310 (Invocation.EmitCall): Avoid allocating temporary variable if
12311 there are no arguments.
12313 2005-10-07 Raja R Harinath <rharinath@novell.com>
12316 * convert.cs (ImplicitConversionStandard): Move conversion of
12317 void* to arbitrary pointer types ...
12318 (ExplicitConversionStandard): .. here.
12319 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12320 error to always print typenames.
12322 2005-10-07 Raja R Harinath <rharinath@novell.com>
12324 * convert.cs (GetConversionOperator): Rename from
12325 GetConversionOperators. Move operator selection code from ...
12326 (UserDefinedConversion): ... here.
12328 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12330 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12333 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12335 * assign.cs (Assign.DoResolve): Error method changed.
12337 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12339 * const.cs (ResolveValue): Reset in_transit immediately.
12341 * constant.cs: Error method changed.
12343 * convert.cs: Removed useless location parameter.
12344 (ExplicitNumericConversion): Don't do double enum check.
12345 (ExplicitConversionCore): Renamed from ExplicitConversion.
12346 (ExplicitUnsafe): Extracted from ExplicitConversion.
12347 (ExplicitConversion): Uses for error reporting.
12349 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12351 (ResolveBoolean): Uses common error method.
12352 (CastToDecimal): Get rid of ec.
12353 (CastFromDecimal): Optimized.
12354 (ConvCast): Get rid of ec.
12356 * enum.cs (ResolveValue): Reset in_transit immediately.
12357 (Emit): Return after first error.
12359 * expression.cs: Convert changes.
12361 * literal.cs: Error method changed.
12363 * statement.cs: Error method changed.
12365 2005-10-03 Raja R Harinath <rharinath@novell.com>
12367 * support.cs (SeekableStreamReader.Position): Don't error out when
12368 the requested position is just beyond the end of the current
12371 2005-09-28 Raja R Harinath <rharinath@novell.com>
12373 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12374 try to keep in sync with the byte count of the underlying Stream.
12375 However, this limits us to a window size of 2048 characters: i.e.,
12376 the maximum lookahead of our lexer/parser can be 2048 characters.
12378 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12381 * driver.cs: Fix compilation files with full root path.
12383 2005-09-25 Miguel de Icaza <miguel@novell.com>
12385 * report.cs (SymbolRelatedToPreviousError): Format the output so
12386 it does not use an open parenthesis that is never closed.
12388 * driver.cs: Follow coding guidelines
12390 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12393 * const.cs (Const.ResolveValue): Check for assigning non-null
12394 value to reference type.
12396 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12398 * anonymous.cs: Implemented ExprClassName.
12400 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12403 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12406 * class.cs (StaticClass.DefineContainerMembers): Report protected
12409 * codegen.cs: if(ed) PRODUCTION.
12411 * convert.cs (Error_CannotImplicitConversion): Better error
12414 * cs-parser.jay: More error checks.
12416 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12418 * driver.cs (CSCParseOption): Enabled wrong option check.
12420 * ecore.cs (Expression.ExprClassName): Turned to property.
12421 (MemberExpr.CheckIntermediateModification): For checking boxed
12422 value types modification.
12424 * statement.cs (Fixed.Resolve): Expression type must be
12425 convertible to fixed type.
12426 (CollectionForeach.GetEnumeratorFilter,TryType):
12427 Small refactoring for easier error checking.
12429 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12431 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12434 * class.cs (GeneratedBaseInitializer): New class for customization
12435 compiler generated initializers.
12436 (MemberBase.DoDefine): Check Obsolete attribute here.
12437 (FieldMember.DoDefine): Ditto.
12439 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12442 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12443 (MemberCore.GetObsoleteAttribute): Removed argument.
12444 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12445 (MemberCore.CheckObsoleteType): New helper.
12449 * statement.cs: Updates after MemberCore changes.
12451 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12452 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12454 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12455 obsolete attribute for compiler construct.
12456 (As.DoResolve): Cache result.
12458 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12460 2005-09-26 Raja R Harinath <rharinath@novell.com>
12463 * expression.cs (This.VerifyFixed): In a value type T, the type of
12464 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12465 value type R, 'this' is treated as a value parameter.
12467 2005-09-22 Miguel de Icaza <miguel@novell.com>
12469 * statement.cs (Lock): Use the TemporaryVariable class instead of
12470 manually using local variables as those do not work when variables
12473 * ecore.cs: Moved the TemporaryVariable class from being a nested
12474 class inside Foreach to be a public class that can be employed in
12477 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12479 * cs-parser.jay: interface_accessors replaced by
12480 accessor_declarations.
12482 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12485 * statement.cs (GotoCase.Resolve): Convert null constant to
12487 (SwitchLabel.ResolveAndReduce): Ditto.
12488 (SwitchLabel.NullStringCase): Custom null stamp.
12489 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12491 typemanager.cs (CSharpSignature): Don't skip first argument
12494 2005-09-18 Miguel de Icaza <miguel@novell.com>
12496 * driver.cs: Set InEmacs based on the environment variable EMACS.
12498 * location.cs (InEmacs): in this mode, do not report column
12499 location as it confuses Emacs.
12501 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12503 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12504 expression.cs, iterators.cs, literal.cs: Store constants and
12507 * class.cs (MemberBase.ShortName): Pass location.
12509 * cs-parser.jay: Some location fixes.
12511 * ecore.cs (Expression.Location): Made virtual.
12513 2005-09-05 Miguel de Icaza <miguel@novell.com>
12515 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12516 if the underlying types are the same, otherwise we need to produce
12517 code that will do the proper cast.
12519 This was exposed by Marek's constant rewrite which produced
12520 invalid code for the call site:
12522 enum X : long { a }
12523 void Method (X v) {}
12527 This fixes test-49.cs
12529 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12531 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12532 Type/Object should be allowed as well. Fixed bug #75968.
12534 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12536 * expression.cs : (Binary.DoResolve): when one is enum constant and
12537 another is constant 0, then return enum one *as enum type*.
12540 2005-09-02 Raja R Harinath <rharinath@novell.com>
12542 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12546 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12547 flow-branching for LocalVariableReferences in case we were invoked
12548 from a MemberAccess.
12549 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12551 (LocalVariableReference.DoResolveBase): ... this.
12552 (MemberAccess.Resolve): Do the check that was disabled during
12555 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12558 (PartialContainer.Create): check abstract/sealed/static strictly
12559 but abstract/sealed can exist only at one side. Fixed bug #75883.
12561 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12564 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12565 specified, don't default to UnmanagedType.I4.
12567 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12569 * expression.cs : conditional operator should check possibly
12570 incorrect assign expression. Fixed bug #75946.
12572 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12574 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12575 Reverting the change. gmcs is much complex than mcs on this matter.
12577 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12579 * cs-tokenizer.cs : To read another token ahead of the actual
12580 consumption, use new SavedToken and cache token instead of moving
12581 back the stream with SeekableStreamReader (it seemed problematic).
12583 driver.cs : Thus use StreamReader directly.
12584 * support.cs : Thus removed SeekableStreamReader.
12586 2005-08-30 Raja R Harinath <rharinath@novell.com>
12589 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12590 (ScopeInfo.EmitScopeType): Use it to construct field names from
12591 names of captured locals.
12594 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12595 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12596 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12597 (ExplicitConversion): Remove enum cases already handled by
12598 implicit conversion. Move implicit conversion check to the beginning.
12599 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12600 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12601 Don't treat System.Enum as a struct.
12603 2005-08-30 Jb Evain <jbevain@gmail.com>
12605 * attribute.cs: handles as expression in parameters.
12607 2005-08-30 Raja R Harinath <rharinath@novell.com>
12610 * class.cs (TypeContainer.VerifyClsName): Don't use a
12611 PartialContainer when verifying CLS compliance.
12612 (AbstractPropertyEventMethod): Set Parent here, ...
12613 (PropertyMethod): ... not here.
12615 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12617 * attribute.cs : escaped attribute name should not be allowed to be
12618 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12620 2005-08-29 Raja R Harinath <rharinath@novell.com>
12623 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12624 when converting a long constant to unsigned long.
12625 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12626 detect where IsApplicable and VerifyArgumentsCompat disagree.
12628 2005-08-29 Raja R Harinath <rharinath@novell.com>
12629 and Carlos Alberto Cortez <carlos@unixmexico.org>
12632 * class.cs (TypeContainer.CanElideInitializer): New helper.
12633 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12634 can safely emitting the initializer of a field.
12636 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12638 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12639 allowed inside a switch (without loop). Fixed bug #75433.
12641 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12643 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12644 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12646 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12648 * driver.cs : kinda reverting the default encoding changes (not exact
12649 revert since I noticed that "codepage:reset" might not work fine).
12651 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12653 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12654 Location. Now getter and setter store location correctly.
12655 (errors/cs0111-12.cs now reports the expected location.)
12657 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12659 * driver.cs : Use default encoding on the environment.
12660 Removed (now that) extra parameter for SeekableStreamReader.
12661 * support.cs : (SeekableStreamReader) third .ctor() argument for
12662 StreamReader is not required (always true). preamble size could
12663 be acquired in simpler and safe way.
12665 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12667 * cs-parser.jay: report CS0642 at warning level 3
12668 and report CS0642 for an if else statement also
12669 fixes bug #74745. Patch by John Luke (and a bit
12671 Removed extra CS0642 warning check for "while",
12673 * statement.cs: In Block.Resolve(), CS0642 check
12674 is reimplemented to check a sequence of an empty
12675 statement and a block.
12677 Both fix bug #66777.
12679 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12681 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12682 detection until I fix it.
12684 * cs-tokenizer.cs: Changed error message.
12686 * cs-parser.jay: Fixed 2 error locations.
12688 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12689 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12692 * enum.cs (GetSignatureForError): Fixed.
12694 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12698 * typemanager.cs (RegisterProperty): Removed.
12700 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12702 2005-08-24 Raja R Harinath <rharinath@novell.com>
12705 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12706 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12708 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12710 * expression.cs : tiny fix is required for not warning positive ulong.
12713 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12715 * expression.cs : add CS0652 check for constant and integral
12716 expression. Fixed bug #53974.
12718 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12720 * expression.cs : in DoNumericPromotions(), check if there is implicit
12721 conversion overload for string (to check CS0034). Fixed bug #52492.
12723 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12725 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12727 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12729 * ecore.cs : report location when it is *not* Null.
12731 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12737 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12738 correctly. Fixed bug #75721.
12740 2005-08-23 Raja R Harinath <rharinath@novell.com>
12742 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12743 loop that performs 'min (pos, char_count)'.
12746 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12747 converted value in Operator.OnesComplement.
12749 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12751 * anonymous.cs: If the anon method is pulled into a helper class,
12752 it needs to be `internal' not `private'. Fixes runtime behavior on
12755 2005-08-20 Martin Baulig <martin@ximian.com>
12757 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12758 scope if we don't already have it.
12760 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12761 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12764 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12767 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12768 is a partial class.
12770 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12772 The big constants rewrite
12773 Fix #75746, #75685 and more
12774 As a side effect saved 1MB for MWF ;-)
12776 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12777 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12778 enum based for corlib compilation.
12780 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12783 * class.cs (FixedField.Define): Use ResolveAsConstant.
12785 * const.cs (IConstant): Interface constants and enums.
12786 (Const.ResolveValue): New method for constant resolvning.
12787 (ExternalConstant): Constants from imported assemblies.
12789 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12790 conversion; like enums.
12791 (Constant.ToType): Converts this constant to different type.
12792 (Constant.Increment): Adds 1.
12794 * convert.cs (ImplicitConversionRequired): Simplified.
12796 * cs-parser.jay: Create EnumMember directly.
12798 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12800 * doc.cs (GenerateEnumDocComment): Removed.
12802 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12803 (ConvertIntLiteral): Removed.
12804 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12806 * enum.cs (EnumMember): Implement IConstant.
12807 (Enum.IsValidEnumConstant): Removed.
12808 (Enum.GetNextDefaultValue): Removed.
12809 (Enum.FindMembers): Updated.
12810 (Enum.GenerateDocComment): Iterate enum members.
12812 * expression.cs (Cast.TryReduce): Handle enums correctly.
12813 (New.Constantify): Made public.
12814 (MemberAccess.DoResolve): Removed contant specific if(s).
12816 * literal.cs (NullLiteral): Implement new abstract methods.
12818 * statement.cs (GotoCase.Resolve): Use new constant methods.
12819 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12821 * typemanager.cs (LookupEnum): Removed.
12822 (IsEnumType): Fixed to work with corlib.
12823 (RegisterConstant): Removed.
12824 (LookupConstant): Removed.
12825 (GetConstant): Changed to work with IConstant.
12827 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12829 * location.cs : Fixed overflown (>255) column number.
12831 2005-08-03 Raja R Harinath <rharinath@novell.com>
12833 First cut of the qualified-alias-member feature.
12834 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12836 * cs-parser.jay (DOUBLE_COLON): New token.
12837 (namespace_or_type_name): Add rule for recognizing
12838 qualified-alias-members.
12839 (primary_expression): Likewise.
12840 (element_access): Allow QualifiedAliasMember as a possible
12841 type-bearing expression.
12842 (local_variable_type, local_variable_pointer_type): Likewise.
12843 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12844 aliases in the current and enclosing namespace declarations.
12845 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12846 * decl.cs (MemberName.is_double_colon): New.
12847 (MemberName.MemberName): Add new constructor for alias-member.
12848 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12849 * expression.cs (QualifiedAliasMember): New expression type.
12851 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12853 * location.cs : it borked when no argument was specified.
12855 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12857 * location.cs : tiny ToString() format fix.
12859 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12861 * statement.cs : oops, it was missing.
12863 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12865 A set of fixes for precise line/column location.
12868 "token" field now holds a file/line "delta", a line number offset
12869 from the segment, and a column number. See also:
12870 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12871 December/009508.html
12872 Removed static IsNull. Use instance IsNull property instead.
12873 * cs-tokenizer.cs :
12874 For some tokens it stores Location. For Identifier it stores
12875 LocatedToken which is a pair of string name and location.
12876 Column numbers are adjusted only at getChar().
12878 Use Location.ToString() for reporting (it now contains column).
12880 Largely modified to use LocatedToken instead of
12881 string (IDENTIFIER), and to acquire Location from some tokens.
12882 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12883 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12885 Now MemberName holds Location. DeclSpace.ctor() receives Location
12886 as a parameter. Removed extra parameters to all derived classes.
12887 Replaced Location.IsNull() with instance property.
12888 * assign.cs, expression.cs :
12889 Added .ctor() overload that omits Location.
12891 Added "nameEscaped" flag that indicates the identifier was escaped
12892 in the source file. This fixes bug #57047.
12894 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12896 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12897 New method, looking for lo-case imported cls type.
12899 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12902 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12904 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12906 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12907 all_imported_types.
12908 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12910 Optimized to save 3.5 MB for SWF compilation.
12912 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12914 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12915 (PartialContainer.Create): Moved logic AddToContainer.
12916 (PartialContainer.MarkForDuplicationCheck): Shares name.
12918 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12921 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12923 (Namespace.GetSignatureForError): New method.
12925 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12926 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12928 2005-08-01 Raja R Harinath <rharinath@novell.com>
12931 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12932 member lookup rather than qualifier_type, since qualifier_type can
12935 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12937 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12940 2005-07-31 Miguel de Icaza <miguel@novell.com>
12942 * statement.cs: Copy the local exception into the exception
12943 captured local. Fixes 75674
12945 2005-07-31 Raja R Harinath <harinath@gmail.com>
12948 * expression.cs (Invocation.OverloadResolve): Don't report error
12949 CS1501 if error CS1502 has been reported.
12950 (New.DoResolve): Delegate CS1501 reporting to
12951 Invocation.OverloadResolve.
12954 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12955 invariant-meaning-in-block property in an enclosing block if
12958 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12960 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12961 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12962 (Switch.CheckSwitch): Just save 50kb for SWF.
12964 2005-07-27 Martin Baulig <martin@ximian.com>
12966 * anonymous.cs (CaptureContext.AddField): Added
12967 `AnonymousContainer am' argument; compute its toplevel scope if
12968 it's not already computed. Fixes #75649.
12970 2005-07-26 Raja R Harinath <rharinath@novell.com>
12973 * class.cs (Constructor.Emit): Reset block to null if the block
12976 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12978 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12980 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12982 * class.cs (MethodData.Define): Check whether accessor implementing
12983 interface is public.
12985 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12987 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12990 * namespace.cs (LookupType): Moved same type check to...
12992 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12993 with the same name.
12995 2005-07-21 Raja R Harinath <rharinath@novell.com>
12997 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12998 already found a typebuilder.
12999 * class.cs (MethodCore.IsDuplicateImplementation): Compare
13000 MemberNames, not strings.
13002 * const.cs (Error_ExpressionMustBeConst):
13003 Rename from Error_EpressionMustBeConst.
13004 * const.cs, class.cs, statement.cd: Update.
13006 2005-07-21 Marek Safar <marek.safar@seznam.cz>
13010 * const.cs (Const.LookupConstantValue): Report missing contant expression
13012 (Error_EpressionMustBeConstant): Only one error method.
13014 * class.cs, statement.c: Updated.
13016 2005-07-20 Raja R Harinath <rharinath@novell.com>
13018 * statement.cs (Block.Flags): Add back HasVarargs.
13019 (Block.flags): Make protected.
13020 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
13022 * typemanager.cs (types, typecontainers, user_types): Remove.
13023 (UserTypes, TypeContainers): Likewise.
13024 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
13025 (CleanUp, Reset): Update.
13026 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
13027 (GetNestedType): Use Type.GetNestedType.
13028 (CoreLookupType): Take two arguments, the namespace and the
13029 basename of the type. Update to use the Namespace.Lookup
13031 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
13032 (RealMemberLookup): Use IsNestedChildOf instead of playing with
13033 string concatenation and substring matches.
13034 * class.cs, enum.cs, delegate.cs: Update to changes.
13036 2005-07-20 Marek Safar <marek.safar@seznam.cz>
13038 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
13039 Expression and made virtual.
13041 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
13042 (ImplicitStandardConversionExists): Fixed `byte' typo ?
13044 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
13046 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
13049 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
13052 2005-07-18 Marek Safar <marek.safar@seznam.cz>
13055 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
13056 AssemblyCultureAttribute is not used on executable.
13059 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
13061 2005-07-16 Raja R Harinath <rharinath@novell.com>
13064 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
13065 New. Reports CS0252/CS0253.
13066 Mostly taken from preliminary patch by Duncak Mak.
13067 (Binary.DoResolveOperator): Store results of operator lookup.
13068 Use them to detect if we need to warn about unintended reference
13071 2005-07-15 Raja R Harinath <rharinath@novell.com>
13074 * namespace.cs (Namespace.Lookup): Add back location parameter.
13075 (Namespace.LookupType): Add CS0436 report. Add location parameter.
13076 * delegate.cs, ecore.cs, expression.cs: Update to changes.
13078 * codegen.cs (EmitContext.DeclSpace): Make readonly.
13079 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
13080 (Namespace.LookupType): ... this.
13081 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
13083 * typemanager.cs (LookupTypeReflection): Remove buggy code that
13084 purported to handle pointers.
13085 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
13088 2005-07-15 Marek Safar <marek.safar@seznam.cz>
13090 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
13093 2005-07-15 Raja R Harinath <rharinath@novell.com>
13095 * namespace.cs (Namespace.Lookup): Drop location parameter.
13096 (NamespaceEntry.LookupAlias): Remove. Merge into ...
13097 (NamespaceEntry.Lookup): ... this.
13098 (NamespaceEntry.Error_AmbiguousTypeReference):
13099 Move here from DeclSpace.
13100 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
13102 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
13103 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
13104 Move to NamespaceEntry.
13105 * delegate.cs, expression.cs: Update to changes.
13107 2005-07-14 Marek Safar <marek.safar@seznam.cz>
13109 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
13110 CheckAttributeType and refactored.
13111 (Attribute.ResolvePossibleAttributeType): Changed to reuse
13112 ResolveAsTypeTerminal error handling.
13113 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13115 (GetSignatureForError): Print errors in same way.
13118 * codegen.cs: Reflect attribute GetSignatureForError change.
13121 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13123 * namespace.cs (UsingEntry): Refactored to make fields private.
13126 statement.cs: Error_UnexpectedKind has extra parameter.
13128 2005-07-14 Raja R Harinath <rharinath@novell.com>
13130 * ecore.cs (IAlias): Remove.
13131 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13132 that implement the interface.
13133 * namespace.cs (Namespace): Likewise.
13134 (Namespace.declspaces): Renamed from 'defined_names'.
13135 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13136 DeclSpace instead of an IAlias.
13137 * tree.cs (Tree.AddDecl): Update.
13139 2005-07-12 Raja R Harinath <rharinath@novell.com>
13141 * statement.cs (Block.Flags); Remove HasVarargs.
13142 (Block.HasVarargs): Move to ToplevelBlock.
13143 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13144 (Block.Variables): Make protected. Initialize variable hashtable
13146 (Block.AddVariable): Update.
13147 (Block.Resolve): Update to changes.
13148 (ToplevelBlock.HasVarargs): New boolean.
13149 (ToplevelBlock.ThisVariable): Move here from Block.
13150 (ToplevelBlock.AddThisVariable): Likewise.
13151 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13152 * expression.cs (This.ResolveBase): Update to changes.
13153 (ArglistAccess.DoResolve): Likewise.
13155 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13158 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13160 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13161 not used and not used & assigned.
13162 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13164 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13167 * expression.cs (Is.DoResolve): null is never provided type.
13169 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13172 * cs-parser.jay: Less strict event error rule to catch more errors.
13174 2005-07-08 Martin Baulig <martin@ximian.com>
13176 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13177 gettter (allowed) or setter (not allowed).
13179 * class.cs (Accessor): Implement IIteratorContainer.
13180 (Accessor.Yields): New public field.
13181 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13182 per-accessor basis.
13185 (get_accessor_declaration, set_accessor_declaration): Set the
13186 `yields' flag on the accessor, not the property.
13187 (property_declaration): Do the iterators check on a per-accessor
13188 basis and not for the whole property.
13190 2005-07-08 Martin Baulig <martin@ximian.com>
13192 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13193 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13195 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13198 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13199 (ExtractSecurityPermissionSet): Cope with self referencing security
13200 attributes properly.
13202 * driver.cs (SetOutputFile): Made public property OutputFile.
13204 2005-07-07 Raja R Harinath <rharinath@novell.com>
13207 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13208 has_nonstatic_fields. Make into a FieldBase pointer.
13209 (TypeContainer.AddField): Add CS0282 check.
13210 (TypeContainer.EmitType): Update.
13212 2005-07-06 Miguel de Icaza <miguel@novell.com>
13214 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13215 compare if they start with __.
13217 2005-07-06 Raja R Harinath <rharinath@novell.com>
13219 * statement.cs (Switch.SwitchGoverningType): Only look at
13220 UserCasts that don't need implicit standard conversions to one of
13221 the allowed switch types (Fixes test-322.cs).
13222 (LocalInfo.Resolve): Re-enable sanity-test.
13224 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13226 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13228 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13230 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13232 2005-07-06 Raja R Harinath <rharinath@novell.com>
13235 * ecore.cs (SimpleName.GetSignatureForError): Add.
13236 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13237 (MemberAccess.GetSignatureForError): Add.
13239 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13241 The big error and warning messages review.
13271 * typemanager.cs: Updated.
13273 * class.cs: (MethodCore.SetYields): Moved here to share.
13274 (PropertyMethod.Define): Moved iterator setup here.
13276 * iterators.cs: Add orig_method to have full access to parent
13279 2005-07-05 Raja R Harinath <rharinath@novell.com>
13281 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13282 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13283 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13284 variable of struct type.
13285 * expression.cs (Unary.ResolveOperator): Update to change.
13286 (Indirection.VerifyFixed): Likewise.
13287 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13288 (ParameterReference.VerifyFixed): Value parameters are fixed.
13289 (This.VerifyFixed): Treat 'this' as a value parameter.
13290 * statement.cs (LocalInfo.IsFixed): Remove.
13292 2005-07-01 Martin Baulig <martin@ximian.com>
13294 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13295 `ec.EmitThis ()' to get the correct scope.
13297 2005-07-01 Martin Baulig <martin@ximian.com>
13299 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13300 instance is a ParameterReference; fixes #75299.
13302 2005-07-01 Martin Baulig <martin@ximian.com>
13304 Reverted Marek's latest patch (r46725):
13305 - it contains structural changes which are neither mentioned in
13306 the ChangeLog nor explained anywhere; for example the additional
13307 argument of EmitContext's and Iterator's .ctor's and the
13308 TypeContainer.DefineMembers() change.
13309 - structural changes like this should go in in seperate patches
13310 and not be hidden in a huge patch which just seems to affect
13311 warnings and errors.
13312 a big and hard to understand patch.
13313 - it breaks iterators and causes regressions, for instance in
13316 2005-06-30 Raja R Harinath <rharinath@novell.com>
13319 * expression.cs (Indexers.map): Remove.
13320 (Indexers.Append): Filter out inaccessible setters and getters.
13321 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13324 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13325 Refactored from ...
13326 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13327 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13328 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13329 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13331 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13334 * class.cs (FieldBase.GetInitializerExpression): One more field
13337 2005-06-28 Miguel de Icaza <miguel@novell.com>
13339 * pending.cs: Do not define a proxy if the base method is virtual,
13340 it will be picked up by the runtime (bug 75270).
13342 2005-06-08 Martin Baulig <martin@ximian.com>
13344 The big Iterators rewrite :-)
13346 * iterators.cs: Rewrite this to use the anonymous methods framework.
13348 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13349 before the TypeContainers; see 2test-21.cs.
13352 (TypeContainer.DefineType): Don't create a new EmitContext if we
13353 already have one (this only happens if we're an Iterator).
13354 (TypeContainer.Define): Also call Define() on all our iterators.
13355 (Method.CreateEmitContext): Added support for iterators.
13358 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13359 (AnonymousContainer.CreateMethodHost): Moved here from
13360 AnonymousMethod and made abstract.
13361 (AnonymousContainer.CreateScopeType): New abstract method.
13362 (AnonymousContainer.IsIterator): New public property.
13363 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13364 get the ScopeTypeBuilder rather than manually defining it here.
13365 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13368 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13369 before RootContext.DefineTypes().
13371 * codegen.cs (EmitContext.RemapToProxy): Removed.
13372 (EmitContext.CurrentAnonymousMethod): Changed type from
13373 AnonymousMethod -> AnonymousContainer.
13374 (EmitContext.ResolveTopBlock): Protect from being called twice.
13375 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13376 (EmitContext.EmitThis): Removed the iterators hacks; use the
13377 anonymous methods framework for that.
13380 (ToplevelBlock.Container): Make this a property, not a field.
13381 (ToplevelBlock.ReParent): New public method; move the
13382 ToplevelBlock into a new container.
13383 (Foreach.TemporaryVariable): Simplify.
13385 2005-06-05 Martin Baulig <martin@ximian.com>
13387 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13388 (Block.AddTemporaryVariable): New public method; creates a new
13389 `LocalInfo' for a temporary variable.
13390 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13392 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13393 non-iterator variables.
13395 2005-06-05 Martin Baulig <martin@ximian.com>
13397 * statement.cs (Foreach.TemporaryVariable): Create the
13398 LocalBuilder in the Emit phase and not in Resolve since in some
13399 situations, we don't have an ILGenerator during Resolve; see
13400 2test-19.cs for an example.
13402 2005-06-04 Martin Baulig <martin@ximian.com>
13404 **** Merged r45395 from GCS ****
13406 The big Foreach rewrite - Part II.
13408 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13409 with `PropertyInfo ienumerator_getcurrent'.
13411 * codegen.cs (VariableStorage): Removed.
13414 (Foreach): Derive from Statement, not ExceptionStatement.
13415 (Foreach.CollectionForeach): New nested class. Moved all the code
13416 dealing with collection foreach here.
13417 (Foreach.ForeachHelperMethods): Removed.
13418 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13420 2005-05-23 Martin Baulig <martin@ximian.com>
13422 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13423 don't need to. Fix #75014.
13425 2005-05-20 Martin Baulig <martin@ximian.com>
13427 Merged r44808 from GMCS.
13429 * class.cs (TypeContainer.CircularDepException): Removed.
13430 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13431 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13432 (CS0146) and interface (CS0529) dependencies here.
13434 2005-06-21 Raja R Harinath <rharinath@novell.com>
13436 * expression.cs (Invocation.EmitCall): Fix initialization
13437 'this_call' to reflect current behaviour. Fix indentation.
13439 * convert.cs (FindMostEncompassedType): Add two trivial special
13440 cases (number_of_types == 0 || number_of_types == 1).
13441 (FindMostEncompasingType): Likewise.
13443 2005-06-17 Raja R Harinath <rharinath@novell.com>
13445 Some cleanups preparing for the fix of #75283.
13446 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13448 (EventExpr.InstanceResolve): Likewise.
13449 (EventExpr.DoResolve): Remove redundant checks.
13451 2005-06-10 Duncan Mak <duncan@novell.com>
13453 * cs-tokenizer.cs (process_directives): New flag for controlling
13454 the processing of preprocessor directives.
13455 (x_token): After seeing a '#', return Token.NONE instead of going
13456 to handle_preprocessing_directive() when not processing
13457 directives. This avoids unnecessary processing during the token peek in
13462 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13463 the existing error reporting methods instead of Report.Error.
13465 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13466 after Raja's rewrite.
13468 2005-06-08 Miguel de Icaza <miguel@novell.com>
13470 * class.cs: Small fix.
13472 2005-06-08 Raja R Harinath <rharinath@novell.com>
13475 * class.cs (GetPartialBases): Fix return value check of
13476 part.GetClassBases.
13478 2005-06-07 Raja R Harinath <rharinath@novell.com>
13480 Ensure that partial classes are registered in their enclosing
13481 namespace. Initial part of fix of #75160.
13482 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13483 Register declspace with namespace here, not in
13484 DeclSpace.RecordDecl.
13485 * cs-parser.jay: Pass namespace to RecordDecl.
13486 * class.cs (PartialContainer.Create): Likewise.
13487 (ClassPart.DefineType): New sanity-check. Throws an exception if
13489 * decl.cs (Declspace.RecordDecl): Remove.
13490 * namespace.cs (NamespaceEntry.DefineName): Remove.
13492 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13494 * rootcontext.cs: Reset TargetExt as well.
13496 2005-06-03 Raja R Harinath <rharinath@novell.com>
13498 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13499 -langversion:ISO-1.
13501 2005-06-02 Raja R Harinath <rharinath@novell.com>
13503 Fix #75080, cs0119.cs.
13504 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13506 (Expression.Resolve): ... this. Use it. Remove bogus code
13507 allowing ExprClass.Type and ExprClass.Namespace for
13508 ResolveFlags.VariableOrValue.
13509 (Expression.Resolve) [1-argument variant]: Change default resolve
13510 flags based on language version.
13511 (Expression.Error_UnexpectedKind): Use a simple string array
13512 rather than an ArrayList.
13513 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13514 not ExprClass.Type.
13515 (TypeOfVoid.DoResolve): Likewise.
13516 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13517 flags argument -- it always has the same value.
13519 2005-05-31 Raja R Harinath <rharinath@novell.com>
13522 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13523 Use it in the error message.
13524 * assign.cs, expression.cs, statement.cs: Update.
13526 2005-05-30 Raja R Harinath <rharinath@novell.com>
13529 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13530 the "almostMatchedMember" case too.
13531 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13532 that failed the accessibility checks to 'almost_match'.
13534 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13536 * attribute.cs: Use internal MethodBuilder methods to set
13537 ExactSpelling and SetLastError on PInvoke methods, instead
13538 of passing them via charset. Fixes #75060.
13540 2005-05-27 Raja R Harinath <rharinath@novell.com>
13542 * parameter.cs (Parameter): Remove TODO comment.
13543 (Parameter.DefineParameter): Remove Location parameter.
13544 (Parameters.LabelParameters): Likewise.
13545 * class.cs (Constructor.Emit): Update to change.
13546 (MethodData.Emit): Likewise.
13547 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13548 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13550 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13553 Removed Parameters.Location and added Parameter.Location instead.
13554 Removed Location parameter from Emit() and GetSignature().
13561 Modified all related calls.
13563 2005-05-26 Raja R Harinath <rharinath@novell.com>
13565 Improve user-defined conversion handling.
13566 * convert.cs (GetConversionOperators): Rewrite. Return only the
13567 applicable operators.
13568 (AddConversionOperators): New. Helper for GetConversionOperators.
13569 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13570 there is only one most encompassed/encompassing type.
13571 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13572 "applicable operator" handling.
13573 (UserConversion): Move cache here from GetConversionOperators.
13574 Directly cache the chosen operator, rather than the whole
13576 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13577 case. Allow conversion of decimal to sbyte and byte too.
13578 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13579 New static methods. Used to avoid allocating EmptyExpressions in
13582 2005-05-24 Duncan Mak <duncan@novell.com>
13584 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13585 another class, used in Convert.ExplicitNumericConversion.
13586 (CastToDecimal): New class, similar to above, but casts to
13587 System.Decimal, used in Convert.ImplicitNumericConversion and also
13588 in explicit convesion from double/float to decimal.
13590 * convert.cs (ImplicitNumericConversion): Handle implicit
13591 conversions to System.Decimal.
13592 (ExplicitNumericConversion): handle explicit conversions to
13597 2005-05-20 Miguel de Icaza <miguel@novell.com>
13599 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13600 know the type at this stage, just break through. Fixes #75008
13602 2005-05-19 Martin Baulig <martin@ximian.com>
13605 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13606 to disable error reporting.
13608 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13609 here since we don't want to report an error; see the new test-336.cs.
13611 2005-05-19 Raja R Harinath <rharinath@novell.com>
13613 * statement.cs (ToplevelBlock.GetParameterReference)
13614 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13615 Move here from class Block.
13616 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13617 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13619 2005-05-18 Martin Baulig <martin@ximian.com>
13624 (FlowBranching.Reachability): Add non-static public And() and Or()
13626 (FlowBranchingSwitch): New class; do the `break_origins' thing
13627 like in FlowBranchingLoop.
13628 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13629 reachability, not just locals and parameters.
13630 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13631 switch; MergeBreakOrigins() now takes care of that.
13633 2005-05-18 Martin Baulig <martin@ximian.com>
13635 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13636 a loop and may leave it, reset the barrier; fixes #74974.
13638 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13640 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13643 * cs-parser.jay: Catch more lexical errors.
13645 * report.cs: Add one more Error method.
13648 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13650 2005-05-17 Martin Baulig <martin@ximian.com>
13652 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13655 2005-05-16 Raja R Harinath <rharinath@novell.com>
13657 Fix test-382.cs. Emit values of decimal constants.
13658 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13660 (TypeContainer.AddField): ... this.
13661 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13662 with initializers to include 'Const's.
13663 (ClassPart.RegisterFieldForInitialization): Forward to
13665 * const.cs (Const.Const): Pass initializer to base class.
13666 (Const.Define): In case of decimal constants, register them for
13667 initialization in a static constructor.
13669 2005-05-14 Martin Baulig <martin@ximian.com>
13671 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13672 do not call ResolveUnreachable() on unreachable statements in
13673 here, see the comment in the source code.
13675 2005-05-13 Raja R Harinath <rharinath@novell.com>
13678 * expression.cs (BinaryResolveOperator): If one of the operands of
13679 an equality comparison is 'null' and the other is a pointer type,
13680 convert the null to a NullPointer.
13681 * convert.cs (ImplicitReferenceConversion): If the expression is a
13682 NullLiteral and the target type is a pointer type, return a
13683 NullPointer instead.
13684 (ImplicitConversionStandard): Likewise.
13686 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13688 * cs-parser.jay: Set readonly context based on special constructs.
13690 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13691 readonly variable error handling.
13693 * rootcontext.cs (EmitCode): Don't verify members when error
13696 * statement.cs (LocalInfo): Add reaodnly context information.
13697 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13699 2005-05-13 Raja R Harinath <rharinath@novell.com>
13701 * statement.cs (Block.Resolve): Revert change below. Modify fix
13702 for #74041 to initialize 'resolved' to false only for explicit
13703 blocks. Fixes #74873.
13705 2005-05-12 Raja R Harinath <harinath@gmail.com>
13708 * typemanager.cs (unmanaged_enclosing_types): New.
13709 (IsUnmanagedType): Avoid infloops by using
13710 'unmanaged_enclosing_types' to talk with recursive invocations.
13712 2005-05-13 Martin Baulig <martin@ximian.com>
13714 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13715 instance variable, not a local. Fix #74873.
13716 (Block.ResolveUnreachable): Set it to true here.
13718 2005-05-11 Duncan Mak <duncan@novell.com>
13720 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13721 continuing to process for 'arg'.
13722 (handle_preprocessing_directive): Check the argument of the #endif
13723 directive and report error CS1025 if there are any trailing
13726 According to the C# spec, having even whitespace after the #endif
13727 directive is illegal; however, because we call arg.TrimEnd ()
13728 beforehand, we have the same behavior as csc, allowing whitespace
13729 after the directive.
13733 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13737 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13738 (Constructor.GetObsoleteAttribute): Implemented correctly.
13740 2005-05-10 Martin Baulig <martin@ximian.com>
13742 * support.cs (ReflectionParameters.ParameterModifier): Use
13743 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13744 and `ParameterAttributes.In'. Fixes #74884.
13746 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13748 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13750 * expression.cs (Argument.GetParameterModifier): Turned to property.
13751 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13753 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13756 2005-05-09 Raja R Harinath <rharinath@novell.com>
13759 * decl.cs (MemberCache.AddMethods): Register override methods,
13760 rather than non-override methods.
13761 * typemanager.cs (RegisterOverride): New.
13762 (IsOverride): Update.
13764 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13768 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13769 recursive declaration.
13771 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13773 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13775 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13777 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13779 2005-05-05 Raja R Harinath <rharinath@novell.com>
13782 * decl.cs (DeclSpace.FamilyAccessible):
13783 Use TypeManager.IsNestedFamilyAccessible.
13785 Fix reopened #64812.
13786 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13789 2005-05-04 Raja R Harinath <rharinath@novell.com>
13790 Abin Thomas <projectmonokochi@rediffmail.com>
13791 Anoob V E <projectmonokochi@rediffmail.com>
13792 Harilal P R <projectmonokochi@rediffmail.com>
13795 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13796 allow access to all static members.
13798 2005-05-04 Martin Baulig <martin@ximian.com>
13800 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13802 2005-05-04 Martin Baulig <martin@ximian.com>
13806 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13807 section at the end; make things work if `default' is not the last
13810 2005-05-04 Martin Baulig <martin@ximian.com>
13814 * statement.cs (Switch): Replaced the `got_default' field with a
13815 `default_section' one.
13816 (Switch.CheckSwitch): Set `default_section' here.
13817 (Switch.Resolve): If we're a constant switch and the constant is
13818 not found, use the default section.
13820 2005-05-03 Martin Baulig <martin@ximian.com>
13822 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13824 * statement.cs (Foreach.ArrayForeach): New nested class.
13825 (Foreach.TemporaryVariable): New nested class.
13826 (Foreach.EmitArrayForeach): Removed; this is now in the new
13827 ArrayForeach class.
13829 2005-05-03 Raja R Harinath <rharinath@novell.com>
13831 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13833 (VerifyPendingMethods): Revert change below.
13835 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13836 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13837 that used to trigger warning -28. Remove warning -28.
13838 * expression.cs (Invocation.OverloadResolve): Use
13839 TypeManager.IsOverride to distinguish override methods.
13842 * pending.cs (VerifyPendingMethods): If a base type implements the
13843 requested interface, don't bother checking individual methods of
13844 the base type. As a side-effect, this prevents the creation of
13845 unnecessary proxies.
13847 2005-05-02 Martin Baulig <martin@ximian.com>
13851 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13852 Also `And' the locals if the old vector is null.
13853 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13854 null; in this case we basically reset all the variables.
13856 2005-05-02 Martin Baulig <martin@ximian.com>
13860 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13861 Added `FlowBranching branching' argument; always `and' the
13862 variables instead of `or'ing them unless we're an infinite loop.
13864 * statement.cs (While.Resolve): Create a new sibling unless we're
13867 2005-05-02 Martin Baulig <martin@ximian.com>
13871 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13872 arguments; use it instead of creating a new TopLevelBlock.
13873 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13874 our ConstructorInitializer.
13877 (TopLevelBlock.TopLevelBranching): New public property.
13878 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13879 and create our `TopLevelBranching'.
13881 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13882 anonymous method host, use `block.TopLevelBranching' rather than
13883 creating a new branching.
13885 2005-04-20 Miguel de Icaza <miguel@novell.com>
13887 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13888 a ScopeInfo, if any of the current children is a child of the new
13889 entry, move those children there.
13891 2005-04-30 Martin Baulig <martin@ximian.com>
13893 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13894 at the beginning of a SwitchSection. Fix #73335.
13896 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13899 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13901 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13902 (FieldExpr.DoResolve): Obsolete members are ignored for field
13905 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13907 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13908 of arrays detection.
13910 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13912 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13914 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13917 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13919 * cs-parser.jay: Use the prefered version of -unsafe in error
13922 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13924 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13927 2005-04-20 John Luke <john.luke@gmail.com>
13929 * driver.cs: fix typo in error message, --outout to --output
13931 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13933 * codegen.cs (InRefOutArgumentResolving): New field.
13935 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13936 fields outside contructor.
13938 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13940 2005-04-19 Miguel de Icaza <miguel@novell.com>
13942 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13943 parameter code was not completed ever, so it was not as up-to-date
13944 as local variables. Must finish it.
13946 The bug fix was to compare the Toplevel of the block, not the
13947 current block. Thanks for Ben for pointing this out.
13949 2005-04-19 Raja R Harinath <rharinath@novell.com>
13951 * decl.cs (AddMethods): Use the declaring type of the problem
13952 method to determine if we want to squash a warning.
13954 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13956 * attribute.cs: Removed debug output.
13958 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13960 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13963 2005-04-18 Raja R Harinath <rharinath@novell.com>
13966 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13967 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13968 all null comparisons against reference types.
13970 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13973 * class.cs (TypeContainer.CircularDepException) New nested
13975 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13976 (TypeContainer.DefineType): Removed error, reset InTransit before
13978 (Class.DefineType): Throw exception when is in Transit.
13979 Catch exception and report error.
13980 (Struct.DefineType): Throw exception when is in Transit.
13981 Catch exception and report error.
13982 (Interface.DefineType): Throw exception when is in Transit.
13983 Catch exception and report error.
13985 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13986 handle nested exception handlers.
13988 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13991 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13992 InFinally and InCatch storage.
13994 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13995 (Catch.Resolve): Set and Restore ec.InCatch.
13996 (Try.Resolve): Set and Restore ec.InFinally.
13997 (Try.HasCatch): True when try has catch.
13999 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
14001 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
14002 for the same event member, so exclude such cases from warning 419.
14005 2005-04-16 Miguel de Icaza <miguel@novell.com>
14007 * expression.cs (Binary.ResolveOperator): Apply patch from John
14008 Luke to fix bug 59864: operators &, | and ^ on enumerations
14009 require that the same enum type on both sides.
14011 * driver.cs: Add warnings to old flag usage, this is to assist
14012 people who produce Makefiles and hope that the Makefiles will be
14015 * class.cs (TypeContainer.EmitType): Moved the definition of the
14016 special $PRIVATE$ field from the resolve phase to the Emit phase.
14017 During resolve we do not know if we are a struct with
14018 HasExplicitLayout, we know this only after the attributes for the
14021 Set the FieldOffset to zero on the dummy field that we create for
14022 the class. Fixes 74590.
14024 2005-04-16 Raja R Harinath <rharinath@novell.com>
14027 * ecore.cs (PropertyExpr.resolved): New.
14028 (DoResolve): Use it to handle a case of double resolution here.
14029 Handle a case of identical-name-and-type-name.
14030 * expression.cs (ArrayCreation.CheckIndices): Avoid double
14031 resolution by storing the results of expression resolution back
14032 into the "probes" array.
14034 2005-04-15 Raja R Harinath <rharinath@novell.com>
14036 Fix cs0208-7.cs and cs0208-8.cs.
14037 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
14038 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
14039 error reporting to point out the reason a struct is not unmanaged.
14041 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14043 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
14044 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
14046 2005-04-13 Raja R Harinath <rharinath@novell.com>
14049 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
14050 IdenticalNameAndTypeName here.
14051 (EventExpr.InstanceResolve): Likewise.
14053 2005-04-13 Marek Safar <marek.safar@seznam.cz>
14055 C# 2.0 DefaultCharSetAttribute implementation
14057 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
14058 which allows us to set GlobalNamespace for every resolve.
14059 (Attribute.ResolveArguments): Cut from Resolve.
14060 (Attribute.GetCharSetValue): Returns CharSet named argument.
14061 (Attribute.DefinePInvokeMethod): Gets default charset from
14063 (GlobalAttribute.ResolveAsTypeStep): Override.
14064 (GlobalAttribute.ResolveArguments): Override.
14066 * class.cs (TypeAttr): Is protected.
14068 * codegen.cs (ModuleClass.DefaultCharSet): New member.
14069 (ModuleClass.DefaultCharSetType): New memeber.
14070 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
14072 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
14073 charset from module.
14075 * delegate.cs (TypeAttr): Override.
14076 (Delegate.DefineType): Use this TypeAttr.
14078 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
14079 at very early stage (before types are defined) to resolve model
14080 module attributes. It will probably not work with corlib but it
14083 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
14084 charset from module.
14086 * typemanager.cs (default_charset_type): New type.
14088 2005-04-13 Raja R Harinath <rharinath@novell.com>
14090 * decl.cs (MemberCache.AddMethods): Don't warn if
14091 System.Object.Finalize has buggy MethodAttributes.
14093 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
14096 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14098 * doc.cs : detect ambiguous reference to overloaded members.
14099 Fixed bug #71603. MS 1.1 csc does not detect it.
14101 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14103 * doc.cs : delegates must not be referenced with parameters.
14106 2005-04-12 Miguel de Icaza <miguel@novell.com>
14108 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
14110 2005-04-10 Miguel de Icaza <miguel@novell.com>
14112 * driver.cs (MainDriver): Stop processing if the CLS stage found
14115 (CompilerCallableEntryPoint.InvokeCompiler): Always
14116 reset after execution; Take a TextWriter argument for the
14119 * report.cs: Use the error stream instead of hardcoding stderr.
14121 2005-04-09 Miguel de Icaza <miguel@novell.com>
14123 * class.cs: Reduce code paths to test, too small of an
14124 optimization to make it worth the extra testing. Always perform
14127 2005-04-08 Raja R Harinath <rharinath@novell.com>
14130 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14131 operators that had errors reported on them.
14133 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14135 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14137 (Attribute.Resolve): Add named argument type checking.
14139 * class.cs (FixedField.Define): Use IsPrimitiveType
14141 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14143 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14144 unsafe parameter types.
14146 * statement.cs (Using.ResolveExpression): Add better error description.
14148 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14150 2005-04-08 Raja R Harinath <rharinath@novell.com>
14153 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14154 AttributeUsageAttribute in the emitcontext of the attribute class,
14155 not in the emitcontext of the attributable entity it was attached to.
14156 * cs-parser.jay: Use 'current_class', not 'current_container',
14157 when creating a GlobalAttribute.
14159 2005-04-08 Alp Toker <alp@atoker.com>
14161 * pending.cs: The fix to #58413 failed to compile methods implementing
14162 interfaces with/without params modifiers and vice versa, even though
14163 params modifiers aren't part of the signature. Make the modifier check
14164 less strict as in csc.
14166 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14167 Anoob V E <projectmonokochi@rediffmail.com>
14168 Harilal P R <projectmonokochi@rediffmail.com>
14171 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14172 modifiers of pending methods.
14173 (PendingImplementation.PendingImplementation): Initialize it.
14174 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14175 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14176 with ParameterData. Add check for modifiers.
14177 * class.cs (MethodData.Define): Update to changes.
14179 2005-04-07 Raja R Harinath <rharinath@novell.com>
14181 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14183 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14185 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14188 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14191 * typemanager.cs: Registered RequiredAttributeAttribute.
14193 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14195 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14196 Warning CS0169 is back at level 3.
14197 (IMethodData.SetMemberIsUsed): New method.
14199 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14200 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14202 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14204 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14206 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14209 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14212 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14213 to avoid the problems with nested types.
14215 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14216 Anoob V.E <projectmonokochi@rediffmail.com>
14217 Harilal P.R <projectmonokochi@rediffmail.com>
14218 Raja R Harinath <rharinath@novell.com>
14221 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14223 * typemanager (GetConstructor): Make public.
14225 2005-04-05 John Luke <john.luke@gmail.com>
14226 Raja R Harinath <rharinath@novell.com>
14229 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14230 struct too. Return false quicker in a few cases.
14231 (VerifyUnManaged): Use it.
14233 2005-04-05 Raja R Harinath <rharinath@novell.com>
14236 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14237 not 'unreachable_seen'.
14239 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14241 * attribute.cs (Attribute.GetValue): Removed unused.
14243 * codegen.cs (CodeGen.TrimExt): Removed unused.
14245 * cs-parser.jay (output): Removed unused.
14247 * cs-tokenizer.cs (hex_digits): Removed unused.
14249 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14251 * expression.cs (Indirection.LoadExprValue): Removed unused.
14252 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14254 * iterators.cs (Iterator.param_types): Removed unused.
14256 * statement.cs (Goto.block): Removed unused.
14257 (ToplevelBlock.did): Removed unused.
14258 (Switch.ResolveConstantSwitch): Removed unused.
14260 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14262 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14265 2005-04-01 Raja R Harinath <rharinath@novell.com>
14267 Fix #74232 and cs0208-3.cs.
14268 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14269 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14270 unmanaged type. Don't use FieldBuilders when 't' is a
14271 TypeBuilder. Use ModFlags and MemberType fields.
14272 * class.cs (MemberBase.member_type): Rename from MemberType.
14273 (MemberBase.MemberType): New property. Determines member_type on
14275 (MemberBase.DoDefine): Don't initialize MemberType here.
14276 (FieldMember.Define): Likewise.
14278 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14281 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14282 Attributes are emitted there.
14284 2005-04-01 Raja R Harinath <rharinath@novell.com>
14286 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14287 keyword in 'partial enum' too.
14288 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14290 Report from Kamil Skalski <nazgul@omega.pl>.
14293 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14294 have partial containers too.
14296 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14297 in block' checks to Block.CheckInvariantMeaningInBlock.
14298 * statement.cs (Block.GetKnownVariableInfo): Make private.
14299 (Block.IsVariableUsedInChildBlock): Remove.
14300 (Block.IsVariableUsedInBlock): Likewise.
14301 (Block.CheckInvariantMeaningInBlock): New. Show location of
14302 conflicting declaration.
14303 (Block.AddVariable): Make error messages less long-winded and more
14304 specific. Show location of conflicting declaration.
14305 * parameter.cs (Parameters.Location): New readonly property.
14307 2005-03-31 Raja R Harinath <rharinath@novell.com>
14309 Clean up semantics of invoking ResolveMemberAccess.
14310 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14311 can have an instance, ensure that we pass in a non-TypeExpression
14312 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14313 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14314 argument. Update to changes and simplify.
14315 (FieldExpr.Emitinstance): Remove CS0120 check.
14316 (PropertyExpr.EmitInstance): Likewise.
14317 * expression.cs (Argument.Resolve): Likewise.
14318 (Invocation.DoResolve): Update to changes in semantics of
14319 InstanceExpression.
14321 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14324 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14327 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14329 2005-03-31 Raja R Harinath <rharinath@novell.com>
14331 Fix difference in behaviour with commandline invocation.
14332 * driver.cs (Driver.Reset): New.
14333 (CompilerCallableEntryPoint): Call it.
14335 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14336 variable" warnings if the boolean expression failed to resolve.
14338 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14340 * attribute.cs: Fix the union of several permissions when some of them
14341 are unrestricted (so the result isn't an unrestricted permission set).
14344 2005-03-30 Raja R Harinath <rharinath@novell.com>
14346 * ecore.cs (MemberExpr): New class. Convert from interface
14348 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14349 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14351 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14352 (MethodGroupExpr.IsExplicitImpl): Remove.
14353 (Expression.GetFieldFromEvent): Remove.
14354 (SimpleName.MemberStaticCheck): Remove.
14355 (SimpleName.DoSimpleNameResolve): Update to changes.
14356 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14357 (MemberAccess.IdenticalNameAndTypeName): Remove.
14358 (MemberAccess.error176): Move to MemberExpr.
14359 (MemberAccess.DoResolve): Update to changes.
14360 (BaseAccess.DoResolve): Likewise.
14362 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14364 C# 2.0 Conditional attribute class implementation
14366 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14367 Analyzes class whether it has attribute which has ConditionalAttribute
14368 and its condition is not defined.
14370 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14371 (Class.IsExcluded): New method. Search for at least one defined
14372 condition in ConditionalAttribute of attribute class.
14374 2005-03-30 Raja R Harinath <rharinath@novell.com>
14376 * ecore.cs (PropertyExpr): Derive from Expression, not
14377 ExpressionStatement.
14378 (PropertyExpr.EmitStatement): Remove.
14380 2005-03-29 Raja R Harinath <rharinath@novell.com>
14383 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14384 internal field "value__" of an enum be private. The examples for
14385 "value__" that I found on MSDN all used FieldAttributes.Private.
14387 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14388 Don't mention IL method attribute names.
14390 Fix #47991. Remove a TODO.
14391 * statement.cs (Block.Toplevel): Make into a field.
14392 (Block.Parameters): Move into ToplevelBlock.
14393 (Block.known_variables): Rename from child_variable_names.
14394 (Block.Block): Remove variants that take Parameters. Initialize
14395 'Toplevel' with the immediately surrounding toplevel block.
14396 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14397 LocalInfo parameter.
14398 (Block.GetKnownVariableInfo): New.
14399 (Block.IsVariableNameUsedInChildBlock): Update.
14400 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14401 the block, even though it may not be in scope.
14402 (Block.AddVariable): Remove Parameters parameter. Use
14403 Toplevel.Parameters instead.
14404 (Block.AddConstant): Remove Parameters parameter.
14405 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14406 (Block.IsParamaterReference): Likewise.
14407 (Block.IsLocalParameter): Likewise. Simplify a lot.
14408 (ToplevelBlock.Parameters): New. Moved from Block.
14409 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14410 initialize Parameters to a non-null value.
14411 * cs-parser.jay: Update to changes.
14412 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14413 simple names that mean different things in the same block. Use
14414 Block.IsVariableNameUsedInBlock.
14416 2005-03-28 Raja R Harinath <rharinath@novell.com>
14418 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14419 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14420 GetTypeHandle. It is possible for a reflected type to derive from
14421 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14422 System.Array during mscorlib compilation).
14423 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14424 contain a method_hash, don't create one either. Don't create a
14425 deep copy of the base cache's method_hash.
14426 (MemberCache.SetupCache): Rename back from DeepCopy.
14427 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14428 already initialized. If we see an override function, add its
14429 underlying base virtual function to the member_hash too.
14431 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14433 2005-03-26 Raja R Harinath <harinath@acm.org>
14436 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14437 fails to resolve, ensure that the LHS is still resolved as an
14440 2005-03-25 Raja R Harinath <harinath@acm.org>
14442 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14444 (Enum.current_ec): Remove.
14445 (Enum.LookupEnumValue): Remove EmitContext argument.
14446 Just uses the one created during DefineType.
14447 (Enum.FindMembers): Update.
14448 * expression.cs (MemberAccess.DoResolve): Update.
14450 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14452 * assign.cs (Assign.DoResolve): Check for CS1717 when
14453 source and target are same (uses Equals).
14455 * expression.cs (LocalVariableReference, ParameterReference,
14456 This): Implemented Equals, GetHashCode.
14458 * statement.cs (Block.GetParameterReference): Removed useless
14461 2005-03-22 Raja R Harinath <rharinath@novell.com>
14464 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14465 blocks before deciding whether the error is cs0136 or cs0128.
14467 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14468 (using_alias_directive, using_namespace_directive): Pass
14469 MemberName, not an expression to Namespace.UsingAlias and
14471 (MakeName): Use the MemberName of the namespace.
14472 * namespace.cs (Namespace.MemberName): New.
14473 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14474 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14476 * decl.cs (MemberName.Name): Make readonly.
14477 (MemberName.FromDotted): New "constructor".
14478 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14479 (MemberCore.Name): Compute from MemberName on demand.
14480 (MemberCore.SetMemberName): Provide a way to change the
14482 (MemberCore.AddToContainer): Don't take a fullname parameter.
14483 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14484 fully qualified name of the container to the member name.
14485 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14486 only if the type is a member of the root container.
14487 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14488 MemberName.Left rather than searching for an embedded ".".
14489 (PartialContainer.CreatePart): Update to changes in RootContext.
14490 (MemberBase.ShortName): Turn into a property. Use
14491 MemberCore.SetMemberName.
14492 (MemberBase.ExplicitInterfaceName): Remove.
14493 (MemberBase.UpdateMemberName): Remove.
14494 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14495 (PropertyBase.SetMemberName): New override.
14496 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14497 (Tree.GetDecl): New.
14498 (Tree.AllDecls): Rename from Decls.
14499 * attribute.cs, enum.cs, report.cs: Update to changes.
14500 * driver.cs (MainDriver): Use MemberName.FromDotted on
14501 RootContext.MainClass.
14503 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14505 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14508 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14510 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14512 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14513 property accessor modifiers.
14515 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14516 fixed buffer attribute (CS1716).
14517 (PropertyMethod.HasCustomAccessModifier): When property accessor
14518 has custom modifier.
14520 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14522 (PropertyExpr.DoResolveLValue): Add CS0272.
14524 2005-03-17 Miguel de Icaza <miguel@novell.com>
14526 * convert.cs: When converting to a pointer, use the proper Conv.U
14527 or Conv.I depending on the source data type.
14529 * cs-tokenizer.cs: Make the size for large decimal constants,
14532 2005-03-17 Martin Baulig <martin@ximian.com>
14534 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14535 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14537 2005-03-17 Martin Baulig <martin@ximian.com>
14539 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14540 to bool so we can return an error condition.
14541 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14544 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14546 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14549 2005-03-16 Raja R Harinath <rharinath@novell.com>
14551 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14552 Refactor to avoid traversing the list of assemblies, and to avoid
14553 string concatenation.
14554 * typemanager.cs (guid_attr_type): Remove.
14555 (negative_hits, pointers, references): Remove hashes.
14557 (GetConstructedType): New. Uses type_hash to handle constructed
14558 types (arrays, references, pointers).
14559 (GetReferenceType, GetPointerType): Use it.
14560 (GetNestedType): New. Uses type_hash to handle nested types of
14562 (LookupType, LookupTypeDirect): Remove.
14563 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14564 'types' hash and LookupTypeReflection directly.
14565 (params_string, params_object): Use GetConstructedType.
14566 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14568 (Namespace.Lookup): Use cached_types.
14569 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14570 provided by old TypeManager.LookupType.
14571 * rootcontext.cs (MakeFQN): Remove.
14572 * decl.cs (DeclSpace.MakeFQN): Likewise.
14573 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14574 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14575 TypeManager.GetConstructedType.
14576 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14578 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14580 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14583 * cs-parser.jay: Reports CS1527 for any namespace element.
14585 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14588 * expression.cs (ParameterReference.IsAssigned): Changed error to
14590 (Error_WrongNumArguments): Moved CS0245 detection here.
14592 * statement.cs (Return.Resolve): Add CS1622 report.
14594 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14596 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14598 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14600 * attribute.cs expression.cs: Get rid of some allocations.
14602 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14604 * doc.cs : just eliminate the latest change.
14606 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14608 * doc.cs : commented out the latest change. It breaks xml-030.cs
14610 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14612 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14613 fail. So invoke CreateType() in FindDocumentedType().
14615 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14617 * cs-tokenizer.cs : added IsKeyword().
14618 * doc.cs : Detect keyword incorrectly used as identifier.
14619 Allow identifiers prefixed by @.
14621 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14623 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14624 It caused exception in namespace resolving (again!).
14626 * class.cs (Class.ctor): Removed exit.
14627 (PropertyMethod.ctor): ditto.
14629 * codegen.cs (Codegen.Reset): Reset static data.
14630 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14632 * cs-tokenizer.cs (Cleanup): Removed.
14634 * driver.cs (GetSystemDir): Rewrote to one line command.
14635 It caused problem with unloaded dynamic modules.
14636 (UnixParseOption): Removed Exit.
14637 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14638 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14639 Now can be mcs used as library.
14641 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14644 * location.cs (Reset): Reset static data.
14646 * namespace.cs (Reset): Reset static data.
14648 * report.cs (Report.Reset): Reset static data.
14650 * rootcontext.cs (RootContext.Reset): Reset static data.
14652 * tree.cs (RootTypes.ctor): Use Location.Null
14654 * typemanager.cs (TypeManager.Reset): Reset static data.
14655 (CoreLookupType): Removed Exit.
14656 (TypeHandle.Reset): Reset static data.
14658 2005-03-10 Raja R Harinath <rharinath@novell.com>
14661 * typemanager.cs (ComputeNamespaces): Import namespaces from
14662 referenced modules too.
14664 2005-03-09 Raja R Harinath <rharinath@novell.com>
14666 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14669 2005-03-09 Raja R Harinath <rharinath@novell.com>
14671 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14672 enclosing DeclSpace. This ensures that a name-lookup populates
14673 more caches and there are fewer 'TypeExpression's. Carve out
14674 nested type lookup into ...
14675 (LookupNestedTypeInHierarchy): ... this.
14677 2005-03-09 Raja R Harinath <rharinath@novell.com>
14679 Clean up a few partial-class semantics.
14680 Fixes test-357.cs and cs1618-2.cs.
14681 * cs-parser.jay (struct_declaration): Use 'current_class' as
14682 parent of newly-created struct. Remove call to Register ().
14683 Use 'pop_current_class' to complete handing the current struct.
14684 (interface_declaration): Likewise.
14685 (class_declaration): Likewise.
14686 (enum_declaration): Use 'current_class' as parent of newly created
14688 (delegate_declaration): Likewise.
14689 (pop_current_class): New function. This is used to handle closing
14690 up the 'current_class' and 'current_container', and pointing them
14691 to the enclosing class/container.
14692 (CSharpParser): Initialize 'current_class' too.
14693 * decl.cs (MemberCore): Add check for invariant: a partial
14694 container is not a parsed entity, and thus does not enclose any
14696 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14697 (DeclSpace.BaseTypeExpr): Use it.
14698 (DeclSpace.LookupType): Add check for invariant.
14699 * class.cs (TypeContainer): Add check for invariant: a nested
14700 class should have the same NamespaceEntry as its enclosing class.
14701 (TypeContainer.EmitFieldInitializers): Make virtual.
14702 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14704 (TypeContainer.Register): Remove.
14705 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14706 null. Use TypeResolveEmitContext for resolving base types and
14707 interfaces. Move initialization of Parts.TypeBuilder here from
14709 (TypeContainer.DefineNestedTypes): ... here.
14710 (PartialContainer): Take a Namespace not a NamespaceEntry.
14711 (PartialContainer.Create): Don't use Register. Call the
14712 appropriate Add... function directly.
14713 (ClassPart): Take both the PartialContainer and the enclosing
14714 class as constructor arguments.
14715 (ClassPart.EmitFieldInitializers): Override.
14716 (ClassPart.PartFindNestedTypes): Remove.
14717 (FieldBase.GetInitializerExpression): Resolve the initializer
14718 expression in the emit context of the enclosing class.
14719 * tree.cs (RootTypes): Remove Register ().
14721 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14723 * cs-parser.jay: Removed CS0134.
14725 * driver.cs: Removed CS1901.
14727 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14728 for predefined types.
14730 2005-03-07 Duncan Mak <duncan@novell.com>
14732 * codegen.cs (Save): Catch UnauthorizedAccessException as
14733 well. Fixes bug #73454.
14735 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14737 * cs-tokenizer.cs (xtoken): Add CS1035.
14739 * class.cs (MethodData.Define): Add CS0683.
14740 (FieldMember.ctor): Add CS0681.
14742 2005-03-07 Raja R Harinath <rharinath@novell.com>
14744 * ecore.cs (SimpleName.DoResolve): Rename from
14745 SimpleName.DoResolveAllowStatic.
14746 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14747 Pass 'intermediate' flag to MemberStaticCheck.
14748 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14749 of "intermediate" lookups via MemberAccess.
14750 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14751 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14753 2005-03-07 Raja R Harinath <rharinath@novell.com>
14756 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14757 slipped in because of variable names that are identical to a
14758 builtin type's BCL equivalent ('string String;', 'int Int32;').
14759 (PropertyExpr.EmitInstance): Likewise.
14761 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14763 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14765 * report.cs (warning_ignore_table): Made public.
14767 2005-03-04 Raja R Harinath <rharinath@novell.com>
14770 * class.cs (MethodData.Emit): Pass 'container' to
14771 container.GetObsoleteAttribute instead of 'container.Parent'.
14773 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14775 * cs-parser.jay: Add 1534 error test.
14777 * iterators.cs (Yield.CheckContext): Add error 1629.
14778 (Iterator.ctor): Save unsafe modifier.
14779 (MoveNextMethod.DoEmit): Restore unsafe context.
14781 * namespace.cs (UsingAlias): Better error message.
14783 2005-03-03 Dan Winship <danw@novell.com>
14785 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14786 the warning message [#73219]
14788 2005-03-03 Raja R Harinath <rharinath@novell.com>
14790 Fix compile with MCS 1.0.0.0.
14791 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14792 w_restore to not depend on string constant folding.
14794 2005-03-03 Raja R Harinath <rharinath@novell.com>
14796 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14797 CS0246 check to users who passed 'silent = false'.
14798 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14800 (SimpleName.SimpleNameResolve): Update.
14801 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14802 (MemberAccess.IdenticalNameAndTypeName): Update.
14803 * doc.cs (FindDocumentedTypeNonArray): Update.
14805 2005-03-03 Raja R Harinath <rharinath@novell.com>
14807 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14808 * parameters.cs (ComputeAndDefineParameters): Remove.
14809 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14810 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14811 Use GetParameterInfo.
14813 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14815 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14817 2005-03-02 Raja R Harinath <rharinath@novell.com>
14819 Unify DeclSpace.LookupType and DeclSpace.FindType.
14820 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14821 is in charge of defining nested types on demand.
14822 (DeclSpace.LookupType): Use it when the current_type is a
14823 TypeBuilder. Use LookupTypeDirect for reflected types.
14824 (DeclSpace.FindType): Remove.
14825 (DeclSpace.LookupInterfaceOrClass): Likewise.
14826 (DeclSpace.DefineTypeAndParents): Likewise.
14827 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14828 DeclSpace.LookupType.
14829 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14830 * typemanager.cs (LookupType): Simplify.
14831 (AddUserType): Remove type from negative_hits.
14832 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14833 * class.cs (TypeContainer.FindMembers): Move handling of nested
14835 (TypeContainer.FindMembers_NestedTypes): ... here.
14836 (TypeContainer.FindNestedType): Implement override.
14837 (ClassPart.FindNestedType): Delegate to PartialContainer.
14838 (ClassPart.PartFindNestedType): Looks up the nested types of the
14841 2005-03-02 Martin Baulig <martin@ximian.com>
14843 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14844 static constructor in static classes.
14846 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14848 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14849 sizeParamIndex is not specified.
14851 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14854 * report.cs (WarningMessage.IsEnabled): Missing null check.
14856 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14858 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14859 in the fields and not in the properties.
14861 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14863 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14866 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14868 * attribute.cs: Small refactoring (improved robustness).
14869 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14870 (ValidateGuid): Removed.
14871 (Resolve): Removed referenced to above mentioned.
14872 (GetAttributeUsage): Made private and changed to work without
14874 (GetIndexerAttributeValue): Don't crash.
14875 (GetConditionalAttributeValue): Ditto.
14876 (GetClsCompliantAttributeValue): Ditto.
14877 (ExtractSecurityPermissionSet): All attributes exceptions are
14879 (GetPropertyValue): New helper.
14880 (GetMethodImplOptions): New method.
14881 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14882 some missing properties.
14884 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14885 (Method.ApplyAttributeBuilder): Updated.
14887 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14890 2005-02-28 Raja R Harinath <rharinath@novell.com>
14893 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14894 non-simple types (array, pointer, reference).
14896 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14898 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14900 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14902 (Method.CheckBase): Catch wrong destructor here.
14903 (MethodData.Define): Add errors 550, 668.
14905 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14907 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14909 * pending.cs (VerifyPendingMethods): Add error 551.
14911 * typemanager.cs (CSharpName): Next error report helper.
14913 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14915 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14916 attributes. Removed useless attribute double check.
14917 It saves almost 2MBs for corlib.
14919 2005-02-25 Raja R Harinath <rharinath@novell.com>
14922 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14923 called twice in case of error.
14925 2005-02-23 Chris Toshok <toshok@ximian.com>
14927 Fix compiler portions of #72827.
14928 * statement.cs (Block.Emit): call Begin/EndScope on the
14929 EmitContext instead of the ILGenerator.
14931 * codegen.cs (EmitContext.BeginScope): new method, call
14932 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14934 (EmitContext.BeginScope): same, but EndScope and CloseScope
14936 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14937 offset and call the superclass's OpenScope(int) with it.
14938 (SymbolWriter.CloseScope): get the current il
14939 offset and call superclass's CloseScope(int) with it.
14941 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14943 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14944 CS1677 for out and ref as well.
14946 * class.cs (Method.Define): Add error CS1599 detection.
14948 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14950 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14952 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14954 * support.cs.cs (ModifierDesc): New helper method.
14956 2005-02-23 Raja R Harinath <rharinath@novell.com>
14957 Abin Thomas <projectmonokochi@rediffmail.com>
14958 Anoob V E <projectmonokochi@rediffmail.com>
14959 Harilal P R <projectmonokochi@rediffmail.com>
14961 Fix #57851, #72718.
14962 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14963 MemberLookup (used for error reporting) actually returns a result.
14964 Fix error report number (122, not 112).
14966 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14967 Anoob V E <projectmonokochi@rediffmail.com>
14968 Harilal P R <projectmonokochi@rediffmail.com>
14971 * pending.cs (PendingImplementation.GetAbstractMethods):
14972 Find NonPublic members too.
14974 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14976 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14979 * class.cs (MethodCore.CheckMethodAgainstBase):
14980 Add error 239 report.
14982 2005-02-21 Raja R Harinath <rharinath@novell.com>
14985 * expression.cs (Invocation.IsApplicable): Make public.
14986 (Invocation.IsParamsMethodApplicable): Likewise.
14987 * delegate.cs (Delegate.VerifyApplicability): Don't use
14988 Invocation.VerifyArgumentCompat for parameter applicability
14989 testing. Use Invocation.IsApplicable and
14990 Invocation.IsParamsMethodApplicable.
14992 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14994 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14996 * class.cs (Operator.Define): Add error 217 report.
14998 2005-02-21 Raja R Harinath <rharinath@novell.com>
15000 * namespace.cs (UsingEntry.Resolve): Undo change below.
15002 2005-02-21 Raja R Harinath <rharinath@novell.com>
15005 * ecore.cs (Expression.MemberLookupFailed): Add argument to
15006 disable the error message when the extended MemberLookup also
15008 (Expression.MemberLookupFinal): Update.
15009 (SimpleName.DoSimpleNameResolve): Update.
15010 * expression.cs (MemberAccess.ResolveNamespaceOrType):
15011 Don't use MemberLookupFinal.
15012 (New.DoResolve): Update.
15013 (BaseAccess.CommonResolve): Update.
15015 2005-02-21 Raja R Harinath <rharinath@novell.com>
15018 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
15019 occured previously, don't resolve again.
15021 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15024 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
15025 argument. Call ResolveAttributeUsage for unresolved.
15026 when types doesn't match ctor arguments.
15028 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
15029 for nested attribute classes.
15030 (Class.attribute_usage): Removed.
15031 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
15032 for attribute class.
15034 * ecore.cs (IsAttribute): Removed.
15036 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
15038 * rootcontext.cs (RegisterAttribute): Removed, attributes are
15040 (attribute_types): Removed.
15041 (EmitCode): Global attributes are emited as the latest.
15043 2005-02-18 Marek Safar <marek.safar@seznam.cz>
15045 * class.cs (EmitFieldInitializers): Don't emit field initializer
15046 for default values when optimilization is on.
15048 * constant.cs (Constant.IsDefaultValue): New property.
15050 * driver.cs: Add /optimize handling.
15054 * literal.cs: Implement new IsDefaultValue property.
15056 * rootcontext.cs (Optimize): New field, holds /optimize option.
15058 2005-02-18 Raja R Harinath <rharinath@novell.com>
15060 Fix crasher in re-opened #72347.
15061 * namespace.cs (Namespace.Lookup): Return null if
15062 DeclSpace.DefineType returns null.
15065 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
15067 2005-02-18 Raja R Harinath <rharinath@novell.com>
15069 Fix remainder of #63202. Change semantics of DoResolveLValue: it
15070 now returns null if it cannot resolve to an lvalue.
15071 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
15072 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
15073 returned null. Remove check for SimpleName.
15074 (EventExpr.DoResolveLValue): New.
15075 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
15076 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
15078 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
15079 avoid CS0131 error.
15080 (Unary.ResolveOperator): Move CS0211 check ...
15081 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
15083 (Unary.DoResolveLValue): Simplify.
15084 (AddressOf.DoResolveLValue): New.
15085 (ArrayAccess.DoResolveLValue): New.
15087 2005-02-16 Marek Safar <marek.safar@seznam.cz>
15089 * attribute.cs (Attribute.Resolve): Add arguments casting for
15090 when types doesn't match ctor arguments.
15092 2005-02-16 Raja R Harinath <rharinath@novell.com>
15094 Fix parts of #63202.
15095 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
15096 lookup of operator in base type. Ensure that all checks happen
15097 when the operator resolves to an "op_..." method.
15099 2005-02-15 Raja R Harinath <rharinath@novell.com>
15102 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
15103 'ignore_cs0104' parameter. Pass it to ...
15104 (NamespaceEntry.Lookup): ... this.
15105 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
15106 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
15107 (TypeLookupExpression.DoResolveAsTypeStep): Update.
15108 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
15109 Update. Request that cs0104 errors be ignored.
15110 (ComposedCast.ResolveAsTypeStep): Update.
15112 2005-02-14 Raja R Harinath <rharinath@novell.com>
15115 * expression.cs (Invocation.BetterFunction): Remove support for
15116 comparing virtual functions and their overrides.
15117 (Invocation.IsOverride): New.
15118 (Invocation.OverloadResolve): Don't consider 'override' functions
15119 during candidate selection. Store them in a lookaside list.
15120 If the selected method is a 'virtual' function, use the list to
15121 find any overrides that are closer to the LHS type.
15123 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15125 * expression.cs (New.DoResolve): Add complex core type reduction.
15126 (New.Constantify): Converts complex core type syntax like 'new int ()'
15127 to simple constant.
15129 2005-02-14 Raja R Harinath <rharinath@novell.com>
15131 * decl.cs (EntryType.EntryType): New constructor to create an
15132 updated copy of a cache entry.
15133 (MemberCache.AddMethods): Use it.
15134 (MemberCache.ClearDeclaredOnly): Remove.
15135 (MemberCache.MemberCache): Update.
15137 2005-02-11 Miguel de Icaza <miguel@novell.com>
15139 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15140 variable. This one is represents the actual low-level declaration
15141 of the method, as opposed to the semantic level `IsStatic'.
15143 An anonymous method which is hosted into a static method might be
15144 actually an instance method. IsStatic would reflect the
15145 container, while MethodIsStatic represents the actual code
15148 * expression.cs (ParameterReference): Use the new MethodIsStatic
15149 instead of IsStatic.
15151 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15152 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15153 set on the current EmitContext.
15155 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15156 resolve our casted expression as an LValue. This triggers the
15157 proper LValue processing that is later required by Assign.
15161 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15163 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15165 C# 2.0 Fixed buffer implementation
15167 * anonymous.cs: Update after RegisterHelperClass renaming.
15169 * attribute.cs (AttributeTester.fixed_buffer_cache):
15170 Cache of external fixed buffers.
15171 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15172 implementation if field is fixed buffer else null.
15175 (TypeContainer.AddField): Accept FieldMember instead of Field.
15176 (FieldBase.IsFieldClsCompliant): Extracted code from
15177 VerifyClsCompliance descendant customization.
15178 (FixedField): New class handles fixed buffer fields.
15179 (FixedFieldExternal): Keeps information about imported fixed
15181 (IFixedField): Make access to internal or external fixed buffer
15184 * cs-parser.jay: Add fixed buffer parsing.
15186 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15189 * expression.cs (Indirection): Extended implementation to accept
15190 fixed buffer field.
15191 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15192 (ElementAccess.MakePointerAccess): Get type as parameter.
15193 (DoResolve): Add fixed buffer field expression conversion.
15194 (DoResolveLValue): Ditto.
15195 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15196 (ArrayPtr): Derives from FixedBufferPtr.
15197 (ArrayPtr.Emit): Add extra emit for array elements.
15199 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15201 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15202 for compiler generated types.
15203 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15205 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15206 and consume less memory.
15207 (Fixed.Resolve): Add fixed buffer case.
15209 * typemanager.cs (compiler_generated_attr_ctor,
15210 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15211 (HasElementType): Add our own implementation to work on every
15214 2005-02-11 Miguel de Icaza <miguel@novell.com>
15216 * anonymous.cs (CaptureContext): Track whether `this' has been
15219 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15220 only captured `this' if it was implicitly done (instance
15221 methods/variables were used).
15223 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15224 `this' must be captured.
15226 2005-01-30 Miguel de Icaza <miguel@novell.com>
15228 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15229 is null it means that there has been no need to capture anything,
15230 so we just create a sibling.
15232 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15234 Just a partial fix. The other half is fairly elusive.
15236 2005-02-10 Raja R Harinath <rharinath@novell.com>
15238 Fix #52586, cs0121-4.cs.
15239 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15240 and return a hashtable.
15241 (MemberCache.ClearDeclaredOnly): New.
15242 (MemberCache.MemberCache): Update to change. Make a deep copy of
15243 the method_hash of a base type too.
15244 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15245 type methods. Overwrite entries with the same MethodHandle so
15246 that the ReflectedType is correct. The process leaves in base
15247 virtual functions and their overrides as distinct entries.
15248 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15249 matters since it was boxed in a ArrayList before.
15250 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15252 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15253 case of a virtual function and its override (choose the overload
15255 (Invocation.OverloadResolve): Avoid 'override' members during
15256 'applicable_type' calculation.
15258 2005-02-09 Raja R Harinath <rharinath@novell.com>
15260 Combine two near-redundant caches.
15261 * typemanager.cs (method_params): Rename from method_internal_params.
15262 (TypeManager.GetParameterData): New. Replace
15263 Invocation.GetParameterData.
15264 (TypeManager.LookupParametersByBuilder): Remove.
15265 * expression.cs (Invocation.method_parameter_cache): Remove.
15266 (Invocation.GetParameterData): Remove.
15268 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15271 2005-02-08 Raja R Harinath <rharinath@novell.com>
15274 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15275 TypeManager.multicast_delegate_type is null, resolve it by looking
15276 up "System.MulticastDelegate".
15277 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15279 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15280 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15281 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15284 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15285 (LabeledStatement.AddReference): New. Set 'referenced'.
15286 (Goto.Resolve): Use it.
15288 2005-02-05 John Luke <john.luke@gmail.com>
15290 * driver.cs: remove duplicate -doc line in Usage ()
15292 2005-02-04 Raja R Harinath <rharinath@novell.com>
15294 * location.cs (Location.AddFile): Fix CS2002 error report.
15296 2005-02-02 Martin Baulig <martin@ximian.com>
15298 * delegate.cs (Delegate.DefineType): Report an internal error if
15299 TypeManager.multicast_delegate_type is null. See bug #72015 for
15302 2005-02-02 Raja R Harinath <rharinath@novell.com>
15304 Fix a crasher in a variant of #31984.
15305 * const.cs (Constant.CheckBase): New override that defers the
15306 new-or-override check in case the base type hasn't been populated
15308 (Constant.Define): Ensure the new-or-override check is performed.
15310 2005-02-01 Duncan Mak <duncan@ximian.com>
15312 * const.cs (LookupConstantValue): Check that `ce' is not null
15313 before calling GetValue ().
15315 2005-02-01 Raja R Harinath <rharinath@novell.com>
15317 Fix test-334.cs (#69519).
15318 * cs-parser.jay (using_alias_directive): Pass in an expression to
15319 NamespaceEntry.UsingAlias.
15320 (using_namespace_directive): Pass in an expression to
15321 NamespaceEntry.Using.
15322 (namespace_name): Don't flatten to a string.
15323 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15324 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15326 (NamespaceEntry.UsingEntry): Likewise.
15327 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15329 (NamespaceEntry.LookupForUsing): Remove.
15330 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15332 (NamespaceEntry.Lookup): Remove support for dotted names.
15334 2005-02-01 Raja R Harinath <rharinath@novell.com>
15336 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15338 (NamespaceEntry.ImplicitParent): Compute on demand.
15339 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15340 parallels the current.
15341 (NamespaceEntry.LookupForUsing): Use it.
15342 (NamespaceEntry.Lookup): If the current namespace-entry is
15343 implicit, don't search aliases and using tables.
15345 2005-02-01 Raja R Harinath <rharinath@novell.com>
15348 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15350 (TypeContainer.BaseCache): Compute on demand.
15351 (TypeContainer.FindMembers): Define constants and types if they're
15352 not already created.
15353 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15355 * const.cs (Constant.Define): Make idempotent.
15357 2005-01-29 Miguel de Icaza <miguel@novell.com>
15359 * pending.cs: Produce better code (no nops produced by using Ldarg
15362 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15363 i - 1' it should be arg + 1.
15367 2005-01-28 Raja R Harinath <rharinath@novell.com>
15369 * attribute.cs (Attribute.CheckAttributeType): Make private
15371 (Attribute.ResolveType): Make virtual.
15372 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15373 handling of RootContext.Tree.Types.
15375 2005-01-27 Raja R Harinath <rharinath@novell.com>
15377 Update attribute-handling to use the SimpleName/MemberAccess
15379 * cs-parser.jay (attribute): Pass in an expression to the
15380 constructors of Attribute and GlobalAttribute.
15381 * attribute.cs (Attribute): Take an expression for the name.
15382 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15383 passed in attribute name expression.
15384 (Attribute.CheckAttributeType): Use it.
15385 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15386 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15387 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15388 argument to prevent error messages if the lookup fails.
15390 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15392 * expression.cs (Indirection): Implemented IVariable interface
15393 to support indirection in AddressOf operator.
15394 (PointerArithmetic.Emit): Add optimalization for case where
15395 result can be precomputed.
15397 2005-01-26 Martin Baulig <martin@ximian.com>
15399 * class.cs (TypeContainer.AttributeTargets): Return the correct
15400 AttributeTargets depending on our `Kind' instead of throwing an
15401 exception; fixes #71632.
15403 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15406 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15409 2005-01-25 Raja R Harinath <rharinath@novell.com>
15412 * expression.cs (MemberAccess.DoResolve): Don't complain with
15413 cs0572 when the LHS of a member access has identical name and type
15416 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15419 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15421 Create custom PermissionSet only for PermissionSetAttribute.
15423 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15426 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15427 delegates in static class.
15429 2005-01-24 Martin Baulig <martin@ximian.com>
15431 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15432 merging an implicit block, just use its reachability.
15434 * statement.cs (Block.Resolve): Make the unreachable code check
15435 work wrt. implicit blocks; see test-337 from #63842.
15437 2005-01-21 Alp Toker <alp@atoker.com>
15439 * cs-parser.jay: destructor_declaration's container is PartialContainer
15440 not Class when partial types are used, so use Kind prop instead of
15443 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15445 * cs-parser.jay: Improve error reporting when an interface
15446 declares new types.
15448 2005-01-20 Dick Porter <dick@ximian.com>
15450 * support.cs: SeekableStreamReader fix from Sandor Dobos
15451 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15452 chars are read. Fixes bug 70369.
15454 2005-01-20 Raja R Harinath <rharinath@novell.com>
15456 * cs-parser.jay (catch_clause): Simplify current_block handling
15459 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15461 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15462 code with ImplicitStandardConversion to handle the implicit
15463 conversion of method groups into valid delegate invocations.
15465 The problem is that in parameter handling we were using this code
15466 path. Fixes bug #64698
15468 2005-01-19 Raja R Harinath <rharinath@novell.com>
15470 * cs-parser.jay: Fix several infelicities.
15471 - Avoid assigning to the parser value stack. Code like
15472 '$3 = null' is unclean. Synthesize a value for the code block
15474 - Avoid using oob_stack for storing location information. Use ...
15475 (_mark_): ... this. New (empty) rule. Saves the current location
15477 (foreach_statement): Avoid using oob_stack for current_block
15478 handling. Use technique used in for_statement and
15479 using_statement. Synthesize a value for the code block to store
15480 additional intermediate information.
15482 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15484 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15485 of a different type is only allowed to private fields of a
15486 containing type, not on fields of a base class.
15488 See test-174.cs and error cs0122-9.cs
15490 2005-01-13 Raja R Harinath <rharinath@novell.com>
15492 Fix test-335.cs (bug #58126).
15493 * cs-parser.jay (argument): Split out non-expression parts of the
15494 rule into 'non_simple_argument'.
15495 (invocation_expression): Support parenthesized invocations with
15496 multiple arguments, and with single non-simple arguments.
15498 2005-01-13 Raja R Harinath <rharinath@novell.com>
15500 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15503 2005-01-12 Raja R Harinath <rharinath@novell.com>
15505 Fix cs0038-1.cs, cs1640-6.cs.
15506 * ecore.cs (Expression.Resolve): Remove special-case for
15507 SimpleName in error-handling.
15508 (Expression.almostMatchedMembers): Relax access permission to
15510 (Expression.MemberLookupFailed): Handle duplicates in
15511 almostMatchedMembers list.
15512 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15513 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15514 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15515 overload if the passed in MemberInfo is a MethodBase.
15517 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15520 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15521 for non-CAS & merge permission sets properly.
15523 2005-01-11 Raja R Harinath <rharinath@novell.com>
15525 Improve standard-compliance of simple name and member access
15526 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15527 * ecore.cs (FullNamedExpression): New abstract base class
15528 for Namespaces and TypeExpressions.
15529 (ResolveFlags.SimpleName): Remove.
15530 (SimpleName): Remove support for dotted names.
15531 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15532 DeclSpace.FindType and DeclSpace.LookupType.
15533 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15534 (Expression.ExprClassName): Make member function.
15535 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15536 a namespace. Remove creation of dotted "SimpleName"s.
15537 (MemberAccess.DoResolve): Likewise.
15538 * decl.cs (DeclSpace.Cache): Make private.
15539 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15540 (DeclSpace.FindType): Update.
15541 (DeclSpace.LookupType): Move here from RootContext. Return a
15542 FullNamedExpression.
15543 * namespace.cs (Namespace): Derive from FullNamedExpression
15544 so that it can be part of expression resolution.
15545 (Namespace.Lookup): Return an FullNamedExpression.
15546 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15548 * rootcontext.cs (NamespaceLookup): Remove.
15549 (LookupType): Move to DeclSpace.
15550 * attribute.cs (CheckAttributeType): Update.
15551 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15552 (FindDocumentedTypeNonArray): Likewise.
15554 2005-01-11 Raja R Harinath <rharinath@novell.com>
15556 Fix cs0509.cs, cs1632.cs.
15557 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15558 is the same as IsInterface.
15559 (TypeContainer.GetClassBases): Likewise.
15560 * statement.cs (LabeledStatement.ig): New field.
15561 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15563 (LabeledStatement.DoEmit): Check that the label was created with
15564 the same ILGenerator.
15566 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15569 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15570 accessors to its properties.
15572 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15573 from accessors to property.
15575 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15578 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15579 only for overrides.
15581 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15583 * attribute.cs: Check for null and empty strings.
15585 I have lost another battle to Paolo.
15587 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15590 * class.cs (PropertyMethod): Set Parent field in ctors.
15591 (SetMethod.InternalParameters): Add unsafe switch hack.
15592 Override MarkForDuplicationCheck where it is appropriate.
15594 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15595 It says whether container allows members with the same name.
15596 Base default is no.
15597 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15598 Removed is_method parameter.
15600 2005-01-06 Duncan Mak <duncan@ximian.com>
15602 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15603 because the previous change led to incorrect reporting of CS1032
15604 ("Cannot define/undefine preprocessor symbols after first token in
15605 file"). Instead of using `tokens_seen' as the only flag that
15606 triggers CS1040, introduce `comments_seen'. This new flag is used
15607 to signify having seen comments on the current line, so it is
15608 unset after a newline.
15610 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15612 * doc.cs : When searching for a type, find nested type too.
15613 This fixes bug #71040.
15615 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15618 - Warn missing member comment on those classes which also does not
15619 have doc comments. Fixed bug #71041.
15620 - Don't warn missing doc comment on default constructor.
15623 2005-01-06 Duncan Mak <duncan@ximian.com>
15625 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15626 comments, set `tokens_seen' to true. This allows us to detect
15627 misplaced preprocessor directives (i.e. not at the beginning of
15628 the a line, nor after whitespaces). In that case, report error
15629 CS1040. This fixes bug #56460.
15631 * cs-parser.jay (interface_member_declaration): Add checks for
15632 IsExplicitImpl, and report CS0541 error if an interface member is
15633 defined as an explicit interface declaration.
15635 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15638 * class.cs (PropertyMethod): Set Parent field in ctors.
15639 (SetMethod.InternalParameters): Add unsafe switch hack.
15641 * decl.cs (MemberCore.Parent): Cannot be readonly.
15643 2005-01-06 Raja R Harinath <rharinath@novell.com>
15645 * decl.cs (DeclSpace.ResolveType): Remove.
15646 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15647 Merge in code from ...
15648 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15649 * class.cs, enum.cs: Update to changes.
15651 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15653 * anonymous.cs: Ensure that we init the scope of our parent if it
15654 has not been initialized yet.
15656 2004-12-30 Duncan Mak <duncan@ximian.com>
15658 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15659 if field.FieldBuilder is null. Fixes #70758.
15661 * convert.cs: Fixed some typos and updated some of the comments.
15662 (ImplicitStandardConversionExists):
15663 (TryImplicitIntConversion): If `target_type' is an interface and
15664 the type of `ic' implements this interface, return true or a new
15665 BoxedCast instead of null. This fixes #70468.
15667 2004-12-29 Duncan Mak <duncan@ximian.com>
15669 * expression.cs (Argument.Emit): Check that Expr is
15670 IMemoryLocation before casting to it, and report CS1510 otherwise.
15674 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15676 * statement.cs (Block.ThisVariable): remove the recursion here, to
15677 make the --profile more sane.
15679 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15681 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15682 assembly, by JB Evain.
15684 2004-12-17 Raja R Harinath <rharinath@novell.com>
15686 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15687 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15688 "parent" refers to enclosing type/class. "base" refers to superclass.
15690 2004-12-17 Raja R Harinath <rharinath@novell.com>
15692 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15693 Ensure that we only have GlobalAttributes.
15694 * attribute.cs (Attribute.Emit): Make non-virtual.
15695 (GlobalAttribute.Emit): Remove.
15696 (Attribute.Resolve): Make virtual.
15697 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15698 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15699 the argument. Don't create one.
15700 (Attribute.GetObsoleteAttribute): Likewise.
15701 (Attribute.GetClsCompliantAttributeValue): Likewise.
15702 * class.cs, decl.cs: Update to changes.
15704 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15706 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15708 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15710 * statement.cs (Foreach.Resolve): Add error 186 report.
15712 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15714 * expression.cs (Conditional.DoResolve): Add warning 429.
15716 * statement.cs (If.Resolve): Add warning 665.
15718 2004-12-16 Raja R Harinath <rharinath@novell.com>
15720 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15721 except when in the parser, and in GlobalAttribute.
15722 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15723 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15724 RootContext.Tree.Types.NamespaceEntry once work is done.
15725 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15726 and resets RootContext.Tree.Types.NamespaceEntry.
15728 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15730 * cs-parser.jay: Don't create a block for every variable.
15732 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15734 * location.cs: Provide extra information.
15736 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15737 variables from the captured environment, it is the ldarg_0.
15739 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15741 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15744 * class.cs: Changed warning level for 169 to avoid developer
15745 displeasure from warning flooding. It will be changed back when they
15746 fix most of current BCL warnings.
15748 * RootContext.cs: Pushed default WarningLevel to 3.
15750 * statement.cs: Removed unused variable.
15752 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15754 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15755 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15756 Add error 502 report.
15757 (StaticClass.DefineType): Add error 441 report.
15758 (Class.AllowedModifiersProp): New virtual property as temporary
15759 extension to AllowedModifiers.
15760 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15761 to share implementation with StaticClass and don't call virtual
15764 * driver.cs (MainDriver): Add error 1558 test.
15766 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15767 report. Moved error 36 test here.
15769 * statement.cs (Throw.Resolve): Add error 724 report.
15771 * typemanager.cs: Add out_attribute_type core type.
15773 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15775 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15777 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15779 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15782 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15784 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15785 Add error 3023 report.
15786 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15788 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15791 2004-12-12 John Luke <john.luke@gmail.com>
15793 * driver.cs (AddArgs): take -- into account when
15794 adding arguments, fixes bug 65710
15796 2004-12-12 Martin Baulig <martin@ximian.com>
15798 * expression.cs (Unary.TryReduceNegative): Added support for
15799 SByteConstant and ByteConstant.
15800 (Unary.Reduce): Check error values from TryReduceNegative().
15802 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15804 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15805 and report exception as error 182.
15807 2004-12-10 Raja R Harinath <rharinath@novell.com>
15809 * driver.cs (Main): Fix message when there are warnings.
15811 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15813 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15815 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15817 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15818 Reduced number of warnings.
15820 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15822 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15824 * driver.cs: Removed message.
15826 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15828 2004-12-08 <vargaz@freemail.hu>
15830 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15832 2004-12-08 Martin Baulig <martin@ximian.com>
15834 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15835 instead of a CS3002 for properties and indexer.
15837 2004-12-08 Martin Baulig <martin@ximian.com>
15839 * decl.cs (MemberName.ToString): Make this work again.
15841 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15843 * attribute.cs (Resolve): Add error 591 detection.
15845 * class.cs (FieldMember.Define): Add error 1547 detection.
15846 (Indexer.Define): Add error 620 detection.
15847 (Operator.Define): Add error 590 detection.
15849 * ecore.cs: Missing argument for error 79.
15851 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15854 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15857 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15860 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15862 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15863 Some operator comments were suppressed.
15864 * doc.cs : Implicit/explicit operator name in doc comments are like
15865 "op_Explicit(type)~returnType", so added suffix handling.
15867 2004-12-07 Martin Baulig <martin@ximian.com>
15870 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15871 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15872 (DeclSpace.ec): New protected field; store the EmitContext here.
15873 (DeclSpace.EmitContext): New public property; moved here from
15875 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15878 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15879 (Enum.Emit): Don't create a new EmitContext.
15881 * delegate.cs (Delegate.DefineType): Always create the
15884 * iterators.cs (Iterators.DefineIterator): Create a new
15885 EmitContext and store it in `ec'.
15887 2004-08-24 Martin Baulig <martin@ximian.com>
15890 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15891 this for accessibility checks.
15892 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15893 IsNestedFamilyAccessible.
15894 (TypeManager.IsSubclassOf): New method, do what the name actually
15897 2004-12-06 Raja R Harinath <rharinath@novell.com>
15899 Fix crash on cs0657-17.cs.
15900 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15901 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15902 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15903 the case where the NamespaceEntry gets overwritten.
15905 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15907 Fixed #69195, #56821
15908 * ecore.cs (ResolveBoolean): Tiny refactoring.
15910 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15911 of right expression resolving when left is false constant and
15912 operator is LogicalAnd OR true constant and operator is LogicalOr.
15914 * statement.cs (ResolveUnreachable): Always reports warning.
15916 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15918 * class.cs: Distinguish between 1721 and 1722 (just a little help
15919 for the programmer).
15921 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15923 * delegate.cs: Only allow this on new versions of the language.
15925 2004-12-02 Duncan Mak <duncan@ximian.com>
15927 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15929 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15930 here as a static method. Take an additional bool out parameter
15931 `must_do_cs1540_check' for signaling to InstanceResolve.
15932 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15933 member field from PropertyExpr class and made it an argument of
15934 the method instead.
15935 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15936 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15937 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15938 and `remove_accessor' as well as InstanceResolve: report CS0122
15943 2004-12-03 Raja R Harinath <rharinath@novell.com>
15945 Fix test-327.cs, test-328.cs, and put in early infrastructure
15946 for eventually fixing #52697.
15947 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15948 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15949 from other methods.
15950 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15951 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15952 (VerifyUsing, error246): Update.
15953 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15954 'NamespaceEntry.LookupNamespaceOrType'.
15956 2004-12-03 Martin Baulig <martin@ximian.com>
15958 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15959 method as our child, call AnonymousMethod.Compatible() on it.
15961 2004-12-03 Raja R Harinath <rharinath@novell.com>
15963 Disable XML documentation support in 'basic' profile.
15964 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15965 Redirect XmlElement to System.Object.
15966 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15967 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15968 * mcs.exe.sources: Add doc-bootstrap.cs.
15969 * doc-bootstrap.cs: New file. Contains empty stub implementation
15972 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15974 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15975 comments are allowed.
15977 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15979 * delegate.cs: Add checks for subtypes in paramaters and return values
15980 in VerifyMethod () to add support for Covariance/Contravariance
15983 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15985 * report.cs: Remove extra closing parenthesis.
15987 * convert.cs (Error_CannotImplicitConversion): If the name of the
15988 types are the same, provide some extra information.
15990 * class.cs (FieldBase): Use an unused bit field from the field to
15991 encode the `has_offset' property from the FieldMember. This saves
15992 a couple of Ks on bootstrap compilation.
15994 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15995 method as our child, return the AnonymousMethod resolved
15998 * expression.cs (New.DoResolve): Allow return values from
15999 NewDelegate to also include AnonymousMethods.
16003 2004-12-02 Marek Safar <marek.safar@seznam.cz>
16006 * attribute.cs (Resolve): Improved implementation of params
16007 attribute arguments.
16009 * support.cs (ParameterData): Add HasParams to be faster.
16011 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
16013 all things are for /doc support:
16015 * doc.cs: new file that supports XML documentation generation.
16016 * mcs.exe.sources: added doc.cs.
16018 Handle /doc command line option.
16019 Report error 2006 instead of 5 for missing file name for /doc.
16020 Generate XML documentation when required, after type resolution.
16022 Added support for picking up documentation (/// and /** ... */),
16023 including a new XmlCommentState enumeration.
16025 Added lines to fill Documentation element for field, constant,
16026 property, indexer, method, constructor, destructor, operator, event
16027 and class, struct, interface, delegate, enum.
16028 Added lines to warn incorrect comment.
16030 Added Documentation field (passed only when /doc was specified).
16032 Added DocComment, DocCommentHeader, GenerateDocComment() and
16033 OnGenerateDocComment() and some supporting private members for
16034 /doc feature to MemberCore.
16036 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
16038 Added overriden DocCommentHeader.
16040 Added overriden DocCommentHeader and GenerateDocComment().
16042 2004-12-01 Miguel de Icaza <miguel@ximian.com>
16044 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
16045 unwrapping the enumeration values, chain to
16046 DoConstantNumericPromotions again, so we can promote things to the
16047 fundamental types (takes care of enums that are bytes, sbytes).
16051 2004-12-01 Raja R Harinath <rharinath@novell.com>
16053 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
16054 Fix long-standing bug in type-lookup. Use FindType instead of
16055 LookupType when ec.ResolvingTypeTree.
16056 (Attribute.ResolveType, Attribute.Resolve)
16057 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
16059 (Attributes.Search): Remove internal version. Update.
16060 (Attributes.SearchMulti): Update.
16061 (Attributes.GetClsCompliantAttribute): Remove.
16062 (Attributes.GetIndexerNameAttribute): Remove.
16063 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
16064 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
16065 * class.cs (Indexer.Define): Likewise.
16067 2004-12-01 Marek Safar <marek.safar@seznam.cz>
16070 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
16071 MarshallByReference members access.
16073 * expression.cs: Use CheckMarshallByRefAccess;
16074 Better error CS0197 message.
16076 * report.cs: Print whole related error message.
16078 2004-11-30 Raja R Harinath <rharinath@novell.com>
16080 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
16081 the current directory to help debugging.
16083 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16085 * class (GetClassBases): Better error 60 report.
16086 (EventProperty): Disabled warning 67 detection.
16088 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16091 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
16093 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
16096 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16099 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
16101 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
16103 2004-11-26 Miguel de Icaza <miguel@ximian.com>
16105 * attribute.cs (Attribute.Resolve): Refine error reporting and
16106 report a cs0117 if the identifier does not exist, to distinguish
16107 from 0617 which is a miss-use of the actual identifier.
16109 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
16110 between cs0070 and cs0079.
16112 * class.cs (MemberBase.DoDefine): When reporting a wrong
16113 accessibility level, we use MethodCore to compare instead of
16114 Method (this was a regression in some refactoring effort).
16116 So now we correctly report cs0056 again.
16118 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16119 testing the target_type (which was known to be object_type) and
16120 not the source type (which is anonymous_method).
16122 Fixed reporting of error cs1660.
16124 * expression.cs (UserCast.Source): Expose the underlying cast.
16126 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16127 allowed types to find a match to int32 first (most common).
16129 In addition, it ignores any ImplicitUserConversions that did an
16130 internal implicit conversion (as the switch statement allows only
16131 one integral conversion to exist).
16133 * class.cs (PartialContainer.Create): rename `name' to
16134 `member_name' for clarity. Then replace the string calls with a
16135 call to MemberName.GetPartialName, as now using
16136 MemberName.ToString is an error (this is due to the side effects
16137 it had, that were fixed in the past).
16139 This will restore the error reporting on a number of partial class
16140 errors that were missusing this (and getting an exception as a
16141 results, which is now just a plain textual warning, because
16142 yyparse debug output would crash otherwise).
16144 2004-11-26 Raja R Harinath <rharinath@novell.com>
16146 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16148 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16150 * rootcontext.cs (LookupType): Make sure to cache lookups that
16151 don't give us a negative result. This saves about 5% of corlib
16154 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16156 * report.cs (AbstractMessage.Print): messages are sent to stderr
16158 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16159 non-interface in the list of interfaces (at this point, either
16160 parent was properly set, or a base class is being listed in the
16161 interfaces section).
16163 This flags error 1722, and resolves the crash from bug 69259.
16165 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16167 * statement.cs (Using.EmitExpressionFinally): make this work right
16168 for valuetypes. Fixes 69926.
16170 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16172 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16173 converted to an enum" here, before we try to change the underlying
16174 type. This code exists, but it is a different code path than the
16175 one used while encoding constants.
16177 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16178 old bug: when converting from the null literal to a pointer,
16179 return an EmptyCast, not the NullLiteral.
16181 This fixes #69921, the recent null_type changes probably made this
16182 bug more prominent.
16184 (ImplicitReferenceConversionExists): In addition, resynchronized
16185 the code here, so it matches the same code in
16186 ImplicitReferenceConversionExists for the `from any class-type S
16187 to any interface-type T'.
16190 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16192 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16194 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16196 * cs-parser.jay: Use verbosity accordingly.
16198 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16200 * expression.cs (Unary.ResolveOperator): Do not report warning;
16201 AddressOf reads from variable.
16203 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16205 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16209 * attribute.cs (Attributable): Removed CheckTargets.
16210 (Attributes.Emit): Explicit attribute targets are tested here.
16212 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16213 not enabled for interfaces.
16215 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16216 (GetAssemblyName): Ouch next bug there.
16218 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16220 * expression.cs: Error 275 added.
16222 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16224 Fix bug #69177 (Implemented decimal constant support)
16226 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16227 (BinaryFold): Add DecimalConstant.
16229 * const.cs (Define): Decimal constant
16231 (ChangeType): Add decimal type handling.
16232 (LookupConstantValue): Don't set value for decimal type but
16233 emit DecimalConstantAttribute. Needed for constant optimization.
16235 * constant.cs (ToDecimal): New method.
16236 (ConvertToDecimal): New method.
16237 (IntConstant): Implemented ConvertToDecimal.
16238 (DecimalConstant.Emit): Emit optimized version for decimals in
16241 * expression.cs (ResolveOperator): Changed order of constant
16242 reduction to work correctly with native types which have
16243 overloaded operators.
16244 (ResolveMemberAccess): Extract constant value from attribute
16247 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16249 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16250 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16251 (ChangeType): Decimal is special.
16252 (TypeToCoreType): Add decimal type.
16254 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16256 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16259 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16261 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16264 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16266 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16268 * pending.cs (PendingImplementation): Grab only interfaces.
16270 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16272 * statement.cs (ForeachHelperMethods): Add location member and
16273 error 202 detection.
16275 2004-11-19 Raja R Harinath <rharinath@novell.com>
16277 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16278 automatically handled by executable.make.
16279 (PROGRAM): Make profile-specific.
16281 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16283 * expression.cs (DoResolveBase): Fixed wrong warning for out
16286 2004-11-18 Martin Baulig <martin@ximian.com>
16288 Merged latest changes into gmcs. Please keep this comment in
16289 here, it makes it easier for me to see what changed in MCS since
16290 the last time I merged.
16292 2004-11-17 Raja R Harinath <rharinath@novell.com>
16294 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16295 (TypeHandle.GetMemberCache): New.
16296 (TypeHandle.TypeHandle): Update.
16297 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16298 (TypeManager.LookupParentInterfacesCache):
16299 Rename from LookupInterfaceCache. Optimize slightly.
16300 (TypeManager.MemberLookup_FindMembers): Update.
16301 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16302 multi-type variant.
16303 (AddCacheContents): Rename from AddHashtable.
16304 * class.cs (TypeContainer.parent_container): Remove.
16305 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16306 (TypeContainer.DoDefineMembers): Don't initialize it.
16307 Update to name changes.
16309 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16311 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16312 that factors the code to check access modifiers on override.
16314 (PropertyBase): Use the code here.
16316 Patch from Lluis S'anchez, fixes bug #69361.
16318 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16320 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16321 routine that is used to report the use of a captured variable
16322 whose address has been taken.
16324 There are two checks: one when variables are being captured and
16325 the other check is when the address of a variable is taken.
16327 (because an anonymous methods might be resolved before *or* after
16328 the address has been taken) and
16330 * expression.cs (Conditional.DoResolve): Remove the special
16331 casing that Martin added to trueExpr and falseExpr being both
16332 NullLiteral. We get the right behavior now just by introducing
16333 the null_type into the compiler.
16335 * convert.cs (ExplicitConversion): Change the code to use
16336 null_type instead of testing `expr is NullLiteral'.
16337 (ImplicitConversionStandard): use null_type too.
16338 (ImplicitReferenceConversionExists): use null_type too.
16339 (ImplicitReferenceConversion): use null_type too.
16341 * literal.cs: The type of `NullLiteral' is now null_type instead
16343 (Resolve): Set the type here.
16345 * typemanager.cs: Introduce null_type.
16347 2004-11-17 Martin Baulig <martin@ximian.com>
16349 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16350 direction, like FindMembers() does. Fixes #69546, testcase is in
16353 2004-11-16 Martin Baulig <martin@ximian.com>
16355 This is based on a patch from Marek Safar, see bug #69082.
16356 Fixes bugs #63705 and #67130.
16358 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16359 method; create a MemberCache for an interface type and cache the
16362 * decl.cs (IMemberContainer.ParentContainer): Removed.
16363 (IMemberContainer.ParentCache): New property.
16364 (MemberCache.SetupCacheForInterface): Removed.
16365 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16366 to create a cache for an interface's "parent".
16368 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16371 2004-11-16 Martin Baulig <martin@ximian.com>
16373 Merged back from gmcs; these changes already went into gmcs a
16374 couple of weeks ago.
16377 (TypeManager.AddUserType): Removed the `ifaces' argument.
16378 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16380 (TypeManager.AddUserInterface): Removed.
16381 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16383 (TypeManager.GetInterfaces): Likewise.
16384 (TypeManager.GetExplicitInterfaces): Likewise.
16386 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16388 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16389 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16391 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16393 * statement.cs: Avoid adding bools to a hashtable.
16395 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16397 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16398 calling an unsafe method from a safe location.
16400 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16403 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16405 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16407 * namespace.cs (VerifyUsing): use GetPartialName instead of
16410 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16412 * statement.cs (Return.Resolve): Fix regression in typo: if
16413 `in_exc', we have to request a NeedReturnLabel, this was a typo
16414 introduced in the anonymous method check-in. Fixes #69131.
16416 * Indexers were using the ShortName when defining themselves,
16417 causing a regression in the compiler bootstrap when applying the
16418 patch from 2004-11-02 (first part), now they use their full name
16419 and the bug is gone.
16421 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16423 * driver.cs: Strip the path from the names of embedded resources. Fixes
16426 2004-11-04 Raja R Harinath <rharinath@novell.com>
16428 Fix error message regression: cs0104-2.cs.
16429 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16430 (AliasEntry.Resolve): Update.
16431 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16433 (RootContext.LookupType): Update.
16435 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16437 * cs-parser.jay: Add support for handling accessor modifiers
16438 * class: Add support port accessor modifiers and error checking,
16439 define PropertyMethod.Define as virtual (not abstract anymore)
16440 * ecore.cs: Add checking for proeprties access with access modifiers
16441 * iterators.cs: Modify Accessor constructor call based in the modified
16443 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16445 * expression.cs (StringConcat): Handle being called twice,
16446 as when we have a concat in a field init with more than two
16449 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16451 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16452 special case explicit implementations, we should always produce
16453 the .property or .event declaration.
16455 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16456 since it will not return correct data if people use this
16457 unresolved in the presence of using statements (see test-313).
16459 * class.cs (MethodData.Define): If we are an explicit interface
16460 implementation, set the method name to the full name of the
16461 interface plus the name of the method.
16463 Notice that using the method.MethodName.GetFullName() does not
16464 work, as it will only contain the name as declared on the source
16465 file (it can be a shorthand in the presence of using statements)
16466 and not the fully qualifed type name, for example:
16470 class D : ICloneable {
16471 object ICloneable.Clone () {
16475 Would produce a method called `ICloneable.Clone' instead of
16476 `System.ICloneable.Clone'.
16478 * namespace.cs (Alias.Resolve): Use GetPartialName.
16480 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16482 * cs-parser.jay: Add error 1055 report.
16484 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16486 * assign.cs (Assign.DoResolve): Only do the transform of
16487 assignment into a New if the types are compatible, if not, fall
16488 through and let the implicit code deal with the errors and with
16489 the necessary conversions.
16491 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16493 * cs-parser.jay: Add error 1031 report.
16495 * cs-tokenizer.cs: Add location for error 1038.
16497 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16499 * cs-parser.jay: Add error 1016 report.
16501 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16503 * cs-parser.jay: Add errors 1575,1611 report.
16505 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16507 * cs-parser.jay: Add error 1001 report.
16509 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16512 * attribute.cs (GetMarshal): Add method argument for
16513 caller identification.
16515 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16516 agument for GetMarshal and RuntimeMissingSupport.
16518 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16520 * attribute.cs (ExtractSecurityPermissionSet): Removed
16521 TypeManager.code_access_permission_type.
16523 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16525 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16527 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16528 for obsolete use of a variable here. Fixes regression on errors
16529 cs0619-25 and cs0619-26.
16531 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16533 Fix #62358, implemented security attribute encoding.
16535 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16536 Tests permitted SecurityAction for assembly or other types.
16537 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16538 data from SecurityPermissionAttribute to PermisionSet class.
16540 * class.cs (ApplyAttributeBuilder): Added special handling
16541 for System.Security.Permissions.SecurityAttribute based types.
16543 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16544 special handling for System.Security.Permissions.SecurityAttribute
16547 * enum.cs (ApplyAttributeBuilder): Added special handling
16548 for System.Security.Permissions.SecurityAttribute based types.
16550 * parameter.cs (ApplyAttributeBuilder): Added special handling
16551 for System.Security.Permissions.SecurityAttribute based types.
16553 * rootcontext.cs: Next 2 core types.
16555 * typemanager.cs (TypeManager.security_permission_attr_type):
16556 Built in type for the SecurityPermission Attribute.
16557 (code_access_permission_type): Build in type.
16559 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16561 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16562 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16563 all of this information into
16564 EmitContext.EmitCapturedVariableInstance.
16566 * codegen.cs (EmitCapturedVariableInstance): move here the
16567 funcionality of emitting an ldarg.0 in the presence of a
16568 remapping. This centralizes the instance emit code.
16570 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16571 then emit a load of this: it means that we have reached the
16572 topmost ScopeInfo: the one that contains the pointer to the
16573 instance of the class hosting the anonymous method.
16575 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16576 captures to the topmost CaptureContext.
16578 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16580 * expression.cs (LocalVariableReference): Move the knowledge about
16581 the iterators into codegen's EmitCapturedVariableInstance.
16583 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16585 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16586 all code paths return a value from an anonymous method (it is the
16587 same as the 161 error, but for anonymous methods).
16589 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16591 The introduction of anonymous methods in the compiler changed
16592 various ways of doing things in the compiler. The most
16593 significant one is the hard split between the resolution phase
16594 and the emission phases of the compiler.
16596 For instance, routines that referenced local variables no
16597 longer can safely create temporary variables during the
16598 resolution phase: they must do so from the emission phase,
16599 since the variable might have been "captured", hence access to
16600 it can not be done with the local-variable operations from the runtime.
16604 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16605 is a toplevel block.
16607 (ToplevelBlock): A new kind of Block, these are the blocks that
16608 are created by the parser for all toplevel method bodies. These
16609 include methods, accessors and anonymous methods.
16611 These contain some extra information not found in regular blocks:
16612 A pointer to an optional CaptureContext (for tracking captured
16613 local variables and parameters). A pointer to the parent
16616 (Return.Resolve): Catch missmatches when returning a value from an
16617 anonymous method (error 1662).
16618 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16621 (Break.Resolve): ditto.
16623 (SwitchLabel): instead of defining the labels during the
16624 resolution phase, we now turned the public ILLabel and ILLabelCode
16625 labels into methods called GetILLabelCode() and GetILLabel() that
16626 only define the label during the Emit phase.
16628 (GotoCase): Track the SwitchLabel instead of the computed label
16629 (its contained therein). Emit the code by using
16630 SwitchLabel.GetILLabelCode ().
16632 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16633 whether the Local has been captured or not.
16635 (LocalInfo.IsCaptured): New property, used to tell whether the
16636 local has been captured.
16638 * anonymous.cs: Vastly updated to contain the anonymous method
16641 The main classes here are: CaptureContext which tracks any
16642 captured information for a toplevel block and ScopeInfo used to
16643 track the activation frames for various local variables.
16645 Each toplevel block has an optional capture context associated
16646 with it. When a method contains an anonymous method both the
16647 toplevel method and the anonymous method will create a capture
16648 context. When variables or parameters are captured, they are
16649 recorded on the CaptureContext that owns them, for example:
16653 MyDelegate d = delegate {
16658 Here `a' will be recorded as captured on the toplevel
16659 CapturedContext, the inner captured context will not have anything
16660 (it will only have data if local variables or parameters from it
16661 are captured in a nested anonymous method.
16663 The ScopeInfo is used to track the activation frames for local
16664 variables, for example:
16666 for (int i = 0; i < 10; i++)
16667 for (int j = 0; j < 10; j++){
16668 MyDelegate d = delegate {
16673 At runtime this captures a single captured variable `i', but it
16674 captures 10 different versions of the variable `j'. The variable
16675 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16676 recorded on a child.
16678 The toplevel ScopeInfo will also track information like the `this'
16679 pointer if instance variables were referenced (this is necessary
16680 as the anonymous method lives inside a nested class in the host
16681 type of the method).
16683 (AnonymousMethod): Expanded to track the Toplevel, implement
16684 `AnonymousMethod.Compatible' to tell whether an anonymous method
16685 can be converted to a target delegate type.
16687 The routine now also produces the anonymous method content
16689 (AnonymousDelegate): A helper class that derives from
16690 DelegateCreation, this is used to generate the code necessary to
16691 produce the delegate for the anonymous method that was created.
16693 * assign.cs: API adjustments for new changes in
16694 Convert.ImplicitStandardConversionExists.
16696 * class.cs: Adjustments to cope with the fact that now toplevel
16697 blocks are of type `ToplevelBlock'.
16699 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16700 insteda of standard blocks.
16702 Flag errors if params arguments are passed to anonymous methods.
16704 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16705 `CurrentAnonymousMethod' which points to the current Anonymous
16706 Method. The variable points to the AnonymousMethod class that
16707 holds the code being compiled. It is set in the new EmitContext
16708 created for the anonymous method.
16710 (EmitContext.Phase): Introduce a variable and an enumeration to
16711 assist in enforcing some rules about when and where we are allowed
16712 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16713 only one that enfonces this right now).
16715 (EmitContext.HaveCaptureInfo): new helper method that returns
16716 whether we have a CapturedContext initialized.
16718 (EmitContext.CaptureVariable): New method used to register that a
16719 LocalInfo must be flagged for capturing.
16721 (EmitContext.CapturedParameter): New method used to register that a
16722 parameters must be flagged for capturing.
16724 (EmitContext.CapturedField): New method used to register that a
16725 field must be flagged for capturing.
16727 (EmitContext.HaveCapturedVariables,
16728 EmitContext.HaveCapturedFields): Return whether there are captured
16729 variables or fields.
16731 (EmitContext.EmitMethodHostInstance): This is used to emit the
16732 instance for the anonymous method. The instance might be null
16733 (static methods), this (for anonymous methods that capture nothing
16734 and happen to live side-by-side with the current method body) or a
16735 more complicated expression if the method has a CaptureContext.
16737 (EmitContext.EmitTopBlock): Routine that drives the emission of
16738 code: it will first resolve the top block, then emit any metadata
16739 and then emit the code. The split is done so that we can extract
16740 any anonymous methods and flag any captured variables/parameters.
16742 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16743 during this phase, the ILGenerator should not be used as labels
16744 and local variables declared here might not be accessible to any
16745 code that is part of an anonymous method.
16747 Exceptions to this include the temporary variables that are
16748 created by some statements internally for holding temporary
16751 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16754 (EmitContext.TemporaryReturn): This method is typically called
16755 from the Emit phase, and its the only place where we allow the
16756 ReturnLabel to be defined other than the EmitMeta. The reason is
16757 that otherwise we would have to duplicate a lot of logic in the
16758 Resolve phases of various methods that today is on the Emit
16761 (EmitContext.NeedReturnLabel): This no longer creates the label,
16762 as the ILGenerator is not valid during the resolve phase.
16764 (EmitContext.EmitThis): Extended the knowledge in this class to
16765 work in anonymous methods in addition to iterators.
16767 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16768 code is necessary on the stack to access the instance to a local
16769 variable (the variable will be accessed as a field).
16771 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16772 EmitContext.EmitAddressOfParameter): Routines to support
16773 parameters (not completed at this point).
16775 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16776 will also remove the parameters.
16778 * convert.cs (Convert): Define a `ConstantEC' which points to a
16779 null. This is just to prefity some code that uses
16780 ImplicitStandardConversion code and do not have an EmitContext
16783 The idea is to flag explicitly that at that point in time, it is
16784 known that the conversion will not trigger the delegate checking
16785 code in implicit conversions (which requires a valid
16788 Everywhere: pass new EmitContext parameter since
16789 ImplicitStandardConversionExists now requires it to check for
16790 anonymous method conversions.
16792 (Convert.ImplicitStandardConversionExists): If the type of an
16793 expression is the anonymous_method_type, and the type is a
16794 delegate, we invoke the AnonymousMethod.Compatible method to check
16795 whether an implicit conversion is possible.
16797 (Convert.ImplicitConversionStandard): Only do implicit method
16798 group conversions if the language level is not ISO_1.
16800 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16801 MethodInfo for the Invoke method. used by Delegate and
16804 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16805 method conversions if the target type is a delegate.
16807 Removed extra debugging nops.
16809 (LocalVariableReference): Turn the `local_info' into a public
16812 Add `prepared' field, the same hack used for FieldExprs to cope
16813 with composed assignments, as Local variables do not necessarily
16814 operate purely on the stack as they used to: they can be captured
16817 Add `temp' for a temporary result, like fields.
16819 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16821 It now copes with Local variables that are captured and emits the
16822 proper instance variable to load it from a field in the captured
16825 (ParameterReference.DoResolveBase): During the resolve phase,
16826 capture parameters if we are in an anonymous method.
16828 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16829 anonymous method, use the EmitContext helper routines to emit the
16830 parameter reference.
16832 * iterators.cs: Set RemapToProxy to true/false during the
16835 * parameters.cs (GetParameterByName): New helper method.
16837 * typemanager.cs (anonymous_method_type) a new type that
16838 represents an anonyous method. This is always an internal type,
16839 used as a fencepost to test against the anonymous-methodness of an
16842 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16844 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16846 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16848 2004-10-18 Martin Baulig <martin@ximian.com>
16850 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16851 `Type' directly, but call ResolveType() on it.
16852 (Catch.Resolve): Likewise.
16853 (Foreach.Resolve): Likewise.
16855 2004-10-18 Martin Baulig <martin@ximian.com>
16857 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16858 `Type' directly, but call ResolveType() on it.
16859 (Probe.DoResolve): Likewise.
16860 (ArrayCreation.LookupType): Likewise.
16861 (TypeOf.DoResolve): Likewise.
16862 (SizeOf.DoResolve): Likewise.
16864 2004-10-18 Martin Baulig <martin@ximian.com>
16866 * expression.cs (Invocation.BetterFunction): Put back
16867 TypeManager.TypeToCoreType().
16869 2004-10-18 Raja R Harinath <rharinath@novell.com>
16871 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16874 2004-10-18 Martin Baulig <martin@ximian.com>
16876 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16877 `Type' directly, but call ResolveType() on it.
16879 2004-10-18 Martin Baulig <martin@ximian.com>
16881 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16882 `Type' directly, but call ResolveType() on it.
16883 (MemberBase.DoDefine): Likewise.
16885 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16886 `Type' directly, but call ResolveType() on it.
16887 (ComposedCast.DoResolveAsTypeStep): Likewise.
16889 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16890 `Type' directly, but call ResolveType() on it.
16892 2004-10-17 John Luke <john.luke@gmail.com>
16894 * class.cs (Operator.GetSignatureForError): use CSharpName
16896 * parameter.cs (Parameter.GetSignatureForError): Returns
16897 correct name even if was not defined.
16899 2004-10-13 Raja R Harinath <rharinath@novell.com>
16902 * class.cs (TypeContainer.EmitContext): New property.
16903 (DefineNestedTypes): Create an emitcontext for each part.
16904 (MethodCore.DoDefineParameters): Use container's emitcontext.
16905 Pass type array to InternalParameters.
16906 (MemberBase.DoDefine): Use container's emitcontext.
16907 (FieldMember.Define): Likewise.
16908 (Event.Define): Likewise.
16909 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16910 Pass type array to InternalParameters.
16911 (SetIndexerMethod.GetParameterInfo): Likewise.
16912 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16913 * delegate.cs (Define): Pass emitcontext to
16914 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16915 array to InternalParameters.
16916 * expression.cs (ParameterReference.DoResolveBase): Pass
16917 emitcontext to GetParameterInfo.
16918 (ComposedCast.DoResolveAsTypeStep): Remove check on
16919 ec.ResolvingTypeTree.
16920 * parameter.cs (Parameter.Resolve): Change argument to
16921 EmitContext. Use ResolveAsTypeTerminal.
16922 (Parameter.GetSignature): Change argument to EmitContext.
16923 (Parameters.ComputeSignature): Likewise.
16924 (Parameters.ComputeParameterTypes): Likewise.
16925 (Parameters.GetParameterInfo): Likewise.
16926 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16927 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16928 * support.cs (InternalParameters..ctor): Remove variant that takes
16930 * typemanager.cs (system_intptr_expr): New.
16931 (InitExpressionTypes): Initialize it.
16933 2004-10-12 Chris Toshok <toshok@ximian.com>
16935 * cs-parser.jay: fix location for try_statement and catch_clause.
16937 2004-10-11 Martin Baulig <martin@ximian.com>
16939 * report.cs: Don't make --fatal abort on warnings, we have
16940 -warnaserror for that.
16942 2004-10-07 Raja R Harinath <rharinath@novell.com>
16944 More DeclSpace.ResolveType avoidance.
16945 * decl.cs (MemberCore.InUnsafe): New property.
16946 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16947 with newly created EmitContext.
16948 (FieldMember.Define): Likewise.
16949 * delegate.cs (Delegate.Define): Likewise.
16950 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16951 only if normal name-lookup fails.
16952 (TypeExpr.DoResolve): Enable error-checking.
16953 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16954 (SizeOf.DoResolve): Likewise.
16955 (ComposedCast.DoResolveAsTypeStep): Likewise.
16956 (StackAlloc.DoResolve): Likewise.
16957 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16958 (Block.Unsafe): New property.
16959 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16960 (Unsafe): Set 'unsafe' flag of contained block.
16961 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16962 (Fixed.Resolve): Likewise.
16963 (Catch.Resolve): Likewise.
16964 (Using.ResolveLocalVariableDecls): Likewise.
16965 (Foreach.Resolve): Likewise.
16967 2004-10-05 John Luke <john.luke@gmail.com>
16969 * cs-parser.jay: add location to error CS0175
16971 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16973 * ecore.cs (Expression.Constantity): Add support for turning null
16976 * const.cs (Const.Define): Allow constants to be reference types
16977 as long as the value is Null.
16979 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16981 * namespace.cs (NamespaceEntry.Using): No matter which warning
16982 level is set, check if this namespace name has already been added.
16984 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16986 * expression.cs: reftype [!=]= null should always use br[true,false].
16989 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16992 * attribute.cs: Enum conversion moved to
16993 GetAttributeArgumentExpression to be applied to the all
16996 2004-10-01 Raja R Harinath <rharinath@novell.com>
16998 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16999 * class.c (TypeContainer.DefineType): Flag error if
17000 base types aren't accessible due to access permissions.
17001 * decl.cs (DeclSpace.ResolveType): Move logic to
17002 Expression.ResolveAsTypeTerminal.
17003 (DeclSpace.ResolveTypeExpr): Thin layer over
17004 Expression.ResolveAsTypeTerminal.
17005 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
17006 Refactor code into NestedAccess. Use it.
17007 (DeclSpace.NestedAccess): New.
17008 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
17009 argument to silence errors. Check access permissions.
17010 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
17011 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
17012 (Cast.DoResolve): Likewise.
17013 (New.DoResolve): Likewise.
17014 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
17015 (TypeOf.DoResolve): Likewise.
17017 * expression.cs (Invocation.BetterConversion): Return the Type of
17018 the better conversion. Implement section 14.4.2.3 more faithfully.
17019 (Invocation.BetterFunction): Make boolean. Make correspondence to
17020 section 14.4.2.2 explicit.
17021 (Invocation.OverloadResolve): Update.
17022 (Invocation): Remove is_base field.
17023 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
17024 (Invocation.Emit): Likewise.
17026 2004-09-27 Raja R Harinath <rharinath@novell.com>
17028 * README: Update to changes.
17030 2004-09-24 Marek Safar <marek.safar@seznam.cz>
17032 * cs-parser.jay: Reverted 642 warning fix.
17034 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17037 * decl.cs (FindMemberWithSameName): Indexer can have more than
17040 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17042 * expression.cs (LocalVariableReference.DoResolveLValue):
17043 Do not report warning 219 for out values.
17044 (EmptyExpression.Null): New member to avoid extra allocations.
17046 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17048 * cs-parser.jay: Fix wrong warning 642 report.
17050 * cs-tokenizer.cs (CheckNextToken): New helper;
17051 Inspect next character if is same as expected.
17053 2004-09-23 Martin Baulig <martin@ximian.com>
17055 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
17056 (Convert.ImplicitReferenceConversionExists): Likewise.
17058 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17060 * class.cs (Operator.Define): Add error 448 and 559 report.
17062 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17064 * class.cs (MemberBase.IsTypePermitted): New protected
17065 method for checking error CS0610.
17067 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17069 * class.cs (TypeContainer.HasExplicitLayout): New property
17070 Returns whether container has StructLayout attribute set Explicit.
17071 (FieldMember): New abstract class for consts and fields.
17072 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
17073 (Field): Reuse FieldMember.
17075 * const.cs (Const): Reuse FieldMember.
17077 * rootcontext.cs: EmitConstants call moved to class.
17079 2004-09-22 Martin Baulig <martin@ximian.com>
17081 Thanks to Peter Sestoft for this bug report.
17083 * expression.cs (Conditional): If both the `trueExpr' and the
17084 `falseExpr' is a NullLiteral, return a NullLiteral.
17086 2004-09-22 Martin Baulig <martin@ximian.com>
17088 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
17089 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
17090 for the "get_Current" call.
17092 2004-09-22 Martin Baulig <martin@ximian.com>
17094 Marek and me just fixed one of our oldest bugs: #28562 :-)
17096 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
17098 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
17099 we're an EnumConstant, just return that.
17100 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
17101 an EnumConstant. In this case, we need to use GetValueAsEnumType()
17102 to get the value which'll actually be written into the attribute.
17103 However, we have to use GetValue() to access the attribute's value
17106 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17108 * constant.cs (Constant.IsNegative): New abstract property
17111 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
17112 (StackAlloc.DoResolve): Reused IsNegative.
17114 2004-09-21 Martin Baulig <martin@ximian.com>
17116 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17117 if we're used in an iterator, we may be called from different
17120 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17121 we actually have an exception block.
17123 2004-09-20 John Luke <jluke@cfl.rr.com>
17125 * class.cs, cs-parser.jay: Improve the error report for 1520:
17126 report the actual line where the error happens, not where the
17127 class was declared.
17129 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17130 Pass location information that was available elsewhere.
17132 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17134 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17135 runtime to delay sign assemblies.
17137 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17139 * cs-parser.jay: Do not report the stack trace, this is barely
17142 2004-08-22 John Luke <john.luke@gmail.com>
17144 * driver.cs : check that a resource id is not already used
17145 before adding it, report CS1508 if it is, bug #63637
17147 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17149 * ecore.cs: Removed dead code.
17151 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17153 * class.cs: Do not report warning CS0067 on the interfaces.
17155 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17157 * cs-parser.jay: Add error 504 report.
17159 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17161 * rootcontext.cs: WarningLevel is 4 by default now.
17163 * statement.cs (Fixed.Resolve): Do not null
17166 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17169 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17170 deep search when property is not virtual.
17171 (PropertyExpr.ResolveAccessors): Make one call for both
17174 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17177 * statement.cs: Error 152 report constains also location.
17179 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17182 * const.cs: Explicitly set constant as static.
17184 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17187 * cs-parser.jay: Add error 1017 report.
17189 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17191 Fixed bug #59980, #64224
17192 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17194 * typemanager.cs (IsSpecialMethod): Simplified
17196 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17198 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17199 condition with better params.
17201 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17204 * attribute.cs (Resolve): Property has to have both
17207 2004-09-14 Martin Baulig <martin@ximian.com>
17209 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17211 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17214 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17215 called and is obsolete then this member suppress message
17216 when call is inside next [Obsolete] method or type.
17218 * expression.cs: Use TestObsoleteMethodUsage member.
17220 2004-09-14 Martin Baulig <martin@ximian.com>
17222 * cs-parser.jay: Sync a bit with the GMCS version.
17224 2004-09-14 Martin Baulig <martin@ximian.com>
17226 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17227 (CSharpParser.yacc_verbose_flag): New public field.
17229 * genericparser.cs: Removed.
17231 2004-09-14 Raja R Harinath <rharinath@novell.com>
17233 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17235 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17237 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17239 2004-09-10 Martin Baulig <martin@ximian.com>
17241 Backported my MemberName changes from GMCS into MCS.
17243 - we are now using a special `MemberName' class instead of using
17244 strings; in GMCS, the `MemberName' also contains the type
17247 - changed the grammar rules a bit:
17248 * the old `member_name' is now a `namespace_or_type_name':
17249 The rule is that we use `namespace_or_type_name' everywhere
17250 where we expect either a "member name" (GetEnumerator) or a
17251 "member name" with an explicit interface name
17252 (IEnumerable.GetEnumerator).
17253 In GMCS, the explicit interface name may include type arguments
17254 (IEnumerable<T>.GetEnumerator).
17255 * we use `member_name' instead of just `IDENTIFIER' for
17257 The rule is that we use `member_name' wherever a member may
17258 have type parameters in GMCS.
17260 * decl.cs (MemberName): New public class.
17261 (MemberCore.MemberName): New public readonly field.
17262 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17263 (DeclSpace): Likewise.
17265 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17266 * enum.cs (Enum.ctor): Likewise.
17268 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17270 (AliasEntry.ctor): Take a MemberName, not an Expression.
17271 (AliasEntry.UsingAlias): Likewise.
17273 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17274 (IMethodData.MemberName): Changed type from string to MemberName.
17275 (MemberBase.ExplicitInterfaceName): Likewise.
17276 (AbstractPropertyEventMethod.SetupName): Make this private.
17277 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17278 argument; compute the member name here.
17279 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17280 on the `member.MemberName' and the `prefix'.
17282 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17284 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17285 thus, we get a `MemberName' instead of a `string'. These
17286 declarations may have type parameters in GMCS.
17287 (interface_method_declaration, delegate_declaration): Likewise.
17288 (class_declaration, interface_declaration): Likewise.
17289 (method_header): Use `namespace_or_type_name' instead of
17290 `member_name'. We may be an explicit interface implementation.
17291 (property_declaration, event_declaration): Likewise.
17292 (member_name): This is now just an `IDENTIFIER', not a
17293 `namespace_or_type_name'.
17294 (type_name, interface_type): Removed.
17295 (namespace_or_type_name): Return a MemberName, not an Expression.
17296 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17297 call GetTypeExpression() on the MemberName to get an expression.
17298 (IndexerDeclaration.interface_type): Changed type from string to
17300 (MakeName): Operate on MemberName's instead of string's.
17302 2004-09-13 Raja R Harinath <rharinath@novell.com>
17305 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17306 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17307 lookup to avoid symbols introduced by 'using'.
17308 * rootcontext.cs (NamespaceLookup): Update.
17310 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17312 * class.cs (TypeContainer.DoDefineMembers): Do not call
17313 DefineDefaultConstructor for static classes.
17315 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17317 * attribute.cs (Attribute.Resolve): Add error 653 report.
17319 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17321 (Method.ApplyAttributeBuilder): Add error 685 report.
17322 (Operator.Define): Add error 564 report.
17324 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17326 * expression.cs (Invocation.DoResolve): Add error
17327 245 and 250 report.
17329 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17332 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17334 * class.cs (ConstructorInitializer.Resolve):
17335 Wrong error number (515->516).
17337 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17339 * class.cs (Indexer.Define): Add error 631 report.
17341 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17343 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17345 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17347 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17349 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17351 * cs-parser.jay: Added error CS0241 report.
17353 2004-09-10 Raja R Harinath <rharinath@novell.com>
17355 * cs-parser.jay (fixed_statement): Introduce a scope for the
17356 declaration in the 'fixed' statement.
17358 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17360 * cs-parser.jay: Added CS0230 error report.
17362 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17364 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17366 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17368 * expression.cs (Argument.Resolve): Added error CS0192 and
17371 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17373 C# 2.0 #pragma warning feature
17375 * cs-tokenizer.cs (PreProcessPragma): New method;
17376 Handles #pragma directive.
17378 * report.cs (WarningRegions): New class; Support
17379 class for #pragma warning directive. It tests whether
17380 warning is enabled for a given line.
17382 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17384 * const.cs: Add more descriptive error report, tahnks to
17387 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17389 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17391 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17393 * expression.cs: Apply patch from Ben: Remove dead code from
17394 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17395 as that code just threw an exception anwyays.
17397 * const.cs: Remove the call to the turnintoconstant, for details
17400 * literal.cs: The type of the null-literal is the null type; So
17401 we use a placeholder type (literal.cs:System.Null, defined here)
17404 * expression.cs (Conditional.DoResolve): Remove some old code that
17405 is no longer needed, conversions have been fixed.
17407 (ArrayCreationExpression.DoResolve): Return false if we fail to
17408 resolve the inner expression.
17410 2004-09-07 Raja R Harinath <rharinath@novell.com>
17413 * cs-parser.jay (delegate_declaration): Record a delegate
17414 declaration as a type declaration.
17415 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17417 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17419 * parameter.cs: Do not crash if the type can not be resolved.
17421 * expression.cs: Report errors with unsafe pointers, fixes #64896
17423 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17425 * expression.cs: Pointer arith always needs to do a conv.i
17426 if the operand is a long. fix 65320
17428 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17430 Fixed cs0619-37.cs, cs0619-38.cs
17432 * enum.cs (GetObsoleteAttribute): Removed.
17434 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17435 on Enum member is double staged. The first is tested member
17438 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17440 Fixed #56986, #63631, #65231
17442 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17443 adds member to name container.
17444 (TypeContainer.AddToTypeContainer): New method, adds type to
17446 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17447 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17448 AddOperator): Simplified by reusing AddToMemberContainer.
17449 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17451 (Method.CheckForDuplications): Fixed implementation to test all
17453 (MemberBase): Detection whether member is explicit interface
17454 implementation is now in constructor.
17455 (MemberBase.UpdateMemberName): Handles IndexerName.
17456 (Accessor): Changed to keep also location information.
17457 (AbstractPropertyEventMethod): Is derived from MemberCore.
17458 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17459 will be emited or not.
17460 (PropertyBase.AreAccessorsDuplicateImplementation):
17461 Tests whether accessors are not in collision with some method.
17462 (Operator): Is derived from MethodCore to simplify common
17465 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17467 (DeclSpace.AddToContainer): Adds the member to defined_names
17468 table. It tests for duplications and enclosing name conflicts.
17470 * enum.cs (EnumMember): Clean up to reuse the base structures
17472 2004-09-03 Martin Baulig <martin@ximian.com>
17474 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17475 into TypeContainer, to make partial classes work again.
17477 2004-09-03 Martin Baulig <martin@ximian.com>
17479 * rootcontext.cs (RootContext.V2): Removed.
17481 2004-03-23 Martin Baulig <martin@ximian.com>
17483 * expression.cs (Invocation.OverloadResolve): Added `bool
17484 may_fail' argument and use it instead of the Location.IsNull() hack.
17486 2004-09-03 Martin Baulig <martin@ximian.com>
17488 Merged latest changes into gmcs. Please keep this comment in
17489 here, it makes it easier for me to see what changed in MCS since
17490 the last time I merged.
17492 2004-09-03 Raja R Harinath <rharinath@novell.com>
17495 * expression.cs (BetterConversion): Don't allow either conversion
17496 to be null. Remove redundant implicit conversion test when 'q ==
17497 null' -- when this function is invoked, we already know that the
17498 implicit conversion exists.
17499 (BetterFunction): Assume that 'best' is non-null. Remove
17500 redundant reimplementation of IsApplicable when 'best' is null.
17501 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17502 number of arguments.
17503 (IsAncestralType): Extract from OverloadResolve.
17504 (OverloadResolve): Make robust to the MethodGroupExpr being
17505 unsorted. Implement all the logic of Section 14.5.5.1, and
17506 support overloading of methods from multiple applicable types.
17507 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17509 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17510 (RealError, Warning): Append type of report to related symbol.
17512 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17514 * enum.cs: Fixed CLS-Compliance checks for enum members.
17515 Error tests cs3008-8.cs, cs3014-8.cs
17517 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17519 Fixed bug #62342, #63102
17520 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17521 like ImplementMethod.
17523 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17525 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17528 2004-09-02 Martin Baulig <martin@ximian.com>
17530 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17531 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17534 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17536 C# 2.0 Static classes implemented
17538 * class.cs (TypeContainer): instance_constructors,
17539 initialized_fields, initialized_static_fields,
17540 default_constructor, base_inteface_types are protected to be
17541 accessible from StaticClass.
17542 (TypeContainer.DefineDefaultConstructor): New virtual method
17543 for custom default constructor generating
17544 (StaticClass): New class to handle "Static classes" feature.
17546 * cs-parser.jay: Handle static keyword on class like instance
17549 * driver.cs: Added "/langversion" command line switch with two
17550 options (iso-1, default).
17552 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17554 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17556 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17558 * delegate.cs: Style.
17560 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17562 * delegate.cs: Add seperate instance expr field for miguel.
17564 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17566 * PointerArithmetic (Resolve): make sure we are not doing
17567 pointer arith on void*. Also, make sure we are resolved
17568 by not setting eclass until resolve.
17570 All callers: Make sure that PointerArithmetic gets resolved.
17572 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17574 * ArrayCreation (LookupType): If the type does not resolve
17575 to an array, give an error.
17577 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17579 * statement.cs (Try.Resolve): Fixed bug #64222
17581 2004-08-27 Martin Baulig <martin@ximian.com>
17584 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17587 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17589 * ecore.cs (Constantify): Get underlying type via
17590 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17591 Windows in special cases.
17593 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17595 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17596 for obtaining also private methods.
17597 (GetRemoveMethod): Used GetRemoveMethod (true)
17598 for obtaining also private methods.
17600 2004-08-24 Martin Baulig <martin@ximian.com>
17602 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17603 MethodAttributes.HideBySig for operators.
17605 2004-08-23 Martin Baulig <martin@ximian.com>
17607 Back to the old error reporting system :-)
17609 * report.cs (Message): Removed.
17610 (Report.MessageData, ErrorData, WarningData): Removed.
17611 (Report.Error, Warning): Back to the old system.
17613 2004-08-23 Martin Baulig <martin@ximian.com>
17615 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17617 * class.cs (TypeContainer.ParentContainer): New public virtual
17618 method; replaces the explicit interface implementation.
17619 (ClassPart.ParentContainer): Override.
17621 2004-08-23 Martin Baulig <martin@ximian.com>
17623 * statement.cs (Switch): Added support for constant switches; see
17624 #59428 or test-285.cs.
17626 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17629 * statement.cs (GetEnumeratorFilter): Removed useless
17630 logic because C# specs is strict. GetEnumerator must be
17633 2004-08-22 Martin Baulig <martin@ximian.com>
17635 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17636 a switch and may break, reset the barrier. Fixes #59867.
17638 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17640 CLS-Compliance speed up (~5% for corlib)
17642 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17643 New method. Tests container for CLS-Compliant names
17645 * class.cs (TypeContainer.VerifyClsName): New method.
17646 Checks whether container name is CLS Compliant.
17647 (Constructor): Implements IMethodData.
17649 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17650 low-case table for CLS Compliance test.
17651 (MemberCache.VerifyClsParameterConflict): New method.
17652 Checks method parameters for CS3006 error.
17654 * enum.cs (EnumMember): Is derived from MemberCore.
17655 (Enum.VerifyClsName): Optimized for better performance.
17657 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17659 * report.cs: Renamed Error_T to Error and changed all
17662 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17664 * class.cs (TypeContainer.IndexerArrayList): New inner class
17665 container for indexers.
17666 (TypeContainer.DefaultIndexerName): New constant for default
17667 indexer name. Replaced all "Item" with this constant.
17668 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17670 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17671 DefaultMemberAttribute constructor.
17673 2004-08-05 Martin Baulig <martin@ximian.com>
17675 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17678 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17680 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17681 multi platforms problem.
17683 * compiler.csproj: Included shared files.
17685 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17687 Fix bug 60333, 55971 in the more general way
17688 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17689 Added arg_type argument for constant conversion.
17690 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17692 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17695 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17696 OperatorArrayList, MethodCoreArrayList for typecontainer
17697 containers. Changed class member types to these new types.
17698 (MethodArrayList.DefineMembers): Added test for CS0659.
17700 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17702 * cfold.cs: Synchronize the folding with the code in expression.cs
17703 Binary.DoNumericPromotions for uint operands.
17705 * attribute.cs: Revert patch from Raja, it introduced a regression
17706 while building Blam-1.2.1 (hard to isolate a test case).
17708 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17712 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17714 (MethodCore.parent_method): New member. The method we're overriding
17715 if this is an override method.
17716 (MethodCore.CheckBase): Moved from Method class and made common.
17717 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17719 (MethodCore.CheckForDuplications): New abstract method. For custom
17720 member duplication search in a container
17721 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17722 method and its return type.
17723 (Event.conflict_symbol): New member. Symbol with same name in the
17727 (MemberCache.FindMemberWithSameName): New method. The method
17728 is looking for conflict with inherited symbols.
17730 2004-08-04 Martin Baulig <martin@ximian.com>
17732 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17734 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17736 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17738 * report.cs (Message): New enum for better error, warning reference in
17740 (MessageData): New inner abstract class. It generally handles printing of
17741 error and warning messages.
17742 Removed unused Error, Warning, Message methods.
17744 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17746 Fix for cs0592-8.cs test
17748 (Attributable.ValidAttributeTargets): Made public.
17749 (Attribute.ExplicitTarget): New member for explicit target value.
17750 (Attribute.CheckTargets): Now we translate explicit attribute
17751 target to Target here.
17753 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17755 * ecore.cs (MethodGroupExpr): new IsBase property.
17757 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17759 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17760 rather than an instance expr.
17762 (DelegateCreation.Emit): Use the method group rather than
17763 the instance expression. Also, if you have base.Foo as the
17764 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17766 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17768 (NewDelegate.DoResolve): Only check for the existance of Invoke
17769 if the method is going to be needed. Use MethodGroupExpr.
17771 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17773 * expression.cs: For pointer arith., make sure to use
17774 the size of the type, not the size of the pointer to
17777 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17780 * class.cs (Class): Added error CS0502 test.
17782 2004-08-03 John Luke <jluke@cfl.rr.com>
17783 Raja R Harinath <rharinath@novell.com>
17786 * attribute.cs (Attribute.complained_before): New flag.
17787 (Attribute.ResolveType, Attribute.Resolve),
17788 (Attribute.DefinePInvokeMethod): Set it.
17789 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17791 2004-08-03 Martin Baulig <martin@ximian.com>
17793 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17794 use a user-defined operator; we still need to do numeric
17795 promotions in case one argument is a builtin type and the other
17796 one has an implicit conversion to that type. Fixes #62322.
17798 2004-08-02 Martin Baulig <martin@ximian.com>
17800 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17801 (LocalInfo.IsThis): New public property.
17802 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17804 2004-08-01 Martin Baulig <martin@ximian.com>
17806 * class.cs (TypeContainer.GetClassBases): Don't set the default
17807 here since we may get called from GetPartialBases().
17808 (TypeContainer.DefineType): If GetClassBases() didn't return a
17809 parent, use the default one.
17811 2004-07-30 Duncan Mak <duncan@ximian.com>
17813 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17815 2004-07-30 Martin Baulig <martin@ximian.com>
17817 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17819 * class.cs (SourceMethod): New public class, derive from the
17820 symbol writer's ISourceMethod.
17821 (Method): Use the new symbol writer API.
17823 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17824 as argument and use the new symbol writer.
17827 (SourceFile): Implement the symbol writer's ISourceFile.
17828 (Location.SymbolDocument): Removed.
17829 (Location.SourceFile): New public property.
17831 * symbolwriter.cs: Use the new symbol writer API.
17833 2004-07-30 Raja R Harinath <rharinath@novell.com>
17835 * Makefile (install-local): Remove. Functionality moved to
17838 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17840 * Makefile: Install mcs.exe.config file together with mcs.exe.
17841 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17842 correct runtime version.
17844 2004-07-25 Martin Baulig <martin@ximian.com>
17847 (TypeContainer.RegisterOrder): Removed, this was unused.
17848 (TypeContainer, interface_order): Removed.
17849 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17850 TypeContainer as argument since we can also be called with a
17851 `PartialContainer' for a partial class/struct/interface.
17852 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17853 of checking whether we're an `Interface' - we could be a
17854 `PartialContainer'.
17855 (PartialContainer.Register): Override; call
17856 AddClass()/AddStruct()/AddInterface() on our parent.
17858 * cs-parser.jay (interface_member_declaration): Add things to the
17859 `current_container', not the `current_class'.
17861 * rootcontext.cs (RegisterOrder): The overloaded version which
17862 takes an `Interface' was unused, removed.
17864 * typemanager.cs (TypeManager.LookupInterface): Return a
17865 `TypeContainer', not an `Interface'.
17866 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17867 contain a `PartialContainer' for an interface, so check it's
17868 `Kind' to figure out what it is.
17870 2004-07-25 Martin Baulig <martin@ximian.com>
17872 * class.cs (Class.DefaultTypeAttributes): New public constant.
17873 (Struct.DefaultTypeAttributes): Likewise.
17874 (Interface.DefaultTypeAttributes): Likewise.
17875 (PartialContainer.TypeAttr): Override this and add the
17876 DefaultTypeAttributes.
17878 2004-07-25 Martin Baulig <martin@ximian.com>
17880 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17881 we can just use the `Parent' field instead.
17883 2004-07-25 Martin Baulig <martin@ximian.com>
17885 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17887 2004-07-25 Martin Baulig <martin@ximian.com>
17889 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17890 our parts before defining any methods.
17891 (TypeContainer.VerifyImplements): Make this virtual.
17892 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17893 on our PartialContainer.
17895 2004-07-25 Martin Baulig <martin@ximian.com>
17897 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17899 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17900 argument, we can just use the `Parent' field instead.
17903 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17904 (MemberBase.DoDefine): Likewise.
17906 2004-07-24 Martin Baulig <martin@ximian.com>
17908 * decl.cs (MemberCore.Parent): New public field.
17909 (DeclSpace.Parent): Moved to MemberCore.
17911 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17912 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17914 (FieldBase, Field, Operator): Likewise.
17915 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17916 (EventField, Event): Likewise.
17918 2004-07-23 Martin Baulig <martin@ximian.com>
17920 * class.cs (PartialContainer): New public class.
17921 (ClassPart): New public class.
17922 (TypeContainer): Added support for partial classes.
17923 (TypeContainer.GetClassBases): Splitted some of the functionality
17924 out into GetNormalBases() and GetPartialBases().
17926 * cs-tokenizer.cs (Token.PARTIAL): New token.
17927 (Tokenizer.consume_identifier): Added some hacks to recognize
17928 `partial', but only if it's immediately followed by `class',
17929 `struct' or `interface'.
17931 * cs-parser.jay: Added support for partial clases.
17933 2004-07-23 Martin Baulig <martin@ximian.com>
17935 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17936 a `DeclSpace' and also made it readonly.
17937 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17938 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17939 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17941 * cs-parser.jay: Pass the `current_class', not the
17942 `current_container' (at the moment, this is still the same thing)
17943 to a new Method, Property, Event, Indexer or Constructor.
17945 2004-07-23 Martin Baulig <martin@ximian.com>
17947 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17948 and removed the `current_interface' one.
17949 (struct_declaration, class_declaration, interface_declaration):
17950 Set `current_class' to the newly created class/struct/interface;
17951 set their `Bases' and call Register() before parsing their body.
17953 2004-07-23 Martin Baulig <martin@ximian.com>
17955 * class.cs (Kind): New public enum.
17956 (TypeContainer): Made this class abstract.
17957 (TypeContainer.Kind): New public readonly field.
17958 (TypeContainer.CheckDef): New public method; moved here from
17960 (TypeContainer.Register): New public abstract method.
17961 (TypeContainer.GetPendingImplementations): New public abstract
17963 (TypeContainer.GetClassBases): Removed the `is_class' and
17964 `is_iface' parameters.
17965 (TypeContainer.DefineNestedTypes): Formerly known as
17967 (ClassOrStruct): Made this class abstract.
17969 * tree.cs (RootTypes): New public type.
17971 2004-07-20 Martin Baulig <martin@ximian.com>
17973 * tree.cs (Tree.RecordNamespace): Removed.
17974 (Tree.Namespaces): Removed.
17976 * rootcontext.cs (RootContext.IsNamespace): Removed.
17978 * cs-parser.jay (namespace_declaration): Just create a new
17979 NamespaceEntry here.
17981 2004-07-20 Martin Baulig <martin@ximian.com>
17983 * statement.cs (ExceptionStatement): New abstract class. This is
17984 now used as a base class for everyone who's using `finally'.
17985 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17986 our local variables before using them.
17988 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17989 virtual method. This is used by Yield.Resolve() to "steal" an
17990 outer block's `finally' clauses.
17991 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17994 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17995 version which takes an ExceptionStatement. This version must be
17996 used to create exception branchings.
17999 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
18000 (Iterator.EmitMoveNext): Added exception support; protect the
18001 block with a `fault' clause, properly handle 'finally' clauses.
18002 (Iterator.EmitDispose): Run all the `finally' clauses here.
18004 2004-07-20 Martin Baulig <martin@ximian.com>
18006 * iterator.cs: This is the first of a set of changes in the
18007 iterator code. Match the spec more closely: if we're an
18008 IEnumerable, then GetEnumerator() must be called. The first time
18009 GetEnumerator() is called, it returns the current instance; all
18010 subsequent invocations (if any) must create a copy.
18012 2004-07-19 Miguel de Icaza <miguel@ximian.com>
18014 * expression.cs: Resolve the constant expression before returning
18017 2004-07-19 Martin Baulig <martin@ximian.com>
18019 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
18020 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
18021 the return type of the new EmitContext.
18023 2004-07-18 Martin Baulig <martin@ximian.com>
18025 * class.cs (Property.Define): Fix iterators.
18027 * iterators.cs (Iterator.Define): Moved the
18028 `container.AddInterator (this)' call here from the .ctor; only do
18029 it if we resolved successfully.
18031 2004-07-17 Miguel de Icaza <miguel@ximian.com>
18033 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
18034 `true' for preprocessing directives that we parse. The return
18035 value indicates whether we should return to regular tokenizing or
18036 not, not whether it was parsed successfully.
18038 In the past if we were in: #if false ... #line #endif, we would
18039 resume parsing after `#line'. See bug 61604.
18041 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
18042 building: IsEnumType should return true only for enums, not for
18043 enums or System.Enum itself. This fixes #61593.
18045 Likely what happened is that corlib was wrong: mcs depended on
18046 this bug in some places. The bug got fixed, we had to add the
18047 hack, which caused bug 61593.
18049 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
18050 that was a workaround for the older conditions.
18052 2004-07-16 Ben Maurer <bmaurer@ximian.com>
18054 * assign.cs: IAssignMethod has a new interface, as documented
18055 inline. All assignment code now uses this new api.
18057 * ecore.cs, expression.cs: All classes which implement
18058 IAssignMethod now use the new interface.
18060 * expression.cs (Invocation): add a hack to EmitCall so that
18061 IndexerAccess can be the target of a compound assignment without
18062 evaluating its arguments twice.
18064 * statement.cs: Handle changes in Invocation api.
18066 2004-07-16 Martin Baulig <martin@ximian.com>
18068 * iterators.cs: Rewrote this. We're now using one single Proxy
18069 class for both the IEnumerable and the IEnumerator interface and
18070 `Iterator' derives from Class so we can use the high-level API.
18072 * class.cs (TypeContainer.AddIterator): New method.
18073 (TypeContainer.DoDefineType): New protected virtual method, which
18074 is called from DefineType().
18075 (TypeContainer.DoDefineMembers): Call DefineType() and
18076 DefineMembers() on all our iterators.
18077 (TypeContainer.Emit): Call Emit() on all our iterators.
18078 (TypeContainer.CloseType): Call CloseType() on all our iterators.
18080 * codegen.cs (EmitContext.CurrentIterator): New public field.
18082 2004-07-15 Martin Baulig <martin@ximian.com>
18085 (TypeManager.not_supported_exception_type): New type.
18087 2004-07-14 Martin Baulig <martin@ximian.com>
18089 * iterators.cs: Use real error numbers.
18091 2004-07-14 Martin Baulig <martin@ximian.com>
18093 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
18094 requires this to be a System.Collection.IEnumerable and not a
18095 class implementing that interface.
18096 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
18098 2004-07-13 Marek Safar <marek.safar@seznam.cz>
18100 * class.cs: Fixed previous fix, it broke some error tests.
18102 2004-07-12 Martin Baulig <martin@ximian.com>
18104 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
18107 2004-07-09 Miguel de Icaza <miguel@ximian.com>
18109 * assign.cs (LocalTemporary): Add new argument: is_address,If
18110 `is_address' is true, then the value that we store is the address
18111 to the real value, and not the value itself.
18113 * ecore.cs (PropertyExpr): use the new local temporary
18114 stuff to allow us to handle X.Y += z (where X is a struct)
18116 2004-07-08 Martin Baulig <martin@ximian.com>
18118 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18119 not always return, just like we're doing in Using.Resolve().
18121 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18123 * cs-parser.jay (fixed_statement): flag this as Pinned.
18125 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18127 * typemanager.cs (TypeManager): Removed MakePinned method, this
18128 mechanism is replaced with the .NET 2.x compatible mechanism of
18129 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18131 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18132 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18133 `IsFixed' property which has a different meaning.
18135 2004-07-02 Raja R Harinath <rharinath@novell.com>
18137 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18138 visible from inside a nested class, not just the names of the
18139 immediately enclosing class.
18140 Fix for bug #60730.
18142 2004-06-24 Raja R Harinath <rharinath@novell.com>
18144 * expression.cs (BetterConversion): Remove buggy special-case
18145 handling of "implicit constant expression conversions". At this
18146 point, we already know that the conversion is possible -- we're
18147 only checking to see which is better.
18149 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18151 * cs-parser.jay: Added error CS0210 test.
18153 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18155 * cs-parser.jay: Added error CS0134 test.
18157 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18160 * cs-parser.jay: Added error CS0145 test.
18162 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18164 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18166 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18168 * expression.cs (StackAlloc.Resolve): The argument may not
18169 be a constant; deal with this case.
18171 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18173 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18174 GetIndexerAttributeValue.
18175 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18177 * class.cs (Indexer.Define): Added error tests for CS0415,
18180 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18182 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18185 2004-06-23 Martin Baulig <martin@ximian.com>
18187 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18188 neither return nor throw, reset the barrier as well. Fixes #60457.
18190 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18192 * class.cs : EventAttributes is now set to None by default.
18193 This fixes bug #60459.
18195 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18198 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18199 Don't throw exception but return null (it's sufficient now).
18201 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18203 * typemanager.cs (GetArgumentTypes): Faster implementation.
18205 2004-06-18 Martin Baulig <martin@ximian.com>
18207 * attribute.cs (Attribute.Resolve): Check whether we're an
18208 EmptyCast which a Constant child. Fixes #60333.
18210 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18212 * statement.cs (EmitCollectionForeach): Account for the fact that
18213 not all valuetypes are in areas which we can take the address of.
18214 For these variables, we store to a temporary variable. Also, make
18215 sure that we dont emit a `callvirt' on a valuetype method.
18217 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18219 * expression.cs (StackAlloc.DoReSolve): Added test for
18220 negative parameter (CS0247).
18222 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18225 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18227 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18230 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18233 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18235 Fix bug #58254 & cs1555.cs, cs1556.cs
18236 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18238 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18240 * cs-parser.jay: Added error CS1669 test for indexers.
18242 2004-06-11 Martin Baulig <martin@ximian.com>
18244 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18245 call this twice: for params and varargs methods.
18247 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18250 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18252 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18254 * attribute.cs (Attribute.GetValidTargets): Made public.
18257 (AbstractPropertyEventMethod): New class for better code sharing.
18258 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18260 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18262 2004-06-11 Raja R Harinath <rharinath@novell.com>
18265 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18266 that the call to Resolve is part of a MemberAccess.
18267 (Expression.Resolve): Use it for SimpleName resolution.
18268 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18269 Add 'intermediate' boolean argument.
18270 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18271 error message when the SimpleName can be resolved ambiguously
18272 between an expression and a type.
18273 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18275 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18276 call on the left-side.
18278 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18281 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18283 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18285 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18287 2004-06-11 Martin Baulig <martin@ximian.com>
18289 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18290 varargs methods if applicable.
18292 2004-06-11 Martin Baulig <martin@ximian.com>
18294 * expression.cs (Invocation.EmitCall): Don't use
18295 `method.CallingConvention == CallingConventions.VarArgs' since the
18296 method could also have `CallingConventions.HasThis'.
18298 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18300 * class.cs (Event.GetSignatureForError): Implemented.
18301 Fixed crash in error test cs3010.cs
18303 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18305 * cs-tokenizer.cs: Change the way we track __arglist to be
18306 consistent with the other keywords.
18308 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18310 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18313 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18315 * codegen.cs: Check that all referenced assemblies have a strongname
18316 before strongnaming the compiled assembly. If not report error CS1577.
18317 Fix bug #56563. Patch by Jackson Harper.
18318 * typemanager.cs: Added a method to return all referenced assemblies.
18319 Fix bug #56563. Patch by Jackson Harper.
18321 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18324 (Method.ApplyAttributeBuilder): Moved and added conditional
18325 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18328 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18330 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18333 * class.cs: (EventField.attribute_targets): Changed default target.
18335 2004-06-08 Martin Baulig <martin@ximian.com>
18337 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18339 2004-06-08 Martin Baulig <martin@ximian.com>
18341 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18343 2004-06-07 Martin Baulig <martin@ximian.com>
18345 Added support for varargs methods.
18347 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18350 * cs-parser.jay: Added support for `__arglist'.
18352 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18354 * expression.cs (Argument.AType): Added `ArgList'.
18355 (Invocation): Added support for varargs methods.
18356 (ArglistAccess): New public class.
18357 (Arglist): New public class.
18359 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18361 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18362 a method's top-level block if the method has varargs.
18364 * support.cs (ReflectionParameters, InternalParameters): Added
18365 support for varargs methods.
18367 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18369 * class.cs: Provide location in indexer error report.
18371 * driver.cs: Use standard names.
18373 * namespace.cs: Catch the use of using after a namespace has been
18374 declared also on using aliases.
18376 2004-06-03 Raja R Harinath <rharinath@novell.com>
18379 * typemanager.cs (closure_private_ok, closure_invocation_type)
18380 (closure_qualifier_type, closure_invocation_assembly)
18381 (FilterWithClosure): Move to ...
18382 (Closure): New internal nested class.
18383 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18384 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18385 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18386 (MemberLookup, MemberLookupFailed): Use it.
18387 * expression.cs (New.DoResolve): Treat the lookup for the
18388 constructor as being qualified by the 'new'ed type.
18389 (Indexers.GetIndexersForTypeOrInterface): Update.
18391 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18394 (GetConditionalAttributeValue): New method. Returns
18395 condition of ConditionalAttribute.
18396 (SearchMulti): New method. Returns all attributes of type 't'.
18397 Use it when attribute is AllowMultiple = true.
18398 (IsConditionalMethodExcluded): New method.
18401 (Method.IsExcluded): Implemented. Returns true if method has conditional
18402 attribute and the conditions is not defined (method is excluded).
18403 (IMethodData): Extended interface for ConditionalAttribute support.
18404 (PropertyMethod.IsExcluded): Implemented.
18407 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18410 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18413 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18415 * expression.cs (ArrayCreationExpression): Make this just an
18416 `expression'. It can't be a statement, so the code here was
18419 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18422 * typemanager.cs (GetFullNameSignature): New method for
18425 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18428 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18429 Use this method when MethodBuilder is null.
18430 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18431 Added test for error CS0626 (MONO reports error for this situation).
18432 (IMethodData.GetSignatureForError): Extended interface.
18434 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18437 (AttributeTester.GetObsoleteAttribute): Returns instance of
18438 ObsoleteAttribute when type is obsolete.
18441 (TypeContainer.VerifyObsoleteAttribute): Override.
18442 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18443 (MethodCode.VerifyObsoleteAttribute): Override.
18444 (MemberBase.VerifyObsoleteAttribute): Override.
18447 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18448 and report proper error.
18451 Delegate.VerifyObsoleteAttribute): Override.
18454 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18455 and report proper error.
18456 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18459 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18463 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18464 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18465 Added test for ObsoleteAttribute.
18468 (Catch): Derived from Statement.
18470 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18472 Fixed bug #59071 & cs0160.cs
18474 * statement.cs (Try.Resolve): Check here whether order of catch
18475 clauses matches their dependencies.
18477 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18479 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18480 caused a regression: #59343. Referencing nested classes from an
18481 assembly stopped working.
18483 2004-05-31 Martin Baulig <martin@ximian.com>
18485 MCS is now frozen for beta 2.
18487 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18489 * convert.cs: add a trivial cache for overload operator resolution.
18491 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18493 * decl.cs: If possible, use lookuptypedirect here. We can only do
18494 this if there is no `.' after the namespace. Avoids using
18495 LookupType, which does lots of slow processing.
18496 (FindNestedType) New method, does what it says :-).
18497 * namespace.cs: use LookupTypeDirect.
18498 * rootcontext.cs: use membercache, if possible.
18499 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18501 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18504 According to the spec,
18506 In a member access of the form E.I, if E is a single identifier,
18507 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18508 field, property, localvariable, or parameter with the same type as
18509 the meaning of E as a type-name (§3.8), then both possible
18510 meanings of E are permitted.
18512 We did not check that E as a simple-name had the same type as E as
18515 This trivial check gives us 5-7% on bootstrap time.
18517 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18519 * expression.cs (Invocation.OverloadResolve): Avoid the
18520 use of hashtables and boxing here by allocating on demand.
18522 2004-05-30 Martin Baulig <martin@ximian.com>
18524 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18525 we're doing a silent lookup. Don't try to lookup nested types in
18526 TypeManager.object_type (thanks to Ben Maurer).
18528 2004-05-30 Martin Baulig <martin@ximian.com>
18530 Committing a patch from Ben Maurer.
18532 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18534 2004-05-29 Martin Baulig <martin@ximian.com>
18536 * class.cs (IMethodData.ShouldIgnore): New method.
18538 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18539 `Location' argument, we don't need it anywhere. Use
18540 `IMethodData.ShouldIgnore ()' instead of
18541 `MethodData.GetMethodFlags ()'.
18542 (TypeManager.AddMethod): Removed.
18543 (TypeManager.AddMethod2): Renamed to AddMethod.
18545 2004-05-29 Martin Baulig <martin@ximian.com>
18547 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18549 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18550 converting from a class type S to an interface type and we already
18551 have an object on the stack, don't box it again. Fixes #52578.
18553 2004-05-29 Martin Baulig <martin@ximian.com>
18555 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18556 Added support for `params' parameters. Fixes #59267.
18558 2004-05-29 Martin Baulig <martin@ximian.com>
18560 * literal.cs (NullPointer): Provide a private .ctor which sets
18561 `type' to TypeManager.object_type. Fixes #59048.
18563 2004-05-29 Martin Baulig <martin@ximian.com>
18565 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18566 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18568 * ecore.cs (EventExpr.instance_expr): Make the field private.
18570 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18572 Fixed bug #50080 & cs0214-2.cs
18573 * expression.cs (Cast.DoResolve): Check unsafe context here.
18575 * statement.cs (Resolve.DoResolve): Likewise.
18577 2004-05-26 Martin Baulig <martin@ximian.com>
18579 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18581 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18582 (RootContext.LookupType): Pass down the `silent' flag.
18584 2004-05-25 Martin Baulig <martin@ximian.com>
18587 (MethodGroupExpr.IdenticalTypeName): New public property.
18588 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18589 expression actually refers to a type.
18591 2004-05-25 Martin Baulig <martin@ximian.com>
18593 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18594 for #56176 and made it actually work.
18596 2004-05-25 Martin Baulig <martin@ximian.com>
18598 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18599 (FieldExpr, PropertyExpr): Override and implement
18600 CacheTemporaries. Fixes #52279.
18602 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18604 * location.cs: In the new compiler listing a file twice is a
18605 warning, not an error.
18607 2004-05-24 Martin Baulig <martin@ximian.com>
18609 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18610 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18612 2004-05-24 Martin Baulig <martin@ximian.com>
18614 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18615 walking the `using' list. Fixes #53921.
18617 2004-05-24 Martin Baulig <martin@ximian.com>
18619 * const.cs (Const.LookupConstantValue): Added support for
18620 EmptyCast's; fixes #55251.
18622 2004-05-24 Martin Baulig <martin@ximian.com>
18624 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18625 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18626 which does the CS0135 check. The reason is that we first need to
18627 check whether the variable actually exists.
18629 2004-05-24 Martin Baulig <martin@ximian.com>
18631 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18632 than RootContext.LookupType() to find the explicit interface
18633 type. Fixes #58584.
18635 2004-05-24 Raja R Harinath <rharinath@novell.com>
18637 * Makefile: Simplify. Use executable.make.
18638 * mcs.exe.sources: New file. List of sources of mcs.exe.
18640 2004-05-24 Anders Carlsson <andersca@gnome.org>
18644 Use the invariant culture when doing String.Compare for CLS case
18647 2004-05-23 Martin Baulig <martin@ximian.com>
18649 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18650 don't have any dots. Fixes #52622, added cs0246-8.cs.
18652 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18654 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18656 * class.cs (MemberBase.Define): Reuse MemberType member for
18657 resolved type. Other methods can use it too.
18659 2004-05-23 Martin Baulig <martin@ximian.com>
18661 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18662 the variable also exists in the current block (otherwise, we need
18663 to report a CS0103). Fixes #58670.
18665 2004-05-23 Martin Baulig <martin@ximian.com>
18667 * flowanalysis.cs (Reachability.Reachable): Compute this
18668 on-the-fly rather than storing it as a field.
18670 2004-05-23 Martin Baulig <martin@ximian.com>
18672 * flowanalysis.cs (Reachability.And): Manually compute the
18673 resulting `barrier' from the reachability.
18675 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18678 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18679 instance of ObsoleteAttribute when symbol is obsolete.
18682 (IMethodData): Extended interface for ObsoleteAttribute support.
18684 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18686 * attribute.cs: Fix bug #55970
18688 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18692 (GetObsoleteAttribute): New method. Creates the instance of
18694 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18695 ObsoleteAttribute when member is obsolete.
18696 (AttributeTester.Report_ObsoleteMessage): Common method for
18697 Obsolete error/warning reporting.
18700 (TypeContainer.base_classs_type): New member for storing parent type.
18703 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18704 for this MemberCore.
18706 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18708 * attribute.cs, const.cs: Fix bug #58590
18710 2004-05-21 Martin Baulig <martin@ximian.com>
18712 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18713 out parameters if the end of the method is unreachable. Fixes
18716 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18718 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18719 Hari was right, why extra method.
18721 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18723 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18725 2004-05-20 Martin Baulig <martin@ximian.com>
18727 Merged this back from gmcs to keep the differences to a minumum.
18729 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18730 instead of a Declspace.
18731 (Attribute.ResolveType): Likewise.
18732 (Attributes.Search): Likewise.
18733 (Attributes.Contains): Likewise.
18734 (Attributes.GetClsCompliantAttribute): Likewise.
18736 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18738 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18741 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18743 Fix bug #58688 (MCS does not report error when the same attribute
18746 * attribute.cs (Attribute.Emit): Distinction between null and default.
18748 2004-05-19 Raja R Harinath <rharinath@novell.com>
18750 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18751 of a top-level attribute without an attribute target.
18752 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18754 (Attribute.Conditional_GetConditionName),
18755 (Attribute.Obsolete_GetObsoleteMessage): Update.
18756 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18757 part of ScanForIndexerName.
18758 (Attribute.CanIgnoreInvalidAttribute): New function.
18759 (Attribute.ScanForIndexerName): Move to ...
18760 (Attributes.ScanForIndexerName): ... here.
18761 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18762 (Attributes.Search): New internal variant that can choose not to
18763 complain if types aren't resolved. The original signature now
18765 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18766 complaints suppressed.
18767 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18768 only if it not useful.
18769 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18770 top-level for attributes that are shared between the assembly
18771 and a top-level class.
18772 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18773 * class.cs: Update to reflect changes.
18774 (DefineIndexers): Fuse loops.
18775 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18776 a couple more variants of attribute names.
18778 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18780 Fix bug #52585 (Implemented explicit attribute declaration)
18783 (Attributable.ValidAttributeTargets): New abstract method. It gets
18784 list of valid attribute targets for explicit target declaration.
18785 (Attribute.Target): It holds target itself.
18786 (AttributeSection): Removed.
18787 (Attribute.CheckTargets): New method. It checks whether attribute
18788 target is valid for the current element.
18791 (EventProperty): New class. For events that are declared like
18792 property (with add and remove accessors).
18793 (EventField): New class. For events that are declared like field.
18796 * cs-parser.jay: Implemented explicit attribute target declaration.
18798 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18799 Override ValidAttributeTargets.
18802 (ReturnParameter): Class for applying custom attributes on
18804 (ParameterAtribute): New class. Class for applying custom
18805 attributes on the parameter type.
18807 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18809 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18812 (Method): Allow UNSAFE here.
18814 * modifiers.cs: Support unsafe reporting.
18816 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18818 * decl.cs: Fix bug #58478.
18820 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18822 * statement.cs: When checking for unreachable code on an EmptyStatement,
18823 set the location. Fixes bug #58488.
18825 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18827 * driver.cs: Add -pkg handling.
18829 From Gonzalo: UseShelLExecute=false
18831 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18834 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18836 (Attribute.IsClsCompliaceRequired): Moved to base for better
18838 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18839 when attribute is AttributeUsageAttribute.
18840 (Attribute.GetValidTargets): Simplified.
18841 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18842 attribute for this type.
18843 (Attribute.ApplyAttributes): Method renamed to Emit and make
18845 (GlobalAttributeSection): New class for special handling of global
18846 attributes (assembly, module).
18847 (AttributeSection.Emit): New method.
18849 * class.cs: Implemented Attributable abstract methods.
18850 (MethodCore.LabelParameters): Moved to Parameter class.
18851 (Accessor): Is back simple class.
18852 (PropertyMethod): Implemented Attributable abstract class.
18853 (DelegateMethod): Implemented Attributable abstract class.
18854 (Event): New constructor for disctintion between normal Event
18855 and Event with accessors.
18857 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18859 * codegen.cs, const.cs, decl.cs, delegate.cs:
18860 (CommonAssemblyModulClass): Implemented Attributable abstract class
18863 * enum.cs: Implement IAttributeSupport interface.
18864 (EnumMember): New class for emum members. Implemented Attributable
18868 (ParameterBase): Is abstract.
18869 (ReturnParameter): New class for easier [return:] attribute handling.
18871 * typemanager.cs: Removed builder_to_attr.
18873 2004-05-11 Raja R Harinath <rharinath@novell.com>
18876 * attribute.cs (Attribute.GetPositionalValue): New function.
18877 * class.cs (TypeContainer.VerifyMembers): New function.
18878 (TypeContainer.Emit): Use it.
18879 (ClassOrStruct): New base class for Class and Struct.
18880 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18881 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18883 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18884 then each non-static field should have a FieldOffset attribute.
18885 Otherwise, none of the fields should have a FieldOffset attribute.
18886 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18887 and FieldOffset attributes.
18888 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18889 (TypeManager.field_offset_attribute_type): New core types.
18890 (TypeManager.InitCoreTypes): Initialize them.
18892 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18894 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18895 Return correct type.
18898 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18900 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18901 be implicitly converted to ulong.
18903 * expression.cs: The logic for allowing operator &, | and ^ worked
18904 was wrong, it worked before because we did not report an error in
18905 an else branch. Fixes 57895.
18907 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18908 allow volatile fields to be reference types.
18910 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18912 * driver.cs: Add support for /debug-
18914 2004-05-07 Raja R Harinath <rharinath@novell.com>
18916 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18917 Add a 'complain' parameter to silence errors.
18918 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18919 silently overlooked type-resolutions.
18920 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18921 to reflect changes.
18922 (Attributes.Search): New function.
18923 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18924 (Attributes.GetAttributeFullName): Remove hack.
18925 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18926 Update to reflect changes.
18927 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18928 Use Attributes.Search instead of nested loops.
18930 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18933 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18934 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18935 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18937 * report.cs: (Report.Warning): Renamed to Warning_T because of
18938 parameter collision.
18940 2004-05-05 Raja R Harinath <rharinath@novell.com>
18942 * expression.cs (MemberAccess.ResolveMemberAccess):
18943 Exit with non-zero status after Report.Error.
18944 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18946 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18948 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18950 * support.cs: Don't hang when the file is empty.
18952 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18954 * support.cs: In SeekableStreamReader, compute the preamble size of the
18955 underlying stream. Position changes should take into account that initial
18958 2004-05-03 Todd Berman <tberman@sevenl.net>
18960 * driver.cs: remove unused GetSysVersion function.
18962 2004-05-03 Todd Berman <tberman@sevenl.net>
18964 * driver.cs: Remove the hack from saturday, as well as the hack
18965 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18966 link_paths to get that bit proper.
18968 2004-05-01 Todd Berman <tberman@sevenl.net>
18970 * driver.cs: Try a LoadFrom before a Load, this checks the current
18971 path. This is currently a bug in mono that is be fixed, however, this
18972 provides a workaround for now. This will be removed when the bug
18975 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18977 * CryptoConvert.cs: Updated to latest version. Fix issue with
18978 incomplete key pairs (#57941).
18980 2004-05-01 Todd Berman <tberman@sevenl.net>
18982 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18985 2004-04-30 Jackson Harper <jackson@ximian.com>
18987 * codegen.cs: Open keys readonly.
18989 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18991 * typemanager.cs: don't report cyclic struct layout when a struct
18992 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18993 which has 2 Pango.Rectangle fields.
18995 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18997 * expression.cs: Handle IntPtr comparisons with IL code
18998 rather than a method call.
19000 2004-04-29 Martin Baulig <martin@ximian.com>
19002 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
19003 the list of PropertyInfo's in class hierarchy and find the
19004 accessor. Fixes #56013.
19006 2004-04-29 Martin Baulig <martin@ximian.com>
19008 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
19010 2004-04-29 Martin Baulig <martin@ximian.com>
19012 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19014 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
19016 2004-04-29 Martin Baulig <martin@ximian.com>
19018 * class.cs (ConstructorInitializer.Resolve): Check whether the
19019 parent .ctor is accessible. Fixes #52146.
19021 2004-04-29 Martin Baulig <martin@ximian.com>
19023 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19025 * statement.cs (Using.EmitLocalVariableDecls): Use
19026 TypeManager.idisposable_type, not typeof (IDisposable).
19027 (Foreach.EmitCollectionForeach): Added support for valuetypes.
19029 2004-04-29 Martin Baulig <martin@ximian.com>
19031 * class.cs (Event.Define): Don't emit the field and don't set
19032 RTSpecialName and SpecialName for events on interfaces. Fixes
19035 2004-04-29 Raja R Harinath <rharinath@novell.com>
19037 Refactor Attribute.ApplyAttributes.
19038 * attribute.cs (Attributable): New base class for objects that can
19039 have Attributes applied on them.
19040 (Attribute): Make AttributeUsage fields public.
19041 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
19042 (Attribute.IsInternalCall): New property.
19043 (Attribute.UsageAttr): Convert to a public read-only property.
19044 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
19045 (Attribute.ResolveType, Attribute.Resolve)
19046 (Attribute.ScanForIndexerName): Update to reflect changes.
19047 (Attribute.CheckAttributeTarget): Re-format.
19048 (Attribute.ApplyAttributes): Refactor, to various
19049 Attributable.ApplyAttributeBuilder methods.
19050 * decl.cs (MemberCore): Make Attributable.
19051 * class.cs (Accessor): Make Attributable.
19052 (MethodData.ApplyAttributes): Use proper attribute types, not
19054 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
19055 (TypeContainer.ApplyAttributeBuilder)
19056 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
19057 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
19058 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
19059 (Operator.ApplyAttributeBuilder): New factored-out methods.
19060 * const.cs (Const.ApplyAttributeBuilder): Likewise.
19061 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
19062 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
19063 * parameter.cs (ParameterBase): New Attributable base class
19064 that can also represent Return types.
19065 (Parameter): Update to the changes.
19067 2004-04-29 Jackson Harper <jackson@ximian.com>
19069 * driver.cs: Prefer the corlib system version when looking for
19070 assemblies in the GAC. This is still a hack, but its a better hack
19073 2004-04-29 Marek Safar <marek.safar@seznam.cz>
19075 * decl.cs, enum.cs: Improved error 3005 reporting.
19077 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
19078 (related_symbols): New private member for list of symbols
19079 related to reported error/warning.
19081 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
19083 2004-04-29 Martin Baulig <martin@ximian.com>
19085 * ecore.cs (Expression.Constantify): If we're an enum and
19086 TypeManager.TypeToCoreType() doesn't give us another type, use
19087 t.UnderlyingSystemType. Fixes #56178.
19089 2004-04-29 Martin Baulig <martin@ximian.com>
19091 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
19092 interfaces and for each interface, only add members directly
19093 declared in that interface. Fixes #53255.
19095 2004-04-28 Martin Baulig <martin@ximian.com>
19097 * expression.cs (ConditionalLogicalOperator): Use a temporary
19098 variable for `left' to avoid that we evaluate it more than once;
19101 2004-04-28 Martin Baulig <martin@ximian.com>
19103 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
19106 2004-04-28 Martin Baulig <martin@ximian.com>
19108 * statement.cs (LocalInfo.Resolve): Check whether the type is not
19111 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
19112 whether the type is not void (CS1547).
19114 2004-04-28 Martin Baulig <martin@ximian.com>
19116 * expression.cs (Unary.DoResolveLValue): Override this and report
19117 CS0131 for anything but Operator.Indirection.
19119 2004-04-28 Martin Baulig <martin@ximian.com>
19121 Committing a patch from Ben Maurer; see bug #50820.
19123 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19126 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19129 2004-04-28 Martin Baulig <martin@ximian.com>
19131 Committing a patch from Ben Maurer; see bug #50820.
19133 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19136 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19139 2004-04-28 Martin Baulig <martin@ximian.com>
19141 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19142 (Block.AddLabel): Call DoLookupLabel() to only search in the
19145 2004-04-28 Martin Baulig <martin@ximian.com>
19147 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19148 comparing StringConstants and NullLiterals in Equality and Inequality.
19150 2004-04-28 Jackson Harper <jackson@ximian.com>
19152 * driver.cs: Attempt to load referenced assemblies from the
19153 GAC. This is the quick and dirty version of this method that
19154 doesnt take into account versions and just takes the first
19155 canidate found. Will be good enough for now as we will not have more
19156 then one version installed into the GAC until I update this method.
19158 2004-04-28 Martin Baulig <martin@ximian.com>
19160 * typemanager.cs (TypeManager.CheckStructCycles): New public
19161 static method to check for cycles in the struct layout.
19163 * rootcontext.cs (RootContext.PopulateTypes): Call
19164 TypeManager.CheckStructCycles() for each TypeContainer.
19165 [Note: We only need to visit each type once.]
19167 2004-04-28 Martin Baulig <martin@ximian.com>
19169 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19171 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19172 success and added `out object value'. Use a `bool resolved' field
19173 to check whether we've already been called rather than
19174 `ConstantValue != null' since this breaks for NullLiterals.
19176 2004-04-28 Raja R Harinath <rharinath@novell.com>
19178 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19179 setting of this flag, since the 'set' method may be non-public.
19181 2004-04-28 Raja R Harinath <rharinath@novell.com>
19183 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19184 check on current_vector.Block.
19186 2004-04-27 Martin Baulig <martin@ximian.com>
19188 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19189 a field initializer. Fixes #56459.
19191 2004-04-27 Martin Baulig <martin@ximian.com>
19193 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19194 we're not attempting to use an indexer. Fixes #52154.
19196 2004-04-27 Martin Baulig <martin@ximian.com>
19198 * statement.cs (Return): Don't create a return label if we don't
19199 need it; reverts my change from January 20th. Thanks to Ben
19202 2004-04-27 Martin Baulig <martin@ximian.com>
19204 According to the spec, `goto' can only leave a nested scope, but
19207 * statement.cs (Block.LookupLabel): Only lookup in the current
19208 block, don't recurse into parent or child blocks.
19209 (Block.AddLabel): Check in parent and child blocks, report
19210 CS0140/CS0158 if we find a duplicate.
19211 (Block): Removed this indexer for label lookups.
19212 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19213 this already does the error reporting for us.
19216 (FlowBranching.UsageVector.Block): New public variable; may be null.
19217 (FlowBranching.CreateSibling): Added `Block' argument.
19218 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19219 label for the target of a `goto' and check whether we're not
19220 leaving a `finally'.
19222 2004-04-27 Martin Baulig <martin@ximian.com>
19224 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19225 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19228 2004-04-27 Martin Baulig <martin@ximian.com>
19230 * statement.cs (Block.AddLabel): Also check for implicit blocks
19231 and added a CS0158 check.
19233 2004-04-27 Martin Baulig <martin@ximian.com>
19235 * flowanalysis.cs (FlowBranchingLoop): New class.
19236 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19237 UsageVector's instead of an ArrayList.
19238 (FlowBranching.Label): Likewise.
19239 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19240 (FlowBranching.AddBreakVector): New method.
19242 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19244 * attribute.cs: Small regression fix: only convert the type if we
19245 the type is different, fixes System.Drawing build.
19247 2004-04-27 Martin Baulig <martin@ximian.com>
19249 * attribute.cs (Attribute.Resolve): If we have a constant value
19250 for a named field or property, implicity convert it to the correct
19253 2004-04-27 Raja R Harinath <rharinath@novell.com>
19255 * statement.cs (Block.Block): Implicit blocks share
19256 'child_variable_names' fields with parent blocks.
19257 (Block.AddChildVariableNames): Remove.
19258 (Block.AddVariable): Mark variable as "used by a child block" in
19259 every surrounding block.
19260 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19261 been used in a child block, complain about violation of "Invariant
19262 meaning in blocks" rule.
19263 * cs-parser.jay (declare_local_variables): Don't use
19264 AddChildVariableNames.
19265 (foreach_statement): Don't create an implicit block: 'foreach'
19266 introduces a scope.
19268 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19270 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19271 converting from 0L to ulong. Fixes 57522.
19273 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19275 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19276 derived class hides via 'new' keyword field from base class (test-242.cs).
19277 TODO: Handle this in the more general way.
19279 * class.cs (CheckBase): Ditto.
19281 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19283 * decl.cs (caching_flags): New member for storing cached values
19285 (MemberCore.Flags): New enum where bit flags for caching_flags
19287 (MemberCore.cls_compliance): Moved to caching_flags.
19288 (DeclSpace.Created): Moved to caching_flags.
19290 * class.cs: Use caching_flags instead of DeclSpace.Created
19292 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19294 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19295 if we are only a derived class, not a nested class.
19297 * typemanager.cs: Same as above, but do this at the MemberLookup
19298 level (used by field and methods, properties are handled in
19299 PropertyExpr). Allow for the qualified access if we are a nested
19302 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19304 * class.cs: Refactoring.
19305 (IMethodData): New inteface; Holds links to parent members
19306 to avoid member duplication (reduced memory allocation).
19307 (Method): Implemented IMethodData interface.
19308 (PropertyBase): New inner classes for get/set methods.
19309 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19310 (Event): New inner classes for add/remove methods.
19311 (Event.DelegateMethod): Implemented IMethodData interface.
19313 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19314 EmitContext (related to class.cs refactoring).
19316 2004-04-21 Raja R Harinath <rharinath@novell.com>
19318 * delegate.cs (Delegate.VerifyApplicability): If the number of
19319 arguments are the same as the number of parameters, first try to
19320 verify applicability ignoring any 'params' modifier on the last
19324 2004-04-16 Raja R Harinath <rharinath@novell.com>
19326 * class.cs (TypeContainer.AddIndexer): Use
19327 'ExplicitInterfaceName' to determine if interface name was
19328 explicitly specified. 'InterfaceType' is not initialized at this time.
19329 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19330 Indexers array is already in the required order. Initialize
19331 'IndexerName' only if there are normal indexers.
19332 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19333 (TypeContainer.Emit): Emit DefaultMember attribute only if
19334 IndexerName is initialized.
19337 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19339 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19342 2004-04-15 Raja R Harinath <rharinath@novell.com>
19344 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19348 * attribute.cs (Attribute.Resolve): Check for duplicate named
19352 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19354 * iterators.cs (MarkYield): track whether we are in an exception,
19355 and generate code accordingly. Use a temporary value to store the
19356 result for our state.
19358 I had ignored a bit the interaction of try/catch with iterators
19359 since their behavior was not entirely obvious, but now it is
19360 possible to verify that our behavior is the same as MS .NET 2.0
19364 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19366 * iterators.cs: Avoid creating temporaries if there is no work to
19369 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19370 Enumerations, use TypeManager.EnumToUnderlying and call
19373 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19376 (This.Emit): Use EmitContext.EmitThis to emit our
19379 (This.EmitAssign): Ditto.
19381 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19382 codepaths, we will move all the functionality into
19385 (FieldExpr.EmitAssign): Ditto.
19387 This fixes several hidden bugs that I uncovered while doing a code
19388 review of this today.
19390 * codegen.cs (EmitThis): reworked so the semantics are more clear
19391 and also support value types "this" instances.
19393 * iterators.cs: Changed so that for iterators in value types, we
19394 do not pass the value type as a parameter.
19396 Initialization of the enumerator helpers is now done in the caller
19397 instead of passing the parameters to the constructors and having
19398 the constructor set the fields.
19400 The fields have now `assembly' visibility instead of private.
19402 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19404 * expression.cs (Argument.Resolve): Check if fields passed as ref
19405 or out are contained in a MarshalByRefObject.
19407 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19408 another compiler type.
19410 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19412 * class.cs (Indexer.Define): use the new name checking method.
19413 Also, return false on an error.
19414 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19415 (is_identifier_[start/part]_character): make static.
19417 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19419 * expression.cs (Binary.ResolveOperator): Do no append strings
19420 twice: since we can be invoked more than once (array evaluation)
19421 on the same concatenation, take care of this here. Based on a fix
19422 from Ben (bug #56454)
19424 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19426 * codegen.cs: Fix another case where CS1548 must be reported (when
19427 delay-sign isn't specified and no private is available #56564). Fix
19428 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19429 error when MCS is used on the MS runtime and we need to delay-sign
19430 (which seems unsupported by AssemblyBuilder - see #56621).
19432 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19434 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19435 (TypeManager.ComputeNamespaces): Faster implementation for
19438 * compiler.csproj: Updated AssemblyName to mcs.
19440 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19442 * rootcontext.cs: Add new types to the boot resolution.
19444 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19445 MulticastDelegate is not allowed.
19447 * typemanager.cs: Add new types to lookup: System.TypedReference
19450 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19451 check for TypedReference or ArgIterator, they are not allowed.
19453 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19454 makes us properly catch 1510 in some conditions (see bug 56016 for
19457 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19459 * CryptoConvert.cs: update from corlib version
19462 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19464 * class.cs (Indexer.Define): Check indexername declaration
19466 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19468 * attribute.cs (IsClsCompliant): Fixed problem with handling
19469 all three states (compliant, not-compliant, undetected).
19471 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19473 * attribute.cs (Attribute): Location is now public.
19474 (Resolve): Store resolved arguments (pos_values) in attribute class.
19475 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19476 (GetClsCompliantAttributeValue): New method that gets
19477 CLSCompliantAttribute value.
19478 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19479 if exists else null.
19480 (AttributeTester): New class for CLS-Compliant verification routines.
19482 * class.cs (Emit): Add CLS-Compliant verification.
19483 (Method.GetSignatureForError): Implemented.
19484 (Constructor.GetSignatureForError): Implemented
19485 (Constructor.HasCompliantArgs): Returns if constructor has
19486 CLS-Compliant arguments.
19487 (Constructor.Emit): Override.
19488 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19489 is needed to test only parameters.
19490 (FieldBase.GetSignatureForError): Implemented.
19491 (TypeContainer): New member for storing base interfaces.
19492 (TypeContainer.FindMembers): Search in base interfaces too.
19494 * codegen.cs (GetClsComplianceAttribute): New method that gets
19495 assembly or module CLSCompliantAttribute value.
19496 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19498 (ModuleClass.Emit): Add error 3012 test.
19500 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19502 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19503 state for all decl types.
19504 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19505 if CLS-Compliant tests are required.
19506 (IsClsCompliaceRequired): New method. Analyze whether code
19507 must be CLS-Compliant.
19508 (IsExposedFromAssembly): New method. Returns true when MemberCore
19509 is exposed from assembly.
19510 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19511 value or gets cached value.
19512 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19513 is explicitly marked with CLSCompliantAttribute.
19514 (IsIdentifierClsCompliant): New abstract method. This method is
19515 used to testing error 3005.
19516 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19517 for identifier and parameters CLS-Compliant testing.
19518 (VerifyClsCompliance): New method. The main virtual method for
19519 CLS-Compliant verifications.
19520 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19521 null. I don't know why is null (too many public members !).
19522 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19523 and get value of first CLSCompliantAttribute that found.
19525 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19526 (VerifyClsCompliance): Override and add extra tests.
19528 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19529 clscheck- disable CLS-Compliant verification event if assembly is has
19530 CLSCompliantAttribute(true).
19532 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19533 ApllyAttribute is now called in emit section as in the other cases.
19534 Possible future Emit integration.
19535 (IsIdentifierClsCompliant): New override.
19536 (VerifyClsCompliance): New override.
19537 (GetEnumeratorName): Returns full enum name.
19539 * parameter.cs (GetSignatureForError): Implemented.
19541 * report.cs (WarningData): New struct for Warning message information.
19542 (LocationOfPreviousError): New method.
19543 (Warning): New method. Reports warning based on the warning table.
19544 (Error_T): New method. Reports error based on the error table.
19546 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19547 verifications are done here.
19549 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19551 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19552 CLSCompliantAttribute.
19553 (all_imported_types): New member holds all imported types from other
19555 (LoadAllImportedTypes): New method fills static table with exported types
19556 from all referenced assemblies.
19557 (Modules): New property returns all assembly modules.
19559 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19561 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19562 throwing a parser error.
19564 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19565 which removes the hardcoded get_/set_ prefixes for properties, as
19566 IL allows for the properties to be named something else.
19570 * expression.cs: Do not override operand before we know if it is
19571 non-null. Fix 56207
19573 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19575 * typemanager.cs: support for pinned variables.
19577 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19579 * decl.cs, typemanager.cs: Avoid using an arraylist
19580 as a buffer if there is only one result set.
19582 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19584 * expression.cs: Make sure you cant call a static method
19585 with an instance expression, bug #56174.
19587 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19589 * class.cs (IsDuplicateImplementation): Improve error reporting to
19590 flag 663 (method only differs in parameter modifier).
19592 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19593 in preprocessor directives.
19595 * location.cs (LookupFile): Allow for the empty path.
19597 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19598 better approach for some of that patch, but its failing with the
19599 CharSet enumeration. For now try/catch will do.
19601 * typemanager.cs: Do not crash if a struct does not have fields.
19604 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19606 * expression.cs: cs0213, cant fix a fixed expression.
19609 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19611 * cs-parser.jay: detect invalid embeded statements gracefully.
19614 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19616 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19619 the invocation type may not be a subclass of the tye of the item/
19620 The type of the item must be a subclass of the invocation item.
19625 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19627 * attribute.cs: Added methods to get a string and a bool from an
19628 attribute. Required to information from AssemblyKeyFileAttribute,
19629 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19630 * codegen.cs: Modified AssemblyName creation to include support for
19631 strongnames. Catch additional exceptions to report them as CS1548.
19632 * compiler.csproj: Updated include CryptoConvert.cs.
19633 * compiler.csproj.user: Removed file - user specific configuration.
19634 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19635 Mono.Security assembly. The original class is maintained and tested in
19636 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19637 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19638 like CSC 8.0 (C# v2) supports.
19639 * Makefile: Added CryptoConvert.cs to mcs sources.
19640 * rootcontext.cs: Added new options for strongnames.
19642 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19644 * driver.cs: For --expect-error, report error code `2'
19645 if the program compiled with no errors, error code `1' if
19646 it compiled with an error other than the one expected.
19648 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19650 * compiler.csproj: Updated for Visual Studio .NET 2003.
19651 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19652 * compiler.sln: Updated for Visual Studio .NET 2003.
19654 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19656 * expression.cs: Fix bug #47234. We basically need to apply the
19657 rule that we prefer the conversion of null to a reference type
19658 when faced with a conversion to 'object' (csc behaviour).
19660 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19662 * statement.cs: Shorter form for foreach, eliminates
19663 a local variable. r=Martin.
19665 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19667 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19668 checks if we can use brtrue/brfalse to test for 0.
19669 * expression.cs: use the above in the test for using brtrue/brfalse.
19670 cleanup code a bit.
19672 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19674 * expression.cs: Rewrite string concat stuff. Benefits:
19676 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19677 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19678 rather than a concat chain.
19680 * typemanager.cs: Add lookups for more concat overloads.
19682 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19684 * expression.cs: Emit shorter il code for array init.
19701 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19703 * statement.cs: Before, two switch blocks would be merged if the
19704 total size of the blocks (end_item - begin_item + 1) was less than
19705 two times the combined sizes of the blocks.
19707 Now, it will only merge if after the merge at least half of the
19712 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19714 * class.cs : csc build fix for GetMethods(). See bug #52503.
19716 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19718 * expression.cs: Make sure fp comparisons work with NaN.
19719 This fixes bug #54303. Mig approved this patch a long
19720 time ago, but we were not able to test b/c the runtime
19723 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19725 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19727 2004-03-19 Martin Baulig <martin@ximian.com>
19729 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19730 error here and not in our caller.
19732 2004-03-19 Martin Baulig <martin@ximian.com>
19734 * interface.cs: Completely killed this file.
19735 (Interface): We're now a TypeContainer and live in class.cs.
19737 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19738 argument; we're now also called for interfaces.
19739 (TypeContainer.DefineMembers): Allow this method being called
19741 (TypeContainer.GetMethods): New public method; formerly known as
19742 Interface.GetMethod(). This is used by PendingImplementation.
19743 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19744 it's now private and non-static.
19745 (Interface): Moved this here; it's now implemented similar to
19747 (Method, Property, Event, Indexer): Added `bool is_interface'
19748 argument to their .ctor's.
19749 (MemberBase.IsInterface): New public field.
19751 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19752 instances instead of InterfaceMethod, InterfaceProperty, etc.
19753 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19754 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19756 2004-03-19 Martin Baulig <martin@ximian.com>
19758 * class.cs (MethodCore.IsDuplicateImplementation): New private
19759 method which does the CS0111 checking.
19760 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19761 Use IsDuplicateImplementation().
19763 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19765 * decl.cs (FindMemberToOverride): New method to find the correct
19766 method or property to override in the base class.
19768 - Make Method/Property use the above method to find the
19769 version in the base class.
19770 - Remove the InheritableMemberSignatureCompare as it is now
19773 This patch makes large code bases much faster to compile, as it is
19774 O(n) rather than O(n^2) to do this validation.
19776 Also, it fixes bug 52458 which is that nested classes are not
19777 taken into account when finding the base class member.
19779 Reviewed/Approved by Martin.
19781 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19783 * interface.cs: In all interface classes removed redundant
19784 member initialization.
19786 2004-03-16 Martin Baulig <martin@ximian.com>
19788 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19790 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19792 * decl.cs (DefineTypeAndParents): New helper method to define a
19793 type's containers before the type itself is defined; This is a
19794 bug exposed by the recent changes to Windows.Forms when an
19795 implemented interface was defined inside a class that had not been
19798 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19800 (Check): Loop correctly to report errors modifiers
19801 (UNSAFE was not in the loop, since it was the same as TOP).
19803 * interface.cs: Every interface member now takes a ModFlags,
19804 instead of a "is_new" bool, which we set on the base MemberCore.
19806 Every place where we called "UnsafeOk" in the interface, now we
19807 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19808 the unsafe settings from the member declaration instead of the
19809 container interface.
19811 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19813 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19814 `set_indexer_name' to the pending bits (one per type).
19816 We fixed a bug today that was picking the wrong method to
19817 override, since for properties the existing InterfaceMethod code
19818 basically ignored the method name. Now we make sure that the
19819 method name is one of the valid indexer names.
19821 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19823 * support.cs (SeekableStreamReader): Keep track of stream byte
19824 positions and don't mix them with character offsets to the buffer.
19826 Patch from Gustavo Giráldez
19828 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19830 * interface.cs (InterfaceSetGetBase): Removed double member
19831 initialization, base class does it as well.
19833 2004-03-13 Martin Baulig <martin@ximian.com>
19835 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19836 when compiling corlib.
19838 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19840 * convert.cs (ExplicitConversion): We were reporting an error on
19841 certain conversions (object_type source to a value type, when the
19842 expression was `null') before we had a chance to pass it through
19843 the user defined conversions.
19845 * driver.cs: Replace / and \ in resource specifications to dots.
19848 * class.cs: Add check for duplicate operators. Fixes 52477
19850 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19852 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19853 that are in the middle of the statements, not only at the end.
19856 * class.cs (TypeContainer.AddField): No longer set the
19857 `HaveStaticConstructor' flag, now we call it
19858 `UserDefineStaticConstructor' to diferentiate the slightly
19859 semantic difference.
19861 The situation is that we were not adding BeforeFieldInit (from
19862 Modifiers.TypeAttr) to classes that could have it.
19863 BeforeFieldInit should be set to classes that have no static
19868 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19870 And most importantly Zoltan's comment:
19872 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19874 "I think beforefieldinit means 'it's ok to initialize the type sometime
19875 before its static fields are used', i.e. initialization does not need
19876 to be triggered by the first access to the type. Setting this flag
19877 helps the JIT to compile better code, since it can run the static
19878 constructor at JIT time, and does not need to generate code to call it
19879 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19880 this flag for lots of classes like String.
19882 csc sets this flag if the type does not have an explicit static
19883 constructor. The reasoning seems to be that if there are only static
19884 initalizers for a type, and no static constructor, then the programmer
19885 does not care when this initialization happens, so beforefieldinit
19888 This bug prevents the AOT compiler from being usable, since it
19889 generates so many calls to mono_runtime_class_init that the AOT code
19890 is much slower than the JITted code. The JITted code is faster,
19891 because it does not generate these calls if the vtable is type is
19892 already initialized, which is true in the majority of cases. But the
19893 AOT compiler can't do this."
19895 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19897 * class.cs (MethodData.Emit): Refactor the code so symbolic
19898 information is generated for destructors; For some reasons we
19899 were taking a code path that did not generate symbolic information
19902 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19904 * class.cs: Create a Constructor.CheckBase method that
19905 takes care of all validation type code. The method
19906 contains some code that was moved from Define.
19908 It also includes new code that checks for duplicate ctors.
19909 This fixes bug #55148.
19911 2004-03-09 Joshua Tauberer <tauberer@for.net>
19913 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19914 a { ... }-style array creation invokes EmitStaticInitializers
19915 which is not good for reference-type arrays. String, decimal
19916 and now null constants (NullCast) are not counted toward
19917 static initializers.
19919 2004-03-05 Martin Baulig <martin@ximian.com>
19921 * location.cs (SourceFile.HasLineDirective): New public field;
19922 specifies whether the file contains or is referenced by a "#line"
19924 (Location.DefineSymbolDocuments): Ignore source files which
19925 either contain or are referenced by a "#line" directive.
19927 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19929 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19930 direct access to our parent, so check the method inline there.
19932 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19934 * expression.cs (Invocation.EmitCall): Miguel's last commit
19935 caused a regression. If you had:
19940 In Foo the implict this would be null.
19942 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19944 * expression.cs (Invocation.EmitCall): If the method is not
19945 virtual, do not emit a CallVirt to it, use Call.
19947 * typemanager.cs (GetFullNameSignature): Improve the method to
19948 cope with ".ctor" and replace it with the type name.
19950 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19951 as an argument the ConstructorBuilder where it is being defined,
19952 to catch the recursive constructor invocations.
19954 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19956 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19957 routines to check if a type is an enumerable/enumerator allow
19958 classes that implement the IEnumerable or IEnumerator interfaces.
19960 * class.cs (Property, Operator): Implement IIteratorContainer, and
19961 implement SetYields.
19963 (Property.Define): Do the block swapping for get_methods in the
19964 context of iterators. We need to check if Properties also
19965 include indexers or not.
19967 (Operator): Assign the Block before invoking the
19968 OperatorMethod.Define, so we can trigger the Iterator code
19971 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19972 Property and Operator classes are not created when we parse the
19973 declarator but until we have the block completed, so we use a
19974 singleton SimpleIteratorContainer.Simple to flag whether the
19975 SetYields has been invoked.
19977 We propagate this setting then to the Property or the Operator to
19978 allow the `yield' to function.
19980 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19982 * codegen.cs: Implemented attribute support for modules.
19983 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19984 Assembly/Module functionality.
19986 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19987 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19988 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19990 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19992 * interface.cs (FindMembers): The operation is performed on all base
19993 interfaces and not only on the first. It is required for future CLS Compliance patch.
19995 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19997 * statement.cs, codegen.cs:
19998 This patch deals with patterns such as:
20000 public class List : IEnumerable {
20002 public MyEnumerator GetEnumerator () {
20003 return new MyEnumerator(this);
20006 IEnumerator IEnumerable.GetEnumerator () {
20010 public struct MyEnumerator : IEnumerator {
20015 Before, there were a few things we did wrong:
20016 1) we would emit callvirt on a struct, which is illegal
20017 2) we emited ldarg when we needed to emit ldarga
20018 3) we would mistakenly call the interface methods on an enumerator
20019 type that derived from IEnumerator and was in another assembly. For example:
20021 public class MyEnumerator : IEnumerator
20023 Would have the interface methods called, even if there were public impls of the
20024 method. In a struct, this lead to invalid IL code.
20026 2004-02-11 Marek Safar <marek.safar@seznam.cz>
20028 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
20031 * delegate.cs (Define): Fixed crash when delegate type is undefined.
20033 2004-02-11 Miguel de Icaza <miguel@ximian.com>
20035 * cs-parser.jay: Fix small regression: we were not testing V2
20036 compiler features correctly.
20038 * interface.cs: If the emit context is null, then create one
20040 2004-02-09 Marek Safar <marek.safar@seznam.cz>
20042 * decl.cs (GetSignatureForError): New virtual method to get full name
20043 for error messages.
20045 * attribute.cs (IAttributeSupport): New interface for attribute setting.
20046 Now it is possible to rewrite ApplyAttributes method to be less if/else.
20048 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
20049 Duplicated members and code in these classes has been removed.
20050 Better encapsulation in these classes.
20052 2004-02-07 Miguel de Icaza <miguel@ximian.com>
20054 * assign.cs (Assign.DoResolve): When dealing with compound
20055 assignments, there is a new rule in ECMA C# 2.4 (might have been
20056 there before, but it is documented here) that states that in:
20060 If b is of type int, and the `op' is a shift-operator, then the
20061 above is evaluated as:
20065 * expression.cs (Binary.ResolveOperator): Instead of testing for
20066 int/uint/long/ulong, try to implicitly convert to any of those
20067 types and use that in pointer arithmetic.
20069 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
20070 method to print information for from the type, not from the
20071 null-method we were given.
20073 2004-02-01 Duncan Mak <duncan@ximian.com>
20075 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
20076 parsing for cmd, fixes bug #53694.
20078 2004-02-04 Marek Safar <marek.safar@seznam.cz>
20080 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
20081 in the member name duplication tests. Property and operator name duplication
20082 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
20084 2004-02-03 Marek Safar <marek.safar@seznam.cz>
20086 * interface.cs (PopulateMethod): Fixed crash when interface method
20087 returns not existing type (error test cs0246-3.cs).
20089 2004-02-02 Ravi Pratap M <ravi@ximian.com>
20091 * cs-parser.jay (interface_accessors): Re-write actions to also
20092 store attributes attached to get and set methods. Fix spelling
20095 (inteface_property_declaration): Modify accordingly.
20097 (InterfaceAccessorInfo): New helper class to store information to pass
20098 around between rules that use interface_accessors.
20100 * interface.cs (Emit): Apply attributes on the get and set
20101 accessors of properties and indexers too.
20103 * attribute.cs (ApplyAttributes): Modify accordingly to use the
20104 right MethodBuilder when applying attributes to the get and set accessors.
20106 2004-01-31 Miguel de Icaza <miguel@ximian.com>
20108 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
20110 2004-01-26 Miguel de Icaza <miguel@ximian.com>
20112 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
20114 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20116 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20117 changes that treat `yield' specially when present before `break'
20118 or `return' tokens.
20120 * cs-tokenizer.cs: yield is no longer a keyword.
20122 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20124 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20125 setting for default constructors.
20126 For default constructors are almost every time set wrong Modifier. The
20127 generated IL code has been alright. But inside mcs this values was
20128 wrong and this was reason why several of my CLS Compliance tests
20131 2004-01-22 Martin Baulig <martin@ximian.com>
20133 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20134 not a QualifiedIdentifier. This is what `type_name_expression'
20135 was previously doing.
20136 (type_name_expression): Removed; the code is now in
20137 `namespace_or_type_name'.
20138 (qualified_identifier): Removed, use `namespace_or_type_name'
20140 (QualifiedIdentifier): Removed this class.
20142 2004-01-22 Martin Baulig <martin@ximian.com>
20144 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20145 not a string as alias name.
20147 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20149 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20150 #52730 bug, and instead compute correctly the need to use a
20151 temporary variable when requesting an address based on the
20152 static/instace modified of the field and the constructor.
20154 2004-01-21 Martin Baulig <martin@ximian.com>
20156 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20157 class and namespace before looking up aliases. Fixes #52517.
20159 2004-01-21 Martin Baulig <martin@ximian.com>
20161 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20162 assinged in a 'try'; fixes exception4.cs.
20164 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20165 * class.cs : Implemented parameter-less constructor for TypeContainer
20167 * decl.cs: Attributes are now stored here. New property OptAttributes
20169 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20171 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20173 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20175 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20176 (CSharpSignature): New method for indexer and property signature.
20178 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20180 * pending.cs (IsVirtualFilter): Faster implementation.
20182 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20184 * typemanager.cs: Avoid inclusion of same assembly more than once.
20186 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20188 * cs-parser.jay: Fixed problem where the last assembly attribute
20189 has been applied also to following declaration (class, struct, etc.)
20191 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20193 * class.cs: Added error CS0538, CS0539 reporting.
20194 Fixed crash on Microsoft runtime when field type is void.
20196 * cs-parser.jay: Added error CS0537 reporting.
20198 * pending.cs: Added error CS0535 reporting.
20199 Improved error report for errors CS0536, CS0534.
20201 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20203 Merge a few bits from the Anonymous Method MCS tree.
20205 * statement.cs (ToplevelBlock): New class for toplevel methods,
20206 will hold anonymous methods, lifted variables.
20208 * cs-parser.jay: Create toplevel blocks for delegates and for
20209 regular blocks of code.
20211 2004-01-20 Martin Baulig <martin@ximian.com>
20213 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20214 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20215 and `NeedExplicitReturn'; added `IsLastStatement'.
20216 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20217 have a `ReturnLabel' or we're not unreachable.
20219 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20220 child's reachability; don't just override ours with it. Fixes
20221 #58058 (lluis's example).
20222 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20223 InFinally(), InLoop(), InSwitch() and
20224 BreakCrossesTryCatchBoundary() methods.
20226 * statement.cs (Return): Do all error checking in Resolve().
20227 Unless we are the last statement in a top-level block, always
20228 create a return label and jump to it.
20229 (Break, Continue): Do all error checking in Resolve(); also make
20230 sure we aren't leaving a `finally'.
20231 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20232 statement in a top-level block.
20233 (Block.Flags): Added `IsDestructor'.
20234 (Block.IsDestructor): New public property.
20236 2004-01-20 Martin Baulig <martin@ximian.com>
20238 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20240 2004-01-20 Martin Baulig <martin@ximian.com>
20242 * statement.cs (Statement.ResolveUnreachable): New public method.
20243 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20244 (Block.Resolve): Resolve unreachable statements.
20246 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20248 * expression.cs: We need to fix the case where we do
20249 not have a temp variable here.
20251 * assign.cs: Only expression compound assignments need
20252 temporary variables.
20254 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20256 * flowanalysis.cs: Reduce memory allocation in a few ways:
20257 - A block with no variables should not allocate a bit
20259 - A method with no out parameters does not need any tracking
20260 for assignment of the parameters, so we need not allocate
20263 public readonly Type[] VariableTypes;
20264 public readonly string[] VariableNames;
20265 Are redundant. The data is already stored in the variable
20266 map, so we need not allocate another array for it.
20267 - We need to add alot of checks for if (params | locals) == null
20268 due to the first two changes.
20270 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20272 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20273 implement IMemoryLocation, we store a copy on a local variable and
20274 take the address of it. Patch from Benjamin Jemlich
20276 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20277 to use a special "type_name_expression" rule which reduces the
20278 number of "QualifiedIdentifier" classes created, and instead
20279 directly creates MemberAccess expressions.
20281 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20283 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20284 that fixes #52853. Null literal assignment to ValueType
20286 * class.cs (MethodData.Emit): Instead of checking the name of the
20287 method to determine if its a destructor, create a new derived
20288 class from Method called Destructor, and test for that.
20290 * cs-parser.jay: Create a Destructor object instead of a Method.
20292 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20296 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20298 * expression.cs (Binary.ResolveOperator): Perform an implicit
20299 conversion from MethodGroups to their delegate types on the
20300 Addition operation.
20302 * delegate.cs: Introduce a new class DelegateCreation that is the
20303 base class for `NewDelegate' and `ImplicitDelegateCreation',
20304 factor some code in here.
20306 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20307 conversion from MethodGroups to compatible delegate types.
20309 * ecore.cs (Expression.Resolve): Do not flag error 654
20310 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20311 we allow conversions from MethodGroups to delegate types now.
20313 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20314 assignments in v2 either.
20316 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20318 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20319 static read-only fields in ctors.
20321 Applied patch from Benjamin Jemlich
20323 * expression.cs (UnaryMutator): Avoid leaking local variables.
20325 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20327 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20328 here to return true, as they can be used like this:
20330 (XXX) int.MEMBER ()
20332 Fixed 49836 and all the other dups
20334 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20336 * driver.cs: Implement /win32res and /win32icon.
20338 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20340 * cs-parser.jay: Add a rule to improve error handling for the
20341 common mistake of placing modifiers after the type.
20343 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20345 * cs-parser.jay (interface_event_declaration): Catch
20346 initialization of events on interfaces, and report cs0068
20348 * cs-parser.jay (interface_event_declaration): Catch
20349 initialization of events.
20351 * ecore.cs: Better report missing constructors.
20353 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20354 the error reporting done in the wrong place. Fix.
20356 * expression.cs (Binary.ResolveOperator): Catch the
20357 operator + (E x, E y) error earlier, and later allow for implicit
20358 conversions in operator +/- (E e, U x) from U to the underlying
20361 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20362 52596, if the container class is abstract, the default constructor
20363 is protected otherwise its public (before, we were always public).
20365 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20368 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20369 Jemlich that fixes bug #52597, MCS was generating invalid code for
20370 idisposable structs. Thanks to Ben for following up with this
20373 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20375 * driver.cs: Allow assemblies without code to be generated, fixes
20378 2004-01-07 Nick Drochak <ndrochak@gol.com>
20380 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20382 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20384 * cs-parser.jay: Add rules to improve error reporting if fields or
20385 methods are declared at the namespace level (error 116)
20387 * Add rules to catch event add/remove
20389 2004-01-04 David Sheldon <dave-mono@earth.li>
20391 * expression.cs: Added matching ")" to error message for
20394 2004-01-03 Todd Berman <tberman@gentoo.org>
20396 * ecore.cs, attribute.cs:
20397 Applying fix from #52429.
20399 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20401 * ecore.cs, expression.cs, statement.cs:
20402 Total rewrite of how we handle branching. We
20403 now handle complex boolean expressions with fewer
20404 jumps. As well if (x == 0) no longer emits a ceq.
20406 if (x is Foo) is much faster now, because we generate
20409 Overall, we get a pretty big improvement on our benchmark
20410 tests. The code we generate is smaller and more readable.
20412 I did a full two-stage bootstrap. The patch was reviewed
20413 by Martin and Miguel.
20415 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20417 * cs-parser.jay: Make primary_expression not take a QI.
20418 we dont need this because the member_access rule covers
20419 us here. So we replace the rule with just IDENTIFIER.
20421 This has two good effects. First, we remove a s/r conflict.
20422 Second, we allocate many fewer QualifiedIdentifier objects.
20424 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20426 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20427 set the correct information via SRE. This prevents
20428 hanging on the MS runtime. Fixes #29374.
20430 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20432 * convert.cs: correctly handle conversions to value types
20433 from Enum and ValueType as unboxing conversions.
20435 Fixes bug #52569. Patch by Benjamin Jemlich.
20437 2004-01-02 Ravi Pratap <ravi@ximian.com>
20439 * expression.cs (BetterConversion): Prefer int -> uint
20440 over int -> ulong (csc's behaviour). This fixed bug #52046.
20442 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20444 * decl.cs (MemberCache.FindMembers): now returns a
20447 * typemanager.cs: In general, go with with ^^.
20448 (CopyNewMethods): take an IList.
20449 (RealMemberLookup): Only allocate an arraylist
20450 if we copy from two sets of methods.
20452 This change basically does two things:
20453 1) Fewer array lists allocated due to CopyNewMethods.
20454 2) the explicit cast in MemberList costed ALOT.
20456 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20458 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20459 a hashtable to avoid needless string allocations when an identifier is
20460 used more than once (the common case).
20462 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20464 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20465 is broken, it will not return anything. So, we
20466 have to use the information we have in mcs to
20469 * typemanager.cs: Add a cache for GetInterfaces,
20470 since this will now be used more often (due to ^^)
20472 (GetExplicitInterfaces) New method that gets the
20473 declared, not effective, interfaces on a type
20474 builder (eg, if you have interface IFoo, interface
20475 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20478 This patch makes MCS able to bootstrap itself on
20481 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20483 * expression.cs: Remove the Nop's that Miguel put
20486 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20488 * report.cs, codegen.cs: Give the real stack trace to
20489 the error when an exception is thrown.
20491 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20493 * decl.cs: only allocate hashtables for ifaces if
20496 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20498 * expression.cs: fix the error from cs0121-2.cs
20499 (a parent interface has two child interfaces that
20500 have a function with the same name and 0 params
20501 and the function is called through the parent).
20503 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20505 * class.cs, rootcontext.cs, typmanager.cs: do not
20508 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20510 * codegen.cs: remove stack for the ec flow branching.
20511 It is already a linked list, so no need.
20513 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20515 * Makefile: Allow custom profiler here.
20517 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20519 * typemanager.cs (LookupType):
20520 - Use a static char [], because split takes
20521 a param array for args, so it was allocating
20523 - Do not store true in a hashtable, it boxes.
20525 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20527 * flowanalysis.cs: bytify common enums.
20529 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20531 * modifiers.cs: Add a new set of flags for the
20532 flags allowed on explicit interface impls.
20533 * cs-parser.jay: catch the use of modifiers in
20534 interfaces correctly.
20535 * class.cs: catch private void IFoo.Blah ().
20537 All related to bug #50572.
20539 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20541 * decl.cs: Rewrite the consistant accessability checking.
20542 Accessability is not linear, it must be implemented in
20543 a tableish way. Fixes #49704.
20545 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20547 * expression.cs: Handle negation in a checked context.
20548 We must use subtraction from zero. Fixes #38674.
20550 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20552 * class.cs: Ignore static void main in DLLs.
20553 * rootcontext.cs: Handle the target type here,
20554 since we are have to access it from class.cs
20555 * driver.cs: account for the above.
20557 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20559 * report.cs: Give line numbers and files if available.
20561 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20563 * driver.cs: Implement /addmodule.
20565 * typemanager.cs: Change 'modules' field so it now contains Modules not
20568 2003-12-20 Martin Baulig <martin@ximian.com>
20570 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20571 (FieldBase.IsAssigned): Removed this field.
20572 (FieldBase.SetAssigned): New public method.
20573 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20575 2003-12-20 Martin Baulig <martin@ximian.com>
20577 * expression.cs (LocalVariableReference.DoResolve): Don't set
20578 `vi.Used' if we're called from DoResolveLValue().
20580 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20581 returns the usage vector it just merged into the current one -
20582 pass this one to UsageWarning().
20583 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20584 of the `EmitContext', don't call this recursively on our children.
20586 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20588 * driver.cs: Implement /target:module.
20590 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20592 * support.cs (CharArrayHashtable): New helper class.
20594 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20595 char arrays, not strings, so we can avoid creating a string in
20596 consume_identifier if the identifier is a keyword.
20598 2003-12-16 Martin Baulig <martin@ximian.com>
20600 * statement.cs (LocalInfo.Assigned): Removed this property.
20601 (LocalInfo.Flags): Removed `Assigned'.
20602 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20603 and uses flow analysis.
20604 (Block.UsageWarning): Made this method private.
20605 (Block.Resolve): Call UsageWarning() if appropriate.
20607 * expression.cs (LocalVariableReference.DoResolve): Always set
20608 LocalInfo.Used here.
20610 2003-12-13 Martin Baulig <martin@ximian.com>
20612 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20613 any value here; we're now using flow analysis to figure out
20614 whether a statement/block returns a value.
20616 2003-12-13 Martin Baulig <martin@ximian.com>
20618 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20620 (FlowBranching.MergeFinally): Don't call
20621 `branching.CheckOutParameters()' here, this is called in
20623 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20624 when adding the `finally' vector.
20626 2003-12-13 Martin Baulig <martin@ximian.com>
20629 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20630 actually work and also fix #48962.
20632 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20634 * decl.cs: Do not check System.Object for nested types,
20635 since we know it does not have any. Big bang for buck:
20638 Run 1: 8.35 seconds
20639 Run 2: 8.32 seconds
20640 corlib: 17.99 seconds
20642 Run 1: 8.17 seconds
20643 Run 2: 8.17 seconds
20644 corlib: 17.39 seconds
20646 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20648 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20649 time we are returning 0 members, so we save alot here.
20651 2003-12-11 Martin Baulig <martin@ximian.com>
20653 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20654 `MergeChild()', also just take the `FlowBranching' as argument;
20655 call Merge() on it and return the result.
20656 (FlowBranching.Merge): We don't need to do anything if we just
20659 2003-12-11 Martin Baulig <martin@ximian.com>
20661 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20662 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20663 Maurer for this idea.
20665 2003-12-11 Martin Baulig <martin@ximian.com>
20667 * flowanalysis.cs (MergeResult): This class is now gone; we now
20668 use the `UsageVector' for this. The reason for this is that if a
20669 branching just has one sibling, we don't need to "merge" them at
20670 all - that's the next step to do.
20671 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20674 2003-12-11 Martin Baulig <martin@ximian.com>
20676 Reworked flow analyis and made it more precise and bug-free. The
20677 most important change is that we're now using a special `Reachability'
20678 class instead of having "magic" meanings of `FlowReturns'. I'll
20679 do some more cleanups and optimizations and also add some more
20680 documentation this week.
20682 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20683 largely reworked this class.
20684 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20685 the new `Reachability' class instead of having "magic" values here.
20686 (FlowBranching): We're now using an instance of `Reachability'
20687 instead of having separate `Returns', `Breaks' etc. fields.
20689 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20690 based on flow analysis; ignore the return value of block.Emit ().
20692 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20694 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20695 if they are private.
20697 2003-12-09 Martin Baulig <martin@ximian.com>
20699 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20700 call them directly on the UsageVector.
20702 2003-12-09 Martin Baulig <martin@ximian.com>
20704 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20705 Changed return type from `FlowReturns' to `Reachability'.
20707 2003-12-09 Martin Baulig <martin@ximian.com>
20709 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20710 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20711 `Reachable' fields with a single `Reachability' one.
20713 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20715 * class.cs (FindMembers): Remove foreach's.
20720 Run 1: 8.74 seconds
20721 Run 2: 8.71 seconds
20724 Run 1: 8.64 seconds
20725 Run 2: 8.58 seconds
20728 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20733 This patch does a few things:
20734 1. EmptyStatement is now a singleton, so it is never reallocated.
20735 2. All blah is EmptyStatement constructs have been changed to
20736 blah == EmptyStatement.Value, which is much faster and valid
20737 now that EmptyStatement is a singleton.
20738 3. When resolving a block, rather than allocating a new array for
20739 the non-empty statements, empty statements are replaced with
20740 EmptyStatement.Value
20741 4. Some recursive functions have been made non-recursive.
20742 Mainly the performance impact is from (3), however (1) and (2) are needed for
20743 this to work. (4) does not make a big difference in normal situations, however
20744 it makes the profile look saner.
20749 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20750 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20751 Total memory allocated: 56397 KB
20754 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20755 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20756 Total memory allocated: 55666 KB
20758 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20760 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20761 than the hashtable in a hashtable version
20763 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20764 we always end up concating a string. This results in a huge perf
20765 loss, because many strings have to be tracked by the GC. In this
20766 patch, we first use a hashtable that works with two keys, so that
20767 the strings do not need to be concat'ed.
20771 Run 1: 8.74 seconds
20772 Run 2: 8.71 seconds
20775 Run 1: 8.65 seconds
20776 Run 2: 8.56 seconds
20778 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20780 * Makefile: Add a new target `do-time' that does a quick and simple
20781 profile, leaving easy to parse output.
20783 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20785 * codegen.cs (Init): Create the dynamic assembly with
20786 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20788 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20790 * support.cs: Make the PtrHashtable use only one
20791 instance of its comparer.
20793 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20795 * typemanager.cs: Fix lookup of GetNamespaces.
20797 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20799 * expression.cs: Removed redundant line.
20801 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20802 ArrayLists, use for loops with bounds.
20804 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20807 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20808 arraylists, use for loop with bounds.
20810 The above three changes give us a 0.071 second performance
20811 improvement out of 3.294 seconds down to 3.223. On my machine
20812 the above changes reduced the memory usage by 1,387 KB during
20813 compiler bootstrap.
20815 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20816 QualifiedIdentifiers. Before we created a new string through
20817 concatenation, and mostly later on, the result would be
20818 manipulated by DecomposeQI through string manipulation.
20820 This reduced the compiler memory usage for bootstrapping from
20821 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20822 compile times in 0.05 seconds.
20824 2003-11-28 Dick Porter <dick@ximian.com>
20826 * support.cs: Do string compares with the Invariant culture.
20834 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20835 the comparison is done with the Invariant culture.
20837 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20839 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20840 GetEnumerator method.
20842 (ProbeCollectionType): Iterate starting at the most specific type
20843 upwards looking for a GetEnumerator
20845 * expression.cs: Shift count can be up to 31 for int/uint and 63
20848 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20850 * statement.cs (Block.LookupLabel): Also look for the label on the
20851 children blocks. Use a hash table to keep track of visited
20854 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20855 we actually did transform the other operand, otherwise fall back
20856 to the common codepath that casts to long.
20858 * cs-tokenizer.cs: Use the same code pattern as the int case.
20859 Maybe I should do the parsing myself, and avoid depending on the
20860 Parse routines to get this done.
20862 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20864 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20865 which fixes bug 51347. This time test it.
20867 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20868 attributes for example can not tell the difference between these.
20869 The difference was only a syntax feature of the language.
20871 * attribute.cs: Apply attributes to delegates.
20873 * delegate.cs: Call the apply attributes method.
20875 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20877 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20878 comparing 0 vs Byte.MinValue, not the value
20880 (ImplicitConversionRequired): When reporting a conversion error,
20881 use error 31 to print out the constant error instead of the
20884 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20885 which fixes bug 51347.
20887 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20889 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20890 which fixes the -warnaserror command line option.
20892 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20894 * cfold.cs (DoNumericPromotions): During constant folding of
20895 additions on UIntConstant, special case intconstants with
20896 IntConstants like we do on the expression binary operator.
20898 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20900 * convert.cs (ImplicitReferenceConversion): We were missing a case
20901 (System.Enum are not value types or class types, so we need to
20902 classify them separatedly).
20904 * driver.cs: We do not support error 2007.
20906 2003-11-12 Jackson Harper <jackson@ximian.com>
20908 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20909 system directory. Also use the full file name so users can
20910 libraries names mscorlib-o-tron.dll in a non system dir.
20912 2003-11-10 Martin Baulig <martin@ximian.com>
20914 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20915 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20916 calling `ResolveType()' on them, directly assign their `Type'.
20918 2003-11-08 Martin Baulig <martin@ximian.com>
20920 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20921 return value and the `out parent' parameter.
20922 (TypeContainer.DefineType): Moved the CS0644 check into
20923 GetClassBases(). Don't pass the interface types to the
20924 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20925 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20927 * ecore.cs (TypeExpr.IsAttribute): New property.
20928 (TypeExpr.GetInterfaces): New method.
20930 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20931 TypeExpr instead of a Type.
20932 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20933 (Interface.DefineType): Don't pass the interface types to the
20934 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20935 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20937 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20938 instead of a `Type[]'.
20939 (TypeManager.RegisterBuilder): Likewise.
20940 (TypeManager.AddUserInterface): Likewise.
20941 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20942 `Type[]' and also return a `TypeExpr[]'.
20943 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20945 2003-11-08 Martin Baulig <martin@ximian.com>
20947 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20950 2003-11-08 Martin Baulig <martin@ximian.com>
20952 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20953 TypeManager.ResolveExpressionTypes().
20955 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20956 instead of an Expression.
20957 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20958 (TypeExpression): New public class; formerly known as `TypeExpr'.
20960 * expression.cs (ComposedCast): Derive from TypeExpr.
20962 * typemanager.cs (TypeManager.system_*_expr): These are now
20963 TypExpr's instead of Expression's.
20964 (TypeManager.ResolveExpressionTypes): New public static function;
20965 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20968 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20970 * expression.cs (New.DoResolve): Do not dereference value that
20971 might be a null return.
20973 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20974 sure that the constant value has the right type. Fixes an
20975 unreported bug, similar to 50425.
20977 * const.cs (Const.LookupConstantValue): Call
20978 ImplicitStandardConversionExists before doing a conversion to
20979 avoid havng the TypeManager.ChangeType do conversions.
20981 Reduced the number of casts used
20983 (Const.ChangeType): New routine to enable reuse of the constant
20984 type changing code from statement.
20986 * typemanager.cs (ChangeType): Move common initialization to
20987 static global variables.
20991 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20992 every value type to go through, even if it was void. Fix that.
20994 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20995 character of the define, and the is_identifier_part_character for
20996 the rest of the string.
20998 2003-11-05 Miguel de Icaza <miguel@ximian.com>
21000 * expression.cs (UnaryMutator.EmitCode): When I updated
21001 LocalVariableReference.DoResolve, I overdid it, and dropped an
21002 optimization done on local variable references.
21004 2003-11-04 Miguel de Icaza <miguel@ximian.com>
21006 * ecore.cs: Convert the return from Ldlen into an int.
21008 2003-10-20 Miguel de Icaza <miguel@ximian.com>
21010 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
21011 the accessibility, this is a special case for toplevel non-public
21012 classes (internal for instance).
21014 2003-10-20 Nick Drochak <ndrochak@gol.com>
21016 * ecore.cs: Fix typo and build. Needed another right paren.
21018 2003-10-19 Miguel de Icaza <miguel@ximian.com>
21020 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
21021 `internal' case regular and protected, but not allowing protected
21022 to be evaluated later. Bug 49840
21024 2003-10-15 Miguel de Icaza <miguel@ximian.com>
21026 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
21027 to kb.Nlast, and not the kb.nFirst to isolate the switch
21030 Extract the underlying type, so enumerations of long/ulong are
21031 treated like long/ulong.
21033 2003-10-14 Miguel de Icaza <miguel@ximian.com>
21035 * expression.cs (New): Overload the meaning of RequestedType to
21036 track the possible creation of the NewDelegate type, since
21037 DoResolve is invoked more than once for new constructors on field
21040 See bugs: #48800 and #37014
21042 * cs-parser.jay (declare_local_constants): Take an arraylist
21043 instead of a single constant.
21045 (local_constant_declaration): It should take a
21046 constant_declarators, not a constant_declarator. Fixes 49487
21048 * convert.cs: Fix error report.
21050 2003-10-13 Jackson Harper <jackson@ximian.com>
21052 * typemanager.cs (TypeToCoreType): Add float and double this fixes
21055 2003-10-09 Martin Baulig <martin@ximian.com>
21057 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
21059 (MethodCore.DoDefineParameters): Removed the TypeContainer
21060 argument; use the DeclSpace which was passed to the .ctor instead.
21061 (MethodCore.CheckParameter): Take a DeclSpace instead of a
21062 TypeContainer; we only need a DeclSpace here.
21064 2003-10-09 Martin Baulig <martin@ximian.com>
21066 * class.cs (MethodData): Added additional `DeclSpace ds' argument
21068 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
21069 EmitContext's .ctor.
21071 2003-10-09 Martin Baulig <martin@ximian.com>
21073 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
21074 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
21075 AsAccessible(), moved them as well.
21077 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
21079 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
21081 * cs-parser.jay : Renamed yyName to yyNames related to jay.
21083 2003-10-07 Miguel de Icaza <miguel@ximian.com>
21085 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
21086 generation for >=, as spotted by Paolo, bug 48679.
21087 Patch from David Waite.
21089 * cs-tokenizer.cs: Add handling for #pragma.
21091 * cs-parser.jay: Allow for both yield and yield return in the
21092 syntax. The anti-cobolization of C# fight will go on!
21094 * class.cs (TypeBuilder.DefineType): Catch error condition here
21095 (Parent.DefineType erroring out and returning null).
21097 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21098 coping with enumerations variables, we were mistakenly processing
21099 them as a regular value type instead of built-in types. Fixes the
21102 * typemanager.cs (IsBuiltinOrEnum): New method.
21104 2003-09-30 Miguel de Icaza <miguel@ximian.com>
21106 * cs-parser.jay: Upgrade: yield now needs the return clause.
21108 2003-09-19 Martin Baulig <martin@ximian.com>
21110 * decl.cs (MemberCache.SetupCacheForInterface): Take a
21111 `MemberCache parent' argument. Normally, an interface doesn't
21112 have a parent type except System.Object, but we use this in gmcs
21113 for generic type parameters.
21115 2003-09-18 Martin Baulig <martin@ximian.com>
21117 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21118 on `type.IsInterface'; don't check whether the type has a parent
21119 to determine whether it's an interface.
21121 2003-09-15 Martin Baulig <martin@ximian.com>
21123 * class.cs (TypeContainer.DefineType): Added an error flag to
21124 avoid reporting duplicate CS0146's ("class definition is
21127 * driver.cs (Driver.MainDriver): Abort if
21128 RootContext.ResolveTree() reported any errors.
21130 2003-09-07 Martin Baulig <martin@ximian.com>
21132 * report.cs (Error, Warning): Added overloaded versions which take
21133 a `params object[] args' and call String.Format().
21135 2003-09-07 Martin Baulig <martin@ximian.com>
21137 * decl.cs (DeclSpace..ctor): Don't call
21138 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21139 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21140 (DeclSpace.RecordDecl): New method.
21142 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21144 2003-09-02 Ravi Pratap <ravi@ximian.com>
21146 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21147 value attributes to be applied to ParameterBuilders.
21149 * class.cs (MethodCore.LabelParameters): Make static and more
21150 generic so that it can be used from other places - like interface
21151 methods, for instance.
21153 * interface.cs (Interface.Emit): Call LabelParameters before
21154 emitting attributes on the InterfaceMethod.
21156 2003-08-26 Martin Baulig <martin@ximian.com>
21158 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21159 resolving aliases; fixes #47927.
21161 2003-08-26 Martin Baulig <martin@ximian.com>
21163 * statement.cs (Using.DoResolve): This is internally emitting a
21164 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21165 do not always return. Fixes #47681.
21167 2003-08-26 Martin Baulig <martin@ximian.com>
21169 * decl.cs (MemberCore): Moved WarningNotHiding(),
21170 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21172 (AdditionResult): Make this nested in DeclSpace.
21173 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21174 argument; call NamespaceEntry.Define() unless we're nested in a
21177 * namespace.cs (Namespace.DefineName): New public function. This
21178 is called from DeclSpace's .ctor to add
21179 (Namespace.Lookup): Include DeclSpaces in the lookup.
21181 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21183 * const.cs (Const): Derive from MemberBase, not MemberCore.
21185 2003-08-25 Martin Baulig <martin@ximian.com>
21187 * convert.cs (Convert.ExplicitReferenceConversion): When
21188 converting from an interface type to a class, unbox if the target
21189 type is a struct type. Fixes #47822.
21191 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21193 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21196 2003-08-22 Martin Baulig <martin@ximian.com>
21198 * class.cs (TypeManager.DefineType): When defining a nested type,
21199 call DefineType() on our parent; fixes #47801.
21201 2003-08-22 Martin Baulig <martin@ximian.com>
21203 * class.cs (MethodData.Define): While checking if a method is an
21204 interface implementation, improve the test a bit more to fix #47654.
21206 2003-08-22 Martin Baulig <martin@ximian.com>
21208 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21209 correctly; fixes #47722.
21211 2003-08-22 Martin Baulig <martin@ximian.com>
21213 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21214 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21216 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21218 2003-08-22 Martin Baulig <martin@ximian.com>
21220 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21221 can only be assigned in static constructors. Fixes #47161.
21223 2003-08-22 Martin Baulig <martin@ximian.com>
21225 Rewrote and improved the flow analysis code.
21227 * flowbranching.cs (FlowBranching): Make this class abstract.
21228 (FlowBranching.CreateBranching): New static function to create a
21229 new flow branching.
21230 (FlowBranchingBlock, FlowBranchingException): New classes.
21231 (FlowBranching.UsageVector.Type): New public readonly field.
21232 (FlowBranching.UsageVector.Breaks): Removed the setter.
21233 (FlowBranching.UsageVector.Returns): Removed the setter.
21234 (FlowBranching.UsageVector): Added Break(), Return(),
21235 NeverReachable() and Throw() methods to modify the reachability.
21236 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21237 done by FlowBranching.Merge().
21238 (FlowBranching.UsageVector.MergeChild): New method; merges the
21239 merge result into the current vector.
21240 (FlowBranching.Merge): New abstract method to merge a branching.
21242 2003-08-12 Martin Baulig <martin@ximian.com>
21244 * expression.cs (Indirection.CacheTemporaries): Create the
21245 LocalTemporary with the pointer type, not its element type.
21247 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21249 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21250 token was a keyword or not.
21252 Add `error' options where an IDENTIFIER was expected; Provide
21253 CheckToken and CheckIdentifierToken convenience error reporting
21256 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21258 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21259 NameSpaceEntry NameSpaceEntry.
21261 (LookupInterfaceOrClass): Avoid creating a full qualified name
21262 from namespace and name: avoid doing lookups when we know the
21263 namespace is non-existant. Use new Tree.LookupByNamespace which
21264 looks up DeclSpaces based on their namespace, name pair.
21266 * driver.cs: Provide a new `parser verbose' to display the
21267 exception thrown during parsing. This is turned off by default
21268 now, so the output of a failure from mcs is more graceful.
21270 * namespace.cs: Track all the namespaces defined in a hashtable
21273 (IsNamespace): New method
21275 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21277 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21278 we know that we need to concatenate (full typename can never be
21283 * statement.cs: Use a bitfield; Do not initialize to null things
21284 which are done by the constructor by default.
21286 * cs-parser.jay: bug fix, parameter was 4, not 3.
21288 * expression.cs: Just use the property;
21290 * statement.cs: No need for GetVariableInfo method.
21292 2003-08-08 Martin Baulig <martin@ximian.com>
21294 * flowanalysis.cs (FlowReturns): This is now nested in the
21295 `FlowBranching' class.
21296 (MyBitVector): Moved this here from statement.cs.
21297 (FlowBranching.SiblingType): New enum type.
21298 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21300 2003-08-07 Martin Baulig <martin@ximian.com>
21302 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21303 `FlowBranching' class and called `BranchingType'.
21305 2003-08-07 Martin Baulig <martin@ximian.com>
21307 * flowanalysis.cs: Moved all the control flow analysis code into
21310 2003-08-07 Martin Baulig <martin@ximian.com>
21312 * assign.cs (Assign.DoResolve): `target' must either be an
21313 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21316 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21318 * expression.cs (BinaryMethod): This kind of expression is created by the
21319 Binary class if it determines that the operator has to be handled
21322 (BinaryDelegate): This kind of expression is created if we are
21323 dealing with a + or - operator on delegates.
21325 (Binary): remove method, argumetns, and DelegateOperator: when
21326 dealing with methods,
21328 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21330 * statement.cs (Block): use bitfields for the three extra booleans
21331 we had in use. Remove unused topblock parameter.
21333 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21335 * assign.cs: Drop extra unneeded tests.
21337 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21339 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21341 * statement.cs (Foreach): Use VariableStorage instead of
21344 * codegen.cs (VariableStorage): New class used by clients that
21345 require a variable stored: locals or fields for variables that
21346 need to live across yield.
21348 Maybe provide a convenience api for EmitThis+EmitLoad?
21350 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21353 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21355 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21356 RemapParameterLValue): New methods that are used to turn a
21357 precomputed FieldInfo into an expression like this:
21361 The idea is to use this instead of making LocalVariableReference
21362 have more than one meaning.
21364 * cs-parser.jay: Add error production to BASE.
21366 * ecore.cs: Deal with TypeManager.GetField returning null, which
21367 is now a valid return value.
21369 (FieldExprNoAddress): New expression for Fields whose address can
21372 * expression.cs (LocalVariableReference): During the resolve
21373 phases, create new expressions if we are in a remapping context.
21374 Remove code that dealt with remapping here.
21376 (ParameterReference): same.
21378 (ProxyInstance): New expression, like the `This' expression, but
21379 it is born fully resolved. We know what we are doing, so remove
21380 the errors that are targeted to user-provided uses of `this'.
21382 * statement.cs (Foreach): our variable is now stored as an
21383 Expression; During resolution, follow the protocol, dont just
21384 assume it will return this.
21386 2003-08-06 Martin Baulig <martin@ximian.com>
21388 * support.cs (SeekableStreamReader.cs): New public class.
21390 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21391 SeekableStreamReader instead of the normal StreamReader.
21393 2003-08-04 Martin Baulig <martin@ximian.com>
21395 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21396 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21397 deambiguate casts and delegate invocations.
21398 (parenthesized_expression): Use the new tokens to ensure this is
21399 not a cast of method invocation.
21401 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21402 when reading a `)' and Deambiguate_CloseParens () was previously
21405 * expression.cs (ParenthesizedExpression): New class. This is
21406 just used for the CS0075 test.
21407 (Binary.DoResolve): Check for CS0075.
21409 2003-07-29 Ravi Pratap <ravi@ximian.com>
21411 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21412 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21413 reference comparison.
21415 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21416 examine the ReturnType for equality - this is necessary in the
21417 cases of implicit and explicit operators whose signature also
21418 includes the return type.
21420 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21422 * namespace.cs: Cache the result of the namespace computation,
21423 instead of computing it every time.
21425 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21427 * decl.cs: Use a global arraylist that we reuse over invocations
21428 to avoid excesive memory consumption. Reduces memory usage on an
21429 mcs compile by one meg (45 average).
21431 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21432 private, work around that.
21434 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21436 * literal.cs (IntLiteral): Define Zero and One static literals.
21438 * cs-parser.jay (integer_literal): use static literals to reduce
21439 memory usage for the most used literals (0, 1 and -1). 211kb
21440 reduced in memory usage.
21442 Replace all calls to `new ArrayList' with `new
21443 ArrayList(4)' which is a good average number for most allocations,
21444 and also requires only 16 bytes of memory for its buffer by
21447 This reduced MCS memory usage in seven megabytes for the RSS after
21450 2003-07-28 Ravi Pratap <ravi@ximian.com>
21452 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21453 handle params methods the correct way by forming only one
21454 applicable set with params and normal methods in them. Earlier we
21455 were looking at params methods only if we found no normal methods
21456 which was not the correct thing to do.
21458 (Invocation.BetterFunction): Take separate arguments indicating
21459 when candidate and the best method are params methods in their
21462 This fixes bugs #43367 and #46199.
21464 * attribute.cs: Documentation updates.
21466 (CheckAttribute): Rename to CheckAttributeTarget.
21467 (GetValidPlaces): Rename to GetValidTargets.
21469 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21470 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21474 2003-07-28 Martin Baulig <martin@ximian.com>
21476 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21477 name when looking up the base class of a nested class. Fixes #46977.
21479 2003-07-26 Martin Baulig <martin@ximian.com>
21481 * expression.cs (Indexers.Indexer): New nested struct; contains
21482 getter, setter and the indexer's type.
21483 (Indexers.Properties): This is now an ArrayList of
21484 Indexers.Indexer's.
21485 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21486 indexer doesn't have any getters.
21488 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21489 for embedded property and indexer assignments.
21491 2003-07-26 Martin Baulig <martin@ximian.com>
21493 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21494 preprocessor directive is not the first non-whitespace character
21497 2003-07-26 Martin Baulig <martin@ximian.com>
21499 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21500 namespace parsing, follow the spec more closely.
21502 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21503 NamespaceEntry.Lookup().
21505 2003-07-25 Martin Baulig <martin@ximian.com>
21507 * MethodCore.cs (OverridesSomething): New public field; it's set
21508 from TypeContainer.DefineMembers if this method overrides
21509 something (which doesn't need to be a method). Fix #39462.
21511 2003-07-25 Ravi Pratap <ravi@ximian.com>
21513 * typemanager.cs (GetMembers): Ensure that the list of members is
21514 reversed. This keeps things in sync.
21516 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21517 find an AttributeUsage attribute.
21519 * expression.cs (Invocation.OverloadResolve): Perform the check
21520 which disallows Invoke to be directly called on a Delegate.
21522 (Error_InvokeOnDelegate): Report error cs1533.
21524 2003-07-25 Martin Baulig <martin@ximian.com>
21526 * expression.cs (Indexers.GetIndexersForType): Only look in the
21527 interface hierarchy if the requested type is already an
21528 interface. Fixes #46788 while keeping #46502 fixed.
21530 2003-07-25 Martin Baulig <martin@ximian.com>
21532 * class.cs (TypeContainer.DefineMembers): Check whether all
21533 readonly fields have been assigned and report warning CS0649 if
21536 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21539 2003-07-24 Ravi Pratap <ravi@ximian.com>
21541 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21542 returned from GetMethods to make things consistent with the
21543 assumptions MCS makes about ordering of methods.
21545 This should comprehensively fix bug #45127 and it does :-)
21547 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21548 ordering is actually reverse.
21550 * Clean up some debug messages I left lying around.
21552 * interface.cs (Populate*): Get rid of code which emits attributes
21553 since the stage in which we emit attributes is the 'Emit' stage,
21554 not the define stage.
21556 (Emit): Move attribute emission for interface members here.
21558 2003-07-22 Ravi Pratap <ravi@ximian.com>
21560 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21561 closely: we eliminate methods in base types when we have an
21562 applicable method in a top-level type.
21564 Please see section 14.5.5.1 for an exact description of what goes
21567 This fixes bug #45127 and a host of other related to corlib compilation.
21569 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21570 array is the method corresponding to the top-level type (this is
21571 because of the changes made to icall.c) so we change this
21574 (MethodGroupExpr.Name): This too.
21576 * typemanager.cs (GetElementType): New method which does the right
21577 thing when compiling corlib.
21579 * everywhere: Make use of the above in the relevant places.
21581 2003-07-22 Martin Baulig <martin@ximian.com>
21583 * cs-parser.jay (invocation_expression): Moved
21584 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21585 `cast_expression', but create a InvocationOrCast which later
21586 resolves to either an Invocation or a Cast.
21588 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21589 method; call this before EmitStatement() to make sure that this
21590 expression can be used as a statement.
21592 * expression.cs (InvocationOrCast): New class; resolves to either
21593 an Invocation or a Cast.
21595 * statement.cs (StatementExpression): Call ResolveStatement() on
21596 the ExpressionStatement before emitting it.
21598 2003-07-21 Martin Baulig <martin@ximian.com>
21600 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21601 `ref' and `out' attributes match; fixes #46220.
21602 (MemberAccess.ResolveMemberAccess): You can't reference a type
21603 through an expression; fixes #33180.
21604 (Indexers.GetIndexersForType): Don't return the indexers from
21605 interfaces the class implements; fixes #46502.
21607 2003-07-21 Martin Baulig <martin@ximian.com>
21609 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21610 CS0661 checks; fixes bug #30442.
21612 2003-07-21 Martin Baulig <martin@ximian.com>
21614 * decl.cs (AdditionResult): Added `Error'.
21616 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21618 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21619 makes cs0031.cs actually work.
21621 2003-07-20 Martin Baulig <martin@ximian.com>
21623 * namespace.cs: Fixed that bug which caused a crash when compiling
21624 the debugger's GUI.
21626 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21628 * typemanager.cs (LookupTypeReflection): Never expose types which
21629 are NotPublic, NestedPrivate, NestedAssembly, or
21630 NestedFamANDAssem. We used to return these, and later do a check
21631 that would report a meaningful error, but the problem is that we
21632 would not get the real match, if there was a name override.
21634 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21636 * namespace.cs (Namespace, Name): Do not compute the namespace
21637 name dynamically, compute it in the constructor. This reduced
21638 memory usage by 1697 KB.
21640 * driver.cs: Use --pause to pause at the end.
21642 2003-07-17 Peter Williams <peter@newton.cx>
21644 * Makefile: Change the name of the test target so that it doesn't
21645 conflict with the recursive test target.
21647 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21649 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21650 AddressOf): Do not use EmitThis, that was wrong, use the actual
21653 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21655 * class.cs (MethodData.Define): While checking if a method is an
21656 interface implementation, improve the test: If we are not public
21657 (use new test here: use the computed MethodAttributes directly,
21658 instead of the parsed modifier flags) check if the `implementing'
21659 method comes from an interface or not.
21661 * pending.cs (VerifyPendingMethods): Slightly better error
21664 * makefile: add test target that does the mcs bootstrap.
21666 2003-07-16 Ravi Pratap <ravi@ximian.com>
21668 * interface.cs (Define): Do nothing here since there are no
21669 members to populate etc. Move the attribute emission out of here
21670 since this was just totally the wrong place to put it. Attribute
21671 application happens during the 'Emit' phase, not in the 'Define'
21674 (Emit): Add this method and move the attribute emission here
21676 * rootcontext.cs (EmitCode): Call the Emit method on interface
21679 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21681 * expression.cs (OverloadResolve): Report error only if Location
21682 is not 'Null' which means that there was a probe going on.
21684 2003-07-14 Martin Baulig <martin@ximian.com>
21686 * expression.cs (ConditionalLogicalOperator): New public class to
21687 implement user defined conditional logical operators.
21688 This is section 14.11.2 in the spec and bug #40505.
21690 2003-07-14 Martin Baulig <martin@ximian.com>
21692 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21694 2003-07-14 Martin Baulig <martin@ximian.com>
21696 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21698 * ecore.cs (IVariable.VerifyFixed): New interface method.
21700 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21701 operator, check whether the variable is actually fixed. Fixes bug
21702 #36055. Set a variable definitely assigned when taking its
21703 address as required by the spec.
21705 * statement.cs (LocalInfo.IsFixed): New field.
21706 (LocalInfo.MakePinned): Set `IsFixed' to true.
21708 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21710 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21711 for .ctors, ensure that we only ask for members declared in the
21712 attribute type (BindingFlags.DeclaredOnly).
21716 * expression.cs (Error_WrongNumArguments): Report error 1501
21717 correctly the way CSC does.
21719 2003-07-13 Martin Baulig <martin@ximian.com>
21721 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21722 lookup on the fully qualified name, to make things like "X.X" work
21723 where "X.X" is a fully qualified type name, but we also have a
21724 namespace "X" in the using list. Fixes #41975.
21726 2003-07-13 Martin Baulig <martin@ximian.com>
21728 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21729 function. If we're a CompoundAssign, we need to create an embedded
21730 CompoundAssign, not an embedded Assign.
21731 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21734 2003-07-13 Martin Baulig <martin@ximian.com>
21736 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21737 work to fix bug #46088.
21739 2003-07-13 Ravi Pratap <ravi@ximian.com>
21741 * class.cs (Operator.Emit): Do not emit attributes here - it is
21742 taken care of by the Method class that we delegate too. This takes
21743 care of bug #45876.
21745 2003-07-10 Martin Baulig <martin@ximian.com>
21747 * expression.cs (TypeOfVoid): New class.
21748 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21750 2003-07-10 Martin Baulig <martin@ximian.com>
21752 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21755 2003-07-10 Martin Baulig <martin@ximian.com>
21757 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21758 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21760 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21762 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21764 2003-07-10 Martin Baulig <martin@ximian.com>
21766 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21767 of decimal. Fixes #42850.
21769 NOTE: I also fixed the created byte blob, but this doesn't work on
21770 the MS runtime and csc never produces any byte blobs for decimal
21773 2003-07-10 Martin Baulig <martin@ximian.com>
21775 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21776 structs; fixes #32068.
21777 (Block.AddChildVariableNames): Fixed #44302.
21779 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21781 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21783 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21785 * attribute.cs: And this test is onger needed.
21787 2003-07-08 Martin Baulig <martin@ximian.com>
21789 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21790 inaccessible types. Fixes #36313.
21792 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21794 * namespace.cs (NamespaceEntry): Create implicit entries for all
21795 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21796 implicit entries for N1.N2 and N1.
21798 2003-07-08 Martin Baulig <martin@ximian.com>
21800 Rewrote the handling of namespaces to fix a lot of the issues
21801 wrt. `using' aliases etc.
21803 * namespace.cs (Namespace): Splitted this class into a
21804 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21806 * typemanager.cs (TypeManager.IsNamespace): Removed.
21807 (TypeManager.ComputeNamespaces): Only compute namespaces from
21808 loaded assemblies here, not the namespaces from the assembly we're
21809 currently compiling.
21811 2003-07-08 Martin Baulig <martin@ximian.com>
21813 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21815 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21817 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21820 I thought about the memory savings here, but LookupTypeReflection
21821 is used under already very constrained scenarios. Compiling
21822 corlib or mcs only exposes one hit, so it would not really reduce
21823 any memory consumption.
21825 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21827 * typemanager.cs: fixes bug #45889 by only adding public types from
21828 other assemblies to the list of known types.
21830 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21832 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21833 on the type we resolved.
21835 2003-07-05 Martin Baulig <martin@ximian.com>
21837 * pending.cs (PendingImplementation.ParentImplements): Don't
21838 create the proxy if the parent is abstract.
21840 * class.cs (TypeContainer.DefineIndexers): Process explicit
21841 interface implementations first. Fixes #37714.
21843 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21845 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21846 defined recursively; but since we modify the input parameters
21847 (left is set to `this' temporarily), we reset this value if the
21848 left_is_explicit is false, which gives the original semantics to
21851 * literal.cs (NullPointer): new class used to represent a null
21852 literal in a pointer context.
21854 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21855 type is a pointer, use a NullPointer object instead of a
21856 NullLiteral. Closes 43687
21858 (ExplicitConversion): Convert pointer values using
21859 the conv opcode to the proper type.
21861 * ecore.cs (New): change ValueTypeVariable property into a method,
21862 that returns whether the valuetype is suitable for being used.
21864 * expression.cs (Binary.DoNumericPromotions): Only return if we
21865 the int constant was a valid uint, and we can return both left and
21866 right as uints. If not, we continue processing, to trigger the
21867 type conversion. This fixes 39018.
21869 * statement.cs (Block.EmitMeta): During constant resolution, set
21870 the CurrentBlock property on the emitcontext, so that we resolve
21871 constants propertly.
21873 2003-07-02 Martin Baulig <martin@ximian.com>
21875 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21876 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21878 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21879 than emitting it here.
21881 * statement.cs: Fixed some more flow analysis bugs.
21883 2003-07-02 Martin Baulig <martin@ximian.com>
21885 * class.cs (MethodData.Define): When implementing interface
21886 methods, set Final unless we're Virtual.
21888 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21889 check work for interface methods.
21891 2003-07-01 Martin Baulig <martin@ximian.com>
21893 * ecore.cs (EmitContext.This): Replaced this property with a
21894 GetThis() method which takes a Location argument. This ensures
21895 that we get the correct error location for a CS0188.
21897 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21899 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21900 ImplicitStandardConversion.
21902 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21904 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21906 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21909 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21911 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21914 (MethodData.Define): Turn off initlocals for unsafe methods.
21916 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21918 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21919 complete; Fixes #37521.
21921 * delegate.cs: Use Modifiers.TypeAttr to compute the
21922 TypeAttributes, instead of rolling our own. This makes the flags
21923 correct for the delegates.
21925 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21927 * class.cs (Constructor.Define): Set the private flag for static
21928 constructors as well.
21930 * cs-parser.jay (statement_expression): Set the return value to
21931 null, to avoid a crash when we catch an error.
21933 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21935 * cs-parser.jay: Applied patch from Jackson that adds support for
21936 extern and unsafe modifiers to destructor declarations.
21938 * expression.cs: Report error 21 if the user is trying to index a
21941 * driver.cs: Add an error message, suggested by the bug report.
21943 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21944 if we do not have a ": this ()" constructor initializer. Fixes 45149
21946 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21948 * namespace.cs: Add some information to reduce FAQs.
21950 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21952 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21953 underlying enumeration types. Fixes #43915.
21955 * expression.cs: Treat ushort/short as legal values to be used in
21956 bitwise operations.
21958 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21960 * delegate.cs: transfer custom attributes for paramenters from
21961 the delegate declaration to Invoke and BeginInvoke.
21963 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21965 * attribute.cs: handle custom marshalers and emit marshal info
21968 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21970 * makefile.gnu: Added anonymous.cs to the compiler sources.
21972 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21974 * iterators.cs: Change the name of the proxy class to include two
21977 * cs-parser.jay: Update grammar to include anonymous methods.
21979 * anonymous.cs: new file.
21981 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21983 * class.cs (Field.Define): Add missing test for pointers and
21986 2003-05-27 Ravi Pratap <ravi@ximian.com>
21988 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21989 we use the stobj opcode.
21991 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21992 since it wasn't the correct fix.
21994 It still is puzzling that we are required to use stobj for IntPtr
21995 which seems to be a ValueType.
21997 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21999 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
22000 during regular simple name resolution. Now, the trick is that
22001 instead of returning for processing the simplename, we do a
22002 TypeManager.LookupType (ie, a rooted lookup as opposed to a
22003 contextual lookup type). If a match is found, return that, if
22004 not, return for further composition.
22006 This fixes long-standing 30485.
22008 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
22009 using the address to initialize an object, do an Stobj instead of
22010 using the regular Stelem.
22012 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
22013 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
22014 Because if we are a BaseIndexerAccess that value will be true.
22017 * statement.cs (GotoCase.Resolve): Return after reporting an
22018 error, do not attempt to continue.
22020 * expression.cs (PointerArithmetic.Emit): If our operand is a
22021 long, convert our constants to match the operand before
22022 multiplying. Convert to I type before adding. Fixes 43670.
22024 2003-05-14 Ravi Pratap <ravi@ximian.com>
22026 * enum.cs (ImplicitConversionExists) : Rename to
22027 ImplicitEnumConversionExists to remove ambiguity.
22029 * ecore.cs (NullCast): New type of cast expression class which
22030 basically is very similar to EmptyCast with the difference being
22031 it still is a constant since it is used only to cast a null to
22033 (eg. (string) null)
22035 * convert.cs (ImplicitReferenceConversion): When casting a null
22036 literal, we return a NullCast.
22038 * literal.cs (NullLiteralTyped): Remove - I don't see why this
22039 should be around anymore.
22041 The renaming (reported was slightly wrong). Corrections:
22043 ConvertImplicitStandard -> ImplicitConversionStandard
22044 ConvertExplicitStandard -> ExplicitConversionStandard
22046 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
22047 before passing them in !
22049 * convert.cs (ImplicitConversionStandard): When comparing for
22050 equal expr and target types, ensure that expr is not a
22053 In general, we must not be checking (expr_type ==
22054 target_type) in the top level conversion methods
22055 (ImplicitConversion, ExplicitConversion etc). This checking is
22056 done in the methods that they delegate to.
22058 2003-05-20 Miguel de Icaza <miguel@ximian.com>
22060 * convert.cs: Move Error_CannotConvertType,
22061 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
22062 ImplicitNumericConversion, ImplicitConversionExists,
22063 ImplicitUserConversionExists, StandardConversionExists,
22064 FindMostEncompassedType, FindMostSpecificSource,
22065 FindMostSpecificTarget, ImplicitUserConversion,
22066 ExplicitUserConversion, GetConversionOperators,
22067 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
22068 TryImplicitIntConversion, Error_CannotConvertImplicit,
22069 ConvertImplicitRequired, ConvertNumericExplicit,
22070 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
22071 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
22074 Perform the following renames:
22076 StandardConversionExists -> ImplicitStandardConversionExists
22077 ConvertImplicit -> ImplicitConversion
22078 ConvertImplicitStandard -> ImplicitStandardConversion
22079 TryImplicitIntConversion -> ImplicitIntConversion
22080 ConvertImplicitRequired -> ImplicitConversionRequired
22081 ConvertNumericExplicit -> ExplicitNumericConversion
22082 ConvertReferenceExplicit -> ExplicitReferenceConversion
22083 ConvertExplicit -> ExplicitConversion
22084 ConvertExplicitStandard -> ExplicitStandardConversion
22086 2003-05-19 Martin Baulig <martin@ximian.com>
22088 * statement.cs (TypeInfo.StructInfo): Made this type protected.
22089 (TypeInfo): Added support for structs having structs as fields.
22091 * ecore.cs (FieldExpr): Implement IVariable.
22092 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
22093 VariableInfo for the field.
22095 2003-05-18 Martin Baulig <martin@ximian.com>
22097 * expression.cs (This.DoResolve): Report a CS0027 if we're
22098 emitting a field initializer.
22100 2003-05-18 Martin Baulig <martin@ximian.com>
22102 * expression.cs (This.ResolveBase): New public function.
22103 (This.DoResolve): Check for CS0188.
22105 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
22108 * ecore.cs (MethodGroupExpr.DoResolve): Set the
22109 `instance_expression' to null if we don't have any non-static
22112 2003-05-18 Martin Baulig <martin@ximian.com>
22114 Reworked the way how local variables and parameters are handled by
22115 the flow analysis code.
22117 * statement.cs (TypeInfo, VariableMap): New public classes.
22118 (VariableInfo): New public class. This is now responsible for
22119 checking whether a variable has been assigned. It is used for
22120 parameters and local variables.
22121 (Block.EmitMeta): Take the InternalParameters as argument; compute
22122 the layout of the flow vectors here.
22123 (Block.LocalMap, Block.ParameterMap): New public properties.
22124 (FlowBranching): The .ctor doesn't get the InternalParameters
22125 anymore since Block.EmitMeta() now computes the layout of the flow
22127 (MyStructInfo): This class is now known as `StructInfo' and nested
22128 in `TypeInfo'; we don't access this directly anymore.
22130 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22131 property and removed IsAssigned(), IsFieldAssigned(),
22132 SetAssigned() and SetFieldAssigned(); we now call them on the
22133 VariableInfo so we don't need to duplicate this code everywhere.
22135 * expression.cs (ParameterReference): Added `Block block' argument
22137 (LocalVariableReference, ParameterReference, This): The new
22138 VariableInfo class is now responsible for all the definite
22141 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22142 IsParameterAssigned, SetParameterAssigned): Removed.
22144 2003-05-18 Martin Baulig <martin@ximian.com>
22146 * typemanager.cs (InitCoreTypes): Try calling
22147 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22148 the 3-args-version. Corlib now also needs our `void_type'.
22149 (GetMethod): Added overloaded version which takes an optional
22150 `bool report_errors' to allow lookups of optional methods.
22152 2003-05-12 Martin Baulig <martin@ximian.com>
22154 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22155 only used for locals and not for parameters.
22157 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22159 * support.cs (InternalParameters.ParameterType): Return the
22160 ExternalType of the parameter.
22162 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22165 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22167 * class.cs (MethodData.Define): Do not set the `newslot' on
22168 interface members, if they are also flagged as "override".
22170 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22171 better code for ++i and i++. This only works for static fields
22172 and local variables.
22174 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22175 want to pull the DeclSpace out of the builder_to_declspace instead
22176 of the TypeBuilder (like in TypeContainer.FindMembers).
22178 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22179 instead of LookupTypeContainer. Fixes the crash on .NET for
22180 looking up interface members.
22182 * const.cs: Create our own emit context during the Definition
22183 stage, so that constants are evaluated in the proper context, when
22184 a recursive definition happens.
22186 2003-05-11 Martin Baulig <martin@ximian.com>
22188 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22189 new block for a switch section.
22190 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22191 the adding/lookup in the switch block. Fixes #39828.
22193 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22195 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22196 functionality: I needed to convert the data after I had performed
22197 the add/sub operation into the operands type size.
22199 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22200 pass the type for the box operation, otherwise the resulting
22201 object would have been of type object.
22203 (BoxedCast): Add constructor to specify the type to box as.
22205 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22207 * iterators.cs: I was reusing the `count' variable inadvertently,
22208 take steps to not allow this to happen.
22210 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22212 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22213 by creating an array at the point where the params starts and
22214 putting all those arguments there, then adjusting the size of the
22217 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22219 * expression.cs (New.AddressOf): Implement interface
22220 IMemoryLocation. This is used when the `new' operator is used in
22221 the context of an invocation to a method on a value type.
22223 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22226 * namespace.cs: Also check the using aliases here.
22228 * driver.cs: Move the test for using validity after the types have
22229 been entered, so we do a single pass that also includes the using
22232 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22233 in the regular case. CreateSiblingForFinally is doing extra
22236 * attribute.cs (GetAttributeArgumentExpression): Store the result
22237 on an out value, and use the return value to indicate failure
22238 instead of using null (which is a valid return for Constant.GetValue).
22240 * statement.cs: Perform the analysis flow for the increment
22241 portion after the statement, because this will be the real flow of
22242 execution. Fixes #42385
22244 * codegen.cs (EmitContext.EmitArgument,
22245 EmitContext.EmitStoreArgument): New helper functions when the
22246 RemapToProxy flag is set.
22248 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22251 Add support for remapping parameters.
22253 * iterators.cs: Propagate parameter values; Store parameter
22254 values in the proxy classes.
22256 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22258 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22259 need a proxy reference; I do not know what I was thinking
22261 * cs-parser.jay (constructor_initializer): catch another error,
22262 and display nice message.
22264 (field_declaration): catch void field declaration
22265 to flag a better error.
22267 * class.cs (MemberBase.CheckBase): Report an error instead of a
22268 warning if a new protected member is declared in a struct.
22269 (Field.Define): catch the error of readonly/volatile.
22271 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22273 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22274 volatile variable is taken
22276 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22278 * statement.cs (Fixed.Resolve): Report an error if we are not in
22281 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22283 * typemanager.cs: reuse the code that handles type clashes for
22284 delegates and enumerations.
22286 * class.cs (Report28): Always report.
22288 * expression.cs (EncodeAsAttribute): Allow nulls here.
22290 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22292 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22293 the functionality for testing whether an expression is valid for
22294 an attribute here. Also handle the case of arrays of elements
22297 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22298 encoding a linear array into an array of objects that are suitable
22299 to be passed to an CustomAttributeBuilder.
22301 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22303 * ecore.cs: (FieldExpr): Handle field remapping here.
22305 * iteratators.cs: Pass the instance variable (if the method is an
22306 instance method) to the constructors, so we can access the field
22307 variables on the class.
22309 TODO: Test this with structs. I think the THIS variable on
22310 structs might have to be a pointer, and not a refenrece
22312 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22314 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22315 local variables to fields in a proxy class.
22317 * iterators.cs (PopulateProxy): Rename our internal fields to
22319 Create a <THIS> field if we are an instance method, so we can
22320 reference our parent container variables.
22321 (MapVariable): Called back from the EmitContext code to enter a
22322 new variable to field mapping into the proxy class (we just create
22326 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22327 for using the remapped locals to fields.
22329 I placed the code here, because that gives the same semantics to
22330 local variables, and only changes the Emit code.
22332 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22333 statements inside iterators.
22334 (VariableInfo): Add a FieldBuilder for the cases when we are
22335 remapping local variables to fields in a proxy class
22337 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22338 current_block != null.
22340 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22341 not cope with strings, as it has been moved to the
22342 TableSwitchEmit. Fixed bug in switch generation.
22344 * expression.cs (New.DoResolve): Provide more context for the user
22345 when reporting an error.
22347 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22350 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22351 check the permissions for it. Note than in a type-resolution
22352 context the check was already present in DeclSpace.ResolveType,
22353 but was missing from the MemberAccess.
22355 (ArrayCreation.CheckIndices): warn if the user has
22356 more nested levels of expressions, but there are no more
22357 dimensions specified. Avoids crash on bug 41906.
22359 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22361 * statement.cs (Block): replace Implicit bool, for a generic
22363 New flag: `Unchecked'. This is used during the EmitMeta phase
22364 (which is out-of-line with the regular Resolve/Emit process for a
22365 statement, as this is done ahead of time, but still gets a chance
22366 to call constant resolve).
22368 (Block.Flags): new enum for adding a new flag.
22370 (Block.EmitMeta): track the state of unchecked.
22372 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22373 to enable constant resolution to work there as well.
22375 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22377 * typemanager.cs (ienumerable_type): Also look up
22378 System.Collections.IEnumerable.
22380 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22382 TODO: Test more than one conditional per method.
22384 * class.cs (Indexer.Define): Report the location where the user is
22385 referencing the unsupported feature.
22387 (MethodData): Overload the use of `conditionals' to
22388 minimize the creation of needless ArrayLists. This saves roughly
22389 212kb on my machine.
22391 (Method): Implement the new IIteratorContainer interface.
22392 (Method.SetYields): Implement the method by setting the ModFlags
22393 to contain METHOD_YIELDS.
22395 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22396 which just got set to null.
22398 * iterators.cs: New file.
22400 (Yield, YieldBreak): New statements.
22402 * statement.cs (Return.Resolve): Flag an error if we are used in
22403 an iterator method.
22405 * codegen.cs (InIterator): New flag set if the code is being
22406 compiled in an iterator method.
22408 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22409 internal modifier, and we just use it to avoid adding extra
22410 fields, as this is seldom used.
22412 * cs-parser.jay: Add yield_statement (yield and yield break).
22414 * driver.cs: New flag -v2 to turn on version 2 features.
22416 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22417 hashtable when v2 is enabled.
22419 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22421 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22422 there is already a namespace defined with this name.
22424 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22425 people upgraded their corlibs.
22427 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22428 always use fully qualified types, no need to use the compiler
22431 (TypeManager.IsNamespace): Use binarysearch.
22433 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22434 AddDelegate): I did not quite use the new IsValid API properly: I
22435 have to pass the short-name and the fullname. I was passing only
22436 the basename instead of the fullname sometimes.
22438 (TypeContainer.DefineType): call NamespaceClash.
22440 * interface.cs (Interface.DefineType): use NamespaceClash before
22443 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22446 * enum.cs: (Enum.DefineType): use NamespaceClash before
22449 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22450 speed increase. First, use the negative_hits cache when we get a
22451 negative. Second, add the type with its full original name
22452 instead of the new . and + encoded name (reflection uses + to
22453 separate type from a nested type). Use LookupTypeReflection
22454 directly which bypasses the type->name hashtable (that we already
22455 know does not contain the type.
22457 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22458 location/container type.
22460 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22462 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22464 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22466 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22467 method is being referenced in the method group from a static
22468 context, and report error 120 if so.
22470 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22473 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22474 is created, we create the A namespace).
22476 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22479 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22481 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22482 invocation to ModuleBuilder.GetType with the same values will
22483 return a new type instance, so we need to cache its return
22486 * expression.cs (Binary.ResolveOperator): Only allow the compare
22487 operators on enums if they are of the same type.
22489 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22490 types of ValueType on their own case. Before we were giving them
22491 the same treatment as objects.
22493 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22494 fullname. Short name is used to compare against container name.
22495 Fullname is used to check against defined namespace names.
22497 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22498 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22500 (Method.CheckBase): Call parent.
22501 (MemberBase.CheckBase): Check for protected members on sealed
22503 (PropertyBase.CheckBase): Call parent.
22504 (Field.Define): Call parent.
22506 * report.cs: Negative error codes are now mapped to 8000 - code,
22507 so that the display is render more nicely.
22509 * typemanager.cs: Do not use try/catch, instead report a regular
22512 (GetPointerType, GetReferenceType): These methods provide
22513 mechanisms to obtain the T* and T& from a T. We had the code
22514 previously scattered around the code base, and it also used
22515 TypeManager.LookupType that would go through plenty of caches.
22516 This one goes directly to the type source.
22518 In some places we did the Type.GetType followed by
22519 ModuleBuilder.GetType, but not in others, so this unifies the
22520 processing as well.
22522 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22523 statements now that we have namespace information.
22525 * typemanager.cs (IsNamespace): New method, returns whether the
22526 string presented is a namespace or not.
22528 (ComputeNamespaces): New public entry point, computes the list of
22529 available namespaces, using the GetNamespaces API call in Mono, or
22530 the slower version in MS.NET.
22532 Now before we start the semantic analysis phase, we have a
22533 complete list of namespaces including everything that the user has
22536 Deleted old code to cache namespaces in .nsc files.
22538 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22540 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22541 class/struct location definition Location for the implicit
22542 constructor location.
22544 (Operator.Define): Use the location of the operator for the
22545 implicit Method definition.
22547 (Constructor.Emit): use the constructor location for the implicit
22548 base initializer constructor.
22550 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22551 and the Expression class now contains two new methods:
22553 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22554 isolate type lookup from the rest of the resolution process.
22556 Since we use Expressions to hold type definitions due to the way
22557 we parse the input we have historically overloaded Resolve to
22558 perform the Type lookups if a special flag is passed. Now this is
22559 eliminated and two methods take their place.
22561 The differences in the two methods between xStep and xTerminal is
22562 that xStep is involved in our current lookup system that uses
22563 SimpleNames to compose a name, while xTerminal is used just to
22564 catch the case where the simplename lookup failed.
22566 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22568 * expression.cs (ResolveMemberAccess): Remove redundant code.
22569 TypeExpr expressions are always born fully resolved.
22571 * interface.cs (PopulateMethod): Do not lookup the types twice.
22572 We were doing it once during SemanticAnalysis and once during
22575 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22576 in local variable type definitions, were being returned as a
22577 SimpleName (we decomposed everything into a string), that is
22578 because primary_expression was being used instead of a type in the
22579 grammar (reduce/reduce conflicts).
22581 The part that was wrong is that we converted the expression into a
22582 string (an oversimplification in one hand, compounded with primary
22583 expressions doing string concatenation).
22589 Would return "A.B.C[]" as a SimpleName. This stopped things like
22590 using clauses from working on this particular context. And a type
22591 was being matched directly against "A.B.C[]".
22593 We now use the correct approach, and allow for ComposedCast to be
22594 part of the unary expression. So the "A.B.C []" become a composed
22595 cast of "A.B.C" (as a nested group of MemberAccess with a
22596 SimpleName at the end) plus the rank composition "[]".
22600 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22602 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22603 for the access level checking.
22605 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22606 `TypeContainer container', because I kept getting confused when I
22607 was debugging this code.
22609 * expression.cs (Indexers): Instead of tracking getters/setters,
22610 we now track them in parallel. We create one arraylist less, but
22611 most importantly it is possible now for the LValue code to find a
22612 matching get for a set.
22614 (IndexerAccess.DoResolveLValue): Update the code.
22615 GetIndexersForType has been modified already to extract all the
22616 indexers from a type. The code assumed it did not.
22618 Also make the code set the correct return type for the indexer.
22619 This was fixed a long time ago for properties, but was missing for
22620 indexers. It used to be void_type.
22622 (Binary.Emit): Test first for doubles instead of
22623 floats, as they are more common.
22625 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22626 when dealing with floats and the <=, >= operators. This fixes bug
22629 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22630 to load the array value by emitting a load on the foreach variable
22631 type. This was incorrect.
22633 We now emit the code to load an element using the the array
22634 variable type, and then we emit the conversion operator.
22638 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22640 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22642 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22644 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22645 test for protection before we test for signatures.
22647 (MethodSignature.ToString): implement.
22649 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22650 to the case where we reduced into a LongConstant.
22652 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22653 depend on whether the information is acurrate, because the
22654 Microsoft runtime will always claim that the array type is public,
22655 regardless of the real state.
22657 If the type is a pointer, another problem happens: the type is
22658 reported as non-public in Microsoft.
22660 In both cases we have to call CheckAccessLevel recursively with
22661 the underlying type as the argument to be tested.
22663 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22665 * assign.cs (Assign.Emit): If we are dealing with a compound
22666 assignment expression, we should use the code path that stores the
22667 intermediate result in a temporary value. This fixes #40903.
22669 *expression.cs (Indirection.ToString): Provide ToString method for
22672 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22674 * class.cs: Null out fields holding references to Block objects so
22675 they can be garbage collected.
22677 * expression.cs (OverloadResolve): Remove unused local.
22679 2003-04-07 Martin Baulig <martin@ximian.com>
22681 * codegen.cs (EmitContext.CurrentFile): New public field.
22682 (EmitContext.Mark): Use the CurrentFile to check whether the
22683 location is in the correct file.
22684 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22686 2003-04-07 Martin Baulig <martin@ximian.com>
22688 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22690 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22691 location. [FIXME: The location argument which gets passed to this
22692 method is sometimes wrong!]
22694 2003-04-07 Nick Drochak <ndrochak@gol.com>
22696 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22698 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22700 * expression.cs (Indirection.EmitAssign): We were using the
22701 temporary, but returning immediately instead of continuing the
22704 2003-04-06 Martin Baulig <martin@ximian.com>
22706 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22707 if it's a nested child, but also deriving from the outer class.
22710 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22711 nested child, but also deriving from the outer class. See
22713 (FilterWithClosure): We may access private members of the outer
22714 class if we're a nested child and deriving from the outer class.
22715 (RealMemberLookup): Only set `closure_private_ok' if the
22716 `original_bf' contained BindingFlags.NonPublic.
22718 2003-04-05 Martin Baulig <martin@ximian.com>
22720 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22722 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22724 * class.cs (Event.Define): Do not allow abstract events to have
22727 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22729 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22730 block in event declarations.
22732 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22733 value type, get its address.
22735 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22736 leaving a class on the stack instead of a boolean value (int
22737 0/1). Change the code so we compare against null, and then the
22738 result against zero.
22740 * class.cs (TypeContainer.GetClassBases): We were checking for the
22741 parent class being sealed too late.
22743 * expression.cs (Binary.Emit): For <= and >= when dealing with
22744 floating point values, use cgt.un and clt.un instead of cgt and
22747 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22749 * statement.cs: Apply the same optimization as MS: skip the
22750 GetEnumerator returning an IEnumerator, and use the one returning a
22751 CharEnumerator instead. This allows us to avoid the try-finally block
22754 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22756 * cs-parser.jay: Attributes cannot be applied to
22757 namespaces. Fixes #40473
22759 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22762 (Add*): check if the name is valid using the full name for constants,
22763 fields, properties and events.
22765 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22767 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22768 char constants to be part of the enumeration.
22770 * expression.cs (Conditional.DoResolve): Add support for operator
22771 true. Implements the missing functionality from 14.12
22773 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22774 operator true/false as required by the spec.
22776 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22777 implicit conversion to boolean.
22779 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22780 also one where the type implements `operator true'.
22782 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22783 get an expression that will invoke operator true based on an
22786 (GetConversionOperators): Removed the hack that called op_True
22789 (Expression.ResolveBoolean): Move this from Statement.
22791 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22793 * ecore.cs (FieldExpr): do not allow initialization of initonly
22794 fields on derived classes
22796 2003-03-13 Martin Baulig <martin@ximian.com>
22798 * statement.cs (Block.Emit): Call ig.BeginScope() and
22799 ig.EndScope() when compiling with debugging info; call
22800 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22802 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22804 * expression.cs (Indexers): Do not construct immediately, allow
22805 for new members to be appended as we go. Fixes 38143
22807 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22809 * expression.cs: save/restore context when resolving an unchecked
22812 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22814 * cfold.cs: Catch division by zero in modulus operator during
22817 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22819 * interface.cs (Interface.DefineMembers): Avoid defining members
22822 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22824 * driver.cs: handle the +/- options for -noconfig
22826 * statement.cs (Unckeched.Resolve): Also track the state of
22827 unchecked in the Resolve phase.
22829 2003-02-27 Martin Baulig <martin@ximian.com>
22831 * ecore.cs (Expression.MemberLookup): Don't create a
22832 MethodGroupExpr for something which is not a method. Fixes #38291.
22834 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22836 * class.cs (MemberBase.CheckParameters): Also check that the type
22837 is unmanaged if it is a pointer.
22839 * expression.cs (SizeOf.Resolve): Add location information.
22841 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22842 a managed type is declared.
22844 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22845 parameter modifiers as well. Fixes bug 38606
22847 * class.cs: Very sad. Am backing out the speed up changes
22848 introduced by the ArrayList -> Array in the TypeContainer, as they
22849 were not actually that much faster, and introduced a bug (no error
22850 reports on duplicated methods).
22852 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22853 source first, this will guarantee that we have a valid expression
22854 before calling in lower levels functions that will require a
22855 resolved object. Then use this original_source in the
22856 target.ResolveLValue instead of the original source that was
22859 Another change. Use target.Resolve instead of LValueResolve.
22860 Although we are resolving for LValues, we will let the Assign code
22861 take care of that (it will be called again from Resolve). This
22862 basically allows code like this:
22864 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22865 class Y { void A (X x) { x [0] += o; }
22867 The problem was that the indexer was trying to resolve for
22868 set_Item (idx, object o) and never finding one. The real set_Item
22869 was set_Item (idx, X). By delaying the process we get the right
22874 2003-02-23 Martin Baulig <martin@ximian.com>
22876 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22877 while calling DoEmit ().
22879 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22880 source files; if you use the #line directive inside a method, the
22881 compiler stops emitting line numbers for the debugger until it
22882 reaches the end of the method or another #line directive which
22883 restores the original file.
22885 2003-02-23 Martin Baulig <martin@ximian.com>
22887 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22889 2003-02-23 Martin Baulig <martin@ximian.com>
22891 * statement.cs (Block.AddChildVariableNames): We need to call this
22892 recursively, not just for our immediate children.
22894 2003-02-23 Martin Baulig <martin@ximian.com>
22896 * class.cs (Event.Define): Always make the field private, like csc does.
22898 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22899 actually work, fixes bug #37521.
22901 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22903 * delegate.cs: When creating the various temporary "Parameters"
22904 classes, make sure that we call the ComputeAndDefineParameterTypes
22905 on those new parameters (just like we do with the formal ones), to
22906 allow them to be resolved in the context of the DeclSpace.
22908 This fixes the bug that Dick observed in Bugzilla #38530.
22910 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22912 * expression.cs (ResolveMemberAccess): When resolving a constant,
22913 do not attempt to pull a constant if the value was not able to
22914 generate a valid constant.
22916 * const.cs (LookupConstantValue): Do not report more errors than required.
22918 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22920 * expression.cs: fixes bug #38328.
22922 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22924 * class.cs: Changed all the various members that can be part of a
22925 class from being an ArrayList to be an Array of the right type.
22926 During the DefineType type_list, interface_list, delegate_list and
22927 enum_list are turned into types, interfaces, delegates and enums
22930 And during the member population, indexer_list, event_list,
22931 constant_list, field_list, instance_constructor_list, method_list,
22932 operator_list and property_list are turned into their real arrays.
22934 Although we could probably perform this operation earlier, for
22935 good error reporting we need to keep the lists and remove the
22936 lists for longer than required.
22938 This optimization was triggered by Paolo profiling the compiler
22939 speed on the output of `gen-sample-program.pl' perl script.
22941 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22942 not crash in methods like MemberLookupFailed that use this field.
22944 This problem arises when the compiler fails to resolve a type
22945 during interface type definition for example.
22947 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22949 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22950 inherit from System.Object, so we have to stop at null, not only
22951 when reaching System.Object.
22953 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22955 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22956 DeclaredOnly because the parent indexer might have had a different
22957 name, but did not loop until the top of the hierarchy was reached.
22959 The problem this one fixes is 35492: when a class implemented an
22960 indexer from an interface, we were getting the interface method
22961 (which was abstract) and we were flagging an error (can not invoke
22964 This also keeps bug 33089 functioning, and test-148 functioning.
22966 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22967 out if a method is special is to see if it is declared in a
22968 property or event, or whether it is one of the predefined operator
22969 names. This should fix correctly #36804.
22971 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22973 The goal here is to remove the dependency on EmptyCast.Peel ().
22974 Killing it completely.
22976 The problem is that currently in a number of places where
22977 constants are expected, we have to "probe" for an EmptyCast, and
22978 Peel, which is not the correct thing to do, as this will be
22979 repetitive and will likely lead to errors.
22981 The idea is to remove any EmptyCasts that are used in casts that
22982 can be reduced to constants, so we only have to cope with
22985 This bug hunt was triggered by Bug 37363 and the desire to remove
22986 the duplicate pattern where we were "peeling" emptycasts to check
22987 whether they were constants. Now constants will always be
22990 * ecore.cs: Use an enumconstant here instead of wrapping with
22993 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22994 throwing me off. By handling this we can get rid of a few hacks.
22996 * statement.cs (Switch): Removed Peel() code.
22998 2003-02-14 Miguel de Icaza <miguel@ximian.com>
23000 * class.cs: Location information for error 508
23002 * expression.cs (New.DoResolve): Add a guard against double
23003 resolution of an expression.
23005 The New DoResolve might be called twice when initializing field
23006 expressions (see EmitFieldInitializers, the call to
23007 GetInitializerExpression will perform a resolve on the expression,
23008 and later the assign will trigger another resolution
23010 This leads to bugs (#37014)
23012 * delegate.cs: The signature for EndInvoke should contain any ref
23013 or out parameters as well. We were not doing this in the past.
23015 * class.cs (Field.Define): Do not overwrite the type definition
23016 inside the `volatile' group. Turns out that volatile enumerations
23017 were changing the type here to perform a validity test, which
23020 2003-02-12 Miguel de Icaza <miguel@ximian.com>
23022 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
23023 and structs, we do not want to load the instance variable
23025 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
23026 enum_type has to be handled like an object reference (implicit
23027 conversions exists from this to object), but the regular IsClass
23028 and IsValueType tests will never return true for this one.
23030 Also we use TypeManager.IsValueType instead of type.IsValueType,
23031 just for consistency with the rest of the code (this is only
23032 needed if we ever use the construct exposed by test-180.cs inside
23033 corlib, which we dont today).
23035 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
23037 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
23040 2003-02-09 Martin Baulig <martin@ximian.com>
23042 * namespace.cs (Namespace..ctor): Added SourceFile argument.
23043 (Namespace.DefineNamespaces): New static public method; this is
23044 called when we're compiling with debugging to add all namespaces
23045 to the symbol file.
23047 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
23048 pass it to the Namespace's .ctor.
23050 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
23051 and MethodBase arguments; pass the namespace ID to the symwriter;
23052 pass the MethodBase instead of the token to the symwriter.
23053 (SymbolWriter.DefineNamespace): New method to add a namespace to
23056 2003-02-09 Martin Baulig <martin@ximian.com>
23058 * symbolwriter.cs: New file. This is a wrapper around
23059 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
23060 methods here in near future.
23062 2003-02-09 Martin Baulig <martin@ximian.com>
23064 * codegen.cs (EmitContext.Mark): Just pass the arguments to
23065 ILGenerator.MarkSequencePoint() which are actually used by the
23068 2003-02-09 Martin Baulig <martin@ximian.com>
23070 * location.cs (SourceFile): New public sealed class. This
23071 contains the name and an index which is used in the location's token.
23072 (Location): Reserve an appropriate number of bits in the token for
23073 the source file instead of walking over that list, this gives us a
23074 really huge performance improvement when compiling with debugging.
23076 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
23077 `SourceFile' argument instead of a string.
23078 (Driver.ProcessFile): Add all the files via Location.AddFile(),
23079 but don't parse/tokenize here, we need to generate the list of all
23080 source files before we do that.
23081 (Driver.ProcessFiles): New static function. Parses/tokenizes all
23084 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
23085 instead of a string.
23087 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
23090 2003-02-09 Martin Baulig <martin@ximian.com>
23092 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
23093 filename on `#line default'.
23095 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
23097 * statement.cs: don't clear the pinned var when the fixed statement
23098 returns from the method (fixes bug#37752).
23100 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
23102 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
23105 2003-02-07 Martin Baulig <martin@ximian.com>
23107 * driver.cs: Removed the `--debug-args' command line argument.
23109 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
23110 automatically by the AsssemblyBuilder.
23111 (CodeGen.InitializeSymbolWriter): We don't need to call any
23112 initialization function on the symbol writer anymore. This method
23113 doesn't take any arguments.
23115 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23117 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23118 from referenced assemblies as well.
23120 2003-02-02 Martin Baulig <martin@ximian.com>
23122 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23124 2003-02-02 Martin Baulig <martin@ximian.com>
23126 * class.cs (Constructor.Emit): Open the symbol writer before
23127 emitting the constructor initializer.
23128 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23129 single-stepping through constructor initializers.
23131 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23133 * class.cs: Handle error 549: do not allow virtual methods in
23136 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23138 * decl.cs: Check access levels when resolving types
23140 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23142 * statement.cs: Add parameters and locals set in catch blocks that might
23143 return to set vector
23145 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23147 * class.cs (Operator): Set the SpecialName flags for operators.
23149 * expression.cs (Invocation.DoResolve): Only block calls to
23150 accessors and operators on SpecialName methods.
23152 (Cast.TryReduce): Handle conversions from char constants.
23155 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23157 * statement.cs: small memory and time optimization in FlowBranching.
23159 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23161 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23162 problem that the last fix but in the other sid (Set).
23164 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23165 access when there is no indexer in the hierarchy.
23167 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23169 * class.cs: Combine some if statements.
23171 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23173 * driver.cs: fixed bug #37187.
23175 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23177 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23178 any indexer, it's needed to build a list with all the indexers in the
23179 hierarchy (AllGetters), else we have problems. Fixes #35653.
23181 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23183 * class.cs (MethodData.Define): It is wrong for an interface
23184 implementation to be static in both cases: explicit and implicit.
23185 We were only handling this in one case.
23187 Improve the if situation there to not have negations.
23189 * class.cs (Field.Define): Turns out that we do not need to check
23190 the unsafe bit on field definition, only on usage. Remove the test.
23192 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23194 * driver.cs: use assembly.Location instead of Codebase (the latest
23195 patch made mcs fail when using MS assemblies).
23197 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23199 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23200 get the path to *corlib.dll.
23202 2003-01-21 Nick Drochak <ndrochak@gol.com>
23206 * typemanager.cs: Remove compiler warnings
23208 2003-01-20 Duncan Mak <duncan@ximian.com>
23210 * AssemblyInfo.cs: Bump the version number to 0.19.
23212 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23214 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23216 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23218 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23220 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23222 * cs-parser.jay: Small fix: we were not comparing the constructor
23223 name correctly. Thanks to Zoltan for the initial pointer.
23225 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23227 * cs-tokenizer.cs: Set file name when specified with #line
23229 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23231 * cs-parser.jay: Only perform the constructor checks here if we
23232 are named like the class; This will help provider a better
23233 error. The constructor path is taken when a type definition is
23234 not found, but most likely the user forgot to add the type, so
23235 report that rather than the constructor error.
23237 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23239 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23242 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23244 * cs-parser.jay: Add cleanup call.
23246 2003-01-13 Duncan Mak <duncan@ximian.com>
23248 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23249 consistent with other methods.
23251 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23253 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23255 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23257 * attribute.cs: only set GuidAttr to true when we have a
23260 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23264 * typemanager.cs: fixes to allow mcs compile corlib with the new
23265 Type.IsSubclassOf fix.
23267 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23269 * expression.cs (LocalVariableReference.DoResolve): Classify a
23270 constant as a value, not as a variable. Also, set the type for
23273 * cs-parser.jay (fixed_statement): take a type instead of a
23274 pointer_type, so we can produce a better error message later.
23276 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23279 (For.DoEmit): Make inifinite loops have a
23280 non-conditional branch back.
23282 (Fixed.DoEmit): First populate the pinned variables, then emit the
23283 statement, then clear the variables. Before I was emitting the
23284 code once for each fixed piece.
23287 2003-01-08 Martin Baulig <martin@ximian.com>
23289 * statement.cs (FlowBranching.MergeChild): A break in a
23290 SWITCH_SECTION does not leave a loop. Fixes #36155.
23292 2003-01-08 Martin Baulig <martin@ximian.com>
23294 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23295 lives in the same number space than `param_map'. Fixes #36154.
23297 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23299 * cs-parser.jay (constructor_declaration): Set the
23300 Constructor.ModFlags before probing for it. This makes the
23301 compiler report 514, 515 and 132 (the code was there, but got
23304 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23305 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23306 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23308 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23310 * enum.cs: create the enum static fields using the enum type.
23312 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23314 * class.cs: don't try to create the ParamBuilder for the return
23315 type if it's not needed (and handle it breaking for the ms runtime
23318 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23320 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23322 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23324 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23325 the command. This showed up while compiling the JANET source
23326 code, which used \r as its only newline separator.
23328 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23330 * class.cs (Method.Define): If we are an operator (because it
23331 reuses our code), then set the SpecialName and HideBySig. #36128
23333 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23335 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23336 exception, report error 120 `object reference required'.
23338 * driver.cs: Add --pause option, used during to measure the size
23339 of the process as it goes with --timestamp.
23341 * expression.cs (Invocation.DoResolve): Do not allow methods with
23342 SpecialName to be invoked.
23344 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23346 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23347 number before adding it.
23349 2002-12-21 Ravi Pratap <ravi@ximian.com>
23351 * ecore.cs (StandardImplicitConversion): When in an unsafe
23352 context, we allow conversion between void * to any other pointer
23353 type. This fixes bug #35973.
23355 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23357 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23358 is not thrown when extensionless outputs are used
23360 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23362 * rootcontext.cs: fixed compilation of corlib.
23364 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23366 * attribute.cs (Attributes.Contains): Add new method.
23368 * class.cs (MethodCore.LabelParameters): if the parameter is an
23369 `out' parameter, check that no attribute `[In]' has been passed.
23371 * enum.cs: Handle the `value__' name in an enumeration.
23373 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23375 * decl.cs: Added special case to allow overrides on "protected
23378 2002-12-18 Ravi Pratap <ravi@ximian.com>
23380 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23381 since it makes much more sense.
23383 (Attributes.ctor): Don't require a Location parameter.
23385 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23387 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23388 since we already have that information per attribute.
23390 * everywhere : make appropriate changes.
23392 * class.cs (LabelParameters): Write the code which actually
23393 applies attributes to the return type. We can't do this on the MS
23394 .NET runtime so we flag a warning in the case an exception is
23397 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23399 * const.cs: Handle implicit null conversions here too.
23401 2002-12-17 Ravi Pratap <ravi@ximian.com>
23403 * class.cs (MethodCore.LabelParameters): Remove the extra
23404 Type [] parameter since it is completely unnecessary. Instead
23405 pass in the method's attributes so that we can extract
23406 the "return" attribute.
23408 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23410 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23411 of ignoring it and letting the compile continue.
23413 * typemanager.cs (ChangeType): use an extra argument to return an
23414 error condition instead of throwing an exception.
23416 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23418 * expression.cs (Unary.TryReduce): mimic the code for the regular
23419 code path. Perform an implicit cast in the cases where we can
23420 implicitly convert to one of the integral types, and then reduce
23421 based on that constant. This fixes bug #35483.
23423 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23425 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23427 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23429 * namespace.cs: fixed bug #35489.
23431 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23433 * class.cs: Remove some dead code.
23435 * cs-parser.jay: Estimate the number of methods needed
23436 (RootContext.MethodCount);
23438 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23439 numbers instead of StringBuilders.
23441 * support.cs (PtrHashtable): Add constructor with initial size;
23442 We can now reduce reallocations of the method table.
23444 2002-12-10 Ravi Pratap <ravi@ximian.com>
23446 * attribute.cs (ApplyAttributes): Keep track of the emitted
23447 attributes on a per-target basis. This fixes bug #35413.
23449 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23451 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23452 default to the Windows 1252 encoding.
23454 (UnixParseOption): Support version, thanks to Alp for the missing
23457 * AssemblyInfo.cs: Add nice assembly information.
23459 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23462 * cs-parser.jay: Allow a trailing comma before the close bracked
23463 in the attribute_section production.
23465 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23466 address of the instance was being taken, I will take this out,
23467 because we take the address of the object immediately here.
23469 2002-12-09 Ravi Pratap <ravi@ximian.com>
23471 * typemanager.cs (AreMultipleAllowed): Take care of the most
23472 obvious case where attribute type is not in the current assembly -
23475 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23477 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23478 definitions, instead of doing that afterwards.
23480 Also we use a nice little hack, depending on the constructor, we
23481 know if we are a "composed" name or a simple name. Hence, we
23482 avoid the IndexOf test, and we avoid
23484 * codegen.cs: Add code to assist in a bug reporter to track down
23485 the source of a compiler crash.
23487 2002-12-07 Ravi Pratap <ravi@ximian.com>
23489 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23490 types have been emitted for a given element and flag an error
23491 if something which does not have AllowMultiple set is used more
23494 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23495 attribute types and their corresponding AllowMultiple properties
23497 (AreMultipleAllowed): Check the property for a given type.
23499 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23500 property in the case we have a TypeContainer.
23502 (Attributes.AddAttribute): Detect duplicates and just skip on
23503 adding them. This trivial fix catches a pretty gross error in our
23504 attribute emission - global attributes were being emitted twice!
23506 Bugzilla bug #33187 is now fixed.
23508 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23510 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23511 instead of pp_and).
23513 * expression.cs (Binary.ResolveOperator): I can only use the
23514 Concat (string, string, string) and Concat (string, string,
23515 string, string) if the child is actually a concatenation of
23518 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23520 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23521 context where we need a 2-character lookahead.
23523 * pending.cs (PendingImplementation): Rework so we can keep track
23524 of interface types all the time, and flag those which were
23525 implemented by parents as optional.
23527 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23529 * expression.cs (Binary.ResolveOperator): Use
23530 String.Concat(string,string,string) or
23531 String.Concat(string,string,string,string) when possible.
23533 * typemanager: More helper methods.
23536 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23538 * pending.cs: remove the bogus return from GetMissingInterfaces()
23539 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23541 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23543 * namespace.cs: avoid duplicated 'using xxx' being added to
23544 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23545 when we get more than one 'using' statement for the same namespace.
23546 Report a CS0105 warning for it.
23548 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23550 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23551 of calling getChar/putback, uses internal knowledge of it.
23553 (xtoken): Reorder tokenizer so most common patterns are checked
23554 first. This reduces the compilation time in another 5% (from 8.11s
23555 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23557 The parsing time is 22% of the compilation in mcs, and from that
23558 64% is spent on the tokenization process.
23560 I tried using a binary search for keywords, but this is slower
23561 than the hashtable. Another option would be to do a couple of
23564 * Not use a StringBuilder, instead use an array of chars,
23565 with a set value. Notice that this way we could catch
23566 the 645 error without having to do it *afterwards*.
23568 * We could write a hand-parser to avoid the hashtable
23569 compares altogether.
23571 The identifier consumption process takes 37% of the tokenization
23572 time. Another 15% is spent on is_number. 56% of the time spent
23573 on is_number is spent on Int64.Parse:
23575 * We could probably choose based on the string length to
23576 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23579 Another 3% is spend on wrapping `xtoken' in the `token' function.
23581 Handle 0xa0 as whitespace (#34752)
23583 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23585 * typemanager.cs (IsCLRType): New routine to tell whether a type
23586 is one of the builtin types.
23588 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23589 typecode in more places instead of doing pointer comparissions.
23590 We could leverage some knowledge about the way the typecodes are
23593 New code to cache namespaces in assemblies, it is currently not
23594 invoked, to be used soon.
23596 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23598 * expression.cs (Binary.ResolveOperator): specially handle
23599 strings, and do not perform user-defined operator overloading for
23602 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23604 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23605 internalcall as it is a pretty simple operation; Avoid whenever
23606 possible to call Char.IsLetter.
23608 (consume_identifier): Cut by half the number of
23609 hashtable calls by merging the is_keyword and GetKeyword behavior.
23611 Do not short-circuit, because if we do, we
23612 report errors (ie, #if false && true would produce an invalid
23616 2002-11-24 Martin Baulig <martin@ximian.com>
23618 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23619 check constant ranges and report a CS0221. Fixes #33186.
23621 2002-11-24 Martin Baulig <martin@ximian.com>
23623 * cs-parser.jay: Make this work for uninitialized variable
23624 declarations in the `for' initializer. Fixes #32416.
23626 2002-11-24 Martin Baulig <martin@ximian.com>
23628 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23629 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23631 2002-11-24 Martin Baulig <martin@ximian.com>
23633 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23634 argument; if true, we also check for user-defined conversions.
23635 This is only needed if both arguments are of a user-defined type.
23636 Fixes #30443, added test-175.cs.
23637 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23639 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23641 2002-11-24 Martin Baulig <martin@ximian.com>
23643 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23644 function to get the store opcode.
23645 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23646 only emit the Ldelema if the store opcode is Stobj. You must run
23647 both test-34 and test-167 to test this. Fixes #34529.
23649 2002-11-23 Martin Baulig <martin@ximian.com>
23651 * ecore.cs (Expression.MemberLookup): Added additional
23652 `qualifier_type' argument which is used when we're being called
23653 from MemberAccess.DoResolve() and null if we're called from a
23655 (Expression.MemberLookupFailed): New method to report errors; this
23656 does the CS1540 check and reports the correct error message.
23658 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23659 argument for the CS1540 check and redone the way how we're dealing
23660 with private members. See the comment in the source code for details.
23661 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23662 `closure_start_type' to `closure_qualifier_type' and check whether
23663 it's not null. It was not this filter being broken, it was just
23664 being called with the wrong arguments.
23666 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23667 and pass it the correct `qualifier_type'; this also does the error
23670 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23672 * expression.cs (Invocation.EmitParams): If the we are dealing
23673 with a non-built-in value type, load its address as well.
23675 (ArrayCreation): Use a a pretty constant instead
23676 of the hardcoded value 2. Use 6 instead of 2 for the number of
23677 static initializers.
23679 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23680 because they are not really value types, just glorified integers.
23682 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23684 * ecore.cs: Remove redundant code for enumerations, make them use
23685 the same code path as everything else, fixes the casting issue
23686 with enumerations in Windows.Forms.
23688 * attribute.cs: Do only cast to string if it is a string, the
23689 validation happens later.
23691 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23692 people upgrade their corlibs.
23694 * ecore.cs: Oops, enumerations were not following the entire code path
23696 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23698 * typemanager.cs (FilterWithClosure): Commented out the test for
23699 1540 in typemanager.cs, as it has problems when accessing
23700 protected methods from a parent class (see test-174.cs).
23702 * attribute.cs (Attribute.ValidateGuid): new method.
23703 (Attribute.Resolve): Use above.
23705 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23707 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23709 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23710 handling for enumerations, as we only needed the TypeContainer
23711 functionality to begin with (this is required for the fix below to
23712 work for enums that reference constants in a container class for
23715 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23717 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23718 a valid TypeBuilder to perform lookups on.o
23720 * class.cs (InheritableMemberSignatureCompare): Use true in the
23721 call to GetGetMethod and GetSetMethod, because we are comparing
23722 the signature, and we need to get the methods *even* if they are
23725 (PropertyBase.CheckBase): ditto.
23727 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23728 GotoCase.Resolve): Use Peel on EmpytCasts.
23730 * ecore.cs (EmptyCast): drop child, add Peel method.
23732 2002-11-17 Martin Baulig <martin@ximian.com>
23734 * ecore.cs (EmptyCast.Child): New public property.
23736 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23737 label resolved to an EmptyCast. Fixes #34162.
23738 (GotoCase.Resolve): Likewise.
23739 (Block.EmitMeta): Likewise.
23741 2002-11-17 Martin Baulig <martin@ximian.com>
23743 * expression.cs (Invocation.BetterConversion): Prefer int over
23744 uint; short over ushort; long over ulong for integer literals.
23745 Use ImplicitConversionExists instead of StandardConversionExists
23746 since we also need to check for user-defined implicit conversions.
23747 Fixes #34165. Added test-173.cs.
23749 2002-11-16 Martin Baulig <martin@ximian.com>
23751 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23752 with the `true' and `false' literals. Fixes #33151.
23754 2002-11-16 Martin Baulig <martin@ximian.com>
23756 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23757 October 22nd; don't do the cs1540 check for static members.
23759 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23760 now using our own filter here and doing the cs1540 check again.
23762 2002-11-16 Martin Baulig <martin@ximian.com>
23764 * support.cs (InternalParameters): Don't crash if we don't have
23765 any fixed parameters. Fixes #33532.
23767 2002-11-16 Martin Baulig <martin@ximian.com>
23769 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23770 when looking up static methods to make this work on Windows.
23773 2002-11-16 Martin Baulig <martin@ximian.com>
23775 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23776 a setter rather than using PropertyInfo.CanWrite.
23778 2002-11-15 Nick Drochak <ndrochak@gol.com>
23780 * class.cs: Allow acces to block member by subclasses. Fixes build
23783 2002-11-14 Martin Baulig <martin@ximian.com>
23785 * class.cs (Constructor.Emit): Added the extern/block check.
23788 2002-11-14 Martin Baulig <martin@ximian.com>
23790 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23791 iteration while looking for indexers, this is needed because the
23792 indexer may have a different name in our base classes. Fixed the
23793 error reporting (no indexers at all, not get accessor, no
23794 overloaded match). Fixes bug #33089.
23795 (IndexerAccess.DoResolveLValue): Likewise.
23797 2002-11-14 Martin Baulig <martin@ximian.com>
23799 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23800 indexers. Fixes the first part of bug #33089.
23801 (MethodSignature.InheritableMemberSignatureCompare): Added support
23804 2002-11-13 Ravi Pratap <ravi@ximian.com>
23806 * attribute.cs (Attribute.Resolve): Catch the
23807 NullReferenceException and report it since it isn't supposed to
23810 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23812 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23813 LogicalOr and LogicalAnd that can benefit from recursively
23814 handling EmitBranchable. The code now should be nice for Paolo.
23816 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23818 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23819 the Type lookups, as we perform quite a number of lookups on
23820 non-Types. This can be removed once we can deterministically tell
23821 whether we have a type or a namespace in advance.
23823 But this might require special hacks from our corlib.
23827 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23828 and double which avoids a conversion from an integer to a double.
23830 * expression.cs: tiny optimization, avoid calling IsConstant,
23831 because it effectively performs the lookup twice.
23833 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23835 But a bogus return here to keep the semantics of the old code
23836 until the Mono runtime is fixed.
23838 * pending.cs (GetMissingInterfaces): New method used to remove all
23839 the interfaces that are already implemented by our parent
23840 classes from the list of pending methods.
23842 * interface.cs: Add checks for calls after ResolveTypeExpr.
23844 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23846 * class.cs (Class.Emit): Report warning 67: event not used if the
23847 warning level is beyond 3.
23849 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23850 being a NullLiteral.
23852 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23855 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23856 path that might fail if a type can not be resolved.
23858 * expression.cs (Binary.Emit): Emit unsigned versions of the
23861 * driver.cs: use error 5.
23863 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23865 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23867 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23869 * cs-parser.jay (switch_section): A beautiful patch from Martin
23870 Baulig that fixed 33094.
23872 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23874 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23875 Check whether the base is abstract and report an error if so.
23877 * expression.cs (IndexerAccess.DoResolveLValue,
23878 IndexerAccess.DoResolve): ditto.
23880 (Invocation.DoResolve): ditto.
23882 (Invocation.FullMethodDesc): Improve the report string.
23884 * statement.cs (Block): Eliminate IsVariableDefined as it is
23885 basically just a wrapper for GetVariableInfo.
23887 * ecore.cs (SimpleName): Use new
23889 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23890 type, as we return the actual parameter ref/unref state on a
23893 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23895 * support.cs: Return proper flags REF/OUT fixing the previous
23898 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23899 not used to mean `ref' but `ref or out' in ParameterReference
23901 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23902 full type signature instead of calling TypeManger.CSharpName
23905 * support.cs (InternalParameters.ParameterDesc): Do not compare
23906 directly to the modflags, because REF/OUT will actually be bitsets
23909 * delegate.cs (VerifyMethod): Check also the modifiers.
23911 * cs-tokenizer.cs: Fix bug where floating point values with an
23912 exponent where a sign was missing was ignored.
23914 * driver.cs: Allow multiple assemblies to be specified in a single
23917 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23919 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23920 because identifiers after a parenthesis would end up in this kind
23921 of production, and we needed to desamiguate it for having casts
23924 (UserDefinedType *) xxx
23926 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23928 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23929 we should set on the Bindingflags.NonPublic, but not turn on
23930 private_ok. private_ok controls whether a Private member is
23931 returned (this is chekced on the filter routine), while the
23932 BindingFlags.NonPublic just controls whether private/protected
23933 will be allowed. This fixes the problem part of the problem of
23934 private properties being allowed to be used in derived classes.
23936 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23937 so we can call the children DoResolveLValue method (this will
23938 properly signal errors on lvalue assignments to base properties)
23940 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23941 getter are null, and we have a property info, we know that this
23942 happened because the lookup failed, so we report an error 122 for
23943 protection level violation.
23945 We also silently return if setter and getter are null in the
23946 resolve functions, this condition only happens if we have flagged
23947 the error before. This is the other half of the problem.
23949 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23950 not have accessibility information, that is why we were returning
23951 true in the filter function in typemanager.cs.
23953 To properly report 122 (property is inaccessible because of its
23954 protection level) correctly, we report this error in ResolveAccess
23955 by failing if both the setter and the getter are lacking (ie, the
23958 DoResolve and DoLResolve have been modified to check for both
23959 setter/getter being null and returning silently, the reason being
23960 that I did not want to put the knowledge about this error in upper
23963 int old = Report.Errors;
23964 x = new PropertyExpr (...);
23965 if (old != Report.Errors)
23970 So the property expr is returned, but it is invalid, so the error
23971 will be flagged during the resolve process.
23973 * class.cs: Remove InheritablePropertySignatureCompare from the
23974 class, as we no longer depend on the property signature to compute
23975 whether it is possible to implement a method or not.
23977 The reason is that calling PropertyInfo.GetGetMethod will return
23978 null (in .NET, in Mono it works, and we should change this), in
23979 cases where the Get Method does not exist in that particular
23984 class X { public virtual int A { get { return 1; } } }
23986 class Z : Y { public override int A { get { return 2; } } }
23988 Would fail in Z because the parent (Y) would not have the property
23989 defined. So we avoid this completely now (because the alternative
23990 fix was ugly and slow), and we now depend exclusively on the
23993 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23994 reference method, instead of using the property.
23996 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23997 routines are gone now.
23999 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
24000 names, they were incorrectly named.
24002 * cs-tokenizer.cs: Return are more gentle token on failure.
24004 * pending.cs (PendingImplementation.InterfaceMethod): This routine
24005 had an out-of-sync index variable, which caused it to remove from
24006 the list of pending methods the wrong method sometimes.
24008 2002-10-22 Miguel de Icaza <miguel@ximian.com>
24010 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
24011 CanWrite, because those refer to this particular instance of the
24012 property, and do not take into account the fact that we can
24013 override single members of a property.
24015 Constructor requires an EmitContext. The resolution process does
24016 not happen here, but we need to compute the accessors before,
24017 because the resolution does not always happen for properties.
24019 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
24020 subclass, before we did not update this flag, but we did update
24023 (GetAccessors): Drop this routine, as it did not work in the
24024 presence of partially overwritten set/get methods.
24026 Notice that this broke the cs1540 detection, but that will require
24029 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24033 * driver.cs: issue a warning instead of an error if we don't support
24034 debugging for the platform. Also ignore a couple of errors that may
24035 arise when trying to write the symbols. Undo my previous patch.
24037 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24039 * driver.cs: ignore /debug switch except for Unix platforms.
24041 2002-10-23 Nick Drochak <ndrochak@gol.com>
24043 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
24045 2002-10-21 Miguel de Icaza <miguel@ximian.com>
24047 * driver.cs: Do not make mcs-debug conditional, so we do not break
24048 builds that use it.
24050 * statement.cs (UsageVector.MergeChildren): I would like Martin to
24051 review this patch. But basically after all the children variables
24052 have been merged, the value of "Breaks" was not being set to
24053 new_breaks for Switch blocks. I think that it should be set after
24054 it has executed. Currently I set this to the value of new_breaks,
24055 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
24056 conservative, but I do not understand this code very well.
24058 I did not break anything in the build, so that is good ;-)
24060 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
24062 2002-10-20 Mark Crichton <crichton@gimp.org>
24064 * cfold.cs: Fixed compile blocker. Really fixed it this time.
24066 2002-10-20 Nick Drochak <ndrochak@gol.com>
24068 * cfold.cs: Fixed compile blocker.
24070 2002-10-20 Miguel de Icaza <miguel@ximian.com>
24072 * driver.cs: I was chekcing the key, not the file.
24074 2002-10-19 Ravi Pratap <ravi@ximian.com>
24076 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
24077 message that we were generating - we just need to silently return
24080 2002-10-19 Miguel de Icaza <miguel@ximian.com>
24082 * class.cs (Event.Define): Change my previous commit, as this
24083 breaks the debugger. This is a temporary hack, as it seems like
24084 the compiler is generating events incorrectly to begin with.
24086 * expression.cs (Binary.ResolveOperator): Added support for
24087 "U operator - (E x, E y)"
24089 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
24092 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
24093 init-only variables, but this path did not take into account that
24094 there might be also instance readonly variables. Correct this
24097 This fixes bug 32253
24099 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
24102 * driver.cs: Change the extension for modules to `netmodule'
24104 * cs-parser.jay: Improved slightly the location tracking for
24105 the debugger symbols.
24107 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
24108 modifiers that were specified instead of the hardcoded value
24109 (FamAndAssem). This was basically ignoring the static modifier,
24110 and others. Fixes 32429.
24112 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
24113 fixed a bug in the process (32476)
24115 * expression.cs (ArrayAccess.EmitAssign): Patch from
24116 hwang_rob@yahoo.ca that fixes bug 31834.3
24118 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24120 * driver.cs: Make the module extension .netmodule.
24122 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24124 * driver.cs: Report an error if the resource file is not found
24125 instead of crashing.
24127 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24128 false, like Emit does.
24130 2002-10-16 Nick Drochak <ndrochak@gol.com>
24132 * typemanager.cs: Remove unused private member. Also reported mcs
24133 bug to report this as a warning like csc.
24135 2002-10-15 Martin Baulig <martin@gnome.org>
24137 * statement.cs (Statement.Emit): Made this a virtual method; emits
24138 the line number info and calls DoEmit().
24139 (Statement.DoEmit): New protected abstract method, formerly knows
24140 as Statement.Emit().
24142 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24144 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24146 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24147 have fixed a remaining problem: not every AddXXXX was adding a
24148 fully qualified name.
24150 Now everyone registers a fully qualified name in the DeclSpace as
24151 being defined instead of the partial name.
24153 Downsides: we are slower than we need to be due to the excess
24154 copies and the names being registered this way.
24156 The reason for this is that we currently depend (on the corlib
24157 bootstrap for instance) that types are fully qualified, because
24158 we dump all the types in the namespace, and we should really have
24159 types inserted into the proper namespace, so we can only store the
24160 basenames in the defined_names array.
24162 2002-10-10 Martin Baulig <martin@gnome.org>
24164 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24165 from bug #31834, see the bug report for a testcase which is
24168 2002-10-10 Martin Baulig <martin@gnome.org>
24170 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24171 flow analysis code for this.
24173 * statement.cs (Do, While, For): Tell the flow analysis code about
24175 (FlowBranching.UsageVector): Added support for infinite loops.
24176 (Block.Resolve): Moved the dead code elimination here and use flow
24179 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24181 * class.cs (Field.Define): Catch cycles on struct type
24184 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24185 fields if the fields are static. We only need to check instance
24188 * expression.cs (As.DoResolve): Test for reference type.
24190 * statement.cs (Using.ResolveExpression): Use
24191 ConvertImplicitRequired, not ConvertImplicit which reports an
24193 (Using.ResolveLocalVariableDecls): ditto.
24195 * expression.cs (Binary.ResolveOperator): Report errors in a few
24196 places where we had to.
24198 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24200 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24202 * expression.cs: Use StoreFromPtr instead of extracting the type
24203 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24205 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24206 an enumeration value to a System.Enum, but System.Enum is not a
24207 value type, but an class type, so we need to box.
24209 (Expression.ConvertExplicit): One codepath could return
24210 errors but not flag them. Fix this. Fixes #31853
24212 * parameter.cs (Resolve): Do not allow void as a parameter type.
24214 2002-10-06 Martin Baulig <martin@gnome.org>
24216 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24217 if it's a class type and not a struct. Fixes #31815.
24219 2002-10-06 Martin Baulig <martin@gnome.org>
24221 * statement.cs: Reworked the flow analysis code a bit to make it
24222 usable for dead code elimination.
24224 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24226 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24228 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24230 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24231 to fix the test 165, will investigate deeper.
24233 2002-10-04 Martin Baulig <martin@gnome.org>
24235 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24236 finally blocks actually work.
24237 (Try.Resolve): We don't need to create a sibling for `finally' if
24238 there is no finally block.
24240 2002-10-04 Martin Baulig <martin@gnome.org>
24242 * class.cs (Constructor.Define): The default accessibility for a
24243 non-default constructor is private, not public.
24245 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24247 * class.cs (Constructor): Make AllowedModifiers public, add
24250 * cs-parser.jay: Perform the modifiers test here, as the
24251 constructor for the Constructor class usually receives a zero
24252 because of the way we create it (first we create, later we
24253 customize, and we were never checking the modifiers).
24255 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24256 is a version of LookupTypeReflection that includes the type-name
24257 cache. This can be used as a fast path for functions that know
24258 the fully qualified name and are only calling into *.GetType() to
24259 obtain a composed type.
24261 This is also used by TypeManager.LookupType during its type
24264 (LookupType): We now also track the real type name, as sometimes
24265 we can get a quey for the real type name from things like
24266 ComposedCast. This fixes bug 31422.
24268 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24269 complete type fullname, it does not have to go through the type
24270 resolution system to obtain the composed version of the type (for
24271 obtaining arrays or pointers).
24273 (Conditional.Emit): Use the EmitBoolExpression to
24274 generate nicer code, as requested by Paolo.
24276 (ArrayCreation.CheckIndices): Use the patch from
24277 hwang_rob@yahoo.ca to validate the array initializers.
24279 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24281 * class.cs (ConstructorInitializer.Emit): simplify code by using
24282 Invocation.EmitCall, and at the same time, fix the bugs in calling
24283 parent constructors that took variable arguments.
24285 * ecore.cs (Expression.ConvertNumericExplicit,
24286 Expression.ImplicitNumericConversion): Remove the code that
24287 manually wrapped decimal (InternalTypeConstructor call is now gone
24290 * expression.cs (Cast.TryReduce): Also handle decimal types when
24291 trying to perform a constant fold on the type.
24293 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24295 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24296 that only turned off an error report, and did nothing else.
24298 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24300 * driver.cs: Handle and ignore /fullpaths
24302 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24304 * expression.cs (Binary.ResolveOperator): Catch the case where
24305 DoNumericPromotions returns true,
24307 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24309 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24311 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24314 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24316 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24317 conversion exists, but it is also required that the conversion be
24318 performed. This manifested in "(Type64Enum) 2".
24320 * class.cs (TypeManager.AddMethod): The fix is not to change
24321 AddEnum, because that one was using a fully qualified name (every
24322 DeclSpace derivative does), but to change the AddMethod routine
24323 that was using an un-namespaced name. This now correctly reports
24324 the duplicated name.
24326 Revert patch until I can properly fix it. The issue
24327 is that we have a shared Type space across all namespaces
24328 currently, which is wrong.
24330 Options include making the Namespace a DeclSpace, and merge
24331 current_namespace/current_container in the parser.
24333 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24335 * cs-parser.jay: Improve error reporting when we get a different
24336 kind of expression in local_variable_type and
24337 local_variable_pointer_type.
24339 Propagate this to avoid missleading errors being reported.
24341 * ecore.cs (ImplicitReferenceConversion): treat
24342 TypeManager.value_type as a target just like object_type. As
24347 Is valid, and needs to result in the int 1 being boxed before it
24348 is assigned to the value type v.
24350 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24351 to validate the enumeration name.
24353 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24354 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24355 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24357 * ecore.cs (TryImplicitIntConversion): When doing an
24358 implicit-enumeration-conversion, check if the type is 64-bits and
24359 perform a conversion before passing to EnumConstant.
24361 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24363 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24364 report ambiguous type references. Unlike the MS version, we
24365 report what the ambiguity is. Innovation at work ;-)
24367 (DeclSpace.FindType): Require a location argument to
24368 display when we display an ambiguous error.
24370 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24372 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24374 * expression.cs (EmitDynamicInitializers): Apply patch from
24375 hwang_rob@yahoo.ca that fixes the order in which we emit our
24378 2002-09-21 Martin Baulig <martin@gnome.org>
24380 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24381 delegate takes no arguments.
24383 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24385 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24388 * expression.cs: Extract the underlying type.
24390 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24392 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24394 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24396 * class.cs (TypeContainer.DefineType): We can not use the nice
24397 PackingSize with the size set to 1 DefineType method, because it
24398 will not allow us to define the interfaces that the struct
24401 This completes the fixing of bug 27287
24403 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24404 means also structs. This fixes part of the problem.
24405 (Expresion.ImplicitReferenceConversionExists): ditto.
24407 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24408 error if there were no errors reported during the type lookup
24409 process, to avoid duplicates or redundant errors. Without this
24410 you would get an ambiguous errors plus a type not found. We have
24411 beaten the user enough with the first error.
24413 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24416 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24417 during the resolution process, stop the lookup, this avoids
24418 repeated error reports (same error twice).
24420 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24422 * typemanager.cs (LookupType): Redo the type lookup code to match
24423 the needs of System.Reflection.
24425 The issue is that System.Reflection requires references to nested
24426 types to begin with a "+" sign instead of a dot. So toplevel
24427 types look like: "NameSpace.TopLevelClass", and nested ones look
24428 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24431 2002-09-19 Martin Baulig <martin@gnome.org>
24433 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24434 says that a method always returns or always throws an exception,
24435 don't report the CS0161.
24437 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24438 set `Returns = new_returns'.
24440 2002-09-19 Martin Baulig <martin@gnome.org>
24442 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24443 to an enum constant, check for a CS0176.
24445 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24447 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24448 for operators that must be in pairs and report errors.
24450 * ecore.cs (SimpleName.DoResolveType): During the initial type
24451 resolution process, when we define types recursively, we must
24452 check first for types in our current scope before we perform
24453 lookups in the enclosing scopes.
24455 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24457 (Invocation.VerifyArgumentsCompat): Call
24458 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24459 I thought we were supposed to always call this, but there are a
24460 few places in the code where we dont do it.
24462 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24464 * driver.cs: Add support in -linkres and -resource to specify the
24465 name of the identifier.
24467 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24469 * ecore.cs (StandardConversionExists): Sync with the conversion
24470 code: allow anything-* to void* conversions.
24472 (FindMostSpecificSource): Use an Expression argument
24473 instead of a Type, because we might be handed over a Literal which
24474 gets a few more implicit conversions that plain types do not. So
24475 this information was being lost.
24477 Also, we drop the temporary type-holder expression when not
24480 2002-09-17 Martin Baulig <martin@gnome.org>
24482 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24483 this is an explicit interface implementation.
24485 2002-09-17 Martin Baulig <martin@gnome.org>
24487 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24488 different `IndexerName' attributes.
24490 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24491 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24492 virtual CommonResolve().
24494 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24496 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24497 and convert that to the UnderlyingType.
24499 * statement.cs (Foreach.Resolve): Indexers are just like variables
24500 or PropertyAccesses.
24502 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24503 inside quoted strings, we were not doing this before.
24505 2002-09-16 Martin Baulig <martin@gnome.org>
24507 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24508 resolve it. This is needed for the definite assignment check of the
24509 instance expression, fixes bug #29846.
24510 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24512 2002-09-16 Nick Drochak <ndrochak@gol.com>
24514 * parameter.cs: Fix compile error. Cannot reference static member
24515 from an instance object. Is this an mcs bug?
24517 2002-09-14 Martin Baulig <martin@gnome.org>
24519 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24520 multiple times. Fixes bug #30295, added test-166.cs.
24522 2002-09-14 Martin Baulig <martin@gnome.org>
24524 * statement.cs (Block.Emit): Don't emit unreachable code.
24525 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24526 `break' statements.
24527 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24529 2002-09-14 Martin Baulig <martin@gnome.org>
24531 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24534 2002-09-14 Martin Baulig <martin@gnome.org>
24536 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24537 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24538 be false on the ms runtime.
24540 2002-09-13 Martin Baulig <martin@gnome.org>
24542 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24543 the CS0038 error message.
24545 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24547 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24548 constant inside, return it.
24550 2002-09-12 Martin Baulig <martin@gnome.org>
24552 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24553 implicit conversion can be done between enum types.
24555 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24556 check whether an implicit conversion to the current enum's UnderlyingType
24557 exists and report an error if not.
24559 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24560 without debugging support.
24562 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24563 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24565 2002-09-12 Martin Baulig <martin@gnome.org>
24567 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24569 * ecore.cs (IMemberExpr.DeclaringType): New property.
24570 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24571 nonstatic member of an outer type (CS0038).
24573 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24575 * driver.cs: Activate the using-error detector at warning level
24576 4 (at least for MS-compatible APIs).
24578 * namespace.cs (VerifyUsing): Small buglett fix.
24580 * pending.cs (PendingImplementation): pass the container pointer.
24582 * interface.cs (GetMethods): Allow for recursive definition. Long
24583 term, I would like to move every type to support recursive
24584 definitions, not the current ordering mechanism that we have right
24587 The situation is this: Attributes are handled before interfaces,
24588 so we can apply attributes to interfaces. But some attributes
24589 implement interfaces, we will now handle the simple cases
24590 (recursive definitions will just get an error).
24592 * parameter.cs: Only invalidate types at the end if we fail to
24595 2002-09-09 Martin Baulig <martin@gnome.org>
24597 * ecore.cs (PropertyExpr.Emit): Also check for
24598 TypeManager.system_int_array_get_length so this'll also work when
24599 compiling corlib. Fixes #30003.
24601 2002-09-09 Martin Baulig <martin@gnome.org>
24603 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24604 and throw an exception if we can't get the type's size. Fixed #30040,
24607 2002-09-09 Martin Baulig <martin@gnome.org>
24609 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24611 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24612 context. Fixes bug #30027.
24614 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24615 virtual functions. Fixes bug #30043, added test-164.cs.
24617 2002-09-08 Ravi Pratap <ravi@ximian.com>
24619 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24621 2002-09-08 Nick Drochak <ndrochak@gol.com>
24623 * driver.cs: Use an object to get the windows codepage since it's not a
24626 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24628 * statement.cs (For.Emit): for infinite loops (test == null)
24629 return whether there is a break inside, not always "true".
24631 * namespace.cs (UsingEntry): New struct to hold the name of the
24632 using definition, the location where it is defined, and whether it
24633 has been used in a successful type lookup.
24635 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24640 2002-09-06 Ravi Pratap <ravi@ximian.com>
24642 * attribute.cs : Fix incorrect code which relied on catching
24643 a NullReferenceException to detect a null being passed in
24644 where an object was expected.
24646 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24648 * statement.cs (Try): flag the catch variable as assigned
24650 * expression.cs (Cast): Simplified by using ResolveType instead of
24651 manually resolving.
24653 * statement.cs (Catch): Fix bug by using ResolveType.
24655 2002-09-06 Ravi Pratap <ravi@ximian.com>
24657 * expression.cs (BetterConversion): Special case for when we have
24658 a NullLiteral as the argument and we have to choose between string
24659 and object types - we choose string the way csc does.
24661 * attribute.cs (Attribute.Resolve): Catch the
24662 NullReferenceException and report error #182 since the Mono
24663 runtime no more has the bug and having this exception raised means
24664 we tried to select a constructor which takes an object and is
24667 2002-09-05 Ravi Pratap <ravi@ximian.com>
24669 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24670 message (1502, 1503) when we can't locate a method after overload
24671 resolution. This is much more informative and closes the bug
24674 * interface.cs (PopulateMethod): Return if there are no argument
24675 types. Fixes a NullReferenceException bug.
24677 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24678 expressions too. Previously we were checking only in one place for
24679 positional arguments leaving out named arguments.
24681 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24682 type to the enum type is not allowed. Remove code corresponding to
24685 (ConvertNumericExplicit): Allow explicit conversions from
24686 the underlying type to enum type. This precisely follows the spec
24687 and closes a bug filed by Gonzalo.
24689 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24692 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24694 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24696 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24697 it was important that we stored the right value after the
24698 reduction in `converted'.
24700 2002-09-04 Martin Baulig <martin@gnome.org>
24702 * location.cs (Location.SymbolDocument): Use full pathnames for the
24705 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24707 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24708 of the expression resolve mechanism, because that will catch the
24709 SimpleName error failures.
24711 (Conditional): If we can not resolve the
24712 expression, return, do not crash.
24714 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24717 (location): display token name instead of its number.
24719 2002-08-28 Martin Baulig <martin@gnome.org>
24721 * expression.cs (Binary.ResolveOperator): Don't silently return
24722 but return an error if an operator cannot be applied between two
24725 2002-08-28 Martin Baulig <martin@gnome.org>
24727 * class.cs (Constructor.Define): Set the permission attributes
24728 correctly instead of making all constructors public.
24730 2002-08-28 Martin Baulig <martin@gnome.org>
24732 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24733 for private members before reporting a CS0103; if we find anything,
24736 2002-08-28 Martin Baulig <martin@gnome.org>
24738 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24739 to check whether `closure_start_type == closure_invocation_type',
24740 we also need to check whether `m.DeclaringType == closure_invocation_type'
24741 before bypassing the permission checks. We might be accessing
24742 protected/private members from the base class.
24743 (TypeManager.RealMemberLookup): Only set private_ok if private
24744 members were requested via BindingFlags.NonPublic.
24746 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24748 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24749 MethodGroupExpr.IsExplicitImpl if appropriate.
24750 (Invocation.DoResolve): Don't report the CS0120 for explicit
24751 interface implementations.
24753 2002-08-27 Martin Baulig <martin@gnome.org>
24755 * expression.cs (Invocation.DoResolve): If this is a static
24756 method and we don't have an InstanceExpression, we must report
24759 2002-08-25 Martin Baulig <martin@gnome.org>
24761 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24762 `==' between a valuetype and an object.
24764 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24766 * ecore.cs (TypeExpr): Provide a ToString method.
24768 2002-08-24 Martin Baulig <martin@gnome.org>
24770 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24771 now called proggie.dbg and it's a binary file.
24773 2002-08-23 Martin Baulig <martin@gnome.org>
24775 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24777 2002-08-23 Martin Baulig <martin@gnome.org>
24779 * struct.cs (MyStructInfo.ctor): Make this work with empty
24780 structs; it's not allowed to use foreach() on null.
24782 2002-08-23 Martin Baulig <martin@gnome.org>
24784 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24785 writer the full pathname of the generated assembly.
24787 2002-08-23 Martin Baulig <martin@gnome.org>
24789 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24790 A `finally' block never returns or breaks; improved handling of
24793 2002-08-23 Martin Baulig <martin@gnome.org>
24795 * statement.cs (Throw.Resolve): Allow `throw null'.
24797 2002-08-23 Martin Baulig <martin@gnome.org>
24799 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24800 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24801 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24802 MemberLookup would return a wrong event if this is an explicit
24803 interface implementation and the class has an event with the same
24806 2002-08-23 Martin Baulig <martin@gnome.org>
24808 * statement.cs (Block.AddChildVariableNames): New public method.
24809 (Block.AddChildVariableName): Likewise.
24810 (Block.IsVariableNameUsedInChildBlock): Likewise.
24811 (Block.AddVariable): Check whether a variable name has already
24812 been used in a child block.
24814 * cs-parser.jay (declare_local_variables): Mark all variable names
24815 from the current block as being used in a child block in the
24818 2002-08-23 Martin Baulig <martin@gnome.org>
24820 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24821 find the symbol writer.
24823 * driver.cs: csc also allows the arguments to /define being
24824 separated by commas, not only by semicolons.
24826 2002-08-23 Martin Baulig <martin@gnome.org>
24828 * interface.cs (Interface.GetMembers): Added static check for events.
24830 2002-08-15 Martin Baulig <martin@gnome.org>
24832 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24833 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24835 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24836 why the MethodData.EmitDestructor() change was necessary.
24838 2002-08-20 Martin Baulig <martin@gnome.org>
24840 * class.cs (TypeContainer.FindMembers): Added static check for events.
24842 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24844 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24845 use Type.GetEvents(), not Type.FindMembers().
24847 2002-08-20 Martin Baulig <martin@gnome.org>
24849 * decl.cs (MemberCache): Added a special method cache which will
24850 be used for method-only searched. This ensures that a method
24851 search will return a MethodInfo with the correct ReflectedType for
24854 2002-08-20 Martin Baulig <martin@gnome.org>
24856 * decl.cs (DeclSpace.FindMembers): Made this public.
24858 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24860 * delegate.cs: fixed build on windows.
24861 [FIXME: Filed as bug #29150: MCS must report these errors.]
24863 2002-08-19 Ravi Pratap <ravi@ximian.com>
24865 * ecore.cs (StandardConversionExists): Return a false
24866 if we are trying to convert the void type to anything else
24867 since that is not allowed.
24869 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24870 we flag error 70 in the event an event is trying to be accessed
24871 directly from outside the declaring type.
24873 2002-08-20 Martin Baulig <martin@gnome.org>
24875 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24876 MemberCache from typemanager.cs to decl.cs.
24878 2002-08-19 Martin Baulig <martin@gnome.org>
24880 * class.cs (TypeContainer): Implement IMemberContainer.
24881 (TypeContainer.DefineMembers): Create the MemberCache.
24882 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24883 return public members if BindingFlags.Public was given, check
24884 whether members are static.
24886 2002-08-16 Martin Baulig <martin@gnome.org>
24888 * decl.cs (DeclSpace.Define): Splitted this in Define and
24889 DefineMembers. DefineMembers is called first and initializes the
24892 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24893 DefineMembers() on all our DeclSpaces.
24895 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24896 but call DefineMembers() on all nested interfaces. We call their
24897 Define() in our new Define() function.
24899 * interface.cs (Interface): Implement IMemberContainer.
24900 (Interface.Define): Moved all code except the attribute stuf to
24902 (Interface.DefineMembers): Initialize the member cache.
24904 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24905 need this anymore since we can use MemberCache.FindMembers directly.
24907 2002-08-19 Martin Baulig <martin@gnome.org>
24909 * typemanager.cs (MemberCache): When creating the cache for an
24910 interface type, add all inherited members.
24911 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24912 to `out bool used_cache' and documented it.
24913 (TypeManager.MemberLookup): If we already used the cache in the first
24914 iteration, we don't need to do the interfaces check.
24916 2002-08-19 Martin Baulig <martin@gnome.org>
24918 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24919 here from IMemberFinder and don't implement this interface anymore.
24920 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24922 * typemanager.cs (IMemberFinder): This interface is now only used by
24923 classes which actually support the member cache.
24924 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24925 since we only put DeclSpaces into this Hashtable.
24926 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24927 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24929 2002-08-16 Martin Baulig <martin@gnome.org>
24931 * typemanager.cs (ICachingMemberFinder): Removed.
24932 (IMemberFinder.MemberCache): New property.
24933 (TypeManager.FindMembers): Merged this with RealFindMembers().
24934 This function will never be called from TypeManager.MemberLookup()
24935 so we can't use the cache here, just the IMemberFinder.
24936 (TypeManager.MemberLookup_FindMembers): Check whether the
24937 IMemberFinder has a MemberCache and call the cache's FindMembers
24939 (MemberCache): Rewrote larger parts of this yet another time and
24940 cleaned it up a bit.
24942 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24944 * driver.cs (LoadArgs): Support quoting.
24946 (Usage): Show the CSC-like command line arguments.
24948 Improved a few error messages.
24950 2002-08-15 Martin Baulig <martin@gnome.org>
24952 * typemanager.cs (IMemberContainer.Type): New property.
24953 (IMemberContainer.IsInterface): New property.
24955 The following changes are conditional to BROKEN_RUNTIME, which is
24956 defined at the top of the file.
24958 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24959 class'es members, but add all members from TypeHandle.ObjectType
24960 if we're an interface.
24961 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24962 is the current type.
24963 (MemberCache.CacheEntry.Container): Removed this field.
24964 (TypeHandle.GetMembers): Include inherited members.
24966 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24968 * typemanager.cs: fixed compilation and added a comment on a field that
24971 2002-08-15 Martin Baulig <martin@gnome.org>
24973 * class.cs (ConstructorInitializer.Resolve): In the
24974 Expression.MemberLookup call, use the queried_type as
24977 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24978 declared' attribute, it's always true.
24979 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24980 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24981 temporary wrapper for FindMembers which tells MemberLookup whether
24982 members from the base classes are included in the return value.
24983 This will go away soon.
24984 (TypeManager.MemberLookup): Use this temporary hack here; once the
24985 new MemberCache is completed, we don't need to do the DeclaredOnly
24986 looping here anymore since the MemberCache will take care of this.
24987 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24988 (MemberCache): When creating the MemberCache for a class, get
24989 members from the current class and all its base classes.
24990 (MemberCache.CacheEntry.Container): New field. This is a
24991 temporary hack until the Mono runtime is fixed to distinguish
24992 between ReflectedType and DeclaringType. It allows us to use MCS
24993 with both the MS runtime and the unfixed Mono runtime without
24994 problems and without accecting performance.
24995 (MemberCache.SearchMembers): The DeclaredOnly looping from
24996 TypeManager.MemberLookup is now done here.
24998 2002-08-14 Martin Baulig <martin@gnome.org>
25000 * statement.cs (MyStructInfo.MyStructInfo): Don't call
25001 Type.GetFields on dynamic types but get the fields from the
25002 corresponding TypeContainer.
25003 (MyStructInfo.GetStructInfo): Added check for enum types.
25005 * typemanager.cs (MemberList.IsSynchronized): Implemented.
25006 (MemberList.SyncRoot): Implemented.
25007 (TypeManager.FilterWithClosure): No need to check permissions if
25008 closure_start_type == closure_invocation_type, don't crash if
25009 closure_invocation_type is null.
25011 2002-08-13 Martin Baulig <martin@gnome.org>
25013 Rewrote TypeContainer.FindMembers to use a member cache. This
25014 gives us a speed increase of about 35% for the self-hosting MCS
25015 build and of about 15-20% for the class libs (both on GNU/Linux).
25017 * report.cs (Timer): New class to get enhanced profiling. This
25018 whole class is "TIMER" conditional since it remarkably slows down
25021 * class.cs (MemberList): New class. This is an IList wrapper
25022 which we're now using instead of passing MemberInfo[]'s around to
25023 avoid copying this array unnecessarily.
25024 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
25025 (ICachingMemberFinder, IMemberContainer): New interface.
25026 (TypeManager.FilterWithClosure): If `criteria' is null, the name
25027 has already been checked, otherwise use it for the name comparision.
25028 (TypeManager.FindMembers): Renamed to RealMemberFinder and
25029 provided wrapper which tries to use ICachingMemberFinder.FindMembers
25030 if possible. Returns a MemberList, not a MemberInfo [].
25031 (TypeHandle): New class, implements IMemberContainer. We create
25032 one instance of this class per type, it contains a MemberCache
25033 which is used to do the member lookups.
25034 (MemberCache): New class. Each instance of this class contains
25035 all members of a type and a name-based hash table.
25036 (MemberCache.FindMembers): This is our new member lookup
25037 function. First, it looks up all members of the requested name in
25038 the hash table. Then, it walks this list and sorts out all
25039 applicable members and returns them.
25041 2002-08-13 Martin Baulig <martin@gnome.org>
25043 In addition to a nice code cleanup, this gives us a performance
25044 increase of about 1.4% on GNU/Linux - not much, but it's already
25045 half a second for the self-hosting MCS compilation.
25047 * typemanager.cs (IMemberFinder): New interface. It is used by
25048 TypeManager.FindMembers to call FindMembers on a TypeContainer,
25049 Enum, Delegate or Interface.
25050 (TypeManager.finder_to_member_finder): New PtrHashtable.
25051 (TypeManager.finder_to_container): Removed.
25052 (TypeManager.finder_to_delegate): Removed.
25053 (TypeManager.finder_to_interface): Removed.
25054 (TypeManager.finder_to_enum): Removed.
25056 * interface.cs (Interface): Implement IMemberFinder.
25058 * delegate.cs (Delegate): Implement IMemberFinder.
25060 * enum.cs (Enum): Implement IMemberFinder.
25062 * class.cs (TypeContainer): Implement IMemberFinder.
25064 2002-08-12 Martin Baulig <martin@gnome.org>
25066 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
25068 2002-08-12 Martin Baulig <martin@gnome.org>
25070 * ecore.cs (ITypeExpression): New interface for expressions which
25072 (TypeExpression): Renamed to TypeLookupExpression.
25073 (Expression.DoResolve): If we're doing a types-only lookup, the
25074 expression must implement the ITypeExpression interface and we
25075 call DoResolveType() on it.
25076 (SimpleName): Implement the new ITypeExpression interface.
25077 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
25078 hack, the situation that we're only looking up types can't happen
25079 anymore when this method is called. Moved the type lookup code to
25080 DoResolveType() and call it.
25081 (SimpleName.DoResolveType): This ITypeExpression interface method
25082 is now doing the types-only lookup.
25083 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
25084 (ResolveFlags): Added MaskExprClass.
25086 * expression.cs (MemberAccess): Implement the ITypeExpression
25088 (MemberAccess.DoResolve): Added support for a types-only lookup
25089 when we're called via ITypeExpression.DoResolveType().
25090 (ComposedCast): Implement the ITypeExpression interface.
25092 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
25093 Expression.Resolve() with ResolveFlags.Type instead.
25095 2002-08-12 Martin Baulig <martin@gnome.org>
25097 * interface.cs (Interface.Define): Apply attributes.
25099 * attribute.cs (Attribute.ApplyAttributes): Added support for
25100 interface attributes.
25102 2002-08-11 Martin Baulig <martin@gnome.org>
25104 * statement.cs (Block.Emit): Only check the "this" variable if we
25105 do not always throw an exception.
25107 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
25108 whether the property has a set accessor.
25110 2002-08-11 Martin Baulig <martin@gnome.org>
25112 Added control flow analysis support for structs.
25114 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25115 with control flow analysis turned off.
25116 (IVariable): New interface.
25117 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25118 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25119 (FieldExpr.DoResolve): Resolve the instance expression with flow
25120 analysis turned off and do the definite assignment check after the
25121 resolving when we know what the expression will resolve to.
25123 * expression.cs (LocalVariableReference, ParameterReference):
25124 Implement the new IVariable interface, only call the flow analysis
25125 code if ec.DoFlowAnalysis is true.
25126 (This): Added constructor which takes a Block argument. Implement
25127 the new IVariable interface.
25128 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25129 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25130 This does the definite assignment checks for struct members.
25132 * class.cs (Constructor.Emit): If this is a non-static `struct'
25133 constructor which doesn't have any initializer, call
25134 Block.AddThisVariable() to tell the flow analysis code that all
25135 struct elements must be initialized before control returns from
25138 * statement.cs (MyStructInfo): New public class.
25139 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25140 argument to this indexer. If non-zero, check an individual struct
25141 member, not the whole struct.
25142 (FlowBranching.CheckOutParameters): Check struct members.
25143 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25144 overloaded versions of these methods which take an additional
25145 `int field_idx' argument to check struct members.
25146 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25147 overloaded versions of these methods which take an additional
25148 `string field_name' argument to check struct member.s
25149 (VariableInfo): Implement the IVariable interface.
25150 (VariableInfo.StructInfo): New public property. Returns the
25151 MyStructInfo instance of the variable if it's a struct or null.
25152 (Block.AddThisVariable): New public method. This is called from
25153 Constructor.Emit() for non-static `struct' constructor which do
25154 not have any initializer. It creates a special variable for the
25155 "this" instance variable which will be checked by the flow
25156 analysis code to ensure that all of the struct's fields are
25157 initialized before control returns from the constructor.
25158 (UsageVector): Added support for struct members. If a
25159 variable/parameter is a struct with N members, we reserve a slot
25160 in the usage vector for each member. A struct is considered fully
25161 initialized if either the struct itself (slot 0) or all its
25162 members are initialized.
25164 2002-08-08 Martin Baulig <martin@gnome.org>
25166 * driver.cs (Driver.MainDriver): Only report an error CS5001
25167 if there were no compilation errors.
25169 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25170 `UnsafeContext' property to determine whether the parent is in
25171 unsafe context rather than checking the parent's ModFlags:
25172 classes nested in an unsafe class are unsafe as well.
25174 2002-08-08 Martin Baulig <martin@gnome.org>
25176 * statement.cs (UsageVector.MergeChildren): Distinguish between
25177 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25178 we return. Added test17() and test18() to test-154.cs.
25180 2002-08-08 Martin Baulig <martin@gnome.org>
25182 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25183 Family access, make sure the invoking type isn't a subclass of the
25184 queried type (that'd be a CS1540).
25186 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25187 this method which takes an additional `Type invocation_type'.
25189 * expression.cs (BaseAccess.DoResolve): Use the base type as
25190 invocation and query type.
25191 (MemberAccess.DoResolve): If the lookup failed and we're about to
25192 report a CS0122, try a lookup with the ec.ContainerType - if this
25193 succeeds, we must report a CS1540.
25195 2002-08-08 Martin Baulig <martin@gnome.org>
25197 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25198 (MethodGroupExpr): Implement the IMemberExpr interface.
25200 * expression (MemberAccess.ResolveMemberAccess): No need to have
25201 any special code for MethodGroupExprs anymore, they're now
25204 2002-08-08 Martin Baulig <martin@gnome.org>
25206 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25207 Family, FamANDAssem and FamORAssem permissions.
25208 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25210 2002-08-08 Martin Baulig <martin@gnome.org>
25212 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25213 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25216 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25218 * driver.cs: implemented /resource option to embed managed resources.
25220 2002-08-07 Martin Baulig <martin@gnome.org>
25222 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25223 (FieldBase.HasFieldInitializer): New public property.
25224 (FieldBase.GetInitializerExpression): New public method. Resolves and
25225 returns the field initializer and makes sure it is only resolved once.
25226 (TypeContainer.EmitFieldInitializers): Call
25227 FieldBase.GetInitializerExpression to get the initializer, this ensures
25228 that it isn't resolved multiple times.
25230 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25231 the resolving process (SimpleName/MemberLookup) that we're currently
25232 emitting a field initializer (which must not access any instance members,
25233 this is an error CS0236).
25235 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25236 argument, if the `IsFieldInitializer' flag is set, we must report and
25237 error CS0236 and not an error CS0120.
25239 2002-08-07 Martin Baulig <martin@gnome.org>
25241 * ecore.cs (IMemberExpr): New public interface.
25242 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25243 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25244 if the expression is an IMemberExpr.
25246 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25247 to be null, implicitly default to `this' if we're non-static in
25248 this case. Simplified the code a lot by using the new IMemberExpr
25249 interface. Also fixed bug #28176 here.
25251 2002-08-06 Martin Baulig <martin@gnome.org>
25253 * cs-parser.jay (SimpleLookup): Removed. We need to create
25254 ParameterReferences during semantic analysis so that we can do a
25255 type-only search when resolving Cast, TypeOf and SizeOf.
25256 (block): Pass the `current_local_parameters' to the Block's
25259 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25260 argument to the constructor.
25261 (ConstructorInitializer.Resolve): Create a temporary implicit
25262 block with the parameters.
25264 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25265 references here if we aren't doing a type-only search.
25267 * statement.cs (Block): Added constructor which takes a
25268 `Parameters parameters' argument.
25269 (Block.Parameters): New public property.
25271 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25272 to `Parameters' and made it public readonly.
25274 2002-08-06 Martin Baulig <martin@gnome.org>
25276 * ecore.cs (Expression.Warning): Made this public as well.
25278 * report.cs (Report.Debug): Print the contents of collections.
25280 2002-08-06 Martin Baulig <martin@gnome.org>
25282 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25283 used to tell Resolve() which kinds of expressions it may return.
25284 (Expression.Resolve): Added overloaded version of this method which
25285 takes a `ResolveFlags flags' argument. This can be used to tell
25286 Resolve() which kinds of expressions it may return. Reports a
25288 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25289 ResolveFlags.SimpleName.
25290 (Expression.Error118): Added overloaded version of this method which
25291 takes a `ResolveFlags flags' argument. It uses the flags to determine
25292 which kinds of expressions are allowed.
25294 * expression.cs (Argument.ResolveMethodGroup): New public method.
25295 Resolves an argument, but allows a MethodGroup to be returned.
25296 This is used when invoking a delegate.
25298 * TODO: Updated a bit.
25300 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25302 Fixed compilation with csc.
25304 * ecore.cs: Expression.Error made public. Is this correct? Should
25305 Warning be made public too?
25307 * expression.cs: use ea.Location instead of ea.loc.
25308 [FIXME: Filed as bug #28607: MCS must report these errors.]
25310 2002-08-06 Martin Baulig <martin@gnome.org>
25312 * ecore.cs (Expression.loc): Moved the location here instead of
25313 duplicating it in all derived classes.
25314 (Expression.Location): New public property.
25315 (Expression.Error, Expression.Warning): Made them non-static and
25316 removed the location argument.
25317 (Expression.Warning): Added overloaded version which takes an
25318 `int level' argument.
25319 (Expression.Error118): Make this non-static and removed the
25320 expression and location arguments.
25321 (TypeExpr): Added location argument to the constructor.
25323 * expression.cs (StaticCallExpr): Added location argument to
25325 (Indirection, PointerArithmetic): Likewise.
25326 (CheckedExpr, UnCheckedExpr): Likewise.
25327 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25328 (StringPtr): Likewise.
25331 2002-08-05 Martin Baulig <martin@gnome.org>
25333 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25335 * assign.cs (Assign.DoResolve): Check whether the source
25336 expression is a value or variable.
25338 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25339 while resolving the corresponding blocks.
25341 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25342 an error, don't silently return null.
25344 * statement.cs (Block.AddVariable): Do the error reporting here
25345 and distinguish between CS0128 and CS0136.
25346 (Block.DoResolve): Report all unused labels (warning CS0164).
25347 (LabeledStatement): Pass the location to the constructor.
25348 (LabeledStatement.HasBeenReferenced): New property.
25349 (LabeledStatement.Resolve): Set it to true here.
25351 * statement.cs (Return.Emit): Return success even after reporting
25352 a type mismatch error (CS0126 or CS0127), this is what csc does and
25353 it avoids confusing the users with any consecutive errors.
25355 2002-08-05 Martin Baulig <martin@gnome.org>
25357 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25359 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25361 * expression.cs (MemberAccess.DoResolve): Silently return if an
25362 error has already been reported.
25364 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25365 error has already been reported.
25367 2002-08-05 Martin Baulig <martin@gnome.org>
25369 * statement.cs (UsageVector): Only initialize the `parameters'
25370 vector if we actually have any "out" parameters.
25372 2002-08-05 Martin Baulig <martin@gnome.org>
25374 * expression.cs (Binary.ResolveOperator): When combining delegates,
25375 they must have the same type.
25377 2002-08-05 Martin Baulig <martin@gnome.org>
25379 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25380 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25381 work with the ms runtime and we also don't need it: if we're a
25382 PropertyBuilder and not in the `indexer_arguments' hash, then we
25383 are a property and not an indexer.
25385 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25386 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25387 since the latter one doesn't work with the ms runtime.
25389 2002-08-03 Martin Baulig <martin@gnome.org>
25391 Fixed bugs #27998 and #22735.
25393 * class.cs (Method.IsOperator): New public field.
25394 (Method.CheckBase): Report CS0111 if there's already a method
25395 with the same parameters in the current class. Report CS0508 when
25396 attempting to change the return type of an inherited method.
25397 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25398 and it's not marked abstract or extern.
25399 (PropertyBase): New abstract base class for Property and Indexer.
25400 (PropertyBase.CheckBase): Moved here from Property and made it work
25402 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25403 the same so we can reuse it there.
25404 (Property, Indexer): Derive from PropertyBase.
25405 (MethodSignature.inheritable_property_signature_filter): New delegate
25406 to find properties and indexers.
25408 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25409 argument and improved error reporting.
25411 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25412 EmptyReadOnlyParameters and made it a property.
25414 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25415 version of this method which takes a `PropertyInfo indexer'.
25416 (TypeManager.RegisterIndexer): New method.
25418 * class.cs: Added myself as author of this file :-)
25420 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25422 * class.cs: fixed compilation on windoze.
25424 2002-08-03 Martin Baulig <martin@gnome.org>
25426 * interface.cs (Interface.GetInterfaceBases): Check whether all
25427 base interfaces are at least as accessible than the current one.
25429 * class.cs (TypeContainer.GetClassBases): Check whether base types
25430 are at least as accessible than the current type.
25431 (TypeContainer.AsAccessible): Implemented and made non-static.
25432 (MemberBase.CheckParameters): Report errors if the accessibility
25435 * delegate.cs (Delegate.Delegate): The default visibility is
25436 internal for top-level types and private for nested types.
25437 (Delegate.Define): Report errors if the accessibility checks fail.
25439 * enum.cs (Enum.Enum): The default visibility is internal for
25440 top-level types and private for nested types.
25441 (Enum.DefineType): Compute the correct visibility.
25443 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25444 function which takes a `bool is_toplevel' instead of a TypeContainer.
25446 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25449 2002-08-02 Martin Baulig <martin@gnome.org>
25451 * expression.cs (LocalVariableReferenc): Added constructor which
25452 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25453 (LocalVariableReference.IsReadOnly): New property.
25454 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25455 variable is readonly, use our own readonly flag to do this; you can
25456 use the new constructor to get a writable reference to a read-only
25459 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25460 reference to the local variable.
25462 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25464 * rootcontext.cs (ResolveCore): Also include System.Exception
25466 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25467 we reach an EmptyStatement.
25469 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25472 * expression.cs (Binary.ResolveOperator): Check error result in
25475 use brtrue/brfalse directly and avoid compares to null.
25477 2002-08-02 Martin Baulig <martin@gnome.org>
25479 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25480 Fixes bug #28407, added test-155.cs.
25482 2002-08-01 Martin Baulig <martin@gnome.org>
25484 * class.cs (Event.EmitDefaultMethod): Make this work with static
25485 events. Fixes #28311, added verify-3.cs.
25487 2002-08-01 Martin Baulig <martin@gnome.org>
25489 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25490 `is_disposable' fields.
25491 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25492 `hm.is_disposable' if we're using the collection pattern.
25493 (Foreach.EmitCollectionForeach): Use the correct type for the
25494 enumerator's local variable, only emit the try/finally block if
25495 necessary (fixes #27713).
25497 2002-08-01 Martin Baulig <martin@gnome.org>
25499 * ecore.cs (Expression.report118): Renamed to Error118 and made
25502 * statement.cs (Throw.Resolve): Check whether the expression is of
25503 the correct type (CS0118) and whether the type derives from
25504 System.Exception (CS0155).
25505 (Catch.Resolve): New method. Do the type lookup here and check
25506 whether it derives from System.Exception (CS0155).
25507 (Catch.CatchType, Catch.IsGeneral): New public properties.
25509 * typemanager.cs (TypeManager.exception_type): Added.
25511 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25513 * driver.cs: Updated About function.
25515 2002-07-31 Martin Baulig <martin@gnome.org>
25517 Implemented Control Flow Analysis.
25519 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25520 (EmitContext.CurrentBranching): Added.
25521 (EmitContext.StartFlowBranching): Added.
25522 (EmitContext.EndFlowBranching): Added.
25523 (EmitContext.KillFlowBranching): Added.
25524 (EmitContext.IsVariableAssigned): Added.
25525 (EmitContext.SetVariableAssigned): Added.
25526 (EmitContext.IsParameterAssigned): Added.
25527 (EmitContext.SetParameterAssigned): Added.
25528 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25529 Added control flow analysis stuff here.
25531 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25532 resolve the expression as lvalue.
25533 (LocalVariableReference.DoResolve): Check whether the variable has
25534 already been assigned.
25535 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25536 the parameter as assigned here.
25537 (ParameterReference.DoResolve): Check whether the parameter has already
25539 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25540 expression as lvalue.
25542 * statement.cs (FlowBranching): New class for the flow analysis code.
25543 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25544 (LabeledStatement.IsDefined): New public property.
25545 (LabeledStatement.AddUsageVector): New public method to tell flow
25546 analyis that the label may be reached via a forward jump.
25547 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25549 (VariableInfo.Number): New public field. This is used by flow analysis
25550 to number all locals of a block.
25551 (Block.CountVariables): New public property. This is the number of
25552 local variables in this block (including the locals from all parent
25554 (Block.EmitMeta): Number all the variables.
25556 * statement.cs: Added flow analysis support to all classes.
25558 2002-07-31 Martin Baulig <martin@gnome.org>
25560 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25561 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25562 then use this argument.
25564 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25566 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25567 use this to specify /define options.
25569 2002-07-29 Martin Baulig <martin@gnome.org>
25571 * statement.cs (Fixed): Moved all code that does variable lookups
25572 and resolvings from Emit to Resolve.
25574 * statement.cs (For): Moved all code that does variable lookups
25575 and resolvings from Emit to Resolve.
25577 * statement.cs (Using): Moved all code that does variable lookups
25578 and resolvings from Emit to Resolve.
25580 2002-07-29 Martin Baulig <martin@gnome.org>
25582 * attribute.cs (Attribute.Resolve): Explicitly catch a
25583 System.NullReferenceException when creating the
25584 CustromAttributeBuilder and report a different warning message.
25586 2002-07-29 Martin Baulig <martin@gnome.org>
25588 * support.cs (ParameterData.ParameterName): Added method to
25589 get the name of a parameter.
25591 * typemanager.cs (TypeManager.IsValueType): New public method.
25593 2002-07-29 Martin Baulig <martin@gnome.org>
25595 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25596 is a flag which specifies that it's either ref or out.
25597 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25598 the out parameter to `out Parameter.Modifier mod', also set the
25599 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25601 * support.cs (InternalParameters.ParameterModifier): Distinguish
25602 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25603 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25605 * expression.cs (Argument.GetParameterModifier): Distinguish
25606 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25607 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25609 2002-07-29 Martin Baulig <martin@gnome.org>
25611 * expression.cs (ParameterReference.ParameterReference): Added
25612 `Location loc' argument to the constructor.
25614 * cs-parser.jay: Pass location to ParameterReference.
25616 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25618 * statement.cs (Try): Initialize the location.
25620 * cs-parser.jay: pass location to Try.
25622 * expression.cs (Unary.Reduce): Change the prototype to return
25623 whether a constant fold could be performed or not. The result is
25624 returned in an out parameters. In the case of Indirection and
25625 AddressOf, we want to perform the full tests.
25627 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25629 * statement.cs (Statement.Emit): Flag dead code.
25631 2002-07-27 Andrew Birkett <andy@nobugs.org>
25633 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25635 2002-07-27 Martin Baulig <martin@gnome.org>
25637 * class.cs (MethodData.Define): Put back call to
25638 TypeManager.AddMethod(), accidentally commented this out.
25640 * report.cs (Debug): New public method to print debugging information,
25641 this is `[Conditional ("DEBUG")]'.
25643 2002-07-26 Martin Baulig <martin@gnome.org>
25645 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25646 (switch_statement): Push the current_block to the switch_stack and
25647 pop it again when we're done with the switch.
25648 (switch_section): The new block is a child of the current_block.
25649 Fixes bug #24007, added test-152.cs.
25651 2002-07-27 Martin Baulig <martin@gnome.org>
25653 * expression.cs (Invocation.EmitArguments): When calling a varargs
25654 function with only its fixed arguments, we need to pass an empty
25657 2002-07-27 Martin Baulig <martin@gnome.org>
25659 Mono 0.13 has been released.
25661 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25663 * driver.cs: Rename --resource to --linkres, because that is what
25664 we do currently, we dont support --resource yet.
25666 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25668 2002-07-25 Martin Baulig <martin@gnome.org>
25670 * class.cs (MethodData): New public class. This is a `method builder'
25671 class for a method or one accessor of a Property/Indexer/Event.
25672 (MethodData.GetMethodFlags): Moved here from MemberBase.
25673 (MethodData.ApplyAttributes): Likewise.
25674 (MethodData.ApplyObsoleteAttribute): Likewise.
25675 (MethodData.ApplyConditionalAttribute): Likewise.
25676 (MethodData.ApplyDllImportAttribute): Likewise.
25677 (MethodData.CheckAbstractAndExternal): Likewise.
25678 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25679 (MethodData.Emit): Formerly known as Method.Emit().
25680 (MemberBase): Moved everything which was specific to a single
25681 accessor/method to MethodData.
25682 (Method): Create a new MethodData and call Define() and Emit() on it.
25683 (Property, Indexer, Event): Create a new MethodData objects for each
25684 accessor and call Define() and Emit() on them.
25686 2002-07-25 Martin Baulig <martin@gnome.org>
25688 Made MethodCore derive from MemberBase to reuse the code from there.
25689 MemberBase now also checks for attributes.
25691 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25692 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25694 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25695 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25696 (MemberBase.ApplyAttributes): New virtual method; applies the
25697 attributes to a method or accessor.
25698 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25699 (MemberBase.ApplyConditionalAttribute): Likewise.
25700 (MemberBase.ApplyDllImportAttribute): Likewise.
25701 (MemberBase.CheckAbstractAndExternal): Likewise.
25702 (MethodCore.ParameterTypes): This is now a property instead of a
25703 method, it's initialized from DoDefineParameters().
25704 (MethodCore.ParameterInfo): Removed the set accessor.
25705 (MethodCore.DoDefineParameters): New protected virtual method to
25706 initialize ParameterTypes and ParameterInfo.
25707 (Method.GetReturnType): We can now simply return the MemberType.
25708 (Method.GetMethodFlags): Override the MemberBase version and add
25709 the conditional flags.
25710 (Method.CheckBase): Moved some code from Define() here, call
25711 DoDefineParameters() here.
25712 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25713 here to avoid some larger code duplication.
25714 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25715 ensure that abstract and external accessors don't declare a body.
25717 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25718 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25719 lookup in the attribute's parent classes, so we need to abort as soon
25720 as we found the first match.
25721 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25722 the attribute has no arguments.
25724 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25727 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25729 * cs-parser.jay: reverted previous patch.
25731 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25733 * cs-parser.jay: fixed bug #22119.
25735 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25737 * attribute.cs: fixed compilation. The error was:
25738 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25739 be assigned to before control leaves the current method."
25740 [FIXME: Filed as bug #28186: MCS must report this error.]
25742 2002-07-25 Martin Baulig <martin@gnome.org>
25744 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25745 method to pull the condition name ouf of a Conditional attribute.
25746 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25747 the obsolete message and error flag out of an Obsolete attribute.
25749 * class.cs (Method.GetMethodFlags): New public method to get the
25750 TypeManager.MethodFlags for this method.
25751 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25753 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25754 if we're overriding a virtual function, set the new private variable
25755 `parent_method'; call the new TypeManager.AddMethod().
25757 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25758 the MethodBuilder and the Method in a PtrHashtable.
25759 (TypeManager.builder_to_method): Added for this purpose.
25760 (TypeManager.MethodFlags): Added IsObsoleteError.
25761 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25762 Obsolete and Conditional arguments in MethodBuilders. If we discover
25763 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25764 the message from the attribute.
25766 2002-07-24 Martin Baulig <martin@gnome.org>
25768 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25769 preprocessor directives, ensure that the argument to #define/#undef is
25770 exactly one identifier and that it's actually an identifier.
25772 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25775 2002-07-24 Martin Baulig <martin@gnome.org>
25777 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25778 initialize it to TypeManager.object_type in the constructor.
25779 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25780 of the `hm.get_current' method if we're using the collection pattern.
25781 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25782 for the explicit conversion to make it work when we're using the collection
25783 pattern and the `Current' property has a different return type than `object'.
25786 2002-07-24 Martin Baulig <martin@gnome.org>
25788 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25789 does not match, but don't report any errors. This method is called in
25790 order for all methods in a MethodGroupExpr until a matching method is
25791 found, so we don't want to bail out if the first method doesn't match.
25792 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25793 matches, report the 123. Fixes #28070.
25795 2002-07-24 Martin Baulig <martin@gnome.org>
25797 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25798 TypeManager.TypeToCoreType() to the top of the method so the
25799 following equality checks will work. Fixes #28107.
25801 2002-07-24 Martin Baulig <martin@gnome.org>
25803 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25804 operand is of type uint, and the other operand is of type sbyte,
25805 short or int, the operands are converted to type long." -
25806 Actually do what this comment already told us. Fixes bug #28106,
25809 2002-07-24 Martin Baulig <martin@gnome.org>
25811 * class.cs (MethodBase): New abstract class. This is now a base
25812 class for Property, Indexer and Event to avoid some code duplication
25813 in their Define() and DefineMethods() methods.
25814 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25815 generic methods for Define() and DefineMethods().
25816 (FieldBase): Derive from MemberBase, not MemberCore.
25817 (Property): Derive from MemberBase, not MemberCore.
25818 (Property.DefineMethod): Moved all the code from this method to the
25819 new MethodBase.DefineAccessor(), just call it with appropriate
25821 (Property.Define): Call the new Property.DoDefine(), this does some
25822 sanity checks and we don't need to duplicate the code everywhere.
25823 (Event): Derive from MemberBase, not MemberCore.
25824 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25825 accessors, this will also make them work with interface events.
25826 (Indexer): Derive from MemberBase, not MemberCore.
25827 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25828 (Indexer.Define): Use the new MethodBase functions.
25830 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25831 argument to the constructor.
25832 (Interface.FindMembers): Added support for interface events.
25833 (Interface.PopluateEvent): Implemented.
25835 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25837 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25839 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25840 but this is required to check for a method name being the same as
25841 the containing class.
25845 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25847 * interface.cs: initialize variable.
25849 2002-07-23 Martin Baulig <martin@gnome.org>
25851 Implemented the IndexerName attribute in interfaces.
25853 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25854 name if this is an explicit interface implementation.
25855 (Indexer.InterfaceIndexerName): New public variable. If we're
25856 implementing an interface indexer, this is the IndexerName in that
25857 interface. Otherwise, it's the IndexerName.
25858 (Indexer.DefineMethod): If we're implementing interface indexer,
25859 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25860 and Pending.ImplementIndexer methods.
25861 (Indexer.Define): Also define the PropertyBuilder if we're
25862 implementing an interface indexer and this is neither an explicit
25863 interface implementation nor do the IndexerName match the one in
25866 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25867 If a method is defined here, then we always need to create a proxy
25868 for it. This is used when implementing interface indexers.
25869 (Pending.IsInterfaceIndexer): New public method.
25870 (Pending.ImplementIndexer): New public method.
25871 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25872 This is used when implementing interface indexers to define a proxy
25874 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25875 define a proxy if necessary.
25877 * interface.cs (Interface.IndexerName): New public variable.
25878 (Interface.PopulateIndexer): Set the IndexerName.
25879 (Interface.DefineIndexers): New private method. Populate all the
25880 indexers and make sure their IndexerNames match.
25882 * typemanager.cs (IndexerPropertyName): Added support for interface
25885 2002-07-22 Martin Baulig <martin@gnome.org>
25887 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25888 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25889 ret if HasReturnLabel.
25890 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25893 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25894 and set the ec.LoopBeginTryCatchLevel.
25895 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25896 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25897 the current ec.TryCatchLevel, the branch goes out of an exception
25898 block. In this case, we need to use Leave and not Br.
25900 2002-07-22 Martin Baulig <martin@gnome.org>
25902 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25903 block unless the block does not always return or it is contained in
25904 another try { ... } catch { ... } block. Fixes bug #26506.
25905 Added verify-1.cs to the test suite.
25907 2002-07-22 Martin Baulig <martin@gnome.org>
25909 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25910 then we do not always return. Fixes bug #24985.
25912 2002-07-22 Martin Baulig <martin@gnome.org>
25914 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25915 lookup on a per-class level; ie. walk up the class hierarchy until we
25916 found at least one applicable method, then choose the best among them.
25917 Fixes bug #24463 and test-29.cs.
25919 2002-07-22 Martin Baulig <martin@gnome.org>
25921 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25922 return types of the methods. The return type is not part of the
25923 signature and we must not check it to make the `new' modifier work.
25924 Fixes bug #27999, also added test-147.cs.
25925 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25927 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25928 on the method's return type.
25930 2002-07-21 Martin Baulig <martin@gnome.org>
25932 * assign.cs: Make this work if the rightmost source is a constant and
25933 we need to do an implicit type conversion. Also adding a few more tests
25934 to test-38.cs which should have caught this.
25936 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25937 target in the makefile for this. The makefile.gnu is primarily intended
25938 for end-users who don't want to debug the compiler.
25940 2002-07-21 Martin Baulig <martin@gnome.org>
25942 * assign.cs: Improved the Assign class so it can now handle embedded
25943 assignments (X = Y = Z = something). As a side-effect this'll now also
25944 consume less local variables. test-38.cs now passes with MCS, added
25945 a few new test cases to that test.
25947 2002-07-20 Martin Baulig <martin@gnome.org>
25949 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25950 instructions. Fixes bug #27977, also added test-146.cs.
25952 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25954 * cs-tokenizer.cs: fixed getHex ().
25956 2002-07-19 Martin Baulig <martin@gnome.org>
25958 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25959 not Type.GetType() to lookup the array type. This is needed when
25960 we're constructing an array of a user-defined type.
25961 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25962 single-dimensional arrays, but also for single-dimensial arrays of
25965 2002-07-19 Martin Baulig <martin@gnome.org>
25967 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25968 this function is called, it's not allowed to share LocalBuilders
25969 among ILGenerators.
25971 2002-07-19 Martin Baulig <martin@gnome.org>
25973 * expression.cs (Argument.Resolve): Report an error 118 when trying
25974 to pass a type as argument.
25976 2002-07-18 Martin Baulig <martin@gnome.org>
25978 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25979 Conv_R_Un for the signed `long' type.
25981 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25983 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25984 `expr' for the temporary result, as that will fail if we do
25985 multiple resolves on the same expression.
25987 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25989 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25990 ec.TypeContainer for looking up aliases.
25992 * class.cs (TypeContainer): Remove LookupAlias from here.
25994 * decl.cs (DeclSpace); Move here.
25996 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25998 * class.cs (FindMembers): Only call filter if the constructor
25999 bulider is not null.
26001 Also handle delegates in `NestedTypes' now. Now we will perform
26002 type lookups using the standard resolution process. This also
26005 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
26006 This uses Expressions (the limited kind that can be parsed by the
26007 tree) instead of strings.
26009 * expression.cs (ComposedCast.ToString): Implement, used to flag
26010 errors since now we have to render expressions.
26012 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
26015 * ecore.cs (SimpleName.ToString): ditto.
26017 * cs-parser.jay: Instead of using strings to assemble types, use
26018 Expressions to assemble the type (using SimpleName, ComposedCast,
26019 MemberAccess). This should fix the type lookups in declarations,
26020 because we were using a different code path for this.
26022 * statement.cs (Block.Resolve): Continue processing statements
26023 even when there is an error.
26025 2002-07-17 Miguel de Icaza <miguel@ximian.com>
26027 * class.cs (Event.Define): Also remove the `remove' method from
26028 the list of pending items.
26030 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
26031 generate more compact code.
26033 2002-07-17 Martin Baulig <martin@gnome.org>
26035 * const.cs (Const.LookupConstantValue): Add support for constant
26036 `unchecked' and `checked' expressions.
26037 Also adding test case test-140.cs for this.
26039 2002-07-17 Martin Baulig <martin@gnome.org>
26041 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
26042 check whether mi.ReturnType implements the IEnumerator interface; the
26043 `==' and the IsAssignableFrom() will fail in this situation.
26045 2002-07-16 Ravi Pratap <ravi@ximian.com>
26047 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
26050 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26052 * expression.cs: fixed bug #27811.
26054 2002-07-14 Miguel de Icaza <miguel@ximian.com>
26056 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
26057 Molaro: when we are a ref, the value already contains a pointer
26058 value, do not take the address of it.
26060 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26061 * removed mb-parser.jay and mb-tokenizer.cs
26063 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26065 * expression.cs: check against the building corlib void type.
26067 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
26069 * ecore.cs: fix for valuetype static readonly fields: when
26070 initializing them, we need their address, not the address of a copy.
26072 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
26074 * typemanager.cs: register also enum_type in corlib.
26076 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26078 * class.cs: allow calling this (but not base) initializers in structs.
26080 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
26082 * ecore.cs: make sure we compare against the building base types
26085 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
26087 * typemanager.cs: fix TypeToCoreType() to handle void and object
26088 (corlib gets no more typerefs after this change).
26090 2002-07-12 Miguel de Icaza <miguel@ximian.com>
26092 * expression.cs (ArrayCreation.EmitArrayArguments): use
26093 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
26095 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
26096 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
26097 array indexes, the runtime actually forbids them.
26099 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
26100 for array arguments here.
26102 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
26103 instead of the default for ValueTypes.
26105 (New.DoEmit): Use IsValueType instead of
26106 IsSubclassOf (value_type)
26107 (New.DoResolve): ditto.
26108 (Invocation.EmitCall): ditto.
26110 * assign.cs (Assign): ditto.
26112 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
26113 Statements *are* currently doing part of their resolution during
26116 Expressions do always resolve during resolve, but statements are
26117 only required to propagate resolution to their children.
26119 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26121 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26123 (LoadAssembly): Do not add the dll if it is already specified
26125 (MainDriver): Add the System directory to the link path at the end,
26126 after all the other -L arguments.
26128 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26129 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26130 ldelem.u1) and using the opposite for sbytes.
26132 This fixes Digger, and we can finally run it.
26134 * driver.cs (UnixParseOption): Move the option parsing here.
26135 (CSCParseOption): Implement CSC-like parsing of options.
26137 We now support both modes of operation, the old Unix way, and the
26138 new CSC-like way. This should help those who wanted to make cross
26139 platform makefiles.
26141 The only thing broken is that /r:, /reference: and /lib: are not
26142 implemented, because I want to make those have the same semantics
26143 as the CSC compiler has, and kill once and for all the confussion
26144 around this. Will be doing this tomorrow.
26146 * statement.cs (Unsafe.Resolve): The state is checked during
26147 resolve, not emit, so we have to set the flags for IsUnsfe here.
26149 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26151 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26152 not catch the Error_ObjectRefRequired in SimpleName (as it is
26153 possible to have a class/instance variable name that later gets
26154 deambiguated), we have to check this here.
26156 2002-07-10 Ravi Pratap <ravi@ximian.com>
26158 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26159 make static and put into Expression.
26161 (Event.Define): Register the private field of the event with the
26162 TypeManager so that GetFieldFromEvent can get at it.
26164 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26165 keep track of the private field associated with an event which
26168 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26171 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26173 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26175 * expression.cs (Binary.EmitBranchable): this routine emits the
26176 Binary expression in a branchable context. This basically means:
26177 we need to branch somewhere, not just get the value on the stack.
26179 This works together with Statement.EmitBoolExpression.
26181 * statement.cs (Statement.EmitBoolExpression): Use
26184 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26186 * statement.cs (For): Reduce the number of jumps in loops.
26188 (For): Implement loop inversion for the For statement.
26190 (Break): We can be breaking out of a Try/Catch controlled section
26191 (foreach might have an implicit try/catch clause), so we need to
26192 use Leave instead of Br.
26194 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26195 now). If the instace expression supports IMemoryLocation, we use
26196 the AddressOf method from the IMemoryLocation to extract the
26197 address instead of emitting the instance.
26199 This showed up with `This', as we were emitting the instance
26200 always (Emit) instead of the Address of This. Particularly
26201 interesting when This is a value type, as we dont want the Emit
26202 effect (which was to load the object).
26204 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26206 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26208 * statement.cs (Checked): Set the CheckedState during the resolve
26209 process too, as the ConvCast operations track the checked state on
26210 the resolve process, and not emit.
26212 * cs-parser.jay (namespace_member_declaration): Flag that we have
26213 found a declaration when we do. This is used to flag error 1529
26215 * driver.cs: Report ok when we display the help only.
26217 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26219 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26221 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26223 * cs-tokenizer.cs (define): We also have to track locally the
26224 defines. AllDefines is just used for the Conditional Attribute,
26225 but we also need the local defines for the current source code.
26227 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26229 * statement.cs (While, For, Do): These loops can exit through a
26230 Break statement, use this information to tell whether the
26231 statement is the last piece of code.
26233 (Break): Flag that we break.
26235 * codegen.cs (EmitContexts): New `Breaks' state variable.
26237 2002-07-03 Martin Baulig <martin@gnome.org>
26239 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26240 modifiers in method declarations in structs. Otherwise, you won't
26241 be able to override things like Object.Equals().
26243 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26245 * class.cs (Method, Property, Indexer): Do not allow the public
26246 modifier to be used in explicit interface implementations.
26248 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26249 override modifiers in method declarations in structs
26251 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26253 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26254 integer or real overflow, report an error
26256 2002-07-02 Martin Baulig <martin@gnome.org>
26258 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26259 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26260 to tell the runtime about our newly created System.Object and
26261 System.ValueType types.
26263 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26265 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26266 struct instead of Ldarg/Starg.
26268 2002-07-02 Martin Baulig <martin@gnome.org>
26270 * expression.cs (Indirection.Indirection): Call
26271 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26273 2002-07-02 Martin Baulig <martin@gnome.org>
26275 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26276 ValueType, call TypeManager.TypeToCoreType() on it.
26277 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26278 the OpCodes.Newarr argument.
26280 2002-07-02 Martin Baulig <martin@gnome.org>
26282 * expression.cs (Invocation.EmitCall): When compiling corlib,
26283 replace all calls to the system's System.Array type to calls to
26284 the newly created one.
26286 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26287 System.Array methods.
26288 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26289 from the system's System.Array type which must be replaced.
26291 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26293 * typemanager.cs: load unverifiable_code_ctor so we can build
26294 corlib using the correct type. Avoid using GetTypeCode() with
26296 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26297 TypeManager.object_type to allow building corlib.
26299 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26301 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26303 2002-07-01 Martin Baulig <martin@gnome.org>
26305 * class.cs: Make the last change actually work, we need to check
26306 whether `ifaces != null' to avoid a crash.
26308 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26310 * class.cs: when we build structs without fields that implement
26311 interfaces, we need to add the interfaces separately, since there is
26312 no API to both set the size and add the interfaces at type creation
26315 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26317 * expression.cs: the dimension arguments to the array constructors
26318 need to be converted if they are a long.
26320 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26322 * class.cs: don't emit ldarg.0 if there is no parent constructor
26323 (fixes showstopper for corlib).
26325 2002-06-29 Martin Baulig <martin@gnome.org>
26327 MCS now compiles corlib on GNU/Linux :-)
26329 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26330 ie. check for MethodImplOptions.InternalCall.
26332 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26333 and TypeManager.attribute_type are null, so we must explicitly check
26334 whether parent is not null to find out whether it's an attribute type.
26335 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26336 and SetBuilder, not only if the property is neither abstract nor external.
26337 This is necessary to set the MethodImplOptions on the accessor methods.
26338 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26339 SetBuilder, see Property.Emit().
26341 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26342 populate "System.Object", "System.ValueType" and "System.Attribute" since
26343 they've already been populated from BootCorlib_PopulateCoreTypes().
26345 2002-06-29 Martin Baulig <martin@gnome.org>
26347 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26348 is the NullLiteral, we also need to make sure that target_type is not
26351 2002-06-29 Martin Baulig <martin@gnome.org>
26353 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26354 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26355 before calling BootstrapCorlib_ResolveDelegate ().
26357 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26359 * statement.cs: fixed build-breaker. All tests passed ok.
26361 2002-06-27 Martin Baulig <martin@gnome.org>
26363 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26364 for System.Decimal when compiling corlib.
26366 2002-06-27 Martin Baulig <martin@gnome.org>
26368 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26369 switch blocks which contain nothing but a default clause.
26371 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26373 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26375 2002-06-27 Martin Baulig <martin@gnome.org>
26377 * ecore.cs (PropertyExpr.PropertyExpr): Call
26378 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26380 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26381 is already a TypeBuilder.
26383 2002-06-27 Martin Baulig <martin@gnome.org>
26385 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26386 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26387 the "from an array-type to System.Array" case. This makes it work
26388 when compiling corlib.
26390 2002-06-27 Martin Baulig <martin@gnome.org>
26392 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26393 non-static PropertyExpr, set its InstanceExpression. This makes
26394 the `ICollection.Count' property work in System/Array.cs.
26396 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26398 * driver.cs: Made error handling more consistent. Errors now
26399 tracked by Report class, so many methods which used to return int
26400 now return void. Main() now prints success/failure and
26401 errors/warnings message.
26403 Renamed '--probe' compiler argument to '--expect-error'. Removed
26404 the magic number return values (123 and 124). Now, if the
26405 expected error occurs, the compiler exits with success (exit value
26406 0). If the compilation completes without seeing that particular
26407 error, the compiler exits with failure (exit value 1). The
26408 makefile in mcs/errors has been changed to handle the new behaviour.
26410 * report.cs: Made 'expected error' number a property and renamed
26411 it from 'Probe' to 'ExpectedError'.
26413 * genericparser.cs: Removed error handling support, since it is
26414 now all done by Report class.
26416 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26417 class, so parse() no longer returns an int.
26419 * namespace.cs: Use Report.Error instead of GenericParser.error
26421 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26423 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26424 TypeContainer.AddOperator): At the front of the list put the
26425 explicit implementations, so they get resolved/defined first.
26427 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26429 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26430 interface type is implemented by this TypeContainer. Used during
26431 explicit interface implementation.
26433 (Property.Define, Indexer.Define, Method.Define): Validate that
26434 the given interface in the explicit implementation is one of the
26435 base classes for the containing type.
26437 Also if we are explicitly implementing an interface, but there is
26438 no match in the pending implementation table, report an error.
26440 (Property.Define): Only define the property if we are
26441 not explicitly implementing a property from an interface. Use the
26442 correct name also for those properties (the same CSC uses,
26443 although that is really not needed).
26445 (Property.Emit): Do not emit attributes for explicitly implemented
26446 properties, as there is no TypeBuilder.
26448 (Indexer.Emit): ditto.
26450 Hiding then means that we do not really *implement* a pending
26451 implementation, which makes code fail.
26453 2002-06-22 Martin Baulig <martin@gnome.org>
26455 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26456 the return value of Object.GetType(). [FIXME: we need to do this whenever
26457 we get a type back from the reflection library].
26459 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26461 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26463 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26465 * attribute.cs: Return null if we can not look up the type.
26467 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26468 the interface types found.
26470 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26471 interface types found.
26473 * typemanager.cs (GetInterfaces): Make this routine returns alll
26474 the interfaces and work around the lame differences between
26475 System.Type and System.Reflection.Emit.TypeBuilder in the results
26476 result for GetInterfaces.
26478 (ExpandInterfaces): Given an array of interface types, expand and
26479 eliminate repeated ocurrences of an interface. This expands in
26480 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26483 2002-06-21 Martin Baulig <martin@gnome.org>
26485 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26488 2002-06-21 Martin Baulig <martin@gnome.org>
26490 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26491 and called with one of the core types, return the corresponding typebuilder for
26494 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26497 2002-06-21 Martin Baulig <martin@gnome.org>
26499 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26500 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26501 (Expression.ConvertReferenceExplicit): Likewise.
26503 * expression.cs (ElementAccess.DoResolve): Likewise.
26504 (ElementAccess.DoResolveLValue): Likewise.
26506 2002-06-10 Martin Baulig <martin@gnome.org>
26508 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26509 add the "value" parameter to the parameter list.
26511 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26514 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26516 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26517 the argument to an int, uint, long or ulong, per the spec. Also
26518 catch negative constants in array creation.
26520 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26522 * class.cs: do not allow the same interface to appear twice in
26523 the definition list.
26525 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26527 * ecore.cs: don't use ldlen with System.Array.
26529 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26531 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26533 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26535 * modifiers.cs: produce correct field attributes for protected
26536 internal. Easy fix so miguel can work on ther harder stuff:-)
26538 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26540 * pending.cs: New file. Move the code from class.cs here.
26541 Support clearning the pending flag for all methods (when not doing
26542 explicit interface implementation).
26544 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26546 * rootcontext.cs: added a couple more types needed to bootstrap.
26548 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26550 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26551 constructor in the type, instead of any constructor in the type
26552 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26553 a bug in the Mono runtime when applying the params attribute).
26555 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26556 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26558 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26560 * expression.cs (Unary.ResolveOperator): Use TypeManager
26561 to resolve the type.
26563 2002-06-13 Ravi Pratap <ravi@ximian.com>
26565 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26568 * enum.cs (AddEnumMember): Add support to store the attributes associated
26569 with each member too.
26571 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26572 field builders too - this takes care of the enum member case.
26574 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26576 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26577 address-of operator on both value types and pointers.
26579 2002-06-10 Martin Baulig <martin@gnome.org>
26581 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26582 PropertyBuilder to the `property_builders' list.
26584 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26585 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26586 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26587 find any indexers which are inherited from an interface.
26589 2002-06-09 Martin Baulig <martin@gnome.org>
26591 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26592 the same type as the constant if necessary. There's also a test-130.cs
26595 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26597 * typemanager.cs (TypeManager.ChangeType): Previously known as
26598 Enum.ChangeEnumType().
26600 2002-06-09 Martin Baulig <martin@gnome.org>
26602 * expression.cs (Cast.TryReduce): Added support for consts.
26604 2002-06-08 Ravi Pratap <ravi@ximian.com>
26606 * class.cs (Accessor): Hold attributes information so we can pass
26609 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26610 Modify to pass in attributes attached to the methods.
26612 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26614 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26615 to handle the Accessor kind :-)
26617 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26619 2002-06-08 Martin Baulig <martin@gnome.org>
26621 * expression.cs (Unary.TryReduceNegative): Added support for
26624 2002-06-08 Martin Baulig <martin@gnome.org>
26626 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26627 name can't be found in the `defined_names' - the caller will do a
26628 MemberLookup in this case and thus find methods in System.Enum
26629 such as Enum.IsDefined().
26631 2002-06-08 Martin Baulig <martin@gnome.org>
26633 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26634 Convert.ChangeType() which works with TypeBuilder created types.
26635 (Enum.LookupEnumValue, Enum.Define): Use it here.
26637 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26638 `TypeBuilder.BaseType != null' check.
26639 (TypeContainer.FindMembers): Only lookup parent members if we
26640 actually have a parent.
26641 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26642 (ConstructorInitializer.Resolve): Likewise.
26644 * interface.cs (Interface.FindMembers): Added
26645 `TypeBuilder.BaseType != null' check.
26647 * rootcontext.cs (RootContext.ResolveCore): Added
26648 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26649 classes_second_stage.
26651 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26652 debug_type and trace_type when compiling with --nostdlib.
26654 2002-06-07 Martin Baulig <martin@gnome.org>
26656 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26657 (AddField): Set it to true when adding a non-static field.
26658 (DefineType): Use `have_nonstatic_fields' to find out whether we
26659 have non-static fields, not `Fields != null'.
26661 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26663 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26664 dereferencing a null on the static-field code path)
26666 2002-05-30 Martin Baulig <martin@gnome.org>
26668 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26669 to take command line arguments. Use reflection to call the new
26670 custom `Initialize' function on the symbol writer and pass it the
26671 command line arguments.
26673 * driver.cs (--debug-args): New command line argument to pass command
26674 line arguments to the symbol writer.
26676 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26678 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26679 the target type for indexers and properties. Thanks to Joe for
26682 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26684 * typemanager.cs (MethodFlags): returns the method flags
26685 (Obsolete/ShouldIgnore) that control warning emission and whether
26686 the invocation should be made, or ignored.
26688 * expression.cs (Invocation.Emit): Remove previous hack, we should
26689 not do this on matching a base type, we should do this based on an attribute
26691 Only emit calls to System.Diagnostics.Debug and
26692 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26693 on the command line.
26695 * rootcontext.cs: Global settings for tracing and debugging.
26697 * cs-tokenizer.cs (define): New utility function to track
26698 defines. Set the global settings for TRACE and DEBUG if found.
26700 2002-05-25 Ravi Pratap <ravi@ximian.com>
26702 * interface.cs (Populate*): Pass in the TypeContainer as well as
26703 the DeclSpace as parameters so that we can create EmitContexts and
26704 then use that to apply attributes etc.
26706 (PopulateMethod, PopulateEvent, PopulateProperty)
26707 (PopulateIndexer): Apply attributes everywhere.
26709 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26712 (ApplyAttributes): Update accordingly.
26714 We now apply interface attributes for all members too.
26716 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26718 * class.cs (Indexer.Define); Correctly check if we are explicit
26719 implementation (instead of checking the Name for a ".", we
26720 directly look up if the InterfaceType was specified).
26722 Delay the creation of the PropertyBuilder.
26724 Only create the PropertyBuilder if we are not an explicit
26725 interface implementation. This means that explicit interface
26726 implementation members do not participate in regular function
26727 lookups, and hence fixes another major ambiguity problem in
26728 overload resolution (that was the visible effect).
26730 (DefineMethod): Return whether we are doing an interface
26733 * typemanager.cs: Temporary hack until we get attributes in
26734 interfaces (Ravi is working on that) and we get IndexerName
26735 support in interfaces.
26737 * interface.cs: Register the indexers as properties.
26739 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26740 warning, I have verified that this is a bug in the .NET runtime
26741 (JavaScript suffers of the same problem).
26743 * typemanager.cs (MemberLookup): When looking up members for
26744 interfaces, the parent of an interface is the implicit
26745 System.Object (so we succeed in searches of Object methods in an
26746 interface method invocation. Example: IEnumerable x; x.ToString
26749 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26751 * class.cs (Event): Events should also register if they do
26752 implement the methods that an interface requires.
26754 * typemanager.cs (MemberLookup); use the new GetInterfaces
26757 (GetInterfaces): The code used to lookup interfaces for a type is
26758 used in more than one place, factor it here.
26760 * driver.cs: Track the errors at the bottom of the file, we kept
26763 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26764 instance if the method we are calling is static!
26766 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26768 * attribute.cs (ApplyAttributes): Make this function filter out
26769 the IndexerName attribute (as that attribute in reality is never
26770 applied) and return the string constant for the IndexerName
26773 * class.cs (TypeContainer.Emit): Validate that all the indexers
26774 have the same IndexerName attribute, and if so, set the
26775 DefaultName attribute on the class.
26777 * typemanager.cs: The return value might contain other stuff (not
26778 only methods). For instance, consider a method with an "Item"
26779 property and an Item method.
26781 * class.cs: If there is a problem with the parameter types,
26784 2002-05-24 Ravi Pratap <ravi@ximian.com>
26786 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26787 looks at user defined conversion after making a call to
26788 StandardConversionExists - we need this for overload resolution.
26790 * expression.cs : Update accordingly the various method calls.
26792 This fixes 2 bugs filed against implicit user defined conversions
26794 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26796 * statement.cs: Track the result of the assignment.
26798 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26800 * expression.cs (MemberAccess): Improved error reporting for
26801 inaccessible members.
26803 2002-05-22 Martin Baulig <martin@gnome.org>
26805 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26806 itself with debugging support.
26808 2002-05-22 Martin Baulig <martin@gnome.org>
26810 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26811 Removed, this isn't needed anymore.
26813 2002-05-20 Martin Baulig <martin@gnome.org>
26815 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26816 be underlying type for an enum.
26818 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26820 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26821 that splits out the loading of just the core types.
26823 * rootcontext.cs (ResolveCore): Split the struct resolution in
26824 two, so we can load the enumeration underlying types before any
26827 * expression.cs (Is): Bandaid until we fix properly Switch (see
26828 bug #24985 for details).
26830 * typemanager.cs (ImplementsInterface): The hashtable will contain
26831 a null if there are no interfaces implemented.
26833 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26835 * cs-parser.jay (indexer_declarator): It is fine to have array
26838 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26840 * typemanager.cs: (RegisterBuilder): New function used to register
26841 TypeBuilders that implement interfaces. Since
26842 TypeBuilder.GetInterfaces (as usual) does not work with lame
26844 (AddUserType): register interfaces.
26846 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26847 dealing with TypeBuilder. Also, arrays are showing up as
26848 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26849 methods can not be invoked on them!
26851 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26852 (ImplicitReferenceConversionExists): Split out from
26853 StandardConversionExists.
26855 * expression.cs (As): We were only implementing one of the three
26856 cases for the as operator. We now implement them all.
26857 (Is): Implement the various other cases for Is as well.
26859 * typemanager.cs (CACHE): New define used to control if we want or
26860 not the FindMembers cache. Seems to have a negative impact on
26861 performance currently
26863 (MemberLookup): Nested types have full acess to
26864 enclosing type members
26866 Remove code that coped with instance/static returns for events, we
26867 now catch this in RealFindMembers.
26869 (RealFindMembers): only perform static lookup if the instance
26870 lookup did not return a type or an event.
26872 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26874 * assign.cs (CompoundAssign): We pass more semantic information
26875 now to Compound Assignments than we did before: now we have all
26876 the information at hand, and now we resolve the target *before* we
26877 do the expression expansion, which allows the "CacheValue" method
26878 to have the effect we intended (before, a [x] += 1 would generate
26879 two differen ArrayAccess expressions from the ElementAccess,
26880 during the resolution process).
26882 (CompoundAssign.DoResolve): Resolve target and original_source here.
26884 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26886 * expression.cs (ArrayAccess): dropped debugging information.
26888 * typemanager.cs: Small bug fix: I was always returning i_members,
26889 instead of one of i_members or s_members (depending on which had
26892 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26893 method is invoked before any code generation takes place, and it
26894 is a mechanism to inform that the expression will be invoked more
26895 than once, and that the method should use temporary values to
26896 avoid having side effects
26898 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26900 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26903 * expression.cs (Indirection, ArrayAccess): Add support for
26904 CacheTemporaries in these two bad boys.
26906 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26907 ldobj or ldind_ref.
26908 (StoreFromPtr): Handle stobj as well.
26910 * expression.cs (UnaryMutator): Share more code.
26912 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26913 down: I was not tracking the Filter function as well, which
26914 was affecting the results of the cache.
26916 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26918 * attribute.cs: Remove the hack to handle the CharSet property on
26921 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26923 * attribute.cs (DoResolve): More uglyness, we now only try to
26924 resolve the attribute partially, to extract the CharSet
26925 information (only if we are a StructLayout attribute). Otherwise
26927 (GetExtraTypeInfo): Add some code to conditionally kill in the
26928 future this. I am more and more convinced that the .NET
26929 framework has special code to handle the attribute setting on
26932 * expression.cs (IsParamsMethodApplicable): Revert my previous
26933 foreach change here, it was wrong.
26935 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26937 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26938 (pp_expr): do not abort on unknown input, just return.
26939 (eval): abort if there are pending chars.
26941 * attribute.cs (Attribute.Resolve): Positional parameters are
26942 optional. Deal with that case.
26944 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26945 the Ansi/Unicode/Auto information for the type.
26947 (TypeContainer.DefineType): instantiate the EmitContext here, as
26948 we will be using it during the type definition (to resolve
26949 attributes) and during the emit phase.
26951 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26952 to pull type information out of the attributes
26954 (Attribute.Resolve): track the constructor builder, and allow for
26955 multiple invocations (structs and classes will use this).
26957 * ecore.cs (MemberLookupFinal): new version with all the
26958 parameters customizable.
26960 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26961 constructors. Return if the result value is null (as the error
26962 would have been flagged already by MemberLookupFinal)
26964 Do not allow instances of abstract classes or interfaces to be
26967 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26968 We have to compare the assembly property here when dealing with
26969 FamANDAssem and Assembly access modifiers, because we might be
26970 creating an assembly from *modules* (that means that we are not
26971 getting TypeBuilders for types defined in other modules that are
26972 part of this assembly).
26974 (Method.Emit): If the method is marked abstract and has a body,
26977 (TypeContainer.DefineMembers): If both the defined member and the
26978 parent name match are methods, then do not emit any warnings: let
26979 the Method.Define routine take care of flagging warnings. But if
26980 there is a mismatch (method overrides something else, or method is
26981 overriwritten by something, then emit warning).
26983 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26984 set to null, this means `do not check for the return type on the
26987 (Method.Define): set the return type for the method signature to
26988 null, so that we get methods with the same name and parameters and
26989 different return types. This is used to flag warning 114 (you are
26990 hiding a method, and you probably want to use the new/override
26993 * typemanager.cs (MemberLookup): Implemented proper access
26994 control, closing a long standing set of bug reports. The problem
26995 was that the Framework only has two bits: Public and NonPublic,
26996 and NonPublic includes private and protected methods, but we need
26997 to enforce the FamANDAssem, FamOrAssem and Family.
26999 2002-05-11 Miguel de Icaza <miguel@ximian.com>
27001 * statement.cs (GotoCase): Return true: Ammounts to giving up
27002 knowledge on whether we return or not, and letting the other case
27003 be responsible for it.
27005 2002-05-10 Miguel de Icaza <miguel@ximian.com>
27007 * driver.cs: Do not load directories for each file processed, only
27008 do it if there is a pattern.
27010 * ecore.cs: Report readonly assigns here as well, as we might have
27011 been resolved only by MemberAccess.
27013 (SimpleName.SimpleNameResolve): Also be useful for LValue
27014 resolution. We need this to propagate assign to local readonly variables
27016 * typemanager.cs: Use a ptrhashtable for the criteria, because we
27017 do not want to reuse potential criteria memory.
27019 * class.cs (MyEventBuilder): Set reflected_type;
27021 * ecore.cs (Constantify): Added support for constifying bools.
27023 (RootContext.LookupType): Added a cache for values looked up in
27024 the declaration space.
27026 * typemanager.cs (FindMembers): Now is a front-end to
27027 RealFindMembers, and provides a two-level hashtable-based cache to
27030 15% performance improvement: from 22.5 to 19.2 seconds.
27032 * expression.cs (IsParamsMethodApplicable): use foreach.
27033 (Invocation.DoResolve): ditto.
27034 (New.DoResolve): ditto.
27035 (ArrayCreation.DoResolve): ditto.
27037 * ecore.cs (FindMostEncompassingType): use foreach.
27039 * delegate.cs (NewDelegate.DoResolve): Use foreach
27041 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
27042 (RemoveMethods): use foreach.
27044 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
27045 nested foreach statements instead of for, and also break out of
27046 the inner loop once a match is found.
27048 (Invocation.OverloadResolve): Use foreach, simplify the code.
27050 2002-05-08 Miguel de Icaza <miguel@ximian.com>
27052 * cfold.cs (BinaryFold): During an enumeration evaluation context,
27053 we actually unwrap the expression to allow for extra information
27056 * expression.cs: Use Shr_Un on unsigned operations.
27058 2002-05-08 Ravi Pratap <ravi@ximian.com>
27060 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
27061 applicable operators was not being considered correctly. This closes
27062 the bug Miguel reported.
27064 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
27066 * attribute.cs: check that the type derives from System.Attribute
27067 and report the correct error in that case (moved the duplicate code to
27068 its own method, too).
27070 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
27072 * attribute.cs: lookup attribute type name as the spec says: first the
27073 bare attribute name and then name + "Attribute" (nant compiles with
27074 mcs after this fix).
27076 2002-05-07 Miguel de Icaza <miguel@ximian.com>
27078 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
27079 Because of the way we parse things, we should try to see if a
27080 UIntConstant can fit in an integer.
27082 2002-05-07 Ravi Pratap <ravi@ximian.com>
27084 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
27085 when we are in an explicit context.
27087 (ConvertReferenceExplicit): When converting from Iface type S to Class
27088 T make sure the rules are implemented as an OR.
27090 * parameter.cs (ParameterType): Make it a property for now although the
27091 purpose really isn't anything immediate.
27093 * expression.cs (Is*Applicable): Do better checking on the parameter type
27094 of a ref/out parameter. The ones from the system assemblies are already
27095 marked with the correct type so we don't need to do any correction.
27097 * ecore.cs (StandardConversionExists): Conversion from Interface types to
27098 the object type is standard too so include that.
27100 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27102 * ecore.cs (StandardConversionExists): Augment with missing code:
27103 deal with IntConstant, LongConstants and Enumerations.
27105 * assign.cs: Report the error, instead of failing silently
27107 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
27108 typecontainer that they are declared, because the
27109 typecontainer/namespace will have the list of using clauses that
27110 need to be applied.
27112 Assembly Attributes were escaping the normal registration
27115 (EmitCode): Apply attributes within an EmitContext that represents
27116 the container they were declared on.
27118 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27120 2002-05-06 Ravi Pratap <ravi@ximian.com>
27122 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27123 Revamp completely - make much cleaner as we now operate only
27126 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27127 to implement the logic detailed in the spec more correctly.
27129 (UserDefinedConversion): Update accordingly.
27131 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27133 * statement.cs: Return flow analysis information up.
27135 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27138 (token): Do not consume an extra character before calling
27141 2002-05-06 Piers Haken <piersh@friskit.com>
27143 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27145 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27147 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27148 EmitContext during the instance constructor initializer
27149 resolution, to stop access to instance variables.
27151 This is mandated by the spec, last paragraph of the `constructor
27152 initializers' section.
27154 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27156 * cs-parser.jay, class.cs (Accessor): new class used to represent
27157 an accessor (get or set). In the past we used `null' to represent
27158 a missing accessor. But this is ambiguous because there was no
27159 way to tell in abstract indexers/properties if one of them was
27162 Now there is a way of addressing that.
27164 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27165 instead of FindMembers.
27167 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27168 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27170 * attribute.cs: Treat indexers and properties as the same in terms
27171 of applying attributes
27173 * ecore.cs (FindMostEncompassedType): Use statically initialized
27174 EmptyExpressions()s like we do elsewhere to avoid creating useless
27175 objects (and we take this out of the tight loop).
27177 (GetConversionOperators): Move the code to extract the actual
27178 operators to a separate routine to clean things up.
27180 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27182 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27183 events are always registered FieldBuilders.
27185 * class.cs (FieldBase): New class shared by Fields
27187 * delegate.cs: If we are a toplevel delegate, use our full name.
27188 If we are a nested delegate, then only use our tail name.
27190 2002-05-02 Ravi Pratap <ravi@ximian.com>
27192 * expression.cs (IsApplicable): Ensure that we add the "&" to
27193 ref/out types before comparing it with the type of the argument.
27195 (IsParamsMethodApplicable): Ditto.
27197 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27200 * delegate.cs : Handle the case when we have more than one applicable
27201 method. Flag an error only when we finish checking all.
27203 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27205 * expression.cs: Add support for boolean static initializers.
27207 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27209 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27211 * parameter.cs (ComputeParameterTypes,
27212 ComputeAndDefineParameterTypes): Better error handling: now we
27213 clear the `types' cache if we fail during any of the type lookups.
27214 We also return the status code correctly to our caller
27216 * delegate.cs: If we fail to define a delegate, abort the extra
27219 * expression.cs (Binary.ResolveOperator): for
27220 operator==(object,object) and operator !=(object, object) we also
27221 have to verify that there is an implicit conversion from one to
27224 (ArrayAccess.DoResolve): Array Access can operate on
27227 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27229 * assign.cs (CompoundAssign): A new class used as a "flag" that
27230 the assignment actually is happening as part of a compound
27231 assignment operator.
27233 During compound assignment, a few new rules exist to enable things
27240 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27241 to the type of x) if y is implicitly convertible to the type of x,
27242 and the operator is a builtin operator and the return type of the
27243 operator is explicitly convertible to the type of x.
27245 * rootcontext.cs: Reset warning level to 2. 4 catches various
27246 "interesting" features in mcs, we must clean this up at some
27247 point, but currently am trying to kill other bugs ;-)
27249 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27250 in container classes as well.
27252 * expression.cs (Binary.ResolveOperator): Handle string case
27253 before anything else (as operator overloading does emit an error
27254 before doing anything else).
27256 This code could go away when we move to a table driven model, but
27257 i could not come up with a good plan last night.
27259 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27261 * typemanager.cs (CSharpName): reimplementation using regex.
27262 * class.cs: added null check for fields in Emit
27263 * rootcontext.cs: set warninglevel to 4
27265 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27267 * typemanager.cs (CSharpName): reimplemented with Lupus
27270 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27272 * statement.cs (If): correclty implement Resolve, because we were
27273 not catching sem errors in there. The same process is needed
27275 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27278 (Statement.Warning_DeadCodeFound): Factorize code.
27279 (While): Report dead code here too.
27281 (Statement): Added Resolve virtual method to allow
27282 for resolution split from the emit code.
27284 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27286 * statement.cs (EmitBoolExpression): No longer try to resolve the
27288 (MakeBoolean): New utility function that resolve, implicitly
27289 converts to boolean and tags the expression.
27292 (If, Do): Implement dead code elimination.
27293 (While): Implement loop inversion
27295 (Do, While, For, If): Resolve the expression prior to calling our
27298 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27301 - added method Report28 (warning: program has more than one entry point)
27302 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27303 - modified method Method.Define, the part at the end of the method
27305 * rootcontext.cs: added static public Location EntryPointLocation;
27307 * ../errors/cs0028.cs : Add test case for the above warning.
27310 - modified method CSharpName to allow arrays of primitive type to
27311 be printed nicely (e.g. instead of System.Int32[][] it now prints
27313 - added method CSharpSignature: returns the signature of a method
27314 in string format to be used in reporting errors, warnings, etc.
27316 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27319 2002-04-26 Ravi Pratap <ravi@ximian.com>
27321 * delegate.cs (Define): Fix extremely silly bug where I was
27322 setting the type of the 'object' parameter of the BeginInvoke
27323 method to System.IAsyncResult instead of System.Object ;-)
27325 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27327 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27330 (Constructor.Emit): return if we fail to initialize the
27331 constructor. Another door closed!
27333 * expression.cs (New.DoResolve): Improve error message (from -6 to
27334 1501). Use DeclaredOnly lookup to find the exact constructor.
27336 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27337 loop. This is useful.
27339 * cs-parser.jay: Adjust the default parameters so that destructors
27340 have the proper signature.
27342 2002-04-26 Martin Baulig <martin@gnome.org>
27344 * driver.cs (LoadAssembly): If `assembly' contains any characters
27345 which are only valid in path names and not in assembly names
27346 (currently slash, backslash and point), use Assembly.LoadFrom ()
27347 instead of Assembly.Load () on the `assembly' (before iteration
27348 over the link_paths).
27350 2002-04-26 Martin Baulig <martin@gnome.org>
27352 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27354 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27356 * class.cs (Property): use the new typemanager.MemberLookup
27358 (TypeContainer.MemberLookup): Implement using the
27359 TypeManager.MemberLookup now.
27361 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27362 and return MemberInfos, so that these can be used without an
27363 EmitContext (what we had before).
27365 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27367 * expression.cs: Fix the case where the argument to params if the
27368 type of the params. I omitted handling this before. Fixed
27370 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27372 * driver.cs: Call BootCorlib_PopulateCoreType
27374 * class.cs (Property.CheckBase): Check for properties only, not
27377 * interface.cs: Temporary hack: try/catch around the
27378 CustomAttributeBuilder, because I am getting an exception that I
27381 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27382 types whose definitions are required to be there (attributes are
27383 defined before standard types).
27385 Compute definitions as we boot the various types, as they are used
27386 immediately (value_type class will need object_type, but if we do
27387 not initialize object_type, we will pass a null, which will let
27388 the runtime pick the System.Object from the existing corlib, which
27389 is not what we want).
27391 2002-04-22 Patrik Torstensson <totte@labs2.com>
27393 * cs-tokenizer.cs: fixed a number of trim() issues.
27395 2002-04-22 Ravi Pratap <ravi@ximian.com>
27397 * expression.cs (Argument.Type): Ensure that we return the correct
27398 type when we have out or ref parameters [in which case we
27401 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27403 * class.cs (Property, Indexer): Allow extern modifier in there.
27405 * typemanager.cs (InitBaseTypes): Initializes object_type and
27406 value_type, since those will be used early on during the bootstrap
27407 process to compile corlib.
27409 (InitCoreTypes): Move code from here to InitBaseTypes.
27411 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27413 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27414 single-dimension arrays as using the ldlen opcode.
27416 Daniel Lewis discovered this optimization.
27418 * typemanager.cs: Add signature for System.Array::get_Length
27420 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27422 * statement.cs: report the error when the foreach does not apply to an
27423 array nor a collection.
27425 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27427 * expression.cs: Add implicit conversions to the operator ~.
27429 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27431 * typemanager.cs: Locate the decimal constructor.
27433 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27435 * attribute.cs: use the new property of TypeOf.
27436 * expression.cs: added 'get' property around typearg.
27438 These changes fix a build breaker reported by NickD. Is this the
27439 correct way to fix? If not, please, revert my changes and make it
27442 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27444 * attribute.cs: Add support for typeof in attribute invocations.
27445 I am not sure that this is right though.
27447 2002-04-14 Duncan Mak <duncan@ximian.com>
27449 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27450 Binary.Operator.Division case.
27452 2002-04-13 Ravi Pratap <ravi@ximian.com>
27454 * class.cs (DefineType): Ensure that we do a proper check on
27455 attribute types and also register it with the TypeManager.
27457 (TypeContainer.Targets): The default for attribute types is
27458 AttributeTargets.All.
27460 * attribute.cs (ApplyAttributes): Registering the attribute type
27461 is done elsewhere, not when we discover we have a Usage attribute.
27463 2002-04-12 Ravi Pratap <ravi@ximian.com>
27465 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27466 and get rid of is_delegate parameter.
27468 * everywhere : update.
27470 2002-04-12 Ravi Pratap <ravi@ximian.com>
27472 * cs-parser.jay (compilation_unit): Revamp completely to use
27473 some new ideas that I got from Rhys' grammar to solve the problems
27474 with assembly level attributes.
27476 (outer_declaration): New grammar production.
27478 (attribute_sections): Add.
27480 (opt_attributes): Base on attribute_sections
27482 (namespace_declaration): Allow opt_attributes to tackle the case
27483 when we have assembly level attributes - we are clever in this
27486 * attribute.cs (ApplyAttributes): Do not worry about assembly
27487 attributes in the non-global context.
27489 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27490 instead of SetGlobalAttributes.
27492 * class.cs, rootcontext.cs : Ensure we define and generate
27493 attribute types before anything else.
27495 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27496 and flag the new error -20 for the case when the attribute type
27497 does not have valid targets specified. csc does not catch this.
27499 * ../errors/errors.txt : update for error # -20
27501 2002-04-11 Ravi Pratap <ravi@ximian.com>
27503 * support.cs (InternalParameters.ParameterModifier): Do some null
27504 checking and return sane values.
27506 * class.cs (Method.Define): If we are a PInvoke method, ensure
27507 that we are static and extern. Report error # 601
27509 * ../errors/cs0601.cs : Add test case for the above error.
27511 2002-04-07 Ravi Pratap <ravi@ximian.com>
27513 * rootcontext.cs (attribute_types): We need to keep type of
27514 all attribute types separately and emit code for them first.
27516 (RegisterAttribute) : Implement.
27518 * class.cs (DefineType): Check if the current Type is a custom
27519 attribute type and register it accordingly.
27521 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27522 adding the first attribute twice and rename to
27524 (SetGlobalAttributes): this.
27526 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27529 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27530 if we are processing global arguments. Hmm, I am unsure of this.
27532 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27534 * expression.cs: added static array of strings to avoid calling
27535 Enum.ToString () for Operator in Binary. Significant recover of
27538 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27540 * class.cs (FindMembers): Allow the Builders of the various
27541 members to be null. If they are skip them. This only happens
27542 during the PInvoke declaration.
27544 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27546 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27547 failure, so we do not keep going afterwards.
27549 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27550 wanted to pass `false' as the `is_delegate' argument. If this is
27551 the case, why not use delegate_type == null to mean `is_delegate =
27552 false' and anything else as is_delegate = true.
27554 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27556 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27557 code for the section, not the beginning of the tests.
27559 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27561 * cfold.cs: Handle operator + (Enum x, Underlying x)
27563 * expression.cs (Binary): same. Warn about errors where we have
27564 Enum/Enum in operator + as well.
27566 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27569 - added support for switch(bool)
27570 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27571 - add TableSwitchEmit() to handle table-based switch statements
27573 2002-04-05 Ravi Pratap <ravi@ximian.com>
27575 * expression.cs (Invocation.OverloadResolve): Factor out code which
27576 does parameter compatibility checking with arguments so that we can
27577 re-use the code even from Delegate.VerifyApplicability
27579 (VerifyArgumentsCompat): Move above code here.
27581 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27582 and instead make a call to the above method.
27584 2002-03-31 Ravi Pratap <ravi@ximian.com>
27586 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27587 We use it to keep track of classes which are attribute types.
27589 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27591 * delegate.cs (Delegate.Define): Correctly define the types in the
27592 presence of fixed and array parameters.
27594 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27597 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27598 include NonPublic after the first iteration.
27600 * class.cs (Indexer.CheckBase): Only check if both parents are
27603 * cs-parser.jay (accessor_body): If empty, set to null.
27605 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27606 same code path here to resolve constants names that we did have in
27607 MemberAccess.DoResolve. There is too much code duplicated here.
27609 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27611 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27613 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27616 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27617 tokens, numbers and strings.
27619 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27622 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27623 asyncronous parameters and the regular parameters.
27625 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27626 specify the target directory.
27628 * expression.cs: (This.DoResolve): Simplify
27629 (As.Emit): Optimize, do not generate IsInst if the expression is
27630 always of the given type.
27632 (Is.DoResolve): Bug fix, we were reporting both always/never for
27635 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27636 creating too many unnecessary arrays.
27638 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27640 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27641 fields instead of rolling our own initializer. Takes care of all
27642 implicit conversions, and drops unnecessary static checks/argument.
27644 2002-03-31 Dick Porter <dick@ximian.com>
27646 * driver.cs: use the GetDirectories() return values properly, and
27647 use "/" as path separator.
27649 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27651 * expression.cs (Unary): Optimize - - expr into expr.
27652 (Binary): Optimize a + (-b) into a -b.
27654 * codegen.cs (CodeGen): Made all methods static.
27656 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27660 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27661 TypeBuilder property.
27663 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27666 * tree.cs: Removed the various RecordXXXX, and replaced with a
27667 single RecordDecl. Removed all the accessor methods, and just
27668 left a single access point Type
27670 * enum.cs: Rename DefineEnum to DefineType.
27672 * decl.cs: New abstract method `DefineType' used to unify the
27673 Defines for Enumerations, Interfaces, TypeContainers and
27676 (FindType): Moved LookupInterfaceOrClass here. Moved the
27677 LookupBaseClasses method that used to live in class.cs and
27678 interface.cs here, and renamed to FindType.
27680 * delegate.cs: Implement DefineType. Take advantage of the
27681 refactored pattern for locating the parent builder without taking
27682 the parent_builder argument (which we know does not work if we are
27683 nested, and triggering a toplevel definition).
27685 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27687 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27688 accessibility of a member has changed during override and report
27691 * class.cs (Method.Define, Property.Define): Only complain on
27692 overrides if the method is private, any other accessibility is
27693 fine (and since we just checked the permission is the same, we are
27696 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27697 and elif are processed always. The other pre-processing
27698 directives are only processed if we are "taking" the path
27700 2002-03-29 Martin Baulig <martin@gnome.org>
27702 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27703 current location is not Null.
27705 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27706 a separate method so we can profile it.
27708 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27709 `span.Seconds' are just seconds, but no minutes or hours.
27710 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27712 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27714 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27715 Remove the gratuitous set of Final:
27717 // If an interface implementation, then we can set Final.
27718 if (((flags & MethodAttributes.Abstract) == 0) &&
27719 implementing.DeclaringType.IsInterface)
27720 flags |= MethodAttributes.Final;
27722 I do not know what I was smoking when I used that.
27725 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27726 step into fixing the name resolution issues for delegates and
27727 unifying the toplevel name resolution.
27729 2002-03-28 Martin Baulig <martin@gnome.org>
27731 * class.cs (Method.Emit): If we have a symbol writer, call its
27732 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27733 tell it about the current method.
27735 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27736 writer that we're going to emit the first byte of IL code for a new
27737 statement (a new source line).
27738 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27739 EmitContext.Mark() before emitting any code.
27741 * location.cs (SymbolDocument): Return null when we're Null.
27743 * statement.cs (Statement): Moved the `Location loc' variable here.
27744 (Statement.EmitBoolExpression): If we have a symbol writer, call
27745 ec.Mark() before emitting any code to tell it that we're at the
27746 beginning of a new statement.
27747 (StatementExpression): Added `Location' argument to the constructor.
27748 (Block): Added public readonly variable `StartLocation' and public
27749 variable `EndLocation'. The latter is to be set using SetEndLocation().
27750 (Block): Added constructor which takes a start and end location.
27751 (Block.SetEndLocation): New method. This sets the end location.
27752 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27753 local variables we create.
27754 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27755 each statement and do also mark the begin and end of the block.
27757 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27758 tell it the current lexer.Location, use Location.Null for the end of the
27760 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27761 current block, set its end location using SetEndLocation().
27762 (statement_expression): StatementExpression constructor now takes the
27763 lexer.Location as additional argument.
27764 (for_statement, declare_local_variables): Likewise.
27765 (declare_local_variables): When creating a new implicit block, use the
27766 new Block constructor and pass it the lexer.Location.
27768 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27770 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27771 members also on the parent interfaces recursively.
27773 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27775 * report.cs: Use new formats, since Gonzalo finished the missing
27778 * expression.cs (Binary.ResolveOperator): added missing operator|
27779 operator& and operator^ for bool/bool.
27781 * cs-parser.jay: CheckDef now takes a Location argument that is
27782 used to report errors more precisly (instead of reporting the end
27783 of a definition, we try to track something which is a lot closer
27784 to the source of the problem).
27786 * cs-tokenizer.cs: Track global token use, so we can properly flag
27787 the use of #define/#undef after the first token has been seen.
27789 Also, rename the reportXXXX to Error_DescriptiveName
27791 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27792 TypeContainer, so that Enum and Interface can use this too.
27794 * class.cs (TypeContainer.LookupInterfaceOrClass,
27795 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27796 `builder' argument. Typically this was used to pass the parent
27797 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27800 The problem is that a nested class could trigger the definition of
27801 a toplevel class, and the builder would be obviously wrong in that
27804 So we drop this argument, and we compute dynamically the
27805 TypeBuilder/ModuleBuilder (the correct information was available
27806 to us anyways from DeclSpace.Parent)
27808 * interface.cs (Interface.DefineInterface): Drop builder
27809 parameter cleanup like class.cs
27811 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27814 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27817 (Try.Emit): Propagate the returns value from the statement.
27819 (Return.Emit): Even if we are leavning
27821 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27823 * modifiers.cs: Fix the computation of MethodAttributes flags.
27825 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27827 * driver.cs: allow compilation of files that start with '/'.
27828 Add a default case when checking the argument of --target.
27830 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27832 * interface.cs: Implement the same search algorithm for types in
27833 the interface code.
27835 * delegate.cs: Do not allow multiple definition.
27837 * Recovered ChangeLog that got accidentally amputated
27839 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27841 * rootcontext.cs: Load manually enum to allow core classes to
27842 contain enumerations.
27844 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27845 Update to new static methods in TypeManager.
27847 * typemanager.cs (GetMethod, GetConstructor): Use our
27848 implementation of FindMembers to find the members, since during
27849 corlib compilation, the types are TypeBuilders and GetMethod and
27850 GetConstructor do not work.
27852 Make all methods in TypeManager static.
27854 (InitCodeHelpers): Split the functionality from
27855 the InitCodeTypes function.
27857 * driver.cs: Call InitCodeHelpers after we have populated the
27860 * cs-parser.jay (delegate_declaration): we did not used to compute
27861 the delegate name correctly for void delegates.
27863 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27865 * rootcontext.cs (RootContext): Init the interface_resolve_order
27866 and type_container_resolve_order always.
27868 (ResolveCore, BootstrapCorlib_ResolveClass,
27869 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27870 compiler when compiling with --nostdlib
27872 * class.cs (TypeContainer.DefineType): Check that our parent is
27873 not null. This test is most important when we are bootstraping
27876 * codegen.cs: Split out the symbol writing code.
27878 2002-03-25 Martin Baulig <martin@gnome.org>
27880 * driver.cs (-g): Made -g an alias for --debug.
27882 2002-03-24 Martin Baulig <martin@gnome.org>
27884 * codegen.cs (SymbolWriter): New public variable. Returns the
27885 current symbol writer.
27886 (CodeGen): Added `bool want_debugging_support' argument to the
27887 constructor. If true, tell the ModuleBuild that we want debugging
27888 support and ask it for the ISymbolWriter.
27889 (Save): If we have a symbol writer, call it's Close() method after
27890 saving the assembly.
27892 * driver.c (--debug): New command line argument to create a
27893 debugger information file.
27895 * location.cs (SymbolDocument): New public property. Returns an
27896 ISymbolDocumentWriter object for the current source file or null
27897 if we don't have a symbol writer.
27899 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27901 * driver.cs (LoadAssembly): Correctly return when all the paths
27902 have been tried and not before.
27904 * statement.cs (Switch.Emit): return the actual coverage for this
27905 statement (returns/not-returns)
27907 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27908 switch of the statement if we are the last switch section. That
27909 kills two problems: try/catch problems (we used to emit an empty
27910 nop at the end) and switch statements where all branches would
27913 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27915 * driver.cs: Add default assemblies (the equivalent to the
27916 Microsoft CSC.RSP file)
27918 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27919 also update tokens_seen and set it to false.
27921 * driver.cs: Implement --recurse for Mike.
27923 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27924 correctly splitting out the paths.
27926 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27928 * interface.cs (Interface.PopulateProperty): Instead of using
27929 `parent' as the declaration space for the set parameters, use
27932 * support.cs (InternalParameters): InternalParameters constructor
27933 takes a DeclSpace instead of a TypeContainer.
27935 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27936 types are being initialized, load the address of it before calling
27939 (New): Provide a mechanism to disable the generation of local
27940 value type temporaries when the caller will be providing us with
27941 an address to store it.
27943 (ArrayCreation.EmitDynamicInitializers): Use it.
27945 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27947 * expression.cs (Invocation.EmitArguments): Only probe for array
27948 property if there is more than one argument. Sorry about that.
27950 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27951 empty param arrays.
27953 * class.cs (Method.LabelParameters): Fix incorrect code path that
27954 prevented the `ParamArrayAttribute' from being applied to the
27957 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27959 * support.cs (ReflectionParameters): Correctly compute whether the
27960 last argument is a params array. Fixes the problem with
27963 * typemanager.cs: Make the assemblies array always be non-null
27964 (empty, but non-null)
27966 * tree.cs (RecordDecl): New function that abstracts the recording
27967 of names. This reports error 101, and provides a pointer to the
27968 previous declaration. Fixes a crash in the compiler.
27970 * cs-parser.jay (constructor_declaration): Update to new grammar,
27971 and provide a constructor_body that can be empty.
27973 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27975 * driver.cs: Add support for --resources.
27977 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27978 Make all types for the various array helper methods be integer.
27980 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27981 CheckState to ConvCast.
27983 (ConvCast): Now it takes a `checked' state argument, to avoid
27984 depending on the emit context for the conversion, and just using
27985 the resolve time setting.
27987 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27988 instead of Invocation.EmitArguments. We do not emit the original
27989 arguments, instead we emit those which have been converted to
27990 unsigned int expressions.
27992 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27994 * codegen.cs: ditto.
27996 * expression.cs (LocalVariableReference): Drop the use of the
27997 Store function that depended on the variable index.
27999 * statement.cs (VariableInfo): Drop the `Idx' property from this
28000 class, as this is not taking into account the indexes for
28001 temporaries tat we generate during the execution, getting the
28004 * class.cs: First emit class initializers, then call the parent
28007 * expression.cs (Binary): Fix opcode emision.
28008 (UnaryMutator.EmitCode): Support checked code generation
28010 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
28011 matches for events for both the Static and Instance scans,
28012 pointing to the same element. Fix that.
28014 2002-03-14 Miguel de Icaza <miguel@ximian.com>
28016 * rootcontext.cs (ResolveTree): Always set the
28017 interface_resolve_order, because nested interfaces will be calling
28020 * class.cs (GetInterfaceOrClass): Track the same resolution
28021 process used by TypeManager.LookupType. This fixes the nested
28022 type lookups in class declarations (separate path from
28025 (TypeContainer.DefineType): Also define nested interfaces.
28026 (TypeContainer.RegisterOrder): New public function used to
28027 register the order in which child interfaces need to be closed.
28029 Nested interfaces need to be closed after their parents have been
28032 * interface.cs (InterfaceAttr): Put all the logic for computing
28033 the interface attribute here.
28035 (DefineInterface): Register our interface order with the
28036 RootContext or with the TypeContainer depending on the case.
28038 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28040 * cs-parser.jay: rework foreach statement to work with the new
28041 changes to the policy on SimpleNames.
28043 * report.cs: support Stacktrace on warnings as well.
28045 * makefile: drop --unsafe and /unsafe from the compile.
28047 2002-03-13 Ravi Pratap <ravi@ximian.com>
28049 * ecore.cs (StandardConversionExists): Modify to take an Expression
28050 as the first parameter. Ensure we do null -> reference type conversion
28053 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
28054 temporary Expression objects.
28056 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
28058 * interface.cs: workaround bug in method overloading resolution
28059 (there is already a bugzilla bug for it).
28061 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28063 We could also solve this problem by having a separate path for
28064 performing type lookups, instead of DoResolve, we could have a
28065 ResolveType entry point, and only participating pieces of the
28066 production (simplename, deref, array) would implement this.
28068 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
28069 signal SimpleName to only resolve type names and not attempt to
28070 resolve anything else.
28072 * expression.cs (Cast): Set the flag.
28074 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
28076 * class.cs: Only report 108 if there is no `new' modifier.
28078 * cs-parser.jay: rework foreach statement to work with the new
28079 changes to the policy on SimpleNames.
28081 * report.cs: support Stacktrace on warnings as well.
28083 * makefile: drop --unsafe and /unsafe from the compile.
28085 2002-03-11 Miguel de Icaza <miguel@ximian.com>
28087 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28088 lookups here, instead of doing that at parse time. This means
28089 that our grammar will not introduce `LocalVariableReferences' as
28090 expressions at this point. That solves the problem of code like
28094 static void Main ()
28098 This is only half the fix. The full fix requires parameters to
28099 also be handled in this way.
28101 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
28102 makes the use more obvious of the DeclSpace. The
28103 ec.TypeContainer.TypeBuilder is now only used to pull the
28104 TypeBuilder for it.
28106 My theory is that I can get rid of the TypeBuilder completely from
28107 the EmitContext, and have typecasts where it is used (from
28108 DeclSpace to where it matters).
28110 The only pending problem is that the code that implements Aliases
28111 is on TypeContainer, and probably should go in DeclSpace.
28113 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28114 lookups here, instead of doing that at parse time. This means
28115 that our grammar will not introduce `LocalVariableReferences' as
28116 expressions at this point. That solves the problem of code like
28120 static void Main ()
28124 This is only half the fix. The full fix requires parameters to
28125 also be handled in this way.
28127 * class.cs (Property.DefineMethod): When implementing an interface
28128 method, set newslot, when implementing an abstract method, do not
28129 set the flag (before we tried never setting it, or always setting
28130 it, which is the difference).
28131 (Indexer.DefineMethod): same.
28132 (Method.DefineMethod): same.
28134 * ecore.cs: Only set the status used flag if we get back a Field.
28136 * attribute.cs: Temporary hack, so Paolo can keep working.
28138 2002-03-08 Ravi Pratap <ravi@ximian.com>
28140 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28141 the unmanaged type in the case we have a MarshalAs attribute.
28143 (Resolve): Handle the case when we are parsing the special MarshalAs
28144 attribute [we need to store the unmanaged type to use later]
28146 * typemanager.cs (marshal_as_attr_type): Built in type for the
28147 MarshalAs Attribute.
28149 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28150 on parameters and accordingly set the marshalling info.
28152 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28154 * class.cs: Optimizing slightly by removing redundant code after
28155 we switched to the `NoTypes' return value.
28156 (Property.DefineMethod): use NoTypes here too.
28158 This fixes the bug I introduced in my last batch of changes.
28160 2002-03-05 Ravi Pratap <ravi@ximian.com>
28162 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28164 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28165 Enums since those are types too.
28167 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28169 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28170 thanks to a call during the lookup process.
28172 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28174 * statement.cs (Foreach): Lots of work to accomodate a particular
28175 kind of foreach statement that I had not kept in mind. It is
28176 possible to have foreachs on classes that provide a GetEnumerator
28177 method that return objects that implement the "pattern" for using
28178 a foreach, there is no need to support GetEnumerator
28181 This is needed to compile nant.
28183 * decl.cs: Only report 114 if the member is not `Finalize' and if
28184 the warning level is at least 2.
28186 * class.cs: Moved the compare function from Method to
28189 (MethodSignature.InheritableMemberSignatureCompare): Add new
28190 filter function that is used to extract inheritable methods from a
28193 (Method.Define): Use the new `inheritable_method_signature_filter'
28196 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28199 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28201 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28203 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28205 * expression.cs: Pass location information to
28206 ConvertImplicitStandard.
28208 * class.cs: Added debugging code to track return values from
28211 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28213 * expression.cs (Is.DoResolve): If either side of the `is' is an
28214 interface, do not flag the warning.
28216 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28219 * report.cs: Allow for --fatal to be used with --probe.
28221 * typemanager.cs (NoTypes): Move the definition for the empty Type
28224 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28226 (TypeContainer.DefineProxy): New function used to proxy to parent
28227 implementations when implementing interfaces.
28228 (TypeContainer.ParentImplements): used to lookup if our parent
28229 implements a public function that is required by an interface.
28230 (TypeContainer.VerifyPendingMethods): Hook this up.
28232 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28233 `modules' and `assemblies' arraylists into arrays. We only grow
28234 these are the very early start up of the program, so this improves
28235 the speedof LookupType (nicely measured).
28237 * expression.cs (MakeByteBlob): Replaced unsafe code with
28238 BitConverter, as suggested by Paolo.
28240 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28241 folding of string concatenation, but if either side is a string,
28242 and the other is not, then return null, and let the runtime use
28243 the concatenation on the string plus the object (using
28244 `Object.ToString').
28246 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28248 Constant Folding has been implemented now.
28250 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28251 the error instead on types that are not supported in one's
28254 * constant.cs (Constant and all children): New set of functions to
28255 perform implict and explicit conversions.
28257 * ecore.cs (EnumConstant): Implement the new functions to perform
28258 conversion by proxying to the child expression.
28260 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28261 own separate setting that can not be turned off from the command
28262 line using --unchecked or --checked and is only controlled using
28263 the checked/unchecked statements and expressions. This setting is
28264 used by the constant folder to flag errors.
28266 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28267 ConstantCheckState as well.
28269 During Resolve, they also have to flag the state, because the
28270 constant folder runs completely in the Resolve phase.
28272 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28275 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28277 * cfold.cs: New file, this file contains the constant folder.
28279 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28280 argument to track whether we are using the resulting address to
28281 load or store a value and provide better error messages.
28283 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28284 new AddressOf arguments.
28286 * statement.cs (Foreach.EmitCollectionForeach): Update
28288 * expression.cs (Argument.Emit): Call AddressOf with proper
28289 arguments to track usage.
28291 (New.DoEmit): Call AddressOf with new arguments.
28293 (Unary.Emit): Adjust AddressOf call.
28295 2002-03-01 Ravi Pratap <ravi@ximian.com>
28297 * cs-parser.jay (member_access): Change the case for pre-defined types
28298 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28301 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28304 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28305 essentially like methods and apply attributes like MethodImplOptions to them too.
28307 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28310 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28311 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28314 * Update code everywhere accordingly.
28316 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28318 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28320 2002-02-28 Ravi Pratap <ravi@ximian.com>
28322 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28323 try performing lookups against those instead of jumping straight into using
28324 the 'using' clauses.
28326 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28328 (LookupType): Perform lookups in implicit parents too.
28330 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28331 sequence as RootContext.LookupType.
28333 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28334 the various cases of namespace lookups into this method.
28336 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28338 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28339 in positional arguments)
28341 * class.cs (Operator): Update the AllowedModifiers to contain
28344 * cs-parser.jay: Update operator declaration to allow for the
28345 operator body to be empty.
28347 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28350 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28352 * class.cs (Method.Emit): Label parameters.
28354 * driver.cs: Return 1 or 0 as the program exit code.
28356 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28358 * expression.cs: Special case the `null' object when trying to
28359 auto-compute the type, as anything can be explicitly converted to
28362 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28363 spotting this Paolo.
28365 (Expression.ImplicitNumericConversion): Perform comparissions of
28366 the type using the underlying type in the case of an enumeration
28367 rather than using the enumeration type for the compare.
28369 Cope with the underlying == type case, which is not possible to
28372 (Expression.ConvertNumericExplicit): Perform comparissions of
28373 the type using the underlying type in the case of an enumeration
28374 rather than using the enumeration type for the compare.
28376 * driver.cs: If the user does not supply an extension, assume .exe
28378 * cs-parser.jay (if_statement): Rewrote so that we can track the
28379 location for the if statement.
28381 * expression.cs (Binary.ConstantFold): Only concat strings when
28382 the operation is "+", not everything ;-)
28384 * statement.cs (Statement.EmitBoolExpression): Take a location
28386 (If, While, Do): Track location.
28388 * expression.cs (Binary.ResolveOperator): In the object + string
28389 case, I was missing a call to ConvertImplicit
28391 2002-02-25 Ravi Pratap <ravi@ximian.com>
28393 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28394 Location arguments. Ensure we use RootContext.LookupType to do our work
28395 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28397 * interface.cs (PopulateMethod): Handle the type of the parameter being
28400 * expression.cs (Invocation.BetterFunction): Handle the case when we
28401 have a params method with no fixed arguments and a call is made with no
28404 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28406 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28407 the verbatim-string-literal
28409 * support.cs (InternalParameters.ParameterModifier): handle null
28411 (InternalParameters.ParameterType): ditto.
28413 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28414 duplicating the name of the variable parameter.
28415 (GetParameterByName): Fix bug where we were not looking up array
28416 paramters if they were the only present (thanks Paolo!).
28417 (GetParameterInfo): We only have an empty set of types if both
28418 fixed and array are set to null.
28419 (GetParameterInfo-idx): Handle FixedParameter == null
28421 * cs-parser.jay: Handle the case where there is no catch
28422 statements (missing null test).
28424 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28426 * driver.cs (MainDriver): Be conservative on our command line
28429 Catch DirectoryNotFoundException when calling GetFiles.
28431 (SplitPathAndPattern): Used to split the input specification into
28432 a path and a pattern that we can feed to Directory.GetFiles.
28434 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28436 * statement.cs (Fixed): Implement the last case of the Fixed
28437 statement (string handling).
28439 * expression.cs (StringPtr): New class used to return a char * to
28440 a string; Used by the Fixed statement.
28442 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28444 * expression.cs (Binary.ResolveOperator): Remove redundant
28445 MemberLookup pn parent type.
28446 Optimize union call, we do not need a union if the types are the same.
28447 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28450 Specialize the use of MemberLookup everywhere, instead of using
28451 the default settings.
28453 (StackAlloc): Implement stackalloc keyword.
28455 * cs-parser.jay: Add rule to parse stackalloc.
28457 * driver.cs: Handle /h, /help, /?
28459 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28460 before we supported unsafe code.
28462 * makefile: add --unsafe to the self compilation of mcs.
28464 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28466 * expression.cs (PointerArithmetic): New class that is used to
28467 perform pointer arithmetic.
28468 (Binary.Resolve): Handle pointer arithmetic
28469 Handle pointer comparission.
28470 (ArrayPtr): Utility expression class that is used to take the
28471 address of an array.
28473 (ElementAccess): Implement array access for pointers
28475 * statement.cs (Fixed): Implement fixed statement for arrays, we
28476 are missing one more case before we are done.
28478 * expression.cs (Indirection): Implement EmitAssign and set the
28479 ExprClass to Variable. This allows pointer dereferences to be
28480 treated as variables, and to have values assigned to them.
28482 * ecore.cs (Expression.StoreFromPtr): New utility function to
28483 store values dereferencing.
28485 2002-02-20 Ravi Pratap <ravi@ximian.com>
28487 * expression.cs (Binary.ResolveOperator): Ensure that we are
28488 not trying to operate on a void type - this fixes the reported
28491 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28492 the parent implementation is sealed.
28494 * ../errors/cs0239.cs : Add.
28496 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28498 * typemanager.cs (unverifiable_code_type): Corresponds to
28499 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28500 which have unsafe code in them.
28502 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28505 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28507 * cs-tokenizer.cs: Add support for @"litreal strings"
28509 Make tokenizer accept pre-processor directives
28510 on any column (remove the old C-like limitation).
28512 * rootcontext.cs (EmitCode): Emit any global attributes.
28513 (AddGlobalAttributes): Used to keep track of assembly attributes.
28515 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28517 * cs-parser.jay: Add support for global attributes.
28519 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28521 * expression.cs (Indirection): New helper class. Unary will
28522 create Indirection classes to be able to implement the
28523 IMemoryLocation interface on it.
28525 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28527 * cs-parser.jay (fixed_statement): reference the right statement.
28529 * statement.cs (Fixed.Emit): Finish implementing the fixed
28530 statement for the &x case.
28532 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28534 * class.cs (Property.Define, Method.Define): Remove newslot when
28537 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28538 wrong. NewSlot should only be used if the `new' keyword is present.
28540 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28541 locating our system dir. Sorry about this.
28543 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28545 * driver.cs (GetSystemDir): Compute correctly the location of our
28546 system assemblies. I was using the compiler directory instead of
28547 the library directory.
28549 2002-02-13 Ravi Pratap <ravi@ximian.com>
28551 * expression.cs (BetterFunction): Put back in what Miguel commented out
28552 since it is the correct fix. The problem is elsewhere ;-)
28554 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28555 parameters of the parms method are themselves compatible or not !
28557 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28558 to check that a class implements an interface before saying that an implicit
28559 conversion was allowed. Use ImplementsInterface to do the checking.
28561 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28563 * class.cs (Method.Define): Track whether we are an explicit
28564 implementation or not. And only call DefineMethodOverride if we
28565 are an explicit implementation.
28567 (Property.DefineMethod): Ditto.
28569 2002-02-11 Ravi Pratap <ravi@ximian.com>
28571 * expression.cs (BetterFunction): Catch hideous bug which was
28572 preventing us from detecting ambiguous calls due to implicit casts i.e
28575 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28577 * support.cs (Pair): Remove un-needed method. I figured why I was
28578 getting the error in cs-parser.jay, the variable in a foreach loop
28579 is readonly, and the compiler does not really treat this as a variable.
28581 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28582 instead of EQUALS in grammar.
28584 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28586 * expression.cs (Unary.DoResolve): Check whether the argument is
28589 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28591 * support.cs: Api for Pair to set a value. Despite the fact that
28592 the variables are public the MS C# compiler refuses to compile
28593 code that accesses the field if the variable is part of a foreach
28596 * statement.cs (Fixed): Begin implementation of the fixed
28599 (Block.AddVariable): Return the VariableInfo on success and null
28600 on failure instead of true/false.
28602 * cs-parser.jay (foreach): Catch errors on variables already
28603 defined (we were ignoring this value before) and properly unwind
28604 the block hierarchy
28606 (fixed_statement): grammar for the fixed statement.
28608 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28610 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28611 pointer types to be incretemented.
28613 (SizeOf): Implement.
28615 * cs-parser.jay (pointer_member_access): Implement
28616 expr->IDENTIFIER production.
28618 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28619 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28622 (Unary): Implement indirection.
28624 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28625 use in non-unsafe context).
28627 (SimpleName.DoResolve): Check for pointers in field access on safe
28630 (Expression.LoadFromPtr): Factor the load-indirect code in this
28631 function. This was duplicated in UnboxCast and ParameterReference
28633 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28635 * expression.cs (ComposedCast): report an error if a pointer cast
28636 is used in a safe region.
28638 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28639 pointer type casts in unsafe context.
28641 * codegen.cs (EmitContext): Set up IsUnsafe.
28643 * cs-parser.jay (non_expression_type): Add productions for pointer
28646 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28647 code. We should not use force into static mode if the method is
28648 not virtual. Fixes bug in MIS
28650 * statement.cs (Do.Emit, While.Emit, For.Emit,
28651 Statement.EmitBoolExpression): Add support to Do and While to
28652 propagate infinite loop as `I do return' semantics.
28654 Improve the For case to also test for boolean constants.
28656 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28657 to the list of attributes we can add.
28659 Remove `EmitContext' argument.
28661 * class.cs (Method.Define): Apply parameter attributes.
28662 (Constructor.Define): Apply parameter attributes.
28663 (MethodCore.LabelParameters): Move here the core of labeling
28666 * support.cs (ReflectionParameters.ParameterModifier,
28667 InternalParameters.ParameterModifier): Use IsByRef on the type and
28668 only return the OUT bit for these parameters instead of in/out/ref
28671 This is because I miss-understood things. The ParameterInfo.IsIn
28672 and IsOut represent whether the parameter has the [In] and [Out]
28675 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28677 * ecore.cs (FieldExpr.Emit): Release temporaries.
28679 * assign.cs (LocalTemporary.Release): new function.
28681 * codegen.cs (EmitContext.GetTemporaryStorage,
28682 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28683 temporary storage. Now we can "put back" localbuilders when we
28686 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28688 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28689 need to make a copy of the variable to generate verifiable code.
28691 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28693 * driver.cs: Compute dynamically the system directory.
28695 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28696 Slower, but more generally useful. Used by the abstract
28697 registering implementation.
28699 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28700 the rules for the special rule on Type/instances. First check if
28701 we have the same name, and if so, try that special static path
28702 rather than the instance path.
28704 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28706 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28709 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28710 Enum, ValueType, Delegate or Array for non-corlib compiles.
28712 * cs-tokenizer.cs: Catch long identifiers (645)
28714 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28717 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28718 fix, we were returning too early, so we were not registering
28719 pending methods from abstract classes.
28721 Do not register pending methods if the class is abstract.
28723 * expression.cs (Conditional.DoResolve): Report circular implicit
28724 conversions when we neecd to compute it for conditional
28727 (Is.DoResolve): If the expression is always of the provided type,
28728 flag warning 183. If the expression can not ever be of the
28729 provided type flag warning 184.
28731 * class.cs: Catch 169 as well.
28733 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28736 2002-01-18 Nick Drochak <ndrochak@gol.com>
28738 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28740 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28742 * interface.cs: (PopulateMethod): Check for pointers being defined
28743 only if the unsafe context is active.
28744 (PopulateProperty): ditto.
28745 (PopulateIndexer): ditto.
28747 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28748 specified. If pointers are present, make sure that they are
28749 present in an unsafe context.
28750 (Constructor, Constructor.Define): ditto.
28751 (Field, Field.Define): ditto.
28752 (Property, Property.Define): ditto.
28753 (Event, Event.Define): ditto.
28755 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28756 hashtable if there are classes or structs defined.
28758 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28759 code, as the constant resolution moved.
28761 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28762 the metadata, so we can flag error 133.
28764 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28765 pointer is being declared in an unsafe context.
28767 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28769 * modifiers.cs (Modifiers.Check): Require a Location argument.
28770 Report error 227 for Unsafe use.
28772 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28774 * statement.cs (For.Emit): If the test is null, then report that
28775 we do `return', as we wont reach anything afterwards.
28777 (Switch.SwitchGoverningType): Track the expression that matched
28780 * driver.cs: Allow negative numbers as an error code to flag.
28782 * cs-parser.jay: Handle 1551.
28784 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28786 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28788 * cs-parser.jay: Report 1518 (type declaration can only contain
28789 class, struct, interface, enum or delegate)
28791 (switch_label): Report 1523 (keywords `case' or `default' must
28794 (opt_switch_sections): Report 1522 (empty switch)
28796 * driver.cs: Report 1515 (response file specified multiple times)
28797 Report 1516 (Source file specified multiple times).
28799 * expression.cs (Argument.Resolve): Signal 1510
28801 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28802 access not allowed in static code)
28804 2002-01-11 Ravi Pratap <ravi@ximian.com>
28806 * typemanager.cs (IsPointerType): Utility method which we are going
28809 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28810 the object type, so we take care of that.
28812 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28814 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28815 added to non-params parameters :-)
28817 * typemanager.cs (CSharpName): Include 'void' type too.
28819 (void_ptr_type): Include in the set of core types.
28821 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28824 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28827 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28828 completely forgotten about it.
28830 2002-01-10 Ravi Pratap <ravi@ximian.com>
28832 * cs-parser.jay (pointer_type): Add. This begins our implementation
28833 of parsing rules for unsafe code.
28835 (unsafe_statement): Implement.
28837 (embedded_statement): Modify to include the above.
28839 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28841 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28842 if the current context is an unsafe one.
28844 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28845 are handled differently, we need separate rules for them.
28847 (local_variable_declaration): Update to use local_variable_pointer_type
28848 to allow variable declarations of unmanaged pointer types.
28850 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28851 in unsafe contexts.
28853 * ../errors/cs0214.cs : Add.
28855 2002-01-16 Nick Drochak <ndrochak@gol.com>
28857 * makefile: remove 'response' file when cleaning.
28859 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28861 * cs-parser.jay: Report 1524.
28863 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28865 * typemanager.cs (RegisterMethod): drop checking if we have
28866 registered this from here
28868 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28870 * class.cs (Method.EmitDestructor): Implement calling our base
28873 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28874 value of InFinally.
28876 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28877 this routine and will wrap the call in a try/catch block. Deal
28880 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28882 * ecore.cs (Expression.MemberLookup): instead of taking a
28883 parameter `same_type' that was used to tell whether we could
28884 access private members we compute our containing type from the
28887 (FieldExpr): Added partial support for volatile fields. This does
28888 not work for volatile fields exposed from assemblies, as I can not
28889 figure out how to extract the modreq from it.
28891 Updated all the source files to use this.
28893 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28894 because it is referenced by MemberLookup very often.
28896 2002-01-09 Ravi Pratap <ravi@ximian.com>
28898 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28899 TypeBuilder.GetCustomAttributes to retrieve what we need.
28901 Get rid of redundant default_member_attr_type as this is the same as
28902 default_member_type which already exists.
28904 * interface.cs, attribute.cs : Update accordingly.
28906 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28908 * typemanager.cs: Enable IndexerPropertyName again. It does not
28909 work for TYpeBuilders though. Ravi, can you please fix this?
28911 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28913 * expression.cs (Argument.Emit): Handle the case of ref objects
28914 being passed to ref functions;
28916 (ParameterReference.EmitLoad): Loads the content of the pointer
28917 without dereferencing.
28919 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28921 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28923 2002-01-08 Ravi Pratap <ravi@ximian.com>
28925 * class.cs (Indexer.DefineMethod): Incorporate the interface
28926 type in the name of the method if we are doing explicit interface
28929 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28931 (BetterConversion): Fix extremely trivial bug where we were referring to
28932 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28935 * ../errors/bug16.cs : Add although we have fixed it.
28937 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28939 * expression.cs (BaseIndexer): Begin implementation.
28941 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28943 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28944 production directly to remove a shift/reduce, and implement
28945 explicit interface implementation.
28947 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28948 after a floating point suffix.
28950 * expression.cs (DoNumericPromotions): Improved the conversion for
28951 uint/uint. If we have a constant, we avoid doing a typecast to a
28954 * class.cs (Indexer): Implement explicit interface implementation
28957 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28959 * class.cs: make the default instance constructor public and hidebysig.
28961 2001-01-03 Ravi Pratap <ravi@ximian.com>
28963 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28964 so we can call it from elsewhere.
28966 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28967 we emit it internally if the class has a defined indexer; otherwise the user
28968 emits it by decorating the class definition with the DefaultMemberAttribute.
28970 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28971 attribute is not used on a type which defines an indexer.
28973 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28974 character when we skip whitespace.
28976 * ../errors/cs0646.cs : Add.
28978 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28980 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28983 * makefile: Add practical target `mcs3.exe' which builds the third
28984 generation compiler.
28986 * expression.cs (New): Fix structures constructor calling.
28988 * class.cs (Property, Method, Indexer): Emit Final flag on the
28989 method if we are an interface implementation and we are not
28992 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28993 whether this property is referencing a `base' method.
28995 * expression.cs (Invocation.EmitCall): take an extra argument:
28996 is_base, this is used to determine whether the `call' or
28997 `callvirt' opcode should be used.
29000 * delegate.cs: update EmitCall.
29002 * class.cs (Method.Define): Set NewSlot for the cases where we are
29003 not implementing an interface method.
29005 (Property.Define): ditto.
29007 2002-01-02 Miguel de Icaza <miguel@ximian.com>
29009 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
29010 'r'. Allows mcs to parse itself fully.
29012 2002-01-02 Ravi Pratap <ravi@ximian.com>
29014 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
29015 of the number of initializers that require the InitializeArray method.
29017 (CheckIndices): Store the Expression in all cases - not the plain value. Also
29018 update the above field where necessary.
29020 (MakeByteBlob): Update accordingly.
29022 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
29025 (EmitDynamicInitializers): Update in accordance with the new optimization.
29027 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
29028 same OpCode applies.
29030 * cs-parser.jay : Fix some glaring errors I introduced.
29032 2002-01-01 Ravi Pratap <ravi@ximian.com>
29034 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
29035 so that we can check for name clashes there too.
29037 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
29038 for interface indexers.
29040 * interfaces.cs (Define): Emit the default member attribute.
29042 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
29043 variable was being referred to while setting the value ;-)
29045 2002-01-01 Miguel de Icaza <miguel@ximian.com>
29047 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
29048 byte-by-byte information when we know the data is zero.
29050 Make the block always a multiple of 4, because
29051 DefineInitializedData has a bug.
29053 * assign.cs: Fix, we should assign from the temporary, not from
29056 * expression.cs (MakeByteBlob): Fix my incorrect code.
29058 2001-12-31 Miguel de Icaza <miguel@ximian.com>
29060 * typemanager.cs (EnumToUnderlying): This function is used to get
29061 the underlying type from an enumeration, because it does not
29064 * constant.cs: Use the I4_S form for values between -128 and 127.
29066 * statement.cs (Block.LookupLabel): Looks up a label.
29067 (Block): Drop support for labeled blocks.
29069 (LabeledStatement): New kind of statement that represents a label
29072 (Goto): Finally implement this bad boy.
29074 * cs-parser.jay: Update to reflect new mechanism to implement
29077 2001-12-30 Miguel de Icaza <miguel@ximian.com>
29079 * codegen.cs (EmitContext.This): a codegen property that keeps the
29080 a single instance of this instead of creating many different this
29083 * delegate.cs (Delegate.DoResolve): Update to use the property;
29085 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
29087 * expression.cs (BaseAccess.DoResolve): Ditto.
29089 2001-12-29 Ravi Pratap <ravi@ximian.com>
29091 * typemanager.cs (methodimpl_attr_type): Add to hold the type
29092 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
29094 (InitCoreTypes): Update accordingly.
29096 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
29097 so we can quickly store the state.
29099 (ApplyAttributes): Set the correct implementation flags
29100 for InternalCall methods.
29102 2001-12-29 Miguel de Icaza <miguel@ximian.com>
29104 * expression.cs (EmitCall): if a method is not virtual, then do
29105 not use callvirt on it.
29107 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
29108 user defined stuff) requires the use of stobj, which takes an
29109 address on the stack instead of an array and an index. So emit
29110 the Ldelema operation for it.
29112 (EmitStoreOpcode): Use stobj for valuetypes.
29114 (UnaryMutator.EmitCode): Use the right 1 value depending on
29115 whether we are dealing with int64/uint64, float or doubles.
29117 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29118 constructors that I implemented last night.
29120 (Constructor.IsDefault): Fix to work properly for static
29123 * cs-parser.jay (CheckDef): report method signature errors.
29124 Update error number 103 to be 132.
29126 * decl.cs: New AdditionResult enumeration value: MethodExists.
29127 Although we do this check for methods later on in the semantic
29128 analysis, catching repeated default constructors is so easy that
29129 we catch these here.
29131 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29134 (ParameterReference.EmitAssign, Emit): handle
29137 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29138 (ArrayAccess.EmitStoreOpcode): ditto.
29140 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29142 * expression.cs (MakeByteBlob): Complete all the missing types
29143 (uint, short, ushort, byte, sbyte)
29145 * class.cs: Only init instance field initializers on instance
29148 Rename `constructors' to instance_constructors.
29150 (TypeContainer.AddConstructor): Only add constructors to the list
29151 if it is not static.
29153 Make sure that we handle default_static_constructor independently
29154 everywhere where we handle instance_constructors
29156 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29158 * class.cs: Do not lookup or create a base initializer for a
29159 static constructor.
29161 (ConstructorInitializer.Resolve): use the proper type to lookup
29164 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29166 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29169 * decl.cs: CloseType is now an virtual method, the default
29170 implementation just closes this type.
29172 2001-12-28 Ravi Pratap <ravi@ximian.com>
29174 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29175 to PreserveSig by default. Also emit HideBySig on such methods.
29177 Basically, set the defaults to standard values.
29179 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29180 argument, if candidate is better, it can't be worse than the best !
29182 (Invocation): Re-write bits to differentiate between methods being
29183 applicable in their expanded form and their normal form - for params
29186 Get rid of use_standard everywhere as only standard conversions are allowed
29187 in overload resolution.
29189 More spec conformance.
29191 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29193 * driver.cs: Add --timestamp, to see where the compiler spends
29196 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29197 `this' in static code.
29199 (SimpleName.DoResolve): Implement in terms of a helper function
29200 that allows static-references to be passed upstream to
29203 (Expression.ResolveWithSimpleName): Resolve specially simple
29204 names when called by MemberAccess to implement the special
29207 (Expression.ImplicitReferenceConversion): Handle conversions from
29208 Null to reference types before others, as Null's type is
29211 * expression.cs (Invocation.EmitCall): Handle the special case of
29212 calling methods declared on a reference type from a ValueType
29213 (Base classes System.Object and System.Enum)
29215 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29216 the left hand side is a TypeExpr, not on every enumeration.
29218 (Binary.Resolve): If types are reference types, then do a cast to
29219 object on operators != and == of both arguments.
29221 * typemanager.cs (FindMembers): Extract instance and static
29222 members if requested.
29224 * interface.cs (PopulateProperty): Use void_type instead of null
29225 as the return type for the setter method.
29227 (PopulateIndexer): ditto.
29229 2001-12-27 Ravi Pratap <ravi@ximian.com>
29231 * support.cs (ReflectionParameters): Fix minor bug where we
29232 were examining the wrong parameter for the ParamArray attribute.
29234 Cope with requests for the type of the parameter at position
29235 greater than the params parameter's. We now return the element
29236 type of the params array as that makes more sense.
29238 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29239 accordingly as we no longer have to extract the element type
29242 (Invocation.OverloadResolve): Update.
29244 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29246 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29247 against IEnumerator, test whether the return value is a descendant
29248 of the IEnumerator interface.
29250 * class.cs (Indexer.Define): Use an auxiliary method to implement
29251 the other bits of the method definition. Begin support for
29252 explicit interface implementation.
29254 (Property.DefineMethod): Use TypeManager.void_type instead of null
29255 for an empty return value.
29257 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29259 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29260 dealing with a FieldExpr which is composed of a FieldBuilder, in
29261 the code path we did extract the constant, but we should have
29262 obtained the underlying value to be able to cast it (otherwise we
29263 end up in an infinite loop, this is what Ravi was running into).
29265 (ArrayCreation.UpdateIndices): Arrays might be empty.
29267 (MemberAccess.ResolveMemberAccess): Add support for section
29268 14.5.4.1 that deals with the special case of E.I when E is a type
29269 and something else, that I can be a reference to a static member.
29271 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29272 handle a particular array type to create byte blobs, it is just
29273 something we dont generate byteblobs for.
29275 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29278 * location.cs (Push): remove the key from the hashtable that we
29279 are about to add. This happens for empty files.
29281 * driver.cs: Dispose files after we have parsed them.
29283 (tokenize): new function that only runs the tokenizer on its
29284 input, for speed testing.
29286 2001-12-26 Ravi Pratap <ravi@ximian.com>
29288 * class.cs (Event.Define): Define the private field only if there
29289 are no accessors defined.
29291 * expression.cs (ResolveMemberAccess): If there is no associated
29292 field with the event, that means we have an event defined with its
29293 own accessors and we should flag error cs0070 since transforming
29294 ourselves into a field is not valid in that case.
29296 * ecore.cs (SimpleName.DoResolve): Same as above.
29298 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29299 and charset to sane values.
29301 2001-12-25 Ravi Pratap <ravi@ximian.com>
29303 * assign.cs (DoResolve): Perform check on events only if they
29304 are being accessed outside the declaring type.
29306 * cs-parser.jay (event_declarations): Update rules to correctly
29307 set the type of the implicit parameter etc.
29309 (add_accessor, remove_accessor): Set current local parameters.
29311 * expression.cs (Binary): For delegate addition and subtraction,
29312 cast the return value from the method into the appropriate delegate
29315 2001-12-24 Ravi Pratap <ravi@ximian.com>
29317 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29318 of these as the workaround is unnecessary.
29320 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29321 delegate data - none of that is needed at all.
29323 Re-write bits to extract the instance expression and the delegate method
29326 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29329 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29330 of attaching attributes instead of duplicating code everywhere.
29332 * everywhere : Update code to do attribute emission using the above method.
29334 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29336 * expression.cs (IsParamsMethodApplicable): if there are not
29337 parameters, return immediately.
29339 * ecore.cs: The 0 literal can be implicity converted to an enum
29342 (SimpleName.DoResolve): First lookup the type, then lookup the
29345 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29346 want to get its address. If the InstanceExpression is not
29347 addressable, store the result in a temporary variable, then get
29350 * codegen.cs: Only display 219 errors on warning level or above.
29352 * expression.cs (ArrayAccess): Make it implement the
29353 IMemoryLocation interface.
29355 (Binary.DoResolve): handle the operator == (object a, object b)
29356 and operator != (object a, object b) without incurring into a
29357 BoxedCast (because 5 != o should never be performed).
29359 Handle binary enumerator operators.
29361 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29362 value type, otherwise use Ldelem_ref.
29364 Use precomputed names;
29366 (AddressOf): Implement address of
29368 * cs-parser.jay (labeled_statement): Fix recursive block
29369 addition by reworking the production.
29371 * expression.cs (New.DoEmit): New has a special case:
29373 If we are dealing with a ValueType, we have a few
29374 situations to deal with:
29376 * The target of New is a ValueType variable, that is
29377 easy, we just pass this as the variable reference
29379 * The target of New is being passed as an argument,
29380 to a boxing operation or a function that takes a
29383 In this case, we need to create a temporary variable
29384 that is the argument of New.
29387 2001-12-23 Ravi Pratap <ravi@ximian.com>
29389 * rootcontext.cs (LookupType): Check that current_type is not null before
29390 going about looking at nested types.
29392 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29393 not implement the IAssignMethod interface any more.
29395 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29396 where we tranform them into FieldExprs if they are being resolved from within
29397 the declaring type.
29399 * ecore.cs (SimpleName.DoResolve): Do the same here.
29401 * assign.cs (DoResolve, Emit): Clean up code considerably.
29403 * ../errors/bug10.cs : Add.
29405 * ../errors/cs0070.cs : Add.
29407 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29409 * assign.cs : Get rid of EventIsLocal everywhere.
29411 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29413 * ecore.cs (ConvertIntLiteral): finished the implementation.
29415 * statement.cs (SwitchLabel): Convert the value we are using as a
29416 key before looking up the table.
29418 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29420 * codegen.cs (EmitTopBlock): Require a Location argument now.
29422 * cs-parser.jay (constructor_declarator): We need to setup
29423 current_local_parameters before we parse the
29424 opt_constructor_initializer, to allow the variables to be bound
29425 to the constructor arguments.
29427 * rootcontext.cs (LookupType): First lookup nested classes in our
29428 class and our parents before we go looking outside our class.
29430 * expression.cs (ConstantFold): Extract/debox the values at the
29433 * rootcontext.cs (EmitCode): Resolve the constants first before we
29434 resolve the types. This is not really needed, but it helps debugging.
29436 * statement.cs: report location.
29438 * cs-parser.jay: pass location to throw statement.
29440 * driver.cs: Small bug fix.
29442 * report.cs: Updated format to be 4-zero filled digits.
29444 2001-12-22 Ravi Pratap <ravi@ximian.com>
29446 * expression.cs (CheckIndices): Fix minor bug where the wrong
29447 variable was being referred to ;-)
29449 (DoEmit): Do not call EmitStaticInitializers when the
29450 underlying type is System.Object.
29452 2001-12-21 Ravi Pratap <ravi@ximian.com>
29454 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29455 and do the usual workaround for SRE.
29457 * class.cs (MyEventBuilder.EventType): New member to get at the type
29458 of the event, quickly.
29460 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29462 * assign.cs (Assign.DoResolve): Handle the case when the target
29463 is an EventExpr and perform the necessary checks.
29465 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29468 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29470 (EventExpr): Set the type in the constructor itself since we
29471 are meant to be born fully resolved.
29473 (EventExpr.Define): Revert code I wrote earlier.
29475 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29476 instance expression is null. The instance expression is a This in that case
29477 or a null, depending on whether it is a static method or not.
29479 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29480 refers to more than one method.
29482 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29483 and accordingly flag errors.
29485 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29487 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29489 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29491 * location.cs (ToString): Provide useful rutine.
29493 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29495 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29496 objects, return the actual integral boxed.
29498 * statement.cs (SwitchLabel): define an ILLabel for each
29501 (Switch.CheckSwitch): If the value is a Literal, extract
29502 the underlying literal.
29504 Also in the unused hashtable we had, add the SwitchLabel so we can
29505 quickly look this value up.
29507 * constant.cs: Implement a bunch of new constants. Rewrite
29508 Literal based on this. Made changes everywhere to adapt to this.
29510 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29511 dereferencing array only once, and also copes with enumrations.
29513 bytes are two bytes wide, not one.
29515 (Cast): Perform constant conversions.
29517 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29518 wrappers to the literals here.
29520 * expression.cs (DoNumericPromotions): long literals can converted
29521 to ulong implicity (this is taken care of elsewhere, but I was
29522 missing this spot).
29524 * ecore.cs (Expression.Literalize): Make the return type Literal,
29525 to improve type checking.
29527 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29529 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29531 * literal.cs: Revert code from ravi that checked the bounds. The
29532 bounds are sane by the definition of the type itself.
29534 * typemanager.cs: Fix implementation of ImplementsInterface. We
29535 need to actually look up in our parent hierarchy for interfaces
29538 * const.cs: Use the underlying type for enumerations
29540 * delegate.cs: Compute the basename for the delegate creation,
29541 that should fix the delegate test case, and restore the correct
29542 Type Lookup semantics in rootcontext
29544 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29545 referencing a nested type with the Reflection API is using the "+"
29548 * cs-parser.jay: Do not require EOF token at the end.
29550 2001-12-20 Ravi Pratap <ravi@ximian.com>
29552 * rootcontext.cs (LookupType): Concatenate type names with
29553 a '.' instead of a '+' The test suite passes again.
29555 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29556 field of the enumeration.
29558 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29559 the case when the member is an EventExpr.
29561 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29562 static has an associated instance expression.
29564 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29566 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29568 * class.cs (Event.Define): Register event and perform appropriate checks
29571 We define the Add and Remove methods even if the use provides none because
29572 in that case, we provide default implementations ourselves.
29574 Define a private field of the type of the event. This is done by the CSC compiler
29575 and we should be doing it too ;-)
29577 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29578 More methods we use in code we generate.
29580 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29583 (InitCoreTypes): Update accordingly for the above.
29585 * class.cs (Event.Emit): Generate code for default accessors that we provide
29587 (EmitDefaultMethod): Do the job in the above.
29589 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29592 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29594 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29595 builders even if we were missing one.
29597 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29598 pass the Basename as our class name instead of the Name. The
29599 basename will be correctly composed for us.
29601 * parameter.cs (Paramters): Now takes a Location argument.
29603 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29604 make all the code call directly LookupType in RootContext and take
29605 this chance to pass the Location information everywhere.
29607 * Everywhere: pass Location information.
29609 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29611 * class.cs (Constructor.Define): Updated way of detecting the
29612 length of the parameters.
29614 (TypeContainer.DefineType): Use basename as the type name for
29617 (TypeContainer.Define): Do not recursively define types here, as
29618 definition is taken care in order by the RootContext.
29620 * tree.cs: Keep track of namespaces in a per-file basis.
29622 * parameter.cs (Parameter.ComputeSignature): Update to use
29625 (Parameters.GetSignature): ditto.
29627 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29628 instead of a TypeContainer.
29630 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29631 resolve names. Because we need to be resolve in our context, not
29634 * driver.cs: Implement response files.
29636 * class.cs (TypeContainer.DefineType): If we are defined, do not
29637 redefine ourselves.
29639 (Event.Emit): Emit the code for add/remove handlers.
29640 (Event.Define): Save the MethodBuilders for add/remove.
29642 * typemanager.cs: Use pair here too.
29644 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29645 DictionaryEntry requires the first argument to be non-null.
29647 (enum_declaration): Compute full name for registering the
29650 (delegate_declaration): Instead of using
29651 formal_parameter_list, use opt_formal_parameter_list as the list
29654 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29655 (EventParsing): New property that controls whether `add' and
29656 `remove' are returned as tokens or identifiers (for events);
29658 2001-12-19 Ravi Pratap <ravi@ximian.com>
29660 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29661 use MyEventBuilder only and let it wrap the real builder for us.
29663 (MyEventBuilder): Revamp constructor etc.
29665 Implement all operations that we perform on EventBuilder in precisely the same
29668 (FindMembers): Update to use the EventBuilder member.
29670 (Event.Emit): Update accordingly.
29672 2001-12-18 Ravi Pratap <ravi@ximian.com>
29674 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29675 by calling the appropriate methods.
29677 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29680 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29682 2001-12-17 Ravi Pratap <ravi@ximian.com>
29684 * delegate.cs (Delegate.Populate): Check that the return type
29685 and various parameters types are indeed accessible.
29687 * class.cs (Constructor.Define): Same here.
29689 (Field.Define): Ditto.
29691 (Event.Define): Ditto.
29693 (Operator.Define): Check that the underlying Method defined itself
29694 correctly - so it's MethodBuilder should not be null.
29696 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29697 expression happens to be null.
29699 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29700 members but as of now we don't seem to be able to do anything really useful with it.
29702 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29703 not the EventBuilder.
29705 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29707 * cs-tokenizer.cs: Add support for defines.
29708 Add support for #if, #elif, #else, #endif
29710 (eval_var): evaluates a variable.
29711 (eval): stubbed for evaluating functions.
29713 * cs-parser.jay: Pass the defines information
29715 * driver.cs: Add --define command line option.
29717 * decl.cs: Move MemberCore here.
29719 Make it the base class for DeclSpace. This allows us to catch and
29720 report 108 and 109 for everything now.
29722 * class.cs (TypeContainer.Define): Extract all the members
29723 before populating and emit the warning 108 (new keyword required
29724 to override) instead of having each member implement this.
29726 (MemberCore.Define): New abstract method, we will be using this in
29727 the warning reporting engine in Populate.
29729 (Operator.Define): Adjust to new MemberCore protocol.
29731 * const.cs (Const): This does not derive from Expression, it is a
29732 temporary object we use to create fields, it is a MemberCore.
29734 * class.cs (Method.Define): Allow the entry point to be in a
29737 * driver.cs: Rewrite the argument handler to clean it up a bit.
29739 * rootcontext.cs: Made it just an auxiliary namespace feature by
29740 making everything static.
29742 * driver.cs: Adapt code to use RootContext type name instead of
29745 * delegate.cs: Remove RootContext argument.
29747 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29750 * class.cs (Event.Define): The lookup can fail.
29752 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29754 * expression.cs: Resolve the this instance before invoking the code.
29756 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29758 * cs-parser.jay: Add a production in element_access that allows
29759 the thing to become a "type" reference. This way we can parse
29760 things like "(string [])" as a type.
29762 Note that this still does not handle the more complex rules of
29766 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29768 * ecore.cs: (CopyNewMethods): new utility function used to
29769 assemble the list of methods from running FindMembers.
29771 (MemberLookup): Rework FindMembers so that
29773 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29775 * class.cs (TypeContainer): Remove Delegates who fail to be
29778 * delegate.cs (Populate): Verify that we dont get null return
29779 values. TODO: Check for AsAccessible.
29781 * cs-parser.jay: Use basename to emit error 574 (destructor should
29782 have the same name as container class), not the full name.
29784 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29785 possible representation.
29787 Also implements integer type suffixes U and L.
29789 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29791 * expression.cs (ArrayCreation.DoResolve): We need to do the
29792 argument resolution *always*.
29794 * decl.cs: Make this hold the namespace. Hold the root context as
29796 (LookupType): Move here.
29798 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29800 * location.cs (Row, Name): Fixed the code, it was always returning
29801 references to the first file.
29803 * interface.cs: Register properties defined through interfaces.
29805 * driver.cs: Add support for globbing on the command line
29807 * class.cs (Field): Make it derive from MemberCore as well.
29810 2001-12-15 Ravi Pratap <ravi@ximian.com>
29812 * class.cs (Event::Define): Check that the type of the event is a delegate
29813 type else flag error #66.
29815 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29818 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29819 values of EntryPoint, CharSet etc etc.
29821 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29823 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29824 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29825 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29826 which needs this to do its work.
29828 * ../errors/cs0066.cs : Add.
29830 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29832 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29835 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29836 clears out the parameters field.
29837 (MemberSignatureCompare): Cleanup
29839 (MemberCore): New base class used to share code between MethodCore
29842 (RegisterRequiredImplementations) BindingFlags.Public requires
29843 either BindingFlags.Instace or Static. Use instance here.
29845 (Property): Refactored code to cope better with the full spec.
29847 * parameter.cs (GetParameterInfo): Return an empty array instead
29850 * class.cs (Property): Abstract or extern properties have no bodies.
29852 * parameter.cs (GetParameterInfo): return a zero-sized array.
29854 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29855 method modifier validation to the typecontainer so we can reuse
29856 this on properties.
29858 (MethodCore.ParameterTypes): return an empty sized array of types.
29860 (Property.Define): Test property modifier validity.
29862 Add tests for sealed/override too.
29864 (Method.Emit): abstract or extern methods have no bodies.
29866 2001-12-14 Ravi Pratap <ravi@ximian.com>
29868 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29871 (Method::Define, ::Emit): Modify accordingly.
29873 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29875 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29877 * makefile: Pass in /unsafe.
29879 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29881 * class.cs (MakeKey): Kill routine.
29883 * class.cs (TypeContainer.Define): Correctly define explicit
29884 method implementations (they require the full interface name plus
29887 * typemanager.cs: Deply the PtrHashtable here and stop using the
29888 lame keys. Things work so much better.
29890 This of course broke everyone who depended on `RegisterMethod' to
29891 do the `test for existance' test. This has to be done elsewhere.
29893 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29894 the object stupid Equals method (because, that like fails all over
29895 the place). We still do not use it.
29897 * class.cs (TypeContainer.SetRequiredInterface,
29898 TypeContainer.RequireMethods): Killed these two routines and moved
29899 all the functionality to RegisterRequiredImplementations.
29901 (TypeContainer.RegisterRequiredImplementations): This routine now
29902 registers all the implementations required in an array for the
29903 interfaces and abstract methods. We use an array of structures
29904 which can be computed ahead of time to reduce memory usage and we
29905 also assume that lookups are cheap as most classes will not
29906 implement too many interfaces.
29908 We also avoid creating too many MethodSignatures.
29910 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29911 clear the "pending" bit if we find that there are problems with
29914 (TypeContainer.VerifyPendingMethods): Update to report errors of
29915 methods that look like implementations but are not.
29917 (TypeContainer.Define): Add support for explicit interface method
29920 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29922 * typemanager.cs: Keep track of the parameters here instead of
29923 being a feature of the TypeContainer.
29925 * class.cs: Drop the registration of parameters here, as
29926 InterfaceMethods are also interface declarations.
29928 * delegate.cs: Register methods with the TypeManager not only with
29929 the TypeContainer. This code was buggy.
29931 * interface.cs: Full registation here.
29933 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29935 * expression.cs: Remove reducer for binary expressions, it can not
29938 * const.cs: Put here the code that used to go into constant.cs
29940 * constant.cs: Put here the code for constants, this is a new base
29941 class for Literals.
29943 * literal.cs: Make Literal derive from Constant.
29945 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29947 * statement.cs (Return.Emit): Report error 157 if the user
29948 attempts to return from a finally block.
29950 (Return.Emit): Instead of emitting a return, jump to the end of
29953 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29954 LocalBuilder to store the result of the function. ReturnLabel is
29955 the target where we jump.
29958 2001-12-09 Radek Doulik <rodo@ximian.com>
29960 * cs-parser.jay: remember alias in current namespace
29962 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29965 * class.cs (LookupAlias): lookup alias in my_namespace
29967 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29969 (LookupAlias): lookup alias in this and if needed in parent
29972 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29976 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29977 making things static. I need this to avoid passing the
29978 TypeContainer when calling ParameterType.
29980 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29981 that did string manipulation to compute the type and then call
29982 GetType. Use Parameter.ParameterType instead.
29984 * cs-tokenizer.cs: Consume the suffix for floating values.
29986 * expression.cs (ParameterReference): figure out whether this is a
29987 reference parameter or not. Kill an extra variable by computing
29988 the arg_idx during emission.
29990 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29991 function that returns whether a parameter is an out/ref value or not.
29993 (Parameter.ParameterType): The type of the parameter (base,
29994 without ref/out applied).
29996 (Parameter.Resolve): Perform resolution here.
29997 (Parameter.ExternalType): The full type (with ref/out applied).
29999 * statement.cs (Using.Emit, Using.EmitExpression): Implement
30000 support for expressions on the using statement.
30002 2001-12-07 Miguel de Icaza <miguel@ximian.com>
30004 * statement.cs (Using.EmitLocalVariableDecls): Split the
30005 localvariable handling of the using statement.
30007 (Block.EmitMeta): Keep track of variable count across blocks. We
30008 were reusing slots on separate branches of blocks.
30010 (Try.Emit): Emit the general code block, we were not emitting it.
30012 Check the type of the declaration to be an IDisposable or
30013 something that can be implicity converted to it.
30015 Emit conversions if required.
30017 * ecore.cs (EmptyExpression): New utility class.
30018 (Expression.ImplicitConversionExists): New utility function.
30020 2001-12-06 Miguel de Icaza <miguel@ximian.com>
30022 * statement.cs (Using): Implement.
30024 * expression.cs (LocalVariableReference): Support read only variables.
30026 * statement.cs: Remove the explicit emit for the Leave opcode.
30027 (VariableInfo): Add a readonly field.
30029 2001-12-05 Miguel de Icaza <miguel@ximian.com>
30031 * ecore.cs (ConvCast): new class used to encapsulate the various
30032 explicit integer conversions that works in both checked and
30033 unchecked contexts.
30035 (Expression.ConvertNumericExplicit): Use new ConvCast class to
30036 properly generate the overflow opcodes.
30038 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30040 * statement.cs: The correct type for the EmptyExpression is the
30041 element_type, not the variable type. Ravi pointed this out.
30043 2001-12-04 Ravi Pratap <ravi@ximian.com>
30045 * class.cs (Method::Define): Handle PInvoke methods specially
30046 by using DefinePInvokeMethod instead of the usual one.
30048 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
30049 above to do the task of extracting information and defining the method.
30051 2001-12-04 Ravi Pratap <ravi@ximian.com>
30053 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
30054 of the condition for string type.
30056 (Emit): Move that here.
30058 (ArrayCreation::CheckIndices): Keep string literals in their expression
30061 (EmitDynamicInitializers): Handle strings appropriately.
30063 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30065 * codegen.cs (EmitContext): Replace multiple variables with a
30066 single pointer to the current Switch statement.
30068 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
30071 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30075 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
30078 (Foreach.Emit): Foreach on arrays was not setting
30079 up the loop variables (for break/continue).
30081 (GotoCase): Semi-implented.
30083 2001-12-03 Ravi Pratap <ravi@ximian.com>
30085 * attribute.cs (CheckAttribute): Handle system attributes by using
30086 Attribute.GetAttributes to examine information we need.
30088 (GetValidPlaces): Same here.
30090 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
30092 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
30094 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
30096 (Method::Define): Set appropriate flags if we have a DllImport attribute.
30098 (Method::Emit): Handle the case when we are a PInvoke method.
30100 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30102 * expression.cs: Use ResolveWithSimpleName on compound names.
30104 2001-12-02 Ravi Pratap <ravi@ximian.com>
30106 * constant.cs (EmitConstant): Make sure we resolve the associated expression
30107 before trying to reduce it.
30109 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
30111 * constant.cs (LookupConstantValue): Implement.
30113 (EmitConstant): Use the above in emitting the constant.
30115 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30116 that are user-defined by doing a LookupConstantValue on them.
30118 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30121 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30123 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30125 (BaseAccess.DoResolve): Implement.
30127 (MemberAccess.DoResolve): Split this routine into a
30128 ResolveMemberAccess routine that can be used independently
30130 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30132 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30133 As that share bits of the implementation. Is returns a boolean,
30134 while As returns the Type that is being probed.
30136 2001-12-01 Ravi Pratap <ravi@ximian.com>
30138 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30139 instead of a Literal - much easier.
30141 (EnumInTransit): Remove - utterly useless :-)
30143 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30145 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30147 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30148 chain when we have no associated expression.
30150 2001-11-30 Ravi Pratap <ravi@ximian.com>
30152 * constant.cs (Define): Use Location while reporting the errror.
30154 Also emit a warning when 'new' is used and there is no inherited
30157 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30160 (LookupEnumValue): Implement to lookup an enum member's value and define it
30163 (Populate): Re-write accordingly to use the above routine.
30165 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30167 * expression.cs (This): Fix prototype for DoResolveLValue to
30168 override the base class DoResolveLValue.
30170 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30173 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30174 (we need to load the address of the field here). This fixes
30177 (FieldExpr.DoResolveLValue): Call the DoResolve
30178 function to initialize the Instance expression.
30180 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30181 correctly the GetEnumerator operation on a value type.
30183 * cs-parser.jay: Add more simple parsing error catches.
30185 * statement.cs (Switch): Add support for string switches.
30186 Handle null specially.
30188 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30190 2001-11-28 Ravi Pratap <ravi@ximian.com>
30192 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30194 (declare_local_constant): New helper function.
30196 * statement.cs (AddConstant): Keep a separate record of constants
30198 (IsConstant): Implement to determine if a variable is a constant.
30200 (GetConstantExpression): Implement.
30202 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30204 * statement.cs (IsVariableDefined): Re-write.
30206 2001-11-27 Ravi Pratap <ravi@ximian.com>
30208 * class.cs (TypeContainer::FindMembers): Look for constants
30209 in the case when we are looking for MemberTypes.Field
30211 * expression.cs (MemberAccess::DoResolve): Check that in the
30212 case we are a FieldExpr and a Literal, we are not being accessed
30213 by an instance reference.
30215 * cs-parser.jay (local_constant_declaration): Implement.
30217 (declaration_statement): Implement for constant declarations.
30219 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30221 * statement.cs (Switch): Catch double defaults.
30223 (Switch): More work on the switch() statement
30224 implementation. It works for integral values now, need to finish
30228 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30230 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30231 integer literals into other integer literals. To be used by
30234 2001-11-24 Ravi Pratap <ravi@ximian.com>
30236 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30239 (EmitDynamicInitializers): Cope with the above since we extract data
30240 directly from ArrayData now.
30242 (ExpectInitializers): Keep track of whether initializers are mandatory
30245 (Bounds): Make it a hashtable to prevent the same dimension being
30246 recorded for every element in that dimension.
30248 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30251 Also fix bug which was causing the indices to be emitted in the reverse
30254 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30256 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30257 unfinished. They do not work, because the underlying code is
30260 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30262 * cs-parser.jay: Remove bogus fixme.
30264 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30265 on Switch statement.
30267 2001-11-23 Ravi Pratap <ravi@ximian.com>
30269 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30272 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30273 parameter. Apparently, any expression is allowed.
30275 (ValidateInitializers): Update accordingly.
30277 (CheckIndices): Fix some tricky bugs thanks to recursion.
30279 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30280 I was being completely brain-dead.
30282 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30283 and re-write acordingly.
30285 (DelegateInvocation): Re-write accordingly.
30287 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30289 (MakeByteBlob): Handle types more correctly.
30291 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30292 initialization from expressions but it is incomplete because I am a complete
30295 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30297 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30298 on If. Basically, we have to return `true' (ie, we do return to
30299 our caller) only if both branches of the if return.
30301 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30302 short-circuit operators, handle them as short circuit operators.
30304 (Cast.DoResolve): Resolve type.
30305 (Cast.Cast): Take an expression as the target type.
30307 * cs-parser.jay (cast_expression): Remove old hack that only
30308 allowed a limited set of types to be handled. Now we take a
30309 unary_expression and we resolve to a type during semantic
30312 Use the grammar productions from Rhys to handle casts (this is
30313 not complete like Rhys syntax yet, we fail to handle that corner
30314 case that C# has regarding (-x), but we will get there.
30316 2001-11-22 Ravi Pratap <ravi@ximian.com>
30318 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30319 field which is an array type.
30321 * cs-parser.jay (declare_local_variables): Support array initialization too.
30323 * typemanager.cs (MakeKey): Implement.
30325 (everywhere): Use the above appropriately.
30327 * cs-parser.jay (for_statement): Update for array initialization while
30328 declaring variables.
30330 * ecore.cs : The error message was correct, it's the variable's names that
30331 were misleading ;-) Make the code more readable.
30333 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30334 the correct type etc.
30336 (ConvertExplicit): Handle Enum types by examining the underlying type.
30338 2001-11-21 Ravi Pratap <ravi@ximian.com>
30340 * parameter.cs (GetCallingConvention): Always return
30341 CallingConventions.Standard for now.
30343 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30345 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30346 and `r' after calling DoNumericPromotions.
30348 * ecore.cs: Fix error message (the types were in the wrong order).
30350 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30351 BindingFlags.Instance as well
30353 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30354 implicit int literal conversion in an empty cast so that we
30355 propagate the right type upstream.
30357 (UnboxCast): new class used to unbox value types.
30358 (Expression.ConvertExplicit): Add explicit type conversions done
30361 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30362 the target type before applying the implicit LongLiterals to ULong
30365 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30367 * cs-parser.jay (for_statement): Reworked the way For works: now
30368 we declare manually any variables that are introduced in
30369 for_initializer to solve the problem of having out-of-band code
30370 emition (that is what got for broken).
30372 (declaration_statement): Perform the actual variable declaration
30373 that used to be done in local_variable_declaration here.
30375 (local_variable_declaration): Do not declare anything, just pass
30376 the information on a DictionaryEntry
30378 2001-11-20 Ravi Pratap <ravi@ximian.com>
30380 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30381 re-write of the logic to now make it recursive.
30383 (UpdateIndices): Re-write accordingly.
30385 Store element data in a separate ArrayData list in the above methods.
30387 (MakeByteBlob): Implement to dump the array data into a byte array.
30389 2001-11-19 Ravi Pratap <ravi@ximian.com>
30391 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30394 * constant.cs (Define): Implement.
30396 (EmitConstant): Re-write fully.
30398 Pass in location info.
30400 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30403 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30404 DictionaryEntry since we need location info too.
30406 (constant_declaration): Update accordingly.
30408 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30409 code into another method : UpdateIndices.
30411 2001-11-18 Ravi Pratap <ravi@ximian.com>
30413 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30414 some type checking etc.
30416 2001-11-17 Ravi Pratap <ravi@ximian.com>
30418 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30419 bits to provide dimension info if the user skips doing that.
30421 Update second constructor to store the rank correctly.
30423 2001-11-16 Ravi Pratap <ravi@ximian.com>
30425 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30426 and try to implement.
30428 * ../errors/cs0150.cs : Add.
30430 * ../errors/cs0178.cs : Add.
30432 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30434 * statement.cs: Implement foreach on multi-dimensional arrays.
30436 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30437 name of the params argument.
30439 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30440 initializing the array.
30442 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30443 we can use this elsewhere.
30445 * statement.cs: Finish implementation of foreach for single
30448 * cs-parser.jay: Use an out-of-band stack to pass information
30449 around, I wonder why I need this.
30451 foreach_block: Make the new foreach_block the current_block.
30453 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30454 function used to return a static Parameters structure. Used for
30455 empty parameters, as those are created very frequently.
30457 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30459 2001-11-15 Ravi Pratap <ravi@ximian.com>
30461 * interface.cs : Default modifier is private, not public. The
30462 make verify test passes again.
30464 2001-11-15 Ravi Pratap <ravi@ximian.com>
30466 * support.cs (ReflectionParameters): Fix logic to determine
30467 whether the last parameter is a params one. Test 9 passes again.
30469 * delegate.cs (Populate): Register the builders we define with
30470 RegisterParameterForBuilder. Test 19 passes again.
30472 * cs-parser.jay (property_declaration): Reference $6 instead
30473 of $$ to get at the location.
30475 (indexer_declaration): Similar stuff.
30477 (attribute): Ditto.
30479 * class.cs (Property): Register parameters for the Get and Set methods
30480 if they exist. Test 23 passes again.
30482 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30483 call to EmitArguments as we are sure there aren't any params arguments.
30484 Test 32 passes again.
30486 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30487 IndexOutOfRangeException.
30489 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30490 Test 33 now passes again.
30492 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30494 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30495 broke a bunch of things. Will have to come up with a better way
30496 of tracking locations.
30498 * statement.cs: Implemented foreach for single dimension arrays.
30500 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30502 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30503 an error. This removes the lookup from the critical path.
30505 * cs-parser.jay: Removed use of temporary_loc, which is completely
30508 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30510 * support.cs (ReflectionParameters.ParameterModifier): Report
30511 whether the argument is a PARAMS argument or not.
30513 * class.cs: Set the attribute `ParamArrayAttribute' on the
30514 parameter argument.
30516 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30517 and cons_param_array_attribute (ConstructorInfo for
30518 ParamArrayAttribute).,
30520 * codegen.cs: Emit the return using the `Return' statement, that
30521 way we can report the error correctly for missing return values.
30523 * class.cs (Method.Emit): Clean up.
30525 * expression.cs (Argument.Resolve): Take another argument: the
30526 location where this argument is used. Notice that this is not
30527 part of the "Argument" class as to reduce the size of the
30528 structure (we know the approximate location anyways).
30530 Test if the argument is a variable-reference, if not, then
30531 complain with a 206.
30533 (Argument.Emit): Emit addresses of variables.
30535 (Argument.FullDesc): Simplify.
30537 (Invocation.DoResolve): Update for Argument.Resolve.
30539 (ElementAccess.DoResolve): ditto.
30541 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30542 method should be virtual, as this method is always virtual.
30544 (NewDelegate.DoResolve): Update for Argument.Resolve.
30546 * class.cs (ConstructorInitializer.DoResolve): ditto.
30548 * attribute.cs (Attribute.Resolve): ditto.
30550 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30552 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30554 * expression.cs (ParameterReference): Drop IStackStorage and implement
30555 IAssignMethod instead.
30557 (LocalVariableReference): ditto.
30559 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30560 IAssignMethod instead.
30562 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30564 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30565 enumerations that are used in heavily used structures derive from
30566 byte in a laughable and pathetic attempt to reduce memory usage.
30567 This is the kind of pre-optimzations that you should not do at
30568 home without adult supervision.
30570 * expression.cs (UnaryMutator): New class, used to handle ++ and
30571 -- separatedly from the other unary operators. Cleans up the
30572 code, and kills the ExpressionStatement dependency in Unary.
30574 (Unary): Removed `method' and `Arguments' from this class, making
30575 it smaller, and moving it all to SimpleCall, so I can reuse this
30576 code in other locations and avoid creating a lot of transient data
30577 strucutres when not required.
30579 * cs-parser.jay: Adjust for new changes.
30581 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30583 * enum.cs (Enum.Populate): If there is a failure during
30586 * cs-parser.jay (opt_enum_base): we used to catch type errors
30587 here, but this is really incorrect. The type error should be
30588 catched during semantic analysis.
30590 2001-12-11 Ravi Pratap <ravi@ximian.com>
30592 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30593 current_local_parameters as expected since I, in my stupidity, had forgotten
30596 * attribute.cs (GetValidPlaces): Fix stupid bug.
30598 * class.cs (Method::Emit): Perform check on applicability of attributes.
30600 (Constructor::Emit): Ditto.
30602 (Field::Emit): Ditto.
30604 (Field.Location): Store location information.
30606 (Property, Event, Indexer, Operator): Ditto.
30608 * cs-parser.jay (field_declaration): Pass in location for each field.
30610 * ../errors/cs0592.cs : Add.
30612 2001-11-12 Ravi Pratap <ravi@ximian.com>
30614 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30616 (InitCoreTypes): Update accordingly.
30618 (RegisterAttrType, LookupAttr): Implement.
30620 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30621 info about the same.
30623 (Resolve): Update to populate the above as necessary.
30625 (Error592): Helper.
30627 (GetValidPlaces): Helper to the above.
30629 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30631 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30633 2001-11-12 Ravi Pratap <ravi@ximian.com>
30635 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30637 * ../errors/cs0617.cs : Add.
30639 2001-11-11 Ravi Pratap <ravi@ximian.com>
30641 * enum.cs (Emit): Rename to Populate to be more consistent with what
30642 we expect it to do and when exactly it is called.
30644 * class.cs, rootcontext.cs : Update accordingly.
30646 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30647 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30649 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30651 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30652 of a fieldinfo using the above, when dealing with a FieldBuilder.
30654 2001-11-10 Ravi Pratap <ravi@ximian.com>
30656 * ../errors/cs0031.cs : Add.
30658 * ../errors/cs1008.cs : Add.
30660 * ../errrors/cs0543.cs : Add.
30662 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30665 (FindMembers): Implement.
30667 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30668 enums and delegates too.
30670 (enum_types): Rename to builder_to_enum.
30672 (delegate_types): Rename to builder_to_delegate.
30674 * delegate.cs (FindMembers): Implement.
30676 2001-11-09 Ravi Pratap <ravi@ximian.com>
30678 * typemanager.cs (IsEnumType): Implement.
30680 * enum.cs (Emit): Re-write parts to account for the underlying type
30681 better and perform checking etc.
30683 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30684 of the underlying type.
30686 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30689 * enum.cs (error31): Helper to report error #31.
30691 * cs-parser.jay (enum_declaration): Store location of each member too.
30693 * enum.cs (member_to_location): New hashtable.
30695 (AddEnumMember): Update location hashtable.
30697 (Emit): Use the location of each member while reporting errors.
30699 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30701 * cs-parser.jay: A for_initializer if is a
30702 local_variable_declaration really ammount to have an implicit
30703 block with the variable declaration and no initializer for for.
30705 * statement.cs (For.Emit): Cope with null initializers.
30707 This fixes the infinite loop on for initializers.
30709 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30711 * enum.cs: More cleanup.
30713 * ecore.cs: Remove dead code.
30715 * class.cs (Property.Emit): More simplification.
30716 (Event.Emit): ditto.
30718 Reworked to have less levels of indentation.
30720 2001-11-08 Ravi Pratap <ravi@ximian.com>
30722 * class.cs (Property): Emit attributes.
30732 * enum.cs (Emit): Ditto.
30734 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30737 * class.cs (Field, Event, etc.): Move attribute generation into the
30738 Emit method everywhere.
30740 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30741 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30742 as we had no way of defining nested enums !
30744 * rootcontext.cs : Adjust code accordingly.
30746 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30748 2001-11-07 Ravi Pratap <ravi@ximian.com>
30750 * expression.cs (EvalConstantExpression): Move into ecore.cs
30752 * enum.cs (Enum): Rename some members and make them public and readonly
30753 according to our convention.
30755 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30758 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30760 (Enum::Emit): Write a simple version for now which doesn't try to compute
30761 expressions. I shall modify this to be more robust in just a while.
30763 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30765 (TypeContainer::CloseType): Create the Enum types too.
30767 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30769 * expression.cs (EvalConstantExpression): Get rid of completely.
30771 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30772 user-defined values and other cases.
30774 (IsValidEnumLiteral): Helper function.
30776 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30777 out there in the case we had a literal FieldExpr.
30779 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30781 (Literalize): Revamp a bit to take two arguments.
30783 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30785 2001-11-06 Ravi Pratap <ravi@ximian.com>
30787 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30789 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30791 (Resolve): Use the above to ensure we have proper initializers.
30793 2001-11-05 Ravi Pratap <ravi@ximian.com>
30795 * expression.cs (Expression::EvalConstantExpression): New method to
30796 evaluate constant expressions.
30798 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30800 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30802 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30805 (Binary.ResolveOperator): Handle operator != (object a, object b)
30806 and operator == (object a, object b);
30808 (Binary.DoNumericPromotions): Indicate whether the numeric
30809 promotion was possible.
30811 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30814 Made the ArrayAccess implement interface IAssignMethod instead of
30815 IStackStore as the order in which arguments are passed reflects
30818 * assign.cs: Instead of using expr.ExprClass to select the way of
30819 assinging, probe for the IStackStore/IAssignMethod interfaces.
30821 * typemanager.cs: Load InitializeArray definition.
30823 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30824 static data that can be used to initialize arrays.
30826 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30828 * expression.cs: Handle operator== and operator!= for booleans.
30830 (Conditioal.Reduce): Implement reducer for the ?: operator.
30832 (Conditional.Resolve): Implement dead code elimination.
30834 (Binary.Resolve): Catch string literals and return a new
30835 concatenated string.
30837 (Unary.Reduce): Implement reduction of unary expressions.
30839 * ecore.cs: Split out the expression core handling here.
30841 (Expression.Reduce): New method used to perform constant folding
30842 and CSE. This is needed to support constant-expressions.
30844 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30845 targets, and optimize for !x.
30847 2001-11-04 Ravi Pratap <ravi@ximian.com>
30849 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30850 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30851 set custom atttributes.
30853 * literal.cs (Literal::GetValue): New abstract method to return the actual
30854 value of the literal, cast as an object.
30856 (*Literal): Implement GetValue method.
30858 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30859 expressions to the arraylist but objects of type Argument.
30861 * class.cs (TypeContainer::Emit): Emit our attributes too.
30863 (Method::Emit, Constructor::Emit): Ditto.
30865 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30866 to be ignoring earlier.
30868 2001-11-03 Ravi Pratap <ravi@ximian.com>
30870 * attribute.cs (AttributeSection::Define): Implement to do the business
30871 of constructing a CustomAttributeBuilder.
30873 (Attribute): New trivial class. Increases readability of code.
30875 * cs-parser.jay : Update accordingly.
30877 (positional_argument_list, named_argument_list, named_argument): New rules
30879 (attribute_arguments): Use the above so that we are more correct.
30881 2001-11-02 Ravi Pratap <ravi@ximian.com>
30883 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30884 to perform all checks for a method with a params parameter.
30886 (Invocation::OverloadResolve): Update to use the above method and therefore
30887 cope correctly with params method invocations.
30889 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30892 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30893 constructors in our parent too because we can't afford to miss out on
30896 * attribute.cs (AttributeSection): New name for the class Attribute
30898 Other trivial changes to improve readability.
30900 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30901 use the new class names.
30903 2001-11-01 Ravi Pratap <ravi@ximian.com>
30905 * class.cs (Method::Define): Complete definition for params types too
30907 (Indexer::Define): Ditto.
30909 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30910 Cope everywhere with a request for info about the array parameter.
30912 2001-11-01 Ravi Pratap <ravi@ximian.com>
30914 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30916 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30917 local_variable_type to extract the string corresponding to the type.
30919 (local_variable_type): Fixup the action to use the new helper method.
30921 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30924 * expression.cs : Clean out code which uses the above.
30926 2001-10-31 Ravi Pratap <ravi@ximian.com>
30928 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30929 and bale out if necessary by returning a false.
30931 (RegisterProperty): Ditto.
30933 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30934 and print out appropriate error messages.
30936 * interface.cs (everywhere): Ditto.
30938 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30939 location to constructor.
30941 * class.cs (Property, Event, Indexer): Update accordingly.
30943 * ../errors/cs111.cs : Added.
30945 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30946 of a method, as laid down by the spec.
30948 (Invocation::OverloadResolve): Use the above method.
30950 2001-10-31 Ravi Pratap <ravi@ximian.com>
30952 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30953 now take a TypeContainer and a Parameters object.
30955 (ParameterData): Modify return type of ParameterModifier method to be
30956 Parameter.Modifier and not a string.
30958 (ReflectionParameters, InternalParameters): Update accordingly.
30960 * expression.cs (Argument::GetParameterModifier): Same here.
30962 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30963 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30964 symbol in it at all so maybe this is only for now.
30966 2001-10-30 Ravi Pratap <ravi@ximian.com>
30968 * support.cs (InternalParameters): Constructor now takes an extra argument
30969 which is the actual Parameters class.
30971 (ParameterDesc): Update to provide info on ref/out modifiers.
30973 * class.cs (everywhere): Update call to InternalParameters to pass in
30974 the second argument too.
30976 * support.cs (ParameterData): Add ParameterModifier, which is a method
30977 to return the modifier info [ref/out etc]
30979 (InternalParameters, ReflectionParameters): Implement the above.
30981 * expression.cs (Argument::ParameterModifier): Similar function to return
30982 info about the argument's modifiers.
30984 (Invocation::OverloadResolve): Update to take into account matching modifiers
30987 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30988 a new SetFormalParameters object which we pass to InternalParameters.
30990 2001-10-30 Ravi Pratap <ravi@ximian.com>
30992 * expression.cs (NewArray): Merge into the ArrayCreation class.
30994 2001-10-29 Ravi Pratap <ravi@ximian.com>
30996 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30997 NewUserdefinedArray into one as there wasn't much of a use in having
31000 * expression.cs (Argument): Change field's name to ArgType from Type.
31002 (Type): New readonly property which returns the proper type, taking into
31003 account ref/out modifiers.
31005 (everywhere): Adjust code accordingly for the above.
31007 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
31008 whether we are emitting for a ref or out parameter.
31010 * expression.cs (Argument::Emit): Use the above field to set the state.
31012 (LocalVariableReference::Emit): Update to honour the flag and emit the
31015 * parameter.cs (Attributes): Set the correct flags for ref parameters.
31017 * expression.cs (Argument::FullDesc): New function to provide a full desc.
31019 * support.cs (ParameterData): Add method ParameterDesc to the interface.
31021 (ReflectionParameters, InternalParameters): Implement the above method.
31023 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
31026 (Invocation::FullMethodDesc): Ditto.
31028 2001-10-29 Miguel de Icaza <miguel@ximian.com>
31030 * cs-parser.jay: Add extra production for the second form of array
31033 * expression.cs (ArrayCreation): Update to reflect the above
31036 * Small changes to prepare for Array initialization.
31038 2001-10-28 Miguel de Icaza <miguel@ximian.com>
31040 * typemanager.cs (ImplementsInterface): interface might be null;
31041 Deal with this problem;
31043 Also, we do store negative hits on the cache (null values), so use
31044 this instead of calling t.GetInterfaces on the type everytime.
31046 2001-10-28 Ravi Pratap <ravi@ximian.com>
31048 * typemanager.cs (IsBuiltinType): New method to help determine the same.
31050 * expression.cs (New::DoResolve): Get rid of array creation code and instead
31051 split functionality out into different classes.
31053 (New::FormArrayType): Move into NewBuiltinArray.
31055 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
31058 (NewBuiltinArray): New class to handle creation of built-in arrays.
31060 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
31061 account creation of one-dimensional arrays.
31063 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
31065 (NewUserdefinedArray::DoResolve): Implement.
31067 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
31069 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
31070 we maintain inside the TypeManager. This is necessary to perform lookups on the
31073 (LookupType): Update to perform GetType on the module builders too.
31075 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
31077 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
31079 2001-10-23 Ravi Pratap <ravi@ximian.com>
31081 * expression.cs (New::DoResolve): Implement guts of array creation.
31083 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
31085 2001-10-27 Miguel de Icaza <miguel@ximian.com>
31087 * expression.cs: Fix bug I introduced lsat night that broke
31090 (Expression.Resolve): Report a 246 error (can not resolve name)
31091 if we find a SimpleName in the stream.
31093 (Expression.ResolveLValue): Ditto.
31095 (Expression.ResolveWithSimpleName): This function is a variant of
31096 ResolveName, this one allows SimpleNames to be returned without a
31097 warning. The only consumer of SimpleNames is MemberAccess
31099 2001-10-26 Miguel de Icaza <miguel@ximian.com>
31101 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
31102 might arrive here. I have my doubts that this is correct.
31104 * statement.cs (Lock): Implement lock statement.
31106 * cs-parser.jay: Small fixes to support `lock' and `using'
31108 * cs-tokenizer.cs: Remove extra space
31110 * driver.cs: New flag --checked, allows to turn on integer math
31113 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
31114 Threading.Monitor.Exit
31116 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31118 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31119 Expression Class to be IndexerAccess.
31121 Notice that Indexer::DoResolve sets the eclass to Value.
31123 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31125 * class.cs (TypeContainer::Emit): Emit code for indexers.
31127 * assign.cs (IAssignMethod): New interface implemented by Indexers
31128 and Properties for handling assignment.
31130 (Assign::Emit): Simplify and reuse code.
31132 * expression.cs (IndexerAccess, PropertyExpr): Implement
31133 IAssignMethod, clean up old code.
31135 2001-10-22 Ravi Pratap <ravi@ximian.com>
31137 * typemanager.cs (ImplementsInterface): New method to determine if a type
31138 implements a given interface. Provides a nice cache too.
31140 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31143 (ConvertReferenceExplicit): Ditto.
31145 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31146 various methods, with correct names etc.
31148 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31149 Operator.UnaryNegation.
31151 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31152 we have a unary plus or minus operator.
31154 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31157 * everywhere : update accordingly.
31159 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31162 * class.cs (Method::Define): For the case where we are implementing a method
31163 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31164 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31166 2001-10-21 Ravi Pratap <ravi@ximian.com>
31168 * interface.cs (FindMembers): Implement to work around S.R.E
31171 * typemanager.cs (IsInterfaceType): Implement.
31173 (FindMembers): Update to handle interface types too.
31175 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31176 use IsAssignableFrom as that is not correct - it doesn't work.
31178 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31179 and accordingly override EmitStatement.
31181 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31182 using the correct logic :-)
31184 2001-10-19 Ravi Pratap <ravi@ximian.com>
31186 * ../errors/cs-11.cs : Add to demonstrate error -11
31188 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31190 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31191 then pass this as a hint to ResolveLValue.
31193 * expression.cs (FieldExpr): Add Location information
31195 (FieldExpr::LValueResolve): Report assignment to readonly
31198 (Expression::ExprClassFromMemberInfo): Pass location information.
31200 (Expression::ResolveLValue): Add new method that resolves an
31203 (Expression::DoResolveLValue): Default invocation calls
31206 (Indexers): New class used to keep track of indexers in a given
31209 (IStackStore): Renamed from LValue, as it did not really describe
31210 what this did. Also ResolveLValue is gone from this interface and
31211 now is part of Expression.
31213 (ElementAccess): Depending on the element access type
31215 * typemanager.cs: Add `indexer_name_type' as a Core type
31216 (System.Runtime.CompilerServices.IndexerNameAttribute)
31218 * statement.cs (Goto): Take a location.
31220 2001-10-18 Ravi Pratap <ravi@ximian.com>
31222 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31223 if two delegates are compatible.
31225 (NewDelegate::DoResolve): Update to take care of the case when
31226 we instantiate a delegate from another delegate.
31228 * typemanager.cs (FindMembers): Don't even try to look up members
31229 of Delegate types for now.
31231 2001-10-18 Ravi Pratap <ravi@ximian.com>
31233 * delegate.cs (NewDelegate): New class to take care of delegate
31236 * expression.cs (New): Split the delegate related code out into
31237 the NewDelegate class.
31239 * delegate.cs (DelegateInvocation): New class to handle delegate
31242 * expression.cs (Invocation): Split out delegate related code into
31243 the DelegateInvocation class.
31245 2001-10-17 Ravi Pratap <ravi@ximian.com>
31247 * expression.cs (New::DoResolve): Implement delegate creation fully
31248 and according to the spec.
31250 (New::DoEmit): Update to handle delegates differently.
31252 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31253 because of which we were printing out arguments in reverse order !
31255 * delegate.cs (VerifyMethod): Implement to check if the given method
31256 matches the delegate.
31258 (FullDelegateDesc): Implement.
31260 (VerifyApplicability): Implement.
31262 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31263 delegate invocations too.
31265 (Invocation::Emit): Ditto.
31267 * ../errors/cs1593.cs : Added.
31269 * ../errors/cs1594.cs : Added.
31271 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31273 2001-10-16 Ravi Pratap <ravi@ximian.com>
31275 * typemanager.cs (intptr_type): Core type for System.IntPtr
31277 (InitCoreTypes): Update for the same.
31279 (iasyncresult_type, asynccallback_type): Ditto.
31281 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31284 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31287 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31288 the builders for the 4 members of a delegate type :-)
31290 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31293 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31295 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31297 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31299 * statement.cs (Break::Emit): Implement.
31300 (Continue::Emit): Implement.
31302 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31303 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31304 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31305 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31308 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31309 properties that track the label for the current loop (begin of the
31310 loop and end of the loop).
31312 2001-10-15 Ravi Pratap <ravi@ximian.com>
31314 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31315 use of emitting anything at all.
31317 * class.cs, rootcontext.cs : Get rid of calls to the same.
31319 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31321 (Populate): Define the constructor correctly and set the implementation
31324 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31327 (AddDelegateType): Implement.
31329 (IsDelegateType): Implement helper method.
31331 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31333 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31334 and accordingly handle it.
31336 * delegate.cs (Populate): Take TypeContainer argument.
31337 Implement bits to define the Invoke method. However, I still haven't figured out
31338 how to take care of the native int bit :-(
31340 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31341 Qualify the name of the delegate, not its return type !
31343 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31346 (StandardConversionExists): Checking for array types turns out to be recursive.
31348 (ConvertReferenceExplicit): Implement array conversion.
31350 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31352 2001-10-12 Ravi Pratap <ravi@ximian.com>
31354 * cs-parser.jay (delegate_declaration): Store the fully qualified
31355 name as it is a type declaration.
31357 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31360 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31361 as TypeContainer::DefineType.
31363 (Populate): Method in which all the definition of the various methods (Invoke)
31366 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31369 (CloseDelegate): Finally creates the delegate.
31371 * class.cs (TypeContainer::DefineType): Update to define delegates.
31372 (Populate, Emit and CloseType): Do the same thing here too.
31374 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31375 delegates in all these operations.
31377 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31379 * expression.cs: LocalTemporary: a new expression used to
31380 reference a temporary that has been created.
31382 * assign.cs: Handle PropertyAccess back here, so that we can
31383 provide the proper semantic access to properties.
31385 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31386 a few more explicit conversions.
31388 * modifiers.cs: `NEW' modifier maps to HideBySig.
31390 * expression.cs (PropertyExpr): Make this into an
31391 ExpressionStatement, and support the EmitStatement code path.
31393 Perform get/set error checking, clean up the interface.
31395 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31396 them into toplevel access objects.
31398 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31400 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31403 * typemanager.cs: Keep track here of our PropertyBuilders again to
31404 work around lameness in SRE.
31406 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31408 * expression.cs (LValue::LValueResolve): New method in the
31409 interface, used to perform a second resolution pass for LValues.
31411 (This::DoResolve): Catch the use of this in static methods.
31413 (This::LValueResolve): Implement.
31415 (This::Store): Remove warning, assigning to `this' in structures
31418 (Invocation::Emit): Deal with invocation of
31419 methods on value types. We need to pass the address to structure
31420 methods rather than the object itself. (The equivalent code to
31421 emit "this" for structures leaves the entire structure on the
31422 stack instead of a pointer to it).
31424 (ParameterReference::DoResolve): Compute the real index for the
31425 argument based on whether the method takes or not a `this' pointer
31426 (ie, the method is static).
31428 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31429 value types returned from functions when we need to invoke a
31430 method on the sturcture.
31433 2001-10-11 Ravi Pratap <ravi@ximian.com>
31435 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31436 defining the type in the Modulebuilder or Typebuilder. This is to take
31437 care of nested types which need to be defined on the TypeBuilder using
31438 DefineNestedMethod.
31440 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31441 methods in RootContext, only ported to be part of TypeContainer.
31443 (TypeContainer::GetInterfaceOrClass): Ditto.
31445 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31447 * interface.cs (Interface::DefineInterface): New method. Does exactly
31448 what RootContext.CreateInterface did earlier, only it takes care of nested types
31451 (Interface::GetInterfaces): Move from RootContext here and port.
31453 (Interface::GetInterfaceByName): Same here.
31455 * rootcontext.cs (ResolveTree): Re-write.
31457 (PopulateTypes): Re-write.
31459 * class.cs (TypeContainer::Populate): Populate nested types too.
31460 (TypeContainer::Emit): Emit nested members too.
31462 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31463 instead just use the name argument passed in as it is already fully
31466 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31467 to TypeContainer mapping to see if a type is user-defined.
31469 * class.cs (TypeContainer::CloseType): Implement.
31471 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31472 the default constructor.
31474 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31477 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31479 * interface.cs (CloseType): Create the type here.
31481 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31484 Remove all the methods which are now in TypeContainer.
31486 2001-10-10 Ravi Pratap <ravi@ximian.com>
31488 * delegate.cs (Define): Re-write bits to define the delegate
31491 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31493 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31495 * expression.cs (ImplicitReferenceConversion): handle null as well
31496 as a source to convert to any reference type.
31498 * statement.cs (Return): Perform any implicit conversions to
31499 expected return type.
31501 Validate use of return statement.
31503 * codegen.cs (EmitContext): Pass the expected return type here.
31505 * class.cs (Method, Constructor, Property): Pass expected return
31506 type to EmitContext.
31508 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31510 * expression.cs: Make DoResolve take an EmitContext instead of a
31513 Replaced `l' and `location' for `loc', for consistency.
31515 (Error, Warning): Remove unneeded Tc argument.
31517 * assign.cs, literal.cs, constant.cs: Update to new calling
31520 * codegen.cs: EmitContext now contains a flag indicating whether
31521 code is being generated in a static method or not.
31523 * cs-parser.jay: DecomposeQI, new function that replaces the old
31524 QualifiedIdentifier. Now we always decompose the assembled
31525 strings from qualified_identifier productions into a group of
31528 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31530 * rootcontext.cs: Deal with field-less struct types correctly now
31531 by passing the size option to Define Type.
31533 * class.cs: Removed hack that created one static field.
31535 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31537 * statement.cs: Moved most of the code generation here.
31539 2001-10-09 Ravi Pratap <ravi@ximian.com>
31541 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31544 (ElementAccess): Remove useless bits for now - keep checks as the spec
31547 2001-10-08 Ravi Pratap <ravi@ximian.com>
31549 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31550 and start performing checks according to the spec.
31552 2001-10-07 Ravi Pratap <ravi@ximian.com>
31554 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31555 rank_specifiers instead.
31557 (rank_specifiers): Change the order in which the rank specifiers are stored
31559 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31561 * expression.cs (ElementAccess): Implement the LValue interface too.
31563 2001-10-06 Ravi Pratap <ravi@ximian.com>
31565 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31566 except that user defined conversions are not included.
31568 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31569 perform the conversion of the return type, if necessary.
31571 (New::DoResolve): Check whether we are creating an array or an object
31572 and accordingly do the needful.
31574 (New::Emit): Same here.
31576 (New::DoResolve): Implement guts of array creation.
31578 (New::FormLookupType): Helper function.
31580 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31582 * codegen.cs: Removed most of the code generation here, and move the
31583 corresponding code generation bits to the statement classes.
31585 Added support for try/catch/finalize and throw.
31587 * cs-parser.jay: Added support for try/catch/finalize.
31589 * class.cs: Catch static methods having the flags override,
31590 virtual or abstract.
31592 * expression.cs (UserCast): This user cast was not really doing
31593 what it was supposed to do. Which is to be born in fully resolved
31594 state. Parts of the resolution were being performed at Emit time!
31598 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31600 * expression.cs: Implicity convert the result from UserCast.
31602 2001-10-05 Ravi Pratap <ravi@ximian.com>
31604 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31605 prevented it from working correctly.
31607 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31608 merely ConvertImplicit.
31610 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31612 * typemanager.cs: Make the LookupTypeContainer function static,
31613 and not per-instance.
31615 * class.cs: Make static FindMembers (the one that takes a Type
31618 * codegen.cs: Add EmitForeach here.
31620 * cs-parser.jay: Make foreach a toplevel object instead of the
31621 inline expansion, as we need to perform semantic analysis on it.
31623 2001-10-05 Ravi Pratap <ravi@ximian.com>
31625 * expression.cs (Expression::ImplicitUserConversion): Rename to
31626 UserDefinedConversion.
31628 (Expression::UserDefinedConversion): Take an extra argument specifying
31629 whether we look for explicit user conversions too.
31631 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31633 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31635 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31636 with the appropriate arguments.
31638 * cs-parser.jay (cast_expression): Record location too.
31640 * expression.cs (Cast): Record location info.
31642 (Expression::ConvertExplicit): Take location argument.
31644 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31645 to determine if we are doing explicit conversions.
31647 (UserCast::Emit): Update accordingly.
31649 (Expression::ConvertExplicit): Report an error if everything fails.
31651 * ../errors/cs0030.cs : Add.
31653 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31655 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31656 virtual and newslot bits.
31658 * class.cs (TypeContainer::RegisterRequiredImplementations):
31659 Record methods we need.
31661 (TypeContainer::MakeKey): Helper function to make keys for
31662 MethodBases, since the Methodbase key is useless.
31664 (TypeContainer::Populate): Call RegisterRequiredImplementations
31665 before defining the methods.
31667 Create a mapping for method_builders_to_methods ahead of time
31668 instead of inside a tight loop.
31670 (::RequireMethods): Accept an object as the data to set into the
31671 hashtable so we can report interface vs abstract method mismatch.
31673 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31675 * report.cs: Make all of it static.
31677 * rootcontext.cs: Drop object_type and value_type computations, as
31678 we have those in the TypeManager anyways.
31680 Drop report instance variable too, now it is a global.
31682 * driver.cs: Use try/catch on command line handling.
31684 Add --probe option to debug the error reporting system with a test
31687 * report.cs: Add support for exiting program when a probe
31688 condition is reached.
31690 2001-10-03 Ravi Pratap <ravi@ximian.com>
31692 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31693 we do a forcible conversion regardless of type, to check if
31694 ForceConversion returns a null.
31696 (Binary::error19): Use location to report error.
31698 (Unary::error23): Use location here too.
31700 * ../errors/cs0019.cs : Check in.
31702 * ../errors/cs0023.cs : Check in.
31704 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31705 case of a non-null MethodInfo object with a length of 0 !
31707 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31708 an applicable member - according to the spec :-)
31709 Also fix logic to find members in base types.
31711 (Unary::ResolveOperator): Same here.
31713 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31714 as I was getting thoroughly confused between this and error19 :-)
31716 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31717 (::FindMostEncompassedType): Implement.
31718 (::FindMostEncompassingType): Implement.
31719 (::StandardConversionExists): Implement.
31721 (UserImplicitCast): Re-vamp. We now need info about most specific
31722 source and target types so that we can do the necessary conversions.
31724 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31725 mathematical union with no duplicates.
31727 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31729 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31730 in order from base classes to child classes, so that we can in
31731 child classes look up in our parent for method names and
31732 attributes (required for handling abstract, virtual, new, override
31733 constructs: we need to instrospect our base class, and if we dont
31734 populate the classes in order, the introspection might be
31735 incorrect. For example, a method could query its parent before
31736 the parent has any methods and would determine that the parent has
31737 no abstract methods (while it could have had them)).
31739 (RootContext::CreateType): Record the order in which we define the
31742 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31744 * class.cs (TypeContainer::Populate): Also method definitions can
31745 fail now, keep track of this.
31747 (TypeContainer::FindMembers): Implement support for
31748 DeclaredOnly/noDeclaredOnly flag.
31750 (Constructor::Emit) Return the ConstructorBuilder.
31752 (Method::Emit) Return the MethodBuilder.
31753 Check for abstract or virtual methods to be public.
31755 * rootcontext.cs (RootContext::CreateType): Register all the
31756 abstract methods required for the class to be complete and the
31757 interface methods that must be implemented.
31759 * cs-parser.jay: Report error 501 (method requires body if it is
31760 not marked abstract or extern).
31762 * expression.cs (TypeOf::Emit): Implement.
31764 * typemanager.cs: runtime_handle_type, new global type.
31766 * class.cs (Property::Emit): Generate code for properties.
31768 2001-10-02 Ravi Pratap <ravi@ximian.com>
31770 * expression.cs (Unary::ResolveOperator): Find operators on base type
31771 too - we now conform exactly to the spec.
31773 (Binary::ResolveOperator): Same here.
31775 * class.cs (Operator::Define): Fix minor quirk in the tests.
31777 * ../errors/cs0215.cs : Added.
31779 * ../errors/cs0556.cs : Added.
31781 * ../errors/cs0555.cs : Added.
31783 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31785 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31786 single integer which is really efficient
31788 2001-10-01 Ravi Pratap <ravi@ximian.com>
31790 * expression.cs (Expression::ImplicitUserConversion): Use location
31791 even in the case when we are examining True operators.
31793 * class.cs (Operator::Define): Perform extensive checks to conform
31794 with the rules for operator overloading in the spec.
31796 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31797 some of the other conversions mentioned in the spec.
31799 * typemanager.cs (array_type): New static member for the System.Array built-in
31802 (cloneable_interface): For System.ICloneable interface.
31804 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31805 we start resolving the tree and populating types.
31807 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31809 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31811 * expression.cs (Expression::ExprClassFromMemberInfo,
31812 Expression::Literalize): Create literal expressions from
31813 FieldInfos which are literals.
31815 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31816 type casts, because they were wrong. The test suite in tests
31819 (ImplicitNumericConversion): ushort to ulong requires a widening
31822 Int32 constant to long requires widening cast as well.
31824 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31825 for integers because the type on the stack is not i4.
31827 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31829 * expression.cs (report118): require location argument.
31831 * parameter.cs: Do not dereference potential null value.
31833 * class.cs: Catch methods that lack the `new' keyword when
31834 overriding a name. Report warnings when `new' is used without
31835 anything being there to override.
31837 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31839 * class.cs: Only add constructor to hashtable if it is non-null
31840 (as now constructors can fail on define).
31842 (TypeManager, Class, Struct): Take location arguments.
31844 Catch field instance initialization in structs as errors.
31846 accepting_filter: a new filter for FindMembers that is static so
31847 that we dont create an instance per invocation.
31849 (Constructor::Define): Catch errors where a struct constructor is
31852 * cs-parser.jay: Pass location information for various new
31855 * delegate.cs (Delegate): take a location argument.
31857 * driver.cs: Do not call EmitCode if there were problesm in the
31858 Definition of the types, as many Builders wont be there.
31860 * decl.cs (Decl::Decl): Require a location argument.
31862 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31863 into integers, and find the most appropiate integer for it.
31865 * literal.cs: Implement ULongLiteral.
31867 * rootcontext.cs: Provide better information about the location of
31868 failure when CreateType fails.
31870 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31872 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31875 * expression.cs (Binary::CheckShiftArguments): Add missing type
31877 (Binary::ResolveOperator): Add type to the logical and and logical
31878 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31881 (Binary::DoNumericPromotions): In the case where either argument
31882 is ulong (and most signed types combined with ulong cause an
31883 error) perform implicit integer constant conversions as well.
31885 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31887 * expression.cs (UserImplicitCast): Method should always be
31889 (Invocation::BetterConversion): Simplified test for IntLiteral.
31891 (Expression::ImplicitNumericConversion): Split this routine out.
31892 Put the code that performs implicit constant integer conversions
31895 (Expression::Resolve): Become a wrapper around DoResolve so we can
31896 check eclass and type being set after resolve.
31898 (Invocation::Badness): Remove this dead function
31900 (Binary::ResolveOperator): Do not compute the expensive argumnets
31901 unless we have a union for it.
31903 (Probe::Emit): Is needs to do an isinst and then
31904 compare against null.
31906 (::CanConvert): Added Location argument. If the Location argument
31907 is null (Location.Null), then we do not report errors. This is
31908 used by the `probe' mechanism of the Explicit conversion. We do
31909 not want to generate an error for something that the user
31910 explicitly requested to be casted. But the pipeline for an
31911 explicit cast first tests for potential implicit casts.
31913 So for now, if the Location is null, it means `Probe only' to
31914 avoid adding another argument. Might have to revise this
31917 (ClassCast): New class used to type cast objects into arbitrary
31918 classes (used in Explicit Reference Conversions).
31920 Implement `as' as well.
31922 Reverted all the patches from Ravi below: they were broken:
31924 * The use of `level' as a mechanism to stop recursive
31925 invocations is wrong. That was there just to catch the
31926 bug with a strack trace but not as a way of addressing
31929 To fix the problem we have to *understand* what is going
31930 on and the interactions and come up with a plan, not
31931 just get things going.
31933 * The use of the type conversion cache that I proposed
31934 last night had an open topic: How does this work across
31935 protection domains. A user defined conversion might not
31936 be public in the location where we are applying the
31937 conversion, a different conversion might be selected
31938 (ie, private A->B (better) but public B->A (worse),
31939 inside A, A->B applies, but outside it, B->A will
31942 * On top of that (ie, even if the above is solved),
31943 conversions in a cache need to be abstract. Ie, `To
31944 convert from an Int to a Short use an OpcodeCast', not
31945 `To convert from an Int to a Short use the OpcodeCast on
31946 the variable 5' (which is what this patch was doing).
31948 2001-09-28 Ravi Pratap <ravi@ximian.com>
31950 * expression.cs (Invocation::ConversionExists): Re-write to use
31951 the conversion cache
31953 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31954 cache all conversions done, not just user-defined ones.
31956 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31957 to determine if a conversion exists instead of acutually trying to
31958 perform the conversion. It's faster too.
31960 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31961 and only then attempt the implicit conversion.
31963 2001-09-28 Ravi Pratap <ravi@ximian.com>
31965 * expression.cs (ConvertImplicit): Use a cache for conversions
31966 already found. Check level of recursion and bail out if necessary.
31968 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31970 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31971 Export standard methods that we expect for string operations.
31973 * statement.cs (Block::UsageWarning): Track usage of variables and
31974 report the errors for not used variables.
31976 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31979 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31981 * codegen.cs: remove unnneded code
31983 * expression.cs: Removed BuiltinTypeAccess class
31985 Fix the order in which implicit conversions are
31988 The previous fixed dropped support for boxed conversions (adding a
31989 test to the test suite now)
31991 (UserImplicitCast::CanConvert): Remove test for source being null,
31992 that code is broken. We should not feed a null to begin with, if
31993 we do, then we should track the bug where the problem originates
31994 and not try to cover it up here.
31996 Return a resolved expression of type UserImplicitCast on success
31997 rather than true/false. Ravi: this is what I was talking about,
31998 the pattern is to use a static method as a "constructor" for
32001 Also, do not create arguments until the very last minute,
32002 otherwise we always create the arguments even for lookups that
32003 will never be performed.
32005 (UserImplicitCast::Resolve): Eliminate, objects of type
32006 UserImplicitCast are born in a fully resolved state.
32008 * typemanager.cs (InitCoreTypes): Init also value_type
32009 (System.ValueType).
32011 * expression.cs (Cast::Resolve): First resolve the child expression.
32013 (LValue): Add new method AddressOf to be used by
32016 Change the argument of Store to take an EmitContext instead of an
32017 ILGenerator, because things like FieldExpr need to be able to call
32018 their children expression to generate the instance code.
32020 (Expression::Error, Expression::Warning): Sugar functions for
32023 (Expression::MemberLookup): Accept a TypeContainer instead of a
32024 Report as the first argument.
32026 (Expression::ResolvePrimary): Killed. I still want to improve
32027 this as currently the code is just not right.
32029 (Expression::ResolveMemberAccess): Simplify, but it is still
32032 (Unary::Resolve): Catch errors in AddressOf operators.
32034 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
32035 index to a byte for the short-version, or the compiler will choose
32036 the wrong Emit call, which generates the wrong data.
32038 (ParameterReference::Emit, ::Store): same.
32040 (FieldExpr::AddressOf): Implement.
32042 * typemanager.cs: TypeManager: made public variable instead of
32045 * driver.cs: document --fatal.
32047 * report.cs (ErrorMessage, WarningMessage): new names for the old
32048 Error and Warning classes.
32050 * cs-parser.jay (member_access): Turn built-in access to types
32051 into a normal simplename
32053 2001-09-27 Ravi Pratap <ravi@ximian.com>
32055 * expression.cs (Invocation::BetterConversion): Fix to cope
32056 with q being null, since this was introducing a bug.
32058 * expression.cs (ConvertImplicit): Do built-in conversions first.
32060 2001-09-27 Ravi Pratap <ravi@ximian.com>
32062 * expression.cs (UserImplicitCast::Resolve): Fix bug.
32064 2001-09-27 Ravi Pratap <ravi@ximian.com>
32066 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
32067 I had introduced long ago (what's new ?).
32069 * expression.cs (UserImplicitCast::CanConvert): Static method to do
32070 the work of all the checking.
32071 (ConvertImplicit): Call CanConvert and only then create object if necessary.
32072 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
32074 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
32075 that is the right way.
32077 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
32078 overloading resolution. Use everywhere instead of cutting and pasting code.
32080 (Binary::ResolveOperator): Use MakeUnionSet.
32082 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
32083 we have to convert to bool types. Not complete yet.
32085 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32087 * typemanager.cs (TypeManager::CSharpName): support ushort.
32089 * expression.cs (Expression::TryImplicitIntConversion): Attempts
32090 to provide an expression that performsn an implicit constant int
32091 conversion (section 6.1.6).
32092 (Expression::ConvertImplicitRequired): Reworked to include
32093 implicit constant expression conversions.
32095 (Expression::ConvertNumericExplicit): Finished.
32097 (Invocation::Emit): If InstanceExpression is null, then it means
32098 that we perform a call on this.
32100 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32102 * expression.cs (Unary::Emit): Remove some dead code.
32103 (Probe): Implement Resolve and Emit for `is'.
32104 (Expression::ConvertImplicitRequired): Attempt to do constant
32105 expression conversions here. Maybe should be moved to
32106 ConvertImplicit, but I am not sure.
32107 (Expression::ImplicitLongConstantConversionPossible,
32108 Expression::ImplicitIntConstantConversionPossible): New functions
32109 that tell whether is it possible to apply an implicit constant
32110 expression conversion.
32112 (ConvertNumericExplicit): Started work on explicit numeric
32115 * cs-parser.jay: Update operator constants.
32117 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32118 (Parameters::GetSignature): Hook up VerifyArgs here.
32119 (Parameters::VerifyArgs): Verifies that no two arguments have the
32122 * class.cs (Operator): Update the operator names to reflect the
32123 ones that the spec expects (as we are just stringizing the
32126 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32127 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32128 previous usage did only work for our methods.
32129 (Expression::ConvertImplicit): Handle decimal implicit numeric
32130 conversions as well.
32131 (Expression::InternalTypeConstructor): Used to invoke constructors
32132 on internal types for default promotions.
32134 (Unary::Emit): Implement special handling for the pre/post
32135 increment/decrement for overloaded operators, as they need to have
32136 the same semantics as the other operators.
32138 (Binary::ResolveOperator): ditto.
32139 (Invocation::ConversionExists): ditto.
32140 (UserImplicitCast::Resolve): ditto.
32142 2001-09-26 Ravi Pratap <ravi@ximian.com>
32144 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32145 operator, return after emitting body. Regression tests pass again !
32147 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32148 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32149 (Invocation::OverloadResolve): Ditto.
32150 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32152 * everywhere : update calls to the above methods accordingly.
32154 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32156 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32158 * expression.cs (ExpressionStatement): New base class used for
32159 expressions that can appear in statements, so that we can provide
32160 an alternate path to generate expression that do not leave a value
32163 (Expression::Emit, and all the derivatives): We no longer return
32164 whether a value is left on the stack or not. Every expression
32165 after being emitted leaves a single value on the stack.
32167 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32168 facilties of ExpressionStatement if possible.
32170 * cs-parser.jay: Update statement_expression.
32172 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32174 * driver.cs: Change the wording of message
32176 2001-09-25 Ravi Pratap <ravi@ximian.com>
32178 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32179 the type of the expression to the return type of the method if
32180 we have an overloaded operator match ! The regression tests pass again !
32181 (Unary::ResolveOperator): Ditto.
32183 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32184 to find "op_Implicit", not "implicit" ;-)
32185 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32186 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32188 * everywhere : Correct calls to the above accordingly.
32190 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32191 (ConvertImplicit): Do user-defined conversion if it exists.
32193 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32195 * assign.cs: track location.
32196 (Resolve): Use implicit conversions on assignment.
32198 * literal.cs: Oops. Not good, Emit of short access values should
32199 pass (Bytes) or the wrong argument will be selected.
32201 * expression.cs (Unary::Emit): Emit code for -expr.
32203 (Unary::ResolveOperator): Handle `Substract' for non-constants
32204 (substract from zero from the non-constants).
32205 Deal with Doubles as well.
32207 (Expression::ConvertImplicitRequired): New routine that reports an
32208 error if no implicit conversion exists.
32210 (Invocation::OverloadResolve): Store the converted implicit
32211 expressions if we make them
32213 2001-09-24 Ravi Pratap <ravi@ximian.com>
32215 * class.cs (ConstructorInitializer): Take a Location argument.
32216 (ConstructorBaseInitializer): Same here.
32217 (ConstructorThisInitializer): Same here.
32219 * cs-parser.jay : Update all calls accordingly.
32221 * expression.cs (Unary, Binary, New): Take location argument.
32222 Update accordingly everywhere.
32224 * cs-parser.jay : Update all calls to the above to take a location
32227 * class.cs : Ditto.
32229 2001-09-24 Ravi Pratap <ravi@ximian.com>
32231 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32232 (Invocation::BetterConversion): Same here
32233 (Invocation::ConversionExists): Ditto.
32235 (Invocation::ConversionExists): Implement.
32237 2001-09-22 Ravi Pratap <ravi@ximian.com>
32239 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32240 Also take an additional TypeContainer argument.
32242 * All over : Pass in TypeContainer as argument to OverloadResolve.
32244 * typemanager.cs (CSharpName): Update to check for the string type and return
32247 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32250 2001-09-21 Ravi Pratap <ravi@ximian.com>
32252 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32253 (Invocation::BetterFunction): Implement.
32254 (Invocation::BetterConversion): Implement.
32255 (Invocation::ConversionExists): Skeleton, no implementation yet.
32257 Okay, things work fine !
32259 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32261 * typemanager.cs: declare and load enum_type, delegate_type and
32264 * expression.cs (Expression::Emit): Now emit returns a value that
32265 tells whether a value is left on the stack or not. This strategy
32266 might be reveted tomorrow with a mechanism that would address
32267 multiple assignments.
32268 (Expression::report118): Utility routine to report mismatches on
32271 (Unary::Report23): Report impossible type/operator combination
32274 (Unary::IsIncrementableNumber): Whether the type can be
32275 incremented or decremented with add.
32276 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32278 (Unary::ResolveOperator): Implement ++, !, ~,
32280 (Invocation::Emit): Deal with new Emit convetion.
32282 * All Expression derivatives: Updated their Emit method to return
32283 whether they leave values on the stack or not.
32285 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32286 stack for expressions that are statements.
32288 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32290 * expression.cs (LValue): New interface. Must be implemented by
32292 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32295 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32296 interface for generating code, simplifies the code.
32298 2001-09-20 Ravi Pratap <ravi@ximian.com>
32300 * expression.cs (everywhere): Comment out return statements in ::Resolve
32301 methods to avoid the warnings.
32303 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32305 * driver.cs (parse): Report error 2001 if we can not open the
32308 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32311 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32314 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32315 otherwise nested blocks end up with the same index.
32317 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32319 * expression.cs: Instead of having FIXMEs in the Resolve
32320 functions, throw exceptions so it is obvious that we are facing a
32323 * cs-parser.jay (invocation_expression): Pass Location information.
32325 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32326 Use a basename for those routines because .NET does not like paths
32329 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32332 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32334 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32335 are loading the correct data types (throws an exception if not).
32336 (TypeManager::InitCoreTypes): Use CoreLookupType
32338 * expression.cs (Unary::ResolveOperator): return the child
32339 expression for expressions which are just +expr.
32340 (Unary::ResolveOperator): Return negative literals for -LITERAL
32341 expressions (otherwise they are Unary {Literal}).
32342 (Invocation::Badness): Take into account `Implicit constant
32343 expression conversions'.
32345 * literal.cs (LongLiteral): Implement long literal class.
32346 (IntLiteral): export the `Value' of the intliteral.
32348 2001-09-19 Ravi Pratap <ravi@ximian.com>
32350 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32352 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32353 instead of 'Operator'
32355 * expression.cs (Binary::ResolveOperator): Update accordingly.
32356 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32359 * cs-parser.jay (unary_expression): Update to use the new names.
32361 * gen-treedump.cs (GetUnary): Same here.
32363 * expression.cs (Unary::Resolve): Implement.
32364 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32365 operators are found instead of making noise ;-)
32366 (Unary::ResolveOperator): New method to do precisely the same thing which
32367 Binary::ResolveOperator does for Binary expressions.
32368 (Unary.method, .Arguments): Add.
32369 (Unary::OperName): Implement.
32370 (Unary::ForceConversion): Copy and Paste !
32372 * class.cs (Operator::Define): Fix a small bug for the case when we have
32375 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32376 for the inbuilt operators. Only overloading works for now ;-)
32378 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32380 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32381 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32383 * expression.cs (This::Emit): Implement.
32384 (This::Resolve): Implement.
32385 (TypeOf:Resolve): Implement.
32386 (Expression::ResolveSimpleName): Add an implicit this to instance
32388 (MemberAccess::Resolve): Deal with Parameters and Fields.
32389 Bind instance variable to Field expressions.
32390 (FieldExpr::Instance): New field used to track the expression that
32391 represents the object instance.
32392 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32394 (FieldExpr::Emit): Implement.
32396 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32397 the last instruction contains a return opcode to avoid generating
32398 the last `ret' instruction (this generates correct code, and it is
32399 nice to pass the peverify output).
32401 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32402 initializer for static and instance variables.
32403 (Constructor::Emit): Allow initializer to be null in the case of
32404 static constructors. Only emit initializer for instance
32407 (TypeContainer::FindMembers): Return a null array if there are no
32410 Also fix the code for the MemberTypes.Method branch, as it was not
32411 scanning that for operators (or tried to access null variables before).
32413 * assign.cs (Assign::Emit): Handle instance and static fields.
32417 * driver.cs: Stop compilation if there are parse errors.
32419 * cs-parser.jay (constructor_declaration): Provide default base
32420 initializer for non-static constructors.
32421 (constructor_declarator): Do not provide a default base
32422 initializers if none was specified.
32423 Catch the fact that constructors should not have parameters.
32425 * class.cs: Do not emit parent class initializers for static
32426 constructors, that should be flagged as an error.
32428 2001-09-18 Ravi Pratap <ravi@ximian.com>
32430 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32431 Move back code into TypeContainer::Populate.
32433 2001-09-18 Ravi Pratap <ravi@ximian.com>
32435 * class.cs (TypeContainer::AddConstructor): Fix the check to
32436 compare against Name, not Basename.
32437 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32439 * cs-parser.jay : Update accordingly.
32441 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32442 for methods, don't forget to look into the operators too.
32443 (RegisterMethodBuilder): Helper method to take care of this for
32444 methods, constructors and operators.
32445 (Operator::Define): Completely revamp.
32446 (Operator.OperatorMethod, MethodName): New fields.
32447 (TypeContainer::Populate): Move the registering of builders into
32448 RegisterMethodBuilder.
32449 (Operator::Emit): Re-write.
32451 * expression.cs (Binary::Emit): Comment out code path to emit method
32452 invocation stuff for the case when we have a user defined operator. I am
32453 just not able to get it right !
32455 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32457 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32460 (Expression::MemberLookup): Provide a version that allows to
32461 specify the MemberTypes and BindingFlags.
32463 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32464 so it was not fetching variable information from outer blocks.
32466 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32467 Beforefieldinit as it was buggy.
32469 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32470 that Ravi put here.
32472 * class.cs (Constructor::Emit): Only emit if block is not null.
32473 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32474 deal with this by semantically definining it as if the user had
32477 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32478 constructors as we now "emit" them at a higher level.
32480 (TypeContainer::DefineDefaultConstructor): Used to define the
32481 default constructors if none was provided.
32483 (ConstructorInitializer): Add methods Resolve and Emit.
32485 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32487 2001-09-17 Ravi Pratap <ravi@ximian.com>
32489 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32490 the default constructor builder with our hashtable for methodbuilders
32493 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32494 and argument_count is 0 in which case we have a match.
32495 (Binary::ResolveOperator): More null checking and miscellaneous coding
32498 2001-09-17 Ravi Pratap <ravi@ximian.com>
32500 * rootcontext.cs (IsNameSpace): Compare against null.
32502 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32504 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32505 and Unary::Operator.
32507 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32510 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32511 we have overloaded operators.
32512 (Binary::ResolveOperator): Implement the part which does the operator overload
32515 * class.cs (Operator::Emit): Implement.
32516 (TypeContainer::Emit): Emit the operators we have too.
32518 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32519 the case when we have a user-defined operator.
32521 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32523 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32525 2001-09-16 Ravi Pratap <ravi@ximian.com>
32527 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32528 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32529 (Constructor::Emit): Implement.
32530 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32531 if we have no work to do.
32532 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32535 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32536 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32538 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32541 2001-09-15 Ravi Pratap <ravi@ximian.com>
32543 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32545 (Tree::RecordNamespace): Method to do what the name says ;-)
32546 (Tree::Namespaces): Property to get at the namespaces hashtable.
32548 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32551 * rootcontext.cs (IsNamespace): Fixed it :-)
32553 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32555 * class.cs (TypeContainer::FindMembers): Add support for
32557 (MethodCore): New class that encapsulates both the shared aspects
32558 of a Constructor and a Method.
32559 (Method, Constructor): Factored pieces into MethodCore.
32561 * driver.cs: Added --fatal which makes errors throw exceptions.
32562 Load System assembly as well as part of the standard library.
32564 * report.cs: Allow throwing exceptions on errors for debugging.
32566 * modifiers.cs: Do not use `parent', instead use the real type
32567 container to evaluate permission settings.
32569 * class.cs: Put Ravi's patch back in. He is right, and we will
32570 have to cope with the
32572 2001-09-14 Ravi Pratap <ravi@ximian.com>
32574 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32575 FamORAssem, not FamANDAssem.
32577 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32579 * driver.cs: Added --parse option that only parses its input files
32582 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32583 incorrect. IsTopLevel is not used to tell whether an object is
32584 root_types or not (that can be achieved by testing this ==
32585 root_types). But to see if this is a top-level *class* (not
32586 necessarly our "toplevel" container).
32588 2001-09-14 Ravi Pratap <ravi@ximian.com>
32590 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32591 parent instead of a direct call to GetType.
32593 2001-09-14 Ravi Pratap <ravi@ximian.com>
32595 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32596 Modifiers.TypeAttr. This should just be a call to that method.
32598 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32599 object so that we can determine if we are top-level or not.
32601 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32604 * enum.cs (Enum::Define): Ditto.
32606 * modifiers.cs (FieldAttr): Re-write.
32608 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32609 (TypeContainer::HaveStaticConstructor): New property to provide access
32610 to precisely that info.
32612 * modifiers.cs (MethodAttr): Re-write.
32613 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32615 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32616 of top-level types as claimed.
32618 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32620 * expression.cs (MemberLookup): Fruitless attempt to lookup
32621 constructors. Maybe I need to emit default constructors? That
32622 might be it (currently .NET emits this for me automatically).
32623 (Invocation::OverloadResolve): Cope with Arguments == null.
32624 (Invocation::EmitArguments): new function, shared by the new
32625 constructor and us.
32626 (Invocation::Emit): Handle static and instance methods. Emit
32627 proper call instruction for virtual or non-virtual invocations.
32628 (New::Emit): Implement.
32629 (New::Resolve): Implement.
32630 (MemberAccess:Resolve): Implement.
32631 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32632 to track instances.
32633 (FieldExpr::Resolve): Set type.
32635 * support.cs: Handle empty arguments.
32637 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32638 SimpleLookup): Auxiliary routines to help parse a qualifier
32641 Update qualifier_identifier rule.
32643 * codegen.cs: Removed debugging messages.
32645 * class.cs: Make this a global thing, this acts just as a "key" to
32646 objects that we might have around.
32648 (Populate): Only initialize method_builders_to_methods once.
32650 * expression.cs (PropertyExpr): Initialize type from the
32653 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32654 Resolve pattern. Attempt to implicitly convert value to boolean.
32657 * expression.cs: Set the type for the int32/int32 argument case.
32658 (Binary::ResolveOperator): Set the return type to boolean for
32659 comparission operators
32661 * typemanager.cs: Remove debugging print code.
32663 (Invocation::Resolve): resolve type.
32665 * class.cs: Allocate a MemberInfo of the correct size, as the code
32666 elsewhere depends on the test to reflect the correct contents.
32668 (Method::) Keep track of parameters, due to System.Reflection holes
32670 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32673 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32674 of the exact size and return that.
32676 (Class::LookupMethodByBuilder): New function that maps
32677 MethodBuilders to its methods. Required to locate the information
32678 on methods because System.Reflection bit us again.
32680 * support.cs: New file, contains an interface ParameterData and
32681 two implementations: ReflectionParameters and InternalParameters
32682 used to access Parameter information. We will need to grow this
32685 * expression.cs (Invocation::GetParameterData): implement a cache
32686 and a wrapper around the ParameterData creation for methods.
32687 (Invocation::OverloadResolve): Use new code.
32689 2001-09-13 Ravi Pratap <ravi@ximian.com>
32691 * class.cs (TypeContainer::EmitField): Remove and move into
32692 (Field::Define): here and modify accordingly.
32693 (Field.FieldBuilder): New member.
32694 (TypeContainer::Populate): Update accordingly.
32695 (TypeContainer::FindMembers): Implement.
32697 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32699 * statement.cs: (VariableInfo::VariableType): New field to be
32700 initialized with the full type once it is resolved.
32702 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32704 * parameter.cs (GetParameterInfo): Use a type cache to compute
32705 things only once, and to reuse this information
32707 * expression.cs (LocalVariableReference::Emit): Implement.
32708 (OpcodeCast::Emit): fix.
32710 (ParameterReference::Resolve): Implement.
32711 (ParameterReference::Emit): Implement.
32713 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32714 that are expressions need to stay as Expressions.
32716 * typemanager.cs (CSharpName): Returns the C# name of a type if
32719 * expression.cs (Expression::ConvertImplicit): New function that
32720 implements implicit type conversions.
32722 (Expression::ImplicitReferenceConversion): Implements implicit
32723 reference conversions.
32725 (EmptyCast): New type for transparent casts.
32727 (OpcodeCast): New type for casts of types that are performed with
32728 a sequence of bytecodes.
32730 (BoxedCast): New type used for casting value types into reference
32731 types. Emits a box opcode.
32733 (Binary::DoNumericPromotions): Implements numeric promotions of
32734 and computation of the Binary::Type.
32736 (Binary::EmitBranchable): Optimization.
32738 (Binary::Emit): Implement code emission for expressions.
32740 * typemanager.cs (TypeManager): Added two new core types: sbyte
32743 2001-09-12 Ravi Pratap <ravi@ximian.com>
32745 * class.cs (TypeContainer::FindMembers): Method which does exactly
32746 what Type.FindMembers does, only we don't have to use reflection. No
32747 implementation yet.
32749 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32750 typecontainer objects as we need to get at them.
32751 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32753 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32754 typecontainer object.
32756 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32757 of just a Report object.
32759 2001-09-11 Ravi Pratap <ravi@ximian.com>
32761 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32763 (TypeContainer::Populate): Now define the delegates of the type too.
32764 (TypeContainer.Delegates): Property to access the list of delegates defined
32767 * delegates.cs (Delegate::Define): Implement partially.
32769 * modifiers.cs (TypeAttr): Handle more flags.
32771 2001-09-11 Ravi Pratap <ravi@ximian.com>
32773 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32775 (Operator::Define): Re-write logic to get types by using the LookupType method
32776 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32777 (Indexer::Define): Ditto.
32778 (Event::Define): Ditto.
32779 (Property::Define): Ditto.
32781 2001-09-10 Ravi Pratap <ravi@ximian.com>
32783 * class.cs (TypeContainer::Populate): Now define operators too.
32784 (TypeContainer.Operators): New property to access the list of operators
32786 (Operator.OperatorMethodBuilder): New member to hold the method builder
32787 for the operator we are defining.
32788 (Operator::Define): Implement.
32790 2001-09-10 Ravi Pratap <ravi@ximian.com>
32792 * class.cs (Event::Define): Make the prefixes of the accessor methods
32793 addOn_ and removeOn_
32795 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32796 of the location being passed in too. Ideally, this should go later since all
32797 error reporting should be done through the Report object.
32799 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32800 (Populate): Iterate thru the indexers we have and define them too.
32801 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32802 for the get and set accessors.
32803 (Indexer::Define): Implement.
32805 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32807 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32808 my previous implementation, did not work.
32810 * typemanager.cs: Add a couple of missing types (the longs).
32812 * literal.cs: Use TypeManager.bool_type instead of getting it.
32814 * expression.cs (EventExpr): New kind of expressions.
32815 (Expressio::ExprClassFromMemberInfo): finish
32817 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32819 * assign.cs: Emit stores to static fields differently.
32821 2001-09-08 Ravi Pratap <ravi@ximian.com>
32823 * Merge in changes and adjust code to tackle conflicts. Backed out my
32824 code in Assign::Resolve ;-)
32826 2001-09-08 Ravi Pratap <ravi@ximian.com>
32828 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32829 instead Report.Error and also pass in the location.
32830 (CSharpParser::Lexer): New readonly property to return the reference
32831 to the Tokenizer object.
32832 (declare_local_variables): Use Report.Error with location instead of plain
32836 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32837 (Operator.CheckBinaryOperator): Ditto.
32839 * cs-parser.jay (operator_declarator): Update accordingly.
32841 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32842 (CheckBinaryOperator): Same here.
32844 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32845 on the name without any prefixes of namespace names etc. This is because we
32846 already might have something already fully qualified like
32847 'System.Console.WriteLine'
32849 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32851 2001-09-07 Ravi Pratap <ravi@ximian.com>
32853 * cs-tokenizer.cs (location): Return a string which also contains
32856 * expression.cs (ElementAccess): New class for expressions of the
32857 type 'element access.'
32858 (BaseAccess): New class for expressions of the type 'base access.'
32859 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32862 * cs-parser.jay (element_access): Implement action.
32863 (base_access): Implement actions.
32864 (checked_expression, unchecked_expression): Implement.
32866 * cs-parser.jay (local_variable_type): Correct and implement.
32867 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32869 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32871 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32872 name and the specifiers.
32874 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32876 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32877 making them all public ;-)
32879 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32882 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32884 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32886 (FieldExpr, PropertyExprs): New resolved expressions.
32887 (SimpleName::MemberStaticCheck): Perform static checks for access
32888 to non-static fields on static methods. Maybe this should be
32889 generalized for MemberAccesses.
32890 (SimpleName::ResolveSimpleName): More work on simple name
32893 * cs-parser.jay (primary_expression/qualified_identifier): track
32894 the parameter index.
32896 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32897 (EmitContext::EmitBoolExpression): Chain to expression generation
32898 instead of temporary hack.
32899 (::EmitStatementExpression): Put generic expression code generation.
32901 * assign.cs (Assign::Emit): Implement variable assignments to
32902 local variables, parameters and fields.
32904 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32906 * statement.cs (Block::GetVariableInfo): New method, returns the
32907 VariableInfo for a variable name in a block.
32908 (Block::GetVariableType): Implement in terms of GetVariableInfo
32910 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32911 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32913 2001-09-06 Ravi Pratap <ravi@ximian.com>
32915 * cs-parser.jay (operator_declaration): Continue on my quest : update
32916 to take attributes argument.
32917 (event_declaration): Ditto.
32918 (enum_declaration): Ditto.
32919 (indexer_declaration): Ditto.
32921 * class.cs (Operator::Operator): Update constructor accordingly.
32922 (Event::Event): Ditto.
32924 * delegate.cs (Delegate::Delegate): Same here.
32926 * enum.cs (Enum::Enum): Same here.
32928 2001-09-05 Ravi Pratap <ravi@ximian.com>
32930 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32932 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32934 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32935 being passed around as an arraylist.
32936 (Attributes::AddAttribute): Method to add attribute sections.
32938 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32939 (struct_declaration): Update accordingly.
32940 (constant_declaration): Update.
32941 (field_declaration): Update.
32942 (method_header): Update.
32943 (fixed_parameter): Update.
32944 (parameter_array): Ditto.
32945 (property_declaration): Ditto.
32946 (destructor_declaration): Ditto.
32948 * class.cs (Struct::Struct): Update constructors accordingly.
32949 (Class::Class): Ditto.
32950 (Field::Field): Ditto.
32951 (Method::Method): Ditto.
32952 (Property::Property): Ditto.
32953 (TypeContainer::OptAttribute): update property's return type.
32955 * interface.cs (Interface.opt_attributes): New member.
32956 (Interface::Interface): Update to take the extra Attributes argument.
32958 * parameter.cs (Parameter::Parameter): Ditto.
32960 * constant.cs (Constant::Constant): Ditto.
32962 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32963 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32964 the attributes as a parameter.
32965 (InterfaceProperty): Update constructor call.
32966 (InterfaceEvent): Ditto.
32967 (InterfaceMethod): Ditto.
32968 (InterfaceIndexer): Ditto.
32970 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32971 pass the attributes too.
32972 (interface_event_declaration): Ditto.
32973 (interface_property_declaration): Ditto.
32974 (interface_method_declaration): Ditto.
32975 (interface_declaration): Ditto.
32977 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32979 * class.cs (Method::Define): Track the "static Main" definition to
32980 create an entry point.
32982 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32983 EntryPoint if we find it.
32985 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32986 (EmitContext::ig): Make this variable public.
32988 * driver.cs: Make the default output file be the first file name
32989 with the .exe extension.
32991 Detect empty compilations
32993 Handle various kinds of output targets. Handle --target and
32994 rename -t to --dumper.
32996 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32997 methods inherited from Expression return now an Expression. This
32998 will is used during the tree rewriting as we resolve them during
33001 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
33002 the spec. Missing entirely is the information about
33003 accessability of elements of it.
33005 (Expression::ExprClassFromMemberInfo): New constructor for
33006 Expressions that creates a fully initialized Expression based on
33007 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
33010 (Invocation::Resolve): Begin implementing resolution of invocations.
33012 * literal.cs (StringLiteral): Implement Emit.
33014 2001-09-05 Ravi Pratap <ravi@ximian.com>
33016 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
33019 2001-09-04 Ravi Pratap <ravi@ximian.com>
33021 * cs-parser.jay (attribute_arguments): Implement actions.
33022 (attribute): Fix bug in production. Implement action.
33023 (attribute_list): Implement.
33024 (attribute_target): Implement.
33025 (attribute_target_specifier, opt_target_specifier): Implement
33026 (CheckAttributeTarget): New method to check if the attribute target
33028 (attribute_section): Implement.
33029 (opt_attributes): Implement.
33031 * attribute.cs : New file to handle attributes.
33032 (Attribute): Class to hold attribute info.
33034 * cs-parser.jay (opt_attribute_target_specifier): Remove production
33035 (attribute_section): Modify production to use 2 different rules to
33036 achieve the same thing. 1 s/r conflict down !
33037 Clean out commented, useless, non-reducing dimension_separator rules.
33039 * class.cs (TypeContainer.attributes): New member to hold list
33040 of attributes for a type.
33041 (Struct::Struct): Modify to take one more argument, the attribute list.
33042 (Class::Class): Ditto.
33043 (Field::Field): Ditto.
33044 (Method::Method): Ditto.
33045 (Property::Property): Ditto.
33047 * cs-parser.jay (struct_declaration): Update constructor call to
33048 pass in the attributes too.
33049 (class_declaration): Ditto.
33050 (constant_declaration): Ditto.
33051 (field_declaration): Ditto.
33052 (method_header): Ditto.
33053 (fixed_parameter): Ditto.
33054 (parameter_array): Ditto.
33055 (property_declaration): Ditto.
33057 * constant.cs (Constant::Constant): Update constructor similarly.
33058 Use System.Collections.
33060 * parameter.cs (Parameter::Parameter): Update as above.
33062 2001-09-02 Ravi Pratap <ravi@ximian.com>
33064 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
33065 (TypeContainer.delegates): New member to hold list of delegates.
33067 * cs-parser.jay (delegate_declaration): Implement the action correctly
33068 this time as I seem to be on crack ;-)
33070 2001-09-02 Miguel de Icaza <miguel@ximian.com>
33072 * rootcontext.cs (RootContext::IsNamespace): new function, used to
33073 tell whether an identifier represents a namespace.
33075 * expression.cs (NamespaceExpr): A namespace expression, used only
33076 temporarly during expression resolution.
33077 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
33078 utility functions to resolve names on expressions.
33080 2001-09-01 Miguel de Icaza <miguel@ximian.com>
33082 * codegen.cs: Add hook for StatementExpressions.
33084 * class.cs: Fix inverted test for static flag in methods.
33086 2001-09-02 Ravi Pratap <ravi@ximian.com>
33088 * class.cs (Operator::CheckUnaryOperator): Correct error number used
33089 to make it coincide with MS' number.
33090 (Operator::CheckBinaryOperator): Ditto.
33092 * ../errors/errors.txt : Remove error numbers added earlier.
33094 * ../errors/cs1019.cs : Test case for error # 1019
33096 * ../errros/cs1020.cs : Test case for error # 1020
33098 * cs-parser.jay : Clean out commented cruft.
33099 (dimension_separators, dimension_separator): Comment out. Ostensibly not
33100 used anywhere - non-reducing rule.
33101 (namespace_declarations): Non-reducing rule - comment out.
33103 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
33104 with TypeContainer::AddEnum.
33106 * delegate.cs : New file for delegate handling classes.
33107 (Delegate): Class for declaring delegates.
33109 * makefile : Update.
33111 * cs-parser.jay (delegate_declaration): Implement.
33113 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33115 * class.cs (Event::Define): Implement.
33116 (Event.EventBuilder): New member.
33118 * class.cs (TypeContainer::Populate): Update to define all enums and events
33120 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33121 readonly fields for all these cases ?
33123 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33125 * class.cs (Property): Revamp to use the convention of making fields readonly.
33126 Accordingly modify code elsewhere.
33128 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33129 the Define method of the Property class.
33131 * class.cs : Clean up applied patch and update references to variables etc. Fix
33133 (TypeContainer::Populate): Update to define all the properties we have. Also
33134 define all enumerations.
33136 * enum.cs (Define): Implement.
33138 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33140 * cs-parser.jay (overloadable_operator): The semantic value is an
33141 enum of the Operator class.
33142 (operator_declarator): Implement actions.
33143 (operator_declaration): Implement.
33145 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33146 validity of definitions.
33147 (Operator::CheckBinaryOperator): Static method to check for binary operators
33148 (TypeContainer::AddOperator): New method to add an operator to a type.
33150 * cs-parser.jay (indexer_declaration): Added line to actually call the
33151 AddIndexer method so it gets added ;-)
33153 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33154 already taken care of by the MS compiler ?
33156 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33158 * class.cs (Operator): New class for operator declarations.
33159 (Operator::OpType): Enum for the various operators.
33161 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33163 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33164 ostensibly handle this in semantic analysis.
33166 * cs-parser.jay (general_catch_clause): Comment out
33167 (specific_catch_clauses, specific_catch_clause): Ditto.
33168 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33169 (catch_args, opt_catch_args): New productions.
33170 (catch_clause): Rewrite to use the new productions above
33171 (catch_clauses): Modify accordingly.
33172 (opt_catch_clauses): New production to use in try_statement
33173 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33174 and re-write the code in the actions to extract the specific and
33175 general catch clauses by being a little smart ;-)
33177 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33178 Hooray, try and catch statements parse fine !
33180 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33182 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33183 string from the hashtable of variables.
33185 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33186 I end up making that mistake ;-)
33187 (catch_clauses): Fixed gross error which made Key and Value of the
33188 DictionaryEntry the same : $1 !!
33190 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33192 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33194 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33195 when the add and remove accessors are specified.
33197 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33199 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33200 information about indexer_declarator.
33201 (indexer_declarator): Implement actions.
33202 (parsing_indexer): New local boolean used to keep track of whether
33203 we are parsing indexers or properties. This is necessary because
33204 implicit_parameters come into picture even for the get accessor in the
33205 case of an indexer.
33206 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33208 * class.cs (Indexer): New class for indexer declarations.
33209 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33210 (TypeContainer::indexers): New member to hold list of indexers for the
33213 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33215 * cs-parser.jay (add_accessor_declaration): Implement action.
33216 (remove_accessor_declaration): Implement action.
33217 (event_accessors_declaration): Implement
33218 (variable_declarators): swap statements for first rule - trivial.
33220 * class.cs (Event): New class to hold information about event
33222 (TypeContainer::AddEvent): New method to add an event to a type
33223 (TypeContainer::events): New member to hold list of events.
33225 * cs-parser.jay (event_declaration): Implement actions.
33227 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33229 * cs-parser.jay (dim_separators): Implement. Make it a string
33230 concatenating all the commas together, just as they appear.
33231 (opt_dim_separators): Modify accordingly
33232 (rank_specifiers): Update accordingly. Basically do the same
33233 thing - instead, collect the brackets here.
33234 (opt_rank_sepcifiers): Modify accordingly.
33235 (array_type): Modify to actually return the complete type string
33236 instead of ignoring the rank_specifiers.
33237 (expression_list): Implement to collect the expressions
33238 (variable_initializer): Implement. We make it a list of expressions
33239 essentially so that we can handle the array_initializer case neatly too.
33240 (variable_initializer_list): Implement.
33241 (array_initializer): Make it a list of variable_initializers
33242 (opt_array_initializer): Modify accordingly.
33244 * expression.cs (New::NType): Add enumeration to help us
33245 keep track of whether we have an object/delegate creation
33246 or an array creation.
33247 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33248 members to hold data about array creation.
33249 (New:New): Modify to update NewType
33250 (New:New): New Overloaded contructor for the array creation
33253 * cs-parser.jay (array_creation_expression): Implement to call
33254 the overloaded New constructor.
33256 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33258 * class.cs (TypeContainer::Constructors): Return member
33259 constructors instead of returning null.
33261 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33263 * typemanager.cs (InitCoreTypes): Initialize the various core
33264 types after we have populated the type manager with the user
33265 defined types (this distinction will be important later while
33266 compiling corlib.dll)
33268 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33269 on Expression Classification. Now all expressions have a method
33270 `Resolve' and a method `Emit'.
33272 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33273 generation from working. Also add some temporary debugging
33276 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33278 * codegen.cs: Lots of code generation pieces. This is only the
33279 beginning, will continue tomorrow with more touches of polish. We
33280 handle the fundamentals of if, while, do, for, return. Others are
33281 trickier and I need to start working on invocations soon.
33283 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33286 * codegen.cs (EmitContext): New struct, used during code
33287 emission to keep a context. Most of the code generation will be
33290 * cs-parser.jay: Add embedded blocks to the list of statements of
33291 this block. So code generation proceeds in a top down fashion.
33293 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33295 * statement.cs: Add support for multiple child blocks.
33297 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33299 * codegen.cs (EmitCode): New function, will emit the code for a
33300 Block of code given a TypeContainer and its ILGenerator.
33302 * statement.cs (Block): Standard public readonly optimization.
33303 (Block::Block constructors): Link children.
33304 (Block::Child): Child Linker.
33305 (Block::EmitVariables): Emits IL variable declarations.
33307 * class.cs: Drop support for MethodGroups here, delay until
33309 (Method::): Applied the same simplification that I did before, and
33310 move from Properties to public readonly fields.
33311 (Method::ParameterTypes): Returns the parameter types for the
33312 function, and implements a cache that will be useful later when I
33313 do error checking and the semantic analysis on the methods is
33315 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33316 and made a method, optional argument tells whether this is a class
33317 or a structure to apply the `has-this' bit.
33318 (Method::GetCallingConvention): Implement, returns the calling
33320 (Method::Define): Defines the type, a second pass is performed
33321 later to populate the methods.
33323 (Constructor::ParameterTypes): implement a cache similar to the
33324 one on Method::ParameterTypes, useful later when we do semantic
33327 (TypeContainer::EmitMethod): New method. Emits methods.
33329 * expression.cs: Removed MethodGroup class from here.
33331 * parameter.cs (Parameters::GetCallingConvention): new method.
33333 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33335 * class.cs (TypeContainer::Populate): Drop RootContext from the
33338 (Constructor::CallingConvention): Returns the calling convention.
33339 (Constructor::ParameterTypes): Returns the constructor parameter
33342 (TypeContainer::AddConstructor): Keep track of default constructor
33343 and the default static constructor.
33345 (Constructor::) Another class that starts using `public readonly'
33346 instead of properties.
33348 (Constructor::IsDefault): Whether this is a default constructor.
33350 (Field::) use readonly public fields instead of properties also.
33352 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33353 track of static constructors; If none is used, turn on
33354 BeforeFieldInit in the TypeAttributes.
33356 * cs-parser.jay (opt_argument_list): now the return can be null
33357 for the cases where there are no arguments.
33359 (constructor_declarator): If there is no implicit `base' or
33360 `this', then invoke the default parent constructor.
33362 * modifiers.cs (MethodAttr): New static function maps a set of
33363 modifiers flags into a MethodAttributes enum
33364 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33365 MethodAttr, TypeAttr to represent the various mappings where the
33366 modifiers are used.
33367 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33369 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33371 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33374 * interface.cs (PopulateIndexer): Implemented the code generator
33375 for interface indexers.
33377 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33379 * interface.cs (InterfaceMemberBase): Now we track the new status
33382 (PopulateProperty): Implement property population. Woohoo! Got
33383 Methods and Properties going today.
33385 Removed all the properties for interfaces, and replaced them with
33386 `public readonly' fields.
33388 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33390 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33391 initialize their hashtables/arraylists only when they are needed
33392 instead of doing this always.
33394 * parameter.cs: Handle refs and out parameters.
33396 * cs-parser.jay: Use an ArrayList to construct the arguments
33397 instead of the ParameterCollection, and then cast that to a
33400 * parameter.cs: Drop the use of ParameterCollection and use
33401 instead arrays of Parameters.
33403 (GetParameterInfo): Use the Type, not the Name when resolving
33406 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33408 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33409 and instead use public readonly fields.
33411 * class.cs: Put back walking code for type containers.
33413 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33415 * class.cs (MakeConstant): Code to define constants.
33417 * rootcontext.cs (LookupType): New function. Used to locate types
33420 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33422 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33423 this System.Reflection code is. Kudos to Microsoft
33425 * typemanager.cs: Implement a type cache and avoid loading all
33426 types at boot time. Wrap in LookupType the internals. This made
33427 the compiler so much faster. Wow. I rule!
33429 * driver.cs: Make sure we always load mscorlib first (for
33430 debugging purposes, nothing really important).
33432 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33433 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33435 * rootcontext.cs: Lookup types on their namespace; Lookup types
33436 on namespaces that have been imported using the `using' keyword.
33438 * class.cs (TypeContainer::TypeAttr): Virtualize.
33439 (Class::TypeAttr): Return attributes suitable for this bad boy.
33440 (Struct::TypeAttr): ditto.
33441 Handle nested classes.
33442 (TypeContainer::) Remove all the type visiting code, it is now
33443 replaced with the rootcontext.cs code
33445 * rootcontext.cs (GetClassBases): Added support for structs.
33447 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33449 * interface.cs, statement.cs, class.cs, parameter.cs,
33450 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33451 Drop use of TypeRefs, and use strings instead.
33453 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33457 * class.cs (Struct::Struct): set the SEALED flags after
33458 checking the modifiers.
33459 (TypeContainer::TypeAttr): new property, returns the
33460 TypeAttributes for a class.
33462 * cs-parser.jay (type_list): Oops, list production was creating a
33463 new list of base types.
33465 * rootcontext.cs (StdLib): New property.
33466 (GetInterfaceTypeByName): returns an interface by type name, and
33467 encapsulates error handling here.
33468 (GetInterfaces): simplified.
33469 (ResolveTree): Encapsulated all the tree resolution here.
33470 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33473 * driver.cs: Add support for --nostdlib, to avoid loading the
33474 default assemblies.
33475 (Main): Do not put tree resolution here.
33477 * rootcontext.cs: Beginning of the class resolution.
33479 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33481 * rootcontext.cs: Provide better error reporting.
33483 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33485 * rootcontext.cs (CreateInterface): Handle the case where there
33486 are no parent interfaces.
33488 (CloseTypes): Routine to flush types at the end.
33489 (CreateInterface): Track types.
33490 (GetInterfaces): Returns an array of Types from the list of
33491 defined interfaces.
33493 * typemanager.c (AddUserType): Mechanism to track user types (puts
33494 the type on the global type hash, and allows us to close it at the
33497 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33499 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33500 RecordInterface instead.
33502 * cs-parser.jay: Updated to reflect changes above.
33504 * decl.cs (Definition): Keep track of the TypeBuilder type that
33505 represents this type here. Not sure we will use it in the long
33506 run, but wont hurt for now.
33508 * driver.cs: Smaller changes to accomodate the new code.
33510 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33513 * rootcontext.cs (CreateInterface): New method, used to create
33514 the System.TypeBuilder type for interfaces.
33515 (ResolveInterfaces): new entry point to resolve the interface
33517 (CodeGen): Property, used to keep track of the code generator.
33519 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33521 * cs-parser.jay: Add a second production for delegate_declaration
33524 (enum_body): Put an opt_comma here instead of putting it on
33525 enum_body or enum_member_declarations so we can handle trailing
33526 commas on enumeration members. Gets rid of a shift/reduce.
33528 (type_list): Need a COMMA in the middle.
33530 (indexer_declaration): Tell tokenizer to recognize get/set
33532 * Remove old targets.
33534 * Re-add the parser target.
33536 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33538 * cs-parser.jay: Add precendence rules for a number of operators
33539 ot reduce the number of shift/reduce conflicts in the grammar.
33541 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33543 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33546 Get rid of old crufty code.
33548 * rootcontext.cs: Use this to keep track of the parsed
33549 representation and the defined types available to the program.
33551 * gen-treedump.cs: adjust for new convention.
33553 * type.cs: Split out the type manager, and the assembly builder
33556 * typemanager.cs: the type manager will live here now.
33558 * cil-codegen.cs: And the code generator here.
33560 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33562 * makefile: Fixed up for easy making.
33564 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33566 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33569 (unary_expression): Expand pre_increment_expression and
33570 post_decrement_expression to reduce a shift/reduce.
33572 2001-07-11 Simon Cozens
33574 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33576 Improve allow_keyword_as_indent name.
33578 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33580 * Adjustments for Beta2.
33582 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33584 * decl.cs: Added `Define' abstract method.
33585 (InTransit): new property, used to catch recursive definitions.
33587 * interface.cs: Implement `Define'.
33589 * modifiers.cs: Map Modifiers.constants to
33590 System.Reflection.TypeAttribute flags.
33592 * class.cs: Keep track of types and user-defined types.
33593 (BuilderInit): New method for creating an assembly
33594 (ResolveType): New function to launch the resolution process, only
33595 used by interfaces for now.
33597 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33598 that are inserted into the name space.
33600 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33602 * ARGH. I have screwed up my tree so many times due to the use of
33603 rsync rather than using CVS. Going to fix this at once.
33605 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33608 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33610 * Experiment successful: Use System.Type rather that our own
33613 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33615 * cs-parser.jay: Removed nsAliases from here.
33617 Use new namespaces, handle `using XXX;'
33619 * namespace.cs: Reimplemented namespace handling, use a recursive
33620 definition of the class. Now we can keep track of using clauses
33621 and catch invalid using clauses.
33623 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33625 * gen-treedump.cs: Adapted for all the renaming.
33627 * expression.cs (Expression): this class now has a Type property
33628 which returns an expression Type.
33630 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33631 `Type', as this has a different meaning now in the base
33633 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33635 * interface.cs, class.cs: Removed from all the sources the
33636 references to signature computation, as we can not do method
33637 signature computation during the parsing time, as we are not
33638 trying to solve at that point distinguishing:
33642 void a (NS.Blah x) {}
33645 Which depending on the context might be valid or not, as we do not
33646 know if Blah is the same thing as NS.Blah at that point.
33648 * Redid everything so the code uses TypeRefs now instead of
33649 Types. TypeRefs are just temporary type placeholders, that need
33650 to be resolved. They initially have a pointer to a string and the
33651 current scope in which they are used. This is used later by the
33652 compiler to resolve the reference to an actual Type.
33654 * DeclSpace is no longer a CIR.Type, and neither are
33655 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33656 are all DeclSpaces, but no Types.
33658 * type.cs (TypeRefManager): This implements the TypeRef manager,
33659 which keeps track of all the types that need to be resolved after
33660 the parsing has finished.
33662 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33664 * ARGH. We are going to have to store `foreach' as a class rather
33665 than resolving it, as we need to verify error 1579 after name
33666 resolution. *OR* we could keep a flag that says `This request to
33667 IEnumerator comes from a foreach statement' which we can then use
33668 to generate the error.
33670 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33672 * class.cs (TypeContainer.AddMethod): we now add methods to the
33673 MethodGroup instead of the method hashtable.
33675 * expression.cs: Add MethodGroup abstraction, which gets us one
33676 step closer to the specification in the way we handle method
33679 * cs-parser.jay (primary_expression): qualified_identifier now
33680 tried to match up an identifier to a local variable reference or
33681 to a parameter reference.
33683 current_local_parameters is now a parser global variable that
33684 points to the current parameters for the block, used during name
33687 (property_declaration): Now creates an implicit `value' argument to
33690 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33692 * parameter.cs: Do not use `param' arguments as part of the
33693 signature, per the spec.
33695 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33697 * decl.cs: Base class for classes, structs and interfaces. This
33698 is the "Declaration Space"
33700 * cs-parser.jay: Use CheckDef for checking declaration errors
33701 instead of having one on each function.
33703 * class.cs: Factor out some code for handling error handling in
33704 accordance to the "Declarations" section in the "Basic Concepts"
33705 chapter in the ECMA C# spec.
33707 * interface.cs: Make all interface member classes derive from
33708 InterfaceMemberBase.
33710 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33712 * Many things: all interfaces are parsed and generated in
33713 gen-treedump. Support for member variables, constructors,
33714 destructors, properties, constants is there.
33716 Beginning of the IL backend, but very little done, just there for
33719 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33721 * cs-parser.jay: Fix labeled statement.
33723 * cs-tokenizer.cs (escape): Escape " and ' always.
33724 ref_line, ref_name: keep track of the line/filename as instructed
33725 by #line by the compiler.
33728 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33730 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33731 to match the values in System.CodeDOM.
33733 Divid renamed to Divide.
33735 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33737 (Statements.set): remove.
33739 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33742 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33743 falseStatements always have valid values.
33745 * cs-parser.jay: Use System.CodeDOM now.