1 2004-09-19 Miguel de Icaza <miguel@ximian.com>
3 * cs-parser.jay: Do not report the stack trace, this is barely
6 2004-08-22 John Luke <john.luke@gmail.com>
8 * driver.cs : check that a resource id is not already used
9 before adding it, report CS1508 if it is, bug #63637
11 2004-09-19 Miguel de Icaza <miguel@ximian.com>
13 * ecore.cs: Removed dead code.
15 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17 * class.cs: Do not report warning CS0067 on the interfaces.
19 2004-09-16 Marek Safar <marek.safar@seznam.cz>
21 * cs-parser.jay: Add error 504 report.
23 2004-09-16 Marek Safar <marek.safar@seznam.cz>
25 * rootcontext.cs: WarningLevel is 4 by default now.
27 * statement.cs (Fixed.Resolve): Do not null
30 2004-09-16 Marek Safar <marek.safar@seznam.cz>
33 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
34 deep search when property is not virtual.
35 (PropertyExpr.ResolveAccessors): Make one call for both
38 2004-09-15 Marek Safar <marek.safar@seznam.cz>
41 * statement.cs: Error 152 report constains also location.
43 2004-09-15 Marek Safar <marek.safar@seznam.cz>
46 * const.cs: Explicitly set constant as static.
48 2004-09-15 Marek Safar <marek.safar@seznam.cz>
51 * cs-parser.jay: Add error 1017 report.
53 2004-09-15 Marek Safar <marek.safar@seznam.cz>
55 Fixed bug #59980, #64224
56 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
58 * typemanager.cs (IsSpecialMethod): Simplified
60 2004-09-14 Marek Safar <marek.safar@seznam.cz>
62 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
63 condition with better params.
65 2004-09-14 Marek Safar <marek.safar@seznam.cz>
68 * attribute.cs (Resolve): Property has to have both
71 2004-09-14 Martin Baulig <martin@ximian.com>
73 Merged latest changes into gmcs. Please keep this comment in
74 here, it makes it easier for me to see what changed in MCS since
75 the last time I merged.
77 2004-09-14 Martin Baulig <martin@ximian.com>
79 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
81 2004-09-14 Marek Safar <marek.safar@seznam.cz>
84 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
85 called and is obsolete then this member suppress message
86 when call is inside next [Obsolete] method or type.
88 * expression.cs: Use TestObsoleteMethodUsage member.
90 2004-09-14 Martin Baulig <martin@ximian.com>
92 * cs-parser.jay: Sync a bit with the GMCS version.
94 2004-09-14 Martin Baulig <martin@ximian.com>
96 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
97 (CSharpParser.yacc_verbose_flag): New public field.
99 * genericparser.cs: Removed.
101 2004-09-14 Raja R Harinath <rharinath@novell.com>
103 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
105 2004-09-13 Marek Safar <marek.safar@seznam.cz>
107 * class.cs (MethodCore.CheckBase): Fix bug #65757.
109 2004-09-10 Martin Baulig <martin@ximian.com>
111 Backported my MemberName changes from GMCS into MCS.
113 - we are now using a special `MemberName' class instead of using
114 strings; in GMCS, the `MemberName' also contains the type
117 - changed the grammar rules a bit:
118 * the old `member_name' is now a `namespace_or_type_name':
119 The rule is that we use `namespace_or_type_name' everywhere
120 where we expect either a "member name" (GetEnumerator) or a
121 "member name" with an explicit interface name
122 (IEnumerable.GetEnumerator).
123 In GMCS, the explicit interface name may include type arguments
124 (IEnumerable<T>.GetEnumerator).
125 * we use `member_name' instead of just `IDENTIFIER' for
127 The rule is that we use `member_name' wherever a member may
128 have type parameters in GMCS.
130 * decl.cs (MemberName): New public class.
131 (MemberCore.MemberName): New public readonly field.
132 (MemberCore.ctor): Take a `MemberName' argument, not a string.
133 (DeclSpace): Likewise.
135 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
136 * enum.cs (Enum.ctor): Likewise.
138 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
140 (AliasEntry.ctor): Take a MemberName, not an Expression.
141 (AliasEntry.UsingAlias): Likewise.
143 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
144 (IMethodData.MemberName): Changed type from string to MemberName.
145 (MemberBase.ExplicitInterfaceName): Likewise.
146 (AbstractPropertyEventMethod.SetupName): Make this private.
147 (AbstractPropertyEventMethod.ctor): Added `string prefix'
148 argument; compute the member name here.
149 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
150 on the `member.MemberName' and the `prefix'.
152 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
154 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
155 thus, we get a `MemberName' instead of a `string'. These
156 declarations may have type parameters in GMCS.
157 (interface_method_declaration, delegate_declaration): Likewise.
158 (class_declaration, interface_declaration): Likewise.
159 (method_header): Use `namespace_or_type_name' instead of
160 `member_name'. We may be an explicit interface implementation.
161 (property_declaration, event_declaration): Likewise.
162 (member_name): This is now just an `IDENTIFIER', not a
163 `namespace_or_type_name'.
164 (type_name, interface_type): Removed.
165 (namespace_or_type_name): Return a MemberName, not an Expression.
166 (primary_expression): Use `member_name' instead of `IDENTIFIER';
167 call GetTypeExpression() on the MemberName to get an expression.
168 (IndexerDeclaration.interface_type): Changed type from string to
170 (MakeName): Operate on MemberName's instead of string's.
172 2004-09-13 Raja R Harinath <rharinath@novell.com>
175 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
176 (NamespaceEntry.Lookup): Add new argument to flag if we want the
177 lookup to avoid symbols introduced by 'using'.
178 * rootcontext.cs (NamespaceLookup): Update.
180 2004-09-12 Marek Safar <marek.safar@seznam.cz>
182 * class.cs (TypeContainer.DoDefineMembers): Do not call
183 DefineDefaultConstructor for static classes.
185 2004-09-12 Marek Safar <marek.safar@seznam.cz>
187 * attribute.cs (Attribute.Resolve): Add error 653 report.
189 * class.cs (Class.ApplyAttributeBuilder): Add error 641
191 (Method.ApplyAttributeBuilder): Add error 685 report.
192 (Operator.Define): Add error 564 report.
194 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
196 * expression.cs (Invocation.DoResolve): Add error
199 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
202 2004-09-11 Marek Safar <marek.safar@seznam.cz>
204 * class.cs (ConstructorInitializer.Resolve):
205 Wrong error number (515->516).
207 2004-09-11 Marek Safar <marek.safar@seznam.cz>
209 * class.cs (Indexer.Define): Add error 631 report.
211 2004-09-11 Marek Safar <marek.safar@seznam.cz>
213 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
215 2004-09-11 Marek Safar <marek.safar@seznam.cz>
217 * expression.cs (Probe.DoResolve): Add error CS0241 report.
219 2004-09-10 Marek Safar <marek.safar@seznam.cz>
221 * cs-parser.jay: Added error CS0241 report.
223 2004-09-10 Raja R Harinath <rharinath@novell.com>
225 * cs-parser.jay (fixed_statement): Introduce a scope for the
226 declaration in the 'fixed' statement.
228 2004-09-09 Marek Safar <marek.safar@seznam.cz>
230 * cs-parser.jay: Added CS0230 error report.
232 2004-09-09 Marek Safar <marek.safar@seznam.cz>
234 * cs-parser.jay: Added errors CS0231 and CS0257 report.
236 2004-09-09 Marek Safar <marek.safar@seznam.cz>
238 * expression.cs (Argument.Resolve): Added error CS0192 and
241 2004-09-09 Marek Safar <marek.safar@seznam.cz>
243 C# 2.0 #pragma warning feature
245 * cs-tokenizer.cs (PreProcessPragma): New method;
246 Handles #pragma directive.
248 * report.cs (WarningRegions): New class; Support
249 class for #pragma warning directive. It tests whether
250 warning is enabled for a given line.
252 2004-09-08 Miguel de Icaza <miguel@ximian.com>
254 * const.cs: Add more descriptive error report, tahnks to
257 2004-09-08 Marek Safar <marek.safar@seznam.cz>
259 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
261 2004-09-07 Miguel de Icaza <miguel@ximian.com>
263 * expression.cs: Apply patch from Ben: Remove dead code from
264 ArrayCreation, and remove the TurnintoConstant call in const.cs,
265 as that code just threw an exception anwyays.
267 * const.cs: Remove the call to the turnintoconstant, for details
270 * literal.cs: The type of the null-literal is the null type; So
271 we use a placeholder type (literal.cs:System.Null, defined here)
274 * expression.cs (Conditional.DoResolve): Remove some old code that
275 is no longer needed, conversions have been fixed.
277 (ArrayCreationExpression.DoResolve): Return false if we fail to
278 resolve the inner expression.
280 2004-09-07 Raja R Harinath <rharinath@novell.com>
283 * cs-parser.jay (delegate_declaration): Record a delegate
284 declaration as a type declaration.
285 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
287 2004-09-06 Miguel de Icaza <miguel@ximian.com>
289 * parameter.cs: Do not crash if the type can not be resolved.
291 * expression.cs: Report errors with unsafe pointers, fixes #64896
293 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
295 * expression.cs: Pointer arith always needs to do a conv.i
296 if the operand is a long. fix 65320
298 2004-09-04 Marek Safar <marek.safar@seznam.cz>
300 Fixed cs0619-37.cs, cs0619-38.cs
302 * enum.cs (GetObsoleteAttribute): Removed.
304 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
305 on Enum member is double staged. The first is tested member
308 2004-09-04 Marek Safar <marek.safar@seznam.cz>
310 Fixed #56986, #63631, #65231
312 * class.cs: (TypeContainer.AddToMemberContainer): New method,
313 adds member to name container.
314 (TypeContainer.AddToTypeContainer): New method, adds type to
316 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
317 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
318 AddOperator): Simplified by reusing AddToMemberContainer.
319 (TypeContainer.UserDefinedStaticConstructor): Changed to property
321 (Method.CheckForDuplications): Fixed implementation to test all
323 (MemberBase): Detection whether member is explicit interface
324 implementation is now in constructor.
325 (MemberBase.UpdateMemberName): Handles IndexerName.
326 (Accessor): Changed to keep also location information.
327 (AbstractPropertyEventMethod): Is derived from MemberCore.
328 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
329 will be emited or not.
330 (PropertyBase.AreAccessorsDuplicateImplementation):
331 Tests whether accessors are not in collision with some method.
332 (Operator): Is derived from MethodCore to simplify common
335 * decl.cs (Flags.TestMethodDuplication): Test for duplication
337 (DeclSpace.AddToContainer): Adds the member to defined_names
338 table. It tests for duplications and enclosing name conflicts.
340 * enum.cs (EnumMember): Clean up to reuse the base structures
342 2004-09-03 Martin Baulig <martin@ximian.com>
344 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
345 into TypeContainer, to make partial classes work again.
347 2004-09-03 Martin Baulig <martin@ximian.com>
349 * rootcontext.cs (RootContext.V2): Removed.
351 2004-03-23 Martin Baulig <martin@ximian.com>
353 * expression.cs (Invocation.OverloadResolve): Added `bool
354 may_fail' argument and use it instead of the Location.IsNull() hack.
356 2004-09-03 Martin Baulig <martin@ximian.com>
358 Merged latest changes into gmcs. Please keep this comment in
359 here, it makes it easier for me to see what changed in MCS since
360 the last time I merged.
362 2004-09-03 Raja R Harinath <rharinath@novell.com>
365 * expression.cs (BetterConversion): Don't allow either conversion
366 to be null. Remove redundant implicit conversion test when 'q ==
367 null' -- when this function is invoked, we already know that the
368 implicit conversion exists.
369 (BetterFunction): Assume that 'best' is non-null. Remove
370 redundant reimplementation of IsApplicable when 'best' is null.
371 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
373 (IsAncestralType): Extract from OverloadResolve.
374 (OverloadResolve): Make robust to the MethodGroupExpr being
375 unsorted. Implement all the logic of Section 14.5.5.1, and
376 support overloading of methods from multiple applicable types.
377 Clean up logic somewhat. Don't pass null methods to BetterFunction.
379 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
380 (RealError, Warning): Append type of report to related symbol.
382 2004-09-03 Marek Safar <marek.safar@seznam.cz>
384 * enum.cs: Fixed CLS-Compliance checks for enum members.
385 Error tests cs3008-8.cs, cs3014-8.cs
387 2004-09-02 Marek Safar <marek.safar@seznam.cz>
389 Fixed bug #62342, #63102
390 * class.cs: ImplementIndexer uses member.IsExplicitImpl
391 like ImplementMethod.
393 2004-09-02 Marek Safar <marek.safar@seznam.cz>
395 * attribute.cs (Attribute.GetAttributeArgumentExpression):
398 2004-09-02 Martin Baulig <martin@ximian.com>
400 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
401 TypeManager.GetArgumentTypes() rather than calling GetParameters()
404 2004-09-01 Marek Safar <marek.safar@seznam.cz>
406 C# 2.0 Static classes implemented
408 * class.cs (TypeContainer): instance_constructors,
409 initialized_fields, initialized_static_fields,
410 default_constructor, base_inteface_types are protected to be
411 accessible from StaticClass.
412 (TypeContainer.DefineDefaultConstructor): New virtual method
413 for custom default constructor generating
414 (StaticClass): New class to handle "Static classes" feature.
416 * cs-parser.jay: Handle static keyword on class like instance
419 * driver.cs: Added "/langversion" command line switch with two
420 options (iso-1, default).
422 2004-08-31 Marek Safar <marek.safar@seznam.cz>
424 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
426 2004-08-31 Miguel de Icaza <miguel@ximian.com>
428 * delegate.cs: Style.
430 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
432 * delegate.cs: Add seperate instance expr field for miguel.
434 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
436 * PointerArithmetic (Resolve): make sure we are not doing
437 pointer arith on void*. Also, make sure we are resolved
438 by not setting eclass until resolve.
440 All callers: Make sure that PointerArithmetic gets resolved.
442 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
444 * ArrayCreation (LookupType): If the type does not resolve
445 to an array, give an error.
447 2004-08-27 Marek Safar <marek.safar@seznam.cz>
449 * statement.cs (Try.Resolve): Fixed bug #64222
451 2004-08-27 Martin Baulig <martin@ximian.com>
454 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
457 2004-08-26 Marek Safar <marek.safar@seznam.cz>
459 * ecore.cs (Constantify): Get underlying type via
460 System.Enum.GetUnderlyingType to avoid StackOverflow on the
461 Windows in special cases.
463 2004-08-26 Marek Safar <marek.safar@seznam.cz>
465 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
466 for obtaining also private methods.
467 (GetRemoveMethod): Used GetRemoveMethod (true)
468 for obtaining also private methods.
470 2004-08-24 Martin Baulig <martin@ximian.com>
472 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
473 MethodAttributes.HideBySig for operators.
475 2004-08-23 Martin Baulig <martin@ximian.com>
477 Back to the old error reporting system :-)
479 * report.cs (Message): Removed.
480 (Report.MessageData, ErrorData, WarningData): Removed.
481 (Report.Error, Warning): Back to the old system.
483 2004-08-23 Martin Baulig <martin@ximian.com>
485 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
487 * class.cs (TypeContainer.ParentContainer): New public virtual
488 method; replaces the explicit interface implementation.
489 (ClassPart.ParentContainer): Override.
491 2004-08-23 Martin Baulig <martin@ximian.com>
493 * statement.cs (Switch): Added support for constant switches; see
494 #59428 or test-285.cs.
496 2004-08-22 Marek Safar <marek.safar@seznam.cz>
499 * statement.cs (GetEnumeratorFilter): Removed useless
500 logic because C# specs is strict. GetEnumerator must be
503 2004-08-22 Martin Baulig <martin@ximian.com>
505 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
506 a switch and may break, reset the barrier. Fixes #59867.
508 2004-08-22 Marek Safar <marek.safar@seznam.cz>
510 CLS-Compliance speed up (~5% for corlib)
512 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
513 New method. Tests container for CLS-Compliant names
515 * class.cs (TypeContainer.VerifyClsName): New method.
516 Checks whether container name is CLS Compliant.
517 (Constructor): Implements IMethodData.
519 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
520 low-case table for CLS Compliance test.
521 (MemberCache.VerifyClsParameterConflict): New method.
522 Checks method parameters for CS3006 error.
524 * enum.cs (EnumMember): Is derived from MemberCore.
525 (Enum.VerifyClsName): Optimized for better performance.
527 2004-08-06 Marek Safar <marek.safar@seznam.cz>
529 * report.cs: Renamed Error_T to Error and changed all
532 2004-08-06 Marek Safar <marek.safar@seznam.cz>
534 * class.cs (TypeContainer.IndexerArrayList): New inner class
535 container for indexers.
536 (TypeContainer.DefaultIndexerName): New constant for default
537 indexer name. Replaced all "Item" with this constant.
538 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
540 * typemanager.cs (TypeManager.default_member_ctor): Cache here
541 DefaultMemberAttribute constructor.
543 2004-08-05 Martin Baulig <martin@ximian.com>
545 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
548 2004-08-05 Marek Safar <marek.safar@seznam.cz>
550 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
551 multi platforms problem.
553 * compiler.csproj: Included shared files.
555 2004-08-04 Marek Safar <marek.safar@seznam.cz>
557 Fix bug 60333, 55971 in the more general way
558 * attribute.cs (Attribute.GetAttributeArgumentExpression):
559 Added arg_type argument for constant conversion.
560 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
562 2004-08-04 Marek Safar <marek.safar@seznam.cz>
565 * class.cs (TypeContainer ): New inner classes MethodArrayList,
566 OperatorArrayList, MethodCoreArrayList for typecontainer
567 containers. Changed class member types to these new types.
568 (MethodArrayList.DefineMembers): Added test for CS0659.
570 2004-08-04 Miguel de Icaza <miguel@ximian.com>
572 * cfold.cs: Synchronize the folding with the code in expression.cs
573 Binary.DoNumericPromotions for uint operands.
575 * attribute.cs: Revert patch from Raja, it introduced a regression
576 while building Blam-1.2.1 (hard to isolate a test case).
578 2004-08-04 Marek Safar <marek.safar@seznam.cz>
582 (TypeContainer.Define): Renamed to DefineContainerMembers because of
584 (MethodCore.parent_method): New member. The method we're overriding
585 if this is an override method.
586 (MethodCore.CheckBase): Moved from Method class and made common.
587 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
589 (MethodCore.CheckForDuplications): New abstract method. For custom
590 member duplication search in a container
591 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
592 method and its return type.
593 (Event.conflict_symbol): New member. Symbol with same name in the
597 (MemberCache.FindMemberWithSameName): New method. The method
598 is looking for conflict with inherited symbols.
600 2004-08-04 Martin Baulig <martin@ximian.com>
602 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
604 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
606 2004-08-03 Marek Safar <marek.safar@seznam.cz>
608 * report.cs (Message): New enum for better error, warning reference in
610 (MessageData): New inner abstract class. It generally handles printing of
611 error and warning messages.
612 Removed unused Error, Warning, Message methods.
614 2004-08-03 Marek Safar <marek.safar@seznam.cz>
616 Fix for cs0592-8.cs test
618 (Attributable.ValidAttributeTargets): Made public.
619 (Attribute.ExplicitTarget): New member for explicit target value.
620 (Attribute.CheckTargets): Now we translate explicit attribute
621 target to Target here.
623 2004-08-03 Ben Maurer <bmaurer@ximian.com>
625 * ecore.cs (MethodGroupExpr): new IsBase property.
627 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
629 * delegate.cs (DelegateCreation): store a MethodGroupExpr
630 rather than an instance expr.
632 (DelegateCreation.Emit): Use the method group rather than
633 the instance expression. Also, if you have base.Foo as the
634 method for a delegate, make sure to emit ldftn, not ldftnvirt.
636 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
638 (NewDelegate.DoResolve): Only check for the existance of Invoke
639 if the method is going to be needed. Use MethodGroupExpr.
641 (NewDelegate.Emit): Remove, DelegateCreation implements this.
643 * expression.cs: For pointer arith., make sure to use
644 the size of the type, not the size of the pointer to
647 2004-08-03 Marek Safar <marek.safar@seznam.cz>
650 * class.cs (Class): Added error CS0502 test.
652 2004-08-03 John Luke <jluke@cfl.rr.com>
653 Raja R Harinath <rharinath@novell.com>
656 * attribute.cs (Attribute.complained_before): New flag.
657 (Attribute.ResolveType, Attribute.Resolve),
658 (Attribute.DefinePInvokeMethod): Set it.
659 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
661 2004-08-03 Martin Baulig <martin@ximian.com>
663 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
664 use a user-defined operator; we still need to do numeric
665 promotions in case one argument is a builtin type and the other
666 one has an implicit conversion to that type. Fixes #62322.
668 2004-08-02 Martin Baulig <martin@ximian.com>
670 * statement.cs (LocalInfo.Flags): Added `IsThis'.
671 (LocalInfo.IsThis): New public property.
672 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
674 2004-08-01 Martin Baulig <martin@ximian.com>
676 * class.cs (TypeContainer.GetClassBases): Don't set the default
677 here since we may get called from GetPartialBases().
678 (TypeContainer.DefineType): If GetClassBases() didn't return a
679 parent, use the default one.
681 2004-07-30 Duncan Mak <duncan@ximian.com>
683 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
685 2004-07-30 Martin Baulig <martin@ximian.com>
687 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
689 * class.cs (SourceMethod): New public class, derive from the
690 symbol writer's ISourceMethod.
691 (Method): Use the new symbol writer API.
693 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
694 as argument and use the new symbol writer.
697 (SourceFile): Implement the symbol writer's ISourceFile.
698 (Location.SymbolDocument): Removed.
699 (Location.SourceFile): New public property.
701 * symbolwriter.cs: Use the new symbol writer API.
703 2004-07-30 Raja R Harinath <rharinath@novell.com>
705 * Makefile (install-local): Remove. Functionality moved to
708 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
710 * Makefile: Install mcs.exe.config file together with mcs.exe.
711 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
712 correct runtime version.
714 2004-07-25 Martin Baulig <martin@ximian.com>
717 (TypeContainer.RegisterOrder): Removed, this was unused.
718 (TypeContainer, interface_order): Removed.
719 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
720 TypeContainer as argument since we can also be called with a
721 `PartialContainer' for a partial class/struct/interface.
722 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
723 of checking whether we're an `Interface' - we could be a
725 (PartialContainer.Register): Override; call
726 AddClass()/AddStruct()/AddInterface() on our parent.
728 * cs-parser.jay (interface_member_declaration): Add things to the
729 `current_container', not the `current_class'.
731 * rootcontext.cs (RegisterOrder): The overloaded version which
732 takes an `Interface' was unused, removed.
734 * typemanager.cs (TypeManager.LookupInterface): Return a
735 `TypeContainer', not an `Interface'.
736 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
737 contain a `PartialContainer' for an interface, so check it's
738 `Kind' to figure out what it is.
740 2004-07-25 Martin Baulig <martin@ximian.com>
742 * class.cs (Class.DefaultTypeAttributes): New public constant.
743 (Struct.DefaultTypeAttributes): Likewise.
744 (Interface.DefaultTypeAttributes): Likewise.
745 (PartialContainer.TypeAttr): Override this and add the
746 DefaultTypeAttributes.
748 2004-07-25 Martin Baulig <martin@ximian.com>
750 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
751 we can just use the `Parent' field instead.
753 2004-07-25 Martin Baulig <martin@ximian.com>
755 * class.cs (TypeContainer.Emit): Renamed to EmitType().
757 2004-07-25 Martin Baulig <martin@ximian.com>
759 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
760 our parts before defining any methods.
761 (TypeContainer.VerifyImplements): Make this virtual.
762 (ClassPart.VerifyImplements): Override and call VerifyImplements()
763 on our PartialContainer.
765 2004-07-25 Martin Baulig <martin@ximian.com>
767 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
769 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
770 argument, we can just use the `Parent' field instead.
773 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
774 (MemberBase.DoDefine): Likewise.
776 2004-07-24 Martin Baulig <martin@ximian.com>
778 * decl.cs (MemberCore.Parent): New public field.
779 (DeclSpace.Parent): Moved to MemberCore.
781 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
782 (MemberBase.ctor): Added TypeContainer argument, pass it to our
784 (FieldBase, Field, Operator): Likewise.
785 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
786 (EventField, Event): Likewise.
788 2004-07-23 Martin Baulig <martin@ximian.com>
790 * class.cs (PartialContainer): New public class.
791 (ClassPart): New public class.
792 (TypeContainer): Added support for partial classes.
793 (TypeContainer.GetClassBases): Splitted some of the functionality
794 out into GetNormalBases() and GetPartialBases().
796 * cs-tokenizer.cs (Token.PARTIAL): New token.
797 (Tokenizer.consume_identifier): Added some hacks to recognize
798 `partial', but only if it's immediately followed by `class',
799 `struct' or `interface'.
801 * cs-parser.jay: Added support for partial clases.
803 2004-07-23 Martin Baulig <martin@ximian.com>
805 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
806 a `DeclSpace' and also made it readonly.
807 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
808 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
809 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
811 * cs-parser.jay: Pass the `current_class', not the
812 `current_container' (at the moment, this is still the same thing)
813 to a new Method, Property, Event, Indexer or Constructor.
815 2004-07-23 Martin Baulig <martin@ximian.com>
817 * cs-parser.jay (CSharpParser): Added a new `current_class' field
818 and removed the `current_interface' one.
819 (struct_declaration, class_declaration, interface_declaration):
820 Set `current_class' to the newly created class/struct/interface;
821 set their `Bases' and call Register() before parsing their body.
823 2004-07-23 Martin Baulig <martin@ximian.com>
825 * class.cs (Kind): New public enum.
826 (TypeContainer): Made this class abstract.
827 (TypeContainer.Kind): New public readonly field.
828 (TypeContainer.CheckDef): New public method; moved here from
830 (TypeContainer.Register): New public abstract method.
831 (TypeContainer.GetPendingImplementations): New public abstract
833 (TypeContainer.GetClassBases): Removed the `is_class' and
834 `is_iface' parameters.
835 (TypeContainer.DefineNestedTypes): Formerly known as
837 (ClassOrStruct): Made this class abstract.
839 * tree.cs (RootTypes): New public type.
841 2004-07-20 Martin Baulig <martin@ximian.com>
843 * tree.cs (Tree.RecordNamespace): Removed.
844 (Tree.Namespaces): Removed.
846 * rootcontext.cs (RootContext.IsNamespace): Removed.
848 * cs-parser.jay (namespace_declaration): Just create a new
851 2004-07-20 Martin Baulig <martin@ximian.com>
853 * statement.cs (ExceptionStatement): New abstract class. This is
854 now used as a base class for everyone who's using `finally'.
855 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
856 our local variables before using them.
858 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
859 virtual method. This is used by Yield.Resolve() to "steal" an
860 outer block's `finally' clauses.
861 (FlowBranchingException): The .ctor now takes an ExceptionStatement
864 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
865 version which takes an ExceptionStatement. This version must be
866 used to create exception branchings.
869 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
870 (Iterator.EmitMoveNext): Added exception support; protect the
871 block with a `fault' clause, properly handle 'finally' clauses.
872 (Iterator.EmitDispose): Run all the `finally' clauses here.
874 2004-07-20 Martin Baulig <martin@ximian.com>
876 * iterator.cs: This is the first of a set of changes in the
877 iterator code. Match the spec more closely: if we're an
878 IEnumerable, then GetEnumerator() must be called. The first time
879 GetEnumerator() is called, it returns the current instance; all
880 subsequent invocations (if any) must create a copy.
882 2004-07-19 Miguel de Icaza <miguel@ximian.com>
884 * expression.cs: Resolve the constant expression before returning
887 2004-07-19 Martin Baulig <martin@ximian.com>
889 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
890 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
891 the return type of the new EmitContext.
893 2004-07-18 Martin Baulig <martin@ximian.com>
895 * class.cs (Property.Define): Fix iterators.
897 * iterators.cs (Iterator.Define): Moved the
898 `container.AddInterator (this)' call here from the .ctor; only do
899 it if we resolved successfully.
901 2004-07-17 Miguel de Icaza <miguel@ximian.com>
903 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
904 `true' for preprocessing directives that we parse. The return
905 value indicates whether we should return to regular tokenizing or
906 not, not whether it was parsed successfully.
908 In the past if we were in: #if false ... #line #endif, we would
909 resume parsing after `#line'. See bug 61604.
911 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
912 building: IsEnumType should return true only for enums, not for
913 enums or System.Enum itself. This fixes #61593.
915 Likely what happened is that corlib was wrong: mcs depended on
916 this bug in some places. The bug got fixed, we had to add the
917 hack, which caused bug 61593.
919 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
920 that was a workaround for the older conditions.
922 2004-07-16 Ben Maurer <bmaurer@ximian.com>
924 * assign.cs: IAssignMethod has a new interface, as documented
925 inline. All assignment code now uses this new api.
927 * ecore.cs, expression.cs: All classes which implement
928 IAssignMethod now use the new interface.
930 * expression.cs (Invocation): add a hack to EmitCall so that
931 IndexerAccess can be the target of a compound assignment without
932 evaluating its arguments twice.
934 * statement.cs: Handle changes in Invocation api.
936 2004-07-16 Martin Baulig <martin@ximian.com>
938 * iterators.cs: Rewrote this. We're now using one single Proxy
939 class for both the IEnumerable and the IEnumerator interface and
940 `Iterator' derives from Class so we can use the high-level API.
942 * class.cs (TypeContainer.AddIterator): New method.
943 (TypeContainer.DoDefineType): New protected virtual method, which
944 is called from DefineType().
945 (TypeContainer.DoDefineMembers): Call DefineType() and
946 DefineMembers() on all our iterators.
947 (TypeContainer.Emit): Call Emit() on all our iterators.
948 (TypeContainer.CloseType): Call CloseType() on all our iterators.
950 * codegen.cs (EmitContext.CurrentIterator): New public field.
952 2004-07-15 Martin Baulig <martin@ximian.com>
955 (TypeManager.not_supported_exception_type): New type.
957 2004-07-14 Martin Baulig <martin@ximian.com>
959 * iterators.cs: Use real error numbers.
961 2004-07-14 Martin Baulig <martin@ximian.com>
963 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
964 requires this to be a System.Collection.IEnumerable and not a
965 class implementing that interface.
966 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
968 2004-07-13 Marek Safar <marek.safar@seznam.cz>
970 * class.cs: Fixed previous fix, it broke some error tests.
972 2004-07-12 Martin Baulig <martin@ximian.com>
974 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
977 2004-07-09 Miguel de Icaza <miguel@ximian.com>
979 * assign.cs (LocalTemporary): Add new argument: is_address,If
980 `is_address' is true, then the value that we store is the address
981 to the real value, and not the value itself.
983 * ecore.cs (PropertyExpr): use the new local temporary
984 stuff to allow us to handle X.Y += z (where X is a struct)
986 2004-07-08 Martin Baulig <martin@ximian.com>
988 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
989 not always return, just like we're doing in Using.Resolve().
991 2004-07-07 Miguel de Icaza <miguel@ximian.com>
993 * cs-parser.jay (fixed_statement): flag this as Pinned.
995 2004-07-06 Miguel de Icaza <miguel@ximian.com>
997 * typemanager.cs (TypeManager): Removed MakePinned method, this
998 mechanism is replaced with the .NET 2.x compatible mechanism of
999 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
1001 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
1002 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
1003 `IsFixed' property which has a different meaning.
1005 2004-07-02 Raja R Harinath <rharinath@novell.com>
1007 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
1008 visible from inside a nested class, not just the names of the
1009 immediately enclosing class.
1012 2004-06-24 Raja R Harinath <rharinath@novell.com>
1014 * expression.cs (BetterConversion): Remove buggy special-case
1015 handling of "implicit constant expression conversions". At this
1016 point, we already know that the conversion is possible -- we're
1017 only checking to see which is better.
1019 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1021 * cs-parser.jay: Added error CS0210 test.
1023 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1025 * cs-parser.jay: Added error CS0134 test.
1027 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1030 * cs-parser.jay: Added error CS0145 test.
1032 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1034 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
1036 2004-06-23 Ben Maurer <bmaurer@ximian.com>
1038 * expression.cs (StackAlloc.Resolve): The argument may not
1039 be a constant; deal with this case.
1041 2004-06-23 Marek Safar <marek.safar@seznam.cz>
1043 * attribute.cs (IndexerName_GetIndexerName): Renamed to
1044 GetIndexerAttributeValue.
1045 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
1047 * class.cs (Indexer.Define): Added error tests for CS0415,
1050 2004-06-23 Miguel de Icaza <miguel@ximian.com>
1052 * attribute.cs (Attribute.Resolve): Keep field code in sync with
1055 2004-06-23 Martin Baulig <martin@ximian.com>
1057 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
1058 neither return nor throw, reset the barrier as well. Fixes #60457.
1060 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
1062 * class.cs : EventAttributes is now set to None by default.
1063 This fixes bug #60459.
1065 2004-06-18 Marek Safar <marek.safar@seznam.cz>
1068 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
1069 Don't throw exception but return null (it's sufficient now).
1071 2004-06-18 Marek Safar <marek.safar@seznam.cz>
1073 * typemanager.cs (GetArgumentTypes): Faster implementation.
1075 2004-06-18 Martin Baulig <martin@ximian.com>
1077 * attribute.cs (Attribute.Resolve): Check whether we're an
1078 EmptyCast which a Constant child. Fixes #60333.
1080 2004-06-17 Ben Maurer <bmaurer@ximian.com>
1082 * statement.cs (EmitCollectionForeach): Account for the fact that
1083 not all valuetypes are in areas which we can take the address of.
1084 For these variables, we store to a temporary variable. Also, make
1085 sure that we dont emit a `callvirt' on a valuetype method.
1087 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1089 * expression.cs (StackAlloc.DoReSolve): Added test for
1090 negative parameter (CS0247).
1092 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1095 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
1097 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1100 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
1103 2004-06-14 Marek Safar <marek.safar@seznam.cz>
1105 Fix bug #58254 & cs1555.cs, cs1556.cs
1106 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
1108 2004-06-14 Marek Safar <marek.safar@seznam.cz>
1110 * cs-parser.jay: Added error CS1669 test for indexers.
1112 2004-06-11 Martin Baulig <martin@ximian.com>
1114 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
1115 call this twice: for params and varargs methods.
1117 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1120 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
1122 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1124 * attribute.cs (Attribute.GetValidTargets): Made public.
1127 (AbstractPropertyEventMethod): New class for better code sharing.
1128 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
1130 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
1132 2004-06-11 Raja R Harinath <rharinath@novell.com>
1135 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
1136 that the call to Resolve is part of a MemberAccess.
1137 (Expression.Resolve): Use it for SimpleName resolution.
1138 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
1139 Add 'intermediate' boolean argument.
1140 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
1141 error message when the SimpleName can be resolved ambiguously
1142 between an expression and a type.
1143 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
1145 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
1146 call on the left-side.
1148 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1151 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
1153 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1155 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
1157 2004-06-11 Martin Baulig <martin@ximian.com>
1159 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
1160 varargs methods if applicable.
1162 2004-06-11 Martin Baulig <martin@ximian.com>
1164 * expression.cs (Invocation.EmitCall): Don't use
1165 `method.CallingConvention == CallingConventions.VarArgs' since the
1166 method could also have `CallingConventions.HasThis'.
1168 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1170 * class.cs (Event.GetSignatureForError): Implemented.
1171 Fixed crash in error test cs3010.cs
1173 2004-06-10 Miguel de Icaza <miguel@ximian.com>
1175 * cs-tokenizer.cs: Change the way we track __arglist to be
1176 consistent with the other keywords.
1178 2004-06-09 Miguel de Icaza <miguel@ximian.com>
1180 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
1183 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
1185 * codegen.cs: Check that all referenced assemblies have a strongname
1186 before strongnaming the compiled assembly. If not report error CS1577.
1187 Fix bug #56563. Patch by Jackson Harper.
1188 * typemanager.cs: Added a method to return all referenced assemblies.
1189 Fix bug #56563. Patch by Jackson Harper.
1191 2004-06-08 Marek Safar <marek.safar@seznam.cz>
1194 (Method.ApplyAttributeBuilder): Moved and added conditional
1195 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
1198 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
1200 2004-06-08 Marek Safar <marek.safar@seznam.cz>
1203 * class.cs: (EventField.attribute_targets): Changed default target.
1205 2004-06-08 Martin Baulig <martin@ximian.com>
1207 * expression.cs (Invocation.EmitCall): Enable varargs methods.
1209 2004-06-08 Martin Baulig <martin@ximian.com>
1211 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
1213 2004-06-07 Martin Baulig <martin@ximian.com>
1215 Added support for varargs methods.
1217 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
1220 * cs-parser.jay: Added support for `__arglist'.
1222 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
1224 * expression.cs (Argument.AType): Added `ArgList'.
1225 (Invocation): Added support for varargs methods.
1226 (ArglistAccess): New public class.
1227 (Arglist): New public class.
1229 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
1231 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
1232 a method's top-level block if the method has varargs.
1234 * support.cs (ReflectionParameters, InternalParameters): Added
1235 support for varargs methods.
1237 2004-06-07 Miguel de Icaza <miguel@ximian.com>
1239 * class.cs: Provide location in indexer error report.
1241 * driver.cs: Use standard names.
1243 * namespace.cs: Catch the use of using after a namespace has been
1244 declared also on using aliases.
1246 2004-06-03 Raja R Harinath <rharinath@novell.com>
1249 * typemanager.cs (closure_private_ok, closure_invocation_type)
1250 (closure_qualifier_type, closure_invocation_assembly)
1251 (FilterWithClosure): Move to ...
1252 (Closure): New internal nested class.
1253 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
1254 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
1255 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
1256 (MemberLookup, MemberLookupFailed): Use it.
1257 * expression.cs (New.DoResolve): Treat the lookup for the
1258 constructor as being qualified by the 'new'ed type.
1259 (Indexers.GetIndexersForTypeOrInterface): Update.
1261 2004-06-03 Marek Safar <marek.safar@seznam.cz>
1264 (GetConditionalAttributeValue): New method. Returns
1265 condition of ConditionalAttribute.
1266 (SearchMulti): New method. Returns all attributes of type 't'.
1267 Use it when attribute is AllowMultiple = true.
1268 (IsConditionalMethodExcluded): New method.
1271 (Method.IsExcluded): Implemented. Returns true if method has conditional
1272 attribute and the conditions is not defined (method is excluded).
1273 (IMethodData): Extended interface for ConditionalAttribute support.
1274 (PropertyMethod.IsExcluded): Implemented.
1277 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
1280 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
1283 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
1285 * expression.cs (ArrayCreationExpression): Make this just an
1286 `expression'. It can't be a statement, so the code here was
1289 2004-06-02 Marek Safar <marek.safar@seznam.cz>
1292 * typemanager.cs (GetFullNameSignature): New method for
1295 2004-06-02 Marek Safar <marek.safar@seznam.cz>
1298 * class.cs (MemberBase.GetSignatureForError): New virtual method.
1299 Use this method when MethodBuilder is null.
1300 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
1301 Added test for error CS0626 (MONO reports error for this situation).
1302 (IMethodData.GetSignatureForError): Extended interface.
1304 2004-06-01 Marek Safar <marek.safar@seznam.cz>
1307 (AttributeTester.GetObsoleteAttribute): Returns instance of
1308 ObsoleteAttribute when type is obsolete.
1311 (TypeContainer.VerifyObsoleteAttribute): Override.
1312 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
1313 (MethodCode.VerifyObsoleteAttribute): Override.
1314 (MemberBase.VerifyObsoleteAttribute): Override.
1317 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
1318 and report proper error.
1321 Delegate.VerifyObsoleteAttribute): Override.
1324 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
1325 and report proper error.
1326 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
1329 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
1333 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
1334 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
1335 Added test for ObsoleteAttribute.
1338 (Catch): Derived from Statement.
1340 2004-06-01 Marek Safar <marek.safar@seznam.cz>
1342 Fixed bug #59071 & cs0160.cs
1344 * statement.cs (Try.Resolve): Check here whether order of catch
1345 clauses matches their dependencies.
1347 2004-05-31 Miguel de Icaza <miguel@ximian.com>
1349 * Reverted patch to namespace.cs (Use lookuptypedirect). This
1350 caused a regression: #59343. Referencing nested classes from an
1351 assembly stopped working.
1353 2004-05-31 Martin Baulig <martin@ximian.com>
1355 MCS is now frozen for beta 2.
1357 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1359 * convert.cs: add a trivial cache for overload operator resolution.
1361 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1363 * decl.cs: If possible, use lookuptypedirect here. We can only do
1364 this if there is no `.' after the namespace. Avoids using
1365 LookupType, which does lots of slow processing.
1366 (FindNestedType) New method, does what it says :-).
1367 * namespace.cs: use LookupTypeDirect.
1368 * rootcontext.cs: use membercache, if possible.
1369 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
1371 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1374 According to the spec,
1376 In a member access of the form E.I, if E is a single identifier,
1377 and if the meaning of E as a simple-name (§7.5.2) is a constant,
1378 field, property, localvariable, or parameter with the same type as
1379 the meaning of E as a type-name (§3.8), then both possible
1380 meanings of E are permitted.
1382 We did not check that E as a simple-name had the same type as E as
1385 This trivial check gives us 5-7% on bootstrap time.
1387 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1389 * expression.cs (Invocation.OverloadResolve): Avoid the
1390 use of hashtables and boxing here by allocating on demand.
1392 2004-05-30 Martin Baulig <martin@ximian.com>
1394 * rootcontext.cs (RootContext.LookupType): Don't cache things if
1395 we're doing a silent lookup. Don't try to lookup nested types in
1396 TypeManager.object_type (thanks to Ben Maurer).
1398 2004-05-30 Martin Baulig <martin@ximian.com>
1400 Committing a patch from Ben Maurer.
1402 * rootcontext.cs (RootContext.LookupType): Cache negative results.
1404 2004-05-29 Martin Baulig <martin@ximian.com>
1406 * class.cs (IMethodData.ShouldIgnore): New method.
1408 * typemanager.cs (TypeManager.MethodFlags): Don't take a
1409 `Location' argument, we don't need it anywhere. Use
1410 `IMethodData.ShouldIgnore ()' instead of
1411 `MethodData.GetMethodFlags ()'.
1412 (TypeManager.AddMethod): Removed.
1413 (TypeManager.AddMethod2): Renamed to AddMethod.
1415 2004-05-29 Martin Baulig <martin@ximian.com>
1417 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
1419 * convert.cs (Convert.ImplicitReferenceConversion): If we're
1420 converting from a class type S to an interface type and we already
1421 have an object on the stack, don't box it again. Fixes #52578.
1423 2004-05-29 Martin Baulig <martin@ximian.com>
1425 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
1426 Added support for `params' parameters. Fixes #59267.
1428 2004-05-29 Martin Baulig <martin@ximian.com>
1430 * literal.cs (NullPointer): Provide a private .ctor which sets
1431 `type' to TypeManager.object_type. Fixes #59048.
1433 2004-05-29 Martin Baulig <martin@ximian.com>
1435 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
1436 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
1438 * ecore.cs (EventExpr.instance_expr): Make the field private.
1440 2004-05-26 Marek Safar <marek.safar@seznam.cz>
1442 Fixed bug #50080 & cs0214-2.cs
1443 * expression.cs (Cast.DoResolve): Check unsafe context here.
1445 * statement.cs (Resolve.DoResolve): Likewise.
1447 2004-05-26 Martin Baulig <martin@ximian.com>
1449 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
1451 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
1452 (RootContext.LookupType): Pass down the `silent' flag.
1454 2004-05-25 Martin Baulig <martin@ximian.com>
1457 (MethodGroupExpr.IdenticalTypeName): New public property.
1458 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
1459 expression actually refers to a type.
1461 2004-05-25 Martin Baulig <martin@ximian.com>
1463 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
1464 for #56176 and made it actually work.
1466 2004-05-25 Martin Baulig <martin@ximian.com>
1468 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
1469 (FieldExpr, PropertyExpr): Override and implement
1470 CacheTemporaries. Fixes #52279.
1472 2004-05-25 Miguel de Icaza <miguel@ximian.com>
1474 * location.cs: In the new compiler listing a file twice is a
1475 warning, not an error.
1477 2004-05-24 Martin Baulig <martin@ximian.com>
1479 * enum.cs (Enum.DefineType): For the `BaseType' to be a
1480 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
1482 2004-05-24 Martin Baulig <martin@ximian.com>
1484 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
1485 walking the `using' list. Fixes #53921.
1487 2004-05-24 Martin Baulig <martin@ximian.com>
1489 * const.cs (Const.LookupConstantValue): Added support for
1490 EmptyCast's; fixes #55251.
1492 2004-05-24 Martin Baulig <martin@ximian.com>
1494 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
1495 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
1496 which does the CS0135 check. The reason is that we first need to
1497 check whether the variable actually exists.
1499 2004-05-24 Martin Baulig <martin@ximian.com>
1501 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
1502 than RootContext.LookupType() to find the explicit interface
1505 2004-05-24 Raja R Harinath <rharinath@novell.com>
1507 * Makefile: Simplify. Use executable.make.
1508 * mcs.exe.sources: New file. List of sources of mcs.exe.
1510 2004-05-24 Anders Carlsson <andersca@gnome.org>
1514 Use the invariant culture when doing String.Compare for CLS case
1517 2004-05-23 Martin Baulig <martin@ximian.com>
1519 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
1520 don't have any dots. Fixes #52622, added cs0246-8.cs.
1522 * namespace.cs (NamespaceEntry.Lookup): Likewise.
1524 2004-05-23 Marek Safar <marek.safar@seznam.cz>
1526 * class.cs (MemberBase.Define): Reuse MemberType member for
1527 resolved type. Other methods can use it too.
1529 2004-05-23 Martin Baulig <martin@ximian.com>
1531 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
1532 the variable also exists in the current block (otherwise, we need
1533 to report a CS0103). Fixes #58670.
1535 2004-05-23 Martin Baulig <martin@ximian.com>
1537 * flowanalysis.cs (Reachability.Reachable): Compute this
1538 on-the-fly rather than storing it as a field.
1540 2004-05-23 Martin Baulig <martin@ximian.com>
1542 * flowanalysis.cs (Reachability.And): Manually compute the
1543 resulting `barrier' from the reachability.
1545 2004-05-23 Marek Safar <marek.safar@seznam.cz>
1548 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
1549 instance of ObsoleteAttribute when symbol is obsolete.
1552 (IMethodData): Extended interface for ObsoleteAttribute support.
1554 2004-05-22 Marek Safar <marek.safar@seznam.cz>
1556 * attribute.cs: Fix bug #55970
1558 2004-05-22 Marek Safar <marek.safar@seznam.cz>
1562 (GetObsoleteAttribute): New method. Creates the instance of
1564 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
1565 ObsoleteAttribute when member is obsolete.
1566 (AttributeTester.Report_ObsoleteMessage): Common method for
1567 Obsolete error/warning reporting.
1570 (TypeContainer.base_classs_type): New member for storing parent type.
1573 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
1574 for this MemberCore.
1576 2004-05-21 Marek Safar <marek.safar@seznam.cz>
1578 * attribute.cs, const.cs: Fix bug #58590
1580 2004-05-21 Martin Baulig <martin@ximian.com>
1582 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
1583 out parameters if the end of the method is unreachable. Fixes
1586 2004-05-21 Marek Safar <marek.safar@seznam.cz>
1588 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
1589 Hari was right, why extra method.
1591 2004-05-21 Marek Safar <marek.safar@seznam.cz>
1593 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
1595 2004-05-20 Martin Baulig <martin@ximian.com>
1597 Merged this back from gmcs to keep the differences to a minumum.
1599 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
1600 instead of a Declspace.
1601 (Attribute.ResolveType): Likewise.
1602 (Attributes.Search): Likewise.
1603 (Attributes.Contains): Likewise.
1604 (Attributes.GetClsCompliantAttribute): Likewise.
1606 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
1608 (MethodData.ApplyAttributes): Take an EmitContext instead of a
1611 2004-05-19 Marek Safar <marek.safar@seznam.cz>
1613 Fix bug #58688 (MCS does not report error when the same attribute
1616 * attribute.cs (Attribute.Emit): Distinction between null and default.
1618 2004-05-19 Raja R Harinath <rharinath@novell.com>
1620 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
1621 of a top-level attribute without an attribute target.
1622 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
1624 (Attribute.Conditional_GetConditionName),
1625 (Attribute.Obsolete_GetObsoleteMessage): Update.
1626 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
1627 part of ScanForIndexerName.
1628 (Attribute.CanIgnoreInvalidAttribute): New function.
1629 (Attribute.ScanForIndexerName): Move to ...
1630 (Attributes.ScanForIndexerName): ... here.
1631 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
1632 (Attributes.Search): New internal variant that can choose not to
1633 complain if types aren't resolved. The original signature now
1635 (Attributes.GetClsCompliantAttribute): Use internal variant, with
1636 complaints suppressed.
1637 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
1638 only if it not useful.
1639 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
1640 top-level for attributes that are shared between the assembly
1641 and a top-level class.
1642 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
1643 * class.cs: Update to reflect changes.
1644 (DefineIndexers): Fuse loops.
1645 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
1646 a couple more variants of attribute names.
1648 2004-05-18 Marek Safar <marek.safar@seznam.cz>
1650 Fix bug #52585 (Implemented explicit attribute declaration)
1653 (Attributable.ValidAttributeTargets): New abstract method. It gets
1654 list of valid attribute targets for explicit target declaration.
1655 (Attribute.Target): It holds target itself.
1656 (AttributeSection): Removed.
1657 (Attribute.CheckTargets): New method. It checks whether attribute
1658 target is valid for the current element.
1661 (EventProperty): New class. For events that are declared like
1662 property (with add and remove accessors).
1663 (EventField): New class. For events that are declared like field.
1666 * cs-parser.jay: Implemented explicit attribute target declaration.
1668 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
1669 Override ValidAttributeTargets.
1672 (ReturnParameter): Class for applying custom attributes on
1674 (ParameterAtribute): New class. Class for applying custom
1675 attributes on the parameter type.
1677 2004-05-17 Miguel de Icaza <miguel@ximian.com>
1679 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
1682 (Method): Allow UNSAFE here.
1684 * modifiers.cs: Support unsafe reporting.
1686 2004-05-17 Marek Safar <marek.safar@seznam.cz>
1688 * decl.cs: Fix bug #58478.
1690 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1692 * statement.cs: When checking for unreachable code on an EmptyStatement,
1693 set the location. Fixes bug #58488.
1695 2004-05-13 Miguel de Icaza <miguel@ximian.com>
1697 * driver.cs: Add -pkg handling.
1699 From Gonzalo: UseShelLExecute=false
1701 2004-05-12 Marek Safar <marek.safar@seznam.cz>
1704 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
1706 (Attribute.IsClsCompliaceRequired): Moved to base for better
1708 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
1709 when attribute is AttributeUsageAttribute.
1710 (Attribute.GetValidTargets): Simplified.
1711 (Attribute.GetAttributeUsage): New method returns AttributeUsage
1712 attribute for this type.
1713 (Attribute.ApplyAttributes): Method renamed to Emit and make
1715 (GlobalAttributeSection): New class for special handling of global
1716 attributes (assembly, module).
1717 (AttributeSection.Emit): New method.
1719 * class.cs: Implemented Attributable abstract methods.
1720 (MethodCore.LabelParameters): Moved to Parameter class.
1721 (Accessor): Is back simple class.
1722 (PropertyMethod): Implemented Attributable abstract class.
1723 (DelegateMethod): Implemented Attributable abstract class.
1724 (Event): New constructor for disctintion between normal Event
1725 and Event with accessors.
1727 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
1729 * codegen.cs, const.cs, decl.cs, delegate.cs:
1730 (CommonAssemblyModulClass): Implemented Attributable abstract class
1733 * enum.cs: Implement IAttributeSupport interface.
1734 (EnumMember): New class for emum members. Implemented Attributable
1738 (ParameterBase): Is abstract.
1739 (ReturnParameter): New class for easier [return:] attribute handling.
1741 * typemanager.cs: Removed builder_to_attr.
1743 2004-05-11 Raja R Harinath <rharinath@novell.com>
1746 * attribute.cs (Attribute.GetPositionalValue): New function.
1747 * class.cs (TypeContainer.VerifyMembers): New function.
1748 (TypeContainer.Emit): Use it.
1749 (ClassOrStruct): New base class for Class and Struct.
1750 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
1751 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
1753 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
1754 then each non-static field should have a FieldOffset attribute.
1755 Otherwise, none of the fields should have a FieldOffset attribute.
1756 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
1757 and FieldOffset attributes.
1758 * typemanager.cs (TypeManager.struct_layout_attribute_type)
1759 (TypeManager.field_offset_attribute_type): New core types.
1760 (TypeManager.InitCoreTypes): Initialize them.
1762 2004-05-11 Michal Moskal <malekith@pld-linux.org>
1764 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
1765 Return correct type.
1768 2004-05-09 Miguel de Icaza <miguel@ximian.com>
1770 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
1771 be implicitly converted to ulong.
1773 * expression.cs: The logic for allowing operator &, | and ^ worked
1774 was wrong, it worked before because we did not report an error in
1775 an else branch. Fixes 57895.
1777 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
1778 allow volatile fields to be reference types.
1780 2004-05-07 Miguel de Icaza <miguel@ximian.com>
1782 * driver.cs: Add support for /debug-
1784 2004-05-07 Raja R Harinath <rharinath@novell.com>
1786 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
1787 Add a 'complain' parameter to silence errors.
1788 (Attribute.Resolve): Update to changes. Put in sanity check to catch
1789 silently overlooked type-resolutions.
1790 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
1792 (Attributes.Search): New function.
1793 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
1794 (Attributes.GetAttributeFullName): Remove hack.
1795 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
1796 Update to reflect changes.
1797 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
1798 Use Attributes.Search instead of nested loops.
1800 2004-05-07 Marek Safar <marek.safar@seznam.cz>
1803 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
1804 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
1805 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
1807 * report.cs: (Report.Warning): Renamed to Warning_T because of
1808 parameter collision.
1810 2004-05-05 Raja R Harinath <rharinath@novell.com>
1812 * expression.cs (MemberAccess.ResolveMemberAccess):
1813 Exit with non-zero status after Report.Error.
1814 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
1816 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
1818 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
1820 * support.cs: Don't hang when the file is empty.
1822 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
1824 * support.cs: In SeekableStreamReader, compute the preamble size of the
1825 underlying stream. Position changes should take into account that initial
1828 2004-05-03 Todd Berman <tberman@sevenl.net>
1830 * driver.cs: remove unused GetSysVersion function.
1832 2004-05-03 Todd Berman <tberman@sevenl.net>
1834 * driver.cs: Remove the hack from saturday, as well as the hack
1835 from jackson (LoadAssemblyFromGac), also adds the CWD to the
1836 link_paths to get that bit proper.
1838 2004-05-01 Todd Berman <tberman@sevenl.net>
1840 * driver.cs: Try a LoadFrom before a Load, this checks the current
1841 path. This is currently a bug in mono that is be fixed, however, this
1842 provides a workaround for now. This will be removed when the bug
1845 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
1847 * CryptoConvert.cs: Updated to latest version. Fix issue with
1848 incomplete key pairs (#57941).
1850 2004-05-01 Todd Berman <tberman@sevenl.net>
1852 * driver.cs: Remove '.' from path_chars, now System.* loads properly
1855 2004-04-30 Jackson Harper <jackson@ximian.com>
1857 * codegen.cs: Open keys readonly.
1859 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1861 * typemanager.cs: don't report cyclic struct layout when a struct
1862 contains 2 or more fields of the same type. Failed for Pango.AttrShape
1863 which has 2 Pango.Rectangle fields.
1865 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
1867 * expression.cs: Handle IntPtr comparisons with IL code
1868 rather than a method call.
1870 2004-04-29 Martin Baulig <martin@ximian.com>
1872 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
1873 the list of PropertyInfo's in class hierarchy and find the
1874 accessor. Fixes #56013.
1876 2004-04-29 Martin Baulig <martin@ximian.com>
1878 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
1880 2004-04-29 Martin Baulig <martin@ximian.com>
1882 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
1884 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
1886 2004-04-29 Martin Baulig <martin@ximian.com>
1888 * class.cs (ConstructorInitializer.Resolve): Check whether the
1889 parent .ctor is accessible. Fixes #52146.
1891 2004-04-29 Martin Baulig <martin@ximian.com>
1893 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
1895 * statement.cs (Using.EmitLocalVariableDecls): Use
1896 TypeManager.idisposable_type, not typeof (IDisposable).
1897 (Foreach.EmitCollectionForeach): Added support for valuetypes.
1899 2004-04-29 Martin Baulig <martin@ximian.com>
1901 * class.cs (Event.Define): Don't emit the field and don't set
1902 RTSpecialName and SpecialName for events on interfaces. Fixes
1905 2004-04-29 Raja R Harinath <rharinath@novell.com>
1907 Refactor Attribute.ApplyAttributes.
1908 * attribute.cs (Attributable): New base class for objects that can
1909 have Attributes applied on them.
1910 (Attribute): Make AttributeUsage fields public.
1911 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
1912 (Attribute.IsInternalCall): New property.
1913 (Attribute.UsageAttr): Convert to a public read-only property.
1914 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
1915 (Attribute.ResolveType, Attribute.Resolve)
1916 (Attribute.ScanForIndexerName): Update to reflect changes.
1917 (Attribute.CheckAttributeTarget): Re-format.
1918 (Attribute.ApplyAttributes): Refactor, to various
1919 Attributable.ApplyAttributeBuilder methods.
1920 * decl.cs (MemberCore): Make Attributable.
1921 * class.cs (Accessor): Make Attributable.
1922 (MethodData.ApplyAttributes): Use proper attribute types, not
1924 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
1925 (TypeContainer.ApplyAttributeBuilder)
1926 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
1927 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
1928 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
1929 (Operator.ApplyAttributeBuilder): New factored-out methods.
1930 * const.cs (Const.ApplyAttributeBuilder): Likewise.
1931 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
1932 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
1933 * parameter.cs (ParameterBase): New Attributable base class
1934 that can also represent Return types.
1935 (Parameter): Update to the changes.
1937 2004-04-29 Jackson Harper <jackson@ximian.com>
1939 * driver.cs: Prefer the corlib system version when looking for
1940 assemblies in the GAC. This is still a hack, but its a better hack
1943 2004-04-29 Marek Safar <marek.safar@seznam.cz>
1945 * decl.cs, enum.cs: Improved error 3005 reporting.
1947 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
1948 (related_symbols): New private member for list of symbols
1949 related to reported error/warning.
1951 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
1953 2004-04-29 Martin Baulig <martin@ximian.com>
1955 * ecore.cs (Expression.Constantify): If we're an enum and
1956 TypeManager.TypeToCoreType() doesn't give us another type, use
1957 t.UnderlyingSystemType. Fixes #56178.
1959 2004-04-29 Martin Baulig <martin@ximian.com>
1961 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
1962 interfaces and for each interface, only add members directly
1963 declared in that interface. Fixes #53255.
1965 2004-04-28 Martin Baulig <martin@ximian.com>
1967 * expression.cs (ConditionalLogicalOperator): Use a temporary
1968 variable for `left' to avoid that we evaluate it more than once;
1971 2004-04-28 Martin Baulig <martin@ximian.com>
1973 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
1976 2004-04-28 Martin Baulig <martin@ximian.com>
1978 * statement.cs (LocalInfo.Resolve): Check whether the type is not
1981 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
1982 whether the type is not void (CS1547).
1984 2004-04-28 Martin Baulig <martin@ximian.com>
1986 * expression.cs (Unary.DoResolveLValue): Override this and report
1987 CS0131 for anything but Operator.Indirection.
1989 2004-04-28 Martin Baulig <martin@ximian.com>
1991 Committing a patch from Ben Maurer; see bug #50820.
1993 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
1996 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
1999 2004-04-28 Martin Baulig <martin@ximian.com>
2001 Committing a patch from Ben Maurer; see bug #50820.
2003 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
2006 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
2009 2004-04-28 Martin Baulig <martin@ximian.com>
2011 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
2012 (Block.AddLabel): Call DoLookupLabel() to only search in the
2015 2004-04-28 Martin Baulig <martin@ximian.com>
2017 * cfold.cs (ConstantFold.BinaryFold): Added special support for
2018 comparing StringConstants and NullLiterals in Equality and Inequality.
2020 2004-04-28 Jackson Harper <jackson@ximian.com>
2022 * driver.cs: Attempt to load referenced assemblies from the
2023 GAC. This is the quick and dirty version of this method that
2024 doesnt take into account versions and just takes the first
2025 canidate found. Will be good enough for now as we will not have more
2026 then one version installed into the GAC until I update this method.
2028 2004-04-28 Martin Baulig <martin@ximian.com>
2030 * typemanager.cs (TypeManager.CheckStructCycles): New public
2031 static method to check for cycles in the struct layout.
2033 * rootcontext.cs (RootContext.PopulateTypes): Call
2034 TypeManager.CheckStructCycles() for each TypeContainer.
2035 [Note: We only need to visit each type once.]
2037 2004-04-28 Martin Baulig <martin@ximian.com>
2039 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
2041 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
2042 success and added `out object value'. Use a `bool resolved' field
2043 to check whether we've already been called rather than
2044 `ConstantValue != null' since this breaks for NullLiterals.
2046 2004-04-28 Raja R Harinath <rharinath@novell.com>
2048 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
2049 setting of this flag, since the 'set' method may be non-public.
2051 2004-04-28 Raja R Harinath <rharinath@novell.com>
2053 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
2054 check on current_vector.Block.
2056 2004-04-27 Martin Baulig <martin@ximian.com>
2058 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
2059 a field initializer. Fixes #56459.
2061 2004-04-27 Martin Baulig <martin@ximian.com>
2063 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
2064 we're not attempting to use an indexer. Fixes #52154.
2066 2004-04-27 Martin Baulig <martin@ximian.com>
2068 * statement.cs (Return): Don't create a return label if we don't
2069 need it; reverts my change from January 20th. Thanks to Ben
2072 2004-04-27 Martin Baulig <martin@ximian.com>
2074 According to the spec, `goto' can only leave a nested scope, but
2077 * statement.cs (Block.LookupLabel): Only lookup in the current
2078 block, don't recurse into parent or child blocks.
2079 (Block.AddLabel): Check in parent and child blocks, report
2080 CS0140/CS0158 if we find a duplicate.
2081 (Block): Removed this indexer for label lookups.
2082 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
2083 this already does the error reporting for us.
2086 (FlowBranching.UsageVector.Block): New public variable; may be null.
2087 (FlowBranching.CreateSibling): Added `Block' argument.
2088 (FlowBranching.LookupLabel): New public virtual method. Lookup a
2089 label for the target of a `goto' and check whether we're not
2090 leaving a `finally'.
2092 2004-04-27 Martin Baulig <martin@ximian.com>
2094 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2095 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
2098 2004-04-27 Martin Baulig <martin@ximian.com>
2100 * statement.cs (Block.AddLabel): Also check for implicit blocks
2101 and added a CS0158 check.
2103 2004-04-27 Martin Baulig <martin@ximian.com>
2105 * flowanalysis.cs (FlowBranchingLoop): New class.
2106 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
2107 UsageVector's instead of an ArrayList.
2108 (FlowBranching.Label): Likewise.
2109 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
2110 (FlowBranching.AddBreakVector): New method.
2112 2004-04-27 Miguel de Icaza <miguel@ximian.com>
2114 * attribute.cs: Small regression fix: only convert the type if we
2115 the type is different, fixes System.Drawing build.
2117 2004-04-27 Martin Baulig <martin@ximian.com>
2119 * attribute.cs (Attribute.Resolve): If we have a constant value
2120 for a named field or property, implicity convert it to the correct
2123 2004-04-27 Raja R Harinath <rharinath@novell.com>
2125 * statement.cs (Block.Block): Implicit blocks share
2126 'child_variable_names' fields with parent blocks.
2127 (Block.AddChildVariableNames): Remove.
2128 (Block.AddVariable): Mark variable as "used by a child block" in
2129 every surrounding block.
2130 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
2131 been used in a child block, complain about violation of "Invariant
2132 meaning in blocks" rule.
2133 * cs-parser.jay (declare_local_variables): Don't use
2134 AddChildVariableNames.
2135 (foreach_statement): Don't create an implicit block: 'foreach'
2138 2004-04-23 Miguel de Icaza <miguel@ximian.com>
2140 * convert.cs (ImplicitNumericConversion): 0 is also positive when
2141 converting from 0L to ulong. Fixes 57522.
2143 2004-04-22 Marek Safar <marek.safar@seznam.cz>
2145 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
2146 derived class hides via 'new' keyword field from base class (test-242.cs).
2147 TODO: Handle this in the more general way.
2149 * class.cs (CheckBase): Ditto.
2151 2004-04-22 Marek Safar <marek.safar@seznam.cz>
2153 * decl.cs (caching_flags): New member for storing cached values
2155 (MemberCore.Flags): New enum where bit flags for caching_flags
2157 (MemberCore.cls_compliance): Moved to caching_flags.
2158 (DeclSpace.Created): Moved to caching_flags.
2160 * class.cs: Use caching_flags instead of DeclSpace.Created
2162 2004-04-21 Miguel de Icaza <miguel@ximian.com>
2164 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
2165 if we are only a derived class, not a nested class.
2167 * typemanager.cs: Same as above, but do this at the MemberLookup
2168 level (used by field and methods, properties are handled in
2169 PropertyExpr). Allow for the qualified access if we are a nested
2172 2004-04-21 Marek Safar <marek.safar@seznam.cz>
2174 * class.cs: Refactoring.
2175 (IMethodData): New inteface; Holds links to parent members
2176 to avoid member duplication (reduced memory allocation).
2177 (Method): Implemented IMethodData interface.
2178 (PropertyBase): New inner classes for get/set methods.
2179 (PropertyBase.PropertyMethod): Implemented IMethodData interface
2180 (Event): New inner classes for add/remove methods.
2181 (Event.DelegateMethod): Implemented IMethodData interface.
2183 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
2184 EmitContext (related to class.cs refactoring).
2186 2004-04-21 Raja R Harinath <rharinath@novell.com>
2188 * delegate.cs (Delegate.VerifyApplicability): If the number of
2189 arguments are the same as the number of parameters, first try to
2190 verify applicability ignoring any 'params' modifier on the last
2194 2004-04-16 Raja R Harinath <rharinath@novell.com>
2196 * class.cs (TypeContainer.AddIndexer): Use
2197 'ExplicitInterfaceName' to determine if interface name was
2198 explicitly specified. 'InterfaceType' is not initialized at this time.
2199 (TypeContainer.DefineIndexers): Remove use of temporary list. The
2200 Indexers array is already in the required order. Initialize
2201 'IndexerName' only if there are normal indexers.
2202 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
2203 (TypeContainer.Emit): Emit DefaultMember attribute only if
2204 IndexerName is initialized.
2207 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
2209 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
2212 2004-04-15 Raja R Harinath <rharinath@novell.com>
2214 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
2218 * attribute.cs (Attribute.Resolve): Check for duplicate named
2222 2004-04-15 Miguel de Icaza <miguel@ximian.com>
2224 * iterators.cs (MarkYield): track whether we are in an exception,
2225 and generate code accordingly. Use a temporary value to store the
2226 result for our state.
2228 I had ignored a bit the interaction of try/catch with iterators
2229 since their behavior was not entirely obvious, but now it is
2230 possible to verify that our behavior is the same as MS .NET 2.0
2234 2004-04-14 Miguel de Icaza <miguel@ximian.com>
2236 * iterators.cs: Avoid creating temporaries if there is no work to
2239 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
2240 Enumerations, use TypeManager.EnumToUnderlying and call
2243 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
2246 (This.Emit): Use EmitContext.EmitThis to emit our
2249 (This.EmitAssign): Ditto.
2251 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
2252 codepaths, we will move all the functionality into
2255 (FieldExpr.EmitAssign): Ditto.
2257 This fixes several hidden bugs that I uncovered while doing a code
2258 review of this today.
2260 * codegen.cs (EmitThis): reworked so the semantics are more clear
2261 and also support value types "this" instances.
2263 * iterators.cs: Changed so that for iterators in value types, we
2264 do not pass the value type as a parameter.
2266 Initialization of the enumerator helpers is now done in the caller
2267 instead of passing the parameters to the constructors and having
2268 the constructor set the fields.
2270 The fields have now `assembly' visibility instead of private.
2272 2004-04-11 Miguel de Icaza <miguel@ximian.com>
2274 * expression.cs (Argument.Resolve): Check if fields passed as ref
2275 or out are contained in a MarshalByRefObject.
2277 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
2278 another compiler type.
2280 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
2282 * class.cs (Indexer.Define): use the new name checking method.
2283 Also, return false on an error.
2284 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
2285 (is_identifier_[start/part]_character): make static.
2287 2004-04-10 Miguel de Icaza <miguel@ximian.com>
2289 * expression.cs (Binary.ResolveOperator): Do no append strings
2290 twice: since we can be invoked more than once (array evaluation)
2291 on the same concatenation, take care of this here. Based on a fix
2292 from Ben (bug #56454)
2294 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
2296 * codegen.cs: Fix another case where CS1548 must be reported (when
2297 delay-sign isn't specified and no private is available #56564). Fix
2298 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
2299 error when MCS is used on the MS runtime and we need to delay-sign
2300 (which seems unsupported by AssemblyBuilder - see #56621).
2302 2004-04-08 Marek Safar <marek.safar@seznam.cz>
2304 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
2305 (TypeManager.ComputeNamespaces): Faster implementation for
2308 * compiler.csproj: Updated AssemblyName to mcs.
2310 2004-04-07 Miguel de Icaza <miguel@ximian.com>
2312 * rootcontext.cs: Add new types to the boot resolution.
2314 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
2315 MulticastDelegate is not allowed.
2317 * typemanager.cs: Add new types to lookup: System.TypedReference
2320 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
2321 check for TypedReference or ArgIterator, they are not allowed.
2323 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
2324 makes us properly catch 1510 in some conditions (see bug 56016 for
2327 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
2329 * CryptoConvert.cs: update from corlib version
2332 2004-04-05 Miguel de Icaza <miguel@ximian.com>
2334 * class.cs (Indexer.Define): Check indexername declaration
2336 2004-04-05 Marek Safar <marek.safar@seznam.cz>
2338 * attribute.cs (IsClsCompliant): Fixed problem with handling
2339 all three states (compliant, not-compliant, undetected).
2341 2004-03-30 Marek Safar <marek.safar@seznam.cz>
2343 * attribute.cs (Attribute): Location is now public.
2344 (Resolve): Store resolved arguments (pos_values) in attribute class.
2345 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
2346 (GetClsCompliantAttributeValue): New method that gets
2347 CLSCompliantAttribute value.
2348 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
2349 if exists else null.
2350 (AttributeTester): New class for CLS-Compliant verification routines.
2352 * class.cs (Emit): Add CLS-Compliant verification.
2353 (Method.GetSignatureForError): Implemented.
2354 (Constructor.GetSignatureForError): Implemented
2355 (Constructor.HasCompliantArgs): Returns if constructor has
2356 CLS-Compliant arguments.
2357 (Constructor.Emit): Override.
2358 (Construcor.IsIdentifierClsCompliant): New method; For constructors
2359 is needed to test only parameters.
2360 (FieldBase.GetSignatureForError): Implemented.
2361 (TypeContainer): New member for storing base interfaces.
2362 (TypeContainer.FindMembers): Search in base interfaces too.
2364 * codegen.cs (GetClsComplianceAttribute): New method that gets
2365 assembly or module CLSCompliantAttribute value.
2366 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
2368 (ModuleClass.Emit): Add error 3012 test.
2370 * const.cs (Emit): Override and call base for CLS-Compliant tests.
2372 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
2373 state for all decl types.
2374 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
2375 if CLS-Compliant tests are required.
2376 (IsClsCompliaceRequired): New method. Analyze whether code
2377 must be CLS-Compliant.
2378 (IsExposedFromAssembly): New method. Returns true when MemberCore
2379 is exposed from assembly.
2380 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
2381 value or gets cached value.
2382 (HasClsCompliantAttribute): New method. Returns true if MemberCore
2383 is explicitly marked with CLSCompliantAttribute.
2384 (IsIdentifierClsCompliant): New abstract method. This method is
2385 used to testing error 3005.
2386 (IsIdentifierAndParamClsCompliant): New method. Common helper method
2387 for identifier and parameters CLS-Compliant testing.
2388 (VerifyClsCompliance): New method. The main virtual method for
2389 CLS-Compliant verifications.
2390 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
2391 null. I don't know why is null (too many public members !).
2392 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
2393 and get value of first CLSCompliantAttribute that found.
2395 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
2396 (VerifyClsCompliance): Override and add extra tests.
2398 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
2399 clscheck- disable CLS-Compliant verification event if assembly is has
2400 CLSCompliantAttribute(true).
2402 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
2403 ApllyAttribute is now called in emit section as in the other cases.
2404 Possible future Emit integration.
2405 (IsIdentifierClsCompliant): New override.
2406 (VerifyClsCompliance): New override.
2407 (GetEnumeratorName): Returns full enum name.
2409 * parameter.cs (GetSignatureForError): Implemented.
2411 * report.cs (WarningData): New struct for Warning message information.
2412 (LocationOfPreviousError): New method.
2413 (Warning): New method. Reports warning based on the warning table.
2414 (Error_T): New method. Reports error based on the error table.
2416 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
2417 verifications are done here.
2419 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
2421 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
2422 CLSCompliantAttribute.
2423 (all_imported_types): New member holds all imported types from other
2425 (LoadAllImportedTypes): New method fills static table with exported types
2426 from all referenced assemblies.
2427 (Modules): New property returns all assembly modules.
2429 2004-03-30 Miguel de Icaza <miguel@ximian.com>
2431 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
2432 throwing a parser error.
2434 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
2435 which removes the hardcoded get_/set_ prefixes for properties, as
2436 IL allows for the properties to be named something else.
2440 * expression.cs: Do not override operand before we know if it is
2443 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
2445 * typemanager.cs: support for pinned variables.
2447 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
2449 * decl.cs, typemanager.cs: Avoid using an arraylist
2450 as a buffer if there is only one result set.
2452 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
2454 * expression.cs: Make sure you cant call a static method
2455 with an instance expression, bug #56174.
2457 2004-03-29 Miguel de Icaza <miguel@ximian.com>
2459 * class.cs (IsDuplicateImplementation): Improve error reporting to
2460 flag 663 (method only differs in parameter modifier).
2462 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
2463 in preprocessor directives.
2465 * location.cs (LookupFile): Allow for the empty path.
2467 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
2468 better approach for some of that patch, but its failing with the
2469 CharSet enumeration. For now try/catch will do.
2471 * typemanager.cs: Do not crash if a struct does not have fields.
2474 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
2476 * expression.cs: cs0213, cant fix a fixed expression.
2479 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
2481 * cs-parser.jay: detect invalid embeded statements gracefully.
2484 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
2486 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
2489 the invocation type may not be a subclass of the tye of the item/
2490 The type of the item must be a subclass of the invocation item.
2495 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
2497 * attribute.cs: Added methods to get a string and a bool from an
2498 attribute. Required to information from AssemblyKeyFileAttribute,
2499 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
2500 * codegen.cs: Modified AssemblyName creation to include support for
2501 strongnames. Catch additional exceptions to report them as CS1548.
2502 * compiler.csproj: Updated include CryptoConvert.cs.
2503 * compiler.csproj.user: Removed file - user specific configuration.
2504 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
2505 Mono.Security assembly. The original class is maintained and tested in
2506 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
2507 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
2508 like CSC 8.0 (C# v2) supports.
2509 * Makefile: Added CryptoConvert.cs to mcs sources.
2510 * rootcontext.cs: Added new options for strongnames.
2512 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
2514 * driver.cs: For --expect-error, report error code `2'
2515 if the program compiled with no errors, error code `1' if
2516 it compiled with an error other than the one expected.
2518 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
2520 * compiler.csproj: Updated for Visual Studio .NET 2003.
2521 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
2522 * compiler.sln: Updated for Visual Studio .NET 2003.
2524 2004-03-24 Ravi Pratap M <ravi@ximian.com>
2526 * expression.cs: Fix bug #47234. We basically need to apply the
2527 rule that we prefer the conversion of null to a reference type
2528 when faced with a conversion to 'object' (csc behaviour).
2530 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
2532 * statement.cs: Shorter form for foreach, eliminates
2533 a local variable. r=Martin.
2535 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
2537 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
2538 checks if we can use brtrue/brfalse to test for 0.
2539 * expression.cs: use the above in the test for using brtrue/brfalse.
2542 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
2544 * expression.cs: Rewrite string concat stuff. Benefits:
2546 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
2547 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
2548 rather than a concat chain.
2550 * typemanager.cs: Add lookups for more concat overloads.
2552 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
2554 * expression.cs: Emit shorter il code for array init.
2571 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
2573 * statement.cs: Before, two switch blocks would be merged if the
2574 total size of the blocks (end_item - begin_item + 1) was less than
2575 two times the combined sizes of the blocks.
2577 Now, it will only merge if after the merge at least half of the
2582 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
2584 * class.cs : csc build fix for GetMethods(). See bug #52503.
2586 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
2588 * expression.cs: Make sure fp comparisons work with NaN.
2589 This fixes bug #54303. Mig approved this patch a long
2590 time ago, but we were not able to test b/c the runtime
2593 2004-03-19 Miguel de Icaza <miguel@ximian.com>
2595 * ecore.cs (TypExpr.GetHashCode): implement this overload.
2597 2004-03-19 Martin Baulig <martin@ximian.com>
2599 * class.cs (MemberCore.IsDuplicateImplementation): Report the
2600 error here and not in our caller.
2602 2004-03-19 Martin Baulig <martin@ximian.com>
2604 * interface.cs: Completely killed this file.
2605 (Interface): We're now a TypeContainer and live in class.cs.
2607 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
2608 argument; we're now also called for interfaces.
2609 (TypeContainer.DefineMembers): Allow this method being called
2611 (TypeContainer.GetMethods): New public method; formerly known as
2612 Interface.GetMethod(). This is used by PendingImplementation.
2613 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
2614 it's now private and non-static.
2615 (Interface): Moved this here; it's now implemented similar to
2617 (Method, Property, Event, Indexer): Added `bool is_interface'
2618 argument to their .ctor's.
2619 (MemberBase.IsInterface): New public field.
2621 * cs-parser.jay: Create normal Method, Property, Event, Indexer
2622 instances instead of InterfaceMethod, InterfaceProperty, etc.
2623 (opt_interface_base): Removed; we now use `opt_class_base' instead.
2624 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
2626 2004-03-19 Martin Baulig <martin@ximian.com>
2628 * class.cs (MethodCore.IsDuplicateImplementation): New private
2629 method which does the CS0111 checking.
2630 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
2631 Use IsDuplicateImplementation().
2633 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
2635 * decl.cs (FindMemberToOverride): New method to find the correct
2636 method or property to override in the base class.
2638 - Make Method/Property use the above method to find the
2639 version in the base class.
2640 - Remove the InheritableMemberSignatureCompare as it is now
2643 This patch makes large code bases much faster to compile, as it is
2644 O(n) rather than O(n^2) to do this validation.
2646 Also, it fixes bug 52458 which is that nested classes are not
2647 taken into account when finding the base class member.
2649 Reviewed/Approved by Martin.
2651 2004-03-17 Marek Safar <marek.safar@seznam.cz>
2653 * interface.cs: In all interface classes removed redundant
2654 member initialization.
2656 2004-03-16 Martin Baulig <martin@ximian.com>
2658 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
2660 2004-03-15 Miguel de Icaza <miguel@ximian.com>
2662 * decl.cs (DefineTypeAndParents): New helper method to define a
2663 type's containers before the type itself is defined; This is a
2664 bug exposed by the recent changes to Windows.Forms when an
2665 implemented interface was defined inside a class that had not been
2668 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
2670 (Check): Loop correctly to report errors modifiers
2671 (UNSAFE was not in the loop, since it was the same as TOP).
2673 * interface.cs: Every interface member now takes a ModFlags,
2674 instead of a "is_new" bool, which we set on the base MemberCore.
2676 Every place where we called "UnsafeOk" in the interface, now we
2677 call the proper member (InterfaceMethod.UnsafeOK) instead to get
2678 the unsafe settings from the member declaration instead of the
2679 container interface.
2681 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
2683 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
2684 `set_indexer_name' to the pending bits (one per type).
2686 We fixed a bug today that was picking the wrong method to
2687 override, since for properties the existing InterfaceMethod code
2688 basically ignored the method name. Now we make sure that the
2689 method name is one of the valid indexer names.
2691 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
2693 * support.cs (SeekableStreamReader): Keep track of stream byte
2694 positions and don't mix them with character offsets to the buffer.
2696 Patch from Gustavo Giráldez
2698 2004-03-15 Marek Safar <marek.safar@seznam.cz>
2700 * interface.cs (InterfaceSetGetBase): Removed double member
2701 initialization, base class does it as well.
2703 2004-03-13 Martin Baulig <martin@ximian.com>
2705 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
2706 when compiling corlib.
2708 2004-03-13 Miguel de Icaza <miguel@ximian.com>
2710 * convert.cs (ExplicitConversion): We were reporting an error on
2711 certain conversions (object_type source to a value type, when the
2712 expression was `null') before we had a chance to pass it through
2713 the user defined conversions.
2715 * driver.cs: Replace / and \ in resource specifications to dots.
2718 * class.cs: Add check for duplicate operators. Fixes 52477
2720 2004-03-11 Miguel de Icaza <miguel@ximian.com>
2722 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
2723 that are in the middle of the statements, not only at the end.
2726 * class.cs (TypeContainer.AddField): No longer set the
2727 `HaveStaticConstructor' flag, now we call it
2728 `UserDefineStaticConstructor' to diferentiate the slightly
2729 semantic difference.
2731 The situation is that we were not adding BeforeFieldInit (from
2732 Modifiers.TypeAttr) to classes that could have it.
2733 BeforeFieldInit should be set to classes that have no static
2738 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
2740 And most importantly Zoltan's comment:
2742 http://bugzilla.ximian.com/show_bug.cgi?id=44229
2744 "I think beforefieldinit means 'it's ok to initialize the type sometime
2745 before its static fields are used', i.e. initialization does not need
2746 to be triggered by the first access to the type. Setting this flag
2747 helps the JIT to compile better code, since it can run the static
2748 constructor at JIT time, and does not need to generate code to call it
2749 (possibly lots of times) at runtime. Unfortunately, mcs does not set
2750 this flag for lots of classes like String.
2752 csc sets this flag if the type does not have an explicit static
2753 constructor. The reasoning seems to be that if there are only static
2754 initalizers for a type, and no static constructor, then the programmer
2755 does not care when this initialization happens, so beforefieldinit
2758 This bug prevents the AOT compiler from being usable, since it
2759 generates so many calls to mono_runtime_class_init that the AOT code
2760 is much slower than the JITted code. The JITted code is faster,
2761 because it does not generate these calls if the vtable is type is
2762 already initialized, which is true in the majority of cases. But the
2763 AOT compiler can't do this."
2765 2004-03-10 Miguel de Icaza <miguel@ximian.com>
2767 * class.cs (MethodData.Emit): Refactor the code so symbolic
2768 information is generated for destructors; For some reasons we
2769 were taking a code path that did not generate symbolic information
2772 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
2774 * class.cs: Create a Constructor.CheckBase method that
2775 takes care of all validation type code. The method
2776 contains some code that was moved from Define.
2778 It also includes new code that checks for duplicate ctors.
2779 This fixes bug #55148.
2781 2004-03-09 Joshua Tauberer <tauberer@for.net>
2783 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
2784 a { ... }-style array creation invokes EmitStaticInitializers
2785 which is not good for reference-type arrays. String, decimal
2786 and now null constants (NullCast) are not counted toward
2787 static initializers.
2789 2004-03-05 Martin Baulig <martin@ximian.com>
2791 * location.cs (SourceFile.HasLineDirective): New public field;
2792 specifies whether the file contains or is referenced by a "#line"
2794 (Location.DefineSymbolDocuments): Ignore source files which
2795 either contain or are referenced by a "#line" directive.
2797 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
2799 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
2800 direct access to our parent, so check the method inline there.
2802 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
2804 * expression.cs (Invocation.EmitCall): Miguel's last commit
2805 caused a regression. If you had:
2810 In Foo the implict this would be null.
2812 2004-02-27 Miguel de Icaza <miguel@ximian.com>
2814 * expression.cs (Invocation.EmitCall): If the method is not
2815 virtual, do not emit a CallVirt to it, use Call.
2817 * typemanager.cs (GetFullNameSignature): Improve the method to
2818 cope with ".ctor" and replace it with the type name.
2820 * class.cs (ConstructorInitializer.Resolve): Now the method takes
2821 as an argument the ConstructorBuilder where it is being defined,
2822 to catch the recursive constructor invocations.
2824 2004-02-26 Miguel de Icaza <miguel@ximian.com>
2826 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
2827 routines to check if a type is an enumerable/enumerator allow
2828 classes that implement the IEnumerable or IEnumerator interfaces.
2830 * class.cs (Property, Operator): Implement IIteratorContainer, and
2831 implement SetYields.
2833 (Property.Define): Do the block swapping for get_methods in the
2834 context of iterators. We need to check if Properties also
2835 include indexers or not.
2837 (Operator): Assign the Block before invoking the
2838 OperatorMethod.Define, so we can trigger the Iterator code
2841 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
2842 Property and Operator classes are not created when we parse the
2843 declarator but until we have the block completed, so we use a
2844 singleton SimpleIteratorContainer.Simple to flag whether the
2845 SetYields has been invoked.
2847 We propagate this setting then to the Property or the Operator to
2848 allow the `yield' to function.
2850 2004-02-25 Marek Safar <marek.safar@seznam.cz>
2852 * codegen.cs: Implemented attribute support for modules.
2853 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
2854 Assembly/Module functionality.
2856 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
2857 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
2858 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
2860 2004-02-16 Marek Safar <marek.safar@seznam.cz>
2862 * interface.cs (FindMembers): The operation is performed on all base
2863 interfaces and not only on the first. It is required for future CLS Compliance patch.
2865 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
2867 * statement.cs, codegen.cs:
2868 This patch deals with patterns such as:
2870 public class List : IEnumerable {
2872 public MyEnumerator GetEnumerator () {
2873 return new MyEnumerator(this);
2876 IEnumerator IEnumerable.GetEnumerator () {
2880 public struct MyEnumerator : IEnumerator {
2885 Before, there were a few things we did wrong:
2886 1) we would emit callvirt on a struct, which is illegal
2887 2) we emited ldarg when we needed to emit ldarga
2888 3) we would mistakenly call the interface methods on an enumerator
2889 type that derived from IEnumerator and was in another assembly. For example:
2891 public class MyEnumerator : IEnumerator
2893 Would have the interface methods called, even if there were public impls of the
2894 method. In a struct, this lead to invalid IL code.
2896 2004-02-11 Marek Safar <marek.safar@seznam.cz>
2898 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
2901 * delegate.cs (Define): Fixed crash when delegate type is undefined.
2903 2004-02-11 Miguel de Icaza <miguel@ximian.com>
2905 * cs-parser.jay: Fix small regression: we were not testing V2
2906 compiler features correctly.
2908 * interface.cs: If the emit context is null, then create one
2910 2004-02-09 Marek Safar <marek.safar@seznam.cz>
2912 * decl.cs (GetSignatureForError): New virtual method to get full name
2915 * attribute.cs (IAttributeSupport): New interface for attribute setting.
2916 Now it is possible to rewrite ApplyAttributes method to be less if/else.
2918 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
2919 Duplicated members and code in these classes has been removed.
2920 Better encapsulation in these classes.
2922 2004-02-07 Miguel de Icaza <miguel@ximian.com>
2924 * assign.cs (Assign.DoResolve): When dealing with compound
2925 assignments, there is a new rule in ECMA C# 2.4 (might have been
2926 there before, but it is documented here) that states that in:
2930 If b is of type int, and the `op' is a shift-operator, then the
2931 above is evaluated as:
2935 * expression.cs (Binary.ResolveOperator): Instead of testing for
2936 int/uint/long/ulong, try to implicitly convert to any of those
2937 types and use that in pointer arithmetic.
2939 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
2940 method to print information for from the type, not from the
2941 null-method we were given.
2943 2004-02-01 Duncan Mak <duncan@ximian.com>
2945 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
2946 parsing for cmd, fixes bug #53694.
2948 2004-02-04 Marek Safar <marek.safar@seznam.cz>
2950 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
2951 in the member name duplication tests. Property and operator name duplication
2952 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
2954 2004-02-03 Marek Safar <marek.safar@seznam.cz>
2956 * interface.cs (PopulateMethod): Fixed crash when interface method
2957 returns not existing type (error test cs0246-3.cs).
2959 2004-02-02 Ravi Pratap M <ravi@ximian.com>
2961 * cs-parser.jay (interface_accessors): Re-write actions to also
2962 store attributes attached to get and set methods. Fix spelling
2965 (inteface_property_declaration): Modify accordingly.
2967 (InterfaceAccessorInfo): New helper class to store information to pass
2968 around between rules that use interface_accessors.
2970 * interface.cs (Emit): Apply attributes on the get and set
2971 accessors of properties and indexers too.
2973 * attribute.cs (ApplyAttributes): Modify accordingly to use the
2974 right MethodBuilder when applying attributes to the get and set accessors.
2976 2004-01-31 Miguel de Icaza <miguel@ximian.com>
2978 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
2980 2004-01-26 Miguel de Icaza <miguel@ximian.com>
2982 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
2984 2004-01-25 Miguel de Icaza <miguel@ximian.com>
2986 * cs-parser.jay: Remove YIELD token, instead use the new grammar
2987 changes that treat `yield' specially when present before `break'
2990 * cs-tokenizer.cs: yield is no longer a keyword.
2992 2004-01-23 Marek Safar <marek.safar@seznam.cz>
2994 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
2995 setting for default constructors.
2996 For default constructors are almost every time set wrong Modifier. The
2997 generated IL code has been alright. But inside mcs this values was
2998 wrong and this was reason why several of my CLS Compliance tests
3001 2004-01-22 Martin Baulig <martin@ximian.com>
3003 * cs-parser.jay (namespace_or_type_name): Return an Expression,
3004 not a QualifiedIdentifier. This is what `type_name_expression'
3005 was previously doing.
3006 (type_name_expression): Removed; the code is now in
3007 `namespace_or_type_name'.
3008 (qualified_identifier): Removed, use `namespace_or_type_name'
3010 (QualifiedIdentifier): Removed this class.
3012 2004-01-22 Martin Baulig <martin@ximian.com>
3014 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
3015 not a string as alias name.
3017 2004-01-21 Miguel de Icaza <miguel@ximian.com>
3019 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
3020 #52730 bug, and instead compute correctly the need to use a
3021 temporary variable when requesting an address based on the
3022 static/instace modified of the field and the constructor.
3024 2004-01-21 Martin Baulig <martin@ximian.com>
3026 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
3027 class and namespace before looking up aliases. Fixes #52517.
3029 2004-01-21 Martin Baulig <martin@ximian.com>
3031 * flowanalysis.cs (UsageVector.Merge): Allow variables being
3032 assinged in a 'try'; fixes exception4.cs.
3034 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3035 * class.cs : Implemented parameter-less constructor for TypeContainer
3037 * decl.cs: Attributes are now stored here. New property OptAttributes
3039 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
3041 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
3043 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3045 * typemanager.cs (CSharpSignature): Now reports also inner class name.
3046 (CSharpSignature): New method for indexer and property signature.
3048 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3050 * pending.cs (IsVirtualFilter): Faster implementation.
3052 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3054 * typemanager.cs: Avoid inclusion of same assembly more than once.
3056 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3058 * cs-parser.jay: Fixed problem where the last assembly attribute
3059 has been applied also to following declaration (class, struct, etc.)
3061 2004-01-21 Marek Safar <marek.safar@seznam.cz>
3063 * class.cs: Added error CS0538, CS0539 reporting.
3064 Fixed crash on Microsoft runtime when field type is void.
3066 * cs-parser.jay: Added error CS0537 reporting.
3068 * pending.cs: Added error CS0535 reporting.
3069 Improved error report for errors CS0536, CS0534.
3071 2004-01-20 Miguel de Icaza <miguel@ximian.com>
3073 Merge a few bits from the Anonymous Method MCS tree.
3075 * statement.cs (ToplevelBlock): New class for toplevel methods,
3076 will hold anonymous methods, lifted variables.
3078 * cs-parser.jay: Create toplevel blocks for delegates and for
3079 regular blocks of code.
3081 2004-01-20 Martin Baulig <martin@ximian.com>
3083 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
3084 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
3085 and `NeedExplicitReturn'; added `IsLastStatement'.
3086 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
3087 have a `ReturnLabel' or we're not unreachable.
3089 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
3090 child's reachability; don't just override ours with it. Fixes
3091 #58058 (lluis's example).
3092 (FlowBranching): Added public InTryOrCatch(), InCatch(),
3093 InFinally(), InLoop(), InSwitch() and
3094 BreakCrossesTryCatchBoundary() methods.
3096 * statement.cs (Return): Do all error checking in Resolve().
3097 Unless we are the last statement in a top-level block, always
3098 create a return label and jump to it.
3099 (Break, Continue): Do all error checking in Resolve(); also make
3100 sure we aren't leaving a `finally'.
3101 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
3102 statement in a top-level block.
3103 (Block.Flags): Added `IsDestructor'.
3104 (Block.IsDestructor): New public property.
3106 2004-01-20 Martin Baulig <martin@ximian.com>
3108 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
3110 2004-01-20 Martin Baulig <martin@ximian.com>
3112 * statement.cs (Statement.ResolveUnreachable): New public method.
3113 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
3114 (Block.Resolve): Resolve unreachable statements.
3116 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
3118 * expression.cs: We need to fix the case where we do
3119 not have a temp variable here.
3121 * assign.cs: Only expression compound assignments need
3122 temporary variables.
3124 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
3126 * flowanalysis.cs: Reduce memory allocation in a few ways:
3127 - A block with no variables should not allocate a bit
3129 - A method with no out parameters does not need any tracking
3130 for assignment of the parameters, so we need not allocate
3133 public readonly Type[] VariableTypes;
3134 public readonly string[] VariableNames;
3135 Are redundant. The data is already stored in the variable
3136 map, so we need not allocate another array for it.
3137 - We need to add alot of checks for if (params | locals) == null
3138 due to the first two changes.
3140 2004-01-18 Miguel de Icaza <miguel@ximian.com>
3142 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
3143 implement IMemoryLocation, we store a copy on a local variable and
3144 take the address of it. Patch from Benjamin Jemlich
3146 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
3147 to use a special "type_name_expression" rule which reduces the
3148 number of "QualifiedIdentifier" classes created, and instead
3149 directly creates MemberAccess expressions.
3151 2004-01-17 Miguel de Icaza <miguel@ximian.com>
3153 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
3154 that fixes #52853. Null literal assignment to ValueType
3156 * class.cs (MethodData.Emit): Instead of checking the name of the
3157 method to determine if its a destructor, create a new derived
3158 class from Method called Destructor, and test for that.
3160 * cs-parser.jay: Create a Destructor object instead of a Method.
3162 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
3166 2004-01-16 Miguel de Icaza <miguel@ximian.com>
3168 * expression.cs (Binary.ResolveOperator): Perform an implicit
3169 conversion from MethodGroups to their delegate types on the
3172 * delegate.cs: Introduce a new class DelegateCreation that is the
3173 base class for `NewDelegate' and `ImplicitDelegateCreation',
3174 factor some code in here.
3176 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
3177 conversion from MethodGroups to compatible delegate types.
3179 * ecore.cs (Expression.Resolve): Do not flag error 654
3180 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
3181 we allow conversions from MethodGroups to delegate types now.
3183 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
3184 assignments in v2 either.
3186 2004-01-10 Miguel de Icaza <miguel@ximian.com>
3188 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
3189 static read-only fields in ctors.
3191 Applied patch from Benjamin Jemlich
3193 * expression.cs (UnaryMutator): Avoid leaking local variables.
3195 2004-01-09 Miguel de Icaza <miguel@ximian.com>
3197 * cs-tokenizer.cs (IsCastToken): Allow the various native types
3198 here to return true, as they can be used like this:
3202 Fixed 49836 and all the other dups
3204 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
3206 * driver.cs: Implement /win32res and /win32icon.
3208 2004-01-08 Miguel de Icaza <miguel@ximian.com>
3210 * cs-parser.jay: Add a rule to improve error handling for the
3211 common mistake of placing modifiers after the type.
3213 2004-01-07 Miguel de Icaza <miguel@ximian.com>
3215 * cs-parser.jay (interface_event_declaration): Catch
3216 initialization of events on interfaces, and report cs0068
3218 * cs-parser.jay (interface_event_declaration): Catch
3219 initialization of events.
3221 * ecore.cs: Better report missing constructors.
3223 * expression.cs (Binary.ResolveOperator): My previous bug fix had
3224 the error reporting done in the wrong place. Fix.
3226 * expression.cs (Binary.ResolveOperator): Catch the
3227 operator + (E x, E y) error earlier, and later allow for implicit
3228 conversions in operator +/- (E e, U x) from U to the underlying
3231 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
3232 52596, if the container class is abstract, the default constructor
3233 is protected otherwise its public (before, we were always public).
3235 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
3238 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
3239 Jemlich that fixes bug #52597, MCS was generating invalid code for
3240 idisposable structs. Thanks to Ben for following up with this
3243 2004-01-06 Miguel de Icaza <miguel@ximian.com>
3245 * driver.cs: Allow assemblies without code to be generated, fixes
3248 2004-01-07 Nick Drochak <ndrochak@gol.com>
3250 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
3252 2004-01-05 Miguel de Icaza <miguel@ximian.com>
3254 * cs-parser.jay: Add rules to improve error reporting if fields or
3255 methods are declared at the namespace level (error 116)
3257 * Add rules to catch event add/remove
3259 2004-01-04 David Sheldon <dave-mono@earth.li>
3261 * expression.cs: Added matching ")" to error message for
3264 2004-01-03 Todd Berman <tberman@gentoo.org>
3266 * ecore.cs, attribute.cs:
3267 Applying fix from #52429.
3269 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
3271 * ecore.cs, expression.cs, statement.cs:
3272 Total rewrite of how we handle branching. We
3273 now handle complex boolean expressions with fewer
3274 jumps. As well if (x == 0) no longer emits a ceq.
3276 if (x is Foo) is much faster now, because we generate
3279 Overall, we get a pretty big improvement on our benchmark
3280 tests. The code we generate is smaller and more readable.
3282 I did a full two-stage bootstrap. The patch was reviewed
3283 by Martin and Miguel.
3285 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
3287 * cs-parser.jay: Make primary_expression not take a QI.
3288 we dont need this because the member_access rule covers
3289 us here. So we replace the rule with just IDENTIFIER.
3291 This has two good effects. First, we remove a s/r conflict.
3292 Second, we allocate many fewer QualifiedIdentifier objects.
3294 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
3296 * attribute.cs: Handle MarshalAs attributes as pseudo, and
3297 set the correct information via SRE. This prevents
3298 hanging on the MS runtime. Fixes #29374.
3300 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
3302 * convert.cs: correctly handle conversions to value types
3303 from Enum and ValueType as unboxing conversions.
3305 Fixes bug #52569. Patch by Benjamin Jemlich.
3307 2004-01-02 Ravi Pratap <ravi@ximian.com>
3309 * expression.cs (BetterConversion): Prefer int -> uint
3310 over int -> ulong (csc's behaviour). This fixed bug #52046.
3312 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
3314 * decl.cs (MemberCache.FindMembers): now returns a
3317 * typemanager.cs: In general, go with with ^^.
3318 (CopyNewMethods): take an IList.
3319 (RealMemberLookup): Only allocate an arraylist
3320 if we copy from two sets of methods.
3322 This change basically does two things:
3323 1) Fewer array lists allocated due to CopyNewMethods.
3324 2) the explicit cast in MemberList costed ALOT.
3326 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
3328 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
3329 a hashtable to avoid needless string allocations when an identifier is
3330 used more than once (the common case).
3332 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
3334 * pending.cs: MS's TypeBuilder.GetInterfaces ()
3335 is broken, it will not return anything. So, we
3336 have to use the information we have in mcs to
3339 * typemanager.cs: Add a cache for GetInterfaces,
3340 since this will now be used more often (due to ^^)
3342 (GetExplicitInterfaces) New method that gets the
3343 declared, not effective, interfaces on a type
3344 builder (eg, if you have interface IFoo, interface
3345 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
3348 This patch makes MCS able to bootstrap itself on
3351 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
3353 * expression.cs: Remove the Nop's that Miguel put
3356 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
3358 * report.cs, codegen.cs: Give the real stack trace to
3359 the error when an exception is thrown.
3361 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
3363 * decl.cs: only allocate hashtables for ifaces if
3366 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
3368 * expression.cs: fix the error from cs0121-2.cs
3369 (a parent interface has two child interfaces that
3370 have a function with the same name and 0 params
3371 and the function is called through the parent).
3373 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
3375 * class.cs, rootcontext.cs, typmanager.cs: do not
3378 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
3380 * codegen.cs: remove stack for the ec flow branching.
3381 It is already a linked list, so no need.
3383 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
3385 * Makefile: Allow custom profiler here.
3387 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
3389 * typemanager.cs (LookupType):
3390 - Use a static char [], because split takes
3391 a param array for args, so it was allocating
3393 - Do not store true in a hashtable, it boxes.
3395 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
3397 * flowanalysis.cs: bytify common enums.
3399 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
3401 * modifiers.cs: Add a new set of flags for the
3402 flags allowed on explicit interface impls.
3403 * cs-parser.jay: catch the use of modifiers in
3404 interfaces correctly.
3405 * class.cs: catch private void IFoo.Blah ().
3407 All related to bug #50572.
3409 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
3411 * decl.cs: Rewrite the consistant accessability checking.
3412 Accessability is not linear, it must be implemented in
3413 a tableish way. Fixes #49704.
3415 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
3417 * expression.cs: Handle negation in a checked context.
3418 We must use subtraction from zero. Fixes #38674.
3420 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
3422 * class.cs: Ignore static void main in DLLs.
3423 * rootcontext.cs: Handle the target type here,
3424 since we are have to access it from class.cs
3425 * driver.cs: account for the above.
3427 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
3429 * report.cs: Give line numbers and files if available.
3431 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
3433 * driver.cs: Implement /addmodule.
3435 * typemanager.cs: Change 'modules' field so it now contains Modules not
3438 2003-12-20 Martin Baulig <martin@ximian.com>
3440 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
3441 (FieldBase.IsAssigned): Removed this field.
3442 (FieldBase.SetAssigned): New public method.
3443 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
3445 2003-12-20 Martin Baulig <martin@ximian.com>
3447 * expression.cs (LocalVariableReference.DoResolve): Don't set
3448 `vi.Used' if we're called from DoResolveLValue().
3450 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
3451 returns the usage vector it just merged into the current one -
3452 pass this one to UsageWarning().
3453 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
3454 of the `EmitContext', don't call this recursively on our children.
3456 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
3458 * driver.cs: Implement /target:module.
3460 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
3462 * support.cs (CharArrayHashtable): New helper class.
3464 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
3465 char arrays, not strings, so we can avoid creating a string in
3466 consume_identifier if the identifier is a keyword.
3468 2003-12-16 Martin Baulig <martin@ximian.com>
3470 * statement.cs (LocalInfo.Assigned): Removed this property.
3471 (LocalInfo.Flags): Removed `Assigned'.
3472 (LocalInfo.IsAssigned): New public method; takes the EmitContext
3473 and uses flow analysis.
3474 (Block.UsageWarning): Made this method private.
3475 (Block.Resolve): Call UsageWarning() if appropriate.
3477 * expression.cs (LocalVariableReference.DoResolve): Always set
3478 LocalInfo.Used here.
3480 2003-12-13 Martin Baulig <martin@ximian.com>
3482 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
3483 any value here; we're now using flow analysis to figure out
3484 whether a statement/block returns a value.
3486 2003-12-13 Martin Baulig <martin@ximian.com>
3488 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
3490 (FlowBranching.MergeFinally): Don't call
3491 `branching.CheckOutParameters()' here, this is called in
3493 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
3494 when adding the `finally' vector.
3496 2003-12-13 Martin Baulig <martin@ximian.com>
3499 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
3500 actually work and also fix #48962.
3502 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
3504 * decl.cs: Do not check System.Object for nested types,
3505 since we know it does not have any. Big bang for buck:
3510 corlib: 17.99 seconds
3514 corlib: 17.39 seconds
3516 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
3518 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
3519 time we are returning 0 members, so we save alot here.
3521 2003-12-11 Martin Baulig <martin@ximian.com>
3523 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
3524 `MergeChild()', also just take the `FlowBranching' as argument;
3525 call Merge() on it and return the result.
3526 (FlowBranching.Merge): We don't need to do anything if we just
3529 2003-12-11 Martin Baulig <martin@ximian.com>
3531 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
3532 them in an `ArrayList' to reduce memory usage. Thanks to Ben
3533 Maurer for this idea.
3535 2003-12-11 Martin Baulig <martin@ximian.com>
3537 * flowanalysis.cs (MergeResult): This class is now gone; we now
3538 use the `UsageVector' for this. The reason for this is that if a
3539 branching just has one sibling, we don't need to "merge" them at
3540 all - that's the next step to do.
3541 (FlowBranching.Merge): We now return a `UsageVector' instead of a
3544 2003-12-11 Martin Baulig <martin@ximian.com>
3546 Reworked flow analyis and made it more precise and bug-free. The
3547 most important change is that we're now using a special `Reachability'
3548 class instead of having "magic" meanings of `FlowReturns'. I'll
3549 do some more cleanups and optimizations and also add some more
3550 documentation this week.
3552 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
3553 largely reworked this class.
3554 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
3555 the new `Reachability' class instead of having "magic" values here.
3556 (FlowBranching): We're now using an instance of `Reachability'
3557 instead of having separate `Returns', `Breaks' etc. fields.
3559 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
3560 based on flow analysis; ignore the return value of block.Emit ().
3562 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
3564 * driver.cs typemanager.cs: Find the mono extensions to corlib even
3565 if they are private.
3567 2003-12-09 Martin Baulig <martin@ximian.com>
3569 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
3570 call them directly on the UsageVector.
3572 2003-12-09 Martin Baulig <martin@ximian.com>
3574 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
3575 Changed return type from `FlowReturns' to `Reachability'.
3577 2003-12-09 Martin Baulig <martin@ximian.com>
3579 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
3580 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
3581 `Reachable' fields with a single `Reachability' one.
3583 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
3585 * class.cs (FindMembers): Remove foreach's.
3598 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
3603 This patch does a few things:
3604 1. EmptyStatement is now a singleton, so it is never reallocated.
3605 2. All blah is EmptyStatement constructs have been changed to
3606 blah == EmptyStatement.Value, which is much faster and valid
3607 now that EmptyStatement is a singleton.
3608 3. When resolving a block, rather than allocating a new array for
3609 the non-empty statements, empty statements are replaced with
3610 EmptyStatement.Value
3611 4. Some recursive functions have been made non-recursive.
3612 Mainly the performance impact is from (3), however (1) and (2) are needed for
3613 this to work. (4) does not make a big difference in normal situations, however
3614 it makes the profile look saner.
3619 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
3620 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
3621 Total memory allocated: 56397 KB
3624 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
3625 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
3626 Total memory allocated: 55666 KB
3628 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
3630 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
3631 than the hashtable in a hashtable version
3633 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
3634 we always end up concating a string. This results in a huge perf
3635 loss, because many strings have to be tracked by the GC. In this
3636 patch, we first use a hashtable that works with two keys, so that
3637 the strings do not need to be concat'ed.
3648 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
3650 * Makefile: Add a new target `do-time' that does a quick and simple
3651 profile, leaving easy to parse output.
3653 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
3655 * codegen.cs (Init): Create the dynamic assembly with
3656 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
3658 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
3660 * support.cs: Make the PtrHashtable use only one
3661 instance of its comparer.
3663 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
3665 * typemanager.cs: Fix lookup of GetNamespaces.
3667 2003-11-29 Miguel de Icaza <miguel@ximian.com>
3669 * expression.cs: Removed redundant line.
3671 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
3672 ArrayLists, use for loops with bounds.
3674 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
3677 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
3678 arraylists, use for loop with bounds.
3680 The above three changes give us a 0.071 second performance
3681 improvement out of 3.294 seconds down to 3.223. On my machine
3682 the above changes reduced the memory usage by 1,387 KB during
3685 * cs-parser.jay (QualifiedIdentifier): New class used to represent
3686 QualifiedIdentifiers. Before we created a new string through
3687 concatenation, and mostly later on, the result would be
3688 manipulated by DecomposeQI through string manipulation.
3690 This reduced the compiler memory usage for bootstrapping from
3691 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
3692 compile times in 0.05 seconds.
3694 2003-11-28 Dick Porter <dick@ximian.com>
3696 * support.cs: Do string compares with the Invariant culture.
3704 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
3705 the comparison is done with the Invariant culture.
3707 2003-11-27 Miguel de Icaza <miguel@ximian.com>
3709 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
3710 GetEnumerator method.
3712 (ProbeCollectionType): Iterate starting at the most specific type
3713 upwards looking for a GetEnumerator
3715 * expression.cs: Shift count can be up to 31 for int/uint and 63
3718 2003-11-26 Miguel de Icaza <miguel@ximian.com>
3720 * statement.cs (Block.LookupLabel): Also look for the label on the
3721 children blocks. Use a hash table to keep track of visited
3724 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
3725 we actually did transform the other operand, otherwise fall back
3726 to the common codepath that casts to long.
3728 * cs-tokenizer.cs: Use the same code pattern as the int case.
3729 Maybe I should do the parsing myself, and avoid depending on the
3730 Parse routines to get this done.
3732 2003-11-25 Miguel de Icaza <miguel@ximian.com>
3734 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
3735 which fixes bug 51347. This time test it.
3737 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
3738 attributes for example can not tell the difference between these.
3739 The difference was only a syntax feature of the language.
3741 * attribute.cs: Apply attributes to delegates.
3743 * delegate.cs: Call the apply attributes method.
3745 2003-11-24 Miguel de Icaza <miguel@ximian.com>
3747 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
3748 comparing 0 vs Byte.MinValue, not the value
3750 (ImplicitConversionRequired): When reporting a conversion error,
3751 use error 31 to print out the constant error instead of the
3754 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
3755 which fixes bug 51347.
3757 2003-11-22 Miguel de Icaza <miguel@ximian.com>
3759 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
3760 which fixes the -warnaserror command line option.
3762 2003-11-21 Miguel de Icaza <miguel@ximian.com>
3764 * cfold.cs (DoNumericPromotions): During constant folding of
3765 additions on UIntConstant, special case intconstants with
3766 IntConstants like we do on the expression binary operator.
3768 2003-11-12 Miguel de Icaza <miguel@ximian.com>
3770 * convert.cs (ImplicitReferenceConversion): We were missing a case
3771 (System.Enum are not value types or class types, so we need to
3772 classify them separatedly).
3774 * driver.cs: We do not support error 2007.
3776 2003-11-12 Jackson Harper <jackson@ximian.com>
3778 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
3779 system directory. Also use the full file name so users can
3780 libraries names mscorlib-o-tron.dll in a non system dir.
3782 2003-11-10 Martin Baulig <martin@ximian.com>
3784 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
3785 (TypeManager.InitCoreTypes): Initialize them here, but instead of
3786 calling `ResolveType()' on them, directly assign their `Type'.
3788 2003-11-08 Martin Baulig <martin@ximian.com>
3790 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
3791 return value and the `out parent' parameter.
3792 (TypeContainer.DefineType): Moved the CS0644 check into
3793 GetClassBases(). Don't pass the interface types to the
3794 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
3795 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
3797 * ecore.cs (TypeExpr.IsAttribute): New property.
3798 (TypeExpr.GetInterfaces): New method.
3800 * interface.cs (Interface.GetInterfaceTypeByName): Return a
3801 TypeExpr instead of a Type.
3802 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
3803 (Interface.DefineType): Don't pass the interface types to the
3804 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
3805 them later and then call `TypeBulider.AddInterfaceImplementation()'.
3807 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
3808 instead of a `Type[]'.
3809 (TypeManager.RegisterBuilder): Likewise.
3810 (TypeManager.AddUserInterface): Likewise.
3811 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
3812 `Type[]' and also return a `TypeExpr[]'.
3813 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
3815 2003-11-08 Martin Baulig <martin@ximian.com>
3817 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
3820 2003-11-08 Martin Baulig <martin@ximian.com>
3822 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
3823 TypeManager.ResolveExpressionTypes().
3825 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
3826 instead of an Expression.
3827 (TypeExpr): This is now an abstract base class for `TypeExpression'.
3828 (TypeExpression): New public class; formerly known as `TypeExpr'.
3830 * expression.cs (ComposedCast): Derive from TypeExpr.
3832 * typemanager.cs (TypeManager.system_*_expr): These are now
3833 TypExpr's instead of Expression's.
3834 (TypeManager.ResolveExpressionTypes): New public static function;
3835 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
3838 2003-11-06 Miguel de Icaza <miguel@ximian.com>
3840 * expression.cs (New.DoResolve): Do not dereference value that
3841 might be a null return.
3843 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
3844 sure that the constant value has the right type. Fixes an
3845 unreported bug, similar to 50425.
3847 * const.cs (Const.LookupConstantValue): Call
3848 ImplicitStandardConversionExists before doing a conversion to
3849 avoid havng the TypeManager.ChangeType do conversions.
3851 Reduced the number of casts used
3853 (Const.ChangeType): New routine to enable reuse of the constant
3854 type changing code from statement.
3856 * typemanager.cs (ChangeType): Move common initialization to
3857 static global variables.
3861 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
3862 every value type to go through, even if it was void. Fix that.
3864 * cs-tokenizer.cs: Use is_identifier_start_character on the start
3865 character of the define, and the is_identifier_part_character for
3866 the rest of the string.
3868 2003-11-05 Miguel de Icaza <miguel@ximian.com>
3870 * expression.cs (UnaryMutator.EmitCode): When I updated
3871 LocalVariableReference.DoResolve, I overdid it, and dropped an
3872 optimization done on local variable references.
3874 2003-11-04 Miguel de Icaza <miguel@ximian.com>
3876 * ecore.cs: Convert the return from Ldlen into an int.
3878 2003-10-20 Miguel de Icaza <miguel@ximian.com>
3880 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
3881 the accessibility, this is a special case for toplevel non-public
3882 classes (internal for instance).
3884 2003-10-20 Nick Drochak <ndrochak@gol.com>
3886 * ecore.cs: Fix typo and build. Needed another right paren.
3888 2003-10-19 Miguel de Icaza <miguel@ximian.com>
3890 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
3891 `internal' case regular and protected, but not allowing protected
3892 to be evaluated later. Bug 49840
3894 2003-10-15 Miguel de Icaza <miguel@ximian.com>
3896 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
3897 to kb.Nlast, and not the kb.nFirst to isolate the switch
3900 Extract the underlying type, so enumerations of long/ulong are
3901 treated like long/ulong.
3903 2003-10-14 Miguel de Icaza <miguel@ximian.com>
3905 * expression.cs (New): Overload the meaning of RequestedType to
3906 track the possible creation of the NewDelegate type, since
3907 DoResolve is invoked more than once for new constructors on field
3910 See bugs: #48800 and #37014
3912 * cs-parser.jay (declare_local_constants): Take an arraylist
3913 instead of a single constant.
3915 (local_constant_declaration): It should take a
3916 constant_declarators, not a constant_declarator. Fixes 49487
3918 * convert.cs: Fix error report.
3920 2003-10-13 Jackson Harper <jackson@ximian.com>
3922 * typemanager.cs (TypeToCoreType): Add float and double this fixes
3925 2003-10-09 Martin Baulig <martin@ximian.com>
3927 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
3929 (MethodCore.DoDefineParameters): Removed the TypeContainer
3930 argument; use the DeclSpace which was passed to the .ctor instead.
3931 (MethodCore.CheckParameter): Take a DeclSpace instead of a
3932 TypeContainer; we only need a DeclSpace here.
3934 2003-10-09 Martin Baulig <martin@ximian.com>
3936 * class.cs (MethodData): Added additional `DeclSpace ds' argument
3938 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
3939 EmitContext's .ctor.
3941 2003-10-09 Martin Baulig <martin@ximian.com>
3943 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
3944 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
3945 AsAccessible(), moved them as well.
3947 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
3949 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
3951 * cs-parser.jay : Renamed yyName to yyNames related to jay.
3953 2003-10-07 Miguel de Icaza <miguel@ximian.com>
3955 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
3956 generation for >=, as spotted by Paolo, bug 48679.
3957 Patch from David Waite.
3959 * cs-tokenizer.cs: Add handling for #pragma.
3961 * cs-parser.jay: Allow for both yield and yield return in the
3962 syntax. The anti-cobolization of C# fight will go on!
3964 * class.cs (TypeBuilder.DefineType): Catch error condition here
3965 (Parent.DefineType erroring out and returning null).
3967 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
3968 coping with enumerations variables, we were mistakenly processing
3969 them as a regular value type instead of built-in types. Fixes the
3972 * typemanager.cs (IsBuiltinOrEnum): New method.
3974 2003-09-30 Miguel de Icaza <miguel@ximian.com>
3976 * cs-parser.jay: Upgrade: yield now needs the return clause.
3978 2003-09-19 Martin Baulig <martin@ximian.com>
3980 * decl.cs (MemberCache.SetupCacheForInterface): Take a
3981 `MemberCache parent' argument. Normally, an interface doesn't
3982 have a parent type except System.Object, but we use this in gmcs
3983 for generic type parameters.
3985 2003-09-18 Martin Baulig <martin@ximian.com>
3987 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
3988 on `type.IsInterface'; don't check whether the type has a parent
3989 to determine whether it's an interface.
3991 2003-09-15 Martin Baulig <martin@ximian.com>
3993 * class.cs (TypeContainer.DefineType): Added an error flag to
3994 avoid reporting duplicate CS0146's ("class definition is
3997 * driver.cs (Driver.MainDriver): Abort if
3998 RootContext.ResolveTree() reported any errors.
4000 2003-09-07 Martin Baulig <martin@ximian.com>
4002 * report.cs (Error, Warning): Added overloaded versions which take
4003 a `params object[] args' and call String.Format().
4005 2003-09-07 Martin Baulig <martin@ximian.com>
4007 * decl.cs (DeclSpace..ctor): Don't call
4008 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
4009 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
4010 (DeclSpace.RecordDecl): New method.
4012 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
4014 2003-09-02 Ravi Pratap <ravi@ximian.com>
4016 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
4017 value attributes to be applied to ParameterBuilders.
4019 * class.cs (MethodCore.LabelParameters): Make static and more
4020 generic so that it can be used from other places - like interface
4021 methods, for instance.
4023 * interface.cs (Interface.Emit): Call LabelParameters before
4024 emitting attributes on the InterfaceMethod.
4026 2003-08-26 Martin Baulig <martin@ximian.com>
4028 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
4029 resolving aliases; fixes #47927.
4031 2003-08-26 Martin Baulig <martin@ximian.com>
4033 * statement.cs (Using.DoResolve): This is internally emitting a
4034 try/finally clause, so we need to set ec.NeedExplicitReturn if we
4035 do not always return. Fixes #47681.
4037 2003-08-26 Martin Baulig <martin@ximian.com>
4039 * decl.cs (MemberCore): Moved WarningNotHiding(),
4040 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
4042 (AdditionResult): Make this nested in DeclSpace.
4043 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
4044 argument; call NamespaceEntry.Define() unless we're nested in a
4047 * namespace.cs (Namespace.DefineName): New public function. This
4048 is called from DeclSpace's .ctor to add
4049 (Namespace.Lookup): Include DeclSpaces in the lookup.
4051 * class.cs (Operator): Derive from MemberBase, not MemberCore.
4053 * const.cs (Const): Derive from MemberBase, not MemberCore.
4055 2003-08-25 Martin Baulig <martin@ximian.com>
4057 * convert.cs (Convert.ExplicitReferenceConversion): When
4058 converting from an interface type to a class, unbox if the target
4059 type is a struct type. Fixes #47822.
4061 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4063 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
4066 2003-08-22 Martin Baulig <martin@ximian.com>
4068 * class.cs (TypeManager.DefineType): When defining a nested type,
4069 call DefineType() on our parent; fixes #47801.
4071 2003-08-22 Martin Baulig <martin@ximian.com>
4073 * class.cs (MethodData.Define): While checking if a method is an
4074 interface implementation, improve the test a bit more to fix #47654.
4076 2003-08-22 Martin Baulig <martin@ximian.com>
4078 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
4079 correctly; fixes #47722.
4081 2003-08-22 Martin Baulig <martin@ximian.com>
4083 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
4084 LocalVariableReference, ensure it's not read-only. Fixes #47536.
4086 * statement.cs (Fixed.DoResolve): Make all variables read-only.
4088 2003-08-22 Martin Baulig <martin@ximian.com>
4090 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
4091 can only be assigned in static constructors. Fixes #47161.
4093 2003-08-22 Martin Baulig <martin@ximian.com>
4095 Rewrote and improved the flow analysis code.
4097 * flowbranching.cs (FlowBranching): Make this class abstract.
4098 (FlowBranching.CreateBranching): New static function to create a
4100 (FlowBranchingBlock, FlowBranchingException): New classes.
4101 (FlowBranching.UsageVector.Type): New public readonly field.
4102 (FlowBranching.UsageVector.Breaks): Removed the setter.
4103 (FlowBranching.UsageVector.Returns): Removed the setter.
4104 (FlowBranching.UsageVector): Added Break(), Return(),
4105 NeverReachable() and Throw() methods to modify the reachability.
4106 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
4107 done by FlowBranching.Merge().
4108 (FlowBranching.UsageVector.MergeChild): New method; merges the
4109 merge result into the current vector.
4110 (FlowBranching.Merge): New abstract method to merge a branching.
4112 2003-08-12 Martin Baulig <martin@ximian.com>
4114 * expression.cs (Indirection.CacheTemporaries): Create the
4115 LocalTemporary with the pointer type, not its element type.
4117 2003-08-10 Miguel de Icaza <miguel@ximian.com>
4119 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
4120 token was a keyword or not.
4122 Add `error' options where an IDENTIFIER was expected; Provide
4123 CheckToken and CheckIdentifierToken convenience error reporting
4126 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
4128 * decl.cs: Rename `NamespaceEntry Namespace' public field into
4129 NameSpaceEntry NameSpaceEntry.
4131 (LookupInterfaceOrClass): Avoid creating a full qualified name
4132 from namespace and name: avoid doing lookups when we know the
4133 namespace is non-existant. Use new Tree.LookupByNamespace which
4134 looks up DeclSpaces based on their namespace, name pair.
4136 * driver.cs: Provide a new `parser verbose' to display the
4137 exception thrown during parsing. This is turned off by default
4138 now, so the output of a failure from mcs is more graceful.
4140 * namespace.cs: Track all the namespaces defined in a hashtable
4143 (IsNamespace): New method
4145 2003-08-09 Miguel de Icaza <miguel@ximian.com>
4147 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
4148 we know that we need to concatenate (full typename can never be
4153 * statement.cs: Use a bitfield; Do not initialize to null things
4154 which are done by the constructor by default.
4156 * cs-parser.jay: bug fix, parameter was 4, not 3.
4158 * expression.cs: Just use the property;
4160 * statement.cs: No need for GetVariableInfo method.
4162 2003-08-08 Martin Baulig <martin@ximian.com>
4164 * flowanalysis.cs (FlowReturns): This is now nested in the
4165 `FlowBranching' class.
4166 (MyBitVector): Moved this here from statement.cs.
4167 (FlowBranching.SiblingType): New enum type.
4168 (FlowBranching.CreateSibling): Added `SiblingType' argument.
4170 2003-08-07 Martin Baulig <martin@ximian.com>
4172 * flowanalysis.cs (FlowBranchingType): This is now nested in the
4173 `FlowBranching' class and called `BranchingType'.
4175 2003-08-07 Martin Baulig <martin@ximian.com>
4177 * flowanalysis.cs: Moved all the control flow analysis code into
4180 2003-08-07 Martin Baulig <martin@ximian.com>
4182 * assign.cs (Assign.DoResolve): `target' must either be an
4183 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
4186 2003-08-07 Miguel de Icaza <miguel@ximian.com>
4188 * expression.cs (BinaryMethod): This kind of expression is created by the
4189 Binary class if it determines that the operator has to be handled
4192 (BinaryDelegate): This kind of expression is created if we are
4193 dealing with a + or - operator on delegates.
4195 (Binary): remove method, argumetns, and DelegateOperator: when
4196 dealing with methods,
4198 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
4200 * statement.cs (Block): use bitfields for the three extra booleans
4201 we had in use. Remove unused topblock parameter.
4203 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
4205 * assign.cs: Drop extra unneeded tests.
4207 2003-08-06 Miguel de Icaza <miguel@ximian.com>
4209 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
4211 * statement.cs (Foreach): Use VariableStorage instead of
4214 * codegen.cs (VariableStorage): New class used by clients that
4215 require a variable stored: locals or fields for variables that
4216 need to live across yield.
4218 Maybe provide a convenience api for EmitThis+EmitLoad?
4220 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
4223 2003-08-05 Miguel de Icaza <miguel@ximian.com>
4225 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
4226 RemapParameterLValue): New methods that are used to turn a
4227 precomputed FieldInfo into an expression like this:
4231 The idea is to use this instead of making LocalVariableReference
4232 have more than one meaning.
4234 * cs-parser.jay: Add error production to BASE.
4236 * ecore.cs: Deal with TypeManager.GetField returning null, which
4237 is now a valid return value.
4239 (FieldExprNoAddress): New expression for Fields whose address can
4242 * expression.cs (LocalVariableReference): During the resolve
4243 phases, create new expressions if we are in a remapping context.
4244 Remove code that dealt with remapping here.
4246 (ParameterReference): same.
4248 (ProxyInstance): New expression, like the `This' expression, but
4249 it is born fully resolved. We know what we are doing, so remove
4250 the errors that are targeted to user-provided uses of `this'.
4252 * statement.cs (Foreach): our variable is now stored as an
4253 Expression; During resolution, follow the protocol, dont just
4254 assume it will return this.
4256 2003-08-06 Martin Baulig <martin@ximian.com>
4258 * support.cs (SeekableStreamReader.cs): New public class.
4260 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
4261 SeekableStreamReader instead of the normal StreamReader.
4263 2003-08-04 Martin Baulig <martin@ximian.com>
4265 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
4266 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
4267 deambiguate casts and delegate invocations.
4268 (parenthesized_expression): Use the new tokens to ensure this is
4269 not a cast of method invocation.
4271 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
4272 when reading a `)' and Deambiguate_CloseParens () was previously
4275 * expression.cs (ParenthesizedExpression): New class. This is
4276 just used for the CS0075 test.
4277 (Binary.DoResolve): Check for CS0075.
4279 2003-07-29 Ravi Pratap <ravi@ximian.com>
4281 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
4282 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
4283 reference comparison.
4285 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
4286 examine the ReturnType for equality - this is necessary in the
4287 cases of implicit and explicit operators whose signature also
4288 includes the return type.
4290 2003-07-26 Miguel de Icaza <miguel@ximian.com>
4292 * namespace.cs: Cache the result of the namespace computation,
4293 instead of computing it every time.
4295 2003-07-24 Miguel de Icaza <miguel@ximian.com>
4297 * decl.cs: Use a global arraylist that we reuse over invocations
4298 to avoid excesive memory consumption. Reduces memory usage on an
4299 mcs compile by one meg (45 average).
4301 * typemanager.cs (LookupTypeReflection): In .NET pointers are
4302 private, work around that.
4304 2003-07-23 Miguel de Icaza <miguel@ximian.com>
4306 * literal.cs (IntLiteral): Define Zero and One static literals.
4308 * cs-parser.jay (integer_literal): use static literals to reduce
4309 memory usage for the most used literals (0, 1 and -1). 211kb
4310 reduced in memory usage.
4312 Replace all calls to `new ArrayList' with `new
4313 ArrayList(4)' which is a good average number for most allocations,
4314 and also requires only 16 bytes of memory for its buffer by
4317 This reduced MCS memory usage in seven megabytes for the RSS after
4320 2003-07-28 Ravi Pratap <ravi@ximian.com>
4322 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
4323 handle params methods the correct way by forming only one
4324 applicable set with params and normal methods in them. Earlier we
4325 were looking at params methods only if we found no normal methods
4326 which was not the correct thing to do.
4328 (Invocation.BetterFunction): Take separate arguments indicating
4329 when candidate and the best method are params methods in their
4332 This fixes bugs #43367 and #46199.
4334 * attribute.cs: Documentation updates.
4336 (CheckAttribute): Rename to CheckAttributeTarget.
4337 (GetValidPlaces): Rename to GetValidTargets.
4339 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
4340 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
4344 2003-07-28 Martin Baulig <martin@ximian.com>
4346 * class.cs (TypeContainer.DefineMembers): Use the base type's full
4347 name when looking up the base class of a nested class. Fixes #46977.
4349 2003-07-26 Martin Baulig <martin@ximian.com>
4351 * expression.cs (Indexers.Indexer): New nested struct; contains
4352 getter, setter and the indexer's type.
4353 (Indexers.Properties): This is now an ArrayList of
4355 (IndexerAccess.DoResolveLValue): Correctly set the type if the
4356 indexer doesn't have any getters.
4358 * assign.cs (Assign.DoResolve): Also do the implicit conversions
4359 for embedded property and indexer assignments.
4361 2003-07-26 Martin Baulig <martin@ximian.com>
4363 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
4364 preprocessor directive is not the first non-whitespace character
4367 2003-07-26 Martin Baulig <martin@ximian.com>
4369 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
4370 namespace parsing, follow the spec more closely.
4372 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
4373 NamespaceEntry.Lookup().
4375 2003-07-25 Martin Baulig <martin@ximian.com>
4377 * MethodCore.cs (OverridesSomething): New public field; it's set
4378 from TypeContainer.DefineMembers if this method overrides
4379 something (which doesn't need to be a method). Fix #39462.
4381 2003-07-25 Ravi Pratap <ravi@ximian.com>
4383 * typemanager.cs (GetMembers): Ensure that the list of members is
4384 reversed. This keeps things in sync.
4386 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
4387 find an AttributeUsage attribute.
4389 * expression.cs (Invocation.OverloadResolve): Perform the check
4390 which disallows Invoke to be directly called on a Delegate.
4392 (Error_InvokeOnDelegate): Report error cs1533.
4394 2003-07-25 Martin Baulig <martin@ximian.com>
4396 * expression.cs (Indexers.GetIndexersForType): Only look in the
4397 interface hierarchy if the requested type is already an
4398 interface. Fixes #46788 while keeping #46502 fixed.
4400 2003-07-25 Martin Baulig <martin@ximian.com>
4402 * class.cs (TypeContainer.DefineMembers): Check whether all
4403 readonly fields have been assigned and report warning CS0649 if
4406 * statement.cs (LocalInfo.IsFixed): Always return true if this is
4409 2003-07-24 Ravi Pratap <ravi@ximian.com>
4411 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
4412 returned from GetMethods to make things consistent with the
4413 assumptions MCS makes about ordering of methods.
4415 This should comprehensively fix bug #45127 and it does :-)
4417 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
4418 ordering is actually reverse.
4420 * Clean up some debug messages I left lying around.
4422 * interface.cs (Populate*): Get rid of code which emits attributes
4423 since the stage in which we emit attributes is the 'Emit' stage,
4424 not the define stage.
4426 (Emit): Move attribute emission for interface members here.
4428 2003-07-22 Ravi Pratap <ravi@ximian.com>
4430 * expression.cs (Invocation.OverloadResolve): Follow the spec more
4431 closely: we eliminate methods in base types when we have an
4432 applicable method in a top-level type.
4434 Please see section 14.5.5.1 for an exact description of what goes
4437 This fixes bug #45127 and a host of other related to corlib compilation.
4439 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
4440 array is the method corresponding to the top-level type (this is
4441 because of the changes made to icall.c) so we change this
4444 (MethodGroupExpr.Name): This too.
4446 * typemanager.cs (GetElementType): New method which does the right
4447 thing when compiling corlib.
4449 * everywhere: Make use of the above in the relevant places.
4451 2003-07-22 Martin Baulig <martin@ximian.com>
4453 * cs-parser.jay (invocation_expression): Moved
4454 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
4455 `cast_expression', but create a InvocationOrCast which later
4456 resolves to either an Invocation or a Cast.
4458 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
4459 method; call this before EmitStatement() to make sure that this
4460 expression can be used as a statement.
4462 * expression.cs (InvocationOrCast): New class; resolves to either
4463 an Invocation or a Cast.
4465 * statement.cs (StatementExpression): Call ResolveStatement() on
4466 the ExpressionStatement before emitting it.
4468 2003-07-21 Martin Baulig <martin@ximian.com>
4470 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
4471 `ref' and `out' attributes match; fixes #46220.
4472 (MemberAccess.ResolveMemberAccess): You can't reference a type
4473 through an expression; fixes #33180.
4474 (Indexers.GetIndexersForType): Don't return the indexers from
4475 interfaces the class implements; fixes #46502.
4477 2003-07-21 Martin Baulig <martin@ximian.com>
4479 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
4480 CS0661 checks; fixes bug #30442.
4482 2003-07-21 Martin Baulig <martin@ximian.com>
4484 * decl.cs (AdditionResult): Added `Error'.
4486 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
4488 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
4489 makes cs0031.cs actually work.
4491 2003-07-20 Martin Baulig <martin@ximian.com>
4493 * namespace.cs: Fixed that bug which caused a crash when compiling
4496 2003-07-20 Miguel de Icaza <miguel@ximian.com>
4498 * typemanager.cs (LookupTypeReflection): Never expose types which
4499 are NotPublic, NestedPrivate, NestedAssembly, or
4500 NestedFamANDAssem. We used to return these, and later do a check
4501 that would report a meaningful error, but the problem is that we
4502 would not get the real match, if there was a name override.
4504 2003-07-18 Miguel de Icaza <miguel@ximian.com>
4506 * namespace.cs (Namespace, Name): Do not compute the namespace
4507 name dynamically, compute it in the constructor. This reduced
4508 memory usage by 1697 KB.
4510 * driver.cs: Use --pause to pause at the end.
4512 2003-07-17 Peter Williams <peter@newton.cx>
4514 * Makefile: Change the name of the test target so that it doesn't
4515 conflict with the recursive test target.
4517 2003-07-17 Miguel de Icaza <miguel@ximian.com>
4519 * expression.cs (LocalVariableReference.Emit, EmitAssign,
4520 AddressOf): Do not use EmitThis, that was wrong, use the actual
4523 2003-07-15 Miguel de Icaza <miguel@ximian.com>
4525 * class.cs (MethodData.Define): While checking if a method is an
4526 interface implementation, improve the test: If we are not public
4527 (use new test here: use the computed MethodAttributes directly,
4528 instead of the parsed modifier flags) check if the `implementing'
4529 method comes from an interface or not.
4531 * pending.cs (VerifyPendingMethods): Slightly better error
4534 * makefile: add test target that does the mcs bootstrap.
4536 2003-07-16 Ravi Pratap <ravi@ximian.com>
4538 * interface.cs (Define): Do nothing here since there are no
4539 members to populate etc. Move the attribute emission out of here
4540 since this was just totally the wrong place to put it. Attribute
4541 application happens during the 'Emit' phase, not in the 'Define'
4544 (Emit): Add this method and move the attribute emission here
4546 * rootcontext.cs (EmitCode): Call the Emit method on interface
4549 2003-07-14 Ravi Pratap M <ravi@ximian.com>
4551 * expression.cs (OverloadResolve): Report error only if Location
4552 is not 'Null' which means that there was a probe going on.
4554 2003-07-14 Martin Baulig <martin@ximian.com>
4556 * expression.cs (ConditionalLogicalOperator): New public class to
4557 implement user defined conditional logical operators.
4558 This is section 14.11.2 in the spec and bug #40505.
4560 2003-07-14 Martin Baulig <martin@ximian.com>
4562 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
4564 2003-07-14 Martin Baulig <martin@ximian.com>
4566 * codegen.cs (EmitContext.InFixedInitializer): New public field.
4568 * ecore.cs (IVariable.VerifyFixed): New interface method.
4570 * expression.cs (Unary.ResolveOperator): When resolving the `&'
4571 operator, check whether the variable is actually fixed. Fixes bug
4572 #36055. Set a variable definitely assigned when taking its
4573 address as required by the spec.
4575 * statement.cs (LocalInfo.IsFixed): New field.
4576 (LocalInfo.MakePinned): Set `IsFixed' to true.
4578 2003-07-14 Ravi Pratap M <ravi@ximian.com>
4580 * attribute.cs (Attribute.Resolve): While doing a Member lookup
4581 for .ctors, ensure that we only ask for members declared in the
4582 attribute type (BindingFlags.DeclaredOnly).
4586 * expression.cs (Error_WrongNumArguments): Report error 1501
4587 correctly the way CSC does.
4589 2003-07-13 Martin Baulig <martin@ximian.com>
4591 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
4592 lookup on the fully qualified name, to make things like "X.X" work
4593 where "X.X" is a fully qualified type name, but we also have a
4594 namespace "X" in the using list. Fixes #41975.
4596 2003-07-13 Martin Baulig <martin@ximian.com>
4598 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
4599 function. If we're a CompoundAssign, we need to create an embedded
4600 CompoundAssign, not an embedded Assign.
4601 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
4604 2003-07-13 Martin Baulig <martin@ximian.com>
4606 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
4607 work to fix bug #46088.
4609 2003-07-13 Ravi Pratap <ravi@ximian.com>
4611 * class.cs (Operator.Emit): Do not emit attributes here - it is
4612 taken care of by the Method class that we delegate too. This takes
4615 2003-07-10 Martin Baulig <martin@ximian.com>
4617 * expression.cs (TypeOfVoid): New class.
4618 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
4620 2003-07-10 Martin Baulig <martin@ximian.com>
4622 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
4625 2003-07-10 Martin Baulig <martin@ximian.com>
4627 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
4628 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
4630 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
4632 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
4634 2003-07-10 Martin Baulig <martin@ximian.com>
4636 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
4637 of decimal. Fixes #42850.
4639 NOTE: I also fixed the created byte blob, but this doesn't work on
4640 the MS runtime and csc never produces any byte blobs for decimal
4643 2003-07-10 Martin Baulig <martin@ximian.com>
4645 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
4646 structs; fixes #32068.
4647 (Block.AddChildVariableNames): Fixed #44302.
4649 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4651 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
4653 2003-07-07 Miguel de Icaza <miguel@ximian.com>
4655 * attribute.cs: And this test is onger needed.
4657 2003-07-08 Martin Baulig <martin@ximian.com>
4659 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
4660 inaccessible types. Fixes #36313.
4662 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
4664 * namespace.cs (NamespaceEntry): Create implicit entries for all
4665 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
4666 implicit entries for N1.N2 and N1.
4668 2003-07-08 Martin Baulig <martin@ximian.com>
4670 Rewrote the handling of namespaces to fix a lot of the issues
4671 wrt. `using' aliases etc.
4673 * namespace.cs (Namespace): Splitted this class into a
4674 per-assembly `Namespace' and a per-file `NamespaceEntry'.
4676 * typemanager.cs (TypeManager.IsNamespace): Removed.
4677 (TypeManager.ComputeNamespaces): Only compute namespaces from
4678 loaded assemblies here, not the namespaces from the assembly we're
4679 currently compiling.
4681 2003-07-08 Martin Baulig <martin@ximian.com>
4683 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
4685 2003-07-07 Miguel de Icaza <miguel@ximian.com>
4687 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
4690 I thought about the memory savings here, but LookupTypeReflection
4691 is used under already very constrained scenarios. Compiling
4692 corlib or mcs only exposes one hit, so it would not really reduce
4693 any memory consumption.
4695 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4697 * typemanager.cs: fixes bug #45889 by only adding public types from
4698 other assemblies to the list of known types.
4700 2003-07-07 Miguel de Icaza <miguel@ximian.com>
4702 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
4703 on the type we resolved.
4705 2003-07-05 Martin Baulig <martin@ximian.com>
4707 * pending.cs (PendingImplementation.ParentImplements): Don't
4708 create the proxy if the parent is abstract.
4710 * class.cs (TypeContainer.DefineIndexers): Process explicit
4711 interface implementations first. Fixes #37714.
4713 2003-07-04 Miguel de Icaza <miguel@ximian.com>
4715 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
4716 defined recursively; but since we modify the input parameters
4717 (left is set to `this' temporarily), we reset this value if the
4718 left_is_explicit is false, which gives the original semantics to
4721 * literal.cs (NullPointer): new class used to represent a null
4722 literal in a pointer context.
4724 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
4725 type is a pointer, use a NullPointer object instead of a
4726 NullLiteral. Closes 43687
4728 (ExplicitConversion): Convert pointer values using
4729 the conv opcode to the proper type.
4731 * ecore.cs (New): change ValueTypeVariable property into a method,
4732 that returns whether the valuetype is suitable for being used.
4734 * expression.cs (Binary.DoNumericPromotions): Only return if we
4735 the int constant was a valid uint, and we can return both left and
4736 right as uints. If not, we continue processing, to trigger the
4737 type conversion. This fixes 39018.
4739 * statement.cs (Block.EmitMeta): During constant resolution, set
4740 the CurrentBlock property on the emitcontext, so that we resolve
4741 constants propertly.
4743 2003-07-02 Martin Baulig <martin@ximian.com>
4745 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
4746 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
4748 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
4749 than emitting it here.
4751 * statement.cs: Fixed some more flow analysis bugs.
4753 2003-07-02 Martin Baulig <martin@ximian.com>
4755 * class.cs (MethodData.Define): When implementing interface
4756 methods, set Final unless we're Virtual.
4758 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
4759 check work for interface methods.
4761 2003-07-01 Martin Baulig <martin@ximian.com>
4763 * ecore.cs (EmitContext.This): Replaced this property with a
4764 GetThis() method which takes a Location argument. This ensures
4765 that we get the correct error location for a CS0188.
4767 2003-07-01 Miguel de Icaza <miguel@ximian.com>
4769 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
4770 ImplicitStandardConversion.
4772 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
4774 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
4776 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
4779 2003-06-30 Miguel de Icaza <miguel@ximian.com>
4781 * class.cs (Constructor.Define): Turn off initlocals for unsafe
4784 (MethodData.Define): Turn off initlocals for unsafe methods.
4786 2003-06-29 Miguel de Icaza <miguel@ximian.com>
4788 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
4789 complete; Fixes #37521.
4791 * delegate.cs: Use Modifiers.TypeAttr to compute the
4792 TypeAttributes, instead of rolling our own. This makes the flags
4793 correct for the delegates.
4795 2003-06-28 Miguel de Icaza <miguel@ximian.com>
4797 * class.cs (Constructor.Define): Set the private flag for static
4798 constructors as well.
4800 * cs-parser.jay (statement_expression): Set the return value to
4801 null, to avoid a crash when we catch an error.
4803 2003-06-24 Miguel de Icaza <miguel@ximian.com>
4805 * cs-parser.jay: Applied patch from Jackson that adds support for
4806 extern and unsafe modifiers to destructor declarations.
4808 * expression.cs: Report error 21 if the user is trying to index a
4811 * driver.cs: Add an error message, suggested by the bug report.
4813 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
4814 if we do not have a ": this ()" constructor initializer. Fixes 45149
4816 2003-06-14 Miguel de Icaza <miguel@ximian.com>
4818 * namespace.cs: Add some information to reduce FAQs.
4820 2003-06-13 Miguel de Icaza <miguel@ximian.com>
4822 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
4823 underlying enumeration types. Fixes #43915.
4825 * expression.cs: Treat ushort/short as legal values to be used in
4828 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
4830 * delegate.cs: transfer custom attributes for paramenters from
4831 the delegate declaration to Invoke and BeginInvoke.
4833 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
4835 * attribute.cs: handle custom marshalers and emit marshal info
4838 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
4840 * makefile.gnu: Added anonymous.cs to the compiler sources.
4842 2003-05-28 Miguel de Icaza <miguel@ximian.com>
4844 * iterators.cs: Change the name of the proxy class to include two
4847 * cs-parser.jay: Update grammar to include anonymous methods.
4849 * anonymous.cs: new file.
4851 2003-05-27 Miguel de Icaza <miguel@ximian.com>
4853 * class.cs (Field.Define): Add missing test for pointers and
4856 2003-05-27 Ravi Pratap <ravi@ximian.com>
4858 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
4859 we use the stobj opcode.
4861 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
4862 since it wasn't the correct fix.
4864 It still is puzzling that we are required to use stobj for IntPtr
4865 which seems to be a ValueType.
4867 2003-05-26 Miguel de Icaza <miguel@ximian.com>
4869 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
4870 during regular simple name resolution. Now, the trick is that
4871 instead of returning for processing the simplename, we do a
4872 TypeManager.LookupType (ie, a rooted lookup as opposed to a
4873 contextual lookup type). If a match is found, return that, if
4874 not, return for further composition.
4876 This fixes long-standing 30485.
4878 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
4879 using the address to initialize an object, do an Stobj instead of
4880 using the regular Stelem.
4882 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
4883 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
4884 Because if we are a BaseIndexerAccess that value will be true.
4887 * statement.cs (GotoCase.Resolve): Return after reporting an
4888 error, do not attempt to continue.
4890 * expression.cs (PointerArithmetic.Emit): If our operand is a
4891 long, convert our constants to match the operand before
4892 multiplying. Convert to I type before adding. Fixes 43670.
4894 2003-05-14 Ravi Pratap <ravi@ximian.com>
4896 * enum.cs (ImplicitConversionExists) : Rename to
4897 ImplicitEnumConversionExists to remove ambiguity.
4899 * ecore.cs (NullCast): New type of cast expression class which
4900 basically is very similar to EmptyCast with the difference being
4901 it still is a constant since it is used only to cast a null to
4905 * convert.cs (ImplicitReferenceConversion): When casting a null
4906 literal, we return a NullCast.
4908 * literal.cs (NullLiteralTyped): Remove - I don't see why this
4909 should be around anymore.
4911 The renaming (reported was slightly wrong). Corrections:
4913 ConvertImplicitStandard -> ImplicitConversionStandard
4914 ConvertExplicitStandard -> ExplicitConversionStandard
4916 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
4917 before passing them in !
4919 * convert.cs (ImplicitConversionStandard): When comparing for
4920 equal expr and target types, ensure that expr is not a
4923 In general, we must not be checking (expr_type ==
4924 target_type) in the top level conversion methods
4925 (ImplicitConversion, ExplicitConversion etc). This checking is
4926 done in the methods that they delegate to.
4928 2003-05-20 Miguel de Icaza <miguel@ximian.com>
4930 * convert.cs: Move Error_CannotConvertType,
4931 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
4932 ImplicitNumericConversion, ImplicitConversionExists,
4933 ImplicitUserConversionExists, StandardConversionExists,
4934 FindMostEncompassedType, FindMostSpecificSource,
4935 FindMostSpecificTarget, ImplicitUserConversion,
4936 ExplicitUserConversion, GetConversionOperators,
4937 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
4938 TryImplicitIntConversion, Error_CannotConvertImplicit,
4939 ConvertImplicitRequired, ConvertNumericExplicit,
4940 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
4941 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
4944 Perform the following renames:
4946 StandardConversionExists -> ImplicitStandardConversionExists
4947 ConvertImplicit -> ImplicitConversion
4948 ConvertImplicitStandard -> ImplicitStandardConversion
4949 TryImplicitIntConversion -> ImplicitIntConversion
4950 ConvertImplicitRequired -> ImplicitConversionRequired
4951 ConvertNumericExplicit -> ExplicitNumericConversion
4952 ConvertReferenceExplicit -> ExplicitReferenceConversion
4953 ConvertExplicit -> ExplicitConversion
4954 ConvertExplicitStandard -> ExplicitStandardConversion
4956 2003-05-19 Martin Baulig <martin@ximian.com>
4958 * statement.cs (TypeInfo.StructInfo): Made this type protected.
4959 (TypeInfo): Added support for structs having structs as fields.
4961 * ecore.cs (FieldExpr): Implement IVariable.
4962 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
4963 VariableInfo for the field.
4965 2003-05-18 Martin Baulig <martin@ximian.com>
4967 * expression.cs (This.DoResolve): Report a CS0027 if we're
4968 emitting a field initializer.
4970 2003-05-18 Martin Baulig <martin@ximian.com>
4972 * expression.cs (This.ResolveBase): New public function.
4973 (This.DoResolve): Check for CS0188.
4975 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
4978 * ecore.cs (MethodGroupExpr.DoResolve): Set the
4979 `instance_expression' to null if we don't have any non-static
4982 2003-05-18 Martin Baulig <martin@ximian.com>
4984 Reworked the way how local variables and parameters are handled by
4985 the flow analysis code.
4987 * statement.cs (TypeInfo, VariableMap): New public classes.
4988 (VariableInfo): New public class. This is now responsible for
4989 checking whether a variable has been assigned. It is used for
4990 parameters and local variables.
4991 (Block.EmitMeta): Take the InternalParameters as argument; compute
4992 the layout of the flow vectors here.
4993 (Block.LocalMap, Block.ParameterMap): New public properties.
4994 (FlowBranching): The .ctor doesn't get the InternalParameters
4995 anymore since Block.EmitMeta() now computes the layout of the flow
4997 (MyStructInfo): This class is now known as `StructInfo' and nested
4998 in `TypeInfo'; we don't access this directly anymore.
5000 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
5001 property and removed IsAssigned(), IsFieldAssigned(),
5002 SetAssigned() and SetFieldAssigned(); we now call them on the
5003 VariableInfo so we don't need to duplicate this code everywhere.
5005 * expression.cs (ParameterReference): Added `Block block' argument
5007 (LocalVariableReference, ParameterReference, This): The new
5008 VariableInfo class is now responsible for all the definite
5011 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
5012 IsParameterAssigned, SetParameterAssigned): Removed.
5014 2003-05-18 Martin Baulig <martin@ximian.com>
5016 * typemanager.cs (InitCoreTypes): Try calling
5017 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
5018 the 3-args-version. Corlib now also needs our `void_type'.
5019 (GetMethod): Added overloaded version which takes an optional
5020 `bool report_errors' to allow lookups of optional methods.
5022 2003-05-12 Martin Baulig <martin@ximian.com>
5024 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
5025 only used for locals and not for parameters.
5027 2003-05-12 Miguel de Icaza <miguel@ximian.com>
5029 * support.cs (InternalParameters.ParameterType): Return the
5030 ExternalType of the parameter.
5032 * parameter.cs (Parameter.ExternalType): drop the two arguments,
5035 2003-05-11 Miguel de Icaza <miguel@ximian.com>
5037 * class.cs (MethodData.Define): Do not set the `newslot' on
5038 interface members, if they are also flagged as "override".
5040 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
5041 better code for ++i and i++. This only works for static fields
5042 and local variables.
5044 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
5045 want to pull the DeclSpace out of the builder_to_declspace instead
5046 of the TypeBuilder (like in TypeContainer.FindMembers).
5048 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
5049 instead of LookupTypeContainer. Fixes the crash on .NET for
5050 looking up interface members.
5052 * const.cs: Create our own emit context during the Definition
5053 stage, so that constants are evaluated in the proper context, when
5054 a recursive definition happens.
5056 2003-05-11 Martin Baulig <martin@ximian.com>
5058 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
5059 new block for a switch section.
5060 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
5061 the adding/lookup in the switch block. Fixes #39828.
5063 2003-05-09 Miguel de Icaza <miguel@ximian.com>
5065 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
5066 functionality: I needed to convert the data after I had performed
5067 the add/sub operation into the operands type size.
5069 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
5070 pass the type for the box operation, otherwise the resulting
5071 object would have been of type object.
5073 (BoxedCast): Add constructor to specify the type to box as.
5075 2003-05-07 Miguel de Icaza <miguel@ximian.com>
5077 * iterators.cs: I was reusing the `count' variable inadvertently,
5078 take steps to not allow this to happen.
5080 2003-05-06 Miguel de Icaza <miguel@ximian.com>
5082 * attribute.cs (Attribute.Resolve): Params attributes are encoded
5083 by creating an array at the point where the params starts and
5084 putting all those arguments there, then adjusting the size of the
5087 2003-05-05 Miguel de Icaza <miguel@ximian.com>
5089 * expression.cs (New.AddressOf): Implement interface
5090 IMemoryLocation. This is used when the `new' operator is used in
5091 the context of an invocation to a method on a value type.
5093 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
5096 * namespace.cs: Also check the using aliases here.
5098 * driver.cs: Move the test for using validity after the types have
5099 been entered, so we do a single pass that also includes the using
5102 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
5103 in the regular case. CreateSiblingForFinally is doing extra
5106 * attribute.cs (GetAttributeArgumentExpression): Store the result
5107 on an out value, and use the return value to indicate failure
5108 instead of using null (which is a valid return for Constant.GetValue).
5110 * statement.cs: Perform the analysis flow for the increment
5111 portion after the statement, because this will be the real flow of
5112 execution. Fixes #42385
5114 * codegen.cs (EmitContext.EmitArgument,
5115 EmitContext.EmitStoreArgument): New helper functions when the
5116 RemapToProxy flag is set.
5118 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
5121 Add support for remapping parameters.
5123 * iterators.cs: Propagate parameter values; Store parameter
5124 values in the proxy classes.
5126 2003-05-04 Miguel de Icaza <miguel@ximian.com>
5128 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
5129 need a proxy reference; I do not know what I was thinking
5131 * cs-parser.jay (constructor_initializer): catch another error,
5132 and display nice message.
5134 (field_declaration): catch void field declaration
5135 to flag a better error.
5137 * class.cs (MemberBase.CheckBase): Report an error instead of a
5138 warning if a new protected member is declared in a struct.
5139 (Field.Define): catch the error of readonly/volatile.
5141 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
5143 (FieldExpr.AddressOf): ditto. Catch error where the address of a
5144 volatile variable is taken
5146 2003-05-02 Miguel de Icaza <miguel@ximian.com>
5148 * statement.cs (Fixed.Resolve): Report an error if we are not in
5151 2003-05-01 Miguel de Icaza <miguel@ximian.com>
5153 * typemanager.cs: reuse the code that handles type clashes for
5154 delegates and enumerations.
5156 * class.cs (Report28): Always report.
5158 * expression.cs (EncodeAsAttribute): Allow nulls here.
5160 2003-04-28 Miguel de Icaza <miguel@ximian.com>
5162 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
5163 the functionality for testing whether an expression is valid for
5164 an attribute here. Also handle the case of arrays of elements
5167 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
5168 encoding a linear array into an array of objects that are suitable
5169 to be passed to an CustomAttributeBuilder.
5171 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
5173 * ecore.cs: (FieldExpr): Handle field remapping here.
5175 * iteratators.cs: Pass the instance variable (if the method is an
5176 instance method) to the constructors, so we can access the field
5177 variables on the class.
5179 TODO: Test this with structs. I think the THIS variable on
5180 structs might have to be a pointer, and not a refenrece
5182 2003-04-27 Miguel de Icaza <miguel@ximian.com>
5184 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
5185 local variables to fields in a proxy class.
5187 * iterators.cs (PopulateProxy): Rename our internal fields to
5189 Create a <THIS> field if we are an instance method, so we can
5190 reference our parent container variables.
5191 (MapVariable): Called back from the EmitContext code to enter a
5192 new variable to field mapping into the proxy class (we just create
5196 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
5197 for using the remapped locals to fields.
5199 I placed the code here, because that gives the same semantics to
5200 local variables, and only changes the Emit code.
5202 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
5203 statements inside iterators.
5204 (VariableInfo): Add a FieldBuilder for the cases when we are
5205 remapping local variables to fields in a proxy class
5207 * ecore.cs (SimpleNameResolve): Avoid testing two times for
5208 current_block != null.
5210 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
5211 not cope with strings, as it has been moved to the
5212 TableSwitchEmit. Fixed bug in switch generation.
5214 * expression.cs (New.DoResolve): Provide more context for the user
5215 when reporting an error.
5217 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
5220 * expression.cs (MemberAccess.DoResolve): When we get a type back,
5221 check the permissions for it. Note than in a type-resolution
5222 context the check was already present in DeclSpace.ResolveType,
5223 but was missing from the MemberAccess.
5225 (ArrayCreation.CheckIndices): warn if the user has
5226 more nested levels of expressions, but there are no more
5227 dimensions specified. Avoids crash on bug 41906.
5229 2003-04-26 Miguel de Icaza <miguel@ximian.com>
5231 * statement.cs (Block): replace Implicit bool, for a generic
5233 New flag: `Unchecked'. This is used during the EmitMeta phase
5234 (which is out-of-line with the regular Resolve/Emit process for a
5235 statement, as this is done ahead of time, but still gets a chance
5236 to call constant resolve).
5238 (Block.Flags): new enum for adding a new flag.
5240 (Block.EmitMeta): track the state of unchecked.
5242 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
5243 to enable constant resolution to work there as well.
5245 2003-04-22 Miguel de Icaza <miguel@ximian.com>
5247 * typemanager.cs (ienumerable_type): Also look up
5248 System.Collections.IEnumerable.
5250 2003-04-21 Miguel de Icaza <miguel@ximian.com>
5252 TODO: Test more than one conditional per method.
5254 * class.cs (Indexer.Define): Report the location where the user is
5255 referencing the unsupported feature.
5257 (MethodData): Overload the use of `conditionals' to
5258 minimize the creation of needless ArrayLists. This saves roughly
5259 212kb on my machine.
5261 (Method): Implement the new IIteratorContainer interface.
5262 (Method.SetYields): Implement the method by setting the ModFlags
5263 to contain METHOD_YIELDS.
5265 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
5266 which just got set to null.
5268 * iterators.cs: New file.
5270 (Yield, YieldBreak): New statements.
5272 * statement.cs (Return.Resolve): Flag an error if we are used in
5275 * codegen.cs (InIterator): New flag set if the code is being
5276 compiled in an iterator method.
5278 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
5279 internal modifier, and we just use it to avoid adding extra
5280 fields, as this is seldom used.
5282 * cs-parser.jay: Add yield_statement (yield and yield break).
5284 * driver.cs: New flag -v2 to turn on version 2 features.
5286 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
5287 hashtable when v2 is enabled.
5289 2003-04-20 Miguel de Icaza <miguel@ximian.com>
5291 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
5292 there is already a namespace defined with this name.
5294 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
5295 people upgraded their corlibs.
5297 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
5298 always use fully qualified types, no need to use the compiler
5301 (TypeManager.IsNamespace): Use binarysearch.
5303 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
5304 AddDelegate): I did not quite use the new IsValid API properly: I
5305 have to pass the short-name and the fullname. I was passing only
5306 the basename instead of the fullname sometimes.
5308 (TypeContainer.DefineType): call NamespaceClash.
5310 * interface.cs (Interface.DefineType): use NamespaceClash before
5313 * delegate.cs (Delegate.DefineType): use NamespaceClash before
5316 * enum.cs: (Enum.DefineType): use NamespaceClash before
5319 * typemanager.cs (: 3-line patch that gives us some tasty 11%
5320 speed increase. First, use the negative_hits cache when we get a
5321 negative. Second, add the type with its full original name
5322 instead of the new . and + encoded name (reflection uses + to
5323 separate type from a nested type). Use LookupTypeReflection
5324 directly which bypasses the type->name hashtable (that we already
5325 know does not contain the type.
5327 * decl.cs (DeclSpace.ResolveTypeExpr): track the
5328 location/container type.
5330 * driver.cs: When passing utf8, use directly the UTF8Encoding.
5332 2003-04-19 Miguel de Icaza <miguel@ximian.com>
5334 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
5336 * delegate.cs (NewDelegate.Resolve): Test whether an instance
5337 method is being referenced in the method group from a static
5338 context, and report error 120 if so.
5340 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
5343 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
5344 is created, we create the A namespace).
5346 * cs-parser.jay: A namespace also introduces a DeclarationFound.
5349 2003-04-18 Miguel de Icaza <miguel@ximian.com>
5351 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
5352 invocation to ModuleBuilder.GetType with the same values will
5353 return a new type instance, so we need to cache its return
5356 * expression.cs (Binary.ResolveOperator): Only allow the compare
5357 operators on enums if they are of the same type.
5359 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
5360 types of ValueType on their own case. Before we were giving them
5361 the same treatment as objects.
5363 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
5364 fullname. Short name is used to compare against container name.
5365 Fullname is used to check against defined namespace names.
5367 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
5368 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
5370 (Method.CheckBase): Call parent.
5371 (MemberBase.CheckBase): Check for protected members on sealed
5373 (PropertyBase.CheckBase): Call parent.
5374 (Field.Define): Call parent.
5376 * report.cs: Negative error codes are now mapped to 8000 - code,
5377 so that the display is render more nicely.
5379 * typemanager.cs: Do not use try/catch, instead report a regular
5382 (GetPointerType, GetReferenceType): These methods provide
5383 mechanisms to obtain the T* and T& from a T. We had the code
5384 previously scattered around the code base, and it also used
5385 TypeManager.LookupType that would go through plenty of caches.
5386 This one goes directly to the type source.
5388 In some places we did the Type.GetType followed by
5389 ModuleBuilder.GetType, but not in others, so this unifies the
5392 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
5393 statements now that we have namespace information.
5395 * typemanager.cs (IsNamespace): New method, returns whether the
5396 string presented is a namespace or not.
5398 (ComputeNamespaces): New public entry point, computes the list of
5399 available namespaces, using the GetNamespaces API call in Mono, or
5400 the slower version in MS.NET.
5402 Now before we start the semantic analysis phase, we have a
5403 complete list of namespaces including everything that the user has
5406 Deleted old code to cache namespaces in .nsc files.
5408 2003-04-17 Miguel de Icaza <miguel@ximian.com>
5410 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
5411 class/struct location definition Location for the implicit
5412 constructor location.
5414 (Operator.Define): Use the location of the operator for the
5415 implicit Method definition.
5417 (Constructor.Emit): use the constructor location for the implicit
5418 base initializer constructor.
5420 * ecore.cs: Remove ITypeExpression. This interface is now gone,
5421 and the Expression class now contains two new methods:
5423 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
5424 isolate type lookup from the rest of the resolution process.
5426 Since we use Expressions to hold type definitions due to the way
5427 we parse the input we have historically overloaded Resolve to
5428 perform the Type lookups if a special flag is passed. Now this is
5429 eliminated and two methods take their place.
5431 The differences in the two methods between xStep and xTerminal is
5432 that xStep is involved in our current lookup system that uses
5433 SimpleNames to compose a name, while xTerminal is used just to
5434 catch the case where the simplename lookup failed.
5436 2003-04-16 Miguel de Icaza <miguel@ximian.com>
5438 * expression.cs (ResolveMemberAccess): Remove redundant code.
5439 TypeExpr expressions are always born fully resolved.
5441 * interface.cs (PopulateMethod): Do not lookup the types twice.
5442 We were doing it once during SemanticAnalysis and once during
5445 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
5446 in local variable type definitions, were being returned as a
5447 SimpleName (we decomposed everything into a string), that is
5448 because primary_expression was being used instead of a type in the
5449 grammar (reduce/reduce conflicts).
5451 The part that was wrong is that we converted the expression into a
5452 string (an oversimplification in one hand, compounded with primary
5453 expressions doing string concatenation).
5459 Would return "A.B.C[]" as a SimpleName. This stopped things like
5460 using clauses from working on this particular context. And a type
5461 was being matched directly against "A.B.C[]".
5463 We now use the correct approach, and allow for ComposedCast to be
5464 part of the unary expression. So the "A.B.C []" become a composed
5465 cast of "A.B.C" (as a nested group of MemberAccess with a
5466 SimpleName at the end) plus the rank composition "[]".
5470 2003-04-10 Miguel de Icaza <miguel@ximian.com>
5472 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
5473 for the access level checking.
5475 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
5476 `TypeContainer container', because I kept getting confused when I
5477 was debugging this code.
5479 * expression.cs (Indexers): Instead of tracking getters/setters,
5480 we now track them in parallel. We create one arraylist less, but
5481 most importantly it is possible now for the LValue code to find a
5482 matching get for a set.
5484 (IndexerAccess.DoResolveLValue): Update the code.
5485 GetIndexersForType has been modified already to extract all the
5486 indexers from a type. The code assumed it did not.
5488 Also make the code set the correct return type for the indexer.
5489 This was fixed a long time ago for properties, but was missing for
5490 indexers. It used to be void_type.
5492 (Binary.Emit): Test first for doubles instead of
5493 floats, as they are more common.
5495 (Binary.EmitBranchable): Use the .un version of the branch opcodes
5496 when dealing with floats and the <=, >= operators. This fixes bug
5499 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
5500 to load the array value by emitting a load on the foreach variable
5501 type. This was incorrect.
5503 We now emit the code to load an element using the the array
5504 variable type, and then we emit the conversion operator.
5508 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
5510 * attribute.cs: Avoid allocation of ArrayLists in the common case.
5512 2003-04-09 Miguel de Icaza <miguel@ximian.com>
5514 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
5515 test for protection before we test for signatures.
5517 (MethodSignature.ToString): implement.
5519 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
5520 to the case where we reduced into a LongConstant.
5522 * decl.cs (CheckAccessLevel): If the type is an array, we can not
5523 depend on whether the information is acurrate, because the
5524 Microsoft runtime will always claim that the array type is public,
5525 regardless of the real state.
5527 If the type is a pointer, another problem happens: the type is
5528 reported as non-public in Microsoft.
5530 In both cases we have to call CheckAccessLevel recursively with
5531 the underlying type as the argument to be tested.
5533 2003-04-08 Miguel de Icaza <miguel@ximian.com>
5535 * assign.cs (Assign.Emit): If we are dealing with a compound
5536 assignment expression, we should use the code path that stores the
5537 intermediate result in a temporary value. This fixes #40903.
5539 *expression.cs (Indirection.ToString): Provide ToString method for
5542 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
5544 * class.cs: Null out fields holding references to Block objects so
5545 they can be garbage collected.
5547 * expression.cs (OverloadResolve): Remove unused local.
5549 2003-04-07 Martin Baulig <martin@ximian.com>
5551 * codegen.cs (EmitContext.CurrentFile): New public field.
5552 (EmitContext.Mark): Use the CurrentFile to check whether the
5553 location is in the correct file.
5554 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
5556 2003-04-07 Martin Baulig <martin@ximian.com>
5558 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
5560 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
5561 location. [FIXME: The location argument which gets passed to this
5562 method is sometimes wrong!]
5564 2003-04-07 Nick Drochak <ndrochak@gol.com>
5566 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
5568 2003-04-07 Miguel de Icaza <miguel@ximian.com>
5570 * expression.cs (Indirection.EmitAssign): We were using the
5571 temporary, but returning immediately instead of continuing the
5574 2003-04-06 Martin Baulig <martin@ximian.com>
5576 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
5577 if it's a nested child, but also deriving from the outer class.
5580 * typemanager.cs (IsNestedChildOf): Make this work if it's a
5581 nested child, but also deriving from the outer class. See
5583 (FilterWithClosure): We may access private members of the outer
5584 class if we're a nested child and deriving from the outer class.
5585 (RealMemberLookup): Only set `closure_private_ok' if the
5586 `original_bf' contained BindingFlags.NonPublic.
5588 2003-04-05 Martin Baulig <martin@ximian.com>
5590 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
5592 2003-04-02 Miguel de Icaza <miguel@ximian.com>
5594 * class.cs (Event.Define): Do not allow abstract events to have
5597 2003-04-01 Miguel de Icaza <miguel@ximian.com>
5599 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
5600 block in event declarations.
5602 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
5603 value type, get its address.
5605 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
5606 leaving a class on the stack instead of a boolean value (int
5607 0/1). Change the code so we compare against null, and then the
5608 result against zero.
5610 * class.cs (TypeContainer.GetClassBases): We were checking for the
5611 parent class being sealed too late.
5613 * expression.cs (Binary.Emit): For <= and >= when dealing with
5614 floating point values, use cgt.un and clt.un instead of cgt and
5617 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
5619 * statement.cs: Apply the same optimization as MS: skip the
5620 GetEnumerator returning an IEnumerator, and use the one returning a
5621 CharEnumerator instead. This allows us to avoid the try-finally block
5624 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
5626 * cs-parser.jay: Attributes cannot be applied to
5627 namespaces. Fixes #40473
5629 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5632 (Add*): check if the name is valid using the full name for constants,
5633 fields, properties and events.
5635 2003-03-28 Miguel de Icaza <miguel@ximian.com>
5637 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
5638 char constants to be part of the enumeration.
5640 * expression.cs (Conditional.DoResolve): Add support for operator
5641 true. Implements the missing functionality from 14.12
5643 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
5644 operator true/false as required by the spec.
5646 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
5647 implicit conversion to boolean.
5649 * statement.cs (Statement.ResolveBoolean): A boolean expression is
5650 also one where the type implements `operator true'.
5652 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
5653 get an expression that will invoke operator true based on an
5656 (GetConversionOperators): Removed the hack that called op_True
5659 (Expression.ResolveBoolean): Move this from Statement.
5661 2003-03-17 Miguel de Icaza <miguel@ximian.com>
5663 * ecore.cs (FieldExpr): do not allow initialization of initonly
5664 fields on derived classes
5666 2003-03-13 Martin Baulig <martin@ximian.com>
5668 * statement.cs (Block.Emit): Call ig.BeginScope() and
5669 ig.EndScope() when compiling with debugging info; call
5670 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
5672 2003-03-08 Miguel de Icaza <miguel@ximian.com>
5674 * expression.cs (Indexers): Do not construct immediately, allow
5675 for new members to be appended as we go. Fixes 38143
5677 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5679 * expression.cs: save/restore context when resolving an unchecked
5682 2003-03-05 Miguel de Icaza <miguel@ximian.com>
5684 * cfold.cs: Catch division by zero in modulus operator during
5687 2003-03-03 Miguel de Icaza <miguel@ximian.com>
5689 * interface.cs (Interface.DefineMembers): Avoid defining members
5692 2003-02-27 Miguel de Icaza <miguel@ximian.com>
5694 * driver.cs: handle the +/- options for -noconfig
5696 * statement.cs (Unckeched.Resolve): Also track the state of
5697 unchecked in the Resolve phase.
5699 2003-02-27 Martin Baulig <martin@ximian.com>
5701 * ecore.cs (Expression.MemberLookup): Don't create a
5702 MethodGroupExpr for something which is not a method. Fixes #38291.
5704 2003-02-25 Miguel de Icaza <miguel@ximian.com>
5706 * class.cs (MemberBase.CheckParameters): Also check that the type
5707 is unmanaged if it is a pointer.
5709 * expression.cs (SizeOf.Resolve): Add location information.
5711 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
5712 a managed type is declared.
5714 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
5715 parameter modifiers as well. Fixes bug 38606
5717 * class.cs: Very sad. Am backing out the speed up changes
5718 introduced by the ArrayList -> Array in the TypeContainer, as they
5719 were not actually that much faster, and introduced a bug (no error
5720 reports on duplicated methods).
5722 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
5723 source first, this will guarantee that we have a valid expression
5724 before calling in lower levels functions that will require a
5725 resolved object. Then use this original_source in the
5726 target.ResolveLValue instead of the original source that was
5729 Another change. Use target.Resolve instead of LValueResolve.
5730 Although we are resolving for LValues, we will let the Assign code
5731 take care of that (it will be called again from Resolve). This
5732 basically allows code like this:
5734 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
5735 class Y { void A (X x) { x [0] += o; }
5737 The problem was that the indexer was trying to resolve for
5738 set_Item (idx, object o) and never finding one. The real set_Item
5739 was set_Item (idx, X). By delaying the process we get the right
5744 2003-02-23 Martin Baulig <martin@ximian.com>
5746 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
5747 while calling DoEmit ().
5749 * codegen.cs (EmitContext.Mark): Don't mark locations in other
5750 source files; if you use the #line directive inside a method, the
5751 compiler stops emitting line numbers for the debugger until it
5752 reaches the end of the method or another #line directive which
5753 restores the original file.
5755 2003-02-23 Martin Baulig <martin@ximian.com>
5757 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
5759 2003-02-23 Martin Baulig <martin@ximian.com>
5761 * statement.cs (Block.AddChildVariableNames): We need to call this
5762 recursively, not just for our immediate children.
5764 2003-02-23 Martin Baulig <martin@ximian.com>
5766 * class.cs (Event.Define): Always make the field private, like csc does.
5768 * typemanager.cs (TypeManager.RealMemberLookup): Make events
5769 actually work, fixes bug #37521.
5771 2003-02-23 Miguel de Icaza <miguel@ximian.com>
5773 * delegate.cs: When creating the various temporary "Parameters"
5774 classes, make sure that we call the ComputeAndDefineParameterTypes
5775 on those new parameters (just like we do with the formal ones), to
5776 allow them to be resolved in the context of the DeclSpace.
5778 This fixes the bug that Dick observed in Bugzilla #38530.
5780 2003-02-22 Miguel de Icaza <miguel@ximian.com>
5782 * expression.cs (ResolveMemberAccess): When resolving a constant,
5783 do not attempt to pull a constant if the value was not able to
5784 generate a valid constant.
5786 * const.cs (LookupConstantValue): Do not report more errors than required.
5788 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5790 * expression.cs: fixes bug #38328.
5792 2003-02-18 Miguel de Icaza <miguel@ximian.com>
5794 * class.cs: Changed all the various members that can be part of a
5795 class from being an ArrayList to be an Array of the right type.
5796 During the DefineType type_list, interface_list, delegate_list and
5797 enum_list are turned into types, interfaces, delegates and enums
5800 And during the member population, indexer_list, event_list,
5801 constant_list, field_list, instance_constructor_list, method_list,
5802 operator_list and property_list are turned into their real arrays.
5804 Although we could probably perform this operation earlier, for
5805 good error reporting we need to keep the lists and remove the
5806 lists for longer than required.
5808 This optimization was triggered by Paolo profiling the compiler
5809 speed on the output of `gen-sample-program.pl' perl script.
5811 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
5812 not crash in methods like MemberLookupFailed that use this field.
5814 This problem arises when the compiler fails to resolve a type
5815 during interface type definition for example.
5817 2003-02-18 Miguel de Icaza <miguel@ximian.com>
5819 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
5820 inherit from System.Object, so we have to stop at null, not only
5821 when reaching System.Object.
5823 2003-02-17 Miguel de Icaza <miguel@ximian.com>
5825 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
5826 DeclaredOnly because the parent indexer might have had a different
5827 name, but did not loop until the top of the hierarchy was reached.
5829 The problem this one fixes is 35492: when a class implemented an
5830 indexer from an interface, we were getting the interface method
5831 (which was abstract) and we were flagging an error (can not invoke
5834 This also keeps bug 33089 functioning, and test-148 functioning.
5836 * typemanager.cs (IsSpecialMethod): The correct way of figuring
5837 out if a method is special is to see if it is declared in a
5838 property or event, or whether it is one of the predefined operator
5839 names. This should fix correctly #36804.
5841 2003-02-15 Miguel de Icaza <miguel@ximian.com>
5843 The goal here is to remove the dependency on EmptyCast.Peel ().
5844 Killing it completely.
5846 The problem is that currently in a number of places where
5847 constants are expected, we have to "probe" for an EmptyCast, and
5848 Peel, which is not the correct thing to do, as this will be
5849 repetitive and will likely lead to errors.
5851 The idea is to remove any EmptyCasts that are used in casts that
5852 can be reduced to constants, so we only have to cope with
5855 This bug hunt was triggered by Bug 37363 and the desire to remove
5856 the duplicate pattern where we were "peeling" emptycasts to check
5857 whether they were constants. Now constants will always be
5860 * ecore.cs: Use an enumconstant here instead of wrapping with
5863 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
5864 throwing me off. By handling this we can get rid of a few hacks.
5866 * statement.cs (Switch): Removed Peel() code.
5868 2003-02-14 Miguel de Icaza <miguel@ximian.com>
5870 * class.cs: Location information for error 508
5872 * expression.cs (New.DoResolve): Add a guard against double
5873 resolution of an expression.
5875 The New DoResolve might be called twice when initializing field
5876 expressions (see EmitFieldInitializers, the call to
5877 GetInitializerExpression will perform a resolve on the expression,
5878 and later the assign will trigger another resolution
5880 This leads to bugs (#37014)
5882 * delegate.cs: The signature for EndInvoke should contain any ref
5883 or out parameters as well. We were not doing this in the past.
5885 * class.cs (Field.Define): Do not overwrite the type definition
5886 inside the `volatile' group. Turns out that volatile enumerations
5887 were changing the type here to perform a validity test, which
5890 2003-02-12 Miguel de Icaza <miguel@ximian.com>
5892 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
5893 and structs, we do not want to load the instance variable
5895 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
5896 enum_type has to be handled like an object reference (implicit
5897 conversions exists from this to object), but the regular IsClass
5898 and IsValueType tests will never return true for this one.
5900 Also we use TypeManager.IsValueType instead of type.IsValueType,
5901 just for consistency with the rest of the code (this is only
5902 needed if we ever use the construct exposed by test-180.cs inside
5903 corlib, which we dont today).
5905 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
5907 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
5910 2003-02-09 Martin Baulig <martin@ximian.com>
5912 * namespace.cs (Namespace..ctor): Added SourceFile argument.
5913 (Namespace.DefineNamespaces): New static public method; this is
5914 called when we're compiling with debugging to add all namespaces
5917 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
5918 pass it to the Namespace's .ctor.
5920 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
5921 and MethodBase arguments; pass the namespace ID to the symwriter;
5922 pass the MethodBase instead of the token to the symwriter.
5923 (SymbolWriter.DefineNamespace): New method to add a namespace to
5926 2003-02-09 Martin Baulig <martin@ximian.com>
5928 * symbolwriter.cs: New file. This is a wrapper around
5929 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
5930 methods here in near future.
5932 2003-02-09 Martin Baulig <martin@ximian.com>
5934 * codegen.cs (EmitContext.Mark): Just pass the arguments to
5935 ILGenerator.MarkSequencePoint() which are actually used by the
5938 2003-02-09 Martin Baulig <martin@ximian.com>
5940 * location.cs (SourceFile): New public sealed class. This
5941 contains the name and an index which is used in the location's token.
5942 (Location): Reserve an appropriate number of bits in the token for
5943 the source file instead of walking over that list, this gives us a
5944 really huge performance improvement when compiling with debugging.
5946 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
5947 `SourceFile' argument instead of a string.
5948 (Driver.ProcessFile): Add all the files via Location.AddFile(),
5949 but don't parse/tokenize here, we need to generate the list of all
5950 source files before we do that.
5951 (Driver.ProcessFiles): New static function. Parses/tokenizes all
5954 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
5955 instead of a string.
5957 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
5960 2003-02-09 Martin Baulig <martin@ximian.com>
5962 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
5963 filename on `#line default'.
5965 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
5967 * statement.cs: don't clear the pinned var when the fixed statement
5968 returns from the method (fixes bug#37752).
5970 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
5972 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
5975 2003-02-07 Martin Baulig <martin@ximian.com>
5977 * driver.cs: Removed the `--debug-args' command line argument.
5979 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
5980 automatically by the AsssemblyBuilder.
5981 (CodeGen.InitializeSymbolWriter): We don't need to call any
5982 initialization function on the symbol writer anymore. This method
5983 doesn't take any arguments.
5985 2003-02-03 Miguel de Icaza <miguel@ximian.com>
5987 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
5988 from referenced assemblies as well.
5990 2003-02-02 Martin Baulig <martin@ximian.com>
5992 * class.cs (MethodData.Emit): Generate debugging info for external methods.
5994 2003-02-02 Martin Baulig <martin@ximian.com>
5996 * class.cs (Constructor.Emit): Open the symbol writer before
5997 emitting the constructor initializer.
5998 (ConstructorInitializer.Emit): Call ec.Mark() to allow
5999 single-stepping through constructor initializers.
6001 2003-01-30 Miguel de Icaza <miguel@ximian.com>
6003 * class.cs: Handle error 549: do not allow virtual methods in
6006 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
6008 * decl.cs: Check access levels when resolving types
6010 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
6012 * statement.cs: Add parameters and locals set in catch blocks that might
6013 return to set vector
6015 2003-01-29 Miguel de Icaza <miguel@ximian.com>
6017 * class.cs (Operator): Set the SpecialName flags for operators.
6019 * expression.cs (Invocation.DoResolve): Only block calls to
6020 accessors and operators on SpecialName methods.
6022 (Cast.TryReduce): Handle conversions from char constants.
6025 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
6027 * statement.cs: small memory and time optimization in FlowBranching.
6029 2003-01-28 Pedro Mart <yoros@wanadoo.es>
6031 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
6032 problem that the last fix but in the other sid (Set).
6034 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
6035 access when there is no indexer in the hierarchy.
6037 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
6039 * class.cs: Combine some if statements.
6041 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6043 * driver.cs: fixed bug #37187.
6045 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
6047 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
6048 any indexer, it's needed to build a list with all the indexers in the
6049 hierarchy (AllGetters), else we have problems. Fixes #35653.
6051 2003-01-23 Miguel de Icaza <miguel@ximian.com>
6053 * class.cs (MethodData.Define): It is wrong for an interface
6054 implementation to be static in both cases: explicit and implicit.
6055 We were only handling this in one case.
6057 Improve the if situation there to not have negations.
6059 * class.cs (Field.Define): Turns out that we do not need to check
6060 the unsafe bit on field definition, only on usage. Remove the test.
6062 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6064 * driver.cs: use assembly.Location instead of Codebase (the latest
6065 patch made mcs fail when using MS assemblies).
6067 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
6069 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
6070 get the path to *corlib.dll.
6072 2003-01-21 Nick Drochak <ndrochak@gol.com>
6076 * typemanager.cs: Remove compiler warnings
6078 2003-01-20 Duncan Mak <duncan@ximian.com>
6080 * AssemblyInfo.cs: Bump the version number to 0.19.
6082 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6084 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
6086 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
6088 * class.cs (Constructor::Emit): Emit debugging info for constructors.
6090 2003-01-17 Miguel de Icaza <miguel@ximian.com>
6092 * cs-parser.jay: Small fix: we were not comparing the constructor
6093 name correctly. Thanks to Zoltan for the initial pointer.
6095 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
6097 * cs-tokenizer.cs: Set file name when specified with #line
6099 2003-01-15 Miguel de Icaza <miguel@ximian.com>
6101 * cs-parser.jay: Only perform the constructor checks here if we
6102 are named like the class; This will help provider a better
6103 error. The constructor path is taken when a type definition is
6104 not found, but most likely the user forgot to add the type, so
6105 report that rather than the constructor error.
6107 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
6109 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
6112 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
6114 * cs-parser.jay: Add cleanup call.
6116 2003-01-13 Duncan Mak <duncan@ximian.com>
6118 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
6119 consistent with other methods.
6121 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
6123 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
6125 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
6127 * attribute.cs: only set GuidAttr to true when we have a
6130 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6134 * typemanager.cs: fixes to allow mcs compile corlib with the new
6135 Type.IsSubclassOf fix.
6137 2003-01-08 Miguel de Icaza <miguel@ximian.com>
6139 * expression.cs (LocalVariableReference.DoResolve): Classify a
6140 constant as a value, not as a variable. Also, set the type for
6143 * cs-parser.jay (fixed_statement): take a type instead of a
6144 pointer_type, so we can produce a better error message later.
6146 * statement.cs (Fixed.Resolve): Flag types that are not pointers
6149 (For.DoEmit): Make inifinite loops have a
6150 non-conditional branch back.
6152 (Fixed.DoEmit): First populate the pinned variables, then emit the
6153 statement, then clear the variables. Before I was emitting the
6154 code once for each fixed piece.
6157 2003-01-08 Martin Baulig <martin@ximian.com>
6159 * statement.cs (FlowBranching.MergeChild): A break in a
6160 SWITCH_SECTION does not leave a loop. Fixes #36155.
6162 2003-01-08 Martin Baulig <martin@ximian.com>
6164 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
6165 lives in the same number space than `param_map'. Fixes #36154.
6167 2003-01-07 Miguel de Icaza <miguel@ximian.com>
6169 * cs-parser.jay (constructor_declaration): Set the
6170 Constructor.ModFlags before probing for it. This makes the
6171 compiler report 514, 515 and 132 (the code was there, but got
6174 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
6175 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
6176 (GotoCase.Resolve): Set `Returns' to ALWAYS.
6178 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
6180 * enum.cs: create the enum static fields using the enum type.
6182 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
6184 * class.cs: don't try to create the ParamBuilder for the return
6185 type if it's not needed (and handle it breaking for the ms runtime
6188 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
6190 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
6192 2002-12-29 Miguel de Icaza <miguel@ximian.com>
6194 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
6195 the command. This showed up while compiling the JANET source
6196 code, which used \r as its only newline separator.
6198 2002-12-28 Miguel de Icaza <miguel@ximian.com>
6200 * class.cs (Method.Define): If we are an operator (because it
6201 reuses our code), then set the SpecialName and HideBySig. #36128
6203 2002-12-22 Miguel de Icaza <miguel@ximian.com>
6205 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
6206 exception, report error 120 `object reference required'.
6208 * driver.cs: Add --pause option, used during to measure the size
6209 of the process as it goes with --timestamp.
6211 * expression.cs (Invocation.DoResolve): Do not allow methods with
6212 SpecialName to be invoked.
6214 2002-12-21 Miguel de Icaza <miguel@ximian.com>
6216 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
6217 number before adding it.
6219 2002-12-21 Ravi Pratap <ravi@ximian.com>
6221 * ecore.cs (StandardImplicitConversion): When in an unsafe
6222 context, we allow conversion between void * to any other pointer
6223 type. This fixes bug #35973.
6225 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
6227 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
6228 is not thrown when extensionless outputs are used
6230 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6232 * rootcontext.cs: fixed compilation of corlib.
6234 2002-12-19 Miguel de Icaza <miguel@ximian.com>
6236 * attribute.cs (Attributes.Contains): Add new method.
6238 * class.cs (MethodCore.LabelParameters): if the parameter is an
6239 `out' parameter, check that no attribute `[In]' has been passed.
6241 * enum.cs: Handle the `value__' name in an enumeration.
6243 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
6245 * decl.cs: Added special case to allow overrides on "protected
6248 2002-12-18 Ravi Pratap <ravi@ximian.com>
6250 * attribute.cs (Attributes.AddAttributeSection): Rename to this
6251 since it makes much more sense.
6253 (Attributes.ctor): Don't require a Location parameter.
6255 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
6257 * attribute.cs (ApplyAttributes): Remove extra Location parameters
6258 since we already have that information per attribute.
6260 * everywhere : make appropriate changes.
6262 * class.cs (LabelParameters): Write the code which actually
6263 applies attributes to the return type. We can't do this on the MS
6264 .NET runtime so we flag a warning in the case an exception is
6267 2002-12-18 Miguel de Icaza <miguel@ximian.com>
6269 * const.cs: Handle implicit null conversions here too.
6271 2002-12-17 Ravi Pratap <ravi@ximian.com>
6273 * class.cs (MethodCore.LabelParameters): Remove the extra
6274 Type [] parameter since it is completely unnecessary. Instead
6275 pass in the method's attributes so that we can extract
6276 the "return" attribute.
6278 2002-12-17 Miguel de Icaza <miguel@ximian.com>
6280 * cs-parser.jay (parse): Use Report.Error to flag errors instead
6281 of ignoring it and letting the compile continue.
6283 * typemanager.cs (ChangeType): use an extra argument to return an
6284 error condition instead of throwing an exception.
6286 2002-12-15 Miguel de Icaza <miguel@ximian.com>
6288 * expression.cs (Unary.TryReduce): mimic the code for the regular
6289 code path. Perform an implicit cast in the cases where we can
6290 implicitly convert to one of the integral types, and then reduce
6291 based on that constant. This fixes bug #35483.
6293 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6295 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
6297 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6299 * namespace.cs: fixed bug #35489.
6301 2002-12-12 Miguel de Icaza <miguel@ximian.com>
6303 * class.cs: Remove some dead code.
6305 * cs-parser.jay: Estimate the number of methods needed
6306 (RootContext.MethodCount);
6308 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
6309 numbers instead of StringBuilders.
6311 * support.cs (PtrHashtable): Add constructor with initial size;
6312 We can now reduce reallocations of the method table.
6314 2002-12-10 Ravi Pratap <ravi@ximian.com>
6316 * attribute.cs (ApplyAttributes): Keep track of the emitted
6317 attributes on a per-target basis. This fixes bug #35413.
6319 2002-12-10 Miguel de Icaza <miguel@ximian.com>
6321 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
6322 default to the Windows 1252 encoding.
6324 (UnixParseOption): Support version, thanks to Alp for the missing
6327 * AssemblyInfo.cs: Add nice assembly information.
6329 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
6332 * cs-parser.jay: Allow a trailing comma before the close bracked
6333 in the attribute_section production.
6335 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
6336 address of the instance was being taken, I will take this out,
6337 because we take the address of the object immediately here.
6339 2002-12-09 Ravi Pratap <ravi@ximian.com>
6341 * typemanager.cs (AreMultipleAllowed): Take care of the most
6342 obvious case where attribute type is not in the current assembly -
6345 2002-12-08 Miguel de Icaza <miguel@ximian.com>
6347 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
6348 definitions, instead of doing that afterwards.
6350 Also we use a nice little hack, depending on the constructor, we
6351 know if we are a "composed" name or a simple name. Hence, we
6352 avoid the IndexOf test, and we avoid
6354 * codegen.cs: Add code to assist in a bug reporter to track down
6355 the source of a compiler crash.
6357 2002-12-07 Ravi Pratap <ravi@ximian.com>
6359 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
6360 types have been emitted for a given element and flag an error
6361 if something which does not have AllowMultiple set is used more
6364 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
6365 attribute types and their corresponding AllowMultiple properties
6367 (AreMultipleAllowed): Check the property for a given type.
6369 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
6370 property in the case we have a TypeContainer.
6372 (Attributes.AddAttribute): Detect duplicates and just skip on
6373 adding them. This trivial fix catches a pretty gross error in our
6374 attribute emission - global attributes were being emitted twice!
6376 Bugzilla bug #33187 is now fixed.
6378 2002-12-06 Miguel de Icaza <miguel@ximian.com>
6380 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
6383 * expression.cs (Binary.ResolveOperator): I can only use the
6384 Concat (string, string, string) and Concat (string, string,
6385 string, string) if the child is actually a concatenation of
6388 2002-12-04 Miguel de Icaza <miguel@ximian.com>
6390 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
6391 context where we need a 2-character lookahead.
6393 * pending.cs (PendingImplementation): Rework so we can keep track
6394 of interface types all the time, and flag those which were
6395 implemented by parents as optional.
6397 2002-12-03 Miguel de Icaza <miguel@ximian.com>
6399 * expression.cs (Binary.ResolveOperator): Use
6400 String.Concat(string,string,string) or
6401 String.Concat(string,string,string,string) when possible.
6403 * typemanager: More helper methods.
6406 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
6408 * pending.cs: remove the bogus return from GetMissingInterfaces()
6409 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
6411 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6413 * namespace.cs: avoid duplicated 'using xxx' being added to
6414 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
6415 when we get more than one 'using' statement for the same namespace.
6416 Report a CS0105 warning for it.
6418 2002-11-30 Miguel de Icaza <miguel@ximian.com>
6420 * cs-tokenizer.cs (consume_identifier): use read directly, instead
6421 of calling getChar/putback, uses internal knowledge of it.
6423 (xtoken): Reorder tokenizer so most common patterns are checked
6424 first. This reduces the compilation time in another 5% (from 8.11s
6425 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
6427 The parsing time is 22% of the compilation in mcs, and from that
6428 64% is spent on the tokenization process.
6430 I tried using a binary search for keywords, but this is slower
6431 than the hashtable. Another option would be to do a couple of
6434 * Not use a StringBuilder, instead use an array of chars,
6435 with a set value. Notice that this way we could catch
6436 the 645 error without having to do it *afterwards*.
6438 * We could write a hand-parser to avoid the hashtable
6439 compares altogether.
6441 The identifier consumption process takes 37% of the tokenization
6442 time. Another 15% is spent on is_number. 56% of the time spent
6443 on is_number is spent on Int64.Parse:
6445 * We could probably choose based on the string length to
6446 use Int32.Parse or Int64.Parse and avoid all the 64-bit
6449 Another 3% is spend on wrapping `xtoken' in the `token' function.
6451 Handle 0xa0 as whitespace (#34752)
6453 2002-11-26 Miguel de Icaza <miguel@ximian.com>
6455 * typemanager.cs (IsCLRType): New routine to tell whether a type
6456 is one of the builtin types.
6458 Maybe it needs to use TypeCodes to be faster. Maybe we could use
6459 typecode in more places instead of doing pointer comparissions.
6460 We could leverage some knowledge about the way the typecodes are
6463 New code to cache namespaces in assemblies, it is currently not
6464 invoked, to be used soon.
6466 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
6468 * expression.cs (Binary.ResolveOperator): specially handle
6469 strings, and do not perform user-defined operator overloading for
6472 2002-11-24 Miguel de Icaza <miguel@ximian.com>
6474 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
6475 internalcall as it is a pretty simple operation; Avoid whenever
6476 possible to call Char.IsLetter.
6478 (consume_identifier): Cut by half the number of
6479 hashtable calls by merging the is_keyword and GetKeyword behavior.
6481 Do not short-circuit, because if we do, we
6482 report errors (ie, #if false && true would produce an invalid
6486 2002-11-24 Martin Baulig <martin@ximian.com>
6488 * expression.cs (Cast.TryReduce): If we're in checked syntax,
6489 check constant ranges and report a CS0221. Fixes #33186.
6491 2002-11-24 Martin Baulig <martin@ximian.com>
6493 * cs-parser.jay: Make this work for uninitialized variable
6494 declarations in the `for' initializer. Fixes #32416.
6496 2002-11-24 Martin Baulig <martin@ximian.com>
6498 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
6499 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
6501 2002-11-24 Martin Baulig <martin@ximian.com>
6503 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
6504 argument; if true, we also check for user-defined conversions.
6505 This is only needed if both arguments are of a user-defined type.
6506 Fixes #30443, added test-175.cs.
6507 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
6509 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
6511 2002-11-24 Martin Baulig <martin@ximian.com>
6513 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
6514 function to get the store opcode.
6515 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
6516 only emit the Ldelema if the store opcode is Stobj. You must run
6517 both test-34 and test-167 to test this. Fixes #34529.
6519 2002-11-23 Martin Baulig <martin@ximian.com>
6521 * ecore.cs (Expression.MemberLookup): Added additional
6522 `qualifier_type' argument which is used when we're being called
6523 from MemberAccess.DoResolve() and null if we're called from a
6525 (Expression.MemberLookupFailed): New method to report errors; this
6526 does the CS1540 check and reports the correct error message.
6528 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
6529 argument for the CS1540 check and redone the way how we're dealing
6530 with private members. See the comment in the source code for details.
6531 (FilterWithClosure): Reverted this back to revision 1.197; renamed
6532 `closure_start_type' to `closure_qualifier_type' and check whether
6533 it's not null. It was not this filter being broken, it was just
6534 being called with the wrong arguments.
6536 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
6537 and pass it the correct `qualifier_type'; this also does the error
6540 2002-11-22 Miguel de Icaza <miguel@ximian.com>
6542 * expression.cs (Invocation.EmitParams): If the we are dealing
6543 with a non-built-in value type, load its address as well.
6545 (ArrayCreation): Use a a pretty constant instead
6546 of the hardcoded value 2. Use 6 instead of 2 for the number of
6547 static initializers.
6549 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
6550 because they are not really value types, just glorified integers.
6552 * driver.cs: Do not append .exe, the CSC compiler does not do it.
6554 * ecore.cs: Remove redundant code for enumerations, make them use
6555 the same code path as everything else, fixes the casting issue
6556 with enumerations in Windows.Forms.
6558 * attribute.cs: Do only cast to string if it is a string, the
6559 validation happens later.
6561 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
6562 people upgrade their corlibs.
6564 * ecore.cs: Oops, enumerations were not following the entire code path
6566 2002-11-21 Miguel de Icaza <miguel@ximian.com>
6568 * typemanager.cs (FilterWithClosure): Commented out the test for
6569 1540 in typemanager.cs, as it has problems when accessing
6570 protected methods from a parent class (see test-174.cs).
6572 * attribute.cs (Attribute.ValidateGuid): new method.
6573 (Attribute.Resolve): Use above.
6575 2002-11-19 Miguel de Icaza <miguel@ximian.com>
6577 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
6579 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
6580 handling for enumerations, as we only needed the TypeContainer
6581 functionality to begin with (this is required for the fix below to
6582 work for enums that reference constants in a container class for
6585 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
6587 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
6588 a valid TypeBuilder to perform lookups on.o
6590 * class.cs (InheritableMemberSignatureCompare): Use true in the
6591 call to GetGetMethod and GetSetMethod, because we are comparing
6592 the signature, and we need to get the methods *even* if they are
6595 (PropertyBase.CheckBase): ditto.
6597 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
6598 GotoCase.Resolve): Use Peel on EmpytCasts.
6600 * ecore.cs (EmptyCast): drop child, add Peel method.
6602 2002-11-17 Martin Baulig <martin@ximian.com>
6604 * ecore.cs (EmptyCast.Child): New public property.
6606 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
6607 label resolved to an EmptyCast. Fixes #34162.
6608 (GotoCase.Resolve): Likewise.
6609 (Block.EmitMeta): Likewise.
6611 2002-11-17 Martin Baulig <martin@ximian.com>
6613 * expression.cs (Invocation.BetterConversion): Prefer int over
6614 uint; short over ushort; long over ulong for integer literals.
6615 Use ImplicitConversionExists instead of StandardConversionExists
6616 since we also need to check for user-defined implicit conversions.
6617 Fixes #34165. Added test-173.cs.
6619 2002-11-16 Martin Baulig <martin@ximian.com>
6621 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
6622 with the `true' and `false' literals. Fixes #33151.
6624 2002-11-16 Martin Baulig <martin@ximian.com>
6626 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
6627 October 22nd; don't do the cs1540 check for static members.
6629 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
6630 now using our own filter here and doing the cs1540 check again.
6632 2002-11-16 Martin Baulig <martin@ximian.com>
6634 * support.cs (InternalParameters): Don't crash if we don't have
6635 any fixed parameters. Fixes #33532.
6637 2002-11-16 Martin Baulig <martin@ximian.com>
6639 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
6640 when looking up static methods to make this work on Windows.
6643 2002-11-16 Martin Baulig <martin@ximian.com>
6645 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
6646 a setter rather than using PropertyInfo.CanWrite.
6648 2002-11-15 Nick Drochak <ndrochak@gol.com>
6650 * class.cs: Allow acces to block member by subclasses. Fixes build
6653 2002-11-14 Martin Baulig <martin@ximian.com>
6655 * class.cs (Constructor.Emit): Added the extern/block check.
6658 2002-11-14 Martin Baulig <martin@ximian.com>
6660 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
6661 iteration while looking for indexers, this is needed because the
6662 indexer may have a different name in our base classes. Fixed the
6663 error reporting (no indexers at all, not get accessor, no
6664 overloaded match). Fixes bug #33089.
6665 (IndexerAccess.DoResolveLValue): Likewise.
6667 2002-11-14 Martin Baulig <martin@ximian.com>
6669 * class.cs (PropertyBase.CheckBase): Make this work for multiple
6670 indexers. Fixes the first part of bug #33089.
6671 (MethodSignature.InheritableMemberSignatureCompare): Added support
6674 2002-11-13 Ravi Pratap <ravi@ximian.com>
6676 * attribute.cs (Attribute.Resolve): Catch the
6677 NullReferenceException and report it since it isn't supposed to
6680 2002-11-12 Miguel de Icaza <miguel@ximian.com>
6682 * expression.cs (Binary.EmitBranchable): Also handle the cases for
6683 LogicalOr and LogicalAnd that can benefit from recursively
6684 handling EmitBranchable. The code now should be nice for Paolo.
6686 2002-11-08 Miguel de Icaza <miguel@ximian.com>
6688 * typemanager.cs (LookupType): Added a negative-hit hashtable for
6689 the Type lookups, as we perform quite a number of lookups on
6690 non-Types. This can be removed once we can deterministically tell
6691 whether we have a type or a namespace in advance.
6693 But this might require special hacks from our corlib.
6697 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
6698 and double which avoids a conversion from an integer to a double.
6700 * expression.cs: tiny optimization, avoid calling IsConstant,
6701 because it effectively performs the lookup twice.
6703 2002-11-06 Miguel de Icaza <miguel@ximian.com>
6705 But a bogus return here to keep the semantics of the old code
6706 until the Mono runtime is fixed.
6708 * pending.cs (GetMissingInterfaces): New method used to remove all
6709 the interfaces that are already implemented by our parent
6710 classes from the list of pending methods.
6712 * interface.cs: Add checks for calls after ResolveTypeExpr.
6714 2002-11-05 Miguel de Icaza <miguel@ximian.com>
6716 * class.cs (Class.Emit): Report warning 67: event not used if the
6717 warning level is beyond 3.
6719 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
6720 being a NullLiteral.
6722 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
6725 * class.cs (TypeContainer.GetClassBases): Cover a missing code
6726 path that might fail if a type can not be resolved.
6728 * expression.cs (Binary.Emit): Emit unsigned versions of the
6731 * driver.cs: use error 5.
6733 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
6735 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
6737 2002-11-01 Miguel de Icaza <miguel@ximian.com>
6739 * cs-parser.jay (switch_section): A beautiful patch from Martin
6740 Baulig that fixed 33094.
6742 2002-10-31 Miguel de Icaza <miguel@ximian.com>
6744 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
6745 Check whether the base is abstract and report an error if so.
6747 * expression.cs (IndexerAccess.DoResolveLValue,
6748 IndexerAccess.DoResolve): ditto.
6750 (Invocation.DoResolve): ditto.
6752 (Invocation.FullMethodDesc): Improve the report string.
6754 * statement.cs (Block): Eliminate IsVariableDefined as it is
6755 basically just a wrapper for GetVariableInfo.
6757 * ecore.cs (SimpleName): Use new
6759 * support.cs (ReflectionParamter.ParameterType): We unwrap the
6760 type, as we return the actual parameter ref/unref state on a
6763 2002-10-30 Miguel de Icaza <miguel@ximian.com>
6765 * support.cs: Return proper flags REF/OUT fixing the previous
6768 * expression.cs: Reverted last patch, that was wrong. Is_ref is
6769 not used to mean `ref' but `ref or out' in ParameterReference
6771 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
6772 full type signature instead of calling TypeManger.CSharpName
6775 * support.cs (InternalParameters.ParameterDesc): Do not compare
6776 directly to the modflags, because REF/OUT will actually be bitsets
6779 * delegate.cs (VerifyMethod): Check also the modifiers.
6781 * cs-tokenizer.cs: Fix bug where floating point values with an
6782 exponent where a sign was missing was ignored.
6784 * driver.cs: Allow multiple assemblies to be specified in a single
6787 2002-10-28 Miguel de Icaza <miguel@ximian.com>
6789 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
6790 because identifiers after a parenthesis would end up in this kind
6791 of production, and we needed to desamiguate it for having casts
6794 (UserDefinedType *) xxx
6796 2002-10-24 Miguel de Icaza <miguel@ximian.com>
6798 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
6799 we should set on the Bindingflags.NonPublic, but not turn on
6800 private_ok. private_ok controls whether a Private member is
6801 returned (this is chekced on the filter routine), while the
6802 BindingFlags.NonPublic just controls whether private/protected
6803 will be allowed. This fixes the problem part of the problem of
6804 private properties being allowed to be used in derived classes.
6806 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
6807 so we can call the children DoResolveLValue method (this will
6808 properly signal errors on lvalue assignments to base properties)
6810 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
6811 getter are null, and we have a property info, we know that this
6812 happened because the lookup failed, so we report an error 122 for
6813 protection level violation.
6815 We also silently return if setter and getter are null in the
6816 resolve functions, this condition only happens if we have flagged
6817 the error before. This is the other half of the problem.
6819 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
6820 not have accessibility information, that is why we were returning
6821 true in the filter function in typemanager.cs.
6823 To properly report 122 (property is inaccessible because of its
6824 protection level) correctly, we report this error in ResolveAccess
6825 by failing if both the setter and the getter are lacking (ie, the
6828 DoResolve and DoLResolve have been modified to check for both
6829 setter/getter being null and returning silently, the reason being
6830 that I did not want to put the knowledge about this error in upper
6833 int old = Report.Errors;
6834 x = new PropertyExpr (...);
6835 if (old != Report.Errors)
6840 So the property expr is returned, but it is invalid, so the error
6841 will be flagged during the resolve process.
6843 * class.cs: Remove InheritablePropertySignatureCompare from the
6844 class, as we no longer depend on the property signature to compute
6845 whether it is possible to implement a method or not.
6847 The reason is that calling PropertyInfo.GetGetMethod will return
6848 null (in .NET, in Mono it works, and we should change this), in
6849 cases where the Get Method does not exist in that particular
6854 class X { public virtual int A { get { return 1; } } }
6856 class Z : Y { public override int A { get { return 2; } } }
6858 Would fail in Z because the parent (Y) would not have the property
6859 defined. So we avoid this completely now (because the alternative
6860 fix was ugly and slow), and we now depend exclusively on the
6863 (PropertyBase.CheckBase): Use a method-base mechanism to find our
6864 reference method, instead of using the property.
6866 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
6867 routines are gone now.
6869 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
6870 names, they were incorrectly named.
6872 * cs-tokenizer.cs: Return are more gentle token on failure.
6874 * pending.cs (PendingImplementation.InterfaceMethod): This routine
6875 had an out-of-sync index variable, which caused it to remove from
6876 the list of pending methods the wrong method sometimes.
6878 2002-10-22 Miguel de Icaza <miguel@ximian.com>
6880 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
6881 CanWrite, because those refer to this particular instance of the
6882 property, and do not take into account the fact that we can
6883 override single members of a property.
6885 Constructor requires an EmitContext. The resolution process does
6886 not happen here, but we need to compute the accessors before,
6887 because the resolution does not always happen for properties.
6889 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
6890 subclass, before we did not update this flag, but we did update
6893 (GetAccessors): Drop this routine, as it did not work in the
6894 presence of partially overwritten set/get methods.
6896 Notice that this broke the cs1540 detection, but that will require
6899 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6903 * driver.cs: issue a warning instead of an error if we don't support
6904 debugging for the platform. Also ignore a couple of errors that may
6905 arise when trying to write the symbols. Undo my previous patch.
6907 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6909 * driver.cs: ignore /debug switch except for Unix platforms.
6911 2002-10-23 Nick Drochak <ndrochak@gol.com>
6913 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
6915 2002-10-21 Miguel de Icaza <miguel@ximian.com>
6917 * driver.cs: Do not make mcs-debug conditional, so we do not break
6920 * statement.cs (UsageVector.MergeChildren): I would like Martin to
6921 review this patch. But basically after all the children variables
6922 have been merged, the value of "Breaks" was not being set to
6923 new_breaks for Switch blocks. I think that it should be set after
6924 it has executed. Currently I set this to the value of new_breaks,
6925 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
6926 conservative, but I do not understand this code very well.
6928 I did not break anything in the build, so that is good ;-)
6930 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
6932 2002-10-20 Mark Crichton <crichton@gimp.org>
6934 * cfold.cs: Fixed compile blocker. Really fixed it this time.
6936 2002-10-20 Nick Drochak <ndrochak@gol.com>
6938 * cfold.cs: Fixed compile blocker.
6940 2002-10-20 Miguel de Icaza <miguel@ximian.com>
6942 * driver.cs: I was chekcing the key, not the file.
6944 2002-10-19 Ravi Pratap <ravi@ximian.com>
6946 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
6947 message that we were generating - we just need to silently return
6950 2002-10-19 Miguel de Icaza <miguel@ximian.com>
6952 * class.cs (Event.Define): Change my previous commit, as this
6953 breaks the debugger. This is a temporary hack, as it seems like
6954 the compiler is generating events incorrectly to begin with.
6956 * expression.cs (Binary.ResolveOperator): Added support for
6957 "U operator - (E x, E y)"
6959 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
6962 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
6963 init-only variables, but this path did not take into account that
6964 there might be also instance readonly variables. Correct this
6967 This fixes bug 32253
6969 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
6972 * driver.cs: Change the extension for modules to `netmodule'
6974 * cs-parser.jay: Improved slightly the location tracking for
6975 the debugger symbols.
6977 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
6978 modifiers that were specified instead of the hardcoded value
6979 (FamAndAssem). This was basically ignoring the static modifier,
6980 and others. Fixes 32429.
6982 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
6983 fixed a bug in the process (32476)
6985 * expression.cs (ArrayAccess.EmitAssign): Patch from
6986 hwang_rob@yahoo.ca that fixes bug 31834.3
6988 2002-10-18 Miguel de Icaza <miguel@ximian.com>
6990 * driver.cs: Make the module extension .netmodule.
6992 2002-10-16 Miguel de Icaza <miguel@ximian.com>
6994 * driver.cs: Report an error if the resource file is not found
6995 instead of crashing.
6997 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
6998 false, like Emit does.
7000 2002-10-16 Nick Drochak <ndrochak@gol.com>
7002 * typemanager.cs: Remove unused private member. Also reported mcs
7003 bug to report this as a warning like csc.
7005 2002-10-15 Martin Baulig <martin@gnome.org>
7007 * statement.cs (Statement.Emit): Made this a virtual method; emits
7008 the line number info and calls DoEmit().
7009 (Statement.DoEmit): New protected abstract method, formerly knows
7010 as Statement.Emit().
7012 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
7014 2002-10-11 Miguel de Icaza <miguel@ximian.com>
7016 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
7017 have fixed a remaining problem: not every AddXXXX was adding a
7018 fully qualified name.
7020 Now everyone registers a fully qualified name in the DeclSpace as
7021 being defined instead of the partial name.
7023 Downsides: we are slower than we need to be due to the excess
7024 copies and the names being registered this way.
7026 The reason for this is that we currently depend (on the corlib
7027 bootstrap for instance) that types are fully qualified, because
7028 we dump all the types in the namespace, and we should really have
7029 types inserted into the proper namespace, so we can only store the
7030 basenames in the defined_names array.
7032 2002-10-10 Martin Baulig <martin@gnome.org>
7034 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
7035 from bug #31834, see the bug report for a testcase which is
7038 2002-10-10 Martin Baulig <martin@gnome.org>
7040 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
7041 flow analysis code for this.
7043 * statement.cs (Do, While, For): Tell the flow analysis code about
7045 (FlowBranching.UsageVector): Added support for infinite loops.
7046 (Block.Resolve): Moved the dead code elimination here and use flow
7049 2002-10-09 Miguel de Icaza <miguel@ximian.com>
7051 * class.cs (Field.Define): Catch cycles on struct type
7054 * typemanager.cs (IsUnmanagedtype): Do not recursively check
7055 fields if the fields are static. We only need to check instance
7058 * expression.cs (As.DoResolve): Test for reference type.
7060 * statement.cs (Using.ResolveExpression): Use
7061 ConvertImplicitRequired, not ConvertImplicit which reports an
7063 (Using.ResolveLocalVariableDecls): ditto.
7065 * expression.cs (Binary.ResolveOperator): Report errors in a few
7066 places where we had to.
7068 * typemanager.cs (IsUnmanagedtype): Finish implementation.
7070 2002-10-08 Miguel de Icaza <miguel@ximian.com>
7072 * expression.cs: Use StoreFromPtr instead of extracting the type
7073 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
7075 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
7076 an enumeration value to a System.Enum, but System.Enum is not a
7077 value type, but an class type, so we need to box.
7079 (Expression.ConvertExplicit): One codepath could return
7080 errors but not flag them. Fix this. Fixes #31853
7082 * parameter.cs (Resolve): Do not allow void as a parameter type.
7084 2002-10-06 Martin Baulig <martin@gnome.org>
7086 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
7087 if it's a class type and not a struct. Fixes #31815.
7089 2002-10-06 Martin Baulig <martin@gnome.org>
7091 * statement.cs: Reworked the flow analysis code a bit to make it
7092 usable for dead code elimination.
7094 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7096 * cs-parser.jay: allow empty source files. Fixes bug #31781.
7098 2002-10-04 Miguel de Icaza <miguel@ximian.com>
7100 * expression.cs (ComposedCast.DoResolveType): A quick workaround
7101 to fix the test 165, will investigate deeper.
7103 2002-10-04 Martin Baulig <martin@gnome.org>
7105 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
7106 finally blocks actually work.
7107 (Try.Resolve): We don't need to create a sibling for `finally' if
7108 there is no finally block.
7110 2002-10-04 Martin Baulig <martin@gnome.org>
7112 * class.cs (Constructor.Define): The default accessibility for a
7113 non-default constructor is private, not public.
7115 2002-10-04 Miguel de Icaza <miguel@ximian.com>
7117 * class.cs (Constructor): Make AllowedModifiers public, add
7120 * cs-parser.jay: Perform the modifiers test here, as the
7121 constructor for the Constructor class usually receives a zero
7122 because of the way we create it (first we create, later we
7123 customize, and we were never checking the modifiers).
7125 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
7126 is a version of LookupTypeReflection that includes the type-name
7127 cache. This can be used as a fast path for functions that know
7128 the fully qualified name and are only calling into *.GetType() to
7129 obtain a composed type.
7131 This is also used by TypeManager.LookupType during its type
7134 (LookupType): We now also track the real type name, as sometimes
7135 we can get a quey for the real type name from things like
7136 ComposedCast. This fixes bug 31422.
7138 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
7139 complete type fullname, it does not have to go through the type
7140 resolution system to obtain the composed version of the type (for
7141 obtaining arrays or pointers).
7143 (Conditional.Emit): Use the EmitBoolExpression to
7144 generate nicer code, as requested by Paolo.
7146 (ArrayCreation.CheckIndices): Use the patch from
7147 hwang_rob@yahoo.ca to validate the array initializers.
7149 2002-10-03 Miguel de Icaza <miguel@ximian.com>
7151 * class.cs (ConstructorInitializer.Emit): simplify code by using
7152 Invocation.EmitCall, and at the same time, fix the bugs in calling
7153 parent constructors that took variable arguments.
7155 * ecore.cs (Expression.ConvertNumericExplicit,
7156 Expression.ImplicitNumericConversion): Remove the code that
7157 manually wrapped decimal (InternalTypeConstructor call is now gone
7160 * expression.cs (Cast.TryReduce): Also handle decimal types when
7161 trying to perform a constant fold on the type.
7163 * typemanager.cs (IsUnmanagedtype): Partially implemented.
7165 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
7166 that only turned off an error report, and did nothing else.
7168 2002-10-02 Miguel de Icaza <miguel@ximian.com>
7170 * driver.cs: Handle and ignore /fullpaths
7172 2002-10-01 Miguel de Icaza <miguel@ximian.com>
7174 * expression.cs (Binary.ResolveOperator): Catch the case where
7175 DoNumericPromotions returns true,
7177 (Binary.DoNumericPromotions): Simplify the code, and the tests.
7179 2002-09-27 Miguel de Icaza <miguel@ximian.com>
7181 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
7184 2002-09-26 Miguel de Icaza <miguel@ximian.com>
7186 * ecore.cs (ConvertNumericExplicit): It is not enough that the
7187 conversion exists, but it is also required that the conversion be
7188 performed. This manifested in "(Type64Enum) 2".
7190 * class.cs (TypeManager.AddMethod): The fix is not to change
7191 AddEnum, because that one was using a fully qualified name (every
7192 DeclSpace derivative does), but to change the AddMethod routine
7193 that was using an un-namespaced name. This now correctly reports
7194 the duplicated name.
7196 Revert patch until I can properly fix it. The issue
7197 is that we have a shared Type space across all namespaces
7198 currently, which is wrong.
7200 Options include making the Namespace a DeclSpace, and merge
7201 current_namespace/current_container in the parser.
7203 2002-09-25 Miguel de Icaza <miguel@ximian.com>
7205 * cs-parser.jay: Improve error reporting when we get a different
7206 kind of expression in local_variable_type and
7207 local_variable_pointer_type.
7209 Propagate this to avoid missleading errors being reported.
7211 * ecore.cs (ImplicitReferenceConversion): treat
7212 TypeManager.value_type as a target just like object_type. As
7217 Is valid, and needs to result in the int 1 being boxed before it
7218 is assigned to the value type v.
7220 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
7221 to validate the enumeration name.
7223 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
7224 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
7225 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
7227 * ecore.cs (TryImplicitIntConversion): When doing an
7228 implicit-enumeration-conversion, check if the type is 64-bits and
7229 perform a conversion before passing to EnumConstant.
7231 2002-09-23 Miguel de Icaza <miguel@ximian.com>
7233 * decl.cs (Error_AmbiguousTypeReference); New routine used to
7234 report ambiguous type references. Unlike the MS version, we
7235 report what the ambiguity is. Innovation at work ;-)
7237 (DeclSpace.FindType): Require a location argument to
7238 display when we display an ambiguous error.
7240 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
7242 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
7244 * expression.cs (EmitDynamicInitializers): Apply patch from
7245 hwang_rob@yahoo.ca that fixes the order in which we emit our
7248 2002-09-21 Martin Baulig <martin@gnome.org>
7250 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
7251 delegate takes no arguments.
7253 2002-09-20 Miguel de Icaza <miguel@ximian.com>
7255 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
7258 * expression.cs: Extract the underlying type.
7260 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
7262 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
7264 2002-09-19 Miguel de Icaza <miguel@ximian.com>
7266 * class.cs (TypeContainer.DefineType): We can not use the nice
7267 PackingSize with the size set to 1 DefineType method, because it
7268 will not allow us to define the interfaces that the struct
7271 This completes the fixing of bug 27287
7273 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
7274 means also structs. This fixes part of the problem.
7275 (Expresion.ImplicitReferenceConversionExists): ditto.
7277 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
7278 error if there were no errors reported during the type lookup
7279 process, to avoid duplicates or redundant errors. Without this
7280 you would get an ambiguous errors plus a type not found. We have
7281 beaten the user enough with the first error.
7283 (DeclSparce.FindType): Emit a warning if we have an ambiguous
7286 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
7287 during the resolution process, stop the lookup, this avoids
7288 repeated error reports (same error twice).
7290 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
7292 * typemanager.cs (LookupType): Redo the type lookup code to match
7293 the needs of System.Reflection.
7295 The issue is that System.Reflection requires references to nested
7296 types to begin with a "+" sign instead of a dot. So toplevel
7297 types look like: "NameSpace.TopLevelClass", and nested ones look
7298 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
7301 2002-09-19 Martin Baulig <martin@gnome.org>
7303 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
7304 says that a method always returns or always throws an exception,
7305 don't report the CS0161.
7307 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
7308 set `Returns = new_returns'.
7310 2002-09-19 Martin Baulig <martin@gnome.org>
7312 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
7313 to an enum constant, check for a CS0176.
7315 2002-09-18 Miguel de Icaza <miguel@ximian.com>
7317 * class.cs (TypeContainer.CheckPairedOperators): Now we check
7318 for operators that must be in pairs and report errors.
7320 * ecore.cs (SimpleName.DoResolveType): During the initial type
7321 resolution process, when we define types recursively, we must
7322 check first for types in our current scope before we perform
7323 lookups in the enclosing scopes.
7325 * expression.cs (MakeByteBlob): Handle Decimal blobs.
7327 (Invocation.VerifyArgumentsCompat): Call
7328 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
7329 I thought we were supposed to always call this, but there are a
7330 few places in the code where we dont do it.
7332 2002-09-17 Miguel de Icaza <miguel@ximian.com>
7334 * driver.cs: Add support in -linkres and -resource to specify the
7335 name of the identifier.
7337 2002-09-16 Miguel de Icaza <miguel@ximian.com>
7339 * ecore.cs (StandardConversionExists): Sync with the conversion
7340 code: allow anything-* to void* conversions.
7342 (FindMostSpecificSource): Use an Expression argument
7343 instead of a Type, because we might be handed over a Literal which
7344 gets a few more implicit conversions that plain types do not. So
7345 this information was being lost.
7347 Also, we drop the temporary type-holder expression when not
7350 2002-09-17 Martin Baulig <martin@gnome.org>
7352 * class.cs (PropertyBase.CheckBase): Don't check the base class if
7353 this is an explicit interface implementation.
7355 2002-09-17 Martin Baulig <martin@gnome.org>
7357 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
7358 different `IndexerName' attributes.
7360 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
7361 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
7362 virtual CommonResolve().
7364 2002-09-16 Miguel de Icaza <miguel@ximian.com>
7366 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
7367 and convert that to the UnderlyingType.
7369 * statement.cs (Foreach.Resolve): Indexers are just like variables
7370 or PropertyAccesses.
7372 * cs-tokenizer.cs (consume_string): Track line numbers and columns
7373 inside quoted strings, we were not doing this before.
7375 2002-09-16 Martin Baulig <martin@gnome.org>
7377 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
7378 resolve it. This is needed for the definite assignment check of the
7379 instance expression, fixes bug #29846.
7380 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
7382 2002-09-16 Nick Drochak <ndrochak@gol.com>
7384 * parameter.cs: Fix compile error. Cannot reference static member
7385 from an instance object. Is this an mcs bug?
7387 2002-09-14 Martin Baulig <martin@gnome.org>
7389 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
7390 multiple times. Fixes bug #30295, added test-166.cs.
7392 2002-09-14 Martin Baulig <martin@gnome.org>
7394 * statement.cs (Block.Emit): Don't emit unreachable code.
7395 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
7397 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
7399 2002-09-14 Martin Baulig <martin@gnome.org>
7401 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
7404 2002-09-14 Martin Baulig <martin@gnome.org>
7406 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
7407 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
7408 be false on the ms runtime.
7410 2002-09-13 Martin Baulig <martin@gnome.org>
7412 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
7413 the CS0038 error message.
7415 2002-09-12 Miguel de Icaza <miguel@ximian.com>
7417 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
7418 constant inside, return it.
7420 2002-09-12 Martin Baulig <martin@gnome.org>
7422 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
7423 implicit conversion can be done between enum types.
7425 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
7426 check whether an implicit conversion to the current enum's UnderlyingType
7427 exists and report an error if not.
7429 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
7430 without debugging support.
7432 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
7433 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
7435 2002-09-12 Martin Baulig <martin@gnome.org>
7437 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
7439 * ecore.cs (IMemberExpr.DeclaringType): New property.
7440 (SimpleName.SimpleNameResolve): Check whether we're accessing a
7441 nonstatic member of an outer type (CS0038).
7443 2002-09-11 Miguel de Icaza <miguel@ximian.com>
7445 * driver.cs: Activate the using-error detector at warning level
7446 4 (at least for MS-compatible APIs).
7448 * namespace.cs (VerifyUsing): Small buglett fix.
7450 * pending.cs (PendingImplementation): pass the container pointer.
7452 * interface.cs (GetMethods): Allow for recursive definition. Long
7453 term, I would like to move every type to support recursive
7454 definitions, not the current ordering mechanism that we have right
7457 The situation is this: Attributes are handled before interfaces,
7458 so we can apply attributes to interfaces. But some attributes
7459 implement interfaces, we will now handle the simple cases
7460 (recursive definitions will just get an error).
7462 * parameter.cs: Only invalidate types at the end if we fail to
7465 2002-09-09 Martin Baulig <martin@gnome.org>
7467 * ecore.cs (PropertyExpr.Emit): Also check for
7468 TypeManager.system_int_array_get_length so this'll also work when
7469 compiling corlib. Fixes #30003.
7471 2002-09-09 Martin Baulig <martin@gnome.org>
7473 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
7474 and throw an exception if we can't get the type's size. Fixed #30040,
7477 2002-09-09 Martin Baulig <martin@gnome.org>
7479 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
7481 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
7482 context. Fixes bug #30027.
7484 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
7485 virtual functions. Fixes bug #30043, added test-164.cs.
7487 2002-09-08 Ravi Pratap <ravi@ximian.com>
7489 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
7491 2002-09-08 Nick Drochak <ndrochak@gol.com>
7493 * driver.cs: Use an object to get the windows codepage since it's not a
7496 2002-09-08 Miguel de Icaza <miguel@ximian.com>
7498 * statement.cs (For.Emit): for infinite loops (test == null)
7499 return whether there is a break inside, not always "true".
7501 * namespace.cs (UsingEntry): New struct to hold the name of the
7502 using definition, the location where it is defined, and whether it
7503 has been used in a successful type lookup.
7505 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
7510 2002-09-06 Ravi Pratap <ravi@ximian.com>
7512 * attribute.cs : Fix incorrect code which relied on catching
7513 a NullReferenceException to detect a null being passed in
7514 where an object was expected.
7516 2002-09-06 Miguel de Icaza <miguel@ximian.com>
7518 * statement.cs (Try): flag the catch variable as assigned
7520 * expression.cs (Cast): Simplified by using ResolveType instead of
7523 * statement.cs (Catch): Fix bug by using ResolveType.
7525 2002-09-06 Ravi Pratap <ravi@ximian.com>
7527 * expression.cs (BetterConversion): Special case for when we have
7528 a NullLiteral as the argument and we have to choose between string
7529 and object types - we choose string the way csc does.
7531 * attribute.cs (Attribute.Resolve): Catch the
7532 NullReferenceException and report error #182 since the Mono
7533 runtime no more has the bug and having this exception raised means
7534 we tried to select a constructor which takes an object and is
7537 2002-09-05 Ravi Pratap <ravi@ximian.com>
7539 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
7540 message (1502, 1503) when we can't locate a method after overload
7541 resolution. This is much more informative and closes the bug
7544 * interface.cs (PopulateMethod): Return if there are no argument
7545 types. Fixes a NullReferenceException bug.
7547 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
7548 expressions too. Previously we were checking only in one place for
7549 positional arguments leaving out named arguments.
7551 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
7552 type to the enum type is not allowed. Remove code corresponding to
7555 (ConvertNumericExplicit): Allow explicit conversions from
7556 the underlying type to enum type. This precisely follows the spec
7557 and closes a bug filed by Gonzalo.
7559 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7562 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
7564 2002-09-03 Miguel de Icaza <miguel@ximian.com>
7566 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
7567 it was important that we stored the right value after the
7568 reduction in `converted'.
7570 2002-09-04 Martin Baulig <martin@gnome.org>
7572 * location.cs (Location.SymbolDocument): Use full pathnames for the
7575 2002-08-30 Miguel de Icaza <miguel@ximian.com>
7577 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
7578 of the expression resolve mechanism, because that will catch the
7579 SimpleName error failures.
7581 (Conditional): If we can not resolve the
7582 expression, return, do not crash.
7584 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7587 (location): display token name instead of its number.
7589 2002-08-28 Martin Baulig <martin@gnome.org>
7591 * expression.cs (Binary.ResolveOperator): Don't silently return
7592 but return an error if an operator cannot be applied between two
7595 2002-08-28 Martin Baulig <martin@gnome.org>
7597 * class.cs (Constructor.Define): Set the permission attributes
7598 correctly instead of making all constructors public.
7600 2002-08-28 Martin Baulig <martin@gnome.org>
7602 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
7603 for private members before reporting a CS0103; if we find anything,
7606 2002-08-28 Martin Baulig <martin@gnome.org>
7608 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
7609 to check whether `closure_start_type == closure_invocation_type',
7610 we also need to check whether `m.DeclaringType == closure_invocation_type'
7611 before bypassing the permission checks. We might be accessing
7612 protected/private members from the base class.
7613 (TypeManager.RealMemberLookup): Only set private_ok if private
7614 members were requested via BindingFlags.NonPublic.
7616 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
7618 * expression.cs (MemberAccess.ResolveMemberAccess): Set
7619 MethodGroupExpr.IsExplicitImpl if appropriate.
7620 (Invocation.DoResolve): Don't report the CS0120 for explicit
7621 interface implementations.
7623 2002-08-27 Martin Baulig <martin@gnome.org>
7625 * expression.cs (Invocation.DoResolve): If this is a static
7626 method and we don't have an InstanceExpression, we must report
7629 2002-08-25 Martin Baulig <martin@gnome.org>
7631 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
7632 `==' between a valuetype and an object.
7634 2002-08-25 Miguel de Icaza <miguel@ximian.com>
7636 * ecore.cs (TypeExpr): Provide a ToString method.
7638 2002-08-24 Martin Baulig <martin@gnome.org>
7640 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
7641 now called proggie.dbg and it's a binary file.
7643 2002-08-23 Martin Baulig <martin@gnome.org>
7645 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
7647 2002-08-23 Martin Baulig <martin@gnome.org>
7649 * struct.cs (MyStructInfo.ctor): Make this work with empty
7650 structs; it's not allowed to use foreach() on null.
7652 2002-08-23 Martin Baulig <martin@gnome.org>
7654 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
7655 writer the full pathname of the generated assembly.
7657 2002-08-23 Martin Baulig <martin@gnome.org>
7659 * statements.cs (FlowBranching.UsageVector.MergeChildren):
7660 A `finally' block never returns or breaks; improved handling of
7663 2002-08-23 Martin Baulig <martin@gnome.org>
7665 * statement.cs (Throw.Resolve): Allow `throw null'.
7667 2002-08-23 Martin Baulig <martin@gnome.org>
7669 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
7670 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
7671 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
7672 MemberLookup would return a wrong event if this is an explicit
7673 interface implementation and the class has an event with the same
7676 2002-08-23 Martin Baulig <martin@gnome.org>
7678 * statement.cs (Block.AddChildVariableNames): New public method.
7679 (Block.AddChildVariableName): Likewise.
7680 (Block.IsVariableNameUsedInChildBlock): Likewise.
7681 (Block.AddVariable): Check whether a variable name has already
7682 been used in a child block.
7684 * cs-parser.jay (declare_local_variables): Mark all variable names
7685 from the current block as being used in a child block in the
7688 2002-08-23 Martin Baulig <martin@gnome.org>
7690 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
7691 find the symbol writer.
7693 * driver.cs: csc also allows the arguments to /define being
7694 separated by commas, not only by semicolons.
7696 2002-08-23 Martin Baulig <martin@gnome.org>
7698 * interface.cs (Interface.GetMembers): Added static check for events.
7700 2002-08-15 Martin Baulig <martin@gnome.org>
7702 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
7703 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
7705 * ecore.cs (Expression.MemberLookup): Added documentation and explained
7706 why the MethodData.EmitDestructor() change was necessary.
7708 2002-08-20 Martin Baulig <martin@gnome.org>
7710 * class.cs (TypeContainer.FindMembers): Added static check for events.
7712 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
7714 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
7715 use Type.GetEvents(), not Type.FindMembers().
7717 2002-08-20 Martin Baulig <martin@gnome.org>
7719 * decl.cs (MemberCache): Added a special method cache which will
7720 be used for method-only searched. This ensures that a method
7721 search will return a MethodInfo with the correct ReflectedType for
7724 2002-08-20 Martin Baulig <martin@gnome.org>
7726 * decl.cs (DeclSpace.FindMembers): Made this public.
7728 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7730 * delegate.cs: fixed build on windows.
7731 [FIXME: Filed as bug #29150: MCS must report these errors.]
7733 2002-08-19 Ravi Pratap <ravi@ximian.com>
7735 * ecore.cs (StandardConversionExists): Return a false
7736 if we are trying to convert the void type to anything else
7737 since that is not allowed.
7739 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
7740 we flag error 70 in the event an event is trying to be accessed
7741 directly from outside the declaring type.
7743 2002-08-20 Martin Baulig <martin@gnome.org>
7745 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
7746 MemberCache from typemanager.cs to decl.cs.
7748 2002-08-19 Martin Baulig <martin@gnome.org>
7750 * class.cs (TypeContainer): Implement IMemberContainer.
7751 (TypeContainer.DefineMembers): Create the MemberCache.
7752 (TypeContainer.FindMembers): Do better BindingFlags checking; only
7753 return public members if BindingFlags.Public was given, check
7754 whether members are static.
7756 2002-08-16 Martin Baulig <martin@gnome.org>
7758 * decl.cs (DeclSpace.Define): Splitted this in Define and
7759 DefineMembers. DefineMembers is called first and initializes the
7762 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
7763 DefineMembers() on all our DeclSpaces.
7765 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
7766 but call DefineMembers() on all nested interfaces. We call their
7767 Define() in our new Define() function.
7769 * interface.cs (Interface): Implement IMemberContainer.
7770 (Interface.Define): Moved all code except the attribute stuf to
7772 (Interface.DefineMembers): Initialize the member cache.
7774 * typemanager.cs (IMemberFinder): Removed this interface, we don't
7775 need this anymore since we can use MemberCache.FindMembers directly.
7777 2002-08-19 Martin Baulig <martin@gnome.org>
7779 * typemanager.cs (MemberCache): When creating the cache for an
7780 interface type, add all inherited members.
7781 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
7782 to `out bool used_cache' and documented it.
7783 (TypeManager.MemberLookup): If we already used the cache in the first
7784 iteration, we don't need to do the interfaces check.
7786 2002-08-19 Martin Baulig <martin@gnome.org>
7788 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
7789 here from IMemberFinder and don't implement this interface anymore.
7790 (DeclSpace.MemberCache): Moved here from IMemberFinder.
7792 * typemanager.cs (IMemberFinder): This interface is now only used by
7793 classes which actually support the member cache.
7794 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
7795 since we only put DeclSpaces into this Hashtable.
7796 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
7797 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
7799 2002-08-16 Martin Baulig <martin@gnome.org>
7801 * typemanager.cs (ICachingMemberFinder): Removed.
7802 (IMemberFinder.MemberCache): New property.
7803 (TypeManager.FindMembers): Merged this with RealFindMembers().
7804 This function will never be called from TypeManager.MemberLookup()
7805 so we can't use the cache here, just the IMemberFinder.
7806 (TypeManager.MemberLookup_FindMembers): Check whether the
7807 IMemberFinder has a MemberCache and call the cache's FindMembers
7809 (MemberCache): Rewrote larger parts of this yet another time and
7810 cleaned it up a bit.
7812 2002-08-15 Miguel de Icaza <miguel@ximian.com>
7814 * driver.cs (LoadArgs): Support quoting.
7816 (Usage): Show the CSC-like command line arguments.
7818 Improved a few error messages.
7820 2002-08-15 Martin Baulig <martin@gnome.org>
7822 * typemanager.cs (IMemberContainer.Type): New property.
7823 (IMemberContainer.IsInterface): New property.
7825 The following changes are conditional to BROKEN_RUNTIME, which is
7826 defined at the top of the file.
7828 * typemanager.cs (MemberCache.MemberCache): Don't add the base
7829 class'es members, but add all members from TypeHandle.ObjectType
7830 if we're an interface.
7831 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
7832 is the current type.
7833 (MemberCache.CacheEntry.Container): Removed this field.
7834 (TypeHandle.GetMembers): Include inherited members.
7836 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7838 * typemanager.cs: fixed compilation and added a comment on a field that
7841 2002-08-15 Martin Baulig <martin@gnome.org>
7843 * class.cs (ConstructorInitializer.Resolve): In the
7844 Expression.MemberLookup call, use the queried_type as
7847 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
7848 declared' attribute, it's always true.
7849 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
7850 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
7851 temporary wrapper for FindMembers which tells MemberLookup whether
7852 members from the base classes are included in the return value.
7853 This will go away soon.
7854 (TypeManager.MemberLookup): Use this temporary hack here; once the
7855 new MemberCache is completed, we don't need to do the DeclaredOnly
7856 looping here anymore since the MemberCache will take care of this.
7857 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
7858 (MemberCache): When creating the MemberCache for a class, get
7859 members from the current class and all its base classes.
7860 (MemberCache.CacheEntry.Container): New field. This is a
7861 temporary hack until the Mono runtime is fixed to distinguish
7862 between ReflectedType and DeclaringType. It allows us to use MCS
7863 with both the MS runtime and the unfixed Mono runtime without
7864 problems and without accecting performance.
7865 (MemberCache.SearchMembers): The DeclaredOnly looping from
7866 TypeManager.MemberLookup is now done here.
7868 2002-08-14 Martin Baulig <martin@gnome.org>
7870 * statement.cs (MyStructInfo.MyStructInfo): Don't call
7871 Type.GetFields on dynamic types but get the fields from the
7872 corresponding TypeContainer.
7873 (MyStructInfo.GetStructInfo): Added check for enum types.
7875 * typemanager.cs (MemberList.IsSynchronized): Implemented.
7876 (MemberList.SyncRoot): Implemented.
7877 (TypeManager.FilterWithClosure): No need to check permissions if
7878 closure_start_type == closure_invocation_type, don't crash if
7879 closure_invocation_type is null.
7881 2002-08-13 Martin Baulig <martin@gnome.org>
7883 Rewrote TypeContainer.FindMembers to use a member cache. This
7884 gives us a speed increase of about 35% for the self-hosting MCS
7885 build and of about 15-20% for the class libs (both on GNU/Linux).
7887 * report.cs (Timer): New class to get enhanced profiling. This
7888 whole class is "TIMER" conditional since it remarkably slows down
7891 * class.cs (MemberList): New class. This is an IList wrapper
7892 which we're now using instead of passing MemberInfo[]'s around to
7893 avoid copying this array unnecessarily.
7894 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
7895 (ICachingMemberFinder, IMemberContainer): New interface.
7896 (TypeManager.FilterWithClosure): If `criteria' is null, the name
7897 has already been checked, otherwise use it for the name comparision.
7898 (TypeManager.FindMembers): Renamed to RealMemberFinder and
7899 provided wrapper which tries to use ICachingMemberFinder.FindMembers
7900 if possible. Returns a MemberList, not a MemberInfo [].
7901 (TypeHandle): New class, implements IMemberContainer. We create
7902 one instance of this class per type, it contains a MemberCache
7903 which is used to do the member lookups.
7904 (MemberCache): New class. Each instance of this class contains
7905 all members of a type and a name-based hash table.
7906 (MemberCache.FindMembers): This is our new member lookup
7907 function. First, it looks up all members of the requested name in
7908 the hash table. Then, it walks this list and sorts out all
7909 applicable members and returns them.
7911 2002-08-13 Martin Baulig <martin@gnome.org>
7913 In addition to a nice code cleanup, this gives us a performance
7914 increase of about 1.4% on GNU/Linux - not much, but it's already
7915 half a second for the self-hosting MCS compilation.
7917 * typemanager.cs (IMemberFinder): New interface. It is used by
7918 TypeManager.FindMembers to call FindMembers on a TypeContainer,
7919 Enum, Delegate or Interface.
7920 (TypeManager.finder_to_member_finder): New PtrHashtable.
7921 (TypeManager.finder_to_container): Removed.
7922 (TypeManager.finder_to_delegate): Removed.
7923 (TypeManager.finder_to_interface): Removed.
7924 (TypeManager.finder_to_enum): Removed.
7926 * interface.cs (Interface): Implement IMemberFinder.
7928 * delegate.cs (Delegate): Implement IMemberFinder.
7930 * enum.cs (Enum): Implement IMemberFinder.
7932 * class.cs (TypeContainer): Implement IMemberFinder.
7934 2002-08-12 Martin Baulig <martin@gnome.org>
7936 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
7938 2002-08-12 Martin Baulig <martin@gnome.org>
7940 * ecore.cs (ITypeExpression): New interface for expressions which
7942 (TypeExpression): Renamed to TypeLookupExpression.
7943 (Expression.DoResolve): If we're doing a types-only lookup, the
7944 expression must implement the ITypeExpression interface and we
7945 call DoResolveType() on it.
7946 (SimpleName): Implement the new ITypeExpression interface.
7947 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
7948 hack, the situation that we're only looking up types can't happen
7949 anymore when this method is called. Moved the type lookup code to
7950 DoResolveType() and call it.
7951 (SimpleName.DoResolveType): This ITypeExpression interface method
7952 is now doing the types-only lookup.
7953 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
7954 (ResolveFlags): Added MaskExprClass.
7956 * expression.cs (MemberAccess): Implement the ITypeExpression
7958 (MemberAccess.DoResolve): Added support for a types-only lookup
7959 when we're called via ITypeExpression.DoResolveType().
7960 (ComposedCast): Implement the ITypeExpression interface.
7962 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
7963 Expression.Resolve() with ResolveFlags.Type instead.
7965 2002-08-12 Martin Baulig <martin@gnome.org>
7967 * interface.cs (Interface.Define): Apply attributes.
7969 * attribute.cs (Attribute.ApplyAttributes): Added support for
7970 interface attributes.
7972 2002-08-11 Martin Baulig <martin@gnome.org>
7974 * statement.cs (Block.Emit): Only check the "this" variable if we
7975 do not always throw an exception.
7977 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
7978 whether the property has a set accessor.
7980 2002-08-11 Martin Baulig <martin@gnome.org>
7982 Added control flow analysis support for structs.
7984 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
7985 with control flow analysis turned off.
7986 (IVariable): New interface.
7987 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
7988 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
7989 (FieldExpr.DoResolve): Resolve the instance expression with flow
7990 analysis turned off and do the definite assignment check after the
7991 resolving when we know what the expression will resolve to.
7993 * expression.cs (LocalVariableReference, ParameterReference):
7994 Implement the new IVariable interface, only call the flow analysis
7995 code if ec.DoFlowAnalysis is true.
7996 (This): Added constructor which takes a Block argument. Implement
7997 the new IVariable interface.
7998 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
7999 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
8000 This does the definite assignment checks for struct members.
8002 * class.cs (Constructor.Emit): If this is a non-static `struct'
8003 constructor which doesn't have any initializer, call
8004 Block.AddThisVariable() to tell the flow analysis code that all
8005 struct elements must be initialized before control returns from
8008 * statement.cs (MyStructInfo): New public class.
8009 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
8010 argument to this indexer. If non-zero, check an individual struct
8011 member, not the whole struct.
8012 (FlowBranching.CheckOutParameters): Check struct members.
8013 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
8014 overloaded versions of these methods which take an additional
8015 `int field_idx' argument to check struct members.
8016 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
8017 overloaded versions of these methods which take an additional
8018 `string field_name' argument to check struct member.s
8019 (VariableInfo): Implement the IVariable interface.
8020 (VariableInfo.StructInfo): New public property. Returns the
8021 MyStructInfo instance of the variable if it's a struct or null.
8022 (Block.AddThisVariable): New public method. This is called from
8023 Constructor.Emit() for non-static `struct' constructor which do
8024 not have any initializer. It creates a special variable for the
8025 "this" instance variable which will be checked by the flow
8026 analysis code to ensure that all of the struct's fields are
8027 initialized before control returns from the constructor.
8028 (UsageVector): Added support for struct members. If a
8029 variable/parameter is a struct with N members, we reserve a slot
8030 in the usage vector for each member. A struct is considered fully
8031 initialized if either the struct itself (slot 0) or all its
8032 members are initialized.
8034 2002-08-08 Martin Baulig <martin@gnome.org>
8036 * driver.cs (Driver.MainDriver): Only report an error CS5001
8037 if there were no compilation errors.
8039 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
8040 `UnsafeContext' property to determine whether the parent is in
8041 unsafe context rather than checking the parent's ModFlags:
8042 classes nested in an unsafe class are unsafe as well.
8044 2002-08-08 Martin Baulig <martin@gnome.org>
8046 * statement.cs (UsageVector.MergeChildren): Distinguish between
8047 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
8048 we return. Added test17() and test18() to test-154.cs.
8050 2002-08-08 Martin Baulig <martin@gnome.org>
8052 * typemanager.cs (TypeManager.FilterWithClosure): If we have
8053 Family access, make sure the invoking type isn't a subclass of the
8054 queried type (that'd be a CS1540).
8056 * ecore.cs (Expression.MemberLookup): Added overloaded version of
8057 this method which takes an additional `Type invocation_type'.
8059 * expression.cs (BaseAccess.DoResolve): Use the base type as
8060 invocation and query type.
8061 (MemberAccess.DoResolve): If the lookup failed and we're about to
8062 report a CS0122, try a lookup with the ec.ContainerType - if this
8063 succeeds, we must report a CS1540.
8065 2002-08-08 Martin Baulig <martin@gnome.org>
8067 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
8068 (MethodGroupExpr): Implement the IMemberExpr interface.
8070 * expression (MemberAccess.ResolveMemberAccess): No need to have
8071 any special code for MethodGroupExprs anymore, they're now
8074 2002-08-08 Martin Baulig <martin@gnome.org>
8076 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
8077 Family, FamANDAssem and FamORAssem permissions.
8078 (TypeManager.IsSubclassOrNestedChildOf): New public method.
8080 2002-08-08 Martin Baulig <martin@gnome.org>
8082 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
8083 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
8086 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
8088 * driver.cs: implemented /resource option to embed managed resources.
8090 2002-08-07 Martin Baulig <martin@gnome.org>
8092 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
8093 (FieldBase.HasFieldInitializer): New public property.
8094 (FieldBase.GetInitializerExpression): New public method. Resolves and
8095 returns the field initializer and makes sure it is only resolved once.
8096 (TypeContainer.EmitFieldInitializers): Call
8097 FieldBase.GetInitializerExpression to get the initializer, this ensures
8098 that it isn't resolved multiple times.
8100 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
8101 the resolving process (SimpleName/MemberLookup) that we're currently
8102 emitting a field initializer (which must not access any instance members,
8103 this is an error CS0236).
8105 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
8106 argument, if the `IsFieldInitializer' flag is set, we must report and
8107 error CS0236 and not an error CS0120.
8109 2002-08-07 Martin Baulig <martin@gnome.org>
8111 * ecore.cs (IMemberExpr): New public interface.
8112 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
8113 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
8114 if the expression is an IMemberExpr.
8116 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
8117 to be null, implicitly default to `this' if we're non-static in
8118 this case. Simplified the code a lot by using the new IMemberExpr
8119 interface. Also fixed bug #28176 here.
8121 2002-08-06 Martin Baulig <martin@gnome.org>
8123 * cs-parser.jay (SimpleLookup): Removed. We need to create
8124 ParameterReferences during semantic analysis so that we can do a
8125 type-only search when resolving Cast, TypeOf and SizeOf.
8126 (block): Pass the `current_local_parameters' to the Block's
8129 * class.cs (ConstructorInitializer): Added `Parameters parameters'
8130 argument to the constructor.
8131 (ConstructorInitializer.Resolve): Create a temporary implicit
8132 block with the parameters.
8134 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
8135 references here if we aren't doing a type-only search.
8137 * statement.cs (Block): Added constructor which takes a
8138 `Parameters parameters' argument.
8139 (Block.Parameters): New public property.
8141 * support.cs (InternalParameters.Parameters): Renamed `parameters'
8142 to `Parameters' and made it public readonly.
8144 2002-08-06 Martin Baulig <martin@gnome.org>
8146 * ecore.cs (Expression.Warning): Made this public as well.
8148 * report.cs (Report.Debug): Print the contents of collections.
8150 2002-08-06 Martin Baulig <martin@gnome.org>
8152 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
8153 used to tell Resolve() which kinds of expressions it may return.
8154 (Expression.Resolve): Added overloaded version of this method which
8155 takes a `ResolveFlags flags' argument. This can be used to tell
8156 Resolve() which kinds of expressions it may return. Reports a
8158 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
8159 ResolveFlags.SimpleName.
8160 (Expression.Error118): Added overloaded version of this method which
8161 takes a `ResolveFlags flags' argument. It uses the flags to determine
8162 which kinds of expressions are allowed.
8164 * expression.cs (Argument.ResolveMethodGroup): New public method.
8165 Resolves an argument, but allows a MethodGroup to be returned.
8166 This is used when invoking a delegate.
8168 * TODO: Updated a bit.
8170 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8172 Fixed compilation with csc.
8174 * ecore.cs: Expression.Error made public. Is this correct? Should
8175 Warning be made public too?
8177 * expression.cs: use ea.Location instead of ea.loc.
8178 [FIXME: Filed as bug #28607: MCS must report these errors.]
8180 2002-08-06 Martin Baulig <martin@gnome.org>
8182 * ecore.cs (Expression.loc): Moved the location here instead of
8183 duplicating it in all derived classes.
8184 (Expression.Location): New public property.
8185 (Expression.Error, Expression.Warning): Made them non-static and
8186 removed the location argument.
8187 (Expression.Warning): Added overloaded version which takes an
8188 `int level' argument.
8189 (Expression.Error118): Make this non-static and removed the
8190 expression and location arguments.
8191 (TypeExpr): Added location argument to the constructor.
8193 * expression.cs (StaticCallExpr): Added location argument to
8195 (Indirection, PointerArithmetic): Likewise.
8196 (CheckedExpr, UnCheckedExpr): Likewise.
8197 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
8198 (StringPtr): Likewise.
8201 2002-08-05 Martin Baulig <martin@gnome.org>
8203 * expression.cs (BaseAccess.DoResolve): Actually report errors.
8205 * assign.cs (Assign.DoResolve): Check whether the source
8206 expression is a value or variable.
8208 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
8209 while resolving the corresponding blocks.
8211 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
8212 an error, don't silently return null.
8214 * statement.cs (Block.AddVariable): Do the error reporting here
8215 and distinguish between CS0128 and CS0136.
8216 (Block.DoResolve): Report all unused labels (warning CS0164).
8217 (LabeledStatement): Pass the location to the constructor.
8218 (LabeledStatement.HasBeenReferenced): New property.
8219 (LabeledStatement.Resolve): Set it to true here.
8221 * statement.cs (Return.Emit): Return success even after reporting
8222 a type mismatch error (CS0126 or CS0127), this is what csc does and
8223 it avoids confusing the users with any consecutive errors.
8225 2002-08-05 Martin Baulig <martin@gnome.org>
8227 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
8229 * const.cs (Const.LookupConstantValue): Catch circular definitions.
8231 * expression.cs (MemberAccess.DoResolve): Silently return if an
8232 error has already been reported.
8234 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
8235 error has already been reported.
8237 2002-08-05 Martin Baulig <martin@gnome.org>
8239 * statement.cs (UsageVector): Only initialize the `parameters'
8240 vector if we actually have any "out" parameters.
8242 2002-08-05 Martin Baulig <martin@gnome.org>
8244 * expression.cs (Binary.ResolveOperator): When combining delegates,
8245 they must have the same type.
8247 2002-08-05 Martin Baulig <martin@gnome.org>
8249 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
8250 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
8251 work with the ms runtime and we also don't need it: if we're a
8252 PropertyBuilder and not in the `indexer_arguments' hash, then we
8253 are a property and not an indexer.
8255 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
8256 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
8257 since the latter one doesn't work with the ms runtime.
8259 2002-08-03 Martin Baulig <martin@gnome.org>
8261 Fixed bugs #27998 and #22735.
8263 * class.cs (Method.IsOperator): New public field.
8264 (Method.CheckBase): Report CS0111 if there's already a method
8265 with the same parameters in the current class. Report CS0508 when
8266 attempting to change the return type of an inherited method.
8267 (MethodData.Emit): Report CS0179 if a method doesn't have a body
8268 and it's not marked abstract or extern.
8269 (PropertyBase): New abstract base class for Property and Indexer.
8270 (PropertyBase.CheckBase): Moved here from Property and made it work
8272 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
8273 the same so we can reuse it there.
8274 (Property, Indexer): Derive from PropertyBase.
8275 (MethodSignature.inheritable_property_signature_filter): New delegate
8276 to find properties and indexers.
8278 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
8279 argument and improved error reporting.
8281 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
8282 EmptyReadOnlyParameters and made it a property.
8284 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
8285 version of this method which takes a `PropertyInfo indexer'.
8286 (TypeManager.RegisterIndexer): New method.
8288 * class.cs: Added myself as author of this file :-)
8290 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8292 * class.cs: fixed compilation on windoze.
8294 2002-08-03 Martin Baulig <martin@gnome.org>
8296 * interface.cs (Interface.GetInterfaceBases): Check whether all
8297 base interfaces are at least as accessible than the current one.
8299 * class.cs (TypeContainer.GetClassBases): Check whether base types
8300 are at least as accessible than the current type.
8301 (TypeContainer.AsAccessible): Implemented and made non-static.
8302 (MemberBase.CheckParameters): Report errors if the accessibility
8305 * delegate.cs (Delegate.Delegate): The default visibility is
8306 internal for top-level types and private for nested types.
8307 (Delegate.Define): Report errors if the accessibility checks fail.
8309 * enum.cs (Enum.Enum): The default visibility is internal for
8310 top-level types and private for nested types.
8311 (Enum.DefineType): Compute the correct visibility.
8313 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
8314 function which takes a `bool is_toplevel' instead of a TypeContainer.
8316 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
8319 2002-08-02 Martin Baulig <martin@gnome.org>
8321 * expression.cs (LocalVariableReferenc): Added constructor which
8322 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
8323 (LocalVariableReference.IsReadOnly): New property.
8324 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
8325 variable is readonly, use our own readonly flag to do this; you can
8326 use the new constructor to get a writable reference to a read-only
8329 * cs-parser.jay (foreach_statement, using_statement): Get a writable
8330 reference to the local variable.
8332 2002-08-01 Miguel de Icaza <miguel@ximian.com>
8334 * rootcontext.cs (ResolveCore): Also include System.Exception
8336 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
8337 we reach an EmptyStatement.
8339 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
8342 * expression.cs (Binary.ResolveOperator): Check error result in
8345 use brtrue/brfalse directly and avoid compares to null.
8347 2002-08-02 Martin Baulig <martin@gnome.org>
8349 * class.cs (TypeContainer.Define): Define all nested interfaces here.
8350 Fixes bug #28407, added test-155.cs.
8352 2002-08-01 Martin Baulig <martin@gnome.org>
8354 * class.cs (Event.EmitDefaultMethod): Make this work with static
8355 events. Fixes #28311, added verify-3.cs.
8357 2002-08-01 Martin Baulig <martin@gnome.org>
8359 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
8360 `is_disposable' fields.
8361 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
8362 `hm.is_disposable' if we're using the collection pattern.
8363 (Foreach.EmitCollectionForeach): Use the correct type for the
8364 enumerator's local variable, only emit the try/finally block if
8365 necessary (fixes #27713).
8367 2002-08-01 Martin Baulig <martin@gnome.org>
8369 * ecore.cs (Expression.report118): Renamed to Error118 and made
8372 * statement.cs (Throw.Resolve): Check whether the expression is of
8373 the correct type (CS0118) and whether the type derives from
8374 System.Exception (CS0155).
8375 (Catch.Resolve): New method. Do the type lookup here and check
8376 whether it derives from System.Exception (CS0155).
8377 (Catch.CatchType, Catch.IsGeneral): New public properties.
8379 * typemanager.cs (TypeManager.exception_type): Added.
8381 2002-07-31 Miguel de Icaza <miguel@ximian.com>
8383 * driver.cs: Updated About function.
8385 2002-07-31 Martin Baulig <martin@gnome.org>
8387 Implemented Control Flow Analysis.
8389 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
8390 (EmitContext.CurrentBranching): Added.
8391 (EmitContext.StartFlowBranching): Added.
8392 (EmitContext.EndFlowBranching): Added.
8393 (EmitContext.KillFlowBranching): Added.
8394 (EmitContext.IsVariableAssigned): Added.
8395 (EmitContext.SetVariableAssigned): Added.
8396 (EmitContext.IsParameterAssigned): Added.
8397 (EmitContext.SetParameterAssigned): Added.
8398 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
8399 Added control flow analysis stuff here.
8401 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
8402 resolve the expression as lvalue.
8403 (LocalVariableReference.DoResolve): Check whether the variable has
8404 already been assigned.
8405 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
8406 the parameter as assigned here.
8407 (ParameterReference.DoResolve): Check whether the parameter has already
8409 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
8410 expression as lvalue.
8412 * statement.cs (FlowBranching): New class for the flow analysis code.
8413 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
8414 (LabeledStatement.IsDefined): New public property.
8415 (LabeledStatement.AddUsageVector): New public method to tell flow
8416 analyis that the label may be reached via a forward jump.
8417 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
8419 (VariableInfo.Number): New public field. This is used by flow analysis
8420 to number all locals of a block.
8421 (Block.CountVariables): New public property. This is the number of
8422 local variables in this block (including the locals from all parent
8424 (Block.EmitMeta): Number all the variables.
8426 * statement.cs: Added flow analysis support to all classes.
8428 2002-07-31 Martin Baulig <martin@gnome.org>
8430 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
8431 To get debugging messages, compile mcs with /define:MCS_DEBUG and
8432 then use this argument.
8434 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
8436 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
8437 use this to specify /define options.
8439 2002-07-29 Martin Baulig <martin@gnome.org>
8441 * statement.cs (Fixed): Moved all code that does variable lookups
8442 and resolvings from Emit to Resolve.
8444 * statement.cs (For): Moved all code that does variable lookups
8445 and resolvings from Emit to Resolve.
8447 * statement.cs (Using): Moved all code that does variable lookups
8448 and resolvings from Emit to Resolve.
8450 2002-07-29 Martin Baulig <martin@gnome.org>
8452 * attribute.cs (Attribute.Resolve): Explicitly catch a
8453 System.NullReferenceException when creating the
8454 CustromAttributeBuilder and report a different warning message.
8456 2002-07-29 Martin Baulig <martin@gnome.org>
8458 * support.cs (ParameterData.ParameterName): Added method to
8459 get the name of a parameter.
8461 * typemanager.cs (TypeManager.IsValueType): New public method.
8463 2002-07-29 Martin Baulig <martin@gnome.org>
8465 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
8466 is a flag which specifies that it's either ref or out.
8467 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
8468 the out parameter to `out Parameter.Modifier mod', also set the
8469 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
8471 * support.cs (InternalParameters.ParameterModifier): Distinguish
8472 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
8473 Parameter.Modifier.ISBYREF flag if it's either ref or out.
8475 * expression.cs (Argument.GetParameterModifier): Distinguish
8476 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
8477 Parameter.Modifier.ISBYREF flag if it's either ref or out.
8479 2002-07-29 Martin Baulig <martin@gnome.org>
8481 * expression.cs (ParameterReference.ParameterReference): Added
8482 `Location loc' argument to the constructor.
8484 * cs-parser.jay: Pass location to ParameterReference.
8486 2002-07-28 Miguel de Icaza <miguel@ximian.com>
8488 * statement.cs (Try): Initialize the location.
8490 * cs-parser.jay: pass location to Try.
8492 * expression.cs (Unary.Reduce): Change the prototype to return
8493 whether a constant fold could be performed or not. The result is
8494 returned in an out parameters. In the case of Indirection and
8495 AddressOf, we want to perform the full tests.
8497 2002-07-26 Miguel de Icaza <miguel@ximian.com>
8499 * statement.cs (Statement.Emit): Flag dead code.
8501 2002-07-27 Andrew Birkett <andy@nobugs.org>
8503 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
8505 2002-07-27 Martin Baulig <martin@gnome.org>
8507 * class.cs (MethodData.Define): Put back call to
8508 TypeManager.AddMethod(), accidentally commented this out.
8510 * report.cs (Debug): New public method to print debugging information,
8511 this is `[Conditional ("DEBUG")]'.
8513 2002-07-26 Martin Baulig <martin@gnome.org>
8515 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
8516 (switch_statement): Push the current_block to the switch_stack and
8517 pop it again when we're done with the switch.
8518 (switch_section): The new block is a child of the current_block.
8519 Fixes bug #24007, added test-152.cs.
8521 2002-07-27 Martin Baulig <martin@gnome.org>
8523 * expression.cs (Invocation.EmitArguments): When calling a varargs
8524 function with only its fixed arguments, we need to pass an empty
8527 2002-07-27 Martin Baulig <martin@gnome.org>
8529 Mono 0.13 has been released.
8531 2002-07-25 Miguel de Icaza <miguel@ximian.com>
8533 * driver.cs: Rename --resource to --linkres, because that is what
8534 we do currently, we dont support --resource yet.
8536 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
8538 2002-07-25 Martin Baulig <martin@gnome.org>
8540 * class.cs (MethodData): New public class. This is a `method builder'
8541 class for a method or one accessor of a Property/Indexer/Event.
8542 (MethodData.GetMethodFlags): Moved here from MemberBase.
8543 (MethodData.ApplyAttributes): Likewise.
8544 (MethodData.ApplyObsoleteAttribute): Likewise.
8545 (MethodData.ApplyConditionalAttribute): Likewise.
8546 (MethodData.ApplyDllImportAttribute): Likewise.
8547 (MethodData.CheckAbstractAndExternal): Likewise.
8548 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
8549 (MethodData.Emit): Formerly known as Method.Emit().
8550 (MemberBase): Moved everything which was specific to a single
8551 accessor/method to MethodData.
8552 (Method): Create a new MethodData and call Define() and Emit() on it.
8553 (Property, Indexer, Event): Create a new MethodData objects for each
8554 accessor and call Define() and Emit() on them.
8556 2002-07-25 Martin Baulig <martin@gnome.org>
8558 Made MethodCore derive from MemberBase to reuse the code from there.
8559 MemberBase now also checks for attributes.
8561 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
8562 (MemberBase.GetMethodFlags): Moved here from class Method and marked
8564 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
8565 `CallingConventions cc' and `Attributes opt_attrs' arguments.
8566 (MemberBase.ApplyAttributes): New virtual method; applies the
8567 attributes to a method or accessor.
8568 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
8569 (MemberBase.ApplyConditionalAttribute): Likewise.
8570 (MemberBase.ApplyDllImportAttribute): Likewise.
8571 (MemberBase.CheckAbstractAndExternal): Likewise.
8572 (MethodCore.ParameterTypes): This is now a property instead of a
8573 method, it's initialized from DoDefineParameters().
8574 (MethodCore.ParameterInfo): Removed the set accessor.
8575 (MethodCore.DoDefineParameters): New protected virtual method to
8576 initialize ParameterTypes and ParameterInfo.
8577 (Method.GetReturnType): We can now simply return the MemberType.
8578 (Method.GetMethodFlags): Override the MemberBase version and add
8579 the conditional flags.
8580 (Method.CheckBase): Moved some code from Define() here, call
8581 DoDefineParameters() here.
8582 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
8583 here to avoid some larger code duplication.
8584 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
8585 ensure that abstract and external accessors don't declare a body.
8587 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
8588 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
8589 lookup in the attribute's parent classes, so we need to abort as soon
8590 as we found the first match.
8591 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
8592 the attribute has no arguments.
8594 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
8597 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8599 * cs-parser.jay: reverted previous patch.
8601 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8603 * cs-parser.jay: fixed bug #22119.
8605 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8607 * attribute.cs: fixed compilation. The error was:
8608 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
8609 be assigned to before control leaves the current method."
8610 [FIXME: Filed as bug #28186: MCS must report this error.]
8612 2002-07-25 Martin Baulig <martin@gnome.org>
8614 * attribute.cs (Attribute.Conditional_GetConditionName): New static
8615 method to pull the condition name ouf of a Conditional attribute.
8616 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
8617 the obsolete message and error flag out of an Obsolete attribute.
8619 * class.cs (Method.GetMethodFlags): New public method to get the
8620 TypeManager.MethodFlags for this method.
8621 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
8623 (Method.Define): Get and apply the Obsolete and Conditional attributes;
8624 if we're overriding a virtual function, set the new private variable
8625 `parent_method'; call the new TypeManager.AddMethod().
8627 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
8628 the MethodBuilder and the Method in a PtrHashtable.
8629 (TypeManager.builder_to_method): Added for this purpose.
8630 (TypeManager.MethodFlags): Added IsObsoleteError.
8631 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
8632 Obsolete and Conditional arguments in MethodBuilders. If we discover
8633 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
8634 the message from the attribute.
8636 2002-07-24 Martin Baulig <martin@gnome.org>
8638 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
8639 preprocessor directives, ensure that the argument to #define/#undef is
8640 exactly one identifier and that it's actually an identifier.
8642 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
8645 2002-07-24 Martin Baulig <martin@gnome.org>
8647 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
8648 initialize it to TypeManager.object_type in the constructor.
8649 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
8650 of the `hm.get_current' method if we're using the collection pattern.
8651 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
8652 for the explicit conversion to make it work when we're using the collection
8653 pattern and the `Current' property has a different return type than `object'.
8656 2002-07-24 Martin Baulig <martin@gnome.org>
8658 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
8659 does not match, but don't report any errors. This method is called in
8660 order for all methods in a MethodGroupExpr until a matching method is
8661 found, so we don't want to bail out if the first method doesn't match.
8662 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
8663 matches, report the 123. Fixes #28070.
8665 2002-07-24 Martin Baulig <martin@gnome.org>
8667 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
8668 TypeManager.TypeToCoreType() to the top of the method so the
8669 following equality checks will work. Fixes #28107.
8671 2002-07-24 Martin Baulig <martin@gnome.org>
8673 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
8674 operand is of type uint, and the other operand is of type sbyte,
8675 short or int, the operands are converted to type long." -
8676 Actually do what this comment already told us. Fixes bug #28106,
8679 2002-07-24 Martin Baulig <martin@gnome.org>
8681 * class.cs (MethodBase): New abstract class. This is now a base
8682 class for Property, Indexer and Event to avoid some code duplication
8683 in their Define() and DefineMethods() methods.
8684 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
8685 generic methods for Define() and DefineMethods().
8686 (FieldBase): Derive from MemberBase, not MemberCore.
8687 (Property): Derive from MemberBase, not MemberCore.
8688 (Property.DefineMethod): Moved all the code from this method to the
8689 new MethodBase.DefineAccessor(), just call it with appropriate
8691 (Property.Define): Call the new Property.DoDefine(), this does some
8692 sanity checks and we don't need to duplicate the code everywhere.
8693 (Event): Derive from MemberBase, not MemberCore.
8694 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
8695 accessors, this will also make them work with interface events.
8696 (Indexer): Derive from MemberBase, not MemberCore.
8697 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
8698 (Indexer.Define): Use the new MethodBase functions.
8700 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
8701 argument to the constructor.
8702 (Interface.FindMembers): Added support for interface events.
8703 (Interface.PopluateEvent): Implemented.
8705 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
8707 2002-07-22 Miguel de Icaza <miguel@ximian.com>
8709 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
8710 but this is required to check for a method name being the same as
8711 the containing class.
8715 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8717 * interface.cs: initialize variable.
8719 2002-07-23 Martin Baulig <martin@gnome.org>
8721 Implemented the IndexerName attribute in interfaces.
8723 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
8724 name if this is an explicit interface implementation.
8725 (Indexer.InterfaceIndexerName): New public variable. If we're
8726 implementing an interface indexer, this is the IndexerName in that
8727 interface. Otherwise, it's the IndexerName.
8728 (Indexer.DefineMethod): If we're implementing interface indexer,
8729 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
8730 and Pending.ImplementIndexer methods.
8731 (Indexer.Define): Also define the PropertyBuilder if we're
8732 implementing an interface indexer and this is neither an explicit
8733 interface implementation nor do the IndexerName match the one in
8736 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
8737 If a method is defined here, then we always need to create a proxy
8738 for it. This is used when implementing interface indexers.
8739 (Pending.IsInterfaceIndexer): New public method.
8740 (Pending.ImplementIndexer): New public method.
8741 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
8742 This is used when implementing interface indexers to define a proxy
8744 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
8745 define a proxy if necessary.
8747 * interface.cs (Interface.IndexerName): New public variable.
8748 (Interface.PopulateIndexer): Set the IndexerName.
8749 (Interface.DefineIndexers): New private method. Populate all the
8750 indexers and make sure their IndexerNames match.
8752 * typemanager.cs (IndexerPropertyName): Added support for interface
8755 2002-07-22 Martin Baulig <martin@gnome.org>
8757 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
8758 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
8759 ret if HasReturnLabel.
8760 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
8763 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
8764 and set the ec.LoopBeginTryCatchLevel.
8765 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
8766 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
8767 the current ec.TryCatchLevel, the branch goes out of an exception
8768 block. In this case, we need to use Leave and not Br.
8770 2002-07-22 Martin Baulig <martin@gnome.org>
8772 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
8773 block unless the block does not always return or it is contained in
8774 another try { ... } catch { ... } block. Fixes bug #26506.
8775 Added verify-1.cs to the test suite.
8777 2002-07-22 Martin Baulig <martin@gnome.org>
8779 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
8780 then we do not always return. Fixes bug #24985.
8782 2002-07-22 Martin Baulig <martin@gnome.org>
8784 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
8785 lookup on a per-class level; ie. walk up the class hierarchy until we
8786 found at least one applicable method, then choose the best among them.
8787 Fixes bug #24463 and test-29.cs.
8789 2002-07-22 Martin Baulig <martin@gnome.org>
8791 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
8792 return types of the methods. The return type is not part of the
8793 signature and we must not check it to make the `new' modifier work.
8794 Fixes bug #27999, also added test-147.cs.
8795 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
8797 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
8798 on the method's return type.
8800 2002-07-21 Martin Baulig <martin@gnome.org>
8802 * assign.cs: Make this work if the rightmost source is a constant and
8803 we need to do an implicit type conversion. Also adding a few more tests
8804 to test-38.cs which should have caught this.
8806 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
8807 target in the makefile for this. The makefile.gnu is primarily intended
8808 for end-users who don't want to debug the compiler.
8810 2002-07-21 Martin Baulig <martin@gnome.org>
8812 * assign.cs: Improved the Assign class so it can now handle embedded
8813 assignments (X = Y = Z = something). As a side-effect this'll now also
8814 consume less local variables. test-38.cs now passes with MCS, added
8815 a few new test cases to that test.
8817 2002-07-20 Martin Baulig <martin@gnome.org>
8819 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
8820 instructions. Fixes bug #27977, also added test-146.cs.
8822 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8824 * cs-tokenizer.cs: fixed getHex ().
8826 2002-07-19 Martin Baulig <martin@gnome.org>
8828 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
8829 not Type.GetType() to lookup the array type. This is needed when
8830 we're constructing an array of a user-defined type.
8831 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
8832 single-dimensional arrays, but also for single-dimensial arrays of
8835 2002-07-19 Martin Baulig <martin@gnome.org>
8837 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
8838 this function is called, it's not allowed to share LocalBuilders
8841 2002-07-19 Martin Baulig <martin@gnome.org>
8843 * expression.cs (Argument.Resolve): Report an error 118 when trying
8844 to pass a type as argument.
8846 2002-07-18 Martin Baulig <martin@gnome.org>
8848 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
8849 Conv_R_Un for the signed `long' type.
8851 2002-07-15 Miguel de Icaza <miguel@ximian.com>
8853 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
8854 `expr' for the temporary result, as that will fail if we do
8855 multiple resolves on the same expression.
8857 2002-07-05 Miguel de Icaza <miguel@ximian.com>
8859 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
8860 ec.TypeContainer for looking up aliases.
8862 * class.cs (TypeContainer): Remove LookupAlias from here.
8864 * decl.cs (DeclSpace); Move here.
8866 2002-07-01 Miguel de Icaza <miguel@ximian.com>
8868 * class.cs (FindMembers): Only call filter if the constructor
8869 bulider is not null.
8871 Also handle delegates in `NestedTypes' now. Now we will perform
8872 type lookups using the standard resolution process. This also
8875 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
8876 This uses Expressions (the limited kind that can be parsed by the
8877 tree) instead of strings.
8879 * expression.cs (ComposedCast.ToString): Implement, used to flag
8880 errors since now we have to render expressions.
8882 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
8885 * ecore.cs (SimpleName.ToString): ditto.
8887 * cs-parser.jay: Instead of using strings to assemble types, use
8888 Expressions to assemble the type (using SimpleName, ComposedCast,
8889 MemberAccess). This should fix the type lookups in declarations,
8890 because we were using a different code path for this.
8892 * statement.cs (Block.Resolve): Continue processing statements
8893 even when there is an error.
8895 2002-07-17 Miguel de Icaza <miguel@ximian.com>
8897 * class.cs (Event.Define): Also remove the `remove' method from
8898 the list of pending items.
8900 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
8901 generate more compact code.
8903 2002-07-17 Martin Baulig <martin@gnome.org>
8905 * const.cs (Const.LookupConstantValue): Add support for constant
8906 `unchecked' and `checked' expressions.
8907 Also adding test case test-140.cs for this.
8909 2002-07-17 Martin Baulig <martin@gnome.org>
8911 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
8912 check whether mi.ReturnType implements the IEnumerator interface; the
8913 `==' and the IsAssignableFrom() will fail in this situation.
8915 2002-07-16 Ravi Pratap <ravi@ximian.com>
8917 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
8920 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8922 * expression.cs: fixed bug #27811.
8924 2002-07-14 Miguel de Icaza <miguel@ximian.com>
8926 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
8927 Molaro: when we are a ref, the value already contains a pointer
8928 value, do not take the address of it.
8930 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
8931 * removed mb-parser.jay and mb-tokenizer.cs
8933 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
8935 * expression.cs: check against the building corlib void type.
8937 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
8939 * ecore.cs: fix for valuetype static readonly fields: when
8940 initializing them, we need their address, not the address of a copy.
8942 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
8944 * typemanager.cs: register also enum_type in corlib.
8946 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
8948 * class.cs: allow calling this (but not base) initializers in structs.
8950 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
8952 * ecore.cs: make sure we compare against the building base types
8955 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
8957 * typemanager.cs: fix TypeToCoreType() to handle void and object
8958 (corlib gets no more typerefs after this change).
8960 2002-07-12 Miguel de Icaza <miguel@ximian.com>
8962 * expression.cs (ArrayCreation.EmitArrayArguments): use
8963 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
8965 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
8966 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
8967 array indexes, the runtime actually forbids them.
8969 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
8970 for array arguments here.
8972 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
8973 instead of the default for ValueTypes.
8975 (New.DoEmit): Use IsValueType instead of
8976 IsSubclassOf (value_type)
8977 (New.DoResolve): ditto.
8978 (Invocation.EmitCall): ditto.
8980 * assign.cs (Assign): ditto.
8982 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
8983 Statements *are* currently doing part of their resolution during
8986 Expressions do always resolve during resolve, but statements are
8987 only required to propagate resolution to their children.
8989 2002-07-11 Miguel de Icaza <miguel@ximian.com>
8991 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
8993 (LoadAssembly): Do not add the dll if it is already specified
8995 (MainDriver): Add the System directory to the link path at the end,
8996 after all the other -L arguments.
8998 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
8999 wrong opcode for loading bytes and bools (ldelem.i1 instead of
9000 ldelem.u1) and using the opposite for sbytes.
9002 This fixes Digger, and we can finally run it.
9004 * driver.cs (UnixParseOption): Move the option parsing here.
9005 (CSCParseOption): Implement CSC-like parsing of options.
9007 We now support both modes of operation, the old Unix way, and the
9008 new CSC-like way. This should help those who wanted to make cross
9011 The only thing broken is that /r:, /reference: and /lib: are not
9012 implemented, because I want to make those have the same semantics
9013 as the CSC compiler has, and kill once and for all the confussion
9014 around this. Will be doing this tomorrow.
9016 * statement.cs (Unsafe.Resolve): The state is checked during
9017 resolve, not emit, so we have to set the flags for IsUnsfe here.
9019 2002-07-10 Miguel de Icaza <miguel@ximian.com>
9021 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
9022 not catch the Error_ObjectRefRequired in SimpleName (as it is
9023 possible to have a class/instance variable name that later gets
9024 deambiguated), we have to check this here.
9026 2002-07-10 Ravi Pratap <ravi@ximian.com>
9028 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
9029 make static and put into Expression.
9031 (Event.Define): Register the private field of the event with the
9032 TypeManager so that GetFieldFromEvent can get at it.
9034 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
9035 keep track of the private field associated with an event which
9038 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
9041 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
9043 2002-07-10 Miguel de Icaza <miguel@ximian.com>
9045 * expression.cs (Binary.EmitBranchable): this routine emits the
9046 Binary expression in a branchable context. This basically means:
9047 we need to branch somewhere, not just get the value on the stack.
9049 This works together with Statement.EmitBoolExpression.
9051 * statement.cs (Statement.EmitBoolExpression): Use
9054 2002-07-09 Miguel de Icaza <miguel@ximian.com>
9056 * statement.cs (For): Reduce the number of jumps in loops.
9058 (For): Implement loop inversion for the For statement.
9060 (Break): We can be breaking out of a Try/Catch controlled section
9061 (foreach might have an implicit try/catch clause), so we need to
9062 use Leave instead of Br.
9064 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
9065 now). If the instace expression supports IMemoryLocation, we use
9066 the AddressOf method from the IMemoryLocation to extract the
9067 address instead of emitting the instance.
9069 This showed up with `This', as we were emitting the instance
9070 always (Emit) instead of the Address of This. Particularly
9071 interesting when This is a value type, as we dont want the Emit
9072 effect (which was to load the object).
9074 2002-07-08 Miguel de Icaza <miguel@ximian.com>
9076 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
9078 * statement.cs (Checked): Set the CheckedState during the resolve
9079 process too, as the ConvCast operations track the checked state on
9080 the resolve process, and not emit.
9082 * cs-parser.jay (namespace_member_declaration): Flag that we have
9083 found a declaration when we do. This is used to flag error 1529
9085 * driver.cs: Report ok when we display the help only.
9087 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
9089 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
9091 2002-07-04 Miguel de Icaza <miguel@ximian.com>
9093 * cs-tokenizer.cs (define): We also have to track locally the
9094 defines. AllDefines is just used for the Conditional Attribute,
9095 but we also need the local defines for the current source code.
9097 2002-07-03 Miguel de Icaza <miguel@ximian.com>
9099 * statement.cs (While, For, Do): These loops can exit through a
9100 Break statement, use this information to tell whether the
9101 statement is the last piece of code.
9103 (Break): Flag that we break.
9105 * codegen.cs (EmitContexts): New `Breaks' state variable.
9107 2002-07-03 Martin Baulig <martin@gnome.org>
9109 * class.cs (TypeContainer.MethodModifiersValid): Allow override
9110 modifiers in method declarations in structs. Otherwise, you won't
9111 be able to override things like Object.Equals().
9113 2002-07-02 Miguel de Icaza <miguel@ximian.com>
9115 * class.cs (Method, Property, Indexer): Do not allow the public
9116 modifier to be used in explicit interface implementations.
9118 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
9119 override modifiers in method declarations in structs
9121 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
9123 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
9124 integer or real overflow, report an error
9126 2002-07-02 Martin Baulig <martin@gnome.org>
9128 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
9129 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
9130 to tell the runtime about our newly created System.Object and
9131 System.ValueType types.
9133 2002-07-02 Miguel de Icaza <miguel@ximian.com>
9135 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
9136 struct instead of Ldarg/Starg.
9138 2002-07-02 Martin Baulig <martin@gnome.org>
9140 * expression.cs (Indirection.Indirection): Call
9141 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
9143 2002-07-02 Martin Baulig <martin@gnome.org>
9145 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
9146 ValueType, call TypeManager.TypeToCoreType() on it.
9147 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
9148 the OpCodes.Newarr argument.
9150 2002-07-02 Martin Baulig <martin@gnome.org>
9152 * expression.cs (Invocation.EmitCall): When compiling corlib,
9153 replace all calls to the system's System.Array type to calls to
9154 the newly created one.
9156 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
9157 System.Array methods.
9158 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
9159 from the system's System.Array type which must be replaced.
9161 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
9163 * typemanager.cs: load unverifiable_code_ctor so we can build
9164 corlib using the correct type. Avoid using GetTypeCode() with
9166 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
9167 TypeManager.object_type to allow building corlib.
9169 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
9171 * ecore.cs: handle System.Enum separately in LoadFromPtr().
9173 2002-07-01 Martin Baulig <martin@gnome.org>
9175 * class.cs: Make the last change actually work, we need to check
9176 whether `ifaces != null' to avoid a crash.
9178 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
9180 * class.cs: when we build structs without fields that implement
9181 interfaces, we need to add the interfaces separately, since there is
9182 no API to both set the size and add the interfaces at type creation
9185 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
9187 * expression.cs: the dimension arguments to the array constructors
9188 need to be converted if they are a long.
9190 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
9192 * class.cs: don't emit ldarg.0 if there is no parent constructor
9193 (fixes showstopper for corlib).
9195 2002-06-29 Martin Baulig <martin@gnome.org>
9197 MCS now compiles corlib on GNU/Linux :-)
9199 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
9200 ie. check for MethodImplOptions.InternalCall.
9202 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
9203 and TypeManager.attribute_type are null, so we must explicitly check
9204 whether parent is not null to find out whether it's an attribute type.
9205 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
9206 and SetBuilder, not only if the property is neither abstract nor external.
9207 This is necessary to set the MethodImplOptions on the accessor methods.
9208 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
9209 SetBuilder, see Property.Emit().
9211 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
9212 populate "System.Object", "System.ValueType" and "System.Attribute" since
9213 they've already been populated from BootCorlib_PopulateCoreTypes().
9215 2002-06-29 Martin Baulig <martin@gnome.org>
9217 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
9218 is the NullLiteral, we also need to make sure that target_type is not
9221 2002-06-29 Martin Baulig <martin@gnome.org>
9223 * rootcontext.cs (RootContext.ResolveCore): We must initialize
9224 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
9225 before calling BootstrapCorlib_ResolveDelegate ().
9227 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9229 * statement.cs: fixed build-breaker. All tests passed ok.
9231 2002-06-27 Martin Baulig <martin@gnome.org>
9233 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
9234 for System.Decimal when compiling corlib.
9236 2002-06-27 Martin Baulig <martin@gnome.org>
9238 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
9239 switch blocks which contain nothing but a default clause.
9241 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
9243 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
9245 2002-06-27 Martin Baulig <martin@gnome.org>
9247 * ecore.cs (PropertyExpr.PropertyExpr): Call
9248 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
9250 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
9251 is already a TypeBuilder.
9253 2002-06-27 Martin Baulig <martin@gnome.org>
9255 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
9256 `target_type == TypeManager.array_type', not IsAssignableFrom() in
9257 the "from an array-type to System.Array" case. This makes it work
9258 when compiling corlib.
9260 2002-06-27 Martin Baulig <martin@gnome.org>
9262 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
9263 non-static PropertyExpr, set its InstanceExpression. This makes
9264 the `ICollection.Count' property work in System/Array.cs.
9266 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
9268 * driver.cs: Made error handling more consistent. Errors now
9269 tracked by Report class, so many methods which used to return int
9270 now return void. Main() now prints success/failure and
9271 errors/warnings message.
9273 Renamed '--probe' compiler argument to '--expect-error'. Removed
9274 the magic number return values (123 and 124). Now, if the
9275 expected error occurs, the compiler exits with success (exit value
9276 0). If the compilation completes without seeing that particular
9277 error, the compiler exits with failure (exit value 1). The
9278 makefile in mcs/errors has been changed to handle the new behaviour.
9280 * report.cs: Made 'expected error' number a property and renamed
9281 it from 'Probe' to 'ExpectedError'.
9283 * genericparser.cs: Removed error handling support, since it is
9284 now all done by Report class.
9286 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
9287 class, so parse() no longer returns an int.
9289 * namespace.cs: Use Report.Error instead of GenericParser.error
9291 2002-06-22 Miguel de Icaza <miguel@ximian.com>
9293 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
9294 TypeContainer.AddOperator): At the front of the list put the
9295 explicit implementations, so they get resolved/defined first.
9297 2002-06-21 Miguel de Icaza <miguel@ximian.com>
9299 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
9300 interface type is implemented by this TypeContainer. Used during
9301 explicit interface implementation.
9303 (Property.Define, Indexer.Define, Method.Define): Validate that
9304 the given interface in the explicit implementation is one of the
9305 base classes for the containing type.
9307 Also if we are explicitly implementing an interface, but there is
9308 no match in the pending implementation table, report an error.
9310 (Property.Define): Only define the property if we are
9311 not explicitly implementing a property from an interface. Use the
9312 correct name also for those properties (the same CSC uses,
9313 although that is really not needed).
9315 (Property.Emit): Do not emit attributes for explicitly implemented
9316 properties, as there is no TypeBuilder.
9318 (Indexer.Emit): ditto.
9320 Hiding then means that we do not really *implement* a pending
9321 implementation, which makes code fail.
9323 2002-06-22 Martin Baulig <martin@gnome.org>
9325 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
9326 the return value of Object.GetType(). [FIXME: we need to do this whenever
9327 we get a type back from the reflection library].
9329 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
9331 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
9333 2002-06-20 Miguel de Icaza <miguel@ximian.com>
9335 * attribute.cs: Return null if we can not look up the type.
9337 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
9338 the interface types found.
9340 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
9341 interface types found.
9343 * typemanager.cs (GetInterfaces): Make this routine returns alll
9344 the interfaces and work around the lame differences between
9345 System.Type and System.Reflection.Emit.TypeBuilder in the results
9346 result for GetInterfaces.
9348 (ExpandInterfaces): Given an array of interface types, expand and
9349 eliminate repeated ocurrences of an interface. This expands in
9350 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
9353 2002-06-21 Martin Baulig <martin@gnome.org>
9355 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
9358 2002-06-21 Martin Baulig <martin@gnome.org>
9360 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
9361 and called with one of the core types, return the corresponding typebuilder for
9364 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
9367 2002-06-21 Martin Baulig <martin@gnome.org>
9369 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
9370 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
9371 (Expression.ConvertReferenceExplicit): Likewise.
9373 * expression.cs (ElementAccess.DoResolve): Likewise.
9374 (ElementAccess.DoResolveLValue): Likewise.
9376 2002-06-10 Martin Baulig <martin@gnome.org>
9378 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
9379 add the "value" parameter to the parameter list.
9381 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
9384 2002-06-19 Miguel de Icaza <miguel@ximian.com>
9386 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
9387 the argument to an int, uint, long or ulong, per the spec. Also
9388 catch negative constants in array creation.
9390 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
9392 * class.cs: do not allow the same interface to appear twice in
9393 the definition list.
9395 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
9397 * ecore.cs: don't use ldlen with System.Array.
9399 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
9401 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
9403 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
9405 * modifiers.cs: produce correct field attributes for protected
9406 internal. Easy fix so miguel can work on ther harder stuff:-)
9408 2002-06-18 Miguel de Icaza <miguel@ximian.com>
9410 * pending.cs: New file. Move the code from class.cs here.
9411 Support clearning the pending flag for all methods (when not doing
9412 explicit interface implementation).
9414 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
9416 * rootcontext.cs: added a couple more types needed to bootstrap.
9418 2002-06-17 Miguel de Icaza <miguel@ximian.com>
9420 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
9421 constructor in the type, instead of any constructor in the type
9422 hierarchy. Thanks to Paolo for finding this bug (it showed up as
9423 a bug in the Mono runtime when applying the params attribute).
9425 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
9426 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
9428 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
9430 * expression.cs (Unary.ResolveOperator): Use TypeManager
9431 to resolve the type.
9433 2002-06-13 Ravi Pratap <ravi@ximian.com>
9435 * cs-parser.jay (enum_member_declaration): Pass in the attributes
9438 * enum.cs (AddEnumMember): Add support to store the attributes associated
9439 with each member too.
9441 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
9442 field builders too - this takes care of the enum member case.
9444 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
9446 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
9447 address-of operator on both value types and pointers.
9449 2002-06-10 Martin Baulig <martin@gnome.org>
9451 * interface.cs (Interface.PopulateIndexer): Add the indexer's
9452 PropertyBuilder to the `property_builders' list.
9454 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
9455 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
9456 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
9457 find any indexers which are inherited from an interface.
9459 2002-06-09 Martin Baulig <martin@gnome.org>
9461 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
9462 the same type as the constant if necessary. There's also a test-130.cs
9465 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
9467 * typemanager.cs (TypeManager.ChangeType): Previously known as
9468 Enum.ChangeEnumType().
9470 2002-06-09 Martin Baulig <martin@gnome.org>
9472 * expression.cs (Cast.TryReduce): Added support for consts.
9474 2002-06-08 Ravi Pratap <ravi@ximian.com>
9476 * class.cs (Accessor): Hold attributes information so we can pass
9479 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
9480 Modify to pass in attributes attached to the methods.
9482 (add_accessor_declaration, remove_accessor_declaration): Ditto.
9484 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
9485 to handle the Accessor kind :-)
9487 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
9489 2002-06-08 Martin Baulig <martin@gnome.org>
9491 * expression.cs (Unary.TryReduceNegative): Added support for
9494 2002-06-08 Martin Baulig <martin@gnome.org>
9496 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
9497 name can't be found in the `defined_names' - the caller will do a
9498 MemberLookup in this case and thus find methods in System.Enum
9499 such as Enum.IsDefined().
9501 2002-06-08 Martin Baulig <martin@gnome.org>
9503 * enum.cs (Enum.ChangeEnumType): This is a custom version of
9504 Convert.ChangeType() which works with TypeBuilder created types.
9505 (Enum.LookupEnumValue, Enum.Define): Use it here.
9507 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
9508 `TypeBuilder.BaseType != null' check.
9509 (TypeContainer.FindMembers): Only lookup parent members if we
9510 actually have a parent.
9511 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
9512 (ConstructorInitializer.Resolve): Likewise.
9514 * interface.cs (Interface.FindMembers): Added
9515 `TypeBuilder.BaseType != null' check.
9517 * rootcontext.cs (RootContext.ResolveCore): Added
9518 "System.Runtime.CompilerServices.IndexerNameAttribute" to
9519 classes_second_stage.
9521 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
9522 debug_type and trace_type when compiling with --nostdlib.
9524 2002-06-07 Martin Baulig <martin@gnome.org>
9526 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
9527 (AddField): Set it to true when adding a non-static field.
9528 (DefineType): Use `have_nonstatic_fields' to find out whether we
9529 have non-static fields, not `Fields != null'.
9531 2002-06-02 Miguel de Icaza <miguel@ximian.com>
9533 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
9534 dereferencing a null on the static-field code path)
9536 2002-05-30 Martin Baulig <martin@gnome.org>
9538 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
9539 to take command line arguments. Use reflection to call the new
9540 custom `Initialize' function on the symbol writer and pass it the
9541 command line arguments.
9543 * driver.cs (--debug-args): New command line argument to pass command
9544 line arguments to the symbol writer.
9546 2002-05-28 Miguel de Icaza <miguel@ximian.com>
9548 * assign.cs (DoResolve): Forgot to do the implicit conversion to
9549 the target type for indexers and properties. Thanks to Joe for
9552 2002-05-27 Miguel de Icaza <miguel@ximian.com>
9554 * typemanager.cs (MethodFlags): returns the method flags
9555 (Obsolete/ShouldIgnore) that control warning emission and whether
9556 the invocation should be made, or ignored.
9558 * expression.cs (Invocation.Emit): Remove previous hack, we should
9559 not do this on matching a base type, we should do this based on an attribute
9561 Only emit calls to System.Diagnostics.Debug and
9562 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
9563 on the command line.
9565 * rootcontext.cs: Global settings for tracing and debugging.
9567 * cs-tokenizer.cs (define): New utility function to track
9568 defines. Set the global settings for TRACE and DEBUG if found.
9570 2002-05-25 Ravi Pratap <ravi@ximian.com>
9572 * interface.cs (Populate*): Pass in the TypeContainer as well as
9573 the DeclSpace as parameters so that we can create EmitContexts and
9574 then use that to apply attributes etc.
9576 (PopulateMethod, PopulateEvent, PopulateProperty)
9577 (PopulateIndexer): Apply attributes everywhere.
9579 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
9582 (ApplyAttributes): Update accordingly.
9584 We now apply interface attributes for all members too.
9586 2002-05-26 Miguel de Icaza <miguel@ximian.com>
9588 * class.cs (Indexer.Define); Correctly check if we are explicit
9589 implementation (instead of checking the Name for a ".", we
9590 directly look up if the InterfaceType was specified).
9592 Delay the creation of the PropertyBuilder.
9594 Only create the PropertyBuilder if we are not an explicit
9595 interface implementation. This means that explicit interface
9596 implementation members do not participate in regular function
9597 lookups, and hence fixes another major ambiguity problem in
9598 overload resolution (that was the visible effect).
9600 (DefineMethod): Return whether we are doing an interface
9603 * typemanager.cs: Temporary hack until we get attributes in
9604 interfaces (Ravi is working on that) and we get IndexerName
9605 support in interfaces.
9607 * interface.cs: Register the indexers as properties.
9609 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
9610 warning, I have verified that this is a bug in the .NET runtime
9611 (JavaScript suffers of the same problem).
9613 * typemanager.cs (MemberLookup): When looking up members for
9614 interfaces, the parent of an interface is the implicit
9615 System.Object (so we succeed in searches of Object methods in an
9616 interface method invocation. Example: IEnumerable x; x.ToString
9619 2002-05-25 Miguel de Icaza <miguel@ximian.com>
9621 * class.cs (Event): Events should also register if they do
9622 implement the methods that an interface requires.
9624 * typemanager.cs (MemberLookup); use the new GetInterfaces
9627 (GetInterfaces): The code used to lookup interfaces for a type is
9628 used in more than one place, factor it here.
9630 * driver.cs: Track the errors at the bottom of the file, we kept
9633 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
9634 instance if the method we are calling is static!
9636 2002-05-24 Miguel de Icaza <miguel@ximian.com>
9638 * attribute.cs (ApplyAttributes): Make this function filter out
9639 the IndexerName attribute (as that attribute in reality is never
9640 applied) and return the string constant for the IndexerName
9643 * class.cs (TypeContainer.Emit): Validate that all the indexers
9644 have the same IndexerName attribute, and if so, set the
9645 DefaultName attribute on the class.
9647 * typemanager.cs: The return value might contain other stuff (not
9648 only methods). For instance, consider a method with an "Item"
9649 property and an Item method.
9651 * class.cs: If there is a problem with the parameter types,
9654 2002-05-24 Ravi Pratap <ravi@ximian.com>
9656 * ecore.cs (ImplicitConversionExists): Wrapper function which also
9657 looks at user defined conversion after making a call to
9658 StandardConversionExists - we need this for overload resolution.
9660 * expression.cs : Update accordingly the various method calls.
9662 This fixes 2 bugs filed against implicit user defined conversions
9664 2002-05-22 Miguel de Icaza <miguel@ximian.com>
9666 * statement.cs: Track the result of the assignment.
9668 2002-05-21 Miguel de Icaza <miguel@ximian.com>
9670 * expression.cs (MemberAccess): Improved error reporting for
9671 inaccessible members.
9673 2002-05-22 Martin Baulig <martin@gnome.org>
9675 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
9676 itself with debugging support.
9678 2002-05-22 Martin Baulig <martin@gnome.org>
9680 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
9681 Removed, this isn't needed anymore.
9683 2002-05-20 Martin Baulig <martin@gnome.org>
9685 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
9686 be underlying type for an enum.
9688 2002-05-20 Miguel de Icaza <miguel@ximian.com>
9690 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
9691 that splits out the loading of just the core types.
9693 * rootcontext.cs (ResolveCore): Split the struct resolution in
9694 two, so we can load the enumeration underlying types before any
9697 * expression.cs (Is): Bandaid until we fix properly Switch (see
9698 bug #24985 for details).
9700 * typemanager.cs (ImplementsInterface): The hashtable will contain
9701 a null if there are no interfaces implemented.
9703 2002-05-18 Miguel de Icaza <miguel@ximian.com>
9705 * cs-parser.jay (indexer_declarator): It is fine to have array
9708 2002-05-17 Miguel de Icaza <miguel@ximian.com>
9710 * typemanager.cs: (RegisterBuilder): New function used to register
9711 TypeBuilders that implement interfaces. Since
9712 TypeBuilder.GetInterfaces (as usual) does not work with lame
9714 (AddUserType): register interfaces.
9716 (ImplementsInterface): Use the builder_to_ifaces hash if we are
9717 dealing with TypeBuilder. Also, arrays are showing up as
9718 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
9719 methods can not be invoked on them!
9721 * ecore.cs (ExplicitReferenceConversionExists): Made public.
9722 (ImplicitReferenceConversionExists): Split out from
9723 StandardConversionExists.
9725 * expression.cs (As): We were only implementing one of the three
9726 cases for the as operator. We now implement them all.
9727 (Is): Implement the various other cases for Is as well.
9729 * typemanager.cs (CACHE): New define used to control if we want or
9730 not the FindMembers cache. Seems to have a negative impact on
9731 performance currently
9733 (MemberLookup): Nested types have full acess to
9734 enclosing type members
9736 Remove code that coped with instance/static returns for events, we
9737 now catch this in RealFindMembers.
9739 (RealFindMembers): only perform static lookup if the instance
9740 lookup did not return a type or an event.
9742 2002-05-17 Miguel de Icaza <miguel@ximian.com>
9744 * assign.cs (CompoundAssign): We pass more semantic information
9745 now to Compound Assignments than we did before: now we have all
9746 the information at hand, and now we resolve the target *before* we
9747 do the expression expansion, which allows the "CacheValue" method
9748 to have the effect we intended (before, a [x] += 1 would generate
9749 two differen ArrayAccess expressions from the ElementAccess,
9750 during the resolution process).
9752 (CompoundAssign.DoResolve): Resolve target and original_source here.
9754 2002-05-16 Miguel de Icaza <miguel@ximian.com>
9756 * expression.cs (ArrayAccess): dropped debugging information.
9758 * typemanager.cs: Small bug fix: I was always returning i_members,
9759 instead of one of i_members or s_members (depending on which had
9762 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
9763 method is invoked before any code generation takes place, and it
9764 is a mechanism to inform that the expression will be invoked more
9765 than once, and that the method should use temporary values to
9766 avoid having side effects
9768 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
9770 * ecore.cs (Expression.CacheTemporaries): Provide empty default
9773 * expression.cs (Indirection, ArrayAccess): Add support for
9774 CacheTemporaries in these two bad boys.
9776 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
9778 (StoreFromPtr): Handle stobj as well.
9780 * expression.cs (UnaryMutator): Share more code.
9782 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
9783 down: I was not tracking the Filter function as well, which
9784 was affecting the results of the cache.
9786 2002-05-15 Miguel de Icaza <miguel@ximian.com>
9788 * attribute.cs: Remove the hack to handle the CharSet property on
9791 2002-05-14 Miguel de Icaza <miguel@ximian.com>
9793 * attribute.cs (DoResolve): More uglyness, we now only try to
9794 resolve the attribute partially, to extract the CharSet
9795 information (only if we are a StructLayout attribute). Otherwise
9797 (GetExtraTypeInfo): Add some code to conditionally kill in the
9798 future this. I am more and more convinced that the .NET
9799 framework has special code to handle the attribute setting on
9802 * expression.cs (IsParamsMethodApplicable): Revert my previous
9803 foreach change here, it was wrong.
9805 2002-05-13 Miguel de Icaza <miguel@ximian.com>
9807 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
9808 (pp_expr): do not abort on unknown input, just return.
9809 (eval): abort if there are pending chars.
9811 * attribute.cs (Attribute.Resolve): Positional parameters are
9812 optional. Deal with that case.
9814 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
9815 the Ansi/Unicode/Auto information for the type.
9817 (TypeContainer.DefineType): instantiate the EmitContext here, as
9818 we will be using it during the type definition (to resolve
9819 attributes) and during the emit phase.
9821 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
9822 to pull type information out of the attributes
9824 (Attribute.Resolve): track the constructor builder, and allow for
9825 multiple invocations (structs and classes will use this).
9827 * ecore.cs (MemberLookupFinal): new version with all the
9828 parameters customizable.
9830 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
9831 constructors. Return if the result value is null (as the error
9832 would have been flagged already by MemberLookupFinal)
9834 Do not allow instances of abstract classes or interfaces to be
9837 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
9838 We have to compare the assembly property here when dealing with
9839 FamANDAssem and Assembly access modifiers, because we might be
9840 creating an assembly from *modules* (that means that we are not
9841 getting TypeBuilders for types defined in other modules that are
9842 part of this assembly).
9844 (Method.Emit): If the method is marked abstract and has a body,
9847 (TypeContainer.DefineMembers): If both the defined member and the
9848 parent name match are methods, then do not emit any warnings: let
9849 the Method.Define routine take care of flagging warnings. But if
9850 there is a mismatch (method overrides something else, or method is
9851 overriwritten by something, then emit warning).
9853 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
9854 set to null, this means `do not check for the return type on the
9857 (Method.Define): set the return type for the method signature to
9858 null, so that we get methods with the same name and parameters and
9859 different return types. This is used to flag warning 114 (you are
9860 hiding a method, and you probably want to use the new/override
9863 * typemanager.cs (MemberLookup): Implemented proper access
9864 control, closing a long standing set of bug reports. The problem
9865 was that the Framework only has two bits: Public and NonPublic,
9866 and NonPublic includes private and protected methods, but we need
9867 to enforce the FamANDAssem, FamOrAssem and Family.
9869 2002-05-11 Miguel de Icaza <miguel@ximian.com>
9871 * statement.cs (GotoCase): Return true: Ammounts to giving up
9872 knowledge on whether we return or not, and letting the other case
9873 be responsible for it.
9875 2002-05-10 Miguel de Icaza <miguel@ximian.com>
9877 * driver.cs: Do not load directories for each file processed, only
9878 do it if there is a pattern.
9880 * ecore.cs: Report readonly assigns here as well, as we might have
9881 been resolved only by MemberAccess.
9883 (SimpleName.SimpleNameResolve): Also be useful for LValue
9884 resolution. We need this to propagate assign to local readonly variables
9886 * typemanager.cs: Use a ptrhashtable for the criteria, because we
9887 do not want to reuse potential criteria memory.
9889 * class.cs (MyEventBuilder): Set reflected_type;
9891 * ecore.cs (Constantify): Added support for constifying bools.
9893 (RootContext.LookupType): Added a cache for values looked up in
9894 the declaration space.
9896 * typemanager.cs (FindMembers): Now is a front-end to
9897 RealFindMembers, and provides a two-level hashtable-based cache to
9900 15% performance improvement: from 22.5 to 19.2 seconds.
9902 * expression.cs (IsParamsMethodApplicable): use foreach.
9903 (Invocation.DoResolve): ditto.
9904 (New.DoResolve): ditto.
9905 (ArrayCreation.DoResolve): ditto.
9907 * ecore.cs (FindMostEncompassingType): use foreach.
9909 * delegate.cs (NewDelegate.DoResolve): Use foreach
9911 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
9912 (RemoveMethods): use foreach.
9914 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
9915 nested foreach statements instead of for, and also break out of
9916 the inner loop once a match is found.
9918 (Invocation.OverloadResolve): Use foreach, simplify the code.
9920 2002-05-08 Miguel de Icaza <miguel@ximian.com>
9922 * cfold.cs (BinaryFold): During an enumeration evaluation context,
9923 we actually unwrap the expression to allow for extra information
9926 * expression.cs: Use Shr_Un on unsigned operations.
9928 2002-05-08 Ravi Pratap <ravi@ximian.com>
9930 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
9931 applicable operators was not being considered correctly. This closes
9932 the bug Miguel reported.
9934 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
9936 * attribute.cs: check that the type derives from System.Attribute
9937 and report the correct error in that case (moved the duplicate code to
9938 its own method, too).
9940 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
9942 * attribute.cs: lookup attribute type name as the spec says: first the
9943 bare attribute name and then name + "Attribute" (nant compiles with
9944 mcs after this fix).
9946 2002-05-07 Miguel de Icaza <miguel@ximian.com>
9948 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
9949 Because of the way we parse things, we should try to see if a
9950 UIntConstant can fit in an integer.
9952 2002-05-07 Ravi Pratap <ravi@ximian.com>
9954 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
9955 when we are in an explicit context.
9957 (ConvertReferenceExplicit): When converting from Iface type S to Class
9958 T make sure the rules are implemented as an OR.
9960 * parameter.cs (ParameterType): Make it a property for now although the
9961 purpose really isn't anything immediate.
9963 * expression.cs (Is*Applicable): Do better checking on the parameter type
9964 of a ref/out parameter. The ones from the system assemblies are already
9965 marked with the correct type so we don't need to do any correction.
9967 * ecore.cs (StandardConversionExists): Conversion from Interface types to
9968 the object type is standard too so include that.
9970 2002-05-06 Miguel de Icaza <miguel@ximian.com>
9972 * ecore.cs (StandardConversionExists): Augment with missing code:
9973 deal with IntConstant, LongConstants and Enumerations.
9975 * assign.cs: Report the error, instead of failing silently
9977 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
9978 typecontainer that they are declared, because the
9979 typecontainer/namespace will have the list of using clauses that
9982 Assembly Attributes were escaping the normal registration
9985 (EmitCode): Apply attributes within an EmitContext that represents
9986 the container they were declared on.
9988 * cs-parser.jay: Track bases for structs. How did I get this wrong?
9990 2002-05-06 Ravi Pratap <ravi@ximian.com>
9992 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
9993 Revamp completely - make much cleaner as we now operate only
9996 (FindMostSpecificSource, FindMostSpecificTarget): New methods
9997 to implement the logic detailed in the spec more correctly.
9999 (UserDefinedConversion): Update accordingly.
10001 2002-05-06 Miguel de Icaza <miguel@ximian.com>
10003 * statement.cs: Return flow analysis information up.
10005 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
10008 (token): Do not consume an extra character before calling
10011 2002-05-06 Piers Haken <piersh@friskit.com>
10013 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
10015 2002-05-06 Miguel de Icaza <miguel@ximian.com>
10017 * class.cs (Constructor.Emit): Set the IsStatic flag in the
10018 EmitContext during the instance constructor initializer
10019 resolution, to stop access to instance variables.
10021 This is mandated by the spec, last paragraph of the `constructor
10022 initializers' section.
10024 2002-05-05 Miguel de Icaza <miguel@ximian.com>
10026 * cs-parser.jay, class.cs (Accessor): new class used to represent
10027 an accessor (get or set). In the past we used `null' to represent
10028 a missing accessor. But this is ambiguous because there was no
10029 way to tell in abstract indexers/properties if one of them was
10032 Now there is a way of addressing that.
10034 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
10035 instead of FindMembers.
10037 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
10038 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
10040 * attribute.cs: Treat indexers and properties as the same in terms
10041 of applying attributes
10043 * ecore.cs (FindMostEncompassedType): Use statically initialized
10044 EmptyExpressions()s like we do elsewhere to avoid creating useless
10045 objects (and we take this out of the tight loop).
10047 (GetConversionOperators): Move the code to extract the actual
10048 operators to a separate routine to clean things up.
10050 2002-05-04 Miguel de Icaza <miguel@ximian.com>
10052 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
10053 events are always registered FieldBuilders.
10055 * class.cs (FieldBase): New class shared by Fields
10057 * delegate.cs: If we are a toplevel delegate, use our full name.
10058 If we are a nested delegate, then only use our tail name.
10060 2002-05-02 Ravi Pratap <ravi@ximian.com>
10062 * expression.cs (IsApplicable): Ensure that we add the "&" to
10063 ref/out types before comparing it with the type of the argument.
10065 (IsParamsMethodApplicable): Ditto.
10067 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
10070 * delegate.cs : Handle the case when we have more than one applicable
10071 method. Flag an error only when we finish checking all.
10073 2002-05-02 Miguel de Icaza <miguel@ximian.com>
10075 * expression.cs: Add support for boolean static initializers.
10077 2002-05-01 Miguel de Icaza <miguel@ximian.com>
10079 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
10081 * parameter.cs (ComputeParameterTypes,
10082 ComputeAndDefineParameterTypes): Better error handling: now we
10083 clear the `types' cache if we fail during any of the type lookups.
10084 We also return the status code correctly to our caller
10086 * delegate.cs: If we fail to define a delegate, abort the extra
10089 * expression.cs (Binary.ResolveOperator): for
10090 operator==(object,object) and operator !=(object, object) we also
10091 have to verify that there is an implicit conversion from one to
10094 (ArrayAccess.DoResolve): Array Access can operate on
10097 2002-04-30 Miguel de Icaza <miguel@ximian.com>
10099 * assign.cs (CompoundAssign): A new class used as a "flag" that
10100 the assignment actually is happening as part of a compound
10101 assignment operator.
10103 During compound assignment, a few new rules exist to enable things
10110 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
10111 to the type of x) if y is implicitly convertible to the type of x,
10112 and the operator is a builtin operator and the return type of the
10113 operator is explicitly convertible to the type of x.
10115 * rootcontext.cs: Reset warning level to 2. 4 catches various
10116 "interesting" features in mcs, we must clean this up at some
10117 point, but currently am trying to kill other bugs ;-)
10119 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
10120 in container classes as well.
10122 * expression.cs (Binary.ResolveOperator): Handle string case
10123 before anything else (as operator overloading does emit an error
10124 before doing anything else).
10126 This code could go away when we move to a table driven model, but
10127 i could not come up with a good plan last night.
10129 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
10131 * typemanager.cs (CSharpName): reimplementation using regex.
10132 * class.cs: added null check for fields in Emit
10133 * rootcontext.cs: set warninglevel to 4
10135 2002-04-29 Miguel de Icaza <miguel@ximian.com>
10137 * typemanager.cs (CSharpName): reimplemented with Lupus
10140 2002-04-28 Miguel de Icaza <miguel@ximian.com>
10142 * statement.cs (If): correclty implement Resolve, because we were
10143 not catching sem errors in there. The same process is needed
10145 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
10148 (Statement.Warning_DeadCodeFound): Factorize code.
10149 (While): Report dead code here too.
10151 (Statement): Added Resolve virtual method to allow
10152 for resolution split from the emit code.
10154 2002-04-26 Miguel de Icaza <miguel@ximian.com>
10156 * statement.cs (EmitBoolExpression): No longer try to resolve the
10158 (MakeBoolean): New utility function that resolve, implicitly
10159 converts to boolean and tags the expression.
10162 (If, Do): Implement dead code elimination.
10163 (While): Implement loop inversion
10165 (Do, While, For, If): Resolve the expression prior to calling our
10168 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
10171 - added method Report28 (warning: program has more than one entry point)
10172 - added method IsEntryPoint, implements paragraph 10.1 of the spec
10173 - modified method Method.Define, the part at the end of the method
10175 * rootcontext.cs: added static public Location EntryPointLocation;
10177 * ../errors/cs0028.cs : Add test case for the above warning.
10180 - modified method CSharpName to allow arrays of primitive type to
10181 be printed nicely (e.g. instead of System.Int32[][] it now prints
10183 - added method CSharpSignature: returns the signature of a method
10184 in string format to be used in reporting errors, warnings, etc.
10186 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
10189 2002-04-26 Ravi Pratap <ravi@ximian.com>
10191 * delegate.cs (Define): Fix extremely silly bug where I was
10192 setting the type of the 'object' parameter of the BeginInvoke
10193 method to System.IAsyncResult instead of System.Object ;-)
10195 2002-04-26 Miguel de Icaza <miguel@ximian.com>
10197 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
10200 (Constructor.Emit): return if we fail to initialize the
10201 constructor. Another door closed!
10203 * expression.cs (New.DoResolve): Improve error message (from -6 to
10204 1501). Use DeclaredOnly lookup to find the exact constructor.
10206 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
10207 loop. This is useful.
10209 * cs-parser.jay: Adjust the default parameters so that destructors
10210 have the proper signature.
10212 2002-04-26 Martin Baulig <martin@gnome.org>
10214 * driver.cs (LoadAssembly): If `assembly' contains any characters
10215 which are only valid in path names and not in assembly names
10216 (currently slash, backslash and point), use Assembly.LoadFrom ()
10217 instead of Assembly.Load () on the `assembly' (before iteration
10218 over the link_paths).
10220 2002-04-26 Martin Baulig <martin@gnome.org>
10222 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
10224 2002-04-25 Miguel de Icaza <miguel@ximian.com>
10226 * class.cs (Property): use the new typemanager.MemberLookup
10228 (TypeContainer.MemberLookup): Implement using the
10229 TypeManager.MemberLookup now.
10231 * typemanager.cs: Make MemberLookup a function of the TypeManager,
10232 and return MemberInfos, so that these can be used without an
10233 EmitContext (what we had before).
10235 2002-04-24 Miguel de Icaza <miguel@ximian.com>
10237 * expression.cs: Fix the case where the argument to params if the
10238 type of the params. I omitted handling this before. Fixed
10240 2002-04-22 Miguel de Icaza <miguel@ximian.com>
10242 * driver.cs: Call BootCorlib_PopulateCoreType
10244 * class.cs (Property.CheckBase): Check for properties only, not
10247 * interface.cs: Temporary hack: try/catch around the
10248 CustomAttributeBuilder, because I am getting an exception that I
10251 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
10252 types whose definitions are required to be there (attributes are
10253 defined before standard types).
10255 Compute definitions as we boot the various types, as they are used
10256 immediately (value_type class will need object_type, but if we do
10257 not initialize object_type, we will pass a null, which will let
10258 the runtime pick the System.Object from the existing corlib, which
10259 is not what we want).
10261 2002-04-22 Patrik Torstensson <totte@labs2.com>
10263 * cs-tokenizer.cs: fixed a number of trim() issues.
10265 2002-04-22 Ravi Pratap <ravi@ximian.com>
10267 * expression.cs (Argument.Type): Ensure that we return the correct
10268 type when we have out or ref parameters [in which case we
10271 2002-04-22 Miguel de Icaza <miguel@ximian.com>
10273 * class.cs (Property, Indexer): Allow extern modifier in there.
10275 * typemanager.cs (InitBaseTypes): Initializes object_type and
10276 value_type, since those will be used early on during the bootstrap
10277 process to compile corlib.
10279 (InitCoreTypes): Move code from here to InitBaseTypes.
10281 2002-04-21 Miguel de Icaza <miguel@ximian.com>
10283 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
10284 single-dimension arrays as using the ldlen opcode.
10286 Daniel Lewis discovered this optimization.
10288 * typemanager.cs: Add signature for System.Array::get_Length
10290 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10292 * statement.cs: report the error when the foreach does not apply to an
10293 array nor a collection.
10295 2002-04-19 Miguel de Icaza <miguel@ximian.com>
10297 * expression.cs: Add implicit conversions to the operator ~.
10299 * constant.cs (DecimalConstant.Emit): Emit decimal value.
10301 * typemanager.cs: Locate the decimal constructor.
10303 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10305 * attribute.cs: use the new property of TypeOf.
10306 * expression.cs: added 'get' property around typearg.
10308 These changes fix a build breaker reported by NickD. Is this the
10309 correct way to fix? If not, please, revert my changes and make it
10312 2002-04-17 Miguel de Icaza <miguel@ximian.com>
10314 * attribute.cs: Add support for typeof in attribute invocations.
10315 I am not sure that this is right though.
10317 2002-04-14 Duncan Mak <duncan@ximian.com>
10319 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
10320 Binary.Operator.Division case.
10322 2002-04-13 Ravi Pratap <ravi@ximian.com>
10324 * class.cs (DefineType): Ensure that we do a proper check on
10325 attribute types and also register it with the TypeManager.
10327 (TypeContainer.Targets): The default for attribute types is
10328 AttributeTargets.All.
10330 * attribute.cs (ApplyAttributes): Registering the attribute type
10331 is done elsewhere, not when we discover we have a Usage attribute.
10333 2002-04-12 Ravi Pratap <ravi@ximian.com>
10335 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
10336 and get rid of is_delegate parameter.
10338 * everywhere : update.
10340 2002-04-12 Ravi Pratap <ravi@ximian.com>
10342 * cs-parser.jay (compilation_unit): Revamp completely to use
10343 some new ideas that I got from Rhys' grammar to solve the problems
10344 with assembly level attributes.
10346 (outer_declaration): New grammar production.
10348 (attribute_sections): Add.
10350 (opt_attributes): Base on attribute_sections
10352 (namespace_declaration): Allow opt_attributes to tackle the case
10353 when we have assembly level attributes - we are clever in this
10356 * attribute.cs (ApplyAttributes): Do not worry about assembly
10357 attributes in the non-global context.
10359 * rootcontext.cs (AddGlobalAttributes): Go back to using this
10360 instead of SetGlobalAttributes.
10362 * class.cs, rootcontext.cs : Ensure we define and generate
10363 attribute types before anything else.
10365 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
10366 and flag the new error -20 for the case when the attribute type
10367 does not have valid targets specified. csc does not catch this.
10369 * ../errors/errors.txt : update for error # -20
10371 2002-04-11 Ravi Pratap <ravi@ximian.com>
10373 * support.cs (InternalParameters.ParameterModifier): Do some null
10374 checking and return sane values.
10376 * class.cs (Method.Define): If we are a PInvoke method, ensure
10377 that we are static and extern. Report error # 601
10379 * ../errors/cs0601.cs : Add test case for the above error.
10381 2002-04-07 Ravi Pratap <ravi@ximian.com>
10383 * rootcontext.cs (attribute_types): We need to keep type of
10384 all attribute types separately and emit code for them first.
10386 (RegisterAttribute) : Implement.
10388 * class.cs (DefineType): Check if the current Type is a custom
10389 attribute type and register it accordingly.
10391 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
10392 adding the first attribute twice and rename to
10394 (SetGlobalAttributes): this.
10396 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
10399 * attribute.cs (ApplyAttributes): Take an additional argument telling us
10400 if we are processing global arguments. Hmm, I am unsure of this.
10402 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10404 * expression.cs: added static array of strings to avoid calling
10405 Enum.ToString () for Operator in Binary. Significant recover of
10408 2002-04-10 Miguel de Icaza <miguel@ximian.com>
10410 * class.cs (FindMembers): Allow the Builders of the various
10411 members to be null. If they are skip them. This only happens
10412 during the PInvoke declaration.
10414 2002-04-09 Miguel de Icaza <miguel@ximian.com>
10416 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
10417 failure, so we do not keep going afterwards.
10419 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
10420 wanted to pass `false' as the `is_delegate' argument. If this is
10421 the case, why not use delegate_type == null to mean `is_delegate =
10422 false' and anything else as is_delegate = true.
10424 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
10426 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
10427 code for the section, not the beginning of the tests.
10429 2002-04-08 Miguel de Icaza <miguel@ximian.com>
10431 * cfold.cs: Handle operator + (Enum x, Underlying x)
10433 * expression.cs (Binary): same. Warn about errors where we have
10434 Enum/Enum in operator + as well.
10436 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
10439 - added support for switch(bool)
10440 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
10441 - add TableSwitchEmit() to handle table-based switch statements
10443 2002-04-05 Ravi Pratap <ravi@ximian.com>
10445 * expression.cs (Invocation.OverloadResolve): Factor out code which
10446 does parameter compatibility checking with arguments so that we can
10447 re-use the code even from Delegate.VerifyApplicability
10449 (VerifyArgumentsCompat): Move above code here.
10451 * delegate.cs (VerifyApplicability): Get rid of duplicate code
10452 and instead make a call to the above method.
10454 2002-03-31 Ravi Pratap <ravi@ximian.com>
10456 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
10457 We use it to keep track of classes which are attribute types.
10459 2002-04-02 Miguel de Icaza <miguel@ximian.com>
10461 * delegate.cs (Delegate.Define): Correctly define the types in the
10462 presence of fixed and array parameters.
10464 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
10467 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
10468 include NonPublic after the first iteration.
10470 * class.cs (Indexer.CheckBase): Only check if both parents are
10473 * cs-parser.jay (accessor_body): If empty, set to null.
10475 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
10476 same code path here to resolve constants names that we did have in
10477 MemberAccess.DoResolve. There is too much code duplicated here.
10479 2002-04-01 Miguel de Icaza <miguel@ximian.com>
10481 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
10483 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
10486 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
10487 tokens, numbers and strings.
10489 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
10492 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
10493 asyncronous parameters and the regular parameters.
10495 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
10496 specify the target directory.
10498 * expression.cs: (This.DoResolve): Simplify
10499 (As.Emit): Optimize, do not generate IsInst if the expression is
10500 always of the given type.
10502 (Is.DoResolve): Bug fix, we were reporting both always/never for
10505 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
10506 creating too many unnecessary arrays.
10508 2002-03-31 Miguel de Icaza <miguel@ximian.com>
10510 * class.cs (EmitFieldInitializer): Use Assign expression to assign
10511 fields instead of rolling our own initializer. Takes care of all
10512 implicit conversions, and drops unnecessary static checks/argument.
10514 2002-03-31 Dick Porter <dick@ximian.com>
10516 * driver.cs: use the GetDirectories() return values properly, and
10517 use "/" as path separator.
10519 2002-03-30 Miguel de Icaza <miguel@ximian.com>
10521 * expression.cs (Unary): Optimize - - expr into expr.
10522 (Binary): Optimize a + (-b) into a -b.
10524 * codegen.cs (CodeGen): Made all methods static.
10526 2002-03-29 Miguel de Icaza <miguel@ximian.com>
10530 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
10531 TypeBuilder property.
10533 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
10536 * tree.cs: Removed the various RecordXXXX, and replaced with a
10537 single RecordDecl. Removed all the accessor methods, and just
10538 left a single access point Type
10540 * enum.cs: Rename DefineEnum to DefineType.
10542 * decl.cs: New abstract method `DefineType' used to unify the
10543 Defines for Enumerations, Interfaces, TypeContainers and
10546 (FindType): Moved LookupInterfaceOrClass here. Moved the
10547 LookupBaseClasses method that used to live in class.cs and
10548 interface.cs here, and renamed to FindType.
10550 * delegate.cs: Implement DefineType. Take advantage of the
10551 refactored pattern for locating the parent builder without taking
10552 the parent_builder argument (which we know does not work if we are
10553 nested, and triggering a toplevel definition).
10555 2002-03-28 Miguel de Icaza <miguel@ximian.com>
10557 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
10558 accessibility of a member has changed during override and report
10561 * class.cs (Method.Define, Property.Define): Only complain on
10562 overrides if the method is private, any other accessibility is
10563 fine (and since we just checked the permission is the same, we are
10566 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
10567 and elif are processed always. The other pre-processing
10568 directives are only processed if we are "taking" the path
10570 2002-03-29 Martin Baulig <martin@gnome.org>
10572 * class.cs (Method.Emit): Only emit symbolic debugging info if the
10573 current location is not Null.
10575 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
10576 a separate method so we can profile it.
10578 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
10579 `span.Seconds' are just seconds, but no minutes or hours.
10580 (MainDriver): Profile the CodeGen.SaveSymbols calls.
10582 2002-03-28 Miguel de Icaza <miguel@ximian.com>
10584 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
10585 Remove the gratuitous set of Final:
10587 // If an interface implementation, then we can set Final.
10588 if (((flags & MethodAttributes.Abstract) == 0) &&
10589 implementing.DeclaringType.IsInterface)
10590 flags |= MethodAttributes.Final;
10592 I do not know what I was smoking when I used that.
10595 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
10596 step into fixing the name resolution issues for delegates and
10597 unifying the toplevel name resolution.
10599 2002-03-28 Martin Baulig <martin@gnome.org>
10601 * class.cs (Method.Emit): If we have a symbol writer, call its
10602 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
10603 tell it about the current method.
10605 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
10606 writer that we're going to emit the first byte of IL code for a new
10607 statement (a new source line).
10608 (EmitContext.EmitTopBlock): If we have a symbol writer, call
10609 EmitContext.Mark() before emitting any code.
10611 * location.cs (SymbolDocument): Return null when we're Null.
10613 * statement.cs (Statement): Moved the `Location loc' variable here.
10614 (Statement.EmitBoolExpression): If we have a symbol writer, call
10615 ec.Mark() before emitting any code to tell it that we're at the
10616 beginning of a new statement.
10617 (StatementExpression): Added `Location' argument to the constructor.
10618 (Block): Added public readonly variable `StartLocation' and public
10619 variable `EndLocation'. The latter is to be set using SetEndLocation().
10620 (Block): Added constructor which takes a start and end location.
10621 (Block.SetEndLocation): New method. This sets the end location.
10622 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
10623 local variables we create.
10624 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
10625 each statement and do also mark the begin and end of the block.
10627 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
10628 tell it the current lexer.Location, use Location.Null for the end of the
10630 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
10631 current block, set its end location using SetEndLocation().
10632 (statement_expression): StatementExpression constructor now takes the
10633 lexer.Location as additional argument.
10634 (for_statement, declare_local_variables): Likewise.
10635 (declare_local_variables): When creating a new implicit block, use the
10636 new Block constructor and pass it the lexer.Location.
10638 2002-03-28 Miguel de Icaza <miguel@ximian.com>
10640 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
10641 members also on the parent interfaces recursively.
10643 2002-03-27 Miguel de Icaza <miguel@ximian.com>
10645 * report.cs: Use new formats, since Gonzalo finished the missing
10648 * expression.cs (Binary.ResolveOperator): added missing operator|
10649 operator& and operator^ for bool/bool.
10651 * cs-parser.jay: CheckDef now takes a Location argument that is
10652 used to report errors more precisly (instead of reporting the end
10653 of a definition, we try to track something which is a lot closer
10654 to the source of the problem).
10656 * cs-tokenizer.cs: Track global token use, so we can properly flag
10657 the use of #define/#undef after the first token has been seen.
10659 Also, rename the reportXXXX to Error_DescriptiveName
10661 * decl.cs (DeclSpace.IsTopLevel): Move property here from
10662 TypeContainer, so that Enum and Interface can use this too.
10664 * class.cs (TypeContainer.LookupInterfaceOrClass,
10665 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
10666 `builder' argument. Typically this was used to pass the parent
10667 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
10670 The problem is that a nested class could trigger the definition of
10671 a toplevel class, and the builder would be obviously wrong in that
10674 So we drop this argument, and we compute dynamically the
10675 TypeBuilder/ModuleBuilder (the correct information was available
10676 to us anyways from DeclSpace.Parent)
10678 * interface.cs (Interface.DefineInterface): Drop builder
10679 parameter cleanup like class.cs
10681 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
10684 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
10687 (Try.Emit): Propagate the returns value from the statement.
10689 (Return.Emit): Even if we are leavning
10691 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
10693 * modifiers.cs: Fix the computation of MethodAttributes flags.
10695 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
10697 * driver.cs: allow compilation of files that start with '/'.
10698 Add a default case when checking the argument of --target.
10700 2002-03-25 Miguel de Icaza <miguel@ximian.com>
10702 * interface.cs: Implement the same search algorithm for types in
10703 the interface code.
10705 * delegate.cs: Do not allow multiple definition.
10707 * Recovered ChangeLog that got accidentally amputated
10709 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
10711 * rootcontext.cs: Load manually enum to allow core classes to
10712 contain enumerations.
10714 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
10715 Update to new static methods in TypeManager.
10717 * typemanager.cs (GetMethod, GetConstructor): Use our
10718 implementation of FindMembers to find the members, since during
10719 corlib compilation, the types are TypeBuilders and GetMethod and
10720 GetConstructor do not work.
10722 Make all methods in TypeManager static.
10724 (InitCodeHelpers): Split the functionality from
10725 the InitCodeTypes function.
10727 * driver.cs: Call InitCodeHelpers after we have populated the
10730 * cs-parser.jay (delegate_declaration): we did not used to compute
10731 the delegate name correctly for void delegates.
10733 2002-03-24 Miguel de Icaza <miguel@ximian.com>
10735 * rootcontext.cs (RootContext): Init the interface_resolve_order
10736 and type_container_resolve_order always.
10738 (ResolveCore, BootstrapCorlib_ResolveClass,
10739 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
10740 compiler when compiling with --nostdlib
10742 * class.cs (TypeContainer.DefineType): Check that our parent is
10743 not null. This test is most important when we are bootstraping
10746 * codegen.cs: Split out the symbol writing code.
10748 2002-03-25 Martin Baulig <martin@gnome.org>
10750 * driver.cs (-g): Made -g an alias for --debug.
10752 2002-03-24 Martin Baulig <martin@gnome.org>
10754 * codegen.cs (SymbolWriter): New public variable. Returns the
10755 current symbol writer.
10756 (CodeGen): Added `bool want_debugging_support' argument to the
10757 constructor. If true, tell the ModuleBuild that we want debugging
10758 support and ask it for the ISymbolWriter.
10759 (Save): If we have a symbol writer, call it's Close() method after
10760 saving the assembly.
10762 * driver.c (--debug): New command line argument to create a
10763 debugger information file.
10765 * location.cs (SymbolDocument): New public property. Returns an
10766 ISymbolDocumentWriter object for the current source file or null
10767 if we don't have a symbol writer.
10769 2002-03-21 Miguel de Icaza <miguel@ximian.com>
10771 * driver.cs (LoadAssembly): Correctly return when all the paths
10772 have been tried and not before.
10774 * statement.cs (Switch.Emit): return the actual coverage for this
10775 statement (returns/not-returns)
10777 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
10778 switch of the statement if we are the last switch section. That
10779 kills two problems: try/catch problems (we used to emit an empty
10780 nop at the end) and switch statements where all branches would
10783 2002-03-19 Miguel de Icaza <miguel@ximian.com>
10785 * driver.cs: Add default assemblies (the equivalent to the
10786 Microsoft CSC.RSP file)
10788 * cs-tokenizer.cs: When updating `cols and setting it to zero,
10789 also update tokens_seen and set it to false.
10791 * driver.cs: Implement --recurse for Mike.
10793 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
10794 correctly splitting out the paths.
10796 2002-03-18 Miguel de Icaza <miguel@ximian.com>
10798 * interface.cs (Interface.PopulateProperty): Instead of using
10799 `parent' as the declaration space for the set parameters, use
10802 * support.cs (InternalParameters): InternalParameters constructor
10803 takes a DeclSpace instead of a TypeContainer.
10805 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
10806 types are being initialized, load the address of it before calling
10809 (New): Provide a mechanism to disable the generation of local
10810 value type temporaries when the caller will be providing us with
10811 an address to store it.
10813 (ArrayCreation.EmitDynamicInitializers): Use it.
10815 2002-03-17 Miguel de Icaza <miguel@ximian.com>
10817 * expression.cs (Invocation.EmitArguments): Only probe for array
10818 property if there is more than one argument. Sorry about that.
10820 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
10821 empty param arrays.
10823 * class.cs (Method.LabelParameters): Fix incorrect code path that
10824 prevented the `ParamArrayAttribute' from being applied to the
10827 2002-03-16 Miguel de Icaza <miguel@ximian.com>
10829 * support.cs (ReflectionParameters): Correctly compute whether the
10830 last argument is a params array. Fixes the problem with
10833 * typemanager.cs: Make the assemblies array always be non-null
10834 (empty, but non-null)
10836 * tree.cs (RecordDecl): New function that abstracts the recording
10837 of names. This reports error 101, and provides a pointer to the
10838 previous declaration. Fixes a crash in the compiler.
10840 * cs-parser.jay (constructor_declaration): Update to new grammar,
10841 and provide a constructor_body that can be empty.
10843 2002-03-15 Miguel de Icaza <miguel@ximian.com>
10845 * driver.cs: Add support for --resources.
10847 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
10848 Make all types for the various array helper methods be integer.
10850 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
10851 CheckState to ConvCast.
10853 (ConvCast): Now it takes a `checked' state argument, to avoid
10854 depending on the emit context for the conversion, and just using
10855 the resolve time setting.
10857 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
10858 instead of Invocation.EmitArguments. We do not emit the original
10859 arguments, instead we emit those which have been converted to
10860 unsigned int expressions.
10862 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
10864 * codegen.cs: ditto.
10866 * expression.cs (LocalVariableReference): Drop the use of the
10867 Store function that depended on the variable index.
10869 * statement.cs (VariableInfo): Drop the `Idx' property from this
10870 class, as this is not taking into account the indexes for
10871 temporaries tat we generate during the execution, getting the
10874 * class.cs: First emit class initializers, then call the parent
10877 * expression.cs (Binary): Fix opcode emision.
10878 (UnaryMutator.EmitCode): Support checked code generation
10880 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
10881 matches for events for both the Static and Instance scans,
10882 pointing to the same element. Fix that.
10884 2002-03-14 Miguel de Icaza <miguel@ximian.com>
10886 * rootcontext.cs (ResolveTree): Always set the
10887 interface_resolve_order, because nested interfaces will be calling
10890 * class.cs (GetInterfaceOrClass): Track the same resolution
10891 process used by TypeManager.LookupType. This fixes the nested
10892 type lookups in class declarations (separate path from
10895 (TypeContainer.DefineType): Also define nested interfaces.
10896 (TypeContainer.RegisterOrder): New public function used to
10897 register the order in which child interfaces need to be closed.
10899 Nested interfaces need to be closed after their parents have been
10902 * interface.cs (InterfaceAttr): Put all the logic for computing
10903 the interface attribute here.
10905 (DefineInterface): Register our interface order with the
10906 RootContext or with the TypeContainer depending on the case.
10908 2002-03-12 Miguel de Icaza <miguel@ximian.com>
10910 * cs-parser.jay: rework foreach statement to work with the new
10911 changes to the policy on SimpleNames.
10913 * report.cs: support Stacktrace on warnings as well.
10915 * makefile: drop --unsafe and /unsafe from the compile.
10917 2002-03-13 Ravi Pratap <ravi@ximian.com>
10919 * ecore.cs (StandardConversionExists): Modify to take an Expression
10920 as the first parameter. Ensure we do null -> reference type conversion
10923 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
10924 temporary Expression objects.
10926 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
10928 * interface.cs: workaround bug in method overloading resolution
10929 (there is already a bugzilla bug for it).
10931 2002-03-12 Miguel de Icaza <miguel@ximian.com>
10933 We could also solve this problem by having a separate path for
10934 performing type lookups, instead of DoResolve, we could have a
10935 ResolveType entry point, and only participating pieces of the
10936 production (simplename, deref, array) would implement this.
10938 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
10939 signal SimpleName to only resolve type names and not attempt to
10940 resolve anything else.
10942 * expression.cs (Cast): Set the flag.
10944 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
10946 * class.cs: Only report 108 if there is no `new' modifier.
10948 * cs-parser.jay: rework foreach statement to work with the new
10949 changes to the policy on SimpleNames.
10951 * report.cs: support Stacktrace on warnings as well.
10953 * makefile: drop --unsafe and /unsafe from the compile.
10955 2002-03-11 Miguel de Icaza <miguel@ximian.com>
10957 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
10958 lookups here, instead of doing that at parse time. This means
10959 that our grammar will not introduce `LocalVariableReferences' as
10960 expressions at this point. That solves the problem of code like
10964 static void Main ()
10968 This is only half the fix. The full fix requires parameters to
10969 also be handled in this way.
10971 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
10972 makes the use more obvious of the DeclSpace. The
10973 ec.TypeContainer.TypeBuilder is now only used to pull the
10974 TypeBuilder for it.
10976 My theory is that I can get rid of the TypeBuilder completely from
10977 the EmitContext, and have typecasts where it is used (from
10978 DeclSpace to where it matters).
10980 The only pending problem is that the code that implements Aliases
10981 is on TypeContainer, and probably should go in DeclSpace.
10983 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
10984 lookups here, instead of doing that at parse time. This means
10985 that our grammar will not introduce `LocalVariableReferences' as
10986 expressions at this point. That solves the problem of code like
10990 static void Main ()
10994 This is only half the fix. The full fix requires parameters to
10995 also be handled in this way.
10997 * class.cs (Property.DefineMethod): When implementing an interface
10998 method, set newslot, when implementing an abstract method, do not
10999 set the flag (before we tried never setting it, or always setting
11000 it, which is the difference).
11001 (Indexer.DefineMethod): same.
11002 (Method.DefineMethod): same.
11004 * ecore.cs: Only set the status used flag if we get back a Field.
11006 * attribute.cs: Temporary hack, so Paolo can keep working.
11008 2002-03-08 Ravi Pratap <ravi@ximian.com>
11010 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
11011 the unmanaged type in the case we have a MarshalAs attribute.
11013 (Resolve): Handle the case when we are parsing the special MarshalAs
11014 attribute [we need to store the unmanaged type to use later]
11016 * typemanager.cs (marshal_as_attr_type): Built in type for the
11017 MarshalAs Attribute.
11019 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
11020 on parameters and accordingly set the marshalling info.
11022 2002-03-09 Miguel de Icaza <miguel@ximian.com>
11024 * class.cs: Optimizing slightly by removing redundant code after
11025 we switched to the `NoTypes' return value.
11026 (Property.DefineMethod): use NoTypes here too.
11028 This fixes the bug I introduced in my last batch of changes.
11030 2002-03-05 Ravi Pratap <ravi@ximian.com>
11032 * tree.cs (RecordEnum): Add. We now keep track of enums too.
11034 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
11035 Enums since those are types too.
11037 * cs-parser.jay (enum_declaration): Record enums as we parse them.
11039 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
11040 thanks to a call during the lookup process.
11042 2002-03-07 Miguel de Icaza <miguel@ximian.com>
11044 * statement.cs (Foreach): Lots of work to accomodate a particular
11045 kind of foreach statement that I had not kept in mind. It is
11046 possible to have foreachs on classes that provide a GetEnumerator
11047 method that return objects that implement the "pattern" for using
11048 a foreach, there is no need to support GetEnumerator
11051 This is needed to compile nant.
11053 * decl.cs: Only report 114 if the member is not `Finalize' and if
11054 the warning level is at least 2.
11056 * class.cs: Moved the compare function from Method to
11059 (MethodSignature.InheritableMemberSignatureCompare): Add new
11060 filter function that is used to extract inheritable methods from a
11063 (Method.Define): Use the new `inheritable_method_signature_filter'
11066 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
11069 2002-03-06 Miguel de Icaza <miguel@ximian.com>
11071 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
11073 * cs-parser.jay: Add opt_semicolon to the interface declaration.
11075 * expression.cs: Pass location information to
11076 ConvertImplicitStandard.
11078 * class.cs: Added debugging code to track return values from
11081 2002-03-05 Miguel de Icaza <miguel@ximian.com>
11083 * expression.cs (Is.DoResolve): If either side of the `is' is an
11084 interface, do not flag the warning.
11086 * ecore.cs (ImplicitReferenceConversion): We need a separate test
11089 * report.cs: Allow for --fatal to be used with --probe.
11091 * typemanager.cs (NoTypes): Move the definition for the empty Type
11094 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
11096 (TypeContainer.DefineProxy): New function used to proxy to parent
11097 implementations when implementing interfaces.
11098 (TypeContainer.ParentImplements): used to lookup if our parent
11099 implements a public function that is required by an interface.
11100 (TypeContainer.VerifyPendingMethods): Hook this up.
11102 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
11103 `modules' and `assemblies' arraylists into arrays. We only grow
11104 these are the very early start up of the program, so this improves
11105 the speedof LookupType (nicely measured).
11107 * expression.cs (MakeByteBlob): Replaced unsafe code with
11108 BitConverter, as suggested by Paolo.
11110 * cfold.cs (ConstantFold.Binary): Special case: perform constant
11111 folding of string concatenation, but if either side is a string,
11112 and the other is not, then return null, and let the runtime use
11113 the concatenation on the string plus the object (using
11114 `Object.ToString').
11116 2002-03-04 Miguel de Icaza <miguel@ximian.com>
11118 Constant Folding has been implemented now.
11120 * expression.cs (Unary.Reduce): Do not throw an exception, catch
11121 the error instead on types that are not supported in one's
11124 * constant.cs (Constant and all children): New set of functions to
11125 perform implict and explicit conversions.
11127 * ecore.cs (EnumConstant): Implement the new functions to perform
11128 conversion by proxying to the child expression.
11130 * codegen.cs: (ConstantCheckState): Constant evaluation has its
11131 own separate setting that can not be turned off from the command
11132 line using --unchecked or --checked and is only controlled using
11133 the checked/unchecked statements and expressions. This setting is
11134 used by the constant folder to flag errors.
11136 * expression.cs (CheckedExpr, UncheckedExpr): Set the
11137 ConstantCheckState as well.
11139 During Resolve, they also have to flag the state, because the
11140 constant folder runs completely in the Resolve phase.
11142 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
11145 2002-03-01 Miguel de Icaza <miguel@ximian.com>
11147 * cfold.cs: New file, this file contains the constant folder.
11149 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
11150 argument to track whether we are using the resulting address to
11151 load or store a value and provide better error messages.
11153 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
11154 new AddressOf arguments.
11156 * statement.cs (Foreach.EmitCollectionForeach): Update
11158 * expression.cs (Argument.Emit): Call AddressOf with proper
11159 arguments to track usage.
11161 (New.DoEmit): Call AddressOf with new arguments.
11163 (Unary.Emit): Adjust AddressOf call.
11165 2002-03-01 Ravi Pratap <ravi@ximian.com>
11167 * cs-parser.jay (member_access): Change the case for pre-defined types
11168 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
11171 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
11174 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
11175 essentially like methods and apply attributes like MethodImplOptions to them too.
11177 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
11180 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
11181 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
11184 * Update code everywhere accordingly.
11186 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
11188 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
11190 2002-02-28 Ravi Pratap <ravi@ximian.com>
11192 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
11193 try performing lookups against those instead of jumping straight into using
11194 the 'using' clauses.
11196 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
11198 (LookupType): Perform lookups in implicit parents too.
11200 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
11201 sequence as RootContext.LookupType.
11203 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
11204 the various cases of namespace lookups into this method.
11206 2002-03-01 Miguel de Icaza <miguel@ximian.com>
11208 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
11209 in positional arguments)
11211 * class.cs (Operator): Update the AllowedModifiers to contain
11214 * cs-parser.jay: Update operator declaration to allow for the
11215 operator body to be empty.
11217 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
11220 2002-02-27 Miguel de Icaza <miguel@ximian.com>
11222 * class.cs (Method.Emit): Label parameters.
11224 * driver.cs: Return 1 or 0 as the program exit code.
11226 2002-02-26 Miguel de Icaza <miguel@ximian.com>
11228 * expression.cs: Special case the `null' object when trying to
11229 auto-compute the type, as anything can be explicitly converted to
11232 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
11233 spotting this Paolo.
11235 (Expression.ImplicitNumericConversion): Perform comparissions of
11236 the type using the underlying type in the case of an enumeration
11237 rather than using the enumeration type for the compare.
11239 Cope with the underlying == type case, which is not possible to
11242 (Expression.ConvertNumericExplicit): Perform comparissions of
11243 the type using the underlying type in the case of an enumeration
11244 rather than using the enumeration type for the compare.
11246 * driver.cs: If the user does not supply an extension, assume .exe
11248 * cs-parser.jay (if_statement): Rewrote so that we can track the
11249 location for the if statement.
11251 * expression.cs (Binary.ConstantFold): Only concat strings when
11252 the operation is "+", not everything ;-)
11254 * statement.cs (Statement.EmitBoolExpression): Take a location
11256 (If, While, Do): Track location.
11258 * expression.cs (Binary.ResolveOperator): In the object + string
11259 case, I was missing a call to ConvertImplicit
11261 2002-02-25 Ravi Pratap <ravi@ximian.com>
11263 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
11264 Location arguments. Ensure we use RootContext.LookupType to do our work
11265 and not try to do a direct Type.GetType and ModuleBuilder.GetType
11267 * interface.cs (PopulateMethod): Handle the type of the parameter being
11270 * expression.cs (Invocation.BetterFunction): Handle the case when we
11271 have a params method with no fixed arguments and a call is made with no
11274 2002-02-25 Miguel de Icaza <miguel@ximian.com>
11276 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
11277 the verbatim-string-literal
11279 * support.cs (InternalParameters.ParameterModifier): handle null
11281 (InternalParameters.ParameterType): ditto.
11283 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
11284 duplicating the name of the variable parameter.
11285 (GetParameterByName): Fix bug where we were not looking up array
11286 paramters if they were the only present (thanks Paolo!).
11287 (GetParameterInfo): We only have an empty set of types if both
11288 fixed and array are set to null.
11289 (GetParameterInfo-idx): Handle FixedParameter == null
11291 * cs-parser.jay: Handle the case where there is no catch
11292 statements (missing null test).
11294 2002-02-22 Miguel de Icaza <miguel@ximian.com>
11296 * driver.cs (MainDriver): Be conservative on our command line
11299 Catch DirectoryNotFoundException when calling GetFiles.
11301 (SplitPathAndPattern): Used to split the input specification into
11302 a path and a pattern that we can feed to Directory.GetFiles.
11304 2002-02-21 Miguel de Icaza <miguel@ximian.com>
11306 * statement.cs (Fixed): Implement the last case of the Fixed
11307 statement (string handling).
11309 * expression.cs (StringPtr): New class used to return a char * to
11310 a string; Used by the Fixed statement.
11312 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
11314 * expression.cs (Binary.ResolveOperator): Remove redundant
11315 MemberLookup pn parent type.
11316 Optimize union call, we do not need a union if the types are the same.
11317 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
11320 Specialize the use of MemberLookup everywhere, instead of using
11321 the default settings.
11323 (StackAlloc): Implement stackalloc keyword.
11325 * cs-parser.jay: Add rule to parse stackalloc.
11327 * driver.cs: Handle /h, /help, /?
11329 * expression.cs (MakeByteBlob): Removed the hacks we had in place
11330 before we supported unsafe code.
11332 * makefile: add --unsafe to the self compilation of mcs.
11334 2002-02-20 Miguel de Icaza <miguel@ximian.com>
11336 * expression.cs (PointerArithmetic): New class that is used to
11337 perform pointer arithmetic.
11338 (Binary.Resolve): Handle pointer arithmetic
11339 Handle pointer comparission.
11340 (ArrayPtr): Utility expression class that is used to take the
11341 address of an array.
11343 (ElementAccess): Implement array access for pointers
11345 * statement.cs (Fixed): Implement fixed statement for arrays, we
11346 are missing one more case before we are done.
11348 * expression.cs (Indirection): Implement EmitAssign and set the
11349 ExprClass to Variable. This allows pointer dereferences to be
11350 treated as variables, and to have values assigned to them.
11352 * ecore.cs (Expression.StoreFromPtr): New utility function to
11353 store values dereferencing.
11355 2002-02-20 Ravi Pratap <ravi@ximian.com>
11357 * expression.cs (Binary.ResolveOperator): Ensure that we are
11358 not trying to operate on a void type - this fixes the reported
11361 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
11362 the parent implementation is sealed.
11364 * ../errors/cs0239.cs : Add.
11366 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
11368 * typemanager.cs (unverifiable_code_type): Corresponds to
11369 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
11370 which have unsafe code in them.
11372 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
11375 2002-02-19 Miguel de Icaza <miguel@ximian.com>
11377 * cs-tokenizer.cs: Add support for @"litreal strings"
11379 Make tokenizer accept pre-processor directives
11380 on any column (remove the old C-like limitation).
11382 * rootcontext.cs (EmitCode): Emit any global attributes.
11383 (AddGlobalAttributes): Used to keep track of assembly attributes.
11385 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
11387 * cs-parser.jay: Add support for global attributes.
11389 2002-02-17 Miguel de Icaza <miguel@ximian.com>
11391 * expression.cs (Indirection): New helper class. Unary will
11392 create Indirection classes to be able to implement the
11393 IMemoryLocation interface on it.
11395 2002-02-16 Miguel de Icaza <miguel@ximian.com>
11397 * cs-parser.jay (fixed_statement): reference the right statement.
11399 * statement.cs (Fixed.Emit): Finish implementing the fixed
11400 statement for the &x case.
11402 2002-02-14 Miguel de Icaza <miguel@ximian.com>
11404 * class.cs (Property.Define, Method.Define): Remove newslot when
11407 * modifiers.cs: My use of NewSlot when `Abstract' was set was
11408 wrong. NewSlot should only be used if the `new' keyword is present.
11410 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
11411 locating our system dir. Sorry about this.
11413 2002-02-13 Miguel de Icaza <miguel@ximian.com>
11415 * driver.cs (GetSystemDir): Compute correctly the location of our
11416 system assemblies. I was using the compiler directory instead of
11417 the library directory.
11419 2002-02-13 Ravi Pratap <ravi@ximian.com>
11421 * expression.cs (BetterFunction): Put back in what Miguel commented out
11422 since it is the correct fix. The problem is elsewhere ;-)
11424 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
11425 parameters of the parms method are themselves compatible or not !
11427 (StandardConversionExists): Fix very dangerous bug where we were forgetting
11428 to check that a class implements an interface before saying that an implicit
11429 conversion was allowed. Use ImplementsInterface to do the checking.
11431 2002-02-13 Miguel de Icaza <miguel@ximian.com>
11433 * class.cs (Method.Define): Track whether we are an explicit
11434 implementation or not. And only call DefineMethodOverride if we
11435 are an explicit implementation.
11437 (Property.DefineMethod): Ditto.
11439 2002-02-11 Ravi Pratap <ravi@ximian.com>
11441 * expression.cs (BetterFunction): Catch hideous bug which was
11442 preventing us from detecting ambiguous calls due to implicit casts i.e
11445 2002-01-29 Miguel de Icaza <miguel@ximian.com>
11447 * support.cs (Pair): Remove un-needed method. I figured why I was
11448 getting the error in cs-parser.jay, the variable in a foreach loop
11449 is readonly, and the compiler does not really treat this as a variable.
11451 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
11452 instead of EQUALS in grammar.
11454 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
11456 * expression.cs (Unary.DoResolve): Check whether the argument is
11459 2002-01-28 Miguel de Icaza <miguel@ximian.com>
11461 * support.cs: Api for Pair to set a value. Despite the fact that
11462 the variables are public the MS C# compiler refuses to compile
11463 code that accesses the field if the variable is part of a foreach
11466 * statement.cs (Fixed): Begin implementation of the fixed
11469 (Block.AddVariable): Return the VariableInfo on success and null
11470 on failure instead of true/false.
11472 * cs-parser.jay (foreach): Catch errors on variables already
11473 defined (we were ignoring this value before) and properly unwind
11474 the block hierarchy
11476 (fixed_statement): grammar for the fixed statement.
11478 2002-01-25 Miguel de Icaza <miguel@ximian.com>
11480 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
11481 pointer types to be incretemented.
11483 (SizeOf): Implement.
11485 * cs-parser.jay (pointer_member_access): Implement
11486 expr->IDENTIFIER production.
11488 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
11489 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
11492 (Unary): Implement indirection.
11494 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
11495 use in non-unsafe context).
11497 (SimpleName.DoResolve): Check for pointers in field access on safe
11500 (Expression.LoadFromPtr): Factor the load-indirect code in this
11501 function. This was duplicated in UnboxCast and ParameterReference
11503 2002-01-24 Miguel de Icaza <miguel@ximian.com>
11505 * expression.cs (ComposedCast): report an error if a pointer cast
11506 is used in a safe region.
11508 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
11509 pointer type casts in unsafe context.
11511 * codegen.cs (EmitContext): Set up IsUnsafe.
11513 * cs-parser.jay (non_expression_type): Add productions for pointer
11516 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
11517 code. We should not use force into static mode if the method is
11518 not virtual. Fixes bug in MIS
11520 * statement.cs (Do.Emit, While.Emit, For.Emit,
11521 Statement.EmitBoolExpression): Add support to Do and While to
11522 propagate infinite loop as `I do return' semantics.
11524 Improve the For case to also test for boolean constants.
11526 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
11527 to the list of attributes we can add.
11529 Remove `EmitContext' argument.
11531 * class.cs (Method.Define): Apply parameter attributes.
11532 (Constructor.Define): Apply parameter attributes.
11533 (MethodCore.LabelParameters): Move here the core of labeling
11536 * support.cs (ReflectionParameters.ParameterModifier,
11537 InternalParameters.ParameterModifier): Use IsByRef on the type and
11538 only return the OUT bit for these parameters instead of in/out/ref
11541 This is because I miss-understood things. The ParameterInfo.IsIn
11542 and IsOut represent whether the parameter has the [In] and [Out]
11545 2002-01-22 Miguel de Icaza <miguel@ximian.com>
11547 * ecore.cs (FieldExpr.Emit): Release temporaries.
11549 * assign.cs (LocalTemporary.Release): new function.
11551 * codegen.cs (EmitContext.GetTemporaryStorage,
11552 EmitContext.FreeTemporaryStorage): Rework the way we deal with
11553 temporary storage. Now we can "put back" localbuilders when we
11556 2002-01-21 Miguel de Icaza <miguel@ximian.com>
11558 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
11559 need to make a copy of the variable to generate verifiable code.
11561 2002-01-19 Miguel de Icaza <miguel@ximian.com>
11563 * driver.cs: Compute dynamically the system directory.
11565 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
11566 Slower, but more generally useful. Used by the abstract
11567 registering implementation.
11569 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
11570 the rules for the special rule on Type/instances. First check if
11571 we have the same name, and if so, try that special static path
11572 rather than the instance path.
11574 2002-01-18 Miguel de Icaza <miguel@ximian.com>
11576 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
11579 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
11580 Enum, ValueType, Delegate or Array for non-corlib compiles.
11582 * cs-tokenizer.cs: Catch long identifiers (645)
11584 * typemanager.cs (IndexerPropetyName): Ravi never tested this
11587 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
11588 fix, we were returning too early, so we were not registering
11589 pending methods from abstract classes.
11591 Do not register pending methods if the class is abstract.
11593 * expression.cs (Conditional.DoResolve): Report circular implicit
11594 conversions when we neecd to compute it for conditional
11597 (Is.DoResolve): If the expression is always of the provided type,
11598 flag warning 183. If the expression can not ever be of the
11599 provided type flag warning 184.
11601 * class.cs: Catch 169 as well.
11603 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
11606 2002-01-18 Nick Drochak <ndrochak@gol.com>
11608 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
11610 2002-01-17 Miguel de Icaza <miguel@ximian.com>
11612 * interface.cs: (PopulateMethod): Check for pointers being defined
11613 only if the unsafe context is active.
11614 (PopulateProperty): ditto.
11615 (PopulateIndexer): ditto.
11617 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
11618 specified. If pointers are present, make sure that they are
11619 present in an unsafe context.
11620 (Constructor, Constructor.Define): ditto.
11621 (Field, Field.Define): ditto.
11622 (Property, Property.Define): ditto.
11623 (Event, Event.Define): ditto.
11625 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
11626 hashtable if there are classes or structs defined.
11628 * expression.cs (LocalVariableReference.DoResolve): Simplify this
11629 code, as the constant resolution moved.
11631 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
11632 the metadata, so we can flag error 133.
11634 * decl.cs (MemberCore.UnsafeOK): New function to test that a
11635 pointer is being declared in an unsafe context.
11637 2002-01-16 Miguel de Icaza <miguel@ximian.com>
11639 * modifiers.cs (Modifiers.Check): Require a Location argument.
11640 Report error 227 for Unsafe use.
11642 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
11644 * statement.cs (For.Emit): If the test is null, then report that
11645 we do `return', as we wont reach anything afterwards.
11647 (Switch.SwitchGoverningType): Track the expression that matched
11650 * driver.cs: Allow negative numbers as an error code to flag.
11652 * cs-parser.jay: Handle 1551.
11654 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
11656 2002-01-15 Miguel de Icaza <miguel@ximian.com>
11658 * cs-parser.jay: Report 1518 (type declaration can only contain
11659 class, struct, interface, enum or delegate)
11661 (switch_label): Report 1523 (keywords `case' or `default' must
11664 (opt_switch_sections): Report 1522 (empty switch)
11666 * driver.cs: Report 1515 (response file specified multiple times)
11667 Report 1516 (Source file specified multiple times).
11669 * expression.cs (Argument.Resolve): Signal 1510
11671 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
11672 access not allowed in static code)
11674 2002-01-11 Ravi Pratap <ravi@ximian.com>
11676 * typemanager.cs (IsPointerType): Utility method which we are going
11679 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
11680 the object type, so we take care of that.
11682 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
11684 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
11685 added to non-params parameters :-)
11687 * typemanager.cs (CSharpName): Include 'void' type too.
11689 (void_ptr_type): Include in the set of core types.
11691 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
11694 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
11697 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
11698 completely forgotten about it.
11700 2002-01-10 Ravi Pratap <ravi@ximian.com>
11702 * cs-parser.jay (pointer_type): Add. This begins our implementation
11703 of parsing rules for unsafe code.
11705 (unsafe_statement): Implement.
11707 (embedded_statement): Modify to include the above.
11709 * statement.cs (Unsafe): Implement new class for unsafe blocks.
11711 * codegen.cs (EmitContext.InUnsafe): Add. This determines
11712 if the current context is an unsafe one.
11714 * cs-parser.jay (local_variable_pointer_type): Since local variable types
11715 are handled differently, we need separate rules for them.
11717 (local_variable_declaration): Update to use local_variable_pointer_type
11718 to allow variable declarations of unmanaged pointer types.
11720 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
11721 in unsafe contexts.
11723 * ../errors/cs0214.cs : Add.
11725 2002-01-16 Nick Drochak <ndrochak@gol.com>
11727 * makefile: remove 'response' file when cleaning.
11729 2002-01-15 Miguel de Icaza <miguel@ximian.com>
11731 * cs-parser.jay: Report 1524.
11733 2002-01-14 Miguel de Icaza <miguel@ximian.com>
11735 * typemanager.cs (RegisterMethod): drop checking if we have
11736 registered this from here
11738 2002-01-12 Miguel de Icaza <miguel@ximian.com>
11740 * class.cs (Method.EmitDestructor): Implement calling our base
11743 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
11744 value of InFinally.
11746 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
11747 this routine and will wrap the call in a try/catch block. Deal
11750 2002-01-11 Miguel de Icaza <miguel@ximian.com>
11752 * ecore.cs (Expression.MemberLookup): instead of taking a
11753 parameter `same_type' that was used to tell whether we could
11754 access private members we compute our containing type from the
11757 (FieldExpr): Added partial support for volatile fields. This does
11758 not work for volatile fields exposed from assemblies, as I can not
11759 figure out how to extract the modreq from it.
11761 Updated all the source files to use this.
11763 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
11764 because it is referenced by MemberLookup very often.
11766 2002-01-09 Ravi Pratap <ravi@ximian.com>
11768 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
11769 TypeBuilder.GetCustomAttributes to retrieve what we need.
11771 Get rid of redundant default_member_attr_type as this is the same as
11772 default_member_type which already exists.
11774 * interface.cs, attribute.cs : Update accordingly.
11776 2002-01-08 Miguel de Icaza <miguel@ximian.com>
11778 * typemanager.cs: Enable IndexerPropertyName again. It does not
11779 work for TYpeBuilders though. Ravi, can you please fix this?
11781 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
11783 * expression.cs (Argument.Emit): Handle the case of ref objects
11784 being passed to ref functions;
11786 (ParameterReference.EmitLoad): Loads the content of the pointer
11787 without dereferencing.
11789 2002-01-07 Miguel de Icaza <miguel@ximian.com>
11791 * cs-tokenizer.cs: Implemented the pre-processing expressions.
11793 2002-01-08 Ravi Pratap <ravi@ximian.com>
11795 * class.cs (Indexer.DefineMethod): Incorporate the interface
11796 type in the name of the method if we are doing explicit interface
11799 * expression.cs (ConversionExists): Remove as it is completely obsolete.
11801 (BetterConversion): Fix extremely trivial bug where we were referring to
11802 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
11805 * ../errors/bug16.cs : Add although we have fixed it.
11807 2002-01-07 Miguel de Icaza <miguel@ximian.com>
11809 * expression.cs (BaseIndexer): Begin implementation.
11811 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
11813 * cs-parser.jay (indexer_declarator): Use qualified_identifier
11814 production directly to remove a shift/reduce, and implement
11815 explicit interface implementation.
11817 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
11818 after a floating point suffix.
11820 * expression.cs (DoNumericPromotions): Improved the conversion for
11821 uint/uint. If we have a constant, we avoid doing a typecast to a
11824 * class.cs (Indexer): Implement explicit interface implementation
11827 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
11829 * class.cs: make the default instance constructor public and hidebysig.
11831 2001-01-03 Ravi Pratap <ravi@ximian.com>
11833 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
11834 so we can call it from elsewhere.
11836 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
11837 we emit it internally if the class has a defined indexer; otherwise the user
11838 emits it by decorating the class definition with the DefaultMemberAttribute.
11840 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
11841 attribute is not used on a type which defines an indexer.
11843 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
11844 character when we skip whitespace.
11846 * ../errors/cs0646.cs : Add.
11848 2002-01-03 Miguel de Icaza <miguel@ximian.com>
11850 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
11853 * makefile: Add practical target `mcs3.exe' which builds the third
11854 generation compiler.
11856 * expression.cs (New): Fix structures constructor calling.
11858 * class.cs (Property, Method, Indexer): Emit Final flag on the
11859 method if we are an interface implementation and we are not
11862 * ecore.cs (PropertyExpr): New public field `IsBase', tells
11863 whether this property is referencing a `base' method.
11865 * expression.cs (Invocation.EmitCall): take an extra argument:
11866 is_base, this is used to determine whether the `call' or
11867 `callvirt' opcode should be used.
11870 * delegate.cs: update EmitCall.
11872 * class.cs (Method.Define): Set NewSlot for the cases where we are
11873 not implementing an interface method.
11875 (Property.Define): ditto.
11877 2002-01-02 Miguel de Icaza <miguel@ximian.com>
11879 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
11880 'r'. Allows mcs to parse itself fully.
11882 2002-01-02 Ravi Pratap <ravi@ximian.com>
11884 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
11885 of the number of initializers that require the InitializeArray method.
11887 (CheckIndices): Store the Expression in all cases - not the plain value. Also
11888 update the above field where necessary.
11890 (MakeByteBlob): Update accordingly.
11892 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
11895 (EmitDynamicInitializers): Update in accordance with the new optimization.
11897 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
11898 same OpCode applies.
11900 * cs-parser.jay : Fix some glaring errors I introduced.
11902 2002-01-01 Ravi Pratap <ravi@ximian.com>
11904 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
11905 so that we can check for name clashes there too.
11907 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
11908 for interface indexers.
11910 * interfaces.cs (Define): Emit the default member attribute.
11912 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
11913 variable was being referred to while setting the value ;-)
11915 2002-01-01 Miguel de Icaza <miguel@ximian.com>
11917 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
11918 byte-by-byte information when we know the data is zero.
11920 Make the block always a multiple of 4, because
11921 DefineInitializedData has a bug.
11923 * assign.cs: Fix, we should assign from the temporary, not from
11926 * expression.cs (MakeByteBlob): Fix my incorrect code.
11928 2001-12-31 Miguel de Icaza <miguel@ximian.com>
11930 * typemanager.cs (EnumToUnderlying): This function is used to get
11931 the underlying type from an enumeration, because it does not
11934 * constant.cs: Use the I4_S form for values between -128 and 127.
11936 * statement.cs (Block.LookupLabel): Looks up a label.
11937 (Block): Drop support for labeled blocks.
11939 (LabeledStatement): New kind of statement that represents a label
11942 (Goto): Finally implement this bad boy.
11944 * cs-parser.jay: Update to reflect new mechanism to implement
11947 2001-12-30 Miguel de Icaza <miguel@ximian.com>
11949 * codegen.cs (EmitContext.This): a codegen property that keeps the
11950 a single instance of this instead of creating many different this
11953 * delegate.cs (Delegate.DoResolve): Update to use the property;
11955 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
11957 * expression.cs (BaseAccess.DoResolve): Ditto.
11959 2001-12-29 Ravi Pratap <ravi@ximian.com>
11961 * typemanager.cs (methodimpl_attr_type): Add to hold the type
11962 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
11964 (InitCoreTypes): Update accordingly.
11966 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
11967 so we can quickly store the state.
11969 (ApplyAttributes): Set the correct implementation flags
11970 for InternalCall methods.
11972 2001-12-29 Miguel de Icaza <miguel@ximian.com>
11974 * expression.cs (EmitCall): if a method is not virtual, then do
11975 not use callvirt on it.
11977 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
11978 user defined stuff) requires the use of stobj, which takes an
11979 address on the stack instead of an array and an index. So emit
11980 the Ldelema operation for it.
11982 (EmitStoreOpcode): Use stobj for valuetypes.
11984 (UnaryMutator.EmitCode): Use the right 1 value depending on
11985 whether we are dealing with int64/uint64, float or doubles.
11987 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
11988 constructors that I implemented last night.
11990 (Constructor.IsDefault): Fix to work properly for static
11993 * cs-parser.jay (CheckDef): report method signature errors.
11994 Update error number 103 to be 132.
11996 * decl.cs: New AdditionResult enumeration value: MethodExists.
11997 Although we do this check for methods later on in the semantic
11998 analysis, catching repeated default constructors is so easy that
11999 we catch these here.
12001 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
12004 (ParameterReference.EmitAssign, Emit): handle
12007 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
12008 (ArrayAccess.EmitStoreOpcode): ditto.
12010 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
12012 * expression.cs (MakeByteBlob): Complete all the missing types
12013 (uint, short, ushort, byte, sbyte)
12015 * class.cs: Only init instance field initializers on instance
12018 Rename `constructors' to instance_constructors.
12020 (TypeContainer.AddConstructor): Only add constructors to the list
12021 if it is not static.
12023 Make sure that we handle default_static_constructor independently
12024 everywhere where we handle instance_constructors
12026 2001-12-28 Miguel de Icaza <miguel@ximian.com>
12028 * class.cs: Do not lookup or create a base initializer for a
12029 static constructor.
12031 (ConstructorInitializer.Resolve): use the proper type to lookup
12034 * cs-parser.jay: Report error 1585 (modifiers between type and name).
12036 * enum.cs, interface.cs: Remove CloseType, this is taken care by
12039 * decl.cs: CloseType is now an virtual method, the default
12040 implementation just closes this type.
12042 2001-12-28 Ravi Pratap <ravi@ximian.com>
12044 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
12045 to PreserveSig by default. Also emit HideBySig on such methods.
12047 Basically, set the defaults to standard values.
12049 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
12050 argument, if candidate is better, it can't be worse than the best !
12052 (Invocation): Re-write bits to differentiate between methods being
12053 applicable in their expanded form and their normal form - for params
12056 Get rid of use_standard everywhere as only standard conversions are allowed
12057 in overload resolution.
12059 More spec conformance.
12061 2001-12-27 Miguel de Icaza <miguel@ximian.com>
12063 * driver.cs: Add --timestamp, to see where the compiler spends
12066 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
12067 `this' in static code.
12069 (SimpleName.DoResolve): Implement in terms of a helper function
12070 that allows static-references to be passed upstream to
12073 (Expression.ResolveWithSimpleName): Resolve specially simple
12074 names when called by MemberAccess to implement the special
12077 (Expression.ImplicitReferenceConversion): Handle conversions from
12078 Null to reference types before others, as Null's type is
12081 * expression.cs (Invocation.EmitCall): Handle the special case of
12082 calling methods declared on a reference type from a ValueType
12083 (Base classes System.Object and System.Enum)
12085 (MemberAccess.Resolve): Only perform lookups on Enumerations if
12086 the left hand side is a TypeExpr, not on every enumeration.
12088 (Binary.Resolve): If types are reference types, then do a cast to
12089 object on operators != and == of both arguments.
12091 * typemanager.cs (FindMembers): Extract instance and static
12092 members if requested.
12094 * interface.cs (PopulateProperty): Use void_type instead of null
12095 as the return type for the setter method.
12097 (PopulateIndexer): ditto.
12099 2001-12-27 Ravi Pratap <ravi@ximian.com>
12101 * support.cs (ReflectionParameters): Fix minor bug where we
12102 were examining the wrong parameter for the ParamArray attribute.
12104 Cope with requests for the type of the parameter at position
12105 greater than the params parameter's. We now return the element
12106 type of the params array as that makes more sense.
12108 * expression.cs (Invocation.IsParamsMethodApplicable): Update
12109 accordingly as we no longer have to extract the element type
12112 (Invocation.OverloadResolve): Update.
12114 2001-12-27 Miguel de Icaza <miguel@ximian.com>
12116 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
12117 against IEnumerator, test whether the return value is a descendant
12118 of the IEnumerator interface.
12120 * class.cs (Indexer.Define): Use an auxiliary method to implement
12121 the other bits of the method definition. Begin support for
12122 explicit interface implementation.
12124 (Property.DefineMethod): Use TypeManager.void_type instead of null
12125 for an empty return value.
12127 2001-12-26 Miguel de Icaza <miguel@ximian.com>
12129 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
12130 dealing with a FieldExpr which is composed of a FieldBuilder, in
12131 the code path we did extract the constant, but we should have
12132 obtained the underlying value to be able to cast it (otherwise we
12133 end up in an infinite loop, this is what Ravi was running into).
12135 (ArrayCreation.UpdateIndices): Arrays might be empty.
12137 (MemberAccess.ResolveMemberAccess): Add support for section
12138 14.5.4.1 that deals with the special case of E.I when E is a type
12139 and something else, that I can be a reference to a static member.
12141 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
12142 handle a particular array type to create byte blobs, it is just
12143 something we dont generate byteblobs for.
12145 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
12148 * location.cs (Push): remove the key from the hashtable that we
12149 are about to add. This happens for empty files.
12151 * driver.cs: Dispose files after we have parsed them.
12153 (tokenize): new function that only runs the tokenizer on its
12154 input, for speed testing.
12156 2001-12-26 Ravi Pratap <ravi@ximian.com>
12158 * class.cs (Event.Define): Define the private field only if there
12159 are no accessors defined.
12161 * expression.cs (ResolveMemberAccess): If there is no associated
12162 field with the event, that means we have an event defined with its
12163 own accessors and we should flag error cs0070 since transforming
12164 ourselves into a field is not valid in that case.
12166 * ecore.cs (SimpleName.DoResolve): Same as above.
12168 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
12169 and charset to sane values.
12171 2001-12-25 Ravi Pratap <ravi@ximian.com>
12173 * assign.cs (DoResolve): Perform check on events only if they
12174 are being accessed outside the declaring type.
12176 * cs-parser.jay (event_declarations): Update rules to correctly
12177 set the type of the implicit parameter etc.
12179 (add_accessor, remove_accessor): Set current local parameters.
12181 * expression.cs (Binary): For delegate addition and subtraction,
12182 cast the return value from the method into the appropriate delegate
12185 2001-12-24 Ravi Pratap <ravi@ximian.com>
12187 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
12188 of these as the workaround is unnecessary.
12190 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
12191 delegate data - none of that is needed at all.
12193 Re-write bits to extract the instance expression and the delegate method
12196 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
12199 * attribute.cs (ApplyAttributes): New method to take care of common tasks
12200 of attaching attributes instead of duplicating code everywhere.
12202 * everywhere : Update code to do attribute emission using the above method.
12204 2001-12-23 Miguel de Icaza <miguel@ximian.com>
12206 * expression.cs (IsParamsMethodApplicable): if there are not
12207 parameters, return immediately.
12209 * ecore.cs: The 0 literal can be implicity converted to an enum
12212 (SimpleName.DoResolve): First lookup the type, then lookup the
12215 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
12216 want to get its address. If the InstanceExpression is not
12217 addressable, store the result in a temporary variable, then get
12220 * codegen.cs: Only display 219 errors on warning level or above.
12222 * expression.cs (ArrayAccess): Make it implement the
12223 IMemoryLocation interface.
12225 (Binary.DoResolve): handle the operator == (object a, object b)
12226 and operator != (object a, object b) without incurring into a
12227 BoxedCast (because 5 != o should never be performed).
12229 Handle binary enumerator operators.
12231 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
12232 value type, otherwise use Ldelem_ref.
12234 Use precomputed names;
12236 (AddressOf): Implement address of
12238 * cs-parser.jay (labeled_statement): Fix recursive block
12239 addition by reworking the production.
12241 * expression.cs (New.DoEmit): New has a special case:
12243 If we are dealing with a ValueType, we have a few
12244 situations to deal with:
12246 * The target of New is a ValueType variable, that is
12247 easy, we just pass this as the variable reference
12249 * The target of New is being passed as an argument,
12250 to a boxing operation or a function that takes a
12253 In this case, we need to create a temporary variable
12254 that is the argument of New.
12257 2001-12-23 Ravi Pratap <ravi@ximian.com>
12259 * rootcontext.cs (LookupType): Check that current_type is not null before
12260 going about looking at nested types.
12262 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
12263 not implement the IAssignMethod interface any more.
12265 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
12266 where we tranform them into FieldExprs if they are being resolved from within
12267 the declaring type.
12269 * ecore.cs (SimpleName.DoResolve): Do the same here.
12271 * assign.cs (DoResolve, Emit): Clean up code considerably.
12273 * ../errors/bug10.cs : Add.
12275 * ../errors/cs0070.cs : Add.
12277 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
12279 * assign.cs : Get rid of EventIsLocal everywhere.
12281 2001-12-23 Miguel de Icaza <miguel@ximian.com>
12283 * ecore.cs (ConvertIntLiteral): finished the implementation.
12285 * statement.cs (SwitchLabel): Convert the value we are using as a
12286 key before looking up the table.
12288 2001-12-22 Miguel de Icaza <miguel@ximian.com>
12290 * codegen.cs (EmitTopBlock): Require a Location argument now.
12292 * cs-parser.jay (constructor_declarator): We need to setup
12293 current_local_parameters before we parse the
12294 opt_constructor_initializer, to allow the variables to be bound
12295 to the constructor arguments.
12297 * rootcontext.cs (LookupType): First lookup nested classes in our
12298 class and our parents before we go looking outside our class.
12300 * expression.cs (ConstantFold): Extract/debox the values at the
12303 * rootcontext.cs (EmitCode): Resolve the constants first before we
12304 resolve the types. This is not really needed, but it helps debugging.
12306 * statement.cs: report location.
12308 * cs-parser.jay: pass location to throw statement.
12310 * driver.cs: Small bug fix.
12312 * report.cs: Updated format to be 4-zero filled digits.
12314 2001-12-22 Ravi Pratap <ravi@ximian.com>
12316 * expression.cs (CheckIndices): Fix minor bug where the wrong
12317 variable was being referred to ;-)
12319 (DoEmit): Do not call EmitStaticInitializers when the
12320 underlying type is System.Object.
12322 2001-12-21 Ravi Pratap <ravi@ximian.com>
12324 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
12325 and do the usual workaround for SRE.
12327 * class.cs (MyEventBuilder.EventType): New member to get at the type
12328 of the event, quickly.
12330 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
12332 * assign.cs (Assign.DoResolve): Handle the case when the target
12333 is an EventExpr and perform the necessary checks.
12335 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
12338 (SimpleName.MemberStaticCheck): Include check for EventExpr.
12340 (EventExpr): Set the type in the constructor itself since we
12341 are meant to be born fully resolved.
12343 (EventExpr.Define): Revert code I wrote earlier.
12345 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
12346 instance expression is null. The instance expression is a This in that case
12347 or a null, depending on whether it is a static method or not.
12349 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
12350 refers to more than one method.
12352 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
12353 and accordingly flag errors.
12355 2001-12-21 Miguel de Icaza <miguel@ximian.com>
12357 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
12359 2001-12-22 Miguel de Icaza <miguel@ximian.com>
12361 * location.cs (ToString): Provide useful rutine.
12363 2001-12-21 Miguel de Icaza <miguel@ximian.com>
12365 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
12366 objects, return the actual integral boxed.
12368 * statement.cs (SwitchLabel): define an ILLabel for each
12371 (Switch.CheckSwitch): If the value is a Literal, extract
12372 the underlying literal.
12374 Also in the unused hashtable we had, add the SwitchLabel so we can
12375 quickly look this value up.
12377 * constant.cs: Implement a bunch of new constants. Rewrite
12378 Literal based on this. Made changes everywhere to adapt to this.
12380 * expression.cs (Expression.MakeByteBlob): Optimize routine by
12381 dereferencing array only once, and also copes with enumrations.
12383 bytes are two bytes wide, not one.
12385 (Cast): Perform constant conversions.
12387 * ecore.cs (TryImplicitIntConversion): Return literals instead of
12388 wrappers to the literals here.
12390 * expression.cs (DoNumericPromotions): long literals can converted
12391 to ulong implicity (this is taken care of elsewhere, but I was
12392 missing this spot).
12394 * ecore.cs (Expression.Literalize): Make the return type Literal,
12395 to improve type checking.
12397 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
12399 2001-12-20 Miguel de Icaza <miguel@ximian.com>
12401 * literal.cs: Revert code from ravi that checked the bounds. The
12402 bounds are sane by the definition of the type itself.
12404 * typemanager.cs: Fix implementation of ImplementsInterface. We
12405 need to actually look up in our parent hierarchy for interfaces
12408 * const.cs: Use the underlying type for enumerations
12410 * delegate.cs: Compute the basename for the delegate creation,
12411 that should fix the delegate test case, and restore the correct
12412 Type Lookup semantics in rootcontext
12414 * rootcontext.cs: Revert Ravi's last patch. The correct way of
12415 referencing a nested type with the Reflection API is using the "+"
12418 * cs-parser.jay: Do not require EOF token at the end.
12420 2001-12-20 Ravi Pratap <ravi@ximian.com>
12422 * rootcontext.cs (LookupType): Concatenate type names with
12423 a '.' instead of a '+' The test suite passes again.
12425 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
12426 field of the enumeration.
12428 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
12429 the case when the member is an EventExpr.
12431 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
12432 static has an associated instance expression.
12434 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
12436 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
12438 * class.cs (Event.Define): Register event and perform appropriate checks
12441 We define the Add and Remove methods even if the use provides none because
12442 in that case, we provide default implementations ourselves.
12444 Define a private field of the type of the event. This is done by the CSC compiler
12445 and we should be doing it too ;-)
12447 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
12448 More methods we use in code we generate.
12450 (multicast_delegate_type, delegate_type): Two separate types since the distinction
12453 (InitCoreTypes): Update accordingly for the above.
12455 * class.cs (Event.Emit): Generate code for default accessors that we provide
12457 (EmitDefaultMethod): Do the job in the above.
12459 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
12462 2001-12-20 Miguel de Icaza <miguel@ximian.com>
12464 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
12465 builders even if we were missing one.
12467 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
12468 pass the Basename as our class name instead of the Name. The
12469 basename will be correctly composed for us.
12471 * parameter.cs (Paramters): Now takes a Location argument.
12473 * decl.cs (DeclSpace.LookupType): Removed convenience function and
12474 make all the code call directly LookupType in RootContext and take
12475 this chance to pass the Location information everywhere.
12477 * Everywhere: pass Location information.
12479 2001-12-19 Miguel de Icaza <miguel@ximian.com>
12481 * class.cs (Constructor.Define): Updated way of detecting the
12482 length of the parameters.
12484 (TypeContainer.DefineType): Use basename as the type name for
12487 (TypeContainer.Define): Do not recursively define types here, as
12488 definition is taken care in order by the RootContext.
12490 * tree.cs: Keep track of namespaces in a per-file basis.
12492 * parameter.cs (Parameter.ComputeSignature): Update to use
12495 (Parameters.GetSignature): ditto.
12497 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
12498 instead of a TypeContainer.
12500 (Interface.SemanticAnalysis): Use `this' instead of our parent to
12501 resolve names. Because we need to be resolve in our context, not
12504 * driver.cs: Implement response files.
12506 * class.cs (TypeContainer.DefineType): If we are defined, do not
12507 redefine ourselves.
12509 (Event.Emit): Emit the code for add/remove handlers.
12510 (Event.Define): Save the MethodBuilders for add/remove.
12512 * typemanager.cs: Use pair here too.
12514 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
12515 DictionaryEntry requires the first argument to be non-null.
12517 (enum_declaration): Compute full name for registering the
12520 (delegate_declaration): Instead of using
12521 formal_parameter_list, use opt_formal_parameter_list as the list
12524 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
12525 (EventParsing): New property that controls whether `add' and
12526 `remove' are returned as tokens or identifiers (for events);
12528 2001-12-19 Ravi Pratap <ravi@ximian.com>
12530 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
12531 use MyEventBuilder only and let it wrap the real builder for us.
12533 (MyEventBuilder): Revamp constructor etc.
12535 Implement all operations that we perform on EventBuilder in precisely the same
12538 (FindMembers): Update to use the EventBuilder member.
12540 (Event.Emit): Update accordingly.
12542 2001-12-18 Ravi Pratap <ravi@ximian.com>
12544 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
12545 by calling the appropriate methods.
12547 (GetCustomAttributes): Make stubs as they cannot possibly do anything
12550 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
12552 2001-12-17 Ravi Pratap <ravi@ximian.com>
12554 * delegate.cs (Delegate.Populate): Check that the return type
12555 and various parameters types are indeed accessible.
12557 * class.cs (Constructor.Define): Same here.
12559 (Field.Define): Ditto.
12561 (Event.Define): Ditto.
12563 (Operator.Define): Check that the underlying Method defined itself
12564 correctly - so it's MethodBuilder should not be null.
12566 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
12567 expression happens to be null.
12569 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
12570 members but as of now we don't seem to be able to do anything really useful with it.
12572 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
12573 not the EventBuilder.
12575 2001-12-18 Miguel de Icaza <miguel@ximian.com>
12577 * cs-tokenizer.cs: Add support for defines.
12578 Add support for #if, #elif, #else, #endif
12580 (eval_var): evaluates a variable.
12581 (eval): stubbed for evaluating functions.
12583 * cs-parser.jay: Pass the defines information
12585 * driver.cs: Add --define command line option.
12587 * decl.cs: Move MemberCore here.
12589 Make it the base class for DeclSpace. This allows us to catch and
12590 report 108 and 109 for everything now.
12592 * class.cs (TypeContainer.Define): Extract all the members
12593 before populating and emit the warning 108 (new keyword required
12594 to override) instead of having each member implement this.
12596 (MemberCore.Define): New abstract method, we will be using this in
12597 the warning reporting engine in Populate.
12599 (Operator.Define): Adjust to new MemberCore protocol.
12601 * const.cs (Const): This does not derive from Expression, it is a
12602 temporary object we use to create fields, it is a MemberCore.
12604 * class.cs (Method.Define): Allow the entry point to be in a
12607 * driver.cs: Rewrite the argument handler to clean it up a bit.
12609 * rootcontext.cs: Made it just an auxiliary namespace feature by
12610 making everything static.
12612 * driver.cs: Adapt code to use RootContext type name instead of
12615 * delegate.cs: Remove RootContext argument.
12617 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
12620 * class.cs (Event.Define): The lookup can fail.
12622 * cs-tokenizer.cs: Begin implementation of pre-procesor.
12624 * expression.cs: Resolve the this instance before invoking the code.
12626 2001-12-17 Miguel de Icaza <miguel@ximian.com>
12628 * cs-parser.jay: Add a production in element_access that allows
12629 the thing to become a "type" reference. This way we can parse
12630 things like "(string [])" as a type.
12632 Note that this still does not handle the more complex rules of
12636 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
12638 * ecore.cs: (CopyNewMethods): new utility function used to
12639 assemble the list of methods from running FindMembers.
12641 (MemberLookup): Rework FindMembers so that
12643 2001-12-16 Miguel de Icaza <miguel@ximian.com>
12645 * class.cs (TypeContainer): Remove Delegates who fail to be
12648 * delegate.cs (Populate): Verify that we dont get null return
12649 values. TODO: Check for AsAccessible.
12651 * cs-parser.jay: Use basename to emit error 574 (destructor should
12652 have the same name as container class), not the full name.
12654 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
12655 possible representation.
12657 Also implements integer type suffixes U and L.
12659 2001-12-15 Miguel de Icaza <miguel@ximian.com>
12661 * expression.cs (ArrayCreation.DoResolve): We need to do the
12662 argument resolution *always*.
12664 * decl.cs: Make this hold the namespace. Hold the root context as
12666 (LookupType): Move here.
12668 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
12670 * location.cs (Row, Name): Fixed the code, it was always returning
12671 references to the first file.
12673 * interface.cs: Register properties defined through interfaces.
12675 * driver.cs: Add support for globbing on the command line
12677 * class.cs (Field): Make it derive from MemberCore as well.
12680 2001-12-15 Ravi Pratap <ravi@ximian.com>
12682 * class.cs (Event::Define): Check that the type of the event is a delegate
12683 type else flag error #66.
12685 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
12688 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
12689 values of EntryPoint, CharSet etc etc.
12691 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
12693 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
12694 be null and we should ignore this. I am not sure if this is really clean. Apparently,
12695 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
12696 which needs this to do its work.
12698 * ../errors/cs0066.cs : Add.
12700 2001-12-14 Miguel de Icaza <miguel@ximian.com>
12702 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
12705 * class.cs: (MethodSignature.MethodSignature): Removed hack that
12706 clears out the parameters field.
12707 (MemberSignatureCompare): Cleanup
12709 (MemberCore): New base class used to share code between MethodCore
12712 (RegisterRequiredImplementations) BindingFlags.Public requires
12713 either BindingFlags.Instace or Static. Use instance here.
12715 (Property): Refactored code to cope better with the full spec.
12717 * parameter.cs (GetParameterInfo): Return an empty array instead
12720 * class.cs (Property): Abstract or extern properties have no bodies.
12722 * parameter.cs (GetParameterInfo): return a zero-sized array.
12724 * class.cs (TypeContainer.MethodModifiersValid): Move all the
12725 method modifier validation to the typecontainer so we can reuse
12726 this on properties.
12728 (MethodCore.ParameterTypes): return an empty sized array of types.
12730 (Property.Define): Test property modifier validity.
12732 Add tests for sealed/override too.
12734 (Method.Emit): abstract or extern methods have no bodies.
12736 2001-12-14 Ravi Pratap <ravi@ximian.com>
12738 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
12741 (Method::Define, ::Emit): Modify accordingly.
12743 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
12745 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
12747 * makefile: Pass in /unsafe.
12749 2001-12-13 Miguel de Icaza <miguel@ximian.com>
12751 * class.cs (MakeKey): Kill routine.
12753 * class.cs (TypeContainer.Define): Correctly define explicit
12754 method implementations (they require the full interface name plus
12757 * typemanager.cs: Deply the PtrHashtable here and stop using the
12758 lame keys. Things work so much better.
12760 This of course broke everyone who depended on `RegisterMethod' to
12761 do the `test for existance' test. This has to be done elsewhere.
12763 * support.cs (PtrHashtable): A hashtable that avoid comparing with
12764 the object stupid Equals method (because, that like fails all over
12765 the place). We still do not use it.
12767 * class.cs (TypeContainer.SetRequiredInterface,
12768 TypeContainer.RequireMethods): Killed these two routines and moved
12769 all the functionality to RegisterRequiredImplementations.
12771 (TypeContainer.RegisterRequiredImplementations): This routine now
12772 registers all the implementations required in an array for the
12773 interfaces and abstract methods. We use an array of structures
12774 which can be computed ahead of time to reduce memory usage and we
12775 also assume that lookups are cheap as most classes will not
12776 implement too many interfaces.
12778 We also avoid creating too many MethodSignatures.
12780 (TypeContainer.IsInterfaceMethod): Update and optionally does not
12781 clear the "pending" bit if we find that there are problems with
12784 (TypeContainer.VerifyPendingMethods): Update to report errors of
12785 methods that look like implementations but are not.
12787 (TypeContainer.Define): Add support for explicit interface method
12790 2001-12-12 Miguel de Icaza <miguel@ximian.com>
12792 * typemanager.cs: Keep track of the parameters here instead of
12793 being a feature of the TypeContainer.
12795 * class.cs: Drop the registration of parameters here, as
12796 InterfaceMethods are also interface declarations.
12798 * delegate.cs: Register methods with the TypeManager not only with
12799 the TypeContainer. This code was buggy.
12801 * interface.cs: Full registation here.
12803 2001-12-11 Miguel de Icaza <miguel@ximian.com>
12805 * expression.cs: Remove reducer for binary expressions, it can not
12808 * const.cs: Put here the code that used to go into constant.cs
12810 * constant.cs: Put here the code for constants, this is a new base
12811 class for Literals.
12813 * literal.cs: Make Literal derive from Constant.
12815 2001-12-09 Miguel de Icaza <miguel@ximian.com>
12817 * statement.cs (Return.Emit): Report error 157 if the user
12818 attempts to return from a finally block.
12820 (Return.Emit): Instead of emitting a return, jump to the end of
12823 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
12824 LocalBuilder to store the result of the function. ReturnLabel is
12825 the target where we jump.
12828 2001-12-09 Radek Doulik <rodo@ximian.com>
12830 * cs-parser.jay: remember alias in current namespace
12832 * ecore.cs (SimpleName::DoResolve): use aliases for types or
12835 * class.cs (LookupAlias): lookup alias in my_namespace
12837 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
12839 (LookupAlias): lookup alias in this and if needed in parent
12842 2001-12-08 Miguel de Icaza <miguel@ximian.com>
12846 * rootcontext.cs: (ModuleBuilder) Made static, first step into
12847 making things static. I need this to avoid passing the
12848 TypeContainer when calling ParameterType.
12850 * support.cs (InternalParameters.ParameterType): Remove ugly hack
12851 that did string manipulation to compute the type and then call
12852 GetType. Use Parameter.ParameterType instead.
12854 * cs-tokenizer.cs: Consume the suffix for floating values.
12856 * expression.cs (ParameterReference): figure out whether this is a
12857 reference parameter or not. Kill an extra variable by computing
12858 the arg_idx during emission.
12860 * parameter.cs (Parameters.GetParameterInfo): New overloaded
12861 function that returns whether a parameter is an out/ref value or not.
12863 (Parameter.ParameterType): The type of the parameter (base,
12864 without ref/out applied).
12866 (Parameter.Resolve): Perform resolution here.
12867 (Parameter.ExternalType): The full type (with ref/out applied).
12869 * statement.cs (Using.Emit, Using.EmitExpression): Implement
12870 support for expressions on the using statement.
12872 2001-12-07 Miguel de Icaza <miguel@ximian.com>
12874 * statement.cs (Using.EmitLocalVariableDecls): Split the
12875 localvariable handling of the using statement.
12877 (Block.EmitMeta): Keep track of variable count across blocks. We
12878 were reusing slots on separate branches of blocks.
12880 (Try.Emit): Emit the general code block, we were not emitting it.
12882 Check the type of the declaration to be an IDisposable or
12883 something that can be implicity converted to it.
12885 Emit conversions if required.
12887 * ecore.cs (EmptyExpression): New utility class.
12888 (Expression.ImplicitConversionExists): New utility function.
12890 2001-12-06 Miguel de Icaza <miguel@ximian.com>
12892 * statement.cs (Using): Implement.
12894 * expression.cs (LocalVariableReference): Support read only variables.
12896 * statement.cs: Remove the explicit emit for the Leave opcode.
12897 (VariableInfo): Add a readonly field.
12899 2001-12-05 Miguel de Icaza <miguel@ximian.com>
12901 * ecore.cs (ConvCast): new class used to encapsulate the various
12902 explicit integer conversions that works in both checked and
12903 unchecked contexts.
12905 (Expression.ConvertNumericExplicit): Use new ConvCast class to
12906 properly generate the overflow opcodes.
12908 2001-12-04 Miguel de Icaza <miguel@ximian.com>
12910 * statement.cs: The correct type for the EmptyExpression is the
12911 element_type, not the variable type. Ravi pointed this out.
12913 2001-12-04 Ravi Pratap <ravi@ximian.com>
12915 * class.cs (Method::Define): Handle PInvoke methods specially
12916 by using DefinePInvokeMethod instead of the usual one.
12918 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
12919 above to do the task of extracting information and defining the method.
12921 2001-12-04 Ravi Pratap <ravi@ximian.com>
12923 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
12924 of the condition for string type.
12926 (Emit): Move that here.
12928 (ArrayCreation::CheckIndices): Keep string literals in their expression
12931 (EmitDynamicInitializers): Handle strings appropriately.
12933 2001-12-04 Miguel de Icaza <miguel@ximian.com>
12935 * codegen.cs (EmitContext): Replace multiple variables with a
12936 single pointer to the current Switch statement.
12938 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
12941 2001-12-03 Miguel de Icaza <miguel@ximian.com>
12945 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
12948 (Foreach.Emit): Foreach on arrays was not setting
12949 up the loop variables (for break/continue).
12951 (GotoCase): Semi-implented.
12953 2001-12-03 Ravi Pratap <ravi@ximian.com>
12955 * attribute.cs (CheckAttribute): Handle system attributes by using
12956 Attribute.GetAttributes to examine information we need.
12958 (GetValidPlaces): Same here.
12960 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
12962 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
12964 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
12966 (Method::Define): Set appropriate flags if we have a DllImport attribute.
12968 (Method::Emit): Handle the case when we are a PInvoke method.
12970 2001-12-03 Miguel de Icaza <miguel@ximian.com>
12972 * expression.cs: Use ResolveWithSimpleName on compound names.
12974 2001-12-02 Ravi Pratap <ravi@ximian.com>
12976 * constant.cs (EmitConstant): Make sure we resolve the associated expression
12977 before trying to reduce it.
12979 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
12981 * constant.cs (LookupConstantValue): Implement.
12983 (EmitConstant): Use the above in emitting the constant.
12985 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
12986 that are user-defined by doing a LookupConstantValue on them.
12988 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
12991 2001-11-29 Miguel de Icaza <miguel@ximian.com>
12993 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
12995 (BaseAccess.DoResolve): Implement.
12997 (MemberAccess.DoResolve): Split this routine into a
12998 ResolveMemberAccess routine that can be used independently
13000 2001-11-28 Miguel de Icaza <miguel@ximian.com>
13002 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
13003 As that share bits of the implementation. Is returns a boolean,
13004 while As returns the Type that is being probed.
13006 2001-12-01 Ravi Pratap <ravi@ximian.com>
13008 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
13009 instead of a Literal - much easier.
13011 (EnumInTransit): Remove - utterly useless :-)
13013 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
13015 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
13017 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
13018 chain when we have no associated expression.
13020 2001-11-30 Ravi Pratap <ravi@ximian.com>
13022 * constant.cs (Define): Use Location while reporting the errror.
13024 Also emit a warning when 'new' is used and there is no inherited
13027 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
13030 (LookupEnumValue): Implement to lookup an enum member's value and define it
13033 (Populate): Re-write accordingly to use the above routine.
13035 2001-11-27 Miguel de Icaza <miguel@ximian.com>
13037 * expression.cs (This): Fix prototype for DoResolveLValue to
13038 override the base class DoResolveLValue.
13040 * cs-parser.cs: Report errors cs574 and cs575 (destructor
13043 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
13044 (we need to load the address of the field here). This fixes
13047 (FieldExpr.DoResolveLValue): Call the DoResolve
13048 function to initialize the Instance expression.
13050 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
13051 correctly the GetEnumerator operation on a value type.
13053 * cs-parser.jay: Add more simple parsing error catches.
13055 * statement.cs (Switch): Add support for string switches.
13056 Handle null specially.
13058 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
13060 2001-11-28 Ravi Pratap <ravi@ximian.com>
13062 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
13064 (declare_local_constant): New helper function.
13066 * statement.cs (AddConstant): Keep a separate record of constants
13068 (IsConstant): Implement to determine if a variable is a constant.
13070 (GetConstantExpression): Implement.
13072 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
13074 * statement.cs (IsVariableDefined): Re-write.
13076 2001-11-27 Ravi Pratap <ravi@ximian.com>
13078 * class.cs (TypeContainer::FindMembers): Look for constants
13079 in the case when we are looking for MemberTypes.Field
13081 * expression.cs (MemberAccess::DoResolve): Check that in the
13082 case we are a FieldExpr and a Literal, we are not being accessed
13083 by an instance reference.
13085 * cs-parser.jay (local_constant_declaration): Implement.
13087 (declaration_statement): Implement for constant declarations.
13089 2001-11-26 Miguel de Icaza <miguel@ximian.com>
13091 * statement.cs (Switch): Catch double defaults.
13093 (Switch): More work on the switch() statement
13094 implementation. It works for integral values now, need to finish
13098 2001-11-24 Miguel de Icaza <miguel@ximian.com>
13100 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
13101 integer literals into other integer literals. To be used by
13104 2001-11-24 Ravi Pratap <ravi@ximian.com>
13106 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
13109 (EmitDynamicInitializers): Cope with the above since we extract data
13110 directly from ArrayData now.
13112 (ExpectInitializers): Keep track of whether initializers are mandatory
13115 (Bounds): Make it a hashtable to prevent the same dimension being
13116 recorded for every element in that dimension.
13118 (EmitDynamicInitializers): Fix bug which prevented the Set array method
13121 Also fix bug which was causing the indices to be emitted in the reverse
13124 2001-11-24 Miguel de Icaza <miguel@ximian.com>
13126 * expression.cs (ArrayCreation): Implement the bits that Ravi left
13127 unfinished. They do not work, because the underlying code is
13130 2001-11-22 Miguel de Icaza <miguel@ximian.com>
13132 * cs-parser.jay: Remove bogus fixme.
13134 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
13135 on Switch statement.
13137 2001-11-23 Ravi Pratap <ravi@ximian.com>
13139 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
13142 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
13143 parameter. Apparently, any expression is allowed.
13145 (ValidateInitializers): Update accordingly.
13147 (CheckIndices): Fix some tricky bugs thanks to recursion.
13149 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
13150 I was being completely brain-dead.
13152 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
13153 and re-write acordingly.
13155 (DelegateInvocation): Re-write accordingly.
13157 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
13159 (MakeByteBlob): Handle types more correctly.
13161 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
13162 initialization from expressions but it is incomplete because I am a complete
13165 2001-11-22 Miguel de Icaza <miguel@ximian.com>
13167 * statement.cs (If.Emit): Fix a bug that generated incorrect code
13168 on If. Basically, we have to return `true' (ie, we do return to
13169 our caller) only if both branches of the if return.
13171 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
13172 short-circuit operators, handle them as short circuit operators.
13174 (Cast.DoResolve): Resolve type.
13175 (Cast.Cast): Take an expression as the target type.
13177 * cs-parser.jay (cast_expression): Remove old hack that only
13178 allowed a limited set of types to be handled. Now we take a
13179 unary_expression and we resolve to a type during semantic
13182 Use the grammar productions from Rhys to handle casts (this is
13183 not complete like Rhys syntax yet, we fail to handle that corner
13184 case that C# has regarding (-x), but we will get there.
13186 2001-11-22 Ravi Pratap <ravi@ximian.com>
13188 * class.cs (EmitFieldInitializer): Take care of the case when we have a
13189 field which is an array type.
13191 * cs-parser.jay (declare_local_variables): Support array initialization too.
13193 * typemanager.cs (MakeKey): Implement.
13195 (everywhere): Use the above appropriately.
13197 * cs-parser.jay (for_statement): Update for array initialization while
13198 declaring variables.
13200 * ecore.cs : The error message was correct, it's the variable's names that
13201 were misleading ;-) Make the code more readable.
13203 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
13204 the correct type etc.
13206 (ConvertExplicit): Handle Enum types by examining the underlying type.
13208 2001-11-21 Ravi Pratap <ravi@ximian.com>
13210 * parameter.cs (GetCallingConvention): Always return
13211 CallingConventions.Standard for now.
13213 2001-11-22 Miguel de Icaza <miguel@ximian.com>
13215 * expression.cs (Binary.ResolveOperator): Update the values of `l'
13216 and `r' after calling DoNumericPromotions.
13218 * ecore.cs: Fix error message (the types were in the wrong order).
13220 * statement.cs (Foreach.ProbeCollectionType): Need to pass
13221 BindingFlags.Instance as well
13223 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
13224 implicit int literal conversion in an empty cast so that we
13225 propagate the right type upstream.
13227 (UnboxCast): new class used to unbox value types.
13228 (Expression.ConvertExplicit): Add explicit type conversions done
13231 (Expression.ImplicitNumericConversion): Oops, forgot to test for
13232 the target type before applying the implicit LongLiterals to ULong
13235 2001-11-21 Miguel de Icaza <miguel@ximian.com>
13237 * cs-parser.jay (for_statement): Reworked the way For works: now
13238 we declare manually any variables that are introduced in
13239 for_initializer to solve the problem of having out-of-band code
13240 emition (that is what got for broken).
13242 (declaration_statement): Perform the actual variable declaration
13243 that used to be done in local_variable_declaration here.
13245 (local_variable_declaration): Do not declare anything, just pass
13246 the information on a DictionaryEntry
13248 2001-11-20 Ravi Pratap <ravi@ximian.com>
13250 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
13251 re-write of the logic to now make it recursive.
13253 (UpdateIndices): Re-write accordingly.
13255 Store element data in a separate ArrayData list in the above methods.
13257 (MakeByteBlob): Implement to dump the array data into a byte array.
13259 2001-11-19 Ravi Pratap <ravi@ximian.com>
13261 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
13264 * constant.cs (Define): Implement.
13266 (EmitConstant): Re-write fully.
13268 Pass in location info.
13270 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
13273 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
13274 DictionaryEntry since we need location info too.
13276 (constant_declaration): Update accordingly.
13278 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
13279 code into another method : UpdateIndices.
13281 2001-11-18 Ravi Pratap <ravi@ximian.com>
13283 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
13284 some type checking etc.
13286 2001-11-17 Ravi Pratap <ravi@ximian.com>
13288 * expression.cs (ArrayCreation::ValidateInitializers): Implement
13289 bits to provide dimension info if the user skips doing that.
13291 Update second constructor to store the rank correctly.
13293 2001-11-16 Ravi Pratap <ravi@ximian.com>
13295 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
13296 and try to implement.
13298 * ../errors/cs0150.cs : Add.
13300 * ../errors/cs0178.cs : Add.
13302 2001-11-16 Miguel de Icaza <miguel@ximian.com>
13304 * statement.cs: Implement foreach on multi-dimensional arrays.
13306 * parameter.cs (Parameters.GetParameterByName): Also lookup the
13307 name of the params argument.
13309 * expression.cs: Use EmitStoreOpcode to get the right opcode while
13310 initializing the array.
13312 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
13313 we can use this elsewhere.
13315 * statement.cs: Finish implementation of foreach for single
13318 * cs-parser.jay: Use an out-of-band stack to pass information
13319 around, I wonder why I need this.
13321 foreach_block: Make the new foreach_block the current_block.
13323 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
13324 function used to return a static Parameters structure. Used for
13325 empty parameters, as those are created very frequently.
13327 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
13329 2001-11-15 Ravi Pratap <ravi@ximian.com>
13331 * interface.cs : Default modifier is private, not public. The
13332 make verify test passes again.
13334 2001-11-15 Ravi Pratap <ravi@ximian.com>
13336 * support.cs (ReflectionParameters): Fix logic to determine
13337 whether the last parameter is a params one. Test 9 passes again.
13339 * delegate.cs (Populate): Register the builders we define with
13340 RegisterParameterForBuilder. Test 19 passes again.
13342 * cs-parser.jay (property_declaration): Reference $6 instead
13343 of $$ to get at the location.
13345 (indexer_declaration): Similar stuff.
13347 (attribute): Ditto.
13349 * class.cs (Property): Register parameters for the Get and Set methods
13350 if they exist. Test 23 passes again.
13352 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
13353 call to EmitArguments as we are sure there aren't any params arguments.
13354 Test 32 passes again.
13356 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
13357 IndexOutOfRangeException.
13359 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
13360 Test 33 now passes again.
13362 2001-11-15 Miguel de Icaza <miguel@ximian.com>
13364 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
13365 broke a bunch of things. Will have to come up with a better way
13366 of tracking locations.
13368 * statement.cs: Implemented foreach for single dimension arrays.
13370 2001-11-09 Miguel de Icaza <miguel@ximian.com>
13372 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
13373 an error. This removes the lookup from the critical path.
13375 * cs-parser.jay: Removed use of temporary_loc, which is completely
13378 2001-11-14 Miguel de Icaza <miguel@ximian.com>
13380 * support.cs (ReflectionParameters.ParameterModifier): Report
13381 whether the argument is a PARAMS argument or not.
13383 * class.cs: Set the attribute `ParamArrayAttribute' on the
13384 parameter argument.
13386 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
13387 and cons_param_array_attribute (ConstructorInfo for
13388 ParamArrayAttribute).,
13390 * codegen.cs: Emit the return using the `Return' statement, that
13391 way we can report the error correctly for missing return values.
13393 * class.cs (Method.Emit): Clean up.
13395 * expression.cs (Argument.Resolve): Take another argument: the
13396 location where this argument is used. Notice that this is not
13397 part of the "Argument" class as to reduce the size of the
13398 structure (we know the approximate location anyways).
13400 Test if the argument is a variable-reference, if not, then
13401 complain with a 206.
13403 (Argument.Emit): Emit addresses of variables.
13405 (Argument.FullDesc): Simplify.
13407 (Invocation.DoResolve): Update for Argument.Resolve.
13409 (ElementAccess.DoResolve): ditto.
13411 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
13412 method should be virtual, as this method is always virtual.
13414 (NewDelegate.DoResolve): Update for Argument.Resolve.
13416 * class.cs (ConstructorInitializer.DoResolve): ditto.
13418 * attribute.cs (Attribute.Resolve): ditto.
13420 2001-11-13 Miguel de Icaza <miguel@ximian.com>
13422 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
13424 * expression.cs (ParameterReference): Drop IStackStorage and implement
13425 IAssignMethod instead.
13427 (LocalVariableReference): ditto.
13429 * ecore.cs (FieldExpr): Drop IStackStorage and implement
13430 IAssignMethod instead.
13432 2001-11-13 Miguel de Icaza <miguel@ximian.com>
13434 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
13435 enumerations that are used in heavily used structures derive from
13436 byte in a laughable and pathetic attempt to reduce memory usage.
13437 This is the kind of pre-optimzations that you should not do at
13438 home without adult supervision.
13440 * expression.cs (UnaryMutator): New class, used to handle ++ and
13441 -- separatedly from the other unary operators. Cleans up the
13442 code, and kills the ExpressionStatement dependency in Unary.
13444 (Unary): Removed `method' and `Arguments' from this class, making
13445 it smaller, and moving it all to SimpleCall, so I can reuse this
13446 code in other locations and avoid creating a lot of transient data
13447 strucutres when not required.
13449 * cs-parser.jay: Adjust for new changes.
13451 2001-11-11 Miguel de Icaza <miguel@ximian.com>
13453 * enum.cs (Enum.Populate): If there is a failure during
13456 * cs-parser.jay (opt_enum_base): we used to catch type errors
13457 here, but this is really incorrect. The type error should be
13458 catched during semantic analysis.
13460 2001-12-11 Ravi Pratap <ravi@ximian.com>
13462 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
13463 current_local_parameters as expected since I, in my stupidity, had forgotten
13466 * attribute.cs (GetValidPlaces): Fix stupid bug.
13468 * class.cs (Method::Emit): Perform check on applicability of attributes.
13470 (Constructor::Emit): Ditto.
13472 (Field::Emit): Ditto.
13474 (Field.Location): Store location information.
13476 (Property, Event, Indexer, Operator): Ditto.
13478 * cs-parser.jay (field_declaration): Pass in location for each field.
13480 * ../errors/cs0592.cs : Add.
13482 2001-11-12 Ravi Pratap <ravi@ximian.com>
13484 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
13486 (InitCoreTypes): Update accordingly.
13488 (RegisterAttrType, LookupAttr): Implement.
13490 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
13491 info about the same.
13493 (Resolve): Update to populate the above as necessary.
13495 (Error592): Helper.
13497 (GetValidPlaces): Helper to the above.
13499 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
13501 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
13503 2001-11-12 Ravi Pratap <ravi@ximian.com>
13505 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
13507 * ../errors/cs0617.cs : Add.
13509 2001-11-11 Ravi Pratap <ravi@ximian.com>
13511 * enum.cs (Emit): Rename to Populate to be more consistent with what
13512 we expect it to do and when exactly it is called.
13514 * class.cs, rootcontext.cs : Update accordingly.
13516 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
13517 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
13519 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
13521 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
13522 of a fieldinfo using the above, when dealing with a FieldBuilder.
13524 2001-11-10 Ravi Pratap <ravi@ximian.com>
13526 * ../errors/cs0031.cs : Add.
13528 * ../errors/cs1008.cs : Add.
13530 * ../errrors/cs0543.cs : Add.
13532 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
13535 (FindMembers): Implement.
13537 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
13538 enums and delegates too.
13540 (enum_types): Rename to builder_to_enum.
13542 (delegate_types): Rename to builder_to_delegate.
13544 * delegate.cs (FindMembers): Implement.
13546 2001-11-09 Ravi Pratap <ravi@ximian.com>
13548 * typemanager.cs (IsEnumType): Implement.
13550 * enum.cs (Emit): Re-write parts to account for the underlying type
13551 better and perform checking etc.
13553 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
13554 of the underlying type.
13556 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
13559 * enum.cs (error31): Helper to report error #31.
13561 * cs-parser.jay (enum_declaration): Store location of each member too.
13563 * enum.cs (member_to_location): New hashtable.
13565 (AddEnumMember): Update location hashtable.
13567 (Emit): Use the location of each member while reporting errors.
13569 2001-11-09 Miguel de Icaza <miguel@ximian.com>
13571 * cs-parser.jay: A for_initializer if is a
13572 local_variable_declaration really ammount to have an implicit
13573 block with the variable declaration and no initializer for for.
13575 * statement.cs (For.Emit): Cope with null initializers.
13577 This fixes the infinite loop on for initializers.
13579 2001-11-08 Miguel de Icaza <miguel@ximian.com>
13581 * enum.cs: More cleanup.
13583 * ecore.cs: Remove dead code.
13585 * class.cs (Property.Emit): More simplification.
13586 (Event.Emit): ditto.
13588 Reworked to have less levels of indentation.
13590 2001-11-08 Ravi Pratap <ravi@ximian.com>
13592 * class.cs (Property): Emit attributes.
13602 * enum.cs (Emit): Ditto.
13604 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
13607 * class.cs (Field, Event, etc.): Move attribute generation into the
13608 Emit method everywhere.
13610 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
13611 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
13612 as we had no way of defining nested enums !
13614 * rootcontext.cs : Adjust code accordingly.
13616 * typemanager.cs (AddEnumType): To keep track of enum types separately.
13618 2001-11-07 Ravi Pratap <ravi@ximian.com>
13620 * expression.cs (EvalConstantExpression): Move into ecore.cs
13622 * enum.cs (Enum): Rename some members and make them public and readonly
13623 according to our convention.
13625 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
13628 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
13630 (Enum::Emit): Write a simple version for now which doesn't try to compute
13631 expressions. I shall modify this to be more robust in just a while.
13633 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
13635 (TypeContainer::CloseType): Create the Enum types too.
13637 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
13639 * expression.cs (EvalConstantExpression): Get rid of completely.
13641 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
13642 user-defined values and other cases.
13644 (IsValidEnumLiteral): Helper function.
13646 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
13647 out there in the case we had a literal FieldExpr.
13649 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
13651 (Literalize): Revamp a bit to take two arguments.
13653 (EnumLiteral): New class which derives from Literal to wrap enum literals.
13655 2001-11-06 Ravi Pratap <ravi@ximian.com>
13657 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
13659 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
13661 (Resolve): Use the above to ensure we have proper initializers.
13663 2001-11-05 Ravi Pratap <ravi@ximian.com>
13665 * expression.cs (Expression::EvalConstantExpression): New method to
13666 evaluate constant expressions.
13668 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
13670 2001-11-07 Miguel de Icaza <miguel@ximian.com>
13672 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
13675 (Binary.ResolveOperator): Handle operator != (object a, object b)
13676 and operator == (object a, object b);
13678 (Binary.DoNumericPromotions): Indicate whether the numeric
13679 promotion was possible.
13681 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
13684 Made the ArrayAccess implement interface IAssignMethod instead of
13685 IStackStore as the order in which arguments are passed reflects
13688 * assign.cs: Instead of using expr.ExprClass to select the way of
13689 assinging, probe for the IStackStore/IAssignMethod interfaces.
13691 * typemanager.cs: Load InitializeArray definition.
13693 * rootcontext.cs (RootContext.MakeStaticData): Used to define
13694 static data that can be used to initialize arrays.
13696 2001-11-05 Miguel de Icaza <miguel@ximian.com>
13698 * expression.cs: Handle operator== and operator!= for booleans.
13700 (Conditioal.Reduce): Implement reducer for the ?: operator.
13702 (Conditional.Resolve): Implement dead code elimination.
13704 (Binary.Resolve): Catch string literals and return a new
13705 concatenated string.
13707 (Unary.Reduce): Implement reduction of unary expressions.
13709 * ecore.cs: Split out the expression core handling here.
13711 (Expression.Reduce): New method used to perform constant folding
13712 and CSE. This is needed to support constant-expressions.
13714 * statement.cs (Statement.EmitBoolExpression): Pass true and false
13715 targets, and optimize for !x.
13717 2001-11-04 Ravi Pratap <ravi@ximian.com>
13719 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
13720 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
13721 set custom atttributes.
13723 * literal.cs (Literal::GetValue): New abstract method to return the actual
13724 value of the literal, cast as an object.
13726 (*Literal): Implement GetValue method.
13728 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
13729 expressions to the arraylist but objects of type Argument.
13731 * class.cs (TypeContainer::Emit): Emit our attributes too.
13733 (Method::Emit, Constructor::Emit): Ditto.
13735 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
13736 to be ignoring earlier.
13738 2001-11-03 Ravi Pratap <ravi@ximian.com>
13740 * attribute.cs (AttributeSection::Define): Implement to do the business
13741 of constructing a CustomAttributeBuilder.
13743 (Attribute): New trivial class. Increases readability of code.
13745 * cs-parser.jay : Update accordingly.
13747 (positional_argument_list, named_argument_list, named_argument): New rules
13749 (attribute_arguments): Use the above so that we are more correct.
13751 2001-11-02 Ravi Pratap <ravi@ximian.com>
13753 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
13754 to perform all checks for a method with a params parameter.
13756 (Invocation::OverloadResolve): Update to use the above method and therefore
13757 cope correctly with params method invocations.
13759 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
13762 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
13763 constructors in our parent too because we can't afford to miss out on
13766 * attribute.cs (AttributeSection): New name for the class Attribute
13768 Other trivial changes to improve readability.
13770 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
13771 use the new class names.
13773 2001-11-01 Ravi Pratap <ravi@ximian.com>
13775 * class.cs (Method::Define): Complete definition for params types too
13777 (Indexer::Define): Ditto.
13779 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
13780 Cope everywhere with a request for info about the array parameter.
13782 2001-11-01 Ravi Pratap <ravi@ximian.com>
13784 * tree.cs (RecordNamespace): Fix up to check for the correct key.
13786 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
13787 local_variable_type to extract the string corresponding to the type.
13789 (local_variable_type): Fixup the action to use the new helper method.
13791 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
13794 * expression.cs : Clean out code which uses the above.
13796 2001-10-31 Ravi Pratap <ravi@ximian.com>
13798 * typemanager.cs (RegisterMethod): Check if we already have an existing key
13799 and bale out if necessary by returning a false.
13801 (RegisterProperty): Ditto.
13803 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
13804 and print out appropriate error messages.
13806 * interface.cs (everywhere): Ditto.
13808 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
13809 location to constructor.
13811 * class.cs (Property, Event, Indexer): Update accordingly.
13813 * ../errors/cs111.cs : Added.
13815 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
13816 of a method, as laid down by the spec.
13818 (Invocation::OverloadResolve): Use the above method.
13820 2001-10-31 Ravi Pratap <ravi@ximian.com>
13822 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
13823 now take a TypeContainer and a Parameters object.
13825 (ParameterData): Modify return type of ParameterModifier method to be
13826 Parameter.Modifier and not a string.
13828 (ReflectionParameters, InternalParameters): Update accordingly.
13830 * expression.cs (Argument::GetParameterModifier): Same here.
13832 * support.cs (InternalParameters::ParameterType): Find a better way of determining
13833 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
13834 symbol in it at all so maybe this is only for now.
13836 2001-10-30 Ravi Pratap <ravi@ximian.com>
13838 * support.cs (InternalParameters): Constructor now takes an extra argument
13839 which is the actual Parameters class.
13841 (ParameterDesc): Update to provide info on ref/out modifiers.
13843 * class.cs (everywhere): Update call to InternalParameters to pass in
13844 the second argument too.
13846 * support.cs (ParameterData): Add ParameterModifier, which is a method
13847 to return the modifier info [ref/out etc]
13849 (InternalParameters, ReflectionParameters): Implement the above.
13851 * expression.cs (Argument::ParameterModifier): Similar function to return
13852 info about the argument's modifiers.
13854 (Invocation::OverloadResolve): Update to take into account matching modifiers
13857 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
13858 a new SetFormalParameters object which we pass to InternalParameters.
13860 2001-10-30 Ravi Pratap <ravi@ximian.com>
13862 * expression.cs (NewArray): Merge into the ArrayCreation class.
13864 2001-10-29 Ravi Pratap <ravi@ximian.com>
13866 * expression.cs (NewArray): Merge classes NewBuiltinArray and
13867 NewUserdefinedArray into one as there wasn't much of a use in having
13870 * expression.cs (Argument): Change field's name to ArgType from Type.
13872 (Type): New readonly property which returns the proper type, taking into
13873 account ref/out modifiers.
13875 (everywhere): Adjust code accordingly for the above.
13877 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
13878 whether we are emitting for a ref or out parameter.
13880 * expression.cs (Argument::Emit): Use the above field to set the state.
13882 (LocalVariableReference::Emit): Update to honour the flag and emit the
13885 * parameter.cs (Attributes): Set the correct flags for ref parameters.
13887 * expression.cs (Argument::FullDesc): New function to provide a full desc.
13889 * support.cs (ParameterData): Add method ParameterDesc to the interface.
13891 (ReflectionParameters, InternalParameters): Implement the above method.
13893 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
13896 (Invocation::FullMethodDesc): Ditto.
13898 2001-10-29 Miguel de Icaza <miguel@ximian.com>
13900 * cs-parser.jay: Add extra production for the second form of array
13903 * expression.cs (ArrayCreation): Update to reflect the above
13906 * Small changes to prepare for Array initialization.
13908 2001-10-28 Miguel de Icaza <miguel@ximian.com>
13910 * typemanager.cs (ImplementsInterface): interface might be null;
13911 Deal with this problem;
13913 Also, we do store negative hits on the cache (null values), so use
13914 this instead of calling t.GetInterfaces on the type everytime.
13916 2001-10-28 Ravi Pratap <ravi@ximian.com>
13918 * typemanager.cs (IsBuiltinType): New method to help determine the same.
13920 * expression.cs (New::DoResolve): Get rid of array creation code and instead
13921 split functionality out into different classes.
13923 (New::FormArrayType): Move into NewBuiltinArray.
13925 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
13928 (NewBuiltinArray): New class to handle creation of built-in arrays.
13930 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
13931 account creation of one-dimensional arrays.
13933 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
13935 (NewUserdefinedArray::DoResolve): Implement.
13937 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
13939 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
13940 we maintain inside the TypeManager. This is necessary to perform lookups on the
13943 (LookupType): Update to perform GetType on the module builders too.
13945 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
13947 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
13949 2001-10-23 Ravi Pratap <ravi@ximian.com>
13951 * expression.cs (New::DoResolve): Implement guts of array creation.
13953 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
13955 2001-10-27 Miguel de Icaza <miguel@ximian.com>
13957 * expression.cs: Fix bug I introduced lsat night that broke
13960 (Expression.Resolve): Report a 246 error (can not resolve name)
13961 if we find a SimpleName in the stream.
13963 (Expression.ResolveLValue): Ditto.
13965 (Expression.ResolveWithSimpleName): This function is a variant of
13966 ResolveName, this one allows SimpleNames to be returned without a
13967 warning. The only consumer of SimpleNames is MemberAccess
13969 2001-10-26 Miguel de Icaza <miguel@ximian.com>
13971 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
13972 might arrive here. I have my doubts that this is correct.
13974 * statement.cs (Lock): Implement lock statement.
13976 * cs-parser.jay: Small fixes to support `lock' and `using'
13978 * cs-tokenizer.cs: Remove extra space
13980 * driver.cs: New flag --checked, allows to turn on integer math
13983 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
13984 Threading.Monitor.Exit
13986 2001-10-23 Miguel de Icaza <miguel@ximian.com>
13988 * expression.cs (IndexerAccess::DoResolveLValue): Set the
13989 Expression Class to be IndexerAccess.
13991 Notice that Indexer::DoResolve sets the eclass to Value.
13993 2001-10-22 Miguel de Icaza <miguel@ximian.com>
13995 * class.cs (TypeContainer::Emit): Emit code for indexers.
13997 * assign.cs (IAssignMethod): New interface implemented by Indexers
13998 and Properties for handling assignment.
14000 (Assign::Emit): Simplify and reuse code.
14002 * expression.cs (IndexerAccess, PropertyExpr): Implement
14003 IAssignMethod, clean up old code.
14005 2001-10-22 Ravi Pratap <ravi@ximian.com>
14007 * typemanager.cs (ImplementsInterface): New method to determine if a type
14008 implements a given interface. Provides a nice cache too.
14010 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
14013 (ConvertReferenceExplicit): Ditto.
14015 * delegate.cs (Delegate::Populate): Update to define the parameters on the
14016 various methods, with correct names etc.
14018 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
14019 Operator.UnaryNegation.
14021 * cs-parser.jay (operator_declarator): Be a little clever in the case where
14022 we have a unary plus or minus operator.
14024 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
14027 * everywhere : update accordingly.
14029 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
14032 * class.cs (Method::Define): For the case where we are implementing a method
14033 inherited from an interface, we need to set the MethodAttributes.Final flag too.
14034 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
14036 2001-10-21 Ravi Pratap <ravi@ximian.com>
14038 * interface.cs (FindMembers): Implement to work around S.R.E
14041 * typemanager.cs (IsInterfaceType): Implement.
14043 (FindMembers): Update to handle interface types too.
14045 * expression.cs (ImplicitReferenceConversion): Re-write bits which
14046 use IsAssignableFrom as that is not correct - it doesn't work.
14048 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
14049 and accordingly override EmitStatement.
14051 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
14052 using the correct logic :-)
14054 2001-10-19 Ravi Pratap <ravi@ximian.com>
14056 * ../errors/cs-11.cs : Add to demonstrate error -11
14058 2001-10-17 Miguel de Icaza <miguel@ximian.com>
14060 * assign.cs (Assign::Resolve): Resolve right hand side first, and
14061 then pass this as a hint to ResolveLValue.
14063 * expression.cs (FieldExpr): Add Location information
14065 (FieldExpr::LValueResolve): Report assignment to readonly
14068 (Expression::ExprClassFromMemberInfo): Pass location information.
14070 (Expression::ResolveLValue): Add new method that resolves an
14073 (Expression::DoResolveLValue): Default invocation calls
14076 (Indexers): New class used to keep track of indexers in a given
14079 (IStackStore): Renamed from LValue, as it did not really describe
14080 what this did. Also ResolveLValue is gone from this interface and
14081 now is part of Expression.
14083 (ElementAccess): Depending on the element access type
14085 * typemanager.cs: Add `indexer_name_type' as a Core type
14086 (System.Runtime.CompilerServices.IndexerNameAttribute)
14088 * statement.cs (Goto): Take a location.
14090 2001-10-18 Ravi Pratap <ravi@ximian.com>
14092 * delegate.cs (Delegate::VerifyDelegate): New method to verify
14093 if two delegates are compatible.
14095 (NewDelegate::DoResolve): Update to take care of the case when
14096 we instantiate a delegate from another delegate.
14098 * typemanager.cs (FindMembers): Don't even try to look up members
14099 of Delegate types for now.
14101 2001-10-18 Ravi Pratap <ravi@ximian.com>
14103 * delegate.cs (NewDelegate): New class to take care of delegate
14106 * expression.cs (New): Split the delegate related code out into
14107 the NewDelegate class.
14109 * delegate.cs (DelegateInvocation): New class to handle delegate
14112 * expression.cs (Invocation): Split out delegate related code into
14113 the DelegateInvocation class.
14115 2001-10-17 Ravi Pratap <ravi@ximian.com>
14117 * expression.cs (New::DoResolve): Implement delegate creation fully
14118 and according to the spec.
14120 (New::DoEmit): Update to handle delegates differently.
14122 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
14123 because of which we were printing out arguments in reverse order !
14125 * delegate.cs (VerifyMethod): Implement to check if the given method
14126 matches the delegate.
14128 (FullDelegateDesc): Implement.
14130 (VerifyApplicability): Implement.
14132 * expression.cs (Invocation::DoResolve): Update to accordingly handle
14133 delegate invocations too.
14135 (Invocation::Emit): Ditto.
14137 * ../errors/cs1593.cs : Added.
14139 * ../errors/cs1594.cs : Added.
14141 * delegate.cs (InstanceExpression, TargetMethod): New properties.
14143 2001-10-16 Ravi Pratap <ravi@ximian.com>
14145 * typemanager.cs (intptr_type): Core type for System.IntPtr
14147 (InitCoreTypes): Update for the same.
14149 (iasyncresult_type, asynccallback_type): Ditto.
14151 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
14154 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
14157 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
14158 the builders for the 4 members of a delegate type :-)
14160 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
14163 * expression.cs (New::DoResolve): Implement guts for delegate creation.
14165 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
14167 2001-10-15 Miguel de Icaza <miguel@ximian.com>
14169 * statement.cs (Break::Emit): Implement.
14170 (Continue::Emit): Implement.
14172 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
14173 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
14174 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
14175 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
14178 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
14179 properties that track the label for the current loop (begin of the
14180 loop and end of the loop).
14182 2001-10-15 Ravi Pratap <ravi@ximian.com>
14184 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
14185 use of emitting anything at all.
14187 * class.cs, rootcontext.cs : Get rid of calls to the same.
14189 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
14191 (Populate): Define the constructor correctly and set the implementation
14194 * typemanager.cs (delegate_types): New hashtable to hold delegates that
14197 (AddDelegateType): Implement.
14199 (IsDelegateType): Implement helper method.
14201 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
14203 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
14204 and accordingly handle it.
14206 * delegate.cs (Populate): Take TypeContainer argument.
14207 Implement bits to define the Invoke method. However, I still haven't figured out
14208 how to take care of the native int bit :-(
14210 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
14211 Qualify the name of the delegate, not its return type !
14213 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
14216 (StandardConversionExists): Checking for array types turns out to be recursive.
14218 (ConvertReferenceExplicit): Implement array conversion.
14220 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
14222 2001-10-12 Ravi Pratap <ravi@ximian.com>
14224 * cs-parser.jay (delegate_declaration): Store the fully qualified
14225 name as it is a type declaration.
14227 * delegate.cs (ReturnType, Name): Rename members to these. Make them
14230 (DefineDelegate): Renamed from Define. Does the same thing essentially,
14231 as TypeContainer::DefineType.
14233 (Populate): Method in which all the definition of the various methods (Invoke)
14236 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
14239 (CloseDelegate): Finally creates the delegate.
14241 * class.cs (TypeContainer::DefineType): Update to define delegates.
14242 (Populate, Emit and CloseType): Do the same thing here too.
14244 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
14245 delegates in all these operations.
14247 2001-10-14 Miguel de Icaza <miguel@ximian.com>
14249 * expression.cs: LocalTemporary: a new expression used to
14250 reference a temporary that has been created.
14252 * assign.cs: Handle PropertyAccess back here, so that we can
14253 provide the proper semantic access to properties.
14255 * expression.cs (Expression::ConvertReferenceExplicit): Implement
14256 a few more explicit conversions.
14258 * modifiers.cs: `NEW' modifier maps to HideBySig.
14260 * expression.cs (PropertyExpr): Make this into an
14261 ExpressionStatement, and support the EmitStatement code path.
14263 Perform get/set error checking, clean up the interface.
14265 * assign.cs: recognize PropertyExprs as targets, and if so, turn
14266 them into toplevel access objects.
14268 2001-10-12 Miguel de Icaza <miguel@ximian.com>
14270 * expression.cs: PropertyExpr::PropertyExpr: use work around the
14273 * typemanager.cs: Keep track here of our PropertyBuilders again to
14274 work around lameness in SRE.
14276 2001-10-11 Miguel de Icaza <miguel@ximian.com>
14278 * expression.cs (LValue::LValueResolve): New method in the
14279 interface, used to perform a second resolution pass for LValues.
14281 (This::DoResolve): Catch the use of this in static methods.
14283 (This::LValueResolve): Implement.
14285 (This::Store): Remove warning, assigning to `this' in structures
14288 (Invocation::Emit): Deal with invocation of
14289 methods on value types. We need to pass the address to structure
14290 methods rather than the object itself. (The equivalent code to
14291 emit "this" for structures leaves the entire structure on the
14292 stack instead of a pointer to it).
14294 (ParameterReference::DoResolve): Compute the real index for the
14295 argument based on whether the method takes or not a `this' pointer
14296 (ie, the method is static).
14298 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
14299 value types returned from functions when we need to invoke a
14300 method on the sturcture.
14303 2001-10-11 Ravi Pratap <ravi@ximian.com>
14305 * class.cs (TypeContainer::DefineType): Method to actually do the business of
14306 defining the type in the Modulebuilder or Typebuilder. This is to take
14307 care of nested types which need to be defined on the TypeBuilder using
14308 DefineNestedMethod.
14310 (TypeContainer::GetClassBases): Implement. Essentially the code from the
14311 methods in RootContext, only ported to be part of TypeContainer.
14313 (TypeContainer::GetInterfaceOrClass): Ditto.
14315 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
14317 * interface.cs (Interface::DefineInterface): New method. Does exactly
14318 what RootContext.CreateInterface did earlier, only it takes care of nested types
14321 (Interface::GetInterfaces): Move from RootContext here and port.
14323 (Interface::GetInterfaceByName): Same here.
14325 * rootcontext.cs (ResolveTree): Re-write.
14327 (PopulateTypes): Re-write.
14329 * class.cs (TypeContainer::Populate): Populate nested types too.
14330 (TypeContainer::Emit): Emit nested members too.
14332 * typemanager.cs (AddUserType): Do not make use of the FullName property,
14333 instead just use the name argument passed in as it is already fully
14336 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
14337 to TypeContainer mapping to see if a type is user-defined.
14339 * class.cs (TypeContainer::CloseType): Implement.
14341 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
14342 the default constructor.
14344 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
14347 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
14349 * interface.cs (CloseType): Create the type here.
14351 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
14354 Remove all the methods which are now in TypeContainer.
14356 2001-10-10 Ravi Pratap <ravi@ximian.com>
14358 * delegate.cs (Define): Re-write bits to define the delegate
14361 2001-10-10 Miguel de Icaza <miguel@ximian.com>
14363 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
14365 * expression.cs (ImplicitReferenceConversion): handle null as well
14366 as a source to convert to any reference type.
14368 * statement.cs (Return): Perform any implicit conversions to
14369 expected return type.
14371 Validate use of return statement.
14373 * codegen.cs (EmitContext): Pass the expected return type here.
14375 * class.cs (Method, Constructor, Property): Pass expected return
14376 type to EmitContext.
14378 2001-10-09 Miguel de Icaza <miguel@ximian.com>
14380 * expression.cs: Make DoResolve take an EmitContext instead of a
14383 Replaced `l' and `location' for `loc', for consistency.
14385 (Error, Warning): Remove unneeded Tc argument.
14387 * assign.cs, literal.cs, constant.cs: Update to new calling
14390 * codegen.cs: EmitContext now contains a flag indicating whether
14391 code is being generated in a static method or not.
14393 * cs-parser.jay: DecomposeQI, new function that replaces the old
14394 QualifiedIdentifier. Now we always decompose the assembled
14395 strings from qualified_identifier productions into a group of
14398 2001-10-08 Miguel de Icaza <miguel@ximian.com>
14400 * rootcontext.cs: Deal with field-less struct types correctly now
14401 by passing the size option to Define Type.
14403 * class.cs: Removed hack that created one static field.
14405 2001-10-07 Miguel de Icaza <miguel@ximian.com>
14407 * statement.cs: Moved most of the code generation here.
14409 2001-10-09 Ravi Pratap <ravi@ximian.com>
14411 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
14414 (ElementAccess): Remove useless bits for now - keep checks as the spec
14417 2001-10-08 Ravi Pratap <ravi@ximian.com>
14419 * expression.cs (ElementAccess::DoResolve): Remove my crap code
14420 and start performing checks according to the spec.
14422 2001-10-07 Ravi Pratap <ravi@ximian.com>
14424 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
14425 rank_specifiers instead.
14427 (rank_specifiers): Change the order in which the rank specifiers are stored
14429 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
14431 * expression.cs (ElementAccess): Implement the LValue interface too.
14433 2001-10-06 Ravi Pratap <ravi@ximian.com>
14435 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
14436 except that user defined conversions are not included.
14438 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
14439 perform the conversion of the return type, if necessary.
14441 (New::DoResolve): Check whether we are creating an array or an object
14442 and accordingly do the needful.
14444 (New::Emit): Same here.
14446 (New::DoResolve): Implement guts of array creation.
14448 (New::FormLookupType): Helper function.
14450 2001-10-07 Miguel de Icaza <miguel@ximian.com>
14452 * codegen.cs: Removed most of the code generation here, and move the
14453 corresponding code generation bits to the statement classes.
14455 Added support for try/catch/finalize and throw.
14457 * cs-parser.jay: Added support for try/catch/finalize.
14459 * class.cs: Catch static methods having the flags override,
14460 virtual or abstract.
14462 * expression.cs (UserCast): This user cast was not really doing
14463 what it was supposed to do. Which is to be born in fully resolved
14464 state. Parts of the resolution were being performed at Emit time!
14468 2001-10-05 Miguel de Icaza <miguel@ximian.com>
14470 * expression.cs: Implicity convert the result from UserCast.
14472 2001-10-05 Ravi Pratap <ravi@ximian.com>
14474 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
14475 prevented it from working correctly.
14477 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
14478 merely ConvertImplicit.
14480 2001-10-05 Miguel de Icaza <miguel@ximian.com>
14482 * typemanager.cs: Make the LookupTypeContainer function static,
14483 and not per-instance.
14485 * class.cs: Make static FindMembers (the one that takes a Type
14488 * codegen.cs: Add EmitForeach here.
14490 * cs-parser.jay: Make foreach a toplevel object instead of the
14491 inline expansion, as we need to perform semantic analysis on it.
14493 2001-10-05 Ravi Pratap <ravi@ximian.com>
14495 * expression.cs (Expression::ImplicitUserConversion): Rename to
14496 UserDefinedConversion.
14498 (Expression::UserDefinedConversion): Take an extra argument specifying
14499 whether we look for explicit user conversions too.
14501 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
14503 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
14505 (ExplicitUserConversion): Make it a call to UserDefinedConversion
14506 with the appropriate arguments.
14508 * cs-parser.jay (cast_expression): Record location too.
14510 * expression.cs (Cast): Record location info.
14512 (Expression::ConvertExplicit): Take location argument.
14514 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
14515 to determine if we are doing explicit conversions.
14517 (UserCast::Emit): Update accordingly.
14519 (Expression::ConvertExplicit): Report an error if everything fails.
14521 * ../errors/cs0030.cs : Add.
14523 2001-10-04 Miguel de Icaza <miguel@ximian.com>
14525 * modifiers.cs: If the ABSTRACT keyword is present, also set the
14526 virtual and newslot bits.
14528 * class.cs (TypeContainer::RegisterRequiredImplementations):
14529 Record methods we need.
14531 (TypeContainer::MakeKey): Helper function to make keys for
14532 MethodBases, since the Methodbase key is useless.
14534 (TypeContainer::Populate): Call RegisterRequiredImplementations
14535 before defining the methods.
14537 Create a mapping for method_builders_to_methods ahead of time
14538 instead of inside a tight loop.
14540 (::RequireMethods): Accept an object as the data to set into the
14541 hashtable so we can report interface vs abstract method mismatch.
14543 2001-10-03 Miguel de Icaza <miguel@ximian.com>
14545 * report.cs: Make all of it static.
14547 * rootcontext.cs: Drop object_type and value_type computations, as
14548 we have those in the TypeManager anyways.
14550 Drop report instance variable too, now it is a global.
14552 * driver.cs: Use try/catch on command line handling.
14554 Add --probe option to debug the error reporting system with a test
14557 * report.cs: Add support for exiting program when a probe
14558 condition is reached.
14560 2001-10-03 Ravi Pratap <ravi@ximian.com>
14562 * expression.cs (Binary::DoNumericPromotions): Fix the case when
14563 we do a forcible conversion regardless of type, to check if
14564 ForceConversion returns a null.
14566 (Binary::error19): Use location to report error.
14568 (Unary::error23): Use location here too.
14570 * ../errors/cs0019.cs : Check in.
14572 * ../errors/cs0023.cs : Check in.
14574 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
14575 case of a non-null MethodInfo object with a length of 0 !
14577 (Binary::ResolveOperator): Flag error if overload resolution fails to find
14578 an applicable member - according to the spec :-)
14579 Also fix logic to find members in base types.
14581 (Unary::ResolveOperator): Same here.
14583 (Unary::report23): Change name to error23 and make first argument a TypeContainer
14584 as I was getting thoroughly confused between this and error19 :-)
14586 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
14587 (::FindMostEncompassedType): Implement.
14588 (::FindMostEncompassingType): Implement.
14589 (::StandardConversionExists): Implement.
14591 (UserImplicitCast): Re-vamp. We now need info about most specific
14592 source and target types so that we can do the necessary conversions.
14594 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
14595 mathematical union with no duplicates.
14597 2001-10-03 Miguel de Icaza <miguel@ximian.com>
14599 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
14600 in order from base classes to child classes, so that we can in
14601 child classes look up in our parent for method names and
14602 attributes (required for handling abstract, virtual, new, override
14603 constructs: we need to instrospect our base class, and if we dont
14604 populate the classes in order, the introspection might be
14605 incorrect. For example, a method could query its parent before
14606 the parent has any methods and would determine that the parent has
14607 no abstract methods (while it could have had them)).
14609 (RootContext::CreateType): Record the order in which we define the
14612 2001-10-02 Miguel de Icaza <miguel@ximian.com>
14614 * class.cs (TypeContainer::Populate): Also method definitions can
14615 fail now, keep track of this.
14617 (TypeContainer::FindMembers): Implement support for
14618 DeclaredOnly/noDeclaredOnly flag.
14620 (Constructor::Emit) Return the ConstructorBuilder.
14622 (Method::Emit) Return the MethodBuilder.
14623 Check for abstract or virtual methods to be public.
14625 * rootcontext.cs (RootContext::CreateType): Register all the
14626 abstract methods required for the class to be complete and the
14627 interface methods that must be implemented.
14629 * cs-parser.jay: Report error 501 (method requires body if it is
14630 not marked abstract or extern).
14632 * expression.cs (TypeOf::Emit): Implement.
14634 * typemanager.cs: runtime_handle_type, new global type.
14636 * class.cs (Property::Emit): Generate code for properties.
14638 2001-10-02 Ravi Pratap <ravi@ximian.com>
14640 * expression.cs (Unary::ResolveOperator): Find operators on base type
14641 too - we now conform exactly to the spec.
14643 (Binary::ResolveOperator): Same here.
14645 * class.cs (Operator::Define): Fix minor quirk in the tests.
14647 * ../errors/cs0215.cs : Added.
14649 * ../errors/cs0556.cs : Added.
14651 * ../errors/cs0555.cs : Added.
14653 2001-10-01 Miguel de Icaza <miguel@ximian.com>
14655 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
14656 single integer which is really efficient
14658 2001-10-01 Ravi Pratap <ravi@ximian.com>
14660 * expression.cs (Expression::ImplicitUserConversion): Use location
14661 even in the case when we are examining True operators.
14663 * class.cs (Operator::Define): Perform extensive checks to conform
14664 with the rules for operator overloading in the spec.
14666 * expression.cs (Expression::ImplicitReferenceConversion): Implement
14667 some of the other conversions mentioned in the spec.
14669 * typemanager.cs (array_type): New static member for the System.Array built-in
14672 (cloneable_interface): For System.ICloneable interface.
14674 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
14675 we start resolving the tree and populating types.
14677 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
14679 2001-10-01 Miguel de Icaza <miguel@ximian.com>
14681 * expression.cs (Expression::ExprClassFromMemberInfo,
14682 Expression::Literalize): Create literal expressions from
14683 FieldInfos which are literals.
14685 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
14686 type casts, because they were wrong. The test suite in tests
14689 (ImplicitNumericConversion): ushort to ulong requires a widening
14692 Int32 constant to long requires widening cast as well.
14694 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
14695 for integers because the type on the stack is not i4.
14697 2001-09-30 Miguel de Icaza <miguel@ximian.com>
14699 * expression.cs (report118): require location argument.
14701 * parameter.cs: Do not dereference potential null value.
14703 * class.cs: Catch methods that lack the `new' keyword when
14704 overriding a name. Report warnings when `new' is used without
14705 anything being there to override.
14707 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
14709 * class.cs: Only add constructor to hashtable if it is non-null
14710 (as now constructors can fail on define).
14712 (TypeManager, Class, Struct): Take location arguments.
14714 Catch field instance initialization in structs as errors.
14716 accepting_filter: a new filter for FindMembers that is static so
14717 that we dont create an instance per invocation.
14719 (Constructor::Define): Catch errors where a struct constructor is
14722 * cs-parser.jay: Pass location information for various new
14725 * delegate.cs (Delegate): take a location argument.
14727 * driver.cs: Do not call EmitCode if there were problesm in the
14728 Definition of the types, as many Builders wont be there.
14730 * decl.cs (Decl::Decl): Require a location argument.
14732 * cs-tokenizer.cs: Handle properly hex constants that can not fit
14733 into integers, and find the most appropiate integer for it.
14735 * literal.cs: Implement ULongLiteral.
14737 * rootcontext.cs: Provide better information about the location of
14738 failure when CreateType fails.
14740 2001-09-29 Miguel de Icaza <miguel@ximian.com>
14742 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
14745 * expression.cs (Binary::CheckShiftArguments): Add missing type
14747 (Binary::ResolveOperator): Add type to the logical and and logical
14748 or, Bitwise And/Or and Exclusive Or code paths, it was missing
14751 (Binary::DoNumericPromotions): In the case where either argument
14752 is ulong (and most signed types combined with ulong cause an
14753 error) perform implicit integer constant conversions as well.
14755 2001-09-28 Miguel de Icaza <miguel@ximian.com>
14757 * expression.cs (UserImplicitCast): Method should always be
14759 (Invocation::BetterConversion): Simplified test for IntLiteral.
14761 (Expression::ImplicitNumericConversion): Split this routine out.
14762 Put the code that performs implicit constant integer conversions
14765 (Expression::Resolve): Become a wrapper around DoResolve so we can
14766 check eclass and type being set after resolve.
14768 (Invocation::Badness): Remove this dead function
14770 (Binary::ResolveOperator): Do not compute the expensive argumnets
14771 unless we have a union for it.
14773 (Probe::Emit): Is needs to do an isinst and then
14774 compare against null.
14776 (::CanConvert): Added Location argument. If the Location argument
14777 is null (Location.Null), then we do not report errors. This is
14778 used by the `probe' mechanism of the Explicit conversion. We do
14779 not want to generate an error for something that the user
14780 explicitly requested to be casted. But the pipeline for an
14781 explicit cast first tests for potential implicit casts.
14783 So for now, if the Location is null, it means `Probe only' to
14784 avoid adding another argument. Might have to revise this
14787 (ClassCast): New class used to type cast objects into arbitrary
14788 classes (used in Explicit Reference Conversions).
14790 Implement `as' as well.
14792 Reverted all the patches from Ravi below: they were broken:
14794 * The use of `level' as a mechanism to stop recursive
14795 invocations is wrong. That was there just to catch the
14796 bug with a strack trace but not as a way of addressing
14799 To fix the problem we have to *understand* what is going
14800 on and the interactions and come up with a plan, not
14801 just get things going.
14803 * The use of the type conversion cache that I proposed
14804 last night had an open topic: How does this work across
14805 protection domains. A user defined conversion might not
14806 be public in the location where we are applying the
14807 conversion, a different conversion might be selected
14808 (ie, private A->B (better) but public B->A (worse),
14809 inside A, A->B applies, but outside it, B->A will
14812 * On top of that (ie, even if the above is solved),
14813 conversions in a cache need to be abstract. Ie, `To
14814 convert from an Int to a Short use an OpcodeCast', not
14815 `To convert from an Int to a Short use the OpcodeCast on
14816 the variable 5' (which is what this patch was doing).
14818 2001-09-28 Ravi Pratap <ravi@ximian.com>
14820 * expression.cs (Invocation::ConversionExists): Re-write to use
14821 the conversion cache
14823 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
14824 cache all conversions done, not just user-defined ones.
14826 (Invocation::BetterConversion): The real culprit. Use ConversionExists
14827 to determine if a conversion exists instead of acutually trying to
14828 perform the conversion. It's faster too.
14830 (Expression::ConvertExplicit): Modify to use ConversionExists to check
14831 and only then attempt the implicit conversion.
14833 2001-09-28 Ravi Pratap <ravi@ximian.com>
14835 * expression.cs (ConvertImplicit): Use a cache for conversions
14836 already found. Check level of recursion and bail out if necessary.
14838 2001-09-28 Miguel de Icaza <miguel@ximian.com>
14840 * typemanager.cs (string_concat_string_string, string_concat_object_object):
14841 Export standard methods that we expect for string operations.
14843 * statement.cs (Block::UsageWarning): Track usage of variables and
14844 report the errors for not used variables.
14846 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
14849 2001-09-27 Miguel de Icaza <miguel@ximian.com>
14851 * codegen.cs: remove unnneded code
14853 * expression.cs: Removed BuiltinTypeAccess class
14855 Fix the order in which implicit conversions are
14858 The previous fixed dropped support for boxed conversions (adding a
14859 test to the test suite now)
14861 (UserImplicitCast::CanConvert): Remove test for source being null,
14862 that code is broken. We should not feed a null to begin with, if
14863 we do, then we should track the bug where the problem originates
14864 and not try to cover it up here.
14866 Return a resolved expression of type UserImplicitCast on success
14867 rather than true/false. Ravi: this is what I was talking about,
14868 the pattern is to use a static method as a "constructor" for
14871 Also, do not create arguments until the very last minute,
14872 otherwise we always create the arguments even for lookups that
14873 will never be performed.
14875 (UserImplicitCast::Resolve): Eliminate, objects of type
14876 UserImplicitCast are born in a fully resolved state.
14878 * typemanager.cs (InitCoreTypes): Init also value_type
14879 (System.ValueType).
14881 * expression.cs (Cast::Resolve): First resolve the child expression.
14883 (LValue): Add new method AddressOf to be used by
14886 Change the argument of Store to take an EmitContext instead of an
14887 ILGenerator, because things like FieldExpr need to be able to call
14888 their children expression to generate the instance code.
14890 (Expression::Error, Expression::Warning): Sugar functions for
14893 (Expression::MemberLookup): Accept a TypeContainer instead of a
14894 Report as the first argument.
14896 (Expression::ResolvePrimary): Killed. I still want to improve
14897 this as currently the code is just not right.
14899 (Expression::ResolveMemberAccess): Simplify, but it is still
14902 (Unary::Resolve): Catch errors in AddressOf operators.
14904 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
14905 index to a byte for the short-version, or the compiler will choose
14906 the wrong Emit call, which generates the wrong data.
14908 (ParameterReference::Emit, ::Store): same.
14910 (FieldExpr::AddressOf): Implement.
14912 * typemanager.cs: TypeManager: made public variable instead of
14915 * driver.cs: document --fatal.
14917 * report.cs (ErrorMessage, WarningMessage): new names for the old
14918 Error and Warning classes.
14920 * cs-parser.jay (member_access): Turn built-in access to types
14921 into a normal simplename
14923 2001-09-27 Ravi Pratap <ravi@ximian.com>
14925 * expression.cs (Invocation::BetterConversion): Fix to cope
14926 with q being null, since this was introducing a bug.
14928 * expression.cs (ConvertImplicit): Do built-in conversions first.
14930 2001-09-27 Ravi Pratap <ravi@ximian.com>
14932 * expression.cs (UserImplicitCast::Resolve): Fix bug.
14934 2001-09-27 Ravi Pratap <ravi@ximian.com>
14936 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
14937 I had introduced long ago (what's new ?).
14939 * expression.cs (UserImplicitCast::CanConvert): Static method to do
14940 the work of all the checking.
14941 (ConvertImplicit): Call CanConvert and only then create object if necessary.
14942 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
14944 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
14945 that is the right way.
14947 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
14948 overloading resolution. Use everywhere instead of cutting and pasting code.
14950 (Binary::ResolveOperator): Use MakeUnionSet.
14952 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
14953 we have to convert to bool types. Not complete yet.
14955 2001-09-27 Miguel de Icaza <miguel@ximian.com>
14957 * typemanager.cs (TypeManager::CSharpName): support ushort.
14959 * expression.cs (Expression::TryImplicitIntConversion): Attempts
14960 to provide an expression that performsn an implicit constant int
14961 conversion (section 6.1.6).
14962 (Expression::ConvertImplicitRequired): Reworked to include
14963 implicit constant expression conversions.
14965 (Expression::ConvertNumericExplicit): Finished.
14967 (Invocation::Emit): If InstanceExpression is null, then it means
14968 that we perform a call on this.
14970 2001-09-26 Miguel de Icaza <miguel@ximian.com>
14972 * expression.cs (Unary::Emit): Remove some dead code.
14973 (Probe): Implement Resolve and Emit for `is'.
14974 (Expression::ConvertImplicitRequired): Attempt to do constant
14975 expression conversions here. Maybe should be moved to
14976 ConvertImplicit, but I am not sure.
14977 (Expression::ImplicitLongConstantConversionPossible,
14978 Expression::ImplicitIntConstantConversionPossible): New functions
14979 that tell whether is it possible to apply an implicit constant
14980 expression conversion.
14982 (ConvertNumericExplicit): Started work on explicit numeric
14985 * cs-parser.jay: Update operator constants.
14987 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
14988 (Parameters::GetSignature): Hook up VerifyArgs here.
14989 (Parameters::VerifyArgs): Verifies that no two arguments have the
14992 * class.cs (Operator): Update the operator names to reflect the
14993 ones that the spec expects (as we are just stringizing the
14996 * expression.cs (Unary::ResolveOperator): Fix bug: Use
14997 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
14998 previous usage did only work for our methods.
14999 (Expression::ConvertImplicit): Handle decimal implicit numeric
15000 conversions as well.
15001 (Expression::InternalTypeConstructor): Used to invoke constructors
15002 on internal types for default promotions.
15004 (Unary::Emit): Implement special handling for the pre/post
15005 increment/decrement for overloaded operators, as they need to have
15006 the same semantics as the other operators.
15008 (Binary::ResolveOperator): ditto.
15009 (Invocation::ConversionExists): ditto.
15010 (UserImplicitCast::Resolve): ditto.
15012 2001-09-26 Ravi Pratap <ravi@ximian.com>
15014 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
15015 operator, return after emitting body. Regression tests pass again !
15017 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
15018 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
15019 (Invocation::OverloadResolve): Ditto.
15020 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
15022 * everywhere : update calls to the above methods accordingly.
15024 2001-09-26 Miguel de Icaza <miguel@ximian.com>
15026 * assign.cs (Assign): Make it inherit from ExpressionStatement.
15028 * expression.cs (ExpressionStatement): New base class used for
15029 expressions that can appear in statements, so that we can provide
15030 an alternate path to generate expression that do not leave a value
15033 (Expression::Emit, and all the derivatives): We no longer return
15034 whether a value is left on the stack or not. Every expression
15035 after being emitted leaves a single value on the stack.
15037 * codegen.cs (EmitContext::EmitStatementExpression): Use the
15038 facilties of ExpressionStatement if possible.
15040 * cs-parser.jay: Update statement_expression.
15042 2001-09-25 Miguel de Icaza <miguel@ximian.com>
15044 * driver.cs: Change the wording of message
15046 2001-09-25 Ravi Pratap <ravi@ximian.com>
15048 * expression.cs (Binary::ResolveOperator): Had forgottten to set
15049 the type of the expression to the return type of the method if
15050 we have an overloaded operator match ! The regression tests pass again !
15051 (Unary::ResolveOperator): Ditto.
15053 * expression.cs (Invocation::ConversionExists): Correct the member lookup
15054 to find "op_Implicit", not "implicit" ;-)
15055 (UserImplicitCast): New class to take care of user-defined implicit conversions.
15056 (ConvertImplicit, ForceConversion): Take TypeContainer argument
15058 * everywhere : Correct calls to the above accordingly.
15060 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
15061 (ConvertImplicit): Do user-defined conversion if it exists.
15063 2001-09-24 Miguel de Icaza <miguel@ximian.com>
15065 * assign.cs: track location.
15066 (Resolve): Use implicit conversions on assignment.
15068 * literal.cs: Oops. Not good, Emit of short access values should
15069 pass (Bytes) or the wrong argument will be selected.
15071 * expression.cs (Unary::Emit): Emit code for -expr.
15073 (Unary::ResolveOperator): Handle `Substract' for non-constants
15074 (substract from zero from the non-constants).
15075 Deal with Doubles as well.
15077 (Expression::ConvertImplicitRequired): New routine that reports an
15078 error if no implicit conversion exists.
15080 (Invocation::OverloadResolve): Store the converted implicit
15081 expressions if we make them
15083 2001-09-24 Ravi Pratap <ravi@ximian.com>
15085 * class.cs (ConstructorInitializer): Take a Location argument.
15086 (ConstructorBaseInitializer): Same here.
15087 (ConstructorThisInitializer): Same here.
15089 * cs-parser.jay : Update all calls accordingly.
15091 * expression.cs (Unary, Binary, New): Take location argument.
15092 Update accordingly everywhere.
15094 * cs-parser.jay : Update all calls to the above to take a location
15097 * class.cs : Ditto.
15099 2001-09-24 Ravi Pratap <ravi@ximian.com>
15101 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
15102 (Invocation::BetterConversion): Same here
15103 (Invocation::ConversionExists): Ditto.
15105 (Invocation::ConversionExists): Implement.
15107 2001-09-22 Ravi Pratap <ravi@ximian.com>
15109 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
15110 Also take an additional TypeContainer argument.
15112 * All over : Pass in TypeContainer as argument to OverloadResolve.
15114 * typemanager.cs (CSharpName): Update to check for the string type and return
15117 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
15120 2001-09-21 Ravi Pratap <ravi@ximian.com>
15122 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
15123 (Invocation::BetterFunction): Implement.
15124 (Invocation::BetterConversion): Implement.
15125 (Invocation::ConversionExists): Skeleton, no implementation yet.
15127 Okay, things work fine !
15129 2001-09-21 Miguel de Icaza <miguel@ximian.com>
15131 * typemanager.cs: declare and load enum_type, delegate_type and
15134 * expression.cs (Expression::Emit): Now emit returns a value that
15135 tells whether a value is left on the stack or not. This strategy
15136 might be reveted tomorrow with a mechanism that would address
15137 multiple assignments.
15138 (Expression::report118): Utility routine to report mismatches on
15141 (Unary::Report23): Report impossible type/operator combination
15144 (Unary::IsIncrementableNumber): Whether the type can be
15145 incremented or decremented with add.
15146 (Unary::ResolveOperator): Also allow enumerations to be bitwise
15148 (Unary::ResolveOperator): Implement ++, !, ~,
15150 (Invocation::Emit): Deal with new Emit convetion.
15152 * All Expression derivatives: Updated their Emit method to return
15153 whether they leave values on the stack or not.
15155 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
15156 stack for expressions that are statements.
15158 2001-09-20 Miguel de Icaza <miguel@ximian.com>
15160 * expression.cs (LValue): New interface. Must be implemented by
15162 (LocalVariableReference, ParameterReference, FieldExpr): Implement
15165 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
15166 interface for generating code, simplifies the code.
15168 2001-09-20 Ravi Pratap <ravi@ximian.com>
15170 * expression.cs (everywhere): Comment out return statements in ::Resolve
15171 methods to avoid the warnings.
15173 2001-09-20 Miguel de Icaza <miguel@ximian.com>
15175 * driver.cs (parse): Report error 2001 if we can not open the
15178 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
15181 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
15184 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
15185 otherwise nested blocks end up with the same index.
15187 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
15189 * expression.cs: Instead of having FIXMEs in the Resolve
15190 functions, throw exceptions so it is obvious that we are facing a
15193 * cs-parser.jay (invocation_expression): Pass Location information.
15195 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
15196 Use a basename for those routines because .NET does not like paths
15199 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
15202 2001-09-19 Miguel de Icaza <miguel@ximian.com>
15204 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
15205 are loading the correct data types (throws an exception if not).
15206 (TypeManager::InitCoreTypes): Use CoreLookupType
15208 * expression.cs (Unary::ResolveOperator): return the child
15209 expression for expressions which are just +expr.
15210 (Unary::ResolveOperator): Return negative literals for -LITERAL
15211 expressions (otherwise they are Unary {Literal}).
15212 (Invocation::Badness): Take into account `Implicit constant
15213 expression conversions'.
15215 * literal.cs (LongLiteral): Implement long literal class.
15216 (IntLiteral): export the `Value' of the intliteral.
15218 2001-09-19 Ravi Pratap <ravi@ximian.com>
15220 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
15222 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
15223 instead of 'Operator'
15225 * expression.cs (Binary::ResolveOperator): Update accordingly.
15226 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
15229 * cs-parser.jay (unary_expression): Update to use the new names.
15231 * gen-treedump.cs (GetUnary): Same here.
15233 * expression.cs (Unary::Resolve): Implement.
15234 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
15235 operators are found instead of making noise ;-)
15236 (Unary::ResolveOperator): New method to do precisely the same thing which
15237 Binary::ResolveOperator does for Binary expressions.
15238 (Unary.method, .Arguments): Add.
15239 (Unary::OperName): Implement.
15240 (Unary::ForceConversion): Copy and Paste !
15242 * class.cs (Operator::Define): Fix a small bug for the case when we have
15245 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
15246 for the inbuilt operators. Only overloading works for now ;-)
15248 2001-09-18 Miguel de Icaza <miguel@ximian.com>
15250 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
15251 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
15253 * expression.cs (This::Emit): Implement.
15254 (This::Resolve): Implement.
15255 (TypeOf:Resolve): Implement.
15256 (Expression::ResolveSimpleName): Add an implicit this to instance
15258 (MemberAccess::Resolve): Deal with Parameters and Fields.
15259 Bind instance variable to Field expressions.
15260 (FieldExpr::Instance): New field used to track the expression that
15261 represents the object instance.
15262 (FieldExpr::Resolve): Track potential errors from MemberLookup not
15264 (FieldExpr::Emit): Implement.
15266 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
15267 the last instruction contains a return opcode to avoid generating
15268 the last `ret' instruction (this generates correct code, and it is
15269 nice to pass the peverify output).
15271 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
15272 initializer for static and instance variables.
15273 (Constructor::Emit): Allow initializer to be null in the case of
15274 static constructors. Only emit initializer for instance
15277 (TypeContainer::FindMembers): Return a null array if there are no
15280 Also fix the code for the MemberTypes.Method branch, as it was not
15281 scanning that for operators (or tried to access null variables before).
15283 * assign.cs (Assign::Emit): Handle instance and static fields.
15287 * driver.cs: Stop compilation if there are parse errors.
15289 * cs-parser.jay (constructor_declaration): Provide default base
15290 initializer for non-static constructors.
15291 (constructor_declarator): Do not provide a default base
15292 initializers if none was specified.
15293 Catch the fact that constructors should not have parameters.
15295 * class.cs: Do not emit parent class initializers for static
15296 constructors, that should be flagged as an error.
15298 2001-09-18 Ravi Pratap <ravi@ximian.com>
15300 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
15301 Move back code into TypeContainer::Populate.
15303 2001-09-18 Ravi Pratap <ravi@ximian.com>
15305 * class.cs (TypeContainer::AddConstructor): Fix the check to
15306 compare against Name, not Basename.
15307 (Operator::OpType): Change Plus and Minus to Add and Subtract.
15309 * cs-parser.jay : Update accordingly.
15311 * class.cs (TypeContainer::FindMembers): For the case where we are searching
15312 for methods, don't forget to look into the operators too.
15313 (RegisterMethodBuilder): Helper method to take care of this for
15314 methods, constructors and operators.
15315 (Operator::Define): Completely revamp.
15316 (Operator.OperatorMethod, MethodName): New fields.
15317 (TypeContainer::Populate): Move the registering of builders into
15318 RegisterMethodBuilder.
15319 (Operator::Emit): Re-write.
15321 * expression.cs (Binary::Emit): Comment out code path to emit method
15322 invocation stuff for the case when we have a user defined operator. I am
15323 just not able to get it right !
15325 2001-09-17 Miguel de Icaza <miguel@ximian.com>
15327 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
15330 (Expression::MemberLookup): Provide a version that allows to
15331 specify the MemberTypes and BindingFlags.
15333 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
15334 so it was not fetching variable information from outer blocks.
15336 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
15337 Beforefieldinit as it was buggy.
15339 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
15340 that Ravi put here.
15342 * class.cs (Constructor::Emit): Only emit if block is not null.
15343 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
15344 deal with this by semantically definining it as if the user had
15347 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
15348 constructors as we now "emit" them at a higher level.
15350 (TypeContainer::DefineDefaultConstructor): Used to define the
15351 default constructors if none was provided.
15353 (ConstructorInitializer): Add methods Resolve and Emit.
15355 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
15357 2001-09-17 Ravi Pratap <ravi@ximian.com>
15359 * class.cs (TypeContainer::EmitDefaultConstructor): Register
15360 the default constructor builder with our hashtable for methodbuilders
15363 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
15364 and argument_count is 0 in which case we have a match.
15365 (Binary::ResolveOperator): More null checking and miscellaneous coding
15368 2001-09-17 Ravi Pratap <ravi@ximian.com>
15370 * rootcontext.cs (IsNameSpace): Compare against null.
15372 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
15374 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
15375 and Unary::Operator.
15377 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
15380 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
15381 we have overloaded operators.
15382 (Binary::ResolveOperator): Implement the part which does the operator overload
15385 * class.cs (Operator::Emit): Implement.
15386 (TypeContainer::Emit): Emit the operators we have too.
15388 * expression.cs (Binary::Emit): Update to emit the appropriate code for
15389 the case when we have a user-defined operator.
15391 2001-09-17 Miguel de Icaza <miguel@ximian.com>
15393 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
15395 2001-09-16 Ravi Pratap <ravi@ximian.com>
15397 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
15398 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
15399 (Constructor::Emit): Implement.
15400 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
15401 if we have no work to do.
15402 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
15405 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
15406 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
15408 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
15411 2001-09-15 Ravi Pratap <ravi@ximian.com>
15413 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
15415 (Tree::RecordNamespace): Method to do what the name says ;-)
15416 (Tree::Namespaces): Property to get at the namespaces hashtable.
15418 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
15421 * rootcontext.cs (IsNamespace): Fixed it :-)
15423 2001-09-14 Miguel de Icaza <miguel@ximian.com>
15425 * class.cs (TypeContainer::FindMembers): Add support for
15427 (MethodCore): New class that encapsulates both the shared aspects
15428 of a Constructor and a Method.
15429 (Method, Constructor): Factored pieces into MethodCore.
15431 * driver.cs: Added --fatal which makes errors throw exceptions.
15432 Load System assembly as well as part of the standard library.
15434 * report.cs: Allow throwing exceptions on errors for debugging.
15436 * modifiers.cs: Do not use `parent', instead use the real type
15437 container to evaluate permission settings.
15439 * class.cs: Put Ravi's patch back in. He is right, and we will
15440 have to cope with the
15442 2001-09-14 Ravi Pratap <ravi@ximian.com>
15444 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
15445 FamORAssem, not FamANDAssem.
15447 2001-09-14 Miguel de Icaza <miguel@ximian.com>
15449 * driver.cs: Added --parse option that only parses its input files
15452 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
15453 incorrect. IsTopLevel is not used to tell whether an object is
15454 root_types or not (that can be achieved by testing this ==
15455 root_types). But to see if this is a top-level *class* (not
15456 necessarly our "toplevel" container).
15458 2001-09-14 Ravi Pratap <ravi@ximian.com>
15460 * enum.cs (Enum::Define): Modify to call the Lookup method on the
15461 parent instead of a direct call to GetType.
15463 2001-09-14 Ravi Pratap <ravi@ximian.com>
15465 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
15466 Modifiers.TypeAttr. This should just be a call to that method.
15468 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
15469 object so that we can determine if we are top-level or not.
15471 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
15474 * enum.cs (Enum::Define): Ditto.
15476 * modifiers.cs (FieldAttr): Re-write.
15478 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
15479 (TypeContainer::HaveStaticConstructor): New property to provide access
15480 to precisely that info.
15482 * modifiers.cs (MethodAttr): Re-write.
15483 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
15485 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
15486 of top-level types as claimed.
15488 2001-09-13 Miguel de Icaza <miguel@ximian.com>
15490 * expression.cs (MemberLookup): Fruitless attempt to lookup
15491 constructors. Maybe I need to emit default constructors? That
15492 might be it (currently .NET emits this for me automatically).
15493 (Invocation::OverloadResolve): Cope with Arguments == null.
15494 (Invocation::EmitArguments): new function, shared by the new
15495 constructor and us.
15496 (Invocation::Emit): Handle static and instance methods. Emit
15497 proper call instruction for virtual or non-virtual invocations.
15498 (New::Emit): Implement.
15499 (New::Resolve): Implement.
15500 (MemberAccess:Resolve): Implement.
15501 (MethodGroupExpr::InstanceExpression): used conforming to the spec
15502 to track instances.
15503 (FieldExpr::Resolve): Set type.
15505 * support.cs: Handle empty arguments.
15507 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
15508 SimpleLookup): Auxiliary routines to help parse a qualifier
15511 Update qualifier_identifier rule.
15513 * codegen.cs: Removed debugging messages.
15515 * class.cs: Make this a global thing, this acts just as a "key" to
15516 objects that we might have around.
15518 (Populate): Only initialize method_builders_to_methods once.
15520 * expression.cs (PropertyExpr): Initialize type from the
15523 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
15524 Resolve pattern. Attempt to implicitly convert value to boolean.
15527 * expression.cs: Set the type for the int32/int32 argument case.
15528 (Binary::ResolveOperator): Set the return type to boolean for
15529 comparission operators
15531 * typemanager.cs: Remove debugging print code.
15533 (Invocation::Resolve): resolve type.
15535 * class.cs: Allocate a MemberInfo of the correct size, as the code
15536 elsewhere depends on the test to reflect the correct contents.
15538 (Method::) Keep track of parameters, due to System.Reflection holes
15540 (TypeContainer::Populate): Keep track of MethodBuilders to Method
15543 (TypeContainer::FindMembers): Use ArrayList and then copy an array
15544 of the exact size and return that.
15546 (Class::LookupMethodByBuilder): New function that maps
15547 MethodBuilders to its methods. Required to locate the information
15548 on methods because System.Reflection bit us again.
15550 * support.cs: New file, contains an interface ParameterData and
15551 two implementations: ReflectionParameters and InternalParameters
15552 used to access Parameter information. We will need to grow this
15555 * expression.cs (Invocation::GetParameterData): implement a cache
15556 and a wrapper around the ParameterData creation for methods.
15557 (Invocation::OverloadResolve): Use new code.
15559 2001-09-13 Ravi Pratap <ravi@ximian.com>
15561 * class.cs (TypeContainer::EmitField): Remove and move into
15562 (Field::Define): here and modify accordingly.
15563 (Field.FieldBuilder): New member.
15564 (TypeContainer::Populate): Update accordingly.
15565 (TypeContainer::FindMembers): Implement.
15567 2001-09-13 Miguel de Icaza <miguel@ximian.com>
15569 * statement.cs: (VariableInfo::VariableType): New field to be
15570 initialized with the full type once it is resolved.
15572 2001-09-12 Miguel de Icaza <miguel@ximian.com>
15574 * parameter.cs (GetParameterInfo): Use a type cache to compute
15575 things only once, and to reuse this information
15577 * expression.cs (LocalVariableReference::Emit): Implement.
15578 (OpcodeCast::Emit): fix.
15580 (ParameterReference::Resolve): Implement.
15581 (ParameterReference::Emit): Implement.
15583 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
15584 that are expressions need to stay as Expressions.
15586 * typemanager.cs (CSharpName): Returns the C# name of a type if
15589 * expression.cs (Expression::ConvertImplicit): New function that
15590 implements implicit type conversions.
15592 (Expression::ImplicitReferenceConversion): Implements implicit
15593 reference conversions.
15595 (EmptyCast): New type for transparent casts.
15597 (OpcodeCast): New type for casts of types that are performed with
15598 a sequence of bytecodes.
15600 (BoxedCast): New type used for casting value types into reference
15601 types. Emits a box opcode.
15603 (Binary::DoNumericPromotions): Implements numeric promotions of
15604 and computation of the Binary::Type.
15606 (Binary::EmitBranchable): Optimization.
15608 (Binary::Emit): Implement code emission for expressions.
15610 * typemanager.cs (TypeManager): Added two new core types: sbyte
15613 2001-09-12 Ravi Pratap <ravi@ximian.com>
15615 * class.cs (TypeContainer::FindMembers): Method which does exactly
15616 what Type.FindMembers does, only we don't have to use reflection. No
15617 implementation yet.
15619 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
15620 typecontainer objects as we need to get at them.
15621 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
15623 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
15624 typecontainer object.
15626 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
15627 of just a Report object.
15629 2001-09-11 Ravi Pratap <ravi@ximian.com>
15631 * class.cs (Event::Define): Go back to using the prefixes "add_" and
15633 (TypeContainer::Populate): Now define the delegates of the type too.
15634 (TypeContainer.Delegates): Property to access the list of delegates defined
15637 * delegates.cs (Delegate::Define): Implement partially.
15639 * modifiers.cs (TypeAttr): Handle more flags.
15641 2001-09-11 Ravi Pratap <ravi@ximian.com>
15643 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
15645 (Operator::Define): Re-write logic to get types by using the LookupType method
15646 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
15647 (Indexer::Define): Ditto.
15648 (Event::Define): Ditto.
15649 (Property::Define): Ditto.
15651 2001-09-10 Ravi Pratap <ravi@ximian.com>
15653 * class.cs (TypeContainer::Populate): Now define operators too.
15654 (TypeContainer.Operators): New property to access the list of operators
15656 (Operator.OperatorMethodBuilder): New member to hold the method builder
15657 for the operator we are defining.
15658 (Operator::Define): Implement.
15660 2001-09-10 Ravi Pratap <ravi@ximian.com>
15662 * class.cs (Event::Define): Make the prefixes of the accessor methods
15663 addOn_ and removeOn_
15665 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
15666 of the location being passed in too. Ideally, this should go later since all
15667 error reporting should be done through the Report object.
15669 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
15670 (Populate): Iterate thru the indexers we have and define them too.
15671 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
15672 for the get and set accessors.
15673 (Indexer::Define): Implement.
15675 2001-09-09 Miguel de Icaza <miguel@ximian.com>
15677 * expression.cs (Binary::Resolve): Beginning of it. I scratched
15678 my previous implementation, did not work.
15680 * typemanager.cs: Add a couple of missing types (the longs).
15682 * literal.cs: Use TypeManager.bool_type instead of getting it.
15684 * expression.cs (EventExpr): New kind of expressions.
15685 (Expressio::ExprClassFromMemberInfo): finish
15687 2001-09-08 Miguel de Icaza <miguel@ximian.com>
15689 * assign.cs: Emit stores to static fields differently.
15691 2001-09-08 Ravi Pratap <ravi@ximian.com>
15693 * Merge in changes and adjust code to tackle conflicts. Backed out my
15694 code in Assign::Resolve ;-)
15696 2001-09-08 Ravi Pratap <ravi@ximian.com>
15698 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
15699 instead Report.Error and also pass in the location.
15700 (CSharpParser::Lexer): New readonly property to return the reference
15701 to the Tokenizer object.
15702 (declare_local_variables): Use Report.Error with location instead of plain
15706 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
15707 (Operator.CheckBinaryOperator): Ditto.
15709 * cs-parser.jay (operator_declarator): Update accordingly.
15711 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
15712 (CheckBinaryOperator): Same here.
15714 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
15715 on the name without any prefixes of namespace names etc. This is because we
15716 already might have something already fully qualified like
15717 'System.Console.WriteLine'
15719 * assign.cs (Resolve): Begin implementation. Stuck ;-)
15721 2001-09-07 Ravi Pratap <ravi@ximian.com>
15723 * cs-tokenizer.cs (location): Return a string which also contains
15726 * expression.cs (ElementAccess): New class for expressions of the
15727 type 'element access.'
15728 (BaseAccess): New class for expressions of the type 'base access.'
15729 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
15732 * cs-parser.jay (element_access): Implement action.
15733 (base_access): Implement actions.
15734 (checked_expression, unchecked_expression): Implement.
15736 * cs-parser.jay (local_variable_type): Correct and implement.
15737 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
15739 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
15741 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
15742 name and the specifiers.
15744 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
15746 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
15747 making them all public ;-)
15749 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
15752 2001-09-07 Miguel de Icaza <miguel@ximian.com>
15754 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
15756 (FieldExpr, PropertyExprs): New resolved expressions.
15757 (SimpleName::MemberStaticCheck): Perform static checks for access
15758 to non-static fields on static methods. Maybe this should be
15759 generalized for MemberAccesses.
15760 (SimpleName::ResolveSimpleName): More work on simple name
15763 * cs-parser.jay (primary_expression/qualified_identifier): track
15764 the parameter index.
15766 * codegen.cs (CodeGen::Save): Catch save exception, report error.
15767 (EmitContext::EmitBoolExpression): Chain to expression generation
15768 instead of temporary hack.
15769 (::EmitStatementExpression): Put generic expression code generation.
15771 * assign.cs (Assign::Emit): Implement variable assignments to
15772 local variables, parameters and fields.
15774 2001-09-06 Miguel de Icaza <miguel@ximian.com>
15776 * statement.cs (Block::GetVariableInfo): New method, returns the
15777 VariableInfo for a variable name in a block.
15778 (Block::GetVariableType): Implement in terms of GetVariableInfo
15780 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
15781 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
15783 2001-09-06 Ravi Pratap <ravi@ximian.com>
15785 * cs-parser.jay (operator_declaration): Continue on my quest : update
15786 to take attributes argument.
15787 (event_declaration): Ditto.
15788 (enum_declaration): Ditto.
15789 (indexer_declaration): Ditto.
15791 * class.cs (Operator::Operator): Update constructor accordingly.
15792 (Event::Event): Ditto.
15794 * delegate.cs (Delegate::Delegate): Same here.
15796 * enum.cs (Enum::Enum): Same here.
15798 2001-09-05 Ravi Pratap <ravi@ximian.com>
15800 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
15802 * ../tests/cs0658.cs : New file to demonstrate error 0658.
15804 * attribute.cs (Attributes): New class to encapsulate all attributes which were
15805 being passed around as an arraylist.
15806 (Attributes::AddAttribute): Method to add attribute sections.
15808 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
15809 (struct_declaration): Update accordingly.
15810 (constant_declaration): Update.
15811 (field_declaration): Update.
15812 (method_header): Update.
15813 (fixed_parameter): Update.
15814 (parameter_array): Ditto.
15815 (property_declaration): Ditto.
15816 (destructor_declaration): Ditto.
15818 * class.cs (Struct::Struct): Update constructors accordingly.
15819 (Class::Class): Ditto.
15820 (Field::Field): Ditto.
15821 (Method::Method): Ditto.
15822 (Property::Property): Ditto.
15823 (TypeContainer::OptAttribute): update property's return type.
15825 * interface.cs (Interface.opt_attributes): New member.
15826 (Interface::Interface): Update to take the extra Attributes argument.
15828 * parameter.cs (Parameter::Parameter): Ditto.
15830 * constant.cs (Constant::Constant): Ditto.
15832 * interface.cs (InterfaceMemberBase): New OptAttributes field.
15833 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
15834 the attributes as a parameter.
15835 (InterfaceProperty): Update constructor call.
15836 (InterfaceEvent): Ditto.
15837 (InterfaceMethod): Ditto.
15838 (InterfaceIndexer): Ditto.
15840 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
15841 pass the attributes too.
15842 (interface_event_declaration): Ditto.
15843 (interface_property_declaration): Ditto.
15844 (interface_method_declaration): Ditto.
15845 (interface_declaration): Ditto.
15847 2001-09-05 Miguel de Icaza <miguel@ximian.com>
15849 * class.cs (Method::Define): Track the "static Main" definition to
15850 create an entry point.
15852 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
15853 EntryPoint if we find it.
15855 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
15856 (EmitContext::ig): Make this variable public.
15858 * driver.cs: Make the default output file be the first file name
15859 with the .exe extension.
15861 Detect empty compilations
15863 Handle various kinds of output targets. Handle --target and
15864 rename -t to --dumper.
15866 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
15867 methods inherited from Expression return now an Expression. This
15868 will is used during the tree rewriting as we resolve them during
15871 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
15872 the spec. Missing entirely is the information about
15873 accessability of elements of it.
15875 (Expression::ExprClassFromMemberInfo): New constructor for
15876 Expressions that creates a fully initialized Expression based on
15877 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
15880 (Invocation::Resolve): Begin implementing resolution of invocations.
15882 * literal.cs (StringLiteral): Implement Emit.
15884 2001-09-05 Ravi Pratap <ravi@ximian.com>
15886 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
15889 2001-09-04 Ravi Pratap <ravi@ximian.com>
15891 * cs-parser.jay (attribute_arguments): Implement actions.
15892 (attribute): Fix bug in production. Implement action.
15893 (attribute_list): Implement.
15894 (attribute_target): Implement.
15895 (attribute_target_specifier, opt_target_specifier): Implement
15896 (CheckAttributeTarget): New method to check if the attribute target
15898 (attribute_section): Implement.
15899 (opt_attributes): Implement.
15901 * attribute.cs : New file to handle attributes.
15902 (Attribute): Class to hold attribute info.
15904 * cs-parser.jay (opt_attribute_target_specifier): Remove production
15905 (attribute_section): Modify production to use 2 different rules to
15906 achieve the same thing. 1 s/r conflict down !
15907 Clean out commented, useless, non-reducing dimension_separator rules.
15909 * class.cs (TypeContainer.attributes): New member to hold list
15910 of attributes for a type.
15911 (Struct::Struct): Modify to take one more argument, the attribute list.
15912 (Class::Class): Ditto.
15913 (Field::Field): Ditto.
15914 (Method::Method): Ditto.
15915 (Property::Property): Ditto.
15917 * cs-parser.jay (struct_declaration): Update constructor call to
15918 pass in the attributes too.
15919 (class_declaration): Ditto.
15920 (constant_declaration): Ditto.
15921 (field_declaration): Ditto.
15922 (method_header): Ditto.
15923 (fixed_parameter): Ditto.
15924 (parameter_array): Ditto.
15925 (property_declaration): Ditto.
15927 * constant.cs (Constant::Constant): Update constructor similarly.
15928 Use System.Collections.
15930 * parameter.cs (Parameter::Parameter): Update as above.
15932 2001-09-02 Ravi Pratap <ravi@ximian.com>
15934 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
15935 (TypeContainer.delegates): New member to hold list of delegates.
15937 * cs-parser.jay (delegate_declaration): Implement the action correctly
15938 this time as I seem to be on crack ;-)
15940 2001-09-02 Miguel de Icaza <miguel@ximian.com>
15942 * rootcontext.cs (RootContext::IsNamespace): new function, used to
15943 tell whether an identifier represents a namespace.
15945 * expression.cs (NamespaceExpr): A namespace expression, used only
15946 temporarly during expression resolution.
15947 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
15948 utility functions to resolve names on expressions.
15950 2001-09-01 Miguel de Icaza <miguel@ximian.com>
15952 * codegen.cs: Add hook for StatementExpressions.
15954 * class.cs: Fix inverted test for static flag in methods.
15956 2001-09-02 Ravi Pratap <ravi@ximian.com>
15958 * class.cs (Operator::CheckUnaryOperator): Correct error number used
15959 to make it coincide with MS' number.
15960 (Operator::CheckBinaryOperator): Ditto.
15962 * ../errors/errors.txt : Remove error numbers added earlier.
15964 * ../errors/cs1019.cs : Test case for error # 1019
15966 * ../errros/cs1020.cs : Test case for error # 1020
15968 * cs-parser.jay : Clean out commented cruft.
15969 (dimension_separators, dimension_separator): Comment out. Ostensibly not
15970 used anywhere - non-reducing rule.
15971 (namespace_declarations): Non-reducing rule - comment out.
15973 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
15974 with TypeContainer::AddEnum.
15976 * delegate.cs : New file for delegate handling classes.
15977 (Delegate): Class for declaring delegates.
15979 * makefile : Update.
15981 * cs-parser.jay (delegate_declaration): Implement.
15983 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
15985 * class.cs (Event::Define): Implement.
15986 (Event.EventBuilder): New member.
15988 * class.cs (TypeContainer::Populate): Update to define all enums and events
15990 (Events): New property for the events arraylist we hold. Shouldn't we move to using
15991 readonly fields for all these cases ?
15993 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
15995 * class.cs (Property): Revamp to use the convention of making fields readonly.
15996 Accordingly modify code elsewhere.
15998 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
15999 the Define method of the Property class.
16001 * class.cs : Clean up applied patch and update references to variables etc. Fix
16003 (TypeContainer::Populate): Update to define all the properties we have. Also
16004 define all enumerations.
16006 * enum.cs (Define): Implement.
16008 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
16010 * cs-parser.jay (overloadable_operator): The semantic value is an
16011 enum of the Operator class.
16012 (operator_declarator): Implement actions.
16013 (operator_declaration): Implement.
16015 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
16016 validity of definitions.
16017 (Operator::CheckBinaryOperator): Static method to check for binary operators
16018 (TypeContainer::AddOperator): New method to add an operator to a type.
16020 * cs-parser.jay (indexer_declaration): Added line to actually call the
16021 AddIndexer method so it gets added ;-)
16023 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
16024 already taken care of by the MS compiler ?
16026 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
16028 * class.cs (Operator): New class for operator declarations.
16029 (Operator::OpType): Enum for the various operators.
16031 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
16033 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
16034 ostensibly handle this in semantic analysis.
16036 * cs-parser.jay (general_catch_clause): Comment out
16037 (specific_catch_clauses, specific_catch_clause): Ditto.
16038 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
16039 (catch_args, opt_catch_args): New productions.
16040 (catch_clause): Rewrite to use the new productions above
16041 (catch_clauses): Modify accordingly.
16042 (opt_catch_clauses): New production to use in try_statement
16043 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
16044 and re-write the code in the actions to extract the specific and
16045 general catch clauses by being a little smart ;-)
16047 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
16048 Hooray, try and catch statements parse fine !
16050 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
16052 * statement.cs (Block::GetVariableType): Fix logic to extract the type
16053 string from the hashtable of variables.
16055 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
16056 I end up making that mistake ;-)
16057 (catch_clauses): Fixed gross error which made Key and Value of the
16058 DictionaryEntry the same : $1 !!
16060 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
16062 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
16064 * cs-parser.jay (event_declaration): Correct to remove the semicolon
16065 when the add and remove accessors are specified.
16067 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
16069 * cs-parser.jay (IndexerDeclaration): New helper class to hold
16070 information about indexer_declarator.
16071 (indexer_declarator): Implement actions.
16072 (parsing_indexer): New local boolean used to keep track of whether
16073 we are parsing indexers or properties. This is necessary because
16074 implicit_parameters come into picture even for the get accessor in the
16075 case of an indexer.
16076 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
16078 * class.cs (Indexer): New class for indexer declarations.
16079 (TypeContainer::AddIndexer): New method to add an indexer to a type.
16080 (TypeContainer::indexers): New member to hold list of indexers for the
16083 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
16085 * cs-parser.jay (add_accessor_declaration): Implement action.
16086 (remove_accessor_declaration): Implement action.
16087 (event_accessors_declaration): Implement
16088 (variable_declarators): swap statements for first rule - trivial.
16090 * class.cs (Event): New class to hold information about event
16092 (TypeContainer::AddEvent): New method to add an event to a type
16093 (TypeContainer::events): New member to hold list of events.
16095 * cs-parser.jay (event_declaration): Implement actions.
16097 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
16099 * cs-parser.jay (dim_separators): Implement. Make it a string
16100 concatenating all the commas together, just as they appear.
16101 (opt_dim_separators): Modify accordingly
16102 (rank_specifiers): Update accordingly. Basically do the same
16103 thing - instead, collect the brackets here.
16104 (opt_rank_sepcifiers): Modify accordingly.
16105 (array_type): Modify to actually return the complete type string
16106 instead of ignoring the rank_specifiers.
16107 (expression_list): Implement to collect the expressions
16108 (variable_initializer): Implement. We make it a list of expressions
16109 essentially so that we can handle the array_initializer case neatly too.
16110 (variable_initializer_list): Implement.
16111 (array_initializer): Make it a list of variable_initializers
16112 (opt_array_initializer): Modify accordingly.
16114 * expression.cs (New::NType): Add enumeration to help us
16115 keep track of whether we have an object/delegate creation
16116 or an array creation.
16117 (New:NewType, New::Rank, New::Indices, New::Initializers): New
16118 members to hold data about array creation.
16119 (New:New): Modify to update NewType
16120 (New:New): New Overloaded contructor for the array creation
16123 * cs-parser.jay (array_creation_expression): Implement to call
16124 the overloaded New constructor.
16126 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
16128 * class.cs (TypeContainer::Constructors): Return member
16129 constructors instead of returning null.
16131 2001-08-26 Miguel de Icaza <miguel@ximian.com>
16133 * typemanager.cs (InitCoreTypes): Initialize the various core
16134 types after we have populated the type manager with the user
16135 defined types (this distinction will be important later while
16136 compiling corlib.dll)
16138 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
16139 on Expression Classification. Now all expressions have a method
16140 `Resolve' and a method `Emit'.
16142 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
16143 generation from working. Also add some temporary debugging
16146 2001-08-24 Miguel de Icaza <miguel@ximian.com>
16148 * codegen.cs: Lots of code generation pieces. This is only the
16149 beginning, will continue tomorrow with more touches of polish. We
16150 handle the fundamentals of if, while, do, for, return. Others are
16151 trickier and I need to start working on invocations soon.
16153 * gen-treedump.cs: Bug fix, use s.Increment here instead of
16156 * codegen.cs (EmitContext): New struct, used during code
16157 emission to keep a context. Most of the code generation will be
16160 * cs-parser.jay: Add embedded blocks to the list of statements of
16161 this block. So code generation proceeds in a top down fashion.
16163 2001-08-23 Miguel de Icaza <miguel@ximian.com>
16165 * statement.cs: Add support for multiple child blocks.
16167 2001-08-22 Miguel de Icaza <miguel@ximian.com>
16169 * codegen.cs (EmitCode): New function, will emit the code for a
16170 Block of code given a TypeContainer and its ILGenerator.
16172 * statement.cs (Block): Standard public readonly optimization.
16173 (Block::Block constructors): Link children.
16174 (Block::Child): Child Linker.
16175 (Block::EmitVariables): Emits IL variable declarations.
16177 * class.cs: Drop support for MethodGroups here, delay until
16179 (Method::): Applied the same simplification that I did before, and
16180 move from Properties to public readonly fields.
16181 (Method::ParameterTypes): Returns the parameter types for the
16182 function, and implements a cache that will be useful later when I
16183 do error checking and the semantic analysis on the methods is
16185 (Constructor::GetCallingConvention): Renamed from CallingConvetion
16186 and made a method, optional argument tells whether this is a class
16187 or a structure to apply the `has-this' bit.
16188 (Method::GetCallingConvention): Implement, returns the calling
16190 (Method::Define): Defines the type, a second pass is performed
16191 later to populate the methods.
16193 (Constructor::ParameterTypes): implement a cache similar to the
16194 one on Method::ParameterTypes, useful later when we do semantic
16197 (TypeContainer::EmitMethod): New method. Emits methods.
16199 * expression.cs: Removed MethodGroup class from here.
16201 * parameter.cs (Parameters::GetCallingConvention): new method.
16203 2001-08-21 Miguel de Icaza <miguel@ximian.com>
16205 * class.cs (TypeContainer::Populate): Drop RootContext from the
16208 (Constructor::CallingConvention): Returns the calling convention.
16209 (Constructor::ParameterTypes): Returns the constructor parameter
16212 (TypeContainer::AddConstructor): Keep track of default constructor
16213 and the default static constructor.
16215 (Constructor::) Another class that starts using `public readonly'
16216 instead of properties.
16218 (Constructor::IsDefault): Whether this is a default constructor.
16220 (Field::) use readonly public fields instead of properties also.
16222 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
16223 track of static constructors; If none is used, turn on
16224 BeforeFieldInit in the TypeAttributes.
16226 * cs-parser.jay (opt_argument_list): now the return can be null
16227 for the cases where there are no arguments.
16229 (constructor_declarator): If there is no implicit `base' or
16230 `this', then invoke the default parent constructor.
16232 * modifiers.cs (MethodAttr): New static function maps a set of
16233 modifiers flags into a MethodAttributes enum
16234 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
16235 MethodAttr, TypeAttr to represent the various mappings where the
16236 modifiers are used.
16237 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
16239 2001-08-19 Miguel de Icaza <miguel@ximian.com>
16241 * parameter.cs (GetParameterInfo): Fix bug where there would be no
16244 * interface.cs (PopulateIndexer): Implemented the code generator
16245 for interface indexers.
16247 2001-08-17 Miguel de Icaza <miguel@ximian.com>
16249 * interface.cs (InterfaceMemberBase): Now we track the new status
16252 (PopulateProperty): Implement property population. Woohoo! Got
16253 Methods and Properties going today.
16255 Removed all the properties for interfaces, and replaced them with
16256 `public readonly' fields.
16258 2001-08-16 Miguel de Icaza <miguel@ximian.com>
16260 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
16261 initialize their hashtables/arraylists only when they are needed
16262 instead of doing this always.
16264 * parameter.cs: Handle refs and out parameters.
16266 * cs-parser.jay: Use an ArrayList to construct the arguments
16267 instead of the ParameterCollection, and then cast that to a
16270 * parameter.cs: Drop the use of ParameterCollection and use
16271 instead arrays of Parameters.
16273 (GetParameterInfo): Use the Type, not the Name when resolving
16276 2001-08-13 Miguel de Icaza <miguel@ximian.com>
16278 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
16279 and instead use public readonly fields.
16281 * class.cs: Put back walking code for type containers.
16283 2001-08-11 Miguel de Icaza <miguel@ximian.com>
16285 * class.cs (MakeConstant): Code to define constants.
16287 * rootcontext.cs (LookupType): New function. Used to locate types
16290 2001-08-08 Miguel de Icaza <miguel@ximian.com>
16292 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
16293 this System.Reflection code is. Kudos to Microsoft
16295 * typemanager.cs: Implement a type cache and avoid loading all
16296 types at boot time. Wrap in LookupType the internals. This made
16297 the compiler so much faster. Wow. I rule!
16299 * driver.cs: Make sure we always load mscorlib first (for
16300 debugging purposes, nothing really important).
16302 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
16303 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
16305 * rootcontext.cs: Lookup types on their namespace; Lookup types
16306 on namespaces that have been imported using the `using' keyword.
16308 * class.cs (TypeContainer::TypeAttr): Virtualize.
16309 (Class::TypeAttr): Return attributes suitable for this bad boy.
16310 (Struct::TypeAttr): ditto.
16311 Handle nested classes.
16312 (TypeContainer::) Remove all the type visiting code, it is now
16313 replaced with the rootcontext.cs code
16315 * rootcontext.cs (GetClassBases): Added support for structs.
16317 2001-08-06 Miguel de Icaza <miguel@ximian.com>
16319 * interface.cs, statement.cs, class.cs, parameter.cs,
16320 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
16321 Drop use of TypeRefs, and use strings instead.
16323 2001-08-04 Miguel de Icaza <miguel@ximian.com>
16327 * class.cs (Struct::Struct): set the SEALED flags after
16328 checking the modifiers.
16329 (TypeContainer::TypeAttr): new property, returns the
16330 TypeAttributes for a class.
16332 * cs-parser.jay (type_list): Oops, list production was creating a
16333 new list of base types.
16335 * rootcontext.cs (StdLib): New property.
16336 (GetInterfaceTypeByName): returns an interface by type name, and
16337 encapsulates error handling here.
16338 (GetInterfaces): simplified.
16339 (ResolveTree): Encapsulated all the tree resolution here.
16340 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
16343 * driver.cs: Add support for --nostdlib, to avoid loading the
16344 default assemblies.
16345 (Main): Do not put tree resolution here.
16347 * rootcontext.cs: Beginning of the class resolution.
16349 2001-08-03 Miguel de Icaza <miguel@ximian.com>
16351 * rootcontext.cs: Provide better error reporting.
16353 * cs-parser.jay (interface_base): set our $$ to be interfaces.
16355 * rootcontext.cs (CreateInterface): Handle the case where there
16356 are no parent interfaces.
16358 (CloseTypes): Routine to flush types at the end.
16359 (CreateInterface): Track types.
16360 (GetInterfaces): Returns an array of Types from the list of
16361 defined interfaces.
16363 * typemanager.c (AddUserType): Mechanism to track user types (puts
16364 the type on the global type hash, and allows us to close it at the
16367 2001-08-02 Miguel de Icaza <miguel@ximian.com>
16369 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
16370 RecordInterface instead.
16372 * cs-parser.jay: Updated to reflect changes above.
16374 * decl.cs (Definition): Keep track of the TypeBuilder type that
16375 represents this type here. Not sure we will use it in the long
16376 run, but wont hurt for now.
16378 * driver.cs: Smaller changes to accomodate the new code.
16380 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
16383 * rootcontext.cs (CreateInterface): New method, used to create
16384 the System.TypeBuilder type for interfaces.
16385 (ResolveInterfaces): new entry point to resolve the interface
16387 (CodeGen): Property, used to keep track of the code generator.
16389 2001-07-26 Miguel de Icaza <miguel@ximian.com>
16391 * cs-parser.jay: Add a second production for delegate_declaration
16394 (enum_body): Put an opt_comma here instead of putting it on
16395 enum_body or enum_member_declarations so we can handle trailing
16396 commas on enumeration members. Gets rid of a shift/reduce.
16398 (type_list): Need a COMMA in the middle.
16400 (indexer_declaration): Tell tokenizer to recognize get/set
16402 * Remove old targets.
16404 * Re-add the parser target.
16406 2001-07-13 Simon Cozens <simon@simon-cozens.org>
16408 * cs-parser.jay: Add precendence rules for a number of operators
16409 ot reduce the number of shift/reduce conflicts in the grammar.
16411 2001-07-17 Miguel de Icaza <miguel@ximian.com>
16413 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
16416 Get rid of old crufty code.
16418 * rootcontext.cs: Use this to keep track of the parsed
16419 representation and the defined types available to the program.
16421 * gen-treedump.cs: adjust for new convention.
16423 * type.cs: Split out the type manager, and the assembly builder
16426 * typemanager.cs: the type manager will live here now.
16428 * cil-codegen.cs: And the code generator here.
16430 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
16432 * makefile: Fixed up for easy making.
16434 2001-07-13 Simon Cozens <simon@simon-cozens.org>
16436 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
16439 (unary_expression): Expand pre_increment_expression and
16440 post_decrement_expression to reduce a shift/reduce.
16442 2001-07-11 Simon Cozens
16444 * cs-tokenizer.cs: Hex numbers should begin with a 0.
16446 Improve allow_keyword_as_indent name.
16448 2001-06-19 Miguel de Icaza <miguel@ximian.com>
16450 * Adjustments for Beta2.
16452 2001-06-13 Miguel de Icaza <miguel@ximian.com>
16454 * decl.cs: Added `Define' abstract method.
16455 (InTransit): new property, used to catch recursive definitions.
16457 * interface.cs: Implement `Define'.
16459 * modifiers.cs: Map Modifiers.constants to
16460 System.Reflection.TypeAttribute flags.
16462 * class.cs: Keep track of types and user-defined types.
16463 (BuilderInit): New method for creating an assembly
16464 (ResolveType): New function to launch the resolution process, only
16465 used by interfaces for now.
16467 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
16468 that are inserted into the name space.
16470 2001-06-08 Miguel de Icaza <miguel@ximian.com>
16472 * ARGH. I have screwed up my tree so many times due to the use of
16473 rsync rather than using CVS. Going to fix this at once.
16475 * driver.cs: Objetify driver. Load assemblies, use assemblies to
16478 2001-06-07 Miguel de Icaza <miguel@ximian.com>
16480 * Experiment successful: Use System.Type rather that our own
16483 2001-05-25 Miguel de Icaza <miguel@ximian.com>
16485 * cs-parser.jay: Removed nsAliases from here.
16487 Use new namespaces, handle `using XXX;'
16489 * namespace.cs: Reimplemented namespace handling, use a recursive
16490 definition of the class. Now we can keep track of using clauses
16491 and catch invalid using clauses.
16493 2001-05-24 Miguel de Icaza <miguel@ximian.com>
16495 * gen-treedump.cs: Adapted for all the renaming.
16497 * expression.cs (Expression): this class now has a Type property
16498 which returns an expression Type.
16500 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
16501 `Type', as this has a different meaning now in the base
16503 2001-05-22 Miguel de Icaza <miguel@ximian.com>
16505 * interface.cs, class.cs: Removed from all the sources the
16506 references to signature computation, as we can not do method
16507 signature computation during the parsing time, as we are not
16508 trying to solve at that point distinguishing:
16512 void a (NS.Blah x) {}
16515 Which depending on the context might be valid or not, as we do not
16516 know if Blah is the same thing as NS.Blah at that point.
16518 * Redid everything so the code uses TypeRefs now instead of
16519 Types. TypeRefs are just temporary type placeholders, that need
16520 to be resolved. They initially have a pointer to a string and the
16521 current scope in which they are used. This is used later by the
16522 compiler to resolve the reference to an actual Type.
16524 * DeclSpace is no longer a CIR.Type, and neither are
16525 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
16526 are all DeclSpaces, but no Types.
16528 * type.cs (TypeRefManager): This implements the TypeRef manager,
16529 which keeps track of all the types that need to be resolved after
16530 the parsing has finished.
16532 2001-05-13 Miguel de Icaza <miguel@ximian.com>
16534 * ARGH. We are going to have to store `foreach' as a class rather
16535 than resolving it, as we need to verify error 1579 after name
16536 resolution. *OR* we could keep a flag that says `This request to
16537 IEnumerator comes from a foreach statement' which we can then use
16538 to generate the error.
16540 2001-05-10 Miguel de Icaza <miguel@ximian.com>
16542 * class.cs (TypeContainer.AddMethod): we now add methods to the
16543 MethodGroup instead of the method hashtable.
16545 * expression.cs: Add MethodGroup abstraction, which gets us one
16546 step closer to the specification in the way we handle method
16549 * cs-parser.jay (primary_expression): qualified_identifier now
16550 tried to match up an identifier to a local variable reference or
16551 to a parameter reference.
16553 current_local_parameters is now a parser global variable that
16554 points to the current parameters for the block, used during name
16557 (property_declaration): Now creates an implicit `value' argument to
16560 2001-05-09 Miguel de Icaza <miguel@ximian.com>
16562 * parameter.cs: Do not use `param' arguments as part of the
16563 signature, per the spec.
16565 2001-05-08 Miguel de Icaza <miguel@ximian.com>
16567 * decl.cs: Base class for classes, structs and interfaces. This
16568 is the "Declaration Space"
16570 * cs-parser.jay: Use CheckDef for checking declaration errors
16571 instead of having one on each function.
16573 * class.cs: Factor out some code for handling error handling in
16574 accordance to the "Declarations" section in the "Basic Concepts"
16575 chapter in the ECMA C# spec.
16577 * interface.cs: Make all interface member classes derive from
16578 InterfaceMemberBase.
16580 2001-05-07 Miguel de Icaza <miguel@ximian.com>
16582 * Many things: all interfaces are parsed and generated in
16583 gen-treedump. Support for member variables, constructors,
16584 destructors, properties, constants is there.
16586 Beginning of the IL backend, but very little done, just there for
16589 2001-04-29 Miguel de Icaza <miguel@ximian.com>
16591 * cs-parser.jay: Fix labeled statement.
16593 * cs-tokenizer.cs (escape): Escape " and ' always.
16594 ref_line, ref_name: keep track of the line/filename as instructed
16595 by #line by the compiler.
16598 2001-04-27 Miguel de Icaza <miguel@ximian.com>
16600 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
16601 to match the values in System.CodeDOM.
16603 Divid renamed to Divide.
16605 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
16607 (Statements.set): remove.
16609 * System.CodeDOM/CodeCatchClause.cs: always have a valid
16612 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
16613 falseStatements always have valid values.
16615 * cs-parser.jay: Use System.CodeDOM now.